Fix bug #11653 with a crash when more than 16 overlay strings are loaded.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
2f07e6af
EZ
12012-06-16 Eli Zaretskii <eliz@gnu.org>
2
3 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end. If
4 all the glyphs of the glyph row came from strings, and we have no
5 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
6 row.
7 (handle_face_prop): Use chunk-relative overlay string index when
8 indexing into it->string_overlays array. (Bug#11653)
2f07e6af 9
29b83cec
AS
102012-06-16 Andreas Schwab <schwab@linux-m68k.org>
11
12 * category.h (CHAR_HAS_CATEGORY): Define as inline.
13 (CATEGORY_MEMBER): Enforce 1/0 value.
14 * category.c (_temp_category_set): Remove.
15
4c5501e9
EZ
162012-06-16 Eli Zaretskii <eliz@gnu.org>
17
18 * window.c (Fdelete_other_windows_internal)
19 (Fdelete_window_internal): Don't access frame's mouse highlight
20 info of the initial frame. (Bug#11677)
21
2b570124
PE
222012-06-14 Paul Eggert <eggert@cs.ucla.edu>
23
e93864f9
PE
24 * .gdbinit (xgetint): Fix recently-introduced paren typo.
25 Assume USE_2_TAGS_FOR_INTS.
26 (xreload): Adjust $tagmask width to match recent lisp.h change.
27
2b570124
PE
28 Simplify lisp.h in minor ways that should not affect code.
29 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
30 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
31 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
32 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
33 (INTTYPEBITS): New macro, for clarity.
34 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
35 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P): Simplify
36 now that USE_LSB_TAG is always defined.
37 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
38 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
39
81755f69
JB
402012-06-13 Juanma Barranquero <lekktu@gmail.com>
41
42 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
43
16192a57
GM
442012-06-13 Glenn Morris <rgm@gnu.org>
45
46 * s/bsd-common.h (BSD4_3):
47 * s/usg5-4-common.h (USG5_4): No longer define; unused.
48
646b5f55
AS
492012-06-13 Andreas Schwab <schwab@linux-m68k.org>
50
51 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
52 instead of union.
53 (XLI, XIL): Define.
54 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG): Use
55 them.
56 * emacs.c (gdb_use_struct): Renamed from gdb_use_union.
57 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
58 * alloc.c (widen_to_Lisp_Object): Removed.
59 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
60 * frame.c (delete_frame): Remove outdated comment.
61 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
62 USE_LISP_UNION_TYPE.
63 (Fw32_unregister_hot_key): Likewise.
64 (Fw32_toggle_lock_key): Likewise.
65 * w32menu.c (add_menu_item): Likewise.
66 (w32_menu_display_help): Use XIL instead of checking
67 USE_LISP_UNION_TYPE.
68 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
69 (init_heap): Likewise.
70 * w32term.c (w32_read_socket): Update comment.
71
1d3823c9
GM
722012-06-13 Glenn Morris <rgm@gnu.org>
73
c62ff706
GM
74 * s/usg5-4-common.h, src/s/unixware.h:
75 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
76
1d3823c9
GM
77 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
78
bfe3e0a2
PE
792012-06-13 Paul Eggert <eggert@cs.ucla.edu>
80
81 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
82 * alloc.c (make_number) [!defined make_number]:
83 Remove, as lisp.h always defines this now.
84 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
85 (roundup_size): Verify that it is a power of 2.
86 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
87 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
88 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
89 -DUSE_LSB_TAG=0, to override the automatically-selected default.
90 USE_LSB_TAG now is always defined to be either 0 or 1.
91 All uses changed.
92 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
93 code works fine either way, and efficiency is not a concern here,
94 as the union type is for debugging, not for production.
95 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
96 Use an inline function on all platforms when using the union type,
97 since this is simpler and 'static inline' can be used portably
98 within Emacs now.
99 (LISP_INITIALLY_ZERO): New macro.
100 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
101 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
102
45fa9c0f
GM
1032012-06-12 Glenn Morris <rgm@gnu.org>
104
b4492cba
GM
105 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
106
107 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 108
45fa9c0f
GM
109 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
110 Move BROKEN_SIGIO to configure.
111
112 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
113 Move NO_TERMIO to configure.
114
0e25d334
CY
1152012-06-12 Chong Yidong <cyd@gnu.org>
116
117 * image.c (imagemagick_load_image): Use MagickFlattenImage if
118 MagickMergeImageLayers is undefined. Use pixel pusher loop if
119 MagickExportImagePixels is undefined.
120
43682bb6
PE
1212012-06-12 Paul Eggert <eggert@cs.ucla.edu>
122
123 * image.c (imagemagick_load_image): Remove unused label.
124
a9be7d2b
GM
1252012-06-11 Glenn Morris <rgm@gnu.org>
126
127 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
128 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
129 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
130 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
131
3017f87f
SM
1322012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
133
134 * alloc.c (make_byte_code): New function.
135 (Fmake_byte_code): Use it. Don't purify here.
136 * lread.c (read1): Use it as well to avoid extra allocation.
137
1b9b4cf4
CY
1382012-06-11 Chong Yidong <cyd@gnu.org>
139
140 * image.c (imagemagick_load_image): Implement transparency.
141
95988fcf
AS
1422012-06-10 Andreas Schwab <schwab@linux-m68k.org>
143
144 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
145 account for preceding backslashes. (Bug#11663)
146
cd4eb164
CY
1472012-06-09 Chong Yidong <cyd@gnu.org>
148
149 * term.c: Support italics in capable terminals (Bug#9652).
150 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
151 (turn_on_face): Output using TS_enter_italic_mode if available.
152 Don't handle unused blinking and alt-charset cases.
153 (turn_off_face): Handle italic case; discard unused tty_blinking_p
154 and tty_alt_charset_p cases.
155 (tty_capable_p, init_tty): Support italics.
156
157 * termchar.h (struct tty_display_info): Add field for italics.
158 Remove unused blink field.
159
160 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
161 Handle slant.
162
163 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
164 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
165 tty_alt_charset_p. Add tty_italic_p.
166
ff88beb8
MA
1672012-06-09 Michael Albinus <michael.albinus@gmx.de>
168
169 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
170 dbus_type_is_basic if available.
171 (xd_extract_signed, xd_extract_unsigned): Rename from
172 extract_signed and extract_unsigned, respectively. Adapt callers.
173
44286096
CY
1742012-06-09 Chong Yidong <cyd@gnu.org>
175
1682701f
CY
176 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
177
44286096
CY
178 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
179 case (Bug#9752).
180
d86feb17
PE
1812012-06-08 Paul Eggert <eggert@cs.ucla.edu>
182
183 * xdisp.c (vmessage): Treat frame message as multibyte.
184 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
185 would generate the diagnostic "Making \302\247 buffer-local while
186 let-bound!".
187
d5c20fe8
EZ
1882012-06-08 Eli Zaretskii <eliz@gnu.org>
189
190 * dispnew.c (showing_window_margins_p): Undo last change, which
191 was done due to an inadvertent commit.
192 (adjust_frame_glyphs_for_frame_redisplay): Do call
193 showing_window_margins_p.
194
513749ee
SM
1952012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
196
197 * eval.c (Fmake_var_non_special): New primitive.
198 (syms_of_eval): Defsubr it.
199 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
200
d4a8f5c1
JB
2012012-06-08 Juanma Barranquero <lekktu@gmail.com>
202
203 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
204 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
205
8bbbc977
EZ
2062012-06-08 Eli Zaretskii <eliz@gnu.org>
207
208 * alloc.c (allocate_vectorlike): Fix last change.
209
f3372c87
DA
2102012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
211
212 Block-based vector allocation of small vectors.
213 * lisp.h (struct vectorlike_header): New field `nbytes',
214 adjust comment accordingly.
215 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
216 to denote vector blocks. Adjust users (live_vector_p,
217 mark_maybe_pointer, valid_lisp_object_p) accordingly.
218 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
219 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
220 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
221 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
222 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
223 (roundup_size): New constant.
224 (struct vector_block): New data type.
225 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 226 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
227 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
228 (sweep_vectors): New functions.
229 (allocate_vectorlike): Return `zero_vector' as the only vector of
230 0 items. Allocate new vector from block if vector size is less than
231 or equal to VBLOCK_BYTES_MAX.
232 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
233 (init_alloc_once): Add call to init_vectors.
234
4f18a4ed
SM
2352012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
236
237 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
238
86f158bc
PE
2392012-06-07 Paul Eggert <eggert@cs.ucla.edu>
240
241 * doprnt.c (doprnt): Truncate multibyte char correctly.
242 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
243 would mishandle a string argument "Xc" if X was a multibyte
244 character of length 2: it would truncate after X's first byte
245 rather than including all of X.
246
c5cfcbe0
CY
2472012-06-06 Chong Yidong <cyd@gnu.org>
248
249 * buffer.c (word_wrap): Doc fix.
250
c05cf390
PE
2512012-06-04 Paul Eggert <eggert@cs.ucla.edu>
252
253 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
254
0c3461de
GM
2552012-06-03 Glenn Morris <rgm@gnu.org>
256
257 * xdisp.c (tool-bar-style): Doc fix.
258
c71232db
UM
2592012-06-03 Ulrich Müller <ulm@gentoo.org>
260
261 * Makefile.in (PAXCTL): Define.
262 (temacs$(EXEEXT)): Disable memory randomization for the temacs
263 binary via PaX flags if the paxctl utility is available.
264 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
265 Restore PaX flags to their default. (Bug#11398)
266
383f7350
CY
2672012-06-03 Chong Yidong <cyd@gnu.org>
268
269 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
270 buffer (Bug#11226).
271
5f2c76c6
CY
2722012-06-03 Chong Yidong <cyd@gnu.org>
273
274 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
275 (note_mode_line_or_margin_highlight): If there is no help echo,
276 use mode-line-default-help-echo. Handle the case where the mouse
277 position is past the end of the mode line string.
278
279 * buffer.c (buffer_local_value_1): New function, split from
280 Fbuffer_local_value; can return Qunbound.
281 (Fbuffer_local_value): Use it.
282 (Vmode_line_format): Docstring tweaks.
283
773d47f6
PE
2842012-06-02 Paul Eggert <eggert@cs.ucla.edu>
285
286 * sysdep.c (system_process_attributes): Improve comment.
287
f2d6a3df
SM
2882012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
289
290 * keyboard.c: Export real-this-command to Elisp.
291 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
292 and DEFVAR it. Update all users.
293
63810350
PE
2942012-06-02 Paul Eggert <eggert@cs.ucla.edu>
295
7bd5c1f4
PE
296 * minibuf.c (Fassoc_string): Remove duplicate declaration.
297
63810350
PE
298 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
299 Convert pctcpu and pctmem to Lisp float properly.
300 Let the compiler fold better, as 100.0/0x8000 is exact.
301
a2821611
AS
3022012-06-02 Andreas Schwab <schwab@linux-m68k.org>
303
304 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
305 cons_block.
306
5fceba1d
PE
3072012-06-01 Paul Eggert <eggert@cs.ucla.edu>
308
309 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
310
c98ff5dd
DA
3112012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
312
313 For a 'struct window', replace some Lisp_Object fields to
314 bitfields where appropriate, remove unused fields.
315 * window.h (struct window): Remove unused 'last_mark_x' and
316 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
317 change it's type from Lisp_Object to bitfield.
318 Change type of 'force_start', 'optional_new_start',
319 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
320 fields from Lisp_Object to bitfield. Adjust users accordingly.
321
ca34e0be
PE
3222012-05-31 Paul Eggert <eggert@cs.ucla.edu>
323
324 Pacify gcc -Wdouble-precision when using Xaw.
325 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
326 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
327 Use 'float' consistently, rather than 'float' in most places
328 and 'double' in a couple of places.
329
efc00ab1 3302012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
331
332 * xdisp.c (handle_stop): Detect whether we have overlay strings
333 loaded by testing it->current.overlay_string_index to be
334 non-negative, instead of checking whether n_overlay_strings is
335 positive. (Bug#11587)
336
efc00ab1 3372012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
338
339 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
340
341 * doc.c (Fsubstitute_command_keys): Doc fix.
342
efc00ab1 3432012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
344
345 * search.c (search_buffer): Remove calls to
346 r_alloc_inhibit_buffer_relocation, as it is now called by
347 maybe_unify_char, which was the cause of relocation of buffer text
348 in bug#11519.
349
efc00ab1 3502012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
351
352 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
353 for the duration of call to load_charset, to avoid problems with
354 callers of maybe_unify_char that access buffer text through C
355 pointers.
356
357 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
358 decrement the inhibition flag, instead of just setting or
359 resetting it.
360
ba93a187
PE
3612012-05-31 Paul Eggert <eggert@cs.ucla.edu>
362
363 Remove obsolete '#define static' cruft.
364 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
365 This #undef was "temporary" in 2000; it is no longer needed
366 now that '#define static' has gone away.
367 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
368 (gray_bitmap_bits): Remove; no longer needed.
369 All uses replaced with definiens.
370 * xterm.c: Include "bitmaps/gray.xbm".
371
9e4bf381
PE
3722012-05-30 Paul Eggert <eggert@cs.ucla.edu>
373
374 Clean up __executable_start, monstartup when --enable-profiling.
375 The following changes affect the code only when profiling.
376 * dispnew.c (__executable_start): Rename from safe_bcopy.
377 Define only on platforms that need it.
378 * emacs.c: Include <sys/gmon.h> when profiling.
379 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
380 (__executable_start): Remove decl, since lisp.h does it now.
381 (safe_bcopy): Remove decl; no longer has that name.
382 (main): Coalesce #if into single bit of code, for simplicity.
383 Cast pointers to uintptr_t, since standard libraries want integers
384 and not pointers.
385 * lisp.h (__executable_start): New decl.
386
32d72c2f
GM
3872012-05-31 Glenn Morris <rgm@gnu.org>
388
389 * image.c (Fimagemagick_types): Doc fix.
390
baac5bc7
JM
3912012-05-30 Jim Meyering <meyering@redhat.com>
392
393 * callproc.c (Fcall_process_region): Include directory component
394 in mkstemp error message (Bug#11586).
395
72cb32cf
PE
3962012-05-30 Paul Eggert <eggert@cs.ucla.edu>
397
398 * alloc.c, lisp.h (make_pure_vector): Now static.
399
61b108cc
SM
4002012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
401
402 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
403 Move to byte-run.el.
404 (Fautoload): Do the hash-doc more carefully.
405 * data.c (Fdefalias): Purify definition, except for keymaps.
406 (Qdefun): Move from eval.c.
407 * lisp.h (Qdefun): Remove.
408 * lread.c (read1): Tiny simplification.
409
471fe23d
TN
4102012-05-29 Troels Nielsen <bn.troels@gmail.com>
411
934f3f58 412 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
413 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
414 Bug#9642, but explicitly check that the buffer the overlay would
415 be moved to is live and rearrange lines to make sure that errors
416 will not put the overlay in an inconsistent state.
417 (Fdelete_overlay): Cosmetics.
418
85d0efd1
EZ
4192012-05-28 Eli Zaretskii <eliz@gnu.org>
420
421 * w32term.c (my_bring_window_to_top): New function.
422 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
423 could be different from the original one.
424 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
425 (Bug#11513)
426
427 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
428 by calling BringWindowToTop.
429
430 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
431 (WM_EMACS_END): Increase by one.
432
da92a98c
PE
4332012-05-28 Paul Eggert <eggert@cs.ucla.edu>
434
435 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
436 This avoids undefined behavior that might cause the eassert
437 to not catch an out-of-range value.
438
74d1f848
JB
4392012-05-28 Juanma Barranquero <lekktu@gmail.com>
440
441 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
442 Update dependencies.
443
9e1a06fc
EZ
4442012-05-27 Eli Zaretskii <eliz@gnu.org>
445
446 * bidi.c (bidi_mirror_char): Fix last change.
447
f3dd7312
AS
4482012-05-27 Andreas Schwab <schwab@linux-m68k.org>
449
450 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
451 when referring to sectname field in printf format.
452
81899c91
PE
4532012-05-27 Paul Eggert <eggert@cs.ucla.edu>
454
57b81a9f
PE
455 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
456 Only r_alloc_inhibit_buffer_relocation needed to be added;
457 the others were already declared.
458
81899c91
PE
459 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
460 before checking whether it's out of range. Put the check inside
461 eassert. See
462 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
463
33017faf 4642012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
465
466 * callproc.c (Fcall_process): Restore a line that was accidentally
467 commented out in the 2011-02-13 change (bug#11547).
468
33017faf 4692012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
470
471 * lisp.h [REL_ALLOC]: Add prototypes for external functions
472 defined on ralloc.c.
473
474 * buffer.c [REL_ALLOC]: Remove prototypes of
475 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
476 they are now on lisp.h.
477
478 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
479
480 * search.c (search_buffer): Use it to inhibit relocation of buffer
481 text while re_search_2 is doing its job, because re_search_2 is
482 passed C pointers to buffer text. (Bug#11519)
483
23415acf
EZ
484 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
485 Update value to 24.
486
44e27368
EZ
487 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
488 state after an additional call to move_it_in_display_line_to, keep
489 the values of it->max_ascent and it->max_descent found for the
490 entire line.
491 (pos_visible_p): Revert the comparison against bottom_y to what it
492 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
493 (Bug#11464)
494
c1892f11
PE
4952012-05-26 Paul Eggert <eggert@cs.ucla.edu>
496
497 Fix coding-related core dumps with gcc -ftrapv.
498 The code was computing A - B, where A and B are pointers, and B is
499 random garbage. This can lead to core dumps on platforms that
500 have special pointer registers, and it also leads to core dumps on
501 x86-64 when compiled with gcc -ftrapv. The fix is to compute
502 A - B only when B is initialized properly.
503 * coding.c (coding_set_source, coding_set_destination): Return void.
504 (coding_change_source, coding_change_destinations): New functions,
505 with the old behaviors of coding_set_source and coding_set_destination.
506 All callers that need an offset changed to use these new functions.
507
eb7afdad
GM
5082012-05-26 Glenn Morris <rgm@gnu.org>
509
510 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
511
f12fdf02
EZ
5122012-05-26 Eli Zaretskii <eliz@gnu.org>
513
53a63be6 514 Extend mouse support on W32 text-mode console.
61b108cc
SM
515 * xdisp.c (draw_row_with_mouse_face):
516 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 517
eb3f6f01 518 * w32console.c: Include window.h.
61b108cc
SM
519 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
520 New functions.
eb3f6f01
EZ
521 (initialize_w32_display): Initialize mouse-highlight data.
522
53a63be6
EZ
523 * w32inevt.c: Include termchar.h and window.h.
524 (do_mouse_event): Support mouse-autoselect-window. When the mouse
525 moves, call note_mouse_highlight. If help_echo changed, call
526 gen_help_event to produce help-echo message in the echo area.
527 Call clear_mouse_face if mouse_face_hidden is set in the mouse
528 highlight info.
529
4cfd81f6
PE
5302012-05-26 Paul Eggert <eggert@cs.ucla.edu>
531
532 * lread.c (read1): Simplify slightly to avoid an overflow warning
533 with GCC 4.7.0 on x86-64.
534
4446092a
EZ
5352012-05-26 Eli Zaretskii <eliz@gnu.org>
536
537 * bidi.c (bidi_mirror_char): Revert last change: an int is
538 definitely wide enough here.
539
42b2a986 5402012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 541
42b2a986 542 Fix integer width and related bugs (Bug#9874).
eb106a49 543 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
544 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
545 (string_bytes, check_sblock, allocate_string_data):
546 (compact_small_strings, Fmake_bool_vector, make_string)
547 (make_unibyte_string, make_multibyte_string)
548 (make_string_from_bytes, make_specified_string)
549 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
550 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
551 (mark_vectorlike):
552 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
553 (allocate_pseudovector):
554 Use int, not EMACS_INT, where int is wide enough.
555 (inhibit_garbage_collection, Fgarbage_collect):
556 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
557 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
558 int might not be wide enough.
559 (bidi_cache_search, bidi_cache_find, bidi_init_it)
560 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
561 (bidi_at_paragraph_end, bidi_find_paragraph_start)
562 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
563 (bidi_level_of_next_char, bidi_move_to_visually_next):
564 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
565 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
566 (Fkill_buffer, Fset_buffer_major_mode)
567 (advance_to_char_boundary, Fbuffer_swap_text)
568 (Fset_buffer_multibyte, overlays_at, overlays_in)
569 (overlay_touches_p, struct sortvec, record_overlay_string)
570 (overlay_strings, recenter_overlay_lists)
571 (adjust_overlays_for_insert, adjust_overlays_for_delete)
572 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
573 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
574 (Foverlay_recenter, last_overlay_modification_hooks_used)
575 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
576 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
577 (validate_region): Omit unnecessary test for b <= e,
578 since that's guaranteed by the previous test.
d311d28c
PE
579 (adjust_overlays_for_delete): Avoid pos + length overflow.
580 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
581 (report_overlay_modification):
582 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
583 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
584 Omit pointer cast, which isn't needed anyway, and doesn't work
585 after the EMACS_INT -> ptrdiff_t change.
02481186 586 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
587 * buffer.h: Adjust decls to match defn changes elsewhere.
588 (struct buffer_text, struct buffer):
589 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
590 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
591 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
592 not int, to avoid needless 32-bit limit on 64-bit hosts.
593 (exec_byte_code): Use tighter memory-full test, one that checks
594 for alloca overflow. Don't compute the address of the object just
595 before an array, as that's not portable. Use EMACS_INT, not
596 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
597 * callint.c (Fcall_interactively):
598 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
599 * callproc.c (call_process_kill, Fcall_process):
600 Don't assume pid_t fits into an Emacs fixnum.
601 (call_process_cleanup, Fcall_process, child_setup):
602 Don't assume pid_t fits into int.
603 (call_process_cleanup, Fcall_process, delete_temp_file)
604 (Fcall_process_region):
605 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
606 (Fcall_process): Simplify handling of volatile integers.
607 Use int, not EMACS_INT, where int will do.
608 * casefiddle.c (casify_object, casify_region, operate_on_word)
609 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
610 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
611 (casify_object): Avoid integer overflow when overallocating buffer.
612 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 613 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
614 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
615 * category.h (CATEGORYP): Don't assume arg is nonnegative.
616 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
617 integers are now checked earlier. All uses replaced with XINT.
618 (ccl_driver):
619 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
620 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
621 (ccl_driver, Fregister_code_conversion_map):
622 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
623 (resolve_symbol_ccl_program): Check that vector header is in range.
624 Always copy the vector, so that we can check its contents reliably
625 now rather than having to recheck each instruction as it's being
626 executed. Check that vector words fit in 'int'.
627 (ccl_get_compiled_code, Fregister_ccl_program)
628 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
629 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
630 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
631 contents are in range.
632 (Fccl_execute_on_string): Check that status is in range.
633 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
634 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
635 Accept and return EMACS_INT, not int, because callers can pass values
636 out of 'int' range.
637 (c_string_width, strwidth, lisp_string_width, chars_in_text)
638 (multibyte_chars_in_text, parse_str_as_multibyte)
639 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
640 (str_as_unibyte, str_to_unibyte, string_count_byte8)
641 (string_escape_byte8, Fget_byte):
642 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 643 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
644 avoid mishandling large integers.
645 * character.h: Adjust decls to match defn changes elsewhere.
646 * charset.c (load_charset_map_from_file, find_charsets_in_text)
647 (Ffind_charset_region):
648 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
649 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
650 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 651 Don't assume fixnum fits in int.
d311d28c
PE
652 (load_charset_map_from_vector, Fmap_charset_chars):
653 Remove now-unnecessary CHECK_NATNUMs.
654 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
655 Don't rely on undefined behavior with signed left shift overflow.
656 Don't assume unsigned int fits into fixnum, or that fixnum fits
657 into unsigned int. Don't require max_code to be a valid fixnum;
658 that's not true for gb10830 4-byte on a 32-bit host. Allow
659 invalid_code to be a cons, for the same reason. Require code_offset
660 to be a character. Avoid int overflow if max_char is close
661 to INT_MAX.
662 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
663 this is intended anyway and avoids some undefined behavior.
664 (load_charset_map): Pass unsigned, not int, as 2nd arg of
665 INDEX_TO_CODE_POINT, as that's what it expects.
666 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
667 * charset.h (DECODE_CHAR): Return int, not unsigned;
668 this is what was intended anyway, and it avoids undefined behavior.
669 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
670 integer-overflow issues.
671 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
672 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
673 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
674 * chartab.c (Fmake_char_table, Fset_char_table_range)
675 (uniprop_get_decoder, uniprop_get_encoder):
676 Don't assume fixnum fits in int.
677 * cmds.c (move_point): New function, that does the gist of
678 Fforward_char and Fbackward_char, but does so while checking
679 for integer overflow more accurately.
c96e5d6a 680 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
681 (Fforward_line, Fend_of_line, internal_self_insert)
682 (internal_self_insert):
683 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
684 Fix a FIXME, by checking for integer overflow when calculating
685 target_clm and actual_clm.
686 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 687 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
688 (ASSURE_DESTINATION, coding_alloc_by_realloc)
689 (coding_alloc_by_making_gap, alloc_destination)
690 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
691 (encode_coding_utf_16, detect_coding_emacs_mule)
692 (decode_coding_emacs_mule, encode_coding_emacs_mule)
693 (detect_coding_iso_2022, decode_coding_iso_2022)
694 (encode_invocation_designation, encode_designation_at_bol)
695 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
696 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
697 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
698 (encode_coding_ccl, encode_coding_raw_text)
699 (detect_coding_charset, decode_coding_charset)
700 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
701 (produce_composition, produce_charset, produce_annotation)
702 (decode_coding, handle_composition_annotation)
703 (handle_charset_annotation, consume_chars, decode_coding_gap)
704 (decode_coding_object, encode_coding_object, detect_coding_system)
705 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
706 (code_convert_region, code_convert_string)
8f50130c
PE
707 (Fdefine_coding_system_internal)
708 (coding_set_source, coding_set_destination):
d311d28c
PE
709 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
710 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
711 (Fdefine_coding_system_internal):
712 Don't assume fixnums fit in int.
713 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 714 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
715 (Funencodable_char_position, Fcheck_coding_systems_region)
716 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 717 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 718 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 719 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 720 Don't access memory outside of the args array.
d311d28c 721 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
722 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
723 result of ENCODE_CHAR.
d311d28c
PE
724 * coding.h: Adjust decls to match defn changes elsewhere.
725 (struct coding_system):
726 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
727 * composite.c (get_composition_id, find_composition)
728 (run_composition_function, update_compositions)
729 (compose_text, composition_gstring_put_cache)
730 (composition_gstring_p, composition_gstring_width)
731 (fill_gstring_header, fill_gstring_body, autocmp_chars)
732 (composition_compute_stop_pos, composition_reseat_it)
733 (composition_update_it, struct position_record)
734 (find_automatic_composition, composition_adjust_point)
735 (Fcomposition_get_gstring, Ffind_composition_internal):
736 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
737 (update_compositions):
738 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
739 * composite.h: Adjust decls to match defn changes elsewhere.
740 (struct composition):
741 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
742 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
743 Do not attempt to compute the address of the object just before a
744 buffer; this is not portable.
745 (Faref, Faset):
746 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
747 (Faset): Use int, not EMACS_INT, where int is wide enough.
748 (Fstring_to_number): Don't assume fixnums fit in int.
749 (Frem): Don't assume arg is nonnegative.
750 * dbusbind.c (xd_append_arg): Check for integers out of range.
751 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 752 (extract_signed, extract_unsigned): New functions.
243e0530
PE
753 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
754 (xd_get_connection_references): Return ptrdiff_t, not int.
755 All uses changed.
756 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
757 (xd_read_message_1):
758 Use int, not unsigned, where the dbus API uses int.
759 (Fdbus_message_internal): Don't overflow mtype.
760 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
761 * dired.c (directory_files_internal, file_name_completion, scmp)
762 (file_name_completion_stat):
763 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
764 (file_name_completion): Don't overflow matchcount.
765 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
766 * dispextern.h: Adjust decls to match defn changes elsewhere.
767 (struct text_pos, struct glyph, struct bidi_saved_info)
768 (struct bidi_string_data, struct bidi_it, struct composition_it)
769 (struct it):
770 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
771 (struct display_pos, struct composition_it, struct it):
772 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
773 * dispnew.c (increment_matrix_positions)
774 (increment_row_positions, mode_line_string)
775 (marginal_area_string):
776 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 777 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
778 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
779 (duration_to_sec_usec): New function, to check for overflow better.
780 (Fsleep_for, sit_for): Use it.
781 * doc.c (get_doc_string, store_function_docstring):
782 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
783 (get_doc_string, Fsnarf_documentation):
784 Use int, not EMACS_INT, where int is wide enough.
785 (get_doc_string):
786 Use SAFE_ALLOCA, not alloca.
787 Check for overflow when converting EMACS_INT to off_t.
788 * doprnt.c (doprnt):
789 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
790 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
791 Don't assume uid_t fits into fixnum.
792 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
793 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
794 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
795 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
796 (general_insert_function)
797 (Finsert_char, make_buffer_string, make_buffer_string_both)
798 (update_buffer_properties, Fbuffer_substring)
799 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
800 (Fsubst_char_in_region, check_translation)
801 (Ftranslate_region_internal, save_restriction_restore, Fformat)
802 (transpose_markers, Ftranspose_regions):
803 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
804 (clip_to_bounds): Move to lisp.h as an inline function).
805 (Fconstrain_to_field): Don't assume integers are nonnegative.
806 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
807 (Fsubst_char_in_region, Fsave_restriction):
808 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
809 (Femacs_pid): Don't assume pid_t fits into fixnum.
810 (lo_time): Use int, not EMACS_INT, when int suffices.
811 (lisp_time_argument): Check for usec out of range.
812 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
813 (Fuser_login_name, Fuser_full_name): Signal an error
814 if a uid argument is out of range, rather than relying on
815 undefined behavior.
c8d5c857
PE
816 (Fformat_time_string): Remove now-unnecessary check.
817 lisp_time_argument checks for out-of-range usec now.
243e0530 818 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
819 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
820 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
821 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
822 (init_cmdargs, Fdump_emacs):
823 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
824 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
825 the bottom (typically) 32 bits of the fixnum.
826 * eval.c (specpdl_size, call_debugger):
827 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
828 (when_entered_debugger, Fbacktrace_debug):
829 Don't assume fixnum can fit in int.
830 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
831 the object just before a buffer; this is not portable.
832 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
833 (grow_specpdl, unbind_to):
834 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
835 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
836 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 837 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
838 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
839 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
840 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
841 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
842 (a_write, e_write):
843 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
844 (Fcopy_file, non_regular_nbytes, read_non_regular)
845 (Finsert_file_contents):
846 Use int, not EMACS_INT, where int is wide enough.
847 (READ_BUF_SIZE): Verify that it fits in int.
848 (Finsert_file_contents): Check that counts are in proper range,
849 rather than assuming fixnums fit into ptrdiff_t etc.
850 Don't assume fixnums fit into int.
125b3835 851 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
852 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
853 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
854 (string_char_to_byte, string_byte_to_char)
855 (string_make_multibyte, string_to_multibyte)
856 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
857 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
858 (substring_both, Fdelete, internal_equal, Ffillarray)
859 (Fclear_string, mapcar1)
860 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
861 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
862 (larger_vector, make_hash_table, maybe_resize_hash_table)
863 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
864 (Fmaphash, secure_hash):
865 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
866 (concat): Check for string index and length overflow.
867 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
868 (Frequire):
869 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
870 (larger_vector): New API (vec, incr_min, size_max) replaces old
871 one (vec, new_size, init). This catches size overflow.
872 INIT was removed because it was always Qnil.
873 All callers changed.
874 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
875 the upper bound on a hash table index size.
876 (make_hash_table, maybe_resize_hash_table): Use it.
877 (secure_hash): Computer start_byte and end_byte only after
878 they're known to be in ptrdiff_t range.
879 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
880 (Ffont_get_glyphs, Ffont_at):
881 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
882 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
883 (Flist_fonts, Fopen_font):
884 Don't assume fixnum can fit in int.
885 (check_gstring): Don't assume index can fit in int.
886 (font_match_p): Check that fixnum is a character, not a nonnegative
887 fixnum, since the later code needs to stuff it into an int.
888 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
889 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
890 conversion overflow issues.
891 (Fopen_font): Check for integer out of range.
892 (Ffont_get_glyphs): Don't assume index can fit in int.
893 * font.h: Adjust decls to match defn changes elsewhere.
894 * fontset.c (reorder_font_vector): Redo score calculation to avoid
895 integer overflow.
896 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
897 printmax_t, where ptrdiff_t is wide enough.
898 (Finternal_char_font):
899 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
900 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
901 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
902 (Fset_frame_position, x_set_frame_parameters)
903 (x_set_line_spacing, x_set_border_width)
904 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
905 Check that fixnums are in proper range for system types.
906 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
907 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
908 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
909 Use SAFE_ALLOCA_LISP, not alloca.
910 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
911 intptr_t is wide enough.
912 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
913 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
914 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
915 Check for fixnum out of range.
916 * ftfont.c (ftfont_list): Don't assume index fits in int.
917 Check that fixnums are in proper range for system types.
918 (ftfont_shape_by_flt):
919 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
920 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
921 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
922 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
923 Check that fixnums are in proper range for system types.
924 * gnutls.h: Adjust decls to match defn changes elsewhere.
925 * gtkutil.c (xg_dialog_run):
926 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
927 (update_frame_tool_bar):
928 Check that fixnums are in proper range for system types.
929 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 930 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
931 * indent.c (last_known_column, last_known_column_point):
932 (current_column_bol_cache):
933 (skip_invisible, current_column, check_display_width):
934 (check_display_width, scan_for_column, current_column_1)
935 (Findent_to, Fcurrent_indentation, position_indentation)
936 (indented_beyond_p, Fmove_to_column, compute_motion):
937 (Fcompute_motion, Fvertical_motion):
938 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
939 (last_known_column_modified): Use EMACS_INT, not int.
940 (check_display_width):
941 (Fcompute_motion):
942 Check that fixnums and floats are in proper range for system types.
943 (compute_motion): Don't assume index or fixnum fits in int.
944 (compute_motion, Fcompute_motion):
945 Use int, not EMACS_INT, when it is wide enough.
946 (vmotion): Omit local var start_hpos that is always 0; that way
947 we don't need to worry about overflow in expressions involving it.
948 * indent.h: Adjust decls to match defn changes elsewhere.
949 (struct position):
950 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
951 Use int, not EMACS_INT, where int is wide enough.
952 Remove unused members ovstring_chars_done and tab_offset;
953 all uses removed.
954 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
955 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
956 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
957 (make_gap, copy_text, insert, insert_and_inherit)
958 (insert_before_markers, insert_before_markers_and_inherit)
959 (insert_1, count_combining_before, count_combining_after)
960 (insert_1_both, insert_from_string)
961 (insert_from_string_before_markers, insert_from_string_1)
962 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
963 (adjust_after_replace, adjust_after_insert, replace_range)
964 (replace_range_2, del_range, del_range_1, del_range_byte)
965 (del_range_both, del_range_2, modify_region)
966 (prepare_to_modify_buffer, signal_before_change)
967 (signal_after_change, Fcombine_after_change_execute):
968 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
969 * intervals.c (traverse_intervals, rotate_right, rotate_left)
970 (balance_an_interval, split_interval_right, split_interval_left)
971 (find_interval, next_interval, update_interval)
972 (adjust_intervals_for_insertion, delete_node, delete_interval)
973 (interval_deletion_adjustment, adjust_intervals_for_deletion)
974 (static_offset_intervals, offset_intervals)
975 (merge_interval_right, merge_interval_left, make_new_interval)
976 (graft_intervals_into_buffer, temp_set_point_both)
977 (temp_set_point, set_point, adjust_for_invis_intang)
978 (set_point_both, move_if_not_intangible, get_property_and_range)
979 (get_local_map, copy_intervals, copy_intervals_to_string)
980 (compare_string_intervals, set_intervals_multibyte_1):
981 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
982 * intervals.h: Adjust decls to match defn changes elsewhere.
983 (struct interval):
984 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
985 * keyboard.c (this_command_key_count, this_single_command_key_start)
986 (before_command_key_count, before_command_echo_length, echo_now)
987 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
988 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
989 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
990 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
991 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
992 (last_non_minibuf_size, last_point_position, echo_truncate)
993 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
994 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
995 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
996 (stuff_buffered_input):
997 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
998 (last_auto_save, command_loop_1, read_char):
999 Use EMACS_INT, not int, to avoid integer overflow.
1000 (record_char): Avoid overflow in total_keys computation.
1001 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
1002 * keyboard.h: Adjust decls to match defn changes elsewhere.
1003 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
1004 (Fkey_description, Fdescribe_vector, Flookup_key):
1005 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1006 (click_position): New function, to check that positions are in range.
1007 (Fcurrent_active_maps):
1008 (describe_command):
1009 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1010 (Faccessible_keymaps, Fkey_description):
1011 (preferred_sequence_p):
1012 Don't assume fixnum can fit into int.
1013 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
1014 Check for integer overflow in size calculations.
1015 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
1016 avoid mishandling large integers.
1017 * lisp.h: Adjust decls to match defn changes elsewhere.
1018 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
1019 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
1020 (struct Lisp_Marker):
1021 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1022 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
1023 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
1024 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
1025 All callers changed.
1026 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
1027 Assume the arg has valid form, since it always does.
1028 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
1029 unsigned integer system type.
1030 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
1031 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
1032 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1033 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
1034 (duration_to_sec_usec): New decl.
1035 * lread.c (read_from_string_index, read_from_string_index_byte)
1036 (read_from_string_limit, readchar, unreadchar, openp)
1037 (read_internal_start, read1, oblookup):
1038 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1039 (Fload, readevalloop, Feval_buffer, Feval_region):
1040 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1041 (openp): Check for out-of-range argument to 'access'.
1042 (read1): Use int, not EMACS_INT, where int is wide enough.
1043 Don't assume fixnum fits into int.
6efdadfd 1044 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
1045 (read_filtered_event): Use duration_to_sec_usec
1046 to do proper overflow checking on durations.
d311d28c
PE
1047 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
1048 in size calculation.
1049 (Fexecute_kbd_macro):
1050 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1051 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
1052 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
1053 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
1054 (set_marker_both, set_marker_restricted_both, marker_position)
1055 (marker_byte_position, Fbuffer_has_markers_at):
1056 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1057 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 1058 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
1059 It now merely ensures that the menu is large enough, without
1060 necessarily growing it, as this avoids some integer overflow issues.
1061 All callers changed.
1062 (keymap_panes, parse_single_submenu, Fx_popup_menu):
1063 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1064 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
1065 Use SAFE_ALLOCA_LISP, not alloca.
1066 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
1067 to EMACS_INT. Check that fixnums are in proper range for system types.
1068 * minibuf.c (minibuf_prompt_width, string_to_object)
1069 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
1070 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
1071 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1072 (get_minibuffer, read_minibuf_unwind):
1073 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1074 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
1075 this simplifies overflow checking. All callers changed.
1076 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
1077 (Ftest_completion):
1078 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1079 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
1080 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
1081 Check that fixnums are in proper range for system types.
1082 (Fx_create_frame, Fx_show_tip):
1083 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1084 * nsfont.m (ns_findfonts, nsfont_list_family):
1085 Don't assume fixnum fits in long.
1086 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
1087 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1088 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
1089 wide enough.
17fdb222 1090 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
1091 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1092 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
1093 (PRINTDECLARE, PRINTPREPARE):
1094 (strout, print_string):
1095 (print, print_preprocess, print_check_string_charset_prop)
1096 (print_object):
1097 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1098 (PRINTDECLARE):
1099 (temp_output_buffer_setup, Fprin1_to_string, print_object):
1100 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1101 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 1102 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 1103 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
1104 (print_error_message): Use SAFE_ALLOCA, not alloca.
1105 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
1106 (print_depth, new_backquote_output, print_number_index):
1107 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
1108 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
1109 (Fset_process_window_size, Fformat_network_address)
1110 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 1111 (sigchld_handler):
d311d28c 1112 Check that fixnums are in proper range for system types.
d44287d4 1113 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
1114 Check for process-ids out of pid_t range rather than relying on
1115 undefined behavior.
e4d81efc 1116 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
1117 (Fformat_network_address, read_process_output, send_process)
1118 (Fprocess_send_region, status_notify):
1119 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1120 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
1121 (wait_reading_process_output, read_process_output, exec_sentinel):
1122 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1123 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
1124 (Faccept_process_output): Use duration_to_sec_usec to do proper
1125 overflow checking on durations.
dde14581
PE
1126 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
1127 Don't assume pid_t fits in int.
02481186
PE
1128 * process.h (struct Lisp_Process): Members tick and update_tick
1129 are now of type EMACS_INT, not int.
b62b53e8
PE
1130 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
1131 configured --with-wide-int.
d311d28c
PE
1132 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
1133 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
1134 * search.c (looking_at_1, string_match_1):
1135 (fast_string_match, fast_c_string_match_ignore_case)
1136 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
1137 (scan_newline, find_before_next_newline, search_command)
1138 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
1139 (set_search_regs, wordify):
1140 (Freplace_match):
1141 (Fmatch_data):
1142 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1143 (string_match_1, search_buffer, set_search_regs):
1144 (Fmatch_data):
1145 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1146 (wordify): Check for overflow in size calculation.
1147 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
1148 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
1149 Check that fixnums are in proper range for system types.
1150 * sound.c (struct sound_device)
1151 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
1152 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1153 (Fplay_sound_internal):
1154 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 1155 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
1156 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
1157 (Fparse_partial_sexp):
1158 Don't assume fixnums can fit in int.
1159 (struct lisp_parse_state, find_start_pos, find_start_value)
1160 (find_start_value_byte, find_start_begv)
1161 (update_syntax_table, char_quoted, dec_bytepos)
1162 (find_defun_start, prev_char_comend_first, back_comment):
1163 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
1164 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
1165 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1166 (Finternal_describe_syntax_value): Check that match_lisp is a
1167 character, not an integer, since the code stuffs it into int.
1168 (scan_words, scan_sexps_forward):
1169 Check that fixnums are in proper range for system types.
1170 (Fforward_word):
1171 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1172 (scan_sexps_forward):
1173 Use CHARACTERP, not INTEGERP, since the value must fit into int.
1174 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
1175 * syntax.h: Adjust decls to match defn changes elsewhere.
1176 (struct gl_state_s):
1177 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
1178 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
1179 MOST_POSITIVE_FIXNUM.
d311d28c
PE
1180 * sysdep.c (wait_for_termination_1, wait_for_termination)
1181 (interruptible_wait_for_termination, mkdir):
1182 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
1183 (emacs_read, emacs_write):
1184 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
1185 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
1186 and double all fit in int.
d311d28c
PE
1187 * term.c (set_tty_color_mode):
1188 Check that fixnums are in proper range for system types.
1189 * termhooks.h (struct input_event):
1190 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1191 * textprop.c (validate_interval_range, interval_of)
1192 (Fadd_text_properties, set_text_properties_1)
1193 (Fremove_text_properties, Fremove_list_of_text_properties)
1194 (Ftext_property_any, Ftext_property_not_all)
1195 (copy_text_properties, text_property_list, extend_property_ranges)
1196 (verify_interval_modification):
1197 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1198 (Fnext_single_char_property_change)
1199 (Fprevious_single_char_property_change):
1200 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
1201 (copy_text_properties):
1202 Check for integer overflow in index calculation.
d311d28c
PE
1203 * undo.c (last_boundary_position, record_point, record_insert)
1204 (record_delete, record_marker_adjustment, record_change)
1205 (record_property_change):
1206 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1207 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
1208 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1209 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1210 (Fx_hide_tip, Fx_file_dialog):
1211 * w32menu.c (set_frame_menubar):
1212 Use ptrdiff_t, not int, for consistency with rest of code.
1213 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
1214 (select_window, Fdelete_other_windows_internal)
1215 (window_scroll_pixel_based, window_scroll_line_based)
1216 (Frecenter, Fset_window_configuration):
1217 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1218 (Fset_window_hscroll, run_window_configuration_change_hook)
1219 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 1220 (Fscroll_other_window, Frecenter):
d311d28c
PE
1221 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1222 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
1223 Don't assume fixnum fits in int.
1224 (Fset_window_scroll_bars):
1225 Check that fixnums are in proper range for system types.
1226 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
1227 (string_pos, c_string_pos, number_of_chars, init_iterator)
1228 (in_ellipses_for_invisible_text_p, init_from_display_pos)
1229 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
1230 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
1231 (face_before_or_after_it_pos, handle_invisible_prop)
1232 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
1233 (display_prop_intangible_p, string_buffer_position_lim)
1234 (string_buffer_position, handle_composition_prop, load_overlay_strings)
1235 (get_overlay_strings_1, get_overlay_strings)
1236 (iterate_out_of_display_property, forward_to_next_line_start)
1237 (back_to_previous_visible_line_start, reseat, reseat_to_string)
1238 (get_next_display_element, set_iterator_to_next)
1239 (get_visually_first_element, compute_stop_pos_backwards)
1240 (handle_stop_backwards, next_element_from_buffer)
1241 (move_it_in_display_line_to, move_it_in_display_line)
1242 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1243 (add_to_log, message_dolog, message_log_check_duplicate)
1244 (message2, message2_nolog, message3, message3_nolog
1245 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
1246 (current_message_1, truncate_echo_area, truncate_message_1)
1247 (set_message, set_message_1, store_mode_line_noprop)
1248 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
1249 (text_outside_line_unchanged_p, check_point_in_composition)
1250 (reconsider_clip_changes)
1251 (redisplay_internal, set_cursor_from_row, try_scrolling)
1252 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
1253 (redisplay_window, find_last_unchanged_at_beg_row)
1254 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
1255 (trailing_whitespace_p, find_row_edges, display_line)
1256 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
1257 (display_mode_element, store_mode_line_string)
1258 (pint2str, pint2hrstr, decode_mode_spec)
1259 (display_count_lines, display_string, draw_glyphs)
1260 (x_produce_glyphs, x_insert_glyphs)
1261 (rows_from_pos_range, mouse_face_from_buffer_pos)
1262 (fast_find_string_pos, mouse_face_from_string_pos)
1263 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1264 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1265 (safe_call, init_from_display_pos, handle_fontified_prop)
1266 (handle_single_display_spec, load_overlay_strings)
1267 (with_echo_area_buffer, setup_echo_area_for_printing)
1268 (display_echo_area, echo_area_display)
1269 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
1270 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
1271 (redisplay_window, dump_glyph_row, display_mode_line)
1272 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 1273 (handle_display_spec, display_prop_string_p):
d311d28c
PE
1274 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1275 (handle_single_display_spec, build_desired_tool_bar_string)
1276 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
1277 (get_specified_cursor_type):
1278 Check that fixnums are in proper range for system types.
1279 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
1280 (Flookup_image_map):
1281 Don't assume fixnums fit in int.
1282 (compare_overlay_entries):
1283 Avoid mishandling comparisons due to subtraction overflow.
1284 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
1285 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
1286 (handle_tool_bar_click):
1287 Use int, not unsigned, since we prefer signed and the signedness
1288 doesn't matter here.
1289 (get_next_display_element, next_element_from_display_vector):
1290 Use int, not EMACS_INT, when int is wide enough.
1291 (start_hourglass): Use duration_to_sec_usec to do proper
1292 overflow checking on durations.
1293 * xfaces.c (Fbitmap_spec_p):
1294 Check that fixnums are in proper range for system types.
1295 (compare_fonts_by_sort_order):
1296 Avoid mishandling comparisons due to subtraction overflow.
1297 (Fx_family_fonts, realize_basic_faces):
1298 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1299 (Fx_family_fonts):
1300 Don't assume fixnum fits in int.
1301 Use SAFE_ALLOCA_LISP, not alloca.
1302 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
1303 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
1304 (face_at_buffer_position, face_for_overlay_string)
1305 (face_at_string_position):
1306 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1307 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
1308 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
1309 (Fx_show_tip):
1310 Check that fixnums are in proper range for system types.
1311 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1312 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
1313 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1314 (Fx_change_window_property): Don't assume fixnums fit in int.
1315 * xfont.c (xfont_chars_supported):
1316 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1317 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
1318 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
1319 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1320 * xml.c (parse_region):
1321 * xrdb.c (magic_file_p):
1322 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1323 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
1324 (x_get_local_selection, x_reply_selection_request)
1325 (x_handle_selection_request, wait_for_property_change):
1326 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1327 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
1328 short is wide enough.
1329 (x_send_client_event): Don't assume fixnum fits in int.
1330 * xterm.c (x_x_to_emacs_modifiers):
1331 Don't assume EMACS_INT overflows nicely into int.
1332 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
1333 may come from Lisp.
1334 (handle_one_xevent): NATNUMP can eval its arg twice.
1335 (x_connection_closed):
1336 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1337 * xterm.h: Adjust decls to match defn changes elsewhere.
1338 (struct scroll_bar): Use struct vectorlike_header
1339 rather than rolling our own approximation.
1340 (SCROLL_BAR_VEC_SIZE): Remove; not used.
1341
c6574eb5
GM
13422012-05-25 Glenn Morris <rgm@gnu.org>
1343
1344 * lisp.mk (lisp): Update for more files being compiled now.
1345
e8d32c7e
SM
13462012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
1347
48def666
SM
1348 * lread.c: Remove `read_pure' which makes no difference.
1349 (read_pure): Remove var.
1350 (unreadpure): Remove function.
1351 (readevalloop): Don't call read_list with -1 flag.
1352 (read1, read_vector): Don't test read_pure any more.
1353 (read_list): Simplify.
1354
e8d32c7e
SM
1355 * fileio.c, character.h: Minor style tweaks.
1356
4b2addb7
DA
13572012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
1358
1359 * window.h (clip_changed): Remove useless declaration.
1360
584461b2
JB
13612012-05-22 Juanma Barranquero <lekktu@gmail.com>
1362
1363 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
1364 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
1365
34374650
PE
13662012-05-22 Paul Eggert <eggert@cs.ucla.edu>
1367
1368 Remove src/m/*.
1369 This directory predates autoconf and is no longer needed nowadays.
1370 Move its few remaining bits of functionality to where they're needed.
1371 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
1372 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
1373 * m/template.h: Remove.
1374 * Makefile.in (M_FILE): Remove. All uses removed.
1375 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
1376 * lisp.h (USE_LSB_TAG):
1377 * mem-limits.h (EXCEEDS_LISP_PTR):
1378 Use VAL_MAX, not VALBITS, in #if.
1379 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
1380 (EMACS_UINT): Define unconditionally now.
1381 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
1382 (BITS_PER_EMACS_INT): New constants, replacing
1383 what used to be in config.h, but not useful in #if.
1384 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
1385 define them any more.
1386 (VAL_MAX): New macro.
1387 (VALMASK): Use it.
1388 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
1389 BITS_PER_EMACS_INT, in #if.
1390 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1391 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
1392 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
1393 * s/ms-w32.h (DATA_START):
1394 Move here from removed file m/intel386.h.
1395 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
1396 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
1397
261cb4bb
PE
13982012-05-21 Paul Eggert <eggert@cs.ucla.edu>
1399
1400 Assume C89 or later.
1401 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
1402 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
1403 (xrealloc):
1404 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
1405 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
1406 * textprop.c, tparam.c (NULL): Remove.
1407 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
1408 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
1409 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
1410 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
1411 * xterm.c (input_signal_count): Assume volatile works.
1412
ff23cd9f
KB
14132012-05-21 Ken Brown <kbrown@cornell.edu>
1414
1415 * xgselect.c (xg_select): Fix first argument in call to 'select'
1416 (bug#11508).
1417
1b170bc6
KB
14182012-05-20 Ken Brown <kbrown@cornell.edu>
1419
1420 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 1421 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 1422
b2f4d39f
KB
14232012-05-19 Ken Brown <kbrown@cornell.edu>
1424
1425 * xfns.c (x_in_use): Remove `static' qualifier.
1426 * xterm.h (x_in_use): Declare.
1427 * xgselect.c: Include xterm.h.
1428 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
1429 and `display_arg' (bug#9754).
1430
003fdae2
PE
14312012-05-19 Paul Eggert <eggert@cs.ucla.edu>
1432
9232a6d9
PE
1433 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
1434
003fdae2
PE
1435 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
1436 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
1437
784b56e2
EZ
14382012-05-18 Eli Zaretskii <eliz@gnu.org>
1439
1440 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
1441
1442 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
1443 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
1444
1445 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
1446 reference to image_cache->refcount.
1447 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
1448
a0a79cde
JL
14492012-05-17 Juri Linkov <juri@jurta.org>
1450
1451 * search.c (Fword_search_regexp, Fword_search_backward)
1452 (Fword_search_forward, Fword_search_backward_lax)
1453 (Fword_search_forward_lax): Move functions to isearch.el
1454 (bug#10145, bug#11381).
1455
b0572523
PE
14562012-05-16 Paul Eggert <eggert@cs.ucla.edu>
1457
1458 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
1459
9660f5fc
SM
14602012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
1461
1462 * lread.c (init_obarray): Declare Qt and Qnil as special.
1463
4374de83
GM
14642012-05-14 Glenn Morris <rgm@gnu.org>
1465
1466 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 1467 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 1468
dc44c39a
PE
14692012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1470
078c97cb
PE
1471 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
1472
dc44c39a
PE
1473 * unexaix.c: Port to more-recent AIX compilers.
1474 (report_error, report_error_1, make_hdr, copy_sym)
1475 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
1476 Make arguments const char *, not char *, to avoid violations of C
1477 standard and to fix some AIX warnings reported by Gilles Pion.
1478
e18afed7 14792012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
1480
1481 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
1482 already have overlays loaded.
1483 (handle_single_display_spec): Before returning without displaying
1484 fringe bitmap, synchronize the bidi iterator with the main display
1485 iterator, by calling iterate_out_of_display_property.
1486 (iterate_out_of_display_property): Detect buffer iteration by
1487 testing that it->string is a Lisp string.
1488 (get_next_display_element): When the current object is exhausted,
1489 and there's something on it->stack, call set_iterator_to_next to
1490 proceed with what's on the stack, instead of returning zero.
1491 (set_iterator_to_next): If called at the end of a Lisp string,
1492 proceed to consider_string_end without incrementing string
1493 position. Don't increment display vector index past the end of
1494 the display vector. (Bug#11417)
c8fb9dc6
EZ
1495 (pos_visible_p): Don't report a position visible when move_it_to
1496 stopped at the last line of window, which happens to be scanned
1497 backwards by the bidi iteration. (Bug#11464)
ac268e67 1498
e18afed7 14992012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
1500
1501 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
1502 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
1503 are on a TTY, and thus unable to display on the fringes.
1504 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
1505 so we need to signal to the caller that this is a "replacing"
1506 display spec. This fixes display when the spec is invalid or we
1507 are on a TTY.
1508
e18afed7 15092012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
1510
1511 * unexaix.c (make_hdr): Fix typo in prototype.
1512 This bug broke the build on AIX. Problem reported by Gilles Pion.
1513
9d0a235a
MA
15142012-05-14 Michael Albinus <michael.albinus@gmx.de>
1515
1516 * keyboard.c (kbd_buffer_get_event): Read special events also in
1517 batch mode. (Bug#11415)
1518
9e6b06ed
GM
15192012-05-12 Glenn Morris <rgm@gnu.org>
1520
1521 * ns.mk: Update for ns_appbindir no longer having trailing "/".
1522
c1a1d7a3
EZ
15232012-05-12 Eli Zaretskii <eliz@gnu.org>
1524
1525 * lisp.mk (lisp): Add newcomment.elc.
1526
3fe7cdc8
GM
15272012-05-12 Glenn Morris <rgm@gnu.org>
1528
1529 * Makefile.in (MKDIR_P): New, set by configure.
1530 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
1531
53f7d2c0
PE
15322012-05-11 Paul Eggert <eggert@cs.ucla.edu>
1533
1534 Remove unused function hourglass_started.
1535 * dispextern.h (hourglass_started):
1536 * w32fns.c (hourglass_started):
1537 * xdisp.c (hourglass_started): Remove.
1538
75aafb17
JB
15392012-05-10 Juanma Barranquero <lekktu@gmail.com>
1540
1541 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
1542 Update dependencies.
1543
12959e8e
PE
15442012-05-10 Paul Eggert <eggert@cs.ucla.edu>
1545
97107e2e
PE
1546 * xgselect.c (xg_select): Put maxfds+1 into a var.
1547 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
1548
12959e8e
PE
1549 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
1550
836d29b3
DA
15512012-05-10 Dave Abrahams <dave@boostpro.com>
1552
1553 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
1554 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
1555
5cb67954
MA
15562012-05-09 Michael Albinus <michael.albinus@gmx.de>
1557
1558 * dbusbind.c (xd_registered_buses): New internal Lisp object.
1559 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
1560 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
1561 Initialize xd_registered_buses.
1562
3478ec45
PE
15632012-05-09 Paul Eggert <eggert@cs.ucla.edu>
1564
b263a6b0
PE
1565 Untag more efficiently if USE_LSB_TAG.
1566 This is based on a proposal by YAMAMOTO Mitsuharu in
1567 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
1568 For an admittedly artificial (nth 8000 longlist) benchmark on
1569 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
1570 Emacs's overall text size by 1%.
1571 * lisp.h (XUNTAG): New macro.
1572 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
1573 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
1574 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
1575 * eval.c (Fautoload):
1576 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
1577 * frame.h (XFRAME): Use XUNTAG.
1578
3478ec45
PE
1579 Port recent dbusbind.c changes to 32-bit --with-wide-int.
1580 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
1581 Remove unportable assumptions about print widths of types like
1582 dbus_uint32_t.
1583 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
1584 intptr_t when converting between pointer and integer, to avoid GCC
1585 warnings about wrong width.
1586
666b903b 15872012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
1588
1589 * w32proc.c (new_child): Force Windows to reserve only 64KB of
1590 stack for each reader_thread, instead of defaulting to 8MB
1591 determined by the linker. This avoids failures in creating
1592 subprocesses on Windows 7, see the discussion in this thread:
1593 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
1594
b120cc17
JC
15952012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
1596
1597 Fix up display of the *Minibuf-0* buffer in the mini window.
1598 * keyboard.c (read_char): Don't clear the echo area if there's no
1599 message to clear.
1600 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 1601 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 1602
9a4b36f8
MA
16032012-05-07 Michael Albinus <michael.albinus@gmx.de>
1604
1605 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
1606 batch mode.
1607
e5f9458f
CY
16082012-05-06 Chong Yidong <cyd@gnu.org>
1609
1610 * lisp.mk (lisp): Update.
1611
eceeb5fc 16122012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
1613
1614 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
1615
71873e2b
SM
16162012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
1617
1618 * data.c (PUT_ERROR): New macro.
1619 (syms_of_data): Use it. Add new error type `user-error'.
1620 * undo.c (user_error): New function.
1621 (Fprimitive_undo): Use it.
1622 * print.c (print_error_message): Adjust print style for `user-error'.
1623 * keyboard.c (user_error): New function.
1624 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
1625
ab0fa4e4
PE
16262012-05-03 Paul Eggert <eggert@cs.ucla.edu>
1627
1628 Do not limit current-time-string to years 1000..9999.
1629 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
1630 (Fcurrent_time_string): Support any year that is supported by the
1631 underlying localtime representation. Don't use asctime, as it
1632 has undefined behavior for years outside the range -999..9999.
1633
7ed806a7
PE
16342012-05-02 Paul Eggert <eggert@cs.ucla.edu>
1635
1636 Fix race conditions involving setenv, gmtime, localtime, asctime.
1637 Without this fix, interrupts could mess up code that uses these
1638 nonreentrant functions, since setting TZ invalidates existing
1639 tm_zone or tzname values, and since most of these functions return
1640 pointers to static storage.
1641 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
1642 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
1643 Grow the critical sections to include not just invoking
1644 localtime/gmtime, but also accessing these functions' results
1645 including their tm_zone values if any, and any related TZ setting.
1646 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
1647 so that the struct tm is saved in the critical section.
1648 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
1649 motivated by the fact that memory allocation needs to be outside
1650 the critical section.
1651
0c16dfed
DA
16522012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
1653
1654 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
1655 with RESET_INTERVAL.
1656
1657 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1658 Remove duplicated buffer name initialization.
1659
3f83ace8
JM
16602012-05-02 Jim Meyering <jim@meyering.net>
1661
1662 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
1663
c7b8541e
JM
1664 * xfns.c (x_window): Use xstrdup (Bug#11375).
1665
90207a15 16662012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
1667
1668 * xdisp.c (pos_visible_p): If already at a newline from the
1669 display string before the 'while' loop, don't walk back the glyphs
1670 from it3.glyph_row. Solves assertion violation when the display
1671 string begins with a newline (egg.el). (Bug#11367)
1672
b593d6a9
AH
16732012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
1674
1675 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
1676 Move to simple.el.
1677
4737362e
GM
16782012-05-01 Glenn Morris <rgm@gnu.org>
1679
99cf43f9
GM
1680 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
1681 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
1682 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
1683 All were removed before 23.1.
1684
9311dcff
GM
1685 * dispnew.c: Remove HAVE_LIBNCURSES test;
1686 it is always true on relevant platforms.
1687
4d5c6349
GM
1688 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
1689 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
1690
4737362e
GM
1691 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
1692
74dd3a6b
AS
16932012-04-30 Andreas Schwab <schwab@linux-m68k.org>
1694
1695 * .gdbinit (xpr): Remove checks for no longer existing misc types.
1696 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
1697 Remove.
1698
13c379ee
PE
16992012-04-28 Paul Eggert <eggert@cs.ucla.edu>
1700
1701 Do not avoid creating empty evaporating overlays (Bug#9642).
1702 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
1703 That is, do not delete an evaporating overlay if it becomes
1704 empty after its bounds are adjusted to fit within its buffer.
1705 This fix caused other problems, and I'm reverting it until we get
1706 to the bottom of them.
1707
a8e7d6d7 17082012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
1709
1710 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
1711
a8e7d6d7 17122012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
1713
1714 * xdisp.c (pos_visible_p): If the window start position is beyond
1715 ZV, start the display from buffer beginning. Prevents assertion
1716 violation in init_iterator when the minibuffer window is scrolled
1717 via the scroll bar.
1718
1719 * window.c (window_scroll_pixel_based): Likewise.
1720
a8e7d6d7 17212012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
1722
1723 * keymap.c (where_is_internal): Doc fix (Bug#10872).
1724
a8e7d6d7 17252012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
1726
1727 * fileio.c (Fcopy_file, Fset_file_selinux_context):
1728 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
1729
a8e7d6d7 17302012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 1731
b593d6a9
AH
1732 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
1733 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 1734
1c6900d9
EZ
17352012-04-26 Eli Zaretskii <eliz@gnu.org>
1736
4c3fa1d9
EZ
1737 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
1738 display element, check also the underlying string or buffer
1739 character. (Bug#11341)
1740
1c6900d9
EZ
1741 * w32menu.c: Include w32heap.h.
1742 (add_menu_item): If the call to AppendMenuW (via
1743 unicode_append_menu) fails, disable Unicode menus only if we are
1744 running on Windows 9X/Me.
1745
42bf8205
AS
17462012-04-24 Andreas Schwab <schwab@linux-m68k.org>
1747
1748 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
1749 (xgetint): Add missing shift for LSB tags.
1750
b1bac16e
MR
17512012-04-24 Martin Rudalics <rudalics@gmx.at>
1752
1753 * keyboard.c (read_char): Don't wipe echo area for select window
1754 events: These might get delayed via `mouse-autoselect-window'
1755 (Bug#11304).
1756
d69621cc
JB
17572012-04-24 Juanma Barranquero <lekktu@gmail.com>
1758
1759 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
1760 manipulation of :loaded-from data.
1761
02fd101b
JB
17622012-04-23 Juanma Barranquero <lekktu@gmail.com>
1763
1764 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
1765 now a cons (bug#11311).
1766
888bec30
PE
17672012-04-23 Paul Eggert <eggert@cs.ucla.edu>
1768
89a438bd
PE
1769 Do not create empty overlays with the evaporate property (Bug#9642).
1770 * buffer.c (Fmove_overlay): Delete an evaporating overlay
1771 if it becomes empty after its bounds are adjusted to fit within
1772 its buffer. Without this fix, in a nonempty buffer (let ((o
1773 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
1774 yields an empty overlay that has the evaporate property, which is
1775 not supposed to happen.
1776
1068fe4d
PE
1777 Fix minor GTK3 problems found by static checking.
1778 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1779 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1780 (struct _EmacsFixedClass, emacs_fixed_get_type):
1781 Move decls here from emacsgtkfixed.h, since they needn't be public.
1782 (emacs_fixed_get_type): Now static.
1783 (emacs_fixed_class_init): Omit unused local.
1784 (emacs_fixed_child_type): Remove; unused.
1785 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1786 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1787 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
1788 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
1789 (EMACS_FIXED_GET_CLASS): Remove; unused.
1790 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
1791
888bec30
PE
1792 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
1793 Problem reported by Juanma Barranquero for Windows -Wunused-function.
1794
de85e130
PE
17952012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1796
d0baac98 1797 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 1798 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
1799 (__malloc_size_t, __malloc_ptrdiff_t):
1800 Remove. All uses removed, replaced by the definiens if needed,
1801 since we can assume C89 or better now.
1802 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
1803 (protect_malloc_state, align, get_contiguous_space)
1804 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
1805 (malloc_atfork_handler_child, malloc_enable_thread)
1806 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
1807 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
1808 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
1809 (special_realloc, _realloc_internal_nolock, _realloc_internal)
1810 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
1811 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
1812 Define using prototypes, not old style.
1813 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
1814 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
1815 (align): Don't assume that signed integer overflow wraps around.
1816 Omit unused local var.
1817 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
1818 (_free_internal_nolock, memalign, mallochook, reallochook):
1819 Omit no-longer-needed casts.
1820 (valloc): Use getpagesize, not __getpagesize.
1821 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
1822 (struct hdr): The 'magic' member is now size_t, not unsigned long.
1823
de85e130
PE
1824 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
1825
dcbf5805
MA
18262012-04-22 Michael Albinus <michael.albinus@gmx.de>
1827
1828 Move functions from C to Lisp. Make non-blocking method calls
1829 the default. Implement further D-Bus standard interfaces.
1830
1831 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
1832 (QCdbus_request_name_allow_replacement)
1833 (QCdbus_request_name_replace_existing)
1834 (QCdbus_request_name_do_not_queue)
1835 (QCdbus_request_name_reply_primary_owner)
1836 (QCdbus_request_name_reply_in_queue)
1837 (QCdbus_request_name_reply_exists)
1838 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
1839 (QCdbus_registered_serial, QCdbus_registered_method)
1840 (QCdbus_registered_signal): New Lisp objects.
1841 (XD_DEBUG_MESSAGE): Use sizeof.
1842 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
1843 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
1844 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
1845 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
1846 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
1847 (xd_signature, xd_append_arg): Allow float for integer types.
1848 (xd_get_connection_references): New function.
b593d6a9
AH
1849 (xd_get_connection_address): Rename from xd_initialize.
1850 Return cached address.
dcbf5805
MA
1851 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
1852 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
1853 level.
1854 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 1855 Return number of refcounts.
dcbf5805
MA
1856 (Fdbus_get_unique_name): Make stronger parameter check.
1857 (Fdbus_message_internal): New defun.
1858 (Fdbus_call_method, Fdbus_call_method_asynchronously)
1859 (Fdbus_method_return_internal, Fdbus_method_error_internal)
1860 (Fdbus_send_signal, Fdbus_register_service)
1861 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
1862 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
1863 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
1864 (Vdbus_compiled_version, Vdbus_runtime_version)
1865 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
1866 (Vdbus_message_type_method_return, Vdbus_message_type_error)
1867 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
1868 (Vdbus_registered_buses, Vdbus_registered_objects_table):
1869 Adapt docstring.
dcbf5805 1870
52828e02
PE
18712012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1872
da05bc4c
PE
1873 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
1874 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
1875 Do not assume ptrdiff_t is the same width as 'int'.
1876
52828e02
PE
1877 * alloc.c: Handle unusual debugging option combinations.
1878 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
1879 since the two debugging options are incompatible.
1880 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
1881 is defined.
1882 (mem_init, mem_insert, mem_insert_fixup):
1883 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
1884 (NEED_MEM_INSERT): Remove; no longer needed.
1885
f01769f9
LL
18862012-04-22 Leo Liu <sdl.web@gmail.com>
1887
1888 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
1889
5790543d
PE
18902012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1891
1892 * sysdep.c [__FreeBSD__]: Minor cleanups.
1893 (list_system_processes, system_process_attributes) [__FreeBSD__]:
1894 Use Emacs indenting style more consistently. Avoid some casts.
1895 Use 'double' consistently rather than mixing 'float' and 'double'.
1896
b91b7e4d
EW
18972012-04-21 Eduard Wiebe <usenet@pusto.de>
1898
b593d6a9
AH
1899 * sysdep.c (list_system_processes, system_process_attributes):
1900 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 1901
6114eb15
AS
19022012-04-21 Andreas Schwab <schwab@linux-m68k.org>
1903
1904 * lisp.mk (lisp): Update.
1905
2f38dff7
PE
19062012-04-20 Paul Eggert <eggert@cs.ucla.edu>
1907
1908 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
1909 It is never used otherwise.
1910
4ae29f89
SM
19112012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
1912
1913 * print.c (print_preprocess): Only check print_depth if print-circle
1914 is nil.
1915 (print_object): Check for cycles even when print-circle is nil and
1916 print-gensym is t, but only check print_depth if print-circle is nil.
1917
f30d612a
CY
19182012-04-20 Chong Yidong <cyd@gnu.org>
1919
1920 * process.c (wait_reading_process_output): If EIO occurs on a pty,
1921 set the status to "failed" and ensure that sentinel is run.
1922
c07a4c0b 19232012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
1924
1925 * process.c (Fset_process_inherit_coding_system_flag)
1926 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 1927 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 1928
c07a4c0b 19292012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
1930
1931 * xdisp.c (string_buffer_position_lim): Limit starting position to
1932 BEGV.
1933 (set_cursor_from_row): If called for a mode-line or header-line
1934 row, return zero immediately.
1935 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
1936 farther than the first row after the header line, if any.
1937 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
1938 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
1939
c07a4c0b 19402012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 1941
4ae29f89
SM
1942 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
1943 (bug#11238).
ad3a2b41 1944
c07a4c0b 19452012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 19462012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
1947
1948 configure: new option --enable-gcc-warnings (Bug#11207)
1949 * Makefile.in (C_WARNINGS_SWITCH): Remove.
1950 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
1951 (ALL_CFLAGS): Use new macros rather than old.
1952 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
1953 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
1954 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
1955 -Wunused-result, -Wunused-variable. This should go away once
1956 the Emacs and Gnulib regex code is merged.
1957 (xmalloc, xrealloc): Now static.
1958
aba027e8
PE
19592012-04-17 Paul Eggert <eggert@cs.ucla.edu>
1960
1961 * dired.c (Fsystem_groups): Remove unused local.
1962
e5a36063
GM
19632012-04-17 Glenn Morris <rgm@gnu.org>
1964
1965 * dired.c (Fsystem_users): Doc fix.
1966
316411f0
DA
19672012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
1968
1969 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
1970 (syms_of_dired): Add them.
1971
9426aba4
PE
19722012-04-16 Paul Eggert <eggert@cs.ucla.edu>
1973
b62a57be
PE
1974 Fix minor alloc.c problems found by static checking.
1975 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
1976 New extern decls, to avoid calling undeclared functions.
1977 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
1978 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
1979 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
1980 (NEED_MEM_INSERT): New macro.
1981 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 1982 Remove one incorrect comment and fix another.
b62a57be 1983
3539f31f
PE
1984 Fix minor ralloc.c problems found by static checking.
1985 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1986 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
1987 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
1988 (r_alloc_sbrk): Now static.
1989
a041960a
PE
1990 Improve ralloc.c interface checking.
1991 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1992 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
1993 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
1994 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
1995 [REL_ALLOC]: ... to here, to check interface.
1996 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
1997 Remove decls. This fixes an "It stinks!".
1998
9426aba4
PE
1999 * alloc.c (which_symbols): Fix alignment issue / type clash.
2000
d55c12ed
AS
20012012-04-15 Andreas Schwab <schwab@linux-m68k.org>
2002
2003 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
2004 (struct Lisp_Misc_Any): Likewise.
2005 (struct Lisp_Free): Likewise.
2006 * alloc.c (union aligned_Lisp_Symbol): Define.
2007 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
2008 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
2009 (union aligned_Lisp_Misc): Define.
2010 (MARKER_BLOCK_SIZE, struct marker_block): Use union
2011 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 2012 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 2013
b948ce8b
PE
20142012-04-14 Paul Eggert <eggert@cs.ucla.edu>
2015
2016 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
2017 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
2018 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
2019 * s/netbsd.h, s/sol2-6.h:
2020 Remove definition of GC_MARK_STACK, since the default now works.
2021 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
2022 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
2023 no longer the default.
2024 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
2025
35dc09a1 20262012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 2027
35dc09a1
GM
2028 * lread.c (lisp_file_lexically_bound_p):
2029 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 2030
35dc09a1
GM
20312012-04-14 Eli Zaretskii <eliz@gnu.org>
2032
2033 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
2034 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
2035
20362012-04-14 Jan Djärv <jan.h.d@swipnet.se>
2037
2038 * nsterm.m (constrainFrameRect): Always constrain when there is only
2039 one screen (Bug#10962).
2040
bcd86815
KB
20412012-04-13 Ken Brown <kbrown@cornell.edu>
2042
2043 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
2044
c25df26e
RT
20452012-04-13 Reuben Thomas <rrt@sc3d.org>
2046
2047 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
2048
0fc59f1e
DC
20492012-04-11 Daniel Colascione <dancol@dancol.org>
2050
2051 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
2052 against is gone. It's better to use vfork now so that when Cygwin
2053 gains a new, working vfork, we use it automatically (bug#10398).
2054
de8c03dc
SM
20552012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2056
2057 * window.c (save_window_save): Obey window-point-insertion-type.
2058
2f097256
GM
20592012-04-11 Glenn Morris <rgm@gnu.org>
2060
2061 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
2062
453b951e
SM
20632012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2064
2065 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
2066
75f1671a 20672012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
2068
2069 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
2070 (force_quit_count): New var.
2071 (handle_interrupt): Use it.
2072
2a8ce227
JB
20732012-04-10 Juanma Barranquero <lekktu@gmail.com>
2074
2075 * w32.c (w32_delayed_load): Record the full path of the library
2076 being loaded (bug#10424).
2077
935396c0
GM
20782012-04-09 Glenn Morris <rgm@gnu.org>
2079
05920a43
GM
2080 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
2081 not just in the obarray, before snarfing them. (Bug#11036)
2082
935396c0
GM
2083 * Makefile.in ($(leimdir)/leim-list.el):
2084 Pass EMACS rather than BUILT_EMACS.
2085
a18ecafa
TZ
20862012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
2087
2088 * process.c (make_process):
2089 * process.h: Add integer `gnutls_handshakes_tried' member to
2090 process struct.
2091
6bbef4e5
JC
2092 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
2093 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
2094
2095 * gnutls.c (gnutls_log_function2i): Convenience log function.
2096 (emacs_gnutls_read): Use new log functions,
2097 `gnutls_handshakes_tried' process member, and
2098 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
2099 attempts per process (connection).
2100
b4d3bc10
CY
21012012-04-09 Chong Yidong <cyd@gnu.org>
2102
2103 * eval.c (Fuser_variable_p, user_variable_p_eh)
2104 (lisp_indirect_variable): Functions deleted.
2105 (Fdefvar): Caller changed.
2106
2107 * callint.c (Finteractive, Fcall_interactively):
2108 * minibuf.c (Fread_variable): Callers changed.
2109
70f4d973
EZ
21102012-04-09 Eli Zaretskii <eliz@gnu.org>
2111
2112 * xdisp.c (set_cursor_from_row): If the display string appears in
2113 the buffer at position that is closer to point than the position
2114 after the display string, display the cursor on the first glyph of
2115 the display string. Fixes cursor display when a 'display' text
2116 property immediately follows invisible text. (Bug#11094)
2117
cb3c2e3e
PE
21182012-04-09 Paul Eggert <eggert@cs.ucla.edu>
2119
2120 composite.c: use 'double' consistently
2121 * composite.c (get_composition_id): Use 'double' consistently
2122 instead of converting 'float' to 'double' and vice versa; this is
2123 easier to understand and avoids a GCC warning.
2124
fd06db5d
GM
21252012-04-09 Glenn Morris <rgm@gnu.org>
2126
50fe702a
GM
2127 * Makefile.in: Generate leim-list with bootstrap-emacs, in
2128 preparation for dumping it with emacs. (Bug#4789)
2129 (leimdir): New variable.
2130 ($(leimdir)/leim-list.el): New rule.
2131 (emacs$(EXEEXT)): Depend on leim-list.el.
2132
fd06db5d
GM
2133 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
2134 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
2135 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
2136
55c131ee
AS
21372012-04-08 Andreas Schwab <schwab@linux-m68k.org>
2138
2139 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
2140 proper alignment.
2141
9209588f
JB
21422012-04-07 Juanma Barranquero <lekktu@gmail.com>
2143
2144 * xml.c (init_libxml2_functions) [WINDOWSNT]:
2145 Remove unused local variable.
2146
e3fb2efb
PE
21472012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2148
2149 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
2150 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
2151 (mark_memory): Mark Lisp_Objects only if pointers might hide in
2152 objects, as mark_maybe_pointer will catch them otherwise.
2153 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
2154 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
2155
b5385551
PE
21562012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2157
2158 Fix typo that broke non-Windows builds.
2159 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
2160
9078ead6
EZ
21612012-04-07 Eli Zaretskii <eliz@gnu.org>
2162
2163 Support building on MS-Windows with libxml2.
2164
2165 * makefile.w32-in (OBJ2): Add xml.$(O).
2166 (GLOBAL_SOURCES): Add xml.c.
2167 ($(BLD)/xml.$(O)): New dependency list.
2168
2169 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
2170 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
2171 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
2172 [!WINDOWSNT]: New macros.
2173 (init_libxml2_functions, libxml2_loaded_p): New functions.
2174 (parse_region): Call fn_xmlCheckVersion instead of using the macro
2175 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
2176 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
2177 Calls xmlCleanupParser only if libxml2 was loaded (or statically
2178 linked in).
6bbef4e5
JC
2179 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
2180 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
2181 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
2182
2183 * emacs.c: Don't include libxml/parser.h.
2184 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
2185 xmlCleanupParser directly.
2186
2187 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
2188
3811fdf3
EZ
21892012-04-07 Eli Zaretskii <eliz@gnu.org>
2190
2191 * indent.c (Fvertical_motion): If there is a display string at
2192 point, use it.vpos to compute how many lines to backtrack after
2193 move_it_to point. (Bug#11133)
2194
2f8e16b2
EZ
21952012-04-06 Eli Zaretskii <eliz@gnu.org>
2196
2197 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
2198 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
2199 about subtle differences between FETCH_CHAR* and STRING_CHAR*
2200 macros related to unification of CJK characters. For the details,
2201 see the discussion following the message here:
2202 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
2203
3d439cd1
CY
22042012-04-04 Chong Yidong <cyd@gnu.org>
2205
2206 * keyboard.c (Vdelayed_warnings_list): Doc fix.
2207
8bc53d00
EZ
22082012-04-01 Eli Zaretskii <eliz@gnu.org>
2209
2210 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
2211 instead of alloca. (Bug#11138)
2212
3b0512a3
AS
22132012-04-01 Andreas Schwab <schwab@linux-m68k.org>
2214
2215 * w32menu.c (is_simple_dialog): Properly check lisp types.
2216 (Bug#11141)
2217
8427ddd2
EZ
22182012-03-31 Eli Zaretskii <eliz@gnu.org>
2219
979022ef
EZ
2220 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
2221 position we get to after a call to move_it_to fails the
2222 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
2223 only if we wind up in a string from display property. (Bug#11063)
2224
a6b1c7cc
EZ
2225 * window.c (Fdelete_other_windows_internal): Invalidate the row
2226 and column information about mouse highlight, so that redisplay
2227 restores it after reallocating the glyph matrices. (Bug#7464)
2228
8427ddd2
EZ
2229 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
2230 string comes from a `display' text property, use the buffer
2231 position of that property as if we actually saw that position in
2232 the row's glyphs.
697ba24b
EZ
2233 (move_it_by_lines): Remove the assertion that
2234 "it->current_x == 0 && it->hpos == 0" which can be legitimately
2235 violated when there's a before-string at the beginning of a line.
2236 (Bug#11063)
8427ddd2 2237
65a0a738
EZ
22382012-03-30 Eli Zaretskii <eliz@gnu.org>
2239
2240 * xdisp.c (append_space_for_newline): If the default face was
2241 remapped, use the remapped face for the appended newline.
2242 (extend_face_to_end_of_line): Use the remapped default face for
2243 extending the face to the end of the line.
2244 (display_line): Call extend_face_to_end_of_line when the default
2245 face was remapped. (Bug#11068)
2246
581355cc
EZ
22472012-03-29 Eli Zaretskii <eliz@gnu.org>
2248
2249 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
2250
e8fc049f
SM
22512012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2252
2253 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
2254
4fb9a543
GM
22552012-03-27 Glenn Morris <rgm@gnu.org>
2256
2257 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
2258 Doc fixes.
2259
679910f1
KH
22602012-03-26 Kenichi Handa <handa@m17n.org>
2261
2262 * dispextern.h (struct glyph): Fix previous change. Change the
2263 bit length of glyphless.ch to 25 (Bug#11082).
2264
90d49b7f
CY
22652012-03-26 Chong Yidong <cyd@gnu.org>
2266
2267 * keyboard.c (Vselection_inhibit_update_commands): New variable.
2268 (command_loop_1): Use it; inhibit selection update for
2269 handle-select-window too (Bug#8996).
2270
f514f6f0
FP
22712012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
2272
e8fc049f 2273 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 2274
bf43fa51
KH
22752012-03-25 Kenichi Handa <handa@m17n.org>
2276
2277 * dispextern.h (struct glyph): Change the bit length of
2278 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
2279
8a0c01dd
EZ
22802012-03-24 Eli Zaretskii <eliz@gnu.org>
2281
2282 * s/ms-w32.h (tzname): Include time.h before redirecting to
2283 _tzname. Fixes the MSVC build. (Bug#9960)
2284
7d1c3a76
AS
22852012-03-24 Andreas Schwab <schwab@linux-m68k.org>
2286
8ed79523
AS
2287 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
2288 characters.
2289
7d1c3a76
AS
2290 * xterm.c (XTread_socket): Only modify handling_signal if
2291 !SYNC_INPUT. (Bug#11080)
2292
e99a9b8b
EZ
22932012-03-23 Eli Zaretskii <eliz@gnu.org>
2294
2295 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
2296 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
2297 when fetching a multibyte character consumes more bytes than
2298 CHAR_BYTES returns, due to unification of CJK characters in
2299 string_char. (Bug#11073)
2300
5063c0e1
TN
23012012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
2302
2303 * process.c (wait_reading_process_output): Handle pty disconnect
2304 by refraining from sending oneself a SIGCHLD (bug#10933).
2305
9f851fbd
CY
23062012-03-22 Chong Yidong <cyd@gnu.org>
2307
2308 * dispextern.h (struct it): New member string_from_prefix_prop_p.
2309
5063c0e1 2310 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
2311 Mark string as coming from a prefix property.
2312 (handle_face_prop): Use default face for prefix strings (Bug#4281).
2313 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
2314
fb5b8aca
CY
23152012-03-21 Chong Yidong <cyd@gnu.org>
2316
2317 * xfaces.c (Vface_remapping_alist): Doc fix.
2318
62356a1b
EZ
23192012-03-20 Eli Zaretskii <eliz@gnu.org>
2320
2321 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
2322 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
2323 Doc fixes.
62356a1b 2324
025de85b
CY
23252012-03-20 Chong Yidong <cyd@gnu.org>
2326
2327 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
2328 to reflect default non-nil value of redisplay-dont-pause.
2329
4827f94e
KH
23302012-03-19 Kenichi Handa <handa@m17n.org>
2331
2332 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
2333 it fit in a valid range (Bug#11003).
2334
e50a24a2
EZ
23352012-03-18 Eli Zaretskii <eliz@gnu.org>
2336
2337 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
2338 that is not from display property, accept the row as a "cursor
2339 row" if one of the string's character has a non-nil `cursor'
2340 property. Fixes cursor positioning when there are newlines in
2341 overlay strings, e.g. in icomplete.el. (Bug#11035)
2342
9af5ed87
PE
23432012-03-12 Paul Eggert <eggert@cs.ucla.edu>
2344
2345 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
2346
d1f55f16
CY
23472012-03-12 Chong Yidong <cyd@gnu.org>
2348
2349 * eval.c (inhibit_lisp_code): Rename from
2350 inhibit_window_configuration_change_hook; move from window.c.
2351
2352 * xfns.c (unwind_create_frame_1, Fx_create_frame):
2353 * window.c (run_window_configuration_change_hook)
2354 (syms_of_window): Callers changed.
2355
66c5eebd
CY
23562012-03-11 Chong Yidong <cyd@gnu.org>
2357
413df973
CY
2358 * keymap.c (Fkey_description): Doc fix (Bug#9700).
2359
66c5eebd
CY
2360 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
2361
1de11f56
CY
23622012-03-10 Chong Yidong <cyd@gnu.org>
2363
2364 * frame.c (other_visible_frames): Don't assume the selected frame
2365 is visible (Bug#10955).
2366
cae07000
SM
23672012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
2368
2369 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
2370
89c94350
JD
23712012-03-08 Jan Djärv <jan.h.d@swipnet.se>
2372
2373 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
2374 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
2375 zero (Bug#10954).
2376
999dd333
GM
23772012-03-03 Glenn Morris <rgm@gnu.org>
2378
01a6dcc8 2379 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 2380
de0100f2
EZ
23812012-03-02 Eli Zaretskii <eliz@gnu.org>
2382
2383 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
2384 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
2385 (redisplay_window, next_element_from_string): Fix typos in
2386 comments.
3e441275
EZ
2387 (redisplay_window): Pass to move_it_vertically the margin in
2388 pixels, not in screen lines.
de0100f2 2389
96a72ee9
GM
23902012-03-02 Glenn Morris <rgm@gnu.org>
2391
2392 * buffer.c (buffer-list-update-hook): Doc fix.
2393
312508d7
EZ
23942012-02-29 Eli Zaretskii <eliz@gnu.org>
2395
2396 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
2397 push_it before setting up the iterator for the first overlay
2398 string, even if we have an empty string loaded.
2399 (next_overlay_string): If there's an empty string on the iterator
2400 stack, pop the stack. (Bug#10903)
2401
27f3c637
PE
24022012-02-25 Paul Eggert <eggert@cs.ucla.edu>
2403
2404 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
2405 Suggested by Stefan Monnier in
2406 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
2407 * alloc.c (widen_to_Lisp_Object): New static function.
2408 (mark_memory): Also mark Lisp_Objects by fetching pointer words
2409 and widening them to Lisp_Objects. This would work even if
2410 USE_LSB_TAG is defined and wide integers are used, which might
2411 happen in a future version of Emacs.
2412
3c9dfce6
CY
24132012-02-25 Chong Yidong <cyd@gnu.org>
2414
fa74b241
CY
2415 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
2416 Doc fix.
2417
3c9dfce6
CY
2418 * xselect.c (Fx_selection_exists_p): Doc fix.
2419 (x_clipboard_manager_save_all): Print an informative message
2420 before saving to clipboard manager.
2421
9486df08
CY
24222012-02-24 Chong Yidong <cyd@gnu.org>
2423
2424 * keyboard.c (process_special_events): Handle all X selection
2425 requests in kbd_buffer, not just the next one (Bug#8869).
2426
f01d3321
CY
24272012-02-23 Chong Yidong <cyd@gnu.org>
2428
2429 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
2430 call when setting menu-bar-lines and tool-bar-lines parameters.
2431 (unwind_create_frame_1): New helper function.
2432
2433 * window.c (inhibit_window_configuration_change_hook): New var.
2434 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 2435 (syms_of_window): Initialize it.
f01d3321 2436
86b847b6
CY
24372012-02-22 Chong Yidong <cyd@gnu.org>
2438
2439 * xterm.c (x_draw_image_relief): Add missing type check for
2440 Vtool_bar_button_margin (Bug#10743).
2441
a59225b1
CY
24422012-02-21 Chong Yidong <cyd@gnu.org>
2443
2444 * fileio.c (Vfile_name_handler_alist): Doc fix.
2445
2446 * buffer.c (Fget_file_buffer): Protect against invalid file
2447 handler return value.
2448
310f5bd4
PE
24492012-02-20 Paul Eggert <eggert@cs.ucla.edu>
2450
cb3a28cc
PE
2451 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
2452 when computing $valmask.
2453
310f5bd4
PE
2454 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
2455 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
2456 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
2457 It's useless in that case, and it can cause problems on hosts
2458 that allocate halves of EMACS_INT values separately.
2459 Reported by Dan Horák. Diagnosed by Andreas Schwab in
2460 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
2461 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
2462 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
2463 it avoids undefined behavior on hosts where shifting right by more
2464 than the word width has undefined behavior.
2465
2375c96a
CY
24662012-02-19 Chong Yidong <cyd@gnu.org>
2467
2468 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
2469 (Funhandled_file_name_directory, Ffile_name_as_directory)
2470 (Fdirectory_file_name, Fexpand_file_name)
2471 (Fsubstitute_in_file_name): Protect against invalid file handler
2472 return values (Bug#10845).
2473
3eb49e71
EZ
24742012-02-18 Eli Zaretskii <eliz@gnu.org>
2475
2476 * .gdbinit (pitx): Fix incorrect references to fields of the
2477 iterator stack.
2478
7b926f3f
CY
24792012-02-17 Chong Yidong <cyd@gnu.org>
2480
2481 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
2482
11273115
PE
24832012-02-15 Paul Eggert <eggert@cs.ucla.edu>
2484
2485 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
2486 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
2487
c3a70e2b
CY
24882012-02-15 Chong Yidong <cyd@gnu.org>
2489
2490 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
2491 marked as special. Also, starting docstrings with * is obsolete.
2492
0ca43699
AS
24932012-02-13 Andreas Schwab <schwab@linux-m68k.org>
2494
2495 * gnutls.c (emacs_gnutls_write): Fix last change.
2496
2e8f3c56
LI
24972012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
2498
2499 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
2500 send_process.
2501
af70074f
SM
25022012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
2503
2504 * keymap.c (Fsingle_key_description): Handle char ranges.
2505
95986d52
CY
25062012-02-12 Chong Yidong <cyd@gnu.org>
2507
afd83bd1
CY
2508 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
2509 as that creates a dangerous corner case.
2510
95986d52
CY
2511 * window.c (Fdelete_window_internal): Invalidate the mouse
2512 highlight (Bug#9904).
2513
bd7da63e
GM
25142012-02-12 Glenn Morris <rgm@gnu.org>
2515
2516 * xselect.c (Fx_own_selection_internal)
2517 (Fx_get_selection_internal, Fx_disown_selection_internal)
2518 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
2519 * nsselect.m (Fx_own_selection_internal)
2520 (Fx_disown_selection_internal, Fx_selection_exists_p)
2521 (Fx_selection_owner_p, Fx_get_selection_internal):
2522 Sync docs and argument specs with the xselect.c versions.
2523
77abcbc2
LI
25242012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
2525
2526 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
2527
90b671e2
EZ
25282012-02-11 Eli Zaretskii <eliz@gnu.org>
2529
1c0ca0b7
EZ
2530 * w32select.c (Fx_selection_exists_p): Sync doc string and
2531 argument list with xselect.c. (Bug#10783)
2532
2533 * w16select.c (Fx_selection_exists_p): Sync doc string and
2534 argument list with xselect.c. (Bug#10783)
90b671e2 2535
49241268
GM
25362012-02-10 Glenn Morris <rgm@gnu.org>
2537
2538 * fns.c (Fsecure_hash): Doc fix.
2539
f998bbe7 25402012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
2541
2542 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
2543
0992bd9c
CY
25442012-02-07 Chong Yidong <cyd@gnu.org>
2545
2546 * buffer.c (Fbuffer_local_variables)
2547 (buffer_lisp_local_variables): Handle unbound vars correctly;
2548 don't let Qunbound leak into Lisp.
2549
af008560
GM
25502012-02-07 Glenn Morris <rgm@gnu.org>
2551
dd605cc4
GM
2552 * image.c (Fimagemagick_types): Doc fix.
2553
af008560
GM
2554 * image.c (imagemagick-render-type): Change it from a lisp object
2555 to an integer. Move the doc here from the lisp manual.
2556 Treat all values not equal to 0 the same.
2557
1449fa1d
CY
25582012-02-06 Chong Yidong <cyd@gnu.org>
2559
2560 * doc.c (store_function_docstring): Avoid applying docstring of
2561 alias to base function (Bug#2603).
2562
3723ec07
AS
25632012-02-04 Andreas Schwab <schwab@linux-m68k.org>
2564
2565 * .gdbinit (pp1, pv1): Remove redundant defines.
2566 (pr): Use pp.
2567
79c1cc1e
CY
25682012-02-04 Chong Yidong <cyd@gnu.org>
2569
2570 * nsterm.m: Declare a global (Bug#10694).
2571
d7f29f8e
EZ
25722012-02-04 Eli Zaretskii <eliz@gnu.org>
2573
cae07000
SM
2574 * w32.c (get_emacs_configuration_options):
2575 Include --enable-checking, if specified, in the return value.
d7f29f8e 2576
3b95a6f9
MR
25772012-02-04 Martin Rudalics <rudalics@gmx.at>
2578
2579 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
2580 after rounding frame sizes. (Bug#9723)
2581
d6fa96a6
EZ
25822012-02-04 Eli Zaretskii <eliz@gnu.org>
2583
2584 * keyboard.c (adjust_point_for_property): Don't position point
2585 before BEGV. (Bug#10696)
2586
df0b2940
PE
25872012-02-03 Paul Eggert <eggert@cs.ucla.edu>
2588
2589 Handle overflow when computing char display width (Bug#9496).
2590 * character.c (char_width): Return EMACS_INT, not int.
2591 (char_width, c_string_width): Check for overflow when
2592 computing the width; this is possible now that individual
2593 characters can have unbounded width. Problem introduced
2594 by merge from Emacs 23 on 2012-01-19.
2595
6bee44d6
MA
25962012-02-02 Michael Albinus <michael.albinus@gmx.de>
2597
2598 * dbusbind.c (Fdbus_register_method): Mention the return value
2599 :ignore in the docstring.
2600
44f92739
GM
26012012-02-02 Glenn Morris <rgm@gnu.org>
2602
1b9f60cc
GM
2603 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
2604
44f92739
GM
2605 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2606 Unconditionally set to t. (Bug#10673)
2607 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2608 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2609 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
2610
c5d3843c
KH
26112012-02-02 Kenichi Handa <handa@m17n.org>
2612
2613 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
2614 0, do not call append_composite_glyph.
2615
159462d4 26162012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
2617
2618 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
2619 NULL (Bug#6988).
2620 (x_produce_glyphs): If the component of a composition is a null
2621 string, set it->pixel_width to 1 to avoid zero-width glyph.
2622
78cef877
EZ
26232012-02-01 Eli Zaretskii <eliz@gnu.org>
2624
2625 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
2626 first 2 arguments are identical. This makes inserting large
2627 output from a subprocess an order of magnitude faster on
2628 MS-Windows, where all sbrk'ed memory is always contiguous.
2629
97897668
GM
26302012-01-31 Glenn Morris <rgm@gnu.org>
2631
2632 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 2633 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
2634 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
2635
31fd3586
GM
26362012-01-29 Glenn Morris <rgm@gnu.org>
2637
2638 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
2639
0e24a8b2
CY
26402012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
2641
2642 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
2643
cc0adcb0
CY
26442012-01-28 Chong Yidong <cyd@gnu.org>
2645
2646 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
2647
acc28cb9
CY
26482012-01-26 Chong Yidong <cyd@gnu.org>
2649
9c69cfb7
CY
2650 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
2651
acc28cb9
CY
2652 * search.c (Fsearch_forward, Fsearch_backward): Document negative
2653 repeat counts (Bug#10507).
2654
48da7392
GM
26552012-01-26 Glenn Morris <rgm@gnu.org>
2656
2657 * lread.c (syms_of_lread): Doc fix.
2658
14af5f7f
CY
26592012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
2660
2661 * coding.c (encode_designation_at_bol): Change return value to
2662 EMACS_INT.
2663
0b21c100
CY
26642012-01-25 Chong Yidong <cyd@gnu.org>
2665
2666 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
2667
3c2907f7
CY
26682012-01-21 Chong Yidong <cyd@gnu.org>
2669
2670 * floatfns.c (Fcopysign): Make the second argument non-optional,
2671 since nil is not allowed anyway.
2672
959ad23f
AS
26732012-01-21 Andreas Schwab <schwab@linux-m68k.org>
2674
2675 * process.c (read_process_output): Use p instead of XPROCESS (proc).
2676 (send_process): Likewise.
2677
34a02f46
MR
26782012-01-19 Martin Rudalics <rudalics@gmx.at>
2679
2680 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
2681 (Vwindow_persistent_parameters): Do not use Qstate.
2682 Rewrite doc-strings.
34a02f46 2683
1259009a 26842012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
2685
2686 * character.c (char_width): New function.
70d4fdf6
GM
2687 (Fchar_width, c_string_width, lisp_string_width):
2688 Use char_width (Bug#9496).
25ed9e61 2689
6a6ee00d
MR
26902012-01-16 Martin Rudalics <rudalics@gmx.at>
2691
2692 * window.c (Vwindow_persistent_parameters): New variable.
2693 (Fset_window_configuration, save_window_save): Handle persistent
2694 window parameters.
2695
c85efaf7
EZ
26962012-01-14 Eli Zaretskii <eliz@gnu.org>
2697
2698 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
2699 thrashing the stack of the thread. (Bug#9087)
2700
5944709e
PE
27012012-01-12 Paul Eggert <eggert@cs.ucla.edu>
2702
2703 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
2704
e71f5d99
EZ
27052012-01-11 Eli Zaretskii <eliz@gnu.org>
2706
2707 * xdisp.c (rows_from_pos_range): Handle the case where the
2708 highlight ends on a newline. (Bug#10464)
2709 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
2710 he end column for display of highlight that ends on a newline
2711 before a R2L line.
2712
ce316182
GM
27132012-01-11 Glenn Morris <rgm@gnu.org>
2714
2715 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
2716 from load-path also when installation-directory is nil. (Bug#10208)
2717
5b43da69
GM
27182012-01-10 Glenn Morris <rgm@gnu.org>
2719
74cc8ff9
GM
2720 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
2721
7d8d6e4e
GM
2722 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
2723 Update template values to be closer to their typical values these days.
5b43da69 2724
a0db8d43
EZ
27252012-01-09 Eli Zaretskii <eliz@gnu.org>
2726
2727 * xdisp.c (rows_from_pos_range): Accept additional argument
2728 DISP_STRING, and accept any glyph in a row whose object is that
2729 string as eligible for mouse highlight. Fixes mouse highlight of
2730 display strings from overlays. (Bug#10464)
2731
9a0115ab 27322012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 2733
b9110d6a 2734 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
2735 * fileio.c (auto_saving_dir_umask): New static var.
2736 (Fmake_directory_internal): Use it.
2737 (do_auto_save_make_dir): Set it, instead of invoking chmod after
2738 creating the directory. The old code temporarily assigns
2739 too-generous permissions to the directory.
2740 (do_auto_save_eh): Clear it.
b9110d6a 2741 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
2742 that the var is always cleared.
2743
6c1bd3f3
EZ
27442012-01-07 Eli Zaretskii <eliz@gnu.org>
2745
2746 * search.c (scan_buffer): Pass character positions to
2747 know_region_cache, not byte positions. (Bug#6540)
2748
069d2b50
L
27492012-01-07 LynX <_LynX@bk.ru> (tiny change)
2750
2751 * w32.c (sys_rename): Report EXDEV when rename of a directory
2752 fails because the target is on another logical disk. (Bug#10284)
2753
75bf0d33
DB
27542012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
2755
2756 * xterm.c (x_embed_request_focus): New function.
2757
2758 * xterm.h: Add prototype.
2759
2760 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
2761
1c6e5a32
GM
27622012-01-05 Glenn Morris <rgm@gnu.org>
2763
2764 * emacs.c (emacs_copyright): Update short copyright year to 2012.
2765
651e947e
EZ
27662012-01-01 Eli Zaretskii <eliz@gnu.org>
2767
2768 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
2769 Load gnutls_transport_set_lowat only if GnuTLS version is below
2770 2.11.1.
2771 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
2772 GnuTLS versions below 2.11.1.
2773
3778cdd8
AL
27742011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
2775
2776 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
2777 to the doc string advising against its use for altering the way
2778 windows are scrolled.
2779
0e5317f7
KH
27802011-12-28 Kenichi Handa <handa@m17n.org>
2781
2782 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
2783 coding-system ASCII compatible only when it does not produce BOM
2784 on encoding (Bug#10383).
2785
93d5ca1f
JD
27862011-12-26 Jan Djärv <jan.h.d@swipnet.se>
2787
2788 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
2789 can scroll.
2790 (create_and_show_popup_menu): Always use menu_position_func for
2791 Gtk3 (Bug#10361).
2792
ca22b785
AS
27932011-12-24 Andreas Schwab <schwab@linux-m68k.org>
2794
2795 * callint.c (Fcall_interactively): Don't truncate prompt string.
2796
d048e1e6
EZ
27972011-12-23 Eli Zaretskii <eliz@gnu.org>
2798
2799 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
2800 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 2801 resumed from there (after widening). (Bug#10360)
d048e1e6 2802
5ccaba1f
JD
28032011-12-22 Jan Djärv <jan.h.d@swipnet.se>
2804
2805 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
2806
204ee57f
JD
28072011-12-21 Jan Djärv <jan.h.d@swipnet.se>
2808
b81d40f0
JB
2809 * nsterm.m (x_free_frame_resources):
2810 Release f->output_data.ns->miniimage.
204ee57f
JD
2811 (ns_index_color): Fix indentation. Do not retain
2812 color_table->colors[i].
2813
2814 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
2815 before returning.
2816
2817 * nsfns.m (x_set_background_color): Assign return value from
2818 ns_index_color to face-background instead of NSColor*.
2819 (ns_implicitly_set_icon_type): Fix indentation.
2820 Change assignment in for loop to comparison.
2821
2822 * emacs.c (ns_pool): New variable.
2823 (main): Assign ns_pool.
2824 (Fkill_emacs): Call ns_release_autorelease_pool.
2825
2826 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
2827 autorelease fdesc, release fdAttrs and tdict.
2828 (ns_get_covering_families): Release charset.
2829 (ns_findfonts): Release NSFontDescriptor created with new.
2830 (ns_uni_to_glyphs): Fix indentation.
2831 (setString): Release attrStr before assigning new value.
2832
c803b2b7
JD
28332011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2834
678f4426
JD
2835 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
2836 and NS_IMPL_COCOA.
2837 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
2838 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
2839
cd394be1 28402011-12-18 David Reitter <reitter@cmu.edu>
678f4426 2841
5fecd5fc
JD
2842 * nsterm.m (ns_term_init): Subscribe for notifications
2843 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
2844 to method trackingNotification in EmacsMenu.
2845
2846 * nsmenu.m (trackingMenu): New variable.
3771cb17 2847 (trackingNotification): New method (from Aquamacs).
5fecd5fc 2848 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 2849 from Aquamacs (Bug#7030).
678f4426
JD
2850
28512011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 2852
c803b2b7
JD
2853 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
2854 (symbol_to_nsstring): Fix indentation.
2855 (ns_symbol_to_pb): New function.
cae07000
SM
2856 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
2857 (Fns_rotate_cut_buffers_internal): Remove.
2858 (Fns_store_selection_internal): Rename from
c803b2b7
JD
2859 Fns_store_cut_buffer_internal.
2860 (ns_get_foreign_selection, Fx_own_selection_internal)
2861 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
2862 (Fns_get_selection_internal, Fns_store_selection_internal):
2863 Use ns_symbol_to_pb and check if return value is nil.
2864 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
2865 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
2866 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
2867 renamed to Sns_store_selection_internal.
2868 (ns_handle_selection_request): Move code to Fx_own_selection_internal
2869 and remove this function.
2870 (ns_handle_selection_clear): Remove, never used.
2871 (Fx_own_selection_internal): Move code from ns_handle_selection_request
2872 here.
2873
e1b01a3a
KB
28742011-12-17 Ken Brown <kbrown@cornell.edu>
2875
2876 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
2877 GID is unknown (Bug#10257).
2878
2adb6e85
PE
28792011-12-17 Paul Eggert <eggert@cs.ucla.edu>
2880
2881 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
2882 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
2883 which caused a build failure on GNU/Linux IA-64. This problem was
2884 introduced by my 2011-10-07 patch.
2885
d1d7b339
JL
28862011-12-15 Juri Linkov <juri@jurta.org>
2887
2888 * image.c (imagemagick_error): New function. (Bug#10112)
2889 (imagemagick_load_image): Comment out `MagickSetResolution' call.
2890 Use `imagemagick_error' where ImageMagick functions return
2891 `MagickFalse'.
2892 (Fimagemagick_types): Add `Fnreverse' to return the list in the
2893 proper order.
2894
100d5755
KH
28952011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2896
2897 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
2898 fill background (Bug#8992).
2899
454592a6
MR
29002011-12-13 Martin Rudalics <rudalics@gmx.at>
2901
2902 * window.c (Vwindow_combination_resize)
2903 (Vwindow_combination_limit): Use t instead of non-nil in
2904 doc-strings.
61d4b438
MR
2905 (Vrecenter_redisplay): Add first sentence of doc-string on
2906 separate line.
53524d93 2907 (Frecenter): Fix doc-string typo.
454592a6 2908
3633e3aa
KH
29092011-12-11 Kenichi Handa <handa@m17n.org>
2910
2911 * coding.c (Funencodable_char_position): Pay attention to the
2912 buffer text relocation (Bug#9389).
2913
7b9d523a 29142011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 2915
7b9d523a
JD
2916 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
2917 gtk_init (Bug#10100).
2918
b73189c6
EZ
29192011-12-10 Eli Zaretskii <eliz@gnu.org>
2920
2921 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
2922 IT->string is nil. (Bug#10263)
2923
f7dfe5d6
JD
29242011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2925
83faebb4
JD
2926 * nsterm.h (x_free_frame_resources): Declare.
2927
f7dfe5d6
JD
2928 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
2929 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
2930
2931 * nsterm.h (ns_get_defaults_value): Declare.
2932
2933 * nsterm.m (ns_default): Call ns_get_defaults_value.
2934
7cd4e72c
EZ
29352011-12-09 Eli Zaretskii <eliz@gnu.org>
2936
2937 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
2938 (Bug#10170)
2939
b34d7317
YM
29402011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2941
2942 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
2943 that where the value of an _OBJC_* symbol points to is in the .bss
2944 section (Bug#10240).
2945
76470ad1
KH
29462011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2947
2948 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 2949 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 2950
745fff94
KH
29512011-12-08 Kenichi Handa <handa@m17n.org>
2952
2953 * ftfont.c (get_adstyle_property): Fix previous change
2954 (Bug#10233).
2955
6e44397c
JB
29562011-12-07 Juanma Barranquero <lekktu@gmail.com>
2957
2958 * w32.c (init_environment): If no_site_lisp, remove site-lisp
2959 dirs from the default value of EMACSLOADPATH (bug#10208).
2960
7efa6272
GM
29612011-12-07 Glenn Morris <rgm@gnu.org>
2962
2963 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
2964 installation and source directories as well. (Bug#10208)
2965
f6fc4d87
CY
29662011-12-06 Chong Yidong <cyd@gnu.org>
2967
2968 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
2969
2bf26180
GM
29702011-12-06 Glenn Morris <rgm@gnu.org>
2971
2972 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
2973 as an error, not just -1. (Bug#10217)
2974
3a6ad4f0
CY
29752011-12-05 Chong Yidong <cyd@gnu.org>
2976
2977 * keyboard.c (process_special_events): New function.
2978 (swallow_events, Finput_pending_p): Use it (Bug#10195).
2979
75a3b399
PE
29802011-12-05 Paul Eggert <eggert@cs.ucla.edu>
2981
2982 * coding.c (encode_designation_at_bol): Don't use uninitialized
2983 local variable (Bug#9318).
2984
c3c9e25e
KH
29852011-12-05 Kenichi Handa <handa@m17n.org>
2986
2987 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
2988 return Qnil (Bug#8046, Bug#10193).
2989
5eb05ea3
KH
29902011-12-05 Kenichi Handa <handa@m17n.org>
2991
2992 * coding.c (encode_designation_at_bol): New args charbuf_end and
2993 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
2994 (coding_set_source): Return how many bytes coding->source was
2995 relocated.
2996 (coding_set_destination): Return how many bytes
2997 coding->destination was relocated.
2998 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 2999 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
3000
30012011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3002
3003 * coding.c (CODING_CHAR_CHARSET_P): New macro.
3004 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
3005 macro (Bug#9318).
3006
30072011-12-05 Andreas Schwab <schwab@linux-m68k.org>
3008
3009 The following changes are to fix Bug#9318.
3010
a79703f5 3011 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
3012 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
3013 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 3014 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 3015
7dbda6df
JB
30162011-12-05 Juanma Barranquero <lekktu@gmail.com>
3017
3018 * lisp.h (process_quit_flag): Fix external declaration.
3019
6d5eb5b0
SM
30202011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
3021
3022 Don't macro-inline non-performance-critical code.
3023 * eval.c (process_quit_flag): New function.
3024 * lisp.h (QUIT): Use it.
3025
a0c3fad0
JD
30262011-12-04 Jan Djärv <jan.h.d@swipnet.se>
3027
3028 * nsfns.m (get_geometry_from_preferences): New function.
3029 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
3030
6c07aac2
AS
30312011-12-04 Andreas Schwab <schwab@linux-m68k.org>
3032
3033 * emacs.c (Qkill_emacs): Define.
3034 (syms_of_emacs): Initialize it.
3035 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
3036 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
3037 (quit_throw_to_read_char): Add parameter `from_signal'.
3038 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
3039 * lisp.h (QUIT): Call Fkill_emacs if requested.
3040
c052ead4
JD
30412011-12-03 Jan Djärv <jan.h.d@swipnet.se>
3042
3043 * widget.c (update_wm_hints): Return if wmshell is null.
3044 (widget_update_wm_size_hints): New function.
3045
3046 * widget.h (widget_update_wm_size_hints): Declare.
3047
3048 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
3049 widget_update_wm_size_hints (Bug#10104).
3050
9e49252b
EZ
30512011-12-03 Eli Zaretskii <eliz@gnu.org>
3052
3053 * xdisp.c (handle_invisible_prop): If the invisible text ends just
3054 before a newline, prepare the bidi iterator for consuming the
3055 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 3056 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 3057
02b16839
JL
30582011-12-02 Juri Linkov <juri@jurta.org>
3059
3060 * search.c (Fword_search_regexp): New Lisp function created from
3061 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
3062 (Fword_search_backward, Fword_search_forward)
3063 (Fword_search_backward_lax, Fword_search_forward_lax):
3064 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
3065 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
3066
0068070e
SM
30672011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
3068
3069 * fileio.c (Finsert_file_contents): Move after-change-function call
3070 to before the "handled:" label, since all "goto handled" appear in
3071 cases where the *-change-functions have already been properly called
3072 (bug#10117).
3073
3360a3fc
AS
30742011-12-01 Andreas Schwab <schwab@linux-m68k.org>
3075
3076 * keyboard.c (interrupt_signal): Don't call kill-emacs when
3077 waiting for input. (Bug#10169)
3078
73d6c093
EZ
30792011-11-30 Eli Zaretskii <eliz@gnu.org>
3080
3081 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
3082 verifies glyph row's hash code--we have just reallocated the
3083 glyphs, so their contents can be complete garbage. (Bug#10164)
3084
febe6bea
JB
30852011-11-30 Juanma Barranquero <lekktu@gmail.com>
3086
3087 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
3088
801a4313
EZ
30892011-11-30 Eli Zaretskii <eliz@gnu.org>
3090
3091 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
3092 attributes are tested _before_ calling verify_row_hash, to protect
3093 against GCC re-ordering of the tests. (Bug#10164)
3094
2b56b87e
JD
30952011-11-29 Jan Djärv <jan.h.d@swipnet.se>
3096
3097 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
3098
3099 * xterm.c (handle_one_xevent): Only set async_visible and friends
3100 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 3101 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
3102 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
3103
dbf31225
PE
31042011-11-28 Paul Eggert <eggert@cs.ucla.edu>
3105
3106 Remove GCPRO-related macros that exist only to avoid shadowing locals.
3107 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
3108 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
3109 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3110 All uses changed to use GCPRO1 etc.
3111 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
3112 Revert to old implementation (i.e., before 2011-03-11).
3113
1305621b
YM
31142011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3115
3116 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
3117 of scroll runs so as to avoid assigning disabled bogus rows and
3118 unnecessary graphics copy operations.
3119
8c9afb46
EZ
31202011-11-27 Eli Zaretskii <eliz@gnu.org>
3121
3122 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
3123 (snprintf) [_MSC_VER]: Redirect to _snprintf.
3124 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
3125 (malloc, free, realloc, calloc): Redirect to e_* only when
3126 compiling Emacs.
3127
3128 * lisp.h (GCTYPEBITS): Move before first use.
3129 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
3130 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
3131 this macro definition.
3132
3133 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
3134 _MSC_VER.
3135
54e9e3bf
JD
31362011-11-27 Jan Djärv <jan.h.d@swipnet.se>
3137
6d5eb5b0
SM
3138 * gtkutil.c (xg_create_frame_widgets):
3139 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
3140 present with Gtk+ 2.0.
3141
83aca1cb
PE
31422011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3143
3144 * fileio.c (Finsert_file_contents): Undo previous change; see
3145 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3146
5b76caa4
PE
31472011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3148
3149 Rename locals to avoid shadowing.
3150 * fileio.c (Finsert_file_contents):
3151 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
3152 * process.c (wait_reading_process_output):
3153 Rename inner 'proc' to 'p' to avoid shadowing.
3154 Indent for consistency with usual Emacs style.
3155
8c535114
EZ
31562011-11-25 Eli Zaretskii <eliz@gnu.org>
3157
3158 * xdisp.c (redisplay_window): If cursor row is not fully visible
3159 after recentering, and scroll-conservatively is set to a large
3160 number, scroll window by a few more lines to make the cursor fully
3161 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
3162 (start_display): Don't move to the next line if the display should
3163 start at a newline that is part of a display vector or an overlay
3164 string. (Bug#10119)
8c535114 3165
fa4fdb5c
JL
31662011-11-24 Juri Linkov <juri@jurta.org>
3167
3168 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
3169 after the `MagickPingImage' call. (Bug#10112)
3170
90ec88df
CY
31712011-11-23 Chong Yidong <cyd@gnu.org>
3172
3173 * window.c (Fcoordinates_in_window_p): Accept only live windows.
3174
56e2e794
MR
31752011-11-23 Martin Rudalics <rudalics@gmx.at>
3176
3177 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
3178 making another buffer current. (Bug#10114)
3179
b6e64c41
GM
31802011-11-23 Glenn Morris <rgm@gnu.org>
3181
3182 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
3183
6b21de18
CY
31842011-11-23 Chong Yidong <cyd@gnu.org>
3185
3186 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
3187 using it (Bug#5984).
3188
b12cd789
EZ
31892011-11-22 Eli Zaretskii <eliz@gnu.org>
3190
3191 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
3192 and header-lines, as they don't have one computed for them.
3193 (Bug#10098)
3194
3195 * .gdbinit (prow): Make displayed values more self-explaining.
3196 Add row's hash code.
3197
261b6fd4
LMI
31982011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
3199
3200 * process.c (wait_reading_process_output): Fix asynchrounous
3201 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 3202 (wait_reading_process_output): Add comment and URL.
261b6fd4 3203
e7cfd277
JD
32042011-11-21 Jan Djärv <jan.h.d@swipnet.se>
3205
3206 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
3207
a9b9b7f5
CY
32082011-11-21 Chong Yidong <cyd@gnu.org>
3209
3210 * window.c (Fnext_window, Fprevious_window): Doc fix.
3211
b0d15b4f
SM
32122011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3213
3214 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
3215
fe7a3057
JB
32162011-11-20 Juanma Barranquero <lekktu@gmail.com>
3217
3218 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
3219
d2999b1a
MR
32202011-11-20 Martin Rudalics <rudalics@gmx.at>
3221
3222 * window.c (Fset_window_combination_limit): Rename argument
3223 STATUS to LIMIT.
3224 (Vwindow_combination_limit): Remove "status" from doc-string.
3225
d5ff9cd0
AS
32262011-11-20 Andreas Schwab <schwab@linux-m68k.org>
3227
3228 * m/ibms390.h: Remove.
3229 * m/ibms390x.h: Don't include "ibms390.h".
3230
a5bb9bd3
SM
32312011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3232
3233 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
3234 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
3235
cd1181db
JB
32362011-11-20 Juanma Barranquero <lekktu@gmail.com>
3237
3238 * casetab.c (Fset_case_table):
3239 * charset.c (Fcharset_after): Fix typos.
3240
615a3b8d 32412011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 3242
17e845af
PE
3243 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
3244 Otherwise, valgrind does not work on some platforms.
3245 Problem reported by Andreas Schwab in
6a0bf43d
PE
3246 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
3247 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
3248 is set, removing the need for VIRT_ADDRESS_VARIES.
3249 (PURE_P): Use a more-efficient implementation that needs just one
3250 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
3251 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
3252 to 4 (xorl, subq, cmpq, setbe).
3253 * alloc.c (pure): Always extern now, since that's the
3254 VIRT_ADDR_VARIES behavior.
3255 (PURE_POINTER_P): Use a single comparison, not two, for
3256 consistency with the new puresize.h.
3257 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
3258 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
3259 Remove VIRT_ADDR_VARIES no longer needed.
3260
f8fe6f96
EZ
32612011-11-19 Eli Zaretskii <eliz@gnu.org>
3262
3263 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
3264 (erase_phys_cursor, update_window_cursor, show_mouse_face)
3265 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
3266 behave as if the cursor position were at the window margin.
3267
3268 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
3269 and the cursor position is out of bounds, behave as if the cursor
3270 position were at the window margin. (Bug#10075)
3271
df05a53c
CY
32722011-11-18 Chong Yidong <cyd@gnu.org>
3273
3274 * window.c (Fwindow_combination_limit): Make first argument
3275 non-optional, since it is meaningless for live windows like the
3276 selected window.
61ccba97 3277
2071918e
DA
32782011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
3279
3280 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
3281
b50a28de
SM
32822011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
3283
3284 * intervals.c: Fix grafting over the whole buffer (bug#10071).
3285 (graft_intervals_into_buffer): Simplify.
3286
015137db
EZ
32872011-11-18 Eli Zaretskii <eliz@gnu.org>
3288
3289 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
3290 hash values of the two rows.
3291 (copy_row_except_pointers): Preserve the used[] arrays and the
3292 hash values of the two rows. (Bug#10035)
68c95424 3293 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
3294
3295 * xdisp.c (row_hash): New function, body extracted from
3296 compute_line_metrics.
3297 (compute_line_metrics): Call row_hash, instead of computing the
3298 hash code inline.
3299
3300 * dispnew.c (verify_row_hash): Call row_hash for computing the
3301 hash code of a row, instead of duplicating code from xdisp.c.
3302
3303 * dispextern.h (row_hash): Add prototype.
3304
a2addb04
TH
33052011-11-18 Tassilo Horn <tassilo@member.fsf.org>
3306
3307 * frame.c (delete_frame): Don't delete the terminal when the last
3308 X frame is closed if emacs is built with GTK toolkit.
3309
df85d315
JB
33102011-11-17 Juanma Barranquero <lekktu@gmail.com>
3311
3312 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
3313
a0c2d0ae
MR
33142011-11-17 Martin Rudalics <rudalics@gmx.at>
3315
3316 * window.c (Vwindow_splits): Rename to
3317 Vwindow_combination_resize. Suggested by Juri Linkov.
3318 (Fsplit_window_internal): Use Vwindow_combination_resize instead
3319 of Vwindow_splits.
3320
58179cce
JB
33212011-11-16 Juanma Barranquero <lekktu@gmail.com>
3322
7877f373
JB
3323 * nsfns.m (Fns_font_name):
3324 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 3325
b6f67890
MR
33262011-11-16 Martin Rudalics <rudalics@gmx.at>
3327
3328 * window.h (window): Rename slot "nest" to "combination_limit".
3329 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
3330 (Fset_window_nest): Rename to Fset_window_combination_limit.
3331 (Vwindow_nest): Rename to Vwindow_combination_limit.
3332 (recombine_windows, make_parent_window, make_window)
3333 (Fsplit_window_internal, saved_window)
3334 (Fset_window_configuration, save_window_save): Rename all
3335 occurrences of window_nest to window_combination_limit.
3336
c7015153
JB
33372011-11-15 Juanma Barranquero <lekktu@gmail.com>
3338
3339 * image.c (imagemagick_load_image): Fix typo.
3340
322ad6ec
EZ
33412011-11-14 Eli Zaretskii <eliz@gnu.org>
3342
3343 * xdisp.c (display_line): Move the call to
3344 highlight_trailing_whitespace before the call to
3345 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
3346 faces of all the glyphs to compute ROW's hash value.
3347 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 3348
f067b8ec
JB
33492011-11-14 Juanma Barranquero <lekktu@gmail.com>
3350
3351 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
3352 just return (bug#10044).
3353
1e5b2111
EZ
33542011-11-12 Eli Zaretskii <eliz@gnu.org>
3355
7ef3cbd5
EZ
3356 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
3357 with user-defined heap size. Bump the default size of the temacs
3358 heap to 27MB, to avoid memory warning when running temacs.
3359 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
3360
1e5b2111
EZ
3361 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
3362 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
3363 (verify_row_hash) [XASSERTS]: New function.
3364 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
3365 that the hash value of glyph rows is correct.
1e5b2111 3366
89d61221
MR
33672011-11-12 Martin Rudalics <rudalics@gmx.at>
3368
3369 * window.h (window): Remove splits slot.
3370 * window.c (Fwindow_splits, Fset_window_splits): Remove.
3371 (Fdelete_other_windows_internal, make_parent_window)
3372 (make_window, Fsplit_window_internal, Fdelete_window_internal)
3373 (Fset_window_configuration, save_window_save): Don't deal with
3374 split status of windows.
3375 (saved_window): Remove splits slot.
3376 (Vwindow_splits): Rewrite doc-string.
3377
97f18cc8
JD
33782011-11-11 Jan Djärv <jan.h.d@swipnet.se>
3379
3380 * xfns.c (unwind_create_frame):
3381 * nsfns.m (unwind_create_frame):
3382 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
3383 Vframe_list (Bug#9999).
3384
22a648b4
DA
33852011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
3386
0b381c7e 3387 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 3388
659afede
KH
33892011-11-11 Kenichi Handa <handa@m17n.org>
3390
3391 * callproc.c (Fcall_process): Set the member dst_multibyte of
3392 process_coding.
3393
9ac0394b
KH
33942011-11-11 Johan Bockgård <bojohan@gnu.org>
3395
3396 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
3397 avoid a crash (bug#9496).
3398
2fbdc249
CY
33992011-11-09 Chong Yidong <cyd@gnu.org>
3400
3401 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
3402 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
3403
ac6b1f81
PE
34042011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3405
3406 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
3407
09db192c
PE
34082011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3409
3410 Avoid some portability problems by eschewing 'extern inline' functions.
3411 The trivial performance wins aren't worth the portability hassles; see
3412 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
3413 et seq.
3414 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3415 (window_box_width, window_box_left, window_box_left_offset)
3416 (window_box_right, window_box_right_offset): Undo previous change,
3417 by removing the "extern"s.
3418 * intervals.c (adjust_intervals_for_insertion)
3419 (adjust_intervals_for_deletion): Undo previous change,
3420 making these static again.
3421 (offset_intervals, temp_set_point_both, temp_set_point)
3422 (copy_intervals_to_string): No longer inline.
3423 * xdisp.c (window_text_bottom_y, window_box_width)
3424 (window_box_height, window_box_left_offset)
3425 (window_box_right_offset, window_box_left, window_box_right)
3426 (window_box): No longer inline.
3427
105216ed
CY
34282011-11-08 Chong Yidong <cyd@gnu.org>
3429
3430 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
3431 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
3432 Signal an error if not a live window.
105216ed
CY
3433 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
3434 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
3435
ae9e237f
JB
34362011-11-07 Juanma Barranquero <lekktu@gmail.com>
3437
3438 * lisp.h (syms_of_abbrev): Remove declaration.
3439 Reported by CHENG Gao <chenggao@royau.me>.
3440
c7aa8333
EZ
34412011-11-07 Eli Zaretskii <eliz@gnu.org>
3442
3443 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
3444 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
3445 of temacs in GUI mode.
3446
be7f5545
MR
34472011-11-07 Martin Rudalics <rudalics@gmx.at>
3448
3449 * window.h: Declare delete_all_child_windows instead of
3450 delete_all_subwindows.
3451 * window.c (Fwindow_nest, Fset_window_nest)
3452 (Fset_window_new_total, Fset_window_new_normal)
3453 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
3454 (delete_all_subwindows): Rename to delete_all_child_windows.
3455 (Fdelete_other_windows_internal, Fset_window_configuration):
3456 Call delete_all_child_windows instead of delete_all_subwindows.
3457 * frame.c (delete_frame): Call delete_all_child_windows instead
3458 of delete_all_subwindows.
3459
ca78dc43
PE
34602011-11-07 Paul Eggert <eggert@cs.ucla.edu>
3461
3462 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
3463 This is also needed for porting to any host where GC_MARK_STACK is
3464 not GC_MAKE_GCPROS_NOOPS.
3465 (which_symbols): Use it.
3466
a0241d01
KH
34672011-11-07 Kenichi Handa <handa@m17n.org>
3468
3469 * coding.c (coding_set_destination): Check coding->src_pos only
3470 when coding->src_object is a buffer (bug#9910).
3471
3472 * process.c (send_process): Set the member src_multibyte of coding
3473 to 0 (bug#9911) when sending a unibyte text.
3474
3475 * callproc.c (Fcall_process): Set the member src_multibyte of
3476 process_coding to 0 (bug#9912).
3477
a64bfdfa 34782011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
3479
3480 * xmenu.c (cleanup_widget_value_tree): New function.
3481 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
3482 calling free_menubar_widget_value_tree directly (Bug#9830).
3483
cb41b32a
PE
34842011-11-06 Paul Eggert <eggert@cs.ucla.edu>
3485
3486 Fix some portability problems with 'inline'.
3487 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3488 (window_box_width, window_box_left, window_box_left_offset)
3489 (window_box_right, window_box_right_offset): Declare extern.
3490 Otherwise, these inline functions do not conform to C99 and
3491 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
3492 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
3493 * intervals.c (adjust_intervals_for_insertion)
3494 (adjust_intervals_for_deletion): Now extern, because otherwise the
3495 extern inline functions 'offset_intervals' couldn't refer to it.
3496 (static_offset_intervals): Remove.
3497 (offset_intervals): Rewrite using the old contents of
3498 static_offset_intervals. The old version didn't conform to C99
3499 because an extern inline function contained a reference to an
3500 identifier with static linkage.
3501
b7041366
AS
35022011-11-06 Andreas Schwab <schwab@linux-m68k.org>
3503
3504 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
3505 GC.
3506
88a37c4d
EZ
35072011-11-06 Eli Zaretskii <eliz@gnu.org>
3508
3509 * xdisp.c (init_iterator, reseat_to_string): Don't set the
3510 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
3511 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
3512 return Qleft_to_right.
3513
49745b39
CY
35142011-11-06 Chong Yidong <cyd@gnu.org>
3515
3516 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
3517 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
3518 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
3519 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
3520 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
3521 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
3522 (Fwindow_vscroll): Doc fix.
3523 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
3524 argument, since it makes no sense to pass a live window and for
3525 consistency with window-child.
3526
1f05cd82
CS
35272011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
3528
3529 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
3530 support MSVC.
3531
22610910
JR
35322011-11-05 Jason Rumney <jasonr@gnu.org>
3533
3534 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
3535 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
3536 fonts (Bug#6029).
3537 (add_font_entity_to_list): Fix logic errors in mixed boolean and
3538 bitwise arithmetic preventing use of unicode-sip and non-truetype
3539 opentype fonts.
3540
a06776b2
EZ
35412011-11-05 Eli Zaretskii <eliz@gnu.org>
3542
3ad924ba
EZ
3543 * s/ms-w32.h (fstat, stat, utime): Move redirections to
3544 "emacs"-only part.
3545
a06776b2
EZ
3546 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
3547 initialization code to keep similarity to xfns.c after changes
3548 from 2011-11-05.
3549
c9e7db78
JD
35502011-11-05 Jan Djärv <jan.h.d@swipnet.se>
3551
a97f8f3f
JD
3552 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
3553 (unwind_create_frame): New function (Bug#9943).
3554 (Fx_create_frame): Restructure code to be more similar to the one in
3555 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
3556 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
3557 Move terminal->reference_count++ just before making the frame official
3558 (Bug#9943).
3559
3560 * nsterm.m (x_free_frame_resources): New function.
3561 (x_destroy_window): Move code to x_free_frame_resources.
3562
c9e7db78 3563 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
3564 (Fx_create_frame, x_create_tip_frame):
3565 Move terminal->reference_count++ just before making the frame
75f1671a 3566 official. Move initialization of image_cache_refcount and
c9e7db78
JD
3567 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
3568
a6fc3b5c
EZ
35692011-11-05 Eli Zaretskii <eliz@gnu.org>
3570
3571 Support MSVC build with newer versions of Visual Studio.
3572 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
3573 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
3574 nt/gmake.defs.
3575
3576 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
3577 which are not supported by MSVC.
3578 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
3579 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
3580 bitfields.
3581 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
3582 types in bitfields.
3583 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
3584
3585 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
3586
58179cce 35872011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
3588
3589 Support MSVC build with newer versions of Visual Studio.
3590 * w32.c: Don't include w32api.h for MSVC.
3591 (init_environment) [_MSC_VER]: Call sys_access, not _access.
3592
3593 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
3594 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
3595 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
3596 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
3597 e_* cousins.
3598 (alloca) [_MSC_VER]: Define to _alloca.
3599
3600 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
3601
3602 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
3603
a58c13ed
EZ
36042011-11-04 Eli Zaretskii <eliz@gnu.org>
3605
3606 * xdisp.c (note_mouse_highlight): If either of
3607 previous/next-single-property-change returns nil, treat that as
3608 the beginning or the end of the buffer. (Bug#9955)
3609
fe0b6370
JD
36102011-11-04 Jan Djärv <jan.h.d@swipnet.se>
3611
a58c13ed 3612 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
3613 label is not null (Bug#9951).
3614 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
3615 may be NULL.
3616
89bd5ee1
EZ
36172011-11-04 Eli Zaretskii <eliz@gnu.org>
3618
3619 * window.c (Fwindow_body_size): Mention in the doc string that the
3620 return value is in frame's canonical units. (Bug#9949)
3621
84c3edb9
EZ
36222011-11-03 Eli Zaretskii <eliz@gnu.org>
3623
4e2fb5c7
EZ
3624 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
3625
84c3edb9 3626 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 3627 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 3628 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 3629
bc17a887
EZ
36302011-11-01 Eli Zaretskii <eliz@gnu.org>
3631
3632 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
3633 Don't stop backward scan on the continuation glyph, even though
3634 its CHARPOS is positive.
6d5eb5b0
SM
3635 (mouse_face_from_buffer_pos, note_mouse_highlight):
3636 Rename cover_string to disp_string.
bc17a887 3637
4ee88440
MR
36382011-11-01 Martin Rudalics <rudalics@gmx.at>
3639
3640 * window.c (temp_output_buffer_show): Don't use
3641 Vtemp_buffer_show_specifiers.
3642 (Vtemp_buffer_show_specifiers): Remove unused variable.
3643
c2ff3c02
EZ
36442011-10-30 Eli Zaretskii <eliz@gnu.org>
3645
3646 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
3647 past the beginning of the current glyph matrix.
3648
58179cce 36492011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
3650
3651 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
3652 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
3653 HAVE_GTK3 (Bug#9869).
b77a6a7f 3654
3b574623
JD
3655 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
3656 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
3657
b77a6a7f
JD
3658 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
3659
3660 * xterm.c: Declare x_handle_net_wm_state to return int.
3661 (handle_one_xevent): Check if we are iconified but don't have
3662 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
3663 (get_current_wm_state): Return non-zero if not hidden,
3664 check for _NET_WM_STATE_HIDDEN (Bug#9893).
3665 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
3666 (x_handle_net_wm_state): Return what get_current_wm_state returns.
3667 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
3668
196e41e4
PE
36692011-10-29 Paul Eggert <eggert@cs.ucla.edu>
3670
3671 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
3672 so that this new function doesn't get optimized away by a
3673 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
3674
021f2e1a
AS
36752011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3676
3677 * frame.h (MOUSE_HL_INFO): Remove excess parens.
3678
8b058d44
EZ
36792011-10-29 Eli Zaretskii <eliz@gnu.org>
3680
3681 Fix the `xbytecode' command.
3682 * .gdbinit (xprintbytestr): New command.
b50a28de 3683 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
3684 (xbytecode): Print the byte-code string as well.
3685
4452fb80
EZ
36862011-10-29 Kim Storm <storm@cua.dk>
3687
8b058d44
EZ
3688 * alloc.c (which_symbols): New function.
3689
21b72067
AS
36902011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3691
3692 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
3693 line. (Bug#9903)
3694
83ed7b5c
GM
36952011-10-29 Glenn Morris <rgm@gnu.org>
3696
3697 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
3698 Not clear what it was for, and it causes various bugs. (Bug#9839)
3699
5a7a728b
EZ
37002011-10-28 Eli Zaretskii <eliz@gnu.org>
3701
3702 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
3703 possible random value that matches one of those tested as
3704 condition to clear the mouse face.
3705
d3d0842f
CY
37062011-10-28 Chong Yidong <cyd@gnu.org>
3707
3708 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
3709
31b39d13
DN
37102011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
3711
3712 * window.c (make_window): Initialize phys_cursor_on_p.
3713
9aba6043
SM
37142011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
3715
3716 * lisp.h (struct Lisp_Symbol): Update comments.
3717
c20992f4
JB
37182011-10-28 Juanma Barranquero <lekktu@gmail.com>
3719
3720 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
3721
db4f02f2
EZ
37222011-10-28 Eli Zaretskii <eliz@gnu.org>
3723
3724 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
3725 <oslsachem@gmail.com> for helping to debug this.
3726
3727 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
3728 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
3729 (g_b_init_get_glyph_outline_w): New static variables.
3730 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
3731 (GetGlyphOutlineW_Proc): New typedefs.
3732 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
3733 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
3734 New functions.
3735 (w32font_open_internal, compute_metrics):
3736 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
3737 instead of calling the "wide" APIs directly.
3738
3739 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
3740
3741 * w32.h (syms_of_w32font): Add prototype.
3742
87e68db4
JB
37432011-10-27 Juanma Barranquero <lekktu@gmail.com>
3744
3745 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
3746 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
3747 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
3748 (Fmove_to_window_line): Doc fix.
3749
435c1d67
CY
37502011-10-27 Chong Yidong <cyd@gnu.org>
3751
3752 * process.c (make_process): Set gnutls_state to NULL.
3753
3754 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
3755 non-NULL, regardless of GNUTLS_INITSTAGE.
3756 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
3757 an error. Set process slots as soon as we allocate them.
3758
3759 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
3760
9c6c6f49
CY
37612011-10-27 Chong Yidong <cyd@gnu.org>
3762
9aba6043
SM
3763 * gnutls.c (emacs_gnutls_deinit): New function.
3764 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
3765 (Fgnutls_deinit, Fgnutls_boot): Use it.
3766
3767 * process.c (make_process): Initialize GnuTLS credentials to NULL.
3768 (deactivate_process): Call emacs_gnutls_deinit.
3769
657d08d3
JB
37702011-10-27 Juanma Barranquero <lekktu@gmail.com>
3771
3772 * image.c (x_create_x_image_and_pixmap):
3773 * w32.c (sys_rename, w32_delayed_load):
3774 * w32font.c (fill_in_logfont):
3775 * w32reg.c (x_get_string_resource): Silence compiler warnings.
3776
5430d399
JB
37772011-10-26 Juanma Barranquero <lekktu@gmail.com>
3778
3779 * w32fns.c (w32_default_color_map): New function,
3780 extracted from Fw32_default_color_map.
a7ef684b 3781 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 3782
fe0055fa
PE
37832011-10-25 Paul Eggert <eggert@cs.ucla.edu>
3784
3785 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
3786
e6346438
SM
37872011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
3788
3789 * keyboard.c (test_undefined): New function (bug#9751).
3790 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
3791
e112cc37
ET
37922011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
3793
3794 * sysdep.c (init_sys_modes): Fix the check for the controlling
3795 terminal (Bug#6649).
3796
7b5d6677
EZ
37972011-10-20 Eli Zaretskii <eliz@gnu.org>
3798
3799 * dispextern.h (struct bidi_it): New member next_en_type.
3800
3801 * bidi.c (bidi_line_init): Initialize the next_en_type member.
3802 (bidi_resolve_explicit_1): When next_en_pos is valid for the
3803 current character, check also for next_en_type being WEAK_EN.
3804 (bidi_resolve_weak): Don't enter the expensive loop if the current
3805 position is before next_en_pos. Record the bidi type of the first
3806 non-ET, non-BN character we find, in addition to its position.
3807 (bidi_level_of_next_char): Invalidate next_en_type when
3808 next_en_pos is over-stepped.
3809
7da0b018
PE
38102011-10-20 Paul Eggert <eggert@cs.ucla.edu>
3811
3812 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
3813 * editfns.c: Rewrite current-time-zone so that it invokes
3814 the equivalent of (format-time-string "%Z") to get the time zone name.
3815 This fixes a bug when the time zone name contains characters that
3816 need converting from the system time locale to Emacs internal format.
3817 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
3818 that patch fixed format-time-string to do the conversion, but
3819 I forgot to fix current-time-zone.
3820 (format_time_string): New function, containing most of
3821 what Fformat_time_string used to contain.
3822 (Fformat_time_string): Rewrite in terms of format_time_string.
3823 This doesn't change this function's behavior.
3824 (current-time-zone): Rewrite to use format_time_string.
3825 This fixes the bug reported by Michael Schierl in
3826 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
3827 Jason Rumney's 2007-06-07 change worked around this bug, but
3828 didn't fix it.
3829 * systime.h (tzname, timezone): Remove no-longer-used declarations.
3830
8547b010
EZ
38312011-10-19 Eli Zaretskii <eliz@gnu.org>
3832
3833 * xdisp.c (start_display): If the character at POS is displayed
3834 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
3835 (try_window_reusing_current_matrix): If a line ends in a display
3836 vector or the next line starts in a display vector, continue
3837 redrawing the window even though the character position of
3838 start_row was reached.
8547b010
EZ
3839 (Bug#9771, part 2)
3840
4e948d15
CY
38412011-10-18 Chong Yidong <cyd@gnu.org>
3842
3843 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
3844 with nobreak-char-display too.
3845
4787455f
EZ
38462011-10-18 Eli Zaretskii <eliz@gnu.org>
3847
3848 Fix part 3 of bug#9771.
3849 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
3850 (bidi_resolve_neutral): Don't enter the expensive loop looking for
3851 non-neutral characters if the current character is a paragraph
3852 separator (a.k.a. Newline). This avoids running the same
3853 expensive loop twice, once when we consume the preceding newline
3854 and the other time when the line actually needs to be displayed.
3855 Avoid the loop when we see neutrals on the base embedding level
3856 following a character whose directionality is the same as the
3857 paragraph's. This avoids running the expensive loop when a line
3858 ends in a long sequence of neutrals, like control characters.
3859 Add assertion against STRONG_AL type. Slightly rearrange code
3860 that determines the type of a neutral given the first non-neutral
3861 that follows it.
3862 (bidi_level_of_next_char): Set next_en_pos to zero when
3863 invalidating its info.
3864
2c91f553
EZ
38652011-10-17 Eli Zaretskii <eliz@gnu.org>
3866
3867 * xdisp.c (push_display_prop): Determine whether to record string
3868 or buffer position by IT->string, not by IT->method. Allow
3869 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
3870 (move_it_vertically_backward): Don't look for character position
3871 immediately after the newline when in a continuation line.
3872 (Bug#9771, part 1)
2c91f553 3873
c7b08b0d
MR
38742011-10-15 Martin Rudalics <rudalics@gmx.at>
3875
3876 * window.c (coordinates_in_window): Rewrite and delabelize
3877 vertical border check. (Bug#5357) (Bug#9618)
3878
6b02f655
SM
38792011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
3880
3881 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
3882 errors in XSetWindowBorder (bug#9310).
3883
81d40c92
DA
38842011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
3885
3886 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
3887 avoid crash when xmalloc overrun checking is enabled.
3888
d4172c3b
EZ
38892011-10-13 Eli Zaretskii <eliz@gnu.org>
3890
3891 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
3892 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
3893 cursor motion with <left> and <right> arrow keys.
3894
3895 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
3896 some callers set that themselves.
3897
b00eea75
EZ
38982011-10-12 Eli Zaretskii <eliz@gnu.org>
3899
3900 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
3901 display string and the previous row comes from the same string and
3902 is empty. (Bug#9739) (Bug#9738)
3903
8fe012c4
SM
39042011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
3905
3906 * doc.c (get_doc_string): Encode file name (bug#9735).
3907
0074aef2
EZ
39082011-10-12 Eli Zaretskii <eliz@gnu.org>
3909
79beb178
EZ
3910 * bidi.c (bidi_level_of_next_char):
3911 * xdisp.c (get_visually_first_element): Remove old incorrect
3912 comments regarding the Unicode Line Separator character.
3913
0074aef2
EZ
3914 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
3915
6e4b3fbe
DA
39162011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
3917
3918 * alloc.c (Fgc_status): Do not access beyond zombies array
3919 boundary if nzombies > MAX_ZOMBIES.
3920 * alloc.c (dump_zombies): Add missing format specifier.
3921
0324f3af
PE
39222011-10-12 Paul Eggert <eggert@cs.ucla.edu>
3923
b5525cac
PE
3924 * xdisp.c (set_cursor_from_row): Simplify conditionals,
3925 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
3926
0324f3af
PE
3927 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
3928 Some packages use them to denote characters with modifiers.
3929
e9b5f888
AS
39302011-10-11 Andreas Schwab <schwab@linux-m68k.org>
3931
3932 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
3933 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
3934 matching a pp-number. Rename parameter var to var1.
3935
127827c0
SM
39362011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
3937
3938 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
3939
c8fd3bd0
GM
39402011-10-08 Glenn Morris <rgm@gnu.org>
3941
3942 * callint.c (Fcall_interactively): Give a more explicit error for the
3943 'c' case with a non-character input. (Bug#8479)
3944
352ec8ff
EZ
39452011-10-08 Eli Zaretskii <eliz@gnu.org>
3946
03669ccb
EZ
3947 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
3948 lines.
7061c986
EZ
3949 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
3950 lines that are hscrolled on the left.
03669ccb 3951
352ec8ff
EZ
3952 * dispnew.c (buffer_posn_from_coords): Account for a possible
3953 presence of header-line. (Bug#4426)
3954
a66cfb1c
SM
39552011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
3956
6b02f655
SM
3957 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
3958 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 3959
7c5ee88e
PE
39602011-10-07 Paul Eggert <eggert@cs.ucla.edu>
3961
3962 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
3963 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
3964 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
3965 this makes Emacs dump core during garbage collection on rare
3966 occasions. sizeof is obviously inferior to offsetof here, so
3967 stick with offsetof.
3968 (GC_POINTER_ALIGNMENT): New macro.
3969 (mark_memory): Omit 3rd (offset) arg; caller changed.
3970 Don't assume EMACS_INT alignment is the same as pointer alignment.
3971
df1bbe5b
SM
39722011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
3973
3974 * keyboard.c (read_key_sequence_remapped): New var.
3975 (read_key_sequence): Compute remapping in the right buffer.
3976 (command_loop_1): Use read_key_sequence's remapping directly.
3977
51553db6
SM
39782011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
3979
32c1fffd
SM
3980 * dired.c (file_name_completion): Don't expand file name.
3981 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
3982 before checking file name handler.
3983
51553db6
SM
3984 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
3985 they've been requested explicitly (bug#9591).
3986
b6bd1599 39872011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
3988
3989 * keymap.c (Fsingle_key_description): Use make_specified_string
3990 instead of build_string to build string from push_key_description.
3991 (Bug#5193)
3992
f701dc2a
PE
39932011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3994
4222c55d
PE
3995 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
3996 This fixes a Y2038 bug on 64-bit hosts.
3997 * buffer.c (reset_buffer):
3998 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
3999 (Fclear_buffer_auto_save_failure):
4000 Use 0, not -1, to represent an unset failure time, since time_t
4001 might not be signed.
4002
f701dc2a
PE
4003 Remove dependency on glibc malloc internals.
4004 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4005 Move back here from lisp.h, but with their new implementations.
4006 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4007 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
4008 * charset.c (charset_table_init): New static var.
4009 (syms_of_charset): Use it instead of xmalloc. This removes a
4010 dependency on glibc malloc internals. See Eli Zaretskii's comment in
4011 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
4012 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4013 Move back to alloc.c.
4014 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4015 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
4016
9ceebf39
JD
40172011-09-30 Jan Djärv <jan.h.d@swipnet.se>
4018
4019 * nsterm.m (windowDidResize): Call x_set_window_size only when
4020 ns_in_resize is true. Otherwise set pixelwidth/height and
4021 call change_frame_size (Bug#9628).
4022
cb993c58
PE
40232011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4024
3930c88b
PE
4025 Port --enable-checking=all to Fedora 14 x86-64.
4026 * charset.c (syms_of_charset): Also account for glibc malloc's
4027 internal overhead when calculating the initial malloc maximum.
4028
cb993c58
PE
4029 Port --enable-checking=all to Fedora 14 x86.
4030 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4031 Move to lisp.h.
4032 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
4033 (overrun_check_realloc, overrun_check_free):
4034 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
4035 That way, xmalloc returns a properly-aligned pointer even if
4036 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
4037 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
4038 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
4039 into account when calculating the initial malloc maximum.
4040 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4041 Move here from alloc.c, so that charset.c can use it too.
4042 Properly align; the old code wasn't right for common 32-bit hosts
4043 when configured with --enable-checking=all.
4044 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4045 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
4046
31bed486
EZ
40472011-09-29 Eli Zaretskii <eliz@gnu.org>
4048
04c70788 4049 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
4050 use EDOM.
4051
fbcaa2f3
EZ
40522011-09-28 Eli Zaretskii <eliz@gnu.org>
4053
4054 * xdisp.c (compute_display_string_end): If there's no display
4055 string at CHARPOS, return -1.
4056
4057 * bidi.c (bidi_fetch_char): When compute_display_string_end
4058 returns a negative value, treat the character as a normal
4059 character not covered by a display string. (Bug#9624)
4060
a239d4e9
JB
40612011-09-28 Juanma Barranquero <lekktu@gmail.com>
4062
4063 * lread.c (Fread_from_string): Fix typo in docstring.
4064
88652fd5
EZ
40652011-09-27 Eli Zaretskii <eliz@gnu.org>
4066
4067 * xdisp.c (handle_invisible_prop): If invisible text ends on a
4068 newline, reseat the iterator instead of bidi-iterating there one
4069 character at a time. (Bug#9610)
32c1fffd
SM
4070 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
4071 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 4072
ed497dd4
AS
40732011-09-27 Andreas Schwab <schwab@linux-m68k.org>
4074
4075 * lread.c (readevalloop): Use correct code for NBSP.
4076 (read1): Likewise. (Bug#9608)
4077
b2bf61aa
MA
40782011-09-25 Michael Albinus <michael.albinus@gmx.de>
4079
4080 * dbusbind.c (Fdbus_register_signal): When service is not
4081 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
4082
32bbb17c
GM
40832011-09-25 Glenn Morris <rgm@gnu.org>
4084
4085 * buffer.c (truncate-lines): Doc fix.
4086
94e0933e
CY
40872011-09-24 Chong Yidong <cyd@stupidchicken.com>
4088
4089 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
4090 (Fset_window_next_buffers): Doc fix.
4091
cddde921
GM
40922011-09-24 Glenn Morris <rgm@gnu.org>
4093
4094 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
4095
1260aef1
PE
40962011-09-24 Paul Eggert <eggert@cs.ucla.edu>
4097
25b4bfa0
PE
4098 Fix minor problems found by static checking.
4099 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
4100 * indent.c (Fvertical_motion): Fix == vs = typo.
4101
e3cbd34b
EZ
41022011-09-24 Eli Zaretskii <eliz@gnu.org>
4103
a66cfb1c
SM
4104 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
4105 Default value is now t. Doc fix.
6bf7006f 4106
e3cbd34b 4107 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 4108 logic when moving up, not only when moving down. Fix the
e3cbd34b 4109 confusing name and values of the it_overshoot_expected variable;
32c1fffd 4110 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
4111
4112 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
4113 CHARPOS is covered by a display string which includes newlines.
4114 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
4115 is covered by a display string with embedded newlines.
4116
a3de0cbd
MA
41172011-09-24 Michael Albinus <michael.albinus@gmx.de>
4118
4119 * dbusbind.c (Fdbus_register_signal): Add match rule to
4120 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
4121 (Fdbus_register_method, Vdbus_registered_objects_table):
4122 Fix docstring.
a3de0cbd 4123
b260039d
JM
41242011-09-24 Jim Meyering <meyering@redhat.com>
4125
32c1fffd 4126 do not ignore write error for any output size
b260039d
JM
4127 The previous change was incomplete.
4128 While it makes emacs --batch detect the vast majority of stdout
4129 write failures, errors were still ignored whenever the output size is
4130 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
4131 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
4132 && echo FAIL: ignored write error
4133 FAIL: ignored write error
4134 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
4135 && echo FAIL: ignored write error
4136 FAIL: ignored write error
4137 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
4138
8eca8a7c
AS
41392011-09-23 Andreas Schwab <schwab@linux-m68k.org>
4140
4141 * emacs.c (Fkill_emacs): In noninteractive mode exit
4142 non-successfully if a write error occurred on stdout. (Bug#9574)
4143
3341db62
EZ
41442011-09-21 Eli Zaretskii <eliz@gnu.org>
4145
4146 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
4147 the xassert test.
4148
4149 * dispextern.h (struct it): Update the comment documenting what
4150 can it->OBJECT be.
4151
8c203dbf
EZ
41522011-09-20 Eli Zaretskii <eliz@gnu.org>
4153
4154 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
4155 a display string, extend search for cursor position to end of row.
4156 (find_row_edges): If the row ends in a newline from a display
4157 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
4158 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
4159 (Fcurrent_bidi_paragraph_direction): Fix search for previous
4160 non-empty line. Fixes confusing cursor motion with arrow keys at
4161 the beginning of a line that starts with whitespace.
8c203dbf 4162
a4824228
LMI
41632011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4164
4165 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
4166 (bug#9493).
4167
33ed493b
CY
41682011-09-18 Chong Yidong <cyd@stupidchicken.com>
4169
4170 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
4171 boolean (Bug#9154).
4172
56cd55c8
EZ
41732011-09-18 Eli Zaretskii <eliz@gnu.org>
4174
4175 * xdisp.c (display_line): Record maximum and minimum buffer
4176 positions even if no glyphs were produced (e.g., by a zero-width
4177 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
4178 buffer positions that will be removed from the glyph row because
4179 they don't fit.
c02dcedf
EZ
4180 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
4181 column is beyond frame width: don't subtract 1 "pixel" when
4182 computing width of the stretch.
3e62b7e0
EZ
4183 (reseat_at_next_visible_line_start): Undo the change made on
4184 2011-09-17 that saved paragraph information and restored it after
4185 the call to `reseat'. (Bug#9545)
56cd55c8 4186
5ed99d36 41872011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
4188
4189 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
4190 and turn window cursor on if cleared (Bug#9415).
4191
5ed99d36 41922011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
4193
4194 * search.c (boyer_moore): Take unibyte characters from pattern
4195 literally. (Bug#9458)
4196
9bade7b2
EZ
41972011-09-18 Eli Zaretskii <eliz@gnu.org>
4198
4199 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
4200
e5e9d610
PE
42012011-09-18 Paul Eggert <eggert@cs.ucla.edu>
4202
87e4427a
PE
4203 Fix minor problem found by static checking.
4204 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
4205 initialized, to pacify gcc -Wuninitialized.
4206
e5e9d610
PE
4207 * fileio.c: Report proper errno when syscall falls.
4208 (Finsert_file_contents): Save and restore errno,
4209 so that report_file_error outputs the correct diagnostic.
4210 (Fwrite_region) [CLASH_DETECTION]: Likewise.
4211
a1674f0b
EZ
42122011-09-18 Eli Zaretskii <eliz@gnu.org>
4213
4214 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
4215
fbfb6dd4
EZ
42162011-09-17 Eli Zaretskii <eliz@gnu.org>
4217
4218 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
4219 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
4220
bb187662
EZ
42212011-09-17 Eli Zaretskii <eliz@gnu.org>
4222
1137e8b8 4223 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 4224 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
4225
4226 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
4227 (bidi_find_paragraph_start): Search back for paragraph beginning
4228 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
4229 (bidi_move_to_visually_next): Only trigger paragraph-related
4230 computations when the last character is a newline or at EOB, not
4231 just any NEUTRAL_B. (Bug#9470)
4232
bb187662
EZ
4233 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
4234 truncated lines if point is covered by a display string. (Bug#9524)
4235
2e621251
PE
42362011-09-16 Paul Eggert <eggert@cs.ucla.edu>
4237
4238 * xselect.c: Relax test for outgoing X longs (Bug#9498).
4239 (cons_to_x_long): New function.
4240 (lisp_data_to_selection_data): Use it. Correct the test for
4241 short-versus-long data; it was negated. Break out of vector
4242 loop, for efficiency, when a long datum is discovered.
4243
91a15bc6
SM
42442011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
4245
4246 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
4247
b41c3a35
EZ
42482011-09-16 Eli Zaretskii <eliz@gnu.org>
4249
4250 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
4251 GCC PR/17406) by declaring this function with external scope.
4252
7812ba2d
PE
42532011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4254
4255 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
4256 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
4257
cf7edc2a
AS
42582011-09-15 Andreas Schwab <schwab@linux-m68k.org>
4259
4260 * editfns.c (Fformat): Correctly handle text properties on "%%".
4261
bd01620e
EZ
42622011-09-15 Eli Zaretskii <eliz@gnu.org>
4263
4264 * xterm.c (x_draw_composite_glyph_string_foreground):
4265 * w32term.c (x_draw_composite_glyph_string_foreground):
4266 * term.c (encode_terminal_code):
4267 * composite.c (composition_update_it, get_composition_id):
4268 * xdisp.c (get_next_display_element)
4269 (fill_composite_glyph_string): Add comments about special meaning
4270 of TAB characters in a composition.
4271
a02719a3
PE
42722011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4273
4274 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
4275 This occurs when processing a multibyte format.
4276 Problem reported by Wolfgang Jenker.
a02719a3 4277
72589a3c
JB
42782011-09-15 Johan Bockgård <bojohan@gnu.org>
4279
4280 * xdisp.c (try_cursor_movement): Only check for exact match if
4281 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
4282
1c14176c
PE
42832011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4284
4285 Remove unused external symbols.
4286 * dispextern.h (calc_pixel_width_or_height): Remove decl.
4287 * xdisp.c (calc_pixel_width_or_height): Now static.
4288 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
4289 * indent.c (check_display_width):
4290 * w32term.c: Fix comment to match code.
4291 * xterm.c, xterm.h (x_catching_errors): Remove.
4292
d2eea5b5
PE
42932011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4294
4295 * xselect.c: Use signed conversions more consistently (Bug#9498).
4296 (selection_data_to_lisp_data): Assume incoming selection data are
4297 signed integers, not unsigned. This is to be consistent with
4298 outgoing selection data, which was modified to use signed integers
4299 in as part of the fix to Bug#9196 in response to Jan D.'s comment
4300 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
4301 expects long, not unsigned long.
4302
46888499
EZ
43032011-09-14 Eli Zaretskii <eliz@gnu.org>
4304
4305 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
4306 computation of loop end. Reported by Johan Bockgård
4307 <bojohan@gnu.org>.
4308
ef8ef9fb
CY
43092011-09-13 Chong Yidong <cyd@stupidchicken.com>
4310
4311 * frame.c (Fother_visible_frames_p): Function deleted.
4312
fa819fed
EZ
43132011-09-12 Eli Zaretskii <eliz@gnu.org>
4314
4315 * indent.c (compute_motion): Process display vector front to back
4316 rather than the other way around. (Bug#2496)
4317
2ba8e008
SM
43182011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
4319
4320 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
4321
20f53c69
CY
43222011-09-11 Chong Yidong <cyd@stupidchicken.com>
4323
4324 * minibuf.c (Fread_from_minibuffer): Doc fix.
4325
d562d7a4
EZ
43262011-09-11 Eli Zaretskii <eliz@gnu.org>
4327
4328 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
4329 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
4330
1c4d7f3d
LMI
43312011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4332
4333 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
4334 value for non-existent files.
4335
b885bf36
EZ
43362011-09-11 Eli Zaretskii <eliz@gnu.org>
4337
4338 * fileio.c (Finsert_file_contents): If the file cannot be opened,
4339 set its "size" to -1. This will set the modtime_size field of
4340 the corresponding buffer to -1, which is what
4341 verify-visited-file-modtime expects for files that do not exist.
4342 (Bug#9139)
4343
6612f0bf
PE
43442011-09-11 Paul Eggert <eggert@cs.ucla.edu>
4345
4346 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
4347 here ...
4348 * lisp.h: ... from here. push_key_description is no longer
4349 defined in keyboard.c, so its declaration should not be in
4350 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
4351 logically belongs with push_key_description.
4352
dfb3f755
PE
43532011-09-10 Paul Eggert <eggert@cs.ucla.edu>
4354
4355 * buffer.h: Include <sys/types.h> instead of <time.h>.
4356 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
4357 Problem reported by Herbert J. Skuhra.
4358
3134906c
LMI
43592011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
4360
4361 * xml.c (parse_region): Make the parsing work for
4362 non-comment-starting XML files again (bug#9144).
4363
8d903f4e
AS
43642011-09-10 Andreas Schwab <schwab@linux-m68k.org>
4365
4366 * image.c (gif_load): Fix calculation of bottom and right corner.
4367 (Bug#9468)
4368
80ad64f4
EZ
43692011-09-10 Eli Zaretskii <eliz@gnu.org>
4370
4371 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
4372 redisplay in small windows.
4373
208a048d
EZ
43742011-09-09 Eli Zaretskii <eliz@gnu.org>
4375
4376 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
4377
9b1c252e
MR
43782011-09-08 Martin Rudalics <rudalics@gmx.at>
4379
4380 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
4381 Operate on live windows only.
4382
2949f33b
JB
43832011-09-08 Juanma Barranquero <lekktu@gmail.com>
4384
4385 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
4386
e08dcafd
EZ
43872011-09-07 Eli Zaretskii <eliz@gnu.org>
4388
4389 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
4390 only under bidi iteration.
4391
115b96bd
JD
43922011-09-07 Jan Djärv <jan.h.d@swipnet.se>
4393
4394 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
4395
c8199d0f
PE
43962011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4397
4398 isnan: Fix porting problem to Solaris 10 with bundled gcc.
4399 Without this fix, the command to link temacs failed due to an
4400 undefined symbol __builtin_isnan. This is because
4401 /usr/include/iso/math_c99.h #defines isnan(x) to
4402 __builtin_isnan(x), but the bundled gcc, which identifies itself
4403 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
4404 a __builtin_isnan.
4405 * floatfns.c (isnan): #undef, and then #define to a clone of
4406 what's in data.c.
4407 (Fisnan): Always define, since it's always available now.
4408 (syms_of_floatfns): Always define isnan at the Lisp level.
4409
e39b275c 44102011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
4411
4412 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
4413
b2db44d9 44142011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 4415
f4af5137 4416 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
4417 The previous code assumed that file offsets (off_t values) fit in
4418 EMACS_INT variables, which is not true on typical 32-bit hosts.
4419 The code messed up by falsely reporting buffer overflow in cases
4420 such as (insert-file-contents "big" nil 1 2) into an empty buffer
4421 when "big" contains more than 2**29 bytes, even though this
4422 inserts just one byte and does not overflow the buffer.
4423 (Finsert_file_contents): Store file offsets as off_t
4424 values, not as EMACS_INT values. Check for overflow when
4425 converting between EMACS_INT and off_t. When checking for
4426 buffer overflow or for overlap, take the offsets into account.
4427 Don't use EMACS_INT for small values where int suffices.
4428 When checking for overlap, fix a typo: ZV was used where
4429 ZV_BYTE was intended.
4430 (Fwrite_region): Don't assume off_t fits into 'long'.
4431 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
4432
ecfc0a49
MA
44332011-09-05 Michael Albinus <michael.albinus@gmx.de>
4434
4435 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
4436
6511acf2 44372011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 4438
0999621a 4439 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
4440
4441 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 4442 (esprintf, exprintf, evxprintf): New functions.
62f19c19 4443 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 4444 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
4445 (modify_event_symbol): Do not assume that the length of
4446 name_alist_or_stem is safe to alloca and fits in int.
4447 (Fexecute_extended_command): Likewise for function name and binding.
4448 (Frecursion_depth): Wrap around reliably on integer overflow.
4449 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
4450 since some callers pass EMACS_INT values.
4451 (Fsingle_key_description): Don't crash if symbol name contains more
4452 than MAX_ALLOCA bytes.
4453 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
4454 (get_minibuffer): Arg is now EMACS_INT, not int.
4455 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 4456 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
4457 * window.h (command_loop_level, minibuf_level): Reflect API changes.
4458
2be7d702
PE
4459 * dbusbind.c (signature_cat): New function.
4460 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
4461 Do not overrun buffer; instead, report string overflow.
4462
9d1df220
PE
4463 * dispnew.c (add_window_display_history): Don't overrun buffer.
4464 Truncate instead; this is OK since it's just a log.
4465
33ef5c64
PE
4466 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
4467 even if the time zone offset is outlandishly large.
4468 Don't mishandle offset == INT_MIN.
4469
66c6fdd5
PE
4470 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
4471 when creating daemon; the previous buffer-overflow check was incorrect.
4472
d749b01b
PE
4473 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
4474 which has the guts of the old verror function.
4475
b5cd1905
PE
4476 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
4477 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
4478
6e1a67fb
PE
4479 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
4480 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 4481 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 4482 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
4483 length of string rather than counting it via multiple sprintfs;
4484 that's simpler and more reliable.
c21721cc
PE
4485 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
4486 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
4487 sprintf, in case result does not fit in int.
4488
c57b67fc
PE
4489 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
4490 (fontset_from_font): Print it.
4491
8a401434
PE
4492 * frame.c (tty_frame_count): Now printmax_t, not int.
4493 (make_terminal_frame, set_term_frame_name): Print it.
4494 (x_report_frame_params): In X, window IDs are unsigned long,
4495 not signed long, so print them as unsigned.
4496 (validate_x_resource_name): Check for implausibly long names,
4497 and don't assume name length fits in 'int'.
4498 (x_get_resource_string): Don't blindly alloca invocation name;
4499 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
4500 not fit in int.
4501
6e1a67fb
PE
4502 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
4503 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
4504 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
4505
0df02bf3
PE
4506 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
4507 Use esprintf, not sprintf, in case result does not fit in int.
4508
48e30793
PE
4509 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4510 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
4511 it as a large positive number.
4512 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
4513 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4514
a66ff6d8
PE
4515 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
4516 in case result does not fit in int.
4517
aca216ff
PE
4518 * print.c (float_to_string): Detect width overflow more reliably.
4519 (print_object): Make sprintf buffer a bit bigger, to avoid potential
4520 buffer overrun. Don't assume list length fits in 'int'. Treat
4521 print length of 0 as 0, not as infinity; to be consistent with other
4522 uses of print length in this function. Don't overflow print length
4523 index. Don't assume hash table size fits in 'long', or that
4524 vectorlike size fits in 'unsigned long'.
4525
31c286f7
PE
4526 * process.c (make_process): Use printmax_t, not int, to format
4527 process-name gensyms.
4528
55e5faa1
PE
4529 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
4530
80f2e268
PE
4531 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
4532 to avoid potential buffer overrun.
4533
670741ab
PE
4534 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
4535 if X resource line is longer than 512 bytes.
4536
b7163a50
PE
4537 * xfns.c (x_window): Make sprintf buffer a bit bigger
4538 to avoid potential buffer overrun.
4539
ae58ff1f
PE
4540 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
4541
c43c8a6a
PE
4542 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
4543
3f8236f4
PE
45442011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4545
53e9fe90 4546 Integer overflow fixes for scrolling, etc.
6511acf2
PE
4547 Without these, Emacs silently mishandles large integers sometimes.
4548 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
4549 it were "C-u 1 M-x recenter" on a typical 64-bit host.
4550
6511acf2
PE
4551 * xdisp.c (try_window_id): Check Emacs fixnum range before
4552 converting to 'int'.
806add1d 4553
6511acf2 4554 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
4555 Check that an Emacs fixnum is in range before assigning it to 'int'.
4556 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
4557 values converted from Emacs fixnums.
4558 (Frecenter): Don't wrap around a line count if it is out of 'int'
4559 range; instead, treat it as an extreme value.
4560 (Fset_window_configuration, compare_window_configurations):
4561 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
4562
6511acf2
PE
4563 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
4564 that can exceed INT_MAX. Check that EMACS_INT value is in range
4565 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
4566 (match_limit): Don't assume that a fixnum can fit in 'int'.
4567
6511acf2 4568 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
4569 exceed INT_MAX.
4570
6511acf2 4571 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
4572 (Fvertical_motion): Don't wrap around LINES values that don't fit
4573 in 'int'. Instead, treat them as extreme values. This is good
4574 enough for windows, which can't have more than INT_MAX lines anyway.
4575
fcb901a7
LMI
45762011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4577
0f2f6b6d
LMI
4578 * Require libxml/parser.h to avoid compilation warning.
4579
fcb901a7
LMI
4580 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
4581
4582 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
4583 since this reportedly can destroy thread storage.
4584
6e20a0d4
CY
45852011-08-30 Chong Yidong <cyd@stupidchicken.com>
4586
4587 * syntax.c (find_defun_start): Update all cache variables if
4588 exiting early (Bug#9401).
4589
148ae00e
EZ
45902011-08-30 Eli Zaretskii <eliz@gnu.org>
4591
f6cfbd8f
EZ
4592 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
4593
148ae00e
EZ
4594 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
4595 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
4596 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
4597
4598 * term.c (tty_append_glyph): New function.
4599 (produce_stretch_glyph): Static function and its prototype deleted.
4600
a66cfb1c
SM
4601 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
4602 Add prototypes.
148ae00e 4603
c4a07a4c
PE
46042011-08-29 Paul Eggert <eggert@cs.ucla.edu>
4605
4606 * image.c (parse_image_spec): Check for nonnegative, not for positive,
4607 when checking :margin (Bug#9390).
4608 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 4609 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
4610 so that the name doesn't mislead. All uses changed.
4611
6bc8cd65
JB
46122011-08-28 Johan Bockgård <bojohan@gnu.org>
4613
4614 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
4615 set_tty_hooks.
4616
dca4927e
EZ
46172011-08-27 Eli Zaretskii <eliz@gnu.org>
4618
4619 * xdisp.c (move_it_to): Don't bail out early when reaching
4620 position beyond to_charpos, if we are scanning backwards.
4621 (move_it_vertically_backward): When DY == 0, make sure we get to
4622 the first character in the line after the newline.
4623
f2cad773
PE
46242011-08-27 Paul Eggert <eggert@cs.ucla.edu>
4625
4626 * ccl.c: Improve and simplify overflow checking (Bug#9196).
4627 (ccl_driver): Do not generate an out-of-range pointer.
4628 (Fccl_execute_on_string): Remove unnecessary check for
4629 integer overflow, noted by Stefan Monnier in
4630 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
4631 Remove a FIXME that didn't need fixing.
4632 Simplify the newly-introduced buffer reallocation code.
4633
0cae2cdb
JB
46342011-08-27 Juanma Barranquero <lekktu@gmail.com>
4635
4636 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
4637
5fc295a4 46382011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 4639
70c60eb2 4640 Integer and memory overflow issues (Bug#9196).
726e0ab1 4641
d31850da
PE
4642 * doc.c (get_doc_string): Rework so that
4643 get_doc_string_buffer_size is the actual buffer size, rather than
4644 being 1 less than the actual buffer size; this makes xpalloc more
4645 convenient.
4646
a69fbedb
PE
4647 * image.c (x_allocate_bitmap_record, cache_image):
4648 * xselect.c (Fx_register_dnd_atom):
4649 Simplify previous changes by using xpalloc.
4650
fe5c5d37
PE
4651 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
4652 since either will do and ptrdiff_t is convenient with xpalloc.
4653
0065d054
PE
4654 * charset.c (charset_table_size)
4655 (struct charset_sort_data.priority): Now ptrdiff_t.
4656 (charset_compare): Don't overflow if priorities differ greatly.
4657 (Fsort_charsets): Don't assume list length fits in int.
4658 Check for size-calculation overflow when allocating sort data.
4659 (syms_of_charset): Allocate an initial charset table that is
4660 just under 64 KiB, to avoid problems with glibc malloc and mmap.
4661
4662 * cmds.c (internal_self_insert): Check for size-calculation overflow.
4663
4664 * composite.h (struct composition.glyph_len): Now int, not unsigned.
4665 The actual value is always <= INT_MAX, and leaving it unsigned made
4666 overflow checking harder.
4667
4668 * dispextern.h (struct glyph_matrix.rows_allocated)
4669 (struct face_cache.size): Now ptrdiff_t, for convenience in use
4670 with xpalloc. The values are still always <= INT_MAX.
4671
4672 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
4673
4674 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
4675 (SAFE_NALLOCA): New macro.
4676
4677 * region-cache.c (struct boundary.pos, find_cache_boundary)
4678 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
4679 (set_cache_region, invalidate_region_cache)
4680 (revalidate_region_cache, know_region_cache, region_cache_forward)
4681 (region_cache_backward, pp_cache):
4682 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
4683 so that ptrdiff_t * can be passed to xpalloc.
4684 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
4685 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
4686 (pp_cache): Don't assume cache_len fits in int.
4687 * region-cache.h: Adjust extern decls to match.
4688
4689 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
4690 EMACS_INT, since either will do, for xpalloc.
4691
4692 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
4693 (xnmalloc, xnrealloc, xpalloc): New functions.
4694
726e0ab1
PE
4695 * bidi.c (bidi_shelve_header_size): New constant.
4696 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
4697 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
4698
51f30bc5 4699 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
4700 * buffer.c (overlays_at, overlays_in, record_overlay_string)
4701 (overlay_strings):
4702 Don't update size of array until after memory allocation succeeds,
4703 because xmalloc/xrealloc may not return.
0065d054
PE
4704 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
4705 now that we have proper integer overflow checking.
4706 (record_overlay_string, overlay_strings): Catch overflows when
4707 calculating size of overlay_str_buf.
726e0ab1 4708
0065d054
PE
4709 * callproc.c (Fcall_process): Check for size overflow when
4710 calculating size of args2.
4711 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
4712 Normally we prefer signed values, but sticking with ptrdiff_t would
4713 require adding more-complicated checks.
726e0ab1
PE
4714
4715 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
4716 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
4717 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 4718 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
4719
4720 * character.c (Fstring): Check for size-calculation overflow.
4721
4722 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
4723 unnecessary integer overflow. Check for size overflow.
4724 (encode_coding_object): Don't update size until xmalloc succeeds.
4725
4726 * composite.c (get_composition_id): Check for overflow in glyph
4727 length calculations.
4728
4729 Integer and memory overflow fixes for display code.
4730 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
4731 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
4732 (scrolling_window): Check for overflow in size calculations.
4733 (line_draw_cost, realloc_glyph_pool, add_row_entry):
4734 Don't assume glyph table len fits in int.
4735 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
4736 (row_table_size): Now ptrdiff_t, not int.
4737 (scrolling_window): Avoid overflow in size calculations.
4738 Don't update size until allocation succeeds.
4739 * fns.c (concat): Check for overflow in size calculations.
4740 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
4741 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4742 (NEXT_ALMOST_PRIME_LIMIT): New constant.
4743
4744 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
4745 (get_doc_string): Check for size calculation overflow.
4746 Don't update size until allocation succeeds.
4747 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
4748 EMACS_INT, where ptrdiff_t will do.
4749 (Fsubstitute_command_keys): Check for string overflow.
4750
4751 * editfns.c (set_time_zone_rule): Don't assume environment length
4752 fits in int.
4753 (message_length): Now ptrdiff_t, not int.
4754 (Fmessage_box): Don't update size until allocation succeeds.
4755 Don't assume message length fits in int.
4756 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
4757
0065d054
PE
4758 * emacs.c (main): Do not reallocate argv, since there is a null at
4759 the end that can be overwritten, and this way there's no need to
4760 worry about size-calculation overflow.
4761 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
4762
4763 * eval.c (init_eval_once, grow_specpdl): Don't update size until
4764 alloc succeeds.
4765 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
4766
4767 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
4768 (x_set_scroll_bar_width, x_figure_window_size):
4769 Check for integer overflow.
4770 (x_set_alpha): Do not assume XINT fits in int.
4771
4772 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
4773 This is for the members text_lines, text_cols, total_lines, total_cols,
4774 where the system imposes an 'int' limit.
4775
4776 * fringe.c (Fdefine_fringe_bitmap):
4777 Don't update size until alloc works.
4778
4779 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
4780 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
4781
4782 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
4783 Check for size-calculation overflow.
4784 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
4785 do, as we prefer signed integers.
4786 (id_to_widget.max_size, id_to_widget.used)
4787 (xg_store_widget_in_map, xg_remove_widget_from_map)
4788 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
4789 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
4790 Use and return ptrdiff_t, not int.
4791 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
4792 * gtkutil.h: Change prototypes to match the above.
4793
4794 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
4795 are duplicate now that they've been promoted to lisp.h.
4796 (x_allocate_bitmap_record, x_alloc_image_color)
4797 (make_image_cache, cache_image, xpm_load):
4798 Don't update size until alloc is done.
4799 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
4800 (x_detect_edges):
3256efce 4801 Check for size calculation overflow.
726e0ab1
PE
4802 (ct_colors_allocated_max): New constant.
4803 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
4804 overflow.
3256efce 4805
726e0ab1
PE
4806 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
4807 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
4808 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
4809 Use ptrdiff_t, not int, to count maps.
4810 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
4811 calculations. Don't update size until allocation succeeds.
4812 Redo calculations to avoid overflow.
726e0ab1
PE
4813 * keyboard.h: Change prototypes to match the above.
4814
4815 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
4816 to count maps.
4817 (current_minor_maps): Check for size calculation overflow.
4818 * keymap.h: Change prototypes to match the above.
4819
4820 * lread.c (read1, init_obarray): Don't update size until alloc done.
4821
4822 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
4823 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
4824
726e0ab1
PE
4825 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
4826 Now ptrdiff_t, not int.
4827 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
4828 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
4829
4830 * process.c (Fnetwork_interface_list): Check for overflow
4831 in size calculation.
4832
4833 * region-cache.c (move_cache_gap): Check for size calculation overflow.
4834
4835 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
4836 overflow. Don't bother calling xmalloc when xrealloc will do.
4837
4838 * search.c (Freplace_match): Check for size calculation overflow.
4839 (Fset_match_data): Don't assume list lengths fit in 'int'.
4840
4841 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
4842 for command line length. Do not attempt to address one before the
4843 beginning of an array, as that's not portable.
4844
4845 * term.c (max_frame_lines): Remove; unused.
4846 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
4847 not int.
4848 (encode_terminal_code, calculate_costs): Check for size
4849 calculation overflow.
4850 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
4851 table lengths and related sizes. Don't update size until alloc
4852 done. Redo calculations to avoid overflow.
4853 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
4854
4855 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
4856 subtracting pointers.
4857 (gobble_line): Check for overflow more carefully. Don't update size
4858 until alloc done.
4859
4860 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
4861 Don't update size until alloc done.
4862 Redo size calculations to avoid overflow.
4863 Check for size calculation overflow.
0065d054 4864 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
4865
4866 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
4867 Use ptrdiff_t, not int, for sizes.
4868 (store_mode_line_noprop_char): Don't update size until alloc done.
4869
0065d054
PE
4870 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
4871 Use ptrdiff_t, not int, for sizes.
4872 (Finternal_make_lisp_face, cache_face):
4873 Check for size calculation overflow.
4874 (cache_face): Treat size calculation overflows as if they were
4875 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
4876
4877 * xfns.c (x_encode_text, x_set_name_internal)
4878 (Fx_change_window_property): Use ptrdiff_t, not int, to count
4879 sizes, since they can exceed INT_MAX in size. Check for size
4880 calculation overflow.
4881
0065d054
PE
4882 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
4883 (xg_select): Check for size calculation overflow.
726e0ab1
PE
4884 Don't update size until alloc done.
4885
0065d054 4886 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 4887 as sprintf is limited to int lengths.
1d526e2f 4888
252c5ee1
PE
4889 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
4890 (X_LONG_MIN): New macros.
864d7ce7
PE
4891 Use them to make the following changes clearer.
4892 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
4893 This change doesn't affect the value now, but it may help remind
4894 future maintainers not to raise the value too much later.
4895 (SELECTION_QUANTUM): Remove, replacing with ...
4896 (selection_quantum): ... new function, which avoids overflow.
4897 All uses changed.
4898 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
4899 assumption that selection length fits in 'int'.
4900 (x_reply_selection_request, x_handle_selection_request)
4901 (x_get_window_property, receive_incremental_selection)
4902 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
4903 (lisp_data_to_selection_data, clean_local_selection_data):
4904 Use ptrdiff_t, not int, to record length of selection.
4905 (x_reply_selection_request, x_get_window_property)
4906 (receive_incremental_selection, x_property_data_to_lisp):
4907 Redo calculations to avoid overflow.
4908 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 4909 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
4910 something.
4911 (x_get_window_property, receive_incremental_selection)
4912 (lisp_data_to_selection_data, x_property_data_to_lisp):
4913 Check for size-calculation overflow.
4914 (x_get_window_property, receive_incremental_selection)
4915 (lisp_data_to_selection_data, Fx_register_dnd_atom):
4916 Don't store size until memory allocation succeeds.
4917 (x_get_window_property): Plug memory leak on memory exhaustion.
4918 Don't double-block input; malloc is safe here. Don't assume 2**34
4919 - 4 fits in unsigned long. Add an xassert to check
4920 XGetWindowProperty overflow. Be more careful about overflow
4921 calculations, and distinguish size from memory overflow better.
4922 (receive_incremental_selection): When tracing, don't assume
4923 unsigned int is less than INT_MAX.
4924 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
4925 harmful) conversions of unsigned short to int.
4926 (lisp_data_to_selection_data): Don't assume that integers
4927 in the range -65535 through -1 fit in an X unsigned short.
4928 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
4929 result parameters unless successful. Rely on cons_to_unsigned
4930 to report problems with elements; the old code wasn't right anyway.
4931 (x_check_property_data): Check for int overflow; we cannot use
4932 a wider type due to X limits.
4933 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
4934
726e0ab1 4935 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 4936
0065d054
PE
4937 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
4938 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
4939 (x_color_cells): Don't store size until memory allocation succeeds.
4940 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 4941 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
4942 (x_term_init): Don't assume length fits in int (sprintf is limited
4943 to int size).
bc18e09d 4944
ebfa62c0
PE
4945 Use ptrdiff_t for composition IDs.
4946 * character.c (lisp_string_width):
4947 * composite.c (composition_table_size, n_compositions)
4948 (get_composition_id, composition_gstring_from_id):
4949 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
4950 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
4951 * window.c (Frecenter):
4952 Use ptrdiff_t, not int, for composition IDs.
4953 * composite.c (get_composition_id): Check for integer overflow.
4954 * composite.h: Adjust prototypes to match the above changes.
4955
d3411f89
PE
4956 Use ptrdiff_t for hash table indexes.
4957 * category.c (hash_get_category_set):
4958 * ccl.c (ccl_driver):
4959 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
4960 * coding.c (coding_system_charset_list, detect_coding_system):
4961 * coding.h (struct coding_system.id):
4962 * composite.c (get_composition_id, gstring_lookup_cache):
4963 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
4964 * image.c (xpm_get_color_table_h):
4965 * lisp.h (hash_lookup, hash_put):
4966 * minibuf.c (Ftest_completion):
4967 Use ptrdiff_t for hash table indexes, not int (which is too
4968 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
4969 32-bit --with-wide-int hosts).
4970
e097a6fa
PE
4971 * charset.c (Fdefine_charset_internal): Check for integer overflow.
4972 Add a FIXME comment about memory leaks.
4973 (syms_of_charset): Don't assume xmalloc returns.
4974
5637687f
PE
4975 Don't assume that stated character widths fit in int.
4976 * character.c (Fchar_width, c_string_width, lisp_string_width):
4977 * character.h (CHAR_WIDTH):
4978 * indent.c (MULTIBYTE_BYTES_WIDTH):
4979 Use sanitize_char_width to avoid undefined and/or bad behavior
4980 with outlandish widths.
a66cfb1c 4981 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
4982 now that we have two such functions. All uses changed.
4983 (sanitize_char_width): New inline function.
4984
a2271ba2
PE
4985 Don't assume that tab-width fits in int.
4986 * character.h (sanitize_width): New inline function.
4987 (SANE_TAB_WIDTH): New macro.
4988 (ASCII_CHAR_WIDTH): Use it.
4989 * indent.c (sane_tab_width): Remove. All uses replaced by
4990 SANE_TAB_WIDTH (current_buffer).
4991 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
4992
18c52557
PE
4993 * fileio.c: Integer overflow issues with file modes.
4994 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
4995
caeeedc1
PE
4996 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
4997 Remove unreachable code.
4998 (read_hex, load_charset_map_from_file): Check for integer overflow.
4999
6df6ae42 5000 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
5001 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
5002 (x_send_scroll_bar_event): Likewise. Check that the size does not
5003 exceed limits imposed by XClientMessageEvent, as well as the usual
5004 ptrdiff_t and size_t limits.
5005
b13995db
PE
5006 * keyboard.c: Overflow, signedness and related fixes.
5007 (make_lispy_movement): Use same integer type in forward decl
5008 that is used in the definition.
5009 (read_key_sequence, keyremap_step):
5010 Change bufsize argument back to int, undoing my 2011-03-30 change.
5011 We prefer signed types, and int is wide enough here.
5012 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
5013 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
5014 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
5015 length, not size_t. Use ptrdiff_t for index, not int.
5016 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
5017 possibility of integer overflow.
5018
13464394
PE
5019 Overflow, signedness and related fixes for images.
5020
5021 * dispextern.h (struct it.stack[0].u.image.image_id)
5022 (struct_it.image_id, struct image.id, struct image_cache.size)
5023 (struct image_cache.used, struct image_cache.ref_count):
5024 * gtkutil.c (update_frame_tool_bar):
5025 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
5026 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
5027 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
5028 * nsmenu.m (update_frame_tool_bar):
5029 * xdisp.c (calc_pixel_width_or_height):
5030 * xfns.c (image_cache_refcount):
5031 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
5032 on typical 64-bit hosts.
5033
5034 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5035 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
5036 Omit unnecessary casts to int.
5037 (parse_image_spec): Check that integers fall into 'int' range
5038 when the callers expect that.
5039 (image_ascent): Redo ascent calculation to avoid int overflow.
5040 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
5041 (lookup_image): Remove unnecessary tests.
5042 (xbm_image_p): Locals are now of int, not EMACS_INT,
5043 since parse_image_check makes sure they fit into int.
5044 (png_load, gif_load, svg_load_image):
5045 Prefer int to unsigned where either will do.
5046 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
5047 old tiff_error_handler and tiff_warning_handler.
5048 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
5049 stack buffer overflows. It uses only the features of vsnprintf
5050 that are common to both POSIX and native Microsoft.
5051 (tiff_error_handler, tiff_warning_handler): Use it.
5052 (tiff_load, gif_load, imagemagick_load_image):
5053 Don't assume :index value fits in 'int'.
5054 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
5055 (imagemagick_load_image): Check that crop parameters fit into
5056 the integer types that MagickCropImage accepts. Don't assume
5057 Vimagemagick_render_type has a nonnegative value. Don't assume
5058 size_t fits in 'long'.
5059 (gs_load): Use printmax_t to print the widest integers possible.
5060 Check for integer overflow when computing image height and width.
5061
c11821d4
EZ
50622011-08-26 Eli Zaretskii <eliz@gnu.org>
5063
5064 * xdisp.c (redisplay_window): Don't force window start if point
5065 will be invisible in the resulting window. (Bug#9324)
5066
0c95fcf7
EZ
50672011-08-25 Eli Zaretskii <eliz@gnu.org>
5068
5069 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
5070 the display spec is of the form `(space ...)'.
5071 (handle_display_spec): Return the value returned by
5072 handle_single_display_spec, not just 1 or zero.
5073 (handle_single_display_spec): If the display spec is of the form
5074 `(space ...)', and specifies display in the text area, return 2
5075 rather than 1.
fee65a97 5076 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
5077 accurately, and prefer exact match for point under bidi.
5078 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
5079
5080 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
5081 into disp_prop; all users changed.
5082
5083 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
5084 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
5085 for the text covered by the display property.
5086
e4ed06f1
CY
50872011-08-25 Chong Yidong <cyd@stupidchicken.com>
5088
5089 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
5090 Change return value to nil.
5091 (Frecord_buffer): Delete unused function.
5092
f67cdd7f
EZ
50932011-08-24 Eli Zaretskii <eliz@gnu.org>
5094
5980d4c6
EZ
5095 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
5096 buffers, return left-to-right.
8610fe8b
EZ
5097 (set_cursor_from_row): Consider candidate row a win if its glyph
5098 represents a newline and point is on that newline. Fixes cursor
5099 positioning on the newline at EOL of R2L text within L2R
5100 paragraph, and vice versa.
5101 (try_cursor_movement): Check continued rows, in addition to
5102 continuation rows. Fixes unwarranted scroll when point enters a
5103 continued line of R2L text within an L2R paragraph, or vice versa.
5104 (cursor_row_p): Consider the case of point being equal to
5105 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
5106 from the end of a short line to the beginning of a continued line
5107 of R2L text within L2R paragraph.
5108 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
5109 composed characters.
5980d4c6 5110
f67cdd7f
EZ
5111 * bidi.c (bidi_check_type): Use xassert.
5112 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
5113 members.
5114
bca633fb
EZ
51152011-08-23 Eli Zaretskii <eliz@gnu.org>
5116
5117 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
5118 a character.
5119
4a5885a7
CY
51202011-08-23 Chong Yidong <cyd@stupidchicken.com>
5121
5122 * nsfont.m (ns_otf_to_script): Fix typo.
5123
0902a04e
KH
51242011-08-22 Kenichi Handa <handa@m17n.org>
5125
5126 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
5127 extra slot even if the purpose is char-code-property-table.
5128
1a2e6670
EZ
51292011-08-23 Eli Zaretskii <eliz@gnu.org>
5130
8ddde651
EZ
5131 * xdisp.c (redisplay_window): When computing centering_position,
5132 account for the height of the header line. (Bug#8874)
5133
425cc014
EZ
5134 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
5135 instead of CHAR_TO_BYTE. Fixes a crash when a completion
5136 candidate is selected by the mouse, and that candidate has a
5137 composed character under the mouse.
5138
1a2e6670
EZ
5139 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
5140 coordinates reported by pos-visible-in-window-p for a composed
5141 character in column zero.
5142
8b76d6f8
SM
51432011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
5144
5145 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
5146
dac347dd
EZ
51472011-08-22 Eli Zaretskii <eliz@gnu.org>
5148
5149 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
5150 consider it a hit if to_charpos is anywhere in the range of the
5151 composed buffer positions.
5152
e013fb34
CY
51532011-08-22 Chong Yidong <cyd@stupidchicken.com>
5154
5155 * image.c (gif_load): Don't assume that each subimage has the same
5156 dimensions as the base image. Handle disposal method that is
5157 "undefined" by the gif spec (Bug#9335).
5158
bd1ba3e8
CY
51592011-08-20 Chong Yidong <cyd@stupidchicken.com>
5160
5161 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 5162 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 5163
54a1215b
EZ
51642011-08-19 Eli Zaretskii <eliz@gnu.org>
5165
823564e5
EZ
5166 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
5167 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
5168 from an Org mode buffer to a Speedbar frame.
5169
54a1215b
EZ
5170 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
5171 a composition, take its buffer position from IT->cmp_it.charpos.
5172 Fixes cursor positioning at the beginning of a line that begins
5173 with a composed character.
5174
9778ebcc
EZ
51752011-08-18 Eli Zaretskii <eliz@gnu.org>
5176
0be6ee06
EZ
5177 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
5178 character bidirectional type, use STRONG_L instead. Fixes crashes
5179 in a buffer produced by `describe-categories'.
5180
9778ebcc
EZ
5181 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
5182 members before the level stack, so they would be saved and
5183 restored when copying iterator state. Fixes incorrect reordering
5184 around TABs covered by display properties.
5185
156bffbe
AS
51862011-08-18 Andreas Schwab <schwab@linux-m68k.org>
5187
6b02f655 5188 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 5189
72ad093b
CY
51902011-08-17 Chong Yidong <cyd@stupidchicken.com>
5191
5192 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
5193 (internal_condition_case_2, internal_condition_case_n):
5194 Remove unnecessary aborts (Bug#9081).
72ad093b 5195
35774242
EZ
51962011-08-17 Eli Zaretskii <eliz@gnu.org>
5197
5198 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
5199 has no `load' handler, try opening the file locally. (Bug#9311)
5200
db76dd85
KB
52012011-08-16 Ken Brown <kbrown@cornell.edu>
5202
5203 * gmalloc.c: Expand comment.
5204
b215eee5
EZ
52052011-08-16 Eli Zaretskii <eliz@gnu.org>
5206
5207 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
5208 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
5209
a4579d33
KB
52102011-08-16 Ken Brown <kbrown@cornell.edu>
5211
5212 Fix memory allocation problems in Cygwin build (Bug#9273).
5213
5214 * unexcw.c ( __malloc_initialized): Declare external variable.
5215 (fixup_executable): Force the dumped emacs to reinitialize malloc.
5216
8b76d6f8
SM
5217 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
5218 New variables.
a4579d33
KB
5219 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
5220 dumped emacs.
5221 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
5222 in the static heap.
5223 [CYGWIN] (special_realloc): New function.
5224 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
5225 requests to realloc storage in the static heap.
5226
3ebec551
PE
52272011-08-15 Paul Eggert <eggert@cs.ucla.edu>
5228
5229 * bidi.c (bidi_initialize): Remove unused local.
5230
9fd8be00
EZ
52312011-08-15 Eli Zaretskii <eliz@gnu.org>
5232
6b02f655
SM
5233 * bidimirror.h:
5234 * biditype.h: Remove file.
5235 * makefile.w32-in ($(BLD)/bidi.$(O)):
5236 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
5237
5238 * dispextern.h: Fix a typo in the comment to bidi_type_t.
5239
5240 * chartab.c: Improve commentary for the uniprop_table API.
5241
32413314
EZ
5242 * bidi.c (bidi_paragraph_init): Support zero value of
5243 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
5244 (bidi_initialize): Use uniprop_table instead of including
5245 biditype.h and bidimirror.h.
32413314 5246
9fd8be00
EZ
5247 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
5248 coordinates of the iterator when restoring from ppos_it.
5249 (Bug#9296)
5250
5cf2b69b
KH
52512011-08-14 Kenichi Handa <handa@m17n.org>
5252
5253 * process.c (create_process): Call setup_process_coding_systems
72ad093b 5254 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 5255
daf17d00
EZ
52562011-08-14 Eli Zaretskii <eliz@gnu.org>
5257
5258 * xdisp.c (move_it_in_display_line_to): Don't invoke
5259 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
5260 ppos_it. Fixes vertical cursor motion when line beginning is
5261 covered by an image. (Bug#9296)
5262
08e3161a
JD
52632011-08-14 Jan Djärv <jan.h.d@swipnet.se>
5264
5265 * nsterm.h (ns_run_ascript): Declare.
5266 (NSAPP_DATA2_RUNASSCRIPT): Define.
5267
5268 * nsfns.m (as_script, as_result, as_status): New static variables.
5269 (ns_run_ascript): New function.
5e617bc2 5270 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
5271 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
5272 the event loop. Get status from as_status (Bug#7276).
5273
5274 * nsterm.m (sendEvent): If event is NSApplicationDefined and
5275 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
5276 the event loop (Bug#7276).
5277
a3720aa2
AS
52782011-08-14 Andreas Schwab <schwab@linux-m68k.org>
5279
5280 * gnutls.c (QCgnutls_bootprop_priority)
5281 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
5282 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
5283 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
5284 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
5285 (QCgnutls_bootprop_verify_hostname_error)
5286 (QCgnutls_bootprop_callbacks_verify): Rename from
5287 Qgnutls_bootprop_..., all uses changed.
5288
5289 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
5290 uses changed.
5291
0a0d27fb
PE
52922011-08-14 Paul Eggert <eggert@cs.ucla.edu>
5293
19d5c50c
PE
5294 * xfaces.c (Qframe_set_background_mode): Now static.
5295 * dispextern.h (Qframe_set_background_mode): Remove decl.
5296
0a0d27fb
PE
5297 * process.c (Fnetwork_interface_info): Declare local only if needed.
5298
377538cb
JD
52992011-08-13 Jan Djärv <jan.h.d@swipnet.se>
5300
5301 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
5302 (Fnetwork_interface_list): Allocate in increments of bytes instead
5303 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
5304 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
5305 sockaddr.
5306 (struct ifflag_def): notrailers is smart on OSX.
5307 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
5308 Get hardware address with getifaddrs if available.
5309
08fff70c
EZ
53102011-08-12 Eli Zaretskii <eliz@gnu.org>
5311
5312 * xdisp.c (iterate_out_of_display_property): xassert that
5313 IT->position is set to within IT->object's boundaries. Break from
5314 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
5315 when IT->position is set up wrongly due to some bug.
5316 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
5317 (push_display_prop): Allow GET_FROM_STRING as IT->method on
5318 entry. Force push_it to save on the stack the current
5319 buffer/string position, to be restored by pop_it. Fix flags in
5320 the iterator structure wrt the object coming from a display
5321 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
5322 properties. (Bug#9284)
5323
7be1c708 53242011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 5325
7be1c708
CY
5326 * fontset.c (fontset_get_font_group): Add proper type checks.
5327 (Bug#9172)
aac0c6e3 5328
7be1c708 53292011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 5330
7be1c708
CY
5331 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
5332 and LC_VERSION_MIN_MACOSX.
5333 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
5334 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 5335
97bb72a6
EZ
53362011-08-08 Eli Zaretskii <eliz@gnu.org>
5337
5338 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
5339 no-display-properties-and-no-overlays under bidi display.
5340 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 5341 properties and overlays.
97bb72a6 5342
d5617611
CY
53432011-08-08 Chong Yidong <cyd@stupidchicken.com>
5344
37e11a63
CY
5345 * editfns.c (Fset_time_zone_rule): Document relationship with the
5346 setenv function.
5347
d5617611
CY
5348 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
5349 the font entity extracted from the cache (Bug#8109).
5350
58872834
CY
53512011-08-07 Chong Yidong <cyd@stupidchicken.com>
5352
5353 * composite.c (autocmp_chars): Don't reset point. That is done by
5354 restore_point_unwind (Bug#5984).
5355
75bfc667
JL
53562011-08-07 Juri Linkov <juri@jurta.org>
5357
5358 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
5359 to show the arg `TIME' instead of `TIMEVAL'.
5360
d1410150
EZ
53612011-08-06 Eli Zaretskii <eliz@gnu.org>
5362
5363 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
5364 display property strides EOL and includes a newline, as in
5365 longlines-mode. (Bug#9254)
75b771e4
EZ
5366 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
5367 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
5368
5369 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
5370 is non-zero, even if the data buffer is NULL. Fixes a crash in
5371 vertical-motion with longlines-mode. (Bug#9254)
5372
35928349
EZ
53732011-08-05 Eli Zaretskii <eliz@gnu.org>
5374
ec7cc85b
EZ
5375 * bidi.c <bidi_cache_total_alloc>: Now static.
5376 (bidi_initialize): Initialize bidi_cache_total_alloc.
5377
8b76d6f8 5378 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
5379 cache. (Bug#9221)
5380
5381 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
5382 amount allocated this far in `bidi_cache_total_alloc'.
5383 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
5384 non-zero, only free the data buffer without restoring the cache
5385 contents. All callers changed.
5386
5387 * dispextern.h (bidi_unshelve_cache): Update prototype.
5388
5389 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
5390 (move_it_in_display_line, move_it_to)
5391 (move_it_vertically_backward, move_it_by_lines): Replace the call
5392 to xfree to an equivalent call to bidi_unshelve_cache.
5393 (move_it_in_display_line_to): Fix logic of returning
412b6358 5394 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 5395
e2e2423b
EZ
53962011-08-05 Eli Zaretskii <eliz@gnu.org>
5397
5398 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
5399 came from a string character with a `cursor' property. (Bug#9229)
5400
ae9e757a
JD
54012011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5402
5403 * Makefile.in (LIB_PTHREAD): New variable.
5404 (LIBES): Add LIB_PTHREAD (Bug#9216).
5405
5406 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
5407 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
5408
213bd7f2
AS
54092011-08-04 Andreas Schwab <schwab@linux-m68k.org>
5410
6b02f655 5411 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 5412
99aaf75f
JD
54132011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5414
5415 * xterm.c (x_find_topmost_parent): New function.
5416 (x_set_frame_alpha): Find topmost parent window with
5417 x_find_topmost_parent and set the property there also (bug#9181).
5418 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
5419
c74e9d86
PE
54202011-08-04 Paul Eggert <eggert@cs.ucla.edu>
5421
5422 * callproc.c (Fcall_process): Avoid vfork clobbering
5423 the local vars buffer, coding_systems, current_dir.
5424
640c8776
SM
54252011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
5426
5427 * keymap.c (Fmake_composed_keymap): Move to subr.el.
5428
f26d0e4c
PE
54292011-08-03 Paul Eggert <eggert@cs.ucla.edu>
5430
8a10d76c
PE
5431 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
5432 so that it is not optimized away.
5433
f26d0e4c
PE
5434 * xdisp.c (compute_display_string_pos): Remove unused local.
5435
55439c61
EZ
54362011-08-02 Eli Zaretskii <eliz@gnu.org>
5437
5438 Fix slow cursor motion and scrolling in large buffers with
5439 selective display, like Org Mode buffers. (Bug#9218)
5440
5441 * dispextern.h (struct bidi_it): New member disp_prop_p.
5442
5443 * xdisp.c: Remove one-slot cache of display string positions.
5444 (compute_display_string_pos): Accept an additional argument
5e617bc2 5445 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
5446 for a display string or property. If found, set DISP_PROP_P
5447 non-zero.
5448
5449 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
5450 DISP_PROP_P, and pass it to compute_display_string_pos.
5451 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
5452 non-zero. All callers of bidi_fetch_char changed.
5453
fb33fa43
SM
54542011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
5455
5456 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
5457
b099e063
DM
54582010-12-03 Don March <don@ohspite.net>
5459
5460 * keymap.c (Fdefine_key): Fix non-prefix key error message when
5461 last character M-[char] is translated to ESC [char] (bug#7541).
5462
5cc7f7af
KH
54632011-08-02 Kenichi Handa <handa@m17n.org>
5464
d0fffa3f 5465 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
5466
5467 * chartab.c (uniprop_table): Make it non-static.
5468
525d5e6e
EZ
54692011-08-01 Eli Zaretskii <eliz@gnu.org>
5470
5471 * xdisp.c (forward_to_next_line_start): Accept additional argument
5472 BIDI_IT_PREV, and store into it the state of the bidi iterator had
5473 on the newline.
5474 (reseat_at_next_visible_line_start): Use the bidi iterator state
5475 returned by forward_to_next_line_start to restore the state of
5476 it->bidi_it after backing up to previous newline. (Bug#9212)
5477
31011111
AS
54782011-07-30 Andreas Schwab <schwab@linux-m68k.org>
5479
5480 * regex.c (re_comp): Protoize.
5481 (re_exec): Fix return type.
5482 (regexec): Fix type of `ret'. (Bug#9203)
5483
476371c4
PE
54842011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5485
e5d76069
PE
5486 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
5487 This is needed if max-image-size is a floating-point number.
5488
9a79b20c
AS
54892011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5490
5491 * print.c (print_object): Print empty symbol as ##.
5492
5493 * lread.c (read1): Read ## as empty symbol.
5494
d8c2fa78
AA
54952011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5496
5497 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
5498 setting frame foreground color (Bug#9175).
5499 (x_set_background_color): Likewise.
5500
ffe57a7a
AA
5501 * nsmenu.m (-setText): Size tooltip dimensions precisely to
5502 contents (Bug#9176).
5503 (EmacsTooltip -init): Remove bezels and add shadows to
5504 tooltip windows.
5505
bf3492a5
AA
5506 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
5507 or scroll bar (Bug#8470).
5508
d55e9c53
AA
5509 * nsfont.m (nsfont_open): Remove assignment to voffset and
5510 unnecessary vars hshink, expand, hd, full_height, min_height.
5511 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
5512
5513 * nsterm.h (nsfont_info): Remove voffset field.
5514
d8c2fa78 55152011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
5516
5517 Implement strike-through and overline on NextStep (Bug#8863).
5518
5519 * nsfont.m (nsfont_open): Use underline position provided by font,
5520 instead of hard-coded value of 2.
5521 (nsfont_draw): Call ns_draw_text_decoration instead.
5522
5523 * nsterm.h: Add declaration for ns_draw_text_decoration.
5524
5525 * nsterm.m (ns_draw_text_decoration): New function for drawing
5526 underline, overline, and strike-through.
5527 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
5528 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 5529 accommodate underlining, etc.
4843aac3 5530
4cc60b9b
EZ
55312011-07-28 Eli Zaretskii <eliz@gnu.org>
5532
bc7ece87
EZ
5533 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
5534 default.
4cc60b9b 5535
476371c4
PE
55362011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5537
66606eea
PE
5538 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
5539 Without this fix, if a signal arrives just after memory fills up,
5540 'malloc' might be invoked reentrantly.
5541
476371c4
PE
5542 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
5543 In other words, assume that every image size is allowed, on non-X
5544 hosts. This assumption is probably wrong, but it lets Emacs compile.
5545
f3fcc40d
AS
55462011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5547
5548 * regex.c (re_iswctype): Convert return values to boolean.
5549
350c992f
EZ
55502011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
5551
5552 * xdisp.c (compute_display_string_pos): Don't use cached display
5553 string position if the buffer had its restriction changed.
5554 (Bug#9184)
5555
5266b4bb
PE
55562011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5557
5558 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5559
2573a837 55602011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 5561
41f55ccd 5562 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 5563
39e378da
PE
5564 * bidi.c: Integer size and overflow fixes.
5565 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
5566 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
5567 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5568 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
5569 (bidi_find_other_level_edge):
5570 Use ptrdiff_t instead of EMACS_INT where either will do.
5571 This works better on 32-bit hosts configured --with-wide-int.
5572 (bidi_cache_ensure_space): Check for size-calculation overflow.
5573 Use % rather than repeated addition, for better worst-case speed.
5574 Don't set bidi_cache_size until after xrealloc returns, because it
5575 might not return.
5576 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
5577 (bidi_cache_ensure_space): Also check that the bidi cache size
5578 does not exceed that of the largest Lisp string or buffer. See Eli
5579 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 5580
5e927815
PE
5581 * alloc.c (__malloc_size_t): Remove.
5582 All uses replaced by size_t. See Andreas Schwab's note
5583 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
5584
ca4aa935
PE
5585 * image.c: Improve checking for integer overflow.
5586 (check_image_size): Assume that f is nonnull, since
5587 it is always nonnull in practice. This is one less thing to
5588 worry about when checking for integer overflow later.
5589 (x_check_image_size): New function, which checks for integer
5590 overflow issues inside X.
5591 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
5592 This removes the need for a memory_full check.
5593 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
5594 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
5595 (xbm_read_bitmap_data): Change locals back to 'int', since
5596 their values must fit in 'int'.
5597 (xpm_load_image, png_load, tiff_load):
5598 Invoke x_create_x_image_and_pixmap earlier,
5599 to avoid much needless work if the image is too large.
5600 (tiff_load): Treat overly large images as if
5601 x_create_x_image_and_pixmap failed, not as malloc failures.
5602 (gs_load): Use x_check_image_size.
5603
5f8f9cc2
PE
5604 * gtkutil.c: Omit integer casts.
5605 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
5606 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
5607
5adf60bc
PE
5608 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
5609
c8907a93
PE
5610 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
5611 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
5612 would wrongly return t on a 64-bit host.
5613
e3c25c68
PE
5614 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
5615 The plain *_OVERFLOW macros run afoul of GCC bug 49705
5616 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
5617 and therefore cause GCC to emit a bogus diagnostic in some cases.
5618
3f791afe
PE
5619 * image.c: Integer signedness and overflow and related fixes.
5620 This is not an exhaustive set of fixes, but it's time to
5621 record what I've got.
5622 (lookup_pixel_color, check_image_size): Remove redundant decls.
5623 (check_image_size): Don't assume that arbitrary EMACS_INT values
5624 fit in 'int', or that arbitrary 'double' values fit in 'int'.
5625 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
5626 (tiff_load, imagemagick_load_image):
5627 Check for overflow in size calculations.
5628 (x_create_x_image_and_pixmap): Remove unnecessary test for
5629 xmalloc returning NULL; that can't happen.
5630 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
5631 (xpm_color_bucket): Use better integer hashing function.
5632 (xpm_cache_color): Don't possibly over-allocate memory.
5633 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
5634 (gif_memory_source):
5635 Use ptrdiff_t, not int or size_t, to record sizes.
5636 (png_load): Don't assume values greater than 2**31 fit in 'int'.
5637 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
5638 either works, as we prefer signed integers.
5639 (tiff_read_from_memory, tiff_write_from_memory):
5640 Return tsize_t, not size_t, since that's what the TIFF API wants.
5641 (tiff_read_from_memory): Don't fail simply because the read would
5642 go past EOF; instead, return a short read.
5643 (tiff_load): Omit no-longer-needed casts.
5644 (Fimagemagick_types): Don't assume size fits into 'int'.
5645
3cc5a532
PE
5646 Improve hashing quality when configured --with-wide-int.
5647 * fns.c (hash_string): New function, taken from sxhash_string.
5648 Do not discard information about ASCII character case; this
5649 discarding is no longer needed.
5650 (sxhash-string): Use it. Change sig to match it. Caller changed.
5651 * lisp.h: Declare it.
5652 * lread.c (hash_string): Remove, since we now use fns.c's version.
5653 The fns.c version returns a wider integer if --with-wide-int is
5654 specified, so this should help the quality of the hashing a bit.
5655
b312a492
PE
5656 * emacs.c: Integer overflow minor fix.
5657 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
5658 Define only if GNU_LINUX.
5659 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
5660
dfd153ae
PE
5661 * dispnew.c: Integer signedness and overflow fixes.
5662 Remove unnecessary forward decls, that were a maintenance hassle.
5663 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
5664 All uses changed.
5665 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
5666 (scrolling_window): Use ptrdiff_t, not int, for byte count.
5667 (prepare_desired_row, line_draw_cost):
5668 Use int, not unsigned, where either works.
5669 (save_current_matrix, restore_current_matrix):
5670 Use ptrdiff_t, not size_t, where either works.
5671 (init_display): Check for overflow more accurately, and without
5672 relying on undefined behavior.
5673
a81d11a3
PE
5674 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
5675 Remove, replacing with the new symbols in lisp.h. All uses changed.
5676 * fileio.c (make_temp_name):
5677 * filelock.c (lock_file_1, lock_file):
5678 * xdisp.c (message_dolog):
5679 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
5680 Use pMd etc. instead.
5681 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
5682 replacing the pWIDE etc. symbols removed from editfns.c.
5683
3300e6fd
PE
5684 * keyboard.h (num_input_events): Now uintmax_t.
5685 This is (very slightly) less likely to mess up due to wraparound.
5686 All uses changed.
5687
fd05c7e9
PE
5688 * buffer.c: Integer signedness fixes.
5689 (alloc_buffer_text, enlarge_buffer_text):
5690 Use ptrdiff_t rather than size_t when either will do, as we prefer
5691 signed integers.
5692
903fe15d
PE
5693 * alloc.c: Integer signedness and overflow fixes.
5694 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
5695 (__malloc_size_t): Default to size_t, not to int.
5696 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
5697 (Fgarbage_collect, mark_object_loop_halt, mark_object):
5698 Prefer ptrdiff_t to size_t when either would do, as we prefer
5699 signed integers.
5700 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
5701 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
5702 Now const. Initialize with values that are in range even if char
5703 is signed.
5704 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
5705 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
5706 These functions do the right thing with sizes > 2**32.
5707 (check_depth): Now ptrdiff_t, not int.
5708 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
5709 Adjust to new way of storing sizes. Check for size overflow bugs
5710 in rest of code.
5711 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
5712 slightly wrong anyway, as it missed one instance of
5713 XMALLOC_OVERRUN_CHECK_OVERHEAD.
5714 (refill_memory_reserve): Omit needless cast to size_t.
5715 (mark_object_loop_halt): Mark as externally visible.
5716
ac82cc6a
PE
5717 * xselect.c: Integer signedness and overflow fixes.
5718 (Fx_register_dnd_atom, x_handle_dnd_message):
5719 Use ptrdiff_t, not size_t, since we prefer signed.
5720 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
5721 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
5722 x_dnd_atoms_size and x_dnd_atoms_length.
5723
c2d1e36d
PE
5724 * doprnt.c: Prefer signed to unsigned when either works.
5725 * eval.c (verror):
5726 * doprnt.c (doprnt):
5727 * lisp.h (doprnt):
5728 * xdisp.c (vmessage):
5729 Use ptrdiff_t, not size_t, when using or implementing doprnt,
5730 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
5731 prefer signed arithmetic to avoid comparison confusion.
5732 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
5733 but is a bit tricky.
5734
0e926e56
PE
5735 Assume freestanding C89 headers, string.h, stdlib.h.
5736 * data.c, doprnt.c, floatfns.c, print.c:
5737 Include float.h unconditionally.
5738 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
5739 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
5740 * regex.c: Likewise for stddef.h, string.h.
5741 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
5742 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
5743 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
5744 (STDC_HEADERS): Remove obsolete defines.
5745 * sysdep.c: Include limits.h unconditionally.
5746
9cfdb3ec
PE
5747 Assume support for memcmp, memcpy, memmove, memset.
5748 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
5749 * regex.c (memcmp, memcpy):
5750 Remove; we assume C89 now.
5751
5752 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
5753 (__malloc_safe_bcopy): Remove; no longer needed.
5754
cf950e6b 5755 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
5756 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
5757 well either way, and we prefer signed to unsigned.
5758
dbf38e02
LMI
57592011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
5760
5761 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
5762 closes the connection while we're reading (bug#9182).
5763
d6f0886c 57642011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 5765
d6f0886c
JD
5766 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
5767 are specified (Bug#9168).
24e0f6b1 5768
2eb1f9e6
PE
57692011-07-25 Paul Eggert <eggert@cs.ucla.edu>
5770
5771 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
5772 Found by GCC static checking and --with-wide-int on a 32-bit host.
5773
22381272 57742011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
5775
5776 * xdisp.c (compute_display_string_pos): Fix logic of caching
5777 previous display string position. Initialize cached_prev_pos to
5778 -1. Fixes slow-down at the beginning of a buffer.
5779
f25e39b4
EZ
57802011-07-24 Eli Zaretskii <eliz@gnu.org>
5781
5782 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
5783 for attrs[LFACE_FONTSET_INDEX].
5784
04c4b52e
PE
57852011-07-23 Paul Eggert <eggert@cs.ucla.edu>
5786
5787 * xml.c (parse_region): Remove unused local
5788 that was recently introduced.
5789
c1734fbd
EZ
57902011-07-23 Eli Zaretskii <eliz@gnu.org>
5791
be18c5a5
EZ
5792 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
5793 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
5794
c1734fbd
EZ
5795 * xdisp.c (move_it_in_display_line_to): Record the best matching
5796 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
5797 exit if none of the characters scanned was an exact match.
5798 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
5799 when exact match is impossible due to invisible text, and the
5800 lines are truncated.
5801
a258d627
JD
58022011-07-23 Jan Djärv <jan.h.d@swipnet.se>
5803
5804 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
5805 for OSX >= 10.7.
5806
b6d5a689
EZ
58072011-07-22 Eli Zaretskii <eliz@gnu.org>
5808
0f74f785
EZ
5809 Fix a significant slow-down of cursor motion with C-n, C-p,
5810 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
5811 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 5812 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
5813 (next_element_from_buffer): Call compute_stop_pos_backwards to
5814 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
5815 base_level_stop.
5816 (reseat): Don't look for prev_stop, as that could mean a very long
5817 run.
5818 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
5819 <cached_disp_overlay_modiff>: Cache for last found display string
5820 position.
551918c1 5821 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
5822 about the same buffer in the same area of character positions, and
5823 the buffer wasn't changed since the time the display string
5824 position was cached.
551918c1 5825
b2d0c91a
EZ
58262011-07-22 Eli Zaretskii <eliz@gnu.org>
5827
5828 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
5829 is an integer, which is important for empty lines. (Bug#9149)
5830
043604ee
CY
58312011-07-22 Chong Yidong <cyd@stupidchicken.com>
5832
5833 * frame.c (Fmodify_frame_parameters): In tty case, update the
5834 default face if necessary (Bug#4238).
5835
da4adb04
CY
58362011-07-21 Chong Yidong <cyd@stupidchicken.com>
5837
5838 * editfns.c (Fstring_to_char): No need to explain what a character
5839 is in the docstring (Bug#6576).
5840
9abd0532
LMI
58412011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5842
5843 * xml.c (parse_region): Make sure we always return a tree.
5844
36881d16
HK
58452011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
5846
5847 * xml.c (parse_region): If a document contains only comments,
5848 return that, too.
5849
1e98674d
LMI
58502011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5851
5852 * xml.c (make_dom): Return comments, too.
5853
590bd467
PE
58542011-07-19 Paul Eggert <eggert@cs.ucla.edu>
5855
5856 Port to OpenBSD.
5857 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
5858 and the surrounding thread.
5859 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
5860 rather than fgets, and retry after EINTR. Otherwise, 'emacs
5861 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
5862 timer goes off.
5863 * s/openbsd.h (BROKEN_SIGIO): Define.
5864 * unexelf.c (unexec) [__OpenBSD__]:
5865 Don't update the .mdebug section of the Alpha COFF symbol table.
5866
f41628b2
LMI
58672011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5868
5869 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
5870 (bug#8460).
5871
b59b67c5
PE
58722011-07-18 Paul Eggert <eggert@cs.ucla.edu>
5873
15e3a074
PE
5874 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
5875 This fixes some race conditions on the permissions of any newly
5876 created file.
5877
41bed37d
PE
5878 * alloc.c (valid_pointer_p): Use pipe, not open.
5879 This fixes some permissions issues when debugging.
5880
b59b67c5
PE
5881 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
5882 If fchown fails to set both uid and gid, try to set just gid,
5883 as that is sometimes allowed. Adjust the file's mode to eliminate
5884 setuid or setgid bits that are inappropriate if fchown fails.
5885
925a6be7
SM
58862011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
5887
5888 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
5889 to compare Lisp_Objects.
5890 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
5891 global_gnutls_log_level, don't mistake it for a Lisp_Object.
5892 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
5893
52968808
AS
58942011-07-17 Andreas Schwab <schwab@linux-m68k.org>
5895
0a6a104b
AS
5896 * lread.c (read_integer): Unread even EOF character.
5897 (read1): Likewise. Properly record start position of symbol.
5898
52968808
AS
5899 * lread.c (read1): Read `#:' as empty uninterned symbol if no
5900 symbol character follows.
5901
9e381cdd
PE
59022011-07-17 Paul Eggert <eggert@cs.ucla.edu>
5903
5904 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
5905 This works around a problem with the previous change to Fcopy_file.
5906 Recent glibc declares fchown with __attribute__((warn_unused_result)),
5907 and without this change, GCC might complain about discarding
5908 fchown's return value.
5909
b5641435
JB
59102011-07-16 Juanma Barranquero <lekktu@gmail.com>
5911
5912 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
5913
a8031457
PE
59142011-07-16 Paul Eggert <eggert@cs.ucla.edu>
5915
5916 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
5917
dd889327
LMI
59182011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
5919
750c33f7
LMI
5920 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
5921 it's used from the C level.
5922
dd889327
LMI
5923 * process.c: Use the same condition for POLL_FOR_INPUT in both
5924 keyboard.c and process.c (bug#1858).
5925
87e86684
LM
59262011-07-09 Lawrence Mitchell <wence@gmx.li>
5927
5928 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
5929 (Fgnutls_boot): Use it.
5930
64348f40
AS
59312011-07-15 Andreas Schwab <schwab@linux-m68k.org>
5932
5933 * doc.c (Fsubstitute_command_keys): Revert last change.
5934
1d698799
LMI
59352011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
5936
f863868c
LMI
5937 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
5938 quotes the next character, and doesn't affect other longer
5939 sequences (bug#8935).
5940
1d698799
LMI
5941 * lread.c (syms_of_lread): Clarify that is isn't only
5942 `eval-buffer' and `eval-defun' that's affected by
5943 `lexical-binding' (bug#8460).
5944
aa4b6df6
EZ
59452011-07-15 Eli Zaretskii <eliz@gnu.org>
5946
5947 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 5948 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 5949
5d856da6
PE
59502011-07-14 Paul Eggert <eggert@cs.ucla.edu>
5951
ad6042bb
PE
5952 Fix minor problems found by static checking.
5953 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
5954 (elsz): Now a signed constant, not a size_t var. We prefer signed
5955 types to unsigned, to avoid integer comparison confusion. Without
5956 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
5957 "cannot optimize loop, the loop counter may overflow", a symptom
5958 of the confusion.
f00bbb22 5959 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
5960 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
5961
6468f31c
LMI
59622011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
5963
49080b10
LMI
5964 * search.c (Fre_search_backward): Mention `case-fold-search' in
5965 all the re_search_* functions (bug#8138).
5966
6468f31c
LMI
5967 * keyboard.c (Fopen_dribble_file): Document when the file is
5968 closed (bug#8056).
5969
c965adc5
EZ
59702011-07-14 Eli Zaretskii <eliz@gnu.org>
5971
df9733bf
EZ
5972 * bidi.c (bidi_dump_cached_states): Fix format of displaying
5973 bidi_cache_idx.
5974
0bb23927
EZ
5975 Support bidi reordering of display and overlay strings.
5976 * xdisp.c (compute_display_string_pos)
5977 (compute_display_string_end): Accept additional argument STRING.
5978 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
5979 (reseat_to_string): Initialize bidi_it->string.s and
5980 bidi_it->string.schars.
5981 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
5982 NULL (avoids a crash in bidi_paragraph_init).
5983 Initialize itb.string.lstring.
0bb23927
EZ
5984 (init_iterator): Call bidi_init_it only of a valid
5985 buffer position was specified. Initialize paragraph_embedding to
5986 L2R.
5987 (reseat_to_string): Initialize the bidi iterator.
5988 (display_string): If we need to ignore text properties of
5989 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
5990 original value of -1 will not work with bidi.)
5991 (compute_display_string_pos): First arg is now struct
5992 `text_pos *'; all callers changed. Support display properties on
5993 Lisp strings.
5994 (compute_display_string_end): Support display properties on Lisp
5995 strings.
5996 (init_iterator, reseat_1, reseat_to_string): Initialize the
5997 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
5998 when iterating on a string not from display properties).
640c8776
SM
5999 (compute_display_string_pos, compute_display_string_end):
6000 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
6001 arrow keys.
6002 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
6003 base_level_stop; instead, set base_level_stop to BEGV.
6004 Fixes crashes in vertical-motion.
0bb23927
EZ
6005 (next_element_from_buffer): Improve commentary for when
6006 the iterator is before prev_stop.
6007 (init_iterator): Initialize bidi_p from the default value of
6008 bidi-display-reordering, not from buffer-local value. Use the
6009 buffer-local value only if initializing for buffer iteration.
6010 (handle_invisible_prop): Support invisible properties on strings
6011 that are being bidi-reordered.
6012 (set_iterator_to_next): Support bidi reordering of C strings and
6013 Lisp strings.
6014 (next_element_from_string): Support bidi reordering of Lisp
6015 strings.
6016 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
6017 (display_string): Support display of R2L glyph rows.
6018 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
6019 (init_iterator): Don't initialize it->bidi_p for strings
6020 here.
6021 (reseat_to_string): Initialize it->bidi_p for strings here.
6022 (next_element_from_string, next_element_from_c_string)
6023 (next_element_from_buffer): Add xassert's for correspondence
6024 between IT's object being iterated and it->bidi_it.string
6025 structure.
6026 (face_before_or_after_it_pos): Support bidi iteration.
6027 (next_element_from_c_string): Handle the case of the first string
6028 character that is not the first one in the visual order.
6029 (get_visually_first_element): New function, refactored from common
6030 parts of next_element_from_buffer, next_element_from_string, and
6031 next_element_from_c_string.
6032 (tool_bar_lines_needed, redisplay_tool_bar)
6033 (display_menu_bar): Force left-to-right direction. Add a FIXME
6034 comment for making that be controlled by a user option.
6035 (push_it, pop_it): Save and restore the state of the
6036 bidi iterator. Save and restore the bidi_p flag.
6037 (pop_it): Iterate out of display property for string iteration as
6038 well.
6039 (iterate_out_of_display_property): Support iteration over strings.
6040 (handle_single_display_spec): Set up it->bidi_it for iteration
6041 over a display string, and call bidi_init_it.
6042 (handle_single_display_spec, next_overlay_string)
6043 (get_overlay_strings_1, push_display_prop): Set up the bidi
6044 iterator for displaying display or overlay strings.
6045 (forward_to_next_line_start): Don't use the shortcut if
6046 bidi-iterating.
6047 (back_to_previous_visible_line_start): If handle_display_prop
6048 pushed the iterator stack, restore the internal state of the bidi
6049 iterator by calling bidi_pop_it same number of times.
6050 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
6051 and we are bidi-iterating, don't decrement the iterator position;
6052 instead, set the first_elt flag in the bidi iterator, to produce
6053 the same effect.
6054 (reseat_1): Remove redundant setting of string_from_display_prop_p.
6055 (push_display_prop): xassert that we are iterating a buffer.
6056 (push_it, pop_it): Save and restore paragraph_embedding member.
6057 (handle_single_display_spec, next_overlay_string)
6058 (get_overlay_strings_1, reseat_1, reseat_to_string)
6059 (push_display_prop): Set up the `unibyte' member of bidi_it.string
6060 correctly. Don't assume unibyte strings are not bidi-reordered.
6061 (compute_display_string_pos)
6062 (compute_display_string_end): Fix handling the case of C string.
6063 (push_it, pop_it): Save and restore from_disp_prop_p.
6064 (handle_single_display_spec, push_display_prop): Set the
6065 from_disp_prop_p flag.
6066 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
6067 (pop_it): Call iterate_out_of_display_property only if we are
6068 popping after iteration over a string that came from a display
6069 property. Fix a typo in popping stretch info. Add an assertion
6070 for verifying that the iterator position is in sync with the bidi
6071 iterator.
6072 (handle_single_display_spec, get_overlay_strings_1)
6073 (push_display_prop): Fix initialization of paragraph direction for
6074 string when that of the parent object is not yet determined.
6075 (reseat_1): Call bidi_init_it to resync the bidi
6076 iterator with IT's position. (Bug#7616)
6077 (find_row_edges): If ROW->start.pos gives position
6078 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
6079 (handle_stop, back_to_previous_visible_line_start, reseat_1):
6080 Reset the from_disp_prop_p flag.
6081 (SAVE_IT, RESTORE_IT): New macros.
6082 (pos_visible_p, face_before_or_after_it_pos)
6083 (back_to_previous_visible_line_start)
6084 (move_it_in_display_line_to, move_it_in_display_line)
6085 (move_it_to, move_it_vertically_backward, move_it_by_lines)
6086 (try_scrolling, redisplay_window, display_line): Use them when
6087 saving a temporary copy of the iterator and restoring it back.
6088 (back_to_previous_visible_line_start, reseat_1)
6089 (init_iterator): Empty the bidi cache "stack".
6090 (move_it_in_display_line_to): If iterator ended up at
6091 EOL, but we never saw any buffer positions smaller than
6092 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
6093 motion in bidi-reordered lines.
6094 (move_it_in_display_line_to): Record prev_method and prev_pos
6095 immediately before the call to set_iterator_to_next. Fixes cursor
6096 motion in bidi-reordered lines with stretch glyphs and strings
6097 displayed in margins. (Bug#8133) (Bug#8867)
6098 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
6099 TO_CHARPOS.
640c8776
SM
6100 (pos_visible_p): Support positions in bidi-reordered lines.
6101 Save and restore bidi cache.
0bb23927
EZ
6102
6103 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
6104 (bidi_paragraph_info): Delete unused struct.
6105 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
6106 (bidi_cache_start): New variable.
6107 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
6108 to zero.
6109 (bidi_cache_fetch_state, bidi_cache_search)
6110 (bidi_cache_find_level_change, bidi_cache_iterator_state)
6111 (bidi_cache_find, bidi_peek_at_next_level)
6112 (bidi_level_of_next_char, bidi_find_other_level_edge)
6113 (bidi_move_to_visually_next): Compare cache index with
6114 bidi_cache_start rather than with zero.
6115 (bidi_fetch_char): Accept new argument STRING; all callers
6116 changed. Support iteration over a string. Support strings with
6117 display properties. Support unibyte strings. Fix the type of
6118 `len' according to what STRING_CHAR_AND_LENGTH expects.
6119 (bidi_paragraph_init, bidi_resolve_explicit_1)
6120 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
6121 (bidi_level_of_next_char, bidi_move_to_visually_next):
6122 Support iteration over a string.
0bb23927
EZ
6123 (bidi_set_sor_type, bidi_resolve_explicit_1)
6124 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
6125 can now be zero (for strings); special values 0 and -1 were
6126 changed to -1 and -2, respectively.
6127 (bidi_char_at_pos): New function.
6128 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
6129 Call it instead of FETCH_MULTIBYTE_CHAR.
6130 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
6131 initialized to valid values.
6132 (bidi_init_it): Don't initialize charpos and bytepos with invalid
6133 values.
6134 (bidi_level_of_next_char): Allow the sentinel "position" to pass
6135 the test for valid cached positions. Fix the logic for looking up
6136 the sentinel state in the cache. GCPRO the Lisp string we are
6137 iterating.
6138 (bidi_push_it, bidi_pop_it): New functions.
6139 (bidi_initialize): Initialize the bidi cache start stack pointer.
6140 (bidi_cache_ensure_space): New function, refactored from part of
6141 bidi_cache_iterator_state. Don't assume the required size is just
6142 one BIDI_CACHE_CHUNK away.
6143 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
6144 (bidi_count_bytes, bidi_char_at_pos): New functions.
6145 (bidi_cache_search): Don't assume bidi_cache_last_idx is
6146 always valid if bidi_cache_idx is valid.
6147 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
6148 is valid if it's going to be used.
6149 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
6150 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
6151 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6152 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
6153 (bidi_find_other_level_edge, bidi_cache_start_stack):
6154 All variables related to cache indices are now EMACS_INT.
c965adc5 6155
0bb23927
EZ
6156 * dispextern.h (struct bidi_string_data): New structure.
6157 (struct bidi_it): New member `string'. Make flag members be 1-bit
6158 fields, and put them last in the struct.
640c8776
SM
6159 (compute_display_string_pos, compute_display_string_end):
6160 Update prototypes.
0bb23927
EZ
6161 (bidi_push_it, bidi_pop_it): Add prototypes.
6162 (struct iterator_stack_entry): New members bidi_p,
6163 paragraph_embedding, and from_disp_prop_p.
6164 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
6165 (bidi_shelve_cache, bidi_unshelve_cache):
6166 Declare prototypes.
0bb23927
EZ
6167
6168 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
6169 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
6170 and vector-like objects.
6171
6172 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
6173 cache around display iteration.
6174
6175 * window.c (Fwindow_end, window_scroll_pixel_based)
6176 (displayed_window_lines, Frecenter): Save and restore the bidi
6177 cache around display iteration.
6178
3bbd2265
LMI
61792011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6180
6181 * editfns.c (Fdelete_region): Clarify the use of the named
6182 parameters (bug#6788).
6183
adc47434
MR
61842011-07-14 Martin Rudalics <rudalics@gmx.at>
6185
6186 * indent.c (Fvertical_motion): Set and restore w->pointm when
6187 saving and restoring the window's buffer (Bug#9006).
6188
837c31f8
LMI
61892011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
6190
6191 * editfns.c (Fstring_to_char): Clarify just what is returned
6192 (bug#6576). Text by Eli Zaretskii.
6193
ac389d0c
JB
61942011-07-13 Juanma Barranquero <lekktu@gmail.com>
6195
6196 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
6197
0be0ce47
EZ
61982011-07-13 Eli Zaretskii <eliz@gnu.org>
6199
6200 * buffer.c (mmap_find): Fix a typo.
6201
cd18e7e3
JB
62022011-07-13 Johan Bockgård <bojohan@gnu.org>
6203
6204 Fix execution of x selection hooks.
6205 * xselect.c (Qx_lost_selection_functions)
6206 (Qx_sent_selection_functions): New vars.
6207 (syms_of_xselect): DEFSYM them.
6208 (x_handle_selection_request): Pass Qx_sent_selection_functions
6209 rather than Vx_sent_selection_functions to Frun_hook_with_args.
6210 (x_handle_selection_clear,x_clear_frame_selections):
6211 Pass Qx_lost_selection_functions rather than
6212 Vx_lost_selection_functions to Frun_hook_with_args.
6213
47ea7f44
PE
62142011-07-13 Paul Eggert <eggert@cs.ucla.edu>
6215
ac389d0c 6216 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
6217 The old code sometimes used this field without initializing it.
6218
47ea7f44
PE
6219 * alloc.c (gc_sweep): Don't read past end of array.
6220 In theory, the old code could also have corrupted Emacs internals,
6221 though it'd be very unlikely.
6222
bc985c87
AS
62232011-07-12 Andreas Schwab <schwab@linux-m68k.org>
6224
6225 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 6226 argument. (Bug#4026)
bc985c87 6227
0cf34688
LMI
62282011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
6229
b3dadd76
LMI
6230 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
6231 key" (bug#4257).
6232
0cf34688
LMI
6233 * window.c (Fset_window_start): Doc fix (bug#4199).
6234 (Fset_window_hscroll): Ditto.
6235
270768cd
PE
62362011-07-12 Paul Eggert <eggert@cs.ucla.edu>
6237
077e3dda 6238 Fix minor new problems caught by GCC 4.6.1.
270768cd 6239 * term.c (init_tty): Remove unused local.
490011a6 6240 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 6241 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 6242 not used otherwise.
270768cd 6243
b1f58454
CY
62442011-07-12 Chong Yidong <cyd@stupidchicken.com>
6245
6246 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
6247
22b9578d
LMI
62482011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6249
6e70ab07
LMI
6250 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
6251 are the mini-buffer and the echo area (bug#3320).
6252
22b9578d
LMI
6253 * term.c (init_tty): Remove support for supdup, c10 and perq
6254 terminals, which are no longer supported (bug#1482).
6255
8974cc9f
JB
62562011-07-10 Johan Bockgård <bojohan@gnu.org>
6257
6258 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
6259
a560d974
JD
62602011-07-10 Jan Djärv <jan.h.d@swipnet.se>
6261
6262 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
6263 for non-popups (Bug#3642).
6264
1dae0f0a
AS
62652011-07-10 Andreas Schwab <schwab@linux-m68k.org>
6266
268c2c36 6267 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 6268 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
6269 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
6270 * cm.c (losecursor): Likewise.
1dae0f0a
AS
6271 * data.c (fmod): Likewise.
6272 * dispnew.c (swap_glyphs_in_rows): Likewise.
6273 * emacs.c (memory_warning_signal): Likewise.
6274 * floatfns.c (float_error): Likewise.
6275 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
6276 (otf_open, font_otf_capability, generate_otf_features)
6277 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
6278 Likewise.
6279 * image.c (pbm_read_file): Likewise.
6280 * indent.c (string_display_width): Likewise.
6281 * intervals.c (check_for_interval, search_for_interval)
6282 (inc_interval_count, count_intervals, root_interval)
6283 (adjust_intervals_for_insertion, make_new_interval): Likewise.
6284 * lread.c (defalias): Likewise.
268c2c36 6285 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
6286 * regex.c (set_image_of_range_1, set_image_of_range)
6287 (regex_grow_registers): Likewise.
6288 * sysdep.c (strerror): Likewise.
6289 * termcap.c (valid_filename_p, tprint, main): Likewise.
6290 * tparam.c (main): Likewise.
6291 * unexhp9k800.c (run_time_remap, save_data_space)
6292 (update_file_ptrs, read_header, write_header, calculate_checksum)
6293 (copy_file, copy_rest, display_header): Likewise.
6294 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
6295 Likewise.
6296 * xdisp.c (check_it): Likewise.
6297 * xfaces.c (register_color, unregister_color, unregister_colors):
6298 Likewise.
6299 * xfns.c (print_fontset_result): Likewise.
6300 * xrdb.c (member, fatal, main): Likewise.
6301
99033785
PE
63022011-07-10 Paul Eggert <eggert@cs.ucla.edu>
6303
6304 Fix minor problems found by static checking (Bug#9031).
6305 * chartab.c (char_table_set_range, map_sub_char_table):
6306 Remove unused locals.
6307 (uniprop_table): Now static.
6308 * composite.c (_work_char): Remove unused static var.
6309
9cb2ac56
JB
63102011-07-09 Juanma Barranquero <lekktu@gmail.com>
6311
6312 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
6313
f25661f0
JD
63142011-07-09 Jan Djärv <jan.h.d@swipnet.se>
6315
6316 * gtkutil.c (qttip_cb): Remove code without function.
6317
8278c4fe
EZ
63182011-07-09 Eli Zaretskii <eliz@gnu.org>
6319
6320 * w32.c (pthread_sigmask): New stub.
6321
1692ae2d 63222011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 6323
8a6ebd58 6324 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
6325 sigprocmask is portable only for single-threaded applications, and
6326 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
6327 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
6328 (LIBES): Use it.
6329 * callproc.c (Fcall_process):
6330 * process.c (create_process):
6331 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
6332 Use pthread_sigmask, not sigprocmask.
123403e4 6333
1b854618
JD
63342011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6335
6336 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
6337 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
6338 wrong (Bug#8591).
6339
3fe4b549
JD
63402011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6341
0ce7e563
JD
6342 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
6343 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
6344 (xg_hide_tooltip): Fix comment.
6345
3fe4b549
JD
6346 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
6347 in registerServicesMenuSendTypes.
6348 (validRequestorForSendType): Don't check ns_return_types.
6349
6350 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
6351 ns_return_type.
6352
5df75e47
JR
63532011-07-08 Jason Rumney <jasonr@gnu.org>
6354
22610910
JR
6355 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
6356 SH_SHOW for hidden windows (Bug#5482).
6357
5df75e47
JR
6358 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
6359 frame struct members of non-existent frames (Bug#6284).
6360
699c10bd
JD
63612011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6362
4393663b
JD
6363 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
6364 variable firstTime not needed on OSX >= 10.6.
6365 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
6366 >= 10.5. Use setKnobProportion, setDoubleValue.
6367
6368 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
6369 (MAC_OS_X_VERSION_10_5): Define if not defined.
6370 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
6371 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
6372 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
6373
6374 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
6375 cString and lossyCString on OSX >= 10.4
6376
58179cce 6377 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
6378 sizeToFit on OSX >= 10.2.
6379
6380 * nsimage.m (allocInitFromFile): Don't use deprecated method
6381 bestRepresentationForDevice on OSX >= 10.6.
6382
6383 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
6384 to avoid warning.
6385
6386 * emacs.c: Declare unexec_init_emacs_zone.
6387
a63e0781
JD
6388 * nsgui.h: Fix compiler warning about gnulib redefining verify.
6389
699c10bd
JD
6390 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
6391
6392 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
6393 on svcsMenu (Bug#8842).
6394
6395 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
6396 ns_return_types.
6397 (Fns_list_services): Just return Qnil on 10.6, code not working there.
6398
6399 * nsterm.m (QUTF8_STRING): Declare.
6400 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
6401 (validRequestorForSendType): Return type is (id).
6402 Change indexOfObjectIdenticalTo to indexOfObject.
6403 Check if we have local selection before returning self (Bug#8842).
6404 (writeSelectionToPasteboard): Put local selection into paste board
6405 if we have a local selection (Bug#8842).
6406 (syms_of_nsterm): DEFSYM QUTF8_STRING.
6407
6408 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
6409 (ns_get_local_selection): Declare.
6410
54e10184
LMI
64112011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
6412
9888ff71
LMI
6413 * keymap.c (describe_map_tree): Don't insert a double newline at
6414 the end of the buffer (bug#1169) and return whether we inserted
6415 something.
6416
54e10184
LMI
6417 * callint.c (Fcall_interactively): Change "reading args" to
6418 "providing args" to try to clarify what it does (bug#1010).
6419
15fa4783
KH
64202011-07-07 Kenichi Handa <handa@m17n.org>
6421
6422 * composite.c (composition_compute_stop_pos): Ignore a static
6423 composition starting before CHARPOS (Bug#8915).
6424
6425 * xdisp.c (handle_composition_prop): Likewise.
6426
a8815b00
EZ
64272011-07-07 Eli Zaretskii <eliz@gnu.org>
6428
6429 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
6430 (Bug#9015)
6431
ef7b981d 64322011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
6433
6434 * character.h (unicode_category_t): New enum type.
6435
6436 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
6437 (Qchar_code_property_table): New variable.
6438 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
6439 (UNIPROP_COMPRESSED_FORM_P): New macros.
6440 (char_table_ascii): Uncompress the compressed values.
6441 (sub_char_table_ref): New arg is_uniprop. Callers changed.
6442 Uncompress the compressed values.
ac389d0c 6443 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
6444 (char_table_ref_and_range): Uncompress the compressed values.
6445 (sub_char_table_set): New arg is_uniprop. Callers changed.
6446 Uncompress the compressed values.
6447 (sub_char_table_set_range): Args changed. Callers changed.
6448 (char_table_set_range): Adjuted for the above change.
6449 (map_sub_char_table): Delete args default_val and parent. Add arg
6450 top. Give decoded values to a Lisp function.
640c8776 6451 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
6452 values to a Lisp function. Gcpro more variables.
6453 (uniprop_table_uncompress)
6454 (uniprop_decode_value_run_length): New functions.
6455 (uniprop_decoder, uniprop_decoder_count): New variables.
6456 (uniprop_get_decoder, uniprop_encode_value_character)
6457 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
6458 New functions.
6459 (uniprop_encoder, uniprop_encoder_count): New variables.
6460 (uniprop_get_encoder, uniprop_table)
6461 (Funicode_property_table_internal, Fget_unicode_property_internal)
6462 (Fput_unicode_property_internal): New functions.
6463 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
6464 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 6465 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
6466 char-code-property-alist.
6467
640c8776 6468 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
6469 Vunicode_category_table.
6470
640c8776 6471 * font.c (font_range): Adjust for the change of
c805dec0
KH
6472 Vunicode_category_table.
6473
76b397fb
DN
64742011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
6475
6476 * m/iris4d.h: Remove file, move contents ...
6477 * s/irix6-5.h: ... here.
6478
22b4128e
PE
64792011-07-06 Paul Eggert <eggert@cs.ucla.edu>
6480
6481 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
6482 * alloc.c (mark_buffer):
6483 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
6484 (clone_per_buffer_values): Don't assume that
22b4128e
PE
6485 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
6486 This isn't true in general, and it's particularly not true
6487 if Emacs is configured with --with-wide-int.
6488 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
6489 New macros, used in the buffer.c change.
6490
869795d6
JD
64912011-07-05 Jan Djärv <jan.h.d@swipnet.se>
6492
6493 * xsettings.c: Use both GConf and GSettings if both are available.
6494 (store_config_changed_event): Add comment.
6495 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
6496 (store_tool_bar_style_changed): New functions.
5e617bc2 6497 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
6498 (struct xsettings): Move font inside HAVE_XFT.
6499 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 6500 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 6501 Move inside HAVE_XFT.
640c8776 6502 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
6503 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
6504 also.
6505 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 6506 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 6507 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
6508 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
6509 (parse_settings): Move check for font inside HAVE_XFT.
6510 (read_settings, apply_xft_settings): Add comment.
6511 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
6512 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
6513 call store_font_name_changed.
6514 (xft_settings_event): Add comment.
6515 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
6516 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
6517 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
6518 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
6519 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
6520 (xsettings_get_system_font, xsettings_get_system_normal_font):
6521 Add comment.
869795d6 6522
d8ed26bd
PE
65232011-07-05 Paul Eggert <eggert@cs.ucla.edu>
6524
6525 Random fixes. E.g., (random) never returned negative values.
6526 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
6527 subseconds part to the entropy, as that's a bit more random.
6528 Prefer signed to unsigned, since the signedness doesn't matter and
6529 in general we prefer signed. When given a limit, use a
6530 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
6531 latter isn't right if USE_2_TAGS_FOR_INTS.
6532 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
6533 not 0..VALMASK. Don't discard "excess" bits that random () returns.
6534
cabf1cac
SM
65352011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
6536
6537 * textprop.c (text_property_stickiness):
6538 Obey Vtext_property_default_nonsticky.
6539 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
6540 * w32fns.c (syms_of_w32fns):
6541 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
6542
6e9b2be9
PE
65432011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6544
6545 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
6546 This is more efficient than Ffile_directory_p and avoids a minor race.
6547
90186c68
LMI
65482011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
6549
7c301272
LMI
6550 * buffer.c (Foverlay_put): Say what the return value is
6551 (bug#7835).
6552
c4f2d8d4
LMI
6553 * fileio.c (barf_or_query_if_file_exists): Check first if the file
6554 is a directory before asking whether to use the file name
6555 (bug#7564).
ad637907
LMI
6556 (barf_or_query_if_file_exists): Make the "File is a directory"
6557 error be more correct.
c4f2d8d4 6558
90186c68
LMI
6559 * fns.c (Frequire): Remove the mention of the .gz files, since
6560 that's installation-specific, but keep the mention of
6561 `get-load-suffixes'.
6562
da64016e
PE
65632011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6564
6565 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
6566 Report string overflow if the output is too long.
6567
7d47b580
JB
65682011-07-04 Juanma Barranquero <lekktu@gmail.com>
6569
a555cb87
JB
6570 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
6571 (syms_of_gnutls): Remove duplicate DEFSYM for
6572 Qgnutls_bootprop_verify_hostname_error, an error for
6573 Qgnutls_bootprop_verify_error (which is no longer used).
6574
7d47b580
JB
6575 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
6576 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
6577 Also (re)move comments that are misplaced or no longer relevant.
6578
1e49bfab
LMI
65792011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6580
6581 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
6582
1485f4c0
CY
65832011-07-03 Chong Yidong <cyd@stupidchicken.com>
6584
6585 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
6586 and background color parameters if they have been changed.
6587
a9ab721e
LMI
65882011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6589
6590 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
6591
cf7cff57
PE
65922011-07-03 Paul Eggert <eggert@cs.ucla.edu>
6593
2e13213d
PE
6594 * xsettings.c (SYSTEM_FONT): Define only when used.
6595 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
6596
cf7cff57
PE
6597 * keymap.c (access_keymap_1): Now static.
6598
7a8e04f7
CY
65992011-07-02 Chong Yidong <cyd@stupidchicken.com>
6600
6601 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
6602 leave any prefix arg for the up event (Bug#1586).
6603
61352f62
LMI
66042011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
6605
69bb1ef7
LMI
6606 * lread.c (syms_of_lread): Mention single symbols defined by
6607 `defvar' or `defconst' (bug#7154).
6608
61352f62 6609 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 6610 (Frequire): Mention get-load-suffixes.
61352f62 6611
28545e04
MR
66122011-07-02 Martin Rudalics <rudalics@gmx.at>
6613
6614 * window.h (window): Remove clone_number slot.
6615 * window.c (Fwindow_clone_number, Fset_window_clone_number):
6616 Remove.
6617 (make_parent_window, make_window, saved_window)
6618 (Fset_window_configuration, save_window_save): Don't deal with
6619 clone numbers.
6620 * buffer.c (Qclone_number): Remove declaration.
6621 (sort_overlays, overlay_strings): Don't deal with clone numbers.
6622
3349e122
SM
66232011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
6624
6625 Add multiple inheritance to keymaps.
6626 * keymap.c (Fmake_composed_keymap): New function.
6627 (Fset_keymap_parent): Simplify.
6628 (fix_submap_inheritance): Remove.
6629 (access_keymap_1): New function extracted from access_keymap to handle
6630 embedded parents and handle lists of maps.
6631 (access_keymap): Use it.
6632 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
6633 (Fcopy_keymap): Handle embedded parents.
6634 (Fcommand_remapping, define_as_prefix): Simplify.
6635 (Fkey_binding): Simplify.
6636 (syms_of_keymap): Move minibuffer-local-completion-map,
6637 minibuffer-local-filename-completion-map,
6638 minibuffer-local-must-match-map, and
6639 minibuffer-local-filename-must-match-map to Elisp.
6640 (syms_of_keymap): Defsubr make-composed-keymap.
6641 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
6642 (parse_menu_item): Trivial simplification.
6643
3279eb87
GM
66442011-07-01 Glenn Morris <rgm@gnu.org>
6645
6646 * Makefile.in (SETTINGS_LIBS): Fix typo.
6647
4550efdf
KI
66482011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
6649
6650 * coding.c (Fencode_coding_string): Record the last coding system
6651 used, as the function doc string says (bug#8738).
6652
0949d2b6
JD
66532011-07-01 Jan Djärv <jan.h.d@swipnet.se>
6654
6655 * xsettings.c (store_monospaced_changed): Take new font as arg and
6656 check for change against current_mono_font.
6657 (EMACS_TYPE_SETTINGS): Remove this and related defines.
6658 (emacs_settings_constructor, emacs_settings_get_property)
6659 (emacs_settings_set_property, emacs_settings_class_init)
6660 (emacs_settings_init, gsettings_obj): Remove.
6661 (something_changedCB): New function for HAVE_GSETTINGS.
6662 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
6663 with value as argument.
6664 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
6665 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 6666 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
6667 "changed".
6668
6669 * xgselect.c: Add defined (HAVE_GSETTINGS).
6670 (xgselect_initialize): Ditto.
6671
6672 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
6673 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
6674 xg_select.
6675
bbc6b304
PE
66762011-07-01 Paul Eggert <eggert@cs.ucla.edu>
6677
6678 * eval.c (struct backtrace): Simplify and port the data structure.
6679 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
6680 signed bit field, as this assumption is not portable and it makes
6681 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
6682 "char debug_on_exit : 1" as this is not portable either; instead,
6683 use the portable "unsigned int debug_on_exit : 1". Remove unused
6684 member evalargs. Remove obsolete comments about cc bombing out.
6685
9851bfc5
JD
66862011-06-30 Jan Djärv <jan.h.d@swipnet.se>
6687
51bb811f 6688 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
6689 Let HAVE_GSETTINGS override HAVE_GCONF.
6690 (store_monospaced_changed): New function.
6691 (EMACS_SETTINGS): A new type derived from GObject to handle
6692 GSettings notifications.
6693 (emacs_settings_constructor, emacs_settings_get_property)
6694 (emacs_settings_set_property, emacs_settings_class_init):
6695 New functions.
6696 (gsettings_client, gsettings_obj): New variables.
6697 (GSETTINGS_SCHEMA): New define.
6698 (something_changedCB): Call store_monospaced_changed.
6699 (init_gsettings): New function.
6700 (xsettings_initialize): Call init_gsettings.
6701 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
6702 to NULL.
6703
640c8776 6704 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
6705 GCONF_CFLAGS/LIBS.
6706
5386012d
MR
67072011-06-29 Martin Rudalics <rudalics@gmx.at>
6708
6709 * window.c (resize_root_window, grow_mini_window)
6710 (shrink_mini_window): Rename Qresize_root_window to
6711 Qwindow_resize_root_window and Qresize_root_window_vertically to
6712 Qwindow_resize_root_window_vertically.
6713
f13e0b08
PE
67142011-06-28 Paul Eggert <eggert@cs.ucla.edu>
6715
6716 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
6717
94515237
JB
67182011-06-27 Juanma Barranquero <lekktu@gmail.com>
6719
6720 * makefile.w32-in: Redesign dependencies so they reflect more
6721 clearly which files are directly included by each source file,
6722 and not through other includes.
6723
e43b6e43
MR
67242011-06-27 Martin Rudalics <rudalics@gmx.at>
6725
6726 * buffer.c (Qclone_number): Declare static and DEFSYM it.
6727 (sort_overlays, overlay_strings): When an overlay's clone number
6728 matches the window's clone number process the overlay even if
6729 the overlay's window property doesn't match the current window.
6730
d68443dc
MR
6731 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
6732 (Fwindow_hchild): Rename to Fwindow_left_child.
6733 (Fwindow_next): Rename to Fwindow_next_sibling.
6734 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
6735 (resize_window_check): Rename to window_resize_check.
6736 (resize_window_apply): Rename to window_resize_apply.
6737 (Fresize_window_apply): Rename to Fwindow_resize_apply.
6738 (Fdelete_other_windows_internal, resize_frame_windows)
6739 (Fsplit_window_internal, Fdelete_window_internal)
6740 (grow_mini_window, shrink_mini_window)
6741 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 6742
c7e73be5
JD
67432011-06-26 Jan Djärv <jan.h.d@swipnet.se>
6744
6745 * emacsgtkfixed.h: State that this is only used with Gtk+3.
6746 (emacs_fixed_set_min_size): Remove.
6747 (emacs_fixed_new): Take frame as argument.
6748
6749 * emacsgtkfixed.c: State that this is only used with Gtk+3.
6750 (_EmacsFixedPrivate): Remove minwidth/height.
6751 Add struct frame *f.
6752 (emacs_fixed_init): Initialize priv->f.
6753 (get_parent_class, emacs_fixed_set_min_size): Remove.
6754 (emacs_fixed_new): Set priv->f to argument.
6755 (emacs_fixed_get_preferred_width)
6756 (emacs_fixed_get_preferred_height): Use min_width/height from
6757 frames size_hint to set minimum and natural (Bug#8919).
6758 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
6759 and use min_width/height from frames size_hint to set
6760 min_width/height (Bug#8919).
6761
6762 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
6763 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
6764 Fix indentation.
c7e73be5 6765
cf99dcf8
EZ
67662011-06-26 Eli Zaretskii <eliz@gnu.org>
6767
6768 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
6769 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
6770 called at ZV.
6771
029529ac
CY
67722011-06-26 Chong Yidong <cyd@stupidchicken.com>
6773
6774 * process.c (wait_reading_process_output): Bypass select if
6775 waiting for a cell while ignoring keyboard input, and input is
6776 pending. Suggested by Jan Djärv (Bug#8869).
6777
7a7ef429
PE
67782011-06-25 Paul Eggert <eggert@cs.ucla.edu>
6779
6780 Use gnulib's dup2 module instead of rolling our own.
6781 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
6782
11fdef7d 67832011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
6784
6785 * dispnew.c (scrolling_window): Before scrolling, turn off a
6786 mouse-highlight in the window being scrolled.
6787
cd3520a4
JB
67882011-06-24 Juanma Barranquero <lekktu@gmail.com>
6789
6790 Move DEFSYM to lisp.h and use everywhere.
6791
6792 * character.h (DEFSYM): Move declaration...
6793 * lisp.h (DEFSYM): ...here.
6794
6795 * gnutls.c:
6796 * minibuf.c:
6797 * w32menu.c:
6798 * w32proc.c:
6799 * w32select.c: Don't include character.h.
6800
6801 * alloc.c (syms_of_alloc):
6802 * buffer.c (syms_of_buffer):
6803 * bytecode.c (syms_of_bytecode):
6804 * callint.c (syms_of_callint):
6805 * casefiddle.c (syms_of_casefiddle):
6806 * casetab.c (init_casetab_once):
6807 * category.c (init_category_once, syms_of_category):
6808 * ccl.c (syms_of_ccl):
6809 * cmds.c (syms_of_cmds):
6810 * composite.c (syms_of_composite):
6811 * dbusbind.c (syms_of_dbusbind):
6812 * dired.c (syms_of_dired):
6813 * dispnew.c (syms_of_display):
6814 * doc.c (syms_of_doc):
6815 * editfns.c (syms_of_editfns):
6816 * emacs.c (syms_of_emacs):
6817 * eval.c (syms_of_eval):
6818 * fileio.c (syms_of_fileio):
6819 * fns.c (syms_of_fns):
6820 * frame.c (syms_of_frame):
6821 * fringe.c (syms_of_fringe):
6822 * insdel.c (syms_of_insdel):
6823 * keymap.c (syms_of_keymap):
6824 * lread.c (init_obarray, syms_of_lread):
6825 * macros.c (syms_of_macros):
6826 * msdos.c (syms_of_msdos):
6827 * print.c (syms_of_print):
6828 * process.c (syms_of_process):
6829 * search.c (syms_of_search):
6830 * sound.c (syms_of_sound):
6831 * syntax.c (init_syntax_once, syms_of_syntax):
6832 * terminal.c (syms_of_terminal):
6833 * textprop.c (syms_of_textprop):
6834 * undo.c (syms_of_undo):
6835 * w32.c (globals_of_w32):
6836 * window.c (syms_of_window):
6837 * xdisp.c (syms_of_xdisp):
6838 * xfaces.c (syms_of_xfaces):
6839 * xfns.c (syms_of_xfns):
6840 * xmenu.c (syms_of_xmenu):
6841 * xsettings.c (syms_of_xsettings):
6842 * xterm.c (syms_of_xterm): Use DEFSYM.
6843
4228cf16
TZ
68442011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
6845
cd3520a4 6846 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 6847
7fcccf1e
PE
68482011-06-23 Paul Eggert <eggert@cs.ucla.edu>
6849
7efb4e0e
PE
6850 Integer and buffer overflow fixes (Bug#8873).
6851
ff5844ad
PE
6852 * print.c (printchar, strout): Check for string overflow.
6853 (PRINTPREPARE, printchar, strout):
6854 Don't set size unless allocation succeeds.
6855
90532f02
PE
6856 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
6857 for sizes. Check for string overflow more accurately.
6858 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
6859
6d84508d
PE
6860 * macros.c: Integer and buffer overflow fixes.
6861 * keyboard.h (struct keyboard.kbd_macro_bufsize):
6862 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
6863 Use ptrdiff_t, not int, for sizes.
6864 Don't increment bufsize until after realloc succeeds.
6865 Check for size-calculation overflow.
6866 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
6867
437b2cb4
PE
6868 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
6869
8b9ac8b4
PE
6870 * lread.c: Integer overflow fixes.
6871 (read_integer): Radix is now EMACS_INT, not int,
6872 to improve quality of diagnostics for out-of-range radices.
6873 Calculate buffer size correctly for out-of-range radices.
6874 (read1): Check for integer overflow in radices, and in
6875 read-circle numbers.
82cb60d3
PE
6876 (read_escape): Avoid int overflow.
6877 (Fload, openp, read_buffer_size, read1)
6878 (substitute_object_recurse, read_vector, read_list, map_obarray):
6879 Use ptrdiff_t, not int, for sizes.
6880 (read1): Use EMACS_INT, not int, for sizes.
20270765 6881 Check for size overflow.
8b9ac8b4 6882
7fcccf1e
PE
6883 * image.c (cache_image): Check for size arithmetic overflow.
6884
bfbbd7e7
PE
6885 * lread.c: Integer overflow issues.
6886 (saved_doc_string_size, saved_doc_string_length)
6887 (prev_saved_doc_string_size, prev_saved_doc_string_length):
6888 Now ptrdiff_t, not int.
6889 (read1): Don't assume doc string length fits in int. Check for
6890 out-of-range doc string lengths.
6891 (read_list): Don't assume file position fits in int.
39019e54 6892 (read_escape): Check for hex character overflow.
bfbbd7e7 6893
4e323265
LL
68942011-06-22 Leo Liu <sdl.web@gmail.com>
6895
6896 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
6897 Move to minibuffer.el.
6898
85fece3e
PE
68992011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6900
20b84ce9 6901 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
6902 The following patches are for when GLYPH_DEBUG && !XASSERT.
6903 * dispextern.h (trace_redisplay_p, dump_glyph_string):
6904 * dispnew.c (flush_stdout):
6905 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
6906 Mark as externally visible.
6907 * dispnew.c (check_window_matrix_pointers): Now static.
6908 * dispnew.c (window_to_frame_vpos):
6909 * xfns.c (unwind_create_frame):
6910 * xterm.c (x_check_font): Remove unused local.
6911 * scroll.c (CHECK_BOUNDS):
6912 * xfaces.c (cache_fache): Rename local to avoid shadowing.
6913 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
6914 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
6915 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
6916 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
6917 Now static.
6918 (debug_method_add): Use va_list and vsprintf rather than relying
6919 on undefined behavior with wrong number of arguments.
6920 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
6921 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
6922 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
6923 since we're not interested in debugging glyphs with old libraries.
6924 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
6925 GCC 4.6.0's static checking.
6926
0766b489
PE
69272011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6928
31fd4b32
PE
6929 Integer overflow and signedness fixes (Bug#8873).
6930 A few related buffer overrun fixes, too.
6931
b79e8648
PE
6932 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
6933
0766b489
PE
6934 * dispextern.h (struct face.stipple):
6935 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
6936 (x_bitmap_mask, x_allocate_bitmap_record)
6937 (x_create_bitmap_from_data, x_create_bitmap_from_file)
6938 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
6939 (x_create_bitmap_from_xpm_data):
6940 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
6941 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
6942 (.bitmaps_last):
6943 * xfaces.c (load_pixmap):
6944 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
6945 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
6946 (.bitmaps_last, struct x_output.icon_bitmap):
6947 Use ptrdiff_t, not int, for bitmap indexes.
6948 (x_allocate_bitmap_record): Check for size overflow.
6949 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
6950
b081724f
PE
6951 Use ptrdiff_t, not int, for overlay counts.
6952 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
6953 * editfns.c (overlays_around, get_pos_property):
6954 * textprop.c (get_char_property_and_overlay):
6955 * xdisp.c (next_overlay_change, note_mouse_highlight):
6956 * xfaces.c (face_at_buffer_position):
21514da7
PE
6957 * buffer.c (OVERLAY_COUNT_MAX): New macro.
6958 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
6959 (Fnext_overlay_change, Fprevious_overlay_change)
6960 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 6961 Use ptrdiff_t, not int, for sizes.
21514da7 6962 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 6963
3de73e5e
PE
6964 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
6965
2606c57b
PE
6966 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
6967 (x_session_initialize): Do not assume string length fits in int.
6968
aaafe47a
PE
6969 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
6970 This is unlikely, but can occur if DPI is outlandish.
6971
2674ddc8 6972 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
6973 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
6974
28154962
PE
6975 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
6976 * xrdb.c (magic_file_p, search_magic_path):
6977 Omit last arg SUFFIX; it was always 0. All callers changed.
6978 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
6979
7de51af5
PE
6980 * xfont.c (xfont_match): Avoid need for strlen.
6981
25ed6cc3
PE
6982 * xfns.c: Don't assume strlen fits in int.
6983 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
6984
4eab31dd
PE
6985 * xdisp.c (message_log_check_duplicate): Return intmax_t,
6986 not unsigned long, as we prefer signed integers. All callers changed.
6987 Detect integer overflow in repeat count.
6988 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 6989 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 6990
171e2a58
PE
6991 * termcap.c: Don't assume sizes fit in int and never overflow.
6992 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
6993 (gobble_line): Check for size-calculation overflow.
6994
ad39faca 6995 * minibuf.c (Fread_buffer):
6e5bb2dc 6996 * lread.c (intern, intern_c_string):
74ca2eb3
PE
6997 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
6998 Don't assume string length fits in int.
6999
52c61c22 7000 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
7001 * gtkutil.c (style_changed_cb): Avoid need for strlen.
7002
b5b8c9e5
PE
7003 * font.c: Don't assume string length fits in int.
7004 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
7005 Use ptrdiff_t, not int.
ccd6111c
PE
7006 (font_intern_prop): Don't assume string length fits in int.
7007 Don't assume integer property fits in fixnum.
7008 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 7009
882f0d81 7010 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 7011 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
7012 Reformulate so as not to need the command string.
7013 Invoke gzip -cd rather than gunzip, as it's more portable.
7014 (lock_info_type, lock_file_1, lock_file):
7015 Don't assume pid_t and time_t fit in unsigned long.
7016 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
7017 (current_lock_owner): Prefer signed type for sizes.
7018 Use memcpy, not strncpy, where memcpy is what is really wanted.
7019 Don't assume (via atoi) that time_t and pid_t fit in int.
7020 Check for time_t and/or pid_t out of range, e.g., via a network share.
7021 Don't alloca where an auto var works fine.
7022
93f4cf88
PE
7023 * fileio.c: Fix some integer overflow issues.
7024 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
7025 Don't assume string length fits in int.
7026 (directory_file_name): Don't assume string length fits in long.
7027 (make_temp_name): Don't assume pid fits in int, or that its print
7028 length is less than 20.
7029
f3e92b69
PE
7030 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
7031
1bfdaf10
PE
7032 * coding.c (make_subsidiaries): Don't assume string length fits in int.
7033
35016e9a
PE
7034 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
7035
3d1e65a1
PE
7036 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
7037 We prefer signed integers, even for size calculations.
7038
0b963a93
PE
7039 * emacs.c: Don't assume string length fits in 'int'.
7040 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
7041 (main): Don't invoke strlen when not needed.
7042
573f4b54
PE
7043 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
7044 (XD_DEBUG_MESSAGE): Don't waste a byte.
7045
989f33ba
PE
7046 * callproc.c (getenv_internal_1, getenv_internal)
7047 (Fgetenv_internal):
965d34eb
PE
7048 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
7049
e4d29b33
PE
7050 * lread.c (invalid_syntax): Omit length argument.
7051 All uses changed. This doesn't fix a bug, but it simplifies the
7052 code away from its former Hollerith-constant appearance, and it's
7053 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 7054 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 7055
eb49b136
PE
7056 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
7057 This didn't break anything, but it didn't help either.
7058 It's confusing to put a bogus integer in a place where the actual
7059 value does not matter.
9f62aeb1 7060 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 7061 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 7062
15375a22
PE
7063 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
7064 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
7065 implementation.
b61cc01c
PE
7066 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
7067 We prefer signed types, and the value cannot exceed the EMACS_INT
7068 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
7069 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
7070 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
7071 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 7072
53b2623d
PE
7073 * indent.c (sane_tab_width): New function.
7074 (current_column, scan_for_column, Findent_to, position_indentation)
7075 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 7076 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 7077
51cab52b 7078 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 7079
f2ed8a70
PE
7080 * lisp.h (lint_assume): New macro.
7081 * composite.c (composition_gstring_put_cache):
7082 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
7083
abe80cc6
PE
7084 * editfns.c, insdel.c:
7085 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 7086
b02c740e
PE
7087 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
7088
ebc96716
PE
7089 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
7090
b4e50fa0 7091 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 7092 Use much-faster test for byte-length change.
311d5d7c 7093 Don't assume string byte-length fits in 'int'.
a4cf38e4 7094 Check that character arg fits in 'int'.
85461888 7095 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 7096
c0c1ee9f
PE
7097 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
7098
a498d7f4
PE
7099 * fns.c (concat): Catch string overflow earlier.
7100 Do not rely on integer wraparound.
7101
51cab52b
PE
7102 * dispextern.h (struct it.overlay_strings_charpos)
7103 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
7104 * xdisp.c (forward_to_next_line_start)
7105 (back_to_previous_visible_line_start)
7106 (reseat_at_next_visible_line_start, next_element_from_buffer):
7107 Don't arbitrarily truncate the value of 'selective' to int.
7108
76031fad
PE
7109 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
7110
5eb55db9
PE
7111 * composite.c: Don't truncate sizes to 'int'.
7112 (composition_gstring_p, composition_reseat_it)
7113 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
7114 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
7115 not EMACS_UINT, for indexes.
5eb55db9 7116
0703a717
PE
7117 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
7118
d6202519
PE
7119 * buffer.c: Include <verify.h>.
7120 (struct sortvec.priority, struct sortstr.priority):
8961a454 7121 Now EMACS_INT, not int.
c20998a7 7122 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
7123 (struct sortstr.size, record_overlay_string)
7124 (struct sortstrlist.size, struct sortlist.used):
7125 Don't truncate size to int.
7126 (record_overlay_string): Check for size-calculation overflow.
d6202519 7127 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 7128
d5a19415
JM
71292011-06-22 Jim Meyering <meyering@redhat.com>
7130
029529ac 7131 Don't leak an XBM-image-sized buffer
d5a19415
JM
7132 * image.c (xbm_load): Free the image buffer after using it.
7133
a9041e6c
PE
71342011-06-21 Paul Eggert <eggert@cs.ucla.edu>
7135
7136 Port to Sun C.
7137 * composite.c (find_automatic_composition): Omit needless 'return 0;'
7138 that Sun C diagnosed.
7139 * fns.c (secure_hash): Fix pointer signedness issue.
7140 * intervals.c (static_offset_intervals): New function.
7141 (offset_intervals): Use it.
7142
7f3f739f
LL
71432011-06-21 Leo Liu <sdl.web@gmail.com>
7144
7145 * deps.mk (fns.o):
7146 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
7147 sha512.h.
7148
7149 * fns.c (secure_hash): Rename from crypto_hash_function and change
7150 the first arg to accept symbols.
5b66d427 7151 (Fsecure_hash): New primitive.
7f3f739f
LL
7152 (syms_of_fns): New symbols.
7153
76147d94
DD
71542011-06-20 Deniz Dogan <deniz@dogan.se>
7155
7156 * process.c (Fset_process_buffer): Clarify return value in
7157 docstring.
7158
7d7d0045
CY
71592011-06-18 Chong Yidong <cyd@stupidchicken.com>
7160
7161 * dispnew.c (add_window_display_history): Use BVAR.
7162
7163 * xdisp.c (debug_method_add): Use BVAR.
7164 (check_window_end, dump_glyph_matrix, dump_glyph)
7165 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
7166
7167 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
7168 Likewise.
7169
7170 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
7171 check till after the cache is created in init_frame_faces.
7172
ff2bc410
SM
71732011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
7174
7175 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
7176
28177add
PE
71772011-06-16 Paul Eggert <eggert@cs.ucla.edu>
7178
dd3482fe
PE
7179 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
7180 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
7181 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
7182
393d71f3 7183 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
7184 * fileio.c (Finsert_file_contents):
7185 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
7186 Remove the old (too-loose) buffer overflow checks.
7187 They weren't needed, since make_gap checks for buffer overflow.
7188 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
7189 The old code merely checked for Emacs fixnum overflow, and relied
7190 on undefined (wraparound) behavior. The new code avoids undefined
7191 behavior, and also checks for ptrdiff_t and/or size_t overflow.
7192
2e6813b0 7193 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
7194 Tune. Don't use wider integers than needed. Don't use alloca.
7195 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 7196
599a9e4f
PE
7197 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
7198
99561444
PE
7199 * insdel.c, lisp.h (buffer_overflow): New function.
7200 (insert_from_buffer_1, replace_range, replace_range_2):
7201 * insdel.c (make_gap_larger):
7202 * editfns.c (Finsert_char):
7203 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
7204
28177add
PE
7205 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
7206
e69dafad
PE
72072011-06-15 Paul Eggert <eggert@cs.ucla.edu>
7208
4baa020d 7209 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 7210
b1c46f02
PE
7211 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
7212 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
7213
e69dafad
PE
7214 * fileio.c: Don't assume EMACS_INT fits in off_t.
7215 (emacs_lseek): New static function.
7216 (Finsert_file_contents, Fwrite_region): Use it.
7217 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
7218
566684ea
PE
7219 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
7220
e6966cd6
PE
7221 * fns.c: Don't overflow int when computing a list length.
7222 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
7223 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
7224 truncation on 64-bit hosts. Check for QUIT every
7225 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
7226 faster and is responsive enough.
7227 (Flength): Report an error instead of overflowing an integer.
7228 (Fsafe_length): Return a float if the value is not representable
7229 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 7230 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 7231 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 7232
dd0b0efb
PE
7233 * alloc.c: Check that resized vectors' lengths fit in fixnums.
7234 (header_size, word_size): New constants.
7235 (allocate_vectorlike): Don't check size overflow here.
7236 (allocate_vector): Check it here instead, since this is the only
7237 caller of allocate_vectorlike that could cause overflow.
7238 Check that the new vector's length is representable as a fixnum.
7239
86fe5cfe
PE
7240 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
7241 The previous code was bogus. For example, next_almost_prime (32)
7242 returned 39, which is undesirable as it is a multiple of 3; and
7243 next_almost_prime (24) returned 25, which is a multiple of 5 so
7244 why was the code bothering to check for multiples of 7?
7245
80e88859
PE
7246 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
7247
4a2f0ad6
PE
7248 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
7249
f66c7cf8
PE
7250 Variadic C functions now count arguments with ptrdiff_t.
7251 This partly undoes my 2011-03-30 change, which replaced int with size_t.
7252 Back then I didn't know that the Emacs coding style prefers signed int.
7253 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
7254 were being counted with int, which may truncate counts on 64-bit
7255 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
7256 * lisp.h (struct Lisp_Subr.function.aMANY)
7257 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
7258 Arg counts are now ptrdiff_t, not size_t.
7259 All variadic functions and their callers changed accordingly.
7260 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
7261 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
7262 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
7263 * callint.c (Fcall_interactively): Check arg count for overflow,
7264 to avoid potential buffer overrun. Use signed char, not 'int',
7265 for 'varies' array, so that we needn't bother to check its size
7266 calculation for overflow.
7267 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
7268 * eval.c (apply_lambda):
7269 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
7270 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
7271 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
7272
a1759b76
PE
7273 * callint.c (Fcall_interactively): Don't use index var as event count.
7274
d96be9fc
PE
7275 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
7276 * mem-limits.h (SIZE): Remove; no longer used.
7277
a690a978 7278 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 7279
578c21e6
PE
7280 Remove unnecessary casts.
7281 * xterm.c (x_term_init):
7282 * xfns.c (x_set_border_pixel):
7283 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
7284 These aren't needed now that we assume ANSI C.
7285
96f53c6c
PE
7286 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
7287 It's more likely to cause problems (due to unsigned overflow)
7288 than to cure them.
7289
83c77d31
PE
7290 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
7291
ee2079f1
PE
7292 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
7293
6da65536
PE
7294 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
7295
7147c4a4
PE
7296 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
7297
193e32d9
PE
7298 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
7299
e5533da6
PE
7300 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
7301
9910e595
PE
7302 GLYPH_CODE_FACE returns EMACS_INT, not int.
7303 * dispextern.h (merge_faces):
7304 * xfaces.c (merge_faces):
01103c44
PE
7305 * xdisp.c (get_next_display_element, next_element_from_display_vector):
7306 Don't assume EMACS_INT fits in int.
9910e595 7307
2638320e
PE
7308 * character.h (CHAR_VALID_P): Remove unused parameter.
7309 * fontset.c, lisp.h, xdisp.c: All uses changed.
7310
045eb8d9
PE
7311 * editfns.c (Ftranslate_region_internal): Omit redundant test.
7312
c1f134b5
PE
7313 * fns.c (concat): Minor tuning based on overflow analysis.
7314 This doesn't fix any bugs. Use int to hold character, instead
7315 of constantly refetching from Emacs object. Use XFASTINT, not
7316 XINT, for value known to be a character. Don't bother comparing
7317 a single byte to 0400, as it's always less.
7318
395fcb93 7319 * floatfns.c (Fexpt):
327eeec8
PE
7320 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
7321
abbd3d23
PE
7322 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
7323 for characters.
7324
684a03ef
PE
7325 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
7326
0fed43f3
PE
7327 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
7328 Without this fix, on a 64-bit host (aset S 0 4294967386) would
7329 incorrectly succeed when S was a string, because 4294967386 was
7330 truncated before it was used.
7331
8fd02eb7
PE
7332 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
7333 Otherwise, an out-of-range integer could cause undefined behavior
7334 on a 64-bit host.
7335
f8c86b69
PE
7336 * composite.c: Use int, not EMACS_INT, for characters.
7337 (fill_gstring_body, composition_compute_stop_pos): Use int, not
7338 EMACS_INT, for values that are known to be in character range.
7339 This doesn't fix any bugs but is the usual style inside Emacs and
7340 may generate better code on 32-bit machines.
7341
34206dd2
PE
7342 Make sure a 64-bit char is never passed to ENCODE_CHAR.
7343 This is for reasons similar to the recent CHAR_STRING fix.
7344 * charset.c (Fencode_char): Check that character arg is actually
7345 a character. Pass an int to ENCODE_CHAR.
7346 * charset.h (ENCODE_CHAR): Verify that the character argument is no
7347 wider than 'int', as a compile-time check to prevent future regressions
7348 in this area.
7349
c5958d4c 7350 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
7351
7352 Make sure a 64-bit char is never passed to CHAR_STRING.
7353 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
7354 by silently ignoring the top 32 bits, allowing some values
7355 that were far too large to be valid characters.
7356 * character.h: Include <verify.h>.
7357 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
7358 arguments are no wider than unsigned, as a compile-time check
7359 to prevent future regressions in this area.
7360 * data.c (Faset):
01103c44 7361 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
7362 (Fsubst_char_in_region):
7363 * fns.c (concat):
7364 * xdisp.c (decode_mode_spec_coding):
7365 Adjust to CHAR_STRING's new requirement.
7366 * editfns.c (Finsert_char, Fsubst_char_in_region):
7367 * fns.c (concat): Check that character args are actually
7368 characters. Without this test, these functions did the wrong
7369 thing with wildly out-of-range values on 64-bit hosts.
7370
d37ca623
PE
7371 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
7372 These casts should not be needed on 32-bit hosts, either.
7373 * keyboard.c (read_char):
7374 * lread.c (Fload): Remove casts to unsigned.
7375
ea204efb
PE
7376 * lisp.h (UNSIGNED_CMP): New macro.
7377 This fixes comparison bugs on 64-bit hosts.
7378 (ASCII_CHAR_P): Use it.
7379 * casefiddle.c (casify_object):
01103c44 7380 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
7381 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
7382 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
7383 * dispextern.h (FACE_FROM_ID):
7384 * keyboard.c (read_char): Use UNSIGNED_CMP.
7385
41cb286c
PE
7386 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
7387 not to EMACS_INT, to avoid GCC warning.
7388
4a1b9832
PE
7389 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
7390
55daad71
PE
7391 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
7392 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
7393 isn't needed on 32-bit machines.
8f95c75c 7394
01103c44
PE
7395 * buffer.c (Fgenerate_new_buffer_name):
7396 Use EMACS_INT for count, not int.
0ceccced 7397 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
7398
7399 * data.c (Qcompiled_function): Now static.
7400
c6f072e7
PE
7401 * window.c (window_body_lines): Now static.
7402
20ce5912
PE
7403 * image.c (gif_load): Rename local to avoid shadowing.
7404
9c4c5f81
PE
7405 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
7406 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
7407 * alloc.c (make_save_value): Integer argument is now of type
7408 ptrdiff_t, not int.
7409 (mark_object): Use ptrdiff_t, not int.
7410 * lisp.h (pD): New macro.
7411 * print.c (print_object): Use it.
7412
c0c5c8ae
PE
7413 * alloc.c: Use EMACS_INT, not int, to count objects.
7414 (total_conses, total_markers, total_symbols, total_vector_size)
7415 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
7416 (total_free_floats, total_floats, total_free_intervals)
7417 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
7418 Now EMACS_INT, not int. All uses changed.
7419 (Fgarbage_collect): Compute overall total using a double, so that
7420 integer overflow is less likely to be a problem. Check for overflow
7421 when converting back to an integer.
5a25e253
PE
7422 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
7423 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
7424 These were 'int' variables that could overflow on 64-bit hosts;
7425 they were never used, so remove them instead of repairing them.
211a0b2a 7426 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
7427 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
7428 Previously, this ceilinged at INT_MAX, but that doesn't work on
7429 64-bit machines.
e46bb31a 7430 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 7431
c78baabf 7432 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 7433 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
7434 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
7435 when a (possibly-narrower) signed value would do just as well.
7436 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 7437
c9d624c6
PE
7438 * alloc.c: Catch some string size overflows that we were missing.
7439 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
7440 for convenience in STRING_BYTES_MAX.
7441 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
7442 The definition here is exact; the one in lisp.h was approximate.
7443 (allocate_string_data): Check for string overflow. This catches
7444 some instances we weren't catching before. Also, it catches
7445 size_t overflow on (unusual) hosts where SIZE_MAX <= min
7446 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
7447 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 7448
c9d624c6
PE
7449 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
7450 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 7451 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 7452
353032ce
PE
7453 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
7454
2bccce07
PE
7455 * alloc.c (Fmake_string): Check for out-of-range init.
7456
0ac30604
SM
74572011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
7458
7459 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
7460
c195f2de
JD
74612011-06-14 Jan Djärv <jan.h.d@swipnet.se>
7462
7463 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
7464 xg_get_default_scrollbar_width.
7465
7466 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
7467 (int_gtk_range_get_value): Move to the scroll bar part of the file.
7468 (style_changed_cb): Call update_theme_scrollbar_width and call
7469 x_set_scroll_bar_default_width and xg_frame_set_char_size for
7470 all frames (Bug#8505).
7471 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
7472 Call gtk_window_set_resizable if HAVE_GTK3.
7473 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
7474 and height if HAVE_GTK3 (Bug#8505).
7475 (scroll_bar_width_for_theme): New variable.
7476 (update_theme_scrollbar_width): New function.
7477 (xg_get_default_scrollbar_width): Move code to
7478 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
7479 (xg_initialize): Call update_theme_scrollbar_width.
7480
7481 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
7482
7483 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
7484
e10ac9f1
MR
74852011-06-12 Martin Rudalics <rudalics@gmx.at>
7486
7487 * frame.c (make_frame): Call other_buffer_safely instead of
7488 other_buffer.
7489
7490 * window.c (temp_output_buffer_show): Call display_buffer with
7491 second argument Vtemp_buffer_show_specifiers and reset latter
7492 immediately after the call.
7493 (Vtemp_buffer_show_specifiers): New variable.
7494 (auto_window_vscroll_p, next_screen_context_lines)
7495 (Vscroll_preserve_screen_position): Remove leading asterisks from
7496 doc-strings.
7497
2d3c217e 74982011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 7499
7b7f97e8 7500 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
7501 * buffer.c (Qclone_number): Remove for now, as it's unused.
7502 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
7503 (record_buffer): Remove unused local.
7504 * frame.c (other_visible_frames, frame_buffer_list): Now static.
7505 (set_frame_buffer_list): Remove; unused.
7506 * frame.h (other_visible_frames): Remove decl.
7507 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
7508 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
7509 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
7510 if HAVE_GPM.
7511 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
7512 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
7513 Define only if HAVE_GPM.
7514 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
7515 (update_hints_inhibit): Remove; never set. All uses removed.
7516 * widgetprv.h (emacsFrameClassRec): Remove decl.
7517 * window.c (delete_deletable_window): Now returns void, since it
7518 wasn't returning anything.
7519 (compare_window_configurations): Remove unused locals.
7520 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
7521 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
7522 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
7523 the same widths as pointers. This follows up on the 2011-05-06 patch.
7524 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
7525 * xterm.h: Likewise.
7526 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
7527
1384b89e
JB
75282011-06-12 Juanma Barranquero <lekktu@gmail.com>
7529
7530 * makefile.w32-in: Update dependencies.
7531 (LISP_H): Add lib/intprops.h.
7532
1100a63c
CY
75332011-06-11 Chong Yidong <cyd@stupidchicken.com>
7534
7535 * image.c (gif_load): Add animation frame delay to the metadata.
7536 (syms_of_image): Use DEFSYM. New symbol `delay'.
7537
6198ccd0
MR
75382011-06-11 Martin Rudalics <rudalics@gmx.at>
7539
7540 * window.c (delete_deletable_window): Re-add.
7541 (Fset_window_configuration): Rewrite to handle dead buffers and
7542 consequently deletable windows.
7543 (window_tree, Fwindow_tree): Remove. Supply functionality in
7544 window.el.
7545 (compare_window_configurations): Simplify code.
7546
b6e3633c
AS
75472011-06-11 Andreas Schwab <schwab@linux-m68k.org>
7548
1ab0dee5
AS
7549 * image.c (imagemagick_load_image): Fix type mismatch.
7550 (Fimagemagick_types): Likewise.
7551
b6e3633c
AS
7552 * window.h (replace_buffer_in_windows): Declare.
7553
9397e56f
MR
75542011-06-11 Martin Rudalics <rudalics@gmx.at>
7555
7556 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
7557 Qclone_number. Remove external declaration of Qdelete_window.
7558 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
7559 code.
640c8776
SM
7560 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
7561 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
7562 (Fother_buffer): Rewrite doc-string. Major rewrite for new
7563 buffer list implementation.
7564 (other_buffer_safely): New function.
7565 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
7566 calls to replace_buffer_in_windows and
7567 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
7568 if allowed.
7569 (record_buffer): Inhibit quitting and rewrite using quittable
7570 functions. Run Qbuffer_list_update_hook if allowed.
7571 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
7572 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
7573 Move switch-to-buffer to window.el.
9397e56f
MR
7574 (bury-buffer): Move to window.el.
7575 (Vbuffer_list_update_hook): New variable.
7576
7577 * lisp.h (other_buffer_safely): Add prototype in buffer.c
7578 section.
7579
7580 * window.h (resize_frame_windows): Move up in code.
7581 (Fwindow_frame): Remove EXFUN.
7582 (replace_buffer_in_all_windows): Remove prototype.
7583 (replace_buffer_in_windows_safely): Add prototype.
7584
7585 * window.c: Declare Qdelete_window static again. Move down
7586 declaration of select_count.
7587 (Fnext_window, Fprevious_window): Rewrite doc-strings.
7588 (Fother_window): Move to window.el.
7589 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
7590 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
7591 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
7592 window.el.
7593 (replace_buffer_in_windows): Implement by calling
7594 Qreplace_buffer_in_windows.
7595 (replace_buffer_in_all_windows): Remove with some functionality
7596 moved into replace_buffer_in_windows_safely.
7597 (replace_buffer_in_windows_safely): New function.
7598 (select_window_norecord, select_frame_norecord): Move in front
7599 of run_window_configuration_change_hook. Remove now obsolete
7600 declarations.
640c8776
SM
7601 (Fset_window_buffer): Rewrite doc-string.
7602 Call Qrecord_window_buffer.
9397e56f
MR
7603 (keys_of_window): Move binding for other-window to window.el.
7604
b50691aa
CY
76052011-06-11 Chong Yidong <cyd@stupidchicken.com>
7606
7607 * dispextern.h (struct image): Replace data member, whose int_val
7608 and ptr_val fields were not used by anything, with a single
7609 lisp_val object.
7610
7611 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
7612 (gif_clear_image, gif_load, imagemagick_load_image)
7613 (gs_clear_image, gs_load): Callers changed.
7614
3f754b86
PE
76152011-06-10 Paul Eggert <eggert@cs.ucla.edu>
7616
cca69397
PE
7617 * buffer.h: Include <time.h>, for time_t.
7618 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
7619
109e28d0
PE
7620 Fix minor problems found by static checking.
7621
60737f02
PE
7622 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
7623
4b66faf3
PE
7624 Make identifiers static if they are not used in other modules.
7625 * data.c (Qcompiled_function, Qframe, Qvector):
7626 * image.c (QimageMagick, Qsvg):
7627 * minibuf.c (Qmetadata):
7628 * window.c (resize_window_check, resize_root_window): Now static.
7629 * window.h (resize_window_check, resize_root_window): Remove decls.
7630
109e28d0
PE
7631 * window.c (window_deletion_count, delete_deletable_window):
7632 Remove; unused.
46a4ce9e
PE
7633 (window_body_lines): Now static.
7634 (Fdelete_other_windows_internal): Mark vars as initialized.
7635 Make sure 'resize_failed' is initialized.
7636 (run_window_configuration_change_hook): Rename local to avoid shadowing.
7637 (resize_window_apply): Remove unused local.
7638 * window.h (delete_deletable_window): Remove decl.
7639
109e28d0 7640 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
7641 (imagemagick_load_image): Fix pointer signedness problem by changing
7642 last arg from unsigned char * to char *. All uses changed.
7643 Also, fix a local for similar reasons.
7644 Remove unused locals. Remove locals to avoid shadowing.
7645 (fn_rsvg_handle_free): Remove; unused.
7646 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 7647 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 7648
3f754b86
PE
7649 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
7650
2547adb1
CY
76512011-06-10 Chong Yidong <cyd@stupidchicken.com>
7652
7653 * image.c (gif_load): Fix omitted cast error introduced by
7654 2011-06-06 change.
7655
2c8e37d4
MR
76562011-06-10 Martin Rudalics <rudalics@gmx.at>
7657
7658 * window.h (resize_proportionally, orig_total_lines)
7659 (orig_top_line): Remove from window structure.
7660 (set_window_height, set_window_width, change_window_heights)
7661 (Fdelete_window): Remove prototypes.
7662 (resize_frame_windows): Remove duplicate declaration.
7663
440a42e3
EZ
76642011-06-10 Eli Zaretskii <eliz@gnu.org>
7665
7666 * window.h (resize_frame_windows, resize_window_check)
7667 (delete_deletable_window, resize_root_window)
7668 (resize_frame_windows): Declare prototypes.
7669
7670 * window.c (resize_window_apply): Make definition be "static" to
7671 match the prototype.
7672
562dd5e9
MR
76732011-06-10 Martin Rudalics <rudalics@gmx.at>
7674
7675 * window.c: Remove declarations of Qwindow_size_fixed,
7676 window_min_size_1, window_min_size_2, window_min_size,
7677 size_window, window_fixed_size_p, enlarge_window, delete_window.
7678 Remove static from declaration of Qdelete_window, it's
7679 temporarily needed by Fbury_buffer.
7680 (replace_window): Don't assign orig_top_line and
7681 orig_total_lines.
7682 (Fdelete_window, delete_window): Remove. Window deletion is
7683 handled by window.el.
640c8776
SM
7684 (window_loop): Remove DELETE_OTHER_WINDOWS case.
7685 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
7686 (Fdelete_other_windows): Remove. Deleting other windows is
7687 handled by window.el.
7688 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
7689 handled in window.el.
7690 (window_min_size_2, window_min_size_1, window_min_size): Remove.
7691 Window minimum sizes are handled in window.el.
7692 (shrink_windows, size_window, set_window_height)
7693 (set_window_width, change_window_heights, window_height)
7694 (window_width, CURBEG, CURSIZE, enlarge_window)
7695 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
7696 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
7697 handled in window.el.
7698 (make_dummy_parent): Rename to make_parent_window and give it a
7699 second argument horflag.
7700 (make_window): Don't set resize_proportionally any more.
7701 (Fsplit_window): Remove. Windows are split in window.el.
7702 (save_restore_action, save_restore_orig_size)
7703 (shrink_window_lowest_first, save_restore_orig_size): Remove.
7704 Resize mini windows in window.el.
7705 (grow_mini_window, shrink_mini_window): Implement by calling
7706 Qresize_root_window_vertically, resize_window_check and
7707 resize_window_apply.
640c8776
SM
7708 (saved_window, Fset_window_configuration, save_window_save):
7709 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
7710 resize_proportionally.
7711 (window_min_height, window_min_width): Move to window.el.
7712 (keys_of_window): Move bindings for delete-other-windows,
7713 split-window, delete-window and enlarge-window to window.el.
7714
7715 * buffer.c: Temporarily extern Qdelete_window.
7716 (Fbury_buffer): Temporarily call Qdelete_window instead of
7717 Fdelete_window (Fbury_buffer will move to window.el soon).
7718
7719 * frame.c (set_menu_bar_lines_1): Remove code handling
7720 orig_top_line and orig_total_lines.
7721
7722 * dispnew.c (adjust_frame_glyphs_initially): Don't use
7723 set_window_height but set heights directly.
7724 (change_frame_size_1): Use resize_frame_windows.
7725
7726 * xdisp.c (init_xdisp): Don't use set_window_height but set
7727 heights directly.
7728
640c8776
SM
7729 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
7730 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
7731 run_window_configuration_change_hook.
7732
7733 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
7734 instead of change_window_heights and run
7735 run_window_configuration_change_hook.
7736
1a13852e
MR
77372011-06-09 Martin Rudalics <rudalics@gmx.at>
7738
7739 * window.c (replace_window): Rename second argument REPLACEMENT to
7740 NEW. New third argument SETFLAG. Rewrite.
7741 (delete_window, make_dummy_parent): Call replace_window with
7742 third argument 1.
7743 (window_list_1): Move down in code.
7744 (run_window_configuration_change_hook): Move set_buffer part
7745 before select_frame_norecord part in order to unwind correctly.
7746 Rename count1 to count.
7747 (recombine_windows, delete_deletable_window, resize_root_window)
7748 (Fdelete_other_windows_internal)
7749 (Frun_window_configuration_change_hook, make_parent_window)
7750 (resize_window_check, resize_window_apply, Fresize_window_apply)
7751 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
7752 (Fdelete_window_internal, Fresize_mini_window_internal):
7753 New functions.
1a13852e
MR
7754 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
7755
f3d1777e
MR
77562011-06-08 Martin Rudalics <rudalics@gmx.at>
7757
496e208e
MR
7758 * window.h (window): Add some new members to window structure -
7759 normal_lines, normal_cols, new_total, new_normal, clone_number,
7760 splits, nest, prev_buffers, next_buffers.
7761 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 7762 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 7763
f3d1777e
MR
7764 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
7765 Remove.
496e208e
MR
7766 (make_dummy_parent): Set new members of windows structure.
7767 (make_window): Move down in code. Handle new members of window
7768 structure.
7769 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
7770 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
7771 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
7772 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
7773 (Fset_window_next_buffers, Fset_window_clone_number):
7774 New functions.
496e208e
MR
7775 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
7776 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
7777 Doc-string fixes.
7778 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
7779 Argument WINDOW can be now internal window too.
7780 (Fwindow_use_time): Move up in code.
7781 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
7782 Rewrite doc-string.
7783 (Fset_window_configuration, saved_window)
7784 (Fcurrent_window_configuration, save_window_save): Handle new
7785 members of window structure.
b9e809c2
MR
7786 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
7787 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
7788 (syms_of_window): New Lisp objects Qrecord_window_buffer,
7789 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
7790 Qget_mru_window, Qresize_root_window,
7791 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
7792 Qauto_buffer_name; staticpro them.
f3d1777e 7793
abde8f8c
MR
77942011-06-07 Martin Rudalics <rudalics@gmx.at>
7795
7796 * window.c (Fwindow_total_size, Fwindow_left_column)
7797 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
7798 (Fwindow_list_1): New functions.
7799 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
7800 (Fwindow_width, Fscroll_left, Fscroll_right):
7801 Use window_body_cols instead of window_box_text_cols.
7802 (delete_window, Fset_window_configuration):
7803 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
7804 (delete_all_subwindows): Take a window as argument and not a
7805 structure. Rewrite.
190b47e6
MR
7806 (window_loop): Remove handling of GET_LRU_WINDOW and
7807 GET_LARGEST_WINDOW.
7808 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
7809
7810 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
7811 window_box_text_cols. delete_all_subwindows now takes a
7812 Lisp_Object as argument.
abde8f8c 7813
640c8776
SM
7814 * indent.c (compute_motion, Fcompute_motion):
7815 Use window_body_cols instead of window_box_text_cols.
abde8f8c 7816
fa8a67e6
MR
7817 * frame.c (delete_frame): Call delete_all_subwindows with root
7818 window as argument.
7819
a54e3482
DC
78202011-06-07 Daniel Colascione <dan.colascione@gmail.com>
7821
7822 * fns.c (Fputhash): Document return value.
7823
60002bf5
CY
78242011-06-06 Chong Yidong <cyd@stupidchicken.com>
7825
7826 * image.c (gif_load): Implement gif89a spec "no disposal" method.
7827
0c671da6 78282011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 7829
b862a52a 7830 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 7831
be44ca6c
PE
7832 Check for overflow when converting integer to cons and back.
7833 * charset.c (Fdefine_charset_internal, Fdecode_char):
7834 Use cons_to_unsigned to catch overflow.
7835 (Fencode_char): Use INTEGER_TO_CONS.
7836 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
7837 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
7838 * data.c (long_to_cons, cons_to_long): Remove.
7839 (cons_to_unsigned, cons_to_signed): New functions.
7840 These signal an error for invalid or out-of-range values.
7841 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
7842 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
7843 * font.c (Ffont_variation_glyphs):
7844 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
7845 * lisp.h: Include <intprops.h>.
7846 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
7847 (cons_to_signed, cons_to_unsigned): New decls.
7848 (long_to_cons, cons_to_long): Remove decls.
7849 * undo.c (record_first_change): Use INTEGER_TO_CONS.
7850 (Fprimitive_undo): Use CONS_TO_INTEGER.
7851 * xfns.c (Fx_window_property): Likewise.
7852 * xselect.c: Include <limits.h>.
7853 (x_own_selection, selection_data_to_lisp_data):
7854 Use INTEGER_TO_CONS.
7855 (x_handle_selection_request, x_handle_selection_clear)
7856 (x_get_foreign_selection, Fx_disown_selection_internal)
7857 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
7858 (lisp_data_to_selection_data): Use cons_to_unsigned.
7859 (x_fill_property_data): Use cons_to_signed.
7860 Report values out of range.
7861
d1f3d2af
PE
7862 Check for buffer and string overflow more precisely.
7863 * buffer.h (BUF_BYTES_MAX): New macro.
7864 * lisp.h (STRING_BYTES_MAX): New macro.
7865 * alloc.c (Fmake_string):
7866 * character.c (string_escape_byte8):
7867 * coding.c (coding_alloc_by_realloc):
7868 * doprnt.c (doprnt):
7869 * editfns.c (Fformat):
7870 * eval.c (verror):
7871 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
7872 since they may not be the same number.
7873 * editfns.c (Finsert_char):
7874 * fileio.c (Finsert_file_contents):
7875 Likewise for BUF_BYTES_MAX.
7876
dd52fcea
PE
7877 * image.c: Use ptrdiff_t, not int, for sizes.
7878 (slurp_file): Switch from int to ptrdiff_t.
7879 All uses changed.
7880 (slurp_file): Check that file size fits in both size_t (for
7881 malloc) and ptrdiff_t (for sanity and safety).
7882
7f9bbdbb
PE
7883 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
7884 if b->modtime has its maximal value.
7885
dfe18f82
PE
7886 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
7887
84acfcf0
PE
7888 Don't assume time_t can fit into int.
7889 * buffer.h (struct buffer.modtime): Now time_t, not int.
7890 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
7891 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
7892
ccd9a01a
PE
7893 Minor fixes for signed vs unsigned integers.
7894 * character.h (MAYBE_UNIFY_CHAR):
7895 * charset.c (maybe_unify_char):
7896 * keyboard.c (read_char, reorder_modifiers):
7897 XINT -> XFASTINT, since the integer must be nonnegative.
7898 * ftfont.c (ftfont_spec_pattern):
7899 * keymap.c (access_keymap, silly_event_symbol_error):
7900 XUINT -> XFASTINT, since the integer must be nonnegative.
7901 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
7902 since it makes no difference and we prefer signed.
7903 * keyboard.c (record_char): Use XUINT when all the neighbors do.
7904 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
7905 nonnegative.
7906
d6d100dd
SM
79072011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
7908
7909 * window.h (Fwindow_frame): Declare.
7910
2b6148e4
PE
79112011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7912
7913 * alloc.c: Simplify handling of large-request failures (Bug#8800).
7914 (SPARE_MEMORY): Always define.
7915 (LARGE_REQUEST): Remove.
7916 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
7917
f230ecc9
MR
79182011-06-06 Martin Rudalics <rudalics@gmx.at>
7919
727e958e
MR
7920 * lisp.h: Move EXFUNS for Fframe_root_window,
7921 Fframe_first_window and Fset_frame_selected_window to window.h.
7922
7923 * window.h: Move EXFUNS for Fframe_root_window,
7924 Fframe_first_window and Fset_frame_selected_window here from
7925 lisp.h.
7926
7927 * frame.c (Fwindow_frame, Fframe_first_window)
7928 (Fframe_root_window, Fframe_selected_window)
7929 (Fset_frame_selected_window): Move to window.c.
7930 (Factive_minibuffer_window): Move to minibuf.c.
7931 (Fother_visible_frames_p): New function.
7932
7933 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
7934
f230ecc9
MR
7935 * window.c (decode_window, decode_any_window): Move up in code.
7936 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
7937 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
7938 (Fwindow_buffer): Move up and rewrite doc-string.
7939 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
7940 (Fwindow_prev): New functions.
727e958e
MR
7941 (Fwindow_frame): Move here from frame.c. Accept any window as
7942 argument.
7943 (Fframe_root_window, Fframe_first_window)
7944 (Fframe_selected_window): Move here from frame.c. Accept frame
7945 or arbitrary window as argument. Update doc-strings.
7946 (Fminibuffer_window): Move up in code.
7947 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
7948 (Fset_frame_selected_window): Move here from frame.c.
7949 Marginal rewrite.
727e958e
MR
7950 (Fselected_window, select_window, Fselect_window): Move up in
7951 code. Minor doc-string fixes.
f230ecc9 7952
4d09bcf6
PE
79532011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7954
7955 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
7956 Do not assume that spare memory exists; that assumption is valid
7957 only if SYSTEM_MALLOC.
7958 (LARGE_REQUEST): New macro, so that the issue of large requests
7959 is separated from the issue of spare memory.
7960
810928a2
AS
79612011-06-05 Andreas Schwab <schwab@linux-m68k.org>
7962
172418ad
AS
7963 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
7964 format. (Bug#8806)
7965
43f862f7
AS
7966 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
7967
810928a2
AS
7968 * xfns.c (x_set_scroll_bar_default_width): Move declarations
7969 before statements.
7970
a059fe24
JD
79712011-06-05 Jan Djärv <jan.h.d@swipnet.se>
7972
7973 * gtkutil.c (xg_get_default_scrollbar_width): New function.
7974
7975 * gtkutil.h: Declare xg_get_default_scrollbar_width.
7976
7977 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
7978 min width by calling x_set_scroll_bar_default_width (Bug#8505).
7979
989bf368
JB
79802011-06-05 Juanma Barranquero <lekktu@gmail.com>
7981
7982 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
7983
4b80f674
CY
79842011-06-04 Chong Yidong <cyd@stupidchicken.com>
7985
7986 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
7987 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
7988 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
7989 New error handlers.
4b80f674
CY
7990 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
7991 Obey Vx_select_enable_clipboard_manager. Catch errors in
7992 x_clipboard_manager_save (Bug#8779).
7993 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 7994 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 7995
99a33b77 79962011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
7997
7998 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
7999
99a33b77 80002011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
8001
8002 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
8003 in the current matrix if keep_current_p is non-zero.
8004
8264569d
EZ
80052011-06-04 Eli Zaretskii <eliz@gnu.org>
8006
8007 * bidi.c (bidi_level_of_next_char): Fix last change.
8008
57f97249
EZ
80092011-06-03 Eli Zaretskii <eliz@gnu.org>
8010
fec2107c 8011 Support bidi reordering of text covered by display properties.
57f97249 8012
fec2107c
EZ
8013 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
8014 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
8015 (bidi_cache_search, bidi_cache_iterator_state)
8016 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
8017 (bidi_level_of_next_char, bidi_move_to_visually_next):
8018 Support character positions inside a run of characters covered by a
fec2107c
EZ
8019 display string.
8020 (bidi_paragraph_init, bidi_resolve_explicit_1)
8021 (bidi_level_of_next_char): Call bidi_fetch_char and
8022 bidi_fetch_char_advance instead of FETCH_CHAR and
8023 FETCH_CHAR_ADVANCE.
8024 (bidi_init_it): Initialize new members.
8025 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
8026 definitions.
8027 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
8028 instead of using explicit *_CHAR codes.
d6d100dd
SM
8029 (bidi_resolve_explicit, bidi_resolve_weak):
8030 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
8031 bidirectional text is supported only in multibyte buffers.
8032 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
8033 it to initialize the frame_window_p member of struct bidi_it.
8034 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
8035 (bidi_resolve_explicit, bidi_resolve_weak)
8036 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
8037 bidi_it->nchars is non-positive.
8038 (bidi_level_of_next_char): Don't try to lookup the cache for the
8039 next/previous character if nothing is cached there yet, or if we
8040 were just reseat()'ed to a new position.
c40e2fb2 8041
0e14fe90
EZ
8042 * xdisp.c (set_cursor_from_row): Set start and stop points
8043 according to the row's direction when priming the loop that looks
8044 for the glyph on which to display cursor.
8045 (single_display_spec_intangible_p): Function deleted.
8046 (display_prop_intangible_p): Reimplement to call
8047 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
8048 Accept 3 additional arguments needed by handle_display_spec.
8049 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
8050 values: lists, `(when COND...)' forms, etc.
8051 (single_display_spec_string_p): Support property values that are
8052 lists with the argument STRING its top-level element.
8053 (display_prop_string_p): Fix the condition for processing a
8054 property that is a list to be consistent with handle_display_spec.
fec2107c 8055 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
8056 last portion of handle_display_prop.
8057 (compute_display_string_pos): Accept additional argument
8058 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
8059 value of a `display' property is a "replacing spec".
8060 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
8061 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
8062 the display property, but just return a value indicating whether
8063 the display property will replace the characters it covers.
8064 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
8065 frame_window_p members of struct bidi_it.
d6d100dd
SM
8066 (compute_display_string_pos, compute_display_string_end):
8067 New functions.
fec2107c
EZ
8068 (push_it): Accept second argument POSITION, where pop_it should
8069 jump to continue iteration.
8070 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 8071
fec2107c
EZ
8072 * keyboard.c (adjust_point_for_property): Adjust the call to
8073 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
8074
8075 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
8076 (bidi_init_it): Update prototypes.
8077 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
8078 (compute_display_string_pos, compute_display_string_end):
8079 Declare prototypes.
fec2107c
EZ
8080 (struct bidi_it): New members nchars and disp_pos. ch_len is now
8081 EMACS_INT.
fc6f18ce 8082
40087514 80832011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 8084
57f53182
PE
8085 Malloc failure behavior now depends on size of allocation.
8086 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
8087 * lisp.h: Change signatures accordingly.
8088 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
8089 All callers changed. (Bug#8762)
8090
8091 * gnutls.c: Use Emacs's memory allocators.
8092 Without this change, the gnutls library would invoke malloc etc.
8093 directly, which causes problems on non-SYNC_INPUT hosts, and which
8094 runs afoul of improving memory_full behavior. (Bug#8761)
8095 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
8096 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
8097 xfree instead of the default malloc, realloc, free.
8098 (Fgnutls_boot): No need to check for memory allocation failure,
8099 since xmalloc does that for us.
8100
ac32cd99 8101 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
8102 * category.c (hash_get_category_set):
8103 * ccl.c (ccl_driver):
8104 * charset.c (Fdefine_charset_internal):
8105 * charset.h (struct charset.hash_index):
8106 * composite.c (get_composition_id, gstring_lookup_cache)
8107 (composition_gstring_put_cache):
8108 * composite.h (struct composition.hash_index):
8109 * dispextern.h (struct image.hash):
8110 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
8111 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
8112 (hashfn_equal, hashfn_user_defined, make_hash_table)
8113 (maybe_resize_hash_table, hash_lookup, hash_put)
8114 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
8115 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
8116 (Fsxhash, Fgethash, Fputhash, Fmaphash):
8117 * image.c (make_image, search_image_cache, lookup_image)
8118 (xpm_put_color_table_h):
8119 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 8120 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 8121 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 8122 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
8123 * alloc.c (allocate_vectorlike):
8124 Check for overflow in vector size calculations.
8125 * ccl.c (ccl_driver):
8126 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
8127 * fns.c, image.c: Remove unnecessary static decls that would otherwise
8128 need to be updated by these changes.
40087514
PE
8129 * fns.c (make_hash_table, maybe_resize_hash_table):
8130 Check for integer overflow with large hash tables.
0de4bb68
PE
8131 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
8132 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
8133 (SXHASH_REDUCE): New macro.
8134 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
8135 Use it instead of discarding useful hash info with large hash values.
8136 (sxhash_float): New function.
8137 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
8138 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
8139 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
8140 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
8141 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
8142 Adjust signatures to match updated version of code.
8143 (consing_since_gc): Now EMACS_INT, since a single hash table can
8144 use more than INT_MAX bytes.
8145
698d32e2
DN
81462011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
8147
8148 Make it possible to build with GCC-4.6+ -O2 -flto.
8149
8150 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
8151
fd6fa53f
SM
81522011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
8153
8154 * minibuf.c (get_minibuffer, read_minibuf_unwind):
8155 Call minibuffer-inactive-mode.
8156
864db017
JB
81572011-05-31 Juanma Barranquero <lekktu@gmail.com>
8158
8159 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
8160 Update dependencies.
8161
2ad0baf4
DN
81622011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8163
8164 * data.c (init_data): Remove code for UTS, this system is not
8165 supported anymore.
8166
4fcc2638
DN
81672011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8168
8169 Don't force ./temacs to start in terminal mode.
8170
8171 * frame.c (make_initial_frame): Initialize faces in all cases, not
8172 only when CANNOT_DUMP is defined.
8173 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
8174
c56e0fd5
DN
81752011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8176
8177 * dispnew.c (add_window_display_history): Use const for the string
8178 pointer. Remove declaration, not needed.
8179
333d54da 81802011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 8181
55d4c1b2 8182 Use 'inline', not 'INLINE'.
333d54da 8183 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
8184 * alloc.c, fontset.c (INLINE): Remove.
8185 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
8186 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
8187 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
8188 * gmalloc.c (register_heapinfo): Use inline unconditionally.
8189 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
8190
738db178
DN
81912011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8192
8193 Make it possible to run ./temacs.
8194
8195 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
8196 syms_of_callproc does the same thing. Remove test for
8197 "initialized", do it in the caller.
8198 * emacs.c (main): Avoid calling set_initial_environment when dumping.
8199
620c53a6
SM
82002011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
8201
8202 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
8203 (read_minibuf): Use get_minibuffer.
8204 (syms_of_minibuf): Use DEFSYM.
8205 (Qmetadata): New var.
8206 * data.c (Qbuffer): Don't make it static.
8207 (syms_of_data): Use DEFSYM.
8208
e003a292
PE
82092011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8210
8211 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
8212 (CCL_CODE_MIN): New macro.
8213
ed008a6d
PE
82142011-05-30 Paul Eggert <eggert@cs.ucla.edu>
8215
3687c2ef
PE
8216 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
8217
ed008a6d
PE
8218 * eval.c (Qdebug): Now static.
8219 * lisp.h (Qdebug): Remove decl. This reverts a part of the
8220 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
8221 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
8222
d66c4c7c
CY
82232011-05-29 Chong Yidong <cyd@stupidchicken.com>
8224
8225 * image.c: Various fixes to ImageMagick code comments.
8226 (Fimagemagick_types): Doc fix.
8227
5fbc2025
PE
82282011-05-29 Paul Eggert <eggert@cs.ucla.edu>
8229
0196f88a
PE
8230 Minor fixes prompted by GCC 4.6.0 warnings.
8231
8232 * xselect.c (converted_selections, conversion_fail_tag): Now static.
8233
5fbc2025
PE
8234 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
8235 (x_clipboard_manager_save_all): Move extern decl to ...
8236 * xterm.h: ... here, so that it can be checked for consistency.
8237
1dd3c2d9
CY
82382011-05-29 Chong Yidong <cyd@stupidchicken.com>
8239
8240 * xselect.c (x_clipboard_manager_save_frame)
8241 (x_clipboard_manager_save_all): New functions.
8242 (Fx_clipboard_manager_save): Lisp function deleted.
8243
8244 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
8245 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
8246
8247 * xterm.h: Update prototype.
8248
5ba6571d
WX
82492011-05-28 William Xu <william.xwl@gmail.com>
8250
8251 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
8252 exiting (Bug#8239).
8253
3eaff834
JM
82542011-05-28 Jim Meyering <meyering@redhat.com>
8255
e1900994 8256 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
8257 * fns.c (to_uchar): Define.
8258 (crypto_hash_function): Use it to convert some newly-signed
8259 variables to unsigned, to avoid sign-extension bugs. For example,
8260 without this change, (md5 "truc") would evaluate to
8261 45723a2aff78ff4fff7fff1114760e62 rather than the expected
8262 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 8263 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 8264
0f6990a7
PE
82652011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8266
8267 Integer overflow fixes.
c8a9ca5a 8268
08686060
PE
8269 * dbusbind.c: Serial number integer overflow fixes.
8270 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
8271 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
8272 to hold a serial number that is too large for a fixnum.
8273 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8274 Check for serial numbers out of range. Decode any serial number
59568bf0 8275 that was so large that it became a float. (Bug#8722)
08686060 8276
2d1fc3c7
PE
8277 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
8278 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8279 Use XFASTINT rather than XUINT when numbers are nonnegative.
8280 (xd_append_arg, Fdbus_method_return_internal):
8281 (Fdbus_method_error_internal): Likewise. Also, for unsigned
8282 arguments, check that Lisp number is nonnegative, rather than
59568bf0 8283 silently wrapping negative numbers around. (Bug#8722)
30217ff0 8284 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 8285 (Bug#8722)
2d1fc3c7 8286
c8a9ca5a
PE
8287 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
8288
519e1d69
PE
8289 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
8290
6df6ae42 8291 ccl: Add integer overflow checks.
30569699
PE
8292 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
8293 (IN_INT_RANGE): New macros.
8294 (ccl_driver): Use them to check for integer overflow when
8295 decoding a CCL program. Many of the new checks are whether XINT (x)
8296 fits in int; it doesn't always, on 64-bit hosts. The new version
8297 doesn't catch all possible integer overflows, but it's an
847044ea 8298 improvement. (Bug#8719)
30569699 8299
c11285dc
PE
8300 * alloc.c (make_event_array): Use XINT, not XUINT.
8301 There's no need for unsigned here.
8302
fdccd48e
PE
8303 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
8304 This follows up to the 2011-05-06 change that substituted uintptr_t
8305 for EMACS_INT. This case wasn't caught back then.
8306
37910ab2
PE
8307 Rework Fformat to avoid integer overflow issues.
8308 * editfns.c: Include <float.h> unconditionally, as it's everywhere
8309 now (part of C89). Include <verify.h>.
8310 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
8311 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
8312 (Fformat): Avoid the prepass trying to compute sizes; it was only
8313 approximate and thus did not catch overflow reliably. Instead, walk
8314 through the format just once, formatting and computing sizes as we go,
8315 checking for integer overflow at every step, and allocating a larger
8316 buffer as needed. Keep track separately whether the format is
8317 multibyte. Keep only the most-recently calculated precision, rather
8318 than them all. Record whether each argument has been converted to
8319 string. Use EMACS_INT, not int, for byte and char and arg counts.
8320 Support field widths and precisions larger than INT_MAX. Avoid
8321 sprintf's undefined behavior with conversion specifications such as %#d
8322 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
8323 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
8324 formatting out-of-range floating point numbers with int
9173deec 8325 formats. (Bug#8668)
37910ab2 8326
2e6578fb
PE
8327 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
8328
0ae6bdee
PE
8329 * data.c: Avoid integer truncation in expressions involving floats.
8330 * data.c: Include <intprops.h>.
8331 (arith_driver): When there's an integer overflow in an expression
8332 involving floating point, convert the integers to floating point
8333 so that the resulting value does not suffer from catastrophic
8334 integer truncation. For example, on a 64-bit host (* 4
8335 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
8336 Do not rely on undefined behavior after integer overflow.
8337
de883a70
PE
8338 merge count_size_as_multibyte, parse_str_to_multibyte
8339 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 8340 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
8341 Check for integer overflow.
8342 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
8343 since it's now a duplicate of the other. This is more of
8344 a character than a buffer op, so better that it's in character.c.
8345 * fns.c, print.c: Adjust to above changes.
8346
2ff916cb
PE
83472011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
8348
8349 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
8350
f1b54466
PE
83512011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8352
fb1ac845
PE
8353 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8354 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
8355 (x_clipboard_manager_save): Now static.
8356 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
8357
f1b54466
PE
8358 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8359 (crypto_hash_function): Now static.
8360 Fix pointer signedness problems. Avoid unnecessary initializations.
8361
a9f737ee
CY
83622011-05-27 Chong Yidong <cyd@stupidchicken.com>
8363
8364 * termhooks.h (Vselection_alist): Make it terminal-local.
8365
8366 * terminal.c (create_terminal): Initialize it.
8367
8368 * xselect.c: Support for clipboard managers.
8369 (Vselection_alist): Move to termhooks.h as terminal-local var.
8370 (LOCAL_SELECTION): New macro.
8371 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
8372 (symbol_to_x_atom): Remove gratuitous arg.
8373 (x_handle_selection_request, lisp_data_to_selection_data)
8374 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
8375 (x_own_selection, x_get_local_selection, x_convert_selection):
8376 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
8377 (some_frame_on_display): Delete unused function.
8378 (Fx_own_selection_internal, Fx_get_selection_internal)
8379 (Fx_disown_selection_internal, Fx_selection_owner_p)
8380 (Fx_selection_exists_p): New optional frame arg.
8381 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
8382 (x_handle_selection_clear): Don't treat other terminals with the
8383 same keyboard specially. Use the terminal-local Vselection_alist.
8384 (x_clear_frame_selections): Use Frun_hook_with_args.
8385
8386 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
8387
8388 * xterm.h: Add support for those atoms.
8389
e067f0c1
CY
83902011-05-26 Chong Yidong <cyd@stupidchicken.com>
8391
8392 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
8393 (converted_selections, conversion_fail_tag): New global variables.
8394 (x_selection_request_lisp_error): Free the above.
8395 (x_get_local_selection): Remove unnecessary code.
8396 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
8397 of converted selections stored in converted_selections.
8398 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
8399 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
8400 (x_convert_selection): New function.
8401 (x_handle_selection_event): Simplify.
8402 (x_get_foreign_selection): Don't ignore incoming requests while
8403 waiting for an answer; this will fail when we implement
8404 SAVE_TARGETS, and seems unnecessary anyway.
8405 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
8406 (Vx_sent_selection_functions): Doc fix.
8407
0f4aebc0
LL
84082011-05-26 Leo Liu <sdl.web@gmail.com>
8409
8410 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
8411
e61124cd
YM
84122011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8413
8414 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
8415
8416 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
8417 for fringe update if it has periodic bitmap.
ac389d0c 8418 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
8419 and fringe_bitmap_periodic_p.
8420
8421 * fringe.c (get_fringe_bitmap_data): New function.
8422 (draw_fringe_bitmap_1, update_window_fringes): Use it.
8423 (update_window_fringes): Record periodicity of fringe bitmap in glyph
8424 row. Mark glyph row for fringe update if periodicity changed.
8425
8426 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
8427 for fringe update unless it has periodic bitmap.
8428
f16d9837
KH
84292011-05-25 Kenichi Handa <handa@m17n.org>
8430
8431 * xdisp.c (get_next_display_element): Set correct it->face_id for
8432 a static composition.
8433
e1b90ef6
LL
84342011-05-24 Leo Liu <sdl.web@gmail.com>
8435
8436 * deps.mk (fns.o):
8437 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
8438
8439 * fns.c (crypto_hash_function, Fsha1): New function.
8440 (Fmd5): Use crypto_hash_function.
8441 (syms_of_fns): Add Ssha1.
8442
7400048f
PE
84432011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8444
8445 * gnutls.c: Remove unused macros.
8446 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
8447 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
8448 Remove macros that are defined and never used.
8449 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
8450
abb71cf4
CY
84512011-05-22 Chong Yidong <cyd@stupidchicken.com>
8452
8453 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
8454 (Fx_get_selection_internal): Minor cleanup.
8455 (Fx_own_selection_internal): Rename arguments for consistency with
8456 select.el.
8457
6307db39
PE
84582011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8459
8460 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
8461
f3d4e0a4
CY
84622011-05-22 Chong Yidong <cyd@stupidchicken.com>
8463
8464 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
8465
4d8ade89
YM
84662011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8467
8468 * dispnew.c (scrolling_window): Don't exclude the case that the
8469 last enabled row in the desired matrix touches the bottom boundary.
8470
32078c8d
GM
84712011-05-21 Glenn Morris <rgm@gnu.org>
8472
8473 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
8474 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
8475 and add some more files.
32078c8d 8476
7285dc67
EZ
84772011-05-20 Eli Zaretskii <eliz@gnu.org>
8478
8479 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
8480 report_file_error introduced by the change from 2011-05-07.
8481
89d1bd22
PE
84822011-05-20 Paul Eggert <eggert@cs.ucla.edu>
8483
8484 * systime.h (Time): Define only if emacs is defined.
8485 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
8486 where the include path doesn't have X11/X.h by default. See
8487 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
8488
cd394be1 84892011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
8490
8491 * composite.c (find_automatic_composition): Fix previous change.
8492
b9704ad9
GM
84932011-05-20 Glenn Morris <rgm@gnu.org>
8494
8495 * lisp.mk: New file, split from Makefile.in.
8496 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
8497 (shortlisp): Remove.
8498 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
8499
4a720484
GM
85002011-05-19 Glenn Morris <rgm@gnu.org>
8501
8502 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
8503 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
8504 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
8505 (lisp): Set the order to that of loadup.el.
8506 (shortlisp): Make it a copy of $lisp.
8507 (SOME_MACHINE_LISP): Remove.
8508 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
8509 Use just $shortlisp, not $SOME_MACHINE_LISP too.
8510
a28d4396
KH
85112011-05-18 Kenichi Handa <handa@m17n.org>
8512
8513 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
8514 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
8515 (find_automatic_composition): Mostly rewrite for efficiency.
8516
a2b1fa8e
JB
85172011-05-18 Juanma Barranquero <lekktu@gmail.com>
8518
8519 * makefile.w32-in: Update dependencies.
8520
8e1f5610
CS
85212011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
8522
8523 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 8524 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 8525
7025ee00 85262011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 8527
cdfa6eab
PE
8528 Fix some integer overflow issues, such as string length overflow.
8529
06d6db33
PE
8530 * insdel.c (count_size_as_multibyte): Check for string overflow.
8531
2b4560a8
PE
8532 * character.c (lisp_string_width): Check for string overflow.
8533 Use EMACS_INT, not int, for string indexes and lengths; in
8534 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
8535 the resulting string length overflows an EMACS_INT; instead,
8536 report a string overflow if no precision given. When checking for
8537 precision exhaustion, use a check that cannot possibly have
8538 integer overflow. (Bug#8675)
8539 * character.h (lisp_string_width): Adjust to new signature.
8540
cb93f9be
PE
8541 * alloc.c (string_overflow): New function.
8542 (Fmake_string): Use it. This doesn't change behavior, but saves
8543 a few bytes and will simplify future changes.
8544 * character.c (string_escape_byte8): Likewise.
8545 * lisp.h (string_overflow): New decl.
8546
1a1f3366
PE
8547 Fixups, following up to the user-interface timestamp change.
8548 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
8549 for UI timestamps, instead of unsigned long.
9fbd6841
PE
8550 * msdos.c (mouse_get_pos): Likewise.
8551 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
8552 * w32gui.h (Time): Define by including "systime.h" rather than by
8553 declaring it ourselves. (Bug#8664)
8554
d4e3e4d3
PE
8555 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
8556 * image.c (clear_image_cache): Likewise.
8557
f6a24d19
PE
8558 * term.c (term_mouse_position): Don't assume time_t wraparound.
8559
08dc5ae6
PE
8560 Be more systematic about user-interface timestamps.
8561 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
8562 and sometimes 'EMACS_UINT', to represent these timestamps.
8563 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
8564 This makes the code easier to follow, and makes it easier to catch
8565 integer overflow bugs such as Bug#8664.
8566 * frame.c (Fmouse_position, Fmouse_pixel_position):
8567 Use Time, not unsigned long, for user-interface timestamps.
8568 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
8569 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
8570 * keyboard.h (last_event_timestamp): Likewise.
8571 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
8572 * menu.h (xmenu_show): Likewise.
8573 * term.c (term_mouse_position): Likewise.
8574 * termhooks.h (struct input_event.timestamp): Likewise.
8575 (struct terminal.mouse_position_hook): Likewise.
8576 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
8577 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
8578 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
8579 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
8580 what it was before.
8581 * menu.h, termhooks.h: Include "systime.h", for Time.
8582
8e55734a
PE
8583 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
8584 Don't assume that the difference between two unsigned long values
8585 can fit into an integer. At this point, we know button_down_time
8586 <= event->timestamp, so the difference must be nonnegative, so
8587 there's no need to cast the result if double-click-time is
8588 nonnegative, as it should be; check that it's nonnegative, just in
8589 case. This bug is triggered when events are more than 2**31 ms
86db42d2 8590 apart (about 25 days). (Bug#8664)
8e55734a 8591
841f1b75 8592 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 8593 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 8594
3e26f69c
PE
8595 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
8596 that always fit in int. Use a sentinel instead of a counter, to
8597 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
8598 * frame.h (struct frame): Use int for menu_bar_items_used
8599 instead of EMACS_INT, since it always fits in int.
3e26f69c 8600
5cc152c0
PE
8601 * menu.c (grow_menu_items): Check for int overflow.
8602
d89eb65e
PE
8603 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
8604
5235bd3e
PE
8605 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
8606 Before, the code was not consistent. These values cannot exceed
8607 2**31 - 1 so there's no need to make them unsigned.
8608 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
8609 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
8610 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
8611 as modifiers.
8612 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
8613
bc827e23
PE
8614 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
8615 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
8616 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
8617 presumably because the widths might not match.
8618
78eb494e
PE
8619 * window.c (size_window): Avoid needless test at loop start.
8620
04f2d78b
CB
86212011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
8622
8623 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
8624
d2fc7e3d 86252011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
8626
8627 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
8628
d2fc7e3d 86292011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
8630
8631 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
8632 `width' to `bar_area_x' and `bar_area_width', respectively.
8633 (x_scroll_run): Take account of fringe background extension.
8634
04f2d78b
CB
8635 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
8636 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
8637 `bar_area_width', respectively.
8638 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
8639 background extension.
8640
79b70037
GM
86412011-05-10 Jim Meyering <meyering@redhat.com>
8642
8643 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
8644
2f142cc5
JB
86452011-05-10 Juanma Barranquero <lekktu@gmail.com>
8646
8647 * image.c (Finit_image_library): Return t for built-in image types,
8648 like pbm and xbm. (Bug#8640)
8649
57679c86
AS
86502011-05-09 Andreas Schwab <schwab@linux-m68k.org>
8651
8652 * w32menu.c (set_frame_menubar): Fix submenu allocation.
8653
888c9e86
EZ
86542011-05-07 Eli Zaretskii <eliz@gnu.org>
8655
b0512a1d
EZ
8656 * w32console.c (Fset_screen_color): Doc fix.
8657 (Fget_screen_color): New function.
8658 (syms_of_ntterm): Defsubr it.
8659
7285dc67
EZ
8660 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
8661 unlink the temporary file if Fcall_process didn't create it in the
8662 first place.
8663 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
8664 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
8665 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
8666 cue to call_process_cleanup not to close that handle.
8667
4d3fcc8e
BK
86682011-05-07 Ben Key <bkey76@gmail.com>
8669
8670 * makefile.w32-in: The bootstrap-temacs rule now makes use of
8671 one of two shell specific rules, either bootstrap-temacs-CMD or
8672 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
8673 to the previous implementation of the bootstrap-temacs rule.
8674 The bootstrap-temacs-CMD rule is similar to the previous
8675 implementation of the bootstrap-temacs rule except that it
8676 makes use of the ESC_CFLAGS variable instead of the CFLAGS
8677 variable.
8678
8679 These changes, along with some changes to nt/configure.bat,
8680 nt/gmake.defs, and nt/nmake.defs, are required to extend my
8681 earlier fix to add support for --cflags and --ldflags options
8682 that include quotes so that it works whether make uses cmd or
8683 sh as the shell.
8684
b4289b64
MA
86852011-05-06 Michael Albinus <michael.albinus@gmx.de>
8686
8687 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
8688 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
8689 is a constant.
8690 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
8691 a string. Handle both cases.
8692 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
8693 (Fdbus_register_method): Use Qinvalid_function.
8694
af4c0e28
JB
86952011-05-06 Juanma Barranquero <lekktu@gmail.com>
8696
8697 * makefile.w32-in: Update dependencies.
8698 (LISP_H): Add inttypes.h and stdin.h.
8699 (PROCESS_H): Add unistd.h.
8700
c51453d9
EZ
87012011-05-06 Eli Zaretskii <eliz@gnu.org>
8702
8703 * lread.c: Include limits.h (fixes the MS-Windows build broken by
8704 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
8705
8ff0ac3c 87062011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 8707
4c4b566b
PE
8708 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
8709
aab2b9b5
PE
8710 * term.c (vfatal): Remove stray call to va_end.
8711 It's not needed and the C Standard doesn't allow it here anyway.
8712
c378da0b
PE
8713 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
8714 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
8715
288b08c7
PE
8716 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
8717 bytes.
8718
e3601888
PE
8719 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
8720
db6c0e74
PE
8721 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8722
dd5963ea
PE
8723 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
8724
88c9450f
PE
8725 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
8726
2f9442b8
PE
8727 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
8728
c032b5f8
PE
8729 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
8730 * charset.c (Fdefine_charset_internal): Don't initialize
8731 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 8732 32-bit int (Bug#8600).
a108c10b
PE
8733
8734 * lread.c (read_integer): Be more consistent with string-to-number.
8735 Use string_to_number to do the actual conversion; this avoids
8736 rounding errors and fixes some other screwups. Without this fix,
8737 for example, #x1fffffffffffffff was misread as -2305843009213693952.
8738 (digit_to_number): Move earlier, for benefit of read_integer.
8739 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 8740 not a digit in any supported base. (Bug#8602)
a108c10b 8741
ad5f9eea
PE
8742 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
8743
aec1708a
PE
8744 * dispnew.c (scrolling_window): Return 1 if we scrolled,
8745 to match comment at start of function. This also removes a
8746 GCC warning about overflow in a 32+64-bit port.
8747
47be4ab5
PE
8748 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
8749
371cac43
PE
8750 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
8751 Reported by Stefan Monnier in
8752 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
8753 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8754 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 8755
d01a7826
PE
8756 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
8757 (EMACS_UINTPTR): Likewise, with uintptr_t.
8758
7fd47d5c
PE
8759 * lisp.h: Prefer 64-bit EMACS_INT if available.
8760 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
8761 on 32-bit hosts that have 64-bit int, so that they can access
8762 large files.
122b0c86
PE
8763 However, temporarily disable this change unless the temporary
8764 symbol WIDE_EMACS_INT is defined.
7fd47d5c 8765
8727937b
PE
8766 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
8767
8ac068ac
PE
8768 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
8769 This removes an assumption that EMACS_INT and long are the same
8770 width as pointers. The assumption is true for Emacs porting targets
8771 now, but we want to make other targets possible.
8772 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
8773 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
8774 In the rest of the code, change types of integers that hold casted
8775 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
8776 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
8777 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
8778 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
8779 No need to cast type when ORing.
8780 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
8781 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
8782 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
8783 assume EMACS_INT is the same width as char *.
8784 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
8785 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
8786 Remove no-longer-needed casts.
8787 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
8788 (xg_tool_bar_help_callback, xg_make_tool_item):
8789 Use EMACS_INTPTR to hold an integer
8790 that will be cast to void *; this can avoid a GCC warning
8791 if EMACS_INT is not the same width as void *.
8792 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
8793 * xdisp.c (display_echo_area_1, resize_mini_window_1):
8794 (current_message_1, set_message_1):
8795 Use a local to convert to proper width without a cast.
8796 * xmenu.c (dialog_selection_callback): Likewise.
8797
ede49d71
PE
8798 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
8799 Also, don't assume VALBITS / RAND_BITS is less than 5,
8800 and don't rely on undefined behavior when shifting a 1 left into
8801 the sign bit.
8802 * lisp.h (get_random): Change signature to match.
8803
2f30ecd0
PE
8804 * lread.c (hash_string): Use size_t, not int, for hash computation.
8805 Normally we prefer signed values; but hashing is special, because
8806 it's better to use unsigned division on hash table sizes so that
8807 the remainder is nonnegative. Also, size_t is the natural width
8808 for hashing into memory. The previous code used 'int', which doesn't
8809 retain enough info to hash well into very large tables.
8810 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
8811
2a866e7b
PE
8812 * dbusbind.c: Don't possibly lose pointer info when converting.
8813 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8814 Use XPNTR rather than XHASH, so that the high-order bits of
8815 the pointer aren't lost when converting through void *.
8816
51639eac
PE
8817 * eval.c (Fautoload): Don't double-shift a pointer.
8818
92394119
PE
8819 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
8820
dbdb9a7c
JB
88212011-05-06 Juanma Barranquero <lekktu@gmail.com>
8822
8823 * gnutls.c (DEF_GNUTLS_FN):
8824 * image.c (DEF_IMGLIB_FN): Make function pointers static.
8825
db7a0b4f
AS
88262011-05-05 Andreas Schwab <schwab@linux-m68k.org>
8827
8828 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
8829 marker. (Bug#8610)
8830
cd394be1 88312011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
8832
8833 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
8834 New version that can reserve upto 2GB of heap space.
8835
f7ff1b0f 88362011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
8837
8838 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
8839
639c109b
TZ
88402011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
8841
8842 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
8843 `gnutls_certificate_set_x509_key_file'.
8844
d2127135
JB
88452011-05-05 Juanma Barranquero <lekktu@gmail.com>
8846
8847 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
8848 Update dependencies.
8849
e968f4f3
JB
88502011-05-04 Juanma Barranquero <lekktu@gmail.com>
8851
8852 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
8853 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
8854 Remove unused parameter `fildes'.
8855 * process.c (read_process_output, send_process): Don't pass it.
8856
84d358f0
JB
88572011-05-04 Juanma Barranquero <lekktu@gmail.com>
8858
8859 Fix previous change: the library cache is defined in w32.c.
8860 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
8861 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
8862
0898ca10
JB
88632011-05-04 Juanma Barranquero <lekktu@gmail.com>
8864
8865 Implement dynamic loading of GnuTLS on Windows.
8866
8867 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
8868 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
8869 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8870 Declare.
8871
8872 * gnutls.c (Qgnutls_dll): Define.
8873 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
8874 (gnutls_*): Declare function pointers.
8875 (init_gnutls_functions): New function to initialize function pointers.
8876 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
8877 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
8878 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8879 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
8880 (emacs_gnutls_write, emacs_gnutls_read)
8881 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
8882 (Fgnutls_available_p): New function.
8883 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
8884 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
8885 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
8886
8887 * image.c: Include w32.h.
8888 (Vimage_type_cache): Delete.
8889 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
8890 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
8891 (w32_delayed_load): Move to w32.c.
8892
8893 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
8894
8895 * w32.c (QCloaded_from, Vlibrary_cache): Define.
8896 (w32_delayed_load): Move from image.c. When loading a library, record
8897 its filename in the :loaded-from property of the library id.
8898 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
8899 Initialize and staticpro them.
8900 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
8901
8902 * process.c: Include lisp.h before w32.h, not after.
8903 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
8904 instead of gnutls_record_check_pending.
8905
8906 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
8907
ff4de4aa
TZ
89082011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
8909
8910 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
8911 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
8912 as passed in.
8913
abe95abb
JD
89142011-05-03 Jan Djärv <jan.h.d@swipnet.se>
8915
8916 * xterm.c (x_set_frame_alpha): Do not set property on anything
8917 else than FRAME_X_OUTER_WINDOW (Bug#8608).
8918
e16e55d4
JB
89192011-05-02 Juanma Barranquero <lekktu@gmail.com>
8920
8921 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
8922
bafcf6a5
JB
89232011-05-02 Juanma Barranquero <lekktu@gmail.com>
8924
8925 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
8926 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
8927 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
8928 (gnutls_global_initialized, Qgnutls_bootprop_priority)
8929 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
8930 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
8931 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
8932 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
8933 (Qgnutls_bootprop_callbacks_verify): Make static.
8934
e7a6747f
AS
89352011-05-01 Andreas Schwab <schwab@linux-m68k.org>
8936
19ed11ba
AS
8937 * callproc.c: Indentation fixup.
8938
e7a6747f 8939 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
8940 (wait_for_termination, interruptible_wait_for_termination):
8941 Move after wait_for_termination_1.
e7a6747f 8942
1ef14cb4
LMI
89432011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
8944
8945 * sysdep.c (interruptible_wait_for_termination): New function
8946 which is like wait_for_termination, but allows keyboard
8947 interruptions.
8948
8949 * callproc.c (Fcall_process): Add (:file "file") as an option for
8950 the STDOUT buffer.
8951 (Fcall_process_region): Ditto.
8952
330d880c
EZ
89532011-04-30 Eli Zaretskii <eliz@gnu.org>
8954
8db90b73
EZ
8955 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
8956 rather than `XVECTOR (FOO)->size'.
8957
330d880c
EZ
8958 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
8959 inttypes.h, as a gnulib replacement is used if it not available in
8960 system headers.
8961
15cbd324
EZ
89622011-04-21 Eli Zaretskii <eliz@gnu.org>
8963
8964 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
8965 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
8966 of MOST_POSITIVE_FIXNUM. (Bug#8528)
8967
8968 * coding.c (coding_alloc_by_realloc): Error out if destination
8969 will grow beyond MOST_POSITIVE_FIXNUM.
8970 (decode_coding_emacs_mule): Abort if there isn't enough place in
8971 charbuf for the composition carryover bytes. Reserve an extra
8972 space for up to 2 characters produced in a loop.
8973 (decode_coding_iso_2022): Abort if there isn't enough place in
8974 charbuf for the composition carryover bytes.
8975
89762011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 8977
ae940cca
EZ
8978 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
8979 aborting when %lld or %lll format is passed.
8980 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
8981 %llo or %llx format is passed. (Bug#8545)
8982
03ab8921
EZ
8983 * window.c (window_scroll_line_based): Use a marker instead of
8984 simple variables to record original value of point. (Bug#7952)
8985
afda1437
EZ
8986 * doprnt.c (doprnt): Fix the case where a multibyte sequence
8987 produced by %s or %c overflows available buffer space. (Bug#8545)
8988
f76dee0c
PE
89892011-04-28 Paul Eggert <eggert@cs.ucla.edu>
8990
8991 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 8992 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 8993
fdc5744d
JB
89942011-04-28 Juanma Barranquero <lekktu@gmail.com>
8995
8996 * w32.c (init_environment): Warn about defaulting HOME to C:\.
8997
638f053a
JB
89982011-04-28 Juanma Barranquero <lekktu@gmail.com>
8999
9000 * keyboard.c (Qdelayed_warnings_hook): Define.
9001 (command_loop_1): Run `delayed-warnings-hook'
9002 if Vdelayed_warnings_list is non-nil.
9003 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
9004 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
9005
d178f871
EZ
90062011-04-28 Eli Zaretskii <eliz@gnu.org>
9007
9008 * doprnt.c (doprnt): Don't return value smaller than the buffer
9009 size if the message was truncated. (Bug#8545).
9010
b124fd93
JB
90112011-04-28 Juanma Barranquero <lekktu@gmail.com>
9012
9013 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
9014 (Fx_window_property): #if-0 the whole functions, not just the bodies.
9015
e810457d
PE
90162011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9017
9018 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
9019
ea51cceb
JB
90202011-04-27 Juanma Barranquero <lekktu@gmail.com>
9021
9022 * makefile.w32-in: Update dependencies.
9023
94dcfacf
EZ
90242011-04-27 Eli Zaretskii <eliz@gnu.org>
9025
9026 Improve `doprnt' and its usage. (Bug#8545)
9027 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
9028 `format_end'. Remove support for %l as a conversion specifier.
9029 Don't use xrealloc. Improve diagnostics when the %l size modifier
9030 is used. Update the commentary.
9031
9032 * eval.c (verror): Simplify calculation of size_t.
9033
9034 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
9035 messages.
9036
f61f41d7
PE
90372011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
9038
9039 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
9040 change.
9041
96fb4434
PE
90422011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9043
9044 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
9045 This makes this file independent of the recent pseudovector change.
9046
671875da 90472011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 9048
69e9b5a3
PE
9049 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
9050
b5f869a7 9051 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 9052 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 9053 Remove unused local.
c8926152 9054 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 9055
841a1577 9056 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
9057 GCC 4.6.0 optimizes based on type-based alias analysis.
9058 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
9059 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
9060 != &v->size, and therefore "v->size = 1; b->size = 2; return
9061 v->size;" must therefore return 1. This assumption is incorrect
9062 for Emacs, since it type-puns struct Lisp_Vector * with many other
9063 types. To fix this problem, this patch adds a new type struct
f904488f 9064 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
9065 and pseudovectors, and helps optimizing compilers not get fooled
9066 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
9067 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
9068 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
9069 the size member.
eab3844f
PE
9070 (XSETPVECTYPE): Rewrite in terms of new macro.
9071 (XSETPVECTYPESIZE): New macro, specifying both type and size.
9072 This is a bit clearer, and further avoids the possibility of
9073 undesirable aliasing.
9074 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 9075 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
9076 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
9077 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
9078 (ASIZE): Now uses header.size rather than size.
9079 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
9080 to avoid the hassle of writing XVECTOR (foo)->header.size.
9081 (struct vectorlike_header): New type.
eab3844f
PE
9082 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
9083 object, to help avoid aliasing.
9084 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
9085 (SUBRP): Likewise, since Lisp_Subr is a special case.
9086 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
9087 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
9088 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 9089 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
9090 changed to be "header.size" and "header.next".
9091 * buffer.h (struct buffer): Likewise.
9092 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
9093 * frame.h (struct frame): Likewise.
9094 * process.h (struct Lisp_Process): Likewise.
9095 * termhooks.h (struct terminal): Likewise.
9096 * window.c (struct save_window_data, struct saved_window): Likewise.
9097 * window.h (struct window): Likewise.
9098 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
9099 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
9100 * buffer.c (init_buffer_once): Likewise.
9101 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
9102 special case.
9103 * process.c (Fformat_network_address): Use local var for size,
9104 for brevity.
9105
0df1eac5
PE
9106 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
9107
847ab9d1 9108 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
9109 * data.c (atof): Remove decl; no longer used or needed.
9110 (digit_to_number): Move to lread.c.
9111 (Fstring_to_number): Use new string_to_number function, to be
9112 consistent with how the Lisp reader treats infinities and NaNs.
9113 Do not assume that floating-point numbers represent EMACS_INT
9114 without losing information; this is not true on most 64-bit hosts.
9115 Avoid double-rounding errors, by insisting on integers when
9116 parsing non-base-10 numbers, as the documentation specifies.
9117 * lisp.h (string_to_number): New decl, replacing ...
9118 (isfloat_string): Remove.
bc0a5c13 9119 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 9120 (read1): Do not accept +. and -. as integers; this
452f4150
PE
9121 appears to have been a coding error. Similarly, do not accept
9122 strings like +-1e0 as floating point numbers. Do not report
9123 overflow for integer overflows unless the base is not 10 which
9124 means we have no simple and reliable way to continue.
9125 Break out the floating-point parsing into a new
9126 function string_to_number, so that Fstring_to_number parses
9127 floating point numbers consistently with the Lisp reader.
04f2d78b 9128 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
9129 (E_CHAR, EXP_INT): Remove, replacing with ...
9130 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
9131 (string_to_number): New function, replacing isfloat_string.
9132 This function checks for valid syntax and produces the resulting
9133 Lisp float number too. Rework it so that string-to-number
bc0a5c13 9134 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
9135 so that overflow for non-base-10 numbers is reported only when
9136 there's no portable and simple way to convert to floating point.
452f4150 9137
67769ffc
PE
9138 * textprop.c (set_text_properties_1): Rewrite for clarity,
9139 and to avoid GCC warning about integer overflow.
9140
c20db43f
PE
9141 * intervals.h (struct interval): Use EMACS_INT for members
9142 where EMACS_UINT might cause problems. See
9143 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
9144 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
9145 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
9146 All uses changed.
37aa2f85
PE
9147 (offset_intervals): Tell GCC not to worry about length overflow
9148 when negating a negative length.
c20db43f 9149
2538aa2f
PE
9150 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
9151 (overrun_check_free): Likewise.
9152
f2d3008d
PE
9153 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
9154 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
9155 word size.
9156
ec8df744
PE
9157 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9158 (gnutls_make_error): Rename local to avoid shadowing.
9159 (gnutls_emacs_global_deinit): ifdef out; not used.
9160 (Fgnutls_boot): Use const for pointer to readonly storage.
9161 Comment out unused local. Fix pointer signedness problems.
9162
640ee02d
PE
9163 * lread.c (openp): Don't stuff size_t into an 'int'.
9164 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
9165 about possible signed overflow.
9166
6048fb2a
PE
9167 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9168 (GDK_KEY_g): Don't define if already defined.
9169 (xg_prepare_tooltip): Avoid pointer signedness problem.
9170 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
9171
fa3c87e1
PE
9172 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
9173 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
9174
2172544b
PE
9175 * xfns.c (Fx_window_property): Simplify a bit,
9176 to make a bit faster and to avoid GCC 4.6.0 warning.
9177 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
9178
9b821a21
PE
9179 * fns.c (internal_equal): Don't assume size_t fits in int.
9180
3c616cfa
PE
9181 * alloc.c (compact_small_strings): Tighten assertion a little.
9182
c2982e87
PE
9183 Replace pEd with more-general pI, and fix some printf arg casts.
9184 * lisp.h (pI): New macro, generalizing old pEd macro to other
9185 conversion specifiers. For example, use "...%"pI"d..." rather
9186 than "...%"pEd"...".
9187 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 9188 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
9189 * alloc.c (check_pure_size): Don't overflow by converting size to int.
9190 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
9191 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
9192 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
9193 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
9194 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
9195 64-bit hosts.
9196 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
9197 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
9198 * print.c (safe_debug_print, print_object): Likewise.
9199 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
9200 to int.
6f04d126
PE
9201 Use pI instead of if-then-else-abort. Use %p to avoid casts,
9202 avoiding the 0 flag, which is not portable.
c2982e87
PE
9203 * process.c (Fmake_network_process): Use pI to avoid cast.
9204 * region-cache.c (pp_cache): Likewise.
9205 * xdisp.c (decode_mode_spec): Likewise.
9206 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
9207 behavior on 64-bit hosts with printf arg.
6f04d126 9208 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
9209 (x_stop_queuing_selection_requests): Likewise.
9210 (x_get_window_property): Don't truncate byte count to an 'int'
9211 when tracing.
0b432f21 9212
5e073ec7
PE
9213 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
9214 here, since it parses constructs like leading '-' and spaces,
9215 which are not wanted; and it overflows with large numbers.
9216 Instead, simply match F[0-9]+, which is what is wanted anyway.
9217
36372bf9
PE
9218 * alloc.c: Remove unportable assumptions about struct layout.
9219 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
9220 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
9221 (allocate_vectorlike, make_pure_vector): Use the new macros,
9222 plus offsetof, to remove unportable assumptions about struct layout.
9223 These assumptions hold on all porting targets that I know of, but
9224 they are not guaranteed, they're easy to remove, and removing them
9225 makes further changes easier.
9226
0b432f21
PE
9227 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
9228 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
9229 (string_overrun_cookie): Now const. Use initializers that
9230 don't formally overflow signed char, to avoid warnings.
000098c1
PE
9231 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
9232 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
9233 (allocate_buffer): Don't assume sizeof (struct buffer) is a
9234 multiple of sizeof (EMACS_INT); it need not be, if
9235 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 9236 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 9237
895009e1
JB
92382011-04-26 Juanma Barranquero <lekktu@gmail.com>
9239
9240 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
9241
6a7a1b0b
TZ
92422011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
9243
9244 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 9245 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
9246 Reported by Paul Eggert <eggert@cs.ucla.edu>.
9247
841a1577 92482011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
9249
9250 * lisp.h (Qdebug): List symbol.
895009e1 9251 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
9252 * keyboard.c (debug-on-event): New variable.
9253 (handle_user_signal): Break into debugger when debug-on-event
9254 matches the current signal symbol.
9255
f2d3ba6f
DN
92562011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
9257
9258 * alloc.c (check_sblock, check_string_bytes)
9259 (check_string_free_list): Convert to standard C.
9260
42ce4c63
TZ
92612011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
9262
9263 * w32.c (emacs_gnutls_push): Fix typo.
9264
825cd63c
EZ
92652011-04-25 Eli Zaretskii <eliz@gnu.org>
9266
fb11d64d
EZ
9267 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
9268 "cast to pointer from integer of different size".
9269
825cd63c
EZ
9270 Improve doprnt and its use in verror. (Bug#8545)
9271 * doprnt.c (doprnt): Document the set of format control sequences
9272 supported by the function. Use SAFE_ALLOCA instead of always
9273 using `alloca'.
9274
9275 * eval.c (verror): Don't limit the buffer size at size_max-1, that
9276 is one byte too soon. Don't use xrealloc; instead xfree and
9277 xmalloc anew.
9278
e061a11b
TZ
92792011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
9280
9281 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
9282 callbacks stage.
9283
9284 * gnutls.c: Renamed global_initialized to
9285 gnutls_global_initialized. Added internals for the
9286 :verify-hostname-error, :verify-error, and :verify-flags
9287 parameters of `gnutls-boot' and documented those parameters in the
9288 docstring. Start callback support.
9173deec
JB
9289 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
9290 unless a fatal error occurred. Call gnutls_alert_send_appropriate
9291 on error. Return error code.
e061a11b
TZ
9292 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
9293 (emacs_gnutls_read): Likewise.
9294 (Fgnutls_boot): Return handshake error code.
9295 (emacs_gnutls_handle_error): New function.
9296 (wsaerror_to_errno): Likewise.
9297
9298 * w32.h (emacs_gnutls_pull): Add prototype.
9299 (emacs_gnutls_push): Likewise.
9300
9301 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
9302 (emacs_gnutls_push): Likewise.
9303
93042011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
9305
9306 * process.c (wait_reading_process_output): Check if GnuTLS
9307 buffered some data internally if no FDs are set for TLS
9308 connections.
9309
9310 * makefile.w32-in (OBJ2): Add gnutls.$(O).
9311 (LIBS): Link to USER_LIBS.
9312 ($(BLD)/gnutls.$(0)): New target.
9313
fa6996bc
EZ
93142011-04-24 Eli Zaretskii <eliz@gnu.org>
9315
eb35682e
EZ
9316 * xdisp.c (handle_single_display_spec): Rename the
9317 display_replaced_before_p argument into display_replaced_p, to
9318 make it consistent with the commentary. Fix typos in the
9319 commentary.
9320
e2ad650c
EZ
9321 * textprop.c (syms_of_textprop): Remove dead code.
9322 (copy_text_properties): Delete obsolete commentary about an
9323 interface that was deleted long ago. Fix typos in the description
9324 of arguments.
9325
1b2de274
EZ
9326 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
9327 to changes in oldXMenu/XMenu.h from 2011-04-16.
9328 <menu_help_message, prev_menu_help_message>: Constify.
9329 (IT_menu_make_room): menu->help_text is now `const char **';
9330 adjust.
9331
9332 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
9333 to changes in oldXMenu/XMenu.h from 2011-04-16.
9334 (struct XMenu): Declare `help_text' `const char **'.
9335
9336 * xfaces.c <Qunspecified>: Make extern again.
9337
9338 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 9339 required by POSIX.
1b2de274 9340
762b15be
EZ
9341 * doc.c (get_doc_string): Improve the format passed to `error'.
9342
9343 * doprnt.c (doprnt): Improve commentary.
9344
9345 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
9346
9347 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
9348 them with etags.
9349
f1052e5d
EZ
9350 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
9351 changes in globals.h immediately force recompilation.
762b15be
EZ
9352 (TAGS): Depend on $(CURDIR)/m/intel386.h and
9353 $(CURDIR)/s/ms-w32.h.
9354 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 9355
fa6996bc
EZ
9356 * character.c (Fchar_direction): Function deleted.
9357 (syms_of_character): Don't defsubr it.
9358 <char-direction-table>: Deleted.
9359
e6c3da20
EZ
93602011-04-23 Eli Zaretskii <eliz@gnu.org>
9361
9362 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
9363 * doprnt.c: Include limits.h.
9364 (SIZE_MAX): New macro.
04f2d78b
CB
9365 (doprnt): Return a size_t value. 2nd arg is now size_t.
9366 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
9367 Improve overflow protection. Support `l' modifier for integer
9368 conversions. Support %l conversion. Don't assume an EMACS_INT
9369 argument for integer conversions and for %c.
9370
9371 * lisp.h (doprnt): Restore prototype.
9372
9373 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
9374 $(SRC)/character.h.
9375
9376 * Makefile.in (base_obj): Add back doprnt.o.
9377
9378 * deps.mk (doprnt.o): Add back prerequisites.
9379 (callint.o): Depend on character.h.
9380
9381 * eval.c (internal_lisp_condition_case): Include the handler
9382 representation in the error message.
9383 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
9384 when breaking from the loop.
9385
9386 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
9387
9388 * callint.c (Fcall_interactively): When displaying error message
9389 about invalid control letter, pass the character's codepoint, not
9390 a pointer to its multibyte form. Improve display of the character
9391 in octal and display also its hex code.
9392
9393 * character.c (char_string): Use %x to display the (unsigned)
9394 codepoint of an invalid character, to avoid displaying a bogus
9395 negative value.
9396
9397 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
9398 `error', not SYMBOL_NAME itself.
9399
9400 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
9401 character arguments to `error'.
9402
9403 * charset.c (check_iso_charset_parameter): Fix incorrect argument
9404 to `error' in error message about FINAL_CHAR argument. Make sure
9405 FINAL_CHAR is a character, and use %c when it is passed as
9406 argument to `error'.
9407
4ffd0d6b 94082011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
9409
9410 * s/ms-w32.h (localtime): Redirect to sys_localtime.
9411
9412 * w32.c: Include <time.h>.
9413 (sys_localtime): New function.
9414
4ffd0d6b 94152011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
9416
9417 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
9418
4ffd0d6b 9419 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 9420
4ffd0d6b 94212011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 9422
4ffd0d6b
GM
9423 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
9424 zombies (Bug#8467).
aac0c6e3 9425
04c56954
EZ
94262011-04-19 Eli Zaretskii <eliz@gnu.org>
9427
9428 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
9429 gl_state.e_property when gl_state.object is Qt.
9430
9431 * insdel.c (make_gap_larger): Remove limitation of buffer size
9432 to <= INT_MAX.
9433
16a43933
CY
94342011-04-18 Chong Yidong <cyd@stupidchicken.com>
9435
9436 * xdisp.c (lookup_glyphless_char_display)
9437 (produce_glyphless_glyph): Handle cons cell entry in
9438 glyphless-char-display.
9439 (Vglyphless_char_display): Document it.
9440
9441 * term.c (produce_glyphless_glyph): Handle cons cell entry in
9442 glyphless-char-display.
9443
4581706e
CY
94442011-04-17 Chong Yidong <cyd@stupidchicken.com>
9445
9446 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
9447
9448 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
9449
9450 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
9451 definition for no-X builds.
9452
4887c6e2 94532011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 9454
fd35b6f9
PE
9455 Static checks with GCC 4.6.0 and non-default toolkits.
9456
5c1ccb01
PE
9457 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
9458
006c5daa
PE
9459 * process.c (keyboard_bit_set): Define only if SIGIO.
9460 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
9461 (send_process): Repair possible setjmp clobbering.
9462
efc736d3
PE
9463 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
9464
4e2fe2e6
PE
9465 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
9466
f97334a2
PE
9467 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
9468
4e75f29d
PE
9469 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
9470 Define only if needed.
9471
90efadd1
PE
9472 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
9473 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 9474 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 9475
3c647824
PE
9476 * dispextern.h (struct redisplay_interface): Rename param
9477 to avoid shadowing.
e264f262 9478 * termhooks.h (struct terminal): Likewise.
761383f4 9479 * xterm.c (xembed_send_message): Likewise.
3c647824 9480
b58c5c4a
PE
9481 * insdel.c (make_gap_smaller): Define only if
9482 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
9483
cad59032
PE
9484 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
9485 it.
9486
c339dc2e
PE
9487 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
9488 so that we aren't warned about unused symbols.
9489
91a3e27b
PE
9490 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
9491
399c71d3 9492 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 9493
8ffc96f5
PE
9494 * xfns.c (x_real_positions): Mark locals as initialized.
9495
eef9bc79
PE
9496 * xmenu.c (xmenu_show): Don't use uninitialized vars.
9497
098db9dd
PE
9498 * xterm.c: Fix problems found by static analysis with other toolkits.
9499 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
9500 (x_dispatch_event): Declare static if USE_GTK, and
9501 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 9502 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 9503 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
9504 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
9505 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 9506
eb18f6cc
PE
9507 * xmenu.c (menu_help_callback): Pointer type fixes.
9508 Use const pointers when pointing at readonly data. Avoid pointer
9509 signedness clashes.
9510 (FALSE): Remove unused macro.
9511 (update_frame_menubar): Remove unused decl.
9512
1fe72bf8
PE
9513 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
9514
60d9e1db
PE
9515 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
9516 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
9517 (single_menu_item): Rename local to avoid shadowing.
9518
39261c26
PE
9519 * keyboard.c (make_lispy_event): Remove unused local var.
9520
018c5e19
PE
9521 * frame.c, frame.h (x_get_resource_string): Bring this back, but
9522 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
9523
63d2b86e
PE
9524 * bitmaps: Change bitmaps from unsigned char back to the X11
9525 compatible char. Avoid the old compiler warnings about
9526 out-of-range initializers by using, for example, '\xab' rather
9527 than 0xab.
9528
aefd87e1
PE
9529 * xgselect.c (xgselect_initialize): Check vs interface
9530 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
9531
bf501fb9
PE
9532 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
9533
e9829fdf
PE
9534 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
9535 to read-only memory.
9536
1086c095
PE
9537 * fns.c (vector): Remove; this old hack is no longer needed.
9538
2baccd04 9539 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 9540 Remove unused var.
dde42981 9541 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 9542
72391843 9543 * xrdb.c (x_load_resources): Omit unused local.
3565b346 9544
436c16df 9545 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 9546 (x_window): Rename locals to avoid shadowing.
dc5ddd85 9547 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 9548
92bb796d 9549 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 9550 (x_term_init): Remove local to avoid shadowing.
92bb796d 9551
764430a3 9552 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
9553
9554 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
9555 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
9556
d1dfb56c
EZ
95572011-04-16 Eli Zaretskii <eliz@gnu.org>
9558
c4354cb4
EZ
9559 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
9560
d1dfb56c
EZ
9561 Fix regex.c, syntax.c and friends for buffers > 2GB.
9562 * syntax.h (struct gl_state_s): Declare character position members
9563 EMACS_INT.
9564
9565 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
9566
04f2d78b
CB
9567 * textprop.c (verify_interval_modification, interval_of):
9568 Declare arguments EMACS_INT.
d1dfb56c
EZ
9569
9570 * intervals.c (adjust_intervals_for_insertion): Declare arguments
9571 EMACS_INT.
9572
9573 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
9574
9575 * indent.c (Fvertical_motion): Local variable it_start is now
9576 EMACS_INT.
9577
9578 * regex.c (re_match, re_match_2, re_match_2_internal)
9579 (bcmp_translate, regcomp, regexec, print_double_string)
9580 (group_in_compile_stack, re_search, re_search_2, regex_compile)
9581 (re_compile_pattern, re_exec): Declare arguments and local
9582 variables `size_t' and `ssize_t' and return values `regoff_t', as
9583 appropriate.
9584 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
9585 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
9586 <compile_stack_type>: `size' and `avail' are now `size_t'.
9587
9588 * regex.h <regoff_t>: Use ssize_t, not int.
9589 (re_search, re_search_2, re_match, re_match_2): Arguments that
9590 specify buffer/string position and length are now ssize_t and
9591 size_t. Return type is regoff_t.
9592
613052cd
BK
95932011-04-16 Ben Key <bkey76@gmail.com>
9594
9595 * nsfont.m: Fixed bugs in ns_get_family and
9596 ns_descriptor_to_entity that were caused by using free to
9597 deallocate memory blocks that were allocated by xmalloc (via
9598 xstrdup). This caused Emacs to crash when compiled with
9599 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
9600 --enable-checking=xmallocoverrun). xfree is now used to
9601 deallocate these memory blocks.
9602
4170f62f 96032011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 9604
71b41406
PE
9605 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
9606
9587a89d
PE
9607 emacs_write: Accept and return EMACS_INT for sizes.
9608 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
9609 et seq.
9610 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
9611 Accept and return EMACS_INT.
9612 (emacs_gnutls_write): Return the number of bytes written on
9613 partial writes.
9614 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
9615 (emacs_read, emacs_write): Remove check for negative size, as the
9616 Emacs source code has been audited now.
9587a89d
PE
9617 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
9618 (emacs_read, emacs_write): Use it.
273a5f82
PE
9619 * process.c (send_process): Adjust to the new signatures of
9620 emacs_write and emacs_gnutls_write. Do not attempt to store
9621 a byte offset into an 'int'; it might overflow.
9587a89d 9622 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 9623
3e047f51
PE
9624 * sound.c: Don't assume sizes fit in 'int'.
9625 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 9626 Return EMACS_INT, not int.
3e047f51 9627 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
9628 Accept EMACS_INT, not int.
9629 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
9630 record read return values.
9631
cc39a9db
BK
96322011-04-15 Ben Key <bkey76@gmail.com>
9633
c9d0ec6d
JB
9634 * keyboard.c (Qundefined): Don't declare static since it is used
9635 in nsfns.m.
9636 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
9637 static since they are used in nsfont.m.
cc39a9db 9638
6c60eb9f
SM
96392011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
9640
9641 * process.c (Qprocessp): Don't declare static.
9642 * lisp.h (Qprocessp): Declare again.
9643
7990b61a
JB
96442011-04-15 Juanma Barranquero <lekktu@gmail.com>
9645
9646 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
9647
5d4cb038
PE
96482011-04-14 Paul Eggert <eggert@cs.ucla.edu>
9649
8bd7b830 9650 Improve C-level modularity by making more things 'static'.
cd64ea1d 9651
e3b27b31
PE
9652 Don't publish debugger-only interfaces to other modules.
9653 * lisp.h (safe_debug_print, debug_output_compilation_hack):
9654 (verify_bytepos, count_markers): Move decls to the only modules
9655 that need them.
9656 * region-cache.h (pp_cache): Likewise.
9657 * window.h (check_all_windows): Likewise.
9658 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
9659
5d4cb038
PE
9660 * sysdep.c (croak): Now static, if
9661 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
9662 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
9663
9664 * alloc.c (refill_memory_reserve): Now static if
9665 !defined REL_ALLOC || defined SYSTEM_MALLOC.
9666 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 9667
e87b6180
PE
9668 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
9669 Define only if USE_LUCID.
9670
ac64929e
PE
9671 * xrdb.c (x_customization_string, x_rm_string): Now static.
9672
6f37259d
PE
9673 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
9674 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
9675
1683e3ab
PE
9676 * xdisp.c (draw_row_with_mouse_face): Now static.
9677 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
9678
de9c2632
PE
9679 * window.h (check_all_windows): Mark externally visible.
9680
2b96acb7
PE
9681 * window.c (window_deletion_count): Now static.
9682
9683 * undo.c: Make symbols static if they're not exported.
9684 (last_undo_buffer, last_boundary_position, pending_boundary):
9685 Now static.
9686
50436f33
PE
9687 * textprop.c (interval_insert_behind_hooks): Now static.
9688 (interval_insert_in_front_hooks): Likewise.
9689
64520e5c
PE
9690 * term.c: Make symbols static if they're not exported.
9691 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
9692 (max_frame_lines, tty_set_terminal_modes):
9693 (tty_reset_terminal_modes, tty_turn_off_highlight):
9694 (get_tty_terminal): Now static.
9695 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
9696 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 9697 HAVE_WINDOW_SYSTEM.
64520e5c
PE
9698 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
9699 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
9700
1fa53021
PE
9701 * sysdep.c: Make symbols static if they're not exported.
9702 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
9703 Now static.
9704 (sigprocmask_set, full_mask): Remove; unused.
9705 (wait_debugging): Mark as visible.
9706 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
9707 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
9708
d4b43b22
PE
9709 * syntax.c (syntax_temp): Define only if !__GNUC__.
9710
b7c513d0
PE
9711 * sound.c (current_sound_device, current_sound): Now static.
9712
989b29ad
PE
9713 * search.c (searchbufs, searchbuf_head): Now static.
9714
13a55a78
PE
9715 * scroll.c (scroll_cost): Remove; unused.
9716 * dispextern.h (scroll_cost): Remove decl.
9717
de68a1fc
PE
9718 * region-cache.h (pp_cache): Mark as externally visible.
9719
40ccffa6
PE
9720 * process.c: Make symbols static if they're not exported.
9721 (process_tick, update_tick, create_process, chan_process):
9722 (Vprocess_alist, proc_buffered_char, datagram_access):
9723 (fd_callback_data, send_process_frame, process_sent_to): Now static.
9724 (deactivate_process): Mark defn as static, as well as decl.
9725 * lisp.h (create_process): Remove decl.
9726 * process.h (chan_process, Vprocess_alist): Remove decls.
9727
ad64fc97
PE
9728 * print.c: Make symbols static if they're not exported.
9729 (print_depth, new_backquote_output, being_printed, print_buffer):
9730 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
9731 (print_interval, print_number_index, initial_stderr_stream):
9732 Now static.
9733 * lisp.h (Fprinc): Remove decl.
9734 (debug_output_compilation_hack): Mark as externally visible.
9735
adddb265
PE
9736 * sysdep.c (croak): Move decl from here to syssignal.h.
9737 * syssignal.h (croak): Put it here, so the API can be checked when
9738 'croak' is called from dissociate_if_controlling_tty.
9739
1717ede2
PE
9740 * minibuf.c: Make symbols static if they're not exported.
9741 (minibuf_save_list, choose_minibuf_frame): Now static.
9742 * lisp.h (choose_minibuf_frame): Remove decl.
9743
fa5fb2bc
PE
9744 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
9745
1e3890d1
PE
9746 * lread.c: Make symbols static if they're not exported.
9747 (read_objects, initial_obarray, oblookup_last_bucket_number):
9748 Now static.
9749 (make_symbol): Remove; unused.
9750 * lisp.h (initial_obarray, make_symbol): Remove decls.
9751
8a1414fa
PE
9752 * keyboard.c: Make symbols static if they're not exported.
9753 (single_kboard, recent_keys_index, total_keys, recent_keys):
9754 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
9755 (this_single_command_key_start, echoing, last_auto_save):
9756 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
9757 (command_loop, echo_now, keyboard_init_hook, help_char_p):
9758 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
9759 (Vlispy_mouse_stem, double_click_count):
9760 Now static.
9761 (force_auto_save_soon): Define only if SIGDANGER.
9762 (ignore_mouse_drag_p): Now static if
9763 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
9764 (print_help): Remove; unused.
9765 (stop_character, last_timer_event): Mark as externally visible.
9766 * keyboard.h (ignore_mouse_drag_p): Declare only if
9767 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
9768 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
9769 * lisp.h (echoing): Remove decl.
9770 (force_auto_save_soon): Declare only if SIGDANGER.
9771 * xdisp.c (redisplay_window): Simplify code, to make it more
9772 obvious that ignore_mouse_drag_p is not accessed if !defined
9773 USE_GTK && !defined HAVE_NS.
9774
93ea6e8f
PE
9775 * intervals.c: Make symbols static if they're not exported.
9776 (merge_properties_sticky, merge_interval_right, delete_interval):
9777 Now static.
9778 * intervals.h (merge_interval_right, delete_interval): Remove decls.
9779
77382fcc
PE
9780 * insdel.c: Make symbols static if they're not exported.
9781 However, leave prepare_to_modify_buffer alone. It's never
9782 called from outside this function, but that appears to be a bug.
9783 (combine_after_change_list, combine_after_change_buffer):
4889fc82 9784 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
9785 (adjust_after_replace_noundo): Remove; unused.
9786 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 9787 (signal_before_change): Remove decls.
77382fcc 9788
9306c32e
PE
9789 * indent.c (val_compute_motion, val_vmotion): Now static.
9790
cd44d2eb
PE
9791 * image.c: Make symbols static if they're not exported.
9792 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
9793 if USE_GTK.
9794 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
9795 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
9796
ad9a7a06
PE
9797 * fringe.c (standard_bitmaps): Now static.
9798 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
9799
81626931
PE
9800 * frame.c: Make symbols static if they're not exported.
9801 (x_report_frame_params, make_terminal_frame): Now static.
9802 (get_frame_param): Now static, unless HAVE_NS.
9803 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
9804 (x_get_resource_string): Remove; not used.
9805 * frame.h (make_terminal_frame, x_report_frame_params):
9806 (x_get_resource_string); Remove decls.
9807 (x_fullscreen_adjust): Declare only if WINDOWSNT.
9808 * lisp.h (get_frame_param): Declare only if HAVE_NS.
9809
239f9db9
PE
9810 * font.c, fontset.c: Make symbols static if they're not exported.
9811 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
9812 (FACE_SUITABLE_FOR_CHAR_P): Use it.
9813 * font.c (font_close_object): Now static.
9814 * font.h (font_close_object): Remove.
9815 * fontset.c (FONTSET_OBJLIST): Remove.
9816 (free_realized_fontset) #if-0 the body, which does nothing.
9817 (face_suitable_for_char_p): #if-0, as it's never called.
9818 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
9819 * xfaces.c (face_at_string_position):
9820 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
9821 since 0 is always ASCII.
9822
dfcf3579
PE
9823 * fns.c (weak_hash_tables): Now static.
9824
5045092b
PE
9825 * fileio.c: Make symbols static if they're not exported.
9826 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
9827 (Vwrite_region_annotation_buffers): Now static.
9828
57a96f5c
PE
9829 * eval.c: Make symbols static if they're not exported.
9830 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
9831 * lisp.h (backtrace_list): Remove decl.
9832
35f08c38
PE
9833 * emacs.c: Make symbols static if they're not exported.
9834 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
9835 (fatal_error_code, fatal_error_signal_hook, standard_args):
9836 Now static.
9837 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
9838 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
9839 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
9840 * lisp.h (fatal_error_signal_hook): Remove decl.
9841 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
9842
f44bd759
PE
9843 * editfns.c: Move a (normally-unused) function to its only use.
9844 * editfns.c, lisp.h (get_operating_system_release): Remove.
9845 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
9846 worth the hassle of breaking this out.
9847
b532497d
PE
9848 * xterm.c: Make symbols static if they're not exported.
9849 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
9850 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
9851 (x_destroy_window, x_delete_display):
9852 Now static.
9853 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
9854 (x_mouse_leave): Remove; unused.
9855 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
9856 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
9857 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
9858 Remove decls.
9859 (x_mouse_leave): Declare only if WINDOWSNT.
9860 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
9861 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
9862 USE_X_TOOLKIT.
9863
1675728f
PE
9864 * ftxfont.c: Make symbols static if they're not exported.
9865 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
9866 HAVE_FREETYPE.
9867 * font.h (ftxfont_driver): Likewise.
9868
e4cebfca
PE
9869 * xfns.c: Make symbols static if they're not exported.
9870 (x_last_font_name, x_display_info_for_name):
9871 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
9872 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
9873 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
9874 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
9875 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
9876 (last_show_tip_args): Now static.
9877 (xic_defaut_fontset, xic_create_fontsetname): Define only if
9878 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
9879 (x_screen_planes): Remove; unused.
9880 * dispextern.h (x_screen_planes): Remove decl.
9881
5bf46f05
PE
9882 * dispnew.c: Make symbols static if they're not exported.
9883 * dispextern.h (redraw_garbaged_frames, scrolling):
9884 (increment_row_positions): Remove.
9885 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
9886 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
9887 Now static.
9888 (redraw_garbaged_frames): Remove; unused.
9889
435f4c28
PE
9890 * xfaces.c: Make symbols static if they're not exported.
9891 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
9892 Remove decls.
9893 * xterm.h (defined_color): Remove decls.
9894 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
9895 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
9896 (menu_face_changed_default, defined_color, free_realized_face):
9897 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
9898 (ascii_face_of_lisp_face): Remove; unused.
9899
8524aef3
PE
9900 * xdisp.c: Make symbols static if they're not exported.
9901 * dispextern.h (scratch_glyph_row, window_box_edges):
9902 (glyph_to_pixel_coords, set_cursor_from_row):
9903 (get_next_display_element, set_iterator_to_next):
9904 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
9905 (show_mouse_face): Remove decls
9906 * frame.h (message_buf_print): Likewise.
9907 * lisp.h (pop_message, set_message, check_point_in_composition):
9908 Likewise.
9909 * xterm.h (set_vertical_scroll_bar): Likewise.
9910 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
9911 (message_buf_print, scratch_glyph_row, displayed_buffer):
9912 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
9913 (get_next_display_element, show_mouse_face, window_box_edges):
9914 (frame_to_window_pixel_xy, check_point_in_composition):
9915 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
9916 (glyph_to_pixel_coords): Remove; unused.
9917
16390cd2
PE
9918 * dired.c (file_name_completion): Now static.
9919
9920 * dbusbind.c (xd_in_read_queued_messages): Now static.
9921
a25f4dfa
PE
9922 * lisp.h (circular_list_error, FOREACH): Remove; unused.
9923 * data.c (circular_list_error): Remove.
9924
14a9c8df
PE
9925 * commands.h (last_point_position, last_point_position_buffer):
9926 (last_point_position_window): Remove decls.
9927 * keyboard.c: Make these variables static.
9928
04f2d78b
CB
9929 * coding.h (coding, code_convert_region, encode_coding_gap):
9930 Remove decls.
74ab6df5
PE
9931 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
9932 (iso_code_class, detect_coding, code_convert_region): Now static.
9933 (encode_coding_gap): Remove; unused.
9934
38dfbee1
PE
9935 * chartab.c (chartab_chars, chartab_bits): Now static.
9936
a2cb4e63
PE
9937 * charset.h (charset_iso_8859_1): Remove decl.
9938 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
9939 Now static.
9940
127198fd
PE
9941 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
9942 * ccl.c (Vccl_program_table): Now static.
9943 (check_ccl_update): Remove; unused.
9944
d85b608f
PE
9945 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
9946 * category.h: ... from here.
9947 * category.c (check_category_table, set_category_set): Now static.
9948
31cd66f3
PE
9949 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
9950 * lisp.h: Remove these decls.
9951
c358e587
PE
9952 * buffer.c (buffer_count): Remove unused var.
9953
e78aecca
PE
9954 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
9955 so that it's not optimized away.
9956 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
9957 * dispextern.h (bidi_dump_cached_states): Remove, since it's
9958 exported only to the debugger.
9959
e192d7d3 9960 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 9961 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 9962
92470028
PE
9963 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
9964 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
9965 was inaccessible from Lisp.
9966 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
9967 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
9968
244ed907
PE
9969 alloc.c: Import and export fewer symbols, and remove unused items.
9970 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
9971 is defined.
9972 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
9973 it's not optimized away by whole-program optimization.
9974 (message_enable_multibyte, free_misc): Remove.
9975 (catchlist, handlerlist, mark_backtrace):
9976 Declare only if BYTE_MARK_STACK.
9977 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
9978 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
9979 (message_enable_multibyte): Remove decl.
9980 (free_misc, interval_free_list, float_block, float_block_index):
9981 (n_float_blocks, float_free_list, cons_block, cons_block_index):
9982 (cons_free_list, last_marked_index):
9983 Now static.
9984 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
9985 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
9986 (mark_backtrace): Define only if BYTE_MARK_STACK.
9987 * xdisp.c (message_enable_multibyte): Now static.
9988
61c2b50e 9989 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
9990 This makes it easier for human readers (and static analyzers)
9991 to see whether these variables are used from other modules.
9992 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
9993 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
9994 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
9995 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
9996 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
9997 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
9998 * xmenu.c, xselect.c:
9999 Declare Q* vars static if they are not used in other modules.
10000 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
10001 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
10002 Remove decls of unexported vars.
10003 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
10004
95c82688
PE
10005 * lisp.h (DEFINE_FUNC): Make sname 'static'.
10006
16a97296
PE
10007 Make Emacs functions such as Fatom 'static' by default.
10008 This makes it easier for human readers (and static analyzers)
10009 to see whether these functions can be called from other modules.
10010 DEFUN now defines a static function. To make the function external
10011 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
10012 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
10013 (Finit_image_library):
16a97296
PE
10014 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
10015 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
10016 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
10017 Remove decls, since these functions are now static.
10018 (Funintern, Fget_internal_run_time): New decls, since these functions
10019 were already external.
95c82688 10020
16a97296
PE
10021 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
10022 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
10023 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
10024 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
10025 * keyboard.c, keymap.c, lread.c:
10026 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
10027 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
10028 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
10029 Mark functions with DEFUE instead of DEFUN,
10030 if they are used in other modules.
10031 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
10032 decls for now-static functions.
10033 * buffer.h (Fdelete_overlay): Remove decl.
10034 * callproc.c (Fgetenv_internal): Mark as internal.
10035 * composite.c (Fremove_list_of_text_properties): Remove decl.
10036 (Fcomposition_get_gstring): New forward static decl.
10037 * composite.h (Fcomposite_get_gstring): Remove decl.
10038 * dired.c (Ffile_attributes): New forward static decl.
10039 * doc.c (Fdocumntation_property): New forward static decl.
10040 * eval.c (Ffetch_bytecode): New forward static decl.
10041 (Funintern): Remove extern decl; now in .h file where it belongs.
10042 * fileio.c (Fmake_symbolic_link): New forward static decl.
10043 * image.c (Finit_image_library): New forward static decl.
10044 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
10045 * intervals.h (Fprevious_property_change):
10046 (Fremove_list_of_text_properties): Remove decls.
10047 * keyboard.c (Fthis_command_keys): Remove decl.
10048 (Fcommand_execute): New forward static decl.
10049 * keymap.c (Flookup_key): New forward static decl.
10050 (Fcopy_keymap): Now static.
10051 * keymap.h (Flookup_key): Remove decl.
10052 * process.c (Fget_process): New forward static decl.
10053 (Fprocess_datagram_address): Mark as internal.
10054 * syntax.c (Fsyntax_table_p): New forward static decl.
10055 (skip_chars): Remove duplicate decl.
10056 * textprop.c (Fprevious_property_change): New forward static decl.
10057 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
10058 Now internal.
10059 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
10060 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
10061
785bbd42
PE
10062 * editfns.c (Fformat): Remove unreachable code.
10063
8b913b57
AS
100642011-04-14 Andreas Schwab <schwab@linux-m68k.org>
10065
10066 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
10067 change. (Bug#8496)
10068
a6744a35
EZ
100692011-04-13 Eli Zaretskii <eliz@gnu.org>
10070
10071 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
10072 when at ZV. (Bug#8487)
10073
e7974947
AS
100742011-04-12 Andreas Schwab <schwab@linux-m68k.org>
10075
baad03f0
AS
10076 * charset.c (Fclear_charset_maps): Use xfree instead of free.
10077 (Bug#8437)
10078 * keyboard.c (parse_tool_bar_item): Likewise.
10079 * sound.c (sound_cleanup, alsa_close): Likewise.
10080 * termcap.c (tgetent): Likewise.
10081 * xfns.c (x_default_font_parameter): Likewise.
10082 * xsettings.c (read_and_apply_settings): Likewise.
10083
e7974947
AS
10084 * alloc.c (overrun_check_malloc, overrun_check_realloc)
10085 (overrun_check_free): Protoize.
10086
28272684
PE
100872011-04-12 Paul Eggert <eggert@cs.ucla.edu>
10088
10089 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
10090 since callers should never pass a negative size.
10091 Change the signature to match that of plain 'read' and 'write'; see
10092 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
10093 * lisp.h: Update prototypes of emacs_write and emacs_read.
10094
11997c76
EZ
100952011-04-11 Eli Zaretskii <eliz@gnu.org>
10096
10097 * xdisp.c (redisplay_window): Don't try to determine the character
10098 position of the scroll margin if the window start point w->startp
e896f03c 10099 is outside the buffer's accessible region. (Bug#8468)
11997c76 10100
8a2cbd72
EZ
101012011-04-10 Eli Zaretskii <eliz@gnu.org>
10102
10103 Fix write-region and its subroutines for buffers > 2GB.
10104 * fileio.c (a_write, e_write): Modify declaration of arguments and
10105 local variables to support buffers larger than 2GB.
10106 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
10107
10108 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
10109 argument, local variables, and return value.
10110
10111 * lisp.h: Update prototypes of emacs_write and emacs_read.
10112
10113 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
10114
4073e537 101152011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 10116
1ebfdcb6
PE
10117 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
10118
b2ded58d
PE
10119 Fix more problems found by GCC 4.6.0's static checks.
10120
7d66342c
PE
10121 * xdisp.c (vmessage): Use a better test for character truncation.
10122
bbf47d44
PE
10123 * charset.c (load_charset_map): <, not <=, for optimization,
10124 and to avoid potential problems with integer overflow.
9248994d 10125 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 10126 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 10127 * editfns.c (Fformat): Likewise.
1e69125e 10128 * syntax.c (skip_chars): Likewise.
3befa583 10129
e3019616
PE
10130 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
10131 This also lets GCC 4.6.0 generate slightly better loop code.
10132
becfa255
PE
10133 * callint.c (Fcall_interactively): <, not <=, for optimization.
10134 (Fcall_interactively): Count the number of arguments produced,
10135 not the number of arguments given. This is simpler and lets GCC
10136 4.6.0 generate slightly better code.
10137
dae0cd48
PE
10138 * ftfont.c: Distingish more carefully between FcChar8 and char.
10139 The previous code passed unsigned char * to a functions like
10140 strlen and xstrcasecmp that expect char *, which does not
10141 conform to the C standard.
10142 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
10143 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
10144 char * when the C standard requires it.
10145
76032d70
PE
10146 * keyboard.c (read_char): Remove unused var.
10147
eb3f1cc8
PE
10148 * eval.c: Port to Windows vsnprintf (Bug#8435).
10149 Include <limits.h>.
10150 (SIZE_MAX): Define if the headers do not.
10151 (verror): Do not give up if vsnprintf returns a negative count.
10152 Instead, grow the buffer. This ports to Windows vsnprintf, which
10153 does not conform to C99. Problem reported by Eli Zaretskii.
10154 Also, simplify the allocation scheme, by avoiding the need for
10155 calling realloc, and removing the ALLOCATED variable.
10156
70476b54
PE
10157 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
10158
12020a9e
PE
10159 Remove invocations of doprnt, as Emacs now uses vsnprintf.
10160 But keep the doprint source code for now, as we might revamp it
10161 and use it again (Bug#8435).
ea6c7ae6
PE
10162 * lisp.h (doprnt): Remove.
10163 * Makefile.in (base_obj): Remove doprnt.o.
10164 * deps.mk (doprnt.o): Remove.
10165
5fdb398c
PE
10166 error: Print 32- and 64-bit integers portably (Bug#8435).
10167 Without this change, on typical 64-bit hosts error ("...%d...", N)
10168 was used to print both 32- and 64-bit integers N, which relied on
10169 undefined behavior.
61bdb816 10170 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
10171 * lisp.h (error, verror): Mark as printf-like functions.
10172 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
10173 Report overflow in size calculations when allocating printf buffer.
10174 Do not truncate output string at its first null byte.
10175 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
10176 Truncate the output at a character boundary, since vsnprintf does not
10177 do that.
10178 * charset.c (check_iso_charset_parameter): Convert internal
10179 character to string before calling 'error', since %c now has the
10180 printf meaning.
10181 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
10182 overflow when computing char to be passed to 'error'. Do not
10183 pass Lisp_Object to 'error'; pass the integer instead.
10184 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
10185 formatted with plain %d.
10186
b189fa66
PE
10187 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
10188
bff87ef0
PE
10189 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
10190
7e2cac20
PE
10191 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
10192
ce4d90b5
PE
10193 * xterm.c (x_catch_errors): Remove duplicate declaration.
10194
266c9547
PE
10195 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
10196
79c49ad2
PE
10197 * xdisp.c, lisp.h (message_nolog): Remove; unused.
10198
368f4090
JM
101992011-04-10 Jim Meyering <meyering@redhat.com>
10200
10201 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
10202 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
10203 return ssize_t not "int", and use size_t as the buffer length.
10204 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
10205 * gnutls.h: Update declarations.
10206 * process.c (read_process_output): Use ssize_t, to match.
10207 (send_process): Likewise.
10208
a32d4040
CY
102092011-04-09 Chong Yidong <cyd@stupidchicken.com>
10210
10211 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
10212
8546720e 102132011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 10214
04f2d78b
CB
10215 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
10216 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 10217
8546720e
GM
10218 * xterm.c (handle_one_xevent):
10219 * xmenu.c (create_and_show_popup_menu):
10220 * xselect.c (x_decline_selection_request)
10221 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 10222
0a2f5c1a 102232011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
10224
10225 Fix some uses of `int' instead of EMACS_INT.
10226 * search.c (string_match_1, fast_string_match)
10227 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
10228 (scan_buffer, find_next_newline_no_quit)
10229 (find_before_next_newline, search_command, Freplace_match)
10230 (Fmatch_data): Make some `int' variables be EMACS_INT.
10231
10232 * xdisp.c (display_count_lines): 3rd argument and return value now
10233 EMACS_INT. All callers changed.
10234 (pint2hrstr): Last argument is now EMACS_INT.
10235
10236 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
10237 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
10238 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
10239 (decode_coding_utf_16, decode_coding_emacs_mule)
10240 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
10241 (decode_coding_ccl, decode_coding_charset)
10242 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
10243 (decode_coding_iso_2022, decode_coding_emacs_mule)
10244 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
10245 <char_offset, last_offset>: Declare EMACS_INT.
10246 (encode_coding_utf_8, encode_coding_utf_16)
10247 (encode_coding_emacs_mule, encode_invocation_designation)
10248 (encode_designation_at_bol, encode_coding_iso_2022)
10249 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
10250 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
10251 Declare EMACS_INT.
10252 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
10253 (encode_invocation_designation): Last argument P_NCHARS is now
10254 EMACS_INT.
10255 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
10256 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
10257
10258 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
10259 All users changed.
10260
10261 * ccl.c (Fccl_execute_on_string): Declare some variables
10262 EMACS_INT.
10263
8546720e 102642011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
10265
10266 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
10267
4e19a977
CS
102682011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
10269
10270 * process.c (Fformat_network_address): Doc fix.
10271
87302331
R
102722011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
10273
ee7683eb 10274 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 10275
cbb59342
CY
102762011-04-08 Chong Yidong <cyd@stupidchicken.com>
10277
10278 * keyboard.c (read_char): Call Lisp function help-form-show,
10279 instead of using internal_with_output_to_temp_buffer.
10280 (Qhelp_form_show): New var.
e0d38eeb 10281 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
10282
10283 * print.c (internal_with_output_to_temp_buffer): Function deleted.
10284
10285 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
10286
e67a13ab
CY
102872011-04-06 Chong Yidong <cyd@stupidchicken.com>
10288
04f2d78b
CB
10289 * process.c (Flist_processes): Remove to Lisp.
10290 (list_processes_1): Delete.
e67a13ab 10291
973f782d
EZ
102922011-04-06 Eli Zaretskii <eliz@gnu.org>
10293
7c106b1e
EZ
10294 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
10295
973f782d
EZ
10296 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
10297
41cf7d1a 102982011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 10299
ca23cc88
PE
10300 Fix more problems found by GCC 4.6.0's static checks.
10301
f390e2d5
PE
10302 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
10303
42eea0d0
PE
10304 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
10305
b69769da 10306 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 10307
f9541e84
PE
10308 * xdisp.c (vmessage): Mark as a printf-like function.
10309
13841b55
PE
10310 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
10311
c136c10f
PE
10312 * sound.c (sound_warning): Don't crash if arg contains a printf format.
10313
5e2d4a30
PE
10314 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
10315 printf-like functions.
10316 (tiff_load): Add casts to remove these marks before passing them
10317 to system-supplied API.
10318
583f48b9
PE
10319 * eval.c (Fsignal): Remove excess argument to 'fatal'.
10320
b25d760e
PE
10321 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
10322 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
10323 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
10324 directly, rather than having caller test rule sign. This avoids
10325 some unnecessary tests.
10326 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
10327 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
10328 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 10329
bc7b6697 10330 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 10331 (xfont_open): Avoid unnecessary tests.
bc7b6697 10332
27ccc379
PE
10333 * composite.c (composition_gstring_put_cache): Use unsigned integer.
10334
dcd5c89a
PE
10335 * composite.h, composite.c (composition_gstring_put_cache):
10336 Use EMACS_INT, not int, for length.
10337
b13a45c6
PE
10338 * composite.h (COMPOSITION_DECODE_REFS): New macro,
10339 breaking out part of COMPOSITION_DECODE_RULE.
10340 (COMPOSITION_DECODE_RULE): Use it.
10341 * composite.c (get_composition_id): Remove unused local vars,
10342 by using the new macro.
10343
1e792e4d
PE
10344 * textprop.c (set_text_properties_1): Change while to do-while,
10345 since the condition is always true at first.
10346
dc6c6455 10347 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
10348 (interval_deletion_adjustment): Return unsigned value.
10349 All uses changed.
dc6c6455 10350
aba7731a
PE
10351 * process.c (list_processes_1, create_pty, read_process_output):
10352 (exec_sentinel): Remove vars that were set but not used.
afd4052b 10353 (create_pty): Remove unnecessary "volatile"s.
bc57d757 10354 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 10355 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 10356 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 10357
fdfc4bf3
PE
10358 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
10359
fca8fe46 10360 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 10361 (update_syntax_table): Use unsigned instead of int.
fca8fe46 10362
06a0259a 10363 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 10364 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 10365 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 10366
e7b9e80f
PE
10367 * print.c (print_error_message): Avoid int overflow.
10368
56201685
PE
10369 * font.c (font_list_entities): Redo for clarity,
10370 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
10371
78834453 10372 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 10373 (font_score): Avoid potential overflow in diff calculation.
78834453 10374
0bc0b309 10375 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 10376 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 10377
e610eaca
PE
10378 * eval.c (funcall_lambda): Rename local to avoid shadowing.
10379
b895abce
PE
10380 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
10381 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
10382 can always succeed if overflow has undefined behavior.
10383
1f1d9321 10384 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 10385 (wordify): Omit three unnecessary tests.
1f1d9321 10386
c59478bc
PE
10387 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
10388 All callers changed. This avoids the need for an unused var.
10389
79b73827
PE
10390 * casefiddle.c (casify_region): Remove var that is set but not used.
10391
a4db5dfe
PE
10392 * dired.c (file_name_completion): Remove var that is set but not used.
10393
43aae36e
PE
10394 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
10395
2a47c44d 10396 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 10397 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 10398
a37c69bf
PE
10399 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
10400 Check for integer overflow on size calculations.
10401
328ab8e7
PE
10402 * buffer.c (Fprevious_overlay_change): Remove var that is set
10403 but not used.
10404
e5a2a5cb
PE
10405 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
10406 Remove vars that are set but not used.
8d84a6eb 10407 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 10408 (timer_check_2): Mark vars as initialized.
e5a2a5cb 10409
a60e5f68
PE
10410 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
10411
f661cb61 10412 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 10413 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 10414
f0397f5a
PE
10415 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
10416 that are set but not used.
10417
8664db06 10418 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 10419 if XCreateBitmapFromData fails (Bug#8410).
8664db06 10420
6abdaa4a
PE
10421 * xselect.c (x_get_local_selection, x_handle_property_notify):
10422 Remove vars that are set but not used.
10423
0ce7538d 10424 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 10425 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 10426
9ae848fc
PE
10427 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
10428 Remove var that is set but not used.
0b918413
PE
10429 (scroll_bar_windows_size): Now size_t, not int.
10430 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
10431 Check for overflow.
9ae848fc 10432
a5a62657
PE
10433 * xfaces.c (realize_named_face): Remove vars that are set but not used.
10434 (map_tty_color) [!defined MSDOS]: Likewise.
10435
5c5cdd39
PE
10436 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
10437
66ebf983
PE
10438 * coding.c: Remove vars that are set but not used.
10439 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
10440 All callers changed.
10441 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
10442 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
10443 (decode_coding_charset): Remove vars that are set but not used.
10444
1be4d761
PE
10445 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
10446 that is set but not used.
10447
47553fa8
PE
10448 * print.c (print_object): Remove var that is set but not used.
10449
1f7196bf 10450 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
10451 The gnulib version avoids calling malloc in the usual case,
10452 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
10453 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
10454 * filelock.c (current_lock_owner): Likewise.
10455 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
10456 * sysdep.c: Include allocator.h, careadlinkat.h.
10457 (emacs_no_realloc_allocator): New static constant.
10458 (emacs_readlink): New function.
fdb61804
PE
10459 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
10460 ../lib/careadlinkat.h.
d1fdcab7 10461
f84c17c7
SM
104622011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
10463
10464 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
10465 first non-nil return value).
10466
ef3862ad
JD
104672011-04-03 Jan Djärv <jan.h.d@swipnet.se>
10468
10469 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
10470 if not defined (Bug#8403).
10471
376a7006
JB
104722011-04-02 Juanma Barranquero <lekktu@gmail.com>
10473
10474 * xdisp.c (display_count_lines): Remove parameter `start',
10475 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10476 (get_char_face_and_encoding): Remove parameter `multibyte_p',
10477 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10478 (fill_stretch_glyph_string): Remove parameters `row' and `area',
10479 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
10480 and thereabouts. All callers changed.
10481 (get_per_char_metric): Remove parameter `f', unused since
10482 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10483
6ca3801d
JM
104842011-04-02 Jim Meyering <meyering@redhat.com>
10485
10486 do not dereference NULL upon failed strdup
10487 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
10488 (ns_get_family): Likewise.
10489
d8e2b5ba
JB
104902011-04-02 Juanma Barranquero <lekktu@gmail.com>
10491
10492 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
10493
8c74fcbd
JD
104942011-04-02 Jan Djärv <jan.h.d@swipnet.se>
10495
10496 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
10497 later (Bug#8403).
10498
7200d79c
SM
104992011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
10500
03408648 10501 Add lexical binding.
7200d79c 10502
03408648
SM
10503 * window.c (Ftemp_output_buffer_show): New fun.
10504 (Fsave_window_excursion):
10505 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
10506
10507 * lread.c (lisp_file_lexically_bound_p): New function.
10508 (Fload): Bind Qlexical_binding.
10509 (readevalloop): Remove `evalfun' arg.
10510 Bind Qinternal_interpreter_environment.
10511 (Feval_buffer): Bind Qlexical_binding.
10512 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
10513 Mark as dynamic.
10514 (syms_of_lread): Declare `lexical-binding'.
10515
10516 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
10517
10518 * keyboard.c (eval_dyn): New fun.
10519 (menu_item_eval_property): Use it.
ca105506
SM
10520
10521 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 10522
03408648
SM
10523 * fns.c (concat, mapcar1): Accept byte-code-functions.
10524
10525 * eval.c (Fsetq): Handle lexical vars.
10526 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
10527 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
10528 (FletX, Flet): Obey lexical binding.
10529 (Fcommandp): Handle closures.
10530 (Feval): New `lexical' arg.
10531 (eval_sub): New function extracted from Feval. Use it almost
10532 everywhere where Feval was used. Look up vars in lexical env.
10533 Handle closures.
10534 (Ffunctionp): Move from subr.el.
10535 (Ffuncall): Handle closures.
10536 (apply_lambda): Remove `eval_flags'.
10537 (funcall_lambda): Handle closures and new byte-code-functions.
10538 (Fspecial_variable_p): New function.
10539 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
10540 but without exporting it to Lisp.
23aba0ea 10541
23aba0ea 10542 * doc.c (Fdocumentation, store_function_docstring):
03408648 10543 * data.c (Finteractive_form): Handle closures.
23aba0ea 10544
03408648
SM
10545 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
10546 interactive spec.
ba83908c 10547
04f2d78b
CB
10548 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
10549 New byte-codes.
03408648
SM
10550 (exec_byte_code): New function extracted from Fbyte_code to handle new
10551 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 10552
03408648 10553 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 10554
03408648 10555 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 10556
e2abce01
JB
105572011-03-31 Juanma Barranquero <lekktu@gmail.com>
10558
10559 * xdisp.c (redisplay_internal): Fix prototype.
10560
63696a73 105612011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 10562
63696a73 10563 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
10564 (try_scrolling): Use it when setting scroll_limit.
10565 Limit scrolling to 100 screen lines.
63696a73
EZ
10566 (redisplay_window): Even when falling back on "recentering",
10567 position point in the window according to scroll-conservatively,
10568 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
10569
10570 (try_scrolling): When point is above the window, allow searching
10571 as far as scroll_max, or one screenful, to compute vertical
10572 distance from PT to the scroll margin position. This prevents
10573 try_scrolling from unnecessarily failing when
10574 scroll-conservatively is set to a value slightly larger than the
10575 window height. Clean up the case of PT below the margin at bottom
10576 of window: scroll_max can no longer be INT_MAX. When aggressive
10577 scrolling is in use, don't let point enter the opposite scroll
10578 margin as result of the scroll.
10579 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
10580 threshold of 100 lines for never-recentering scrolling.
10581
e4cc2dfc
JB
105822011-03-31 Juanma Barranquero <lekktu@gmail.com>
10583
10584 * dispextern.h (move_it_by_lines):
10585 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
10586 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
10587 (message_log_check_duplicate): Remove parameters `prev_bol' and
10588 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10589 (redisplay_internal): Remove parameter `preserve_echo_area',
10590 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
10591
10592 * indent.c (Fvertical_motion):
10593 * window.c (window_scroll_pixel_based, Frecenter):
10594 Don't pass `need_y_p' to `move_it_by_lines'.
10595
1c470562
SM
105962011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
10597
44f230aa
SM
10598 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
10599 steal a few bits to be more compact.
10600 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
10601 Remove unneeded casts.
10602
1c470562
SM
10603 * bytecode.c (Fbyte_code): CAR and CDR can GC.
10604
888adce9
ZK
106052011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
10606
10607 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
10608 binding" message (bug#7967).
10609
f838ed7b
PE
106102011-03-30 Paul Eggert <eggert@cs.ucla.edu>
10611
77861b95
PE
10612 Fix more problems found by GCC 4.6.0's static checks.
10613
de6dbc14
PE
10614 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
10615 Remove unused local var.
10616
f838ed7b
PE
10617 * editfns.c (Fmessage_box): Remove unused local var.
10618
792c7b2b
PE
10619 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
10620 (note_mode_line_or_margin_highlight, note_mouse_highlight):
10621 Omit unused local vars.
c499e557 10622 * window.c (shrink_windows): Omit unused local var.
b01a1c29 10623 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
10624 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
10625 Omit unused local var.
10626
ba0165e1
PE
10627 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
10628 Don't assume string length fits in int.
32ad8845 10629 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 10630 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 10631
3c59b4c9
PE
10632 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
10633 instead of alloca (Bug#8344).
10634
a3eed478 10635 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 10636 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 10637
eb4d412d
PE
10638 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
10639
1658b401
PE
10640 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
10641 concerns.
10642
10643 * term.c (produce_glyphless_glyph): Remove unnecessary test.
10644
10645 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 10646
9a2c6e05
PE
10647 * keyboard.c (syms_of_keyboard): Use the same style as later
10648 in this function when indexing through an array. This also
10649 works around GCC bug 48267.
10650
03d0a109
PE
10651 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
10652
44f730c8
PE
10653 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
10654
fe75f926
PE
10655 * chartab.c (sub_char_table_ref_and_range): Redo for slight
10656 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
10657
ffa8c828
PE
10658 * keyboard.c, keyboard.h (num_input_events): Now size_t.
10659 This avoids undefined behavior on integer overflow, and is a bit
10660 more convenient anyway since it is compared to a size_t variable.
10661
c5101a77
PE
10662 Variadic C functions now count arguments with size_t, not int.
10663 This avoids an unnecessary limitation on 64-bit machines, which
10664 caused (substring ...) to crash on large vectors (Bug#8344).
10665 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
10666 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 10667 All variadic functions and their callers changed accordingly.
c5101a77
PE
10668 (struct gcpro.nvars): Now size_t, not int. All uses changed.
10669 * data.c (arith_driver, float_arith_driver): Likewise.
10670 * editfns.c (general_insert_function): Likewise.
10671 * eval.c (struct backtrace.nargs, interactive_p)
10672 (internal_condition_case_n, run_hook_with_args, apply_lambda)
10673 (funcall_lambda, mark_backtrace): Likewise.
10674 * fns.c (concat): Likewise.
10675 * frame.c (x_set_frame_parameters): Likewise.
10676 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
10677 0 if not found, not -1. All callers changed.
10678
dd3f25f7
PE
10679 * alloc.c (garbage_collect): Don't assume stack size fits in int.
10680 (stack_copy_size): Now size_t, not int.
10681 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
10682
461c2ab9
JB
106832011-03-28 Juanma Barranquero <lekktu@gmail.com>
10684
10685 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
10686 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10687 All callers changed.
10688
10689 * lisp.h (multibyte_char_to_unibyte):
10690 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
10691 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10692 * character.h (CHAR_TO_BYTE8):
10693 * cmds.c (internal_self_insert):
10694 * editfns.c (general_insert_function):
10695 * keymap.c (push_key_description):
10696 * search.c (Freplace_match):
10697 * xdisp.c (message_dolog, set_message_1): All callers changed.
10698
f6d62986
SM
106992011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
10700
10701 * keyboard.c (safe_run_hook_funcall): New function.
10702 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
10703 don't set the hook to nil, but remove the offending function instead.
10704 (Qcommand_hook_internal): Remove, unused.
10705 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
10706 Vcommand_hook_internal.
10707
10708 * eval.c (enum run_hooks_condition): Remove.
10709 (funcall_nil, funcall_not): New functions.
10710 (run_hook_with_args): Call each function through a `funcall' argument.
10711 Remove `cond' argument, now redundant.
10712 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
10713 (Frun_hook_with_args_until_failure): Adjust accordingly.
10714 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
10715
1db5b1ad
JB
107162011-03-28 Juanma Barranquero <lekktu@gmail.com>
10717
10718 * dispextern.h (string_buffer_position): Remove declaration.
10719
10720 * print.c (strout): Remove parameter `multibyte', unused since
10721 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
10722
10723 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
10724 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
10725 All callers changed.
10726
10727 * w32.c (_wsa_errlist): Use braces for struct initializers.
10728
10729 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
10730 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
10731 All callers changed.
10732 (string_buffer_position): Likewise. Also, make static (it's never
10733 used outside xdisp.c).
10734 (cursor_row_p): Remove parameter `w', unused since
10735 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
10736 (decode_mode_spec): Remove parameter `precision', introduced during
10737 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
10738 All callers changed.
10739
5ffb62aa
JD
107402011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10741
10742 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
10743
461c2ab9 107442011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
10745
10746 * nsterm.m (ns_menu_bar_is_hidden): New variable.
10747 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
10748 (ns_update_auto_hide_menu_bar): New functions.
10749 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
10750 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
10751 ns_constrain_all_frames.
10752 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
10753 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
10754
5c380ffb
JD
107552011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10756
10757 * nsmenu.m (runDialogAt): Remove argument to timer_check.
10758
9af30bdf
GM
107592011-03-27 Glenn Morris <rgm@gnu.org>
10760
10761 * syssignal.h: Replace RETSIGTYPE with void.
10762 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
10763 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
10764 Replace SIGTYPE with void everywhere.
10765 * s/usg5-4-common.h (SIGTYPE): Remove definition.
10766 * s/template.h (SIGTYPE): Remove commented out definition.
10767
e2abce01
JB
107682011-03-26 Eli Zaretskii <eliz@gnu.org>
10769
10770 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
10771 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
10772
f868cd8a
JB
107732011-03-26 Juanma Barranquero <lekktu@gmail.com>
10774
59eb0929
JB
10775 * w32.c (read_unc_volume): Use parameter `henum', instead of
10776 global variable `wget_enum_handle'.
10777
10778 * keymap.c (describe_vector): Remove parameters `indices' and
10779 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
10780 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
10781
f868cd8a
JB
10782 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
10783
10784 * keyboard.c (timer_check): Remove parameter `do_it_now',
10785 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
10786 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
10787 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
10788
10789 * keyboard.c (read_char):
10790 * w32menu.c (w32_menu_display_help):
10791 * xmenu.c (show_help_event, menu_help_callback):
10792 Adjust calls to `show_help_echo'.
10793
10794 * gtkutil.c (xg_maybe_add_timer):
10795 * keyboard.c (readable_events):
10796 * process.c (wait_reading_process_output):
10797 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
10798
10799 * insdel.c (adjust_markers_gap_motion):
10800 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
10801 (gap_left, gap_right): Don't call it.
10802
2ecf6fdb
CY
108032011-03-25 Chong Yidong <cyd@stupidchicken.com>
10804
10805 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
10806 incurred during fontification.
10807
6b1f9ba4
JB
108082011-03-25 Juanma Barranquero <lekktu@gmail.com>
10809
10810 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
10811 (DEFVAR_PER_BUFFER): Don't pass it.
10812
10813 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
10814 (scrolling_window): Don't pass it.
10815
0f4a96b5
JB
108162011-03-25 Juanma Barranquero <lekktu@gmail.com>
10817
10818 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
10819
10820 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
10821 and `suffix'.
10822 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
10823 of variables specific to SELinux and computation of `encoded_absname'.
10824
10825 * image.c (XPutPixel): Remove unused variable `height'.
10826
10827 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
10828
10829 * unexw32.c (get_section_info): Remove unused variable `section'.
10830
10831 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
10832 (system_process_attributes): Remove unused variable `sess'.
10833 (sys_read): Remove unused variable `err'.
10834
10835 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
10836 (w32_wnd_proc): Remove unused variable `isdead'.
10837 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
10838 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
10839 (x_create_tip_frame): Remove unused variable `tem'.
10840
10841 * w32inevt.c (w32_console_read_socket):
10842 Remove unused variable `no_events'.
10843
10844 * w32term.c (x_draw_composite_glyph_string_foreground):
10845 Remove unused variable `width'.
10846
1149507c
JB
108472011-03-24 Juanma Barranquero <lekktu@gmail.com>
10848
10849 * w32term.c (x_set_glyph_string_clipping):
10850 Don't pass uninitialized region to CombineRgn.
10851
9c88f339
JB
108522011-03-23 Juanma Barranquero <lekktu@gmail.com>
10853
10854 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
10855 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
10856 (Fx_close_connection): Remove unused variable `i'.
10857
10858 * w32font.c (w32font_draw): Return number of glyphs.
10859 (w32font_open_internal): Remove unused variable `i'.
10860 (w32font_driver): Add missing initializer.
10861
10862 * w32menu.c (utf8to16): Remove unused variable `utf16'.
10863 (fill_in_menu): Remove unused variable `items_added'.
10864
10865 * w32term.c (last_mouse_press_frame): Remove static global variable.
10866 (w32_clip_to_row): Remove unused variable `f'.
10867 (x_delete_terminal): Remove unused variable `i'.
10868
10869 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
10870 (NOTHING): Remove unused static global variable.
10871 (uniscribe_check_otf): Remove unused variable `table'.
10872 (uniscribe_font_driver): Add missing initializers.
10873
dee091a3
JD
108742011-03-23 Julien Danjou <julien@danjou.info>
10875
10876 * term.c (Fsuspend_tty, Fresume_tty):
10877 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
10878 * window.c (temp_output_buffer_show):
10879 * insdel.c (signal_before_change):
10880 * frame.c (Fhandle_switch_frame):
10881 * fileio.c (Fdo_auto_save):
10882 * emacs.c (Fkill_emacs):
10883 * editfns.c (save_excursion_restore):
10884 * cmds.c (internal_self_insert):
10885 * callint.c (Fcall_interactively):
10886 * buffer.c (Fkill_all_local_variables):
10887 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
10888 Use Frun_hooks.
0f4a96b5 10889 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 10890 unconditionally since it does the check itself.
dee091a3 10891
2c520ab5 108922011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 10893
c9c49752
PE
10894 Fix more problems found by GCC 4.5.2's static checks.
10895
8abc3f12
PE
10896 * coding.c (encode_coding_raw_text): Avoid unnecessary test
10897 the first time through the loop, since we know p0 < p1 then.
10898 This also avoids a gcc -Wstrict-overflow warning.
10899
a2d26660
PE
10900 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
10901 leading to a memory leak, possible in functions like
10902 load_charset_map_from_file that can allocate an unbounded number
b12ef411 10903 of objects (Bug#8318).
a2d26660 10904
916c72e9
PE
10905 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
10906 that could (at least in theory) be that large.
10907
19ab8a18
PE
10908 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
10909 This is less likely to overflow, and avoids undefined behavior if
10910 overflow does occur. All callers changed. Use strtoul to scan
10911 for the unsigned long integer.
b7cbbd6f
PE
10912 (pint2hrstr): Simplify and tune code slightly.
10913 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 10914
f0641eff
PE
10915 * scroll.c (do_scrolling): Work around GCC bug 48228.
10916 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
10917
7f650bb9
PE
10918 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
10919 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
10920 (validate_x_resource_name): Simplify count usage.
10921 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 10922
37dd57d1
PE
10923 * fileio.c (Fcopy_file): Report error if fchown or fchmod
10924 fail (Bug#8306).
81e56e61 10925
699979fc 10926 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 10927
401bf9b4
PE
10928 * process.c (Fmake_network_process): Use socklen_t, not int,
10929 where POSIX says socklen_t is required in portable programs.
10930 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 10931 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
10932 (Fmake_network_process, server_accept_connection):
10933 (wait_reading_process_output, read_process_output):
10934 Likewise.
10935
b93aacde
PE
10936 * process.c: Rename or move locals to avoid shadowing.
10937 (list_processes_1, Fmake_network_process):
10938 (read_process_output_error_handler, exec_sentinel_error_handler):
10939 Rename or move locals.
4dc343ee 10940 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 10941 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 10942 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 10943 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 10944 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 10945
af8a867c 10946 Make tparam.h and terminfo.c consistent.
44f230aa
SM
10947 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
10948 Include tparam.h instead, since it declares them.
af8a867c
PE
10949 * cm.h (PC): Remove extern decl; tparam.h now does this.
10950 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
10951 * terminfo.c: Include tparam.h, to check interfaces.
10952 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
10953 (tparam): Adjust signature to match interface in tparam.h;
10954 this removes some undefined behavior. Check that outstring and len
10955 are zero, which they always are with Emacs.
10956 * tparam.h (PC, BC, UP): New extern decls.
10957
0248044d 10958 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 10959 (xftfont_open): Rename locals to avoid shadowing.
0248044d 10960
8ff096c1 10961 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
10962 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
10963 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 10964 (ftfont_list): Remove unused local.
49eaafba
PE
10965 (get_adstyle_property, ftfont_pattern_entity):
10966 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
10967 Rename locals to avoid shadowing.
8ff096c1 10968
e2be39f6
PE
10969 * xfont.c (xfont_list_family): Mark var as initialized.
10970
c9735e30
PE
10971 * xml.c (make_dom): Now static.
10972
8f5201ae
PE
10973 * composite.c (composition_compute_stop_pos): Rename local to
10974 avoid shadowing.
b246f932
PE
10975 (composition_reseat_it): Remove unused locals.
10976 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 10977 (composition_update_it): Mark var as initialized.
11b61122
PE
10978 (find_automatic_composition): Mark vars as initialized,
10979 with a FIXME (Bug#8290).
8f5201ae 10980
760fbc2c
PE
10981 character.h: Rename locals to avoid shadowing.
10982 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
10983 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
10984 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
10985 (BUF_DEC_POS): Be more systematic about renaming local temporaries
10986 to avoid shadowing.
10987
ff08eb85
PE
10988 * textprop.c (property_change_between_p): Remove; unused.
10989
fc7bf025
PE
10990 * intervals.c (interval_start_pos): Now static.
10991
235d7abc
PE
10992 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
10993
44f230aa
SM
10994 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
10995 Rename locals to avoid shadowing.
3e7d6594 10996
50060332
PE
10997 * sound.c (wav_play, au_play, Fplay_sound_internal):
10998 Fix pointer signedness.
d01f234b 10999 (alsa_choose_format): Remove unused local var.
c83b8872
PE
11000 (wav_play): Initialize a variable to 0, to prevent undefined
11001 behavior (Bug#8278).
50060332 11002
c4fc4e30
PE
11003 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
11004
918436ed
PE
11005 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
11006
c939f91b
PE
11007 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
11008 clobbering (Bug#8298).
b9c7f648
PE
11009 * sysdep.c (sys_subshell): Likewise.
11010 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 11011
6bd8c144
PE
11012 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
11013 This should get cleaned up, so that child_setup has the
11014 same signature on all platforms.
11015
7710357c 11016 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 11017 (relocate_fd): Rename locals to avoid shadowing.
7710357c 11018
c59da222
CY
110192011-03-22 Chong Yidong <cyd@stupidchicken.com>
11020
11021 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
11022 not to be necessary, and produces flickering.
11023
66b87493
GM
110242011-03-20 Glenn Morris <rgm@gnu.org>
11025
11026 * config.in: Remove file.
11027
45b6f6d5
JB
110282011-03-20 Juanma Barranquero <lekktu@gmail.com>
11029
11030 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
11031 are now in src/globals.h.
11032 (syms_of_minibuf): Remove spurious & from previous change.
11033
cd394be1 110342011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
11035
11036 * minibuf.c (completing-read-function): New variable.
11037 (completing-read-default): Rename from completing-read.
11038 (completing-read): Call completing-read-function.
11039
b14e3e21
CY
110402011-03-19 Juanma Barranquero <lekktu@gmail.com>
11041
11042 * xfaces.c (Fx_load_color_file):
11043 Read color file from absolute filename (bug#8250).
11044
f2b726e6
JB
110452011-03-19 Juanma Barranquero <lekktu@gmail.com>
11046
11047 * makefile.w32-in: Update dependencies.
11048
09f6ff02
EZ
110492011-03-17 Eli Zaretskii <eliz@gnu.org>
11050
11051 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
11052
29a6015a
PE
110532011-03-17 Paul Eggert <eggert@cs.ucla.edu>
11054
a3a6c54e
PE
11055 Fix more problems found by GCC 4.5.2's static checks.
11056
b766f867
PE
11057 * process.c (make_serial_process_unwind, send_process_trap):
11058 (sigchld_handler): Now static.
11059
be02381c
PE
11060 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
11061 That way, the code declares only the vars that it needs.
11062 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
11063 * s/cygwin.h (PTY_ITERATION): Likewise.
11064 * s/darwin.h (PTY_ITERATION): Likewise.
11065 * s/gnu-linux.h (PTY_ITERATION): Likewise.
11066
57048744
PE
11067 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
11068 * process.c (allocate_pty): Don't declare stb unless it's needed.
11069
7914961c 11070 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
11071 (CONSTANTLIM): Remove; unused.
11072 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
11073 Define only if needed.
7914961c 11074
b3967b18
PE
11075 * unexelf.c (unexec): Name an expression,
11076 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
11077 Use a different way to cause a compilation error if anyone uses
11078 n rather than nn, a way that does not involve shadowing.
73366a00 11079 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 11080
29a6015a
PE
11081 * deps.mk (unexalpha.o): Remove; unused.
11082
43cfc33e 11083 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 11084 * unexec.h: New file.
ce701a33
PE
11085 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
11086 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
11087 Depend on unexec.h.
11088 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
11089 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
11090 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 11091 Change as necessary to match prototype in unexec.h.
ce701a33 11092
01f44d5a
PE
11093 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
11094 shadowing.
4f63c6bb 11095 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 11096
a6670b0b
PE
11097 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
11098 Rename locals to avoid shadowing.
11099
cef2010d 11100 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 11101 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 11102
d4d7173a
PE
11103 * print.c (Fredirect_debugging_output): Fix pointer signedess.
11104
f08b802a
PE
11105 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
11106 warning when compiling print.c.
11107
3ddb0639
PE
11108 * font.c (font_unparse_fcname): Abort in an "impossible" situation
11109 instead of using an uninitialized var.
5ad03b97 11110 (font_sort_entities): Mark var as initialized.
3ddb0639 11111
170a2692
PE
11112 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
11113
e663c700
PE
11114 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
11115 pointers to constants.
89bc529a 11116 (font_parse_fcname): Remove unused vars.
7b81e2d0 11117 (font_delete_unmatched): Now static.
ea838e10 11118 (font_get_spec): Remove; unused.
13a547c6
PE
11119 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
11120 (font_update_drivers, Ffont_get_glyphs, font_add_log):
11121 Rename or move locals to avoid shadowing.
e663c700 11122
2a80c887 11123 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 11124 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 11125
1384fa33 11126 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 11127 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 11128
8b2c52e9
PE
11129 * alloc.c (mark_backtrace): Move decl from here ...
11130 * lisp.h: ... to here, so that it can be checked.
11131
475545b5 11132 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 11133 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
11134 (lisp_indirect_variable): Name an expression,
11135 to avoid gcc -Wbad-function-cast warning.
1faed8ae 11136 (Fdefvar): Rename locals to avoid shadowing.
475545b5 11137
b1349114 11138 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 11139 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 11140 Use const pointer when appropriate.
b1349114 11141
a2928364
PE
11142 * lisp.h (get_system_name, get_operating_system_release):
11143 Move decls here, to check interfaces.
11144 * process.c (get_operating_system_release): Move decl to lisp.h.
11145 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
11146 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
11147 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
11148 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
11149 (Fformat_time_string, Fencode_time, Finsert_char):
11150 (Ftranslate_region_internal, Fformat):
11151 Rename or remove local vars to avoid shadowing.
9710023e 11152 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 11153
a415e694
PE
11154 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
11155 avoid shadowing.
11156
8ef4622d
PE
11157 * lisp.h (eassert): Check that the argument compiles, even if
11158 ENABLE_CHECKING is not defined.
11159
946f9a5b
PE
11160 * data.c (Findirect_variable): Name an expression, to avoid
11161 gcc -Wbad-function-cast warning.
112396d6 11162 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 11163 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
11164 (Fmake_variable_buffer_local, Fmake_local_variable):
11165 Mark variables as initialized.
52746918 11166 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 11167
e5aab7e7 11168 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
11169 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
11170 Rename locals to avoid shadowing.
dff45157
PE
11171 (mark_stack): Move local variables into the #ifdef region where
11172 they're used.
7bc26fdb
PE
11173 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
11174 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
11175 needed otherwise.
11176 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
11177 (GC_STRING_CHARS): Remove; not used.
d40d4be1 11178 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 11179
e5aab7e7
PE
11180 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
11181 avoids undefined behavior in theory.
11182
4da60324
PE
11183 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
11184
88043301
PE
11185 Use functions, not macros, for up- and down-casing (Bug#8254).
11186 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11187 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
11188 to use the following functions instead of these macros.
11189 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
11190 EMACS_INT, since callers assume the returned value fits in int.
11191 (upcase1): Likewise, for UPCASE_TABLE.
11192 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 11193 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 11194 the race-condition problem in the old DOWNCASE.
88043301 11195
19ed5445
PE
11196 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
11197 Rename locals to avoid shadowing.
11198 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
11199 (regex_compile, re_search_2, re_match_2_internal):
11200 Remove unused local vars.
952db0d7
PE
11201 (FREE_VAR): Rewrite so as not to use empty "else",
11202 which gcc can warn about.
da053e48 11203 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
11204 (RETALLOC_IF): Define only if needed.
11205 (WORDCHAR_P): Likewise. This one is never needed, but is used
11206 only in a comment talking about a compiler bug, so put inside
11207 the #if 0 of that comment.
11208 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
11209 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
11210 Remove; unused.
19ed5445 11211
1f3561e4 11212 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
11213 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
11214 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 11215
ded6f8f7
PE
11216 * search.c (simple_search): Remove unused var.
11217
dbd37a95
PE
11218 * dired.c (compile_pattern): Move decl from here ...
11219 * lisp.h: ... to here, so that it can be checked.
11220 (struct re_registers): New forward decl.
11221
7e47afad
PE
11222 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
11223
85f24f61
PE
11224 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
11225 All uses changed.
11226 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
11227 Rename locals to avoid shadowing.
5671df8f 11228 (Fvertical_motion): Mark locals as initialized.
85f24f61 11229
181aa2be 11230 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 11231 (casify_region): Mark local as initialized.
181aa2be 11232
930d429c
PE
11233 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
11234
7082eac6
PE
11235 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
11236 New macros, so that the caller can use some names other than
11237 gcpro1, gcpro2, etc.
11238 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
11239 of the new macros.
11240 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
11241 argument, for consistency with GCPRO2_VAR, etc: it is now the
11242 prefix of the variable, not the variable itself. All uses
11243 changed.
38b2c076
PE
11244 * dired.c (directory_files_internal, file_name_completion):
11245 Rename locals to avoid shadowing.
11246
15206ed9
PE
11247 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
11248 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
11249 dired.c's scmp function, had undefined behavior.
11250 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11251 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
11252 * buffer.h: ... to here, because these macros use current_buffer,
11253 and the new implementation with inline functions needs to have
11254 current_buffer in scope now, rather than later when the macros
11255 are used.
11256 (downcase, upcase1): New static inline functions.
11257 (DOWNCASE, UPCASE1): Reimplement using these functions.
11258 This avoids undefined behavior in expressions like
11259 DOWNCASE (x) == DOWNCASE (y), which previously suffered
11260 from race conditions in accessing the global variables
11261 case_temp1 and case_temp2.
11262 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
11263 * lisp.h (case_temp1, case_temp2): Remove their decls.
11264 * character.h (ASCII_CHAR_P): Move from here ...
11265 * lisp.h: ... to here, so that the inline functions mentioned
11266 above can use them.
11267
4a6bea26
PE
11268 * dired.c (directory_files_internal_unwind): Now static.
11269
f14b7e14
PE
11270 * fileio.c (file_name_as_directory, directory_file_name):
11271 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
11272 Now static.
2893f146
PE
11273 (file_name_as_directory): Use const pointers when appropriate.
11274 (Fexpand_file_name): Likewise. In particular, newdir might
11275 point at constant storage, so make it a const pointer.
fd4ead52 11276 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
11277 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
11278 signedness issues.
f839df0c
PE
11279 (Fset_file_times, Finsert_file_contents, auto_save_error):
11280 Rename locals to avoid shadowing.
f14b7e14 11281
5716756e 11282 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
11283 (Ftry_completion, Fall_completions): Rename or remove locals
11284 to avoid shadowing.
5716756e 11285
b4c3046a
PE
11286 * marker.c (bytepos_to_charpos): Remove; unused.
11287
b45db522
PE
11288 * lisp.h (verify_bytepos, count_markers): New decls,
11289 so that gcc does not warn that these functions aren't declared.
11290
85876d07
PE
11291 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
11292 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 11293 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 11294 (copy_text): Remove unused local var.
85876d07 11295
03d78a21 11296 * filelock.c (within_one_second): Now static.
b3dd38ab 11297 (lock_file_1): Rename local to avoid shadowing.
03d78a21 11298
5df8f01b
PE
11299 * buffer.c (fix_overlays_before): Mark locals as initialized.
11300 (fix_start_end_in_overlays): Likewise. This function should be
11301 simplified by using pointers-to-pointers, but that's a different
11302 matter.
b1d876f1 11303 (switch_to_buffer_1): Now static.
8f54f30a
PE
11304 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
11305 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 11306
a70072c9 11307 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 11308 Fix pointer signedness issue.
edced198
PE
11309 (sys_subshell): Mark local as volatile if checking for lint,
11310 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 11311 (MAXPATHLEN): Define only if needed.
a70072c9 11312
a0977c44
PE
11313 * process.c (serial_open, serial_configure): Move decls from here ...
11314 * systty.h: ... to here, so that they can be checked.
11315
a884fdcc
PE
11316 * fns.c (get_random, seed_random): Move extern decls from here ...
11317 * lisp.h: ... to here, so that they can be checked.
11318
604efe86 11319 * sysdep.c (reset_io): Now static.
b8950c94 11320 (wait_for_termination_signal): Remove; unused.
604efe86 11321
38fc62d9
PE
11322 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
11323 (copy_keymap_item, append_key, push_text_char_description):
11324 Now static.
1004a21a 11325 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 11326 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
11327 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
11328 (describe_map_tree):
11329 Rename locals to avoid shadowing.
38fc62d9 11330
2f2650da
PE
11331 * keyboard.c: Declare functions static if they are not used elsewhere.
11332 (echo_char, echo_dash, cmd_error, top_level_2):
11333 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
11334 (read_char, kbd_buffer_get_event, make_lispy_position):
11335 (make_lispy_event, make_lispy_movement, apply_modifiers):
11336 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
11337 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
11338 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 11339 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 11340 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 11341
a053e86c 11342 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
11343 (mark_kboards): Move decl here ...
11344 * alloc.c (mark_kboards): ... from here.
a053e86c 11345
4752793e
PE
11346 * lisp.h (force_auto_save_soon): New decl.
11347
74f10ca7 11348 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
11349 (DEFINE_DUMMY_FUNCTION): New macro.
11350 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
11351 Use it.
c03cd23f
PE
11352 (main): Add casts to avoid warnings
11353 if GCC considers string literals to be constants.
74f10ca7 11354
022e70d4
PE
11355 * lisp.h (fatal_error_signal): Add decl, since it's exported.
11356
59d6fe83
PE
11357 * dbusbind.c: Pointer signedness fixes.
11358 (xd_signature, xd_append_arg, xd_initialize):
11359 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11360 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11361 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
11362 (Fdbus_register_signal): Use SSDATA when the context wants char *.
11363
78320123
PE
11364 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
11365 if GCC considers string literals to be constants.
49cebcca 11366 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 11367
35ac2a97
SM
113682011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
11369
fb103ca9
SM
11370 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
11371 (print_preprocess, print_object): New macro to fix last change.
11372
35ac2a97
SM
11373 * print.c (print_preprocess): Don't forget font objects.
11374
62973b41
JB
113752011-03-16 Juanma Barranquero <lekktu@gmail.com>
11376
11377 * emacs.c (USAGE3): Doc fixes.
11378
0e48bb22
AS
113792011-03-15 Andreas Schwab <schwab@linux-m68k.org>
11380
11381 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
11382 structure.
11383
7684e57b
JB
113842011-03-14 Juanma Barranquero <lekktu@gmail.com>
11385
11386 * lisp.h (VWindow_system, Qfile_name_history):
11387 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
11388 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
11389 (w32_system_caret_x, w32_system_caret_y): Declare extern.
11390
11391 * w32select.c: Don't #include "keyboard.h".
c96bbc66 11392 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
11393
11394 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
11395 * w32console.c (detect_input_pending, read_input_pending)
11396 (encode_terminal_code):
11397 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
11398 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
11399 (w32_system_caret_y, Qfile_name_history):
11400 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
11401 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
11402 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
11403 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
11404 * w32proc.c (Qlocal, report_file_error):
11405 * w32term.c (Vwindow_system, updating_frame):
11406 * w32uniscribe.c (initialized, uniscribe_font_driver):
11407 Remove unneeded extern declarations.
11408
2aa46d6c
CY
114092011-03-14 Chong Yidong <cyd@stupidchicken.com>
11410
c96bbc66 11411 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 11412
cffc6f3b
CY
114132011-03-13 Chong Yidong <cyd@stupidchicken.com>
11414
11415 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
11416 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
11417 These macros can no longer be used for assignment.
11418
44f230aa
SM
11419 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
11420 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
11421 (record_buffer_markers, fetch_buffer_markers): New functions for
11422 recording and fetching special buffer markers.
11423 (set_buffer_internal_1, set_buffer_temp): Use them.
11424
11425 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
11426
11427 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
11428
11429 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
11430 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
11431
11432 * xdisp.c (hscroll_window_tree):
11433 (reconsider_clip_changes): Use PT instead of BUF_PT.
11434
d251f04b
EZ
114352011-03-13 Eli Zaretskii <eliz@gnu.org>
11436
11437 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
11438 $(EMACS_ROOT)/lib/intprops.h.
11439
f0c77cd1
PE
114402011-03-13 Paul Eggert <eggert@cs.ucla.edu>
11441
3eca4629
PE
11442 Fix more problems found by GCC 4.5.2's static checks.
11443
7c86ee98
PE
11444 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
11445 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
11446 (xg_free_frame_widgets): Make it clear that a local variable is
11447 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
11448 (gdk_window_get_screen): Make it clear that this macro is needed
11449 only if USE_GTK_TOOLTIP.
1e5524e7
PE
11450 (int_gtk_range_get_value): New function, which avoids a diagnostic
11451 from gcc -Wbad-function-cast.
11452 (xg_set_toolkit_scroll_bar_thumb): Use it.
11453 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
11454 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
11455 (get_utf8_string, xg_get_file_with_chooser):
11456 Rename locals to avoid shadowing.
11457 (create_dialog): Move locals to avoid shadowing.
7c86ee98 11458
41729b81
PE
11459 * xgselect.c (xg_select): Remove unused var.
11460
f0c77cd1
PE
11461 * image.c (four_corners_best): Mark locals as initialized.
11462 (gif_load): Initialize transparent_p to zero (Bug#8238).
11463 Mark another local as initialized.
ec6cf4c6 11464 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 11465
ce0ad53d 11466 * image.c (clear_image_cache): Now static.
d5d5a617 11467 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 11468 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
11469 (x_edge_detection): Remove unnecessary cast that
11470 gcc -Wbad-function-cast diagnoses.
2037898d 11471 (gif_load): Fix pointer signedness.
6ae141d6
PE
11472 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
11473 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 11474
33383987 114752011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 11476
d32df629
PE
11477 Improve quality of tests for time stamp overflow.
11478 For example, without this patch (encode-time 0 0 0 1 1
11479 1152921504606846976) returns the obviously-bogus value (-948597
11480 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
11481 reports time overflow. See
11482 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
11483 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
11484 * editfns.c: Include limits.h and intprops.h.
11485 (TIME_T_MIN, TIME_T_MAX): New macros.
11486 (time_overflow): Move earlier, to before first use.
11487 (hi_time, lo_time): New functions, for an accurate test for
11488 out-of-range times.
11489 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
11490 (Fget_internal_run_time): Don't assume time_t fits in int.
11491 (make_time): Use list2 instead of Fcons twice.
11492 (Fdecode_time): More accurate test for out-of-range times.
11493 (check_tm_member): New function.
11494 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
11495 (lisp_time_argument): Don't rely on undefined left-shift and
11496 right-shift behavior when checking for time stamp overflow.
8be6f318 11497
fe31d94c
PE
11498 * editfns.c (time_overflow): New function, refactoring common code.
11499 (Fformat_time_string, Fdecode_time, Fencode_time):
11500 (Fcurrent_time_string): Use it.
11501
8be6f318
PE
11502 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
11503 * dired.c (make_time): Move to ...
11504 * editfns.c (make_time): ... here.
11505 * systime.h: Note the move.
11506
09d9db2c 115072011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 11508
126bc0dc
YM
11509 * fringe.c (update_window_fringes): Remove unused variables.
11510
c47cbdfd
YM
11511 * unexmacosx.c (copy_data_segment): Also copy __got section.
11512 (Bug#8223)
11513
7ac80be9
EZ
115142011-03-12 Eli Zaretskii <eliz@gnu.org>
11515
c96bbc66 11516 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
11517 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
11518 Constify `char *' arguments and their references according to
11519 prototypes in tparam.h.
11520
ecb0f94d 11521 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 11522
7ac80be9
EZ
11523 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
11524 Adapt all references accordingly.
11525
11526 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
11527
ef1fd07e
TT
115282011-03-11 Tom Tromey <tromey@redhat.com>
11529
11530 * buffer.c (syms_of_buffer): Remove obsolete comment.
11531
7ef4b50c
EZ
115322011-03-11 Eli Zaretskii <eliz@gnu.org>
11533
11534 * termhooks.h (encode_terminal_code): Declare prototype.
11535
11536 * msdos.c (encode_terminal_code): Don't declare prototype.
11537
11538 * term.c (encode_terminal_code): Now external again, used by
11539 w32console.c and msdos.c.
11540
44f230aa
SM
11541 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
11542 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 11543
4b1ec863 115442011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 11545
1714f52b 11546 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 11547
4b1ec863
PE
11548 * fringe.c (update_window_fringes): Mark locals as initialized
11549 (Bug#8227).
11550 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 11551
524c7aa6
PE
11552 * alloc.c (mark_fringe_data): Move decl from here ...
11553 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
11554 to check its interface.
11555 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
11556
a5c0af81 11557 * fontset.c (free_realized_fontset): Now static.
7519b8cd 11558 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 11559 (fontset_font): Mark local as initialized.
a9a06e0b 11560 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 11561
b4716021
PE
11562 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
11563
811e9bac 11564 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 11565 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
11566 (x_own_selection, Fx_disown_selection_internal): Rename locals
11567 to avoid shadowing.
11568 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 11569
7e3ab302
PE
11570 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
11571 so that the caller can use some name other than gcpro1.
11572 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
11573 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11574 (Fx_backspace_delete_keys_p):
11575 Use them to avoid shadowing, and rename vars to avoid shadowing.
11576 (x_decode_color, x_set_name, x_window): Now static.
6b437900 11577 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 11578 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
11579 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
11580 Remove unused locals.
7e3ab302
PE
11581 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11582 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
11583 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
11584 macros.
f78faa98 11585
e2b13473
PE
11586 * xterm.h (x_mouse_leave): New decl.
11587
77f23912
PE
11588 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
11589 Remove unused functions.
cdf4ba58
PE
11590 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
11591 (x_calc_absolute_position): Now static.
7411c686 11592 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 11593 Don't declare local "event" unless it's used.
ed7bf3a5
PE
11594 (x_iconify_frame, x_free_frame_resources): Don't declare locals
11595 unless they are used.
38d0b34a
PE
11596 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
11597 (x_fatal_error_signal): Remove; not used.
a6067996
PE
11598 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
11599 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
11600 (x_error_catcher, x_connection_closed, x_error_handler):
11601 (x_error_quitter, xembed_send_message, x_iconify_frame):
11602 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 11603 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 11604 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 11605
44f230aa
SM
11606 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
11607 Rename or move locals to avoid shadowing.
6b463e58 11608 (tty_defined_color, merge_face_heights): Now static.
5967d051 11609 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
11610 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
11611 does not deduce is never used uninitialized.
73719eba
PE
11612 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
11613 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 11614
426994c3 11615 * terminal.c (store_terminal_param): Now static.
5489860b 11616
032f1620 11617 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 11618 (set_frame_menubar): Remove unused local.
d4323972 11619 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
11620 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
11621 since they might point to immutable storage.
281585b0
PE
11622 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
11623 since it's unused otherwise.
032f1620 11624
367c19e5 11625 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 11626 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
11627 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
11628 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 11629 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
11630 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
11631 does not deduce are never used uninitialized.
70739cbe 11632
07b48fa9
PE
11633 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
11634
8868a238 11635 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
11636 * window.c (window_loop, size_window):
11637 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 11638
7e5cf297 11639 * window.c (display_buffer): Now static.
d6550a9f
PE
11640 (size_window): Mark variables that gcc -Wuninitialized
11641 does not deduce are never used uninitialized.
a586633d
PE
11642 * window.h (check_all_windows): New decl, to forestall
11643 gcc -Wmissing-prototypes diagnostic.
5b555da1 11644 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 11645
f6095868
PE
11646 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
11647 shadowing.
11648 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
11649 Include <limits.h>.
11650 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
11651 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
11652 (load_charset_map): Mark variables that gcc -Wuninitialized
11653 does not deduce are never used uninitialized.
53df7c11 11654 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 11655
f38b440c
PE
11656 * coding.c (coding_set_source, coding_set_destination):
11657 Use "else { /* comment */ }" rather than "else /* comment */;"
11658 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
11659 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
11660 a block, when the outer 'i' will do.
11661 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
11662 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
11663 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
11664 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
11665 (Fdecode_sjis_char, Fdefine_coding_system_internal):
11666 Rename locals to avoid shadowing.
11667 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
11668 * coding.c (emacs_mule_char, encode_invocation_designation):
11669 Now static, since they're not used elsewhere.
413bb2db 11670 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 11671 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
11672 (decode_coding_emacs_mule): Mark variables that gcc
11673 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
11674 (detect_coding_iso_2022): Initialize a local variable that might
11675 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 11676 this initialization is needed. (Bug#8211)
5f58e762
PE
11677 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
11678 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
11679 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
11680 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
11681 Remove unused macros.
f38b440c 11682
232b38b9 11683 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 11684 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 11685 * character.c (string_count_byte8): Likewise.
232b38b9 11686
fb90da1b
PE
11687 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
11688 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
11689
fb93dbc2
PE
11690 * chartab.c (copy_sub_char_table): Now static, since it's not used
11691 elsewhere.
5c156ace
PE
11692 (sub_char_table_ref_and_range, char_table_ref_and_range):
11693 Rename locals to avoid shadowing.
bbcd0949 11694 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 11695
7d3b3862 11696 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 11697 (BIDI_BOB): Remove unused macro.
7d3b3862 11698
6be7d3da
PE
11699 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
11700 deduce are never used uninitialized.
c2ed9c8b 11701 * term.c (encode_terminal_code): Likewise.
6be7d3da 11702
75f8807f 11703 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 11704
50938595
PE
11705 * tparam.h: New file.
11706 * term.c, tparam.h: Include it.
11707 * deps.mk (term.o, tparam.o): Depend on tparam.h.
11708 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
11709 Move these decls to tparam.h, and make them agree with what
11710 is actually in tparam.c. The previous trick of using incompatible
11711 decls in different modules does not conform to the C standard.
11712 All callers of tparam changed to use tparam's actual API.
11713 * tparam.c (tparam1, tparam, tgoto):
11714 Use const pointers where appropriate.
11715
fbceeba2
PE
11716 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
11717 * cm.h (struct cm): Likewise.
11718 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
11719 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
11720 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
11721 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
11722 (turn_on_face, init_tty): Likewise.
11723 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 11724
7f3f1250
PE
11725 * term.c (term_mouse_position): Rename local to avoid shadowing.
11726
e6ca6543
PE
11727 * alloc.c (mark_ttys): Move decl from here ...
11728 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
11729
c40f8d15
AS
117302011-03-11 Andreas Schwab <schwab@linux-m68k.org>
11731
11732 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
11733
cfe0661d
JB
117342011-03-09 Juanma Barranquero <lekktu@gmail.com>
11735
11736 * search.c (compile_pattern_1): Remove argument regp, unused since
11737 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
11738 (compile_pattern): Don't pass it.
11739
0afb4571
J
117402011-03-08 Jan Djärv <jan.h.d@swipnet.se>
11741
11742 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
11743 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
11744 for ! HAVE_GTK3.
11745 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
11746
11747 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
11748
11749 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
11750 gdk_window_get_screen, gdk_window_get_geometry,
11751 gdk_x11_window_lookup_for_display and GDK_KEY_g.
11752 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
11753 (xg_get_pixbuf_from_pixmap): New function.
11754 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
11755 to Pixmap, take frame as parameter, remove GdkColormap parameter.
11756 Call xg_get_pixbuf_from_pixmap instead of
11757 gdk_pixbuf_get_from_drawable.
11758 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
11759 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
11760 (xg_check_special_colors): Use GtkStyleContext and its functions
11761 for HAVE_GTK3.
11762 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
11763 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
11764 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
11765 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
11766 Call gtk_widget_get_preferred_size.
0afb4571
J
11767 (xg_frame_resized): gdk_window_get_geometry only takes 5
11768 parameters.
44f230aa
SM
11769 (xg_win_to_widget, xg_event_is_for_menubar):
11770 Call gdk_x11_window_lookup_for_display.
0afb4571
J
11771 (xg_set_widget_bg): New function.
11772 (delete_cb): New function.
895009e1 11773 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 11774 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
11775 (xg_set_background_color): Call xg_set_widget_bg.
11776 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
11777 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
11778 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
11779 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
11780 if ! HAVE_GTK3.
11781 (update_frame_tool_bar): Call gtk_widget_hide.
11782 (xg_initialize): Use GDK_KEY_g.
11783
11784 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
11785 if ! HAVE_GTK3
11786 (x_session_initialize): Call gdk_x11_set_sm_client_id.
11787
11788 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
11789 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
11790 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
11791
1c2cc4ef
JB
117922011-03-08 Juanma Barranquero <lekktu@gmail.com>
11793
11794 * w32xfns.c (select_palette): Check success of RealizePalette against
11795 GDI_ERROR, not zero.
11796
33383987 11797See ChangeLog.11 for earlier changes.
aac0c6e3
MR
11798
11799;; Local Variables:
11800;; coding: utf-8
aac0c6e3
MR
11801;; End:
11802
2f097256 11803 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
11804
11805 This file is part of GNU Emacs.
11806
11807 GNU Emacs is free software: you can redistribute it and/or modify
11808 it under the terms of the GNU General Public License as published by
11809 the Free Software Foundation, either version 3 of the License, or
11810 (at your option) any later version.
11811
11812 GNU Emacs is distributed in the hope that it will be useful,
11813 but WITHOUT ANY WARRANTY; without even the implied warranty of
11814 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11815 GNU General Public License for more details.
11816
11817 You should have received a copy of the GNU General Public License
11818 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.