Avoid weird behavior with large horizontal scrolls.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
dea7f1e5
PE
12012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2
24a212eb
PE
3 Avoid weird behavior with large horizontal scrolls.
4 Without this change, for example, large hscroll values would
5 mess up Emacs's display on Fedora 15 x86, presumably due to
6 overflows in int calculations in the display code.
7 Also, if buffers had long lines, Emacs would freeze.
8 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
9 (set_window_hscroll): New function, containing the old guts of
10 Fset_window_hscroll. Return the clipped value.
11 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
12 This avoids the need to check against PTRDIFF_MAX.
13
dea7f1e5
PE
14 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
15
76046526
DA
162012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
17
18 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
19
39adff0d
PE
202012-07-04 Paul Eggert <eggert@cs.ucla.edu>
21
63807d47
PE
22 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
23 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
24 since GCC 4.4.6 issues a bogus warning for them.
25
39adff0d
PE
26 Fix bugs in file timestamp newness comparisons.
27 * fileio.c (Ffile_newer_than_file_p):
28 * lread.c (Fload): Use full timestamp resolution of files,
29 not just the 1-second resolution, so that files that are only
30 slightly newer still count as newer.
31 * fileio.c (Ffile_newer_than_file_p): Don't assume file
32 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
33
dbeed9a6
PE
342012-07-03 Paul Eggert <eggert@cs.ucla.edu>
35
36 * fileio.c: Improve handling of file time marker. (Bug#11852)
37 (special_mtime): New function.
38 (Finsert_file_contents, Fverify_visited_file_modtime):
39 Use it to set special mtime values consistently.
40
636334d6
AS
412012-07-03 Andreas Schwab <schwab@linux-m68k.org>
42
43 * fileio.c (Finsert_file_contents): Properly handle st_mtime
44 marker for non-existing file. (Bug#11852)
45
e2017fe2
GM
462012-07-03 Glenn Morris <rgm@gnu.org>
47
48 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
49 and did not make it into globals.h).
50
404dbd37
TT
512012-07-03 Tom Tromey <tromey@redhat.com>
52
53 * window.c (Fset_window_margins, Fset_window_fringes)
54 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
55 * textprop.c (Fprevious_property_change): No longer static.
56 * syntax.c (Fsyntax_table_p): No longer static.
57 * process.c (Fget_process, Fprocess_datagram_address): No longer
58 static.
59 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
60 * keyboard.c (Fcommand_execute): No longer static.
61 Remove EXFUN.
62 * insdel.c (Fcombine_after_change_execute): No longer static.
63 * image.c (Finit_image_library): No longer static.
64 * fileio.c (Fmake_symbolic_link): No longer static.
65 * eval.c (Ffetch_bytecode): No longer static.
66 * editfns.c (Fuser_full_name): No longer static.
67 * doc.c: (Fdocumentation_property, Fsnarf_documentation): No
68 longer static.
69 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
70 static.
71 * dired.c (Ffile_attributes): No longer static.
72 * composite.c (Fcomposition_get_gstring): No longer static.
73 * callproc.c (Fgetenv_internal): No longer static.
74
75 * ccl.h: Remove EXFUNs.
76 * buffer.h: Remove EXFUNs.
77 * dispextern.h: Remove EXFUNs.
78 * intervals.h: Remove EXFUNs.
79 * fontset.h: Remove EXFUN.
80 * font.h: Remove EXFUNs.
81 * dosfns.c (system_process_attributes): Remove EXFUN.
82 * keymap.h: Remove EXFUNs.
83 * lisp.h: Remove EXFUNs.
84 * w32term.h: Remove EXFUNs.
85 * window.h: Remove EXFUNs.
86 * xsettings.h: Remove EXFUN.
87 * xterm.h: Remove EXFUN.
88
8e4fd1e1
GM
892012-07-03 Glenn Morris <rgm@gnu.org>
90
91 * lisp.h (Frandom): Make it visible to C.
92 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
93 buffer for invisible buffers. (Bug#1229)
94
ca95b3eb
DA
952012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
96
97 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
98 values which aren't power of 2.
99 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
100 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
101 accordingly.
102
7555c33f
SM
1032012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
104
105 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
106
107 * alloc.c (mark_object): Revert part of last patch to use `switch'.
108
d12e8f5a
DA
1092012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
110
111 * alloc.c (allocate_vector_block): Remove redundant
112 calls to mallopt if DOUG_LEA_MALLOC is defined.
113 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
114 avoid calls to mallopt if zero_vector is returned.
115
296094c3
DA
1162012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
117
118 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
119 is enabled, avoid dereferencing NULL current_sblock if
120 running undumped.
121
36429c89
DA
1222012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
123
124 Cleanup basic buffer management.
125 * buffer.h (struct buffer): Change layout to use generic vector
126 marking code. Fix some comments. Change type of 'clip_changed'
127 to bitfield. Remove unused #ifndef old.
128 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
129 (GET_OVERLAYS_AT): Fix indentation.
130 (for_each_per_buffer_object_at): New macro.
131 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
132 (Fbuffer_local_variables): Use it.
133 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
134 * alloc.c (allocate_buffer): Adjust to match new layout of
135 struct buffer. Fix comment.
136 (mark_overlay): New function.
137 (mark_buffer): Use it. Use mark_vectorlike to mark normal
138 Lisp area of struct buffer.
139 (mark_object): Use it. Adjust marking of misc objects
140 and related comments.
141
3b3e4cac
PE
1422012-07-02 Paul Eggert <eggert@cs.ucla.edu>
143
144 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
145 wrapper that is not needed because the wrapped code is a no-op (zero
146 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
147 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
148
cf5c0175
DA
1492012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
150
151 * alloc.c (mark_buffer): Simplify. Remove prototype.
152 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 153 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
154 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
155 redundant calls to mark_vectorlike for bool vectors.
156
ca26824c
GM
1572012-06-30 Glenn Morris <rgm@gnu.org>
158
2e4c5312
GM
159 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
160
ca26824c
GM
161 * epaths.in (PATH_SITELOADSEARCH): New.
162 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
163 This is rather than relying on --enable-locallisppath elements
164 having "site-lisp" in their names. (Bug#10208#25, 11658)
165
0d23c240
EZ
1662012-06-30 Eli Zaretskii <eliz@gnu.org>
167
c9240d7a
EZ
168 * w32proc.c (sys_select): Accept and ignore one more argument.
169
170 * w32.c (emacs_gnutls_pull): Call select with one more argument.
171
0d23c240 172 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 173 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
174
175 * sysdep.c: Don't include dos.h and dosfns.h.
176
177 * process.c (sys_select):
178 * msdos.c (sys_select): Accept one more argument and ignore it.
179
180 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
181 adapt data types and code to that.
182
183 * dosfns.c:
184 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
185 which clashes with the gnulib function of the same name.
186
af5a5a98
AS
1872012-06-30 Andreas Schwab <schwab@linux-m68k.org>
188
c5e4379c
AS
189 * font.c (font_style_to_value, font_style_symbolic)
190 (font_prop_validate_style): Add type checks for values in
191 font_style_table.
192
af5a5a98
AS
193 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
194 argument.
195 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
196 uses.
197
8d38f461
EZ
1982012-06-29 Eli Zaretskii <eliz@gnu.org>
199
2e5a6631
EZ
200 * xdisp.c (try_window_id): Undo last change.
201
8d38f461
EZ
202 * w32.c (getwd): Adjust commentary about startup_dir.
203 (init_environment): Always call sys_access, even in non-MSVC
204 builds. Don't chdir to the directory of the Emacs executable.
205 This undoes code from 1997 which was justified by the need to
206 "avoid conflicts when removing and renaming directories". But its
207 downside was that every relative file name was being interpreted
208 relative to the directory of the Emacs executable, which can never
209 be TRT. In particular, it broke sys_access when called with
210 relative file names.
211 (sys_access): Map GetLastError to errno.
212
2af3565e
DA
2132012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
214
215 * window.h (struct window): Change type of 'fringes_outside_margins'
216 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 217 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
218 Adjust comment.
219 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
220 to ptrdiff_t.
221
c8d3a25c 2222012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 223
c8d3a25c
GM
224 * gnutls.c (emacs_gnutls_handshake):
225 Add QUIT to make the loop interruptible.
57570cd3 226
c8d3a25c 2272012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 228
c8d3a25c
GM
229 * charset.c (init_charset): Make lack of etc/charsets fatal.
230
3e984ee8
DA
2312012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
232
233 * editfns.c (region_limit): Fix type mismatch.
234
ef884f23
DA
2352012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
236
237 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
238 undefined. Convert from xassert to eassert.
239 * nsmenu.m: Convert from xassert to eassert.
240 * nsterm.m: Likewise.
241
7d7e0027
SM
2422012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
243
244 * editfns.c (region_limit): Clip to narrowing (bug#11770).
245
aa754e6a
PE
2462012-06-28 Paul Eggert <eggert@cs.ucla.edu>
247
248 Avoid integer overflow on scroll-left and scroll-right.
249 * window.c (HSCROLL_MAX): New macro.
250 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
251 overflow when requested scroll falls outside ptrdiff_t range.
252
80b00b08
DA
2532012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
254
255 * window.h (struct window): Change type of 'hscroll',
256 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
257 'last_modified' and 'last_overlay_modified' to EMACS_INT.
258 Adjust users accordingly.
259 * xdisp.c (try_cursor_movement): Replace type check with eassert.
260 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
261 from EMACS_INT to ptrdiff_t.
262 (make_window): Omit redundant initialization.
263
62b2bcf6
JB
2642012-06-28 Juanma Barranquero <lekktu@gmail.com>
265
266 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
267
45942c7d
DA
2682012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
269
270 * window.h (struct window): Change type of 'use_time' and
271 'sequence_number' from Lisp_Object to int.
272 * frame.c (make_frame): Adjust users accordingly.
273 * print.c (print_object): Likewise.
274 * window.c (select_window, Fwindow_use_time, make_parent_window)
275 (make_window): Likewise.
276
e509cfa6
DA
2772012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
278
279 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
280 enabled with --enable-checking=[all,glyphs] configure option.
281 Fix GLYPH_DEBUG usage assuming that it may be undefined,
282 adjust comments accordingly.
283 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
284 undefined, adjust comments accordingly.
285 * image.c: Likewise.
286 * scroll.c: Likewise.
287 * w32fns.c: Likewise.
288 * w32term.c: Likewise.
289 * xdisp.c: Likewise.
290 * xfaces.c: Likewise.
291 * xfns.c: Likewise.
292 * xterm.c: Likewise.
293
a54e2c05
DA
2942012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
295
296 Generalize run-time debugging checks.
297 * dispextern.h (XASSERTS): Remove.
298 * fontset.c (xassert): Remove.
299 Convert from xassert to eassert.
300 * alloc.c: Convert from xassert to eassert.
301 * bidi.c: Likewise.
302 * dispnew.c: Likewise.
303 * fns.c: Likewise.
304 * fringe.c: Likewise.
305 * ftfont.c: Likewise.
306 * gtkutil.c: Likewise.
307 * image.c: Likewise.
308 * keyboard.c: Likewise.
309 * menu.c: Likewise.
310 * process.c: Likewise.
311 * scroll.c: Likewise.
312 * sound.c: Likewise.
313 * term.c: Likewise.
314 * w32console.c: Likewise.
315 * w32fns.c: Likewise.
316 * w32term.c: Likewise.
317 * window.c: Likewise.
318 * xdisp.c: Likewise.
319 * xfaces.c: Likewise.
320 * xfns.c: Likewise.
321 * xselect.c: Likewise.
322 * xterm.c: Likewise.
323
1ec4b7b2
SM
3242012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
325
326 * fns.c (maybe_resize_hash_table): Output message when growing the
327 purify-hashtable.
328
2014308a
DA
3292012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
330
331 * alloc.c (allocate_string_data): Remove dead code.
332 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
333 avoid GCC warning about unused macro.
334
246155eb
DA
3352012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
336
337 * alloc.c (allocate_string): Omit intervals initialization.
338 * alloc.c (make_uninit_multibyte_string): Initialize intervals
339 as in make_pure_string and make_pure_c_string.
340
43184b7b
DA
3412012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
342
343 * alloc.c (allocate_string): Fix last change.
344
3fe6dd74
DA
3452012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
346
347 * alloc.c (allocate_string): Remove two redundant calls
348 to memset, add explicit initialization where appropriate.
349
1ba6038a
GM
3502012-06-27 Glenn Morris <rgm@gnu.org>
351
352 * lisp.mk (lisp): Remove paths.elc.
353
c89926a5
CY
3542012-06-27 Chong Yidong <cyd@gnu.org>
355
356 * doc.c (Fsubstitute_command_keys): Fix punctuation.
357
ed6b3510
JW
3582012-06-26 John Wiegley <johnw@newartisans.com>
359
1ec4b7b2 360 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
361 on Mac OS X Lion: __mod_init_func and __mod_term_func.
362
ed6b3510
JW
363 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
364 when building with Clang.
365
8edd4a2b
SM
3662012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
367
368 * eval.c (Fapply): Allow calling it with a single argument.
369
f6f62d1b
EZ
3702012-06-26 Eli Zaretskii <eliz@gnu.org>
371
372 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
373 _stricmp and _strnicmp.
374 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
375
62efea5e
DA
3762012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
377
378 * alloc.c (allocate_window): Zero out non-Lisp part of newly
379 allocated window.
380 (allocate_process): Likewise for new process.
8edd4a2b 381 (allocate_terminal): Change to use offsetof.
62efea5e
DA
382 (allocate_frame): Likewise.
383 * frame.c (make_frame): Omit redundant initialization.
384 * window.c (make_parent_window): Use memset.
385 (make_window): Omit redundant initialization.
386 * process.c (make_process): Omit redundant initialization.
387 * terminal.c (create_terminal): Likewise.
388
42997f4d
DA
3892012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
390
391 * term.c (delete_tty): Remove redundant call to memset.
392
1130ecfc
DA
3932012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
394
395 * alloc.c: Remove build_string.
396 * lisp.h: Define build_string as static inline. This provides
397 a better opportunity to optimize away calls to strlen when the
398 function is called with compile-time constant argument.
399 * image.c (imagemagick_error): Convert to build_string.
400 * w32proc.c (sys_spawnve): Likewise.
401 * xterm.c (x_term_init): Likewise.
402
cf38a720
PE
4032012-06-26 Paul Eggert <eggert@cs.ucla.edu>
404
99027bdd
PE
405 Use sprintf return value instead of invoking strlen on result.
406 In the old days this wasn't portable, since some sprintf
407 implementations returned char *. But they died out years ago and
408 Emacs already assumes sprintf returns int.
409 Similarly for float_to_string.
410 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
411 * ccl.c (ccl_driver):
412 * character.c (string_escape_byte8):
413 * data.c (Fnumber_to_string):
414 * doprnt.c (doprnt):
415 * print.c (print_object):
416 * xdisp.c (message_dolog):
417 * xfns.c (syms_of_xfns):
418 Use sprintf or float_to_string result to avoid need to call strlen.
419 * data.c (Fnumber_to_string):
420 Use make_unibyte_string, since the string must be ASCII.
421 * lisp.h, print.c (float_to_string): Now returns int length.
422 * term.c (produce_glyphless_glyph):
423 Use sprintf result rather than recomputing it.
424
cf38a720
PE
425 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
426 * Makefile.in (ALL_CFLAGS):
427 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
428 * gmalloc.c, regex.c: Include <config.h> unconditionally.
429
3511c784
DA
4302012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
431
0a08eb21 432 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
433 strcasecmp if available.
434 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
435
fb7da12e
AS
4362012-06-25 Andreas Schwab <schwab@linux-m68k.org>
437
438 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
439 Avoid comma operator.
440 * menu.c (push_submenu_start, push_submenu_end)
441 (push_left_right_boundary, push_menu_pane): Likewise.
442 * msdos.c (dos_rawgetc): Likewise.
443
afa2ffd8
DA
4442012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
445
446 * xfns.c (xic_create_fontsetname): Remove redundant calls
447 to memset.
448
b3b4476b
PE
4492012-06-25 Paul Eggert <eggert@cs.ucla.edu>
450
4495ff38
PE
451 * gtkutil.c (get_utf8_string): Remove redundant assignment.
452 sprintf already null-terminates its output.
453
b3b4476b
PE
454 * xfns.c (x_window): Remove redundant cast.
455
b00876c9
DA
4562012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
457
458 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
459 `const char *' to `char *' to avoid compiler warning.
460
d188e26b
PE
4612012-06-24 Paul Eggert <eggert@cs.ucla.edu>
462
885d1d74
PE
463 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
464 instead of truncating it to 63 (admittedly a generous limit).
465
d188e26b
PE
466 * process.c: Fix spelling and caps in comments.
467
e2f560b1
DN
4682012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
469
e86db54b 470 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
471 * sysdep.c (setpgrp): Remove definition, not used in this file.
472
7583a3a1
JB
4732012-06-24 Juanma Barranquero <lekktu@gmail.com>
474
475 * makefile.w32-in: Update dependencies.
476
696056c2
EZ
4772012-06-24 Eli Zaretskii <eliz@gnu.org>
478
479 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
480 (SYSTIME_H): Add nt/inc/sys/time.h.
481
482 * systime.h [WINDOWSNT]: Include sys/time.h.
483
484 * s/ms-w32.h (struct timespec): Definition moved from
485 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
486
845ca893
PE
4872012-06-24 Paul Eggert <eggert@cs.ucla.edu>
488
489 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
490 * buffer.h (buffer_slot_type_mismatch):
491 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
492 * eval.c (unwind_to_catch):
493 * image.c (my_png_error, my_error_exit):
494 * keyboard.c (quit_throw_to_read_char, user_error)
495 (Fexit_recursive_edit, Fabort_recursive_edit):
496 * lisp.h (die, args_out_of_range, args_out_of_range_3)
497 (wrong_type_argument, buffer_overflow, __executable_start)
498 (memory_full, buffer_memory_full, string_overflow, Fthrow)
499 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
500 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
501 (fatal):
502 (child_setup) [!DOS_NT]:
503 * lread.c (end_of_file_error, invalid_syntax):
504 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
505 * puresize.h (pure_write_error):
506 * search.c (matcher_overflow):
507 * sound.c (sound_perror, alsa_sound_perror):
508 * sysdep.c, syssignal.h (croak):
509 * term.c (maybe_fatal, vfatal):
510 * textprop.c (text_read_only):
511 * undo.c (user_error):
512 * unexmacosx.c (unexec_error):
513 * xterm.c (x_ins_del_lines, x_delete_glyphs):
514 Use _Noreturn rather than NO_RETURN.
515 No need for separate decl merely because of _Noreturn.
516 * sound.c (sound_warning, parse_sound):
517 Remove unnecessary forward decls.
518
f1dd8073
PE
5192012-06-24 Paul Eggert <eggert@cs.ucla.edu>
520
521 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
522 * lisp.h (WAIT_READING_MAX): New macro.
523 * dispnew.c (Fsleep_for, sit_for):
524 * keyboard.c (kbd_buffer_get_event):
525 * process.c (Faccept_process_output):
526 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
527 This improves on the previous patch, which introduced a bug
528 when time_t is unsigned and as wide as intmax_t.
529 See <http://bugs.gnu.org/9000#51>.
530
b82c1755
EZ
5312012-06-23 Eli Zaretskii <eliz@gnu.org>
532
533 * dispnew.c (sit_for, Fsleep_for):
534 * keyboard.c (kbd_buffer_get_event):
535 * process.c (Faccept_process_output): Avoid compiler warnings when
536 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
537
ca300656
JB
5382012-06-23 Juanma Barranquero <lekktu@gmail.com>
539
049ec95b
JB
540 * makefile.w32-in: Update dependencies.
541
ca300656
JB
542 * w32.c (ltime): Add return type and declare static.
543 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
544
db7b8d06
PE
5452012-06-23 Paul Eggert <eggert@cs.ucla.edu>
546
547 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
548 Privately reported by Herbert J. Skuhra.
549 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
550 All uses changed.
551 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
552 not make_lisp_timeval, when the argument is of type EMACS_TIME.
553
0bd8297f
EZ
5542012-06-23 Eli Zaretskii <eliz@gnu.org>
555
96512555
EZ
556 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
557 last argument of make_unibyte_string.
558
0bd8297f
EZ
559 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
560 language ID in the event parameters.
561
562 * w32term.c (w32_read_socket): Put the new keyboard codepage into
563 event.code, not the obscure "character set ID".
564
63def6b6
CY
5652012-06-23 Chong Yidong <cyd@gnu.org>
566
567 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
568
e8a02204
EZ
5692012-06-23 Eli Zaretskii <eliz@gnu.org>
570
388cdec0
EZ
571 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
572 * w32.c (fdutimens): New function.
573
574 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
575
576 * s/ms-w32.h (pselect): Redirect to sys_select.
577
578 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
579
e8a02204
EZ
580 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
581 in the logic of incrementing and decrementing the value of
582 use_relocatable_buffers.
583
d054f3fb
PE
5842012-06-23 Paul Eggert <eggert@cs.ucla.edu>
585
586 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
587 Privately reported by Herbert J. Skuhra.
588 [__FreeBSD__]: Remove "*/" typo after "#include".
589 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
590 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
591 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
592 Don't assume EMACS_TIME and struct timeval are the same type.
593
d35af63c
PE
5942012-06-22 Paul Eggert <eggert@cs.ucla.edu>
595
596 Support higher-resolution time stamps (Bug#9000).
597 The time stamps are only nanosecond-resolution at the C level,
598 since that's the best that any real-world system supports now.
599 But they are picosecond-resolution at the Lisp level, as that's
600 easy, and leaves room for future OS improvements.
601
602 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
603 (LIBES): Use it.
604
605 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
606 Don't get current time unless it's needed.
607
608 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
609 now provides it if it's absent.
610 (start_atimer): Port to higher-res time stamps.
611 Check for time stamp overflow. Don't get current time more
612 often than is needed.
613
614 * buffer.h (struct buffer): Buffer modtime now has high resolution.
615 Include systime.h, not time.h.
616 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
617
618 * dired.c: Include stat-time.h.
619 (Ffile-attributes): File times now have higher resolution.
620
621 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
622 (struct image): Timestamp now has higher resolution.
623
624 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
625 has at least microseconds now. All uses removed.
626 (update_frame, update_single_window, update_window, update_frame_1)
627 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
628
629 * editfns.c (time_overflow): Now extern.
630 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
631 (float-time, Fformat_time_string, Fcurrent_time_string)
632 (Fcurrent_time_zone): Accept and generate higher-resolution
633 time stamps.
634 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
635 (decode_time_components, lisp_seconds_argument): New functions.
636 (make_time): Now static.
637 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
638 Report an error if the time is invalid, rather than having the caller
639 do that.
640
641 * fileio.c: Include <stat-time.h>
642 (Fcopy_file): Copy higher-resolution time stamps.
643 Prefer to set the time stamp via a file descriptor if that works.
644 (Fset_file_times, Finsert_file_contents, Fwrite_region)
645 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
646 (Fvisited_file_modtime, Fset_visited_file_modtime):
647 Support higher-resolution time stamps.
648
649 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
650
651 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
652
653 * image.c (prepare_image_for_display, clear_image_cache)
654 (lookup_image): Port to higer-resolution time stamps.
655
656 * keyboard.c (start_polling, bind_polling_period):
657 Check for time stamp overflow.
658 (read_char, kbd_buffer_get_event, timer_start_idle)
659 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
660 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
661 Port to higher-resolution time stamps. Do not assume time_t is signed.
662 (decode_timer): New function. Timers are now vectors of length 9,
663 not 8, to accommodate the picosecond component.
664 (timer_check_2): Use it.
665
666 * nsterm.m (select_timeout, timeval_subtract): Remove.
667 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
668 as they're a bit more accurate and handle overflow better.
669 (ns_select): Change prototype to be compatible with pselect.
670 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
671 * nsterm.h (ns_select): Adjust prototype.
672
673 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
674 us-resolution time stamps.
675 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
676
677 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
678
679 * lisp.h (time_overflow): New decl.
680 (wait_reading_process_output): First arg is now intmax_t, not int,
681 to accommodate larger waits.
682
683 * process.h (struct Lisp_Process.read_output_delay):
684 Now counts nanoseconds, not microseconds.
685 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
686 EMACS_HAS_USECS.
687 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
688 (wait_reading_process_output):
689 Port to ns-resolution time stamps.
690 (Faccept_process_output, wait_reading_process_output):
691 Check for time stamp overflow. Do not assume time_t is signed.
692 (select_wrapper): Remove; we now use pselect.
693 (Fprocess_attributes): Now generates ns-resolution time stamps.
694
695 * sysdep.c: Include utimens.h. Don't include utime.h
696 or worry about struct utimbuf; gnulib does that for us now.
697 (gettimeofday): Remove; gnulib provides a substitute.
698 (make_timeval): New function.
699 (set_file_times): Now sets ns-resolution time stamps.
700 New arg FD; all uses changed.
701 (time_from_jiffies, ltime_from_jiffies, get_up_time)
702 (system_process_attributes):
703 Now returns ns-resolution time stamp. All uses changed.
704 Check for time stamp overflow.
705
706 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
707 provides a substitute now.
708
709 * systime.h: Include timespec.h rather than sys/time.h and time.h,
710 since it guarantees struct timespec.
711 (EMACS_TIME): Now struct timespec, so that we can support
712 ns-resolution time stamps.
713 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
714 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
715 (EMACS_USECS): Remove.
716 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
717 so multiply the arg by 1000 before storing it.
718 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
719 New macros.
720 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
721 Port to ns-resolution time stamps.
722 (EMACS_TIME_NEG_P): Remove; replaced by....
723 (EMACS_TIME_SIGN): New macro.
724 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
725 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
726 (set_file_times, make_time, lisp_time_argument): Adjust signature.
727 (make_timeval, make_lisp_time, decode_time_components): New decls.
728 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
729 that it mishandled time_t overflow. You can't compare by subtracting!
730 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
731 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
732
733 * term.c: Include <sys/time.h>.
734 (timeval_to_Time): New function, for proper overflow wraparound.
735 (term_mouse_position, term_mouse_click): Use it.
736
737 * undo.c (record_first_change): Support higher-resolution time stamps
738 in the undo buffer.
739 (Fprimitive_undo): Use them when restoring time stamps.
740
741 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
742 (w32_get_internal_run_time):
743 Port to higher-resolution Emacs time stamps.
744 (ltime): Now accepts single 64-bit integer, as that's more convenient
745 for callers.
746
747 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
748
749 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
750 for compatibility with pselect. Support ns-resolution time stamps.
751
752 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
753
754 * xselect.c (wait_for_property_change, x_get_foreign_selection):
755 Check for time stamp overflow, and support ns-resolution time stamps.
756
757 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
758 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
759 (timeval_subtract): Remove; no longer needed.
760 (XTflash, XTring_bell, x_wait_for_event):
761 Port to ns-resolution time stamps. Don't assume time_t is signed.
762
b6a92dfe
CY
7632012-06-22 Chong Yidong <cyd@gnu.org>
764
765 * xdisp.c (x_consider_frame_title): Revert last change.
766
d251c37c
EZ
7672012-06-22 Eli Zaretskii <eliz@gnu.org>
768
769 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
770 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
771 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
772 staticidx goes up to 1597 out of 1600 = 0x640.)
773
f10deafb
PE
7742012-06-20 Paul Eggert <eggert@cs.ucla.edu>
775
776 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
777 Otherwise, the umask might be mistakenly 0 while handling input signals.
778
ec6de1e2
SM
7792012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
780
781 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
782
28be1ada
DA
7832012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
784
785 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
786 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
787 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
788 access to `contents' member of Lisp_Vector objects with AREF and ASET
789 where appropriate.
790
c6bf3022
CY
7912012-06-19 Chong Yidong <cyd@gnu.org>
792
793 * frame.c (delete_frame): When selecting a frame on a different
794 text terminal, do not alter the terminal's top-frame.
795
796 * xdisp.c (format_mode_line_unwind_data): Record the target
797 frame's selected window and its terminal's top-frame.
798 (unwind_format_mode_line): Restore them.
799 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
800 Callers changed.
801 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
802 since tty frames can be explicitly named.
803 (prepare_menu_bars): Likewise.
804
805 * term.c (Ftty_top_frame): New function.
806
defd4196
PE
8072012-06-18 Paul Eggert <eggert@cs.ucla.edu>
808
809 Port byte-code-meter to modern targets.
810 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
811 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 812 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
813 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
814 (METER_1, METER_2): Simplify.
815
1053a871
SM
8162012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
817
818 * data.c (Fdefalias): Return `symbol' (bug#11686).
819
b7e8d081
MR
8202012-06-18 Martin Rudalics <rudalics@gmx.at>
821
822 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
823 gets killed during executing of this function (Bug#11665).
824 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
825 (Vkill_buffer_query_functions): In doc-string say that functions
826 run by this hook should not change the current buffer.
827
7ea2b339
PE
8282012-06-18 Paul Eggert <eggert@cs.ucla.edu>
829
830 Fix recently-introduced process.c problems found by static checking.
831 * process.c (write_queue_push, write_queue_pop, send_process):
832 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
833 (write_queue_pop): Fix pointer signedness problem.
834 (send_process): Remove unused local.
835
96a313a1
CY
8362012-06-17 Chong Yidong <cyd@gnu.org>
837
838 * xdisp.c (redisplay_internal): No need to redisplay terminal
839 frames that are not on top.
840
20ca2e94
TN
8412012-06-17 Troels Nielsen <bn.troels@gmail.com>
842
843 * process.c (make_process): Initialize write_queue.
844 (write_queue_push, write_queue_pop): New functions.
845 (send_process): Use them to maintain correct ordering of process
846 writes (Bug#10815).
847
9a900ca9
PE
8482012-06-17 Paul Eggert <eggert@cs.ucla.edu>
849
310fbfa8
PE
850 * lisp.h (eassert): Assume C89 or later.
851 This removes the need for CHECK.
852 (CHECK): Remove. Its comments about always evaluating its
853 argument were confusing, as 'eassert' typically does not evaluate
854 its argument.
855
27bb1ca4
PE
856 * coding.c (produce_chars): Use ptrdiff_t, not int.
857
9a900ca9
PE
858 * xterm.c (x_draw_underwave): Check for integer overflow.
859 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
860
41b7f8bc 8612012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
862
863 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
864 referenced (Bug#11583).
865
9b0e3eba
AA
8662012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
867
868 Implement wave-style variant of underlining.
869 * dispextern.h (face_underline_type): New enum.
870 (face): Add field for underline type.
871 * nsterm.m (ns_draw_underwave): New function.
872 (ns_draw_text_decoration): Use it.
873 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
874 New functions.
875 (x_draw_glyph_string): Use them.
876 * xfaces.c (Qline, Qwave): New Lisp objects.
877 (check_lface_attrs, merge_face_ref)
1053a871
SM
878 (Finternal_set_lisp_face_attribute, realize_x_face):
879 Handle wave-style underline face attributes.
9b0e3eba
AA
880 * xterm.c (x_draw_underwave): New function.
881 (x_draw_glyph_string): Use it.
882
0fb52f11
JB
8832012-06-16 Juanma Barranquero <lekktu@gmail.com>
884
885 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
886 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
887 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
888 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
889 ($(BLD)/w32select.$(O)): Update dependencies.
890
e5560ff7
AS
8912012-06-16 Andreas Schwab <schwab@linux-m68k.org>
892
893 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
894 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
895 * character.c (_fetch_multibyte_char_p): Remove.
896 * alloc.c: Include "character.h" before "buffer.h".
897 * bidi.c: Likewise.
898 * buffer.c: Likewise.
899 * bytecode.c: Likewise.
900 * callint.c: Likewise.
901 * callproc.c: Likewise.
902 * casefiddle.c: Likewise.
903 * casetab.c: Likewise.
904 * category.c: Likewise.
905 * cmds.c: Likewise.
906 * coding.c: Likewise.
907 * composite.c: Likewise.
908 * dired.c: Likewise.
909 * dispnew.c: Likewise.
910 * doc.c: Likewise.
911 * dosfns.c: Likewise.
912 * editfns.c: Likewise.
913 * emacs.c: Likewise.
914 * fileio.c: Likewise.
915 * filelock.c: Likewise.
916 * font.c: Likewise.
917 * fontset.c: Likewise.
918 * fringe.c: Likewise.
919 * indent.c: Likewise.
920 * insdel.c: Likewise.
921 * intervals.c: Likewise.
922 * keyboard.c: Likewise.
923 * keymap.c: Likewise.
924 * lread.c: Likewise.
925 * macros.c: Likewise.
926 * marker.c: Likewise.
927 * minibuf.c: Likewise.
928 * nsfns.m: Likewise.
929 * nsmenu.m: Likewise.
930 * print.c: Likewise.
931 * process.c: Likewise.
932 * regex.c: Likewise.
933 * region-cache.c: Likewise.
934 * search.c: Likewise.
935 * syntax.c: Likewise.
936 * term.c: Likewise.
937 * textprop.c: Likewise.
938 * undo.c: Likewise.
939 * unexsol.c: Likewise.
940 * w16select.c: Likewise.
941 * w32fns.c: Likewise.
942 * w32menu.c: Likewise.
943 * window.c: Likewise.
944 * xdisp.c: Likewise.
945 * xfns.c: Likewise.
946 * xmenu.c: Likewise.
947 * xml.c: Likewise.
948 * xselect.c: Likewise.
949
2f07e6af
EZ
9502012-06-16 Eli Zaretskii <eliz@gnu.org>
951
1053a871
SM
952 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
953 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 954 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
955 row.
956 (handle_face_prop): Use chunk-relative overlay string index when
957 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
958 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
959 the rightmost. (Bug#11720)
2f07e6af 960
29b83cec
AS
9612012-06-16 Andreas Schwab <schwab@linux-m68k.org>
962
963 * category.h (CHAR_HAS_CATEGORY): Define as inline.
964 (CATEGORY_MEMBER): Enforce 1/0 value.
965 * category.c (_temp_category_set): Remove.
966
4c5501e9
EZ
9672012-06-16 Eli Zaretskii <eliz@gnu.org>
968
969 * window.c (Fdelete_other_windows_internal)
970 (Fdelete_window_internal): Don't access frame's mouse highlight
971 info of the initial frame. (Bug#11677)
972
2b570124
PE
9732012-06-14 Paul Eggert <eggert@cs.ucla.edu>
974
e93864f9
PE
975 * .gdbinit (xgetint): Fix recently-introduced paren typo.
976 Assume USE_2_TAGS_FOR_INTS.
977 (xreload): Adjust $tagmask width to match recent lisp.h change.
978
2b570124
PE
979 Simplify lisp.h in minor ways that should not affect code.
980 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
981 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
982 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
983 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
984 (INTTYPEBITS): New macro, for clarity.
985 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
986 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
987 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
988 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
989 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
990
81755f69
JB
9912012-06-13 Juanma Barranquero <lekktu@gmail.com>
992
993 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
994
16192a57
GM
9952012-06-13 Glenn Morris <rgm@gnu.org>
996
997 * s/bsd-common.h (BSD4_3):
998 * s/usg5-4-common.h (USG5_4): No longer define; unused.
999
646b5f55
AS
10002012-06-13 Andreas Schwab <schwab@linux-m68k.org>
1001
1002 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
1003 instead of union.
1004 (XLI, XIL): Define.
1053a871
SM
1005 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
1006 Use them.
1007 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 1008 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 1009 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
1010 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
1011 * frame.c (delete_frame): Remove outdated comment.
1012 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
1013 USE_LISP_UNION_TYPE.
1014 (Fw32_unregister_hot_key): Likewise.
1015 (Fw32_toggle_lock_key): Likewise.
1016 * w32menu.c (add_menu_item): Likewise.
1017 (w32_menu_display_help): Use XIL instead of checking
1018 USE_LISP_UNION_TYPE.
1019 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
1020 (init_heap): Likewise.
1021 * w32term.c (w32_read_socket): Update comment.
1022
1d3823c9
GM
10232012-06-13 Glenn Morris <rgm@gnu.org>
1024
c62ff706
GM
1025 * s/usg5-4-common.h, src/s/unixware.h:
1026 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
1027
1d3823c9
GM
1028 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
1029
bfe3e0a2
PE
10302012-06-13 Paul Eggert <eggert@cs.ucla.edu>
1031
1032 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
1033 * alloc.c (make_number) [!defined make_number]:
1034 Remove, as lisp.h always defines this now.
1035 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
1036 (roundup_size): Verify that it is a power of 2.
1037 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
1038 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
1039 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
1040 -DUSE_LSB_TAG=0, to override the automatically-selected default.
1041 USE_LSB_TAG now is always defined to be either 0 or 1.
1042 All uses changed.
1043 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
1044 code works fine either way, and efficiency is not a concern here,
1045 as the union type is for debugging, not for production.
1046 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
1047 Use an inline function on all platforms when using the union type,
1048 since this is simpler and 'static inline' can be used portably
1049 within Emacs now.
1050 (LISP_INITIALLY_ZERO): New macro.
1051 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
1052 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
1053
45fa9c0f
GM
10542012-06-12 Glenn Morris <rgm@gnu.org>
1055
b4492cba
GM
1056 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
1057
1058 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 1059
45fa9c0f
GM
1060 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
1061 Move BROKEN_SIGIO to configure.
1062
1063 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
1064 Move NO_TERMIO to configure.
1065
0e25d334
CY
10662012-06-12 Chong Yidong <cyd@gnu.org>
1067
1068 * image.c (imagemagick_load_image): Use MagickFlattenImage if
1069 MagickMergeImageLayers is undefined. Use pixel pusher loop if
1070 MagickExportImagePixels is undefined.
1071
43682bb6
PE
10722012-06-12 Paul Eggert <eggert@cs.ucla.edu>
1073
1074 * image.c (imagemagick_load_image): Remove unused label.
1075
a9be7d2b
GM
10762012-06-11 Glenn Morris <rgm@gnu.org>
1077
1078 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1079 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
1080 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
1081 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
1082
3017f87f
SM
10832012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
1084
1085 * alloc.c (make_byte_code): New function.
1086 (Fmake_byte_code): Use it. Don't purify here.
1087 * lread.c (read1): Use it as well to avoid extra allocation.
1088
1b9b4cf4
CY
10892012-06-11 Chong Yidong <cyd@gnu.org>
1090
1091 * image.c (imagemagick_load_image): Implement transparency.
1092
95988fcf
AS
10932012-06-10 Andreas Schwab <schwab@linux-m68k.org>
1094
1095 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
1096 account for preceding backslashes. (Bug#11663)
1097
cd4eb164
CY
10982012-06-09 Chong Yidong <cyd@gnu.org>
1099
1100 * term.c: Support italics in capable terminals (Bug#9652).
1101 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
1102 (turn_on_face): Output using TS_enter_italic_mode if available.
1103 Don't handle unused blinking and alt-charset cases.
1104 (turn_off_face): Handle italic case; discard unused tty_blinking_p
1105 and tty_alt_charset_p cases.
1106 (tty_capable_p, init_tty): Support italics.
1107
1108 * termchar.h (struct tty_display_info): Add field for italics.
1109 Remove unused blink field.
1110
1111 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
1112 Handle slant.
1113
1114 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
1115 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
1116 tty_alt_charset_p. Add tty_italic_p.
1117
ff88beb8
MA
11182012-06-09 Michael Albinus <michael.albinus@gmx.de>
1119
1120 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
1121 dbus_type_is_basic if available.
1122 (xd_extract_signed, xd_extract_unsigned): Rename from
1123 extract_signed and extract_unsigned, respectively. Adapt callers.
1124
44286096
CY
11252012-06-09 Chong Yidong <cyd@gnu.org>
1126
1682701f
CY
1127 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
1128
44286096
CY
1129 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
1130 case (Bug#9752).
1131
d86feb17
PE
11322012-06-08 Paul Eggert <eggert@cs.ucla.edu>
1133
1134 * xdisp.c (vmessage): Treat frame message as multibyte.
1135 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
1136 would generate the diagnostic "Making \302\247 buffer-local while
1137 let-bound!".
1138
d5c20fe8
EZ
11392012-06-08 Eli Zaretskii <eliz@gnu.org>
1140
1141 * dispnew.c (showing_window_margins_p): Undo last change, which
1142 was done due to an inadvertent commit.
1143 (adjust_frame_glyphs_for_frame_redisplay): Do call
1144 showing_window_margins_p.
1145
513749ee
SM
11462012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1147
1148 * eval.c (Fmake_var_non_special): New primitive.
1149 (syms_of_eval): Defsubr it.
1150 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
1151
d4a8f5c1
JB
11522012-06-08 Juanma Barranquero <lekktu@gmail.com>
1153
1154 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
1155 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
1156
8bbbc977
EZ
11572012-06-08 Eli Zaretskii <eliz@gnu.org>
1158
1159 * alloc.c (allocate_vectorlike): Fix last change.
1160
f3372c87
DA
11612012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
1162
1163 Block-based vector allocation of small vectors.
1164 * lisp.h (struct vectorlike_header): New field `nbytes',
1165 adjust comment accordingly.
1166 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
1167 to denote vector blocks. Adjust users (live_vector_p,
1168 mark_maybe_pointer, valid_lisp_object_p) accordingly.
1169 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
1170 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
1171 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
1172 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
1173 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
1174 (roundup_size): New constant.
1175 (struct vector_block): New data type.
1176 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 1177 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
1178 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
1179 (sweep_vectors): New functions.
1180 (allocate_vectorlike): Return `zero_vector' as the only vector of
1181 0 items. Allocate new vector from block if vector size is less than
1182 or equal to VBLOCK_BYTES_MAX.
1183 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
1184 (init_alloc_once): Add call to init_vectors.
1185
4f18a4ed
SM
11862012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1187
1188 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
1189
86f158bc
PE
11902012-06-07 Paul Eggert <eggert@cs.ucla.edu>
1191
1192 * doprnt.c (doprnt): Truncate multibyte char correctly.
1193 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
1194 would mishandle a string argument "Xc" if X was a multibyte
1195 character of length 2: it would truncate after X's first byte
1196 rather than including all of X.
1197
c5cfcbe0
CY
11982012-06-06 Chong Yidong <cyd@gnu.org>
1199
1200 * buffer.c (word_wrap): Doc fix.
1201
c05cf390
PE
12022012-06-04 Paul Eggert <eggert@cs.ucla.edu>
1203
1204 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
1205
0c3461de
GM
12062012-06-03 Glenn Morris <rgm@gnu.org>
1207
1208 * xdisp.c (tool-bar-style): Doc fix.
1209
c71232db
UM
12102012-06-03 Ulrich Müller <ulm@gentoo.org>
1211
1212 * Makefile.in (PAXCTL): Define.
1213 (temacs$(EXEEXT)): Disable memory randomization for the temacs
1214 binary via PaX flags if the paxctl utility is available.
1215 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
1216 Restore PaX flags to their default. (Bug#11398)
1217
383f7350
CY
12182012-06-03 Chong Yidong <cyd@gnu.org>
1219
1220 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
1221 buffer (Bug#11226).
1222
5f2c76c6
CY
12232012-06-03 Chong Yidong <cyd@gnu.org>
1224
1225 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
1226 (note_mode_line_or_margin_highlight): If there is no help echo,
1227 use mode-line-default-help-echo. Handle the case where the mouse
1228 position is past the end of the mode line string.
1229
1230 * buffer.c (buffer_local_value_1): New function, split from
1231 Fbuffer_local_value; can return Qunbound.
1232 (Fbuffer_local_value): Use it.
1233 (Vmode_line_format): Docstring tweaks.
1234
773d47f6
PE
12352012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1236
1237 * sysdep.c (system_process_attributes): Improve comment.
1238
f2d6a3df
SM
12392012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
1240
1241 * keyboard.c: Export real-this-command to Elisp.
1242 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
1243 and DEFVAR it. Update all users.
1244
63810350
PE
12452012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1246
7bd5c1f4
PE
1247 * minibuf.c (Fassoc_string): Remove duplicate declaration.
1248
63810350
PE
1249 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
1250 Convert pctcpu and pctmem to Lisp float properly.
1251 Let the compiler fold better, as 100.0/0x8000 is exact.
1252
a2821611
AS
12532012-06-02 Andreas Schwab <schwab@linux-m68k.org>
1254
1255 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
1256 cons_block.
1257
5fceba1d
PE
12582012-06-01 Paul Eggert <eggert@cs.ucla.edu>
1259
1260 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
1261
c98ff5dd
DA
12622012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
1263
1264 For a 'struct window', replace some Lisp_Object fields to
1265 bitfields where appropriate, remove unused fields.
1266 * window.h (struct window): Remove unused 'last_mark_x' and
1267 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
1268 change it's type from Lisp_Object to bitfield.
1269 Change type of 'force_start', 'optional_new_start',
1270 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
1271 fields from Lisp_Object to bitfield. Adjust users accordingly.
1272
ca34e0be
PE
12732012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1274
1275 Pacify gcc -Wdouble-precision when using Xaw.
1276 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
1277 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
1278 Use 'float' consistently, rather than 'float' in most places
1279 and 'double' in a couple of places.
1280
efc00ab1 12812012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
1282
1283 * xdisp.c (handle_stop): Detect whether we have overlay strings
1284 loaded by testing it->current.overlay_string_index to be
1285 non-negative, instead of checking whether n_overlay_strings is
1286 positive. (Bug#11587)
1287
efc00ab1 12882012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
1289
1290 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
1291
1292 * doc.c (Fsubstitute_command_keys): Doc fix.
1293
efc00ab1 12942012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
1295
1296 * search.c (search_buffer): Remove calls to
1297 r_alloc_inhibit_buffer_relocation, as it is now called by
1298 maybe_unify_char, which was the cause of relocation of buffer text
1299 in bug#11519.
1300
efc00ab1 13012012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
1302
1303 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
1304 for the duration of call to load_charset, to avoid problems with
1305 callers of maybe_unify_char that access buffer text through C
1306 pointers.
1307
1308 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
1309 decrement the inhibition flag, instead of just setting or
1310 resetting it.
1311
ba93a187
PE
13122012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1313
1314 Remove obsolete '#define static' cruft.
1315 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
1316 This #undef was "temporary" in 2000; it is no longer needed
1317 now that '#define static' has gone away.
1318 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
1319 (gray_bitmap_bits): Remove; no longer needed.
1320 All uses replaced with definiens.
1321 * xterm.c: Include "bitmaps/gray.xbm".
1322
9e4bf381
PE
13232012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1324
1325 Clean up __executable_start, monstartup when --enable-profiling.
1326 The following changes affect the code only when profiling.
1327 * dispnew.c (__executable_start): Rename from safe_bcopy.
1328 Define only on platforms that need it.
1329 * emacs.c: Include <sys/gmon.h> when profiling.
1330 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
1331 (__executable_start): Remove decl, since lisp.h does it now.
1332 (safe_bcopy): Remove decl; no longer has that name.
1333 (main): Coalesce #if into single bit of code, for simplicity.
1334 Cast pointers to uintptr_t, since standard libraries want integers
1335 and not pointers.
1336 * lisp.h (__executable_start): New decl.
1337
32d72c2f
GM
13382012-05-31 Glenn Morris <rgm@gnu.org>
1339
1340 * image.c (Fimagemagick_types): Doc fix.
1341
baac5bc7
JM
13422012-05-30 Jim Meyering <meyering@redhat.com>
1343
1344 * callproc.c (Fcall_process_region): Include directory component
1345 in mkstemp error message (Bug#11586).
1346
72cb32cf
PE
13472012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1348
1349 * alloc.c, lisp.h (make_pure_vector): Now static.
1350
61b108cc
SM
13512012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
1352
1353 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
1354 Move to byte-run.el.
1355 (Fautoload): Do the hash-doc more carefully.
1356 * data.c (Fdefalias): Purify definition, except for keymaps.
1357 (Qdefun): Move from eval.c.
1358 * lisp.h (Qdefun): Remove.
1359 * lread.c (read1): Tiny simplification.
1360
471fe23d
TN
13612012-05-29 Troels Nielsen <bn.troels@gmail.com>
1362
934f3f58 1363 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
1364 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
1365 Bug#9642, but explicitly check that the buffer the overlay would
1366 be moved to is live and rearrange lines to make sure that errors
1367 will not put the overlay in an inconsistent state.
1368 (Fdelete_overlay): Cosmetics.
1369
85d0efd1
EZ
13702012-05-28 Eli Zaretskii <eliz@gnu.org>
1371
1372 * w32term.c (my_bring_window_to_top): New function.
1373 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
1374 could be different from the original one.
1375 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
1376 (Bug#11513)
1377
1378 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
1379 by calling BringWindowToTop.
1380
1381 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
1382 (WM_EMACS_END): Increase by one.
1383
da92a98c
PE
13842012-05-28 Paul Eggert <eggert@cs.ucla.edu>
1385
1386 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
1387 This avoids undefined behavior that might cause the eassert
1388 to not catch an out-of-range value.
1389
74d1f848
JB
13902012-05-28 Juanma Barranquero <lekktu@gmail.com>
1391
1392 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
1393 Update dependencies.
1394
9e1a06fc
EZ
13952012-05-27 Eli Zaretskii <eliz@gnu.org>
1396
1397 * bidi.c (bidi_mirror_char): Fix last change.
1398
f3dd7312
AS
13992012-05-27 Andreas Schwab <schwab@linux-m68k.org>
1400
1401 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
1402 when referring to sectname field in printf format.
1403
81899c91
PE
14042012-05-27 Paul Eggert <eggert@cs.ucla.edu>
1405
57b81a9f
PE
1406 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
1407 Only r_alloc_inhibit_buffer_relocation needed to be added;
1408 the others were already declared.
1409
81899c91
PE
1410 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
1411 before checking whether it's out of range. Put the check inside
1412 eassert. See
1413 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
1414
33017faf 14152012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
1416
1417 * callproc.c (Fcall_process): Restore a line that was accidentally
1418 commented out in the 2011-02-13 change (bug#11547).
1419
33017faf 14202012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
1421
1422 * lisp.h [REL_ALLOC]: Add prototypes for external functions
1423 defined on ralloc.c.
1424
1425 * buffer.c [REL_ALLOC]: Remove prototypes of
1426 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
1427 they are now on lisp.h.
1428
1429 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
1430
1431 * search.c (search_buffer): Use it to inhibit relocation of buffer
1432 text while re_search_2 is doing its job, because re_search_2 is
1433 passed C pointers to buffer text. (Bug#11519)
1434
23415acf
EZ
1435 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
1436 Update value to 24.
1437
44e27368
EZ
1438 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
1439 state after an additional call to move_it_in_display_line_to, keep
1440 the values of it->max_ascent and it->max_descent found for the
1441 entire line.
1442 (pos_visible_p): Revert the comparison against bottom_y to what it
1443 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
1444 (Bug#11464)
1445
c1892f11
PE
14462012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1447
1448 Fix coding-related core dumps with gcc -ftrapv.
1449 The code was computing A - B, where A and B are pointers, and B is
1450 random garbage. This can lead to core dumps on platforms that
1451 have special pointer registers, and it also leads to core dumps on
1452 x86-64 when compiled with gcc -ftrapv. The fix is to compute
1453 A - B only when B is initialized properly.
1454 * coding.c (coding_set_source, coding_set_destination): Return void.
1455 (coding_change_source, coding_change_destinations): New functions,
1456 with the old behaviors of coding_set_source and coding_set_destination.
1457 All callers that need an offset changed to use these new functions.
1458
eb7afdad
GM
14592012-05-26 Glenn Morris <rgm@gnu.org>
1460
1461 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
1462
f12fdf02
EZ
14632012-05-26 Eli Zaretskii <eliz@gnu.org>
1464
53a63be6 1465 Extend mouse support on W32 text-mode console.
61b108cc
SM
1466 * xdisp.c (draw_row_with_mouse_face):
1467 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 1468
eb3f6f01 1469 * w32console.c: Include window.h.
61b108cc
SM
1470 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
1471 New functions.
eb3f6f01
EZ
1472 (initialize_w32_display): Initialize mouse-highlight data.
1473
53a63be6
EZ
1474 * w32inevt.c: Include termchar.h and window.h.
1475 (do_mouse_event): Support mouse-autoselect-window. When the mouse
1476 moves, call note_mouse_highlight. If help_echo changed, call
1477 gen_help_event to produce help-echo message in the echo area.
1478 Call clear_mouse_face if mouse_face_hidden is set in the mouse
1479 highlight info.
1480
4cfd81f6
PE
14812012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1482
1483 * lread.c (read1): Simplify slightly to avoid an overflow warning
1484 with GCC 4.7.0 on x86-64.
1485
4446092a
EZ
14862012-05-26 Eli Zaretskii <eliz@gnu.org>
1487
1488 * bidi.c (bidi_mirror_char): Revert last change: an int is
1489 definitely wide enough here.
1490
42b2a986 14912012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 1492
42b2a986 1493 Fix integer width and related bugs (Bug#9874).
eb106a49 1494 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
1495 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
1496 (string_bytes, check_sblock, allocate_string_data):
1497 (compact_small_strings, Fmake_bool_vector, make_string)
1498 (make_unibyte_string, make_multibyte_string)
1499 (make_string_from_bytes, make_specified_string)
1500 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
1501 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
1502 (mark_vectorlike):
1503 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1504 (allocate_pseudovector):
1505 Use int, not EMACS_INT, where int is wide enough.
1506 (inhibit_garbage_collection, Fgarbage_collect):
1507 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1508 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
1509 int might not be wide enough.
1510 (bidi_cache_search, bidi_cache_find, bidi_init_it)
1511 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
1512 (bidi_at_paragraph_end, bidi_find_paragraph_start)
1513 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1514 (bidi_level_of_next_char, bidi_move_to_visually_next):
1515 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1516 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
1517 (Fkill_buffer, Fset_buffer_major_mode)
1518 (advance_to_char_boundary, Fbuffer_swap_text)
1519 (Fset_buffer_multibyte, overlays_at, overlays_in)
1520 (overlay_touches_p, struct sortvec, record_overlay_string)
1521 (overlay_strings, recenter_overlay_lists)
1522 (adjust_overlays_for_insert, adjust_overlays_for_delete)
1523 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
1524 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
1525 (Foverlay_recenter, last_overlay_modification_hooks_used)
1526 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
1527 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
1528 (validate_region): Omit unnecessary test for b <= e,
1529 since that's guaranteed by the previous test.
d311d28c
PE
1530 (adjust_overlays_for_delete): Avoid pos + length overflow.
1531 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
1532 (report_overlay_modification):
1533 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1534 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
1535 Omit pointer cast, which isn't needed anyway, and doesn't work
1536 after the EMACS_INT -> ptrdiff_t change.
02481186 1537 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
1538 * buffer.h: Adjust decls to match defn changes elsewhere.
1539 (struct buffer_text, struct buffer):
1540 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1541 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
1542 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
1543 not int, to avoid needless 32-bit limit on 64-bit hosts.
1544 (exec_byte_code): Use tighter memory-full test, one that checks
1545 for alloca overflow. Don't compute the address of the object just
1546 before an array, as that's not portable. Use EMACS_INT, not
1547 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
1548 * callint.c (Fcall_interactively):
1549 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1550 * callproc.c (call_process_kill, Fcall_process):
1551 Don't assume pid_t fits into an Emacs fixnum.
1552 (call_process_cleanup, Fcall_process, child_setup):
1553 Don't assume pid_t fits into int.
1554 (call_process_cleanup, Fcall_process, delete_temp_file)
1555 (Fcall_process_region):
1556 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1557 (Fcall_process): Simplify handling of volatile integers.
1558 Use int, not EMACS_INT, where int will do.
1559 * casefiddle.c (casify_object, casify_region, operate_on_word)
1560 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
1561 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1562 (casify_object): Avoid integer overflow when overallocating buffer.
1563 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 1564 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
1565 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
1566 * category.h (CATEGORYP): Don't assume arg is nonnegative.
1567 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
1568 integers are now checked earlier. All uses replaced with XINT.
1569 (ccl_driver):
1570 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1571 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
1572 (ccl_driver, Fregister_code_conversion_map):
1573 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
1574 (resolve_symbol_ccl_program): Check that vector header is in range.
1575 Always copy the vector, so that we can check its contents reliably
1576 now rather than having to recheck each instruction as it's being
1577 executed. Check that vector words fit in 'int'.
1578 (ccl_get_compiled_code, Fregister_ccl_program)
1579 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
1580 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
1581 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
1582 contents are in range.
1583 (Fccl_execute_on_string): Check that status is in range.
1584 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
1585 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
1586 Accept and return EMACS_INT, not int, because callers can pass values
1587 out of 'int' range.
1588 (c_string_width, strwidth, lisp_string_width, chars_in_text)
1589 (multibyte_chars_in_text, parse_str_as_multibyte)
1590 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
1591 (str_as_unibyte, str_to_unibyte, string_count_byte8)
1592 (string_escape_byte8, Fget_byte):
1593 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 1594 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
1595 avoid mishandling large integers.
1596 * character.h: Adjust decls to match defn changes elsewhere.
1597 * charset.c (load_charset_map_from_file, find_charsets_in_text)
1598 (Ffind_charset_region):
1599 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1600 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
1601 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 1602 Don't assume fixnum fits in int.
d311d28c
PE
1603 (load_charset_map_from_vector, Fmap_charset_chars):
1604 Remove now-unnecessary CHECK_NATNUMs.
1605 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
1606 Don't rely on undefined behavior with signed left shift overflow.
1607 Don't assume unsigned int fits into fixnum, or that fixnum fits
1608 into unsigned int. Don't require max_code to be a valid fixnum;
1609 that's not true for gb10830 4-byte on a 32-bit host. Allow
1610 invalid_code to be a cons, for the same reason. Require code_offset
1611 to be a character. Avoid int overflow if max_char is close
1612 to INT_MAX.
1613 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
1614 this is intended anyway and avoids some undefined behavior.
1615 (load_charset_map): Pass unsigned, not int, as 2nd arg of
1616 INDEX_TO_CODE_POINT, as that's what it expects.
1617 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
1618 * charset.h (DECODE_CHAR): Return int, not unsigned;
1619 this is what was intended anyway, and it avoids undefined behavior.
1620 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
1621 integer-overflow issues.
1622 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
1623 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
1624 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
1625 * chartab.c (Fmake_char_table, Fset_char_table_range)
1626 (uniprop_get_decoder, uniprop_get_encoder):
1627 Don't assume fixnum fits in int.
1628 * cmds.c (move_point): New function, that does the gist of
1629 Fforward_char and Fbackward_char, but does so while checking
1630 for integer overflow more accurately.
c96e5d6a 1631 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
1632 (Fforward_line, Fend_of_line, internal_self_insert)
1633 (internal_self_insert):
1634 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1635 Fix a FIXME, by checking for integer overflow when calculating
1636 target_clm and actual_clm.
1637 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 1638 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
1639 (ASSURE_DESTINATION, coding_alloc_by_realloc)
1640 (coding_alloc_by_making_gap, alloc_destination)
1641 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
1642 (encode_coding_utf_16, detect_coding_emacs_mule)
1643 (decode_coding_emacs_mule, encode_coding_emacs_mule)
1644 (detect_coding_iso_2022, decode_coding_iso_2022)
1645 (encode_invocation_designation, encode_designation_at_bol)
1646 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1647 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
1648 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
1649 (encode_coding_ccl, encode_coding_raw_text)
1650 (detect_coding_charset, decode_coding_charset)
1651 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
1652 (produce_composition, produce_charset, produce_annotation)
1653 (decode_coding, handle_composition_annotation)
1654 (handle_charset_annotation, consume_chars, decode_coding_gap)
1655 (decode_coding_object, encode_coding_object, detect_coding_system)
1656 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
1657 (code_convert_region, code_convert_string)
8f50130c
PE
1658 (Fdefine_coding_system_internal)
1659 (coding_set_source, coding_set_destination):
d311d28c
PE
1660 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1661 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
1662 (Fdefine_coding_system_internal):
1663 Don't assume fixnums fit in int.
1664 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 1665 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
1666 (Funencodable_char_position, Fcheck_coding_systems_region)
1667 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 1668 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 1669 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 1670 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 1671 Don't access memory outside of the args array.
d311d28c 1672 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
1673 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
1674 result of ENCODE_CHAR.
d311d28c
PE
1675 * coding.h: Adjust decls to match defn changes elsewhere.
1676 (struct coding_system):
1677 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1678 * composite.c (get_composition_id, find_composition)
1679 (run_composition_function, update_compositions)
1680 (compose_text, composition_gstring_put_cache)
1681 (composition_gstring_p, composition_gstring_width)
1682 (fill_gstring_header, fill_gstring_body, autocmp_chars)
1683 (composition_compute_stop_pos, composition_reseat_it)
1684 (composition_update_it, struct position_record)
1685 (find_automatic_composition, composition_adjust_point)
1686 (Fcomposition_get_gstring, Ffind_composition_internal):
1687 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1688 (update_compositions):
1689 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1690 * composite.h: Adjust decls to match defn changes elsewhere.
1691 (struct composition):
1692 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1693 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
1694 Do not attempt to compute the address of the object just before a
1695 buffer; this is not portable.
1696 (Faref, Faset):
1697 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1698 (Faset): Use int, not EMACS_INT, where int is wide enough.
1699 (Fstring_to_number): Don't assume fixnums fit in int.
1700 (Frem): Don't assume arg is nonnegative.
1701 * dbusbind.c (xd_append_arg): Check for integers out of range.
1702 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 1703 (extract_signed, extract_unsigned): New functions.
243e0530
PE
1704 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
1705 (xd_get_connection_references): Return ptrdiff_t, not int.
1706 All uses changed.
1707 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
1708 (xd_read_message_1):
1709 Use int, not unsigned, where the dbus API uses int.
1710 (Fdbus_message_internal): Don't overflow mtype.
1711 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
1712 * dired.c (directory_files_internal, file_name_completion, scmp)
1713 (file_name_completion_stat):
1714 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1715 (file_name_completion): Don't overflow matchcount.
1716 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
1717 * dispextern.h: Adjust decls to match defn changes elsewhere.
1718 (struct text_pos, struct glyph, struct bidi_saved_info)
1719 (struct bidi_string_data, struct bidi_it, struct composition_it)
1720 (struct it):
1721 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1722 (struct display_pos, struct composition_it, struct it):
1723 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1724 * dispnew.c (increment_matrix_positions)
1725 (increment_row_positions, mode_line_string)
1726 (marginal_area_string):
1727 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 1728 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
1729 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1730 (duration_to_sec_usec): New function, to check for overflow better.
1731 (Fsleep_for, sit_for): Use it.
1732 * doc.c (get_doc_string, store_function_docstring):
1733 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1734 (get_doc_string, Fsnarf_documentation):
1735 Use int, not EMACS_INT, where int is wide enough.
1736 (get_doc_string):
1737 Use SAFE_ALLOCA, not alloca.
1738 Check for overflow when converting EMACS_INT to off_t.
1739 * doprnt.c (doprnt):
1740 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1741 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
1742 Don't assume uid_t fits into fixnum.
1743 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
1744 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
1745 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
1746 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
1747 (general_insert_function)
1748 (Finsert_char, make_buffer_string, make_buffer_string_both)
1749 (update_buffer_properties, Fbuffer_substring)
1750 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
1751 (Fsubst_char_in_region, check_translation)
1752 (Ftranslate_region_internal, save_restriction_restore, Fformat)
1753 (transpose_markers, Ftranspose_regions):
1754 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1755 (clip_to_bounds): Move to lisp.h as an inline function).
1756 (Fconstrain_to_field): Don't assume integers are nonnegative.
1757 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
1758 (Fsubst_char_in_region, Fsave_restriction):
1759 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1760 (Femacs_pid): Don't assume pid_t fits into fixnum.
1761 (lo_time): Use int, not EMACS_INT, when int suffices.
1762 (lisp_time_argument): Check for usec out of range.
1763 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
1764 (Fuser_login_name, Fuser_full_name): Signal an error
1765 if a uid argument is out of range, rather than relying on
1766 undefined behavior.
c8d5c857
PE
1767 (Fformat_time_string): Remove now-unnecessary check.
1768 lisp_time_argument checks for out-of-range usec now.
243e0530 1769 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
1770 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
1771 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
1772 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
1773 (init_cmdargs, Fdump_emacs):
1774 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1775 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
1776 the bottom (typically) 32 bits of the fixnum.
1777 * eval.c (specpdl_size, call_debugger):
1778 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1779 (when_entered_debugger, Fbacktrace_debug):
1780 Don't assume fixnum can fit in int.
1781 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
1782 the object just before a buffer; this is not portable.
1783 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
1784 (grow_specpdl, unbind_to):
1785 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1786 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
1787 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 1788 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
1789 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
1790 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
1791 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1792 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
1793 (a_write, e_write):
1794 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1795 (Fcopy_file, non_regular_nbytes, read_non_regular)
1796 (Finsert_file_contents):
1797 Use int, not EMACS_INT, where int is wide enough.
1798 (READ_BUF_SIZE): Verify that it fits in int.
1799 (Finsert_file_contents): Check that counts are in proper range,
1800 rather than assuming fixnums fit into ptrdiff_t etc.
1801 Don't assume fixnums fit into int.
125b3835 1802 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
1803 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
1804 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
1805 (string_char_to_byte, string_byte_to_char)
1806 (string_make_multibyte, string_to_multibyte)
1807 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
1808 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
1809 (substring_both, Fdelete, internal_equal, Ffillarray)
1810 (Fclear_string, mapcar1)
1811 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
1812 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
1813 (larger_vector, make_hash_table, maybe_resize_hash_table)
1814 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
1815 (Fmaphash, secure_hash):
1816 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1817 (concat): Check for string index and length overflow.
1818 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
1819 (Frequire):
1820 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1821 (larger_vector): New API (vec, incr_min, size_max) replaces old
1822 one (vec, new_size, init). This catches size overflow.
1823 INIT was removed because it was always Qnil.
1824 All callers changed.
1825 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
1826 the upper bound on a hash table index size.
1827 (make_hash_table, maybe_resize_hash_table): Use it.
1828 (secure_hash): Computer start_byte and end_byte only after
1829 they're known to be in ptrdiff_t range.
1830 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
1831 (Ffont_get_glyphs, Ffont_at):
1832 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1833 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
1834 (Flist_fonts, Fopen_font):
1835 Don't assume fixnum can fit in int.
1836 (check_gstring): Don't assume index can fit in int.
1837 (font_match_p): Check that fixnum is a character, not a nonnegative
1838 fixnum, since the later code needs to stuff it into an int.
1839 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
1840 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
1841 conversion overflow issues.
1842 (Fopen_font): Check for integer out of range.
1843 (Ffont_get_glyphs): Don't assume index can fit in int.
1844 * font.h: Adjust decls to match defn changes elsewhere.
1845 * fontset.c (reorder_font_vector): Redo score calculation to avoid
1846 integer overflow.
1847 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
1848 printmax_t, where ptrdiff_t is wide enough.
1849 (Finternal_char_font):
1850 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1851 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
1852 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
1853 (Fset_frame_position, x_set_frame_parameters)
1854 (x_set_line_spacing, x_set_border_width)
1855 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
1856 Check that fixnums are in proper range for system types.
1857 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
1858 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1859 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
1860 Use SAFE_ALLOCA_LISP, not alloca.
1861 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
1862 intptr_t is wide enough.
1863 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
1864 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
1865 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
1866 Check for fixnum out of range.
1867 * ftfont.c (ftfont_list): Don't assume index fits in int.
1868 Check that fixnums are in proper range for system types.
1869 (ftfont_shape_by_flt):
1870 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
1871 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1872 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1873 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
1874 Check that fixnums are in proper range for system types.
1875 * gnutls.h: Adjust decls to match defn changes elsewhere.
1876 * gtkutil.c (xg_dialog_run):
1877 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1878 (update_frame_tool_bar):
1879 Check that fixnums are in proper range for system types.
1880 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 1881 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
1882 * indent.c (last_known_column, last_known_column_point):
1883 (current_column_bol_cache):
1884 (skip_invisible, current_column, check_display_width):
1885 (check_display_width, scan_for_column, current_column_1)
1886 (Findent_to, Fcurrent_indentation, position_indentation)
1887 (indented_beyond_p, Fmove_to_column, compute_motion):
1888 (Fcompute_motion, Fvertical_motion):
1889 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1890 (last_known_column_modified): Use EMACS_INT, not int.
1891 (check_display_width):
1892 (Fcompute_motion):
1893 Check that fixnums and floats are in proper range for system types.
1894 (compute_motion): Don't assume index or fixnum fits in int.
1895 (compute_motion, Fcompute_motion):
1896 Use int, not EMACS_INT, when it is wide enough.
1897 (vmotion): Omit local var start_hpos that is always 0; that way
1898 we don't need to worry about overflow in expressions involving it.
1899 * indent.h: Adjust decls to match defn changes elsewhere.
1900 (struct position):
1901 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1902 Use int, not EMACS_INT, where int is wide enough.
1903 Remove unused members ovstring_chars_done and tab_offset;
1904 all uses removed.
1905 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
1906 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
1907 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
1908 (make_gap, copy_text, insert, insert_and_inherit)
1909 (insert_before_markers, insert_before_markers_and_inherit)
1910 (insert_1, count_combining_before, count_combining_after)
1911 (insert_1_both, insert_from_string)
1912 (insert_from_string_before_markers, insert_from_string_1)
1913 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
1914 (adjust_after_replace, adjust_after_insert, replace_range)
1915 (replace_range_2, del_range, del_range_1, del_range_byte)
1916 (del_range_both, del_range_2, modify_region)
1917 (prepare_to_modify_buffer, signal_before_change)
1918 (signal_after_change, Fcombine_after_change_execute):
1919 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1920 * intervals.c (traverse_intervals, rotate_right, rotate_left)
1921 (balance_an_interval, split_interval_right, split_interval_left)
1922 (find_interval, next_interval, update_interval)
1923 (adjust_intervals_for_insertion, delete_node, delete_interval)
1924 (interval_deletion_adjustment, adjust_intervals_for_deletion)
1925 (static_offset_intervals, offset_intervals)
1926 (merge_interval_right, merge_interval_left, make_new_interval)
1927 (graft_intervals_into_buffer, temp_set_point_both)
1928 (temp_set_point, set_point, adjust_for_invis_intang)
1929 (set_point_both, move_if_not_intangible, get_property_and_range)
1930 (get_local_map, copy_intervals, copy_intervals_to_string)
1931 (compare_string_intervals, set_intervals_multibyte_1):
1932 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1933 * intervals.h: Adjust decls to match defn changes elsewhere.
1934 (struct interval):
1935 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1936 * keyboard.c (this_command_key_count, this_single_command_key_start)
1937 (before_command_key_count, before_command_echo_length, echo_now)
1938 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
1939 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
1940 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
1941 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
1942 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1943 (last_non_minibuf_size, last_point_position, echo_truncate)
1944 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
1945 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
1946 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
1947 (stuff_buffered_input):
1948 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1949 (last_auto_save, command_loop_1, read_char):
1950 Use EMACS_INT, not int, to avoid integer overflow.
1951 (record_char): Avoid overflow in total_keys computation.
1952 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
1953 * keyboard.h: Adjust decls to match defn changes elsewhere.
1954 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
1955 (Fkey_description, Fdescribe_vector, Flookup_key):
1956 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1957 (click_position): New function, to check that positions are in range.
1958 (Fcurrent_active_maps):
1959 (describe_command):
1960 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1961 (Faccessible_keymaps, Fkey_description):
1962 (preferred_sequence_p):
1963 Don't assume fixnum can fit into int.
1964 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
1965 Check for integer overflow in size calculations.
1966 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
1967 avoid mishandling large integers.
1968 * lisp.h: Adjust decls to match defn changes elsewhere.
1969 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
1970 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
1971 (struct Lisp_Marker):
1972 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1973 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
1974 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
1975 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
1976 All callers changed.
1977 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
1978 Assume the arg has valid form, since it always does.
1979 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
1980 unsigned integer system type.
1981 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
1982 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
1983 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1984 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
1985 (duration_to_sec_usec): New decl.
1986 * lread.c (read_from_string_index, read_from_string_index_byte)
1987 (read_from_string_limit, readchar, unreadchar, openp)
1988 (read_internal_start, read1, oblookup):
1989 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1990 (Fload, readevalloop, Feval_buffer, Feval_region):
1991 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1992 (openp): Check for out-of-range argument to 'access'.
1993 (read1): Use int, not EMACS_INT, where int is wide enough.
1994 Don't assume fixnum fits into int.
6efdadfd 1995 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
1996 (read_filtered_event): Use duration_to_sec_usec
1997 to do proper overflow checking on durations.
d311d28c
PE
1998 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
1999 in size calculation.
2000 (Fexecute_kbd_macro):
2001 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2002 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
2003 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
2004 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
2005 (set_marker_both, set_marker_restricted_both, marker_position)
2006 (marker_byte_position, Fbuffer_has_markers_at):
2007 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2008 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 2009 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
2010 It now merely ensures that the menu is large enough, without
2011 necessarily growing it, as this avoids some integer overflow issues.
2012 All callers changed.
2013 (keymap_panes, parse_single_submenu, Fx_popup_menu):
2014 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2015 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
2016 Use SAFE_ALLOCA_LISP, not alloca.
2017 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
2018 to EMACS_INT. Check that fixnums are in proper range for system types.
2019 * minibuf.c (minibuf_prompt_width, string_to_object)
2020 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
2021 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
2022 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2023 (get_minibuffer, read_minibuf_unwind):
2024 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2025 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
2026 this simplifies overflow checking. All callers changed.
2027 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
2028 (Ftest_completion):
2029 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2030 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
2031 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
2032 Check that fixnums are in proper range for system types.
2033 (Fx_create_frame, Fx_show_tip):
2034 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2035 * nsfont.m (ns_findfonts, nsfont_list_family):
2036 Don't assume fixnum fits in long.
2037 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
2038 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2039 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
2040 wide enough.
17fdb222 2041 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
2042 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2043 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
2044 (PRINTDECLARE, PRINTPREPARE):
2045 (strout, print_string):
2046 (print, print_preprocess, print_check_string_charset_prop)
2047 (print_object):
2048 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2049 (PRINTDECLARE):
2050 (temp_output_buffer_setup, Fprin1_to_string, print_object):
2051 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2052 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 2053 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 2054 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
2055 (print_error_message): Use SAFE_ALLOCA, not alloca.
2056 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
2057 (print_depth, new_backquote_output, print_number_index):
2058 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
2059 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
2060 (Fset_process_window_size, Fformat_network_address)
2061 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 2062 (sigchld_handler):
d311d28c 2063 Check that fixnums are in proper range for system types.
d44287d4 2064 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
2065 Check for process-ids out of pid_t range rather than relying on
2066 undefined behavior.
e4d81efc 2067 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
2068 (Fformat_network_address, read_process_output, send_process)
2069 (Fprocess_send_region, status_notify):
2070 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2071 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
2072 (wait_reading_process_output, read_process_output, exec_sentinel):
2073 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2074 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
2075 (Faccept_process_output): Use duration_to_sec_usec to do proper
2076 overflow checking on durations.
dde14581
PE
2077 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
2078 Don't assume pid_t fits in int.
02481186
PE
2079 * process.h (struct Lisp_Process): Members tick and update_tick
2080 are now of type EMACS_INT, not int.
b62b53e8
PE
2081 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
2082 configured --with-wide-int.
d311d28c
PE
2083 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
2084 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
2085 * search.c (looking_at_1, string_match_1):
2086 (fast_string_match, fast_c_string_match_ignore_case)
2087 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
2088 (scan_newline, find_before_next_newline, search_command)
2089 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
2090 (set_search_regs, wordify):
2091 (Freplace_match):
2092 (Fmatch_data):
2093 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2094 (string_match_1, search_buffer, set_search_regs):
2095 (Fmatch_data):
2096 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2097 (wordify): Check for overflow in size calculation.
2098 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
2099 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
2100 Check that fixnums are in proper range for system types.
2101 * sound.c (struct sound_device)
2102 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
2103 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2104 (Fplay_sound_internal):
2105 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 2106 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
2107 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
2108 (Fparse_partial_sexp):
2109 Don't assume fixnums can fit in int.
2110 (struct lisp_parse_state, find_start_pos, find_start_value)
2111 (find_start_value_byte, find_start_begv)
2112 (update_syntax_table, char_quoted, dec_bytepos)
2113 (find_defun_start, prev_char_comend_first, back_comment):
2114 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
2115 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
2116 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2117 (Finternal_describe_syntax_value): Check that match_lisp is a
2118 character, not an integer, since the code stuffs it into int.
2119 (scan_words, scan_sexps_forward):
2120 Check that fixnums are in proper range for system types.
2121 (Fforward_word):
2122 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2123 (scan_sexps_forward):
2124 Use CHARACTERP, not INTEGERP, since the value must fit into int.
2125 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
2126 * syntax.h: Adjust decls to match defn changes elsewhere.
2127 (struct gl_state_s):
2128 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
2129 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
2130 MOST_POSITIVE_FIXNUM.
d311d28c
PE
2131 * sysdep.c (wait_for_termination_1, wait_for_termination)
2132 (interruptible_wait_for_termination, mkdir):
2133 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
2134 (emacs_read, emacs_write):
2135 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
2136 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
2137 and double all fit in int.
d311d28c
PE
2138 * term.c (set_tty_color_mode):
2139 Check that fixnums are in proper range for system types.
2140 * termhooks.h (struct input_event):
2141 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2142 * textprop.c (validate_interval_range, interval_of)
2143 (Fadd_text_properties, set_text_properties_1)
2144 (Fremove_text_properties, Fremove_list_of_text_properties)
2145 (Ftext_property_any, Ftext_property_not_all)
2146 (copy_text_properties, text_property_list, extend_property_ranges)
2147 (verify_interval_modification):
2148 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2149 (Fnext_single_char_property_change)
2150 (Fprevious_single_char_property_change):
2151 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
2152 (copy_text_properties):
2153 Check for integer overflow in index calculation.
d311d28c
PE
2154 * undo.c (last_boundary_position, record_point, record_insert)
2155 (record_delete, record_marker_adjustment, record_change)
2156 (record_property_change):
2157 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2158 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
2159 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2160 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2161 (Fx_hide_tip, Fx_file_dialog):
2162 * w32menu.c (set_frame_menubar):
2163 Use ptrdiff_t, not int, for consistency with rest of code.
2164 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
2165 (select_window, Fdelete_other_windows_internal)
2166 (window_scroll_pixel_based, window_scroll_line_based)
2167 (Frecenter, Fset_window_configuration):
2168 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2169 (Fset_window_hscroll, run_window_configuration_change_hook)
2170 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 2171 (Fscroll_other_window, Frecenter):
d311d28c
PE
2172 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2173 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
2174 Don't assume fixnum fits in int.
2175 (Fset_window_scroll_bars):
2176 Check that fixnums are in proper range for system types.
2177 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
2178 (string_pos, c_string_pos, number_of_chars, init_iterator)
2179 (in_ellipses_for_invisible_text_p, init_from_display_pos)
2180 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
2181 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
2182 (face_before_or_after_it_pos, handle_invisible_prop)
2183 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
2184 (display_prop_intangible_p, string_buffer_position_lim)
2185 (string_buffer_position, handle_composition_prop, load_overlay_strings)
2186 (get_overlay_strings_1, get_overlay_strings)
2187 (iterate_out_of_display_property, forward_to_next_line_start)
2188 (back_to_previous_visible_line_start, reseat, reseat_to_string)
2189 (get_next_display_element, set_iterator_to_next)
2190 (get_visually_first_element, compute_stop_pos_backwards)
2191 (handle_stop_backwards, next_element_from_buffer)
2192 (move_it_in_display_line_to, move_it_in_display_line)
2193 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2194 (add_to_log, message_dolog, message_log_check_duplicate)
2195 (message2, message2_nolog, message3, message3_nolog
2196 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
2197 (current_message_1, truncate_echo_area, truncate_message_1)
2198 (set_message, set_message_1, store_mode_line_noprop)
2199 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
2200 (text_outside_line_unchanged_p, check_point_in_composition)
2201 (reconsider_clip_changes)
2202 (redisplay_internal, set_cursor_from_row, try_scrolling)
2203 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
2204 (redisplay_window, find_last_unchanged_at_beg_row)
2205 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
2206 (trailing_whitespace_p, find_row_edges, display_line)
2207 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
2208 (display_mode_element, store_mode_line_string)
2209 (pint2str, pint2hrstr, decode_mode_spec)
2210 (display_count_lines, display_string, draw_glyphs)
2211 (x_produce_glyphs, x_insert_glyphs)
2212 (rows_from_pos_range, mouse_face_from_buffer_pos)
2213 (fast_find_string_pos, mouse_face_from_string_pos)
2214 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2215 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2216 (safe_call, init_from_display_pos, handle_fontified_prop)
2217 (handle_single_display_spec, load_overlay_strings)
2218 (with_echo_area_buffer, setup_echo_area_for_printing)
2219 (display_echo_area, echo_area_display)
2220 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
2221 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
2222 (redisplay_window, dump_glyph_row, display_mode_line)
2223 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 2224 (handle_display_spec, display_prop_string_p):
d311d28c
PE
2225 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2226 (handle_single_display_spec, build_desired_tool_bar_string)
2227 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
2228 (get_specified_cursor_type):
2229 Check that fixnums are in proper range for system types.
2230 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
2231 (Flookup_image_map):
2232 Don't assume fixnums fit in int.
2233 (compare_overlay_entries):
2234 Avoid mishandling comparisons due to subtraction overflow.
2235 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
2236 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
2237 (handle_tool_bar_click):
2238 Use int, not unsigned, since we prefer signed and the signedness
2239 doesn't matter here.
2240 (get_next_display_element, next_element_from_display_vector):
2241 Use int, not EMACS_INT, when int is wide enough.
2242 (start_hourglass): Use duration_to_sec_usec to do proper
2243 overflow checking on durations.
2244 * xfaces.c (Fbitmap_spec_p):
2245 Check that fixnums are in proper range for system types.
2246 (compare_fonts_by_sort_order):
2247 Avoid mishandling comparisons due to subtraction overflow.
2248 (Fx_family_fonts, realize_basic_faces):
2249 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2250 (Fx_family_fonts):
2251 Don't assume fixnum fits in int.
2252 Use SAFE_ALLOCA_LISP, not alloca.
2253 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
2254 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
2255 (face_at_buffer_position, face_for_overlay_string)
2256 (face_at_string_position):
2257 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2258 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
2259 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
2260 (Fx_show_tip):
2261 Check that fixnums are in proper range for system types.
2262 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2263 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
2264 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2265 (Fx_change_window_property): Don't assume fixnums fit in int.
2266 * xfont.c (xfont_chars_supported):
2267 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2268 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
2269 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
2270 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2271 * xml.c (parse_region):
2272 * xrdb.c (magic_file_p):
2273 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2274 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
2275 (x_get_local_selection, x_reply_selection_request)
2276 (x_handle_selection_request, wait_for_property_change):
2277 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2278 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
2279 short is wide enough.
2280 (x_send_client_event): Don't assume fixnum fits in int.
2281 * xterm.c (x_x_to_emacs_modifiers):
2282 Don't assume EMACS_INT overflows nicely into int.
2283 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
2284 may come from Lisp.
2285 (handle_one_xevent): NATNUMP can eval its arg twice.
2286 (x_connection_closed):
2287 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2288 * xterm.h: Adjust decls to match defn changes elsewhere.
2289 (struct scroll_bar): Use struct vectorlike_header
2290 rather than rolling our own approximation.
2291 (SCROLL_BAR_VEC_SIZE): Remove; not used.
2292
c6574eb5
GM
22932012-05-25 Glenn Morris <rgm@gnu.org>
2294
2295 * lisp.mk (lisp): Update for more files being compiled now.
2296
e8d32c7e
SM
22972012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
2298
48def666
SM
2299 * lread.c: Remove `read_pure' which makes no difference.
2300 (read_pure): Remove var.
2301 (unreadpure): Remove function.
2302 (readevalloop): Don't call read_list with -1 flag.
2303 (read1, read_vector): Don't test read_pure any more.
2304 (read_list): Simplify.
2305
e8d32c7e
SM
2306 * fileio.c, character.h: Minor style tweaks.
2307
4b2addb7
DA
23082012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
2309
2310 * window.h (clip_changed): Remove useless declaration.
2311
584461b2
JB
23122012-05-22 Juanma Barranquero <lekktu@gmail.com>
2313
2314 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
2315 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
2316
34374650
PE
23172012-05-22 Paul Eggert <eggert@cs.ucla.edu>
2318
2319 Remove src/m/*.
2320 This directory predates autoconf and is no longer needed nowadays.
2321 Move its few remaining bits of functionality to where they're needed.
2322 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
2323 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
2324 * m/template.h: Remove.
2325 * Makefile.in (M_FILE): Remove. All uses removed.
2326 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
2327 * lisp.h (USE_LSB_TAG):
2328 * mem-limits.h (EXCEEDS_LISP_PTR):
2329 Use VAL_MAX, not VALBITS, in #if.
2330 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
2331 (EMACS_UINT): Define unconditionally now.
2332 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
2333 (BITS_PER_EMACS_INT): New constants, replacing
2334 what used to be in config.h, but not useful in #if.
2335 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
2336 define them any more.
2337 (VAL_MAX): New macro.
2338 (VALMASK): Use it.
2339 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
2340 BITS_PER_EMACS_INT, in #if.
2341 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
2342 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
2343 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
2344 * s/ms-w32.h (DATA_START):
2345 Move here from removed file m/intel386.h.
2346 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
2347 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
2348
261cb4bb
PE
23492012-05-21 Paul Eggert <eggert@cs.ucla.edu>
2350
2351 Assume C89 or later.
2352 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
2353 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
2354 (xrealloc):
2355 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
2356 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
2357 * textprop.c, tparam.c (NULL): Remove.
2358 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
2359 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
2360 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
2361 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
2362 * xterm.c (input_signal_count): Assume volatile works.
2363
ff23cd9f
KB
23642012-05-21 Ken Brown <kbrown@cornell.edu>
2365
2366 * xgselect.c (xg_select): Fix first argument in call to 'select'
2367 (bug#11508).
2368
1b170bc6
KB
23692012-05-20 Ken Brown <kbrown@cornell.edu>
2370
2371 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 2372 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 2373
b2f4d39f
KB
23742012-05-19 Ken Brown <kbrown@cornell.edu>
2375
2376 * xfns.c (x_in_use): Remove `static' qualifier.
2377 * xterm.h (x_in_use): Declare.
2378 * xgselect.c: Include xterm.h.
2379 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
2380 and `display_arg' (bug#9754).
2381
003fdae2
PE
23822012-05-19 Paul Eggert <eggert@cs.ucla.edu>
2383
9232a6d9
PE
2384 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
2385
003fdae2
PE
2386 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
2387 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
2388
784b56e2
EZ
23892012-05-18 Eli Zaretskii <eliz@gnu.org>
2390
2391 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
2392
2393 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
2394 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
2395
2396 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
2397 reference to image_cache->refcount.
2398 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
2399
a0a79cde
JL
24002012-05-17 Juri Linkov <juri@jurta.org>
2401
2402 * search.c (Fword_search_regexp, Fword_search_backward)
2403 (Fword_search_forward, Fword_search_backward_lax)
2404 (Fword_search_forward_lax): Move functions to isearch.el
2405 (bug#10145, bug#11381).
2406
b0572523
PE
24072012-05-16 Paul Eggert <eggert@cs.ucla.edu>
2408
2409 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
2410
9660f5fc
SM
24112012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
2412
2413 * lread.c (init_obarray): Declare Qt and Qnil as special.
2414
4374de83
GM
24152012-05-14 Glenn Morris <rgm@gnu.org>
2416
2417 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 2418 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 2419
dc44c39a
PE
24202012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2421
078c97cb
PE
2422 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
2423
dc44c39a
PE
2424 * unexaix.c: Port to more-recent AIX compilers.
2425 (report_error, report_error_1, make_hdr, copy_sym)
2426 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
2427 Make arguments const char *, not char *, to avoid violations of C
2428 standard and to fix some AIX warnings reported by Gilles Pion.
2429
e18afed7 24302012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
2431
2432 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
2433 already have overlays loaded.
2434 (handle_single_display_spec): Before returning without displaying
2435 fringe bitmap, synchronize the bidi iterator with the main display
2436 iterator, by calling iterate_out_of_display_property.
2437 (iterate_out_of_display_property): Detect buffer iteration by
2438 testing that it->string is a Lisp string.
2439 (get_next_display_element): When the current object is exhausted,
2440 and there's something on it->stack, call set_iterator_to_next to
2441 proceed with what's on the stack, instead of returning zero.
2442 (set_iterator_to_next): If called at the end of a Lisp string,
2443 proceed to consider_string_end without incrementing string
2444 position. Don't increment display vector index past the end of
2445 the display vector. (Bug#11417)
c8fb9dc6
EZ
2446 (pos_visible_p): Don't report a position visible when move_it_to
2447 stopped at the last line of window, which happens to be scanned
2448 backwards by the bidi iteration. (Bug#11464)
ac268e67 2449
e18afed7 24502012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
2451
2452 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
2453 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
2454 are on a TTY, and thus unable to display on the fringes.
2455 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
2456 so we need to signal to the caller that this is a "replacing"
2457 display spec. This fixes display when the spec is invalid or we
2458 are on a TTY.
2459
e18afed7 24602012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
2461
2462 * unexaix.c (make_hdr): Fix typo in prototype.
2463 This bug broke the build on AIX. Problem reported by Gilles Pion.
2464
9d0a235a
MA
24652012-05-14 Michael Albinus <michael.albinus@gmx.de>
2466
2467 * keyboard.c (kbd_buffer_get_event): Read special events also in
2468 batch mode. (Bug#11415)
2469
9e6b06ed
GM
24702012-05-12 Glenn Morris <rgm@gnu.org>
2471
2472 * ns.mk: Update for ns_appbindir no longer having trailing "/".
2473
c1a1d7a3
EZ
24742012-05-12 Eli Zaretskii <eliz@gnu.org>
2475
2476 * lisp.mk (lisp): Add newcomment.elc.
2477
3fe7cdc8
GM
24782012-05-12 Glenn Morris <rgm@gnu.org>
2479
2480 * Makefile.in (MKDIR_P): New, set by configure.
2481 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
2482
53f7d2c0
PE
24832012-05-11 Paul Eggert <eggert@cs.ucla.edu>
2484
2485 Remove unused function hourglass_started.
2486 * dispextern.h (hourglass_started):
2487 * w32fns.c (hourglass_started):
2488 * xdisp.c (hourglass_started): Remove.
2489
75aafb17
JB
24902012-05-10 Juanma Barranquero <lekktu@gmail.com>
2491
2492 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
2493 Update dependencies.
2494
12959e8e
PE
24952012-05-10 Paul Eggert <eggert@cs.ucla.edu>
2496
97107e2e
PE
2497 * xgselect.c (xg_select): Put maxfds+1 into a var.
2498 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
2499
12959e8e
PE
2500 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
2501
836d29b3
DA
25022012-05-10 Dave Abrahams <dave@boostpro.com>
2503
2504 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
2505 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
2506
5cb67954
MA
25072012-05-09 Michael Albinus <michael.albinus@gmx.de>
2508
2509 * dbusbind.c (xd_registered_buses): New internal Lisp object.
2510 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
2511 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
2512 Initialize xd_registered_buses.
2513
3478ec45
PE
25142012-05-09 Paul Eggert <eggert@cs.ucla.edu>
2515
b263a6b0
PE
2516 Untag more efficiently if USE_LSB_TAG.
2517 This is based on a proposal by YAMAMOTO Mitsuharu in
2518 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
2519 For an admittedly artificial (nth 8000 longlist) benchmark on
2520 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
2521 Emacs's overall text size by 1%.
2522 * lisp.h (XUNTAG): New macro.
2523 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
2524 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
2525 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
2526 * eval.c (Fautoload):
2527 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
2528 * frame.h (XFRAME): Use XUNTAG.
2529
3478ec45
PE
2530 Port recent dbusbind.c changes to 32-bit --with-wide-int.
2531 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
2532 Remove unportable assumptions about print widths of types like
2533 dbus_uint32_t.
2534 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
2535 intptr_t when converting between pointer and integer, to avoid GCC
2536 warnings about wrong width.
2537
666b903b 25382012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
2539
2540 * w32proc.c (new_child): Force Windows to reserve only 64KB of
2541 stack for each reader_thread, instead of defaulting to 8MB
2542 determined by the linker. This avoids failures in creating
2543 subprocesses on Windows 7, see the discussion in this thread:
2544 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
2545
b120cc17
JC
25462012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
2547
2548 Fix up display of the *Minibuf-0* buffer in the mini window.
2549 * keyboard.c (read_char): Don't clear the echo area if there's no
2550 message to clear.
2551 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 2552 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 2553
9a4b36f8
MA
25542012-05-07 Michael Albinus <michael.albinus@gmx.de>
2555
2556 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
2557 batch mode.
2558
e5f9458f
CY
25592012-05-06 Chong Yidong <cyd@gnu.org>
2560
2561 * lisp.mk (lisp): Update.
2562
eceeb5fc 25632012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
2564
2565 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
2566
71873e2b
SM
25672012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
2568
2569 * data.c (PUT_ERROR): New macro.
2570 (syms_of_data): Use it. Add new error type `user-error'.
2571 * undo.c (user_error): New function.
2572 (Fprimitive_undo): Use it.
2573 * print.c (print_error_message): Adjust print style for `user-error'.
2574 * keyboard.c (user_error): New function.
2575 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
2576
ab0fa4e4
PE
25772012-05-03 Paul Eggert <eggert@cs.ucla.edu>
2578
2579 Do not limit current-time-string to years 1000..9999.
2580 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
2581 (Fcurrent_time_string): Support any year that is supported by the
2582 underlying localtime representation. Don't use asctime, as it
2583 has undefined behavior for years outside the range -999..9999.
2584
7ed806a7
PE
25852012-05-02 Paul Eggert <eggert@cs.ucla.edu>
2586
2587 Fix race conditions involving setenv, gmtime, localtime, asctime.
2588 Without this fix, interrupts could mess up code that uses these
2589 nonreentrant functions, since setting TZ invalidates existing
2590 tm_zone or tzname values, and since most of these functions return
2591 pointers to static storage.
2592 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
2593 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
2594 Grow the critical sections to include not just invoking
2595 localtime/gmtime, but also accessing these functions' results
2596 including their tm_zone values if any, and any related TZ setting.
2597 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
2598 so that the struct tm is saved in the critical section.
2599 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
2600 motivated by the fact that memory allocation needs to be outside
2601 the critical section.
2602
0c16dfed
DA
26032012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
2604
2605 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
2606 with RESET_INTERVAL.
2607
2608 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2609 Remove duplicated buffer name initialization.
2610
3f83ace8
JM
26112012-05-02 Jim Meyering <jim@meyering.net>
2612
2613 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
2614
c7b8541e
JM
2615 * xfns.c (x_window): Use xstrdup (Bug#11375).
2616
90207a15 26172012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
2618
2619 * xdisp.c (pos_visible_p): If already at a newline from the
2620 display string before the 'while' loop, don't walk back the glyphs
2621 from it3.glyph_row. Solves assertion violation when the display
2622 string begins with a newline (egg.el). (Bug#11367)
2623
b593d6a9
AH
26242012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
2625
2626 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
2627 Move to simple.el.
2628
4737362e
GM
26292012-05-01 Glenn Morris <rgm@gnu.org>
2630
99cf43f9
GM
2631 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
2632 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
2633 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
2634 All were removed before 23.1.
2635
9311dcff
GM
2636 * dispnew.c: Remove HAVE_LIBNCURSES test;
2637 it is always true on relevant platforms.
2638
4d5c6349
GM
2639 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
2640 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
2641
4737362e
GM
2642 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
2643
74dd3a6b
AS
26442012-04-30 Andreas Schwab <schwab@linux-m68k.org>
2645
2646 * .gdbinit (xpr): Remove checks for no longer existing misc types.
2647 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
2648 Remove.
2649
13c379ee
PE
26502012-04-28 Paul Eggert <eggert@cs.ucla.edu>
2651
2652 Do not avoid creating empty evaporating overlays (Bug#9642).
2653 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
2654 That is, do not delete an evaporating overlay if it becomes
2655 empty after its bounds are adjusted to fit within its buffer.
2656 This fix caused other problems, and I'm reverting it until we get
2657 to the bottom of them.
2658
a8e7d6d7 26592012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
2660
2661 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
2662
a8e7d6d7 26632012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
2664
2665 * xdisp.c (pos_visible_p): If the window start position is beyond
2666 ZV, start the display from buffer beginning. Prevents assertion
2667 violation in init_iterator when the minibuffer window is scrolled
2668 via the scroll bar.
2669
2670 * window.c (window_scroll_pixel_based): Likewise.
2671
a8e7d6d7 26722012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
2673
2674 * keymap.c (where_is_internal): Doc fix (Bug#10872).
2675
a8e7d6d7 26762012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
2677
2678 * fileio.c (Fcopy_file, Fset_file_selinux_context):
2679 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
2680
a8e7d6d7 26812012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 2682
b593d6a9
AH
2683 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
2684 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 2685
1c6900d9
EZ
26862012-04-26 Eli Zaretskii <eliz@gnu.org>
2687
4c3fa1d9
EZ
2688 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
2689 display element, check also the underlying string or buffer
2690 character. (Bug#11341)
2691
1c6900d9
EZ
2692 * w32menu.c: Include w32heap.h.
2693 (add_menu_item): If the call to AppendMenuW (via
2694 unicode_append_menu) fails, disable Unicode menus only if we are
2695 running on Windows 9X/Me.
2696
42bf8205
AS
26972012-04-24 Andreas Schwab <schwab@linux-m68k.org>
2698
2699 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
2700 (xgetint): Add missing shift for LSB tags.
2701
b1bac16e
MR
27022012-04-24 Martin Rudalics <rudalics@gmx.at>
2703
2704 * keyboard.c (read_char): Don't wipe echo area for select window
2705 events: These might get delayed via `mouse-autoselect-window'
2706 (Bug#11304).
2707
d69621cc
JB
27082012-04-24 Juanma Barranquero <lekktu@gmail.com>
2709
2710 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
2711 manipulation of :loaded-from data.
2712
02fd101b
JB
27132012-04-23 Juanma Barranquero <lekktu@gmail.com>
2714
2715 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
2716 now a cons (bug#11311).
2717
888bec30
PE
27182012-04-23 Paul Eggert <eggert@cs.ucla.edu>
2719
89a438bd
PE
2720 Do not create empty overlays with the evaporate property (Bug#9642).
2721 * buffer.c (Fmove_overlay): Delete an evaporating overlay
2722 if it becomes empty after its bounds are adjusted to fit within
2723 its buffer. Without this fix, in a nonempty buffer (let ((o
2724 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
2725 yields an empty overlay that has the evaporate property, which is
2726 not supposed to happen.
2727
1068fe4d
PE
2728 Fix minor GTK3 problems found by static checking.
2729 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2730 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2731 (struct _EmacsFixedClass, emacs_fixed_get_type):
2732 Move decls here from emacsgtkfixed.h, since they needn't be public.
2733 (emacs_fixed_get_type): Now static.
2734 (emacs_fixed_class_init): Omit unused local.
2735 (emacs_fixed_child_type): Remove; unused.
2736 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2737 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2738 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
2739 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
2740 (EMACS_FIXED_GET_CLASS): Remove; unused.
2741 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
2742
888bec30
PE
2743 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
2744 Problem reported by Juanma Barranquero for Windows -Wunused-function.
2745
de85e130
PE
27462012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2747
d0baac98 2748 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 2749 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
2750 (__malloc_size_t, __malloc_ptrdiff_t):
2751 Remove. All uses removed, replaced by the definiens if needed,
2752 since we can assume C89 or better now.
2753 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
2754 (protect_malloc_state, align, get_contiguous_space)
2755 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
2756 (malloc_atfork_handler_child, malloc_enable_thread)
2757 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
2758 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
2759 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
2760 (special_realloc, _realloc_internal_nolock, _realloc_internal)
2761 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
2762 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
2763 Define using prototypes, not old style.
2764 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
2765 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
2766 (align): Don't assume that signed integer overflow wraps around.
2767 Omit unused local var.
2768 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
2769 (_free_internal_nolock, memalign, mallochook, reallochook):
2770 Omit no-longer-needed casts.
2771 (valloc): Use getpagesize, not __getpagesize.
2772 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
2773 (struct hdr): The 'magic' member is now size_t, not unsigned long.
2774
de85e130
PE
2775 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
2776
dcbf5805
MA
27772012-04-22 Michael Albinus <michael.albinus@gmx.de>
2778
2779 Move functions from C to Lisp. Make non-blocking method calls
2780 the default. Implement further D-Bus standard interfaces.
2781
2782 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
2783 (QCdbus_request_name_allow_replacement)
2784 (QCdbus_request_name_replace_existing)
2785 (QCdbus_request_name_do_not_queue)
2786 (QCdbus_request_name_reply_primary_owner)
2787 (QCdbus_request_name_reply_in_queue)
2788 (QCdbus_request_name_reply_exists)
2789 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
2790 (QCdbus_registered_serial, QCdbus_registered_method)
2791 (QCdbus_registered_signal): New Lisp objects.
2792 (XD_DEBUG_MESSAGE): Use sizeof.
2793 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
2794 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
2795 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
2796 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
2797 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
2798 (xd_signature, xd_append_arg): Allow float for integer types.
2799 (xd_get_connection_references): New function.
b593d6a9
AH
2800 (xd_get_connection_address): Rename from xd_initialize.
2801 Return cached address.
dcbf5805
MA
2802 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
2803 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
2804 level.
2805 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 2806 Return number of refcounts.
dcbf5805
MA
2807 (Fdbus_get_unique_name): Make stronger parameter check.
2808 (Fdbus_message_internal): New defun.
2809 (Fdbus_call_method, Fdbus_call_method_asynchronously)
2810 (Fdbus_method_return_internal, Fdbus_method_error_internal)
2811 (Fdbus_send_signal, Fdbus_register_service)
2812 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
2813 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
2814 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
2815 (Vdbus_compiled_version, Vdbus_runtime_version)
2816 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
2817 (Vdbus_message_type_method_return, Vdbus_message_type_error)
2818 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
2819 (Vdbus_registered_buses, Vdbus_registered_objects_table):
2820 Adapt docstring.
dcbf5805 2821
52828e02
PE
28222012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2823
da05bc4c
PE
2824 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
2825 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
2826 Do not assume ptrdiff_t is the same width as 'int'.
2827
52828e02
PE
2828 * alloc.c: Handle unusual debugging option combinations.
2829 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
2830 since the two debugging options are incompatible.
2831 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
2832 is defined.
2833 (mem_init, mem_insert, mem_insert_fixup):
2834 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
2835 (NEED_MEM_INSERT): Remove; no longer needed.
2836
f01769f9
LL
28372012-04-22 Leo Liu <sdl.web@gmail.com>
2838
2839 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
2840
5790543d
PE
28412012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2842
2843 * sysdep.c [__FreeBSD__]: Minor cleanups.
2844 (list_system_processes, system_process_attributes) [__FreeBSD__]:
2845 Use Emacs indenting style more consistently. Avoid some casts.
2846 Use 'double' consistently rather than mixing 'float' and 'double'.
2847
b91b7e4d
EW
28482012-04-21 Eduard Wiebe <usenet@pusto.de>
2849
b593d6a9
AH
2850 * sysdep.c (list_system_processes, system_process_attributes):
2851 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 2852
6114eb15
AS
28532012-04-21 Andreas Schwab <schwab@linux-m68k.org>
2854
2855 * lisp.mk (lisp): Update.
2856
2f38dff7
PE
28572012-04-20 Paul Eggert <eggert@cs.ucla.edu>
2858
2859 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
2860 It is never used otherwise.
2861
4ae29f89
SM
28622012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
2863
2864 * print.c (print_preprocess): Only check print_depth if print-circle
2865 is nil.
2866 (print_object): Check for cycles even when print-circle is nil and
2867 print-gensym is t, but only check print_depth if print-circle is nil.
2868
f30d612a
CY
28692012-04-20 Chong Yidong <cyd@gnu.org>
2870
2871 * process.c (wait_reading_process_output): If EIO occurs on a pty,
2872 set the status to "failed" and ensure that sentinel is run.
2873
c07a4c0b 28742012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
2875
2876 * process.c (Fset_process_inherit_coding_system_flag)
2877 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 2878 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 2879
c07a4c0b 28802012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
2881
2882 * xdisp.c (string_buffer_position_lim): Limit starting position to
2883 BEGV.
2884 (set_cursor_from_row): If called for a mode-line or header-line
2885 row, return zero immediately.
2886 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
2887 farther than the first row after the header line, if any.
2888 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
2889 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
2890
c07a4c0b 28912012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 2892
4ae29f89
SM
2893 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
2894 (bug#11238).
ad3a2b41 2895
c07a4c0b 28962012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 28972012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
2898
2899 configure: new option --enable-gcc-warnings (Bug#11207)
2900 * Makefile.in (C_WARNINGS_SWITCH): Remove.
2901 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
2902 (ALL_CFLAGS): Use new macros rather than old.
2903 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
2904 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
2905 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
2906 -Wunused-result, -Wunused-variable. This should go away once
2907 the Emacs and Gnulib regex code is merged.
2908 (xmalloc, xrealloc): Now static.
2909
aba027e8
PE
29102012-04-17 Paul Eggert <eggert@cs.ucla.edu>
2911
2912 * dired.c (Fsystem_groups): Remove unused local.
2913
e5a36063
GM
29142012-04-17 Glenn Morris <rgm@gnu.org>
2915
2916 * dired.c (Fsystem_users): Doc fix.
2917
316411f0
DA
29182012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
2919
2920 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
2921 (syms_of_dired): Add them.
2922
9426aba4
PE
29232012-04-16 Paul Eggert <eggert@cs.ucla.edu>
2924
b62a57be
PE
2925 Fix minor alloc.c problems found by static checking.
2926 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
2927 New extern decls, to avoid calling undeclared functions.
2928 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
2929 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
2930 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
2931 (NEED_MEM_INSERT): New macro.
2932 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 2933 Remove one incorrect comment and fix another.
b62a57be 2934
3539f31f
PE
2935 Fix minor ralloc.c problems found by static checking.
2936 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2937 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
2938 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
2939 (r_alloc_sbrk): Now static.
2940
a041960a
PE
2941 Improve ralloc.c interface checking.
2942 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2943 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
2944 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
2945 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
2946 [REL_ALLOC]: ... to here, to check interface.
2947 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
2948 Remove decls. This fixes an "It stinks!".
2949
9426aba4
PE
2950 * alloc.c (which_symbols): Fix alignment issue / type clash.
2951
d55c12ed
AS
29522012-04-15 Andreas Schwab <schwab@linux-m68k.org>
2953
2954 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
2955 (struct Lisp_Misc_Any): Likewise.
2956 (struct Lisp_Free): Likewise.
2957 * alloc.c (union aligned_Lisp_Symbol): Define.
2958 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
2959 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
2960 (union aligned_Lisp_Misc): Define.
2961 (MARKER_BLOCK_SIZE, struct marker_block): Use union
2962 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 2963 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 2964
b948ce8b
PE
29652012-04-14 Paul Eggert <eggert@cs.ucla.edu>
2966
2967 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
2968 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
2969 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
2970 * s/netbsd.h, s/sol2-6.h:
2971 Remove definition of GC_MARK_STACK, since the default now works.
2972 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
2973 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
2974 no longer the default.
2975 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
2976
35dc09a1 29772012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 2978
35dc09a1
GM
2979 * lread.c (lisp_file_lexically_bound_p):
2980 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 2981
35dc09a1
GM
29822012-04-14 Eli Zaretskii <eliz@gnu.org>
2983
2984 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
2985 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
2986
29872012-04-14 Jan Djärv <jan.h.d@swipnet.se>
2988
2989 * nsterm.m (constrainFrameRect): Always constrain when there is only
2990 one screen (Bug#10962).
2991
bcd86815
KB
29922012-04-13 Ken Brown <kbrown@cornell.edu>
2993
2994 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
2995
c25df26e
RT
29962012-04-13 Reuben Thomas <rrt@sc3d.org>
2997
2998 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
2999
0fc59f1e
DC
30002012-04-11 Daniel Colascione <dancol@dancol.org>
3001
3002 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
3003 against is gone. It's better to use vfork now so that when Cygwin
3004 gains a new, working vfork, we use it automatically (bug#10398).
3005
de8c03dc
SM
30062012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3007
3008 * window.c (save_window_save): Obey window-point-insertion-type.
3009
2f097256
GM
30102012-04-11 Glenn Morris <rgm@gnu.org>
3011
3012 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
3013
453b951e
SM
30142012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3015
3016 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
3017
75f1671a 30182012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
3019
3020 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
3021 (force_quit_count): New var.
3022 (handle_interrupt): Use it.
3023
2a8ce227
JB
30242012-04-10 Juanma Barranquero <lekktu@gmail.com>
3025
3026 * w32.c (w32_delayed_load): Record the full path of the library
3027 being loaded (bug#10424).
3028
935396c0
GM
30292012-04-09 Glenn Morris <rgm@gnu.org>
3030
05920a43
GM
3031 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
3032 not just in the obarray, before snarfing them. (Bug#11036)
3033
935396c0
GM
3034 * Makefile.in ($(leimdir)/leim-list.el):
3035 Pass EMACS rather than BUILT_EMACS.
3036
a18ecafa
TZ
30372012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
3038
3039 * process.c (make_process):
3040 * process.h: Add integer `gnutls_handshakes_tried' member to
3041 process struct.
3042
6bbef4e5
JC
3043 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
3044 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
3045
3046 * gnutls.c (gnutls_log_function2i): Convenience log function.
3047 (emacs_gnutls_read): Use new log functions,
3048 `gnutls_handshakes_tried' process member, and
3049 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
3050 attempts per process (connection).
3051
b4d3bc10
CY
30522012-04-09 Chong Yidong <cyd@gnu.org>
3053
3054 * eval.c (Fuser_variable_p, user_variable_p_eh)
3055 (lisp_indirect_variable): Functions deleted.
3056 (Fdefvar): Caller changed.
3057
3058 * callint.c (Finteractive, Fcall_interactively):
3059 * minibuf.c (Fread_variable): Callers changed.
3060
70f4d973
EZ
30612012-04-09 Eli Zaretskii <eliz@gnu.org>
3062
3063 * xdisp.c (set_cursor_from_row): If the display string appears in
3064 the buffer at position that is closer to point than the position
3065 after the display string, display the cursor on the first glyph of
3066 the display string. Fixes cursor display when a 'display' text
3067 property immediately follows invisible text. (Bug#11094)
3068
cb3c2e3e
PE
30692012-04-09 Paul Eggert <eggert@cs.ucla.edu>
3070
3071 composite.c: use 'double' consistently
3072 * composite.c (get_composition_id): Use 'double' consistently
3073 instead of converting 'float' to 'double' and vice versa; this is
3074 easier to understand and avoids a GCC warning.
3075
fd06db5d
GM
30762012-04-09 Glenn Morris <rgm@gnu.org>
3077
50fe702a
GM
3078 * Makefile.in: Generate leim-list with bootstrap-emacs, in
3079 preparation for dumping it with emacs. (Bug#4789)
3080 (leimdir): New variable.
3081 ($(leimdir)/leim-list.el): New rule.
3082 (emacs$(EXEEXT)): Depend on leim-list.el.
3083
fd06db5d
GM
3084 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
3085 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
3086 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
3087
55c131ee
AS
30882012-04-08 Andreas Schwab <schwab@linux-m68k.org>
3089
3090 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
3091 proper alignment.
3092
9209588f
JB
30932012-04-07 Juanma Barranquero <lekktu@gmail.com>
3094
3095 * xml.c (init_libxml2_functions) [WINDOWSNT]:
3096 Remove unused local variable.
3097
e3fb2efb
PE
30982012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3099
3100 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
3101 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
3102 (mark_memory): Mark Lisp_Objects only if pointers might hide in
3103 objects, as mark_maybe_pointer will catch them otherwise.
3104 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
3105 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
3106
b5385551
PE
31072012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3108
3109 Fix typo that broke non-Windows builds.
3110 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
3111
9078ead6
EZ
31122012-04-07 Eli Zaretskii <eliz@gnu.org>
3113
3114 Support building on MS-Windows with libxml2.
3115
3116 * makefile.w32-in (OBJ2): Add xml.$(O).
3117 (GLOBAL_SOURCES): Add xml.c.
3118 ($(BLD)/xml.$(O)): New dependency list.
3119
3120 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
3121 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
3122 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
3123 [!WINDOWSNT]: New macros.
3124 (init_libxml2_functions, libxml2_loaded_p): New functions.
3125 (parse_region): Call fn_xmlCheckVersion instead of using the macro
3126 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
3127 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
3128 Calls xmlCleanupParser only if libxml2 was loaded (or statically
3129 linked in).
6bbef4e5
JC
3130 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
3131 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
3132 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
3133
3134 * emacs.c: Don't include libxml/parser.h.
3135 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
3136 xmlCleanupParser directly.
3137
3138 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
3139
3811fdf3
EZ
31402012-04-07 Eli Zaretskii <eliz@gnu.org>
3141
3142 * indent.c (Fvertical_motion): If there is a display string at
3143 point, use it.vpos to compute how many lines to backtrack after
3144 move_it_to point. (Bug#11133)
3145
2f8e16b2
EZ
31462012-04-06 Eli Zaretskii <eliz@gnu.org>
3147
3148 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
3149 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
3150 about subtle differences between FETCH_CHAR* and STRING_CHAR*
3151 macros related to unification of CJK characters. For the details,
3152 see the discussion following the message here:
3153 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
3154
3d439cd1
CY
31552012-04-04 Chong Yidong <cyd@gnu.org>
3156
3157 * keyboard.c (Vdelayed_warnings_list): Doc fix.
3158
8bc53d00
EZ
31592012-04-01 Eli Zaretskii <eliz@gnu.org>
3160
3161 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
3162 instead of alloca. (Bug#11138)
3163
3b0512a3
AS
31642012-04-01 Andreas Schwab <schwab@linux-m68k.org>
3165
3166 * w32menu.c (is_simple_dialog): Properly check lisp types.
3167 (Bug#11141)
3168
8427ddd2
EZ
31692012-03-31 Eli Zaretskii <eliz@gnu.org>
3170
979022ef
EZ
3171 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
3172 position we get to after a call to move_it_to fails the
3173 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
3174 only if we wind up in a string from display property. (Bug#11063)
3175
a6b1c7cc
EZ
3176 * window.c (Fdelete_other_windows_internal): Invalidate the row
3177 and column information about mouse highlight, so that redisplay
3178 restores it after reallocating the glyph matrices. (Bug#7464)
3179
8427ddd2
EZ
3180 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
3181 string comes from a `display' text property, use the buffer
3182 position of that property as if we actually saw that position in
3183 the row's glyphs.
697ba24b
EZ
3184 (move_it_by_lines): Remove the assertion that
3185 "it->current_x == 0 && it->hpos == 0" which can be legitimately
3186 violated when there's a before-string at the beginning of a line.
3187 (Bug#11063)
8427ddd2 3188
65a0a738
EZ
31892012-03-30 Eli Zaretskii <eliz@gnu.org>
3190
3191 * xdisp.c (append_space_for_newline): If the default face was
3192 remapped, use the remapped face for the appended newline.
3193 (extend_face_to_end_of_line): Use the remapped default face for
3194 extending the face to the end of the line.
3195 (display_line): Call extend_face_to_end_of_line when the default
3196 face was remapped. (Bug#11068)
3197
581355cc
EZ
31982012-03-29 Eli Zaretskii <eliz@gnu.org>
3199
3200 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
3201
e8fc049f
SM
32022012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3203
3204 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
3205
4fb9a543
GM
32062012-03-27 Glenn Morris <rgm@gnu.org>
3207
3208 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
3209 Doc fixes.
3210
679910f1
KH
32112012-03-26 Kenichi Handa <handa@m17n.org>
3212
3213 * dispextern.h (struct glyph): Fix previous change. Change the
3214 bit length of glyphless.ch to 25 (Bug#11082).
3215
90d49b7f
CY
32162012-03-26 Chong Yidong <cyd@gnu.org>
3217
3218 * keyboard.c (Vselection_inhibit_update_commands): New variable.
3219 (command_loop_1): Use it; inhibit selection update for
3220 handle-select-window too (Bug#8996).
3221
f514f6f0
FP
32222012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
3223
e8fc049f 3224 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 3225
bf43fa51
KH
32262012-03-25 Kenichi Handa <handa@m17n.org>
3227
3228 * dispextern.h (struct glyph): Change the bit length of
3229 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
3230
8a0c01dd
EZ
32312012-03-24 Eli Zaretskii <eliz@gnu.org>
3232
3233 * s/ms-w32.h (tzname): Include time.h before redirecting to
3234 _tzname. Fixes the MSVC build. (Bug#9960)
3235
7d1c3a76
AS
32362012-03-24 Andreas Schwab <schwab@linux-m68k.org>
3237
8ed79523
AS
3238 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
3239 characters.
3240
7d1c3a76
AS
3241 * xterm.c (XTread_socket): Only modify handling_signal if
3242 !SYNC_INPUT. (Bug#11080)
3243
e99a9b8b
EZ
32442012-03-23 Eli Zaretskii <eliz@gnu.org>
3245
3246 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
3247 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
3248 when fetching a multibyte character consumes more bytes than
3249 CHAR_BYTES returns, due to unification of CJK characters in
3250 string_char. (Bug#11073)
3251
5063c0e1
TN
32522012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
3253
3254 * process.c (wait_reading_process_output): Handle pty disconnect
3255 by refraining from sending oneself a SIGCHLD (bug#10933).
3256
9f851fbd
CY
32572012-03-22 Chong Yidong <cyd@gnu.org>
3258
3259 * dispextern.h (struct it): New member string_from_prefix_prop_p.
3260
5063c0e1 3261 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
3262 Mark string as coming from a prefix property.
3263 (handle_face_prop): Use default face for prefix strings (Bug#4281).
3264 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
3265
fb5b8aca
CY
32662012-03-21 Chong Yidong <cyd@gnu.org>
3267
3268 * xfaces.c (Vface_remapping_alist): Doc fix.
3269
62356a1b
EZ
32702012-03-20 Eli Zaretskii <eliz@gnu.org>
3271
3272 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
3273 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
3274 Doc fixes.
62356a1b 3275
025de85b
CY
32762012-03-20 Chong Yidong <cyd@gnu.org>
3277
3278 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
3279 to reflect default non-nil value of redisplay-dont-pause.
3280
4827f94e
KH
32812012-03-19 Kenichi Handa <handa@m17n.org>
3282
3283 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
3284 it fit in a valid range (Bug#11003).
3285
e50a24a2
EZ
32862012-03-18 Eli Zaretskii <eliz@gnu.org>
3287
3288 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
3289 that is not from display property, accept the row as a "cursor
3290 row" if one of the string's character has a non-nil `cursor'
3291 property. Fixes cursor positioning when there are newlines in
3292 overlay strings, e.g. in icomplete.el. (Bug#11035)
3293
9af5ed87
PE
32942012-03-12 Paul Eggert <eggert@cs.ucla.edu>
3295
3296 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
3297
d1f55f16
CY
32982012-03-12 Chong Yidong <cyd@gnu.org>
3299
3300 * eval.c (inhibit_lisp_code): Rename from
3301 inhibit_window_configuration_change_hook; move from window.c.
3302
3303 * xfns.c (unwind_create_frame_1, Fx_create_frame):
3304 * window.c (run_window_configuration_change_hook)
3305 (syms_of_window): Callers changed.
3306
66c5eebd
CY
33072012-03-11 Chong Yidong <cyd@gnu.org>
3308
413df973
CY
3309 * keymap.c (Fkey_description): Doc fix (Bug#9700).
3310
66c5eebd
CY
3311 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
3312
1de11f56
CY
33132012-03-10 Chong Yidong <cyd@gnu.org>
3314
3315 * frame.c (other_visible_frames): Don't assume the selected frame
3316 is visible (Bug#10955).
3317
cae07000
SM
33182012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
3319
3320 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
3321
89c94350
JD
33222012-03-08 Jan Djärv <jan.h.d@swipnet.se>
3323
3324 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
3325 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
3326 zero (Bug#10954).
3327
999dd333
GM
33282012-03-03 Glenn Morris <rgm@gnu.org>
3329
01a6dcc8 3330 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 3331
de0100f2
EZ
33322012-03-02 Eli Zaretskii <eliz@gnu.org>
3333
3334 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
3335 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
3336 (redisplay_window, next_element_from_string): Fix typos in
3337 comments.
3e441275
EZ
3338 (redisplay_window): Pass to move_it_vertically the margin in
3339 pixels, not in screen lines.
de0100f2 3340
96a72ee9
GM
33412012-03-02 Glenn Morris <rgm@gnu.org>
3342
3343 * buffer.c (buffer-list-update-hook): Doc fix.
3344
312508d7
EZ
33452012-02-29 Eli Zaretskii <eliz@gnu.org>
3346
3347 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
3348 push_it before setting up the iterator for the first overlay
3349 string, even if we have an empty string loaded.
3350 (next_overlay_string): If there's an empty string on the iterator
3351 stack, pop the stack. (Bug#10903)
3352
27f3c637
PE
33532012-02-25 Paul Eggert <eggert@cs.ucla.edu>
3354
3355 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
3356 Suggested by Stefan Monnier in
3357 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
3358 * alloc.c (widen_to_Lisp_Object): New static function.
3359 (mark_memory): Also mark Lisp_Objects by fetching pointer words
3360 and widening them to Lisp_Objects. This would work even if
3361 USE_LSB_TAG is defined and wide integers are used, which might
3362 happen in a future version of Emacs.
3363
3c9dfce6
CY
33642012-02-25 Chong Yidong <cyd@gnu.org>
3365
fa74b241
CY
3366 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
3367 Doc fix.
3368
3c9dfce6
CY
3369 * xselect.c (Fx_selection_exists_p): Doc fix.
3370 (x_clipboard_manager_save_all): Print an informative message
3371 before saving to clipboard manager.
3372
9486df08
CY
33732012-02-24 Chong Yidong <cyd@gnu.org>
3374
3375 * keyboard.c (process_special_events): Handle all X selection
3376 requests in kbd_buffer, not just the next one (Bug#8869).
3377
f01d3321
CY
33782012-02-23 Chong Yidong <cyd@gnu.org>
3379
3380 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
3381 call when setting menu-bar-lines and tool-bar-lines parameters.
3382 (unwind_create_frame_1): New helper function.
3383
3384 * window.c (inhibit_window_configuration_change_hook): New var.
3385 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 3386 (syms_of_window): Initialize it.
f01d3321 3387
86b847b6
CY
33882012-02-22 Chong Yidong <cyd@gnu.org>
3389
3390 * xterm.c (x_draw_image_relief): Add missing type check for
3391 Vtool_bar_button_margin (Bug#10743).
3392
a59225b1
CY
33932012-02-21 Chong Yidong <cyd@gnu.org>
3394
3395 * fileio.c (Vfile_name_handler_alist): Doc fix.
3396
3397 * buffer.c (Fget_file_buffer): Protect against invalid file
3398 handler return value.
3399
310f5bd4
PE
34002012-02-20 Paul Eggert <eggert@cs.ucla.edu>
3401
cb3a28cc
PE
3402 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
3403 when computing $valmask.
3404
310f5bd4
PE
3405 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
3406 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
3407 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
3408 It's useless in that case, and it can cause problems on hosts
3409 that allocate halves of EMACS_INT values separately.
3410 Reported by Dan Horák. Diagnosed by Andreas Schwab in
3411 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
3412 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
3413 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
3414 it avoids undefined behavior on hosts where shifting right by more
3415 than the word width has undefined behavior.
3416
2375c96a
CY
34172012-02-19 Chong Yidong <cyd@gnu.org>
3418
3419 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
3420 (Funhandled_file_name_directory, Ffile_name_as_directory)
3421 (Fdirectory_file_name, Fexpand_file_name)
3422 (Fsubstitute_in_file_name): Protect against invalid file handler
3423 return values (Bug#10845).
3424
3eb49e71
EZ
34252012-02-18 Eli Zaretskii <eliz@gnu.org>
3426
3427 * .gdbinit (pitx): Fix incorrect references to fields of the
3428 iterator stack.
3429
7b926f3f
CY
34302012-02-17 Chong Yidong <cyd@gnu.org>
3431
3432 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
3433
11273115
PE
34342012-02-15 Paul Eggert <eggert@cs.ucla.edu>
3435
3436 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
3437 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
3438
c3a70e2b
CY
34392012-02-15 Chong Yidong <cyd@gnu.org>
3440
3441 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
3442 marked as special. Also, starting docstrings with * is obsolete.
3443
0ca43699
AS
34442012-02-13 Andreas Schwab <schwab@linux-m68k.org>
3445
3446 * gnutls.c (emacs_gnutls_write): Fix last change.
3447
2e8f3c56
LI
34482012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
3449
3450 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
3451 send_process.
3452
af70074f
SM
34532012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
3454
3455 * keymap.c (Fsingle_key_description): Handle char ranges.
3456
95986d52
CY
34572012-02-12 Chong Yidong <cyd@gnu.org>
3458
afd83bd1
CY
3459 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
3460 as that creates a dangerous corner case.
3461
95986d52
CY
3462 * window.c (Fdelete_window_internal): Invalidate the mouse
3463 highlight (Bug#9904).
3464
bd7da63e
GM
34652012-02-12 Glenn Morris <rgm@gnu.org>
3466
3467 * xselect.c (Fx_own_selection_internal)
3468 (Fx_get_selection_internal, Fx_disown_selection_internal)
3469 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
3470 * nsselect.m (Fx_own_selection_internal)
3471 (Fx_disown_selection_internal, Fx_selection_exists_p)
3472 (Fx_selection_owner_p, Fx_get_selection_internal):
3473 Sync docs and argument specs with the xselect.c versions.
3474
77abcbc2
LI
34752012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
3476
3477 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
3478
90b671e2
EZ
34792012-02-11 Eli Zaretskii <eliz@gnu.org>
3480
1c0ca0b7
EZ
3481 * w32select.c (Fx_selection_exists_p): Sync doc string and
3482 argument list with xselect.c. (Bug#10783)
3483
3484 * w16select.c (Fx_selection_exists_p): Sync doc string and
3485 argument list with xselect.c. (Bug#10783)
90b671e2 3486
49241268
GM
34872012-02-10 Glenn Morris <rgm@gnu.org>
3488
3489 * fns.c (Fsecure_hash): Doc fix.
3490
f998bbe7 34912012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
3492
3493 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
3494
0992bd9c
CY
34952012-02-07 Chong Yidong <cyd@gnu.org>
3496
3497 * buffer.c (Fbuffer_local_variables)
3498 (buffer_lisp_local_variables): Handle unbound vars correctly;
3499 don't let Qunbound leak into Lisp.
3500
af008560
GM
35012012-02-07 Glenn Morris <rgm@gnu.org>
3502
dd605cc4
GM
3503 * image.c (Fimagemagick_types): Doc fix.
3504
af008560
GM
3505 * image.c (imagemagick-render-type): Change it from a lisp object
3506 to an integer. Move the doc here from the lisp manual.
3507 Treat all values not equal to 0 the same.
3508
1449fa1d
CY
35092012-02-06 Chong Yidong <cyd@gnu.org>
3510
3511 * doc.c (store_function_docstring): Avoid applying docstring of
3512 alias to base function (Bug#2603).
3513
3723ec07
AS
35142012-02-04 Andreas Schwab <schwab@linux-m68k.org>
3515
3516 * .gdbinit (pp1, pv1): Remove redundant defines.
3517 (pr): Use pp.
3518
79c1cc1e
CY
35192012-02-04 Chong Yidong <cyd@gnu.org>
3520
3521 * nsterm.m: Declare a global (Bug#10694).
3522
d7f29f8e
EZ
35232012-02-04 Eli Zaretskii <eliz@gnu.org>
3524
cae07000
SM
3525 * w32.c (get_emacs_configuration_options):
3526 Include --enable-checking, if specified, in the return value.
d7f29f8e 3527
3b95a6f9
MR
35282012-02-04 Martin Rudalics <rudalics@gmx.at>
3529
3530 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
3531 after rounding frame sizes. (Bug#9723)
3532
d6fa96a6
EZ
35332012-02-04 Eli Zaretskii <eliz@gnu.org>
3534
3535 * keyboard.c (adjust_point_for_property): Don't position point
3536 before BEGV. (Bug#10696)
3537
df0b2940
PE
35382012-02-03 Paul Eggert <eggert@cs.ucla.edu>
3539
3540 Handle overflow when computing char display width (Bug#9496).
3541 * character.c (char_width): Return EMACS_INT, not int.
3542 (char_width, c_string_width): Check for overflow when
3543 computing the width; this is possible now that individual
3544 characters can have unbounded width. Problem introduced
3545 by merge from Emacs 23 on 2012-01-19.
3546
6bee44d6
MA
35472012-02-02 Michael Albinus <michael.albinus@gmx.de>
3548
3549 * dbusbind.c (Fdbus_register_method): Mention the return value
3550 :ignore in the docstring.
3551
44f92739
GM
35522012-02-02 Glenn Morris <rgm@gnu.org>
3553
1b9f60cc
GM
3554 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
3555
44f92739
GM
3556 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3557 Unconditionally set to t. (Bug#10673)
3558 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3559 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3560 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
3561
c5d3843c
KH
35622012-02-02 Kenichi Handa <handa@m17n.org>
3563
3564 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
3565 0, do not call append_composite_glyph.
3566
159462d4 35672012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
3568
3569 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
3570 NULL (Bug#6988).
3571 (x_produce_glyphs): If the component of a composition is a null
3572 string, set it->pixel_width to 1 to avoid zero-width glyph.
3573
78cef877
EZ
35742012-02-01 Eli Zaretskii <eliz@gnu.org>
3575
3576 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
3577 first 2 arguments are identical. This makes inserting large
3578 output from a subprocess an order of magnitude faster on
3579 MS-Windows, where all sbrk'ed memory is always contiguous.
3580
97897668
GM
35812012-01-31 Glenn Morris <rgm@gnu.org>
3582
3583 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 3584 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
3585 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
3586
31fd3586
GM
35872012-01-29 Glenn Morris <rgm@gnu.org>
3588
3589 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
3590
0e24a8b2
CY
35912012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
3592
3593 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
3594
cc0adcb0
CY
35952012-01-28 Chong Yidong <cyd@gnu.org>
3596
3597 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
3598
acc28cb9
CY
35992012-01-26 Chong Yidong <cyd@gnu.org>
3600
9c69cfb7
CY
3601 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
3602
acc28cb9
CY
3603 * search.c (Fsearch_forward, Fsearch_backward): Document negative
3604 repeat counts (Bug#10507).
3605
48da7392
GM
36062012-01-26 Glenn Morris <rgm@gnu.org>
3607
3608 * lread.c (syms_of_lread): Doc fix.
3609
14af5f7f
CY
36102012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
3611
3612 * coding.c (encode_designation_at_bol): Change return value to
3613 EMACS_INT.
3614
0b21c100
CY
36152012-01-25 Chong Yidong <cyd@gnu.org>
3616
3617 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
3618
3c2907f7
CY
36192012-01-21 Chong Yidong <cyd@gnu.org>
3620
3621 * floatfns.c (Fcopysign): Make the second argument non-optional,
3622 since nil is not allowed anyway.
3623
959ad23f
AS
36242012-01-21 Andreas Schwab <schwab@linux-m68k.org>
3625
3626 * process.c (read_process_output): Use p instead of XPROCESS (proc).
3627 (send_process): Likewise.
3628
34a02f46
MR
36292012-01-19 Martin Rudalics <rudalics@gmx.at>
3630
3631 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
3632 (Vwindow_persistent_parameters): Do not use Qstate.
3633 Rewrite doc-strings.
34a02f46 3634
1259009a 36352012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
3636
3637 * character.c (char_width): New function.
70d4fdf6
GM
3638 (Fchar_width, c_string_width, lisp_string_width):
3639 Use char_width (Bug#9496).
25ed9e61 3640
6a6ee00d
MR
36412012-01-16 Martin Rudalics <rudalics@gmx.at>
3642
3643 * window.c (Vwindow_persistent_parameters): New variable.
3644 (Fset_window_configuration, save_window_save): Handle persistent
3645 window parameters.
3646
c85efaf7
EZ
36472012-01-14 Eli Zaretskii <eliz@gnu.org>
3648
3649 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
3650 thrashing the stack of the thread. (Bug#9087)
3651
5944709e
PE
36522012-01-12 Paul Eggert <eggert@cs.ucla.edu>
3653
3654 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
3655
e71f5d99
EZ
36562012-01-11 Eli Zaretskii <eliz@gnu.org>
3657
3658 * xdisp.c (rows_from_pos_range): Handle the case where the
3659 highlight ends on a newline. (Bug#10464)
3660 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
3661 he end column for display of highlight that ends on a newline
3662 before a R2L line.
3663
ce316182
GM
36642012-01-11 Glenn Morris <rgm@gnu.org>
3665
3666 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
3667 from load-path also when installation-directory is nil. (Bug#10208)
3668
5b43da69
GM
36692012-01-10 Glenn Morris <rgm@gnu.org>
3670
74cc8ff9
GM
3671 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
3672
7d8d6e4e
GM
3673 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
3674 Update template values to be closer to their typical values these days.
5b43da69 3675
a0db8d43
EZ
36762012-01-09 Eli Zaretskii <eliz@gnu.org>
3677
3678 * xdisp.c (rows_from_pos_range): Accept additional argument
3679 DISP_STRING, and accept any glyph in a row whose object is that
3680 string as eligible for mouse highlight. Fixes mouse highlight of
3681 display strings from overlays. (Bug#10464)
3682
9a0115ab 36832012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 3684
b9110d6a 3685 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
3686 * fileio.c (auto_saving_dir_umask): New static var.
3687 (Fmake_directory_internal): Use it.
3688 (do_auto_save_make_dir): Set it, instead of invoking chmod after
3689 creating the directory. The old code temporarily assigns
3690 too-generous permissions to the directory.
3691 (do_auto_save_eh): Clear it.
b9110d6a 3692 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
3693 that the var is always cleared.
3694
6c1bd3f3
EZ
36952012-01-07 Eli Zaretskii <eliz@gnu.org>
3696
3697 * search.c (scan_buffer): Pass character positions to
3698 know_region_cache, not byte positions. (Bug#6540)
3699
069d2b50
L
37002012-01-07 LynX <_LynX@bk.ru> (tiny change)
3701
3702 * w32.c (sys_rename): Report EXDEV when rename of a directory
3703 fails because the target is on another logical disk. (Bug#10284)
3704
75bf0d33
DB
37052012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
3706
3707 * xterm.c (x_embed_request_focus): New function.
3708
3709 * xterm.h: Add prototype.
3710
3711 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
3712
1c6e5a32
GM
37132012-01-05 Glenn Morris <rgm@gnu.org>
3714
3715 * emacs.c (emacs_copyright): Update short copyright year to 2012.
3716
651e947e
EZ
37172012-01-01 Eli Zaretskii <eliz@gnu.org>
3718
3719 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
3720 Load gnutls_transport_set_lowat only if GnuTLS version is below
3721 2.11.1.
3722 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
3723 GnuTLS versions below 2.11.1.
3724
3778cdd8
AL
37252011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
3726
3727 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
3728 to the doc string advising against its use for altering the way
3729 windows are scrolled.
3730
0e5317f7
KH
37312011-12-28 Kenichi Handa <handa@m17n.org>
3732
3733 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
3734 coding-system ASCII compatible only when it does not produce BOM
3735 on encoding (Bug#10383).
3736
93d5ca1f
JD
37372011-12-26 Jan Djärv <jan.h.d@swipnet.se>
3738
3739 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
3740 can scroll.
3741 (create_and_show_popup_menu): Always use menu_position_func for
3742 Gtk3 (Bug#10361).
3743
ca22b785
AS
37442011-12-24 Andreas Schwab <schwab@linux-m68k.org>
3745
3746 * callint.c (Fcall_interactively): Don't truncate prompt string.
3747
d048e1e6
EZ
37482011-12-23 Eli Zaretskii <eliz@gnu.org>
3749
3750 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
3751 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 3752 resumed from there (after widening). (Bug#10360)
d048e1e6 3753
5ccaba1f
JD
37542011-12-22 Jan Djärv <jan.h.d@swipnet.se>
3755
3756 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
3757
204ee57f
JD
37582011-12-21 Jan Djärv <jan.h.d@swipnet.se>
3759
b81d40f0
JB
3760 * nsterm.m (x_free_frame_resources):
3761 Release f->output_data.ns->miniimage.
204ee57f
JD
3762 (ns_index_color): Fix indentation. Do not retain
3763 color_table->colors[i].
3764
3765 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
3766 before returning.
3767
3768 * nsfns.m (x_set_background_color): Assign return value from
3769 ns_index_color to face-background instead of NSColor*.
3770 (ns_implicitly_set_icon_type): Fix indentation.
3771 Change assignment in for loop to comparison.
3772
3773 * emacs.c (ns_pool): New variable.
3774 (main): Assign ns_pool.
3775 (Fkill_emacs): Call ns_release_autorelease_pool.
3776
3777 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
3778 autorelease fdesc, release fdAttrs and tdict.
3779 (ns_get_covering_families): Release charset.
3780 (ns_findfonts): Release NSFontDescriptor created with new.
3781 (ns_uni_to_glyphs): Fix indentation.
3782 (setString): Release attrStr before assigning new value.
3783
c803b2b7
JD
37842011-12-18 Jan Djärv <jan.h.d@swipnet.se>
3785
678f4426
JD
3786 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
3787 and NS_IMPL_COCOA.
3788 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
3789 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
3790
cd394be1 37912011-12-18 David Reitter <reitter@cmu.edu>
678f4426 3792
5fecd5fc
JD
3793 * nsterm.m (ns_term_init): Subscribe for notifications
3794 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
3795 to method trackingNotification in EmacsMenu.
3796
3797 * nsmenu.m (trackingMenu): New variable.
3771cb17 3798 (trackingNotification): New method (from Aquamacs).
5fecd5fc 3799 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 3800 from Aquamacs (Bug#7030).
678f4426
JD
3801
38022011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 3803
c803b2b7
JD
3804 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
3805 (symbol_to_nsstring): Fix indentation.
3806 (ns_symbol_to_pb): New function.
cae07000
SM
3807 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
3808 (Fns_rotate_cut_buffers_internal): Remove.
3809 (Fns_store_selection_internal): Rename from
c803b2b7
JD
3810 Fns_store_cut_buffer_internal.
3811 (ns_get_foreign_selection, Fx_own_selection_internal)
3812 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
3813 (Fns_get_selection_internal, Fns_store_selection_internal):
3814 Use ns_symbol_to_pb and check if return value is nil.
3815 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
3816 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
3817 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
3818 renamed to Sns_store_selection_internal.
3819 (ns_handle_selection_request): Move code to Fx_own_selection_internal
3820 and remove this function.
3821 (ns_handle_selection_clear): Remove, never used.
3822 (Fx_own_selection_internal): Move code from ns_handle_selection_request
3823 here.
3824
e1b01a3a
KB
38252011-12-17 Ken Brown <kbrown@cornell.edu>
3826
3827 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
3828 GID is unknown (Bug#10257).
3829
2adb6e85
PE
38302011-12-17 Paul Eggert <eggert@cs.ucla.edu>
3831
3832 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
3833 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
3834 which caused a build failure on GNU/Linux IA-64. This problem was
3835 introduced by my 2011-10-07 patch.
3836
d1d7b339
JL
38372011-12-15 Juri Linkov <juri@jurta.org>
3838
3839 * image.c (imagemagick_error): New function. (Bug#10112)
3840 (imagemagick_load_image): Comment out `MagickSetResolution' call.
3841 Use `imagemagick_error' where ImageMagick functions return
3842 `MagickFalse'.
3843 (Fimagemagick_types): Add `Fnreverse' to return the list in the
3844 proper order.
3845
100d5755
KH
38462011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3847
3848 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
3849 fill background (Bug#8992).
3850
454592a6
MR
38512011-12-13 Martin Rudalics <rudalics@gmx.at>
3852
3853 * window.c (Vwindow_combination_resize)
3854 (Vwindow_combination_limit): Use t instead of non-nil in
3855 doc-strings.
61d4b438
MR
3856 (Vrecenter_redisplay): Add first sentence of doc-string on
3857 separate line.
53524d93 3858 (Frecenter): Fix doc-string typo.
454592a6 3859
3633e3aa
KH
38602011-12-11 Kenichi Handa <handa@m17n.org>
3861
3862 * coding.c (Funencodable_char_position): Pay attention to the
3863 buffer text relocation (Bug#9389).
3864
7b9d523a 38652011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 3866
7b9d523a
JD
3867 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
3868 gtk_init (Bug#10100).
3869
b73189c6
EZ
38702011-12-10 Eli Zaretskii <eliz@gnu.org>
3871
3872 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
3873 IT->string is nil. (Bug#10263)
3874
f7dfe5d6
JD
38752011-12-10 Jan Djärv <jan.h.d@swipnet.se>
3876
83faebb4
JD
3877 * nsterm.h (x_free_frame_resources): Declare.
3878
f7dfe5d6
JD
3879 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
3880 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
3881
3882 * nsterm.h (ns_get_defaults_value): Declare.
3883
3884 * nsterm.m (ns_default): Call ns_get_defaults_value.
3885
7cd4e72c
EZ
38862011-12-09 Eli Zaretskii <eliz@gnu.org>
3887
3888 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
3889 (Bug#10170)
3890
b34d7317
YM
38912011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3892
3893 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
3894 that where the value of an _OBJC_* symbol points to is in the .bss
3895 section (Bug#10240).
3896
76470ad1
KH
38972011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3898
3899 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 3900 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 3901
745fff94
KH
39022011-12-08 Kenichi Handa <handa@m17n.org>
3903
3904 * ftfont.c (get_adstyle_property): Fix previous change
3905 (Bug#10233).
3906
6e44397c
JB
39072011-12-07 Juanma Barranquero <lekktu@gmail.com>
3908
3909 * w32.c (init_environment): If no_site_lisp, remove site-lisp
3910 dirs from the default value of EMACSLOADPATH (bug#10208).
3911
7efa6272
GM
39122011-12-07 Glenn Morris <rgm@gnu.org>
3913
3914 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
3915 installation and source directories as well. (Bug#10208)
3916
f6fc4d87
CY
39172011-12-06 Chong Yidong <cyd@gnu.org>
3918
3919 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
3920
2bf26180
GM
39212011-12-06 Glenn Morris <rgm@gnu.org>
3922
3923 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
3924 as an error, not just -1. (Bug#10217)
3925
3a6ad4f0
CY
39262011-12-05 Chong Yidong <cyd@gnu.org>
3927
3928 * keyboard.c (process_special_events): New function.
3929 (swallow_events, Finput_pending_p): Use it (Bug#10195).
3930
75a3b399
PE
39312011-12-05 Paul Eggert <eggert@cs.ucla.edu>
3932
3933 * coding.c (encode_designation_at_bol): Don't use uninitialized
3934 local variable (Bug#9318).
3935
c3c9e25e
KH
39362011-12-05 Kenichi Handa <handa@m17n.org>
3937
3938 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
3939 return Qnil (Bug#8046, Bug#10193).
3940
5eb05ea3
KH
39412011-12-05 Kenichi Handa <handa@m17n.org>
3942
3943 * coding.c (encode_designation_at_bol): New args charbuf_end and
3944 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
3945 (coding_set_source): Return how many bytes coding->source was
3946 relocated.
3947 (coding_set_destination): Return how many bytes
3948 coding->destination was relocated.
3949 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 3950 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
3951
39522011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3953
3954 * coding.c (CODING_CHAR_CHARSET_P): New macro.
3955 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
3956 macro (Bug#9318).
3957
39582011-12-05 Andreas Schwab <schwab@linux-m68k.org>
3959
3960 The following changes are to fix Bug#9318.
3961
a79703f5 3962 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
3963 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
3964 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 3965 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 3966
7dbda6df
JB
39672011-12-05 Juanma Barranquero <lekktu@gmail.com>
3968
3969 * lisp.h (process_quit_flag): Fix external declaration.
3970
6d5eb5b0
SM
39712011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
3972
3973 Don't macro-inline non-performance-critical code.
3974 * eval.c (process_quit_flag): New function.
3975 * lisp.h (QUIT): Use it.
3976
a0c3fad0
JD
39772011-12-04 Jan Djärv <jan.h.d@swipnet.se>
3978
3979 * nsfns.m (get_geometry_from_preferences): New function.
3980 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
3981
6c07aac2
AS
39822011-12-04 Andreas Schwab <schwab@linux-m68k.org>
3983
3984 * emacs.c (Qkill_emacs): Define.
3985 (syms_of_emacs): Initialize it.
3986 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
3987 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
3988 (quit_throw_to_read_char): Add parameter `from_signal'.
3989 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
3990 * lisp.h (QUIT): Call Fkill_emacs if requested.
3991
c052ead4
JD
39922011-12-03 Jan Djärv <jan.h.d@swipnet.se>
3993
3994 * widget.c (update_wm_hints): Return if wmshell is null.
3995 (widget_update_wm_size_hints): New function.
3996
3997 * widget.h (widget_update_wm_size_hints): Declare.
3998
3999 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
4000 widget_update_wm_size_hints (Bug#10104).
4001
9e49252b
EZ
40022011-12-03 Eli Zaretskii <eliz@gnu.org>
4003
4004 * xdisp.c (handle_invisible_prop): If the invisible text ends just
4005 before a newline, prepare the bidi iterator for consuming the
4006 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 4007 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 4008
02b16839
JL
40092011-12-02 Juri Linkov <juri@jurta.org>
4010
4011 * search.c (Fword_search_regexp): New Lisp function created from
4012 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
4013 (Fword_search_backward, Fword_search_forward)
4014 (Fword_search_backward_lax, Fword_search_forward_lax):
4015 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
4016 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
4017
0068070e
SM
40182011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
4019
4020 * fileio.c (Finsert_file_contents): Move after-change-function call
4021 to before the "handled:" label, since all "goto handled" appear in
4022 cases where the *-change-functions have already been properly called
4023 (bug#10117).
4024
3360a3fc
AS
40252011-12-01 Andreas Schwab <schwab@linux-m68k.org>
4026
4027 * keyboard.c (interrupt_signal): Don't call kill-emacs when
4028 waiting for input. (Bug#10169)
4029
73d6c093
EZ
40302011-11-30 Eli Zaretskii <eliz@gnu.org>
4031
4032 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
4033 verifies glyph row's hash code--we have just reallocated the
4034 glyphs, so their contents can be complete garbage. (Bug#10164)
4035
febe6bea
JB
40362011-11-30 Juanma Barranquero <lekktu@gmail.com>
4037
4038 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
4039
801a4313
EZ
40402011-11-30 Eli Zaretskii <eliz@gnu.org>
4041
4042 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
4043 attributes are tested _before_ calling verify_row_hash, to protect
4044 against GCC re-ordering of the tests. (Bug#10164)
4045
2b56b87e
JD
40462011-11-29 Jan Djärv <jan.h.d@swipnet.se>
4047
4048 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
4049
4050 * xterm.c (handle_one_xevent): Only set async_visible and friends
4051 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 4052 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
4053 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
4054
dbf31225
PE
40552011-11-28 Paul Eggert <eggert@cs.ucla.edu>
4056
4057 Remove GCPRO-related macros that exist only to avoid shadowing locals.
4058 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
4059 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
4060 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4061 All uses changed to use GCPRO1 etc.
4062 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
4063 Revert to old implementation (i.e., before 2011-03-11).
4064
1305621b
YM
40652011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4066
4067 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
4068 of scroll runs so as to avoid assigning disabled bogus rows and
4069 unnecessary graphics copy operations.
4070
8c9afb46
EZ
40712011-11-27 Eli Zaretskii <eliz@gnu.org>
4072
4073 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
4074 (snprintf) [_MSC_VER]: Redirect to _snprintf.
4075 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
4076 (malloc, free, realloc, calloc): Redirect to e_* only when
4077 compiling Emacs.
4078
4079 * lisp.h (GCTYPEBITS): Move before first use.
4080 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
4081 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
4082 this macro definition.
4083
4084 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
4085 _MSC_VER.
4086
54e9e3bf
JD
40872011-11-27 Jan Djärv <jan.h.d@swipnet.se>
4088
6d5eb5b0
SM
4089 * gtkutil.c (xg_create_frame_widgets):
4090 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
4091 present with Gtk+ 2.0.
4092
83aca1cb
PE
40932011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4094
4095 * fileio.c (Finsert_file_contents): Undo previous change; see
4096 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4097
5b76caa4
PE
40982011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4099
4100 Rename locals to avoid shadowing.
4101 * fileio.c (Finsert_file_contents):
4102 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
4103 * process.c (wait_reading_process_output):
4104 Rename inner 'proc' to 'p' to avoid shadowing.
4105 Indent for consistency with usual Emacs style.
4106
8c535114
EZ
41072011-11-25 Eli Zaretskii <eliz@gnu.org>
4108
4109 * xdisp.c (redisplay_window): If cursor row is not fully visible
4110 after recentering, and scroll-conservatively is set to a large
4111 number, scroll window by a few more lines to make the cursor fully
4112 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
4113 (start_display): Don't move to the next line if the display should
4114 start at a newline that is part of a display vector or an overlay
4115 string. (Bug#10119)
8c535114 4116
fa4fdb5c
JL
41172011-11-24 Juri Linkov <juri@jurta.org>
4118
4119 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
4120 after the `MagickPingImage' call. (Bug#10112)
4121
90ec88df
CY
41222011-11-23 Chong Yidong <cyd@gnu.org>
4123
4124 * window.c (Fcoordinates_in_window_p): Accept only live windows.
4125
56e2e794
MR
41262011-11-23 Martin Rudalics <rudalics@gmx.at>
4127
4128 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
4129 making another buffer current. (Bug#10114)
4130
b6e64c41
GM
41312011-11-23 Glenn Morris <rgm@gnu.org>
4132
4133 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
4134
6b21de18
CY
41352011-11-23 Chong Yidong <cyd@gnu.org>
4136
4137 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
4138 using it (Bug#5984).
4139
b12cd789
EZ
41402011-11-22 Eli Zaretskii <eliz@gnu.org>
4141
4142 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
4143 and header-lines, as they don't have one computed for them.
4144 (Bug#10098)
4145
4146 * .gdbinit (prow): Make displayed values more self-explaining.
4147 Add row's hash code.
4148
261b6fd4
LMI
41492011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
4150
4151 * process.c (wait_reading_process_output): Fix asynchrounous
4152 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 4153 (wait_reading_process_output): Add comment and URL.
261b6fd4 4154
e7cfd277
JD
41552011-11-21 Jan Djärv <jan.h.d@swipnet.se>
4156
4157 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
4158
a9b9b7f5
CY
41592011-11-21 Chong Yidong <cyd@gnu.org>
4160
4161 * window.c (Fnext_window, Fprevious_window): Doc fix.
4162
b0d15b4f
SM
41632011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4164
4165 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
4166
fe7a3057
JB
41672011-11-20 Juanma Barranquero <lekktu@gmail.com>
4168
4169 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
4170
d2999b1a
MR
41712011-11-20 Martin Rudalics <rudalics@gmx.at>
4172
4173 * window.c (Fset_window_combination_limit): Rename argument
4174 STATUS to LIMIT.
4175 (Vwindow_combination_limit): Remove "status" from doc-string.
4176
d5ff9cd0
AS
41772011-11-20 Andreas Schwab <schwab@linux-m68k.org>
4178
4179 * m/ibms390.h: Remove.
4180 * m/ibms390x.h: Don't include "ibms390.h".
4181
a5bb9bd3
SM
41822011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4183
4184 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
4185 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
4186
cd1181db
JB
41872011-11-20 Juanma Barranquero <lekktu@gmail.com>
4188
4189 * casetab.c (Fset_case_table):
4190 * charset.c (Fcharset_after): Fix typos.
4191
615a3b8d 41922011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 4193
17e845af
PE
4194 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
4195 Otherwise, valgrind does not work on some platforms.
4196 Problem reported by Andreas Schwab in
6a0bf43d
PE
4197 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
4198 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
4199 is set, removing the need for VIRT_ADDRESS_VARIES.
4200 (PURE_P): Use a more-efficient implementation that needs just one
4201 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
4202 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
4203 to 4 (xorl, subq, cmpq, setbe).
4204 * alloc.c (pure): Always extern now, since that's the
4205 VIRT_ADDR_VARIES behavior.
4206 (PURE_POINTER_P): Use a single comparison, not two, for
4207 consistency with the new puresize.h.
4208 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
4209 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
4210 Remove VIRT_ADDR_VARIES no longer needed.
4211
f8fe6f96
EZ
42122011-11-19 Eli Zaretskii <eliz@gnu.org>
4213
4214 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
4215 (erase_phys_cursor, update_window_cursor, show_mouse_face)
4216 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
4217 behave as if the cursor position were at the window margin.
4218
4219 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
4220 and the cursor position is out of bounds, behave as if the cursor
4221 position were at the window margin. (Bug#10075)
4222
df05a53c
CY
42232011-11-18 Chong Yidong <cyd@gnu.org>
4224
4225 * window.c (Fwindow_combination_limit): Make first argument
4226 non-optional, since it is meaningless for live windows like the
4227 selected window.
61ccba97 4228
2071918e
DA
42292011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
4230
4231 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
4232
b50a28de
SM
42332011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
4234
4235 * intervals.c: Fix grafting over the whole buffer (bug#10071).
4236 (graft_intervals_into_buffer): Simplify.
4237
015137db
EZ
42382011-11-18 Eli Zaretskii <eliz@gnu.org>
4239
4240 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
4241 hash values of the two rows.
4242 (copy_row_except_pointers): Preserve the used[] arrays and the
4243 hash values of the two rows. (Bug#10035)
68c95424 4244 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
4245
4246 * xdisp.c (row_hash): New function, body extracted from
4247 compute_line_metrics.
4248 (compute_line_metrics): Call row_hash, instead of computing the
4249 hash code inline.
4250
4251 * dispnew.c (verify_row_hash): Call row_hash for computing the
4252 hash code of a row, instead of duplicating code from xdisp.c.
4253
4254 * dispextern.h (row_hash): Add prototype.
4255
a2addb04
TH
42562011-11-18 Tassilo Horn <tassilo@member.fsf.org>
4257
4258 * frame.c (delete_frame): Don't delete the terminal when the last
4259 X frame is closed if emacs is built with GTK toolkit.
4260
df85d315
JB
42612011-11-17 Juanma Barranquero <lekktu@gmail.com>
4262
4263 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
4264
a0c2d0ae
MR
42652011-11-17 Martin Rudalics <rudalics@gmx.at>
4266
4267 * window.c (Vwindow_splits): Rename to
4268 Vwindow_combination_resize. Suggested by Juri Linkov.
4269 (Fsplit_window_internal): Use Vwindow_combination_resize instead
4270 of Vwindow_splits.
4271
58179cce
JB
42722011-11-16 Juanma Barranquero <lekktu@gmail.com>
4273
7877f373
JB
4274 * nsfns.m (Fns_font_name):
4275 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 4276
b6f67890
MR
42772011-11-16 Martin Rudalics <rudalics@gmx.at>
4278
4279 * window.h (window): Rename slot "nest" to "combination_limit".
4280 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
4281 (Fset_window_nest): Rename to Fset_window_combination_limit.
4282 (Vwindow_nest): Rename to Vwindow_combination_limit.
4283 (recombine_windows, make_parent_window, make_window)
4284 (Fsplit_window_internal, saved_window)
4285 (Fset_window_configuration, save_window_save): Rename all
4286 occurrences of window_nest to window_combination_limit.
4287
c7015153
JB
42882011-11-15 Juanma Barranquero <lekktu@gmail.com>
4289
4290 * image.c (imagemagick_load_image): Fix typo.
4291
322ad6ec
EZ
42922011-11-14 Eli Zaretskii <eliz@gnu.org>
4293
4294 * xdisp.c (display_line): Move the call to
4295 highlight_trailing_whitespace before the call to
4296 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
4297 faces of all the glyphs to compute ROW's hash value.
4298 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 4299
f067b8ec
JB
43002011-11-14 Juanma Barranquero <lekktu@gmail.com>
4301
4302 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
4303 just return (bug#10044).
4304
1e5b2111
EZ
43052011-11-12 Eli Zaretskii <eliz@gnu.org>
4306
7ef3cbd5
EZ
4307 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
4308 with user-defined heap size. Bump the default size of the temacs
4309 heap to 27MB, to avoid memory warning when running temacs.
4310 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
4311
1e5b2111
EZ
4312 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
4313 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
4314 (verify_row_hash) [XASSERTS]: New function.
4315 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
4316 that the hash value of glyph rows is correct.
1e5b2111 4317
89d61221
MR
43182011-11-12 Martin Rudalics <rudalics@gmx.at>
4319
4320 * window.h (window): Remove splits slot.
4321 * window.c (Fwindow_splits, Fset_window_splits): Remove.
4322 (Fdelete_other_windows_internal, make_parent_window)
4323 (make_window, Fsplit_window_internal, Fdelete_window_internal)
4324 (Fset_window_configuration, save_window_save): Don't deal with
4325 split status of windows.
4326 (saved_window): Remove splits slot.
4327 (Vwindow_splits): Rewrite doc-string.
4328
97f18cc8
JD
43292011-11-11 Jan Djärv <jan.h.d@swipnet.se>
4330
4331 * xfns.c (unwind_create_frame):
4332 * nsfns.m (unwind_create_frame):
4333 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
4334 Vframe_list (Bug#9999).
4335
22a648b4
DA
43362011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
4337
0b381c7e 4338 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 4339
659afede
KH
43402011-11-11 Kenichi Handa <handa@m17n.org>
4341
4342 * callproc.c (Fcall_process): Set the member dst_multibyte of
4343 process_coding.
4344
9ac0394b
KH
43452011-11-11 Johan Bockgård <bojohan@gnu.org>
4346
4347 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
4348 avoid a crash (bug#9496).
4349
2fbdc249
CY
43502011-11-09 Chong Yidong <cyd@gnu.org>
4351
4352 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
4353 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
4354
ac6b1f81
PE
43552011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4356
4357 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
4358
09db192c
PE
43592011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4360
4361 Avoid some portability problems by eschewing 'extern inline' functions.
4362 The trivial performance wins aren't worth the portability hassles; see
4363 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
4364 et seq.
4365 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4366 (window_box_width, window_box_left, window_box_left_offset)
4367 (window_box_right, window_box_right_offset): Undo previous change,
4368 by removing the "extern"s.
4369 * intervals.c (adjust_intervals_for_insertion)
4370 (adjust_intervals_for_deletion): Undo previous change,
4371 making these static again.
4372 (offset_intervals, temp_set_point_both, temp_set_point)
4373 (copy_intervals_to_string): No longer inline.
4374 * xdisp.c (window_text_bottom_y, window_box_width)
4375 (window_box_height, window_box_left_offset)
4376 (window_box_right_offset, window_box_left, window_box_right)
4377 (window_box): No longer inline.
4378
105216ed
CY
43792011-11-08 Chong Yidong <cyd@gnu.org>
4380
4381 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
4382 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
4383 Signal an error if not a live window.
105216ed
CY
4384 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
4385 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
4386
ae9e237f
JB
43872011-11-07 Juanma Barranquero <lekktu@gmail.com>
4388
4389 * lisp.h (syms_of_abbrev): Remove declaration.
4390 Reported by CHENG Gao <chenggao@royau.me>.
4391
c7aa8333
EZ
43922011-11-07 Eli Zaretskii <eliz@gnu.org>
4393
4394 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
4395 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
4396 of temacs in GUI mode.
4397
be7f5545
MR
43982011-11-07 Martin Rudalics <rudalics@gmx.at>
4399
4400 * window.h: Declare delete_all_child_windows instead of
4401 delete_all_subwindows.
4402 * window.c (Fwindow_nest, Fset_window_nest)
4403 (Fset_window_new_total, Fset_window_new_normal)
4404 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
4405 (delete_all_subwindows): Rename to delete_all_child_windows.
4406 (Fdelete_other_windows_internal, Fset_window_configuration):
4407 Call delete_all_child_windows instead of delete_all_subwindows.
4408 * frame.c (delete_frame): Call delete_all_child_windows instead
4409 of delete_all_subwindows.
4410
ca78dc43
PE
44112011-11-07 Paul Eggert <eggert@cs.ucla.edu>
4412
4413 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
4414 This is also needed for porting to any host where GC_MARK_STACK is
4415 not GC_MAKE_GCPROS_NOOPS.
4416 (which_symbols): Use it.
4417
a0241d01
KH
44182011-11-07 Kenichi Handa <handa@m17n.org>
4419
4420 * coding.c (coding_set_destination): Check coding->src_pos only
4421 when coding->src_object is a buffer (bug#9910).
4422
4423 * process.c (send_process): Set the member src_multibyte of coding
4424 to 0 (bug#9911) when sending a unibyte text.
4425
4426 * callproc.c (Fcall_process): Set the member src_multibyte of
4427 process_coding to 0 (bug#9912).
4428
a64bfdfa 44292011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
4430
4431 * xmenu.c (cleanup_widget_value_tree): New function.
4432 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
4433 calling free_menubar_widget_value_tree directly (Bug#9830).
4434
cb41b32a
PE
44352011-11-06 Paul Eggert <eggert@cs.ucla.edu>
4436
4437 Fix some portability problems with 'inline'.
4438 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4439 (window_box_width, window_box_left, window_box_left_offset)
4440 (window_box_right, window_box_right_offset): Declare extern.
4441 Otherwise, these inline functions do not conform to C99 and
4442 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
4443 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
4444 * intervals.c (adjust_intervals_for_insertion)
4445 (adjust_intervals_for_deletion): Now extern, because otherwise the
4446 extern inline functions 'offset_intervals' couldn't refer to it.
4447 (static_offset_intervals): Remove.
4448 (offset_intervals): Rewrite using the old contents of
4449 static_offset_intervals. The old version didn't conform to C99
4450 because an extern inline function contained a reference to an
4451 identifier with static linkage.
4452
b7041366
AS
44532011-11-06 Andreas Schwab <schwab@linux-m68k.org>
4454
4455 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
4456 GC.
4457
88a37c4d
EZ
44582011-11-06 Eli Zaretskii <eliz@gnu.org>
4459
4460 * xdisp.c (init_iterator, reseat_to_string): Don't set the
4461 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
4462 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
4463 return Qleft_to_right.
4464
49745b39
CY
44652011-11-06 Chong Yidong <cyd@gnu.org>
4466
4467 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
4468 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
4469 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
4470 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
4471 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
4472 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
4473 (Fwindow_vscroll): Doc fix.
4474 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
4475 argument, since it makes no sense to pass a live window and for
4476 consistency with window-child.
4477
1f05cd82
CS
44782011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
4479
4480 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
4481 support MSVC.
4482
22610910
JR
44832011-11-05 Jason Rumney <jasonr@gnu.org>
4484
4485 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
4486 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
4487 fonts (Bug#6029).
4488 (add_font_entity_to_list): Fix logic errors in mixed boolean and
4489 bitwise arithmetic preventing use of unicode-sip and non-truetype
4490 opentype fonts.
4491
a06776b2
EZ
44922011-11-05 Eli Zaretskii <eliz@gnu.org>
4493
3ad924ba
EZ
4494 * s/ms-w32.h (fstat, stat, utime): Move redirections to
4495 "emacs"-only part.
4496
a06776b2
EZ
4497 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
4498 initialization code to keep similarity to xfns.c after changes
4499 from 2011-11-05.
4500
c9e7db78
JD
45012011-11-05 Jan Djärv <jan.h.d@swipnet.se>
4502
a97f8f3f
JD
4503 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
4504 (unwind_create_frame): New function (Bug#9943).
4505 (Fx_create_frame): Restructure code to be more similar to the one in
4506 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
4507 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
4508 Move terminal->reference_count++ just before making the frame official
4509 (Bug#9943).
4510
4511 * nsterm.m (x_free_frame_resources): New function.
4512 (x_destroy_window): Move code to x_free_frame_resources.
4513
c9e7db78 4514 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
4515 (Fx_create_frame, x_create_tip_frame):
4516 Move terminal->reference_count++ just before making the frame
75f1671a 4517 official. Move initialization of image_cache_refcount and
c9e7db78
JD
4518 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
4519
a6fc3b5c
EZ
45202011-11-05 Eli Zaretskii <eliz@gnu.org>
4521
4522 Support MSVC build with newer versions of Visual Studio.
4523 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
4524 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
4525 nt/gmake.defs.
4526
4527 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
4528 which are not supported by MSVC.
4529 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
4530 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
4531 bitfields.
4532 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
4533 types in bitfields.
4534 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
4535
4536 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
4537
58179cce 45382011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
4539
4540 Support MSVC build with newer versions of Visual Studio.
4541 * w32.c: Don't include w32api.h for MSVC.
4542 (init_environment) [_MSC_VER]: Call sys_access, not _access.
4543
4544 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
4545 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
4546 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
4547 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
4548 e_* cousins.
4549 (alloca) [_MSC_VER]: Define to _alloca.
4550
4551 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
4552
4553 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
4554
a58c13ed
EZ
45552011-11-04 Eli Zaretskii <eliz@gnu.org>
4556
4557 * xdisp.c (note_mouse_highlight): If either of
4558 previous/next-single-property-change returns nil, treat that as
4559 the beginning or the end of the buffer. (Bug#9955)
4560
fe0b6370
JD
45612011-11-04 Jan Djärv <jan.h.d@swipnet.se>
4562
a58c13ed 4563 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
4564 label is not null (Bug#9951).
4565 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
4566 may be NULL.
4567
89bd5ee1
EZ
45682011-11-04 Eli Zaretskii <eliz@gnu.org>
4569
4570 * window.c (Fwindow_body_size): Mention in the doc string that the
4571 return value is in frame's canonical units. (Bug#9949)
4572
84c3edb9
EZ
45732011-11-03 Eli Zaretskii <eliz@gnu.org>
4574
4e2fb5c7
EZ
4575 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
4576
84c3edb9 4577 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 4578 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 4579 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 4580
bc17a887
EZ
45812011-11-01 Eli Zaretskii <eliz@gnu.org>
4582
4583 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
4584 Don't stop backward scan on the continuation glyph, even though
4585 its CHARPOS is positive.
6d5eb5b0
SM
4586 (mouse_face_from_buffer_pos, note_mouse_highlight):
4587 Rename cover_string to disp_string.
bc17a887 4588
4ee88440
MR
45892011-11-01 Martin Rudalics <rudalics@gmx.at>
4590
4591 * window.c (temp_output_buffer_show): Don't use
4592 Vtemp_buffer_show_specifiers.
4593 (Vtemp_buffer_show_specifiers): Remove unused variable.
4594
c2ff3c02
EZ
45952011-10-30 Eli Zaretskii <eliz@gnu.org>
4596
4597 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
4598 past the beginning of the current glyph matrix.
4599
58179cce 46002011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
4601
4602 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
4603 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
4604 HAVE_GTK3 (Bug#9869).
b77a6a7f 4605
3b574623
JD
4606 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
4607 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
4608
b77a6a7f
JD
4609 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
4610
4611 * xterm.c: Declare x_handle_net_wm_state to return int.
4612 (handle_one_xevent): Check if we are iconified but don't have
4613 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
4614 (get_current_wm_state): Return non-zero if not hidden,
4615 check for _NET_WM_STATE_HIDDEN (Bug#9893).
4616 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
4617 (x_handle_net_wm_state): Return what get_current_wm_state returns.
4618 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
4619
196e41e4
PE
46202011-10-29 Paul Eggert <eggert@cs.ucla.edu>
4621
4622 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
4623 so that this new function doesn't get optimized away by a
4624 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
4625
021f2e1a
AS
46262011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4627
4628 * frame.h (MOUSE_HL_INFO): Remove excess parens.
4629
8b058d44
EZ
46302011-10-29 Eli Zaretskii <eliz@gnu.org>
4631
4632 Fix the `xbytecode' command.
4633 * .gdbinit (xprintbytestr): New command.
b50a28de 4634 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
4635 (xbytecode): Print the byte-code string as well.
4636
4452fb80
EZ
46372011-10-29 Kim Storm <storm@cua.dk>
4638
8b058d44
EZ
4639 * alloc.c (which_symbols): New function.
4640
21b72067
AS
46412011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4642
4643 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
4644 line. (Bug#9903)
4645
83ed7b5c
GM
46462011-10-29 Glenn Morris <rgm@gnu.org>
4647
4648 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
4649 Not clear what it was for, and it causes various bugs. (Bug#9839)
4650
5a7a728b
EZ
46512011-10-28 Eli Zaretskii <eliz@gnu.org>
4652
4653 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
4654 possible random value that matches one of those tested as
4655 condition to clear the mouse face.
4656
d3d0842f
CY
46572011-10-28 Chong Yidong <cyd@gnu.org>
4658
4659 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
4660
31b39d13
DN
46612011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
4662
4663 * window.c (make_window): Initialize phys_cursor_on_p.
4664
9aba6043
SM
46652011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
4666
4667 * lisp.h (struct Lisp_Symbol): Update comments.
4668
c20992f4
JB
46692011-10-28 Juanma Barranquero <lekktu@gmail.com>
4670
4671 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
4672
db4f02f2
EZ
46732011-10-28 Eli Zaretskii <eliz@gnu.org>
4674
4675 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
4676 <oslsachem@gmail.com> for helping to debug this.
4677
4678 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
4679 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
4680 (g_b_init_get_glyph_outline_w): New static variables.
4681 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
4682 (GetGlyphOutlineW_Proc): New typedefs.
4683 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
4684 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
4685 New functions.
4686 (w32font_open_internal, compute_metrics):
4687 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
4688 instead of calling the "wide" APIs directly.
4689
4690 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
4691
4692 * w32.h (syms_of_w32font): Add prototype.
4693
87e68db4
JB
46942011-10-27 Juanma Barranquero <lekktu@gmail.com>
4695
4696 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
4697 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
4698 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
4699 (Fmove_to_window_line): Doc fix.
4700
435c1d67
CY
47012011-10-27 Chong Yidong <cyd@gnu.org>
4702
4703 * process.c (make_process): Set gnutls_state to NULL.
4704
4705 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
4706 non-NULL, regardless of GNUTLS_INITSTAGE.
4707 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
4708 an error. Set process slots as soon as we allocate them.
4709
4710 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
4711
9c6c6f49
CY
47122011-10-27 Chong Yidong <cyd@gnu.org>
4713
9aba6043
SM
4714 * gnutls.c (emacs_gnutls_deinit): New function.
4715 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
4716 (Fgnutls_deinit, Fgnutls_boot): Use it.
4717
4718 * process.c (make_process): Initialize GnuTLS credentials to NULL.
4719 (deactivate_process): Call emacs_gnutls_deinit.
4720
657d08d3
JB
47212011-10-27 Juanma Barranquero <lekktu@gmail.com>
4722
4723 * image.c (x_create_x_image_and_pixmap):
4724 * w32.c (sys_rename, w32_delayed_load):
4725 * w32font.c (fill_in_logfont):
4726 * w32reg.c (x_get_string_resource): Silence compiler warnings.
4727
5430d399
JB
47282011-10-26 Juanma Barranquero <lekktu@gmail.com>
4729
4730 * w32fns.c (w32_default_color_map): New function,
4731 extracted from Fw32_default_color_map.
a7ef684b 4732 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 4733
fe0055fa
PE
47342011-10-25 Paul Eggert <eggert@cs.ucla.edu>
4735
4736 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
4737
e6346438
SM
47382011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
4739
4740 * keyboard.c (test_undefined): New function (bug#9751).
4741 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
4742
e112cc37
ET
47432011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
4744
4745 * sysdep.c (init_sys_modes): Fix the check for the controlling
4746 terminal (Bug#6649).
4747
7b5d6677
EZ
47482011-10-20 Eli Zaretskii <eliz@gnu.org>
4749
4750 * dispextern.h (struct bidi_it): New member next_en_type.
4751
4752 * bidi.c (bidi_line_init): Initialize the next_en_type member.
4753 (bidi_resolve_explicit_1): When next_en_pos is valid for the
4754 current character, check also for next_en_type being WEAK_EN.
4755 (bidi_resolve_weak): Don't enter the expensive loop if the current
4756 position is before next_en_pos. Record the bidi type of the first
4757 non-ET, non-BN character we find, in addition to its position.
4758 (bidi_level_of_next_char): Invalidate next_en_type when
4759 next_en_pos is over-stepped.
4760
7da0b018
PE
47612011-10-20 Paul Eggert <eggert@cs.ucla.edu>
4762
4763 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
4764 * editfns.c: Rewrite current-time-zone so that it invokes
4765 the equivalent of (format-time-string "%Z") to get the time zone name.
4766 This fixes a bug when the time zone name contains characters that
4767 need converting from the system time locale to Emacs internal format.
4768 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
4769 that patch fixed format-time-string to do the conversion, but
4770 I forgot to fix current-time-zone.
4771 (format_time_string): New function, containing most of
4772 what Fformat_time_string used to contain.
4773 (Fformat_time_string): Rewrite in terms of format_time_string.
4774 This doesn't change this function's behavior.
4775 (current-time-zone): Rewrite to use format_time_string.
4776 This fixes the bug reported by Michael Schierl in
4777 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
4778 Jason Rumney's 2007-06-07 change worked around this bug, but
4779 didn't fix it.
4780 * systime.h (tzname, timezone): Remove no-longer-used declarations.
4781
8547b010
EZ
47822011-10-19 Eli Zaretskii <eliz@gnu.org>
4783
4784 * xdisp.c (start_display): If the character at POS is displayed
4785 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
4786 (try_window_reusing_current_matrix): If a line ends in a display
4787 vector or the next line starts in a display vector, continue
4788 redrawing the window even though the character position of
4789 start_row was reached.
8547b010
EZ
4790 (Bug#9771, part 2)
4791
4e948d15
CY
47922011-10-18 Chong Yidong <cyd@gnu.org>
4793
4794 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
4795 with nobreak-char-display too.
4796
4787455f
EZ
47972011-10-18 Eli Zaretskii <eliz@gnu.org>
4798
4799 Fix part 3 of bug#9771.
4800 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
4801 (bidi_resolve_neutral): Don't enter the expensive loop looking for
4802 non-neutral characters if the current character is a paragraph
4803 separator (a.k.a. Newline). This avoids running the same
4804 expensive loop twice, once when we consume the preceding newline
4805 and the other time when the line actually needs to be displayed.
4806 Avoid the loop when we see neutrals on the base embedding level
4807 following a character whose directionality is the same as the
4808 paragraph's. This avoids running the expensive loop when a line
4809 ends in a long sequence of neutrals, like control characters.
4810 Add assertion against STRONG_AL type. Slightly rearrange code
4811 that determines the type of a neutral given the first non-neutral
4812 that follows it.
4813 (bidi_level_of_next_char): Set next_en_pos to zero when
4814 invalidating its info.
4815
2c91f553
EZ
48162011-10-17 Eli Zaretskii <eliz@gnu.org>
4817
4818 * xdisp.c (push_display_prop): Determine whether to record string
4819 or buffer position by IT->string, not by IT->method. Allow
4820 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
4821 (move_it_vertically_backward): Don't look for character position
4822 immediately after the newline when in a continuation line.
4823 (Bug#9771, part 1)
2c91f553 4824
c7b08b0d
MR
48252011-10-15 Martin Rudalics <rudalics@gmx.at>
4826
4827 * window.c (coordinates_in_window): Rewrite and delabelize
4828 vertical border check. (Bug#5357) (Bug#9618)
4829
6b02f655
SM
48302011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
4831
4832 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
4833 errors in XSetWindowBorder (bug#9310).
4834
81d40c92
DA
48352011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
4836
4837 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
4838 avoid crash when xmalloc overrun checking is enabled.
4839
d4172c3b
EZ
48402011-10-13 Eli Zaretskii <eliz@gnu.org>
4841
4842 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
4843 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
4844 cursor motion with <left> and <right> arrow keys.
4845
4846 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
4847 some callers set that themselves.
4848
b00eea75
EZ
48492011-10-12 Eli Zaretskii <eliz@gnu.org>
4850
4851 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
4852 display string and the previous row comes from the same string and
4853 is empty. (Bug#9739) (Bug#9738)
4854
8fe012c4
SM
48552011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
4856
4857 * doc.c (get_doc_string): Encode file name (bug#9735).
4858
0074aef2
EZ
48592011-10-12 Eli Zaretskii <eliz@gnu.org>
4860
79beb178
EZ
4861 * bidi.c (bidi_level_of_next_char):
4862 * xdisp.c (get_visually_first_element): Remove old incorrect
4863 comments regarding the Unicode Line Separator character.
4864
0074aef2
EZ
4865 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
4866
6e4b3fbe
DA
48672011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
4868
4869 * alloc.c (Fgc_status): Do not access beyond zombies array
4870 boundary if nzombies > MAX_ZOMBIES.
4871 * alloc.c (dump_zombies): Add missing format specifier.
4872
0324f3af
PE
48732011-10-12 Paul Eggert <eggert@cs.ucla.edu>
4874
b5525cac
PE
4875 * xdisp.c (set_cursor_from_row): Simplify conditionals,
4876 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
4877
0324f3af
PE
4878 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
4879 Some packages use them to denote characters with modifiers.
4880
e9b5f888
AS
48812011-10-11 Andreas Schwab <schwab@linux-m68k.org>
4882
4883 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
4884 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
4885 matching a pp-number. Rename parameter var to var1.
4886
127827c0
SM
48872011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
4888
4889 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
4890
c8fd3bd0
GM
48912011-10-08 Glenn Morris <rgm@gnu.org>
4892
4893 * callint.c (Fcall_interactively): Give a more explicit error for the
4894 'c' case with a non-character input. (Bug#8479)
4895
352ec8ff
EZ
48962011-10-08 Eli Zaretskii <eliz@gnu.org>
4897
03669ccb
EZ
4898 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
4899 lines.
7061c986
EZ
4900 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
4901 lines that are hscrolled on the left.
03669ccb 4902
352ec8ff
EZ
4903 * dispnew.c (buffer_posn_from_coords): Account for a possible
4904 presence of header-line. (Bug#4426)
4905
a66cfb1c
SM
49062011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
4907
6b02f655
SM
4908 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
4909 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 4910
7c5ee88e
PE
49112011-10-07 Paul Eggert <eggert@cs.ucla.edu>
4912
4913 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
4914 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
4915 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
4916 this makes Emacs dump core during garbage collection on rare
4917 occasions. sizeof is obviously inferior to offsetof here, so
4918 stick with offsetof.
4919 (GC_POINTER_ALIGNMENT): New macro.
4920 (mark_memory): Omit 3rd (offset) arg; caller changed.
4921 Don't assume EMACS_INT alignment is the same as pointer alignment.
4922
df1bbe5b
SM
49232011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
4924
4925 * keyboard.c (read_key_sequence_remapped): New var.
4926 (read_key_sequence): Compute remapping in the right buffer.
4927 (command_loop_1): Use read_key_sequence's remapping directly.
4928
51553db6
SM
49292011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
4930
32c1fffd
SM
4931 * dired.c (file_name_completion): Don't expand file name.
4932 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
4933 before checking file name handler.
4934
51553db6
SM
4935 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
4936 they've been requested explicitly (bug#9591).
4937
b6bd1599 49382011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
4939
4940 * keymap.c (Fsingle_key_description): Use make_specified_string
4941 instead of build_string to build string from push_key_description.
4942 (Bug#5193)
4943
f701dc2a
PE
49442011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4945
4222c55d
PE
4946 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
4947 This fixes a Y2038 bug on 64-bit hosts.
4948 * buffer.c (reset_buffer):
4949 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
4950 (Fclear_buffer_auto_save_failure):
4951 Use 0, not -1, to represent an unset failure time, since time_t
4952 might not be signed.
4953
f701dc2a
PE
4954 Remove dependency on glibc malloc internals.
4955 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4956 Move back here from lisp.h, but with their new implementations.
4957 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4958 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
4959 * charset.c (charset_table_init): New static var.
4960 (syms_of_charset): Use it instead of xmalloc. This removes a
4961 dependency on glibc malloc internals. See Eli Zaretskii's comment in
4962 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
4963 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4964 Move back to alloc.c.
4965 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4966 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
4967
9ceebf39
JD
49682011-09-30 Jan Djärv <jan.h.d@swipnet.se>
4969
4970 * nsterm.m (windowDidResize): Call x_set_window_size only when
4971 ns_in_resize is true. Otherwise set pixelwidth/height and
4972 call change_frame_size (Bug#9628).
4973
cb993c58
PE
49742011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4975
3930c88b
PE
4976 Port --enable-checking=all to Fedora 14 x86-64.
4977 * charset.c (syms_of_charset): Also account for glibc malloc's
4978 internal overhead when calculating the initial malloc maximum.
4979
cb993c58
PE
4980 Port --enable-checking=all to Fedora 14 x86.
4981 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4982 Move to lisp.h.
4983 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
4984 (overrun_check_realloc, overrun_check_free):
4985 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
4986 That way, xmalloc returns a properly-aligned pointer even if
4987 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
4988 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
4989 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
4990 into account when calculating the initial malloc maximum.
4991 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4992 Move here from alloc.c, so that charset.c can use it too.
4993 Properly align; the old code wasn't right for common 32-bit hosts
4994 when configured with --enable-checking=all.
4995 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4996 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
4997
31bed486
EZ
49982011-09-29 Eli Zaretskii <eliz@gnu.org>
4999
04c70788 5000 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
5001 use EDOM.
5002
fbcaa2f3
EZ
50032011-09-28 Eli Zaretskii <eliz@gnu.org>
5004
5005 * xdisp.c (compute_display_string_end): If there's no display
5006 string at CHARPOS, return -1.
5007
5008 * bidi.c (bidi_fetch_char): When compute_display_string_end
5009 returns a negative value, treat the character as a normal
5010 character not covered by a display string. (Bug#9624)
5011
a239d4e9
JB
50122011-09-28 Juanma Barranquero <lekktu@gmail.com>
5013
5014 * lread.c (Fread_from_string): Fix typo in docstring.
5015
88652fd5
EZ
50162011-09-27 Eli Zaretskii <eliz@gnu.org>
5017
5018 * xdisp.c (handle_invisible_prop): If invisible text ends on a
5019 newline, reseat the iterator instead of bidi-iterating there one
5020 character at a time. (Bug#9610)
32c1fffd
SM
5021 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
5022 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 5023
ed497dd4
AS
50242011-09-27 Andreas Schwab <schwab@linux-m68k.org>
5025
5026 * lread.c (readevalloop): Use correct code for NBSP.
5027 (read1): Likewise. (Bug#9608)
5028
b2bf61aa
MA
50292011-09-25 Michael Albinus <michael.albinus@gmx.de>
5030
5031 * dbusbind.c (Fdbus_register_signal): When service is not
5032 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
5033
32bbb17c
GM
50342011-09-25 Glenn Morris <rgm@gnu.org>
5035
5036 * buffer.c (truncate-lines): Doc fix.
5037
94e0933e
CY
50382011-09-24 Chong Yidong <cyd@stupidchicken.com>
5039
5040 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
5041 (Fset_window_next_buffers): Doc fix.
5042
cddde921
GM
50432011-09-24 Glenn Morris <rgm@gnu.org>
5044
5045 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
5046
1260aef1
PE
50472011-09-24 Paul Eggert <eggert@cs.ucla.edu>
5048
25b4bfa0
PE
5049 Fix minor problems found by static checking.
5050 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
5051 * indent.c (Fvertical_motion): Fix == vs = typo.
5052
e3cbd34b
EZ
50532011-09-24 Eli Zaretskii <eliz@gnu.org>
5054
a66cfb1c
SM
5055 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
5056 Default value is now t. Doc fix.
6bf7006f 5057
e3cbd34b 5058 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 5059 logic when moving up, not only when moving down. Fix the
e3cbd34b 5060 confusing name and values of the it_overshoot_expected variable;
32c1fffd 5061 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
5062
5063 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
5064 CHARPOS is covered by a display string which includes newlines.
5065 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
5066 is covered by a display string with embedded newlines.
5067
a3de0cbd
MA
50682011-09-24 Michael Albinus <michael.albinus@gmx.de>
5069
5070 * dbusbind.c (Fdbus_register_signal): Add match rule to
5071 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
5072 (Fdbus_register_method, Vdbus_registered_objects_table):
5073 Fix docstring.
a3de0cbd 5074
b260039d
JM
50752011-09-24 Jim Meyering <meyering@redhat.com>
5076
32c1fffd 5077 do not ignore write error for any output size
b260039d
JM
5078 The previous change was incomplete.
5079 While it makes emacs --batch detect the vast majority of stdout
5080 write failures, errors were still ignored whenever the output size is
5081 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
5082 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
5083 && echo FAIL: ignored write error
5084 FAIL: ignored write error
5085 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
5086 && echo FAIL: ignored write error
5087 FAIL: ignored write error
5088 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
5089
8eca8a7c
AS
50902011-09-23 Andreas Schwab <schwab@linux-m68k.org>
5091
5092 * emacs.c (Fkill_emacs): In noninteractive mode exit
5093 non-successfully if a write error occurred on stdout. (Bug#9574)
5094
3341db62
EZ
50952011-09-21 Eli Zaretskii <eliz@gnu.org>
5096
5097 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
5098 the xassert test.
5099
5100 * dispextern.h (struct it): Update the comment documenting what
5101 can it->OBJECT be.
5102
8c203dbf
EZ
51032011-09-20 Eli Zaretskii <eliz@gnu.org>
5104
5105 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
5106 a display string, extend search for cursor position to end of row.
5107 (find_row_edges): If the row ends in a newline from a display
5108 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
5109 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
5110 (Fcurrent_bidi_paragraph_direction): Fix search for previous
5111 non-empty line. Fixes confusing cursor motion with arrow keys at
5112 the beginning of a line that starts with whitespace.
8c203dbf 5113
a4824228
LMI
51142011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5115
5116 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
5117 (bug#9493).
5118
33ed493b
CY
51192011-09-18 Chong Yidong <cyd@stupidchicken.com>
5120
5121 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
5122 boolean (Bug#9154).
5123
56cd55c8
EZ
51242011-09-18 Eli Zaretskii <eliz@gnu.org>
5125
5126 * xdisp.c (display_line): Record maximum and minimum buffer
5127 positions even if no glyphs were produced (e.g., by a zero-width
5128 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
5129 buffer positions that will be removed from the glyph row because
5130 they don't fit.
c02dcedf
EZ
5131 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
5132 column is beyond frame width: don't subtract 1 "pixel" when
5133 computing width of the stretch.
3e62b7e0
EZ
5134 (reseat_at_next_visible_line_start): Undo the change made on
5135 2011-09-17 that saved paragraph information and restored it after
5136 the call to `reseat'. (Bug#9545)
56cd55c8 5137
5ed99d36 51382011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
5139
5140 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
5141 and turn window cursor on if cleared (Bug#9415).
5142
5ed99d36 51432011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
5144
5145 * search.c (boyer_moore): Take unibyte characters from pattern
5146 literally. (Bug#9458)
5147
9bade7b2
EZ
51482011-09-18 Eli Zaretskii <eliz@gnu.org>
5149
5150 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
5151
e5e9d610
PE
51522011-09-18 Paul Eggert <eggert@cs.ucla.edu>
5153
87e4427a
PE
5154 Fix minor problem found by static checking.
5155 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
5156 initialized, to pacify gcc -Wuninitialized.
5157
e5e9d610
PE
5158 * fileio.c: Report proper errno when syscall falls.
5159 (Finsert_file_contents): Save and restore errno,
5160 so that report_file_error outputs the correct diagnostic.
5161 (Fwrite_region) [CLASH_DETECTION]: Likewise.
5162
a1674f0b
EZ
51632011-09-18 Eli Zaretskii <eliz@gnu.org>
5164
5165 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
5166
fbfb6dd4
EZ
51672011-09-17 Eli Zaretskii <eliz@gnu.org>
5168
5169 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
5170 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
5171
bb187662
EZ
51722011-09-17 Eli Zaretskii <eliz@gnu.org>
5173
1137e8b8 5174 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 5175 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
5176
5177 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
5178 (bidi_find_paragraph_start): Search back for paragraph beginning
5179 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
5180 (bidi_move_to_visually_next): Only trigger paragraph-related
5181 computations when the last character is a newline or at EOB, not
5182 just any NEUTRAL_B. (Bug#9470)
5183
bb187662
EZ
5184 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
5185 truncated lines if point is covered by a display string. (Bug#9524)
5186
2e621251
PE
51872011-09-16 Paul Eggert <eggert@cs.ucla.edu>
5188
5189 * xselect.c: Relax test for outgoing X longs (Bug#9498).
5190 (cons_to_x_long): New function.
5191 (lisp_data_to_selection_data): Use it. Correct the test for
5192 short-versus-long data; it was negated. Break out of vector
5193 loop, for efficiency, when a long datum is discovered.
5194
91a15bc6
SM
51952011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
5196
5197 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
5198
b41c3a35
EZ
51992011-09-16 Eli Zaretskii <eliz@gnu.org>
5200
5201 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
5202 GCC PR/17406) by declaring this function with external scope.
5203
7812ba2d
PE
52042011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5205
5206 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
5207 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
5208
cf7edc2a
AS
52092011-09-15 Andreas Schwab <schwab@linux-m68k.org>
5210
5211 * editfns.c (Fformat): Correctly handle text properties on "%%".
5212
bd01620e
EZ
52132011-09-15 Eli Zaretskii <eliz@gnu.org>
5214
5215 * xterm.c (x_draw_composite_glyph_string_foreground):
5216 * w32term.c (x_draw_composite_glyph_string_foreground):
5217 * term.c (encode_terminal_code):
5218 * composite.c (composition_update_it, get_composition_id):
5219 * xdisp.c (get_next_display_element)
5220 (fill_composite_glyph_string): Add comments about special meaning
5221 of TAB characters in a composition.
5222
a02719a3
PE
52232011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5224
5225 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
5226 This occurs when processing a multibyte format.
5227 Problem reported by Wolfgang Jenker.
a02719a3 5228
72589a3c
JB
52292011-09-15 Johan Bockgård <bojohan@gnu.org>
5230
5231 * xdisp.c (try_cursor_movement): Only check for exact match if
5232 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
5233
1c14176c
PE
52342011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5235
5236 Remove unused external symbols.
5237 * dispextern.h (calc_pixel_width_or_height): Remove decl.
5238 * xdisp.c (calc_pixel_width_or_height): Now static.
5239 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
5240 * indent.c (check_display_width):
5241 * w32term.c: Fix comment to match code.
5242 * xterm.c, xterm.h (x_catching_errors): Remove.
5243
d2eea5b5
PE
52442011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5245
5246 * xselect.c: Use signed conversions more consistently (Bug#9498).
5247 (selection_data_to_lisp_data): Assume incoming selection data are
5248 signed integers, not unsigned. This is to be consistent with
5249 outgoing selection data, which was modified to use signed integers
5250 in as part of the fix to Bug#9196 in response to Jan D.'s comment
5251 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
5252 expects long, not unsigned long.
5253
46888499
EZ
52542011-09-14 Eli Zaretskii <eliz@gnu.org>
5255
5256 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
5257 computation of loop end. Reported by Johan Bockgård
5258 <bojohan@gnu.org>.
5259
ef8ef9fb
CY
52602011-09-13 Chong Yidong <cyd@stupidchicken.com>
5261
5262 * frame.c (Fother_visible_frames_p): Function deleted.
5263
fa819fed
EZ
52642011-09-12 Eli Zaretskii <eliz@gnu.org>
5265
5266 * indent.c (compute_motion): Process display vector front to back
5267 rather than the other way around. (Bug#2496)
5268
2ba8e008
SM
52692011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
5270
5271 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
5272
20f53c69
CY
52732011-09-11 Chong Yidong <cyd@stupidchicken.com>
5274
5275 * minibuf.c (Fread_from_minibuffer): Doc fix.
5276
d562d7a4
EZ
52772011-09-11 Eli Zaretskii <eliz@gnu.org>
5278
5279 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
5280 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
5281
1c4d7f3d
LMI
52822011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5283
5284 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
5285 value for non-existent files.
5286
b885bf36
EZ
52872011-09-11 Eli Zaretskii <eliz@gnu.org>
5288
5289 * fileio.c (Finsert_file_contents): If the file cannot be opened,
5290 set its "size" to -1. This will set the modtime_size field of
5291 the corresponding buffer to -1, which is what
5292 verify-visited-file-modtime expects for files that do not exist.
5293 (Bug#9139)
5294
6612f0bf
PE
52952011-09-11 Paul Eggert <eggert@cs.ucla.edu>
5296
5297 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
5298 here ...
5299 * lisp.h: ... from here. push_key_description is no longer
5300 defined in keyboard.c, so its declaration should not be in
5301 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
5302 logically belongs with push_key_description.
5303
dfb3f755
PE
53042011-09-10 Paul Eggert <eggert@cs.ucla.edu>
5305
5306 * buffer.h: Include <sys/types.h> instead of <time.h>.
5307 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
5308 Problem reported by Herbert J. Skuhra.
5309
3134906c
LMI
53102011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
5311
5312 * xml.c (parse_region): Make the parsing work for
5313 non-comment-starting XML files again (bug#9144).
5314
8d903f4e
AS
53152011-09-10 Andreas Schwab <schwab@linux-m68k.org>
5316
5317 * image.c (gif_load): Fix calculation of bottom and right corner.
5318 (Bug#9468)
5319
80ad64f4
EZ
53202011-09-10 Eli Zaretskii <eliz@gnu.org>
5321
5322 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
5323 redisplay in small windows.
5324
208a048d
EZ
53252011-09-09 Eli Zaretskii <eliz@gnu.org>
5326
5327 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
5328
9b1c252e
MR
53292011-09-08 Martin Rudalics <rudalics@gmx.at>
5330
5331 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
5332 Operate on live windows only.
5333
2949f33b
JB
53342011-09-08 Juanma Barranquero <lekktu@gmail.com>
5335
5336 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
5337
e08dcafd
EZ
53382011-09-07 Eli Zaretskii <eliz@gnu.org>
5339
5340 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
5341 only under bidi iteration.
5342
115b96bd
JD
53432011-09-07 Jan Djärv <jan.h.d@swipnet.se>
5344
5345 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
5346
c8199d0f
PE
53472011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5348
5349 isnan: Fix porting problem to Solaris 10 with bundled gcc.
5350 Without this fix, the command to link temacs failed due to an
5351 undefined symbol __builtin_isnan. This is because
5352 /usr/include/iso/math_c99.h #defines isnan(x) to
5353 __builtin_isnan(x), but the bundled gcc, which identifies itself
5354 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
5355 a __builtin_isnan.
5356 * floatfns.c (isnan): #undef, and then #define to a clone of
5357 what's in data.c.
5358 (Fisnan): Always define, since it's always available now.
5359 (syms_of_floatfns): Always define isnan at the Lisp level.
5360
e39b275c 53612011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
5362
5363 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
5364
b2db44d9 53652011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 5366
f4af5137 5367 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
5368 The previous code assumed that file offsets (off_t values) fit in
5369 EMACS_INT variables, which is not true on typical 32-bit hosts.
5370 The code messed up by falsely reporting buffer overflow in cases
5371 such as (insert-file-contents "big" nil 1 2) into an empty buffer
5372 when "big" contains more than 2**29 bytes, even though this
5373 inserts just one byte and does not overflow the buffer.
5374 (Finsert_file_contents): Store file offsets as off_t
5375 values, not as EMACS_INT values. Check for overflow when
5376 converting between EMACS_INT and off_t. When checking for
5377 buffer overflow or for overlap, take the offsets into account.
5378 Don't use EMACS_INT for small values where int suffices.
5379 When checking for overlap, fix a typo: ZV was used where
5380 ZV_BYTE was intended.
5381 (Fwrite_region): Don't assume off_t fits into 'long'.
5382 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
5383
ecfc0a49
MA
53842011-09-05 Michael Albinus <michael.albinus@gmx.de>
5385
5386 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
5387
6511acf2 53882011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 5389
0999621a 5390 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
5391
5392 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 5393 (esprintf, exprintf, evxprintf): New functions.
62f19c19 5394 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 5395 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
5396 (modify_event_symbol): Do not assume that the length of
5397 name_alist_or_stem is safe to alloca and fits in int.
5398 (Fexecute_extended_command): Likewise for function name and binding.
5399 (Frecursion_depth): Wrap around reliably on integer overflow.
5400 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
5401 since some callers pass EMACS_INT values.
5402 (Fsingle_key_description): Don't crash if symbol name contains more
5403 than MAX_ALLOCA bytes.
5404 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
5405 (get_minibuffer): Arg is now EMACS_INT, not int.
5406 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 5407 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
5408 * window.h (command_loop_level, minibuf_level): Reflect API changes.
5409
2be7d702
PE
5410 * dbusbind.c (signature_cat): New function.
5411 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
5412 Do not overrun buffer; instead, report string overflow.
5413
9d1df220
PE
5414 * dispnew.c (add_window_display_history): Don't overrun buffer.
5415 Truncate instead; this is OK since it's just a log.
5416
33ef5c64
PE
5417 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
5418 even if the time zone offset is outlandishly large.
5419 Don't mishandle offset == INT_MIN.
5420
66c6fdd5
PE
5421 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
5422 when creating daemon; the previous buffer-overflow check was incorrect.
5423
d749b01b
PE
5424 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
5425 which has the guts of the old verror function.
5426
b5cd1905
PE
5427 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
5428 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
5429
6e1a67fb
PE
5430 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
5431 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 5432 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 5433 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
5434 length of string rather than counting it via multiple sprintfs;
5435 that's simpler and more reliable.
c21721cc
PE
5436 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
5437 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
5438 sprintf, in case result does not fit in int.
5439
c57b67fc
PE
5440 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
5441 (fontset_from_font): Print it.
5442
8a401434
PE
5443 * frame.c (tty_frame_count): Now printmax_t, not int.
5444 (make_terminal_frame, set_term_frame_name): Print it.
5445 (x_report_frame_params): In X, window IDs are unsigned long,
5446 not signed long, so print them as unsigned.
5447 (validate_x_resource_name): Check for implausibly long names,
5448 and don't assume name length fits in 'int'.
5449 (x_get_resource_string): Don't blindly alloca invocation name;
5450 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
5451 not fit in int.
5452
6e1a67fb
PE
5453 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
5454 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
5455 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
5456
0df02bf3
PE
5457 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
5458 Use esprintf, not sprintf, in case result does not fit in int.
5459
48e30793
PE
5460 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5461 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
5462 it as a large positive number.
5463 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
5464 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5465
a66ff6d8
PE
5466 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
5467 in case result does not fit in int.
5468
aca216ff
PE
5469 * print.c (float_to_string): Detect width overflow more reliably.
5470 (print_object): Make sprintf buffer a bit bigger, to avoid potential
5471 buffer overrun. Don't assume list length fits in 'int'. Treat
5472 print length of 0 as 0, not as infinity; to be consistent with other
5473 uses of print length in this function. Don't overflow print length
5474 index. Don't assume hash table size fits in 'long', or that
5475 vectorlike size fits in 'unsigned long'.
5476
31c286f7
PE
5477 * process.c (make_process): Use printmax_t, not int, to format
5478 process-name gensyms.
5479
55e5faa1
PE
5480 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
5481
80f2e268
PE
5482 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
5483 to avoid potential buffer overrun.
5484
670741ab
PE
5485 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
5486 if X resource line is longer than 512 bytes.
5487
b7163a50
PE
5488 * xfns.c (x_window): Make sprintf buffer a bit bigger
5489 to avoid potential buffer overrun.
5490
ae58ff1f
PE
5491 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
5492
c43c8a6a
PE
5493 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
5494
3f8236f4
PE
54952011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5496
53e9fe90 5497 Integer overflow fixes for scrolling, etc.
6511acf2
PE
5498 Without these, Emacs silently mishandles large integers sometimes.
5499 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
5500 it were "C-u 1 M-x recenter" on a typical 64-bit host.
5501
6511acf2
PE
5502 * xdisp.c (try_window_id): Check Emacs fixnum range before
5503 converting to 'int'.
806add1d 5504
6511acf2 5505 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
5506 Check that an Emacs fixnum is in range before assigning it to 'int'.
5507 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
5508 values converted from Emacs fixnums.
5509 (Frecenter): Don't wrap around a line count if it is out of 'int'
5510 range; instead, treat it as an extreme value.
5511 (Fset_window_configuration, compare_window_configurations):
5512 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
5513
6511acf2
PE
5514 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
5515 that can exceed INT_MAX. Check that EMACS_INT value is in range
5516 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
5517 (match_limit): Don't assume that a fixnum can fit in 'int'.
5518
6511acf2 5519 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
5520 exceed INT_MAX.
5521
6511acf2 5522 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
5523 (Fvertical_motion): Don't wrap around LINES values that don't fit
5524 in 'int'. Instead, treat them as extreme values. This is good
5525 enough for windows, which can't have more than INT_MAX lines anyway.
5526
fcb901a7
LMI
55272011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5528
0f2f6b6d
LMI
5529 * Require libxml/parser.h to avoid compilation warning.
5530
fcb901a7
LMI
5531 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
5532
5533 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
5534 since this reportedly can destroy thread storage.
5535
6e20a0d4
CY
55362011-08-30 Chong Yidong <cyd@stupidchicken.com>
5537
5538 * syntax.c (find_defun_start): Update all cache variables if
5539 exiting early (Bug#9401).
5540
148ae00e
EZ
55412011-08-30 Eli Zaretskii <eliz@gnu.org>
5542
f6cfbd8f
EZ
5543 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
5544
148ae00e
EZ
5545 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
5546 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
5547 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
5548
5549 * term.c (tty_append_glyph): New function.
5550 (produce_stretch_glyph): Static function and its prototype deleted.
5551
a66cfb1c
SM
5552 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
5553 Add prototypes.
148ae00e 5554
c4a07a4c
PE
55552011-08-29 Paul Eggert <eggert@cs.ucla.edu>
5556
5557 * image.c (parse_image_spec): Check for nonnegative, not for positive,
5558 when checking :margin (Bug#9390).
5559 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 5560 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
5561 so that the name doesn't mislead. All uses changed.
5562
6bc8cd65
JB
55632011-08-28 Johan Bockgård <bojohan@gnu.org>
5564
5565 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
5566 set_tty_hooks.
5567
dca4927e
EZ
55682011-08-27 Eli Zaretskii <eliz@gnu.org>
5569
5570 * xdisp.c (move_it_to): Don't bail out early when reaching
5571 position beyond to_charpos, if we are scanning backwards.
5572 (move_it_vertically_backward): When DY == 0, make sure we get to
5573 the first character in the line after the newline.
5574
f2cad773
PE
55752011-08-27 Paul Eggert <eggert@cs.ucla.edu>
5576
5577 * ccl.c: Improve and simplify overflow checking (Bug#9196).
5578 (ccl_driver): Do not generate an out-of-range pointer.
5579 (Fccl_execute_on_string): Remove unnecessary check for
5580 integer overflow, noted by Stefan Monnier in
5581 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
5582 Remove a FIXME that didn't need fixing.
5583 Simplify the newly-introduced buffer reallocation code.
5584
0cae2cdb
JB
55852011-08-27 Juanma Barranquero <lekktu@gmail.com>
5586
5587 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
5588
5fc295a4 55892011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 5590
70c60eb2 5591 Integer and memory overflow issues (Bug#9196).
726e0ab1 5592
d31850da
PE
5593 * doc.c (get_doc_string): Rework so that
5594 get_doc_string_buffer_size is the actual buffer size, rather than
5595 being 1 less than the actual buffer size; this makes xpalloc more
5596 convenient.
5597
a69fbedb
PE
5598 * image.c (x_allocate_bitmap_record, cache_image):
5599 * xselect.c (Fx_register_dnd_atom):
5600 Simplify previous changes by using xpalloc.
5601
fe5c5d37
PE
5602 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
5603 since either will do and ptrdiff_t is convenient with xpalloc.
5604
0065d054
PE
5605 * charset.c (charset_table_size)
5606 (struct charset_sort_data.priority): Now ptrdiff_t.
5607 (charset_compare): Don't overflow if priorities differ greatly.
5608 (Fsort_charsets): Don't assume list length fits in int.
5609 Check for size-calculation overflow when allocating sort data.
5610 (syms_of_charset): Allocate an initial charset table that is
5611 just under 64 KiB, to avoid problems with glibc malloc and mmap.
5612
5613 * cmds.c (internal_self_insert): Check for size-calculation overflow.
5614
5615 * composite.h (struct composition.glyph_len): Now int, not unsigned.
5616 The actual value is always <= INT_MAX, and leaving it unsigned made
5617 overflow checking harder.
5618
5619 * dispextern.h (struct glyph_matrix.rows_allocated)
5620 (struct face_cache.size): Now ptrdiff_t, for convenience in use
5621 with xpalloc. The values are still always <= INT_MAX.
5622
5623 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
5624
5625 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
5626 (SAFE_NALLOCA): New macro.
5627
5628 * region-cache.c (struct boundary.pos, find_cache_boundary)
5629 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
5630 (set_cache_region, invalidate_region_cache)
5631 (revalidate_region_cache, know_region_cache, region_cache_forward)
5632 (region_cache_backward, pp_cache):
5633 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
5634 so that ptrdiff_t * can be passed to xpalloc.
5635 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
5636 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
5637 (pp_cache): Don't assume cache_len fits in int.
5638 * region-cache.h: Adjust extern decls to match.
5639
5640 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
5641 EMACS_INT, since either will do, for xpalloc.
5642
5643 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
5644 (xnmalloc, xnrealloc, xpalloc): New functions.
5645
726e0ab1
PE
5646 * bidi.c (bidi_shelve_header_size): New constant.
5647 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
5648 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
5649
51f30bc5 5650 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
5651 * buffer.c (overlays_at, overlays_in, record_overlay_string)
5652 (overlay_strings):
5653 Don't update size of array until after memory allocation succeeds,
5654 because xmalloc/xrealloc may not return.
0065d054
PE
5655 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
5656 now that we have proper integer overflow checking.
5657 (record_overlay_string, overlay_strings): Catch overflows when
5658 calculating size of overlay_str_buf.
726e0ab1 5659
0065d054
PE
5660 * callproc.c (Fcall_process): Check for size overflow when
5661 calculating size of args2.
5662 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
5663 Normally we prefer signed values, but sticking with ptrdiff_t would
5664 require adding more-complicated checks.
726e0ab1
PE
5665
5666 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
5667 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
5668 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 5669 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
5670
5671 * character.c (Fstring): Check for size-calculation overflow.
5672
5673 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
5674 unnecessary integer overflow. Check for size overflow.
5675 (encode_coding_object): Don't update size until xmalloc succeeds.
5676
5677 * composite.c (get_composition_id): Check for overflow in glyph
5678 length calculations.
5679
5680 Integer and memory overflow fixes for display code.
5681 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
5682 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
5683 (scrolling_window): Check for overflow in size calculations.
5684 (line_draw_cost, realloc_glyph_pool, add_row_entry):
5685 Don't assume glyph table len fits in int.
5686 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
5687 (row_table_size): Now ptrdiff_t, not int.
5688 (scrolling_window): Avoid overflow in size calculations.
5689 Don't update size until allocation succeeds.
5690 * fns.c (concat): Check for overflow in size calculations.
5691 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
5692 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5693 (NEXT_ALMOST_PRIME_LIMIT): New constant.
5694
5695 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
5696 (get_doc_string): Check for size calculation overflow.
5697 Don't update size until allocation succeeds.
5698 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
5699 EMACS_INT, where ptrdiff_t will do.
5700 (Fsubstitute_command_keys): Check for string overflow.
5701
5702 * editfns.c (set_time_zone_rule): Don't assume environment length
5703 fits in int.
5704 (message_length): Now ptrdiff_t, not int.
5705 (Fmessage_box): Don't update size until allocation succeeds.
5706 Don't assume message length fits in int.
5707 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
5708
0065d054
PE
5709 * emacs.c (main): Do not reallocate argv, since there is a null at
5710 the end that can be overwritten, and this way there's no need to
5711 worry about size-calculation overflow.
5712 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
5713
5714 * eval.c (init_eval_once, grow_specpdl): Don't update size until
5715 alloc succeeds.
5716 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
5717
5718 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
5719 (x_set_scroll_bar_width, x_figure_window_size):
5720 Check for integer overflow.
5721 (x_set_alpha): Do not assume XINT fits in int.
5722
5723 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
5724 This is for the members text_lines, text_cols, total_lines, total_cols,
5725 where the system imposes an 'int' limit.
5726
5727 * fringe.c (Fdefine_fringe_bitmap):
5728 Don't update size until alloc works.
5729
5730 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
5731 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
5732
5733 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
5734 Check for size-calculation overflow.
5735 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
5736 do, as we prefer signed integers.
5737 (id_to_widget.max_size, id_to_widget.used)
5738 (xg_store_widget_in_map, xg_remove_widget_from_map)
5739 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
5740 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
5741 Use and return ptrdiff_t, not int.
5742 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
5743 * gtkutil.h: Change prototypes to match the above.
5744
5745 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
5746 are duplicate now that they've been promoted to lisp.h.
5747 (x_allocate_bitmap_record, x_alloc_image_color)
5748 (make_image_cache, cache_image, xpm_load):
5749 Don't update size until alloc is done.
5750 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
5751 (x_detect_edges):
3256efce 5752 Check for size calculation overflow.
726e0ab1
PE
5753 (ct_colors_allocated_max): New constant.
5754 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
5755 overflow.
3256efce 5756
726e0ab1
PE
5757 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
5758 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
5759 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
5760 Use ptrdiff_t, not int, to count maps.
5761 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
5762 calculations. Don't update size until allocation succeeds.
5763 Redo calculations to avoid overflow.
726e0ab1
PE
5764 * keyboard.h: Change prototypes to match the above.
5765
5766 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
5767 to count maps.
5768 (current_minor_maps): Check for size calculation overflow.
5769 * keymap.h: Change prototypes to match the above.
5770
5771 * lread.c (read1, init_obarray): Don't update size until alloc done.
5772
5773 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
5774 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
5775
726e0ab1
PE
5776 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
5777 Now ptrdiff_t, not int.
5778 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
5779 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
5780
5781 * process.c (Fnetwork_interface_list): Check for overflow
5782 in size calculation.
5783
5784 * region-cache.c (move_cache_gap): Check for size calculation overflow.
5785
5786 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
5787 overflow. Don't bother calling xmalloc when xrealloc will do.
5788
5789 * search.c (Freplace_match): Check for size calculation overflow.
5790 (Fset_match_data): Don't assume list lengths fit in 'int'.
5791
5792 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
5793 for command line length. Do not attempt to address one before the
5794 beginning of an array, as that's not portable.
5795
5796 * term.c (max_frame_lines): Remove; unused.
5797 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
5798 not int.
5799 (encode_terminal_code, calculate_costs): Check for size
5800 calculation overflow.
5801 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
5802 table lengths and related sizes. Don't update size until alloc
5803 done. Redo calculations to avoid overflow.
5804 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
5805
5806 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
5807 subtracting pointers.
5808 (gobble_line): Check for overflow more carefully. Don't update size
5809 until alloc done.
5810
5811 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
5812 Don't update size until alloc done.
5813 Redo size calculations to avoid overflow.
5814 Check for size calculation overflow.
0065d054 5815 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
5816
5817 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
5818 Use ptrdiff_t, not int, for sizes.
5819 (store_mode_line_noprop_char): Don't update size until alloc done.
5820
0065d054
PE
5821 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
5822 Use ptrdiff_t, not int, for sizes.
5823 (Finternal_make_lisp_face, cache_face):
5824 Check for size calculation overflow.
5825 (cache_face): Treat size calculation overflows as if they were
5826 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
5827
5828 * xfns.c (x_encode_text, x_set_name_internal)
5829 (Fx_change_window_property): Use ptrdiff_t, not int, to count
5830 sizes, since they can exceed INT_MAX in size. Check for size
5831 calculation overflow.
5832
0065d054
PE
5833 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
5834 (xg_select): Check for size calculation overflow.
726e0ab1
PE
5835 Don't update size until alloc done.
5836
0065d054 5837 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 5838 as sprintf is limited to int lengths.
1d526e2f 5839
252c5ee1
PE
5840 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
5841 (X_LONG_MIN): New macros.
864d7ce7
PE
5842 Use them to make the following changes clearer.
5843 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
5844 This change doesn't affect the value now, but it may help remind
5845 future maintainers not to raise the value too much later.
5846 (SELECTION_QUANTUM): Remove, replacing with ...
5847 (selection_quantum): ... new function, which avoids overflow.
5848 All uses changed.
5849 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
5850 assumption that selection length fits in 'int'.
5851 (x_reply_selection_request, x_handle_selection_request)
5852 (x_get_window_property, receive_incremental_selection)
5853 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
5854 (lisp_data_to_selection_data, clean_local_selection_data):
5855 Use ptrdiff_t, not int, to record length of selection.
5856 (x_reply_selection_request, x_get_window_property)
5857 (receive_incremental_selection, x_property_data_to_lisp):
5858 Redo calculations to avoid overflow.
5859 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 5860 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
5861 something.
5862 (x_get_window_property, receive_incremental_selection)
5863 (lisp_data_to_selection_data, x_property_data_to_lisp):
5864 Check for size-calculation overflow.
5865 (x_get_window_property, receive_incremental_selection)
5866 (lisp_data_to_selection_data, Fx_register_dnd_atom):
5867 Don't store size until memory allocation succeeds.
5868 (x_get_window_property): Plug memory leak on memory exhaustion.
5869 Don't double-block input; malloc is safe here. Don't assume 2**34
5870 - 4 fits in unsigned long. Add an xassert to check
5871 XGetWindowProperty overflow. Be more careful about overflow
5872 calculations, and distinguish size from memory overflow better.
5873 (receive_incremental_selection): When tracing, don't assume
5874 unsigned int is less than INT_MAX.
5875 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
5876 harmful) conversions of unsigned short to int.
5877 (lisp_data_to_selection_data): Don't assume that integers
5878 in the range -65535 through -1 fit in an X unsigned short.
5879 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
5880 result parameters unless successful. Rely on cons_to_unsigned
5881 to report problems with elements; the old code wasn't right anyway.
5882 (x_check_property_data): Check for int overflow; we cannot use
5883 a wider type due to X limits.
5884 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
5885
726e0ab1 5886 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 5887
0065d054
PE
5888 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
5889 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
5890 (x_color_cells): Don't store size until memory allocation succeeds.
5891 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 5892 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
5893 (x_term_init): Don't assume length fits in int (sprintf is limited
5894 to int size).
bc18e09d 5895
ebfa62c0
PE
5896 Use ptrdiff_t for composition IDs.
5897 * character.c (lisp_string_width):
5898 * composite.c (composition_table_size, n_compositions)
5899 (get_composition_id, composition_gstring_from_id):
5900 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
5901 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
5902 * window.c (Frecenter):
5903 Use ptrdiff_t, not int, for composition IDs.
5904 * composite.c (get_composition_id): Check for integer overflow.
5905 * composite.h: Adjust prototypes to match the above changes.
5906
d3411f89
PE
5907 Use ptrdiff_t for hash table indexes.
5908 * category.c (hash_get_category_set):
5909 * ccl.c (ccl_driver):
5910 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
5911 * coding.c (coding_system_charset_list, detect_coding_system):
5912 * coding.h (struct coding_system.id):
5913 * composite.c (get_composition_id, gstring_lookup_cache):
5914 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
5915 * image.c (xpm_get_color_table_h):
5916 * lisp.h (hash_lookup, hash_put):
5917 * minibuf.c (Ftest_completion):
5918 Use ptrdiff_t for hash table indexes, not int (which is too
5919 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
5920 32-bit --with-wide-int hosts).
5921
e097a6fa
PE
5922 * charset.c (Fdefine_charset_internal): Check for integer overflow.
5923 Add a FIXME comment about memory leaks.
5924 (syms_of_charset): Don't assume xmalloc returns.
5925
5637687f
PE
5926 Don't assume that stated character widths fit in int.
5927 * character.c (Fchar_width, c_string_width, lisp_string_width):
5928 * character.h (CHAR_WIDTH):
5929 * indent.c (MULTIBYTE_BYTES_WIDTH):
5930 Use sanitize_char_width to avoid undefined and/or bad behavior
5931 with outlandish widths.
a66cfb1c 5932 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
5933 now that we have two such functions. All uses changed.
5934 (sanitize_char_width): New inline function.
5935
a2271ba2
PE
5936 Don't assume that tab-width fits in int.
5937 * character.h (sanitize_width): New inline function.
5938 (SANE_TAB_WIDTH): New macro.
5939 (ASCII_CHAR_WIDTH): Use it.
5940 * indent.c (sane_tab_width): Remove. All uses replaced by
5941 SANE_TAB_WIDTH (current_buffer).
5942 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
5943
18c52557
PE
5944 * fileio.c: Integer overflow issues with file modes.
5945 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
5946
caeeedc1
PE
5947 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
5948 Remove unreachable code.
5949 (read_hex, load_charset_map_from_file): Check for integer overflow.
5950
6df6ae42 5951 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
5952 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
5953 (x_send_scroll_bar_event): Likewise. Check that the size does not
5954 exceed limits imposed by XClientMessageEvent, as well as the usual
5955 ptrdiff_t and size_t limits.
5956
b13995db
PE
5957 * keyboard.c: Overflow, signedness and related fixes.
5958 (make_lispy_movement): Use same integer type in forward decl
5959 that is used in the definition.
5960 (read_key_sequence, keyremap_step):
5961 Change bufsize argument back to int, undoing my 2011-03-30 change.
5962 We prefer signed types, and int is wide enough here.
5963 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
5964 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
5965 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
5966 length, not size_t. Use ptrdiff_t for index, not int.
5967 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
5968 possibility of integer overflow.
5969
13464394
PE
5970 Overflow, signedness and related fixes for images.
5971
5972 * dispextern.h (struct it.stack[0].u.image.image_id)
5973 (struct_it.image_id, struct image.id, struct image_cache.size)
5974 (struct image_cache.used, struct image_cache.ref_count):
5975 * gtkutil.c (update_frame_tool_bar):
5976 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
5977 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
5978 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
5979 * nsmenu.m (update_frame_tool_bar):
5980 * xdisp.c (calc_pixel_width_or_height):
5981 * xfns.c (image_cache_refcount):
5982 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
5983 on typical 64-bit hosts.
5984
5985 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5986 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
5987 Omit unnecessary casts to int.
5988 (parse_image_spec): Check that integers fall into 'int' range
5989 when the callers expect that.
5990 (image_ascent): Redo ascent calculation to avoid int overflow.
5991 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
5992 (lookup_image): Remove unnecessary tests.
5993 (xbm_image_p): Locals are now of int, not EMACS_INT,
5994 since parse_image_check makes sure they fit into int.
5995 (png_load, gif_load, svg_load_image):
5996 Prefer int to unsigned where either will do.
5997 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
5998 old tiff_error_handler and tiff_warning_handler.
5999 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
6000 stack buffer overflows. It uses only the features of vsnprintf
6001 that are common to both POSIX and native Microsoft.
6002 (tiff_error_handler, tiff_warning_handler): Use it.
6003 (tiff_load, gif_load, imagemagick_load_image):
6004 Don't assume :index value fits in 'int'.
6005 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
6006 (imagemagick_load_image): Check that crop parameters fit into
6007 the integer types that MagickCropImage accepts. Don't assume
6008 Vimagemagick_render_type has a nonnegative value. Don't assume
6009 size_t fits in 'long'.
6010 (gs_load): Use printmax_t to print the widest integers possible.
6011 Check for integer overflow when computing image height and width.
6012
c11821d4
EZ
60132011-08-26 Eli Zaretskii <eliz@gnu.org>
6014
6015 * xdisp.c (redisplay_window): Don't force window start if point
6016 will be invisible in the resulting window. (Bug#9324)
6017
0c95fcf7
EZ
60182011-08-25 Eli Zaretskii <eliz@gnu.org>
6019
6020 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
6021 the display spec is of the form `(space ...)'.
6022 (handle_display_spec): Return the value returned by
6023 handle_single_display_spec, not just 1 or zero.
6024 (handle_single_display_spec): If the display spec is of the form
6025 `(space ...)', and specifies display in the text area, return 2
6026 rather than 1.
fee65a97 6027 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
6028 accurately, and prefer exact match for point under bidi.
6029 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
6030
6031 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
6032 into disp_prop; all users changed.
6033
6034 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
6035 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
6036 for the text covered by the display property.
6037
e4ed06f1
CY
60382011-08-25 Chong Yidong <cyd@stupidchicken.com>
6039
6040 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
6041 Change return value to nil.
6042 (Frecord_buffer): Delete unused function.
6043
f67cdd7f
EZ
60442011-08-24 Eli Zaretskii <eliz@gnu.org>
6045
5980d4c6
EZ
6046 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
6047 buffers, return left-to-right.
8610fe8b
EZ
6048 (set_cursor_from_row): Consider candidate row a win if its glyph
6049 represents a newline and point is on that newline. Fixes cursor
6050 positioning on the newline at EOL of R2L text within L2R
6051 paragraph, and vice versa.
6052 (try_cursor_movement): Check continued rows, in addition to
6053 continuation rows. Fixes unwarranted scroll when point enters a
6054 continued line of R2L text within an L2R paragraph, or vice versa.
6055 (cursor_row_p): Consider the case of point being equal to
6056 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
6057 from the end of a short line to the beginning of a continued line
6058 of R2L text within L2R paragraph.
6059 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
6060 composed characters.
5980d4c6 6061
f67cdd7f
EZ
6062 * bidi.c (bidi_check_type): Use xassert.
6063 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
6064 members.
6065
bca633fb
EZ
60662011-08-23 Eli Zaretskii <eliz@gnu.org>
6067
6068 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
6069 a character.
6070
4a5885a7
CY
60712011-08-23 Chong Yidong <cyd@stupidchicken.com>
6072
6073 * nsfont.m (ns_otf_to_script): Fix typo.
6074
0902a04e
KH
60752011-08-22 Kenichi Handa <handa@m17n.org>
6076
6077 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
6078 extra slot even if the purpose is char-code-property-table.
6079
1a2e6670
EZ
60802011-08-23 Eli Zaretskii <eliz@gnu.org>
6081
8ddde651
EZ
6082 * xdisp.c (redisplay_window): When computing centering_position,
6083 account for the height of the header line. (Bug#8874)
6084
425cc014
EZ
6085 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
6086 instead of CHAR_TO_BYTE. Fixes a crash when a completion
6087 candidate is selected by the mouse, and that candidate has a
6088 composed character under the mouse.
6089
1a2e6670
EZ
6090 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
6091 coordinates reported by pos-visible-in-window-p for a composed
6092 character in column zero.
6093
8b76d6f8
SM
60942011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
6095
6096 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
6097
dac347dd
EZ
60982011-08-22 Eli Zaretskii <eliz@gnu.org>
6099
6100 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
6101 consider it a hit if to_charpos is anywhere in the range of the
6102 composed buffer positions.
6103
e013fb34
CY
61042011-08-22 Chong Yidong <cyd@stupidchicken.com>
6105
6106 * image.c (gif_load): Don't assume that each subimage has the same
6107 dimensions as the base image. Handle disposal method that is
6108 "undefined" by the gif spec (Bug#9335).
6109
bd1ba3e8
CY
61102011-08-20 Chong Yidong <cyd@stupidchicken.com>
6111
6112 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 6113 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 6114
54a1215b
EZ
61152011-08-19 Eli Zaretskii <eliz@gnu.org>
6116
823564e5
EZ
6117 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
6118 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
6119 from an Org mode buffer to a Speedbar frame.
6120
54a1215b
EZ
6121 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
6122 a composition, take its buffer position from IT->cmp_it.charpos.
6123 Fixes cursor positioning at the beginning of a line that begins
6124 with a composed character.
6125
9778ebcc
EZ
61262011-08-18 Eli Zaretskii <eliz@gnu.org>
6127
0be6ee06
EZ
6128 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
6129 character bidirectional type, use STRONG_L instead. Fixes crashes
6130 in a buffer produced by `describe-categories'.
6131
9778ebcc
EZ
6132 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
6133 members before the level stack, so they would be saved and
6134 restored when copying iterator state. Fixes incorrect reordering
6135 around TABs covered by display properties.
6136
156bffbe
AS
61372011-08-18 Andreas Schwab <schwab@linux-m68k.org>
6138
6b02f655 6139 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 6140
72ad093b
CY
61412011-08-17 Chong Yidong <cyd@stupidchicken.com>
6142
6143 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
6144 (internal_condition_case_2, internal_condition_case_n):
6145 Remove unnecessary aborts (Bug#9081).
72ad093b 6146
35774242
EZ
61472011-08-17 Eli Zaretskii <eliz@gnu.org>
6148
6149 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
6150 has no `load' handler, try opening the file locally. (Bug#9311)
6151
db76dd85
KB
61522011-08-16 Ken Brown <kbrown@cornell.edu>
6153
6154 * gmalloc.c: Expand comment.
6155
b215eee5
EZ
61562011-08-16 Eli Zaretskii <eliz@gnu.org>
6157
6158 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
6159 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
6160
a4579d33
KB
61612011-08-16 Ken Brown <kbrown@cornell.edu>
6162
6163 Fix memory allocation problems in Cygwin build (Bug#9273).
6164
6165 * unexcw.c ( __malloc_initialized): Declare external variable.
6166 (fixup_executable): Force the dumped emacs to reinitialize malloc.
6167
8b76d6f8
SM
6168 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
6169 New variables.
a4579d33
KB
6170 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
6171 dumped emacs.
6172 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
6173 in the static heap.
6174 [CYGWIN] (special_realloc): New function.
6175 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
6176 requests to realloc storage in the static heap.
6177
3ebec551
PE
61782011-08-15 Paul Eggert <eggert@cs.ucla.edu>
6179
6180 * bidi.c (bidi_initialize): Remove unused local.
6181
9fd8be00
EZ
61822011-08-15 Eli Zaretskii <eliz@gnu.org>
6183
6b02f655
SM
6184 * bidimirror.h:
6185 * biditype.h: Remove file.
6186 * makefile.w32-in ($(BLD)/bidi.$(O)):
6187 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
6188
6189 * dispextern.h: Fix a typo in the comment to bidi_type_t.
6190
6191 * chartab.c: Improve commentary for the uniprop_table API.
6192
32413314
EZ
6193 * bidi.c (bidi_paragraph_init): Support zero value of
6194 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
6195 (bidi_initialize): Use uniprop_table instead of including
6196 biditype.h and bidimirror.h.
32413314 6197
9fd8be00
EZ
6198 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
6199 coordinates of the iterator when restoring from ppos_it.
6200 (Bug#9296)
6201
5cf2b69b
KH
62022011-08-14 Kenichi Handa <handa@m17n.org>
6203
6204 * process.c (create_process): Call setup_process_coding_systems
72ad093b 6205 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 6206
daf17d00
EZ
62072011-08-14 Eli Zaretskii <eliz@gnu.org>
6208
6209 * xdisp.c (move_it_in_display_line_to): Don't invoke
6210 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
6211 ppos_it. Fixes vertical cursor motion when line beginning is
6212 covered by an image. (Bug#9296)
6213
08e3161a
JD
62142011-08-14 Jan Djärv <jan.h.d@swipnet.se>
6215
6216 * nsterm.h (ns_run_ascript): Declare.
6217 (NSAPP_DATA2_RUNASSCRIPT): Define.
6218
6219 * nsfns.m (as_script, as_result, as_status): New static variables.
6220 (ns_run_ascript): New function.
5e617bc2 6221 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
6222 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
6223 the event loop. Get status from as_status (Bug#7276).
6224
6225 * nsterm.m (sendEvent): If event is NSApplicationDefined and
6226 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
6227 the event loop (Bug#7276).
6228
a3720aa2
AS
62292011-08-14 Andreas Schwab <schwab@linux-m68k.org>
6230
6231 * gnutls.c (QCgnutls_bootprop_priority)
6232 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
6233 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
6234 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
6235 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
6236 (QCgnutls_bootprop_verify_hostname_error)
6237 (QCgnutls_bootprop_callbacks_verify): Rename from
6238 Qgnutls_bootprop_..., all uses changed.
6239
6240 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
6241 uses changed.
6242
0a0d27fb
PE
62432011-08-14 Paul Eggert <eggert@cs.ucla.edu>
6244
19d5c50c
PE
6245 * xfaces.c (Qframe_set_background_mode): Now static.
6246 * dispextern.h (Qframe_set_background_mode): Remove decl.
6247
0a0d27fb
PE
6248 * process.c (Fnetwork_interface_info): Declare local only if needed.
6249
377538cb
JD
62502011-08-13 Jan Djärv <jan.h.d@swipnet.se>
6251
6252 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
6253 (Fnetwork_interface_list): Allocate in increments of bytes instead
6254 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
6255 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
6256 sockaddr.
6257 (struct ifflag_def): notrailers is smart on OSX.
6258 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
6259 Get hardware address with getifaddrs if available.
6260
08fff70c
EZ
62612011-08-12 Eli Zaretskii <eliz@gnu.org>
6262
6263 * xdisp.c (iterate_out_of_display_property): xassert that
6264 IT->position is set to within IT->object's boundaries. Break from
6265 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
6266 when IT->position is set up wrongly due to some bug.
6267 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
6268 (push_display_prop): Allow GET_FROM_STRING as IT->method on
6269 entry. Force push_it to save on the stack the current
6270 buffer/string position, to be restored by pop_it. Fix flags in
6271 the iterator structure wrt the object coming from a display
6272 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
6273 properties. (Bug#9284)
6274
7be1c708 62752011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 6276
7be1c708
CY
6277 * fontset.c (fontset_get_font_group): Add proper type checks.
6278 (Bug#9172)
aac0c6e3 6279
7be1c708 62802011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 6281
7be1c708
CY
6282 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
6283 and LC_VERSION_MIN_MACOSX.
6284 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
6285 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 6286
97bb72a6
EZ
62872011-08-08 Eli Zaretskii <eliz@gnu.org>
6288
6289 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
6290 no-display-properties-and-no-overlays under bidi display.
6291 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 6292 properties and overlays.
97bb72a6 6293
d5617611
CY
62942011-08-08 Chong Yidong <cyd@stupidchicken.com>
6295
37e11a63
CY
6296 * editfns.c (Fset_time_zone_rule): Document relationship with the
6297 setenv function.
6298
d5617611
CY
6299 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
6300 the font entity extracted from the cache (Bug#8109).
6301
58872834
CY
63022011-08-07 Chong Yidong <cyd@stupidchicken.com>
6303
6304 * composite.c (autocmp_chars): Don't reset point. That is done by
6305 restore_point_unwind (Bug#5984).
6306
75bfc667
JL
63072011-08-07 Juri Linkov <juri@jurta.org>
6308
6309 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
6310 to show the arg `TIME' instead of `TIMEVAL'.
6311
d1410150
EZ
63122011-08-06 Eli Zaretskii <eliz@gnu.org>
6313
6314 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
6315 display property strides EOL and includes a newline, as in
6316 longlines-mode. (Bug#9254)
75b771e4
EZ
6317 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
6318 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
6319
6320 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
6321 is non-zero, even if the data buffer is NULL. Fixes a crash in
6322 vertical-motion with longlines-mode. (Bug#9254)
6323
35928349
EZ
63242011-08-05 Eli Zaretskii <eliz@gnu.org>
6325
ec7cc85b
EZ
6326 * bidi.c <bidi_cache_total_alloc>: Now static.
6327 (bidi_initialize): Initialize bidi_cache_total_alloc.
6328
8b76d6f8 6329 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
6330 cache. (Bug#9221)
6331
6332 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
6333 amount allocated this far in `bidi_cache_total_alloc'.
6334 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
6335 non-zero, only free the data buffer without restoring the cache
6336 contents. All callers changed.
6337
6338 * dispextern.h (bidi_unshelve_cache): Update prototype.
6339
6340 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
6341 (move_it_in_display_line, move_it_to)
6342 (move_it_vertically_backward, move_it_by_lines): Replace the call
6343 to xfree to an equivalent call to bidi_unshelve_cache.
6344 (move_it_in_display_line_to): Fix logic of returning
412b6358 6345 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 6346
e2e2423b
EZ
63472011-08-05 Eli Zaretskii <eliz@gnu.org>
6348
6349 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
6350 came from a string character with a `cursor' property. (Bug#9229)
6351
ae9e757a
JD
63522011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6353
6354 * Makefile.in (LIB_PTHREAD): New variable.
6355 (LIBES): Add LIB_PTHREAD (Bug#9216).
6356
6357 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
6358 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
6359
213bd7f2
AS
63602011-08-04 Andreas Schwab <schwab@linux-m68k.org>
6361
6b02f655 6362 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 6363
99aaf75f
JD
63642011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6365
6366 * xterm.c (x_find_topmost_parent): New function.
6367 (x_set_frame_alpha): Find topmost parent window with
6368 x_find_topmost_parent and set the property there also (bug#9181).
6369 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
6370
c74e9d86
PE
63712011-08-04 Paul Eggert <eggert@cs.ucla.edu>
6372
6373 * callproc.c (Fcall_process): Avoid vfork clobbering
6374 the local vars buffer, coding_systems, current_dir.
6375
640c8776
SM
63762011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
6377
6378 * keymap.c (Fmake_composed_keymap): Move to subr.el.
6379
f26d0e4c
PE
63802011-08-03 Paul Eggert <eggert@cs.ucla.edu>
6381
8a10d76c
PE
6382 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
6383 so that it is not optimized away.
6384
f26d0e4c
PE
6385 * xdisp.c (compute_display_string_pos): Remove unused local.
6386
55439c61
EZ
63872011-08-02 Eli Zaretskii <eliz@gnu.org>
6388
6389 Fix slow cursor motion and scrolling in large buffers with
6390 selective display, like Org Mode buffers. (Bug#9218)
6391
6392 * dispextern.h (struct bidi_it): New member disp_prop_p.
6393
6394 * xdisp.c: Remove one-slot cache of display string positions.
6395 (compute_display_string_pos): Accept an additional argument
5e617bc2 6396 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
6397 for a display string or property. If found, set DISP_PROP_P
6398 non-zero.
6399
6400 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
6401 DISP_PROP_P, and pass it to compute_display_string_pos.
6402 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
6403 non-zero. All callers of bidi_fetch_char changed.
6404
fb33fa43
SM
64052011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
6406
6407 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
6408
b099e063
DM
64092010-12-03 Don March <don@ohspite.net>
6410
6411 * keymap.c (Fdefine_key): Fix non-prefix key error message when
6412 last character M-[char] is translated to ESC [char] (bug#7541).
6413
5cc7f7af
KH
64142011-08-02 Kenichi Handa <handa@m17n.org>
6415
d0fffa3f 6416 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
6417
6418 * chartab.c (uniprop_table): Make it non-static.
6419
525d5e6e
EZ
64202011-08-01 Eli Zaretskii <eliz@gnu.org>
6421
6422 * xdisp.c (forward_to_next_line_start): Accept additional argument
6423 BIDI_IT_PREV, and store into it the state of the bidi iterator had
6424 on the newline.
6425 (reseat_at_next_visible_line_start): Use the bidi iterator state
6426 returned by forward_to_next_line_start to restore the state of
6427 it->bidi_it after backing up to previous newline. (Bug#9212)
6428
31011111
AS
64292011-07-30 Andreas Schwab <schwab@linux-m68k.org>
6430
6431 * regex.c (re_comp): Protoize.
6432 (re_exec): Fix return type.
6433 (regexec): Fix type of `ret'. (Bug#9203)
6434
476371c4
PE
64352011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6436
e5d76069
PE
6437 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
6438 This is needed if max-image-size is a floating-point number.
6439
9a79b20c
AS
64402011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6441
6442 * print.c (print_object): Print empty symbol as ##.
6443
6444 * lread.c (read1): Read ## as empty symbol.
6445
d8c2fa78
AA
64462011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6447
6448 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
6449 setting frame foreground color (Bug#9175).
6450 (x_set_background_color): Likewise.
6451
ffe57a7a
AA
6452 * nsmenu.m (-setText): Size tooltip dimensions precisely to
6453 contents (Bug#9176).
6454 (EmacsTooltip -init): Remove bezels and add shadows to
6455 tooltip windows.
6456
bf3492a5
AA
6457 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
6458 or scroll bar (Bug#8470).
6459
d55e9c53
AA
6460 * nsfont.m (nsfont_open): Remove assignment to voffset and
6461 unnecessary vars hshink, expand, hd, full_height, min_height.
6462 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
6463
6464 * nsterm.h (nsfont_info): Remove voffset field.
6465
d8c2fa78 64662011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
6467
6468 Implement strike-through and overline on NextStep (Bug#8863).
6469
6470 * nsfont.m (nsfont_open): Use underline position provided by font,
6471 instead of hard-coded value of 2.
6472 (nsfont_draw): Call ns_draw_text_decoration instead.
6473
6474 * nsterm.h: Add declaration for ns_draw_text_decoration.
6475
6476 * nsterm.m (ns_draw_text_decoration): New function for drawing
6477 underline, overline, and strike-through.
6478 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
6479 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 6480 accommodate underlining, etc.
4843aac3 6481
4cc60b9b
EZ
64822011-07-28 Eli Zaretskii <eliz@gnu.org>
6483
bc7ece87
EZ
6484 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
6485 default.
4cc60b9b 6486
476371c4
PE
64872011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6488
66606eea
PE
6489 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
6490 Without this fix, if a signal arrives just after memory fills up,
6491 'malloc' might be invoked reentrantly.
6492
476371c4
PE
6493 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
6494 In other words, assume that every image size is allowed, on non-X
6495 hosts. This assumption is probably wrong, but it lets Emacs compile.
6496
f3fcc40d
AS
64972011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6498
6499 * regex.c (re_iswctype): Convert return values to boolean.
6500
350c992f
EZ
65012011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
6502
6503 * xdisp.c (compute_display_string_pos): Don't use cached display
6504 string position if the buffer had its restriction changed.
6505 (Bug#9184)
6506
5266b4bb
PE
65072011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6508
6509 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6510
2573a837 65112011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 6512
41f55ccd 6513 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 6514
39e378da
PE
6515 * bidi.c: Integer size and overflow fixes.
6516 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
6517 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
6518 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6519 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
6520 (bidi_find_other_level_edge):
6521 Use ptrdiff_t instead of EMACS_INT where either will do.
6522 This works better on 32-bit hosts configured --with-wide-int.
6523 (bidi_cache_ensure_space): Check for size-calculation overflow.
6524 Use % rather than repeated addition, for better worst-case speed.
6525 Don't set bidi_cache_size until after xrealloc returns, because it
6526 might not return.
6527 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
6528 (bidi_cache_ensure_space): Also check that the bidi cache size
6529 does not exceed that of the largest Lisp string or buffer. See Eli
6530 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 6531
5e927815
PE
6532 * alloc.c (__malloc_size_t): Remove.
6533 All uses replaced by size_t. See Andreas Schwab's note
6534 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
6535
ca4aa935
PE
6536 * image.c: Improve checking for integer overflow.
6537 (check_image_size): Assume that f is nonnull, since
6538 it is always nonnull in practice. This is one less thing to
6539 worry about when checking for integer overflow later.
6540 (x_check_image_size): New function, which checks for integer
6541 overflow issues inside X.
6542 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
6543 This removes the need for a memory_full check.
6544 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
6545 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
6546 (xbm_read_bitmap_data): Change locals back to 'int', since
6547 their values must fit in 'int'.
6548 (xpm_load_image, png_load, tiff_load):
6549 Invoke x_create_x_image_and_pixmap earlier,
6550 to avoid much needless work if the image is too large.
6551 (tiff_load): Treat overly large images as if
6552 x_create_x_image_and_pixmap failed, not as malloc failures.
6553 (gs_load): Use x_check_image_size.
6554
5f8f9cc2
PE
6555 * gtkutil.c: Omit integer casts.
6556 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
6557 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
6558
5adf60bc
PE
6559 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
6560
c8907a93
PE
6561 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
6562 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
6563 would wrongly return t on a 64-bit host.
6564
e3c25c68
PE
6565 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
6566 The plain *_OVERFLOW macros run afoul of GCC bug 49705
6567 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
6568 and therefore cause GCC to emit a bogus diagnostic in some cases.
6569
3f791afe
PE
6570 * image.c: Integer signedness and overflow and related fixes.
6571 This is not an exhaustive set of fixes, but it's time to
6572 record what I've got.
6573 (lookup_pixel_color, check_image_size): Remove redundant decls.
6574 (check_image_size): Don't assume that arbitrary EMACS_INT values
6575 fit in 'int', or that arbitrary 'double' values fit in 'int'.
6576 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
6577 (tiff_load, imagemagick_load_image):
6578 Check for overflow in size calculations.
6579 (x_create_x_image_and_pixmap): Remove unnecessary test for
6580 xmalloc returning NULL; that can't happen.
6581 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
6582 (xpm_color_bucket): Use better integer hashing function.
6583 (xpm_cache_color): Don't possibly over-allocate memory.
6584 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
6585 (gif_memory_source):
6586 Use ptrdiff_t, not int or size_t, to record sizes.
6587 (png_load): Don't assume values greater than 2**31 fit in 'int'.
6588 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
6589 either works, as we prefer signed integers.
6590 (tiff_read_from_memory, tiff_write_from_memory):
6591 Return tsize_t, not size_t, since that's what the TIFF API wants.
6592 (tiff_read_from_memory): Don't fail simply because the read would
6593 go past EOF; instead, return a short read.
6594 (tiff_load): Omit no-longer-needed casts.
6595 (Fimagemagick_types): Don't assume size fits into 'int'.
6596
3cc5a532
PE
6597 Improve hashing quality when configured --with-wide-int.
6598 * fns.c (hash_string): New function, taken from sxhash_string.
6599 Do not discard information about ASCII character case; this
6600 discarding is no longer needed.
6601 (sxhash-string): Use it. Change sig to match it. Caller changed.
6602 * lisp.h: Declare it.
6603 * lread.c (hash_string): Remove, since we now use fns.c's version.
6604 The fns.c version returns a wider integer if --with-wide-int is
6605 specified, so this should help the quality of the hashing a bit.
6606
b312a492
PE
6607 * emacs.c: Integer overflow minor fix.
6608 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
6609 Define only if GNU_LINUX.
6610 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
6611
dfd153ae
PE
6612 * dispnew.c: Integer signedness and overflow fixes.
6613 Remove unnecessary forward decls, that were a maintenance hassle.
6614 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
6615 All uses changed.
6616 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
6617 (scrolling_window): Use ptrdiff_t, not int, for byte count.
6618 (prepare_desired_row, line_draw_cost):
6619 Use int, not unsigned, where either works.
6620 (save_current_matrix, restore_current_matrix):
6621 Use ptrdiff_t, not size_t, where either works.
6622 (init_display): Check for overflow more accurately, and without
6623 relying on undefined behavior.
6624
a81d11a3
PE
6625 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
6626 Remove, replacing with the new symbols in lisp.h. All uses changed.
6627 * fileio.c (make_temp_name):
6628 * filelock.c (lock_file_1, lock_file):
6629 * xdisp.c (message_dolog):
6630 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
6631 Use pMd etc. instead.
6632 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
6633 replacing the pWIDE etc. symbols removed from editfns.c.
6634
3300e6fd
PE
6635 * keyboard.h (num_input_events): Now uintmax_t.
6636 This is (very slightly) less likely to mess up due to wraparound.
6637 All uses changed.
6638
fd05c7e9
PE
6639 * buffer.c: Integer signedness fixes.
6640 (alloc_buffer_text, enlarge_buffer_text):
6641 Use ptrdiff_t rather than size_t when either will do, as we prefer
6642 signed integers.
6643
903fe15d
PE
6644 * alloc.c: Integer signedness and overflow fixes.
6645 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
6646 (__malloc_size_t): Default to size_t, not to int.
6647 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
6648 (Fgarbage_collect, mark_object_loop_halt, mark_object):
6649 Prefer ptrdiff_t to size_t when either would do, as we prefer
6650 signed integers.
6651 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
6652 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
6653 Now const. Initialize with values that are in range even if char
6654 is signed.
6655 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
6656 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
6657 These functions do the right thing with sizes > 2**32.
6658 (check_depth): Now ptrdiff_t, not int.
6659 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
6660 Adjust to new way of storing sizes. Check for size overflow bugs
6661 in rest of code.
6662 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
6663 slightly wrong anyway, as it missed one instance of
6664 XMALLOC_OVERRUN_CHECK_OVERHEAD.
6665 (refill_memory_reserve): Omit needless cast to size_t.
6666 (mark_object_loop_halt): Mark as externally visible.
6667
ac82cc6a
PE
6668 * xselect.c: Integer signedness and overflow fixes.
6669 (Fx_register_dnd_atom, x_handle_dnd_message):
6670 Use ptrdiff_t, not size_t, since we prefer signed.
6671 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
6672 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
6673 x_dnd_atoms_size and x_dnd_atoms_length.
6674
c2d1e36d
PE
6675 * doprnt.c: Prefer signed to unsigned when either works.
6676 * eval.c (verror):
6677 * doprnt.c (doprnt):
6678 * lisp.h (doprnt):
6679 * xdisp.c (vmessage):
6680 Use ptrdiff_t, not size_t, when using or implementing doprnt,
6681 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
6682 prefer signed arithmetic to avoid comparison confusion.
6683 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
6684 but is a bit tricky.
6685
0e926e56
PE
6686 Assume freestanding C89 headers, string.h, stdlib.h.
6687 * data.c, doprnt.c, floatfns.c, print.c:
6688 Include float.h unconditionally.
6689 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
6690 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
6691 * regex.c: Likewise for stddef.h, string.h.
6692 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
6693 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
6694 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
6695 (STDC_HEADERS): Remove obsolete defines.
6696 * sysdep.c: Include limits.h unconditionally.
6697
9cfdb3ec
PE
6698 Assume support for memcmp, memcpy, memmove, memset.
6699 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
6700 * regex.c (memcmp, memcpy):
6701 Remove; we assume C89 now.
6702
6703 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
6704 (__malloc_safe_bcopy): Remove; no longer needed.
6705
cf950e6b 6706 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
6707 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
6708 well either way, and we prefer signed to unsigned.
6709
dbf38e02
LMI
67102011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
6711
6712 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
6713 closes the connection while we're reading (bug#9182).
6714
d6f0886c 67152011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 6716
d6f0886c
JD
6717 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
6718 are specified (Bug#9168).
24e0f6b1 6719
2eb1f9e6
PE
67202011-07-25 Paul Eggert <eggert@cs.ucla.edu>
6721
6722 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
6723 Found by GCC static checking and --with-wide-int on a 32-bit host.
6724
22381272 67252011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
6726
6727 * xdisp.c (compute_display_string_pos): Fix logic of caching
6728 previous display string position. Initialize cached_prev_pos to
6729 -1. Fixes slow-down at the beginning of a buffer.
6730
f25e39b4
EZ
67312011-07-24 Eli Zaretskii <eliz@gnu.org>
6732
6733 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
6734 for attrs[LFACE_FONTSET_INDEX].
6735
04c4b52e
PE
67362011-07-23 Paul Eggert <eggert@cs.ucla.edu>
6737
6738 * xml.c (parse_region): Remove unused local
6739 that was recently introduced.
6740
c1734fbd
EZ
67412011-07-23 Eli Zaretskii <eliz@gnu.org>
6742
be18c5a5
EZ
6743 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
6744 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
6745
c1734fbd
EZ
6746 * xdisp.c (move_it_in_display_line_to): Record the best matching
6747 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
6748 exit if none of the characters scanned was an exact match.
6749 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
6750 when exact match is impossible due to invisible text, and the
6751 lines are truncated.
6752
a258d627
JD
67532011-07-23 Jan Djärv <jan.h.d@swipnet.se>
6754
6755 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
6756 for OSX >= 10.7.
6757
b6d5a689
EZ
67582011-07-22 Eli Zaretskii <eliz@gnu.org>
6759
0f74f785
EZ
6760 Fix a significant slow-down of cursor motion with C-n, C-p,
6761 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
6762 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 6763 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
6764 (next_element_from_buffer): Call compute_stop_pos_backwards to
6765 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
6766 base_level_stop.
6767 (reseat): Don't look for prev_stop, as that could mean a very long
6768 run.
6769 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
6770 <cached_disp_overlay_modiff>: Cache for last found display string
6771 position.
551918c1 6772 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
6773 about the same buffer in the same area of character positions, and
6774 the buffer wasn't changed since the time the display string
6775 position was cached.
551918c1 6776
b2d0c91a
EZ
67772011-07-22 Eli Zaretskii <eliz@gnu.org>
6778
6779 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
6780 is an integer, which is important for empty lines. (Bug#9149)
6781
043604ee
CY
67822011-07-22 Chong Yidong <cyd@stupidchicken.com>
6783
6784 * frame.c (Fmodify_frame_parameters): In tty case, update the
6785 default face if necessary (Bug#4238).
6786
da4adb04
CY
67872011-07-21 Chong Yidong <cyd@stupidchicken.com>
6788
6789 * editfns.c (Fstring_to_char): No need to explain what a character
6790 is in the docstring (Bug#6576).
6791
9abd0532
LMI
67922011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6793
6794 * xml.c (parse_region): Make sure we always return a tree.
6795
36881d16
HK
67962011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
6797
6798 * xml.c (parse_region): If a document contains only comments,
6799 return that, too.
6800
1e98674d
LMI
68012011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6802
6803 * xml.c (make_dom): Return comments, too.
6804
590bd467
PE
68052011-07-19 Paul Eggert <eggert@cs.ucla.edu>
6806
6807 Port to OpenBSD.
6808 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
6809 and the surrounding thread.
6810 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
6811 rather than fgets, and retry after EINTR. Otherwise, 'emacs
6812 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
6813 timer goes off.
6814 * s/openbsd.h (BROKEN_SIGIO): Define.
6815 * unexelf.c (unexec) [__OpenBSD__]:
6816 Don't update the .mdebug section of the Alpha COFF symbol table.
6817
f41628b2
LMI
68182011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6819
6820 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
6821 (bug#8460).
6822
b59b67c5
PE
68232011-07-18 Paul Eggert <eggert@cs.ucla.edu>
6824
15e3a074
PE
6825 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
6826 This fixes some race conditions on the permissions of any newly
6827 created file.
6828
41bed37d
PE
6829 * alloc.c (valid_pointer_p): Use pipe, not open.
6830 This fixes some permissions issues when debugging.
6831
b59b67c5
PE
6832 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
6833 If fchown fails to set both uid and gid, try to set just gid,
6834 as that is sometimes allowed. Adjust the file's mode to eliminate
6835 setuid or setgid bits that are inappropriate if fchown fails.
6836
925a6be7
SM
68372011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
6838
6839 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
6840 to compare Lisp_Objects.
6841 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
6842 global_gnutls_log_level, don't mistake it for a Lisp_Object.
6843 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
6844
52968808
AS
68452011-07-17 Andreas Schwab <schwab@linux-m68k.org>
6846
0a6a104b
AS
6847 * lread.c (read_integer): Unread even EOF character.
6848 (read1): Likewise. Properly record start position of symbol.
6849
52968808
AS
6850 * lread.c (read1): Read `#:' as empty uninterned symbol if no
6851 symbol character follows.
6852
9e381cdd
PE
68532011-07-17 Paul Eggert <eggert@cs.ucla.edu>
6854
6855 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
6856 This works around a problem with the previous change to Fcopy_file.
6857 Recent glibc declares fchown with __attribute__((warn_unused_result)),
6858 and without this change, GCC might complain about discarding
6859 fchown's return value.
6860
b5641435
JB
68612011-07-16 Juanma Barranquero <lekktu@gmail.com>
6862
6863 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
6864
a8031457
PE
68652011-07-16 Paul Eggert <eggert@cs.ucla.edu>
6866
6867 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
6868
dd889327
LMI
68692011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
6870
750c33f7
LMI
6871 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
6872 it's used from the C level.
6873
dd889327
LMI
6874 * process.c: Use the same condition for POLL_FOR_INPUT in both
6875 keyboard.c and process.c (bug#1858).
6876
87e86684
LM
68772011-07-09 Lawrence Mitchell <wence@gmx.li>
6878
6879 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
6880 (Fgnutls_boot): Use it.
6881
64348f40
AS
68822011-07-15 Andreas Schwab <schwab@linux-m68k.org>
6883
6884 * doc.c (Fsubstitute_command_keys): Revert last change.
6885
1d698799
LMI
68862011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
6887
f863868c
LMI
6888 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
6889 quotes the next character, and doesn't affect other longer
6890 sequences (bug#8935).
6891
1d698799
LMI
6892 * lread.c (syms_of_lread): Clarify that is isn't only
6893 `eval-buffer' and `eval-defun' that's affected by
6894 `lexical-binding' (bug#8460).
6895
aa4b6df6
EZ
68962011-07-15 Eli Zaretskii <eliz@gnu.org>
6897
6898 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 6899 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 6900
5d856da6
PE
69012011-07-14 Paul Eggert <eggert@cs.ucla.edu>
6902
ad6042bb
PE
6903 Fix minor problems found by static checking.
6904 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
6905 (elsz): Now a signed constant, not a size_t var. We prefer signed
6906 types to unsigned, to avoid integer comparison confusion. Without
6907 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
6908 "cannot optimize loop, the loop counter may overflow", a symptom
6909 of the confusion.
f00bbb22 6910 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
6911 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
6912
6468f31c
LMI
69132011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6914
49080b10
LMI
6915 * search.c (Fre_search_backward): Mention `case-fold-search' in
6916 all the re_search_* functions (bug#8138).
6917
6468f31c
LMI
6918 * keyboard.c (Fopen_dribble_file): Document when the file is
6919 closed (bug#8056).
6920
c965adc5
EZ
69212011-07-14 Eli Zaretskii <eliz@gnu.org>
6922
df9733bf
EZ
6923 * bidi.c (bidi_dump_cached_states): Fix format of displaying
6924 bidi_cache_idx.
6925
0bb23927
EZ
6926 Support bidi reordering of display and overlay strings.
6927 * xdisp.c (compute_display_string_pos)
6928 (compute_display_string_end): Accept additional argument STRING.
6929 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
6930 (reseat_to_string): Initialize bidi_it->string.s and
6931 bidi_it->string.schars.
6932 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
6933 NULL (avoids a crash in bidi_paragraph_init).
6934 Initialize itb.string.lstring.
0bb23927
EZ
6935 (init_iterator): Call bidi_init_it only of a valid
6936 buffer position was specified. Initialize paragraph_embedding to
6937 L2R.
6938 (reseat_to_string): Initialize the bidi iterator.
6939 (display_string): If we need to ignore text properties of
6940 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
6941 original value of -1 will not work with bidi.)
6942 (compute_display_string_pos): First arg is now struct
6943 `text_pos *'; all callers changed. Support display properties on
6944 Lisp strings.
6945 (compute_display_string_end): Support display properties on Lisp
6946 strings.
6947 (init_iterator, reseat_1, reseat_to_string): Initialize the
6948 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
6949 when iterating on a string not from display properties).
640c8776
SM
6950 (compute_display_string_pos, compute_display_string_end):
6951 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
6952 arrow keys.
6953 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
6954 base_level_stop; instead, set base_level_stop to BEGV.
6955 Fixes crashes in vertical-motion.
0bb23927
EZ
6956 (next_element_from_buffer): Improve commentary for when
6957 the iterator is before prev_stop.
6958 (init_iterator): Initialize bidi_p from the default value of
6959 bidi-display-reordering, not from buffer-local value. Use the
6960 buffer-local value only if initializing for buffer iteration.
6961 (handle_invisible_prop): Support invisible properties on strings
6962 that are being bidi-reordered.
6963 (set_iterator_to_next): Support bidi reordering of C strings and
6964 Lisp strings.
6965 (next_element_from_string): Support bidi reordering of Lisp
6966 strings.
6967 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
6968 (display_string): Support display of R2L glyph rows.
6969 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
6970 (init_iterator): Don't initialize it->bidi_p for strings
6971 here.
6972 (reseat_to_string): Initialize it->bidi_p for strings here.
6973 (next_element_from_string, next_element_from_c_string)
6974 (next_element_from_buffer): Add xassert's for correspondence
6975 between IT's object being iterated and it->bidi_it.string
6976 structure.
6977 (face_before_or_after_it_pos): Support bidi iteration.
6978 (next_element_from_c_string): Handle the case of the first string
6979 character that is not the first one in the visual order.
6980 (get_visually_first_element): New function, refactored from common
6981 parts of next_element_from_buffer, next_element_from_string, and
6982 next_element_from_c_string.
6983 (tool_bar_lines_needed, redisplay_tool_bar)
6984 (display_menu_bar): Force left-to-right direction. Add a FIXME
6985 comment for making that be controlled by a user option.
6986 (push_it, pop_it): Save and restore the state of the
6987 bidi iterator. Save and restore the bidi_p flag.
6988 (pop_it): Iterate out of display property for string iteration as
6989 well.
6990 (iterate_out_of_display_property): Support iteration over strings.
6991 (handle_single_display_spec): Set up it->bidi_it for iteration
6992 over a display string, and call bidi_init_it.
6993 (handle_single_display_spec, next_overlay_string)
6994 (get_overlay_strings_1, push_display_prop): Set up the bidi
6995 iterator for displaying display or overlay strings.
6996 (forward_to_next_line_start): Don't use the shortcut if
6997 bidi-iterating.
6998 (back_to_previous_visible_line_start): If handle_display_prop
6999 pushed the iterator stack, restore the internal state of the bidi
7000 iterator by calling bidi_pop_it same number of times.
7001 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
7002 and we are bidi-iterating, don't decrement the iterator position;
7003 instead, set the first_elt flag in the bidi iterator, to produce
7004 the same effect.
7005 (reseat_1): Remove redundant setting of string_from_display_prop_p.
7006 (push_display_prop): xassert that we are iterating a buffer.
7007 (push_it, pop_it): Save and restore paragraph_embedding member.
7008 (handle_single_display_spec, next_overlay_string)
7009 (get_overlay_strings_1, reseat_1, reseat_to_string)
7010 (push_display_prop): Set up the `unibyte' member of bidi_it.string
7011 correctly. Don't assume unibyte strings are not bidi-reordered.
7012 (compute_display_string_pos)
7013 (compute_display_string_end): Fix handling the case of C string.
7014 (push_it, pop_it): Save and restore from_disp_prop_p.
7015 (handle_single_display_spec, push_display_prop): Set the
7016 from_disp_prop_p flag.
7017 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
7018 (pop_it): Call iterate_out_of_display_property only if we are
7019 popping after iteration over a string that came from a display
7020 property. Fix a typo in popping stretch info. Add an assertion
7021 for verifying that the iterator position is in sync with the bidi
7022 iterator.
7023 (handle_single_display_spec, get_overlay_strings_1)
7024 (push_display_prop): Fix initialization of paragraph direction for
7025 string when that of the parent object is not yet determined.
7026 (reseat_1): Call bidi_init_it to resync the bidi
7027 iterator with IT's position. (Bug#7616)
7028 (find_row_edges): If ROW->start.pos gives position
7029 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
7030 (handle_stop, back_to_previous_visible_line_start, reseat_1):
7031 Reset the from_disp_prop_p flag.
7032 (SAVE_IT, RESTORE_IT): New macros.
7033 (pos_visible_p, face_before_or_after_it_pos)
7034 (back_to_previous_visible_line_start)
7035 (move_it_in_display_line_to, move_it_in_display_line)
7036 (move_it_to, move_it_vertically_backward, move_it_by_lines)
7037 (try_scrolling, redisplay_window, display_line): Use them when
7038 saving a temporary copy of the iterator and restoring it back.
7039 (back_to_previous_visible_line_start, reseat_1)
7040 (init_iterator): Empty the bidi cache "stack".
7041 (move_it_in_display_line_to): If iterator ended up at
7042 EOL, but we never saw any buffer positions smaller than
7043 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
7044 motion in bidi-reordered lines.
7045 (move_it_in_display_line_to): Record prev_method and prev_pos
7046 immediately before the call to set_iterator_to_next. Fixes cursor
7047 motion in bidi-reordered lines with stretch glyphs and strings
7048 displayed in margins. (Bug#8133) (Bug#8867)
7049 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
7050 TO_CHARPOS.
640c8776
SM
7051 (pos_visible_p): Support positions in bidi-reordered lines.
7052 Save and restore bidi cache.
0bb23927
EZ
7053
7054 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
7055 (bidi_paragraph_info): Delete unused struct.
7056 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
7057 (bidi_cache_start): New variable.
7058 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
7059 to zero.
7060 (bidi_cache_fetch_state, bidi_cache_search)
7061 (bidi_cache_find_level_change, bidi_cache_iterator_state)
7062 (bidi_cache_find, bidi_peek_at_next_level)
7063 (bidi_level_of_next_char, bidi_find_other_level_edge)
7064 (bidi_move_to_visually_next): Compare cache index with
7065 bidi_cache_start rather than with zero.
7066 (bidi_fetch_char): Accept new argument STRING; all callers
7067 changed. Support iteration over a string. Support strings with
7068 display properties. Support unibyte strings. Fix the type of
7069 `len' according to what STRING_CHAR_AND_LENGTH expects.
7070 (bidi_paragraph_init, bidi_resolve_explicit_1)
7071 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
7072 (bidi_level_of_next_char, bidi_move_to_visually_next):
7073 Support iteration over a string.
0bb23927
EZ
7074 (bidi_set_sor_type, bidi_resolve_explicit_1)
7075 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
7076 can now be zero (for strings); special values 0 and -1 were
7077 changed to -1 and -2, respectively.
7078 (bidi_char_at_pos): New function.
7079 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
7080 Call it instead of FETCH_MULTIBYTE_CHAR.
7081 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
7082 initialized to valid values.
7083 (bidi_init_it): Don't initialize charpos and bytepos with invalid
7084 values.
7085 (bidi_level_of_next_char): Allow the sentinel "position" to pass
7086 the test for valid cached positions. Fix the logic for looking up
7087 the sentinel state in the cache. GCPRO the Lisp string we are
7088 iterating.
7089 (bidi_push_it, bidi_pop_it): New functions.
7090 (bidi_initialize): Initialize the bidi cache start stack pointer.
7091 (bidi_cache_ensure_space): New function, refactored from part of
7092 bidi_cache_iterator_state. Don't assume the required size is just
7093 one BIDI_CACHE_CHUNK away.
7094 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
7095 (bidi_count_bytes, bidi_char_at_pos): New functions.
7096 (bidi_cache_search): Don't assume bidi_cache_last_idx is
7097 always valid if bidi_cache_idx is valid.
7098 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
7099 is valid if it's going to be used.
7100 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
7101 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
7102 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7103 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
7104 (bidi_find_other_level_edge, bidi_cache_start_stack):
7105 All variables related to cache indices are now EMACS_INT.
c965adc5 7106
0bb23927
EZ
7107 * dispextern.h (struct bidi_string_data): New structure.
7108 (struct bidi_it): New member `string'. Make flag members be 1-bit
7109 fields, and put them last in the struct.
640c8776
SM
7110 (compute_display_string_pos, compute_display_string_end):
7111 Update prototypes.
0bb23927
EZ
7112 (bidi_push_it, bidi_pop_it): Add prototypes.
7113 (struct iterator_stack_entry): New members bidi_p,
7114 paragraph_embedding, and from_disp_prop_p.
7115 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
7116 (bidi_shelve_cache, bidi_unshelve_cache):
7117 Declare prototypes.
0bb23927
EZ
7118
7119 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
7120 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
7121 and vector-like objects.
7122
7123 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
7124 cache around display iteration.
7125
7126 * window.c (Fwindow_end, window_scroll_pixel_based)
7127 (displayed_window_lines, Frecenter): Save and restore the bidi
7128 cache around display iteration.
7129
3bbd2265
LMI
71302011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7131
7132 * editfns.c (Fdelete_region): Clarify the use of the named
7133 parameters (bug#6788).
7134
adc47434
MR
71352011-07-14 Martin Rudalics <rudalics@gmx.at>
7136
7137 * indent.c (Fvertical_motion): Set and restore w->pointm when
7138 saving and restoring the window's buffer (Bug#9006).
7139
837c31f8
LMI
71402011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
7141
7142 * editfns.c (Fstring_to_char): Clarify just what is returned
7143 (bug#6576). Text by Eli Zaretskii.
7144
ac389d0c
JB
71452011-07-13 Juanma Barranquero <lekktu@gmail.com>
7146
7147 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
7148
0be0ce47
EZ
71492011-07-13 Eli Zaretskii <eliz@gnu.org>
7150
7151 * buffer.c (mmap_find): Fix a typo.
7152
cd18e7e3
JB
71532011-07-13 Johan Bockgård <bojohan@gnu.org>
7154
7155 Fix execution of x selection hooks.
7156 * xselect.c (Qx_lost_selection_functions)
7157 (Qx_sent_selection_functions): New vars.
7158 (syms_of_xselect): DEFSYM them.
7159 (x_handle_selection_request): Pass Qx_sent_selection_functions
7160 rather than Vx_sent_selection_functions to Frun_hook_with_args.
7161 (x_handle_selection_clear,x_clear_frame_selections):
7162 Pass Qx_lost_selection_functions rather than
7163 Vx_lost_selection_functions to Frun_hook_with_args.
7164
47ea7f44
PE
71652011-07-13 Paul Eggert <eggert@cs.ucla.edu>
7166
ac389d0c 7167 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
7168 The old code sometimes used this field without initializing it.
7169
47ea7f44
PE
7170 * alloc.c (gc_sweep): Don't read past end of array.
7171 In theory, the old code could also have corrupted Emacs internals,
7172 though it'd be very unlikely.
7173
bc985c87
AS
71742011-07-12 Andreas Schwab <schwab@linux-m68k.org>
7175
7176 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 7177 argument. (Bug#4026)
bc985c87 7178
0cf34688
LMI
71792011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
7180
b3dadd76
LMI
7181 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
7182 key" (bug#4257).
7183
0cf34688
LMI
7184 * window.c (Fset_window_start): Doc fix (bug#4199).
7185 (Fset_window_hscroll): Ditto.
7186
270768cd
PE
71872011-07-12 Paul Eggert <eggert@cs.ucla.edu>
7188
077e3dda 7189 Fix minor new problems caught by GCC 4.6.1.
270768cd 7190 * term.c (init_tty): Remove unused local.
490011a6 7191 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 7192 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 7193 not used otherwise.
270768cd 7194
b1f58454
CY
71952011-07-12 Chong Yidong <cyd@stupidchicken.com>
7196
7197 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
7198
22b9578d
LMI
71992011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7200
6e70ab07
LMI
7201 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
7202 are the mini-buffer and the echo area (bug#3320).
7203
22b9578d
LMI
7204 * term.c (init_tty): Remove support for supdup, c10 and perq
7205 terminals, which are no longer supported (bug#1482).
7206
8974cc9f
JB
72072011-07-10 Johan Bockgård <bojohan@gnu.org>
7208
7209 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
7210
a560d974
JD
72112011-07-10 Jan Djärv <jan.h.d@swipnet.se>
7212
7213 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
7214 for non-popups (Bug#3642).
7215
1dae0f0a
AS
72162011-07-10 Andreas Schwab <schwab@linux-m68k.org>
7217
268c2c36 7218 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 7219 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
7220 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
7221 * cm.c (losecursor): Likewise.
1dae0f0a
AS
7222 * data.c (fmod): Likewise.
7223 * dispnew.c (swap_glyphs_in_rows): Likewise.
7224 * emacs.c (memory_warning_signal): Likewise.
7225 * floatfns.c (float_error): Likewise.
7226 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
7227 (otf_open, font_otf_capability, generate_otf_features)
7228 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
7229 Likewise.
7230 * image.c (pbm_read_file): Likewise.
7231 * indent.c (string_display_width): Likewise.
7232 * intervals.c (check_for_interval, search_for_interval)
7233 (inc_interval_count, count_intervals, root_interval)
7234 (adjust_intervals_for_insertion, make_new_interval): Likewise.
7235 * lread.c (defalias): Likewise.
268c2c36 7236 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
7237 * regex.c (set_image_of_range_1, set_image_of_range)
7238 (regex_grow_registers): Likewise.
7239 * sysdep.c (strerror): Likewise.
7240 * termcap.c (valid_filename_p, tprint, main): Likewise.
7241 * tparam.c (main): Likewise.
7242 * unexhp9k800.c (run_time_remap, save_data_space)
7243 (update_file_ptrs, read_header, write_header, calculate_checksum)
7244 (copy_file, copy_rest, display_header): Likewise.
7245 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
7246 Likewise.
7247 * xdisp.c (check_it): Likewise.
7248 * xfaces.c (register_color, unregister_color, unregister_colors):
7249 Likewise.
7250 * xfns.c (print_fontset_result): Likewise.
7251 * xrdb.c (member, fatal, main): Likewise.
7252
99033785
PE
72532011-07-10 Paul Eggert <eggert@cs.ucla.edu>
7254
7255 Fix minor problems found by static checking (Bug#9031).
7256 * chartab.c (char_table_set_range, map_sub_char_table):
7257 Remove unused locals.
7258 (uniprop_table): Now static.
7259 * composite.c (_work_char): Remove unused static var.
7260
9cb2ac56
JB
72612011-07-09 Juanma Barranquero <lekktu@gmail.com>
7262
7263 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
7264
f25661f0
JD
72652011-07-09 Jan Djärv <jan.h.d@swipnet.se>
7266
7267 * gtkutil.c (qttip_cb): Remove code without function.
7268
8278c4fe
EZ
72692011-07-09 Eli Zaretskii <eliz@gnu.org>
7270
7271 * w32.c (pthread_sigmask): New stub.
7272
1692ae2d 72732011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 7274
8a6ebd58 7275 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
7276 sigprocmask is portable only for single-threaded applications, and
7277 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
7278 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
7279 (LIBES): Use it.
7280 * callproc.c (Fcall_process):
7281 * process.c (create_process):
7282 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
7283 Use pthread_sigmask, not sigprocmask.
123403e4 7284
1b854618
JD
72852011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7286
7287 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
7288 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
7289 wrong (Bug#8591).
7290
3fe4b549
JD
72912011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7292
0ce7e563
JD
7293 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
7294 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
7295 (xg_hide_tooltip): Fix comment.
7296
3fe4b549
JD
7297 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
7298 in registerServicesMenuSendTypes.
7299 (validRequestorForSendType): Don't check ns_return_types.
7300
7301 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
7302 ns_return_type.
7303
5df75e47
JR
73042011-07-08 Jason Rumney <jasonr@gnu.org>
7305
22610910
JR
7306 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
7307 SH_SHOW for hidden windows (Bug#5482).
7308
5df75e47
JR
7309 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
7310 frame struct members of non-existent frames (Bug#6284).
7311
699c10bd
JD
73122011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7313
4393663b
JD
7314 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
7315 variable firstTime not needed on OSX >= 10.6.
7316 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
7317 >= 10.5. Use setKnobProportion, setDoubleValue.
7318
7319 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
7320 (MAC_OS_X_VERSION_10_5): Define if not defined.
7321 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
7322 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
7323 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
7324
7325 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
7326 cString and lossyCString on OSX >= 10.4
7327
58179cce 7328 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
7329 sizeToFit on OSX >= 10.2.
7330
7331 * nsimage.m (allocInitFromFile): Don't use deprecated method
7332 bestRepresentationForDevice on OSX >= 10.6.
7333
7334 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
7335 to avoid warning.
7336
7337 * emacs.c: Declare unexec_init_emacs_zone.
7338
a63e0781
JD
7339 * nsgui.h: Fix compiler warning about gnulib redefining verify.
7340
699c10bd
JD
7341 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
7342
7343 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
7344 on svcsMenu (Bug#8842).
7345
7346 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
7347 ns_return_types.
7348 (Fns_list_services): Just return Qnil on 10.6, code not working there.
7349
7350 * nsterm.m (QUTF8_STRING): Declare.
7351 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
7352 (validRequestorForSendType): Return type is (id).
7353 Change indexOfObjectIdenticalTo to indexOfObject.
7354 Check if we have local selection before returning self (Bug#8842).
7355 (writeSelectionToPasteboard): Put local selection into paste board
7356 if we have a local selection (Bug#8842).
7357 (syms_of_nsterm): DEFSYM QUTF8_STRING.
7358
7359 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
7360 (ns_get_local_selection): Declare.
7361
54e10184
LMI
73622011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
7363
9888ff71
LMI
7364 * keymap.c (describe_map_tree): Don't insert a double newline at
7365 the end of the buffer (bug#1169) and return whether we inserted
7366 something.
7367
54e10184
LMI
7368 * callint.c (Fcall_interactively): Change "reading args" to
7369 "providing args" to try to clarify what it does (bug#1010).
7370
15fa4783
KH
73712011-07-07 Kenichi Handa <handa@m17n.org>
7372
7373 * composite.c (composition_compute_stop_pos): Ignore a static
7374 composition starting before CHARPOS (Bug#8915).
7375
7376 * xdisp.c (handle_composition_prop): Likewise.
7377
a8815b00
EZ
73782011-07-07 Eli Zaretskii <eliz@gnu.org>
7379
7380 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
7381 (Bug#9015)
7382
ef7b981d 73832011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
7384
7385 * character.h (unicode_category_t): New enum type.
7386
7387 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
7388 (Qchar_code_property_table): New variable.
7389 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
7390 (UNIPROP_COMPRESSED_FORM_P): New macros.
7391 (char_table_ascii): Uncompress the compressed values.
7392 (sub_char_table_ref): New arg is_uniprop. Callers changed.
7393 Uncompress the compressed values.
ac389d0c 7394 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
7395 (char_table_ref_and_range): Uncompress the compressed values.
7396 (sub_char_table_set): New arg is_uniprop. Callers changed.
7397 Uncompress the compressed values.
7398 (sub_char_table_set_range): Args changed. Callers changed.
7399 (char_table_set_range): Adjuted for the above change.
7400 (map_sub_char_table): Delete args default_val and parent. Add arg
7401 top. Give decoded values to a Lisp function.
640c8776 7402 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
7403 values to a Lisp function. Gcpro more variables.
7404 (uniprop_table_uncompress)
7405 (uniprop_decode_value_run_length): New functions.
7406 (uniprop_decoder, uniprop_decoder_count): New variables.
7407 (uniprop_get_decoder, uniprop_encode_value_character)
7408 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
7409 New functions.
7410 (uniprop_encoder, uniprop_encoder_count): New variables.
7411 (uniprop_get_encoder, uniprop_table)
7412 (Funicode_property_table_internal, Fget_unicode_property_internal)
7413 (Fput_unicode_property_internal): New functions.
7414 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
7415 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 7416 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
7417 char-code-property-alist.
7418
640c8776 7419 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
7420 Vunicode_category_table.
7421
640c8776 7422 * font.c (font_range): Adjust for the change of
c805dec0
KH
7423 Vunicode_category_table.
7424
76b397fb
DN
74252011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
7426
7427 * m/iris4d.h: Remove file, move contents ...
7428 * s/irix6-5.h: ... here.
7429
22b4128e
PE
74302011-07-06 Paul Eggert <eggert@cs.ucla.edu>
7431
7432 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
7433 * alloc.c (mark_buffer):
7434 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
7435 (clone_per_buffer_values): Don't assume that
22b4128e
PE
7436 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
7437 This isn't true in general, and it's particularly not true
7438 if Emacs is configured with --with-wide-int.
7439 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
7440 New macros, used in the buffer.c change.
7441
869795d6
JD
74422011-07-05 Jan Djärv <jan.h.d@swipnet.se>
7443
7444 * xsettings.c: Use both GConf and GSettings if both are available.
7445 (store_config_changed_event): Add comment.
7446 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
7447 (store_tool_bar_style_changed): New functions.
5e617bc2 7448 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
7449 (struct xsettings): Move font inside HAVE_XFT.
7450 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 7451 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 7452 Move inside HAVE_XFT.
640c8776 7453 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
7454 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
7455 also.
7456 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 7457 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 7458 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
7459 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
7460 (parse_settings): Move check for font inside HAVE_XFT.
7461 (read_settings, apply_xft_settings): Add comment.
7462 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
7463 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
7464 call store_font_name_changed.
7465 (xft_settings_event): Add comment.
7466 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
7467 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
7468 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
7469 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
7470 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
7471 (xsettings_get_system_font, xsettings_get_system_normal_font):
7472 Add comment.
869795d6 7473
d8ed26bd
PE
74742011-07-05 Paul Eggert <eggert@cs.ucla.edu>
7475
7476 Random fixes. E.g., (random) never returned negative values.
7477 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
7478 subseconds part to the entropy, as that's a bit more random.
7479 Prefer signed to unsigned, since the signedness doesn't matter and
7480 in general we prefer signed. When given a limit, use a
7481 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
7482 latter isn't right if USE_2_TAGS_FOR_INTS.
7483 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
7484 not 0..VALMASK. Don't discard "excess" bits that random () returns.
7485
cabf1cac
SM
74862011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
7487
7488 * textprop.c (text_property_stickiness):
7489 Obey Vtext_property_default_nonsticky.
7490 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
7491 * w32fns.c (syms_of_w32fns):
7492 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
7493
6e9b2be9
PE
74942011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7495
7496 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
7497 This is more efficient than Ffile_directory_p and avoids a minor race.
7498
90186c68
LMI
74992011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
7500
7c301272
LMI
7501 * buffer.c (Foverlay_put): Say what the return value is
7502 (bug#7835).
7503
c4f2d8d4
LMI
7504 * fileio.c (barf_or_query_if_file_exists): Check first if the file
7505 is a directory before asking whether to use the file name
7506 (bug#7564).
ad637907
LMI
7507 (barf_or_query_if_file_exists): Make the "File is a directory"
7508 error be more correct.
c4f2d8d4 7509
90186c68
LMI
7510 * fns.c (Frequire): Remove the mention of the .gz files, since
7511 that's installation-specific, but keep the mention of
7512 `get-load-suffixes'.
7513
da64016e
PE
75142011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7515
7516 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
7517 Report string overflow if the output is too long.
7518
7d47b580
JB
75192011-07-04 Juanma Barranquero <lekktu@gmail.com>
7520
a555cb87
JB
7521 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
7522 (syms_of_gnutls): Remove duplicate DEFSYM for
7523 Qgnutls_bootprop_verify_hostname_error, an error for
7524 Qgnutls_bootprop_verify_error (which is no longer used).
7525
7d47b580
JB
7526 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
7527 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
7528 Also (re)move comments that are misplaced or no longer relevant.
7529
1e49bfab
LMI
75302011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7531
7532 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
7533
1485f4c0
CY
75342011-07-03 Chong Yidong <cyd@stupidchicken.com>
7535
7536 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
7537 and background color parameters if they have been changed.
7538
a9ab721e
LMI
75392011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7540
7541 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
7542
cf7cff57
PE
75432011-07-03 Paul Eggert <eggert@cs.ucla.edu>
7544
2e13213d
PE
7545 * xsettings.c (SYSTEM_FONT): Define only when used.
7546 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
7547
cf7cff57
PE
7548 * keymap.c (access_keymap_1): Now static.
7549
7a8e04f7
CY
75502011-07-02 Chong Yidong <cyd@stupidchicken.com>
7551
7552 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
7553 leave any prefix arg for the up event (Bug#1586).
7554
61352f62
LMI
75552011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
7556
69bb1ef7
LMI
7557 * lread.c (syms_of_lread): Mention single symbols defined by
7558 `defvar' or `defconst' (bug#7154).
7559
61352f62 7560 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 7561 (Frequire): Mention get-load-suffixes.
61352f62 7562
28545e04
MR
75632011-07-02 Martin Rudalics <rudalics@gmx.at>
7564
7565 * window.h (window): Remove clone_number slot.
7566 * window.c (Fwindow_clone_number, Fset_window_clone_number):
7567 Remove.
7568 (make_parent_window, make_window, saved_window)
7569 (Fset_window_configuration, save_window_save): Don't deal with
7570 clone numbers.
7571 * buffer.c (Qclone_number): Remove declaration.
7572 (sort_overlays, overlay_strings): Don't deal with clone numbers.
7573
3349e122
SM
75742011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
7575
7576 Add multiple inheritance to keymaps.
7577 * keymap.c (Fmake_composed_keymap): New function.
7578 (Fset_keymap_parent): Simplify.
7579 (fix_submap_inheritance): Remove.
7580 (access_keymap_1): New function extracted from access_keymap to handle
7581 embedded parents and handle lists of maps.
7582 (access_keymap): Use it.
7583 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
7584 (Fcopy_keymap): Handle embedded parents.
7585 (Fcommand_remapping, define_as_prefix): Simplify.
7586 (Fkey_binding): Simplify.
7587 (syms_of_keymap): Move minibuffer-local-completion-map,
7588 minibuffer-local-filename-completion-map,
7589 minibuffer-local-must-match-map, and
7590 minibuffer-local-filename-must-match-map to Elisp.
7591 (syms_of_keymap): Defsubr make-composed-keymap.
7592 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
7593 (parse_menu_item): Trivial simplification.
7594
3279eb87
GM
75952011-07-01 Glenn Morris <rgm@gnu.org>
7596
7597 * Makefile.in (SETTINGS_LIBS): Fix typo.
7598
4550efdf
KI
75992011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
7600
7601 * coding.c (Fencode_coding_string): Record the last coding system
7602 used, as the function doc string says (bug#8738).
7603
0949d2b6
JD
76042011-07-01 Jan Djärv <jan.h.d@swipnet.se>
7605
7606 * xsettings.c (store_monospaced_changed): Take new font as arg and
7607 check for change against current_mono_font.
7608 (EMACS_TYPE_SETTINGS): Remove this and related defines.
7609 (emacs_settings_constructor, emacs_settings_get_property)
7610 (emacs_settings_set_property, emacs_settings_class_init)
7611 (emacs_settings_init, gsettings_obj): Remove.
7612 (something_changedCB): New function for HAVE_GSETTINGS.
7613 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
7614 with value as argument.
7615 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
7616 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 7617 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
7618 "changed".
7619
7620 * xgselect.c: Add defined (HAVE_GSETTINGS).
7621 (xgselect_initialize): Ditto.
7622
7623 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
7624 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
7625 xg_select.
7626
bbc6b304
PE
76272011-07-01 Paul Eggert <eggert@cs.ucla.edu>
7628
7629 * eval.c (struct backtrace): Simplify and port the data structure.
7630 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
7631 signed bit field, as this assumption is not portable and it makes
7632 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
7633 "char debug_on_exit : 1" as this is not portable either; instead,
7634 use the portable "unsigned int debug_on_exit : 1". Remove unused
7635 member evalargs. Remove obsolete comments about cc bombing out.
7636
9851bfc5
JD
76372011-06-30 Jan Djärv <jan.h.d@swipnet.se>
7638
51bb811f 7639 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
7640 Let HAVE_GSETTINGS override HAVE_GCONF.
7641 (store_monospaced_changed): New function.
7642 (EMACS_SETTINGS): A new type derived from GObject to handle
7643 GSettings notifications.
7644 (emacs_settings_constructor, emacs_settings_get_property)
7645 (emacs_settings_set_property, emacs_settings_class_init):
7646 New functions.
7647 (gsettings_client, gsettings_obj): New variables.
7648 (GSETTINGS_SCHEMA): New define.
7649 (something_changedCB): Call store_monospaced_changed.
7650 (init_gsettings): New function.
7651 (xsettings_initialize): Call init_gsettings.
7652 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
7653 to NULL.
7654
640c8776 7655 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
7656 GCONF_CFLAGS/LIBS.
7657
5386012d
MR
76582011-06-29 Martin Rudalics <rudalics@gmx.at>
7659
7660 * window.c (resize_root_window, grow_mini_window)
7661 (shrink_mini_window): Rename Qresize_root_window to
7662 Qwindow_resize_root_window and Qresize_root_window_vertically to
7663 Qwindow_resize_root_window_vertically.
7664
f13e0b08
PE
76652011-06-28 Paul Eggert <eggert@cs.ucla.edu>
7666
7667 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
7668
94515237
JB
76692011-06-27 Juanma Barranquero <lekktu@gmail.com>
7670
7671 * makefile.w32-in: Redesign dependencies so they reflect more
7672 clearly which files are directly included by each source file,
7673 and not through other includes.
7674
e43b6e43
MR
76752011-06-27 Martin Rudalics <rudalics@gmx.at>
7676
7677 * buffer.c (Qclone_number): Declare static and DEFSYM it.
7678 (sort_overlays, overlay_strings): When an overlay's clone number
7679 matches the window's clone number process the overlay even if
7680 the overlay's window property doesn't match the current window.
7681
d68443dc
MR
7682 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
7683 (Fwindow_hchild): Rename to Fwindow_left_child.
7684 (Fwindow_next): Rename to Fwindow_next_sibling.
7685 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
7686 (resize_window_check): Rename to window_resize_check.
7687 (resize_window_apply): Rename to window_resize_apply.
7688 (Fresize_window_apply): Rename to Fwindow_resize_apply.
7689 (Fdelete_other_windows_internal, resize_frame_windows)
7690 (Fsplit_window_internal, Fdelete_window_internal)
7691 (grow_mini_window, shrink_mini_window)
7692 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 7693
c7e73be5
JD
76942011-06-26 Jan Djärv <jan.h.d@swipnet.se>
7695
7696 * emacsgtkfixed.h: State that this is only used with Gtk+3.
7697 (emacs_fixed_set_min_size): Remove.
7698 (emacs_fixed_new): Take frame as argument.
7699
7700 * emacsgtkfixed.c: State that this is only used with Gtk+3.
7701 (_EmacsFixedPrivate): Remove minwidth/height.
7702 Add struct frame *f.
7703 (emacs_fixed_init): Initialize priv->f.
7704 (get_parent_class, emacs_fixed_set_min_size): Remove.
7705 (emacs_fixed_new): Set priv->f to argument.
7706 (emacs_fixed_get_preferred_width)
7707 (emacs_fixed_get_preferred_height): Use min_width/height from
7708 frames size_hint to set minimum and natural (Bug#8919).
7709 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
7710 and use min_width/height from frames size_hint to set
7711 min_width/height (Bug#8919).
7712
7713 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
7714 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
7715 Fix indentation.
c7e73be5 7716
cf99dcf8
EZ
77172011-06-26 Eli Zaretskii <eliz@gnu.org>
7718
7719 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
7720 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
7721 called at ZV.
7722
029529ac
CY
77232011-06-26 Chong Yidong <cyd@stupidchicken.com>
7724
7725 * process.c (wait_reading_process_output): Bypass select if
7726 waiting for a cell while ignoring keyboard input, and input is
7727 pending. Suggested by Jan Djärv (Bug#8869).
7728
7a7ef429
PE
77292011-06-25 Paul Eggert <eggert@cs.ucla.edu>
7730
7731 Use gnulib's dup2 module instead of rolling our own.
7732 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
7733
11fdef7d 77342011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
7735
7736 * dispnew.c (scrolling_window): Before scrolling, turn off a
7737 mouse-highlight in the window being scrolled.
7738
cd3520a4
JB
77392011-06-24 Juanma Barranquero <lekktu@gmail.com>
7740
7741 Move DEFSYM to lisp.h and use everywhere.
7742
7743 * character.h (DEFSYM): Move declaration...
7744 * lisp.h (DEFSYM): ...here.
7745
7746 * gnutls.c:
7747 * minibuf.c:
7748 * w32menu.c:
7749 * w32proc.c:
7750 * w32select.c: Don't include character.h.
7751
7752 * alloc.c (syms_of_alloc):
7753 * buffer.c (syms_of_buffer):
7754 * bytecode.c (syms_of_bytecode):
7755 * callint.c (syms_of_callint):
7756 * casefiddle.c (syms_of_casefiddle):
7757 * casetab.c (init_casetab_once):
7758 * category.c (init_category_once, syms_of_category):
7759 * ccl.c (syms_of_ccl):
7760 * cmds.c (syms_of_cmds):
7761 * composite.c (syms_of_composite):
7762 * dbusbind.c (syms_of_dbusbind):
7763 * dired.c (syms_of_dired):
7764 * dispnew.c (syms_of_display):
7765 * doc.c (syms_of_doc):
7766 * editfns.c (syms_of_editfns):
7767 * emacs.c (syms_of_emacs):
7768 * eval.c (syms_of_eval):
7769 * fileio.c (syms_of_fileio):
7770 * fns.c (syms_of_fns):
7771 * frame.c (syms_of_frame):
7772 * fringe.c (syms_of_fringe):
7773 * insdel.c (syms_of_insdel):
7774 * keymap.c (syms_of_keymap):
7775 * lread.c (init_obarray, syms_of_lread):
7776 * macros.c (syms_of_macros):
7777 * msdos.c (syms_of_msdos):
7778 * print.c (syms_of_print):
7779 * process.c (syms_of_process):
7780 * search.c (syms_of_search):
7781 * sound.c (syms_of_sound):
7782 * syntax.c (init_syntax_once, syms_of_syntax):
7783 * terminal.c (syms_of_terminal):
7784 * textprop.c (syms_of_textprop):
7785 * undo.c (syms_of_undo):
7786 * w32.c (globals_of_w32):
7787 * window.c (syms_of_window):
7788 * xdisp.c (syms_of_xdisp):
7789 * xfaces.c (syms_of_xfaces):
7790 * xfns.c (syms_of_xfns):
7791 * xmenu.c (syms_of_xmenu):
7792 * xsettings.c (syms_of_xsettings):
7793 * xterm.c (syms_of_xterm): Use DEFSYM.
7794
4228cf16
TZ
77952011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
7796
cd3520a4 7797 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 7798
7fcccf1e
PE
77992011-06-23 Paul Eggert <eggert@cs.ucla.edu>
7800
7efb4e0e
PE
7801 Integer and buffer overflow fixes (Bug#8873).
7802
ff5844ad
PE
7803 * print.c (printchar, strout): Check for string overflow.
7804 (PRINTPREPARE, printchar, strout):
7805 Don't set size unless allocation succeeds.
7806
90532f02
PE
7807 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
7808 for sizes. Check for string overflow more accurately.
7809 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
7810
6d84508d
PE
7811 * macros.c: Integer and buffer overflow fixes.
7812 * keyboard.h (struct keyboard.kbd_macro_bufsize):
7813 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
7814 Use ptrdiff_t, not int, for sizes.
7815 Don't increment bufsize until after realloc succeeds.
7816 Check for size-calculation overflow.
7817 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
7818
437b2cb4
PE
7819 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
7820
8b9ac8b4
PE
7821 * lread.c: Integer overflow fixes.
7822 (read_integer): Radix is now EMACS_INT, not int,
7823 to improve quality of diagnostics for out-of-range radices.
7824 Calculate buffer size correctly for out-of-range radices.
7825 (read1): Check for integer overflow in radices, and in
7826 read-circle numbers.
82cb60d3
PE
7827 (read_escape): Avoid int overflow.
7828 (Fload, openp, read_buffer_size, read1)
7829 (substitute_object_recurse, read_vector, read_list, map_obarray):
7830 Use ptrdiff_t, not int, for sizes.
7831 (read1): Use EMACS_INT, not int, for sizes.
20270765 7832 Check for size overflow.
8b9ac8b4 7833
7fcccf1e
PE
7834 * image.c (cache_image): Check for size arithmetic overflow.
7835
bfbbd7e7
PE
7836 * lread.c: Integer overflow issues.
7837 (saved_doc_string_size, saved_doc_string_length)
7838 (prev_saved_doc_string_size, prev_saved_doc_string_length):
7839 Now ptrdiff_t, not int.
7840 (read1): Don't assume doc string length fits in int. Check for
7841 out-of-range doc string lengths.
7842 (read_list): Don't assume file position fits in int.
39019e54 7843 (read_escape): Check for hex character overflow.
bfbbd7e7 7844
4e323265
LL
78452011-06-22 Leo Liu <sdl.web@gmail.com>
7846
7847 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
7848 Move to minibuffer.el.
7849
85fece3e
PE
78502011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7851
20b84ce9 7852 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
7853 The following patches are for when GLYPH_DEBUG && !XASSERT.
7854 * dispextern.h (trace_redisplay_p, dump_glyph_string):
7855 * dispnew.c (flush_stdout):
7856 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
7857 Mark as externally visible.
7858 * dispnew.c (check_window_matrix_pointers): Now static.
7859 * dispnew.c (window_to_frame_vpos):
7860 * xfns.c (unwind_create_frame):
7861 * xterm.c (x_check_font): Remove unused local.
7862 * scroll.c (CHECK_BOUNDS):
7863 * xfaces.c (cache_fache): Rename local to avoid shadowing.
7864 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
7865 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
7866 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
7867 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
7868 Now static.
7869 (debug_method_add): Use va_list and vsprintf rather than relying
7870 on undefined behavior with wrong number of arguments.
7871 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
7872 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
7873 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
7874 since we're not interested in debugging glyphs with old libraries.
7875 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
7876 GCC 4.6.0's static checking.
7877
0766b489
PE
78782011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7879
31fd4b32
PE
7880 Integer overflow and signedness fixes (Bug#8873).
7881 A few related buffer overrun fixes, too.
7882
b79e8648
PE
7883 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
7884
0766b489
PE
7885 * dispextern.h (struct face.stipple):
7886 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
7887 (x_bitmap_mask, x_allocate_bitmap_record)
7888 (x_create_bitmap_from_data, x_create_bitmap_from_file)
7889 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
7890 (x_create_bitmap_from_xpm_data):
7891 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
7892 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
7893 (.bitmaps_last):
7894 * xfaces.c (load_pixmap):
7895 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
7896 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
7897 (.bitmaps_last, struct x_output.icon_bitmap):
7898 Use ptrdiff_t, not int, for bitmap indexes.
7899 (x_allocate_bitmap_record): Check for size overflow.
7900 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
7901
b081724f
PE
7902 Use ptrdiff_t, not int, for overlay counts.
7903 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
7904 * editfns.c (overlays_around, get_pos_property):
7905 * textprop.c (get_char_property_and_overlay):
7906 * xdisp.c (next_overlay_change, note_mouse_highlight):
7907 * xfaces.c (face_at_buffer_position):
21514da7
PE
7908 * buffer.c (OVERLAY_COUNT_MAX): New macro.
7909 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
7910 (Fnext_overlay_change, Fprevious_overlay_change)
7911 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 7912 Use ptrdiff_t, not int, for sizes.
21514da7 7913 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 7914
3de73e5e
PE
7915 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
7916
2606c57b
PE
7917 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
7918 (x_session_initialize): Do not assume string length fits in int.
7919
aaafe47a
PE
7920 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
7921 This is unlikely, but can occur if DPI is outlandish.
7922
2674ddc8 7923 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
7924 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
7925
28154962
PE
7926 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
7927 * xrdb.c (magic_file_p, search_magic_path):
7928 Omit last arg SUFFIX; it was always 0. All callers changed.
7929 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
7930
7de51af5
PE
7931 * xfont.c (xfont_match): Avoid need for strlen.
7932
25ed6cc3
PE
7933 * xfns.c: Don't assume strlen fits in int.
7934 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
7935
4eab31dd
PE
7936 * xdisp.c (message_log_check_duplicate): Return intmax_t,
7937 not unsigned long, as we prefer signed integers. All callers changed.
7938 Detect integer overflow in repeat count.
7939 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 7940 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 7941
171e2a58
PE
7942 * termcap.c: Don't assume sizes fit in int and never overflow.
7943 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
7944 (gobble_line): Check for size-calculation overflow.
7945
ad39faca 7946 * minibuf.c (Fread_buffer):
6e5bb2dc 7947 * lread.c (intern, intern_c_string):
74ca2eb3
PE
7948 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
7949 Don't assume string length fits in int.
7950
52c61c22 7951 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
7952 * gtkutil.c (style_changed_cb): Avoid need for strlen.
7953
b5b8c9e5
PE
7954 * font.c: Don't assume string length fits in int.
7955 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
7956 Use ptrdiff_t, not int.
ccd6111c
PE
7957 (font_intern_prop): Don't assume string length fits in int.
7958 Don't assume integer property fits in fixnum.
7959 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 7960
882f0d81 7961 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 7962 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
7963 Reformulate so as not to need the command string.
7964 Invoke gzip -cd rather than gunzip, as it's more portable.
7965 (lock_info_type, lock_file_1, lock_file):
7966 Don't assume pid_t and time_t fit in unsigned long.
7967 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
7968 (current_lock_owner): Prefer signed type for sizes.
7969 Use memcpy, not strncpy, where memcpy is what is really wanted.
7970 Don't assume (via atoi) that time_t and pid_t fit in int.
7971 Check for time_t and/or pid_t out of range, e.g., via a network share.
7972 Don't alloca where an auto var works fine.
7973
93f4cf88
PE
7974 * fileio.c: Fix some integer overflow issues.
7975 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
7976 Don't assume string length fits in int.
7977 (directory_file_name): Don't assume string length fits in long.
7978 (make_temp_name): Don't assume pid fits in int, or that its print
7979 length is less than 20.
7980
f3e92b69
PE
7981 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
7982
1bfdaf10
PE
7983 * coding.c (make_subsidiaries): Don't assume string length fits in int.
7984
35016e9a
PE
7985 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
7986
3d1e65a1
PE
7987 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
7988 We prefer signed integers, even for size calculations.
7989
0b963a93
PE
7990 * emacs.c: Don't assume string length fits in 'int'.
7991 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
7992 (main): Don't invoke strlen when not needed.
7993
573f4b54
PE
7994 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
7995 (XD_DEBUG_MESSAGE): Don't waste a byte.
7996
989f33ba
PE
7997 * callproc.c (getenv_internal_1, getenv_internal)
7998 (Fgetenv_internal):
965d34eb
PE
7999 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
8000
e4d29b33
PE
8001 * lread.c (invalid_syntax): Omit length argument.
8002 All uses changed. This doesn't fix a bug, but it simplifies the
8003 code away from its former Hollerith-constant appearance, and it's
8004 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 8005 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 8006
eb49b136
PE
8007 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
8008 This didn't break anything, but it didn't help either.
8009 It's confusing to put a bogus integer in a place where the actual
8010 value does not matter.
9f62aeb1 8011 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 8012 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 8013
15375a22
PE
8014 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
8015 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
8016 implementation.
b61cc01c
PE
8017 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
8018 We prefer signed types, and the value cannot exceed the EMACS_INT
8019 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
8020 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
8021 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
8022 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 8023
53b2623d
PE
8024 * indent.c (sane_tab_width): New function.
8025 (current_column, scan_for_column, Findent_to, position_indentation)
8026 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 8027 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 8028
51cab52b 8029 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 8030
f2ed8a70
PE
8031 * lisp.h (lint_assume): New macro.
8032 * composite.c (composition_gstring_put_cache):
8033 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
8034
abe80cc6
PE
8035 * editfns.c, insdel.c:
8036 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 8037
b02c740e
PE
8038 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
8039
ebc96716
PE
8040 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
8041
b4e50fa0 8042 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 8043 Use much-faster test for byte-length change.
311d5d7c 8044 Don't assume string byte-length fits in 'int'.
a4cf38e4 8045 Check that character arg fits in 'int'.
85461888 8046 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 8047
c0c1ee9f
PE
8048 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
8049
a498d7f4
PE
8050 * fns.c (concat): Catch string overflow earlier.
8051 Do not rely on integer wraparound.
8052
51cab52b
PE
8053 * dispextern.h (struct it.overlay_strings_charpos)
8054 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
8055 * xdisp.c (forward_to_next_line_start)
8056 (back_to_previous_visible_line_start)
8057 (reseat_at_next_visible_line_start, next_element_from_buffer):
8058 Don't arbitrarily truncate the value of 'selective' to int.
8059
76031fad
PE
8060 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
8061
5eb55db9
PE
8062 * composite.c: Don't truncate sizes to 'int'.
8063 (composition_gstring_p, composition_reseat_it)
8064 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
8065 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
8066 not EMACS_UINT, for indexes.
5eb55db9 8067
0703a717
PE
8068 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
8069
d6202519
PE
8070 * buffer.c: Include <verify.h>.
8071 (struct sortvec.priority, struct sortstr.priority):
8961a454 8072 Now EMACS_INT, not int.
c20998a7 8073 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
8074 (struct sortstr.size, record_overlay_string)
8075 (struct sortstrlist.size, struct sortlist.used):
8076 Don't truncate size to int.
8077 (record_overlay_string): Check for size-calculation overflow.
d6202519 8078 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 8079
d5a19415
JM
80802011-06-22 Jim Meyering <meyering@redhat.com>
8081
029529ac 8082 Don't leak an XBM-image-sized buffer
d5a19415
JM
8083 * image.c (xbm_load): Free the image buffer after using it.
8084
a9041e6c
PE
80852011-06-21 Paul Eggert <eggert@cs.ucla.edu>
8086
8087 Port to Sun C.
8088 * composite.c (find_automatic_composition): Omit needless 'return 0;'
8089 that Sun C diagnosed.
8090 * fns.c (secure_hash): Fix pointer signedness issue.
8091 * intervals.c (static_offset_intervals): New function.
8092 (offset_intervals): Use it.
8093
7f3f739f
LL
80942011-06-21 Leo Liu <sdl.web@gmail.com>
8095
8096 * deps.mk (fns.o):
8097 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
8098 sha512.h.
8099
8100 * fns.c (secure_hash): Rename from crypto_hash_function and change
8101 the first arg to accept symbols.
5b66d427 8102 (Fsecure_hash): New primitive.
7f3f739f
LL
8103 (syms_of_fns): New symbols.
8104
76147d94
DD
81052011-06-20 Deniz Dogan <deniz@dogan.se>
8106
8107 * process.c (Fset_process_buffer): Clarify return value in
8108 docstring.
8109
7d7d0045
CY
81102011-06-18 Chong Yidong <cyd@stupidchicken.com>
8111
8112 * dispnew.c (add_window_display_history): Use BVAR.
8113
8114 * xdisp.c (debug_method_add): Use BVAR.
8115 (check_window_end, dump_glyph_matrix, dump_glyph)
8116 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
8117
8118 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
8119 Likewise.
8120
8121 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
8122 check till after the cache is created in init_frame_faces.
8123
ff2bc410
SM
81242011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
8125
8126 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
8127
28177add
PE
81282011-06-16 Paul Eggert <eggert@cs.ucla.edu>
8129
dd3482fe
PE
8130 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
8131 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
8132 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
8133
393d71f3 8134 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
8135 * fileio.c (Finsert_file_contents):
8136 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
8137 Remove the old (too-loose) buffer overflow checks.
8138 They weren't needed, since make_gap checks for buffer overflow.
8139 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
8140 The old code merely checked for Emacs fixnum overflow, and relied
8141 on undefined (wraparound) behavior. The new code avoids undefined
8142 behavior, and also checks for ptrdiff_t and/or size_t overflow.
8143
2e6813b0 8144 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
8145 Tune. Don't use wider integers than needed. Don't use alloca.
8146 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 8147
599a9e4f
PE
8148 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
8149
99561444
PE
8150 * insdel.c, lisp.h (buffer_overflow): New function.
8151 (insert_from_buffer_1, replace_range, replace_range_2):
8152 * insdel.c (make_gap_larger):
8153 * editfns.c (Finsert_char):
8154 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
8155
28177add
PE
8156 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
8157
e69dafad
PE
81582011-06-15 Paul Eggert <eggert@cs.ucla.edu>
8159
4baa020d 8160 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 8161
b1c46f02
PE
8162 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
8163 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
8164
e69dafad
PE
8165 * fileio.c: Don't assume EMACS_INT fits in off_t.
8166 (emacs_lseek): New static function.
8167 (Finsert_file_contents, Fwrite_region): Use it.
8168 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
8169
566684ea
PE
8170 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
8171
e6966cd6
PE
8172 * fns.c: Don't overflow int when computing a list length.
8173 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
8174 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
8175 truncation on 64-bit hosts. Check for QUIT every
8176 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
8177 faster and is responsive enough.
8178 (Flength): Report an error instead of overflowing an integer.
8179 (Fsafe_length): Return a float if the value is not representable
8180 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 8181 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 8182 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 8183
dd0b0efb
PE
8184 * alloc.c: Check that resized vectors' lengths fit in fixnums.
8185 (header_size, word_size): New constants.
8186 (allocate_vectorlike): Don't check size overflow here.
8187 (allocate_vector): Check it here instead, since this is the only
8188 caller of allocate_vectorlike that could cause overflow.
8189 Check that the new vector's length is representable as a fixnum.
8190
86fe5cfe
PE
8191 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
8192 The previous code was bogus. For example, next_almost_prime (32)
8193 returned 39, which is undesirable as it is a multiple of 3; and
8194 next_almost_prime (24) returned 25, which is a multiple of 5 so
8195 why was the code bothering to check for multiples of 7?
8196
80e88859
PE
8197 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
8198
4a2f0ad6
PE
8199 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
8200
f66c7cf8
PE
8201 Variadic C functions now count arguments with ptrdiff_t.
8202 This partly undoes my 2011-03-30 change, which replaced int with size_t.
8203 Back then I didn't know that the Emacs coding style prefers signed int.
8204 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
8205 were being counted with int, which may truncate counts on 64-bit
8206 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
8207 * lisp.h (struct Lisp_Subr.function.aMANY)
8208 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
8209 Arg counts are now ptrdiff_t, not size_t.
8210 All variadic functions and their callers changed accordingly.
8211 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
8212 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
8213 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
8214 * callint.c (Fcall_interactively): Check arg count for overflow,
8215 to avoid potential buffer overrun. Use signed char, not 'int',
8216 for 'varies' array, so that we needn't bother to check its size
8217 calculation for overflow.
8218 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
8219 * eval.c (apply_lambda):
8220 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
8221 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
8222 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
8223
a1759b76
PE
8224 * callint.c (Fcall_interactively): Don't use index var as event count.
8225
d96be9fc
PE
8226 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
8227 * mem-limits.h (SIZE): Remove; no longer used.
8228
a690a978 8229 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 8230
578c21e6
PE
8231 Remove unnecessary casts.
8232 * xterm.c (x_term_init):
8233 * xfns.c (x_set_border_pixel):
8234 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
8235 These aren't needed now that we assume ANSI C.
8236
96f53c6c
PE
8237 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
8238 It's more likely to cause problems (due to unsigned overflow)
8239 than to cure them.
8240
83c77d31
PE
8241 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
8242
ee2079f1
PE
8243 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
8244
6da65536
PE
8245 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
8246
7147c4a4
PE
8247 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
8248
193e32d9
PE
8249 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
8250
e5533da6
PE
8251 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
8252
9910e595
PE
8253 GLYPH_CODE_FACE returns EMACS_INT, not int.
8254 * dispextern.h (merge_faces):
8255 * xfaces.c (merge_faces):
01103c44
PE
8256 * xdisp.c (get_next_display_element, next_element_from_display_vector):
8257 Don't assume EMACS_INT fits in int.
9910e595 8258
2638320e
PE
8259 * character.h (CHAR_VALID_P): Remove unused parameter.
8260 * fontset.c, lisp.h, xdisp.c: All uses changed.
8261
045eb8d9
PE
8262 * editfns.c (Ftranslate_region_internal): Omit redundant test.
8263
c1f134b5
PE
8264 * fns.c (concat): Minor tuning based on overflow analysis.
8265 This doesn't fix any bugs. Use int to hold character, instead
8266 of constantly refetching from Emacs object. Use XFASTINT, not
8267 XINT, for value known to be a character. Don't bother comparing
8268 a single byte to 0400, as it's always less.
8269
395fcb93 8270 * floatfns.c (Fexpt):
327eeec8
PE
8271 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
8272
abbd3d23
PE
8273 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
8274 for characters.
8275
684a03ef
PE
8276 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
8277
0fed43f3
PE
8278 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
8279 Without this fix, on a 64-bit host (aset S 0 4294967386) would
8280 incorrectly succeed when S was a string, because 4294967386 was
8281 truncated before it was used.
8282
8fd02eb7
PE
8283 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
8284 Otherwise, an out-of-range integer could cause undefined behavior
8285 on a 64-bit host.
8286
f8c86b69
PE
8287 * composite.c: Use int, not EMACS_INT, for characters.
8288 (fill_gstring_body, composition_compute_stop_pos): Use int, not
8289 EMACS_INT, for values that are known to be in character range.
8290 This doesn't fix any bugs but is the usual style inside Emacs and
8291 may generate better code on 32-bit machines.
8292
34206dd2
PE
8293 Make sure a 64-bit char is never passed to ENCODE_CHAR.
8294 This is for reasons similar to the recent CHAR_STRING fix.
8295 * charset.c (Fencode_char): Check that character arg is actually
8296 a character. Pass an int to ENCODE_CHAR.
8297 * charset.h (ENCODE_CHAR): Verify that the character argument is no
8298 wider than 'int', as a compile-time check to prevent future regressions
8299 in this area.
8300
c5958d4c 8301 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
8302
8303 Make sure a 64-bit char is never passed to CHAR_STRING.
8304 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
8305 by silently ignoring the top 32 bits, allowing some values
8306 that were far too large to be valid characters.
8307 * character.h: Include <verify.h>.
8308 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
8309 arguments are no wider than unsigned, as a compile-time check
8310 to prevent future regressions in this area.
8311 * data.c (Faset):
01103c44 8312 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
8313 (Fsubst_char_in_region):
8314 * fns.c (concat):
8315 * xdisp.c (decode_mode_spec_coding):
8316 Adjust to CHAR_STRING's new requirement.
8317 * editfns.c (Finsert_char, Fsubst_char_in_region):
8318 * fns.c (concat): Check that character args are actually
8319 characters. Without this test, these functions did the wrong
8320 thing with wildly out-of-range values on 64-bit hosts.
8321
d37ca623
PE
8322 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
8323 These casts should not be needed on 32-bit hosts, either.
8324 * keyboard.c (read_char):
8325 * lread.c (Fload): Remove casts to unsigned.
8326
ea204efb
PE
8327 * lisp.h (UNSIGNED_CMP): New macro.
8328 This fixes comparison bugs on 64-bit hosts.
8329 (ASCII_CHAR_P): Use it.
8330 * casefiddle.c (casify_object):
01103c44 8331 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
8332 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
8333 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
8334 * dispextern.h (FACE_FROM_ID):
8335 * keyboard.c (read_char): Use UNSIGNED_CMP.
8336
41cb286c
PE
8337 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
8338 not to EMACS_INT, to avoid GCC warning.
8339
4a1b9832
PE
8340 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
8341
55daad71
PE
8342 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
8343 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
8344 isn't needed on 32-bit machines.
8f95c75c 8345
01103c44
PE
8346 * buffer.c (Fgenerate_new_buffer_name):
8347 Use EMACS_INT for count, not int.
0ceccced 8348 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
8349
8350 * data.c (Qcompiled_function): Now static.
8351
c6f072e7
PE
8352 * window.c (window_body_lines): Now static.
8353
20ce5912
PE
8354 * image.c (gif_load): Rename local to avoid shadowing.
8355
9c4c5f81
PE
8356 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
8357 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
8358 * alloc.c (make_save_value): Integer argument is now of type
8359 ptrdiff_t, not int.
8360 (mark_object): Use ptrdiff_t, not int.
8361 * lisp.h (pD): New macro.
8362 * print.c (print_object): Use it.
8363
c0c5c8ae
PE
8364 * alloc.c: Use EMACS_INT, not int, to count objects.
8365 (total_conses, total_markers, total_symbols, total_vector_size)
8366 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
8367 (total_free_floats, total_floats, total_free_intervals)
8368 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
8369 Now EMACS_INT, not int. All uses changed.
8370 (Fgarbage_collect): Compute overall total using a double, so that
8371 integer overflow is less likely to be a problem. Check for overflow
8372 when converting back to an integer.
5a25e253
PE
8373 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
8374 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
8375 These were 'int' variables that could overflow on 64-bit hosts;
8376 they were never used, so remove them instead of repairing them.
211a0b2a 8377 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
8378 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
8379 Previously, this ceilinged at INT_MAX, but that doesn't work on
8380 64-bit machines.
e46bb31a 8381 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 8382
c78baabf 8383 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 8384 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
8385 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
8386 when a (possibly-narrower) signed value would do just as well.
8387 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 8388
c9d624c6
PE
8389 * alloc.c: Catch some string size overflows that we were missing.
8390 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
8391 for convenience in STRING_BYTES_MAX.
8392 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
8393 The definition here is exact; the one in lisp.h was approximate.
8394 (allocate_string_data): Check for string overflow. This catches
8395 some instances we weren't catching before. Also, it catches
8396 size_t overflow on (unusual) hosts where SIZE_MAX <= min
8397 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
8398 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 8399
c9d624c6
PE
8400 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
8401 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 8402 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 8403
353032ce
PE
8404 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
8405
2bccce07
PE
8406 * alloc.c (Fmake_string): Check for out-of-range init.
8407
0ac30604
SM
84082011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
8409
8410 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
8411
c195f2de
JD
84122011-06-14 Jan Djärv <jan.h.d@swipnet.se>
8413
8414 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
8415 xg_get_default_scrollbar_width.
8416
8417 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
8418 (int_gtk_range_get_value): Move to the scroll bar part of the file.
8419 (style_changed_cb): Call update_theme_scrollbar_width and call
8420 x_set_scroll_bar_default_width and xg_frame_set_char_size for
8421 all frames (Bug#8505).
8422 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
8423 Call gtk_window_set_resizable if HAVE_GTK3.
8424 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
8425 and height if HAVE_GTK3 (Bug#8505).
8426 (scroll_bar_width_for_theme): New variable.
8427 (update_theme_scrollbar_width): New function.
8428 (xg_get_default_scrollbar_width): Move code to
8429 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
8430 (xg_initialize): Call update_theme_scrollbar_width.
8431
8432 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
8433
8434 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
8435
e10ac9f1
MR
84362011-06-12 Martin Rudalics <rudalics@gmx.at>
8437
8438 * frame.c (make_frame): Call other_buffer_safely instead of
8439 other_buffer.
8440
8441 * window.c (temp_output_buffer_show): Call display_buffer with
8442 second argument Vtemp_buffer_show_specifiers and reset latter
8443 immediately after the call.
8444 (Vtemp_buffer_show_specifiers): New variable.
8445 (auto_window_vscroll_p, next_screen_context_lines)
8446 (Vscroll_preserve_screen_position): Remove leading asterisks from
8447 doc-strings.
8448
2d3c217e 84492011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 8450
7b7f97e8 8451 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
8452 * buffer.c (Qclone_number): Remove for now, as it's unused.
8453 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
8454 (record_buffer): Remove unused local.
8455 * frame.c (other_visible_frames, frame_buffer_list): Now static.
8456 (set_frame_buffer_list): Remove; unused.
8457 * frame.h (other_visible_frames): Remove decl.
8458 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
8459 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
8460 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
8461 if HAVE_GPM.
8462 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
8463 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
8464 Define only if HAVE_GPM.
8465 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
8466 (update_hints_inhibit): Remove; never set. All uses removed.
8467 * widgetprv.h (emacsFrameClassRec): Remove decl.
8468 * window.c (delete_deletable_window): Now returns void, since it
8469 wasn't returning anything.
8470 (compare_window_configurations): Remove unused locals.
8471 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
8472 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
8473 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
8474 the same widths as pointers. This follows up on the 2011-05-06 patch.
8475 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
8476 * xterm.h: Likewise.
8477 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
8478
1384b89e
JB
84792011-06-12 Juanma Barranquero <lekktu@gmail.com>
8480
8481 * makefile.w32-in: Update dependencies.
8482 (LISP_H): Add lib/intprops.h.
8483
1100a63c
CY
84842011-06-11 Chong Yidong <cyd@stupidchicken.com>
8485
8486 * image.c (gif_load): Add animation frame delay to the metadata.
8487 (syms_of_image): Use DEFSYM. New symbol `delay'.
8488
6198ccd0
MR
84892011-06-11 Martin Rudalics <rudalics@gmx.at>
8490
8491 * window.c (delete_deletable_window): Re-add.
8492 (Fset_window_configuration): Rewrite to handle dead buffers and
8493 consequently deletable windows.
8494 (window_tree, Fwindow_tree): Remove. Supply functionality in
8495 window.el.
8496 (compare_window_configurations): Simplify code.
8497
b6e3633c
AS
84982011-06-11 Andreas Schwab <schwab@linux-m68k.org>
8499
1ab0dee5
AS
8500 * image.c (imagemagick_load_image): Fix type mismatch.
8501 (Fimagemagick_types): Likewise.
8502
b6e3633c
AS
8503 * window.h (replace_buffer_in_windows): Declare.
8504
9397e56f
MR
85052011-06-11 Martin Rudalics <rudalics@gmx.at>
8506
8507 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
8508 Qclone_number. Remove external declaration of Qdelete_window.
8509 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
8510 code.
640c8776
SM
8511 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
8512 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
8513 (Fother_buffer): Rewrite doc-string. Major rewrite for new
8514 buffer list implementation.
8515 (other_buffer_safely): New function.
8516 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
8517 calls to replace_buffer_in_windows and
8518 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
8519 if allowed.
8520 (record_buffer): Inhibit quitting and rewrite using quittable
8521 functions. Run Qbuffer_list_update_hook if allowed.
8522 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
8523 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
8524 Move switch-to-buffer to window.el.
9397e56f
MR
8525 (bury-buffer): Move to window.el.
8526 (Vbuffer_list_update_hook): New variable.
8527
8528 * lisp.h (other_buffer_safely): Add prototype in buffer.c
8529 section.
8530
8531 * window.h (resize_frame_windows): Move up in code.
8532 (Fwindow_frame): Remove EXFUN.
8533 (replace_buffer_in_all_windows): Remove prototype.
8534 (replace_buffer_in_windows_safely): Add prototype.
8535
8536 * window.c: Declare Qdelete_window static again. Move down
8537 declaration of select_count.
8538 (Fnext_window, Fprevious_window): Rewrite doc-strings.
8539 (Fother_window): Move to window.el.
8540 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
8541 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
8542 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
8543 window.el.
8544 (replace_buffer_in_windows): Implement by calling
8545 Qreplace_buffer_in_windows.
8546 (replace_buffer_in_all_windows): Remove with some functionality
8547 moved into replace_buffer_in_windows_safely.
8548 (replace_buffer_in_windows_safely): New function.
8549 (select_window_norecord, select_frame_norecord): Move in front
8550 of run_window_configuration_change_hook. Remove now obsolete
8551 declarations.
640c8776
SM
8552 (Fset_window_buffer): Rewrite doc-string.
8553 Call Qrecord_window_buffer.
9397e56f
MR
8554 (keys_of_window): Move binding for other-window to window.el.
8555
b50691aa
CY
85562011-06-11 Chong Yidong <cyd@stupidchicken.com>
8557
8558 * dispextern.h (struct image): Replace data member, whose int_val
8559 and ptr_val fields were not used by anything, with a single
8560 lisp_val object.
8561
8562 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
8563 (gif_clear_image, gif_load, imagemagick_load_image)
8564 (gs_clear_image, gs_load): Callers changed.
8565
3f754b86
PE
85662011-06-10 Paul Eggert <eggert@cs.ucla.edu>
8567
cca69397
PE
8568 * buffer.h: Include <time.h>, for time_t.
8569 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
8570
109e28d0
PE
8571 Fix minor problems found by static checking.
8572
60737f02
PE
8573 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
8574
4b66faf3
PE
8575 Make identifiers static if they are not used in other modules.
8576 * data.c (Qcompiled_function, Qframe, Qvector):
8577 * image.c (QimageMagick, Qsvg):
8578 * minibuf.c (Qmetadata):
8579 * window.c (resize_window_check, resize_root_window): Now static.
8580 * window.h (resize_window_check, resize_root_window): Remove decls.
8581
109e28d0
PE
8582 * window.c (window_deletion_count, delete_deletable_window):
8583 Remove; unused.
46a4ce9e
PE
8584 (window_body_lines): Now static.
8585 (Fdelete_other_windows_internal): Mark vars as initialized.
8586 Make sure 'resize_failed' is initialized.
8587 (run_window_configuration_change_hook): Rename local to avoid shadowing.
8588 (resize_window_apply): Remove unused local.
8589 * window.h (delete_deletable_window): Remove decl.
8590
109e28d0 8591 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
8592 (imagemagick_load_image): Fix pointer signedness problem by changing
8593 last arg from unsigned char * to char *. All uses changed.
8594 Also, fix a local for similar reasons.
8595 Remove unused locals. Remove locals to avoid shadowing.
8596 (fn_rsvg_handle_free): Remove; unused.
8597 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 8598 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 8599
3f754b86
PE
8600 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
8601
2547adb1
CY
86022011-06-10 Chong Yidong <cyd@stupidchicken.com>
8603
8604 * image.c (gif_load): Fix omitted cast error introduced by
8605 2011-06-06 change.
8606
2c8e37d4
MR
86072011-06-10 Martin Rudalics <rudalics@gmx.at>
8608
8609 * window.h (resize_proportionally, orig_total_lines)
8610 (orig_top_line): Remove from window structure.
8611 (set_window_height, set_window_width, change_window_heights)
8612 (Fdelete_window): Remove prototypes.
8613 (resize_frame_windows): Remove duplicate declaration.
8614
440a42e3
EZ
86152011-06-10 Eli Zaretskii <eliz@gnu.org>
8616
8617 * window.h (resize_frame_windows, resize_window_check)
8618 (delete_deletable_window, resize_root_window)
8619 (resize_frame_windows): Declare prototypes.
8620
8621 * window.c (resize_window_apply): Make definition be "static" to
8622 match the prototype.
8623
562dd5e9
MR
86242011-06-10 Martin Rudalics <rudalics@gmx.at>
8625
8626 * window.c: Remove declarations of Qwindow_size_fixed,
8627 window_min_size_1, window_min_size_2, window_min_size,
8628 size_window, window_fixed_size_p, enlarge_window, delete_window.
8629 Remove static from declaration of Qdelete_window, it's
8630 temporarily needed by Fbury_buffer.
8631 (replace_window): Don't assign orig_top_line and
8632 orig_total_lines.
8633 (Fdelete_window, delete_window): Remove. Window deletion is
8634 handled by window.el.
640c8776
SM
8635 (window_loop): Remove DELETE_OTHER_WINDOWS case.
8636 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
8637 (Fdelete_other_windows): Remove. Deleting other windows is
8638 handled by window.el.
8639 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
8640 handled in window.el.
8641 (window_min_size_2, window_min_size_1, window_min_size): Remove.
8642 Window minimum sizes are handled in window.el.
8643 (shrink_windows, size_window, set_window_height)
8644 (set_window_width, change_window_heights, window_height)
8645 (window_width, CURBEG, CURSIZE, enlarge_window)
8646 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
8647 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
8648 handled in window.el.
8649 (make_dummy_parent): Rename to make_parent_window and give it a
8650 second argument horflag.
8651 (make_window): Don't set resize_proportionally any more.
8652 (Fsplit_window): Remove. Windows are split in window.el.
8653 (save_restore_action, save_restore_orig_size)
8654 (shrink_window_lowest_first, save_restore_orig_size): Remove.
8655 Resize mini windows in window.el.
8656 (grow_mini_window, shrink_mini_window): Implement by calling
8657 Qresize_root_window_vertically, resize_window_check and
8658 resize_window_apply.
640c8776
SM
8659 (saved_window, Fset_window_configuration, save_window_save):
8660 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
8661 resize_proportionally.
8662 (window_min_height, window_min_width): Move to window.el.
8663 (keys_of_window): Move bindings for delete-other-windows,
8664 split-window, delete-window and enlarge-window to window.el.
8665
8666 * buffer.c: Temporarily extern Qdelete_window.
8667 (Fbury_buffer): Temporarily call Qdelete_window instead of
8668 Fdelete_window (Fbury_buffer will move to window.el soon).
8669
8670 * frame.c (set_menu_bar_lines_1): Remove code handling
8671 orig_top_line and orig_total_lines.
8672
8673 * dispnew.c (adjust_frame_glyphs_initially): Don't use
8674 set_window_height but set heights directly.
8675 (change_frame_size_1): Use resize_frame_windows.
8676
8677 * xdisp.c (init_xdisp): Don't use set_window_height but set
8678 heights directly.
8679
640c8776
SM
8680 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
8681 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
8682 run_window_configuration_change_hook.
8683
8684 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
8685 instead of change_window_heights and run
8686 run_window_configuration_change_hook.
8687
1a13852e
MR
86882011-06-09 Martin Rudalics <rudalics@gmx.at>
8689
8690 * window.c (replace_window): Rename second argument REPLACEMENT to
8691 NEW. New third argument SETFLAG. Rewrite.
8692 (delete_window, make_dummy_parent): Call replace_window with
8693 third argument 1.
8694 (window_list_1): Move down in code.
8695 (run_window_configuration_change_hook): Move set_buffer part
8696 before select_frame_norecord part in order to unwind correctly.
8697 Rename count1 to count.
8698 (recombine_windows, delete_deletable_window, resize_root_window)
8699 (Fdelete_other_windows_internal)
8700 (Frun_window_configuration_change_hook, make_parent_window)
8701 (resize_window_check, resize_window_apply, Fresize_window_apply)
8702 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
8703 (Fdelete_window_internal, Fresize_mini_window_internal):
8704 New functions.
1a13852e
MR
8705 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
8706
f3d1777e
MR
87072011-06-08 Martin Rudalics <rudalics@gmx.at>
8708
496e208e
MR
8709 * window.h (window): Add some new members to window structure -
8710 normal_lines, normal_cols, new_total, new_normal, clone_number,
8711 splits, nest, prev_buffers, next_buffers.
8712 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 8713 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 8714
f3d1777e
MR
8715 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
8716 Remove.
496e208e
MR
8717 (make_dummy_parent): Set new members of windows structure.
8718 (make_window): Move down in code. Handle new members of window
8719 structure.
8720 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
8721 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
8722 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
8723 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
8724 (Fset_window_next_buffers, Fset_window_clone_number):
8725 New functions.
496e208e
MR
8726 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
8727 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
8728 Doc-string fixes.
8729 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
8730 Argument WINDOW can be now internal window too.
8731 (Fwindow_use_time): Move up in code.
8732 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
8733 Rewrite doc-string.
8734 (Fset_window_configuration, saved_window)
8735 (Fcurrent_window_configuration, save_window_save): Handle new
8736 members of window structure.
b9e809c2
MR
8737 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
8738 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
8739 (syms_of_window): New Lisp objects Qrecord_window_buffer,
8740 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
8741 Qget_mru_window, Qresize_root_window,
8742 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
8743 Qauto_buffer_name; staticpro them.
f3d1777e 8744
abde8f8c
MR
87452011-06-07 Martin Rudalics <rudalics@gmx.at>
8746
8747 * window.c (Fwindow_total_size, Fwindow_left_column)
8748 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
8749 (Fwindow_list_1): New functions.
8750 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
8751 (Fwindow_width, Fscroll_left, Fscroll_right):
8752 Use window_body_cols instead of window_box_text_cols.
8753 (delete_window, Fset_window_configuration):
8754 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
8755 (delete_all_subwindows): Take a window as argument and not a
8756 structure. Rewrite.
190b47e6
MR
8757 (window_loop): Remove handling of GET_LRU_WINDOW and
8758 GET_LARGEST_WINDOW.
8759 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
8760
8761 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
8762 window_box_text_cols. delete_all_subwindows now takes a
8763 Lisp_Object as argument.
abde8f8c 8764
640c8776
SM
8765 * indent.c (compute_motion, Fcompute_motion):
8766 Use window_body_cols instead of window_box_text_cols.
abde8f8c 8767
fa8a67e6
MR
8768 * frame.c (delete_frame): Call delete_all_subwindows with root
8769 window as argument.
8770
a54e3482
DC
87712011-06-07 Daniel Colascione <dan.colascione@gmail.com>
8772
8773 * fns.c (Fputhash): Document return value.
8774
60002bf5
CY
87752011-06-06 Chong Yidong <cyd@stupidchicken.com>
8776
8777 * image.c (gif_load): Implement gif89a spec "no disposal" method.
8778
0c671da6 87792011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 8780
b862a52a 8781 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 8782
be44ca6c
PE
8783 Check for overflow when converting integer to cons and back.
8784 * charset.c (Fdefine_charset_internal, Fdecode_char):
8785 Use cons_to_unsigned to catch overflow.
8786 (Fencode_char): Use INTEGER_TO_CONS.
8787 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
8788 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
8789 * data.c (long_to_cons, cons_to_long): Remove.
8790 (cons_to_unsigned, cons_to_signed): New functions.
8791 These signal an error for invalid or out-of-range values.
8792 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
8793 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
8794 * font.c (Ffont_variation_glyphs):
8795 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
8796 * lisp.h: Include <intprops.h>.
8797 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
8798 (cons_to_signed, cons_to_unsigned): New decls.
8799 (long_to_cons, cons_to_long): Remove decls.
8800 * undo.c (record_first_change): Use INTEGER_TO_CONS.
8801 (Fprimitive_undo): Use CONS_TO_INTEGER.
8802 * xfns.c (Fx_window_property): Likewise.
8803 * xselect.c: Include <limits.h>.
8804 (x_own_selection, selection_data_to_lisp_data):
8805 Use INTEGER_TO_CONS.
8806 (x_handle_selection_request, x_handle_selection_clear)
8807 (x_get_foreign_selection, Fx_disown_selection_internal)
8808 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
8809 (lisp_data_to_selection_data): Use cons_to_unsigned.
8810 (x_fill_property_data): Use cons_to_signed.
8811 Report values out of range.
8812
d1f3d2af
PE
8813 Check for buffer and string overflow more precisely.
8814 * buffer.h (BUF_BYTES_MAX): New macro.
8815 * lisp.h (STRING_BYTES_MAX): New macro.
8816 * alloc.c (Fmake_string):
8817 * character.c (string_escape_byte8):
8818 * coding.c (coding_alloc_by_realloc):
8819 * doprnt.c (doprnt):
8820 * editfns.c (Fformat):
8821 * eval.c (verror):
8822 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
8823 since they may not be the same number.
8824 * editfns.c (Finsert_char):
8825 * fileio.c (Finsert_file_contents):
8826 Likewise for BUF_BYTES_MAX.
8827
dd52fcea
PE
8828 * image.c: Use ptrdiff_t, not int, for sizes.
8829 (slurp_file): Switch from int to ptrdiff_t.
8830 All uses changed.
8831 (slurp_file): Check that file size fits in both size_t (for
8832 malloc) and ptrdiff_t (for sanity and safety).
8833
7f9bbdbb
PE
8834 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
8835 if b->modtime has its maximal value.
8836
dfe18f82
PE
8837 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
8838
84acfcf0
PE
8839 Don't assume time_t can fit into int.
8840 * buffer.h (struct buffer.modtime): Now time_t, not int.
8841 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
8842 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
8843
ccd9a01a
PE
8844 Minor fixes for signed vs unsigned integers.
8845 * character.h (MAYBE_UNIFY_CHAR):
8846 * charset.c (maybe_unify_char):
8847 * keyboard.c (read_char, reorder_modifiers):
8848 XINT -> XFASTINT, since the integer must be nonnegative.
8849 * ftfont.c (ftfont_spec_pattern):
8850 * keymap.c (access_keymap, silly_event_symbol_error):
8851 XUINT -> XFASTINT, since the integer must be nonnegative.
8852 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
8853 since it makes no difference and we prefer signed.
8854 * keyboard.c (record_char): Use XUINT when all the neighbors do.
8855 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
8856 nonnegative.
8857
d6d100dd
SM
88582011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
8859
8860 * window.h (Fwindow_frame): Declare.
8861
2b6148e4
PE
88622011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8863
8864 * alloc.c: Simplify handling of large-request failures (Bug#8800).
8865 (SPARE_MEMORY): Always define.
8866 (LARGE_REQUEST): Remove.
8867 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
8868
f230ecc9
MR
88692011-06-06 Martin Rudalics <rudalics@gmx.at>
8870
727e958e
MR
8871 * lisp.h: Move EXFUNS for Fframe_root_window,
8872 Fframe_first_window and Fset_frame_selected_window to window.h.
8873
8874 * window.h: Move EXFUNS for Fframe_root_window,
8875 Fframe_first_window and Fset_frame_selected_window here from
8876 lisp.h.
8877
8878 * frame.c (Fwindow_frame, Fframe_first_window)
8879 (Fframe_root_window, Fframe_selected_window)
8880 (Fset_frame_selected_window): Move to window.c.
8881 (Factive_minibuffer_window): Move to minibuf.c.
8882 (Fother_visible_frames_p): New function.
8883
8884 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
8885
f230ecc9
MR
8886 * window.c (decode_window, decode_any_window): Move up in code.
8887 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
8888 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
8889 (Fwindow_buffer): Move up and rewrite doc-string.
8890 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
8891 (Fwindow_prev): New functions.
727e958e
MR
8892 (Fwindow_frame): Move here from frame.c. Accept any window as
8893 argument.
8894 (Fframe_root_window, Fframe_first_window)
8895 (Fframe_selected_window): Move here from frame.c. Accept frame
8896 or arbitrary window as argument. Update doc-strings.
8897 (Fminibuffer_window): Move up in code.
8898 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
8899 (Fset_frame_selected_window): Move here from frame.c.
8900 Marginal rewrite.
727e958e
MR
8901 (Fselected_window, select_window, Fselect_window): Move up in
8902 code. Minor doc-string fixes.
f230ecc9 8903
4d09bcf6
PE
89042011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8905
8906 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
8907 Do not assume that spare memory exists; that assumption is valid
8908 only if SYSTEM_MALLOC.
8909 (LARGE_REQUEST): New macro, so that the issue of large requests
8910 is separated from the issue of spare memory.
8911
810928a2
AS
89122011-06-05 Andreas Schwab <schwab@linux-m68k.org>
8913
172418ad
AS
8914 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
8915 format. (Bug#8806)
8916
43f862f7
AS
8917 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
8918
810928a2
AS
8919 * xfns.c (x_set_scroll_bar_default_width): Move declarations
8920 before statements.
8921
a059fe24
JD
89222011-06-05 Jan Djärv <jan.h.d@swipnet.se>
8923
8924 * gtkutil.c (xg_get_default_scrollbar_width): New function.
8925
8926 * gtkutil.h: Declare xg_get_default_scrollbar_width.
8927
8928 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
8929 min width by calling x_set_scroll_bar_default_width (Bug#8505).
8930
989bf368
JB
89312011-06-05 Juanma Barranquero <lekktu@gmail.com>
8932
8933 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
8934
4b80f674
CY
89352011-06-04 Chong Yidong <cyd@stupidchicken.com>
8936
8937 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
8938 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
8939 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
8940 New error handlers.
4b80f674
CY
8941 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
8942 Obey Vx_select_enable_clipboard_manager. Catch errors in
8943 x_clipboard_manager_save (Bug#8779).
8944 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 8945 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 8946
99a33b77 89472011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
8948
8949 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
8950
99a33b77 89512011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
8952
8953 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
8954 in the current matrix if keep_current_p is non-zero.
8955
8264569d
EZ
89562011-06-04 Eli Zaretskii <eliz@gnu.org>
8957
8958 * bidi.c (bidi_level_of_next_char): Fix last change.
8959
57f97249
EZ
89602011-06-03 Eli Zaretskii <eliz@gnu.org>
8961
fec2107c 8962 Support bidi reordering of text covered by display properties.
57f97249 8963
fec2107c
EZ
8964 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
8965 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
8966 (bidi_cache_search, bidi_cache_iterator_state)
8967 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
8968 (bidi_level_of_next_char, bidi_move_to_visually_next):
8969 Support character positions inside a run of characters covered by a
fec2107c
EZ
8970 display string.
8971 (bidi_paragraph_init, bidi_resolve_explicit_1)
8972 (bidi_level_of_next_char): Call bidi_fetch_char and
8973 bidi_fetch_char_advance instead of FETCH_CHAR and
8974 FETCH_CHAR_ADVANCE.
8975 (bidi_init_it): Initialize new members.
8976 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
8977 definitions.
8978 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
8979 instead of using explicit *_CHAR codes.
d6d100dd
SM
8980 (bidi_resolve_explicit, bidi_resolve_weak):
8981 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
8982 bidirectional text is supported only in multibyte buffers.
8983 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
8984 it to initialize the frame_window_p member of struct bidi_it.
8985 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
8986 (bidi_resolve_explicit, bidi_resolve_weak)
8987 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
8988 bidi_it->nchars is non-positive.
8989 (bidi_level_of_next_char): Don't try to lookup the cache for the
8990 next/previous character if nothing is cached there yet, or if we
8991 were just reseat()'ed to a new position.
c40e2fb2 8992
0e14fe90
EZ
8993 * xdisp.c (set_cursor_from_row): Set start and stop points
8994 according to the row's direction when priming the loop that looks
8995 for the glyph on which to display cursor.
8996 (single_display_spec_intangible_p): Function deleted.
8997 (display_prop_intangible_p): Reimplement to call
8998 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
8999 Accept 3 additional arguments needed by handle_display_spec.
9000 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
9001 values: lists, `(when COND...)' forms, etc.
9002 (single_display_spec_string_p): Support property values that are
9003 lists with the argument STRING its top-level element.
9004 (display_prop_string_p): Fix the condition for processing a
9005 property that is a list to be consistent with handle_display_spec.
fec2107c 9006 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
9007 last portion of handle_display_prop.
9008 (compute_display_string_pos): Accept additional argument
9009 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
9010 value of a `display' property is a "replacing spec".
9011 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
9012 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
9013 the display property, but just return a value indicating whether
9014 the display property will replace the characters it covers.
9015 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
9016 frame_window_p members of struct bidi_it.
d6d100dd
SM
9017 (compute_display_string_pos, compute_display_string_end):
9018 New functions.
fec2107c
EZ
9019 (push_it): Accept second argument POSITION, where pop_it should
9020 jump to continue iteration.
9021 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 9022
fec2107c
EZ
9023 * keyboard.c (adjust_point_for_property): Adjust the call to
9024 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
9025
9026 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
9027 (bidi_init_it): Update prototypes.
9028 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
9029 (compute_display_string_pos, compute_display_string_end):
9030 Declare prototypes.
fec2107c
EZ
9031 (struct bidi_it): New members nchars and disp_pos. ch_len is now
9032 EMACS_INT.
fc6f18ce 9033
40087514 90342011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 9035
57f53182
PE
9036 Malloc failure behavior now depends on size of allocation.
9037 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
9038 * lisp.h: Change signatures accordingly.
9039 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
9040 All callers changed. (Bug#8762)
9041
9042 * gnutls.c: Use Emacs's memory allocators.
9043 Without this change, the gnutls library would invoke malloc etc.
9044 directly, which causes problems on non-SYNC_INPUT hosts, and which
9045 runs afoul of improving memory_full behavior. (Bug#8761)
9046 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
9047 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
9048 xfree instead of the default malloc, realloc, free.
9049 (Fgnutls_boot): No need to check for memory allocation failure,
9050 since xmalloc does that for us.
9051
ac32cd99 9052 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
9053 * category.c (hash_get_category_set):
9054 * ccl.c (ccl_driver):
9055 * charset.c (Fdefine_charset_internal):
9056 * charset.h (struct charset.hash_index):
9057 * composite.c (get_composition_id, gstring_lookup_cache)
9058 (composition_gstring_put_cache):
9059 * composite.h (struct composition.hash_index):
9060 * dispextern.h (struct image.hash):
9061 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
9062 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
9063 (hashfn_equal, hashfn_user_defined, make_hash_table)
9064 (maybe_resize_hash_table, hash_lookup, hash_put)
9065 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
9066 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
9067 (Fsxhash, Fgethash, Fputhash, Fmaphash):
9068 * image.c (make_image, search_image_cache, lookup_image)
9069 (xpm_put_color_table_h):
9070 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 9071 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 9072 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 9073 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
9074 * alloc.c (allocate_vectorlike):
9075 Check for overflow in vector size calculations.
9076 * ccl.c (ccl_driver):
9077 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
9078 * fns.c, image.c: Remove unnecessary static decls that would otherwise
9079 need to be updated by these changes.
40087514
PE
9080 * fns.c (make_hash_table, maybe_resize_hash_table):
9081 Check for integer overflow with large hash tables.
0de4bb68
PE
9082 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
9083 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
9084 (SXHASH_REDUCE): New macro.
9085 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
9086 Use it instead of discarding useful hash info with large hash values.
9087 (sxhash_float): New function.
9088 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
9089 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
9090 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
9091 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
9092 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
9093 Adjust signatures to match updated version of code.
9094 (consing_since_gc): Now EMACS_INT, since a single hash table can
9095 use more than INT_MAX bytes.
9096
698d32e2
DN
90972011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
9098
9099 Make it possible to build with GCC-4.6+ -O2 -flto.
9100
9101 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
9102
fd6fa53f
SM
91032011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
9104
9105 * minibuf.c (get_minibuffer, read_minibuf_unwind):
9106 Call minibuffer-inactive-mode.
9107
864db017
JB
91082011-05-31 Juanma Barranquero <lekktu@gmail.com>
9109
9110 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
9111 Update dependencies.
9112
2ad0baf4
DN
91132011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9114
9115 * data.c (init_data): Remove code for UTS, this system is not
9116 supported anymore.
9117
4fcc2638
DN
91182011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9119
9120 Don't force ./temacs to start in terminal mode.
9121
9122 * frame.c (make_initial_frame): Initialize faces in all cases, not
9123 only when CANNOT_DUMP is defined.
9124 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
9125
c56e0fd5
DN
91262011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9127
9128 * dispnew.c (add_window_display_history): Use const for the string
9129 pointer. Remove declaration, not needed.
9130
333d54da 91312011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 9132
55d4c1b2 9133 Use 'inline', not 'INLINE'.
333d54da 9134 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
9135 * alloc.c, fontset.c (INLINE): Remove.
9136 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
9137 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
9138 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
9139 * gmalloc.c (register_heapinfo): Use inline unconditionally.
9140 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
9141
738db178
DN
91422011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9143
9144 Make it possible to run ./temacs.
9145
9146 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
9147 syms_of_callproc does the same thing. Remove test for
9148 "initialized", do it in the caller.
9149 * emacs.c (main): Avoid calling set_initial_environment when dumping.
9150
620c53a6
SM
91512011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
9152
9153 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
9154 (read_minibuf): Use get_minibuffer.
9155 (syms_of_minibuf): Use DEFSYM.
9156 (Qmetadata): New var.
9157 * data.c (Qbuffer): Don't make it static.
9158 (syms_of_data): Use DEFSYM.
9159
e003a292
PE
91602011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9161
9162 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
9163 (CCL_CODE_MIN): New macro.
9164
ed008a6d
PE
91652011-05-30 Paul Eggert <eggert@cs.ucla.edu>
9166
3687c2ef
PE
9167 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
9168
ed008a6d
PE
9169 * eval.c (Qdebug): Now static.
9170 * lisp.h (Qdebug): Remove decl. This reverts a part of the
9171 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
9172 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
9173
d66c4c7c
CY
91742011-05-29 Chong Yidong <cyd@stupidchicken.com>
9175
9176 * image.c: Various fixes to ImageMagick code comments.
9177 (Fimagemagick_types): Doc fix.
9178
5fbc2025
PE
91792011-05-29 Paul Eggert <eggert@cs.ucla.edu>
9180
0196f88a
PE
9181 Minor fixes prompted by GCC 4.6.0 warnings.
9182
9183 * xselect.c (converted_selections, conversion_fail_tag): Now static.
9184
5fbc2025
PE
9185 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
9186 (x_clipboard_manager_save_all): Move extern decl to ...
9187 * xterm.h: ... here, so that it can be checked for consistency.
9188
1dd3c2d9
CY
91892011-05-29 Chong Yidong <cyd@stupidchicken.com>
9190
9191 * xselect.c (x_clipboard_manager_save_frame)
9192 (x_clipboard_manager_save_all): New functions.
9193 (Fx_clipboard_manager_save): Lisp function deleted.
9194
9195 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
9196 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
9197
9198 * xterm.h: Update prototype.
9199
5ba6571d
WX
92002011-05-28 William Xu <william.xwl@gmail.com>
9201
9202 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
9203 exiting (Bug#8239).
9204
3eaff834
JM
92052011-05-28 Jim Meyering <meyering@redhat.com>
9206
e1900994 9207 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
9208 * fns.c (to_uchar): Define.
9209 (crypto_hash_function): Use it to convert some newly-signed
9210 variables to unsigned, to avoid sign-extension bugs. For example,
9211 without this change, (md5 "truc") would evaluate to
9212 45723a2aff78ff4fff7fff1114760e62 rather than the expected
9213 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 9214 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 9215
0f6990a7
PE
92162011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9217
9218 Integer overflow fixes.
c8a9ca5a 9219
08686060
PE
9220 * dbusbind.c: Serial number integer overflow fixes.
9221 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
9222 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
9223 to hold a serial number that is too large for a fixnum.
9224 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9225 Check for serial numbers out of range. Decode any serial number
59568bf0 9226 that was so large that it became a float. (Bug#8722)
08686060 9227
2d1fc3c7
PE
9228 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
9229 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9230 Use XFASTINT rather than XUINT when numbers are nonnegative.
9231 (xd_append_arg, Fdbus_method_return_internal):
9232 (Fdbus_method_error_internal): Likewise. Also, for unsigned
9233 arguments, check that Lisp number is nonnegative, rather than
59568bf0 9234 silently wrapping negative numbers around. (Bug#8722)
30217ff0 9235 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 9236 (Bug#8722)
2d1fc3c7 9237
c8a9ca5a
PE
9238 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
9239
519e1d69
PE
9240 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
9241
6df6ae42 9242 ccl: Add integer overflow checks.
30569699
PE
9243 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
9244 (IN_INT_RANGE): New macros.
9245 (ccl_driver): Use them to check for integer overflow when
9246 decoding a CCL program. Many of the new checks are whether XINT (x)
9247 fits in int; it doesn't always, on 64-bit hosts. The new version
9248 doesn't catch all possible integer overflows, but it's an
847044ea 9249 improvement. (Bug#8719)
30569699 9250
c11285dc
PE
9251 * alloc.c (make_event_array): Use XINT, not XUINT.
9252 There's no need for unsigned here.
9253
fdccd48e
PE
9254 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
9255 This follows up to the 2011-05-06 change that substituted uintptr_t
9256 for EMACS_INT. This case wasn't caught back then.
9257
37910ab2
PE
9258 Rework Fformat to avoid integer overflow issues.
9259 * editfns.c: Include <float.h> unconditionally, as it's everywhere
9260 now (part of C89). Include <verify.h>.
9261 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
9262 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
9263 (Fformat): Avoid the prepass trying to compute sizes; it was only
9264 approximate and thus did not catch overflow reliably. Instead, walk
9265 through the format just once, formatting and computing sizes as we go,
9266 checking for integer overflow at every step, and allocating a larger
9267 buffer as needed. Keep track separately whether the format is
9268 multibyte. Keep only the most-recently calculated precision, rather
9269 than them all. Record whether each argument has been converted to
9270 string. Use EMACS_INT, not int, for byte and char and arg counts.
9271 Support field widths and precisions larger than INT_MAX. Avoid
9272 sprintf's undefined behavior with conversion specifications such as %#d
9273 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
9274 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
9275 formatting out-of-range floating point numbers with int
9173deec 9276 formats. (Bug#8668)
37910ab2 9277
2e6578fb
PE
9278 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
9279
0ae6bdee
PE
9280 * data.c: Avoid integer truncation in expressions involving floats.
9281 * data.c: Include <intprops.h>.
9282 (arith_driver): When there's an integer overflow in an expression
9283 involving floating point, convert the integers to floating point
9284 so that the resulting value does not suffer from catastrophic
9285 integer truncation. For example, on a 64-bit host (* 4
9286 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
9287 Do not rely on undefined behavior after integer overflow.
9288
de883a70
PE
9289 merge count_size_as_multibyte, parse_str_to_multibyte
9290 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 9291 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
9292 Check for integer overflow.
9293 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
9294 since it's now a duplicate of the other. This is more of
9295 a character than a buffer op, so better that it's in character.c.
9296 * fns.c, print.c: Adjust to above changes.
9297
2ff916cb
PE
92982011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
9299
9300 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
9301
f1b54466
PE
93022011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9303
fb1ac845
PE
9304 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9305 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
9306 (x_clipboard_manager_save): Now static.
9307 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
9308
f1b54466
PE
9309 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9310 (crypto_hash_function): Now static.
9311 Fix pointer signedness problems. Avoid unnecessary initializations.
9312
a9f737ee
CY
93132011-05-27 Chong Yidong <cyd@stupidchicken.com>
9314
9315 * termhooks.h (Vselection_alist): Make it terminal-local.
9316
9317 * terminal.c (create_terminal): Initialize it.
9318
9319 * xselect.c: Support for clipboard managers.
9320 (Vselection_alist): Move to termhooks.h as terminal-local var.
9321 (LOCAL_SELECTION): New macro.
9322 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
9323 (symbol_to_x_atom): Remove gratuitous arg.
9324 (x_handle_selection_request, lisp_data_to_selection_data)
9325 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
9326 (x_own_selection, x_get_local_selection, x_convert_selection):
9327 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
9328 (some_frame_on_display): Delete unused function.
9329 (Fx_own_selection_internal, Fx_get_selection_internal)
9330 (Fx_disown_selection_internal, Fx_selection_owner_p)
9331 (Fx_selection_exists_p): New optional frame arg.
9332 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
9333 (x_handle_selection_clear): Don't treat other terminals with the
9334 same keyboard specially. Use the terminal-local Vselection_alist.
9335 (x_clear_frame_selections): Use Frun_hook_with_args.
9336
9337 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
9338
9339 * xterm.h: Add support for those atoms.
9340
e067f0c1
CY
93412011-05-26 Chong Yidong <cyd@stupidchicken.com>
9342
9343 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
9344 (converted_selections, conversion_fail_tag): New global variables.
9345 (x_selection_request_lisp_error): Free the above.
9346 (x_get_local_selection): Remove unnecessary code.
9347 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
9348 of converted selections stored in converted_selections.
9349 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
9350 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
9351 (x_convert_selection): New function.
9352 (x_handle_selection_event): Simplify.
9353 (x_get_foreign_selection): Don't ignore incoming requests while
9354 waiting for an answer; this will fail when we implement
9355 SAVE_TARGETS, and seems unnecessary anyway.
9356 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
9357 (Vx_sent_selection_functions): Doc fix.
9358
0f4aebc0
LL
93592011-05-26 Leo Liu <sdl.web@gmail.com>
9360
9361 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
9362
e61124cd
YM
93632011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9364
9365 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
9366
9367 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
9368 for fringe update if it has periodic bitmap.
ac389d0c 9369 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
9370 and fringe_bitmap_periodic_p.
9371
9372 * fringe.c (get_fringe_bitmap_data): New function.
9373 (draw_fringe_bitmap_1, update_window_fringes): Use it.
9374 (update_window_fringes): Record periodicity of fringe bitmap in glyph
9375 row. Mark glyph row for fringe update if periodicity changed.
9376
9377 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
9378 for fringe update unless it has periodic bitmap.
9379
f16d9837
KH
93802011-05-25 Kenichi Handa <handa@m17n.org>
9381
9382 * xdisp.c (get_next_display_element): Set correct it->face_id for
9383 a static composition.
9384
e1b90ef6
LL
93852011-05-24 Leo Liu <sdl.web@gmail.com>
9386
9387 * deps.mk (fns.o):
9388 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
9389
9390 * fns.c (crypto_hash_function, Fsha1): New function.
9391 (Fmd5): Use crypto_hash_function.
9392 (syms_of_fns): Add Ssha1.
9393
7400048f
PE
93942011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9395
9396 * gnutls.c: Remove unused macros.
9397 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
9398 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
9399 Remove macros that are defined and never used.
9400 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
9401
abb71cf4
CY
94022011-05-22 Chong Yidong <cyd@stupidchicken.com>
9403
9404 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
9405 (Fx_get_selection_internal): Minor cleanup.
9406 (Fx_own_selection_internal): Rename arguments for consistency with
9407 select.el.
9408
6307db39
PE
94092011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9410
9411 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
9412
f3d4e0a4
CY
94132011-05-22 Chong Yidong <cyd@stupidchicken.com>
9414
9415 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
9416
4d8ade89
YM
94172011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9418
9419 * dispnew.c (scrolling_window): Don't exclude the case that the
9420 last enabled row in the desired matrix touches the bottom boundary.
9421
32078c8d
GM
94222011-05-21 Glenn Morris <rgm@gnu.org>
9423
9424 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
9425 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
9426 and add some more files.
32078c8d 9427
7285dc67
EZ
94282011-05-20 Eli Zaretskii <eliz@gnu.org>
9429
9430 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
9431 report_file_error introduced by the change from 2011-05-07.
9432
89d1bd22
PE
94332011-05-20 Paul Eggert <eggert@cs.ucla.edu>
9434
9435 * systime.h (Time): Define only if emacs is defined.
9436 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
9437 where the include path doesn't have X11/X.h by default. See
9438 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
9439
cd394be1 94402011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
9441
9442 * composite.c (find_automatic_composition): Fix previous change.
9443
b9704ad9
GM
94442011-05-20 Glenn Morris <rgm@gnu.org>
9445
9446 * lisp.mk: New file, split from Makefile.in.
9447 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
9448 (shortlisp): Remove.
9449 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
9450
4a720484
GM
94512011-05-19 Glenn Morris <rgm@gnu.org>
9452
9453 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
9454 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
9455 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
9456 (lisp): Set the order to that of loadup.el.
9457 (shortlisp): Make it a copy of $lisp.
9458 (SOME_MACHINE_LISP): Remove.
9459 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
9460 Use just $shortlisp, not $SOME_MACHINE_LISP too.
9461
a28d4396
KH
94622011-05-18 Kenichi Handa <handa@m17n.org>
9463
9464 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
9465 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
9466 (find_automatic_composition): Mostly rewrite for efficiency.
9467
a2b1fa8e
JB
94682011-05-18 Juanma Barranquero <lekktu@gmail.com>
9469
9470 * makefile.w32-in: Update dependencies.
9471
8e1f5610
CS
94722011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
9473
9474 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 9475 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 9476
7025ee00 94772011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 9478
cdfa6eab
PE
9479 Fix some integer overflow issues, such as string length overflow.
9480
06d6db33
PE
9481 * insdel.c (count_size_as_multibyte): Check for string overflow.
9482
2b4560a8
PE
9483 * character.c (lisp_string_width): Check for string overflow.
9484 Use EMACS_INT, not int, for string indexes and lengths; in
9485 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
9486 the resulting string length overflows an EMACS_INT; instead,
9487 report a string overflow if no precision given. When checking for
9488 precision exhaustion, use a check that cannot possibly have
9489 integer overflow. (Bug#8675)
9490 * character.h (lisp_string_width): Adjust to new signature.
9491
cb93f9be
PE
9492 * alloc.c (string_overflow): New function.
9493 (Fmake_string): Use it. This doesn't change behavior, but saves
9494 a few bytes and will simplify future changes.
9495 * character.c (string_escape_byte8): Likewise.
9496 * lisp.h (string_overflow): New decl.
9497
1a1f3366
PE
9498 Fixups, following up to the user-interface timestamp change.
9499 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
9500 for UI timestamps, instead of unsigned long.
9fbd6841
PE
9501 * msdos.c (mouse_get_pos): Likewise.
9502 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
9503 * w32gui.h (Time): Define by including "systime.h" rather than by
9504 declaring it ourselves. (Bug#8664)
9505
d4e3e4d3
PE
9506 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
9507 * image.c (clear_image_cache): Likewise.
9508
f6a24d19
PE
9509 * term.c (term_mouse_position): Don't assume time_t wraparound.
9510
08dc5ae6
PE
9511 Be more systematic about user-interface timestamps.
9512 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
9513 and sometimes 'EMACS_UINT', to represent these timestamps.
9514 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
9515 This makes the code easier to follow, and makes it easier to catch
9516 integer overflow bugs such as Bug#8664.
9517 * frame.c (Fmouse_position, Fmouse_pixel_position):
9518 Use Time, not unsigned long, for user-interface timestamps.
9519 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
9520 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
9521 * keyboard.h (last_event_timestamp): Likewise.
9522 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
9523 * menu.h (xmenu_show): Likewise.
9524 * term.c (term_mouse_position): Likewise.
9525 * termhooks.h (struct input_event.timestamp): Likewise.
9526 (struct terminal.mouse_position_hook): Likewise.
9527 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
9528 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
9529 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
9530 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
9531 what it was before.
9532 * menu.h, termhooks.h: Include "systime.h", for Time.
9533
8e55734a
PE
9534 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
9535 Don't assume that the difference between two unsigned long values
9536 can fit into an integer. At this point, we know button_down_time
9537 <= event->timestamp, so the difference must be nonnegative, so
9538 there's no need to cast the result if double-click-time is
9539 nonnegative, as it should be; check that it's nonnegative, just in
9540 case. This bug is triggered when events are more than 2**31 ms
86db42d2 9541 apart (about 25 days). (Bug#8664)
8e55734a 9542
841f1b75 9543 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 9544 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 9545
3e26f69c
PE
9546 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
9547 that always fit in int. Use a sentinel instead of a counter, to
9548 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
9549 * frame.h (struct frame): Use int for menu_bar_items_used
9550 instead of EMACS_INT, since it always fits in int.
3e26f69c 9551
5cc152c0
PE
9552 * menu.c (grow_menu_items): Check for int overflow.
9553
d89eb65e
PE
9554 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
9555
5235bd3e
PE
9556 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
9557 Before, the code was not consistent. These values cannot exceed
9558 2**31 - 1 so there's no need to make them unsigned.
9559 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
9560 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
9561 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
9562 as modifiers.
9563 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
9564
bc827e23
PE
9565 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
9566 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
9567 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
9568 presumably because the widths might not match.
9569
78eb494e
PE
9570 * window.c (size_window): Avoid needless test at loop start.
9571
04f2d78b
CB
95722011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
9573
9574 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
9575
d2fc7e3d 95762011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
9577
9578 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
9579
d2fc7e3d 95802011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
9581
9582 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
9583 `width' to `bar_area_x' and `bar_area_width', respectively.
9584 (x_scroll_run): Take account of fringe background extension.
9585
04f2d78b
CB
9586 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
9587 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
9588 `bar_area_width', respectively.
9589 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
9590 background extension.
9591
79b70037
GM
95922011-05-10 Jim Meyering <meyering@redhat.com>
9593
9594 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
9595
2f142cc5
JB
95962011-05-10 Juanma Barranquero <lekktu@gmail.com>
9597
9598 * image.c (Finit_image_library): Return t for built-in image types,
9599 like pbm and xbm. (Bug#8640)
9600
57679c86
AS
96012011-05-09 Andreas Schwab <schwab@linux-m68k.org>
9602
9603 * w32menu.c (set_frame_menubar): Fix submenu allocation.
9604
888c9e86
EZ
96052011-05-07 Eli Zaretskii <eliz@gnu.org>
9606
b0512a1d
EZ
9607 * w32console.c (Fset_screen_color): Doc fix.
9608 (Fget_screen_color): New function.
9609 (syms_of_ntterm): Defsubr it.
9610
7285dc67
EZ
9611 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
9612 unlink the temporary file if Fcall_process didn't create it in the
9613 first place.
9614 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
9615 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
9616 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
9617 cue to call_process_cleanup not to close that handle.
9618
4d3fcc8e
BK
96192011-05-07 Ben Key <bkey76@gmail.com>
9620
9621 * makefile.w32-in: The bootstrap-temacs rule now makes use of
9622 one of two shell specific rules, either bootstrap-temacs-CMD or
9623 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
9624 to the previous implementation of the bootstrap-temacs rule.
9625 The bootstrap-temacs-CMD rule is similar to the previous
9626 implementation of the bootstrap-temacs rule except that it
9627 makes use of the ESC_CFLAGS variable instead of the CFLAGS
9628 variable.
9629
9630 These changes, along with some changes to nt/configure.bat,
9631 nt/gmake.defs, and nt/nmake.defs, are required to extend my
9632 earlier fix to add support for --cflags and --ldflags options
9633 that include quotes so that it works whether make uses cmd or
9634 sh as the shell.
9635
b4289b64
MA
96362011-05-06 Michael Albinus <michael.albinus@gmx.de>
9637
9638 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
9639 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
9640 is a constant.
9641 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
9642 a string. Handle both cases.
9643 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
9644 (Fdbus_register_method): Use Qinvalid_function.
9645
af4c0e28
JB
96462011-05-06 Juanma Barranquero <lekktu@gmail.com>
9647
9648 * makefile.w32-in: Update dependencies.
9649 (LISP_H): Add inttypes.h and stdin.h.
9650 (PROCESS_H): Add unistd.h.
9651
c51453d9
EZ
96522011-05-06 Eli Zaretskii <eliz@gnu.org>
9653
9654 * lread.c: Include limits.h (fixes the MS-Windows build broken by
9655 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
9656
8ff0ac3c 96572011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 9658
4c4b566b
PE
9659 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
9660
aab2b9b5
PE
9661 * term.c (vfatal): Remove stray call to va_end.
9662 It's not needed and the C Standard doesn't allow it here anyway.
9663
c378da0b
PE
9664 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
9665 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
9666
288b08c7
PE
9667 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
9668 bytes.
9669
e3601888
PE
9670 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
9671
db6c0e74
PE
9672 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
9673
dd5963ea
PE
9674 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
9675
88c9450f
PE
9676 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
9677
2f9442b8
PE
9678 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
9679
c032b5f8
PE
9680 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
9681 * charset.c (Fdefine_charset_internal): Don't initialize
9682 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 9683 32-bit int (Bug#8600).
a108c10b
PE
9684
9685 * lread.c (read_integer): Be more consistent with string-to-number.
9686 Use string_to_number to do the actual conversion; this avoids
9687 rounding errors and fixes some other screwups. Without this fix,
9688 for example, #x1fffffffffffffff was misread as -2305843009213693952.
9689 (digit_to_number): Move earlier, for benefit of read_integer.
9690 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 9691 not a digit in any supported base. (Bug#8602)
a108c10b 9692
ad5f9eea
PE
9693 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
9694
aec1708a
PE
9695 * dispnew.c (scrolling_window): Return 1 if we scrolled,
9696 to match comment at start of function. This also removes a
9697 GCC warning about overflow in a 32+64-bit port.
9698
47be4ab5
PE
9699 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
9700
371cac43
PE
9701 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
9702 Reported by Stefan Monnier in
9703 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
9704 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9705 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 9706
d01a7826
PE
9707 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
9708 (EMACS_UINTPTR): Likewise, with uintptr_t.
9709
7fd47d5c
PE
9710 * lisp.h: Prefer 64-bit EMACS_INT if available.
9711 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
9712 on 32-bit hosts that have 64-bit int, so that they can access
9713 large files.
122b0c86
PE
9714 However, temporarily disable this change unless the temporary
9715 symbol WIDE_EMACS_INT is defined.
7fd47d5c 9716
8727937b
PE
9717 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
9718
8ac068ac
PE
9719 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
9720 This removes an assumption that EMACS_INT and long are the same
9721 width as pointers. The assumption is true for Emacs porting targets
9722 now, but we want to make other targets possible.
9723 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
9724 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
9725 In the rest of the code, change types of integers that hold casted
9726 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
9727 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
9728 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
9729 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
9730 No need to cast type when ORing.
9731 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
9732 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
9733 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
9734 assume EMACS_INT is the same width as char *.
9735 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
9736 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
9737 Remove no-longer-needed casts.
9738 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
9739 (xg_tool_bar_help_callback, xg_make_tool_item):
9740 Use EMACS_INTPTR to hold an integer
9741 that will be cast to void *; this can avoid a GCC warning
9742 if EMACS_INT is not the same width as void *.
9743 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
9744 * xdisp.c (display_echo_area_1, resize_mini_window_1):
9745 (current_message_1, set_message_1):
9746 Use a local to convert to proper width without a cast.
9747 * xmenu.c (dialog_selection_callback): Likewise.
9748
ede49d71
PE
9749 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
9750 Also, don't assume VALBITS / RAND_BITS is less than 5,
9751 and don't rely on undefined behavior when shifting a 1 left into
9752 the sign bit.
9753 * lisp.h (get_random): Change signature to match.
9754
2f30ecd0
PE
9755 * lread.c (hash_string): Use size_t, not int, for hash computation.
9756 Normally we prefer signed values; but hashing is special, because
9757 it's better to use unsigned division on hash table sizes so that
9758 the remainder is nonnegative. Also, size_t is the natural width
9759 for hashing into memory. The previous code used 'int', which doesn't
9760 retain enough info to hash well into very large tables.
9761 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
9762
2a866e7b
PE
9763 * dbusbind.c: Don't possibly lose pointer info when converting.
9764 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9765 Use XPNTR rather than XHASH, so that the high-order bits of
9766 the pointer aren't lost when converting through void *.
9767
51639eac
PE
9768 * eval.c (Fautoload): Don't double-shift a pointer.
9769
92394119
PE
9770 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
9771
dbdb9a7c
JB
97722011-05-06 Juanma Barranquero <lekktu@gmail.com>
9773
9774 * gnutls.c (DEF_GNUTLS_FN):
9775 * image.c (DEF_IMGLIB_FN): Make function pointers static.
9776
db7a0b4f
AS
97772011-05-05 Andreas Schwab <schwab@linux-m68k.org>
9778
9779 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
9780 marker. (Bug#8610)
9781
cd394be1 97822011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
9783
9784 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
9785 New version that can reserve upto 2GB of heap space.
9786
f7ff1b0f 97872011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
9788
9789 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
9790
639c109b
TZ
97912011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
9792
9793 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
9794 `gnutls_certificate_set_x509_key_file'.
9795
d2127135
JB
97962011-05-05 Juanma Barranquero <lekktu@gmail.com>
9797
9798 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
9799 Update dependencies.
9800
e968f4f3
JB
98012011-05-04 Juanma Barranquero <lekktu@gmail.com>
9802
9803 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
9804 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
9805 Remove unused parameter `fildes'.
9806 * process.c (read_process_output, send_process): Don't pass it.
9807
84d358f0
JB
98082011-05-04 Juanma Barranquero <lekktu@gmail.com>
9809
9810 Fix previous change: the library cache is defined in w32.c.
9811 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
9812 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
9813
0898ca10
JB
98142011-05-04 Juanma Barranquero <lekktu@gmail.com>
9815
9816 Implement dynamic loading of GnuTLS on Windows.
9817
9818 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
9819 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
9820 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9821 Declare.
9822
9823 * gnutls.c (Qgnutls_dll): Define.
9824 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
9825 (gnutls_*): Declare function pointers.
9826 (init_gnutls_functions): New function to initialize function pointers.
9827 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
9828 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
9829 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9830 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
9831 (emacs_gnutls_write, emacs_gnutls_read)
9832 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
9833 (Fgnutls_available_p): New function.
9834 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
9835 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
9836 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
9837
9838 * image.c: Include w32.h.
9839 (Vimage_type_cache): Delete.
9840 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
9841 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
9842 (w32_delayed_load): Move to w32.c.
9843
9844 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
9845
9846 * w32.c (QCloaded_from, Vlibrary_cache): Define.
9847 (w32_delayed_load): Move from image.c. When loading a library, record
9848 its filename in the :loaded-from property of the library id.
9849 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
9850 Initialize and staticpro them.
9851 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
9852
9853 * process.c: Include lisp.h before w32.h, not after.
9854 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
9855 instead of gnutls_record_check_pending.
9856
9857 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
9858
ff4de4aa
TZ
98592011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
9860
9861 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
9862 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
9863 as passed in.
9864
abe95abb
JD
98652011-05-03 Jan Djärv <jan.h.d@swipnet.se>
9866
9867 * xterm.c (x_set_frame_alpha): Do not set property on anything
9868 else than FRAME_X_OUTER_WINDOW (Bug#8608).
9869
e16e55d4
JB
98702011-05-02 Juanma Barranquero <lekktu@gmail.com>
9871
9872 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
9873
bafcf6a5
JB
98742011-05-02 Juanma Barranquero <lekktu@gmail.com>
9875
9876 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
9877 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
9878 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
9879 (gnutls_global_initialized, Qgnutls_bootprop_priority)
9880 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
9881 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
9882 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
9883 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
9884 (Qgnutls_bootprop_callbacks_verify): Make static.
9885
e7a6747f
AS
98862011-05-01 Andreas Schwab <schwab@linux-m68k.org>
9887
19ed11ba
AS
9888 * callproc.c: Indentation fixup.
9889
e7a6747f 9890 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
9891 (wait_for_termination, interruptible_wait_for_termination):
9892 Move after wait_for_termination_1.
e7a6747f 9893
1ef14cb4
LMI
98942011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
9895
9896 * sysdep.c (interruptible_wait_for_termination): New function
9897 which is like wait_for_termination, but allows keyboard
9898 interruptions.
9899
9900 * callproc.c (Fcall_process): Add (:file "file") as an option for
9901 the STDOUT buffer.
9902 (Fcall_process_region): Ditto.
9903
330d880c
EZ
99042011-04-30 Eli Zaretskii <eliz@gnu.org>
9905
8db90b73
EZ
9906 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
9907 rather than `XVECTOR (FOO)->size'.
9908
330d880c
EZ
9909 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
9910 inttypes.h, as a gnulib replacement is used if it not available in
9911 system headers.
9912
15cbd324
EZ
99132011-04-21 Eli Zaretskii <eliz@gnu.org>
9914
9915 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
9916 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
9917 of MOST_POSITIVE_FIXNUM. (Bug#8528)
9918
9919 * coding.c (coding_alloc_by_realloc): Error out if destination
9920 will grow beyond MOST_POSITIVE_FIXNUM.
9921 (decode_coding_emacs_mule): Abort if there isn't enough place in
9922 charbuf for the composition carryover bytes. Reserve an extra
9923 space for up to 2 characters produced in a loop.
9924 (decode_coding_iso_2022): Abort if there isn't enough place in
9925 charbuf for the composition carryover bytes.
9926
99272011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 9928
ae940cca
EZ
9929 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
9930 aborting when %lld or %lll format is passed.
9931 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
9932 %llo or %llx format is passed. (Bug#8545)
9933
03ab8921
EZ
9934 * window.c (window_scroll_line_based): Use a marker instead of
9935 simple variables to record original value of point. (Bug#7952)
9936
afda1437
EZ
9937 * doprnt.c (doprnt): Fix the case where a multibyte sequence
9938 produced by %s or %c overflows available buffer space. (Bug#8545)
9939
f76dee0c
PE
99402011-04-28 Paul Eggert <eggert@cs.ucla.edu>
9941
9942 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 9943 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 9944
fdc5744d
JB
99452011-04-28 Juanma Barranquero <lekktu@gmail.com>
9946
9947 * w32.c (init_environment): Warn about defaulting HOME to C:\.
9948
638f053a
JB
99492011-04-28 Juanma Barranquero <lekktu@gmail.com>
9950
9951 * keyboard.c (Qdelayed_warnings_hook): Define.
9952 (command_loop_1): Run `delayed-warnings-hook'
9953 if Vdelayed_warnings_list is non-nil.
9954 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
9955 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
9956
d178f871
EZ
99572011-04-28 Eli Zaretskii <eliz@gnu.org>
9958
9959 * doprnt.c (doprnt): Don't return value smaller than the buffer
9960 size if the message was truncated. (Bug#8545).
9961
b124fd93
JB
99622011-04-28 Juanma Barranquero <lekktu@gmail.com>
9963
9964 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
9965 (Fx_window_property): #if-0 the whole functions, not just the bodies.
9966
e810457d
PE
99672011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9968
9969 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
9970
ea51cceb
JB
99712011-04-27 Juanma Barranquero <lekktu@gmail.com>
9972
9973 * makefile.w32-in: Update dependencies.
9974
94dcfacf
EZ
99752011-04-27 Eli Zaretskii <eliz@gnu.org>
9976
9977 Improve `doprnt' and its usage. (Bug#8545)
9978 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
9979 `format_end'. Remove support for %l as a conversion specifier.
9980 Don't use xrealloc. Improve diagnostics when the %l size modifier
9981 is used. Update the commentary.
9982
9983 * eval.c (verror): Simplify calculation of size_t.
9984
9985 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
9986 messages.
9987
f61f41d7
PE
99882011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
9989
9990 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
9991 change.
9992
96fb4434
PE
99932011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9994
9995 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
9996 This makes this file independent of the recent pseudovector change.
9997
671875da 99982011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 9999
69e9b5a3
PE
10000 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
10001
b5f869a7 10002 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 10003 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 10004 Remove unused local.
c8926152 10005 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 10006
841a1577 10007 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
10008 GCC 4.6.0 optimizes based on type-based alias analysis.
10009 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
10010 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
10011 != &v->size, and therefore "v->size = 1; b->size = 2; return
10012 v->size;" must therefore return 1. This assumption is incorrect
10013 for Emacs, since it type-puns struct Lisp_Vector * with many other
10014 types. To fix this problem, this patch adds a new type struct
f904488f 10015 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
10016 and pseudovectors, and helps optimizing compilers not get fooled
10017 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
10018 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
10019 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
10020 the size member.
eab3844f
PE
10021 (XSETPVECTYPE): Rewrite in terms of new macro.
10022 (XSETPVECTYPESIZE): New macro, specifying both type and size.
10023 This is a bit clearer, and further avoids the possibility of
10024 undesirable aliasing.
10025 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 10026 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
10027 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
10028 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
10029 (ASIZE): Now uses header.size rather than size.
10030 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
10031 to avoid the hassle of writing XVECTOR (foo)->header.size.
10032 (struct vectorlike_header): New type.
eab3844f
PE
10033 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
10034 object, to help avoid aliasing.
10035 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
10036 (SUBRP): Likewise, since Lisp_Subr is a special case.
10037 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
10038 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
10039 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 10040 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
10041 changed to be "header.size" and "header.next".
10042 * buffer.h (struct buffer): Likewise.
10043 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
10044 * frame.h (struct frame): Likewise.
10045 * process.h (struct Lisp_Process): Likewise.
10046 * termhooks.h (struct terminal): Likewise.
10047 * window.c (struct save_window_data, struct saved_window): Likewise.
10048 * window.h (struct window): Likewise.
10049 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
10050 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
10051 * buffer.c (init_buffer_once): Likewise.
10052 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
10053 special case.
10054 * process.c (Fformat_network_address): Use local var for size,
10055 for brevity.
10056
0df1eac5
PE
10057 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
10058
847ab9d1 10059 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
10060 * data.c (atof): Remove decl; no longer used or needed.
10061 (digit_to_number): Move to lread.c.
10062 (Fstring_to_number): Use new string_to_number function, to be
10063 consistent with how the Lisp reader treats infinities and NaNs.
10064 Do not assume that floating-point numbers represent EMACS_INT
10065 without losing information; this is not true on most 64-bit hosts.
10066 Avoid double-rounding errors, by insisting on integers when
10067 parsing non-base-10 numbers, as the documentation specifies.
10068 * lisp.h (string_to_number): New decl, replacing ...
10069 (isfloat_string): Remove.
bc0a5c13 10070 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 10071 (read1): Do not accept +. and -. as integers; this
452f4150
PE
10072 appears to have been a coding error. Similarly, do not accept
10073 strings like +-1e0 as floating point numbers. Do not report
10074 overflow for integer overflows unless the base is not 10 which
10075 means we have no simple and reliable way to continue.
10076 Break out the floating-point parsing into a new
10077 function string_to_number, so that Fstring_to_number parses
10078 floating point numbers consistently with the Lisp reader.
04f2d78b 10079 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
10080 (E_CHAR, EXP_INT): Remove, replacing with ...
10081 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
10082 (string_to_number): New function, replacing isfloat_string.
10083 This function checks for valid syntax and produces the resulting
10084 Lisp float number too. Rework it so that string-to-number
bc0a5c13 10085 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
10086 so that overflow for non-base-10 numbers is reported only when
10087 there's no portable and simple way to convert to floating point.
452f4150 10088
67769ffc
PE
10089 * textprop.c (set_text_properties_1): Rewrite for clarity,
10090 and to avoid GCC warning about integer overflow.
10091
c20db43f
PE
10092 * intervals.h (struct interval): Use EMACS_INT for members
10093 where EMACS_UINT might cause problems. See
10094 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
10095 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
10096 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
10097 All uses changed.
37aa2f85
PE
10098 (offset_intervals): Tell GCC not to worry about length overflow
10099 when negating a negative length.
c20db43f 10100
2538aa2f
PE
10101 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
10102 (overrun_check_free): Likewise.
10103
f2d3008d
PE
10104 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
10105 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
10106 word size.
10107
ec8df744
PE
10108 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10109 (gnutls_make_error): Rename local to avoid shadowing.
10110 (gnutls_emacs_global_deinit): ifdef out; not used.
10111 (Fgnutls_boot): Use const for pointer to readonly storage.
10112 Comment out unused local. Fix pointer signedness problems.
10113
640ee02d
PE
10114 * lread.c (openp): Don't stuff size_t into an 'int'.
10115 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
10116 about possible signed overflow.
10117
6048fb2a
PE
10118 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10119 (GDK_KEY_g): Don't define if already defined.
10120 (xg_prepare_tooltip): Avoid pointer signedness problem.
10121 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
10122
fa3c87e1
PE
10123 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
10124 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
10125
2172544b
PE
10126 * xfns.c (Fx_window_property): Simplify a bit,
10127 to make a bit faster and to avoid GCC 4.6.0 warning.
10128 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
10129
9b821a21
PE
10130 * fns.c (internal_equal): Don't assume size_t fits in int.
10131
3c616cfa
PE
10132 * alloc.c (compact_small_strings): Tighten assertion a little.
10133
c2982e87
PE
10134 Replace pEd with more-general pI, and fix some printf arg casts.
10135 * lisp.h (pI): New macro, generalizing old pEd macro to other
10136 conversion specifiers. For example, use "...%"pI"d..." rather
10137 than "...%"pEd"...".
10138 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 10139 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
10140 * alloc.c (check_pure_size): Don't overflow by converting size to int.
10141 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
10142 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
10143 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
10144 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
10145 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
10146 64-bit hosts.
10147 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
10148 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
10149 * print.c (safe_debug_print, print_object): Likewise.
10150 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
10151 to int.
6f04d126
PE
10152 Use pI instead of if-then-else-abort. Use %p to avoid casts,
10153 avoiding the 0 flag, which is not portable.
c2982e87
PE
10154 * process.c (Fmake_network_process): Use pI to avoid cast.
10155 * region-cache.c (pp_cache): Likewise.
10156 * xdisp.c (decode_mode_spec): Likewise.
10157 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
10158 behavior on 64-bit hosts with printf arg.
6f04d126 10159 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
10160 (x_stop_queuing_selection_requests): Likewise.
10161 (x_get_window_property): Don't truncate byte count to an 'int'
10162 when tracing.
0b432f21 10163
5e073ec7
PE
10164 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
10165 here, since it parses constructs like leading '-' and spaces,
10166 which are not wanted; and it overflows with large numbers.
10167 Instead, simply match F[0-9]+, which is what is wanted anyway.
10168
36372bf9
PE
10169 * alloc.c: Remove unportable assumptions about struct layout.
10170 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
10171 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
10172 (allocate_vectorlike, make_pure_vector): Use the new macros,
10173 plus offsetof, to remove unportable assumptions about struct layout.
10174 These assumptions hold on all porting targets that I know of, but
10175 they are not guaranteed, they're easy to remove, and removing them
10176 makes further changes easier.
10177
0b432f21
PE
10178 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
10179 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
10180 (string_overrun_cookie): Now const. Use initializers that
10181 don't formally overflow signed char, to avoid warnings.
000098c1
PE
10182 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
10183 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
10184 (allocate_buffer): Don't assume sizeof (struct buffer) is a
10185 multiple of sizeof (EMACS_INT); it need not be, if
10186 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 10187 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 10188
895009e1
JB
101892011-04-26 Juanma Barranquero <lekktu@gmail.com>
10190
10191 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
10192
6a7a1b0b
TZ
101932011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
10194
10195 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 10196 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
10197 Reported by Paul Eggert <eggert@cs.ucla.edu>.
10198
841a1577 101992011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
10200
10201 * lisp.h (Qdebug): List symbol.
895009e1 10202 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
10203 * keyboard.c (debug-on-event): New variable.
10204 (handle_user_signal): Break into debugger when debug-on-event
10205 matches the current signal symbol.
10206
f2d3ba6f
DN
102072011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
10208
10209 * alloc.c (check_sblock, check_string_bytes)
10210 (check_string_free_list): Convert to standard C.
10211
42ce4c63
TZ
102122011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
10213
10214 * w32.c (emacs_gnutls_push): Fix typo.
10215
825cd63c
EZ
102162011-04-25 Eli Zaretskii <eliz@gnu.org>
10217
fb11d64d
EZ
10218 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
10219 "cast to pointer from integer of different size".
10220
825cd63c
EZ
10221 Improve doprnt and its use in verror. (Bug#8545)
10222 * doprnt.c (doprnt): Document the set of format control sequences
10223 supported by the function. Use SAFE_ALLOCA instead of always
10224 using `alloca'.
10225
10226 * eval.c (verror): Don't limit the buffer size at size_max-1, that
10227 is one byte too soon. Don't use xrealloc; instead xfree and
10228 xmalloc anew.
10229
e061a11b
TZ
102302011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
10231
10232 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
10233 callbacks stage.
10234
10235 * gnutls.c: Renamed global_initialized to
10236 gnutls_global_initialized. Added internals for the
10237 :verify-hostname-error, :verify-error, and :verify-flags
10238 parameters of `gnutls-boot' and documented those parameters in the
10239 docstring. Start callback support.
9173deec
JB
10240 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
10241 unless a fatal error occurred. Call gnutls_alert_send_appropriate
10242 on error. Return error code.
e061a11b
TZ
10243 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
10244 (emacs_gnutls_read): Likewise.
10245 (Fgnutls_boot): Return handshake error code.
10246 (emacs_gnutls_handle_error): New function.
10247 (wsaerror_to_errno): Likewise.
10248
10249 * w32.h (emacs_gnutls_pull): Add prototype.
10250 (emacs_gnutls_push): Likewise.
10251
10252 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
10253 (emacs_gnutls_push): Likewise.
10254
102552011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
10256
10257 * process.c (wait_reading_process_output): Check if GnuTLS
10258 buffered some data internally if no FDs are set for TLS
10259 connections.
10260
10261 * makefile.w32-in (OBJ2): Add gnutls.$(O).
10262 (LIBS): Link to USER_LIBS.
10263 ($(BLD)/gnutls.$(0)): New target.
10264
fa6996bc
EZ
102652011-04-24 Eli Zaretskii <eliz@gnu.org>
10266
eb35682e
EZ
10267 * xdisp.c (handle_single_display_spec): Rename the
10268 display_replaced_before_p argument into display_replaced_p, to
10269 make it consistent with the commentary. Fix typos in the
10270 commentary.
10271
e2ad650c
EZ
10272 * textprop.c (syms_of_textprop): Remove dead code.
10273 (copy_text_properties): Delete obsolete commentary about an
10274 interface that was deleted long ago. Fix typos in the description
10275 of arguments.
10276
1b2de274
EZ
10277 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
10278 to changes in oldXMenu/XMenu.h from 2011-04-16.
10279 <menu_help_message, prev_menu_help_message>: Constify.
10280 (IT_menu_make_room): menu->help_text is now `const char **';
10281 adjust.
10282
10283 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
10284 to changes in oldXMenu/XMenu.h from 2011-04-16.
10285 (struct XMenu): Declare `help_text' `const char **'.
10286
10287 * xfaces.c <Qunspecified>: Make extern again.
10288
10289 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 10290 required by POSIX.
1b2de274 10291
762b15be
EZ
10292 * doc.c (get_doc_string): Improve the format passed to `error'.
10293
10294 * doprnt.c (doprnt): Improve commentary.
10295
10296 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
10297
10298 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
10299 them with etags.
10300
f1052e5d
EZ
10301 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
10302 changes in globals.h immediately force recompilation.
762b15be
EZ
10303 (TAGS): Depend on $(CURDIR)/m/intel386.h and
10304 $(CURDIR)/s/ms-w32.h.
10305 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 10306
fa6996bc
EZ
10307 * character.c (Fchar_direction): Function deleted.
10308 (syms_of_character): Don't defsubr it.
10309 <char-direction-table>: Deleted.
10310
e6c3da20
EZ
103112011-04-23 Eli Zaretskii <eliz@gnu.org>
10312
10313 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
10314 * doprnt.c: Include limits.h.
10315 (SIZE_MAX): New macro.
04f2d78b
CB
10316 (doprnt): Return a size_t value. 2nd arg is now size_t.
10317 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
10318 Improve overflow protection. Support `l' modifier for integer
10319 conversions. Support %l conversion. Don't assume an EMACS_INT
10320 argument for integer conversions and for %c.
10321
10322 * lisp.h (doprnt): Restore prototype.
10323
10324 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
10325 $(SRC)/character.h.
10326
10327 * Makefile.in (base_obj): Add back doprnt.o.
10328
10329 * deps.mk (doprnt.o): Add back prerequisites.
10330 (callint.o): Depend on character.h.
10331
10332 * eval.c (internal_lisp_condition_case): Include the handler
10333 representation in the error message.
10334 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
10335 when breaking from the loop.
10336
10337 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
10338
10339 * callint.c (Fcall_interactively): When displaying error message
10340 about invalid control letter, pass the character's codepoint, not
10341 a pointer to its multibyte form. Improve display of the character
10342 in octal and display also its hex code.
10343
10344 * character.c (char_string): Use %x to display the (unsigned)
10345 codepoint of an invalid character, to avoid displaying a bogus
10346 negative value.
10347
10348 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
10349 `error', not SYMBOL_NAME itself.
10350
10351 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
10352 character arguments to `error'.
10353
10354 * charset.c (check_iso_charset_parameter): Fix incorrect argument
10355 to `error' in error message about FINAL_CHAR argument. Make sure
10356 FINAL_CHAR is a character, and use %c when it is passed as
10357 argument to `error'.
10358
4ffd0d6b 103592011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
10360
10361 * s/ms-w32.h (localtime): Redirect to sys_localtime.
10362
10363 * w32.c: Include <time.h>.
10364 (sys_localtime): New function.
10365
4ffd0d6b 103662011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
10367
10368 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
10369
4ffd0d6b 10370 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 10371
4ffd0d6b 103722011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 10373
4ffd0d6b
GM
10374 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
10375 zombies (Bug#8467).
aac0c6e3 10376
04c56954
EZ
103772011-04-19 Eli Zaretskii <eliz@gnu.org>
10378
10379 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
10380 gl_state.e_property when gl_state.object is Qt.
10381
10382 * insdel.c (make_gap_larger): Remove limitation of buffer size
10383 to <= INT_MAX.
10384
16a43933
CY
103852011-04-18 Chong Yidong <cyd@stupidchicken.com>
10386
10387 * xdisp.c (lookup_glyphless_char_display)
10388 (produce_glyphless_glyph): Handle cons cell entry in
10389 glyphless-char-display.
10390 (Vglyphless_char_display): Document it.
10391
10392 * term.c (produce_glyphless_glyph): Handle cons cell entry in
10393 glyphless-char-display.
10394
4581706e
CY
103952011-04-17 Chong Yidong <cyd@stupidchicken.com>
10396
10397 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
10398
10399 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
10400
10401 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
10402 definition for no-X builds.
10403
4887c6e2 104042011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 10405
fd35b6f9
PE
10406 Static checks with GCC 4.6.0 and non-default toolkits.
10407
5c1ccb01
PE
10408 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
10409
006c5daa
PE
10410 * process.c (keyboard_bit_set): Define only if SIGIO.
10411 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
10412 (send_process): Repair possible setjmp clobbering.
10413
efc736d3
PE
10414 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
10415
4e2fe2e6
PE
10416 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
10417
f97334a2
PE
10418 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
10419
4e75f29d
PE
10420 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
10421 Define only if needed.
10422
90efadd1
PE
10423 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
10424 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 10425 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 10426
3c647824
PE
10427 * dispextern.h (struct redisplay_interface): Rename param
10428 to avoid shadowing.
e264f262 10429 * termhooks.h (struct terminal): Likewise.
761383f4 10430 * xterm.c (xembed_send_message): Likewise.
3c647824 10431
b58c5c4a
PE
10432 * insdel.c (make_gap_smaller): Define only if
10433 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
10434
cad59032
PE
10435 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
10436 it.
10437
c339dc2e
PE
10438 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
10439 so that we aren't warned about unused symbols.
10440
91a3e27b
PE
10441 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
10442
399c71d3 10443 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 10444
8ffc96f5
PE
10445 * xfns.c (x_real_positions): Mark locals as initialized.
10446
eef9bc79
PE
10447 * xmenu.c (xmenu_show): Don't use uninitialized vars.
10448
098db9dd
PE
10449 * xterm.c: Fix problems found by static analysis with other toolkits.
10450 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
10451 (x_dispatch_event): Declare static if USE_GTK, and
10452 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 10453 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 10454 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
10455 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
10456 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 10457
eb18f6cc
PE
10458 * xmenu.c (menu_help_callback): Pointer type fixes.
10459 Use const pointers when pointing at readonly data. Avoid pointer
10460 signedness clashes.
10461 (FALSE): Remove unused macro.
10462 (update_frame_menubar): Remove unused decl.
10463
1fe72bf8
PE
10464 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
10465
60d9e1db
PE
10466 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
10467 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
10468 (single_menu_item): Rename local to avoid shadowing.
10469
39261c26
PE
10470 * keyboard.c (make_lispy_event): Remove unused local var.
10471
018c5e19
PE
10472 * frame.c, frame.h (x_get_resource_string): Bring this back, but
10473 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
10474
63d2b86e
PE
10475 * bitmaps: Change bitmaps from unsigned char back to the X11
10476 compatible char. Avoid the old compiler warnings about
10477 out-of-range initializers by using, for example, '\xab' rather
10478 than 0xab.
10479
aefd87e1
PE
10480 * xgselect.c (xgselect_initialize): Check vs interface
10481 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
10482
bf501fb9
PE
10483 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
10484
e9829fdf
PE
10485 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
10486 to read-only memory.
10487
1086c095
PE
10488 * fns.c (vector): Remove; this old hack is no longer needed.
10489
2baccd04 10490 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 10491 Remove unused var.
dde42981 10492 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 10493
72391843 10494 * xrdb.c (x_load_resources): Omit unused local.
3565b346 10495
436c16df 10496 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 10497 (x_window): Rename locals to avoid shadowing.
dc5ddd85 10498 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 10499
92bb796d 10500 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 10501 (x_term_init): Remove local to avoid shadowing.
92bb796d 10502
764430a3 10503 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
10504
10505 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
10506 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
10507
d1dfb56c
EZ
105082011-04-16 Eli Zaretskii <eliz@gnu.org>
10509
c4354cb4
EZ
10510 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
10511
d1dfb56c
EZ
10512 Fix regex.c, syntax.c and friends for buffers > 2GB.
10513 * syntax.h (struct gl_state_s): Declare character position members
10514 EMACS_INT.
10515
10516 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
10517
04f2d78b
CB
10518 * textprop.c (verify_interval_modification, interval_of):
10519 Declare arguments EMACS_INT.
d1dfb56c
EZ
10520
10521 * intervals.c (adjust_intervals_for_insertion): Declare arguments
10522 EMACS_INT.
10523
10524 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
10525
10526 * indent.c (Fvertical_motion): Local variable it_start is now
10527 EMACS_INT.
10528
10529 * regex.c (re_match, re_match_2, re_match_2_internal)
10530 (bcmp_translate, regcomp, regexec, print_double_string)
10531 (group_in_compile_stack, re_search, re_search_2, regex_compile)
10532 (re_compile_pattern, re_exec): Declare arguments and local
10533 variables `size_t' and `ssize_t' and return values `regoff_t', as
10534 appropriate.
10535 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
10536 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
10537 <compile_stack_type>: `size' and `avail' are now `size_t'.
10538
10539 * regex.h <regoff_t>: Use ssize_t, not int.
10540 (re_search, re_search_2, re_match, re_match_2): Arguments that
10541 specify buffer/string position and length are now ssize_t and
10542 size_t. Return type is regoff_t.
10543
613052cd
BK
105442011-04-16 Ben Key <bkey76@gmail.com>
10545
10546 * nsfont.m: Fixed bugs in ns_get_family and
10547 ns_descriptor_to_entity that were caused by using free to
10548 deallocate memory blocks that were allocated by xmalloc (via
10549 xstrdup). This caused Emacs to crash when compiled with
10550 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
10551 --enable-checking=xmallocoverrun). xfree is now used to
10552 deallocate these memory blocks.
10553
4170f62f 105542011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 10555
71b41406
PE
10556 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
10557
9587a89d
PE
10558 emacs_write: Accept and return EMACS_INT for sizes.
10559 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
10560 et seq.
10561 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
10562 Accept and return EMACS_INT.
10563 (emacs_gnutls_write): Return the number of bytes written on
10564 partial writes.
10565 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
10566 (emacs_read, emacs_write): Remove check for negative size, as the
10567 Emacs source code has been audited now.
9587a89d
PE
10568 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
10569 (emacs_read, emacs_write): Use it.
273a5f82
PE
10570 * process.c (send_process): Adjust to the new signatures of
10571 emacs_write and emacs_gnutls_write. Do not attempt to store
10572 a byte offset into an 'int'; it might overflow.
9587a89d 10573 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 10574
3e047f51
PE
10575 * sound.c: Don't assume sizes fit in 'int'.
10576 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 10577 Return EMACS_INT, not int.
3e047f51 10578 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
10579 Accept EMACS_INT, not int.
10580 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
10581 record read return values.
10582
cc39a9db
BK
105832011-04-15 Ben Key <bkey76@gmail.com>
10584
c9d0ec6d
JB
10585 * keyboard.c (Qundefined): Don't declare static since it is used
10586 in nsfns.m.
10587 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
10588 static since they are used in nsfont.m.
cc39a9db 10589
6c60eb9f
SM
105902011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
10591
10592 * process.c (Qprocessp): Don't declare static.
10593 * lisp.h (Qprocessp): Declare again.
10594
7990b61a
JB
105952011-04-15 Juanma Barranquero <lekktu@gmail.com>
10596
10597 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
10598
5d4cb038
PE
105992011-04-14 Paul Eggert <eggert@cs.ucla.edu>
10600
8bd7b830 10601 Improve C-level modularity by making more things 'static'.
cd64ea1d 10602
e3b27b31
PE
10603 Don't publish debugger-only interfaces to other modules.
10604 * lisp.h (safe_debug_print, debug_output_compilation_hack):
10605 (verify_bytepos, count_markers): Move decls to the only modules
10606 that need them.
10607 * region-cache.h (pp_cache): Likewise.
10608 * window.h (check_all_windows): Likewise.
10609 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
10610
5d4cb038
PE
10611 * sysdep.c (croak): Now static, if
10612 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
10613 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
10614
10615 * alloc.c (refill_memory_reserve): Now static if
10616 !defined REL_ALLOC || defined SYSTEM_MALLOC.
10617 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 10618
e87b6180
PE
10619 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
10620 Define only if USE_LUCID.
10621
ac64929e
PE
10622 * xrdb.c (x_customization_string, x_rm_string): Now static.
10623
6f37259d
PE
10624 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
10625 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
10626
1683e3ab
PE
10627 * xdisp.c (draw_row_with_mouse_face): Now static.
10628 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
10629
de9c2632
PE
10630 * window.h (check_all_windows): Mark externally visible.
10631
2b96acb7
PE
10632 * window.c (window_deletion_count): Now static.
10633
10634 * undo.c: Make symbols static if they're not exported.
10635 (last_undo_buffer, last_boundary_position, pending_boundary):
10636 Now static.
10637
50436f33
PE
10638 * textprop.c (interval_insert_behind_hooks): Now static.
10639 (interval_insert_in_front_hooks): Likewise.
10640
64520e5c
PE
10641 * term.c: Make symbols static if they're not exported.
10642 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
10643 (max_frame_lines, tty_set_terminal_modes):
10644 (tty_reset_terminal_modes, tty_turn_off_highlight):
10645 (get_tty_terminal): Now static.
10646 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
10647 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 10648 HAVE_WINDOW_SYSTEM.
64520e5c
PE
10649 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
10650 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
10651
1fa53021
PE
10652 * sysdep.c: Make symbols static if they're not exported.
10653 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
10654 Now static.
10655 (sigprocmask_set, full_mask): Remove; unused.
10656 (wait_debugging): Mark as visible.
10657 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
10658 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
10659
d4b43b22
PE
10660 * syntax.c (syntax_temp): Define only if !__GNUC__.
10661
b7c513d0
PE
10662 * sound.c (current_sound_device, current_sound): Now static.
10663
989b29ad
PE
10664 * search.c (searchbufs, searchbuf_head): Now static.
10665
13a55a78
PE
10666 * scroll.c (scroll_cost): Remove; unused.
10667 * dispextern.h (scroll_cost): Remove decl.
10668
de68a1fc
PE
10669 * region-cache.h (pp_cache): Mark as externally visible.
10670
40ccffa6
PE
10671 * process.c: Make symbols static if they're not exported.
10672 (process_tick, update_tick, create_process, chan_process):
10673 (Vprocess_alist, proc_buffered_char, datagram_access):
10674 (fd_callback_data, send_process_frame, process_sent_to): Now static.
10675 (deactivate_process): Mark defn as static, as well as decl.
10676 * lisp.h (create_process): Remove decl.
10677 * process.h (chan_process, Vprocess_alist): Remove decls.
10678
ad64fc97
PE
10679 * print.c: Make symbols static if they're not exported.
10680 (print_depth, new_backquote_output, being_printed, print_buffer):
10681 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
10682 (print_interval, print_number_index, initial_stderr_stream):
10683 Now static.
10684 * lisp.h (Fprinc): Remove decl.
10685 (debug_output_compilation_hack): Mark as externally visible.
10686
adddb265
PE
10687 * sysdep.c (croak): Move decl from here to syssignal.h.
10688 * syssignal.h (croak): Put it here, so the API can be checked when
10689 'croak' is called from dissociate_if_controlling_tty.
10690
1717ede2
PE
10691 * minibuf.c: Make symbols static if they're not exported.
10692 (minibuf_save_list, choose_minibuf_frame): Now static.
10693 * lisp.h (choose_minibuf_frame): Remove decl.
10694
fa5fb2bc
PE
10695 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
10696
1e3890d1
PE
10697 * lread.c: Make symbols static if they're not exported.
10698 (read_objects, initial_obarray, oblookup_last_bucket_number):
10699 Now static.
10700 (make_symbol): Remove; unused.
10701 * lisp.h (initial_obarray, make_symbol): Remove decls.
10702
8a1414fa
PE
10703 * keyboard.c: Make symbols static if they're not exported.
10704 (single_kboard, recent_keys_index, total_keys, recent_keys):
10705 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
10706 (this_single_command_key_start, echoing, last_auto_save):
10707 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
10708 (command_loop, echo_now, keyboard_init_hook, help_char_p):
10709 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
10710 (Vlispy_mouse_stem, double_click_count):
10711 Now static.
10712 (force_auto_save_soon): Define only if SIGDANGER.
10713 (ignore_mouse_drag_p): Now static if
10714 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
10715 (print_help): Remove; unused.
10716 (stop_character, last_timer_event): Mark as externally visible.
10717 * keyboard.h (ignore_mouse_drag_p): Declare only if
10718 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
10719 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
10720 * lisp.h (echoing): Remove decl.
10721 (force_auto_save_soon): Declare only if SIGDANGER.
10722 * xdisp.c (redisplay_window): Simplify code, to make it more
10723 obvious that ignore_mouse_drag_p is not accessed if !defined
10724 USE_GTK && !defined HAVE_NS.
10725
93ea6e8f
PE
10726 * intervals.c: Make symbols static if they're not exported.
10727 (merge_properties_sticky, merge_interval_right, delete_interval):
10728 Now static.
10729 * intervals.h (merge_interval_right, delete_interval): Remove decls.
10730
77382fcc
PE
10731 * insdel.c: Make symbols static if they're not exported.
10732 However, leave prepare_to_modify_buffer alone. It's never
10733 called from outside this function, but that appears to be a bug.
10734 (combine_after_change_list, combine_after_change_buffer):
4889fc82 10735 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
10736 (adjust_after_replace_noundo): Remove; unused.
10737 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 10738 (signal_before_change): Remove decls.
77382fcc 10739
9306c32e
PE
10740 * indent.c (val_compute_motion, val_vmotion): Now static.
10741
cd44d2eb
PE
10742 * image.c: Make symbols static if they're not exported.
10743 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
10744 if USE_GTK.
10745 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
10746 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
10747
ad9a7a06
PE
10748 * fringe.c (standard_bitmaps): Now static.
10749 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
10750
81626931
PE
10751 * frame.c: Make symbols static if they're not exported.
10752 (x_report_frame_params, make_terminal_frame): Now static.
10753 (get_frame_param): Now static, unless HAVE_NS.
10754 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
10755 (x_get_resource_string): Remove; not used.
10756 * frame.h (make_terminal_frame, x_report_frame_params):
10757 (x_get_resource_string); Remove decls.
10758 (x_fullscreen_adjust): Declare only if WINDOWSNT.
10759 * lisp.h (get_frame_param): Declare only if HAVE_NS.
10760
239f9db9
PE
10761 * font.c, fontset.c: Make symbols static if they're not exported.
10762 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
10763 (FACE_SUITABLE_FOR_CHAR_P): Use it.
10764 * font.c (font_close_object): Now static.
10765 * font.h (font_close_object): Remove.
10766 * fontset.c (FONTSET_OBJLIST): Remove.
10767 (free_realized_fontset) #if-0 the body, which does nothing.
10768 (face_suitable_for_char_p): #if-0, as it's never called.
10769 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
10770 * xfaces.c (face_at_string_position):
10771 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
10772 since 0 is always ASCII.
10773
dfcf3579
PE
10774 * fns.c (weak_hash_tables): Now static.
10775
5045092b
PE
10776 * fileio.c: Make symbols static if they're not exported.
10777 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
10778 (Vwrite_region_annotation_buffers): Now static.
10779
57a96f5c
PE
10780 * eval.c: Make symbols static if they're not exported.
10781 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
10782 * lisp.h (backtrace_list): Remove decl.
10783
35f08c38
PE
10784 * emacs.c: Make symbols static if they're not exported.
10785 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
10786 (fatal_error_code, fatal_error_signal_hook, standard_args):
10787 Now static.
10788 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
10789 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
10790 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
10791 * lisp.h (fatal_error_signal_hook): Remove decl.
10792 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
10793
f44bd759
PE
10794 * editfns.c: Move a (normally-unused) function to its only use.
10795 * editfns.c, lisp.h (get_operating_system_release): Remove.
10796 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
10797 worth the hassle of breaking this out.
10798
b532497d
PE
10799 * xterm.c: Make symbols static if they're not exported.
10800 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
10801 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
10802 (x_destroy_window, x_delete_display):
10803 Now static.
10804 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
10805 (x_mouse_leave): Remove; unused.
10806 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
10807 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
10808 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
10809 Remove decls.
10810 (x_mouse_leave): Declare only if WINDOWSNT.
10811 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
10812 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
10813 USE_X_TOOLKIT.
10814
1675728f
PE
10815 * ftxfont.c: Make symbols static if they're not exported.
10816 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
10817 HAVE_FREETYPE.
10818 * font.h (ftxfont_driver): Likewise.
10819
e4cebfca
PE
10820 * xfns.c: Make symbols static if they're not exported.
10821 (x_last_font_name, x_display_info_for_name):
10822 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
10823 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
10824 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
10825 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
10826 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
10827 (last_show_tip_args): Now static.
10828 (xic_defaut_fontset, xic_create_fontsetname): Define only if
10829 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
10830 (x_screen_planes): Remove; unused.
10831 * dispextern.h (x_screen_planes): Remove decl.
10832
5bf46f05
PE
10833 * dispnew.c: Make symbols static if they're not exported.
10834 * dispextern.h (redraw_garbaged_frames, scrolling):
10835 (increment_row_positions): Remove.
10836 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
10837 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
10838 Now static.
10839 (redraw_garbaged_frames): Remove; unused.
10840
435f4c28
PE
10841 * xfaces.c: Make symbols static if they're not exported.
10842 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
10843 Remove decls.
10844 * xterm.h (defined_color): Remove decls.
10845 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
10846 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
10847 (menu_face_changed_default, defined_color, free_realized_face):
10848 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
10849 (ascii_face_of_lisp_face): Remove; unused.
10850
8524aef3
PE
10851 * xdisp.c: Make symbols static if they're not exported.
10852 * dispextern.h (scratch_glyph_row, window_box_edges):
10853 (glyph_to_pixel_coords, set_cursor_from_row):
10854 (get_next_display_element, set_iterator_to_next):
10855 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
10856 (show_mouse_face): Remove decls
10857 * frame.h (message_buf_print): Likewise.
10858 * lisp.h (pop_message, set_message, check_point_in_composition):
10859 Likewise.
10860 * xterm.h (set_vertical_scroll_bar): Likewise.
10861 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
10862 (message_buf_print, scratch_glyph_row, displayed_buffer):
10863 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
10864 (get_next_display_element, show_mouse_face, window_box_edges):
10865 (frame_to_window_pixel_xy, check_point_in_composition):
10866 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
10867 (glyph_to_pixel_coords): Remove; unused.
10868
16390cd2
PE
10869 * dired.c (file_name_completion): Now static.
10870
10871 * dbusbind.c (xd_in_read_queued_messages): Now static.
10872
a25f4dfa
PE
10873 * lisp.h (circular_list_error, FOREACH): Remove; unused.
10874 * data.c (circular_list_error): Remove.
10875
14a9c8df
PE
10876 * commands.h (last_point_position, last_point_position_buffer):
10877 (last_point_position_window): Remove decls.
10878 * keyboard.c: Make these variables static.
10879
04f2d78b
CB
10880 * coding.h (coding, code_convert_region, encode_coding_gap):
10881 Remove decls.
74ab6df5
PE
10882 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
10883 (iso_code_class, detect_coding, code_convert_region): Now static.
10884 (encode_coding_gap): Remove; unused.
10885
38dfbee1
PE
10886 * chartab.c (chartab_chars, chartab_bits): Now static.
10887
a2cb4e63
PE
10888 * charset.h (charset_iso_8859_1): Remove decl.
10889 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
10890 Now static.
10891
127198fd
PE
10892 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
10893 * ccl.c (Vccl_program_table): Now static.
10894 (check_ccl_update): Remove; unused.
10895
d85b608f
PE
10896 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
10897 * category.h: ... from here.
10898 * category.c (check_category_table, set_category_set): Now static.
10899
31cd66f3
PE
10900 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
10901 * lisp.h: Remove these decls.
10902
c358e587
PE
10903 * buffer.c (buffer_count): Remove unused var.
10904
e78aecca
PE
10905 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
10906 so that it's not optimized away.
10907 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
10908 * dispextern.h (bidi_dump_cached_states): Remove, since it's
10909 exported only to the debugger.
10910
e192d7d3 10911 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 10912 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 10913
92470028
PE
10914 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
10915 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
10916 was inaccessible from Lisp.
10917 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
10918 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
10919
244ed907
PE
10920 alloc.c: Import and export fewer symbols, and remove unused items.
10921 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
10922 is defined.
10923 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
10924 it's not optimized away by whole-program optimization.
10925 (message_enable_multibyte, free_misc): Remove.
10926 (catchlist, handlerlist, mark_backtrace):
10927 Declare only if BYTE_MARK_STACK.
10928 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
10929 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
10930 (message_enable_multibyte): Remove decl.
10931 (free_misc, interval_free_list, float_block, float_block_index):
10932 (n_float_blocks, float_free_list, cons_block, cons_block_index):
10933 (cons_free_list, last_marked_index):
10934 Now static.
10935 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
10936 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
10937 (mark_backtrace): Define only if BYTE_MARK_STACK.
10938 * xdisp.c (message_enable_multibyte): Now static.
10939
61c2b50e 10940 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
10941 This makes it easier for human readers (and static analyzers)
10942 to see whether these variables are used from other modules.
10943 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
10944 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
10945 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
10946 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
10947 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
10948 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
10949 * xmenu.c, xselect.c:
10950 Declare Q* vars static if they are not used in other modules.
10951 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
10952 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
10953 Remove decls of unexported vars.
10954 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
10955
95c82688
PE
10956 * lisp.h (DEFINE_FUNC): Make sname 'static'.
10957
16a97296
PE
10958 Make Emacs functions such as Fatom 'static' by default.
10959 This makes it easier for human readers (and static analyzers)
10960 to see whether these functions can be called from other modules.
10961 DEFUN now defines a static function. To make the function external
10962 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
10963 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
10964 (Finit_image_library):
16a97296
PE
10965 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
10966 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
10967 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
10968 Remove decls, since these functions are now static.
10969 (Funintern, Fget_internal_run_time): New decls, since these functions
10970 were already external.
95c82688 10971
16a97296
PE
10972 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
10973 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
10974 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
10975 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
10976 * keyboard.c, keymap.c, lread.c:
10977 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
10978 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
10979 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
10980 Mark functions with DEFUE instead of DEFUN,
10981 if they are used in other modules.
10982 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
10983 decls for now-static functions.
10984 * buffer.h (Fdelete_overlay): Remove decl.
10985 * callproc.c (Fgetenv_internal): Mark as internal.
10986 * composite.c (Fremove_list_of_text_properties): Remove decl.
10987 (Fcomposition_get_gstring): New forward static decl.
10988 * composite.h (Fcomposite_get_gstring): Remove decl.
10989 * dired.c (Ffile_attributes): New forward static decl.
10990 * doc.c (Fdocumntation_property): New forward static decl.
10991 * eval.c (Ffetch_bytecode): New forward static decl.
10992 (Funintern): Remove extern decl; now in .h file where it belongs.
10993 * fileio.c (Fmake_symbolic_link): New forward static decl.
10994 * image.c (Finit_image_library): New forward static decl.
10995 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
10996 * intervals.h (Fprevious_property_change):
10997 (Fremove_list_of_text_properties): Remove decls.
10998 * keyboard.c (Fthis_command_keys): Remove decl.
10999 (Fcommand_execute): New forward static decl.
11000 * keymap.c (Flookup_key): New forward static decl.
11001 (Fcopy_keymap): Now static.
11002 * keymap.h (Flookup_key): Remove decl.
11003 * process.c (Fget_process): New forward static decl.
11004 (Fprocess_datagram_address): Mark as internal.
11005 * syntax.c (Fsyntax_table_p): New forward static decl.
11006 (skip_chars): Remove duplicate decl.
11007 * textprop.c (Fprevious_property_change): New forward static decl.
11008 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
11009 Now internal.
11010 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
11011 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
11012
785bbd42
PE
11013 * editfns.c (Fformat): Remove unreachable code.
11014
8b913b57
AS
110152011-04-14 Andreas Schwab <schwab@linux-m68k.org>
11016
11017 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
11018 change. (Bug#8496)
11019
a6744a35
EZ
110202011-04-13 Eli Zaretskii <eliz@gnu.org>
11021
11022 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
11023 when at ZV. (Bug#8487)
11024
e7974947
AS
110252011-04-12 Andreas Schwab <schwab@linux-m68k.org>
11026
baad03f0
AS
11027 * charset.c (Fclear_charset_maps): Use xfree instead of free.
11028 (Bug#8437)
11029 * keyboard.c (parse_tool_bar_item): Likewise.
11030 * sound.c (sound_cleanup, alsa_close): Likewise.
11031 * termcap.c (tgetent): Likewise.
11032 * xfns.c (x_default_font_parameter): Likewise.
11033 * xsettings.c (read_and_apply_settings): Likewise.
11034
e7974947
AS
11035 * alloc.c (overrun_check_malloc, overrun_check_realloc)
11036 (overrun_check_free): Protoize.
11037
28272684
PE
110382011-04-12 Paul Eggert <eggert@cs.ucla.edu>
11039
11040 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
11041 since callers should never pass a negative size.
11042 Change the signature to match that of plain 'read' and 'write'; see
11043 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
11044 * lisp.h: Update prototypes of emacs_write and emacs_read.
11045
11997c76
EZ
110462011-04-11 Eli Zaretskii <eliz@gnu.org>
11047
11048 * xdisp.c (redisplay_window): Don't try to determine the character
11049 position of the scroll margin if the window start point w->startp
e896f03c 11050 is outside the buffer's accessible region. (Bug#8468)
11997c76 11051
8a2cbd72
EZ
110522011-04-10 Eli Zaretskii <eliz@gnu.org>
11053
11054 Fix write-region and its subroutines for buffers > 2GB.
11055 * fileio.c (a_write, e_write): Modify declaration of arguments and
11056 local variables to support buffers larger than 2GB.
11057 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
11058
11059 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
11060 argument, local variables, and return value.
11061
11062 * lisp.h: Update prototypes of emacs_write and emacs_read.
11063
11064 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
11065
4073e537 110662011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 11067
1ebfdcb6
PE
11068 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
11069
b2ded58d
PE
11070 Fix more problems found by GCC 4.6.0's static checks.
11071
7d66342c
PE
11072 * xdisp.c (vmessage): Use a better test for character truncation.
11073
bbf47d44
PE
11074 * charset.c (load_charset_map): <, not <=, for optimization,
11075 and to avoid potential problems with integer overflow.
9248994d 11076 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 11077 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 11078 * editfns.c (Fformat): Likewise.
1e69125e 11079 * syntax.c (skip_chars): Likewise.
3befa583 11080
e3019616
PE
11081 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
11082 This also lets GCC 4.6.0 generate slightly better loop code.
11083
becfa255
PE
11084 * callint.c (Fcall_interactively): <, not <=, for optimization.
11085 (Fcall_interactively): Count the number of arguments produced,
11086 not the number of arguments given. This is simpler and lets GCC
11087 4.6.0 generate slightly better code.
11088
dae0cd48
PE
11089 * ftfont.c: Distingish more carefully between FcChar8 and char.
11090 The previous code passed unsigned char * to a functions like
11091 strlen and xstrcasecmp that expect char *, which does not
11092 conform to the C standard.
11093 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
11094 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
11095 char * when the C standard requires it.
11096
76032d70
PE
11097 * keyboard.c (read_char): Remove unused var.
11098
eb3f1cc8
PE
11099 * eval.c: Port to Windows vsnprintf (Bug#8435).
11100 Include <limits.h>.
11101 (SIZE_MAX): Define if the headers do not.
11102 (verror): Do not give up if vsnprintf returns a negative count.
11103 Instead, grow the buffer. This ports to Windows vsnprintf, which
11104 does not conform to C99. Problem reported by Eli Zaretskii.
11105 Also, simplify the allocation scheme, by avoiding the need for
11106 calling realloc, and removing the ALLOCATED variable.
11107
70476b54
PE
11108 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
11109
12020a9e
PE
11110 Remove invocations of doprnt, as Emacs now uses vsnprintf.
11111 But keep the doprint source code for now, as we might revamp it
11112 and use it again (Bug#8435).
ea6c7ae6
PE
11113 * lisp.h (doprnt): Remove.
11114 * Makefile.in (base_obj): Remove doprnt.o.
11115 * deps.mk (doprnt.o): Remove.
11116
5fdb398c
PE
11117 error: Print 32- and 64-bit integers portably (Bug#8435).
11118 Without this change, on typical 64-bit hosts error ("...%d...", N)
11119 was used to print both 32- and 64-bit integers N, which relied on
11120 undefined behavior.
61bdb816 11121 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
11122 * lisp.h (error, verror): Mark as printf-like functions.
11123 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
11124 Report overflow in size calculations when allocating printf buffer.
11125 Do not truncate output string at its first null byte.
11126 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
11127 Truncate the output at a character boundary, since vsnprintf does not
11128 do that.
11129 * charset.c (check_iso_charset_parameter): Convert internal
11130 character to string before calling 'error', since %c now has the
11131 printf meaning.
11132 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
11133 overflow when computing char to be passed to 'error'. Do not
11134 pass Lisp_Object to 'error'; pass the integer instead.
11135 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
11136 formatted with plain %d.
11137
b189fa66
PE
11138 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
11139
bff87ef0
PE
11140 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
11141
7e2cac20
PE
11142 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
11143
ce4d90b5
PE
11144 * xterm.c (x_catch_errors): Remove duplicate declaration.
11145
266c9547
PE
11146 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
11147
79c49ad2
PE
11148 * xdisp.c, lisp.h (message_nolog): Remove; unused.
11149
368f4090
JM
111502011-04-10 Jim Meyering <meyering@redhat.com>
11151
11152 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
11153 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
11154 return ssize_t not "int", and use size_t as the buffer length.
11155 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
11156 * gnutls.h: Update declarations.
11157 * process.c (read_process_output): Use ssize_t, to match.
11158 (send_process): Likewise.
11159
a32d4040
CY
111602011-04-09 Chong Yidong <cyd@stupidchicken.com>
11161
11162 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
11163
8546720e 111642011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 11165
04f2d78b
CB
11166 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
11167 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 11168
8546720e
GM
11169 * xterm.c (handle_one_xevent):
11170 * xmenu.c (create_and_show_popup_menu):
11171 * xselect.c (x_decline_selection_request)
11172 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 11173
0a2f5c1a 111742011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
11175
11176 Fix some uses of `int' instead of EMACS_INT.
11177 * search.c (string_match_1, fast_string_match)
11178 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
11179 (scan_buffer, find_next_newline_no_quit)
11180 (find_before_next_newline, search_command, Freplace_match)
11181 (Fmatch_data): Make some `int' variables be EMACS_INT.
11182
11183 * xdisp.c (display_count_lines): 3rd argument and return value now
11184 EMACS_INT. All callers changed.
11185 (pint2hrstr): Last argument is now EMACS_INT.
11186
11187 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
11188 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
11189 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
11190 (decode_coding_utf_16, decode_coding_emacs_mule)
11191 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
11192 (decode_coding_ccl, decode_coding_charset)
11193 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
11194 (decode_coding_iso_2022, decode_coding_emacs_mule)
11195 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
11196 <char_offset, last_offset>: Declare EMACS_INT.
11197 (encode_coding_utf_8, encode_coding_utf_16)
11198 (encode_coding_emacs_mule, encode_invocation_designation)
11199 (encode_designation_at_bol, encode_coding_iso_2022)
11200 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
11201 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
11202 Declare EMACS_INT.
11203 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
11204 (encode_invocation_designation): Last argument P_NCHARS is now
11205 EMACS_INT.
11206 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
11207 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
11208
11209 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
11210 All users changed.
11211
11212 * ccl.c (Fccl_execute_on_string): Declare some variables
11213 EMACS_INT.
11214
8546720e 112152011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
11216
11217 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
11218
4e19a977
CS
112192011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
11220
11221 * process.c (Fformat_network_address): Doc fix.
11222
87302331
R
112232011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
11224
ee7683eb 11225 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 11226
cbb59342
CY
112272011-04-08 Chong Yidong <cyd@stupidchicken.com>
11228
11229 * keyboard.c (read_char): Call Lisp function help-form-show,
11230 instead of using internal_with_output_to_temp_buffer.
11231 (Qhelp_form_show): New var.
e0d38eeb 11232 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
11233
11234 * print.c (internal_with_output_to_temp_buffer): Function deleted.
11235
11236 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
11237
e67a13ab
CY
112382011-04-06 Chong Yidong <cyd@stupidchicken.com>
11239
04f2d78b
CB
11240 * process.c (Flist_processes): Remove to Lisp.
11241 (list_processes_1): Delete.
e67a13ab 11242
973f782d
EZ
112432011-04-06 Eli Zaretskii <eliz@gnu.org>
11244
7c106b1e
EZ
11245 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
11246
973f782d
EZ
11247 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
11248
41cf7d1a 112492011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 11250
ca23cc88
PE
11251 Fix more problems found by GCC 4.6.0's static checks.
11252
f390e2d5
PE
11253 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
11254
42eea0d0
PE
11255 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
11256
b69769da 11257 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 11258
f9541e84
PE
11259 * xdisp.c (vmessage): Mark as a printf-like function.
11260
13841b55
PE
11261 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
11262
c136c10f
PE
11263 * sound.c (sound_warning): Don't crash if arg contains a printf format.
11264
5e2d4a30
PE
11265 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
11266 printf-like functions.
11267 (tiff_load): Add casts to remove these marks before passing them
11268 to system-supplied API.
11269
583f48b9
PE
11270 * eval.c (Fsignal): Remove excess argument to 'fatal'.
11271
b25d760e
PE
11272 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
11273 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
11274 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
11275 directly, rather than having caller test rule sign. This avoids
11276 some unnecessary tests.
11277 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
11278 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
11279 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 11280
bc7b6697 11281 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 11282 (xfont_open): Avoid unnecessary tests.
bc7b6697 11283
27ccc379
PE
11284 * composite.c (composition_gstring_put_cache): Use unsigned integer.
11285
dcd5c89a
PE
11286 * composite.h, composite.c (composition_gstring_put_cache):
11287 Use EMACS_INT, not int, for length.
11288
b13a45c6
PE
11289 * composite.h (COMPOSITION_DECODE_REFS): New macro,
11290 breaking out part of COMPOSITION_DECODE_RULE.
11291 (COMPOSITION_DECODE_RULE): Use it.
11292 * composite.c (get_composition_id): Remove unused local vars,
11293 by using the new macro.
11294
1e792e4d
PE
11295 * textprop.c (set_text_properties_1): Change while to do-while,
11296 since the condition is always true at first.
11297
dc6c6455 11298 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
11299 (interval_deletion_adjustment): Return unsigned value.
11300 All uses changed.
dc6c6455 11301
aba7731a
PE
11302 * process.c (list_processes_1, create_pty, read_process_output):
11303 (exec_sentinel): Remove vars that were set but not used.
afd4052b 11304 (create_pty): Remove unnecessary "volatile"s.
bc57d757 11305 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 11306 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 11307 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 11308
fdfc4bf3
PE
11309 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
11310
fca8fe46 11311 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 11312 (update_syntax_table): Use unsigned instead of int.
fca8fe46 11313
06a0259a 11314 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 11315 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 11316 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 11317
e7b9e80f
PE
11318 * print.c (print_error_message): Avoid int overflow.
11319
56201685
PE
11320 * font.c (font_list_entities): Redo for clarity,
11321 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
11322
78834453 11323 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 11324 (font_score): Avoid potential overflow in diff calculation.
78834453 11325
0bc0b309 11326 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 11327 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 11328
e610eaca
PE
11329 * eval.c (funcall_lambda): Rename local to avoid shadowing.
11330
b895abce
PE
11331 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
11332 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
11333 can always succeed if overflow has undefined behavior.
11334
1f1d9321 11335 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 11336 (wordify): Omit three unnecessary tests.
1f1d9321 11337
c59478bc
PE
11338 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
11339 All callers changed. This avoids the need for an unused var.
11340
79b73827
PE
11341 * casefiddle.c (casify_region): Remove var that is set but not used.
11342
a4db5dfe
PE
11343 * dired.c (file_name_completion): Remove var that is set but not used.
11344
43aae36e
PE
11345 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
11346
2a47c44d 11347 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 11348 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 11349
a37c69bf
PE
11350 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
11351 Check for integer overflow on size calculations.
11352
328ab8e7
PE
11353 * buffer.c (Fprevious_overlay_change): Remove var that is set
11354 but not used.
11355
e5a2a5cb
PE
11356 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
11357 Remove vars that are set but not used.
8d84a6eb 11358 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 11359 (timer_check_2): Mark vars as initialized.
e5a2a5cb 11360
a60e5f68
PE
11361 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
11362
f661cb61 11363 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 11364 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 11365
f0397f5a
PE
11366 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
11367 that are set but not used.
11368
8664db06 11369 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 11370 if XCreateBitmapFromData fails (Bug#8410).
8664db06 11371
6abdaa4a
PE
11372 * xselect.c (x_get_local_selection, x_handle_property_notify):
11373 Remove vars that are set but not used.
11374
0ce7538d 11375 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 11376 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 11377
9ae848fc
PE
11378 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
11379 Remove var that is set but not used.
0b918413
PE
11380 (scroll_bar_windows_size): Now size_t, not int.
11381 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
11382 Check for overflow.
9ae848fc 11383
a5a62657
PE
11384 * xfaces.c (realize_named_face): Remove vars that are set but not used.
11385 (map_tty_color) [!defined MSDOS]: Likewise.
11386
5c5cdd39
PE
11387 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
11388
66ebf983
PE
11389 * coding.c: Remove vars that are set but not used.
11390 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
11391 All callers changed.
11392 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
11393 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
11394 (decode_coding_charset): Remove vars that are set but not used.
11395
1be4d761
PE
11396 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
11397 that is set but not used.
11398
47553fa8
PE
11399 * print.c (print_object): Remove var that is set but not used.
11400
1f7196bf 11401 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
11402 The gnulib version avoids calling malloc in the usual case,
11403 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
11404 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
11405 * filelock.c (current_lock_owner): Likewise.
11406 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
11407 * sysdep.c: Include allocator.h, careadlinkat.h.
11408 (emacs_no_realloc_allocator): New static constant.
11409 (emacs_readlink): New function.
fdb61804
PE
11410 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
11411 ../lib/careadlinkat.h.
d1fdcab7 11412
f84c17c7
SM
114132011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
11414
11415 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
11416 first non-nil return value).
11417
ef3862ad
JD
114182011-04-03 Jan Djärv <jan.h.d@swipnet.se>
11419
11420 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
11421 if not defined (Bug#8403).
11422
376a7006
JB
114232011-04-02 Juanma Barranquero <lekktu@gmail.com>
11424
11425 * xdisp.c (display_count_lines): Remove parameter `start',
11426 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11427 (get_char_face_and_encoding): Remove parameter `multibyte_p',
11428 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11429 (fill_stretch_glyph_string): Remove parameters `row' and `area',
11430 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
11431 and thereabouts. All callers changed.
11432 (get_per_char_metric): Remove parameter `f', unused since
11433 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11434
6ca3801d
JM
114352011-04-02 Jim Meyering <meyering@redhat.com>
11436
11437 do not dereference NULL upon failed strdup
11438 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
11439 (ns_get_family): Likewise.
11440
d8e2b5ba
JB
114412011-04-02 Juanma Barranquero <lekktu@gmail.com>
11442
11443 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
11444
8c74fcbd
JD
114452011-04-02 Jan Djärv <jan.h.d@swipnet.se>
11446
11447 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
11448 later (Bug#8403).
11449
7200d79c
SM
114502011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
11451
03408648 11452 Add lexical binding.
7200d79c 11453
03408648
SM
11454 * window.c (Ftemp_output_buffer_show): New fun.
11455 (Fsave_window_excursion):
11456 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
11457
11458 * lread.c (lisp_file_lexically_bound_p): New function.
11459 (Fload): Bind Qlexical_binding.
11460 (readevalloop): Remove `evalfun' arg.
11461 Bind Qinternal_interpreter_environment.
11462 (Feval_buffer): Bind Qlexical_binding.
11463 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
11464 Mark as dynamic.
11465 (syms_of_lread): Declare `lexical-binding'.
11466
11467 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
11468
11469 * keyboard.c (eval_dyn): New fun.
11470 (menu_item_eval_property): Use it.
ca105506
SM
11471
11472 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 11473
03408648
SM
11474 * fns.c (concat, mapcar1): Accept byte-code-functions.
11475
11476 * eval.c (Fsetq): Handle lexical vars.
11477 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
11478 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
11479 (FletX, Flet): Obey lexical binding.
11480 (Fcommandp): Handle closures.
11481 (Feval): New `lexical' arg.
11482 (eval_sub): New function extracted from Feval. Use it almost
11483 everywhere where Feval was used. Look up vars in lexical env.
11484 Handle closures.
11485 (Ffunctionp): Move from subr.el.
11486 (Ffuncall): Handle closures.
11487 (apply_lambda): Remove `eval_flags'.
11488 (funcall_lambda): Handle closures and new byte-code-functions.
11489 (Fspecial_variable_p): New function.
11490 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
11491 but without exporting it to Lisp.
23aba0ea 11492
23aba0ea 11493 * doc.c (Fdocumentation, store_function_docstring):
03408648 11494 * data.c (Finteractive_form): Handle closures.
23aba0ea 11495
03408648
SM
11496 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
11497 interactive spec.
ba83908c 11498
04f2d78b
CB
11499 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
11500 New byte-codes.
03408648
SM
11501 (exec_byte_code): New function extracted from Fbyte_code to handle new
11502 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 11503
03408648 11504 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 11505
03408648 11506 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 11507
e2abce01
JB
115082011-03-31 Juanma Barranquero <lekktu@gmail.com>
11509
11510 * xdisp.c (redisplay_internal): Fix prototype.
11511
63696a73 115122011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 11513
63696a73 11514 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
11515 (try_scrolling): Use it when setting scroll_limit.
11516 Limit scrolling to 100 screen lines.
63696a73
EZ
11517 (redisplay_window): Even when falling back on "recentering",
11518 position point in the window according to scroll-conservatively,
11519 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
11520
11521 (try_scrolling): When point is above the window, allow searching
11522 as far as scroll_max, or one screenful, to compute vertical
11523 distance from PT to the scroll margin position. This prevents
11524 try_scrolling from unnecessarily failing when
11525 scroll-conservatively is set to a value slightly larger than the
11526 window height. Clean up the case of PT below the margin at bottom
11527 of window: scroll_max can no longer be INT_MAX. When aggressive
11528 scrolling is in use, don't let point enter the opposite scroll
11529 margin as result of the scroll.
11530 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
11531 threshold of 100 lines for never-recentering scrolling.
11532
e4cc2dfc
JB
115332011-03-31 Juanma Barranquero <lekktu@gmail.com>
11534
11535 * dispextern.h (move_it_by_lines):
11536 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
11537 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
11538 (message_log_check_duplicate): Remove parameters `prev_bol' and
11539 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11540 (redisplay_internal): Remove parameter `preserve_echo_area',
11541 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
11542
11543 * indent.c (Fvertical_motion):
11544 * window.c (window_scroll_pixel_based, Frecenter):
11545 Don't pass `need_y_p' to `move_it_by_lines'.
11546
1c470562
SM
115472011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
11548
44f230aa
SM
11549 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
11550 steal a few bits to be more compact.
11551 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
11552 Remove unneeded casts.
11553
1c470562
SM
11554 * bytecode.c (Fbyte_code): CAR and CDR can GC.
11555
888adce9
ZK
115562011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
11557
11558 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
11559 binding" message (bug#7967).
11560
f838ed7b
PE
115612011-03-30 Paul Eggert <eggert@cs.ucla.edu>
11562
77861b95
PE
11563 Fix more problems found by GCC 4.6.0's static checks.
11564
de6dbc14
PE
11565 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
11566 Remove unused local var.
11567
f838ed7b
PE
11568 * editfns.c (Fmessage_box): Remove unused local var.
11569
792c7b2b
PE
11570 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
11571 (note_mode_line_or_margin_highlight, note_mouse_highlight):
11572 Omit unused local vars.
c499e557 11573 * window.c (shrink_windows): Omit unused local var.
b01a1c29 11574 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
11575 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
11576 Omit unused local var.
11577
ba0165e1
PE
11578 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
11579 Don't assume string length fits in int.
32ad8845 11580 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 11581 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 11582
3c59b4c9
PE
11583 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
11584 instead of alloca (Bug#8344).
11585
a3eed478 11586 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 11587 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 11588
eb4d412d
PE
11589 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
11590
1658b401
PE
11591 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
11592 concerns.
11593
11594 * term.c (produce_glyphless_glyph): Remove unnecessary test.
11595
11596 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 11597
9a2c6e05
PE
11598 * keyboard.c (syms_of_keyboard): Use the same style as later
11599 in this function when indexing through an array. This also
11600 works around GCC bug 48267.
11601
03d0a109
PE
11602 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
11603
44f730c8
PE
11604 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
11605
fe75f926
PE
11606 * chartab.c (sub_char_table_ref_and_range): Redo for slight
11607 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
11608
ffa8c828
PE
11609 * keyboard.c, keyboard.h (num_input_events): Now size_t.
11610 This avoids undefined behavior on integer overflow, and is a bit
11611 more convenient anyway since it is compared to a size_t variable.
11612
c5101a77
PE
11613 Variadic C functions now count arguments with size_t, not int.
11614 This avoids an unnecessary limitation on 64-bit machines, which
11615 caused (substring ...) to crash on large vectors (Bug#8344).
11616 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
11617 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 11618 All variadic functions and their callers changed accordingly.
c5101a77
PE
11619 (struct gcpro.nvars): Now size_t, not int. All uses changed.
11620 * data.c (arith_driver, float_arith_driver): Likewise.
11621 * editfns.c (general_insert_function): Likewise.
11622 * eval.c (struct backtrace.nargs, interactive_p)
11623 (internal_condition_case_n, run_hook_with_args, apply_lambda)
11624 (funcall_lambda, mark_backtrace): Likewise.
11625 * fns.c (concat): Likewise.
11626 * frame.c (x_set_frame_parameters): Likewise.
11627 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
11628 0 if not found, not -1. All callers changed.
11629
dd3f25f7
PE
11630 * alloc.c (garbage_collect): Don't assume stack size fits in int.
11631 (stack_copy_size): Now size_t, not int.
11632 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
11633
461c2ab9
JB
116342011-03-28 Juanma Barranquero <lekktu@gmail.com>
11635
11636 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
11637 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11638 All callers changed.
11639
11640 * lisp.h (multibyte_char_to_unibyte):
11641 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
11642 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11643 * character.h (CHAR_TO_BYTE8):
11644 * cmds.c (internal_self_insert):
11645 * editfns.c (general_insert_function):
11646 * keymap.c (push_key_description):
11647 * search.c (Freplace_match):
11648 * xdisp.c (message_dolog, set_message_1): All callers changed.
11649
f6d62986
SM
116502011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
11651
11652 * keyboard.c (safe_run_hook_funcall): New function.
11653 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
11654 don't set the hook to nil, but remove the offending function instead.
11655 (Qcommand_hook_internal): Remove, unused.
11656 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
11657 Vcommand_hook_internal.
11658
11659 * eval.c (enum run_hooks_condition): Remove.
11660 (funcall_nil, funcall_not): New functions.
11661 (run_hook_with_args): Call each function through a `funcall' argument.
11662 Remove `cond' argument, now redundant.
11663 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
11664 (Frun_hook_with_args_until_failure): Adjust accordingly.
11665 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
11666
1db5b1ad
JB
116672011-03-28 Juanma Barranquero <lekktu@gmail.com>
11668
11669 * dispextern.h (string_buffer_position): Remove declaration.
11670
11671 * print.c (strout): Remove parameter `multibyte', unused since
11672 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
11673
11674 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
11675 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
11676 All callers changed.
11677
11678 * w32.c (_wsa_errlist): Use braces for struct initializers.
11679
11680 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
11681 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
11682 All callers changed.
11683 (string_buffer_position): Likewise. Also, make static (it's never
11684 used outside xdisp.c).
11685 (cursor_row_p): Remove parameter `w', unused since
11686 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
11687 (decode_mode_spec): Remove parameter `precision', introduced during
11688 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
11689 All callers changed.
11690
5ffb62aa
JD
116912011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11692
11693 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
11694
461c2ab9 116952011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
11696
11697 * nsterm.m (ns_menu_bar_is_hidden): New variable.
11698 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
11699 (ns_update_auto_hide_menu_bar): New functions.
11700 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
11701 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
11702 ns_constrain_all_frames.
11703 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
11704 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
11705
5c380ffb
JD
117062011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11707
11708 * nsmenu.m (runDialogAt): Remove argument to timer_check.
11709
9af30bdf
GM
117102011-03-27 Glenn Morris <rgm@gnu.org>
11711
11712 * syssignal.h: Replace RETSIGTYPE with void.
11713 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
11714 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
11715 Replace SIGTYPE with void everywhere.
11716 * s/usg5-4-common.h (SIGTYPE): Remove definition.
11717 * s/template.h (SIGTYPE): Remove commented out definition.
11718
e2abce01
JB
117192011-03-26 Eli Zaretskii <eliz@gnu.org>
11720
11721 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
11722 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
11723
f868cd8a
JB
117242011-03-26 Juanma Barranquero <lekktu@gmail.com>
11725
59eb0929
JB
11726 * w32.c (read_unc_volume): Use parameter `henum', instead of
11727 global variable `wget_enum_handle'.
11728
11729 * keymap.c (describe_vector): Remove parameters `indices' and
11730 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
11731 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
11732
f868cd8a
JB
11733 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
11734
11735 * keyboard.c (timer_check): Remove parameter `do_it_now',
11736 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
11737 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
11738 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
11739
11740 * keyboard.c (read_char):
11741 * w32menu.c (w32_menu_display_help):
11742 * xmenu.c (show_help_event, menu_help_callback):
11743 Adjust calls to `show_help_echo'.
11744
11745 * gtkutil.c (xg_maybe_add_timer):
11746 * keyboard.c (readable_events):
11747 * process.c (wait_reading_process_output):
11748 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
11749
11750 * insdel.c (adjust_markers_gap_motion):
11751 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
11752 (gap_left, gap_right): Don't call it.
11753
2ecf6fdb
CY
117542011-03-25 Chong Yidong <cyd@stupidchicken.com>
11755
11756 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
11757 incurred during fontification.
11758
6b1f9ba4
JB
117592011-03-25 Juanma Barranquero <lekktu@gmail.com>
11760
11761 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
11762 (DEFVAR_PER_BUFFER): Don't pass it.
11763
11764 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
11765 (scrolling_window): Don't pass it.
11766
0f4a96b5
JB
117672011-03-25 Juanma Barranquero <lekktu@gmail.com>
11768
11769 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
11770
11771 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
11772 and `suffix'.
11773 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
11774 of variables specific to SELinux and computation of `encoded_absname'.
11775
11776 * image.c (XPutPixel): Remove unused variable `height'.
11777
11778 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
11779
11780 * unexw32.c (get_section_info): Remove unused variable `section'.
11781
11782 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
11783 (system_process_attributes): Remove unused variable `sess'.
11784 (sys_read): Remove unused variable `err'.
11785
11786 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
11787 (w32_wnd_proc): Remove unused variable `isdead'.
11788 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
11789 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
11790 (x_create_tip_frame): Remove unused variable `tem'.
11791
11792 * w32inevt.c (w32_console_read_socket):
11793 Remove unused variable `no_events'.
11794
11795 * w32term.c (x_draw_composite_glyph_string_foreground):
11796 Remove unused variable `width'.
11797
1149507c
JB
117982011-03-24 Juanma Barranquero <lekktu@gmail.com>
11799
11800 * w32term.c (x_set_glyph_string_clipping):
11801 Don't pass uninitialized region to CombineRgn.
11802
9c88f339
JB
118032011-03-23 Juanma Barranquero <lekktu@gmail.com>
11804
11805 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
11806 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
11807 (Fx_close_connection): Remove unused variable `i'.
11808
11809 * w32font.c (w32font_draw): Return number of glyphs.
11810 (w32font_open_internal): Remove unused variable `i'.
11811 (w32font_driver): Add missing initializer.
11812
11813 * w32menu.c (utf8to16): Remove unused variable `utf16'.
11814 (fill_in_menu): Remove unused variable `items_added'.
11815
11816 * w32term.c (last_mouse_press_frame): Remove static global variable.
11817 (w32_clip_to_row): Remove unused variable `f'.
11818 (x_delete_terminal): Remove unused variable `i'.
11819
11820 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
11821 (NOTHING): Remove unused static global variable.
11822 (uniscribe_check_otf): Remove unused variable `table'.
11823 (uniscribe_font_driver): Add missing initializers.
11824
dee091a3
JD
118252011-03-23 Julien Danjou <julien@danjou.info>
11826
11827 * term.c (Fsuspend_tty, Fresume_tty):
11828 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
11829 * window.c (temp_output_buffer_show):
11830 * insdel.c (signal_before_change):
11831 * frame.c (Fhandle_switch_frame):
11832 * fileio.c (Fdo_auto_save):
11833 * emacs.c (Fkill_emacs):
11834 * editfns.c (save_excursion_restore):
11835 * cmds.c (internal_self_insert):
11836 * callint.c (Fcall_interactively):
11837 * buffer.c (Fkill_all_local_variables):
11838 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
11839 Use Frun_hooks.
0f4a96b5 11840 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 11841 unconditionally since it does the check itself.
dee091a3 11842
2c520ab5 118432011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 11844
c9c49752
PE
11845 Fix more problems found by GCC 4.5.2's static checks.
11846
8abc3f12
PE
11847 * coding.c (encode_coding_raw_text): Avoid unnecessary test
11848 the first time through the loop, since we know p0 < p1 then.
11849 This also avoids a gcc -Wstrict-overflow warning.
11850
a2d26660
PE
11851 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
11852 leading to a memory leak, possible in functions like
11853 load_charset_map_from_file that can allocate an unbounded number
b12ef411 11854 of objects (Bug#8318).
a2d26660 11855
916c72e9
PE
11856 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
11857 that could (at least in theory) be that large.
11858
19ab8a18
PE
11859 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
11860 This is less likely to overflow, and avoids undefined behavior if
11861 overflow does occur. All callers changed. Use strtoul to scan
11862 for the unsigned long integer.
b7cbbd6f
PE
11863 (pint2hrstr): Simplify and tune code slightly.
11864 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 11865
f0641eff
PE
11866 * scroll.c (do_scrolling): Work around GCC bug 48228.
11867 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
11868
7f650bb9
PE
11869 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
11870 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
11871 (validate_x_resource_name): Simplify count usage.
11872 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 11873
37dd57d1
PE
11874 * fileio.c (Fcopy_file): Report error if fchown or fchmod
11875 fail (Bug#8306).
81e56e61 11876
699979fc 11877 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 11878
401bf9b4
PE
11879 * process.c (Fmake_network_process): Use socklen_t, not int,
11880 where POSIX says socklen_t is required in portable programs.
11881 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 11882 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
11883 (Fmake_network_process, server_accept_connection):
11884 (wait_reading_process_output, read_process_output):
11885 Likewise.
11886
b93aacde
PE
11887 * process.c: Rename or move locals to avoid shadowing.
11888 (list_processes_1, Fmake_network_process):
11889 (read_process_output_error_handler, exec_sentinel_error_handler):
11890 Rename or move locals.
4dc343ee 11891 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 11892 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 11893 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 11894 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 11895 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 11896
af8a867c 11897 Make tparam.h and terminfo.c consistent.
44f230aa
SM
11898 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
11899 Include tparam.h instead, since it declares them.
af8a867c
PE
11900 * cm.h (PC): Remove extern decl; tparam.h now does this.
11901 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
11902 * terminfo.c: Include tparam.h, to check interfaces.
11903 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
11904 (tparam): Adjust signature to match interface in tparam.h;
11905 this removes some undefined behavior. Check that outstring and len
11906 are zero, which they always are with Emacs.
11907 * tparam.h (PC, BC, UP): New extern decls.
11908
0248044d 11909 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 11910 (xftfont_open): Rename locals to avoid shadowing.
0248044d 11911
8ff096c1 11912 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
11913 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
11914 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 11915 (ftfont_list): Remove unused local.
49eaafba
PE
11916 (get_adstyle_property, ftfont_pattern_entity):
11917 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
11918 Rename locals to avoid shadowing.
8ff096c1 11919
e2be39f6
PE
11920 * xfont.c (xfont_list_family): Mark var as initialized.
11921
c9735e30
PE
11922 * xml.c (make_dom): Now static.
11923
8f5201ae
PE
11924 * composite.c (composition_compute_stop_pos): Rename local to
11925 avoid shadowing.
b246f932
PE
11926 (composition_reseat_it): Remove unused locals.
11927 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 11928 (composition_update_it): Mark var as initialized.
11b61122
PE
11929 (find_automatic_composition): Mark vars as initialized,
11930 with a FIXME (Bug#8290).
8f5201ae 11931
760fbc2c
PE
11932 character.h: Rename locals to avoid shadowing.
11933 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
11934 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
11935 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
11936 (BUF_DEC_POS): Be more systematic about renaming local temporaries
11937 to avoid shadowing.
11938
ff08eb85
PE
11939 * textprop.c (property_change_between_p): Remove; unused.
11940
fc7bf025
PE
11941 * intervals.c (interval_start_pos): Now static.
11942
235d7abc
PE
11943 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
11944
44f230aa
SM
11945 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
11946 Rename locals to avoid shadowing.
3e7d6594 11947
50060332
PE
11948 * sound.c (wav_play, au_play, Fplay_sound_internal):
11949 Fix pointer signedness.
d01f234b 11950 (alsa_choose_format): Remove unused local var.
c83b8872
PE
11951 (wav_play): Initialize a variable to 0, to prevent undefined
11952 behavior (Bug#8278).
50060332 11953
c4fc4e30
PE
11954 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
11955
918436ed
PE
11956 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
11957
c939f91b
PE
11958 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
11959 clobbering (Bug#8298).
b9c7f648
PE
11960 * sysdep.c (sys_subshell): Likewise.
11961 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 11962
6bd8c144
PE
11963 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
11964 This should get cleaned up, so that child_setup has the
11965 same signature on all platforms.
11966
7710357c 11967 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 11968 (relocate_fd): Rename locals to avoid shadowing.
7710357c 11969
c59da222
CY
119702011-03-22 Chong Yidong <cyd@stupidchicken.com>
11971
11972 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
11973 not to be necessary, and produces flickering.
11974
66b87493
GM
119752011-03-20 Glenn Morris <rgm@gnu.org>
11976
11977 * config.in: Remove file.
11978
45b6f6d5
JB
119792011-03-20 Juanma Barranquero <lekktu@gmail.com>
11980
11981 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
11982 are now in src/globals.h.
11983 (syms_of_minibuf): Remove spurious & from previous change.
11984
cd394be1 119852011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
11986
11987 * minibuf.c (completing-read-function): New variable.
11988 (completing-read-default): Rename from completing-read.
11989 (completing-read): Call completing-read-function.
11990
b14e3e21
CY
119912011-03-19 Juanma Barranquero <lekktu@gmail.com>
11992
11993 * xfaces.c (Fx_load_color_file):
11994 Read color file from absolute filename (bug#8250).
11995
f2b726e6
JB
119962011-03-19 Juanma Barranquero <lekktu@gmail.com>
11997
11998 * makefile.w32-in: Update dependencies.
11999
09f6ff02
EZ
120002011-03-17 Eli Zaretskii <eliz@gnu.org>
12001
12002 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
12003
29a6015a
PE
120042011-03-17 Paul Eggert <eggert@cs.ucla.edu>
12005
a3a6c54e
PE
12006 Fix more problems found by GCC 4.5.2's static checks.
12007
b766f867
PE
12008 * process.c (make_serial_process_unwind, send_process_trap):
12009 (sigchld_handler): Now static.
12010
be02381c
PE
12011 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
12012 That way, the code declares only the vars that it needs.
12013 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
12014 * s/cygwin.h (PTY_ITERATION): Likewise.
12015 * s/darwin.h (PTY_ITERATION): Likewise.
12016 * s/gnu-linux.h (PTY_ITERATION): Likewise.
12017
57048744
PE
12018 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
12019 * process.c (allocate_pty): Don't declare stb unless it's needed.
12020
7914961c 12021 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
12022 (CONSTANTLIM): Remove; unused.
12023 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
12024 Define only if needed.
7914961c 12025
b3967b18
PE
12026 * unexelf.c (unexec): Name an expression,
12027 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
12028 Use a different way to cause a compilation error if anyone uses
12029 n rather than nn, a way that does not involve shadowing.
73366a00 12030 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 12031
29a6015a
PE
12032 * deps.mk (unexalpha.o): Remove; unused.
12033
43cfc33e 12034 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 12035 * unexec.h: New file.
ce701a33
PE
12036 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
12037 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
12038 Depend on unexec.h.
12039 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
12040 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
12041 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 12042 Change as necessary to match prototype in unexec.h.
ce701a33 12043
01f44d5a
PE
12044 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
12045 shadowing.
4f63c6bb 12046 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 12047
a6670b0b
PE
12048 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
12049 Rename locals to avoid shadowing.
12050
cef2010d 12051 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 12052 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 12053
d4d7173a
PE
12054 * print.c (Fredirect_debugging_output): Fix pointer signedess.
12055
f08b802a
PE
12056 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
12057 warning when compiling print.c.
12058
3ddb0639
PE
12059 * font.c (font_unparse_fcname): Abort in an "impossible" situation
12060 instead of using an uninitialized var.
5ad03b97 12061 (font_sort_entities): Mark var as initialized.
3ddb0639 12062
170a2692
PE
12063 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
12064
e663c700
PE
12065 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
12066 pointers to constants.
89bc529a 12067 (font_parse_fcname): Remove unused vars.
7b81e2d0 12068 (font_delete_unmatched): Now static.
ea838e10 12069 (font_get_spec): Remove; unused.
13a547c6
PE
12070 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
12071 (font_update_drivers, Ffont_get_glyphs, font_add_log):
12072 Rename or move locals to avoid shadowing.
e663c700 12073
2a80c887 12074 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 12075 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 12076
1384fa33 12077 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 12078 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 12079
8b2c52e9
PE
12080 * alloc.c (mark_backtrace): Move decl from here ...
12081 * lisp.h: ... to here, so that it can be checked.
12082
475545b5 12083 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 12084 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
12085 (lisp_indirect_variable): Name an expression,
12086 to avoid gcc -Wbad-function-cast warning.
1faed8ae 12087 (Fdefvar): Rename locals to avoid shadowing.
475545b5 12088
b1349114 12089 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 12090 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 12091 Use const pointer when appropriate.
b1349114 12092
a2928364
PE
12093 * lisp.h (get_system_name, get_operating_system_release):
12094 Move decls here, to check interfaces.
12095 * process.c (get_operating_system_release): Move decl to lisp.h.
12096 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
12097 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
12098 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
12099 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
12100 (Fformat_time_string, Fencode_time, Finsert_char):
12101 (Ftranslate_region_internal, Fformat):
12102 Rename or remove local vars to avoid shadowing.
9710023e 12103 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 12104
a415e694
PE
12105 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
12106 avoid shadowing.
12107
8ef4622d
PE
12108 * lisp.h (eassert): Check that the argument compiles, even if
12109 ENABLE_CHECKING is not defined.
12110
946f9a5b
PE
12111 * data.c (Findirect_variable): Name an expression, to avoid
12112 gcc -Wbad-function-cast warning.
112396d6 12113 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 12114 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
12115 (Fmake_variable_buffer_local, Fmake_local_variable):
12116 Mark variables as initialized.
52746918 12117 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 12118
e5aab7e7 12119 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
12120 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
12121 Rename locals to avoid shadowing.
dff45157
PE
12122 (mark_stack): Move local variables into the #ifdef region where
12123 they're used.
7bc26fdb
PE
12124 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
12125 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
12126 needed otherwise.
12127 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
12128 (GC_STRING_CHARS): Remove; not used.
d40d4be1 12129 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 12130
e5aab7e7
PE
12131 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
12132 avoids undefined behavior in theory.
12133
4da60324
PE
12134 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
12135
88043301
PE
12136 Use functions, not macros, for up- and down-casing (Bug#8254).
12137 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12138 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
12139 to use the following functions instead of these macros.
12140 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
12141 EMACS_INT, since callers assume the returned value fits in int.
12142 (upcase1): Likewise, for UPCASE_TABLE.
12143 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 12144 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 12145 the race-condition problem in the old DOWNCASE.
88043301 12146
19ed5445
PE
12147 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
12148 Rename locals to avoid shadowing.
12149 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
12150 (regex_compile, re_search_2, re_match_2_internal):
12151 Remove unused local vars.
952db0d7
PE
12152 (FREE_VAR): Rewrite so as not to use empty "else",
12153 which gcc can warn about.
da053e48 12154 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
12155 (RETALLOC_IF): Define only if needed.
12156 (WORDCHAR_P): Likewise. This one is never needed, but is used
12157 only in a comment talking about a compiler bug, so put inside
12158 the #if 0 of that comment.
12159 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
12160 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
12161 Remove; unused.
19ed5445 12162
1f3561e4 12163 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
12164 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
12165 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 12166
ded6f8f7
PE
12167 * search.c (simple_search): Remove unused var.
12168
dbd37a95
PE
12169 * dired.c (compile_pattern): Move decl from here ...
12170 * lisp.h: ... to here, so that it can be checked.
12171 (struct re_registers): New forward decl.
12172
7e47afad
PE
12173 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
12174
85f24f61
PE
12175 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
12176 All uses changed.
12177 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
12178 Rename locals to avoid shadowing.
5671df8f 12179 (Fvertical_motion): Mark locals as initialized.
85f24f61 12180
181aa2be 12181 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 12182 (casify_region): Mark local as initialized.
181aa2be 12183
930d429c
PE
12184 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
12185
7082eac6
PE
12186 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
12187 New macros, so that the caller can use some names other than
12188 gcpro1, gcpro2, etc.
12189 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
12190 of the new macros.
12191 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
12192 argument, for consistency with GCPRO2_VAR, etc: it is now the
12193 prefix of the variable, not the variable itself. All uses
12194 changed.
38b2c076
PE
12195 * dired.c (directory_files_internal, file_name_completion):
12196 Rename locals to avoid shadowing.
12197
15206ed9
PE
12198 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
12199 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
12200 dired.c's scmp function, had undefined behavior.
12201 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12202 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
12203 * buffer.h: ... to here, because these macros use current_buffer,
12204 and the new implementation with inline functions needs to have
12205 current_buffer in scope now, rather than later when the macros
12206 are used.
12207 (downcase, upcase1): New static inline functions.
12208 (DOWNCASE, UPCASE1): Reimplement using these functions.
12209 This avoids undefined behavior in expressions like
12210 DOWNCASE (x) == DOWNCASE (y), which previously suffered
12211 from race conditions in accessing the global variables
12212 case_temp1 and case_temp2.
12213 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
12214 * lisp.h (case_temp1, case_temp2): Remove their decls.
12215 * character.h (ASCII_CHAR_P): Move from here ...
12216 * lisp.h: ... to here, so that the inline functions mentioned
12217 above can use them.
12218
4a6bea26
PE
12219 * dired.c (directory_files_internal_unwind): Now static.
12220
f14b7e14
PE
12221 * fileio.c (file_name_as_directory, directory_file_name):
12222 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
12223 Now static.
2893f146
PE
12224 (file_name_as_directory): Use const pointers when appropriate.
12225 (Fexpand_file_name): Likewise. In particular, newdir might
12226 point at constant storage, so make it a const pointer.
fd4ead52 12227 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
12228 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
12229 signedness issues.
f839df0c
PE
12230 (Fset_file_times, Finsert_file_contents, auto_save_error):
12231 Rename locals to avoid shadowing.
f14b7e14 12232
5716756e 12233 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
12234 (Ftry_completion, Fall_completions): Rename or remove locals
12235 to avoid shadowing.
5716756e 12236
b4c3046a
PE
12237 * marker.c (bytepos_to_charpos): Remove; unused.
12238
b45db522
PE
12239 * lisp.h (verify_bytepos, count_markers): New decls,
12240 so that gcc does not warn that these functions aren't declared.
12241
85876d07
PE
12242 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
12243 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 12244 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 12245 (copy_text): Remove unused local var.
85876d07 12246
03d78a21 12247 * filelock.c (within_one_second): Now static.
b3dd38ab 12248 (lock_file_1): Rename local to avoid shadowing.
03d78a21 12249
5df8f01b
PE
12250 * buffer.c (fix_overlays_before): Mark locals as initialized.
12251 (fix_start_end_in_overlays): Likewise. This function should be
12252 simplified by using pointers-to-pointers, but that's a different
12253 matter.
b1d876f1 12254 (switch_to_buffer_1): Now static.
8f54f30a
PE
12255 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
12256 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 12257
a70072c9 12258 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 12259 Fix pointer signedness issue.
edced198
PE
12260 (sys_subshell): Mark local as volatile if checking for lint,
12261 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 12262 (MAXPATHLEN): Define only if needed.
a70072c9 12263
a0977c44
PE
12264 * process.c (serial_open, serial_configure): Move decls from here ...
12265 * systty.h: ... to here, so that they can be checked.
12266
a884fdcc
PE
12267 * fns.c (get_random, seed_random): Move extern decls from here ...
12268 * lisp.h: ... to here, so that they can be checked.
12269
604efe86 12270 * sysdep.c (reset_io): Now static.
b8950c94 12271 (wait_for_termination_signal): Remove; unused.
604efe86 12272
38fc62d9
PE
12273 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
12274 (copy_keymap_item, append_key, push_text_char_description):
12275 Now static.
1004a21a 12276 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 12277 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
12278 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
12279 (describe_map_tree):
12280 Rename locals to avoid shadowing.
38fc62d9 12281
2f2650da
PE
12282 * keyboard.c: Declare functions static if they are not used elsewhere.
12283 (echo_char, echo_dash, cmd_error, top_level_2):
12284 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
12285 (read_char, kbd_buffer_get_event, make_lispy_position):
12286 (make_lispy_event, make_lispy_movement, apply_modifiers):
12287 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
12288 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
12289 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 12290 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 12291 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 12292
a053e86c 12293 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
12294 (mark_kboards): Move decl here ...
12295 * alloc.c (mark_kboards): ... from here.
a053e86c 12296
4752793e
PE
12297 * lisp.h (force_auto_save_soon): New decl.
12298
74f10ca7 12299 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
12300 (DEFINE_DUMMY_FUNCTION): New macro.
12301 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
12302 Use it.
c03cd23f
PE
12303 (main): Add casts to avoid warnings
12304 if GCC considers string literals to be constants.
74f10ca7 12305
022e70d4
PE
12306 * lisp.h (fatal_error_signal): Add decl, since it's exported.
12307
59d6fe83
PE
12308 * dbusbind.c: Pointer signedness fixes.
12309 (xd_signature, xd_append_arg, xd_initialize):
12310 (Fdbus_call_method, Fdbus_call_method_asynchronously):
12311 (Fdbus_method_return_internal, Fdbus_method_error_internal):
12312 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
12313 (Fdbus_register_signal): Use SSDATA when the context wants char *.
12314
78320123
PE
12315 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
12316 if GCC considers string literals to be constants.
49cebcca 12317 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 12318
35ac2a97
SM
123192011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
12320
fb103ca9
SM
12321 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
12322 (print_preprocess, print_object): New macro to fix last change.
12323
35ac2a97
SM
12324 * print.c (print_preprocess): Don't forget font objects.
12325
62973b41
JB
123262011-03-16 Juanma Barranquero <lekktu@gmail.com>
12327
12328 * emacs.c (USAGE3): Doc fixes.
12329
0e48bb22
AS
123302011-03-15 Andreas Schwab <schwab@linux-m68k.org>
12331
12332 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
12333 structure.
12334
7684e57b
JB
123352011-03-14 Juanma Barranquero <lekktu@gmail.com>
12336
12337 * lisp.h (VWindow_system, Qfile_name_history):
12338 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
12339 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
12340 (w32_system_caret_x, w32_system_caret_y): Declare extern.
12341
12342 * w32select.c: Don't #include "keyboard.h".
c96bbc66 12343 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
12344
12345 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
12346 * w32console.c (detect_input_pending, read_input_pending)
12347 (encode_terminal_code):
12348 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
12349 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
12350 (w32_system_caret_y, Qfile_name_history):
12351 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
12352 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
12353 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
12354 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
12355 * w32proc.c (Qlocal, report_file_error):
12356 * w32term.c (Vwindow_system, updating_frame):
12357 * w32uniscribe.c (initialized, uniscribe_font_driver):
12358 Remove unneeded extern declarations.
12359
2aa46d6c
CY
123602011-03-14 Chong Yidong <cyd@stupidchicken.com>
12361
c96bbc66 12362 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 12363
cffc6f3b
CY
123642011-03-13 Chong Yidong <cyd@stupidchicken.com>
12365
12366 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
12367 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
12368 These macros can no longer be used for assignment.
12369
44f230aa
SM
12370 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
12371 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
12372 (record_buffer_markers, fetch_buffer_markers): New functions for
12373 recording and fetching special buffer markers.
12374 (set_buffer_internal_1, set_buffer_temp): Use them.
12375
12376 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
12377
12378 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
12379
12380 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
12381 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
12382
12383 * xdisp.c (hscroll_window_tree):
12384 (reconsider_clip_changes): Use PT instead of BUF_PT.
12385
d251f04b
EZ
123862011-03-13 Eli Zaretskii <eliz@gnu.org>
12387
12388 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
12389 $(EMACS_ROOT)/lib/intprops.h.
12390
f0c77cd1
PE
123912011-03-13 Paul Eggert <eggert@cs.ucla.edu>
12392
3eca4629
PE
12393 Fix more problems found by GCC 4.5.2's static checks.
12394
7c86ee98
PE
12395 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
12396 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
12397 (xg_free_frame_widgets): Make it clear that a local variable is
12398 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
12399 (gdk_window_get_screen): Make it clear that this macro is needed
12400 only if USE_GTK_TOOLTIP.
1e5524e7
PE
12401 (int_gtk_range_get_value): New function, which avoids a diagnostic
12402 from gcc -Wbad-function-cast.
12403 (xg_set_toolkit_scroll_bar_thumb): Use it.
12404 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
12405 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
12406 (get_utf8_string, xg_get_file_with_chooser):
12407 Rename locals to avoid shadowing.
12408 (create_dialog): Move locals to avoid shadowing.
7c86ee98 12409
41729b81
PE
12410 * xgselect.c (xg_select): Remove unused var.
12411
f0c77cd1
PE
12412 * image.c (four_corners_best): Mark locals as initialized.
12413 (gif_load): Initialize transparent_p to zero (Bug#8238).
12414 Mark another local as initialized.
ec6cf4c6 12415 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 12416
ce0ad53d 12417 * image.c (clear_image_cache): Now static.
d5d5a617 12418 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 12419 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
12420 (x_edge_detection): Remove unnecessary cast that
12421 gcc -Wbad-function-cast diagnoses.
2037898d 12422 (gif_load): Fix pointer signedness.
6ae141d6
PE
12423 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
12424 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 12425
33383987 124262011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 12427
d32df629
PE
12428 Improve quality of tests for time stamp overflow.
12429 For example, without this patch (encode-time 0 0 0 1 1
12430 1152921504606846976) returns the obviously-bogus value (-948597
12431 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
12432 reports time overflow. See
12433 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
12434 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
12435 * editfns.c: Include limits.h and intprops.h.
12436 (TIME_T_MIN, TIME_T_MAX): New macros.
12437 (time_overflow): Move earlier, to before first use.
12438 (hi_time, lo_time): New functions, for an accurate test for
12439 out-of-range times.
12440 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
12441 (Fget_internal_run_time): Don't assume time_t fits in int.
12442 (make_time): Use list2 instead of Fcons twice.
12443 (Fdecode_time): More accurate test for out-of-range times.
12444 (check_tm_member): New function.
12445 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
12446 (lisp_time_argument): Don't rely on undefined left-shift and
12447 right-shift behavior when checking for time stamp overflow.
8be6f318 12448
fe31d94c
PE
12449 * editfns.c (time_overflow): New function, refactoring common code.
12450 (Fformat_time_string, Fdecode_time, Fencode_time):
12451 (Fcurrent_time_string): Use it.
12452
8be6f318
PE
12453 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
12454 * dired.c (make_time): Move to ...
12455 * editfns.c (make_time): ... here.
12456 * systime.h: Note the move.
12457
09d9db2c 124582011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 12459
126bc0dc
YM
12460 * fringe.c (update_window_fringes): Remove unused variables.
12461
c47cbdfd
YM
12462 * unexmacosx.c (copy_data_segment): Also copy __got section.
12463 (Bug#8223)
12464
7ac80be9
EZ
124652011-03-12 Eli Zaretskii <eliz@gnu.org>
12466
c96bbc66 12467 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
12468 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
12469 Constify `char *' arguments and their references according to
12470 prototypes in tparam.h.
12471
ecb0f94d 12472 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 12473
7ac80be9
EZ
12474 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
12475 Adapt all references accordingly.
12476
12477 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
12478
ef1fd07e
TT
124792011-03-11 Tom Tromey <tromey@redhat.com>
12480
12481 * buffer.c (syms_of_buffer): Remove obsolete comment.
12482
7ef4b50c
EZ
124832011-03-11 Eli Zaretskii <eliz@gnu.org>
12484
12485 * termhooks.h (encode_terminal_code): Declare prototype.
12486
12487 * msdos.c (encode_terminal_code): Don't declare prototype.
12488
12489 * term.c (encode_terminal_code): Now external again, used by
12490 w32console.c and msdos.c.
12491
44f230aa
SM
12492 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
12493 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 12494
4b1ec863 124952011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 12496
1714f52b 12497 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 12498
4b1ec863
PE
12499 * fringe.c (update_window_fringes): Mark locals as initialized
12500 (Bug#8227).
12501 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 12502
524c7aa6
PE
12503 * alloc.c (mark_fringe_data): Move decl from here ...
12504 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
12505 to check its interface.
12506 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
12507
a5c0af81 12508 * fontset.c (free_realized_fontset): Now static.
7519b8cd 12509 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 12510 (fontset_font): Mark local as initialized.
a9a06e0b 12511 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 12512
b4716021
PE
12513 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
12514
811e9bac 12515 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 12516 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
12517 (x_own_selection, Fx_disown_selection_internal): Rename locals
12518 to avoid shadowing.
12519 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 12520
7e3ab302
PE
12521 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
12522 so that the caller can use some name other than gcpro1.
12523 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
12524 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12525 (Fx_backspace_delete_keys_p):
12526 Use them to avoid shadowing, and rename vars to avoid shadowing.
12527 (x_decode_color, x_set_name, x_window): Now static.
6b437900 12528 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 12529 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
12530 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
12531 Remove unused locals.
7e3ab302
PE
12532 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12533 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
12534 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
12535 macros.
f78faa98 12536
e2b13473
PE
12537 * xterm.h (x_mouse_leave): New decl.
12538
77f23912
PE
12539 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
12540 Remove unused functions.
cdf4ba58
PE
12541 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
12542 (x_calc_absolute_position): Now static.
7411c686 12543 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 12544 Don't declare local "event" unless it's used.
ed7bf3a5
PE
12545 (x_iconify_frame, x_free_frame_resources): Don't declare locals
12546 unless they are used.
38d0b34a
PE
12547 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
12548 (x_fatal_error_signal): Remove; not used.
a6067996
PE
12549 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
12550 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
12551 (x_error_catcher, x_connection_closed, x_error_handler):
12552 (x_error_quitter, xembed_send_message, x_iconify_frame):
12553 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 12554 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 12555 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 12556
44f230aa
SM
12557 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
12558 Rename or move locals to avoid shadowing.
6b463e58 12559 (tty_defined_color, merge_face_heights): Now static.
5967d051 12560 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
12561 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
12562 does not deduce is never used uninitialized.
73719eba
PE
12563 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
12564 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 12565
426994c3 12566 * terminal.c (store_terminal_param): Now static.
5489860b 12567
032f1620 12568 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 12569 (set_frame_menubar): Remove unused local.
d4323972 12570 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
12571 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
12572 since they might point to immutable storage.
281585b0
PE
12573 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
12574 since it's unused otherwise.
032f1620 12575
367c19e5 12576 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 12577 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
12578 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
12579 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 12580 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
12581 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
12582 does not deduce are never used uninitialized.
70739cbe 12583
07b48fa9
PE
12584 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
12585
8868a238 12586 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
12587 * window.c (window_loop, size_window):
12588 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 12589
7e5cf297 12590 * window.c (display_buffer): Now static.
d6550a9f
PE
12591 (size_window): Mark variables that gcc -Wuninitialized
12592 does not deduce are never used uninitialized.
a586633d
PE
12593 * window.h (check_all_windows): New decl, to forestall
12594 gcc -Wmissing-prototypes diagnostic.
5b555da1 12595 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 12596
f6095868
PE
12597 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
12598 shadowing.
12599 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
12600 Include <limits.h>.
12601 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
12602 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
12603 (load_charset_map): Mark variables that gcc -Wuninitialized
12604 does not deduce are never used uninitialized.
53df7c11 12605 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 12606
f38b440c
PE
12607 * coding.c (coding_set_source, coding_set_destination):
12608 Use "else { /* comment */ }" rather than "else /* comment */;"
12609 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
12610 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
12611 a block, when the outer 'i' will do.
12612 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
12613 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
12614 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
12615 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
12616 (Fdecode_sjis_char, Fdefine_coding_system_internal):
12617 Rename locals to avoid shadowing.
12618 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
12619 * coding.c (emacs_mule_char, encode_invocation_designation):
12620 Now static, since they're not used elsewhere.
413bb2db 12621 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 12622 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
12623 (decode_coding_emacs_mule): Mark variables that gcc
12624 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
12625 (detect_coding_iso_2022): Initialize a local variable that might
12626 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 12627 this initialization is needed. (Bug#8211)
5f58e762
PE
12628 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
12629 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
12630 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
12631 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
12632 Remove unused macros.
f38b440c 12633
232b38b9 12634 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 12635 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 12636 * character.c (string_count_byte8): Likewise.
232b38b9 12637
fb90da1b
PE
12638 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
12639 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
12640
fb93dbc2
PE
12641 * chartab.c (copy_sub_char_table): Now static, since it's not used
12642 elsewhere.
5c156ace
PE
12643 (sub_char_table_ref_and_range, char_table_ref_and_range):
12644 Rename locals to avoid shadowing.
bbcd0949 12645 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 12646
7d3b3862 12647 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 12648 (BIDI_BOB): Remove unused macro.
7d3b3862 12649
6be7d3da
PE
12650 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
12651 deduce are never used uninitialized.
c2ed9c8b 12652 * term.c (encode_terminal_code): Likewise.
6be7d3da 12653
75f8807f 12654 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 12655
50938595
PE
12656 * tparam.h: New file.
12657 * term.c, tparam.h: Include it.
12658 * deps.mk (term.o, tparam.o): Depend on tparam.h.
12659 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
12660 Move these decls to tparam.h, and make them agree with what
12661 is actually in tparam.c. The previous trick of using incompatible
12662 decls in different modules does not conform to the C standard.
12663 All callers of tparam changed to use tparam's actual API.
12664 * tparam.c (tparam1, tparam, tgoto):
12665 Use const pointers where appropriate.
12666
fbceeba2
PE
12667 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
12668 * cm.h (struct cm): Likewise.
12669 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
12670 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
12671 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
12672 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
12673 (turn_on_face, init_tty): Likewise.
12674 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 12675
7f3f1250
PE
12676 * term.c (term_mouse_position): Rename local to avoid shadowing.
12677
e6ca6543
PE
12678 * alloc.c (mark_ttys): Move decl from here ...
12679 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
12680
c40f8d15
AS
126812011-03-11 Andreas Schwab <schwab@linux-m68k.org>
12682
12683 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
12684
cfe0661d
JB
126852011-03-09 Juanma Barranquero <lekktu@gmail.com>
12686
12687 * search.c (compile_pattern_1): Remove argument regp, unused since
12688 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
12689 (compile_pattern): Don't pass it.
12690
0afb4571
J
126912011-03-08 Jan Djärv <jan.h.d@swipnet.se>
12692
12693 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
12694 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
12695 for ! HAVE_GTK3.
12696 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
12697
12698 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
12699
12700 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
12701 gdk_window_get_screen, gdk_window_get_geometry,
12702 gdk_x11_window_lookup_for_display and GDK_KEY_g.
12703 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
12704 (xg_get_pixbuf_from_pixmap): New function.
12705 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
12706 to Pixmap, take frame as parameter, remove GdkColormap parameter.
12707 Call xg_get_pixbuf_from_pixmap instead of
12708 gdk_pixbuf_get_from_drawable.
12709 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
12710 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
12711 (xg_check_special_colors): Use GtkStyleContext and its functions
12712 for HAVE_GTK3.
12713 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
12714 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
12715 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
12716 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
12717 Call gtk_widget_get_preferred_size.
0afb4571
J
12718 (xg_frame_resized): gdk_window_get_geometry only takes 5
12719 parameters.
44f230aa
SM
12720 (xg_win_to_widget, xg_event_is_for_menubar):
12721 Call gdk_x11_window_lookup_for_display.
0afb4571
J
12722 (xg_set_widget_bg): New function.
12723 (delete_cb): New function.
895009e1 12724 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 12725 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
12726 (xg_set_background_color): Call xg_set_widget_bg.
12727 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
12728 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
12729 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
12730 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
12731 if ! HAVE_GTK3.
12732 (update_frame_tool_bar): Call gtk_widget_hide.
12733 (xg_initialize): Use GDK_KEY_g.
12734
12735 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
12736 if ! HAVE_GTK3
12737 (x_session_initialize): Call gdk_x11_set_sm_client_id.
12738
12739 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
12740 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
12741 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
12742
1c2cc4ef
JB
127432011-03-08 Juanma Barranquero <lekktu@gmail.com>
12744
12745 * w32xfns.c (select_palette): Check success of RealizePalette against
12746 GDI_ERROR, not zero.
12747
33383987 12748See ChangeLog.11 for earlier changes.
aac0c6e3
MR
12749
12750;; Local Variables:
12751;; coding: utf-8
aac0c6e3
MR
12752;; End:
12753
2f097256 12754 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
12755
12756 This file is part of GNU Emacs.
12757
12758 GNU Emacs is free software: you can redistribute it and/or modify
12759 it under the terms of the GNU General Public License as published by
12760 the Free Software Foundation, either version 3 of the License, or
12761 (at your option) any later version.
12762
12763 GNU Emacs is distributed in the hope that it will be useful,
12764 but WITHOUT ANY WARRANTY; without even the implied warranty of
12765 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12766 GNU General Public License for more details.
12767
12768 You should have received a copy of the GNU General Public License
12769 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.