Don't handle splits status.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
89d61221
MR
12011-11-12 Martin Rudalics <rudalics@gmx.at>
2
3 * window.h (window): Remove splits slot.
4 * window.c (Fwindow_splits, Fset_window_splits): Remove.
5 (Fdelete_other_windows_internal, make_parent_window)
6 (make_window, Fsplit_window_internal, Fdelete_window_internal)
7 (Fset_window_configuration, save_window_save): Don't deal with
8 split status of windows.
9 (saved_window): Remove splits slot.
10 (Vwindow_splits): Rewrite doc-string.
11
97f18cc8
JD
122011-11-11 Jan Djärv <jan.h.d@swipnet.se>
13
14 * xfns.c (unwind_create_frame):
15 * nsfns.m (unwind_create_frame):
16 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
17 Vframe_list (Bug#9999).
18
22a648b4
DA
192011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
20
21 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22
659afede
KH
232011-11-11 Kenichi Handa <handa@m17n.org>
24
25 * callproc.c (Fcall_process): Set the member dst_multibyte of
26 process_coding.
27
9ac0394b
KH
282011-11-11 Johan Bockgård <bojohan@gnu.org>
29
30 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
31 avoid a crash (bug#9496).
32
2fbdc249
CY
332011-11-09 Chong Yidong <cyd@gnu.org>
34
35 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
36 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
37
ac6b1f81
PE
382011-11-08 Paul Eggert <eggert@cs.ucla.edu>
39
40 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
41
09db192c
PE
422011-11-08 Paul Eggert <eggert@cs.ucla.edu>
43
44 Avoid some portability problems by eschewing 'extern inline' functions.
45 The trivial performance wins aren't worth the portability hassles; see
46 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
47 et seq.
48 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
49 (window_box_width, window_box_left, window_box_left_offset)
50 (window_box_right, window_box_right_offset): Undo previous change,
51 by removing the "extern"s.
52 * intervals.c (adjust_intervals_for_insertion)
53 (adjust_intervals_for_deletion): Undo previous change,
54 making these static again.
55 (offset_intervals, temp_set_point_both, temp_set_point)
56 (copy_intervals_to_string): No longer inline.
57 * xdisp.c (window_text_bottom_y, window_box_width)
58 (window_box_height, window_box_left_offset)
59 (window_box_right_offset, window_box_left, window_box_right)
60 (window_box): No longer inline.
61
105216ed
CY
622011-11-08 Chong Yidong <cyd@gnu.org>
63
64 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
65 (Fwindow_body_height, Fwindow_body_width): Move from Lisp. Signal
66 an error if not a live window.
67 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
68 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
69
ae9e237f
JB
702011-11-07 Juanma Barranquero <lekktu@gmail.com>
71
72 * lisp.h (syms_of_abbrev): Remove declaration.
73 Reported by CHENG Gao <chenggao@royau.me>.
74
c7aa8333
EZ
752011-11-07 Eli Zaretskii <eliz@gnu.org>
76
77 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
78 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
79 of temacs in GUI mode.
80
be7f5545
MR
812011-11-07 Martin Rudalics <rudalics@gmx.at>
82
83 * window.h: Declare delete_all_child_windows instead of
84 delete_all_subwindows.
85 * window.c (Fwindow_nest, Fset_window_nest)
86 (Fset_window_new_total, Fset_window_new_normal)
87 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
88 (delete_all_subwindows): Rename to delete_all_child_windows.
89 (Fdelete_other_windows_internal, Fset_window_configuration):
90 Call delete_all_child_windows instead of delete_all_subwindows.
91 * frame.c (delete_frame): Call delete_all_child_windows instead
92 of delete_all_subwindows.
93
ca78dc43
PE
942011-11-07 Paul Eggert <eggert@cs.ucla.edu>
95
96 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
97 This is also needed for porting to any host where GC_MARK_STACK is
98 not GC_MAKE_GCPROS_NOOPS.
99 (which_symbols): Use it.
100
a0241d01
KH
1012011-11-07 Kenichi Handa <handa@m17n.org>
102
103 * coding.c (coding_set_destination): Check coding->src_pos only
104 when coding->src_object is a buffer (bug#9910).
105
106 * process.c (send_process): Set the member src_multibyte of coding
107 to 0 (bug#9911) when sending a unibyte text.
108
109 * callproc.c (Fcall_process): Set the member src_multibyte of
110 process_coding to 0 (bug#9912).
111
a64bfdfa 1122011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
113
114 * xmenu.c (cleanup_widget_value_tree): New function.
115 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
116 calling free_menubar_widget_value_tree directly (Bug#9830).
117
cb41b32a
PE
1182011-11-06 Paul Eggert <eggert@cs.ucla.edu>
119
120 Fix some portability problems with 'inline'.
121 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
122 (window_box_width, window_box_left, window_box_left_offset)
123 (window_box_right, window_box_right_offset): Declare extern.
124 Otherwise, these inline functions do not conform to C99 and
125 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
126 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
127 * intervals.c (adjust_intervals_for_insertion)
128 (adjust_intervals_for_deletion): Now extern, because otherwise the
129 extern inline functions 'offset_intervals' couldn't refer to it.
130 (static_offset_intervals): Remove.
131 (offset_intervals): Rewrite using the old contents of
132 static_offset_intervals. The old version didn't conform to C99
133 because an extern inline function contained a reference to an
134 identifier with static linkage.
135
b7041366
AS
1362011-11-06 Andreas Schwab <schwab@linux-m68k.org>
137
138 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
139 GC.
140
88a37c4d
EZ
1412011-11-06 Eli Zaretskii <eliz@gnu.org>
142
143 * xdisp.c (init_iterator, reseat_to_string): Don't set the
144 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
145 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
146 return Qleft_to_right.
147
49745b39
CY
1482011-11-06 Chong Yidong <cyd@gnu.org>
149
150 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
151 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
152 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
153 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
154 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
155 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
156 (Fwindow_vscroll): Doc fix.
157 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
158 argument, since it makes no sense to pass a live window and for
159 consistency with window-child.
160
1f05cd82
CS
1612011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
162
163 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
164 support MSVC.
165
22610910
JR
1662011-11-05 Jason Rumney <jasonr@gnu.org>
167
168 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
169 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
170 fonts (Bug#6029).
171 (add_font_entity_to_list): Fix logic errors in mixed boolean and
172 bitwise arithmetic preventing use of unicode-sip and non-truetype
173 opentype fonts.
174
a06776b2
EZ
1752011-11-05 Eli Zaretskii <eliz@gnu.org>
176
3ad924ba
EZ
177 * s/ms-w32.h (fstat, stat, utime): Move redirections to
178 "emacs"-only part.
179
a06776b2
EZ
180 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
181 initialization code to keep similarity to xfns.c after changes
182 from 2011-11-05.
183
c9e7db78
JD
1842011-11-05 Jan Djärv <jan.h.d@swipnet.se>
185
a97f8f3f
JD
186 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
187 (unwind_create_frame): New function (Bug#9943).
188 (Fx_create_frame): Restructure code to be more similar to the one in
189 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
190 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
191 Move terminal->reference_count++ just before making the frame official
192 (Bug#9943).
193
194 * nsterm.m (x_free_frame_resources): New function.
195 (x_destroy_window): Move code to x_free_frame_resources.
196
c9e7db78
JD
197 * xfns.c (unwind_create_frame): Fix comment.
198 (Fx_create_frame, x_create_tip_frame): Move
199 terminal->reference_count++ just before making the frame
200 official. Move initialization of image_cache_refcount and
201 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
202
a6fc3b5c
EZ
2032011-11-05 Eli Zaretskii <eliz@gnu.org>
204
205 Support MSVC build with newer versions of Visual Studio.
206 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
207 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
208 nt/gmake.defs.
209
210 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
211 which are not supported by MSVC.
212 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
213 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
214 bitfields.
215 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
216 types in bitfields.
217 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
218
219 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
220
2212011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
222
223 Support MSVC build with newer versions of Visual Studio.
224 * w32.c: Don't include w32api.h for MSVC.
225 (init_environment) [_MSC_VER]: Call sys_access, not _access.
226
227 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
228 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
229 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
230 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
231 e_* cousins.
232 (alloca) [_MSC_VER]: Define to _alloca.
233
234 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
235
236 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
237
a58c13ed
EZ
2382011-11-04 Eli Zaretskii <eliz@gnu.org>
239
240 * xdisp.c (note_mouse_highlight): If either of
241 previous/next-single-property-change returns nil, treat that as
242 the beginning or the end of the buffer. (Bug#9955)
243
fe0b6370
JD
2442011-11-04 Jan Djärv <jan.h.d@swipnet.se>
245
a58c13ed 246 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
247 label is not null (Bug#9951).
248 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
249 may be NULL.
250
89bd5ee1
EZ
2512011-11-04 Eli Zaretskii <eliz@gnu.org>
252
253 * window.c (Fwindow_body_size): Mention in the doc string that the
254 return value is in frame's canonical units. (Bug#9949)
255
84c3edb9
EZ
2562011-11-03 Eli Zaretskii <eliz@gnu.org>
257
4e2fb5c7
EZ
258 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
259
84c3edb9 260 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 261 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 262 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 263
bc17a887
EZ
2642011-11-01 Eli Zaretskii <eliz@gnu.org>
265
266 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
267 Don't stop backward scan on the continuation glyph, even though
268 its CHARPOS is positive.
26b46e51
EZ
269 (mouse_face_from_buffer_pos, note_mouse_highlight): Rename
270 cover_string to disp_string.
bc17a887 271
4ee88440
MR
2722011-11-01 Martin Rudalics <rudalics@gmx.at>
273
274 * window.c (temp_output_buffer_show): Don't use
275 Vtemp_buffer_show_specifiers.
276 (Vtemp_buffer_show_specifiers): Remove unused variable.
277
c2ff3c02
EZ
2782011-10-30 Eli Zaretskii <eliz@gnu.org>
279
280 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
281 past the beginning of the current glyph matrix.
282
6e56383b
JD
2832011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
284
285 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
286 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
287 HAVE_GTK3 (Bug#9869).
b77a6a7f 288
3b574623
JD
289 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
290 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
291
b77a6a7f
JD
292 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
293
294 * xterm.c: Declare x_handle_net_wm_state to return int.
295 (handle_one_xevent): Check if we are iconified but don't have
296 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
297 (get_current_wm_state): Return non-zero if not hidden,
298 check for _NET_WM_STATE_HIDDEN (Bug#9893).
299 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
300 (x_handle_net_wm_state): Return what get_current_wm_state returns.
301 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
302
196e41e4
PE
3032011-10-29 Paul Eggert <eggert@cs.ucla.edu>
304
305 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
306 so that this new function doesn't get optimized away by a
307 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
308
021f2e1a
AS
3092011-10-29 Andreas Schwab <schwab@linux-m68k.org>
310
311 * frame.h (MOUSE_HL_INFO): Remove excess parens.
312
8b058d44
EZ
3132011-10-29 Eli Zaretskii <eliz@gnu.org>
314
315 Fix the `xbytecode' command.
316 * .gdbinit (xprintbytestr): New command.
317 (xwhichsymbols): Renamed from `which'; all callers changed.
318 (xbytecode): Print the byte-code string as well.
319
4452fb80
EZ
3202011-10-29 Kim Storm <storm@cua.dk>
321
8b058d44
EZ
322 * alloc.c (which_symbols): New function.
323
21b72067
AS
3242011-10-29 Andreas Schwab <schwab@linux-m68k.org>
325
326 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
327 line. (Bug#9903)
328
83ed7b5c
GM
3292011-10-29 Glenn Morris <rgm@gnu.org>
330
331 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
332 Not clear what it was for, and it causes various bugs. (Bug#9839)
333
5a7a728b
EZ
3342011-10-28 Eli Zaretskii <eliz@gnu.org>
335
336 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
337 possible random value that matches one of those tested as
338 condition to clear the mouse face.
339
d3d0842f
CY
3402011-10-28 Chong Yidong <cyd@gnu.org>
341
342 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
343
31b39d13
DN
3442011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
345
346 * window.c (make_window): Initialize phys_cursor_on_p.
347
9aba6043
SM
3482011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
349
350 * lisp.h (struct Lisp_Symbol): Update comments.
351
c20992f4
JB
3522011-10-28 Juanma Barranquero <lekktu@gmail.com>
353
354 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
355
db4f02f2
EZ
3562011-10-28 Eli Zaretskii <eliz@gnu.org>
357
358 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
359 <oslsachem@gmail.com> for helping to debug this.
360
361 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
362 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
363 (g_b_init_get_glyph_outline_w): New static variables.
364 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
365 (GetGlyphOutlineW_Proc): New typedefs.
366 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
367 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
368 New functions.
369 (w32font_open_internal, compute_metrics):
370 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
371 instead of calling the "wide" APIs directly.
372
373 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
374
375 * w32.h (syms_of_w32font): Add prototype.
376
87e68db4
JB
3772011-10-27 Juanma Barranquero <lekktu@gmail.com>
378
379 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
380 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
381 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
382 (Fmove_to_window_line): Doc fix.
383
435c1d67
CY
3842011-10-27 Chong Yidong <cyd@gnu.org>
385
386 * process.c (make_process): Set gnutls_state to NULL.
387
388 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
389 non-NULL, regardless of GNUTLS_INITSTAGE.
390 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
391 an error. Set process slots as soon as we allocate them.
392
393 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
394
9c6c6f49
CY
3952011-10-27 Chong Yidong <cyd@gnu.org>
396
9aba6043
SM
397 * gnutls.c (emacs_gnutls_deinit): New function.
398 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
399 (Fgnutls_deinit, Fgnutls_boot): Use it.
400
401 * process.c (make_process): Initialize GnuTLS credentials to NULL.
402 (deactivate_process): Call emacs_gnutls_deinit.
403
657d08d3
JB
4042011-10-27 Juanma Barranquero <lekktu@gmail.com>
405
406 * image.c (x_create_x_image_and_pixmap):
407 * w32.c (sys_rename, w32_delayed_load):
408 * w32font.c (fill_in_logfont):
409 * w32reg.c (x_get_string_resource): Silence compiler warnings.
410
5430d399
JB
4112011-10-26 Juanma Barranquero <lekktu@gmail.com>
412
413 * w32fns.c (w32_default_color_map): New function,
414 extracted from Fw32_default_color_map.
a7ef684b 415 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 416
fe0055fa
PE
4172011-10-25 Paul Eggert <eggert@cs.ucla.edu>
418
419 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
420
e6346438
SM
4212011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
422
423 * keyboard.c (test_undefined): New function (bug#9751).
424 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
425
e112cc37
ET
4262011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
427
428 * sysdep.c (init_sys_modes): Fix the check for the controlling
429 terminal (Bug#6649).
430
7b5d6677
EZ
4312011-10-20 Eli Zaretskii <eliz@gnu.org>
432
433 * dispextern.h (struct bidi_it): New member next_en_type.
434
435 * bidi.c (bidi_line_init): Initialize the next_en_type member.
436 (bidi_resolve_explicit_1): When next_en_pos is valid for the
437 current character, check also for next_en_type being WEAK_EN.
438 (bidi_resolve_weak): Don't enter the expensive loop if the current
439 position is before next_en_pos. Record the bidi type of the first
440 non-ET, non-BN character we find, in addition to its position.
441 (bidi_level_of_next_char): Invalidate next_en_type when
442 next_en_pos is over-stepped.
443
7da0b018
PE
4442011-10-20 Paul Eggert <eggert@cs.ucla.edu>
445
446 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
447 * editfns.c: Rewrite current-time-zone so that it invokes
448 the equivalent of (format-time-string "%Z") to get the time zone name.
449 This fixes a bug when the time zone name contains characters that
450 need converting from the system time locale to Emacs internal format.
451 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
452 that patch fixed format-time-string to do the conversion, but
453 I forgot to fix current-time-zone.
454 (format_time_string): New function, containing most of
455 what Fformat_time_string used to contain.
456 (Fformat_time_string): Rewrite in terms of format_time_string.
457 This doesn't change this function's behavior.
458 (current-time-zone): Rewrite to use format_time_string.
459 This fixes the bug reported by Michael Schierl in
460 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
461 Jason Rumney's 2007-06-07 change worked around this bug, but
462 didn't fix it.
463 * systime.h (tzname, timezone): Remove no-longer-used declarations.
464
8547b010
EZ
4652011-10-19 Eli Zaretskii <eliz@gnu.org>
466
467 * xdisp.c (start_display): If the character at POS is displayed
468 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
469 (try_window_reusing_current_matrix): If a line ends in a display
470 vector or the next line starts in a display vector, continue
471 redrawing the window even though the character position of
472 start_row was reached.
8547b010
EZ
473 (Bug#9771, part 2)
474
4e948d15
CY
4752011-10-18 Chong Yidong <cyd@gnu.org>
476
477 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
478 with nobreak-char-display too.
479
4787455f
EZ
4802011-10-18 Eli Zaretskii <eliz@gnu.org>
481
482 Fix part 3 of bug#9771.
483 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
484 (bidi_resolve_neutral): Don't enter the expensive loop looking for
485 non-neutral characters if the current character is a paragraph
486 separator (a.k.a. Newline). This avoids running the same
487 expensive loop twice, once when we consume the preceding newline
488 and the other time when the line actually needs to be displayed.
489 Avoid the loop when we see neutrals on the base embedding level
490 following a character whose directionality is the same as the
491 paragraph's. This avoids running the expensive loop when a line
492 ends in a long sequence of neutrals, like control characters.
493 Add assertion against STRONG_AL type. Slightly rearrange code
494 that determines the type of a neutral given the first non-neutral
495 that follows it.
496 (bidi_level_of_next_char): Set next_en_pos to zero when
497 invalidating its info.
498
2c91f553
EZ
4992011-10-17 Eli Zaretskii <eliz@gnu.org>
500
501 * xdisp.c (push_display_prop): Determine whether to record string
502 or buffer position by IT->string, not by IT->method. Allow
503 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
504 (move_it_vertically_backward): Don't look for character position
505 immediately after the newline when in a continuation line.
506 (Bug#9771, part 1)
2c91f553 507
c7b08b0d
MR
5082011-10-15 Martin Rudalics <rudalics@gmx.at>
509
510 * window.c (coordinates_in_window): Rewrite and delabelize
511 vertical border check. (Bug#5357) (Bug#9618)
512
6b02f655
SM
5132011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
514
515 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
516 errors in XSetWindowBorder (bug#9310).
517
81d40c92
DA
5182011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
519
520 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
521 avoid crash when xmalloc overrun checking is enabled.
522
d4172c3b
EZ
5232011-10-13 Eli Zaretskii <eliz@gnu.org>
524
525 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
526 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
527 cursor motion with <left> and <right> arrow keys.
528
529 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
530 some callers set that themselves.
531
b00eea75
EZ
5322011-10-12 Eli Zaretskii <eliz@gnu.org>
533
534 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
535 display string and the previous row comes from the same string and
536 is empty. (Bug#9739) (Bug#9738)
537
8fe012c4
SM
5382011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
539
540 * doc.c (get_doc_string): Encode file name (bug#9735).
541
0074aef2
EZ
5422011-10-12 Eli Zaretskii <eliz@gnu.org>
543
79beb178
EZ
544 * bidi.c (bidi_level_of_next_char):
545 * xdisp.c (get_visually_first_element): Remove old incorrect
546 comments regarding the Unicode Line Separator character.
547
0074aef2
EZ
548 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
549
6e4b3fbe
DA
5502011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
551
552 * alloc.c (Fgc_status): Do not access beyond zombies array
553 boundary if nzombies > MAX_ZOMBIES.
554 * alloc.c (dump_zombies): Add missing format specifier.
555
0324f3af
PE
5562011-10-12 Paul Eggert <eggert@cs.ucla.edu>
557
b5525cac
PE
558 * xdisp.c (set_cursor_from_row): Simplify conditionals,
559 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
560
0324f3af
PE
561 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
562 Some packages use them to denote characters with modifiers.
563
e9b5f888
AS
5642011-10-11 Andreas Schwab <schwab@linux-m68k.org>
565
566 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
567 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
568 matching a pp-number. Rename parameter var to var1.
569
127827c0
SM
5702011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
571
572 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
573
c8fd3bd0
GM
5742011-10-08 Glenn Morris <rgm@gnu.org>
575
576 * callint.c (Fcall_interactively): Give a more explicit error for the
577 'c' case with a non-character input. (Bug#8479)
578
352ec8ff
EZ
5792011-10-08 Eli Zaretskii <eliz@gnu.org>
580
03669ccb
EZ
581 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
582 lines.
7061c986
EZ
583 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
584 lines that are hscrolled on the left.
03669ccb 585
352ec8ff
EZ
586 * dispnew.c (buffer_posn_from_coords): Account for a possible
587 presence of header-line. (Bug#4426)
588
a66cfb1c
SM
5892011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
590
6b02f655
SM
591 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
592 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 593
7c5ee88e
PE
5942011-10-07 Paul Eggert <eggert@cs.ucla.edu>
595
596 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
597 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
598 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
599 this makes Emacs dump core during garbage collection on rare
600 occasions. sizeof is obviously inferior to offsetof here, so
601 stick with offsetof.
602 (GC_POINTER_ALIGNMENT): New macro.
603 (mark_memory): Omit 3rd (offset) arg; caller changed.
604 Don't assume EMACS_INT alignment is the same as pointer alignment.
605
df1bbe5b
SM
6062011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
607
608 * keyboard.c (read_key_sequence_remapped): New var.
609 (read_key_sequence): Compute remapping in the right buffer.
610 (command_loop_1): Use read_key_sequence's remapping directly.
611
51553db6
SM
6122011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
613
32c1fffd
SM
614 * dired.c (file_name_completion): Don't expand file name.
615 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
616 before checking file name handler.
617
51553db6
SM
618 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
619 they've been requested explicitly (bug#9591).
620
b6bd1599 6212011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
622
623 * keymap.c (Fsingle_key_description): Use make_specified_string
624 instead of build_string to build string from push_key_description.
625 (Bug#5193)
626
f701dc2a
PE
6272011-09-30 Paul Eggert <eggert@cs.ucla.edu>
628
4222c55d
PE
629 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
630 This fixes a Y2038 bug on 64-bit hosts.
631 * buffer.c (reset_buffer):
632 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
633 (Fclear_buffer_auto_save_failure):
634 Use 0, not -1, to represent an unset failure time, since time_t
635 might not be signed.
636
f701dc2a
PE
637 Remove dependency on glibc malloc internals.
638 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
639 Move back here from lisp.h, but with their new implementations.
640 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
641 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
642 * charset.c (charset_table_init): New static var.
643 (syms_of_charset): Use it instead of xmalloc. This removes a
644 dependency on glibc malloc internals. See Eli Zaretskii's comment in
645 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
646 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
647 Move back to alloc.c.
648 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
649 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
650
9ceebf39
JD
6512011-09-30 Jan Djärv <jan.h.d@swipnet.se>
652
653 * nsterm.m (windowDidResize): Call x_set_window_size only when
654 ns_in_resize is true. Otherwise set pixelwidth/height and
655 call change_frame_size (Bug#9628).
656
cb993c58
PE
6572011-09-30 Paul Eggert <eggert@cs.ucla.edu>
658
3930c88b
PE
659 Port --enable-checking=all to Fedora 14 x86-64.
660 * charset.c (syms_of_charset): Also account for glibc malloc's
661 internal overhead when calculating the initial malloc maximum.
662
cb993c58
PE
663 Port --enable-checking=all to Fedora 14 x86.
664 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
665 Move to lisp.h.
666 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
667 (overrun_check_realloc, overrun_check_free):
668 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
669 That way, xmalloc returns a properly-aligned pointer even if
670 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
671 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
672 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
673 into account when calculating the initial malloc maximum.
674 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
675 Move here from alloc.c, so that charset.c can use it too.
676 Properly align; the old code wasn't right for common 32-bit hosts
677 when configured with --enable-checking=all.
678 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
679 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
680
31bed486
EZ
6812011-09-29 Eli Zaretskii <eliz@gnu.org>
682
04c70788 683 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
684 use EDOM.
685
fbcaa2f3
EZ
6862011-09-28 Eli Zaretskii <eliz@gnu.org>
687
688 * xdisp.c (compute_display_string_end): If there's no display
689 string at CHARPOS, return -1.
690
691 * bidi.c (bidi_fetch_char): When compute_display_string_end
692 returns a negative value, treat the character as a normal
693 character not covered by a display string. (Bug#9624)
694
a239d4e9
JB
6952011-09-28 Juanma Barranquero <lekktu@gmail.com>
696
697 * lread.c (Fread_from_string): Fix typo in docstring.
698
88652fd5
EZ
6992011-09-27 Eli Zaretskii <eliz@gnu.org>
700
701 * xdisp.c (handle_invisible_prop): If invisible text ends on a
702 newline, reseat the iterator instead of bidi-iterating there one
703 character at a time. (Bug#9610)
32c1fffd
SM
704 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
705 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 706
ed497dd4
AS
7072011-09-27 Andreas Schwab <schwab@linux-m68k.org>
708
709 * lread.c (readevalloop): Use correct code for NBSP.
710 (read1): Likewise. (Bug#9608)
711
b2bf61aa
MA
7122011-09-25 Michael Albinus <michael.albinus@gmx.de>
713
714 * dbusbind.c (Fdbus_register_signal): When service is not
715 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
716
32bbb17c
GM
7172011-09-25 Glenn Morris <rgm@gnu.org>
718
719 * buffer.c (truncate-lines): Doc fix.
720
94e0933e
CY
7212011-09-24 Chong Yidong <cyd@stupidchicken.com>
722
723 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
724 (Fset_window_next_buffers): Doc fix.
725
cddde921
GM
7262011-09-24 Glenn Morris <rgm@gnu.org>
727
728 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
729
1260aef1
PE
7302011-09-24 Paul Eggert <eggert@cs.ucla.edu>
731
25b4bfa0
PE
732 Fix minor problems found by static checking.
733 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
734 * indent.c (Fvertical_motion): Fix == vs = typo.
735
e3cbd34b
EZ
7362011-09-24 Eli Zaretskii <eliz@gnu.org>
737
a66cfb1c
SM
738 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
739 Default value is now t. Doc fix.
6bf7006f 740
e3cbd34b 741 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 742 logic when moving up, not only when moving down. Fix the
e3cbd34b 743 confusing name and values of the it_overshoot_expected variable;
32c1fffd 744 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
745
746 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
747 CHARPOS is covered by a display string which includes newlines.
748 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
749 is covered by a display string with embedded newlines.
750
a3de0cbd
MA
7512011-09-24 Michael Albinus <michael.albinus@gmx.de>
752
753 * dbusbind.c (Fdbus_register_signal): Add match rule to
754 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
755 (Fdbus_register_method, Vdbus_registered_objects_table):
756 Fix docstring.
a3de0cbd 757
b260039d
JM
7582011-09-24 Jim Meyering <meyering@redhat.com>
759
32c1fffd 760 do not ignore write error for any output size
b260039d
JM
761 The previous change was incomplete.
762 While it makes emacs --batch detect the vast majority of stdout
763 write failures, errors were still ignored whenever the output size is
764 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
765 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
766 && echo FAIL: ignored write error
767 FAIL: ignored write error
768 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
769 && echo FAIL: ignored write error
770 FAIL: ignored write error
771 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
772
8eca8a7c
AS
7732011-09-23 Andreas Schwab <schwab@linux-m68k.org>
774
775 * emacs.c (Fkill_emacs): In noninteractive mode exit
776 non-successfully if a write error occurred on stdout. (Bug#9574)
777
3341db62
EZ
7782011-09-21 Eli Zaretskii <eliz@gnu.org>
779
780 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
781 the xassert test.
782
783 * dispextern.h (struct it): Update the comment documenting what
784 can it->OBJECT be.
785
8c203dbf
EZ
7862011-09-20 Eli Zaretskii <eliz@gnu.org>
787
788 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
789 a display string, extend search for cursor position to end of row.
790 (find_row_edges): If the row ends in a newline from a display
791 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
792 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
793 (Fcurrent_bidi_paragraph_direction): Fix search for previous
794 non-empty line. Fixes confusing cursor motion with arrow keys at
795 the beginning of a line that starts with whitespace.
8c203dbf 796
a4824228
LMI
7972011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
798
799 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
800 (bug#9493).
801
33ed493b
CY
8022011-09-18 Chong Yidong <cyd@stupidchicken.com>
803
804 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
805 boolean (Bug#9154).
806
56cd55c8
EZ
8072011-09-18 Eli Zaretskii <eliz@gnu.org>
808
809 * xdisp.c (display_line): Record maximum and minimum buffer
810 positions even if no glyphs were produced (e.g., by a zero-width
811 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
812 buffer positions that will be removed from the glyph row because
813 they don't fit.
c02dcedf
EZ
814 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
815 column is beyond frame width: don't subtract 1 "pixel" when
816 computing width of the stretch.
3e62b7e0
EZ
817 (reseat_at_next_visible_line_start): Undo the change made on
818 2011-09-17 that saved paragraph information and restored it after
819 the call to `reseat'. (Bug#9545)
56cd55c8 820
5ed99d36 8212011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
822
823 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
824 and turn window cursor on if cleared (Bug#9415).
825
5ed99d36 8262011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
827
828 * search.c (boyer_moore): Take unibyte characters from pattern
829 literally. (Bug#9458)
830
9bade7b2
EZ
8312011-09-18 Eli Zaretskii <eliz@gnu.org>
832
833 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
834
e5e9d610
PE
8352011-09-18 Paul Eggert <eggert@cs.ucla.edu>
836
87e4427a
PE
837 Fix minor problem found by static checking.
838 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
839 initialized, to pacify gcc -Wuninitialized.
840
e5e9d610
PE
841 * fileio.c: Report proper errno when syscall falls.
842 (Finsert_file_contents): Save and restore errno,
843 so that report_file_error outputs the correct diagnostic.
844 (Fwrite_region) [CLASH_DETECTION]: Likewise.
845
a1674f0b
EZ
8462011-09-18 Eli Zaretskii <eliz@gnu.org>
847
848 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
849
fbfb6dd4
EZ
8502011-09-17 Eli Zaretskii <eliz@gnu.org>
851
852 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
853 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
854
bb187662
EZ
8552011-09-17 Eli Zaretskii <eliz@gnu.org>
856
1137e8b8 857 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 858 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
859
860 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
861 (bidi_find_paragraph_start): Search back for paragraph beginning
862 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
863 (bidi_move_to_visually_next): Only trigger paragraph-related
864 computations when the last character is a newline or at EOB, not
865 just any NEUTRAL_B. (Bug#9470)
866
bb187662
EZ
867 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
868 truncated lines if point is covered by a display string. (Bug#9524)
869
2e621251
PE
8702011-09-16 Paul Eggert <eggert@cs.ucla.edu>
871
872 * xselect.c: Relax test for outgoing X longs (Bug#9498).
873 (cons_to_x_long): New function.
874 (lisp_data_to_selection_data): Use it. Correct the test for
875 short-versus-long data; it was negated. Break out of vector
876 loop, for efficiency, when a long datum is discovered.
877
91a15bc6
SM
8782011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
879
880 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
881
b41c3a35
EZ
8822011-09-16 Eli Zaretskii <eliz@gnu.org>
883
884 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
885 GCC PR/17406) by declaring this function with external scope.
886
7812ba2d
PE
8872011-09-15 Paul Eggert <eggert@cs.ucla.edu>
888
889 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
890 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
891
cf7edc2a
AS
8922011-09-15 Andreas Schwab <schwab@linux-m68k.org>
893
894 * editfns.c (Fformat): Correctly handle text properties on "%%".
895
bd01620e
EZ
8962011-09-15 Eli Zaretskii <eliz@gnu.org>
897
898 * xterm.c (x_draw_composite_glyph_string_foreground):
899 * w32term.c (x_draw_composite_glyph_string_foreground):
900 * term.c (encode_terminal_code):
901 * composite.c (composition_update_it, get_composition_id):
902 * xdisp.c (get_next_display_element)
903 (fill_composite_glyph_string): Add comments about special meaning
904 of TAB characters in a composition.
905
a02719a3
PE
9062011-09-15 Paul Eggert <eggert@cs.ucla.edu>
907
908 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
909 This occurs when processing a multibyte format.
910 Problem reported by Wolfgang Jenker.
a02719a3 911
72589a3c
JB
9122011-09-15 Johan Bockgård <bojohan@gnu.org>
913
914 * xdisp.c (try_cursor_movement): Only check for exact match if
915 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
916
1c14176c
PE
9172011-09-14 Paul Eggert <eggert@cs.ucla.edu>
918
919 Remove unused external symbols.
920 * dispextern.h (calc_pixel_width_or_height): Remove decl.
921 * xdisp.c (calc_pixel_width_or_height): Now static.
922 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
923 * indent.c (check_display_width):
924 * w32term.c: Fix comment to match code.
925 * xterm.c, xterm.h (x_catching_errors): Remove.
926
d2eea5b5
PE
9272011-09-14 Paul Eggert <eggert@cs.ucla.edu>
928
929 * xselect.c: Use signed conversions more consistently (Bug#9498).
930 (selection_data_to_lisp_data): Assume incoming selection data are
931 signed integers, not unsigned. This is to be consistent with
932 outgoing selection data, which was modified to use signed integers
933 in as part of the fix to Bug#9196 in response to Jan D.'s comment
934 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
935 expects long, not unsigned long.
936
46888499
EZ
9372011-09-14 Eli Zaretskii <eliz@gnu.org>
938
939 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
940 computation of loop end. Reported by Johan Bockgård
941 <bojohan@gnu.org>.
942
ef8ef9fb
CY
9432011-09-13 Chong Yidong <cyd@stupidchicken.com>
944
945 * frame.c (Fother_visible_frames_p): Function deleted.
946
fa819fed
EZ
9472011-09-12 Eli Zaretskii <eliz@gnu.org>
948
949 * indent.c (compute_motion): Process display vector front to back
950 rather than the other way around. (Bug#2496)
951
2ba8e008
SM
9522011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
953
954 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
955
20f53c69
CY
9562011-09-11 Chong Yidong <cyd@stupidchicken.com>
957
958 * minibuf.c (Fread_from_minibuffer): Doc fix.
959
d562d7a4
EZ
9602011-09-11 Eli Zaretskii <eliz@gnu.org>
961
962 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
963 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
964
1c4d7f3d
LMI
9652011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
966
967 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
968 value for non-existent files.
969
b885bf36
EZ
9702011-09-11 Eli Zaretskii <eliz@gnu.org>
971
972 * fileio.c (Finsert_file_contents): If the file cannot be opened,
973 set its "size" to -1. This will set the modtime_size field of
974 the corresponding buffer to -1, which is what
975 verify-visited-file-modtime expects for files that do not exist.
976 (Bug#9139)
977
6612f0bf
PE
9782011-09-11 Paul Eggert <eggert@cs.ucla.edu>
979
980 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
981 here ...
982 * lisp.h: ... from here. push_key_description is no longer
983 defined in keyboard.c, so its declaration should not be in
984 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
985 logically belongs with push_key_description.
986
dfb3f755
PE
9872011-09-10 Paul Eggert <eggert@cs.ucla.edu>
988
989 * buffer.h: Include <sys/types.h> instead of <time.h>.
990 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
991 Problem reported by Herbert J. Skuhra.
992
3134906c
LMI
9932011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
994
995 * xml.c (parse_region): Make the parsing work for
996 non-comment-starting XML files again (bug#9144).
997
8d903f4e
AS
9982011-09-10 Andreas Schwab <schwab@linux-m68k.org>
999
1000 * image.c (gif_load): Fix calculation of bottom and right corner.
1001 (Bug#9468)
1002
80ad64f4
EZ
10032011-09-10 Eli Zaretskii <eliz@gnu.org>
1004
1005 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1006 redisplay in small windows.
1007
208a048d
EZ
10082011-09-09 Eli Zaretskii <eliz@gnu.org>
1009
1010 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1011
9b1c252e
MR
10122011-09-08 Martin Rudalics <rudalics@gmx.at>
1013
1014 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1015 Operate on live windows only.
1016
2949f33b
JB
10172011-09-08 Juanma Barranquero <lekktu@gmail.com>
1018
1019 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1020
e08dcafd
EZ
10212011-09-07 Eli Zaretskii <eliz@gnu.org>
1022
1023 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1024 only under bidi iteration.
1025
115b96bd
JD
10262011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1027
1028 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1029
c8199d0f
PE
10302011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1031
1032 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1033 Without this fix, the command to link temacs failed due to an
1034 undefined symbol __builtin_isnan. This is because
1035 /usr/include/iso/math_c99.h #defines isnan(x) to
1036 __builtin_isnan(x), but the bundled gcc, which identifies itself
1037 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1038 a __builtin_isnan.
1039 * floatfns.c (isnan): #undef, and then #define to a clone of
1040 what's in data.c.
1041 (Fisnan): Always define, since it's always available now.
1042 (syms_of_floatfns): Always define isnan at the Lisp level.
1043
e39b275c 10442011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
1045
1046 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1047
b2db44d9 10482011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 1049
f4af5137 1050 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
1051 The previous code assumed that file offsets (off_t values) fit in
1052 EMACS_INT variables, which is not true on typical 32-bit hosts.
1053 The code messed up by falsely reporting buffer overflow in cases
1054 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1055 when "big" contains more than 2**29 bytes, even though this
1056 inserts just one byte and does not overflow the buffer.
1057 (Finsert_file_contents): Store file offsets as off_t
1058 values, not as EMACS_INT values. Check for overflow when
1059 converting between EMACS_INT and off_t. When checking for
1060 buffer overflow or for overlap, take the offsets into account.
1061 Don't use EMACS_INT for small values where int suffices.
1062 When checking for overlap, fix a typo: ZV was used where
1063 ZV_BYTE was intended.
1064 (Fwrite_region): Don't assume off_t fits into 'long'.
1065 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1066
ecfc0a49
MA
10672011-09-05 Michael Albinus <michael.albinus@gmx.de>
1068
1069 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1070
6511acf2 10712011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 1072
0999621a 1073 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
1074
1075 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 1076 (esprintf, exprintf, evxprintf): New functions.
62f19c19 1077 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 1078 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
1079 (modify_event_symbol): Do not assume that the length of
1080 name_alist_or_stem is safe to alloca and fits in int.
1081 (Fexecute_extended_command): Likewise for function name and binding.
1082 (Frecursion_depth): Wrap around reliably on integer overflow.
1083 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1084 since some callers pass EMACS_INT values.
1085 (Fsingle_key_description): Don't crash if symbol name contains more
1086 than MAX_ALLOCA bytes.
1087 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1088 (get_minibuffer): Arg is now EMACS_INT, not int.
1089 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 1090 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
1091 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1092
2be7d702
PE
1093 * dbusbind.c (signature_cat): New function.
1094 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
1095 Do not overrun buffer; instead, report string overflow.
1096
9d1df220
PE
1097 * dispnew.c (add_window_display_history): Don't overrun buffer.
1098 Truncate instead; this is OK since it's just a log.
1099
33ef5c64
PE
1100 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1101 even if the time zone offset is outlandishly large.
1102 Don't mishandle offset == INT_MIN.
1103
66c6fdd5
PE
1104 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1105 when creating daemon; the previous buffer-overflow check was incorrect.
1106
d749b01b
PE
1107 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1108 which has the guts of the old verror function.
1109
b5cd1905
PE
1110 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1111 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1112
6e1a67fb
PE
1113 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1114 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 1115 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 1116 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
1117 length of string rather than counting it via multiple sprintfs;
1118 that's simpler and more reliable.
c21721cc
PE
1119 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1120 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1121 sprintf, in case result does not fit in int.
1122
c57b67fc
PE
1123 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1124 (fontset_from_font): Print it.
1125
8a401434
PE
1126 * frame.c (tty_frame_count): Now printmax_t, not int.
1127 (make_terminal_frame, set_term_frame_name): Print it.
1128 (x_report_frame_params): In X, window IDs are unsigned long,
1129 not signed long, so print them as unsigned.
1130 (validate_x_resource_name): Check for implausibly long names,
1131 and don't assume name length fits in 'int'.
1132 (x_get_resource_string): Don't blindly alloca invocation name;
1133 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1134 not fit in int.
1135
6e1a67fb
PE
1136 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1137 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
1138 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1139
0df02bf3
PE
1140 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1141 Use esprintf, not sprintf, in case result does not fit in int.
1142
48e30793
PE
1143 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1144 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1145 it as a large positive number.
1146 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1147 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1148
a66ff6d8
PE
1149 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1150 in case result does not fit in int.
1151
aca216ff
PE
1152 * print.c (float_to_string): Detect width overflow more reliably.
1153 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1154 buffer overrun. Don't assume list length fits in 'int'. Treat
1155 print length of 0 as 0, not as infinity; to be consistent with other
1156 uses of print length in this function. Don't overflow print length
1157 index. Don't assume hash table size fits in 'long', or that
1158 vectorlike size fits in 'unsigned long'.
1159
31c286f7
PE
1160 * process.c (make_process): Use printmax_t, not int, to format
1161 process-name gensyms.
1162
55e5faa1
PE
1163 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1164
80f2e268
PE
1165 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1166 to avoid potential buffer overrun.
1167
670741ab
PE
1168 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1169 if X resource line is longer than 512 bytes.
1170
b7163a50
PE
1171 * xfns.c (x_window): Make sprintf buffer a bit bigger
1172 to avoid potential buffer overrun.
1173
ae58ff1f
PE
1174 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1175
c43c8a6a
PE
1176 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1177
3f8236f4
PE
11782011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1179
53e9fe90 1180 Integer overflow fixes for scrolling, etc.
6511acf2
PE
1181 Without these, Emacs silently mishandles large integers sometimes.
1182 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
1183 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1184
6511acf2
PE
1185 * xdisp.c (try_window_id): Check Emacs fixnum range before
1186 converting to 'int'.
806add1d 1187
6511acf2 1188 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
1189 Check that an Emacs fixnum is in range before assigning it to 'int'.
1190 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1191 values converted from Emacs fixnums.
1192 (Frecenter): Don't wrap around a line count if it is out of 'int'
1193 range; instead, treat it as an extreme value.
1194 (Fset_window_configuration, compare_window_configurations):
1195 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1196
6511acf2
PE
1197 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1198 that can exceed INT_MAX. Check that EMACS_INT value is in range
1199 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
1200 (match_limit): Don't assume that a fixnum can fit in 'int'.
1201
6511acf2 1202 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
1203 exceed INT_MAX.
1204
6511acf2 1205 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
1206 (Fvertical_motion): Don't wrap around LINES values that don't fit
1207 in 'int'. Instead, treat them as extreme values. This is good
1208 enough for windows, which can't have more than INT_MAX lines anyway.
1209
fcb901a7
LMI
12102011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1211
0f2f6b6d
LMI
1212 * Require libxml/parser.h to avoid compilation warning.
1213
fcb901a7
LMI
1214 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1215
1216 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1217 since this reportedly can destroy thread storage.
1218
6e20a0d4
CY
12192011-08-30 Chong Yidong <cyd@stupidchicken.com>
1220
1221 * syntax.c (find_defun_start): Update all cache variables if
1222 exiting early (Bug#9401).
1223
148ae00e
EZ
12242011-08-30 Eli Zaretskii <eliz@gnu.org>
1225
f6cfbd8f
EZ
1226 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1227
148ae00e
EZ
1228 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1229 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1230 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1231
1232 * term.c (tty_append_glyph): New function.
1233 (produce_stretch_glyph): Static function and its prototype deleted.
1234
a66cfb1c
SM
1235 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1236 Add prototypes.
148ae00e 1237
c4a07a4c
PE
12382011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1239
1240 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1241 when checking :margin (Bug#9390).
1242 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 1243 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
1244 so that the name doesn't mislead. All uses changed.
1245
6bc8cd65
JB
12462011-08-28 Johan Bockgård <bojohan@gnu.org>
1247
1248 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1249 set_tty_hooks.
1250
dca4927e
EZ
12512011-08-27 Eli Zaretskii <eliz@gnu.org>
1252
1253 * xdisp.c (move_it_to): Don't bail out early when reaching
1254 position beyond to_charpos, if we are scanning backwards.
1255 (move_it_vertically_backward): When DY == 0, make sure we get to
1256 the first character in the line after the newline.
1257
f2cad773
PE
12582011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1259
1260 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1261 (ccl_driver): Do not generate an out-of-range pointer.
1262 (Fccl_execute_on_string): Remove unnecessary check for
1263 integer overflow, noted by Stefan Monnier in
1264 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1265 Remove a FIXME that didn't need fixing.
1266 Simplify the newly-introduced buffer reallocation code.
1267
0cae2cdb
JB
12682011-08-27 Juanma Barranquero <lekktu@gmail.com>
1269
1270 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1271
5fc295a4 12722011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 1273
70c60eb2 1274 Integer and memory overflow issues (Bug#9196).
726e0ab1 1275
d31850da
PE
1276 * doc.c (get_doc_string): Rework so that
1277 get_doc_string_buffer_size is the actual buffer size, rather than
1278 being 1 less than the actual buffer size; this makes xpalloc more
1279 convenient.
1280
a69fbedb
PE
1281 * image.c (x_allocate_bitmap_record, cache_image):
1282 * xselect.c (Fx_register_dnd_atom):
1283 Simplify previous changes by using xpalloc.
1284
fe5c5d37
PE
1285 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1286 since either will do and ptrdiff_t is convenient with xpalloc.
1287
0065d054
PE
1288 * charset.c (charset_table_size)
1289 (struct charset_sort_data.priority): Now ptrdiff_t.
1290 (charset_compare): Don't overflow if priorities differ greatly.
1291 (Fsort_charsets): Don't assume list length fits in int.
1292 Check for size-calculation overflow when allocating sort data.
1293 (syms_of_charset): Allocate an initial charset table that is
1294 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1295
1296 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1297
1298 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1299 The actual value is always <= INT_MAX, and leaving it unsigned made
1300 overflow checking harder.
1301
1302 * dispextern.h (struct glyph_matrix.rows_allocated)
1303 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1304 with xpalloc. The values are still always <= INT_MAX.
1305
1306 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1307
1308 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1309 (SAFE_NALLOCA): New macro.
1310
1311 * region-cache.c (struct boundary.pos, find_cache_boundary)
1312 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1313 (set_cache_region, invalidate_region_cache)
1314 (revalidate_region_cache, know_region_cache, region_cache_forward)
1315 (region_cache_backward, pp_cache):
1316 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1317 so that ptrdiff_t * can be passed to xpalloc.
1318 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1319 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1320 (pp_cache): Don't assume cache_len fits in int.
1321 * region-cache.h: Adjust extern decls to match.
1322
1323 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1324 EMACS_INT, since either will do, for xpalloc.
1325
1326 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1327 (xnmalloc, xnrealloc, xpalloc): New functions.
1328
726e0ab1
PE
1329 * bidi.c (bidi_shelve_header_size): New constant.
1330 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1331 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1332
51f30bc5 1333 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
1334 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1335 (overlay_strings):
1336 Don't update size of array until after memory allocation succeeds,
1337 because xmalloc/xrealloc may not return.
0065d054
PE
1338 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1339 now that we have proper integer overflow checking.
1340 (record_overlay_string, overlay_strings): Catch overflows when
1341 calculating size of overlay_str_buf.
726e0ab1 1342
0065d054
PE
1343 * callproc.c (Fcall_process): Check for size overflow when
1344 calculating size of args2.
1345 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1346 Normally we prefer signed values, but sticking with ptrdiff_t would
1347 require adding more-complicated checks.
726e0ab1
PE
1348
1349 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1350 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1351 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 1352 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
1353
1354 * character.c (Fstring): Check for size-calculation overflow.
1355
1356 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1357 unnecessary integer overflow. Check for size overflow.
1358 (encode_coding_object): Don't update size until xmalloc succeeds.
1359
1360 * composite.c (get_composition_id): Check for overflow in glyph
1361 length calculations.
1362
1363 Integer and memory overflow fixes for display code.
1364 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1365 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1366 (scrolling_window): Check for overflow in size calculations.
1367 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1368 Don't assume glyph table len fits in int.
1369 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1370 (row_table_size): Now ptrdiff_t, not int.
1371 (scrolling_window): Avoid overflow in size calculations.
1372 Don't update size until allocation succeeds.
1373 * fns.c (concat): Check for overflow in size calculations.
1374 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1375 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1376 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1377
1378 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1379 (get_doc_string): Check for size calculation overflow.
1380 Don't update size until allocation succeeds.
1381 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1382 EMACS_INT, where ptrdiff_t will do.
1383 (Fsubstitute_command_keys): Check for string overflow.
1384
1385 * editfns.c (set_time_zone_rule): Don't assume environment length
1386 fits in int.
1387 (message_length): Now ptrdiff_t, not int.
1388 (Fmessage_box): Don't update size until allocation succeeds.
1389 Don't assume message length fits in int.
1390 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1391
0065d054
PE
1392 * emacs.c (main): Do not reallocate argv, since there is a null at
1393 the end that can be overwritten, and this way there's no need to
1394 worry about size-calculation overflow.
1395 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
1396
1397 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1398 alloc succeeds.
1399 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1400
1401 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1402 (x_set_scroll_bar_width, x_figure_window_size):
1403 Check for integer overflow.
1404 (x_set_alpha): Do not assume XINT fits in int.
1405
1406 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1407 This is for the members text_lines, text_cols, total_lines, total_cols,
1408 where the system imposes an 'int' limit.
1409
1410 * fringe.c (Fdefine_fringe_bitmap):
1411 Don't update size until alloc works.
1412
1413 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1414 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1415
1416 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1417 Check for size-calculation overflow.
1418 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1419 do, as we prefer signed integers.
1420 (id_to_widget.max_size, id_to_widget.used)
1421 (xg_store_widget_in_map, xg_remove_widget_from_map)
1422 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1423 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1424 Use and return ptrdiff_t, not int.
1425 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1426 * gtkutil.h: Change prototypes to match the above.
1427
1428 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1429 are duplicate now that they've been promoted to lisp.h.
1430 (x_allocate_bitmap_record, x_alloc_image_color)
1431 (make_image_cache, cache_image, xpm_load):
1432 Don't update size until alloc is done.
1433 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1434 (x_detect_edges):
3256efce 1435 Check for size calculation overflow.
726e0ab1
PE
1436 (ct_colors_allocated_max): New constant.
1437 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1438 overflow.
3256efce 1439
726e0ab1
PE
1440 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1441 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1442 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1443 Use ptrdiff_t, not int, to count maps.
1444 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
1445 calculations. Don't update size until allocation succeeds.
1446 Redo calculations to avoid overflow.
726e0ab1
PE
1447 * keyboard.h: Change prototypes to match the above.
1448
1449 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1450 to count maps.
1451 (current_minor_maps): Check for size calculation overflow.
1452 * keymap.h: Change prototypes to match the above.
1453
1454 * lread.c (read1, init_obarray): Don't update size until alloc done.
1455
1456 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1457 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1458
726e0ab1
PE
1459 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1460 Now ptrdiff_t, not int.
1461 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1462 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1463
1464 * process.c (Fnetwork_interface_list): Check for overflow
1465 in size calculation.
1466
1467 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1468
1469 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1470 overflow. Don't bother calling xmalloc when xrealloc will do.
1471
1472 * search.c (Freplace_match): Check for size calculation overflow.
1473 (Fset_match_data): Don't assume list lengths fit in 'int'.
1474
1475 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1476 for command line length. Do not attempt to address one before the
1477 beginning of an array, as that's not portable.
1478
1479 * term.c (max_frame_lines): Remove; unused.
1480 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1481 not int.
1482 (encode_terminal_code, calculate_costs): Check for size
1483 calculation overflow.
1484 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1485 table lengths and related sizes. Don't update size until alloc
1486 done. Redo calculations to avoid overflow.
1487 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1488
1489 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1490 subtracting pointers.
1491 (gobble_line): Check for overflow more carefully. Don't update size
1492 until alloc done.
1493
1494 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1495 Don't update size until alloc done.
1496 Redo size calculations to avoid overflow.
1497 Check for size calculation overflow.
0065d054 1498 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
1499
1500 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1501 Use ptrdiff_t, not int, for sizes.
1502 (store_mode_line_noprop_char): Don't update size until alloc done.
1503
0065d054
PE
1504 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1505 Use ptrdiff_t, not int, for sizes.
1506 (Finternal_make_lisp_face, cache_face):
1507 Check for size calculation overflow.
1508 (cache_face): Treat size calculation overflows as if they were
1509 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
1510
1511 * xfns.c (x_encode_text, x_set_name_internal)
1512 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1513 sizes, since they can exceed INT_MAX in size. Check for size
1514 calculation overflow.
1515
0065d054
PE
1516 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1517 (xg_select): Check for size calculation overflow.
726e0ab1
PE
1518 Don't update size until alloc done.
1519
0065d054 1520 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 1521 as sprintf is limited to int lengths.
1d526e2f 1522
252c5ee1
PE
1523 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1524 (X_LONG_MIN): New macros.
864d7ce7
PE
1525 Use them to make the following changes clearer.
1526 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1527 This change doesn't affect the value now, but it may help remind
1528 future maintainers not to raise the value too much later.
1529 (SELECTION_QUANTUM): Remove, replacing with ...
1530 (selection_quantum): ... new function, which avoids overflow.
1531 All uses changed.
1532 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1533 assumption that selection length fits in 'int'.
1534 (x_reply_selection_request, x_handle_selection_request)
1535 (x_get_window_property, receive_incremental_selection)
1536 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1537 (lisp_data_to_selection_data, clean_local_selection_data):
1538 Use ptrdiff_t, not int, to record length of selection.
1539 (x_reply_selection_request, x_get_window_property)
1540 (receive_incremental_selection, x_property_data_to_lisp):
1541 Redo calculations to avoid overflow.
1542 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 1543 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
1544 something.
1545 (x_get_window_property, receive_incremental_selection)
1546 (lisp_data_to_selection_data, x_property_data_to_lisp):
1547 Check for size-calculation overflow.
1548 (x_get_window_property, receive_incremental_selection)
1549 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1550 Don't store size until memory allocation succeeds.
1551 (x_get_window_property): Plug memory leak on memory exhaustion.
1552 Don't double-block input; malloc is safe here. Don't assume 2**34
1553 - 4 fits in unsigned long. Add an xassert to check
1554 XGetWindowProperty overflow. Be more careful about overflow
1555 calculations, and distinguish size from memory overflow better.
1556 (receive_incremental_selection): When tracing, don't assume
1557 unsigned int is less than INT_MAX.
1558 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1559 harmful) conversions of unsigned short to int.
1560 (lisp_data_to_selection_data): Don't assume that integers
1561 in the range -65535 through -1 fit in an X unsigned short.
1562 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1563 result parameters unless successful. Rely on cons_to_unsigned
1564 to report problems with elements; the old code wasn't right anyway.
1565 (x_check_property_data): Check for int overflow; we cannot use
1566 a wider type due to X limits.
1567 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1568
726e0ab1 1569 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 1570
0065d054
PE
1571 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1572 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
1573 (x_color_cells): Don't store size until memory allocation succeeds.
1574 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 1575 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
1576 (x_term_init): Don't assume length fits in int (sprintf is limited
1577 to int size).
bc18e09d 1578
ebfa62c0
PE
1579 Use ptrdiff_t for composition IDs.
1580 * character.c (lisp_string_width):
1581 * composite.c (composition_table_size, n_compositions)
1582 (get_composition_id, composition_gstring_from_id):
1583 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1584 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1585 * window.c (Frecenter):
1586 Use ptrdiff_t, not int, for composition IDs.
1587 * composite.c (get_composition_id): Check for integer overflow.
1588 * composite.h: Adjust prototypes to match the above changes.
1589
d3411f89
PE
1590 Use ptrdiff_t for hash table indexes.
1591 * category.c (hash_get_category_set):
1592 * ccl.c (ccl_driver):
1593 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1594 * coding.c (coding_system_charset_list, detect_coding_system):
1595 * coding.h (struct coding_system.id):
1596 * composite.c (get_composition_id, gstring_lookup_cache):
1597 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1598 * image.c (xpm_get_color_table_h):
1599 * lisp.h (hash_lookup, hash_put):
1600 * minibuf.c (Ftest_completion):
1601 Use ptrdiff_t for hash table indexes, not int (which is too
1602 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1603 32-bit --with-wide-int hosts).
1604
e097a6fa
PE
1605 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1606 Add a FIXME comment about memory leaks.
1607 (syms_of_charset): Don't assume xmalloc returns.
1608
5637687f
PE
1609 Don't assume that stated character widths fit in int.
1610 * character.c (Fchar_width, c_string_width, lisp_string_width):
1611 * character.h (CHAR_WIDTH):
1612 * indent.c (MULTIBYTE_BYTES_WIDTH):
1613 Use sanitize_char_width to avoid undefined and/or bad behavior
1614 with outlandish widths.
a66cfb1c 1615 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
1616 now that we have two such functions. All uses changed.
1617 (sanitize_char_width): New inline function.
1618
a2271ba2
PE
1619 Don't assume that tab-width fits in int.
1620 * character.h (sanitize_width): New inline function.
1621 (SANE_TAB_WIDTH): New macro.
1622 (ASCII_CHAR_WIDTH): Use it.
1623 * indent.c (sane_tab_width): Remove. All uses replaced by
1624 SANE_TAB_WIDTH (current_buffer).
1625 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1626
18c52557
PE
1627 * fileio.c: Integer overflow issues with file modes.
1628 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1629
caeeedc1
PE
1630 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1631 Remove unreachable code.
1632 (read_hex, load_charset_map_from_file): Check for integer overflow.
1633
50849c52
PE
1634 * xterm.c: don't go over XClientMessageEvent limit
1635 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1636 (x_send_scroll_bar_event): Likewise. Check that the size does not
1637 exceed limits imposed by XClientMessageEvent, as well as the usual
1638 ptrdiff_t and size_t limits.
1639
b13995db
PE
1640 * keyboard.c: Overflow, signedness and related fixes.
1641 (make_lispy_movement): Use same integer type in forward decl
1642 that is used in the definition.
1643 (read_key_sequence, keyremap_step):
1644 Change bufsize argument back to int, undoing my 2011-03-30 change.
1645 We prefer signed types, and int is wide enough here.
1646 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1647 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1648 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1649 length, not size_t. Use ptrdiff_t for index, not int.
1650 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1651 possibility of integer overflow.
1652
13464394
PE
1653 Overflow, signedness and related fixes for images.
1654
1655 * dispextern.h (struct it.stack[0].u.image.image_id)
1656 (struct_it.image_id, struct image.id, struct image_cache.size)
1657 (struct image_cache.used, struct image_cache.ref_count):
1658 * gtkutil.c (update_frame_tool_bar):
1659 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1660 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1661 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1662 * nsmenu.m (update_frame_tool_bar):
1663 * xdisp.c (calc_pixel_width_or_height):
1664 * xfns.c (image_cache_refcount):
1665 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1666 on typical 64-bit hosts.
1667
1668 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1669 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1670 Omit unnecessary casts to int.
1671 (parse_image_spec): Check that integers fall into 'int' range
1672 when the callers expect that.
1673 (image_ascent): Redo ascent calculation to avoid int overflow.
1674 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1675 (lookup_image): Remove unnecessary tests.
1676 (xbm_image_p): Locals are now of int, not EMACS_INT,
1677 since parse_image_check makes sure they fit into int.
1678 (png_load, gif_load, svg_load_image):
1679 Prefer int to unsigned where either will do.
1680 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
1681 old tiff_error_handler and tiff_warning_handler.
1682 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
1683 stack buffer overflows. It uses only the features of vsnprintf
1684 that are common to both POSIX and native Microsoft.
1685 (tiff_error_handler, tiff_warning_handler): Use it.
1686 (tiff_load, gif_load, imagemagick_load_image):
1687 Don't assume :index value fits in 'int'.
1688 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1689 (imagemagick_load_image): Check that crop parameters fit into
1690 the integer types that MagickCropImage accepts. Don't assume
1691 Vimagemagick_render_type has a nonnegative value. Don't assume
1692 size_t fits in 'long'.
1693 (gs_load): Use printmax_t to print the widest integers possible.
1694 Check for integer overflow when computing image height and width.
1695
c11821d4
EZ
16962011-08-26 Eli Zaretskii <eliz@gnu.org>
1697
1698 * xdisp.c (redisplay_window): Don't force window start if point
1699 will be invisible in the resulting window. (Bug#9324)
1700
0c95fcf7
EZ
17012011-08-25 Eli Zaretskii <eliz@gnu.org>
1702
1703 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1704 the display spec is of the form `(space ...)'.
1705 (handle_display_spec): Return the value returned by
1706 handle_single_display_spec, not just 1 or zero.
1707 (handle_single_display_spec): If the display spec is of the form
1708 `(space ...)', and specifies display in the text area, return 2
1709 rather than 1.
fee65a97 1710 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
1711 accurately, and prefer exact match for point under bidi.
1712 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
1713
1714 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1715 into disp_prop; all users changed.
1716
1717 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1718 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1719 for the text covered by the display property.
1720
e4ed06f1
CY
17212011-08-25 Chong Yidong <cyd@stupidchicken.com>
1722
1723 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1724 Change return value to nil.
1725 (Frecord_buffer): Delete unused function.
1726
f67cdd7f
EZ
17272011-08-24 Eli Zaretskii <eliz@gnu.org>
1728
5980d4c6
EZ
1729 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1730 buffers, return left-to-right.
8610fe8b
EZ
1731 (set_cursor_from_row): Consider candidate row a win if its glyph
1732 represents a newline and point is on that newline. Fixes cursor
1733 positioning on the newline at EOL of R2L text within L2R
1734 paragraph, and vice versa.
1735 (try_cursor_movement): Check continued rows, in addition to
1736 continuation rows. Fixes unwarranted scroll when point enters a
1737 continued line of R2L text within an L2R paragraph, or vice versa.
1738 (cursor_row_p): Consider the case of point being equal to
1739 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1740 from the end of a short line to the beginning of a continued line
1741 of R2L text within L2R paragraph.
1742 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1743 composed characters.
5980d4c6 1744
f67cdd7f
EZ
1745 * bidi.c (bidi_check_type): Use xassert.
1746 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1747 members.
1748
bca633fb
EZ
17492011-08-23 Eli Zaretskii <eliz@gnu.org>
1750
1751 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1752 a character.
1753
4a5885a7
CY
17542011-08-23 Chong Yidong <cyd@stupidchicken.com>
1755
1756 * nsfont.m (ns_otf_to_script): Fix typo.
1757
0902a04e
KH
17582011-08-22 Kenichi Handa <handa@m17n.org>
1759
1760 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1761 extra slot even if the purpose is char-code-property-table.
1762
1a2e6670
EZ
17632011-08-23 Eli Zaretskii <eliz@gnu.org>
1764
8ddde651
EZ
1765 * xdisp.c (redisplay_window): When computing centering_position,
1766 account for the height of the header line. (Bug#8874)
1767
425cc014
EZ
1768 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1769 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1770 candidate is selected by the mouse, and that candidate has a
1771 composed character under the mouse.
1772
1a2e6670
EZ
1773 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1774 coordinates reported by pos-visible-in-window-p for a composed
1775 character in column zero.
1776
8b76d6f8
SM
17772011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1778
1779 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1780
dac347dd
EZ
17812011-08-22 Eli Zaretskii <eliz@gnu.org>
1782
1783 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1784 consider it a hit if to_charpos is anywhere in the range of the
1785 composed buffer positions.
1786
e013fb34
CY
17872011-08-22 Chong Yidong <cyd@stupidchicken.com>
1788
1789 * image.c (gif_load): Don't assume that each subimage has the same
1790 dimensions as the base image. Handle disposal method that is
1791 "undefined" by the gif spec (Bug#9335).
1792
bd1ba3e8
CY
17932011-08-20 Chong Yidong <cyd@stupidchicken.com>
1794
1795 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 1796 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 1797
54a1215b
EZ
17982011-08-19 Eli Zaretskii <eliz@gnu.org>
1799
823564e5
EZ
1800 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1801 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1802 from an Org mode buffer to a Speedbar frame.
1803
54a1215b
EZ
1804 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1805 a composition, take its buffer position from IT->cmp_it.charpos.
1806 Fixes cursor positioning at the beginning of a line that begins
1807 with a composed character.
1808
9778ebcc
EZ
18092011-08-18 Eli Zaretskii <eliz@gnu.org>
1810
0be6ee06
EZ
1811 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1812 character bidirectional type, use STRONG_L instead. Fixes crashes
1813 in a buffer produced by `describe-categories'.
1814
9778ebcc
EZ
1815 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1816 members before the level stack, so they would be saved and
1817 restored when copying iterator state. Fixes incorrect reordering
1818 around TABs covered by display properties.
1819
156bffbe
AS
18202011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1821
6b02f655 1822 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 1823
72ad093b
CY
18242011-08-17 Chong Yidong <cyd@stupidchicken.com>
1825
1826 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
1827 (internal_condition_case_2, internal_condition_case_n):
1828 Remove unnecessary aborts (Bug#9081).
72ad093b 1829
35774242
EZ
18302011-08-17 Eli Zaretskii <eliz@gnu.org>
1831
1832 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1833 has no `load' handler, try opening the file locally. (Bug#9311)
1834
db76dd85
KB
18352011-08-16 Ken Brown <kbrown@cornell.edu>
1836
1837 * gmalloc.c: Expand comment.
1838
b215eee5
EZ
18392011-08-16 Eli Zaretskii <eliz@gnu.org>
1840
1841 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1842 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1843
a4579d33
KB
18442011-08-16 Ken Brown <kbrown@cornell.edu>
1845
1846 Fix memory allocation problems in Cygwin build (Bug#9273).
1847
1848 * unexcw.c ( __malloc_initialized): Declare external variable.
1849 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1850
8b76d6f8
SM
1851 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1852 New variables.
a4579d33
KB
1853 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1854 dumped emacs.
1855 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1856 in the static heap.
1857 [CYGWIN] (special_realloc): New function.
1858 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1859 requests to realloc storage in the static heap.
1860
3ebec551
PE
18612011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1862
1863 * bidi.c (bidi_initialize): Remove unused local.
1864
9fd8be00
EZ
18652011-08-15 Eli Zaretskii <eliz@gnu.org>
1866
6b02f655
SM
1867 * bidimirror.h:
1868 * biditype.h: Remove file.
1869 * makefile.w32-in ($(BLD)/bidi.$(O)):
1870 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
1871
1872 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1873
1874 * chartab.c: Improve commentary for the uniprop_table API.
1875
32413314
EZ
1876 * bidi.c (bidi_paragraph_init): Support zero value of
1877 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
1878 (bidi_initialize): Use uniprop_table instead of including
1879 biditype.h and bidimirror.h.
32413314 1880
9fd8be00
EZ
1881 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1882 coordinates of the iterator when restoring from ppos_it.
1883 (Bug#9296)
1884
5cf2b69b
KH
18852011-08-14 Kenichi Handa <handa@m17n.org>
1886
1887 * process.c (create_process): Call setup_process_coding_systems
72ad093b 1888 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 1889
daf17d00
EZ
18902011-08-14 Eli Zaretskii <eliz@gnu.org>
1891
1892 * xdisp.c (move_it_in_display_line_to): Don't invoke
1893 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1894 ppos_it. Fixes vertical cursor motion when line beginning is
1895 covered by an image. (Bug#9296)
1896
08e3161a
JD
18972011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1898
1899 * nsterm.h (ns_run_ascript): Declare.
1900 (NSAPP_DATA2_RUNASSCRIPT): Define.
1901
1902 * nsfns.m (as_script, as_result, as_status): New static variables.
1903 (ns_run_ascript): New function.
5e617bc2 1904 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
1905 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1906 the event loop. Get status from as_status (Bug#7276).
1907
1908 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1909 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1910 the event loop (Bug#7276).
1911
a3720aa2
AS
19122011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1913
1914 * gnutls.c (QCgnutls_bootprop_priority)
1915 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1916 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1917 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1918 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1919 (QCgnutls_bootprop_verify_hostname_error)
1920 (QCgnutls_bootprop_callbacks_verify): Rename from
1921 Qgnutls_bootprop_..., all uses changed.
1922
1923 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1924 uses changed.
1925
0a0d27fb
PE
19262011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1927
19d5c50c
PE
1928 * xfaces.c (Qframe_set_background_mode): Now static.
1929 * dispextern.h (Qframe_set_background_mode): Remove decl.
1930
0a0d27fb
PE
1931 * process.c (Fnetwork_interface_info): Declare local only if needed.
1932
377538cb
JD
19332011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1934
1935 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1936 (Fnetwork_interface_list): Allocate in increments of bytes instead
1937 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1938 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1939 sockaddr.
1940 (struct ifflag_def): notrailers is smart on OSX.
1941 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1942 Get hardware address with getifaddrs if available.
1943
08fff70c
EZ
19442011-08-12 Eli Zaretskii <eliz@gnu.org>
1945
1946 * xdisp.c (iterate_out_of_display_property): xassert that
1947 IT->position is set to within IT->object's boundaries. Break from
1948 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
1949 when IT->position is set up wrongly due to some bug.
1950 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
1951 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1952 entry. Force push_it to save on the stack the current
1953 buffer/string position, to be restored by pop_it. Fix flags in
1954 the iterator structure wrt the object coming from a display
1955 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1956 properties. (Bug#9284)
1957
7be1c708 19582011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 1959
7be1c708
CY
1960 * fontset.c (fontset_get_font_group): Add proper type checks.
1961 (Bug#9172)
aac0c6e3 1962
7be1c708 19632011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 1964
7be1c708
CY
1965 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1966 and LC_VERSION_MIN_MACOSX.
1967 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1968 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 1969
97bb72a6
EZ
19702011-08-08 Eli Zaretskii <eliz@gnu.org>
1971
1972 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
1973 no-display-properties-and-no-overlays under bidi display.
1974 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 1975 properties and overlays.
97bb72a6 1976
d5617611
CY
19772011-08-08 Chong Yidong <cyd@stupidchicken.com>
1978
37e11a63
CY
1979 * editfns.c (Fset_time_zone_rule): Document relationship with the
1980 setenv function.
1981
d5617611
CY
1982 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1983 the font entity extracted from the cache (Bug#8109).
1984
58872834
CY
19852011-08-07 Chong Yidong <cyd@stupidchicken.com>
1986
1987 * composite.c (autocmp_chars): Don't reset point. That is done by
1988 restore_point_unwind (Bug#5984).
1989
75bfc667
JL
19902011-08-07 Juri Linkov <juri@jurta.org>
1991
1992 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1993 to show the arg `TIME' instead of `TIMEVAL'.
1994
d1410150
EZ
19952011-08-06 Eli Zaretskii <eliz@gnu.org>
1996
1997 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1998 display property strides EOL and includes a newline, as in
1999 longlines-mode. (Bug#9254)
75b771e4
EZ
2000 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2001 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
2002
2003 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2004 is non-zero, even if the data buffer is NULL. Fixes a crash in
2005 vertical-motion with longlines-mode. (Bug#9254)
2006
35928349
EZ
20072011-08-05 Eli Zaretskii <eliz@gnu.org>
2008
ec7cc85b
EZ
2009 * bidi.c <bidi_cache_total_alloc>: Now static.
2010 (bidi_initialize): Initialize bidi_cache_total_alloc.
2011
8b76d6f8 2012 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
2013 cache. (Bug#9221)
2014
2015 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2016 amount allocated this far in `bidi_cache_total_alloc'.
2017 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2018 non-zero, only free the data buffer without restoring the cache
2019 contents. All callers changed.
2020
2021 * dispextern.h (bidi_unshelve_cache): Update prototype.
2022
2023 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2024 (move_it_in_display_line, move_it_to)
2025 (move_it_vertically_backward, move_it_by_lines): Replace the call
2026 to xfree to an equivalent call to bidi_unshelve_cache.
2027 (move_it_in_display_line_to): Fix logic of returning
412b6358 2028 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 2029
e2e2423b
EZ
20302011-08-05 Eli Zaretskii <eliz@gnu.org>
2031
2032 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2033 came from a string character with a `cursor' property. (Bug#9229)
2034
ae9e757a
JD
20352011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2036
2037 * Makefile.in (LIB_PTHREAD): New variable.
2038 (LIBES): Add LIB_PTHREAD (Bug#9216).
2039
2040 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2041 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2042
213bd7f2
AS
20432011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2044
6b02f655 2045 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 2046
99aaf75f
JD
20472011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2048
2049 * xterm.c (x_find_topmost_parent): New function.
2050 (x_set_frame_alpha): Find topmost parent window with
2051 x_find_topmost_parent and set the property there also (bug#9181).
2052 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2053
c74e9d86
PE
20542011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2055
2056 * callproc.c (Fcall_process): Avoid vfork clobbering
2057 the local vars buffer, coding_systems, current_dir.
2058
640c8776
SM
20592011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2060
2061 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2062
f26d0e4c
PE
20632011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2064
8a10d76c
PE
2065 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2066 so that it is not optimized away.
2067
f26d0e4c
PE
2068 * xdisp.c (compute_display_string_pos): Remove unused local.
2069
55439c61
EZ
20702011-08-02 Eli Zaretskii <eliz@gnu.org>
2071
2072 Fix slow cursor motion and scrolling in large buffers with
2073 selective display, like Org Mode buffers. (Bug#9218)
2074
2075 * dispextern.h (struct bidi_it): New member disp_prop_p.
2076
2077 * xdisp.c: Remove one-slot cache of display string positions.
2078 (compute_display_string_pos): Accept an additional argument
5e617bc2 2079 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
2080 for a display string or property. If found, set DISP_PROP_P
2081 non-zero.
2082
2083 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
2084 DISP_PROP_P, and pass it to compute_display_string_pos.
2085 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
2086 non-zero. All callers of bidi_fetch_char changed.
2087
fb33fa43
SM
20882011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2089
2090 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2091
b099e063
DM
20922010-12-03 Don March <don@ohspite.net>
2093
2094 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2095 last character M-[char] is translated to ESC [char] (bug#7541).
2096
5cc7f7af
KH
20972011-08-02 Kenichi Handa <handa@m17n.org>
2098
d0fffa3f 2099 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
2100
2101 * chartab.c (uniprop_table): Make it non-static.
2102
525d5e6e
EZ
21032011-08-01 Eli Zaretskii <eliz@gnu.org>
2104
2105 * xdisp.c (forward_to_next_line_start): Accept additional argument
2106 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2107 on the newline.
2108 (reseat_at_next_visible_line_start): Use the bidi iterator state
2109 returned by forward_to_next_line_start to restore the state of
2110 it->bidi_it after backing up to previous newline. (Bug#9212)
2111
31011111
AS
21122011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2113
2114 * regex.c (re_comp): Protoize.
2115 (re_exec): Fix return type.
2116 (regexec): Fix type of `ret'. (Bug#9203)
2117
476371c4
PE
21182011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2119
e5d76069
PE
2120 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2121 This is needed if max-image-size is a floating-point number.
2122
9a79b20c
AS
21232011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2124
2125 * print.c (print_object): Print empty symbol as ##.
2126
2127 * lread.c (read1): Read ## as empty symbol.
2128
d8c2fa78
AA
21292011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2130
2131 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2132 setting frame foreground color (Bug#9175).
2133 (x_set_background_color): Likewise.
2134
ffe57a7a
AA
2135 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2136 contents (Bug#9176).
2137 (EmacsTooltip -init): Remove bezels and add shadows to
2138 tooltip windows.
2139
bf3492a5
AA
2140 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2141 or scroll bar (Bug#8470).
2142
d55e9c53
AA
2143 * nsfont.m (nsfont_open): Remove assignment to voffset and
2144 unnecessary vars hshink, expand, hd, full_height, min_height.
2145 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2146
2147 * nsterm.h (nsfont_info): Remove voffset field.
2148
d8c2fa78 21492011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
2150
2151 Implement strike-through and overline on NextStep (Bug#8863).
2152
2153 * nsfont.m (nsfont_open): Use underline position provided by font,
2154 instead of hard-coded value of 2.
2155 (nsfont_draw): Call ns_draw_text_decoration instead.
2156
2157 * nsterm.h: Add declaration for ns_draw_text_decoration.
2158
2159 * nsterm.m (ns_draw_text_decoration): New function for drawing
2160 underline, overline, and strike-through.
2161 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2162 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 2163 accommodate underlining, etc.
4843aac3 2164
4cc60b9b
EZ
21652011-07-28 Eli Zaretskii <eliz@gnu.org>
2166
bc7ece87
EZ
2167 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2168 default.
4cc60b9b 2169
476371c4
PE
21702011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2171
66606eea
PE
2172 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2173 Without this fix, if a signal arrives just after memory fills up,
2174 'malloc' might be invoked reentrantly.
2175
476371c4
PE
2176 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2177 In other words, assume that every image size is allowed, on non-X
2178 hosts. This assumption is probably wrong, but it lets Emacs compile.
2179
f3fcc40d
AS
21802011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2181
2182 * regex.c (re_iswctype): Convert return values to boolean.
2183
350c992f
EZ
21842011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2185
2186 * xdisp.c (compute_display_string_pos): Don't use cached display
2187 string position if the buffer had its restriction changed.
2188 (Bug#9184)
2189
5266b4bb
PE
21902011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2191
2192 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2193
2573a837 21942011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 2195
41f55ccd 2196 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 2197
39e378da
PE
2198 * bidi.c: Integer size and overflow fixes.
2199 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2200 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2201 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2202 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2203 (bidi_find_other_level_edge):
2204 Use ptrdiff_t instead of EMACS_INT where either will do.
2205 This works better on 32-bit hosts configured --with-wide-int.
2206 (bidi_cache_ensure_space): Check for size-calculation overflow.
2207 Use % rather than repeated addition, for better worst-case speed.
2208 Don't set bidi_cache_size until after xrealloc returns, because it
2209 might not return.
2210 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
2211 (bidi_cache_ensure_space): Also check that the bidi cache size
2212 does not exceed that of the largest Lisp string or buffer. See Eli
2213 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 2214
5e927815
PE
2215 * alloc.c (__malloc_size_t): Remove.
2216 All uses replaced by size_t. See Andreas Schwab's note
2217 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2218
ca4aa935
PE
2219 * image.c: Improve checking for integer overflow.
2220 (check_image_size): Assume that f is nonnull, since
2221 it is always nonnull in practice. This is one less thing to
2222 worry about when checking for integer overflow later.
2223 (x_check_image_size): New function, which checks for integer
2224 overflow issues inside X.
2225 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2226 This removes the need for a memory_full check.
2227 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2228 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2229 (xbm_read_bitmap_data): Change locals back to 'int', since
2230 their values must fit in 'int'.
2231 (xpm_load_image, png_load, tiff_load):
2232 Invoke x_create_x_image_and_pixmap earlier,
2233 to avoid much needless work if the image is too large.
2234 (tiff_load): Treat overly large images as if
2235 x_create_x_image_and_pixmap failed, not as malloc failures.
2236 (gs_load): Use x_check_image_size.
2237
5f8f9cc2
PE
2238 * gtkutil.c: Omit integer casts.
2239 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2240 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2241
5adf60bc
PE
2242 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2243
c8907a93
PE
2244 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2245 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2246 would wrongly return t on a 64-bit host.
2247
e3c25c68
PE
2248 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2249 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2250 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2251 and therefore cause GCC to emit a bogus diagnostic in some cases.
2252
3f791afe
PE
2253 * image.c: Integer signedness and overflow and related fixes.
2254 This is not an exhaustive set of fixes, but it's time to
2255 record what I've got.
2256 (lookup_pixel_color, check_image_size): Remove redundant decls.
2257 (check_image_size): Don't assume that arbitrary EMACS_INT values
2258 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2259 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2260 (tiff_load, imagemagick_load_image):
2261 Check for overflow in size calculations.
2262 (x_create_x_image_and_pixmap): Remove unnecessary test for
2263 xmalloc returning NULL; that can't happen.
2264 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2265 (xpm_color_bucket): Use better integer hashing function.
2266 (xpm_cache_color): Don't possibly over-allocate memory.
2267 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2268 (gif_memory_source):
2269 Use ptrdiff_t, not int or size_t, to record sizes.
2270 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2271 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2272 either works, as we prefer signed integers.
2273 (tiff_read_from_memory, tiff_write_from_memory):
2274 Return tsize_t, not size_t, since that's what the TIFF API wants.
2275 (tiff_read_from_memory): Don't fail simply because the read would
2276 go past EOF; instead, return a short read.
2277 (tiff_load): Omit no-longer-needed casts.
2278 (Fimagemagick_types): Don't assume size fits into 'int'.
2279
3cc5a532
PE
2280 Improve hashing quality when configured --with-wide-int.
2281 * fns.c (hash_string): New function, taken from sxhash_string.
2282 Do not discard information about ASCII character case; this
2283 discarding is no longer needed.
2284 (sxhash-string): Use it. Change sig to match it. Caller changed.
2285 * lisp.h: Declare it.
2286 * lread.c (hash_string): Remove, since we now use fns.c's version.
2287 The fns.c version returns a wider integer if --with-wide-int is
2288 specified, so this should help the quality of the hashing a bit.
2289
b312a492
PE
2290 * emacs.c: Integer overflow minor fix.
2291 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2292 Define only if GNU_LINUX.
2293 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2294
dfd153ae
PE
2295 * dispnew.c: Integer signedness and overflow fixes.
2296 Remove unnecessary forward decls, that were a maintenance hassle.
2297 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2298 All uses changed.
2299 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2300 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2301 (prepare_desired_row, line_draw_cost):
2302 Use int, not unsigned, where either works.
2303 (save_current_matrix, restore_current_matrix):
2304 Use ptrdiff_t, not size_t, where either works.
2305 (init_display): Check for overflow more accurately, and without
2306 relying on undefined behavior.
2307
a81d11a3
PE
2308 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2309 Remove, replacing with the new symbols in lisp.h. All uses changed.
2310 * fileio.c (make_temp_name):
2311 * filelock.c (lock_file_1, lock_file):
2312 * xdisp.c (message_dolog):
2313 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2314 Use pMd etc. instead.
2315 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2316 replacing the pWIDE etc. symbols removed from editfns.c.
2317
3300e6fd
PE
2318 * keyboard.h (num_input_events): Now uintmax_t.
2319 This is (very slightly) less likely to mess up due to wraparound.
2320 All uses changed.
2321
fd05c7e9
PE
2322 * buffer.c: Integer signedness fixes.
2323 (alloc_buffer_text, enlarge_buffer_text):
2324 Use ptrdiff_t rather than size_t when either will do, as we prefer
2325 signed integers.
2326
903fe15d
PE
2327 * alloc.c: Integer signedness and overflow fixes.
2328 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2329 (__malloc_size_t): Default to size_t, not to int.
2330 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2331 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2332 Prefer ptrdiff_t to size_t when either would do, as we prefer
2333 signed integers.
2334 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2335 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2336 Now const. Initialize with values that are in range even if char
2337 is signed.
2338 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2339 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2340 These functions do the right thing with sizes > 2**32.
2341 (check_depth): Now ptrdiff_t, not int.
2342 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2343 Adjust to new way of storing sizes. Check for size overflow bugs
2344 in rest of code.
2345 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2346 slightly wrong anyway, as it missed one instance of
2347 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2348 (refill_memory_reserve): Omit needless cast to size_t.
2349 (mark_object_loop_halt): Mark as externally visible.
2350
ac82cc6a
PE
2351 * xselect.c: Integer signedness and overflow fixes.
2352 (Fx_register_dnd_atom, x_handle_dnd_message):
2353 Use ptrdiff_t, not size_t, since we prefer signed.
2354 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2355 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2356 x_dnd_atoms_size and x_dnd_atoms_length.
2357
c2d1e36d
PE
2358 * doprnt.c: Prefer signed to unsigned when either works.
2359 * eval.c (verror):
2360 * doprnt.c (doprnt):
2361 * lisp.h (doprnt):
2362 * xdisp.c (vmessage):
2363 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2364 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2365 prefer signed arithmetic to avoid comparison confusion.
2366 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2367 but is a bit tricky.
2368
0e926e56
PE
2369 Assume freestanding C89 headers, string.h, stdlib.h.
2370 * data.c, doprnt.c, floatfns.c, print.c:
2371 Include float.h unconditionally.
2372 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2373 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2374 * regex.c: Likewise for stddef.h, string.h.
2375 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2376 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2377 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2378 (STDC_HEADERS): Remove obsolete defines.
2379 * sysdep.c: Include limits.h unconditionally.
2380
9cfdb3ec
PE
2381 Assume support for memcmp, memcpy, memmove, memset.
2382 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2383 * regex.c (memcmp, memcpy):
2384 Remove; we assume C89 now.
2385
2386 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2387 (__malloc_safe_bcopy): Remove; no longer needed.
2388
cf950e6b 2389 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
2390 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2391 well either way, and we prefer signed to unsigned.
2392
dbf38e02
LMI
23932011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2394
2395 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2396 closes the connection while we're reading (bug#9182).
2397
d6f0886c 23982011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 2399
d6f0886c
JD
2400 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2401 are specified (Bug#9168).
24e0f6b1 2402
2eb1f9e6
PE
24032011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2404
2405 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2406 Found by GCC static checking and --with-wide-int on a 32-bit host.
2407
22381272 24082011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
2409
2410 * xdisp.c (compute_display_string_pos): Fix logic of caching
2411 previous display string position. Initialize cached_prev_pos to
2412 -1. Fixes slow-down at the beginning of a buffer.
2413
f25e39b4
EZ
24142011-07-24 Eli Zaretskii <eliz@gnu.org>
2415
2416 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2417 for attrs[LFACE_FONTSET_INDEX].
2418
04c4b52e
PE
24192011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2420
2421 * xml.c (parse_region): Remove unused local
2422 that was recently introduced.
2423
c1734fbd
EZ
24242011-07-23 Eli Zaretskii <eliz@gnu.org>
2425
be18c5a5
EZ
2426 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2427 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2428
c1734fbd
EZ
2429 * xdisp.c (move_it_in_display_line_to): Record the best matching
2430 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
2431 exit if none of the characters scanned was an exact match.
2432 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
2433 when exact match is impossible due to invisible text, and the
2434 lines are truncated.
2435
a258d627
JD
24362011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2437
2438 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2439 for OSX >= 10.7.
2440
b6d5a689
EZ
24412011-07-22 Eli Zaretskii <eliz@gnu.org>
2442
0f74f785
EZ
2443 Fix a significant slow-down of cursor motion with C-n, C-p,
2444 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2445 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 2446 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
2447 (next_element_from_buffer): Call compute_stop_pos_backwards to
2448 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
2449 base_level_stop.
2450 (reseat): Don't look for prev_stop, as that could mean a very long
2451 run.
2452 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2453 <cached_disp_overlay_modiff>: Cache for last found display string
2454 position.
551918c1 2455 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
2456 about the same buffer in the same area of character positions, and
2457 the buffer wasn't changed since the time the display string
2458 position was cached.
551918c1 2459
b2d0c91a
EZ
24602011-07-22 Eli Zaretskii <eliz@gnu.org>
2461
2462 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2463 is an integer, which is important for empty lines. (Bug#9149)
2464
043604ee
CY
24652011-07-22 Chong Yidong <cyd@stupidchicken.com>
2466
2467 * frame.c (Fmodify_frame_parameters): In tty case, update the
2468 default face if necessary (Bug#4238).
2469
da4adb04
CY
24702011-07-21 Chong Yidong <cyd@stupidchicken.com>
2471
2472 * editfns.c (Fstring_to_char): No need to explain what a character
2473 is in the docstring (Bug#6576).
2474
9abd0532
LMI
24752011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2476
2477 * xml.c (parse_region): Make sure we always return a tree.
2478
36881d16
HK
24792011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2480
2481 * xml.c (parse_region): If a document contains only comments,
2482 return that, too.
2483
1e98674d
LMI
24842011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2485
2486 * xml.c (make_dom): Return comments, too.
2487
590bd467
PE
24882011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2489
2490 Port to OpenBSD.
2491 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2492 and the surrounding thread.
2493 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2494 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2495 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2496 timer goes off.
2497 * s/openbsd.h (BROKEN_SIGIO): Define.
2498 * unexelf.c (unexec) [__OpenBSD__]:
2499 Don't update the .mdebug section of the Alpha COFF symbol table.
2500
f41628b2
LMI
25012011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2502
2503 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2504 (bug#8460).
2505
b59b67c5
PE
25062011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2507
15e3a074
PE
2508 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2509 This fixes some race conditions on the permissions of any newly
2510 created file.
2511
41bed37d
PE
2512 * alloc.c (valid_pointer_p): Use pipe, not open.
2513 This fixes some permissions issues when debugging.
2514
b59b67c5
PE
2515 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2516 If fchown fails to set both uid and gid, try to set just gid,
2517 as that is sometimes allowed. Adjust the file's mode to eliminate
2518 setuid or setgid bits that are inappropriate if fchown fails.
2519
925a6be7
SM
25202011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2521
2522 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2523 to compare Lisp_Objects.
2524 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2525 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2526 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2527
52968808
AS
25282011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2529
0a6a104b
AS
2530 * lread.c (read_integer): Unread even EOF character.
2531 (read1): Likewise. Properly record start position of symbol.
2532
52968808
AS
2533 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2534 symbol character follows.
2535
9e381cdd
PE
25362011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2537
2538 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2539 This works around a problem with the previous change to Fcopy_file.
2540 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2541 and without this change, GCC might complain about discarding
2542 fchown's return value.
2543
b5641435
JB
25442011-07-16 Juanma Barranquero <lekktu@gmail.com>
2545
2546 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2547
a8031457
PE
25482011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2549
2550 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2551
dd889327
LMI
25522011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2553
750c33f7
LMI
2554 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2555 it's used from the C level.
2556
dd889327
LMI
2557 * process.c: Use the same condition for POLL_FOR_INPUT in both
2558 keyboard.c and process.c (bug#1858).
2559
87e86684
LM
25602011-07-09 Lawrence Mitchell <wence@gmx.li>
2561
2562 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2563 (Fgnutls_boot): Use it.
2564
64348f40
AS
25652011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2566
2567 * doc.c (Fsubstitute_command_keys): Revert last change.
2568
1d698799
LMI
25692011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2570
f863868c
LMI
2571 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2572 quotes the next character, and doesn't affect other longer
2573 sequences (bug#8935).
2574
1d698799
LMI
2575 * lread.c (syms_of_lread): Clarify that is isn't only
2576 `eval-buffer' and `eval-defun' that's affected by
2577 `lexical-binding' (bug#8460).
2578
aa4b6df6
EZ
25792011-07-15 Eli Zaretskii <eliz@gnu.org>
2580
2581 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 2582 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 2583
5d856da6
PE
25842011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2585
ad6042bb
PE
2586 Fix minor problems found by static checking.
2587 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2588 (elsz): Now a signed constant, not a size_t var. We prefer signed
2589 types to unsigned, to avoid integer comparison confusion. Without
2590 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2591 "cannot optimize loop, the loop counter may overflow", a symptom
2592 of the confusion.
f00bbb22 2593 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
2594 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2595
6468f31c
LMI
25962011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2597
49080b10
LMI
2598 * search.c (Fre_search_backward): Mention `case-fold-search' in
2599 all the re_search_* functions (bug#8138).
2600
6468f31c
LMI
2601 * keyboard.c (Fopen_dribble_file): Document when the file is
2602 closed (bug#8056).
2603
c965adc5
EZ
26042011-07-14 Eli Zaretskii <eliz@gnu.org>
2605
df9733bf
EZ
2606 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2607 bidi_cache_idx.
2608
0bb23927
EZ
2609 Support bidi reordering of display and overlay strings.
2610 * xdisp.c (compute_display_string_pos)
2611 (compute_display_string_end): Accept additional argument STRING.
2612 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2613 (reseat_to_string): Initialize bidi_it->string.s and
2614 bidi_it->string.schars.
2615 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
2616 NULL (avoids a crash in bidi_paragraph_init).
2617 Initialize itb.string.lstring.
0bb23927
EZ
2618 (init_iterator): Call bidi_init_it only of a valid
2619 buffer position was specified. Initialize paragraph_embedding to
2620 L2R.
2621 (reseat_to_string): Initialize the bidi iterator.
2622 (display_string): If we need to ignore text properties of
2623 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2624 original value of -1 will not work with bidi.)
2625 (compute_display_string_pos): First arg is now struct
2626 `text_pos *'; all callers changed. Support display properties on
2627 Lisp strings.
2628 (compute_display_string_end): Support display properties on Lisp
2629 strings.
2630 (init_iterator, reseat_1, reseat_to_string): Initialize the
2631 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2632 when iterating on a string not from display properties).
640c8776
SM
2633 (compute_display_string_pos, compute_display_string_end):
2634 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
2635 arrow keys.
2636 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
2637 base_level_stop; instead, set base_level_stop to BEGV.
2638 Fixes crashes in vertical-motion.
0bb23927
EZ
2639 (next_element_from_buffer): Improve commentary for when
2640 the iterator is before prev_stop.
2641 (init_iterator): Initialize bidi_p from the default value of
2642 bidi-display-reordering, not from buffer-local value. Use the
2643 buffer-local value only if initializing for buffer iteration.
2644 (handle_invisible_prop): Support invisible properties on strings
2645 that are being bidi-reordered.
2646 (set_iterator_to_next): Support bidi reordering of C strings and
2647 Lisp strings.
2648 (next_element_from_string): Support bidi reordering of Lisp
2649 strings.
2650 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
2651 (display_string): Support display of R2L glyph rows.
2652 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
2653 (init_iterator): Don't initialize it->bidi_p for strings
2654 here.
2655 (reseat_to_string): Initialize it->bidi_p for strings here.
2656 (next_element_from_string, next_element_from_c_string)
2657 (next_element_from_buffer): Add xassert's for correspondence
2658 between IT's object being iterated and it->bidi_it.string
2659 structure.
2660 (face_before_or_after_it_pos): Support bidi iteration.
2661 (next_element_from_c_string): Handle the case of the first string
2662 character that is not the first one in the visual order.
2663 (get_visually_first_element): New function, refactored from common
2664 parts of next_element_from_buffer, next_element_from_string, and
2665 next_element_from_c_string.
2666 (tool_bar_lines_needed, redisplay_tool_bar)
2667 (display_menu_bar): Force left-to-right direction. Add a FIXME
2668 comment for making that be controlled by a user option.
2669 (push_it, pop_it): Save and restore the state of the
2670 bidi iterator. Save and restore the bidi_p flag.
2671 (pop_it): Iterate out of display property for string iteration as
2672 well.
2673 (iterate_out_of_display_property): Support iteration over strings.
2674 (handle_single_display_spec): Set up it->bidi_it for iteration
2675 over a display string, and call bidi_init_it.
2676 (handle_single_display_spec, next_overlay_string)
2677 (get_overlay_strings_1, push_display_prop): Set up the bidi
2678 iterator for displaying display or overlay strings.
2679 (forward_to_next_line_start): Don't use the shortcut if
2680 bidi-iterating.
2681 (back_to_previous_visible_line_start): If handle_display_prop
2682 pushed the iterator stack, restore the internal state of the bidi
2683 iterator by calling bidi_pop_it same number of times.
2684 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2685 and we are bidi-iterating, don't decrement the iterator position;
2686 instead, set the first_elt flag in the bidi iterator, to produce
2687 the same effect.
2688 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2689 (push_display_prop): xassert that we are iterating a buffer.
2690 (push_it, pop_it): Save and restore paragraph_embedding member.
2691 (handle_single_display_spec, next_overlay_string)
2692 (get_overlay_strings_1, reseat_1, reseat_to_string)
2693 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2694 correctly. Don't assume unibyte strings are not bidi-reordered.
2695 (compute_display_string_pos)
2696 (compute_display_string_end): Fix handling the case of C string.
2697 (push_it, pop_it): Save and restore from_disp_prop_p.
2698 (handle_single_display_spec, push_display_prop): Set the
2699 from_disp_prop_p flag.
2700 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2701 (pop_it): Call iterate_out_of_display_property only if we are
2702 popping after iteration over a string that came from a display
2703 property. Fix a typo in popping stretch info. Add an assertion
2704 for verifying that the iterator position is in sync with the bidi
2705 iterator.
2706 (handle_single_display_spec, get_overlay_strings_1)
2707 (push_display_prop): Fix initialization of paragraph direction for
2708 string when that of the parent object is not yet determined.
2709 (reseat_1): Call bidi_init_it to resync the bidi
2710 iterator with IT's position. (Bug#7616)
2711 (find_row_edges): If ROW->start.pos gives position
2712 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2713 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2714 Reset the from_disp_prop_p flag.
2715 (SAVE_IT, RESTORE_IT): New macros.
2716 (pos_visible_p, face_before_or_after_it_pos)
2717 (back_to_previous_visible_line_start)
2718 (move_it_in_display_line_to, move_it_in_display_line)
2719 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2720 (try_scrolling, redisplay_window, display_line): Use them when
2721 saving a temporary copy of the iterator and restoring it back.
2722 (back_to_previous_visible_line_start, reseat_1)
2723 (init_iterator): Empty the bidi cache "stack".
2724 (move_it_in_display_line_to): If iterator ended up at
2725 EOL, but we never saw any buffer positions smaller than
2726 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2727 motion in bidi-reordered lines.
2728 (move_it_in_display_line_to): Record prev_method and prev_pos
2729 immediately before the call to set_iterator_to_next. Fixes cursor
2730 motion in bidi-reordered lines with stretch glyphs and strings
2731 displayed in margins. (Bug#8133) (Bug#8867)
2732 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2733 TO_CHARPOS.
640c8776
SM
2734 (pos_visible_p): Support positions in bidi-reordered lines.
2735 Save and restore bidi cache.
0bb23927
EZ
2736
2737 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2738 (bidi_paragraph_info): Delete unused struct.
2739 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2740 (bidi_cache_start): New variable.
2741 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2742 to zero.
2743 (bidi_cache_fetch_state, bidi_cache_search)
2744 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2745 (bidi_cache_find, bidi_peek_at_next_level)
2746 (bidi_level_of_next_char, bidi_find_other_level_edge)
2747 (bidi_move_to_visually_next): Compare cache index with
2748 bidi_cache_start rather than with zero.
2749 (bidi_fetch_char): Accept new argument STRING; all callers
2750 changed. Support iteration over a string. Support strings with
2751 display properties. Support unibyte strings. Fix the type of
2752 `len' according to what STRING_CHAR_AND_LENGTH expects.
2753 (bidi_paragraph_init, bidi_resolve_explicit_1)
2754 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
2755 (bidi_level_of_next_char, bidi_move_to_visually_next):
2756 Support iteration over a string.
0bb23927
EZ
2757 (bidi_set_sor_type, bidi_resolve_explicit_1)
2758 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2759 can now be zero (for strings); special values 0 and -1 were
2760 changed to -1 and -2, respectively.
2761 (bidi_char_at_pos): New function.
2762 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2763 Call it instead of FETCH_MULTIBYTE_CHAR.
2764 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2765 initialized to valid values.
2766 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2767 values.
2768 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2769 the test for valid cached positions. Fix the logic for looking up
2770 the sentinel state in the cache. GCPRO the Lisp string we are
2771 iterating.
2772 (bidi_push_it, bidi_pop_it): New functions.
2773 (bidi_initialize): Initialize the bidi cache start stack pointer.
2774 (bidi_cache_ensure_space): New function, refactored from part of
2775 bidi_cache_iterator_state. Don't assume the required size is just
2776 one BIDI_CACHE_CHUNK away.
2777 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2778 (bidi_count_bytes, bidi_char_at_pos): New functions.
2779 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2780 always valid if bidi_cache_idx is valid.
2781 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2782 is valid if it's going to be used.
2783 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2784 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
2785 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2786 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
2787 (bidi_find_other_level_edge, bidi_cache_start_stack):
2788 All variables related to cache indices are now EMACS_INT.
c965adc5 2789
0bb23927
EZ
2790 * dispextern.h (struct bidi_string_data): New structure.
2791 (struct bidi_it): New member `string'. Make flag members be 1-bit
2792 fields, and put them last in the struct.
640c8776
SM
2793 (compute_display_string_pos, compute_display_string_end):
2794 Update prototypes.
0bb23927
EZ
2795 (bidi_push_it, bidi_pop_it): Add prototypes.
2796 (struct iterator_stack_entry): New members bidi_p,
2797 paragraph_embedding, and from_disp_prop_p.
2798 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
2799 (bidi_shelve_cache, bidi_unshelve_cache):
2800 Declare prototypes.
0bb23927
EZ
2801
2802 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2803 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2804 and vector-like objects.
2805
2806 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2807 cache around display iteration.
2808
2809 * window.c (Fwindow_end, window_scroll_pixel_based)
2810 (displayed_window_lines, Frecenter): Save and restore the bidi
2811 cache around display iteration.
2812
3bbd2265
LMI
28132011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2814
2815 * editfns.c (Fdelete_region): Clarify the use of the named
2816 parameters (bug#6788).
2817
adc47434
MR
28182011-07-14 Martin Rudalics <rudalics@gmx.at>
2819
2820 * indent.c (Fvertical_motion): Set and restore w->pointm when
2821 saving and restoring the window's buffer (Bug#9006).
2822
837c31f8
LMI
28232011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2824
2825 * editfns.c (Fstring_to_char): Clarify just what is returned
2826 (bug#6576). Text by Eli Zaretskii.
2827
ac389d0c
JB
28282011-07-13 Juanma Barranquero <lekktu@gmail.com>
2829
2830 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2831
0be0ce47
EZ
28322011-07-13 Eli Zaretskii <eliz@gnu.org>
2833
2834 * buffer.c (mmap_find): Fix a typo.
2835
cd18e7e3
JB
28362011-07-13 Johan Bockgård <bojohan@gnu.org>
2837
2838 Fix execution of x selection hooks.
2839 * xselect.c (Qx_lost_selection_functions)
2840 (Qx_sent_selection_functions): New vars.
2841 (syms_of_xselect): DEFSYM them.
2842 (x_handle_selection_request): Pass Qx_sent_selection_functions
2843 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2844 (x_handle_selection_clear,x_clear_frame_selections):
2845 Pass Qx_lost_selection_functions rather than
2846 Vx_lost_selection_functions to Frun_hook_with_args.
2847
47ea7f44
PE
28482011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2849
ac389d0c 2850 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
2851 The old code sometimes used this field without initializing it.
2852
47ea7f44
PE
2853 * alloc.c (gc_sweep): Don't read past end of array.
2854 In theory, the old code could also have corrupted Emacs internals,
2855 though it'd be very unlikely.
2856
bc985c87
AS
28572011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2858
2859 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 2860 argument. (Bug#4026)
bc985c87 2861
0cf34688
LMI
28622011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2863
b3dadd76
LMI
2864 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2865 key" (bug#4257).
2866
0cf34688
LMI
2867 * window.c (Fset_window_start): Doc fix (bug#4199).
2868 (Fset_window_hscroll): Ditto.
2869
270768cd
PE
28702011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2871
077e3dda 2872 Fix minor new problems caught by GCC 4.6.1.
270768cd 2873 * term.c (init_tty): Remove unused local.
490011a6 2874 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 2875 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 2876 not used otherwise.
270768cd 2877
b1f58454
CY
28782011-07-12 Chong Yidong <cyd@stupidchicken.com>
2879
2880 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2881
22b9578d
LMI
28822011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2883
6e70ab07
LMI
2884 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2885 are the mini-buffer and the echo area (bug#3320).
2886
22b9578d
LMI
2887 * term.c (init_tty): Remove support for supdup, c10 and perq
2888 terminals, which are no longer supported (bug#1482).
2889
8974cc9f
JB
28902011-07-10 Johan Bockgård <bojohan@gnu.org>
2891
2892 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2893
a560d974
JD
28942011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2895
2896 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2897 for non-popups (Bug#3642).
2898
1dae0f0a
AS
28992011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2900
268c2c36 2901 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 2902 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
2903 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2904 * cm.c (losecursor): Likewise.
1dae0f0a
AS
2905 * data.c (fmod): Likewise.
2906 * dispnew.c (swap_glyphs_in_rows): Likewise.
2907 * emacs.c (memory_warning_signal): Likewise.
2908 * floatfns.c (float_error): Likewise.
2909 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2910 (otf_open, font_otf_capability, generate_otf_features)
2911 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2912 Likewise.
2913 * image.c (pbm_read_file): Likewise.
2914 * indent.c (string_display_width): Likewise.
2915 * intervals.c (check_for_interval, search_for_interval)
2916 (inc_interval_count, count_intervals, root_interval)
2917 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2918 * lread.c (defalias): Likewise.
268c2c36 2919 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
2920 * regex.c (set_image_of_range_1, set_image_of_range)
2921 (regex_grow_registers): Likewise.
2922 * sysdep.c (strerror): Likewise.
2923 * termcap.c (valid_filename_p, tprint, main): Likewise.
2924 * tparam.c (main): Likewise.
2925 * unexhp9k800.c (run_time_remap, save_data_space)
2926 (update_file_ptrs, read_header, write_header, calculate_checksum)
2927 (copy_file, copy_rest, display_header): Likewise.
2928 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2929 Likewise.
2930 * xdisp.c (check_it): Likewise.
2931 * xfaces.c (register_color, unregister_color, unregister_colors):
2932 Likewise.
2933 * xfns.c (print_fontset_result): Likewise.
2934 * xrdb.c (member, fatal, main): Likewise.
2935
99033785
PE
29362011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2937
2938 Fix minor problems found by static checking (Bug#9031).
2939 * chartab.c (char_table_set_range, map_sub_char_table):
2940 Remove unused locals.
2941 (uniprop_table): Now static.
2942 * composite.c (_work_char): Remove unused static var.
2943
9cb2ac56
JB
29442011-07-09 Juanma Barranquero <lekktu@gmail.com>
2945
2946 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2947
f25661f0
JD
29482011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2949
2950 * gtkutil.c (qttip_cb): Remove code without function.
2951
8278c4fe
EZ
29522011-07-09 Eli Zaretskii <eliz@gnu.org>
2953
2954 * w32.c (pthread_sigmask): New stub.
2955
1692ae2d 29562011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 2957
8a6ebd58 2958 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
2959 sigprocmask is portable only for single-threaded applications, and
2960 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
2961 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2962 (LIBES): Use it.
2963 * callproc.c (Fcall_process):
2964 * process.c (create_process):
2965 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2966 Use pthread_sigmask, not sigprocmask.
123403e4 2967
1b854618
JD
29682011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2969
2970 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2971 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2972 wrong (Bug#8591).
2973
3fe4b549
JD
29742011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2975
0ce7e563
JD
2976 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2977 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2978 (xg_hide_tooltip): Fix comment.
2979
3fe4b549
JD
2980 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2981 in registerServicesMenuSendTypes.
2982 (validRequestorForSendType): Don't check ns_return_types.
2983
2984 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2985 ns_return_type.
2986
5df75e47
JR
29872011-07-08 Jason Rumney <jasonr@gnu.org>
2988
22610910
JR
2989 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
2990 SH_SHOW for hidden windows (Bug#5482).
2991
5df75e47
JR
2992 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2993 frame struct members of non-existent frames (Bug#6284).
2994
699c10bd
JD
29952011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2996
4393663b
JD
2997 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2998 variable firstTime not needed on OSX >= 10.6.
2999 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3000 >= 10.5. Use setKnobProportion, setDoubleValue.
3001
3002 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3003 (MAC_OS_X_VERSION_10_5): Define if not defined.
3004 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3005 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3006 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3007
3008 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3009 cString and lossyCString on OSX >= 10.4
3010
3011 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
3012 sizeToFit on OSX >= 10.2.
3013
3014 * nsimage.m (allocInitFromFile): Don't use deprecated method
3015 bestRepresentationForDevice on OSX >= 10.6.
3016
3017 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3018 to avoid warning.
3019
3020 * emacs.c: Declare unexec_init_emacs_zone.
3021
a63e0781
JD
3022 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3023
699c10bd
JD
3024 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3025
3026 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3027 on svcsMenu (Bug#8842).
3028
3029 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3030 ns_return_types.
3031 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3032
3033 * nsterm.m (QUTF8_STRING): Declare.
3034 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3035 (validRequestorForSendType): Return type is (id).
3036 Change indexOfObjectIdenticalTo to indexOfObject.
3037 Check if we have local selection before returning self (Bug#8842).
3038 (writeSelectionToPasteboard): Put local selection into paste board
3039 if we have a local selection (Bug#8842).
3040 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3041
3042 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3043 (ns_get_local_selection): Declare.
3044
54e10184
LMI
30452011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3046
9888ff71
LMI
3047 * keymap.c (describe_map_tree): Don't insert a double newline at
3048 the end of the buffer (bug#1169) and return whether we inserted
3049 something.
3050
54e10184
LMI
3051 * callint.c (Fcall_interactively): Change "reading args" to
3052 "providing args" to try to clarify what it does (bug#1010).
3053
15fa4783
KH
30542011-07-07 Kenichi Handa <handa@m17n.org>
3055
3056 * composite.c (composition_compute_stop_pos): Ignore a static
3057 composition starting before CHARPOS (Bug#8915).
3058
3059 * xdisp.c (handle_composition_prop): Likewise.
3060
a8815b00
EZ
30612011-07-07 Eli Zaretskii <eliz@gnu.org>
3062
3063 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3064 (Bug#9015)
3065
ef7b981d 30662011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
3067
3068 * character.h (unicode_category_t): New enum type.
3069
3070 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3071 (Qchar_code_property_table): New variable.
3072 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3073 (UNIPROP_COMPRESSED_FORM_P): New macros.
3074 (char_table_ascii): Uncompress the compressed values.
3075 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3076 Uncompress the compressed values.
ac389d0c 3077 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
3078 (char_table_ref_and_range): Uncompress the compressed values.
3079 (sub_char_table_set): New arg is_uniprop. Callers changed.
3080 Uncompress the compressed values.
3081 (sub_char_table_set_range): Args changed. Callers changed.
3082 (char_table_set_range): Adjuted for the above change.
3083 (map_sub_char_table): Delete args default_val and parent. Add arg
3084 top. Give decoded values to a Lisp function.
640c8776 3085 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
3086 values to a Lisp function. Gcpro more variables.
3087 (uniprop_table_uncompress)
3088 (uniprop_decode_value_run_length): New functions.
3089 (uniprop_decoder, uniprop_decoder_count): New variables.
3090 (uniprop_get_decoder, uniprop_encode_value_character)
3091 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3092 New functions.
3093 (uniprop_encoder, uniprop_encoder_count): New variables.
3094 (uniprop_get_encoder, uniprop_table)
3095 (Funicode_property_table_internal, Fget_unicode_property_internal)
3096 (Fput_unicode_property_internal): New functions.
3097 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3098 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 3099 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
3100 char-code-property-alist.
3101
640c8776 3102 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
3103 Vunicode_category_table.
3104
640c8776 3105 * font.c (font_range): Adjust for the change of
c805dec0
KH
3106 Vunicode_category_table.
3107
76b397fb
DN
31082011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3109
3110 * m/iris4d.h: Remove file, move contents ...
3111 * s/irix6-5.h: ... here.
3112
22b4128e
PE
31132011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3114
3115 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
3116 * alloc.c (mark_buffer):
3117 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3118 (clone_per_buffer_values): Don't assume that
22b4128e
PE
3119 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3120 This isn't true in general, and it's particularly not true
3121 if Emacs is configured with --with-wide-int.
3122 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3123 New macros, used in the buffer.c change.
3124
869795d6
JD
31252011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3126
3127 * xsettings.c: Use both GConf and GSettings if both are available.
3128 (store_config_changed_event): Add comment.
3129 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3130 (store_tool_bar_style_changed): New functions.
5e617bc2 3131 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
3132 (struct xsettings): Move font inside HAVE_XFT.
3133 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 3134 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 3135 Move inside HAVE_XFT.
640c8776 3136 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
3137 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3138 also.
3139 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 3140 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 3141 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
3142 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3143 (parse_settings): Move check for font inside HAVE_XFT.
3144 (read_settings, apply_xft_settings): Add comment.
3145 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3146 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3147 call store_font_name_changed.
3148 (xft_settings_event): Add comment.
3149 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3150 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3151 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3152 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3153 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
3154 (xsettings_get_system_font, xsettings_get_system_normal_font):
3155 Add comment.
869795d6 3156
d8ed26bd
PE
31572011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3158
3159 Random fixes. E.g., (random) never returned negative values.
3160 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3161 subseconds part to the entropy, as that's a bit more random.
3162 Prefer signed to unsigned, since the signedness doesn't matter and
3163 in general we prefer signed. When given a limit, use a
3164 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3165 latter isn't right if USE_2_TAGS_FOR_INTS.
3166 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3167 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3168
cabf1cac
SM
31692011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3170
3171 * textprop.c (text_property_stickiness):
3172 Obey Vtext_property_default_nonsticky.
3173 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3174 * w32fns.c (syms_of_w32fns):
3175 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3176
6e9b2be9
PE
31772011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3178
3179 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3180 This is more efficient than Ffile_directory_p and avoids a minor race.
3181
90186c68
LMI
31822011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3183
7c301272
LMI
3184 * buffer.c (Foverlay_put): Say what the return value is
3185 (bug#7835).
3186
c4f2d8d4
LMI
3187 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3188 is a directory before asking whether to use the file name
3189 (bug#7564).
ad637907
LMI
3190 (barf_or_query_if_file_exists): Make the "File is a directory"
3191 error be more correct.
c4f2d8d4 3192
90186c68
LMI
3193 * fns.c (Frequire): Remove the mention of the .gz files, since
3194 that's installation-specific, but keep the mention of
3195 `get-load-suffixes'.
3196
da64016e
PE
31972011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3198
3199 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3200 Report string overflow if the output is too long.
3201
7d47b580
JB
32022011-07-04 Juanma Barranquero <lekktu@gmail.com>
3203
a555cb87
JB
3204 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3205 (syms_of_gnutls): Remove duplicate DEFSYM for
3206 Qgnutls_bootprop_verify_hostname_error, an error for
3207 Qgnutls_bootprop_verify_error (which is no longer used).
3208
7d47b580
JB
3209 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3210 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3211 Also (re)move comments that are misplaced or no longer relevant.
3212
1e49bfab
LMI
32132011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3214
3215 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3216
1485f4c0
CY
32172011-07-03 Chong Yidong <cyd@stupidchicken.com>
3218
3219 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3220 and background color parameters if they have been changed.
3221
a9ab721e
LMI
32222011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3223
3224 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3225
cf7cff57
PE
32262011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3227
2e13213d
PE
3228 * xsettings.c (SYSTEM_FONT): Define only when used.
3229 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3230
cf7cff57
PE
3231 * keymap.c (access_keymap_1): Now static.
3232
7a8e04f7
CY
32332011-07-02 Chong Yidong <cyd@stupidchicken.com>
3234
3235 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3236 leave any prefix arg for the up event (Bug#1586).
3237
61352f62
LMI
32382011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3239
69bb1ef7
LMI
3240 * lread.c (syms_of_lread): Mention single symbols defined by
3241 `defvar' or `defconst' (bug#7154).
3242
61352f62 3243 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 3244 (Frequire): Mention get-load-suffixes.
61352f62 3245
28545e04
MR
32462011-07-02 Martin Rudalics <rudalics@gmx.at>
3247
3248 * window.h (window): Remove clone_number slot.
3249 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3250 Remove.
3251 (make_parent_window, make_window, saved_window)
3252 (Fset_window_configuration, save_window_save): Don't deal with
3253 clone numbers.
3254 * buffer.c (Qclone_number): Remove declaration.
3255 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3256
3349e122
SM
32572011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3258
3259 Add multiple inheritance to keymaps.
3260 * keymap.c (Fmake_composed_keymap): New function.
3261 (Fset_keymap_parent): Simplify.
3262 (fix_submap_inheritance): Remove.
3263 (access_keymap_1): New function extracted from access_keymap to handle
3264 embedded parents and handle lists of maps.
3265 (access_keymap): Use it.
3266 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3267 (Fcopy_keymap): Handle embedded parents.
3268 (Fcommand_remapping, define_as_prefix): Simplify.
3269 (Fkey_binding): Simplify.
3270 (syms_of_keymap): Move minibuffer-local-completion-map,
3271 minibuffer-local-filename-completion-map,
3272 minibuffer-local-must-match-map, and
3273 minibuffer-local-filename-must-match-map to Elisp.
3274 (syms_of_keymap): Defsubr make-composed-keymap.
3275 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3276 (parse_menu_item): Trivial simplification.
3277
3279eb87
GM
32782011-07-01 Glenn Morris <rgm@gnu.org>
3279
3280 * Makefile.in (SETTINGS_LIBS): Fix typo.
3281
4550efdf
KI
32822011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3283
3284 * coding.c (Fencode_coding_string): Record the last coding system
3285 used, as the function doc string says (bug#8738).
3286
0949d2b6
JD
32872011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3288
3289 * xsettings.c (store_monospaced_changed): Take new font as arg and
3290 check for change against current_mono_font.
3291 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3292 (emacs_settings_constructor, emacs_settings_get_property)
3293 (emacs_settings_set_property, emacs_settings_class_init)
3294 (emacs_settings_init, gsettings_obj): Remove.
3295 (something_changedCB): New function for HAVE_GSETTINGS.
3296 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3297 with value as argument.
3298 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3299 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 3300 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
3301 "changed".
3302
3303 * xgselect.c: Add defined (HAVE_GSETTINGS).
3304 (xgselect_initialize): Ditto.
3305
3306 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3307 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3308 xg_select.
3309
bbc6b304
PE
33102011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3311
3312 * eval.c (struct backtrace): Simplify and port the data structure.
3313 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3314 signed bit field, as this assumption is not portable and it makes
3315 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3316 "char debug_on_exit : 1" as this is not portable either; instead,
3317 use the portable "unsigned int debug_on_exit : 1". Remove unused
3318 member evalargs. Remove obsolete comments about cc bombing out.
3319
9851bfc5
JD
33202011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3321
51bb811f 3322 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
3323 Let HAVE_GSETTINGS override HAVE_GCONF.
3324 (store_monospaced_changed): New function.
3325 (EMACS_SETTINGS): A new type derived from GObject to handle
3326 GSettings notifications.
3327 (emacs_settings_constructor, emacs_settings_get_property)
3328 (emacs_settings_set_property, emacs_settings_class_init):
3329 New functions.
3330 (gsettings_client, gsettings_obj): New variables.
3331 (GSETTINGS_SCHEMA): New define.
3332 (something_changedCB): Call store_monospaced_changed.
3333 (init_gsettings): New function.
3334 (xsettings_initialize): Call init_gsettings.
3335 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3336 to NULL.
3337
640c8776 3338 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
3339 GCONF_CFLAGS/LIBS.
3340
5386012d
MR
33412011-06-29 Martin Rudalics <rudalics@gmx.at>
3342
3343 * window.c (resize_root_window, grow_mini_window)
3344 (shrink_mini_window): Rename Qresize_root_window to
3345 Qwindow_resize_root_window and Qresize_root_window_vertically to
3346 Qwindow_resize_root_window_vertically.
3347
f13e0b08
PE
33482011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3349
3350 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3351
94515237
JB
33522011-06-27 Juanma Barranquero <lekktu@gmail.com>
3353
3354 * makefile.w32-in: Redesign dependencies so they reflect more
3355 clearly which files are directly included by each source file,
3356 and not through other includes.
3357
e43b6e43
MR
33582011-06-27 Martin Rudalics <rudalics@gmx.at>
3359
3360 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3361 (sort_overlays, overlay_strings): When an overlay's clone number
3362 matches the window's clone number process the overlay even if
3363 the overlay's window property doesn't match the current window.
3364
d68443dc
MR
3365 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3366 (Fwindow_hchild): Rename to Fwindow_left_child.
3367 (Fwindow_next): Rename to Fwindow_next_sibling.
3368 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
3369 (resize_window_check): Rename to window_resize_check.
3370 (resize_window_apply): Rename to window_resize_apply.
3371 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3372 (Fdelete_other_windows_internal, resize_frame_windows)
3373 (Fsplit_window_internal, Fdelete_window_internal)
3374 (grow_mini_window, shrink_mini_window)
3375 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 3376
c7e73be5
JD
33772011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3378
3379 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3380 (emacs_fixed_set_min_size): Remove.
3381 (emacs_fixed_new): Take frame as argument.
3382
3383 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3384 (_EmacsFixedPrivate): Remove minwidth/height.
3385 Add struct frame *f.
3386 (emacs_fixed_init): Initialize priv->f.
3387 (get_parent_class, emacs_fixed_set_min_size): Remove.
3388 (emacs_fixed_new): Set priv->f to argument.
3389 (emacs_fixed_get_preferred_width)
3390 (emacs_fixed_get_preferred_height): Use min_width/height from
3391 frames size_hint to set minimum and natural (Bug#8919).
3392 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3393 and use min_width/height from frames size_hint to set
3394 min_width/height (Bug#8919).
3395
3396 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
3397 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3398 Fix indentation.
c7e73be5 3399
cf99dcf8
EZ
34002011-06-26 Eli Zaretskii <eliz@gnu.org>
3401
3402 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3403 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3404 called at ZV.
3405
029529ac
CY
34062011-06-26 Chong Yidong <cyd@stupidchicken.com>
3407
3408 * process.c (wait_reading_process_output): Bypass select if
3409 waiting for a cell while ignoring keyboard input, and input is
3410 pending. Suggested by Jan Djärv (Bug#8869).
3411
7a7ef429
PE
34122011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3413
3414 Use gnulib's dup2 module instead of rolling our own.
3415 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3416
11fdef7d 34172011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
3418
3419 * dispnew.c (scrolling_window): Before scrolling, turn off a
3420 mouse-highlight in the window being scrolled.
3421
cd3520a4
JB
34222011-06-24 Juanma Barranquero <lekktu@gmail.com>
3423
3424 Move DEFSYM to lisp.h and use everywhere.
3425
3426 * character.h (DEFSYM): Move declaration...
3427 * lisp.h (DEFSYM): ...here.
3428
3429 * gnutls.c:
3430 * minibuf.c:
3431 * w32menu.c:
3432 * w32proc.c:
3433 * w32select.c: Don't include character.h.
3434
3435 * alloc.c (syms_of_alloc):
3436 * buffer.c (syms_of_buffer):
3437 * bytecode.c (syms_of_bytecode):
3438 * callint.c (syms_of_callint):
3439 * casefiddle.c (syms_of_casefiddle):
3440 * casetab.c (init_casetab_once):
3441 * category.c (init_category_once, syms_of_category):
3442 * ccl.c (syms_of_ccl):
3443 * cmds.c (syms_of_cmds):
3444 * composite.c (syms_of_composite):
3445 * dbusbind.c (syms_of_dbusbind):
3446 * dired.c (syms_of_dired):
3447 * dispnew.c (syms_of_display):
3448 * doc.c (syms_of_doc):
3449 * editfns.c (syms_of_editfns):
3450 * emacs.c (syms_of_emacs):
3451 * eval.c (syms_of_eval):
3452 * fileio.c (syms_of_fileio):
3453 * fns.c (syms_of_fns):
3454 * frame.c (syms_of_frame):
3455 * fringe.c (syms_of_fringe):
3456 * insdel.c (syms_of_insdel):
3457 * keymap.c (syms_of_keymap):
3458 * lread.c (init_obarray, syms_of_lread):
3459 * macros.c (syms_of_macros):
3460 * msdos.c (syms_of_msdos):
3461 * print.c (syms_of_print):
3462 * process.c (syms_of_process):
3463 * search.c (syms_of_search):
3464 * sound.c (syms_of_sound):
3465 * syntax.c (init_syntax_once, syms_of_syntax):
3466 * terminal.c (syms_of_terminal):
3467 * textprop.c (syms_of_textprop):
3468 * undo.c (syms_of_undo):
3469 * w32.c (globals_of_w32):
3470 * window.c (syms_of_window):
3471 * xdisp.c (syms_of_xdisp):
3472 * xfaces.c (syms_of_xfaces):
3473 * xfns.c (syms_of_xfns):
3474 * xmenu.c (syms_of_xmenu):
3475 * xsettings.c (syms_of_xsettings):
3476 * xterm.c (syms_of_xterm): Use DEFSYM.
3477
4228cf16
TZ
34782011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3479
cd3520a4 3480 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 3481
7fcccf1e
PE
34822011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3483
7efb4e0e
PE
3484 Integer and buffer overflow fixes (Bug#8873).
3485
ff5844ad
PE
3486 * print.c (printchar, strout): Check for string overflow.
3487 (PRINTPREPARE, printchar, strout):
3488 Don't set size unless allocation succeeds.
3489
90532f02
PE
3490 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3491 for sizes. Check for string overflow more accurately.
3492 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3493
6d84508d
PE
3494 * macros.c: Integer and buffer overflow fixes.
3495 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3496 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3497 Use ptrdiff_t, not int, for sizes.
3498 Don't increment bufsize until after realloc succeeds.
3499 Check for size-calculation overflow.
3500 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3501
437b2cb4
PE
3502 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3503
8b9ac8b4
PE
3504 * lread.c: Integer overflow fixes.
3505 (read_integer): Radix is now EMACS_INT, not int,
3506 to improve quality of diagnostics for out-of-range radices.
3507 Calculate buffer size correctly for out-of-range radices.
3508 (read1): Check for integer overflow in radices, and in
3509 read-circle numbers.
82cb60d3
PE
3510 (read_escape): Avoid int overflow.
3511 (Fload, openp, read_buffer_size, read1)
3512 (substitute_object_recurse, read_vector, read_list, map_obarray):
3513 Use ptrdiff_t, not int, for sizes.
3514 (read1): Use EMACS_INT, not int, for sizes.
20270765 3515 Check for size overflow.
8b9ac8b4 3516
7fcccf1e
PE
3517 * image.c (cache_image): Check for size arithmetic overflow.
3518
bfbbd7e7
PE
3519 * lread.c: Integer overflow issues.
3520 (saved_doc_string_size, saved_doc_string_length)
3521 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3522 Now ptrdiff_t, not int.
3523 (read1): Don't assume doc string length fits in int. Check for
3524 out-of-range doc string lengths.
3525 (read_list): Don't assume file position fits in int.
39019e54 3526 (read_escape): Check for hex character overflow.
bfbbd7e7 3527
4e323265
LL
35282011-06-22 Leo Liu <sdl.web@gmail.com>
3529
3530 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3531 Move to minibuffer.el.
3532
85fece3e
PE
35332011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3534
20b84ce9 3535 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
3536 The following patches are for when GLYPH_DEBUG && !XASSERT.
3537 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3538 * dispnew.c (flush_stdout):
3539 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3540 Mark as externally visible.
3541 * dispnew.c (check_window_matrix_pointers): Now static.
3542 * dispnew.c (window_to_frame_vpos):
3543 * xfns.c (unwind_create_frame):
3544 * xterm.c (x_check_font): Remove unused local.
3545 * scroll.c (CHECK_BOUNDS):
3546 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3547 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3548 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3549 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3550 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3551 Now static.
3552 (debug_method_add): Use va_list and vsprintf rather than relying
3553 on undefined behavior with wrong number of arguments.
3554 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3555 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3556 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3557 since we're not interested in debugging glyphs with old libraries.
3558 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3559 GCC 4.6.0's static checking.
3560
0766b489
PE
35612011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3562
31fd4b32
PE
3563 Integer overflow and signedness fixes (Bug#8873).
3564 A few related buffer overrun fixes, too.
3565
b79e8648
PE
3566 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3567
0766b489
PE
3568 * dispextern.h (struct face.stipple):
3569 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3570 (x_bitmap_mask, x_allocate_bitmap_record)
3571 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3572 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3573 (x_create_bitmap_from_xpm_data):
3574 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3575 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3576 (.bitmaps_last):
3577 * xfaces.c (load_pixmap):
3578 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3579 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3580 (.bitmaps_last, struct x_output.icon_bitmap):
3581 Use ptrdiff_t, not int, for bitmap indexes.
3582 (x_allocate_bitmap_record): Check for size overflow.
3583 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3584
b081724f
PE
3585 Use ptrdiff_t, not int, for overlay counts.
3586 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3587 * editfns.c (overlays_around, get_pos_property):
3588 * textprop.c (get_char_property_and_overlay):
3589 * xdisp.c (next_overlay_change, note_mouse_highlight):
3590 * xfaces.c (face_at_buffer_position):
21514da7
PE
3591 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3592 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3593 (Fnext_overlay_change, Fprevious_overlay_change)
3594 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 3595 Use ptrdiff_t, not int, for sizes.
21514da7 3596 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 3597
3de73e5e
PE
3598 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3599
2606c57b
PE
3600 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3601 (x_session_initialize): Do not assume string length fits in int.
3602
aaafe47a
PE
3603 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3604 This is unlikely, but can occur if DPI is outlandish.
3605
2674ddc8 3606 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
3607 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3608
28154962
PE
3609 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3610 * xrdb.c (magic_file_p, search_magic_path):
3611 Omit last arg SUFFIX; it was always 0. All callers changed.
3612 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3613
7de51af5
PE
3614 * xfont.c (xfont_match): Avoid need for strlen.
3615
25ed6cc3
PE
3616 * xfns.c: Don't assume strlen fits in int.
3617 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3618
4eab31dd
PE
3619 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3620 not unsigned long, as we prefer signed integers. All callers changed.
3621 Detect integer overflow in repeat count.
3622 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 3623 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 3624
171e2a58
PE
3625 * termcap.c: Don't assume sizes fit in int and never overflow.
3626 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3627 (gobble_line): Check for size-calculation overflow.
3628
ad39faca 3629 * minibuf.c (Fread_buffer):
6e5bb2dc 3630 * lread.c (intern, intern_c_string):
74ca2eb3
PE
3631 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3632 Don't assume string length fits in int.
3633
52c61c22 3634 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
3635 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3636
b5b8c9e5
PE
3637 * font.c: Don't assume string length fits in int.
3638 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3639 Use ptrdiff_t, not int.
ccd6111c
PE
3640 (font_intern_prop): Don't assume string length fits in int.
3641 Don't assume integer property fits in fixnum.
3642 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 3643
882f0d81 3644 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 3645 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
3646 Reformulate so as not to need the command string.
3647 Invoke gzip -cd rather than gunzip, as it's more portable.
3648 (lock_info_type, lock_file_1, lock_file):
3649 Don't assume pid_t and time_t fit in unsigned long.
3650 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3651 (current_lock_owner): Prefer signed type for sizes.
3652 Use memcpy, not strncpy, where memcpy is what is really wanted.
3653 Don't assume (via atoi) that time_t and pid_t fit in int.
3654 Check for time_t and/or pid_t out of range, e.g., via a network share.
3655 Don't alloca where an auto var works fine.
3656
93f4cf88
PE
3657 * fileio.c: Fix some integer overflow issues.
3658 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3659 Don't assume string length fits in int.
3660 (directory_file_name): Don't assume string length fits in long.
3661 (make_temp_name): Don't assume pid fits in int, or that its print
3662 length is less than 20.
3663
f3e92b69
PE
3664 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3665
1bfdaf10
PE
3666 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3667
35016e9a
PE
3668 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3669
3d1e65a1
PE
3670 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3671 We prefer signed integers, even for size calculations.
3672
0b963a93
PE
3673 * emacs.c: Don't assume string length fits in 'int'.
3674 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3675 (main): Don't invoke strlen when not needed.
3676
573f4b54
PE
3677 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3678 (XD_DEBUG_MESSAGE): Don't waste a byte.
3679
989f33ba
PE
3680 * callproc.c (getenv_internal_1, getenv_internal)
3681 (Fgetenv_internal):
965d34eb
PE
3682 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3683
e4d29b33
PE
3684 * lread.c (invalid_syntax): Omit length argument.
3685 All uses changed. This doesn't fix a bug, but it simplifies the
3686 code away from its former Hollerith-constant appearance, and it's
3687 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 3688 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 3689
eb49b136
PE
3690 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3691 This didn't break anything, but it didn't help either.
3692 It's confusing to put a bogus integer in a place where the actual
3693 value does not matter.
9f62aeb1 3694 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 3695 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 3696
15375a22
PE
3697 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3698 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3699 implementation.
b61cc01c
PE
3700 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3701 We prefer signed types, and the value cannot exceed the EMACS_INT
3702 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
3703 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3704 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3705 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 3706
53b2623d
PE
3707 * indent.c (sane_tab_width): New function.
3708 (current_column, scan_for_column, Findent_to, position_indentation)
3709 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 3710 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 3711
51cab52b 3712 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 3713
f2ed8a70
PE
3714 * lisp.h (lint_assume): New macro.
3715 * composite.c (composition_gstring_put_cache):
3716 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3717
abe80cc6
PE
3718 * editfns.c, insdel.c:
3719 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 3720
b02c740e
PE
3721 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3722
ebc96716
PE
3723 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3724
b4e50fa0 3725 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 3726 Use much-faster test for byte-length change.
311d5d7c 3727 Don't assume string byte-length fits in 'int'.
a4cf38e4 3728 Check that character arg fits in 'int'.
85461888 3729 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 3730
c0c1ee9f
PE
3731 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3732
a498d7f4
PE
3733 * fns.c (concat): Catch string overflow earlier.
3734 Do not rely on integer wraparound.
3735
51cab52b
PE
3736 * dispextern.h (struct it.overlay_strings_charpos)
3737 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
3738 * xdisp.c (forward_to_next_line_start)
3739 (back_to_previous_visible_line_start)
3740 (reseat_at_next_visible_line_start, next_element_from_buffer):
3741 Don't arbitrarily truncate the value of 'selective' to int.
3742
76031fad
PE
3743 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3744
5eb55db9
PE
3745 * composite.c: Don't truncate sizes to 'int'.
3746 (composition_gstring_p, composition_reseat_it)
3747 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
3748 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3749 not EMACS_UINT, for indexes.
5eb55db9 3750
0703a717
PE
3751 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3752
d6202519
PE
3753 * buffer.c: Include <verify.h>.
3754 (struct sortvec.priority, struct sortstr.priority):
8961a454 3755 Now EMACS_INT, not int.
c20998a7 3756 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
3757 (struct sortstr.size, record_overlay_string)
3758 (struct sortstrlist.size, struct sortlist.used):
3759 Don't truncate size to int.
3760 (record_overlay_string): Check for size-calculation overflow.
d6202519 3761 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 3762
d5a19415
JM
37632011-06-22 Jim Meyering <meyering@redhat.com>
3764
029529ac 3765 Don't leak an XBM-image-sized buffer
d5a19415
JM
3766 * image.c (xbm_load): Free the image buffer after using it.
3767
a9041e6c
PE
37682011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3769
3770 Port to Sun C.
3771 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3772 that Sun C diagnosed.
3773 * fns.c (secure_hash): Fix pointer signedness issue.
3774 * intervals.c (static_offset_intervals): New function.
3775 (offset_intervals): Use it.
3776
7f3f739f
LL
37772011-06-21 Leo Liu <sdl.web@gmail.com>
3778
3779 * deps.mk (fns.o):
3780 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3781 sha512.h.
3782
3783 * fns.c (secure_hash): Rename from crypto_hash_function and change
3784 the first arg to accept symbols.
5b66d427 3785 (Fsecure_hash): New primitive.
7f3f739f
LL
3786 (syms_of_fns): New symbols.
3787
76147d94
DD
37882011-06-20 Deniz Dogan <deniz@dogan.se>
3789
3790 * process.c (Fset_process_buffer): Clarify return value in
3791 docstring.
3792
7d7d0045
CY
37932011-06-18 Chong Yidong <cyd@stupidchicken.com>
3794
3795 * dispnew.c (add_window_display_history): Use BVAR.
3796
3797 * xdisp.c (debug_method_add): Use BVAR.
3798 (check_window_end, dump_glyph_matrix, dump_glyph)
3799 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3800
3801 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3802 Likewise.
3803
3804 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3805 check till after the cache is created in init_frame_faces.
3806
ff2bc410
SM
38072011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3808
3809 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3810
28177add
PE
38112011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3812
dd3482fe
PE
3813 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3814 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3815 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3816
393d71f3 3817 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
3818 * fileio.c (Finsert_file_contents):
3819 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3820 Remove the old (too-loose) buffer overflow checks.
3821 They weren't needed, since make_gap checks for buffer overflow.
3822 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3823 The old code merely checked for Emacs fixnum overflow, and relied
3824 on undefined (wraparound) behavior. The new code avoids undefined
3825 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3826
2e6813b0 3827 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
3828 Tune. Don't use wider integers than needed. Don't use alloca.
3829 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 3830
599a9e4f
PE
3831 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3832
99561444
PE
3833 * insdel.c, lisp.h (buffer_overflow): New function.
3834 (insert_from_buffer_1, replace_range, replace_range_2):
3835 * insdel.c (make_gap_larger):
3836 * editfns.c (Finsert_char):
3837 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3838
28177add
PE
3839 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3840
e69dafad
PE
38412011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3842
a7af7fde 3843 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 3844
b1c46f02
PE
3845 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3846 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3847
e69dafad
PE
3848 * fileio.c: Don't assume EMACS_INT fits in off_t.
3849 (emacs_lseek): New static function.
3850 (Finsert_file_contents, Fwrite_region): Use it.
3851 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3852
566684ea
PE
3853 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3854
e6966cd6
PE
3855 * fns.c: Don't overflow int when computing a list length.
3856 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3857 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3858 truncation on 64-bit hosts. Check for QUIT every
3859 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3860 faster and is responsive enough.
3861 (Flength): Report an error instead of overflowing an integer.
3862 (Fsafe_length): Return a float if the value is not representable
3863 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 3864 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 3865 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 3866
dd0b0efb
PE
3867 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3868 (header_size, word_size): New constants.
3869 (allocate_vectorlike): Don't check size overflow here.
3870 (allocate_vector): Check it here instead, since this is the only
3871 caller of allocate_vectorlike that could cause overflow.
3872 Check that the new vector's length is representable as a fixnum.
3873
86fe5cfe
PE
3874 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3875 The previous code was bogus. For example, next_almost_prime (32)
3876 returned 39, which is undesirable as it is a multiple of 3; and
3877 next_almost_prime (24) returned 25, which is a multiple of 5 so
3878 why was the code bothering to check for multiples of 7?
3879
80e88859
PE
3880 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3881
4a2f0ad6
PE
3882 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3883
f66c7cf8
PE
3884 Variadic C functions now count arguments with ptrdiff_t.
3885 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3886 Back then I didn't know that the Emacs coding style prefers signed int.
3887 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
3888 were being counted with int, which may truncate counts on 64-bit
3889 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
3890 * lisp.h (struct Lisp_Subr.function.aMANY)
3891 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3892 Arg counts are now ptrdiff_t, not size_t.
3893 All variadic functions and their callers changed accordingly.
3894 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3895 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3896 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3897 * callint.c (Fcall_interactively): Check arg count for overflow,
3898 to avoid potential buffer overrun. Use signed char, not 'int',
3899 for 'varies' array, so that we needn't bother to check its size
3900 calculation for overflow.
3901 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3902 * eval.c (apply_lambda):
3903 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3904 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3905 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3906
a1759b76
PE
3907 * callint.c (Fcall_interactively): Don't use index var as event count.
3908
d96be9fc
PE
3909 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3910 * mem-limits.h (SIZE): Remove; no longer used.
3911
a690a978 3912 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 3913
578c21e6
PE
3914 Remove unnecessary casts.
3915 * xterm.c (x_term_init):
3916 * xfns.c (x_set_border_pixel):
3917 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3918 These aren't needed now that we assume ANSI C.
3919
96f53c6c
PE
3920 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3921 It's more likely to cause problems (due to unsigned overflow)
3922 than to cure them.
3923
83c77d31
PE
3924 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3925
ee2079f1
PE
3926 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3927
6da65536
PE
3928 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3929
7147c4a4
PE
3930 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3931
193e32d9
PE
3932 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3933
e5533da6
PE
3934 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3935
9910e595
PE
3936 GLYPH_CODE_FACE returns EMACS_INT, not int.
3937 * dispextern.h (merge_faces):
3938 * xfaces.c (merge_faces):
01103c44
PE
3939 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3940 Don't assume EMACS_INT fits in int.
9910e595 3941
2638320e
PE
3942 * character.h (CHAR_VALID_P): Remove unused parameter.
3943 * fontset.c, lisp.h, xdisp.c: All uses changed.
3944
045eb8d9
PE
3945 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3946
c1f134b5
PE
3947 * fns.c (concat): Minor tuning based on overflow analysis.
3948 This doesn't fix any bugs. Use int to hold character, instead
3949 of constantly refetching from Emacs object. Use XFASTINT, not
3950 XINT, for value known to be a character. Don't bother comparing
3951 a single byte to 0400, as it's always less.
3952
395fcb93 3953 * floatfns.c (Fexpt):
327eeec8
PE
3954 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3955
abbd3d23
PE
3956 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3957 for characters.
3958
684a03ef
PE
3959 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3960
0fed43f3
PE
3961 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3962 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3963 incorrectly succeed when S was a string, because 4294967386 was
3964 truncated before it was used.
3965
8fd02eb7
PE
3966 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3967 Otherwise, an out-of-range integer could cause undefined behavior
3968 on a 64-bit host.
3969
f8c86b69
PE
3970 * composite.c: Use int, not EMACS_INT, for characters.
3971 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3972 EMACS_INT, for values that are known to be in character range.
3973 This doesn't fix any bugs but is the usual style inside Emacs and
3974 may generate better code on 32-bit machines.
3975
34206dd2
PE
3976 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3977 This is for reasons similar to the recent CHAR_STRING fix.
3978 * charset.c (Fencode_char): Check that character arg is actually
3979 a character. Pass an int to ENCODE_CHAR.
3980 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3981 wider than 'int', as a compile-time check to prevent future regressions
3982 in this area.
3983
c5958d4c 3984 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
3985
3986 Make sure a 64-bit char is never passed to CHAR_STRING.
3987 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3988 by silently ignoring the top 32 bits, allowing some values
3989 that were far too large to be valid characters.
3990 * character.h: Include <verify.h>.
3991 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3992 arguments are no wider than unsigned, as a compile-time check
3993 to prevent future regressions in this area.
3994 * data.c (Faset):
01103c44 3995 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
3996 (Fsubst_char_in_region):
3997 * fns.c (concat):
3998 * xdisp.c (decode_mode_spec_coding):
3999 Adjust to CHAR_STRING's new requirement.
4000 * editfns.c (Finsert_char, Fsubst_char_in_region):
4001 * fns.c (concat): Check that character args are actually
4002 characters. Without this test, these functions did the wrong
4003 thing with wildly out-of-range values on 64-bit hosts.
4004
d37ca623
PE
4005 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4006 These casts should not be needed on 32-bit hosts, either.
4007 * keyboard.c (read_char):
4008 * lread.c (Fload): Remove casts to unsigned.
4009
ea204efb
PE
4010 * lisp.h (UNSIGNED_CMP): New macro.
4011 This fixes comparison bugs on 64-bit hosts.
4012 (ASCII_CHAR_P): Use it.
4013 * casefiddle.c (casify_object):
01103c44 4014 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
4015 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4016 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4017 * dispextern.h (FACE_FROM_ID):
4018 * keyboard.c (read_char): Use UNSIGNED_CMP.
4019
41cb286c
PE
4020 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4021 not to EMACS_INT, to avoid GCC warning.
4022
4a1b9832
PE
4023 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4024
55daad71
PE
4025 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4026 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4027 isn't needed on 32-bit machines.
8f95c75c 4028
01103c44
PE
4029 * buffer.c (Fgenerate_new_buffer_name):
4030 Use EMACS_INT for count, not int.
0ceccced 4031 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
4032
4033 * data.c (Qcompiled_function): Now static.
4034
c6f072e7
PE
4035 * window.c (window_body_lines): Now static.
4036
20ce5912
PE
4037 * image.c (gif_load): Rename local to avoid shadowing.
4038
9c4c5f81
PE
4039 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4040 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4041 * alloc.c (make_save_value): Integer argument is now of type
4042 ptrdiff_t, not int.
4043 (mark_object): Use ptrdiff_t, not int.
4044 * lisp.h (pD): New macro.
4045 * print.c (print_object): Use it.
4046
c0c5c8ae
PE
4047 * alloc.c: Use EMACS_INT, not int, to count objects.
4048 (total_conses, total_markers, total_symbols, total_vector_size)
4049 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
4050 (total_free_floats, total_floats, total_free_intervals)
4051 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
4052 Now EMACS_INT, not int. All uses changed.
4053 (Fgarbage_collect): Compute overall total using a double, so that
4054 integer overflow is less likely to be a problem. Check for overflow
4055 when converting back to an integer.
5a25e253
PE
4056 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4057 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4058 These were 'int' variables that could overflow on 64-bit hosts;
4059 they were never used, so remove them instead of repairing them.
211a0b2a 4060 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
4061 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4062 Previously, this ceilinged at INT_MAX, but that doesn't work on
4063 64-bit machines.
e46bb31a 4064 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 4065
c78baabf 4066 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 4067 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
4068 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4069 when a (possibly-narrower) signed value would do just as well.
4070 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 4071
c9d624c6
PE
4072 * alloc.c: Catch some string size overflows that we were missing.
4073 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4074 for convenience in STRING_BYTES_MAX.
4075 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4076 The definition here is exact; the one in lisp.h was approximate.
4077 (allocate_string_data): Check for string overflow. This catches
4078 some instances we weren't catching before. Also, it catches
4079 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4080 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4081 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 4082
c9d624c6
PE
4083 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4084 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 4085 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 4086
353032ce
PE
4087 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4088
2bccce07
PE
4089 * alloc.c (Fmake_string): Check for out-of-range init.
4090
0ac30604
SM
40912011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4092
4093 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4094
c195f2de
JD
40952011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4096
4097 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4098 xg_get_default_scrollbar_width.
4099
4100 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4101 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4102 (style_changed_cb): Call update_theme_scrollbar_width and call
4103 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4104 all frames (Bug#8505).
4105 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4106 Call gtk_window_set_resizable if HAVE_GTK3.
4107 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4108 and height if HAVE_GTK3 (Bug#8505).
4109 (scroll_bar_width_for_theme): New variable.
4110 (update_theme_scrollbar_width): New function.
4111 (xg_get_default_scrollbar_width): Move code to
4112 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4113 (xg_initialize): Call update_theme_scrollbar_width.
4114
4115 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4116
4117 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4118
e10ac9f1
MR
41192011-06-12 Martin Rudalics <rudalics@gmx.at>
4120
4121 * frame.c (make_frame): Call other_buffer_safely instead of
4122 other_buffer.
4123
4124 * window.c (temp_output_buffer_show): Call display_buffer with
4125 second argument Vtemp_buffer_show_specifiers and reset latter
4126 immediately after the call.
4127 (Vtemp_buffer_show_specifiers): New variable.
4128 (auto_window_vscroll_p, next_screen_context_lines)
4129 (Vscroll_preserve_screen_position): Remove leading asterisks from
4130 doc-strings.
4131
2d3c217e 41322011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 4133
7b7f97e8 4134 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
4135 * buffer.c (Qclone_number): Remove for now, as it's unused.
4136 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4137 (record_buffer): Remove unused local.
4138 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4139 (set_frame_buffer_list): Remove; unused.
4140 * frame.h (other_visible_frames): Remove decl.
4141 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4142 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4143 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4144 if HAVE_GPM.
4145 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4146 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4147 Define only if HAVE_GPM.
4148 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4149 (update_hints_inhibit): Remove; never set. All uses removed.
4150 * widgetprv.h (emacsFrameClassRec): Remove decl.
4151 * window.c (delete_deletable_window): Now returns void, since it
4152 wasn't returning anything.
4153 (compare_window_configurations): Remove unused locals.
4154 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4155 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
4156 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4157 the same widths as pointers. This follows up on the 2011-05-06 patch.
4158 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4159 * xterm.h: Likewise.
4160 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4161
1384b89e
JB
41622011-06-12 Juanma Barranquero <lekktu@gmail.com>
4163
4164 * makefile.w32-in: Update dependencies.
4165 (LISP_H): Add lib/intprops.h.
4166
1100a63c
CY
41672011-06-11 Chong Yidong <cyd@stupidchicken.com>
4168
4169 * image.c (gif_load): Add animation frame delay to the metadata.
4170 (syms_of_image): Use DEFSYM. New symbol `delay'.
4171
6198ccd0
MR
41722011-06-11 Martin Rudalics <rudalics@gmx.at>
4173
4174 * window.c (delete_deletable_window): Re-add.
4175 (Fset_window_configuration): Rewrite to handle dead buffers and
4176 consequently deletable windows.
4177 (window_tree, Fwindow_tree): Remove. Supply functionality in
4178 window.el.
4179 (compare_window_configurations): Simplify code.
4180
b6e3633c
AS
41812011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4182
1ab0dee5
AS
4183 * image.c (imagemagick_load_image): Fix type mismatch.
4184 (Fimagemagick_types): Likewise.
4185
b6e3633c
AS
4186 * window.h (replace_buffer_in_windows): Declare.
4187
9397e56f
MR
41882011-06-11 Martin Rudalics <rudalics@gmx.at>
4189
4190 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4191 Qclone_number. Remove external declaration of Qdelete_window.
4192 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4193 code.
640c8776
SM
4194 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4195 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
4196 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4197 buffer list implementation.
4198 (other_buffer_safely): New function.
4199 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4200 calls to replace_buffer_in_windows and
4201 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4202 if allowed.
4203 (record_buffer): Inhibit quitting and rewrite using quittable
4204 functions. Run Qbuffer_list_update_hook if allowed.
4205 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
4206 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4207 Move switch-to-buffer to window.el.
9397e56f
MR
4208 (bury-buffer): Move to window.el.
4209 (Vbuffer_list_update_hook): New variable.
4210
4211 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4212 section.
4213
4214 * window.h (resize_frame_windows): Move up in code.
4215 (Fwindow_frame): Remove EXFUN.
4216 (replace_buffer_in_all_windows): Remove prototype.
4217 (replace_buffer_in_windows_safely): Add prototype.
4218
4219 * window.c: Declare Qdelete_window static again. Move down
4220 declaration of select_count.
4221 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4222 (Fother_window): Move to window.el.
4223 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4224 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4225 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4226 window.el.
4227 (replace_buffer_in_windows): Implement by calling
4228 Qreplace_buffer_in_windows.
4229 (replace_buffer_in_all_windows): Remove with some functionality
4230 moved into replace_buffer_in_windows_safely.
4231 (replace_buffer_in_windows_safely): New function.
4232 (select_window_norecord, select_frame_norecord): Move in front
4233 of run_window_configuration_change_hook. Remove now obsolete
4234 declarations.
640c8776
SM
4235 (Fset_window_buffer): Rewrite doc-string.
4236 Call Qrecord_window_buffer.
9397e56f
MR
4237 (keys_of_window): Move binding for other-window to window.el.
4238
b50691aa
CY
42392011-06-11 Chong Yidong <cyd@stupidchicken.com>
4240
4241 * dispextern.h (struct image): Replace data member, whose int_val
4242 and ptr_val fields were not used by anything, with a single
4243 lisp_val object.
4244
4245 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4246 (gif_clear_image, gif_load, imagemagick_load_image)
4247 (gs_clear_image, gs_load): Callers changed.
4248
3f754b86
PE
42492011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4250
cca69397
PE
4251 * buffer.h: Include <time.h>, for time_t.
4252 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4253
109e28d0
PE
4254 Fix minor problems found by static checking.
4255
60737f02
PE
4256 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4257
4b66faf3
PE
4258 Make identifiers static if they are not used in other modules.
4259 * data.c (Qcompiled_function, Qframe, Qvector):
4260 * image.c (QimageMagick, Qsvg):
4261 * minibuf.c (Qmetadata):
4262 * window.c (resize_window_check, resize_root_window): Now static.
4263 * window.h (resize_window_check, resize_root_window): Remove decls.
4264
109e28d0
PE
4265 * window.c (window_deletion_count, delete_deletable_window):
4266 Remove; unused.
46a4ce9e
PE
4267 (window_body_lines): Now static.
4268 (Fdelete_other_windows_internal): Mark vars as initialized.
4269 Make sure 'resize_failed' is initialized.
4270 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4271 (resize_window_apply): Remove unused local.
4272 * window.h (delete_deletable_window): Remove decl.
4273
109e28d0 4274 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
4275 (imagemagick_load_image): Fix pointer signedness problem by changing
4276 last arg from unsigned char * to char *. All uses changed.
4277 Also, fix a local for similar reasons.
4278 Remove unused locals. Remove locals to avoid shadowing.
4279 (fn_rsvg_handle_free): Remove; unused.
4280 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 4281 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 4282
3f754b86
PE
4283 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4284
2547adb1
CY
42852011-06-10 Chong Yidong <cyd@stupidchicken.com>
4286
4287 * image.c (gif_load): Fix omitted cast error introduced by
4288 2011-06-06 change.
4289
2c8e37d4
MR
42902011-06-10 Martin Rudalics <rudalics@gmx.at>
4291
4292 * window.h (resize_proportionally, orig_total_lines)
4293 (orig_top_line): Remove from window structure.
4294 (set_window_height, set_window_width, change_window_heights)
4295 (Fdelete_window): Remove prototypes.
4296 (resize_frame_windows): Remove duplicate declaration.
4297
440a42e3
EZ
42982011-06-10 Eli Zaretskii <eliz@gnu.org>
4299
4300 * window.h (resize_frame_windows, resize_window_check)
4301 (delete_deletable_window, resize_root_window)
4302 (resize_frame_windows): Declare prototypes.
4303
4304 * window.c (resize_window_apply): Make definition be "static" to
4305 match the prototype.
4306
562dd5e9
MR
43072011-06-10 Martin Rudalics <rudalics@gmx.at>
4308
4309 * window.c: Remove declarations of Qwindow_size_fixed,
4310 window_min_size_1, window_min_size_2, window_min_size,
4311 size_window, window_fixed_size_p, enlarge_window, delete_window.
4312 Remove static from declaration of Qdelete_window, it's
4313 temporarily needed by Fbury_buffer.
4314 (replace_window): Don't assign orig_top_line and
4315 orig_total_lines.
4316 (Fdelete_window, delete_window): Remove. Window deletion is
4317 handled by window.el.
640c8776
SM
4318 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4319 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
4320 (Fdelete_other_windows): Remove. Deleting other windows is
4321 handled by window.el.
4322 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4323 handled in window.el.
4324 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4325 Window minimum sizes are handled in window.el.
4326 (shrink_windows, size_window, set_window_height)
4327 (set_window_width, change_window_heights, window_height)
4328 (window_width, CURBEG, CURSIZE, enlarge_window)
4329 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4330 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4331 handled in window.el.
4332 (make_dummy_parent): Rename to make_parent_window and give it a
4333 second argument horflag.
4334 (make_window): Don't set resize_proportionally any more.
4335 (Fsplit_window): Remove. Windows are split in window.el.
4336 (save_restore_action, save_restore_orig_size)
4337 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4338 Resize mini windows in window.el.
4339 (grow_mini_window, shrink_mini_window): Implement by calling
4340 Qresize_root_window_vertically, resize_window_check and
4341 resize_window_apply.
640c8776
SM
4342 (saved_window, Fset_window_configuration, save_window_save):
4343 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
4344 resize_proportionally.
4345 (window_min_height, window_min_width): Move to window.el.
4346 (keys_of_window): Move bindings for delete-other-windows,
4347 split-window, delete-window and enlarge-window to window.el.
4348
4349 * buffer.c: Temporarily extern Qdelete_window.
4350 (Fbury_buffer): Temporarily call Qdelete_window instead of
4351 Fdelete_window (Fbury_buffer will move to window.el soon).
4352
4353 * frame.c (set_menu_bar_lines_1): Remove code handling
4354 orig_top_line and orig_total_lines.
4355
4356 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4357 set_window_height but set heights directly.
4358 (change_frame_size_1): Use resize_frame_windows.
4359
4360 * xdisp.c (init_xdisp): Don't use set_window_height but set
4361 heights directly.
4362
640c8776
SM
4363 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4364 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
4365 run_window_configuration_change_hook.
4366
4367 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4368 instead of change_window_heights and run
4369 run_window_configuration_change_hook.
4370
1a13852e
MR
43712011-06-09 Martin Rudalics <rudalics@gmx.at>
4372
4373 * window.c (replace_window): Rename second argument REPLACEMENT to
4374 NEW. New third argument SETFLAG. Rewrite.
4375 (delete_window, make_dummy_parent): Call replace_window with
4376 third argument 1.
4377 (window_list_1): Move down in code.
4378 (run_window_configuration_change_hook): Move set_buffer part
4379 before select_frame_norecord part in order to unwind correctly.
4380 Rename count1 to count.
4381 (recombine_windows, delete_deletable_window, resize_root_window)
4382 (Fdelete_other_windows_internal)
4383 (Frun_window_configuration_change_hook, make_parent_window)
4384 (resize_window_check, resize_window_apply, Fresize_window_apply)
4385 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
4386 (Fdelete_window_internal, Fresize_mini_window_internal):
4387 New functions.
1a13852e
MR
4388 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4389
f3d1777e
MR
43902011-06-08 Martin Rudalics <rudalics@gmx.at>
4391
496e208e
MR
4392 * window.h (window): Add some new members to window structure -
4393 normal_lines, normal_cols, new_total, new_normal, clone_number,
4394 splits, nest, prev_buffers, next_buffers.
4395 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 4396 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 4397
f3d1777e
MR
4398 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4399 Remove.
496e208e
MR
4400 (make_dummy_parent): Set new members of windows structure.
4401 (make_window): Move down in code. Handle new members of window
4402 structure.
4403 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4404 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4405 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4406 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
4407 (Fset_window_next_buffers, Fset_window_clone_number):
4408 New functions.
496e208e
MR
4409 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4410 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4411 Doc-string fixes.
4412 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4413 Argument WINDOW can be now internal window too.
4414 (Fwindow_use_time): Move up in code.
4415 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4416 Rewrite doc-string.
4417 (Fset_window_configuration, saved_window)
4418 (Fcurrent_window_configuration, save_window_save): Handle new
4419 members of window structure.
b9e809c2
MR
4420 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4421 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4422 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4423 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4424 Qget_mru_window, Qresize_root_window,
4425 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4426 Qauto_buffer_name; staticpro them.
f3d1777e 4427
abde8f8c
MR
44282011-06-07 Martin Rudalics <rudalics@gmx.at>
4429
4430 * window.c (Fwindow_total_size, Fwindow_left_column)
4431 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4432 (Fwindow_list_1): New functions.
4433 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
4434 (Fwindow_width, Fscroll_left, Fscroll_right):
4435 Use window_body_cols instead of window_box_text_cols.
4436 (delete_window, Fset_window_configuration):
4437 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
4438 (delete_all_subwindows): Take a window as argument and not a
4439 structure. Rewrite.
190b47e6
MR
4440 (window_loop): Remove handling of GET_LRU_WINDOW and
4441 GET_LARGEST_WINDOW.
4442 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
4443
4444 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
4445 window_box_text_cols. delete_all_subwindows now takes a
4446 Lisp_Object as argument.
abde8f8c 4447
640c8776
SM
4448 * indent.c (compute_motion, Fcompute_motion):
4449 Use window_body_cols instead of window_box_text_cols.
abde8f8c 4450
fa8a67e6
MR
4451 * frame.c (delete_frame): Call delete_all_subwindows with root
4452 window as argument.
4453
a54e3482
DC
44542011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4455
4456 * fns.c (Fputhash): Document return value.
4457
60002bf5
CY
44582011-06-06 Chong Yidong <cyd@stupidchicken.com>
4459
4460 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4461
0c671da6 44622011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 4463
b862a52a 4464 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 4465
be44ca6c
PE
4466 Check for overflow when converting integer to cons and back.
4467 * charset.c (Fdefine_charset_internal, Fdecode_char):
4468 Use cons_to_unsigned to catch overflow.
4469 (Fencode_char): Use INTEGER_TO_CONS.
4470 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4471 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4472 * data.c (long_to_cons, cons_to_long): Remove.
4473 (cons_to_unsigned, cons_to_signed): New functions.
4474 These signal an error for invalid or out-of-range values.
4475 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4476 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4477 * font.c (Ffont_variation_glyphs):
4478 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4479 * lisp.h: Include <intprops.h>.
4480 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4481 (cons_to_signed, cons_to_unsigned): New decls.
4482 (long_to_cons, cons_to_long): Remove decls.
4483 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4484 (Fprimitive_undo): Use CONS_TO_INTEGER.
4485 * xfns.c (Fx_window_property): Likewise.
4486 * xselect.c: Include <limits.h>.
4487 (x_own_selection, selection_data_to_lisp_data):
4488 Use INTEGER_TO_CONS.
4489 (x_handle_selection_request, x_handle_selection_clear)
4490 (x_get_foreign_selection, Fx_disown_selection_internal)
4491 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4492 (lisp_data_to_selection_data): Use cons_to_unsigned.
4493 (x_fill_property_data): Use cons_to_signed.
4494 Report values out of range.
4495
d1f3d2af
PE
4496 Check for buffer and string overflow more precisely.
4497 * buffer.h (BUF_BYTES_MAX): New macro.
4498 * lisp.h (STRING_BYTES_MAX): New macro.
4499 * alloc.c (Fmake_string):
4500 * character.c (string_escape_byte8):
4501 * coding.c (coding_alloc_by_realloc):
4502 * doprnt.c (doprnt):
4503 * editfns.c (Fformat):
4504 * eval.c (verror):
4505 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4506 since they may not be the same number.
4507 * editfns.c (Finsert_char):
4508 * fileio.c (Finsert_file_contents):
4509 Likewise for BUF_BYTES_MAX.
4510
dd52fcea
PE
4511 * image.c: Use ptrdiff_t, not int, for sizes.
4512 (slurp_file): Switch from int to ptrdiff_t.
4513 All uses changed.
4514 (slurp_file): Check that file size fits in both size_t (for
4515 malloc) and ptrdiff_t (for sanity and safety).
4516
7f9bbdbb
PE
4517 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4518 if b->modtime has its maximal value.
4519
dfe18f82
PE
4520 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4521
84acfcf0
PE
4522 Don't assume time_t can fit into int.
4523 * buffer.h (struct buffer.modtime): Now time_t, not int.
4524 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4525 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4526
ccd9a01a
PE
4527 Minor fixes for signed vs unsigned integers.
4528 * character.h (MAYBE_UNIFY_CHAR):
4529 * charset.c (maybe_unify_char):
4530 * keyboard.c (read_char, reorder_modifiers):
4531 XINT -> XFASTINT, since the integer must be nonnegative.
4532 * ftfont.c (ftfont_spec_pattern):
4533 * keymap.c (access_keymap, silly_event_symbol_error):
4534 XUINT -> XFASTINT, since the integer must be nonnegative.
4535 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4536 since it makes no difference and we prefer signed.
4537 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4538 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4539 nonnegative.
4540
d6d100dd
SM
45412011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4542
4543 * window.h (Fwindow_frame): Declare.
4544
2b6148e4
PE
45452011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4546
4547 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4548 (SPARE_MEMORY): Always define.
4549 (LARGE_REQUEST): Remove.
4550 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4551
f230ecc9
MR
45522011-06-06 Martin Rudalics <rudalics@gmx.at>
4553
727e958e
MR
4554 * lisp.h: Move EXFUNS for Fframe_root_window,
4555 Fframe_first_window and Fset_frame_selected_window to window.h.
4556
4557 * window.h: Move EXFUNS for Fframe_root_window,
4558 Fframe_first_window and Fset_frame_selected_window here from
4559 lisp.h.
4560
4561 * frame.c (Fwindow_frame, Fframe_first_window)
4562 (Fframe_root_window, Fframe_selected_window)
4563 (Fset_frame_selected_window): Move to window.c.
4564 (Factive_minibuffer_window): Move to minibuf.c.
4565 (Fother_visible_frames_p): New function.
4566
4567 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4568
f230ecc9
MR
4569 * window.c (decode_window, decode_any_window): Move up in code.
4570 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4571 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
4572 (Fwindow_buffer): Move up and rewrite doc-string.
4573 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4574 (Fwindow_prev): New functions.
727e958e
MR
4575 (Fwindow_frame): Move here from frame.c. Accept any window as
4576 argument.
4577 (Fframe_root_window, Fframe_first_window)
4578 (Fframe_selected_window): Move here from frame.c. Accept frame
4579 or arbitrary window as argument. Update doc-strings.
4580 (Fminibuffer_window): Move up in code.
4581 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
4582 (Fset_frame_selected_window): Move here from frame.c.
4583 Marginal rewrite.
727e958e
MR
4584 (Fselected_window, select_window, Fselect_window): Move up in
4585 code. Minor doc-string fixes.
f230ecc9 4586
4d09bcf6
PE
45872011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4588
4589 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4590 Do not assume that spare memory exists; that assumption is valid
4591 only if SYSTEM_MALLOC.
4592 (LARGE_REQUEST): New macro, so that the issue of large requests
4593 is separated from the issue of spare memory.
4594
810928a2
AS
45952011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4596
172418ad
AS
4597 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4598 format. (Bug#8806)
4599
43f862f7
AS
4600 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4601
810928a2
AS
4602 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4603 before statements.
4604
a059fe24
JD
46052011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4606
4607 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4608
4609 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4610
4611 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4612 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4613
989bf368
JB
46142011-06-05 Juanma Barranquero <lekktu@gmail.com>
4615
4616 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4617
4b80f674
CY
46182011-06-04 Chong Yidong <cyd@stupidchicken.com>
4619
4620 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4621 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
4622 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4623 New error handlers.
4b80f674
CY
4624 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4625 Obey Vx_select_enable_clipboard_manager. Catch errors in
4626 x_clipboard_manager_save (Bug#8779).
4627 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 4628 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 4629
99a33b77 46302011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
4631
4632 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4633
99a33b77 46342011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
4635
4636 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4637 in the current matrix if keep_current_p is non-zero.
4638
8264569d
EZ
46392011-06-04 Eli Zaretskii <eliz@gnu.org>
4640
4641 * bidi.c (bidi_level_of_next_char): Fix last change.
4642
57f97249
EZ
46432011-06-03 Eli Zaretskii <eliz@gnu.org>
4644
fec2107c 4645 Support bidi reordering of text covered by display properties.
57f97249 4646
fec2107c
EZ
4647 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4648 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4649 (bidi_cache_search, bidi_cache_iterator_state)
4650 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
4651 (bidi_level_of_next_char, bidi_move_to_visually_next):
4652 Support character positions inside a run of characters covered by a
fec2107c
EZ
4653 display string.
4654 (bidi_paragraph_init, bidi_resolve_explicit_1)
4655 (bidi_level_of_next_char): Call bidi_fetch_char and
4656 bidi_fetch_char_advance instead of FETCH_CHAR and
4657 FETCH_CHAR_ADVANCE.
4658 (bidi_init_it): Initialize new members.
4659 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4660 definitions.
4661 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4662 instead of using explicit *_CHAR codes.
d6d100dd
SM
4663 (bidi_resolve_explicit, bidi_resolve_weak):
4664 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
4665 bidirectional text is supported only in multibyte buffers.
4666 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4667 it to initialize the frame_window_p member of struct bidi_it.
4668 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4669 (bidi_resolve_explicit, bidi_resolve_weak)
4670 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4671 bidi_it->nchars is non-positive.
4672 (bidi_level_of_next_char): Don't try to lookup the cache for the
4673 next/previous character if nothing is cached there yet, or if we
4674 were just reseat()'ed to a new position.
c40e2fb2 4675
0e14fe90
EZ
4676 * xdisp.c (set_cursor_from_row): Set start and stop points
4677 according to the row's direction when priming the loop that looks
4678 for the glyph on which to display cursor.
4679 (single_display_spec_intangible_p): Function deleted.
4680 (display_prop_intangible_p): Reimplement to call
4681 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
4682 Accept 3 additional arguments needed by handle_display_spec.
4683 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
4684 values: lists, `(when COND...)' forms, etc.
4685 (single_display_spec_string_p): Support property values that are
4686 lists with the argument STRING its top-level element.
4687 (display_prop_string_p): Fix the condition for processing a
4688 property that is a list to be consistent with handle_display_spec.
fec2107c 4689 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
4690 last portion of handle_display_prop.
4691 (compute_display_string_pos): Accept additional argument
4692 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4693 value of a `display' property is a "replacing spec".
4694 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4695 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4696 the display property, but just return a value indicating whether
4697 the display property will replace the characters it covers.
4698 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4699 frame_window_p members of struct bidi_it.
d6d100dd
SM
4700 (compute_display_string_pos, compute_display_string_end):
4701 New functions.
fec2107c
EZ
4702 (push_it): Accept second argument POSITION, where pop_it should
4703 jump to continue iteration.
4704 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 4705
fec2107c
EZ
4706 * keyboard.c (adjust_point_for_property): Adjust the call to
4707 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
4708
4709 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
4710 (bidi_init_it): Update prototypes.
4711 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
4712 (compute_display_string_pos, compute_display_string_end):
4713 Declare prototypes.
fec2107c
EZ
4714 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4715 EMACS_INT.
fc6f18ce 4716
40087514 47172011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 4718
57f53182
PE
4719 Malloc failure behavior now depends on size of allocation.
4720 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4721 * lisp.h: Change signatures accordingly.
4722 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4723 All callers changed. (Bug#8762)
4724
4725 * gnutls.c: Use Emacs's memory allocators.
4726 Without this change, the gnutls library would invoke malloc etc.
4727 directly, which causes problems on non-SYNC_INPUT hosts, and which
4728 runs afoul of improving memory_full behavior. (Bug#8761)
4729 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4730 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4731 xfree instead of the default malloc, realloc, free.
4732 (Fgnutls_boot): No need to check for memory allocation failure,
4733 since xmalloc does that for us.
4734
ac32cd99 4735 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
4736 * category.c (hash_get_category_set):
4737 * ccl.c (ccl_driver):
4738 * charset.c (Fdefine_charset_internal):
4739 * charset.h (struct charset.hash_index):
4740 * composite.c (get_composition_id, gstring_lookup_cache)
4741 (composition_gstring_put_cache):
4742 * composite.h (struct composition.hash_index):
4743 * dispextern.h (struct image.hash):
4744 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4745 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4746 (hashfn_equal, hashfn_user_defined, make_hash_table)
4747 (maybe_resize_hash_table, hash_lookup, hash_put)
4748 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4749 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4750 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4751 * image.c (make_image, search_image_cache, lookup_image)
4752 (xpm_put_color_table_h):
4753 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 4754 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 4755 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 4756 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
4757 * alloc.c (allocate_vectorlike):
4758 Check for overflow in vector size calculations.
4759 * ccl.c (ccl_driver):
4760 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
4761 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4762 need to be updated by these changes.
40087514
PE
4763 * fns.c (make_hash_table, maybe_resize_hash_table):
4764 Check for integer overflow with large hash tables.
0de4bb68
PE
4765 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4766 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4767 (SXHASH_REDUCE): New macro.
4768 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4769 Use it instead of discarding useful hash info with large hash values.
4770 (sxhash_float): New function.
4771 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4772 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
4773 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4774 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
4775 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4776 Adjust signatures to match updated version of code.
4777 (consing_since_gc): Now EMACS_INT, since a single hash table can
4778 use more than INT_MAX bytes.
4779
698d32e2
DN
47802011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4781
4782 Make it possible to build with GCC-4.6+ -O2 -flto.
4783
4784 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4785
fd6fa53f
SM
47862011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4787
4788 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4789 Call minibuffer-inactive-mode.
4790
864db017
JB
47912011-05-31 Juanma Barranquero <lekktu@gmail.com>
4792
4793 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4794 Update dependencies.
4795
2ad0baf4
DN
47962011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4797
4798 * data.c (init_data): Remove code for UTS, this system is not
4799 supported anymore.
4800
4fcc2638
DN
48012011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4802
4803 Don't force ./temacs to start in terminal mode.
4804
4805 * frame.c (make_initial_frame): Initialize faces in all cases, not
4806 only when CANNOT_DUMP is defined.
4807 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4808
c56e0fd5
DN
48092011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4810
4811 * dispnew.c (add_window_display_history): Use const for the string
4812 pointer. Remove declaration, not needed.
4813
333d54da 48142011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 4815
55d4c1b2 4816 Use 'inline', not 'INLINE'.
333d54da 4817 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
4818 * alloc.c, fontset.c (INLINE): Remove.
4819 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4820 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4821 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4822 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4823 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4824
738db178
DN
48252011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4826
4827 Make it possible to run ./temacs.
4828
4829 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4830 syms_of_callproc does the same thing. Remove test for
4831 "initialized", do it in the caller.
4832 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4833
620c53a6
SM
48342011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4835
4836 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4837 (read_minibuf): Use get_minibuffer.
4838 (syms_of_minibuf): Use DEFSYM.
4839 (Qmetadata): New var.
4840 * data.c (Qbuffer): Don't make it static.
4841 (syms_of_data): Use DEFSYM.
4842
e003a292
PE
48432011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4844
4845 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4846 (CCL_CODE_MIN): New macro.
4847
ed008a6d
PE
48482011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4849
3687c2ef
PE
4850 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4851
ed008a6d
PE
4852 * eval.c (Qdebug): Now static.
4853 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4854 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4855 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4856
d66c4c7c
CY
48572011-05-29 Chong Yidong <cyd@stupidchicken.com>
4858
4859 * image.c: Various fixes to ImageMagick code comments.
4860 (Fimagemagick_types): Doc fix.
4861
5fbc2025
PE
48622011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4863
0196f88a
PE
4864 Minor fixes prompted by GCC 4.6.0 warnings.
4865
4866 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4867
5fbc2025
PE
4868 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4869 (x_clipboard_manager_save_all): Move extern decl to ...
4870 * xterm.h: ... here, so that it can be checked for consistency.
4871
1dd3c2d9
CY
48722011-05-29 Chong Yidong <cyd@stupidchicken.com>
4873
4874 * xselect.c (x_clipboard_manager_save_frame)
4875 (x_clipboard_manager_save_all): New functions.
4876 (Fx_clipboard_manager_save): Lisp function deleted.
4877
4878 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4879 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4880
4881 * xterm.h: Update prototype.
4882
5ba6571d
WX
48832011-05-28 William Xu <william.xwl@gmail.com>
4884
4885 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4886 exiting (Bug#8239).
4887
3eaff834
JM
48882011-05-28 Jim Meyering <meyering@redhat.com>
4889
e1900994 4890 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
4891 * fns.c (to_uchar): Define.
4892 (crypto_hash_function): Use it to convert some newly-signed
4893 variables to unsigned, to avoid sign-extension bugs. For example,
4894 without this change, (md5 "truc") would evaluate to
4895 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4896 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 4897 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 4898
0f6990a7
PE
48992011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4900
4901 Integer overflow fixes.
c8a9ca5a 4902
08686060
PE
4903 * dbusbind.c: Serial number integer overflow fixes.
4904 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
4905 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4906 to hold a serial number that is too large for a fixnum.
4907 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4908 Check for serial numbers out of range. Decode any serial number
59568bf0 4909 that was so large that it became a float. (Bug#8722)
08686060 4910
2d1fc3c7
PE
4911 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4912 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4913 Use XFASTINT rather than XUINT when numbers are nonnegative.
4914 (xd_append_arg, Fdbus_method_return_internal):
4915 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4916 arguments, check that Lisp number is nonnegative, rather than
59568bf0 4917 silently wrapping negative numbers around. (Bug#8722)
30217ff0 4918 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 4919 (Bug#8722)
2d1fc3c7 4920
c8a9ca5a
PE
4921 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4922
519e1d69
PE
4923 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4924
30569699
PE
4925 ccl: add integer overflow checks
4926 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4927 (IN_INT_RANGE): New macros.
4928 (ccl_driver): Use them to check for integer overflow when
4929 decoding a CCL program. Many of the new checks are whether XINT (x)
4930 fits in int; it doesn't always, on 64-bit hosts. The new version
4931 doesn't catch all possible integer overflows, but it's an
847044ea 4932 improvement. (Bug#8719)
30569699 4933
c11285dc
PE
4934 * alloc.c (make_event_array): Use XINT, not XUINT.
4935 There's no need for unsigned here.
4936
fdccd48e
PE
4937 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4938 This follows up to the 2011-05-06 change that substituted uintptr_t
4939 for EMACS_INT. This case wasn't caught back then.
4940
37910ab2
PE
4941 Rework Fformat to avoid integer overflow issues.
4942 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4943 now (part of C89). Include <verify.h>.
4944 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4945 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4946 (Fformat): Avoid the prepass trying to compute sizes; it was only
4947 approximate and thus did not catch overflow reliably. Instead, walk
4948 through the format just once, formatting and computing sizes as we go,
4949 checking for integer overflow at every step, and allocating a larger
4950 buffer as needed. Keep track separately whether the format is
4951 multibyte. Keep only the most-recently calculated precision, rather
4952 than them all. Record whether each argument has been converted to
4953 string. Use EMACS_INT, not int, for byte and char and arg counts.
4954 Support field widths and precisions larger than INT_MAX. Avoid
4955 sprintf's undefined behavior with conversion specifications such as %#d
4956 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4957 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4958 formatting out-of-range floating point numbers with int
9173deec 4959 formats. (Bug#8668)
37910ab2 4960
2e6578fb
PE
4961 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4962
0ae6bdee
PE
4963 * data.c: Avoid integer truncation in expressions involving floats.
4964 * data.c: Include <intprops.h>.
4965 (arith_driver): When there's an integer overflow in an expression
4966 involving floating point, convert the integers to floating point
4967 so that the resulting value does not suffer from catastrophic
4968 integer truncation. For example, on a 64-bit host (* 4
4969 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4970 Do not rely on undefined behavior after integer overflow.
4971
de883a70
PE
4972 merge count_size_as_multibyte, parse_str_to_multibyte
4973 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 4974 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
4975 Check for integer overflow.
4976 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4977 since it's now a duplicate of the other. This is more of
4978 a character than a buffer op, so better that it's in character.c.
4979 * fns.c, print.c: Adjust to above changes.
4980
2ff916cb
PE
49812011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4982
4983 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4984
f1b54466
PE
49852011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4986
fb1ac845
PE
4987 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4988 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4989 (x_clipboard_manager_save): Now static.
4990 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4991
f1b54466
PE
4992 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4993 (crypto_hash_function): Now static.
4994 Fix pointer signedness problems. Avoid unnecessary initializations.
4995
a9f737ee
CY
49962011-05-27 Chong Yidong <cyd@stupidchicken.com>
4997
4998 * termhooks.h (Vselection_alist): Make it terminal-local.
4999
5000 * terminal.c (create_terminal): Initialize it.
5001
5002 * xselect.c: Support for clipboard managers.
5003 (Vselection_alist): Move to termhooks.h as terminal-local var.
5004 (LOCAL_SELECTION): New macro.
5005 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5006 (symbol_to_x_atom): Remove gratuitous arg.
5007 (x_handle_selection_request, lisp_data_to_selection_data)
5008 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
5009 (x_own_selection, x_get_local_selection, x_convert_selection):
5010 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
5011 (some_frame_on_display): Delete unused function.
5012 (Fx_own_selection_internal, Fx_get_selection_internal)
5013 (Fx_disown_selection_internal, Fx_selection_owner_p)
5014 (Fx_selection_exists_p): New optional frame arg.
5015 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5016 (x_handle_selection_clear): Don't treat other terminals with the
5017 same keyboard specially. Use the terminal-local Vselection_alist.
5018 (x_clear_frame_selections): Use Frun_hook_with_args.
5019
5020 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5021
5022 * xterm.h: Add support for those atoms.
5023
e067f0c1
CY
50242011-05-26 Chong Yidong <cyd@stupidchicken.com>
5025
5026 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5027 (converted_selections, conversion_fail_tag): New global variables.
5028 (x_selection_request_lisp_error): Free the above.
5029 (x_get_local_selection): Remove unnecessary code.
5030 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
5031 of converted selections stored in converted_selections.
5032 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
5033 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5034 (x_convert_selection): New function.
5035 (x_handle_selection_event): Simplify.
5036 (x_get_foreign_selection): Don't ignore incoming requests while
5037 waiting for an answer; this will fail when we implement
5038 SAVE_TARGETS, and seems unnecessary anyway.
5039 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5040 (Vx_sent_selection_functions): Doc fix.
5041
0f4aebc0
LL
50422011-05-26 Leo Liu <sdl.web@gmail.com>
5043
5044 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5045
e61124cd
YM
50462011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5047
5048 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5049
5050 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5051 for fringe update if it has periodic bitmap.
ac389d0c 5052 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
5053 and fringe_bitmap_periodic_p.
5054
5055 * fringe.c (get_fringe_bitmap_data): New function.
5056 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5057 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5058 row. Mark glyph row for fringe update if periodicity changed.
5059
5060 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5061 for fringe update unless it has periodic bitmap.
5062
f16d9837
KH
50632011-05-25 Kenichi Handa <handa@m17n.org>
5064
5065 * xdisp.c (get_next_display_element): Set correct it->face_id for
5066 a static composition.
5067
e1b90ef6
LL
50682011-05-24 Leo Liu <sdl.web@gmail.com>
5069
5070 * deps.mk (fns.o):
5071 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5072
5073 * fns.c (crypto_hash_function, Fsha1): New function.
5074 (Fmd5): Use crypto_hash_function.
5075 (syms_of_fns): Add Ssha1.
5076
7400048f
PE
50772011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5078
5079 * gnutls.c: Remove unused macros.
5080 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5081 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5082 Remove macros that are defined and never used.
5083 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5084
abb71cf4
CY
50852011-05-22 Chong Yidong <cyd@stupidchicken.com>
5086
5087 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5088 (Fx_get_selection_internal): Minor cleanup.
5089 (Fx_own_selection_internal): Rename arguments for consistency with
5090 select.el.
5091
6307db39
PE
50922011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5093
5094 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5095
f3d4e0a4
CY
50962011-05-22 Chong Yidong <cyd@stupidchicken.com>
5097
5098 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5099
4d8ade89
YM
51002011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5101
5102 * dispnew.c (scrolling_window): Don't exclude the case that the
5103 last enabled row in the desired matrix touches the bottom boundary.
5104
32078c8d
GM
51052011-05-21 Glenn Morris <rgm@gnu.org>
5106
5107 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
5108 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5109 and add some more files.
32078c8d 5110
7285dc67
EZ
51112011-05-20 Eli Zaretskii <eliz@gnu.org>
5112
5113 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5114 report_file_error introduced by the change from 2011-05-07.
5115
89d1bd22
PE
51162011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5117
5118 * systime.h (Time): Define only if emacs is defined.
5119 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5120 where the include path doesn't have X11/X.h by default. See
5121 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5122
e23640bb 51232011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
5124
5125 * composite.c (find_automatic_composition): Fix previous change.
5126
b9704ad9
GM
51272011-05-20 Glenn Morris <rgm@gnu.org>
5128
5129 * lisp.mk: New file, split from Makefile.in.
5130 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5131 (shortlisp): Remove.
5132 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5133
4a720484
GM
51342011-05-19 Glenn Morris <rgm@gnu.org>
5135
5136 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5137 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5138 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5139 (lisp): Set the order to that of loadup.el.
5140 (shortlisp): Make it a copy of $lisp.
5141 (SOME_MACHINE_LISP): Remove.
5142 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5143 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5144
a28d4396
KH
51452011-05-18 Kenichi Handa <handa@m17n.org>
5146
5147 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5148 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5149 (find_automatic_composition): Mostly rewrite for efficiency.
5150
a2b1fa8e
JB
51512011-05-18 Juanma Barranquero <lekktu@gmail.com>
5152
5153 * makefile.w32-in: Update dependencies.
5154
8e1f5610
CS
51552011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5156
5157 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 5158 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 5159
7025ee00 51602011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 5161
cdfa6eab
PE
5162 Fix some integer overflow issues, such as string length overflow.
5163
06d6db33
PE
5164 * insdel.c (count_size_as_multibyte): Check for string overflow.
5165
2b4560a8
PE
5166 * character.c (lisp_string_width): Check for string overflow.
5167 Use EMACS_INT, not int, for string indexes and lengths; in
5168 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5169 the resulting string length overflows an EMACS_INT; instead,
5170 report a string overflow if no precision given. When checking for
5171 precision exhaustion, use a check that cannot possibly have
5172 integer overflow. (Bug#8675)
5173 * character.h (lisp_string_width): Adjust to new signature.
5174
cb93f9be
PE
5175 * alloc.c (string_overflow): New function.
5176 (Fmake_string): Use it. This doesn't change behavior, but saves
5177 a few bytes and will simplify future changes.
5178 * character.c (string_escape_byte8): Likewise.
5179 * lisp.h (string_overflow): New decl.
5180
1a1f3366
PE
5181 Fixups, following up to the user-interface timestamp change.
5182 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5183 for UI timestamps, instead of unsigned long.
9fbd6841
PE
5184 * msdos.c (mouse_get_pos): Likewise.
5185 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
5186 * w32gui.h (Time): Define by including "systime.h" rather than by
5187 declaring it ourselves. (Bug#8664)
5188
d4e3e4d3
PE
5189 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5190 * image.c (clear_image_cache): Likewise.
5191
f6a24d19
PE
5192 * term.c (term_mouse_position): Don't assume time_t wraparound.
5193
08dc5ae6
PE
5194 Be more systematic about user-interface timestamps.
5195 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
5196 and sometimes 'EMACS_UINT', to represent these timestamps.
5197 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
5198 This makes the code easier to follow, and makes it easier to catch
5199 integer overflow bugs such as Bug#8664.
5200 * frame.c (Fmouse_position, Fmouse_pixel_position):
5201 Use Time, not unsigned long, for user-interface timestamps.
5202 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5203 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5204 * keyboard.h (last_event_timestamp): Likewise.
5205 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5206 * menu.h (xmenu_show): Likewise.
5207 * term.c (term_mouse_position): Likewise.
5208 * termhooks.h (struct input_event.timestamp): Likewise.
5209 (struct terminal.mouse_position_hook): Likewise.
5210 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5211 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5212 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5213 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5214 what it was before.
5215 * menu.h, termhooks.h: Include "systime.h", for Time.
5216
8e55734a
PE
5217 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5218 Don't assume that the difference between two unsigned long values
5219 can fit into an integer. At this point, we know button_down_time
5220 <= event->timestamp, so the difference must be nonnegative, so
5221 there's no need to cast the result if double-click-time is
5222 nonnegative, as it should be; check that it's nonnegative, just in
5223 case. This bug is triggered when events are more than 2**31 ms
86db42d2 5224 apart (about 25 days). (Bug#8664)
8e55734a 5225
841f1b75 5226 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 5227 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 5228
3e26f69c
PE
5229 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5230 that always fit in int. Use a sentinel instead of a counter, to
5231 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
5232 * frame.h (struct frame): Use int for menu_bar_items_used
5233 instead of EMACS_INT, since it always fits in int.
3e26f69c 5234
5cc152c0
PE
5235 * menu.c (grow_menu_items): Check for int overflow.
5236
d89eb65e
PE
5237 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5238
5235bd3e
PE
5239 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5240 Before, the code was not consistent. These values cannot exceed
5241 2**31 - 1 so there's no need to make them unsigned.
5242 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5243 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5244 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5245 as modifiers.
5246 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5247
bc827e23
PE
5248 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5249 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5250 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5251 presumably because the widths might not match.
5252
78eb494e
PE
5253 * window.c (size_window): Avoid needless test at loop start.
5254
04f2d78b
CB
52552011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5256
5257 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5258
d2fc7e3d 52592011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
5260
5261 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5262
d2fc7e3d 52632011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
5264
5265 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5266 `width' to `bar_area_x' and `bar_area_width', respectively.
5267 (x_scroll_run): Take account of fringe background extension.
5268
04f2d78b
CB
5269 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5270 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
5271 `bar_area_width', respectively.
5272 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5273 background extension.
5274
79b70037
GM
52752011-05-10 Jim Meyering <meyering@redhat.com>
5276
5277 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5278
2f142cc5
JB
52792011-05-10 Juanma Barranquero <lekktu@gmail.com>
5280
5281 * image.c (Finit_image_library): Return t for built-in image types,
5282 like pbm and xbm. (Bug#8640)
5283
57679c86
AS
52842011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5285
5286 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5287
888c9e86
EZ
52882011-05-07 Eli Zaretskii <eliz@gnu.org>
5289
b0512a1d
EZ
5290 * w32console.c (Fset_screen_color): Doc fix.
5291 (Fget_screen_color): New function.
5292 (syms_of_ntterm): Defsubr it.
5293
7285dc67
EZ
5294 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5295 unlink the temporary file if Fcall_process didn't create it in the
5296 first place.
5297 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5298 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
5299 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5300 cue to call_process_cleanup not to close that handle.
5301
4d3fcc8e
BK
53022011-05-07 Ben Key <bkey76@gmail.com>
5303
5304 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5305 one of two shell specific rules, either bootstrap-temacs-CMD or
5306 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5307 to the previous implementation of the bootstrap-temacs rule.
5308 The bootstrap-temacs-CMD rule is similar to the previous
5309 implementation of the bootstrap-temacs rule except that it
5310 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5311 variable.
5312
5313 These changes, along with some changes to nt/configure.bat,
5314 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5315 earlier fix to add support for --cflags and --ldflags options
5316 that include quotes so that it works whether make uses cmd or
5317 sh as the shell.
5318
b4289b64
MA
53192011-05-06 Michael Albinus <michael.albinus@gmx.de>
5320
5321 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5322 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5323 is a constant.
5324 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5325 a string. Handle both cases.
5326 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5327 (Fdbus_register_method): Use Qinvalid_function.
5328
af4c0e28
JB
53292011-05-06 Juanma Barranquero <lekktu@gmail.com>
5330
5331 * makefile.w32-in: Update dependencies.
5332 (LISP_H): Add inttypes.h and stdin.h.
5333 (PROCESS_H): Add unistd.h.
5334
c51453d9
EZ
53352011-05-06 Eli Zaretskii <eliz@gnu.org>
5336
5337 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5338 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5339
8ff0ac3c 53402011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 5341
4c4b566b
PE
5342 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5343
aab2b9b5
PE
5344 * term.c (vfatal): Remove stray call to va_end.
5345 It's not needed and the C Standard doesn't allow it here anyway.
5346
c378da0b
PE
5347 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5348 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5349
288b08c7
PE
5350 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5351 bytes.
5352
e3601888
PE
5353 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5354
db6c0e74
PE
5355 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5356
dd5963ea
PE
5357 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5358
88c9450f
PE
5359 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5360
2f9442b8
PE
5361 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5362
c032b5f8
PE
5363 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5364 * charset.c (Fdefine_charset_internal): Don't initialize
5365 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 5366 32-bit int (Bug#8600).
a108c10b
PE
5367
5368 * lread.c (read_integer): Be more consistent with string-to-number.
5369 Use string_to_number to do the actual conversion; this avoids
5370 rounding errors and fixes some other screwups. Without this fix,
5371 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5372 (digit_to_number): Move earlier, for benefit of read_integer.
5373 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 5374 not a digit in any supported base. (Bug#8602)
a108c10b 5375
ad5f9eea
PE
5376 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5377
aec1708a
PE
5378 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5379 to match comment at start of function. This also removes a
5380 GCC warning about overflow in a 32+64-bit port.
5381
47be4ab5
PE
5382 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5383
371cac43
PE
5384 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5385 Reported by Stefan Monnier in
5386 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
5387 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5388 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 5389
d01a7826
PE
5390 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5391 (EMACS_UINTPTR): Likewise, with uintptr_t.
5392
7fd47d5c
PE
5393 * lisp.h: Prefer 64-bit EMACS_INT if available.
5394 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5395 on 32-bit hosts that have 64-bit int, so that they can access
5396 large files.
122b0c86
PE
5397 However, temporarily disable this change unless the temporary
5398 symbol WIDE_EMACS_INT is defined.
7fd47d5c 5399
8727937b
PE
5400 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5401
8ac068ac
PE
5402 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5403 This removes an assumption that EMACS_INT and long are the same
5404 width as pointers. The assumption is true for Emacs porting targets
5405 now, but we want to make other targets possible.
5406 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5407 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5408 In the rest of the code, change types of integers that hold casted
5409 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5410 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5411 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5412 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5413 No need to cast type when ORing.
5414 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5415 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5416 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5417 assume EMACS_INT is the same width as char *.
5418 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5419 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5420 Remove no-longer-needed casts.
5421 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5422 (xg_tool_bar_help_callback, xg_make_tool_item):
5423 Use EMACS_INTPTR to hold an integer
5424 that will be cast to void *; this can avoid a GCC warning
5425 if EMACS_INT is not the same width as void *.
5426 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5427 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5428 (current_message_1, set_message_1):
5429 Use a local to convert to proper width without a cast.
5430 * xmenu.c (dialog_selection_callback): Likewise.
5431
ede49d71
PE
5432 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5433 Also, don't assume VALBITS / RAND_BITS is less than 5,
5434 and don't rely on undefined behavior when shifting a 1 left into
5435 the sign bit.
5436 * lisp.h (get_random): Change signature to match.
5437
2f30ecd0
PE
5438 * lread.c (hash_string): Use size_t, not int, for hash computation.
5439 Normally we prefer signed values; but hashing is special, because
5440 it's better to use unsigned division on hash table sizes so that
5441 the remainder is nonnegative. Also, size_t is the natural width
5442 for hashing into memory. The previous code used 'int', which doesn't
5443 retain enough info to hash well into very large tables.
5444 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5445
2a866e7b
PE
5446 * dbusbind.c: Don't possibly lose pointer info when converting.
5447 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5448 Use XPNTR rather than XHASH, so that the high-order bits of
5449 the pointer aren't lost when converting through void *.
5450
51639eac
PE
5451 * eval.c (Fautoload): Don't double-shift a pointer.
5452
92394119
PE
5453 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5454
dbdb9a7c
JB
54552011-05-06 Juanma Barranquero <lekktu@gmail.com>
5456
5457 * gnutls.c (DEF_GNUTLS_FN):
5458 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5459
db7a0b4f
AS
54602011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5461
5462 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5463 marker. (Bug#8610)
5464
f7ff1b0f 54652011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
5466
5467 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5468 New version that can reserve upto 2GB of heap space.
5469
f7ff1b0f 54702011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
5471
5472 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5473
639c109b
TZ
54742011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5475
5476 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5477 `gnutls_certificate_set_x509_key_file'.
5478
d2127135
JB
54792011-05-05 Juanma Barranquero <lekktu@gmail.com>
5480
5481 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5482 Update dependencies.
5483
e968f4f3
JB
54842011-05-04 Juanma Barranquero <lekktu@gmail.com>
5485
5486 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5487 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5488 Remove unused parameter `fildes'.
5489 * process.c (read_process_output, send_process): Don't pass it.
5490
84d358f0
JB
54912011-05-04 Juanma Barranquero <lekktu@gmail.com>
5492
5493 Fix previous change: the library cache is defined in w32.c.
5494 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5495 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5496
0898ca10
JB
54972011-05-04 Juanma Barranquero <lekktu@gmail.com>
5498
5499 Implement dynamic loading of GnuTLS on Windows.
5500
5501 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5502 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5503 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5504 Declare.
5505
5506 * gnutls.c (Qgnutls_dll): Define.
5507 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5508 (gnutls_*): Declare function pointers.
5509 (init_gnutls_functions): New function to initialize function pointers.
5510 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5511 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5512 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5513 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5514 (emacs_gnutls_write, emacs_gnutls_read)
5515 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5516 (Fgnutls_available_p): New function.
5517 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5518 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5519 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5520
5521 * image.c: Include w32.h.
5522 (Vimage_type_cache): Delete.
5523 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5524 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5525 (w32_delayed_load): Move to w32.c.
5526
5527 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5528
5529 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5530 (w32_delayed_load): Move from image.c. When loading a library, record
5531 its filename in the :loaded-from property of the library id.
5532 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5533 Initialize and staticpro them.
5534 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5535
5536 * process.c: Include lisp.h before w32.h, not after.
5537 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5538 instead of gnutls_record_check_pending.
5539
5540 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5541
ff4de4aa
TZ
55422011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5543
5544 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5545 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5546 as passed in.
5547
abe95abb
JD
55482011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5549
5550 * xterm.c (x_set_frame_alpha): Do not set property on anything
5551 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5552
e16e55d4
JB
55532011-05-02 Juanma Barranquero <lekktu@gmail.com>
5554
5555 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5556
bafcf6a5
JB
55572011-05-02 Juanma Barranquero <lekktu@gmail.com>
5558
5559 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5560 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5561 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5562 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5563 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5564 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5565 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5566 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5567 (Qgnutls_bootprop_callbacks_verify): Make static.
5568
e7a6747f
AS
55692011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5570
19ed11ba
AS
5571 * callproc.c: Indentation fixup.
5572
e7a6747f 5573 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
5574 (wait_for_termination, interruptible_wait_for_termination):
5575 Move after wait_for_termination_1.
e7a6747f 5576
1ef14cb4
LMI
55772011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5578
5579 * sysdep.c (interruptible_wait_for_termination): New function
5580 which is like wait_for_termination, but allows keyboard
5581 interruptions.
5582
5583 * callproc.c (Fcall_process): Add (:file "file") as an option for
5584 the STDOUT buffer.
5585 (Fcall_process_region): Ditto.
5586
330d880c
EZ
55872011-04-30 Eli Zaretskii <eliz@gnu.org>
5588
8db90b73
EZ
5589 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5590 rather than `XVECTOR (FOO)->size'.
5591
330d880c
EZ
5592 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5593 inttypes.h, as a gnulib replacement is used if it not available in
5594 system headers.
5595
15cbd324
EZ
55962011-04-21 Eli Zaretskii <eliz@gnu.org>
5597
5598 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5599 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5600 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5601
5602 * coding.c (coding_alloc_by_realloc): Error out if destination
5603 will grow beyond MOST_POSITIVE_FIXNUM.
5604 (decode_coding_emacs_mule): Abort if there isn't enough place in
5605 charbuf for the composition carryover bytes. Reserve an extra
5606 space for up to 2 characters produced in a loop.
5607 (decode_coding_iso_2022): Abort if there isn't enough place in
5608 charbuf for the composition carryover bytes.
5609
56102011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 5611
ae940cca
EZ
5612 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5613 aborting when %lld or %lll format is passed.
5614 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5615 %llo or %llx format is passed. (Bug#8545)
5616
03ab8921
EZ
5617 * window.c (window_scroll_line_based): Use a marker instead of
5618 simple variables to record original value of point. (Bug#7952)
5619
afda1437
EZ
5620 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5621 produced by %s or %c overflows available buffer space. (Bug#8545)
5622
f76dee0c
PE
56232011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5624
5625 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 5626 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 5627
fdc5744d
JB
56282011-04-28 Juanma Barranquero <lekktu@gmail.com>
5629
5630 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5631
638f053a
JB
56322011-04-28 Juanma Barranquero <lekktu@gmail.com>
5633
5634 * keyboard.c (Qdelayed_warnings_hook): Define.
5635 (command_loop_1): Run `delayed-warnings-hook'
5636 if Vdelayed_warnings_list is non-nil.
5637 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5638 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5639
d178f871
EZ
56402011-04-28 Eli Zaretskii <eliz@gnu.org>
5641
5642 * doprnt.c (doprnt): Don't return value smaller than the buffer
5643 size if the message was truncated. (Bug#8545).
5644
b124fd93
JB
56452011-04-28 Juanma Barranquero <lekktu@gmail.com>
5646
5647 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5648 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5649
e810457d
PE
56502011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5651
5652 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5653
ea51cceb
JB
56542011-04-27 Juanma Barranquero <lekktu@gmail.com>
5655
5656 * makefile.w32-in: Update dependencies.
5657
94dcfacf
EZ
56582011-04-27 Eli Zaretskii <eliz@gnu.org>
5659
5660 Improve `doprnt' and its usage. (Bug#8545)
5661 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5662 `format_end'. Remove support for %l as a conversion specifier.
5663 Don't use xrealloc. Improve diagnostics when the %l size modifier
5664 is used. Update the commentary.
5665
5666 * eval.c (verror): Simplify calculation of size_t.
5667
5668 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5669 messages.
5670
f61f41d7
PE
56712011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5672
5673 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5674 change.
5675
96fb4434
PE
56762011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5677
5678 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5679 This makes this file independent of the recent pseudovector change.
5680
671875da 56812011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 5682
69e9b5a3
PE
5683 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5684
b5f869a7 5685 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 5686 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 5687 Remove unused local.
c8926152 5688 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 5689
841a1577 5690 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
5691 GCC 4.6.0 optimizes based on type-based alias analysis.
5692 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
5693 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5694 != &v->size, and therefore "v->size = 1; b->size = 2; return
5695 v->size;" must therefore return 1. This assumption is incorrect
5696 for Emacs, since it type-puns struct Lisp_Vector * with many other
5697 types. To fix this problem, this patch adds a new type struct
f904488f 5698 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
5699 and pseudovectors, and helps optimizing compilers not get fooled
5700 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5701 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
5702 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5703 the size member.
eab3844f
PE
5704 (XSETPVECTYPE): Rewrite in terms of new macro.
5705 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5706 This is a bit clearer, and further avoids the possibility of
5707 undesirable aliasing.
5708 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 5709 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
5710 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5711 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
5712 (ASIZE): Now uses header.size rather than size.
5713 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
5714 to avoid the hassle of writing XVECTOR (foo)->header.size.
5715 (struct vectorlike_header): New type.
eab3844f
PE
5716 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5717 object, to help avoid aliasing.
5718 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5719 (SUBRP): Likewise, since Lisp_Subr is a special case.
5720 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5721 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5722 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 5723 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
5724 changed to be "header.size" and "header.next".
5725 * buffer.h (struct buffer): Likewise.
5726 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5727 * frame.h (struct frame): Likewise.
5728 * process.h (struct Lisp_Process): Likewise.
5729 * termhooks.h (struct terminal): Likewise.
5730 * window.c (struct save_window_data, struct saved_window): Likewise.
5731 * window.h (struct window): Likewise.
5732 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5733 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5734 * buffer.c (init_buffer_once): Likewise.
5735 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5736 special case.
5737 * process.c (Fformat_network_address): Use local var for size,
5738 for brevity.
5739
0df1eac5
PE
5740 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5741
847ab9d1 5742 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
5743 * data.c (atof): Remove decl; no longer used or needed.
5744 (digit_to_number): Move to lread.c.
5745 (Fstring_to_number): Use new string_to_number function, to be
5746 consistent with how the Lisp reader treats infinities and NaNs.
5747 Do not assume that floating-point numbers represent EMACS_INT
5748 without losing information; this is not true on most 64-bit hosts.
5749 Avoid double-rounding errors, by insisting on integers when
5750 parsing non-base-10 numbers, as the documentation specifies.
5751 * lisp.h (string_to_number): New decl, replacing ...
5752 (isfloat_string): Remove.
bc0a5c13 5753 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 5754 (read1): Do not accept +. and -. as integers; this
452f4150
PE
5755 appears to have been a coding error. Similarly, do not accept
5756 strings like +-1e0 as floating point numbers. Do not report
5757 overflow for integer overflows unless the base is not 10 which
5758 means we have no simple and reliable way to continue.
5759 Break out the floating-point parsing into a new
5760 function string_to_number, so that Fstring_to_number parses
5761 floating point numbers consistently with the Lisp reader.
04f2d78b 5762 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
5763 (E_CHAR, EXP_INT): Remove, replacing with ...
5764 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5765 (string_to_number): New function, replacing isfloat_string.
5766 This function checks for valid syntax and produces the resulting
5767 Lisp float number too. Rework it so that string-to-number
bc0a5c13 5768 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
5769 so that overflow for non-base-10 numbers is reported only when
5770 there's no portable and simple way to convert to floating point.
452f4150 5771
67769ffc
PE
5772 * textprop.c (set_text_properties_1): Rewrite for clarity,
5773 and to avoid GCC warning about integer overflow.
5774
c20db43f
PE
5775 * intervals.h (struct interval): Use EMACS_INT for members
5776 where EMACS_UINT might cause problems. See
5777 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5778 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5779 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5780 All uses changed.
37aa2f85
PE
5781 (offset_intervals): Tell GCC not to worry about length overflow
5782 when negating a negative length.
c20db43f 5783
2538aa2f
PE
5784 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5785 (overrun_check_free): Likewise.
5786
f2d3008d
PE
5787 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5788 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5789 word size.
5790
ec8df744
PE
5791 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5792 (gnutls_make_error): Rename local to avoid shadowing.
5793 (gnutls_emacs_global_deinit): ifdef out; not used.
5794 (Fgnutls_boot): Use const for pointer to readonly storage.
5795 Comment out unused local. Fix pointer signedness problems.
5796
640ee02d
PE
5797 * lread.c (openp): Don't stuff size_t into an 'int'.
5798 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5799 about possible signed overflow.
5800
6048fb2a
PE
5801 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5802 (GDK_KEY_g): Don't define if already defined.
5803 (xg_prepare_tooltip): Avoid pointer signedness problem.
5804 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5805
fa3c87e1
PE
5806 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5807 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5808
2172544b
PE
5809 * xfns.c (Fx_window_property): Simplify a bit,
5810 to make a bit faster and to avoid GCC 4.6.0 warning.
5811 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5812
9b821a21
PE
5813 * fns.c (internal_equal): Don't assume size_t fits in int.
5814
3c616cfa
PE
5815 * alloc.c (compact_small_strings): Tighten assertion a little.
5816
c2982e87
PE
5817 Replace pEd with more-general pI, and fix some printf arg casts.
5818 * lisp.h (pI): New macro, generalizing old pEd macro to other
5819 conversion specifiers. For example, use "...%"pI"d..." rather
5820 than "...%"pEd"...".
5821 (pEd): Remove. All uses replaced with similar uses of pI.
5822 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5823 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5824 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5825 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5826 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5827 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5828 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5829 64-bit hosts.
5830 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5831 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5832 * print.c (safe_debug_print, print_object): Likewise.
5833 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5834 to int.
6f04d126
PE
5835 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5836 avoiding the 0 flag, which is not portable.
c2982e87
PE
5837 * process.c (Fmake_network_process): Use pI to avoid cast.
5838 * region-cache.c (pp_cache): Likewise.
5839 * xdisp.c (decode_mode_spec): Likewise.
5840 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5841 behavior on 64-bit hosts with printf arg.
6f04d126 5842 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
5843 (x_stop_queuing_selection_requests): Likewise.
5844 (x_get_window_property): Don't truncate byte count to an 'int'
5845 when tracing.
0b432f21 5846
5e073ec7
PE
5847 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5848 here, since it parses constructs like leading '-' and spaces,
5849 which are not wanted; and it overflows with large numbers.
5850 Instead, simply match F[0-9]+, which is what is wanted anyway.
5851
36372bf9
PE
5852 * alloc.c: Remove unportable assumptions about struct layout.
5853 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5854 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5855 (allocate_vectorlike, make_pure_vector): Use the new macros,
5856 plus offsetof, to remove unportable assumptions about struct layout.
5857 These assumptions hold on all porting targets that I know of, but
5858 they are not guaranteed, they're easy to remove, and removing them
5859 makes further changes easier.
5860
0b432f21
PE
5861 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5862 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
5863 (string_overrun_cookie): Now const. Use initializers that
5864 don't formally overflow signed char, to avoid warnings.
000098c1
PE
5865 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5866 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
5867 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5868 multiple of sizeof (EMACS_INT); it need not be, if
5869 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 5870 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 5871
895009e1
JB
58722011-04-26 Juanma Barranquero <lekktu@gmail.com>
5873
5874 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5875
6a7a1b0b
TZ
58762011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5877
5878 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 5879 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
5880 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5881
841a1577 58822011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
5883
5884 * lisp.h (Qdebug): List symbol.
895009e1 5885 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
5886 * keyboard.c (debug-on-event): New variable.
5887 (handle_user_signal): Break into debugger when debug-on-event
5888 matches the current signal symbol.
5889
f2d3ba6f
DN
58902011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5891
5892 * alloc.c (check_sblock, check_string_bytes)
5893 (check_string_free_list): Convert to standard C.
5894
42ce4c63
TZ
58952011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5896
5897 * w32.c (emacs_gnutls_push): Fix typo.
5898
825cd63c
EZ
58992011-04-25 Eli Zaretskii <eliz@gnu.org>
5900
fb11d64d
EZ
5901 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5902 "cast to pointer from integer of different size".
5903
825cd63c
EZ
5904 Improve doprnt and its use in verror. (Bug#8545)
5905 * doprnt.c (doprnt): Document the set of format control sequences
5906 supported by the function. Use SAFE_ALLOCA instead of always
5907 using `alloca'.
5908
5909 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5910 is one byte too soon. Don't use xrealloc; instead xfree and
5911 xmalloc anew.
5912
e061a11b
TZ
59132011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5914
5915 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5916 callbacks stage.
5917
5918 * gnutls.c: Renamed global_initialized to
5919 gnutls_global_initialized. Added internals for the
5920 :verify-hostname-error, :verify-error, and :verify-flags
5921 parameters of `gnutls-boot' and documented those parameters in the
5922 docstring. Start callback support.
9173deec
JB
5923 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5924 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5925 on error. Return error code.
e061a11b
TZ
5926 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5927 (emacs_gnutls_read): Likewise.
5928 (Fgnutls_boot): Return handshake error code.
5929 (emacs_gnutls_handle_error): New function.
5930 (wsaerror_to_errno): Likewise.
5931
5932 * w32.h (emacs_gnutls_pull): Add prototype.
5933 (emacs_gnutls_push): Likewise.
5934
5935 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5936 (emacs_gnutls_push): Likewise.
5937
59382011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5939
5940 * process.c (wait_reading_process_output): Check if GnuTLS
5941 buffered some data internally if no FDs are set for TLS
5942 connections.
5943
5944 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5945 (LIBS): Link to USER_LIBS.
5946 ($(BLD)/gnutls.$(0)): New target.
5947
fa6996bc
EZ
59482011-04-24 Eli Zaretskii <eliz@gnu.org>
5949
eb35682e
EZ
5950 * xdisp.c (handle_single_display_spec): Rename the
5951 display_replaced_before_p argument into display_replaced_p, to
5952 make it consistent with the commentary. Fix typos in the
5953 commentary.
5954
e2ad650c
EZ
5955 * textprop.c (syms_of_textprop): Remove dead code.
5956 (copy_text_properties): Delete obsolete commentary about an
5957 interface that was deleted long ago. Fix typos in the description
5958 of arguments.
5959
1b2de274
EZ
5960 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5961 to changes in oldXMenu/XMenu.h from 2011-04-16.
5962 <menu_help_message, prev_menu_help_message>: Constify.
5963 (IT_menu_make_room): menu->help_text is now `const char **';
5964 adjust.
5965
5966 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5967 to changes in oldXMenu/XMenu.h from 2011-04-16.
5968 (struct XMenu): Declare `help_text' `const char **'.
5969
5970 * xfaces.c <Qunspecified>: Make extern again.
5971
5972 * syntax.c: Include sys/types.h before including regex.h, as
5973 required by Posix.
5974
762b15be
EZ
5975 * doc.c (get_doc_string): Improve the format passed to `error'.
5976
5977 * doprnt.c (doprnt): Improve commentary.
5978
5979 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5980
5981 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5982 them with etags.
5983
f1052e5d
EZ
5984 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5985 changes in globals.h immediately force recompilation.
762b15be
EZ
5986 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5987 $(CURDIR)/s/ms-w32.h.
5988 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 5989
fa6996bc
EZ
5990 * character.c (Fchar_direction): Function deleted.
5991 (syms_of_character): Don't defsubr it.
5992 <char-direction-table>: Deleted.
5993
e6c3da20
EZ
59942011-04-23 Eli Zaretskii <eliz@gnu.org>
5995
5996 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5997 * doprnt.c: Include limits.h.
5998 (SIZE_MAX): New macro.
04f2d78b
CB
5999 (doprnt): Return a size_t value. 2nd arg is now size_t.
6000 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
6001 Improve overflow protection. Support `l' modifier for integer
6002 conversions. Support %l conversion. Don't assume an EMACS_INT
6003 argument for integer conversions and for %c.
6004
6005 * lisp.h (doprnt): Restore prototype.
6006
6007 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6008 $(SRC)/character.h.
6009
6010 * Makefile.in (base_obj): Add back doprnt.o.
6011
6012 * deps.mk (doprnt.o): Add back prerequisites.
6013 (callint.o): Depend on character.h.
6014
6015 * eval.c (internal_lisp_condition_case): Include the handler
6016 representation in the error message.
6017 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6018 when breaking from the loop.
6019
6020 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6021
6022 * callint.c (Fcall_interactively): When displaying error message
6023 about invalid control letter, pass the character's codepoint, not
6024 a pointer to its multibyte form. Improve display of the character
6025 in octal and display also its hex code.
6026
6027 * character.c (char_string): Use %x to display the (unsigned)
6028 codepoint of an invalid character, to avoid displaying a bogus
6029 negative value.
6030
6031 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6032 `error', not SYMBOL_NAME itself.
6033
6034 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6035 character arguments to `error'.
6036
6037 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6038 to `error' in error message about FINAL_CHAR argument. Make sure
6039 FINAL_CHAR is a character, and use %c when it is passed as
6040 argument to `error'.
6041
4ffd0d6b 60422011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
6043
6044 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6045
6046 * w32.c: Include <time.h>.
6047 (sys_localtime): New function.
6048
4ffd0d6b 60492011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
6050
6051 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6052
4ffd0d6b 6053 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 6054
4ffd0d6b 60552011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 6056
4ffd0d6b
GM
6057 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6058 zombies (Bug#8467).
aac0c6e3 6059
04c56954
EZ
60602011-04-19 Eli Zaretskii <eliz@gnu.org>
6061
6062 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6063 gl_state.e_property when gl_state.object is Qt.
6064
6065 * insdel.c (make_gap_larger): Remove limitation of buffer size
6066 to <= INT_MAX.
6067
16a43933
CY
60682011-04-18 Chong Yidong <cyd@stupidchicken.com>
6069
6070 * xdisp.c (lookup_glyphless_char_display)
6071 (produce_glyphless_glyph): Handle cons cell entry in
6072 glyphless-char-display.
6073 (Vglyphless_char_display): Document it.
6074
6075 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6076 glyphless-char-display.
6077
4581706e
CY
60782011-04-17 Chong Yidong <cyd@stupidchicken.com>
6079
6080 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6081
6082 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6083
6084 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6085 definition for no-X builds.
6086
4887c6e2 60872011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 6088
fd35b6f9
PE
6089 Static checks with GCC 4.6.0 and non-default toolkits.
6090
5c1ccb01
PE
6091 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6092
006c5daa
PE
6093 * process.c (keyboard_bit_set): Define only if SIGIO.
6094 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6095 (send_process): Repair possible setjmp clobbering.
6096
efc736d3
PE
6097 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6098
4e2fe2e6
PE
6099 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6100
f97334a2
PE
6101 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6102
4e75f29d
PE
6103 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6104 Define only if needed.
6105
90efadd1
PE
6106 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6107 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 6108 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 6109
3c647824
PE
6110 * dispextern.h (struct redisplay_interface): Rename param
6111 to avoid shadowing.
e264f262 6112 * termhooks.h (struct terminal): Likewise.
761383f4 6113 * xterm.c (xembed_send_message): Likewise.
3c647824 6114
b58c5c4a
PE
6115 * insdel.c (make_gap_smaller): Define only if
6116 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6117
cad59032
PE
6118 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6119 it.
6120
c339dc2e
PE
6121 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6122 so that we aren't warned about unused symbols.
6123
91a3e27b
PE
6124 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6125
399c71d3 6126 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 6127
8ffc96f5
PE
6128 * xfns.c (x_real_positions): Mark locals as initialized.
6129
eef9bc79
PE
6130 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6131
098db9dd
PE
6132 * xterm.c: Fix problems found by static analysis with other toolkits.
6133 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
6134 (x_dispatch_event): Declare static if USE_GTK, and
6135 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 6136 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 6137 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
6138 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6139 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 6140
eb18f6cc
PE
6141 * xmenu.c (menu_help_callback): Pointer type fixes.
6142 Use const pointers when pointing at readonly data. Avoid pointer
6143 signedness clashes.
6144 (FALSE): Remove unused macro.
6145 (update_frame_menubar): Remove unused decl.
6146
1fe72bf8
PE
6147 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6148
60d9e1db
PE
6149 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6150 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6151 (single_menu_item): Rename local to avoid shadowing.
6152
39261c26
PE
6153 * keyboard.c (make_lispy_event): Remove unused local var.
6154
018c5e19
PE
6155 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6156 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6157
63d2b86e
PE
6158 * bitmaps: Change bitmaps from unsigned char back to the X11
6159 compatible char. Avoid the old compiler warnings about
6160 out-of-range initializers by using, for example, '\xab' rather
6161 than 0xab.
6162
aefd87e1
PE
6163 * xgselect.c (xgselect_initialize): Check vs interface
6164 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6165
bf501fb9
PE
6166 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6167
e9829fdf
PE
6168 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6169 to read-only memory.
6170
1086c095
PE
6171 * fns.c (vector): Remove; this old hack is no longer needed.
6172
2baccd04 6173 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 6174 Remove unused var.
dde42981 6175 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 6176
72391843 6177 * xrdb.c (x_load_resources): Omit unused local.
3565b346 6178
436c16df 6179 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 6180 (x_window): Rename locals to avoid shadowing.
dc5ddd85 6181 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 6182
92bb796d 6183 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 6184 (x_term_init): Remove local to avoid shadowing.
92bb796d 6185
764430a3 6186 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
6187
6188 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6189 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6190
d1dfb56c
EZ
61912011-04-16 Eli Zaretskii <eliz@gnu.org>
6192
c4354cb4
EZ
6193 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6194
d1dfb56c
EZ
6195 Fix regex.c, syntax.c and friends for buffers > 2GB.
6196 * syntax.h (struct gl_state_s): Declare character position members
6197 EMACS_INT.
6198
6199 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6200
04f2d78b
CB
6201 * textprop.c (verify_interval_modification, interval_of):
6202 Declare arguments EMACS_INT.
d1dfb56c
EZ
6203
6204 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6205 EMACS_INT.
6206
6207 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6208
6209 * indent.c (Fvertical_motion): Local variable it_start is now
6210 EMACS_INT.
6211
6212 * regex.c (re_match, re_match_2, re_match_2_internal)
6213 (bcmp_translate, regcomp, regexec, print_double_string)
6214 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6215 (re_compile_pattern, re_exec): Declare arguments and local
6216 variables `size_t' and `ssize_t' and return values `regoff_t', as
6217 appropriate.
6218 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6219 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6220 <compile_stack_type>: `size' and `avail' are now `size_t'.
6221
6222 * regex.h <regoff_t>: Use ssize_t, not int.
6223 (re_search, re_search_2, re_match, re_match_2): Arguments that
6224 specify buffer/string position and length are now ssize_t and
6225 size_t. Return type is regoff_t.
6226
613052cd
BK
62272011-04-16 Ben Key <bkey76@gmail.com>
6228
6229 * nsfont.m: Fixed bugs in ns_get_family and
6230 ns_descriptor_to_entity that were caused by using free to
6231 deallocate memory blocks that were allocated by xmalloc (via
6232 xstrdup). This caused Emacs to crash when compiled with
6233 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6234 --enable-checking=xmallocoverrun). xfree is now used to
6235 deallocate these memory blocks.
6236
4170f62f 62372011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 6238
71b41406
PE
6239 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6240
9587a89d
PE
6241 emacs_write: Accept and return EMACS_INT for sizes.
6242 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6243 et seq.
6244 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6245 Accept and return EMACS_INT.
6246 (emacs_gnutls_write): Return the number of bytes written on
6247 partial writes.
6248 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
6249 (emacs_read, emacs_write): Remove check for negative size, as the
6250 Emacs source code has been audited now.
9587a89d
PE
6251 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6252 (emacs_read, emacs_write): Use it.
273a5f82
PE
6253 * process.c (send_process): Adjust to the new signatures of
6254 emacs_write and emacs_gnutls_write. Do not attempt to store
6255 a byte offset into an 'int'; it might overflow.
9587a89d 6256 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 6257
3e047f51
PE
6258 * sound.c: Don't assume sizes fit in 'int'.
6259 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 6260 Return EMACS_INT, not int.
3e047f51 6261 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
6262 Accept EMACS_INT, not int.
6263 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
6264 record read return values.
6265
cc39a9db
BK
62662011-04-15 Ben Key <bkey76@gmail.com>
6267
c9d0ec6d
JB
6268 * keyboard.c (Qundefined): Don't declare static since it is used
6269 in nsfns.m.
6270 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6271 static since they are used in nsfont.m.
cc39a9db 6272
6c60eb9f
SM
62732011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6274
6275 * process.c (Qprocessp): Don't declare static.
6276 * lisp.h (Qprocessp): Declare again.
6277
7990b61a
JB
62782011-04-15 Juanma Barranquero <lekktu@gmail.com>
6279
6280 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6281
5d4cb038
PE
62822011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6283
8bd7b830 6284 Improve C-level modularity by making more things 'static'.
cd64ea1d 6285
e3b27b31
PE
6286 Don't publish debugger-only interfaces to other modules.
6287 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6288 (verify_bytepos, count_markers): Move decls to the only modules
6289 that need them.
6290 * region-cache.h (pp_cache): Likewise.
6291 * window.h (check_all_windows): Likewise.
6292 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6293
5d4cb038
PE
6294 * sysdep.c (croak): Now static, if
6295 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6296 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
6297
6298 * alloc.c (refill_memory_reserve): Now static if
6299 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6300 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 6301
e87b6180
PE
6302 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6303 Define only if USE_LUCID.
6304
ac64929e
PE
6305 * xrdb.c (x_customization_string, x_rm_string): Now static.
6306
6f37259d
PE
6307 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6308 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6309
1683e3ab
PE
6310 * xdisp.c (draw_row_with_mouse_face): Now static.
6311 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6312
de9c2632
PE
6313 * window.h (check_all_windows): Mark externally visible.
6314
2b96acb7
PE
6315 * window.c (window_deletion_count): Now static.
6316
6317 * undo.c: Make symbols static if they're not exported.
6318 (last_undo_buffer, last_boundary_position, pending_boundary):
6319 Now static.
6320
50436f33
PE
6321 * textprop.c (interval_insert_behind_hooks): Now static.
6322 (interval_insert_in_front_hooks): Likewise.
6323
64520e5c
PE
6324 * term.c: Make symbols static if they're not exported.
6325 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6326 (max_frame_lines, tty_set_terminal_modes):
6327 (tty_reset_terminal_modes, tty_turn_off_highlight):
6328 (get_tty_terminal): Now static.
6329 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6330 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 6331 HAVE_WINDOW_SYSTEM.
64520e5c
PE
6332 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6333 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6334
1fa53021
PE
6335 * sysdep.c: Make symbols static if they're not exported.
6336 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6337 Now static.
6338 (sigprocmask_set, full_mask): Remove; unused.
6339 (wait_debugging): Mark as visible.
6340 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6341 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6342
d4b43b22
PE
6343 * syntax.c (syntax_temp): Define only if !__GNUC__.
6344
b7c513d0
PE
6345 * sound.c (current_sound_device, current_sound): Now static.
6346
989b29ad
PE
6347 * search.c (searchbufs, searchbuf_head): Now static.
6348
13a55a78
PE
6349 * scroll.c (scroll_cost): Remove; unused.
6350 * dispextern.h (scroll_cost): Remove decl.
6351
de68a1fc
PE
6352 * region-cache.h (pp_cache): Mark as externally visible.
6353
40ccffa6
PE
6354 * process.c: Make symbols static if they're not exported.
6355 (process_tick, update_tick, create_process, chan_process):
6356 (Vprocess_alist, proc_buffered_char, datagram_access):
6357 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6358 (deactivate_process): Mark defn as static, as well as decl.
6359 * lisp.h (create_process): Remove decl.
6360 * process.h (chan_process, Vprocess_alist): Remove decls.
6361
ad64fc97
PE
6362 * print.c: Make symbols static if they're not exported.
6363 (print_depth, new_backquote_output, being_printed, print_buffer):
6364 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6365 (print_interval, print_number_index, initial_stderr_stream):
6366 Now static.
6367 * lisp.h (Fprinc): Remove decl.
6368 (debug_output_compilation_hack): Mark as externally visible.
6369
adddb265
PE
6370 * sysdep.c (croak): Move decl from here to syssignal.h.
6371 * syssignal.h (croak): Put it here, so the API can be checked when
6372 'croak' is called from dissociate_if_controlling_tty.
6373
1717ede2
PE
6374 * minibuf.c: Make symbols static if they're not exported.
6375 (minibuf_save_list, choose_minibuf_frame): Now static.
6376 * lisp.h (choose_minibuf_frame): Remove decl.
6377
fa5fb2bc
PE
6378 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6379
1e3890d1
PE
6380 * lread.c: Make symbols static if they're not exported.
6381 (read_objects, initial_obarray, oblookup_last_bucket_number):
6382 Now static.
6383 (make_symbol): Remove; unused.
6384 * lisp.h (initial_obarray, make_symbol): Remove decls.
6385
8a1414fa
PE
6386 * keyboard.c: Make symbols static if they're not exported.
6387 (single_kboard, recent_keys_index, total_keys, recent_keys):
6388 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6389 (this_single_command_key_start, echoing, last_auto_save):
6390 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6391 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6392 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6393 (Vlispy_mouse_stem, double_click_count):
6394 Now static.
6395 (force_auto_save_soon): Define only if SIGDANGER.
6396 (ignore_mouse_drag_p): Now static if
6397 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6398 (print_help): Remove; unused.
6399 (stop_character, last_timer_event): Mark as externally visible.
6400 * keyboard.h (ignore_mouse_drag_p): Declare only if
6401 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6402 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6403 * lisp.h (echoing): Remove decl.
6404 (force_auto_save_soon): Declare only if SIGDANGER.
6405 * xdisp.c (redisplay_window): Simplify code, to make it more
6406 obvious that ignore_mouse_drag_p is not accessed if !defined
6407 USE_GTK && !defined HAVE_NS.
6408
93ea6e8f
PE
6409 * intervals.c: Make symbols static if they're not exported.
6410 (merge_properties_sticky, merge_interval_right, delete_interval):
6411 Now static.
6412 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6413
77382fcc
PE
6414 * insdel.c: Make symbols static if they're not exported.
6415 However, leave prepare_to_modify_buffer alone. It's never
6416 called from outside this function, but that appears to be a bug.
6417 (combine_after_change_list, combine_after_change_buffer):
4889fc82 6418 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
6419 (adjust_after_replace_noundo): Remove; unused.
6420 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 6421 (signal_before_change): Remove decls.
77382fcc 6422
9306c32e
PE
6423 * indent.c (val_compute_motion, val_vmotion): Now static.
6424
cd44d2eb
PE
6425 * image.c: Make symbols static if they're not exported.
6426 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6427 if USE_GTK.
6428 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6429 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6430
ad9a7a06
PE
6431 * fringe.c (standard_bitmaps): Now static.
6432 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6433
81626931
PE
6434 * frame.c: Make symbols static if they're not exported.
6435 (x_report_frame_params, make_terminal_frame): Now static.
6436 (get_frame_param): Now static, unless HAVE_NS.
6437 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6438 (x_get_resource_string): Remove; not used.
6439 * frame.h (make_terminal_frame, x_report_frame_params):
6440 (x_get_resource_string); Remove decls.
6441 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6442 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6443
239f9db9
PE
6444 * font.c, fontset.c: Make symbols static if they're not exported.
6445 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6446 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6447 * font.c (font_close_object): Now static.
6448 * font.h (font_close_object): Remove.
6449 * fontset.c (FONTSET_OBJLIST): Remove.
6450 (free_realized_fontset) #if-0 the body, which does nothing.
6451 (face_suitable_for_char_p): #if-0, as it's never called.
6452 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
6453 * xfaces.c (face_at_string_position):
6454 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
6455 since 0 is always ASCII.
6456
dfcf3579
PE
6457 * fns.c (weak_hash_tables): Now static.
6458
5045092b
PE
6459 * fileio.c: Make symbols static if they're not exported.
6460 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6461 (Vwrite_region_annotation_buffers): Now static.
6462
57a96f5c
PE
6463 * eval.c: Make symbols static if they're not exported.
6464 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6465 * lisp.h (backtrace_list): Remove decl.
6466
35f08c38
PE
6467 * emacs.c: Make symbols static if they're not exported.
6468 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6469 (fatal_error_code, fatal_error_signal_hook, standard_args):
6470 Now static.
6471 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6472 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6473 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6474 * lisp.h (fatal_error_signal_hook): Remove decl.
6475 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6476
f44bd759
PE
6477 * editfns.c: Move a (normally-unused) function to its only use.
6478 * editfns.c, lisp.h (get_operating_system_release): Remove.
6479 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6480 worth the hassle of breaking this out.
6481
b532497d
PE
6482 * xterm.c: Make symbols static if they're not exported.
6483 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6484 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6485 (x_destroy_window, x_delete_display):
6486 Now static.
6487 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6488 (x_mouse_leave): Remove; unused.
6489 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6490 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6491 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6492 Remove decls.
6493 (x_mouse_leave): Declare only if WINDOWSNT.
6494 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6495 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6496 USE_X_TOOLKIT.
6497
1675728f
PE
6498 * ftxfont.c: Make symbols static if they're not exported.
6499 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6500 HAVE_FREETYPE.
6501 * font.h (ftxfont_driver): Likewise.
6502
e4cebfca
PE
6503 * xfns.c: Make symbols static if they're not exported.
6504 (x_last_font_name, x_display_info_for_name):
6505 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6506 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6507 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6508 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6509 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6510 (last_show_tip_args): Now static.
6511 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6512 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6513 (x_screen_planes): Remove; unused.
6514 * dispextern.h (x_screen_planes): Remove decl.
6515
5bf46f05
PE
6516 * dispnew.c: Make symbols static if they're not exported.
6517 * dispextern.h (redraw_garbaged_frames, scrolling):
6518 (increment_row_positions): Remove.
6519 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6520 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6521 Now static.
6522 (redraw_garbaged_frames): Remove; unused.
6523
435f4c28
PE
6524 * xfaces.c: Make symbols static if they're not exported.
6525 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6526 Remove decls.
6527 * xterm.h (defined_color): Remove decls.
6528 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6529 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6530 (menu_face_changed_default, defined_color, free_realized_face):
6531 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6532 (ascii_face_of_lisp_face): Remove; unused.
6533
8524aef3
PE
6534 * xdisp.c: Make symbols static if they're not exported.
6535 * dispextern.h (scratch_glyph_row, window_box_edges):
6536 (glyph_to_pixel_coords, set_cursor_from_row):
6537 (get_next_display_element, set_iterator_to_next):
6538 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6539 (show_mouse_face): Remove decls
6540 * frame.h (message_buf_print): Likewise.
6541 * lisp.h (pop_message, set_message, check_point_in_composition):
6542 Likewise.
6543 * xterm.h (set_vertical_scroll_bar): Likewise.
6544 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6545 (message_buf_print, scratch_glyph_row, displayed_buffer):
6546 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6547 (get_next_display_element, show_mouse_face, window_box_edges):
6548 (frame_to_window_pixel_xy, check_point_in_composition):
6549 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6550 (glyph_to_pixel_coords): Remove; unused.
6551
16390cd2
PE
6552 * dired.c (file_name_completion): Now static.
6553
6554 * dbusbind.c (xd_in_read_queued_messages): Now static.
6555
a25f4dfa
PE
6556 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6557 * data.c (circular_list_error): Remove.
6558
14a9c8df
PE
6559 * commands.h (last_point_position, last_point_position_buffer):
6560 (last_point_position_window): Remove decls.
6561 * keyboard.c: Make these variables static.
6562
04f2d78b
CB
6563 * coding.h (coding, code_convert_region, encode_coding_gap):
6564 Remove decls.
74ab6df5
PE
6565 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6566 (iso_code_class, detect_coding, code_convert_region): Now static.
6567 (encode_coding_gap): Remove; unused.
6568
38dfbee1
PE
6569 * chartab.c (chartab_chars, chartab_bits): Now static.
6570
a2cb4e63
PE
6571 * charset.h (charset_iso_8859_1): Remove decl.
6572 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6573 Now static.
6574
127198fd
PE
6575 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6576 * ccl.c (Vccl_program_table): Now static.
6577 (check_ccl_update): Remove; unused.
6578
d85b608f
PE
6579 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6580 * category.h: ... from here.
6581 * category.c (check_category_table, set_category_set): Now static.
6582
31cd66f3
PE
6583 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6584 * lisp.h: Remove these decls.
6585
c358e587
PE
6586 * buffer.c (buffer_count): Remove unused var.
6587
e78aecca
PE
6588 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6589 so that it's not optimized away.
6590 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6591 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6592 exported only to the debugger.
6593
e192d7d3 6594 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 6595 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 6596
92470028
PE
6597 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6598 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6599 was inaccessible from Lisp.
6600 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6601 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6602
244ed907
PE
6603 alloc.c: Import and export fewer symbols, and remove unused items.
6604 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6605 is defined.
6606 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6607 it's not optimized away by whole-program optimization.
6608 (message_enable_multibyte, free_misc): Remove.
6609 (catchlist, handlerlist, mark_backtrace):
6610 Declare only if BYTE_MARK_STACK.
6611 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6612 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6613 (message_enable_multibyte): Remove decl.
6614 (free_misc, interval_free_list, float_block, float_block_index):
6615 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6616 (cons_free_list, last_marked_index):
6617 Now static.
6618 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6619 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6620 (mark_backtrace): Define only if BYTE_MARK_STACK.
6621 * xdisp.c (message_enable_multibyte): Now static.
6622
61c2b50e 6623 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
6624 This makes it easier for human readers (and static analyzers)
6625 to see whether these variables are used from other modules.
6626 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6627 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6628 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6629 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6630 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6631 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6632 * xmenu.c, xselect.c:
6633 Declare Q* vars static if they are not used in other modules.
6634 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6635 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6636 Remove decls of unexported vars.
6637 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6638
95c82688
PE
6639 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6640
16a97296
PE
6641 Make Emacs functions such as Fatom 'static' by default.
6642 This makes it easier for human readers (and static analyzers)
6643 to see whether these functions can be called from other modules.
6644 DEFUN now defines a static function. To make the function external
6645 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
6646 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6647 (Finit_image_library):
16a97296
PE
6648 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6649 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6650 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6651 Remove decls, since these functions are now static.
6652 (Funintern, Fget_internal_run_time): New decls, since these functions
6653 were already external.
95c82688 6654
16a97296
PE
6655 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6656 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6657 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6658 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6659 * keyboard.c, keymap.c, lread.c:
6660 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6661 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6662 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6663 Mark functions with DEFUE instead of DEFUN,
6664 if they are used in other modules.
6665 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6666 decls for now-static functions.
6667 * buffer.h (Fdelete_overlay): Remove decl.
6668 * callproc.c (Fgetenv_internal): Mark as internal.
6669 * composite.c (Fremove_list_of_text_properties): Remove decl.
6670 (Fcomposition_get_gstring): New forward static decl.
6671 * composite.h (Fcomposite_get_gstring): Remove decl.
6672 * dired.c (Ffile_attributes): New forward static decl.
6673 * doc.c (Fdocumntation_property): New forward static decl.
6674 * eval.c (Ffetch_bytecode): New forward static decl.
6675 (Funintern): Remove extern decl; now in .h file where it belongs.
6676 * fileio.c (Fmake_symbolic_link): New forward static decl.
6677 * image.c (Finit_image_library): New forward static decl.
6678 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6679 * intervals.h (Fprevious_property_change):
6680 (Fremove_list_of_text_properties): Remove decls.
6681 * keyboard.c (Fthis_command_keys): Remove decl.
6682 (Fcommand_execute): New forward static decl.
6683 * keymap.c (Flookup_key): New forward static decl.
6684 (Fcopy_keymap): Now static.
6685 * keymap.h (Flookup_key): Remove decl.
6686 * process.c (Fget_process): New forward static decl.
6687 (Fprocess_datagram_address): Mark as internal.
6688 * syntax.c (Fsyntax_table_p): New forward static decl.
6689 (skip_chars): Remove duplicate decl.
6690 * textprop.c (Fprevious_property_change): New forward static decl.
6691 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6692 Now internal.
6693 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6694 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6695
785bbd42
PE
6696 * editfns.c (Fformat): Remove unreachable code.
6697
8b913b57
AS
66982011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6699
6700 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6701 change. (Bug#8496)
6702
a6744a35
EZ
67032011-04-13 Eli Zaretskii <eliz@gnu.org>
6704
6705 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6706 when at ZV. (Bug#8487)
6707
e7974947
AS
67082011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6709
baad03f0
AS
6710 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6711 (Bug#8437)
6712 * keyboard.c (parse_tool_bar_item): Likewise.
6713 * sound.c (sound_cleanup, alsa_close): Likewise.
6714 * termcap.c (tgetent): Likewise.
6715 * xfns.c (x_default_font_parameter): Likewise.
6716 * xsettings.c (read_and_apply_settings): Likewise.
6717
e7974947
AS
6718 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6719 (overrun_check_free): Protoize.
6720
28272684
PE
67212011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6722
6723 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6724 since callers should never pass a negative size.
6725 Change the signature to match that of plain 'read' and 'write'; see
6726 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6727 * lisp.h: Update prototypes of emacs_write and emacs_read.
6728
11997c76
EZ
67292011-04-11 Eli Zaretskii <eliz@gnu.org>
6730
6731 * xdisp.c (redisplay_window): Don't try to determine the character
6732 position of the scroll margin if the window start point w->startp
e896f03c 6733 is outside the buffer's accessible region. (Bug#8468)
11997c76 6734
8a2cbd72
EZ
67352011-04-10 Eli Zaretskii <eliz@gnu.org>
6736
6737 Fix write-region and its subroutines for buffers > 2GB.
6738 * fileio.c (a_write, e_write): Modify declaration of arguments and
6739 local variables to support buffers larger than 2GB.
6740 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6741
6742 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6743 argument, local variables, and return value.
6744
6745 * lisp.h: Update prototypes of emacs_write and emacs_read.
6746
6747 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6748
4073e537 67492011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 6750
1ebfdcb6
PE
6751 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6752
b2ded58d
PE
6753 Fix more problems found by GCC 4.6.0's static checks.
6754
7d66342c
PE
6755 * xdisp.c (vmessage): Use a better test for character truncation.
6756
bbf47d44
PE
6757 * charset.c (load_charset_map): <, not <=, for optimization,
6758 and to avoid potential problems with integer overflow.
9248994d 6759 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 6760 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 6761 * editfns.c (Fformat): Likewise.
1e69125e 6762 * syntax.c (skip_chars): Likewise.
3befa583 6763
e3019616
PE
6764 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6765 This also lets GCC 4.6.0 generate slightly better loop code.
6766
becfa255
PE
6767 * callint.c (Fcall_interactively): <, not <=, for optimization.
6768 (Fcall_interactively): Count the number of arguments produced,
6769 not the number of arguments given. This is simpler and lets GCC
6770 4.6.0 generate slightly better code.
6771
dae0cd48
PE
6772 * ftfont.c: Distingish more carefully between FcChar8 and char.
6773 The previous code passed unsigned char * to a functions like
6774 strlen and xstrcasecmp that expect char *, which does not
6775 conform to the C standard.
6776 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6777 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6778 char * when the C standard requires it.
6779
76032d70
PE
6780 * keyboard.c (read_char): Remove unused var.
6781
eb3f1cc8
PE
6782 * eval.c: Port to Windows vsnprintf (Bug#8435).
6783 Include <limits.h>.
6784 (SIZE_MAX): Define if the headers do not.
6785 (verror): Do not give up if vsnprintf returns a negative count.
6786 Instead, grow the buffer. This ports to Windows vsnprintf, which
6787 does not conform to C99. Problem reported by Eli Zaretskii.
6788 Also, simplify the allocation scheme, by avoiding the need for
6789 calling realloc, and removing the ALLOCATED variable.
6790
70476b54
PE
6791 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6792
12020a9e
PE
6793 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6794 But keep the doprint source code for now, as we might revamp it
6795 and use it again (Bug#8435).
ea6c7ae6
PE
6796 * lisp.h (doprnt): Remove.
6797 * Makefile.in (base_obj): Remove doprnt.o.
6798 * deps.mk (doprnt.o): Remove.
6799
5fdb398c
PE
6800 error: Print 32- and 64-bit integers portably (Bug#8435).
6801 Without this change, on typical 64-bit hosts error ("...%d...", N)
6802 was used to print both 32- and 64-bit integers N, which relied on
6803 undefined behavior.
6804 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6805 New macro.
6806 * lisp.h (error, verror): Mark as printf-like functions.
6807 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6808 Report overflow in size calculations when allocating printf buffer.
6809 Do not truncate output string at its first null byte.
6810 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6811 Truncate the output at a character boundary, since vsnprintf does not
6812 do that.
6813 * charset.c (check_iso_charset_parameter): Convert internal
6814 character to string before calling 'error', since %c now has the
6815 printf meaning.
6816 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6817 overflow when computing char to be passed to 'error'. Do not
6818 pass Lisp_Object to 'error'; pass the integer instead.
6819 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6820 formatted with plain %d.
6821
b189fa66
PE
6822 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6823
bff87ef0
PE
6824 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6825
7e2cac20
PE
6826 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6827
ce4d90b5
PE
6828 * xterm.c (x_catch_errors): Remove duplicate declaration.
6829
266c9547
PE
6830 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6831
79c49ad2
PE
6832 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6833
368f4090
JM
68342011-04-10 Jim Meyering <meyering@redhat.com>
6835
6836 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6837 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6838 return ssize_t not "int", and use size_t as the buffer length.
6839 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6840 * gnutls.h: Update declarations.
6841 * process.c (read_process_output): Use ssize_t, to match.
6842 (send_process): Likewise.
6843
a32d4040
CY
68442011-04-09 Chong Yidong <cyd@stupidchicken.com>
6845
6846 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6847
8546720e 68482011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 6849
04f2d78b
CB
6850 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6851 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 6852
8546720e
GM
6853 * xterm.c (handle_one_xevent):
6854 * xmenu.c (create_and_show_popup_menu):
6855 * xselect.c (x_decline_selection_request)
6856 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 6857
0a2f5c1a 68582011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
6859
6860 Fix some uses of `int' instead of EMACS_INT.
6861 * search.c (string_match_1, fast_string_match)
6862 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6863 (scan_buffer, find_next_newline_no_quit)
6864 (find_before_next_newline, search_command, Freplace_match)
6865 (Fmatch_data): Make some `int' variables be EMACS_INT.
6866
6867 * xdisp.c (display_count_lines): 3rd argument and return value now
6868 EMACS_INT. All callers changed.
6869 (pint2hrstr): Last argument is now EMACS_INT.
6870
6871 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6872 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6873 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6874 (decode_coding_utf_16, decode_coding_emacs_mule)
6875 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6876 (decode_coding_ccl, decode_coding_charset)
6877 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6878 (decode_coding_iso_2022, decode_coding_emacs_mule)
6879 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6880 <char_offset, last_offset>: Declare EMACS_INT.
6881 (encode_coding_utf_8, encode_coding_utf_16)
6882 (encode_coding_emacs_mule, encode_invocation_designation)
6883 (encode_designation_at_bol, encode_coding_iso_2022)
6884 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6885 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6886 Declare EMACS_INT.
6887 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6888 (encode_invocation_designation): Last argument P_NCHARS is now
6889 EMACS_INT.
6890 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6891 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6892
6893 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6894 All users changed.
6895
6896 * ccl.c (Fccl_execute_on_string): Declare some variables
6897 EMACS_INT.
6898
8546720e 68992011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
6900
6901 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6902
4e19a977
CS
69032011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6904
6905 * process.c (Fformat_network_address): Doc fix.
6906
87302331
R
69072011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6908
6909 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6910
cbb59342
CY
69112011-04-08 Chong Yidong <cyd@stupidchicken.com>
6912
6913 * keyboard.c (read_char): Call Lisp function help-form-show,
6914 instead of using internal_with_output_to_temp_buffer.
6915 (Qhelp_form_show): New var.
e0d38eeb 6916 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
6917
6918 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6919
6920 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6921
e67a13ab
CY
69222011-04-06 Chong Yidong <cyd@stupidchicken.com>
6923
04f2d78b
CB
6924 * process.c (Flist_processes): Remove to Lisp.
6925 (list_processes_1): Delete.
e67a13ab 6926
973f782d
EZ
69272011-04-06 Eli Zaretskii <eliz@gnu.org>
6928
7c106b1e
EZ
6929 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6930
973f782d
EZ
6931 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6932
41cf7d1a 69332011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 6934
ca23cc88
PE
6935 Fix more problems found by GCC 4.6.0's static checks.
6936
f390e2d5
PE
6937 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6938
42eea0d0
PE
6939 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6940
b69769da 6941 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 6942
f9541e84
PE
6943 * xdisp.c (vmessage): Mark as a printf-like function.
6944
13841b55
PE
6945 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6946
c136c10f
PE
6947 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6948
5e2d4a30
PE
6949 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6950 printf-like functions.
6951 (tiff_load): Add casts to remove these marks before passing them
6952 to system-supplied API.
6953
583f48b9
PE
6954 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6955
b25d760e
PE
6956 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6957 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
6958 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6959 directly, rather than having caller test rule sign. This avoids
6960 some unnecessary tests.
6961 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6962 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6963 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 6964
bc7b6697 6965 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 6966 (xfont_open): Avoid unnecessary tests.
bc7b6697 6967
27ccc379
PE
6968 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6969
dcd5c89a
PE
6970 * composite.h, composite.c (composition_gstring_put_cache):
6971 Use EMACS_INT, not int, for length.
6972
b13a45c6
PE
6973 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6974 breaking out part of COMPOSITION_DECODE_RULE.
6975 (COMPOSITION_DECODE_RULE): Use it.
6976 * composite.c (get_composition_id): Remove unused local vars,
6977 by using the new macro.
6978
1e792e4d
PE
6979 * textprop.c (set_text_properties_1): Change while to do-while,
6980 since the condition is always true at first.
6981
dc6c6455 6982 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
6983 (interval_deletion_adjustment): Return unsigned value.
6984 All uses changed.
dc6c6455 6985
aba7731a
PE
6986 * process.c (list_processes_1, create_pty, read_process_output):
6987 (exec_sentinel): Remove vars that were set but not used.
afd4052b 6988 (create_pty): Remove unnecessary "volatile"s.
bc57d757 6989 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 6990 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 6991 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 6992
fdfc4bf3
PE
6993 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6994
fca8fe46 6995 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 6996 (update_syntax_table): Use unsigned instead of int.
fca8fe46 6997
06a0259a 6998 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 6999 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 7000 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 7001
e7b9e80f
PE
7002 * print.c (print_error_message): Avoid int overflow.
7003
56201685
PE
7004 * font.c (font_list_entities): Redo for clarity,
7005 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7006
78834453 7007 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 7008 (font_score): Avoid potential overflow in diff calculation.
78834453 7009
0bc0b309 7010 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 7011 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 7012
e610eaca
PE
7013 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7014
b895abce
PE
7015 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7016 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7017 can always succeed if overflow has undefined behavior.
7018
1f1d9321 7019 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 7020 (wordify): Omit three unnecessary tests.
1f1d9321 7021
c59478bc
PE
7022 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7023 All callers changed. This avoids the need for an unused var.
7024
79b73827
PE
7025 * casefiddle.c (casify_region): Remove var that is set but not used.
7026
a4db5dfe
PE
7027 * dired.c (file_name_completion): Remove var that is set but not used.
7028
43aae36e
PE
7029 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7030
2a47c44d 7031 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 7032 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 7033
a37c69bf
PE
7034 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7035 Check for integer overflow on size calculations.
7036
328ab8e7
PE
7037 * buffer.c (Fprevious_overlay_change): Remove var that is set
7038 but not used.
7039
e5a2a5cb
PE
7040 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7041 Remove vars that are set but not used.
8d84a6eb 7042 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 7043 (timer_check_2): Mark vars as initialized.
e5a2a5cb 7044
a60e5f68
PE
7045 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7046
f661cb61 7047 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 7048 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 7049
f0397f5a
PE
7050 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7051 that are set but not used.
7052
8664db06 7053 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 7054 if XCreateBitmapFromData fails (Bug#8410).
8664db06 7055
6abdaa4a
PE
7056 * xselect.c (x_get_local_selection, x_handle_property_notify):
7057 Remove vars that are set but not used.
7058
0ce7538d 7059 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 7060 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 7061
9ae848fc
PE
7062 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7063 Remove var that is set but not used.
0b918413
PE
7064 (scroll_bar_windows_size): Now size_t, not int.
7065 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7066 Check for overflow.
9ae848fc 7067
a5a62657
PE
7068 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7069 (map_tty_color) [!defined MSDOS]: Likewise.
7070
5c5cdd39
PE
7071 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7072
66ebf983
PE
7073 * coding.c: Remove vars that are set but not used.
7074 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7075 All callers changed.
7076 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7077 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7078 (decode_coding_charset): Remove vars that are set but not used.
7079
1be4d761
PE
7080 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7081 that is set but not used.
7082
47553fa8
PE
7083 * print.c (print_object): Remove var that is set but not used.
7084
1f7196bf 7085 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
7086 The gnulib version avoids calling malloc in the usual case,
7087 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7088 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7089 * filelock.c (current_lock_owner): Likewise.
7090 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7091 * sysdep.c: Include allocator.h, careadlinkat.h.
7092 (emacs_no_realloc_allocator): New static constant.
7093 (emacs_readlink): New function.
fdb61804
PE
7094 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7095 ../lib/careadlinkat.h.
d1fdcab7 7096
f84c17c7
SM
70972011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7098
7099 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7100 first non-nil return value).
7101
ef3862ad
JD
71022011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7103
7104 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7105 if not defined (Bug#8403).
7106
376a7006
JB
71072011-04-02 Juanma Barranquero <lekktu@gmail.com>
7108
7109 * xdisp.c (display_count_lines): Remove parameter `start',
7110 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7111 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7112 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7113 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7114 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7115 and thereabouts. All callers changed.
7116 (get_per_char_metric): Remove parameter `f', unused since
7117 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7118
6ca3801d
JM
71192011-04-02 Jim Meyering <meyering@redhat.com>
7120
7121 do not dereference NULL upon failed strdup
7122 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7123 (ns_get_family): Likewise.
7124
d8e2b5ba
JB
71252011-04-02 Juanma Barranquero <lekktu@gmail.com>
7126
7127 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7128
8c74fcbd
JD
71292011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7130
7131 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7132 later (Bug#8403).
7133
7200d79c
SM
71342011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7135
03408648 7136 Add lexical binding.
7200d79c 7137
03408648
SM
7138 * window.c (Ftemp_output_buffer_show): New fun.
7139 (Fsave_window_excursion):
7140 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7141
7142 * lread.c (lisp_file_lexically_bound_p): New function.
7143 (Fload): Bind Qlexical_binding.
7144 (readevalloop): Remove `evalfun' arg.
7145 Bind Qinternal_interpreter_environment.
7146 (Feval_buffer): Bind Qlexical_binding.
7147 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7148 Mark as dynamic.
7149 (syms_of_lread): Declare `lexical-binding'.
7150
7151 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7152
7153 * keyboard.c (eval_dyn): New fun.
7154 (menu_item_eval_property): Use it.
ca105506
SM
7155
7156 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 7157
03408648
SM
7158 * fns.c (concat, mapcar1): Accept byte-code-functions.
7159
7160 * eval.c (Fsetq): Handle lexical vars.
7161 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7162 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7163 (FletX, Flet): Obey lexical binding.
7164 (Fcommandp): Handle closures.
7165 (Feval): New `lexical' arg.
7166 (eval_sub): New function extracted from Feval. Use it almost
7167 everywhere where Feval was used. Look up vars in lexical env.
7168 Handle closures.
7169 (Ffunctionp): Move from subr.el.
7170 (Ffuncall): Handle closures.
7171 (apply_lambda): Remove `eval_flags'.
7172 (funcall_lambda): Handle closures and new byte-code-functions.
7173 (Fspecial_variable_p): New function.
7174 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7175 but without exporting it to Lisp.
23aba0ea 7176
23aba0ea 7177 * doc.c (Fdocumentation, store_function_docstring):
03408648 7178 * data.c (Finteractive_form): Handle closures.
23aba0ea 7179
03408648
SM
7180 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7181 interactive spec.
ba83908c 7182
04f2d78b
CB
7183 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7184 New byte-codes.
03408648
SM
7185 (exec_byte_code): New function extracted from Fbyte_code to handle new
7186 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 7187
03408648 7188 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 7189
03408648 7190 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 7191
e2abce01
JB
71922011-03-31 Juanma Barranquero <lekktu@gmail.com>
7193
7194 * xdisp.c (redisplay_internal): Fix prototype.
7195
63696a73 71962011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 7197
63696a73 7198 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
7199 (try_scrolling): Use it when setting scroll_limit.
7200 Limit scrolling to 100 screen lines.
63696a73
EZ
7201 (redisplay_window): Even when falling back on "recentering",
7202 position point in the window according to scroll-conservatively,
7203 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7204
7205 (try_scrolling): When point is above the window, allow searching
7206 as far as scroll_max, or one screenful, to compute vertical
7207 distance from PT to the scroll margin position. This prevents
7208 try_scrolling from unnecessarily failing when
7209 scroll-conservatively is set to a value slightly larger than the
7210 window height. Clean up the case of PT below the margin at bottom
7211 of window: scroll_max can no longer be INT_MAX. When aggressive
7212 scrolling is in use, don't let point enter the opposite scroll
7213 margin as result of the scroll.
7214 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
7215 threshold of 100 lines for never-recentering scrolling.
7216
e4cc2dfc
JB
72172011-03-31 Juanma Barranquero <lekktu@gmail.com>
7218
7219 * dispextern.h (move_it_by_lines):
7220 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7221 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7222 (message_log_check_duplicate): Remove parameters `prev_bol' and
7223 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7224 (redisplay_internal): Remove parameter `preserve_echo_area',
7225 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7226
7227 * indent.c (Fvertical_motion):
7228 * window.c (window_scroll_pixel_based, Frecenter):
7229 Don't pass `need_y_p' to `move_it_by_lines'.
7230
1c470562
SM
72312011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7232
44f230aa
SM
7233 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7234 steal a few bits to be more compact.
7235 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7236 Remove unneeded casts.
7237
1c470562
SM
7238 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7239
888adce9
ZK
72402011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7241
7242 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7243 binding" message (bug#7967).
7244
f838ed7b
PE
72452011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7246
77861b95
PE
7247 Fix more problems found by GCC 4.6.0's static checks.
7248
de6dbc14
PE
7249 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7250 Remove unused local var.
7251
f838ed7b
PE
7252 * editfns.c (Fmessage_box): Remove unused local var.
7253
792c7b2b
PE
7254 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7255 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7256 Omit unused local vars.
c499e557 7257 * window.c (shrink_windows): Omit unused local var.
b01a1c29 7258 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
7259 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7260 Omit unused local var.
7261
ba0165e1
PE
7262 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7263 Don't assume string length fits in int.
32ad8845 7264 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 7265 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 7266
3c59b4c9
PE
7267 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7268 instead of alloca (Bug#8344).
7269
a3eed478 7270 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 7271 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 7272
eb4d412d
PE
7273 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7274
1658b401
PE
7275 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7276 concerns.
7277
7278 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7279
7280 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 7281
9a2c6e05
PE
7282 * keyboard.c (syms_of_keyboard): Use the same style as later
7283 in this function when indexing through an array. This also
7284 works around GCC bug 48267.
7285
03d0a109
PE
7286 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7287
44f730c8
PE
7288 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7289
fe75f926
PE
7290 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7291 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7292
ffa8c828
PE
7293 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7294 This avoids undefined behavior on integer overflow, and is a bit
7295 more convenient anyway since it is compared to a size_t variable.
7296
c5101a77
PE
7297 Variadic C functions now count arguments with size_t, not int.
7298 This avoids an unnecessary limitation on 64-bit machines, which
7299 caused (substring ...) to crash on large vectors (Bug#8344).
7300 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7301 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 7302 All variadic functions and their callers changed accordingly.
c5101a77
PE
7303 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7304 * data.c (arith_driver, float_arith_driver): Likewise.
7305 * editfns.c (general_insert_function): Likewise.
7306 * eval.c (struct backtrace.nargs, interactive_p)
7307 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7308 (funcall_lambda, mark_backtrace): Likewise.
7309 * fns.c (concat): Likewise.
7310 * frame.c (x_set_frame_parameters): Likewise.
7311 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7312 0 if not found, not -1. All callers changed.
7313
dd3f25f7
PE
7314 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7315 (stack_copy_size): Now size_t, not int.
7316 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7317
461c2ab9
JB
73182011-03-28 Juanma Barranquero <lekktu@gmail.com>
7319
7320 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7321 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7322 All callers changed.
7323
7324 * lisp.h (multibyte_char_to_unibyte):
7325 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7326 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7327 * character.h (CHAR_TO_BYTE8):
7328 * cmds.c (internal_self_insert):
7329 * editfns.c (general_insert_function):
7330 * keymap.c (push_key_description):
7331 * search.c (Freplace_match):
7332 * xdisp.c (message_dolog, set_message_1): All callers changed.
7333
f6d62986
SM
73342011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7335
7336 * keyboard.c (safe_run_hook_funcall): New function.
7337 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7338 don't set the hook to nil, but remove the offending function instead.
7339 (Qcommand_hook_internal): Remove, unused.
7340 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7341 Vcommand_hook_internal.
7342
7343 * eval.c (enum run_hooks_condition): Remove.
7344 (funcall_nil, funcall_not): New functions.
7345 (run_hook_with_args): Call each function through a `funcall' argument.
7346 Remove `cond' argument, now redundant.
7347 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7348 (Frun_hook_with_args_until_failure): Adjust accordingly.
7349 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7350
1db5b1ad
JB
73512011-03-28 Juanma Barranquero <lekktu@gmail.com>
7352
7353 * dispextern.h (string_buffer_position): Remove declaration.
7354
7355 * print.c (strout): Remove parameter `multibyte', unused since
7356 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7357
7358 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7359 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7360 All callers changed.
7361
7362 * w32.c (_wsa_errlist): Use braces for struct initializers.
7363
7364 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7365 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7366 All callers changed.
7367 (string_buffer_position): Likewise. Also, make static (it's never
7368 used outside xdisp.c).
7369 (cursor_row_p): Remove parameter `w', unused since
7370 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7371 (decode_mode_spec): Remove parameter `precision', introduced during
7372 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7373 All callers changed.
7374
5ffb62aa
JD
73752011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7376
7377 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7378
461c2ab9 73792011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
7380
7381 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7382 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7383 (ns_update_auto_hide_menu_bar): New functions.
7384 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7385 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7386 ns_constrain_all_frames.
7387 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7388 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7389
5c380ffb
JD
73902011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7391
7392 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7393
9af30bdf
GM
73942011-03-27 Glenn Morris <rgm@gnu.org>
7395
7396 * syssignal.h: Replace RETSIGTYPE with void.
7397 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7398 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7399 Replace SIGTYPE with void everywhere.
7400 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7401 * s/template.h (SIGTYPE): Remove commented out definition.
7402
e2abce01
JB
74032011-03-26 Eli Zaretskii <eliz@gnu.org>
7404
7405 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7406 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7407
f868cd8a
JB
74082011-03-26 Juanma Barranquero <lekktu@gmail.com>
7409
59eb0929
JB
7410 * w32.c (read_unc_volume): Use parameter `henum', instead of
7411 global variable `wget_enum_handle'.
7412
7413 * keymap.c (describe_vector): Remove parameters `indices' and
7414 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7415 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7416
f868cd8a
JB
7417 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7418
7419 * keyboard.c (timer_check): Remove parameter `do_it_now',
7420 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7421 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7422 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7423
7424 * keyboard.c (read_char):
7425 * w32menu.c (w32_menu_display_help):
7426 * xmenu.c (show_help_event, menu_help_callback):
7427 Adjust calls to `show_help_echo'.
7428
7429 * gtkutil.c (xg_maybe_add_timer):
7430 * keyboard.c (readable_events):
7431 * process.c (wait_reading_process_output):
7432 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7433
7434 * insdel.c (adjust_markers_gap_motion):
7435 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7436 (gap_left, gap_right): Don't call it.
7437
2ecf6fdb
CY
74382011-03-25 Chong Yidong <cyd@stupidchicken.com>
7439
7440 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7441 incurred during fontification.
7442
6b1f9ba4
JB
74432011-03-25 Juanma Barranquero <lekktu@gmail.com>
7444
7445 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7446 (DEFVAR_PER_BUFFER): Don't pass it.
7447
7448 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7449 (scrolling_window): Don't pass it.
7450
0f4a96b5
JB
74512011-03-25 Juanma Barranquero <lekktu@gmail.com>
7452
7453 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7454
7455 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7456 and `suffix'.
7457 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7458 of variables specific to SELinux and computation of `encoded_absname'.
7459
7460 * image.c (XPutPixel): Remove unused variable `height'.
7461
7462 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7463
7464 * unexw32.c (get_section_info): Remove unused variable `section'.
7465
7466 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7467 (system_process_attributes): Remove unused variable `sess'.
7468 (sys_read): Remove unused variable `err'.
7469
7470 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7471 (w32_wnd_proc): Remove unused variable `isdead'.
7472 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7473 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7474 (x_create_tip_frame): Remove unused variable `tem'.
7475
7476 * w32inevt.c (w32_console_read_socket):
7477 Remove unused variable `no_events'.
7478
7479 * w32term.c (x_draw_composite_glyph_string_foreground):
7480 Remove unused variable `width'.
7481
1149507c
JB
74822011-03-24 Juanma Barranquero <lekktu@gmail.com>
7483
7484 * w32term.c (x_set_glyph_string_clipping):
7485 Don't pass uninitialized region to CombineRgn.
7486
9c88f339
JB
74872011-03-23 Juanma Barranquero <lekktu@gmail.com>
7488
7489 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7490 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7491 (Fx_close_connection): Remove unused variable `i'.
7492
7493 * w32font.c (w32font_draw): Return number of glyphs.
7494 (w32font_open_internal): Remove unused variable `i'.
7495 (w32font_driver): Add missing initializer.
7496
7497 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7498 (fill_in_menu): Remove unused variable `items_added'.
7499
7500 * w32term.c (last_mouse_press_frame): Remove static global variable.
7501 (w32_clip_to_row): Remove unused variable `f'.
7502 (x_delete_terminal): Remove unused variable `i'.
7503
7504 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7505 (NOTHING): Remove unused static global variable.
7506 (uniscribe_check_otf): Remove unused variable `table'.
7507 (uniscribe_font_driver): Add missing initializers.
7508
dee091a3
JD
75092011-03-23 Julien Danjou <julien@danjou.info>
7510
7511 * term.c (Fsuspend_tty, Fresume_tty):
7512 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7513 * window.c (temp_output_buffer_show):
7514 * insdel.c (signal_before_change):
7515 * frame.c (Fhandle_switch_frame):
7516 * fileio.c (Fdo_auto_save):
7517 * emacs.c (Fkill_emacs):
7518 * editfns.c (save_excursion_restore):
7519 * cmds.c (internal_self_insert):
7520 * callint.c (Fcall_interactively):
7521 * buffer.c (Fkill_all_local_variables):
7522 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7523 Use Frun_hooks.
0f4a96b5 7524 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
7525 unconditionnaly since it does the check itself.
7526
2c520ab5 75272011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 7528
c9c49752
PE
7529 Fix more problems found by GCC 4.5.2's static checks.
7530
8abc3f12
PE
7531 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7532 the first time through the loop, since we know p0 < p1 then.
7533 This also avoids a gcc -Wstrict-overflow warning.
7534
a2d26660
PE
7535 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7536 leading to a memory leak, possible in functions like
7537 load_charset_map_from_file that can allocate an unbounded number
b12ef411 7538 of objects (Bug#8318).
a2d26660 7539
916c72e9
PE
7540 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7541 that could (at least in theory) be that large.
7542
19ab8a18
PE
7543 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7544 This is less likely to overflow, and avoids undefined behavior if
7545 overflow does occur. All callers changed. Use strtoul to scan
7546 for the unsigned long integer.
b7cbbd6f
PE
7547 (pint2hrstr): Simplify and tune code slightly.
7548 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 7549
f0641eff
PE
7550 * scroll.c (do_scrolling): Work around GCC bug 48228.
7551 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7552
7f650bb9
PE
7553 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7554 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
7555 (validate_x_resource_name): Simplify count usage.
7556 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 7557
37dd57d1
PE
7558 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7559 fail (Bug#8306).
81e56e61 7560
699979fc 7561 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 7562
401bf9b4
PE
7563 * process.c (Fmake_network_process): Use socklen_t, not int,
7564 where POSIX says socklen_t is required in portable programs.
7565 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 7566 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
7567 (Fmake_network_process, server_accept_connection):
7568 (wait_reading_process_output, read_process_output):
7569 Likewise.
7570
b93aacde
PE
7571 * process.c: Rename or move locals to avoid shadowing.
7572 (list_processes_1, Fmake_network_process):
7573 (read_process_output_error_handler, exec_sentinel_error_handler):
7574 Rename or move locals.
4dc343ee 7575 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 7576 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 7577 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 7578 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 7579 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 7580
af8a867c 7581 Make tparam.h and terminfo.c consistent.
44f230aa
SM
7582 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7583 Include tparam.h instead, since it declares them.
af8a867c
PE
7584 * cm.h (PC): Remove extern decl; tparam.h now does this.
7585 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7586 * terminfo.c: Include tparam.h, to check interfaces.
7587 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7588 (tparam): Adjust signature to match interface in tparam.h;
7589 this removes some undefined behavior. Check that outstring and len
7590 are zero, which they always are with Emacs.
7591 * tparam.h (PC, BC, UP): New extern decls.
7592
0248044d 7593 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 7594 (xftfont_open): Rename locals to avoid shadowing.
0248044d 7595
8ff096c1 7596 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
7597 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7598 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 7599 (ftfont_list): Remove unused local.
49eaafba
PE
7600 (get_adstyle_property, ftfont_pattern_entity):
7601 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7602 Rename locals to avoid shadowing.
8ff096c1 7603
e2be39f6
PE
7604 * xfont.c (xfont_list_family): Mark var as initialized.
7605
c9735e30
PE
7606 * xml.c (make_dom): Now static.
7607
8f5201ae
PE
7608 * composite.c (composition_compute_stop_pos): Rename local to
7609 avoid shadowing.
b246f932
PE
7610 (composition_reseat_it): Remove unused locals.
7611 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 7612 (composition_update_it): Mark var as initialized.
11b61122
PE
7613 (find_automatic_composition): Mark vars as initialized,
7614 with a FIXME (Bug#8290).
8f5201ae 7615
760fbc2c
PE
7616 character.h: Rename locals to avoid shadowing.
7617 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7618 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7619 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7620 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7621 to avoid shadowing.
7622
ff08eb85
PE
7623 * textprop.c (property_change_between_p): Remove; unused.
7624
fc7bf025
PE
7625 * intervals.c (interval_start_pos): Now static.
7626
235d7abc
PE
7627 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7628
44f230aa
SM
7629 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7630 Rename locals to avoid shadowing.
3e7d6594 7631
50060332
PE
7632 * sound.c (wav_play, au_play, Fplay_sound_internal):
7633 Fix pointer signedness.
d01f234b 7634 (alsa_choose_format): Remove unused local var.
c83b8872
PE
7635 (wav_play): Initialize a variable to 0, to prevent undefined
7636 behavior (Bug#8278).
50060332 7637
c4fc4e30
PE
7638 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7639
918436ed
PE
7640 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7641
c939f91b
PE
7642 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7643 clobbering (Bug#8298).
b9c7f648
PE
7644 * sysdep.c (sys_subshell): Likewise.
7645 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 7646
6bd8c144
PE
7647 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7648 This should get cleaned up, so that child_setup has the
7649 same signature on all platforms.
7650
7710357c 7651 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 7652 (relocate_fd): Rename locals to avoid shadowing.
7710357c 7653
c59da222
CY
76542011-03-22 Chong Yidong <cyd@stupidchicken.com>
7655
7656 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7657 not to be necessary, and produces flickering.
7658
66b87493
GM
76592011-03-20 Glenn Morris <rgm@gnu.org>
7660
7661 * config.in: Remove file.
7662
45b6f6d5
JB
76632011-03-20 Juanma Barranquero <lekktu@gmail.com>
7664
7665 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7666 are now in src/globals.h.
7667 (syms_of_minibuf): Remove spurious & from previous change.
7668
3ec03f7e
LL
76692011-03-20 Leo <sdl.web@gmail.com>
7670
7671 * minibuf.c (completing-read-function): New variable.
7672 (completing-read-default): Rename from completing-read.
7673 (completing-read): Call completing-read-function.
7674
b14e3e21
CY
76752011-03-19 Juanma Barranquero <lekktu@gmail.com>
7676
7677 * xfaces.c (Fx_load_color_file):
7678 Read color file from absolute filename (bug#8250).
7679
f2b726e6
JB
76802011-03-19 Juanma Barranquero <lekktu@gmail.com>
7681
7682 * makefile.w32-in: Update dependencies.
7683
09f6ff02
EZ
76842011-03-17 Eli Zaretskii <eliz@gnu.org>
7685
7686 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7687
29a6015a
PE
76882011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7689
a3a6c54e
PE
7690 Fix more problems found by GCC 4.5.2's static checks.
7691
b766f867
PE
7692 * process.c (make_serial_process_unwind, send_process_trap):
7693 (sigchld_handler): Now static.
7694
be02381c
PE
7695 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7696 That way, the code declares only the vars that it needs.
7697 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7698 * s/cygwin.h (PTY_ITERATION): Likewise.
7699 * s/darwin.h (PTY_ITERATION): Likewise.
7700 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7701
57048744
PE
7702 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7703 * process.c (allocate_pty): Don't declare stb unless it's needed.
7704
7914961c 7705 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
7706 (CONSTANTLIM): Remove; unused.
7707 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7708 Define only if needed.
7914961c 7709
b3967b18
PE
7710 * unexelf.c (unexec): Name an expression,
7711 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
7712 Use a different way to cause a compilation error if anyone uses
7713 n rather than nn, a way that does not involve shadowing.
73366a00 7714 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 7715
29a6015a
PE
7716 * deps.mk (unexalpha.o): Remove; unused.
7717
43cfc33e 7718 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 7719 * unexec.h: New file.
ce701a33
PE
7720 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7721 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7722 Depend on unexec.h.
7723 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7724 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7725 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 7726 Change as necessary to match prototype in unexec.h.
ce701a33 7727
01f44d5a
PE
7728 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7729 shadowing.
4f63c6bb 7730 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 7731
a6670b0b
PE
7732 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7733 Rename locals to avoid shadowing.
7734
cef2010d 7735 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 7736 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 7737
d4d7173a
PE
7738 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7739
f08b802a
PE
7740 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7741 warning when compiling print.c.
7742
3ddb0639
PE
7743 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7744 instead of using an uninitialized var.
5ad03b97 7745 (font_sort_entities): Mark var as initialized.
3ddb0639 7746
170a2692
PE
7747 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7748
e663c700
PE
7749 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7750 pointers to constants.
89bc529a 7751 (font_parse_fcname): Remove unused vars.
7b81e2d0 7752 (font_delete_unmatched): Now static.
ea838e10 7753 (font_get_spec): Remove; unused.
13a547c6
PE
7754 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7755 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7756 Rename or move locals to avoid shadowing.
e663c700 7757
2a80c887 7758 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 7759 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 7760
1384fa33 7761 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 7762 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 7763
8b2c52e9
PE
7764 * alloc.c (mark_backtrace): Move decl from here ...
7765 * lisp.h: ... to here, so that it can be checked.
7766
475545b5 7767 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 7768 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
7769 (lisp_indirect_variable): Name an expression,
7770 to avoid gcc -Wbad-function-cast warning.
1faed8ae 7771 (Fdefvar): Rename locals to avoid shadowing.
475545b5 7772
b1349114 7773 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 7774 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 7775 Use const pointer when appropriate.
b1349114 7776
a2928364
PE
7777 * lisp.h (get_system_name, get_operating_system_release):
7778 Move decls here, to check interfaces.
7779 * process.c (get_operating_system_release): Move decl to lisp.h.
7780 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
7781 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7782 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7783 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
7784 (Fformat_time_string, Fencode_time, Finsert_char):
7785 (Ftranslate_region_internal, Fformat):
7786 Rename or remove local vars to avoid shadowing.
9710023e 7787 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 7788
a415e694
PE
7789 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7790 avoid shadowing.
7791
8ef4622d
PE
7792 * lisp.h (eassert): Check that the argument compiles, even if
7793 ENABLE_CHECKING is not defined.
7794
946f9a5b
PE
7795 * data.c (Findirect_variable): Name an expression, to avoid
7796 gcc -Wbad-function-cast warning.
112396d6 7797 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 7798 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
7799 (Fmake_variable_buffer_local, Fmake_local_variable):
7800 Mark variables as initialized.
52746918 7801 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 7802
e5aab7e7 7803 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
7804 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7805 Rename locals to avoid shadowing.
dff45157
PE
7806 (mark_stack): Move local variables into the #ifdef region where
7807 they're used.
7bc26fdb
PE
7808 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7809 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7810 needed otherwise.
7811 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7812 (GC_STRING_CHARS): Remove; not used.
d40d4be1 7813 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 7814
e5aab7e7
PE
7815 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7816 avoids undefined behavior in theory.
7817
4da60324
PE
7818 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7819
88043301
PE
7820 Use functions, not macros, for up- and down-casing (Bug#8254).
7821 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7822 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7823 to use the following functions instead of these macros.
7824 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7825 EMACS_INT, since callers assume the returned value fits in int.
7826 (upcase1): Likewise, for UPCASE_TABLE.
7827 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 7828 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 7829 the race-condition problem in the old DOWNCASE.
88043301 7830
19ed5445
PE
7831 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7832 Rename locals to avoid shadowing.
7833 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
7834 (regex_compile, re_search_2, re_match_2_internal):
7835 Remove unused local vars.
952db0d7
PE
7836 (FREE_VAR): Rewrite so as not to use empty "else",
7837 which gcc can warn about.
da053e48 7838 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
7839 (RETALLOC_IF): Define only if needed.
7840 (WORDCHAR_P): Likewise. This one is never needed, but is used
7841 only in a comment talking about a compiler bug, so put inside
7842 the #if 0 of that comment.
7843 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7844 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7845 Remove; unused.
19ed5445 7846
1f3561e4 7847 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
7848 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7849 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 7850
ded6f8f7
PE
7851 * search.c (simple_search): Remove unused var.
7852
dbd37a95
PE
7853 * dired.c (compile_pattern): Move decl from here ...
7854 * lisp.h: ... to here, so that it can be checked.
7855 (struct re_registers): New forward decl.
7856
7e47afad
PE
7857 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7858
85f24f61
PE
7859 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7860 All uses changed.
7861 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7862 Rename locals to avoid shadowing.
5671df8f 7863 (Fvertical_motion): Mark locals as initialized.
85f24f61 7864
181aa2be 7865 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 7866 (casify_region): Mark local as initialized.
181aa2be 7867
930d429c
PE
7868 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7869
7082eac6
PE
7870 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7871 New macros, so that the caller can use some names other than
7872 gcpro1, gcpro2, etc.
7873 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7874 of the new macros.
7875 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7876 argument, for consistency with GCPRO2_VAR, etc: it is now the
7877 prefix of the variable, not the variable itself. All uses
7878 changed.
38b2c076
PE
7879 * dired.c (directory_files_internal, file_name_completion):
7880 Rename locals to avoid shadowing.
7881
15206ed9
PE
7882 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7883 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7884 dired.c's scmp function, had undefined behavior.
7885 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7886 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7887 * buffer.h: ... to here, because these macros use current_buffer,
7888 and the new implementation with inline functions needs to have
7889 current_buffer in scope now, rather than later when the macros
7890 are used.
7891 (downcase, upcase1): New static inline functions.
7892 (DOWNCASE, UPCASE1): Reimplement using these functions.
7893 This avoids undefined behavior in expressions like
7894 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7895 from race conditions in accessing the global variables
7896 case_temp1 and case_temp2.
7897 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7898 * lisp.h (case_temp1, case_temp2): Remove their decls.
7899 * character.h (ASCII_CHAR_P): Move from here ...
7900 * lisp.h: ... to here, so that the inline functions mentioned
7901 above can use them.
7902
4a6bea26
PE
7903 * dired.c (directory_files_internal_unwind): Now static.
7904
f14b7e14
PE
7905 * fileio.c (file_name_as_directory, directory_file_name):
7906 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7907 Now static.
2893f146
PE
7908 (file_name_as_directory): Use const pointers when appropriate.
7909 (Fexpand_file_name): Likewise. In particular, newdir might
7910 point at constant storage, so make it a const pointer.
fd4ead52 7911 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
7912 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7913 signedness issues.
f839df0c
PE
7914 (Fset_file_times, Finsert_file_contents, auto_save_error):
7915 Rename locals to avoid shadowing.
f14b7e14 7916
5716756e 7917 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
7918 (Ftry_completion, Fall_completions): Rename or remove locals
7919 to avoid shadowing.
5716756e 7920
b4c3046a
PE
7921 * marker.c (bytepos_to_charpos): Remove; unused.
7922
b45db522
PE
7923 * lisp.h (verify_bytepos, count_markers): New decls,
7924 so that gcc does not warn that these functions aren't declared.
7925
85876d07
PE
7926 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7927 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 7928 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 7929 (copy_text): Remove unused local var.
85876d07 7930
03d78a21 7931 * filelock.c (within_one_second): Now static.
b3dd38ab 7932 (lock_file_1): Rename local to avoid shadowing.
03d78a21 7933
5df8f01b
PE
7934 * buffer.c (fix_overlays_before): Mark locals as initialized.
7935 (fix_start_end_in_overlays): Likewise. This function should be
7936 simplified by using pointers-to-pointers, but that's a different
7937 matter.
b1d876f1 7938 (switch_to_buffer_1): Now static.
8f54f30a
PE
7939 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7940 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 7941
a70072c9 7942 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 7943 Fix pointer signedness issue.
edced198
PE
7944 (sys_subshell): Mark local as volatile if checking for lint,
7945 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 7946 (MAXPATHLEN): Define only if needed.
a70072c9 7947
a0977c44
PE
7948 * process.c (serial_open, serial_configure): Move decls from here ...
7949 * systty.h: ... to here, so that they can be checked.
7950
a884fdcc
PE
7951 * fns.c (get_random, seed_random): Move extern decls from here ...
7952 * lisp.h: ... to here, so that they can be checked.
7953
604efe86 7954 * sysdep.c (reset_io): Now static.
b8950c94 7955 (wait_for_termination_signal): Remove; unused.
604efe86 7956
38fc62d9
PE
7957 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7958 (copy_keymap_item, append_key, push_text_char_description):
7959 Now static.
1004a21a 7960 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 7961 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
7962 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7963 (describe_map_tree):
7964 Rename locals to avoid shadowing.
38fc62d9 7965
2f2650da
PE
7966 * keyboard.c: Declare functions static if they are not used elsewhere.
7967 (echo_char, echo_dash, cmd_error, top_level_2):
7968 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
7969 (read_char, kbd_buffer_get_event, make_lispy_position):
7970 (make_lispy_event, make_lispy_movement, apply_modifiers):
7971 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7972 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7973 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 7974 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 7975 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 7976
a053e86c 7977 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
7978 (mark_kboards): Move decl here ...
7979 * alloc.c (mark_kboards): ... from here.
a053e86c 7980
4752793e
PE
7981 * lisp.h (force_auto_save_soon): New decl.
7982
74f10ca7 7983 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
7984 (DEFINE_DUMMY_FUNCTION): New macro.
7985 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7986 Use it.
c03cd23f
PE
7987 (main): Add casts to avoid warnings
7988 if GCC considers string literals to be constants.
74f10ca7 7989
022e70d4
PE
7990 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7991
59d6fe83
PE
7992 * dbusbind.c: Pointer signedness fixes.
7993 (xd_signature, xd_append_arg, xd_initialize):
7994 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7995 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7996 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7997 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7998
78320123
PE
7999 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8000 if GCC considers string literals to be constants.
49cebcca 8001 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 8002
35ac2a97
SM
80032011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8004
fb103ca9
SM
8005 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8006 (print_preprocess, print_object): New macro to fix last change.
8007
35ac2a97
SM
8008 * print.c (print_preprocess): Don't forget font objects.
8009
62973b41
JB
80102011-03-16 Juanma Barranquero <lekktu@gmail.com>
8011
8012 * emacs.c (USAGE3): Doc fixes.
8013
0e48bb22
AS
80142011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8015
8016 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8017 structure.
8018
7684e57b
JB
80192011-03-14 Juanma Barranquero <lekktu@gmail.com>
8020
8021 * lisp.h (VWindow_system, Qfile_name_history):
8022 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8023 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8024 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8025
8026 * w32select.c: Don't #include "keyboard.h".
c96bbc66 8027 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
8028
8029 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8030 * w32console.c (detect_input_pending, read_input_pending)
8031 (encode_terminal_code):
8032 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8033 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8034 (w32_system_caret_y, Qfile_name_history):
8035 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8036 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8037 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8038 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8039 * w32proc.c (Qlocal, report_file_error):
8040 * w32term.c (Vwindow_system, updating_frame):
8041 * w32uniscribe.c (initialized, uniscribe_font_driver):
8042 Remove unneeded extern declarations.
8043
2aa46d6c
CY
80442011-03-14 Chong Yidong <cyd@stupidchicken.com>
8045
c96bbc66 8046 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 8047
cffc6f3b
CY
80482011-03-13 Chong Yidong <cyd@stupidchicken.com>
8049
8050 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8051 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8052 These macros can no longer be used for assignment.
8053
44f230aa
SM
8054 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8055 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
8056 (record_buffer_markers, fetch_buffer_markers): New functions for
8057 recording and fetching special buffer markers.
8058 (set_buffer_internal_1, set_buffer_temp): Use them.
8059
8060 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8061
8062 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8063
8064 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8065 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8066
8067 * xdisp.c (hscroll_window_tree):
8068 (reconsider_clip_changes): Use PT instead of BUF_PT.
8069
d251f04b
EZ
80702011-03-13 Eli Zaretskii <eliz@gnu.org>
8071
8072 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8073 $(EMACS_ROOT)/lib/intprops.h.
8074
f0c77cd1
PE
80752011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8076
3eca4629
PE
8077 Fix more problems found by GCC 4.5.2's static checks.
8078
7c86ee98
PE
8079 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8080 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
8081 (xg_free_frame_widgets): Make it clear that a local variable is
8082 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
8083 (gdk_window_get_screen): Make it clear that this macro is needed
8084 only if USE_GTK_TOOLTIP.
1e5524e7
PE
8085 (int_gtk_range_get_value): New function, which avoids a diagnostic
8086 from gcc -Wbad-function-cast.
8087 (xg_set_toolkit_scroll_bar_thumb): Use it.
8088 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8089 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
8090 (get_utf8_string, xg_get_file_with_chooser):
8091 Rename locals to avoid shadowing.
8092 (create_dialog): Move locals to avoid shadowing.
7c86ee98 8093
41729b81
PE
8094 * xgselect.c (xg_select): Remove unused var.
8095
f0c77cd1
PE
8096 * image.c (four_corners_best): Mark locals as initialized.
8097 (gif_load): Initialize transparent_p to zero (Bug#8238).
8098 Mark another local as initialized.
ec6cf4c6 8099 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 8100
ce0ad53d 8101 * image.c (clear_image_cache): Now static.
d5d5a617 8102 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 8103 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
8104 (x_edge_detection): Remove unnecessary cast that
8105 gcc -Wbad-function-cast diagnoses.
2037898d 8106 (gif_load): Fix pointer signedness.
6ae141d6
PE
8107 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8108 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 8109
33383987 81102011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 8111
d32df629
PE
8112 Improve quality of tests for time stamp overflow.
8113 For example, without this patch (encode-time 0 0 0 1 1
8114 1152921504606846976) returns the obviously-bogus value (-948597
8115 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8116 reports time overflow. See
8117 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
8118 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8119 * editfns.c: Include limits.h and intprops.h.
8120 (TIME_T_MIN, TIME_T_MAX): New macros.
8121 (time_overflow): Move earlier, to before first use.
8122 (hi_time, lo_time): New functions, for an accurate test for
8123 out-of-range times.
8124 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8125 (Fget_internal_run_time): Don't assume time_t fits in int.
8126 (make_time): Use list2 instead of Fcons twice.
8127 (Fdecode_time): More accurate test for out-of-range times.
8128 (check_tm_member): New function.
8129 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
8130 (lisp_time_argument): Don't rely on undefined left-shift and
8131 right-shift behavior when checking for time stamp overflow.
8be6f318 8132
fe31d94c
PE
8133 * editfns.c (time_overflow): New function, refactoring common code.
8134 (Fformat_time_string, Fdecode_time, Fencode_time):
8135 (Fcurrent_time_string): Use it.
8136
8be6f318
PE
8137 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8138 * dired.c (make_time): Move to ...
8139 * editfns.c (make_time): ... here.
8140 * systime.h: Note the move.
8141
09d9db2c 81422011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 8143
126bc0dc
YM
8144 * fringe.c (update_window_fringes): Remove unused variables.
8145
c47cbdfd
YM
8146 * unexmacosx.c (copy_data_segment): Also copy __got section.
8147 (Bug#8223)
8148
7ac80be9
EZ
81492011-03-12 Eli Zaretskii <eliz@gnu.org>
8150
c96bbc66 8151 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
8152 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8153 Constify `char *' arguments and their references according to
8154 prototypes in tparam.h.
8155
ecb0f94d 8156 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 8157
7ac80be9
EZ
8158 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8159 Adapt all references accordingly.
8160
8161 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8162
ef1fd07e
TT
81632011-03-11 Tom Tromey <tromey@redhat.com>
8164
8165 * buffer.c (syms_of_buffer): Remove obsolete comment.
8166
7ef4b50c
EZ
81672011-03-11 Eli Zaretskii <eliz@gnu.org>
8168
8169 * termhooks.h (encode_terminal_code): Declare prototype.
8170
8171 * msdos.c (encode_terminal_code): Don't declare prototype.
8172
8173 * term.c (encode_terminal_code): Now external again, used by
8174 w32console.c and msdos.c.
8175
44f230aa
SM
8176 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8177 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 8178
4b1ec863 81792011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 8180
1714f52b 8181 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 8182
4b1ec863
PE
8183 * fringe.c (update_window_fringes): Mark locals as initialized
8184 (Bug#8227).
8185 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 8186
524c7aa6
PE
8187 * alloc.c (mark_fringe_data): Move decl from here ...
8188 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8189 to check its interface.
8190 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8191
a5c0af81 8192 * fontset.c (free_realized_fontset): Now static.
7519b8cd 8193 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 8194 (fontset_font): Mark local as initialized.
a9a06e0b 8195 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 8196
b4716021
PE
8197 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8198
811e9bac 8199 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 8200 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
8201 (x_own_selection, Fx_disown_selection_internal): Rename locals
8202 to avoid shadowing.
8203 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 8204
7e3ab302
PE
8205 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8206 so that the caller can use some name other than gcpro1.
8207 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
8208 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8209 (Fx_backspace_delete_keys_p):
8210 Use them to avoid shadowing, and rename vars to avoid shadowing.
8211 (x_decode_color, x_set_name, x_window): Now static.
6b437900 8212 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 8213 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
8214 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8215 Remove unused locals.
7e3ab302
PE
8216 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8217 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8218 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8219 macros.
f78faa98 8220
e2b13473
PE
8221 * xterm.h (x_mouse_leave): New decl.
8222
77f23912
PE
8223 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8224 Remove unused functions.
cdf4ba58
PE
8225 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8226 (x_calc_absolute_position): Now static.
7411c686 8227 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 8228 Don't declare local "event" unless it's used.
ed7bf3a5
PE
8229 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8230 unless they are used.
38d0b34a
PE
8231 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8232 (x_fatal_error_signal): Remove; not used.
a6067996
PE
8233 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8234 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8235 (x_error_catcher, x_connection_closed, x_error_handler):
8236 (x_error_quitter, xembed_send_message, x_iconify_frame):
8237 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 8238 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 8239 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 8240
44f230aa
SM
8241 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8242 Rename or move locals to avoid shadowing.
6b463e58 8243 (tty_defined_color, merge_face_heights): Now static.
5967d051 8244 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
8245 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8246 does not deduce is never used uninitialized.
73719eba
PE
8247 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8248 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 8249
426994c3 8250 * terminal.c (store_terminal_param): Now static.
5489860b 8251
032f1620 8252 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 8253 (set_frame_menubar): Remove unused local.
d4323972 8254 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
8255 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8256 since they might point to immutable storage.
281585b0
PE
8257 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8258 since it's unused otherwise.
032f1620 8259
367c19e5 8260 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 8261 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
8262 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8263 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 8264 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
8265 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8266 does not deduce are never used uninitialized.
70739cbe 8267
07b48fa9
PE
8268 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8269
8868a238 8270 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
8271 * window.c (window_loop, size_window):
8272 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 8273
7e5cf297 8274 * window.c (display_buffer): Now static.
d6550a9f
PE
8275 (size_window): Mark variables that gcc -Wuninitialized
8276 does not deduce are never used uninitialized.
a586633d
PE
8277 * window.h (check_all_windows): New decl, to forestall
8278 gcc -Wmissing-prototypes diagnostic.
5b555da1 8279 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 8280
f6095868
PE
8281 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8282 shadowing.
8283 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
8284 Include <limits.h>.
8285 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8286 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
8287 (load_charset_map): Mark variables that gcc -Wuninitialized
8288 does not deduce are never used uninitialized.
53df7c11 8289 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 8290
f38b440c
PE
8291 * coding.c (coding_set_source, coding_set_destination):
8292 Use "else { /* comment */ }" rather than "else /* comment */;"
8293 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
8294 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8295 a block, when the outer 'i' will do.
8296 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8297 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8298 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8299 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8300 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8301 Rename locals to avoid shadowing.
8302 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
8303 * coding.c (emacs_mule_char, encode_invocation_designation):
8304 Now static, since they're not used elsewhere.
413bb2db 8305 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 8306 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
8307 (decode_coding_emacs_mule): Mark variables that gcc
8308 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
8309 (detect_coding_iso_2022): Initialize a local variable that might
8310 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 8311 this initialization is needed. (Bug#8211)
5f58e762
PE
8312 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8313 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8314 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8315 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8316 Remove unused macros.
f38b440c 8317
232b38b9 8318 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 8319 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 8320 * character.c (string_count_byte8): Likewise.
232b38b9 8321
fb90da1b
PE
8322 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8323 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8324
fb93dbc2
PE
8325 * chartab.c (copy_sub_char_table): Now static, since it's not used
8326 elsewhere.
5c156ace
PE
8327 (sub_char_table_ref_and_range, char_table_ref_and_range):
8328 Rename locals to avoid shadowing.
bbcd0949 8329 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 8330
7d3b3862 8331 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 8332 (BIDI_BOB): Remove unused macro.
7d3b3862 8333
6be7d3da
PE
8334 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8335 deduce are never used uninitialized.
c2ed9c8b 8336 * term.c (encode_terminal_code): Likewise.
6be7d3da 8337
75f8807f 8338 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 8339
50938595
PE
8340 * tparam.h: New file.
8341 * term.c, tparam.h: Include it.
8342 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8343 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8344 Move these decls to tparam.h, and make them agree with what
8345 is actually in tparam.c. The previous trick of using incompatible
8346 decls in different modules does not conform to the C standard.
8347 All callers of tparam changed to use tparam's actual API.
8348 * tparam.c (tparam1, tparam, tgoto):
8349 Use const pointers where appropriate.
8350
fbceeba2
PE
8351 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8352 * cm.h (struct cm): Likewise.
8353 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8354 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8355 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8356 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8357 (turn_on_face, init_tty): Likewise.
8358 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 8359
7f3f1250
PE
8360 * term.c (term_mouse_position): Rename local to avoid shadowing.
8361
e6ca6543
PE
8362 * alloc.c (mark_ttys): Move decl from here ...
8363 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8364
c40f8d15
AS
83652011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8366
8367 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8368
cfe0661d
JB
83692011-03-09 Juanma Barranquero <lekktu@gmail.com>
8370
8371 * search.c (compile_pattern_1): Remove argument regp, unused since
8372 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8373 (compile_pattern): Don't pass it.
8374
0afb4571
J
83752011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8376
8377 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8378 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8379 for ! HAVE_GTK3.
8380 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8381
8382 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8383
8384 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8385 gdk_window_get_screen, gdk_window_get_geometry,
8386 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8387 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8388 (xg_get_pixbuf_from_pixmap): New function.
8389 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8390 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8391 Call xg_get_pixbuf_from_pixmap instead of
8392 gdk_pixbuf_get_from_drawable.
8393 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8394 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8395 (xg_check_special_colors): Use GtkStyleContext and its functions
8396 for HAVE_GTK3.
8397 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8398 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8399 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
8400 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8401 Call gtk_widget_get_preferred_size.
0afb4571
J
8402 (xg_frame_resized): gdk_window_get_geometry only takes 5
8403 parameters.
44f230aa
SM
8404 (xg_win_to_widget, xg_event_is_for_menubar):
8405 Call gdk_x11_window_lookup_for_display.
0afb4571
J
8406 (xg_set_widget_bg): New function.
8407 (delete_cb): New function.
895009e1 8408 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
8409 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
8410 (xg_set_background_color): Call xg_set_widget_bg.
8411 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8412 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8413 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8414 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8415 if ! HAVE_GTK3.
8416 (update_frame_tool_bar): Call gtk_widget_hide.
8417 (xg_initialize): Use GDK_KEY_g.
8418
8419 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8420 if ! HAVE_GTK3
8421 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8422
8423 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8424 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8425 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8426
1c2cc4ef
JB
84272011-03-08 Juanma Barranquero <lekktu@gmail.com>
8428
8429 * w32xfns.c (select_palette): Check success of RealizePalette against
8430 GDI_ERROR, not zero.
8431
33383987 8432See ChangeLog.11 for earlier changes.
aac0c6e3
MR
8433
8434;; Local Variables:
8435;; coding: utf-8
aac0c6e3
MR
8436;; End:
8437
33383987 8438 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
8439
8440 This file is part of GNU Emacs.
8441
8442 GNU Emacs is free software: you can redistribute it and/or modify
8443 it under the terms of the GNU General Public License as published by
8444 the Free Software Foundation, either version 3 of the License, or
8445 (at your option) any later version.
8446
8447 GNU Emacs is distributed in the hope that it will be useful,
8448 but WITHOUT ANY WARRANTY; without even the implied warranty of
8449 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8450 GNU General Public License for more details.
8451
8452 You should have received a copy of the GNU General Public License
8453 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.