lisp/progmodes/cwarn.el: Small fixes.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
31fd3586
GM
12012-01-29 Glenn Morris <rgm@gnu.org>
2
3 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
4
0e24a8b2
CY
52012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
6
7 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
8
cc0adcb0
CY
92012-01-28 Chong Yidong <cyd@gnu.org>
10
0e24a8b2 11
cc0adcb0
CY
12 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
13
acc28cb9
CY
142012-01-26 Chong Yidong <cyd@gnu.org>
15
9c69cfb7
CY
16 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
17
acc28cb9
CY
18 * search.c (Fsearch_forward, Fsearch_backward): Document negative
19 repeat counts (Bug#10507).
20
48da7392
GM
212012-01-26 Glenn Morris <rgm@gnu.org>
22
23 * lread.c (syms_of_lread): Doc fix.
24
14af5f7f
CY
252012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
26
27 * coding.c (encode_designation_at_bol): Change return value to
28 EMACS_INT.
29
0b21c100
CY
302012-01-25 Chong Yidong <cyd@gnu.org>
31
32 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
33
3c2907f7
CY
342012-01-21 Chong Yidong <cyd@gnu.org>
35
36 * floatfns.c (Fcopysign): Make the second argument non-optional,
37 since nil is not allowed anyway.
38
959ad23f
AS
392012-01-21 Andreas Schwab <schwab@linux-m68k.org>
40
41 * process.c (read_process_output): Use p instead of XPROCESS (proc).
42 (send_process): Likewise.
43
34a02f46
MR
442012-01-19 Martin Rudalics <rudalics@gmx.at>
45
46 * window.c (save_window_save, Fcurrent_window_configuration)
47 (Vwindow_persistent_parameters): Do not use Qstate. Rewrite
48 doc-strings.
49
1259009a 502012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
51
52 * character.c (char_width): New function.
70d4fdf6
GM
53 (Fchar_width, c_string_width, lisp_string_width):
54 Use char_width (Bug#9496).
25ed9e61 55
6a6ee00d
MR
562012-01-16 Martin Rudalics <rudalics@gmx.at>
57
58 * window.c (Vwindow_persistent_parameters): New variable.
59 (Fset_window_configuration, save_window_save): Handle persistent
60 window parameters.
61
c85efaf7
EZ
622012-01-14 Eli Zaretskii <eliz@gnu.org>
63
64 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
65 thrashing the stack of the thread. (Bug#9087)
66
5944709e
PE
672012-01-12 Paul Eggert <eggert@cs.ucla.edu>
68
69 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
70
e71f5d99
EZ
712012-01-11 Eli Zaretskii <eliz@gnu.org>
72
73 * xdisp.c (rows_from_pos_range): Handle the case where the
74 highlight ends on a newline. (Bug#10464)
75 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
76 he end column for display of highlight that ends on a newline
77 before a R2L line.
78
ce316182
GM
792012-01-11 Glenn Morris <rgm@gnu.org>
80
81 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
82 from load-path also when installation-directory is nil. (Bug#10208)
83
5b43da69
GM
842012-01-10 Glenn Morris <rgm@gnu.org>
85
74cc8ff9
GM
86 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
87
7d8d6e4e
GM
88 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
89 Update template values to be closer to their typical values these days.
5b43da69 90
a0db8d43
EZ
912012-01-09 Eli Zaretskii <eliz@gnu.org>
92
93 * xdisp.c (rows_from_pos_range): Accept additional argument
94 DISP_STRING, and accept any glyph in a row whose object is that
95 string as eligible for mouse highlight. Fixes mouse highlight of
96 display strings from overlays. (Bug#10464)
97
9a0115ab 982012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 99
b9110d6a 100 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
101 * fileio.c (auto_saving_dir_umask): New static var.
102 (Fmake_directory_internal): Use it.
103 (do_auto_save_make_dir): Set it, instead of invoking chmod after
104 creating the directory. The old code temporarily assigns
105 too-generous permissions to the directory.
106 (do_auto_save_eh): Clear it.
b9110d6a 107 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
108 that the var is always cleared.
109
6c1bd3f3
EZ
1102012-01-07 Eli Zaretskii <eliz@gnu.org>
111
112 * search.c (scan_buffer): Pass character positions to
113 know_region_cache, not byte positions. (Bug#6540)
114
069d2b50
L
1152012-01-07 LynX <_LynX@bk.ru> (tiny change)
116
117 * w32.c (sys_rename): Report EXDEV when rename of a directory
118 fails because the target is on another logical disk. (Bug#10284)
119
75bf0d33
DB
1202012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
121
122 * xterm.c (x_embed_request_focus): New function.
123
124 * xterm.h: Add prototype.
125
126 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
127
1c6e5a32
GM
1282012-01-05 Glenn Morris <rgm@gnu.org>
129
130 * emacs.c (emacs_copyright): Update short copyright year to 2012.
131
651e947e
EZ
1322012-01-01 Eli Zaretskii <eliz@gnu.org>
133
134 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
135 Load gnutls_transport_set_lowat only if GnuTLS version is below
136 2.11.1.
137 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
138 GnuTLS versions below 2.11.1.
139
3778cdd8
AL
1402011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
141
142 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
143 to the doc string advising against its use for altering the way
144 windows are scrolled.
145
0e5317f7
KH
1462011-12-28 Kenichi Handa <handa@m17n.org>
147
148 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
149 coding-system ASCII compatible only when it does not produce BOM
150 on encoding (Bug#10383).
151
93d5ca1f
JD
1522011-12-26 Jan Djärv <jan.h.d@swipnet.se>
153
154 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
155 can scroll.
156 (create_and_show_popup_menu): Always use menu_position_func for
157 Gtk3 (Bug#10361).
158
ca22b785
AS
1592011-12-24 Andreas Schwab <schwab@linux-m68k.org>
160
161 * callint.c (Fcall_interactively): Don't truncate prompt string.
162
d048e1e6
EZ
1632011-12-23 Eli Zaretskii <eliz@gnu.org>
164
165 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
166 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 167 resumed from there (after widening). (Bug#10360)
d048e1e6 168
5ccaba1f
JD
1692011-12-22 Jan Djärv <jan.h.d@swipnet.se>
170
171 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
172
204ee57f
JD
1732011-12-21 Jan Djärv <jan.h.d@swipnet.se>
174
b81d40f0
JB
175 * nsterm.m (x_free_frame_resources):
176 Release f->output_data.ns->miniimage.
204ee57f
JD
177 (ns_index_color): Fix indentation. Do not retain
178 color_table->colors[i].
179
180 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
181 before returning.
182
183 * nsfns.m (x_set_background_color): Assign return value from
184 ns_index_color to face-background instead of NSColor*.
185 (ns_implicitly_set_icon_type): Fix indentation.
186 Change assignment in for loop to comparison.
187
188 * emacs.c (ns_pool): New variable.
189 (main): Assign ns_pool.
190 (Fkill_emacs): Call ns_release_autorelease_pool.
191
192 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
193 autorelease fdesc, release fdAttrs and tdict.
194 (ns_get_covering_families): Release charset.
195 (ns_findfonts): Release NSFontDescriptor created with new.
196 (ns_uni_to_glyphs): Fix indentation.
197 (setString): Release attrStr before assigning new value.
198
c803b2b7
JD
1992011-12-18 Jan Djärv <jan.h.d@swipnet.se>
200
678f4426
JD
201 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
202 and NS_IMPL_COCOA.
203 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
204 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
205
cd394be1 2062011-12-18 David Reitter <reitter@cmu.edu>
678f4426 207
5fecd5fc
JD
208 * nsterm.m (ns_term_init): Subscribe for notifications
209 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
210 to method trackingNotification in EmacsMenu.
211
212 * nsmenu.m (trackingMenu): New variable.
3771cb17 213 (trackingNotification): New method (from Aquamacs).
5fecd5fc 214 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 215 from Aquamacs (Bug#7030).
678f4426
JD
216
2172011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 218
c803b2b7
JD
219 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
220 (symbol_to_nsstring): Fix indentation.
221 (ns_symbol_to_pb): New function.
222 (Fns_get_selection_internal): Renamed from Fns_get_cut_buffer_internal.
223 (Fns_rotate_cut_buffers_internal): Removed.
224 (Fns_store_selection_internal): Renamed from
225 Fns_store_cut_buffer_internal.
226 (ns_get_foreign_selection, Fx_own_selection_internal)
227 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
228 (Fns_get_selection_internal, Fns_store_selection_internal):
229 Use ns_symbol_to_pb and check if return value is nil.
230 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
231 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
232 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
233 renamed to Sns_store_selection_internal.
234 (ns_handle_selection_request): Move code to Fx_own_selection_internal
235 and remove this function.
236 (ns_handle_selection_clear): Remove, never used.
237 (Fx_own_selection_internal): Move code from ns_handle_selection_request
238 here.
239
e1b01a3a
KB
2402011-12-17 Ken Brown <kbrown@cornell.edu>
241
242 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
243 GID is unknown (Bug#10257).
244
2adb6e85
PE
2452011-12-17 Paul Eggert <eggert@cs.ucla.edu>
246
247 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
248 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
249 which caused a build failure on GNU/Linux IA-64. This problem was
250 introduced by my 2011-10-07 patch.
251
d1d7b339
JL
2522011-12-15 Juri Linkov <juri@jurta.org>
253
254 * image.c (imagemagick_error): New function. (Bug#10112)
255 (imagemagick_load_image): Comment out `MagickSetResolution' call.
256 Use `imagemagick_error' where ImageMagick functions return
257 `MagickFalse'.
258 (Fimagemagick_types): Add `Fnreverse' to return the list in the
259 proper order.
260
100d5755
KH
2612011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
262
263 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
264 fill background (Bug#8992).
265
454592a6
MR
2662011-12-13 Martin Rudalics <rudalics@gmx.at>
267
268 * window.c (Vwindow_combination_resize)
269 (Vwindow_combination_limit): Use t instead of non-nil in
270 doc-strings.
61d4b438
MR
271 (Vrecenter_redisplay): Add first sentence of doc-string on
272 separate line.
53524d93 273 (Frecenter): Fix doc-string typo.
454592a6 274
3633e3aa
KH
2752011-12-11 Kenichi Handa <handa@m17n.org>
276
277 * coding.c (Funencodable_char_position): Pay attention to the
278 buffer text relocation (Bug#9389).
279
7b9d523a
JD
2802011-12-10 Jan Djärv <jan.h.d@swipnet.se>
281
282 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
283 gtk_init (Bug#10100).
284
b73189c6
EZ
2852011-12-10 Eli Zaretskii <eliz@gnu.org>
286
287 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
288 IT->string is nil. (Bug#10263)
289
f7dfe5d6
JD
2902011-12-10 Jan Djärv <jan.h.d@swipnet.se>
291
83faebb4
JD
292 * nsterm.h (x_free_frame_resources): Declare.
293
f7dfe5d6
JD
294 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
295 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
296
297 * nsterm.h (ns_get_defaults_value): Declare.
298
299 * nsterm.m (ns_default): Call ns_get_defaults_value.
300
7cd4e72c
EZ
3012011-12-09 Eli Zaretskii <eliz@gnu.org>
302
303 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
304 (Bug#10170)
305
b34d7317
YM
3062011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
307
308 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
309 that where the value of an _OBJC_* symbol points to is in the .bss
310 section (Bug#10240).
311
76470ad1
KH
3122011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
313
314 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 315 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 316
745fff94
KH
3172011-12-08 Kenichi Handa <handa@m17n.org>
318
319 * ftfont.c (get_adstyle_property): Fix previous change
320 (Bug#10233).
321
6e44397c
JB
3222011-12-07 Juanma Barranquero <lekktu@gmail.com>
323
324 * w32.c (init_environment): If no_site_lisp, remove site-lisp
325 dirs from the default value of EMACSLOADPATH (bug#10208).
326
7efa6272
GM
3272011-12-07 Glenn Morris <rgm@gnu.org>
328
329 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
330 installation and source directories as well. (Bug#10208)
331
f6fc4d87
CY
3322011-12-06 Chong Yidong <cyd@gnu.org>
333
334 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
335
2bf26180
GM
3362011-12-06 Glenn Morris <rgm@gnu.org>
337
338 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
339 as an error, not just -1. (Bug#10217)
340
3a6ad4f0
CY
3412011-12-05 Chong Yidong <cyd@gnu.org>
342
343 * keyboard.c (process_special_events): New function.
344 (swallow_events, Finput_pending_p): Use it (Bug#10195).
345
75a3b399
PE
3462011-12-05 Paul Eggert <eggert@cs.ucla.edu>
347
348 * coding.c (encode_designation_at_bol): Don't use uninitialized
349 local variable (Bug#9318).
350
c3c9e25e
KH
3512011-12-05 Kenichi Handa <handa@m17n.org>
352
353 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
354 return Qnil (Bug#8046, Bug#10193).
355
5eb05ea3
KH
3562011-12-05 Kenichi Handa <handa@m17n.org>
357
358 * coding.c (encode_designation_at_bol): New args charbuf_end and
359 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
360 (coding_set_source): Return how many bytes coding->source was
361 relocated.
362 (coding_set_destination): Return how many bytes
363 coding->destination was relocated.
364 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
365 (CODING_CHAR_CHARSET_P): Adjusted for the avove changes.
5eb05ea3
KH
366
3672011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
368
369 * coding.c (CODING_CHAR_CHARSET_P): New macro.
370 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
371 macro (Bug#9318).
372
3732011-12-05 Andreas Schwab <schwab@linux-m68k.org>
374
375 The following changes are to fix Bug#9318.
376
a79703f5 377 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
378 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
379 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 380 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 381
7dbda6df
JB
3822011-12-05 Juanma Barranquero <lekktu@gmail.com>
383
384 * lisp.h (process_quit_flag): Fix external declaration.
385
6d5eb5b0
SM
3862011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
387
388 Don't macro-inline non-performance-critical code.
389 * eval.c (process_quit_flag): New function.
390 * lisp.h (QUIT): Use it.
391
a0c3fad0
JD
3922011-12-04 Jan Djärv <jan.h.d@swipnet.se>
393
394 * nsfns.m (get_geometry_from_preferences): New function.
395 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
396
6c07aac2
AS
3972011-12-04 Andreas Schwab <schwab@linux-m68k.org>
398
399 * emacs.c (Qkill_emacs): Define.
400 (syms_of_emacs): Initialize it.
401 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
402 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
403 (quit_throw_to_read_char): Add parameter `from_signal'.
404 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
405 * lisp.h (QUIT): Call Fkill_emacs if requested.
406
c052ead4
JD
4072011-12-03 Jan Djärv <jan.h.d@swipnet.se>
408
409 * widget.c (update_wm_hints): Return if wmshell is null.
410 (widget_update_wm_size_hints): New function.
411
412 * widget.h (widget_update_wm_size_hints): Declare.
413
414 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
415 widget_update_wm_size_hints (Bug#10104).
416
9e49252b
EZ
4172011-12-03 Eli Zaretskii <eliz@gnu.org>
418
419 * xdisp.c (handle_invisible_prop): If the invisible text ends just
420 before a newline, prepare the bidi iterator for consuming the
421 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 422 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 423
02b16839
JL
4242011-12-02 Juri Linkov <juri@jurta.org>
425
426 * search.c (Fword_search_regexp): New Lisp function created from
427 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
428 (Fword_search_backward, Fword_search_forward)
429 (Fword_search_backward_lax, Fword_search_forward_lax):
430 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
431 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
432
0068070e
SM
4332011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
434
435 * fileio.c (Finsert_file_contents): Move after-change-function call
436 to before the "handled:" label, since all "goto handled" appear in
437 cases where the *-change-functions have already been properly called
438 (bug#10117).
439
3360a3fc
AS
4402011-12-01 Andreas Schwab <schwab@linux-m68k.org>
441
442 * keyboard.c (interrupt_signal): Don't call kill-emacs when
443 waiting for input. (Bug#10169)
444
73d6c093
EZ
4452011-11-30 Eli Zaretskii <eliz@gnu.org>
446
447 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
448 verifies glyph row's hash code--we have just reallocated the
449 glyphs, so their contents can be complete garbage. (Bug#10164)
450
febe6bea
JB
4512011-11-30 Juanma Barranquero <lekktu@gmail.com>
452
453 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
454
801a4313
EZ
4552011-11-30 Eli Zaretskii <eliz@gnu.org>
456
457 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
458 attributes are tested _before_ calling verify_row_hash, to protect
459 against GCC re-ordering of the tests. (Bug#10164)
460
2b56b87e
JD
4612011-11-29 Jan Djärv <jan.h.d@swipnet.se>
462
463 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
464
465 * xterm.c (handle_one_xevent): Only set async_visible and friends
466 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 467 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
468 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
469
dbf31225
PE
4702011-11-28 Paul Eggert <eggert@cs.ucla.edu>
471
472 Remove GCPRO-related macros that exist only to avoid shadowing locals.
473 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
474 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
475 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
476 All uses changed to use GCPRO1 etc.
477 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
478 Revert to old implementation (i.e., before 2011-03-11).
479
1305621b
YM
4802011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
481
482 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
483 of scroll runs so as to avoid assigning disabled bogus rows and
484 unnecessary graphics copy operations.
485
8c9afb46
EZ
4862011-11-27 Eli Zaretskii <eliz@gnu.org>
487
488 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
489 (snprintf) [_MSC_VER]: Redirect to _snprintf.
490 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
491 (malloc, free, realloc, calloc): Redirect to e_* only when
492 compiling Emacs.
493
494 * lisp.h (GCTYPEBITS): Move before first use.
495 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
496 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
497 this macro definition.
498
499 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
500 _MSC_VER.
501
54e9e3bf
JD
5022011-11-27 Jan Djärv <jan.h.d@swipnet.se>
503
6d5eb5b0
SM
504 * gtkutil.c (xg_create_frame_widgets):
505 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
506 present with Gtk+ 2.0.
507
83aca1cb
PE
5082011-11-26 Paul Eggert <eggert@cs.ucla.edu>
509
510 * fileio.c (Finsert_file_contents): Undo previous change; see
511 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
512
5b76caa4
PE
5132011-11-26 Paul Eggert <eggert@cs.ucla.edu>
514
515 Rename locals to avoid shadowing.
516 * fileio.c (Finsert_file_contents):
517 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
518 * process.c (wait_reading_process_output):
519 Rename inner 'proc' to 'p' to avoid shadowing.
520 Indent for consistency with usual Emacs style.
521
8c535114
EZ
5222011-11-25 Eli Zaretskii <eliz@gnu.org>
523
524 * xdisp.c (redisplay_window): If cursor row is not fully visible
525 after recentering, and scroll-conservatively is set to a large
526 number, scroll window by a few more lines to make the cursor fully
527 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
528 (start_display): Don't move to the next line if the display should
529 start at a newline that is part of a display vector or an overlay
530 string. (Bug#10119)
8c535114 531
fa4fdb5c
JL
5322011-11-24 Juri Linkov <juri@jurta.org>
533
534 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
535 after the `MagickPingImage' call. (Bug#10112)
536
90ec88df
CY
5372011-11-23 Chong Yidong <cyd@gnu.org>
538
539 * window.c (Fcoordinates_in_window_p): Accept only live windows.
540
56e2e794
MR
5412011-11-23 Martin Rudalics <rudalics@gmx.at>
542
543 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
544 making another buffer current. (Bug#10114)
545
b6e64c41
GM
5462011-11-23 Glenn Morris <rgm@gnu.org>
547
548 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
549
6b21de18
CY
5502011-11-23 Chong Yidong <cyd@gnu.org>
551
552 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
553 using it (Bug#5984).
554
b12cd789
EZ
5552011-11-22 Eli Zaretskii <eliz@gnu.org>
556
557 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
558 and header-lines, as they don't have one computed for them.
559 (Bug#10098)
560
561 * .gdbinit (prow): Make displayed values more self-explaining.
562 Add row's hash code.
563
261b6fd4
LMI
5642011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
565
566 * process.c (wait_reading_process_output): Fix asynchrounous
567 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 568 (wait_reading_process_output): Add comment and URL.
261b6fd4 569
e7cfd277
JD
5702011-11-21 Jan Djärv <jan.h.d@swipnet.se>
571
572 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
573
a9b9b7f5
CY
5742011-11-21 Chong Yidong <cyd@gnu.org>
575
576 * window.c (Fnext_window, Fprevious_window): Doc fix.
577
b0d15b4f
SM
5782011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
579
580 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
581
fe7a3057
JB
5822011-11-20 Juanma Barranquero <lekktu@gmail.com>
583
584 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
585
d2999b1a
MR
5862011-11-20 Martin Rudalics <rudalics@gmx.at>
587
588 * window.c (Fset_window_combination_limit): Rename argument
589 STATUS to LIMIT.
590 (Vwindow_combination_limit): Remove "status" from doc-string.
591
d5ff9cd0
AS
5922011-11-20 Andreas Schwab <schwab@linux-m68k.org>
593
594 * m/ibms390.h: Remove.
595 * m/ibms390x.h: Don't include "ibms390.h".
596
a5bb9bd3
SM
5972011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
598
599 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
600 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
601
cd1181db
JB
6022011-11-20 Juanma Barranquero <lekktu@gmail.com>
603
604 * casetab.c (Fset_case_table):
605 * charset.c (Fcharset_after): Fix typos.
606
615a3b8d 6072011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 608
17e845af
PE
609 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
610 Otherwise, valgrind does not work on some platforms.
611 Problem reported by Andreas Schwab in
6a0bf43d
PE
612 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
613 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
614 is set, removing the need for VIRT_ADDRESS_VARIES.
615 (PURE_P): Use a more-efficient implementation that needs just one
616 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
617 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
618 to 4 (xorl, subq, cmpq, setbe).
619 * alloc.c (pure): Always extern now, since that's the
620 VIRT_ADDR_VARIES behavior.
621 (PURE_POINTER_P): Use a single comparison, not two, for
622 consistency with the new puresize.h.
623 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
624 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
625 Remove VIRT_ADDR_VARIES no longer needed.
626
f8fe6f96
EZ
6272011-11-19 Eli Zaretskii <eliz@gnu.org>
628
629 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
630 (erase_phys_cursor, update_window_cursor, show_mouse_face)
631 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
632 behave as if the cursor position were at the window margin.
633
634 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
635 and the cursor position is out of bounds, behave as if the cursor
636 position were at the window margin. (Bug#10075)
637
df05a53c
CY
6382011-11-18 Chong Yidong <cyd@gnu.org>
639
640 * window.c (Fwindow_combination_limit): Make first argument
641 non-optional, since it is meaningless for live windows like the
642 selected window.
643
2071918e
DA
6442011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
645
646 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
647
b50a28de
SM
6482011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
649
650 * intervals.c: Fix grafting over the whole buffer (bug#10071).
651 (graft_intervals_into_buffer): Simplify.
652
015137db
EZ
6532011-11-18 Eli Zaretskii <eliz@gnu.org>
654
655 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
656 hash values of the two rows.
657 (copy_row_except_pointers): Preserve the used[] arrays and the
658 hash values of the two rows. (Bug#10035)
68c95424 659 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
660
661 * xdisp.c (row_hash): New function, body extracted from
662 compute_line_metrics.
663 (compute_line_metrics): Call row_hash, instead of computing the
664 hash code inline.
665
666 * dispnew.c (verify_row_hash): Call row_hash for computing the
667 hash code of a row, instead of duplicating code from xdisp.c.
668
669 * dispextern.h (row_hash): Add prototype.
670
a2addb04
TH
6712011-11-18 Tassilo Horn <tassilo@member.fsf.org>
672
673 * frame.c (delete_frame): Don't delete the terminal when the last
674 X frame is closed if emacs is built with GTK toolkit.
675
df85d315
JB
6762011-11-17 Juanma Barranquero <lekktu@gmail.com>
677
678 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
679
a0c2d0ae
MR
6802011-11-17 Martin Rudalics <rudalics@gmx.at>
681
682 * window.c (Vwindow_splits): Rename to
683 Vwindow_combination_resize. Suggested by Juri Linkov.
684 (Fsplit_window_internal): Use Vwindow_combination_resize instead
685 of Vwindow_splits.
686
58179cce
JB
6872011-11-16 Juanma Barranquero <lekktu@gmail.com>
688
7877f373
JB
689 * nsfns.m (Fns_font_name):
690 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 691
b6f67890
MR
6922011-11-16 Martin Rudalics <rudalics@gmx.at>
693
694 * window.h (window): Rename slot "nest" to "combination_limit".
695 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
696 (Fset_window_nest): Rename to Fset_window_combination_limit.
697 (Vwindow_nest): Rename to Vwindow_combination_limit.
698 (recombine_windows, make_parent_window, make_window)
699 (Fsplit_window_internal, saved_window)
700 (Fset_window_configuration, save_window_save): Rename all
701 occurrences of window_nest to window_combination_limit.
702
c7015153
JB
7032011-11-15 Juanma Barranquero <lekktu@gmail.com>
704
705 * image.c (imagemagick_load_image): Fix typo.
706
322ad6ec
EZ
7072011-11-14 Eli Zaretskii <eliz@gnu.org>
708
709 * xdisp.c (display_line): Move the call to
710 highlight_trailing_whitespace before the call to
711 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
712 faces of all the glyphs to compute ROW's hash value.
713 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 714
f067b8ec
JB
7152011-11-14 Juanma Barranquero <lekktu@gmail.com>
716
717 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
718 just return (bug#10044).
719
1e5b2111
EZ
7202011-11-12 Eli Zaretskii <eliz@gnu.org>
721
7ef3cbd5
EZ
722 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
723 with user-defined heap size. Bump the default size of the temacs
724 heap to 27MB, to avoid memory warning when running temacs.
725 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
726
1e5b2111
EZ
727 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
728 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
729 (verify_row_hash) [XASSERTS]: New function.
730 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
731 that the hash value of glyph rows is correct.
1e5b2111 732
89d61221
MR
7332011-11-12 Martin Rudalics <rudalics@gmx.at>
734
735 * window.h (window): Remove splits slot.
736 * window.c (Fwindow_splits, Fset_window_splits): Remove.
737 (Fdelete_other_windows_internal, make_parent_window)
738 (make_window, Fsplit_window_internal, Fdelete_window_internal)
739 (Fset_window_configuration, save_window_save): Don't deal with
740 split status of windows.
741 (saved_window): Remove splits slot.
742 (Vwindow_splits): Rewrite doc-string.
743
97f18cc8
JD
7442011-11-11 Jan Djärv <jan.h.d@swipnet.se>
745
746 * xfns.c (unwind_create_frame):
747 * nsfns.m (unwind_create_frame):
748 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
749 Vframe_list (Bug#9999).
750
22a648b4
DA
7512011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
752
0b381c7e 753 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 754
659afede
KH
7552011-11-11 Kenichi Handa <handa@m17n.org>
756
757 * callproc.c (Fcall_process): Set the member dst_multibyte of
758 process_coding.
759
9ac0394b
KH
7602011-11-11 Johan Bockgård <bojohan@gnu.org>
761
762 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
763 avoid a crash (bug#9496).
764
2fbdc249
CY
7652011-11-09 Chong Yidong <cyd@gnu.org>
766
767 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
768 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
769
ac6b1f81
PE
7702011-11-08 Paul Eggert <eggert@cs.ucla.edu>
771
772 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
773
09db192c
PE
7742011-11-08 Paul Eggert <eggert@cs.ucla.edu>
775
776 Avoid some portability problems by eschewing 'extern inline' functions.
777 The trivial performance wins aren't worth the portability hassles; see
778 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
779 et seq.
780 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
781 (window_box_width, window_box_left, window_box_left_offset)
782 (window_box_right, window_box_right_offset): Undo previous change,
783 by removing the "extern"s.
784 * intervals.c (adjust_intervals_for_insertion)
785 (adjust_intervals_for_deletion): Undo previous change,
786 making these static again.
787 (offset_intervals, temp_set_point_both, temp_set_point)
788 (copy_intervals_to_string): No longer inline.
789 * xdisp.c (window_text_bottom_y, window_box_width)
790 (window_box_height, window_box_left_offset)
791 (window_box_right_offset, window_box_left, window_box_right)
792 (window_box): No longer inline.
793
105216ed
CY
7942011-11-08 Chong Yidong <cyd@gnu.org>
795
796 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
797 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
798 Signal an error if not a live window.
105216ed
CY
799 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
800 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
801
ae9e237f
JB
8022011-11-07 Juanma Barranquero <lekktu@gmail.com>
803
804 * lisp.h (syms_of_abbrev): Remove declaration.
805 Reported by CHENG Gao <chenggao@royau.me>.
806
c7aa8333
EZ
8072011-11-07 Eli Zaretskii <eliz@gnu.org>
808
809 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
810 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
811 of temacs in GUI mode.
812
be7f5545
MR
8132011-11-07 Martin Rudalics <rudalics@gmx.at>
814
815 * window.h: Declare delete_all_child_windows instead of
816 delete_all_subwindows.
817 * window.c (Fwindow_nest, Fset_window_nest)
818 (Fset_window_new_total, Fset_window_new_normal)
819 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
820 (delete_all_subwindows): Rename to delete_all_child_windows.
821 (Fdelete_other_windows_internal, Fset_window_configuration):
822 Call delete_all_child_windows instead of delete_all_subwindows.
823 * frame.c (delete_frame): Call delete_all_child_windows instead
824 of delete_all_subwindows.
825
ca78dc43
PE
8262011-11-07 Paul Eggert <eggert@cs.ucla.edu>
827
828 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
829 This is also needed for porting to any host where GC_MARK_STACK is
830 not GC_MAKE_GCPROS_NOOPS.
831 (which_symbols): Use it.
832
a0241d01
KH
8332011-11-07 Kenichi Handa <handa@m17n.org>
834
835 * coding.c (coding_set_destination): Check coding->src_pos only
836 when coding->src_object is a buffer (bug#9910).
837
838 * process.c (send_process): Set the member src_multibyte of coding
839 to 0 (bug#9911) when sending a unibyte text.
840
841 * callproc.c (Fcall_process): Set the member src_multibyte of
842 process_coding to 0 (bug#9912).
843
a64bfdfa 8442011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
845
846 * xmenu.c (cleanup_widget_value_tree): New function.
847 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
848 calling free_menubar_widget_value_tree directly (Bug#9830).
849
cb41b32a
PE
8502011-11-06 Paul Eggert <eggert@cs.ucla.edu>
851
852 Fix some portability problems with 'inline'.
853 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
854 (window_box_width, window_box_left, window_box_left_offset)
855 (window_box_right, window_box_right_offset): Declare extern.
856 Otherwise, these inline functions do not conform to C99 and
857 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
858 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
859 * intervals.c (adjust_intervals_for_insertion)
860 (adjust_intervals_for_deletion): Now extern, because otherwise the
861 extern inline functions 'offset_intervals' couldn't refer to it.
862 (static_offset_intervals): Remove.
863 (offset_intervals): Rewrite using the old contents of
864 static_offset_intervals. The old version didn't conform to C99
865 because an extern inline function contained a reference to an
866 identifier with static linkage.
867
b7041366
AS
8682011-11-06 Andreas Schwab <schwab@linux-m68k.org>
869
870 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
871 GC.
872
88a37c4d
EZ
8732011-11-06 Eli Zaretskii <eliz@gnu.org>
874
875 * xdisp.c (init_iterator, reseat_to_string): Don't set the
876 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
877 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
878 return Qleft_to_right.
879
49745b39
CY
8802011-11-06 Chong Yidong <cyd@gnu.org>
881
882 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
883 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
884 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
885 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
886 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
887 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
888 (Fwindow_vscroll): Doc fix.
889 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
890 argument, since it makes no sense to pass a live window and for
891 consistency with window-child.
892
1f05cd82
CS
8932011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
894
895 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
896 support MSVC.
897
22610910
JR
8982011-11-05 Jason Rumney <jasonr@gnu.org>
899
900 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
901 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
902 fonts (Bug#6029).
903 (add_font_entity_to_list): Fix logic errors in mixed boolean and
904 bitwise arithmetic preventing use of unicode-sip and non-truetype
905 opentype fonts.
906
a06776b2
EZ
9072011-11-05 Eli Zaretskii <eliz@gnu.org>
908
3ad924ba
EZ
909 * s/ms-w32.h (fstat, stat, utime): Move redirections to
910 "emacs"-only part.
911
a06776b2
EZ
912 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
913 initialization code to keep similarity to xfns.c after changes
914 from 2011-11-05.
915
c9e7db78
JD
9162011-11-05 Jan Djärv <jan.h.d@swipnet.se>
917
a97f8f3f
JD
918 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
919 (unwind_create_frame): New function (Bug#9943).
920 (Fx_create_frame): Restructure code to be more similar to the one in
921 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
922 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
923 Move terminal->reference_count++ just before making the frame official
924 (Bug#9943).
925
926 * nsterm.m (x_free_frame_resources): New function.
927 (x_destroy_window): Move code to x_free_frame_resources.
928
c9e7db78 929 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
930 (Fx_create_frame, x_create_tip_frame):
931 Move terminal->reference_count++ just before making the frame
c9e7db78
JD
932 official. Move initialization of image_cache_refcount and
933 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
934
a6fc3b5c
EZ
9352011-11-05 Eli Zaretskii <eliz@gnu.org>
936
937 Support MSVC build with newer versions of Visual Studio.
938 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
939 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
940 nt/gmake.defs.
941
942 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
943 which are not supported by MSVC.
944 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
945 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
946 bitfields.
947 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
948 types in bitfields.
949 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
950
951 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
952
58179cce 9532011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
954
955 Support MSVC build with newer versions of Visual Studio.
956 * w32.c: Don't include w32api.h for MSVC.
957 (init_environment) [_MSC_VER]: Call sys_access, not _access.
958
959 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
960 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
961 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
962 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
963 e_* cousins.
964 (alloca) [_MSC_VER]: Define to _alloca.
965
966 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
967
968 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
969
a58c13ed
EZ
9702011-11-04 Eli Zaretskii <eliz@gnu.org>
971
972 * xdisp.c (note_mouse_highlight): If either of
973 previous/next-single-property-change returns nil, treat that as
974 the beginning or the end of the buffer. (Bug#9955)
975
fe0b6370
JD
9762011-11-04 Jan Djärv <jan.h.d@swipnet.se>
977
a58c13ed 978 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
979 label is not null (Bug#9951).
980 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
981 may be NULL.
982
89bd5ee1
EZ
9832011-11-04 Eli Zaretskii <eliz@gnu.org>
984
985 * window.c (Fwindow_body_size): Mention in the doc string that the
986 return value is in frame's canonical units. (Bug#9949)
987
84c3edb9
EZ
9882011-11-03 Eli Zaretskii <eliz@gnu.org>
989
4e2fb5c7
EZ
990 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
991
84c3edb9 992 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 993 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 994 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 995
bc17a887
EZ
9962011-11-01 Eli Zaretskii <eliz@gnu.org>
997
998 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
999 Don't stop backward scan on the continuation glyph, even though
1000 its CHARPOS is positive.
6d5eb5b0
SM
1001 (mouse_face_from_buffer_pos, note_mouse_highlight):
1002 Rename cover_string to disp_string.
bc17a887 1003
4ee88440
MR
10042011-11-01 Martin Rudalics <rudalics@gmx.at>
1005
1006 * window.c (temp_output_buffer_show): Don't use
1007 Vtemp_buffer_show_specifiers.
1008 (Vtemp_buffer_show_specifiers): Remove unused variable.
1009
c2ff3c02
EZ
10102011-10-30 Eli Zaretskii <eliz@gnu.org>
1011
1012 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1013 past the beginning of the current glyph matrix.
1014
58179cce 10152011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
1016
1017 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1018 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1019 HAVE_GTK3 (Bug#9869).
b77a6a7f 1020
3b574623
JD
1021 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1022 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1023
b77a6a7f
JD
1024 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1025
1026 * xterm.c: Declare x_handle_net_wm_state to return int.
1027 (handle_one_xevent): Check if we are iconified but don't have
1028 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1029 (get_current_wm_state): Return non-zero if not hidden,
1030 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1031 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1032 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1033 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1034
196e41e4
PE
10352011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1036
1037 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1038 so that this new function doesn't get optimized away by a
1039 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1040
021f2e1a
AS
10412011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1042
1043 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1044
8b058d44
EZ
10452011-10-29 Eli Zaretskii <eliz@gnu.org>
1046
1047 Fix the `xbytecode' command.
1048 * .gdbinit (xprintbytestr): New command.
b50a28de 1049 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
1050 (xbytecode): Print the byte-code string as well.
1051
4452fb80
EZ
10522011-10-29 Kim Storm <storm@cua.dk>
1053
8b058d44
EZ
1054 * alloc.c (which_symbols): New function.
1055
21b72067
AS
10562011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1057
1058 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1059 line. (Bug#9903)
1060
83ed7b5c
GM
10612011-10-29 Glenn Morris <rgm@gnu.org>
1062
1063 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1064 Not clear what it was for, and it causes various bugs. (Bug#9839)
1065
5a7a728b
EZ
10662011-10-28 Eli Zaretskii <eliz@gnu.org>
1067
1068 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1069 possible random value that matches one of those tested as
1070 condition to clear the mouse face.
1071
d3d0842f
CY
10722011-10-28 Chong Yidong <cyd@gnu.org>
1073
1074 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1075
31b39d13
DN
10762011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1077
1078 * window.c (make_window): Initialize phys_cursor_on_p.
1079
9aba6043
SM
10802011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1081
1082 * lisp.h (struct Lisp_Symbol): Update comments.
1083
c20992f4
JB
10842011-10-28 Juanma Barranquero <lekktu@gmail.com>
1085
1086 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1087
db4f02f2
EZ
10882011-10-28 Eli Zaretskii <eliz@gnu.org>
1089
1090 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1091 <oslsachem@gmail.com> for helping to debug this.
1092
1093 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1094 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1095 (g_b_init_get_glyph_outline_w): New static variables.
1096 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1097 (GetGlyphOutlineW_Proc): New typedefs.
1098 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
1099 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1100 New functions.
1101 (w32font_open_internal, compute_metrics):
1102 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
1103 instead of calling the "wide" APIs directly.
1104
1105 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1106
1107 * w32.h (syms_of_w32font): Add prototype.
1108
87e68db4
JB
11092011-10-27 Juanma Barranquero <lekktu@gmail.com>
1110
1111 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1112 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1113 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1114 (Fmove_to_window_line): Doc fix.
1115
435c1d67
CY
11162011-10-27 Chong Yidong <cyd@gnu.org>
1117
1118 * process.c (make_process): Set gnutls_state to NULL.
1119
1120 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1121 non-NULL, regardless of GNUTLS_INITSTAGE.
1122 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1123 an error. Set process slots as soon as we allocate them.
1124
1125 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1126
9c6c6f49
CY
11272011-10-27 Chong Yidong <cyd@gnu.org>
1128
9aba6043
SM
1129 * gnutls.c (emacs_gnutls_deinit): New function.
1130 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
1131 (Fgnutls_deinit, Fgnutls_boot): Use it.
1132
1133 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1134 (deactivate_process): Call emacs_gnutls_deinit.
1135
657d08d3
JB
11362011-10-27 Juanma Barranquero <lekktu@gmail.com>
1137
1138 * image.c (x_create_x_image_and_pixmap):
1139 * w32.c (sys_rename, w32_delayed_load):
1140 * w32font.c (fill_in_logfont):
1141 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1142
5430d399
JB
11432011-10-26 Juanma Barranquero <lekktu@gmail.com>
1144
1145 * w32fns.c (w32_default_color_map): New function,
1146 extracted from Fw32_default_color_map.
a7ef684b 1147 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 1148
fe0055fa
PE
11492011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1150
1151 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1152
e6346438
SM
11532011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1154
1155 * keyboard.c (test_undefined): New function (bug#9751).
1156 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1157
e112cc37
ET
11582011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1159
1160 * sysdep.c (init_sys_modes): Fix the check for the controlling
1161 terminal (Bug#6649).
1162
7b5d6677
EZ
11632011-10-20 Eli Zaretskii <eliz@gnu.org>
1164
1165 * dispextern.h (struct bidi_it): New member next_en_type.
1166
1167 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1168 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1169 current character, check also for next_en_type being WEAK_EN.
1170 (bidi_resolve_weak): Don't enter the expensive loop if the current
1171 position is before next_en_pos. Record the bidi type of the first
1172 non-ET, non-BN character we find, in addition to its position.
1173 (bidi_level_of_next_char): Invalidate next_en_type when
1174 next_en_pos is over-stepped.
1175
7da0b018
PE
11762011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1177
1178 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1179 * editfns.c: Rewrite current-time-zone so that it invokes
1180 the equivalent of (format-time-string "%Z") to get the time zone name.
1181 This fixes a bug when the time zone name contains characters that
1182 need converting from the system time locale to Emacs internal format.
1183 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1184 that patch fixed format-time-string to do the conversion, but
1185 I forgot to fix current-time-zone.
1186 (format_time_string): New function, containing most of
1187 what Fformat_time_string used to contain.
1188 (Fformat_time_string): Rewrite in terms of format_time_string.
1189 This doesn't change this function's behavior.
1190 (current-time-zone): Rewrite to use format_time_string.
1191 This fixes the bug reported by Michael Schierl in
1192 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1193 Jason Rumney's 2007-06-07 change worked around this bug, but
1194 didn't fix it.
1195 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1196
8547b010
EZ
11972011-10-19 Eli Zaretskii <eliz@gnu.org>
1198
1199 * xdisp.c (start_display): If the character at POS is displayed
1200 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
1201 (try_window_reusing_current_matrix): If a line ends in a display
1202 vector or the next line starts in a display vector, continue
1203 redrawing the window even though the character position of
1204 start_row was reached.
8547b010
EZ
1205 (Bug#9771, part 2)
1206
4e948d15
CY
12072011-10-18 Chong Yidong <cyd@gnu.org>
1208
1209 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1210 with nobreak-char-display too.
1211
4787455f
EZ
12122011-10-18 Eli Zaretskii <eliz@gnu.org>
1213
1214 Fix part 3 of bug#9771.
1215 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1216 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1217 non-neutral characters if the current character is a paragraph
1218 separator (a.k.a. Newline). This avoids running the same
1219 expensive loop twice, once when we consume the preceding newline
1220 and the other time when the line actually needs to be displayed.
1221 Avoid the loop when we see neutrals on the base embedding level
1222 following a character whose directionality is the same as the
1223 paragraph's. This avoids running the expensive loop when a line
1224 ends in a long sequence of neutrals, like control characters.
1225 Add assertion against STRONG_AL type. Slightly rearrange code
1226 that determines the type of a neutral given the first non-neutral
1227 that follows it.
1228 (bidi_level_of_next_char): Set next_en_pos to zero when
1229 invalidating its info.
1230
2c91f553
EZ
12312011-10-17 Eli Zaretskii <eliz@gnu.org>
1232
1233 * xdisp.c (push_display_prop): Determine whether to record string
1234 or buffer position by IT->string, not by IT->method. Allow
1235 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
1236 (move_it_vertically_backward): Don't look for character position
1237 immediately after the newline when in a continuation line.
1238 (Bug#9771, part 1)
2c91f553 1239
c7b08b0d
MR
12402011-10-15 Martin Rudalics <rudalics@gmx.at>
1241
1242 * window.c (coordinates_in_window): Rewrite and delabelize
1243 vertical border check. (Bug#5357) (Bug#9618)
1244
6b02f655
SM
12452011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1246
1247 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1248 errors in XSetWindowBorder (bug#9310).
1249
81d40c92
DA
12502011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1251
1252 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1253 avoid crash when xmalloc overrun checking is enabled.
1254
d4172c3b
EZ
12552011-10-13 Eli Zaretskii <eliz@gnu.org>
1256
1257 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1258 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1259 cursor motion with <left> and <right> arrow keys.
1260
1261 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1262 some callers set that themselves.
1263
b00eea75
EZ
12642011-10-12 Eli Zaretskii <eliz@gnu.org>
1265
1266 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1267 display string and the previous row comes from the same string and
1268 is empty. (Bug#9739) (Bug#9738)
1269
8fe012c4
SM
12702011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1271
1272 * doc.c (get_doc_string): Encode file name (bug#9735).
1273
0074aef2
EZ
12742011-10-12 Eli Zaretskii <eliz@gnu.org>
1275
79beb178
EZ
1276 * bidi.c (bidi_level_of_next_char):
1277 * xdisp.c (get_visually_first_element): Remove old incorrect
1278 comments regarding the Unicode Line Separator character.
1279
0074aef2
EZ
1280 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1281
6e4b3fbe
DA
12822011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1283
1284 * alloc.c (Fgc_status): Do not access beyond zombies array
1285 boundary if nzombies > MAX_ZOMBIES.
1286 * alloc.c (dump_zombies): Add missing format specifier.
1287
0324f3af
PE
12882011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1289
b5525cac
PE
1290 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1291 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1292
0324f3af
PE
1293 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1294 Some packages use them to denote characters with modifiers.
1295
e9b5f888
AS
12962011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1297
1298 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1299 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1300 matching a pp-number. Rename parameter var to var1.
1301
127827c0
SM
13022011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1303
1304 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1305
c8fd3bd0
GM
13062011-10-08 Glenn Morris <rgm@gnu.org>
1307
1308 * callint.c (Fcall_interactively): Give a more explicit error for the
1309 'c' case with a non-character input. (Bug#8479)
1310
352ec8ff
EZ
13112011-10-08 Eli Zaretskii <eliz@gnu.org>
1312
03669ccb
EZ
1313 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1314 lines.
7061c986
EZ
1315 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1316 lines that are hscrolled on the left.
03669ccb 1317
352ec8ff
EZ
1318 * dispnew.c (buffer_posn_from_coords): Account for a possible
1319 presence of header-line. (Bug#4426)
1320
a66cfb1c
SM
13212011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1322
6b02f655
SM
1323 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1324 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 1325
7c5ee88e
PE
13262011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1327
1328 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1329 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1330 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1331 this makes Emacs dump core during garbage collection on rare
1332 occasions. sizeof is obviously inferior to offsetof here, so
1333 stick with offsetof.
1334 (GC_POINTER_ALIGNMENT): New macro.
1335 (mark_memory): Omit 3rd (offset) arg; caller changed.
1336 Don't assume EMACS_INT alignment is the same as pointer alignment.
1337
df1bbe5b
SM
13382011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1339
1340 * keyboard.c (read_key_sequence_remapped): New var.
1341 (read_key_sequence): Compute remapping in the right buffer.
1342 (command_loop_1): Use read_key_sequence's remapping directly.
1343
51553db6
SM
13442011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1345
32c1fffd
SM
1346 * dired.c (file_name_completion): Don't expand file name.
1347 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1348 before checking file name handler.
1349
51553db6
SM
1350 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1351 they've been requested explicitly (bug#9591).
1352
b6bd1599 13532011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
1354
1355 * keymap.c (Fsingle_key_description): Use make_specified_string
1356 instead of build_string to build string from push_key_description.
1357 (Bug#5193)
1358
f701dc2a
PE
13592011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1360
4222c55d
PE
1361 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1362 This fixes a Y2038 bug on 64-bit hosts.
1363 * buffer.c (reset_buffer):
1364 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1365 (Fclear_buffer_auto_save_failure):
1366 Use 0, not -1, to represent an unset failure time, since time_t
1367 might not be signed.
1368
f701dc2a
PE
1369 Remove dependency on glibc malloc internals.
1370 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1371 Move back here from lisp.h, but with their new implementations.
1372 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1373 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1374 * charset.c (charset_table_init): New static var.
1375 (syms_of_charset): Use it instead of xmalloc. This removes a
1376 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1377 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1378 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1379 Move back to alloc.c.
1380 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1381 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1382
9ceebf39
JD
13832011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1384
1385 * nsterm.m (windowDidResize): Call x_set_window_size only when
1386 ns_in_resize is true. Otherwise set pixelwidth/height and
1387 call change_frame_size (Bug#9628).
1388
cb993c58
PE
13892011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1390
3930c88b
PE
1391 Port --enable-checking=all to Fedora 14 x86-64.
1392 * charset.c (syms_of_charset): Also account for glibc malloc's
1393 internal overhead when calculating the initial malloc maximum.
1394
cb993c58
PE
1395 Port --enable-checking=all to Fedora 14 x86.
1396 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1397 Move to lisp.h.
1398 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1399 (overrun_check_realloc, overrun_check_free):
1400 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1401 That way, xmalloc returns a properly-aligned pointer even if
1402 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1403 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1404 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1405 into account when calculating the initial malloc maximum.
1406 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1407 Move here from alloc.c, so that charset.c can use it too.
1408 Properly align; the old code wasn't right for common 32-bit hosts
1409 when configured with --enable-checking=all.
1410 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1411 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1412
31bed486
EZ
14132011-09-29 Eli Zaretskii <eliz@gnu.org>
1414
04c70788 1415 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
1416 use EDOM.
1417
fbcaa2f3
EZ
14182011-09-28 Eli Zaretskii <eliz@gnu.org>
1419
1420 * xdisp.c (compute_display_string_end): If there's no display
1421 string at CHARPOS, return -1.
1422
1423 * bidi.c (bidi_fetch_char): When compute_display_string_end
1424 returns a negative value, treat the character as a normal
1425 character not covered by a display string. (Bug#9624)
1426
a239d4e9
JB
14272011-09-28 Juanma Barranquero <lekktu@gmail.com>
1428
1429 * lread.c (Fread_from_string): Fix typo in docstring.
1430
88652fd5
EZ
14312011-09-27 Eli Zaretskii <eliz@gnu.org>
1432
1433 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1434 newline, reseat the iterator instead of bidi-iterating there one
1435 character at a time. (Bug#9610)
32c1fffd
SM
1436 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1437 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 1438
ed497dd4
AS
14392011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1440
1441 * lread.c (readevalloop): Use correct code for NBSP.
1442 (read1): Likewise. (Bug#9608)
1443
b2bf61aa
MA
14442011-09-25 Michael Albinus <michael.albinus@gmx.de>
1445
1446 * dbusbind.c (Fdbus_register_signal): When service is not
1447 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1448
32bbb17c
GM
14492011-09-25 Glenn Morris <rgm@gnu.org>
1450
1451 * buffer.c (truncate-lines): Doc fix.
1452
94e0933e
CY
14532011-09-24 Chong Yidong <cyd@stupidchicken.com>
1454
1455 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1456 (Fset_window_next_buffers): Doc fix.
1457
cddde921
GM
14582011-09-24 Glenn Morris <rgm@gnu.org>
1459
1460 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1461
1260aef1
PE
14622011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1463
25b4bfa0
PE
1464 Fix minor problems found by static checking.
1465 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
1466 * indent.c (Fvertical_motion): Fix == vs = typo.
1467
e3cbd34b
EZ
14682011-09-24 Eli Zaretskii <eliz@gnu.org>
1469
a66cfb1c
SM
1470 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1471 Default value is now t. Doc fix.
6bf7006f 1472
e3cbd34b 1473 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 1474 logic when moving up, not only when moving down. Fix the
e3cbd34b 1475 confusing name and values of the it_overshoot_expected variable;
32c1fffd 1476 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
1477
1478 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1479 CHARPOS is covered by a display string which includes newlines.
1480 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1481 is covered by a display string with embedded newlines.
1482
a3de0cbd
MA
14832011-09-24 Michael Albinus <michael.albinus@gmx.de>
1484
1485 * dbusbind.c (Fdbus_register_signal): Add match rule to
1486 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
1487 (Fdbus_register_method, Vdbus_registered_objects_table):
1488 Fix docstring.
a3de0cbd 1489
b260039d
JM
14902011-09-24 Jim Meyering <meyering@redhat.com>
1491
32c1fffd 1492 do not ignore write error for any output size
b260039d
JM
1493 The previous change was incomplete.
1494 While it makes emacs --batch detect the vast majority of stdout
1495 write failures, errors were still ignored whenever the output size is
1496 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1497 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1498 && echo FAIL: ignored write error
1499 FAIL: ignored write error
1500 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1501 && echo FAIL: ignored write error
1502 FAIL: ignored write error
1503 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1504
8eca8a7c
AS
15052011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1506
1507 * emacs.c (Fkill_emacs): In noninteractive mode exit
1508 non-successfully if a write error occurred on stdout. (Bug#9574)
1509
3341db62
EZ
15102011-09-21 Eli Zaretskii <eliz@gnu.org>
1511
1512 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1513 the xassert test.
1514
1515 * dispextern.h (struct it): Update the comment documenting what
1516 can it->OBJECT be.
1517
8c203dbf
EZ
15182011-09-20 Eli Zaretskii <eliz@gnu.org>
1519
1520 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1521 a display string, extend search for cursor position to end of row.
1522 (find_row_edges): If the row ends in a newline from a display
1523 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1524 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
1525 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1526 non-empty line. Fixes confusing cursor motion with arrow keys at
1527 the beginning of a line that starts with whitespace.
8c203dbf 1528
a4824228
LMI
15292011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1530
1531 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1532 (bug#9493).
1533
33ed493b
CY
15342011-09-18 Chong Yidong <cyd@stupidchicken.com>
1535
1536 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1537 boolean (Bug#9154).
1538
56cd55c8
EZ
15392011-09-18 Eli Zaretskii <eliz@gnu.org>
1540
1541 * xdisp.c (display_line): Record maximum and minimum buffer
1542 positions even if no glyphs were produced (e.g., by a zero-width
1543 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1544 buffer positions that will be removed from the glyph row because
1545 they don't fit.
c02dcedf
EZ
1546 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1547 column is beyond frame width: don't subtract 1 "pixel" when
1548 computing width of the stretch.
3e62b7e0
EZ
1549 (reseat_at_next_visible_line_start): Undo the change made on
1550 2011-09-17 that saved paragraph information and restored it after
1551 the call to `reseat'. (Bug#9545)
56cd55c8 1552
5ed99d36 15532011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
1554
1555 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1556 and turn window cursor on if cleared (Bug#9415).
1557
5ed99d36 15582011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
1559
1560 * search.c (boyer_moore): Take unibyte characters from pattern
1561 literally. (Bug#9458)
1562
9bade7b2
EZ
15632011-09-18 Eli Zaretskii <eliz@gnu.org>
1564
1565 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1566
e5e9d610
PE
15672011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1568
87e4427a
PE
1569 Fix minor problem found by static checking.
1570 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1571 initialized, to pacify gcc -Wuninitialized.
1572
e5e9d610
PE
1573 * fileio.c: Report proper errno when syscall falls.
1574 (Finsert_file_contents): Save and restore errno,
1575 so that report_file_error outputs the correct diagnostic.
1576 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1577
a1674f0b
EZ
15782011-09-18 Eli Zaretskii <eliz@gnu.org>
1579
1580 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1581
fbfb6dd4
EZ
15822011-09-17 Eli Zaretskii <eliz@gnu.org>
1583
1584 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1585 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1586
bb187662
EZ
15872011-09-17 Eli Zaretskii <eliz@gnu.org>
1588
1137e8b8 1589 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 1590 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
1591
1592 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1593 (bidi_find_paragraph_start): Search back for paragraph beginning
1594 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1595 (bidi_move_to_visually_next): Only trigger paragraph-related
1596 computations when the last character is a newline or at EOB, not
1597 just any NEUTRAL_B. (Bug#9470)
1598
bb187662
EZ
1599 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1600 truncated lines if point is covered by a display string. (Bug#9524)
1601
2e621251
PE
16022011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1603
1604 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1605 (cons_to_x_long): New function.
1606 (lisp_data_to_selection_data): Use it. Correct the test for
1607 short-versus-long data; it was negated. Break out of vector
1608 loop, for efficiency, when a long datum is discovered.
1609
91a15bc6
SM
16102011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1611
1612 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1613
b41c3a35
EZ
16142011-09-16 Eli Zaretskii <eliz@gnu.org>
1615
1616 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1617 GCC PR/17406) by declaring this function with external scope.
1618
7812ba2d
PE
16192011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1620
1621 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1622 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1623
cf7edc2a
AS
16242011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1625
1626 * editfns.c (Fformat): Correctly handle text properties on "%%".
1627
bd01620e
EZ
16282011-09-15 Eli Zaretskii <eliz@gnu.org>
1629
1630 * xterm.c (x_draw_composite_glyph_string_foreground):
1631 * w32term.c (x_draw_composite_glyph_string_foreground):
1632 * term.c (encode_terminal_code):
1633 * composite.c (composition_update_it, get_composition_id):
1634 * xdisp.c (get_next_display_element)
1635 (fill_composite_glyph_string): Add comments about special meaning
1636 of TAB characters in a composition.
1637
a02719a3
PE
16382011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1639
1640 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
1641 This occurs when processing a multibyte format.
1642 Problem reported by Wolfgang Jenker.
a02719a3 1643
72589a3c
JB
16442011-09-15 Johan Bockgård <bojohan@gnu.org>
1645
1646 * xdisp.c (try_cursor_movement): Only check for exact match if
1647 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1648
1c14176c
PE
16492011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1650
1651 Remove unused external symbols.
1652 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1653 * xdisp.c (calc_pixel_width_or_height): Now static.
1654 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1655 * indent.c (check_display_width):
1656 * w32term.c: Fix comment to match code.
1657 * xterm.c, xterm.h (x_catching_errors): Remove.
1658
d2eea5b5
PE
16592011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1660
1661 * xselect.c: Use signed conversions more consistently (Bug#9498).
1662 (selection_data_to_lisp_data): Assume incoming selection data are
1663 signed integers, not unsigned. This is to be consistent with
1664 outgoing selection data, which was modified to use signed integers
1665 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1666 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1667 expects long, not unsigned long.
1668
46888499
EZ
16692011-09-14 Eli Zaretskii <eliz@gnu.org>
1670
1671 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1672 computation of loop end. Reported by Johan Bockgård
1673 <bojohan@gnu.org>.
1674
ef8ef9fb
CY
16752011-09-13 Chong Yidong <cyd@stupidchicken.com>
1676
1677 * frame.c (Fother_visible_frames_p): Function deleted.
1678
fa819fed
EZ
16792011-09-12 Eli Zaretskii <eliz@gnu.org>
1680
1681 * indent.c (compute_motion): Process display vector front to back
1682 rather than the other way around. (Bug#2496)
1683
2ba8e008
SM
16842011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1685
1686 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1687
20f53c69
CY
16882011-09-11 Chong Yidong <cyd@stupidchicken.com>
1689
1690 * minibuf.c (Fread_from_minibuffer): Doc fix.
1691
d562d7a4
EZ
16922011-09-11 Eli Zaretskii <eliz@gnu.org>
1693
1694 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1695 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1696
1c4d7f3d
LMI
16972011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1698
1699 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1700 value for non-existent files.
1701
b885bf36
EZ
17022011-09-11 Eli Zaretskii <eliz@gnu.org>
1703
1704 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1705 set its "size" to -1. This will set the modtime_size field of
1706 the corresponding buffer to -1, which is what
1707 verify-visited-file-modtime expects for files that do not exist.
1708 (Bug#9139)
1709
6612f0bf
PE
17102011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1711
1712 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1713 here ...
1714 * lisp.h: ... from here. push_key_description is no longer
1715 defined in keyboard.c, so its declaration should not be in
1716 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1717 logically belongs with push_key_description.
1718
dfb3f755
PE
17192011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1720
1721 * buffer.h: Include <sys/types.h> instead of <time.h>.
1722 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1723 Problem reported by Herbert J. Skuhra.
1724
3134906c
LMI
17252011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1726
1727 * xml.c (parse_region): Make the parsing work for
1728 non-comment-starting XML files again (bug#9144).
1729
8d903f4e
AS
17302011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1731
1732 * image.c (gif_load): Fix calculation of bottom and right corner.
1733 (Bug#9468)
1734
80ad64f4
EZ
17352011-09-10 Eli Zaretskii <eliz@gnu.org>
1736
1737 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1738 redisplay in small windows.
1739
208a048d
EZ
17402011-09-09 Eli Zaretskii <eliz@gnu.org>
1741
1742 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1743
9b1c252e
MR
17442011-09-08 Martin Rudalics <rudalics@gmx.at>
1745
1746 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1747 Operate on live windows only.
1748
2949f33b
JB
17492011-09-08 Juanma Barranquero <lekktu@gmail.com>
1750
1751 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1752
e08dcafd
EZ
17532011-09-07 Eli Zaretskii <eliz@gnu.org>
1754
1755 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1756 only under bidi iteration.
1757
115b96bd
JD
17582011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1759
1760 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1761
c8199d0f
PE
17622011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1763
1764 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1765 Without this fix, the command to link temacs failed due to an
1766 undefined symbol __builtin_isnan. This is because
1767 /usr/include/iso/math_c99.h #defines isnan(x) to
1768 __builtin_isnan(x), but the bundled gcc, which identifies itself
1769 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1770 a __builtin_isnan.
1771 * floatfns.c (isnan): #undef, and then #define to a clone of
1772 what's in data.c.
1773 (Fisnan): Always define, since it's always available now.
1774 (syms_of_floatfns): Always define isnan at the Lisp level.
1775
e39b275c 17762011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
1777
1778 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1779
b2db44d9 17802011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 1781
f4af5137 1782 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
1783 The previous code assumed that file offsets (off_t values) fit in
1784 EMACS_INT variables, which is not true on typical 32-bit hosts.
1785 The code messed up by falsely reporting buffer overflow in cases
1786 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1787 when "big" contains more than 2**29 bytes, even though this
1788 inserts just one byte and does not overflow the buffer.
1789 (Finsert_file_contents): Store file offsets as off_t
1790 values, not as EMACS_INT values. Check for overflow when
1791 converting between EMACS_INT and off_t. When checking for
1792 buffer overflow or for overlap, take the offsets into account.
1793 Don't use EMACS_INT for small values where int suffices.
1794 When checking for overlap, fix a typo: ZV was used where
1795 ZV_BYTE was intended.
1796 (Fwrite_region): Don't assume off_t fits into 'long'.
1797 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1798
ecfc0a49
MA
17992011-09-05 Michael Albinus <michael.albinus@gmx.de>
1800
1801 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1802
6511acf2 18032011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 1804
0999621a 1805 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
1806
1807 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 1808 (esprintf, exprintf, evxprintf): New functions.
62f19c19 1809 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 1810 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
1811 (modify_event_symbol): Do not assume that the length of
1812 name_alist_or_stem is safe to alloca and fits in int.
1813 (Fexecute_extended_command): Likewise for function name and binding.
1814 (Frecursion_depth): Wrap around reliably on integer overflow.
1815 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1816 since some callers pass EMACS_INT values.
1817 (Fsingle_key_description): Don't crash if symbol name contains more
1818 than MAX_ALLOCA bytes.
1819 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1820 (get_minibuffer): Arg is now EMACS_INT, not int.
1821 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 1822 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
1823 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1824
2be7d702
PE
1825 * dbusbind.c (signature_cat): New function.
1826 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
1827 Do not overrun buffer; instead, report string overflow.
1828
9d1df220
PE
1829 * dispnew.c (add_window_display_history): Don't overrun buffer.
1830 Truncate instead; this is OK since it's just a log.
1831
33ef5c64
PE
1832 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1833 even if the time zone offset is outlandishly large.
1834 Don't mishandle offset == INT_MIN.
1835
66c6fdd5
PE
1836 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1837 when creating daemon; the previous buffer-overflow check was incorrect.
1838
d749b01b
PE
1839 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1840 which has the guts of the old verror function.
1841
b5cd1905
PE
1842 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1843 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1844
6e1a67fb
PE
1845 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1846 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 1847 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 1848 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
1849 length of string rather than counting it via multiple sprintfs;
1850 that's simpler and more reliable.
c21721cc
PE
1851 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1852 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1853 sprintf, in case result does not fit in int.
1854
c57b67fc
PE
1855 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1856 (fontset_from_font): Print it.
1857
8a401434
PE
1858 * frame.c (tty_frame_count): Now printmax_t, not int.
1859 (make_terminal_frame, set_term_frame_name): Print it.
1860 (x_report_frame_params): In X, window IDs are unsigned long,
1861 not signed long, so print them as unsigned.
1862 (validate_x_resource_name): Check for implausibly long names,
1863 and don't assume name length fits in 'int'.
1864 (x_get_resource_string): Don't blindly alloca invocation name;
1865 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1866 not fit in int.
1867
6e1a67fb
PE
1868 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1869 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
1870 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1871
0df02bf3
PE
1872 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1873 Use esprintf, not sprintf, in case result does not fit in int.
1874
48e30793
PE
1875 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1876 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1877 it as a large positive number.
1878 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1879 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1880
a66ff6d8
PE
1881 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1882 in case result does not fit in int.
1883
aca216ff
PE
1884 * print.c (float_to_string): Detect width overflow more reliably.
1885 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1886 buffer overrun. Don't assume list length fits in 'int'. Treat
1887 print length of 0 as 0, not as infinity; to be consistent with other
1888 uses of print length in this function. Don't overflow print length
1889 index. Don't assume hash table size fits in 'long', or that
1890 vectorlike size fits in 'unsigned long'.
1891
31c286f7
PE
1892 * process.c (make_process): Use printmax_t, not int, to format
1893 process-name gensyms.
1894
55e5faa1
PE
1895 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1896
80f2e268
PE
1897 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1898 to avoid potential buffer overrun.
1899
670741ab
PE
1900 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1901 if X resource line is longer than 512 bytes.
1902
b7163a50
PE
1903 * xfns.c (x_window): Make sprintf buffer a bit bigger
1904 to avoid potential buffer overrun.
1905
ae58ff1f
PE
1906 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1907
c43c8a6a
PE
1908 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1909
3f8236f4
PE
19102011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1911
53e9fe90 1912 Integer overflow fixes for scrolling, etc.
6511acf2
PE
1913 Without these, Emacs silently mishandles large integers sometimes.
1914 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
1915 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1916
6511acf2
PE
1917 * xdisp.c (try_window_id): Check Emacs fixnum range before
1918 converting to 'int'.
806add1d 1919
6511acf2 1920 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
1921 Check that an Emacs fixnum is in range before assigning it to 'int'.
1922 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1923 values converted from Emacs fixnums.
1924 (Frecenter): Don't wrap around a line count if it is out of 'int'
1925 range; instead, treat it as an extreme value.
1926 (Fset_window_configuration, compare_window_configurations):
1927 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1928
6511acf2
PE
1929 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1930 that can exceed INT_MAX. Check that EMACS_INT value is in range
1931 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
1932 (match_limit): Don't assume that a fixnum can fit in 'int'.
1933
6511acf2 1934 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
1935 exceed INT_MAX.
1936
6511acf2 1937 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
1938 (Fvertical_motion): Don't wrap around LINES values that don't fit
1939 in 'int'. Instead, treat them as extreme values. This is good
1940 enough for windows, which can't have more than INT_MAX lines anyway.
1941
fcb901a7
LMI
19422011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1943
0f2f6b6d
LMI
1944 * Require libxml/parser.h to avoid compilation warning.
1945
fcb901a7
LMI
1946 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1947
1948 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1949 since this reportedly can destroy thread storage.
1950
6e20a0d4
CY
19512011-08-30 Chong Yidong <cyd@stupidchicken.com>
1952
1953 * syntax.c (find_defun_start): Update all cache variables if
1954 exiting early (Bug#9401).
1955
148ae00e
EZ
19562011-08-30 Eli Zaretskii <eliz@gnu.org>
1957
f6cfbd8f
EZ
1958 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1959
148ae00e
EZ
1960 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1961 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1962 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1963
1964 * term.c (tty_append_glyph): New function.
1965 (produce_stretch_glyph): Static function and its prototype deleted.
1966
a66cfb1c
SM
1967 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1968 Add prototypes.
148ae00e 1969
c4a07a4c
PE
19702011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1971
1972 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1973 when checking :margin (Bug#9390).
1974 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 1975 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
1976 so that the name doesn't mislead. All uses changed.
1977
6bc8cd65
JB
19782011-08-28 Johan Bockgård <bojohan@gnu.org>
1979
1980 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1981 set_tty_hooks.
1982
dca4927e
EZ
19832011-08-27 Eli Zaretskii <eliz@gnu.org>
1984
1985 * xdisp.c (move_it_to): Don't bail out early when reaching
1986 position beyond to_charpos, if we are scanning backwards.
1987 (move_it_vertically_backward): When DY == 0, make sure we get to
1988 the first character in the line after the newline.
1989
f2cad773
PE
19902011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1991
1992 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1993 (ccl_driver): Do not generate an out-of-range pointer.
1994 (Fccl_execute_on_string): Remove unnecessary check for
1995 integer overflow, noted by Stefan Monnier in
1996 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1997 Remove a FIXME that didn't need fixing.
1998 Simplify the newly-introduced buffer reallocation code.
1999
0cae2cdb
JB
20002011-08-27 Juanma Barranquero <lekktu@gmail.com>
2001
2002 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2003
5fc295a4 20042011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 2005
70c60eb2 2006 Integer and memory overflow issues (Bug#9196).
726e0ab1 2007
d31850da
PE
2008 * doc.c (get_doc_string): Rework so that
2009 get_doc_string_buffer_size is the actual buffer size, rather than
2010 being 1 less than the actual buffer size; this makes xpalloc more
2011 convenient.
2012
a69fbedb
PE
2013 * image.c (x_allocate_bitmap_record, cache_image):
2014 * xselect.c (Fx_register_dnd_atom):
2015 Simplify previous changes by using xpalloc.
2016
fe5c5d37
PE
2017 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2018 since either will do and ptrdiff_t is convenient with xpalloc.
2019
0065d054
PE
2020 * charset.c (charset_table_size)
2021 (struct charset_sort_data.priority): Now ptrdiff_t.
2022 (charset_compare): Don't overflow if priorities differ greatly.
2023 (Fsort_charsets): Don't assume list length fits in int.
2024 Check for size-calculation overflow when allocating sort data.
2025 (syms_of_charset): Allocate an initial charset table that is
2026 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2027
2028 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2029
2030 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2031 The actual value is always <= INT_MAX, and leaving it unsigned made
2032 overflow checking harder.
2033
2034 * dispextern.h (struct glyph_matrix.rows_allocated)
2035 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2036 with xpalloc. The values are still always <= INT_MAX.
2037
2038 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2039
2040 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2041 (SAFE_NALLOCA): New macro.
2042
2043 * region-cache.c (struct boundary.pos, find_cache_boundary)
2044 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2045 (set_cache_region, invalidate_region_cache)
2046 (revalidate_region_cache, know_region_cache, region_cache_forward)
2047 (region_cache_backward, pp_cache):
2048 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2049 so that ptrdiff_t * can be passed to xpalloc.
2050 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2051 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2052 (pp_cache): Don't assume cache_len fits in int.
2053 * region-cache.h: Adjust extern decls to match.
2054
2055 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2056 EMACS_INT, since either will do, for xpalloc.
2057
2058 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2059 (xnmalloc, xnrealloc, xpalloc): New functions.
2060
726e0ab1
PE
2061 * bidi.c (bidi_shelve_header_size): New constant.
2062 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2063 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2064
51f30bc5 2065 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
2066 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2067 (overlay_strings):
2068 Don't update size of array until after memory allocation succeeds,
2069 because xmalloc/xrealloc may not return.
0065d054
PE
2070 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2071 now that we have proper integer overflow checking.
2072 (record_overlay_string, overlay_strings): Catch overflows when
2073 calculating size of overlay_str_buf.
726e0ab1 2074
0065d054
PE
2075 * callproc.c (Fcall_process): Check for size overflow when
2076 calculating size of args2.
2077 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2078 Normally we prefer signed values, but sticking with ptrdiff_t would
2079 require adding more-complicated checks.
726e0ab1
PE
2080
2081 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2082 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2083 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 2084 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
2085
2086 * character.c (Fstring): Check for size-calculation overflow.
2087
2088 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2089 unnecessary integer overflow. Check for size overflow.
2090 (encode_coding_object): Don't update size until xmalloc succeeds.
2091
2092 * composite.c (get_composition_id): Check for overflow in glyph
2093 length calculations.
2094
2095 Integer and memory overflow fixes for display code.
2096 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2097 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2098 (scrolling_window): Check for overflow in size calculations.
2099 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2100 Don't assume glyph table len fits in int.
2101 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2102 (row_table_size): Now ptrdiff_t, not int.
2103 (scrolling_window): Avoid overflow in size calculations.
2104 Don't update size until allocation succeeds.
2105 * fns.c (concat): Check for overflow in size calculations.
2106 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2107 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2108 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2109
2110 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2111 (get_doc_string): Check for size calculation overflow.
2112 Don't update size until allocation succeeds.
2113 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2114 EMACS_INT, where ptrdiff_t will do.
2115 (Fsubstitute_command_keys): Check for string overflow.
2116
2117 * editfns.c (set_time_zone_rule): Don't assume environment length
2118 fits in int.
2119 (message_length): Now ptrdiff_t, not int.
2120 (Fmessage_box): Don't update size until allocation succeeds.
2121 Don't assume message length fits in int.
2122 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2123
0065d054
PE
2124 * emacs.c (main): Do not reallocate argv, since there is a null at
2125 the end that can be overwritten, and this way there's no need to
2126 worry about size-calculation overflow.
2127 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
2128
2129 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2130 alloc succeeds.
2131 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2132
2133 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2134 (x_set_scroll_bar_width, x_figure_window_size):
2135 Check for integer overflow.
2136 (x_set_alpha): Do not assume XINT fits in int.
2137
2138 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2139 This is for the members text_lines, text_cols, total_lines, total_cols,
2140 where the system imposes an 'int' limit.
2141
2142 * fringe.c (Fdefine_fringe_bitmap):
2143 Don't update size until alloc works.
2144
2145 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2146 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2147
2148 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2149 Check for size-calculation overflow.
2150 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2151 do, as we prefer signed integers.
2152 (id_to_widget.max_size, id_to_widget.used)
2153 (xg_store_widget_in_map, xg_remove_widget_from_map)
2154 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2155 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2156 Use and return ptrdiff_t, not int.
2157 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2158 * gtkutil.h: Change prototypes to match the above.
2159
2160 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2161 are duplicate now that they've been promoted to lisp.h.
2162 (x_allocate_bitmap_record, x_alloc_image_color)
2163 (make_image_cache, cache_image, xpm_load):
2164 Don't update size until alloc is done.
2165 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2166 (x_detect_edges):
3256efce 2167 Check for size calculation overflow.
726e0ab1
PE
2168 (ct_colors_allocated_max): New constant.
2169 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2170 overflow.
3256efce 2171
726e0ab1
PE
2172 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2173 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2174 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2175 Use ptrdiff_t, not int, to count maps.
2176 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
2177 calculations. Don't update size until allocation succeeds.
2178 Redo calculations to avoid overflow.
726e0ab1
PE
2179 * keyboard.h: Change prototypes to match the above.
2180
2181 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2182 to count maps.
2183 (current_minor_maps): Check for size calculation overflow.
2184 * keymap.h: Change prototypes to match the above.
2185
2186 * lread.c (read1, init_obarray): Don't update size until alloc done.
2187
2188 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2189 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2190
726e0ab1
PE
2191 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2192 Now ptrdiff_t, not int.
2193 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2194 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2195
2196 * process.c (Fnetwork_interface_list): Check for overflow
2197 in size calculation.
2198
2199 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2200
2201 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2202 overflow. Don't bother calling xmalloc when xrealloc will do.
2203
2204 * search.c (Freplace_match): Check for size calculation overflow.
2205 (Fset_match_data): Don't assume list lengths fit in 'int'.
2206
2207 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2208 for command line length. Do not attempt to address one before the
2209 beginning of an array, as that's not portable.
2210
2211 * term.c (max_frame_lines): Remove; unused.
2212 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2213 not int.
2214 (encode_terminal_code, calculate_costs): Check for size
2215 calculation overflow.
2216 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2217 table lengths and related sizes. Don't update size until alloc
2218 done. Redo calculations to avoid overflow.
2219 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2220
2221 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2222 subtracting pointers.
2223 (gobble_line): Check for overflow more carefully. Don't update size
2224 until alloc done.
2225
2226 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2227 Don't update size until alloc done.
2228 Redo size calculations to avoid overflow.
2229 Check for size calculation overflow.
0065d054 2230 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
2231
2232 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2233 Use ptrdiff_t, not int, for sizes.
2234 (store_mode_line_noprop_char): Don't update size until alloc done.
2235
0065d054
PE
2236 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2237 Use ptrdiff_t, not int, for sizes.
2238 (Finternal_make_lisp_face, cache_face):
2239 Check for size calculation overflow.
2240 (cache_face): Treat size calculation overflows as if they were
2241 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
2242
2243 * xfns.c (x_encode_text, x_set_name_internal)
2244 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2245 sizes, since they can exceed INT_MAX in size. Check for size
2246 calculation overflow.
2247
0065d054
PE
2248 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2249 (xg_select): Check for size calculation overflow.
726e0ab1
PE
2250 Don't update size until alloc done.
2251
0065d054 2252 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 2253 as sprintf is limited to int lengths.
1d526e2f 2254
252c5ee1
PE
2255 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2256 (X_LONG_MIN): New macros.
864d7ce7
PE
2257 Use them to make the following changes clearer.
2258 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2259 This change doesn't affect the value now, but it may help remind
2260 future maintainers not to raise the value too much later.
2261 (SELECTION_QUANTUM): Remove, replacing with ...
2262 (selection_quantum): ... new function, which avoids overflow.
2263 All uses changed.
2264 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2265 assumption that selection length fits in 'int'.
2266 (x_reply_selection_request, x_handle_selection_request)
2267 (x_get_window_property, receive_incremental_selection)
2268 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2269 (lisp_data_to_selection_data, clean_local_selection_data):
2270 Use ptrdiff_t, not int, to record length of selection.
2271 (x_reply_selection_request, x_get_window_property)
2272 (receive_incremental_selection, x_property_data_to_lisp):
2273 Redo calculations to avoid overflow.
2274 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 2275 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
2276 something.
2277 (x_get_window_property, receive_incremental_selection)
2278 (lisp_data_to_selection_data, x_property_data_to_lisp):
2279 Check for size-calculation overflow.
2280 (x_get_window_property, receive_incremental_selection)
2281 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2282 Don't store size until memory allocation succeeds.
2283 (x_get_window_property): Plug memory leak on memory exhaustion.
2284 Don't double-block input; malloc is safe here. Don't assume 2**34
2285 - 4 fits in unsigned long. Add an xassert to check
2286 XGetWindowProperty overflow. Be more careful about overflow
2287 calculations, and distinguish size from memory overflow better.
2288 (receive_incremental_selection): When tracing, don't assume
2289 unsigned int is less than INT_MAX.
2290 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2291 harmful) conversions of unsigned short to int.
2292 (lisp_data_to_selection_data): Don't assume that integers
2293 in the range -65535 through -1 fit in an X unsigned short.
2294 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2295 result parameters unless successful. Rely on cons_to_unsigned
2296 to report problems with elements; the old code wasn't right anyway.
2297 (x_check_property_data): Check for int overflow; we cannot use
2298 a wider type due to X limits.
2299 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2300
726e0ab1 2301 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 2302
0065d054
PE
2303 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2304 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
2305 (x_color_cells): Don't store size until memory allocation succeeds.
2306 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 2307 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
2308 (x_term_init): Don't assume length fits in int (sprintf is limited
2309 to int size).
bc18e09d 2310
ebfa62c0
PE
2311 Use ptrdiff_t for composition IDs.
2312 * character.c (lisp_string_width):
2313 * composite.c (composition_table_size, n_compositions)
2314 (get_composition_id, composition_gstring_from_id):
2315 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2316 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2317 * window.c (Frecenter):
2318 Use ptrdiff_t, not int, for composition IDs.
2319 * composite.c (get_composition_id): Check for integer overflow.
2320 * composite.h: Adjust prototypes to match the above changes.
2321
d3411f89
PE
2322 Use ptrdiff_t for hash table indexes.
2323 * category.c (hash_get_category_set):
2324 * ccl.c (ccl_driver):
2325 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2326 * coding.c (coding_system_charset_list, detect_coding_system):
2327 * coding.h (struct coding_system.id):
2328 * composite.c (get_composition_id, gstring_lookup_cache):
2329 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2330 * image.c (xpm_get_color_table_h):
2331 * lisp.h (hash_lookup, hash_put):
2332 * minibuf.c (Ftest_completion):
2333 Use ptrdiff_t for hash table indexes, not int (which is too
2334 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2335 32-bit --with-wide-int hosts).
2336
e097a6fa
PE
2337 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2338 Add a FIXME comment about memory leaks.
2339 (syms_of_charset): Don't assume xmalloc returns.
2340
5637687f
PE
2341 Don't assume that stated character widths fit in int.
2342 * character.c (Fchar_width, c_string_width, lisp_string_width):
2343 * character.h (CHAR_WIDTH):
2344 * indent.c (MULTIBYTE_BYTES_WIDTH):
2345 Use sanitize_char_width to avoid undefined and/or bad behavior
2346 with outlandish widths.
a66cfb1c 2347 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
2348 now that we have two such functions. All uses changed.
2349 (sanitize_char_width): New inline function.
2350
a2271ba2
PE
2351 Don't assume that tab-width fits in int.
2352 * character.h (sanitize_width): New inline function.
2353 (SANE_TAB_WIDTH): New macro.
2354 (ASCII_CHAR_WIDTH): Use it.
2355 * indent.c (sane_tab_width): Remove. All uses replaced by
2356 SANE_TAB_WIDTH (current_buffer).
2357 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2358
18c52557
PE
2359 * fileio.c: Integer overflow issues with file modes.
2360 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2361
caeeedc1
PE
2362 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2363 Remove unreachable code.
2364 (read_hex, load_charset_map_from_file): Check for integer overflow.
2365
50849c52
PE
2366 * xterm.c: don't go over XClientMessageEvent limit
2367 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2368 (x_send_scroll_bar_event): Likewise. Check that the size does not
2369 exceed limits imposed by XClientMessageEvent, as well as the usual
2370 ptrdiff_t and size_t limits.
2371
b13995db
PE
2372 * keyboard.c: Overflow, signedness and related fixes.
2373 (make_lispy_movement): Use same integer type in forward decl
2374 that is used in the definition.
2375 (read_key_sequence, keyremap_step):
2376 Change bufsize argument back to int, undoing my 2011-03-30 change.
2377 We prefer signed types, and int is wide enough here.
2378 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2379 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2380 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2381 length, not size_t. Use ptrdiff_t for index, not int.
2382 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2383 possibility of integer overflow.
2384
13464394
PE
2385 Overflow, signedness and related fixes for images.
2386
2387 * dispextern.h (struct it.stack[0].u.image.image_id)
2388 (struct_it.image_id, struct image.id, struct image_cache.size)
2389 (struct image_cache.used, struct image_cache.ref_count):
2390 * gtkutil.c (update_frame_tool_bar):
2391 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2392 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2393 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2394 * nsmenu.m (update_frame_tool_bar):
2395 * xdisp.c (calc_pixel_width_or_height):
2396 * xfns.c (image_cache_refcount):
2397 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2398 on typical 64-bit hosts.
2399
2400 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2401 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2402 Omit unnecessary casts to int.
2403 (parse_image_spec): Check that integers fall into 'int' range
2404 when the callers expect that.
2405 (image_ascent): Redo ascent calculation to avoid int overflow.
2406 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2407 (lookup_image): Remove unnecessary tests.
2408 (xbm_image_p): Locals are now of int, not EMACS_INT,
2409 since parse_image_check makes sure they fit into int.
2410 (png_load, gif_load, svg_load_image):
2411 Prefer int to unsigned where either will do.
2412 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
2413 old tiff_error_handler and tiff_warning_handler.
2414 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
2415 stack buffer overflows. It uses only the features of vsnprintf
2416 that are common to both POSIX and native Microsoft.
2417 (tiff_error_handler, tiff_warning_handler): Use it.
2418 (tiff_load, gif_load, imagemagick_load_image):
2419 Don't assume :index value fits in 'int'.
2420 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2421 (imagemagick_load_image): Check that crop parameters fit into
2422 the integer types that MagickCropImage accepts. Don't assume
2423 Vimagemagick_render_type has a nonnegative value. Don't assume
2424 size_t fits in 'long'.
2425 (gs_load): Use printmax_t to print the widest integers possible.
2426 Check for integer overflow when computing image height and width.
2427
c11821d4
EZ
24282011-08-26 Eli Zaretskii <eliz@gnu.org>
2429
2430 * xdisp.c (redisplay_window): Don't force window start if point
2431 will be invisible in the resulting window. (Bug#9324)
2432
0c95fcf7
EZ
24332011-08-25 Eli Zaretskii <eliz@gnu.org>
2434
2435 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2436 the display spec is of the form `(space ...)'.
2437 (handle_display_spec): Return the value returned by
2438 handle_single_display_spec, not just 1 or zero.
2439 (handle_single_display_spec): If the display spec is of the form
2440 `(space ...)', and specifies display in the text area, return 2
2441 rather than 1.
fee65a97 2442 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
2443 accurately, and prefer exact match for point under bidi.
2444 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
2445
2446 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2447 into disp_prop; all users changed.
2448
2449 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2450 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2451 for the text covered by the display property.
2452
e4ed06f1
CY
24532011-08-25 Chong Yidong <cyd@stupidchicken.com>
2454
2455 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2456 Change return value to nil.
2457 (Frecord_buffer): Delete unused function.
2458
f67cdd7f
EZ
24592011-08-24 Eli Zaretskii <eliz@gnu.org>
2460
5980d4c6
EZ
2461 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2462 buffers, return left-to-right.
8610fe8b
EZ
2463 (set_cursor_from_row): Consider candidate row a win if its glyph
2464 represents a newline and point is on that newline. Fixes cursor
2465 positioning on the newline at EOL of R2L text within L2R
2466 paragraph, and vice versa.
2467 (try_cursor_movement): Check continued rows, in addition to
2468 continuation rows. Fixes unwarranted scroll when point enters a
2469 continued line of R2L text within an L2R paragraph, or vice versa.
2470 (cursor_row_p): Consider the case of point being equal to
2471 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2472 from the end of a short line to the beginning of a continued line
2473 of R2L text within L2R paragraph.
2474 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2475 composed characters.
5980d4c6 2476
f67cdd7f
EZ
2477 * bidi.c (bidi_check_type): Use xassert.
2478 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2479 members.
2480
bca633fb
EZ
24812011-08-23 Eli Zaretskii <eliz@gnu.org>
2482
2483 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2484 a character.
2485
4a5885a7
CY
24862011-08-23 Chong Yidong <cyd@stupidchicken.com>
2487
2488 * nsfont.m (ns_otf_to_script): Fix typo.
2489
0902a04e
KH
24902011-08-22 Kenichi Handa <handa@m17n.org>
2491
2492 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2493 extra slot even if the purpose is char-code-property-table.
2494
1a2e6670
EZ
24952011-08-23 Eli Zaretskii <eliz@gnu.org>
2496
8ddde651
EZ
2497 * xdisp.c (redisplay_window): When computing centering_position,
2498 account for the height of the header line. (Bug#8874)
2499
425cc014
EZ
2500 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2501 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2502 candidate is selected by the mouse, and that candidate has a
2503 composed character under the mouse.
2504
1a2e6670
EZ
2505 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2506 coordinates reported by pos-visible-in-window-p for a composed
2507 character in column zero.
2508
8b76d6f8
SM
25092011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2510
2511 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2512
dac347dd
EZ
25132011-08-22 Eli Zaretskii <eliz@gnu.org>
2514
2515 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2516 consider it a hit if to_charpos is anywhere in the range of the
2517 composed buffer positions.
2518
e013fb34
CY
25192011-08-22 Chong Yidong <cyd@stupidchicken.com>
2520
2521 * image.c (gif_load): Don't assume that each subimage has the same
2522 dimensions as the base image. Handle disposal method that is
2523 "undefined" by the gif spec (Bug#9335).
2524
bd1ba3e8
CY
25252011-08-20 Chong Yidong <cyd@stupidchicken.com>
2526
2527 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 2528 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 2529
54a1215b
EZ
25302011-08-19 Eli Zaretskii <eliz@gnu.org>
2531
823564e5
EZ
2532 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2533 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2534 from an Org mode buffer to a Speedbar frame.
2535
54a1215b
EZ
2536 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2537 a composition, take its buffer position from IT->cmp_it.charpos.
2538 Fixes cursor positioning at the beginning of a line that begins
2539 with a composed character.
2540
9778ebcc
EZ
25412011-08-18 Eli Zaretskii <eliz@gnu.org>
2542
0be6ee06
EZ
2543 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2544 character bidirectional type, use STRONG_L instead. Fixes crashes
2545 in a buffer produced by `describe-categories'.
2546
9778ebcc
EZ
2547 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2548 members before the level stack, so they would be saved and
2549 restored when copying iterator state. Fixes incorrect reordering
2550 around TABs covered by display properties.
2551
156bffbe
AS
25522011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2553
6b02f655 2554 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 2555
72ad093b
CY
25562011-08-17 Chong Yidong <cyd@stupidchicken.com>
2557
2558 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
2559 (internal_condition_case_2, internal_condition_case_n):
2560 Remove unnecessary aborts (Bug#9081).
72ad093b 2561
35774242
EZ
25622011-08-17 Eli Zaretskii <eliz@gnu.org>
2563
2564 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2565 has no `load' handler, try opening the file locally. (Bug#9311)
2566
db76dd85
KB
25672011-08-16 Ken Brown <kbrown@cornell.edu>
2568
2569 * gmalloc.c: Expand comment.
2570
b215eee5
EZ
25712011-08-16 Eli Zaretskii <eliz@gnu.org>
2572
2573 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2574 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2575
a4579d33
KB
25762011-08-16 Ken Brown <kbrown@cornell.edu>
2577
2578 Fix memory allocation problems in Cygwin build (Bug#9273).
2579
2580 * unexcw.c ( __malloc_initialized): Declare external variable.
2581 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2582
8b76d6f8
SM
2583 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2584 New variables.
a4579d33
KB
2585 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2586 dumped emacs.
2587 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2588 in the static heap.
2589 [CYGWIN] (special_realloc): New function.
2590 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2591 requests to realloc storage in the static heap.
2592
3ebec551
PE
25932011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2594
2595 * bidi.c (bidi_initialize): Remove unused local.
2596
9fd8be00
EZ
25972011-08-15 Eli Zaretskii <eliz@gnu.org>
2598
6b02f655
SM
2599 * bidimirror.h:
2600 * biditype.h: Remove file.
2601 * makefile.w32-in ($(BLD)/bidi.$(O)):
2602 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
2603
2604 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2605
2606 * chartab.c: Improve commentary for the uniprop_table API.
2607
32413314
EZ
2608 * bidi.c (bidi_paragraph_init): Support zero value of
2609 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
2610 (bidi_initialize): Use uniprop_table instead of including
2611 biditype.h and bidimirror.h.
32413314 2612
9fd8be00
EZ
2613 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2614 coordinates of the iterator when restoring from ppos_it.
2615 (Bug#9296)
2616
5cf2b69b
KH
26172011-08-14 Kenichi Handa <handa@m17n.org>
2618
2619 * process.c (create_process): Call setup_process_coding_systems
72ad093b 2620 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 2621
daf17d00
EZ
26222011-08-14 Eli Zaretskii <eliz@gnu.org>
2623
2624 * xdisp.c (move_it_in_display_line_to): Don't invoke
2625 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2626 ppos_it. Fixes vertical cursor motion when line beginning is
2627 covered by an image. (Bug#9296)
2628
08e3161a
JD
26292011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2630
2631 * nsterm.h (ns_run_ascript): Declare.
2632 (NSAPP_DATA2_RUNASSCRIPT): Define.
2633
2634 * nsfns.m (as_script, as_result, as_status): New static variables.
2635 (ns_run_ascript): New function.
5e617bc2 2636 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
2637 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2638 the event loop. Get status from as_status (Bug#7276).
2639
2640 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2641 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2642 the event loop (Bug#7276).
2643
a3720aa2
AS
26442011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2645
2646 * gnutls.c (QCgnutls_bootprop_priority)
2647 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2648 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2649 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2650 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2651 (QCgnutls_bootprop_verify_hostname_error)
2652 (QCgnutls_bootprop_callbacks_verify): Rename from
2653 Qgnutls_bootprop_..., all uses changed.
2654
2655 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2656 uses changed.
2657
0a0d27fb
PE
26582011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2659
19d5c50c
PE
2660 * xfaces.c (Qframe_set_background_mode): Now static.
2661 * dispextern.h (Qframe_set_background_mode): Remove decl.
2662
0a0d27fb
PE
2663 * process.c (Fnetwork_interface_info): Declare local only if needed.
2664
377538cb
JD
26652011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2666
2667 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2668 (Fnetwork_interface_list): Allocate in increments of bytes instead
2669 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2670 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2671 sockaddr.
2672 (struct ifflag_def): notrailers is smart on OSX.
2673 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2674 Get hardware address with getifaddrs if available.
2675
08fff70c
EZ
26762011-08-12 Eli Zaretskii <eliz@gnu.org>
2677
2678 * xdisp.c (iterate_out_of_display_property): xassert that
2679 IT->position is set to within IT->object's boundaries. Break from
2680 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
2681 when IT->position is set up wrongly due to some bug.
2682 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
2683 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2684 entry. Force push_it to save on the stack the current
2685 buffer/string position, to be restored by pop_it. Fix flags in
2686 the iterator structure wrt the object coming from a display
2687 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2688 properties. (Bug#9284)
2689
7be1c708 26902011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 2691
7be1c708
CY
2692 * fontset.c (fontset_get_font_group): Add proper type checks.
2693 (Bug#9172)
aac0c6e3 2694
7be1c708 26952011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 2696
7be1c708
CY
2697 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2698 and LC_VERSION_MIN_MACOSX.
2699 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2700 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 2701
97bb72a6
EZ
27022011-08-08 Eli Zaretskii <eliz@gnu.org>
2703
2704 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
2705 no-display-properties-and-no-overlays under bidi display.
2706 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 2707 properties and overlays.
97bb72a6 2708
d5617611
CY
27092011-08-08 Chong Yidong <cyd@stupidchicken.com>
2710
37e11a63
CY
2711 * editfns.c (Fset_time_zone_rule): Document relationship with the
2712 setenv function.
2713
d5617611
CY
2714 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2715 the font entity extracted from the cache (Bug#8109).
2716
58872834
CY
27172011-08-07 Chong Yidong <cyd@stupidchicken.com>
2718
2719 * composite.c (autocmp_chars): Don't reset point. That is done by
2720 restore_point_unwind (Bug#5984).
2721
75bfc667
JL
27222011-08-07 Juri Linkov <juri@jurta.org>
2723
2724 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2725 to show the arg `TIME' instead of `TIMEVAL'.
2726
d1410150
EZ
27272011-08-06 Eli Zaretskii <eliz@gnu.org>
2728
2729 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2730 display property strides EOL and includes a newline, as in
2731 longlines-mode. (Bug#9254)
75b771e4
EZ
2732 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2733 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
2734
2735 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2736 is non-zero, even if the data buffer is NULL. Fixes a crash in
2737 vertical-motion with longlines-mode. (Bug#9254)
2738
35928349
EZ
27392011-08-05 Eli Zaretskii <eliz@gnu.org>
2740
ec7cc85b
EZ
2741 * bidi.c <bidi_cache_total_alloc>: Now static.
2742 (bidi_initialize): Initialize bidi_cache_total_alloc.
2743
8b76d6f8 2744 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
2745 cache. (Bug#9221)
2746
2747 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2748 amount allocated this far in `bidi_cache_total_alloc'.
2749 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2750 non-zero, only free the data buffer without restoring the cache
2751 contents. All callers changed.
2752
2753 * dispextern.h (bidi_unshelve_cache): Update prototype.
2754
2755 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2756 (move_it_in_display_line, move_it_to)
2757 (move_it_vertically_backward, move_it_by_lines): Replace the call
2758 to xfree to an equivalent call to bidi_unshelve_cache.
2759 (move_it_in_display_line_to): Fix logic of returning
412b6358 2760 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 2761
e2e2423b
EZ
27622011-08-05 Eli Zaretskii <eliz@gnu.org>
2763
2764 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2765 came from a string character with a `cursor' property. (Bug#9229)
2766
ae9e757a
JD
27672011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2768
2769 * Makefile.in (LIB_PTHREAD): New variable.
2770 (LIBES): Add LIB_PTHREAD (Bug#9216).
2771
2772 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2773 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2774
213bd7f2
AS
27752011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2776
6b02f655 2777 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 2778
99aaf75f
JD
27792011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2780
2781 * xterm.c (x_find_topmost_parent): New function.
2782 (x_set_frame_alpha): Find topmost parent window with
2783 x_find_topmost_parent and set the property there also (bug#9181).
2784 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2785
c74e9d86
PE
27862011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2787
2788 * callproc.c (Fcall_process): Avoid vfork clobbering
2789 the local vars buffer, coding_systems, current_dir.
2790
640c8776
SM
27912011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2792
2793 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2794
f26d0e4c
PE
27952011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2796
8a10d76c
PE
2797 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2798 so that it is not optimized away.
2799
f26d0e4c
PE
2800 * xdisp.c (compute_display_string_pos): Remove unused local.
2801
55439c61
EZ
28022011-08-02 Eli Zaretskii <eliz@gnu.org>
2803
2804 Fix slow cursor motion and scrolling in large buffers with
2805 selective display, like Org Mode buffers. (Bug#9218)
2806
2807 * dispextern.h (struct bidi_it): New member disp_prop_p.
2808
2809 * xdisp.c: Remove one-slot cache of display string positions.
2810 (compute_display_string_pos): Accept an additional argument
5e617bc2 2811 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
2812 for a display string or property. If found, set DISP_PROP_P
2813 non-zero.
2814
2815 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
2816 DISP_PROP_P, and pass it to compute_display_string_pos.
2817 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
2818 non-zero. All callers of bidi_fetch_char changed.
2819
fb33fa43
SM
28202011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2821
2822 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2823
b099e063
DM
28242010-12-03 Don March <don@ohspite.net>
2825
2826 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2827 last character M-[char] is translated to ESC [char] (bug#7541).
2828
5cc7f7af
KH
28292011-08-02 Kenichi Handa <handa@m17n.org>
2830
d0fffa3f 2831 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
2832
2833 * chartab.c (uniprop_table): Make it non-static.
2834
525d5e6e
EZ
28352011-08-01 Eli Zaretskii <eliz@gnu.org>
2836
2837 * xdisp.c (forward_to_next_line_start): Accept additional argument
2838 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2839 on the newline.
2840 (reseat_at_next_visible_line_start): Use the bidi iterator state
2841 returned by forward_to_next_line_start to restore the state of
2842 it->bidi_it after backing up to previous newline. (Bug#9212)
2843
31011111
AS
28442011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2845
2846 * regex.c (re_comp): Protoize.
2847 (re_exec): Fix return type.
2848 (regexec): Fix type of `ret'. (Bug#9203)
2849
476371c4
PE
28502011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2851
e5d76069
PE
2852 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2853 This is needed if max-image-size is a floating-point number.
2854
9a79b20c
AS
28552011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2856
2857 * print.c (print_object): Print empty symbol as ##.
2858
2859 * lread.c (read1): Read ## as empty symbol.
2860
d8c2fa78
AA
28612011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2862
2863 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2864 setting frame foreground color (Bug#9175).
2865 (x_set_background_color): Likewise.
2866
ffe57a7a
AA
2867 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2868 contents (Bug#9176).
2869 (EmacsTooltip -init): Remove bezels and add shadows to
2870 tooltip windows.
2871
bf3492a5
AA
2872 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2873 or scroll bar (Bug#8470).
2874
d55e9c53
AA
2875 * nsfont.m (nsfont_open): Remove assignment to voffset and
2876 unnecessary vars hshink, expand, hd, full_height, min_height.
2877 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2878
2879 * nsterm.h (nsfont_info): Remove voffset field.
2880
d8c2fa78 28812011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
2882
2883 Implement strike-through and overline on NextStep (Bug#8863).
2884
2885 * nsfont.m (nsfont_open): Use underline position provided by font,
2886 instead of hard-coded value of 2.
2887 (nsfont_draw): Call ns_draw_text_decoration instead.
2888
2889 * nsterm.h: Add declaration for ns_draw_text_decoration.
2890
2891 * nsterm.m (ns_draw_text_decoration): New function for drawing
2892 underline, overline, and strike-through.
2893 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2894 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 2895 accommodate underlining, etc.
4843aac3 2896
4cc60b9b
EZ
28972011-07-28 Eli Zaretskii <eliz@gnu.org>
2898
bc7ece87
EZ
2899 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2900 default.
4cc60b9b 2901
476371c4
PE
29022011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2903
66606eea
PE
2904 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2905 Without this fix, if a signal arrives just after memory fills up,
2906 'malloc' might be invoked reentrantly.
2907
476371c4
PE
2908 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2909 In other words, assume that every image size is allowed, on non-X
2910 hosts. This assumption is probably wrong, but it lets Emacs compile.
2911
f3fcc40d
AS
29122011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2913
2914 * regex.c (re_iswctype): Convert return values to boolean.
2915
350c992f
EZ
29162011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2917
2918 * xdisp.c (compute_display_string_pos): Don't use cached display
2919 string position if the buffer had its restriction changed.
2920 (Bug#9184)
2921
5266b4bb
PE
29222011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2923
2924 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2925
2573a837 29262011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 2927
41f55ccd 2928 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 2929
39e378da
PE
2930 * bidi.c: Integer size and overflow fixes.
2931 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2932 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2933 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2934 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2935 (bidi_find_other_level_edge):
2936 Use ptrdiff_t instead of EMACS_INT where either will do.
2937 This works better on 32-bit hosts configured --with-wide-int.
2938 (bidi_cache_ensure_space): Check for size-calculation overflow.
2939 Use % rather than repeated addition, for better worst-case speed.
2940 Don't set bidi_cache_size until after xrealloc returns, because it
2941 might not return.
2942 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
2943 (bidi_cache_ensure_space): Also check that the bidi cache size
2944 does not exceed that of the largest Lisp string or buffer. See Eli
2945 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 2946
5e927815
PE
2947 * alloc.c (__malloc_size_t): Remove.
2948 All uses replaced by size_t. See Andreas Schwab's note
2949 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2950
ca4aa935
PE
2951 * image.c: Improve checking for integer overflow.
2952 (check_image_size): Assume that f is nonnull, since
2953 it is always nonnull in practice. This is one less thing to
2954 worry about when checking for integer overflow later.
2955 (x_check_image_size): New function, which checks for integer
2956 overflow issues inside X.
2957 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2958 This removes the need for a memory_full check.
2959 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2960 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2961 (xbm_read_bitmap_data): Change locals back to 'int', since
2962 their values must fit in 'int'.
2963 (xpm_load_image, png_load, tiff_load):
2964 Invoke x_create_x_image_and_pixmap earlier,
2965 to avoid much needless work if the image is too large.
2966 (tiff_load): Treat overly large images as if
2967 x_create_x_image_and_pixmap failed, not as malloc failures.
2968 (gs_load): Use x_check_image_size.
2969
5f8f9cc2
PE
2970 * gtkutil.c: Omit integer casts.
2971 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2972 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2973
5adf60bc
PE
2974 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2975
c8907a93
PE
2976 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2977 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2978 would wrongly return t on a 64-bit host.
2979
e3c25c68
PE
2980 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2981 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2982 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2983 and therefore cause GCC to emit a bogus diagnostic in some cases.
2984
3f791afe
PE
2985 * image.c: Integer signedness and overflow and related fixes.
2986 This is not an exhaustive set of fixes, but it's time to
2987 record what I've got.
2988 (lookup_pixel_color, check_image_size): Remove redundant decls.
2989 (check_image_size): Don't assume that arbitrary EMACS_INT values
2990 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2991 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2992 (tiff_load, imagemagick_load_image):
2993 Check for overflow in size calculations.
2994 (x_create_x_image_and_pixmap): Remove unnecessary test for
2995 xmalloc returning NULL; that can't happen.
2996 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2997 (xpm_color_bucket): Use better integer hashing function.
2998 (xpm_cache_color): Don't possibly over-allocate memory.
2999 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3000 (gif_memory_source):
3001 Use ptrdiff_t, not int or size_t, to record sizes.
3002 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3003 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3004 either works, as we prefer signed integers.
3005 (tiff_read_from_memory, tiff_write_from_memory):
3006 Return tsize_t, not size_t, since that's what the TIFF API wants.
3007 (tiff_read_from_memory): Don't fail simply because the read would
3008 go past EOF; instead, return a short read.
3009 (tiff_load): Omit no-longer-needed casts.
3010 (Fimagemagick_types): Don't assume size fits into 'int'.
3011
3cc5a532
PE
3012 Improve hashing quality when configured --with-wide-int.
3013 * fns.c (hash_string): New function, taken from sxhash_string.
3014 Do not discard information about ASCII character case; this
3015 discarding is no longer needed.
3016 (sxhash-string): Use it. Change sig to match it. Caller changed.
3017 * lisp.h: Declare it.
3018 * lread.c (hash_string): Remove, since we now use fns.c's version.
3019 The fns.c version returns a wider integer if --with-wide-int is
3020 specified, so this should help the quality of the hashing a bit.
3021
b312a492
PE
3022 * emacs.c: Integer overflow minor fix.
3023 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3024 Define only if GNU_LINUX.
3025 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3026
dfd153ae
PE
3027 * dispnew.c: Integer signedness and overflow fixes.
3028 Remove unnecessary forward decls, that were a maintenance hassle.
3029 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3030 All uses changed.
3031 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3032 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3033 (prepare_desired_row, line_draw_cost):
3034 Use int, not unsigned, where either works.
3035 (save_current_matrix, restore_current_matrix):
3036 Use ptrdiff_t, not size_t, where either works.
3037 (init_display): Check for overflow more accurately, and without
3038 relying on undefined behavior.
3039
a81d11a3
PE
3040 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3041 Remove, replacing with the new symbols in lisp.h. All uses changed.
3042 * fileio.c (make_temp_name):
3043 * filelock.c (lock_file_1, lock_file):
3044 * xdisp.c (message_dolog):
3045 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3046 Use pMd etc. instead.
3047 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3048 replacing the pWIDE etc. symbols removed from editfns.c.
3049
3300e6fd
PE
3050 * keyboard.h (num_input_events): Now uintmax_t.
3051 This is (very slightly) less likely to mess up due to wraparound.
3052 All uses changed.
3053
fd05c7e9
PE
3054 * buffer.c: Integer signedness fixes.
3055 (alloc_buffer_text, enlarge_buffer_text):
3056 Use ptrdiff_t rather than size_t when either will do, as we prefer
3057 signed integers.
3058
903fe15d
PE
3059 * alloc.c: Integer signedness and overflow fixes.
3060 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3061 (__malloc_size_t): Default to size_t, not to int.
3062 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3063 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3064 Prefer ptrdiff_t to size_t when either would do, as we prefer
3065 signed integers.
3066 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3067 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3068 Now const. Initialize with values that are in range even if char
3069 is signed.
3070 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3071 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3072 These functions do the right thing with sizes > 2**32.
3073 (check_depth): Now ptrdiff_t, not int.
3074 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3075 Adjust to new way of storing sizes. Check for size overflow bugs
3076 in rest of code.
3077 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3078 slightly wrong anyway, as it missed one instance of
3079 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3080 (refill_memory_reserve): Omit needless cast to size_t.
3081 (mark_object_loop_halt): Mark as externally visible.
3082
ac82cc6a
PE
3083 * xselect.c: Integer signedness and overflow fixes.
3084 (Fx_register_dnd_atom, x_handle_dnd_message):
3085 Use ptrdiff_t, not size_t, since we prefer signed.
3086 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3087 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3088 x_dnd_atoms_size and x_dnd_atoms_length.
3089
c2d1e36d
PE
3090 * doprnt.c: Prefer signed to unsigned when either works.
3091 * eval.c (verror):
3092 * doprnt.c (doprnt):
3093 * lisp.h (doprnt):
3094 * xdisp.c (vmessage):
3095 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3096 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3097 prefer signed arithmetic to avoid comparison confusion.
3098 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3099 but is a bit tricky.
3100
0e926e56
PE
3101 Assume freestanding C89 headers, string.h, stdlib.h.
3102 * data.c, doprnt.c, floatfns.c, print.c:
3103 Include float.h unconditionally.
3104 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3105 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3106 * regex.c: Likewise for stddef.h, string.h.
3107 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3108 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3109 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3110 (STDC_HEADERS): Remove obsolete defines.
3111 * sysdep.c: Include limits.h unconditionally.
3112
9cfdb3ec
PE
3113 Assume support for memcmp, memcpy, memmove, memset.
3114 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3115 * regex.c (memcmp, memcpy):
3116 Remove; we assume C89 now.
3117
3118 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3119 (__malloc_safe_bcopy): Remove; no longer needed.
3120
cf950e6b 3121 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
3122 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3123 well either way, and we prefer signed to unsigned.
3124
dbf38e02
LMI
31252011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3126
3127 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3128 closes the connection while we're reading (bug#9182).
3129
d6f0886c 31302011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 3131
d6f0886c
JD
3132 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3133 are specified (Bug#9168).
24e0f6b1 3134
2eb1f9e6
PE
31352011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3136
3137 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3138 Found by GCC static checking and --with-wide-int on a 32-bit host.
3139
22381272 31402011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
3141
3142 * xdisp.c (compute_display_string_pos): Fix logic of caching
3143 previous display string position. Initialize cached_prev_pos to
3144 -1. Fixes slow-down at the beginning of a buffer.
3145
f25e39b4
EZ
31462011-07-24 Eli Zaretskii <eliz@gnu.org>
3147
3148 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3149 for attrs[LFACE_FONTSET_INDEX].
3150
04c4b52e
PE
31512011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3152
3153 * xml.c (parse_region): Remove unused local
3154 that was recently introduced.
3155
c1734fbd
EZ
31562011-07-23 Eli Zaretskii <eliz@gnu.org>
3157
be18c5a5
EZ
3158 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3159 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3160
c1734fbd
EZ
3161 * xdisp.c (move_it_in_display_line_to): Record the best matching
3162 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
3163 exit if none of the characters scanned was an exact match.
3164 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
3165 when exact match is impossible due to invisible text, and the
3166 lines are truncated.
3167
a258d627
JD
31682011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3169
3170 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3171 for OSX >= 10.7.
3172
b6d5a689
EZ
31732011-07-22 Eli Zaretskii <eliz@gnu.org>
3174
0f74f785
EZ
3175 Fix a significant slow-down of cursor motion with C-n, C-p,
3176 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3177 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 3178 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
3179 (next_element_from_buffer): Call compute_stop_pos_backwards to
3180 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
3181 base_level_stop.
3182 (reseat): Don't look for prev_stop, as that could mean a very long
3183 run.
3184 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3185 <cached_disp_overlay_modiff>: Cache for last found display string
3186 position.
551918c1 3187 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
3188 about the same buffer in the same area of character positions, and
3189 the buffer wasn't changed since the time the display string
3190 position was cached.
551918c1 3191
b2d0c91a
EZ
31922011-07-22 Eli Zaretskii <eliz@gnu.org>
3193
3194 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3195 is an integer, which is important for empty lines. (Bug#9149)
3196
043604ee
CY
31972011-07-22 Chong Yidong <cyd@stupidchicken.com>
3198
3199 * frame.c (Fmodify_frame_parameters): In tty case, update the
3200 default face if necessary (Bug#4238).
3201
da4adb04
CY
32022011-07-21 Chong Yidong <cyd@stupidchicken.com>
3203
3204 * editfns.c (Fstring_to_char): No need to explain what a character
3205 is in the docstring (Bug#6576).
3206
9abd0532
LMI
32072011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3208
3209 * xml.c (parse_region): Make sure we always return a tree.
3210
36881d16
HK
32112011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3212
3213 * xml.c (parse_region): If a document contains only comments,
3214 return that, too.
3215
1e98674d
LMI
32162011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3217
3218 * xml.c (make_dom): Return comments, too.
3219
590bd467
PE
32202011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3221
3222 Port to OpenBSD.
3223 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3224 and the surrounding thread.
3225 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3226 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3227 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3228 timer goes off.
3229 * s/openbsd.h (BROKEN_SIGIO): Define.
3230 * unexelf.c (unexec) [__OpenBSD__]:
3231 Don't update the .mdebug section of the Alpha COFF symbol table.
3232
f41628b2
LMI
32332011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3234
3235 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3236 (bug#8460).
3237
b59b67c5
PE
32382011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3239
15e3a074
PE
3240 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3241 This fixes some race conditions on the permissions of any newly
3242 created file.
3243
41bed37d
PE
3244 * alloc.c (valid_pointer_p): Use pipe, not open.
3245 This fixes some permissions issues when debugging.
3246
b59b67c5
PE
3247 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3248 If fchown fails to set both uid and gid, try to set just gid,
3249 as that is sometimes allowed. Adjust the file's mode to eliminate
3250 setuid or setgid bits that are inappropriate if fchown fails.
3251
925a6be7
SM
32522011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3253
3254 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3255 to compare Lisp_Objects.
3256 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3257 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3258 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3259
52968808
AS
32602011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3261
0a6a104b
AS
3262 * lread.c (read_integer): Unread even EOF character.
3263 (read1): Likewise. Properly record start position of symbol.
3264
52968808
AS
3265 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3266 symbol character follows.
3267
9e381cdd
PE
32682011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3269
3270 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3271 This works around a problem with the previous change to Fcopy_file.
3272 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3273 and without this change, GCC might complain about discarding
3274 fchown's return value.
3275
b5641435
JB
32762011-07-16 Juanma Barranquero <lekktu@gmail.com>
3277
3278 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3279
a8031457
PE
32802011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3281
3282 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3283
dd889327
LMI
32842011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3285
750c33f7
LMI
3286 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3287 it's used from the C level.
3288
dd889327
LMI
3289 * process.c: Use the same condition for POLL_FOR_INPUT in both
3290 keyboard.c and process.c (bug#1858).
3291
87e86684
LM
32922011-07-09 Lawrence Mitchell <wence@gmx.li>
3293
3294 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3295 (Fgnutls_boot): Use it.
3296
64348f40
AS
32972011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3298
3299 * doc.c (Fsubstitute_command_keys): Revert last change.
3300
1d698799
LMI
33012011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3302
f863868c
LMI
3303 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3304 quotes the next character, and doesn't affect other longer
3305 sequences (bug#8935).
3306
1d698799
LMI
3307 * lread.c (syms_of_lread): Clarify that is isn't only
3308 `eval-buffer' and `eval-defun' that's affected by
3309 `lexical-binding' (bug#8460).
3310
aa4b6df6
EZ
33112011-07-15 Eli Zaretskii <eliz@gnu.org>
3312
3313 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 3314 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 3315
5d856da6
PE
33162011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3317
ad6042bb
PE
3318 Fix minor problems found by static checking.
3319 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3320 (elsz): Now a signed constant, not a size_t var. We prefer signed
3321 types to unsigned, to avoid integer comparison confusion. Without
3322 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3323 "cannot optimize loop, the loop counter may overflow", a symptom
3324 of the confusion.
f00bbb22 3325 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
3326 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3327
6468f31c
LMI
33282011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3329
49080b10
LMI
3330 * search.c (Fre_search_backward): Mention `case-fold-search' in
3331 all the re_search_* functions (bug#8138).
3332
6468f31c
LMI
3333 * keyboard.c (Fopen_dribble_file): Document when the file is
3334 closed (bug#8056).
3335
c965adc5
EZ
33362011-07-14 Eli Zaretskii <eliz@gnu.org>
3337
df9733bf
EZ
3338 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3339 bidi_cache_idx.
3340
0bb23927
EZ
3341 Support bidi reordering of display and overlay strings.
3342 * xdisp.c (compute_display_string_pos)
3343 (compute_display_string_end): Accept additional argument STRING.
3344 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3345 (reseat_to_string): Initialize bidi_it->string.s and
3346 bidi_it->string.schars.
3347 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
3348 NULL (avoids a crash in bidi_paragraph_init).
3349 Initialize itb.string.lstring.
0bb23927
EZ
3350 (init_iterator): Call bidi_init_it only of a valid
3351 buffer position was specified. Initialize paragraph_embedding to
3352 L2R.
3353 (reseat_to_string): Initialize the bidi iterator.
3354 (display_string): If we need to ignore text properties of
3355 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3356 original value of -1 will not work with bidi.)
3357 (compute_display_string_pos): First arg is now struct
3358 `text_pos *'; all callers changed. Support display properties on
3359 Lisp strings.
3360 (compute_display_string_end): Support display properties on Lisp
3361 strings.
3362 (init_iterator, reseat_1, reseat_to_string): Initialize the
3363 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3364 when iterating on a string not from display properties).
640c8776
SM
3365 (compute_display_string_pos, compute_display_string_end):
3366 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
3367 arrow keys.
3368 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
3369 base_level_stop; instead, set base_level_stop to BEGV.
3370 Fixes crashes in vertical-motion.
0bb23927
EZ
3371 (next_element_from_buffer): Improve commentary for when
3372 the iterator is before prev_stop.
3373 (init_iterator): Initialize bidi_p from the default value of
3374 bidi-display-reordering, not from buffer-local value. Use the
3375 buffer-local value only if initializing for buffer iteration.
3376 (handle_invisible_prop): Support invisible properties on strings
3377 that are being bidi-reordered.
3378 (set_iterator_to_next): Support bidi reordering of C strings and
3379 Lisp strings.
3380 (next_element_from_string): Support bidi reordering of Lisp
3381 strings.
3382 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
3383 (display_string): Support display of R2L glyph rows.
3384 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
3385 (init_iterator): Don't initialize it->bidi_p for strings
3386 here.
3387 (reseat_to_string): Initialize it->bidi_p for strings here.
3388 (next_element_from_string, next_element_from_c_string)
3389 (next_element_from_buffer): Add xassert's for correspondence
3390 between IT's object being iterated and it->bidi_it.string
3391 structure.
3392 (face_before_or_after_it_pos): Support bidi iteration.
3393 (next_element_from_c_string): Handle the case of the first string
3394 character that is not the first one in the visual order.
3395 (get_visually_first_element): New function, refactored from common
3396 parts of next_element_from_buffer, next_element_from_string, and
3397 next_element_from_c_string.
3398 (tool_bar_lines_needed, redisplay_tool_bar)
3399 (display_menu_bar): Force left-to-right direction. Add a FIXME
3400 comment for making that be controlled by a user option.
3401 (push_it, pop_it): Save and restore the state of the
3402 bidi iterator. Save and restore the bidi_p flag.
3403 (pop_it): Iterate out of display property for string iteration as
3404 well.
3405 (iterate_out_of_display_property): Support iteration over strings.
3406 (handle_single_display_spec): Set up it->bidi_it for iteration
3407 over a display string, and call bidi_init_it.
3408 (handle_single_display_spec, next_overlay_string)
3409 (get_overlay_strings_1, push_display_prop): Set up the bidi
3410 iterator for displaying display or overlay strings.
3411 (forward_to_next_line_start): Don't use the shortcut if
3412 bidi-iterating.
3413 (back_to_previous_visible_line_start): If handle_display_prop
3414 pushed the iterator stack, restore the internal state of the bidi
3415 iterator by calling bidi_pop_it same number of times.
3416 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3417 and we are bidi-iterating, don't decrement the iterator position;
3418 instead, set the first_elt flag in the bidi iterator, to produce
3419 the same effect.
3420 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3421 (push_display_prop): xassert that we are iterating a buffer.
3422 (push_it, pop_it): Save and restore paragraph_embedding member.
3423 (handle_single_display_spec, next_overlay_string)
3424 (get_overlay_strings_1, reseat_1, reseat_to_string)
3425 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3426 correctly. Don't assume unibyte strings are not bidi-reordered.
3427 (compute_display_string_pos)
3428 (compute_display_string_end): Fix handling the case of C string.
3429 (push_it, pop_it): Save and restore from_disp_prop_p.
3430 (handle_single_display_spec, push_display_prop): Set the
3431 from_disp_prop_p flag.
3432 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3433 (pop_it): Call iterate_out_of_display_property only if we are
3434 popping after iteration over a string that came from a display
3435 property. Fix a typo in popping stretch info. Add an assertion
3436 for verifying that the iterator position is in sync with the bidi
3437 iterator.
3438 (handle_single_display_spec, get_overlay_strings_1)
3439 (push_display_prop): Fix initialization of paragraph direction for
3440 string when that of the parent object is not yet determined.
3441 (reseat_1): Call bidi_init_it to resync the bidi
3442 iterator with IT's position. (Bug#7616)
3443 (find_row_edges): If ROW->start.pos gives position
3444 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3445 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3446 Reset the from_disp_prop_p flag.
3447 (SAVE_IT, RESTORE_IT): New macros.
3448 (pos_visible_p, face_before_or_after_it_pos)
3449 (back_to_previous_visible_line_start)
3450 (move_it_in_display_line_to, move_it_in_display_line)
3451 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3452 (try_scrolling, redisplay_window, display_line): Use them when
3453 saving a temporary copy of the iterator and restoring it back.
3454 (back_to_previous_visible_line_start, reseat_1)
3455 (init_iterator): Empty the bidi cache "stack".
3456 (move_it_in_display_line_to): If iterator ended up at
3457 EOL, but we never saw any buffer positions smaller than
3458 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3459 motion in bidi-reordered lines.
3460 (move_it_in_display_line_to): Record prev_method and prev_pos
3461 immediately before the call to set_iterator_to_next. Fixes cursor
3462 motion in bidi-reordered lines with stretch glyphs and strings
3463 displayed in margins. (Bug#8133) (Bug#8867)
3464 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3465 TO_CHARPOS.
640c8776
SM
3466 (pos_visible_p): Support positions in bidi-reordered lines.
3467 Save and restore bidi cache.
0bb23927
EZ
3468
3469 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3470 (bidi_paragraph_info): Delete unused struct.
3471 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3472 (bidi_cache_start): New variable.
3473 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3474 to zero.
3475 (bidi_cache_fetch_state, bidi_cache_search)
3476 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3477 (bidi_cache_find, bidi_peek_at_next_level)
3478 (bidi_level_of_next_char, bidi_find_other_level_edge)
3479 (bidi_move_to_visually_next): Compare cache index with
3480 bidi_cache_start rather than with zero.
3481 (bidi_fetch_char): Accept new argument STRING; all callers
3482 changed. Support iteration over a string. Support strings with
3483 display properties. Support unibyte strings. Fix the type of
3484 `len' according to what STRING_CHAR_AND_LENGTH expects.
3485 (bidi_paragraph_init, bidi_resolve_explicit_1)
3486 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
3487 (bidi_level_of_next_char, bidi_move_to_visually_next):
3488 Support iteration over a string.
0bb23927
EZ
3489 (bidi_set_sor_type, bidi_resolve_explicit_1)
3490 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3491 can now be zero (for strings); special values 0 and -1 were
3492 changed to -1 and -2, respectively.
3493 (bidi_char_at_pos): New function.
3494 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3495 Call it instead of FETCH_MULTIBYTE_CHAR.
3496 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3497 initialized to valid values.
3498 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3499 values.
3500 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3501 the test for valid cached positions. Fix the logic for looking up
3502 the sentinel state in the cache. GCPRO the Lisp string we are
3503 iterating.
3504 (bidi_push_it, bidi_pop_it): New functions.
3505 (bidi_initialize): Initialize the bidi cache start stack pointer.
3506 (bidi_cache_ensure_space): New function, refactored from part of
3507 bidi_cache_iterator_state. Don't assume the required size is just
3508 one BIDI_CACHE_CHUNK away.
3509 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3510 (bidi_count_bytes, bidi_char_at_pos): New functions.
3511 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3512 always valid if bidi_cache_idx is valid.
3513 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3514 is valid if it's going to be used.
3515 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3516 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
3517 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3518 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
3519 (bidi_find_other_level_edge, bidi_cache_start_stack):
3520 All variables related to cache indices are now EMACS_INT.
c965adc5 3521
0bb23927
EZ
3522 * dispextern.h (struct bidi_string_data): New structure.
3523 (struct bidi_it): New member `string'. Make flag members be 1-bit
3524 fields, and put them last in the struct.
640c8776
SM
3525 (compute_display_string_pos, compute_display_string_end):
3526 Update prototypes.
0bb23927
EZ
3527 (bidi_push_it, bidi_pop_it): Add prototypes.
3528 (struct iterator_stack_entry): New members bidi_p,
3529 paragraph_embedding, and from_disp_prop_p.
3530 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
3531 (bidi_shelve_cache, bidi_unshelve_cache):
3532 Declare prototypes.
0bb23927
EZ
3533
3534 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3535 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3536 and vector-like objects.
3537
3538 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3539 cache around display iteration.
3540
3541 * window.c (Fwindow_end, window_scroll_pixel_based)
3542 (displayed_window_lines, Frecenter): Save and restore the bidi
3543 cache around display iteration.
3544
3bbd2265
LMI
35452011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3546
3547 * editfns.c (Fdelete_region): Clarify the use of the named
3548 parameters (bug#6788).
3549
adc47434
MR
35502011-07-14 Martin Rudalics <rudalics@gmx.at>
3551
3552 * indent.c (Fvertical_motion): Set and restore w->pointm when
3553 saving and restoring the window's buffer (Bug#9006).
3554
837c31f8
LMI
35552011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3556
3557 * editfns.c (Fstring_to_char): Clarify just what is returned
3558 (bug#6576). Text by Eli Zaretskii.
3559
ac389d0c
JB
35602011-07-13 Juanma Barranquero <lekktu@gmail.com>
3561
3562 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3563
0be0ce47
EZ
35642011-07-13 Eli Zaretskii <eliz@gnu.org>
3565
3566 * buffer.c (mmap_find): Fix a typo.
3567
cd18e7e3
JB
35682011-07-13 Johan Bockgård <bojohan@gnu.org>
3569
3570 Fix execution of x selection hooks.
3571 * xselect.c (Qx_lost_selection_functions)
3572 (Qx_sent_selection_functions): New vars.
3573 (syms_of_xselect): DEFSYM them.
3574 (x_handle_selection_request): Pass Qx_sent_selection_functions
3575 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3576 (x_handle_selection_clear,x_clear_frame_selections):
3577 Pass Qx_lost_selection_functions rather than
3578 Vx_lost_selection_functions to Frun_hook_with_args.
3579
47ea7f44
PE
35802011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3581
ac389d0c 3582 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
3583 The old code sometimes used this field without initializing it.
3584
47ea7f44
PE
3585 * alloc.c (gc_sweep): Don't read past end of array.
3586 In theory, the old code could also have corrupted Emacs internals,
3587 though it'd be very unlikely.
3588
bc985c87
AS
35892011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3590
3591 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 3592 argument. (Bug#4026)
bc985c87 3593
0cf34688
LMI
35942011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3595
b3dadd76
LMI
3596 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3597 key" (bug#4257).
3598
0cf34688
LMI
3599 * window.c (Fset_window_start): Doc fix (bug#4199).
3600 (Fset_window_hscroll): Ditto.
3601
270768cd
PE
36022011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3603
077e3dda 3604 Fix minor new problems caught by GCC 4.6.1.
270768cd 3605 * term.c (init_tty): Remove unused local.
490011a6 3606 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 3607 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 3608 not used otherwise.
270768cd 3609
b1f58454
CY
36102011-07-12 Chong Yidong <cyd@stupidchicken.com>
3611
3612 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3613
22b9578d
LMI
36142011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3615
6e70ab07
LMI
3616 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3617 are the mini-buffer and the echo area (bug#3320).
3618
22b9578d
LMI
3619 * term.c (init_tty): Remove support for supdup, c10 and perq
3620 terminals, which are no longer supported (bug#1482).
3621
8974cc9f
JB
36222011-07-10 Johan Bockgård <bojohan@gnu.org>
3623
3624 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3625
a560d974
JD
36262011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3627
3628 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3629 for non-popups (Bug#3642).
3630
1dae0f0a
AS
36312011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3632
268c2c36 3633 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 3634 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
3635 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3636 * cm.c (losecursor): Likewise.
1dae0f0a
AS
3637 * data.c (fmod): Likewise.
3638 * dispnew.c (swap_glyphs_in_rows): Likewise.
3639 * emacs.c (memory_warning_signal): Likewise.
3640 * floatfns.c (float_error): Likewise.
3641 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3642 (otf_open, font_otf_capability, generate_otf_features)
3643 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3644 Likewise.
3645 * image.c (pbm_read_file): Likewise.
3646 * indent.c (string_display_width): Likewise.
3647 * intervals.c (check_for_interval, search_for_interval)
3648 (inc_interval_count, count_intervals, root_interval)
3649 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3650 * lread.c (defalias): Likewise.
268c2c36 3651 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
3652 * regex.c (set_image_of_range_1, set_image_of_range)
3653 (regex_grow_registers): Likewise.
3654 * sysdep.c (strerror): Likewise.
3655 * termcap.c (valid_filename_p, tprint, main): Likewise.
3656 * tparam.c (main): Likewise.
3657 * unexhp9k800.c (run_time_remap, save_data_space)
3658 (update_file_ptrs, read_header, write_header, calculate_checksum)
3659 (copy_file, copy_rest, display_header): Likewise.
3660 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3661 Likewise.
3662 * xdisp.c (check_it): Likewise.
3663 * xfaces.c (register_color, unregister_color, unregister_colors):
3664 Likewise.
3665 * xfns.c (print_fontset_result): Likewise.
3666 * xrdb.c (member, fatal, main): Likewise.
3667
99033785
PE
36682011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3669
3670 Fix minor problems found by static checking (Bug#9031).
3671 * chartab.c (char_table_set_range, map_sub_char_table):
3672 Remove unused locals.
3673 (uniprop_table): Now static.
3674 * composite.c (_work_char): Remove unused static var.
3675
9cb2ac56
JB
36762011-07-09 Juanma Barranquero <lekktu@gmail.com>
3677
3678 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3679
f25661f0
JD
36802011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3681
3682 * gtkutil.c (qttip_cb): Remove code without function.
3683
8278c4fe
EZ
36842011-07-09 Eli Zaretskii <eliz@gnu.org>
3685
3686 * w32.c (pthread_sigmask): New stub.
3687
1692ae2d 36882011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 3689
8a6ebd58 3690 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
3691 sigprocmask is portable only for single-threaded applications, and
3692 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
3693 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3694 (LIBES): Use it.
3695 * callproc.c (Fcall_process):
3696 * process.c (create_process):
3697 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3698 Use pthread_sigmask, not sigprocmask.
123403e4 3699
1b854618
JD
37002011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3701
3702 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3703 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3704 wrong (Bug#8591).
3705
3fe4b549
JD
37062011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3707
0ce7e563
JD
3708 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3709 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3710 (xg_hide_tooltip): Fix comment.
3711
3fe4b549
JD
3712 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3713 in registerServicesMenuSendTypes.
3714 (validRequestorForSendType): Don't check ns_return_types.
3715
3716 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3717 ns_return_type.
3718
5df75e47
JR
37192011-07-08 Jason Rumney <jasonr@gnu.org>
3720
22610910
JR
3721 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3722 SH_SHOW for hidden windows (Bug#5482).
3723
5df75e47
JR
3724 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3725 frame struct members of non-existent frames (Bug#6284).
3726
699c10bd
JD
37272011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3728
4393663b
JD
3729 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3730 variable firstTime not needed on OSX >= 10.6.
3731 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3732 >= 10.5. Use setKnobProportion, setDoubleValue.
3733
3734 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3735 (MAC_OS_X_VERSION_10_5): Define if not defined.
3736 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3737 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3738 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3739
3740 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3741 cString and lossyCString on OSX >= 10.4
3742
58179cce 3743 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
3744 sizeToFit on OSX >= 10.2.
3745
3746 * nsimage.m (allocInitFromFile): Don't use deprecated method
3747 bestRepresentationForDevice on OSX >= 10.6.
3748
3749 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3750 to avoid warning.
3751
3752 * emacs.c: Declare unexec_init_emacs_zone.
3753
a63e0781
JD
3754 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3755
699c10bd
JD
3756 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3757
3758 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3759 on svcsMenu (Bug#8842).
3760
3761 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3762 ns_return_types.
3763 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3764
3765 * nsterm.m (QUTF8_STRING): Declare.
3766 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3767 (validRequestorForSendType): Return type is (id).
3768 Change indexOfObjectIdenticalTo to indexOfObject.
3769 Check if we have local selection before returning self (Bug#8842).
3770 (writeSelectionToPasteboard): Put local selection into paste board
3771 if we have a local selection (Bug#8842).
3772 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3773
3774 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3775 (ns_get_local_selection): Declare.
3776
54e10184
LMI
37772011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3778
9888ff71
LMI
3779 * keymap.c (describe_map_tree): Don't insert a double newline at
3780 the end of the buffer (bug#1169) and return whether we inserted
3781 something.
3782
54e10184
LMI
3783 * callint.c (Fcall_interactively): Change "reading args" to
3784 "providing args" to try to clarify what it does (bug#1010).
3785
15fa4783
KH
37862011-07-07 Kenichi Handa <handa@m17n.org>
3787
3788 * composite.c (composition_compute_stop_pos): Ignore a static
3789 composition starting before CHARPOS (Bug#8915).
3790
3791 * xdisp.c (handle_composition_prop): Likewise.
3792
a8815b00
EZ
37932011-07-07 Eli Zaretskii <eliz@gnu.org>
3794
3795 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3796 (Bug#9015)
3797
ef7b981d 37982011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
3799
3800 * character.h (unicode_category_t): New enum type.
3801
3802 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3803 (Qchar_code_property_table): New variable.
3804 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3805 (UNIPROP_COMPRESSED_FORM_P): New macros.
3806 (char_table_ascii): Uncompress the compressed values.
3807 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3808 Uncompress the compressed values.
ac389d0c 3809 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
3810 (char_table_ref_and_range): Uncompress the compressed values.
3811 (sub_char_table_set): New arg is_uniprop. Callers changed.
3812 Uncompress the compressed values.
3813 (sub_char_table_set_range): Args changed. Callers changed.
3814 (char_table_set_range): Adjuted for the above change.
3815 (map_sub_char_table): Delete args default_val and parent. Add arg
3816 top. Give decoded values to a Lisp function.
640c8776 3817 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
3818 values to a Lisp function. Gcpro more variables.
3819 (uniprop_table_uncompress)
3820 (uniprop_decode_value_run_length): New functions.
3821 (uniprop_decoder, uniprop_decoder_count): New variables.
3822 (uniprop_get_decoder, uniprop_encode_value_character)
3823 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3824 New functions.
3825 (uniprop_encoder, uniprop_encoder_count): New variables.
3826 (uniprop_get_encoder, uniprop_table)
3827 (Funicode_property_table_internal, Fget_unicode_property_internal)
3828 (Fput_unicode_property_internal): New functions.
3829 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3830 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 3831 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
3832 char-code-property-alist.
3833
640c8776 3834 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
3835 Vunicode_category_table.
3836
640c8776 3837 * font.c (font_range): Adjust for the change of
c805dec0
KH
3838 Vunicode_category_table.
3839
76b397fb
DN
38402011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3841
3842 * m/iris4d.h: Remove file, move contents ...
3843 * s/irix6-5.h: ... here.
3844
22b4128e
PE
38452011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3846
3847 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
3848 * alloc.c (mark_buffer):
3849 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3850 (clone_per_buffer_values): Don't assume that
22b4128e
PE
3851 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3852 This isn't true in general, and it's particularly not true
3853 if Emacs is configured with --with-wide-int.
3854 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3855 New macros, used in the buffer.c change.
3856
869795d6
JD
38572011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3858
3859 * xsettings.c: Use both GConf and GSettings if both are available.
3860 (store_config_changed_event): Add comment.
3861 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3862 (store_tool_bar_style_changed): New functions.
5e617bc2 3863 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
3864 (struct xsettings): Move font inside HAVE_XFT.
3865 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 3866 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 3867 Move inside HAVE_XFT.
640c8776 3868 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
3869 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3870 also.
3871 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 3872 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 3873 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
3874 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3875 (parse_settings): Move check for font inside HAVE_XFT.
3876 (read_settings, apply_xft_settings): Add comment.
3877 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3878 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3879 call store_font_name_changed.
3880 (xft_settings_event): Add comment.
3881 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3882 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3883 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3884 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3885 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
3886 (xsettings_get_system_font, xsettings_get_system_normal_font):
3887 Add comment.
869795d6 3888
d8ed26bd
PE
38892011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3890
3891 Random fixes. E.g., (random) never returned negative values.
3892 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3893 subseconds part to the entropy, as that's a bit more random.
3894 Prefer signed to unsigned, since the signedness doesn't matter and
3895 in general we prefer signed. When given a limit, use a
3896 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3897 latter isn't right if USE_2_TAGS_FOR_INTS.
3898 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3899 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3900
cabf1cac
SM
39012011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3902
3903 * textprop.c (text_property_stickiness):
3904 Obey Vtext_property_default_nonsticky.
3905 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3906 * w32fns.c (syms_of_w32fns):
3907 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3908
6e9b2be9
PE
39092011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3910
3911 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3912 This is more efficient than Ffile_directory_p and avoids a minor race.
3913
90186c68
LMI
39142011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3915
7c301272
LMI
3916 * buffer.c (Foverlay_put): Say what the return value is
3917 (bug#7835).
3918
c4f2d8d4
LMI
3919 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3920 is a directory before asking whether to use the file name
3921 (bug#7564).
ad637907
LMI
3922 (barf_or_query_if_file_exists): Make the "File is a directory"
3923 error be more correct.
c4f2d8d4 3924
90186c68
LMI
3925 * fns.c (Frequire): Remove the mention of the .gz files, since
3926 that's installation-specific, but keep the mention of
3927 `get-load-suffixes'.
3928
da64016e
PE
39292011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3930
3931 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3932 Report string overflow if the output is too long.
3933
7d47b580
JB
39342011-07-04 Juanma Barranquero <lekktu@gmail.com>
3935
a555cb87
JB
3936 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3937 (syms_of_gnutls): Remove duplicate DEFSYM for
3938 Qgnutls_bootprop_verify_hostname_error, an error for
3939 Qgnutls_bootprop_verify_error (which is no longer used).
3940
7d47b580
JB
3941 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3942 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3943 Also (re)move comments that are misplaced or no longer relevant.
3944
1e49bfab
LMI
39452011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3946
3947 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3948
1485f4c0
CY
39492011-07-03 Chong Yidong <cyd@stupidchicken.com>
3950
3951 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3952 and background color parameters if they have been changed.
3953
a9ab721e
LMI
39542011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3955
3956 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3957
cf7cff57
PE
39582011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3959
2e13213d
PE
3960 * xsettings.c (SYSTEM_FONT): Define only when used.
3961 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3962
cf7cff57
PE
3963 * keymap.c (access_keymap_1): Now static.
3964
7a8e04f7
CY
39652011-07-02 Chong Yidong <cyd@stupidchicken.com>
3966
3967 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3968 leave any prefix arg for the up event (Bug#1586).
3969
61352f62
LMI
39702011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3971
69bb1ef7
LMI
3972 * lread.c (syms_of_lread): Mention single symbols defined by
3973 `defvar' or `defconst' (bug#7154).
3974
61352f62 3975 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 3976 (Frequire): Mention get-load-suffixes.
61352f62 3977
28545e04
MR
39782011-07-02 Martin Rudalics <rudalics@gmx.at>
3979
3980 * window.h (window): Remove clone_number slot.
3981 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3982 Remove.
3983 (make_parent_window, make_window, saved_window)
3984 (Fset_window_configuration, save_window_save): Don't deal with
3985 clone numbers.
3986 * buffer.c (Qclone_number): Remove declaration.
3987 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3988
3349e122
SM
39892011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3990
3991 Add multiple inheritance to keymaps.
3992 * keymap.c (Fmake_composed_keymap): New function.
3993 (Fset_keymap_parent): Simplify.
3994 (fix_submap_inheritance): Remove.
3995 (access_keymap_1): New function extracted from access_keymap to handle
3996 embedded parents and handle lists of maps.
3997 (access_keymap): Use it.
3998 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3999 (Fcopy_keymap): Handle embedded parents.
4000 (Fcommand_remapping, define_as_prefix): Simplify.
4001 (Fkey_binding): Simplify.
4002 (syms_of_keymap): Move minibuffer-local-completion-map,
4003 minibuffer-local-filename-completion-map,
4004 minibuffer-local-must-match-map, and
4005 minibuffer-local-filename-must-match-map to Elisp.
4006 (syms_of_keymap): Defsubr make-composed-keymap.
4007 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4008 (parse_menu_item): Trivial simplification.
4009
3279eb87
GM
40102011-07-01 Glenn Morris <rgm@gnu.org>
4011
4012 * Makefile.in (SETTINGS_LIBS): Fix typo.
4013
4550efdf
KI
40142011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4015
4016 * coding.c (Fencode_coding_string): Record the last coding system
4017 used, as the function doc string says (bug#8738).
4018
0949d2b6
JD
40192011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4020
4021 * xsettings.c (store_monospaced_changed): Take new font as arg and
4022 check for change against current_mono_font.
4023 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4024 (emacs_settings_constructor, emacs_settings_get_property)
4025 (emacs_settings_set_property, emacs_settings_class_init)
4026 (emacs_settings_init, gsettings_obj): Remove.
4027 (something_changedCB): New function for HAVE_GSETTINGS.
4028 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4029 with value as argument.
4030 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4031 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 4032 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
4033 "changed".
4034
4035 * xgselect.c: Add defined (HAVE_GSETTINGS).
4036 (xgselect_initialize): Ditto.
4037
4038 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4039 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4040 xg_select.
4041
bbc6b304
PE
40422011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4043
4044 * eval.c (struct backtrace): Simplify and port the data structure.
4045 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4046 signed bit field, as this assumption is not portable and it makes
4047 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4048 "char debug_on_exit : 1" as this is not portable either; instead,
4049 use the portable "unsigned int debug_on_exit : 1". Remove unused
4050 member evalargs. Remove obsolete comments about cc bombing out.
4051
9851bfc5
JD
40522011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4053
51bb811f 4054 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
4055 Let HAVE_GSETTINGS override HAVE_GCONF.
4056 (store_monospaced_changed): New function.
4057 (EMACS_SETTINGS): A new type derived from GObject to handle
4058 GSettings notifications.
4059 (emacs_settings_constructor, emacs_settings_get_property)
4060 (emacs_settings_set_property, emacs_settings_class_init):
4061 New functions.
4062 (gsettings_client, gsettings_obj): New variables.
4063 (GSETTINGS_SCHEMA): New define.
4064 (something_changedCB): Call store_monospaced_changed.
4065 (init_gsettings): New function.
4066 (xsettings_initialize): Call init_gsettings.
4067 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4068 to NULL.
4069
640c8776 4070 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
4071 GCONF_CFLAGS/LIBS.
4072
5386012d
MR
40732011-06-29 Martin Rudalics <rudalics@gmx.at>
4074
4075 * window.c (resize_root_window, grow_mini_window)
4076 (shrink_mini_window): Rename Qresize_root_window to
4077 Qwindow_resize_root_window and Qresize_root_window_vertically to
4078 Qwindow_resize_root_window_vertically.
4079
f13e0b08
PE
40802011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4081
4082 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4083
94515237
JB
40842011-06-27 Juanma Barranquero <lekktu@gmail.com>
4085
4086 * makefile.w32-in: Redesign dependencies so they reflect more
4087 clearly which files are directly included by each source file,
4088 and not through other includes.
4089
e43b6e43
MR
40902011-06-27 Martin Rudalics <rudalics@gmx.at>
4091
4092 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4093 (sort_overlays, overlay_strings): When an overlay's clone number
4094 matches the window's clone number process the overlay even if
4095 the overlay's window property doesn't match the current window.
4096
d68443dc
MR
4097 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4098 (Fwindow_hchild): Rename to Fwindow_left_child.
4099 (Fwindow_next): Rename to Fwindow_next_sibling.
4100 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
4101 (resize_window_check): Rename to window_resize_check.
4102 (resize_window_apply): Rename to window_resize_apply.
4103 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4104 (Fdelete_other_windows_internal, resize_frame_windows)
4105 (Fsplit_window_internal, Fdelete_window_internal)
4106 (grow_mini_window, shrink_mini_window)
4107 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 4108
c7e73be5
JD
41092011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4110
4111 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4112 (emacs_fixed_set_min_size): Remove.
4113 (emacs_fixed_new): Take frame as argument.
4114
4115 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4116 (_EmacsFixedPrivate): Remove minwidth/height.
4117 Add struct frame *f.
4118 (emacs_fixed_init): Initialize priv->f.
4119 (get_parent_class, emacs_fixed_set_min_size): Remove.
4120 (emacs_fixed_new): Set priv->f to argument.
4121 (emacs_fixed_get_preferred_width)
4122 (emacs_fixed_get_preferred_height): Use min_width/height from
4123 frames size_hint to set minimum and natural (Bug#8919).
4124 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4125 and use min_width/height from frames size_hint to set
4126 min_width/height (Bug#8919).
4127
4128 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
4129 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4130 Fix indentation.
c7e73be5 4131
cf99dcf8
EZ
41322011-06-26 Eli Zaretskii <eliz@gnu.org>
4133
4134 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4135 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4136 called at ZV.
4137
029529ac
CY
41382011-06-26 Chong Yidong <cyd@stupidchicken.com>
4139
4140 * process.c (wait_reading_process_output): Bypass select if
4141 waiting for a cell while ignoring keyboard input, and input is
4142 pending. Suggested by Jan Djärv (Bug#8869).
4143
7a7ef429
PE
41442011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4145
4146 Use gnulib's dup2 module instead of rolling our own.
4147 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4148
11fdef7d 41492011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
4150
4151 * dispnew.c (scrolling_window): Before scrolling, turn off a
4152 mouse-highlight in the window being scrolled.
4153
cd3520a4
JB
41542011-06-24 Juanma Barranquero <lekktu@gmail.com>
4155
4156 Move DEFSYM to lisp.h and use everywhere.
4157
4158 * character.h (DEFSYM): Move declaration...
4159 * lisp.h (DEFSYM): ...here.
4160
4161 * gnutls.c:
4162 * minibuf.c:
4163 * w32menu.c:
4164 * w32proc.c:
4165 * w32select.c: Don't include character.h.
4166
4167 * alloc.c (syms_of_alloc):
4168 * buffer.c (syms_of_buffer):
4169 * bytecode.c (syms_of_bytecode):
4170 * callint.c (syms_of_callint):
4171 * casefiddle.c (syms_of_casefiddle):
4172 * casetab.c (init_casetab_once):
4173 * category.c (init_category_once, syms_of_category):
4174 * ccl.c (syms_of_ccl):
4175 * cmds.c (syms_of_cmds):
4176 * composite.c (syms_of_composite):
4177 * dbusbind.c (syms_of_dbusbind):
4178 * dired.c (syms_of_dired):
4179 * dispnew.c (syms_of_display):
4180 * doc.c (syms_of_doc):
4181 * editfns.c (syms_of_editfns):
4182 * emacs.c (syms_of_emacs):
4183 * eval.c (syms_of_eval):
4184 * fileio.c (syms_of_fileio):
4185 * fns.c (syms_of_fns):
4186 * frame.c (syms_of_frame):
4187 * fringe.c (syms_of_fringe):
4188 * insdel.c (syms_of_insdel):
4189 * keymap.c (syms_of_keymap):
4190 * lread.c (init_obarray, syms_of_lread):
4191 * macros.c (syms_of_macros):
4192 * msdos.c (syms_of_msdos):
4193 * print.c (syms_of_print):
4194 * process.c (syms_of_process):
4195 * search.c (syms_of_search):
4196 * sound.c (syms_of_sound):
4197 * syntax.c (init_syntax_once, syms_of_syntax):
4198 * terminal.c (syms_of_terminal):
4199 * textprop.c (syms_of_textprop):
4200 * undo.c (syms_of_undo):
4201 * w32.c (globals_of_w32):
4202 * window.c (syms_of_window):
4203 * xdisp.c (syms_of_xdisp):
4204 * xfaces.c (syms_of_xfaces):
4205 * xfns.c (syms_of_xfns):
4206 * xmenu.c (syms_of_xmenu):
4207 * xsettings.c (syms_of_xsettings):
4208 * xterm.c (syms_of_xterm): Use DEFSYM.
4209
4228cf16
TZ
42102011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4211
cd3520a4 4212 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 4213
7fcccf1e
PE
42142011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4215
7efb4e0e
PE
4216 Integer and buffer overflow fixes (Bug#8873).
4217
ff5844ad
PE
4218 * print.c (printchar, strout): Check for string overflow.
4219 (PRINTPREPARE, printchar, strout):
4220 Don't set size unless allocation succeeds.
4221
90532f02
PE
4222 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4223 for sizes. Check for string overflow more accurately.
4224 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4225
6d84508d
PE
4226 * macros.c: Integer and buffer overflow fixes.
4227 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4228 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4229 Use ptrdiff_t, not int, for sizes.
4230 Don't increment bufsize until after realloc succeeds.
4231 Check for size-calculation overflow.
4232 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4233
437b2cb4
PE
4234 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4235
8b9ac8b4
PE
4236 * lread.c: Integer overflow fixes.
4237 (read_integer): Radix is now EMACS_INT, not int,
4238 to improve quality of diagnostics for out-of-range radices.
4239 Calculate buffer size correctly for out-of-range radices.
4240 (read1): Check for integer overflow in radices, and in
4241 read-circle numbers.
82cb60d3
PE
4242 (read_escape): Avoid int overflow.
4243 (Fload, openp, read_buffer_size, read1)
4244 (substitute_object_recurse, read_vector, read_list, map_obarray):
4245 Use ptrdiff_t, not int, for sizes.
4246 (read1): Use EMACS_INT, not int, for sizes.
20270765 4247 Check for size overflow.
8b9ac8b4 4248
7fcccf1e
PE
4249 * image.c (cache_image): Check for size arithmetic overflow.
4250
bfbbd7e7
PE
4251 * lread.c: Integer overflow issues.
4252 (saved_doc_string_size, saved_doc_string_length)
4253 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4254 Now ptrdiff_t, not int.
4255 (read1): Don't assume doc string length fits in int. Check for
4256 out-of-range doc string lengths.
4257 (read_list): Don't assume file position fits in int.
39019e54 4258 (read_escape): Check for hex character overflow.
bfbbd7e7 4259
4e323265
LL
42602011-06-22 Leo Liu <sdl.web@gmail.com>
4261
4262 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4263 Move to minibuffer.el.
4264
85fece3e
PE
42652011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4266
20b84ce9 4267 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
4268 The following patches are for when GLYPH_DEBUG && !XASSERT.
4269 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4270 * dispnew.c (flush_stdout):
4271 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4272 Mark as externally visible.
4273 * dispnew.c (check_window_matrix_pointers): Now static.
4274 * dispnew.c (window_to_frame_vpos):
4275 * xfns.c (unwind_create_frame):
4276 * xterm.c (x_check_font): Remove unused local.
4277 * scroll.c (CHECK_BOUNDS):
4278 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4279 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4280 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4281 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4282 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4283 Now static.
4284 (debug_method_add): Use va_list and vsprintf rather than relying
4285 on undefined behavior with wrong number of arguments.
4286 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4287 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4288 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4289 since we're not interested in debugging glyphs with old libraries.
4290 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4291 GCC 4.6.0's static checking.
4292
0766b489
PE
42932011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4294
31fd4b32
PE
4295 Integer overflow and signedness fixes (Bug#8873).
4296 A few related buffer overrun fixes, too.
4297
b79e8648
PE
4298 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4299
0766b489
PE
4300 * dispextern.h (struct face.stipple):
4301 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4302 (x_bitmap_mask, x_allocate_bitmap_record)
4303 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4304 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4305 (x_create_bitmap_from_xpm_data):
4306 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4307 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4308 (.bitmaps_last):
4309 * xfaces.c (load_pixmap):
4310 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4311 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4312 (.bitmaps_last, struct x_output.icon_bitmap):
4313 Use ptrdiff_t, not int, for bitmap indexes.
4314 (x_allocate_bitmap_record): Check for size overflow.
4315 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4316
b081724f
PE
4317 Use ptrdiff_t, not int, for overlay counts.
4318 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4319 * editfns.c (overlays_around, get_pos_property):
4320 * textprop.c (get_char_property_and_overlay):
4321 * xdisp.c (next_overlay_change, note_mouse_highlight):
4322 * xfaces.c (face_at_buffer_position):
21514da7
PE
4323 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4324 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4325 (Fnext_overlay_change, Fprevious_overlay_change)
4326 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 4327 Use ptrdiff_t, not int, for sizes.
21514da7 4328 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 4329
3de73e5e
PE
4330 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4331
2606c57b
PE
4332 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4333 (x_session_initialize): Do not assume string length fits in int.
4334
aaafe47a
PE
4335 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4336 This is unlikely, but can occur if DPI is outlandish.
4337
2674ddc8 4338 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
4339 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4340
28154962
PE
4341 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4342 * xrdb.c (magic_file_p, search_magic_path):
4343 Omit last arg SUFFIX; it was always 0. All callers changed.
4344 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4345
7de51af5
PE
4346 * xfont.c (xfont_match): Avoid need for strlen.
4347
25ed6cc3
PE
4348 * xfns.c: Don't assume strlen fits in int.
4349 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4350
4eab31dd
PE
4351 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4352 not unsigned long, as we prefer signed integers. All callers changed.
4353 Detect integer overflow in repeat count.
4354 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 4355 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 4356
171e2a58
PE
4357 * termcap.c: Don't assume sizes fit in int and never overflow.
4358 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4359 (gobble_line): Check for size-calculation overflow.
4360
ad39faca 4361 * minibuf.c (Fread_buffer):
6e5bb2dc 4362 * lread.c (intern, intern_c_string):
74ca2eb3
PE
4363 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4364 Don't assume string length fits in int.
4365
52c61c22 4366 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
4367 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4368
b5b8c9e5
PE
4369 * font.c: Don't assume string length fits in int.
4370 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4371 Use ptrdiff_t, not int.
ccd6111c
PE
4372 (font_intern_prop): Don't assume string length fits in int.
4373 Don't assume integer property fits in fixnum.
4374 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 4375
882f0d81 4376 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 4377 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
4378 Reformulate so as not to need the command string.
4379 Invoke gzip -cd rather than gunzip, as it's more portable.
4380 (lock_info_type, lock_file_1, lock_file):
4381 Don't assume pid_t and time_t fit in unsigned long.
4382 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4383 (current_lock_owner): Prefer signed type for sizes.
4384 Use memcpy, not strncpy, where memcpy is what is really wanted.
4385 Don't assume (via atoi) that time_t and pid_t fit in int.
4386 Check for time_t and/or pid_t out of range, e.g., via a network share.
4387 Don't alloca where an auto var works fine.
4388
93f4cf88
PE
4389 * fileio.c: Fix some integer overflow issues.
4390 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4391 Don't assume string length fits in int.
4392 (directory_file_name): Don't assume string length fits in long.
4393 (make_temp_name): Don't assume pid fits in int, or that its print
4394 length is less than 20.
4395
f3e92b69
PE
4396 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4397
1bfdaf10
PE
4398 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4399
35016e9a
PE
4400 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4401
3d1e65a1
PE
4402 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4403 We prefer signed integers, even for size calculations.
4404
0b963a93
PE
4405 * emacs.c: Don't assume string length fits in 'int'.
4406 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4407 (main): Don't invoke strlen when not needed.
4408
573f4b54
PE
4409 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4410 (XD_DEBUG_MESSAGE): Don't waste a byte.
4411
989f33ba
PE
4412 * callproc.c (getenv_internal_1, getenv_internal)
4413 (Fgetenv_internal):
965d34eb
PE
4414 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4415
e4d29b33
PE
4416 * lread.c (invalid_syntax): Omit length argument.
4417 All uses changed. This doesn't fix a bug, but it simplifies the
4418 code away from its former Hollerith-constant appearance, and it's
4419 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 4420 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 4421
eb49b136
PE
4422 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4423 This didn't break anything, but it didn't help either.
4424 It's confusing to put a bogus integer in a place where the actual
4425 value does not matter.
9f62aeb1 4426 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 4427 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 4428
15375a22
PE
4429 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4430 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4431 implementation.
b61cc01c
PE
4432 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4433 We prefer signed types, and the value cannot exceed the EMACS_INT
4434 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
4435 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4436 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4437 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 4438
53b2623d
PE
4439 * indent.c (sane_tab_width): New function.
4440 (current_column, scan_for_column, Findent_to, position_indentation)
4441 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 4442 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 4443
51cab52b 4444 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 4445
f2ed8a70
PE
4446 * lisp.h (lint_assume): New macro.
4447 * composite.c (composition_gstring_put_cache):
4448 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4449
abe80cc6
PE
4450 * editfns.c, insdel.c:
4451 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 4452
b02c740e
PE
4453 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4454
ebc96716
PE
4455 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4456
b4e50fa0 4457 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 4458 Use much-faster test for byte-length change.
311d5d7c 4459 Don't assume string byte-length fits in 'int'.
a4cf38e4 4460 Check that character arg fits in 'int'.
85461888 4461 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 4462
c0c1ee9f
PE
4463 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4464
a498d7f4
PE
4465 * fns.c (concat): Catch string overflow earlier.
4466 Do not rely on integer wraparound.
4467
51cab52b
PE
4468 * dispextern.h (struct it.overlay_strings_charpos)
4469 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
4470 * xdisp.c (forward_to_next_line_start)
4471 (back_to_previous_visible_line_start)
4472 (reseat_at_next_visible_line_start, next_element_from_buffer):
4473 Don't arbitrarily truncate the value of 'selective' to int.
4474
76031fad
PE
4475 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4476
5eb55db9
PE
4477 * composite.c: Don't truncate sizes to 'int'.
4478 (composition_gstring_p, composition_reseat_it)
4479 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
4480 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4481 not EMACS_UINT, for indexes.
5eb55db9 4482
0703a717
PE
4483 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4484
d6202519
PE
4485 * buffer.c: Include <verify.h>.
4486 (struct sortvec.priority, struct sortstr.priority):
8961a454 4487 Now EMACS_INT, not int.
c20998a7 4488 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
4489 (struct sortstr.size, record_overlay_string)
4490 (struct sortstrlist.size, struct sortlist.used):
4491 Don't truncate size to int.
4492 (record_overlay_string): Check for size-calculation overflow.
d6202519 4493 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 4494
d5a19415
JM
44952011-06-22 Jim Meyering <meyering@redhat.com>
4496
029529ac 4497 Don't leak an XBM-image-sized buffer
d5a19415
JM
4498 * image.c (xbm_load): Free the image buffer after using it.
4499
a9041e6c
PE
45002011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4501
4502 Port to Sun C.
4503 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4504 that Sun C diagnosed.
4505 * fns.c (secure_hash): Fix pointer signedness issue.
4506 * intervals.c (static_offset_intervals): New function.
4507 (offset_intervals): Use it.
4508
7f3f739f
LL
45092011-06-21 Leo Liu <sdl.web@gmail.com>
4510
4511 * deps.mk (fns.o):
4512 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4513 sha512.h.
4514
4515 * fns.c (secure_hash): Rename from crypto_hash_function and change
4516 the first arg to accept symbols.
5b66d427 4517 (Fsecure_hash): New primitive.
7f3f739f
LL
4518 (syms_of_fns): New symbols.
4519
76147d94
DD
45202011-06-20 Deniz Dogan <deniz@dogan.se>
4521
4522 * process.c (Fset_process_buffer): Clarify return value in
4523 docstring.
4524
7d7d0045
CY
45252011-06-18 Chong Yidong <cyd@stupidchicken.com>
4526
4527 * dispnew.c (add_window_display_history): Use BVAR.
4528
4529 * xdisp.c (debug_method_add): Use BVAR.
4530 (check_window_end, dump_glyph_matrix, dump_glyph)
4531 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4532
4533 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4534 Likewise.
4535
4536 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4537 check till after the cache is created in init_frame_faces.
4538
ff2bc410
SM
45392011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4540
4541 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4542
28177add
PE
45432011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4544
dd3482fe
PE
4545 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4546 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4547 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4548
393d71f3 4549 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
4550 * fileio.c (Finsert_file_contents):
4551 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4552 Remove the old (too-loose) buffer overflow checks.
4553 They weren't needed, since make_gap checks for buffer overflow.
4554 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4555 The old code merely checked for Emacs fixnum overflow, and relied
4556 on undefined (wraparound) behavior. The new code avoids undefined
4557 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4558
2e6813b0 4559 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
4560 Tune. Don't use wider integers than needed. Don't use alloca.
4561 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 4562
599a9e4f
PE
4563 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4564
99561444
PE
4565 * insdel.c, lisp.h (buffer_overflow): New function.
4566 (insert_from_buffer_1, replace_range, replace_range_2):
4567 * insdel.c (make_gap_larger):
4568 * editfns.c (Finsert_char):
4569 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4570
28177add
PE
4571 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4572
e69dafad
PE
45732011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4574
4baa020d 4575 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 4576
b1c46f02
PE
4577 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4578 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4579
e69dafad
PE
4580 * fileio.c: Don't assume EMACS_INT fits in off_t.
4581 (emacs_lseek): New static function.
4582 (Finsert_file_contents, Fwrite_region): Use it.
4583 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4584
566684ea
PE
4585 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4586
e6966cd6
PE
4587 * fns.c: Don't overflow int when computing a list length.
4588 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4589 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4590 truncation on 64-bit hosts. Check for QUIT every
4591 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4592 faster and is responsive enough.
4593 (Flength): Report an error instead of overflowing an integer.
4594 (Fsafe_length): Return a float if the value is not representable
4595 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 4596 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 4597 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 4598
dd0b0efb
PE
4599 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4600 (header_size, word_size): New constants.
4601 (allocate_vectorlike): Don't check size overflow here.
4602 (allocate_vector): Check it here instead, since this is the only
4603 caller of allocate_vectorlike that could cause overflow.
4604 Check that the new vector's length is representable as a fixnum.
4605
86fe5cfe
PE
4606 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4607 The previous code was bogus. For example, next_almost_prime (32)
4608 returned 39, which is undesirable as it is a multiple of 3; and
4609 next_almost_prime (24) returned 25, which is a multiple of 5 so
4610 why was the code bothering to check for multiples of 7?
4611
80e88859
PE
4612 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4613
4a2f0ad6
PE
4614 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4615
f66c7cf8
PE
4616 Variadic C functions now count arguments with ptrdiff_t.
4617 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4618 Back then I didn't know that the Emacs coding style prefers signed int.
4619 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
4620 were being counted with int, which may truncate counts on 64-bit
4621 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
4622 * lisp.h (struct Lisp_Subr.function.aMANY)
4623 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4624 Arg counts are now ptrdiff_t, not size_t.
4625 All variadic functions and their callers changed accordingly.
4626 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4627 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4628 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4629 * callint.c (Fcall_interactively): Check arg count for overflow,
4630 to avoid potential buffer overrun. Use signed char, not 'int',
4631 for 'varies' array, so that we needn't bother to check its size
4632 calculation for overflow.
4633 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4634 * eval.c (apply_lambda):
4635 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4636 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4637 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4638
a1759b76
PE
4639 * callint.c (Fcall_interactively): Don't use index var as event count.
4640
d96be9fc
PE
4641 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4642 * mem-limits.h (SIZE): Remove; no longer used.
4643
a690a978 4644 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 4645
578c21e6
PE
4646 Remove unnecessary casts.
4647 * xterm.c (x_term_init):
4648 * xfns.c (x_set_border_pixel):
4649 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4650 These aren't needed now that we assume ANSI C.
4651
96f53c6c
PE
4652 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4653 It's more likely to cause problems (due to unsigned overflow)
4654 than to cure them.
4655
83c77d31
PE
4656 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4657
ee2079f1
PE
4658 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4659
6da65536
PE
4660 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4661
7147c4a4
PE
4662 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4663
193e32d9
PE
4664 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4665
e5533da6
PE
4666 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4667
9910e595
PE
4668 GLYPH_CODE_FACE returns EMACS_INT, not int.
4669 * dispextern.h (merge_faces):
4670 * xfaces.c (merge_faces):
01103c44
PE
4671 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4672 Don't assume EMACS_INT fits in int.
9910e595 4673
2638320e
PE
4674 * character.h (CHAR_VALID_P): Remove unused parameter.
4675 * fontset.c, lisp.h, xdisp.c: All uses changed.
4676
045eb8d9
PE
4677 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4678
c1f134b5
PE
4679 * fns.c (concat): Minor tuning based on overflow analysis.
4680 This doesn't fix any bugs. Use int to hold character, instead
4681 of constantly refetching from Emacs object. Use XFASTINT, not
4682 XINT, for value known to be a character. Don't bother comparing
4683 a single byte to 0400, as it's always less.
4684
395fcb93 4685 * floatfns.c (Fexpt):
327eeec8
PE
4686 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4687
abbd3d23
PE
4688 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4689 for characters.
4690
684a03ef
PE
4691 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4692
0fed43f3
PE
4693 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4694 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4695 incorrectly succeed when S was a string, because 4294967386 was
4696 truncated before it was used.
4697
8fd02eb7
PE
4698 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4699 Otherwise, an out-of-range integer could cause undefined behavior
4700 on a 64-bit host.
4701
f8c86b69
PE
4702 * composite.c: Use int, not EMACS_INT, for characters.
4703 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4704 EMACS_INT, for values that are known to be in character range.
4705 This doesn't fix any bugs but is the usual style inside Emacs and
4706 may generate better code on 32-bit machines.
4707
34206dd2
PE
4708 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4709 This is for reasons similar to the recent CHAR_STRING fix.
4710 * charset.c (Fencode_char): Check that character arg is actually
4711 a character. Pass an int to ENCODE_CHAR.
4712 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4713 wider than 'int', as a compile-time check to prevent future regressions
4714 in this area.
4715
c5958d4c 4716 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
4717
4718 Make sure a 64-bit char is never passed to CHAR_STRING.
4719 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4720 by silently ignoring the top 32 bits, allowing some values
4721 that were far too large to be valid characters.
4722 * character.h: Include <verify.h>.
4723 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4724 arguments are no wider than unsigned, as a compile-time check
4725 to prevent future regressions in this area.
4726 * data.c (Faset):
01103c44 4727 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
4728 (Fsubst_char_in_region):
4729 * fns.c (concat):
4730 * xdisp.c (decode_mode_spec_coding):
4731 Adjust to CHAR_STRING's new requirement.
4732 * editfns.c (Finsert_char, Fsubst_char_in_region):
4733 * fns.c (concat): Check that character args are actually
4734 characters. Without this test, these functions did the wrong
4735 thing with wildly out-of-range values on 64-bit hosts.
4736
d37ca623
PE
4737 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4738 These casts should not be needed on 32-bit hosts, either.
4739 * keyboard.c (read_char):
4740 * lread.c (Fload): Remove casts to unsigned.
4741
ea204efb
PE
4742 * lisp.h (UNSIGNED_CMP): New macro.
4743 This fixes comparison bugs on 64-bit hosts.
4744 (ASCII_CHAR_P): Use it.
4745 * casefiddle.c (casify_object):
01103c44 4746 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
4747 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4748 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4749 * dispextern.h (FACE_FROM_ID):
4750 * keyboard.c (read_char): Use UNSIGNED_CMP.
4751
41cb286c
PE
4752 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4753 not to EMACS_INT, to avoid GCC warning.
4754
4a1b9832
PE
4755 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4756
55daad71
PE
4757 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4758 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4759 isn't needed on 32-bit machines.
8f95c75c 4760
01103c44
PE
4761 * buffer.c (Fgenerate_new_buffer_name):
4762 Use EMACS_INT for count, not int.
0ceccced 4763 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
4764
4765 * data.c (Qcompiled_function): Now static.
4766
c6f072e7
PE
4767 * window.c (window_body_lines): Now static.
4768
20ce5912
PE
4769 * image.c (gif_load): Rename local to avoid shadowing.
4770
9c4c5f81
PE
4771 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4772 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4773 * alloc.c (make_save_value): Integer argument is now of type
4774 ptrdiff_t, not int.
4775 (mark_object): Use ptrdiff_t, not int.
4776 * lisp.h (pD): New macro.
4777 * print.c (print_object): Use it.
4778
c0c5c8ae
PE
4779 * alloc.c: Use EMACS_INT, not int, to count objects.
4780 (total_conses, total_markers, total_symbols, total_vector_size)
4781 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
4782 (total_free_floats, total_floats, total_free_intervals)
4783 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
4784 Now EMACS_INT, not int. All uses changed.
4785 (Fgarbage_collect): Compute overall total using a double, so that
4786 integer overflow is less likely to be a problem. Check for overflow
4787 when converting back to an integer.
5a25e253
PE
4788 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4789 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4790 These were 'int' variables that could overflow on 64-bit hosts;
4791 they were never used, so remove them instead of repairing them.
211a0b2a 4792 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
4793 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4794 Previously, this ceilinged at INT_MAX, but that doesn't work on
4795 64-bit machines.
e46bb31a 4796 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 4797
c78baabf 4798 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 4799 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
4800 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4801 when a (possibly-narrower) signed value would do just as well.
4802 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 4803
c9d624c6
PE
4804 * alloc.c: Catch some string size overflows that we were missing.
4805 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4806 for convenience in STRING_BYTES_MAX.
4807 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4808 The definition here is exact; the one in lisp.h was approximate.
4809 (allocate_string_data): Check for string overflow. This catches
4810 some instances we weren't catching before. Also, it catches
4811 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4812 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4813 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 4814
c9d624c6
PE
4815 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4816 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 4817 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 4818
353032ce
PE
4819 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4820
2bccce07
PE
4821 * alloc.c (Fmake_string): Check for out-of-range init.
4822
0ac30604
SM
48232011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4824
4825 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4826
c195f2de
JD
48272011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4828
4829 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4830 xg_get_default_scrollbar_width.
4831
4832 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4833 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4834 (style_changed_cb): Call update_theme_scrollbar_width and call
4835 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4836 all frames (Bug#8505).
4837 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4838 Call gtk_window_set_resizable if HAVE_GTK3.
4839 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4840 and height if HAVE_GTK3 (Bug#8505).
4841 (scroll_bar_width_for_theme): New variable.
4842 (update_theme_scrollbar_width): New function.
4843 (xg_get_default_scrollbar_width): Move code to
4844 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4845 (xg_initialize): Call update_theme_scrollbar_width.
4846
4847 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4848
4849 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4850
e10ac9f1
MR
48512011-06-12 Martin Rudalics <rudalics@gmx.at>
4852
4853 * frame.c (make_frame): Call other_buffer_safely instead of
4854 other_buffer.
4855
4856 * window.c (temp_output_buffer_show): Call display_buffer with
4857 second argument Vtemp_buffer_show_specifiers and reset latter
4858 immediately after the call.
4859 (Vtemp_buffer_show_specifiers): New variable.
4860 (auto_window_vscroll_p, next_screen_context_lines)
4861 (Vscroll_preserve_screen_position): Remove leading asterisks from
4862 doc-strings.
4863
2d3c217e 48642011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 4865
7b7f97e8 4866 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
4867 * buffer.c (Qclone_number): Remove for now, as it's unused.
4868 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4869 (record_buffer): Remove unused local.
4870 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4871 (set_frame_buffer_list): Remove; unused.
4872 * frame.h (other_visible_frames): Remove decl.
4873 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4874 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4875 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4876 if HAVE_GPM.
4877 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4878 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4879 Define only if HAVE_GPM.
4880 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4881 (update_hints_inhibit): Remove; never set. All uses removed.
4882 * widgetprv.h (emacsFrameClassRec): Remove decl.
4883 * window.c (delete_deletable_window): Now returns void, since it
4884 wasn't returning anything.
4885 (compare_window_configurations): Remove unused locals.
4886 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4887 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
4888 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4889 the same widths as pointers. This follows up on the 2011-05-06 patch.
4890 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4891 * xterm.h: Likewise.
4892 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4893
1384b89e
JB
48942011-06-12 Juanma Barranquero <lekktu@gmail.com>
4895
4896 * makefile.w32-in: Update dependencies.
4897 (LISP_H): Add lib/intprops.h.
4898
1100a63c
CY
48992011-06-11 Chong Yidong <cyd@stupidchicken.com>
4900
4901 * image.c (gif_load): Add animation frame delay to the metadata.
4902 (syms_of_image): Use DEFSYM. New symbol `delay'.
4903
6198ccd0
MR
49042011-06-11 Martin Rudalics <rudalics@gmx.at>
4905
4906 * window.c (delete_deletable_window): Re-add.
4907 (Fset_window_configuration): Rewrite to handle dead buffers and
4908 consequently deletable windows.
4909 (window_tree, Fwindow_tree): Remove. Supply functionality in
4910 window.el.
4911 (compare_window_configurations): Simplify code.
4912
b6e3633c
AS
49132011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4914
1ab0dee5
AS
4915 * image.c (imagemagick_load_image): Fix type mismatch.
4916 (Fimagemagick_types): Likewise.
4917
b6e3633c
AS
4918 * window.h (replace_buffer_in_windows): Declare.
4919
9397e56f
MR
49202011-06-11 Martin Rudalics <rudalics@gmx.at>
4921
4922 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4923 Qclone_number. Remove external declaration of Qdelete_window.
4924 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4925 code.
640c8776
SM
4926 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4927 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
4928 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4929 buffer list implementation.
4930 (other_buffer_safely): New function.
4931 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4932 calls to replace_buffer_in_windows and
4933 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4934 if allowed.
4935 (record_buffer): Inhibit quitting and rewrite using quittable
4936 functions. Run Qbuffer_list_update_hook if allowed.
4937 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
4938 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4939 Move switch-to-buffer to window.el.
9397e56f
MR
4940 (bury-buffer): Move to window.el.
4941 (Vbuffer_list_update_hook): New variable.
4942
4943 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4944 section.
4945
4946 * window.h (resize_frame_windows): Move up in code.
4947 (Fwindow_frame): Remove EXFUN.
4948 (replace_buffer_in_all_windows): Remove prototype.
4949 (replace_buffer_in_windows_safely): Add prototype.
4950
4951 * window.c: Declare Qdelete_window static again. Move down
4952 declaration of select_count.
4953 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4954 (Fother_window): Move to window.el.
4955 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4956 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4957 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4958 window.el.
4959 (replace_buffer_in_windows): Implement by calling
4960 Qreplace_buffer_in_windows.
4961 (replace_buffer_in_all_windows): Remove with some functionality
4962 moved into replace_buffer_in_windows_safely.
4963 (replace_buffer_in_windows_safely): New function.
4964 (select_window_norecord, select_frame_norecord): Move in front
4965 of run_window_configuration_change_hook. Remove now obsolete
4966 declarations.
640c8776
SM
4967 (Fset_window_buffer): Rewrite doc-string.
4968 Call Qrecord_window_buffer.
9397e56f
MR
4969 (keys_of_window): Move binding for other-window to window.el.
4970
b50691aa
CY
49712011-06-11 Chong Yidong <cyd@stupidchicken.com>
4972
4973 * dispextern.h (struct image): Replace data member, whose int_val
4974 and ptr_val fields were not used by anything, with a single
4975 lisp_val object.
4976
4977 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4978 (gif_clear_image, gif_load, imagemagick_load_image)
4979 (gs_clear_image, gs_load): Callers changed.
4980
3f754b86
PE
49812011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4982
cca69397
PE
4983 * buffer.h: Include <time.h>, for time_t.
4984 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4985
109e28d0
PE
4986 Fix minor problems found by static checking.
4987
60737f02
PE
4988 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4989
4b66faf3
PE
4990 Make identifiers static if they are not used in other modules.
4991 * data.c (Qcompiled_function, Qframe, Qvector):
4992 * image.c (QimageMagick, Qsvg):
4993 * minibuf.c (Qmetadata):
4994 * window.c (resize_window_check, resize_root_window): Now static.
4995 * window.h (resize_window_check, resize_root_window): Remove decls.
4996
109e28d0
PE
4997 * window.c (window_deletion_count, delete_deletable_window):
4998 Remove; unused.
46a4ce9e
PE
4999 (window_body_lines): Now static.
5000 (Fdelete_other_windows_internal): Mark vars as initialized.
5001 Make sure 'resize_failed' is initialized.
5002 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5003 (resize_window_apply): Remove unused local.
5004 * window.h (delete_deletable_window): Remove decl.
5005
109e28d0 5006 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
5007 (imagemagick_load_image): Fix pointer signedness problem by changing
5008 last arg from unsigned char * to char *. All uses changed.
5009 Also, fix a local for similar reasons.
5010 Remove unused locals. Remove locals to avoid shadowing.
5011 (fn_rsvg_handle_free): Remove; unused.
5012 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 5013 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 5014
3f754b86
PE
5015 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5016
2547adb1
CY
50172011-06-10 Chong Yidong <cyd@stupidchicken.com>
5018
5019 * image.c (gif_load): Fix omitted cast error introduced by
5020 2011-06-06 change.
5021
2c8e37d4
MR
50222011-06-10 Martin Rudalics <rudalics@gmx.at>
5023
5024 * window.h (resize_proportionally, orig_total_lines)
5025 (orig_top_line): Remove from window structure.
5026 (set_window_height, set_window_width, change_window_heights)
5027 (Fdelete_window): Remove prototypes.
5028 (resize_frame_windows): Remove duplicate declaration.
5029
440a42e3
EZ
50302011-06-10 Eli Zaretskii <eliz@gnu.org>
5031
5032 * window.h (resize_frame_windows, resize_window_check)
5033 (delete_deletable_window, resize_root_window)
5034 (resize_frame_windows): Declare prototypes.
5035
5036 * window.c (resize_window_apply): Make definition be "static" to
5037 match the prototype.
5038
562dd5e9
MR
50392011-06-10 Martin Rudalics <rudalics@gmx.at>
5040
5041 * window.c: Remove declarations of Qwindow_size_fixed,
5042 window_min_size_1, window_min_size_2, window_min_size,
5043 size_window, window_fixed_size_p, enlarge_window, delete_window.
5044 Remove static from declaration of Qdelete_window, it's
5045 temporarily needed by Fbury_buffer.
5046 (replace_window): Don't assign orig_top_line and
5047 orig_total_lines.
5048 (Fdelete_window, delete_window): Remove. Window deletion is
5049 handled by window.el.
640c8776
SM
5050 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5051 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
5052 (Fdelete_other_windows): Remove. Deleting other windows is
5053 handled by window.el.
5054 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5055 handled in window.el.
5056 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5057 Window minimum sizes are handled in window.el.
5058 (shrink_windows, size_window, set_window_height)
5059 (set_window_width, change_window_heights, window_height)
5060 (window_width, CURBEG, CURSIZE, enlarge_window)
5061 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5062 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5063 handled in window.el.
5064 (make_dummy_parent): Rename to make_parent_window and give it a
5065 second argument horflag.
5066 (make_window): Don't set resize_proportionally any more.
5067 (Fsplit_window): Remove. Windows are split in window.el.
5068 (save_restore_action, save_restore_orig_size)
5069 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5070 Resize mini windows in window.el.
5071 (grow_mini_window, shrink_mini_window): Implement by calling
5072 Qresize_root_window_vertically, resize_window_check and
5073 resize_window_apply.
640c8776
SM
5074 (saved_window, Fset_window_configuration, save_window_save):
5075 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
5076 resize_proportionally.
5077 (window_min_height, window_min_width): Move to window.el.
5078 (keys_of_window): Move bindings for delete-other-windows,
5079 split-window, delete-window and enlarge-window to window.el.
5080
5081 * buffer.c: Temporarily extern Qdelete_window.
5082 (Fbury_buffer): Temporarily call Qdelete_window instead of
5083 Fdelete_window (Fbury_buffer will move to window.el soon).
5084
5085 * frame.c (set_menu_bar_lines_1): Remove code handling
5086 orig_top_line and orig_total_lines.
5087
5088 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5089 set_window_height but set heights directly.
5090 (change_frame_size_1): Use resize_frame_windows.
5091
5092 * xdisp.c (init_xdisp): Don't use set_window_height but set
5093 heights directly.
5094
640c8776
SM
5095 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5096 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
5097 run_window_configuration_change_hook.
5098
5099 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5100 instead of change_window_heights and run
5101 run_window_configuration_change_hook.
5102
1a13852e
MR
51032011-06-09 Martin Rudalics <rudalics@gmx.at>
5104
5105 * window.c (replace_window): Rename second argument REPLACEMENT to
5106 NEW. New third argument SETFLAG. Rewrite.
5107 (delete_window, make_dummy_parent): Call replace_window with
5108 third argument 1.
5109 (window_list_1): Move down in code.
5110 (run_window_configuration_change_hook): Move set_buffer part
5111 before select_frame_norecord part in order to unwind correctly.
5112 Rename count1 to count.
5113 (recombine_windows, delete_deletable_window, resize_root_window)
5114 (Fdelete_other_windows_internal)
5115 (Frun_window_configuration_change_hook, make_parent_window)
5116 (resize_window_check, resize_window_apply, Fresize_window_apply)
5117 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
5118 (Fdelete_window_internal, Fresize_mini_window_internal):
5119 New functions.
1a13852e
MR
5120 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5121
f3d1777e
MR
51222011-06-08 Martin Rudalics <rudalics@gmx.at>
5123
496e208e
MR
5124 * window.h (window): Add some new members to window structure -
5125 normal_lines, normal_cols, new_total, new_normal, clone_number,
5126 splits, nest, prev_buffers, next_buffers.
5127 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 5128 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 5129
f3d1777e
MR
5130 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5131 Remove.
496e208e
MR
5132 (make_dummy_parent): Set new members of windows structure.
5133 (make_window): Move down in code. Handle new members of window
5134 structure.
5135 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5136 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5137 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5138 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
5139 (Fset_window_next_buffers, Fset_window_clone_number):
5140 New functions.
496e208e
MR
5141 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5142 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5143 Doc-string fixes.
5144 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5145 Argument WINDOW can be now internal window too.
5146 (Fwindow_use_time): Move up in code.
5147 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5148 Rewrite doc-string.
5149 (Fset_window_configuration, saved_window)
5150 (Fcurrent_window_configuration, save_window_save): Handle new
5151 members of window structure.
b9e809c2
MR
5152 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5153 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5154 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5155 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5156 Qget_mru_window, Qresize_root_window,
5157 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5158 Qauto_buffer_name; staticpro them.
f3d1777e 5159
abde8f8c
MR
51602011-06-07 Martin Rudalics <rudalics@gmx.at>
5161
5162 * window.c (Fwindow_total_size, Fwindow_left_column)
5163 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5164 (Fwindow_list_1): New functions.
5165 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
5166 (Fwindow_width, Fscroll_left, Fscroll_right):
5167 Use window_body_cols instead of window_box_text_cols.
5168 (delete_window, Fset_window_configuration):
5169 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
5170 (delete_all_subwindows): Take a window as argument and not a
5171 structure. Rewrite.
190b47e6
MR
5172 (window_loop): Remove handling of GET_LRU_WINDOW and
5173 GET_LARGEST_WINDOW.
5174 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
5175
5176 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
5177 window_box_text_cols. delete_all_subwindows now takes a
5178 Lisp_Object as argument.
abde8f8c 5179
640c8776
SM
5180 * indent.c (compute_motion, Fcompute_motion):
5181 Use window_body_cols instead of window_box_text_cols.
abde8f8c 5182
fa8a67e6
MR
5183 * frame.c (delete_frame): Call delete_all_subwindows with root
5184 window as argument.
5185
a54e3482
DC
51862011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5187
5188 * fns.c (Fputhash): Document return value.
5189
60002bf5
CY
51902011-06-06 Chong Yidong <cyd@stupidchicken.com>
5191
5192 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5193
0c671da6 51942011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 5195
b862a52a 5196 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 5197
be44ca6c
PE
5198 Check for overflow when converting integer to cons and back.
5199 * charset.c (Fdefine_charset_internal, Fdecode_char):
5200 Use cons_to_unsigned to catch overflow.
5201 (Fencode_char): Use INTEGER_TO_CONS.
5202 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5203 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5204 * data.c (long_to_cons, cons_to_long): Remove.
5205 (cons_to_unsigned, cons_to_signed): New functions.
5206 These signal an error for invalid or out-of-range values.
5207 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5208 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5209 * font.c (Ffont_variation_glyphs):
5210 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5211 * lisp.h: Include <intprops.h>.
5212 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5213 (cons_to_signed, cons_to_unsigned): New decls.
5214 (long_to_cons, cons_to_long): Remove decls.
5215 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5216 (Fprimitive_undo): Use CONS_TO_INTEGER.
5217 * xfns.c (Fx_window_property): Likewise.
5218 * xselect.c: Include <limits.h>.
5219 (x_own_selection, selection_data_to_lisp_data):
5220 Use INTEGER_TO_CONS.
5221 (x_handle_selection_request, x_handle_selection_clear)
5222 (x_get_foreign_selection, Fx_disown_selection_internal)
5223 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5224 (lisp_data_to_selection_data): Use cons_to_unsigned.
5225 (x_fill_property_data): Use cons_to_signed.
5226 Report values out of range.
5227
d1f3d2af
PE
5228 Check for buffer and string overflow more precisely.
5229 * buffer.h (BUF_BYTES_MAX): New macro.
5230 * lisp.h (STRING_BYTES_MAX): New macro.
5231 * alloc.c (Fmake_string):
5232 * character.c (string_escape_byte8):
5233 * coding.c (coding_alloc_by_realloc):
5234 * doprnt.c (doprnt):
5235 * editfns.c (Fformat):
5236 * eval.c (verror):
5237 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5238 since they may not be the same number.
5239 * editfns.c (Finsert_char):
5240 * fileio.c (Finsert_file_contents):
5241 Likewise for BUF_BYTES_MAX.
5242
dd52fcea
PE
5243 * image.c: Use ptrdiff_t, not int, for sizes.
5244 (slurp_file): Switch from int to ptrdiff_t.
5245 All uses changed.
5246 (slurp_file): Check that file size fits in both size_t (for
5247 malloc) and ptrdiff_t (for sanity and safety).
5248
7f9bbdbb
PE
5249 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5250 if b->modtime has its maximal value.
5251
dfe18f82
PE
5252 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5253
84acfcf0
PE
5254 Don't assume time_t can fit into int.
5255 * buffer.h (struct buffer.modtime): Now time_t, not int.
5256 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5257 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5258
ccd9a01a
PE
5259 Minor fixes for signed vs unsigned integers.
5260 * character.h (MAYBE_UNIFY_CHAR):
5261 * charset.c (maybe_unify_char):
5262 * keyboard.c (read_char, reorder_modifiers):
5263 XINT -> XFASTINT, since the integer must be nonnegative.
5264 * ftfont.c (ftfont_spec_pattern):
5265 * keymap.c (access_keymap, silly_event_symbol_error):
5266 XUINT -> XFASTINT, since the integer must be nonnegative.
5267 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5268 since it makes no difference and we prefer signed.
5269 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5270 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5271 nonnegative.
5272
d6d100dd
SM
52732011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5274
5275 * window.h (Fwindow_frame): Declare.
5276
2b6148e4
PE
52772011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5278
5279 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5280 (SPARE_MEMORY): Always define.
5281 (LARGE_REQUEST): Remove.
5282 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5283
f230ecc9
MR
52842011-06-06 Martin Rudalics <rudalics@gmx.at>
5285
727e958e
MR
5286 * lisp.h: Move EXFUNS for Fframe_root_window,
5287 Fframe_first_window and Fset_frame_selected_window to window.h.
5288
5289 * window.h: Move EXFUNS for Fframe_root_window,
5290 Fframe_first_window and Fset_frame_selected_window here from
5291 lisp.h.
5292
5293 * frame.c (Fwindow_frame, Fframe_first_window)
5294 (Fframe_root_window, Fframe_selected_window)
5295 (Fset_frame_selected_window): Move to window.c.
5296 (Factive_minibuffer_window): Move to minibuf.c.
5297 (Fother_visible_frames_p): New function.
5298
5299 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5300
f230ecc9
MR
5301 * window.c (decode_window, decode_any_window): Move up in code.
5302 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5303 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
5304 (Fwindow_buffer): Move up and rewrite doc-string.
5305 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5306 (Fwindow_prev): New functions.
727e958e
MR
5307 (Fwindow_frame): Move here from frame.c. Accept any window as
5308 argument.
5309 (Fframe_root_window, Fframe_first_window)
5310 (Fframe_selected_window): Move here from frame.c. Accept frame
5311 or arbitrary window as argument. Update doc-strings.
5312 (Fminibuffer_window): Move up in code.
5313 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
5314 (Fset_frame_selected_window): Move here from frame.c.
5315 Marginal rewrite.
727e958e
MR
5316 (Fselected_window, select_window, Fselect_window): Move up in
5317 code. Minor doc-string fixes.
f230ecc9 5318
4d09bcf6
PE
53192011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5320
5321 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5322 Do not assume that spare memory exists; that assumption is valid
5323 only if SYSTEM_MALLOC.
5324 (LARGE_REQUEST): New macro, so that the issue of large requests
5325 is separated from the issue of spare memory.
5326
810928a2
AS
53272011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5328
172418ad
AS
5329 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5330 format. (Bug#8806)
5331
43f862f7
AS
5332 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5333
810928a2
AS
5334 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5335 before statements.
5336
a059fe24
JD
53372011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5338
5339 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5340
5341 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5342
5343 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5344 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5345
989bf368
JB
53462011-06-05 Juanma Barranquero <lekktu@gmail.com>
5347
5348 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5349
4b80f674
CY
53502011-06-04 Chong Yidong <cyd@stupidchicken.com>
5351
5352 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5353 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
5354 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5355 New error handlers.
4b80f674
CY
5356 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5357 Obey Vx_select_enable_clipboard_manager. Catch errors in
5358 x_clipboard_manager_save (Bug#8779).
5359 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 5360 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 5361
99a33b77 53622011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
5363
5364 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5365
99a33b77 53662011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
5367
5368 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5369 in the current matrix if keep_current_p is non-zero.
5370
8264569d
EZ
53712011-06-04 Eli Zaretskii <eliz@gnu.org>
5372
5373 * bidi.c (bidi_level_of_next_char): Fix last change.
5374
57f97249
EZ
53752011-06-03 Eli Zaretskii <eliz@gnu.org>
5376
fec2107c 5377 Support bidi reordering of text covered by display properties.
57f97249 5378
fec2107c
EZ
5379 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5380 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5381 (bidi_cache_search, bidi_cache_iterator_state)
5382 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
5383 (bidi_level_of_next_char, bidi_move_to_visually_next):
5384 Support character positions inside a run of characters covered by a
fec2107c
EZ
5385 display string.
5386 (bidi_paragraph_init, bidi_resolve_explicit_1)
5387 (bidi_level_of_next_char): Call bidi_fetch_char and
5388 bidi_fetch_char_advance instead of FETCH_CHAR and
5389 FETCH_CHAR_ADVANCE.
5390 (bidi_init_it): Initialize new members.
5391 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5392 definitions.
5393 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5394 instead of using explicit *_CHAR codes.
d6d100dd
SM
5395 (bidi_resolve_explicit, bidi_resolve_weak):
5396 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
5397 bidirectional text is supported only in multibyte buffers.
5398 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5399 it to initialize the frame_window_p member of struct bidi_it.
5400 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5401 (bidi_resolve_explicit, bidi_resolve_weak)
5402 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5403 bidi_it->nchars is non-positive.
5404 (bidi_level_of_next_char): Don't try to lookup the cache for the
5405 next/previous character if nothing is cached there yet, or if we
5406 were just reseat()'ed to a new position.
c40e2fb2 5407
0e14fe90
EZ
5408 * xdisp.c (set_cursor_from_row): Set start and stop points
5409 according to the row's direction when priming the loop that looks
5410 for the glyph on which to display cursor.
5411 (single_display_spec_intangible_p): Function deleted.
5412 (display_prop_intangible_p): Reimplement to call
5413 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
5414 Accept 3 additional arguments needed by handle_display_spec.
5415 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
5416 values: lists, `(when COND...)' forms, etc.
5417 (single_display_spec_string_p): Support property values that are
5418 lists with the argument STRING its top-level element.
5419 (display_prop_string_p): Fix the condition for processing a
5420 property that is a list to be consistent with handle_display_spec.
fec2107c 5421 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
5422 last portion of handle_display_prop.
5423 (compute_display_string_pos): Accept additional argument
5424 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5425 value of a `display' property is a "replacing spec".
5426 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5427 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5428 the display property, but just return a value indicating whether
5429 the display property will replace the characters it covers.
5430 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5431 frame_window_p members of struct bidi_it.
d6d100dd
SM
5432 (compute_display_string_pos, compute_display_string_end):
5433 New functions.
fec2107c
EZ
5434 (push_it): Accept second argument POSITION, where pop_it should
5435 jump to continue iteration.
5436 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 5437
fec2107c
EZ
5438 * keyboard.c (adjust_point_for_property): Adjust the call to
5439 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
5440
5441 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
5442 (bidi_init_it): Update prototypes.
5443 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
5444 (compute_display_string_pos, compute_display_string_end):
5445 Declare prototypes.
fec2107c
EZ
5446 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5447 EMACS_INT.
fc6f18ce 5448
40087514 54492011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 5450
57f53182
PE
5451 Malloc failure behavior now depends on size of allocation.
5452 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5453 * lisp.h: Change signatures accordingly.
5454 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5455 All callers changed. (Bug#8762)
5456
5457 * gnutls.c: Use Emacs's memory allocators.
5458 Without this change, the gnutls library would invoke malloc etc.
5459 directly, which causes problems on non-SYNC_INPUT hosts, and which
5460 runs afoul of improving memory_full behavior. (Bug#8761)
5461 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5462 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5463 xfree instead of the default malloc, realloc, free.
5464 (Fgnutls_boot): No need to check for memory allocation failure,
5465 since xmalloc does that for us.
5466
ac32cd99 5467 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
5468 * category.c (hash_get_category_set):
5469 * ccl.c (ccl_driver):
5470 * charset.c (Fdefine_charset_internal):
5471 * charset.h (struct charset.hash_index):
5472 * composite.c (get_composition_id, gstring_lookup_cache)
5473 (composition_gstring_put_cache):
5474 * composite.h (struct composition.hash_index):
5475 * dispextern.h (struct image.hash):
5476 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5477 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5478 (hashfn_equal, hashfn_user_defined, make_hash_table)
5479 (maybe_resize_hash_table, hash_lookup, hash_put)
5480 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5481 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5482 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5483 * image.c (make_image, search_image_cache, lookup_image)
5484 (xpm_put_color_table_h):
5485 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 5486 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 5487 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 5488 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
5489 * alloc.c (allocate_vectorlike):
5490 Check for overflow in vector size calculations.
5491 * ccl.c (ccl_driver):
5492 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
5493 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5494 need to be updated by these changes.
40087514
PE
5495 * fns.c (make_hash_table, maybe_resize_hash_table):
5496 Check for integer overflow with large hash tables.
0de4bb68
PE
5497 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5498 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5499 (SXHASH_REDUCE): New macro.
5500 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5501 Use it instead of discarding useful hash info with large hash values.
5502 (sxhash_float): New function.
5503 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5504 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
5505 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5506 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
5507 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5508 Adjust signatures to match updated version of code.
5509 (consing_since_gc): Now EMACS_INT, since a single hash table can
5510 use more than INT_MAX bytes.
5511
698d32e2
DN
55122011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5513
5514 Make it possible to build with GCC-4.6+ -O2 -flto.
5515
5516 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5517
fd6fa53f
SM
55182011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5519
5520 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5521 Call minibuffer-inactive-mode.
5522
864db017
JB
55232011-05-31 Juanma Barranquero <lekktu@gmail.com>
5524
5525 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5526 Update dependencies.
5527
2ad0baf4
DN
55282011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5529
5530 * data.c (init_data): Remove code for UTS, this system is not
5531 supported anymore.
5532
4fcc2638
DN
55332011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5534
5535 Don't force ./temacs to start in terminal mode.
5536
5537 * frame.c (make_initial_frame): Initialize faces in all cases, not
5538 only when CANNOT_DUMP is defined.
5539 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5540
c56e0fd5
DN
55412011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5542
5543 * dispnew.c (add_window_display_history): Use const for the string
5544 pointer. Remove declaration, not needed.
5545
333d54da 55462011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 5547
55d4c1b2 5548 Use 'inline', not 'INLINE'.
333d54da 5549 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
5550 * alloc.c, fontset.c (INLINE): Remove.
5551 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5552 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5553 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5554 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5555 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5556
738db178
DN
55572011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5558
5559 Make it possible to run ./temacs.
5560
5561 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5562 syms_of_callproc does the same thing. Remove test for
5563 "initialized", do it in the caller.
5564 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5565
620c53a6
SM
55662011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5567
5568 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5569 (read_minibuf): Use get_minibuffer.
5570 (syms_of_minibuf): Use DEFSYM.
5571 (Qmetadata): New var.
5572 * data.c (Qbuffer): Don't make it static.
5573 (syms_of_data): Use DEFSYM.
5574
e003a292
PE
55752011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5576
5577 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5578 (CCL_CODE_MIN): New macro.
5579
ed008a6d
PE
55802011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5581
3687c2ef
PE
5582 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5583
ed008a6d
PE
5584 * eval.c (Qdebug): Now static.
5585 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5586 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5587 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5588
d66c4c7c
CY
55892011-05-29 Chong Yidong <cyd@stupidchicken.com>
5590
5591 * image.c: Various fixes to ImageMagick code comments.
5592 (Fimagemagick_types): Doc fix.
5593
5fbc2025
PE
55942011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5595
0196f88a
PE
5596 Minor fixes prompted by GCC 4.6.0 warnings.
5597
5598 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5599
5fbc2025
PE
5600 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5601 (x_clipboard_manager_save_all): Move extern decl to ...
5602 * xterm.h: ... here, so that it can be checked for consistency.
5603
1dd3c2d9
CY
56042011-05-29 Chong Yidong <cyd@stupidchicken.com>
5605
5606 * xselect.c (x_clipboard_manager_save_frame)
5607 (x_clipboard_manager_save_all): New functions.
5608 (Fx_clipboard_manager_save): Lisp function deleted.
5609
5610 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5611 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5612
5613 * xterm.h: Update prototype.
5614
5ba6571d
WX
56152011-05-28 William Xu <william.xwl@gmail.com>
5616
5617 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5618 exiting (Bug#8239).
5619
3eaff834
JM
56202011-05-28 Jim Meyering <meyering@redhat.com>
5621
e1900994 5622 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
5623 * fns.c (to_uchar): Define.
5624 (crypto_hash_function): Use it to convert some newly-signed
5625 variables to unsigned, to avoid sign-extension bugs. For example,
5626 without this change, (md5 "truc") would evaluate to
5627 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5628 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 5629 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 5630
0f6990a7
PE
56312011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5632
5633 Integer overflow fixes.
c8a9ca5a 5634
08686060
PE
5635 * dbusbind.c: Serial number integer overflow fixes.
5636 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
5637 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5638 to hold a serial number that is too large for a fixnum.
5639 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5640 Check for serial numbers out of range. Decode any serial number
59568bf0 5641 that was so large that it became a float. (Bug#8722)
08686060 5642
2d1fc3c7
PE
5643 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5644 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5645 Use XFASTINT rather than XUINT when numbers are nonnegative.
5646 (xd_append_arg, Fdbus_method_return_internal):
5647 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5648 arguments, check that Lisp number is nonnegative, rather than
59568bf0 5649 silently wrapping negative numbers around. (Bug#8722)
30217ff0 5650 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 5651 (Bug#8722)
2d1fc3c7 5652
c8a9ca5a
PE
5653 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5654
519e1d69
PE
5655 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5656
30569699
PE
5657 ccl: add integer overflow checks
5658 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5659 (IN_INT_RANGE): New macros.
5660 (ccl_driver): Use them to check for integer overflow when
5661 decoding a CCL program. Many of the new checks are whether XINT (x)
5662 fits in int; it doesn't always, on 64-bit hosts. The new version
5663 doesn't catch all possible integer overflows, but it's an
847044ea 5664 improvement. (Bug#8719)
30569699 5665
c11285dc
PE
5666 * alloc.c (make_event_array): Use XINT, not XUINT.
5667 There's no need for unsigned here.
5668
fdccd48e
PE
5669 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5670 This follows up to the 2011-05-06 change that substituted uintptr_t
5671 for EMACS_INT. This case wasn't caught back then.
5672
37910ab2
PE
5673 Rework Fformat to avoid integer overflow issues.
5674 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5675 now (part of C89). Include <verify.h>.
5676 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5677 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5678 (Fformat): Avoid the prepass trying to compute sizes; it was only
5679 approximate and thus did not catch overflow reliably. Instead, walk
5680 through the format just once, formatting and computing sizes as we go,
5681 checking for integer overflow at every step, and allocating a larger
5682 buffer as needed. Keep track separately whether the format is
5683 multibyte. Keep only the most-recently calculated precision, rather
5684 than them all. Record whether each argument has been converted to
5685 string. Use EMACS_INT, not int, for byte and char and arg counts.
5686 Support field widths and precisions larger than INT_MAX. Avoid
5687 sprintf's undefined behavior with conversion specifications such as %#d
5688 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5689 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5690 formatting out-of-range floating point numbers with int
9173deec 5691 formats. (Bug#8668)
37910ab2 5692
2e6578fb
PE
5693 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5694
0ae6bdee
PE
5695 * data.c: Avoid integer truncation in expressions involving floats.
5696 * data.c: Include <intprops.h>.
5697 (arith_driver): When there's an integer overflow in an expression
5698 involving floating point, convert the integers to floating point
5699 so that the resulting value does not suffer from catastrophic
5700 integer truncation. For example, on a 64-bit host (* 4
5701 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5702 Do not rely on undefined behavior after integer overflow.
5703
de883a70
PE
5704 merge count_size_as_multibyte, parse_str_to_multibyte
5705 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 5706 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
5707 Check for integer overflow.
5708 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5709 since it's now a duplicate of the other. This is more of
5710 a character than a buffer op, so better that it's in character.c.
5711 * fns.c, print.c: Adjust to above changes.
5712
2ff916cb
PE
57132011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5714
5715 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5716
f1b54466
PE
57172011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5718
fb1ac845
PE
5719 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5720 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5721 (x_clipboard_manager_save): Now static.
5722 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5723
f1b54466
PE
5724 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5725 (crypto_hash_function): Now static.
5726 Fix pointer signedness problems. Avoid unnecessary initializations.
5727
a9f737ee
CY
57282011-05-27 Chong Yidong <cyd@stupidchicken.com>
5729
5730 * termhooks.h (Vselection_alist): Make it terminal-local.
5731
5732 * terminal.c (create_terminal): Initialize it.
5733
5734 * xselect.c: Support for clipboard managers.
5735 (Vselection_alist): Move to termhooks.h as terminal-local var.
5736 (LOCAL_SELECTION): New macro.
5737 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5738 (symbol_to_x_atom): Remove gratuitous arg.
5739 (x_handle_selection_request, lisp_data_to_selection_data)
5740 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
5741 (x_own_selection, x_get_local_selection, x_convert_selection):
5742 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
5743 (some_frame_on_display): Delete unused function.
5744 (Fx_own_selection_internal, Fx_get_selection_internal)
5745 (Fx_disown_selection_internal, Fx_selection_owner_p)
5746 (Fx_selection_exists_p): New optional frame arg.
5747 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5748 (x_handle_selection_clear): Don't treat other terminals with the
5749 same keyboard specially. Use the terminal-local Vselection_alist.
5750 (x_clear_frame_selections): Use Frun_hook_with_args.
5751
5752 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5753
5754 * xterm.h: Add support for those atoms.
5755
e067f0c1
CY
57562011-05-26 Chong Yidong <cyd@stupidchicken.com>
5757
5758 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5759 (converted_selections, conversion_fail_tag): New global variables.
5760 (x_selection_request_lisp_error): Free the above.
5761 (x_get_local_selection): Remove unnecessary code.
5762 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
5763 of converted selections stored in converted_selections.
5764 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
5765 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5766 (x_convert_selection): New function.
5767 (x_handle_selection_event): Simplify.
5768 (x_get_foreign_selection): Don't ignore incoming requests while
5769 waiting for an answer; this will fail when we implement
5770 SAVE_TARGETS, and seems unnecessary anyway.
5771 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5772 (Vx_sent_selection_functions): Doc fix.
5773
0f4aebc0
LL
57742011-05-26 Leo Liu <sdl.web@gmail.com>
5775
5776 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5777
e61124cd
YM
57782011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5779
5780 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5781
5782 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5783 for fringe update if it has periodic bitmap.
ac389d0c 5784 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
5785 and fringe_bitmap_periodic_p.
5786
5787 * fringe.c (get_fringe_bitmap_data): New function.
5788 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5789 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5790 row. Mark glyph row for fringe update if periodicity changed.
5791
5792 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5793 for fringe update unless it has periodic bitmap.
5794
f16d9837
KH
57952011-05-25 Kenichi Handa <handa@m17n.org>
5796
5797 * xdisp.c (get_next_display_element): Set correct it->face_id for
5798 a static composition.
5799
e1b90ef6
LL
58002011-05-24 Leo Liu <sdl.web@gmail.com>
5801
5802 * deps.mk (fns.o):
5803 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5804
5805 * fns.c (crypto_hash_function, Fsha1): New function.
5806 (Fmd5): Use crypto_hash_function.
5807 (syms_of_fns): Add Ssha1.
5808
7400048f
PE
58092011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5810
5811 * gnutls.c: Remove unused macros.
5812 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5813 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5814 Remove macros that are defined and never used.
5815 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5816
abb71cf4
CY
58172011-05-22 Chong Yidong <cyd@stupidchicken.com>
5818
5819 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5820 (Fx_get_selection_internal): Minor cleanup.
5821 (Fx_own_selection_internal): Rename arguments for consistency with
5822 select.el.
5823
6307db39
PE
58242011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5825
5826 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5827
f3d4e0a4
CY
58282011-05-22 Chong Yidong <cyd@stupidchicken.com>
5829
5830 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5831
4d8ade89
YM
58322011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5833
5834 * dispnew.c (scrolling_window): Don't exclude the case that the
5835 last enabled row in the desired matrix touches the bottom boundary.
5836
32078c8d
GM
58372011-05-21 Glenn Morris <rgm@gnu.org>
5838
5839 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
5840 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5841 and add some more files.
32078c8d 5842
7285dc67
EZ
58432011-05-20 Eli Zaretskii <eliz@gnu.org>
5844
5845 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5846 report_file_error introduced by the change from 2011-05-07.
5847
89d1bd22
PE
58482011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5849
5850 * systime.h (Time): Define only if emacs is defined.
5851 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5852 where the include path doesn't have X11/X.h by default. See
5853 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5854
cd394be1 58552011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
5856
5857 * composite.c (find_automatic_composition): Fix previous change.
5858
b9704ad9
GM
58592011-05-20 Glenn Morris <rgm@gnu.org>
5860
5861 * lisp.mk: New file, split from Makefile.in.
5862 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5863 (shortlisp): Remove.
5864 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5865
4a720484
GM
58662011-05-19 Glenn Morris <rgm@gnu.org>
5867
5868 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5869 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5870 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5871 (lisp): Set the order to that of loadup.el.
5872 (shortlisp): Make it a copy of $lisp.
5873 (SOME_MACHINE_LISP): Remove.
5874 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5875 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5876
a28d4396
KH
58772011-05-18 Kenichi Handa <handa@m17n.org>
5878
5879 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5880 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5881 (find_automatic_composition): Mostly rewrite for efficiency.
5882
a2b1fa8e
JB
58832011-05-18 Juanma Barranquero <lekktu@gmail.com>
5884
5885 * makefile.w32-in: Update dependencies.
5886
8e1f5610
CS
58872011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5888
5889 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 5890 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 5891
7025ee00 58922011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 5893
cdfa6eab
PE
5894 Fix some integer overflow issues, such as string length overflow.
5895
06d6db33
PE
5896 * insdel.c (count_size_as_multibyte): Check for string overflow.
5897
2b4560a8
PE
5898 * character.c (lisp_string_width): Check for string overflow.
5899 Use EMACS_INT, not int, for string indexes and lengths; in
5900 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5901 the resulting string length overflows an EMACS_INT; instead,
5902 report a string overflow if no precision given. When checking for
5903 precision exhaustion, use a check that cannot possibly have
5904 integer overflow. (Bug#8675)
5905 * character.h (lisp_string_width): Adjust to new signature.
5906
cb93f9be
PE
5907 * alloc.c (string_overflow): New function.
5908 (Fmake_string): Use it. This doesn't change behavior, but saves
5909 a few bytes and will simplify future changes.
5910 * character.c (string_escape_byte8): Likewise.
5911 * lisp.h (string_overflow): New decl.
5912
1a1f3366
PE
5913 Fixups, following up to the user-interface timestamp change.
5914 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5915 for UI timestamps, instead of unsigned long.
9fbd6841
PE
5916 * msdos.c (mouse_get_pos): Likewise.
5917 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
5918 * w32gui.h (Time): Define by including "systime.h" rather than by
5919 declaring it ourselves. (Bug#8664)
5920
d4e3e4d3
PE
5921 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5922 * image.c (clear_image_cache): Likewise.
5923
f6a24d19
PE
5924 * term.c (term_mouse_position): Don't assume time_t wraparound.
5925
08dc5ae6
PE
5926 Be more systematic about user-interface timestamps.
5927 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
5928 and sometimes 'EMACS_UINT', to represent these timestamps.
5929 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
5930 This makes the code easier to follow, and makes it easier to catch
5931 integer overflow bugs such as Bug#8664.
5932 * frame.c (Fmouse_position, Fmouse_pixel_position):
5933 Use Time, not unsigned long, for user-interface timestamps.
5934 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5935 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5936 * keyboard.h (last_event_timestamp): Likewise.
5937 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5938 * menu.h (xmenu_show): Likewise.
5939 * term.c (term_mouse_position): Likewise.
5940 * termhooks.h (struct input_event.timestamp): Likewise.
5941 (struct terminal.mouse_position_hook): Likewise.
5942 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5943 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5944 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5945 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5946 what it was before.
5947 * menu.h, termhooks.h: Include "systime.h", for Time.
5948
8e55734a
PE
5949 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5950 Don't assume that the difference between two unsigned long values
5951 can fit into an integer. At this point, we know button_down_time
5952 <= event->timestamp, so the difference must be nonnegative, so
5953 there's no need to cast the result if double-click-time is
5954 nonnegative, as it should be; check that it's nonnegative, just in
5955 case. This bug is triggered when events are more than 2**31 ms
86db42d2 5956 apart (about 25 days). (Bug#8664)
8e55734a 5957
841f1b75 5958 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 5959 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 5960
3e26f69c
PE
5961 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5962 that always fit in int. Use a sentinel instead of a counter, to
5963 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
5964 * frame.h (struct frame): Use int for menu_bar_items_used
5965 instead of EMACS_INT, since it always fits in int.
3e26f69c 5966
5cc152c0
PE
5967 * menu.c (grow_menu_items): Check for int overflow.
5968
d89eb65e
PE
5969 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5970
5235bd3e
PE
5971 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5972 Before, the code was not consistent. These values cannot exceed
5973 2**31 - 1 so there's no need to make them unsigned.
5974 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5975 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5976 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5977 as modifiers.
5978 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5979
bc827e23
PE
5980 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5981 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5982 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5983 presumably because the widths might not match.
5984
78eb494e
PE
5985 * window.c (size_window): Avoid needless test at loop start.
5986
04f2d78b
CB
59872011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5988
5989 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5990
d2fc7e3d 59912011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
5992
5993 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5994
d2fc7e3d 59952011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
5996
5997 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5998 `width' to `bar_area_x' and `bar_area_width', respectively.
5999 (x_scroll_run): Take account of fringe background extension.
6000
04f2d78b
CB
6001 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6002 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
6003 `bar_area_width', respectively.
6004 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6005 background extension.
6006
79b70037
GM
60072011-05-10 Jim Meyering <meyering@redhat.com>
6008
6009 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6010
2f142cc5
JB
60112011-05-10 Juanma Barranquero <lekktu@gmail.com>
6012
6013 * image.c (Finit_image_library): Return t for built-in image types,
6014 like pbm and xbm. (Bug#8640)
6015
57679c86
AS
60162011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6017
6018 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6019
888c9e86
EZ
60202011-05-07 Eli Zaretskii <eliz@gnu.org>
6021
b0512a1d
EZ
6022 * w32console.c (Fset_screen_color): Doc fix.
6023 (Fget_screen_color): New function.
6024 (syms_of_ntterm): Defsubr it.
6025
7285dc67
EZ
6026 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6027 unlink the temporary file if Fcall_process didn't create it in the
6028 first place.
6029 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6030 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
6031 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6032 cue to call_process_cleanup not to close that handle.
6033
4d3fcc8e
BK
60342011-05-07 Ben Key <bkey76@gmail.com>
6035
6036 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6037 one of two shell specific rules, either bootstrap-temacs-CMD or
6038 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6039 to the previous implementation of the bootstrap-temacs rule.
6040 The bootstrap-temacs-CMD rule is similar to the previous
6041 implementation of the bootstrap-temacs rule except that it
6042 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6043 variable.
6044
6045 These changes, along with some changes to nt/configure.bat,
6046 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6047 earlier fix to add support for --cflags and --ldflags options
6048 that include quotes so that it works whether make uses cmd or
6049 sh as the shell.
6050
b4289b64
MA
60512011-05-06 Michael Albinus <michael.albinus@gmx.de>
6052
6053 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6054 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6055 is a constant.
6056 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6057 a string. Handle both cases.
6058 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6059 (Fdbus_register_method): Use Qinvalid_function.
6060
af4c0e28
JB
60612011-05-06 Juanma Barranquero <lekktu@gmail.com>
6062
6063 * makefile.w32-in: Update dependencies.
6064 (LISP_H): Add inttypes.h and stdin.h.
6065 (PROCESS_H): Add unistd.h.
6066
c51453d9
EZ
60672011-05-06 Eli Zaretskii <eliz@gnu.org>
6068
6069 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6070 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6071
8ff0ac3c 60722011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 6073
4c4b566b
PE
6074 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6075
aab2b9b5
PE
6076 * term.c (vfatal): Remove stray call to va_end.
6077 It's not needed and the C Standard doesn't allow it here anyway.
6078
c378da0b
PE
6079 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6080 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6081
288b08c7
PE
6082 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6083 bytes.
6084
e3601888
PE
6085 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6086
db6c0e74
PE
6087 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6088
dd5963ea
PE
6089 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6090
88c9450f
PE
6091 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6092
2f9442b8
PE
6093 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6094
c032b5f8
PE
6095 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6096 * charset.c (Fdefine_charset_internal): Don't initialize
6097 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 6098 32-bit int (Bug#8600).
a108c10b
PE
6099
6100 * lread.c (read_integer): Be more consistent with string-to-number.
6101 Use string_to_number to do the actual conversion; this avoids
6102 rounding errors and fixes some other screwups. Without this fix,
6103 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6104 (digit_to_number): Move earlier, for benefit of read_integer.
6105 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 6106 not a digit in any supported base. (Bug#8602)
a108c10b 6107
ad5f9eea
PE
6108 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6109
aec1708a
PE
6110 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6111 to match comment at start of function. This also removes a
6112 GCC warning about overflow in a 32+64-bit port.
6113
47be4ab5
PE
6114 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6115
371cac43
PE
6116 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6117 Reported by Stefan Monnier in
6118 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
6119 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6120 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 6121
d01a7826
PE
6122 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6123 (EMACS_UINTPTR): Likewise, with uintptr_t.
6124
7fd47d5c
PE
6125 * lisp.h: Prefer 64-bit EMACS_INT if available.
6126 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6127 on 32-bit hosts that have 64-bit int, so that they can access
6128 large files.
122b0c86
PE
6129 However, temporarily disable this change unless the temporary
6130 symbol WIDE_EMACS_INT is defined.
7fd47d5c 6131
8727937b
PE
6132 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6133
8ac068ac
PE
6134 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6135 This removes an assumption that EMACS_INT and long are the same
6136 width as pointers. The assumption is true for Emacs porting targets
6137 now, but we want to make other targets possible.
6138 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6139 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6140 In the rest of the code, change types of integers that hold casted
6141 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6142 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6143 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6144 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6145 No need to cast type when ORing.
6146 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6147 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6148 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6149 assume EMACS_INT is the same width as char *.
6150 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6151 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6152 Remove no-longer-needed casts.
6153 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6154 (xg_tool_bar_help_callback, xg_make_tool_item):
6155 Use EMACS_INTPTR to hold an integer
6156 that will be cast to void *; this can avoid a GCC warning
6157 if EMACS_INT is not the same width as void *.
6158 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6159 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6160 (current_message_1, set_message_1):
6161 Use a local to convert to proper width without a cast.
6162 * xmenu.c (dialog_selection_callback): Likewise.
6163
ede49d71
PE
6164 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6165 Also, don't assume VALBITS / RAND_BITS is less than 5,
6166 and don't rely on undefined behavior when shifting a 1 left into
6167 the sign bit.
6168 * lisp.h (get_random): Change signature to match.
6169
2f30ecd0
PE
6170 * lread.c (hash_string): Use size_t, not int, for hash computation.
6171 Normally we prefer signed values; but hashing is special, because
6172 it's better to use unsigned division on hash table sizes so that
6173 the remainder is nonnegative. Also, size_t is the natural width
6174 for hashing into memory. The previous code used 'int', which doesn't
6175 retain enough info to hash well into very large tables.
6176 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6177
2a866e7b
PE
6178 * dbusbind.c: Don't possibly lose pointer info when converting.
6179 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6180 Use XPNTR rather than XHASH, so that the high-order bits of
6181 the pointer aren't lost when converting through void *.
6182
51639eac
PE
6183 * eval.c (Fautoload): Don't double-shift a pointer.
6184
92394119
PE
6185 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6186
dbdb9a7c
JB
61872011-05-06 Juanma Barranquero <lekktu@gmail.com>
6188
6189 * gnutls.c (DEF_GNUTLS_FN):
6190 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6191
db7a0b4f
AS
61922011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6193
6194 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6195 marker. (Bug#8610)
6196
cd394be1 61972011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
6198
6199 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6200 New version that can reserve upto 2GB of heap space.
6201
f7ff1b0f 62022011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
6203
6204 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6205
639c109b
TZ
62062011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6207
6208 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6209 `gnutls_certificate_set_x509_key_file'.
6210
d2127135
JB
62112011-05-05 Juanma Barranquero <lekktu@gmail.com>
6212
6213 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6214 Update dependencies.
6215
e968f4f3
JB
62162011-05-04 Juanma Barranquero <lekktu@gmail.com>
6217
6218 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6219 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6220 Remove unused parameter `fildes'.
6221 * process.c (read_process_output, send_process): Don't pass it.
6222
84d358f0
JB
62232011-05-04 Juanma Barranquero <lekktu@gmail.com>
6224
6225 Fix previous change: the library cache is defined in w32.c.
6226 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6227 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6228
0898ca10
JB
62292011-05-04 Juanma Barranquero <lekktu@gmail.com>
6230
6231 Implement dynamic loading of GnuTLS on Windows.
6232
6233 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6234 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6235 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6236 Declare.
6237
6238 * gnutls.c (Qgnutls_dll): Define.
6239 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6240 (gnutls_*): Declare function pointers.
6241 (init_gnutls_functions): New function to initialize function pointers.
6242 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6243 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6244 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6245 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6246 (emacs_gnutls_write, emacs_gnutls_read)
6247 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6248 (Fgnutls_available_p): New function.
6249 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6250 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6251 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6252
6253 * image.c: Include w32.h.
6254 (Vimage_type_cache): Delete.
6255 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6256 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6257 (w32_delayed_load): Move to w32.c.
6258
6259 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6260
6261 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6262 (w32_delayed_load): Move from image.c. When loading a library, record
6263 its filename in the :loaded-from property of the library id.
6264 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6265 Initialize and staticpro them.
6266 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6267
6268 * process.c: Include lisp.h before w32.h, not after.
6269 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6270 instead of gnutls_record_check_pending.
6271
6272 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6273
ff4de4aa
TZ
62742011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6275
6276 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6277 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6278 as passed in.
6279
abe95abb
JD
62802011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6281
6282 * xterm.c (x_set_frame_alpha): Do not set property on anything
6283 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6284
e16e55d4
JB
62852011-05-02 Juanma Barranquero <lekktu@gmail.com>
6286
6287 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6288
bafcf6a5
JB
62892011-05-02 Juanma Barranquero <lekktu@gmail.com>
6290
6291 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6292 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6293 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6294 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6295 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6296 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6297 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6298 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6299 (Qgnutls_bootprop_callbacks_verify): Make static.
6300
e7a6747f
AS
63012011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6302
19ed11ba
AS
6303 * callproc.c: Indentation fixup.
6304
e7a6747f 6305 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
6306 (wait_for_termination, interruptible_wait_for_termination):
6307 Move after wait_for_termination_1.
e7a6747f 6308
1ef14cb4
LMI
63092011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6310
6311 * sysdep.c (interruptible_wait_for_termination): New function
6312 which is like wait_for_termination, but allows keyboard
6313 interruptions.
6314
6315 * callproc.c (Fcall_process): Add (:file "file") as an option for
6316 the STDOUT buffer.
6317 (Fcall_process_region): Ditto.
6318
330d880c
EZ
63192011-04-30 Eli Zaretskii <eliz@gnu.org>
6320
8db90b73
EZ
6321 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6322 rather than `XVECTOR (FOO)->size'.
6323
330d880c
EZ
6324 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6325 inttypes.h, as a gnulib replacement is used if it not available in
6326 system headers.
6327
15cbd324
EZ
63282011-04-21 Eli Zaretskii <eliz@gnu.org>
6329
6330 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6331 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6332 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6333
6334 * coding.c (coding_alloc_by_realloc): Error out if destination
6335 will grow beyond MOST_POSITIVE_FIXNUM.
6336 (decode_coding_emacs_mule): Abort if there isn't enough place in
6337 charbuf for the composition carryover bytes. Reserve an extra
6338 space for up to 2 characters produced in a loop.
6339 (decode_coding_iso_2022): Abort if there isn't enough place in
6340 charbuf for the composition carryover bytes.
6341
63422011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 6343
ae940cca
EZ
6344 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6345 aborting when %lld or %lll format is passed.
6346 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6347 %llo or %llx format is passed. (Bug#8545)
6348
03ab8921
EZ
6349 * window.c (window_scroll_line_based): Use a marker instead of
6350 simple variables to record original value of point. (Bug#7952)
6351
afda1437
EZ
6352 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6353 produced by %s or %c overflows available buffer space. (Bug#8545)
6354
f76dee0c
PE
63552011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6356
6357 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 6358 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 6359
fdc5744d
JB
63602011-04-28 Juanma Barranquero <lekktu@gmail.com>
6361
6362 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6363
638f053a
JB
63642011-04-28 Juanma Barranquero <lekktu@gmail.com>
6365
6366 * keyboard.c (Qdelayed_warnings_hook): Define.
6367 (command_loop_1): Run `delayed-warnings-hook'
6368 if Vdelayed_warnings_list is non-nil.
6369 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6370 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6371
d178f871
EZ
63722011-04-28 Eli Zaretskii <eliz@gnu.org>
6373
6374 * doprnt.c (doprnt): Don't return value smaller than the buffer
6375 size if the message was truncated. (Bug#8545).
6376
b124fd93
JB
63772011-04-28 Juanma Barranquero <lekktu@gmail.com>
6378
6379 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6380 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6381
e810457d
PE
63822011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6383
6384 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6385
ea51cceb
JB
63862011-04-27 Juanma Barranquero <lekktu@gmail.com>
6387
6388 * makefile.w32-in: Update dependencies.
6389
94dcfacf
EZ
63902011-04-27 Eli Zaretskii <eliz@gnu.org>
6391
6392 Improve `doprnt' and its usage. (Bug#8545)
6393 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6394 `format_end'. Remove support for %l as a conversion specifier.
6395 Don't use xrealloc. Improve diagnostics when the %l size modifier
6396 is used. Update the commentary.
6397
6398 * eval.c (verror): Simplify calculation of size_t.
6399
6400 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6401 messages.
6402
f61f41d7
PE
64032011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6404
6405 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6406 change.
6407
96fb4434
PE
64082011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6409
6410 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6411 This makes this file independent of the recent pseudovector change.
6412
671875da 64132011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 6414
69e9b5a3
PE
6415 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6416
b5f869a7 6417 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 6418 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 6419 Remove unused local.
c8926152 6420 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 6421
841a1577 6422 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
6423 GCC 4.6.0 optimizes based on type-based alias analysis.
6424 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
6425 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6426 != &v->size, and therefore "v->size = 1; b->size = 2; return
6427 v->size;" must therefore return 1. This assumption is incorrect
6428 for Emacs, since it type-puns struct Lisp_Vector * with many other
6429 types. To fix this problem, this patch adds a new type struct
f904488f 6430 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
6431 and pseudovectors, and helps optimizing compilers not get fooled
6432 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6433 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
6434 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6435 the size member.
eab3844f
PE
6436 (XSETPVECTYPE): Rewrite in terms of new macro.
6437 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6438 This is a bit clearer, and further avoids the possibility of
6439 undesirable aliasing.
6440 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 6441 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
6442 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6443 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
6444 (ASIZE): Now uses header.size rather than size.
6445 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
6446 to avoid the hassle of writing XVECTOR (foo)->header.size.
6447 (struct vectorlike_header): New type.
eab3844f
PE
6448 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6449 object, to help avoid aliasing.
6450 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6451 (SUBRP): Likewise, since Lisp_Subr is a special case.
6452 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6453 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6454 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 6455 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
6456 changed to be "header.size" and "header.next".
6457 * buffer.h (struct buffer): Likewise.
6458 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6459 * frame.h (struct frame): Likewise.
6460 * process.h (struct Lisp_Process): Likewise.
6461 * termhooks.h (struct terminal): Likewise.
6462 * window.c (struct save_window_data, struct saved_window): Likewise.
6463 * window.h (struct window): Likewise.
6464 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6465 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6466 * buffer.c (init_buffer_once): Likewise.
6467 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6468 special case.
6469 * process.c (Fformat_network_address): Use local var for size,
6470 for brevity.
6471
0df1eac5
PE
6472 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6473
847ab9d1 6474 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
6475 * data.c (atof): Remove decl; no longer used or needed.
6476 (digit_to_number): Move to lread.c.
6477 (Fstring_to_number): Use new string_to_number function, to be
6478 consistent with how the Lisp reader treats infinities and NaNs.
6479 Do not assume that floating-point numbers represent EMACS_INT
6480 without losing information; this is not true on most 64-bit hosts.
6481 Avoid double-rounding errors, by insisting on integers when
6482 parsing non-base-10 numbers, as the documentation specifies.
6483 * lisp.h (string_to_number): New decl, replacing ...
6484 (isfloat_string): Remove.
bc0a5c13 6485 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 6486 (read1): Do not accept +. and -. as integers; this
452f4150
PE
6487 appears to have been a coding error. Similarly, do not accept
6488 strings like +-1e0 as floating point numbers. Do not report
6489 overflow for integer overflows unless the base is not 10 which
6490 means we have no simple and reliable way to continue.
6491 Break out the floating-point parsing into a new
6492 function string_to_number, so that Fstring_to_number parses
6493 floating point numbers consistently with the Lisp reader.
04f2d78b 6494 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
6495 (E_CHAR, EXP_INT): Remove, replacing with ...
6496 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6497 (string_to_number): New function, replacing isfloat_string.
6498 This function checks for valid syntax and produces the resulting
6499 Lisp float number too. Rework it so that string-to-number
bc0a5c13 6500 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
6501 so that overflow for non-base-10 numbers is reported only when
6502 there's no portable and simple way to convert to floating point.
452f4150 6503
67769ffc
PE
6504 * textprop.c (set_text_properties_1): Rewrite for clarity,
6505 and to avoid GCC warning about integer overflow.
6506
c20db43f
PE
6507 * intervals.h (struct interval): Use EMACS_INT for members
6508 where EMACS_UINT might cause problems. See
6509 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6510 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6511 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6512 All uses changed.
37aa2f85
PE
6513 (offset_intervals): Tell GCC not to worry about length overflow
6514 when negating a negative length.
c20db43f 6515
2538aa2f
PE
6516 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6517 (overrun_check_free): Likewise.
6518
f2d3008d
PE
6519 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6520 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6521 word size.
6522
ec8df744
PE
6523 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6524 (gnutls_make_error): Rename local to avoid shadowing.
6525 (gnutls_emacs_global_deinit): ifdef out; not used.
6526 (Fgnutls_boot): Use const for pointer to readonly storage.
6527 Comment out unused local. Fix pointer signedness problems.
6528
640ee02d
PE
6529 * lread.c (openp): Don't stuff size_t into an 'int'.
6530 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6531 about possible signed overflow.
6532
6048fb2a
PE
6533 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6534 (GDK_KEY_g): Don't define if already defined.
6535 (xg_prepare_tooltip): Avoid pointer signedness problem.
6536 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6537
fa3c87e1
PE
6538 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6539 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6540
2172544b
PE
6541 * xfns.c (Fx_window_property): Simplify a bit,
6542 to make a bit faster and to avoid GCC 4.6.0 warning.
6543 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6544
9b821a21
PE
6545 * fns.c (internal_equal): Don't assume size_t fits in int.
6546
3c616cfa
PE
6547 * alloc.c (compact_small_strings): Tighten assertion a little.
6548
c2982e87
PE
6549 Replace pEd with more-general pI, and fix some printf arg casts.
6550 * lisp.h (pI): New macro, generalizing old pEd macro to other
6551 conversion specifiers. For example, use "...%"pI"d..." rather
6552 than "...%"pEd"...".
6553 (pEd): Remove. All uses replaced with similar uses of pI.
6554 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6555 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6556 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6557 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6558 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6559 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6560 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6561 64-bit hosts.
6562 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6563 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6564 * print.c (safe_debug_print, print_object): Likewise.
6565 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6566 to int.
6f04d126
PE
6567 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6568 avoiding the 0 flag, which is not portable.
c2982e87
PE
6569 * process.c (Fmake_network_process): Use pI to avoid cast.
6570 * region-cache.c (pp_cache): Likewise.
6571 * xdisp.c (decode_mode_spec): Likewise.
6572 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6573 behavior on 64-bit hosts with printf arg.
6f04d126 6574 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
6575 (x_stop_queuing_selection_requests): Likewise.
6576 (x_get_window_property): Don't truncate byte count to an 'int'
6577 when tracing.
0b432f21 6578
5e073ec7
PE
6579 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6580 here, since it parses constructs like leading '-' and spaces,
6581 which are not wanted; and it overflows with large numbers.
6582 Instead, simply match F[0-9]+, which is what is wanted anyway.
6583
36372bf9
PE
6584 * alloc.c: Remove unportable assumptions about struct layout.
6585 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6586 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6587 (allocate_vectorlike, make_pure_vector): Use the new macros,
6588 plus offsetof, to remove unportable assumptions about struct layout.
6589 These assumptions hold on all porting targets that I know of, but
6590 they are not guaranteed, they're easy to remove, and removing them
6591 makes further changes easier.
6592
0b432f21
PE
6593 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6594 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
6595 (string_overrun_cookie): Now const. Use initializers that
6596 don't formally overflow signed char, to avoid warnings.
000098c1
PE
6597 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6598 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
6599 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6600 multiple of sizeof (EMACS_INT); it need not be, if
6601 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 6602 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 6603
895009e1
JB
66042011-04-26 Juanma Barranquero <lekktu@gmail.com>
6605
6606 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6607
6a7a1b0b
TZ
66082011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6609
6610 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 6611 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
6612 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6613
841a1577 66142011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
6615
6616 * lisp.h (Qdebug): List symbol.
895009e1 6617 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
6618 * keyboard.c (debug-on-event): New variable.
6619 (handle_user_signal): Break into debugger when debug-on-event
6620 matches the current signal symbol.
6621
f2d3ba6f
DN
66222011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6623
6624 * alloc.c (check_sblock, check_string_bytes)
6625 (check_string_free_list): Convert to standard C.
6626
42ce4c63
TZ
66272011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6628
6629 * w32.c (emacs_gnutls_push): Fix typo.
6630
825cd63c
EZ
66312011-04-25 Eli Zaretskii <eliz@gnu.org>
6632
fb11d64d
EZ
6633 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6634 "cast to pointer from integer of different size".
6635
825cd63c
EZ
6636 Improve doprnt and its use in verror. (Bug#8545)
6637 * doprnt.c (doprnt): Document the set of format control sequences
6638 supported by the function. Use SAFE_ALLOCA instead of always
6639 using `alloca'.
6640
6641 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6642 is one byte too soon. Don't use xrealloc; instead xfree and
6643 xmalloc anew.
6644
e061a11b
TZ
66452011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6646
6647 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6648 callbacks stage.
6649
6650 * gnutls.c: Renamed global_initialized to
6651 gnutls_global_initialized. Added internals for the
6652 :verify-hostname-error, :verify-error, and :verify-flags
6653 parameters of `gnutls-boot' and documented those parameters in the
6654 docstring. Start callback support.
9173deec
JB
6655 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6656 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6657 on error. Return error code.
e061a11b
TZ
6658 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6659 (emacs_gnutls_read): Likewise.
6660 (Fgnutls_boot): Return handshake error code.
6661 (emacs_gnutls_handle_error): New function.
6662 (wsaerror_to_errno): Likewise.
6663
6664 * w32.h (emacs_gnutls_pull): Add prototype.
6665 (emacs_gnutls_push): Likewise.
6666
6667 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6668 (emacs_gnutls_push): Likewise.
6669
66702011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6671
6672 * process.c (wait_reading_process_output): Check if GnuTLS
6673 buffered some data internally if no FDs are set for TLS
6674 connections.
6675
6676 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6677 (LIBS): Link to USER_LIBS.
6678 ($(BLD)/gnutls.$(0)): New target.
6679
fa6996bc
EZ
66802011-04-24 Eli Zaretskii <eliz@gnu.org>
6681
eb35682e
EZ
6682 * xdisp.c (handle_single_display_spec): Rename the
6683 display_replaced_before_p argument into display_replaced_p, to
6684 make it consistent with the commentary. Fix typos in the
6685 commentary.
6686
e2ad650c
EZ
6687 * textprop.c (syms_of_textprop): Remove dead code.
6688 (copy_text_properties): Delete obsolete commentary about an
6689 interface that was deleted long ago. Fix typos in the description
6690 of arguments.
6691
1b2de274
EZ
6692 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6693 to changes in oldXMenu/XMenu.h from 2011-04-16.
6694 <menu_help_message, prev_menu_help_message>: Constify.
6695 (IT_menu_make_room): menu->help_text is now `const char **';
6696 adjust.
6697
6698 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6699 to changes in oldXMenu/XMenu.h from 2011-04-16.
6700 (struct XMenu): Declare `help_text' `const char **'.
6701
6702 * xfaces.c <Qunspecified>: Make extern again.
6703
6704 * syntax.c: Include sys/types.h before including regex.h, as
6705 required by Posix.
6706
762b15be
EZ
6707 * doc.c (get_doc_string): Improve the format passed to `error'.
6708
6709 * doprnt.c (doprnt): Improve commentary.
6710
6711 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6712
6713 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6714 them with etags.
6715
f1052e5d
EZ
6716 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6717 changes in globals.h immediately force recompilation.
762b15be
EZ
6718 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6719 $(CURDIR)/s/ms-w32.h.
6720 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 6721
fa6996bc
EZ
6722 * character.c (Fchar_direction): Function deleted.
6723 (syms_of_character): Don't defsubr it.
6724 <char-direction-table>: Deleted.
6725
e6c3da20
EZ
67262011-04-23 Eli Zaretskii <eliz@gnu.org>
6727
6728 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6729 * doprnt.c: Include limits.h.
6730 (SIZE_MAX): New macro.
04f2d78b
CB
6731 (doprnt): Return a size_t value. 2nd arg is now size_t.
6732 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
6733 Improve overflow protection. Support `l' modifier for integer
6734 conversions. Support %l conversion. Don't assume an EMACS_INT
6735 argument for integer conversions and for %c.
6736
6737 * lisp.h (doprnt): Restore prototype.
6738
6739 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6740 $(SRC)/character.h.
6741
6742 * Makefile.in (base_obj): Add back doprnt.o.
6743
6744 * deps.mk (doprnt.o): Add back prerequisites.
6745 (callint.o): Depend on character.h.
6746
6747 * eval.c (internal_lisp_condition_case): Include the handler
6748 representation in the error message.
6749 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6750 when breaking from the loop.
6751
6752 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6753
6754 * callint.c (Fcall_interactively): When displaying error message
6755 about invalid control letter, pass the character's codepoint, not
6756 a pointer to its multibyte form. Improve display of the character
6757 in octal and display also its hex code.
6758
6759 * character.c (char_string): Use %x to display the (unsigned)
6760 codepoint of an invalid character, to avoid displaying a bogus
6761 negative value.
6762
6763 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6764 `error', not SYMBOL_NAME itself.
6765
6766 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6767 character arguments to `error'.
6768
6769 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6770 to `error' in error message about FINAL_CHAR argument. Make sure
6771 FINAL_CHAR is a character, and use %c when it is passed as
6772 argument to `error'.
6773
4ffd0d6b 67742011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
6775
6776 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6777
6778 * w32.c: Include <time.h>.
6779 (sys_localtime): New function.
6780
4ffd0d6b 67812011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
6782
6783 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6784
4ffd0d6b 6785 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 6786
4ffd0d6b 67872011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 6788
4ffd0d6b
GM
6789 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6790 zombies (Bug#8467).
aac0c6e3 6791
04c56954
EZ
67922011-04-19 Eli Zaretskii <eliz@gnu.org>
6793
6794 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6795 gl_state.e_property when gl_state.object is Qt.
6796
6797 * insdel.c (make_gap_larger): Remove limitation of buffer size
6798 to <= INT_MAX.
6799
16a43933
CY
68002011-04-18 Chong Yidong <cyd@stupidchicken.com>
6801
6802 * xdisp.c (lookup_glyphless_char_display)
6803 (produce_glyphless_glyph): Handle cons cell entry in
6804 glyphless-char-display.
6805 (Vglyphless_char_display): Document it.
6806
6807 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6808 glyphless-char-display.
6809
4581706e
CY
68102011-04-17 Chong Yidong <cyd@stupidchicken.com>
6811
6812 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6813
6814 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6815
6816 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6817 definition for no-X builds.
6818
4887c6e2 68192011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 6820
fd35b6f9
PE
6821 Static checks with GCC 4.6.0 and non-default toolkits.
6822
5c1ccb01
PE
6823 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6824
006c5daa
PE
6825 * process.c (keyboard_bit_set): Define only if SIGIO.
6826 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6827 (send_process): Repair possible setjmp clobbering.
6828
efc736d3
PE
6829 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6830
4e2fe2e6
PE
6831 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6832
f97334a2
PE
6833 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6834
4e75f29d
PE
6835 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6836 Define only if needed.
6837
90efadd1
PE
6838 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6839 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 6840 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 6841
3c647824
PE
6842 * dispextern.h (struct redisplay_interface): Rename param
6843 to avoid shadowing.
e264f262 6844 * termhooks.h (struct terminal): Likewise.
761383f4 6845 * xterm.c (xembed_send_message): Likewise.
3c647824 6846
b58c5c4a
PE
6847 * insdel.c (make_gap_smaller): Define only if
6848 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6849
cad59032
PE
6850 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6851 it.
6852
c339dc2e
PE
6853 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6854 so that we aren't warned about unused symbols.
6855
91a3e27b
PE
6856 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6857
399c71d3 6858 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 6859
8ffc96f5
PE
6860 * xfns.c (x_real_positions): Mark locals as initialized.
6861
eef9bc79
PE
6862 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6863
098db9dd
PE
6864 * xterm.c: Fix problems found by static analysis with other toolkits.
6865 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
6866 (x_dispatch_event): Declare static if USE_GTK, and
6867 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 6868 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 6869 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
6870 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6871 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 6872
eb18f6cc
PE
6873 * xmenu.c (menu_help_callback): Pointer type fixes.
6874 Use const pointers when pointing at readonly data. Avoid pointer
6875 signedness clashes.
6876 (FALSE): Remove unused macro.
6877 (update_frame_menubar): Remove unused decl.
6878
1fe72bf8
PE
6879 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6880
60d9e1db
PE
6881 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6882 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6883 (single_menu_item): Rename local to avoid shadowing.
6884
39261c26
PE
6885 * keyboard.c (make_lispy_event): Remove unused local var.
6886
018c5e19
PE
6887 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6888 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6889
63d2b86e
PE
6890 * bitmaps: Change bitmaps from unsigned char back to the X11
6891 compatible char. Avoid the old compiler warnings about
6892 out-of-range initializers by using, for example, '\xab' rather
6893 than 0xab.
6894
aefd87e1
PE
6895 * xgselect.c (xgselect_initialize): Check vs interface
6896 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6897
bf501fb9
PE
6898 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6899
e9829fdf
PE
6900 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6901 to read-only memory.
6902
1086c095
PE
6903 * fns.c (vector): Remove; this old hack is no longer needed.
6904
2baccd04 6905 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 6906 Remove unused var.
dde42981 6907 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 6908
72391843 6909 * xrdb.c (x_load_resources): Omit unused local.
3565b346 6910
436c16df 6911 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 6912 (x_window): Rename locals to avoid shadowing.
dc5ddd85 6913 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 6914
92bb796d 6915 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 6916 (x_term_init): Remove local to avoid shadowing.
92bb796d 6917
764430a3 6918 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
6919
6920 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6921 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6922
d1dfb56c
EZ
69232011-04-16 Eli Zaretskii <eliz@gnu.org>
6924
c4354cb4
EZ
6925 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6926
d1dfb56c
EZ
6927 Fix regex.c, syntax.c and friends for buffers > 2GB.
6928 * syntax.h (struct gl_state_s): Declare character position members
6929 EMACS_INT.
6930
6931 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6932
04f2d78b
CB
6933 * textprop.c (verify_interval_modification, interval_of):
6934 Declare arguments EMACS_INT.
d1dfb56c
EZ
6935
6936 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6937 EMACS_INT.
6938
6939 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6940
6941 * indent.c (Fvertical_motion): Local variable it_start is now
6942 EMACS_INT.
6943
6944 * regex.c (re_match, re_match_2, re_match_2_internal)
6945 (bcmp_translate, regcomp, regexec, print_double_string)
6946 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6947 (re_compile_pattern, re_exec): Declare arguments and local
6948 variables `size_t' and `ssize_t' and return values `regoff_t', as
6949 appropriate.
6950 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6951 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6952 <compile_stack_type>: `size' and `avail' are now `size_t'.
6953
6954 * regex.h <regoff_t>: Use ssize_t, not int.
6955 (re_search, re_search_2, re_match, re_match_2): Arguments that
6956 specify buffer/string position and length are now ssize_t and
6957 size_t. Return type is regoff_t.
6958
613052cd
BK
69592011-04-16 Ben Key <bkey76@gmail.com>
6960
6961 * nsfont.m: Fixed bugs in ns_get_family and
6962 ns_descriptor_to_entity that were caused by using free to
6963 deallocate memory blocks that were allocated by xmalloc (via
6964 xstrdup). This caused Emacs to crash when compiled with
6965 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6966 --enable-checking=xmallocoverrun). xfree is now used to
6967 deallocate these memory blocks.
6968
4170f62f 69692011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 6970
71b41406
PE
6971 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6972
9587a89d
PE
6973 emacs_write: Accept and return EMACS_INT for sizes.
6974 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6975 et seq.
6976 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6977 Accept and return EMACS_INT.
6978 (emacs_gnutls_write): Return the number of bytes written on
6979 partial writes.
6980 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
6981 (emacs_read, emacs_write): Remove check for negative size, as the
6982 Emacs source code has been audited now.
9587a89d
PE
6983 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6984 (emacs_read, emacs_write): Use it.
273a5f82
PE
6985 * process.c (send_process): Adjust to the new signatures of
6986 emacs_write and emacs_gnutls_write. Do not attempt to store
6987 a byte offset into an 'int'; it might overflow.
9587a89d 6988 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 6989
3e047f51
PE
6990 * sound.c: Don't assume sizes fit in 'int'.
6991 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 6992 Return EMACS_INT, not int.
3e047f51 6993 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
6994 Accept EMACS_INT, not int.
6995 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
6996 record read return values.
6997
cc39a9db
BK
69982011-04-15 Ben Key <bkey76@gmail.com>
6999
c9d0ec6d
JB
7000 * keyboard.c (Qundefined): Don't declare static since it is used
7001 in nsfns.m.
7002 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7003 static since they are used in nsfont.m.
cc39a9db 7004
6c60eb9f
SM
70052011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7006
7007 * process.c (Qprocessp): Don't declare static.
7008 * lisp.h (Qprocessp): Declare again.
7009
7990b61a
JB
70102011-04-15 Juanma Barranquero <lekktu@gmail.com>
7011
7012 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7013
5d4cb038
PE
70142011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7015
8bd7b830 7016 Improve C-level modularity by making more things 'static'.
cd64ea1d 7017
e3b27b31
PE
7018 Don't publish debugger-only interfaces to other modules.
7019 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7020 (verify_bytepos, count_markers): Move decls to the only modules
7021 that need them.
7022 * region-cache.h (pp_cache): Likewise.
7023 * window.h (check_all_windows): Likewise.
7024 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7025
5d4cb038
PE
7026 * sysdep.c (croak): Now static, if
7027 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7028 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
7029
7030 * alloc.c (refill_memory_reserve): Now static if
7031 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7032 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 7033
e87b6180
PE
7034 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7035 Define only if USE_LUCID.
7036
ac64929e
PE
7037 * xrdb.c (x_customization_string, x_rm_string): Now static.
7038
6f37259d
PE
7039 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7040 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7041
1683e3ab
PE
7042 * xdisp.c (draw_row_with_mouse_face): Now static.
7043 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7044
de9c2632
PE
7045 * window.h (check_all_windows): Mark externally visible.
7046
2b96acb7
PE
7047 * window.c (window_deletion_count): Now static.
7048
7049 * undo.c: Make symbols static if they're not exported.
7050 (last_undo_buffer, last_boundary_position, pending_boundary):
7051 Now static.
7052
50436f33
PE
7053 * textprop.c (interval_insert_behind_hooks): Now static.
7054 (interval_insert_in_front_hooks): Likewise.
7055
64520e5c
PE
7056 * term.c: Make symbols static if they're not exported.
7057 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7058 (max_frame_lines, tty_set_terminal_modes):
7059 (tty_reset_terminal_modes, tty_turn_off_highlight):
7060 (get_tty_terminal): Now static.
7061 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7062 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 7063 HAVE_WINDOW_SYSTEM.
64520e5c
PE
7064 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7065 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7066
1fa53021
PE
7067 * sysdep.c: Make symbols static if they're not exported.
7068 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7069 Now static.
7070 (sigprocmask_set, full_mask): Remove; unused.
7071 (wait_debugging): Mark as visible.
7072 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7073 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7074
d4b43b22
PE
7075 * syntax.c (syntax_temp): Define only if !__GNUC__.
7076
b7c513d0
PE
7077 * sound.c (current_sound_device, current_sound): Now static.
7078
989b29ad
PE
7079 * search.c (searchbufs, searchbuf_head): Now static.
7080
13a55a78
PE
7081 * scroll.c (scroll_cost): Remove; unused.
7082 * dispextern.h (scroll_cost): Remove decl.
7083
de68a1fc
PE
7084 * region-cache.h (pp_cache): Mark as externally visible.
7085
40ccffa6
PE
7086 * process.c: Make symbols static if they're not exported.
7087 (process_tick, update_tick, create_process, chan_process):
7088 (Vprocess_alist, proc_buffered_char, datagram_access):
7089 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7090 (deactivate_process): Mark defn as static, as well as decl.
7091 * lisp.h (create_process): Remove decl.
7092 * process.h (chan_process, Vprocess_alist): Remove decls.
7093
ad64fc97
PE
7094 * print.c: Make symbols static if they're not exported.
7095 (print_depth, new_backquote_output, being_printed, print_buffer):
7096 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7097 (print_interval, print_number_index, initial_stderr_stream):
7098 Now static.
7099 * lisp.h (Fprinc): Remove decl.
7100 (debug_output_compilation_hack): Mark as externally visible.
7101
adddb265
PE
7102 * sysdep.c (croak): Move decl from here to syssignal.h.
7103 * syssignal.h (croak): Put it here, so the API can be checked when
7104 'croak' is called from dissociate_if_controlling_tty.
7105
1717ede2
PE
7106 * minibuf.c: Make symbols static if they're not exported.
7107 (minibuf_save_list, choose_minibuf_frame): Now static.
7108 * lisp.h (choose_minibuf_frame): Remove decl.
7109
fa5fb2bc
PE
7110 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7111
1e3890d1
PE
7112 * lread.c: Make symbols static if they're not exported.
7113 (read_objects, initial_obarray, oblookup_last_bucket_number):
7114 Now static.
7115 (make_symbol): Remove; unused.
7116 * lisp.h (initial_obarray, make_symbol): Remove decls.
7117
8a1414fa
PE
7118 * keyboard.c: Make symbols static if they're not exported.
7119 (single_kboard, recent_keys_index, total_keys, recent_keys):
7120 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7121 (this_single_command_key_start, echoing, last_auto_save):
7122 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7123 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7124 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7125 (Vlispy_mouse_stem, double_click_count):
7126 Now static.
7127 (force_auto_save_soon): Define only if SIGDANGER.
7128 (ignore_mouse_drag_p): Now static if
7129 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7130 (print_help): Remove; unused.
7131 (stop_character, last_timer_event): Mark as externally visible.
7132 * keyboard.h (ignore_mouse_drag_p): Declare only if
7133 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7134 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7135 * lisp.h (echoing): Remove decl.
7136 (force_auto_save_soon): Declare only if SIGDANGER.
7137 * xdisp.c (redisplay_window): Simplify code, to make it more
7138 obvious that ignore_mouse_drag_p is not accessed if !defined
7139 USE_GTK && !defined HAVE_NS.
7140
93ea6e8f
PE
7141 * intervals.c: Make symbols static if they're not exported.
7142 (merge_properties_sticky, merge_interval_right, delete_interval):
7143 Now static.
7144 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7145
77382fcc
PE
7146 * insdel.c: Make symbols static if they're not exported.
7147 However, leave prepare_to_modify_buffer alone. It's never
7148 called from outside this function, but that appears to be a bug.
7149 (combine_after_change_list, combine_after_change_buffer):
4889fc82 7150 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
7151 (adjust_after_replace_noundo): Remove; unused.
7152 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 7153 (signal_before_change): Remove decls.
77382fcc 7154
9306c32e
PE
7155 * indent.c (val_compute_motion, val_vmotion): Now static.
7156
cd44d2eb
PE
7157 * image.c: Make symbols static if they're not exported.
7158 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7159 if USE_GTK.
7160 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7161 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7162
ad9a7a06
PE
7163 * fringe.c (standard_bitmaps): Now static.
7164 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7165
81626931
PE
7166 * frame.c: Make symbols static if they're not exported.
7167 (x_report_frame_params, make_terminal_frame): Now static.
7168 (get_frame_param): Now static, unless HAVE_NS.
7169 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7170 (x_get_resource_string): Remove; not used.
7171 * frame.h (make_terminal_frame, x_report_frame_params):
7172 (x_get_resource_string); Remove decls.
7173 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7174 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7175
239f9db9
PE
7176 * font.c, fontset.c: Make symbols static if they're not exported.
7177 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7178 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7179 * font.c (font_close_object): Now static.
7180 * font.h (font_close_object): Remove.
7181 * fontset.c (FONTSET_OBJLIST): Remove.
7182 (free_realized_fontset) #if-0 the body, which does nothing.
7183 (face_suitable_for_char_p): #if-0, as it's never called.
7184 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
7185 * xfaces.c (face_at_string_position):
7186 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
7187 since 0 is always ASCII.
7188
dfcf3579
PE
7189 * fns.c (weak_hash_tables): Now static.
7190
5045092b
PE
7191 * fileio.c: Make symbols static if they're not exported.
7192 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7193 (Vwrite_region_annotation_buffers): Now static.
7194
57a96f5c
PE
7195 * eval.c: Make symbols static if they're not exported.
7196 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7197 * lisp.h (backtrace_list): Remove decl.
7198
35f08c38
PE
7199 * emacs.c: Make symbols static if they're not exported.
7200 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7201 (fatal_error_code, fatal_error_signal_hook, standard_args):
7202 Now static.
7203 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7204 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7205 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7206 * lisp.h (fatal_error_signal_hook): Remove decl.
7207 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7208
f44bd759
PE
7209 * editfns.c: Move a (normally-unused) function to its only use.
7210 * editfns.c, lisp.h (get_operating_system_release): Remove.
7211 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7212 worth the hassle of breaking this out.
7213
b532497d
PE
7214 * xterm.c: Make symbols static if they're not exported.
7215 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7216 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7217 (x_destroy_window, x_delete_display):
7218 Now static.
7219 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7220 (x_mouse_leave): Remove; unused.
7221 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7222 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7223 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7224 Remove decls.
7225 (x_mouse_leave): Declare only if WINDOWSNT.
7226 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7227 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7228 USE_X_TOOLKIT.
7229
1675728f
PE
7230 * ftxfont.c: Make symbols static if they're not exported.
7231 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7232 HAVE_FREETYPE.
7233 * font.h (ftxfont_driver): Likewise.
7234
e4cebfca
PE
7235 * xfns.c: Make symbols static if they're not exported.
7236 (x_last_font_name, x_display_info_for_name):
7237 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7238 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7239 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7240 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7241 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7242 (last_show_tip_args): Now static.
7243 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7244 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7245 (x_screen_planes): Remove; unused.
7246 * dispextern.h (x_screen_planes): Remove decl.
7247
5bf46f05
PE
7248 * dispnew.c: Make symbols static if they're not exported.
7249 * dispextern.h (redraw_garbaged_frames, scrolling):
7250 (increment_row_positions): Remove.
7251 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7252 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7253 Now static.
7254 (redraw_garbaged_frames): Remove; unused.
7255
435f4c28
PE
7256 * xfaces.c: Make symbols static if they're not exported.
7257 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7258 Remove decls.
7259 * xterm.h (defined_color): Remove decls.
7260 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7261 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7262 (menu_face_changed_default, defined_color, free_realized_face):
7263 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7264 (ascii_face_of_lisp_face): Remove; unused.
7265
8524aef3
PE
7266 * xdisp.c: Make symbols static if they're not exported.
7267 * dispextern.h (scratch_glyph_row, window_box_edges):
7268 (glyph_to_pixel_coords, set_cursor_from_row):
7269 (get_next_display_element, set_iterator_to_next):
7270 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7271 (show_mouse_face): Remove decls
7272 * frame.h (message_buf_print): Likewise.
7273 * lisp.h (pop_message, set_message, check_point_in_composition):
7274 Likewise.
7275 * xterm.h (set_vertical_scroll_bar): Likewise.
7276 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7277 (message_buf_print, scratch_glyph_row, displayed_buffer):
7278 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7279 (get_next_display_element, show_mouse_face, window_box_edges):
7280 (frame_to_window_pixel_xy, check_point_in_composition):
7281 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7282 (glyph_to_pixel_coords): Remove; unused.
7283
16390cd2
PE
7284 * dired.c (file_name_completion): Now static.
7285
7286 * dbusbind.c (xd_in_read_queued_messages): Now static.
7287
a25f4dfa
PE
7288 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7289 * data.c (circular_list_error): Remove.
7290
14a9c8df
PE
7291 * commands.h (last_point_position, last_point_position_buffer):
7292 (last_point_position_window): Remove decls.
7293 * keyboard.c: Make these variables static.
7294
04f2d78b
CB
7295 * coding.h (coding, code_convert_region, encode_coding_gap):
7296 Remove decls.
74ab6df5
PE
7297 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7298 (iso_code_class, detect_coding, code_convert_region): Now static.
7299 (encode_coding_gap): Remove; unused.
7300
38dfbee1
PE
7301 * chartab.c (chartab_chars, chartab_bits): Now static.
7302
a2cb4e63
PE
7303 * charset.h (charset_iso_8859_1): Remove decl.
7304 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7305 Now static.
7306
127198fd
PE
7307 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7308 * ccl.c (Vccl_program_table): Now static.
7309 (check_ccl_update): Remove; unused.
7310
d85b608f
PE
7311 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7312 * category.h: ... from here.
7313 * category.c (check_category_table, set_category_set): Now static.
7314
31cd66f3
PE
7315 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7316 * lisp.h: Remove these decls.
7317
c358e587
PE
7318 * buffer.c (buffer_count): Remove unused var.
7319
e78aecca
PE
7320 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7321 so that it's not optimized away.
7322 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7323 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7324 exported only to the debugger.
7325
e192d7d3 7326 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 7327 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 7328
92470028
PE
7329 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7330 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7331 was inaccessible from Lisp.
7332 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7333 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7334
244ed907
PE
7335 alloc.c: Import and export fewer symbols, and remove unused items.
7336 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7337 is defined.
7338 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7339 it's not optimized away by whole-program optimization.
7340 (message_enable_multibyte, free_misc): Remove.
7341 (catchlist, handlerlist, mark_backtrace):
7342 Declare only if BYTE_MARK_STACK.
7343 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7344 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7345 (message_enable_multibyte): Remove decl.
7346 (free_misc, interval_free_list, float_block, float_block_index):
7347 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7348 (cons_free_list, last_marked_index):
7349 Now static.
7350 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7351 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7352 (mark_backtrace): Define only if BYTE_MARK_STACK.
7353 * xdisp.c (message_enable_multibyte): Now static.
7354
61c2b50e 7355 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
7356 This makes it easier for human readers (and static analyzers)
7357 to see whether these variables are used from other modules.
7358 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7359 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7360 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7361 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7362 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7363 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7364 * xmenu.c, xselect.c:
7365 Declare Q* vars static if they are not used in other modules.
7366 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7367 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7368 Remove decls of unexported vars.
7369 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7370
95c82688
PE
7371 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7372
16a97296
PE
7373 Make Emacs functions such as Fatom 'static' by default.
7374 This makes it easier for human readers (and static analyzers)
7375 to see whether these functions can be called from other modules.
7376 DEFUN now defines a static function. To make the function external
7377 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
7378 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7379 (Finit_image_library):
16a97296
PE
7380 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7381 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7382 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7383 Remove decls, since these functions are now static.
7384 (Funintern, Fget_internal_run_time): New decls, since these functions
7385 were already external.
95c82688 7386
16a97296
PE
7387 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7388 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7389 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7390 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7391 * keyboard.c, keymap.c, lread.c:
7392 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7393 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7394 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7395 Mark functions with DEFUE instead of DEFUN,
7396 if they are used in other modules.
7397 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7398 decls for now-static functions.
7399 * buffer.h (Fdelete_overlay): Remove decl.
7400 * callproc.c (Fgetenv_internal): Mark as internal.
7401 * composite.c (Fremove_list_of_text_properties): Remove decl.
7402 (Fcomposition_get_gstring): New forward static decl.
7403 * composite.h (Fcomposite_get_gstring): Remove decl.
7404 * dired.c (Ffile_attributes): New forward static decl.
7405 * doc.c (Fdocumntation_property): New forward static decl.
7406 * eval.c (Ffetch_bytecode): New forward static decl.
7407 (Funintern): Remove extern decl; now in .h file where it belongs.
7408 * fileio.c (Fmake_symbolic_link): New forward static decl.
7409 * image.c (Finit_image_library): New forward static decl.
7410 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7411 * intervals.h (Fprevious_property_change):
7412 (Fremove_list_of_text_properties): Remove decls.
7413 * keyboard.c (Fthis_command_keys): Remove decl.
7414 (Fcommand_execute): New forward static decl.
7415 * keymap.c (Flookup_key): New forward static decl.
7416 (Fcopy_keymap): Now static.
7417 * keymap.h (Flookup_key): Remove decl.
7418 * process.c (Fget_process): New forward static decl.
7419 (Fprocess_datagram_address): Mark as internal.
7420 * syntax.c (Fsyntax_table_p): New forward static decl.
7421 (skip_chars): Remove duplicate decl.
7422 * textprop.c (Fprevious_property_change): New forward static decl.
7423 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7424 Now internal.
7425 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7426 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7427
785bbd42
PE
7428 * editfns.c (Fformat): Remove unreachable code.
7429
8b913b57
AS
74302011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7431
7432 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7433 change. (Bug#8496)
7434
a6744a35
EZ
74352011-04-13 Eli Zaretskii <eliz@gnu.org>
7436
7437 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7438 when at ZV. (Bug#8487)
7439
e7974947
AS
74402011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7441
baad03f0
AS
7442 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7443 (Bug#8437)
7444 * keyboard.c (parse_tool_bar_item): Likewise.
7445 * sound.c (sound_cleanup, alsa_close): Likewise.
7446 * termcap.c (tgetent): Likewise.
7447 * xfns.c (x_default_font_parameter): Likewise.
7448 * xsettings.c (read_and_apply_settings): Likewise.
7449
e7974947
AS
7450 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7451 (overrun_check_free): Protoize.
7452
28272684
PE
74532011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7454
7455 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7456 since callers should never pass a negative size.
7457 Change the signature to match that of plain 'read' and 'write'; see
7458 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7459 * lisp.h: Update prototypes of emacs_write and emacs_read.
7460
11997c76
EZ
74612011-04-11 Eli Zaretskii <eliz@gnu.org>
7462
7463 * xdisp.c (redisplay_window): Don't try to determine the character
7464 position of the scroll margin if the window start point w->startp
e896f03c 7465 is outside the buffer's accessible region. (Bug#8468)
11997c76 7466
8a2cbd72
EZ
74672011-04-10 Eli Zaretskii <eliz@gnu.org>
7468
7469 Fix write-region and its subroutines for buffers > 2GB.
7470 * fileio.c (a_write, e_write): Modify declaration of arguments and
7471 local variables to support buffers larger than 2GB.
7472 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7473
7474 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7475 argument, local variables, and return value.
7476
7477 * lisp.h: Update prototypes of emacs_write and emacs_read.
7478
7479 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7480
4073e537 74812011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 7482
1ebfdcb6
PE
7483 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7484
b2ded58d
PE
7485 Fix more problems found by GCC 4.6.0's static checks.
7486
7d66342c
PE
7487 * xdisp.c (vmessage): Use a better test for character truncation.
7488
bbf47d44
PE
7489 * charset.c (load_charset_map): <, not <=, for optimization,
7490 and to avoid potential problems with integer overflow.
9248994d 7491 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 7492 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 7493 * editfns.c (Fformat): Likewise.
1e69125e 7494 * syntax.c (skip_chars): Likewise.
3befa583 7495
e3019616
PE
7496 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7497 This also lets GCC 4.6.0 generate slightly better loop code.
7498
becfa255
PE
7499 * callint.c (Fcall_interactively): <, not <=, for optimization.
7500 (Fcall_interactively): Count the number of arguments produced,
7501 not the number of arguments given. This is simpler and lets GCC
7502 4.6.0 generate slightly better code.
7503
dae0cd48
PE
7504 * ftfont.c: Distingish more carefully between FcChar8 and char.
7505 The previous code passed unsigned char * to a functions like
7506 strlen and xstrcasecmp that expect char *, which does not
7507 conform to the C standard.
7508 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7509 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7510 char * when the C standard requires it.
7511
76032d70
PE
7512 * keyboard.c (read_char): Remove unused var.
7513
eb3f1cc8
PE
7514 * eval.c: Port to Windows vsnprintf (Bug#8435).
7515 Include <limits.h>.
7516 (SIZE_MAX): Define if the headers do not.
7517 (verror): Do not give up if vsnprintf returns a negative count.
7518 Instead, grow the buffer. This ports to Windows vsnprintf, which
7519 does not conform to C99. Problem reported by Eli Zaretskii.
7520 Also, simplify the allocation scheme, by avoiding the need for
7521 calling realloc, and removing the ALLOCATED variable.
7522
70476b54
PE
7523 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7524
12020a9e
PE
7525 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7526 But keep the doprint source code for now, as we might revamp it
7527 and use it again (Bug#8435).
ea6c7ae6
PE
7528 * lisp.h (doprnt): Remove.
7529 * Makefile.in (base_obj): Remove doprnt.o.
7530 * deps.mk (doprnt.o): Remove.
7531
5fdb398c
PE
7532 error: Print 32- and 64-bit integers portably (Bug#8435).
7533 Without this change, on typical 64-bit hosts error ("...%d...", N)
7534 was used to print both 32- and 64-bit integers N, which relied on
7535 undefined behavior.
7536 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7537 New macro.
7538 * lisp.h (error, verror): Mark as printf-like functions.
7539 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7540 Report overflow in size calculations when allocating printf buffer.
7541 Do not truncate output string at its first null byte.
7542 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7543 Truncate the output at a character boundary, since vsnprintf does not
7544 do that.
7545 * charset.c (check_iso_charset_parameter): Convert internal
7546 character to string before calling 'error', since %c now has the
7547 printf meaning.
7548 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7549 overflow when computing char to be passed to 'error'. Do not
7550 pass Lisp_Object to 'error'; pass the integer instead.
7551 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7552 formatted with plain %d.
7553
b189fa66
PE
7554 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7555
bff87ef0
PE
7556 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7557
7e2cac20
PE
7558 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7559
ce4d90b5
PE
7560 * xterm.c (x_catch_errors): Remove duplicate declaration.
7561
266c9547
PE
7562 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7563
79c49ad2
PE
7564 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7565
368f4090
JM
75662011-04-10 Jim Meyering <meyering@redhat.com>
7567
7568 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7569 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7570 return ssize_t not "int", and use size_t as the buffer length.
7571 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7572 * gnutls.h: Update declarations.
7573 * process.c (read_process_output): Use ssize_t, to match.
7574 (send_process): Likewise.
7575
a32d4040
CY
75762011-04-09 Chong Yidong <cyd@stupidchicken.com>
7577
7578 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7579
8546720e 75802011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 7581
04f2d78b
CB
7582 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7583 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 7584
8546720e
GM
7585 * xterm.c (handle_one_xevent):
7586 * xmenu.c (create_and_show_popup_menu):
7587 * xselect.c (x_decline_selection_request)
7588 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 7589
0a2f5c1a 75902011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
7591
7592 Fix some uses of `int' instead of EMACS_INT.
7593 * search.c (string_match_1, fast_string_match)
7594 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7595 (scan_buffer, find_next_newline_no_quit)
7596 (find_before_next_newline, search_command, Freplace_match)
7597 (Fmatch_data): Make some `int' variables be EMACS_INT.
7598
7599 * xdisp.c (display_count_lines): 3rd argument and return value now
7600 EMACS_INT. All callers changed.
7601 (pint2hrstr): Last argument is now EMACS_INT.
7602
7603 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7604 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7605 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7606 (decode_coding_utf_16, decode_coding_emacs_mule)
7607 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7608 (decode_coding_ccl, decode_coding_charset)
7609 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7610 (decode_coding_iso_2022, decode_coding_emacs_mule)
7611 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7612 <char_offset, last_offset>: Declare EMACS_INT.
7613 (encode_coding_utf_8, encode_coding_utf_16)
7614 (encode_coding_emacs_mule, encode_invocation_designation)
7615 (encode_designation_at_bol, encode_coding_iso_2022)
7616 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7617 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7618 Declare EMACS_INT.
7619 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7620 (encode_invocation_designation): Last argument P_NCHARS is now
7621 EMACS_INT.
7622 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7623 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7624
7625 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7626 All users changed.
7627
7628 * ccl.c (Fccl_execute_on_string): Declare some variables
7629 EMACS_INT.
7630
8546720e 76312011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
7632
7633 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7634
4e19a977
CS
76352011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7636
7637 * process.c (Fformat_network_address): Doc fix.
7638
87302331
R
76392011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7640
ee7683eb 7641 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 7642
cbb59342
CY
76432011-04-08 Chong Yidong <cyd@stupidchicken.com>
7644
7645 * keyboard.c (read_char): Call Lisp function help-form-show,
7646 instead of using internal_with_output_to_temp_buffer.
7647 (Qhelp_form_show): New var.
e0d38eeb 7648 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
7649
7650 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7651
7652 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7653
e67a13ab
CY
76542011-04-06 Chong Yidong <cyd@stupidchicken.com>
7655
04f2d78b
CB
7656 * process.c (Flist_processes): Remove to Lisp.
7657 (list_processes_1): Delete.
e67a13ab 7658
973f782d
EZ
76592011-04-06 Eli Zaretskii <eliz@gnu.org>
7660
7c106b1e
EZ
7661 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7662
973f782d
EZ
7663 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7664
41cf7d1a 76652011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 7666
ca23cc88
PE
7667 Fix more problems found by GCC 4.6.0's static checks.
7668
f390e2d5
PE
7669 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7670
42eea0d0
PE
7671 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7672
b69769da 7673 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 7674
f9541e84
PE
7675 * xdisp.c (vmessage): Mark as a printf-like function.
7676
13841b55
PE
7677 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7678
c136c10f
PE
7679 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7680
5e2d4a30
PE
7681 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7682 printf-like functions.
7683 (tiff_load): Add casts to remove these marks before passing them
7684 to system-supplied API.
7685
583f48b9
PE
7686 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7687
b25d760e
PE
7688 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7689 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
7690 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7691 directly, rather than having caller test rule sign. This avoids
7692 some unnecessary tests.
7693 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7694 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7695 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 7696
bc7b6697 7697 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 7698 (xfont_open): Avoid unnecessary tests.
bc7b6697 7699
27ccc379
PE
7700 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7701
dcd5c89a
PE
7702 * composite.h, composite.c (composition_gstring_put_cache):
7703 Use EMACS_INT, not int, for length.
7704
b13a45c6
PE
7705 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7706 breaking out part of COMPOSITION_DECODE_RULE.
7707 (COMPOSITION_DECODE_RULE): Use it.
7708 * composite.c (get_composition_id): Remove unused local vars,
7709 by using the new macro.
7710
1e792e4d
PE
7711 * textprop.c (set_text_properties_1): Change while to do-while,
7712 since the condition is always true at first.
7713
dc6c6455 7714 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
7715 (interval_deletion_adjustment): Return unsigned value.
7716 All uses changed.
dc6c6455 7717
aba7731a
PE
7718 * process.c (list_processes_1, create_pty, read_process_output):
7719 (exec_sentinel): Remove vars that were set but not used.
afd4052b 7720 (create_pty): Remove unnecessary "volatile"s.
bc57d757 7721 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 7722 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 7723 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 7724
fdfc4bf3
PE
7725 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7726
fca8fe46 7727 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 7728 (update_syntax_table): Use unsigned instead of int.
fca8fe46 7729
06a0259a 7730 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 7731 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 7732 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 7733
e7b9e80f
PE
7734 * print.c (print_error_message): Avoid int overflow.
7735
56201685
PE
7736 * font.c (font_list_entities): Redo for clarity,
7737 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7738
78834453 7739 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 7740 (font_score): Avoid potential overflow in diff calculation.
78834453 7741
0bc0b309 7742 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 7743 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 7744
e610eaca
PE
7745 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7746
b895abce
PE
7747 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7748 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7749 can always succeed if overflow has undefined behavior.
7750
1f1d9321 7751 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 7752 (wordify): Omit three unnecessary tests.
1f1d9321 7753
c59478bc
PE
7754 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7755 All callers changed. This avoids the need for an unused var.
7756
79b73827
PE
7757 * casefiddle.c (casify_region): Remove var that is set but not used.
7758
a4db5dfe
PE
7759 * dired.c (file_name_completion): Remove var that is set but not used.
7760
43aae36e
PE
7761 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7762
2a47c44d 7763 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 7764 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 7765
a37c69bf
PE
7766 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7767 Check for integer overflow on size calculations.
7768
328ab8e7
PE
7769 * buffer.c (Fprevious_overlay_change): Remove var that is set
7770 but not used.
7771
e5a2a5cb
PE
7772 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7773 Remove vars that are set but not used.
8d84a6eb 7774 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 7775 (timer_check_2): Mark vars as initialized.
e5a2a5cb 7776
a60e5f68
PE
7777 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7778
f661cb61 7779 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 7780 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 7781
f0397f5a
PE
7782 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7783 that are set but not used.
7784
8664db06 7785 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 7786 if XCreateBitmapFromData fails (Bug#8410).
8664db06 7787
6abdaa4a
PE
7788 * xselect.c (x_get_local_selection, x_handle_property_notify):
7789 Remove vars that are set but not used.
7790
0ce7538d 7791 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 7792 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 7793
9ae848fc
PE
7794 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7795 Remove var that is set but not used.
0b918413
PE
7796 (scroll_bar_windows_size): Now size_t, not int.
7797 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7798 Check for overflow.
9ae848fc 7799
a5a62657
PE
7800 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7801 (map_tty_color) [!defined MSDOS]: Likewise.
7802
5c5cdd39
PE
7803 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7804
66ebf983
PE
7805 * coding.c: Remove vars that are set but not used.
7806 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7807 All callers changed.
7808 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7809 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7810 (decode_coding_charset): Remove vars that are set but not used.
7811
1be4d761
PE
7812 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7813 that is set but not used.
7814
47553fa8
PE
7815 * print.c (print_object): Remove var that is set but not used.
7816
1f7196bf 7817 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
7818 The gnulib version avoids calling malloc in the usual case,
7819 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7820 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7821 * filelock.c (current_lock_owner): Likewise.
7822 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7823 * sysdep.c: Include allocator.h, careadlinkat.h.
7824 (emacs_no_realloc_allocator): New static constant.
7825 (emacs_readlink): New function.
fdb61804
PE
7826 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7827 ../lib/careadlinkat.h.
d1fdcab7 7828
f84c17c7
SM
78292011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7830
7831 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7832 first non-nil return value).
7833
ef3862ad
JD
78342011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7835
7836 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7837 if not defined (Bug#8403).
7838
376a7006
JB
78392011-04-02 Juanma Barranquero <lekktu@gmail.com>
7840
7841 * xdisp.c (display_count_lines): Remove parameter `start',
7842 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7843 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7844 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7845 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7846 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7847 and thereabouts. All callers changed.
7848 (get_per_char_metric): Remove parameter `f', unused since
7849 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7850
6ca3801d
JM
78512011-04-02 Jim Meyering <meyering@redhat.com>
7852
7853 do not dereference NULL upon failed strdup
7854 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7855 (ns_get_family): Likewise.
7856
d8e2b5ba
JB
78572011-04-02 Juanma Barranquero <lekktu@gmail.com>
7858
7859 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7860
8c74fcbd
JD
78612011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7862
7863 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7864 later (Bug#8403).
7865
7200d79c
SM
78662011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7867
03408648 7868 Add lexical binding.
7200d79c 7869
03408648
SM
7870 * window.c (Ftemp_output_buffer_show): New fun.
7871 (Fsave_window_excursion):
7872 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7873
7874 * lread.c (lisp_file_lexically_bound_p): New function.
7875 (Fload): Bind Qlexical_binding.
7876 (readevalloop): Remove `evalfun' arg.
7877 Bind Qinternal_interpreter_environment.
7878 (Feval_buffer): Bind Qlexical_binding.
7879 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7880 Mark as dynamic.
7881 (syms_of_lread): Declare `lexical-binding'.
7882
7883 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7884
7885 * keyboard.c (eval_dyn): New fun.
7886 (menu_item_eval_property): Use it.
ca105506
SM
7887
7888 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 7889
03408648
SM
7890 * fns.c (concat, mapcar1): Accept byte-code-functions.
7891
7892 * eval.c (Fsetq): Handle lexical vars.
7893 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7894 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7895 (FletX, Flet): Obey lexical binding.
7896 (Fcommandp): Handle closures.
7897 (Feval): New `lexical' arg.
7898 (eval_sub): New function extracted from Feval. Use it almost
7899 everywhere where Feval was used. Look up vars in lexical env.
7900 Handle closures.
7901 (Ffunctionp): Move from subr.el.
7902 (Ffuncall): Handle closures.
7903 (apply_lambda): Remove `eval_flags'.
7904 (funcall_lambda): Handle closures and new byte-code-functions.
7905 (Fspecial_variable_p): New function.
7906 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7907 but without exporting it to Lisp.
23aba0ea 7908
23aba0ea 7909 * doc.c (Fdocumentation, store_function_docstring):
03408648 7910 * data.c (Finteractive_form): Handle closures.
23aba0ea 7911
03408648
SM
7912 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7913 interactive spec.
ba83908c 7914
04f2d78b
CB
7915 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7916 New byte-codes.
03408648
SM
7917 (exec_byte_code): New function extracted from Fbyte_code to handle new
7918 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 7919
03408648 7920 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 7921
03408648 7922 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 7923
e2abce01
JB
79242011-03-31 Juanma Barranquero <lekktu@gmail.com>
7925
7926 * xdisp.c (redisplay_internal): Fix prototype.
7927
63696a73 79282011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 7929
63696a73 7930 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
7931 (try_scrolling): Use it when setting scroll_limit.
7932 Limit scrolling to 100 screen lines.
63696a73
EZ
7933 (redisplay_window): Even when falling back on "recentering",
7934 position point in the window according to scroll-conservatively,
7935 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7936
7937 (try_scrolling): When point is above the window, allow searching
7938 as far as scroll_max, or one screenful, to compute vertical
7939 distance from PT to the scroll margin position. This prevents
7940 try_scrolling from unnecessarily failing when
7941 scroll-conservatively is set to a value slightly larger than the
7942 window height. Clean up the case of PT below the margin at bottom
7943 of window: scroll_max can no longer be INT_MAX. When aggressive
7944 scrolling is in use, don't let point enter the opposite scroll
7945 margin as result of the scroll.
7946 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
7947 threshold of 100 lines for never-recentering scrolling.
7948
e4cc2dfc
JB
79492011-03-31 Juanma Barranquero <lekktu@gmail.com>
7950
7951 * dispextern.h (move_it_by_lines):
7952 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7953 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7954 (message_log_check_duplicate): Remove parameters `prev_bol' and
7955 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7956 (redisplay_internal): Remove parameter `preserve_echo_area',
7957 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7958
7959 * indent.c (Fvertical_motion):
7960 * window.c (window_scroll_pixel_based, Frecenter):
7961 Don't pass `need_y_p' to `move_it_by_lines'.
7962
1c470562
SM
79632011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7964
44f230aa
SM
7965 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7966 steal a few bits to be more compact.
7967 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7968 Remove unneeded casts.
7969
1c470562
SM
7970 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7971
888adce9
ZK
79722011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7973
7974 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7975 binding" message (bug#7967).
7976
f838ed7b
PE
79772011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7978
77861b95
PE
7979 Fix more problems found by GCC 4.6.0's static checks.
7980
de6dbc14
PE
7981 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7982 Remove unused local var.
7983
f838ed7b
PE
7984 * editfns.c (Fmessage_box): Remove unused local var.
7985
792c7b2b
PE
7986 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7987 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7988 Omit unused local vars.
c499e557 7989 * window.c (shrink_windows): Omit unused local var.
b01a1c29 7990 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
7991 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7992 Omit unused local var.
7993
ba0165e1
PE
7994 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7995 Don't assume string length fits in int.
32ad8845 7996 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 7997 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 7998
3c59b4c9
PE
7999 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8000 instead of alloca (Bug#8344).
8001
a3eed478 8002 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 8003 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 8004
eb4d412d
PE
8005 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8006
1658b401
PE
8007 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8008 concerns.
8009
8010 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8011
8012 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 8013
9a2c6e05
PE
8014 * keyboard.c (syms_of_keyboard): Use the same style as later
8015 in this function when indexing through an array. This also
8016 works around GCC bug 48267.
8017
03d0a109
PE
8018 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8019
44f730c8
PE
8020 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8021
fe75f926
PE
8022 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8023 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8024
ffa8c828
PE
8025 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8026 This avoids undefined behavior on integer overflow, and is a bit
8027 more convenient anyway since it is compared to a size_t variable.
8028
c5101a77
PE
8029 Variadic C functions now count arguments with size_t, not int.
8030 This avoids an unnecessary limitation on 64-bit machines, which
8031 caused (substring ...) to crash on large vectors (Bug#8344).
8032 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8033 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 8034 All variadic functions and their callers changed accordingly.
c5101a77
PE
8035 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8036 * data.c (arith_driver, float_arith_driver): Likewise.
8037 * editfns.c (general_insert_function): Likewise.
8038 * eval.c (struct backtrace.nargs, interactive_p)
8039 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8040 (funcall_lambda, mark_backtrace): Likewise.
8041 * fns.c (concat): Likewise.
8042 * frame.c (x_set_frame_parameters): Likewise.
8043 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8044 0 if not found, not -1. All callers changed.
8045
dd3f25f7
PE
8046 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8047 (stack_copy_size): Now size_t, not int.
8048 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8049
461c2ab9
JB
80502011-03-28 Juanma Barranquero <lekktu@gmail.com>
8051
8052 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8053 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8054 All callers changed.
8055
8056 * lisp.h (multibyte_char_to_unibyte):
8057 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8058 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8059 * character.h (CHAR_TO_BYTE8):
8060 * cmds.c (internal_self_insert):
8061 * editfns.c (general_insert_function):
8062 * keymap.c (push_key_description):
8063 * search.c (Freplace_match):
8064 * xdisp.c (message_dolog, set_message_1): All callers changed.
8065
f6d62986
SM
80662011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8067
8068 * keyboard.c (safe_run_hook_funcall): New function.
8069 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8070 don't set the hook to nil, but remove the offending function instead.
8071 (Qcommand_hook_internal): Remove, unused.
8072 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8073 Vcommand_hook_internal.
8074
8075 * eval.c (enum run_hooks_condition): Remove.
8076 (funcall_nil, funcall_not): New functions.
8077 (run_hook_with_args): Call each function through a `funcall' argument.
8078 Remove `cond' argument, now redundant.
8079 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8080 (Frun_hook_with_args_until_failure): Adjust accordingly.
8081 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8082
1db5b1ad
JB
80832011-03-28 Juanma Barranquero <lekktu@gmail.com>
8084
8085 * dispextern.h (string_buffer_position): Remove declaration.
8086
8087 * print.c (strout): Remove parameter `multibyte', unused since
8088 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8089
8090 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8091 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8092 All callers changed.
8093
8094 * w32.c (_wsa_errlist): Use braces for struct initializers.
8095
8096 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8097 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8098 All callers changed.
8099 (string_buffer_position): Likewise. Also, make static (it's never
8100 used outside xdisp.c).
8101 (cursor_row_p): Remove parameter `w', unused since
8102 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8103 (decode_mode_spec): Remove parameter `precision', introduced during
8104 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8105 All callers changed.
8106
5ffb62aa
JD
81072011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8108
8109 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8110
461c2ab9 81112011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
8112
8113 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8114 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8115 (ns_update_auto_hide_menu_bar): New functions.
8116 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8117 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8118 ns_constrain_all_frames.
8119 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8120 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8121
5c380ffb
JD
81222011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8123
8124 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8125
9af30bdf
GM
81262011-03-27 Glenn Morris <rgm@gnu.org>
8127
8128 * syssignal.h: Replace RETSIGTYPE with void.
8129 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8130 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8131 Replace SIGTYPE with void everywhere.
8132 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8133 * s/template.h (SIGTYPE): Remove commented out definition.
8134
e2abce01
JB
81352011-03-26 Eli Zaretskii <eliz@gnu.org>
8136
8137 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8138 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8139
f868cd8a
JB
81402011-03-26 Juanma Barranquero <lekktu@gmail.com>
8141
59eb0929
JB
8142 * w32.c (read_unc_volume): Use parameter `henum', instead of
8143 global variable `wget_enum_handle'.
8144
8145 * keymap.c (describe_vector): Remove parameters `indices' and
8146 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8147 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8148
f868cd8a
JB
8149 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8150
8151 * keyboard.c (timer_check): Remove parameter `do_it_now',
8152 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8153 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8154 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8155
8156 * keyboard.c (read_char):
8157 * w32menu.c (w32_menu_display_help):
8158 * xmenu.c (show_help_event, menu_help_callback):
8159 Adjust calls to `show_help_echo'.
8160
8161 * gtkutil.c (xg_maybe_add_timer):
8162 * keyboard.c (readable_events):
8163 * process.c (wait_reading_process_output):
8164 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8165
8166 * insdel.c (adjust_markers_gap_motion):
8167 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8168 (gap_left, gap_right): Don't call it.
8169
2ecf6fdb
CY
81702011-03-25 Chong Yidong <cyd@stupidchicken.com>
8171
8172 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8173 incurred during fontification.
8174
6b1f9ba4
JB
81752011-03-25 Juanma Barranquero <lekktu@gmail.com>
8176
8177 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8178 (DEFVAR_PER_BUFFER): Don't pass it.
8179
8180 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8181 (scrolling_window): Don't pass it.
8182
0f4a96b5
JB
81832011-03-25 Juanma Barranquero <lekktu@gmail.com>
8184
8185 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8186
8187 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8188 and `suffix'.
8189 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8190 of variables specific to SELinux and computation of `encoded_absname'.
8191
8192 * image.c (XPutPixel): Remove unused variable `height'.
8193
8194 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8195
8196 * unexw32.c (get_section_info): Remove unused variable `section'.
8197
8198 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8199 (system_process_attributes): Remove unused variable `sess'.
8200 (sys_read): Remove unused variable `err'.
8201
8202 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8203 (w32_wnd_proc): Remove unused variable `isdead'.
8204 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8205 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8206 (x_create_tip_frame): Remove unused variable `tem'.
8207
8208 * w32inevt.c (w32_console_read_socket):
8209 Remove unused variable `no_events'.
8210
8211 * w32term.c (x_draw_composite_glyph_string_foreground):
8212 Remove unused variable `width'.
8213
1149507c
JB
82142011-03-24 Juanma Barranquero <lekktu@gmail.com>
8215
8216 * w32term.c (x_set_glyph_string_clipping):
8217 Don't pass uninitialized region to CombineRgn.
8218
9c88f339
JB
82192011-03-23 Juanma Barranquero <lekktu@gmail.com>
8220
8221 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8222 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8223 (Fx_close_connection): Remove unused variable `i'.
8224
8225 * w32font.c (w32font_draw): Return number of glyphs.
8226 (w32font_open_internal): Remove unused variable `i'.
8227 (w32font_driver): Add missing initializer.
8228
8229 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8230 (fill_in_menu): Remove unused variable `items_added'.
8231
8232 * w32term.c (last_mouse_press_frame): Remove static global variable.
8233 (w32_clip_to_row): Remove unused variable `f'.
8234 (x_delete_terminal): Remove unused variable `i'.
8235
8236 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8237 (NOTHING): Remove unused static global variable.
8238 (uniscribe_check_otf): Remove unused variable `table'.
8239 (uniscribe_font_driver): Add missing initializers.
8240
dee091a3
JD
82412011-03-23 Julien Danjou <julien@danjou.info>
8242
8243 * term.c (Fsuspend_tty, Fresume_tty):
8244 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8245 * window.c (temp_output_buffer_show):
8246 * insdel.c (signal_before_change):
8247 * frame.c (Fhandle_switch_frame):
8248 * fileio.c (Fdo_auto_save):
8249 * emacs.c (Fkill_emacs):
8250 * editfns.c (save_excursion_restore):
8251 * cmds.c (internal_self_insert):
8252 * callint.c (Fcall_interactively):
8253 * buffer.c (Fkill_all_local_variables):
8254 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8255 Use Frun_hooks.
0f4a96b5 8256 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 8257 unconditionally since it does the check itself.
dee091a3 8258
2c520ab5 82592011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 8260
c9c49752
PE
8261 Fix more problems found by GCC 4.5.2's static checks.
8262
8abc3f12
PE
8263 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8264 the first time through the loop, since we know p0 < p1 then.
8265 This also avoids a gcc -Wstrict-overflow warning.
8266
a2d26660
PE
8267 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8268 leading to a memory leak, possible in functions like
8269 load_charset_map_from_file that can allocate an unbounded number
b12ef411 8270 of objects (Bug#8318).
a2d26660 8271
916c72e9
PE
8272 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8273 that could (at least in theory) be that large.
8274
19ab8a18
PE
8275 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8276 This is less likely to overflow, and avoids undefined behavior if
8277 overflow does occur. All callers changed. Use strtoul to scan
8278 for the unsigned long integer.
b7cbbd6f
PE
8279 (pint2hrstr): Simplify and tune code slightly.
8280 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 8281
f0641eff
PE
8282 * scroll.c (do_scrolling): Work around GCC bug 48228.
8283 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8284
7f650bb9
PE
8285 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8286 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
8287 (validate_x_resource_name): Simplify count usage.
8288 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 8289
37dd57d1
PE
8290 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8291 fail (Bug#8306).
81e56e61 8292
699979fc 8293 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 8294
401bf9b4
PE
8295 * process.c (Fmake_network_process): Use socklen_t, not int,
8296 where POSIX says socklen_t is required in portable programs.
8297 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 8298 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
8299 (Fmake_network_process, server_accept_connection):
8300 (wait_reading_process_output, read_process_output):
8301 Likewise.
8302
b93aacde
PE
8303 * process.c: Rename or move locals to avoid shadowing.
8304 (list_processes_1, Fmake_network_process):
8305 (read_process_output_error_handler, exec_sentinel_error_handler):
8306 Rename or move locals.
4dc343ee 8307 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 8308 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 8309 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 8310 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 8311 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 8312
af8a867c 8313 Make tparam.h and terminfo.c consistent.
44f230aa
SM
8314 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8315 Include tparam.h instead, since it declares them.
af8a867c
PE
8316 * cm.h (PC): Remove extern decl; tparam.h now does this.
8317 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8318 * terminfo.c: Include tparam.h, to check interfaces.
8319 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8320 (tparam): Adjust signature to match interface in tparam.h;
8321 this removes some undefined behavior. Check that outstring and len
8322 are zero, which they always are with Emacs.
8323 * tparam.h (PC, BC, UP): New extern decls.
8324
0248044d 8325 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 8326 (xftfont_open): Rename locals to avoid shadowing.
0248044d 8327
8ff096c1 8328 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
8329 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8330 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 8331 (ftfont_list): Remove unused local.
49eaafba
PE
8332 (get_adstyle_property, ftfont_pattern_entity):
8333 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8334 Rename locals to avoid shadowing.
8ff096c1 8335
e2be39f6
PE
8336 * xfont.c (xfont_list_family): Mark var as initialized.
8337
c9735e30
PE
8338 * xml.c (make_dom): Now static.
8339
8f5201ae
PE
8340 * composite.c (composition_compute_stop_pos): Rename local to
8341 avoid shadowing.
b246f932
PE
8342 (composition_reseat_it): Remove unused locals.
8343 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 8344 (composition_update_it): Mark var as initialized.
11b61122
PE
8345 (find_automatic_composition): Mark vars as initialized,
8346 with a FIXME (Bug#8290).
8f5201ae 8347
760fbc2c
PE
8348 character.h: Rename locals to avoid shadowing.
8349 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8350 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8351 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8352 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8353 to avoid shadowing.
8354
ff08eb85
PE
8355 * textprop.c (property_change_between_p): Remove; unused.
8356
fc7bf025
PE
8357 * intervals.c (interval_start_pos): Now static.
8358
235d7abc
PE
8359 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8360
44f230aa
SM
8361 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8362 Rename locals to avoid shadowing.
3e7d6594 8363
50060332
PE
8364 * sound.c (wav_play, au_play, Fplay_sound_internal):
8365 Fix pointer signedness.
d01f234b 8366 (alsa_choose_format): Remove unused local var.
c83b8872
PE
8367 (wav_play): Initialize a variable to 0, to prevent undefined
8368 behavior (Bug#8278).
50060332 8369
c4fc4e30
PE
8370 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8371
918436ed
PE
8372 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8373
c939f91b
PE
8374 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8375 clobbering (Bug#8298).
b9c7f648
PE
8376 * sysdep.c (sys_subshell): Likewise.
8377 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 8378
6bd8c144
PE
8379 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8380 This should get cleaned up, so that child_setup has the
8381 same signature on all platforms.
8382
7710357c 8383 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 8384 (relocate_fd): Rename locals to avoid shadowing.
7710357c 8385
c59da222
CY
83862011-03-22 Chong Yidong <cyd@stupidchicken.com>
8387
8388 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8389 not to be necessary, and produces flickering.
8390
66b87493
GM
83912011-03-20 Glenn Morris <rgm@gnu.org>
8392
8393 * config.in: Remove file.
8394
45b6f6d5
JB
83952011-03-20 Juanma Barranquero <lekktu@gmail.com>
8396
8397 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8398 are now in src/globals.h.
8399 (syms_of_minibuf): Remove spurious & from previous change.
8400
cd394be1 84012011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
8402
8403 * minibuf.c (completing-read-function): New variable.
8404 (completing-read-default): Rename from completing-read.
8405 (completing-read): Call completing-read-function.
8406
b14e3e21
CY
84072011-03-19 Juanma Barranquero <lekktu@gmail.com>
8408
8409 * xfaces.c (Fx_load_color_file):
8410 Read color file from absolute filename (bug#8250).
8411
f2b726e6
JB
84122011-03-19 Juanma Barranquero <lekktu@gmail.com>
8413
8414 * makefile.w32-in: Update dependencies.
8415
09f6ff02
EZ
84162011-03-17 Eli Zaretskii <eliz@gnu.org>
8417
8418 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8419
29a6015a
PE
84202011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8421
a3a6c54e
PE
8422 Fix more problems found by GCC 4.5.2's static checks.
8423
b766f867
PE
8424 * process.c (make_serial_process_unwind, send_process_trap):
8425 (sigchld_handler): Now static.
8426
be02381c
PE
8427 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8428 That way, the code declares only the vars that it needs.
8429 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8430 * s/cygwin.h (PTY_ITERATION): Likewise.
8431 * s/darwin.h (PTY_ITERATION): Likewise.
8432 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8433
57048744
PE
8434 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8435 * process.c (allocate_pty): Don't declare stb unless it's needed.
8436
7914961c 8437 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
8438 (CONSTANTLIM): Remove; unused.
8439 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8440 Define only if needed.
7914961c 8441
b3967b18
PE
8442 * unexelf.c (unexec): Name an expression,
8443 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
8444 Use a different way to cause a compilation error if anyone uses
8445 n rather than nn, a way that does not involve shadowing.
73366a00 8446 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 8447
29a6015a
PE
8448 * deps.mk (unexalpha.o): Remove; unused.
8449
43cfc33e 8450 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 8451 * unexec.h: New file.
ce701a33
PE
8452 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8453 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8454 Depend on unexec.h.
8455 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8456 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8457 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 8458 Change as necessary to match prototype in unexec.h.
ce701a33 8459
01f44d5a
PE
8460 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8461 shadowing.
4f63c6bb 8462 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 8463
a6670b0b
PE
8464 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8465 Rename locals to avoid shadowing.
8466
cef2010d 8467 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 8468 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 8469
d4d7173a
PE
8470 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8471
f08b802a
PE
8472 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8473 warning when compiling print.c.
8474
3ddb0639
PE
8475 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8476 instead of using an uninitialized var.
5ad03b97 8477 (font_sort_entities): Mark var as initialized.
3ddb0639 8478
170a2692
PE
8479 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8480
e663c700
PE
8481 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8482 pointers to constants.
89bc529a 8483 (font_parse_fcname): Remove unused vars.
7b81e2d0 8484 (font_delete_unmatched): Now static.
ea838e10 8485 (font_get_spec): Remove; unused.
13a547c6
PE
8486 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8487 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8488 Rename or move locals to avoid shadowing.
e663c700 8489
2a80c887 8490 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 8491 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 8492
1384fa33 8493 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 8494 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 8495
8b2c52e9
PE
8496 * alloc.c (mark_backtrace): Move decl from here ...
8497 * lisp.h: ... to here, so that it can be checked.
8498
475545b5 8499 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 8500 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
8501 (lisp_indirect_variable): Name an expression,
8502 to avoid gcc -Wbad-function-cast warning.
1faed8ae 8503 (Fdefvar): Rename locals to avoid shadowing.
475545b5 8504
b1349114 8505 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 8506 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 8507 Use const pointer when appropriate.
b1349114 8508
a2928364
PE
8509 * lisp.h (get_system_name, get_operating_system_release):
8510 Move decls here, to check interfaces.
8511 * process.c (get_operating_system_release): Move decl to lisp.h.
8512 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
8513 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8514 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8515 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
8516 (Fformat_time_string, Fencode_time, Finsert_char):
8517 (Ftranslate_region_internal, Fformat):
8518 Rename or remove local vars to avoid shadowing.
9710023e 8519 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 8520
a415e694
PE
8521 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8522 avoid shadowing.
8523
8ef4622d
PE
8524 * lisp.h (eassert): Check that the argument compiles, even if
8525 ENABLE_CHECKING is not defined.
8526
946f9a5b
PE
8527 * data.c (Findirect_variable): Name an expression, to avoid
8528 gcc -Wbad-function-cast warning.
112396d6 8529 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 8530 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
8531 (Fmake_variable_buffer_local, Fmake_local_variable):
8532 Mark variables as initialized.
52746918 8533 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 8534
e5aab7e7 8535 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
8536 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8537 Rename locals to avoid shadowing.
dff45157
PE
8538 (mark_stack): Move local variables into the #ifdef region where
8539 they're used.
7bc26fdb
PE
8540 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8541 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8542 needed otherwise.
8543 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8544 (GC_STRING_CHARS): Remove; not used.
d40d4be1 8545 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 8546
e5aab7e7
PE
8547 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8548 avoids undefined behavior in theory.
8549
4da60324
PE
8550 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8551
88043301
PE
8552 Use functions, not macros, for up- and down-casing (Bug#8254).
8553 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8554 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8555 to use the following functions instead of these macros.
8556 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8557 EMACS_INT, since callers assume the returned value fits in int.
8558 (upcase1): Likewise, for UPCASE_TABLE.
8559 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 8560 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 8561 the race-condition problem in the old DOWNCASE.
88043301 8562
19ed5445
PE
8563 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8564 Rename locals to avoid shadowing.
8565 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
8566 (regex_compile, re_search_2, re_match_2_internal):
8567 Remove unused local vars.
952db0d7
PE
8568 (FREE_VAR): Rewrite so as not to use empty "else",
8569 which gcc can warn about.
da053e48 8570 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
8571 (RETALLOC_IF): Define only if needed.
8572 (WORDCHAR_P): Likewise. This one is never needed, but is used
8573 only in a comment talking about a compiler bug, so put inside
8574 the #if 0 of that comment.
8575 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8576 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8577 Remove; unused.
19ed5445 8578
1f3561e4 8579 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
8580 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8581 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 8582
ded6f8f7
PE
8583 * search.c (simple_search): Remove unused var.
8584
dbd37a95
PE
8585 * dired.c (compile_pattern): Move decl from here ...
8586 * lisp.h: ... to here, so that it can be checked.
8587 (struct re_registers): New forward decl.
8588
7e47afad
PE
8589 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8590
85f24f61
PE
8591 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8592 All uses changed.
8593 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8594 Rename locals to avoid shadowing.
5671df8f 8595 (Fvertical_motion): Mark locals as initialized.
85f24f61 8596
181aa2be 8597 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 8598 (casify_region): Mark local as initialized.
181aa2be 8599
930d429c
PE
8600 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8601
7082eac6
PE
8602 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8603 New macros, so that the caller can use some names other than
8604 gcpro1, gcpro2, etc.
8605 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8606 of the new macros.
8607 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8608 argument, for consistency with GCPRO2_VAR, etc: it is now the
8609 prefix of the variable, not the variable itself. All uses
8610 changed.
38b2c076
PE
8611 * dired.c (directory_files_internal, file_name_completion):
8612 Rename locals to avoid shadowing.
8613
15206ed9
PE
8614 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8615 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8616 dired.c's scmp function, had undefined behavior.
8617 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8618 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8619 * buffer.h: ... to here, because these macros use current_buffer,
8620 and the new implementation with inline functions needs to have
8621 current_buffer in scope now, rather than later when the macros
8622 are used.
8623 (downcase, upcase1): New static inline functions.
8624 (DOWNCASE, UPCASE1): Reimplement using these functions.
8625 This avoids undefined behavior in expressions like
8626 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8627 from race conditions in accessing the global variables
8628 case_temp1 and case_temp2.
8629 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8630 * lisp.h (case_temp1, case_temp2): Remove their decls.
8631 * character.h (ASCII_CHAR_P): Move from here ...
8632 * lisp.h: ... to here, so that the inline functions mentioned
8633 above can use them.
8634
4a6bea26
PE
8635 * dired.c (directory_files_internal_unwind): Now static.
8636
f14b7e14
PE
8637 * fileio.c (file_name_as_directory, directory_file_name):
8638 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8639 Now static.
2893f146
PE
8640 (file_name_as_directory): Use const pointers when appropriate.
8641 (Fexpand_file_name): Likewise. In particular, newdir might
8642 point at constant storage, so make it a const pointer.
fd4ead52 8643 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
8644 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8645 signedness issues.
f839df0c
PE
8646 (Fset_file_times, Finsert_file_contents, auto_save_error):
8647 Rename locals to avoid shadowing.
f14b7e14 8648
5716756e 8649 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
8650 (Ftry_completion, Fall_completions): Rename or remove locals
8651 to avoid shadowing.
5716756e 8652
b4c3046a
PE
8653 * marker.c (bytepos_to_charpos): Remove; unused.
8654
b45db522
PE
8655 * lisp.h (verify_bytepos, count_markers): New decls,
8656 so that gcc does not warn that these functions aren't declared.
8657
85876d07
PE
8658 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8659 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 8660 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 8661 (copy_text): Remove unused local var.
85876d07 8662
03d78a21 8663 * filelock.c (within_one_second): Now static.
b3dd38ab 8664 (lock_file_1): Rename local to avoid shadowing.
03d78a21 8665
5df8f01b
PE
8666 * buffer.c (fix_overlays_before): Mark locals as initialized.
8667 (fix_start_end_in_overlays): Likewise. This function should be
8668 simplified by using pointers-to-pointers, but that's a different
8669 matter.
b1d876f1 8670 (switch_to_buffer_1): Now static.
8f54f30a
PE
8671 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8672 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 8673
a70072c9 8674 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 8675 Fix pointer signedness issue.
edced198
PE
8676 (sys_subshell): Mark local as volatile if checking for lint,
8677 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 8678 (MAXPATHLEN): Define only if needed.
a70072c9 8679
a0977c44
PE
8680 * process.c (serial_open, serial_configure): Move decls from here ...
8681 * systty.h: ... to here, so that they can be checked.
8682
a884fdcc
PE
8683 * fns.c (get_random, seed_random): Move extern decls from here ...
8684 * lisp.h: ... to here, so that they can be checked.
8685
604efe86 8686 * sysdep.c (reset_io): Now static.
b8950c94 8687 (wait_for_termination_signal): Remove; unused.
604efe86 8688
38fc62d9
PE
8689 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8690 (copy_keymap_item, append_key, push_text_char_description):
8691 Now static.
1004a21a 8692 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 8693 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
8694 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8695 (describe_map_tree):
8696 Rename locals to avoid shadowing.
38fc62d9 8697
2f2650da
PE
8698 * keyboard.c: Declare functions static if they are not used elsewhere.
8699 (echo_char, echo_dash, cmd_error, top_level_2):
8700 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
8701 (read_char, kbd_buffer_get_event, make_lispy_position):
8702 (make_lispy_event, make_lispy_movement, apply_modifiers):
8703 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8704 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8705 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 8706 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 8707 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 8708
a053e86c 8709 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
8710 (mark_kboards): Move decl here ...
8711 * alloc.c (mark_kboards): ... from here.
a053e86c 8712
4752793e
PE
8713 * lisp.h (force_auto_save_soon): New decl.
8714
74f10ca7 8715 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
8716 (DEFINE_DUMMY_FUNCTION): New macro.
8717 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8718 Use it.
c03cd23f
PE
8719 (main): Add casts to avoid warnings
8720 if GCC considers string literals to be constants.
74f10ca7 8721
022e70d4
PE
8722 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8723
59d6fe83
PE
8724 * dbusbind.c: Pointer signedness fixes.
8725 (xd_signature, xd_append_arg, xd_initialize):
8726 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8727 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8728 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8729 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8730
78320123
PE
8731 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8732 if GCC considers string literals to be constants.
49cebcca 8733 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 8734
35ac2a97
SM
87352011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8736
fb103ca9
SM
8737 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8738 (print_preprocess, print_object): New macro to fix last change.
8739
35ac2a97
SM
8740 * print.c (print_preprocess): Don't forget font objects.
8741
62973b41
JB
87422011-03-16 Juanma Barranquero <lekktu@gmail.com>
8743
8744 * emacs.c (USAGE3): Doc fixes.
8745
0e48bb22
AS
87462011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8747
8748 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8749 structure.
8750
7684e57b
JB
87512011-03-14 Juanma Barranquero <lekktu@gmail.com>
8752
8753 * lisp.h (VWindow_system, Qfile_name_history):
8754 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8755 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8756 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8757
8758 * w32select.c: Don't #include "keyboard.h".
c96bbc66 8759 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
8760
8761 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8762 * w32console.c (detect_input_pending, read_input_pending)
8763 (encode_terminal_code):
8764 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8765 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8766 (w32_system_caret_y, Qfile_name_history):
8767 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8768 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8769 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8770 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8771 * w32proc.c (Qlocal, report_file_error):
8772 * w32term.c (Vwindow_system, updating_frame):
8773 * w32uniscribe.c (initialized, uniscribe_font_driver):
8774 Remove unneeded extern declarations.
8775
2aa46d6c
CY
87762011-03-14 Chong Yidong <cyd@stupidchicken.com>
8777
c96bbc66 8778 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 8779
cffc6f3b
CY
87802011-03-13 Chong Yidong <cyd@stupidchicken.com>
8781
8782 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8783 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8784 These macros can no longer be used for assignment.
8785
44f230aa
SM
8786 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8787 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
8788 (record_buffer_markers, fetch_buffer_markers): New functions for
8789 recording and fetching special buffer markers.
8790 (set_buffer_internal_1, set_buffer_temp): Use them.
8791
8792 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8793
8794 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8795
8796 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8797 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8798
8799 * xdisp.c (hscroll_window_tree):
8800 (reconsider_clip_changes): Use PT instead of BUF_PT.
8801
d251f04b
EZ
88022011-03-13 Eli Zaretskii <eliz@gnu.org>
8803
8804 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8805 $(EMACS_ROOT)/lib/intprops.h.
8806
f0c77cd1
PE
88072011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8808
3eca4629
PE
8809 Fix more problems found by GCC 4.5.2's static checks.
8810
7c86ee98
PE
8811 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8812 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
8813 (xg_free_frame_widgets): Make it clear that a local variable is
8814 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
8815 (gdk_window_get_screen): Make it clear that this macro is needed
8816 only if USE_GTK_TOOLTIP.
1e5524e7
PE
8817 (int_gtk_range_get_value): New function, which avoids a diagnostic
8818 from gcc -Wbad-function-cast.
8819 (xg_set_toolkit_scroll_bar_thumb): Use it.
8820 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8821 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
8822 (get_utf8_string, xg_get_file_with_chooser):
8823 Rename locals to avoid shadowing.
8824 (create_dialog): Move locals to avoid shadowing.
7c86ee98 8825
41729b81
PE
8826 * xgselect.c (xg_select): Remove unused var.
8827
f0c77cd1
PE
8828 * image.c (four_corners_best): Mark locals as initialized.
8829 (gif_load): Initialize transparent_p to zero (Bug#8238).
8830 Mark another local as initialized.
ec6cf4c6 8831 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 8832
ce0ad53d 8833 * image.c (clear_image_cache): Now static.
d5d5a617 8834 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 8835 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
8836 (x_edge_detection): Remove unnecessary cast that
8837 gcc -Wbad-function-cast diagnoses.
2037898d 8838 (gif_load): Fix pointer signedness.
6ae141d6
PE
8839 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8840 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 8841
33383987 88422011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 8843
d32df629
PE
8844 Improve quality of tests for time stamp overflow.
8845 For example, without this patch (encode-time 0 0 0 1 1
8846 1152921504606846976) returns the obviously-bogus value (-948597
8847 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8848 reports time overflow. See
8849 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
8850 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8851 * editfns.c: Include limits.h and intprops.h.
8852 (TIME_T_MIN, TIME_T_MAX): New macros.
8853 (time_overflow): Move earlier, to before first use.
8854 (hi_time, lo_time): New functions, for an accurate test for
8855 out-of-range times.
8856 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8857 (Fget_internal_run_time): Don't assume time_t fits in int.
8858 (make_time): Use list2 instead of Fcons twice.
8859 (Fdecode_time): More accurate test for out-of-range times.
8860 (check_tm_member): New function.
8861 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
8862 (lisp_time_argument): Don't rely on undefined left-shift and
8863 right-shift behavior when checking for time stamp overflow.
8be6f318 8864
fe31d94c
PE
8865 * editfns.c (time_overflow): New function, refactoring common code.
8866 (Fformat_time_string, Fdecode_time, Fencode_time):
8867 (Fcurrent_time_string): Use it.
8868
8be6f318
PE
8869 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8870 * dired.c (make_time): Move to ...
8871 * editfns.c (make_time): ... here.
8872 * systime.h: Note the move.
8873
09d9db2c 88742011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 8875
126bc0dc
YM
8876 * fringe.c (update_window_fringes): Remove unused variables.
8877
c47cbdfd
YM
8878 * unexmacosx.c (copy_data_segment): Also copy __got section.
8879 (Bug#8223)
8880
7ac80be9
EZ
88812011-03-12 Eli Zaretskii <eliz@gnu.org>
8882
c96bbc66 8883 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
8884 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8885 Constify `char *' arguments and their references according to
8886 prototypes in tparam.h.
8887
ecb0f94d 8888 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 8889
7ac80be9
EZ
8890 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8891 Adapt all references accordingly.
8892
8893 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8894
ef1fd07e
TT
88952011-03-11 Tom Tromey <tromey@redhat.com>
8896
8897 * buffer.c (syms_of_buffer): Remove obsolete comment.
8898
7ef4b50c
EZ
88992011-03-11 Eli Zaretskii <eliz@gnu.org>
8900
8901 * termhooks.h (encode_terminal_code): Declare prototype.
8902
8903 * msdos.c (encode_terminal_code): Don't declare prototype.
8904
8905 * term.c (encode_terminal_code): Now external again, used by
8906 w32console.c and msdos.c.
8907
44f230aa
SM
8908 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8909 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 8910
4b1ec863 89112011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 8912
1714f52b 8913 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 8914
4b1ec863
PE
8915 * fringe.c (update_window_fringes): Mark locals as initialized
8916 (Bug#8227).
8917 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 8918
524c7aa6
PE
8919 * alloc.c (mark_fringe_data): Move decl from here ...
8920 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8921 to check its interface.
8922 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8923
a5c0af81 8924 * fontset.c (free_realized_fontset): Now static.
7519b8cd 8925 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 8926 (fontset_font): Mark local as initialized.
a9a06e0b 8927 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 8928
b4716021
PE
8929 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8930
811e9bac 8931 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 8932 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
8933 (x_own_selection, Fx_disown_selection_internal): Rename locals
8934 to avoid shadowing.
8935 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 8936
7e3ab302
PE
8937 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8938 so that the caller can use some name other than gcpro1.
8939 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
8940 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8941 (Fx_backspace_delete_keys_p):
8942 Use them to avoid shadowing, and rename vars to avoid shadowing.
8943 (x_decode_color, x_set_name, x_window): Now static.
6b437900 8944 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 8945 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
8946 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8947 Remove unused locals.
7e3ab302
PE
8948 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8949 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8950 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8951 macros.
f78faa98 8952
e2b13473
PE
8953 * xterm.h (x_mouse_leave): New decl.
8954
77f23912
PE
8955 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8956 Remove unused functions.
cdf4ba58
PE
8957 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8958 (x_calc_absolute_position): Now static.
7411c686 8959 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 8960 Don't declare local "event" unless it's used.
ed7bf3a5
PE
8961 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8962 unless they are used.
38d0b34a
PE
8963 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8964 (x_fatal_error_signal): Remove; not used.
a6067996
PE
8965 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8966 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8967 (x_error_catcher, x_connection_closed, x_error_handler):
8968 (x_error_quitter, xembed_send_message, x_iconify_frame):
8969 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 8970 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 8971 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 8972
44f230aa
SM
8973 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8974 Rename or move locals to avoid shadowing.
6b463e58 8975 (tty_defined_color, merge_face_heights): Now static.
5967d051 8976 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
8977 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8978 does not deduce is never used uninitialized.
73719eba
PE
8979 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8980 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 8981
426994c3 8982 * terminal.c (store_terminal_param): Now static.
5489860b 8983
032f1620 8984 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 8985 (set_frame_menubar): Remove unused local.
d4323972 8986 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
8987 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8988 since they might point to immutable storage.
281585b0
PE
8989 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8990 since it's unused otherwise.
032f1620 8991
367c19e5 8992 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 8993 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
8994 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8995 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 8996 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
8997 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8998 does not deduce are never used uninitialized.
70739cbe 8999
07b48fa9
PE
9000 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9001
8868a238 9002 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
9003 * window.c (window_loop, size_window):
9004 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 9005
7e5cf297 9006 * window.c (display_buffer): Now static.
d6550a9f
PE
9007 (size_window): Mark variables that gcc -Wuninitialized
9008 does not deduce are never used uninitialized.
a586633d
PE
9009 * window.h (check_all_windows): New decl, to forestall
9010 gcc -Wmissing-prototypes diagnostic.
5b555da1 9011 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 9012
f6095868
PE
9013 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9014 shadowing.
9015 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
9016 Include <limits.h>.
9017 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9018 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
9019 (load_charset_map): Mark variables that gcc -Wuninitialized
9020 does not deduce are never used uninitialized.
53df7c11 9021 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 9022
f38b440c
PE
9023 * coding.c (coding_set_source, coding_set_destination):
9024 Use "else { /* comment */ }" rather than "else /* comment */;"
9025 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
9026 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9027 a block, when the outer 'i' will do.
9028 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9029 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9030 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9031 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9032 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9033 Rename locals to avoid shadowing.
9034 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
9035 * coding.c (emacs_mule_char, encode_invocation_designation):
9036 Now static, since they're not used elsewhere.
413bb2db 9037 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 9038 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
9039 (decode_coding_emacs_mule): Mark variables that gcc
9040 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
9041 (detect_coding_iso_2022): Initialize a local variable that might
9042 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 9043 this initialization is needed. (Bug#8211)
5f58e762
PE
9044 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9045 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9046 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9047 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9048 Remove unused macros.
f38b440c 9049
232b38b9 9050 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 9051 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 9052 * character.c (string_count_byte8): Likewise.
232b38b9 9053
fb90da1b
PE
9054 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9055 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9056
fb93dbc2
PE
9057 * chartab.c (copy_sub_char_table): Now static, since it's not used
9058 elsewhere.
5c156ace
PE
9059 (sub_char_table_ref_and_range, char_table_ref_and_range):
9060 Rename locals to avoid shadowing.
bbcd0949 9061 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 9062
7d3b3862 9063 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 9064 (BIDI_BOB): Remove unused macro.
7d3b3862 9065
6be7d3da
PE
9066 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9067 deduce are never used uninitialized.
c2ed9c8b 9068 * term.c (encode_terminal_code): Likewise.
6be7d3da 9069
75f8807f 9070 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 9071
50938595
PE
9072 * tparam.h: New file.
9073 * term.c, tparam.h: Include it.
9074 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9075 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9076 Move these decls to tparam.h, and make them agree with what
9077 is actually in tparam.c. The previous trick of using incompatible
9078 decls in different modules does not conform to the C standard.
9079 All callers of tparam changed to use tparam's actual API.
9080 * tparam.c (tparam1, tparam, tgoto):
9081 Use const pointers where appropriate.
9082
fbceeba2
PE
9083 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9084 * cm.h (struct cm): Likewise.
9085 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9086 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9087 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9088 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9089 (turn_on_face, init_tty): Likewise.
9090 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 9091
7f3f1250
PE
9092 * term.c (term_mouse_position): Rename local to avoid shadowing.
9093
e6ca6543
PE
9094 * alloc.c (mark_ttys): Move decl from here ...
9095 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9096
c40f8d15
AS
90972011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9098
9099 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9100
cfe0661d
JB
91012011-03-09 Juanma Barranquero <lekktu@gmail.com>
9102
9103 * search.c (compile_pattern_1): Remove argument regp, unused since
9104 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9105 (compile_pattern): Don't pass it.
9106
0afb4571
J
91072011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9108
9109 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9110 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9111 for ! HAVE_GTK3.
9112 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9113
9114 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9115
9116 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9117 gdk_window_get_screen, gdk_window_get_geometry,
9118 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9119 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9120 (xg_get_pixbuf_from_pixmap): New function.
9121 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9122 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9123 Call xg_get_pixbuf_from_pixmap instead of
9124 gdk_pixbuf_get_from_drawable.
9125 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9126 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9127 (xg_check_special_colors): Use GtkStyleContext and its functions
9128 for HAVE_GTK3.
9129 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9130 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9131 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
9132 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9133 Call gtk_widget_get_preferred_size.
0afb4571
J
9134 (xg_frame_resized): gdk_window_get_geometry only takes 5
9135 parameters.
44f230aa
SM
9136 (xg_win_to_widget, xg_event_is_for_menubar):
9137 Call gdk_x11_window_lookup_for_display.
0afb4571
J
9138 (xg_set_widget_bg): New function.
9139 (delete_cb): New function.
895009e1 9140 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 9141 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
9142 (xg_set_background_color): Call xg_set_widget_bg.
9143 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9144 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9145 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9146 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9147 if ! HAVE_GTK3.
9148 (update_frame_tool_bar): Call gtk_widget_hide.
9149 (xg_initialize): Use GDK_KEY_g.
9150
9151 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9152 if ! HAVE_GTK3
9153 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9154
9155 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9156 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9157 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9158
1c2cc4ef
JB
91592011-03-08 Juanma Barranquero <lekktu@gmail.com>
9160
9161 * w32xfns.c (select_palette): Check success of RealizePalette against
9162 GDI_ERROR, not zero.
9163
33383987 9164See ChangeLog.11 for earlier changes.
aac0c6e3
MR
9165
9166;; Local Variables:
9167;; coding: utf-8
aac0c6e3
MR
9168;; End:
9169
acaf905b 9170 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
9171
9172 This file is part of GNU Emacs.
9173
9174 GNU Emacs is free software: you can redistribute it and/or modify
9175 it under the terms of the GNU General Public License as published by
9176 the Free Software Foundation, either version 3 of the License, or
9177 (at your option) any later version.
9178
9179 GNU Emacs is distributed in the hope that it will be useful,
9180 but WITHOUT ANY WARRANTY; without even the implied warranty of
9181 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9182 GNU General Public License for more details.
9183
9184 You should have received a copy of the GNU General Public License
9185 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.