* lisp/dired.el (dired-sort-toggle-or-edit): Revert last changes.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
1c4d7f3d
LMI
12011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2
3 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
4 value for non-existent files.
5
b885bf36
EZ
62011-09-11 Eli Zaretskii <eliz@gnu.org>
7
8 * fileio.c (Finsert_file_contents): If the file cannot be opened,
9 set its "size" to -1. This will set the modtime_size field of
10 the corresponding buffer to -1, which is what
11 verify-visited-file-modtime expects for files that do not exist.
12 (Bug#9139)
13
6612f0bf
PE
142011-09-11 Paul Eggert <eggert@cs.ucla.edu>
15
16 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
17 here ...
18 * lisp.h: ... from here. push_key_description is no longer
19 defined in keyboard.c, so its declaration should not be in
20 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
21 logically belongs with push_key_description.
22
dfb3f755
PE
232011-09-10 Paul Eggert <eggert@cs.ucla.edu>
24
25 * buffer.h: Include <sys/types.h> instead of <time.h>.
26 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
27 Problem reported by Herbert J. Skuhra.
28
3134906c
LMI
292011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
30
31 * xml.c (parse_region): Make the parsing work for
32 non-comment-starting XML files again (bug#9144).
33
8d903f4e
AS
342011-09-10 Andreas Schwab <schwab@linux-m68k.org>
35
36 * image.c (gif_load): Fix calculation of bottom and right corner.
37 (Bug#9468)
38
80ad64f4
EZ
392011-09-10 Eli Zaretskii <eliz@gnu.org>
40
41 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
42 redisplay in small windows.
43
208a048d
EZ
442011-09-09 Eli Zaretskii <eliz@gnu.org>
45
46 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
47
9b1c252e
MR
482011-09-08 Martin Rudalics <rudalics@gmx.at>
49
50 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
51 Operate on live windows only.
52
2949f33b
JB
532011-09-08 Juanma Barranquero <lekktu@gmail.com>
54
55 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
56
e08dcafd
EZ
572011-09-07 Eli Zaretskii <eliz@gnu.org>
58
59 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
60 only under bidi iteration.
61
115b96bd
JD
622011-09-07 Jan Djärv <jan.h.d@swipnet.se>
63
64 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
65
c8199d0f
PE
662011-09-06 Paul Eggert <eggert@cs.ucla.edu>
67
68 isnan: Fix porting problem to Solaris 10 with bundled gcc.
69 Without this fix, the command to link temacs failed due to an
70 undefined symbol __builtin_isnan. This is because
71 /usr/include/iso/math_c99.h #defines isnan(x) to
72 __builtin_isnan(x), but the bundled gcc, which identifies itself
73 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
74 a __builtin_isnan.
75 * floatfns.c (isnan): #undef, and then #define to a clone of
76 what's in data.c.
77 (Fisnan): Always define, since it's always available now.
78 (syms_of_floatfns): Always define isnan at the Lisp level.
79
e39b275c 802011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
81
82 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
83
b2db44d9 842011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 85
f4af5137 86 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
87 The previous code assumed that file offsets (off_t values) fit in
88 EMACS_INT variables, which is not true on typical 32-bit hosts.
89 The code messed up by falsely reporting buffer overflow in cases
90 such as (insert-file-contents "big" nil 1 2) into an empty buffer
91 when "big" contains more than 2**29 bytes, even though this
92 inserts just one byte and does not overflow the buffer.
93 (Finsert_file_contents): Store file offsets as off_t
94 values, not as EMACS_INT values. Check for overflow when
95 converting between EMACS_INT and off_t. When checking for
96 buffer overflow or for overlap, take the offsets into account.
97 Don't use EMACS_INT for small values where int suffices.
98 When checking for overlap, fix a typo: ZV was used where
99 ZV_BYTE was intended.
100 (Fwrite_region): Don't assume off_t fits into 'long'.
101 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
102
ecfc0a49
MA
1032011-09-05 Michael Albinus <michael.albinus@gmx.de>
104
105 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
106
6511acf2 1072011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 108
0999621a 109 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
110
111 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 112 (esprintf, exprintf, evxprintf): New functions.
62f19c19
PE
113 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
114 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
115 (modify_event_symbol): Do not assume that the length of
116 name_alist_or_stem is safe to alloca and fits in int.
117 (Fexecute_extended_command): Likewise for function name and binding.
118 (Frecursion_depth): Wrap around reliably on integer overflow.
119 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
120 since some callers pass EMACS_INT values.
121 (Fsingle_key_description): Don't crash if symbol name contains more
122 than MAX_ALLOCA bytes.
123 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
124 (get_minibuffer): Arg is now EMACS_INT, not int.
125 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 126 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
127 * window.h (command_loop_level, minibuf_level): Reflect API changes.
128
2be7d702
PE
129 * dbusbind.c (signature_cat): New function.
130 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
131 Do not overrun buffer; instead, report string overflow.
132
9d1df220
PE
133 * dispnew.c (add_window_display_history): Don't overrun buffer.
134 Truncate instead; this is OK since it's just a log.
135
33ef5c64
PE
136 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
137 even if the time zone offset is outlandishly large.
138 Don't mishandle offset == INT_MIN.
139
66c6fdd5
PE
140 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
141 when creating daemon; the previous buffer-overflow check was incorrect.
142
d749b01b
PE
143 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
144 which has the guts of the old verror function.
145
b5cd1905
PE
146 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
147 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
148
6e1a67fb
PE
149 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
150 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 151 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 152 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
153 length of string rather than counting it via multiple sprintfs;
154 that's simpler and more reliable.
c21721cc
PE
155 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
156 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
157 sprintf, in case result does not fit in int.
158
c57b67fc
PE
159 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
160 (fontset_from_font): Print it.
161
8a401434
PE
162 * frame.c (tty_frame_count): Now printmax_t, not int.
163 (make_terminal_frame, set_term_frame_name): Print it.
164 (x_report_frame_params): In X, window IDs are unsigned long,
165 not signed long, so print them as unsigned.
166 (validate_x_resource_name): Check for implausibly long names,
167 and don't assume name length fits in 'int'.
168 (x_get_resource_string): Don't blindly alloca invocation name;
169 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
170 not fit in int.
171
6e1a67fb
PE
172 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
173 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
174 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
175
0df02bf3
PE
176 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
177 Use esprintf, not sprintf, in case result does not fit in int.
178
48e30793
PE
179 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
180 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
181 it as a large positive number.
182 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
183 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
184
a66ff6d8
PE
185 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
186 in case result does not fit in int.
187
aca216ff
PE
188 * print.c (float_to_string): Detect width overflow more reliably.
189 (print_object): Make sprintf buffer a bit bigger, to avoid potential
190 buffer overrun. Don't assume list length fits in 'int'. Treat
191 print length of 0 as 0, not as infinity; to be consistent with other
192 uses of print length in this function. Don't overflow print length
193 index. Don't assume hash table size fits in 'long', or that
194 vectorlike size fits in 'unsigned long'.
195
31c286f7
PE
196 * process.c (make_process): Use printmax_t, not int, to format
197 process-name gensyms.
198
55e5faa1
PE
199 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
200
80f2e268
PE
201 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
202 to avoid potential buffer overrun.
203
670741ab
PE
204 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
205 if X resource line is longer than 512 bytes.
206
b7163a50
PE
207 * xfns.c (x_window): Make sprintf buffer a bit bigger
208 to avoid potential buffer overrun.
209
ae58ff1f
PE
210 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
211
c43c8a6a
PE
212 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
213
3f8236f4
PE
2142011-09-04 Paul Eggert <eggert@cs.ucla.edu>
215
53e9fe90 216 Integer overflow fixes for scrolling, etc.
6511acf2
PE
217 Without these, Emacs silently mishandles large integers sometimes.
218 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
219 it were "C-u 1 M-x recenter" on a typical 64-bit host.
220
6511acf2
PE
221 * xdisp.c (try_window_id): Check Emacs fixnum range before
222 converting to 'int'.
806add1d 223
6511acf2 224 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
225 Check that an Emacs fixnum is in range before assigning it to 'int'.
226 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
227 values converted from Emacs fixnums.
228 (Frecenter): Don't wrap around a line count if it is out of 'int'
229 range; instead, treat it as an extreme value.
230 (Fset_window_configuration, compare_window_configurations):
231 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
232
6511acf2
PE
233 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
234 that can exceed INT_MAX. Check that EMACS_INT value is in range
235 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
236 (match_limit): Don't assume that a fixnum can fit in 'int'.
237
6511acf2 238 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
239 exceed INT_MAX.
240
6511acf2 241 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
242 (Fvertical_motion): Don't wrap around LINES values that don't fit
243 in 'int'. Instead, treat them as extreme values. This is good
244 enough for windows, which can't have more than INT_MAX lines anyway.
245
fcb901a7
LMI
2462011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
247
0f2f6b6d
LMI
248 * Require libxml/parser.h to avoid compilation warning.
249
fcb901a7
LMI
250 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
251
252 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
253 since this reportedly can destroy thread storage.
254
6e20a0d4
CY
2552011-08-30 Chong Yidong <cyd@stupidchicken.com>
256
257 * syntax.c (find_defun_start): Update all cache variables if
258 exiting early (Bug#9401).
259
148ae00e
EZ
2602011-08-30 Eli Zaretskii <eliz@gnu.org>
261
f6cfbd8f
EZ
262 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
263
148ae00e
EZ
264 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
265 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
266 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
267
268 * term.c (tty_append_glyph): New function.
269 (produce_stretch_glyph): Static function and its prototype deleted.
270
271 * dispextern.h (produce_stretch_glyph, tty_append_glyph): Add
272 prototypes.
273
c4a07a4c
PE
2742011-08-29 Paul Eggert <eggert@cs.ucla.edu>
275
276 * image.c (parse_image_spec): Check for nonnegative, not for positive,
277 when checking :margin (Bug#9390).
278 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
279 Renamed from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
280 so that the name doesn't mislead. All uses changed.
281
6bc8cd65
JB
2822011-08-28 Johan Bockgård <bojohan@gnu.org>
283
284 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
285 set_tty_hooks.
286
dca4927e
EZ
2872011-08-27 Eli Zaretskii <eliz@gnu.org>
288
289 * xdisp.c (move_it_to): Don't bail out early when reaching
290 position beyond to_charpos, if we are scanning backwards.
291 (move_it_vertically_backward): When DY == 0, make sure we get to
292 the first character in the line after the newline.
293
f2cad773
PE
2942011-08-27 Paul Eggert <eggert@cs.ucla.edu>
295
296 * ccl.c: Improve and simplify overflow checking (Bug#9196).
297 (ccl_driver): Do not generate an out-of-range pointer.
298 (Fccl_execute_on_string): Remove unnecessary check for
299 integer overflow, noted by Stefan Monnier in
300 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
301 Remove a FIXME that didn't need fixing.
302 Simplify the newly-introduced buffer reallocation code.
303
0cae2cdb
JB
3042011-08-27 Juanma Barranquero <lekktu@gmail.com>
305
306 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
307
5fc295a4 3082011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 309
70c60eb2 310 Integer and memory overflow issues (Bug#9196).
726e0ab1 311
d31850da
PE
312 * doc.c (get_doc_string): Rework so that
313 get_doc_string_buffer_size is the actual buffer size, rather than
314 being 1 less than the actual buffer size; this makes xpalloc more
315 convenient.
316
a69fbedb
PE
317 * image.c (x_allocate_bitmap_record, cache_image):
318 * xselect.c (Fx_register_dnd_atom):
319 Simplify previous changes by using xpalloc.
320
fe5c5d37
PE
321 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
322 since either will do and ptrdiff_t is convenient with xpalloc.
323
0065d054
PE
324 * charset.c (charset_table_size)
325 (struct charset_sort_data.priority): Now ptrdiff_t.
326 (charset_compare): Don't overflow if priorities differ greatly.
327 (Fsort_charsets): Don't assume list length fits in int.
328 Check for size-calculation overflow when allocating sort data.
329 (syms_of_charset): Allocate an initial charset table that is
330 just under 64 KiB, to avoid problems with glibc malloc and mmap.
331
332 * cmds.c (internal_self_insert): Check for size-calculation overflow.
333
334 * composite.h (struct composition.glyph_len): Now int, not unsigned.
335 The actual value is always <= INT_MAX, and leaving it unsigned made
336 overflow checking harder.
337
338 * dispextern.h (struct glyph_matrix.rows_allocated)
339 (struct face_cache.size): Now ptrdiff_t, for convenience in use
340 with xpalloc. The values are still always <= INT_MAX.
341
342 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
343
344 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
345 (SAFE_NALLOCA): New macro.
346
347 * region-cache.c (struct boundary.pos, find_cache_boundary)
348 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
349 (set_cache_region, invalidate_region_cache)
350 (revalidate_region_cache, know_region_cache, region_cache_forward)
351 (region_cache_backward, pp_cache):
352 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
353 so that ptrdiff_t * can be passed to xpalloc.
354 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
355 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
356 (pp_cache): Don't assume cache_len fits in int.
357 * region-cache.h: Adjust extern decls to match.
358
359 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
360 EMACS_INT, since either will do, for xpalloc.
361
362 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
363 (xnmalloc, xnrealloc, xpalloc): New functions.
364
726e0ab1
PE
365 * bidi.c (bidi_shelve_header_size): New constant.
366 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
367 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
368
51f30bc5 369 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
370 * buffer.c (overlays_at, overlays_in, record_overlay_string)
371 (overlay_strings):
372 Don't update size of array until after memory allocation succeeds,
373 because xmalloc/xrealloc may not return.
0065d054
PE
374 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
375 now that we have proper integer overflow checking.
376 (record_overlay_string, overlay_strings): Catch overflows when
377 calculating size of overlay_str_buf.
726e0ab1 378
0065d054
PE
379 * callproc.c (Fcall_process): Check for size overflow when
380 calculating size of args2.
381 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
382 Normally we prefer signed values, but sticking with ptrdiff_t would
383 require adding more-complicated checks.
726e0ab1
PE
384
385 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
386 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
387 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 388 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
389
390 * character.c (Fstring): Check for size-calculation overflow.
391
392 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
393 unnecessary integer overflow. Check for size overflow.
394 (encode_coding_object): Don't update size until xmalloc succeeds.
395
396 * composite.c (get_composition_id): Check for overflow in glyph
397 length calculations.
398
399 Integer and memory overflow fixes for display code.
400 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
401 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
402 (scrolling_window): Check for overflow in size calculations.
403 (line_draw_cost, realloc_glyph_pool, add_row_entry):
404 Don't assume glyph table len fits in int.
405 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
406 (row_table_size): Now ptrdiff_t, not int.
407 (scrolling_window): Avoid overflow in size calculations.
408 Don't update size until allocation succeeds.
409 * fns.c (concat): Check for overflow in size calculations.
410 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
411 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
412 (NEXT_ALMOST_PRIME_LIMIT): New constant.
413
414 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
415 (get_doc_string): Check for size calculation overflow.
416 Don't update size until allocation succeeds.
417 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
418 EMACS_INT, where ptrdiff_t will do.
419 (Fsubstitute_command_keys): Check for string overflow.
420
421 * editfns.c (set_time_zone_rule): Don't assume environment length
422 fits in int.
423 (message_length): Now ptrdiff_t, not int.
424 (Fmessage_box): Don't update size until allocation succeeds.
425 Don't assume message length fits in int.
426 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
427
0065d054
PE
428 * emacs.c (main): Do not reallocate argv, since there is a null at
429 the end that can be overwritten, and this way there's no need to
430 worry about size-calculation overflow.
431 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
432
433 * eval.c (init_eval_once, grow_specpdl): Don't update size until
434 alloc succeeds.
435 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
436
437 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
438 (x_set_scroll_bar_width, x_figure_window_size):
439 Check for integer overflow.
440 (x_set_alpha): Do not assume XINT fits in int.
441
442 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
443 This is for the members text_lines, text_cols, total_lines, total_cols,
444 where the system imposes an 'int' limit.
445
446 * fringe.c (Fdefine_fringe_bitmap):
447 Don't update size until alloc works.
448
449 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
450 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
451
452 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
453 Check for size-calculation overflow.
454 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
455 do, as we prefer signed integers.
456 (id_to_widget.max_size, id_to_widget.used)
457 (xg_store_widget_in_map, xg_remove_widget_from_map)
458 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
459 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
460 Use and return ptrdiff_t, not int.
461 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
462 * gtkutil.h: Change prototypes to match the above.
463
464 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
465 are duplicate now that they've been promoted to lisp.h.
466 (x_allocate_bitmap_record, x_alloc_image_color)
467 (make_image_cache, cache_image, xpm_load):
468 Don't update size until alloc is done.
469 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
470 (x_detect_edges):
3256efce 471 Check for size calculation overflow.
726e0ab1
PE
472 (ct_colors_allocated_max): New constant.
473 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
474 overflow.
3256efce 475
726e0ab1
PE
476 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
477 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
478 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
479 Use ptrdiff_t, not int, to count maps.
480 (read_char_minibuf_menu_prompt): Check for overflow in size
481 calculations. Don't update size until allocation succeeds. Redo
482 calculations to avoid overflow.
483 * keyboard.h: Change prototypes to match the above.
484
485 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
486 to count maps.
487 (current_minor_maps): Check for size calculation overflow.
488 * keymap.h: Change prototypes to match the above.
489
490 * lread.c (read1, init_obarray): Don't update size until alloc done.
491
492 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
493 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
494
726e0ab1
PE
495 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
496 Now ptrdiff_t, not int.
497 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
498 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
499
500 * process.c (Fnetwork_interface_list): Check for overflow
501 in size calculation.
502
503 * region-cache.c (move_cache_gap): Check for size calculation overflow.
504
505 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
506 overflow. Don't bother calling xmalloc when xrealloc will do.
507
508 * search.c (Freplace_match): Check for size calculation overflow.
509 (Fset_match_data): Don't assume list lengths fit in 'int'.
510
511 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
512 for command line length. Do not attempt to address one before the
513 beginning of an array, as that's not portable.
514
515 * term.c (max_frame_lines): Remove; unused.
516 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
517 not int.
518 (encode_terminal_code, calculate_costs): Check for size
519 calculation overflow.
520 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
521 table lengths and related sizes. Don't update size until alloc
522 done. Redo calculations to avoid overflow.
523 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
524
525 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
526 subtracting pointers.
527 (gobble_line): Check for overflow more carefully. Don't update size
528 until alloc done.
529
530 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
531 Don't update size until alloc done.
532 Redo size calculations to avoid overflow.
533 Check for size calculation overflow.
0065d054 534 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
535
536 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
537 Use ptrdiff_t, not int, for sizes.
538 (store_mode_line_noprop_char): Don't update size until alloc done.
539
0065d054
PE
540 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
541 Use ptrdiff_t, not int, for sizes.
542 (Finternal_make_lisp_face, cache_face):
543 Check for size calculation overflow.
544 (cache_face): Treat size calculation overflows as if they were
545 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
546
547 * xfns.c (x_encode_text, x_set_name_internal)
548 (Fx_change_window_property): Use ptrdiff_t, not int, to count
549 sizes, since they can exceed INT_MAX in size. Check for size
550 calculation overflow.
551
0065d054
PE
552 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
553 (xg_select): Check for size calculation overflow.
726e0ab1
PE
554 Don't update size until alloc done.
555
0065d054 556 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 557 as sprintf is limited to int lengths.
1d526e2f 558
252c5ee1
PE
559 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
560 (X_LONG_MIN): New macros.
864d7ce7
PE
561 Use them to make the following changes clearer.
562 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
563 This change doesn't affect the value now, but it may help remind
564 future maintainers not to raise the value too much later.
565 (SELECTION_QUANTUM): Remove, replacing with ...
566 (selection_quantum): ... new function, which avoids overflow.
567 All uses changed.
568 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
569 assumption that selection length fits in 'int'.
570 (x_reply_selection_request, x_handle_selection_request)
571 (x_get_window_property, receive_incremental_selection)
572 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
573 (lisp_data_to_selection_data, clean_local_selection_data):
574 Use ptrdiff_t, not int, to record length of selection.
575 (x_reply_selection_request, x_get_window_property)
576 (receive_incremental_selection, x_property_data_to_lisp):
577 Redo calculations to avoid overflow.
578 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 579 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
580 something.
581 (x_get_window_property, receive_incremental_selection)
582 (lisp_data_to_selection_data, x_property_data_to_lisp):
583 Check for size-calculation overflow.
584 (x_get_window_property, receive_incremental_selection)
585 (lisp_data_to_selection_data, Fx_register_dnd_atom):
586 Don't store size until memory allocation succeeds.
587 (x_get_window_property): Plug memory leak on memory exhaustion.
588 Don't double-block input; malloc is safe here. Don't assume 2**34
589 - 4 fits in unsigned long. Add an xassert to check
590 XGetWindowProperty overflow. Be more careful about overflow
591 calculations, and distinguish size from memory overflow better.
592 (receive_incremental_selection): When tracing, don't assume
593 unsigned int is less than INT_MAX.
594 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
595 harmful) conversions of unsigned short to int.
596 (lisp_data_to_selection_data): Don't assume that integers
597 in the range -65535 through -1 fit in an X unsigned short.
598 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
599 result parameters unless successful. Rely on cons_to_unsigned
600 to report problems with elements; the old code wasn't right anyway.
601 (x_check_property_data): Check for int overflow; we cannot use
602 a wider type due to X limits.
603 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
604
726e0ab1 605 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 606
0065d054
PE
607 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
608 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
609 (x_color_cells): Don't store size until memory allocation succeeds.
610 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 611 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
612 (x_term_init): Don't assume length fits in int (sprintf is limited
613 to int size).
bc18e09d 614
ebfa62c0
PE
615 Use ptrdiff_t for composition IDs.
616 * character.c (lisp_string_width):
617 * composite.c (composition_table_size, n_compositions)
618 (get_composition_id, composition_gstring_from_id):
619 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
620 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
621 * window.c (Frecenter):
622 Use ptrdiff_t, not int, for composition IDs.
623 * composite.c (get_composition_id): Check for integer overflow.
624 * composite.h: Adjust prototypes to match the above changes.
625
d3411f89
PE
626 Use ptrdiff_t for hash table indexes.
627 * category.c (hash_get_category_set):
628 * ccl.c (ccl_driver):
629 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
630 * coding.c (coding_system_charset_list, detect_coding_system):
631 * coding.h (struct coding_system.id):
632 * composite.c (get_composition_id, gstring_lookup_cache):
633 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
634 * image.c (xpm_get_color_table_h):
635 * lisp.h (hash_lookup, hash_put):
636 * minibuf.c (Ftest_completion):
637 Use ptrdiff_t for hash table indexes, not int (which is too
638 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
639 32-bit --with-wide-int hosts).
640
e097a6fa
PE
641 * charset.c (Fdefine_charset_internal): Check for integer overflow.
642 Add a FIXME comment about memory leaks.
643 (syms_of_charset): Don't assume xmalloc returns.
644
5637687f
PE
645 Don't assume that stated character widths fit in int.
646 * character.c (Fchar_width, c_string_width, lisp_string_width):
647 * character.h (CHAR_WIDTH):
648 * indent.c (MULTIBYTE_BYTES_WIDTH):
649 Use sanitize_char_width to avoid undefined and/or bad behavior
650 with outlandish widths.
651 * character.h (sanitize_tab_width): Renamed from sanitize_width,
652 now that we have two such functions. All uses changed.
653 (sanitize_char_width): New inline function.
654
a2271ba2
PE
655 Don't assume that tab-width fits in int.
656 * character.h (sanitize_width): New inline function.
657 (SANE_TAB_WIDTH): New macro.
658 (ASCII_CHAR_WIDTH): Use it.
659 * indent.c (sane_tab_width): Remove. All uses replaced by
660 SANE_TAB_WIDTH (current_buffer).
661 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
662
18c52557
PE
663 * fileio.c: Integer overflow issues with file modes.
664 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
665
caeeedc1
PE
666 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
667 Remove unreachable code.
668 (read_hex, load_charset_map_from_file): Check for integer overflow.
669
50849c52
PE
670 * xterm.c: don't go over XClientMessageEvent limit
671 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
672 (x_send_scroll_bar_event): Likewise. Check that the size does not
673 exceed limits imposed by XClientMessageEvent, as well as the usual
674 ptrdiff_t and size_t limits.
675
b13995db
PE
676 * keyboard.c: Overflow, signedness and related fixes.
677 (make_lispy_movement): Use same integer type in forward decl
678 that is used in the definition.
679 (read_key_sequence, keyremap_step):
680 Change bufsize argument back to int, undoing my 2011-03-30 change.
681 We prefer signed types, and int is wide enough here.
682 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
683 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
684 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
685 length, not size_t. Use ptrdiff_t for index, not int.
686 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
687 possibility of integer overflow.
688
13464394
PE
689 Overflow, signedness and related fixes for images.
690
691 * dispextern.h (struct it.stack[0].u.image.image_id)
692 (struct_it.image_id, struct image.id, struct image_cache.size)
693 (struct image_cache.used, struct image_cache.ref_count):
694 * gtkutil.c (update_frame_tool_bar):
695 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
696 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
697 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
698 * nsmenu.m (update_frame_tool_bar):
699 * xdisp.c (calc_pixel_width_or_height):
700 * xfns.c (image_cache_refcount):
701 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
702 on typical 64-bit hosts.
703
704 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
705 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
706 Omit unnecessary casts to int.
707 (parse_image_spec): Check that integers fall into 'int' range
708 when the callers expect that.
709 (image_ascent): Redo ascent calculation to avoid int overflow.
710 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
711 (lookup_image): Remove unnecessary tests.
712 (xbm_image_p): Locals are now of int, not EMACS_INT,
713 since parse_image_check makes sure they fit into int.
714 (png_load, gif_load, svg_load_image):
715 Prefer int to unsigned where either will do.
716 (tiff_handler): New function, combining the cores of the
717 old tiff_error_handler and tiff_warning_handler. This
718 function is rewritten to use vsnprintf and thereby avoid
719 stack buffer overflows. It uses only the features of vsnprintf
720 that are common to both POSIX and native Microsoft.
721 (tiff_error_handler, tiff_warning_handler): Use it.
722 (tiff_load, gif_load, imagemagick_load_image):
723 Don't assume :index value fits in 'int'.
724 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
725 (imagemagick_load_image): Check that crop parameters fit into
726 the integer types that MagickCropImage accepts. Don't assume
727 Vimagemagick_render_type has a nonnegative value. Don't assume
728 size_t fits in 'long'.
729 (gs_load): Use printmax_t to print the widest integers possible.
730 Check for integer overflow when computing image height and width.
731
c11821d4
EZ
7322011-08-26 Eli Zaretskii <eliz@gnu.org>
733
734 * xdisp.c (redisplay_window): Don't force window start if point
735 will be invisible in the resulting window. (Bug#9324)
736
0c95fcf7
EZ
7372011-08-25 Eli Zaretskii <eliz@gnu.org>
738
739 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
740 the display spec is of the form `(space ...)'.
741 (handle_display_spec): Return the value returned by
742 handle_single_display_spec, not just 1 or zero.
743 (handle_single_display_spec): If the display spec is of the form
744 `(space ...)', and specifies display in the text area, return 2
745 rather than 1.
fee65a97 746 (try_cursor_movement): Check for the need to scroll more
e25be792
EZ
747 accurately, and prefer exact match for point under bidi. Don't
748 advance `row' beyond the last row of the window.
0c95fcf7
EZ
749
750 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
751 into disp_prop; all users changed.
752
753 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
754 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
755 for the text covered by the display property.
756
e4ed06f1
CY
7572011-08-25 Chong Yidong <cyd@stupidchicken.com>
758
759 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
760 Change return value to nil.
761 (Frecord_buffer): Delete unused function.
762
f67cdd7f
EZ
7632011-08-24 Eli Zaretskii <eliz@gnu.org>
764
5980d4c6
EZ
765 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
766 buffers, return left-to-right.
8610fe8b
EZ
767 (set_cursor_from_row): Consider candidate row a win if its glyph
768 represents a newline and point is on that newline. Fixes cursor
769 positioning on the newline at EOL of R2L text within L2R
770 paragraph, and vice versa.
771 (try_cursor_movement): Check continued rows, in addition to
772 continuation rows. Fixes unwarranted scroll when point enters a
773 continued line of R2L text within an L2R paragraph, or vice versa.
774 (cursor_row_p): Consider the case of point being equal to
775 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
776 from the end of a short line to the beginning of a continued line
777 of R2L text within L2R paragraph.
778 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
779 composed characters.
5980d4c6 780
f67cdd7f
EZ
781 * bidi.c (bidi_check_type): Use xassert.
782 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
783 members.
784
bca633fb
EZ
7852011-08-23 Eli Zaretskii <eliz@gnu.org>
786
787 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
788 a character.
789
4a5885a7
CY
7902011-08-23 Chong Yidong <cyd@stupidchicken.com>
791
792 * nsfont.m (ns_otf_to_script): Fix typo.
793
0902a04e
KH
7942011-08-22 Kenichi Handa <handa@m17n.org>
795
796 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
797 extra slot even if the purpose is char-code-property-table.
798
1a2e6670
EZ
7992011-08-23 Eli Zaretskii <eliz@gnu.org>
800
8ddde651
EZ
801 * xdisp.c (redisplay_window): When computing centering_position,
802 account for the height of the header line. (Bug#8874)
803
425cc014
EZ
804 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
805 instead of CHAR_TO_BYTE. Fixes a crash when a completion
806 candidate is selected by the mouse, and that candidate has a
807 composed character under the mouse.
808
1a2e6670
EZ
809 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
810 coordinates reported by pos-visible-in-window-p for a composed
811 character in column zero.
812
8b76d6f8
SM
8132011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
814
815 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
816
dac347dd
EZ
8172011-08-22 Eli Zaretskii <eliz@gnu.org>
818
819 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
820 consider it a hit if to_charpos is anywhere in the range of the
821 composed buffer positions.
822
e013fb34
CY
8232011-08-22 Chong Yidong <cyd@stupidchicken.com>
824
825 * image.c (gif_load): Don't assume that each subimage has the same
826 dimensions as the base image. Handle disposal method that is
827 "undefined" by the gif spec (Bug#9335).
828
bd1ba3e8
CY
8292011-08-20 Chong Yidong <cyd@stupidchicken.com>
830
831 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 832 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 833
54a1215b
EZ
8342011-08-19 Eli Zaretskii <eliz@gnu.org>
835
823564e5
EZ
836 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
837 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
838 from an Org mode buffer to a Speedbar frame.
839
54a1215b
EZ
840 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
841 a composition, take its buffer position from IT->cmp_it.charpos.
842 Fixes cursor positioning at the beginning of a line that begins
843 with a composed character.
844
9778ebcc
EZ
8452011-08-18 Eli Zaretskii <eliz@gnu.org>
846
0be6ee06
EZ
847 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
848 character bidirectional type, use STRONG_L instead. Fixes crashes
849 in a buffer produced by `describe-categories'.
850
9778ebcc
EZ
851 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
852 members before the level stack, so they would be saved and
853 restored when copying iterator state. Fixes incorrect reordering
854 around TABs covered by display properties.
855
156bffbe
AS
8562011-08-18 Andreas Schwab <schwab@linux-m68k.org>
857
858 * process.c (Fnetwork_interface_list): Correctly determine buffer
859 size.
860
72ad093b
CY
8612011-08-17 Chong Yidong <cyd@stupidchicken.com>
862
863 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
864 (internal_condition_case_2, internal_condition_case_n):
865 Remove unnecessary aborts (Bug#9081).
72ad093b 866
35774242
EZ
8672011-08-17 Eli Zaretskii <eliz@gnu.org>
868
869 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
870 has no `load' handler, try opening the file locally. (Bug#9311)
871
db76dd85
KB
8722011-08-16 Ken Brown <kbrown@cornell.edu>
873
874 * gmalloc.c: Expand comment.
875
b215eee5
EZ
8762011-08-16 Eli Zaretskii <eliz@gnu.org>
877
878 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
879 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
880
a4579d33
KB
8812011-08-16 Ken Brown <kbrown@cornell.edu>
882
883 Fix memory allocation problems in Cygwin build (Bug#9273).
884
885 * unexcw.c ( __malloc_initialized): Declare external variable.
886 (fixup_executable): Force the dumped emacs to reinitialize malloc.
887
8b76d6f8
SM
888 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
889 New variables.
a4579d33
KB
890 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
891 dumped emacs.
892 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
893 in the static heap.
894 [CYGWIN] (special_realloc): New function.
895 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
896 requests to realloc storage in the static heap.
897
3ebec551
PE
8982011-08-15 Paul Eggert <eggert@cs.ucla.edu>
899
900 * bidi.c (bidi_initialize): Remove unused local.
901
9fd8be00
EZ
9022011-08-15 Eli Zaretskii <eliz@gnu.org>
903
474a8465
EZ
904 * biditype.h: File removed.
905
906 * bidimirror.h: File removed.
907
908 * deps.mk (bidi.o): Remove biditype.h and
909 bidimirror.h.
910
911 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
912 bidimirror.h.
913
914 * dispextern.h: Fix a typo in the comment to bidi_type_t.
915
916 * chartab.c: Improve commentary for the uniprop_table API.
917
32413314
EZ
918 * bidi.c (bidi_paragraph_init): Support zero value of
919 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
920 (bidi_initialize): Use uniprop_table instead of including
921 biditype.h and bidimirror.h.
32413314 922
9fd8be00
EZ
923 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
924 coordinates of the iterator when restoring from ppos_it.
925 (Bug#9296)
926
5cf2b69b
KH
9272011-08-14 Kenichi Handa <handa@m17n.org>
928
929 * process.c (create_process): Call setup_process_coding_systems
72ad093b 930 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 931
daf17d00
EZ
9322011-08-14 Eli Zaretskii <eliz@gnu.org>
933
934 * xdisp.c (move_it_in_display_line_to): Don't invoke
935 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
936 ppos_it. Fixes vertical cursor motion when line beginning is
937 covered by an image. (Bug#9296)
938
08e3161a
JD
9392011-08-14 Jan Djärv <jan.h.d@swipnet.se>
940
941 * nsterm.h (ns_run_ascript): Declare.
942 (NSAPP_DATA2_RUNASSCRIPT): Define.
943
944 * nsfns.m (as_script, as_result, as_status): New static variables.
945 (ns_run_ascript): New function.
5e617bc2 946 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
947 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
948 the event loop. Get status from as_status (Bug#7276).
949
950 * nsterm.m (sendEvent): If event is NSApplicationDefined and
951 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
952 the event loop (Bug#7276).
953
a3720aa2
AS
9542011-08-14 Andreas Schwab <schwab@linux-m68k.org>
955
956 * gnutls.c (QCgnutls_bootprop_priority)
957 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
958 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
959 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
960 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
961 (QCgnutls_bootprop_verify_hostname_error)
962 (QCgnutls_bootprop_callbacks_verify): Rename from
963 Qgnutls_bootprop_..., all uses changed.
964
965 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
966 uses changed.
967
0a0d27fb
PE
9682011-08-14 Paul Eggert <eggert@cs.ucla.edu>
969
19d5c50c
PE
970 * xfaces.c (Qframe_set_background_mode): Now static.
971 * dispextern.h (Qframe_set_background_mode): Remove decl.
972
0a0d27fb
PE
973 * process.c (Fnetwork_interface_info): Declare local only if needed.
974
377538cb
JD
9752011-08-13 Jan Djärv <jan.h.d@swipnet.se>
976
977 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
978 (Fnetwork_interface_list): Allocate in increments of bytes instead
979 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
980 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
981 sockaddr.
982 (struct ifflag_def): notrailers is smart on OSX.
983 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
984 Get hardware address with getifaddrs if available.
985
08fff70c
EZ
9862011-08-12 Eli Zaretskii <eliz@gnu.org>
987
988 * xdisp.c (iterate_out_of_display_property): xassert that
989 IT->position is set to within IT->object's boundaries. Break from
990 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
991 when IT->position is set up wrongly due to some bug.
992 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
993 (push_display_prop): Allow GET_FROM_STRING as IT->method on
994 entry. Force push_it to save on the stack the current
995 buffer/string position, to be restored by pop_it. Fix flags in
996 the iterator structure wrt the object coming from a display
997 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
998 properties. (Bug#9284)
999
7be1c708 10002011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 1001
7be1c708
CY
1002 * fontset.c (fontset_get_font_group): Add proper type checks.
1003 (Bug#9172)
aac0c6e3 1004
7be1c708 10052011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 1006
7be1c708
CY
1007 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1008 and LC_VERSION_MIN_MACOSX.
1009 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1010 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 1011
97bb72a6
EZ
10122011-08-08 Eli Zaretskii <eliz@gnu.org>
1013
1014 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
1015 no-display-properties-and-no-overlays under bidi display.
1016 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 1017 properties and overlays.
97bb72a6 1018
d5617611
CY
10192011-08-08 Chong Yidong <cyd@stupidchicken.com>
1020
37e11a63
CY
1021 * editfns.c (Fset_time_zone_rule): Document relationship with the
1022 setenv function.
1023
d5617611
CY
1024 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1025 the font entity extracted from the cache (Bug#8109).
1026
58872834
CY
10272011-08-07 Chong Yidong <cyd@stupidchicken.com>
1028
1029 * composite.c (autocmp_chars): Don't reset point. That is done by
1030 restore_point_unwind (Bug#5984).
1031
75bfc667
JL
10322011-08-07 Juri Linkov <juri@jurta.org>
1033
1034 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1035 to show the arg `TIME' instead of `TIMEVAL'.
1036
d1410150
EZ
10372011-08-06 Eli Zaretskii <eliz@gnu.org>
1038
1039 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1040 display property strides EOL and includes a newline, as in
1041 longlines-mode. (Bug#9254)
75b771e4
EZ
1042 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1043 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
1044
1045 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1046 is non-zero, even if the data buffer is NULL. Fixes a crash in
1047 vertical-motion with longlines-mode. (Bug#9254)
1048
35928349
EZ
10492011-08-05 Eli Zaretskii <eliz@gnu.org>
1050
ec7cc85b
EZ
1051 * bidi.c <bidi_cache_total_alloc>: Now static.
1052 (bidi_initialize): Initialize bidi_cache_total_alloc.
1053
8b76d6f8 1054 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
1055 cache. (Bug#9221)
1056
1057 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1058 amount allocated this far in `bidi_cache_total_alloc'.
1059 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1060 non-zero, only free the data buffer without restoring the cache
1061 contents. All callers changed.
1062
1063 * dispextern.h (bidi_unshelve_cache): Update prototype.
1064
1065 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1066 (move_it_in_display_line, move_it_to)
1067 (move_it_vertically_backward, move_it_by_lines): Replace the call
1068 to xfree to an equivalent call to bidi_unshelve_cache.
1069 (move_it_in_display_line_to): Fix logic of returning
412b6358 1070 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 1071
e2e2423b
EZ
10722011-08-05 Eli Zaretskii <eliz@gnu.org>
1073
1074 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1075 came from a string character with a `cursor' property. (Bug#9229)
1076
ae9e757a
JD
10772011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1078
1079 * Makefile.in (LIB_PTHREAD): New variable.
1080 (LIBES): Add LIB_PTHREAD (Bug#9216).
1081
1082 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1083 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1084
213bd7f2
AS
10852011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1086
1087 * regex.c (re_iswctype): Remove some redundant boolean
1088 conversions.
1089
99aaf75f
JD
10902011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1091
1092 * xterm.c (x_find_topmost_parent): New function.
1093 (x_set_frame_alpha): Find topmost parent window with
1094 x_find_topmost_parent and set the property there also (bug#9181).
1095 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1096
c74e9d86
PE
10972011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1098
1099 * callproc.c (Fcall_process): Avoid vfork clobbering
1100 the local vars buffer, coding_systems, current_dir.
1101
640c8776
SM
11022011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1103
1104 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1105
f26d0e4c
PE
11062011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1107
8a10d76c
PE
1108 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1109 so that it is not optimized away.
1110
f26d0e4c
PE
1111 * xdisp.c (compute_display_string_pos): Remove unused local.
1112
55439c61
EZ
11132011-08-02 Eli Zaretskii <eliz@gnu.org>
1114
1115 Fix slow cursor motion and scrolling in large buffers with
1116 selective display, like Org Mode buffers. (Bug#9218)
1117
1118 * dispextern.h (struct bidi_it): New member disp_prop_p.
1119
1120 * xdisp.c: Remove one-slot cache of display string positions.
1121 (compute_display_string_pos): Accept an additional argument
5e617bc2 1122 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
1123 for a display string or property. If found, set DISP_PROP_P
1124 non-zero.
1125
1126 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
1127 DISP_PROP_P, and pass it to compute_display_string_pos.
1128 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
1129 non-zero. All callers of bidi_fetch_char changed.
1130
fb33fa43
SM
11312011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1132
1133 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1134
b099e063
DM
11352010-12-03 Don March <don@ohspite.net>
1136
1137 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1138 last character M-[char] is translated to ESC [char] (bug#7541).
1139
5cc7f7af
KH
11402011-08-02 Kenichi Handa <handa@m17n.org>
1141
d0fffa3f 1142 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
1143
1144 * chartab.c (uniprop_table): Make it non-static.
1145
525d5e6e
EZ
11462011-08-01 Eli Zaretskii <eliz@gnu.org>
1147
1148 * xdisp.c (forward_to_next_line_start): Accept additional argument
1149 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1150 on the newline.
1151 (reseat_at_next_visible_line_start): Use the bidi iterator state
1152 returned by forward_to_next_line_start to restore the state of
1153 it->bidi_it after backing up to previous newline. (Bug#9212)
1154
31011111
AS
11552011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1156
1157 * regex.c (re_comp): Protoize.
1158 (re_exec): Fix return type.
1159 (regexec): Fix type of `ret'. (Bug#9203)
1160
476371c4
PE
11612011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1162
e5d76069
PE
1163 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1164 This is needed if max-image-size is a floating-point number.
1165
9a79b20c
AS
11662011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1167
1168 * print.c (print_object): Print empty symbol as ##.
1169
1170 * lread.c (read1): Read ## as empty symbol.
1171
d8c2fa78
AA
11722011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1173
1174 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1175 setting frame foreground color (Bug#9175).
1176 (x_set_background_color): Likewise.
1177
ffe57a7a
AA
1178 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1179 contents (Bug#9176).
1180 (EmacsTooltip -init): Remove bezels and add shadows to
1181 tooltip windows.
1182
bf3492a5
AA
1183 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1184 or scroll bar (Bug#8470).
1185
d55e9c53
AA
1186 * nsfont.m (nsfont_open): Remove assignment to voffset and
1187 unnecessary vars hshink, expand, hd, full_height, min_height.
1188 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1189
1190 * nsterm.h (nsfont_info): Remove voffset field.
1191
d8c2fa78 11922011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
1193
1194 Implement strike-through and overline on NextStep (Bug#8863).
1195
1196 * nsfont.m (nsfont_open): Use underline position provided by font,
1197 instead of hard-coded value of 2.
1198 (nsfont_draw): Call ns_draw_text_decoration instead.
1199
1200 * nsterm.h: Add declaration for ns_draw_text_decoration.
1201
1202 * nsterm.m (ns_draw_text_decoration): New function for drawing
1203 underline, overline, and strike-through.
1204 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1205 ns_draw_text_decoration. Change treatment of cursor drawing to
1206 accomodate underlining, etc.
1207
4cc60b9b
EZ
12082011-07-28 Eli Zaretskii <eliz@gnu.org>
1209
bc7ece87
EZ
1210 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1211 default.
4cc60b9b 1212
476371c4
PE
12132011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1214
66606eea
PE
1215 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1216 Without this fix, if a signal arrives just after memory fills up,
1217 'malloc' might be invoked reentrantly.
1218
476371c4
PE
1219 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1220 In other words, assume that every image size is allowed, on non-X
1221 hosts. This assumption is probably wrong, but it lets Emacs compile.
1222
f3fcc40d
AS
12232011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1224
1225 * regex.c (re_iswctype): Convert return values to boolean.
1226
350c992f
EZ
12272011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1228
1229 * xdisp.c (compute_display_string_pos): Don't use cached display
1230 string position if the buffer had its restriction changed.
1231 (Bug#9184)
1232
5266b4bb
PE
12332011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1234
1235 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1236
2573a837 12372011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 1238
41f55ccd 1239 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 1240
39e378da
PE
1241 * bidi.c: Integer size and overflow fixes.
1242 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1243 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1244 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1245 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1246 (bidi_find_other_level_edge):
1247 Use ptrdiff_t instead of EMACS_INT where either will do.
1248 This works better on 32-bit hosts configured --with-wide-int.
1249 (bidi_cache_ensure_space): Check for size-calculation overflow.
1250 Use % rather than repeated addition, for better worst-case speed.
1251 Don't set bidi_cache_size until after xrealloc returns, because it
1252 might not return.
1253 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
1254 (bidi_cache_ensure_space): Also check that the bidi cache size
1255 does not exceed that of the largest Lisp string or buffer. See Eli
1256 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 1257
5e927815
PE
1258 * alloc.c (__malloc_size_t): Remove.
1259 All uses replaced by size_t. See Andreas Schwab's note
1260 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1261
ca4aa935
PE
1262 * image.c: Improve checking for integer overflow.
1263 (check_image_size): Assume that f is nonnull, since
1264 it is always nonnull in practice. This is one less thing to
1265 worry about when checking for integer overflow later.
1266 (x_check_image_size): New function, which checks for integer
1267 overflow issues inside X.
1268 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1269 This removes the need for a memory_full check.
1270 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1271 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1272 (xbm_read_bitmap_data): Change locals back to 'int', since
1273 their values must fit in 'int'.
1274 (xpm_load_image, png_load, tiff_load):
1275 Invoke x_create_x_image_and_pixmap earlier,
1276 to avoid much needless work if the image is too large.
1277 (tiff_load): Treat overly large images as if
1278 x_create_x_image_and_pixmap failed, not as malloc failures.
1279 (gs_load): Use x_check_image_size.
1280
5f8f9cc2
PE
1281 * gtkutil.c: Omit integer casts.
1282 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1283 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1284
5adf60bc
PE
1285 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1286
c8907a93
PE
1287 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1288 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1289 would wrongly return t on a 64-bit host.
1290
e3c25c68
PE
1291 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1292 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1293 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1294 and therefore cause GCC to emit a bogus diagnostic in some cases.
1295
3f791afe
PE
1296 * image.c: Integer signedness and overflow and related fixes.
1297 This is not an exhaustive set of fixes, but it's time to
1298 record what I've got.
1299 (lookup_pixel_color, check_image_size): Remove redundant decls.
1300 (check_image_size): Don't assume that arbitrary EMACS_INT values
1301 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1302 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1303 (tiff_load, imagemagick_load_image):
1304 Check for overflow in size calculations.
1305 (x_create_x_image_and_pixmap): Remove unnecessary test for
1306 xmalloc returning NULL; that can't happen.
1307 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1308 (xpm_color_bucket): Use better integer hashing function.
1309 (xpm_cache_color): Don't possibly over-allocate memory.
1310 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1311 (gif_memory_source):
1312 Use ptrdiff_t, not int or size_t, to record sizes.
1313 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1314 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1315 either works, as we prefer signed integers.
1316 (tiff_read_from_memory, tiff_write_from_memory):
1317 Return tsize_t, not size_t, since that's what the TIFF API wants.
1318 (tiff_read_from_memory): Don't fail simply because the read would
1319 go past EOF; instead, return a short read.
1320 (tiff_load): Omit no-longer-needed casts.
1321 (Fimagemagick_types): Don't assume size fits into 'int'.
1322
3cc5a532
PE
1323 Improve hashing quality when configured --with-wide-int.
1324 * fns.c (hash_string): New function, taken from sxhash_string.
1325 Do not discard information about ASCII character case; this
1326 discarding is no longer needed.
1327 (sxhash-string): Use it. Change sig to match it. Caller changed.
1328 * lisp.h: Declare it.
1329 * lread.c (hash_string): Remove, since we now use fns.c's version.
1330 The fns.c version returns a wider integer if --with-wide-int is
1331 specified, so this should help the quality of the hashing a bit.
1332
b312a492
PE
1333 * emacs.c: Integer overflow minor fix.
1334 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1335 Define only if GNU_LINUX.
1336 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1337
dfd153ae
PE
1338 * dispnew.c: Integer signedness and overflow fixes.
1339 Remove unnecessary forward decls, that were a maintenance hassle.
1340 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1341 All uses changed.
1342 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1343 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1344 (prepare_desired_row, line_draw_cost):
1345 Use int, not unsigned, where either works.
1346 (save_current_matrix, restore_current_matrix):
1347 Use ptrdiff_t, not size_t, where either works.
1348 (init_display): Check for overflow more accurately, and without
1349 relying on undefined behavior.
1350
a81d11a3
PE
1351 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1352 Remove, replacing with the new symbols in lisp.h. All uses changed.
1353 * fileio.c (make_temp_name):
1354 * filelock.c (lock_file_1, lock_file):
1355 * xdisp.c (message_dolog):
1356 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1357 Use pMd etc. instead.
1358 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1359 replacing the pWIDE etc. symbols removed from editfns.c.
1360
3300e6fd
PE
1361 * keyboard.h (num_input_events): Now uintmax_t.
1362 This is (very slightly) less likely to mess up due to wraparound.
1363 All uses changed.
1364
fd05c7e9
PE
1365 * buffer.c: Integer signedness fixes.
1366 (alloc_buffer_text, enlarge_buffer_text):
1367 Use ptrdiff_t rather than size_t when either will do, as we prefer
1368 signed integers.
1369
903fe15d
PE
1370 * alloc.c: Integer signedness and overflow fixes.
1371 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1372 (__malloc_size_t): Default to size_t, not to int.
1373 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1374 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1375 Prefer ptrdiff_t to size_t when either would do, as we prefer
1376 signed integers.
1377 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1378 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1379 Now const. Initialize with values that are in range even if char
1380 is signed.
1381 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1382 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1383 These functions do the right thing with sizes > 2**32.
1384 (check_depth): Now ptrdiff_t, not int.
1385 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1386 Adjust to new way of storing sizes. Check for size overflow bugs
1387 in rest of code.
1388 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1389 slightly wrong anyway, as it missed one instance of
1390 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1391 (refill_memory_reserve): Omit needless cast to size_t.
1392 (mark_object_loop_halt): Mark as externally visible.
1393
ac82cc6a
PE
1394 * xselect.c: Integer signedness and overflow fixes.
1395 (Fx_register_dnd_atom, x_handle_dnd_message):
1396 Use ptrdiff_t, not size_t, since we prefer signed.
1397 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1398 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1399 x_dnd_atoms_size and x_dnd_atoms_length.
1400
c2d1e36d
PE
1401 * doprnt.c: Prefer signed to unsigned when either works.
1402 * eval.c (verror):
1403 * doprnt.c (doprnt):
1404 * lisp.h (doprnt):
1405 * xdisp.c (vmessage):
1406 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1407 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1408 prefer signed arithmetic to avoid comparison confusion.
1409 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1410 but is a bit tricky.
1411
0e926e56
PE
1412 Assume freestanding C89 headers, string.h, stdlib.h.
1413 * data.c, doprnt.c, floatfns.c, print.c:
1414 Include float.h unconditionally.
1415 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1416 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1417 * regex.c: Likewise for stddef.h, string.h.
1418 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1419 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1420 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1421 (STDC_HEADERS): Remove obsolete defines.
1422 * sysdep.c: Include limits.h unconditionally.
1423
9cfdb3ec
PE
1424 Assume support for memcmp, memcpy, memmove, memset.
1425 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1426 * regex.c (memcmp, memcpy):
1427 Remove; we assume C89 now.
1428
1429 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1430 (__malloc_safe_bcopy): Remove; no longer needed.
1431
cf950e6b 1432 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
1433 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1434 well either way, and we prefer signed to unsigned.
1435
dbf38e02
LMI
14362011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1437
1438 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1439 closes the connection while we're reading (bug#9182).
1440
d6f0886c 14412011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 1442
d6f0886c
JD
1443 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1444 are specified (Bug#9168).
24e0f6b1 1445
2eb1f9e6
PE
14462011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1447
1448 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1449 Found by GCC static checking and --with-wide-int on a 32-bit host.
1450
22381272 14512011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
1452
1453 * xdisp.c (compute_display_string_pos): Fix logic of caching
1454 previous display string position. Initialize cached_prev_pos to
1455 -1. Fixes slow-down at the beginning of a buffer.
1456
f25e39b4
EZ
14572011-07-24 Eli Zaretskii <eliz@gnu.org>
1458
1459 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1460 for attrs[LFACE_FONTSET_INDEX].
1461
04c4b52e
PE
14622011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1463
1464 * xml.c (parse_region): Remove unused local
1465 that was recently introduced.
1466
c1734fbd
EZ
14672011-07-23 Eli Zaretskii <eliz@gnu.org>
1468
be18c5a5
EZ
1469 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1470 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1471
c1734fbd
EZ
1472 * xdisp.c (move_it_in_display_line_to): Record the best matching
1473 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
1474 exit if none of the characters scanned was an exact match.
1475 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
1476 when exact match is impossible due to invisible text, and the
1477 lines are truncated.
1478
a258d627
JD
14792011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1480
1481 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1482 for OSX >= 10.7.
1483
b6d5a689
EZ
14842011-07-22 Eli Zaretskii <eliz@gnu.org>
1485
0f74f785
EZ
1486 Fix a significant slow-down of cursor motion with C-n, C-p,
1487 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1488 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 1489 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
1490 (next_element_from_buffer): Call compute_stop_pos_backwards to
1491 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
1492 base_level_stop.
1493 (reseat): Don't look for prev_stop, as that could mean a very long
1494 run.
1495 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1496 <cached_disp_overlay_modiff>: Cache for last found display string
1497 position.
551918c1 1498 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
1499 about the same buffer in the same area of character positions, and
1500 the buffer wasn't changed since the time the display string
1501 position was cached.
551918c1 1502
b2d0c91a
EZ
15032011-07-22 Eli Zaretskii <eliz@gnu.org>
1504
1505 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1506 is an integer, which is important for empty lines. (Bug#9149)
1507
043604ee
CY
15082011-07-22 Chong Yidong <cyd@stupidchicken.com>
1509
1510 * frame.c (Fmodify_frame_parameters): In tty case, update the
1511 default face if necessary (Bug#4238).
1512
da4adb04
CY
15132011-07-21 Chong Yidong <cyd@stupidchicken.com>
1514
1515 * editfns.c (Fstring_to_char): No need to explain what a character
1516 is in the docstring (Bug#6576).
1517
9abd0532
LMI
15182011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1519
1520 * xml.c (parse_region): Make sure we always return a tree.
1521
36881d16
HK
15222011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1523
1524 * xml.c (parse_region): If a document contains only comments,
1525 return that, too.
1526
1e98674d
LMI
15272011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1528
1529 * xml.c (make_dom): Return comments, too.
1530
590bd467
PE
15312011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1532
1533 Port to OpenBSD.
1534 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1535 and the surrounding thread.
1536 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1537 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1538 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1539 timer goes off.
1540 * s/openbsd.h (BROKEN_SIGIO): Define.
1541 * unexelf.c (unexec) [__OpenBSD__]:
1542 Don't update the .mdebug section of the Alpha COFF symbol table.
1543
f41628b2
LMI
15442011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1545
1546 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1547 (bug#8460).
1548
b59b67c5
PE
15492011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1550
15e3a074
PE
1551 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1552 This fixes some race conditions on the permissions of any newly
1553 created file.
1554
41bed37d
PE
1555 * alloc.c (valid_pointer_p): Use pipe, not open.
1556 This fixes some permissions issues when debugging.
1557
b59b67c5
PE
1558 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1559 If fchown fails to set both uid and gid, try to set just gid,
1560 as that is sometimes allowed. Adjust the file's mode to eliminate
1561 setuid or setgid bits that are inappropriate if fchown fails.
1562
925a6be7
SM
15632011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1564
1565 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1566 to compare Lisp_Objects.
1567 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1568 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1569 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1570
52968808
AS
15712011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1572
0a6a104b
AS
1573 * lread.c (read_integer): Unread even EOF character.
1574 (read1): Likewise. Properly record start position of symbol.
1575
52968808
AS
1576 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1577 symbol character follows.
1578
9e381cdd
PE
15792011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1580
1581 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1582 This works around a problem with the previous change to Fcopy_file.
1583 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1584 and without this change, GCC might complain about discarding
1585 fchown's return value.
1586
b5641435
JB
15872011-07-16 Juanma Barranquero <lekktu@gmail.com>
1588
1589 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1590
a8031457
PE
15912011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1592
1593 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1594
dd889327
LMI
15952011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1596
750c33f7
LMI
1597 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1598 it's used from the C level.
1599
dd889327
LMI
1600 * process.c: Use the same condition for POLL_FOR_INPUT in both
1601 keyboard.c and process.c (bug#1858).
1602
87e86684
LM
16032011-07-09 Lawrence Mitchell <wence@gmx.li>
1604
1605 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1606 (Fgnutls_boot): Use it.
1607
64348f40
AS
16082011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1609
1610 * doc.c (Fsubstitute_command_keys): Revert last change.
1611
1d698799
LMI
16122011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1613
f863868c
LMI
1614 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1615 quotes the next character, and doesn't affect other longer
1616 sequences (bug#8935).
1617
1d698799
LMI
1618 * lread.c (syms_of_lread): Clarify that is isn't only
1619 `eval-buffer' and `eval-defun' that's affected by
1620 `lexical-binding' (bug#8460).
1621
aa4b6df6
EZ
16222011-07-15 Eli Zaretskii <eliz@gnu.org>
1623
1624 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1625 bidi redisplay when a line includes both an image and is
1626 truncated.
1627
5d856da6
PE
16282011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1629
ad6042bb
PE
1630 Fix minor problems found by static checking.
1631 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1632 (elsz): Now a signed constant, not a size_t var. We prefer signed
1633 types to unsigned, to avoid integer comparison confusion. Without
1634 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1635 "cannot optimize loop, the loop counter may overflow", a symptom
1636 of the confusion.
f00bbb22 1637 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
1638 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1639
6468f31c
LMI
16402011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1641
49080b10
LMI
1642 * search.c (Fre_search_backward): Mention `case-fold-search' in
1643 all the re_search_* functions (bug#8138).
1644
6468f31c
LMI
1645 * keyboard.c (Fopen_dribble_file): Document when the file is
1646 closed (bug#8056).
1647
c965adc5
EZ
16482011-07-14 Eli Zaretskii <eliz@gnu.org>
1649
df9733bf
EZ
1650 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1651 bidi_cache_idx.
1652
0bb23927
EZ
1653 Support bidi reordering of display and overlay strings.
1654 * xdisp.c (compute_display_string_pos)
1655 (compute_display_string_end): Accept additional argument STRING.
1656 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1657 (reseat_to_string): Initialize bidi_it->string.s and
1658 bidi_it->string.schars.
1659 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
1660 NULL (avoids a crash in bidi_paragraph_init).
1661 Initialize itb.string.lstring.
0bb23927
EZ
1662 (init_iterator): Call bidi_init_it only of a valid
1663 buffer position was specified. Initialize paragraph_embedding to
1664 L2R.
1665 (reseat_to_string): Initialize the bidi iterator.
1666 (display_string): If we need to ignore text properties of
1667 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1668 original value of -1 will not work with bidi.)
1669 (compute_display_string_pos): First arg is now struct
1670 `text_pos *'; all callers changed. Support display properties on
1671 Lisp strings.
1672 (compute_display_string_end): Support display properties on Lisp
1673 strings.
1674 (init_iterator, reseat_1, reseat_to_string): Initialize the
1675 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1676 when iterating on a string not from display properties).
640c8776
SM
1677 (compute_display_string_pos, compute_display_string_end):
1678 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
1679 arrow keys.
1680 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
1681 base_level_stop; instead, set base_level_stop to BEGV.
1682 Fixes crashes in vertical-motion.
0bb23927
EZ
1683 (next_element_from_buffer): Improve commentary for when
1684 the iterator is before prev_stop.
1685 (init_iterator): Initialize bidi_p from the default value of
1686 bidi-display-reordering, not from buffer-local value. Use the
1687 buffer-local value only if initializing for buffer iteration.
1688 (handle_invisible_prop): Support invisible properties on strings
1689 that are being bidi-reordered.
1690 (set_iterator_to_next): Support bidi reordering of C strings and
1691 Lisp strings.
1692 (next_element_from_string): Support bidi reordering of Lisp
1693 strings.
1694 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
1695 (display_string): Support display of R2L glyph rows.
1696 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
1697 (init_iterator): Don't initialize it->bidi_p for strings
1698 here.
1699 (reseat_to_string): Initialize it->bidi_p for strings here.
1700 (next_element_from_string, next_element_from_c_string)
1701 (next_element_from_buffer): Add xassert's for correspondence
1702 between IT's object being iterated and it->bidi_it.string
1703 structure.
1704 (face_before_or_after_it_pos): Support bidi iteration.
1705 (next_element_from_c_string): Handle the case of the first string
1706 character that is not the first one in the visual order.
1707 (get_visually_first_element): New function, refactored from common
1708 parts of next_element_from_buffer, next_element_from_string, and
1709 next_element_from_c_string.
1710 (tool_bar_lines_needed, redisplay_tool_bar)
1711 (display_menu_bar): Force left-to-right direction. Add a FIXME
1712 comment for making that be controlled by a user option.
1713 (push_it, pop_it): Save and restore the state of the
1714 bidi iterator. Save and restore the bidi_p flag.
1715 (pop_it): Iterate out of display property for string iteration as
1716 well.
1717 (iterate_out_of_display_property): Support iteration over strings.
1718 (handle_single_display_spec): Set up it->bidi_it for iteration
1719 over a display string, and call bidi_init_it.
1720 (handle_single_display_spec, next_overlay_string)
1721 (get_overlay_strings_1, push_display_prop): Set up the bidi
1722 iterator for displaying display or overlay strings.
1723 (forward_to_next_line_start): Don't use the shortcut if
1724 bidi-iterating.
1725 (back_to_previous_visible_line_start): If handle_display_prop
1726 pushed the iterator stack, restore the internal state of the bidi
1727 iterator by calling bidi_pop_it same number of times.
1728 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
1729 and we are bidi-iterating, don't decrement the iterator position;
1730 instead, set the first_elt flag in the bidi iterator, to produce
1731 the same effect.
1732 (reseat_1): Remove redundant setting of string_from_display_prop_p.
1733 (push_display_prop): xassert that we are iterating a buffer.
1734 (push_it, pop_it): Save and restore paragraph_embedding member.
1735 (handle_single_display_spec, next_overlay_string)
1736 (get_overlay_strings_1, reseat_1, reseat_to_string)
1737 (push_display_prop): Set up the `unibyte' member of bidi_it.string
1738 correctly. Don't assume unibyte strings are not bidi-reordered.
1739 (compute_display_string_pos)
1740 (compute_display_string_end): Fix handling the case of C string.
1741 (push_it, pop_it): Save and restore from_disp_prop_p.
1742 (handle_single_display_spec, push_display_prop): Set the
1743 from_disp_prop_p flag.
1744 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
1745 (pop_it): Call iterate_out_of_display_property only if we are
1746 popping after iteration over a string that came from a display
1747 property. Fix a typo in popping stretch info. Add an assertion
1748 for verifying that the iterator position is in sync with the bidi
1749 iterator.
1750 (handle_single_display_spec, get_overlay_strings_1)
1751 (push_display_prop): Fix initialization of paragraph direction for
1752 string when that of the parent object is not yet determined.
1753 (reseat_1): Call bidi_init_it to resync the bidi
1754 iterator with IT's position. (Bug#7616)
1755 (find_row_edges): If ROW->start.pos gives position
1756 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
1757 (handle_stop, back_to_previous_visible_line_start, reseat_1):
1758 Reset the from_disp_prop_p flag.
1759 (SAVE_IT, RESTORE_IT): New macros.
1760 (pos_visible_p, face_before_or_after_it_pos)
1761 (back_to_previous_visible_line_start)
1762 (move_it_in_display_line_to, move_it_in_display_line)
1763 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1764 (try_scrolling, redisplay_window, display_line): Use them when
1765 saving a temporary copy of the iterator and restoring it back.
1766 (back_to_previous_visible_line_start, reseat_1)
1767 (init_iterator): Empty the bidi cache "stack".
1768 (move_it_in_display_line_to): If iterator ended up at
1769 EOL, but we never saw any buffer positions smaller than
1770 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
1771 motion in bidi-reordered lines.
1772 (move_it_in_display_line_to): Record prev_method and prev_pos
1773 immediately before the call to set_iterator_to_next. Fixes cursor
1774 motion in bidi-reordered lines with stretch glyphs and strings
1775 displayed in margins. (Bug#8133) (Bug#8867)
1776 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
1777 TO_CHARPOS.
640c8776
SM
1778 (pos_visible_p): Support positions in bidi-reordered lines.
1779 Save and restore bidi cache.
0bb23927
EZ
1780
1781 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
1782 (bidi_paragraph_info): Delete unused struct.
1783 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
1784 (bidi_cache_start): New variable.
1785 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
1786 to zero.
1787 (bidi_cache_fetch_state, bidi_cache_search)
1788 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1789 (bidi_cache_find, bidi_peek_at_next_level)
1790 (bidi_level_of_next_char, bidi_find_other_level_edge)
1791 (bidi_move_to_visually_next): Compare cache index with
1792 bidi_cache_start rather than with zero.
1793 (bidi_fetch_char): Accept new argument STRING; all callers
1794 changed. Support iteration over a string. Support strings with
1795 display properties. Support unibyte strings. Fix the type of
1796 `len' according to what STRING_CHAR_AND_LENGTH expects.
1797 (bidi_paragraph_init, bidi_resolve_explicit_1)
1798 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
1799 (bidi_level_of_next_char, bidi_move_to_visually_next):
1800 Support iteration over a string.
0bb23927
EZ
1801 (bidi_set_sor_type, bidi_resolve_explicit_1)
1802 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
1803 can now be zero (for strings); special values 0 and -1 were
1804 changed to -1 and -2, respectively.
1805 (bidi_char_at_pos): New function.
1806 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
1807 Call it instead of FETCH_MULTIBYTE_CHAR.
1808 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
1809 initialized to valid values.
1810 (bidi_init_it): Don't initialize charpos and bytepos with invalid
1811 values.
1812 (bidi_level_of_next_char): Allow the sentinel "position" to pass
1813 the test for valid cached positions. Fix the logic for looking up
1814 the sentinel state in the cache. GCPRO the Lisp string we are
1815 iterating.
1816 (bidi_push_it, bidi_pop_it): New functions.
1817 (bidi_initialize): Initialize the bidi cache start stack pointer.
1818 (bidi_cache_ensure_space): New function, refactored from part of
1819 bidi_cache_iterator_state. Don't assume the required size is just
1820 one BIDI_CACHE_CHUNK away.
1821 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
1822 (bidi_count_bytes, bidi_char_at_pos): New functions.
1823 (bidi_cache_search): Don't assume bidi_cache_last_idx is
1824 always valid if bidi_cache_idx is valid.
1825 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
1826 is valid if it's going to be used.
1827 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
1828 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
1829 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1830 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
1831 (bidi_find_other_level_edge, bidi_cache_start_stack):
1832 All variables related to cache indices are now EMACS_INT.
c965adc5 1833
0bb23927
EZ
1834 * dispextern.h (struct bidi_string_data): New structure.
1835 (struct bidi_it): New member `string'. Make flag members be 1-bit
1836 fields, and put them last in the struct.
640c8776
SM
1837 (compute_display_string_pos, compute_display_string_end):
1838 Update prototypes.
0bb23927
EZ
1839 (bidi_push_it, bidi_pop_it): Add prototypes.
1840 (struct iterator_stack_entry): New members bidi_p,
1841 paragraph_embedding, and from_disp_prop_p.
1842 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
1843 (bidi_shelve_cache, bidi_unshelve_cache):
1844 Declare prototypes.
0bb23927
EZ
1845
1846 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
1847 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1848 and vector-like objects.
1849
1850 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1851 cache around display iteration.
1852
1853 * window.c (Fwindow_end, window_scroll_pixel_based)
1854 (displayed_window_lines, Frecenter): Save and restore the bidi
1855 cache around display iteration.
1856
3bbd2265
LMI
18572011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1858
1859 * editfns.c (Fdelete_region): Clarify the use of the named
1860 parameters (bug#6788).
1861
adc47434
MR
18622011-07-14 Martin Rudalics <rudalics@gmx.at>
1863
1864 * indent.c (Fvertical_motion): Set and restore w->pointm when
1865 saving and restoring the window's buffer (Bug#9006).
1866
837c31f8
LMI
18672011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1868
1869 * editfns.c (Fstring_to_char): Clarify just what is returned
1870 (bug#6576). Text by Eli Zaretskii.
1871
ac389d0c
JB
18722011-07-13 Juanma Barranquero <lekktu@gmail.com>
1873
1874 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1875
0be0ce47
EZ
18762011-07-13 Eli Zaretskii <eliz@gnu.org>
1877
1878 * buffer.c (mmap_find): Fix a typo.
1879
cd18e7e3
JB
18802011-07-13 Johan Bockgård <bojohan@gnu.org>
1881
1882 Fix execution of x selection hooks.
1883 * xselect.c (Qx_lost_selection_functions)
1884 (Qx_sent_selection_functions): New vars.
1885 (syms_of_xselect): DEFSYM them.
1886 (x_handle_selection_request): Pass Qx_sent_selection_functions
1887 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1888 (x_handle_selection_clear,x_clear_frame_selections):
1889 Pass Qx_lost_selection_functions rather than
1890 Vx_lost_selection_functions to Frun_hook_with_args.
1891
47ea7f44
PE
18922011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1893
ac389d0c 1894 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
1895 The old code sometimes used this field without initializing it.
1896
47ea7f44
PE
1897 * alloc.c (gc_sweep): Don't read past end of array.
1898 In theory, the old code could also have corrupted Emacs internals,
1899 though it'd be very unlikely.
1900
bc985c87
AS
19012011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1902
1903 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 1904 argument. (Bug#4026)
bc985c87 1905
0cf34688
LMI
19062011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1907
b3dadd76
LMI
1908 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
1909 key" (bug#4257).
1910
0cf34688
LMI
1911 * window.c (Fset_window_start): Doc fix (bug#4199).
1912 (Fset_window_hscroll): Ditto.
1913
270768cd
PE
19142011-07-12 Paul Eggert <eggert@cs.ucla.edu>
1915
077e3dda 1916 Fix minor new problems caught by GCC 4.6.1.
270768cd 1917 * term.c (init_tty): Remove unused local.
490011a6 1918 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 1919 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 1920 not used otherwise.
270768cd 1921
b1f58454
CY
19222011-07-12 Chong Yidong <cyd@stupidchicken.com>
1923
1924 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
1925
22b9578d
LMI
19262011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1927
6e70ab07
LMI
1928 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
1929 are the mini-buffer and the echo area (bug#3320).
1930
22b9578d
LMI
1931 * term.c (init_tty): Remove support for supdup, c10 and perq
1932 terminals, which are no longer supported (bug#1482).
1933
8974cc9f
JB
19342011-07-10 Johan Bockgård <bojohan@gnu.org>
1935
1936 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
1937
a560d974
JD
19382011-07-10 Jan Djärv <jan.h.d@swipnet.se>
1939
1940 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
1941 for non-popups (Bug#3642).
1942
1dae0f0a
AS
19432011-07-10 Andreas Schwab <schwab@linux-m68k.org>
1944
268c2c36 1945 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 1946 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
1947 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
1948 * cm.c (losecursor): Likewise.
1dae0f0a
AS
1949 * data.c (fmod): Likewise.
1950 * dispnew.c (swap_glyphs_in_rows): Likewise.
1951 * emacs.c (memory_warning_signal): Likewise.
1952 * floatfns.c (float_error): Likewise.
1953 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
1954 (otf_open, font_otf_capability, generate_otf_features)
1955 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
1956 Likewise.
1957 * image.c (pbm_read_file): Likewise.
1958 * indent.c (string_display_width): Likewise.
1959 * intervals.c (check_for_interval, search_for_interval)
1960 (inc_interval_count, count_intervals, root_interval)
1961 (adjust_intervals_for_insertion, make_new_interval): Likewise.
1962 * lread.c (defalias): Likewise.
268c2c36 1963 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
1964 * regex.c (set_image_of_range_1, set_image_of_range)
1965 (regex_grow_registers): Likewise.
1966 * sysdep.c (strerror): Likewise.
1967 * termcap.c (valid_filename_p, tprint, main): Likewise.
1968 * tparam.c (main): Likewise.
1969 * unexhp9k800.c (run_time_remap, save_data_space)
1970 (update_file_ptrs, read_header, write_header, calculate_checksum)
1971 (copy_file, copy_rest, display_header): Likewise.
1972 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
1973 Likewise.
1974 * xdisp.c (check_it): Likewise.
1975 * xfaces.c (register_color, unregister_color, unregister_colors):
1976 Likewise.
1977 * xfns.c (print_fontset_result): Likewise.
1978 * xrdb.c (member, fatal, main): Likewise.
1979
99033785
PE
19802011-07-10 Paul Eggert <eggert@cs.ucla.edu>
1981
1982 Fix minor problems found by static checking (Bug#9031).
1983 * chartab.c (char_table_set_range, map_sub_char_table):
1984 Remove unused locals.
1985 (uniprop_table): Now static.
1986 * composite.c (_work_char): Remove unused static var.
1987
9cb2ac56
JB
19882011-07-09 Juanma Barranquero <lekktu@gmail.com>
1989
1990 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
1991
f25661f0
JD
19922011-07-09 Jan Djärv <jan.h.d@swipnet.se>
1993
1994 * gtkutil.c (qttip_cb): Remove code without function.
1995
8278c4fe
EZ
19962011-07-09 Eli Zaretskii <eliz@gnu.org>
1997
1998 * w32.c (pthread_sigmask): New stub.
1999
1692ae2d 20002011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 2001
8a6ebd58 2002 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
2003 sigprocmask is portable only for single-threaded applications, and
2004 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
2005 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2006 (LIBES): Use it.
2007 * callproc.c (Fcall_process):
2008 * process.c (create_process):
2009 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2010 Use pthread_sigmask, not sigprocmask.
123403e4 2011
1b854618
JD
20122011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2013
2014 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2015 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2016 wrong (Bug#8591).
2017
3fe4b549
JD
20182011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2019
0ce7e563
JD
2020 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2021 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2022 (xg_hide_tooltip): Fix comment.
2023
3fe4b549
JD
2024 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2025 in registerServicesMenuSendTypes.
2026 (validRequestorForSendType): Don't check ns_return_types.
2027
2028 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2029 ns_return_type.
2030
5df75e47
JR
20312011-07-08 Jason Rumney <jasonr@gnu.org>
2032
2033 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2034 frame struct members of non-existent frames (Bug#6284).
2035
699c10bd
JD
20362011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2037
4393663b
JD
2038 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2039 variable firstTime not needed on OSX >= 10.6.
2040 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2041 >= 10.5. Use setKnobProportion, setDoubleValue.
2042
2043 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2044 (MAC_OS_X_VERSION_10_5): Define if not defined.
2045 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2046 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2047 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2048
2049 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2050 cString and lossyCString on OSX >= 10.4
2051
2052 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2053 sizeToFit on OSX >= 10.2.
2054
2055 * nsimage.m (allocInitFromFile): Don't use deprecated method
2056 bestRepresentationForDevice on OSX >= 10.6.
2057
2058 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2059 to avoid warning.
2060
2061 * emacs.c: Declare unexec_init_emacs_zone.
2062
a63e0781
JD
2063 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2064
699c10bd
JD
2065 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2066
2067 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2068 on svcsMenu (Bug#8842).
2069
2070 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2071 ns_return_types.
2072 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2073
2074 * nsterm.m (QUTF8_STRING): Declare.
2075 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2076 (validRequestorForSendType): Return type is (id).
2077 Change indexOfObjectIdenticalTo to indexOfObject.
2078 Check if we have local selection before returning self (Bug#8842).
2079 (writeSelectionToPasteboard): Put local selection into paste board
2080 if we have a local selection (Bug#8842).
2081 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2082
2083 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2084 (ns_get_local_selection): Declare.
2085
54e10184
LMI
20862011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2087
9888ff71
LMI
2088 * keymap.c (describe_map_tree): Don't insert a double newline at
2089 the end of the buffer (bug#1169) and return whether we inserted
2090 something.
2091
54e10184
LMI
2092 * callint.c (Fcall_interactively): Change "reading args" to
2093 "providing args" to try to clarify what it does (bug#1010).
2094
15fa4783
KH
20952011-07-07 Kenichi Handa <handa@m17n.org>
2096
2097 * composite.c (composition_compute_stop_pos): Ignore a static
2098 composition starting before CHARPOS (Bug#8915).
2099
2100 * xdisp.c (handle_composition_prop): Likewise.
2101
a8815b00
EZ
21022011-07-07 Eli Zaretskii <eliz@gnu.org>
2103
2104 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2105 (Bug#9015)
2106
ef7b981d 21072011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
2108
2109 * character.h (unicode_category_t): New enum type.
2110
2111 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2112 (Qchar_code_property_table): New variable.
2113 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2114 (UNIPROP_COMPRESSED_FORM_P): New macros.
2115 (char_table_ascii): Uncompress the compressed values.
2116 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2117 Uncompress the compressed values.
ac389d0c 2118 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
2119 (char_table_ref_and_range): Uncompress the compressed values.
2120 (sub_char_table_set): New arg is_uniprop. Callers changed.
2121 Uncompress the compressed values.
2122 (sub_char_table_set_range): Args changed. Callers changed.
2123 (char_table_set_range): Adjuted for the above change.
2124 (map_sub_char_table): Delete args default_val and parent. Add arg
2125 top. Give decoded values to a Lisp function.
640c8776 2126 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
2127 values to a Lisp function. Gcpro more variables.
2128 (uniprop_table_uncompress)
2129 (uniprop_decode_value_run_length): New functions.
2130 (uniprop_decoder, uniprop_decoder_count): New variables.
2131 (uniprop_get_decoder, uniprop_encode_value_character)
2132 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2133 New functions.
2134 (uniprop_encoder, uniprop_encoder_count): New variables.
2135 (uniprop_get_encoder, uniprop_table)
2136 (Funicode_property_table_internal, Fget_unicode_property_internal)
2137 (Fput_unicode_property_internal): New functions.
2138 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2139 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 2140 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
2141 char-code-property-alist.
2142
640c8776 2143 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
2144 Vunicode_category_table.
2145
640c8776 2146 * font.c (font_range): Adjust for the change of
c805dec0
KH
2147 Vunicode_category_table.
2148
76b397fb
DN
21492011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2150
2151 * m/iris4d.h: Remove file, move contents ...
2152 * s/irix6-5.h: ... here.
2153
22b4128e
PE
21542011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2155
2156 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
2157 * alloc.c (mark_buffer):
2158 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2159 (clone_per_buffer_values): Don't assume that
22b4128e
PE
2160 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2161 This isn't true in general, and it's particularly not true
2162 if Emacs is configured with --with-wide-int.
2163 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2164 New macros, used in the buffer.c change.
2165
869795d6
JD
21662011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2167
2168 * xsettings.c: Use both GConf and GSettings if both are available.
2169 (store_config_changed_event): Add comment.
2170 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2171 (store_tool_bar_style_changed): New functions.
5e617bc2 2172 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
2173 (struct xsettings): Move font inside HAVE_XFT.
2174 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 2175 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 2176 Move inside HAVE_XFT.
640c8776 2177 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
2178 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2179 also.
2180 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 2181 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 2182 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
2183 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2184 (parse_settings): Move check for font inside HAVE_XFT.
2185 (read_settings, apply_xft_settings): Add comment.
2186 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2187 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2188 call store_font_name_changed.
2189 (xft_settings_event): Add comment.
2190 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2191 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2192 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2193 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2194 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
2195 (xsettings_get_system_font, xsettings_get_system_normal_font):
2196 Add comment.
869795d6 2197
d8ed26bd
PE
21982011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2199
2200 Random fixes. E.g., (random) never returned negative values.
2201 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2202 subseconds part to the entropy, as that's a bit more random.
2203 Prefer signed to unsigned, since the signedness doesn't matter and
2204 in general we prefer signed. When given a limit, use a
2205 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2206 latter isn't right if USE_2_TAGS_FOR_INTS.
2207 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2208 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2209
cabf1cac
SM
22102011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2211
2212 * textprop.c (text_property_stickiness):
2213 Obey Vtext_property_default_nonsticky.
2214 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2215 * w32fns.c (syms_of_w32fns):
2216 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2217
6e9b2be9
PE
22182011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2219
2220 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2221 This is more efficient than Ffile_directory_p and avoids a minor race.
2222
90186c68
LMI
22232011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2224
7c301272
LMI
2225 * buffer.c (Foverlay_put): Say what the return value is
2226 (bug#7835).
2227
c4f2d8d4
LMI
2228 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2229 is a directory before asking whether to use the file name
2230 (bug#7564).
ad637907
LMI
2231 (barf_or_query_if_file_exists): Make the "File is a directory"
2232 error be more correct.
c4f2d8d4 2233
90186c68
LMI
2234 * fns.c (Frequire): Remove the mention of the .gz files, since
2235 that's installation-specific, but keep the mention of
2236 `get-load-suffixes'.
2237
da64016e
PE
22382011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2239
2240 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2241 Report string overflow if the output is too long.
2242
7d47b580
JB
22432011-07-04 Juanma Barranquero <lekktu@gmail.com>
2244
a555cb87
JB
2245 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2246 (syms_of_gnutls): Remove duplicate DEFSYM for
2247 Qgnutls_bootprop_verify_hostname_error, an error for
2248 Qgnutls_bootprop_verify_error (which is no longer used).
2249
7d47b580
JB
2250 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2251 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2252 Also (re)move comments that are misplaced or no longer relevant.
2253
1e49bfab
LMI
22542011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2255
2256 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2257
1485f4c0
CY
22582011-07-03 Chong Yidong <cyd@stupidchicken.com>
2259
2260 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2261 and background color parameters if they have been changed.
2262
a9ab721e
LMI
22632011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2264
2265 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2266
cf7cff57
PE
22672011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2268
2e13213d
PE
2269 * xsettings.c (SYSTEM_FONT): Define only when used.
2270 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2271
cf7cff57
PE
2272 * keymap.c (access_keymap_1): Now static.
2273
7a8e04f7
CY
22742011-07-02 Chong Yidong <cyd@stupidchicken.com>
2275
2276 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2277 leave any prefix arg for the up event (Bug#1586).
2278
61352f62
LMI
22792011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2280
69bb1ef7
LMI
2281 * lread.c (syms_of_lread): Mention single symbols defined by
2282 `defvar' or `defconst' (bug#7154).
2283
61352f62 2284 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 2285 (Frequire): Mention get-load-suffixes.
61352f62 2286
28545e04
MR
22872011-07-02 Martin Rudalics <rudalics@gmx.at>
2288
2289 * window.h (window): Remove clone_number slot.
2290 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2291 Remove.
2292 (make_parent_window, make_window, saved_window)
2293 (Fset_window_configuration, save_window_save): Don't deal with
2294 clone numbers.
2295 * buffer.c (Qclone_number): Remove declaration.
2296 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2297
3349e122
SM
22982011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2299
2300 Add multiple inheritance to keymaps.
2301 * keymap.c (Fmake_composed_keymap): New function.
2302 (Fset_keymap_parent): Simplify.
2303 (fix_submap_inheritance): Remove.
2304 (access_keymap_1): New function extracted from access_keymap to handle
2305 embedded parents and handle lists of maps.
2306 (access_keymap): Use it.
2307 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2308 (Fcopy_keymap): Handle embedded parents.
2309 (Fcommand_remapping, define_as_prefix): Simplify.
2310 (Fkey_binding): Simplify.
2311 (syms_of_keymap): Move minibuffer-local-completion-map,
2312 minibuffer-local-filename-completion-map,
2313 minibuffer-local-must-match-map, and
2314 minibuffer-local-filename-must-match-map to Elisp.
2315 (syms_of_keymap): Defsubr make-composed-keymap.
2316 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2317 (parse_menu_item): Trivial simplification.
2318
3279eb87
GM
23192011-07-01 Glenn Morris <rgm@gnu.org>
2320
2321 * Makefile.in (SETTINGS_LIBS): Fix typo.
2322
4550efdf
KI
23232011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2324
2325 * coding.c (Fencode_coding_string): Record the last coding system
2326 used, as the function doc string says (bug#8738).
2327
0949d2b6
JD
23282011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2329
2330 * xsettings.c (store_monospaced_changed): Take new font as arg and
2331 check for change against current_mono_font.
2332 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2333 (emacs_settings_constructor, emacs_settings_get_property)
2334 (emacs_settings_set_property, emacs_settings_class_init)
2335 (emacs_settings_init, gsettings_obj): Remove.
2336 (something_changedCB): New function for HAVE_GSETTINGS.
2337 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2338 with value as argument.
2339 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2340 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 2341 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
2342 "changed".
2343
2344 * xgselect.c: Add defined (HAVE_GSETTINGS).
2345 (xgselect_initialize): Ditto.
2346
2347 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2348 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2349 xg_select.
2350
bbc6b304
PE
23512011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2352
2353 * eval.c (struct backtrace): Simplify and port the data structure.
2354 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2355 signed bit field, as this assumption is not portable and it makes
2356 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2357 "char debug_on_exit : 1" as this is not portable either; instead,
2358 use the portable "unsigned int debug_on_exit : 1". Remove unused
2359 member evalargs. Remove obsolete comments about cc bombing out.
2360
9851bfc5
JD
23612011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2362
51bb811f 2363 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
2364 Let HAVE_GSETTINGS override HAVE_GCONF.
2365 (store_monospaced_changed): New function.
2366 (EMACS_SETTINGS): A new type derived from GObject to handle
2367 GSettings notifications.
2368 (emacs_settings_constructor, emacs_settings_get_property)
2369 (emacs_settings_set_property, emacs_settings_class_init):
2370 New functions.
2371 (gsettings_client, gsettings_obj): New variables.
2372 (GSETTINGS_SCHEMA): New define.
2373 (something_changedCB): Call store_monospaced_changed.
2374 (init_gsettings): New function.
2375 (xsettings_initialize): Call init_gsettings.
2376 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2377 to NULL.
2378
640c8776 2379 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
2380 GCONF_CFLAGS/LIBS.
2381
5386012d
MR
23822011-06-29 Martin Rudalics <rudalics@gmx.at>
2383
2384 * window.c (resize_root_window, grow_mini_window)
2385 (shrink_mini_window): Rename Qresize_root_window to
2386 Qwindow_resize_root_window and Qresize_root_window_vertically to
2387 Qwindow_resize_root_window_vertically.
2388
f13e0b08
PE
23892011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2390
2391 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2392
94515237
JB
23932011-06-27 Juanma Barranquero <lekktu@gmail.com>
2394
2395 * makefile.w32-in: Redesign dependencies so they reflect more
2396 clearly which files are directly included by each source file,
2397 and not through other includes.
2398
e43b6e43
MR
23992011-06-27 Martin Rudalics <rudalics@gmx.at>
2400
2401 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2402 (sort_overlays, overlay_strings): When an overlay's clone number
2403 matches the window's clone number process the overlay even if
2404 the overlay's window property doesn't match the current window.
2405
d68443dc
MR
2406 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2407 (Fwindow_hchild): Rename to Fwindow_left_child.
2408 (Fwindow_next): Rename to Fwindow_next_sibling.
2409 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
2410 (resize_window_check): Rename to window_resize_check.
2411 (resize_window_apply): Rename to window_resize_apply.
2412 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2413 (Fdelete_other_windows_internal, resize_frame_windows)
2414 (Fsplit_window_internal, Fdelete_window_internal)
2415 (grow_mini_window, shrink_mini_window)
2416 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 2417
c7e73be5
JD
24182011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2419
2420 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2421 (emacs_fixed_set_min_size): Remove.
2422 (emacs_fixed_new): Take frame as argument.
2423
2424 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2425 (_EmacsFixedPrivate): Remove minwidth/height.
2426 Add struct frame *f.
2427 (emacs_fixed_init): Initialize priv->f.
2428 (get_parent_class, emacs_fixed_set_min_size): Remove.
2429 (emacs_fixed_new): Set priv->f to argument.
2430 (emacs_fixed_get_preferred_width)
2431 (emacs_fixed_get_preferred_height): Use min_width/height from
2432 frames size_hint to set minimum and natural (Bug#8919).
2433 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2434 and use min_width/height from frames size_hint to set
2435 min_width/height (Bug#8919).
2436
2437 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
2438 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2439 Fix indentation.
c7e73be5 2440
cf99dcf8
EZ
24412011-06-26 Eli Zaretskii <eliz@gnu.org>
2442
2443 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2444 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2445 called at ZV.
2446
029529ac
CY
24472011-06-26 Chong Yidong <cyd@stupidchicken.com>
2448
2449 * process.c (wait_reading_process_output): Bypass select if
2450 waiting for a cell while ignoring keyboard input, and input is
2451 pending. Suggested by Jan Djärv (Bug#8869).
2452
7a7ef429
PE
24532011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2454
2455 Use gnulib's dup2 module instead of rolling our own.
2456 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2457
11fdef7d 24582011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
2459
2460 * dispnew.c (scrolling_window): Before scrolling, turn off a
2461 mouse-highlight in the window being scrolled.
2462
cd3520a4
JB
24632011-06-24 Juanma Barranquero <lekktu@gmail.com>
2464
2465 Move DEFSYM to lisp.h and use everywhere.
2466
2467 * character.h (DEFSYM): Move declaration...
2468 * lisp.h (DEFSYM): ...here.
2469
2470 * gnutls.c:
2471 * minibuf.c:
2472 * w32menu.c:
2473 * w32proc.c:
2474 * w32select.c: Don't include character.h.
2475
2476 * alloc.c (syms_of_alloc):
2477 * buffer.c (syms_of_buffer):
2478 * bytecode.c (syms_of_bytecode):
2479 * callint.c (syms_of_callint):
2480 * casefiddle.c (syms_of_casefiddle):
2481 * casetab.c (init_casetab_once):
2482 * category.c (init_category_once, syms_of_category):
2483 * ccl.c (syms_of_ccl):
2484 * cmds.c (syms_of_cmds):
2485 * composite.c (syms_of_composite):
2486 * dbusbind.c (syms_of_dbusbind):
2487 * dired.c (syms_of_dired):
2488 * dispnew.c (syms_of_display):
2489 * doc.c (syms_of_doc):
2490 * editfns.c (syms_of_editfns):
2491 * emacs.c (syms_of_emacs):
2492 * eval.c (syms_of_eval):
2493 * fileio.c (syms_of_fileio):
2494 * fns.c (syms_of_fns):
2495 * frame.c (syms_of_frame):
2496 * fringe.c (syms_of_fringe):
2497 * insdel.c (syms_of_insdel):
2498 * keymap.c (syms_of_keymap):
2499 * lread.c (init_obarray, syms_of_lread):
2500 * macros.c (syms_of_macros):
2501 * msdos.c (syms_of_msdos):
2502 * print.c (syms_of_print):
2503 * process.c (syms_of_process):
2504 * search.c (syms_of_search):
2505 * sound.c (syms_of_sound):
2506 * syntax.c (init_syntax_once, syms_of_syntax):
2507 * terminal.c (syms_of_terminal):
2508 * textprop.c (syms_of_textprop):
2509 * undo.c (syms_of_undo):
2510 * w32.c (globals_of_w32):
2511 * window.c (syms_of_window):
2512 * xdisp.c (syms_of_xdisp):
2513 * xfaces.c (syms_of_xfaces):
2514 * xfns.c (syms_of_xfns):
2515 * xmenu.c (syms_of_xmenu):
2516 * xsettings.c (syms_of_xsettings):
2517 * xterm.c (syms_of_xterm): Use DEFSYM.
2518
4228cf16
TZ
25192011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2520
cd3520a4 2521 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 2522
7fcccf1e
PE
25232011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2524
7efb4e0e
PE
2525 Integer and buffer overflow fixes (Bug#8873).
2526
ff5844ad
PE
2527 * print.c (printchar, strout): Check for string overflow.
2528 (PRINTPREPARE, printchar, strout):
2529 Don't set size unless allocation succeeds.
2530
90532f02
PE
2531 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2532 for sizes. Check for string overflow more accurately.
2533 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2534
6d84508d
PE
2535 * macros.c: Integer and buffer overflow fixes.
2536 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2537 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2538 Use ptrdiff_t, not int, for sizes.
2539 Don't increment bufsize until after realloc succeeds.
2540 Check for size-calculation overflow.
2541 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2542
437b2cb4
PE
2543 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2544
8b9ac8b4
PE
2545 * lread.c: Integer overflow fixes.
2546 (read_integer): Radix is now EMACS_INT, not int,
2547 to improve quality of diagnostics for out-of-range radices.
2548 Calculate buffer size correctly for out-of-range radices.
2549 (read1): Check for integer overflow in radices, and in
2550 read-circle numbers.
82cb60d3
PE
2551 (read_escape): Avoid int overflow.
2552 (Fload, openp, read_buffer_size, read1)
2553 (substitute_object_recurse, read_vector, read_list, map_obarray):
2554 Use ptrdiff_t, not int, for sizes.
2555 (read1): Use EMACS_INT, not int, for sizes.
20270765 2556 Check for size overflow.
8b9ac8b4 2557
7fcccf1e
PE
2558 * image.c (cache_image): Check for size arithmetic overflow.
2559
bfbbd7e7
PE
2560 * lread.c: Integer overflow issues.
2561 (saved_doc_string_size, saved_doc_string_length)
2562 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2563 Now ptrdiff_t, not int.
2564 (read1): Don't assume doc string length fits in int. Check for
2565 out-of-range doc string lengths.
2566 (read_list): Don't assume file position fits in int.
39019e54 2567 (read_escape): Check for hex character overflow.
bfbbd7e7 2568
4e323265
LL
25692011-06-22 Leo Liu <sdl.web@gmail.com>
2570
2571 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2572 Move to minibuffer.el.
2573
85fece3e
PE
25742011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2575
20b84ce9 2576 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
2577 The following patches are for when GLYPH_DEBUG && !XASSERT.
2578 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2579 * dispnew.c (flush_stdout):
2580 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2581 Mark as externally visible.
2582 * dispnew.c (check_window_matrix_pointers): Now static.
2583 * dispnew.c (window_to_frame_vpos):
2584 * xfns.c (unwind_create_frame):
2585 * xterm.c (x_check_font): Remove unused local.
2586 * scroll.c (CHECK_BOUNDS):
2587 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2588 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2589 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2590 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2591 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2592 Now static.
2593 (debug_method_add): Use va_list and vsprintf rather than relying
2594 on undefined behavior with wrong number of arguments.
2595 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2596 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2597 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2598 since we're not interested in debugging glyphs with old libraries.
2599 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2600 GCC 4.6.0's static checking.
2601
0766b489
PE
26022011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2603
31fd4b32
PE
2604 Integer overflow and signedness fixes (Bug#8873).
2605 A few related buffer overrun fixes, too.
2606
b79e8648
PE
2607 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2608
0766b489
PE
2609 * dispextern.h (struct face.stipple):
2610 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2611 (x_bitmap_mask, x_allocate_bitmap_record)
2612 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2613 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2614 (x_create_bitmap_from_xpm_data):
2615 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2616 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2617 (.bitmaps_last):
2618 * xfaces.c (load_pixmap):
2619 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2620 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2621 (.bitmaps_last, struct x_output.icon_bitmap):
2622 Use ptrdiff_t, not int, for bitmap indexes.
2623 (x_allocate_bitmap_record): Check for size overflow.
2624 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2625
b081724f
PE
2626 Use ptrdiff_t, not int, for overlay counts.
2627 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2628 * editfns.c (overlays_around, get_pos_property):
2629 * textprop.c (get_char_property_and_overlay):
2630 * xdisp.c (next_overlay_change, note_mouse_highlight):
2631 * xfaces.c (face_at_buffer_position):
21514da7
PE
2632 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2633 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2634 (Fnext_overlay_change, Fprevious_overlay_change)
2635 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 2636 Use ptrdiff_t, not int, for sizes.
21514da7 2637 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 2638
3de73e5e
PE
2639 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2640
2606c57b
PE
2641 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2642 (x_session_initialize): Do not assume string length fits in int.
2643
aaafe47a
PE
2644 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2645 This is unlikely, but can occur if DPI is outlandish.
2646
2674ddc8 2647 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
2648 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2649
28154962
PE
2650 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2651 * xrdb.c (magic_file_p, search_magic_path):
2652 Omit last arg SUFFIX; it was always 0. All callers changed.
2653 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2654
7de51af5
PE
2655 * xfont.c (xfont_match): Avoid need for strlen.
2656
25ed6cc3
PE
2657 * xfns.c: Don't assume strlen fits in int.
2658 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2659
4eab31dd
PE
2660 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2661 not unsigned long, as we prefer signed integers. All callers changed.
2662 Detect integer overflow in repeat count.
2663 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 2664 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 2665
171e2a58
PE
2666 * termcap.c: Don't assume sizes fit in int and never overflow.
2667 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2668 (gobble_line): Check for size-calculation overflow.
2669
ad39faca 2670 * minibuf.c (Fread_buffer):
6e5bb2dc 2671 * lread.c (intern, intern_c_string):
74ca2eb3
PE
2672 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2673 Don't assume string length fits in int.
2674
52c61c22 2675 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
2676 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2677
b5b8c9e5
PE
2678 * font.c: Don't assume string length fits in int.
2679 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2680 Use ptrdiff_t, not int.
ccd6111c
PE
2681 (font_intern_prop): Don't assume string length fits in int.
2682 Don't assume integer property fits in fixnum.
2683 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 2684
882f0d81 2685 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 2686 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
2687 Reformulate so as not to need the command string.
2688 Invoke gzip -cd rather than gunzip, as it's more portable.
2689 (lock_info_type, lock_file_1, lock_file):
2690 Don't assume pid_t and time_t fit in unsigned long.
2691 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
2692 (current_lock_owner): Prefer signed type for sizes.
2693 Use memcpy, not strncpy, where memcpy is what is really wanted.
2694 Don't assume (via atoi) that time_t and pid_t fit in int.
2695 Check for time_t and/or pid_t out of range, e.g., via a network share.
2696 Don't alloca where an auto var works fine.
2697
93f4cf88
PE
2698 * fileio.c: Fix some integer overflow issues.
2699 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
2700 Don't assume string length fits in int.
2701 (directory_file_name): Don't assume string length fits in long.
2702 (make_temp_name): Don't assume pid fits in int, or that its print
2703 length is less than 20.
2704
f3e92b69
PE
2705 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
2706
1bfdaf10
PE
2707 * coding.c (make_subsidiaries): Don't assume string length fits in int.
2708
35016e9a
PE
2709 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
2710
3d1e65a1
PE
2711 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
2712 We prefer signed integers, even for size calculations.
2713
0b963a93
PE
2714 * emacs.c: Don't assume string length fits in 'int'.
2715 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
2716 (main): Don't invoke strlen when not needed.
2717
573f4b54
PE
2718 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
2719 (XD_DEBUG_MESSAGE): Don't waste a byte.
2720
989f33ba
PE
2721 * callproc.c (getenv_internal_1, getenv_internal)
2722 (Fgetenv_internal):
965d34eb
PE
2723 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
2724
e4d29b33
PE
2725 * lread.c (invalid_syntax): Omit length argument.
2726 All uses changed. This doesn't fix a bug, but it simplifies the
2727 code away from its former Hollerith-constant appearance, and it's
2728 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 2729 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 2730
eb49b136
PE
2731 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
2732 This didn't break anything, but it didn't help either.
2733 It's confusing to put a bogus integer in a place where the actual
2734 value does not matter.
9f62aeb1 2735 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 2736 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 2737
15375a22
PE
2738 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
2739 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
2740 implementation.
b61cc01c
PE
2741 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
2742 We prefer signed types, and the value cannot exceed the EMACS_INT
2743 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
2744 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
2745 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
2746 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 2747
53b2623d
PE
2748 * indent.c (sane_tab_width): New function.
2749 (current_column, scan_for_column, Findent_to, position_indentation)
2750 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 2751 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 2752
51cab52b 2753 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 2754
f2ed8a70
PE
2755 * lisp.h (lint_assume): New macro.
2756 * composite.c (composition_gstring_put_cache):
2757 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
2758
abe80cc6
PE
2759 * editfns.c, insdel.c:
2760 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 2761
b02c740e
PE
2762 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
2763
ebc96716
PE
2764 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
2765
b4e50fa0 2766 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 2767 Use much-faster test for byte-length change.
311d5d7c 2768 Don't assume string byte-length fits in 'int'.
a4cf38e4 2769 Check that character arg fits in 'int'.
85461888 2770 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 2771
c0c1ee9f
PE
2772 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
2773
a498d7f4
PE
2774 * fns.c (concat): Catch string overflow earlier.
2775 Do not rely on integer wraparound.
2776
51cab52b
PE
2777 * dispextern.h (struct it.overlay_strings_charpos)
2778 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
2779 * xdisp.c (forward_to_next_line_start)
2780 (back_to_previous_visible_line_start)
2781 (reseat_at_next_visible_line_start, next_element_from_buffer):
2782 Don't arbitrarily truncate the value of 'selective' to int.
2783
76031fad
PE
2784 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
2785
5eb55db9
PE
2786 * composite.c: Don't truncate sizes to 'int'.
2787 (composition_gstring_p, composition_reseat_it)
2788 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
2789 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
2790 not EMACS_UINT, for indexes.
5eb55db9 2791
0703a717
PE
2792 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
2793
d6202519
PE
2794 * buffer.c: Include <verify.h>.
2795 (struct sortvec.priority, struct sortstr.priority):
8961a454 2796 Now EMACS_INT, not int.
c20998a7 2797 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
2798 (struct sortstr.size, record_overlay_string)
2799 (struct sortstrlist.size, struct sortlist.used):
2800 Don't truncate size to int.
2801 (record_overlay_string): Check for size-calculation overflow.
d6202519 2802 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 2803
d5a19415
JM
28042011-06-22 Jim Meyering <meyering@redhat.com>
2805
029529ac 2806 Don't leak an XBM-image-sized buffer
d5a19415
JM
2807 * image.c (xbm_load): Free the image buffer after using it.
2808
a9041e6c
PE
28092011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2810
2811 Port to Sun C.
2812 * composite.c (find_automatic_composition): Omit needless 'return 0;'
2813 that Sun C diagnosed.
2814 * fns.c (secure_hash): Fix pointer signedness issue.
2815 * intervals.c (static_offset_intervals): New function.
2816 (offset_intervals): Use it.
2817
7f3f739f
LL
28182011-06-21 Leo Liu <sdl.web@gmail.com>
2819
2820 * deps.mk (fns.o):
2821 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
2822 sha512.h.
2823
2824 * fns.c (secure_hash): Rename from crypto_hash_function and change
2825 the first arg to accept symbols.
5b66d427 2826 (Fsecure_hash): New primitive.
7f3f739f
LL
2827 (syms_of_fns): New symbols.
2828
76147d94
DD
28292011-06-20 Deniz Dogan <deniz@dogan.se>
2830
2831 * process.c (Fset_process_buffer): Clarify return value in
2832 docstring.
2833
7d7d0045
CY
28342011-06-18 Chong Yidong <cyd@stupidchicken.com>
2835
2836 * dispnew.c (add_window_display_history): Use BVAR.
2837
2838 * xdisp.c (debug_method_add): Use BVAR.
2839 (check_window_end, dump_glyph_matrix, dump_glyph)
2840 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
2841
2842 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
2843 Likewise.
2844
2845 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
2846 check till after the cache is created in init_frame_faces.
2847
ff2bc410
SM
28482011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2849
2850 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2851
28177add
PE
28522011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2853
dd3482fe
PE
2854 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2855 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2856 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2857
393d71f3 2858 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
2859 * fileio.c (Finsert_file_contents):
2860 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2861 Remove the old (too-loose) buffer overflow checks.
2862 They weren't needed, since make_gap checks for buffer overflow.
2863 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2864 The old code merely checked for Emacs fixnum overflow, and relied
2865 on undefined (wraparound) behavior. The new code avoids undefined
2866 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2867
2e6813b0 2868 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
2869 Tune. Don't use wider integers than needed. Don't use alloca.
2870 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 2871
599a9e4f
PE
2872 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2873
99561444
PE
2874 * insdel.c, lisp.h (buffer_overflow): New function.
2875 (insert_from_buffer_1, replace_range, replace_range_2):
2876 * insdel.c (make_gap_larger):
2877 * editfns.c (Finsert_char):
2878 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2879
28177add
PE
2880 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2881
e69dafad
PE
28822011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2883
a7af7fde 2884 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 2885
b1c46f02
PE
2886 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2887 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2888
e69dafad
PE
2889 * fileio.c: Don't assume EMACS_INT fits in off_t.
2890 (emacs_lseek): New static function.
2891 (Finsert_file_contents, Fwrite_region): Use it.
2892 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2893
566684ea
PE
2894 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2895
e6966cd6
PE
2896 * fns.c: Don't overflow int when computing a list length.
2897 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2898 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2899 truncation on 64-bit hosts. Check for QUIT every
2900 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2901 faster and is responsive enough.
2902 (Flength): Report an error instead of overflowing an integer.
2903 (Fsafe_length): Return a float if the value is not representable
2904 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 2905 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 2906 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 2907
dd0b0efb
PE
2908 * alloc.c: Check that resized vectors' lengths fit in fixnums.
2909 (header_size, word_size): New constants.
2910 (allocate_vectorlike): Don't check size overflow here.
2911 (allocate_vector): Check it here instead, since this is the only
2912 caller of allocate_vectorlike that could cause overflow.
2913 Check that the new vector's length is representable as a fixnum.
2914
86fe5cfe
PE
2915 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
2916 The previous code was bogus. For example, next_almost_prime (32)
2917 returned 39, which is undesirable as it is a multiple of 3; and
2918 next_almost_prime (24) returned 25, which is a multiple of 5 so
2919 why was the code bothering to check for multiples of 7?
2920
80e88859
PE
2921 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
2922
4a2f0ad6
PE
2923 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
2924
f66c7cf8
PE
2925 Variadic C functions now count arguments with ptrdiff_t.
2926 This partly undoes my 2011-03-30 change, which replaced int with size_t.
2927 Back then I didn't know that the Emacs coding style prefers signed int.
2928 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
2929 were being counted with int, which may truncate counts on 64-bit
2930 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
2931 * lisp.h (struct Lisp_Subr.function.aMANY)
2932 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
2933 Arg counts are now ptrdiff_t, not size_t.
2934 All variadic functions and their callers changed accordingly.
2935 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
2936 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
2937 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
2938 * callint.c (Fcall_interactively): Check arg count for overflow,
2939 to avoid potential buffer overrun. Use signed char, not 'int',
2940 for 'varies' array, so that we needn't bother to check its size
2941 calculation for overflow.
2942 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
2943 * eval.c (apply_lambda):
2944 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
2945 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
2946 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
2947
a1759b76
PE
2948 * callint.c (Fcall_interactively): Don't use index var as event count.
2949
d96be9fc
PE
2950 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
2951 * mem-limits.h (SIZE): Remove; no longer used.
2952
a690a978 2953 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 2954
578c21e6
PE
2955 Remove unnecessary casts.
2956 * xterm.c (x_term_init):
2957 * xfns.c (x_set_border_pixel):
2958 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
2959 These aren't needed now that we assume ANSI C.
2960
96f53c6c
PE
2961 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
2962 It's more likely to cause problems (due to unsigned overflow)
2963 than to cure them.
2964
83c77d31
PE
2965 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
2966
ee2079f1
PE
2967 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
2968
6da65536
PE
2969 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
2970
7147c4a4
PE
2971 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
2972
193e32d9
PE
2973 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
2974
e5533da6
PE
2975 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
2976
9910e595
PE
2977 GLYPH_CODE_FACE returns EMACS_INT, not int.
2978 * dispextern.h (merge_faces):
2979 * xfaces.c (merge_faces):
01103c44
PE
2980 * xdisp.c (get_next_display_element, next_element_from_display_vector):
2981 Don't assume EMACS_INT fits in int.
9910e595 2982
2638320e
PE
2983 * character.h (CHAR_VALID_P): Remove unused parameter.
2984 * fontset.c, lisp.h, xdisp.c: All uses changed.
2985
045eb8d9
PE
2986 * editfns.c (Ftranslate_region_internal): Omit redundant test.
2987
c1f134b5
PE
2988 * fns.c (concat): Minor tuning based on overflow analysis.
2989 This doesn't fix any bugs. Use int to hold character, instead
2990 of constantly refetching from Emacs object. Use XFASTINT, not
2991 XINT, for value known to be a character. Don't bother comparing
2992 a single byte to 0400, as it's always less.
2993
395fcb93 2994 * floatfns.c (Fexpt):
327eeec8
PE
2995 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
2996
abbd3d23
PE
2997 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
2998 for characters.
2999
684a03ef
PE
3000 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3001
0fed43f3
PE
3002 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3003 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3004 incorrectly succeed when S was a string, because 4294967386 was
3005 truncated before it was used.
3006
8fd02eb7
PE
3007 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3008 Otherwise, an out-of-range integer could cause undefined behavior
3009 on a 64-bit host.
3010
f8c86b69
PE
3011 * composite.c: Use int, not EMACS_INT, for characters.
3012 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3013 EMACS_INT, for values that are known to be in character range.
3014 This doesn't fix any bugs but is the usual style inside Emacs and
3015 may generate better code on 32-bit machines.
3016
34206dd2
PE
3017 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3018 This is for reasons similar to the recent CHAR_STRING fix.
3019 * charset.c (Fencode_char): Check that character arg is actually
3020 a character. Pass an int to ENCODE_CHAR.
3021 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3022 wider than 'int', as a compile-time check to prevent future regressions
3023 in this area.
3024
c5958d4c 3025 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
3026
3027 Make sure a 64-bit char is never passed to CHAR_STRING.
3028 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3029 by silently ignoring the top 32 bits, allowing some values
3030 that were far too large to be valid characters.
3031 * character.h: Include <verify.h>.
3032 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3033 arguments are no wider than unsigned, as a compile-time check
3034 to prevent future regressions in this area.
3035 * data.c (Faset):
01103c44 3036 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
3037 (Fsubst_char_in_region):
3038 * fns.c (concat):
3039 * xdisp.c (decode_mode_spec_coding):
3040 Adjust to CHAR_STRING's new requirement.
3041 * editfns.c (Finsert_char, Fsubst_char_in_region):
3042 * fns.c (concat): Check that character args are actually
3043 characters. Without this test, these functions did the wrong
3044 thing with wildly out-of-range values on 64-bit hosts.
3045
d37ca623
PE
3046 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3047 These casts should not be needed on 32-bit hosts, either.
3048 * keyboard.c (read_char):
3049 * lread.c (Fload): Remove casts to unsigned.
3050
ea204efb
PE
3051 * lisp.h (UNSIGNED_CMP): New macro.
3052 This fixes comparison bugs on 64-bit hosts.
3053 (ASCII_CHAR_P): Use it.
3054 * casefiddle.c (casify_object):
01103c44 3055 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
3056 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3057 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3058 * dispextern.h (FACE_FROM_ID):
3059 * keyboard.c (read_char): Use UNSIGNED_CMP.
3060
41cb286c
PE
3061 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3062 not to EMACS_INT, to avoid GCC warning.
3063
4a1b9832
PE
3064 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3065
55daad71
PE
3066 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3067 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3068 isn't needed on 32-bit machines.
8f95c75c 3069
01103c44
PE
3070 * buffer.c (Fgenerate_new_buffer_name):
3071 Use EMACS_INT for count, not int.
0ceccced 3072 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
3073
3074 * data.c (Qcompiled_function): Now static.
3075
c6f072e7
PE
3076 * window.c (window_body_lines): Now static.
3077
20ce5912
PE
3078 * image.c (gif_load): Rename local to avoid shadowing.
3079
9c4c5f81
PE
3080 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3081 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3082 * alloc.c (make_save_value): Integer argument is now of type
3083 ptrdiff_t, not int.
3084 (mark_object): Use ptrdiff_t, not int.
3085 * lisp.h (pD): New macro.
3086 * print.c (print_object): Use it.
3087
c0c5c8ae
PE
3088 * alloc.c: Use EMACS_INT, not int, to count objects.
3089 (total_conses, total_markers, total_symbols, total_vector_size)
3090 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
3091 (total_free_floats, total_floats, total_free_intervals)
3092 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
3093 Now EMACS_INT, not int. All uses changed.
3094 (Fgarbage_collect): Compute overall total using a double, so that
3095 integer overflow is less likely to be a problem. Check for overflow
3096 when converting back to an integer.
5a25e253
PE
3097 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3098 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3099 These were 'int' variables that could overflow on 64-bit hosts;
3100 they were never used, so remove them instead of repairing them.
211a0b2a 3101 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
3102 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3103 Previously, this ceilinged at INT_MAX, but that doesn't work on
3104 64-bit machines.
e46bb31a 3105 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 3106
c78baabf 3107 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 3108 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
3109 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3110 when a (possibly-narrower) signed value would do just as well.
3111 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 3112
c9d624c6
PE
3113 * alloc.c: Catch some string size overflows that we were missing.
3114 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3115 for convenience in STRING_BYTES_MAX.
3116 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3117 The definition here is exact; the one in lisp.h was approximate.
3118 (allocate_string_data): Check for string overflow. This catches
3119 some instances we weren't catching before. Also, it catches
3120 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3121 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3122 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 3123
c9d624c6
PE
3124 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3125 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 3126 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 3127
353032ce
PE
3128 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3129
2bccce07
PE
3130 * alloc.c (Fmake_string): Check for out-of-range init.
3131
0ac30604
SM
31322011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3133
3134 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3135
c195f2de
JD
31362011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3137
3138 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3139 xg_get_default_scrollbar_width.
3140
3141 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3142 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3143 (style_changed_cb): Call update_theme_scrollbar_width and call
3144 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3145 all frames (Bug#8505).
3146 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3147 Call gtk_window_set_resizable if HAVE_GTK3.
3148 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3149 and height if HAVE_GTK3 (Bug#8505).
3150 (scroll_bar_width_for_theme): New variable.
3151 (update_theme_scrollbar_width): New function.
3152 (xg_get_default_scrollbar_width): Move code to
3153 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3154 (xg_initialize): Call update_theme_scrollbar_width.
3155
3156 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3157
3158 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3159
e10ac9f1
MR
31602011-06-12 Martin Rudalics <rudalics@gmx.at>
3161
3162 * frame.c (make_frame): Call other_buffer_safely instead of
3163 other_buffer.
3164
3165 * window.c (temp_output_buffer_show): Call display_buffer with
3166 second argument Vtemp_buffer_show_specifiers and reset latter
3167 immediately after the call.
3168 (Vtemp_buffer_show_specifiers): New variable.
3169 (auto_window_vscroll_p, next_screen_context_lines)
3170 (Vscroll_preserve_screen_position): Remove leading asterisks from
3171 doc-strings.
3172
2d3c217e 31732011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 3174
7b7f97e8 3175 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
3176 * buffer.c (Qclone_number): Remove for now, as it's unused.
3177 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3178 (record_buffer): Remove unused local.
3179 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3180 (set_frame_buffer_list): Remove; unused.
3181 * frame.h (other_visible_frames): Remove decl.
3182 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3183 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3184 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3185 if HAVE_GPM.
3186 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3187 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3188 Define only if HAVE_GPM.
3189 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3190 (update_hints_inhibit): Remove; never set. All uses removed.
3191 * widgetprv.h (emacsFrameClassRec): Remove decl.
3192 * window.c (delete_deletable_window): Now returns void, since it
3193 wasn't returning anything.
3194 (compare_window_configurations): Remove unused locals.
3195 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3196 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
3197 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3198 the same widths as pointers. This follows up on the 2011-05-06 patch.
3199 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3200 * xterm.h: Likewise.
3201 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3202
1384b89e
JB
32032011-06-12 Juanma Barranquero <lekktu@gmail.com>
3204
3205 * makefile.w32-in: Update dependencies.
3206 (LISP_H): Add lib/intprops.h.
3207
1100a63c
CY
32082011-06-11 Chong Yidong <cyd@stupidchicken.com>
3209
3210 * image.c (gif_load): Add animation frame delay to the metadata.
3211 (syms_of_image): Use DEFSYM. New symbol `delay'.
3212
6198ccd0
MR
32132011-06-11 Martin Rudalics <rudalics@gmx.at>
3214
3215 * window.c (delete_deletable_window): Re-add.
3216 (Fset_window_configuration): Rewrite to handle dead buffers and
3217 consequently deletable windows.
3218 (window_tree, Fwindow_tree): Remove. Supply functionality in
3219 window.el.
3220 (compare_window_configurations): Simplify code.
3221
b6e3633c
AS
32222011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3223
1ab0dee5
AS
3224 * image.c (imagemagick_load_image): Fix type mismatch.
3225 (Fimagemagick_types): Likewise.
3226
b6e3633c
AS
3227 * window.h (replace_buffer_in_windows): Declare.
3228
9397e56f
MR
32292011-06-11 Martin Rudalics <rudalics@gmx.at>
3230
3231 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3232 Qclone_number. Remove external declaration of Qdelete_window.
3233 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3234 code.
640c8776
SM
3235 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3236 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
3237 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3238 buffer list implementation.
3239 (other_buffer_safely): New function.
3240 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3241 calls to replace_buffer_in_windows and
3242 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3243 if allowed.
3244 (record_buffer): Inhibit quitting and rewrite using quittable
3245 functions. Run Qbuffer_list_update_hook if allowed.
3246 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
3247 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3248 Move switch-to-buffer to window.el.
9397e56f
MR
3249 (bury-buffer): Move to window.el.
3250 (Vbuffer_list_update_hook): New variable.
3251
3252 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3253 section.
3254
3255 * window.h (resize_frame_windows): Move up in code.
3256 (Fwindow_frame): Remove EXFUN.
3257 (replace_buffer_in_all_windows): Remove prototype.
3258 (replace_buffer_in_windows_safely): Add prototype.
3259
3260 * window.c: Declare Qdelete_window static again. Move down
3261 declaration of select_count.
3262 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3263 (Fother_window): Move to window.el.
3264 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3265 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3266 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3267 window.el.
3268 (replace_buffer_in_windows): Implement by calling
3269 Qreplace_buffer_in_windows.
3270 (replace_buffer_in_all_windows): Remove with some functionality
3271 moved into replace_buffer_in_windows_safely.
3272 (replace_buffer_in_windows_safely): New function.
3273 (select_window_norecord, select_frame_norecord): Move in front
3274 of run_window_configuration_change_hook. Remove now obsolete
3275 declarations.
640c8776
SM
3276 (Fset_window_buffer): Rewrite doc-string.
3277 Call Qrecord_window_buffer.
9397e56f
MR
3278 (keys_of_window): Move binding for other-window to window.el.
3279
b50691aa
CY
32802011-06-11 Chong Yidong <cyd@stupidchicken.com>
3281
3282 * dispextern.h (struct image): Replace data member, whose int_val
3283 and ptr_val fields were not used by anything, with a single
3284 lisp_val object.
3285
3286 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3287 (gif_clear_image, gif_load, imagemagick_load_image)
3288 (gs_clear_image, gs_load): Callers changed.
3289
3f754b86
PE
32902011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3291
cca69397
PE
3292 * buffer.h: Include <time.h>, for time_t.
3293 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3294
109e28d0
PE
3295 Fix minor problems found by static checking.
3296
60737f02
PE
3297 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3298
4b66faf3
PE
3299 Make identifiers static if they are not used in other modules.
3300 * data.c (Qcompiled_function, Qframe, Qvector):
3301 * image.c (QimageMagick, Qsvg):
3302 * minibuf.c (Qmetadata):
3303 * window.c (resize_window_check, resize_root_window): Now static.
3304 * window.h (resize_window_check, resize_root_window): Remove decls.
3305
109e28d0
PE
3306 * window.c (window_deletion_count, delete_deletable_window):
3307 Remove; unused.
46a4ce9e
PE
3308 (window_body_lines): Now static.
3309 (Fdelete_other_windows_internal): Mark vars as initialized.
3310 Make sure 'resize_failed' is initialized.
3311 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3312 (resize_window_apply): Remove unused local.
3313 * window.h (delete_deletable_window): Remove decl.
3314
109e28d0 3315 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
3316 (imagemagick_load_image): Fix pointer signedness problem by changing
3317 last arg from unsigned char * to char *. All uses changed.
3318 Also, fix a local for similar reasons.
3319 Remove unused locals. Remove locals to avoid shadowing.
3320 (fn_rsvg_handle_free): Remove; unused.
3321 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 3322 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 3323
3f754b86
PE
3324 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3325
2547adb1
CY
33262011-06-10 Chong Yidong <cyd@stupidchicken.com>
3327
3328 * image.c (gif_load): Fix omitted cast error introduced by
3329 2011-06-06 change.
3330
2c8e37d4
MR
33312011-06-10 Martin Rudalics <rudalics@gmx.at>
3332
3333 * window.h (resize_proportionally, orig_total_lines)
3334 (orig_top_line): Remove from window structure.
3335 (set_window_height, set_window_width, change_window_heights)
3336 (Fdelete_window): Remove prototypes.
3337 (resize_frame_windows): Remove duplicate declaration.
3338
440a42e3
EZ
33392011-06-10 Eli Zaretskii <eliz@gnu.org>
3340
3341 * window.h (resize_frame_windows, resize_window_check)
3342 (delete_deletable_window, resize_root_window)
3343 (resize_frame_windows): Declare prototypes.
3344
3345 * window.c (resize_window_apply): Make definition be "static" to
3346 match the prototype.
3347
562dd5e9
MR
33482011-06-10 Martin Rudalics <rudalics@gmx.at>
3349
3350 * window.c: Remove declarations of Qwindow_size_fixed,
3351 window_min_size_1, window_min_size_2, window_min_size,
3352 size_window, window_fixed_size_p, enlarge_window, delete_window.
3353 Remove static from declaration of Qdelete_window, it's
3354 temporarily needed by Fbury_buffer.
3355 (replace_window): Don't assign orig_top_line and
3356 orig_total_lines.
3357 (Fdelete_window, delete_window): Remove. Window deletion is
3358 handled by window.el.
640c8776
SM
3359 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3360 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
3361 (Fdelete_other_windows): Remove. Deleting other windows is
3362 handled by window.el.
3363 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3364 handled in window.el.
3365 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3366 Window minimum sizes are handled in window.el.
3367 (shrink_windows, size_window, set_window_height)
3368 (set_window_width, change_window_heights, window_height)
3369 (window_width, CURBEG, CURSIZE, enlarge_window)
3370 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3371 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3372 handled in window.el.
3373 (make_dummy_parent): Rename to make_parent_window and give it a
3374 second argument horflag.
3375 (make_window): Don't set resize_proportionally any more.
3376 (Fsplit_window): Remove. Windows are split in window.el.
3377 (save_restore_action, save_restore_orig_size)
3378 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3379 Resize mini windows in window.el.
3380 (grow_mini_window, shrink_mini_window): Implement by calling
3381 Qresize_root_window_vertically, resize_window_check and
3382 resize_window_apply.
640c8776
SM
3383 (saved_window, Fset_window_configuration, save_window_save):
3384 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
3385 resize_proportionally.
3386 (window_min_height, window_min_width): Move to window.el.
3387 (keys_of_window): Move bindings for delete-other-windows,
3388 split-window, delete-window and enlarge-window to window.el.
3389
3390 * buffer.c: Temporarily extern Qdelete_window.
3391 (Fbury_buffer): Temporarily call Qdelete_window instead of
3392 Fdelete_window (Fbury_buffer will move to window.el soon).
3393
3394 * frame.c (set_menu_bar_lines_1): Remove code handling
3395 orig_top_line and orig_total_lines.
3396
3397 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3398 set_window_height but set heights directly.
3399 (change_frame_size_1): Use resize_frame_windows.
3400
3401 * xdisp.c (init_xdisp): Don't use set_window_height but set
3402 heights directly.
3403
640c8776
SM
3404 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3405 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
3406 run_window_configuration_change_hook.
3407
3408 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3409 instead of change_window_heights and run
3410 run_window_configuration_change_hook.
3411
1a13852e
MR
34122011-06-09 Martin Rudalics <rudalics@gmx.at>
3413
3414 * window.c (replace_window): Rename second argument REPLACEMENT to
3415 NEW. New third argument SETFLAG. Rewrite.
3416 (delete_window, make_dummy_parent): Call replace_window with
3417 third argument 1.
3418 (window_list_1): Move down in code.
3419 (run_window_configuration_change_hook): Move set_buffer part
3420 before select_frame_norecord part in order to unwind correctly.
3421 Rename count1 to count.
3422 (recombine_windows, delete_deletable_window, resize_root_window)
3423 (Fdelete_other_windows_internal)
3424 (Frun_window_configuration_change_hook, make_parent_window)
3425 (resize_window_check, resize_window_apply, Fresize_window_apply)
3426 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
3427 (Fdelete_window_internal, Fresize_mini_window_internal):
3428 New functions.
1a13852e
MR
3429 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3430
f3d1777e
MR
34312011-06-08 Martin Rudalics <rudalics@gmx.at>
3432
496e208e
MR
3433 * window.h (window): Add some new members to window structure -
3434 normal_lines, normal_cols, new_total, new_normal, clone_number,
3435 splits, nest, prev_buffers, next_buffers.
3436 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 3437 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 3438
f3d1777e
MR
3439 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3440 Remove.
496e208e
MR
3441 (make_dummy_parent): Set new members of windows structure.
3442 (make_window): Move down in code. Handle new members of window
3443 structure.
3444 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3445 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3446 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3447 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
3448 (Fset_window_next_buffers, Fset_window_clone_number):
3449 New functions.
496e208e
MR
3450 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3451 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3452 Doc-string fixes.
3453 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3454 Argument WINDOW can be now internal window too.
3455 (Fwindow_use_time): Move up in code.
3456 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3457 Rewrite doc-string.
3458 (Fset_window_configuration, saved_window)
3459 (Fcurrent_window_configuration, save_window_save): Handle new
3460 members of window structure.
b9e809c2
MR
3461 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3462 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3463 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3464 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3465 Qget_mru_window, Qresize_root_window,
3466 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3467 Qauto_buffer_name; staticpro them.
f3d1777e 3468
abde8f8c
MR
34692011-06-07 Martin Rudalics <rudalics@gmx.at>
3470
3471 * window.c (Fwindow_total_size, Fwindow_left_column)
3472 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3473 (Fwindow_list_1): New functions.
3474 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
3475 (Fwindow_width, Fscroll_left, Fscroll_right):
3476 Use window_body_cols instead of window_box_text_cols.
3477 (delete_window, Fset_window_configuration):
3478 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
3479 (delete_all_subwindows): Take a window as argument and not a
3480 structure. Rewrite.
190b47e6
MR
3481 (window_loop): Remove handling of GET_LRU_WINDOW and
3482 GET_LARGEST_WINDOW.
3483 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
3484
3485 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
3486 window_box_text_cols. delete_all_subwindows now takes a
3487 Lisp_Object as argument.
abde8f8c 3488
640c8776
SM
3489 * indent.c (compute_motion, Fcompute_motion):
3490 Use window_body_cols instead of window_box_text_cols.
abde8f8c 3491
fa8a67e6
MR
3492 * frame.c (delete_frame): Call delete_all_subwindows with root
3493 window as argument.
3494
a54e3482
DC
34952011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3496
3497 * fns.c (Fputhash): Document return value.
3498
60002bf5
CY
34992011-06-06 Chong Yidong <cyd@stupidchicken.com>
3500
3501 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3502
0c671da6 35032011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 3504
b862a52a 3505 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 3506
be44ca6c
PE
3507 Check for overflow when converting integer to cons and back.
3508 * charset.c (Fdefine_charset_internal, Fdecode_char):
3509 Use cons_to_unsigned to catch overflow.
3510 (Fencode_char): Use INTEGER_TO_CONS.
3511 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3512 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3513 * data.c (long_to_cons, cons_to_long): Remove.
3514 (cons_to_unsigned, cons_to_signed): New functions.
3515 These signal an error for invalid or out-of-range values.
3516 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3517 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3518 * font.c (Ffont_variation_glyphs):
3519 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3520 * lisp.h: Include <intprops.h>.
3521 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3522 (cons_to_signed, cons_to_unsigned): New decls.
3523 (long_to_cons, cons_to_long): Remove decls.
3524 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3525 (Fprimitive_undo): Use CONS_TO_INTEGER.
3526 * xfns.c (Fx_window_property): Likewise.
3527 * xselect.c: Include <limits.h>.
3528 (x_own_selection, selection_data_to_lisp_data):
3529 Use INTEGER_TO_CONS.
3530 (x_handle_selection_request, x_handle_selection_clear)
3531 (x_get_foreign_selection, Fx_disown_selection_internal)
3532 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3533 (lisp_data_to_selection_data): Use cons_to_unsigned.
3534 (x_fill_property_data): Use cons_to_signed.
3535 Report values out of range.
3536
d1f3d2af
PE
3537 Check for buffer and string overflow more precisely.
3538 * buffer.h (BUF_BYTES_MAX): New macro.
3539 * lisp.h (STRING_BYTES_MAX): New macro.
3540 * alloc.c (Fmake_string):
3541 * character.c (string_escape_byte8):
3542 * coding.c (coding_alloc_by_realloc):
3543 * doprnt.c (doprnt):
3544 * editfns.c (Fformat):
3545 * eval.c (verror):
3546 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3547 since they may not be the same number.
3548 * editfns.c (Finsert_char):
3549 * fileio.c (Finsert_file_contents):
3550 Likewise for BUF_BYTES_MAX.
3551
dd52fcea
PE
3552 * image.c: Use ptrdiff_t, not int, for sizes.
3553 (slurp_file): Switch from int to ptrdiff_t.
3554 All uses changed.
3555 (slurp_file): Check that file size fits in both size_t (for
3556 malloc) and ptrdiff_t (for sanity and safety).
3557
7f9bbdbb
PE
3558 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3559 if b->modtime has its maximal value.
3560
dfe18f82
PE
3561 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3562
84acfcf0
PE
3563 Don't assume time_t can fit into int.
3564 * buffer.h (struct buffer.modtime): Now time_t, not int.
3565 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3566 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3567
ccd9a01a
PE
3568 Minor fixes for signed vs unsigned integers.
3569 * character.h (MAYBE_UNIFY_CHAR):
3570 * charset.c (maybe_unify_char):
3571 * keyboard.c (read_char, reorder_modifiers):
3572 XINT -> XFASTINT, since the integer must be nonnegative.
3573 * ftfont.c (ftfont_spec_pattern):
3574 * keymap.c (access_keymap, silly_event_symbol_error):
3575 XUINT -> XFASTINT, since the integer must be nonnegative.
3576 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3577 since it makes no difference and we prefer signed.
3578 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3579 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3580 nonnegative.
3581
d6d100dd
SM
35822011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3583
3584 * window.h (Fwindow_frame): Declare.
3585
2b6148e4
PE
35862011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3587
3588 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3589 (SPARE_MEMORY): Always define.
3590 (LARGE_REQUEST): Remove.
3591 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3592
f230ecc9
MR
35932011-06-06 Martin Rudalics <rudalics@gmx.at>
3594
727e958e
MR
3595 * lisp.h: Move EXFUNS for Fframe_root_window,
3596 Fframe_first_window and Fset_frame_selected_window to window.h.
3597
3598 * window.h: Move EXFUNS for Fframe_root_window,
3599 Fframe_first_window and Fset_frame_selected_window here from
3600 lisp.h.
3601
3602 * frame.c (Fwindow_frame, Fframe_first_window)
3603 (Fframe_root_window, Fframe_selected_window)
3604 (Fset_frame_selected_window): Move to window.c.
3605 (Factive_minibuffer_window): Move to minibuf.c.
3606 (Fother_visible_frames_p): New function.
3607
3608 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3609
f230ecc9
MR
3610 * window.c (decode_window, decode_any_window): Move up in code.
3611 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3612 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
3613 (Fwindow_buffer): Move up and rewrite doc-string.
3614 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3615 (Fwindow_prev): New functions.
727e958e
MR
3616 (Fwindow_frame): Move here from frame.c. Accept any window as
3617 argument.
3618 (Fframe_root_window, Fframe_first_window)
3619 (Fframe_selected_window): Move here from frame.c. Accept frame
3620 or arbitrary window as argument. Update doc-strings.
3621 (Fminibuffer_window): Move up in code.
3622 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
3623 (Fset_frame_selected_window): Move here from frame.c.
3624 Marginal rewrite.
727e958e
MR
3625 (Fselected_window, select_window, Fselect_window): Move up in
3626 code. Minor doc-string fixes.
f230ecc9 3627
4d09bcf6
PE
36282011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3629
3630 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3631 Do not assume that spare memory exists; that assumption is valid
3632 only if SYSTEM_MALLOC.
3633 (LARGE_REQUEST): New macro, so that the issue of large requests
3634 is separated from the issue of spare memory.
3635
810928a2
AS
36362011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3637
172418ad
AS
3638 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3639 format. (Bug#8806)
3640
43f862f7
AS
3641 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3642
810928a2
AS
3643 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3644 before statements.
3645
a059fe24
JD
36462011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3647
3648 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3649
3650 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3651
3652 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3653 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3654
989bf368
JB
36552011-06-05 Juanma Barranquero <lekktu@gmail.com>
3656
3657 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3658
4b80f674
CY
36592011-06-04 Chong Yidong <cyd@stupidchicken.com>
3660
3661 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3662 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
3663 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3664 New error handlers.
4b80f674
CY
3665 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3666 Obey Vx_select_enable_clipboard_manager. Catch errors in
3667 x_clipboard_manager_save (Bug#8779).
3668 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 3669 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 3670
99a33b77 36712011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
3672
3673 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3674
99a33b77 36752011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
3676
3677 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3678 in the current matrix if keep_current_p is non-zero.
3679
8264569d
EZ
36802011-06-04 Eli Zaretskii <eliz@gnu.org>
3681
3682 * bidi.c (bidi_level_of_next_char): Fix last change.
3683
57f97249
EZ
36842011-06-03 Eli Zaretskii <eliz@gnu.org>
3685
fec2107c 3686 Support bidi reordering of text covered by display properties.
57f97249 3687
fec2107c
EZ
3688 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3689 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3690 (bidi_cache_search, bidi_cache_iterator_state)
3691 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
3692 (bidi_level_of_next_char, bidi_move_to_visually_next):
3693 Support character positions inside a run of characters covered by a
fec2107c
EZ
3694 display string.
3695 (bidi_paragraph_init, bidi_resolve_explicit_1)
3696 (bidi_level_of_next_char): Call bidi_fetch_char and
3697 bidi_fetch_char_advance instead of FETCH_CHAR and
3698 FETCH_CHAR_ADVANCE.
3699 (bidi_init_it): Initialize new members.
3700 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
3701 definitions.
3702 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
3703 instead of using explicit *_CHAR codes.
d6d100dd
SM
3704 (bidi_resolve_explicit, bidi_resolve_weak):
3705 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
3706 bidirectional text is supported only in multibyte buffers.
3707 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
3708 it to initialize the frame_window_p member of struct bidi_it.
3709 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
3710 (bidi_resolve_explicit, bidi_resolve_weak)
3711 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
3712 bidi_it->nchars is non-positive.
3713 (bidi_level_of_next_char): Don't try to lookup the cache for the
3714 next/previous character if nothing is cached there yet, or if we
3715 were just reseat()'ed to a new position.
c40e2fb2 3716
0e14fe90
EZ
3717 * xdisp.c (set_cursor_from_row): Set start and stop points
3718 according to the row's direction when priming the loop that looks
3719 for the glyph on which to display cursor.
3720 (single_display_spec_intangible_p): Function deleted.
3721 (display_prop_intangible_p): Reimplement to call
3722 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
3723 Accept 3 additional arguments needed by handle_display_spec.
3724 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
3725 values: lists, `(when COND...)' forms, etc.
3726 (single_display_spec_string_p): Support property values that are
3727 lists with the argument STRING its top-level element.
3728 (display_prop_string_p): Fix the condition for processing a
3729 property that is a list to be consistent with handle_display_spec.
fec2107c 3730 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
3731 last portion of handle_display_prop.
3732 (compute_display_string_pos): Accept additional argument
3733 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
3734 value of a `display' property is a "replacing spec".
3735 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
3736 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
3737 the display property, but just return a value indicating whether
3738 the display property will replace the characters it covers.
3739 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
3740 frame_window_p members of struct bidi_it.
d6d100dd
SM
3741 (compute_display_string_pos, compute_display_string_end):
3742 New functions.
fec2107c
EZ
3743 (push_it): Accept second argument POSITION, where pop_it should
3744 jump to continue iteration.
3745 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 3746
fec2107c
EZ
3747 * keyboard.c (adjust_point_for_property): Adjust the call to
3748 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
3749
3750 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
3751 (bidi_init_it): Update prototypes.
3752 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
3753 (compute_display_string_pos, compute_display_string_end):
3754 Declare prototypes.
fec2107c
EZ
3755 (struct bidi_it): New members nchars and disp_pos. ch_len is now
3756 EMACS_INT.
fc6f18ce 3757
40087514 37582011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 3759
57f53182
PE
3760 Malloc failure behavior now depends on size of allocation.
3761 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
3762 * lisp.h: Change signatures accordingly.
3763 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
3764 All callers changed. (Bug#8762)
3765
3766 * gnutls.c: Use Emacs's memory allocators.
3767 Without this change, the gnutls library would invoke malloc etc.
3768 directly, which causes problems on non-SYNC_INPUT hosts, and which
3769 runs afoul of improving memory_full behavior. (Bug#8761)
3770 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
3771 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
3772 xfree instead of the default malloc, realloc, free.
3773 (Fgnutls_boot): No need to check for memory allocation failure,
3774 since xmalloc does that for us.
3775
ac32cd99 3776 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
3777 * category.c (hash_get_category_set):
3778 * ccl.c (ccl_driver):
3779 * charset.c (Fdefine_charset_internal):
3780 * charset.h (struct charset.hash_index):
3781 * composite.c (get_composition_id, gstring_lookup_cache)
3782 (composition_gstring_put_cache):
3783 * composite.h (struct composition.hash_index):
3784 * dispextern.h (struct image.hash):
3785 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
3786 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
3787 (hashfn_equal, hashfn_user_defined, make_hash_table)
3788 (maybe_resize_hash_table, hash_lookup, hash_put)
3789 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
3790 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
3791 (Fsxhash, Fgethash, Fputhash, Fmaphash):
3792 * image.c (make_image, search_image_cache, lookup_image)
3793 (xpm_put_color_table_h):
3794 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 3795 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 3796 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 3797 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
3798 * alloc.c (allocate_vectorlike):
3799 Check for overflow in vector size calculations.
3800 * ccl.c (ccl_driver):
3801 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
3802 * fns.c, image.c: Remove unnecessary static decls that would otherwise
3803 need to be updated by these changes.
40087514
PE
3804 * fns.c (make_hash_table, maybe_resize_hash_table):
3805 Check for integer overflow with large hash tables.
0de4bb68
PE
3806 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
3807 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
3808 (SXHASH_REDUCE): New macro.
3809 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
3810 Use it instead of discarding useful hash info with large hash values.
3811 (sxhash_float): New function.
3812 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
3813 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
3814 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
3815 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
3816 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
3817 Adjust signatures to match updated version of code.
3818 (consing_since_gc): Now EMACS_INT, since a single hash table can
3819 use more than INT_MAX bytes.
3820
698d32e2
DN
38212011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
3822
3823 Make it possible to build with GCC-4.6+ -O2 -flto.
3824
3825 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
3826
fd6fa53f
SM
38272011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
3828
3829 * minibuf.c (get_minibuffer, read_minibuf_unwind):
3830 Call minibuffer-inactive-mode.
3831
864db017
JB
38322011-05-31 Juanma Barranquero <lekktu@gmail.com>
3833
3834 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3835 Update dependencies.
3836
2ad0baf4
DN
38372011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3838
3839 * data.c (init_data): Remove code for UTS, this system is not
3840 supported anymore.
3841
4fcc2638
DN
38422011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3843
3844 Don't force ./temacs to start in terminal mode.
3845
3846 * frame.c (make_initial_frame): Initialize faces in all cases, not
3847 only when CANNOT_DUMP is defined.
3848 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3849
c56e0fd5
DN
38502011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3851
3852 * dispnew.c (add_window_display_history): Use const for the string
3853 pointer. Remove declaration, not needed.
3854
333d54da 38552011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 3856
55d4c1b2 3857 Use 'inline', not 'INLINE'.
333d54da 3858 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
3859 * alloc.c, fontset.c (INLINE): Remove.
3860 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3861 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3862 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3863 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3864 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3865
738db178
DN
38662011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3867
3868 Make it possible to run ./temacs.
3869
3870 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3871 syms_of_callproc does the same thing. Remove test for
3872 "initialized", do it in the caller.
3873 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3874
620c53a6
SM
38752011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3876
3877 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3878 (read_minibuf): Use get_minibuffer.
3879 (syms_of_minibuf): Use DEFSYM.
3880 (Qmetadata): New var.
3881 * data.c (Qbuffer): Don't make it static.
3882 (syms_of_data): Use DEFSYM.
3883
e003a292
PE
38842011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3885
3886 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3887 (CCL_CODE_MIN): New macro.
3888
ed008a6d
PE
38892011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3890
3687c2ef
PE
3891 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3892
ed008a6d
PE
3893 * eval.c (Qdebug): Now static.
3894 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3895 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
3896 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3897
d66c4c7c
CY
38982011-05-29 Chong Yidong <cyd@stupidchicken.com>
3899
3900 * image.c: Various fixes to ImageMagick code comments.
3901 (Fimagemagick_types): Doc fix.
3902
5fbc2025
PE
39032011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3904
0196f88a
PE
3905 Minor fixes prompted by GCC 4.6.0 warnings.
3906
3907 * xselect.c (converted_selections, conversion_fail_tag): Now static.
3908
5fbc2025
PE
3909 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
3910 (x_clipboard_manager_save_all): Move extern decl to ...
3911 * xterm.h: ... here, so that it can be checked for consistency.
3912
1dd3c2d9
CY
39132011-05-29 Chong Yidong <cyd@stupidchicken.com>
3914
3915 * xselect.c (x_clipboard_manager_save_frame)
3916 (x_clipboard_manager_save_all): New functions.
3917 (Fx_clipboard_manager_save): Lisp function deleted.
3918
3919 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
3920 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
3921
3922 * xterm.h: Update prototype.
3923
5ba6571d
WX
39242011-05-28 William Xu <william.xwl@gmail.com>
3925
3926 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
3927 exiting (Bug#8239).
3928
3eaff834
JM
39292011-05-28 Jim Meyering <meyering@redhat.com>
3930
e1900994 3931 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
3932 * fns.c (to_uchar): Define.
3933 (crypto_hash_function): Use it to convert some newly-signed
3934 variables to unsigned, to avoid sign-extension bugs. For example,
3935 without this change, (md5 "truc") would evaluate to
3936 45723a2aff78ff4fff7fff1114760e62 rather than the expected
3937 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 3938 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 3939
0f6990a7
PE
39402011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3941
3942 Integer overflow fixes.
c8a9ca5a 3943
08686060
PE
3944 * dbusbind.c: Serial number integer overflow fixes.
3945 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
3946 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
3947 to hold a serial number that is too large for a fixnum.
3948 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3949 Check for serial numbers out of range. Decode any serial number
59568bf0 3950 that was so large that it became a float. (Bug#8722)
08686060 3951
2d1fc3c7
PE
3952 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
3953 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3954 Use XFASTINT rather than XUINT when numbers are nonnegative.
3955 (xd_append_arg, Fdbus_method_return_internal):
3956 (Fdbus_method_error_internal): Likewise. Also, for unsigned
3957 arguments, check that Lisp number is nonnegative, rather than
59568bf0 3958 silently wrapping negative numbers around. (Bug#8722)
30217ff0 3959 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 3960 (Bug#8722)
2d1fc3c7 3961
c8a9ca5a
PE
3962 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
3963
519e1d69
PE
3964 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
3965
30569699
PE
3966 ccl: add integer overflow checks
3967 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
3968 (IN_INT_RANGE): New macros.
3969 (ccl_driver): Use them to check for integer overflow when
3970 decoding a CCL program. Many of the new checks are whether XINT (x)
3971 fits in int; it doesn't always, on 64-bit hosts. The new version
3972 doesn't catch all possible integer overflows, but it's an
847044ea 3973 improvement. (Bug#8719)
30569699 3974
c11285dc
PE
3975 * alloc.c (make_event_array): Use XINT, not XUINT.
3976 There's no need for unsigned here.
3977
fdccd48e
PE
3978 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
3979 This follows up to the 2011-05-06 change that substituted uintptr_t
3980 for EMACS_INT. This case wasn't caught back then.
3981
37910ab2
PE
3982 Rework Fformat to avoid integer overflow issues.
3983 * editfns.c: Include <float.h> unconditionally, as it's everywhere
3984 now (part of C89). Include <verify.h>.
3985 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
3986 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
3987 (Fformat): Avoid the prepass trying to compute sizes; it was only
3988 approximate and thus did not catch overflow reliably. Instead, walk
3989 through the format just once, formatting and computing sizes as we go,
3990 checking for integer overflow at every step, and allocating a larger
3991 buffer as needed. Keep track separately whether the format is
3992 multibyte. Keep only the most-recently calculated precision, rather
3993 than them all. Record whether each argument has been converted to
3994 string. Use EMACS_INT, not int, for byte and char and arg counts.
3995 Support field widths and precisions larger than INT_MAX. Avoid
3996 sprintf's undefined behavior with conversion specifications such as %#d
3997 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
3998 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
3999 formatting out-of-range floating point numbers with int
9173deec 4000 formats. (Bug#8668)
37910ab2 4001
2e6578fb
PE
4002 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4003
0ae6bdee
PE
4004 * data.c: Avoid integer truncation in expressions involving floats.
4005 * data.c: Include <intprops.h>.
4006 (arith_driver): When there's an integer overflow in an expression
4007 involving floating point, convert the integers to floating point
4008 so that the resulting value does not suffer from catastrophic
4009 integer truncation. For example, on a 64-bit host (* 4
4010 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4011 Do not rely on undefined behavior after integer overflow.
4012
de883a70
PE
4013 merge count_size_as_multibyte, parse_str_to_multibyte
4014 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 4015 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
4016 Check for integer overflow.
4017 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4018 since it's now a duplicate of the other. This is more of
4019 a character than a buffer op, so better that it's in character.c.
4020 * fns.c, print.c: Adjust to above changes.
4021
2ff916cb
PE
40222011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4023
4024 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4025
f1b54466
PE
40262011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4027
fb1ac845
PE
4028 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4029 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4030 (x_clipboard_manager_save): Now static.
4031 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4032
f1b54466
PE
4033 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4034 (crypto_hash_function): Now static.
4035 Fix pointer signedness problems. Avoid unnecessary initializations.
4036
a9f737ee
CY
40372011-05-27 Chong Yidong <cyd@stupidchicken.com>
4038
4039 * termhooks.h (Vselection_alist): Make it terminal-local.
4040
4041 * terminal.c (create_terminal): Initialize it.
4042
4043 * xselect.c: Support for clipboard managers.
4044 (Vselection_alist): Move to termhooks.h as terminal-local var.
4045 (LOCAL_SELECTION): New macro.
4046 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4047 (symbol_to_x_atom): Remove gratuitous arg.
4048 (x_handle_selection_request, lisp_data_to_selection_data)
4049 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
4050 (x_own_selection, x_get_local_selection, x_convert_selection):
4051 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
4052 (some_frame_on_display): Delete unused function.
4053 (Fx_own_selection_internal, Fx_get_selection_internal)
4054 (Fx_disown_selection_internal, Fx_selection_owner_p)
4055 (Fx_selection_exists_p): New optional frame arg.
4056 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4057 (x_handle_selection_clear): Don't treat other terminals with the
4058 same keyboard specially. Use the terminal-local Vselection_alist.
4059 (x_clear_frame_selections): Use Frun_hook_with_args.
4060
4061 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4062
4063 * xterm.h: Add support for those atoms.
4064
e067f0c1
CY
40652011-05-26 Chong Yidong <cyd@stupidchicken.com>
4066
4067 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4068 (converted_selections, conversion_fail_tag): New global variables.
4069 (x_selection_request_lisp_error): Free the above.
4070 (x_get_local_selection): Remove unnecessary code.
4071 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
4072 of converted selections stored in converted_selections.
4073 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
4074 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4075 (x_convert_selection): New function.
4076 (x_handle_selection_event): Simplify.
4077 (x_get_foreign_selection): Don't ignore incoming requests while
4078 waiting for an answer; this will fail when we implement
4079 SAVE_TARGETS, and seems unnecessary anyway.
4080 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4081 (Vx_sent_selection_functions): Doc fix.
4082
0f4aebc0
LL
40832011-05-26 Leo Liu <sdl.web@gmail.com>
4084
4085 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4086
e61124cd
YM
40872011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4088
4089 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4090
4091 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4092 for fringe update if it has periodic bitmap.
ac389d0c 4093 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
4094 and fringe_bitmap_periodic_p.
4095
4096 * fringe.c (get_fringe_bitmap_data): New function.
4097 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4098 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4099 row. Mark glyph row for fringe update if periodicity changed.
4100
4101 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4102 for fringe update unless it has periodic bitmap.
4103
f16d9837
KH
41042011-05-25 Kenichi Handa <handa@m17n.org>
4105
4106 * xdisp.c (get_next_display_element): Set correct it->face_id for
4107 a static composition.
4108
e1b90ef6
LL
41092011-05-24 Leo Liu <sdl.web@gmail.com>
4110
4111 * deps.mk (fns.o):
4112 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4113
4114 * fns.c (crypto_hash_function, Fsha1): New function.
4115 (Fmd5): Use crypto_hash_function.
4116 (syms_of_fns): Add Ssha1.
4117
7400048f
PE
41182011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4119
4120 * gnutls.c: Remove unused macros.
4121 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4122 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4123 Remove macros that are defined and never used.
4124 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4125
abb71cf4
CY
41262011-05-22 Chong Yidong <cyd@stupidchicken.com>
4127
4128 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4129 (Fx_get_selection_internal): Minor cleanup.
4130 (Fx_own_selection_internal): Rename arguments for consistency with
4131 select.el.
4132
6307db39
PE
41332011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4134
4135 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4136
f3d4e0a4
CY
41372011-05-22 Chong Yidong <cyd@stupidchicken.com>
4138
4139 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4140
4d8ade89
YM
41412011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4142
4143 * dispnew.c (scrolling_window): Don't exclude the case that the
4144 last enabled row in the desired matrix touches the bottom boundary.
4145
32078c8d
GM
41462011-05-21 Glenn Morris <rgm@gnu.org>
4147
4148 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
4149 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4150 and add some more files.
32078c8d 4151
7285dc67
EZ
41522011-05-20 Eli Zaretskii <eliz@gnu.org>
4153
4154 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4155 report_file_error introduced by the change from 2011-05-07.
4156
89d1bd22
PE
41572011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4158
4159 * systime.h (Time): Define only if emacs is defined.
4160 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4161 where the include path doesn't have X11/X.h by default. See
4162 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4163
e23640bb 41642011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
4165
4166 * composite.c (find_automatic_composition): Fix previous change.
4167
b9704ad9
GM
41682011-05-20 Glenn Morris <rgm@gnu.org>
4169
4170 * lisp.mk: New file, split from Makefile.in.
4171 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4172 (shortlisp): Remove.
4173 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4174
4a720484
GM
41752011-05-19 Glenn Morris <rgm@gnu.org>
4176
4177 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4178 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4179 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4180 (lisp): Set the order to that of loadup.el.
4181 (shortlisp): Make it a copy of $lisp.
4182 (SOME_MACHINE_LISP): Remove.
4183 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4184 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4185
a28d4396
KH
41862011-05-18 Kenichi Handa <handa@m17n.org>
4187
4188 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4189 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4190 (find_automatic_composition): Mostly rewrite for efficiency.
4191
a2b1fa8e
JB
41922011-05-18 Juanma Barranquero <lekktu@gmail.com>
4193
4194 * makefile.w32-in: Update dependencies.
4195
8e1f5610
CS
41962011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4197
4198 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 4199 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 4200
7025ee00 42012011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 4202
cdfa6eab
PE
4203 Fix some integer overflow issues, such as string length overflow.
4204
06d6db33
PE
4205 * insdel.c (count_size_as_multibyte): Check for string overflow.
4206
2b4560a8
PE
4207 * character.c (lisp_string_width): Check for string overflow.
4208 Use EMACS_INT, not int, for string indexes and lengths; in
4209 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4210 the resulting string length overflows an EMACS_INT; instead,
4211 report a string overflow if no precision given. When checking for
4212 precision exhaustion, use a check that cannot possibly have
4213 integer overflow. (Bug#8675)
4214 * character.h (lisp_string_width): Adjust to new signature.
4215
cb93f9be
PE
4216 * alloc.c (string_overflow): New function.
4217 (Fmake_string): Use it. This doesn't change behavior, but saves
4218 a few bytes and will simplify future changes.
4219 * character.c (string_escape_byte8): Likewise.
4220 * lisp.h (string_overflow): New decl.
4221
1a1f3366
PE
4222 Fixups, following up to the user-interface timestamp change.
4223 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4224 for UI timestamps, instead of unsigned long.
9fbd6841
PE
4225 * msdos.c (mouse_get_pos): Likewise.
4226 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
4227 * w32gui.h (Time): Define by including "systime.h" rather than by
4228 declaring it ourselves. (Bug#8664)
4229
d4e3e4d3
PE
4230 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4231 * image.c (clear_image_cache): Likewise.
4232
f6a24d19
PE
4233 * term.c (term_mouse_position): Don't assume time_t wraparound.
4234
08dc5ae6
PE
4235 Be more systematic about user-interface timestamps.
4236 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
4237 and sometimes 'EMACS_UINT', to represent these timestamps.
4238 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
4239 This makes the code easier to follow, and makes it easier to catch
4240 integer overflow bugs such as Bug#8664.
4241 * frame.c (Fmouse_position, Fmouse_pixel_position):
4242 Use Time, not unsigned long, for user-interface timestamps.
4243 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4244 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4245 * keyboard.h (last_event_timestamp): Likewise.
4246 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4247 * menu.h (xmenu_show): Likewise.
4248 * term.c (term_mouse_position): Likewise.
4249 * termhooks.h (struct input_event.timestamp): Likewise.
4250 (struct terminal.mouse_position_hook): Likewise.
4251 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4252 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4253 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4254 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4255 what it was before.
4256 * menu.h, termhooks.h: Include "systime.h", for Time.
4257
8e55734a
PE
4258 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4259 Don't assume that the difference between two unsigned long values
4260 can fit into an integer. At this point, we know button_down_time
4261 <= event->timestamp, so the difference must be nonnegative, so
4262 there's no need to cast the result if double-click-time is
4263 nonnegative, as it should be; check that it's nonnegative, just in
4264 case. This bug is triggered when events are more than 2**31 ms
86db42d2 4265 apart (about 25 days). (Bug#8664)
8e55734a 4266
841f1b75 4267 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 4268 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 4269
3e26f69c
PE
4270 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4271 that always fit in int. Use a sentinel instead of a counter, to
4272 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
4273 * frame.h (struct frame): Use int for menu_bar_items_used
4274 instead of EMACS_INT, since it always fits in int.
3e26f69c 4275
5cc152c0
PE
4276 * menu.c (grow_menu_items): Check for int overflow.
4277
d89eb65e
PE
4278 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4279
5235bd3e
PE
4280 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4281 Before, the code was not consistent. These values cannot exceed
4282 2**31 - 1 so there's no need to make them unsigned.
4283 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4284 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4285 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4286 as modifiers.
4287 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4288
bc827e23
PE
4289 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4290 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4291 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4292 presumably because the widths might not match.
4293
78eb494e
PE
4294 * window.c (size_window): Avoid needless test at loop start.
4295
04f2d78b
CB
42962011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4297
4298 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4299
d2fc7e3d 43002011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
4301
4302 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4303
d2fc7e3d 43042011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
4305
4306 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4307 `width' to `bar_area_x' and `bar_area_width', respectively.
4308 (x_scroll_run): Take account of fringe background extension.
4309
04f2d78b
CB
4310 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4311 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
4312 `bar_area_width', respectively.
4313 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4314 background extension.
4315
79b70037
GM
43162011-05-10 Jim Meyering <meyering@redhat.com>
4317
4318 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4319
2f142cc5
JB
43202011-05-10 Juanma Barranquero <lekktu@gmail.com>
4321
4322 * image.c (Finit_image_library): Return t for built-in image types,
4323 like pbm and xbm. (Bug#8640)
4324
57679c86
AS
43252011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4326
4327 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4328
888c9e86
EZ
43292011-05-07 Eli Zaretskii <eliz@gnu.org>
4330
b0512a1d
EZ
4331 * w32console.c (Fset_screen_color): Doc fix.
4332 (Fget_screen_color): New function.
4333 (syms_of_ntterm): Defsubr it.
4334
7285dc67
EZ
4335 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4336 unlink the temporary file if Fcall_process didn't create it in the
4337 first place.
4338 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4339 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
4340 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4341 cue to call_process_cleanup not to close that handle.
4342
4d3fcc8e
BK
43432011-05-07 Ben Key <bkey76@gmail.com>
4344
4345 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4346 one of two shell specific rules, either bootstrap-temacs-CMD or
4347 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4348 to the previous implementation of the bootstrap-temacs rule.
4349 The bootstrap-temacs-CMD rule is similar to the previous
4350 implementation of the bootstrap-temacs rule except that it
4351 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4352 variable.
4353
4354 These changes, along with some changes to nt/configure.bat,
4355 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4356 earlier fix to add support for --cflags and --ldflags options
4357 that include quotes so that it works whether make uses cmd or
4358 sh as the shell.
4359
b4289b64
MA
43602011-05-06 Michael Albinus <michael.albinus@gmx.de>
4361
4362 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4363 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4364 is a constant.
4365 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4366 a string. Handle both cases.
4367 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4368 (Fdbus_register_method): Use Qinvalid_function.
4369
af4c0e28
JB
43702011-05-06 Juanma Barranquero <lekktu@gmail.com>
4371
4372 * makefile.w32-in: Update dependencies.
4373 (LISP_H): Add inttypes.h and stdin.h.
4374 (PROCESS_H): Add unistd.h.
4375
c51453d9
EZ
43762011-05-06 Eli Zaretskii <eliz@gnu.org>
4377
4378 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4379 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4380
8ff0ac3c 43812011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 4382
4c4b566b
PE
4383 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4384
aab2b9b5
PE
4385 * term.c (vfatal): Remove stray call to va_end.
4386 It's not needed and the C Standard doesn't allow it here anyway.
4387
c378da0b
PE
4388 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4389 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4390
288b08c7
PE
4391 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4392 bytes.
4393
e3601888
PE
4394 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4395
db6c0e74
PE
4396 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4397
dd5963ea
PE
4398 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4399
88c9450f
PE
4400 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4401
2f9442b8
PE
4402 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4403
c032b5f8
PE
4404 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4405 * charset.c (Fdefine_charset_internal): Don't initialize
4406 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 4407 32-bit int (Bug#8600).
a108c10b
PE
4408
4409 * lread.c (read_integer): Be more consistent with string-to-number.
4410 Use string_to_number to do the actual conversion; this avoids
4411 rounding errors and fixes some other screwups. Without this fix,
4412 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4413 (digit_to_number): Move earlier, for benefit of read_integer.
4414 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 4415 not a digit in any supported base. (Bug#8602)
a108c10b 4416
ad5f9eea
PE
4417 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4418
aec1708a
PE
4419 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4420 to match comment at start of function. This also removes a
4421 GCC warning about overflow in a 32+64-bit port.
4422
47be4ab5
PE
4423 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4424
371cac43
PE
4425 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4426 Reported by Stefan Monnier in
4427 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
4428 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4429 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 4430
d01a7826
PE
4431 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4432 (EMACS_UINTPTR): Likewise, with uintptr_t.
4433
7fd47d5c
PE
4434 * lisp.h: Prefer 64-bit EMACS_INT if available.
4435 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4436 on 32-bit hosts that have 64-bit int, so that they can access
4437 large files.
122b0c86
PE
4438 However, temporarily disable this change unless the temporary
4439 symbol WIDE_EMACS_INT is defined.
7fd47d5c 4440
8727937b
PE
4441 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4442
8ac068ac
PE
4443 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4444 This removes an assumption that EMACS_INT and long are the same
4445 width as pointers. The assumption is true for Emacs porting targets
4446 now, but we want to make other targets possible.
4447 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4448 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4449 In the rest of the code, change types of integers that hold casted
4450 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4451 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4452 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4453 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4454 No need to cast type when ORing.
4455 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4456 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4457 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4458 assume EMACS_INT is the same width as char *.
4459 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4460 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4461 Remove no-longer-needed casts.
4462 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4463 (xg_tool_bar_help_callback, xg_make_tool_item):
4464 Use EMACS_INTPTR to hold an integer
4465 that will be cast to void *; this can avoid a GCC warning
4466 if EMACS_INT is not the same width as void *.
4467 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4468 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4469 (current_message_1, set_message_1):
4470 Use a local to convert to proper width without a cast.
4471 * xmenu.c (dialog_selection_callback): Likewise.
4472
ede49d71
PE
4473 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4474 Also, don't assume VALBITS / RAND_BITS is less than 5,
4475 and don't rely on undefined behavior when shifting a 1 left into
4476 the sign bit.
4477 * lisp.h (get_random): Change signature to match.
4478
2f30ecd0
PE
4479 * lread.c (hash_string): Use size_t, not int, for hash computation.
4480 Normally we prefer signed values; but hashing is special, because
4481 it's better to use unsigned division on hash table sizes so that
4482 the remainder is nonnegative. Also, size_t is the natural width
4483 for hashing into memory. The previous code used 'int', which doesn't
4484 retain enough info to hash well into very large tables.
4485 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4486
2a866e7b
PE
4487 * dbusbind.c: Don't possibly lose pointer info when converting.
4488 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4489 Use XPNTR rather than XHASH, so that the high-order bits of
4490 the pointer aren't lost when converting through void *.
4491
51639eac
PE
4492 * eval.c (Fautoload): Don't double-shift a pointer.
4493
92394119
PE
4494 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4495
dbdb9a7c
JB
44962011-05-06 Juanma Barranquero <lekktu@gmail.com>
4497
4498 * gnutls.c (DEF_GNUTLS_FN):
4499 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4500
db7a0b4f
AS
45012011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4502
4503 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4504 marker. (Bug#8610)
4505
f7ff1b0f 45062011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
4507
4508 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4509 New version that can reserve upto 2GB of heap space.
4510
f7ff1b0f 45112011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
4512
4513 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4514
639c109b
TZ
45152011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4516
4517 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4518 `gnutls_certificate_set_x509_key_file'.
4519
d2127135
JB
45202011-05-05 Juanma Barranquero <lekktu@gmail.com>
4521
4522 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4523 Update dependencies.
4524
e968f4f3
JB
45252011-05-04 Juanma Barranquero <lekktu@gmail.com>
4526
4527 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4528 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4529 Remove unused parameter `fildes'.
4530 * process.c (read_process_output, send_process): Don't pass it.
4531
84d358f0
JB
45322011-05-04 Juanma Barranquero <lekktu@gmail.com>
4533
4534 Fix previous change: the library cache is defined in w32.c.
4535 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4536 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4537
0898ca10
JB
45382011-05-04 Juanma Barranquero <lekktu@gmail.com>
4539
4540 Implement dynamic loading of GnuTLS on Windows.
4541
4542 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4543 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4544 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4545 Declare.
4546
4547 * gnutls.c (Qgnutls_dll): Define.
4548 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4549 (gnutls_*): Declare function pointers.
4550 (init_gnutls_functions): New function to initialize function pointers.
4551 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4552 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4553 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4554 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4555 (emacs_gnutls_write, emacs_gnutls_read)
4556 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4557 (Fgnutls_available_p): New function.
4558 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4559 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4560 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4561
4562 * image.c: Include w32.h.
4563 (Vimage_type_cache): Delete.
4564 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4565 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4566 (w32_delayed_load): Move to w32.c.
4567
4568 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4569
4570 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4571 (w32_delayed_load): Move from image.c. When loading a library, record
4572 its filename in the :loaded-from property of the library id.
4573 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4574 Initialize and staticpro them.
4575 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4576
4577 * process.c: Include lisp.h before w32.h, not after.
4578 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4579 instead of gnutls_record_check_pending.
4580
4581 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4582
ff4de4aa
TZ
45832011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4584
4585 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4586 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4587 as passed in.
4588
abe95abb
JD
45892011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4590
4591 * xterm.c (x_set_frame_alpha): Do not set property on anything
4592 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4593
e16e55d4
JB
45942011-05-02 Juanma Barranquero <lekktu@gmail.com>
4595
4596 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4597
bafcf6a5
JB
45982011-05-02 Juanma Barranquero <lekktu@gmail.com>
4599
4600 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4601 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4602 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4603 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4604 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4605 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4606 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4607 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4608 (Qgnutls_bootprop_callbacks_verify): Make static.
4609
e7a6747f
AS
46102011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4611
19ed11ba
AS
4612 * callproc.c: Indentation fixup.
4613
e7a6747f 4614 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
4615 (wait_for_termination, interruptible_wait_for_termination):
4616 Move after wait_for_termination_1.
e7a6747f 4617
1ef14cb4
LMI
46182011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4619
4620 * sysdep.c (interruptible_wait_for_termination): New function
4621 which is like wait_for_termination, but allows keyboard
4622 interruptions.
4623
4624 * callproc.c (Fcall_process): Add (:file "file") as an option for
4625 the STDOUT buffer.
4626 (Fcall_process_region): Ditto.
4627
330d880c
EZ
46282011-04-30 Eli Zaretskii <eliz@gnu.org>
4629
8db90b73
EZ
4630 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4631 rather than `XVECTOR (FOO)->size'.
4632
330d880c
EZ
4633 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4634 inttypes.h, as a gnulib replacement is used if it not available in
4635 system headers.
4636
15cbd324
EZ
46372011-04-21 Eli Zaretskii <eliz@gnu.org>
4638
4639 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4640 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4641 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4642
4643 * coding.c (coding_alloc_by_realloc): Error out if destination
4644 will grow beyond MOST_POSITIVE_FIXNUM.
4645 (decode_coding_emacs_mule): Abort if there isn't enough place in
4646 charbuf for the composition carryover bytes. Reserve an extra
4647 space for up to 2 characters produced in a loop.
4648 (decode_coding_iso_2022): Abort if there isn't enough place in
4649 charbuf for the composition carryover bytes.
4650
46512011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 4652
ae940cca
EZ
4653 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4654 aborting when %lld or %lll format is passed.
4655 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4656 %llo or %llx format is passed. (Bug#8545)
4657
03ab8921
EZ
4658 * window.c (window_scroll_line_based): Use a marker instead of
4659 simple variables to record original value of point. (Bug#7952)
4660
afda1437
EZ
4661 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4662 produced by %s or %c overflows available buffer space. (Bug#8545)
4663
f76dee0c
PE
46642011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4665
4666 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 4667 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 4668
fdc5744d
JB
46692011-04-28 Juanma Barranquero <lekktu@gmail.com>
4670
4671 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4672
638f053a
JB
46732011-04-28 Juanma Barranquero <lekktu@gmail.com>
4674
4675 * keyboard.c (Qdelayed_warnings_hook): Define.
4676 (command_loop_1): Run `delayed-warnings-hook'
4677 if Vdelayed_warnings_list is non-nil.
4678 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4679 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4680
d178f871
EZ
46812011-04-28 Eli Zaretskii <eliz@gnu.org>
4682
4683 * doprnt.c (doprnt): Don't return value smaller than the buffer
4684 size if the message was truncated. (Bug#8545).
4685
b124fd93
JB
46862011-04-28 Juanma Barranquero <lekktu@gmail.com>
4687
4688 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4689 (Fx_window_property): #if-0 the whole functions, not just the bodies.
4690
e810457d
PE
46912011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4692
4693 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4694
ea51cceb
JB
46952011-04-27 Juanma Barranquero <lekktu@gmail.com>
4696
4697 * makefile.w32-in: Update dependencies.
4698
94dcfacf
EZ
46992011-04-27 Eli Zaretskii <eliz@gnu.org>
4700
4701 Improve `doprnt' and its usage. (Bug#8545)
4702 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
4703 `format_end'. Remove support for %l as a conversion specifier.
4704 Don't use xrealloc. Improve diagnostics when the %l size modifier
4705 is used. Update the commentary.
4706
4707 * eval.c (verror): Simplify calculation of size_t.
4708
4709 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
4710 messages.
4711
f61f41d7
PE
47122011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
4713
4714 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
4715 change.
4716
96fb4434
PE
47172011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4718
4719 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
4720 This makes this file independent of the recent pseudovector change.
4721
671875da 47222011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 4723
69e9b5a3
PE
4724 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
4725
b5f869a7 4726 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 4727 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 4728 Remove unused local.
c8926152 4729 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 4730
841a1577 4731 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
4732 GCC 4.6.0 optimizes based on type-based alias analysis.
4733 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
4734 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
4735 != &v->size, and therefore "v->size = 1; b->size = 2; return
4736 v->size;" must therefore return 1. This assumption is incorrect
4737 for Emacs, since it type-puns struct Lisp_Vector * with many other
4738 types. To fix this problem, this patch adds a new type struct
f904488f 4739 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
4740 and pseudovectors, and helps optimizing compilers not get fooled
4741 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
4742 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
4743 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
4744 the size member.
eab3844f
PE
4745 (XSETPVECTYPE): Rewrite in terms of new macro.
4746 (XSETPVECTYPESIZE): New macro, specifying both type and size.
4747 This is a bit clearer, and further avoids the possibility of
4748 undesirable aliasing.
4749 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 4750 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
4751 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
4752 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
4753 (ASIZE): Now uses header.size rather than size.
4754 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
4755 to avoid the hassle of writing XVECTOR (foo)->header.size.
4756 (struct vectorlike_header): New type.
eab3844f
PE
4757 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
4758 object, to help avoid aliasing.
4759 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
4760 (SUBRP): Likewise, since Lisp_Subr is a special case.
4761 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
4762 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
4763 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 4764 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
4765 changed to be "header.size" and "header.next".
4766 * buffer.h (struct buffer): Likewise.
4767 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
4768 * frame.h (struct frame): Likewise.
4769 * process.h (struct Lisp_Process): Likewise.
4770 * termhooks.h (struct terminal): Likewise.
4771 * window.c (struct save_window_data, struct saved_window): Likewise.
4772 * window.h (struct window): Likewise.
4773 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
4774 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
4775 * buffer.c (init_buffer_once): Likewise.
4776 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
4777 special case.
4778 * process.c (Fformat_network_address): Use local var for size,
4779 for brevity.
4780
0df1eac5
PE
4781 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
4782
847ab9d1 4783 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
4784 * data.c (atof): Remove decl; no longer used or needed.
4785 (digit_to_number): Move to lread.c.
4786 (Fstring_to_number): Use new string_to_number function, to be
4787 consistent with how the Lisp reader treats infinities and NaNs.
4788 Do not assume that floating-point numbers represent EMACS_INT
4789 without losing information; this is not true on most 64-bit hosts.
4790 Avoid double-rounding errors, by insisting on integers when
4791 parsing non-base-10 numbers, as the documentation specifies.
4792 * lisp.h (string_to_number): New decl, replacing ...
4793 (isfloat_string): Remove.
bc0a5c13 4794 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 4795 (read1): Do not accept +. and -. as integers; this
452f4150
PE
4796 appears to have been a coding error. Similarly, do not accept
4797 strings like +-1e0 as floating point numbers. Do not report
4798 overflow for integer overflows unless the base is not 10 which
4799 means we have no simple and reliable way to continue.
4800 Break out the floating-point parsing into a new
4801 function string_to_number, so that Fstring_to_number parses
4802 floating point numbers consistently with the Lisp reader.
04f2d78b 4803 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
4804 (E_CHAR, EXP_INT): Remove, replacing with ...
4805 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
4806 (string_to_number): New function, replacing isfloat_string.
4807 This function checks for valid syntax and produces the resulting
4808 Lisp float number too. Rework it so that string-to-number
bc0a5c13 4809 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
4810 so that overflow for non-base-10 numbers is reported only when
4811 there's no portable and simple way to convert to floating point.
452f4150 4812
67769ffc
PE
4813 * textprop.c (set_text_properties_1): Rewrite for clarity,
4814 and to avoid GCC warning about integer overflow.
4815
c20db43f
PE
4816 * intervals.h (struct interval): Use EMACS_INT for members
4817 where EMACS_UINT might cause problems. See
4818 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
4819 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
4820 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
4821 All uses changed.
37aa2f85
PE
4822 (offset_intervals): Tell GCC not to worry about length overflow
4823 when negating a negative length.
c20db43f 4824
2538aa2f
PE
4825 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
4826 (overrun_check_free): Likewise.
4827
f2d3008d
PE
4828 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
4829 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
4830 word size.
4831
ec8df744
PE
4832 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4833 (gnutls_make_error): Rename local to avoid shadowing.
4834 (gnutls_emacs_global_deinit): ifdef out; not used.
4835 (Fgnutls_boot): Use const for pointer to readonly storage.
4836 Comment out unused local. Fix pointer signedness problems.
4837
640ee02d
PE
4838 * lread.c (openp): Don't stuff size_t into an 'int'.
4839 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4840 about possible signed overflow.
4841
6048fb2a
PE
4842 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4843 (GDK_KEY_g): Don't define if already defined.
4844 (xg_prepare_tooltip): Avoid pointer signedness problem.
4845 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
4846
fa3c87e1
PE
4847 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4848 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4849
2172544b
PE
4850 * xfns.c (Fx_window_property): Simplify a bit,
4851 to make a bit faster and to avoid GCC 4.6.0 warning.
4852 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4853
9b821a21
PE
4854 * fns.c (internal_equal): Don't assume size_t fits in int.
4855
3c616cfa
PE
4856 * alloc.c (compact_small_strings): Tighten assertion a little.
4857
c2982e87
PE
4858 Replace pEd with more-general pI, and fix some printf arg casts.
4859 * lisp.h (pI): New macro, generalizing old pEd macro to other
4860 conversion specifiers. For example, use "...%"pI"d..." rather
4861 than "...%"pEd"...".
4862 (pEd): Remove. All uses replaced with similar uses of pI.
4863 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4864 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4865 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4866 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4867 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4868 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4869 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4870 64-bit hosts.
4871 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4872 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4873 * print.c (safe_debug_print, print_object): Likewise.
4874 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4875 to int.
6f04d126
PE
4876 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4877 avoiding the 0 flag, which is not portable.
c2982e87
PE
4878 * process.c (Fmake_network_process): Use pI to avoid cast.
4879 * region-cache.c (pp_cache): Likewise.
4880 * xdisp.c (decode_mode_spec): Likewise.
4881 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4882 behavior on 64-bit hosts with printf arg.
6f04d126 4883 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
4884 (x_stop_queuing_selection_requests): Likewise.
4885 (x_get_window_property): Don't truncate byte count to an 'int'
4886 when tracing.
0b432f21 4887
5e073ec7
PE
4888 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4889 here, since it parses constructs like leading '-' and spaces,
4890 which are not wanted; and it overflows with large numbers.
4891 Instead, simply match F[0-9]+, which is what is wanted anyway.
4892
36372bf9
PE
4893 * alloc.c: Remove unportable assumptions about struct layout.
4894 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4895 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4896 (allocate_vectorlike, make_pure_vector): Use the new macros,
4897 plus offsetof, to remove unportable assumptions about struct layout.
4898 These assumptions hold on all porting targets that I know of, but
4899 they are not guaranteed, they're easy to remove, and removing them
4900 makes further changes easier.
4901
0b432f21
PE
4902 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4903 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
4904 (string_overrun_cookie): Now const. Use initializers that
4905 don't formally overflow signed char, to avoid warnings.
000098c1
PE
4906 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
4907 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
4908 (allocate_buffer): Don't assume sizeof (struct buffer) is a
4909 multiple of sizeof (EMACS_INT); it need not be, if
4910 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 4911 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 4912
895009e1
JB
49132011-04-26 Juanma Barranquero <lekktu@gmail.com>
4914
4915 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
4916
6a7a1b0b
TZ
49172011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
4918
4919 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 4920 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
4921 Reported by Paul Eggert <eggert@cs.ucla.edu>.
4922
841a1577 49232011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
4924
4925 * lisp.h (Qdebug): List symbol.
895009e1 4926 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
4927 * keyboard.c (debug-on-event): New variable.
4928 (handle_user_signal): Break into debugger when debug-on-event
4929 matches the current signal symbol.
4930
f2d3ba6f
DN
49312011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
4932
4933 * alloc.c (check_sblock, check_string_bytes)
4934 (check_string_free_list): Convert to standard C.
4935
42ce4c63
TZ
49362011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
4937
4938 * w32.c (emacs_gnutls_push): Fix typo.
4939
825cd63c
EZ
49402011-04-25 Eli Zaretskii <eliz@gnu.org>
4941
fb11d64d
EZ
4942 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
4943 "cast to pointer from integer of different size".
4944
825cd63c
EZ
4945 Improve doprnt and its use in verror. (Bug#8545)
4946 * doprnt.c (doprnt): Document the set of format control sequences
4947 supported by the function. Use SAFE_ALLOCA instead of always
4948 using `alloca'.
4949
4950 * eval.c (verror): Don't limit the buffer size at size_max-1, that
4951 is one byte too soon. Don't use xrealloc; instead xfree and
4952 xmalloc anew.
4953
e061a11b
TZ
49542011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
4955
4956 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
4957 callbacks stage.
4958
4959 * gnutls.c: Renamed global_initialized to
4960 gnutls_global_initialized. Added internals for the
4961 :verify-hostname-error, :verify-error, and :verify-flags
4962 parameters of `gnutls-boot' and documented those parameters in the
4963 docstring. Start callback support.
9173deec
JB
4964 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
4965 unless a fatal error occurred. Call gnutls_alert_send_appropriate
4966 on error. Return error code.
e061a11b
TZ
4967 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
4968 (emacs_gnutls_read): Likewise.
4969 (Fgnutls_boot): Return handshake error code.
4970 (emacs_gnutls_handle_error): New function.
4971 (wsaerror_to_errno): Likewise.
4972
4973 * w32.h (emacs_gnutls_pull): Add prototype.
4974 (emacs_gnutls_push): Likewise.
4975
4976 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
4977 (emacs_gnutls_push): Likewise.
4978
49792011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
4980
4981 * process.c (wait_reading_process_output): Check if GnuTLS
4982 buffered some data internally if no FDs are set for TLS
4983 connections.
4984
4985 * makefile.w32-in (OBJ2): Add gnutls.$(O).
4986 (LIBS): Link to USER_LIBS.
4987 ($(BLD)/gnutls.$(0)): New target.
4988
fa6996bc
EZ
49892011-04-24 Eli Zaretskii <eliz@gnu.org>
4990
eb35682e
EZ
4991 * xdisp.c (handle_single_display_spec): Rename the
4992 display_replaced_before_p argument into display_replaced_p, to
4993 make it consistent with the commentary. Fix typos in the
4994 commentary.
4995
e2ad650c
EZ
4996 * textprop.c (syms_of_textprop): Remove dead code.
4997 (copy_text_properties): Delete obsolete commentary about an
4998 interface that was deleted long ago. Fix typos in the description
4999 of arguments.
5000
1b2de274
EZ
5001 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5002 to changes in oldXMenu/XMenu.h from 2011-04-16.
5003 <menu_help_message, prev_menu_help_message>: Constify.
5004 (IT_menu_make_room): menu->help_text is now `const char **';
5005 adjust.
5006
5007 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5008 to changes in oldXMenu/XMenu.h from 2011-04-16.
5009 (struct XMenu): Declare `help_text' `const char **'.
5010
5011 * xfaces.c <Qunspecified>: Make extern again.
5012
5013 * syntax.c: Include sys/types.h before including regex.h, as
5014 required by Posix.
5015
762b15be
EZ
5016 * doc.c (get_doc_string): Improve the format passed to `error'.
5017
5018 * doprnt.c (doprnt): Improve commentary.
5019
5020 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5021
5022 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5023 them with etags.
5024
f1052e5d
EZ
5025 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5026 changes in globals.h immediately force recompilation.
762b15be
EZ
5027 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5028 $(CURDIR)/s/ms-w32.h.
5029 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 5030
fa6996bc
EZ
5031 * character.c (Fchar_direction): Function deleted.
5032 (syms_of_character): Don't defsubr it.
5033 <char-direction-table>: Deleted.
5034
e6c3da20
EZ
50352011-04-23 Eli Zaretskii <eliz@gnu.org>
5036
5037 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5038 * doprnt.c: Include limits.h.
5039 (SIZE_MAX): New macro.
04f2d78b
CB
5040 (doprnt): Return a size_t value. 2nd arg is now size_t.
5041 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
5042 Improve overflow protection. Support `l' modifier for integer
5043 conversions. Support %l conversion. Don't assume an EMACS_INT
5044 argument for integer conversions and for %c.
5045
5046 * lisp.h (doprnt): Restore prototype.
5047
5048 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5049 $(SRC)/character.h.
5050
5051 * Makefile.in (base_obj): Add back doprnt.o.
5052
5053 * deps.mk (doprnt.o): Add back prerequisites.
5054 (callint.o): Depend on character.h.
5055
5056 * eval.c (internal_lisp_condition_case): Include the handler
5057 representation in the error message.
5058 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5059 when breaking from the loop.
5060
5061 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5062
5063 * callint.c (Fcall_interactively): When displaying error message
5064 about invalid control letter, pass the character's codepoint, not
5065 a pointer to its multibyte form. Improve display of the character
5066 in octal and display also its hex code.
5067
5068 * character.c (char_string): Use %x to display the (unsigned)
5069 codepoint of an invalid character, to avoid displaying a bogus
5070 negative value.
5071
5072 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5073 `error', not SYMBOL_NAME itself.
5074
5075 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5076 character arguments to `error'.
5077
5078 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5079 to `error' in error message about FINAL_CHAR argument. Make sure
5080 FINAL_CHAR is a character, and use %c when it is passed as
5081 argument to `error'.
5082
4ffd0d6b 50832011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
5084
5085 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5086
5087 * w32.c: Include <time.h>.
5088 (sys_localtime): New function.
5089
4ffd0d6b 50902011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
5091
5092 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5093
4ffd0d6b 5094 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 5095
4ffd0d6b 50962011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 5097
4ffd0d6b
GM
5098 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5099 zombies (Bug#8467).
aac0c6e3 5100
04c56954
EZ
51012011-04-19 Eli Zaretskii <eliz@gnu.org>
5102
5103 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5104 gl_state.e_property when gl_state.object is Qt.
5105
5106 * insdel.c (make_gap_larger): Remove limitation of buffer size
5107 to <= INT_MAX.
5108
16a43933
CY
51092011-04-18 Chong Yidong <cyd@stupidchicken.com>
5110
5111 * xdisp.c (lookup_glyphless_char_display)
5112 (produce_glyphless_glyph): Handle cons cell entry in
5113 glyphless-char-display.
5114 (Vglyphless_char_display): Document it.
5115
5116 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5117 glyphless-char-display.
5118
4581706e
CY
51192011-04-17 Chong Yidong <cyd@stupidchicken.com>
5120
5121 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5122
5123 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5124
5125 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5126 definition for no-X builds.
5127
4887c6e2 51282011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 5129
fd35b6f9
PE
5130 Static checks with GCC 4.6.0 and non-default toolkits.
5131
5c1ccb01
PE
5132 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5133
006c5daa
PE
5134 * process.c (keyboard_bit_set): Define only if SIGIO.
5135 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5136 (send_process): Repair possible setjmp clobbering.
5137
efc736d3
PE
5138 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5139
4e2fe2e6
PE
5140 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5141
f97334a2
PE
5142 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5143
4e75f29d
PE
5144 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5145 Define only if needed.
5146
90efadd1
PE
5147 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5148 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 5149 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 5150
3c647824
PE
5151 * dispextern.h (struct redisplay_interface): Rename param
5152 to avoid shadowing.
e264f262 5153 * termhooks.h (struct terminal): Likewise.
761383f4 5154 * xterm.c (xembed_send_message): Likewise.
3c647824 5155
b58c5c4a
PE
5156 * insdel.c (make_gap_smaller): Define only if
5157 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5158
cad59032
PE
5159 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5160 it.
5161
c339dc2e
PE
5162 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5163 so that we aren't warned about unused symbols.
5164
91a3e27b
PE
5165 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5166
399c71d3 5167 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 5168
8ffc96f5
PE
5169 * xfns.c (x_real_positions): Mark locals as initialized.
5170
eef9bc79
PE
5171 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5172
098db9dd
PE
5173 * xterm.c: Fix problems found by static analysis with other toolkits.
5174 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
5175 (x_dispatch_event): Declare static if USE_GTK, and
5176 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 5177 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 5178 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
5179 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5180 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 5181
eb18f6cc
PE
5182 * xmenu.c (menu_help_callback): Pointer type fixes.
5183 Use const pointers when pointing at readonly data. Avoid pointer
5184 signedness clashes.
5185 (FALSE): Remove unused macro.
5186 (update_frame_menubar): Remove unused decl.
5187
1fe72bf8
PE
5188 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5189
60d9e1db
PE
5190 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5191 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5192 (single_menu_item): Rename local to avoid shadowing.
5193
39261c26
PE
5194 * keyboard.c (make_lispy_event): Remove unused local var.
5195
018c5e19
PE
5196 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5197 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5198
63d2b86e
PE
5199 * bitmaps: Change bitmaps from unsigned char back to the X11
5200 compatible char. Avoid the old compiler warnings about
5201 out-of-range initializers by using, for example, '\xab' rather
5202 than 0xab.
5203
aefd87e1
PE
5204 * xgselect.c (xgselect_initialize): Check vs interface
5205 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5206
bf501fb9
PE
5207 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5208
e9829fdf
PE
5209 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5210 to read-only memory.
5211
1086c095
PE
5212 * fns.c (vector): Remove; this old hack is no longer needed.
5213
2baccd04 5214 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 5215 Remove unused var.
dde42981 5216 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 5217
72391843 5218 * xrdb.c (x_load_resources): Omit unused local.
3565b346 5219
436c16df 5220 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 5221 (x_window): Rename locals to avoid shadowing.
dc5ddd85 5222 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 5223
92bb796d 5224 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 5225 (x_term_init): Remove local to avoid shadowing.
92bb796d 5226
764430a3 5227 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
5228
5229 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5230 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5231
d1dfb56c
EZ
52322011-04-16 Eli Zaretskii <eliz@gnu.org>
5233
c4354cb4
EZ
5234 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5235
d1dfb56c
EZ
5236 Fix regex.c, syntax.c and friends for buffers > 2GB.
5237 * syntax.h (struct gl_state_s): Declare character position members
5238 EMACS_INT.
5239
5240 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5241
04f2d78b
CB
5242 * textprop.c (verify_interval_modification, interval_of):
5243 Declare arguments EMACS_INT.
d1dfb56c
EZ
5244
5245 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5246 EMACS_INT.
5247
5248 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5249
5250 * indent.c (Fvertical_motion): Local variable it_start is now
5251 EMACS_INT.
5252
5253 * regex.c (re_match, re_match_2, re_match_2_internal)
5254 (bcmp_translate, regcomp, regexec, print_double_string)
5255 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5256 (re_compile_pattern, re_exec): Declare arguments and local
5257 variables `size_t' and `ssize_t' and return values `regoff_t', as
5258 appropriate.
5259 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5260 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5261 <compile_stack_type>: `size' and `avail' are now `size_t'.
5262
5263 * regex.h <regoff_t>: Use ssize_t, not int.
5264 (re_search, re_search_2, re_match, re_match_2): Arguments that
5265 specify buffer/string position and length are now ssize_t and
5266 size_t. Return type is regoff_t.
5267
613052cd
BK
52682011-04-16 Ben Key <bkey76@gmail.com>
5269
5270 * nsfont.m: Fixed bugs in ns_get_family and
5271 ns_descriptor_to_entity that were caused by using free to
5272 deallocate memory blocks that were allocated by xmalloc (via
5273 xstrdup). This caused Emacs to crash when compiled with
5274 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5275 --enable-checking=xmallocoverrun). xfree is now used to
5276 deallocate these memory blocks.
5277
4170f62f 52782011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 5279
71b41406
PE
5280 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5281
9587a89d
PE
5282 emacs_write: Accept and return EMACS_INT for sizes.
5283 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5284 et seq.
5285 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5286 Accept and return EMACS_INT.
5287 (emacs_gnutls_write): Return the number of bytes written on
5288 partial writes.
5289 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
5290 (emacs_read, emacs_write): Remove check for negative size, as the
5291 Emacs source code has been audited now.
9587a89d
PE
5292 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5293 (emacs_read, emacs_write): Use it.
273a5f82
PE
5294 * process.c (send_process): Adjust to the new signatures of
5295 emacs_write and emacs_gnutls_write. Do not attempt to store
5296 a byte offset into an 'int'; it might overflow.
9587a89d 5297 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 5298
3e047f51
PE
5299 * sound.c: Don't assume sizes fit in 'int'.
5300 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 5301 Return EMACS_INT, not int.
3e047f51 5302 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
5303 Accept EMACS_INT, not int.
5304 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
5305 record read return values.
5306
cc39a9db
BK
53072011-04-15 Ben Key <bkey76@gmail.com>
5308
c9d0ec6d
JB
5309 * keyboard.c (Qundefined): Don't declare static since it is used
5310 in nsfns.m.
5311 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5312 static since they are used in nsfont.m.
cc39a9db 5313
6c60eb9f
SM
53142011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5315
5316 * process.c (Qprocessp): Don't declare static.
5317 * lisp.h (Qprocessp): Declare again.
5318
7990b61a
JB
53192011-04-15 Juanma Barranquero <lekktu@gmail.com>
5320
5321 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5322
5d4cb038
PE
53232011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5324
8bd7b830 5325 Improve C-level modularity by making more things 'static'.
cd64ea1d 5326
e3b27b31
PE
5327 Don't publish debugger-only interfaces to other modules.
5328 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5329 (verify_bytepos, count_markers): Move decls to the only modules
5330 that need them.
5331 * region-cache.h (pp_cache): Likewise.
5332 * window.h (check_all_windows): Likewise.
5333 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5334
5d4cb038
PE
5335 * sysdep.c (croak): Now static, if
5336 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5337 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
5338
5339 * alloc.c (refill_memory_reserve): Now static if
5340 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5341 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 5342
e87b6180
PE
5343 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5344 Define only if USE_LUCID.
5345
ac64929e
PE
5346 * xrdb.c (x_customization_string, x_rm_string): Now static.
5347
6f37259d
PE
5348 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5349 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5350
1683e3ab
PE
5351 * xdisp.c (draw_row_with_mouse_face): Now static.
5352 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5353
de9c2632
PE
5354 * window.h (check_all_windows): Mark externally visible.
5355
2b96acb7
PE
5356 * window.c (window_deletion_count): Now static.
5357
5358 * undo.c: Make symbols static if they're not exported.
5359 (last_undo_buffer, last_boundary_position, pending_boundary):
5360 Now static.
5361
50436f33
PE
5362 * textprop.c (interval_insert_behind_hooks): Now static.
5363 (interval_insert_in_front_hooks): Likewise.
5364
64520e5c
PE
5365 * term.c: Make symbols static if they're not exported.
5366 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5367 (max_frame_lines, tty_set_terminal_modes):
5368 (tty_reset_terminal_modes, tty_turn_off_highlight):
5369 (get_tty_terminal): Now static.
5370 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5371 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 5372 HAVE_WINDOW_SYSTEM.
64520e5c
PE
5373 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5374 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5375
1fa53021
PE
5376 * sysdep.c: Make symbols static if they're not exported.
5377 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5378 Now static.
5379 (sigprocmask_set, full_mask): Remove; unused.
5380 (wait_debugging): Mark as visible.
5381 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5382 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5383
d4b43b22
PE
5384 * syntax.c (syntax_temp): Define only if !__GNUC__.
5385
b7c513d0
PE
5386 * sound.c (current_sound_device, current_sound): Now static.
5387
989b29ad
PE
5388 * search.c (searchbufs, searchbuf_head): Now static.
5389
13a55a78
PE
5390 * scroll.c (scroll_cost): Remove; unused.
5391 * dispextern.h (scroll_cost): Remove decl.
5392
de68a1fc
PE
5393 * region-cache.h (pp_cache): Mark as externally visible.
5394
40ccffa6
PE
5395 * process.c: Make symbols static if they're not exported.
5396 (process_tick, update_tick, create_process, chan_process):
5397 (Vprocess_alist, proc_buffered_char, datagram_access):
5398 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5399 (deactivate_process): Mark defn as static, as well as decl.
5400 * lisp.h (create_process): Remove decl.
5401 * process.h (chan_process, Vprocess_alist): Remove decls.
5402
ad64fc97
PE
5403 * print.c: Make symbols static if they're not exported.
5404 (print_depth, new_backquote_output, being_printed, print_buffer):
5405 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5406 (print_interval, print_number_index, initial_stderr_stream):
5407 Now static.
5408 * lisp.h (Fprinc): Remove decl.
5409 (debug_output_compilation_hack): Mark as externally visible.
5410
adddb265
PE
5411 * sysdep.c (croak): Move decl from here to syssignal.h.
5412 * syssignal.h (croak): Put it here, so the API can be checked when
5413 'croak' is called from dissociate_if_controlling_tty.
5414
1717ede2
PE
5415 * minibuf.c: Make symbols static if they're not exported.
5416 (minibuf_save_list, choose_minibuf_frame): Now static.
5417 * lisp.h (choose_minibuf_frame): Remove decl.
5418
fa5fb2bc
PE
5419 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5420
1e3890d1
PE
5421 * lread.c: Make symbols static if they're not exported.
5422 (read_objects, initial_obarray, oblookup_last_bucket_number):
5423 Now static.
5424 (make_symbol): Remove; unused.
5425 * lisp.h (initial_obarray, make_symbol): Remove decls.
5426
8a1414fa
PE
5427 * keyboard.c: Make symbols static if they're not exported.
5428 (single_kboard, recent_keys_index, total_keys, recent_keys):
5429 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5430 (this_single_command_key_start, echoing, last_auto_save):
5431 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5432 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5433 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5434 (Vlispy_mouse_stem, double_click_count):
5435 Now static.
5436 (force_auto_save_soon): Define only if SIGDANGER.
5437 (ignore_mouse_drag_p): Now static if
5438 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5439 (print_help): Remove; unused.
5440 (stop_character, last_timer_event): Mark as externally visible.
5441 * keyboard.h (ignore_mouse_drag_p): Declare only if
5442 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5443 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5444 * lisp.h (echoing): Remove decl.
5445 (force_auto_save_soon): Declare only if SIGDANGER.
5446 * xdisp.c (redisplay_window): Simplify code, to make it more
5447 obvious that ignore_mouse_drag_p is not accessed if !defined
5448 USE_GTK && !defined HAVE_NS.
5449
93ea6e8f
PE
5450 * intervals.c: Make symbols static if they're not exported.
5451 (merge_properties_sticky, merge_interval_right, delete_interval):
5452 Now static.
5453 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5454
77382fcc
PE
5455 * insdel.c: Make symbols static if they're not exported.
5456 However, leave prepare_to_modify_buffer alone. It's never
5457 called from outside this function, but that appears to be a bug.
5458 (combine_after_change_list, combine_after_change_buffer):
4889fc82 5459 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
5460 (adjust_after_replace_noundo): Remove; unused.
5461 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 5462 (signal_before_change): Remove decls.
77382fcc 5463
9306c32e
PE
5464 * indent.c (val_compute_motion, val_vmotion): Now static.
5465
cd44d2eb
PE
5466 * image.c: Make symbols static if they're not exported.
5467 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5468 if USE_GTK.
5469 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5470 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5471
ad9a7a06
PE
5472 * fringe.c (standard_bitmaps): Now static.
5473 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5474
81626931
PE
5475 * frame.c: Make symbols static if they're not exported.
5476 (x_report_frame_params, make_terminal_frame): Now static.
5477 (get_frame_param): Now static, unless HAVE_NS.
5478 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5479 (x_get_resource_string): Remove; not used.
5480 * frame.h (make_terminal_frame, x_report_frame_params):
5481 (x_get_resource_string); Remove decls.
5482 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5483 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5484
239f9db9
PE
5485 * font.c, fontset.c: Make symbols static if they're not exported.
5486 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5487 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5488 * font.c (font_close_object): Now static.
5489 * font.h (font_close_object): Remove.
5490 * fontset.c (FONTSET_OBJLIST): Remove.
5491 (free_realized_fontset) #if-0 the body, which does nothing.
5492 (face_suitable_for_char_p): #if-0, as it's never called.
5493 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
5494 * xfaces.c (face_at_string_position):
5495 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
5496 since 0 is always ASCII.
5497
dfcf3579
PE
5498 * fns.c (weak_hash_tables): Now static.
5499
5045092b
PE
5500 * fileio.c: Make symbols static if they're not exported.
5501 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5502 (Vwrite_region_annotation_buffers): Now static.
5503
57a96f5c
PE
5504 * eval.c: Make symbols static if they're not exported.
5505 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5506 * lisp.h (backtrace_list): Remove decl.
5507
35f08c38
PE
5508 * emacs.c: Make symbols static if they're not exported.
5509 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5510 (fatal_error_code, fatal_error_signal_hook, standard_args):
5511 Now static.
5512 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5513 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5514 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5515 * lisp.h (fatal_error_signal_hook): Remove decl.
5516 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5517
f44bd759
PE
5518 * editfns.c: Move a (normally-unused) function to its only use.
5519 * editfns.c, lisp.h (get_operating_system_release): Remove.
5520 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5521 worth the hassle of breaking this out.
5522
b532497d
PE
5523 * xterm.c: Make symbols static if they're not exported.
5524 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5525 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5526 (x_destroy_window, x_delete_display):
5527 Now static.
5528 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5529 (x_mouse_leave): Remove; unused.
5530 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5531 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5532 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5533 Remove decls.
5534 (x_mouse_leave): Declare only if WINDOWSNT.
5535 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5536 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5537 USE_X_TOOLKIT.
5538
1675728f
PE
5539 * ftxfont.c: Make symbols static if they're not exported.
5540 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5541 HAVE_FREETYPE.
5542 * font.h (ftxfont_driver): Likewise.
5543
e4cebfca
PE
5544 * xfns.c: Make symbols static if they're not exported.
5545 (x_last_font_name, x_display_info_for_name):
5546 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5547 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5548 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5549 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5550 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5551 (last_show_tip_args): Now static.
5552 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5553 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5554 (x_screen_planes): Remove; unused.
5555 * dispextern.h (x_screen_planes): Remove decl.
5556
5bf46f05
PE
5557 * dispnew.c: Make symbols static if they're not exported.
5558 * dispextern.h (redraw_garbaged_frames, scrolling):
5559 (increment_row_positions): Remove.
5560 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5561 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5562 Now static.
5563 (redraw_garbaged_frames): Remove; unused.
5564
435f4c28
PE
5565 * xfaces.c: Make symbols static if they're not exported.
5566 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5567 Remove decls.
5568 * xterm.h (defined_color): Remove decls.
5569 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5570 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5571 (menu_face_changed_default, defined_color, free_realized_face):
5572 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5573 (ascii_face_of_lisp_face): Remove; unused.
5574
8524aef3
PE
5575 * xdisp.c: Make symbols static if they're not exported.
5576 * dispextern.h (scratch_glyph_row, window_box_edges):
5577 (glyph_to_pixel_coords, set_cursor_from_row):
5578 (get_next_display_element, set_iterator_to_next):
5579 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5580 (show_mouse_face): Remove decls
5581 * frame.h (message_buf_print): Likewise.
5582 * lisp.h (pop_message, set_message, check_point_in_composition):
5583 Likewise.
5584 * xterm.h (set_vertical_scroll_bar): Likewise.
5585 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5586 (message_buf_print, scratch_glyph_row, displayed_buffer):
5587 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5588 (get_next_display_element, show_mouse_face, window_box_edges):
5589 (frame_to_window_pixel_xy, check_point_in_composition):
5590 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5591 (glyph_to_pixel_coords): Remove; unused.
5592
16390cd2
PE
5593 * dired.c (file_name_completion): Now static.
5594
5595 * dbusbind.c (xd_in_read_queued_messages): Now static.
5596
a25f4dfa
PE
5597 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5598 * data.c (circular_list_error): Remove.
5599
14a9c8df
PE
5600 * commands.h (last_point_position, last_point_position_buffer):
5601 (last_point_position_window): Remove decls.
5602 * keyboard.c: Make these variables static.
5603
04f2d78b
CB
5604 * coding.h (coding, code_convert_region, encode_coding_gap):
5605 Remove decls.
74ab6df5
PE
5606 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5607 (iso_code_class, detect_coding, code_convert_region): Now static.
5608 (encode_coding_gap): Remove; unused.
5609
38dfbee1
PE
5610 * chartab.c (chartab_chars, chartab_bits): Now static.
5611
a2cb4e63
PE
5612 * charset.h (charset_iso_8859_1): Remove decl.
5613 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5614 Now static.
5615
127198fd
PE
5616 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5617 * ccl.c (Vccl_program_table): Now static.
5618 (check_ccl_update): Remove; unused.
5619
d85b608f
PE
5620 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5621 * category.h: ... from here.
5622 * category.c (check_category_table, set_category_set): Now static.
5623
31cd66f3
PE
5624 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5625 * lisp.h: Remove these decls.
5626
c358e587
PE
5627 * buffer.c (buffer_count): Remove unused var.
5628
e78aecca
PE
5629 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5630 so that it's not optimized away.
5631 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5632 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5633 exported only to the debugger.
5634
e192d7d3 5635 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 5636 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 5637
92470028
PE
5638 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5639 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5640 was inaccessible from Lisp.
5641 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5642 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5643
244ed907
PE
5644 alloc.c: Import and export fewer symbols, and remove unused items.
5645 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5646 is defined.
5647 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5648 it's not optimized away by whole-program optimization.
5649 (message_enable_multibyte, free_misc): Remove.
5650 (catchlist, handlerlist, mark_backtrace):
5651 Declare only if BYTE_MARK_STACK.
5652 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5653 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5654 (message_enable_multibyte): Remove decl.
5655 (free_misc, interval_free_list, float_block, float_block_index):
5656 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5657 (cons_free_list, last_marked_index):
5658 Now static.
5659 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5660 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5661 (mark_backtrace): Define only if BYTE_MARK_STACK.
5662 * xdisp.c (message_enable_multibyte): Now static.
5663
61c2b50e 5664 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
5665 This makes it easier for human readers (and static analyzers)
5666 to see whether these variables are used from other modules.
5667 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5668 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5669 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5670 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5671 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5672 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5673 * xmenu.c, xselect.c:
5674 Declare Q* vars static if they are not used in other modules.
5675 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5676 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5677 Remove decls of unexported vars.
5678 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5679
95c82688
PE
5680 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5681
16a97296
PE
5682 Make Emacs functions such as Fatom 'static' by default.
5683 This makes it easier for human readers (and static analyzers)
5684 to see whether these functions can be called from other modules.
5685 DEFUN now defines a static function. To make the function external
5686 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
5687 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5688 (Finit_image_library):
16a97296
PE
5689 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5690 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
5691 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
5692 Remove decls, since these functions are now static.
5693 (Funintern, Fget_internal_run_time): New decls, since these functions
5694 were already external.
95c82688 5695
16a97296
PE
5696 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
5697 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
5698 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
5699 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
5700 * keyboard.c, keymap.c, lread.c:
5701 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
5702 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
5703 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
5704 Mark functions with DEFUE instead of DEFUN,
5705 if they are used in other modules.
5706 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
5707 decls for now-static functions.
5708 * buffer.h (Fdelete_overlay): Remove decl.
5709 * callproc.c (Fgetenv_internal): Mark as internal.
5710 * composite.c (Fremove_list_of_text_properties): Remove decl.
5711 (Fcomposition_get_gstring): New forward static decl.
5712 * composite.h (Fcomposite_get_gstring): Remove decl.
5713 * dired.c (Ffile_attributes): New forward static decl.
5714 * doc.c (Fdocumntation_property): New forward static decl.
5715 * eval.c (Ffetch_bytecode): New forward static decl.
5716 (Funintern): Remove extern decl; now in .h file where it belongs.
5717 * fileio.c (Fmake_symbolic_link): New forward static decl.
5718 * image.c (Finit_image_library): New forward static decl.
5719 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
5720 * intervals.h (Fprevious_property_change):
5721 (Fremove_list_of_text_properties): Remove decls.
5722 * keyboard.c (Fthis_command_keys): Remove decl.
5723 (Fcommand_execute): New forward static decl.
5724 * keymap.c (Flookup_key): New forward static decl.
5725 (Fcopy_keymap): Now static.
5726 * keymap.h (Flookup_key): Remove decl.
5727 * process.c (Fget_process): New forward static decl.
5728 (Fprocess_datagram_address): Mark as internal.
5729 * syntax.c (Fsyntax_table_p): New forward static decl.
5730 (skip_chars): Remove duplicate decl.
5731 * textprop.c (Fprevious_property_change): New forward static decl.
5732 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
5733 Now internal.
5734 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
5735 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
5736
785bbd42
PE
5737 * editfns.c (Fformat): Remove unreachable code.
5738
8b913b57
AS
57392011-04-14 Andreas Schwab <schwab@linux-m68k.org>
5740
5741 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
5742 change. (Bug#8496)
5743
a6744a35
EZ
57442011-04-13 Eli Zaretskii <eliz@gnu.org>
5745
5746 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
5747 when at ZV. (Bug#8487)
5748
e7974947
AS
57492011-04-12 Andreas Schwab <schwab@linux-m68k.org>
5750
baad03f0
AS
5751 * charset.c (Fclear_charset_maps): Use xfree instead of free.
5752 (Bug#8437)
5753 * keyboard.c (parse_tool_bar_item): Likewise.
5754 * sound.c (sound_cleanup, alsa_close): Likewise.
5755 * termcap.c (tgetent): Likewise.
5756 * xfns.c (x_default_font_parameter): Likewise.
5757 * xsettings.c (read_and_apply_settings): Likewise.
5758
e7974947
AS
5759 * alloc.c (overrun_check_malloc, overrun_check_realloc)
5760 (overrun_check_free): Protoize.
5761
28272684
PE
57622011-04-12 Paul Eggert <eggert@cs.ucla.edu>
5763
5764 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
5765 since callers should never pass a negative size.
5766 Change the signature to match that of plain 'read' and 'write'; see
5767 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
5768 * lisp.h: Update prototypes of emacs_write and emacs_read.
5769
11997c76
EZ
57702011-04-11 Eli Zaretskii <eliz@gnu.org>
5771
5772 * xdisp.c (redisplay_window): Don't try to determine the character
5773 position of the scroll margin if the window start point w->startp
e896f03c 5774 is outside the buffer's accessible region. (Bug#8468)
11997c76 5775
8a2cbd72
EZ
57762011-04-10 Eli Zaretskii <eliz@gnu.org>
5777
5778 Fix write-region and its subroutines for buffers > 2GB.
5779 * fileio.c (a_write, e_write): Modify declaration of arguments and
5780 local variables to support buffers larger than 2GB.
5781 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
5782
5783 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
5784 argument, local variables, and return value.
5785
5786 * lisp.h: Update prototypes of emacs_write and emacs_read.
5787
5788 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
5789
4073e537 57902011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 5791
1ebfdcb6
PE
5792 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
5793
b2ded58d
PE
5794 Fix more problems found by GCC 4.6.0's static checks.
5795
7d66342c
PE
5796 * xdisp.c (vmessage): Use a better test for character truncation.
5797
bbf47d44
PE
5798 * charset.c (load_charset_map): <, not <=, for optimization,
5799 and to avoid potential problems with integer overflow.
9248994d 5800 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 5801 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 5802 * editfns.c (Fformat): Likewise.
1e69125e 5803 * syntax.c (skip_chars): Likewise.
3befa583 5804
e3019616
PE
5805 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
5806 This also lets GCC 4.6.0 generate slightly better loop code.
5807
becfa255
PE
5808 * callint.c (Fcall_interactively): <, not <=, for optimization.
5809 (Fcall_interactively): Count the number of arguments produced,
5810 not the number of arguments given. This is simpler and lets GCC
5811 4.6.0 generate slightly better code.
5812
dae0cd48
PE
5813 * ftfont.c: Distingish more carefully between FcChar8 and char.
5814 The previous code passed unsigned char * to a functions like
5815 strlen and xstrcasecmp that expect char *, which does not
5816 conform to the C standard.
5817 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
5818 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
5819 char * when the C standard requires it.
5820
76032d70
PE
5821 * keyboard.c (read_char): Remove unused var.
5822
eb3f1cc8
PE
5823 * eval.c: Port to Windows vsnprintf (Bug#8435).
5824 Include <limits.h>.
5825 (SIZE_MAX): Define if the headers do not.
5826 (verror): Do not give up if vsnprintf returns a negative count.
5827 Instead, grow the buffer. This ports to Windows vsnprintf, which
5828 does not conform to C99. Problem reported by Eli Zaretskii.
5829 Also, simplify the allocation scheme, by avoiding the need for
5830 calling realloc, and removing the ALLOCATED variable.
5831
70476b54
PE
5832 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5833
12020a9e
PE
5834 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5835 But keep the doprint source code for now, as we might revamp it
5836 and use it again (Bug#8435).
ea6c7ae6
PE
5837 * lisp.h (doprnt): Remove.
5838 * Makefile.in (base_obj): Remove doprnt.o.
5839 * deps.mk (doprnt.o): Remove.
5840
5fdb398c
PE
5841 error: Print 32- and 64-bit integers portably (Bug#8435).
5842 Without this change, on typical 64-bit hosts error ("...%d...", N)
5843 was used to print both 32- and 64-bit integers N, which relied on
5844 undefined behavior.
5845 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
5846 New macro.
5847 * lisp.h (error, verror): Mark as printf-like functions.
5848 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5849 Report overflow in size calculations when allocating printf buffer.
5850 Do not truncate output string at its first null byte.
5851 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5852 Truncate the output at a character boundary, since vsnprintf does not
5853 do that.
5854 * charset.c (check_iso_charset_parameter): Convert internal
5855 character to string before calling 'error', since %c now has the
5856 printf meaning.
5857 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5858 overflow when computing char to be passed to 'error'. Do not
5859 pass Lisp_Object to 'error'; pass the integer instead.
5860 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5861 formatted with plain %d.
5862
b189fa66
PE
5863 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5864
bff87ef0
PE
5865 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5866
7e2cac20
PE
5867 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5868
ce4d90b5
PE
5869 * xterm.c (x_catch_errors): Remove duplicate declaration.
5870
266c9547
PE
5871 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5872
79c49ad2
PE
5873 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5874
368f4090
JM
58752011-04-10 Jim Meyering <meyering@redhat.com>
5876
5877 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5878 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5879 return ssize_t not "int", and use size_t as the buffer length.
5880 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5881 * gnutls.h: Update declarations.
5882 * process.c (read_process_output): Use ssize_t, to match.
5883 (send_process): Likewise.
5884
a32d4040
CY
58852011-04-09 Chong Yidong <cyd@stupidchicken.com>
5886
5887 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5888
8546720e 58892011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 5890
04f2d78b
CB
5891 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5892 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 5893
8546720e
GM
5894 * xterm.c (handle_one_xevent):
5895 * xmenu.c (create_and_show_popup_menu):
5896 * xselect.c (x_decline_selection_request)
5897 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 5898
0a2f5c1a 58992011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
5900
5901 Fix some uses of `int' instead of EMACS_INT.
5902 * search.c (string_match_1, fast_string_match)
5903 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5904 (scan_buffer, find_next_newline_no_quit)
5905 (find_before_next_newline, search_command, Freplace_match)
5906 (Fmatch_data): Make some `int' variables be EMACS_INT.
5907
5908 * xdisp.c (display_count_lines): 3rd argument and return value now
5909 EMACS_INT. All callers changed.
5910 (pint2hrstr): Last argument is now EMACS_INT.
5911
5912 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
5913 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5914 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
5915 (decode_coding_utf_16, decode_coding_emacs_mule)
5916 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
5917 (decode_coding_ccl, decode_coding_charset)
5918 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
5919 (decode_coding_iso_2022, decode_coding_emacs_mule)
5920 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
5921 <char_offset, last_offset>: Declare EMACS_INT.
5922 (encode_coding_utf_8, encode_coding_utf_16)
5923 (encode_coding_emacs_mule, encode_invocation_designation)
5924 (encode_designation_at_bol, encode_coding_iso_2022)
5925 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
5926 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
5927 Declare EMACS_INT.
5928 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
5929 (encode_invocation_designation): Last argument P_NCHARS is now
5930 EMACS_INT.
5931 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
5932 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
5933
5934 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
5935 All users changed.
5936
5937 * ccl.c (Fccl_execute_on_string): Declare some variables
5938 EMACS_INT.
5939
8546720e 59402011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
5941
5942 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
5943
4e19a977
CS
59442011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
5945
5946 * process.c (Fformat_network_address): Doc fix.
5947
87302331
R
59482011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
5949
5950 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
5951
cbb59342
CY
59522011-04-08 Chong Yidong <cyd@stupidchicken.com>
5953
5954 * keyboard.c (read_char): Call Lisp function help-form-show,
5955 instead of using internal_with_output_to_temp_buffer.
5956 (Qhelp_form_show): New var.
e0d38eeb 5957 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
5958
5959 * print.c (internal_with_output_to_temp_buffer): Function deleted.
5960
5961 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
5962
e67a13ab
CY
59632011-04-06 Chong Yidong <cyd@stupidchicken.com>
5964
04f2d78b
CB
5965 * process.c (Flist_processes): Remove to Lisp.
5966 (list_processes_1): Delete.
e67a13ab 5967
973f782d
EZ
59682011-04-06 Eli Zaretskii <eliz@gnu.org>
5969
7c106b1e
EZ
5970 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
5971
973f782d
EZ
5972 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
5973
41cf7d1a 59742011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 5975
ca23cc88
PE
5976 Fix more problems found by GCC 4.6.0's static checks.
5977
f390e2d5
PE
5978 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
5979
42eea0d0
PE
5980 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
5981
b69769da 5982 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 5983
f9541e84
PE
5984 * xdisp.c (vmessage): Mark as a printf-like function.
5985
13841b55
PE
5986 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
5987
c136c10f
PE
5988 * sound.c (sound_warning): Don't crash if arg contains a printf format.
5989
5e2d4a30
PE
5990 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
5991 printf-like functions.
5992 (tiff_load): Add casts to remove these marks before passing them
5993 to system-supplied API.
5994
583f48b9
PE
5995 * eval.c (Fsignal): Remove excess argument to 'fatal'.
5996
b25d760e
PE
5997 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
5998 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
5999 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6000 directly, rather than having caller test rule sign. This avoids
6001 some unnecessary tests.
6002 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6003 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6004 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 6005
bc7b6697 6006 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 6007 (xfont_open): Avoid unnecessary tests.
bc7b6697 6008
27ccc379
PE
6009 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6010
dcd5c89a
PE
6011 * composite.h, composite.c (composition_gstring_put_cache):
6012 Use EMACS_INT, not int, for length.
6013
b13a45c6
PE
6014 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6015 breaking out part of COMPOSITION_DECODE_RULE.
6016 (COMPOSITION_DECODE_RULE): Use it.
6017 * composite.c (get_composition_id): Remove unused local vars,
6018 by using the new macro.
6019
1e792e4d
PE
6020 * textprop.c (set_text_properties_1): Change while to do-while,
6021 since the condition is always true at first.
6022
dc6c6455 6023 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
6024 (interval_deletion_adjustment): Return unsigned value.
6025 All uses changed.
dc6c6455 6026
aba7731a
PE
6027 * process.c (list_processes_1, create_pty, read_process_output):
6028 (exec_sentinel): Remove vars that were set but not used.
afd4052b 6029 (create_pty): Remove unnecessary "volatile"s.
bc57d757 6030 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 6031 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 6032 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 6033
fdfc4bf3
PE
6034 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6035
fca8fe46 6036 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 6037 (update_syntax_table): Use unsigned instead of int.
fca8fe46 6038
06a0259a 6039 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 6040 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 6041 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 6042
e7b9e80f
PE
6043 * print.c (print_error_message): Avoid int overflow.
6044
56201685
PE
6045 * font.c (font_list_entities): Redo for clarity,
6046 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6047
78834453 6048 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 6049 (font_score): Avoid potential overflow in diff calculation.
78834453 6050
0bc0b309 6051 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 6052 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 6053
e610eaca
PE
6054 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6055
b895abce
PE
6056 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6057 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6058 can always succeed if overflow has undefined behavior.
6059
1f1d9321 6060 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 6061 (wordify): Omit three unnecessary tests.
1f1d9321 6062
c59478bc
PE
6063 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6064 All callers changed. This avoids the need for an unused var.
6065
79b73827
PE
6066 * casefiddle.c (casify_region): Remove var that is set but not used.
6067
a4db5dfe
PE
6068 * dired.c (file_name_completion): Remove var that is set but not used.
6069
43aae36e
PE
6070 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6071
2a47c44d 6072 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 6073 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 6074
a37c69bf
PE
6075 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6076 Check for integer overflow on size calculations.
6077
328ab8e7
PE
6078 * buffer.c (Fprevious_overlay_change): Remove var that is set
6079 but not used.
6080
e5a2a5cb
PE
6081 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6082 Remove vars that are set but not used.
8d84a6eb 6083 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 6084 (timer_check_2): Mark vars as initialized.
e5a2a5cb 6085
a60e5f68
PE
6086 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6087
f661cb61 6088 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 6089 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 6090
f0397f5a
PE
6091 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6092 that are set but not used.
6093
8664db06 6094 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 6095 if XCreateBitmapFromData fails (Bug#8410).
8664db06 6096
6abdaa4a
PE
6097 * xselect.c (x_get_local_selection, x_handle_property_notify):
6098 Remove vars that are set but not used.
6099
0ce7538d 6100 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 6101 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 6102
9ae848fc
PE
6103 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6104 Remove var that is set but not used.
0b918413
PE
6105 (scroll_bar_windows_size): Now size_t, not int.
6106 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6107 Check for overflow.
9ae848fc 6108
a5a62657
PE
6109 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6110 (map_tty_color) [!defined MSDOS]: Likewise.
6111
5c5cdd39
PE
6112 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6113
66ebf983
PE
6114 * coding.c: Remove vars that are set but not used.
6115 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6116 All callers changed.
6117 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6118 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6119 (decode_coding_charset): Remove vars that are set but not used.
6120
1be4d761
PE
6121 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6122 that is set but not used.
6123
47553fa8
PE
6124 * print.c (print_object): Remove var that is set but not used.
6125
1f7196bf 6126 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
6127 The gnulib version avoids calling malloc in the usual case,
6128 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6129 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6130 * filelock.c (current_lock_owner): Likewise.
6131 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6132 * sysdep.c: Include allocator.h, careadlinkat.h.
6133 (emacs_no_realloc_allocator): New static constant.
6134 (emacs_readlink): New function.
fdb61804
PE
6135 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6136 ../lib/careadlinkat.h.
d1fdcab7 6137
f84c17c7
SM
61382011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6139
6140 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6141 first non-nil return value).
6142
ef3862ad
JD
61432011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6144
6145 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6146 if not defined (Bug#8403).
6147
376a7006
JB
61482011-04-02 Juanma Barranquero <lekktu@gmail.com>
6149
6150 * xdisp.c (display_count_lines): Remove parameter `start',
6151 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6152 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6153 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6154 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6155 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6156 and thereabouts. All callers changed.
6157 (get_per_char_metric): Remove parameter `f', unused since
6158 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6159
6ca3801d
JM
61602011-04-02 Jim Meyering <meyering@redhat.com>
6161
6162 do not dereference NULL upon failed strdup
6163 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6164 (ns_get_family): Likewise.
6165
d8e2b5ba
JB
61662011-04-02 Juanma Barranquero <lekktu@gmail.com>
6167
6168 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6169
8c74fcbd
JD
61702011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6171
6172 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6173 later (Bug#8403).
6174
7200d79c
SM
61752011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6176
03408648 6177 Add lexical binding.
7200d79c 6178
03408648
SM
6179 * window.c (Ftemp_output_buffer_show): New fun.
6180 (Fsave_window_excursion):
6181 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6182
6183 * lread.c (lisp_file_lexically_bound_p): New function.
6184 (Fload): Bind Qlexical_binding.
6185 (readevalloop): Remove `evalfun' arg.
6186 Bind Qinternal_interpreter_environment.
6187 (Feval_buffer): Bind Qlexical_binding.
6188 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6189 Mark as dynamic.
6190 (syms_of_lread): Declare `lexical-binding'.
6191
6192 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6193
6194 * keyboard.c (eval_dyn): New fun.
6195 (menu_item_eval_property): Use it.
ca105506
SM
6196
6197 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 6198
03408648
SM
6199 * fns.c (concat, mapcar1): Accept byte-code-functions.
6200
6201 * eval.c (Fsetq): Handle lexical vars.
6202 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6203 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6204 (FletX, Flet): Obey lexical binding.
6205 (Fcommandp): Handle closures.
6206 (Feval): New `lexical' arg.
6207 (eval_sub): New function extracted from Feval. Use it almost
6208 everywhere where Feval was used. Look up vars in lexical env.
6209 Handle closures.
6210 (Ffunctionp): Move from subr.el.
6211 (Ffuncall): Handle closures.
6212 (apply_lambda): Remove `eval_flags'.
6213 (funcall_lambda): Handle closures and new byte-code-functions.
6214 (Fspecial_variable_p): New function.
6215 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6216 but without exporting it to Lisp.
23aba0ea 6217
23aba0ea 6218 * doc.c (Fdocumentation, store_function_docstring):
03408648 6219 * data.c (Finteractive_form): Handle closures.
23aba0ea 6220
03408648
SM
6221 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6222 interactive spec.
ba83908c 6223
04f2d78b
CB
6224 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6225 New byte-codes.
03408648
SM
6226 (exec_byte_code): New function extracted from Fbyte_code to handle new
6227 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 6228
03408648 6229 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 6230
03408648 6231 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 6232
e2abce01
JB
62332011-03-31 Juanma Barranquero <lekktu@gmail.com>
6234
6235 * xdisp.c (redisplay_internal): Fix prototype.
6236
63696a73 62372011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 6238
63696a73 6239 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
6240 (try_scrolling): Use it when setting scroll_limit.
6241 Limit scrolling to 100 screen lines.
63696a73
EZ
6242 (redisplay_window): Even when falling back on "recentering",
6243 position point in the window according to scroll-conservatively,
6244 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6245
6246 (try_scrolling): When point is above the window, allow searching
6247 as far as scroll_max, or one screenful, to compute vertical
6248 distance from PT to the scroll margin position. This prevents
6249 try_scrolling from unnecessarily failing when
6250 scroll-conservatively is set to a value slightly larger than the
6251 window height. Clean up the case of PT below the margin at bottom
6252 of window: scroll_max can no longer be INT_MAX. When aggressive
6253 scrolling is in use, don't let point enter the opposite scroll
6254 margin as result of the scroll.
6255 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
6256 threshold of 100 lines for never-recentering scrolling.
6257
e4cc2dfc
JB
62582011-03-31 Juanma Barranquero <lekktu@gmail.com>
6259
6260 * dispextern.h (move_it_by_lines):
6261 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6262 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6263 (message_log_check_duplicate): Remove parameters `prev_bol' and
6264 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6265 (redisplay_internal): Remove parameter `preserve_echo_area',
6266 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6267
6268 * indent.c (Fvertical_motion):
6269 * window.c (window_scroll_pixel_based, Frecenter):
6270 Don't pass `need_y_p' to `move_it_by_lines'.
6271
1c470562
SM
62722011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6273
44f230aa
SM
6274 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6275 steal a few bits to be more compact.
6276 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6277 Remove unneeded casts.
6278
1c470562
SM
6279 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6280
888adce9
ZK
62812011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6282
6283 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6284 binding" message (bug#7967).
6285
f838ed7b
PE
62862011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6287
77861b95
PE
6288 Fix more problems found by GCC 4.6.0's static checks.
6289
de6dbc14
PE
6290 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6291 Remove unused local var.
6292
f838ed7b
PE
6293 * editfns.c (Fmessage_box): Remove unused local var.
6294
792c7b2b
PE
6295 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6296 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6297 Omit unused local vars.
c499e557 6298 * window.c (shrink_windows): Omit unused local var.
b01a1c29 6299 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
6300 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6301 Omit unused local var.
6302
ba0165e1
PE
6303 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6304 Don't assume string length fits in int.
32ad8845 6305 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 6306 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 6307
3c59b4c9
PE
6308 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6309 instead of alloca (Bug#8344).
6310
a3eed478 6311 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 6312 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 6313
eb4d412d
PE
6314 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6315
1658b401
PE
6316 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6317 concerns.
6318
6319 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6320
6321 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 6322
9a2c6e05
PE
6323 * keyboard.c (syms_of_keyboard): Use the same style as later
6324 in this function when indexing through an array. This also
6325 works around GCC bug 48267.
6326
03d0a109
PE
6327 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6328
44f730c8
PE
6329 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6330
fe75f926
PE
6331 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6332 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6333
ffa8c828
PE
6334 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6335 This avoids undefined behavior on integer overflow, and is a bit
6336 more convenient anyway since it is compared to a size_t variable.
6337
c5101a77
PE
6338 Variadic C functions now count arguments with size_t, not int.
6339 This avoids an unnecessary limitation on 64-bit machines, which
6340 caused (substring ...) to crash on large vectors (Bug#8344).
6341 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6342 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 6343 All variadic functions and their callers changed accordingly.
c5101a77
PE
6344 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6345 * data.c (arith_driver, float_arith_driver): Likewise.
6346 * editfns.c (general_insert_function): Likewise.
6347 * eval.c (struct backtrace.nargs, interactive_p)
6348 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6349 (funcall_lambda, mark_backtrace): Likewise.
6350 * fns.c (concat): Likewise.
6351 * frame.c (x_set_frame_parameters): Likewise.
6352 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6353 0 if not found, not -1. All callers changed.
6354
dd3f25f7
PE
6355 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6356 (stack_copy_size): Now size_t, not int.
6357 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6358
461c2ab9
JB
63592011-03-28 Juanma Barranquero <lekktu@gmail.com>
6360
6361 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6362 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6363 All callers changed.
6364
6365 * lisp.h (multibyte_char_to_unibyte):
6366 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6367 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6368 * character.h (CHAR_TO_BYTE8):
6369 * cmds.c (internal_self_insert):
6370 * editfns.c (general_insert_function):
6371 * keymap.c (push_key_description):
6372 * search.c (Freplace_match):
6373 * xdisp.c (message_dolog, set_message_1): All callers changed.
6374
f6d62986
SM
63752011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6376
6377 * keyboard.c (safe_run_hook_funcall): New function.
6378 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6379 don't set the hook to nil, but remove the offending function instead.
6380 (Qcommand_hook_internal): Remove, unused.
6381 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6382 Vcommand_hook_internal.
6383
6384 * eval.c (enum run_hooks_condition): Remove.
6385 (funcall_nil, funcall_not): New functions.
6386 (run_hook_with_args): Call each function through a `funcall' argument.
6387 Remove `cond' argument, now redundant.
6388 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6389 (Frun_hook_with_args_until_failure): Adjust accordingly.
6390 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6391
1db5b1ad
JB
63922011-03-28 Juanma Barranquero <lekktu@gmail.com>
6393
6394 * dispextern.h (string_buffer_position): Remove declaration.
6395
6396 * print.c (strout): Remove parameter `multibyte', unused since
6397 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6398
6399 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6400 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6401 All callers changed.
6402
6403 * w32.c (_wsa_errlist): Use braces for struct initializers.
6404
6405 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6406 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6407 All callers changed.
6408 (string_buffer_position): Likewise. Also, make static (it's never
6409 used outside xdisp.c).
6410 (cursor_row_p): Remove parameter `w', unused since
6411 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6412 (decode_mode_spec): Remove parameter `precision', introduced during
6413 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6414 All callers changed.
6415
5ffb62aa
JD
64162011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6417
6418 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6419
461c2ab9 64202011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
6421
6422 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6423 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6424 (ns_update_auto_hide_menu_bar): New functions.
6425 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6426 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6427 ns_constrain_all_frames.
6428 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6429 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6430
5c380ffb
JD
64312011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6432
6433 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6434
9af30bdf
GM
64352011-03-27 Glenn Morris <rgm@gnu.org>
6436
6437 * syssignal.h: Replace RETSIGTYPE with void.
6438 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6439 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6440 Replace SIGTYPE with void everywhere.
6441 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6442 * s/template.h (SIGTYPE): Remove commented out definition.
6443
e2abce01
JB
64442011-03-26 Eli Zaretskii <eliz@gnu.org>
6445
6446 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6447 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6448
f868cd8a
JB
64492011-03-26 Juanma Barranquero <lekktu@gmail.com>
6450
59eb0929
JB
6451 * w32.c (read_unc_volume): Use parameter `henum', instead of
6452 global variable `wget_enum_handle'.
6453
6454 * keymap.c (describe_vector): Remove parameters `indices' and
6455 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6456 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6457
f868cd8a
JB
6458 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6459
6460 * keyboard.c (timer_check): Remove parameter `do_it_now',
6461 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6462 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6463 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6464
6465 * keyboard.c (read_char):
6466 * w32menu.c (w32_menu_display_help):
6467 * xmenu.c (show_help_event, menu_help_callback):
6468 Adjust calls to `show_help_echo'.
6469
6470 * gtkutil.c (xg_maybe_add_timer):
6471 * keyboard.c (readable_events):
6472 * process.c (wait_reading_process_output):
6473 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6474
6475 * insdel.c (adjust_markers_gap_motion):
6476 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6477 (gap_left, gap_right): Don't call it.
6478
2ecf6fdb
CY
64792011-03-25 Chong Yidong <cyd@stupidchicken.com>
6480
6481 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6482 incurred during fontification.
6483
6b1f9ba4
JB
64842011-03-25 Juanma Barranquero <lekktu@gmail.com>
6485
6486 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6487 (DEFVAR_PER_BUFFER): Don't pass it.
6488
6489 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6490 (scrolling_window): Don't pass it.
6491
0f4a96b5
JB
64922011-03-25 Juanma Barranquero <lekktu@gmail.com>
6493
6494 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6495
6496 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6497 and `suffix'.
6498 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6499 of variables specific to SELinux and computation of `encoded_absname'.
6500
6501 * image.c (XPutPixel): Remove unused variable `height'.
6502
6503 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6504
6505 * unexw32.c (get_section_info): Remove unused variable `section'.
6506
6507 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6508 (system_process_attributes): Remove unused variable `sess'.
6509 (sys_read): Remove unused variable `err'.
6510
6511 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6512 (w32_wnd_proc): Remove unused variable `isdead'.
6513 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6514 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6515 (x_create_tip_frame): Remove unused variable `tem'.
6516
6517 * w32inevt.c (w32_console_read_socket):
6518 Remove unused variable `no_events'.
6519
6520 * w32term.c (x_draw_composite_glyph_string_foreground):
6521 Remove unused variable `width'.
6522
1149507c
JB
65232011-03-24 Juanma Barranquero <lekktu@gmail.com>
6524
6525 * w32term.c (x_set_glyph_string_clipping):
6526 Don't pass uninitialized region to CombineRgn.
6527
9c88f339
JB
65282011-03-23 Juanma Barranquero <lekktu@gmail.com>
6529
6530 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6531 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6532 (Fx_close_connection): Remove unused variable `i'.
6533
6534 * w32font.c (w32font_draw): Return number of glyphs.
6535 (w32font_open_internal): Remove unused variable `i'.
6536 (w32font_driver): Add missing initializer.
6537
6538 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6539 (fill_in_menu): Remove unused variable `items_added'.
6540
6541 * w32term.c (last_mouse_press_frame): Remove static global variable.
6542 (w32_clip_to_row): Remove unused variable `f'.
6543 (x_delete_terminal): Remove unused variable `i'.
6544
6545 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6546 (NOTHING): Remove unused static global variable.
6547 (uniscribe_check_otf): Remove unused variable `table'.
6548 (uniscribe_font_driver): Add missing initializers.
6549
dee091a3
JD
65502011-03-23 Julien Danjou <julien@danjou.info>
6551
6552 * term.c (Fsuspend_tty, Fresume_tty):
6553 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6554 * window.c (temp_output_buffer_show):
6555 * insdel.c (signal_before_change):
6556 * frame.c (Fhandle_switch_frame):
6557 * fileio.c (Fdo_auto_save):
6558 * emacs.c (Fkill_emacs):
6559 * editfns.c (save_excursion_restore):
6560 * cmds.c (internal_self_insert):
6561 * callint.c (Fcall_interactively):
6562 * buffer.c (Fkill_all_local_variables):
6563 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6564 Use Frun_hooks.
0f4a96b5 6565 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
6566 unconditionnaly since it does the check itself.
6567
2c520ab5 65682011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 6569
c9c49752
PE
6570 Fix more problems found by GCC 4.5.2's static checks.
6571
8abc3f12
PE
6572 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6573 the first time through the loop, since we know p0 < p1 then.
6574 This also avoids a gcc -Wstrict-overflow warning.
6575
a2d26660
PE
6576 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6577 leading to a memory leak, possible in functions like
6578 load_charset_map_from_file that can allocate an unbounded number
b12ef411 6579 of objects (Bug#8318).
a2d26660 6580
916c72e9
PE
6581 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6582 that could (at least in theory) be that large.
6583
19ab8a18
PE
6584 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6585 This is less likely to overflow, and avoids undefined behavior if
6586 overflow does occur. All callers changed. Use strtoul to scan
6587 for the unsigned long integer.
b7cbbd6f
PE
6588 (pint2hrstr): Simplify and tune code slightly.
6589 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 6590
f0641eff
PE
6591 * scroll.c (do_scrolling): Work around GCC bug 48228.
6592 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6593
7f650bb9
PE
6594 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6595 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
6596 (validate_x_resource_name): Simplify count usage.
6597 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 6598
37dd57d1
PE
6599 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6600 fail (Bug#8306).
81e56e61 6601
699979fc 6602 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 6603
401bf9b4
PE
6604 * process.c (Fmake_network_process): Use socklen_t, not int,
6605 where POSIX says socklen_t is required in portable programs.
6606 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 6607 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
6608 (Fmake_network_process, server_accept_connection):
6609 (wait_reading_process_output, read_process_output):
6610 Likewise.
6611
b93aacde
PE
6612 * process.c: Rename or move locals to avoid shadowing.
6613 (list_processes_1, Fmake_network_process):
6614 (read_process_output_error_handler, exec_sentinel_error_handler):
6615 Rename or move locals.
4dc343ee 6616 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 6617 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 6618 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 6619 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 6620 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 6621
af8a867c 6622 Make tparam.h and terminfo.c consistent.
44f230aa
SM
6623 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6624 Include tparam.h instead, since it declares them.
af8a867c
PE
6625 * cm.h (PC): Remove extern decl; tparam.h now does this.
6626 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6627 * terminfo.c: Include tparam.h, to check interfaces.
6628 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6629 (tparam): Adjust signature to match interface in tparam.h;
6630 this removes some undefined behavior. Check that outstring and len
6631 are zero, which they always are with Emacs.
6632 * tparam.h (PC, BC, UP): New extern decls.
6633
0248044d 6634 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 6635 (xftfont_open): Rename locals to avoid shadowing.
0248044d 6636
8ff096c1 6637 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
6638 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6639 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 6640 (ftfont_list): Remove unused local.
49eaafba
PE
6641 (get_adstyle_property, ftfont_pattern_entity):
6642 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6643 Rename locals to avoid shadowing.
8ff096c1 6644
e2be39f6
PE
6645 * xfont.c (xfont_list_family): Mark var as initialized.
6646
c9735e30
PE
6647 * xml.c (make_dom): Now static.
6648
8f5201ae
PE
6649 * composite.c (composition_compute_stop_pos): Rename local to
6650 avoid shadowing.
b246f932
PE
6651 (composition_reseat_it): Remove unused locals.
6652 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 6653 (composition_update_it): Mark var as initialized.
11b61122
PE
6654 (find_automatic_composition): Mark vars as initialized,
6655 with a FIXME (Bug#8290).
8f5201ae 6656
760fbc2c
PE
6657 character.h: Rename locals to avoid shadowing.
6658 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6659 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6660 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6661 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6662 to avoid shadowing.
6663
ff08eb85
PE
6664 * textprop.c (property_change_between_p): Remove; unused.
6665
fc7bf025
PE
6666 * intervals.c (interval_start_pos): Now static.
6667
235d7abc
PE
6668 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6669
44f230aa
SM
6670 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6671 Rename locals to avoid shadowing.
3e7d6594 6672
50060332
PE
6673 * sound.c (wav_play, au_play, Fplay_sound_internal):
6674 Fix pointer signedness.
d01f234b 6675 (alsa_choose_format): Remove unused local var.
c83b8872
PE
6676 (wav_play): Initialize a variable to 0, to prevent undefined
6677 behavior (Bug#8278).
50060332 6678
c4fc4e30
PE
6679 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6680
918436ed
PE
6681 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6682
c939f91b
PE
6683 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6684 clobbering (Bug#8298).
b9c7f648
PE
6685 * sysdep.c (sys_subshell): Likewise.
6686 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 6687
6bd8c144
PE
6688 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6689 This should get cleaned up, so that child_setup has the
6690 same signature on all platforms.
6691
7710357c 6692 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 6693 (relocate_fd): Rename locals to avoid shadowing.
7710357c 6694
c59da222
CY
66952011-03-22 Chong Yidong <cyd@stupidchicken.com>
6696
6697 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
6698 not to be necessary, and produces flickering.
6699
66b87493
GM
67002011-03-20 Glenn Morris <rgm@gnu.org>
6701
6702 * config.in: Remove file.
6703
45b6f6d5
JB
67042011-03-20 Juanma Barranquero <lekktu@gmail.com>
6705
6706 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
6707 are now in src/globals.h.
6708 (syms_of_minibuf): Remove spurious & from previous change.
6709
3ec03f7e
LL
67102011-03-20 Leo <sdl.web@gmail.com>
6711
6712 * minibuf.c (completing-read-function): New variable.
6713 (completing-read-default): Rename from completing-read.
6714 (completing-read): Call completing-read-function.
6715
b14e3e21
CY
67162011-03-19 Juanma Barranquero <lekktu@gmail.com>
6717
6718 * xfaces.c (Fx_load_color_file):
6719 Read color file from absolute filename (bug#8250).
6720
f2b726e6
JB
67212011-03-19 Juanma Barranquero <lekktu@gmail.com>
6722
6723 * makefile.w32-in: Update dependencies.
6724
09f6ff02
EZ
67252011-03-17 Eli Zaretskii <eliz@gnu.org>
6726
6727 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
6728
29a6015a
PE
67292011-03-17 Paul Eggert <eggert@cs.ucla.edu>
6730
a3a6c54e
PE
6731 Fix more problems found by GCC 4.5.2's static checks.
6732
b766f867
PE
6733 * process.c (make_serial_process_unwind, send_process_trap):
6734 (sigchld_handler): Now static.
6735
be02381c
PE
6736 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
6737 That way, the code declares only the vars that it needs.
6738 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
6739 * s/cygwin.h (PTY_ITERATION): Likewise.
6740 * s/darwin.h (PTY_ITERATION): Likewise.
6741 * s/gnu-linux.h (PTY_ITERATION): Likewise.
6742
57048744
PE
6743 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
6744 * process.c (allocate_pty): Don't declare stb unless it's needed.
6745
7914961c 6746 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
6747 (CONSTANTLIM): Remove; unused.
6748 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
6749 Define only if needed.
7914961c 6750
b3967b18
PE
6751 * unexelf.c (unexec): Name an expression,
6752 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
6753 Use a different way to cause a compilation error if anyone uses
6754 n rather than nn, a way that does not involve shadowing.
73366a00 6755 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 6756
29a6015a
PE
6757 * deps.mk (unexalpha.o): Remove; unused.
6758
43cfc33e 6759 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 6760 * unexec.h: New file.
ce701a33
PE
6761 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
6762 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
6763 Depend on unexec.h.
6764 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
6765 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
6766 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 6767 Change as necessary to match prototype in unexec.h.
ce701a33 6768
01f44d5a
PE
6769 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
6770 shadowing.
4f63c6bb 6771 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 6772
a6670b0b
PE
6773 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
6774 Rename locals to avoid shadowing.
6775
cef2010d 6776 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 6777 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 6778
d4d7173a
PE
6779 * print.c (Fredirect_debugging_output): Fix pointer signedess.
6780
f08b802a
PE
6781 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
6782 warning when compiling print.c.
6783
3ddb0639
PE
6784 * font.c (font_unparse_fcname): Abort in an "impossible" situation
6785 instead of using an uninitialized var.
5ad03b97 6786 (font_sort_entities): Mark var as initialized.
3ddb0639 6787
170a2692
PE
6788 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
6789
e663c700
PE
6790 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
6791 pointers to constants.
89bc529a 6792 (font_parse_fcname): Remove unused vars.
7b81e2d0 6793 (font_delete_unmatched): Now static.
ea838e10 6794 (font_get_spec): Remove; unused.
13a547c6
PE
6795 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
6796 (font_update_drivers, Ffont_get_glyphs, font_add_log):
6797 Rename or move locals to avoid shadowing.
e663c700 6798
2a80c887 6799 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 6800 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 6801
1384fa33 6802 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 6803 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 6804
8b2c52e9
PE
6805 * alloc.c (mark_backtrace): Move decl from here ...
6806 * lisp.h: ... to here, so that it can be checked.
6807
475545b5 6808 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 6809 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
6810 (lisp_indirect_variable): Name an expression,
6811 to avoid gcc -Wbad-function-cast warning.
1faed8ae 6812 (Fdefvar): Rename locals to avoid shadowing.
475545b5 6813
b1349114 6814 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 6815 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 6816 Use const pointer when appropriate.
b1349114 6817
a2928364
PE
6818 * lisp.h (get_system_name, get_operating_system_release):
6819 Move decls here, to check interfaces.
6820 * process.c (get_operating_system_release): Move decl to lisp.h.
6821 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
6822 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
6823 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
6824 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
6825 (Fformat_time_string, Fencode_time, Finsert_char):
6826 (Ftranslate_region_internal, Fformat):
6827 Rename or remove local vars to avoid shadowing.
9710023e 6828 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 6829
a415e694
PE
6830 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
6831 avoid shadowing.
6832
8ef4622d
PE
6833 * lisp.h (eassert): Check that the argument compiles, even if
6834 ENABLE_CHECKING is not defined.
6835
946f9a5b
PE
6836 * data.c (Findirect_variable): Name an expression, to avoid
6837 gcc -Wbad-function-cast warning.
112396d6 6838 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 6839 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
6840 (Fmake_variable_buffer_local, Fmake_local_variable):
6841 Mark variables as initialized.
52746918 6842 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 6843
e5aab7e7 6844 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
6845 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
6846 Rename locals to avoid shadowing.
dff45157
PE
6847 (mark_stack): Move local variables into the #ifdef region where
6848 they're used.
7bc26fdb
PE
6849 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6850 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6851 needed otherwise.
6852 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6853 (GC_STRING_CHARS): Remove; not used.
d40d4be1 6854 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 6855
e5aab7e7
PE
6856 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6857 avoids undefined behavior in theory.
6858
4da60324
PE
6859 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6860
88043301
PE
6861 Use functions, not macros, for up- and down-casing (Bug#8254).
6862 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6863 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6864 to use the following functions instead of these macros.
6865 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6866 EMACS_INT, since callers assume the returned value fits in int.
6867 (upcase1): Likewise, for UPCASE_TABLE.
6868 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 6869 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 6870 the race-condition problem in the old DOWNCASE.
88043301 6871
19ed5445
PE
6872 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6873 Rename locals to avoid shadowing.
6874 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
6875 (regex_compile, re_search_2, re_match_2_internal):
6876 Remove unused local vars.
952db0d7
PE
6877 (FREE_VAR): Rewrite so as not to use empty "else",
6878 which gcc can warn about.
da053e48 6879 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
6880 (RETALLOC_IF): Define only if needed.
6881 (WORDCHAR_P): Likewise. This one is never needed, but is used
6882 only in a comment talking about a compiler bug, so put inside
6883 the #if 0 of that comment.
6884 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6885 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6886 Remove; unused.
19ed5445 6887
1f3561e4 6888 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
6889 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6890 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 6891
ded6f8f7
PE
6892 * search.c (simple_search): Remove unused var.
6893
dbd37a95
PE
6894 * dired.c (compile_pattern): Move decl from here ...
6895 * lisp.h: ... to here, so that it can be checked.
6896 (struct re_registers): New forward decl.
6897
7e47afad
PE
6898 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6899
85f24f61
PE
6900 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6901 All uses changed.
6902 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6903 Rename locals to avoid shadowing.
5671df8f 6904 (Fvertical_motion): Mark locals as initialized.
85f24f61 6905
181aa2be 6906 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 6907 (casify_region): Mark local as initialized.
181aa2be 6908
930d429c
PE
6909 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
6910
7082eac6
PE
6911 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
6912 New macros, so that the caller can use some names other than
6913 gcpro1, gcpro2, etc.
6914 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
6915 of the new macros.
6916 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
6917 argument, for consistency with GCPRO2_VAR, etc: it is now the
6918 prefix of the variable, not the variable itself. All uses
6919 changed.
38b2c076
PE
6920 * dired.c (directory_files_internal, file_name_completion):
6921 Rename locals to avoid shadowing.
6922
15206ed9
PE
6923 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
6924 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
6925 dired.c's scmp function, had undefined behavior.
6926 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6927 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
6928 * buffer.h: ... to here, because these macros use current_buffer,
6929 and the new implementation with inline functions needs to have
6930 current_buffer in scope now, rather than later when the macros
6931 are used.
6932 (downcase, upcase1): New static inline functions.
6933 (DOWNCASE, UPCASE1): Reimplement using these functions.
6934 This avoids undefined behavior in expressions like
6935 DOWNCASE (x) == DOWNCASE (y), which previously suffered
6936 from race conditions in accessing the global variables
6937 case_temp1 and case_temp2.
6938 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
6939 * lisp.h (case_temp1, case_temp2): Remove their decls.
6940 * character.h (ASCII_CHAR_P): Move from here ...
6941 * lisp.h: ... to here, so that the inline functions mentioned
6942 above can use them.
6943
4a6bea26
PE
6944 * dired.c (directory_files_internal_unwind): Now static.
6945
f14b7e14
PE
6946 * fileio.c (file_name_as_directory, directory_file_name):
6947 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
6948 Now static.
2893f146
PE
6949 (file_name_as_directory): Use const pointers when appropriate.
6950 (Fexpand_file_name): Likewise. In particular, newdir might
6951 point at constant storage, so make it a const pointer.
fd4ead52 6952 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
6953 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
6954 signedness issues.
f839df0c
PE
6955 (Fset_file_times, Finsert_file_contents, auto_save_error):
6956 Rename locals to avoid shadowing.
f14b7e14 6957
5716756e 6958 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
6959 (Ftry_completion, Fall_completions): Rename or remove locals
6960 to avoid shadowing.
5716756e 6961
b4c3046a
PE
6962 * marker.c (bytepos_to_charpos): Remove; unused.
6963
b45db522
PE
6964 * lisp.h (verify_bytepos, count_markers): New decls,
6965 so that gcc does not warn that these functions aren't declared.
6966
85876d07
PE
6967 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
6968 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 6969 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 6970 (copy_text): Remove unused local var.
85876d07 6971
03d78a21 6972 * filelock.c (within_one_second): Now static.
b3dd38ab 6973 (lock_file_1): Rename local to avoid shadowing.
03d78a21 6974
5df8f01b
PE
6975 * buffer.c (fix_overlays_before): Mark locals as initialized.
6976 (fix_start_end_in_overlays): Likewise. This function should be
6977 simplified by using pointers-to-pointers, but that's a different
6978 matter.
b1d876f1 6979 (switch_to_buffer_1): Now static.
8f54f30a
PE
6980 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
6981 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 6982
a70072c9 6983 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 6984 Fix pointer signedness issue.
edced198
PE
6985 (sys_subshell): Mark local as volatile if checking for lint,
6986 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 6987 (MAXPATHLEN): Define only if needed.
a70072c9 6988
a0977c44
PE
6989 * process.c (serial_open, serial_configure): Move decls from here ...
6990 * systty.h: ... to here, so that they can be checked.
6991
a884fdcc
PE
6992 * fns.c (get_random, seed_random): Move extern decls from here ...
6993 * lisp.h: ... to here, so that they can be checked.
6994
604efe86 6995 * sysdep.c (reset_io): Now static.
b8950c94 6996 (wait_for_termination_signal): Remove; unused.
604efe86 6997
38fc62d9
PE
6998 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
6999 (copy_keymap_item, append_key, push_text_char_description):
7000 Now static.
1004a21a 7001 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 7002 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
7003 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7004 (describe_map_tree):
7005 Rename locals to avoid shadowing.
38fc62d9 7006
2f2650da
PE
7007 * keyboard.c: Declare functions static if they are not used elsewhere.
7008 (echo_char, echo_dash, cmd_error, top_level_2):
7009 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
7010 (read_char, kbd_buffer_get_event, make_lispy_position):
7011 (make_lispy_event, make_lispy_movement, apply_modifiers):
7012 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7013 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7014 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 7015 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 7016 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 7017
a053e86c 7018 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
7019 (mark_kboards): Move decl here ...
7020 * alloc.c (mark_kboards): ... from here.
a053e86c 7021
4752793e
PE
7022 * lisp.h (force_auto_save_soon): New decl.
7023
74f10ca7 7024 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
7025 (DEFINE_DUMMY_FUNCTION): New macro.
7026 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7027 Use it.
c03cd23f
PE
7028 (main): Add casts to avoid warnings
7029 if GCC considers string literals to be constants.
74f10ca7 7030
022e70d4
PE
7031 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7032
59d6fe83
PE
7033 * dbusbind.c: Pointer signedness fixes.
7034 (xd_signature, xd_append_arg, xd_initialize):
7035 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7036 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7037 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7038 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7039
78320123
PE
7040 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7041 if GCC considers string literals to be constants.
49cebcca 7042 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 7043
35ac2a97
SM
70442011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7045
fb103ca9
SM
7046 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7047 (print_preprocess, print_object): New macro to fix last change.
7048
35ac2a97
SM
7049 * print.c (print_preprocess): Don't forget font objects.
7050
62973b41
JB
70512011-03-16 Juanma Barranquero <lekktu@gmail.com>
7052
7053 * emacs.c (USAGE3): Doc fixes.
7054
0e48bb22
AS
70552011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7056
7057 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7058 structure.
7059
7684e57b
JB
70602011-03-14 Juanma Barranquero <lekktu@gmail.com>
7061
7062 * lisp.h (VWindow_system, Qfile_name_history):
7063 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7064 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7065 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7066
7067 * w32select.c: Don't #include "keyboard.h".
c96bbc66 7068 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
7069
7070 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7071 * w32console.c (detect_input_pending, read_input_pending)
7072 (encode_terminal_code):
7073 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7074 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7075 (w32_system_caret_y, Qfile_name_history):
7076 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7077 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7078 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7079 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7080 * w32proc.c (Qlocal, report_file_error):
7081 * w32term.c (Vwindow_system, updating_frame):
7082 * w32uniscribe.c (initialized, uniscribe_font_driver):
7083 Remove unneeded extern declarations.
7084
2aa46d6c
CY
70852011-03-14 Chong Yidong <cyd@stupidchicken.com>
7086
c96bbc66 7087 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 7088
cffc6f3b
CY
70892011-03-13 Chong Yidong <cyd@stupidchicken.com>
7090
7091 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7092 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7093 These macros can no longer be used for assignment.
7094
44f230aa
SM
7095 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7096 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
7097 (record_buffer_markers, fetch_buffer_markers): New functions for
7098 recording and fetching special buffer markers.
7099 (set_buffer_internal_1, set_buffer_temp): Use them.
7100
7101 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7102
7103 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7104
7105 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7106 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7107
7108 * xdisp.c (hscroll_window_tree):
7109 (reconsider_clip_changes): Use PT instead of BUF_PT.
7110
d251f04b
EZ
71112011-03-13 Eli Zaretskii <eliz@gnu.org>
7112
7113 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7114 $(EMACS_ROOT)/lib/intprops.h.
7115
f0c77cd1
PE
71162011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7117
3eca4629
PE
7118 Fix more problems found by GCC 4.5.2's static checks.
7119
7c86ee98
PE
7120 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7121 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
7122 (xg_free_frame_widgets): Make it clear that a local variable is
7123 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
7124 (gdk_window_get_screen): Make it clear that this macro is needed
7125 only if USE_GTK_TOOLTIP.
1e5524e7
PE
7126 (int_gtk_range_get_value): New function, which avoids a diagnostic
7127 from gcc -Wbad-function-cast.
7128 (xg_set_toolkit_scroll_bar_thumb): Use it.
7129 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7130 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
7131 (get_utf8_string, xg_get_file_with_chooser):
7132 Rename locals to avoid shadowing.
7133 (create_dialog): Move locals to avoid shadowing.
7c86ee98 7134
41729b81
PE
7135 * xgselect.c (xg_select): Remove unused var.
7136
f0c77cd1
PE
7137 * image.c (four_corners_best): Mark locals as initialized.
7138 (gif_load): Initialize transparent_p to zero (Bug#8238).
7139 Mark another local as initialized.
ec6cf4c6 7140 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 7141
ce0ad53d 7142 * image.c (clear_image_cache): Now static.
d5d5a617 7143 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 7144 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
7145 (x_edge_detection): Remove unnecessary cast that
7146 gcc -Wbad-function-cast diagnoses.
2037898d 7147 (gif_load): Fix pointer signedness.
6ae141d6
PE
7148 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7149 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 7150
33383987 71512011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 7152
d32df629
PE
7153 Improve quality of tests for time stamp overflow.
7154 For example, without this patch (encode-time 0 0 0 1 1
7155 1152921504606846976) returns the obviously-bogus value (-948597
7156 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7157 reports time overflow. See
7158 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
7159 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7160 * editfns.c: Include limits.h and intprops.h.
7161 (TIME_T_MIN, TIME_T_MAX): New macros.
7162 (time_overflow): Move earlier, to before first use.
7163 (hi_time, lo_time): New functions, for an accurate test for
7164 out-of-range times.
7165 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7166 (Fget_internal_run_time): Don't assume time_t fits in int.
7167 (make_time): Use list2 instead of Fcons twice.
7168 (Fdecode_time): More accurate test for out-of-range times.
7169 (check_tm_member): New function.
7170 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
7171 (lisp_time_argument): Don't rely on undefined left-shift and
7172 right-shift behavior when checking for time stamp overflow.
8be6f318 7173
fe31d94c
PE
7174 * editfns.c (time_overflow): New function, refactoring common code.
7175 (Fformat_time_string, Fdecode_time, Fencode_time):
7176 (Fcurrent_time_string): Use it.
7177
8be6f318
PE
7178 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7179 * dired.c (make_time): Move to ...
7180 * editfns.c (make_time): ... here.
7181 * systime.h: Note the move.
7182
09d9db2c 71832011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 7184
126bc0dc
YM
7185 * fringe.c (update_window_fringes): Remove unused variables.
7186
c47cbdfd
YM
7187 * unexmacosx.c (copy_data_segment): Also copy __got section.
7188 (Bug#8223)
7189
7ac80be9
EZ
71902011-03-12 Eli Zaretskii <eliz@gnu.org>
7191
c96bbc66 7192 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
7193 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7194 Constify `char *' arguments and their references according to
7195 prototypes in tparam.h.
7196
ecb0f94d 7197 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 7198
7ac80be9
EZ
7199 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7200 Adapt all references accordingly.
7201
7202 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7203
ef1fd07e
TT
72042011-03-11 Tom Tromey <tromey@redhat.com>
7205
7206 * buffer.c (syms_of_buffer): Remove obsolete comment.
7207
7ef4b50c
EZ
72082011-03-11 Eli Zaretskii <eliz@gnu.org>
7209
7210 * termhooks.h (encode_terminal_code): Declare prototype.
7211
7212 * msdos.c (encode_terminal_code): Don't declare prototype.
7213
7214 * term.c (encode_terminal_code): Now external again, used by
7215 w32console.c and msdos.c.
7216
44f230aa
SM
7217 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7218 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 7219
4b1ec863 72202011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 7221
1714f52b 7222 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 7223
4b1ec863
PE
7224 * fringe.c (update_window_fringes): Mark locals as initialized
7225 (Bug#8227).
7226 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 7227
524c7aa6
PE
7228 * alloc.c (mark_fringe_data): Move decl from here ...
7229 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7230 to check its interface.
7231 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7232
a5c0af81 7233 * fontset.c (free_realized_fontset): Now static.
7519b8cd 7234 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 7235 (fontset_font): Mark local as initialized.
a9a06e0b 7236 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 7237
b4716021
PE
7238 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7239
811e9bac 7240 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 7241 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
7242 (x_own_selection, Fx_disown_selection_internal): Rename locals
7243 to avoid shadowing.
7244 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 7245
7e3ab302
PE
7246 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7247 so that the caller can use some name other than gcpro1.
7248 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
7249 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7250 (Fx_backspace_delete_keys_p):
7251 Use them to avoid shadowing, and rename vars to avoid shadowing.
7252 (x_decode_color, x_set_name, x_window): Now static.
6b437900 7253 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 7254 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
7255 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7256 Remove unused locals.
7e3ab302
PE
7257 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7258 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7259 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7260 macros.
f78faa98 7261
e2b13473
PE
7262 * xterm.h (x_mouse_leave): New decl.
7263
77f23912
PE
7264 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7265 Remove unused functions.
cdf4ba58
PE
7266 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7267 (x_calc_absolute_position): Now static.
7411c686 7268 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 7269 Don't declare local "event" unless it's used.
ed7bf3a5
PE
7270 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7271 unless they are used.
38d0b34a
PE
7272 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7273 (x_fatal_error_signal): Remove; not used.
a6067996
PE
7274 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7275 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7276 (x_error_catcher, x_connection_closed, x_error_handler):
7277 (x_error_quitter, xembed_send_message, x_iconify_frame):
7278 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 7279 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 7280 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 7281
44f230aa
SM
7282 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7283 Rename or move locals to avoid shadowing.
6b463e58 7284 (tty_defined_color, merge_face_heights): Now static.
5967d051 7285 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
7286 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7287 does not deduce is never used uninitialized.
73719eba
PE
7288 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7289 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 7290
426994c3 7291 * terminal.c (store_terminal_param): Now static.
5489860b 7292
032f1620 7293 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 7294 (set_frame_menubar): Remove unused local.
d4323972 7295 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
7296 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7297 since they might point to immutable storage.
281585b0
PE
7298 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7299 since it's unused otherwise.
032f1620 7300
367c19e5 7301 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 7302 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
7303 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7304 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 7305 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
7306 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7307 does not deduce are never used uninitialized.
70739cbe 7308
07b48fa9
PE
7309 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7310
8868a238 7311 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
7312 * window.c (window_loop, size_window):
7313 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 7314
7e5cf297 7315 * window.c (display_buffer): Now static.
d6550a9f
PE
7316 (size_window): Mark variables that gcc -Wuninitialized
7317 does not deduce are never used uninitialized.
a586633d
PE
7318 * window.h (check_all_windows): New decl, to forestall
7319 gcc -Wmissing-prototypes diagnostic.
5b555da1 7320 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 7321
f6095868
PE
7322 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7323 shadowing.
7324 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
7325 Include <limits.h>.
7326 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7327 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
7328 (load_charset_map): Mark variables that gcc -Wuninitialized
7329 does not deduce are never used uninitialized.
53df7c11 7330 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 7331
f38b440c
PE
7332 * coding.c (coding_set_source, coding_set_destination):
7333 Use "else { /* comment */ }" rather than "else /* comment */;"
7334 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
7335 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7336 a block, when the outer 'i' will do.
7337 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7338 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7339 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7340 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7341 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7342 Rename locals to avoid shadowing.
7343 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
7344 * coding.c (emacs_mule_char, encode_invocation_designation):
7345 Now static, since they're not used elsewhere.
413bb2db 7346 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 7347 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
7348 (decode_coding_emacs_mule): Mark variables that gcc
7349 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
7350 (detect_coding_iso_2022): Initialize a local variable that might
7351 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 7352 this initialization is needed. (Bug#8211)
5f58e762
PE
7353 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7354 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7355 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7356 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7357 Remove unused macros.
f38b440c 7358
232b38b9 7359 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 7360 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 7361 * character.c (string_count_byte8): Likewise.
232b38b9 7362
fb90da1b
PE
7363 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7364 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7365
fb93dbc2
PE
7366 * chartab.c (copy_sub_char_table): Now static, since it's not used
7367 elsewhere.
5c156ace
PE
7368 (sub_char_table_ref_and_range, char_table_ref_and_range):
7369 Rename locals to avoid shadowing.
bbcd0949 7370 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 7371
7d3b3862 7372 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 7373 (BIDI_BOB): Remove unused macro.
7d3b3862 7374
6be7d3da
PE
7375 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7376 deduce are never used uninitialized.
c2ed9c8b 7377 * term.c (encode_terminal_code): Likewise.
6be7d3da 7378
75f8807f 7379 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 7380
50938595
PE
7381 * tparam.h: New file.
7382 * term.c, tparam.h: Include it.
7383 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7384 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7385 Move these decls to tparam.h, and make them agree with what
7386 is actually in tparam.c. The previous trick of using incompatible
7387 decls in different modules does not conform to the C standard.
7388 All callers of tparam changed to use tparam's actual API.
7389 * tparam.c (tparam1, tparam, tgoto):
7390 Use const pointers where appropriate.
7391
fbceeba2
PE
7392 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7393 * cm.h (struct cm): Likewise.
7394 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7395 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7396 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7397 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7398 (turn_on_face, init_tty): Likewise.
7399 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 7400
7f3f1250
PE
7401 * term.c (term_mouse_position): Rename local to avoid shadowing.
7402
e6ca6543
PE
7403 * alloc.c (mark_ttys): Move decl from here ...
7404 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7405
c40f8d15
AS
74062011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7407
7408 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7409
cfe0661d
JB
74102011-03-09 Juanma Barranquero <lekktu@gmail.com>
7411
7412 * search.c (compile_pattern_1): Remove argument regp, unused since
7413 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7414 (compile_pattern): Don't pass it.
7415
0afb4571
J
74162011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7417
7418 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7419 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7420 for ! HAVE_GTK3.
7421 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7422
7423 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7424
7425 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7426 gdk_window_get_screen, gdk_window_get_geometry,
7427 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7428 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7429 (xg_get_pixbuf_from_pixmap): New function.
7430 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7431 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7432 Call xg_get_pixbuf_from_pixmap instead of
7433 gdk_pixbuf_get_from_drawable.
7434 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7435 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7436 (xg_check_special_colors): Use GtkStyleContext and its functions
7437 for HAVE_GTK3.
7438 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7439 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7440 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
7441 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7442 Call gtk_widget_get_preferred_size.
0afb4571
J
7443 (xg_frame_resized): gdk_window_get_geometry only takes 5
7444 parameters.
44f230aa
SM
7445 (xg_win_to_widget, xg_event_is_for_menubar):
7446 Call gdk_x11_window_lookup_for_display.
0afb4571
J
7447 (xg_set_widget_bg): New function.
7448 (delete_cb): New function.
895009e1 7449 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
7450 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7451 (xg_set_background_color): Call xg_set_widget_bg.
7452 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7453 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7454 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7455 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7456 if ! HAVE_GTK3.
7457 (update_frame_tool_bar): Call gtk_widget_hide.
7458 (xg_initialize): Use GDK_KEY_g.
7459
7460 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7461 if ! HAVE_GTK3
7462 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7463
7464 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7465 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7466 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7467
1c2cc4ef
JB
74682011-03-08 Juanma Barranquero <lekktu@gmail.com>
7469
7470 * w32xfns.c (select_palette): Check success of RealizePalette against
7471 GDI_ERROR, not zero.
7472
33383987 7473See ChangeLog.11 for earlier changes.
aac0c6e3
MR
7474
7475;; Local Variables:
7476;; coding: utf-8
aac0c6e3
MR
7477;; End:
7478
33383987 7479 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
7480
7481 This file is part of GNU Emacs.
7482
7483 GNU Emacs is free software: you can redistribute it and/or modify
7484 it under the terms of the GNU General Public License as published by
7485 the Free Software Foundation, either version 3 of the License, or
7486 (at your option) any later version.
7487
7488 GNU Emacs is distributed in the hope that it will be useful,
7489 but WITHOUT ANY WARRANTY; without even the implied warranty of
7490 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7491 GNU General Public License for more details.
7492
7493 You should have received a copy of the GNU General Public License
7494 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.