calc.texi (Simplification modes): Mention "basic" simplification.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
4f5d0325
EZ
12012-08-01 Eli Zaretskii <eliz@gnu.org>
2
2008beae
EZ
3 * .gdbinit (xcar, xcdr, xlist, xwindow, nextcons, xprintsym):
4 Adapt to latest changes in field names of the corresponding Lisp
288479f6 5 objects.
2008beae 6
4f5d0325
EZ
7 * xdisp.c (try_window_id): Use WVAR in IF_DEBUG code.
8
fe3cc771
GM
92012-08-01 Glenn Morris <rgm@gnu.org>
10
11 * s/msdos.h: Remove file.
12 * conf_post.h [MSDOS]: New section, moved from s/msdos.h.
13 * Makefile.in (S_FILE): Remove.
14 (config_h): Remove S_FILE.
15
c90acc54
JB
162012-08-01 Juanma Barranquero <lekktu@gmail.com>
17
18 * s/ms-w32.h (DEVICE_SEP, IS_DIRECTORY_SEP, IS_ANY_SEP):
19 Remove; moved to nt/config.nt.
20
d8a05828
DA
212012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
22
23 Use INTERNAL_FIELD for conses and overlays.
24 * lisp.h (struct Lisp_Cons): Use INTERNAL_FIELD.
25 Remove obsolete comment.
26 (MVAR): New macro.
27 (struct Lisp_Overlay): Use INTERNAL_FIELD.
28 * alloc.c, buffer.c, buffer.h, fns.c: Adjust users.
29
8271d590
DA
302012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
31
32 Use INTERNAL_FIELD for symbols.
33 * lisp.h (SVAR): New macro. Adjust users.
34 * alloc.c, bytecode.c, cmds.c, data.c, doc.c, eval.c:
35 * fns.c, keyboard.c, lread.c, xterm.c: Users changed.
36
3193acd2
DA
372012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
38
39 Use INTERNAL_FIELD for processes.
40 * process.h (PVAR): New macro. Adjust style.
41 (struct Lisp_Process): Change Lisp_Object members to INTERNAL_FIELD.
42 * print.c, process.c, sysdep.c, w32.c, xdisp.c: Users changed.
43
3a45383a
DA
442012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
45
46 Use INTERNAL_FIELD for windows.
47 * window.h (WVAR): New macro.
48 (struct window): Change Lisp_Object members to INTERNAL_FIELD.
49 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
50 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
51 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, nsterm.m, print.c:
52 * textprop.c, w32fns.c, w32menu.c, w32term.c, window.c, xdisp.c:
53 * xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
54
c1dbc63c
PE
552012-08-01 Paul Eggert <eggert@cs.ucla.edu>
56
57 * coding.h (CODING_ATTR_FLUSHING): Remove; unused and wouldn't work.
58
5c0c0e8a
GM
592012-08-01 Glenn Morris <rgm@gnu.org>
60
61 * lisp.h (IS_DIRECTORY_SEP, IS_DEVICE_SEP, IS_ANY_SEP):
62 Move to configure.ac.
63
552a99b4
JB
642012-08-01 Juanma Barranquero <lekktu@gmail.com>
65
66 * makefile.w32-in (CONFIG_H): Update dependencies.
67 (CONF_POST_H): New macro.
68
69 * s/ms-w32.h (SEPCHAR, NULL_DEVICE): Remove; moved to nt/config.nt.
70
8d8e2dfe
GM
712012-07-31 Glenn Morris <rgm@gnu.org>
72
bc96620a
GM
73 * Makefile.in (S_FILE): No longer set by configure.
74
476b1b2d
GM
75 * conf_post.h (config_opsysfile): Move earlier, so that WINDOWSNT
76 is available.
77 (alloca.h) [WINDOWSNT]: Don't include it on MS Windows.
78
b2c7a106
GM
79 * process.h (NULL_DEVICE):
80 * emacs.c (SEPCHAR):
81 * editfns.c (USER_FULL_NAME): Let configure set them.
82
d53d062a
GM
83 * s/README, s/template.h: Remove files.
84
4515017f
GM
85 * conf_post.h [HPUX]: Undefine HAVE_RANDOM and HAVE_RINT.
86
8d8e2dfe
GM
87 * conf_post.h (AMPERSAND_FULL_NAME, subprocesses):
88 Move to configure.ac.
89
5b20b3cc
EZ
902012-07-31 Eli Zaretskii <eliz@gnu.org>
91
1e0afd9a
EZ
92 * .gdbinit (xframe): Adapt to introduction of FVAR and the
93 resulting renaming of 'struct frame' members.
94
5b20b3cc
EZ
95 * w32menu.c (w32_menu_show): Revert bogus introduction of FVAR.
96
97 * fontset.c (dump_fontset): Fix compilation with ENABLE_CHECKING
98 after introduction of FVAR.
99
f1310128
JD
1002012-07-31 Jan Djärv <jan.h.d@swipnet.se>
101
79e721e0
JD
102 * nsmenu.m (update_frame_tool_bar): Change key from NSObject* to id.
103
104 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Use drawInRect
105 instead of compositeToPoint.
106 (applicationShouldTerminate): Pass NS String literal to NSRunAlertPanel.
107
8d7c7eed 108 * nsfns.m, nsmenu.m, nsterm.m: Adopt to struct frame/FVAR changes.
f1310128 109
e34f7f79
DA
1102012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
111
112 Generalize INTERNAL_FIELD between buffers, keyboards and frames.
113 * lisp.h (INTERNAL_FIELD): New macro.
114 * buffer.h (BUFFER_INTERNAL_FIELD): Removed.
115 (BVAR): Change to use INTERNAL_FIELD.
116 * keyboard.h (KBOARD_INTERNAL_FIELD): Likewise.
117 (KVAR): Change to use INTERNAL_FIELD.
118 * frame.h (FVAR): New macro.
119 (struct frame): Use INTERNAL_FIELD for all Lisp_Object fields.
3a45383a
DA
120 * alloc.c, buffer.c, data.c, dispnew.c, dosfns.c, eval.c, frame.c:
121 * fringe.c, gtkutil.c, minibuf.c, nsfns.m, nsterm.m, print.c:
122 * term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
e34f7f79
DA
123 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
124
c09bfb2f
DA
1252012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
126
127 Miscellaneous fixes for non-default X toolkits.
128 * xfns.c (Fx_file_dialog): Change to SSDATA to avoid warnings.
129 * xterm.c (x_frame_of_widget): Remove redundant prototype.
130 Move under #ifdef USE_LUCID.
131 (x_create_toolkit_scroll_bar): Adjust scroll_bar_name
132 definition and usage to avoid warnings.
133
14c114ae
JD
1342012-07-31 Jan Djärv <jan.h.d@swipnet.se>
135
136 * nsterm.m (openFiles): Fix previous checkin.
137
3bd21e82
PE
1382012-07-31 Paul Eggert <eggert@cs.ucla.edu>
139
140 * indent.c (compute_motion): Remove unused local.
141
c1529ded
GM
1422012-07-31 Glenn Morris <rgm@gnu.org>
143
400d5621
GM
144 * s/usg5-4-common.h (wait3, WRETCODE): Let configure set them.
145
268e2432
GM
146 * conf_post.h [USG5_4]:
147 Move remaining contents of s/usg5-4-common.h here.
148 * s/usg5-4-common.h: Remove file.
149
7552f3ee
GM
150 * conf_post.h [IRIX6_5]: Move remaining contents of s/irix6-5.h here.
151 * s/irix6-5.h: Remove file.
152
6a381852
GM
153 * conf_post.h [DARWIN_OS]: Move remaining contents of s/darwin.h here.
154 * s/darwin.h: Remove file.
155
c1529ded
GM
156 * conf_post.h [HPUX]: Move random, srandom here from s/hpux10-20.h.
157 * s/hpux10-20.h: Remove file, which is now empty.
158
b429a4ee
GM
1592012-07-30 Glenn Morris <rgm@gnu.org>
160
161 * conf_post.h: New, split from configure.ac's AH_BOTTOM.
162 * Makefile.in (config_h): Add conf_post.h.
163 * makefile.w32-in (CONFIG_H): Add conf_post.h.
164
adff3182
JD
1652012-07-30 Jan Djärv <jan.h.d@swipnet.se>
166
167 * nsterm.m (ns_do_open_file): New variable.
b9031d69 168 (ns_term_init): Set ns_do_open_file to YES after run returns.
adff3182
JD
169 (openFile, openTempFile, openFileWithoutUI, openFiles): Open
170 files only if ns_do_open_file.
171
c32af1e4
PE
1722012-07-30 Paul Eggert <eggert@cs.ucla.edu>
173
7393bcbb
PE
174 * lisp.h (SWITCH_ENUM_CAST): Remove. All uses removed.
175 This no-op macro hasn't been needed for many years.
176 * src/regex.c (SWITCH_ENUM_CAST) [!emacs]: Likewise.
177
c32af1e4
PE
178 Export DIRECTORY_SEP, TYPEMASK, VALMASK to GDB.
179 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]: Add lsb_bits.
180 * lisp.h (enum lsb_bits) [USE_LSB_TAG]: New enum, for
181 gdb_make_enums_visible.
182 (TYPEMASK, VALMASK) [USE_LSB_TAGS]: Now enum constants, not macros.
183 (DIRECTORY_SEP): Now a constant, not a macro.
184
302fc036
EZ
1852012-07-30 Eli Zaretskii <eliz@gnu.org>
186
187 * w32fns.c (w32_wnd_proc): Pass w32_keyboard_codepage to
188 w32_kbd_patch_key as the 2nd arg. (Bug#12082)
189
190 * w32term.c <w32_keyboard_codepage>: Renamed from
191 keyboard_codepage and now external. All users changed.
192
193 * w32term.h: Add declaration of w32_keyboard_codepage.
194
195 * w32inevt.c (w32_kbd_patch_key): Accept an additional argument --
196 the codepage to translate keys to Unicode. If this argument is
197 -1, use the value returned by GetConsoleCP. All callers changed.
198
88fb40b4
PE
1992012-07-30 Paul Eggert <eggert@cs.ucla.edu>
200
0aee6912
PE
201 Update .PHONY listings in makefiles.
202 * Makefile.in (.PHONY): Add all, mostlyclean, clean,
203 bootstrap-clean, distclean, maintainer-clean, versioclean,
204 extraclean, frc.
205
88fb40b4
PE
206 * lisp.h (STRING_BYTES_BOUND): Cast entire result to ptrdiff_t.
207 This is a bit clearer. Fix some commentary typos.
208
0a763bd1
GM
2092012-07-30 Glenn Morris <rgm@gnu.org>
210
32bac6d6
GM
211 * s/netbsd.h: Let configure include signal.h if needed.
212 Remove file, which is now empty.
213
b65e7c46
GM
214 * s/usg5-4-common.h (_longjmp, _setjmp, TIOCSIGSEND):
215 Let configure set them.
216 * s/irix6-5.h (_longjmp, _setjmp, TIOCSIGSEND):
217 No more need to undefine.
0a763bd1 218
169304bd
AS
2192012-07-30 Andreas Schwab <schwab@linux-m68k.org>
220
221 * keymap.c (Fkey_description): Don't remove 0x80 bit from
222 non-single-byte char when adding meta modifier. (Bug#12090)
223
6cd7a139
DA
2242012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
225
226 Convert safe_call to use variable number of arguments.
227 * xdisp.c (safe_call): Convert to use varargs. Adjust users.
228 (safe_call2): Fix comment.
229 * lisp.h (safe_call): Adjust prototype.
230 * coding.c (encode_coding_object): Change to use safe_call2.
231 * xfaces.c (merge_face_heights): Change to use safe_call1.
232
d34d6ffc
GM
2332012-07-30 Glenn Morris <rgm@gnu.org>
234
7b8a48e4 235 * s/aix4-2.h (sigmask): No need to undefine it, since syssignal.h
227f5bd0 236 does that unconditionally. Remove file, which is now empty.
7b8a48e4 237
d34d6ffc
GM
238 * s/freebsd.h, s/gnu-linux.h, s/sol2-6.h, s/unixware.h:
239 Remove empty files.
240
03a660a6
PE
2412012-07-30 Paul Eggert <eggert@cs.ucla.edu>
242
243 Export to GDB most of lisp.h's remaining object-like macros.
244 * lisp.h (min, max): Move earlier, because they're used earlier now.
245 (INTMASK, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK)
246 (CHAR_TABLE_STANDARD_SLOTS, CHARTAB_SIZE_BITS_0)
247 (CHARTAB_SIZE_BITS_1, CHARTAB_SIZE_BITS_2, CHARTAB_SIZE_BITS_3)
248 (DEFAULT_HASH_SIZE, COMPILED_ARGLIST, COMPILED_BYTECODE)
249 (COMPILED_CONSTANTS, COMPILED_STACK_DEPTH, COMPILED_DOC_STRING)
250 (COMPILED_INTERACTIVE, CHAR_ALT, CHAR_SUPER, CHAR_HYPER, CHAR_SHIFT)
251 (CHAR_CTL, CHAR_META, CHAR_MODIFIER_MASK, CHARACTERBITS)
252 (MANY, UNEVALLED, FLOAT_TO_STRING_BUFSIZE, MAX_ALLOCA):
253 Now constants, for GDB. They need not be macros.
254 (MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM, STRING_BYTES_BOUND):
255 Now constants, for GDB, as well as macros, for static initializers.
256 (CHAR_TABLE_STANDARD_SLOTS, CHAR_TABLE_EXTRA_SLOTS):
257 Move to after the definition of struct Lisp_Char_Table,
258 since the former now needs that type defined.
259 (enum CHARTAB_SIZE_BITS, enum CHAR_TABLE_STANDARD_SLOTS)
260 (enum DEFAULT_HASH_SIZE, enum Lisp_Compiled, enum char_bits)
261 (enum maxargs, enum FLOAT_TO_STRING_BUFSIZE, enum MAX_ALLOCA):
262 New enums, for gdb_make_enums_visible.
263 (GLYPH_MODE_LINE_FACE): Remove; unused.
88fb40b4 264 * alloc.c (STRING_BYTES_MAX): Now a constant, not a macro.
03a660a6
PE
265 (gdb_make_enums_visible): Add enum CHARTAB_SIZE_BITS, enum
266 CHAR_TABLE_STANDARD_SLOTS, enum char_bits, enum DEFAULT_HASH_SIZE,
267 enum FLOAT_TO_STRING_BUFSIZE, enum Lisp_Bits, enum Lisp_Compiled,
268 enum maxargs, enum MAX_ALLOCA.
269 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): Remove.
270 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Remove;
271 no longer needed, now that they are done in lisp.h.
272
e499d0ee
DA
2732012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
274
275 Cleanup string bytes checking.
276 * alloc.c (GC_STRING_BYTES, CHECK_STRING_BYTES): Remove. Convert
277 all users to STRING_BYTES or string_bytes if GC_CHECK_STRING_BYTES.
278 (check_string_bytes): Define to empty if not GC_CHECK_STRING_BYTES.
279 (check_sblock, compact_small_strings): Simplify.
280
d5040d2d
PE
2812012-07-29 Paul Eggert <eggert@cs.ucla.edu>
282
283 * lisp.h (LISP_INT_TAG, LISP_INT1_TAG, LISP_STRING_TAG): Remove.
284 These macros are confusing and no longer need to be defined, as
285 the enum values now suffice. All uses replaced with definiens.
286 (Lisp_Int1, Lisp_String): Define directly; this is clearer.
287
7f259ae6
JB
2882012-07-29 Juanma Barranquero <lekktu@gmail.com>
289
290 * makefile.w32-in (LISP_H, $(BLD)/emacs.$(O), $(BLD)/w32inevt.$(O))
291 ($(BLD)/w32console.$(O)): Update dependencies.
292
7e63e0c3
DA
2932012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
294
295 Remove HIDE_LISP_IMPLEMENTATION and cleanup cons free list check.
296 * lisp.h (HIDE_LISP_IMPLEMENTATION): Remove as useless for a long
297 time. Adjust users.
298 (CHECK_CONS_LIST): Remove. Convert all users to check_cons_list.
299
ffd817eb
JD
3002012-07-29 Jan Djärv <jan.h.d@swipnet.se>
301
302 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
303 setting sitelisp (Bug#12010).
304
417a7a0e
EZ
3052012-07-29 Eli Zaretskii <eliz@gnu.org>
306
307 * w32heap.h (OS_9X): Renamed from OS_WINDOWS_95.
308
309 * w32heap.c (cache_system_info):
310 * w32.c (sys_rename):
311 * w32proc.c (find_child_console, sys_kill): All users changed.
312
387d4d92
PE
3132012-07-29 Paul Eggert <eggert@cs.ucla.edu>
314
315 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
316
55a6cca6
EZ
3172012-07-29 Eli Zaretskii <eliz@gnu.org>
318
319 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
320
dbcf001c
DA
3212012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
322
323 Cleanup statistics calculation in Fgarbage_collect.
324 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start. Fix
325 zombies percentage calculation. Simplify elapsed time calculation.
326
e2688e4a
DA
3272012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
328
329 Generalize marker debugging code under MARKER_DEBUG and use eassert.
330 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
331 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
332 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
333 (replace_range, replace_range_2, del_range_2): Change to eassert.
334 * marker.c (byte_char_debug_check): Adjust style.
335
b46a6a83
PE
3362012-07-29 Paul Eggert <eggert@cs.ucla.edu>
337
338 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
339 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
340 long-ago-commented-out code that talks about "WIN32".
341 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
342 All uses changed.
343
e32a5799
PE
3442012-07-28 Paul Eggert <eggert@cs.ucla.edu>
345
346 Use Gnulib stdalign module (Bug#9772, Bug#9960).
347 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
348 Simplify by using alignof.
349 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
350 * lisp.h: Include <stdalign.h>.
351 (GCALIGNMENT): New macro and constant.
352 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
353 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
354 (stdalign): New macro, if not already defined.
355
df81cd29
EZ
3562012-07-28 Eli Zaretskii <eliz@gnu.org>
357
01bd1b0d
EZ
358 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
359 * w32inevt.c: Include w32inevt.h.
360 (w32_read_console_input): New inline function, calls either
361 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
362 w32_console_unicode_input.
363 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
364 (w32_kbd_patch_key, key_event): Use the codepage returned by
365 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
366 (key_event): use uChar.UnicodeChar only if
367 w32_console_unicode_input is non-zero.
368
369 * w32console.c: Include w32heap.h.
370 <w32_console_unicode_input>: New global variable.
371 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
372 family of Windows, zero otherwise.
373
374 * w32inevt.h: Declare w32_console_unicode_input.
375
df81cd29
EZ
376 * xdisp.c (init_iterator): Don't reference tip_frame in a build
377 --without-x. (Bug#11742)
378
c20fdd9e
PE
3792012-07-27 Paul Eggert <eggert@cs.ucla.edu>
380
381 Adjust GDB to reflect pvec_type changes (Bug#12036).
382 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
383 2012-07-04 changes to pseudovector representation. Problem
384 reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
385
32770973 3862012-07-27 Michael Albinus <michael.albinus@gmx.de>
e518bc71
MA
387
388 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
389 bus address.
390 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
391
3438fe21
EZ
3922012-07-27 Eli Zaretskii <eliz@gnu.org>
393
bcfbc9de
EZ
394 * alloc.c (listn): Fix the order the arguments are consed onto the
395 list.
396
3438fe21
EZ
397 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
398 enumeration constants, as PURE and HEAP are too general, and clash
399 with other headers and sources, such as gmalloc.c and the
400 MS-Windows system headers. All users changed.
401
eeaea515
DA
4022012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
403
404 Revert last save_excursion_save and save_excursion_restore changes.
405 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
406 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
407
073c88c2
DA
4082012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
409
410 Fix recently-introduced typos in Windows port.
411 Reported by Martin Rudalics <rudalics@gmx.at>.
412 * w32.c (init_environment): Replace comma with semicolon.
eeaea515 413 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
073c88c2 414
4706125e
PE
4152012-07-27 Paul Eggert <eggert@cs.ucla.edu>
416
417 Improve GDB symbol export (Bug#12036).
418 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
419 arms of an 'if', not using conditional expressions; otherwise GDB
420 complains about the types in the unevaluated arm when the argument
421 is an integer literal.
422 (xgetint): Simplify expression.
423 * alloc.c (gdb_make_enums_visible): New constant. This ports to
424 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
425 Zaretskii in <http://bugs.gnu.org/12036#13>.
426 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
427 needed now that we have gdb_make_enums_visible.
428 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
429 (enum enum_USE_LSB_TAG):
430 New enum types, packaging up enums that need to be exported to GDB.
431
694b6c97
DA
4322012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
433
434 Utility function to make a list from specified amount of objects.
435 * lisp.h (enum constype): New datatype.
436 (listn): New prototype.
437 * alloc.c (listn): New function.
438 (Fmemory_use_count, syms_of_alloc): Use it.
439 * buffer.c (syms_of_buffer): Likewise.
440 * callint.c (syms_of_callint): Likewise.
441 * charset.c (define_charset_internal): Likewise.
442 * coding.c (syms_of_coding): Likewise.
443 * keymap.c (syms_of_keymap): Likewise.
444 * search.c (syms_of_search): Likewise.
445 * syntax.c (syms_of_syntax): Likewise.
446 * w32.c (init_environment): Likewise.
447 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
448 * xdisp.c (syms_of_xdisp): Likewise.
449 * xfns.c (syms_of_xfns): Likewise.
450
6195f384
DA
4512012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
452
453 Fast save_excursion_save and save_excursion_restore.
454 * lisp.h (struct Lisp_Excursion): New data type.
455 (PVEC_EXCURSION): New pseudovector type.
456 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
457 to deal with it. Adjust comments.
458 (init_marker, attach_marker): New prototype.
459 (unchain_marker): Adjust prototype.
460 * marker.c (attach_marker): Change to global.
461 (init_marker): New function.
462 * alloc.c (Fmake_marker, build_marker): Use it.
463 (build_marker): More easserts.
464 (mark_object): Handle struct Lisp_Excursion.
465 * editfns.c (save_excursion_save, save_excursion_restore):
466 Reimplement to use struct Lisp_Excursion. Add comments.
467
5eceb8fb
PE
4682012-07-26 Paul Eggert <eggert@cs.ucla.edu>
469
470 Fix export of symbols to GDB (Bug#12036).
471 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
472 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
473 emacs.c, as this is a more-suitable home. Had this been done earlier
474 the fix for 12036 would have avoided some of the problems noted in
475 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
476 would have been more obvious.
562157c8
PE
477 * emacs.c: Do not include <verify.h>; no longer needed.
478 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
5eceb8fb
PE
479 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
480 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
481 Remove; now done in lisp.h.
482 * lisp.h (PUBLISH_TO_GDB): New macro.
483 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
484 (DATA_SEG_BITS): Use it.
485 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
486 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
487 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
488 not be usable in #if. This simplifies things.
489
d6749401
JB
4902012-07-26 Juanma Barranquero <lekktu@gmail.com>
491
492 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
493
1781b9e9
PE
4942012-07-26 Paul Eggert <eggert@cs.ucla.edu>
495
d89518db 496 Simplify export of symbols to GDB (Bug#12036).
1781b9e9
PE
497 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
498 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
499 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
500 Adjust to changes in lisp.h and emacs.c, by using
501 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
502 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
503 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
504 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
505 instead of gdb_valbits.
506 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
507 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
508 instead of gdb_array_mark_flag.
509 (xboolvector): Get size from $->size, not $->header.size.
510 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
511 (xreload, hook-run, hookpost-run): Remove.
512 * emacs.c: Include <verify.h>.
513 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
514 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
515 Remove.
516 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
517 (gdb_USE_LSB_TAG): New enum constants.
518 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
519 Also define these as enum constants, so they're visible to GDB.
520 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
521 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
522 as constants, so they're visible to GDB.
523 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
524 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
525 Now enum constants, not macros, so they're visible to GDB.
526 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
527 more convenient now. All uses changed.
528 (VALMASK) [USE_LSB_TAG]: Also define in this case.
529 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
530
3628596a
DA
5312012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
532
533 Explicitly free restriction data that are not needed anymore.
534 * editfns.c (save_restriction_restore): Free restriction data.
535
7abaf5cc
SM
5362012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
537
538 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
539 add argument, tune behavior, and adjust all callers.
540
71f88e00
PE
5412012-07-25 Paul Eggert <eggert@cs.ucla.edu>
542
543 Use typedef for EMACS_INT, EMACS_UINT.
544 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
545 than macros. This simplifies debugging in the usual case, since
546 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
547 and it allows expressions involving EMACS_INT casts.
548 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
549
57ec3034
JD
5502012-07-25 Jan Djärv <jan.h.d@swipnet.se>
551
552 * nsterm.m (ns_read_socket): Return early if there is a modal
553 window (Bug#12043).
554
8137e7b3
MR
5552012-07-25 Martin Rudalics <rudalics@gmx.at>
556
557 * frame.c (Fredirect_frame_focus): In doc-string don't mention
558 that FOCUS-FRAME can be omitted.
559
04e9897c
DA
5602012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
561
562 Adjust buffer text indirection counters at the end of Fkill_buffer.
563 * buffer.c (Fkill_buffer): Adjust indirection counters when the
564 buffer is definitely dead. This should really fix an issue reported
565 by Christoph Scholtes again. (Bug#12007).
566 (init_buffer_once): Initialize indirection counters of
567 buffer_defaults and buffer_local_symbols (for sanity and safety).
568
8a0484e1
EZ
5692012-07-24 Eli Zaretskii <eliz@gnu.org>
570
571 * xdisp.c (init_iterator): Don't compute dimensions of truncation
572 and continuation glyphs on tooltip frames, leave them at zero.
573 Avoids continued lines in tooltips. (Bug#11832)
574
fa691a83
DA
5752012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
576
577 Simplify copy_overlay.
04e9897c 578 * buffer.c (copy_overlay): Simplify. Use build_marker.
fa691a83
DA
579 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
580
436bc8e0
EZ
5812012-07-23 Eli Zaretskii <eliz@gnu.org>
582
583 * print.c (print_object): Don't crash when a frame's name is nil
584 or invalid. (Bug#12025)
585
586 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
587 it signals an error when a tooltip frame is being created.
588
d7a7fda3
DA
5892012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
590
591 Cleanup miscellaneous objects allocation and initialization.
592 * alloc.c (allocate_misc): Change to static. Add argument to
593 specify the subtype. Adjust comment and users.
594 (build_overlay): New function.
595 * buffer.c (copy_overlays, Fmake_overlay): Use it.
596 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
597 (allocate_misc): Remove prototype.
598 (build_overlay): Add prototype.
599
6002012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
372f8ffc
DA
601
602 Swap buffer text indirection counters in Fbuffer_swap_text.
603 * buffer.c (Fbuffer_swap_text): Swap indirections too.
604 This avoids crash reported by Christoph Scholtes at
605 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
606
9d7fa573
JD
6072012-07-22 Jan Djärv <jan.h.d@swipnet.se>
608
609 * nsmenu.m (Popdown_data): New struct.
610 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
611 free Popdown_data.
612 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
613 (initWithContentRect): Make imgView and contentView non-static
614 and autorelease them. Also autorelease img and matrix (Bug#12005).
615 (dealloc): Remove (Bug#12005).
616
0dd6d66d
DA
6172012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
618
619 Adjust consing_since_gc when objects are explicitly freed.
620 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
621 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
622 (free_cons, free_misc): Subtract object size from consing_since_gc.
623
d36d71df
DA
6242012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
625
626 Simplify and cleanup markers positioning code.
627 * marker.c (attach_marker): More useful eassert.
628 (live_buffer, set_marker_internal): New function.
629 (Fset_marker, set_marker_restricted): Use set_marker_internal.
630 (set_marker_both, set_marker_restricted_both): Use live_buffer.
631
fb9ea40f
PE
6322012-07-22 Paul Eggert <eggert@cs.ucla.edu>
633
634 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
635 as it's limited by the amount of memory, not by INT_MAX.
636
2d5c5f7d
EZ
6372012-07-21 Eli Zaretskii <eliz@gnu.org>
638
07fb592e
EZ
639 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
640 in special-event-map. See the discussion at
641 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
642 for the reasons.
643
37a9eac8 644 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
2d5c5f7d
EZ
645 info.dwItemData. Fixes crashes on 64-bit Windows. Suggested by
646 Fabrice Popineau <fabrice.popineau@supelec.fr>.
647
c4328746
JD
6482012-07-21 Jan Djärv <jan.h.d@swipnet.se>
649
650 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 651 (conversationIdentifier): Return value is NSInteger.
784051c4 652 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 653
6e5d1c12
CY
6542012-07-21 Chong Yidong <cyd@gnu.org>
655
656 * window.c (decode_any_window): Signal an error if the window is
657 on a dead frame (Bug#11984).
658
9928463d
DA
6592012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
660
661 Add indirection counting to speed up Fkill_buffer.
662 * buffer.h (struct buffer): New member.
663 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
664 (Fmake_indirect_buffer): Set indirection counter to -1, increment
665 base buffer indirection counter.
666 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
667 (Fkill_buffer): Adjust indirection counters as needed, don't walk
668 through buffer list if indirection counter is 0.
669
f8643a6b
DA
6702012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
671
672 Extend the value returned by Fgarbage_collect with heap statistics.
673 * alloc.c (Qheap): New symbol.
674 (syms_of_alloc): DEFSYM it.
675 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
676 (Fmemory_free): Remove.
677 (syms_of_alloc): Don't defsubr it.
678 * buffer.c (Fcompact_buffer): Remove.
679 (syms_of_buffer): Don't defsubr it.
680
dac616ff
DA
6812012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
682
683 Make maybe_gc inline.
684 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
685 * lisp.h (consing_since_gc, gc_relative_threshold)
686 (memory_full_cons_threshold): Revert declaration.
687 (maybe_gc): Remove prototype, define as inline.
688 * alloc.c: Remove old commented-out code.
689 (consing_since_gc, gc_relative_threshold)
690 (memory_full_cons_threshold): Revert to global.
691 (maybe_gc): Remove.
692
d7ea76b4
DA
6932012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
694
695 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
696 * lisp.h (build_unibyte_string): New function.
697 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
698 * sysdep.c, w32fns.c, xfns.c: Use it.
699 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
700 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
701 Adjust users accordingly.
702 * font.h (font_open_by_name): Adjust prototype.
703
765e61e3
DA
7042012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
705
706 Cleanup calls to Fgarbage_collect.
707 * lisp.h (maybe_gc): New prototype.
708 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
709 Remove declarations.
710 * alloc.c (maybe_gc): New function.
711 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
712 Make them static.
713 * bytecode.c (MAYBE_GC): Use maybe_gc.
714 * eval.c (eval_sub, Ffuncall): Likewise.
715 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
716 to avoid dependency from auto-save feature.
717
52b852c7
PE
7182012-07-19 Paul Eggert <eggert@cs.ucla.edu>
719
720 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
721 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
722 'for_each_per_buffer_object_at'.
723 All uses changed. It's better to use upper-case for macros that
724 cannot be implemented as functions, to give the reader a clue
725 that they're special.
726
5db81e33
SM
7272012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
728
729 * alloc.c (Fgarbage_collect): Tweak docstring.
730
5b835e1d
DA
7312012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
732
733 Tweak the value returned from Fgarbage_collect again.
734 * alloc.c (Fgarbage_collect): New return value, as confirmed in
735 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
736 Adjust documentation.
737 (total_vector_bytes): Rename to total_vector_slots, adjust
738 accounting.
739 (total_free_vector_bytes): Rename to total_free_vector_slots,
740 adjust accounting.
741 (Qstring_bytes, Qvector_slots): New symbols.
742 (syms_of_alloc): DEFSYM them.
743
9cd47b72
DA
7442012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
745
746 Buffer compaction primitive which may be used from Lisp.
747 * buffer.c (compact_buffer, Fcompact_buffer): New function.
748 (syms_of_buffer): Register Fcompact_buffer.
749 * alloc.c (Fgarbage_collect): Use compact_buffer.
750 * buffer.h (compact_buffer): New prototype.
751 (struct buffer_text): New member.
752
d17337e5
DA
7532012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
754
755 New macro to iterate over all buffers, miscellaneous cleanups.
756 * lisp.h (all_buffers): Remove declaration.
757 * buffer.h (all_buffers): Add declaration, with comment.
758 (for_each_buffer): New macro.
759 * alloc.c (Fgarbage_collect, mark_object): Use it.
760 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
761 (init_buffer): Likewise.
762 * data.c (Fset_default): Likewise.
763 * coding.c (code_conversion_restore): Remove redundant check
764 for dead buffer.
765 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
766
60cfd278
AS
7672012-07-18 Andreas Schwab <schwab@linux-m68k.org>
768
769 Fix bug that created negative-length intervals.
770 * intervals.c (merge_interval_right, merge_interval_left):
771 Do not zero out this interval if it is absorbed by its children,
772 as this interval's total length doesn't change in that case. See
773 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
774
d06714cb
PE
7752012-07-18 Paul Eggert <eggert@cs.ucla.edu>
776
83713154
PE
777 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
778 when invoking (make-bool-vector N t) and N is a positive
779 multiple of 8 -- the last 8 bits were mistakenly cleared.
780
d06714cb
PE
781 Remove some struct layout assumptions in bool vectors.
782 * alloc.c (bool_header_size): New constant.
783 (header_size, word_size): Move earlier, as they're now used earlier.
784 Use 'word_size' in a few more places, where it's appropriate.
785 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
786 padding before the data member of a bool vector.
787 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
788 than doing the check by hand with an abort ().
789
464d5a5e
SM
7902012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
791
5fbc0409
SM
792 * eval.c (Fdefvar): Don't check constants since we only set the var if
793 it's not yet defined anyway (bug#11904).
794
464d5a5e
SM
795 * lisp.h (last_undo_boundary): Declare new var.
796 * keyboard.c (command_loop_1): Set it.
797 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
798 were auto-added by the command loop (bug#11774).
799
8dc2e44a
AS
8002012-07-18 Andreas Schwab <schwab@linux-m68k.org>
801
802 * w32font.c (Qsymbol): Remove local definition.
803 (syms_of_w32font): Don't DEFSYM it.
804
169925ec
DA
8052012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
806
807 Fix sweep_vectors to handle large bool vectors correctly.
808 * alloc.c (sweep_vectors): Account total_vector_bytes for
809 bool vectors larger than VBLOCK_BYTES_MAX.
810
5fbfb018
CY
8112012-07-18 Chong Yidong <cyd@gnu.org>
812
813 * frame.c (x_set_frame_parameters): Revert bogus change introduced
814 in 2012-05-25 commit by Paul Eggert (Bug#11738).
815
3ab6e069
DA
8162012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
817
818 Return more descriptive data from Fgarbage_collect.
819 Suggested by Stefan Monnier in
820 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
821 * alloc.c (bounded_number): New function.
822 (total_buffers, total_vectors): New variable.
823 (total_string_size): Rename to total_string_bytes, adjust users.
824 (total_vector_size): Rename to total_vector_bytes, adjust users.
825 (sweep_vectors): Account total_vectors and total_vector_bytes.
826 (Fgarbage_collect): New return value. Adjust documentation.
827 (gc_sweep): Account total_buffers.
828 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
829 (VECTOR_SIZE): Remove.
830 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
831 (Qinterval, Qmisc): New symbols.
832 (syms_of_data): Initialize them.
833 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
834 (Qcons, Qbuffer): New declarations.
835
6d02fe5b
PE
8362012-07-17 Paul Eggert <eggert@cs.ucla.edu>
837
838 * alloc.c (Fmemory_free): Account for memory-free's own storage.
839 Round up, not down. Improve doc.
840
b7ffe040
DA
8412012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
842
843 Restore old code in allocate_string_data to avoid Faset breakage.
844 Reported by Julien Danjou <julien@danjou.info> in
845 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
846 * alloc.c (allocate_string_data): Restore old code with minor
847 adjustments, fix comment to explain this subtle issue.
848
4dc7c8d5
SM
8492012-07-17 Eli Zaretskii <eliz@gnu.org>
850
851 Remove FILE_SYSTEM_CASE.
852 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
853
854 * fileio.c (FILE_SYSTEM_CASE): Don't define.
855 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
856 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
857 call-process-region passes it through expand-file-name.
858
859 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
860
8612012-07-17 Andreas Schwab <schwab@linux-m68k.org>
862
863 Fix crash when creating indirect buffer (Bug#11917)
864 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
865 Don't handle unbound variables specially if non-zero.
866 (Fbuffer_local_variables): Pass zero.
867 (clone_per_buffer_values): Pass non-zero.
868
8692012-07-17 Andreas Schwab <schwab@linux-m68k.org>
870
871 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
872 to make the loop interruptible.
873
8742012-07-17 Andreas Schwab <schwab@linux-m68k.org>
875
876 * gnutls.c (emacs_gnutls_handshake): Only retry if
877 GNUTLS_E_INTERRUPTED.
878
cce7fefc
DA
8792012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
880
881 Cleanup and convert miscellaneous checks to eassert.
882 * alloc.c (mark_interval): Fix comment, partially rephrase
883 old comment from intervals.h (see below).
884 * intervals.c (find_interval, adjust_intervals_for_insertion)
885 (delete_interval, adjust_intervals_for_deletion)
886 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
887 Convert to eassert.
888 (adjust_intervals_for_insertion, make_new_interval):
889 Remove obsolete and unused code.
890 * intervals.h (struct interval): Remove obsolete comment.
891 * textprotp.c (erase_properties): Remove unused code.
892 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
893 (Fremove_list_of_text_properties): Convert to eassert.
894
9ea10cc3
CY
8952012-07-17 Chong Yidong <cyd@gnu.org>
896
897 * editfns.c (Finsert_char): Doc fix.
898
3900d5de
DA
8992012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
900
901 Fix previous change to make Fmemory_free always accurate.
902 * alloc.c (make_interval): Update total_free_intervals.
903 (make_float): Likewise for total_free_floats.
904 (free_cons, Fcons): Likewise for total_free_conses.
905 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
906 Likewise for total_free_vector_bytes.
907 (Fmake_symbol): Likewise for total_free_symbols.
908 (bytes_free): Remove.
909
7098646f
DA
9102012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
911
912 Simple free memory accounting feature.
913 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
914 (sweep_vectors): Accumulate size of free vectors.
915 (Fgarbage_collect): Setup bytes_free.
916 (Fmemory_free): New function.
917 (syms_of_alloc): Register it.
918
22657b40
DA
9192012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
920
921 Cleanup overlays checking.
922 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
923 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
924 eassert and OVERLAYP.
925 (sort_overlays): Change to use OVERLAYP.
926
ddfc8813
RK
9272012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
928
929 * editfns.c (Finsert_char): Make it interactive, and make the
930 second arg optional. Copy interactive spec and docstring from
931 ucs-insert.
932
7c26cf3c
PE
9332012-07-17 Paul Eggert <eggert@cs.ucla.edu>
934
935 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
936 Unlike the other wrapped functions, fabs has an unspecified
937 effect on errno.
938
5d127af9
JD
9392012-07-16 Jan Djärv <jan.h.d@swipnet.se>
940
941 * nsterm.m (keyDown): Interpret flags without left/right bits
942 as the left key (Bug#11670).
943
6a0dd1d7
DA
9442012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
945
946 Remove empty and useless init functions.
947 * lisp.h (init_character_once, init_fns, init_image)
948 (init_filelock, init_sound): Remove prototype.
949 * character.c (init_character_once): Remove.
950 * filelock.c (init_filelock): Likewise.
951 * fns.c (init_fns): Likewise.
952 * image.c (init_image): Likewise.
953 * sound.c (init_sound): Likewise.
954 * emacs.c (main): Adjust accordingly.
955
7a6136fd
DA
9562012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
957
958 * gtkutil.h: Tiny cleanups.
959 (use_old_gtk_file_dialog): Remove useless declaration.
960 (xg_uses_old_file_dialog): Add suggested const attribute.
961
ce811ad9
EZ
9622012-07-15 Eli Zaretskii <eliz@gnu.org>
963
964 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
965 (bidi_paragraph_init): Use it to limit search forward for a strong
966 directional character in abnormally large paragraphs full of
967 neutral or weak characters. (Bug#11943)
968
c9adfeaa
SF
9692012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
970
971 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
972 the toolbar (Bug#9451).
973 (xg_make_tool_item): Give the widget event box a transparent
974 background.
975
fff62aa9
DA
9762012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
977
978 Cleanup basic allocation variables and functions.
979 * alloc.c (ignore_warnings, init_intervals, init_float)
980 (init_cons, init_symbol, init_marker): Remove.
981 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
982 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
983 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
984 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
985 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
986 (staticidx, init_alloc_once, init_strings, free_ablock):
987 Remove redundant initialization.
988 * fns.c (init_weak_hash_tables): Remove.
989 * lisp.h (init_weak_hash_tables): Remove prototype.
990
9730daca
DA
9912012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
992
993 Use zero_vector where appropriate.
994 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
995 accordingly.
996 * lisp.h (zero_vector): New declaration.
997 * font.c (null_vector): Remove.
998 (syms_of_font): Remove initialization and staticpro.
999 (font_list_entities, font_find_for_lface): Change to use zero_vector.
1000 * keymap.c (Faccessible_keymaps): Likewise.
1001
2e2d2a13
LL
10022012-07-15 Leo Liu <sdl.web@gmail.com>
1003
1004 * fringe.c: Fix typo in comments.
1005
cd276f6e
LL
10062012-07-14 Leo Liu <sdl.web@gmail.com>
1007
1008 * fringe.c: Add a new bitmap exclamation-mark.
1009
5a1131d9
EZ
10102012-07-14 Eli Zaretskii <eliz@gnu.org>
1011
1012 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
1013
1014 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
1015 (HAVE_MENUS): Don't define, defined by editing config.in with
1016 msdos/sed2v2.inp.
1017 (GMALLOC_INHIBIT_VALLOC): Don't define.
1018 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
1019
22e983b7
JB
10202012-07-14 Juanma Barranquero <lekktu@gmail.com>
1021
1022 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
1023
5b3f250f
GM
10242012-07-14 Glenn Morris <rgm@gnu.org>
1025
1026 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
1027 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
1028 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
1029
33d63ff4
GM
10302012-07-13 Glenn Morris <rgm@gnu.org>
1031
5b633342
GM
1032 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
1033
33d63ff4
GM
1034 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
1035 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
1036
b55b9f85
JD
10372012-07-13 Jan Djärv <jan.h.d@swipnet.se>
1038
0dc8cf50
JD
1039 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
1040 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
1041 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
1042 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
1043 where appropriate.
1044 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
1045 as boolean expression.
1046 (x_set_window_size): Remove unused variable toolbar.
1047 (ns_get_color_default, ns_mod_to_lisp): Remove.
1048 (ns_mouse_position): Remove unused variables xchar and ychar.
1049 (ns_compute_glyph_string_overhangs): Remove unused variable face.
1050 (ns_set_vertical_scroll_bar): Remove unused variable count.
1051 (ns_delete_terminal): Remove unused variable i.
1052 (ns_term_init): Remove unused variables r, g and b.
1053 (mouseDown): Remove unused variable window.
1054 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
1055 (initFrameFromEmacs): Remove unused variable vbextra.
1056 (mouseEntered): Remove unused variables p and dpyinfo.
1057 (mouseExited): Remove unused variables p and r.
1058 (ns_define_frame_cursor, ns_clear_frame_area)
1059 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
1060 (menuDown): Assign [sender tag] to variable and cast the variable.
1061
1062 * nsterm.h (menuDown): Add id as type to argument sender.
1063 (ns_display_info_for_name): Add Lisp_Object argument.
1064 (ns_term_init): Add Lisp_Object argument.
1065 (ns_map_event_to_object): Add void argument.
1066 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
1067 prototype with arguments and only declare if __OBJC__.
1068 (nxatoms_of_nsselect): Add void argument.
1069 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
1070 (ns_alloc_autorelease_pool): Add void argument.
1071 (ns_release_autorelease_pool): Add void* argument.
1072 (ns_get_defaults_value): Add const char* argument.
1073
1074 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
1075 (initFromContents): Use SSDATA where appropriate.
1076 (ns_update_menubar): Add braces to ambigous if-else.
1077 (initWithTitle): Put () around assignment in if statement.
1078 (ns_menu_show): Remove unused variables window and keymap.
1079 (update_frame_tool_bar): Remove unused variable selected_p.
1080 (initWithContentRect): Remove unused variable this_cmd_name.
1081
1082 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
1083 appropriate.
1084 (setXBMColor): Remove unused variable len.
1085 (setPixmapData): Put () around assignment in loop statement.
1086
1087 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
1088 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
1089 where appropriate.
1090 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
1091 around assignment in loop statement.
1092 (nsfont_open): Remove unused variable i.
1093 (nsfont_open): Remove unused variable len.
1094 (nsfont_draw): Remove unused variable cs.
1095
1096 * nsfns.m (x_set_icon_name, ns_set_name_internal)
1097 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
1098 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
1099 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
1100 (Fns_font_name, Fns_perform_service)
1101 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
1102 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
1103 (ns_set_name): Remove unused variable view.
1104 (x_set_menu_bar_lines): Remove unused variable olines.
1105 (x_set_tool_bar_lines): Remove unused variable root_window.
1106 (Fns_list_colors): Put () around assignment in while statement.
1107 (Fns_perform_service): Remove unused variable len.
1108 (Fns_display_usable_bounds): Remove unused variable top.
1109 (syms_of_nsfns): Remove unused variable i.
1110
b55b9f85
JD
1111 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
1112 memcpy (Bug#11907).
1113
ed9265fc 11142012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
1115
1116 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
1117 and free it with DestroyExceptionInfo (Bug#11558).
1118
ef099b57
JB
11192012-07-13 Juanma Barranquero <lekktu@gmail.com>
1120
1121 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
1122 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
1123 Set here, not in nt/config.nt.
1124
ea814a5d
EZ
11252012-07-13 Eli Zaretskii <eliz@gnu.org>
1126
1127 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
1128 cursor overflow into the last glyph on display line when the right
1129 fringe is off. (Bug#11832)
1130
1a952767
PE
11312012-07-13 Paul Eggert <eggert@cs.ucla.edu>
1132
1133 * xdisp.c (produce_special_glyphs): Now static.
1134 * dispextern.h (produce_special_glyphs): Remove decl.
1135
983188fd
GM
11362012-07-13 Glenn Morris <rgm@gnu.org>
1137
8d7c7eed 1138 * s/bsd-common.h, s/cygwin.h: Remove empty files.
32fb4bb6
GM
1139 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
1140
983188fd
GM
1141 * s/usg5-4-common.h (USG, USG5):
1142 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
1143 * s/sol2-6.h (SOLARIS2):
1144 * s/irix6-5.h (IRIX6_5):
1145 * s/hpux10-20.h (USG, USG5, HPUX):
1146 * s/gnu-linux.h (USG, GNU_LINUX):
1147 * s/freebsd.h (BSD_SYSTEM):
1148 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
1149 * s/cygwin.h (CYGWIN):
1150 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
1151 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
1152
d1e68667 11532012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
1154
1155 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 1156
6de0e799
GM
11572012-07-13 Glenn Morris <rgm@gnu.org>
1158
739ae010
GM
1159 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
1160
dbee5793
GM
1161 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
1162
6de0e799
GM
1163 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
1164 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
1165
b82da769
GM
11662012-07-12 Glenn Morris <rgm@gnu.org>
1167
4fae5a7a 1168 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
1169
1170 * process.c (init_process_emacs): Rename from init_process.
1171 The old name is also the name of a Mach system call.
1172 * lisp.h, emacs.c: Update for this name change.
1173 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
1174 longer needed.
1175
5a979817
EZ
11762012-07-12 Eli Zaretskii <eliz@gnu.org>
1177
1178 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
1179 memmove call that removes glyphs covered by the left truncation
1180 glyph. Improve commentary.
1181 (display_line): Fix display of continuation glyphs on GUI frames
1182 when the right fringe is turned off and variable-size fonts are
1183 used in the window. Move the code that appends a stretch glyph to
1184 produce_special_glyphs, so that it could be used for truncation
1185 and continuation glyphs alike.
1186 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
1187 glyph of a suitably computed width, to align the special glyphs at
1188 the window margin. Code moved from display_line. (Bug#11832)
1189
3e91a053
GM
11902012-07-12 Glenn Morris <rgm@gnu.org>
1191
ba9e4b84
GM
1192 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
1193
1194 * s/gnu-linux.h, s/hpux10-20.h:
1195 Do not unconditionally define HAVE_XRMSETDATABASE.
1196
3e91a053
GM
1197 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
1198
b300b1f4
PE
11992012-07-12 Paul Eggert <eggert@cs.ucla.edu>
1200
1201 Fix typos that broke OS X build.
1202 Reported by Randal L. Schwartz in
1203 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
1204 * nsterm.m (ns_timeout): Add missing local decl.
1205 (ns_get_color): snprintf -> sprintf, to fix typo.
1206
6e777848
GM
12072012-07-12 Glenn Morris <rgm@gnu.org>
1208
3f922c37
GM
1209 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
1210 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
1211 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
1212 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
1213
0ab7b23a
GM
1214 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
1215 Move PTY_OPEN to configure.
1216
6e777848
GM
1217 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1218 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
1219 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
1220
4a7edc24
DA
12212012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
1222
1223 Use empty_unibyte_string where applicable.
1224 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
1225 * lread.c (read1): Likewise.
1226 * xsettings.c (syms_of_xsettings): Likewise.
1227
308aab79
GM
12282012-07-12 Glenn Morris <rgm@gnu.org>
1229
42bd1719
GM
1230 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
1231 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
1232 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
1233 * s/hpux10-20.h (RUN_TIME_REMAP):
1234 * s/bsd-common.h (TABDLY): Move to configure.
1235
1236 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
1237
1238 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
1239
ea0bbd17 1240 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 1241 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
1242
1243 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 1244
308aab79
GM
1245 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
1246 * s/template.h: Move NARROWPROTO to configure.
1247
ee1cf5cf
GM
12482012-07-11 Glenn Morris <rgm@gnu.org>
1249
30fe9bf4
GM
1250 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
1251 unused since 2011-01-17 change to systty.h.
1252
ee1cf5cf
GM
1253 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
1254 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1255 Move HAVE_PTYS and HAVE_SOCKETS to configure.
1256
63e47e07
PE
12572012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1258
1259 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
1260
c43fb4c3
GM
12612012-07-11 Glenn Morris <rgm@gnu.org>
1262
1263 * s/darwin.h, s/gnu-linux.h, s/template.h:
1264 Move INTERRUPT_INPUT to configure.
1265
e8df9267
DA
12662012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1267
1268 Minor adjustments to interning code.
1269 * lisp.h (intern, intern_c_string): Redefine as static inline
1270 wrappers for intern_1 and intern_c_string_1, respectively.
1271 (intern_1, intern_c_string_1): Rename prototypes.
2bce5643
DA
1272 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
1273 Vobarray checking.
e8df9267
DA
1274 * font.c (font_intern_prop): Likewise. Adjust comment.
1275 * w32font.c (intern_font_name): Likewise.
1276
34348bd4
AS
12772012-07-11 Andreas Schwab <schwab@linux-m68k.org>
1278
d96a1e0c
AS
1279 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
1280
34348bd4
AS
1281 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
1282 of Fcar/Fcdr if possible.
1283 * font.c (check_otf_features): Likewise.
1284 * fontset.c (Fnew_fontset): Likewise.
1285 * gnutls.c (Fgnutls_boot): Likewise.
1286 * minibuf.c (read_minibuf): Likewise.
1287 * msdos.c (IT_set_frame_parameters): Likewise.
1288 * xmenu.c (Fx_popup_dialog): Likewise.
1289 * w32menu.c (Fx_popup_dialog): Likewise.
1290
c8add24e
GM
12912012-07-11 Glenn Morris <rgm@gnu.org>
1292
4b575b3c
GM
1293 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
1294 since nothing has defined it on these platforms.
1295
09f4e3b0
GM
1296 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
1297 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
1298
172bedef
GM
1299 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1300 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1301 Move CLASH_DETECTION to configure.
1302
249685df
GM
1303 * s/gnu.h: Remove file, which is now empty.
1304
c8add24e
GM
1305 * s/gnu.h, s/gnu-linux.h:
1306 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
1307
b41253a3
JW
13082012-07-11 John Wiegley <johnw@newartisans.com>
1309
1310 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
1311 function attribute, so we only use it if it exists in the
1312 compiler.
1313
d923b542
DA
13142012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1315
1316 Avoid call to strlen in fast_c_string_match_ignore_case.
1317 * search.c (fast_c_string_match_ignore_case): Change to use
1318 length argument. Adjust users accordingly.
1319 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
1320
5ebbef1d
PE
13212012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1322
bb352260
PE
1323 Assume mkdir, rmdir.
1324 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
1325 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
1326
57054ddd
PE
1327 Assume rename.
1328 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
1329
b747d3f7
PE
1330 Assume perror.
1331 * s/hpux10-20.h (HAVE_PERROR): Remove.
1332 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
1333 Remove dummy definition, as this problem was obsolete long ago.
1334
5ebbef1d
PE
1335 Assume strerror.
1336 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
1337
984e7f30
DA
13382012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1339
1340 Avoid calls to strlen in font processing functions.
1341 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
d923b542 1342 (font_open_by_name): Change to use length argument. Adjust
984e7f30 1343 users accordingly.
d923b542
DA
1344 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
1345 Adjust prototypes.
1346 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
1347 Change to return ptrdiff_t.
984e7f30
DA
1348 (xfont_list_pattern, xfont_match): Use length returned by
1349 xfont_decode_coding_xlfd.
1350 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
1351
20e94fdd
GM
13522012-07-11 Glenn Morris <rgm@gnu.org>
1353
9d596af3
GM
1354 * s/darwin.h, s/freebsd.h, s/netbsd.h:
1355 Move DONT_REOPEN_PTY to configure.
1356
20e94fdd
GM
1357 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
1358 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
1359
e99a530f
PE
13602012-07-10 Paul Eggert <eggert@cs.ucla.edu>
1361
22ffb973
PE
1362 Remove "#define unix" that is no longer needed (Bug#11905).
1363 * s/aix4-2.h (unix): Remove; no longer needed.
1364
e9a9ae03
PE
1365 EMACS_TIME simplification (Bug#11875).
1366 This replaces macros (which typically do not work in GDB)
1367 with functions, typedefs and enums, making the code easier to debug.
1368 The functional style also makes code easier to read and maintain.
1369 * systime.h: Include <sys/time.h> on all hosts, not just if
1370 WINDOWSNT, since 'struct timeval' is needed in general.
1371 (EMACS_TIME): Now a typedef, not a macro.
1372 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
1373 not macros.
1374 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
1375 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
1376 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
1377 (EMACS_TIME_LE): Now functions, not macros.
1378 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
1379 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
1380 which are not functions. All uses rewritten to use:
1381 (make_emacs_time): New function.
1382 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
1383 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
1384 not functions. All uses rewritten to use the following, respectively:
1385 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
1386 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 1387 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
1388 * fileio.c (Fcopy_file):
1389 * xterm.c (XTflash): Get the current time closer to when it's used.
1390 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
1391
ffacb126
PE
1392 * bytecode.c (targets): Suppress -Woverride-init warnings.
1393
e99a530f
PE
1394 Simplify by avoiding confusing use of strncpy etc.
1395 * doc.c (Fsnarf_documentation):
1396 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
1397 * frame.c (Fmake_terminal_frame):
1398 * gtkutil.c (get_utf8_string):
1399 * lread.c (openp):
1400 * nsmenu.m (ns_update_menubar):
1401 * regex.c (regerror):
1402 Prefer memcpy to strncpy and strncat when either will do.
1403 * fileio.c (Fsubstitute_in_file_name):
1404 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
1405 (menu_separator_name_p):
1406 * nsmenu.m (ns_update_menubar):
1407 Prefer memcmp to strncmp when either will do.
1408 * nsterm.m: Include <ftoastr.h>.
1409 (ns_get_color):
1410 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
1411 Prefer snprintf to strncpy.
1412 * nsterm.m (ns_term_init):
1413 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
1414 * nsterm.m (ns_term_init):
1415 Avoid the need for strncpy, by using build_string or
1416 make_unibyte_string directly. Use dtoastr, not snprintf.
1417 * process.c (Fmake_network_process): Diagnose service names that
1418 are too long, rather than silently truncating them or creating
1419 non-null-terminated names.
1420 (Fnetwork_interface_info): Likewise, for interface names.
1421 * sysdep.c (system_process_attributes) [GNU_LINUX]:
1422 Prefer sprintf to strncat.
1423 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
1424 Prefer vsnprintf to vsprintf + strncpy.
1425
c59592b3
GM
14262012-07-10 Glenn Morris <rgm@gnu.org>
1427
1428 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
1429 Clarify fallback case.
1430
7d7bbefd
DA
14312012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1432
1433 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
1434 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
1435 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 1436 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
1437 where argument type is known to be a Lisp_Cons.
1438
3a4c8000
TT
14392012-07-10 Tom Tromey <tromey@redhat.com>
1440
1441 * bytecode.c (BYTE_CODE_THREADED): New macro.
1442 (BYTE_CODES): New macro. Replaces all old byte-code defines.
1443 (enum byte_code_op): New type.
1444 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
1445 (exec_byte_code): Use them. Use token threading when applicable.
1446
2a0213a6
DA
14472012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1448
1449 Optimize pure C strings initialization.
1450 * lisp.h (make_pure_string): Fix prototype.
1451 (build_pure_c_string): New function, defined as static inline. This
1452 provides a better opportunity to optimize away calls to strlen when
1453 the function is called with compile-time constant argument.
1454 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
1455 argument, adjust users accordingly. Use build_pure_c_string where
1456 appropriate.
1457 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
1458 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
1459 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
1460
cb1caeaf
DA
14612012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1462
1463 Avoid calls to strlen in miscellaneous functions.
1464 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
1465 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
1466 * lread.c (openp): Likewise.
1467
c293e30c
DA
14682012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1469
1470 Avoid calls to strlen in path processing functions.
1471 * fileio.c (file_name_as_directory): Add comment. Change to add
1472 srclen argument and return the length of result. Adjust users
1473 accordingly.
1474 (directory_file_name): Fix comment. Change to add srclen argument,
cb1caeaf 1475 swap 1st and 2nd arguments to obey the common convention. Adjust
c293e30c
DA
1476 users accordingly.
1477 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
1478
9e059e3f
GM
14792012-07-10 Glenn Morris <rgm@gnu.org>
1480
d02eb359
GM
1481 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
1482 Move PENDING_OUTPUT_COUNT definition to configure.
1483
882cf227
GM
1484 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
1485 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
1486 * s/gnu.h (DATA_START): Move definitions to configure.
1487
af6e839f
GM
1488 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
1489 We include usg5-4-common.h, which defines them both.
1490
40289a12
GM
1491 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
1492 O_RDONLY already includes it).
1493
9e059e3f
GM
1494 Stop ns builds setting the EMACSLOADPATH environment variable.
1495 * nsterm.m (ns_load_path): Rename from ns_init_paths.
1496 Now it does not set EMACSLOADPATH, just returns the load-path string.
1497 * nsterm.h: Update accordingly.
1498 * lread.c [HAVE_NS]: Include nsterm.h.
1499 (init_lread) [HAVE_NS]: Use ns_load_path.
1500 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
1501
7c4e8ec0
GM
15022012-07-09 Glenn Morris <rgm@gnu.org>
1503
d4f600ff
GM
1504 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
1505 since the included bsd-common.h does so.
1506
cbb31951
GM
1507 Stop ns builds setting the EMACSPATH environment variable.
1508 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
1509 (ns_init_paths): Do not set EMACSPATH.
1510 * nsterm.h (ns_exec_path): Add it.
1511 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
1512 Use ns_exec_path.
1513
7c4e8ec0
GM
1514 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
1515
26bccfae
PE
15162012-07-09 Paul Eggert <eggert@cs.ucla.edu>
1517
a0bee46f
PE
1518 * process.c (wait_reading_process_output): 'waitchannels' was unset
1519 when read_kbd || !NILP (wait_for_cell); fix this.
1520
5994c183
PE
1521 Add GCC-style 'const' attribute to functions that can use it.
1522 * character.h (char_resolve_modifier_mask):
1523 * keyboard.h (make_ctrl_char):
1524 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
1525 (init_character_once, next_almost_prime, init_fns, init_image)
1526 (flush_pending_output, init_sound):
1527 * mem-limits.h (start_of_data):
1528 * menu.h (finish_menu_items):
1529 Add ATTRIBUTE_CONST.
1530 * emacs.c (DEFINE_DUMMY_FUNCTION):
1531 Declare the dummy function with ATTRIBUTE_CONST.
1532 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
1533 Add decls with ATTRIBUTE_CONST.
1534
26bccfae
PE
1535 Minor improvements to make_formatted_string.
1536 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
1537 where int is good enough, as vsprintf returns an int.
1538 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
1539
a8290ec3
DA
15402012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1541
1542 Use make_formatted_string to avoid double length calculation.
1543 * lisp.h (make_formatted_string): New prototype.
1544 * alloc.c (make_formatted_string): New function.
1545 * buffer.c (Fgenerate_new_buffer_name): Use it.
1546 * dbus.c (syms_of_dbusbind): Likewise.
1547 * editfns.c (Fcurrent_time_zone): Likewise.
1548 * filelock.c (get_boot_time): Likewise.
1549 * frame.c (make_terminal_frame, set_term_frame_name)
1550 (x_report_frame_params): Likewise.
1551 * image.c (gs_load): Likewise.
1552 * minibuf.c (get_minibuffer): Likewise.
1553 * msdos.c (dos_set_window_size): Likewise.
1554 * process.c (make_process): Likewise.
1555 * xdisp.c (ensure_echo_area_buffers): Likewise.
1556 * xsettings.c (apply_xft_settings): Likewise.
1557
d01ba2f1
GM
15582012-07-09 Glenn Morris <rgm@gnu.org>
1559
1560 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
1561 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
1562 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
1563 * nsterm.h (ns_etc_directory): Add it.
1564 * callproc.c [HAVE_NS]: Include nsterm.h.
1565 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
1566
f1f924b6
DA
15672012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1568
1569 Move marker debugging code under MARKER_DEBUG.
1570 * marker.c (MARKER_DEBUG): Move marker debugging code under
1571 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
1572 for bootstrap with --enable-checking (~3x slowdown reported
1573 by Juanma Barranquero <lekktu@gmail.com>).
1574 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
1575
ab531b66
PE
15762012-07-08 Paul Eggert <eggert@cs.ucla.edu>
1577
1578 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
1579 See <http://bugs.gnu.org/11825#29>.
1580
c4b3bc8a
EZ
15812012-07-08 Eli Zaretskii <eliz@gnu.org>
1582
1583 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
1584 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
1585 (display_line): Add commentary about displaying truncation glyphs
1586 on GUI frames.
1587 (produce_special_glyphs): Move here from term.c.
1588
1589 * term.c (produce_special_glyphs): Move to xdisp.c.
1590
1591 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
1592 section.
c4b3bc8a 1593
b676b881
AS
15942012-07-07 Andreas Schwab <schwab@linux-m68k.org>
1595
f17c5273
AS
1596 * xdisp.c (display_line): Avoid warning about implicit declaration
1597 of FRAME_FONT.
1598
298819b9
AS
1599 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
1600
b676b881
AS
1601 * lisp.h: Remove empty conditional.
1602
6045c4fd
PE
16032012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1604
b3350bf9
PE
1605 * lread.c (load_path_check): Now static.
1606
6045c4fd
PE
1607 Fix some minor --with-ns problems found by static checking.
1608 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
1609 (x_set_font) [!HAVE_X_WINDOWS]:
1610 * image.c (xpm_load_image) [HAVE_NS]:
1611 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
1612 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
1613 Remove unused local.
1614 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
1615 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
1616 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
1617 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
1618 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
1619 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
1620 Fix pointer signedness problem.
1621 * xfaces.c (FRAME_X_FONT_TABLE):
1622 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
1623
929e7845
GM
16242012-07-07 Glenn Morris <rgm@gnu.org>
1625
1626 * lread.c (load_path_check): New function, split from init_lread.
1627 (init_lread): Reorganize. Motivation:
1628 If EMACSLOADPATH is set, check/warn about that rather than the
1629 defaults, which we are not going to use. Hence we can remove
1630 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
1631 Don't warn if site-lisp directories are missing.
1632 If not installed, start from a blank load-path, since
1633 PATH_LOADSEARCH refers to the eventual installation directories.
1634
58dd0aa4
EZ
16352012-07-07 Eli Zaretskii <eliz@gnu.org>
1636
1637 Support truncation and continuation glyphs on GUI frames, when
1638 fringes are disabled. (Bug#11832)
1639 * xdisp.c (init_iterator): Get dimensions of truncation and
1640 continuation glyphs even if on GUI frames. Adjust
1641 it->last_visible_x on GUI frames when the left or right fringes,
1642 or both, are absent.
1643 (start_display, move_it_in_display_line_to): Handle the case of a
1644 GUI frame without a fringe to display continuation or truncation
1645 glyphs.
1646 (insert_left_trunc_glyphs): Support GUI frames: make sure
1647 truncation glyphs overwrite enough glyphs from the current line to
1648 have sufficient space in pixels.
1649 (display_line): Support truncation and continuation glyphs on GUI
1650 frames. If some spare pixels are left on the line after inserting
1651 the truncation glyphs, fill that space with a stretch glyph of a
1652 suitably computed width.
1653
1654 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
1655 produce_glyphs, to support GUI sessions.
1656
31571fd7
PE
16572012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1658
5a16b9bc
PE
1659 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
1660
f3047c75
PE
1661 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
1662
31571fd7
PE
1663 Do not require float-time's arg to fit in time_t (Bug#11825).
1664 This works better on hosts where time_t is unsigned, and where
1665 float-time is applied to the (negative) difference between two times.
1666 * editfns.c (decode_time_components): Last arg is now double *,
1667 not int *, and means to store all the result as a double, without
1668 worrying about whether the seconds part fits in time_t.
1669 All callers changed.
1670 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
1671 All callers changed.
1672 (Ffloat_time): Do not fail merely because the specified time falls
1673 outside of time_t range.
1674
4516fbef
GM
16752012-07-07 Glenn Morris <rgm@gnu.org>
1676
1677 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
1678 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
1679 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
1680
07adc2c6
JB
16812012-07-07 Juanma Barranquero <lekktu@gmail.com>
1682
1683 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
1684 Update dependencies.
1685
1686 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
1687
fd573f31
PE
16882012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1689
fee5959d
PE
1690 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
1691 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
1692 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
1693 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
1694 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
1695 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
1696
fd573f31
PE
1697 * xfont.c (compare_font_names): Redo to omit the need for casts.
1698
ddadbc0e
AS
16992012-07-06 Andreas Schwab <schwab@linux-m68k.org>
1700
fca8d6b6
AS
1701 * xfns.c (Fx_change_window_property): Doc fix.
1702 * w32fns.c (Fx_change_window_property): Doc fix.
1703
ddadbc0e
AS
1704 * w32fns.c (Fx_window_property): Accept the same arguments as the
1705 X Windows version. Doc fix.
1706 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
1707
ed9265fc 17082012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
1709 Eli Zaretskii <eliz@gnu.org>
1710
1711 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
1712 Windows-specific code from nt/config.nt moved here.
1713 Obsolete settings removed.
1714
216ee680
PE
17152012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1716
1717 * process.c: Avoid unnecessary calls to gettime.
1718 (wait_reading_process_output): Don't get the time of day
1719 when gobbling data immediately and not waiting, as there's no need
1720 for it in that case. This removes a FIXME.
1721
bdd091e4
JD
17222012-07-06 Jan Djärv <jan.h.d@swipnet.se>
1723
1724 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
1725 is defined (Bug#11768).
1726
9d44f8ce
DA
17272012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1728
1729 Fix marker debugging code.
1730 * marker.c (byte_char_debug_check): Do not perform the check
1731 if buffer is not multibyte.
090bd7cb
JB
1732 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1733 Call byte_char_debug_check with correct arguments.
9d44f8ce 1734
90fc4786
DA
17352012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1736
1737 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
1738 * marker.c (byte_char_debug_check, count_markers):
1739 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
1740 (byte_debug_flag): Remove.
1741 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1742 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
1743
7b7ae965
DA
17442012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1745
4e57b342
DA
1746 Avoid code repetition in marker-related functions.
1747 * marker.c (attach_marker): New function.
1748 (Fset_marker, set_marker_restricted, set_marker_both)
1749 (set_marker_restricted_both): Use it.
1750 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
1751 Consistently rename charno to charpos.
1752 (marker_position): Add eassert.
1753 (marker_byte_position): Convert to eassert.
1754
17552012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1756
1757 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 1758 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 1759 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 1760
657924ff
DA
17612012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1762
1763 Introduce fast path for the widely used marker operation.
1764 * alloc.c (build_marker): New function.
1765 * lisp.h (build_marker): New prototype.
1766 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
1767 * composite.c (autocmp_chars): Likewise.
1768 * editfns.c (buildmark): Remove.
1769 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
1770 (save_restriction_save): Use build_marker.
1771 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
1772 * window.c (save_window_save): Likewise.
1773
041a49a6
DA
17742012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1775
1776 Do not use Fdelete_overlay in delete_all_overlays
1777 to avoid redundant calls to unchain_overlay.
1778 * buffer.c (drop_overlay): New function.
1779 (delete_all_overlays, Fdelete_overlay): Use it.
1780 * minibuf.c (get_minibuffer): Fix comment.
1781
7dca65a4
PE
17822012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1783
1784 Port to OpenBSD 5.1 amd64.
1785 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
1786 This is needed for OpenBSD, and should be harmless on all BSD systems.
1787 Also, include <sys/sysctl.h>, as it should be available on all
1788 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
1789 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
1790 use p_pid member, not kp_proc.pid.
1791
8eb876e2
GM
17922012-07-06 Glenn Morris <rgm@gnu.org>
1793
1794 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
1795
38182d90
PE
17962012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1797
1798 More xmalloc and related cleanup.
1799 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
1800 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
1801 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
1802 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
1803 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
1804 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
1805 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
1806 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
1807 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
1808 * xterm.c:
1809 Omit needless casts involving void * pointers and allocation.
1810 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
1811 as the former is more robust if P's type is changed.
1812 Prefer xzalloc to xmalloc + memset 0.
1813 Simplify malloc-or-realloc to realloc.
1814 Don't worry about xmalloc returning a null pointer.
1815 Prefer xstrdup to xmalloc + strcpy.
1816 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
1817 growing it.
1818 * keyboard.c (apply_modifiers_uncached): Prefer local array to
1819 alloca of a constant.
1820
6dd5a677
EZ
18212012-07-05 Eli Zaretskii <eliz@gnu.org>
1822
1823 * xdisp.c (display_line): Fix horizontal pixel coordinates when
1824 hscroll is larger than the line width. Fixes long and futile
1825 looping inside extend_face_to_end_of_line (on a TTY) producing
1826 glyphs that are not needed and thrown away.
1827
6b312f0f
DA
18282012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1829
1830 * marker.c (set_marker_restricted_both): Simplify by using
1831 clip_to_bounds.
1832
f520ef9b
PE
18332012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1834
1835 * editfns.c (region_limit): Simplify by using clip_to_bounds.
1836
383b7c95
JD
18372012-07-05 Jan Djärv <jan.h.d@swipnet.se>
1838
1839 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
1840 not defined (Bug#11768).
1841 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
1842 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
1843 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
1844 followed by gtk_box_set_homogeneous (Bug#11768).
1845 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
1846 (update_theme_scrollbar_width, xg_create_scroll_bar):
1847 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
1848 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
1849 (is_box_type): New function (Bug#11768).
1850 (xg_tool_item_stale_p): Call is_box_type.
5293d758 1851 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
1852 with default display (Bug#11768).
1853
d6e7bf45
EZ
18542012-07-05 Eli Zaretskii <eliz@gnu.org>
1855
1856 * xdisp.c (window_hscroll_limited): New function.
1857 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
1858 coordinates when window's hscroll is set to insanely large
1859 values. (Bug#11857)
1860
431391ec
JB
18612012-07-05 Juanma Barranquero <lekktu@gmail.com>
1862
1863 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
1864 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
1865
23f86fce
DA
18662012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1867
1868 Cleanup xmalloc.
1869 * lisp.h (xzalloc): New prototype. Omit needless casts.
1870 * alloc.c (xzalloc): New function. Omit needless casts.
1871 * charset.c: Omit needless casts. Convert all calls to
1872 xmalloc with following memset to xzalloc.
1873 * dispnew.c: Likewise.
1874 * fringe.c: Likewise.
1875 * image.c: Likewise.
1876 * sound.c: Likewise.
1877 * term.c: Likewise.
1878 * w32fns.c: Likewise.
1879 * w32font.c: Likewise.
1880 * w32term.c: Likewise.
1881 * xfaces.c: Likewise.
1882 * xfns.c: Likewise.
1883 * xterm.c: Likewise.
1884 * atimer.c: Omit needless casts.
1885 * buffer.c: Likewise.
1886 * callproc.c: Likewise.
1887 * ccl.c: Likewise.
1888 * coding.c: Likewise.
1889 * composite.c: Likewise.
1890 * doc.c: Likewise.
1891 * doprnt.c: Likewise.
1892 * editfns.c: Likewise.
1893 * emacs.c: Likewise.
1894 * eval.c: Likewise.
1895 * filelock.c: Likewise.
1896 * fns.c: Likewise.
1897 * gtkutil.c: Likewise.
1898 * keyboard.c: Likewise.
1899 * lisp.h: Likewise.
1900 * lread.c: Likewise.
1901 * minibuf.c: Likewise.
1902 * msdos.c: Likewise.
1903 * print.c: Likewise.
1904 * process.c: Likewise.
1905 * region-cache.c: Likewise.
1906 * search.c: Likewise.
1907 * sysdep.c: Likewise.
1908 * termcap.c: Likewise.
1909 * terminal.c: Likewise.
1910 * tparam.c: Likewise.
1911 * w16select.c: Likewise.
1912 * w32.c: Likewise.
1913 * w32reg.c: Likewise.
1914 * w32select.c: Likewise.
1915 * w32uniscribe.c: Likewise.
1916 * widget.c: Likewise.
1917 * xdisp.c: Likewise.
1918 * xmenu.c: Likewise.
1919 * xrdb.c: Likewise.
1920 * xselect.c: Likewise.
1921
0497dc44
PE
19222012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1923
1924 * fileio.c (time_error_value): Check the right error number.
1925 Problem reported by Troels Nielsen in
1926 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
1927
356e7178
PE
19282012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1929
4e71fd89
PE
1930 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
1931 This should be fixed in a better way; see Eli Zaretskii in
1932 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
1933 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
1934
f0941253
PE
1935 * fileio.c (time_error_value): Rename from special_mtime.
1936 The old name's problems were noted by Eli Zaretskii in
1937 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
1938
065c9eb4
PE
1939 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
1940 This variable's comment says Emacs needs at least one GDB-visible
1941 symbol of type enum pvec_type, to work around GDB problems.
1942 The symbol's value doesn't matter.
1943
356e7178
PE
1944 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
1945 that causes compilation to fail on pre-C99 compilers.
1946
ed9265fc 19472012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
1948
1949 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
1950 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
1951
3884d954
DA
19522012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1953
d209e2fb 1954 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
1955 headers for buffer_defaults and buffer_local_symbols.
1956 Reported by Juanma Barranquero <lekktu@gmail.com>.
1957
ee28be33
SM
19582012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1959
1960 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
1961 * lisp.h (enum pvec_type): Use fewer bits.
1962 (PSEUDOVECTOR_SIZE_BITS): New constant.
1963 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
1964 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
1965 change in pvec_type.
1966 (PSEUDOVECTOR_TYPEP): New macro.
1967 (TYPED_PSEUDOVECTORP): Use it.
1968 * fns.c (internal_equal): Adapt code to extract pvectype.
1969 * emacs.c (gdb_pvec_type): Update type.
1970 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
1971 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
1972 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
1973 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
1974 (sweep_vectors): Use it. Use local var `total_bytes' instead of
1975 abusing vector->header.next.nbytes.
1976 (live_vector_p): Use PVEC_TYPE.
1977 (mark_object): Adapt code to extract pvectype. Use switch.
1978
c7f2cd7f
PE
19792012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1980
1981 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
1982 Tighten new eassert a bit.
1983
8ce70ed2
DA
19842012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1985
1986 Fix compilation with --enable-gcc-warnings and -O1
1987 optimization level.
1988 * doprnt.c (doprnt): Change type of tem to int, initialize
1989 to avoid compiler warning. Add eassert.
1990 * search.c (simple_search): Initialize match_byte to avoid
1991 compiler warning. Add eassert.
1992
dea7f1e5
PE
19932012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1994
24a212eb
PE
1995 Avoid weird behavior with large horizontal scrolls.
1996 Without this change, for example, large hscroll values would
1997 mess up Emacs's display on Fedora 15 x86, presumably due to
1998 overflows in int calculations in the display code.
1999 Also, if buffers had long lines, Emacs would freeze.
2000 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
2001 (set_window_hscroll): New function, containing the old guts of
2002 Fset_window_hscroll. Return the clipped value.
2003 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
2004 This avoids the need to check against PTRDIFF_MAX.
2005
dea7f1e5
PE
2006 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
2007
76046526
DA
20082012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2009
2010 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
2011
39adff0d
PE
20122012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2013
63807d47
PE
2014 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
2015 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
2016 since GCC 4.4.6 issues a bogus warning for them.
2017
39adff0d
PE
2018 Fix bugs in file timestamp newness comparisons.
2019 * fileio.c (Ffile_newer_than_file_p):
2020 * lread.c (Fload): Use full timestamp resolution of files,
2021 not just the 1-second resolution, so that files that are only
2022 slightly newer still count as newer.
2023 * fileio.c (Ffile_newer_than_file_p): Don't assume file
2024 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
2025
dbeed9a6
PE
20262012-07-03 Paul Eggert <eggert@cs.ucla.edu>
2027
2028 * fileio.c: Improve handling of file time marker. (Bug#11852)
2029 (special_mtime): New function.
2030 (Finsert_file_contents, Fverify_visited_file_modtime):
2031 Use it to set special mtime values consistently.
2032
636334d6
AS
20332012-07-03 Andreas Schwab <schwab@linux-m68k.org>
2034
2035 * fileio.c (Finsert_file_contents): Properly handle st_mtime
2036 marker for non-existing file. (Bug#11852)
2037
e2017fe2
GM
20382012-07-03 Glenn Morris <rgm@gnu.org>
2039
2040 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
2041 and did not make it into globals.h).
2042
404dbd37
TT
20432012-07-03 Tom Tromey <tromey@redhat.com>
2044
2045 * window.c (Fset_window_margins, Fset_window_fringes)
2046 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
2047 * textprop.c (Fprevious_property_change): No longer static.
2048 * syntax.c (Fsyntax_table_p): No longer static.
2049 * process.c (Fget_process, Fprocess_datagram_address): No longer
2050 static.
2051 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
2052 * keyboard.c (Fcommand_execute): No longer static.
2053 Remove EXFUN.
2054 * insdel.c (Fcombine_after_change_execute): No longer static.
2055 * image.c (Finit_image_library): No longer static.
2056 * fileio.c (Fmake_symbolic_link): No longer static.
2057 * eval.c (Ffetch_bytecode): No longer static.
2058 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
2059 * doc.c (Fdocumentation_property, Fsnarf_documentation):
2060 No longer static.
404dbd37
TT
2061 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
2062 static.
2063 * dired.c (Ffile_attributes): No longer static.
2064 * composite.c (Fcomposition_get_gstring): No longer static.
2065 * callproc.c (Fgetenv_internal): No longer static.
2066
2067 * ccl.h: Remove EXFUNs.
2068 * buffer.h: Remove EXFUNs.
2069 * dispextern.h: Remove EXFUNs.
2070 * intervals.h: Remove EXFUNs.
2071 * fontset.h: Remove EXFUN.
2072 * font.h: Remove EXFUNs.
2073 * dosfns.c (system_process_attributes): Remove EXFUN.
2074 * keymap.h: Remove EXFUNs.
2075 * lisp.h: Remove EXFUNs.
2076 * w32term.h: Remove EXFUNs.
2077 * window.h: Remove EXFUNs.
2078 * xsettings.h: Remove EXFUN.
2079 * xterm.h: Remove EXFUN.
2080
8e4fd1e1
GM
20812012-07-03 Glenn Morris <rgm@gnu.org>
2082
2083 * lisp.h (Frandom): Make it visible to C.
2084 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
2085 buffer for invisible buffers. (Bug#1229)
2086
ca95b3eb
DA
20872012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2088
2089 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
2090 values which aren't power of 2.
2091 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
2092 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
2093 accordingly.
2094
7555c33f
SM
20952012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
2096
2097 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
2098
2099 * alloc.c (mark_object): Revert part of last patch to use `switch'.
2100
d12e8f5a
DA
21012012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2102
2103 * alloc.c (allocate_vector_block): Remove redundant
2104 calls to mallopt if DOUG_LEA_MALLOC is defined.
2105 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
2106 avoid calls to mallopt if zero_vector is returned.
2107
296094c3
DA
21082012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2109
2110 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
2111 is enabled, avoid dereferencing NULL current_sblock if
2112 running undumped.
2113
36429c89
DA
21142012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2115
2116 Cleanup basic buffer management.
2117 * buffer.h (struct buffer): Change layout to use generic vector
2118 marking code. Fix some comments. Change type of 'clip_changed'
2119 to bitfield. Remove unused #ifndef old.
2120 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
2121 (GET_OVERLAYS_AT): Fix indentation.
2122 (for_each_per_buffer_object_at): New macro.
2123 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
2124 (Fbuffer_local_variables): Use it.
2125 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
2126 * alloc.c (allocate_buffer): Adjust to match new layout of
2127 struct buffer. Fix comment.
2128 (mark_overlay): New function.
2129 (mark_buffer): Use it. Use mark_vectorlike to mark normal
2130 Lisp area of struct buffer.
2131 (mark_object): Use it. Adjust marking of misc objects
2132 and related comments.
2133
3b3e4cac
PE
21342012-07-02 Paul Eggert <eggert@cs.ucla.edu>
2135
2136 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
2137 wrapper that is not needed because the wrapped code is a no-op (zero
2138 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
2139 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
2140
cf5c0175
DA
21412012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
2142
2143 * alloc.c (mark_buffer): Simplify. Remove prototype.
2144 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 2145 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
2146 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
2147 redundant calls to mark_vectorlike for bool vectors.
2148
ca26824c
GM
21492012-06-30 Glenn Morris <rgm@gnu.org>
2150
2e4c5312
GM
2151 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
2152
ca26824c
GM
2153 * epaths.in (PATH_SITELOADSEARCH): New.
2154 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
2155 This is rather than relying on --enable-locallisppath elements
2156 having "site-lisp" in their names. (Bug#10208#25, 11658)
2157
0d23c240
EZ
21582012-06-30 Eli Zaretskii <eliz@gnu.org>
2159
c9240d7a
EZ
2160 * w32proc.c (sys_select): Accept and ignore one more argument.
2161
2162 * w32.c (emacs_gnutls_pull): Call select with one more argument.
2163
0d23c240 2164 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 2165 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
2166
2167 * sysdep.c: Don't include dos.h and dosfns.h.
2168
2169 * process.c (sys_select):
2170 * msdos.c (sys_select): Accept one more argument and ignore it.
2171
2172 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
2173 adapt data types and code to that.
2174
2175 * dosfns.c:
2176 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
2177 which clashes with the gnulib function of the same name.
2178
af5a5a98
AS
21792012-06-30 Andreas Schwab <schwab@linux-m68k.org>
2180
c5e4379c
AS
2181 * font.c (font_style_to_value, font_style_symbolic)
2182 (font_prop_validate_style): Add type checks for values in
2183 font_style_table.
2184
af5a5a98
AS
2185 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
2186 argument.
2187 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
2188 uses.
2189
8d38f461
EZ
21902012-06-29 Eli Zaretskii <eliz@gnu.org>
2191
2e5a6631
EZ
2192 * xdisp.c (try_window_id): Undo last change.
2193
8d38f461
EZ
2194 * w32.c (getwd): Adjust commentary about startup_dir.
2195 (init_environment): Always call sys_access, even in non-MSVC
2196 builds. Don't chdir to the directory of the Emacs executable.
2197 This undoes code from 1997 which was justified by the need to
2198 "avoid conflicts when removing and renaming directories". But its
2199 downside was that every relative file name was being interpreted
2200 relative to the directory of the Emacs executable, which can never
2201 be TRT. In particular, it broke sys_access when called with
2202 relative file names.
2203 (sys_access): Map GetLastError to errno.
2204
2af3565e
DA
22052012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2206
2207 * window.h (struct window): Change type of 'fringes_outside_margins'
2208 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 2209 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
2210 Adjust comment.
2211 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
2212 to ptrdiff_t.
2213
c8d3a25c 22142012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 2215
c8d3a25c
GM
2216 * gnutls.c (emacs_gnutls_handshake):
2217 Add QUIT to make the loop interruptible.
57570cd3 2218
c8d3a25c 22192012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 2220
c8d3a25c
GM
2221 * charset.c (init_charset): Make lack of etc/charsets fatal.
2222
3e984ee8
DA
22232012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2224
2225 * editfns.c (region_limit): Fix type mismatch.
2226
ef884f23
DA
22272012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2228
2229 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
2230 undefined. Convert from xassert to eassert.
2231 * nsmenu.m: Convert from xassert to eassert.
2232 * nsterm.m: Likewise.
2233
7d7e0027
SM
22342012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
2235
2236 * editfns.c (region_limit): Clip to narrowing (bug#11770).
2237
aa754e6a
PE
22382012-06-28 Paul Eggert <eggert@cs.ucla.edu>
2239
2240 Avoid integer overflow on scroll-left and scroll-right.
2241 * window.c (HSCROLL_MAX): New macro.
2242 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
2243 overflow when requested scroll falls outside ptrdiff_t range.
2244
80b00b08
DA
22452012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2246
2247 * window.h (struct window): Change type of 'hscroll',
2248 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
2249 'last_modified' and 'last_overlay_modified' to EMACS_INT.
2250 Adjust users accordingly.
2251 * xdisp.c (try_cursor_movement): Replace type check with eassert.
2252 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
2253 from EMACS_INT to ptrdiff_t.
2254 (make_window): Omit redundant initialization.
2255
62b2bcf6
JB
22562012-06-28 Juanma Barranquero <lekktu@gmail.com>
2257
2258 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
2259
45942c7d
DA
22602012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2261
2262 * window.h (struct window): Change type of 'use_time' and
2263 'sequence_number' from Lisp_Object to int.
2264 * frame.c (make_frame): Adjust users accordingly.
2265 * print.c (print_object): Likewise.
2266 * window.c (select_window, Fwindow_use_time, make_parent_window)
2267 (make_window): Likewise.
2268
e509cfa6
DA
22692012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2270
2271 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
2272 enabled with --enable-checking=[all,glyphs] configure option.
2273 Fix GLYPH_DEBUG usage assuming that it may be undefined,
2274 adjust comments accordingly.
2275 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
2276 undefined, adjust comments accordingly.
2277 * image.c: Likewise.
2278 * scroll.c: Likewise.
2279 * w32fns.c: Likewise.
2280 * w32term.c: Likewise.
2281 * xdisp.c: Likewise.
2282 * xfaces.c: Likewise.
2283 * xfns.c: Likewise.
2284 * xterm.c: Likewise.
2285
a54e2c05
DA
22862012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2287
2288 Generalize run-time debugging checks.
2289 * dispextern.h (XASSERTS): Remove.
2290 * fontset.c (xassert): Remove.
2291 Convert from xassert to eassert.
2292 * alloc.c: Convert from xassert to eassert.
2293 * bidi.c: Likewise.
2294 * dispnew.c: Likewise.
2295 * fns.c: Likewise.
2296 * fringe.c: Likewise.
2297 * ftfont.c: Likewise.
2298 * gtkutil.c: Likewise.
2299 * image.c: Likewise.
2300 * keyboard.c: Likewise.
2301 * menu.c: Likewise.
2302 * process.c: Likewise.
2303 * scroll.c: Likewise.
2304 * sound.c: Likewise.
2305 * term.c: Likewise.
2306 * w32console.c: Likewise.
2307 * w32fns.c: Likewise.
2308 * w32term.c: Likewise.
2309 * window.c: Likewise.
2310 * xdisp.c: Likewise.
2311 * xfaces.c: Likewise.
2312 * xfns.c: Likewise.
2313 * xselect.c: Likewise.
2314 * xterm.c: Likewise.
2315
1ec4b7b2
SM
23162012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
2317
2318 * fns.c (maybe_resize_hash_table): Output message when growing the
2319 purify-hashtable.
2320
2014308a
DA
23212012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2322
2323 * alloc.c (allocate_string_data): Remove dead code.
2324 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
2325 avoid GCC warning about unused macro.
2326
246155eb
DA
23272012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2328
2329 * alloc.c (allocate_string): Omit intervals initialization.
2330 * alloc.c (make_uninit_multibyte_string): Initialize intervals
2331 as in make_pure_string and make_pure_c_string.
2332
43184b7b
DA
23332012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2334
d209e2fb 2335 * alloc.c (allocate_string): Fix last change.
43184b7b 2336
3fe6dd74
DA
23372012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2338
d209e2fb 2339 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
2340 to memset, add explicit initialization where appropriate.
2341
1ba6038a
GM
23422012-06-27 Glenn Morris <rgm@gnu.org>
2343
2344 * lisp.mk (lisp): Remove paths.elc.
2345
c89926a5
CY
23462012-06-27 Chong Yidong <cyd@gnu.org>
2347
2348 * doc.c (Fsubstitute_command_keys): Fix punctuation.
2349
ed6b3510
JW
23502012-06-26 John Wiegley <johnw@newartisans.com>
2351
1ec4b7b2 2352 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
2353 on Mac OS X Lion: __mod_init_func and __mod_term_func.
2354
ed6b3510
JW
2355 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
2356 when building with Clang.
2357
8edd4a2b
SM
23582012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
2359
2360 * eval.c (Fapply): Allow calling it with a single argument.
2361
f6f62d1b
EZ
23622012-06-26 Eli Zaretskii <eliz@gnu.org>
2363
2364 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
2365 _stricmp and _strnicmp.
2366 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
2367
62efea5e
DA
23682012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2369
2370 * alloc.c (allocate_window): Zero out non-Lisp part of newly
2371 allocated window.
2372 (allocate_process): Likewise for new process.
8edd4a2b 2373 (allocate_terminal): Change to use offsetof.
62efea5e
DA
2374 (allocate_frame): Likewise.
2375 * frame.c (make_frame): Omit redundant initialization.
2376 * window.c (make_parent_window): Use memset.
2377 (make_window): Omit redundant initialization.
2378 * process.c (make_process): Omit redundant initialization.
2379 * terminal.c (create_terminal): Likewise.
2380
42997f4d
DA
23812012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2382
2383 * term.c (delete_tty): Remove redundant call to memset.
2384
1130ecfc
DA
23852012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2386
2387 * alloc.c: Remove build_string.
2388 * lisp.h: Define build_string as static inline. This provides
2389 a better opportunity to optimize away calls to strlen when the
2390 function is called with compile-time constant argument.
2391 * image.c (imagemagick_error): Convert to build_string.
2392 * w32proc.c (sys_spawnve): Likewise.
2393 * xterm.c (x_term_init): Likewise.
2394
cf38a720
PE
23952012-06-26 Paul Eggert <eggert@cs.ucla.edu>
2396
99027bdd
PE
2397 Use sprintf return value instead of invoking strlen on result.
2398 In the old days this wasn't portable, since some sprintf
2399 implementations returned char *. But they died out years ago and
2400 Emacs already assumes sprintf returns int.
2401 Similarly for float_to_string.
2402 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
2403 * ccl.c (ccl_driver):
2404 * character.c (string_escape_byte8):
2405 * data.c (Fnumber_to_string):
2406 * doprnt.c (doprnt):
2407 * print.c (print_object):
2408 * xdisp.c (message_dolog):
2409 * xfns.c (syms_of_xfns):
2410 Use sprintf or float_to_string result to avoid need to call strlen.
2411 * data.c (Fnumber_to_string):
2412 Use make_unibyte_string, since the string must be ASCII.
2413 * lisp.h, print.c (float_to_string): Now returns int length.
2414 * term.c (produce_glyphless_glyph):
2415 Use sprintf result rather than recomputing it.
2416
cf38a720
PE
2417 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
2418 * Makefile.in (ALL_CFLAGS):
2419 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
2420 * gmalloc.c, regex.c: Include <config.h> unconditionally.
2421
3511c784
DA
24222012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2423
0a08eb21 2424 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
2425 strcasecmp if available.
2426 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
2427
fb7da12e
AS
24282012-06-25 Andreas Schwab <schwab@linux-m68k.org>
2429
2430 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
2431 Avoid comma operator.
2432 * menu.c (push_submenu_start, push_submenu_end)
2433 (push_left_right_boundary, push_menu_pane): Likewise.
2434 * msdos.c (dos_rawgetc): Likewise.
2435
afa2ffd8
DA
24362012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2437
2438 * xfns.c (xic_create_fontsetname): Remove redundant calls
2439 to memset.
2440
b3b4476b
PE
24412012-06-25 Paul Eggert <eggert@cs.ucla.edu>
2442
4495ff38
PE
2443 * gtkutil.c (get_utf8_string): Remove redundant assignment.
2444 sprintf already null-terminates its output.
2445
b3b4476b
PE
2446 * xfns.c (x_window): Remove redundant cast.
2447
b00876c9
DA
24482012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2449
2450 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
2451 `const char *' to `char *' to avoid compiler warning.
2452
d188e26b
PE
24532012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2454
885d1d74
PE
2455 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
2456 instead of truncating it to 63 (admittedly a generous limit).
2457
d188e26b
PE
2458 * process.c: Fix spelling and caps in comments.
2459
e2f560b1
DN
24602012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
2461
e86db54b 2462 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
2463 * sysdep.c (setpgrp): Remove definition, not used in this file.
2464
7583a3a1
JB
24652012-06-24 Juanma Barranquero <lekktu@gmail.com>
2466
2467 * makefile.w32-in: Update dependencies.
2468
696056c2
EZ
24692012-06-24 Eli Zaretskii <eliz@gnu.org>
2470
2471 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
2472 (SYSTIME_H): Add nt/inc/sys/time.h.
2473
2474 * systime.h [WINDOWSNT]: Include sys/time.h.
2475
2476 * s/ms-w32.h (struct timespec): Definition moved from
2477 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
2478
845ca893
PE
24792012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2480
2481 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
2482 * buffer.h (buffer_slot_type_mismatch):
2483 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2484 * eval.c (unwind_to_catch):
2485 * image.c (my_png_error, my_error_exit):
2486 * keyboard.c (quit_throw_to_read_char, user_error)
2487 (Fexit_recursive_edit, Fabort_recursive_edit):
2488 * lisp.h (die, args_out_of_range, args_out_of_range_3)
2489 (wrong_type_argument, buffer_overflow, __executable_start)
2490 (memory_full, buffer_memory_full, string_overflow, Fthrow)
2491 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
2492 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
2493 (fatal):
2494 (child_setup) [!DOS_NT]:
2495 * lread.c (end_of_file_error, invalid_syntax):
2496 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2497 * puresize.h (pure_write_error):
2498 * search.c (matcher_overflow):
2499 * sound.c (sound_perror, alsa_sound_perror):
2500 * sysdep.c, syssignal.h (croak):
2501 * term.c (maybe_fatal, vfatal):
2502 * textprop.c (text_read_only):
2503 * undo.c (user_error):
2504 * unexmacosx.c (unexec_error):
2505 * xterm.c (x_ins_del_lines, x_delete_glyphs):
2506 Use _Noreturn rather than NO_RETURN.
2507 No need for separate decl merely because of _Noreturn.
2508 * sound.c (sound_warning, parse_sound):
2509 Remove unnecessary forward decls.
2510
f1dd8073
PE
25112012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2512
2513 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
2514 * lisp.h (WAIT_READING_MAX): New macro.
2515 * dispnew.c (Fsleep_for, sit_for):
2516 * keyboard.c (kbd_buffer_get_event):
2517 * process.c (Faccept_process_output):
2518 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
2519 This improves on the previous patch, which introduced a bug
2520 when time_t is unsigned and as wide as intmax_t.
2521 See <http://bugs.gnu.org/9000#51>.
2522
b82c1755
EZ
25232012-06-23 Eli Zaretskii <eliz@gnu.org>
2524
2525 * dispnew.c (sit_for, Fsleep_for):
2526 * keyboard.c (kbd_buffer_get_event):
2527 * process.c (Faccept_process_output): Avoid compiler warnings when
2528 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
2529
ca300656
JB
25302012-06-23 Juanma Barranquero <lekktu@gmail.com>
2531
049ec95b
JB
2532 * makefile.w32-in: Update dependencies.
2533
ca300656
JB
2534 * w32.c (ltime): Add return type and declare static.
2535 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
2536
db7b8d06
PE
25372012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2538
2539 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
2540 Privately reported by Herbert J. Skuhra.
2541 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
2542 All uses changed.
2543 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
2544 not make_lisp_timeval, when the argument is of type EMACS_TIME.
2545
0bd8297f
EZ
25462012-06-23 Eli Zaretskii <eliz@gnu.org>
2547
96512555
EZ
2548 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
2549 last argument of make_unibyte_string.
2550
0bd8297f
EZ
2551 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
2552 language ID in the event parameters.
2553
2554 * w32term.c (w32_read_socket): Put the new keyboard codepage into
2555 event.code, not the obscure "character set ID".
2556
63def6b6
CY
25572012-06-23 Chong Yidong <cyd@gnu.org>
2558
2559 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
2560
e8a02204
EZ
25612012-06-23 Eli Zaretskii <eliz@gnu.org>
2562
388cdec0
EZ
2563 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
2564 * w32.c (fdutimens): New function.
2565
2566 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
2567
2568 * s/ms-w32.h (pselect): Redirect to sys_select.
2569
2570 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
2571
e8a02204
EZ
2572 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
2573 in the logic of incrementing and decrementing the value of
2574 use_relocatable_buffers.
2575
d054f3fb
PE
25762012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2577
2578 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
2579 Privately reported by Herbert J. Skuhra.
2580 [__FreeBSD__]: Remove "*/" typo after "#include".
2581 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
2582 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
2583 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
2584 Don't assume EMACS_TIME and struct timeval are the same type.
2585
d35af63c
PE
25862012-06-22 Paul Eggert <eggert@cs.ucla.edu>
2587
2588 Support higher-resolution time stamps (Bug#9000).
2589 The time stamps are only nanosecond-resolution at the C level,
2590 since that's the best that any real-world system supports now.
2591 But they are picosecond-resolution at the Lisp level, as that's
2592 easy, and leaves room for future OS improvements.
2593
2594 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
2595 (LIBES): Use it.
2596
2597 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
2598 Don't get current time unless it's needed.
2599
2600 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
2601 now provides it if it's absent.
2602 (start_atimer): Port to higher-res time stamps.
2603 Check for time stamp overflow. Don't get current time more
2604 often than is needed.
2605
2606 * buffer.h (struct buffer): Buffer modtime now has high resolution.
2607 Include systime.h, not time.h.
2608 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
2609
2610 * dired.c: Include stat-time.h.
2611 (Ffile-attributes): File times now have higher resolution.
2612
2613 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
2614 (struct image): Timestamp now has higher resolution.
2615
2616 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
2617 has at least microseconds now. All uses removed.
2618 (update_frame, update_single_window, update_window, update_frame_1)
2619 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
2620
2621 * editfns.c (time_overflow): Now extern.
2622 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
2623 (float-time, Fformat_time_string, Fcurrent_time_string)
2624 (Fcurrent_time_zone): Accept and generate higher-resolution
2625 time stamps.
2626 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
2627 (decode_time_components, lisp_seconds_argument): New functions.
2628 (make_time): Now static.
2629 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
2630 Report an error if the time is invalid, rather than having the caller
2631 do that.
2632
2633 * fileio.c: Include <stat-time.h>
2634 (Fcopy_file): Copy higher-resolution time stamps.
2635 Prefer to set the time stamp via a file descriptor if that works.
2636 (Fset_file_times, Finsert_file_contents, Fwrite_region)
2637 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
2638 (Fvisited_file_modtime, Fset_visited_file_modtime):
2639 Support higher-resolution time stamps.
2640
2641 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
2642
2643 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
2644
2645 * image.c (prepare_image_for_display, clear_image_cache)
2646 (lookup_image): Port to higer-resolution time stamps.
2647
2648 * keyboard.c (start_polling, bind_polling_period):
2649 Check for time stamp overflow.
2650 (read_char, kbd_buffer_get_event, timer_start_idle)
2651 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
2652 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
2653 Port to higher-resolution time stamps. Do not assume time_t is signed.
2654 (decode_timer): New function. Timers are now vectors of length 9,
2655 not 8, to accommodate the picosecond component.
2656 (timer_check_2): Use it.
2657
2658 * nsterm.m (select_timeout, timeval_subtract): Remove.
2659 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
2660 as they're a bit more accurate and handle overflow better.
2661 (ns_select): Change prototype to be compatible with pselect.
2662 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
2663 * nsterm.h (ns_select): Adjust prototype.
2664
2665 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
2666 us-resolution time stamps.
2667 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
2668
2669 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
2670
2671 * lisp.h (time_overflow): New decl.
2672 (wait_reading_process_output): First arg is now intmax_t, not int,
2673 to accommodate larger waits.
2674
2675 * process.h (struct Lisp_Process.read_output_delay):
2676 Now counts nanoseconds, not microseconds.
2677 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
2678 EMACS_HAS_USECS.
2679 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
2680 (wait_reading_process_output):
2681 Port to ns-resolution time stamps.
2682 (Faccept_process_output, wait_reading_process_output):
2683 Check for time stamp overflow. Do not assume time_t is signed.
2684 (select_wrapper): Remove; we now use pselect.
2685 (Fprocess_attributes): Now generates ns-resolution time stamps.
2686
2687 * sysdep.c: Include utimens.h. Don't include utime.h
2688 or worry about struct utimbuf; gnulib does that for us now.
2689 (gettimeofday): Remove; gnulib provides a substitute.
2690 (make_timeval): New function.
2691 (set_file_times): Now sets ns-resolution time stamps.
2692 New arg FD; all uses changed.
2693 (time_from_jiffies, ltime_from_jiffies, get_up_time)
2694 (system_process_attributes):
2695 Now returns ns-resolution time stamp. All uses changed.
2696 Check for time stamp overflow.
2697
2698 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
2699 provides a substitute now.
2700
2701 * systime.h: Include timespec.h rather than sys/time.h and time.h,
2702 since it guarantees struct timespec.
2703 (EMACS_TIME): Now struct timespec, so that we can support
2704 ns-resolution time stamps.
2705 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
2706 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
2707 (EMACS_USECS): Remove.
2708 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
2709 so multiply the arg by 1000 before storing it.
2710 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
2711 New macros.
2712 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
2713 Port to ns-resolution time stamps.
2714 (EMACS_TIME_NEG_P): Remove; replaced by....
2715 (EMACS_TIME_SIGN): New macro.
2716 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
2717 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
2718 (set_file_times, make_time, lisp_time_argument): Adjust signature.
2719 (make_timeval, make_lisp_time, decode_time_components): New decls.
2720 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
2721 that it mishandled time_t overflow. You can't compare by subtracting!
2722 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
2723 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
2724
2725 * term.c: Include <sys/time.h>.
2726 (timeval_to_Time): New function, for proper overflow wraparound.
2727 (term_mouse_position, term_mouse_click): Use it.
2728
2729 * undo.c (record_first_change): Support higher-resolution time stamps
2730 in the undo buffer.
2731 (Fprimitive_undo): Use them when restoring time stamps.
2732
2733 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
2734 (w32_get_internal_run_time):
2735 Port to higher-resolution Emacs time stamps.
2736 (ltime): Now accepts single 64-bit integer, as that's more convenient
2737 for callers.
2738
2739 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
2740
2741 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
2742 for compatibility with pselect. Support ns-resolution time stamps.
2743
2744 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
2745
2746 * xselect.c (wait_for_property_change, x_get_foreign_selection):
2747 Check for time stamp overflow, and support ns-resolution time stamps.
2748
2749 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
2750 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
2751 (timeval_subtract): Remove; no longer needed.
2752 (XTflash, XTring_bell, x_wait_for_event):
2753 Port to ns-resolution time stamps. Don't assume time_t is signed.
2754
b6a92dfe
CY
27552012-06-22 Chong Yidong <cyd@gnu.org>
2756
2757 * xdisp.c (x_consider_frame_title): Revert last change.
2758
d251c37c
EZ
27592012-06-22 Eli Zaretskii <eliz@gnu.org>
2760
2761 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
2762 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
2763 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
2764 staticidx goes up to 1597 out of 1600 = 0x640.)
2765
f10deafb
PE
27662012-06-20 Paul Eggert <eggert@cs.ucla.edu>
2767
2768 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
2769 Otherwise, the umask might be mistakenly 0 while handling input signals.
2770
ec6de1e2
SM
27712012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
2772
2773 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
2774
28be1ada
DA
27752012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
2776
2777 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
2778 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
2779 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
2780 access to `contents' member of Lisp_Vector objects with AREF and ASET
2781 where appropriate.
2782
c6bf3022
CY
27832012-06-19 Chong Yidong <cyd@gnu.org>
2784
2785 * frame.c (delete_frame): When selecting a frame on a different
2786 text terminal, do not alter the terminal's top-frame.
2787
2788 * xdisp.c (format_mode_line_unwind_data): Record the target
2789 frame's selected window and its terminal's top-frame.
2790 (unwind_format_mode_line): Restore them.
2791 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
2792 Callers changed.
2793 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
2794 since tty frames can be explicitly named.
2795 (prepare_menu_bars): Likewise.
2796
2797 * term.c (Ftty_top_frame): New function.
2798
defd4196
PE
27992012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2800
2801 Port byte-code-meter to modern targets.
2802 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
2803 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 2804 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
2805 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
2806 (METER_1, METER_2): Simplify.
2807
1053a871
SM
28082012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
2809
2810 * data.c (Fdefalias): Return `symbol' (bug#11686).
2811
b7e8d081
MR
28122012-06-18 Martin Rudalics <rudalics@gmx.at>
2813
2814 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
2815 gets killed during executing of this function (Bug#11665).
2816 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
2817 (Vkill_buffer_query_functions): In doc-string say that functions
2818 run by this hook should not change the current buffer.
2819
7ea2b339
PE
28202012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2821
2822 Fix recently-introduced process.c problems found by static checking.
2823 * process.c (write_queue_push, write_queue_pop, send_process):
2824 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
2825 (write_queue_pop): Fix pointer signedness problem.
2826 (send_process): Remove unused local.
2827
96a313a1
CY
28282012-06-17 Chong Yidong <cyd@gnu.org>
2829
2830 * xdisp.c (redisplay_internal): No need to redisplay terminal
2831 frames that are not on top.
2832
20ca2e94
TN
28332012-06-17 Troels Nielsen <bn.troels@gmail.com>
2834
2835 * process.c (make_process): Initialize write_queue.
2836 (write_queue_push, write_queue_pop): New functions.
2837 (send_process): Use them to maintain correct ordering of process
2838 writes (Bug#10815).
2839
9a900ca9
PE
28402012-06-17 Paul Eggert <eggert@cs.ucla.edu>
2841
310fbfa8
PE
2842 * lisp.h (eassert): Assume C89 or later.
2843 This removes the need for CHECK.
2844 (CHECK): Remove. Its comments about always evaluating its
2845 argument were confusing, as 'eassert' typically does not evaluate
2846 its argument.
2847
27bb1ca4
PE
2848 * coding.c (produce_chars): Use ptrdiff_t, not int.
2849
9a900ca9
PE
2850 * xterm.c (x_draw_underwave): Check for integer overflow.
2851 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
2852
41b7f8bc 28532012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
2854
2855 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
2856 referenced (Bug#11583).
2857
9b0e3eba
AA
28582012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
2859
2860 Implement wave-style variant of underlining.
2861 * dispextern.h (face_underline_type): New enum.
2862 (face): Add field for underline type.
2863 * nsterm.m (ns_draw_underwave): New function.
2864 (ns_draw_text_decoration): Use it.
2865 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
2866 New functions.
2867 (x_draw_glyph_string): Use them.
2868 * xfaces.c (Qline, Qwave): New Lisp objects.
2869 (check_lface_attrs, merge_face_ref)
1053a871
SM
2870 (Finternal_set_lisp_face_attribute, realize_x_face):
2871 Handle wave-style underline face attributes.
9b0e3eba
AA
2872 * xterm.c (x_draw_underwave): New function.
2873 (x_draw_glyph_string): Use it.
2874
0fb52f11
JB
28752012-06-16 Juanma Barranquero <lekktu@gmail.com>
2876
2877 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
2878 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
2879 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
2880 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
2881 ($(BLD)/w32select.$(O)): Update dependencies.
2882
e5560ff7
AS
28832012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2884
2885 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
2886 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
2887 * character.c (_fetch_multibyte_char_p): Remove.
2888 * alloc.c: Include "character.h" before "buffer.h".
2889 * bidi.c: Likewise.
2890 * buffer.c: Likewise.
2891 * bytecode.c: Likewise.
2892 * callint.c: Likewise.
2893 * callproc.c: Likewise.
2894 * casefiddle.c: Likewise.
2895 * casetab.c: Likewise.
2896 * category.c: Likewise.
2897 * cmds.c: Likewise.
2898 * coding.c: Likewise.
2899 * composite.c: Likewise.
2900 * dired.c: Likewise.
2901 * dispnew.c: Likewise.
2902 * doc.c: Likewise.
2903 * dosfns.c: Likewise.
2904 * editfns.c: Likewise.
2905 * emacs.c: Likewise.
2906 * fileio.c: Likewise.
2907 * filelock.c: Likewise.
2908 * font.c: Likewise.
2909 * fontset.c: Likewise.
2910 * fringe.c: Likewise.
2911 * indent.c: Likewise.
2912 * insdel.c: Likewise.
2913 * intervals.c: Likewise.
2914 * keyboard.c: Likewise.
2915 * keymap.c: Likewise.
2916 * lread.c: Likewise.
2917 * macros.c: Likewise.
2918 * marker.c: Likewise.
2919 * minibuf.c: Likewise.
2920 * nsfns.m: Likewise.
2921 * nsmenu.m: Likewise.
2922 * print.c: Likewise.
2923 * process.c: Likewise.
2924 * regex.c: Likewise.
2925 * region-cache.c: Likewise.
2926 * search.c: Likewise.
2927 * syntax.c: Likewise.
2928 * term.c: Likewise.
2929 * textprop.c: Likewise.
2930 * undo.c: Likewise.
2931 * unexsol.c: Likewise.
2932 * w16select.c: Likewise.
2933 * w32fns.c: Likewise.
2934 * w32menu.c: Likewise.
2935 * window.c: Likewise.
2936 * xdisp.c: Likewise.
2937 * xfns.c: Likewise.
2938 * xmenu.c: Likewise.
2939 * xml.c: Likewise.
2940 * xselect.c: Likewise.
2941
2f07e6af
EZ
29422012-06-16 Eli Zaretskii <eliz@gnu.org>
2943
1053a871
SM
2944 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
2945 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 2946 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
2947 row.
2948 (handle_face_prop): Use chunk-relative overlay string index when
2949 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
2950 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
2951 the rightmost. (Bug#11720)
2f07e6af 2952
29b83cec
AS
29532012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2954
2955 * category.h (CHAR_HAS_CATEGORY): Define as inline.
2956 (CATEGORY_MEMBER): Enforce 1/0 value.
2957 * category.c (_temp_category_set): Remove.
2958
4c5501e9
EZ
29592012-06-16 Eli Zaretskii <eliz@gnu.org>
2960
2961 * window.c (Fdelete_other_windows_internal)
2962 (Fdelete_window_internal): Don't access frame's mouse highlight
2963 info of the initial frame. (Bug#11677)
2964
2b570124
PE
29652012-06-14 Paul Eggert <eggert@cs.ucla.edu>
2966
e93864f9
PE
2967 * .gdbinit (xgetint): Fix recently-introduced paren typo.
2968 Assume USE_2_TAGS_FOR_INTS.
2969 (xreload): Adjust $tagmask width to match recent lisp.h change.
2970
2b570124
PE
2971 Simplify lisp.h in minor ways that should not affect code.
2972 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
2973 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
2974 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
2975 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
2976 (INTTYPEBITS): New macro, for clarity.
2977 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
2978 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
2979 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
2980 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
2981 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
2982
81755f69
JB
29832012-06-13 Juanma Barranquero <lekktu@gmail.com>
2984
2985 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
2986
16192a57
GM
29872012-06-13 Glenn Morris <rgm@gnu.org>
2988
2989 * s/bsd-common.h (BSD4_3):
2990 * s/usg5-4-common.h (USG5_4): No longer define; unused.
2991
646b5f55
AS
29922012-06-13 Andreas Schwab <schwab@linux-m68k.org>
2993
2994 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
2995 instead of union.
2996 (XLI, XIL): Define.
1053a871
SM
2997 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
2998 Use them.
2999 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 3000 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 3001 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
3002 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
3003 * frame.c (delete_frame): Remove outdated comment.
3004 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
3005 USE_LISP_UNION_TYPE.
3006 (Fw32_unregister_hot_key): Likewise.
3007 (Fw32_toggle_lock_key): Likewise.
3008 * w32menu.c (add_menu_item): Likewise.
3009 (w32_menu_display_help): Use XIL instead of checking
3010 USE_LISP_UNION_TYPE.
3011 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
3012 (init_heap): Likewise.
3013 * w32term.c (w32_read_socket): Update comment.
3014
1d3823c9
GM
30152012-06-13 Glenn Morris <rgm@gnu.org>
3016
c62ff706
GM
3017 * s/usg5-4-common.h, src/s/unixware.h:
3018 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
3019
1d3823c9
GM
3020 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
3021
bfe3e0a2
PE
30222012-06-13 Paul Eggert <eggert@cs.ucla.edu>
3023
3024 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
3025 * alloc.c (make_number) [!defined make_number]:
3026 Remove, as lisp.h always defines this now.
3027 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
3028 (roundup_size): Verify that it is a power of 2.
3029 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
3030 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
3031 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
3032 -DUSE_LSB_TAG=0, to override the automatically-selected default.
3033 USE_LSB_TAG now is always defined to be either 0 or 1.
3034 All uses changed.
3035 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
3036 code works fine either way, and efficiency is not a concern here,
3037 as the union type is for debugging, not for production.
3038 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
3039 Use an inline function on all platforms when using the union type,
3040 since this is simpler and 'static inline' can be used portably
3041 within Emacs now.
3042 (LISP_INITIALLY_ZERO): New macro.
3043 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
3044 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
3045
45fa9c0f
GM
30462012-06-12 Glenn Morris <rgm@gnu.org>
3047
b4492cba
GM
3048 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
3049
3050 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 3051
45fa9c0f
GM
3052 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
3053 Move BROKEN_SIGIO to configure.
3054
3055 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
3056 Move NO_TERMIO to configure.
3057
0e25d334
CY
30582012-06-12 Chong Yidong <cyd@gnu.org>
3059
3060 * image.c (imagemagick_load_image): Use MagickFlattenImage if
3061 MagickMergeImageLayers is undefined. Use pixel pusher loop if
3062 MagickExportImagePixels is undefined.
3063
43682bb6
PE
30642012-06-12 Paul Eggert <eggert@cs.ucla.edu>
3065
3066 * image.c (imagemagick_load_image): Remove unused label.
3067
a9be7d2b
GM
30682012-06-11 Glenn Morris <rgm@gnu.org>
3069
3070 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
3071 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
3072 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
3073 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
3074
3017f87f
SM
30752012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
3076
3077 * alloc.c (make_byte_code): New function.
3078 (Fmake_byte_code): Use it. Don't purify here.
3079 * lread.c (read1): Use it as well to avoid extra allocation.
3080
1b9b4cf4
CY
30812012-06-11 Chong Yidong <cyd@gnu.org>
3082
3083 * image.c (imagemagick_load_image): Implement transparency.
3084
95988fcf
AS
30852012-06-10 Andreas Schwab <schwab@linux-m68k.org>
3086
3087 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
3088 account for preceding backslashes. (Bug#11663)
3089
cd4eb164
CY
30902012-06-09 Chong Yidong <cyd@gnu.org>
3091
3092 * term.c: Support italics in capable terminals (Bug#9652).
3093 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
3094 (turn_on_face): Output using TS_enter_italic_mode if available.
3095 Don't handle unused blinking and alt-charset cases.
3096 (turn_off_face): Handle italic case; discard unused tty_blinking_p
3097 and tty_alt_charset_p cases.
3098 (tty_capable_p, init_tty): Support italics.
3099
3100 * termchar.h (struct tty_display_info): Add field for italics.
3101 Remove unused blink field.
3102
3103 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
3104 Handle slant.
3105
3106 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
3107 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
3108 tty_alt_charset_p. Add tty_italic_p.
3109
ff88beb8
MA
31102012-06-09 Michael Albinus <michael.albinus@gmx.de>
3111
3112 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
3113 dbus_type_is_basic if available.
3114 (xd_extract_signed, xd_extract_unsigned): Rename from
3115 extract_signed and extract_unsigned, respectively. Adapt callers.
3116
44286096
CY
31172012-06-09 Chong Yidong <cyd@gnu.org>
3118
1682701f
CY
3119 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
3120
44286096
CY
3121 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
3122 case (Bug#9752).
3123
d86feb17
PE
31242012-06-08 Paul Eggert <eggert@cs.ucla.edu>
3125
3126 * xdisp.c (vmessage): Treat frame message as multibyte.
3127 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
3128 would generate the diagnostic "Making \302\247 buffer-local while
3129 let-bound!".
3130
d5c20fe8
EZ
31312012-06-08 Eli Zaretskii <eliz@gnu.org>
3132
3133 * dispnew.c (showing_window_margins_p): Undo last change, which
3134 was done due to an inadvertent commit.
3135 (adjust_frame_glyphs_for_frame_redisplay): Do call
3136 showing_window_margins_p.
3137
513749ee
SM
31382012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3139
3140 * eval.c (Fmake_var_non_special): New primitive.
3141 (syms_of_eval): Defsubr it.
3142 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
3143
d4a8f5c1
JB
31442012-06-08 Juanma Barranquero <lekktu@gmail.com>
3145
3146 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
3147 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
3148
8bbbc977
EZ
31492012-06-08 Eli Zaretskii <eliz@gnu.org>
3150
3151 * alloc.c (allocate_vectorlike): Fix last change.
3152
f3372c87
DA
31532012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
3154
3155 Block-based vector allocation of small vectors.
3156 * lisp.h (struct vectorlike_header): New field `nbytes',
3157 adjust comment accordingly.
3158 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
3159 to denote vector blocks. Adjust users (live_vector_p,
3160 mark_maybe_pointer, valid_lisp_object_p) accordingly.
3161 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
3162 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
3163 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
3164 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
3165 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
3166 (roundup_size): New constant.
3167 (struct vector_block): New data type.
3168 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 3169 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
3170 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
3171 (sweep_vectors): New functions.
3172 (allocate_vectorlike): Return `zero_vector' as the only vector of
3173 0 items. Allocate new vector from block if vector size is less than
3174 or equal to VBLOCK_BYTES_MAX.
3175 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
3176 (init_alloc_once): Add call to init_vectors.
3177
4f18a4ed
SM
31782012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3179
3180 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
3181
86f158bc
PE
31822012-06-07 Paul Eggert <eggert@cs.ucla.edu>
3183
3184 * doprnt.c (doprnt): Truncate multibyte char correctly.
3185 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
3186 would mishandle a string argument "Xc" if X was a multibyte
3187 character of length 2: it would truncate after X's first byte
3188 rather than including all of X.
3189
c5cfcbe0
CY
31902012-06-06 Chong Yidong <cyd@gnu.org>
3191
3192 * buffer.c (word_wrap): Doc fix.
3193
c05cf390
PE
31942012-06-04 Paul Eggert <eggert@cs.ucla.edu>
3195
3196 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
3197
0c3461de
GM
31982012-06-03 Glenn Morris <rgm@gnu.org>
3199
3200 * xdisp.c (tool-bar-style): Doc fix.
3201
c71232db
UM
32022012-06-03 Ulrich Müller <ulm@gentoo.org>
3203
3204 * Makefile.in (PAXCTL): Define.
3205 (temacs$(EXEEXT)): Disable memory randomization for the temacs
3206 binary via PaX flags if the paxctl utility is available.
3207 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
3208 Restore PaX flags to their default. (Bug#11398)
3209
383f7350
CY
32102012-06-03 Chong Yidong <cyd@gnu.org>
3211
3212 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
3213 buffer (Bug#11226).
3214
5f2c76c6
CY
32152012-06-03 Chong Yidong <cyd@gnu.org>
3216
3217 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
3218 (note_mode_line_or_margin_highlight): If there is no help echo,
3219 use mode-line-default-help-echo. Handle the case where the mouse
3220 position is past the end of the mode line string.
3221
3222 * buffer.c (buffer_local_value_1): New function, split from
3223 Fbuffer_local_value; can return Qunbound.
3224 (Fbuffer_local_value): Use it.
3225 (Vmode_line_format): Docstring tweaks.
3226
773d47f6
PE
32272012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3228
3229 * sysdep.c (system_process_attributes): Improve comment.
3230
f2d6a3df
SM
32312012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
3232
3233 * keyboard.c: Export real-this-command to Elisp.
3234 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
3235 and DEFVAR it. Update all users.
3236
63810350
PE
32372012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3238
7bd5c1f4
PE
3239 * minibuf.c (Fassoc_string): Remove duplicate declaration.
3240
63810350
PE
3241 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
3242 Convert pctcpu and pctmem to Lisp float properly.
3243 Let the compiler fold better, as 100.0/0x8000 is exact.
3244
a2821611
AS
32452012-06-02 Andreas Schwab <schwab@linux-m68k.org>
3246
3247 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
3248 cons_block.
3249
5fceba1d
PE
32502012-06-01 Paul Eggert <eggert@cs.ucla.edu>
3251
3252 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
3253
c98ff5dd
DA
32542012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
3255
3256 For a 'struct window', replace some Lisp_Object fields to
3257 bitfields where appropriate, remove unused fields.
3258 * window.h (struct window): Remove unused 'last_mark_x' and
3259 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
3260 change it's type from Lisp_Object to bitfield.
3261 Change type of 'force_start', 'optional_new_start',
3262 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
3263 fields from Lisp_Object to bitfield. Adjust users accordingly.
3264
ca34e0be
PE
32652012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3266
3267 Pacify gcc -Wdouble-precision when using Xaw.
3268 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
3269 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
3270 Use 'float' consistently, rather than 'float' in most places
3271 and 'double' in a couple of places.
3272
efc00ab1 32732012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
3274
3275 * xdisp.c (handle_stop): Detect whether we have overlay strings
3276 loaded by testing it->current.overlay_string_index to be
3277 non-negative, instead of checking whether n_overlay_strings is
3278 positive. (Bug#11587)
3279
efc00ab1 32802012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
3281
3282 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
3283
3284 * doc.c (Fsubstitute_command_keys): Doc fix.
3285
efc00ab1 32862012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
3287
3288 * search.c (search_buffer): Remove calls to
3289 r_alloc_inhibit_buffer_relocation, as it is now called by
3290 maybe_unify_char, which was the cause of relocation of buffer text
3291 in bug#11519.
3292
efc00ab1 32932012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
3294
3295 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
3296 for the duration of call to load_charset, to avoid problems with
3297 callers of maybe_unify_char that access buffer text through C
3298 pointers.
3299
3300 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
3301 decrement the inhibition flag, instead of just setting or
3302 resetting it.
3303
ba93a187
PE
33042012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3305
3306 Remove obsolete '#define static' cruft.
3307 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
3308 This #undef was "temporary" in 2000; it is no longer needed
3309 now that '#define static' has gone away.
3310 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
3311 (gray_bitmap_bits): Remove; no longer needed.
3312 All uses replaced with definiens.
3313 * xterm.c: Include "bitmaps/gray.xbm".
3314
9e4bf381
PE
33152012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3316
3317 Clean up __executable_start, monstartup when --enable-profiling.
3318 The following changes affect the code only when profiling.
3319 * dispnew.c (__executable_start): Rename from safe_bcopy.
3320 Define only on platforms that need it.
3321 * emacs.c: Include <sys/gmon.h> when profiling.
3322 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
3323 (__executable_start): Remove decl, since lisp.h does it now.
3324 (safe_bcopy): Remove decl; no longer has that name.
3325 (main): Coalesce #if into single bit of code, for simplicity.
3326 Cast pointers to uintptr_t, since standard libraries want integers
3327 and not pointers.
3328 * lisp.h (__executable_start): New decl.
3329
32d72c2f
GM
33302012-05-31 Glenn Morris <rgm@gnu.org>
3331
3332 * image.c (Fimagemagick_types): Doc fix.
3333
baac5bc7
JM
33342012-05-30 Jim Meyering <meyering@redhat.com>
3335
3336 * callproc.c (Fcall_process_region): Include directory component
3337 in mkstemp error message (Bug#11586).
3338
72cb32cf
PE
33392012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3340
3341 * alloc.c, lisp.h (make_pure_vector): Now static.
3342
61b108cc
SM
33432012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
3344
3345 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
3346 Move to byte-run.el.
3347 (Fautoload): Do the hash-doc more carefully.
3348 * data.c (Fdefalias): Purify definition, except for keymaps.
3349 (Qdefun): Move from eval.c.
3350 * lisp.h (Qdefun): Remove.
3351 * lread.c (read1): Tiny simplification.
3352
471fe23d
TN
33532012-05-29 Troels Nielsen <bn.troels@gmail.com>
3354
934f3f58 3355 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
3356 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
3357 Bug#9642, but explicitly check that the buffer the overlay would
3358 be moved to is live and rearrange lines to make sure that errors
3359 will not put the overlay in an inconsistent state.
3360 (Fdelete_overlay): Cosmetics.
3361
85d0efd1
EZ
33622012-05-28 Eli Zaretskii <eliz@gnu.org>
3363
3364 * w32term.c (my_bring_window_to_top): New function.
3365 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
3366 could be different from the original one.
3367 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
3368 (Bug#11513)
3369
3370 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
3371 by calling BringWindowToTop.
3372
3373 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
3374 (WM_EMACS_END): Increase by one.
3375
da92a98c
PE
33762012-05-28 Paul Eggert <eggert@cs.ucla.edu>
3377
3378 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
3379 This avoids undefined behavior that might cause the eassert
3380 to not catch an out-of-range value.
3381
74d1f848
JB
33822012-05-28 Juanma Barranquero <lekktu@gmail.com>
3383
3384 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
3385 Update dependencies.
3386
9e1a06fc
EZ
33872012-05-27 Eli Zaretskii <eliz@gnu.org>
3388
3389 * bidi.c (bidi_mirror_char): Fix last change.
3390
f3dd7312
AS
33912012-05-27 Andreas Schwab <schwab@linux-m68k.org>
3392
3393 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
3394 when referring to sectname field in printf format.
3395
81899c91
PE
33962012-05-27 Paul Eggert <eggert@cs.ucla.edu>
3397
57b81a9f
PE
3398 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
3399 Only r_alloc_inhibit_buffer_relocation needed to be added;
3400 the others were already declared.
3401
81899c91
PE
3402 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
3403 before checking whether it's out of range. Put the check inside
3404 eassert. See
3405 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
3406
33017faf 34072012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
3408
3409 * callproc.c (Fcall_process): Restore a line that was accidentally
3410 commented out in the 2011-02-13 change (bug#11547).
3411
33017faf 34122012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
3413
3414 * lisp.h [REL_ALLOC]: Add prototypes for external functions
3415 defined on ralloc.c.
3416
3417 * buffer.c [REL_ALLOC]: Remove prototypes of
3418 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
3419 they are now on lisp.h.
3420
3421 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
3422
3423 * search.c (search_buffer): Use it to inhibit relocation of buffer
3424 text while re_search_2 is doing its job, because re_search_2 is
3425 passed C pointers to buffer text. (Bug#11519)
3426
23415acf
EZ
3427 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
3428 Update value to 24.
3429
44e27368
EZ
3430 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
3431 state after an additional call to move_it_in_display_line_to, keep
3432 the values of it->max_ascent and it->max_descent found for the
3433 entire line.
3434 (pos_visible_p): Revert the comparison against bottom_y to what it
3435 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
3436 (Bug#11464)
3437
c1892f11
PE
34382012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3439
3440 Fix coding-related core dumps with gcc -ftrapv.
3441 The code was computing A - B, where A and B are pointers, and B is
3442 random garbage. This can lead to core dumps on platforms that
3443 have special pointer registers, and it also leads to core dumps on
3444 x86-64 when compiled with gcc -ftrapv. The fix is to compute
3445 A - B only when B is initialized properly.
3446 * coding.c (coding_set_source, coding_set_destination): Return void.
3447 (coding_change_source, coding_change_destinations): New functions,
3448 with the old behaviors of coding_set_source and coding_set_destination.
3449 All callers that need an offset changed to use these new functions.
3450
eb7afdad
GM
34512012-05-26 Glenn Morris <rgm@gnu.org>
3452
3453 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
3454
f12fdf02
EZ
34552012-05-26 Eli Zaretskii <eliz@gnu.org>
3456
53a63be6 3457 Extend mouse support on W32 text-mode console.
61b108cc
SM
3458 * xdisp.c (draw_row_with_mouse_face):
3459 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 3460
eb3f6f01 3461 * w32console.c: Include window.h.
61b108cc
SM
3462 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
3463 New functions.
eb3f6f01
EZ
3464 (initialize_w32_display): Initialize mouse-highlight data.
3465
53a63be6
EZ
3466 * w32inevt.c: Include termchar.h and window.h.
3467 (do_mouse_event): Support mouse-autoselect-window. When the mouse
3468 moves, call note_mouse_highlight. If help_echo changed, call
3469 gen_help_event to produce help-echo message in the echo area.
3470 Call clear_mouse_face if mouse_face_hidden is set in the mouse
3471 highlight info.
3472
4cfd81f6
PE
34732012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3474
3475 * lread.c (read1): Simplify slightly to avoid an overflow warning
3476 with GCC 4.7.0 on x86-64.
3477
4446092a
EZ
34782012-05-26 Eli Zaretskii <eliz@gnu.org>
3479
3480 * bidi.c (bidi_mirror_char): Revert last change: an int is
3481 definitely wide enough here.
3482
42b2a986 34832012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 3484
42b2a986 3485 Fix integer width and related bugs (Bug#9874).
eb106a49 3486 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
3487 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
3488 (string_bytes, check_sblock, allocate_string_data):
3489 (compact_small_strings, Fmake_bool_vector, make_string)
3490 (make_unibyte_string, make_multibyte_string)
3491 (make_string_from_bytes, make_specified_string)
3492 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
3493 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
3494 (mark_vectorlike):
3495 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3496 (allocate_pseudovector):
3497 Use int, not EMACS_INT, where int is wide enough.
3498 (inhibit_garbage_collection, Fgarbage_collect):
3499 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3500 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
3501 int might not be wide enough.
3502 (bidi_cache_search, bidi_cache_find, bidi_init_it)
3503 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
3504 (bidi_at_paragraph_end, bidi_find_paragraph_start)
3505 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3506 (bidi_level_of_next_char, bidi_move_to_visually_next):
3507 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3508 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
3509 (Fkill_buffer, Fset_buffer_major_mode)
3510 (advance_to_char_boundary, Fbuffer_swap_text)
3511 (Fset_buffer_multibyte, overlays_at, overlays_in)
3512 (overlay_touches_p, struct sortvec, record_overlay_string)
3513 (overlay_strings, recenter_overlay_lists)
3514 (adjust_overlays_for_insert, adjust_overlays_for_delete)
3515 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
3516 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
3517 (Foverlay_recenter, last_overlay_modification_hooks_used)
3518 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
3519 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
3520 (validate_region): Omit unnecessary test for b <= e,
3521 since that's guaranteed by the previous test.
d311d28c
PE
3522 (adjust_overlays_for_delete): Avoid pos + length overflow.
3523 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
3524 (report_overlay_modification):
3525 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3526 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
3527 Omit pointer cast, which isn't needed anyway, and doesn't work
3528 after the EMACS_INT -> ptrdiff_t change.
02481186 3529 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
3530 * buffer.h: Adjust decls to match defn changes elsewhere.
3531 (struct buffer_text, struct buffer):
3532 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3533 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
3534 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
3535 not int, to avoid needless 32-bit limit on 64-bit hosts.
3536 (exec_byte_code): Use tighter memory-full test, one that checks
3537 for alloca overflow. Don't compute the address of the object just
3538 before an array, as that's not portable. Use EMACS_INT, not
3539 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
3540 * callint.c (Fcall_interactively):
3541 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3542 * callproc.c (call_process_kill, Fcall_process):
3543 Don't assume pid_t fits into an Emacs fixnum.
3544 (call_process_cleanup, Fcall_process, child_setup):
3545 Don't assume pid_t fits into int.
3546 (call_process_cleanup, Fcall_process, delete_temp_file)
3547 (Fcall_process_region):
3548 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3549 (Fcall_process): Simplify handling of volatile integers.
3550 Use int, not EMACS_INT, where int will do.
3551 * casefiddle.c (casify_object, casify_region, operate_on_word)
3552 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
3553 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3554 (casify_object): Avoid integer overflow when overallocating buffer.
3555 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 3556 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
3557 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
3558 * category.h (CATEGORYP): Don't assume arg is nonnegative.
3559 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
3560 integers are now checked earlier. All uses replaced with XINT.
3561 (ccl_driver):
3562 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3563 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
3564 (ccl_driver, Fregister_code_conversion_map):
3565 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
3566 (resolve_symbol_ccl_program): Check that vector header is in range.
3567 Always copy the vector, so that we can check its contents reliably
3568 now rather than having to recheck each instruction as it's being
3569 executed. Check that vector words fit in 'int'.
3570 (ccl_get_compiled_code, Fregister_ccl_program)
3571 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
3572 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
3573 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
3574 contents are in range.
3575 (Fccl_execute_on_string): Check that status is in range.
3576 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
3577 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
3578 Accept and return EMACS_INT, not int, because callers can pass values
3579 out of 'int' range.
3580 (c_string_width, strwidth, lisp_string_width, chars_in_text)
3581 (multibyte_chars_in_text, parse_str_as_multibyte)
3582 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
3583 (str_as_unibyte, str_to_unibyte, string_count_byte8)
3584 (string_escape_byte8, Fget_byte):
3585 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 3586 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
3587 avoid mishandling large integers.
3588 * character.h: Adjust decls to match defn changes elsewhere.
3589 * charset.c (load_charset_map_from_file, find_charsets_in_text)
3590 (Ffind_charset_region):
3591 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3592 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
3593 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 3594 Don't assume fixnum fits in int.
d311d28c
PE
3595 (load_charset_map_from_vector, Fmap_charset_chars):
3596 Remove now-unnecessary CHECK_NATNUMs.
3597 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
3598 Don't rely on undefined behavior with signed left shift overflow.
3599 Don't assume unsigned int fits into fixnum, or that fixnum fits
3600 into unsigned int. Don't require max_code to be a valid fixnum;
3601 that's not true for gb10830 4-byte on a 32-bit host. Allow
3602 invalid_code to be a cons, for the same reason. Require code_offset
3603 to be a character. Avoid int overflow if max_char is close
3604 to INT_MAX.
3605 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
3606 this is intended anyway and avoids some undefined behavior.
3607 (load_charset_map): Pass unsigned, not int, as 2nd arg of
3608 INDEX_TO_CODE_POINT, as that's what it expects.
3609 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
3610 * charset.h (DECODE_CHAR): Return int, not unsigned;
3611 this is what was intended anyway, and it avoids undefined behavior.
3612 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
3613 integer-overflow issues.
3614 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
3615 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
3616 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
3617 * chartab.c (Fmake_char_table, Fset_char_table_range)
3618 (uniprop_get_decoder, uniprop_get_encoder):
3619 Don't assume fixnum fits in int.
3620 * cmds.c (move_point): New function, that does the gist of
3621 Fforward_char and Fbackward_char, but does so while checking
3622 for integer overflow more accurately.
c96e5d6a 3623 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
3624 (Fforward_line, Fend_of_line, internal_self_insert)
3625 (internal_self_insert):
3626 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3627 Fix a FIXME, by checking for integer overflow when calculating
3628 target_clm and actual_clm.
3629 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 3630 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
3631 (ASSURE_DESTINATION, coding_alloc_by_realloc)
3632 (coding_alloc_by_making_gap, alloc_destination)
3633 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
3634 (encode_coding_utf_16, detect_coding_emacs_mule)
3635 (decode_coding_emacs_mule, encode_coding_emacs_mule)
3636 (detect_coding_iso_2022, decode_coding_iso_2022)
3637 (encode_invocation_designation, encode_designation_at_bol)
3638 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3639 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
3640 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
3641 (encode_coding_ccl, encode_coding_raw_text)
3642 (detect_coding_charset, decode_coding_charset)
3643 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
3644 (produce_composition, produce_charset, produce_annotation)
3645 (decode_coding, handle_composition_annotation)
3646 (handle_charset_annotation, consume_chars, decode_coding_gap)
3647 (decode_coding_object, encode_coding_object, detect_coding_system)
3648 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
3649 (code_convert_region, code_convert_string)
8f50130c
PE
3650 (Fdefine_coding_system_internal)
3651 (coding_set_source, coding_set_destination):
d311d28c
PE
3652 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3653 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
3654 (Fdefine_coding_system_internal):
3655 Don't assume fixnums fit in int.
3656 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 3657 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
3658 (Funencodable_char_position, Fcheck_coding_systems_region)
3659 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 3660 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 3661 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 3662 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 3663 Don't access memory outside of the args array.
d311d28c 3664 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
3665 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
3666 result of ENCODE_CHAR.
d311d28c
PE
3667 * coding.h: Adjust decls to match defn changes elsewhere.
3668 (struct coding_system):
3669 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3670 * composite.c (get_composition_id, find_composition)
3671 (run_composition_function, update_compositions)
3672 (compose_text, composition_gstring_put_cache)
3673 (composition_gstring_p, composition_gstring_width)
3674 (fill_gstring_header, fill_gstring_body, autocmp_chars)
3675 (composition_compute_stop_pos, composition_reseat_it)
3676 (composition_update_it, struct position_record)
3677 (find_automatic_composition, composition_adjust_point)
3678 (Fcomposition_get_gstring, Ffind_composition_internal):
3679 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3680 (update_compositions):
3681 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3682 * composite.h: Adjust decls to match defn changes elsewhere.
3683 (struct composition):
3684 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3685 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
3686 Do not attempt to compute the address of the object just before a
3687 buffer; this is not portable.
3688 (Faref, Faset):
3689 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3690 (Faset): Use int, not EMACS_INT, where int is wide enough.
3691 (Fstring_to_number): Don't assume fixnums fit in int.
3692 (Frem): Don't assume arg is nonnegative.
3693 * dbusbind.c (xd_append_arg): Check for integers out of range.
3694 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 3695 (extract_signed, extract_unsigned): New functions.
243e0530
PE
3696 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
3697 (xd_get_connection_references): Return ptrdiff_t, not int.
3698 All uses changed.
3699 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
3700 (xd_read_message_1):
3701 Use int, not unsigned, where the dbus API uses int.
3702 (Fdbus_message_internal): Don't overflow mtype.
3703 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
3704 * dired.c (directory_files_internal, file_name_completion, scmp)
3705 (file_name_completion_stat):
3706 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3707 (file_name_completion): Don't overflow matchcount.
3708 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
3709 * dispextern.h: Adjust decls to match defn changes elsewhere.
3710 (struct text_pos, struct glyph, struct bidi_saved_info)
3711 (struct bidi_string_data, struct bidi_it, struct composition_it)
3712 (struct it):
3713 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3714 (struct display_pos, struct composition_it, struct it):
3715 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3716 * dispnew.c (increment_matrix_positions)
3717 (increment_row_positions, mode_line_string)
3718 (marginal_area_string):
3719 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 3720 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
3721 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3722 (duration_to_sec_usec): New function, to check for overflow better.
3723 (Fsleep_for, sit_for): Use it.
3724 * doc.c (get_doc_string, store_function_docstring):
3725 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3726 (get_doc_string, Fsnarf_documentation):
3727 Use int, not EMACS_INT, where int is wide enough.
3728 (get_doc_string):
3729 Use SAFE_ALLOCA, not alloca.
3730 Check for overflow when converting EMACS_INT to off_t.
3731 * doprnt.c (doprnt):
3732 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3733 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
3734 Don't assume uid_t fits into fixnum.
3735 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
3736 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
3737 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
3738 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
3739 (general_insert_function)
3740 (Finsert_char, make_buffer_string, make_buffer_string_both)
3741 (update_buffer_properties, Fbuffer_substring)
3742 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
3743 (Fsubst_char_in_region, check_translation)
3744 (Ftranslate_region_internal, save_restriction_restore, Fformat)
3745 (transpose_markers, Ftranspose_regions):
3746 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3747 (clip_to_bounds): Move to lisp.h as an inline function).
3748 (Fconstrain_to_field): Don't assume integers are nonnegative.
3749 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
3750 (Fsubst_char_in_region, Fsave_restriction):
3751 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3752 (Femacs_pid): Don't assume pid_t fits into fixnum.
3753 (lo_time): Use int, not EMACS_INT, when int suffices.
3754 (lisp_time_argument): Check for usec out of range.
3755 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
3756 (Fuser_login_name, Fuser_full_name): Signal an error
3757 if a uid argument is out of range, rather than relying on
3758 undefined behavior.
c8d5c857
PE
3759 (Fformat_time_string): Remove now-unnecessary check.
3760 lisp_time_argument checks for out-of-range usec now.
243e0530 3761 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
3762 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
3763 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
3764 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
3765 (init_cmdargs, Fdump_emacs):
3766 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3767 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
3768 the bottom (typically) 32 bits of the fixnum.
3769 * eval.c (specpdl_size, call_debugger):
3770 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3771 (when_entered_debugger, Fbacktrace_debug):
3772 Don't assume fixnum can fit in int.
3773 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
3774 the object just before a buffer; this is not portable.
3775 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
3776 (grow_specpdl, unbind_to):
3777 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3778 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
3779 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 3780 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
3781 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
3782 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
3783 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3784 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
3785 (a_write, e_write):
3786 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3787 (Fcopy_file, non_regular_nbytes, read_non_regular)
3788 (Finsert_file_contents):
3789 Use int, not EMACS_INT, where int is wide enough.
3790 (READ_BUF_SIZE): Verify that it fits in int.
3791 (Finsert_file_contents): Check that counts are in proper range,
3792 rather than assuming fixnums fit into ptrdiff_t etc.
3793 Don't assume fixnums fit into int.
125b3835 3794 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
3795 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
3796 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
3797 (string_char_to_byte, string_byte_to_char)
3798 (string_make_multibyte, string_to_multibyte)
3799 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
3800 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
3801 (substring_both, Fdelete, internal_equal, Ffillarray)
3802 (Fclear_string, mapcar1)
3803 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
3804 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
3805 (larger_vector, make_hash_table, maybe_resize_hash_table)
3806 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
3807 (Fmaphash, secure_hash):
3808 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3809 (concat): Check for string index and length overflow.
3810 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
3811 (Frequire):
3812 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3813 (larger_vector): New API (vec, incr_min, size_max) replaces old
3814 one (vec, new_size, init). This catches size overflow.
3815 INIT was removed because it was always Qnil.
3816 All callers changed.
3817 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
3818 the upper bound on a hash table index size.
3819 (make_hash_table, maybe_resize_hash_table): Use it.
3820 (secure_hash): Computer start_byte and end_byte only after
3821 they're known to be in ptrdiff_t range.
3822 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
3823 (Ffont_get_glyphs, Ffont_at):
3824 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3825 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
3826 (Flist_fonts, Fopen_font):
3827 Don't assume fixnum can fit in int.
3828 (check_gstring): Don't assume index can fit in int.
3829 (font_match_p): Check that fixnum is a character, not a nonnegative
3830 fixnum, since the later code needs to stuff it into an int.
3831 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
3832 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
3833 conversion overflow issues.
3834 (Fopen_font): Check for integer out of range.
3835 (Ffont_get_glyphs): Don't assume index can fit in int.
3836 * font.h: Adjust decls to match defn changes elsewhere.
3837 * fontset.c (reorder_font_vector): Redo score calculation to avoid
3838 integer overflow.
3839 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
3840 printmax_t, where ptrdiff_t is wide enough.
3841 (Finternal_char_font):
3842 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3843 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
3844 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
3845 (Fset_frame_position, x_set_frame_parameters)
3846 (x_set_line_spacing, x_set_border_width)
3847 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
3848 Check that fixnums are in proper range for system types.
3849 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
3850 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3851 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
3852 Use SAFE_ALLOCA_LISP, not alloca.
3853 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
3854 intptr_t is wide enough.
3855 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
3856 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
3857 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
3858 Check for fixnum out of range.
3859 * ftfont.c (ftfont_list): Don't assume index fits in int.
3860 Check that fixnums are in proper range for system types.
3861 (ftfont_shape_by_flt):
3862 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
3863 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3864 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3865 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
3866 Check that fixnums are in proper range for system types.
3867 * gnutls.h: Adjust decls to match defn changes elsewhere.
3868 * gtkutil.c (xg_dialog_run):
3869 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3870 (update_frame_tool_bar):
3871 Check that fixnums are in proper range for system types.
3872 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 3873 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
3874 * indent.c (last_known_column, last_known_column_point):
3875 (current_column_bol_cache):
3876 (skip_invisible, current_column, check_display_width):
3877 (check_display_width, scan_for_column, current_column_1)
3878 (Findent_to, Fcurrent_indentation, position_indentation)
3879 (indented_beyond_p, Fmove_to_column, compute_motion):
3880 (Fcompute_motion, Fvertical_motion):
3881 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3882 (last_known_column_modified): Use EMACS_INT, not int.
3883 (check_display_width):
3884 (Fcompute_motion):
3885 Check that fixnums and floats are in proper range for system types.
3886 (compute_motion): Don't assume index or fixnum fits in int.
3887 (compute_motion, Fcompute_motion):
3888 Use int, not EMACS_INT, when it is wide enough.
3889 (vmotion): Omit local var start_hpos that is always 0; that way
3890 we don't need to worry about overflow in expressions involving it.
3891 * indent.h: Adjust decls to match defn changes elsewhere.
3892 (struct position):
3893 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3894 Use int, not EMACS_INT, where int is wide enough.
3895 Remove unused members ovstring_chars_done and tab_offset;
3896 all uses removed.
3897 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
3898 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
3899 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
3900 (make_gap, copy_text, insert, insert_and_inherit)
3901 (insert_before_markers, insert_before_markers_and_inherit)
3902 (insert_1, count_combining_before, count_combining_after)
3903 (insert_1_both, insert_from_string)
3904 (insert_from_string_before_markers, insert_from_string_1)
3905 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
3906 (adjust_after_replace, adjust_after_insert, replace_range)
3907 (replace_range_2, del_range, del_range_1, del_range_byte)
3908 (del_range_both, del_range_2, modify_region)
3909 (prepare_to_modify_buffer, signal_before_change)
3910 (signal_after_change, Fcombine_after_change_execute):
3911 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3912 * intervals.c (traverse_intervals, rotate_right, rotate_left)
3913 (balance_an_interval, split_interval_right, split_interval_left)
3914 (find_interval, next_interval, update_interval)
3915 (adjust_intervals_for_insertion, delete_node, delete_interval)
3916 (interval_deletion_adjustment, adjust_intervals_for_deletion)
3917 (static_offset_intervals, offset_intervals)
3918 (merge_interval_right, merge_interval_left, make_new_interval)
3919 (graft_intervals_into_buffer, temp_set_point_both)
3920 (temp_set_point, set_point, adjust_for_invis_intang)
3921 (set_point_both, move_if_not_intangible, get_property_and_range)
3922 (get_local_map, copy_intervals, copy_intervals_to_string)
3923 (compare_string_intervals, set_intervals_multibyte_1):
3924 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3925 * intervals.h: Adjust decls to match defn changes elsewhere.
3926 (struct interval):
3927 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3928 * keyboard.c (this_command_key_count, this_single_command_key_start)
3929 (before_command_key_count, before_command_echo_length, echo_now)
3930 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
3931 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
3932 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
3933 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
3934 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3935 (last_non_minibuf_size, last_point_position, echo_truncate)
3936 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
3937 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
3938 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
3939 (stuff_buffered_input):
3940 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3941 (last_auto_save, command_loop_1, read_char):
3942 Use EMACS_INT, not int, to avoid integer overflow.
3943 (record_char): Avoid overflow in total_keys computation.
3944 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
3945 * keyboard.h: Adjust decls to match defn changes elsewhere.
3946 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
3947 (Fkey_description, Fdescribe_vector, Flookup_key):
3948 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3949 (click_position): New function, to check that positions are in range.
3950 (Fcurrent_active_maps):
3951 (describe_command):
3952 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3953 (Faccessible_keymaps, Fkey_description):
3954 (preferred_sequence_p):
3955 Don't assume fixnum can fit into int.
3956 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
3957 Check for integer overflow in size calculations.
3958 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
3959 avoid mishandling large integers.
3960 * lisp.h: Adjust decls to match defn changes elsewhere.
3961 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
3962 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
3963 (struct Lisp_Marker):
3964 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3965 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
3966 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
3967 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
3968 All callers changed.
3969 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
3970 Assume the arg has valid form, since it always does.
3971 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
3972 unsigned integer system type.
3973 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
3974 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
3975 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3976 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
3977 (duration_to_sec_usec): New decl.
3978 * lread.c (read_from_string_index, read_from_string_index_byte)
3979 (read_from_string_limit, readchar, unreadchar, openp)
3980 (read_internal_start, read1, oblookup):
3981 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3982 (Fload, readevalloop, Feval_buffer, Feval_region):
3983 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3984 (openp): Check for out-of-range argument to 'access'.
3985 (read1): Use int, not EMACS_INT, where int is wide enough.
3986 Don't assume fixnum fits into int.
6efdadfd 3987 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
3988 (read_filtered_event): Use duration_to_sec_usec
3989 to do proper overflow checking on durations.
d311d28c
PE
3990 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
3991 in size calculation.
3992 (Fexecute_kbd_macro):
3993 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3994 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
3995 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
3996 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
3997 (set_marker_both, set_marker_restricted_both, marker_position)
3998 (marker_byte_position, Fbuffer_has_markers_at):
3999 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4000 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 4001 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
4002 It now merely ensures that the menu is large enough, without
4003 necessarily growing it, as this avoids some integer overflow issues.
4004 All callers changed.
4005 (keymap_panes, parse_single_submenu, Fx_popup_menu):
4006 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4007 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
4008 Use SAFE_ALLOCA_LISP, not alloca.
4009 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
4010 to EMACS_INT. Check that fixnums are in proper range for system types.
4011 * minibuf.c (minibuf_prompt_width, string_to_object)
4012 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
4013 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
4014 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4015 (get_minibuffer, read_minibuf_unwind):
4016 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4017 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
4018 this simplifies overflow checking. All callers changed.
4019 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
4020 (Ftest_completion):
4021 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4022 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
4023 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
4024 Check that fixnums are in proper range for system types.
4025 (Fx_create_frame, Fx_show_tip):
4026 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4027 * nsfont.m (ns_findfonts, nsfont_list_family):
4028 Don't assume fixnum fits in long.
4029 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
4030 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4031 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
4032 wide enough.
17fdb222 4033 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
4034 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4035 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
4036 (PRINTDECLARE, PRINTPREPARE):
4037 (strout, print_string):
4038 (print, print_preprocess, print_check_string_charset_prop)
4039 (print_object):
4040 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4041 (PRINTDECLARE):
4042 (temp_output_buffer_setup, Fprin1_to_string, print_object):
4043 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4044 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 4045 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 4046 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
4047 (print_error_message): Use SAFE_ALLOCA, not alloca.
4048 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
4049 (print_depth, new_backquote_output, print_number_index):
4050 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
4051 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
4052 (Fset_process_window_size, Fformat_network_address)
4053 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 4054 (sigchld_handler):
d311d28c 4055 Check that fixnums are in proper range for system types.
d44287d4 4056 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
4057 Check for process-ids out of pid_t range rather than relying on
4058 undefined behavior.
e4d81efc 4059 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
4060 (Fformat_network_address, read_process_output, send_process)
4061 (Fprocess_send_region, status_notify):
4062 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4063 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
4064 (wait_reading_process_output, read_process_output, exec_sentinel):
4065 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4066 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
4067 (Faccept_process_output): Use duration_to_sec_usec to do proper
4068 overflow checking on durations.
dde14581
PE
4069 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
4070 Don't assume pid_t fits in int.
02481186
PE
4071 * process.h (struct Lisp_Process): Members tick and update_tick
4072 are now of type EMACS_INT, not int.
b62b53e8
PE
4073 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
4074 configured --with-wide-int.
d311d28c
PE
4075 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
4076 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
4077 * search.c (looking_at_1, string_match_1):
4078 (fast_string_match, fast_c_string_match_ignore_case)
4079 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
4080 (scan_newline, find_before_next_newline, search_command)
4081 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
4082 (set_search_regs, wordify):
4083 (Freplace_match):
4084 (Fmatch_data):
4085 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4086 (string_match_1, search_buffer, set_search_regs):
4087 (Fmatch_data):
4088 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4089 (wordify): Check for overflow in size calculation.
4090 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
4091 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
4092 Check that fixnums are in proper range for system types.
4093 * sound.c (struct sound_device)
4094 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
4095 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4096 (Fplay_sound_internal):
4097 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 4098 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
4099 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
4100 (Fparse_partial_sexp):
4101 Don't assume fixnums can fit in int.
4102 (struct lisp_parse_state, find_start_pos, find_start_value)
4103 (find_start_value_byte, find_start_begv)
4104 (update_syntax_table, char_quoted, dec_bytepos)
4105 (find_defun_start, prev_char_comend_first, back_comment):
4106 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
4107 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
4108 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4109 (Finternal_describe_syntax_value): Check that match_lisp is a
4110 character, not an integer, since the code stuffs it into int.
4111 (scan_words, scan_sexps_forward):
4112 Check that fixnums are in proper range for system types.
4113 (Fforward_word):
4114 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4115 (scan_sexps_forward):
4116 Use CHARACTERP, not INTEGERP, since the value must fit into int.
4117 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
4118 * syntax.h: Adjust decls to match defn changes elsewhere.
4119 (struct gl_state_s):
4120 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
4121 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
4122 MOST_POSITIVE_FIXNUM.
d311d28c
PE
4123 * sysdep.c (wait_for_termination_1, wait_for_termination)
4124 (interruptible_wait_for_termination, mkdir):
4125 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
4126 (emacs_read, emacs_write):
4127 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
4128 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
4129 and double all fit in int.
d311d28c
PE
4130 * term.c (set_tty_color_mode):
4131 Check that fixnums are in proper range for system types.
4132 * termhooks.h (struct input_event):
4133 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4134 * textprop.c (validate_interval_range, interval_of)
4135 (Fadd_text_properties, set_text_properties_1)
4136 (Fremove_text_properties, Fremove_list_of_text_properties)
4137 (Ftext_property_any, Ftext_property_not_all)
4138 (copy_text_properties, text_property_list, extend_property_ranges)
4139 (verify_interval_modification):
4140 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4141 (Fnext_single_char_property_change)
4142 (Fprevious_single_char_property_change):
4143 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
4144 (copy_text_properties):
4145 Check for integer overflow in index calculation.
d311d28c
PE
4146 * undo.c (last_boundary_position, record_point, record_insert)
4147 (record_delete, record_marker_adjustment, record_change)
4148 (record_property_change):
4149 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4150 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
4151 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4152 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4153 (Fx_hide_tip, Fx_file_dialog):
4154 * w32menu.c (set_frame_menubar):
4155 Use ptrdiff_t, not int, for consistency with rest of code.
4156 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
4157 (select_window, Fdelete_other_windows_internal)
4158 (window_scroll_pixel_based, window_scroll_line_based)
4159 (Frecenter, Fset_window_configuration):
4160 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4161 (Fset_window_hscroll, run_window_configuration_change_hook)
4162 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 4163 (Fscroll_other_window, Frecenter):
d311d28c
PE
4164 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4165 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
4166 Don't assume fixnum fits in int.
4167 (Fset_window_scroll_bars):
4168 Check that fixnums are in proper range for system types.
4169 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
4170 (string_pos, c_string_pos, number_of_chars, init_iterator)
4171 (in_ellipses_for_invisible_text_p, init_from_display_pos)
4172 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
4173 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
4174 (face_before_or_after_it_pos, handle_invisible_prop)
4175 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
4176 (display_prop_intangible_p, string_buffer_position_lim)
4177 (string_buffer_position, handle_composition_prop, load_overlay_strings)
4178 (get_overlay_strings_1, get_overlay_strings)
4179 (iterate_out_of_display_property, forward_to_next_line_start)
4180 (back_to_previous_visible_line_start, reseat, reseat_to_string)
4181 (get_next_display_element, set_iterator_to_next)
4182 (get_visually_first_element, compute_stop_pos_backwards)
4183 (handle_stop_backwards, next_element_from_buffer)
4184 (move_it_in_display_line_to, move_it_in_display_line)
4185 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4186 (add_to_log, message_dolog, message_log_check_duplicate)
4187 (message2, message2_nolog, message3, message3_nolog
4188 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
4189 (current_message_1, truncate_echo_area, truncate_message_1)
4190 (set_message, set_message_1, store_mode_line_noprop)
4191 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
4192 (text_outside_line_unchanged_p, check_point_in_composition)
4193 (reconsider_clip_changes)
4194 (redisplay_internal, set_cursor_from_row, try_scrolling)
4195 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
4196 (redisplay_window, find_last_unchanged_at_beg_row)
4197 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
4198 (trailing_whitespace_p, find_row_edges, display_line)
4199 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
4200 (display_mode_element, store_mode_line_string)
4201 (pint2str, pint2hrstr, decode_mode_spec)
4202 (display_count_lines, display_string, draw_glyphs)
4203 (x_produce_glyphs, x_insert_glyphs)
4204 (rows_from_pos_range, mouse_face_from_buffer_pos)
4205 (fast_find_string_pos, mouse_face_from_string_pos)
4206 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4207 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4208 (safe_call, init_from_display_pos, handle_fontified_prop)
4209 (handle_single_display_spec, load_overlay_strings)
4210 (with_echo_area_buffer, setup_echo_area_for_printing)
4211 (display_echo_area, echo_area_display)
4212 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
4213 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
4214 (redisplay_window, dump_glyph_row, display_mode_line)
4215 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 4216 (handle_display_spec, display_prop_string_p):
d311d28c
PE
4217 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4218 (handle_single_display_spec, build_desired_tool_bar_string)
4219 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
4220 (get_specified_cursor_type):
4221 Check that fixnums are in proper range for system types.
4222 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
4223 (Flookup_image_map):
4224 Don't assume fixnums fit in int.
4225 (compare_overlay_entries):
4226 Avoid mishandling comparisons due to subtraction overflow.
4227 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
4228 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
4229 (handle_tool_bar_click):
4230 Use int, not unsigned, since we prefer signed and the signedness
4231 doesn't matter here.
4232 (get_next_display_element, next_element_from_display_vector):
4233 Use int, not EMACS_INT, when int is wide enough.
4234 (start_hourglass): Use duration_to_sec_usec to do proper
4235 overflow checking on durations.
4236 * xfaces.c (Fbitmap_spec_p):
4237 Check that fixnums are in proper range for system types.
4238 (compare_fonts_by_sort_order):
4239 Avoid mishandling comparisons due to subtraction overflow.
4240 (Fx_family_fonts, realize_basic_faces):
4241 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4242 (Fx_family_fonts):
4243 Don't assume fixnum fits in int.
4244 Use SAFE_ALLOCA_LISP, not alloca.
4245 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
4246 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
4247 (face_at_buffer_position, face_for_overlay_string)
4248 (face_at_string_position):
4249 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4250 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
4251 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
4252 (Fx_show_tip):
4253 Check that fixnums are in proper range for system types.
4254 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4255 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
4256 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4257 (Fx_change_window_property): Don't assume fixnums fit in int.
4258 * xfont.c (xfont_chars_supported):
4259 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4260 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
4261 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
4262 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4263 * xml.c (parse_region):
4264 * xrdb.c (magic_file_p):
4265 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4266 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
4267 (x_get_local_selection, x_reply_selection_request)
4268 (x_handle_selection_request, wait_for_property_change):
4269 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4270 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
4271 short is wide enough.
4272 (x_send_client_event): Don't assume fixnum fits in int.
4273 * xterm.c (x_x_to_emacs_modifiers):
4274 Don't assume EMACS_INT overflows nicely into int.
4275 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
4276 may come from Lisp.
4277 (handle_one_xevent): NATNUMP can eval its arg twice.
4278 (x_connection_closed):
4279 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4280 * xterm.h: Adjust decls to match defn changes elsewhere.
4281 (struct scroll_bar): Use struct vectorlike_header
4282 rather than rolling our own approximation.
4283 (SCROLL_BAR_VEC_SIZE): Remove; not used.
4284
c6574eb5
GM
42852012-05-25 Glenn Morris <rgm@gnu.org>
4286
4287 * lisp.mk (lisp): Update for more files being compiled now.
4288
e8d32c7e
SM
42892012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
4290
48def666
SM
4291 * lread.c: Remove `read_pure' which makes no difference.
4292 (read_pure): Remove var.
4293 (unreadpure): Remove function.
4294 (readevalloop): Don't call read_list with -1 flag.
4295 (read1, read_vector): Don't test read_pure any more.
4296 (read_list): Simplify.
4297
e8d32c7e
SM
4298 * fileio.c, character.h: Minor style tweaks.
4299
4b2addb7
DA
43002012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
4301
4302 * window.h (clip_changed): Remove useless declaration.
4303
584461b2
JB
43042012-05-22 Juanma Barranquero <lekktu@gmail.com>
4305
4306 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
4307 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
4308
34374650
PE
43092012-05-22 Paul Eggert <eggert@cs.ucla.edu>
4310
4311 Remove src/m/*.
4312 This directory predates autoconf and is no longer needed nowadays.
4313 Move its few remaining bits of functionality to where they're needed.
4314 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
4315 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
4316 * m/template.h: Remove.
4317 * Makefile.in (M_FILE): Remove. All uses removed.
4318 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
4319 * lisp.h (USE_LSB_TAG):
4320 * mem-limits.h (EXCEEDS_LISP_PTR):
4321 Use VAL_MAX, not VALBITS, in #if.
4322 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
4323 (EMACS_UINT): Define unconditionally now.
4324 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
4325 (BITS_PER_EMACS_INT): New constants, replacing
4326 what used to be in config.h, but not useful in #if.
4327 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
4328 define them any more.
4329 (VAL_MAX): New macro.
4330 (VALMASK): Use it.
4331 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
4332 BITS_PER_EMACS_INT, in #if.
4333 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
4334 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
4335 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
4336 * s/ms-w32.h (DATA_START):
4337 Move here from removed file m/intel386.h.
4338 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
4339 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
4340
261cb4bb
PE
43412012-05-21 Paul Eggert <eggert@cs.ucla.edu>
4342
4343 Assume C89 or later.
4344 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
4345 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
4346 (xrealloc):
4347 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
4348 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
4349 * textprop.c, tparam.c (NULL): Remove.
4350 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
4351 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
4352 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
4353 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
4354 * xterm.c (input_signal_count): Assume volatile works.
4355
ff23cd9f
KB
43562012-05-21 Ken Brown <kbrown@cornell.edu>
4357
4358 * xgselect.c (xg_select): Fix first argument in call to 'select'
4359 (bug#11508).
4360
1b170bc6
KB
43612012-05-20 Ken Brown <kbrown@cornell.edu>
4362
4363 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 4364 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 4365
b2f4d39f
KB
43662012-05-19 Ken Brown <kbrown@cornell.edu>
4367
4368 * xfns.c (x_in_use): Remove `static' qualifier.
4369 * xterm.h (x_in_use): Declare.
4370 * xgselect.c: Include xterm.h.
4371 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
4372 and `display_arg' (bug#9754).
4373
003fdae2
PE
43742012-05-19 Paul Eggert <eggert@cs.ucla.edu>
4375
9232a6d9
PE
4376 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
4377
003fdae2
PE
4378 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
4379 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
4380
784b56e2
EZ
43812012-05-18 Eli Zaretskii <eliz@gnu.org>
4382
4383 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
4384
4385 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 4386 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
4387
4388 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
4389 reference to image_cache->refcount.
4390 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
4391
a0a79cde
JL
43922012-05-17 Juri Linkov <juri@jurta.org>
4393
4394 * search.c (Fword_search_regexp, Fword_search_backward)
4395 (Fword_search_forward, Fword_search_backward_lax)
4396 (Fword_search_forward_lax): Move functions to isearch.el
4397 (bug#10145, bug#11381).
4398
b0572523
PE
43992012-05-16 Paul Eggert <eggert@cs.ucla.edu>
4400
4401 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
4402
9660f5fc
SM
44032012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
4404
4405 * lread.c (init_obarray): Declare Qt and Qnil as special.
4406
4374de83
GM
44072012-05-14 Glenn Morris <rgm@gnu.org>
4408
4409 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 4410 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 4411
dc44c39a
PE
44122012-05-14 Paul Eggert <eggert@cs.ucla.edu>
4413
078c97cb
PE
4414 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
4415
dc44c39a
PE
4416 * unexaix.c: Port to more-recent AIX compilers.
4417 (report_error, report_error_1, make_hdr, copy_sym)
4418 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
4419 Make arguments const char *, not char *, to avoid violations of C
4420 standard and to fix some AIX warnings reported by Gilles Pion.
4421
e18afed7 44222012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
4423
4424 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
4425 already have overlays loaded.
4426 (handle_single_display_spec): Before returning without displaying
4427 fringe bitmap, synchronize the bidi iterator with the main display
4428 iterator, by calling iterate_out_of_display_property.
4429 (iterate_out_of_display_property): Detect buffer iteration by
4430 testing that it->string is a Lisp string.
4431 (get_next_display_element): When the current object is exhausted,
4432 and there's something on it->stack, call set_iterator_to_next to
4433 proceed with what's on the stack, instead of returning zero.
4434 (set_iterator_to_next): If called at the end of a Lisp string,
4435 proceed to consider_string_end without incrementing string
4436 position. Don't increment display vector index past the end of
4437 the display vector. (Bug#11417)
c8fb9dc6
EZ
4438 (pos_visible_p): Don't report a position visible when move_it_to
4439 stopped at the last line of window, which happens to be scanned
4440 backwards by the bidi iteration. (Bug#11464)
ac268e67 4441
e18afed7 44422012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
4443
4444 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
4445 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
4446 are on a TTY, and thus unable to display on the fringes.
4447 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
4448 so we need to signal to the caller that this is a "replacing"
4449 display spec. This fixes display when the spec is invalid or we
4450 are on a TTY.
4451
e18afed7 44522012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
4453
4454 * unexaix.c (make_hdr): Fix typo in prototype.
4455 This bug broke the build on AIX. Problem reported by Gilles Pion.
4456
9d0a235a
MA
44572012-05-14 Michael Albinus <michael.albinus@gmx.de>
4458
4459 * keyboard.c (kbd_buffer_get_event): Read special events also in
4460 batch mode. (Bug#11415)
4461
9e6b06ed
GM
44622012-05-12 Glenn Morris <rgm@gnu.org>
4463
4464 * ns.mk: Update for ns_appbindir no longer having trailing "/".
4465
c1a1d7a3
EZ
44662012-05-12 Eli Zaretskii <eliz@gnu.org>
4467
4468 * lisp.mk (lisp): Add newcomment.elc.
4469
3fe7cdc8
GM
44702012-05-12 Glenn Morris <rgm@gnu.org>
4471
4472 * Makefile.in (MKDIR_P): New, set by configure.
4473 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
4474
53f7d2c0
PE
44752012-05-11 Paul Eggert <eggert@cs.ucla.edu>
4476
4477 Remove unused function hourglass_started.
4478 * dispextern.h (hourglass_started):
4479 * w32fns.c (hourglass_started):
4480 * xdisp.c (hourglass_started): Remove.
4481
75aafb17
JB
44822012-05-10 Juanma Barranquero <lekktu@gmail.com>
4483
4484 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
4485 Update dependencies.
4486
12959e8e
PE
44872012-05-10 Paul Eggert <eggert@cs.ucla.edu>
4488
97107e2e
PE
4489 * xgselect.c (xg_select): Put maxfds+1 into a var.
4490 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
4491
12959e8e
PE
4492 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
4493
836d29b3
DA
44942012-05-10 Dave Abrahams <dave@boostpro.com>
4495
4496 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
4497 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
4498
5cb67954
MA
44992012-05-09 Michael Albinus <michael.albinus@gmx.de>
4500
4501 * dbusbind.c (xd_registered_buses): New internal Lisp object.
4502 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
4503 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
4504 Initialize xd_registered_buses.
4505
3478ec45
PE
45062012-05-09 Paul Eggert <eggert@cs.ucla.edu>
4507
b263a6b0
PE
4508 Untag more efficiently if USE_LSB_TAG.
4509 This is based on a proposal by YAMAMOTO Mitsuharu in
4510 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
4511 For an admittedly artificial (nth 8000 longlist) benchmark on
4512 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
4513 Emacs's overall text size by 1%.
4514 * lisp.h (XUNTAG): New macro.
4515 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
4516 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
4517 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
4518 * eval.c (Fautoload):
4519 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
4520 * frame.h (XFRAME): Use XUNTAG.
4521
3478ec45
PE
4522 Port recent dbusbind.c changes to 32-bit --with-wide-int.
4523 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
4524 Remove unportable assumptions about print widths of types like
4525 dbus_uint32_t.
4526 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
4527 intptr_t when converting between pointer and integer, to avoid GCC
4528 warnings about wrong width.
4529
666b903b 45302012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
4531
4532 * w32proc.c (new_child): Force Windows to reserve only 64KB of
4533 stack for each reader_thread, instead of defaulting to 8MB
4534 determined by the linker. This avoids failures in creating
4535 subprocesses on Windows 7, see the discussion in this thread:
4536 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
4537
b120cc17
JC
45382012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
4539
4540 Fix up display of the *Minibuf-0* buffer in the mini window.
4541 * keyboard.c (read_char): Don't clear the echo area if there's no
4542 message to clear.
4543 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 4544 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 4545
9a4b36f8
MA
45462012-05-07 Michael Albinus <michael.albinus@gmx.de>
4547
4548 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
4549 batch mode.
4550
e5f9458f
CY
45512012-05-06 Chong Yidong <cyd@gnu.org>
4552
4553 * lisp.mk (lisp): Update.
4554
eceeb5fc 45552012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
4556
4557 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
4558
71873e2b
SM
45592012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
4560
4561 * data.c (PUT_ERROR): New macro.
4562 (syms_of_data): Use it. Add new error type `user-error'.
4563 * undo.c (user_error): New function.
4564 (Fprimitive_undo): Use it.
4565 * print.c (print_error_message): Adjust print style for `user-error'.
4566 * keyboard.c (user_error): New function.
4567 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
4568
ab0fa4e4
PE
45692012-05-03 Paul Eggert <eggert@cs.ucla.edu>
4570
4571 Do not limit current-time-string to years 1000..9999.
4572 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
4573 (Fcurrent_time_string): Support any year that is supported by the
4574 underlying localtime representation. Don't use asctime, as it
4575 has undefined behavior for years outside the range -999..9999.
4576
7ed806a7
PE
45772012-05-02 Paul Eggert <eggert@cs.ucla.edu>
4578
4579 Fix race conditions involving setenv, gmtime, localtime, asctime.
4580 Without this fix, interrupts could mess up code that uses these
4581 nonreentrant functions, since setting TZ invalidates existing
4582 tm_zone or tzname values, and since most of these functions return
4583 pointers to static storage.
4584 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
4585 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
4586 Grow the critical sections to include not just invoking
4587 localtime/gmtime, but also accessing these functions' results
4588 including their tm_zone values if any, and any related TZ setting.
4589 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
4590 so that the struct tm is saved in the critical section.
4591 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
4592 motivated by the fact that memory allocation needs to be outside
4593 the critical section.
4594
0c16dfed
DA
45952012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
4596
4597 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
4598 with RESET_INTERVAL.
4599
4600 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4601 Remove duplicated buffer name initialization.
4602
3f83ace8
JM
46032012-05-02 Jim Meyering <jim@meyering.net>
4604
4605 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
4606
c7b8541e
JM
4607 * xfns.c (x_window): Use xstrdup (Bug#11375).
4608
90207a15 46092012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
4610
4611 * xdisp.c (pos_visible_p): If already at a newline from the
4612 display string before the 'while' loop, don't walk back the glyphs
4613 from it3.glyph_row. Solves assertion violation when the display
4614 string begins with a newline (egg.el). (Bug#11367)
4615
b593d6a9
AH
46162012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
4617
4618 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
4619 Move to simple.el.
4620
4737362e
GM
46212012-05-01 Glenn Morris <rgm@gnu.org>
4622
99cf43f9
GM
4623 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
4624 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
4625 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
4626 All were removed before 23.1.
4627
9311dcff
GM
4628 * dispnew.c: Remove HAVE_LIBNCURSES test;
4629 it is always true on relevant platforms.
4630
4d5c6349
GM
4631 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
4632 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
4633
4737362e
GM
4634 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
4635
74dd3a6b
AS
46362012-04-30 Andreas Schwab <schwab@linux-m68k.org>
4637
4638 * .gdbinit (xpr): Remove checks for no longer existing misc types.
4639 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
4640 Remove.
4641
13c379ee
PE
46422012-04-28 Paul Eggert <eggert@cs.ucla.edu>
4643
4644 Do not avoid creating empty evaporating overlays (Bug#9642).
4645 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
4646 That is, do not delete an evaporating overlay if it becomes
4647 empty after its bounds are adjusted to fit within its buffer.
4648 This fix caused other problems, and I'm reverting it until we get
4649 to the bottom of them.
4650
a8e7d6d7 46512012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
4652
4653 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
4654
a8e7d6d7 46552012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
4656
4657 * xdisp.c (pos_visible_p): If the window start position is beyond
4658 ZV, start the display from buffer beginning. Prevents assertion
4659 violation in init_iterator when the minibuffer window is scrolled
4660 via the scroll bar.
4661
4662 * window.c (window_scroll_pixel_based): Likewise.
4663
a8e7d6d7 46642012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
4665
4666 * keymap.c (where_is_internal): Doc fix (Bug#10872).
4667
a8e7d6d7 46682012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
4669
4670 * fileio.c (Fcopy_file, Fset_file_selinux_context):
4671 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
4672
a8e7d6d7 46732012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 4674
b593d6a9
AH
4675 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
4676 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 4677
1c6900d9
EZ
46782012-04-26 Eli Zaretskii <eliz@gnu.org>
4679
4c3fa1d9
EZ
4680 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
4681 display element, check also the underlying string or buffer
4682 character. (Bug#11341)
4683
1c6900d9
EZ
4684 * w32menu.c: Include w32heap.h.
4685 (add_menu_item): If the call to AppendMenuW (via
4686 unicode_append_menu) fails, disable Unicode menus only if we are
4687 running on Windows 9X/Me.
4688
42bf8205
AS
46892012-04-24 Andreas Schwab <schwab@linux-m68k.org>
4690
4691 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
4692 (xgetint): Add missing shift for LSB tags.
4693
b1bac16e
MR
46942012-04-24 Martin Rudalics <rudalics@gmx.at>
4695
4696 * keyboard.c (read_char): Don't wipe echo area for select window
4697 events: These might get delayed via `mouse-autoselect-window'
4698 (Bug#11304).
4699
d69621cc
JB
47002012-04-24 Juanma Barranquero <lekktu@gmail.com>
4701
4702 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
4703 manipulation of :loaded-from data.
4704
02fd101b
JB
47052012-04-23 Juanma Barranquero <lekktu@gmail.com>
4706
4707 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
4708 now a cons (bug#11311).
4709
888bec30
PE
47102012-04-23 Paul Eggert <eggert@cs.ucla.edu>
4711
89a438bd
PE
4712 Do not create empty overlays with the evaporate property (Bug#9642).
4713 * buffer.c (Fmove_overlay): Delete an evaporating overlay
4714 if it becomes empty after its bounds are adjusted to fit within
4715 its buffer. Without this fix, in a nonempty buffer (let ((o
4716 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
4717 yields an empty overlay that has the evaporate property, which is
4718 not supposed to happen.
4719
1068fe4d
PE
4720 Fix minor GTK3 problems found by static checking.
4721 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4722 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4723 (struct _EmacsFixedClass, emacs_fixed_get_type):
4724 Move decls here from emacsgtkfixed.h, since they needn't be public.
4725 (emacs_fixed_get_type): Now static.
4726 (emacs_fixed_class_init): Omit unused local.
4727 (emacs_fixed_child_type): Remove; unused.
4728 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4729 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4730 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
4731 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
4732 (EMACS_FIXED_GET_CLASS): Remove; unused.
4733 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
4734
888bec30
PE
4735 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
4736 Problem reported by Juanma Barranquero for Windows -Wunused-function.
4737
de85e130
PE
47382012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4739
d0baac98 4740 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 4741 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
4742 (__malloc_size_t, __malloc_ptrdiff_t):
4743 Remove. All uses removed, replaced by the definiens if needed,
4744 since we can assume C89 or better now.
4745 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
4746 (protect_malloc_state, align, get_contiguous_space)
4747 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
4748 (malloc_atfork_handler_child, malloc_enable_thread)
4749 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
4750 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
4751 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
4752 (special_realloc, _realloc_internal_nolock, _realloc_internal)
4753 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
4754 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
4755 Define using prototypes, not old style.
4756 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
4757 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
4758 (align): Don't assume that signed integer overflow wraps around.
4759 Omit unused local var.
4760 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
4761 (_free_internal_nolock, memalign, mallochook, reallochook):
4762 Omit no-longer-needed casts.
4763 (valloc): Use getpagesize, not __getpagesize.
4764 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
4765 (struct hdr): The 'magic' member is now size_t, not unsigned long.
4766
de85e130
PE
4767 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
4768
dcbf5805
MA
47692012-04-22 Michael Albinus <michael.albinus@gmx.de>
4770
4771 Move functions from C to Lisp. Make non-blocking method calls
4772 the default. Implement further D-Bus standard interfaces.
4773
4774 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
4775 (QCdbus_request_name_allow_replacement)
4776 (QCdbus_request_name_replace_existing)
4777 (QCdbus_request_name_do_not_queue)
4778 (QCdbus_request_name_reply_primary_owner)
4779 (QCdbus_request_name_reply_in_queue)
4780 (QCdbus_request_name_reply_exists)
4781 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
4782 (QCdbus_registered_serial, QCdbus_registered_method)
4783 (QCdbus_registered_signal): New Lisp objects.
4784 (XD_DEBUG_MESSAGE): Use sizeof.
4785 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
4786 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
4787 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
4788 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
4789 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
4790 (xd_signature, xd_append_arg): Allow float for integer types.
4791 (xd_get_connection_references): New function.
b593d6a9
AH
4792 (xd_get_connection_address): Rename from xd_initialize.
4793 Return cached address.
dcbf5805
MA
4794 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
4795 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
4796 level.
4797 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 4798 Return number of refcounts.
dcbf5805
MA
4799 (Fdbus_get_unique_name): Make stronger parameter check.
4800 (Fdbus_message_internal): New defun.
4801 (Fdbus_call_method, Fdbus_call_method_asynchronously)
4802 (Fdbus_method_return_internal, Fdbus_method_error_internal)
4803 (Fdbus_send_signal, Fdbus_register_service)
4804 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
4805 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
4806 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
4807 (Vdbus_compiled_version, Vdbus_runtime_version)
4808 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
4809 (Vdbus_message_type_method_return, Vdbus_message_type_error)
4810 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
4811 (Vdbus_registered_buses, Vdbus_registered_objects_table):
4812 Adapt docstring.
dcbf5805 4813
52828e02
PE
48142012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4815
da05bc4c
PE
4816 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
4817 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
4818 Do not assume ptrdiff_t is the same width as 'int'.
4819
52828e02
PE
4820 * alloc.c: Handle unusual debugging option combinations.
4821 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
4822 since the two debugging options are incompatible.
4823 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
4824 is defined.
4825 (mem_init, mem_insert, mem_insert_fixup):
4826 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
4827 (NEED_MEM_INSERT): Remove; no longer needed.
4828
f01769f9
LL
48292012-04-22 Leo Liu <sdl.web@gmail.com>
4830
4831 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
4832
5790543d
PE
48332012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4834
4835 * sysdep.c [__FreeBSD__]: Minor cleanups.
4836 (list_system_processes, system_process_attributes) [__FreeBSD__]:
4837 Use Emacs indenting style more consistently. Avoid some casts.
4838 Use 'double' consistently rather than mixing 'float' and 'double'.
4839
b91b7e4d
EW
48402012-04-21 Eduard Wiebe <usenet@pusto.de>
4841
b593d6a9
AH
4842 * sysdep.c (list_system_processes, system_process_attributes):
4843 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 4844
6114eb15
AS
48452012-04-21 Andreas Schwab <schwab@linux-m68k.org>
4846
4847 * lisp.mk (lisp): Update.
4848
2f38dff7
PE
48492012-04-20 Paul Eggert <eggert@cs.ucla.edu>
4850
4851 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
4852 It is never used otherwise.
4853
4ae29f89
SM
48542012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
4855
4856 * print.c (print_preprocess): Only check print_depth if print-circle
4857 is nil.
4858 (print_object): Check for cycles even when print-circle is nil and
4859 print-gensym is t, but only check print_depth if print-circle is nil.
4860
f30d612a
CY
48612012-04-20 Chong Yidong <cyd@gnu.org>
4862
4863 * process.c (wait_reading_process_output): If EIO occurs on a pty,
4864 set the status to "failed" and ensure that sentinel is run.
4865
c07a4c0b 48662012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
4867
4868 * process.c (Fset_process_inherit_coding_system_flag)
4869 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 4870 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 4871
c07a4c0b 48722012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
4873
4874 * xdisp.c (string_buffer_position_lim): Limit starting position to
4875 BEGV.
4876 (set_cursor_from_row): If called for a mode-line or header-line
4877 row, return zero immediately.
4878 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
4879 farther than the first row after the header line, if any.
4880 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
4881 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
4882
c07a4c0b 48832012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 4884
4ae29f89
SM
4885 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
4886 (bug#11238).
ad3a2b41 4887
c07a4c0b 48882012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 48892012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
4890
4891 configure: new option --enable-gcc-warnings (Bug#11207)
4892 * Makefile.in (C_WARNINGS_SWITCH): Remove.
4893 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
4894 (ALL_CFLAGS): Use new macros rather than old.
4895 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
4896 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
4897 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
4898 -Wunused-result, -Wunused-variable. This should go away once
4899 the Emacs and Gnulib regex code is merged.
4900 (xmalloc, xrealloc): Now static.
4901
aba027e8
PE
49022012-04-17 Paul Eggert <eggert@cs.ucla.edu>
4903
4904 * dired.c (Fsystem_groups): Remove unused local.
4905
e5a36063
GM
49062012-04-17 Glenn Morris <rgm@gnu.org>
4907
4908 * dired.c (Fsystem_users): Doc fix.
4909
316411f0
DA
49102012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
4911
4912 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
4913 (syms_of_dired): Add them.
4914
9426aba4
PE
49152012-04-16 Paul Eggert <eggert@cs.ucla.edu>
4916
b62a57be
PE
4917 Fix minor alloc.c problems found by static checking.
4918 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
4919 New extern decls, to avoid calling undeclared functions.
4920 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
4921 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
4922 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
4923 (NEED_MEM_INSERT): New macro.
4924 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 4925 Remove one incorrect comment and fix another.
b62a57be 4926
3539f31f
PE
4927 Fix minor ralloc.c problems found by static checking.
4928 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4929 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
4930 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
4931 (r_alloc_sbrk): Now static.
4932
a041960a
PE
4933 Improve ralloc.c interface checking.
4934 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4935 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
4936 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
4937 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
4938 [REL_ALLOC]: ... to here, to check interface.
4939 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
4940 Remove decls. This fixes an "It stinks!".
4941
9426aba4
PE
4942 * alloc.c (which_symbols): Fix alignment issue / type clash.
4943
d55c12ed
AS
49442012-04-15 Andreas Schwab <schwab@linux-m68k.org>
4945
4946 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
4947 (struct Lisp_Misc_Any): Likewise.
4948 (struct Lisp_Free): Likewise.
4949 * alloc.c (union aligned_Lisp_Symbol): Define.
4950 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
4951 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
4952 (union aligned_Lisp_Misc): Define.
4953 (MARKER_BLOCK_SIZE, struct marker_block): Use union
4954 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 4955 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 4956
b948ce8b
PE
49572012-04-14 Paul Eggert <eggert@cs.ucla.edu>
4958
4959 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
4960 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
4961 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
4962 * s/netbsd.h, s/sol2-6.h:
4963 Remove definition of GC_MARK_STACK, since the default now works.
4964 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
4965 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
4966 no longer the default.
4967 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
4968
35dc09a1 49692012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 4970
35dc09a1
GM
4971 * lread.c (lisp_file_lexically_bound_p):
4972 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 4973
35dc09a1
GM
49742012-04-14 Eli Zaretskii <eliz@gnu.org>
4975
4976 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
4977 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
4978
49792012-04-14 Jan Djärv <jan.h.d@swipnet.se>
4980
4981 * nsterm.m (constrainFrameRect): Always constrain when there is only
4982 one screen (Bug#10962).
4983
bcd86815
KB
49842012-04-13 Ken Brown <kbrown@cornell.edu>
4985
4986 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
4987
c25df26e
RT
49882012-04-13 Reuben Thomas <rrt@sc3d.org>
4989
4990 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
4991
0fc59f1e
DC
49922012-04-11 Daniel Colascione <dancol@dancol.org>
4993
4994 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
4995 against is gone. It's better to use vfork now so that when Cygwin
4996 gains a new, working vfork, we use it automatically (bug#10398).
4997
de8c03dc
SM
49982012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4999
5000 * window.c (save_window_save): Obey window-point-insertion-type.
5001
2f097256
GM
50022012-04-11 Glenn Morris <rgm@gnu.org>
5003
5004 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
5005
453b951e
SM
50062012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
5007
5008 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
5009
75f1671a 50102012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
5011
5012 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
5013 (force_quit_count): New var.
5014 (handle_interrupt): Use it.
5015
2a8ce227
JB
50162012-04-10 Juanma Barranquero <lekktu@gmail.com>
5017
5018 * w32.c (w32_delayed_load): Record the full path of the library
5019 being loaded (bug#10424).
5020
935396c0
GM
50212012-04-09 Glenn Morris <rgm@gnu.org>
5022
05920a43
GM
5023 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
5024 not just in the obarray, before snarfing them. (Bug#11036)
5025
935396c0
GM
5026 * Makefile.in ($(leimdir)/leim-list.el):
5027 Pass EMACS rather than BUILT_EMACS.
5028
a18ecafa
TZ
50292012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
5030
5031 * process.c (make_process):
5032 * process.h: Add integer `gnutls_handshakes_tried' member to
5033 process struct.
5034
6bbef4e5
JC
5035 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
5036 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
5037
5038 * gnutls.c (gnutls_log_function2i): Convenience log function.
5039 (emacs_gnutls_read): Use new log functions,
5040 `gnutls_handshakes_tried' process member, and
5041 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
5042 attempts per process (connection).
5043
b4d3bc10
CY
50442012-04-09 Chong Yidong <cyd@gnu.org>
5045
5046 * eval.c (Fuser_variable_p, user_variable_p_eh)
5047 (lisp_indirect_variable): Functions deleted.
5048 (Fdefvar): Caller changed.
5049
5050 * callint.c (Finteractive, Fcall_interactively):
5051 * minibuf.c (Fread_variable): Callers changed.
5052
70f4d973
EZ
50532012-04-09 Eli Zaretskii <eliz@gnu.org>
5054
5055 * xdisp.c (set_cursor_from_row): If the display string appears in
5056 the buffer at position that is closer to point than the position
5057 after the display string, display the cursor on the first glyph of
5058 the display string. Fixes cursor display when a 'display' text
5059 property immediately follows invisible text. (Bug#11094)
5060
cb3c2e3e
PE
50612012-04-09 Paul Eggert <eggert@cs.ucla.edu>
5062
5063 composite.c: use 'double' consistently
5064 * composite.c (get_composition_id): Use 'double' consistently
5065 instead of converting 'float' to 'double' and vice versa; this is
5066 easier to understand and avoids a GCC warning.
5067
fd06db5d
GM
50682012-04-09 Glenn Morris <rgm@gnu.org>
5069
50fe702a
GM
5070 * Makefile.in: Generate leim-list with bootstrap-emacs, in
5071 preparation for dumping it with emacs. (Bug#4789)
5072 (leimdir): New variable.
5073 ($(leimdir)/leim-list.el): New rule.
5074 (emacs$(EXEEXT)): Depend on leim-list.el.
5075
fd06db5d
GM
5076 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
5077 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
5078 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
5079
55c131ee
AS
50802012-04-08 Andreas Schwab <schwab@linux-m68k.org>
5081
5082 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
5083 proper alignment.
5084
9209588f
JB
50852012-04-07 Juanma Barranquero <lekktu@gmail.com>
5086
5087 * xml.c (init_libxml2_functions) [WINDOWSNT]:
5088 Remove unused local variable.
5089
e3fb2efb
PE
50902012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5091
5092 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
5093 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
5094 (mark_memory): Mark Lisp_Objects only if pointers might hide in
5095 objects, as mark_maybe_pointer will catch them otherwise.
5096 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
5097 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
5098
b5385551
PE
50992012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5100
5101 Fix typo that broke non-Windows builds.
5102 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
5103
9078ead6
EZ
51042012-04-07 Eli Zaretskii <eliz@gnu.org>
5105
5106 Support building on MS-Windows with libxml2.
5107
5108 * makefile.w32-in (OBJ2): Add xml.$(O).
5109 (GLOBAL_SOURCES): Add xml.c.
5110 ($(BLD)/xml.$(O)): New dependency list.
5111
5112 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
5113 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
5114 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
5115 [!WINDOWSNT]: New macros.
5116 (init_libxml2_functions, libxml2_loaded_p): New functions.
5117 (parse_region): Call fn_xmlCheckVersion instead of using the macro
5118 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
5119 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
5120 Calls xmlCleanupParser only if libxml2 was loaded (or statically
5121 linked in).
6bbef4e5
JC
5122 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
5123 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
5124 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
5125
5126 * emacs.c: Don't include libxml/parser.h.
5127 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
5128 xmlCleanupParser directly.
5129
5130 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
5131
3811fdf3
EZ
51322012-04-07 Eli Zaretskii <eliz@gnu.org>
5133
5134 * indent.c (Fvertical_motion): If there is a display string at
5135 point, use it.vpos to compute how many lines to backtrack after
5136 move_it_to point. (Bug#11133)
5137
2f8e16b2
EZ
51382012-04-06 Eli Zaretskii <eliz@gnu.org>
5139
5140 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
5141 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
5142 about subtle differences between FETCH_CHAR* and STRING_CHAR*
5143 macros related to unification of CJK characters. For the details,
5144 see the discussion following the message here:
5145 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
5146
3d439cd1
CY
51472012-04-04 Chong Yidong <cyd@gnu.org>
5148
5149 * keyboard.c (Vdelayed_warnings_list): Doc fix.
5150
8bc53d00
EZ
51512012-04-01 Eli Zaretskii <eliz@gnu.org>
5152
5153 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
5154 instead of alloca. (Bug#11138)
5155
3b0512a3
AS
51562012-04-01 Andreas Schwab <schwab@linux-m68k.org>
5157
5158 * w32menu.c (is_simple_dialog): Properly check lisp types.
5159 (Bug#11141)
5160
8427ddd2
EZ
51612012-03-31 Eli Zaretskii <eliz@gnu.org>
5162
979022ef
EZ
5163 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
5164 position we get to after a call to move_it_to fails the
5165 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
5166 only if we wind up in a string from display property. (Bug#11063)
5167
a6b1c7cc
EZ
5168 * window.c (Fdelete_other_windows_internal): Invalidate the row
5169 and column information about mouse highlight, so that redisplay
5170 restores it after reallocating the glyph matrices. (Bug#7464)
5171
8427ddd2
EZ
5172 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
5173 string comes from a `display' text property, use the buffer
5174 position of that property as if we actually saw that position in
5175 the row's glyphs.
697ba24b
EZ
5176 (move_it_by_lines): Remove the assertion that
5177 "it->current_x == 0 && it->hpos == 0" which can be legitimately
5178 violated when there's a before-string at the beginning of a line.
5179 (Bug#11063)
8427ddd2 5180
65a0a738
EZ
51812012-03-30 Eli Zaretskii <eliz@gnu.org>
5182
5183 * xdisp.c (append_space_for_newline): If the default face was
5184 remapped, use the remapped face for the appended newline.
5185 (extend_face_to_end_of_line): Use the remapped default face for
5186 extending the face to the end of the line.
5187 (display_line): Call extend_face_to_end_of_line when the default
5188 face was remapped. (Bug#11068)
5189
581355cc
EZ
51902012-03-29 Eli Zaretskii <eliz@gnu.org>
5191
5192 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
5193
e8fc049f
SM
51942012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5195
5196 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
5197
4fb9a543
GM
51982012-03-27 Glenn Morris <rgm@gnu.org>
5199
5200 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
5201 Doc fixes.
5202
679910f1
KH
52032012-03-26 Kenichi Handa <handa@m17n.org>
5204
5205 * dispextern.h (struct glyph): Fix previous change. Change the
5206 bit length of glyphless.ch to 25 (Bug#11082).
5207
90d49b7f
CY
52082012-03-26 Chong Yidong <cyd@gnu.org>
5209
5210 * keyboard.c (Vselection_inhibit_update_commands): New variable.
5211 (command_loop_1): Use it; inhibit selection update for
5212 handle-select-window too (Bug#8996).
5213
f514f6f0
FP
52142012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
5215
e8fc049f 5216 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 5217
bf43fa51
KH
52182012-03-25 Kenichi Handa <handa@m17n.org>
5219
5220 * dispextern.h (struct glyph): Change the bit length of
5221 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
5222
8a0c01dd
EZ
52232012-03-24 Eli Zaretskii <eliz@gnu.org>
5224
5225 * s/ms-w32.h (tzname): Include time.h before redirecting to
5226 _tzname. Fixes the MSVC build. (Bug#9960)
5227
7d1c3a76
AS
52282012-03-24 Andreas Schwab <schwab@linux-m68k.org>
5229
8ed79523
AS
5230 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
5231 characters.
5232
7d1c3a76
AS
5233 * xterm.c (XTread_socket): Only modify handling_signal if
5234 !SYNC_INPUT. (Bug#11080)
5235
e99a9b8b
EZ
52362012-03-23 Eli Zaretskii <eliz@gnu.org>
5237
5238 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
5239 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
5240 when fetching a multibyte character consumes more bytes than
5241 CHAR_BYTES returns, due to unification of CJK characters in
5242 string_char. (Bug#11073)
5243
5063c0e1
TN
52442012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
5245
5246 * process.c (wait_reading_process_output): Handle pty disconnect
5247 by refraining from sending oneself a SIGCHLD (bug#10933).
5248
9f851fbd
CY
52492012-03-22 Chong Yidong <cyd@gnu.org>
5250
5251 * dispextern.h (struct it): New member string_from_prefix_prop_p.
5252
5063c0e1 5253 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
5254 Mark string as coming from a prefix property.
5255 (handle_face_prop): Use default face for prefix strings (Bug#4281).
5256 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
5257
fb5b8aca
CY
52582012-03-21 Chong Yidong <cyd@gnu.org>
5259
5260 * xfaces.c (Vface_remapping_alist): Doc fix.
5261
62356a1b
EZ
52622012-03-20 Eli Zaretskii <eliz@gnu.org>
5263
5264 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
5265 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
5266 Doc fixes.
62356a1b 5267
025de85b
CY
52682012-03-20 Chong Yidong <cyd@gnu.org>
5269
5270 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
5271 to reflect default non-nil value of redisplay-dont-pause.
5272
4827f94e
KH
52732012-03-19 Kenichi Handa <handa@m17n.org>
5274
5275 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
5276 it fit in a valid range (Bug#11003).
5277
e50a24a2
EZ
52782012-03-18 Eli Zaretskii <eliz@gnu.org>
5279
5280 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
5281 that is not from display property, accept the row as a "cursor
5282 row" if one of the string's character has a non-nil `cursor'
5283 property. Fixes cursor positioning when there are newlines in
5284 overlay strings, e.g. in icomplete.el. (Bug#11035)
5285
9af5ed87
PE
52862012-03-12 Paul Eggert <eggert@cs.ucla.edu>
5287
5288 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
5289
d1f55f16
CY
52902012-03-12 Chong Yidong <cyd@gnu.org>
5291
5292 * eval.c (inhibit_lisp_code): Rename from
5293 inhibit_window_configuration_change_hook; move from window.c.
5294
5295 * xfns.c (unwind_create_frame_1, Fx_create_frame):
5296 * window.c (run_window_configuration_change_hook)
5297 (syms_of_window): Callers changed.
5298
66c5eebd
CY
52992012-03-11 Chong Yidong <cyd@gnu.org>
5300
413df973
CY
5301 * keymap.c (Fkey_description): Doc fix (Bug#9700).
5302
66c5eebd
CY
5303 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
5304
1de11f56
CY
53052012-03-10 Chong Yidong <cyd@gnu.org>
5306
5307 * frame.c (other_visible_frames): Don't assume the selected frame
5308 is visible (Bug#10955).
5309
cae07000
SM
53102012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
5311
5312 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
5313
89c94350
JD
53142012-03-08 Jan Djärv <jan.h.d@swipnet.se>
5315
5316 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
5317 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
5318 zero (Bug#10954).
5319
999dd333
GM
53202012-03-03 Glenn Morris <rgm@gnu.org>
5321
01a6dcc8 5322 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 5323
de0100f2
EZ
53242012-03-02 Eli Zaretskii <eliz@gnu.org>
5325
5326 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
5327 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
5328 (redisplay_window, next_element_from_string): Fix typos in
5329 comments.
3e441275
EZ
5330 (redisplay_window): Pass to move_it_vertically the margin in
5331 pixels, not in screen lines.
de0100f2 5332
96a72ee9
GM
53332012-03-02 Glenn Morris <rgm@gnu.org>
5334
5335 * buffer.c (buffer-list-update-hook): Doc fix.
5336
312508d7
EZ
53372012-02-29 Eli Zaretskii <eliz@gnu.org>
5338
5339 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
5340 push_it before setting up the iterator for the first overlay
5341 string, even if we have an empty string loaded.
5342 (next_overlay_string): If there's an empty string on the iterator
5343 stack, pop the stack. (Bug#10903)
5344
27f3c637
PE
53452012-02-25 Paul Eggert <eggert@cs.ucla.edu>
5346
5347 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
5348 Suggested by Stefan Monnier in
5349 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
5350 * alloc.c (widen_to_Lisp_Object): New static function.
5351 (mark_memory): Also mark Lisp_Objects by fetching pointer words
5352 and widening them to Lisp_Objects. This would work even if
5353 USE_LSB_TAG is defined and wide integers are used, which might
5354 happen in a future version of Emacs.
5355
3c9dfce6
CY
53562012-02-25 Chong Yidong <cyd@gnu.org>
5357
fa74b241
CY
5358 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
5359 Doc fix.
5360
3c9dfce6
CY
5361 * xselect.c (Fx_selection_exists_p): Doc fix.
5362 (x_clipboard_manager_save_all): Print an informative message
5363 before saving to clipboard manager.
5364
9486df08
CY
53652012-02-24 Chong Yidong <cyd@gnu.org>
5366
5367 * keyboard.c (process_special_events): Handle all X selection
5368 requests in kbd_buffer, not just the next one (Bug#8869).
5369
f01d3321
CY
53702012-02-23 Chong Yidong <cyd@gnu.org>
5371
5372 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
5373 call when setting menu-bar-lines and tool-bar-lines parameters.
5374 (unwind_create_frame_1): New helper function.
5375
5376 * window.c (inhibit_window_configuration_change_hook): New var.
5377 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 5378 (syms_of_window): Initialize it.
f01d3321 5379
86b847b6
CY
53802012-02-22 Chong Yidong <cyd@gnu.org>
5381
5382 * xterm.c (x_draw_image_relief): Add missing type check for
5383 Vtool_bar_button_margin (Bug#10743).
5384
a59225b1
CY
53852012-02-21 Chong Yidong <cyd@gnu.org>
5386
5387 * fileio.c (Vfile_name_handler_alist): Doc fix.
5388
5389 * buffer.c (Fget_file_buffer): Protect against invalid file
5390 handler return value.
5391
310f5bd4
PE
53922012-02-20 Paul Eggert <eggert@cs.ucla.edu>
5393
cb3a28cc
PE
5394 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
5395 when computing $valmask.
5396
310f5bd4
PE
5397 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
5398 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
5399 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
5400 It's useless in that case, and it can cause problems on hosts
5401 that allocate halves of EMACS_INT values separately.
5402 Reported by Dan Horák. Diagnosed by Andreas Schwab in
5403 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
5404 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
5405 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
5406 it avoids undefined behavior on hosts where shifting right by more
5407 than the word width has undefined behavior.
5408
2375c96a
CY
54092012-02-19 Chong Yidong <cyd@gnu.org>
5410
5411 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
5412 (Funhandled_file_name_directory, Ffile_name_as_directory)
5413 (Fdirectory_file_name, Fexpand_file_name)
5414 (Fsubstitute_in_file_name): Protect against invalid file handler
5415 return values (Bug#10845).
5416
3eb49e71
EZ
54172012-02-18 Eli Zaretskii <eliz@gnu.org>
5418
5419 * .gdbinit (pitx): Fix incorrect references to fields of the
5420 iterator stack.
5421
7b926f3f
CY
54222012-02-17 Chong Yidong <cyd@gnu.org>
5423
5424 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
5425
11273115
PE
54262012-02-15 Paul Eggert <eggert@cs.ucla.edu>
5427
5428 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
5429 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
5430
c3a70e2b
CY
54312012-02-15 Chong Yidong <cyd@gnu.org>
5432
5433 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
5434 marked as special. Also, starting docstrings with * is obsolete.
5435
0ca43699
AS
54362012-02-13 Andreas Schwab <schwab@linux-m68k.org>
5437
5438 * gnutls.c (emacs_gnutls_write): Fix last change.
5439
2e8f3c56
LI
54402012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
5441
5442 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
5443 send_process.
5444
af70074f
SM
54452012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
5446
5447 * keymap.c (Fsingle_key_description): Handle char ranges.
5448
95986d52
CY
54492012-02-12 Chong Yidong <cyd@gnu.org>
5450
afd83bd1
CY
5451 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
5452 as that creates a dangerous corner case.
5453
95986d52
CY
5454 * window.c (Fdelete_window_internal): Invalidate the mouse
5455 highlight (Bug#9904).
5456
bd7da63e
GM
54572012-02-12 Glenn Morris <rgm@gnu.org>
5458
5459 * xselect.c (Fx_own_selection_internal)
5460 (Fx_get_selection_internal, Fx_disown_selection_internal)
5461 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
5462 * nsselect.m (Fx_own_selection_internal)
5463 (Fx_disown_selection_internal, Fx_selection_exists_p)
5464 (Fx_selection_owner_p, Fx_get_selection_internal):
5465 Sync docs and argument specs with the xselect.c versions.
5466
77abcbc2
LI
54672012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
5468
5469 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
5470
90b671e2
EZ
54712012-02-11 Eli Zaretskii <eliz@gnu.org>
5472
1c0ca0b7
EZ
5473 * w32select.c (Fx_selection_exists_p): Sync doc string and
5474 argument list with xselect.c. (Bug#10783)
5475
5476 * w16select.c (Fx_selection_exists_p): Sync doc string and
5477 argument list with xselect.c. (Bug#10783)
90b671e2 5478
49241268
GM
54792012-02-10 Glenn Morris <rgm@gnu.org>
5480
5481 * fns.c (Fsecure_hash): Doc fix.
5482
f998bbe7 54832012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
5484
5485 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
5486
0992bd9c
CY
54872012-02-07 Chong Yidong <cyd@gnu.org>
5488
5489 * buffer.c (Fbuffer_local_variables)
5490 (buffer_lisp_local_variables): Handle unbound vars correctly;
5491 don't let Qunbound leak into Lisp.
5492
af008560
GM
54932012-02-07 Glenn Morris <rgm@gnu.org>
5494
dd605cc4
GM
5495 * image.c (Fimagemagick_types): Doc fix.
5496
af008560
GM
5497 * image.c (imagemagick-render-type): Change it from a lisp object
5498 to an integer. Move the doc here from the lisp manual.
5499 Treat all values not equal to 0 the same.
5500
1449fa1d
CY
55012012-02-06 Chong Yidong <cyd@gnu.org>
5502
5503 * doc.c (store_function_docstring): Avoid applying docstring of
5504 alias to base function (Bug#2603).
5505
3723ec07
AS
55062012-02-04 Andreas Schwab <schwab@linux-m68k.org>
5507
5508 * .gdbinit (pp1, pv1): Remove redundant defines.
5509 (pr): Use pp.
5510
79c1cc1e
CY
55112012-02-04 Chong Yidong <cyd@gnu.org>
5512
5513 * nsterm.m: Declare a global (Bug#10694).
5514
d7f29f8e
EZ
55152012-02-04 Eli Zaretskii <eliz@gnu.org>
5516
cae07000
SM
5517 * w32.c (get_emacs_configuration_options):
5518 Include --enable-checking, if specified, in the return value.
d7f29f8e 5519
3b95a6f9
MR
55202012-02-04 Martin Rudalics <rudalics@gmx.at>
5521
5522 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
5523 after rounding frame sizes. (Bug#9723)
5524
d6fa96a6
EZ
55252012-02-04 Eli Zaretskii <eliz@gnu.org>
5526
5527 * keyboard.c (adjust_point_for_property): Don't position point
5528 before BEGV. (Bug#10696)
5529
df0b2940
PE
55302012-02-03 Paul Eggert <eggert@cs.ucla.edu>
5531
5532 Handle overflow when computing char display width (Bug#9496).
5533 * character.c (char_width): Return EMACS_INT, not int.
5534 (char_width, c_string_width): Check for overflow when
5535 computing the width; this is possible now that individual
5536 characters can have unbounded width. Problem introduced
5537 by merge from Emacs 23 on 2012-01-19.
5538
6bee44d6
MA
55392012-02-02 Michael Albinus <michael.albinus@gmx.de>
5540
5541 * dbusbind.c (Fdbus_register_method): Mention the return value
5542 :ignore in the docstring.
5543
44f92739
GM
55442012-02-02 Glenn Morris <rgm@gnu.org>
5545
1b9f60cc
GM
5546 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
5547
44f92739
GM
5548 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5549 Unconditionally set to t. (Bug#10673)
5550 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5551 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
5552 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
5553
c5d3843c
KH
55542012-02-02 Kenichi Handa <handa@m17n.org>
5555
5556 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
5557 0, do not call append_composite_glyph.
5558
159462d4 55592012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
5560
5561 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
5562 NULL (Bug#6988).
5563 (x_produce_glyphs): If the component of a composition is a null
5564 string, set it->pixel_width to 1 to avoid zero-width glyph.
5565
78cef877
EZ
55662012-02-01 Eli Zaretskii <eliz@gnu.org>
5567
5568 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
5569 first 2 arguments are identical. This makes inserting large
5570 output from a subprocess an order of magnitude faster on
5571 MS-Windows, where all sbrk'ed memory is always contiguous.
5572
97897668
GM
55732012-01-31 Glenn Morris <rgm@gnu.org>
5574
5575 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 5576 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
5577 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
5578
31fd3586
GM
55792012-01-29 Glenn Morris <rgm@gnu.org>
5580
5581 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
5582
0e24a8b2
CY
55832012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
5584
5585 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
5586
cc0adcb0
CY
55872012-01-28 Chong Yidong <cyd@gnu.org>
5588
5589 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
5590
acc28cb9
CY
55912012-01-26 Chong Yidong <cyd@gnu.org>
5592
9c69cfb7
CY
5593 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
5594
acc28cb9
CY
5595 * search.c (Fsearch_forward, Fsearch_backward): Document negative
5596 repeat counts (Bug#10507).
5597
48da7392
GM
55982012-01-26 Glenn Morris <rgm@gnu.org>
5599
5600 * lread.c (syms_of_lread): Doc fix.
5601
14af5f7f
CY
56022012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
5603
5604 * coding.c (encode_designation_at_bol): Change return value to
5605 EMACS_INT.
5606
0b21c100
CY
56072012-01-25 Chong Yidong <cyd@gnu.org>
5608
5609 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
5610
3c2907f7
CY
56112012-01-21 Chong Yidong <cyd@gnu.org>
5612
5613 * floatfns.c (Fcopysign): Make the second argument non-optional,
5614 since nil is not allowed anyway.
5615
959ad23f
AS
56162012-01-21 Andreas Schwab <schwab@linux-m68k.org>
5617
5618 * process.c (read_process_output): Use p instead of XPROCESS (proc).
5619 (send_process): Likewise.
5620
34a02f46
MR
56212012-01-19 Martin Rudalics <rudalics@gmx.at>
5622
5623 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
5624 (Vwindow_persistent_parameters): Do not use Qstate.
5625 Rewrite doc-strings.
34a02f46 5626
1259009a 56272012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
5628
5629 * character.c (char_width): New function.
70d4fdf6
GM
5630 (Fchar_width, c_string_width, lisp_string_width):
5631 Use char_width (Bug#9496).
25ed9e61 5632
6a6ee00d
MR
56332012-01-16 Martin Rudalics <rudalics@gmx.at>
5634
5635 * window.c (Vwindow_persistent_parameters): New variable.
5636 (Fset_window_configuration, save_window_save): Handle persistent
5637 window parameters.
5638
c85efaf7
EZ
56392012-01-14 Eli Zaretskii <eliz@gnu.org>
5640
5641 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
5642 thrashing the stack of the thread. (Bug#9087)
5643
5944709e
PE
56442012-01-12 Paul Eggert <eggert@cs.ucla.edu>
5645
5646 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
5647
e71f5d99
EZ
56482012-01-11 Eli Zaretskii <eliz@gnu.org>
5649
5650 * xdisp.c (rows_from_pos_range): Handle the case where the
5651 highlight ends on a newline. (Bug#10464)
5652 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
5653 he end column for display of highlight that ends on a newline
5654 before a R2L line.
5655
ce316182
GM
56562012-01-11 Glenn Morris <rgm@gnu.org>
5657
5658 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
5659 from load-path also when installation-directory is nil. (Bug#10208)
5660
5b43da69
GM
56612012-01-10 Glenn Morris <rgm@gnu.org>
5662
74cc8ff9
GM
5663 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
5664
7d8d6e4e
GM
5665 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
5666 Update template values to be closer to their typical values these days.
5b43da69 5667
a0db8d43
EZ
56682012-01-09 Eli Zaretskii <eliz@gnu.org>
5669
5670 * xdisp.c (rows_from_pos_range): Accept additional argument
5671 DISP_STRING, and accept any glyph in a row whose object is that
5672 string as eligible for mouse highlight. Fixes mouse highlight of
5673 display strings from overlays. (Bug#10464)
5674
9a0115ab 56752012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 5676
b9110d6a 5677 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
5678 * fileio.c (auto_saving_dir_umask): New static var.
5679 (Fmake_directory_internal): Use it.
5680 (do_auto_save_make_dir): Set it, instead of invoking chmod after
5681 creating the directory. The old code temporarily assigns
5682 too-generous permissions to the directory.
5683 (do_auto_save_eh): Clear it.
b9110d6a 5684 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
5685 that the var is always cleared.
5686
6c1bd3f3
EZ
56872012-01-07 Eli Zaretskii <eliz@gnu.org>
5688
5689 * search.c (scan_buffer): Pass character positions to
5690 know_region_cache, not byte positions. (Bug#6540)
5691
069d2b50
L
56922012-01-07 LynX <_LynX@bk.ru> (tiny change)
5693
5694 * w32.c (sys_rename): Report EXDEV when rename of a directory
5695 fails because the target is on another logical disk. (Bug#10284)
5696
75bf0d33
DB
56972012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
5698
5699 * xterm.c (x_embed_request_focus): New function.
5700
5701 * xterm.h: Add prototype.
5702
5703 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
5704
1c6e5a32
GM
57052012-01-05 Glenn Morris <rgm@gnu.org>
5706
5707 * emacs.c (emacs_copyright): Update short copyright year to 2012.
5708
651e947e
EZ
57092012-01-01 Eli Zaretskii <eliz@gnu.org>
5710
5711 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
5712 Load gnutls_transport_set_lowat only if GnuTLS version is below
5713 2.11.1.
5714 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
5715 GnuTLS versions below 2.11.1.
5716
3778cdd8
AL
57172011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
5718
5719 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
5720 to the doc string advising against its use for altering the way
5721 windows are scrolled.
5722
0e5317f7
KH
57232011-12-28 Kenichi Handa <handa@m17n.org>
5724
5725 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
5726 coding-system ASCII compatible only when it does not produce BOM
5727 on encoding (Bug#10383).
5728
93d5ca1f
JD
57292011-12-26 Jan Djärv <jan.h.d@swipnet.se>
5730
5731 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
5732 can scroll.
5733 (create_and_show_popup_menu): Always use menu_position_func for
5734 Gtk3 (Bug#10361).
5735
ca22b785
AS
57362011-12-24 Andreas Schwab <schwab@linux-m68k.org>
5737
5738 * callint.c (Fcall_interactively): Don't truncate prompt string.
5739
d048e1e6
EZ
57402011-12-23 Eli Zaretskii <eliz@gnu.org>
5741
5742 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
5743 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 5744 resumed from there (after widening). (Bug#10360)
d048e1e6 5745
5ccaba1f
JD
57462011-12-22 Jan Djärv <jan.h.d@swipnet.se>
5747
5748 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
5749
204ee57f
JD
57502011-12-21 Jan Djärv <jan.h.d@swipnet.se>
5751
b81d40f0
JB
5752 * nsterm.m (x_free_frame_resources):
5753 Release f->output_data.ns->miniimage.
204ee57f
JD
5754 (ns_index_color): Fix indentation. Do not retain
5755 color_table->colors[i].
5756
5757 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
5758 before returning.
5759
5760 * nsfns.m (x_set_background_color): Assign return value from
5761 ns_index_color to face-background instead of NSColor*.
5762 (ns_implicitly_set_icon_type): Fix indentation.
5763 Change assignment in for loop to comparison.
5764
5765 * emacs.c (ns_pool): New variable.
5766 (main): Assign ns_pool.
5767 (Fkill_emacs): Call ns_release_autorelease_pool.
5768
5769 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
5770 autorelease fdesc, release fdAttrs and tdict.
5771 (ns_get_covering_families): Release charset.
5772 (ns_findfonts): Release NSFontDescriptor created with new.
5773 (ns_uni_to_glyphs): Fix indentation.
5774 (setString): Release attrStr before assigning new value.
5775
c803b2b7
JD
57762011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5777
678f4426
JD
5778 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
5779 and NS_IMPL_COCOA.
5780 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
5781 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
5782
cd394be1 57832011-12-18 David Reitter <reitter@cmu.edu>
678f4426 5784
5fecd5fc
JD
5785 * nsterm.m (ns_term_init): Subscribe for notifications
5786 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
5787 to method trackingNotification in EmacsMenu.
5788
5789 * nsmenu.m (trackingMenu): New variable.
3771cb17 5790 (trackingNotification): New method (from Aquamacs).
5fecd5fc 5791 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 5792 from Aquamacs (Bug#7030).
678f4426
JD
5793
57942011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 5795
c803b2b7
JD
5796 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
5797 (symbol_to_nsstring): Fix indentation.
5798 (ns_symbol_to_pb): New function.
cae07000
SM
5799 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
5800 (Fns_rotate_cut_buffers_internal): Remove.
5801 (Fns_store_selection_internal): Rename from
c803b2b7
JD
5802 Fns_store_cut_buffer_internal.
5803 (ns_get_foreign_selection, Fx_own_selection_internal)
5804 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
5805 (Fns_get_selection_internal, Fns_store_selection_internal):
5806 Use ns_symbol_to_pb and check if return value is nil.
5807 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
5808 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
5809 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
5810 renamed to Sns_store_selection_internal.
5811 (ns_handle_selection_request): Move code to Fx_own_selection_internal
5812 and remove this function.
5813 (ns_handle_selection_clear): Remove, never used.
5814 (Fx_own_selection_internal): Move code from ns_handle_selection_request
5815 here.
5816
e1b01a3a
KB
58172011-12-17 Ken Brown <kbrown@cornell.edu>
5818
5819 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
5820 GID is unknown (Bug#10257).
5821
2adb6e85
PE
58222011-12-17 Paul Eggert <eggert@cs.ucla.edu>
5823
5824 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
5825 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
5826 which caused a build failure on GNU/Linux IA-64. This problem was
5827 introduced by my 2011-10-07 patch.
5828
d1d7b339
JL
58292011-12-15 Juri Linkov <juri@jurta.org>
5830
5831 * image.c (imagemagick_error): New function. (Bug#10112)
5832 (imagemagick_load_image): Comment out `MagickSetResolution' call.
5833 Use `imagemagick_error' where ImageMagick functions return
5834 `MagickFalse'.
5835 (Fimagemagick_types): Add `Fnreverse' to return the list in the
5836 proper order.
5837
100d5755
KH
58382011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5839
5840 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
5841 fill background (Bug#8992).
5842
454592a6
MR
58432011-12-13 Martin Rudalics <rudalics@gmx.at>
5844
5845 * window.c (Vwindow_combination_resize)
5846 (Vwindow_combination_limit): Use t instead of non-nil in
5847 doc-strings.
61d4b438
MR
5848 (Vrecenter_redisplay): Add first sentence of doc-string on
5849 separate line.
53524d93 5850 (Frecenter): Fix doc-string typo.
454592a6 5851
3633e3aa
KH
58522011-12-11 Kenichi Handa <handa@m17n.org>
5853
5854 * coding.c (Funencodable_char_position): Pay attention to the
5855 buffer text relocation (Bug#9389).
5856
7b9d523a 58572011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 5858
7b9d523a
JD
5859 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
5860 gtk_init (Bug#10100).
5861
b73189c6
EZ
58622011-12-10 Eli Zaretskii <eliz@gnu.org>
5863
5864 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
5865 IT->string is nil. (Bug#10263)
5866
f7dfe5d6
JD
58672011-12-10 Jan Djärv <jan.h.d@swipnet.se>
5868
83faebb4
JD
5869 * nsterm.h (x_free_frame_resources): Declare.
5870
f7dfe5d6
JD
5871 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
5872 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
5873
5874 * nsterm.h (ns_get_defaults_value): Declare.
5875
5876 * nsterm.m (ns_default): Call ns_get_defaults_value.
5877
7cd4e72c
EZ
58782011-12-09 Eli Zaretskii <eliz@gnu.org>
5879
5880 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
5881 (Bug#10170)
5882
b34d7317
YM
58832011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5884
5885 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
5886 that where the value of an _OBJC_* symbol points to is in the .bss
5887 section (Bug#10240).
5888
76470ad1
KH
58892011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5890
5891 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 5892 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 5893
745fff94
KH
58942011-12-08 Kenichi Handa <handa@m17n.org>
5895
5896 * ftfont.c (get_adstyle_property): Fix previous change
5897 (Bug#10233).
5898
6e44397c
JB
58992011-12-07 Juanma Barranquero <lekktu@gmail.com>
5900
5901 * w32.c (init_environment): If no_site_lisp, remove site-lisp
5902 dirs from the default value of EMACSLOADPATH (bug#10208).
5903
7efa6272
GM
59042011-12-07 Glenn Morris <rgm@gnu.org>
5905
5906 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
5907 installation and source directories as well. (Bug#10208)
5908
f6fc4d87
CY
59092011-12-06 Chong Yidong <cyd@gnu.org>
5910
5911 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
5912
2bf26180
GM
59132011-12-06 Glenn Morris <rgm@gnu.org>
5914
5915 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
5916 as an error, not just -1. (Bug#10217)
5917
3a6ad4f0
CY
59182011-12-05 Chong Yidong <cyd@gnu.org>
5919
5920 * keyboard.c (process_special_events): New function.
5921 (swallow_events, Finput_pending_p): Use it (Bug#10195).
5922
75a3b399
PE
59232011-12-05 Paul Eggert <eggert@cs.ucla.edu>
5924
5925 * coding.c (encode_designation_at_bol): Don't use uninitialized
5926 local variable (Bug#9318).
5927
c3c9e25e
KH
59282011-12-05 Kenichi Handa <handa@m17n.org>
5929
5930 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
5931 return Qnil (Bug#8046, Bug#10193).
5932
5eb05ea3
KH
59332011-12-05 Kenichi Handa <handa@m17n.org>
5934
5935 * coding.c (encode_designation_at_bol): New args charbuf_end and
5936 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
5937 (coding_set_source): Return how many bytes coding->source was
5938 relocated.
5939 (coding_set_destination): Return how many bytes
5940 coding->destination was relocated.
5941 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 5942 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
5943
59442011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5945
5946 * coding.c (CODING_CHAR_CHARSET_P): New macro.
5947 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
5948 macro (Bug#9318).
5949
59502011-12-05 Andreas Schwab <schwab@linux-m68k.org>
5951
5952 The following changes are to fix Bug#9318.
5953
a79703f5 5954 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
5955 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
5956 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 5957 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 5958
7dbda6df
JB
59592011-12-05 Juanma Barranquero <lekktu@gmail.com>
5960
5961 * lisp.h (process_quit_flag): Fix external declaration.
5962
6d5eb5b0
SM
59632011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
5964
5965 Don't macro-inline non-performance-critical code.
5966 * eval.c (process_quit_flag): New function.
5967 * lisp.h (QUIT): Use it.
5968
a0c3fad0
JD
59692011-12-04 Jan Djärv <jan.h.d@swipnet.se>
5970
5971 * nsfns.m (get_geometry_from_preferences): New function.
5972 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
5973
6c07aac2
AS
59742011-12-04 Andreas Schwab <schwab@linux-m68k.org>
5975
5976 * emacs.c (Qkill_emacs): Define.
5977 (syms_of_emacs): Initialize it.
5978 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
5979 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
5980 (quit_throw_to_read_char): Add parameter `from_signal'.
5981 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
5982 * lisp.h (QUIT): Call Fkill_emacs if requested.
5983
c052ead4
JD
59842011-12-03 Jan Djärv <jan.h.d@swipnet.se>
5985
5986 * widget.c (update_wm_hints): Return if wmshell is null.
5987 (widget_update_wm_size_hints): New function.
5988
5989 * widget.h (widget_update_wm_size_hints): Declare.
5990
5991 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
5992 widget_update_wm_size_hints (Bug#10104).
5993
9e49252b
EZ
59942011-12-03 Eli Zaretskii <eliz@gnu.org>
5995
5996 * xdisp.c (handle_invisible_prop): If the invisible text ends just
5997 before a newline, prepare the bidi iterator for consuming the
5998 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 5999 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 6000
02b16839
JL
60012011-12-02 Juri Linkov <juri@jurta.org>
6002
6003 * search.c (Fword_search_regexp): New Lisp function created from
6004 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
6005 (Fword_search_backward, Fword_search_forward)
6006 (Fword_search_backward_lax, Fword_search_forward_lax):
6007 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
6008 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
6009
0068070e
SM
60102011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
6011
6012 * fileio.c (Finsert_file_contents): Move after-change-function call
6013 to before the "handled:" label, since all "goto handled" appear in
6014 cases where the *-change-functions have already been properly called
6015 (bug#10117).
6016
3360a3fc
AS
60172011-12-01 Andreas Schwab <schwab@linux-m68k.org>
6018
6019 * keyboard.c (interrupt_signal): Don't call kill-emacs when
6020 waiting for input. (Bug#10169)
6021
73d6c093
EZ
60222011-11-30 Eli Zaretskii <eliz@gnu.org>
6023
6024 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
6025 verifies glyph row's hash code--we have just reallocated the
6026 glyphs, so their contents can be complete garbage. (Bug#10164)
6027
febe6bea
JB
60282011-11-30 Juanma Barranquero <lekktu@gmail.com>
6029
6030 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
6031
801a4313
EZ
60322011-11-30 Eli Zaretskii <eliz@gnu.org>
6033
6034 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
6035 attributes are tested _before_ calling verify_row_hash, to protect
6036 against GCC re-ordering of the tests. (Bug#10164)
6037
2b56b87e
JD
60382011-11-29 Jan Djärv <jan.h.d@swipnet.se>
6039
6040 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
6041
6042 * xterm.c (handle_one_xevent): Only set async_visible and friends
6043 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 6044 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
6045 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
6046
dbf31225
PE
60472011-11-28 Paul Eggert <eggert@cs.ucla.edu>
6048
6049 Remove GCPRO-related macros that exist only to avoid shadowing locals.
6050 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
6051 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
6052 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6053 All uses changed to use GCPRO1 etc.
6054 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
6055 Revert to old implementation (i.e., before 2011-03-11).
6056
1305621b
YM
60572011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6058
6059 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
6060 of scroll runs so as to avoid assigning disabled bogus rows and
6061 unnecessary graphics copy operations.
6062
8c9afb46
EZ
60632011-11-27 Eli Zaretskii <eliz@gnu.org>
6064
6065 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
6066 (snprintf) [_MSC_VER]: Redirect to _snprintf.
6067 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
6068 (malloc, free, realloc, calloc): Redirect to e_* only when
6069 compiling Emacs.
6070
6071 * lisp.h (GCTYPEBITS): Move before first use.
6072 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
6073 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
6074 this macro definition.
6075
6076 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
6077 _MSC_VER.
6078
54e9e3bf
JD
60792011-11-27 Jan Djärv <jan.h.d@swipnet.se>
6080
6d5eb5b0
SM
6081 * gtkutil.c (xg_create_frame_widgets):
6082 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
6083 present with Gtk+ 2.0.
6084
83aca1cb
PE
60852011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6086
6087 * fileio.c (Finsert_file_contents): Undo previous change; see
6088 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6089
5b76caa4
PE
60902011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6091
6092 Rename locals to avoid shadowing.
6093 * fileio.c (Finsert_file_contents):
6094 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
6095 * process.c (wait_reading_process_output):
6096 Rename inner 'proc' to 'p' to avoid shadowing.
6097 Indent for consistency with usual Emacs style.
6098
8c535114
EZ
60992011-11-25 Eli Zaretskii <eliz@gnu.org>
6100
6101 * xdisp.c (redisplay_window): If cursor row is not fully visible
6102 after recentering, and scroll-conservatively is set to a large
6103 number, scroll window by a few more lines to make the cursor fully
6104 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
6105 (start_display): Don't move to the next line if the display should
6106 start at a newline that is part of a display vector or an overlay
6107 string. (Bug#10119)
8c535114 6108
fa4fdb5c
JL
61092011-11-24 Juri Linkov <juri@jurta.org>
6110
6111 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
6112 after the `MagickPingImage' call. (Bug#10112)
6113
90ec88df
CY
61142011-11-23 Chong Yidong <cyd@gnu.org>
6115
6116 * window.c (Fcoordinates_in_window_p): Accept only live windows.
6117
56e2e794
MR
61182011-11-23 Martin Rudalics <rudalics@gmx.at>
6119
6120 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
6121 making another buffer current. (Bug#10114)
6122
b6e64c41
GM
61232011-11-23 Glenn Morris <rgm@gnu.org>
6124
6125 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
6126
6b21de18
CY
61272011-11-23 Chong Yidong <cyd@gnu.org>
6128
6129 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
6130 using it (Bug#5984).
6131
b12cd789
EZ
61322011-11-22 Eli Zaretskii <eliz@gnu.org>
6133
6134 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
6135 and header-lines, as they don't have one computed for them.
6136 (Bug#10098)
6137
6138 * .gdbinit (prow): Make displayed values more self-explaining.
6139 Add row's hash code.
6140
261b6fd4
LMI
61412011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
6142
6143 * process.c (wait_reading_process_output): Fix asynchrounous
6144 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 6145 (wait_reading_process_output): Add comment and URL.
261b6fd4 6146
e7cfd277
JD
61472011-11-21 Jan Djärv <jan.h.d@swipnet.se>
6148
6149 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
6150
a9b9b7f5
CY
61512011-11-21 Chong Yidong <cyd@gnu.org>
6152
6153 * window.c (Fnext_window, Fprevious_window): Doc fix.
6154
b0d15b4f
SM
61552011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6156
6157 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
6158
fe7a3057
JB
61592011-11-20 Juanma Barranquero <lekktu@gmail.com>
6160
6161 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
6162
d2999b1a
MR
61632011-11-20 Martin Rudalics <rudalics@gmx.at>
6164
6165 * window.c (Fset_window_combination_limit): Rename argument
6166 STATUS to LIMIT.
6167 (Vwindow_combination_limit): Remove "status" from doc-string.
6168
d5ff9cd0
AS
61692011-11-20 Andreas Schwab <schwab@linux-m68k.org>
6170
6171 * m/ibms390.h: Remove.
6172 * m/ibms390x.h: Don't include "ibms390.h".
6173
a5bb9bd3
SM
61742011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6175
6176 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
6177 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
6178
cd1181db
JB
61792011-11-20 Juanma Barranquero <lekktu@gmail.com>
6180
6181 * casetab.c (Fset_case_table):
6182 * charset.c (Fcharset_after): Fix typos.
6183
615a3b8d 61842011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 6185
17e845af
PE
6186 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
6187 Otherwise, valgrind does not work on some platforms.
6188 Problem reported by Andreas Schwab in
6a0bf43d
PE
6189 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
6190 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
6191 is set, removing the need for VIRT_ADDRESS_VARIES.
6192 (PURE_P): Use a more-efficient implementation that needs just one
6193 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
6194 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
6195 to 4 (xorl, subq, cmpq, setbe).
6196 * alloc.c (pure): Always extern now, since that's the
6197 VIRT_ADDR_VARIES behavior.
6198 (PURE_POINTER_P): Use a single comparison, not two, for
6199 consistency with the new puresize.h.
6200 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
6201 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
6202 Remove VIRT_ADDR_VARIES no longer needed.
6203
f8fe6f96
EZ
62042011-11-19 Eli Zaretskii <eliz@gnu.org>
6205
6206 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
6207 (erase_phys_cursor, update_window_cursor, show_mouse_face)
6208 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
6209 behave as if the cursor position were at the window margin.
6210
6211 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
6212 and the cursor position is out of bounds, behave as if the cursor
6213 position were at the window margin. (Bug#10075)
6214
df05a53c
CY
62152011-11-18 Chong Yidong <cyd@gnu.org>
6216
6217 * window.c (Fwindow_combination_limit): Make first argument
6218 non-optional, since it is meaningless for live windows like the
6219 selected window.
61ccba97 6220
2071918e
DA
62212011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
6222
6223 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
6224
b50a28de
SM
62252011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
6226
6227 * intervals.c: Fix grafting over the whole buffer (bug#10071).
6228 (graft_intervals_into_buffer): Simplify.
6229
015137db
EZ
62302011-11-18 Eli Zaretskii <eliz@gnu.org>
6231
6232 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
6233 hash values of the two rows.
6234 (copy_row_except_pointers): Preserve the used[] arrays and the
6235 hash values of the two rows. (Bug#10035)
68c95424 6236 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
6237
6238 * xdisp.c (row_hash): New function, body extracted from
6239 compute_line_metrics.
6240 (compute_line_metrics): Call row_hash, instead of computing the
6241 hash code inline.
6242
6243 * dispnew.c (verify_row_hash): Call row_hash for computing the
6244 hash code of a row, instead of duplicating code from xdisp.c.
6245
6246 * dispextern.h (row_hash): Add prototype.
6247
a2addb04
TH
62482011-11-18 Tassilo Horn <tassilo@member.fsf.org>
6249
6250 * frame.c (delete_frame): Don't delete the terminal when the last
6251 X frame is closed if emacs is built with GTK toolkit.
6252
df85d315
JB
62532011-11-17 Juanma Barranquero <lekktu@gmail.com>
6254
6255 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
6256
a0c2d0ae
MR
62572011-11-17 Martin Rudalics <rudalics@gmx.at>
6258
6259 * window.c (Vwindow_splits): Rename to
6260 Vwindow_combination_resize. Suggested by Juri Linkov.
6261 (Fsplit_window_internal): Use Vwindow_combination_resize instead
6262 of Vwindow_splits.
6263
58179cce
JB
62642011-11-16 Juanma Barranquero <lekktu@gmail.com>
6265
7877f373
JB
6266 * nsfns.m (Fns_font_name):
6267 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 6268
b6f67890
MR
62692011-11-16 Martin Rudalics <rudalics@gmx.at>
6270
6271 * window.h (window): Rename slot "nest" to "combination_limit".
6272 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
6273 (Fset_window_nest): Rename to Fset_window_combination_limit.
6274 (Vwindow_nest): Rename to Vwindow_combination_limit.
6275 (recombine_windows, make_parent_window, make_window)
6276 (Fsplit_window_internal, saved_window)
6277 (Fset_window_configuration, save_window_save): Rename all
6278 occurrences of window_nest to window_combination_limit.
6279
c7015153
JB
62802011-11-15 Juanma Barranquero <lekktu@gmail.com>
6281
6282 * image.c (imagemagick_load_image): Fix typo.
6283
322ad6ec
EZ
62842011-11-14 Eli Zaretskii <eliz@gnu.org>
6285
6286 * xdisp.c (display_line): Move the call to
6287 highlight_trailing_whitespace before the call to
6288 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
6289 faces of all the glyphs to compute ROW's hash value.
6290 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 6291
f067b8ec
JB
62922011-11-14 Juanma Barranquero <lekktu@gmail.com>
6293
6294 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
6295 just return (bug#10044).
6296
1e5b2111
EZ
62972011-11-12 Eli Zaretskii <eliz@gnu.org>
6298
7ef3cbd5
EZ
6299 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
6300 with user-defined heap size. Bump the default size of the temacs
6301 heap to 27MB, to avoid memory warning when running temacs.
6302 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
6303
1e5b2111
EZ
6304 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
6305 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
6306 (verify_row_hash) [XASSERTS]: New function.
6307 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
6308 that the hash value of glyph rows is correct.
1e5b2111 6309
89d61221
MR
63102011-11-12 Martin Rudalics <rudalics@gmx.at>
6311
6312 * window.h (window): Remove splits slot.
6313 * window.c (Fwindow_splits, Fset_window_splits): Remove.
6314 (Fdelete_other_windows_internal, make_parent_window)
6315 (make_window, Fsplit_window_internal, Fdelete_window_internal)
6316 (Fset_window_configuration, save_window_save): Don't deal with
6317 split status of windows.
6318 (saved_window): Remove splits slot.
6319 (Vwindow_splits): Rewrite doc-string.
6320
97f18cc8
JD
63212011-11-11 Jan Djärv <jan.h.d@swipnet.se>
6322
6323 * xfns.c (unwind_create_frame):
6324 * nsfns.m (unwind_create_frame):
6325 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
6326 Vframe_list (Bug#9999).
6327
22a648b4
DA
63282011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
6329
0b381c7e 6330 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 6331
659afede
KH
63322011-11-11 Kenichi Handa <handa@m17n.org>
6333
6334 * callproc.c (Fcall_process): Set the member dst_multibyte of
6335 process_coding.
6336
9ac0394b
KH
63372011-11-11 Johan Bockgård <bojohan@gnu.org>
6338
6339 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
6340 avoid a crash (bug#9496).
6341
2fbdc249
CY
63422011-11-09 Chong Yidong <cyd@gnu.org>
6343
6344 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
6345 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
6346
ac6b1f81
PE
63472011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6348
6349 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
6350
09db192c
PE
63512011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6352
6353 Avoid some portability problems by eschewing 'extern inline' functions.
6354 The trivial performance wins aren't worth the portability hassles; see
6355 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
6356 et seq.
6357 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6358 (window_box_width, window_box_left, window_box_left_offset)
6359 (window_box_right, window_box_right_offset): Undo previous change,
6360 by removing the "extern"s.
6361 * intervals.c (adjust_intervals_for_insertion)
6362 (adjust_intervals_for_deletion): Undo previous change,
6363 making these static again.
6364 (offset_intervals, temp_set_point_both, temp_set_point)
6365 (copy_intervals_to_string): No longer inline.
6366 * xdisp.c (window_text_bottom_y, window_box_width)
6367 (window_box_height, window_box_left_offset)
6368 (window_box_right_offset, window_box_left, window_box_right)
6369 (window_box): No longer inline.
6370
105216ed
CY
63712011-11-08 Chong Yidong <cyd@gnu.org>
6372
6373 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
6374 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
6375 Signal an error if not a live window.
105216ed
CY
6376 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
6377 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
6378
ae9e237f
JB
63792011-11-07 Juanma Barranquero <lekktu@gmail.com>
6380
6381 * lisp.h (syms_of_abbrev): Remove declaration.
6382 Reported by CHENG Gao <chenggao@royau.me>.
6383
c7aa8333
EZ
63842011-11-07 Eli Zaretskii <eliz@gnu.org>
6385
6386 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
6387 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
6388 of temacs in GUI mode.
6389
be7f5545
MR
63902011-11-07 Martin Rudalics <rudalics@gmx.at>
6391
6392 * window.h: Declare delete_all_child_windows instead of
6393 delete_all_subwindows.
6394 * window.c (Fwindow_nest, Fset_window_nest)
6395 (Fset_window_new_total, Fset_window_new_normal)
6396 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
6397 (delete_all_subwindows): Rename to delete_all_child_windows.
6398 (Fdelete_other_windows_internal, Fset_window_configuration):
6399 Call delete_all_child_windows instead of delete_all_subwindows.
6400 * frame.c (delete_frame): Call delete_all_child_windows instead
6401 of delete_all_subwindows.
6402
ca78dc43
PE
64032011-11-07 Paul Eggert <eggert@cs.ucla.edu>
6404
6405 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
6406 This is also needed for porting to any host where GC_MARK_STACK is
6407 not GC_MAKE_GCPROS_NOOPS.
6408 (which_symbols): Use it.
6409
a0241d01
KH
64102011-11-07 Kenichi Handa <handa@m17n.org>
6411
6412 * coding.c (coding_set_destination): Check coding->src_pos only
6413 when coding->src_object is a buffer (bug#9910).
6414
6415 * process.c (send_process): Set the member src_multibyte of coding
6416 to 0 (bug#9911) when sending a unibyte text.
6417
6418 * callproc.c (Fcall_process): Set the member src_multibyte of
6419 process_coding to 0 (bug#9912).
6420
a64bfdfa 64212011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
6422
6423 * xmenu.c (cleanup_widget_value_tree): New function.
6424 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
6425 calling free_menubar_widget_value_tree directly (Bug#9830).
6426
cb41b32a
PE
64272011-11-06 Paul Eggert <eggert@cs.ucla.edu>
6428
6429 Fix some portability problems with 'inline'.
6430 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6431 (window_box_width, window_box_left, window_box_left_offset)
6432 (window_box_right, window_box_right_offset): Declare extern.
6433 Otherwise, these inline functions do not conform to C99 and
6434 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
6435 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
6436 * intervals.c (adjust_intervals_for_insertion)
6437 (adjust_intervals_for_deletion): Now extern, because otherwise the
6438 extern inline functions 'offset_intervals' couldn't refer to it.
6439 (static_offset_intervals): Remove.
6440 (offset_intervals): Rewrite using the old contents of
6441 static_offset_intervals. The old version didn't conform to C99
6442 because an extern inline function contained a reference to an
6443 identifier with static linkage.
6444
b7041366
AS
64452011-11-06 Andreas Schwab <schwab@linux-m68k.org>
6446
6447 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
6448 GC.
6449
88a37c4d
EZ
64502011-11-06 Eli Zaretskii <eliz@gnu.org>
6451
6452 * xdisp.c (init_iterator, reseat_to_string): Don't set the
6453 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
6454 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
6455 return Qleft_to_right.
6456
49745b39
CY
64572011-11-06 Chong Yidong <cyd@gnu.org>
6458
6459 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
6460 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
6461 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
6462 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
6463 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
6464 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
6465 (Fwindow_vscroll): Doc fix.
6466 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
6467 argument, since it makes no sense to pass a live window and for
6468 consistency with window-child.
6469
1f05cd82
CS
64702011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
6471
6472 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
6473 support MSVC.
6474
22610910
JR
64752011-11-05 Jason Rumney <jasonr@gnu.org>
6476
6477 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
6478 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
6479 fonts (Bug#6029).
6480 (add_font_entity_to_list): Fix logic errors in mixed boolean and
6481 bitwise arithmetic preventing use of unicode-sip and non-truetype
6482 opentype fonts.
6483
a06776b2
EZ
64842011-11-05 Eli Zaretskii <eliz@gnu.org>
6485
3ad924ba
EZ
6486 * s/ms-w32.h (fstat, stat, utime): Move redirections to
6487 "emacs"-only part.
6488
a06776b2
EZ
6489 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
6490 initialization code to keep similarity to xfns.c after changes
6491 from 2011-11-05.
6492
c9e7db78
JD
64932011-11-05 Jan Djärv <jan.h.d@swipnet.se>
6494
a97f8f3f
JD
6495 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
6496 (unwind_create_frame): New function (Bug#9943).
6497 (Fx_create_frame): Restructure code to be more similar to the one in
6498 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
6499 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
6500 Move terminal->reference_count++ just before making the frame official
6501 (Bug#9943).
6502
6503 * nsterm.m (x_free_frame_resources): New function.
6504 (x_destroy_window): Move code to x_free_frame_resources.
6505
c9e7db78 6506 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
6507 (Fx_create_frame, x_create_tip_frame):
6508 Move terminal->reference_count++ just before making the frame
75f1671a 6509 official. Move initialization of image_cache_refcount and
c9e7db78
JD
6510 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
6511
a6fc3b5c
EZ
65122011-11-05 Eli Zaretskii <eliz@gnu.org>
6513
6514 Support MSVC build with newer versions of Visual Studio.
6515 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
6516 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
6517 nt/gmake.defs.
6518
6519 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
6520 which are not supported by MSVC.
6521 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
6522 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
6523 bitfields.
6524 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
6525 types in bitfields.
6526 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
6527
6528 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
6529
58179cce 65302011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
6531
6532 Support MSVC build with newer versions of Visual Studio.
6533 * w32.c: Don't include w32api.h for MSVC.
6534 (init_environment) [_MSC_VER]: Call sys_access, not _access.
6535
6536 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
6537 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
6538 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
6539 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
6540 e_* cousins.
6541 (alloca) [_MSC_VER]: Define to _alloca.
6542
6543 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
6544
6545 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
6546
a58c13ed
EZ
65472011-11-04 Eli Zaretskii <eliz@gnu.org>
6548
6549 * xdisp.c (note_mouse_highlight): If either of
6550 previous/next-single-property-change returns nil, treat that as
6551 the beginning or the end of the buffer. (Bug#9955)
6552
fe0b6370
JD
65532011-11-04 Jan Djärv <jan.h.d@swipnet.se>
6554
a58c13ed 6555 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
6556 label is not null (Bug#9951).
6557 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
6558 may be NULL.
6559
89bd5ee1
EZ
65602011-11-04 Eli Zaretskii <eliz@gnu.org>
6561
6562 * window.c (Fwindow_body_size): Mention in the doc string that the
6563 return value is in frame's canonical units. (Bug#9949)
6564
84c3edb9
EZ
65652011-11-03 Eli Zaretskii <eliz@gnu.org>
6566
4e2fb5c7
EZ
6567 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
6568
84c3edb9 6569 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 6570 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 6571 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 6572
bc17a887
EZ
65732011-11-01 Eli Zaretskii <eliz@gnu.org>
6574
6575 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
6576 Don't stop backward scan on the continuation glyph, even though
6577 its CHARPOS is positive.
6d5eb5b0
SM
6578 (mouse_face_from_buffer_pos, note_mouse_highlight):
6579 Rename cover_string to disp_string.
bc17a887 6580
4ee88440
MR
65812011-11-01 Martin Rudalics <rudalics@gmx.at>
6582
6583 * window.c (temp_output_buffer_show): Don't use
6584 Vtemp_buffer_show_specifiers.
6585 (Vtemp_buffer_show_specifiers): Remove unused variable.
6586
c2ff3c02
EZ
65872011-10-30 Eli Zaretskii <eliz@gnu.org>
6588
6589 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
6590 past the beginning of the current glyph matrix.
6591
58179cce 65922011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
6593
6594 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
6595 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
6596 HAVE_GTK3 (Bug#9869).
b77a6a7f 6597
3b574623
JD
6598 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
6599 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
6600
b77a6a7f
JD
6601 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
6602
6603 * xterm.c: Declare x_handle_net_wm_state to return int.
6604 (handle_one_xevent): Check if we are iconified but don't have
6605 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
6606 (get_current_wm_state): Return non-zero if not hidden,
6607 check for _NET_WM_STATE_HIDDEN (Bug#9893).
6608 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
6609 (x_handle_net_wm_state): Return what get_current_wm_state returns.
6610 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
6611
196e41e4
PE
66122011-10-29 Paul Eggert <eggert@cs.ucla.edu>
6613
6614 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
6615 so that this new function doesn't get optimized away by a
6616 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
6617
021f2e1a
AS
66182011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6619
6620 * frame.h (MOUSE_HL_INFO): Remove excess parens.
6621
8b058d44
EZ
66222011-10-29 Eli Zaretskii <eliz@gnu.org>
6623
6624 Fix the `xbytecode' command.
6625 * .gdbinit (xprintbytestr): New command.
b50a28de 6626 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
6627 (xbytecode): Print the byte-code string as well.
6628
4452fb80
EZ
66292011-10-29 Kim Storm <storm@cua.dk>
6630
8b058d44
EZ
6631 * alloc.c (which_symbols): New function.
6632
21b72067
AS
66332011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6634
6635 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
6636 line. (Bug#9903)
6637
83ed7b5c
GM
66382011-10-29 Glenn Morris <rgm@gnu.org>
6639
6640 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
6641 Not clear what it was for, and it causes various bugs. (Bug#9839)
6642
5a7a728b
EZ
66432011-10-28 Eli Zaretskii <eliz@gnu.org>
6644
6645 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
6646 possible random value that matches one of those tested as
6647 condition to clear the mouse face.
6648
d3d0842f
CY
66492011-10-28 Chong Yidong <cyd@gnu.org>
6650
6651 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
6652
31b39d13
DN
66532011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
6654
6655 * window.c (make_window): Initialize phys_cursor_on_p.
6656
9aba6043
SM
66572011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
6658
6659 * lisp.h (struct Lisp_Symbol): Update comments.
6660
c20992f4
JB
66612011-10-28 Juanma Barranquero <lekktu@gmail.com>
6662
6663 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
6664
db4f02f2
EZ
66652011-10-28 Eli Zaretskii <eliz@gnu.org>
6666
6667 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
6668 <oslsachem@gmail.com> for helping to debug this.
6669
6670 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
6671 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
6672 (g_b_init_get_glyph_outline_w): New static variables.
6673 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
6674 (GetGlyphOutlineW_Proc): New typedefs.
6675 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
6676 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
6677 New functions.
6678 (w32font_open_internal, compute_metrics):
6679 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
6680 instead of calling the "wide" APIs directly.
6681
6682 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
6683
6684 * w32.h (syms_of_w32font): Add prototype.
6685
87e68db4
JB
66862011-10-27 Juanma Barranquero <lekktu@gmail.com>
6687
6688 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
6689 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
6690 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
6691 (Fmove_to_window_line): Doc fix.
6692
435c1d67
CY
66932011-10-27 Chong Yidong <cyd@gnu.org>
6694
6695 * process.c (make_process): Set gnutls_state to NULL.
6696
6697 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
6698 non-NULL, regardless of GNUTLS_INITSTAGE.
6699 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
6700 an error. Set process slots as soon as we allocate them.
6701
6702 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
6703
9c6c6f49
CY
67042011-10-27 Chong Yidong <cyd@gnu.org>
6705
9aba6043
SM
6706 * gnutls.c (emacs_gnutls_deinit): New function.
6707 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
6708 (Fgnutls_deinit, Fgnutls_boot): Use it.
6709
6710 * process.c (make_process): Initialize GnuTLS credentials to NULL.
6711 (deactivate_process): Call emacs_gnutls_deinit.
6712
657d08d3
JB
67132011-10-27 Juanma Barranquero <lekktu@gmail.com>
6714
6715 * image.c (x_create_x_image_and_pixmap):
6716 * w32.c (sys_rename, w32_delayed_load):
6717 * w32font.c (fill_in_logfont):
6718 * w32reg.c (x_get_string_resource): Silence compiler warnings.
6719
5430d399
JB
67202011-10-26 Juanma Barranquero <lekktu@gmail.com>
6721
6722 * w32fns.c (w32_default_color_map): New function,
6723 extracted from Fw32_default_color_map.
a7ef684b 6724 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 6725
fe0055fa
PE
67262011-10-25 Paul Eggert <eggert@cs.ucla.edu>
6727
6728 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
6729
e6346438
SM
67302011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
6731
6732 * keyboard.c (test_undefined): New function (bug#9751).
6733 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
6734
e112cc37
ET
67352011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
6736
6737 * sysdep.c (init_sys_modes): Fix the check for the controlling
6738 terminal (Bug#6649).
6739
7b5d6677
EZ
67402011-10-20 Eli Zaretskii <eliz@gnu.org>
6741
6742 * dispextern.h (struct bidi_it): New member next_en_type.
6743
6744 * bidi.c (bidi_line_init): Initialize the next_en_type member.
6745 (bidi_resolve_explicit_1): When next_en_pos is valid for the
6746 current character, check also for next_en_type being WEAK_EN.
6747 (bidi_resolve_weak): Don't enter the expensive loop if the current
6748 position is before next_en_pos. Record the bidi type of the first
6749 non-ET, non-BN character we find, in addition to its position.
6750 (bidi_level_of_next_char): Invalidate next_en_type when
6751 next_en_pos is over-stepped.
6752
7da0b018
PE
67532011-10-20 Paul Eggert <eggert@cs.ucla.edu>
6754
6755 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
6756 * editfns.c: Rewrite current-time-zone so that it invokes
6757 the equivalent of (format-time-string "%Z") to get the time zone name.
6758 This fixes a bug when the time zone name contains characters that
6759 need converting from the system time locale to Emacs internal format.
6760 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
6761 that patch fixed format-time-string to do the conversion, but
6762 I forgot to fix current-time-zone.
6763 (format_time_string): New function, containing most of
6764 what Fformat_time_string used to contain.
6765 (Fformat_time_string): Rewrite in terms of format_time_string.
6766 This doesn't change this function's behavior.
6767 (current-time-zone): Rewrite to use format_time_string.
6768 This fixes the bug reported by Michael Schierl in
6769 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
6770 Jason Rumney's 2007-06-07 change worked around this bug, but
6771 didn't fix it.
6772 * systime.h (tzname, timezone): Remove no-longer-used declarations.
6773
8547b010
EZ
67742011-10-19 Eli Zaretskii <eliz@gnu.org>
6775
6776 * xdisp.c (start_display): If the character at POS is displayed
6777 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
6778 (try_window_reusing_current_matrix): If a line ends in a display
6779 vector or the next line starts in a display vector, continue
6780 redrawing the window even though the character position of
6781 start_row was reached.
8547b010
EZ
6782 (Bug#9771, part 2)
6783
4e948d15
CY
67842011-10-18 Chong Yidong <cyd@gnu.org>
6785
6786 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
6787 with nobreak-char-display too.
6788
4787455f
EZ
67892011-10-18 Eli Zaretskii <eliz@gnu.org>
6790
6791 Fix part 3 of bug#9771.
6792 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
6793 (bidi_resolve_neutral): Don't enter the expensive loop looking for
6794 non-neutral characters if the current character is a paragraph
6795 separator (a.k.a. Newline). This avoids running the same
6796 expensive loop twice, once when we consume the preceding newline
6797 and the other time when the line actually needs to be displayed.
6798 Avoid the loop when we see neutrals on the base embedding level
6799 following a character whose directionality is the same as the
6800 paragraph's. This avoids running the expensive loop when a line
6801 ends in a long sequence of neutrals, like control characters.
6802 Add assertion against STRONG_AL type. Slightly rearrange code
6803 that determines the type of a neutral given the first non-neutral
6804 that follows it.
6805 (bidi_level_of_next_char): Set next_en_pos to zero when
6806 invalidating its info.
6807
2c91f553
EZ
68082011-10-17 Eli Zaretskii <eliz@gnu.org>
6809
6810 * xdisp.c (push_display_prop): Determine whether to record string
6811 or buffer position by IT->string, not by IT->method. Allow
6812 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
6813 (move_it_vertically_backward): Don't look for character position
6814 immediately after the newline when in a continuation line.
6815 (Bug#9771, part 1)
2c91f553 6816
c7b08b0d
MR
68172011-10-15 Martin Rudalics <rudalics@gmx.at>
6818
6819 * window.c (coordinates_in_window): Rewrite and delabelize
6820 vertical border check. (Bug#5357) (Bug#9618)
6821
6b02f655
SM
68222011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
6823
6824 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
6825 errors in XSetWindowBorder (bug#9310).
6826
81d40c92
DA
68272011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
6828
6829 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
6830 avoid crash when xmalloc overrun checking is enabled.
6831
d4172c3b
EZ
68322011-10-13 Eli Zaretskii <eliz@gnu.org>
6833
6834 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
6835 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
6836 cursor motion with <left> and <right> arrow keys.
6837
6838 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
6839 some callers set that themselves.
6840
b00eea75
EZ
68412011-10-12 Eli Zaretskii <eliz@gnu.org>
6842
6843 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
6844 display string and the previous row comes from the same string and
6845 is empty. (Bug#9739) (Bug#9738)
6846
8fe012c4
SM
68472011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
6848
6849 * doc.c (get_doc_string): Encode file name (bug#9735).
6850
0074aef2
EZ
68512011-10-12 Eli Zaretskii <eliz@gnu.org>
6852
79beb178
EZ
6853 * bidi.c (bidi_level_of_next_char):
6854 * xdisp.c (get_visually_first_element): Remove old incorrect
6855 comments regarding the Unicode Line Separator character.
6856
0074aef2
EZ
6857 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
6858
6e4b3fbe
DA
68592011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
6860
6861 * alloc.c (Fgc_status): Do not access beyond zombies array
6862 boundary if nzombies > MAX_ZOMBIES.
6863 * alloc.c (dump_zombies): Add missing format specifier.
6864
0324f3af
PE
68652011-10-12 Paul Eggert <eggert@cs.ucla.edu>
6866
b5525cac
PE
6867 * xdisp.c (set_cursor_from_row): Simplify conditionals,
6868 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
6869
0324f3af
PE
6870 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
6871 Some packages use them to denote characters with modifiers.
6872
e9b5f888
AS
68732011-10-11 Andreas Schwab <schwab@linux-m68k.org>
6874
6875 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
6876 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
6877 matching a pp-number. Rename parameter var to var1.
6878
127827c0
SM
68792011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
6880
6881 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
6882
c8fd3bd0
GM
68832011-10-08 Glenn Morris <rgm@gnu.org>
6884
6885 * callint.c (Fcall_interactively): Give a more explicit error for the
6886 'c' case with a non-character input. (Bug#8479)
6887
352ec8ff
EZ
68882011-10-08 Eli Zaretskii <eliz@gnu.org>
6889
03669ccb
EZ
6890 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
6891 lines.
7061c986
EZ
6892 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
6893 lines that are hscrolled on the left.
03669ccb 6894
352ec8ff
EZ
6895 * dispnew.c (buffer_posn_from_coords): Account for a possible
6896 presence of header-line. (Bug#4426)
6897
a66cfb1c
SM
68982011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
6899
6b02f655
SM
6900 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
6901 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 6902
7c5ee88e
PE
69032011-10-07 Paul Eggert <eggert@cs.ucla.edu>
6904
6905 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
6906 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
6907 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
6908 this makes Emacs dump core during garbage collection on rare
6909 occasions. sizeof is obviously inferior to offsetof here, so
6910 stick with offsetof.
6911 (GC_POINTER_ALIGNMENT): New macro.
6912 (mark_memory): Omit 3rd (offset) arg; caller changed.
6913 Don't assume EMACS_INT alignment is the same as pointer alignment.
6914
df1bbe5b
SM
69152011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
6916
6917 * keyboard.c (read_key_sequence_remapped): New var.
6918 (read_key_sequence): Compute remapping in the right buffer.
6919 (command_loop_1): Use read_key_sequence's remapping directly.
6920
51553db6
SM
69212011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
6922
32c1fffd
SM
6923 * dired.c (file_name_completion): Don't expand file name.
6924 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
6925 before checking file name handler.
6926
51553db6
SM
6927 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
6928 they've been requested explicitly (bug#9591).
6929
b6bd1599 69302011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
6931
6932 * keymap.c (Fsingle_key_description): Use make_specified_string
6933 instead of build_string to build string from push_key_description.
6934 (Bug#5193)
6935
f701dc2a
PE
69362011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6937
4222c55d
PE
6938 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
6939 This fixes a Y2038 bug on 64-bit hosts.
6940 * buffer.c (reset_buffer):
6941 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
6942 (Fclear_buffer_auto_save_failure):
6943 Use 0, not -1, to represent an unset failure time, since time_t
6944 might not be signed.
6945
f701dc2a
PE
6946 Remove dependency on glibc malloc internals.
6947 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6948 Move back here from lisp.h, but with their new implementations.
6949 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6950 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
6951 * charset.c (charset_table_init): New static var.
6952 (syms_of_charset): Use it instead of xmalloc. This removes a
6953 dependency on glibc malloc internals. See Eli Zaretskii's comment in
6954 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
6955 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6956 Move back to alloc.c.
6957 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6958 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
6959
9ceebf39
JD
69602011-09-30 Jan Djärv <jan.h.d@swipnet.se>
6961
6962 * nsterm.m (windowDidResize): Call x_set_window_size only when
6963 ns_in_resize is true. Otherwise set pixelwidth/height and
6964 call change_frame_size (Bug#9628).
6965
cb993c58
PE
69662011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6967
3930c88b
PE
6968 Port --enable-checking=all to Fedora 14 x86-64.
6969 * charset.c (syms_of_charset): Also account for glibc malloc's
6970 internal overhead when calculating the initial malloc maximum.
6971
cb993c58
PE
6972 Port --enable-checking=all to Fedora 14 x86.
6973 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6974 Move to lisp.h.
6975 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
6976 (overrun_check_realloc, overrun_check_free):
6977 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
6978 That way, xmalloc returns a properly-aligned pointer even if
6979 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
6980 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
6981 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
6982 into account when calculating the initial malloc maximum.
6983 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6984 Move here from alloc.c, so that charset.c can use it too.
6985 Properly align; the old code wasn't right for common 32-bit hosts
6986 when configured with --enable-checking=all.
6987 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6988 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
6989
31bed486
EZ
69902011-09-29 Eli Zaretskii <eliz@gnu.org>
6991
04c70788 6992 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
6993 use EDOM.
6994
fbcaa2f3
EZ
69952011-09-28 Eli Zaretskii <eliz@gnu.org>
6996
6997 * xdisp.c (compute_display_string_end): If there's no display
6998 string at CHARPOS, return -1.
6999
7000 * bidi.c (bidi_fetch_char): When compute_display_string_end
7001 returns a negative value, treat the character as a normal
7002 character not covered by a display string. (Bug#9624)
7003
a239d4e9
JB
70042011-09-28 Juanma Barranquero <lekktu@gmail.com>
7005
7006 * lread.c (Fread_from_string): Fix typo in docstring.
7007
88652fd5
EZ
70082011-09-27 Eli Zaretskii <eliz@gnu.org>
7009
7010 * xdisp.c (handle_invisible_prop): If invisible text ends on a
7011 newline, reseat the iterator instead of bidi-iterating there one
7012 character at a time. (Bug#9610)
32c1fffd
SM
7013 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
7014 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 7015
ed497dd4
AS
70162011-09-27 Andreas Schwab <schwab@linux-m68k.org>
7017
7018 * lread.c (readevalloop): Use correct code for NBSP.
7019 (read1): Likewise. (Bug#9608)
7020
b2bf61aa
MA
70212011-09-25 Michael Albinus <michael.albinus@gmx.de>
7022
7023 * dbusbind.c (Fdbus_register_signal): When service is not
7024 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
7025
32bbb17c
GM
70262011-09-25 Glenn Morris <rgm@gnu.org>
7027
7028 * buffer.c (truncate-lines): Doc fix.
7029
94e0933e
CY
70302011-09-24 Chong Yidong <cyd@stupidchicken.com>
7031
7032 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
7033 (Fset_window_next_buffers): Doc fix.
7034
cddde921
GM
70352011-09-24 Glenn Morris <rgm@gnu.org>
7036
7037 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
7038
1260aef1
PE
70392011-09-24 Paul Eggert <eggert@cs.ucla.edu>
7040
25b4bfa0
PE
7041 Fix minor problems found by static checking.
7042 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
7043 * indent.c (Fvertical_motion): Fix == vs = typo.
7044
e3cbd34b
EZ
70452011-09-24 Eli Zaretskii <eliz@gnu.org>
7046
a66cfb1c
SM
7047 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
7048 Default value is now t. Doc fix.
6bf7006f 7049
e3cbd34b 7050 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 7051 logic when moving up, not only when moving down. Fix the
e3cbd34b 7052 confusing name and values of the it_overshoot_expected variable;
32c1fffd 7053 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
7054
7055 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
7056 CHARPOS is covered by a display string which includes newlines.
7057 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
7058 is covered by a display string with embedded newlines.
7059
a3de0cbd
MA
70602011-09-24 Michael Albinus <michael.albinus@gmx.de>
7061
7062 * dbusbind.c (Fdbus_register_signal): Add match rule to
7063 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
7064 (Fdbus_register_method, Vdbus_registered_objects_table):
7065 Fix docstring.
a3de0cbd 7066
b260039d
JM
70672011-09-24 Jim Meyering <meyering@redhat.com>
7068
32c1fffd 7069 do not ignore write error for any output size
b260039d
JM
7070 The previous change was incomplete.
7071 While it makes emacs --batch detect the vast majority of stdout
7072 write failures, errors were still ignored whenever the output size is
7073 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
7074 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
7075 && echo FAIL: ignored write error
7076 FAIL: ignored write error
7077 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
7078 && echo FAIL: ignored write error
7079 FAIL: ignored write error
7080 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
7081
8eca8a7c
AS
70822011-09-23 Andreas Schwab <schwab@linux-m68k.org>
7083
7084 * emacs.c (Fkill_emacs): In noninteractive mode exit
7085 non-successfully if a write error occurred on stdout. (Bug#9574)
7086
3341db62
EZ
70872011-09-21 Eli Zaretskii <eliz@gnu.org>
7088
7089 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
7090 the xassert test.
7091
7092 * dispextern.h (struct it): Update the comment documenting what
7093 can it->OBJECT be.
7094
8c203dbf
EZ
70952011-09-20 Eli Zaretskii <eliz@gnu.org>
7096
7097 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
7098 a display string, extend search for cursor position to end of row.
7099 (find_row_edges): If the row ends in a newline from a display
7100 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
7101 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
7102 (Fcurrent_bidi_paragraph_direction): Fix search for previous
7103 non-empty line. Fixes confusing cursor motion with arrow keys at
7104 the beginning of a line that starts with whitespace.
8c203dbf 7105
a4824228
LMI
71062011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7107
7108 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
7109 (bug#9493).
7110
33ed493b
CY
71112011-09-18 Chong Yidong <cyd@stupidchicken.com>
7112
7113 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
7114 boolean (Bug#9154).
7115
56cd55c8
EZ
71162011-09-18 Eli Zaretskii <eliz@gnu.org>
7117
7118 * xdisp.c (display_line): Record maximum and minimum buffer
7119 positions even if no glyphs were produced (e.g., by a zero-width
7120 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
7121 buffer positions that will be removed from the glyph row because
7122 they don't fit.
c02dcedf
EZ
7123 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
7124 column is beyond frame width: don't subtract 1 "pixel" when
7125 computing width of the stretch.
3e62b7e0
EZ
7126 (reseat_at_next_visible_line_start): Undo the change made on
7127 2011-09-17 that saved paragraph information and restored it after
7128 the call to `reseat'. (Bug#9545)
56cd55c8 7129
5ed99d36 71302011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
7131
7132 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
7133 and turn window cursor on if cleared (Bug#9415).
7134
5ed99d36 71352011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
7136
7137 * search.c (boyer_moore): Take unibyte characters from pattern
7138 literally. (Bug#9458)
7139
9bade7b2
EZ
71402011-09-18 Eli Zaretskii <eliz@gnu.org>
7141
7142 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
7143
e5e9d610
PE
71442011-09-18 Paul Eggert <eggert@cs.ucla.edu>
7145
87e4427a
PE
7146 Fix minor problem found by static checking.
7147 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
7148 initialized, to pacify gcc -Wuninitialized.
7149
e5e9d610
PE
7150 * fileio.c: Report proper errno when syscall falls.
7151 (Finsert_file_contents): Save and restore errno,
7152 so that report_file_error outputs the correct diagnostic.
7153 (Fwrite_region) [CLASH_DETECTION]: Likewise.
7154
a1674f0b
EZ
71552011-09-18 Eli Zaretskii <eliz@gnu.org>
7156
7157 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
7158
fbfb6dd4
EZ
71592011-09-17 Eli Zaretskii <eliz@gnu.org>
7160
7161 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
7162 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
7163
bb187662
EZ
71642011-09-17 Eli Zaretskii <eliz@gnu.org>
7165
1137e8b8 7166 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 7167 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
7168
7169 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
7170 (bidi_find_paragraph_start): Search back for paragraph beginning
7171 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
7172 (bidi_move_to_visually_next): Only trigger paragraph-related
7173 computations when the last character is a newline or at EOB, not
7174 just any NEUTRAL_B. (Bug#9470)
7175
bb187662
EZ
7176 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
7177 truncated lines if point is covered by a display string. (Bug#9524)
7178
2e621251
PE
71792011-09-16 Paul Eggert <eggert@cs.ucla.edu>
7180
7181 * xselect.c: Relax test for outgoing X longs (Bug#9498).
7182 (cons_to_x_long): New function.
7183 (lisp_data_to_selection_data): Use it. Correct the test for
7184 short-versus-long data; it was negated. Break out of vector
7185 loop, for efficiency, when a long datum is discovered.
7186
91a15bc6
SM
71872011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
7188
7189 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
7190
b41c3a35
EZ
71912011-09-16 Eli Zaretskii <eliz@gnu.org>
7192
7193 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
7194 GCC PR/17406) by declaring this function with external scope.
7195
7812ba2d
PE
71962011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7197
7198 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
7199 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
7200
cf7edc2a
AS
72012011-09-15 Andreas Schwab <schwab@linux-m68k.org>
7202
7203 * editfns.c (Fformat): Correctly handle text properties on "%%".
7204
bd01620e
EZ
72052011-09-15 Eli Zaretskii <eliz@gnu.org>
7206
7207 * xterm.c (x_draw_composite_glyph_string_foreground):
7208 * w32term.c (x_draw_composite_glyph_string_foreground):
7209 * term.c (encode_terminal_code):
7210 * composite.c (composition_update_it, get_composition_id):
7211 * xdisp.c (get_next_display_element)
7212 (fill_composite_glyph_string): Add comments about special meaning
7213 of TAB characters in a composition.
7214
a02719a3
PE
72152011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7216
7217 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
7218 This occurs when processing a multibyte format.
7219 Problem reported by Wolfgang Jenker.
a02719a3 7220
72589a3c
JB
72212011-09-15 Johan Bockgård <bojohan@gnu.org>
7222
7223 * xdisp.c (try_cursor_movement): Only check for exact match if
7224 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
7225
1c14176c
PE
72262011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7227
7228 Remove unused external symbols.
7229 * dispextern.h (calc_pixel_width_or_height): Remove decl.
7230 * xdisp.c (calc_pixel_width_or_height): Now static.
7231 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
7232 * indent.c (check_display_width):
7233 * w32term.c: Fix comment to match code.
7234 * xterm.c, xterm.h (x_catching_errors): Remove.
7235
d2eea5b5
PE
72362011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7237
7238 * xselect.c: Use signed conversions more consistently (Bug#9498).
7239 (selection_data_to_lisp_data): Assume incoming selection data are
7240 signed integers, not unsigned. This is to be consistent with
7241 outgoing selection data, which was modified to use signed integers
7242 in as part of the fix to Bug#9196 in response to Jan D.'s comment
7243 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
7244 expects long, not unsigned long.
7245
46888499
EZ
72462011-09-14 Eli Zaretskii <eliz@gnu.org>
7247
7248 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
7249 computation of loop end. Reported by Johan Bockgård
7250 <bojohan@gnu.org>.
7251
ef8ef9fb
CY
72522011-09-13 Chong Yidong <cyd@stupidchicken.com>
7253
7254 * frame.c (Fother_visible_frames_p): Function deleted.
7255
fa819fed
EZ
72562011-09-12 Eli Zaretskii <eliz@gnu.org>
7257
7258 * indent.c (compute_motion): Process display vector front to back
7259 rather than the other way around. (Bug#2496)
7260
2ba8e008
SM
72612011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
7262
7263 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
7264
20f53c69
CY
72652011-09-11 Chong Yidong <cyd@stupidchicken.com>
7266
7267 * minibuf.c (Fread_from_minibuffer): Doc fix.
7268
d562d7a4
EZ
72692011-09-11 Eli Zaretskii <eliz@gnu.org>
7270
7271 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
7272 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
7273
1c4d7f3d
LMI
72742011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7275
7276 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
7277 value for non-existent files.
7278
b885bf36
EZ
72792011-09-11 Eli Zaretskii <eliz@gnu.org>
7280
7281 * fileio.c (Finsert_file_contents): If the file cannot be opened,
7282 set its "size" to -1. This will set the modtime_size field of
7283 the corresponding buffer to -1, which is what
7284 verify-visited-file-modtime expects for files that do not exist.
7285 (Bug#9139)
7286
6612f0bf
PE
72872011-09-11 Paul Eggert <eggert@cs.ucla.edu>
7288
7289 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
7290 here ...
7291 * lisp.h: ... from here. push_key_description is no longer
7292 defined in keyboard.c, so its declaration should not be in
7293 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
7294 logically belongs with push_key_description.
7295
dfb3f755
PE
72962011-09-10 Paul Eggert <eggert@cs.ucla.edu>
7297
7298 * buffer.h: Include <sys/types.h> instead of <time.h>.
7299 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
7300 Problem reported by Herbert J. Skuhra.
7301
3134906c
LMI
73022011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
7303
7304 * xml.c (parse_region): Make the parsing work for
7305 non-comment-starting XML files again (bug#9144).
7306
8d903f4e
AS
73072011-09-10 Andreas Schwab <schwab@linux-m68k.org>
7308
7309 * image.c (gif_load): Fix calculation of bottom and right corner.
7310 (Bug#9468)
7311
80ad64f4
EZ
73122011-09-10 Eli Zaretskii <eliz@gnu.org>
7313
7314 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
7315 redisplay in small windows.
7316
208a048d
EZ
73172011-09-09 Eli Zaretskii <eliz@gnu.org>
7318
7319 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
7320
9b1c252e
MR
73212011-09-08 Martin Rudalics <rudalics@gmx.at>
7322
7323 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
7324 Operate on live windows only.
7325
2949f33b
JB
73262011-09-08 Juanma Barranquero <lekktu@gmail.com>
7327
7328 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
7329
e08dcafd
EZ
73302011-09-07 Eli Zaretskii <eliz@gnu.org>
7331
7332 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
7333 only under bidi iteration.
7334
115b96bd
JD
73352011-09-07 Jan Djärv <jan.h.d@swipnet.se>
7336
7337 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
7338
c8199d0f
PE
73392011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7340
7341 isnan: Fix porting problem to Solaris 10 with bundled gcc.
7342 Without this fix, the command to link temacs failed due to an
7343 undefined symbol __builtin_isnan. This is because
7344 /usr/include/iso/math_c99.h #defines isnan(x) to
7345 __builtin_isnan(x), but the bundled gcc, which identifies itself
7346 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
7347 a __builtin_isnan.
7348 * floatfns.c (isnan): #undef, and then #define to a clone of
7349 what's in data.c.
7350 (Fisnan): Always define, since it's always available now.
7351 (syms_of_floatfns): Always define isnan at the Lisp level.
7352
e39b275c 73532011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
7354
7355 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
7356
b2db44d9 73572011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 7358
f4af5137 7359 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
7360 The previous code assumed that file offsets (off_t values) fit in
7361 EMACS_INT variables, which is not true on typical 32-bit hosts.
7362 The code messed up by falsely reporting buffer overflow in cases
7363 such as (insert-file-contents "big" nil 1 2) into an empty buffer
7364 when "big" contains more than 2**29 bytes, even though this
7365 inserts just one byte and does not overflow the buffer.
7366 (Finsert_file_contents): Store file offsets as off_t
7367 values, not as EMACS_INT values. Check for overflow when
7368 converting between EMACS_INT and off_t. When checking for
7369 buffer overflow or for overlap, take the offsets into account.
7370 Don't use EMACS_INT for small values where int suffices.
7371 When checking for overlap, fix a typo: ZV was used where
7372 ZV_BYTE was intended.
7373 (Fwrite_region): Don't assume off_t fits into 'long'.
7374 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
7375
ecfc0a49
MA
73762011-09-05 Michael Albinus <michael.albinus@gmx.de>
7377
7378 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
7379
6511acf2 73802011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 7381
0999621a 7382 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
7383
7384 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 7385 (esprintf, exprintf, evxprintf): New functions.
62f19c19 7386 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 7387 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
7388 (modify_event_symbol): Do not assume that the length of
7389 name_alist_or_stem is safe to alloca and fits in int.
7390 (Fexecute_extended_command): Likewise for function name and binding.
7391 (Frecursion_depth): Wrap around reliably on integer overflow.
7392 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
7393 since some callers pass EMACS_INT values.
7394 (Fsingle_key_description): Don't crash if symbol name contains more
7395 than MAX_ALLOCA bytes.
7396 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
7397 (get_minibuffer): Arg is now EMACS_INT, not int.
7398 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 7399 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
7400 * window.h (command_loop_level, minibuf_level): Reflect API changes.
7401
2be7d702
PE
7402 * dbusbind.c (signature_cat): New function.
7403 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
7404 Do not overrun buffer; instead, report string overflow.
7405
9d1df220
PE
7406 * dispnew.c (add_window_display_history): Don't overrun buffer.
7407 Truncate instead; this is OK since it's just a log.
7408
33ef5c64
PE
7409 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
7410 even if the time zone offset is outlandishly large.
7411 Don't mishandle offset == INT_MIN.
7412
66c6fdd5
PE
7413 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
7414 when creating daemon; the previous buffer-overflow check was incorrect.
7415
d749b01b
PE
7416 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
7417 which has the guts of the old verror function.
7418
b5cd1905
PE
7419 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
7420 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
7421
6e1a67fb
PE
7422 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
7423 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 7424 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 7425 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
7426 length of string rather than counting it via multiple sprintfs;
7427 that's simpler and more reliable.
c21721cc
PE
7428 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
7429 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
7430 sprintf, in case result does not fit in int.
7431
c57b67fc
PE
7432 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
7433 (fontset_from_font): Print it.
7434
8a401434
PE
7435 * frame.c (tty_frame_count): Now printmax_t, not int.
7436 (make_terminal_frame, set_term_frame_name): Print it.
7437 (x_report_frame_params): In X, window IDs are unsigned long,
7438 not signed long, so print them as unsigned.
7439 (validate_x_resource_name): Check for implausibly long names,
7440 and don't assume name length fits in 'int'.
7441 (x_get_resource_string): Don't blindly alloca invocation name;
7442 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
7443 not fit in int.
7444
6e1a67fb
PE
7445 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
7446 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
7447 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
7448
0df02bf3
PE
7449 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
7450 Use esprintf, not sprintf, in case result does not fit in int.
7451
48e30793
PE
7452 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7453 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
7454 it as a large positive number.
7455 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
7456 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7457
a66ff6d8
PE
7458 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
7459 in case result does not fit in int.
7460
aca216ff
PE
7461 * print.c (float_to_string): Detect width overflow more reliably.
7462 (print_object): Make sprintf buffer a bit bigger, to avoid potential
7463 buffer overrun. Don't assume list length fits in 'int'. Treat
7464 print length of 0 as 0, not as infinity; to be consistent with other
7465 uses of print length in this function. Don't overflow print length
7466 index. Don't assume hash table size fits in 'long', or that
7467 vectorlike size fits in 'unsigned long'.
7468
31c286f7
PE
7469 * process.c (make_process): Use printmax_t, not int, to format
7470 process-name gensyms.
7471
55e5faa1
PE
7472 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
7473
80f2e268
PE
7474 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
7475 to avoid potential buffer overrun.
7476
670741ab
PE
7477 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
7478 if X resource line is longer than 512 bytes.
7479
b7163a50
PE
7480 * xfns.c (x_window): Make sprintf buffer a bit bigger
7481 to avoid potential buffer overrun.
7482
ae58ff1f
PE
7483 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
7484
c43c8a6a
PE
7485 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
7486
3f8236f4
PE
74872011-09-04 Paul Eggert <eggert@cs.ucla.edu>
7488
53e9fe90 7489 Integer overflow fixes for scrolling, etc.
6511acf2
PE
7490 Without these, Emacs silently mishandles large integers sometimes.
7491 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
7492 it were "C-u 1 M-x recenter" on a typical 64-bit host.
7493
6511acf2
PE
7494 * xdisp.c (try_window_id): Check Emacs fixnum range before
7495 converting to 'int'.
806add1d 7496
6511acf2 7497 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
7498 Check that an Emacs fixnum is in range before assigning it to 'int'.
7499 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
7500 values converted from Emacs fixnums.
7501 (Frecenter): Don't wrap around a line count if it is out of 'int'
7502 range; instead, treat it as an extreme value.
7503 (Fset_window_configuration, compare_window_configurations):
7504 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
7505
6511acf2
PE
7506 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
7507 that can exceed INT_MAX. Check that EMACS_INT value is in range
7508 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
7509 (match_limit): Don't assume that a fixnum can fit in 'int'.
7510
6511acf2 7511 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
7512 exceed INT_MAX.
7513
6511acf2 7514 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
7515 (Fvertical_motion): Don't wrap around LINES values that don't fit
7516 in 'int'. Instead, treat them as extreme values. This is good
7517 enough for windows, which can't have more than INT_MAX lines anyway.
7518
fcb901a7
LMI
75192011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7520
0f2f6b6d
LMI
7521 * Require libxml/parser.h to avoid compilation warning.
7522
fcb901a7
LMI
7523 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
7524
7525 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
7526 since this reportedly can destroy thread storage.
7527
6e20a0d4
CY
75282011-08-30 Chong Yidong <cyd@stupidchicken.com>
7529
7530 * syntax.c (find_defun_start): Update all cache variables if
7531 exiting early (Bug#9401).
7532
148ae00e
EZ
75332011-08-30 Eli Zaretskii <eliz@gnu.org>
7534
f6cfbd8f
EZ
7535 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
7536
148ae00e
EZ
7537 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
7538 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
7539 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
7540
7541 * term.c (tty_append_glyph): New function.
7542 (produce_stretch_glyph): Static function and its prototype deleted.
7543
a66cfb1c
SM
7544 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
7545 Add prototypes.
148ae00e 7546
c4a07a4c
PE
75472011-08-29 Paul Eggert <eggert@cs.ucla.edu>
7548
7549 * image.c (parse_image_spec): Check for nonnegative, not for positive,
7550 when checking :margin (Bug#9390).
7551 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 7552 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
7553 so that the name doesn't mislead. All uses changed.
7554
6bc8cd65
JB
75552011-08-28 Johan Bockgård <bojohan@gnu.org>
7556
7557 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
7558 set_tty_hooks.
7559
dca4927e
EZ
75602011-08-27 Eli Zaretskii <eliz@gnu.org>
7561
7562 * xdisp.c (move_it_to): Don't bail out early when reaching
7563 position beyond to_charpos, if we are scanning backwards.
7564 (move_it_vertically_backward): When DY == 0, make sure we get to
7565 the first character in the line after the newline.
7566
f2cad773
PE
75672011-08-27 Paul Eggert <eggert@cs.ucla.edu>
7568
7569 * ccl.c: Improve and simplify overflow checking (Bug#9196).
7570 (ccl_driver): Do not generate an out-of-range pointer.
7571 (Fccl_execute_on_string): Remove unnecessary check for
7572 integer overflow, noted by Stefan Monnier in
7573 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
7574 Remove a FIXME that didn't need fixing.
7575 Simplify the newly-introduced buffer reallocation code.
7576
0cae2cdb
JB
75772011-08-27 Juanma Barranquero <lekktu@gmail.com>
7578
7579 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
7580
5fc295a4 75812011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 7582
70c60eb2 7583 Integer and memory overflow issues (Bug#9196).
726e0ab1 7584
d31850da
PE
7585 * doc.c (get_doc_string): Rework so that
7586 get_doc_string_buffer_size is the actual buffer size, rather than
7587 being 1 less than the actual buffer size; this makes xpalloc more
7588 convenient.
7589
a69fbedb
PE
7590 * image.c (x_allocate_bitmap_record, cache_image):
7591 * xselect.c (Fx_register_dnd_atom):
7592 Simplify previous changes by using xpalloc.
7593
fe5c5d37
PE
7594 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
7595 since either will do and ptrdiff_t is convenient with xpalloc.
7596
0065d054
PE
7597 * charset.c (charset_table_size)
7598 (struct charset_sort_data.priority): Now ptrdiff_t.
7599 (charset_compare): Don't overflow if priorities differ greatly.
7600 (Fsort_charsets): Don't assume list length fits in int.
7601 Check for size-calculation overflow when allocating sort data.
7602 (syms_of_charset): Allocate an initial charset table that is
7603 just under 64 KiB, to avoid problems with glibc malloc and mmap.
7604
7605 * cmds.c (internal_self_insert): Check for size-calculation overflow.
7606
7607 * composite.h (struct composition.glyph_len): Now int, not unsigned.
7608 The actual value is always <= INT_MAX, and leaving it unsigned made
7609 overflow checking harder.
7610
7611 * dispextern.h (struct glyph_matrix.rows_allocated)
7612 (struct face_cache.size): Now ptrdiff_t, for convenience in use
7613 with xpalloc. The values are still always <= INT_MAX.
7614
7615 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
7616
7617 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
7618 (SAFE_NALLOCA): New macro.
7619
7620 * region-cache.c (struct boundary.pos, find_cache_boundary)
7621 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
7622 (set_cache_region, invalidate_region_cache)
7623 (revalidate_region_cache, know_region_cache, region_cache_forward)
7624 (region_cache_backward, pp_cache):
7625 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
7626 so that ptrdiff_t * can be passed to xpalloc.
7627 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
7628 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
7629 (pp_cache): Don't assume cache_len fits in int.
7630 * region-cache.h: Adjust extern decls to match.
7631
7632 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
7633 EMACS_INT, since either will do, for xpalloc.
7634
7635 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
7636 (xnmalloc, xnrealloc, xpalloc): New functions.
7637
726e0ab1
PE
7638 * bidi.c (bidi_shelve_header_size): New constant.
7639 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
7640 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
7641
51f30bc5 7642 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
7643 * buffer.c (overlays_at, overlays_in, record_overlay_string)
7644 (overlay_strings):
7645 Don't update size of array until after memory allocation succeeds,
7646 because xmalloc/xrealloc may not return.
0065d054
PE
7647 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
7648 now that we have proper integer overflow checking.
7649 (record_overlay_string, overlay_strings): Catch overflows when
7650 calculating size of overlay_str_buf.
726e0ab1 7651
0065d054
PE
7652 * callproc.c (Fcall_process): Check for size overflow when
7653 calculating size of args2.
7654 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
7655 Normally we prefer signed values, but sticking with ptrdiff_t would
7656 require adding more-complicated checks.
726e0ab1
PE
7657
7658 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
7659 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
7660 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 7661 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
7662
7663 * character.c (Fstring): Check for size-calculation overflow.
7664
7665 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
7666 unnecessary integer overflow. Check for size overflow.
7667 (encode_coding_object): Don't update size until xmalloc succeeds.
7668
7669 * composite.c (get_composition_id): Check for overflow in glyph
7670 length calculations.
7671
7672 Integer and memory overflow fixes for display code.
7673 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
7674 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
7675 (scrolling_window): Check for overflow in size calculations.
7676 (line_draw_cost, realloc_glyph_pool, add_row_entry):
7677 Don't assume glyph table len fits in int.
7678 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
7679 (row_table_size): Now ptrdiff_t, not int.
7680 (scrolling_window): Avoid overflow in size calculations.
7681 Don't update size until allocation succeeds.
7682 * fns.c (concat): Check for overflow in size calculations.
7683 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
7684 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7685 (NEXT_ALMOST_PRIME_LIMIT): New constant.
7686
7687 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
7688 (get_doc_string): Check for size calculation overflow.
7689 Don't update size until allocation succeeds.
7690 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
7691 EMACS_INT, where ptrdiff_t will do.
7692 (Fsubstitute_command_keys): Check for string overflow.
7693
7694 * editfns.c (set_time_zone_rule): Don't assume environment length
7695 fits in int.
7696 (message_length): Now ptrdiff_t, not int.
7697 (Fmessage_box): Don't update size until allocation succeeds.
7698 Don't assume message length fits in int.
7699 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
7700
0065d054
PE
7701 * emacs.c (main): Do not reallocate argv, since there is a null at
7702 the end that can be overwritten, and this way there's no need to
7703 worry about size-calculation overflow.
7704 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
7705
7706 * eval.c (init_eval_once, grow_specpdl): Don't update size until
7707 alloc succeeds.
7708 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
7709
7710 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
7711 (x_set_scroll_bar_width, x_figure_window_size):
7712 Check for integer overflow.
7713 (x_set_alpha): Do not assume XINT fits in int.
7714
7715 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
7716 This is for the members text_lines, text_cols, total_lines, total_cols,
7717 where the system imposes an 'int' limit.
7718
7719 * fringe.c (Fdefine_fringe_bitmap):
7720 Don't update size until alloc works.
7721
7722 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
7723 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
7724
7725 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
7726 Check for size-calculation overflow.
7727 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
7728 do, as we prefer signed integers.
7729 (id_to_widget.max_size, id_to_widget.used)
7730 (xg_store_widget_in_map, xg_remove_widget_from_map)
7731 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
7732 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
7733 Use and return ptrdiff_t, not int.
7734 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
7735 * gtkutil.h: Change prototypes to match the above.
7736
7737 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
7738 are duplicate now that they've been promoted to lisp.h.
7739 (x_allocate_bitmap_record, x_alloc_image_color)
7740 (make_image_cache, cache_image, xpm_load):
7741 Don't update size until alloc is done.
7742 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
7743 (x_detect_edges):
3256efce 7744 Check for size calculation overflow.
726e0ab1
PE
7745 (ct_colors_allocated_max): New constant.
7746 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
7747 overflow.
3256efce 7748
726e0ab1
PE
7749 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
7750 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
7751 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
7752 Use ptrdiff_t, not int, to count maps.
7753 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
7754 calculations. Don't update size until allocation succeeds.
7755 Redo calculations to avoid overflow.
726e0ab1
PE
7756 * keyboard.h: Change prototypes to match the above.
7757
7758 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
7759 to count maps.
7760 (current_minor_maps): Check for size calculation overflow.
7761 * keymap.h: Change prototypes to match the above.
7762
7763 * lread.c (read1, init_obarray): Don't update size until alloc done.
7764
7765 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
7766 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
7767
726e0ab1
PE
7768 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
7769 Now ptrdiff_t, not int.
7770 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
7771 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
7772
7773 * process.c (Fnetwork_interface_list): Check for overflow
7774 in size calculation.
7775
7776 * region-cache.c (move_cache_gap): Check for size calculation overflow.
7777
7778 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
7779 overflow. Don't bother calling xmalloc when xrealloc will do.
7780
7781 * search.c (Freplace_match): Check for size calculation overflow.
7782 (Fset_match_data): Don't assume list lengths fit in 'int'.
7783
7784 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
7785 for command line length. Do not attempt to address one before the
7786 beginning of an array, as that's not portable.
7787
7788 * term.c (max_frame_lines): Remove; unused.
7789 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
7790 not int.
7791 (encode_terminal_code, calculate_costs): Check for size
7792 calculation overflow.
7793 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
7794 table lengths and related sizes. Don't update size until alloc
7795 done. Redo calculations to avoid overflow.
7796 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
7797
7798 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
7799 subtracting pointers.
7800 (gobble_line): Check for overflow more carefully. Don't update size
7801 until alloc done.
7802
7803 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
7804 Don't update size until alloc done.
7805 Redo size calculations to avoid overflow.
7806 Check for size calculation overflow.
0065d054 7807 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
7808
7809 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
7810 Use ptrdiff_t, not int, for sizes.
7811 (store_mode_line_noprop_char): Don't update size until alloc done.
7812
0065d054
PE
7813 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
7814 Use ptrdiff_t, not int, for sizes.
7815 (Finternal_make_lisp_face, cache_face):
7816 Check for size calculation overflow.
7817 (cache_face): Treat size calculation overflows as if they were
7818 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
7819
7820 * xfns.c (x_encode_text, x_set_name_internal)
7821 (Fx_change_window_property): Use ptrdiff_t, not int, to count
7822 sizes, since they can exceed INT_MAX in size. Check for size
7823 calculation overflow.
7824
0065d054
PE
7825 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
7826 (xg_select): Check for size calculation overflow.
726e0ab1
PE
7827 Don't update size until alloc done.
7828
0065d054 7829 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 7830 as sprintf is limited to int lengths.
1d526e2f 7831
252c5ee1
PE
7832 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
7833 (X_LONG_MIN): New macros.
864d7ce7
PE
7834 Use them to make the following changes clearer.
7835 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
7836 This change doesn't affect the value now, but it may help remind
7837 future maintainers not to raise the value too much later.
7838 (SELECTION_QUANTUM): Remove, replacing with ...
7839 (selection_quantum): ... new function, which avoids overflow.
7840 All uses changed.
7841 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
7842 assumption that selection length fits in 'int'.
7843 (x_reply_selection_request, x_handle_selection_request)
7844 (x_get_window_property, receive_incremental_selection)
7845 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
7846 (lisp_data_to_selection_data, clean_local_selection_data):
7847 Use ptrdiff_t, not int, to record length of selection.
7848 (x_reply_selection_request, x_get_window_property)
7849 (receive_incremental_selection, x_property_data_to_lisp):
7850 Redo calculations to avoid overflow.
7851 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 7852 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
7853 something.
7854 (x_get_window_property, receive_incremental_selection)
7855 (lisp_data_to_selection_data, x_property_data_to_lisp):
7856 Check for size-calculation overflow.
7857 (x_get_window_property, receive_incremental_selection)
7858 (lisp_data_to_selection_data, Fx_register_dnd_atom):
7859 Don't store size until memory allocation succeeds.
7860 (x_get_window_property): Plug memory leak on memory exhaustion.
7861 Don't double-block input; malloc is safe here. Don't assume 2**34
7862 - 4 fits in unsigned long. Add an xassert to check
7863 XGetWindowProperty overflow. Be more careful about overflow
7864 calculations, and distinguish size from memory overflow better.
7865 (receive_incremental_selection): When tracing, don't assume
7866 unsigned int is less than INT_MAX.
7867 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
7868 harmful) conversions of unsigned short to int.
7869 (lisp_data_to_selection_data): Don't assume that integers
7870 in the range -65535 through -1 fit in an X unsigned short.
7871 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
7872 result parameters unless successful. Rely on cons_to_unsigned
7873 to report problems with elements; the old code wasn't right anyway.
7874 (x_check_property_data): Check for int overflow; we cannot use
7875 a wider type due to X limits.
7876 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
7877
726e0ab1 7878 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 7879
0065d054
PE
7880 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
7881 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
7882 (x_color_cells): Don't store size until memory allocation succeeds.
7883 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 7884 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
7885 (x_term_init): Don't assume length fits in int (sprintf is limited
7886 to int size).
bc18e09d 7887
ebfa62c0
PE
7888 Use ptrdiff_t for composition IDs.
7889 * character.c (lisp_string_width):
7890 * composite.c (composition_table_size, n_compositions)
7891 (get_composition_id, composition_gstring_from_id):
7892 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
7893 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
7894 * window.c (Frecenter):
7895 Use ptrdiff_t, not int, for composition IDs.
7896 * composite.c (get_composition_id): Check for integer overflow.
7897 * composite.h: Adjust prototypes to match the above changes.
7898
d3411f89
PE
7899 Use ptrdiff_t for hash table indexes.
7900 * category.c (hash_get_category_set):
7901 * ccl.c (ccl_driver):
7902 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
7903 * coding.c (coding_system_charset_list, detect_coding_system):
7904 * coding.h (struct coding_system.id):
7905 * composite.c (get_composition_id, gstring_lookup_cache):
7906 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
7907 * image.c (xpm_get_color_table_h):
7908 * lisp.h (hash_lookup, hash_put):
7909 * minibuf.c (Ftest_completion):
7910 Use ptrdiff_t for hash table indexes, not int (which is too
7911 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
7912 32-bit --with-wide-int hosts).
7913
e097a6fa
PE
7914 * charset.c (Fdefine_charset_internal): Check for integer overflow.
7915 Add a FIXME comment about memory leaks.
7916 (syms_of_charset): Don't assume xmalloc returns.
7917
5637687f
PE
7918 Don't assume that stated character widths fit in int.
7919 * character.c (Fchar_width, c_string_width, lisp_string_width):
7920 * character.h (CHAR_WIDTH):
7921 * indent.c (MULTIBYTE_BYTES_WIDTH):
7922 Use sanitize_char_width to avoid undefined and/or bad behavior
7923 with outlandish widths.
a66cfb1c 7924 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
7925 now that we have two such functions. All uses changed.
7926 (sanitize_char_width): New inline function.
7927
a2271ba2
PE
7928 Don't assume that tab-width fits in int.
7929 * character.h (sanitize_width): New inline function.
7930 (SANE_TAB_WIDTH): New macro.
7931 (ASCII_CHAR_WIDTH): Use it.
7932 * indent.c (sane_tab_width): Remove. All uses replaced by
7933 SANE_TAB_WIDTH (current_buffer).
7934 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
7935
18c52557
PE
7936 * fileio.c: Integer overflow issues with file modes.
7937 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
7938
caeeedc1
PE
7939 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
7940 Remove unreachable code.
7941 (read_hex, load_charset_map_from_file): Check for integer overflow.
7942
6df6ae42 7943 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
7944 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
7945 (x_send_scroll_bar_event): Likewise. Check that the size does not
7946 exceed limits imposed by XClientMessageEvent, as well as the usual
7947 ptrdiff_t and size_t limits.
7948
b13995db
PE
7949 * keyboard.c: Overflow, signedness and related fixes.
7950 (make_lispy_movement): Use same integer type in forward decl
7951 that is used in the definition.
7952 (read_key_sequence, keyremap_step):
7953 Change bufsize argument back to int, undoing my 2011-03-30 change.
7954 We prefer signed types, and int is wide enough here.
7955 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
7956 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
7957 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
7958 length, not size_t. Use ptrdiff_t for index, not int.
7959 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
7960 possibility of integer overflow.
7961
13464394
PE
7962 Overflow, signedness and related fixes for images.
7963
7964 * dispextern.h (struct it.stack[0].u.image.image_id)
7965 (struct_it.image_id, struct image.id, struct image_cache.size)
7966 (struct image_cache.used, struct image_cache.ref_count):
7967 * gtkutil.c (update_frame_tool_bar):
7968 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
7969 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
7970 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
7971 * nsmenu.m (update_frame_tool_bar):
7972 * xdisp.c (calc_pixel_width_or_height):
7973 * xfns.c (image_cache_refcount):
7974 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
7975 on typical 64-bit hosts.
7976
7977 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7978 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
7979 Omit unnecessary casts to int.
7980 (parse_image_spec): Check that integers fall into 'int' range
7981 when the callers expect that.
7982 (image_ascent): Redo ascent calculation to avoid int overflow.
7983 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
7984 (lookup_image): Remove unnecessary tests.
7985 (xbm_image_p): Locals are now of int, not EMACS_INT,
7986 since parse_image_check makes sure they fit into int.
7987 (png_load, gif_load, svg_load_image):
7988 Prefer int to unsigned where either will do.
7989 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
7990 old tiff_error_handler and tiff_warning_handler.
7991 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
7992 stack buffer overflows. It uses only the features of vsnprintf
7993 that are common to both POSIX and native Microsoft.
7994 (tiff_error_handler, tiff_warning_handler): Use it.
7995 (tiff_load, gif_load, imagemagick_load_image):
7996 Don't assume :index value fits in 'int'.
7997 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
7998 (imagemagick_load_image): Check that crop parameters fit into
7999 the integer types that MagickCropImage accepts. Don't assume
8000 Vimagemagick_render_type has a nonnegative value. Don't assume
8001 size_t fits in 'long'.
8002 (gs_load): Use printmax_t to print the widest integers possible.
8003 Check for integer overflow when computing image height and width.
8004
c11821d4
EZ
80052011-08-26 Eli Zaretskii <eliz@gnu.org>
8006
8007 * xdisp.c (redisplay_window): Don't force window start if point
8008 will be invisible in the resulting window. (Bug#9324)
8009
0c95fcf7
EZ
80102011-08-25 Eli Zaretskii <eliz@gnu.org>
8011
8012 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
8013 the display spec is of the form `(space ...)'.
8014 (handle_display_spec): Return the value returned by
8015 handle_single_display_spec, not just 1 or zero.
8016 (handle_single_display_spec): If the display spec is of the form
8017 `(space ...)', and specifies display in the text area, return 2
8018 rather than 1.
fee65a97 8019 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
8020 accurately, and prefer exact match for point under bidi.
8021 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
8022
8023 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
8024 into disp_prop; all users changed.
8025
8026 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
8027 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
8028 for the text covered by the display property.
8029
e4ed06f1
CY
80302011-08-25 Chong Yidong <cyd@stupidchicken.com>
8031
8032 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
8033 Change return value to nil.
8034 (Frecord_buffer): Delete unused function.
8035
f67cdd7f
EZ
80362011-08-24 Eli Zaretskii <eliz@gnu.org>
8037
5980d4c6
EZ
8038 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
8039 buffers, return left-to-right.
8610fe8b
EZ
8040 (set_cursor_from_row): Consider candidate row a win if its glyph
8041 represents a newline and point is on that newline. Fixes cursor
8042 positioning on the newline at EOL of R2L text within L2R
8043 paragraph, and vice versa.
8044 (try_cursor_movement): Check continued rows, in addition to
8045 continuation rows. Fixes unwarranted scroll when point enters a
8046 continued line of R2L text within an L2R paragraph, or vice versa.
8047 (cursor_row_p): Consider the case of point being equal to
8048 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
8049 from the end of a short line to the beginning of a continued line
8050 of R2L text within L2R paragraph.
8051 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
8052 composed characters.
5980d4c6 8053
f67cdd7f
EZ
8054 * bidi.c (bidi_check_type): Use xassert.
8055 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
8056 members.
8057
bca633fb
EZ
80582011-08-23 Eli Zaretskii <eliz@gnu.org>
8059
8060 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
8061 a character.
8062
4a5885a7
CY
80632011-08-23 Chong Yidong <cyd@stupidchicken.com>
8064
8065 * nsfont.m (ns_otf_to_script): Fix typo.
8066
0902a04e
KH
80672011-08-22 Kenichi Handa <handa@m17n.org>
8068
8069 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
8070 extra slot even if the purpose is char-code-property-table.
8071
1a2e6670
EZ
80722011-08-23 Eli Zaretskii <eliz@gnu.org>
8073
8ddde651
EZ
8074 * xdisp.c (redisplay_window): When computing centering_position,
8075 account for the height of the header line. (Bug#8874)
8076
425cc014
EZ
8077 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
8078 instead of CHAR_TO_BYTE. Fixes a crash when a completion
8079 candidate is selected by the mouse, and that candidate has a
8080 composed character under the mouse.
8081
1a2e6670
EZ
8082 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
8083 coordinates reported by pos-visible-in-window-p for a composed
8084 character in column zero.
8085
8b76d6f8
SM
80862011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
8087
8088 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
8089
dac347dd
EZ
80902011-08-22 Eli Zaretskii <eliz@gnu.org>
8091
8092 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
8093 consider it a hit if to_charpos is anywhere in the range of the
8094 composed buffer positions.
8095
e013fb34
CY
80962011-08-22 Chong Yidong <cyd@stupidchicken.com>
8097
8098 * image.c (gif_load): Don't assume that each subimage has the same
8099 dimensions as the base image. Handle disposal method that is
8100 "undefined" by the gif spec (Bug#9335).
8101
bd1ba3e8
CY
81022011-08-20 Chong Yidong <cyd@stupidchicken.com>
8103
8104 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 8105 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 8106
54a1215b
EZ
81072011-08-19 Eli Zaretskii <eliz@gnu.org>
8108
823564e5
EZ
8109 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
8110 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
8111 from an Org mode buffer to a Speedbar frame.
8112
54a1215b
EZ
8113 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
8114 a composition, take its buffer position from IT->cmp_it.charpos.
8115 Fixes cursor positioning at the beginning of a line that begins
8116 with a composed character.
8117
9778ebcc
EZ
81182011-08-18 Eli Zaretskii <eliz@gnu.org>
8119
0be6ee06
EZ
8120 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
8121 character bidirectional type, use STRONG_L instead. Fixes crashes
8122 in a buffer produced by `describe-categories'.
8123
9778ebcc
EZ
8124 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
8125 members before the level stack, so they would be saved and
8126 restored when copying iterator state. Fixes incorrect reordering
8127 around TABs covered by display properties.
8128
156bffbe
AS
81292011-08-18 Andreas Schwab <schwab@linux-m68k.org>
8130
6b02f655 8131 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 8132
72ad093b
CY
81332011-08-17 Chong Yidong <cyd@stupidchicken.com>
8134
8135 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
8136 (internal_condition_case_2, internal_condition_case_n):
8137 Remove unnecessary aborts (Bug#9081).
72ad093b 8138
35774242
EZ
81392011-08-17 Eli Zaretskii <eliz@gnu.org>
8140
8141 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
8142 has no `load' handler, try opening the file locally. (Bug#9311)
8143
db76dd85
KB
81442011-08-16 Ken Brown <kbrown@cornell.edu>
8145
8146 * gmalloc.c: Expand comment.
8147
b215eee5
EZ
81482011-08-16 Eli Zaretskii <eliz@gnu.org>
8149
8150 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
8151 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
8152
a4579d33
KB
81532011-08-16 Ken Brown <kbrown@cornell.edu>
8154
8155 Fix memory allocation problems in Cygwin build (Bug#9273).
8156
8157 * unexcw.c ( __malloc_initialized): Declare external variable.
8158 (fixup_executable): Force the dumped emacs to reinitialize malloc.
8159
8b76d6f8
SM
8160 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
8161 New variables.
a4579d33
KB
8162 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
8163 dumped emacs.
8164 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
8165 in the static heap.
8166 [CYGWIN] (special_realloc): New function.
8167 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
8168 requests to realloc storage in the static heap.
8169
3ebec551
PE
81702011-08-15 Paul Eggert <eggert@cs.ucla.edu>
8171
8172 * bidi.c (bidi_initialize): Remove unused local.
8173
9fd8be00
EZ
81742011-08-15 Eli Zaretskii <eliz@gnu.org>
8175
6b02f655
SM
8176 * bidimirror.h:
8177 * biditype.h: Remove file.
8178 * makefile.w32-in ($(BLD)/bidi.$(O)):
8179 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
8180
8181 * dispextern.h: Fix a typo in the comment to bidi_type_t.
8182
8183 * chartab.c: Improve commentary for the uniprop_table API.
8184
32413314
EZ
8185 * bidi.c (bidi_paragraph_init): Support zero value of
8186 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
8187 (bidi_initialize): Use uniprop_table instead of including
8188 biditype.h and bidimirror.h.
32413314 8189
9fd8be00
EZ
8190 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
8191 coordinates of the iterator when restoring from ppos_it.
8192 (Bug#9296)
8193
5cf2b69b
KH
81942011-08-14 Kenichi Handa <handa@m17n.org>
8195
8196 * process.c (create_process): Call setup_process_coding_systems
72ad093b 8197 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 8198
daf17d00
EZ
81992011-08-14 Eli Zaretskii <eliz@gnu.org>
8200
8201 * xdisp.c (move_it_in_display_line_to): Don't invoke
8202 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
8203 ppos_it. Fixes vertical cursor motion when line beginning is
8204 covered by an image. (Bug#9296)
8205
08e3161a
JD
82062011-08-14 Jan Djärv <jan.h.d@swipnet.se>
8207
8208 * nsterm.h (ns_run_ascript): Declare.
8209 (NSAPP_DATA2_RUNASSCRIPT): Define.
8210
8211 * nsfns.m (as_script, as_result, as_status): New static variables.
8212 (ns_run_ascript): New function.
5e617bc2 8213 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
8214 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
8215 the event loop. Get status from as_status (Bug#7276).
8216
8217 * nsterm.m (sendEvent): If event is NSApplicationDefined and
8218 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
8219 the event loop (Bug#7276).
8220
a3720aa2
AS
82212011-08-14 Andreas Schwab <schwab@linux-m68k.org>
8222
8223 * gnutls.c (QCgnutls_bootprop_priority)
8224 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
8225 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
8226 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
8227 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
8228 (QCgnutls_bootprop_verify_hostname_error)
8229 (QCgnutls_bootprop_callbacks_verify): Rename from
8230 Qgnutls_bootprop_..., all uses changed.
8231
8232 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
8233 uses changed.
8234
0a0d27fb
PE
82352011-08-14 Paul Eggert <eggert@cs.ucla.edu>
8236
19d5c50c
PE
8237 * xfaces.c (Qframe_set_background_mode): Now static.
8238 * dispextern.h (Qframe_set_background_mode): Remove decl.
8239
0a0d27fb
PE
8240 * process.c (Fnetwork_interface_info): Declare local only if needed.
8241
377538cb
JD
82422011-08-13 Jan Djärv <jan.h.d@swipnet.se>
8243
8244 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
8245 (Fnetwork_interface_list): Allocate in increments of bytes instead
8246 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
8247 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
8248 sockaddr.
8249 (struct ifflag_def): notrailers is smart on OSX.
8250 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
8251 Get hardware address with getifaddrs if available.
8252
08fff70c
EZ
82532011-08-12 Eli Zaretskii <eliz@gnu.org>
8254
8255 * xdisp.c (iterate_out_of_display_property): xassert that
8256 IT->position is set to within IT->object's boundaries. Break from
8257 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
8258 when IT->position is set up wrongly due to some bug.
8259 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
8260 (push_display_prop): Allow GET_FROM_STRING as IT->method on
8261 entry. Force push_it to save on the stack the current
8262 buffer/string position, to be restored by pop_it. Fix flags in
8263 the iterator structure wrt the object coming from a display
8264 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
8265 properties. (Bug#9284)
8266
7be1c708 82672011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 8268
7be1c708
CY
8269 * fontset.c (fontset_get_font_group): Add proper type checks.
8270 (Bug#9172)
aac0c6e3 8271
7be1c708 82722011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 8273
7be1c708
CY
8274 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
8275 and LC_VERSION_MIN_MACOSX.
8276 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
8277 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 8278
97bb72a6
EZ
82792011-08-08 Eli Zaretskii <eliz@gnu.org>
8280
8281 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
8282 no-display-properties-and-no-overlays under bidi display.
8283 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 8284 properties and overlays.
97bb72a6 8285
d5617611
CY
82862011-08-08 Chong Yidong <cyd@stupidchicken.com>
8287
37e11a63
CY
8288 * editfns.c (Fset_time_zone_rule): Document relationship with the
8289 setenv function.
8290
d5617611
CY
8291 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
8292 the font entity extracted from the cache (Bug#8109).
8293
58872834
CY
82942011-08-07 Chong Yidong <cyd@stupidchicken.com>
8295
8296 * composite.c (autocmp_chars): Don't reset point. That is done by
8297 restore_point_unwind (Bug#5984).
8298
75bfc667
JL
82992011-08-07 Juri Linkov <juri@jurta.org>
8300
8301 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
8302 to show the arg `TIME' instead of `TIMEVAL'.
8303
d1410150
EZ
83042011-08-06 Eli Zaretskii <eliz@gnu.org>
8305
8306 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
8307 display property strides EOL and includes a newline, as in
8308 longlines-mode. (Bug#9254)
75b771e4
EZ
8309 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
8310 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
8311
8312 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
8313 is non-zero, even if the data buffer is NULL. Fixes a crash in
8314 vertical-motion with longlines-mode. (Bug#9254)
8315
35928349
EZ
83162011-08-05 Eli Zaretskii <eliz@gnu.org>
8317
ec7cc85b
EZ
8318 * bidi.c <bidi_cache_total_alloc>: Now static.
8319 (bidi_initialize): Initialize bidi_cache_total_alloc.
8320
8b76d6f8 8321 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
8322 cache. (Bug#9221)
8323
8324 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
8325 amount allocated this far in `bidi_cache_total_alloc'.
8326 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
8327 non-zero, only free the data buffer without restoring the cache
8328 contents. All callers changed.
8329
8330 * dispextern.h (bidi_unshelve_cache): Update prototype.
8331
8332 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
8333 (move_it_in_display_line, move_it_to)
8334 (move_it_vertically_backward, move_it_by_lines): Replace the call
8335 to xfree to an equivalent call to bidi_unshelve_cache.
8336 (move_it_in_display_line_to): Fix logic of returning
412b6358 8337 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 8338
e2e2423b
EZ
83392011-08-05 Eli Zaretskii <eliz@gnu.org>
8340
8341 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
8342 came from a string character with a `cursor' property. (Bug#9229)
8343
ae9e757a
JD
83442011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8345
8346 * Makefile.in (LIB_PTHREAD): New variable.
8347 (LIBES): Add LIB_PTHREAD (Bug#9216).
8348
8349 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
8350 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
8351
213bd7f2
AS
83522011-08-04 Andreas Schwab <schwab@linux-m68k.org>
8353
6b02f655 8354 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 8355
99aaf75f
JD
83562011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8357
8358 * xterm.c (x_find_topmost_parent): New function.
8359 (x_set_frame_alpha): Find topmost parent window with
8360 x_find_topmost_parent and set the property there also (bug#9181).
8361 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
8362
c74e9d86
PE
83632011-08-04 Paul Eggert <eggert@cs.ucla.edu>
8364
8365 * callproc.c (Fcall_process): Avoid vfork clobbering
8366 the local vars buffer, coding_systems, current_dir.
8367
640c8776
SM
83682011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
8369
8370 * keymap.c (Fmake_composed_keymap): Move to subr.el.
8371
f26d0e4c
PE
83722011-08-03 Paul Eggert <eggert@cs.ucla.edu>
8373
8a10d76c
PE
8374 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
8375 so that it is not optimized away.
8376
f26d0e4c
PE
8377 * xdisp.c (compute_display_string_pos): Remove unused local.
8378
55439c61
EZ
83792011-08-02 Eli Zaretskii <eliz@gnu.org>
8380
8381 Fix slow cursor motion and scrolling in large buffers with
8382 selective display, like Org Mode buffers. (Bug#9218)
8383
8384 * dispextern.h (struct bidi_it): New member disp_prop_p.
8385
8386 * xdisp.c: Remove one-slot cache of display string positions.
8387 (compute_display_string_pos): Accept an additional argument
5e617bc2 8388 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
8389 for a display string or property. If found, set DISP_PROP_P
8390 non-zero.
8391
8392 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
8393 DISP_PROP_P, and pass it to compute_display_string_pos.
8394 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
8395 non-zero. All callers of bidi_fetch_char changed.
8396
fb33fa43
SM
83972011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
8398
8399 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
8400
b099e063
DM
84012010-12-03 Don March <don@ohspite.net>
8402
8403 * keymap.c (Fdefine_key): Fix non-prefix key error message when
8404 last character M-[char] is translated to ESC [char] (bug#7541).
8405
5cc7f7af
KH
84062011-08-02 Kenichi Handa <handa@m17n.org>
8407
d0fffa3f 8408 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
8409
8410 * chartab.c (uniprop_table): Make it non-static.
8411
525d5e6e
EZ
84122011-08-01 Eli Zaretskii <eliz@gnu.org>
8413
8414 * xdisp.c (forward_to_next_line_start): Accept additional argument
8415 BIDI_IT_PREV, and store into it the state of the bidi iterator had
8416 on the newline.
8417 (reseat_at_next_visible_line_start): Use the bidi iterator state
8418 returned by forward_to_next_line_start to restore the state of
8419 it->bidi_it after backing up to previous newline. (Bug#9212)
8420
31011111
AS
84212011-07-30 Andreas Schwab <schwab@linux-m68k.org>
8422
8423 * regex.c (re_comp): Protoize.
8424 (re_exec): Fix return type.
8425 (regexec): Fix type of `ret'. (Bug#9203)
8426
476371c4
PE
84272011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8428
e5d76069
PE
8429 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
8430 This is needed if max-image-size is a floating-point number.
8431
9a79b20c
AS
84322011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8433
8434 * print.c (print_object): Print empty symbol as ##.
8435
8436 * lread.c (read1): Read ## as empty symbol.
8437
d8c2fa78
AA
84382011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
8439
8440 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
8441 setting frame foreground color (Bug#9175).
8442 (x_set_background_color): Likewise.
8443
ffe57a7a
AA
8444 * nsmenu.m (-setText): Size tooltip dimensions precisely to
8445 contents (Bug#9176).
8446 (EmacsTooltip -init): Remove bezels and add shadows to
8447 tooltip windows.
8448
bf3492a5
AA
8449 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
8450 or scroll bar (Bug#8470).
8451
d55e9c53
AA
8452 * nsfont.m (nsfont_open): Remove assignment to voffset and
8453 unnecessary vars hshink, expand, hd, full_height, min_height.
8454 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
8455
8456 * nsterm.h (nsfont_info): Remove voffset field.
8457
d8c2fa78 84582011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
8459
8460 Implement strike-through and overline on NextStep (Bug#8863).
8461
8462 * nsfont.m (nsfont_open): Use underline position provided by font,
8463 instead of hard-coded value of 2.
8464 (nsfont_draw): Call ns_draw_text_decoration instead.
8465
8466 * nsterm.h: Add declaration for ns_draw_text_decoration.
8467
8468 * nsterm.m (ns_draw_text_decoration): New function for drawing
8469 underline, overline, and strike-through.
8470 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
8471 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 8472 accommodate underlining, etc.
4843aac3 8473
4cc60b9b
EZ
84742011-07-28 Eli Zaretskii <eliz@gnu.org>
8475
bc7ece87
EZ
8476 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
8477 default.
4cc60b9b 8478
476371c4
PE
84792011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8480
66606eea
PE
8481 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
8482 Without this fix, if a signal arrives just after memory fills up,
8483 'malloc' might be invoked reentrantly.
8484
476371c4
PE
8485 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
8486 In other words, assume that every image size is allowed, on non-X
8487 hosts. This assumption is probably wrong, but it lets Emacs compile.
8488
f3fcc40d
AS
84892011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8490
8491 * regex.c (re_iswctype): Convert return values to boolean.
8492
350c992f
EZ
84932011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
8494
8495 * xdisp.c (compute_display_string_pos): Don't use cached display
8496 string position if the buffer had its restriction changed.
8497 (Bug#9184)
8498
5266b4bb
PE
84992011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8500
8501 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8502
2573a837 85032011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 8504
41f55ccd 8505 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 8506
39e378da
PE
8507 * bidi.c: Integer size and overflow fixes.
8508 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
8509 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
8510 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8511 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
8512 (bidi_find_other_level_edge):
8513 Use ptrdiff_t instead of EMACS_INT where either will do.
8514 This works better on 32-bit hosts configured --with-wide-int.
8515 (bidi_cache_ensure_space): Check for size-calculation overflow.
8516 Use % rather than repeated addition, for better worst-case speed.
8517 Don't set bidi_cache_size until after xrealloc returns, because it
8518 might not return.
8519 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
8520 (bidi_cache_ensure_space): Also check that the bidi cache size
8521 does not exceed that of the largest Lisp string or buffer. See Eli
8522 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 8523
5e927815
PE
8524 * alloc.c (__malloc_size_t): Remove.
8525 All uses replaced by size_t. See Andreas Schwab's note
8526 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
8527
ca4aa935
PE
8528 * image.c: Improve checking for integer overflow.
8529 (check_image_size): Assume that f is nonnull, since
8530 it is always nonnull in practice. This is one less thing to
8531 worry about when checking for integer overflow later.
8532 (x_check_image_size): New function, which checks for integer
8533 overflow issues inside X.
8534 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
8535 This removes the need for a memory_full check.
8536 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
8537 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
8538 (xbm_read_bitmap_data): Change locals back to 'int', since
8539 their values must fit in 'int'.
8540 (xpm_load_image, png_load, tiff_load):
8541 Invoke x_create_x_image_and_pixmap earlier,
8542 to avoid much needless work if the image is too large.
8543 (tiff_load): Treat overly large images as if
8544 x_create_x_image_and_pixmap failed, not as malloc failures.
8545 (gs_load): Use x_check_image_size.
8546
5f8f9cc2
PE
8547 * gtkutil.c: Omit integer casts.
8548 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
8549 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
8550
5adf60bc
PE
8551 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
8552
c8907a93
PE
8553 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
8554 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
8555 would wrongly return t on a 64-bit host.
8556
e3c25c68
PE
8557 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
8558 The plain *_OVERFLOW macros run afoul of GCC bug 49705
8559 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
8560 and therefore cause GCC to emit a bogus diagnostic in some cases.
8561
3f791afe
PE
8562 * image.c: Integer signedness and overflow and related fixes.
8563 This is not an exhaustive set of fixes, but it's time to
8564 record what I've got.
8565 (lookup_pixel_color, check_image_size): Remove redundant decls.
8566 (check_image_size): Don't assume that arbitrary EMACS_INT values
8567 fit in 'int', or that arbitrary 'double' values fit in 'int'.
8568 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
8569 (tiff_load, imagemagick_load_image):
8570 Check for overflow in size calculations.
8571 (x_create_x_image_and_pixmap): Remove unnecessary test for
8572 xmalloc returning NULL; that can't happen.
8573 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
8574 (xpm_color_bucket): Use better integer hashing function.
8575 (xpm_cache_color): Don't possibly over-allocate memory.
8576 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
8577 (gif_memory_source):
8578 Use ptrdiff_t, not int or size_t, to record sizes.
8579 (png_load): Don't assume values greater than 2**31 fit in 'int'.
8580 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
8581 either works, as we prefer signed integers.
8582 (tiff_read_from_memory, tiff_write_from_memory):
8583 Return tsize_t, not size_t, since that's what the TIFF API wants.
8584 (tiff_read_from_memory): Don't fail simply because the read would
8585 go past EOF; instead, return a short read.
8586 (tiff_load): Omit no-longer-needed casts.
8587 (Fimagemagick_types): Don't assume size fits into 'int'.
8588
3cc5a532
PE
8589 Improve hashing quality when configured --with-wide-int.
8590 * fns.c (hash_string): New function, taken from sxhash_string.
8591 Do not discard information about ASCII character case; this
8592 discarding is no longer needed.
8593 (sxhash-string): Use it. Change sig to match it. Caller changed.
8594 * lisp.h: Declare it.
8595 * lread.c (hash_string): Remove, since we now use fns.c's version.
8596 The fns.c version returns a wider integer if --with-wide-int is
8597 specified, so this should help the quality of the hashing a bit.
8598
b312a492
PE
8599 * emacs.c: Integer overflow minor fix.
8600 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
8601 Define only if GNU_LINUX.
8602 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
8603
dfd153ae
PE
8604 * dispnew.c: Integer signedness and overflow fixes.
8605 Remove unnecessary forward decls, that were a maintenance hassle.
8606 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
8607 All uses changed.
8608 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
8609 (scrolling_window): Use ptrdiff_t, not int, for byte count.
8610 (prepare_desired_row, line_draw_cost):
8611 Use int, not unsigned, where either works.
8612 (save_current_matrix, restore_current_matrix):
8613 Use ptrdiff_t, not size_t, where either works.
8614 (init_display): Check for overflow more accurately, and without
8615 relying on undefined behavior.
8616
a81d11a3
PE
8617 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
8618 Remove, replacing with the new symbols in lisp.h. All uses changed.
8619 * fileio.c (make_temp_name):
8620 * filelock.c (lock_file_1, lock_file):
8621 * xdisp.c (message_dolog):
8622 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
8623 Use pMd etc. instead.
8624 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
8625 replacing the pWIDE etc. symbols removed from editfns.c.
8626
3300e6fd
PE
8627 * keyboard.h (num_input_events): Now uintmax_t.
8628 This is (very slightly) less likely to mess up due to wraparound.
8629 All uses changed.
8630
fd05c7e9
PE
8631 * buffer.c: Integer signedness fixes.
8632 (alloc_buffer_text, enlarge_buffer_text):
8633 Use ptrdiff_t rather than size_t when either will do, as we prefer
8634 signed integers.
8635
903fe15d
PE
8636 * alloc.c: Integer signedness and overflow fixes.
8637 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
8638 (__malloc_size_t): Default to size_t, not to int.
8639 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
8640 (Fgarbage_collect, mark_object_loop_halt, mark_object):
8641 Prefer ptrdiff_t to size_t when either would do, as we prefer
8642 signed integers.
8643 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
8644 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
8645 Now const. Initialize with values that are in range even if char
8646 is signed.
8647 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
8648 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
8649 These functions do the right thing with sizes > 2**32.
8650 (check_depth): Now ptrdiff_t, not int.
8651 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
8652 Adjust to new way of storing sizes. Check for size overflow bugs
8653 in rest of code.
8654 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
8655 slightly wrong anyway, as it missed one instance of
8656 XMALLOC_OVERRUN_CHECK_OVERHEAD.
8657 (refill_memory_reserve): Omit needless cast to size_t.
8658 (mark_object_loop_halt): Mark as externally visible.
8659
ac82cc6a
PE
8660 * xselect.c: Integer signedness and overflow fixes.
8661 (Fx_register_dnd_atom, x_handle_dnd_message):
8662 Use ptrdiff_t, not size_t, since we prefer signed.
8663 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
8664 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
8665 x_dnd_atoms_size and x_dnd_atoms_length.
8666
c2d1e36d
PE
8667 * doprnt.c: Prefer signed to unsigned when either works.
8668 * eval.c (verror):
8669 * doprnt.c (doprnt):
8670 * lisp.h (doprnt):
8671 * xdisp.c (vmessage):
8672 Use ptrdiff_t, not size_t, when using or implementing doprnt,
8673 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
8674 prefer signed arithmetic to avoid comparison confusion.
8675 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
8676 but is a bit tricky.
8677
0e926e56
PE
8678 Assume freestanding C89 headers, string.h, stdlib.h.
8679 * data.c, doprnt.c, floatfns.c, print.c:
8680 Include float.h unconditionally.
8681 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
8682 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
8683 * regex.c: Likewise for stddef.h, string.h.
8684 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
8685 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
8686 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
8687 (STDC_HEADERS): Remove obsolete defines.
8688 * sysdep.c: Include limits.h unconditionally.
8689
9cfdb3ec
PE
8690 Assume support for memcmp, memcpy, memmove, memset.
8691 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
8692 * regex.c (memcmp, memcpy):
8693 Remove; we assume C89 now.
8694
8695 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
8696 (__malloc_safe_bcopy): Remove; no longer needed.
8697
cf950e6b 8698 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
8699 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
8700 well either way, and we prefer signed to unsigned.
8701
dbf38e02
LMI
87022011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
8703
8704 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
8705 closes the connection while we're reading (bug#9182).
8706
d6f0886c 87072011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 8708
d6f0886c
JD
8709 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
8710 are specified (Bug#9168).
24e0f6b1 8711
2eb1f9e6
PE
87122011-07-25 Paul Eggert <eggert@cs.ucla.edu>
8713
8714 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
8715 Found by GCC static checking and --with-wide-int on a 32-bit host.
8716
22381272 87172011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
8718
8719 * xdisp.c (compute_display_string_pos): Fix logic of caching
8720 previous display string position. Initialize cached_prev_pos to
8721 -1. Fixes slow-down at the beginning of a buffer.
8722
f25e39b4
EZ
87232011-07-24 Eli Zaretskii <eliz@gnu.org>
8724
8725 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
8726 for attrs[LFACE_FONTSET_INDEX].
8727
04c4b52e
PE
87282011-07-23 Paul Eggert <eggert@cs.ucla.edu>
8729
8730 * xml.c (parse_region): Remove unused local
8731 that was recently introduced.
8732
c1734fbd
EZ
87332011-07-23 Eli Zaretskii <eliz@gnu.org>
8734
be18c5a5
EZ
8735 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
8736 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
8737
c1734fbd
EZ
8738 * xdisp.c (move_it_in_display_line_to): Record the best matching
8739 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
8740 exit if none of the characters scanned was an exact match.
8741 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
8742 when exact match is impossible due to invisible text, and the
8743 lines are truncated.
8744
a258d627
JD
87452011-07-23 Jan Djärv <jan.h.d@swipnet.se>
8746
8747 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
8748 for OSX >= 10.7.
8749
b6d5a689
EZ
87502011-07-22 Eli Zaretskii <eliz@gnu.org>
8751
0f74f785
EZ
8752 Fix a significant slow-down of cursor motion with C-n, C-p,
8753 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
8754 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 8755 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
8756 (next_element_from_buffer): Call compute_stop_pos_backwards to
8757 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
8758 base_level_stop.
8759 (reseat): Don't look for prev_stop, as that could mean a very long
8760 run.
8761 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
8762 <cached_disp_overlay_modiff>: Cache for last found display string
8763 position.
551918c1 8764 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
8765 about the same buffer in the same area of character positions, and
8766 the buffer wasn't changed since the time the display string
8767 position was cached.
551918c1 8768
b2d0c91a
EZ
87692011-07-22 Eli Zaretskii <eliz@gnu.org>
8770
8771 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
8772 is an integer, which is important for empty lines. (Bug#9149)
8773
043604ee
CY
87742011-07-22 Chong Yidong <cyd@stupidchicken.com>
8775
8776 * frame.c (Fmodify_frame_parameters): In tty case, update the
8777 default face if necessary (Bug#4238).
8778
da4adb04
CY
87792011-07-21 Chong Yidong <cyd@stupidchicken.com>
8780
8781 * editfns.c (Fstring_to_char): No need to explain what a character
8782 is in the docstring (Bug#6576).
8783
9abd0532
LMI
87842011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8785
8786 * xml.c (parse_region): Make sure we always return a tree.
8787
36881d16
HK
87882011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
8789
8790 * xml.c (parse_region): If a document contains only comments,
8791 return that, too.
8792
1e98674d
LMI
87932011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8794
8795 * xml.c (make_dom): Return comments, too.
8796
590bd467
PE
87972011-07-19 Paul Eggert <eggert@cs.ucla.edu>
8798
8799 Port to OpenBSD.
8800 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
8801 and the surrounding thread.
8802 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
8803 rather than fgets, and retry after EINTR. Otherwise, 'emacs
8804 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
8805 timer goes off.
8806 * s/openbsd.h (BROKEN_SIGIO): Define.
8807 * unexelf.c (unexec) [__OpenBSD__]:
8808 Don't update the .mdebug section of the Alpha COFF symbol table.
8809
f41628b2
LMI
88102011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
8811
8812 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
8813 (bug#8460).
8814
b59b67c5
PE
88152011-07-18 Paul Eggert <eggert@cs.ucla.edu>
8816
15e3a074
PE
8817 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
8818 This fixes some race conditions on the permissions of any newly
8819 created file.
8820
41bed37d
PE
8821 * alloc.c (valid_pointer_p): Use pipe, not open.
8822 This fixes some permissions issues when debugging.
8823
b59b67c5
PE
8824 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
8825 If fchown fails to set both uid and gid, try to set just gid,
8826 as that is sometimes allowed. Adjust the file's mode to eliminate
8827 setuid or setgid bits that are inappropriate if fchown fails.
8828
925a6be7
SM
88292011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
8830
8831 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
8832 to compare Lisp_Objects.
8833 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
8834 global_gnutls_log_level, don't mistake it for a Lisp_Object.
8835 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
8836
52968808
AS
88372011-07-17 Andreas Schwab <schwab@linux-m68k.org>
8838
0a6a104b
AS
8839 * lread.c (read_integer): Unread even EOF character.
8840 (read1): Likewise. Properly record start position of symbol.
8841
52968808
AS
8842 * lread.c (read1): Read `#:' as empty uninterned symbol if no
8843 symbol character follows.
8844
9e381cdd
PE
88452011-07-17 Paul Eggert <eggert@cs.ucla.edu>
8846
8847 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
8848 This works around a problem with the previous change to Fcopy_file.
8849 Recent glibc declares fchown with __attribute__((warn_unused_result)),
8850 and without this change, GCC might complain about discarding
8851 fchown's return value.
8852
b5641435
JB
88532011-07-16 Juanma Barranquero <lekktu@gmail.com>
8854
8855 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
8856
a8031457
PE
88572011-07-16 Paul Eggert <eggert@cs.ucla.edu>
8858
8859 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
8860
dd889327
LMI
88612011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
8862
750c33f7
LMI
8863 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
8864 it's used from the C level.
8865
dd889327
LMI
8866 * process.c: Use the same condition for POLL_FOR_INPUT in both
8867 keyboard.c and process.c (bug#1858).
8868
87e86684
LM
88692011-07-09 Lawrence Mitchell <wence@gmx.li>
8870
8871 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
8872 (Fgnutls_boot): Use it.
8873
64348f40
AS
88742011-07-15 Andreas Schwab <schwab@linux-m68k.org>
8875
8876 * doc.c (Fsubstitute_command_keys): Revert last change.
8877
1d698799
LMI
88782011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
8879
f863868c
LMI
8880 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
8881 quotes the next character, and doesn't affect other longer
8882 sequences (bug#8935).
8883
1d698799
LMI
8884 * lread.c (syms_of_lread): Clarify that is isn't only
8885 `eval-buffer' and `eval-defun' that's affected by
8886 `lexical-binding' (bug#8460).
8887
aa4b6df6
EZ
88882011-07-15 Eli Zaretskii <eliz@gnu.org>
8889
8890 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 8891 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 8892
5d856da6
PE
88932011-07-14 Paul Eggert <eggert@cs.ucla.edu>
8894
ad6042bb
PE
8895 Fix minor problems found by static checking.
8896 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
8897 (elsz): Now a signed constant, not a size_t var. We prefer signed
8898 types to unsigned, to avoid integer comparison confusion. Without
8899 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
8900 "cannot optimize loop, the loop counter may overflow", a symptom
8901 of the confusion.
f00bbb22 8902 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
8903 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
8904
6468f31c
LMI
89052011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8906
49080b10
LMI
8907 * search.c (Fre_search_backward): Mention `case-fold-search' in
8908 all the re_search_* functions (bug#8138).
8909
6468f31c
LMI
8910 * keyboard.c (Fopen_dribble_file): Document when the file is
8911 closed (bug#8056).
8912
c965adc5
EZ
89132011-07-14 Eli Zaretskii <eliz@gnu.org>
8914
df9733bf
EZ
8915 * bidi.c (bidi_dump_cached_states): Fix format of displaying
8916 bidi_cache_idx.
8917
0bb23927
EZ
8918 Support bidi reordering of display and overlay strings.
8919 * xdisp.c (compute_display_string_pos)
8920 (compute_display_string_end): Accept additional argument STRING.
8921 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
8922 (reseat_to_string): Initialize bidi_it->string.s and
8923 bidi_it->string.schars.
8924 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
8925 NULL (avoids a crash in bidi_paragraph_init).
8926 Initialize itb.string.lstring.
0bb23927
EZ
8927 (init_iterator): Call bidi_init_it only of a valid
8928 buffer position was specified. Initialize paragraph_embedding to
8929 L2R.
8930 (reseat_to_string): Initialize the bidi iterator.
8931 (display_string): If we need to ignore text properties of
8932 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
8933 original value of -1 will not work with bidi.)
8934 (compute_display_string_pos): First arg is now struct
8935 `text_pos *'; all callers changed. Support display properties on
8936 Lisp strings.
8937 (compute_display_string_end): Support display properties on Lisp
8938 strings.
8939 (init_iterator, reseat_1, reseat_to_string): Initialize the
8940 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
8941 when iterating on a string not from display properties).
640c8776
SM
8942 (compute_display_string_pos, compute_display_string_end):
8943 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
8944 arrow keys.
8945 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
8946 base_level_stop; instead, set base_level_stop to BEGV.
8947 Fixes crashes in vertical-motion.
0bb23927
EZ
8948 (next_element_from_buffer): Improve commentary for when
8949 the iterator is before prev_stop.
8950 (init_iterator): Initialize bidi_p from the default value of
8951 bidi-display-reordering, not from buffer-local value. Use the
8952 buffer-local value only if initializing for buffer iteration.
8953 (handle_invisible_prop): Support invisible properties on strings
8954 that are being bidi-reordered.
8955 (set_iterator_to_next): Support bidi reordering of C strings and
8956 Lisp strings.
8957 (next_element_from_string): Support bidi reordering of Lisp
8958 strings.
8959 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
8960 (display_string): Support display of R2L glyph rows.
8961 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
8962 (init_iterator): Don't initialize it->bidi_p for strings
8963 here.
8964 (reseat_to_string): Initialize it->bidi_p for strings here.
8965 (next_element_from_string, next_element_from_c_string)
8966 (next_element_from_buffer): Add xassert's for correspondence
8967 between IT's object being iterated and it->bidi_it.string
8968 structure.
8969 (face_before_or_after_it_pos): Support bidi iteration.
8970 (next_element_from_c_string): Handle the case of the first string
8971 character that is not the first one in the visual order.
8972 (get_visually_first_element): New function, refactored from common
8973 parts of next_element_from_buffer, next_element_from_string, and
8974 next_element_from_c_string.
8975 (tool_bar_lines_needed, redisplay_tool_bar)
8976 (display_menu_bar): Force left-to-right direction. Add a FIXME
8977 comment for making that be controlled by a user option.
8978 (push_it, pop_it): Save and restore the state of the
8979 bidi iterator. Save and restore the bidi_p flag.
8980 (pop_it): Iterate out of display property for string iteration as
8981 well.
8982 (iterate_out_of_display_property): Support iteration over strings.
8983 (handle_single_display_spec): Set up it->bidi_it for iteration
8984 over a display string, and call bidi_init_it.
8985 (handle_single_display_spec, next_overlay_string)
8986 (get_overlay_strings_1, push_display_prop): Set up the bidi
8987 iterator for displaying display or overlay strings.
8988 (forward_to_next_line_start): Don't use the shortcut if
8989 bidi-iterating.
8990 (back_to_previous_visible_line_start): If handle_display_prop
8991 pushed the iterator stack, restore the internal state of the bidi
8992 iterator by calling bidi_pop_it same number of times.
8993 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
8994 and we are bidi-iterating, don't decrement the iterator position;
8995 instead, set the first_elt flag in the bidi iterator, to produce
8996 the same effect.
8997 (reseat_1): Remove redundant setting of string_from_display_prop_p.
8998 (push_display_prop): xassert that we are iterating a buffer.
8999 (push_it, pop_it): Save and restore paragraph_embedding member.
9000 (handle_single_display_spec, next_overlay_string)
9001 (get_overlay_strings_1, reseat_1, reseat_to_string)
9002 (push_display_prop): Set up the `unibyte' member of bidi_it.string
9003 correctly. Don't assume unibyte strings are not bidi-reordered.
9004 (compute_display_string_pos)
9005 (compute_display_string_end): Fix handling the case of C string.
9006 (push_it, pop_it): Save and restore from_disp_prop_p.
9007 (handle_single_display_spec, push_display_prop): Set the
9008 from_disp_prop_p flag.
9009 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
9010 (pop_it): Call iterate_out_of_display_property only if we are
9011 popping after iteration over a string that came from a display
9012 property. Fix a typo in popping stretch info. Add an assertion
9013 for verifying that the iterator position is in sync with the bidi
9014 iterator.
9015 (handle_single_display_spec, get_overlay_strings_1)
9016 (push_display_prop): Fix initialization of paragraph direction for
9017 string when that of the parent object is not yet determined.
9018 (reseat_1): Call bidi_init_it to resync the bidi
9019 iterator with IT's position. (Bug#7616)
9020 (find_row_edges): If ROW->start.pos gives position
9021 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
9022 (handle_stop, back_to_previous_visible_line_start, reseat_1):
9023 Reset the from_disp_prop_p flag.
9024 (SAVE_IT, RESTORE_IT): New macros.
9025 (pos_visible_p, face_before_or_after_it_pos)
9026 (back_to_previous_visible_line_start)
9027 (move_it_in_display_line_to, move_it_in_display_line)
9028 (move_it_to, move_it_vertically_backward, move_it_by_lines)
9029 (try_scrolling, redisplay_window, display_line): Use them when
9030 saving a temporary copy of the iterator and restoring it back.
9031 (back_to_previous_visible_line_start, reseat_1)
9032 (init_iterator): Empty the bidi cache "stack".
9033 (move_it_in_display_line_to): If iterator ended up at
9034 EOL, but we never saw any buffer positions smaller than
9035 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
9036 motion in bidi-reordered lines.
9037 (move_it_in_display_line_to): Record prev_method and prev_pos
9038 immediately before the call to set_iterator_to_next. Fixes cursor
9039 motion in bidi-reordered lines with stretch glyphs and strings
9040 displayed in margins. (Bug#8133) (Bug#8867)
9041 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
9042 TO_CHARPOS.
640c8776
SM
9043 (pos_visible_p): Support positions in bidi-reordered lines.
9044 Save and restore bidi cache.
0bb23927
EZ
9045
9046 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
9047 (bidi_paragraph_info): Delete unused struct.
9048 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
9049 (bidi_cache_start): New variable.
9050 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
9051 to zero.
9052 (bidi_cache_fetch_state, bidi_cache_search)
9053 (bidi_cache_find_level_change, bidi_cache_iterator_state)
9054 (bidi_cache_find, bidi_peek_at_next_level)
9055 (bidi_level_of_next_char, bidi_find_other_level_edge)
9056 (bidi_move_to_visually_next): Compare cache index with
9057 bidi_cache_start rather than with zero.
9058 (bidi_fetch_char): Accept new argument STRING; all callers
9059 changed. Support iteration over a string. Support strings with
9060 display properties. Support unibyte strings. Fix the type of
9061 `len' according to what STRING_CHAR_AND_LENGTH expects.
9062 (bidi_paragraph_init, bidi_resolve_explicit_1)
9063 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
9064 (bidi_level_of_next_char, bidi_move_to_visually_next):
9065 Support iteration over a string.
0bb23927
EZ
9066 (bidi_set_sor_type, bidi_resolve_explicit_1)
9067 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
9068 can now be zero (for strings); special values 0 and -1 were
9069 changed to -1 and -2, respectively.
9070 (bidi_char_at_pos): New function.
9071 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
9072 Call it instead of FETCH_MULTIBYTE_CHAR.
9073 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
9074 initialized to valid values.
9075 (bidi_init_it): Don't initialize charpos and bytepos with invalid
9076 values.
9077 (bidi_level_of_next_char): Allow the sentinel "position" to pass
9078 the test for valid cached positions. Fix the logic for looking up
9079 the sentinel state in the cache. GCPRO the Lisp string we are
9080 iterating.
9081 (bidi_push_it, bidi_pop_it): New functions.
9082 (bidi_initialize): Initialize the bidi cache start stack pointer.
9083 (bidi_cache_ensure_space): New function, refactored from part of
9084 bidi_cache_iterator_state. Don't assume the required size is just
9085 one BIDI_CACHE_CHUNK away.
9086 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
9087 (bidi_count_bytes, bidi_char_at_pos): New functions.
9088 (bidi_cache_search): Don't assume bidi_cache_last_idx is
9089 always valid if bidi_cache_idx is valid.
9090 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
9091 is valid if it's going to be used.
9092 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
9093 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
9094 (bidi_cache_find_level_change, bidi_cache_ensure_space)
9095 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
9096 (bidi_find_other_level_edge, bidi_cache_start_stack):
9097 All variables related to cache indices are now EMACS_INT.
c965adc5 9098
0bb23927
EZ
9099 * dispextern.h (struct bidi_string_data): New structure.
9100 (struct bidi_it): New member `string'. Make flag members be 1-bit
9101 fields, and put them last in the struct.
640c8776
SM
9102 (compute_display_string_pos, compute_display_string_end):
9103 Update prototypes.
0bb23927
EZ
9104 (bidi_push_it, bidi_pop_it): Add prototypes.
9105 (struct iterator_stack_entry): New members bidi_p,
9106 paragraph_embedding, and from_disp_prop_p.
9107 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
9108 (bidi_shelve_cache, bidi_unshelve_cache):
9109 Declare prototypes.
0bb23927
EZ
9110
9111 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
9112 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
9113 and vector-like objects.
9114
9115 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
9116 cache around display iteration.
9117
9118 * window.c (Fwindow_end, window_scroll_pixel_based)
9119 (displayed_window_lines, Frecenter): Save and restore the bidi
9120 cache around display iteration.
9121
3bbd2265
LMI
91222011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
9123
9124 * editfns.c (Fdelete_region): Clarify the use of the named
9125 parameters (bug#6788).
9126
adc47434
MR
91272011-07-14 Martin Rudalics <rudalics@gmx.at>
9128
9129 * indent.c (Fvertical_motion): Set and restore w->pointm when
9130 saving and restoring the window's buffer (Bug#9006).
9131
837c31f8
LMI
91322011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
9133
9134 * editfns.c (Fstring_to_char): Clarify just what is returned
9135 (bug#6576). Text by Eli Zaretskii.
9136
ac389d0c
JB
91372011-07-13 Juanma Barranquero <lekktu@gmail.com>
9138
9139 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
9140
0be0ce47
EZ
91412011-07-13 Eli Zaretskii <eliz@gnu.org>
9142
9143 * buffer.c (mmap_find): Fix a typo.
9144
cd18e7e3
JB
91452011-07-13 Johan Bockgård <bojohan@gnu.org>
9146
9147 Fix execution of x selection hooks.
9148 * xselect.c (Qx_lost_selection_functions)
9149 (Qx_sent_selection_functions): New vars.
9150 (syms_of_xselect): DEFSYM them.
9151 (x_handle_selection_request): Pass Qx_sent_selection_functions
9152 rather than Vx_sent_selection_functions to Frun_hook_with_args.
9153 (x_handle_selection_clear,x_clear_frame_selections):
9154 Pass Qx_lost_selection_functions rather than
9155 Vx_lost_selection_functions to Frun_hook_with_args.
9156
47ea7f44
PE
91572011-07-13 Paul Eggert <eggert@cs.ucla.edu>
9158
ac389d0c 9159 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
9160 The old code sometimes used this field without initializing it.
9161
47ea7f44
PE
9162 * alloc.c (gc_sweep): Don't read past end of array.
9163 In theory, the old code could also have corrupted Emacs internals,
9164 though it'd be very unlikely.
9165
bc985c87
AS
91662011-07-12 Andreas Schwab <schwab@linux-m68k.org>
9167
9168 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 9169 argument. (Bug#4026)
bc985c87 9170
0cf34688
LMI
91712011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
9172
b3dadd76
LMI
9173 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
9174 key" (bug#4257).
9175
0cf34688
LMI
9176 * window.c (Fset_window_start): Doc fix (bug#4199).
9177 (Fset_window_hscroll): Ditto.
9178
270768cd
PE
91792011-07-12 Paul Eggert <eggert@cs.ucla.edu>
9180
077e3dda 9181 Fix minor new problems caught by GCC 4.6.1.
270768cd 9182 * term.c (init_tty): Remove unused local.
490011a6 9183 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 9184 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 9185 not used otherwise.
270768cd 9186
b1f58454
CY
91872011-07-12 Chong Yidong <cyd@stupidchicken.com>
9188
9189 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
9190
22b9578d
LMI
91912011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
9192
6e70ab07
LMI
9193 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
9194 are the mini-buffer and the echo area (bug#3320).
9195
22b9578d
LMI
9196 * term.c (init_tty): Remove support for supdup, c10 and perq
9197 terminals, which are no longer supported (bug#1482).
9198
8974cc9f
JB
91992011-07-10 Johan Bockgård <bojohan@gnu.org>
9200
9201 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
9202
a560d974
JD
92032011-07-10 Jan Djärv <jan.h.d@swipnet.se>
9204
9205 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
9206 for non-popups (Bug#3642).
9207
1dae0f0a
AS
92082011-07-10 Andreas Schwab <schwab@linux-m68k.org>
9209
268c2c36 9210 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 9211 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
9212 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
9213 * cm.c (losecursor): Likewise.
1dae0f0a
AS
9214 * data.c (fmod): Likewise.
9215 * dispnew.c (swap_glyphs_in_rows): Likewise.
9216 * emacs.c (memory_warning_signal): Likewise.
9217 * floatfns.c (float_error): Likewise.
9218 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
9219 (otf_open, font_otf_capability, generate_otf_features)
9220 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
9221 Likewise.
9222 * image.c (pbm_read_file): Likewise.
9223 * indent.c (string_display_width): Likewise.
9224 * intervals.c (check_for_interval, search_for_interval)
9225 (inc_interval_count, count_intervals, root_interval)
9226 (adjust_intervals_for_insertion, make_new_interval): Likewise.
9227 * lread.c (defalias): Likewise.
268c2c36 9228 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
9229 * regex.c (set_image_of_range_1, set_image_of_range)
9230 (regex_grow_registers): Likewise.
9231 * sysdep.c (strerror): Likewise.
9232 * termcap.c (valid_filename_p, tprint, main): Likewise.
9233 * tparam.c (main): Likewise.
9234 * unexhp9k800.c (run_time_remap, save_data_space)
9235 (update_file_ptrs, read_header, write_header, calculate_checksum)
9236 (copy_file, copy_rest, display_header): Likewise.
9237 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
9238 Likewise.
9239 * xdisp.c (check_it): Likewise.
9240 * xfaces.c (register_color, unregister_color, unregister_colors):
9241 Likewise.
9242 * xfns.c (print_fontset_result): Likewise.
9243 * xrdb.c (member, fatal, main): Likewise.
9244
99033785
PE
92452011-07-10 Paul Eggert <eggert@cs.ucla.edu>
9246
9247 Fix minor problems found by static checking (Bug#9031).
9248 * chartab.c (char_table_set_range, map_sub_char_table):
9249 Remove unused locals.
9250 (uniprop_table): Now static.
9251 * composite.c (_work_char): Remove unused static var.
9252
9cb2ac56
JB
92532011-07-09 Juanma Barranquero <lekktu@gmail.com>
9254
9255 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
9256
f25661f0
JD
92572011-07-09 Jan Djärv <jan.h.d@swipnet.se>
9258
9259 * gtkutil.c (qttip_cb): Remove code without function.
9260
8278c4fe
EZ
92612011-07-09 Eli Zaretskii <eliz@gnu.org>
9262
9263 * w32.c (pthread_sigmask): New stub.
9264
1692ae2d 92652011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 9266
8a6ebd58 9267 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
9268 sigprocmask is portable only for single-threaded applications, and
9269 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
9270 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
9271 (LIBES): Use it.
9272 * callproc.c (Fcall_process):
9273 * process.c (create_process):
9274 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
9275 Use pthread_sigmask, not sigprocmask.
123403e4 9276
1b854618
JD
92772011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9278
9279 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
9280 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
9281 wrong (Bug#8591).
9282
3fe4b549
JD
92832011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9284
0ce7e563
JD
9285 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
9286 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
9287 (xg_hide_tooltip): Fix comment.
9288
3fe4b549
JD
9289 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
9290 in registerServicesMenuSendTypes.
9291 (validRequestorForSendType): Don't check ns_return_types.
9292
9293 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
9294 ns_return_type.
9295
5df75e47
JR
92962011-07-08 Jason Rumney <jasonr@gnu.org>
9297
22610910
JR
9298 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
9299 SH_SHOW for hidden windows (Bug#5482).
9300
5df75e47
JR
9301 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
9302 frame struct members of non-existent frames (Bug#6284).
9303
699c10bd
JD
93042011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9305
4393663b
JD
9306 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
9307 variable firstTime not needed on OSX >= 10.6.
9308 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
9309 >= 10.5. Use setKnobProportion, setDoubleValue.
9310
9311 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
9312 (MAC_OS_X_VERSION_10_5): Define if not defined.
9313 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
9314 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
9315 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
9316
9317 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 9318 cString and lossyCString on OSX >= 10.4.
4393663b 9319
58179cce 9320 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
9321 sizeToFit on OSX >= 10.2.
9322
9323 * nsimage.m (allocInitFromFile): Don't use deprecated method
9324 bestRepresentationForDevice on OSX >= 10.6.
9325
9326 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
9327 to avoid warning.
9328
9329 * emacs.c: Declare unexec_init_emacs_zone.
9330
a63e0781
JD
9331 * nsgui.h: Fix compiler warning about gnulib redefining verify.
9332
699c10bd
JD
9333 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
9334
9335 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
9336 on svcsMenu (Bug#8842).
9337
9338 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
9339 ns_return_types.
9340 (Fns_list_services): Just return Qnil on 10.6, code not working there.
9341
9342 * nsterm.m (QUTF8_STRING): Declare.
9343 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
9344 (validRequestorForSendType): Return type is (id).
9345 Change indexOfObjectIdenticalTo to indexOfObject.
9346 Check if we have local selection before returning self (Bug#8842).
9347 (writeSelectionToPasteboard): Put local selection into paste board
9348 if we have a local selection (Bug#8842).
9349 (syms_of_nsterm): DEFSYM QUTF8_STRING.
9350
9351 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
9352 (ns_get_local_selection): Declare.
9353
54e10184
LMI
93542011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
9355
9888ff71
LMI
9356 * keymap.c (describe_map_tree): Don't insert a double newline at
9357 the end of the buffer (bug#1169) and return whether we inserted
9358 something.
9359
54e10184
LMI
9360 * callint.c (Fcall_interactively): Change "reading args" to
9361 "providing args" to try to clarify what it does (bug#1010).
9362
15fa4783
KH
93632011-07-07 Kenichi Handa <handa@m17n.org>
9364
9365 * composite.c (composition_compute_stop_pos): Ignore a static
9366 composition starting before CHARPOS (Bug#8915).
9367
9368 * xdisp.c (handle_composition_prop): Likewise.
9369
a8815b00
EZ
93702011-07-07 Eli Zaretskii <eliz@gnu.org>
9371
9372 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
9373 (Bug#9015)
9374
ef7b981d 93752011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
9376
9377 * character.h (unicode_category_t): New enum type.
9378
9379 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
9380 (Qchar_code_property_table): New variable.
9381 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
9382 (UNIPROP_COMPRESSED_FORM_P): New macros.
9383 (char_table_ascii): Uncompress the compressed values.
9384 (sub_char_table_ref): New arg is_uniprop. Callers changed.
9385 Uncompress the compressed values.
ac389d0c 9386 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
9387 (char_table_ref_and_range): Uncompress the compressed values.
9388 (sub_char_table_set): New arg is_uniprop. Callers changed.
9389 Uncompress the compressed values.
9390 (sub_char_table_set_range): Args changed. Callers changed.
9391 (char_table_set_range): Adjuted for the above change.
9392 (map_sub_char_table): Delete args default_val and parent. Add arg
9393 top. Give decoded values to a Lisp function.
640c8776 9394 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
9395 values to a Lisp function. Gcpro more variables.
9396 (uniprop_table_uncompress)
9397 (uniprop_decode_value_run_length): New functions.
9398 (uniprop_decoder, uniprop_decoder_count): New variables.
9399 (uniprop_get_decoder, uniprop_encode_value_character)
9400 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
9401 New functions.
9402 (uniprop_encoder, uniprop_encoder_count): New variables.
9403 (uniprop_get_encoder, uniprop_table)
9404 (Funicode_property_table_internal, Fget_unicode_property_internal)
9405 (Fput_unicode_property_internal): New functions.
9406 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
9407 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 9408 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
9409 char-code-property-alist.
9410
640c8776 9411 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
9412 Vunicode_category_table.
9413
640c8776 9414 * font.c (font_range): Adjust for the change of
c805dec0
KH
9415 Vunicode_category_table.
9416
76b397fb
DN
94172011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
9418
9419 * m/iris4d.h: Remove file, move contents ...
9420 * s/irix6-5.h: ... here.
9421
22b4128e
PE
94222011-07-06 Paul Eggert <eggert@cs.ucla.edu>
9423
9424 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
9425 * alloc.c (mark_buffer):
9426 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
9427 (clone_per_buffer_values): Don't assume that
22b4128e
PE
9428 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
9429 This isn't true in general, and it's particularly not true
9430 if Emacs is configured with --with-wide-int.
9431 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
9432 New macros, used in the buffer.c change.
9433
869795d6
JD
94342011-07-05 Jan Djärv <jan.h.d@swipnet.se>
9435
9436 * xsettings.c: Use both GConf and GSettings if both are available.
9437 (store_config_changed_event): Add comment.
9438 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
9439 (store_tool_bar_style_changed): New functions.
5e617bc2 9440 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
9441 (struct xsettings): Move font inside HAVE_XFT.
9442 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 9443 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 9444 Move inside HAVE_XFT.
640c8776 9445 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
9446 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
9447 also.
9448 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 9449 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 9450 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
9451 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
9452 (parse_settings): Move check for font inside HAVE_XFT.
9453 (read_settings, apply_xft_settings): Add comment.
9454 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
9455 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
9456 call store_font_name_changed.
9457 (xft_settings_event): Add comment.
9458 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
9459 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
9460 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
9461 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
9462 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
9463 (xsettings_get_system_font, xsettings_get_system_normal_font):
9464 Add comment.
869795d6 9465
d8ed26bd
PE
94662011-07-05 Paul Eggert <eggert@cs.ucla.edu>
9467
9468 Random fixes. E.g., (random) never returned negative values.
9469 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
9470 subseconds part to the entropy, as that's a bit more random.
9471 Prefer signed to unsigned, since the signedness doesn't matter and
9472 in general we prefer signed. When given a limit, use a
9473 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
9474 latter isn't right if USE_2_TAGS_FOR_INTS.
9475 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
9476 not 0..VALMASK. Don't discard "excess" bits that random () returns.
9477
cabf1cac
SM
94782011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
9479
9480 * textprop.c (text_property_stickiness):
9481 Obey Vtext_property_default_nonsticky.
9482 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
9483 * w32fns.c (syms_of_w32fns):
9484 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
9485
6e9b2be9
PE
94862011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9487
9488 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
9489 This is more efficient than Ffile_directory_p and avoids a minor race.
9490
90186c68
LMI
94912011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
9492
7c301272
LMI
9493 * buffer.c (Foverlay_put): Say what the return value is
9494 (bug#7835).
9495
c4f2d8d4
LMI
9496 * fileio.c (barf_or_query_if_file_exists): Check first if the file
9497 is a directory before asking whether to use the file name
9498 (bug#7564).
ad637907
LMI
9499 (barf_or_query_if_file_exists): Make the "File is a directory"
9500 error be more correct.
c4f2d8d4 9501
90186c68
LMI
9502 * fns.c (Frequire): Remove the mention of the .gz files, since
9503 that's installation-specific, but keep the mention of
9504 `get-load-suffixes'.
9505
da64016e
PE
95062011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9507
9508 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
9509 Report string overflow if the output is too long.
9510
7d47b580
JB
95112011-07-04 Juanma Barranquero <lekktu@gmail.com>
9512
a555cb87
JB
9513 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
9514 (syms_of_gnutls): Remove duplicate DEFSYM for
9515 Qgnutls_bootprop_verify_hostname_error, an error for
9516 Qgnutls_bootprop_verify_error (which is no longer used).
9517
7d47b580
JB
9518 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
9519 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
9520 Also (re)move comments that are misplaced or no longer relevant.
9521
1e49bfab
LMI
95222011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9523
9524 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
9525
1485f4c0
CY
95262011-07-03 Chong Yidong <cyd@stupidchicken.com>
9527
9528 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
9529 and background color parameters if they have been changed.
9530
a9ab721e
LMI
95312011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9532
9533 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
9534
cf7cff57
PE
95352011-07-03 Paul Eggert <eggert@cs.ucla.edu>
9536
2e13213d
PE
9537 * xsettings.c (SYSTEM_FONT): Define only when used.
9538 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
9539
cf7cff57
PE
9540 * keymap.c (access_keymap_1): Now static.
9541
7a8e04f7
CY
95422011-07-02 Chong Yidong <cyd@stupidchicken.com>
9543
9544 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
9545 leave any prefix arg for the up event (Bug#1586).
9546
61352f62
LMI
95472011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
9548
69bb1ef7
LMI
9549 * lread.c (syms_of_lread): Mention single symbols defined by
9550 `defvar' or `defconst' (bug#7154).
9551
61352f62 9552 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 9553 (Frequire): Mention get-load-suffixes.
61352f62 9554
28545e04
MR
95552011-07-02 Martin Rudalics <rudalics@gmx.at>
9556
9557 * window.h (window): Remove clone_number slot.
9558 * window.c (Fwindow_clone_number, Fset_window_clone_number):
9559 Remove.
9560 (make_parent_window, make_window, saved_window)
9561 (Fset_window_configuration, save_window_save): Don't deal with
9562 clone numbers.
9563 * buffer.c (Qclone_number): Remove declaration.
9564 (sort_overlays, overlay_strings): Don't deal with clone numbers.
9565
3349e122
SM
95662011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
9567
9568 Add multiple inheritance to keymaps.
9569 * keymap.c (Fmake_composed_keymap): New function.
9570 (Fset_keymap_parent): Simplify.
9571 (fix_submap_inheritance): Remove.
9572 (access_keymap_1): New function extracted from access_keymap to handle
9573 embedded parents and handle lists of maps.
9574 (access_keymap): Use it.
9575 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
9576 (Fcopy_keymap): Handle embedded parents.
9577 (Fcommand_remapping, define_as_prefix): Simplify.
9578 (Fkey_binding): Simplify.
9579 (syms_of_keymap): Move minibuffer-local-completion-map,
9580 minibuffer-local-filename-completion-map,
9581 minibuffer-local-must-match-map, and
9582 minibuffer-local-filename-must-match-map to Elisp.
9583 (syms_of_keymap): Defsubr make-composed-keymap.
9584 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
9585 (parse_menu_item): Trivial simplification.
9586
3279eb87
GM
95872011-07-01 Glenn Morris <rgm@gnu.org>
9588
9589 * Makefile.in (SETTINGS_LIBS): Fix typo.
9590
4550efdf
KI
95912011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
9592
9593 * coding.c (Fencode_coding_string): Record the last coding system
9594 used, as the function doc string says (bug#8738).
9595
0949d2b6
JD
95962011-07-01 Jan Djärv <jan.h.d@swipnet.se>
9597
9598 * xsettings.c (store_monospaced_changed): Take new font as arg and
9599 check for change against current_mono_font.
9600 (EMACS_TYPE_SETTINGS): Remove this and related defines.
9601 (emacs_settings_constructor, emacs_settings_get_property)
9602 (emacs_settings_set_property, emacs_settings_class_init)
9603 (emacs_settings_init, gsettings_obj): Remove.
9604 (something_changedCB): New function for HAVE_GSETTINGS.
9605 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
9606 with value as argument.
9607 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
9608 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 9609 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
9610 "changed".
9611
9612 * xgselect.c: Add defined (HAVE_GSETTINGS).
9613 (xgselect_initialize): Ditto.
9614
9615 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
9616 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
9617 xg_select.
9618
bbc6b304
PE
96192011-07-01 Paul Eggert <eggert@cs.ucla.edu>
9620
9621 * eval.c (struct backtrace): Simplify and port the data structure.
9622 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
9623 signed bit field, as this assumption is not portable and it makes
9624 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
9625 "char debug_on_exit : 1" as this is not portable either; instead,
9626 use the portable "unsigned int debug_on_exit : 1". Remove unused
9627 member evalargs. Remove obsolete comments about cc bombing out.
9628
9851bfc5
JD
96292011-06-30 Jan Djärv <jan.h.d@swipnet.se>
9630
51bb811f 9631 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
9632 Let HAVE_GSETTINGS override HAVE_GCONF.
9633 (store_monospaced_changed): New function.
9634 (EMACS_SETTINGS): A new type derived from GObject to handle
9635 GSettings notifications.
9636 (emacs_settings_constructor, emacs_settings_get_property)
9637 (emacs_settings_set_property, emacs_settings_class_init):
9638 New functions.
9639 (gsettings_client, gsettings_obj): New variables.
9640 (GSETTINGS_SCHEMA): New define.
9641 (something_changedCB): Call store_monospaced_changed.
9642 (init_gsettings): New function.
9643 (xsettings_initialize): Call init_gsettings.
9644 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
9645 to NULL.
9646
640c8776 9647 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
9648 GCONF_CFLAGS/LIBS.
9649
5386012d
MR
96502011-06-29 Martin Rudalics <rudalics@gmx.at>
9651
9652 * window.c (resize_root_window, grow_mini_window)
9653 (shrink_mini_window): Rename Qresize_root_window to
9654 Qwindow_resize_root_window and Qresize_root_window_vertically to
9655 Qwindow_resize_root_window_vertically.
9656
f13e0b08
PE
96572011-06-28 Paul Eggert <eggert@cs.ucla.edu>
9658
9659 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
9660
94515237
JB
96612011-06-27 Juanma Barranquero <lekktu@gmail.com>
9662
9663 * makefile.w32-in: Redesign dependencies so they reflect more
9664 clearly which files are directly included by each source file,
9665 and not through other includes.
9666
e43b6e43
MR
96672011-06-27 Martin Rudalics <rudalics@gmx.at>
9668
9669 * buffer.c (Qclone_number): Declare static and DEFSYM it.
9670 (sort_overlays, overlay_strings): When an overlay's clone number
9671 matches the window's clone number process the overlay even if
9672 the overlay's window property doesn't match the current window.
9673
d68443dc
MR
9674 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
9675 (Fwindow_hchild): Rename to Fwindow_left_child.
9676 (Fwindow_next): Rename to Fwindow_next_sibling.
9677 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
9678 (resize_window_check): Rename to window_resize_check.
9679 (resize_window_apply): Rename to window_resize_apply.
9680 (Fresize_window_apply): Rename to Fwindow_resize_apply.
9681 (Fdelete_other_windows_internal, resize_frame_windows)
9682 (Fsplit_window_internal, Fdelete_window_internal)
9683 (grow_mini_window, shrink_mini_window)
9684 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 9685
c7e73be5
JD
96862011-06-26 Jan Djärv <jan.h.d@swipnet.se>
9687
9688 * emacsgtkfixed.h: State that this is only used with Gtk+3.
9689 (emacs_fixed_set_min_size): Remove.
9690 (emacs_fixed_new): Take frame as argument.
9691
9692 * emacsgtkfixed.c: State that this is only used with Gtk+3.
9693 (_EmacsFixedPrivate): Remove minwidth/height.
9694 Add struct frame *f.
9695 (emacs_fixed_init): Initialize priv->f.
9696 (get_parent_class, emacs_fixed_set_min_size): Remove.
9697 (emacs_fixed_new): Set priv->f to argument.
9698 (emacs_fixed_get_preferred_width)
9699 (emacs_fixed_get_preferred_height): Use min_width/height from
9700 frames size_hint to set minimum and natural (Bug#8919).
9701 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
9702 and use min_width/height from frames size_hint to set
9703 min_width/height (Bug#8919).
9704
9705 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
9706 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
9707 Fix indentation.
c7e73be5 9708
cf99dcf8
EZ
97092011-06-26 Eli Zaretskii <eliz@gnu.org>
9710
9711 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
9712 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
9713 called at ZV.
9714
029529ac
CY
97152011-06-26 Chong Yidong <cyd@stupidchicken.com>
9716
9717 * process.c (wait_reading_process_output): Bypass select if
9718 waiting for a cell while ignoring keyboard input, and input is
9719 pending. Suggested by Jan Djärv (Bug#8869).
9720
7a7ef429
PE
97212011-06-25 Paul Eggert <eggert@cs.ucla.edu>
9722
9723 Use gnulib's dup2 module instead of rolling our own.
9724 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
9725
11fdef7d 97262011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
9727
9728 * dispnew.c (scrolling_window): Before scrolling, turn off a
9729 mouse-highlight in the window being scrolled.
9730
cd3520a4
JB
97312011-06-24 Juanma Barranquero <lekktu@gmail.com>
9732
9733 Move DEFSYM to lisp.h and use everywhere.
9734
9735 * character.h (DEFSYM): Move declaration...
9736 * lisp.h (DEFSYM): ...here.
9737
9738 * gnutls.c:
9739 * minibuf.c:
9740 * w32menu.c:
9741 * w32proc.c:
9742 * w32select.c: Don't include character.h.
9743
9744 * alloc.c (syms_of_alloc):
9745 * buffer.c (syms_of_buffer):
9746 * bytecode.c (syms_of_bytecode):
9747 * callint.c (syms_of_callint):
9748 * casefiddle.c (syms_of_casefiddle):
9749 * casetab.c (init_casetab_once):
9750 * category.c (init_category_once, syms_of_category):
9751 * ccl.c (syms_of_ccl):
9752 * cmds.c (syms_of_cmds):
9753 * composite.c (syms_of_composite):
9754 * dbusbind.c (syms_of_dbusbind):
9755 * dired.c (syms_of_dired):
9756 * dispnew.c (syms_of_display):
9757 * doc.c (syms_of_doc):
9758 * editfns.c (syms_of_editfns):
9759 * emacs.c (syms_of_emacs):
9760 * eval.c (syms_of_eval):
9761 * fileio.c (syms_of_fileio):
9762 * fns.c (syms_of_fns):
9763 * frame.c (syms_of_frame):
9764 * fringe.c (syms_of_fringe):
9765 * insdel.c (syms_of_insdel):
9766 * keymap.c (syms_of_keymap):
9767 * lread.c (init_obarray, syms_of_lread):
9768 * macros.c (syms_of_macros):
9769 * msdos.c (syms_of_msdos):
9770 * print.c (syms_of_print):
9771 * process.c (syms_of_process):
9772 * search.c (syms_of_search):
9773 * sound.c (syms_of_sound):
9774 * syntax.c (init_syntax_once, syms_of_syntax):
9775 * terminal.c (syms_of_terminal):
9776 * textprop.c (syms_of_textprop):
9777 * undo.c (syms_of_undo):
9778 * w32.c (globals_of_w32):
9779 * window.c (syms_of_window):
9780 * xdisp.c (syms_of_xdisp):
9781 * xfaces.c (syms_of_xfaces):
9782 * xfns.c (syms_of_xfns):
9783 * xmenu.c (syms_of_xmenu):
9784 * xsettings.c (syms_of_xsettings):
9785 * xterm.c (syms_of_xterm): Use DEFSYM.
9786
4228cf16
TZ
97872011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
9788
cd3520a4 9789 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 9790
7fcccf1e
PE
97912011-06-23 Paul Eggert <eggert@cs.ucla.edu>
9792
7efb4e0e
PE
9793 Integer and buffer overflow fixes (Bug#8873).
9794
ff5844ad
PE
9795 * print.c (printchar, strout): Check for string overflow.
9796 (PRINTPREPARE, printchar, strout):
9797 Don't set size unless allocation succeeds.
9798
90532f02
PE
9799 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
9800 for sizes. Check for string overflow more accurately.
9801 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
9802
6d84508d
PE
9803 * macros.c: Integer and buffer overflow fixes.
9804 * keyboard.h (struct keyboard.kbd_macro_bufsize):
9805 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
9806 Use ptrdiff_t, not int, for sizes.
9807 Don't increment bufsize until after realloc succeeds.
9808 Check for size-calculation overflow.
9809 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
9810
437b2cb4
PE
9811 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
9812
8b9ac8b4
PE
9813 * lread.c: Integer overflow fixes.
9814 (read_integer): Radix is now EMACS_INT, not int,
9815 to improve quality of diagnostics for out-of-range radices.
9816 Calculate buffer size correctly for out-of-range radices.
9817 (read1): Check for integer overflow in radices, and in
9818 read-circle numbers.
82cb60d3
PE
9819 (read_escape): Avoid int overflow.
9820 (Fload, openp, read_buffer_size, read1)
9821 (substitute_object_recurse, read_vector, read_list, map_obarray):
9822 Use ptrdiff_t, not int, for sizes.
9823 (read1): Use EMACS_INT, not int, for sizes.
20270765 9824 Check for size overflow.
8b9ac8b4 9825
7fcccf1e
PE
9826 * image.c (cache_image): Check for size arithmetic overflow.
9827
bfbbd7e7
PE
9828 * lread.c: Integer overflow issues.
9829 (saved_doc_string_size, saved_doc_string_length)
9830 (prev_saved_doc_string_size, prev_saved_doc_string_length):
9831 Now ptrdiff_t, not int.
9832 (read1): Don't assume doc string length fits in int. Check for
9833 out-of-range doc string lengths.
9834 (read_list): Don't assume file position fits in int.
39019e54 9835 (read_escape): Check for hex character overflow.
bfbbd7e7 9836
4e323265
LL
98372011-06-22 Leo Liu <sdl.web@gmail.com>
9838
9839 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
9840 Move to minibuffer.el.
9841
85fece3e
PE
98422011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9843
20b84ce9 9844 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
9845 The following patches are for when GLYPH_DEBUG && !XASSERT.
9846 * dispextern.h (trace_redisplay_p, dump_glyph_string):
9847 * dispnew.c (flush_stdout):
9848 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
9849 Mark as externally visible.
9850 * dispnew.c (check_window_matrix_pointers): Now static.
9851 * dispnew.c (window_to_frame_vpos):
9852 * xfns.c (unwind_create_frame):
9853 * xterm.c (x_check_font): Remove unused local.
9854 * scroll.c (CHECK_BOUNDS):
9855 * xfaces.c (cache_fache): Rename local to avoid shadowing.
9856 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
9857 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
9858 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
9859 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
9860 Now static.
9861 (debug_method_add): Use va_list and vsprintf rather than relying
9862 on undefined behavior with wrong number of arguments.
9863 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
9864 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
9865 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
9866 since we're not interested in debugging glyphs with old libraries.
9867 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
9868 GCC 4.6.0's static checking.
9869
0766b489
PE
98702011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9871
31fd4b32
PE
9872 Integer overflow and signedness fixes (Bug#8873).
9873 A few related buffer overrun fixes, too.
9874
b79e8648
PE
9875 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
9876
0766b489
PE
9877 * dispextern.h (struct face.stipple):
9878 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
9879 (x_bitmap_mask, x_allocate_bitmap_record)
9880 (x_create_bitmap_from_data, x_create_bitmap_from_file)
9881 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
9882 (x_create_bitmap_from_xpm_data):
9883 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
9884 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
9885 (.bitmaps_last):
9886 * xfaces.c (load_pixmap):
9887 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
9888 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
9889 (.bitmaps_last, struct x_output.icon_bitmap):
9890 Use ptrdiff_t, not int, for bitmap indexes.
9891 (x_allocate_bitmap_record): Check for size overflow.
9892 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
9893
b081724f
PE
9894 Use ptrdiff_t, not int, for overlay counts.
9895 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
9896 * editfns.c (overlays_around, get_pos_property):
9897 * textprop.c (get_char_property_and_overlay):
9898 * xdisp.c (next_overlay_change, note_mouse_highlight):
9899 * xfaces.c (face_at_buffer_position):
21514da7
PE
9900 * buffer.c (OVERLAY_COUNT_MAX): New macro.
9901 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
9902 (Fnext_overlay_change, Fprevious_overlay_change)
9903 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 9904 Use ptrdiff_t, not int, for sizes.
21514da7 9905 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 9906
3de73e5e
PE
9907 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
9908
2606c57b
PE
9909 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
9910 (x_session_initialize): Do not assume string length fits in int.
9911
aaafe47a
PE
9912 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
9913 This is unlikely, but can occur if DPI is outlandish.
9914
2674ddc8 9915 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
9916 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
9917
28154962
PE
9918 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
9919 * xrdb.c (magic_file_p, search_magic_path):
9920 Omit last arg SUFFIX; it was always 0. All callers changed.
9921 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
9922
7de51af5
PE
9923 * xfont.c (xfont_match): Avoid need for strlen.
9924
25ed6cc3
PE
9925 * xfns.c: Don't assume strlen fits in int.
9926 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
9927
4eab31dd
PE
9928 * xdisp.c (message_log_check_duplicate): Return intmax_t,
9929 not unsigned long, as we prefer signed integers. All callers changed.
9930 Detect integer overflow in repeat count.
9931 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 9932 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 9933
171e2a58
PE
9934 * termcap.c: Don't assume sizes fit in int and never overflow.
9935 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
9936 (gobble_line): Check for size-calculation overflow.
9937
ad39faca 9938 * minibuf.c (Fread_buffer):
6e5bb2dc 9939 * lread.c (intern, intern_c_string):
74ca2eb3
PE
9940 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
9941 Don't assume string length fits in int.
9942
52c61c22 9943 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
9944 * gtkutil.c (style_changed_cb): Avoid need for strlen.
9945
b5b8c9e5
PE
9946 * font.c: Don't assume string length fits in int.
9947 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
9948 Use ptrdiff_t, not int.
ccd6111c
PE
9949 (font_intern_prop): Don't assume string length fits in int.
9950 Don't assume integer property fits in fixnum.
9951 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 9952
882f0d81 9953 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 9954 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
9955 Reformulate so as not to need the command string.
9956 Invoke gzip -cd rather than gunzip, as it's more portable.
9957 (lock_info_type, lock_file_1, lock_file):
9958 Don't assume pid_t and time_t fit in unsigned long.
9959 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
9960 (current_lock_owner): Prefer signed type for sizes.
9961 Use memcpy, not strncpy, where memcpy is what is really wanted.
9962 Don't assume (via atoi) that time_t and pid_t fit in int.
9963 Check for time_t and/or pid_t out of range, e.g., via a network share.
9964 Don't alloca where an auto var works fine.
9965
93f4cf88
PE
9966 * fileio.c: Fix some integer overflow issues.
9967 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
9968 Don't assume string length fits in int.
9969 (directory_file_name): Don't assume string length fits in long.
9970 (make_temp_name): Don't assume pid fits in int, or that its print
9971 length is less than 20.
9972
f3e92b69
PE
9973 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
9974
1bfdaf10
PE
9975 * coding.c (make_subsidiaries): Don't assume string length fits in int.
9976
35016e9a
PE
9977 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
9978
3d1e65a1
PE
9979 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
9980 We prefer signed integers, even for size calculations.
9981
0b963a93
PE
9982 * emacs.c: Don't assume string length fits in 'int'.
9983 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
9984 (main): Don't invoke strlen when not needed.
9985
573f4b54
PE
9986 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
9987 (XD_DEBUG_MESSAGE): Don't waste a byte.
9988
989f33ba
PE
9989 * callproc.c (getenv_internal_1, getenv_internal)
9990 (Fgetenv_internal):
965d34eb
PE
9991 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
9992
e4d29b33
PE
9993 * lread.c (invalid_syntax): Omit length argument.
9994 All uses changed. This doesn't fix a bug, but it simplifies the
9995 code away from its former Hollerith-constant appearance, and it's
9996 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 9997 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 9998
eb49b136
PE
9999 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
10000 This didn't break anything, but it didn't help either.
10001 It's confusing to put a bogus integer in a place where the actual
10002 value does not matter.
9f62aeb1 10003 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 10004 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 10005
15375a22
PE
10006 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
10007 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
10008 implementation.
b61cc01c
PE
10009 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
10010 We prefer signed types, and the value cannot exceed the EMACS_INT
10011 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
10012 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
10013 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
10014 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 10015
53b2623d
PE
10016 * indent.c (sane_tab_width): New function.
10017 (current_column, scan_for_column, Findent_to, position_indentation)
10018 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 10019 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 10020
51cab52b 10021 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 10022
f2ed8a70
PE
10023 * lisp.h (lint_assume): New macro.
10024 * composite.c (composition_gstring_put_cache):
10025 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
10026
abe80cc6
PE
10027 * editfns.c, insdel.c:
10028 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 10029
b02c740e
PE
10030 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
10031
ebc96716
PE
10032 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
10033
b4e50fa0 10034 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 10035 Use much-faster test for byte-length change.
311d5d7c 10036 Don't assume string byte-length fits in 'int'.
a4cf38e4 10037 Check that character arg fits in 'int'.
85461888 10038 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 10039
c0c1ee9f
PE
10040 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
10041
a498d7f4
PE
10042 * fns.c (concat): Catch string overflow earlier.
10043 Do not rely on integer wraparound.
10044
51cab52b
PE
10045 * dispextern.h (struct it.overlay_strings_charpos)
10046 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
10047 * xdisp.c (forward_to_next_line_start)
10048 (back_to_previous_visible_line_start)
10049 (reseat_at_next_visible_line_start, next_element_from_buffer):
10050 Don't arbitrarily truncate the value of 'selective' to int.
10051
76031fad
PE
10052 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
10053
5eb55db9
PE
10054 * composite.c: Don't truncate sizes to 'int'.
10055 (composition_gstring_p, composition_reseat_it)
10056 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
10057 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
10058 not EMACS_UINT, for indexes.
5eb55db9 10059
0703a717
PE
10060 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
10061
d6202519
PE
10062 * buffer.c: Include <verify.h>.
10063 (struct sortvec.priority, struct sortstr.priority):
8961a454 10064 Now EMACS_INT, not int.
c20998a7 10065 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
10066 (struct sortstr.size, record_overlay_string)
10067 (struct sortstrlist.size, struct sortlist.used):
10068 Don't truncate size to int.
10069 (record_overlay_string): Check for size-calculation overflow.
d6202519 10070 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 10071
d5a19415
JM
100722011-06-22 Jim Meyering <meyering@redhat.com>
10073
029529ac 10074 Don't leak an XBM-image-sized buffer
d5a19415
JM
10075 * image.c (xbm_load): Free the image buffer after using it.
10076
a9041e6c
PE
100772011-06-21 Paul Eggert <eggert@cs.ucla.edu>
10078
10079 Port to Sun C.
10080 * composite.c (find_automatic_composition): Omit needless 'return 0;'
10081 that Sun C diagnosed.
10082 * fns.c (secure_hash): Fix pointer signedness issue.
10083 * intervals.c (static_offset_intervals): New function.
10084 (offset_intervals): Use it.
10085
7f3f739f
LL
100862011-06-21 Leo Liu <sdl.web@gmail.com>
10087
10088 * deps.mk (fns.o):
10089 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
10090 sha512.h.
10091
10092 * fns.c (secure_hash): Rename from crypto_hash_function and change
10093 the first arg to accept symbols.
5b66d427 10094 (Fsecure_hash): New primitive.
7f3f739f
LL
10095 (syms_of_fns): New symbols.
10096
76147d94
DD
100972011-06-20 Deniz Dogan <deniz@dogan.se>
10098
10099 * process.c (Fset_process_buffer): Clarify return value in
10100 docstring.
10101
7d7d0045
CY
101022011-06-18 Chong Yidong <cyd@stupidchicken.com>
10103
10104 * dispnew.c (add_window_display_history): Use BVAR.
10105
10106 * xdisp.c (debug_method_add): Use BVAR.
10107 (check_window_end, dump_glyph_matrix, dump_glyph)
10108 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
10109
10110 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
10111 Likewise.
10112
10113 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
10114 check till after the cache is created in init_frame_faces.
10115
ff2bc410
SM
101162011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
10117
10118 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
10119
28177add
PE
101202011-06-16 Paul Eggert <eggert@cs.ucla.edu>
10121
dd3482fe
PE
10122 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
10123 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
10124 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
10125
393d71f3 10126 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
10127 * fileio.c (Finsert_file_contents):
10128 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
10129 Remove the old (too-loose) buffer overflow checks.
10130 They weren't needed, since make_gap checks for buffer overflow.
10131 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
10132 The old code merely checked for Emacs fixnum overflow, and relied
10133 on undefined (wraparound) behavior. The new code avoids undefined
10134 behavior, and also checks for ptrdiff_t and/or size_t overflow.
10135
2e6813b0 10136 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
10137 Tune. Don't use wider integers than needed. Don't use alloca.
10138 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 10139
599a9e4f
PE
10140 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
10141
99561444
PE
10142 * insdel.c, lisp.h (buffer_overflow): New function.
10143 (insert_from_buffer_1, replace_range, replace_range_2):
10144 * insdel.c (make_gap_larger):
10145 * editfns.c (Finsert_char):
10146 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
10147
28177add
PE
10148 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
10149
e69dafad
PE
101502011-06-15 Paul Eggert <eggert@cs.ucla.edu>
10151
4baa020d 10152 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 10153
b1c46f02
PE
10154 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
10155 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
10156
e69dafad
PE
10157 * fileio.c: Don't assume EMACS_INT fits in off_t.
10158 (emacs_lseek): New static function.
10159 (Finsert_file_contents, Fwrite_region): Use it.
10160 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
10161
566684ea
PE
10162 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
10163
e6966cd6
PE
10164 * fns.c: Don't overflow int when computing a list length.
10165 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
10166 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
10167 truncation on 64-bit hosts. Check for QUIT every
10168 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
10169 faster and is responsive enough.
10170 (Flength): Report an error instead of overflowing an integer.
10171 (Fsafe_length): Return a float if the value is not representable
10172 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 10173 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 10174 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 10175
dd0b0efb
PE
10176 * alloc.c: Check that resized vectors' lengths fit in fixnums.
10177 (header_size, word_size): New constants.
10178 (allocate_vectorlike): Don't check size overflow here.
10179 (allocate_vector): Check it here instead, since this is the only
10180 caller of allocate_vectorlike that could cause overflow.
10181 Check that the new vector's length is representable as a fixnum.
10182
86fe5cfe
PE
10183 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
10184 The previous code was bogus. For example, next_almost_prime (32)
10185 returned 39, which is undesirable as it is a multiple of 3; and
10186 next_almost_prime (24) returned 25, which is a multiple of 5 so
10187 why was the code bothering to check for multiples of 7?
10188
80e88859
PE
10189 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
10190
4a2f0ad6
PE
10191 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
10192
f66c7cf8
PE
10193 Variadic C functions now count arguments with ptrdiff_t.
10194 This partly undoes my 2011-03-30 change, which replaced int with size_t.
10195 Back then I didn't know that the Emacs coding style prefers signed int.
10196 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
10197 were being counted with int, which may truncate counts on 64-bit
10198 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
10199 * lisp.h (struct Lisp_Subr.function.aMANY)
10200 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
10201 Arg counts are now ptrdiff_t, not size_t.
10202 All variadic functions and their callers changed accordingly.
10203 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
10204 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
10205 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
10206 * callint.c (Fcall_interactively): Check arg count for overflow,
10207 to avoid potential buffer overrun. Use signed char, not 'int',
10208 for 'varies' array, so that we needn't bother to check its size
10209 calculation for overflow.
10210 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
10211 * eval.c (apply_lambda):
10212 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
10213 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
10214 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
10215
a1759b76
PE
10216 * callint.c (Fcall_interactively): Don't use index var as event count.
10217
d96be9fc
PE
10218 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
10219 * mem-limits.h (SIZE): Remove; no longer used.
10220
a690a978 10221 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 10222
578c21e6
PE
10223 Remove unnecessary casts.
10224 * xterm.c (x_term_init):
10225 * xfns.c (x_set_border_pixel):
10226 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
10227 These aren't needed now that we assume ANSI C.
10228
96f53c6c
PE
10229 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
10230 It's more likely to cause problems (due to unsigned overflow)
10231 than to cure them.
10232
83c77d31
PE
10233 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
10234
ee2079f1
PE
10235 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
10236
6da65536
PE
10237 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
10238
7147c4a4
PE
10239 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
10240
193e32d9
PE
10241 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
10242
e5533da6
PE
10243 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
10244
9910e595
PE
10245 GLYPH_CODE_FACE returns EMACS_INT, not int.
10246 * dispextern.h (merge_faces):
10247 * xfaces.c (merge_faces):
01103c44
PE
10248 * xdisp.c (get_next_display_element, next_element_from_display_vector):
10249 Don't assume EMACS_INT fits in int.
9910e595 10250
2638320e
PE
10251 * character.h (CHAR_VALID_P): Remove unused parameter.
10252 * fontset.c, lisp.h, xdisp.c: All uses changed.
10253
045eb8d9
PE
10254 * editfns.c (Ftranslate_region_internal): Omit redundant test.
10255
c1f134b5
PE
10256 * fns.c (concat): Minor tuning based on overflow analysis.
10257 This doesn't fix any bugs. Use int to hold character, instead
10258 of constantly refetching from Emacs object. Use XFASTINT, not
10259 XINT, for value known to be a character. Don't bother comparing
10260 a single byte to 0400, as it's always less.
10261
395fcb93 10262 * floatfns.c (Fexpt):
327eeec8
PE
10263 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
10264
abbd3d23
PE
10265 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
10266 for characters.
10267
684a03ef
PE
10268 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
10269
0fed43f3
PE
10270 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
10271 Without this fix, on a 64-bit host (aset S 0 4294967386) would
10272 incorrectly succeed when S was a string, because 4294967386 was
10273 truncated before it was used.
10274
8fd02eb7
PE
10275 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
10276 Otherwise, an out-of-range integer could cause undefined behavior
10277 on a 64-bit host.
10278
f8c86b69
PE
10279 * composite.c: Use int, not EMACS_INT, for characters.
10280 (fill_gstring_body, composition_compute_stop_pos): Use int, not
10281 EMACS_INT, for values that are known to be in character range.
10282 This doesn't fix any bugs but is the usual style inside Emacs and
10283 may generate better code on 32-bit machines.
10284
34206dd2
PE
10285 Make sure a 64-bit char is never passed to ENCODE_CHAR.
10286 This is for reasons similar to the recent CHAR_STRING fix.
10287 * charset.c (Fencode_char): Check that character arg is actually
10288 a character. Pass an int to ENCODE_CHAR.
10289 * charset.h (ENCODE_CHAR): Verify that the character argument is no
10290 wider than 'int', as a compile-time check to prevent future regressions
10291 in this area.
10292
c5958d4c 10293 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
10294
10295 Make sure a 64-bit char is never passed to CHAR_STRING.
10296 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
10297 by silently ignoring the top 32 bits, allowing some values
10298 that were far too large to be valid characters.
10299 * character.h: Include <verify.h>.
10300 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
10301 arguments are no wider than unsigned, as a compile-time check
10302 to prevent future regressions in this area.
10303 * data.c (Faset):
01103c44 10304 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
10305 (Fsubst_char_in_region):
10306 * fns.c (concat):
10307 * xdisp.c (decode_mode_spec_coding):
10308 Adjust to CHAR_STRING's new requirement.
10309 * editfns.c (Finsert_char, Fsubst_char_in_region):
10310 * fns.c (concat): Check that character args are actually
10311 characters. Without this test, these functions did the wrong
10312 thing with wildly out-of-range values on 64-bit hosts.
10313
d37ca623
PE
10314 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
10315 These casts should not be needed on 32-bit hosts, either.
10316 * keyboard.c (read_char):
10317 * lread.c (Fload): Remove casts to unsigned.
10318
ea204efb
PE
10319 * lisp.h (UNSIGNED_CMP): New macro.
10320 This fixes comparison bugs on 64-bit hosts.
10321 (ASCII_CHAR_P): Use it.
10322 * casefiddle.c (casify_object):
01103c44 10323 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
10324 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
10325 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
10326 * dispextern.h (FACE_FROM_ID):
10327 * keyboard.c (read_char): Use UNSIGNED_CMP.
10328
41cb286c
PE
10329 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
10330 not to EMACS_INT, to avoid GCC warning.
10331
4a1b9832
PE
10332 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
10333
55daad71
PE
10334 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
10335 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
10336 isn't needed on 32-bit machines.
8f95c75c 10337
01103c44
PE
10338 * buffer.c (Fgenerate_new_buffer_name):
10339 Use EMACS_INT for count, not int.
0ceccced 10340 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
10341
10342 * data.c (Qcompiled_function): Now static.
10343
c6f072e7
PE
10344 * window.c (window_body_lines): Now static.
10345
20ce5912
PE
10346 * image.c (gif_load): Rename local to avoid shadowing.
10347
9c4c5f81
PE
10348 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
10349 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
10350 * alloc.c (make_save_value): Integer argument is now of type
10351 ptrdiff_t, not int.
10352 (mark_object): Use ptrdiff_t, not int.
10353 * lisp.h (pD): New macro.
10354 * print.c (print_object): Use it.
10355
c0c5c8ae
PE
10356 * alloc.c: Use EMACS_INT, not int, to count objects.
10357 (total_conses, total_markers, total_symbols, total_vector_size)
10358 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
10359 (total_free_floats, total_floats, total_free_intervals)
10360 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
10361 Now EMACS_INT, not int. All uses changed.
10362 (Fgarbage_collect): Compute overall total using a double, so that
10363 integer overflow is less likely to be a problem. Check for overflow
10364 when converting back to an integer.
5a25e253
PE
10365 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
10366 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
10367 These were 'int' variables that could overflow on 64-bit hosts;
10368 they were never used, so remove them instead of repairing them.
211a0b2a 10369 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
10370 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
10371 Previously, this ceilinged at INT_MAX, but that doesn't work on
10372 64-bit machines.
e46bb31a 10373 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 10374
c78baabf 10375 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 10376 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
10377 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
10378 when a (possibly-narrower) signed value would do just as well.
10379 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 10380
c9d624c6
PE
10381 * alloc.c: Catch some string size overflows that we were missing.
10382 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
10383 for convenience in STRING_BYTES_MAX.
10384 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
10385 The definition here is exact; the one in lisp.h was approximate.
10386 (allocate_string_data): Check for string overflow. This catches
10387 some instances we weren't catching before. Also, it catches
10388 size_t overflow on (unusual) hosts where SIZE_MAX <= min
10389 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
10390 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 10391
c9d624c6
PE
10392 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
10393 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 10394 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 10395
353032ce
PE
10396 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
10397
2bccce07
PE
10398 * alloc.c (Fmake_string): Check for out-of-range init.
10399
0ac30604
SM
104002011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
10401
10402 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
10403
c195f2de
JD
104042011-06-14 Jan Djärv <jan.h.d@swipnet.se>
10405
10406 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
10407 xg_get_default_scrollbar_width.
10408
10409 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
10410 (int_gtk_range_get_value): Move to the scroll bar part of the file.
10411 (style_changed_cb): Call update_theme_scrollbar_width and call
10412 x_set_scroll_bar_default_width and xg_frame_set_char_size for
10413 all frames (Bug#8505).
10414 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
10415 Call gtk_window_set_resizable if HAVE_GTK3.
10416 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
10417 and height if HAVE_GTK3 (Bug#8505).
10418 (scroll_bar_width_for_theme): New variable.
10419 (update_theme_scrollbar_width): New function.
10420 (xg_get_default_scrollbar_width): Move code to
10421 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
10422 (xg_initialize): Call update_theme_scrollbar_width.
10423
10424 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
10425
10426 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
10427
e10ac9f1
MR
104282011-06-12 Martin Rudalics <rudalics@gmx.at>
10429
10430 * frame.c (make_frame): Call other_buffer_safely instead of
10431 other_buffer.
10432
10433 * window.c (temp_output_buffer_show): Call display_buffer with
10434 second argument Vtemp_buffer_show_specifiers and reset latter
10435 immediately after the call.
10436 (Vtemp_buffer_show_specifiers): New variable.
10437 (auto_window_vscroll_p, next_screen_context_lines)
10438 (Vscroll_preserve_screen_position): Remove leading asterisks from
10439 doc-strings.
10440
2d3c217e 104412011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 10442
7b7f97e8 10443 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
10444 * buffer.c (Qclone_number): Remove for now, as it's unused.
10445 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
10446 (record_buffer): Remove unused local.
10447 * frame.c (other_visible_frames, frame_buffer_list): Now static.
10448 (set_frame_buffer_list): Remove; unused.
10449 * frame.h (other_visible_frames): Remove decl.
10450 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
10451 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
10452 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
10453 if HAVE_GPM.
10454 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
10455 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
10456 Define only if HAVE_GPM.
10457 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
10458 (update_hints_inhibit): Remove; never set. All uses removed.
10459 * widgetprv.h (emacsFrameClassRec): Remove decl.
10460 * window.c (delete_deletable_window): Now returns void, since it
10461 wasn't returning anything.
10462 (compare_window_configurations): Remove unused locals.
10463 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
10464 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
10465 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
10466 the same widths as pointers. This follows up on the 2011-05-06 patch.
10467 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
10468 * xterm.h: Likewise.
10469 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
10470
1384b89e
JB
104712011-06-12 Juanma Barranquero <lekktu@gmail.com>
10472
10473 * makefile.w32-in: Update dependencies.
10474 (LISP_H): Add lib/intprops.h.
10475
1100a63c
CY
104762011-06-11 Chong Yidong <cyd@stupidchicken.com>
10477
10478 * image.c (gif_load): Add animation frame delay to the metadata.
10479 (syms_of_image): Use DEFSYM. New symbol `delay'.
10480
6198ccd0
MR
104812011-06-11 Martin Rudalics <rudalics@gmx.at>
10482
10483 * window.c (delete_deletable_window): Re-add.
10484 (Fset_window_configuration): Rewrite to handle dead buffers and
10485 consequently deletable windows.
10486 (window_tree, Fwindow_tree): Remove. Supply functionality in
10487 window.el.
10488 (compare_window_configurations): Simplify code.
10489
b6e3633c
AS
104902011-06-11 Andreas Schwab <schwab@linux-m68k.org>
10491
1ab0dee5
AS
10492 * image.c (imagemagick_load_image): Fix type mismatch.
10493 (Fimagemagick_types): Likewise.
10494
b6e3633c
AS
10495 * window.h (replace_buffer_in_windows): Declare.
10496
9397e56f
MR
104972011-06-11 Martin Rudalics <rudalics@gmx.at>
10498
10499 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
10500 Qclone_number. Remove external declaration of Qdelete_window.
10501 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
10502 code.
640c8776
SM
10503 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
10504 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
10505 (Fother_buffer): Rewrite doc-string. Major rewrite for new
10506 buffer list implementation.
10507 (other_buffer_safely): New function.
10508 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
10509 calls to replace_buffer_in_windows and
10510 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
10511 if allowed.
10512 (record_buffer): Inhibit quitting and rewrite using quittable
10513 functions. Run Qbuffer_list_update_hook if allowed.
10514 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
10515 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
10516 Move switch-to-buffer to window.el.
9397e56f
MR
10517 (bury-buffer): Move to window.el.
10518 (Vbuffer_list_update_hook): New variable.
10519
10520 * lisp.h (other_buffer_safely): Add prototype in buffer.c
10521 section.
10522
10523 * window.h (resize_frame_windows): Move up in code.
10524 (Fwindow_frame): Remove EXFUN.
10525 (replace_buffer_in_all_windows): Remove prototype.
10526 (replace_buffer_in_windows_safely): Add prototype.
10527
10528 * window.c: Declare Qdelete_window static again. Move down
10529 declaration of select_count.
10530 (Fnext_window, Fprevious_window): Rewrite doc-strings.
10531 (Fother_window): Move to window.el.
10532 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
10533 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
10534 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
10535 window.el.
10536 (replace_buffer_in_windows): Implement by calling
10537 Qreplace_buffer_in_windows.
10538 (replace_buffer_in_all_windows): Remove with some functionality
10539 moved into replace_buffer_in_windows_safely.
10540 (replace_buffer_in_windows_safely): New function.
10541 (select_window_norecord, select_frame_norecord): Move in front
10542 of run_window_configuration_change_hook. Remove now obsolete
10543 declarations.
640c8776
SM
10544 (Fset_window_buffer): Rewrite doc-string.
10545 Call Qrecord_window_buffer.
9397e56f
MR
10546 (keys_of_window): Move binding for other-window to window.el.
10547
b50691aa
CY
105482011-06-11 Chong Yidong <cyd@stupidchicken.com>
10549
10550 * dispextern.h (struct image): Replace data member, whose int_val
10551 and ptr_val fields were not used by anything, with a single
10552 lisp_val object.
10553
10554 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
10555 (gif_clear_image, gif_load, imagemagick_load_image)
10556 (gs_clear_image, gs_load): Callers changed.
10557
3f754b86
PE
105582011-06-10 Paul Eggert <eggert@cs.ucla.edu>
10559
cca69397
PE
10560 * buffer.h: Include <time.h>, for time_t.
10561 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
10562
109e28d0
PE
10563 Fix minor problems found by static checking.
10564
60737f02
PE
10565 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
10566
4b66faf3
PE
10567 Make identifiers static if they are not used in other modules.
10568 * data.c (Qcompiled_function, Qframe, Qvector):
10569 * image.c (QimageMagick, Qsvg):
10570 * minibuf.c (Qmetadata):
10571 * window.c (resize_window_check, resize_root_window): Now static.
10572 * window.h (resize_window_check, resize_root_window): Remove decls.
10573
109e28d0
PE
10574 * window.c (window_deletion_count, delete_deletable_window):
10575 Remove; unused.
46a4ce9e
PE
10576 (window_body_lines): Now static.
10577 (Fdelete_other_windows_internal): Mark vars as initialized.
10578 Make sure 'resize_failed' is initialized.
10579 (run_window_configuration_change_hook): Rename local to avoid shadowing.
10580 (resize_window_apply): Remove unused local.
10581 * window.h (delete_deletable_window): Remove decl.
10582
109e28d0 10583 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
10584 (imagemagick_load_image): Fix pointer signedness problem by changing
10585 last arg from unsigned char * to char *. All uses changed.
10586 Also, fix a local for similar reasons.
10587 Remove unused locals. Remove locals to avoid shadowing.
10588 (fn_rsvg_handle_free): Remove; unused.
10589 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 10590 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 10591
3f754b86
PE
10592 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
10593
2547adb1
CY
105942011-06-10 Chong Yidong <cyd@stupidchicken.com>
10595
10596 * image.c (gif_load): Fix omitted cast error introduced by
10597 2011-06-06 change.
10598
2c8e37d4
MR
105992011-06-10 Martin Rudalics <rudalics@gmx.at>
10600
10601 * window.h (resize_proportionally, orig_total_lines)
10602 (orig_top_line): Remove from window structure.
10603 (set_window_height, set_window_width, change_window_heights)
10604 (Fdelete_window): Remove prototypes.
10605 (resize_frame_windows): Remove duplicate declaration.
10606
440a42e3
EZ
106072011-06-10 Eli Zaretskii <eliz@gnu.org>
10608
10609 * window.h (resize_frame_windows, resize_window_check)
10610 (delete_deletable_window, resize_root_window)
10611 (resize_frame_windows): Declare prototypes.
10612
10613 * window.c (resize_window_apply): Make definition be "static" to
10614 match the prototype.
10615
562dd5e9
MR
106162011-06-10 Martin Rudalics <rudalics@gmx.at>
10617
10618 * window.c: Remove declarations of Qwindow_size_fixed,
10619 window_min_size_1, window_min_size_2, window_min_size,
10620 size_window, window_fixed_size_p, enlarge_window, delete_window.
10621 Remove static from declaration of Qdelete_window, it's
10622 temporarily needed by Fbury_buffer.
10623 (replace_window): Don't assign orig_top_line and
10624 orig_total_lines.
10625 (Fdelete_window, delete_window): Remove. Window deletion is
10626 handled by window.el.
640c8776
SM
10627 (window_loop): Remove DELETE_OTHER_WINDOWS case.
10628 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
10629 (Fdelete_other_windows): Remove. Deleting other windows is
10630 handled by window.el.
10631 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
10632 handled in window.el.
10633 (window_min_size_2, window_min_size_1, window_min_size): Remove.
10634 Window minimum sizes are handled in window.el.
10635 (shrink_windows, size_window, set_window_height)
10636 (set_window_width, change_window_heights, window_height)
10637 (window_width, CURBEG, CURSIZE, enlarge_window)
10638 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
10639 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
10640 handled in window.el.
10641 (make_dummy_parent): Rename to make_parent_window and give it a
10642 second argument horflag.
10643 (make_window): Don't set resize_proportionally any more.
10644 (Fsplit_window): Remove. Windows are split in window.el.
10645 (save_restore_action, save_restore_orig_size)
10646 (shrink_window_lowest_first, save_restore_orig_size): Remove.
10647 Resize mini windows in window.el.
10648 (grow_mini_window, shrink_mini_window): Implement by calling
10649 Qresize_root_window_vertically, resize_window_check and
10650 resize_window_apply.
640c8776
SM
10651 (saved_window, Fset_window_configuration, save_window_save):
10652 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
10653 resize_proportionally.
10654 (window_min_height, window_min_width): Move to window.el.
10655 (keys_of_window): Move bindings for delete-other-windows,
10656 split-window, delete-window and enlarge-window to window.el.
10657
10658 * buffer.c: Temporarily extern Qdelete_window.
10659 (Fbury_buffer): Temporarily call Qdelete_window instead of
10660 Fdelete_window (Fbury_buffer will move to window.el soon).
10661
10662 * frame.c (set_menu_bar_lines_1): Remove code handling
10663 orig_top_line and orig_total_lines.
10664
10665 * dispnew.c (adjust_frame_glyphs_initially): Don't use
10666 set_window_height but set heights directly.
10667 (change_frame_size_1): Use resize_frame_windows.
10668
10669 * xdisp.c (init_xdisp): Don't use set_window_height but set
10670 heights directly.
10671
640c8776
SM
10672 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
10673 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
10674 run_window_configuration_change_hook.
10675
10676 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
10677 instead of change_window_heights and run
10678 run_window_configuration_change_hook.
10679
1a13852e
MR
106802011-06-09 Martin Rudalics <rudalics@gmx.at>
10681
10682 * window.c (replace_window): Rename second argument REPLACEMENT to
10683 NEW. New third argument SETFLAG. Rewrite.
10684 (delete_window, make_dummy_parent): Call replace_window with
10685 third argument 1.
10686 (window_list_1): Move down in code.
10687 (run_window_configuration_change_hook): Move set_buffer part
10688 before select_frame_norecord part in order to unwind correctly.
10689 Rename count1 to count.
10690 (recombine_windows, delete_deletable_window, resize_root_window)
10691 (Fdelete_other_windows_internal)
10692 (Frun_window_configuration_change_hook, make_parent_window)
10693 (resize_window_check, resize_window_apply, Fresize_window_apply)
10694 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
10695 (Fdelete_window_internal, Fresize_mini_window_internal):
10696 New functions.
1a13852e
MR
10697 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
10698
f3d1777e
MR
106992011-06-08 Martin Rudalics <rudalics@gmx.at>
10700
496e208e
MR
10701 * window.h (window): Add some new members to window structure -
10702 normal_lines, normal_cols, new_total, new_normal, clone_number,
10703 splits, nest, prev_buffers, next_buffers.
10704 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 10705 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 10706
f3d1777e
MR
10707 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
10708 Remove.
496e208e
MR
10709 (make_dummy_parent): Set new members of windows structure.
10710 (make_window): Move down in code. Handle new members of window
10711 structure.
10712 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
10713 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
10714 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
10715 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
10716 (Fset_window_next_buffers, Fset_window_clone_number):
10717 New functions.
496e208e
MR
10718 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
10719 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
10720 Doc-string fixes.
10721 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
10722 Argument WINDOW can be now internal window too.
10723 (Fwindow_use_time): Move up in code.
10724 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
10725 Rewrite doc-string.
10726 (Fset_window_configuration, saved_window)
10727 (Fcurrent_window_configuration, save_window_save): Handle new
10728 members of window structure.
b9e809c2
MR
10729 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
10730 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
10731 (syms_of_window): New Lisp objects Qrecord_window_buffer,
10732 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
10733 Qget_mru_window, Qresize_root_window,
10734 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
10735 Qauto_buffer_name; staticpro them.
f3d1777e 10736
abde8f8c
MR
107372011-06-07 Martin Rudalics <rudalics@gmx.at>
10738
10739 * window.c (Fwindow_total_size, Fwindow_left_column)
10740 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
10741 (Fwindow_list_1): New functions.
10742 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
10743 (Fwindow_width, Fscroll_left, Fscroll_right):
10744 Use window_body_cols instead of window_box_text_cols.
10745 (delete_window, Fset_window_configuration):
10746 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
10747 (delete_all_subwindows): Take a window as argument and not a
10748 structure. Rewrite.
190b47e6
MR
10749 (window_loop): Remove handling of GET_LRU_WINDOW and
10750 GET_LARGEST_WINDOW.
10751 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
10752
10753 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
10754 window_box_text_cols. delete_all_subwindows now takes a
10755 Lisp_Object as argument.
abde8f8c 10756
640c8776
SM
10757 * indent.c (compute_motion, Fcompute_motion):
10758 Use window_body_cols instead of window_box_text_cols.
abde8f8c 10759
fa8a67e6
MR
10760 * frame.c (delete_frame): Call delete_all_subwindows with root
10761 window as argument.
10762
a54e3482
DC
107632011-06-07 Daniel Colascione <dan.colascione@gmail.com>
10764
10765 * fns.c (Fputhash): Document return value.
10766
60002bf5
CY
107672011-06-06 Chong Yidong <cyd@stupidchicken.com>
10768
10769 * image.c (gif_load): Implement gif89a spec "no disposal" method.
10770
0c671da6 107712011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 10772
b862a52a 10773 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 10774
be44ca6c
PE
10775 Check for overflow when converting integer to cons and back.
10776 * charset.c (Fdefine_charset_internal, Fdecode_char):
10777 Use cons_to_unsigned to catch overflow.
10778 (Fencode_char): Use INTEGER_TO_CONS.
10779 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
10780 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
10781 * data.c (long_to_cons, cons_to_long): Remove.
10782 (cons_to_unsigned, cons_to_signed): New functions.
10783 These signal an error for invalid or out-of-range values.
10784 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
10785 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
10786 * font.c (Ffont_variation_glyphs):
10787 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
10788 * lisp.h: Include <intprops.h>.
10789 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
10790 (cons_to_signed, cons_to_unsigned): New decls.
10791 (long_to_cons, cons_to_long): Remove decls.
10792 * undo.c (record_first_change): Use INTEGER_TO_CONS.
10793 (Fprimitive_undo): Use CONS_TO_INTEGER.
10794 * xfns.c (Fx_window_property): Likewise.
10795 * xselect.c: Include <limits.h>.
10796 (x_own_selection, selection_data_to_lisp_data):
10797 Use INTEGER_TO_CONS.
10798 (x_handle_selection_request, x_handle_selection_clear)
10799 (x_get_foreign_selection, Fx_disown_selection_internal)
10800 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
10801 (lisp_data_to_selection_data): Use cons_to_unsigned.
10802 (x_fill_property_data): Use cons_to_signed.
10803 Report values out of range.
10804
d1f3d2af
PE
10805 Check for buffer and string overflow more precisely.
10806 * buffer.h (BUF_BYTES_MAX): New macro.
10807 * lisp.h (STRING_BYTES_MAX): New macro.
10808 * alloc.c (Fmake_string):
10809 * character.c (string_escape_byte8):
10810 * coding.c (coding_alloc_by_realloc):
10811 * doprnt.c (doprnt):
10812 * editfns.c (Fformat):
10813 * eval.c (verror):
10814 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
10815 since they may not be the same number.
10816 * editfns.c (Finsert_char):
10817 * fileio.c (Finsert_file_contents):
10818 Likewise for BUF_BYTES_MAX.
10819
dd52fcea
PE
10820 * image.c: Use ptrdiff_t, not int, for sizes.
10821 (slurp_file): Switch from int to ptrdiff_t.
10822 All uses changed.
10823 (slurp_file): Check that file size fits in both size_t (for
10824 malloc) and ptrdiff_t (for sanity and safety).
10825
7f9bbdbb
PE
10826 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
10827 if b->modtime has its maximal value.
10828
dfe18f82
PE
10829 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
10830
84acfcf0
PE
10831 Don't assume time_t can fit into int.
10832 * buffer.h (struct buffer.modtime): Now time_t, not int.
10833 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
10834 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
10835
ccd9a01a
PE
10836 Minor fixes for signed vs unsigned integers.
10837 * character.h (MAYBE_UNIFY_CHAR):
10838 * charset.c (maybe_unify_char):
10839 * keyboard.c (read_char, reorder_modifiers):
10840 XINT -> XFASTINT, since the integer must be nonnegative.
10841 * ftfont.c (ftfont_spec_pattern):
10842 * keymap.c (access_keymap, silly_event_symbol_error):
10843 XUINT -> XFASTINT, since the integer must be nonnegative.
10844 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
10845 since it makes no difference and we prefer signed.
10846 * keyboard.c (record_char): Use XUINT when all the neighbors do.
10847 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
10848 nonnegative.
10849
d6d100dd
SM
108502011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
10851
10852 * window.h (Fwindow_frame): Declare.
10853
2b6148e4
PE
108542011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10855
10856 * alloc.c: Simplify handling of large-request failures (Bug#8800).
10857 (SPARE_MEMORY): Always define.
10858 (LARGE_REQUEST): Remove.
10859 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
10860
f230ecc9
MR
108612011-06-06 Martin Rudalics <rudalics@gmx.at>
10862
727e958e
MR
10863 * lisp.h: Move EXFUNS for Fframe_root_window,
10864 Fframe_first_window and Fset_frame_selected_window to window.h.
10865
10866 * window.h: Move EXFUNS for Fframe_root_window,
10867 Fframe_first_window and Fset_frame_selected_window here from
10868 lisp.h.
10869
10870 * frame.c (Fwindow_frame, Fframe_first_window)
10871 (Fframe_root_window, Fframe_selected_window)
10872 (Fset_frame_selected_window): Move to window.c.
10873 (Factive_minibuffer_window): Move to minibuf.c.
10874 (Fother_visible_frames_p): New function.
10875
10876 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
10877
f230ecc9
MR
10878 * window.c (decode_window, decode_any_window): Move up in code.
10879 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
10880 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
10881 (Fwindow_buffer): Move up and rewrite doc-string.
10882 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
10883 (Fwindow_prev): New functions.
727e958e
MR
10884 (Fwindow_frame): Move here from frame.c. Accept any window as
10885 argument.
10886 (Fframe_root_window, Fframe_first_window)
10887 (Fframe_selected_window): Move here from frame.c. Accept frame
10888 or arbitrary window as argument. Update doc-strings.
10889 (Fminibuffer_window): Move up in code.
10890 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
10891 (Fset_frame_selected_window): Move here from frame.c.
10892 Marginal rewrite.
727e958e
MR
10893 (Fselected_window, select_window, Fselect_window): Move up in
10894 code. Minor doc-string fixes.
f230ecc9 10895
4d09bcf6
PE
108962011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10897
10898 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
10899 Do not assume that spare memory exists; that assumption is valid
10900 only if SYSTEM_MALLOC.
10901 (LARGE_REQUEST): New macro, so that the issue of large requests
10902 is separated from the issue of spare memory.
10903
810928a2
AS
109042011-06-05 Andreas Schwab <schwab@linux-m68k.org>
10905
172418ad
AS
10906 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
10907 format. (Bug#8806)
10908
43f862f7
AS
10909 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
10910
810928a2
AS
10911 * xfns.c (x_set_scroll_bar_default_width): Move declarations
10912 before statements.
10913
a059fe24
JD
109142011-06-05 Jan Djärv <jan.h.d@swipnet.se>
10915
10916 * gtkutil.c (xg_get_default_scrollbar_width): New function.
10917
10918 * gtkutil.h: Declare xg_get_default_scrollbar_width.
10919
10920 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
10921 min width by calling x_set_scroll_bar_default_width (Bug#8505).
10922
989bf368
JB
109232011-06-05 Juanma Barranquero <lekktu@gmail.com>
10924
10925 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
10926
4b80f674
CY
109272011-06-04 Chong Yidong <cyd@stupidchicken.com>
10928
10929 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
10930 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
10931 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
10932 New error handlers.
4b80f674
CY
10933 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
10934 Obey Vx_select_enable_clipboard_manager. Catch errors in
10935 x_clipboard_manager_save (Bug#8779).
10936 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 10937 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 10938
99a33b77 109392011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
10940
10941 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
10942
99a33b77 109432011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
10944
10945 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
10946 in the current matrix if keep_current_p is non-zero.
10947
8264569d
EZ
109482011-06-04 Eli Zaretskii <eliz@gnu.org>
10949
10950 * bidi.c (bidi_level_of_next_char): Fix last change.
10951
57f97249
EZ
109522011-06-03 Eli Zaretskii <eliz@gnu.org>
10953
fec2107c 10954 Support bidi reordering of text covered by display properties.
57f97249 10955
fec2107c
EZ
10956 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
10957 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
10958 (bidi_cache_search, bidi_cache_iterator_state)
10959 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
10960 (bidi_level_of_next_char, bidi_move_to_visually_next):
10961 Support character positions inside a run of characters covered by a
fec2107c
EZ
10962 display string.
10963 (bidi_paragraph_init, bidi_resolve_explicit_1)
10964 (bidi_level_of_next_char): Call bidi_fetch_char and
10965 bidi_fetch_char_advance instead of FETCH_CHAR and
10966 FETCH_CHAR_ADVANCE.
10967 (bidi_init_it): Initialize new members.
10968 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
10969 definitions.
10970 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
10971 instead of using explicit *_CHAR codes.
d6d100dd
SM
10972 (bidi_resolve_explicit, bidi_resolve_weak):
10973 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
10974 bidirectional text is supported only in multibyte buffers.
10975 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
10976 it to initialize the frame_window_p member of struct bidi_it.
10977 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
10978 (bidi_resolve_explicit, bidi_resolve_weak)
10979 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
10980 bidi_it->nchars is non-positive.
10981 (bidi_level_of_next_char): Don't try to lookup the cache for the
10982 next/previous character if nothing is cached there yet, or if we
10983 were just reseat()'ed to a new position.
c40e2fb2 10984
0e14fe90
EZ
10985 * xdisp.c (set_cursor_from_row): Set start and stop points
10986 according to the row's direction when priming the loop that looks
10987 for the glyph on which to display cursor.
10988 (single_display_spec_intangible_p): Function deleted.
10989 (display_prop_intangible_p): Reimplement to call
10990 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
10991 Accept 3 additional arguments needed by handle_display_spec.
10992 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
10993 values: lists, `(when COND...)' forms, etc.
10994 (single_display_spec_string_p): Support property values that are
10995 lists with the argument STRING its top-level element.
10996 (display_prop_string_p): Fix the condition for processing a
10997 property that is a list to be consistent with handle_display_spec.
fec2107c 10998 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
10999 last portion of handle_display_prop.
11000 (compute_display_string_pos): Accept additional argument
11001 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
11002 value of a `display' property is a "replacing spec".
11003 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
11004 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
11005 the display property, but just return a value indicating whether
11006 the display property will replace the characters it covers.
11007 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
11008 frame_window_p members of struct bidi_it.
d6d100dd
SM
11009 (compute_display_string_pos, compute_display_string_end):
11010 New functions.
fec2107c
EZ
11011 (push_it): Accept second argument POSITION, where pop_it should
11012 jump to continue iteration.
11013 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 11014
fec2107c
EZ
11015 * keyboard.c (adjust_point_for_property): Adjust the call to
11016 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
11017
11018 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
11019 (bidi_init_it): Update prototypes.
11020 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
11021 (compute_display_string_pos, compute_display_string_end):
11022 Declare prototypes.
fec2107c
EZ
11023 (struct bidi_it): New members nchars and disp_pos. ch_len is now
11024 EMACS_INT.
fc6f18ce 11025
40087514 110262011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 11027
57f53182
PE
11028 Malloc failure behavior now depends on size of allocation.
11029 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
11030 * lisp.h: Change signatures accordingly.
11031 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
11032 All callers changed. (Bug#8762)
11033
11034 * gnutls.c: Use Emacs's memory allocators.
11035 Without this change, the gnutls library would invoke malloc etc.
11036 directly, which causes problems on non-SYNC_INPUT hosts, and which
11037 runs afoul of improving memory_full behavior. (Bug#8761)
11038 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
11039 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
11040 xfree instead of the default malloc, realloc, free.
11041 (Fgnutls_boot): No need to check for memory allocation failure,
11042 since xmalloc does that for us.
11043
ac32cd99 11044 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
11045 * category.c (hash_get_category_set):
11046 * ccl.c (ccl_driver):
11047 * charset.c (Fdefine_charset_internal):
11048 * charset.h (struct charset.hash_index):
11049 * composite.c (get_composition_id, gstring_lookup_cache)
11050 (composition_gstring_put_cache):
11051 * composite.h (struct composition.hash_index):
11052 * dispextern.h (struct image.hash):
11053 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
11054 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
11055 (hashfn_equal, hashfn_user_defined, make_hash_table)
11056 (maybe_resize_hash_table, hash_lookup, hash_put)
11057 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
11058 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
11059 (Fsxhash, Fgethash, Fputhash, Fmaphash):
11060 * image.c (make_image, search_image_cache, lookup_image)
11061 (xpm_put_color_table_h):
11062 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 11063 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 11064 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 11065 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
11066 * alloc.c (allocate_vectorlike):
11067 Check for overflow in vector size calculations.
11068 * ccl.c (ccl_driver):
11069 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
11070 * fns.c, image.c: Remove unnecessary static decls that would otherwise
11071 need to be updated by these changes.
40087514
PE
11072 * fns.c (make_hash_table, maybe_resize_hash_table):
11073 Check for integer overflow with large hash tables.
0de4bb68
PE
11074 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
11075 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
11076 (SXHASH_REDUCE): New macro.
11077 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
11078 Use it instead of discarding useful hash info with large hash values.
11079 (sxhash_float): New function.
11080 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
11081 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
11082 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
11083 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
11084 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
11085 Adjust signatures to match updated version of code.
11086 (consing_since_gc): Now EMACS_INT, since a single hash table can
11087 use more than INT_MAX bytes.
11088
698d32e2
DN
110892011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
11090
11091 Make it possible to build with GCC-4.6+ -O2 -flto.
11092
11093 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
11094
fd6fa53f
SM
110952011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
11096
11097 * minibuf.c (get_minibuffer, read_minibuf_unwind):
11098 Call minibuffer-inactive-mode.
11099
864db017
JB
111002011-05-31 Juanma Barranquero <lekktu@gmail.com>
11101
11102 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
11103 Update dependencies.
11104
2ad0baf4
DN
111052011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11106
11107 * data.c (init_data): Remove code for UTS, this system is not
11108 supported anymore.
11109
4fcc2638
DN
111102011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11111
11112 Don't force ./temacs to start in terminal mode.
11113
11114 * frame.c (make_initial_frame): Initialize faces in all cases, not
11115 only when CANNOT_DUMP is defined.
11116 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
11117
c56e0fd5
DN
111182011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11119
11120 * dispnew.c (add_window_display_history): Use const for the string
11121 pointer. Remove declaration, not needed.
11122
333d54da 111232011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 11124
55d4c1b2 11125 Use 'inline', not 'INLINE'.
333d54da 11126 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
11127 * alloc.c, fontset.c (INLINE): Remove.
11128 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
11129 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
11130 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
11131 * gmalloc.c (register_heapinfo): Use inline unconditionally.
11132 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
11133
738db178
DN
111342011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11135
11136 Make it possible to run ./temacs.
11137
11138 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
11139 syms_of_callproc does the same thing. Remove test for
11140 "initialized", do it in the caller.
11141 * emacs.c (main): Avoid calling set_initial_environment when dumping.
11142
620c53a6
SM
111432011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
11144
11145 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
11146 (read_minibuf): Use get_minibuffer.
11147 (syms_of_minibuf): Use DEFSYM.
11148 (Qmetadata): New var.
11149 * data.c (Qbuffer): Don't make it static.
11150 (syms_of_data): Use DEFSYM.
11151
e003a292
PE
111522011-05-31 Paul Eggert <eggert@cs.ucla.edu>
11153
11154 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
11155 (CCL_CODE_MIN): New macro.
11156
ed008a6d
PE
111572011-05-30 Paul Eggert <eggert@cs.ucla.edu>
11158
3687c2ef
PE
11159 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
11160
ed008a6d
PE
11161 * eval.c (Qdebug): Now static.
11162 * lisp.h (Qdebug): Remove decl. This reverts a part of the
11163 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
11164 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
11165
d66c4c7c
CY
111662011-05-29 Chong Yidong <cyd@stupidchicken.com>
11167
11168 * image.c: Various fixes to ImageMagick code comments.
11169 (Fimagemagick_types): Doc fix.
11170
5fbc2025
PE
111712011-05-29 Paul Eggert <eggert@cs.ucla.edu>
11172
0196f88a
PE
11173 Minor fixes prompted by GCC 4.6.0 warnings.
11174
11175 * xselect.c (converted_selections, conversion_fail_tag): Now static.
11176
5fbc2025
PE
11177 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
11178 (x_clipboard_manager_save_all): Move extern decl to ...
11179 * xterm.h: ... here, so that it can be checked for consistency.
11180
1dd3c2d9
CY
111812011-05-29 Chong Yidong <cyd@stupidchicken.com>
11182
11183 * xselect.c (x_clipboard_manager_save_frame)
11184 (x_clipboard_manager_save_all): New functions.
11185 (Fx_clipboard_manager_save): Lisp function deleted.
11186
11187 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
11188 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
11189
11190 * xterm.h: Update prototype.
11191
5ba6571d
WX
111922011-05-28 William Xu <william.xwl@gmail.com>
11193
11194 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
11195 exiting (Bug#8239).
11196
3eaff834
JM
111972011-05-28 Jim Meyering <meyering@redhat.com>
11198
e1900994 11199 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
11200 * fns.c (to_uchar): Define.
11201 (crypto_hash_function): Use it to convert some newly-signed
11202 variables to unsigned, to avoid sign-extension bugs. For example,
11203 without this change, (md5 "truc") would evaluate to
11204 45723a2aff78ff4fff7fff1114760e62 rather than the expected
11205 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 11206 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 11207
0f6990a7
PE
112082011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11209
11210 Integer overflow fixes.
c8a9ca5a 11211
08686060
PE
11212 * dbusbind.c: Serial number integer overflow fixes.
11213 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
11214 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
11215 to hold a serial number that is too large for a fixnum.
11216 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11217 Check for serial numbers out of range. Decode any serial number
59568bf0 11218 that was so large that it became a float. (Bug#8722)
08686060 11219
2d1fc3c7
PE
11220 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
11221 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11222 Use XFASTINT rather than XUINT when numbers are nonnegative.
11223 (xd_append_arg, Fdbus_method_return_internal):
11224 (Fdbus_method_error_internal): Likewise. Also, for unsigned
11225 arguments, check that Lisp number is nonnegative, rather than
59568bf0 11226 silently wrapping negative numbers around. (Bug#8722)
30217ff0 11227 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 11228 (Bug#8722)
2d1fc3c7 11229
c8a9ca5a
PE
11230 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
11231
519e1d69
PE
11232 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
11233
6df6ae42 11234 ccl: Add integer overflow checks.
30569699
PE
11235 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
11236 (IN_INT_RANGE): New macros.
11237 (ccl_driver): Use them to check for integer overflow when
11238 decoding a CCL program. Many of the new checks are whether XINT (x)
11239 fits in int; it doesn't always, on 64-bit hosts. The new version
11240 doesn't catch all possible integer overflows, but it's an
847044ea 11241 improvement. (Bug#8719)
30569699 11242
c11285dc
PE
11243 * alloc.c (make_event_array): Use XINT, not XUINT.
11244 There's no need for unsigned here.
11245
fdccd48e
PE
11246 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
11247 This follows up to the 2011-05-06 change that substituted uintptr_t
11248 for EMACS_INT. This case wasn't caught back then.
11249
37910ab2
PE
11250 Rework Fformat to avoid integer overflow issues.
11251 * editfns.c: Include <float.h> unconditionally, as it's everywhere
11252 now (part of C89). Include <verify.h>.
11253 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
11254 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
11255 (Fformat): Avoid the prepass trying to compute sizes; it was only
11256 approximate and thus did not catch overflow reliably. Instead, walk
11257 through the format just once, formatting and computing sizes as we go,
11258 checking for integer overflow at every step, and allocating a larger
11259 buffer as needed. Keep track separately whether the format is
11260 multibyte. Keep only the most-recently calculated precision, rather
11261 than them all. Record whether each argument has been converted to
11262 string. Use EMACS_INT, not int, for byte and char and arg counts.
11263 Support field widths and precisions larger than INT_MAX. Avoid
11264 sprintf's undefined behavior with conversion specifications such as %#d
11265 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
11266 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
11267 formatting out-of-range floating point numbers with int
9173deec 11268 formats. (Bug#8668)
37910ab2 11269
2e6578fb
PE
11270 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
11271
0ae6bdee
PE
11272 * data.c: Avoid integer truncation in expressions involving floats.
11273 * data.c: Include <intprops.h>.
11274 (arith_driver): When there's an integer overflow in an expression
11275 involving floating point, convert the integers to floating point
11276 so that the resulting value does not suffer from catastrophic
11277 integer truncation. For example, on a 64-bit host (* 4
11278 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
11279 Do not rely on undefined behavior after integer overflow.
11280
de883a70
PE
11281 merge count_size_as_multibyte, parse_str_to_multibyte
11282 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 11283 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
11284 Check for integer overflow.
11285 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
11286 since it's now a duplicate of the other. This is more of
11287 a character than a buffer op, so better that it's in character.c.
11288 * fns.c, print.c: Adjust to above changes.
11289
2ff916cb
PE
112902011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
11291
11292 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
11293
f1b54466
PE
112942011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11295
fb1ac845
PE
11296 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11297 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
11298 (x_clipboard_manager_save): Now static.
11299 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
11300
f1b54466
PE
11301 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11302 (crypto_hash_function): Now static.
11303 Fix pointer signedness problems. Avoid unnecessary initializations.
11304
a9f737ee
CY
113052011-05-27 Chong Yidong <cyd@stupidchicken.com>
11306
11307 * termhooks.h (Vselection_alist): Make it terminal-local.
11308
11309 * terminal.c (create_terminal): Initialize it.
11310
11311 * xselect.c: Support for clipboard managers.
11312 (Vselection_alist): Move to termhooks.h as terminal-local var.
11313 (LOCAL_SELECTION): New macro.
11314 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
11315 (symbol_to_x_atom): Remove gratuitous arg.
11316 (x_handle_selection_request, lisp_data_to_selection_data)
11317 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
11318 (x_own_selection, x_get_local_selection, x_convert_selection):
11319 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
11320 (some_frame_on_display): Delete unused function.
11321 (Fx_own_selection_internal, Fx_get_selection_internal)
11322 (Fx_disown_selection_internal, Fx_selection_owner_p)
11323 (Fx_selection_exists_p): New optional frame arg.
11324 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
11325 (x_handle_selection_clear): Don't treat other terminals with the
11326 same keyboard specially. Use the terminal-local Vselection_alist.
11327 (x_clear_frame_selections): Use Frun_hook_with_args.
11328
11329 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
11330
11331 * xterm.h: Add support for those atoms.
11332
e067f0c1
CY
113332011-05-26 Chong Yidong <cyd@stupidchicken.com>
11334
11335 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
11336 (converted_selections, conversion_fail_tag): New global variables.
11337 (x_selection_request_lisp_error): Free the above.
11338 (x_get_local_selection): Remove unnecessary code.
11339 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
11340 of converted selections stored in converted_selections.
11341 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
11342 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
11343 (x_convert_selection): New function.
11344 (x_handle_selection_event): Simplify.
11345 (x_get_foreign_selection): Don't ignore incoming requests while
11346 waiting for an answer; this will fail when we implement
11347 SAVE_TARGETS, and seems unnecessary anyway.
11348 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
11349 (Vx_sent_selection_functions): Doc fix.
11350
0f4aebc0
LL
113512011-05-26 Leo Liu <sdl.web@gmail.com>
11352
11353 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
11354
e61124cd
YM
113552011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11356
11357 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
11358
11359 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
11360 for fringe update if it has periodic bitmap.
ac389d0c 11361 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
11362 and fringe_bitmap_periodic_p.
11363
11364 * fringe.c (get_fringe_bitmap_data): New function.
11365 (draw_fringe_bitmap_1, update_window_fringes): Use it.
11366 (update_window_fringes): Record periodicity of fringe bitmap in glyph
11367 row. Mark glyph row for fringe update if periodicity changed.
11368
11369 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
11370 for fringe update unless it has periodic bitmap.
11371
f16d9837
KH
113722011-05-25 Kenichi Handa <handa@m17n.org>
11373
11374 * xdisp.c (get_next_display_element): Set correct it->face_id for
11375 a static composition.
11376
e1b90ef6
LL
113772011-05-24 Leo Liu <sdl.web@gmail.com>
11378
11379 * deps.mk (fns.o):
11380 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
11381
11382 * fns.c (crypto_hash_function, Fsha1): New function.
11383 (Fmd5): Use crypto_hash_function.
11384 (syms_of_fns): Add Ssha1.
11385
7400048f
PE
113862011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11387
11388 * gnutls.c: Remove unused macros.
11389 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
11390 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
11391 Remove macros that are defined and never used.
11392 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
11393
abb71cf4
CY
113942011-05-22 Chong Yidong <cyd@stupidchicken.com>
11395
11396 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
11397 (Fx_get_selection_internal): Minor cleanup.
11398 (Fx_own_selection_internal): Rename arguments for consistency with
11399 select.el.
11400
6307db39
PE
114012011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11402
11403 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
11404
f3d4e0a4
CY
114052011-05-22 Chong Yidong <cyd@stupidchicken.com>
11406
11407 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
11408
4d8ade89
YM
114092011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11410
11411 * dispnew.c (scrolling_window): Don't exclude the case that the
11412 last enabled row in the desired matrix touches the bottom boundary.
11413
32078c8d
GM
114142011-05-21 Glenn Morris <rgm@gnu.org>
11415
11416 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
11417 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
11418 and add some more files.
32078c8d 11419
7285dc67
EZ
114202011-05-20 Eli Zaretskii <eliz@gnu.org>
11421
11422 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
11423 report_file_error introduced by the change from 2011-05-07.
11424
89d1bd22
PE
114252011-05-20 Paul Eggert <eggert@cs.ucla.edu>
11426
11427 * systime.h (Time): Define only if emacs is defined.
11428 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
11429 where the include path doesn't have X11/X.h by default. See
11430 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
11431
cd394be1 114322011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
11433
11434 * composite.c (find_automatic_composition): Fix previous change.
11435
b9704ad9
GM
114362011-05-20 Glenn Morris <rgm@gnu.org>
11437
11438 * lisp.mk: New file, split from Makefile.in.
11439 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
11440 (shortlisp): Remove.
11441 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
11442
4a720484
GM
114432011-05-19 Glenn Morris <rgm@gnu.org>
11444
11445 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
11446 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
11447 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
11448 (lisp): Set the order to that of loadup.el.
11449 (shortlisp): Make it a copy of $lisp.
11450 (SOME_MACHINE_LISP): Remove.
11451 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
11452 Use just $shortlisp, not $SOME_MACHINE_LISP too.
11453
a28d4396
KH
114542011-05-18 Kenichi Handa <handa@m17n.org>
11455
11456 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
11457 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
11458 (find_automatic_composition): Mostly rewrite for efficiency.
11459
a2b1fa8e
JB
114602011-05-18 Juanma Barranquero <lekktu@gmail.com>
11461
11462 * makefile.w32-in: Update dependencies.
11463
8e1f5610
CS
114642011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
11465
11466 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 11467 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 11468
7025ee00 114692011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 11470
cdfa6eab
PE
11471 Fix some integer overflow issues, such as string length overflow.
11472
06d6db33
PE
11473 * insdel.c (count_size_as_multibyte): Check for string overflow.
11474
2b4560a8
PE
11475 * character.c (lisp_string_width): Check for string overflow.
11476 Use EMACS_INT, not int, for string indexes and lengths; in
11477 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
11478 the resulting string length overflows an EMACS_INT; instead,
11479 report a string overflow if no precision given. When checking for
11480 precision exhaustion, use a check that cannot possibly have
11481 integer overflow. (Bug#8675)
11482 * character.h (lisp_string_width): Adjust to new signature.
11483
cb93f9be
PE
11484 * alloc.c (string_overflow): New function.
11485 (Fmake_string): Use it. This doesn't change behavior, but saves
11486 a few bytes and will simplify future changes.
11487 * character.c (string_escape_byte8): Likewise.
11488 * lisp.h (string_overflow): New decl.
11489
1a1f3366
PE
11490 Fixups, following up to the user-interface timestamp change.
11491 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
11492 for UI timestamps, instead of unsigned long.
9fbd6841
PE
11493 * msdos.c (mouse_get_pos): Likewise.
11494 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
11495 * w32gui.h (Time): Define by including "systime.h" rather than by
11496 declaring it ourselves. (Bug#8664)
11497
d4e3e4d3
PE
11498 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
11499 * image.c (clear_image_cache): Likewise.
11500
f6a24d19
PE
11501 * term.c (term_mouse_position): Don't assume time_t wraparound.
11502
08dc5ae6
PE
11503 Be more systematic about user-interface timestamps.
11504 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
11505 and sometimes 'EMACS_UINT', to represent these timestamps.
11506 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
11507 This makes the code easier to follow, and makes it easier to catch
11508 integer overflow bugs such as Bug#8664.
11509 * frame.c (Fmouse_position, Fmouse_pixel_position):
11510 Use Time, not unsigned long, for user-interface timestamps.
11511 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
11512 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
11513 * keyboard.h (last_event_timestamp): Likewise.
11514 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
11515 * menu.h (xmenu_show): Likewise.
11516 * term.c (term_mouse_position): Likewise.
11517 * termhooks.h (struct input_event.timestamp): Likewise.
11518 (struct terminal.mouse_position_hook): Likewise.
11519 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
11520 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
11521 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
11522 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
11523 what it was before.
11524 * menu.h, termhooks.h: Include "systime.h", for Time.
11525
8e55734a
PE
11526 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
11527 Don't assume that the difference between two unsigned long values
11528 can fit into an integer. At this point, we know button_down_time
11529 <= event->timestamp, so the difference must be nonnegative, so
11530 there's no need to cast the result if double-click-time is
11531 nonnegative, as it should be; check that it's nonnegative, just in
11532 case. This bug is triggered when events are more than 2**31 ms
86db42d2 11533 apart (about 25 days). (Bug#8664)
8e55734a 11534
841f1b75 11535 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 11536 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 11537
3e26f69c
PE
11538 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
11539 that always fit in int. Use a sentinel instead of a counter, to
11540 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
11541 * frame.h (struct frame): Use int for menu_bar_items_used
11542 instead of EMACS_INT, since it always fits in int.
3e26f69c 11543
5cc152c0
PE
11544 * menu.c (grow_menu_items): Check for int overflow.
11545
d89eb65e
PE
11546 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
11547
5235bd3e
PE
11548 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
11549 Before, the code was not consistent. These values cannot exceed
11550 2**31 - 1 so there's no need to make them unsigned.
11551 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
11552 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
11553 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
11554 as modifiers.
11555 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
11556
bc827e23
PE
11557 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
11558 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
11559 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
11560 presumably because the widths might not match.
11561
78eb494e
PE
11562 * window.c (size_window): Avoid needless test at loop start.
11563
04f2d78b
CB
115642011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
11565
11566 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
11567
d2fc7e3d 115682011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
11569
11570 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
11571
d2fc7e3d 115722011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
11573
11574 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
11575 `width' to `bar_area_x' and `bar_area_width', respectively.
11576 (x_scroll_run): Take account of fringe background extension.
11577
04f2d78b
CB
11578 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
11579 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
11580 `bar_area_width', respectively.
11581 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
11582 background extension.
11583
79b70037
GM
115842011-05-10 Jim Meyering <meyering@redhat.com>
11585
11586 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
11587
2f142cc5
JB
115882011-05-10 Juanma Barranquero <lekktu@gmail.com>
11589
11590 * image.c (Finit_image_library): Return t for built-in image types,
11591 like pbm and xbm. (Bug#8640)
11592
57679c86
AS
115932011-05-09 Andreas Schwab <schwab@linux-m68k.org>
11594
11595 * w32menu.c (set_frame_menubar): Fix submenu allocation.
11596
888c9e86
EZ
115972011-05-07 Eli Zaretskii <eliz@gnu.org>
11598
b0512a1d
EZ
11599 * w32console.c (Fset_screen_color): Doc fix.
11600 (Fget_screen_color): New function.
11601 (syms_of_ntterm): Defsubr it.
11602
7285dc67
EZ
11603 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
11604 unlink the temporary file if Fcall_process didn't create it in the
11605 first place.
11606 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
11607 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
11608 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
11609 cue to call_process_cleanup not to close that handle.
11610
4d3fcc8e
BK
116112011-05-07 Ben Key <bkey76@gmail.com>
11612
11613 * makefile.w32-in: The bootstrap-temacs rule now makes use of
11614 one of two shell specific rules, either bootstrap-temacs-CMD or
11615 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
11616 to the previous implementation of the bootstrap-temacs rule.
11617 The bootstrap-temacs-CMD rule is similar to the previous
11618 implementation of the bootstrap-temacs rule except that it
11619 makes use of the ESC_CFLAGS variable instead of the CFLAGS
11620 variable.
11621
11622 These changes, along with some changes to nt/configure.bat,
11623 nt/gmake.defs, and nt/nmake.defs, are required to extend my
11624 earlier fix to add support for --cflags and --ldflags options
11625 that include quotes so that it works whether make uses cmd or
11626 sh as the shell.
11627
b4289b64
MA
116282011-05-06 Michael Albinus <michael.albinus@gmx.de>
11629
11630 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
11631 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
11632 is a constant.
11633 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
11634 a string. Handle both cases.
11635 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
11636 (Fdbus_register_method): Use Qinvalid_function.
11637
af4c0e28
JB
116382011-05-06 Juanma Barranquero <lekktu@gmail.com>
11639
11640 * makefile.w32-in: Update dependencies.
11641 (LISP_H): Add inttypes.h and stdin.h.
11642 (PROCESS_H): Add unistd.h.
11643
c51453d9
EZ
116442011-05-06 Eli Zaretskii <eliz@gnu.org>
11645
11646 * lread.c: Include limits.h (fixes the MS-Windows build broken by
11647 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
11648
8ff0ac3c 116492011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 11650
4c4b566b
PE
11651 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
11652
aab2b9b5
PE
11653 * term.c (vfatal): Remove stray call to va_end.
11654 It's not needed and the C Standard doesn't allow it here anyway.
11655
c378da0b
PE
11656 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
11657 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
11658
288b08c7
PE
11659 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
11660 bytes.
11661
e3601888
PE
11662 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
11663
db6c0e74
PE
11664 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
11665
dd5963ea
PE
11666 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
11667
88c9450f
PE
11668 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
11669
2f9442b8
PE
11670 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
11671
c032b5f8
PE
11672 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
11673 * charset.c (Fdefine_charset_internal): Don't initialize
11674 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 11675 32-bit int (Bug#8600).
a108c10b
PE
11676
11677 * lread.c (read_integer): Be more consistent with string-to-number.
11678 Use string_to_number to do the actual conversion; this avoids
11679 rounding errors and fixes some other screwups. Without this fix,
11680 for example, #x1fffffffffffffff was misread as -2305843009213693952.
11681 (digit_to_number): Move earlier, for benefit of read_integer.
11682 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 11683 not a digit in any supported base. (Bug#8602)
a108c10b 11684
ad5f9eea
PE
11685 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
11686
aec1708a
PE
11687 * dispnew.c (scrolling_window): Return 1 if we scrolled,
11688 to match comment at start of function. This also removes a
11689 GCC warning about overflow in a 32+64-bit port.
11690
47be4ab5
PE
11691 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
11692
371cac43
PE
11693 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
11694 Reported by Stefan Monnier in
11695 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
11696 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11697 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 11698
d01a7826
PE
11699 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
11700 (EMACS_UINTPTR): Likewise, with uintptr_t.
11701
7fd47d5c
PE
11702 * lisp.h: Prefer 64-bit EMACS_INT if available.
11703 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
11704 on 32-bit hosts that have 64-bit int, so that they can access
11705 large files.
122b0c86
PE
11706 However, temporarily disable this change unless the temporary
11707 symbol WIDE_EMACS_INT is defined.
7fd47d5c 11708
8727937b
PE
11709 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
11710
8ac068ac
PE
11711 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
11712 This removes an assumption that EMACS_INT and long are the same
11713 width as pointers. The assumption is true for Emacs porting targets
11714 now, but we want to make other targets possible.
11715 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
11716 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
11717 In the rest of the code, change types of integers that hold casted
11718 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
11719 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
11720 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
11721 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
11722 No need to cast type when ORing.
11723 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
11724 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
11725 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
11726 assume EMACS_INT is the same width as char *.
11727 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
11728 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
11729 Remove no-longer-needed casts.
11730 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
11731 (xg_tool_bar_help_callback, xg_make_tool_item):
11732 Use EMACS_INTPTR to hold an integer
11733 that will be cast to void *; this can avoid a GCC warning
11734 if EMACS_INT is not the same width as void *.
11735 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
11736 * xdisp.c (display_echo_area_1, resize_mini_window_1):
11737 (current_message_1, set_message_1):
11738 Use a local to convert to proper width without a cast.
11739 * xmenu.c (dialog_selection_callback): Likewise.
11740
ede49d71
PE
11741 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
11742 Also, don't assume VALBITS / RAND_BITS is less than 5,
11743 and don't rely on undefined behavior when shifting a 1 left into
11744 the sign bit.
11745 * lisp.h (get_random): Change signature to match.
11746
2f30ecd0
PE
11747 * lread.c (hash_string): Use size_t, not int, for hash computation.
11748 Normally we prefer signed values; but hashing is special, because
11749 it's better to use unsigned division on hash table sizes so that
11750 the remainder is nonnegative. Also, size_t is the natural width
11751 for hashing into memory. The previous code used 'int', which doesn't
11752 retain enough info to hash well into very large tables.
11753 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
11754
2a866e7b
PE
11755 * dbusbind.c: Don't possibly lose pointer info when converting.
11756 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11757 Use XPNTR rather than XHASH, so that the high-order bits of
11758 the pointer aren't lost when converting through void *.
11759
51639eac
PE
11760 * eval.c (Fautoload): Don't double-shift a pointer.
11761
92394119
PE
11762 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
11763
dbdb9a7c
JB
117642011-05-06 Juanma Barranquero <lekktu@gmail.com>
11765
11766 * gnutls.c (DEF_GNUTLS_FN):
11767 * image.c (DEF_IMGLIB_FN): Make function pointers static.
11768
db7a0b4f
AS
117692011-05-05 Andreas Schwab <schwab@linux-m68k.org>
11770
11771 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
11772 marker. (Bug#8610)
11773
cd394be1 117742011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
11775
11776 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
11777 New version that can reserve upto 2GB of heap space.
11778
f7ff1b0f 117792011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
11780
11781 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
11782
639c109b
TZ
117832011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
11784
11785 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
11786 `gnutls_certificate_set_x509_key_file'.
11787
d2127135
JB
117882011-05-05 Juanma Barranquero <lekktu@gmail.com>
11789
11790 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
11791 Update dependencies.
11792
e968f4f3
JB
117932011-05-04 Juanma Barranquero <lekktu@gmail.com>
11794
11795 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
11796 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
11797 Remove unused parameter `fildes'.
11798 * process.c (read_process_output, send_process): Don't pass it.
11799
84d358f0
JB
118002011-05-04 Juanma Barranquero <lekktu@gmail.com>
11801
11802 Fix previous change: the library cache is defined in w32.c.
11803 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
11804 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
11805
0898ca10
JB
118062011-05-04 Juanma Barranquero <lekktu@gmail.com>
11807
11808 Implement dynamic loading of GnuTLS on Windows.
11809
11810 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
11811 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
11812 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11813 Declare.
11814
11815 * gnutls.c (Qgnutls_dll): Define.
11816 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
11817 (gnutls_*): Declare function pointers.
11818 (init_gnutls_functions): New function to initialize function pointers.
11819 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
11820 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
11821 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11822 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
11823 (emacs_gnutls_write, emacs_gnutls_read)
11824 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
11825 (Fgnutls_available_p): New function.
11826 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
11827 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
11828 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
11829
11830 * image.c: Include w32.h.
11831 (Vimage_type_cache): Delete.
11832 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
11833 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
11834 (w32_delayed_load): Move to w32.c.
11835
11836 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
11837
11838 * w32.c (QCloaded_from, Vlibrary_cache): Define.
11839 (w32_delayed_load): Move from image.c. When loading a library, record
11840 its filename in the :loaded-from property of the library id.
11841 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
11842 Initialize and staticpro them.
11843 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
11844
11845 * process.c: Include lisp.h before w32.h, not after.
11846 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
11847 instead of gnutls_record_check_pending.
11848
11849 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
11850
ff4de4aa
TZ
118512011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
11852
11853 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
11854 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
11855 as passed in.
11856
abe95abb
JD
118572011-05-03 Jan Djärv <jan.h.d@swipnet.se>
11858
11859 * xterm.c (x_set_frame_alpha): Do not set property on anything
11860 else than FRAME_X_OUTER_WINDOW (Bug#8608).
11861
e16e55d4
JB
118622011-05-02 Juanma Barranquero <lekktu@gmail.com>
11863
11864 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
11865
bafcf6a5
JB
118662011-05-02 Juanma Barranquero <lekktu@gmail.com>
11867
11868 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
11869 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
11870 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
11871 (gnutls_global_initialized, Qgnutls_bootprop_priority)
11872 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
11873 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
11874 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
11875 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
11876 (Qgnutls_bootprop_callbacks_verify): Make static.
11877
e7a6747f
AS
118782011-05-01 Andreas Schwab <schwab@linux-m68k.org>
11879
19ed11ba
AS
11880 * callproc.c: Indentation fixup.
11881
e7a6747f 11882 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
11883 (wait_for_termination, interruptible_wait_for_termination):
11884 Move after wait_for_termination_1.
e7a6747f 11885
1ef14cb4
LMI
118862011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
11887
11888 * sysdep.c (interruptible_wait_for_termination): New function
11889 which is like wait_for_termination, but allows keyboard
11890 interruptions.
11891
11892 * callproc.c (Fcall_process): Add (:file "file") as an option for
11893 the STDOUT buffer.
11894 (Fcall_process_region): Ditto.
11895
330d880c
EZ
118962011-04-30 Eli Zaretskii <eliz@gnu.org>
11897
8db90b73
EZ
11898 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
11899 rather than `XVECTOR (FOO)->size'.
11900
330d880c
EZ
11901 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
11902 inttypes.h, as a gnulib replacement is used if it not available in
11903 system headers.
11904
15cbd324
EZ
119052011-04-21 Eli Zaretskii <eliz@gnu.org>
11906
11907 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
11908 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
11909 of MOST_POSITIVE_FIXNUM. (Bug#8528)
11910
11911 * coding.c (coding_alloc_by_realloc): Error out if destination
11912 will grow beyond MOST_POSITIVE_FIXNUM.
11913 (decode_coding_emacs_mule): Abort if there isn't enough place in
11914 charbuf for the composition carryover bytes. Reserve an extra
11915 space for up to 2 characters produced in a loop.
11916 (decode_coding_iso_2022): Abort if there isn't enough place in
11917 charbuf for the composition carryover bytes.
11918
119192011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 11920
ae940cca
EZ
11921 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
11922 aborting when %lld or %lll format is passed.
11923 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
11924 %llo or %llx format is passed. (Bug#8545)
11925
03ab8921
EZ
11926 * window.c (window_scroll_line_based): Use a marker instead of
11927 simple variables to record original value of point. (Bug#7952)
11928
afda1437
EZ
11929 * doprnt.c (doprnt): Fix the case where a multibyte sequence
11930 produced by %s or %c overflows available buffer space. (Bug#8545)
11931
f76dee0c
PE
119322011-04-28 Paul Eggert <eggert@cs.ucla.edu>
11933
11934 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 11935 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 11936
fdc5744d
JB
119372011-04-28 Juanma Barranquero <lekktu@gmail.com>
11938
11939 * w32.c (init_environment): Warn about defaulting HOME to C:\.
11940
638f053a
JB
119412011-04-28 Juanma Barranquero <lekktu@gmail.com>
11942
11943 * keyboard.c (Qdelayed_warnings_hook): Define.
11944 (command_loop_1): Run `delayed-warnings-hook'
11945 if Vdelayed_warnings_list is non-nil.
11946 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
11947 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
11948
d178f871
EZ
119492011-04-28 Eli Zaretskii <eliz@gnu.org>
11950
11951 * doprnt.c (doprnt): Don't return value smaller than the buffer
11952 size if the message was truncated. (Bug#8545).
11953
b124fd93
JB
119542011-04-28 Juanma Barranquero <lekktu@gmail.com>
11955
11956 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
11957 (Fx_window_property): #if-0 the whole functions, not just the bodies.
11958
e810457d
PE
119592011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11960
11961 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
11962
ea51cceb
JB
119632011-04-27 Juanma Barranquero <lekktu@gmail.com>
11964
11965 * makefile.w32-in: Update dependencies.
11966
94dcfacf
EZ
119672011-04-27 Eli Zaretskii <eliz@gnu.org>
11968
11969 Improve `doprnt' and its usage. (Bug#8545)
11970 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
11971 `format_end'. Remove support for %l as a conversion specifier.
11972 Don't use xrealloc. Improve diagnostics when the %l size modifier
11973 is used. Update the commentary.
11974
11975 * eval.c (verror): Simplify calculation of size_t.
11976
11977 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
11978 messages.
11979
f61f41d7
PE
119802011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
11981
11982 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
11983 change.
11984
96fb4434
PE
119852011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11986
11987 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
11988 This makes this file independent of the recent pseudovector change.
11989
671875da 119902011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 11991
69e9b5a3
PE
11992 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
11993
b5f869a7 11994 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 11995 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 11996 Remove unused local.
c8926152 11997 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 11998
841a1577 11999 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
12000 GCC 4.6.0 optimizes based on type-based alias analysis.
12001 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
12002 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
12003 != &v->size, and therefore "v->size = 1; b->size = 2; return
12004 v->size;" must therefore return 1. This assumption is incorrect
12005 for Emacs, since it type-puns struct Lisp_Vector * with many other
12006 types. To fix this problem, this patch adds a new type struct
f904488f 12007 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
12008 and pseudovectors, and helps optimizing compilers not get fooled
12009 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
12010 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
12011 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
12012 the size member.
eab3844f
PE
12013 (XSETPVECTYPE): Rewrite in terms of new macro.
12014 (XSETPVECTYPESIZE): New macro, specifying both type and size.
12015 This is a bit clearer, and further avoids the possibility of
12016 undesirable aliasing.
12017 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 12018 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
12019 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
12020 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
12021 (ASIZE): Now uses header.size rather than size.
12022 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
12023 to avoid the hassle of writing XVECTOR (foo)->header.size.
12024 (struct vectorlike_header): New type.
eab3844f
PE
12025 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
12026 object, to help avoid aliasing.
12027 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
12028 (SUBRP): Likewise, since Lisp_Subr is a special case.
12029 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
12030 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
12031 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 12032 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
12033 changed to be "header.size" and "header.next".
12034 * buffer.h (struct buffer): Likewise.
12035 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
12036 * frame.h (struct frame): Likewise.
12037 * process.h (struct Lisp_Process): Likewise.
12038 * termhooks.h (struct terminal): Likewise.
12039 * window.c (struct save_window_data, struct saved_window): Likewise.
12040 * window.h (struct window): Likewise.
12041 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
12042 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
12043 * buffer.c (init_buffer_once): Likewise.
12044 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
12045 special case.
12046 * process.c (Fformat_network_address): Use local var for size,
12047 for brevity.
12048
0df1eac5
PE
12049 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
12050
847ab9d1 12051 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
12052 * data.c (atof): Remove decl; no longer used or needed.
12053 (digit_to_number): Move to lread.c.
12054 (Fstring_to_number): Use new string_to_number function, to be
12055 consistent with how the Lisp reader treats infinities and NaNs.
12056 Do not assume that floating-point numbers represent EMACS_INT
12057 without losing information; this is not true on most 64-bit hosts.
12058 Avoid double-rounding errors, by insisting on integers when
12059 parsing non-base-10 numbers, as the documentation specifies.
12060 * lisp.h (string_to_number): New decl, replacing ...
12061 (isfloat_string): Remove.
bc0a5c13 12062 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 12063 (read1): Do not accept +. and -. as integers; this
452f4150
PE
12064 appears to have been a coding error. Similarly, do not accept
12065 strings like +-1e0 as floating point numbers. Do not report
12066 overflow for integer overflows unless the base is not 10 which
12067 means we have no simple and reliable way to continue.
12068 Break out the floating-point parsing into a new
12069 function string_to_number, so that Fstring_to_number parses
12070 floating point numbers consistently with the Lisp reader.
04f2d78b 12071 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
12072 (E_CHAR, EXP_INT): Remove, replacing with ...
12073 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
12074 (string_to_number): New function, replacing isfloat_string.
12075 This function checks for valid syntax and produces the resulting
12076 Lisp float number too. Rework it so that string-to-number
bc0a5c13 12077 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
12078 so that overflow for non-base-10 numbers is reported only when
12079 there's no portable and simple way to convert to floating point.
452f4150 12080
67769ffc
PE
12081 * textprop.c (set_text_properties_1): Rewrite for clarity,
12082 and to avoid GCC warning about integer overflow.
12083
c20db43f
PE
12084 * intervals.h (struct interval): Use EMACS_INT for members
12085 where EMACS_UINT might cause problems. See
12086 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
12087 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
12088 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
12089 All uses changed.
37aa2f85
PE
12090 (offset_intervals): Tell GCC not to worry about length overflow
12091 when negating a negative length.
c20db43f 12092
2538aa2f
PE
12093 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
12094 (overrun_check_free): Likewise.
12095
f2d3008d
PE
12096 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
12097 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
12098 word size.
12099
ec8df744
PE
12100 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12101 (gnutls_make_error): Rename local to avoid shadowing.
12102 (gnutls_emacs_global_deinit): ifdef out; not used.
12103 (Fgnutls_boot): Use const for pointer to readonly storage.
12104 Comment out unused local. Fix pointer signedness problems.
12105
640ee02d
PE
12106 * lread.c (openp): Don't stuff size_t into an 'int'.
12107 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
12108 about possible signed overflow.
12109
6048fb2a
PE
12110 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12111 (GDK_KEY_g): Don't define if already defined.
12112 (xg_prepare_tooltip): Avoid pointer signedness problem.
12113 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
12114
fa3c87e1
PE
12115 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
12116 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
12117
2172544b
PE
12118 * xfns.c (Fx_window_property): Simplify a bit,
12119 to make a bit faster and to avoid GCC 4.6.0 warning.
12120 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
12121
9b821a21
PE
12122 * fns.c (internal_equal): Don't assume size_t fits in int.
12123
3c616cfa
PE
12124 * alloc.c (compact_small_strings): Tighten assertion a little.
12125
c2982e87
PE
12126 Replace pEd with more-general pI, and fix some printf arg casts.
12127 * lisp.h (pI): New macro, generalizing old pEd macro to other
12128 conversion specifiers. For example, use "...%"pI"d..." rather
12129 than "...%"pEd"...".
12130 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 12131 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
12132 * alloc.c (check_pure_size): Don't overflow by converting size to int.
12133 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
12134 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
12135 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
12136 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
12137 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
12138 64-bit hosts.
12139 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
12140 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
12141 * print.c (safe_debug_print, print_object): Likewise.
12142 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
12143 to int.
6f04d126
PE
12144 Use pI instead of if-then-else-abort. Use %p to avoid casts,
12145 avoiding the 0 flag, which is not portable.
c2982e87
PE
12146 * process.c (Fmake_network_process): Use pI to avoid cast.
12147 * region-cache.c (pp_cache): Likewise.
12148 * xdisp.c (decode_mode_spec): Likewise.
12149 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
12150 behavior on 64-bit hosts with printf arg.
6f04d126 12151 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
12152 (x_stop_queuing_selection_requests): Likewise.
12153 (x_get_window_property): Don't truncate byte count to an 'int'
12154 when tracing.
0b432f21 12155
5e073ec7
PE
12156 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
12157 here, since it parses constructs like leading '-' and spaces,
12158 which are not wanted; and it overflows with large numbers.
12159 Instead, simply match F[0-9]+, which is what is wanted anyway.
12160
36372bf9
PE
12161 * alloc.c: Remove unportable assumptions about struct layout.
12162 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
12163 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
12164 (allocate_vectorlike, make_pure_vector): Use the new macros,
12165 plus offsetof, to remove unportable assumptions about struct layout.
12166 These assumptions hold on all porting targets that I know of, but
12167 they are not guaranteed, they're easy to remove, and removing them
12168 makes further changes easier.
12169
0b432f21
PE
12170 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
12171 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
12172 (string_overrun_cookie): Now const. Use initializers that
12173 don't formally overflow signed char, to avoid warnings.
000098c1
PE
12174 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
12175 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
12176 (allocate_buffer): Don't assume sizeof (struct buffer) is a
12177 multiple of sizeof (EMACS_INT); it need not be, if
12178 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 12179 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 12180
895009e1
JB
121812011-04-26 Juanma Barranquero <lekktu@gmail.com>
12182
12183 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
12184
6a7a1b0b
TZ
121852011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
12186
12187 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 12188 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
12189 Reported by Paul Eggert <eggert@cs.ucla.edu>.
12190
841a1577 121912011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
12192
12193 * lisp.h (Qdebug): List symbol.
895009e1 12194 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
12195 * keyboard.c (debug-on-event): New variable.
12196 (handle_user_signal): Break into debugger when debug-on-event
12197 matches the current signal symbol.
12198
f2d3ba6f
DN
121992011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
12200
12201 * alloc.c (check_sblock, check_string_bytes)
12202 (check_string_free_list): Convert to standard C.
12203
42ce4c63
TZ
122042011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
12205
12206 * w32.c (emacs_gnutls_push): Fix typo.
12207
825cd63c
EZ
122082011-04-25 Eli Zaretskii <eliz@gnu.org>
12209
fb11d64d
EZ
12210 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
12211 "cast to pointer from integer of different size".
12212
825cd63c
EZ
12213 Improve doprnt and its use in verror. (Bug#8545)
12214 * doprnt.c (doprnt): Document the set of format control sequences
12215 supported by the function. Use SAFE_ALLOCA instead of always
12216 using `alloca'.
12217
12218 * eval.c (verror): Don't limit the buffer size at size_max-1, that
12219 is one byte too soon. Don't use xrealloc; instead xfree and
12220 xmalloc anew.
12221
e061a11b
TZ
122222011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
12223
12224 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
12225 callbacks stage.
12226
12227 * gnutls.c: Renamed global_initialized to
12228 gnutls_global_initialized. Added internals for the
12229 :verify-hostname-error, :verify-error, and :verify-flags
12230 parameters of `gnutls-boot' and documented those parameters in the
12231 docstring. Start callback support.
9173deec
JB
12232 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
12233 unless a fatal error occurred. Call gnutls_alert_send_appropriate
12234 on error. Return error code.
e061a11b
TZ
12235 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
12236 (emacs_gnutls_read): Likewise.
12237 (Fgnutls_boot): Return handshake error code.
12238 (emacs_gnutls_handle_error): New function.
12239 (wsaerror_to_errno): Likewise.
12240
12241 * w32.h (emacs_gnutls_pull): Add prototype.
12242 (emacs_gnutls_push): Likewise.
12243
12244 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
12245 (emacs_gnutls_push): Likewise.
12246
122472011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
12248
12249 * process.c (wait_reading_process_output): Check if GnuTLS
12250 buffered some data internally if no FDs are set for TLS
12251 connections.
12252
12253 * makefile.w32-in (OBJ2): Add gnutls.$(O).
12254 (LIBS): Link to USER_LIBS.
12255 ($(BLD)/gnutls.$(0)): New target.
12256
fa6996bc
EZ
122572011-04-24 Eli Zaretskii <eliz@gnu.org>
12258
eb35682e
EZ
12259 * xdisp.c (handle_single_display_spec): Rename the
12260 display_replaced_before_p argument into display_replaced_p, to
12261 make it consistent with the commentary. Fix typos in the
12262 commentary.
12263
e2ad650c
EZ
12264 * textprop.c (syms_of_textprop): Remove dead code.
12265 (copy_text_properties): Delete obsolete commentary about an
12266 interface that was deleted long ago. Fix typos in the description
12267 of arguments.
12268
1b2de274
EZ
12269 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
12270 to changes in oldXMenu/XMenu.h from 2011-04-16.
12271 <menu_help_message, prev_menu_help_message>: Constify.
12272 (IT_menu_make_room): menu->help_text is now `const char **';
12273 adjust.
12274
12275 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
12276 to changes in oldXMenu/XMenu.h from 2011-04-16.
12277 (struct XMenu): Declare `help_text' `const char **'.
12278
12279 * xfaces.c <Qunspecified>: Make extern again.
12280
12281 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 12282 required by POSIX.
1b2de274 12283
762b15be
EZ
12284 * doc.c (get_doc_string): Improve the format passed to `error'.
12285
12286 * doprnt.c (doprnt): Improve commentary.
12287
12288 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
12289
12290 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
12291 them with etags.
12292
f1052e5d
EZ
12293 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
12294 changes in globals.h immediately force recompilation.
762b15be
EZ
12295 (TAGS): Depend on $(CURDIR)/m/intel386.h and
12296 $(CURDIR)/s/ms-w32.h.
12297 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 12298
fa6996bc
EZ
12299 * character.c (Fchar_direction): Function deleted.
12300 (syms_of_character): Don't defsubr it.
12301 <char-direction-table>: Deleted.
12302
e6c3da20
EZ
123032011-04-23 Eli Zaretskii <eliz@gnu.org>
12304
12305 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
12306 * doprnt.c: Include limits.h.
12307 (SIZE_MAX): New macro.
04f2d78b
CB
12308 (doprnt): Return a size_t value. 2nd arg is now size_t.
12309 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
12310 Improve overflow protection. Support `l' modifier for integer
12311 conversions. Support %l conversion. Don't assume an EMACS_INT
12312 argument for integer conversions and for %c.
12313
12314 * lisp.h (doprnt): Restore prototype.
12315
12316 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
12317 $(SRC)/character.h.
12318
12319 * Makefile.in (base_obj): Add back doprnt.o.
12320
12321 * deps.mk (doprnt.o): Add back prerequisites.
12322 (callint.o): Depend on character.h.
12323
12324 * eval.c (internal_lisp_condition_case): Include the handler
12325 representation in the error message.
12326 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
12327 when breaking from the loop.
12328
12329 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
12330
12331 * callint.c (Fcall_interactively): When displaying error message
12332 about invalid control letter, pass the character's codepoint, not
12333 a pointer to its multibyte form. Improve display of the character
12334 in octal and display also its hex code.
12335
12336 * character.c (char_string): Use %x to display the (unsigned)
12337 codepoint of an invalid character, to avoid displaying a bogus
12338 negative value.
12339
12340 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
12341 `error', not SYMBOL_NAME itself.
12342
12343 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
12344 character arguments to `error'.
12345
12346 * charset.c (check_iso_charset_parameter): Fix incorrect argument
12347 to `error' in error message about FINAL_CHAR argument. Make sure
12348 FINAL_CHAR is a character, and use %c when it is passed as
12349 argument to `error'.
12350
4ffd0d6b 123512011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
12352
12353 * s/ms-w32.h (localtime): Redirect to sys_localtime.
12354
12355 * w32.c: Include <time.h>.
12356 (sys_localtime): New function.
12357
4ffd0d6b 123582011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
12359
12360 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
12361
4ffd0d6b 12362 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 12363
4ffd0d6b 123642011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 12365
4ffd0d6b
GM
12366 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
12367 zombies (Bug#8467).
aac0c6e3 12368
04c56954
EZ
123692011-04-19 Eli Zaretskii <eliz@gnu.org>
12370
12371 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
12372 gl_state.e_property when gl_state.object is Qt.
12373
12374 * insdel.c (make_gap_larger): Remove limitation of buffer size
12375 to <= INT_MAX.
12376
16a43933
CY
123772011-04-18 Chong Yidong <cyd@stupidchicken.com>
12378
12379 * xdisp.c (lookup_glyphless_char_display)
12380 (produce_glyphless_glyph): Handle cons cell entry in
12381 glyphless-char-display.
12382 (Vglyphless_char_display): Document it.
12383
12384 * term.c (produce_glyphless_glyph): Handle cons cell entry in
12385 glyphless-char-display.
12386
4581706e
CY
123872011-04-17 Chong Yidong <cyd@stupidchicken.com>
12388
12389 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
12390
12391 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
12392
12393 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
12394 definition for no-X builds.
12395
4887c6e2 123962011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 12397
fd35b6f9
PE
12398 Static checks with GCC 4.6.0 and non-default toolkits.
12399
5c1ccb01
PE
12400 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
12401
006c5daa
PE
12402 * process.c (keyboard_bit_set): Define only if SIGIO.
12403 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
12404 (send_process): Repair possible setjmp clobbering.
12405
efc736d3
PE
12406 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
12407
4e2fe2e6
PE
12408 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
12409
f97334a2
PE
12410 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
12411
4e75f29d
PE
12412 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
12413 Define only if needed.
12414
90efadd1
PE
12415 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
12416 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 12417 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 12418
3c647824
PE
12419 * dispextern.h (struct redisplay_interface): Rename param
12420 to avoid shadowing.
e264f262 12421 * termhooks.h (struct terminal): Likewise.
761383f4 12422 * xterm.c (xembed_send_message): Likewise.
3c647824 12423
b58c5c4a
PE
12424 * insdel.c (make_gap_smaller): Define only if
12425 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
12426
cad59032
PE
12427 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
12428 it.
12429
c339dc2e
PE
12430 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
12431 so that we aren't warned about unused symbols.
12432
91a3e27b
PE
12433 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
12434
399c71d3 12435 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 12436
8ffc96f5
PE
12437 * xfns.c (x_real_positions): Mark locals as initialized.
12438
eef9bc79
PE
12439 * xmenu.c (xmenu_show): Don't use uninitialized vars.
12440
098db9dd
PE
12441 * xterm.c: Fix problems found by static analysis with other toolkits.
12442 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
12443 (x_dispatch_event): Declare static if USE_GTK, and
12444 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 12445 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 12446 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
12447 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
12448 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 12449
eb18f6cc
PE
12450 * xmenu.c (menu_help_callback): Pointer type fixes.
12451 Use const pointers when pointing at readonly data. Avoid pointer
12452 signedness clashes.
12453 (FALSE): Remove unused macro.
12454 (update_frame_menubar): Remove unused decl.
12455
1fe72bf8
PE
12456 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
12457
60d9e1db
PE
12458 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
12459 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
12460 (single_menu_item): Rename local to avoid shadowing.
12461
39261c26
PE
12462 * keyboard.c (make_lispy_event): Remove unused local var.
12463
018c5e19
PE
12464 * frame.c, frame.h (x_get_resource_string): Bring this back, but
12465 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
12466
63d2b86e
PE
12467 * bitmaps: Change bitmaps from unsigned char back to the X11
12468 compatible char. Avoid the old compiler warnings about
12469 out-of-range initializers by using, for example, '\xab' rather
12470 than 0xab.
12471
aefd87e1
PE
12472 * xgselect.c (xgselect_initialize): Check vs interface
12473 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
12474
bf501fb9
PE
12475 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
12476
e9829fdf
PE
12477 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
12478 to read-only memory.
12479
1086c095
PE
12480 * fns.c (vector): Remove; this old hack is no longer needed.
12481
2baccd04 12482 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 12483 Remove unused var.
dde42981 12484 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 12485
72391843 12486 * xrdb.c (x_load_resources): Omit unused local.
3565b346 12487
436c16df 12488 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 12489 (x_window): Rename locals to avoid shadowing.
dc5ddd85 12490 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 12491
92bb796d 12492 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 12493 (x_term_init): Remove local to avoid shadowing.
92bb796d 12494
764430a3 12495 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
12496
12497 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
12498 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
12499
d1dfb56c
EZ
125002011-04-16 Eli Zaretskii <eliz@gnu.org>
12501
c4354cb4
EZ
12502 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
12503
d1dfb56c
EZ
12504 Fix regex.c, syntax.c and friends for buffers > 2GB.
12505 * syntax.h (struct gl_state_s): Declare character position members
12506 EMACS_INT.
12507
12508 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
12509
04f2d78b
CB
12510 * textprop.c (verify_interval_modification, interval_of):
12511 Declare arguments EMACS_INT.
d1dfb56c
EZ
12512
12513 * intervals.c (adjust_intervals_for_insertion): Declare arguments
12514 EMACS_INT.
12515
12516 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
12517
12518 * indent.c (Fvertical_motion): Local variable it_start is now
12519 EMACS_INT.
12520
12521 * regex.c (re_match, re_match_2, re_match_2_internal)
12522 (bcmp_translate, regcomp, regexec, print_double_string)
12523 (group_in_compile_stack, re_search, re_search_2, regex_compile)
12524 (re_compile_pattern, re_exec): Declare arguments and local
12525 variables `size_t' and `ssize_t' and return values `regoff_t', as
12526 appropriate.
12527 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
12528 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
12529 <compile_stack_type>: `size' and `avail' are now `size_t'.
12530
12531 * regex.h <regoff_t>: Use ssize_t, not int.
12532 (re_search, re_search_2, re_match, re_match_2): Arguments that
12533 specify buffer/string position and length are now ssize_t and
12534 size_t. Return type is regoff_t.
12535
613052cd
BK
125362011-04-16 Ben Key <bkey76@gmail.com>
12537
12538 * nsfont.m: Fixed bugs in ns_get_family and
12539 ns_descriptor_to_entity that were caused by using free to
12540 deallocate memory blocks that were allocated by xmalloc (via
12541 xstrdup). This caused Emacs to crash when compiled with
12542 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
12543 --enable-checking=xmallocoverrun). xfree is now used to
12544 deallocate these memory blocks.
12545
4170f62f 125462011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 12547
71b41406
PE
12548 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
12549
9587a89d
PE
12550 emacs_write: Accept and return EMACS_INT for sizes.
12551 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
12552 et seq.
12553 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
12554 Accept and return EMACS_INT.
12555 (emacs_gnutls_write): Return the number of bytes written on
12556 partial writes.
12557 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
12558 (emacs_read, emacs_write): Remove check for negative size, as the
12559 Emacs source code has been audited now.
9587a89d
PE
12560 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
12561 (emacs_read, emacs_write): Use it.
273a5f82
PE
12562 * process.c (send_process): Adjust to the new signatures of
12563 emacs_write and emacs_gnutls_write. Do not attempt to store
12564 a byte offset into an 'int'; it might overflow.
9587a89d 12565 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 12566
3e047f51
PE
12567 * sound.c: Don't assume sizes fit in 'int'.
12568 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 12569 Return EMACS_INT, not int.
3e047f51 12570 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
12571 Accept EMACS_INT, not int.
12572 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
12573 record read return values.
12574
cc39a9db
BK
125752011-04-15 Ben Key <bkey76@gmail.com>
12576
c9d0ec6d
JB
12577 * keyboard.c (Qundefined): Don't declare static since it is used
12578 in nsfns.m.
12579 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
12580 static since they are used in nsfont.m.
cc39a9db 12581
6c60eb9f
SM
125822011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
12583
12584 * process.c (Qprocessp): Don't declare static.
12585 * lisp.h (Qprocessp): Declare again.
12586
7990b61a
JB
125872011-04-15 Juanma Barranquero <lekktu@gmail.com>
12588
12589 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
12590
5d4cb038
PE
125912011-04-14 Paul Eggert <eggert@cs.ucla.edu>
12592
8bd7b830 12593 Improve C-level modularity by making more things 'static'.
cd64ea1d 12594
e3b27b31
PE
12595 Don't publish debugger-only interfaces to other modules.
12596 * lisp.h (safe_debug_print, debug_output_compilation_hack):
12597 (verify_bytepos, count_markers): Move decls to the only modules
12598 that need them.
12599 * region-cache.h (pp_cache): Likewise.
12600 * window.h (check_all_windows): Likewise.
12601 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
12602
5d4cb038
PE
12603 * sysdep.c (croak): Now static, if
12604 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
12605 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
12606
12607 * alloc.c (refill_memory_reserve): Now static if
12608 !defined REL_ALLOC || defined SYSTEM_MALLOC.
12609 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 12610
e87b6180
PE
12611 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
12612 Define only if USE_LUCID.
12613
ac64929e
PE
12614 * xrdb.c (x_customization_string, x_rm_string): Now static.
12615
6f37259d
PE
12616 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
12617 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
12618
1683e3ab
PE
12619 * xdisp.c (draw_row_with_mouse_face): Now static.
12620 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
12621
de9c2632
PE
12622 * window.h (check_all_windows): Mark externally visible.
12623
2b96acb7
PE
12624 * window.c (window_deletion_count): Now static.
12625
12626 * undo.c: Make symbols static if they're not exported.
12627 (last_undo_buffer, last_boundary_position, pending_boundary):
12628 Now static.
12629
50436f33
PE
12630 * textprop.c (interval_insert_behind_hooks): Now static.
12631 (interval_insert_in_front_hooks): Likewise.
12632
64520e5c
PE
12633 * term.c: Make symbols static if they're not exported.
12634 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
12635 (max_frame_lines, tty_set_terminal_modes):
12636 (tty_reset_terminal_modes, tty_turn_off_highlight):
12637 (get_tty_terminal): Now static.
12638 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
12639 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 12640 HAVE_WINDOW_SYSTEM.
64520e5c
PE
12641 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
12642 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
12643
1fa53021
PE
12644 * sysdep.c: Make symbols static if they're not exported.
12645 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
12646 Now static.
12647 (sigprocmask_set, full_mask): Remove; unused.
12648 (wait_debugging): Mark as visible.
12649 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
12650 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
12651
d4b43b22
PE
12652 * syntax.c (syntax_temp): Define only if !__GNUC__.
12653
b7c513d0
PE
12654 * sound.c (current_sound_device, current_sound): Now static.
12655
989b29ad
PE
12656 * search.c (searchbufs, searchbuf_head): Now static.
12657
13a55a78
PE
12658 * scroll.c (scroll_cost): Remove; unused.
12659 * dispextern.h (scroll_cost): Remove decl.
12660
de68a1fc
PE
12661 * region-cache.h (pp_cache): Mark as externally visible.
12662
40ccffa6
PE
12663 * process.c: Make symbols static if they're not exported.
12664 (process_tick, update_tick, create_process, chan_process):
12665 (Vprocess_alist, proc_buffered_char, datagram_access):
12666 (fd_callback_data, send_process_frame, process_sent_to): Now static.
12667 (deactivate_process): Mark defn as static, as well as decl.
12668 * lisp.h (create_process): Remove decl.
12669 * process.h (chan_process, Vprocess_alist): Remove decls.
12670
ad64fc97
PE
12671 * print.c: Make symbols static if they're not exported.
12672 (print_depth, new_backquote_output, being_printed, print_buffer):
12673 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
12674 (print_interval, print_number_index, initial_stderr_stream):
12675 Now static.
12676 * lisp.h (Fprinc): Remove decl.
12677 (debug_output_compilation_hack): Mark as externally visible.
12678
adddb265
PE
12679 * sysdep.c (croak): Move decl from here to syssignal.h.
12680 * syssignal.h (croak): Put it here, so the API can be checked when
12681 'croak' is called from dissociate_if_controlling_tty.
12682
1717ede2
PE
12683 * minibuf.c: Make symbols static if they're not exported.
12684 (minibuf_save_list, choose_minibuf_frame): Now static.
12685 * lisp.h (choose_minibuf_frame): Remove decl.
12686
fa5fb2bc
PE
12687 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
12688
1e3890d1
PE
12689 * lread.c: Make symbols static if they're not exported.
12690 (read_objects, initial_obarray, oblookup_last_bucket_number):
12691 Now static.
12692 (make_symbol): Remove; unused.
12693 * lisp.h (initial_obarray, make_symbol): Remove decls.
12694
8a1414fa
PE
12695 * keyboard.c: Make symbols static if they're not exported.
12696 (single_kboard, recent_keys_index, total_keys, recent_keys):
12697 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
12698 (this_single_command_key_start, echoing, last_auto_save):
12699 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
12700 (command_loop, echo_now, keyboard_init_hook, help_char_p):
12701 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
12702 (Vlispy_mouse_stem, double_click_count):
12703 Now static.
12704 (force_auto_save_soon): Define only if SIGDANGER.
12705 (ignore_mouse_drag_p): Now static if
12706 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
12707 (print_help): Remove; unused.
12708 (stop_character, last_timer_event): Mark as externally visible.
12709 * keyboard.h (ignore_mouse_drag_p): Declare only if
12710 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
12711 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
12712 * lisp.h (echoing): Remove decl.
12713 (force_auto_save_soon): Declare only if SIGDANGER.
12714 * xdisp.c (redisplay_window): Simplify code, to make it more
12715 obvious that ignore_mouse_drag_p is not accessed if !defined
12716 USE_GTK && !defined HAVE_NS.
12717
93ea6e8f
PE
12718 * intervals.c: Make symbols static if they're not exported.
12719 (merge_properties_sticky, merge_interval_right, delete_interval):
12720 Now static.
12721 * intervals.h (merge_interval_right, delete_interval): Remove decls.
12722
77382fcc
PE
12723 * insdel.c: Make symbols static if they're not exported.
12724 However, leave prepare_to_modify_buffer alone. It's never
12725 called from outside this function, but that appears to be a bug.
12726 (combine_after_change_list, combine_after_change_buffer):
4889fc82 12727 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
12728 (adjust_after_replace_noundo): Remove; unused.
12729 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 12730 (signal_before_change): Remove decls.
77382fcc 12731
9306c32e
PE
12732 * indent.c (val_compute_motion, val_vmotion): Now static.
12733
cd44d2eb
PE
12734 * image.c: Make symbols static if they're not exported.
12735 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
12736 if USE_GTK.
12737 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
12738 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
12739
ad9a7a06
PE
12740 * fringe.c (standard_bitmaps): Now static.
12741 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
12742
81626931
PE
12743 * frame.c: Make symbols static if they're not exported.
12744 (x_report_frame_params, make_terminal_frame): Now static.
12745 (get_frame_param): Now static, unless HAVE_NS.
12746 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
12747 (x_get_resource_string): Remove; not used.
12748 * frame.h (make_terminal_frame, x_report_frame_params):
12749 (x_get_resource_string); Remove decls.
12750 (x_fullscreen_adjust): Declare only if WINDOWSNT.
12751 * lisp.h (get_frame_param): Declare only if HAVE_NS.
12752
239f9db9
PE
12753 * font.c, fontset.c: Make symbols static if they're not exported.
12754 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
12755 (FACE_SUITABLE_FOR_CHAR_P): Use it.
12756 * font.c (font_close_object): Now static.
12757 * font.h (font_close_object): Remove.
12758 * fontset.c (FONTSET_OBJLIST): Remove.
12759 (free_realized_fontset) #if-0 the body, which does nothing.
12760 (face_suitable_for_char_p): #if-0, as it's never called.
12761 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
12762 * xfaces.c (face_at_string_position):
12763 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
12764 since 0 is always ASCII.
12765
dfcf3579
PE
12766 * fns.c (weak_hash_tables): Now static.
12767
5045092b
PE
12768 * fileio.c: Make symbols static if they're not exported.
12769 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
12770 (Vwrite_region_annotation_buffers): Now static.
12771
57a96f5c
PE
12772 * eval.c: Make symbols static if they're not exported.
12773 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
12774 * lisp.h (backtrace_list): Remove decl.
12775
35f08c38
PE
12776 * emacs.c: Make symbols static if they're not exported.
12777 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
12778 (fatal_error_code, fatal_error_signal_hook, standard_args):
12779 Now static.
12780 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
12781 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
12782 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
12783 * lisp.h (fatal_error_signal_hook): Remove decl.
12784 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
12785
f44bd759
PE
12786 * editfns.c: Move a (normally-unused) function to its only use.
12787 * editfns.c, lisp.h (get_operating_system_release): Remove.
12788 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
12789 worth the hassle of breaking this out.
12790
b532497d
PE
12791 * xterm.c: Make symbols static if they're not exported.
12792 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
12793 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
12794 (x_destroy_window, x_delete_display):
12795 Now static.
12796 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
12797 (x_mouse_leave): Remove; unused.
12798 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
12799 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
12800 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
12801 Remove decls.
12802 (x_mouse_leave): Declare only if WINDOWSNT.
12803 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
12804 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
12805 USE_X_TOOLKIT.
12806
1675728f
PE
12807 * ftxfont.c: Make symbols static if they're not exported.
12808 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
12809 HAVE_FREETYPE.
12810 * font.h (ftxfont_driver): Likewise.
12811
e4cebfca
PE
12812 * xfns.c: Make symbols static if they're not exported.
12813 (x_last_font_name, x_display_info_for_name):
12814 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
12815 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
12816 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
12817 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
12818 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
12819 (last_show_tip_args): Now static.
12820 (xic_defaut_fontset, xic_create_fontsetname): Define only if
12821 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
12822 (x_screen_planes): Remove; unused.
12823 * dispextern.h (x_screen_planes): Remove decl.
12824
5bf46f05
PE
12825 * dispnew.c: Make symbols static if they're not exported.
12826 * dispextern.h (redraw_garbaged_frames, scrolling):
12827 (increment_row_positions): Remove.
12828 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
12829 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
12830 Now static.
12831 (redraw_garbaged_frames): Remove; unused.
12832
435f4c28
PE
12833 * xfaces.c: Make symbols static if they're not exported.
12834 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
12835 Remove decls.
12836 * xterm.h (defined_color): Remove decls.
12837 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
12838 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
12839 (menu_face_changed_default, defined_color, free_realized_face):
12840 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
12841 (ascii_face_of_lisp_face): Remove; unused.
12842
8524aef3
PE
12843 * xdisp.c: Make symbols static if they're not exported.
12844 * dispextern.h (scratch_glyph_row, window_box_edges):
12845 (glyph_to_pixel_coords, set_cursor_from_row):
12846 (get_next_display_element, set_iterator_to_next):
12847 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
12848 (show_mouse_face): Remove decls
12849 * frame.h (message_buf_print): Likewise.
12850 * lisp.h (pop_message, set_message, check_point_in_composition):
12851 Likewise.
12852 * xterm.h (set_vertical_scroll_bar): Likewise.
12853 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
12854 (message_buf_print, scratch_glyph_row, displayed_buffer):
12855 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
12856 (get_next_display_element, show_mouse_face, window_box_edges):
12857 (frame_to_window_pixel_xy, check_point_in_composition):
12858 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
12859 (glyph_to_pixel_coords): Remove; unused.
12860
16390cd2
PE
12861 * dired.c (file_name_completion): Now static.
12862
12863 * dbusbind.c (xd_in_read_queued_messages): Now static.
12864
a25f4dfa
PE
12865 * lisp.h (circular_list_error, FOREACH): Remove; unused.
12866 * data.c (circular_list_error): Remove.
12867
14a9c8df
PE
12868 * commands.h (last_point_position, last_point_position_buffer):
12869 (last_point_position_window): Remove decls.
12870 * keyboard.c: Make these variables static.
12871
04f2d78b
CB
12872 * coding.h (coding, code_convert_region, encode_coding_gap):
12873 Remove decls.
74ab6df5
PE
12874 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
12875 (iso_code_class, detect_coding, code_convert_region): Now static.
12876 (encode_coding_gap): Remove; unused.
12877
38dfbee1
PE
12878 * chartab.c (chartab_chars, chartab_bits): Now static.
12879
a2cb4e63
PE
12880 * charset.h (charset_iso_8859_1): Remove decl.
12881 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
12882 Now static.
12883
127198fd
PE
12884 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
12885 * ccl.c (Vccl_program_table): Now static.
12886 (check_ccl_update): Remove; unused.
12887
d85b608f
PE
12888 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
12889 * category.h: ... from here.
12890 * category.c (check_category_table, set_category_set): Now static.
12891
31cd66f3
PE
12892 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
12893 * lisp.h: Remove these decls.
12894
c358e587
PE
12895 * buffer.c (buffer_count): Remove unused var.
12896
e78aecca
PE
12897 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
12898 so that it's not optimized away.
12899 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
12900 * dispextern.h (bidi_dump_cached_states): Remove, since it's
12901 exported only to the debugger.
12902
e192d7d3 12903 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 12904 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 12905
92470028
PE
12906 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
12907 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
12908 was inaccessible from Lisp.
12909 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
12910 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
12911
244ed907
PE
12912 alloc.c: Import and export fewer symbols, and remove unused items.
12913 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
12914 is defined.
12915 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
12916 it's not optimized away by whole-program optimization.
12917 (message_enable_multibyte, free_misc): Remove.
12918 (catchlist, handlerlist, mark_backtrace):
12919 Declare only if BYTE_MARK_STACK.
12920 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
12921 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
12922 (message_enable_multibyte): Remove decl.
12923 (free_misc, interval_free_list, float_block, float_block_index):
12924 (n_float_blocks, float_free_list, cons_block, cons_block_index):
12925 (cons_free_list, last_marked_index):
12926 Now static.
12927 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
12928 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
12929 (mark_backtrace): Define only if BYTE_MARK_STACK.
12930 * xdisp.c (message_enable_multibyte): Now static.
12931
61c2b50e 12932 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
12933 This makes it easier for human readers (and static analyzers)
12934 to see whether these variables are used from other modules.
12935 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
12936 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
12937 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
12938 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
12939 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
12940 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
12941 * xmenu.c, xselect.c:
12942 Declare Q* vars static if they are not used in other modules.
12943 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
12944 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
12945 Remove decls of unexported vars.
12946 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
12947
95c82688
PE
12948 * lisp.h (DEFINE_FUNC): Make sname 'static'.
12949
16a97296
PE
12950 Make Emacs functions such as Fatom 'static' by default.
12951 This makes it easier for human readers (and static analyzers)
12952 to see whether these functions can be called from other modules.
12953 DEFUN now defines a static function. To make the function external
12954 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
12955 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
12956 (Finit_image_library):
16a97296
PE
12957 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
12958 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
12959 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
12960 Remove decls, since these functions are now static.
12961 (Funintern, Fget_internal_run_time): New decls, since these functions
12962 were already external.
95c82688 12963
16a97296
PE
12964 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
12965 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
12966 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
12967 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
12968 * keyboard.c, keymap.c, lread.c:
12969 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
12970 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
12971 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
12972 Mark functions with DEFUE instead of DEFUN,
12973 if they are used in other modules.
12974 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
12975 decls for now-static functions.
12976 * buffer.h (Fdelete_overlay): Remove decl.
12977 * callproc.c (Fgetenv_internal): Mark as internal.
12978 * composite.c (Fremove_list_of_text_properties): Remove decl.
12979 (Fcomposition_get_gstring): New forward static decl.
12980 * composite.h (Fcomposite_get_gstring): Remove decl.
12981 * dired.c (Ffile_attributes): New forward static decl.
12982 * doc.c (Fdocumntation_property): New forward static decl.
12983 * eval.c (Ffetch_bytecode): New forward static decl.
12984 (Funintern): Remove extern decl; now in .h file where it belongs.
12985 * fileio.c (Fmake_symbolic_link): New forward static decl.
12986 * image.c (Finit_image_library): New forward static decl.
12987 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
12988 * intervals.h (Fprevious_property_change):
12989 (Fremove_list_of_text_properties): Remove decls.
12990 * keyboard.c (Fthis_command_keys): Remove decl.
12991 (Fcommand_execute): New forward static decl.
12992 * keymap.c (Flookup_key): New forward static decl.
12993 (Fcopy_keymap): Now static.
12994 * keymap.h (Flookup_key): Remove decl.
12995 * process.c (Fget_process): New forward static decl.
12996 (Fprocess_datagram_address): Mark as internal.
12997 * syntax.c (Fsyntax_table_p): New forward static decl.
12998 (skip_chars): Remove duplicate decl.
12999 * textprop.c (Fprevious_property_change): New forward static decl.
13000 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
13001 Now internal.
13002 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
13003 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
13004
785bbd42
PE
13005 * editfns.c (Fformat): Remove unreachable code.
13006
8b913b57
AS
130072011-04-14 Andreas Schwab <schwab@linux-m68k.org>
13008
13009 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
13010 change. (Bug#8496)
13011
a6744a35
EZ
130122011-04-13 Eli Zaretskii <eliz@gnu.org>
13013
13014 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
13015 when at ZV. (Bug#8487)
13016
e7974947
AS
130172011-04-12 Andreas Schwab <schwab@linux-m68k.org>
13018
baad03f0
AS
13019 * charset.c (Fclear_charset_maps): Use xfree instead of free.
13020 (Bug#8437)
13021 * keyboard.c (parse_tool_bar_item): Likewise.
13022 * sound.c (sound_cleanup, alsa_close): Likewise.
13023 * termcap.c (tgetent): Likewise.
13024 * xfns.c (x_default_font_parameter): Likewise.
13025 * xsettings.c (read_and_apply_settings): Likewise.
13026
e7974947
AS
13027 * alloc.c (overrun_check_malloc, overrun_check_realloc)
13028 (overrun_check_free): Protoize.
13029
28272684
PE
130302011-04-12 Paul Eggert <eggert@cs.ucla.edu>
13031
13032 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
13033 since callers should never pass a negative size.
13034 Change the signature to match that of plain 'read' and 'write'; see
13035 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
13036 * lisp.h: Update prototypes of emacs_write and emacs_read.
13037
11997c76
EZ
130382011-04-11 Eli Zaretskii <eliz@gnu.org>
13039
13040 * xdisp.c (redisplay_window): Don't try to determine the character
13041 position of the scroll margin if the window start point w->startp
e896f03c 13042 is outside the buffer's accessible region. (Bug#8468)
11997c76 13043
8a2cbd72
EZ
130442011-04-10 Eli Zaretskii <eliz@gnu.org>
13045
13046 Fix write-region and its subroutines for buffers > 2GB.
13047 * fileio.c (a_write, e_write): Modify declaration of arguments and
13048 local variables to support buffers larger than 2GB.
13049 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
13050
13051 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
13052 argument, local variables, and return value.
13053
13054 * lisp.h: Update prototypes of emacs_write and emacs_read.
13055
13056 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
13057
4073e537 130582011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 13059
1ebfdcb6
PE
13060 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
13061
b2ded58d
PE
13062 Fix more problems found by GCC 4.6.0's static checks.
13063
7d66342c
PE
13064 * xdisp.c (vmessage): Use a better test for character truncation.
13065
bbf47d44
PE
13066 * charset.c (load_charset_map): <, not <=, for optimization,
13067 and to avoid potential problems with integer overflow.
9248994d 13068 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 13069 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 13070 * editfns.c (Fformat): Likewise.
1e69125e 13071 * syntax.c (skip_chars): Likewise.
3befa583 13072
e3019616
PE
13073 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
13074 This also lets GCC 4.6.0 generate slightly better loop code.
13075
becfa255
PE
13076 * callint.c (Fcall_interactively): <, not <=, for optimization.
13077 (Fcall_interactively): Count the number of arguments produced,
13078 not the number of arguments given. This is simpler and lets GCC
13079 4.6.0 generate slightly better code.
13080
dae0cd48
PE
13081 * ftfont.c: Distingish more carefully between FcChar8 and char.
13082 The previous code passed unsigned char * to a functions like
13083 strlen and xstrcasecmp that expect char *, which does not
13084 conform to the C standard.
13085 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
13086 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
13087 char * when the C standard requires it.
13088
76032d70
PE
13089 * keyboard.c (read_char): Remove unused var.
13090
eb3f1cc8
PE
13091 * eval.c: Port to Windows vsnprintf (Bug#8435).
13092 Include <limits.h>.
13093 (SIZE_MAX): Define if the headers do not.
13094 (verror): Do not give up if vsnprintf returns a negative count.
13095 Instead, grow the buffer. This ports to Windows vsnprintf, which
13096 does not conform to C99. Problem reported by Eli Zaretskii.
13097 Also, simplify the allocation scheme, by avoiding the need for
13098 calling realloc, and removing the ALLOCATED variable.
13099
70476b54
PE
13100 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
13101
12020a9e
PE
13102 Remove invocations of doprnt, as Emacs now uses vsnprintf.
13103 But keep the doprint source code for now, as we might revamp it
13104 and use it again (Bug#8435).
ea6c7ae6
PE
13105 * lisp.h (doprnt): Remove.
13106 * Makefile.in (base_obj): Remove doprnt.o.
13107 * deps.mk (doprnt.o): Remove.
13108
5fdb398c
PE
13109 error: Print 32- and 64-bit integers portably (Bug#8435).
13110 Without this change, on typical 64-bit hosts error ("...%d...", N)
13111 was used to print both 32- and 64-bit integers N, which relied on
13112 undefined behavior.
61bdb816 13113 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
13114 * lisp.h (error, verror): Mark as printf-like functions.
13115 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
13116 Report overflow in size calculations when allocating printf buffer.
13117 Do not truncate output string at its first null byte.
13118 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
13119 Truncate the output at a character boundary, since vsnprintf does not
13120 do that.
13121 * charset.c (check_iso_charset_parameter): Convert internal
13122 character to string before calling 'error', since %c now has the
13123 printf meaning.
13124 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
13125 overflow when computing char to be passed to 'error'. Do not
13126 pass Lisp_Object to 'error'; pass the integer instead.
13127 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
13128 formatted with plain %d.
13129
b189fa66
PE
13130 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
13131
bff87ef0
PE
13132 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
13133
7e2cac20
PE
13134 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
13135
ce4d90b5
PE
13136 * xterm.c (x_catch_errors): Remove duplicate declaration.
13137
266c9547
PE
13138 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
13139
79c49ad2
PE
13140 * xdisp.c, lisp.h (message_nolog): Remove; unused.
13141
368f4090
JM
131422011-04-10 Jim Meyering <meyering@redhat.com>
13143
13144 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
13145 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
13146 return ssize_t not "int", and use size_t as the buffer length.
13147 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
13148 * gnutls.h: Update declarations.
13149 * process.c (read_process_output): Use ssize_t, to match.
13150 (send_process): Likewise.
13151
a32d4040
CY
131522011-04-09 Chong Yidong <cyd@stupidchicken.com>
13153
13154 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
13155
8546720e 131562011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 13157
04f2d78b
CB
13158 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
13159 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 13160
8546720e
GM
13161 * xterm.c (handle_one_xevent):
13162 * xmenu.c (create_and_show_popup_menu):
13163 * xselect.c (x_decline_selection_request)
13164 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 13165
0a2f5c1a 131662011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
13167
13168 Fix some uses of `int' instead of EMACS_INT.
13169 * search.c (string_match_1, fast_string_match)
13170 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
13171 (scan_buffer, find_next_newline_no_quit)
13172 (find_before_next_newline, search_command, Freplace_match)
13173 (Fmatch_data): Make some `int' variables be EMACS_INT.
13174
13175 * xdisp.c (display_count_lines): 3rd argument and return value now
13176 EMACS_INT. All callers changed.
13177 (pint2hrstr): Last argument is now EMACS_INT.
13178
13179 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
13180 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
13181 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
13182 (decode_coding_utf_16, decode_coding_emacs_mule)
13183 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
13184 (decode_coding_ccl, decode_coding_charset)
13185 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
13186 (decode_coding_iso_2022, decode_coding_emacs_mule)
13187 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
13188 <char_offset, last_offset>: Declare EMACS_INT.
13189 (encode_coding_utf_8, encode_coding_utf_16)
13190 (encode_coding_emacs_mule, encode_invocation_designation)
13191 (encode_designation_at_bol, encode_coding_iso_2022)
13192 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
13193 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
13194 Declare EMACS_INT.
13195 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
13196 (encode_invocation_designation): Last argument P_NCHARS is now
13197 EMACS_INT.
13198 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
13199 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
13200
13201 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
13202 All users changed.
13203
13204 * ccl.c (Fccl_execute_on_string): Declare some variables
13205 EMACS_INT.
13206
8546720e 132072011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
13208
13209 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
13210
4e19a977
CS
132112011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
13212
13213 * process.c (Fformat_network_address): Doc fix.
13214
87302331
R
132152011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
13216
ee7683eb 13217 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 13218
cbb59342
CY
132192011-04-08 Chong Yidong <cyd@stupidchicken.com>
13220
13221 * keyboard.c (read_char): Call Lisp function help-form-show,
13222 instead of using internal_with_output_to_temp_buffer.
13223 (Qhelp_form_show): New var.
e0d38eeb 13224 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
13225
13226 * print.c (internal_with_output_to_temp_buffer): Function deleted.
13227
13228 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
13229
e67a13ab
CY
132302011-04-06 Chong Yidong <cyd@stupidchicken.com>
13231
04f2d78b
CB
13232 * process.c (Flist_processes): Remove to Lisp.
13233 (list_processes_1): Delete.
e67a13ab 13234
973f782d
EZ
132352011-04-06 Eli Zaretskii <eliz@gnu.org>
13236
7c106b1e
EZ
13237 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
13238
973f782d
EZ
13239 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
13240
41cf7d1a 132412011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 13242
ca23cc88
PE
13243 Fix more problems found by GCC 4.6.0's static checks.
13244
f390e2d5
PE
13245 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
13246
42eea0d0
PE
13247 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
13248
b69769da 13249 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 13250
f9541e84
PE
13251 * xdisp.c (vmessage): Mark as a printf-like function.
13252
13841b55
PE
13253 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
13254
c136c10f
PE
13255 * sound.c (sound_warning): Don't crash if arg contains a printf format.
13256
5e2d4a30
PE
13257 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
13258 printf-like functions.
13259 (tiff_load): Add casts to remove these marks before passing them
13260 to system-supplied API.
13261
583f48b9
PE
13262 * eval.c (Fsignal): Remove excess argument to 'fatal'.
13263
b25d760e
PE
13264 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
13265 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
13266 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
13267 directly, rather than having caller test rule sign. This avoids
13268 some unnecessary tests.
13269 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
13270 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
13271 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 13272
bc7b6697 13273 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 13274 (xfont_open): Avoid unnecessary tests.
bc7b6697 13275
27ccc379
PE
13276 * composite.c (composition_gstring_put_cache): Use unsigned integer.
13277
dcd5c89a
PE
13278 * composite.h, composite.c (composition_gstring_put_cache):
13279 Use EMACS_INT, not int, for length.
13280
b13a45c6
PE
13281 * composite.h (COMPOSITION_DECODE_REFS): New macro,
13282 breaking out part of COMPOSITION_DECODE_RULE.
13283 (COMPOSITION_DECODE_RULE): Use it.
13284 * composite.c (get_composition_id): Remove unused local vars,
13285 by using the new macro.
13286
1e792e4d
PE
13287 * textprop.c (set_text_properties_1): Change while to do-while,
13288 since the condition is always true at first.
13289
dc6c6455 13290 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
13291 (interval_deletion_adjustment): Return unsigned value.
13292 All uses changed.
dc6c6455 13293
aba7731a
PE
13294 * process.c (list_processes_1, create_pty, read_process_output):
13295 (exec_sentinel): Remove vars that were set but not used.
afd4052b 13296 (create_pty): Remove unnecessary "volatile"s.
bc57d757 13297 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 13298 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 13299 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 13300
fdfc4bf3
PE
13301 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
13302
fca8fe46 13303 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 13304 (update_syntax_table): Use unsigned instead of int.
fca8fe46 13305
06a0259a 13306 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 13307 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 13308 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 13309
e7b9e80f
PE
13310 * print.c (print_error_message): Avoid int overflow.
13311
56201685
PE
13312 * font.c (font_list_entities): Redo for clarity,
13313 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
13314
78834453 13315 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 13316 (font_score): Avoid potential overflow in diff calculation.
78834453 13317
0bc0b309 13318 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 13319 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 13320
e610eaca
PE
13321 * eval.c (funcall_lambda): Rename local to avoid shadowing.
13322
b895abce
PE
13323 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
13324 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
13325 can always succeed if overflow has undefined behavior.
13326
1f1d9321 13327 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 13328 (wordify): Omit three unnecessary tests.
1f1d9321 13329
c59478bc
PE
13330 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
13331 All callers changed. This avoids the need for an unused var.
13332
79b73827
PE
13333 * casefiddle.c (casify_region): Remove var that is set but not used.
13334
a4db5dfe
PE
13335 * dired.c (file_name_completion): Remove var that is set but not used.
13336
43aae36e
PE
13337 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
13338
2a47c44d 13339 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 13340 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 13341
a37c69bf
PE
13342 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
13343 Check for integer overflow on size calculations.
13344
328ab8e7
PE
13345 * buffer.c (Fprevious_overlay_change): Remove var that is set
13346 but not used.
13347
e5a2a5cb
PE
13348 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
13349 Remove vars that are set but not used.
8d84a6eb 13350 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 13351 (timer_check_2): Mark vars as initialized.
e5a2a5cb 13352
a60e5f68
PE
13353 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
13354
f661cb61 13355 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 13356 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 13357
f0397f5a
PE
13358 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
13359 that are set but not used.
13360
8664db06 13361 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 13362 if XCreateBitmapFromData fails (Bug#8410).
8664db06 13363
6abdaa4a
PE
13364 * xselect.c (x_get_local_selection, x_handle_property_notify):
13365 Remove vars that are set but not used.
13366
0ce7538d 13367 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 13368 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 13369
9ae848fc
PE
13370 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
13371 Remove var that is set but not used.
0b918413
PE
13372 (scroll_bar_windows_size): Now size_t, not int.
13373 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
13374 Check for overflow.
9ae848fc 13375
a5a62657
PE
13376 * xfaces.c (realize_named_face): Remove vars that are set but not used.
13377 (map_tty_color) [!defined MSDOS]: Likewise.
13378
5c5cdd39
PE
13379 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
13380
66ebf983
PE
13381 * coding.c: Remove vars that are set but not used.
13382 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
13383 All callers changed.
13384 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
13385 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
13386 (decode_coding_charset): Remove vars that are set but not used.
13387
1be4d761
PE
13388 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
13389 that is set but not used.
13390
47553fa8
PE
13391 * print.c (print_object): Remove var that is set but not used.
13392
1f7196bf 13393 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
13394 The gnulib version avoids calling malloc in the usual case,
13395 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
13396 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
13397 * filelock.c (current_lock_owner): Likewise.
13398 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
13399 * sysdep.c: Include allocator.h, careadlinkat.h.
13400 (emacs_no_realloc_allocator): New static constant.
13401 (emacs_readlink): New function.
fdb61804
PE
13402 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
13403 ../lib/careadlinkat.h.
d1fdcab7 13404
f84c17c7
SM
134052011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
13406
13407 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
13408 first non-nil return value).
13409
ef3862ad
JD
134102011-04-03 Jan Djärv <jan.h.d@swipnet.se>
13411
13412 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
13413 if not defined (Bug#8403).
13414
376a7006
JB
134152011-04-02 Juanma Barranquero <lekktu@gmail.com>
13416
13417 * xdisp.c (display_count_lines): Remove parameter `start',
13418 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13419 (get_char_face_and_encoding): Remove parameter `multibyte_p',
13420 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13421 (fill_stretch_glyph_string): Remove parameters `row' and `area',
13422 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
13423 and thereabouts. All callers changed.
13424 (get_per_char_metric): Remove parameter `f', unused since
13425 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13426
6ca3801d
JM
134272011-04-02 Jim Meyering <meyering@redhat.com>
13428
13429 do not dereference NULL upon failed strdup
13430 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
13431 (ns_get_family): Likewise.
13432
d8e2b5ba
JB
134332011-04-02 Juanma Barranquero <lekktu@gmail.com>
13434
13435 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
13436
8c74fcbd
JD
134372011-04-02 Jan Djärv <jan.h.d@swipnet.se>
13438
13439 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
13440 later (Bug#8403).
13441
7200d79c
SM
134422011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
13443
03408648 13444 Add lexical binding.
7200d79c 13445
03408648
SM
13446 * window.c (Ftemp_output_buffer_show): New fun.
13447 (Fsave_window_excursion):
13448 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
13449
13450 * lread.c (lisp_file_lexically_bound_p): New function.
13451 (Fload): Bind Qlexical_binding.
13452 (readevalloop): Remove `evalfun' arg.
13453 Bind Qinternal_interpreter_environment.
13454 (Feval_buffer): Bind Qlexical_binding.
13455 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
13456 Mark as dynamic.
13457 (syms_of_lread): Declare `lexical-binding'.
13458
13459 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
13460
13461 * keyboard.c (eval_dyn): New fun.
13462 (menu_item_eval_property): Use it.
ca105506
SM
13463
13464 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 13465
03408648
SM
13466 * fns.c (concat, mapcar1): Accept byte-code-functions.
13467
13468 * eval.c (Fsetq): Handle lexical vars.
13469 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
13470 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
13471 (FletX, Flet): Obey lexical binding.
13472 (Fcommandp): Handle closures.
13473 (Feval): New `lexical' arg.
13474 (eval_sub): New function extracted from Feval. Use it almost
13475 everywhere where Feval was used. Look up vars in lexical env.
13476 Handle closures.
13477 (Ffunctionp): Move from subr.el.
13478 (Ffuncall): Handle closures.
13479 (apply_lambda): Remove `eval_flags'.
13480 (funcall_lambda): Handle closures and new byte-code-functions.
13481 (Fspecial_variable_p): New function.
13482 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
13483 but without exporting it to Lisp.
23aba0ea 13484
23aba0ea 13485 * doc.c (Fdocumentation, store_function_docstring):
03408648 13486 * data.c (Finteractive_form): Handle closures.
23aba0ea 13487
03408648
SM
13488 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
13489 interactive spec.
ba83908c 13490
04f2d78b
CB
13491 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
13492 New byte-codes.
03408648
SM
13493 (exec_byte_code): New function extracted from Fbyte_code to handle new
13494 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 13495
03408648 13496 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 13497
03408648 13498 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 13499
e2abce01
JB
135002011-03-31 Juanma Barranquero <lekktu@gmail.com>
13501
13502 * xdisp.c (redisplay_internal): Fix prototype.
13503
63696a73 135042011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 13505
63696a73 13506 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
13507 (try_scrolling): Use it when setting scroll_limit.
13508 Limit scrolling to 100 screen lines.
63696a73
EZ
13509 (redisplay_window): Even when falling back on "recentering",
13510 position point in the window according to scroll-conservatively,
13511 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
13512
13513 (try_scrolling): When point is above the window, allow searching
13514 as far as scroll_max, or one screenful, to compute vertical
13515 distance from PT to the scroll margin position. This prevents
13516 try_scrolling from unnecessarily failing when
13517 scroll-conservatively is set to a value slightly larger than the
13518 window height. Clean up the case of PT below the margin at bottom
13519 of window: scroll_max can no longer be INT_MAX. When aggressive
13520 scrolling is in use, don't let point enter the opposite scroll
13521 margin as result of the scroll.
13522 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
13523 threshold of 100 lines for never-recentering scrolling.
13524
e4cc2dfc
JB
135252011-03-31 Juanma Barranquero <lekktu@gmail.com>
13526
13527 * dispextern.h (move_it_by_lines):
13528 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
13529 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
13530 (message_log_check_duplicate): Remove parameters `prev_bol' and
13531 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13532 (redisplay_internal): Remove parameter `preserve_echo_area',
13533 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
13534
13535 * indent.c (Fvertical_motion):
13536 * window.c (window_scroll_pixel_based, Frecenter):
13537 Don't pass `need_y_p' to `move_it_by_lines'.
13538
1c470562
SM
135392011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
13540
44f230aa
SM
13541 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
13542 steal a few bits to be more compact.
13543 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
13544 Remove unneeded casts.
13545
1c470562
SM
13546 * bytecode.c (Fbyte_code): CAR and CDR can GC.
13547
888adce9
ZK
135482011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
13549
13550 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
13551 binding" message (bug#7967).
13552
f838ed7b
PE
135532011-03-30 Paul Eggert <eggert@cs.ucla.edu>
13554
77861b95
PE
13555 Fix more problems found by GCC 4.6.0's static checks.
13556
de6dbc14
PE
13557 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
13558 Remove unused local var.
13559
f838ed7b
PE
13560 * editfns.c (Fmessage_box): Remove unused local var.
13561
792c7b2b
PE
13562 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
13563 (note_mode_line_or_margin_highlight, note_mouse_highlight):
13564 Omit unused local vars.
c499e557 13565 * window.c (shrink_windows): Omit unused local var.
b01a1c29 13566 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
13567 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
13568 Omit unused local var.
13569
ba0165e1
PE
13570 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
13571 Don't assume string length fits in int.
32ad8845 13572 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 13573 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 13574
3c59b4c9
PE
13575 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
13576 instead of alloca (Bug#8344).
13577
a3eed478 13578 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 13579 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 13580
eb4d412d
PE
13581 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
13582
1658b401
PE
13583 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
13584 concerns.
13585
13586 * term.c (produce_glyphless_glyph): Remove unnecessary test.
13587
13588 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 13589
9a2c6e05
PE
13590 * keyboard.c (syms_of_keyboard): Use the same style as later
13591 in this function when indexing through an array. This also
13592 works around GCC bug 48267.
13593
03d0a109
PE
13594 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
13595
44f730c8
PE
13596 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
13597
fe75f926
PE
13598 * chartab.c (sub_char_table_ref_and_range): Redo for slight
13599 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
13600
ffa8c828
PE
13601 * keyboard.c, keyboard.h (num_input_events): Now size_t.
13602 This avoids undefined behavior on integer overflow, and is a bit
13603 more convenient anyway since it is compared to a size_t variable.
13604
c5101a77
PE
13605 Variadic C functions now count arguments with size_t, not int.
13606 This avoids an unnecessary limitation on 64-bit machines, which
13607 caused (substring ...) to crash on large vectors (Bug#8344).
13608 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
13609 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 13610 All variadic functions and their callers changed accordingly.
c5101a77
PE
13611 (struct gcpro.nvars): Now size_t, not int. All uses changed.
13612 * data.c (arith_driver, float_arith_driver): Likewise.
13613 * editfns.c (general_insert_function): Likewise.
13614 * eval.c (struct backtrace.nargs, interactive_p)
13615 (internal_condition_case_n, run_hook_with_args, apply_lambda)
13616 (funcall_lambda, mark_backtrace): Likewise.
13617 * fns.c (concat): Likewise.
13618 * frame.c (x_set_frame_parameters): Likewise.
13619 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
13620 0 if not found, not -1. All callers changed.
13621
dd3f25f7
PE
13622 * alloc.c (garbage_collect): Don't assume stack size fits in int.
13623 (stack_copy_size): Now size_t, not int.
13624 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
13625
461c2ab9
JB
136262011-03-28 Juanma Barranquero <lekktu@gmail.com>
13627
13628 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
13629 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13630 All callers changed.
13631
13632 * lisp.h (multibyte_char_to_unibyte):
13633 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
13634 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13635 * character.h (CHAR_TO_BYTE8):
13636 * cmds.c (internal_self_insert):
13637 * editfns.c (general_insert_function):
13638 * keymap.c (push_key_description):
13639 * search.c (Freplace_match):
13640 * xdisp.c (message_dolog, set_message_1): All callers changed.
13641
f6d62986
SM
136422011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
13643
13644 * keyboard.c (safe_run_hook_funcall): New function.
13645 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
13646 don't set the hook to nil, but remove the offending function instead.
13647 (Qcommand_hook_internal): Remove, unused.
13648 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
13649 Vcommand_hook_internal.
13650
13651 * eval.c (enum run_hooks_condition): Remove.
13652 (funcall_nil, funcall_not): New functions.
13653 (run_hook_with_args): Call each function through a `funcall' argument.
13654 Remove `cond' argument, now redundant.
13655 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
13656 (Frun_hook_with_args_until_failure): Adjust accordingly.
13657 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
13658
1db5b1ad
JB
136592011-03-28 Juanma Barranquero <lekktu@gmail.com>
13660
13661 * dispextern.h (string_buffer_position): Remove declaration.
13662
13663 * print.c (strout): Remove parameter `multibyte', unused since
13664 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
13665
13666 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
13667 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
13668 All callers changed.
13669
13670 * w32.c (_wsa_errlist): Use braces for struct initializers.
13671
13672 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
13673 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
13674 All callers changed.
13675 (string_buffer_position): Likewise. Also, make static (it's never
13676 used outside xdisp.c).
13677 (cursor_row_p): Remove parameter `w', unused since
13678 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
13679 (decode_mode_spec): Remove parameter `precision', introduced during
13680 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
13681 All callers changed.
13682
5ffb62aa
JD
136832011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13684
13685 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
13686
461c2ab9 136872011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
13688
13689 * nsterm.m (ns_menu_bar_is_hidden): New variable.
13690 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
13691 (ns_update_auto_hide_menu_bar): New functions.
13692 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
13693 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
13694 ns_constrain_all_frames.
13695 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
13696 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
13697
5c380ffb
JD
136982011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13699
13700 * nsmenu.m (runDialogAt): Remove argument to timer_check.
13701
9af30bdf
GM
137022011-03-27 Glenn Morris <rgm@gnu.org>
13703
13704 * syssignal.h: Replace RETSIGTYPE with void.
13705 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
13706 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
13707 Replace SIGTYPE with void everywhere.
13708 * s/usg5-4-common.h (SIGTYPE): Remove definition.
13709 * s/template.h (SIGTYPE): Remove commented out definition.
13710
e2abce01
JB
137112011-03-26 Eli Zaretskii <eliz@gnu.org>
13712
13713 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
13714 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
13715
f868cd8a
JB
137162011-03-26 Juanma Barranquero <lekktu@gmail.com>
13717
59eb0929
JB
13718 * w32.c (read_unc_volume): Use parameter `henum', instead of
13719 global variable `wget_enum_handle'.
13720
13721 * keymap.c (describe_vector): Remove parameters `indices' and
13722 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
13723 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
13724
f868cd8a
JB
13725 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
13726
13727 * keyboard.c (timer_check): Remove parameter `do_it_now',
13728 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
13729 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
13730 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
13731
13732 * keyboard.c (read_char):
13733 * w32menu.c (w32_menu_display_help):
13734 * xmenu.c (show_help_event, menu_help_callback):
13735 Adjust calls to `show_help_echo'.
13736
13737 * gtkutil.c (xg_maybe_add_timer):
13738 * keyboard.c (readable_events):
13739 * process.c (wait_reading_process_output):
13740 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
13741
13742 * insdel.c (adjust_markers_gap_motion):
13743 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
13744 (gap_left, gap_right): Don't call it.
13745
2ecf6fdb
CY
137462011-03-25 Chong Yidong <cyd@stupidchicken.com>
13747
13748 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
13749 incurred during fontification.
13750
6b1f9ba4
JB
137512011-03-25 Juanma Barranquero <lekktu@gmail.com>
13752
13753 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
13754 (DEFVAR_PER_BUFFER): Don't pass it.
13755
13756 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
13757 (scrolling_window): Don't pass it.
13758
0f4a96b5
JB
137592011-03-25 Juanma Barranquero <lekktu@gmail.com>
13760
13761 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
13762
13763 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
13764 and `suffix'.
13765 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
13766 of variables specific to SELinux and computation of `encoded_absname'.
13767
13768 * image.c (XPutPixel): Remove unused variable `height'.
13769
13770 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
13771
13772 * unexw32.c (get_section_info): Remove unused variable `section'.
13773
13774 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
13775 (system_process_attributes): Remove unused variable `sess'.
13776 (sys_read): Remove unused variable `err'.
13777
13778 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
13779 (w32_wnd_proc): Remove unused variable `isdead'.
13780 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
13781 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
13782 (x_create_tip_frame): Remove unused variable `tem'.
13783
13784 * w32inevt.c (w32_console_read_socket):
13785 Remove unused variable `no_events'.
13786
13787 * w32term.c (x_draw_composite_glyph_string_foreground):
13788 Remove unused variable `width'.
13789
1149507c
JB
137902011-03-24 Juanma Barranquero <lekktu@gmail.com>
13791
13792 * w32term.c (x_set_glyph_string_clipping):
13793 Don't pass uninitialized region to CombineRgn.
13794
9c88f339
JB
137952011-03-23 Juanma Barranquero <lekktu@gmail.com>
13796
13797 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
13798 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
13799 (Fx_close_connection): Remove unused variable `i'.
13800
13801 * w32font.c (w32font_draw): Return number of glyphs.
13802 (w32font_open_internal): Remove unused variable `i'.
13803 (w32font_driver): Add missing initializer.
13804
13805 * w32menu.c (utf8to16): Remove unused variable `utf16'.
13806 (fill_in_menu): Remove unused variable `items_added'.
13807
13808 * w32term.c (last_mouse_press_frame): Remove static global variable.
13809 (w32_clip_to_row): Remove unused variable `f'.
13810 (x_delete_terminal): Remove unused variable `i'.
13811
13812 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
13813 (NOTHING): Remove unused static global variable.
13814 (uniscribe_check_otf): Remove unused variable `table'.
13815 (uniscribe_font_driver): Add missing initializers.
13816
dee091a3
JD
138172011-03-23 Julien Danjou <julien@danjou.info>
13818
13819 * term.c (Fsuspend_tty, Fresume_tty):
13820 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
13821 * window.c (temp_output_buffer_show):
13822 * insdel.c (signal_before_change):
13823 * frame.c (Fhandle_switch_frame):
13824 * fileio.c (Fdo_auto_save):
13825 * emacs.c (Fkill_emacs):
13826 * editfns.c (save_excursion_restore):
13827 * cmds.c (internal_self_insert):
13828 * callint.c (Fcall_interactively):
13829 * buffer.c (Fkill_all_local_variables):
13830 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
13831 Use Frun_hooks.
0f4a96b5 13832 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 13833 unconditionally since it does the check itself.
dee091a3 13834
2c520ab5 138352011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 13836
c9c49752
PE
13837 Fix more problems found by GCC 4.5.2's static checks.
13838
8abc3f12
PE
13839 * coding.c (encode_coding_raw_text): Avoid unnecessary test
13840 the first time through the loop, since we know p0 < p1 then.
13841 This also avoids a gcc -Wstrict-overflow warning.
13842
a2d26660
PE
13843 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
13844 leading to a memory leak, possible in functions like
13845 load_charset_map_from_file that can allocate an unbounded number
b12ef411 13846 of objects (Bug#8318).
a2d26660 13847
916c72e9
PE
13848 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
13849 that could (at least in theory) be that large.
13850
19ab8a18
PE
13851 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
13852 This is less likely to overflow, and avoids undefined behavior if
13853 overflow does occur. All callers changed. Use strtoul to scan
13854 for the unsigned long integer.
b7cbbd6f
PE
13855 (pint2hrstr): Simplify and tune code slightly.
13856 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 13857
f0641eff
PE
13858 * scroll.c (do_scrolling): Work around GCC bug 48228.
13859 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
13860
7f650bb9
PE
13861 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
13862 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
13863 (validate_x_resource_name): Simplify count usage.
13864 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 13865
37dd57d1
PE
13866 * fileio.c (Fcopy_file): Report error if fchown or fchmod
13867 fail (Bug#8306).
81e56e61 13868
699979fc 13869 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 13870
401bf9b4
PE
13871 * process.c (Fmake_network_process): Use socklen_t, not int,
13872 where POSIX says socklen_t is required in portable programs.
13873 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 13874 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
13875 (Fmake_network_process, server_accept_connection):
13876 (wait_reading_process_output, read_process_output):
13877 Likewise.
13878
b93aacde
PE
13879 * process.c: Rename or move locals to avoid shadowing.
13880 (list_processes_1, Fmake_network_process):
13881 (read_process_output_error_handler, exec_sentinel_error_handler):
13882 Rename or move locals.
4dc343ee 13883 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 13884 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 13885 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 13886 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 13887 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 13888
af8a867c 13889 Make tparam.h and terminfo.c consistent.
44f230aa
SM
13890 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
13891 Include tparam.h instead, since it declares them.
af8a867c
PE
13892 * cm.h (PC): Remove extern decl; tparam.h now does this.
13893 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
13894 * terminfo.c: Include tparam.h, to check interfaces.
13895 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
13896 (tparam): Adjust signature to match interface in tparam.h;
13897 this removes some undefined behavior. Check that outstring and len
13898 are zero, which they always are with Emacs.
13899 * tparam.h (PC, BC, UP): New extern decls.
13900
0248044d 13901 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 13902 (xftfont_open): Rename locals to avoid shadowing.
0248044d 13903
8ff096c1 13904 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
13905 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
13906 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 13907 (ftfont_list): Remove unused local.
49eaafba
PE
13908 (get_adstyle_property, ftfont_pattern_entity):
13909 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
13910 Rename locals to avoid shadowing.
8ff096c1 13911
e2be39f6
PE
13912 * xfont.c (xfont_list_family): Mark var as initialized.
13913
c9735e30
PE
13914 * xml.c (make_dom): Now static.
13915
8f5201ae
PE
13916 * composite.c (composition_compute_stop_pos): Rename local to
13917 avoid shadowing.
b246f932
PE
13918 (composition_reseat_it): Remove unused locals.
13919 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 13920 (composition_update_it): Mark var as initialized.
11b61122
PE
13921 (find_automatic_composition): Mark vars as initialized,
13922 with a FIXME (Bug#8290).
8f5201ae 13923
760fbc2c
PE
13924 character.h: Rename locals to avoid shadowing.
13925 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
13926 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
13927 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
13928 (BUF_DEC_POS): Be more systematic about renaming local temporaries
13929 to avoid shadowing.
13930
ff08eb85
PE
13931 * textprop.c (property_change_between_p): Remove; unused.
13932
fc7bf025
PE
13933 * intervals.c (interval_start_pos): Now static.
13934
235d7abc
PE
13935 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
13936
44f230aa
SM
13937 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
13938 Rename locals to avoid shadowing.
3e7d6594 13939
50060332
PE
13940 * sound.c (wav_play, au_play, Fplay_sound_internal):
13941 Fix pointer signedness.
d01f234b 13942 (alsa_choose_format): Remove unused local var.
c83b8872
PE
13943 (wav_play): Initialize a variable to 0, to prevent undefined
13944 behavior (Bug#8278).
50060332 13945
c4fc4e30
PE
13946 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
13947
918436ed
PE
13948 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
13949
c939f91b
PE
13950 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
13951 clobbering (Bug#8298).
b9c7f648
PE
13952 * sysdep.c (sys_subshell): Likewise.
13953 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 13954
6bd8c144
PE
13955 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
13956 This should get cleaned up, so that child_setup has the
13957 same signature on all platforms.
13958
7710357c 13959 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 13960 (relocate_fd): Rename locals to avoid shadowing.
7710357c 13961
c59da222
CY
139622011-03-22 Chong Yidong <cyd@stupidchicken.com>
13963
13964 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
13965 not to be necessary, and produces flickering.
13966
66b87493
GM
139672011-03-20 Glenn Morris <rgm@gnu.org>
13968
13969 * config.in: Remove file.
13970
45b6f6d5
JB
139712011-03-20 Juanma Barranquero <lekktu@gmail.com>
13972
13973 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
13974 are now in src/globals.h.
13975 (syms_of_minibuf): Remove spurious & from previous change.
13976
cd394be1 139772011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
13978
13979 * minibuf.c (completing-read-function): New variable.
13980 (completing-read-default): Rename from completing-read.
13981 (completing-read): Call completing-read-function.
13982
b14e3e21
CY
139832011-03-19 Juanma Barranquero <lekktu@gmail.com>
13984
13985 * xfaces.c (Fx_load_color_file):
13986 Read color file from absolute filename (bug#8250).
13987
f2b726e6
JB
139882011-03-19 Juanma Barranquero <lekktu@gmail.com>
13989
13990 * makefile.w32-in: Update dependencies.
13991
09f6ff02
EZ
139922011-03-17 Eli Zaretskii <eliz@gnu.org>
13993
13994 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
13995
29a6015a
PE
139962011-03-17 Paul Eggert <eggert@cs.ucla.edu>
13997
a3a6c54e
PE
13998 Fix more problems found by GCC 4.5.2's static checks.
13999
b766f867
PE
14000 * process.c (make_serial_process_unwind, send_process_trap):
14001 (sigchld_handler): Now static.
14002
be02381c
PE
14003 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
14004 That way, the code declares only the vars that it needs.
14005 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
14006 * s/cygwin.h (PTY_ITERATION): Likewise.
14007 * s/darwin.h (PTY_ITERATION): Likewise.
14008 * s/gnu-linux.h (PTY_ITERATION): Likewise.
14009
57048744
PE
14010 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
14011 * process.c (allocate_pty): Don't declare stb unless it's needed.
14012
7914961c 14013 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
14014 (CONSTANTLIM): Remove; unused.
14015 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
14016 Define only if needed.
7914961c 14017
b3967b18
PE
14018 * unexelf.c (unexec): Name an expression,
14019 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
14020 Use a different way to cause a compilation error if anyone uses
14021 n rather than nn, a way that does not involve shadowing.
73366a00 14022 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 14023
29a6015a
PE
14024 * deps.mk (unexalpha.o): Remove; unused.
14025
43cfc33e 14026 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 14027 * unexec.h: New file.
ce701a33
PE
14028 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
14029 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
14030 Depend on unexec.h.
14031 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
14032 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
14033 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 14034 Change as necessary to match prototype in unexec.h.
ce701a33 14035
01f44d5a
PE
14036 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
14037 shadowing.
4f63c6bb 14038 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 14039
a6670b0b
PE
14040 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
14041 Rename locals to avoid shadowing.
14042
cef2010d 14043 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 14044 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 14045
d4d7173a
PE
14046 * print.c (Fredirect_debugging_output): Fix pointer signedess.
14047
f08b802a
PE
14048 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
14049 warning when compiling print.c.
14050
3ddb0639
PE
14051 * font.c (font_unparse_fcname): Abort in an "impossible" situation
14052 instead of using an uninitialized var.
5ad03b97 14053 (font_sort_entities): Mark var as initialized.
3ddb0639 14054
170a2692
PE
14055 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
14056
e663c700
PE
14057 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
14058 pointers to constants.
89bc529a 14059 (font_parse_fcname): Remove unused vars.
7b81e2d0 14060 (font_delete_unmatched): Now static.
ea838e10 14061 (font_get_spec): Remove; unused.
13a547c6
PE
14062 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
14063 (font_update_drivers, Ffont_get_glyphs, font_add_log):
14064 Rename or move locals to avoid shadowing.
e663c700 14065
2a80c887 14066 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 14067 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 14068
1384fa33 14069 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 14070 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 14071
8b2c52e9
PE
14072 * alloc.c (mark_backtrace): Move decl from here ...
14073 * lisp.h: ... to here, so that it can be checked.
14074
475545b5 14075 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 14076 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
14077 (lisp_indirect_variable): Name an expression,
14078 to avoid gcc -Wbad-function-cast warning.
1faed8ae 14079 (Fdefvar): Rename locals to avoid shadowing.
475545b5 14080
b1349114 14081 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 14082 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 14083 Use const pointer when appropriate.
b1349114 14084
a2928364
PE
14085 * lisp.h (get_system_name, get_operating_system_release):
14086 Move decls here, to check interfaces.
14087 * process.c (get_operating_system_release): Move decl to lisp.h.
14088 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
14089 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
14090 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
14091 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
14092 (Fformat_time_string, Fencode_time, Finsert_char):
14093 (Ftranslate_region_internal, Fformat):
14094 Rename or remove local vars to avoid shadowing.
9710023e 14095 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 14096
a415e694
PE
14097 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
14098 avoid shadowing.
14099
8ef4622d
PE
14100 * lisp.h (eassert): Check that the argument compiles, even if
14101 ENABLE_CHECKING is not defined.
14102
946f9a5b
PE
14103 * data.c (Findirect_variable): Name an expression, to avoid
14104 gcc -Wbad-function-cast warning.
112396d6 14105 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 14106 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
14107 (Fmake_variable_buffer_local, Fmake_local_variable):
14108 Mark variables as initialized.
52746918 14109 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 14110
e5aab7e7 14111 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
14112 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
14113 Rename locals to avoid shadowing.
dff45157
PE
14114 (mark_stack): Move local variables into the #ifdef region where
14115 they're used.
7bc26fdb
PE
14116 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
14117 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
14118 needed otherwise.
14119 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
14120 (GC_STRING_CHARS): Remove; not used.
d40d4be1 14121 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 14122
e5aab7e7
PE
14123 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
14124 avoids undefined behavior in theory.
14125
4da60324
PE
14126 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
14127
88043301
PE
14128 Use functions, not macros, for up- and down-casing (Bug#8254).
14129 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14130 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
14131 to use the following functions instead of these macros.
14132 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
14133 EMACS_INT, since callers assume the returned value fits in int.
14134 (upcase1): Likewise, for UPCASE_TABLE.
14135 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 14136 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 14137 the race-condition problem in the old DOWNCASE.
88043301 14138
19ed5445
PE
14139 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
14140 Rename locals to avoid shadowing.
14141 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
14142 (regex_compile, re_search_2, re_match_2_internal):
14143 Remove unused local vars.
952db0d7
PE
14144 (FREE_VAR): Rewrite so as not to use empty "else",
14145 which gcc can warn about.
da053e48 14146 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
14147 (RETALLOC_IF): Define only if needed.
14148 (WORDCHAR_P): Likewise. This one is never needed, but is used
14149 only in a comment talking about a compiler bug, so put inside
14150 the #if 0 of that comment.
14151 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
14152 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
14153 Remove; unused.
19ed5445 14154
1f3561e4 14155 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
14156 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
14157 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 14158
ded6f8f7
PE
14159 * search.c (simple_search): Remove unused var.
14160
dbd37a95
PE
14161 * dired.c (compile_pattern): Move decl from here ...
14162 * lisp.h: ... to here, so that it can be checked.
14163 (struct re_registers): New forward decl.
14164
7e47afad
PE
14165 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
14166
85f24f61
PE
14167 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
14168 All uses changed.
14169 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
14170 Rename locals to avoid shadowing.
5671df8f 14171 (Fvertical_motion): Mark locals as initialized.
85f24f61 14172
181aa2be 14173 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 14174 (casify_region): Mark local as initialized.
181aa2be 14175
930d429c
PE
14176 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
14177
7082eac6
PE
14178 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
14179 New macros, so that the caller can use some names other than
14180 gcpro1, gcpro2, etc.
14181 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
14182 of the new macros.
14183 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
14184 argument, for consistency with GCPRO2_VAR, etc: it is now the
14185 prefix of the variable, not the variable itself. All uses
14186 changed.
38b2c076
PE
14187 * dired.c (directory_files_internal, file_name_completion):
14188 Rename locals to avoid shadowing.
14189
15206ed9
PE
14190 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
14191 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
14192 dired.c's scmp function, had undefined behavior.
14193 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14194 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
14195 * buffer.h: ... to here, because these macros use current_buffer,
14196 and the new implementation with inline functions needs to have
14197 current_buffer in scope now, rather than later when the macros
14198 are used.
14199 (downcase, upcase1): New static inline functions.
14200 (DOWNCASE, UPCASE1): Reimplement using these functions.
14201 This avoids undefined behavior in expressions like
14202 DOWNCASE (x) == DOWNCASE (y), which previously suffered
14203 from race conditions in accessing the global variables
14204 case_temp1 and case_temp2.
14205 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
14206 * lisp.h (case_temp1, case_temp2): Remove their decls.
14207 * character.h (ASCII_CHAR_P): Move from here ...
14208 * lisp.h: ... to here, so that the inline functions mentioned
14209 above can use them.
14210
4a6bea26
PE
14211 * dired.c (directory_files_internal_unwind): Now static.
14212
f14b7e14
PE
14213 * fileio.c (file_name_as_directory, directory_file_name):
14214 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
14215 Now static.
2893f146
PE
14216 (file_name_as_directory): Use const pointers when appropriate.
14217 (Fexpand_file_name): Likewise. In particular, newdir might
14218 point at constant storage, so make it a const pointer.
fd4ead52 14219 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
14220 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
14221 signedness issues.
f839df0c
PE
14222 (Fset_file_times, Finsert_file_contents, auto_save_error):
14223 Rename locals to avoid shadowing.
f14b7e14 14224
5716756e 14225 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
14226 (Ftry_completion, Fall_completions): Rename or remove locals
14227 to avoid shadowing.
5716756e 14228
b4c3046a
PE
14229 * marker.c (bytepos_to_charpos): Remove; unused.
14230
b45db522
PE
14231 * lisp.h (verify_bytepos, count_markers): New decls,
14232 so that gcc does not warn that these functions aren't declared.
14233
85876d07
PE
14234 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
14235 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 14236 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 14237 (copy_text): Remove unused local var.
85876d07 14238
03d78a21 14239 * filelock.c (within_one_second): Now static.
b3dd38ab 14240 (lock_file_1): Rename local to avoid shadowing.
03d78a21 14241
5df8f01b
PE
14242 * buffer.c (fix_overlays_before): Mark locals as initialized.
14243 (fix_start_end_in_overlays): Likewise. This function should be
14244 simplified by using pointers-to-pointers, but that's a different
14245 matter.
b1d876f1 14246 (switch_to_buffer_1): Now static.
8f54f30a
PE
14247 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
14248 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 14249
a70072c9 14250 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 14251 Fix pointer signedness issue.
edced198
PE
14252 (sys_subshell): Mark local as volatile if checking for lint,
14253 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 14254 (MAXPATHLEN): Define only if needed.
a70072c9 14255
a0977c44
PE
14256 * process.c (serial_open, serial_configure): Move decls from here ...
14257 * systty.h: ... to here, so that they can be checked.
14258
a884fdcc
PE
14259 * fns.c (get_random, seed_random): Move extern decls from here ...
14260 * lisp.h: ... to here, so that they can be checked.
14261
604efe86 14262 * sysdep.c (reset_io): Now static.
b8950c94 14263 (wait_for_termination_signal): Remove; unused.
604efe86 14264
38fc62d9
PE
14265 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
14266 (copy_keymap_item, append_key, push_text_char_description):
14267 Now static.
1004a21a 14268 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 14269 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
14270 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
14271 (describe_map_tree):
14272 Rename locals to avoid shadowing.
38fc62d9 14273
2f2650da
PE
14274 * keyboard.c: Declare functions static if they are not used elsewhere.
14275 (echo_char, echo_dash, cmd_error, top_level_2):
14276 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
14277 (read_char, kbd_buffer_get_event, make_lispy_position):
14278 (make_lispy_event, make_lispy_movement, apply_modifiers):
14279 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
14280 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
14281 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 14282 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 14283 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 14284
a053e86c 14285 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
14286 (mark_kboards): Move decl here ...
14287 * alloc.c (mark_kboards): ... from here.
a053e86c 14288
4752793e
PE
14289 * lisp.h (force_auto_save_soon): New decl.
14290
74f10ca7 14291 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
14292 (DEFINE_DUMMY_FUNCTION): New macro.
14293 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
14294 Use it.
c03cd23f
PE
14295 (main): Add casts to avoid warnings
14296 if GCC considers string literals to be constants.
74f10ca7 14297
022e70d4
PE
14298 * lisp.h (fatal_error_signal): Add decl, since it's exported.
14299
59d6fe83
PE
14300 * dbusbind.c: Pointer signedness fixes.
14301 (xd_signature, xd_append_arg, xd_initialize):
14302 (Fdbus_call_method, Fdbus_call_method_asynchronously):
14303 (Fdbus_method_return_internal, Fdbus_method_error_internal):
14304 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
14305 (Fdbus_register_signal): Use SSDATA when the context wants char *.
14306
78320123
PE
14307 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
14308 if GCC considers string literals to be constants.
49cebcca 14309 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 14310
35ac2a97
SM
143112011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
14312
fb103ca9
SM
14313 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
14314 (print_preprocess, print_object): New macro to fix last change.
14315
35ac2a97
SM
14316 * print.c (print_preprocess): Don't forget font objects.
14317
62973b41
JB
143182011-03-16 Juanma Barranquero <lekktu@gmail.com>
14319
14320 * emacs.c (USAGE3): Doc fixes.
14321
0e48bb22
AS
143222011-03-15 Andreas Schwab <schwab@linux-m68k.org>
14323
14324 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
14325 structure.
14326
7684e57b
JB
143272011-03-14 Juanma Barranquero <lekktu@gmail.com>
14328
14329 * lisp.h (VWindow_system, Qfile_name_history):
14330 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
14331 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
14332 (w32_system_caret_x, w32_system_caret_y): Declare extern.
14333
14334 * w32select.c: Don't #include "keyboard.h".
c96bbc66 14335 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
14336
14337 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
14338 * w32console.c (detect_input_pending, read_input_pending)
14339 (encode_terminal_code):
14340 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
14341 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
14342 (w32_system_caret_y, Qfile_name_history):
14343 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
14344 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
14345 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
14346 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
14347 * w32proc.c (Qlocal, report_file_error):
14348 * w32term.c (Vwindow_system, updating_frame):
14349 * w32uniscribe.c (initialized, uniscribe_font_driver):
14350 Remove unneeded extern declarations.
14351
2aa46d6c
CY
143522011-03-14 Chong Yidong <cyd@stupidchicken.com>
14353
c96bbc66 14354 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 14355
cffc6f3b
CY
143562011-03-13 Chong Yidong <cyd@stupidchicken.com>
14357
14358 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
14359 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
14360 These macros can no longer be used for assignment.
14361
44f230aa
SM
14362 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
14363 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
14364 (record_buffer_markers, fetch_buffer_markers): New functions for
14365 recording and fetching special buffer markers.
14366 (set_buffer_internal_1, set_buffer_temp): Use them.
14367
14368 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
14369
14370 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
14371
14372 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
14373 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
14374
14375 * xdisp.c (hscroll_window_tree):
14376 (reconsider_clip_changes): Use PT instead of BUF_PT.
14377
d251f04b
EZ
143782011-03-13 Eli Zaretskii <eliz@gnu.org>
14379
14380 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
14381 $(EMACS_ROOT)/lib/intprops.h.
14382
f0c77cd1
PE
143832011-03-13 Paul Eggert <eggert@cs.ucla.edu>
14384
3eca4629
PE
14385 Fix more problems found by GCC 4.5.2's static checks.
14386
7c86ee98
PE
14387 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
14388 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
14389 (xg_free_frame_widgets): Make it clear that a local variable is
14390 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
14391 (gdk_window_get_screen): Make it clear that this macro is needed
14392 only if USE_GTK_TOOLTIP.
1e5524e7
PE
14393 (int_gtk_range_get_value): New function, which avoids a diagnostic
14394 from gcc -Wbad-function-cast.
14395 (xg_set_toolkit_scroll_bar_thumb): Use it.
14396 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
14397 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
14398 (get_utf8_string, xg_get_file_with_chooser):
14399 Rename locals to avoid shadowing.
14400 (create_dialog): Move locals to avoid shadowing.
7c86ee98 14401
41729b81
PE
14402 * xgselect.c (xg_select): Remove unused var.
14403
f0c77cd1
PE
14404 * image.c (four_corners_best): Mark locals as initialized.
14405 (gif_load): Initialize transparent_p to zero (Bug#8238).
14406 Mark another local as initialized.
ec6cf4c6 14407 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 14408
ce0ad53d 14409 * image.c (clear_image_cache): Now static.
d5d5a617 14410 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 14411 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
14412 (x_edge_detection): Remove unnecessary cast that
14413 gcc -Wbad-function-cast diagnoses.
2037898d 14414 (gif_load): Fix pointer signedness.
6ae141d6
PE
14415 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
14416 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 14417
33383987 144182011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 14419
d32df629
PE
14420 Improve quality of tests for time stamp overflow.
14421 For example, without this patch (encode-time 0 0 0 1 1
14422 1152921504606846976) returns the obviously-bogus value (-948597
14423 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
14424 reports time overflow. See
14425 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
14426 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
14427 * editfns.c: Include limits.h and intprops.h.
14428 (TIME_T_MIN, TIME_T_MAX): New macros.
14429 (time_overflow): Move earlier, to before first use.
14430 (hi_time, lo_time): New functions, for an accurate test for
14431 out-of-range times.
14432 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
14433 (Fget_internal_run_time): Don't assume time_t fits in int.
14434 (make_time): Use list2 instead of Fcons twice.
14435 (Fdecode_time): More accurate test for out-of-range times.
14436 (check_tm_member): New function.
14437 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
14438 (lisp_time_argument): Don't rely on undefined left-shift and
14439 right-shift behavior when checking for time stamp overflow.
8be6f318 14440
fe31d94c
PE
14441 * editfns.c (time_overflow): New function, refactoring common code.
14442 (Fformat_time_string, Fdecode_time, Fencode_time):
14443 (Fcurrent_time_string): Use it.
14444
8be6f318
PE
14445 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
14446 * dired.c (make_time): Move to ...
14447 * editfns.c (make_time): ... here.
14448 * systime.h: Note the move.
14449
09d9db2c 144502011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 14451
126bc0dc
YM
14452 * fringe.c (update_window_fringes): Remove unused variables.
14453
c47cbdfd
YM
14454 * unexmacosx.c (copy_data_segment): Also copy __got section.
14455 (Bug#8223)
14456
7ac80be9
EZ
144572011-03-12 Eli Zaretskii <eliz@gnu.org>
14458
c96bbc66 14459 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
14460 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
14461 Constify `char *' arguments and their references according to
14462 prototypes in tparam.h.
14463
ecb0f94d 14464 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 14465
7ac80be9
EZ
14466 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
14467 Adapt all references accordingly.
14468
14469 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
14470
ef1fd07e
TT
144712011-03-11 Tom Tromey <tromey@redhat.com>
14472
14473 * buffer.c (syms_of_buffer): Remove obsolete comment.
14474
7ef4b50c
EZ
144752011-03-11 Eli Zaretskii <eliz@gnu.org>
14476
14477 * termhooks.h (encode_terminal_code): Declare prototype.
14478
14479 * msdos.c (encode_terminal_code): Don't declare prototype.
14480
14481 * term.c (encode_terminal_code): Now external again, used by
14482 w32console.c and msdos.c.
14483
44f230aa
SM
14484 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
14485 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 14486
4b1ec863 144872011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 14488
1714f52b 14489 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 14490
4b1ec863
PE
14491 * fringe.c (update_window_fringes): Mark locals as initialized
14492 (Bug#8227).
14493 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 14494
524c7aa6
PE
14495 * alloc.c (mark_fringe_data): Move decl from here ...
14496 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
14497 to check its interface.
14498 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
14499
a5c0af81 14500 * fontset.c (free_realized_fontset): Now static.
7519b8cd 14501 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 14502 (fontset_font): Mark local as initialized.
a9a06e0b 14503 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 14504
b4716021
PE
14505 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
14506
811e9bac 14507 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 14508 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
14509 (x_own_selection, Fx_disown_selection_internal): Rename locals
14510 to avoid shadowing.
14511 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 14512
7e3ab302
PE
14513 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
14514 so that the caller can use some name other than gcpro1.
14515 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
14516 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14517 (Fx_backspace_delete_keys_p):
14518 Use them to avoid shadowing, and rename vars to avoid shadowing.
14519 (x_decode_color, x_set_name, x_window): Now static.
6b437900 14520 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 14521 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
14522 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
14523 Remove unused locals.
7e3ab302
PE
14524 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14525 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
14526 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
14527 macros.
f78faa98 14528
e2b13473
PE
14529 * xterm.h (x_mouse_leave): New decl.
14530
77f23912
PE
14531 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
14532 Remove unused functions.
cdf4ba58
PE
14533 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
14534 (x_calc_absolute_position): Now static.
7411c686 14535 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 14536 Don't declare local "event" unless it's used.
ed7bf3a5
PE
14537 (x_iconify_frame, x_free_frame_resources): Don't declare locals
14538 unless they are used.
38d0b34a
PE
14539 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
14540 (x_fatal_error_signal): Remove; not used.
a6067996
PE
14541 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
14542 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
14543 (x_error_catcher, x_connection_closed, x_error_handler):
14544 (x_error_quitter, xembed_send_message, x_iconify_frame):
14545 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 14546 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 14547 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 14548
44f230aa
SM
14549 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
14550 Rename or move locals to avoid shadowing.
6b463e58 14551 (tty_defined_color, merge_face_heights): Now static.
5967d051 14552 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
14553 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
14554 does not deduce is never used uninitialized.
73719eba
PE
14555 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
14556 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 14557
426994c3 14558 * terminal.c (store_terminal_param): Now static.
5489860b 14559
032f1620 14560 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 14561 (set_frame_menubar): Remove unused local.
d4323972 14562 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
14563 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
14564 since they might point to immutable storage.
281585b0
PE
14565 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
14566 since it's unused otherwise.
032f1620 14567
367c19e5 14568 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 14569 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
14570 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
14571 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 14572 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
14573 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
14574 does not deduce are never used uninitialized.
70739cbe 14575
07b48fa9
PE
14576 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
14577
8868a238 14578 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
14579 * window.c (window_loop, size_window):
14580 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 14581
7e5cf297 14582 * window.c (display_buffer): Now static.
d6550a9f
PE
14583 (size_window): Mark variables that gcc -Wuninitialized
14584 does not deduce are never used uninitialized.
a586633d
PE
14585 * window.h (check_all_windows): New decl, to forestall
14586 gcc -Wmissing-prototypes diagnostic.
5b555da1 14587 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 14588
f6095868
PE
14589 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
14590 shadowing.
14591 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
14592 Include <limits.h>.
14593 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
14594 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
14595 (load_charset_map): Mark variables that gcc -Wuninitialized
14596 does not deduce are never used uninitialized.
53df7c11 14597 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 14598
f38b440c
PE
14599 * coding.c (coding_set_source, coding_set_destination):
14600 Use "else { /* comment */ }" rather than "else /* comment */;"
14601 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
14602 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
14603 a block, when the outer 'i' will do.
14604 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
14605 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
14606 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
14607 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
14608 (Fdecode_sjis_char, Fdefine_coding_system_internal):
14609 Rename locals to avoid shadowing.
14610 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
14611 * coding.c (emacs_mule_char, encode_invocation_designation):
14612 Now static, since they're not used elsewhere.
413bb2db 14613 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 14614 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
14615 (decode_coding_emacs_mule): Mark variables that gcc
14616 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
14617 (detect_coding_iso_2022): Initialize a local variable that might
14618 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 14619 this initialization is needed. (Bug#8211)
5f58e762
PE
14620 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
14621 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
14622 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
14623 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
14624 Remove unused macros.
f38b440c 14625
232b38b9 14626 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 14627 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 14628 * character.c (string_count_byte8): Likewise.
232b38b9 14629
fb90da1b
PE
14630 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
14631 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
14632
fb93dbc2
PE
14633 * chartab.c (copy_sub_char_table): Now static, since it's not used
14634 elsewhere.
5c156ace
PE
14635 (sub_char_table_ref_and_range, char_table_ref_and_range):
14636 Rename locals to avoid shadowing.
bbcd0949 14637 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 14638
7d3b3862 14639 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 14640 (BIDI_BOB): Remove unused macro.
7d3b3862 14641
6be7d3da
PE
14642 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
14643 deduce are never used uninitialized.
c2ed9c8b 14644 * term.c (encode_terminal_code): Likewise.
6be7d3da 14645
75f8807f 14646 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 14647
50938595
PE
14648 * tparam.h: New file.
14649 * term.c, tparam.h: Include it.
14650 * deps.mk (term.o, tparam.o): Depend on tparam.h.
14651 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
14652 Move these decls to tparam.h, and make them agree with what
14653 is actually in tparam.c. The previous trick of using incompatible
14654 decls in different modules does not conform to the C standard.
14655 All callers of tparam changed to use tparam's actual API.
14656 * tparam.c (tparam1, tparam, tgoto):
14657 Use const pointers where appropriate.
14658
fbceeba2
PE
14659 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
14660 * cm.h (struct cm): Likewise.
14661 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
14662 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
14663 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
14664 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
14665 (turn_on_face, init_tty): Likewise.
14666 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 14667
7f3f1250
PE
14668 * term.c (term_mouse_position): Rename local to avoid shadowing.
14669
e6ca6543
PE
14670 * alloc.c (mark_ttys): Move decl from here ...
14671 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
14672
c40f8d15
AS
146732011-03-11 Andreas Schwab <schwab@linux-m68k.org>
14674
14675 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
14676
cfe0661d
JB
146772011-03-09 Juanma Barranquero <lekktu@gmail.com>
14678
14679 * search.c (compile_pattern_1): Remove argument regp, unused since
14680 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
14681 (compile_pattern): Don't pass it.
14682
0afb4571
J
146832011-03-08 Jan Djärv <jan.h.d@swipnet.se>
14684
14685 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
14686 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
14687 for ! HAVE_GTK3.
14688 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
14689
14690 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
14691
14692 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
14693 gdk_window_get_screen, gdk_window_get_geometry,
14694 gdk_x11_window_lookup_for_display and GDK_KEY_g.
14695 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
14696 (xg_get_pixbuf_from_pixmap): New function.
14697 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
14698 to Pixmap, take frame as parameter, remove GdkColormap parameter.
14699 Call xg_get_pixbuf_from_pixmap instead of
14700 gdk_pixbuf_get_from_drawable.
14701 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
14702 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
14703 (xg_check_special_colors): Use GtkStyleContext and its functions
14704 for HAVE_GTK3.
14705 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
14706 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
14707 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
14708 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
14709 Call gtk_widget_get_preferred_size.
0afb4571
J
14710 (xg_frame_resized): gdk_window_get_geometry only takes 5
14711 parameters.
44f230aa
SM
14712 (xg_win_to_widget, xg_event_is_for_menubar):
14713 Call gdk_x11_window_lookup_for_display.
0afb4571
J
14714 (xg_set_widget_bg): New function.
14715 (delete_cb): New function.
895009e1 14716 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 14717 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
14718 (xg_set_background_color): Call xg_set_widget_bg.
14719 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
14720 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
14721 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
14722 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
14723 if ! HAVE_GTK3.
14724 (update_frame_tool_bar): Call gtk_widget_hide.
14725 (xg_initialize): Use GDK_KEY_g.
14726
14727 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
14728 if ! HAVE_GTK3
14729 (x_session_initialize): Call gdk_x11_set_sm_client_id.
14730
14731 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
14732 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
14733 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
14734
1c2cc4ef
JB
147352011-03-08 Juanma Barranquero <lekktu@gmail.com>
14736
14737 * w32xfns.c (select_palette): Check success of RealizePalette against
14738 GDI_ERROR, not zero.
14739
33383987 14740See ChangeLog.11 for earlier changes.
aac0c6e3
MR
14741
14742;; Local Variables:
14743;; coding: utf-8
aac0c6e3
MR
14744;; End:
14745
2f097256 14746 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
14747
14748 This file is part of GNU Emacs.
14749
14750 GNU Emacs is free software: you can redistribute it and/or modify
14751 it under the terms of the GNU General Public License as published by
14752 the Free Software Foundation, either version 3 of the License, or
14753 (at your option) any later version.
14754
14755 GNU Emacs is distributed in the hope that it will be useful,
14756 but WITHOUT ANY WARRANTY; without even the implied warranty of
14757 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14758 GNU General Public License for more details.
14759
14760 You should have received a copy of the GNU General Public License
14761 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.