newsticker: Clean up newsticker--group-manage-orphan-feeds
[bpt/emacs.git] / src / ChangeLog
CommitLineData
196e41e4
PE
12011-10-29 Paul Eggert <eggert@cs.ucla.edu>
2
3 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
4 so that this new function doesn't get optimized away by a
5 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
6
021f2e1a
AS
72011-10-29 Andreas Schwab <schwab@linux-m68k.org>
8
9 * frame.h (MOUSE_HL_INFO): Remove excess parens.
10
8b058d44
EZ
112011-10-29 Eli Zaretskii <eliz@gnu.org>
12
13 Fix the `xbytecode' command.
14 * .gdbinit (xprintbytestr): New command.
15 (xwhichsymbols): Renamed from `which'; all callers changed.
16 (xbytecode): Print the byte-code string as well.
17
4452fb80
EZ
182011-10-29 Kim Storm <storm@cua.dk>
19
8b058d44
EZ
20 * alloc.c (which_symbols): New function.
21
21b72067
AS
222011-10-29 Andreas Schwab <schwab@linux-m68k.org>
23
24 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
25 line. (Bug#9903)
26
83ed7b5c
GM
272011-10-29 Glenn Morris <rgm@gnu.org>
28
29 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
30 Not clear what it was for, and it causes various bugs. (Bug#9839)
31
5a7a728b
EZ
322011-10-28 Eli Zaretskii <eliz@gnu.org>
33
34 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
35 possible random value that matches one of those tested as
36 condition to clear the mouse face.
37
d3d0842f
CY
382011-10-28 Chong Yidong <cyd@gnu.org>
39
40 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
41
31b39d13
DN
422011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
43
44 * window.c (make_window): Initialize phys_cursor_on_p.
45
9aba6043
SM
462011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
47
48 * lisp.h (struct Lisp_Symbol): Update comments.
49
c20992f4
JB
502011-10-28 Juanma Barranquero <lekktu@gmail.com>
51
52 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
53
db4f02f2
EZ
542011-10-28 Eli Zaretskii <eliz@gnu.org>
55
56 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
57 <oslsachem@gmail.com> for helping to debug this.
58
59 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
60 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
61 (g_b_init_get_glyph_outline_w): New static variables.
62 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
63 (GetGlyphOutlineW_Proc): New typedefs.
64 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
65 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
66 New functions.
67 (w32font_open_internal, compute_metrics):
68 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
69 instead of calling the "wide" APIs directly.
70
71 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
72
73 * w32.h (syms_of_w32font): Add prototype.
74
87e68db4
JB
752011-10-27 Juanma Barranquero <lekktu@gmail.com>
76
77 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
78 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
79 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
80 (Fmove_to_window_line): Doc fix.
81
435c1d67
CY
822011-10-27 Chong Yidong <cyd@gnu.org>
83
84 * process.c (make_process): Set gnutls_state to NULL.
85
86 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
87 non-NULL, regardless of GNUTLS_INITSTAGE.
88 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
89 an error. Set process slots as soon as we allocate them.
90
91 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
92
9c6c6f49
CY
932011-10-27 Chong Yidong <cyd@gnu.org>
94
9aba6043
SM
95 * gnutls.c (emacs_gnutls_deinit): New function.
96 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
97 (Fgnutls_deinit, Fgnutls_boot): Use it.
98
99 * process.c (make_process): Initialize GnuTLS credentials to NULL.
100 (deactivate_process): Call emacs_gnutls_deinit.
101
657d08d3
JB
1022011-10-27 Juanma Barranquero <lekktu@gmail.com>
103
104 * image.c (x_create_x_image_and_pixmap):
105 * w32.c (sys_rename, w32_delayed_load):
106 * w32font.c (fill_in_logfont):
107 * w32reg.c (x_get_string_resource): Silence compiler warnings.
108
5430d399
JB
1092011-10-26 Juanma Barranquero <lekktu@gmail.com>
110
111 * w32fns.c (w32_default_color_map): New function,
112 extracted from Fw32_default_color_map.
a7ef684b 113 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 114
fe0055fa
PE
1152011-10-25 Paul Eggert <eggert@cs.ucla.edu>
116
117 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
118
e6346438
SM
1192011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
120
121 * keyboard.c (test_undefined): New function (bug#9751).
122 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
123
e112cc37
ET
1242011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
125
126 * sysdep.c (init_sys_modes): Fix the check for the controlling
127 terminal (Bug#6649).
128
7b5d6677
EZ
1292011-10-20 Eli Zaretskii <eliz@gnu.org>
130
131 * dispextern.h (struct bidi_it): New member next_en_type.
132
133 * bidi.c (bidi_line_init): Initialize the next_en_type member.
134 (bidi_resolve_explicit_1): When next_en_pos is valid for the
135 current character, check also for next_en_type being WEAK_EN.
136 (bidi_resolve_weak): Don't enter the expensive loop if the current
137 position is before next_en_pos. Record the bidi type of the first
138 non-ET, non-BN character we find, in addition to its position.
139 (bidi_level_of_next_char): Invalidate next_en_type when
140 next_en_pos is over-stepped.
141
7da0b018
PE
1422011-10-20 Paul Eggert <eggert@cs.ucla.edu>
143
144 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
145 * editfns.c: Rewrite current-time-zone so that it invokes
146 the equivalent of (format-time-string "%Z") to get the time zone name.
147 This fixes a bug when the time zone name contains characters that
148 need converting from the system time locale to Emacs internal format.
149 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
150 that patch fixed format-time-string to do the conversion, but
151 I forgot to fix current-time-zone.
152 (format_time_string): New function, containing most of
153 what Fformat_time_string used to contain.
154 (Fformat_time_string): Rewrite in terms of format_time_string.
155 This doesn't change this function's behavior.
156 (current-time-zone): Rewrite to use format_time_string.
157 This fixes the bug reported by Michael Schierl in
158 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
159 Jason Rumney's 2007-06-07 change worked around this bug, but
160 didn't fix it.
161 * systime.h (tzname, timezone): Remove no-longer-used declarations.
162
8547b010
EZ
1632011-10-19 Eli Zaretskii <eliz@gnu.org>
164
165 * xdisp.c (start_display): If the character at POS is displayed
166 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
167 (try_window_reusing_current_matrix): If a line ends in a display
168 vector or the next line starts in a display vector, continue
169 redrawing the window even though the character position of
170 start_row was reached.
8547b010
EZ
171 (Bug#9771, part 2)
172
4e948d15
CY
1732011-10-18 Chong Yidong <cyd@gnu.org>
174
175 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
176 with nobreak-char-display too.
177
4787455f
EZ
1782011-10-18 Eli Zaretskii <eliz@gnu.org>
179
180 Fix part 3 of bug#9771.
181 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
182 (bidi_resolve_neutral): Don't enter the expensive loop looking for
183 non-neutral characters if the current character is a paragraph
184 separator (a.k.a. Newline). This avoids running the same
185 expensive loop twice, once when we consume the preceding newline
186 and the other time when the line actually needs to be displayed.
187 Avoid the loop when we see neutrals on the base embedding level
188 following a character whose directionality is the same as the
189 paragraph's. This avoids running the expensive loop when a line
190 ends in a long sequence of neutrals, like control characters.
191 Add assertion against STRONG_AL type. Slightly rearrange code
192 that determines the type of a neutral given the first non-neutral
193 that follows it.
194 (bidi_level_of_next_char): Set next_en_pos to zero when
195 invalidating its info.
196
2c91f553
EZ
1972011-10-17 Eli Zaretskii <eliz@gnu.org>
198
199 * xdisp.c (push_display_prop): Determine whether to record string
200 or buffer position by IT->string, not by IT->method. Allow
201 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
202 (move_it_vertically_backward): Don't look for character position
203 immediately after the newline when in a continuation line.
204 (Bug#9771, part 1)
2c91f553 205
c7b08b0d
MR
2062011-10-15 Martin Rudalics <rudalics@gmx.at>
207
208 * window.c (coordinates_in_window): Rewrite and delabelize
209 vertical border check. (Bug#5357) (Bug#9618)
210
6b02f655
SM
2112011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
212
213 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
214 errors in XSetWindowBorder (bug#9310).
215
81d40c92
DA
2162011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
217
218 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
219 avoid crash when xmalloc overrun checking is enabled.
220
d4172c3b
EZ
2212011-10-13 Eli Zaretskii <eliz@gnu.org>
222
223 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
224 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
225 cursor motion with <left> and <right> arrow keys.
226
227 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
228 some callers set that themselves.
229
b00eea75
EZ
2302011-10-12 Eli Zaretskii <eliz@gnu.org>
231
232 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
233 display string and the previous row comes from the same string and
234 is empty. (Bug#9739) (Bug#9738)
235
8fe012c4
SM
2362011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
237
238 * doc.c (get_doc_string): Encode file name (bug#9735).
239
0074aef2
EZ
2402011-10-12 Eli Zaretskii <eliz@gnu.org>
241
79beb178
EZ
242 * bidi.c (bidi_level_of_next_char):
243 * xdisp.c (get_visually_first_element): Remove old incorrect
244 comments regarding the Unicode Line Separator character.
245
0074aef2
EZ
246 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
247
6e4b3fbe
DA
2482011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
249
250 * alloc.c (Fgc_status): Do not access beyond zombies array
251 boundary if nzombies > MAX_ZOMBIES.
252 * alloc.c (dump_zombies): Add missing format specifier.
253
0324f3af
PE
2542011-10-12 Paul Eggert <eggert@cs.ucla.edu>
255
b5525cac
PE
256 * xdisp.c (set_cursor_from_row): Simplify conditionals,
257 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
258
0324f3af
PE
259 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
260 Some packages use them to denote characters with modifiers.
261
e9b5f888
AS
2622011-10-11 Andreas Schwab <schwab@linux-m68k.org>
263
264 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
265 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
266 matching a pp-number. Rename parameter var to var1.
267
127827c0
SM
2682011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
269
270 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
271
c8fd3bd0
GM
2722011-10-08 Glenn Morris <rgm@gnu.org>
273
274 * callint.c (Fcall_interactively): Give a more explicit error for the
275 'c' case with a non-character input. (Bug#8479)
276
352ec8ff
EZ
2772011-10-08 Eli Zaretskii <eliz@gnu.org>
278
03669ccb
EZ
279 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
280 lines.
7061c986
EZ
281 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
282 lines that are hscrolled on the left.
03669ccb 283
352ec8ff
EZ
284 * dispnew.c (buffer_posn_from_coords): Account for a possible
285 presence of header-line. (Bug#4426)
286
a66cfb1c
SM
2872011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
288
6b02f655
SM
289 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
290 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 291
7c5ee88e
PE
2922011-10-07 Paul Eggert <eggert@cs.ucla.edu>
293
294 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
295 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
296 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
297 this makes Emacs dump core during garbage collection on rare
298 occasions. sizeof is obviously inferior to offsetof here, so
299 stick with offsetof.
300 (GC_POINTER_ALIGNMENT): New macro.
301 (mark_memory): Omit 3rd (offset) arg; caller changed.
302 Don't assume EMACS_INT alignment is the same as pointer alignment.
303
df1bbe5b
SM
3042011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
305
306 * keyboard.c (read_key_sequence_remapped): New var.
307 (read_key_sequence): Compute remapping in the right buffer.
308 (command_loop_1): Use read_key_sequence's remapping directly.
309
51553db6
SM
3102011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
311
32c1fffd
SM
312 * dired.c (file_name_completion): Don't expand file name.
313 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
314 before checking file name handler.
315
51553db6
SM
316 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
317 they've been requested explicitly (bug#9591).
318
b6bd1599 3192011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
320
321 * keymap.c (Fsingle_key_description): Use make_specified_string
322 instead of build_string to build string from push_key_description.
323 (Bug#5193)
324
f701dc2a
PE
3252011-09-30 Paul Eggert <eggert@cs.ucla.edu>
326
4222c55d
PE
327 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
328 This fixes a Y2038 bug on 64-bit hosts.
329 * buffer.c (reset_buffer):
330 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
331 (Fclear_buffer_auto_save_failure):
332 Use 0, not -1, to represent an unset failure time, since time_t
333 might not be signed.
334
f701dc2a
PE
335 Remove dependency on glibc malloc internals.
336 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
337 Move back here from lisp.h, but with their new implementations.
338 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
339 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
340 * charset.c (charset_table_init): New static var.
341 (syms_of_charset): Use it instead of xmalloc. This removes a
342 dependency on glibc malloc internals. See Eli Zaretskii's comment in
343 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
344 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
345 Move back to alloc.c.
346 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
347 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
348
9ceebf39
JD
3492011-09-30 Jan Djärv <jan.h.d@swipnet.se>
350
351 * nsterm.m (windowDidResize): Call x_set_window_size only when
352 ns_in_resize is true. Otherwise set pixelwidth/height and
353 call change_frame_size (Bug#9628).
354
cb993c58
PE
3552011-09-30 Paul Eggert <eggert@cs.ucla.edu>
356
3930c88b
PE
357 Port --enable-checking=all to Fedora 14 x86-64.
358 * charset.c (syms_of_charset): Also account for glibc malloc's
359 internal overhead when calculating the initial malloc maximum.
360
cb993c58
PE
361 Port --enable-checking=all to Fedora 14 x86.
362 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
363 Move to lisp.h.
364 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
365 (overrun_check_realloc, overrun_check_free):
366 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
367 That way, xmalloc returns a properly-aligned pointer even if
368 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
369 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
370 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
371 into account when calculating the initial malloc maximum.
372 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
373 Move here from alloc.c, so that charset.c can use it too.
374 Properly align; the old code wasn't right for common 32-bit hosts
375 when configured with --enable-checking=all.
376 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
377 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
378
31bed486
EZ
3792011-09-29 Eli Zaretskii <eliz@gnu.org>
380
04c70788 381 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
382 use EDOM.
383
fbcaa2f3
EZ
3842011-09-28 Eli Zaretskii <eliz@gnu.org>
385
386 * xdisp.c (compute_display_string_end): If there's no display
387 string at CHARPOS, return -1.
388
389 * bidi.c (bidi_fetch_char): When compute_display_string_end
390 returns a negative value, treat the character as a normal
391 character not covered by a display string. (Bug#9624)
392
a239d4e9
JB
3932011-09-28 Juanma Barranquero <lekktu@gmail.com>
394
395 * lread.c (Fread_from_string): Fix typo in docstring.
396
88652fd5
EZ
3972011-09-27 Eli Zaretskii <eliz@gnu.org>
398
399 * xdisp.c (handle_invisible_prop): If invisible text ends on a
400 newline, reseat the iterator instead of bidi-iterating there one
401 character at a time. (Bug#9610)
32c1fffd
SM
402 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
403 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 404
ed497dd4
AS
4052011-09-27 Andreas Schwab <schwab@linux-m68k.org>
406
407 * lread.c (readevalloop): Use correct code for NBSP.
408 (read1): Likewise. (Bug#9608)
409
b2bf61aa
MA
4102011-09-25 Michael Albinus <michael.albinus@gmx.de>
411
412 * dbusbind.c (Fdbus_register_signal): When service is not
413 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
414
32bbb17c
GM
4152011-09-25 Glenn Morris <rgm@gnu.org>
416
417 * buffer.c (truncate-lines): Doc fix.
418
94e0933e
CY
4192011-09-24 Chong Yidong <cyd@stupidchicken.com>
420
421 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
422 (Fset_window_next_buffers): Doc fix.
423
cddde921
GM
4242011-09-24 Glenn Morris <rgm@gnu.org>
425
426 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
427
1260aef1
PE
4282011-09-24 Paul Eggert <eggert@cs.ucla.edu>
429
25b4bfa0
PE
430 Fix minor problems found by static checking.
431 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
432 * indent.c (Fvertical_motion): Fix == vs = typo.
433
e3cbd34b
EZ
4342011-09-24 Eli Zaretskii <eliz@gnu.org>
435
a66cfb1c
SM
436 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
437 Default value is now t. Doc fix.
6bf7006f 438
e3cbd34b 439 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 440 logic when moving up, not only when moving down. Fix the
e3cbd34b 441 confusing name and values of the it_overshoot_expected variable;
32c1fffd 442 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
443
444 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
445 CHARPOS is covered by a display string which includes newlines.
446 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
447 is covered by a display string with embedded newlines.
448
a3de0cbd
MA
4492011-09-24 Michael Albinus <michael.albinus@gmx.de>
450
451 * dbusbind.c (Fdbus_register_signal): Add match rule to
452 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
453 (Fdbus_register_method, Vdbus_registered_objects_table):
454 Fix docstring.
a3de0cbd 455
b260039d
JM
4562011-09-24 Jim Meyering <meyering@redhat.com>
457
32c1fffd 458 do not ignore write error for any output size
b260039d
JM
459 The previous change was incomplete.
460 While it makes emacs --batch detect the vast majority of stdout
461 write failures, errors were still ignored whenever the output size is
462 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
463 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
464 && echo FAIL: ignored write error
465 FAIL: ignored write error
466 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
467 && echo FAIL: ignored write error
468 FAIL: ignored write error
469 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
470
8eca8a7c
AS
4712011-09-23 Andreas Schwab <schwab@linux-m68k.org>
472
473 * emacs.c (Fkill_emacs): In noninteractive mode exit
474 non-successfully if a write error occurred on stdout. (Bug#9574)
475
3341db62
EZ
4762011-09-21 Eli Zaretskii <eliz@gnu.org>
477
478 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
479 the xassert test.
480
481 * dispextern.h (struct it): Update the comment documenting what
482 can it->OBJECT be.
483
8c203dbf
EZ
4842011-09-20 Eli Zaretskii <eliz@gnu.org>
485
486 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
487 a display string, extend search for cursor position to end of row.
488 (find_row_edges): If the row ends in a newline from a display
489 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
490 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
491 (Fcurrent_bidi_paragraph_direction): Fix search for previous
492 non-empty line. Fixes confusing cursor motion with arrow keys at
493 the beginning of a line that starts with whitespace.
8c203dbf 494
a4824228
LMI
4952011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
496
497 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
498 (bug#9493).
499
33ed493b
CY
5002011-09-18 Chong Yidong <cyd@stupidchicken.com>
501
502 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
503 boolean (Bug#9154).
504
56cd55c8
EZ
5052011-09-18 Eli Zaretskii <eliz@gnu.org>
506
507 * xdisp.c (display_line): Record maximum and minimum buffer
508 positions even if no glyphs were produced (e.g., by a zero-width
509 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
510 buffer positions that will be removed from the glyph row because
511 they don't fit.
c02dcedf
EZ
512 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
513 column is beyond frame width: don't subtract 1 "pixel" when
514 computing width of the stretch.
3e62b7e0
EZ
515 (reseat_at_next_visible_line_start): Undo the change made on
516 2011-09-17 that saved paragraph information and restored it after
517 the call to `reseat'. (Bug#9545)
56cd55c8 518
5ed99d36 5192011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
520
521 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
522 and turn window cursor on if cleared (Bug#9415).
523
5ed99d36 5242011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
525
526 * search.c (boyer_moore): Take unibyte characters from pattern
527 literally. (Bug#9458)
528
9bade7b2
EZ
5292011-09-18 Eli Zaretskii <eliz@gnu.org>
530
531 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
532
e5e9d610
PE
5332011-09-18 Paul Eggert <eggert@cs.ucla.edu>
534
87e4427a
PE
535 Fix minor problem found by static checking.
536 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
537 initialized, to pacify gcc -Wuninitialized.
538
e5e9d610
PE
539 * fileio.c: Report proper errno when syscall falls.
540 (Finsert_file_contents): Save and restore errno,
541 so that report_file_error outputs the correct diagnostic.
542 (Fwrite_region) [CLASH_DETECTION]: Likewise.
543
a1674f0b
EZ
5442011-09-18 Eli Zaretskii <eliz@gnu.org>
545
546 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
547
fbfb6dd4
EZ
5482011-09-17 Eli Zaretskii <eliz@gnu.org>
549
550 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
551 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
552
bb187662
EZ
5532011-09-17 Eli Zaretskii <eliz@gnu.org>
554
1137e8b8 555 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 556 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
557
558 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
559 (bidi_find_paragraph_start): Search back for paragraph beginning
560 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
561 (bidi_move_to_visually_next): Only trigger paragraph-related
562 computations when the last character is a newline or at EOB, not
563 just any NEUTRAL_B. (Bug#9470)
564
bb187662
EZ
565 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
566 truncated lines if point is covered by a display string. (Bug#9524)
567
2e621251
PE
5682011-09-16 Paul Eggert <eggert@cs.ucla.edu>
569
570 * xselect.c: Relax test for outgoing X longs (Bug#9498).
571 (cons_to_x_long): New function.
572 (lisp_data_to_selection_data): Use it. Correct the test for
573 short-versus-long data; it was negated. Break out of vector
574 loop, for efficiency, when a long datum is discovered.
575
91a15bc6
SM
5762011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
577
578 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
579
b41c3a35
EZ
5802011-09-16 Eli Zaretskii <eliz@gnu.org>
581
582 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
583 GCC PR/17406) by declaring this function with external scope.
584
7812ba2d
PE
5852011-09-15 Paul Eggert <eggert@cs.ucla.edu>
586
587 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
588 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
589
cf7edc2a
AS
5902011-09-15 Andreas Schwab <schwab@linux-m68k.org>
591
592 * editfns.c (Fformat): Correctly handle text properties on "%%".
593
bd01620e
EZ
5942011-09-15 Eli Zaretskii <eliz@gnu.org>
595
596 * xterm.c (x_draw_composite_glyph_string_foreground):
597 * w32term.c (x_draw_composite_glyph_string_foreground):
598 * term.c (encode_terminal_code):
599 * composite.c (composition_update_it, get_composition_id):
600 * xdisp.c (get_next_display_element)
601 (fill_composite_glyph_string): Add comments about special meaning
602 of TAB characters in a composition.
603
a02719a3
PE
6042011-09-15 Paul Eggert <eggert@cs.ucla.edu>
605
606 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
607 This occurs when processing a multibyte format.
608 Problem reported by Wolfgang Jenker.
a02719a3 609
72589a3c
JB
6102011-09-15 Johan Bockgård <bojohan@gnu.org>
611
612 * xdisp.c (try_cursor_movement): Only check for exact match if
613 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
614
1c14176c
PE
6152011-09-14 Paul Eggert <eggert@cs.ucla.edu>
616
617 Remove unused external symbols.
618 * dispextern.h (calc_pixel_width_or_height): Remove decl.
619 * xdisp.c (calc_pixel_width_or_height): Now static.
620 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
621 * indent.c (check_display_width):
622 * w32term.c: Fix comment to match code.
623 * xterm.c, xterm.h (x_catching_errors): Remove.
624
d2eea5b5
PE
6252011-09-14 Paul Eggert <eggert@cs.ucla.edu>
626
627 * xselect.c: Use signed conversions more consistently (Bug#9498).
628 (selection_data_to_lisp_data): Assume incoming selection data are
629 signed integers, not unsigned. This is to be consistent with
630 outgoing selection data, which was modified to use signed integers
631 in as part of the fix to Bug#9196 in response to Jan D.'s comment
632 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
633 expects long, not unsigned long.
634
46888499
EZ
6352011-09-14 Eli Zaretskii <eliz@gnu.org>
636
637 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
638 computation of loop end. Reported by Johan Bockgård
639 <bojohan@gnu.org>.
640
ef8ef9fb
CY
6412011-09-13 Chong Yidong <cyd@stupidchicken.com>
642
643 * frame.c (Fother_visible_frames_p): Function deleted.
644
fa819fed
EZ
6452011-09-12 Eli Zaretskii <eliz@gnu.org>
646
647 * indent.c (compute_motion): Process display vector front to back
648 rather than the other way around. (Bug#2496)
649
2ba8e008
SM
6502011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
651
652 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
653
20f53c69
CY
6542011-09-11 Chong Yidong <cyd@stupidchicken.com>
655
656 * minibuf.c (Fread_from_minibuffer): Doc fix.
657
d562d7a4
EZ
6582011-09-11 Eli Zaretskii <eliz@gnu.org>
659
660 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
661 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
662
1c4d7f3d
LMI
6632011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
664
665 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
666 value for non-existent files.
667
b885bf36
EZ
6682011-09-11 Eli Zaretskii <eliz@gnu.org>
669
670 * fileio.c (Finsert_file_contents): If the file cannot be opened,
671 set its "size" to -1. This will set the modtime_size field of
672 the corresponding buffer to -1, which is what
673 verify-visited-file-modtime expects for files that do not exist.
674 (Bug#9139)
675
6612f0bf
PE
6762011-09-11 Paul Eggert <eggert@cs.ucla.edu>
677
678 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
679 here ...
680 * lisp.h: ... from here. push_key_description is no longer
681 defined in keyboard.c, so its declaration should not be in
682 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
683 logically belongs with push_key_description.
684
dfb3f755
PE
6852011-09-10 Paul Eggert <eggert@cs.ucla.edu>
686
687 * buffer.h: Include <sys/types.h> instead of <time.h>.
688 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
689 Problem reported by Herbert J. Skuhra.
690
3134906c
LMI
6912011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
692
693 * xml.c (parse_region): Make the parsing work for
694 non-comment-starting XML files again (bug#9144).
695
8d903f4e
AS
6962011-09-10 Andreas Schwab <schwab@linux-m68k.org>
697
698 * image.c (gif_load): Fix calculation of bottom and right corner.
699 (Bug#9468)
700
80ad64f4
EZ
7012011-09-10 Eli Zaretskii <eliz@gnu.org>
702
703 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
704 redisplay in small windows.
705
208a048d
EZ
7062011-09-09 Eli Zaretskii <eliz@gnu.org>
707
708 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
709
9b1c252e
MR
7102011-09-08 Martin Rudalics <rudalics@gmx.at>
711
712 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
713 Operate on live windows only.
714
2949f33b
JB
7152011-09-08 Juanma Barranquero <lekktu@gmail.com>
716
717 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
718
e08dcafd
EZ
7192011-09-07 Eli Zaretskii <eliz@gnu.org>
720
721 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
722 only under bidi iteration.
723
115b96bd
JD
7242011-09-07 Jan Djärv <jan.h.d@swipnet.se>
725
726 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
727
c8199d0f
PE
7282011-09-06 Paul Eggert <eggert@cs.ucla.edu>
729
730 isnan: Fix porting problem to Solaris 10 with bundled gcc.
731 Without this fix, the command to link temacs failed due to an
732 undefined symbol __builtin_isnan. This is because
733 /usr/include/iso/math_c99.h #defines isnan(x) to
734 __builtin_isnan(x), but the bundled gcc, which identifies itself
735 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
736 a __builtin_isnan.
737 * floatfns.c (isnan): #undef, and then #define to a clone of
738 what's in data.c.
739 (Fisnan): Always define, since it's always available now.
740 (syms_of_floatfns): Always define isnan at the Lisp level.
741
e39b275c 7422011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
743
744 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
745
b2db44d9 7462011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 747
f4af5137 748 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
749 The previous code assumed that file offsets (off_t values) fit in
750 EMACS_INT variables, which is not true on typical 32-bit hosts.
751 The code messed up by falsely reporting buffer overflow in cases
752 such as (insert-file-contents "big" nil 1 2) into an empty buffer
753 when "big" contains more than 2**29 bytes, even though this
754 inserts just one byte and does not overflow the buffer.
755 (Finsert_file_contents): Store file offsets as off_t
756 values, not as EMACS_INT values. Check for overflow when
757 converting between EMACS_INT and off_t. When checking for
758 buffer overflow or for overlap, take the offsets into account.
759 Don't use EMACS_INT for small values where int suffices.
760 When checking for overlap, fix a typo: ZV was used where
761 ZV_BYTE was intended.
762 (Fwrite_region): Don't assume off_t fits into 'long'.
763 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
764
ecfc0a49
MA
7652011-09-05 Michael Albinus <michael.albinus@gmx.de>
766
767 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
768
6511acf2 7692011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 770
0999621a 771 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
772
773 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 774 (esprintf, exprintf, evxprintf): New functions.
62f19c19 775 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 776 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
777 (modify_event_symbol): Do not assume that the length of
778 name_alist_or_stem is safe to alloca and fits in int.
779 (Fexecute_extended_command): Likewise for function name and binding.
780 (Frecursion_depth): Wrap around reliably on integer overflow.
781 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
782 since some callers pass EMACS_INT values.
783 (Fsingle_key_description): Don't crash if symbol name contains more
784 than MAX_ALLOCA bytes.
785 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
786 (get_minibuffer): Arg is now EMACS_INT, not int.
787 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 788 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
789 * window.h (command_loop_level, minibuf_level): Reflect API changes.
790
2be7d702
PE
791 * dbusbind.c (signature_cat): New function.
792 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
793 Do not overrun buffer; instead, report string overflow.
794
9d1df220
PE
795 * dispnew.c (add_window_display_history): Don't overrun buffer.
796 Truncate instead; this is OK since it's just a log.
797
33ef5c64
PE
798 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
799 even if the time zone offset is outlandishly large.
800 Don't mishandle offset == INT_MIN.
801
66c6fdd5
PE
802 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
803 when creating daemon; the previous buffer-overflow check was incorrect.
804
d749b01b
PE
805 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
806 which has the guts of the old verror function.
807
b5cd1905
PE
808 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
809 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
810
6e1a67fb
PE
811 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
812 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 813 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 814 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
815 length of string rather than counting it via multiple sprintfs;
816 that's simpler and more reliable.
c21721cc
PE
817 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
818 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
819 sprintf, in case result does not fit in int.
820
c57b67fc
PE
821 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
822 (fontset_from_font): Print it.
823
8a401434
PE
824 * frame.c (tty_frame_count): Now printmax_t, not int.
825 (make_terminal_frame, set_term_frame_name): Print it.
826 (x_report_frame_params): In X, window IDs are unsigned long,
827 not signed long, so print them as unsigned.
828 (validate_x_resource_name): Check for implausibly long names,
829 and don't assume name length fits in 'int'.
830 (x_get_resource_string): Don't blindly alloca invocation name;
831 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
832 not fit in int.
833
6e1a67fb
PE
834 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
835 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
836 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
837
0df02bf3
PE
838 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
839 Use esprintf, not sprintf, in case result does not fit in int.
840
48e30793
PE
841 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
842 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
843 it as a large positive number.
844 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
845 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
846
a66ff6d8
PE
847 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
848 in case result does not fit in int.
849
aca216ff
PE
850 * print.c (float_to_string): Detect width overflow more reliably.
851 (print_object): Make sprintf buffer a bit bigger, to avoid potential
852 buffer overrun. Don't assume list length fits in 'int'. Treat
853 print length of 0 as 0, not as infinity; to be consistent with other
854 uses of print length in this function. Don't overflow print length
855 index. Don't assume hash table size fits in 'long', or that
856 vectorlike size fits in 'unsigned long'.
857
31c286f7
PE
858 * process.c (make_process): Use printmax_t, not int, to format
859 process-name gensyms.
860
55e5faa1
PE
861 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
862
80f2e268
PE
863 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
864 to avoid potential buffer overrun.
865
670741ab
PE
866 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
867 if X resource line is longer than 512 bytes.
868
b7163a50
PE
869 * xfns.c (x_window): Make sprintf buffer a bit bigger
870 to avoid potential buffer overrun.
871
ae58ff1f
PE
872 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
873
c43c8a6a
PE
874 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
875
3f8236f4
PE
8762011-09-04 Paul Eggert <eggert@cs.ucla.edu>
877
53e9fe90 878 Integer overflow fixes for scrolling, etc.
6511acf2
PE
879 Without these, Emacs silently mishandles large integers sometimes.
880 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
881 it were "C-u 1 M-x recenter" on a typical 64-bit host.
882
6511acf2
PE
883 * xdisp.c (try_window_id): Check Emacs fixnum range before
884 converting to 'int'.
806add1d 885
6511acf2 886 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
887 Check that an Emacs fixnum is in range before assigning it to 'int'.
888 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
889 values converted from Emacs fixnums.
890 (Frecenter): Don't wrap around a line count if it is out of 'int'
891 range; instead, treat it as an extreme value.
892 (Fset_window_configuration, compare_window_configurations):
893 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
894
6511acf2
PE
895 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
896 that can exceed INT_MAX. Check that EMACS_INT value is in range
897 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
898 (match_limit): Don't assume that a fixnum can fit in 'int'.
899
6511acf2 900 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
901 exceed INT_MAX.
902
6511acf2 903 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
904 (Fvertical_motion): Don't wrap around LINES values that don't fit
905 in 'int'. Instead, treat them as extreme values. This is good
906 enough for windows, which can't have more than INT_MAX lines anyway.
907
fcb901a7
LMI
9082011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
909
0f2f6b6d
LMI
910 * Require libxml/parser.h to avoid compilation warning.
911
fcb901a7
LMI
912 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
913
914 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
915 since this reportedly can destroy thread storage.
916
6e20a0d4
CY
9172011-08-30 Chong Yidong <cyd@stupidchicken.com>
918
919 * syntax.c (find_defun_start): Update all cache variables if
920 exiting early (Bug#9401).
921
148ae00e
EZ
9222011-08-30 Eli Zaretskii <eliz@gnu.org>
923
f6cfbd8f
EZ
924 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
925
148ae00e
EZ
926 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
927 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
928 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
929
930 * term.c (tty_append_glyph): New function.
931 (produce_stretch_glyph): Static function and its prototype deleted.
932
a66cfb1c
SM
933 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
934 Add prototypes.
148ae00e 935
c4a07a4c
PE
9362011-08-29 Paul Eggert <eggert@cs.ucla.edu>
937
938 * image.c (parse_image_spec): Check for nonnegative, not for positive,
939 when checking :margin (Bug#9390).
940 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 941 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
942 so that the name doesn't mislead. All uses changed.
943
6bc8cd65
JB
9442011-08-28 Johan Bockgård <bojohan@gnu.org>
945
946 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
947 set_tty_hooks.
948
dca4927e
EZ
9492011-08-27 Eli Zaretskii <eliz@gnu.org>
950
951 * xdisp.c (move_it_to): Don't bail out early when reaching
952 position beyond to_charpos, if we are scanning backwards.
953 (move_it_vertically_backward): When DY == 0, make sure we get to
954 the first character in the line after the newline.
955
f2cad773
PE
9562011-08-27 Paul Eggert <eggert@cs.ucla.edu>
957
958 * ccl.c: Improve and simplify overflow checking (Bug#9196).
959 (ccl_driver): Do not generate an out-of-range pointer.
960 (Fccl_execute_on_string): Remove unnecessary check for
961 integer overflow, noted by Stefan Monnier in
962 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
963 Remove a FIXME that didn't need fixing.
964 Simplify the newly-introduced buffer reallocation code.
965
0cae2cdb
JB
9662011-08-27 Juanma Barranquero <lekktu@gmail.com>
967
968 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
969
5fc295a4 9702011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 971
70c60eb2 972 Integer and memory overflow issues (Bug#9196).
726e0ab1 973
d31850da
PE
974 * doc.c (get_doc_string): Rework so that
975 get_doc_string_buffer_size is the actual buffer size, rather than
976 being 1 less than the actual buffer size; this makes xpalloc more
977 convenient.
978
a69fbedb
PE
979 * image.c (x_allocate_bitmap_record, cache_image):
980 * xselect.c (Fx_register_dnd_atom):
981 Simplify previous changes by using xpalloc.
982
fe5c5d37
PE
983 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
984 since either will do and ptrdiff_t is convenient with xpalloc.
985
0065d054
PE
986 * charset.c (charset_table_size)
987 (struct charset_sort_data.priority): Now ptrdiff_t.
988 (charset_compare): Don't overflow if priorities differ greatly.
989 (Fsort_charsets): Don't assume list length fits in int.
990 Check for size-calculation overflow when allocating sort data.
991 (syms_of_charset): Allocate an initial charset table that is
992 just under 64 KiB, to avoid problems with glibc malloc and mmap.
993
994 * cmds.c (internal_self_insert): Check for size-calculation overflow.
995
996 * composite.h (struct composition.glyph_len): Now int, not unsigned.
997 The actual value is always <= INT_MAX, and leaving it unsigned made
998 overflow checking harder.
999
1000 * dispextern.h (struct glyph_matrix.rows_allocated)
1001 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1002 with xpalloc. The values are still always <= INT_MAX.
1003
1004 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1005
1006 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1007 (SAFE_NALLOCA): New macro.
1008
1009 * region-cache.c (struct boundary.pos, find_cache_boundary)
1010 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1011 (set_cache_region, invalidate_region_cache)
1012 (revalidate_region_cache, know_region_cache, region_cache_forward)
1013 (region_cache_backward, pp_cache):
1014 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1015 so that ptrdiff_t * can be passed to xpalloc.
1016 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1017 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1018 (pp_cache): Don't assume cache_len fits in int.
1019 * region-cache.h: Adjust extern decls to match.
1020
1021 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1022 EMACS_INT, since either will do, for xpalloc.
1023
1024 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1025 (xnmalloc, xnrealloc, xpalloc): New functions.
1026
726e0ab1
PE
1027 * bidi.c (bidi_shelve_header_size): New constant.
1028 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1029 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1030
51f30bc5 1031 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
1032 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1033 (overlay_strings):
1034 Don't update size of array until after memory allocation succeeds,
1035 because xmalloc/xrealloc may not return.
0065d054
PE
1036 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1037 now that we have proper integer overflow checking.
1038 (record_overlay_string, overlay_strings): Catch overflows when
1039 calculating size of overlay_str_buf.
726e0ab1 1040
0065d054
PE
1041 * callproc.c (Fcall_process): Check for size overflow when
1042 calculating size of args2.
1043 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1044 Normally we prefer signed values, but sticking with ptrdiff_t would
1045 require adding more-complicated checks.
726e0ab1
PE
1046
1047 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1048 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1049 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 1050 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
1051
1052 * character.c (Fstring): Check for size-calculation overflow.
1053
1054 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1055 unnecessary integer overflow. Check for size overflow.
1056 (encode_coding_object): Don't update size until xmalloc succeeds.
1057
1058 * composite.c (get_composition_id): Check for overflow in glyph
1059 length calculations.
1060
1061 Integer and memory overflow fixes for display code.
1062 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1063 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1064 (scrolling_window): Check for overflow in size calculations.
1065 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1066 Don't assume glyph table len fits in int.
1067 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1068 (row_table_size): Now ptrdiff_t, not int.
1069 (scrolling_window): Avoid overflow in size calculations.
1070 Don't update size until allocation succeeds.
1071 * fns.c (concat): Check for overflow in size calculations.
1072 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1073 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1074 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1075
1076 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1077 (get_doc_string): Check for size calculation overflow.
1078 Don't update size until allocation succeeds.
1079 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1080 EMACS_INT, where ptrdiff_t will do.
1081 (Fsubstitute_command_keys): Check for string overflow.
1082
1083 * editfns.c (set_time_zone_rule): Don't assume environment length
1084 fits in int.
1085 (message_length): Now ptrdiff_t, not int.
1086 (Fmessage_box): Don't update size until allocation succeeds.
1087 Don't assume message length fits in int.
1088 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1089
0065d054
PE
1090 * emacs.c (main): Do not reallocate argv, since there is a null at
1091 the end that can be overwritten, and this way there's no need to
1092 worry about size-calculation overflow.
1093 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
1094
1095 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1096 alloc succeeds.
1097 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1098
1099 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1100 (x_set_scroll_bar_width, x_figure_window_size):
1101 Check for integer overflow.
1102 (x_set_alpha): Do not assume XINT fits in int.
1103
1104 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1105 This is for the members text_lines, text_cols, total_lines, total_cols,
1106 where the system imposes an 'int' limit.
1107
1108 * fringe.c (Fdefine_fringe_bitmap):
1109 Don't update size until alloc works.
1110
1111 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1112 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1113
1114 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1115 Check for size-calculation overflow.
1116 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1117 do, as we prefer signed integers.
1118 (id_to_widget.max_size, id_to_widget.used)
1119 (xg_store_widget_in_map, xg_remove_widget_from_map)
1120 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1121 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1122 Use and return ptrdiff_t, not int.
1123 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1124 * gtkutil.h: Change prototypes to match the above.
1125
1126 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1127 are duplicate now that they've been promoted to lisp.h.
1128 (x_allocate_bitmap_record, x_alloc_image_color)
1129 (make_image_cache, cache_image, xpm_load):
1130 Don't update size until alloc is done.
1131 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1132 (x_detect_edges):
3256efce 1133 Check for size calculation overflow.
726e0ab1
PE
1134 (ct_colors_allocated_max): New constant.
1135 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1136 overflow.
3256efce 1137
726e0ab1
PE
1138 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1139 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1140 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1141 Use ptrdiff_t, not int, to count maps.
1142 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
1143 calculations. Don't update size until allocation succeeds.
1144 Redo calculations to avoid overflow.
726e0ab1
PE
1145 * keyboard.h: Change prototypes to match the above.
1146
1147 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1148 to count maps.
1149 (current_minor_maps): Check for size calculation overflow.
1150 * keymap.h: Change prototypes to match the above.
1151
1152 * lread.c (read1, init_obarray): Don't update size until alloc done.
1153
1154 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1155 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1156
726e0ab1
PE
1157 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1158 Now ptrdiff_t, not int.
1159 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1160 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1161
1162 * process.c (Fnetwork_interface_list): Check for overflow
1163 in size calculation.
1164
1165 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1166
1167 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1168 overflow. Don't bother calling xmalloc when xrealloc will do.
1169
1170 * search.c (Freplace_match): Check for size calculation overflow.
1171 (Fset_match_data): Don't assume list lengths fit in 'int'.
1172
1173 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1174 for command line length. Do not attempt to address one before the
1175 beginning of an array, as that's not portable.
1176
1177 * term.c (max_frame_lines): Remove; unused.
1178 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1179 not int.
1180 (encode_terminal_code, calculate_costs): Check for size
1181 calculation overflow.
1182 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1183 table lengths and related sizes. Don't update size until alloc
1184 done. Redo calculations to avoid overflow.
1185 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1186
1187 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1188 subtracting pointers.
1189 (gobble_line): Check for overflow more carefully. Don't update size
1190 until alloc done.
1191
1192 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1193 Don't update size until alloc done.
1194 Redo size calculations to avoid overflow.
1195 Check for size calculation overflow.
0065d054 1196 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
1197
1198 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1199 Use ptrdiff_t, not int, for sizes.
1200 (store_mode_line_noprop_char): Don't update size until alloc done.
1201
0065d054
PE
1202 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1203 Use ptrdiff_t, not int, for sizes.
1204 (Finternal_make_lisp_face, cache_face):
1205 Check for size calculation overflow.
1206 (cache_face): Treat size calculation overflows as if they were
1207 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
1208
1209 * xfns.c (x_encode_text, x_set_name_internal)
1210 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1211 sizes, since they can exceed INT_MAX in size. Check for size
1212 calculation overflow.
1213
0065d054
PE
1214 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1215 (xg_select): Check for size calculation overflow.
726e0ab1
PE
1216 Don't update size until alloc done.
1217
0065d054 1218 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 1219 as sprintf is limited to int lengths.
1d526e2f 1220
252c5ee1
PE
1221 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1222 (X_LONG_MIN): New macros.
864d7ce7
PE
1223 Use them to make the following changes clearer.
1224 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1225 This change doesn't affect the value now, but it may help remind
1226 future maintainers not to raise the value too much later.
1227 (SELECTION_QUANTUM): Remove, replacing with ...
1228 (selection_quantum): ... new function, which avoids overflow.
1229 All uses changed.
1230 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1231 assumption that selection length fits in 'int'.
1232 (x_reply_selection_request, x_handle_selection_request)
1233 (x_get_window_property, receive_incremental_selection)
1234 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1235 (lisp_data_to_selection_data, clean_local_selection_data):
1236 Use ptrdiff_t, not int, to record length of selection.
1237 (x_reply_selection_request, x_get_window_property)
1238 (receive_incremental_selection, x_property_data_to_lisp):
1239 Redo calculations to avoid overflow.
1240 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 1241 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
1242 something.
1243 (x_get_window_property, receive_incremental_selection)
1244 (lisp_data_to_selection_data, x_property_data_to_lisp):
1245 Check for size-calculation overflow.
1246 (x_get_window_property, receive_incremental_selection)
1247 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1248 Don't store size until memory allocation succeeds.
1249 (x_get_window_property): Plug memory leak on memory exhaustion.
1250 Don't double-block input; malloc is safe here. Don't assume 2**34
1251 - 4 fits in unsigned long. Add an xassert to check
1252 XGetWindowProperty overflow. Be more careful about overflow
1253 calculations, and distinguish size from memory overflow better.
1254 (receive_incremental_selection): When tracing, don't assume
1255 unsigned int is less than INT_MAX.
1256 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1257 harmful) conversions of unsigned short to int.
1258 (lisp_data_to_selection_data): Don't assume that integers
1259 in the range -65535 through -1 fit in an X unsigned short.
1260 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1261 result parameters unless successful. Rely on cons_to_unsigned
1262 to report problems with elements; the old code wasn't right anyway.
1263 (x_check_property_data): Check for int overflow; we cannot use
1264 a wider type due to X limits.
1265 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1266
726e0ab1 1267 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 1268
0065d054
PE
1269 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1270 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
1271 (x_color_cells): Don't store size until memory allocation succeeds.
1272 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 1273 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
1274 (x_term_init): Don't assume length fits in int (sprintf is limited
1275 to int size).
bc18e09d 1276
ebfa62c0
PE
1277 Use ptrdiff_t for composition IDs.
1278 * character.c (lisp_string_width):
1279 * composite.c (composition_table_size, n_compositions)
1280 (get_composition_id, composition_gstring_from_id):
1281 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1282 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1283 * window.c (Frecenter):
1284 Use ptrdiff_t, not int, for composition IDs.
1285 * composite.c (get_composition_id): Check for integer overflow.
1286 * composite.h: Adjust prototypes to match the above changes.
1287
d3411f89
PE
1288 Use ptrdiff_t for hash table indexes.
1289 * category.c (hash_get_category_set):
1290 * ccl.c (ccl_driver):
1291 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1292 * coding.c (coding_system_charset_list, detect_coding_system):
1293 * coding.h (struct coding_system.id):
1294 * composite.c (get_composition_id, gstring_lookup_cache):
1295 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1296 * image.c (xpm_get_color_table_h):
1297 * lisp.h (hash_lookup, hash_put):
1298 * minibuf.c (Ftest_completion):
1299 Use ptrdiff_t for hash table indexes, not int (which is too
1300 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1301 32-bit --with-wide-int hosts).
1302
e097a6fa
PE
1303 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1304 Add a FIXME comment about memory leaks.
1305 (syms_of_charset): Don't assume xmalloc returns.
1306
5637687f
PE
1307 Don't assume that stated character widths fit in int.
1308 * character.c (Fchar_width, c_string_width, lisp_string_width):
1309 * character.h (CHAR_WIDTH):
1310 * indent.c (MULTIBYTE_BYTES_WIDTH):
1311 Use sanitize_char_width to avoid undefined and/or bad behavior
1312 with outlandish widths.
a66cfb1c 1313 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
1314 now that we have two such functions. All uses changed.
1315 (sanitize_char_width): New inline function.
1316
a2271ba2
PE
1317 Don't assume that tab-width fits in int.
1318 * character.h (sanitize_width): New inline function.
1319 (SANE_TAB_WIDTH): New macro.
1320 (ASCII_CHAR_WIDTH): Use it.
1321 * indent.c (sane_tab_width): Remove. All uses replaced by
1322 SANE_TAB_WIDTH (current_buffer).
1323 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1324
18c52557
PE
1325 * fileio.c: Integer overflow issues with file modes.
1326 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1327
caeeedc1
PE
1328 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1329 Remove unreachable code.
1330 (read_hex, load_charset_map_from_file): Check for integer overflow.
1331
50849c52
PE
1332 * xterm.c: don't go over XClientMessageEvent limit
1333 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1334 (x_send_scroll_bar_event): Likewise. Check that the size does not
1335 exceed limits imposed by XClientMessageEvent, as well as the usual
1336 ptrdiff_t and size_t limits.
1337
b13995db
PE
1338 * keyboard.c: Overflow, signedness and related fixes.
1339 (make_lispy_movement): Use same integer type in forward decl
1340 that is used in the definition.
1341 (read_key_sequence, keyremap_step):
1342 Change bufsize argument back to int, undoing my 2011-03-30 change.
1343 We prefer signed types, and int is wide enough here.
1344 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1345 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1346 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1347 length, not size_t. Use ptrdiff_t for index, not int.
1348 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1349 possibility of integer overflow.
1350
13464394
PE
1351 Overflow, signedness and related fixes for images.
1352
1353 * dispextern.h (struct it.stack[0].u.image.image_id)
1354 (struct_it.image_id, struct image.id, struct image_cache.size)
1355 (struct image_cache.used, struct image_cache.ref_count):
1356 * gtkutil.c (update_frame_tool_bar):
1357 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1358 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1359 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1360 * nsmenu.m (update_frame_tool_bar):
1361 * xdisp.c (calc_pixel_width_or_height):
1362 * xfns.c (image_cache_refcount):
1363 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1364 on typical 64-bit hosts.
1365
1366 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1367 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1368 Omit unnecessary casts to int.
1369 (parse_image_spec): Check that integers fall into 'int' range
1370 when the callers expect that.
1371 (image_ascent): Redo ascent calculation to avoid int overflow.
1372 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1373 (lookup_image): Remove unnecessary tests.
1374 (xbm_image_p): Locals are now of int, not EMACS_INT,
1375 since parse_image_check makes sure they fit into int.
1376 (png_load, gif_load, svg_load_image):
1377 Prefer int to unsigned where either will do.
1378 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
1379 old tiff_error_handler and tiff_warning_handler.
1380 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
1381 stack buffer overflows. It uses only the features of vsnprintf
1382 that are common to both POSIX and native Microsoft.
1383 (tiff_error_handler, tiff_warning_handler): Use it.
1384 (tiff_load, gif_load, imagemagick_load_image):
1385 Don't assume :index value fits in 'int'.
1386 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1387 (imagemagick_load_image): Check that crop parameters fit into
1388 the integer types that MagickCropImage accepts. Don't assume
1389 Vimagemagick_render_type has a nonnegative value. Don't assume
1390 size_t fits in 'long'.
1391 (gs_load): Use printmax_t to print the widest integers possible.
1392 Check for integer overflow when computing image height and width.
1393
c11821d4
EZ
13942011-08-26 Eli Zaretskii <eliz@gnu.org>
1395
1396 * xdisp.c (redisplay_window): Don't force window start if point
1397 will be invisible in the resulting window. (Bug#9324)
1398
0c95fcf7
EZ
13992011-08-25 Eli Zaretskii <eliz@gnu.org>
1400
1401 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1402 the display spec is of the form `(space ...)'.
1403 (handle_display_spec): Return the value returned by
1404 handle_single_display_spec, not just 1 or zero.
1405 (handle_single_display_spec): If the display spec is of the form
1406 `(space ...)', and specifies display in the text area, return 2
1407 rather than 1.
fee65a97 1408 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
1409 accurately, and prefer exact match for point under bidi.
1410 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
1411
1412 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1413 into disp_prop; all users changed.
1414
1415 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1416 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1417 for the text covered by the display property.
1418
e4ed06f1
CY
14192011-08-25 Chong Yidong <cyd@stupidchicken.com>
1420
1421 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1422 Change return value to nil.
1423 (Frecord_buffer): Delete unused function.
1424
f67cdd7f
EZ
14252011-08-24 Eli Zaretskii <eliz@gnu.org>
1426
5980d4c6
EZ
1427 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1428 buffers, return left-to-right.
8610fe8b
EZ
1429 (set_cursor_from_row): Consider candidate row a win if its glyph
1430 represents a newline and point is on that newline. Fixes cursor
1431 positioning on the newline at EOL of R2L text within L2R
1432 paragraph, and vice versa.
1433 (try_cursor_movement): Check continued rows, in addition to
1434 continuation rows. Fixes unwarranted scroll when point enters a
1435 continued line of R2L text within an L2R paragraph, or vice versa.
1436 (cursor_row_p): Consider the case of point being equal to
1437 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1438 from the end of a short line to the beginning of a continued line
1439 of R2L text within L2R paragraph.
1440 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1441 composed characters.
5980d4c6 1442
f67cdd7f
EZ
1443 * bidi.c (bidi_check_type): Use xassert.
1444 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1445 members.
1446
bca633fb
EZ
14472011-08-23 Eli Zaretskii <eliz@gnu.org>
1448
1449 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1450 a character.
1451
4a5885a7
CY
14522011-08-23 Chong Yidong <cyd@stupidchicken.com>
1453
1454 * nsfont.m (ns_otf_to_script): Fix typo.
1455
0902a04e
KH
14562011-08-22 Kenichi Handa <handa@m17n.org>
1457
1458 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1459 extra slot even if the purpose is char-code-property-table.
1460
1a2e6670
EZ
14612011-08-23 Eli Zaretskii <eliz@gnu.org>
1462
8ddde651
EZ
1463 * xdisp.c (redisplay_window): When computing centering_position,
1464 account for the height of the header line. (Bug#8874)
1465
425cc014
EZ
1466 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1467 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1468 candidate is selected by the mouse, and that candidate has a
1469 composed character under the mouse.
1470
1a2e6670
EZ
1471 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1472 coordinates reported by pos-visible-in-window-p for a composed
1473 character in column zero.
1474
8b76d6f8
SM
14752011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1476
1477 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1478
dac347dd
EZ
14792011-08-22 Eli Zaretskii <eliz@gnu.org>
1480
1481 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1482 consider it a hit if to_charpos is anywhere in the range of the
1483 composed buffer positions.
1484
e013fb34
CY
14852011-08-22 Chong Yidong <cyd@stupidchicken.com>
1486
1487 * image.c (gif_load): Don't assume that each subimage has the same
1488 dimensions as the base image. Handle disposal method that is
1489 "undefined" by the gif spec (Bug#9335).
1490
bd1ba3e8
CY
14912011-08-20 Chong Yidong <cyd@stupidchicken.com>
1492
1493 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 1494 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 1495
54a1215b
EZ
14962011-08-19 Eli Zaretskii <eliz@gnu.org>
1497
823564e5
EZ
1498 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1499 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1500 from an Org mode buffer to a Speedbar frame.
1501
54a1215b
EZ
1502 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1503 a composition, take its buffer position from IT->cmp_it.charpos.
1504 Fixes cursor positioning at the beginning of a line that begins
1505 with a composed character.
1506
9778ebcc
EZ
15072011-08-18 Eli Zaretskii <eliz@gnu.org>
1508
0be6ee06
EZ
1509 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1510 character bidirectional type, use STRONG_L instead. Fixes crashes
1511 in a buffer produced by `describe-categories'.
1512
9778ebcc
EZ
1513 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1514 members before the level stack, so they would be saved and
1515 restored when copying iterator state. Fixes incorrect reordering
1516 around TABs covered by display properties.
1517
156bffbe
AS
15182011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1519
6b02f655 1520 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 1521
72ad093b
CY
15222011-08-17 Chong Yidong <cyd@stupidchicken.com>
1523
1524 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
1525 (internal_condition_case_2, internal_condition_case_n):
1526 Remove unnecessary aborts (Bug#9081).
72ad093b 1527
35774242
EZ
15282011-08-17 Eli Zaretskii <eliz@gnu.org>
1529
1530 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1531 has no `load' handler, try opening the file locally. (Bug#9311)
1532
db76dd85
KB
15332011-08-16 Ken Brown <kbrown@cornell.edu>
1534
1535 * gmalloc.c: Expand comment.
1536
b215eee5
EZ
15372011-08-16 Eli Zaretskii <eliz@gnu.org>
1538
1539 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1540 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1541
a4579d33
KB
15422011-08-16 Ken Brown <kbrown@cornell.edu>
1543
1544 Fix memory allocation problems in Cygwin build (Bug#9273).
1545
1546 * unexcw.c ( __malloc_initialized): Declare external variable.
1547 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1548
8b76d6f8
SM
1549 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1550 New variables.
a4579d33
KB
1551 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1552 dumped emacs.
1553 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1554 in the static heap.
1555 [CYGWIN] (special_realloc): New function.
1556 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1557 requests to realloc storage in the static heap.
1558
3ebec551
PE
15592011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1560
1561 * bidi.c (bidi_initialize): Remove unused local.
1562
9fd8be00
EZ
15632011-08-15 Eli Zaretskii <eliz@gnu.org>
1564
6b02f655
SM
1565 * bidimirror.h:
1566 * biditype.h: Remove file.
1567 * makefile.w32-in ($(BLD)/bidi.$(O)):
1568 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
1569
1570 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1571
1572 * chartab.c: Improve commentary for the uniprop_table API.
1573
32413314
EZ
1574 * bidi.c (bidi_paragraph_init): Support zero value of
1575 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
1576 (bidi_initialize): Use uniprop_table instead of including
1577 biditype.h and bidimirror.h.
32413314 1578
9fd8be00
EZ
1579 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1580 coordinates of the iterator when restoring from ppos_it.
1581 (Bug#9296)
1582
5cf2b69b
KH
15832011-08-14 Kenichi Handa <handa@m17n.org>
1584
1585 * process.c (create_process): Call setup_process_coding_systems
72ad093b 1586 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 1587
daf17d00
EZ
15882011-08-14 Eli Zaretskii <eliz@gnu.org>
1589
1590 * xdisp.c (move_it_in_display_line_to): Don't invoke
1591 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1592 ppos_it. Fixes vertical cursor motion when line beginning is
1593 covered by an image. (Bug#9296)
1594
08e3161a
JD
15952011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1596
1597 * nsterm.h (ns_run_ascript): Declare.
1598 (NSAPP_DATA2_RUNASSCRIPT): Define.
1599
1600 * nsfns.m (as_script, as_result, as_status): New static variables.
1601 (ns_run_ascript): New function.
5e617bc2 1602 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
1603 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1604 the event loop. Get status from as_status (Bug#7276).
1605
1606 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1607 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1608 the event loop (Bug#7276).
1609
a3720aa2
AS
16102011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1611
1612 * gnutls.c (QCgnutls_bootprop_priority)
1613 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1614 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1615 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1616 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1617 (QCgnutls_bootprop_verify_hostname_error)
1618 (QCgnutls_bootprop_callbacks_verify): Rename from
1619 Qgnutls_bootprop_..., all uses changed.
1620
1621 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1622 uses changed.
1623
0a0d27fb
PE
16242011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1625
19d5c50c
PE
1626 * xfaces.c (Qframe_set_background_mode): Now static.
1627 * dispextern.h (Qframe_set_background_mode): Remove decl.
1628
0a0d27fb
PE
1629 * process.c (Fnetwork_interface_info): Declare local only if needed.
1630
377538cb
JD
16312011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1632
1633 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1634 (Fnetwork_interface_list): Allocate in increments of bytes instead
1635 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1636 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1637 sockaddr.
1638 (struct ifflag_def): notrailers is smart on OSX.
1639 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1640 Get hardware address with getifaddrs if available.
1641
08fff70c
EZ
16422011-08-12 Eli Zaretskii <eliz@gnu.org>
1643
1644 * xdisp.c (iterate_out_of_display_property): xassert that
1645 IT->position is set to within IT->object's boundaries. Break from
1646 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
1647 when IT->position is set up wrongly due to some bug.
1648 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
1649 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1650 entry. Force push_it to save on the stack the current
1651 buffer/string position, to be restored by pop_it. Fix flags in
1652 the iterator structure wrt the object coming from a display
1653 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1654 properties. (Bug#9284)
1655
7be1c708 16562011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 1657
7be1c708
CY
1658 * fontset.c (fontset_get_font_group): Add proper type checks.
1659 (Bug#9172)
aac0c6e3 1660
7be1c708 16612011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 1662
7be1c708
CY
1663 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1664 and LC_VERSION_MIN_MACOSX.
1665 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1666 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 1667
97bb72a6
EZ
16682011-08-08 Eli Zaretskii <eliz@gnu.org>
1669
1670 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
1671 no-display-properties-and-no-overlays under bidi display.
1672 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 1673 properties and overlays.
97bb72a6 1674
d5617611
CY
16752011-08-08 Chong Yidong <cyd@stupidchicken.com>
1676
37e11a63
CY
1677 * editfns.c (Fset_time_zone_rule): Document relationship with the
1678 setenv function.
1679
d5617611
CY
1680 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1681 the font entity extracted from the cache (Bug#8109).
1682
58872834
CY
16832011-08-07 Chong Yidong <cyd@stupidchicken.com>
1684
1685 * composite.c (autocmp_chars): Don't reset point. That is done by
1686 restore_point_unwind (Bug#5984).
1687
75bfc667
JL
16882011-08-07 Juri Linkov <juri@jurta.org>
1689
1690 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1691 to show the arg `TIME' instead of `TIMEVAL'.
1692
d1410150
EZ
16932011-08-06 Eli Zaretskii <eliz@gnu.org>
1694
1695 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1696 display property strides EOL and includes a newline, as in
1697 longlines-mode. (Bug#9254)
75b771e4
EZ
1698 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1699 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
1700
1701 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1702 is non-zero, even if the data buffer is NULL. Fixes a crash in
1703 vertical-motion with longlines-mode. (Bug#9254)
1704
35928349
EZ
17052011-08-05 Eli Zaretskii <eliz@gnu.org>
1706
ec7cc85b
EZ
1707 * bidi.c <bidi_cache_total_alloc>: Now static.
1708 (bidi_initialize): Initialize bidi_cache_total_alloc.
1709
8b76d6f8 1710 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
1711 cache. (Bug#9221)
1712
1713 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1714 amount allocated this far in `bidi_cache_total_alloc'.
1715 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1716 non-zero, only free the data buffer without restoring the cache
1717 contents. All callers changed.
1718
1719 * dispextern.h (bidi_unshelve_cache): Update prototype.
1720
1721 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1722 (move_it_in_display_line, move_it_to)
1723 (move_it_vertically_backward, move_it_by_lines): Replace the call
1724 to xfree to an equivalent call to bidi_unshelve_cache.
1725 (move_it_in_display_line_to): Fix logic of returning
412b6358 1726 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 1727
e2e2423b
EZ
17282011-08-05 Eli Zaretskii <eliz@gnu.org>
1729
1730 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1731 came from a string character with a `cursor' property. (Bug#9229)
1732
ae9e757a
JD
17332011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1734
1735 * Makefile.in (LIB_PTHREAD): New variable.
1736 (LIBES): Add LIB_PTHREAD (Bug#9216).
1737
1738 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1739 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1740
213bd7f2
AS
17412011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1742
6b02f655 1743 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 1744
99aaf75f
JD
17452011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1746
1747 * xterm.c (x_find_topmost_parent): New function.
1748 (x_set_frame_alpha): Find topmost parent window with
1749 x_find_topmost_parent and set the property there also (bug#9181).
1750 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1751
c74e9d86
PE
17522011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1753
1754 * callproc.c (Fcall_process): Avoid vfork clobbering
1755 the local vars buffer, coding_systems, current_dir.
1756
640c8776
SM
17572011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1758
1759 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1760
f26d0e4c
PE
17612011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1762
8a10d76c
PE
1763 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1764 so that it is not optimized away.
1765
f26d0e4c
PE
1766 * xdisp.c (compute_display_string_pos): Remove unused local.
1767
55439c61
EZ
17682011-08-02 Eli Zaretskii <eliz@gnu.org>
1769
1770 Fix slow cursor motion and scrolling in large buffers with
1771 selective display, like Org Mode buffers. (Bug#9218)
1772
1773 * dispextern.h (struct bidi_it): New member disp_prop_p.
1774
1775 * xdisp.c: Remove one-slot cache of display string positions.
1776 (compute_display_string_pos): Accept an additional argument
5e617bc2 1777 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
1778 for a display string or property. If found, set DISP_PROP_P
1779 non-zero.
1780
1781 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
1782 DISP_PROP_P, and pass it to compute_display_string_pos.
1783 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
1784 non-zero. All callers of bidi_fetch_char changed.
1785
fb33fa43
SM
17862011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1787
1788 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1789
b099e063
DM
17902010-12-03 Don March <don@ohspite.net>
1791
1792 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1793 last character M-[char] is translated to ESC [char] (bug#7541).
1794
5cc7f7af
KH
17952011-08-02 Kenichi Handa <handa@m17n.org>
1796
d0fffa3f 1797 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
1798
1799 * chartab.c (uniprop_table): Make it non-static.
1800
525d5e6e
EZ
18012011-08-01 Eli Zaretskii <eliz@gnu.org>
1802
1803 * xdisp.c (forward_to_next_line_start): Accept additional argument
1804 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1805 on the newline.
1806 (reseat_at_next_visible_line_start): Use the bidi iterator state
1807 returned by forward_to_next_line_start to restore the state of
1808 it->bidi_it after backing up to previous newline. (Bug#9212)
1809
31011111
AS
18102011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1811
1812 * regex.c (re_comp): Protoize.
1813 (re_exec): Fix return type.
1814 (regexec): Fix type of `ret'. (Bug#9203)
1815
476371c4
PE
18162011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1817
e5d76069
PE
1818 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1819 This is needed if max-image-size is a floating-point number.
1820
9a79b20c
AS
18212011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1822
1823 * print.c (print_object): Print empty symbol as ##.
1824
1825 * lread.c (read1): Read ## as empty symbol.
1826
d8c2fa78
AA
18272011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1828
1829 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1830 setting frame foreground color (Bug#9175).
1831 (x_set_background_color): Likewise.
1832
ffe57a7a
AA
1833 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1834 contents (Bug#9176).
1835 (EmacsTooltip -init): Remove bezels and add shadows to
1836 tooltip windows.
1837
bf3492a5
AA
1838 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1839 or scroll bar (Bug#8470).
1840
d55e9c53
AA
1841 * nsfont.m (nsfont_open): Remove assignment to voffset and
1842 unnecessary vars hshink, expand, hd, full_height, min_height.
1843 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1844
1845 * nsterm.h (nsfont_info): Remove voffset field.
1846
d8c2fa78 18472011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
1848
1849 Implement strike-through and overline on NextStep (Bug#8863).
1850
1851 * nsfont.m (nsfont_open): Use underline position provided by font,
1852 instead of hard-coded value of 2.
1853 (nsfont_draw): Call ns_draw_text_decoration instead.
1854
1855 * nsterm.h: Add declaration for ns_draw_text_decoration.
1856
1857 * nsterm.m (ns_draw_text_decoration): New function for drawing
1858 underline, overline, and strike-through.
1859 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1860 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 1861 accommodate underlining, etc.
4843aac3 1862
4cc60b9b
EZ
18632011-07-28 Eli Zaretskii <eliz@gnu.org>
1864
bc7ece87
EZ
1865 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1866 default.
4cc60b9b 1867
476371c4
PE
18682011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1869
66606eea
PE
1870 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1871 Without this fix, if a signal arrives just after memory fills up,
1872 'malloc' might be invoked reentrantly.
1873
476371c4
PE
1874 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1875 In other words, assume that every image size is allowed, on non-X
1876 hosts. This assumption is probably wrong, but it lets Emacs compile.
1877
f3fcc40d
AS
18782011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1879
1880 * regex.c (re_iswctype): Convert return values to boolean.
1881
350c992f
EZ
18822011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1883
1884 * xdisp.c (compute_display_string_pos): Don't use cached display
1885 string position if the buffer had its restriction changed.
1886 (Bug#9184)
1887
5266b4bb
PE
18882011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1889
1890 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1891
2573a837 18922011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 1893
41f55ccd 1894 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 1895
39e378da
PE
1896 * bidi.c: Integer size and overflow fixes.
1897 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1898 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1899 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1900 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1901 (bidi_find_other_level_edge):
1902 Use ptrdiff_t instead of EMACS_INT where either will do.
1903 This works better on 32-bit hosts configured --with-wide-int.
1904 (bidi_cache_ensure_space): Check for size-calculation overflow.
1905 Use % rather than repeated addition, for better worst-case speed.
1906 Don't set bidi_cache_size until after xrealloc returns, because it
1907 might not return.
1908 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
1909 (bidi_cache_ensure_space): Also check that the bidi cache size
1910 does not exceed that of the largest Lisp string or buffer. See Eli
1911 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 1912
5e927815
PE
1913 * alloc.c (__malloc_size_t): Remove.
1914 All uses replaced by size_t. See Andreas Schwab's note
1915 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1916
ca4aa935
PE
1917 * image.c: Improve checking for integer overflow.
1918 (check_image_size): Assume that f is nonnull, since
1919 it is always nonnull in practice. This is one less thing to
1920 worry about when checking for integer overflow later.
1921 (x_check_image_size): New function, which checks for integer
1922 overflow issues inside X.
1923 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1924 This removes the need for a memory_full check.
1925 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1926 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1927 (xbm_read_bitmap_data): Change locals back to 'int', since
1928 their values must fit in 'int'.
1929 (xpm_load_image, png_load, tiff_load):
1930 Invoke x_create_x_image_and_pixmap earlier,
1931 to avoid much needless work if the image is too large.
1932 (tiff_load): Treat overly large images as if
1933 x_create_x_image_and_pixmap failed, not as malloc failures.
1934 (gs_load): Use x_check_image_size.
1935
5f8f9cc2
PE
1936 * gtkutil.c: Omit integer casts.
1937 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1938 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1939
5adf60bc
PE
1940 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1941
c8907a93
PE
1942 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1943 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1944 would wrongly return t on a 64-bit host.
1945
e3c25c68
PE
1946 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1947 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1948 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1949 and therefore cause GCC to emit a bogus diagnostic in some cases.
1950
3f791afe
PE
1951 * image.c: Integer signedness and overflow and related fixes.
1952 This is not an exhaustive set of fixes, but it's time to
1953 record what I've got.
1954 (lookup_pixel_color, check_image_size): Remove redundant decls.
1955 (check_image_size): Don't assume that arbitrary EMACS_INT values
1956 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1957 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1958 (tiff_load, imagemagick_load_image):
1959 Check for overflow in size calculations.
1960 (x_create_x_image_and_pixmap): Remove unnecessary test for
1961 xmalloc returning NULL; that can't happen.
1962 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1963 (xpm_color_bucket): Use better integer hashing function.
1964 (xpm_cache_color): Don't possibly over-allocate memory.
1965 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1966 (gif_memory_source):
1967 Use ptrdiff_t, not int or size_t, to record sizes.
1968 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1969 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1970 either works, as we prefer signed integers.
1971 (tiff_read_from_memory, tiff_write_from_memory):
1972 Return tsize_t, not size_t, since that's what the TIFF API wants.
1973 (tiff_read_from_memory): Don't fail simply because the read would
1974 go past EOF; instead, return a short read.
1975 (tiff_load): Omit no-longer-needed casts.
1976 (Fimagemagick_types): Don't assume size fits into 'int'.
1977
3cc5a532
PE
1978 Improve hashing quality when configured --with-wide-int.
1979 * fns.c (hash_string): New function, taken from sxhash_string.
1980 Do not discard information about ASCII character case; this
1981 discarding is no longer needed.
1982 (sxhash-string): Use it. Change sig to match it. Caller changed.
1983 * lisp.h: Declare it.
1984 * lread.c (hash_string): Remove, since we now use fns.c's version.
1985 The fns.c version returns a wider integer if --with-wide-int is
1986 specified, so this should help the quality of the hashing a bit.
1987
b312a492
PE
1988 * emacs.c: Integer overflow minor fix.
1989 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1990 Define only if GNU_LINUX.
1991 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1992
dfd153ae
PE
1993 * dispnew.c: Integer signedness and overflow fixes.
1994 Remove unnecessary forward decls, that were a maintenance hassle.
1995 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1996 All uses changed.
1997 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1998 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1999 (prepare_desired_row, line_draw_cost):
2000 Use int, not unsigned, where either works.
2001 (save_current_matrix, restore_current_matrix):
2002 Use ptrdiff_t, not size_t, where either works.
2003 (init_display): Check for overflow more accurately, and without
2004 relying on undefined behavior.
2005
a81d11a3
PE
2006 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2007 Remove, replacing with the new symbols in lisp.h. All uses changed.
2008 * fileio.c (make_temp_name):
2009 * filelock.c (lock_file_1, lock_file):
2010 * xdisp.c (message_dolog):
2011 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2012 Use pMd etc. instead.
2013 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2014 replacing the pWIDE etc. symbols removed from editfns.c.
2015
3300e6fd
PE
2016 * keyboard.h (num_input_events): Now uintmax_t.
2017 This is (very slightly) less likely to mess up due to wraparound.
2018 All uses changed.
2019
fd05c7e9
PE
2020 * buffer.c: Integer signedness fixes.
2021 (alloc_buffer_text, enlarge_buffer_text):
2022 Use ptrdiff_t rather than size_t when either will do, as we prefer
2023 signed integers.
2024
903fe15d
PE
2025 * alloc.c: Integer signedness and overflow fixes.
2026 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2027 (__malloc_size_t): Default to size_t, not to int.
2028 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2029 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2030 Prefer ptrdiff_t to size_t when either would do, as we prefer
2031 signed integers.
2032 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2033 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2034 Now const. Initialize with values that are in range even if char
2035 is signed.
2036 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2037 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2038 These functions do the right thing with sizes > 2**32.
2039 (check_depth): Now ptrdiff_t, not int.
2040 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2041 Adjust to new way of storing sizes. Check for size overflow bugs
2042 in rest of code.
2043 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2044 slightly wrong anyway, as it missed one instance of
2045 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2046 (refill_memory_reserve): Omit needless cast to size_t.
2047 (mark_object_loop_halt): Mark as externally visible.
2048
ac82cc6a
PE
2049 * xselect.c: Integer signedness and overflow fixes.
2050 (Fx_register_dnd_atom, x_handle_dnd_message):
2051 Use ptrdiff_t, not size_t, since we prefer signed.
2052 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2053 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2054 x_dnd_atoms_size and x_dnd_atoms_length.
2055
c2d1e36d
PE
2056 * doprnt.c: Prefer signed to unsigned when either works.
2057 * eval.c (verror):
2058 * doprnt.c (doprnt):
2059 * lisp.h (doprnt):
2060 * xdisp.c (vmessage):
2061 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2062 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2063 prefer signed arithmetic to avoid comparison confusion.
2064 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2065 but is a bit tricky.
2066
0e926e56
PE
2067 Assume freestanding C89 headers, string.h, stdlib.h.
2068 * data.c, doprnt.c, floatfns.c, print.c:
2069 Include float.h unconditionally.
2070 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2071 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2072 * regex.c: Likewise for stddef.h, string.h.
2073 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2074 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2075 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2076 (STDC_HEADERS): Remove obsolete defines.
2077 * sysdep.c: Include limits.h unconditionally.
2078
9cfdb3ec
PE
2079 Assume support for memcmp, memcpy, memmove, memset.
2080 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2081 * regex.c (memcmp, memcpy):
2082 Remove; we assume C89 now.
2083
2084 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2085 (__malloc_safe_bcopy): Remove; no longer needed.
2086
cf950e6b 2087 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
2088 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2089 well either way, and we prefer signed to unsigned.
2090
dbf38e02
LMI
20912011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2092
2093 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2094 closes the connection while we're reading (bug#9182).
2095
d6f0886c 20962011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 2097
d6f0886c
JD
2098 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2099 are specified (Bug#9168).
24e0f6b1 2100
2eb1f9e6
PE
21012011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2102
2103 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2104 Found by GCC static checking and --with-wide-int on a 32-bit host.
2105
22381272 21062011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
2107
2108 * xdisp.c (compute_display_string_pos): Fix logic of caching
2109 previous display string position. Initialize cached_prev_pos to
2110 -1. Fixes slow-down at the beginning of a buffer.
2111
f25e39b4
EZ
21122011-07-24 Eli Zaretskii <eliz@gnu.org>
2113
2114 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2115 for attrs[LFACE_FONTSET_INDEX].
2116
04c4b52e
PE
21172011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2118
2119 * xml.c (parse_region): Remove unused local
2120 that was recently introduced.
2121
c1734fbd
EZ
21222011-07-23 Eli Zaretskii <eliz@gnu.org>
2123
be18c5a5
EZ
2124 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2125 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2126
c1734fbd
EZ
2127 * xdisp.c (move_it_in_display_line_to): Record the best matching
2128 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
2129 exit if none of the characters scanned was an exact match.
2130 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
2131 when exact match is impossible due to invisible text, and the
2132 lines are truncated.
2133
a258d627
JD
21342011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2135
2136 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2137 for OSX >= 10.7.
2138
b6d5a689
EZ
21392011-07-22 Eli Zaretskii <eliz@gnu.org>
2140
0f74f785
EZ
2141 Fix a significant slow-down of cursor motion with C-n, C-p,
2142 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2143 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 2144 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
2145 (next_element_from_buffer): Call compute_stop_pos_backwards to
2146 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
2147 base_level_stop.
2148 (reseat): Don't look for prev_stop, as that could mean a very long
2149 run.
2150 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2151 <cached_disp_overlay_modiff>: Cache for last found display string
2152 position.
551918c1 2153 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
2154 about the same buffer in the same area of character positions, and
2155 the buffer wasn't changed since the time the display string
2156 position was cached.
551918c1 2157
b2d0c91a
EZ
21582011-07-22 Eli Zaretskii <eliz@gnu.org>
2159
2160 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2161 is an integer, which is important for empty lines. (Bug#9149)
2162
043604ee
CY
21632011-07-22 Chong Yidong <cyd@stupidchicken.com>
2164
2165 * frame.c (Fmodify_frame_parameters): In tty case, update the
2166 default face if necessary (Bug#4238).
2167
da4adb04
CY
21682011-07-21 Chong Yidong <cyd@stupidchicken.com>
2169
2170 * editfns.c (Fstring_to_char): No need to explain what a character
2171 is in the docstring (Bug#6576).
2172
9abd0532
LMI
21732011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2174
2175 * xml.c (parse_region): Make sure we always return a tree.
2176
36881d16
HK
21772011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2178
2179 * xml.c (parse_region): If a document contains only comments,
2180 return that, too.
2181
1e98674d
LMI
21822011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2183
2184 * xml.c (make_dom): Return comments, too.
2185
590bd467
PE
21862011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2187
2188 Port to OpenBSD.
2189 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2190 and the surrounding thread.
2191 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2192 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2193 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2194 timer goes off.
2195 * s/openbsd.h (BROKEN_SIGIO): Define.
2196 * unexelf.c (unexec) [__OpenBSD__]:
2197 Don't update the .mdebug section of the Alpha COFF symbol table.
2198
f41628b2
LMI
21992011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2200
2201 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2202 (bug#8460).
2203
b59b67c5
PE
22042011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2205
15e3a074
PE
2206 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2207 This fixes some race conditions on the permissions of any newly
2208 created file.
2209
41bed37d
PE
2210 * alloc.c (valid_pointer_p): Use pipe, not open.
2211 This fixes some permissions issues when debugging.
2212
b59b67c5
PE
2213 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2214 If fchown fails to set both uid and gid, try to set just gid,
2215 as that is sometimes allowed. Adjust the file's mode to eliminate
2216 setuid or setgid bits that are inappropriate if fchown fails.
2217
925a6be7
SM
22182011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2219
2220 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2221 to compare Lisp_Objects.
2222 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2223 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2224 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2225
52968808
AS
22262011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2227
0a6a104b
AS
2228 * lread.c (read_integer): Unread even EOF character.
2229 (read1): Likewise. Properly record start position of symbol.
2230
52968808
AS
2231 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2232 symbol character follows.
2233
9e381cdd
PE
22342011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2235
2236 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2237 This works around a problem with the previous change to Fcopy_file.
2238 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2239 and without this change, GCC might complain about discarding
2240 fchown's return value.
2241
b5641435
JB
22422011-07-16 Juanma Barranquero <lekktu@gmail.com>
2243
2244 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2245
a8031457
PE
22462011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2247
2248 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2249
dd889327
LMI
22502011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2251
750c33f7
LMI
2252 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2253 it's used from the C level.
2254
dd889327
LMI
2255 * process.c: Use the same condition for POLL_FOR_INPUT in both
2256 keyboard.c and process.c (bug#1858).
2257
87e86684
LM
22582011-07-09 Lawrence Mitchell <wence@gmx.li>
2259
2260 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2261 (Fgnutls_boot): Use it.
2262
64348f40
AS
22632011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2264
2265 * doc.c (Fsubstitute_command_keys): Revert last change.
2266
1d698799
LMI
22672011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2268
f863868c
LMI
2269 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2270 quotes the next character, and doesn't affect other longer
2271 sequences (bug#8935).
2272
1d698799
LMI
2273 * lread.c (syms_of_lread): Clarify that is isn't only
2274 `eval-buffer' and `eval-defun' that's affected by
2275 `lexical-binding' (bug#8460).
2276
aa4b6df6
EZ
22772011-07-15 Eli Zaretskii <eliz@gnu.org>
2278
2279 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 2280 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 2281
5d856da6
PE
22822011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2283
ad6042bb
PE
2284 Fix minor problems found by static checking.
2285 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2286 (elsz): Now a signed constant, not a size_t var. We prefer signed
2287 types to unsigned, to avoid integer comparison confusion. Without
2288 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2289 "cannot optimize loop, the loop counter may overflow", a symptom
2290 of the confusion.
f00bbb22 2291 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
2292 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2293
6468f31c
LMI
22942011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2295
49080b10
LMI
2296 * search.c (Fre_search_backward): Mention `case-fold-search' in
2297 all the re_search_* functions (bug#8138).
2298
6468f31c
LMI
2299 * keyboard.c (Fopen_dribble_file): Document when the file is
2300 closed (bug#8056).
2301
c965adc5
EZ
23022011-07-14 Eli Zaretskii <eliz@gnu.org>
2303
df9733bf
EZ
2304 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2305 bidi_cache_idx.
2306
0bb23927
EZ
2307 Support bidi reordering of display and overlay strings.
2308 * xdisp.c (compute_display_string_pos)
2309 (compute_display_string_end): Accept additional argument STRING.
2310 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2311 (reseat_to_string): Initialize bidi_it->string.s and
2312 bidi_it->string.schars.
2313 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
2314 NULL (avoids a crash in bidi_paragraph_init).
2315 Initialize itb.string.lstring.
0bb23927
EZ
2316 (init_iterator): Call bidi_init_it only of a valid
2317 buffer position was specified. Initialize paragraph_embedding to
2318 L2R.
2319 (reseat_to_string): Initialize the bidi iterator.
2320 (display_string): If we need to ignore text properties of
2321 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2322 original value of -1 will not work with bidi.)
2323 (compute_display_string_pos): First arg is now struct
2324 `text_pos *'; all callers changed. Support display properties on
2325 Lisp strings.
2326 (compute_display_string_end): Support display properties on Lisp
2327 strings.
2328 (init_iterator, reseat_1, reseat_to_string): Initialize the
2329 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2330 when iterating on a string not from display properties).
640c8776
SM
2331 (compute_display_string_pos, compute_display_string_end):
2332 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
2333 arrow keys.
2334 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
2335 base_level_stop; instead, set base_level_stop to BEGV.
2336 Fixes crashes in vertical-motion.
0bb23927
EZ
2337 (next_element_from_buffer): Improve commentary for when
2338 the iterator is before prev_stop.
2339 (init_iterator): Initialize bidi_p from the default value of
2340 bidi-display-reordering, not from buffer-local value. Use the
2341 buffer-local value only if initializing for buffer iteration.
2342 (handle_invisible_prop): Support invisible properties on strings
2343 that are being bidi-reordered.
2344 (set_iterator_to_next): Support bidi reordering of C strings and
2345 Lisp strings.
2346 (next_element_from_string): Support bidi reordering of Lisp
2347 strings.
2348 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
2349 (display_string): Support display of R2L glyph rows.
2350 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
2351 (init_iterator): Don't initialize it->bidi_p for strings
2352 here.
2353 (reseat_to_string): Initialize it->bidi_p for strings here.
2354 (next_element_from_string, next_element_from_c_string)
2355 (next_element_from_buffer): Add xassert's for correspondence
2356 between IT's object being iterated and it->bidi_it.string
2357 structure.
2358 (face_before_or_after_it_pos): Support bidi iteration.
2359 (next_element_from_c_string): Handle the case of the first string
2360 character that is not the first one in the visual order.
2361 (get_visually_first_element): New function, refactored from common
2362 parts of next_element_from_buffer, next_element_from_string, and
2363 next_element_from_c_string.
2364 (tool_bar_lines_needed, redisplay_tool_bar)
2365 (display_menu_bar): Force left-to-right direction. Add a FIXME
2366 comment for making that be controlled by a user option.
2367 (push_it, pop_it): Save and restore the state of the
2368 bidi iterator. Save and restore the bidi_p flag.
2369 (pop_it): Iterate out of display property for string iteration as
2370 well.
2371 (iterate_out_of_display_property): Support iteration over strings.
2372 (handle_single_display_spec): Set up it->bidi_it for iteration
2373 over a display string, and call bidi_init_it.
2374 (handle_single_display_spec, next_overlay_string)
2375 (get_overlay_strings_1, push_display_prop): Set up the bidi
2376 iterator for displaying display or overlay strings.
2377 (forward_to_next_line_start): Don't use the shortcut if
2378 bidi-iterating.
2379 (back_to_previous_visible_line_start): If handle_display_prop
2380 pushed the iterator stack, restore the internal state of the bidi
2381 iterator by calling bidi_pop_it same number of times.
2382 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2383 and we are bidi-iterating, don't decrement the iterator position;
2384 instead, set the first_elt flag in the bidi iterator, to produce
2385 the same effect.
2386 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2387 (push_display_prop): xassert that we are iterating a buffer.
2388 (push_it, pop_it): Save and restore paragraph_embedding member.
2389 (handle_single_display_spec, next_overlay_string)
2390 (get_overlay_strings_1, reseat_1, reseat_to_string)
2391 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2392 correctly. Don't assume unibyte strings are not bidi-reordered.
2393 (compute_display_string_pos)
2394 (compute_display_string_end): Fix handling the case of C string.
2395 (push_it, pop_it): Save and restore from_disp_prop_p.
2396 (handle_single_display_spec, push_display_prop): Set the
2397 from_disp_prop_p flag.
2398 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2399 (pop_it): Call iterate_out_of_display_property only if we are
2400 popping after iteration over a string that came from a display
2401 property. Fix a typo in popping stretch info. Add an assertion
2402 for verifying that the iterator position is in sync with the bidi
2403 iterator.
2404 (handle_single_display_spec, get_overlay_strings_1)
2405 (push_display_prop): Fix initialization of paragraph direction for
2406 string when that of the parent object is not yet determined.
2407 (reseat_1): Call bidi_init_it to resync the bidi
2408 iterator with IT's position. (Bug#7616)
2409 (find_row_edges): If ROW->start.pos gives position
2410 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2411 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2412 Reset the from_disp_prop_p flag.
2413 (SAVE_IT, RESTORE_IT): New macros.
2414 (pos_visible_p, face_before_or_after_it_pos)
2415 (back_to_previous_visible_line_start)
2416 (move_it_in_display_line_to, move_it_in_display_line)
2417 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2418 (try_scrolling, redisplay_window, display_line): Use them when
2419 saving a temporary copy of the iterator and restoring it back.
2420 (back_to_previous_visible_line_start, reseat_1)
2421 (init_iterator): Empty the bidi cache "stack".
2422 (move_it_in_display_line_to): If iterator ended up at
2423 EOL, but we never saw any buffer positions smaller than
2424 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2425 motion in bidi-reordered lines.
2426 (move_it_in_display_line_to): Record prev_method and prev_pos
2427 immediately before the call to set_iterator_to_next. Fixes cursor
2428 motion in bidi-reordered lines with stretch glyphs and strings
2429 displayed in margins. (Bug#8133) (Bug#8867)
2430 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2431 TO_CHARPOS.
640c8776
SM
2432 (pos_visible_p): Support positions in bidi-reordered lines.
2433 Save and restore bidi cache.
0bb23927
EZ
2434
2435 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2436 (bidi_paragraph_info): Delete unused struct.
2437 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2438 (bidi_cache_start): New variable.
2439 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2440 to zero.
2441 (bidi_cache_fetch_state, bidi_cache_search)
2442 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2443 (bidi_cache_find, bidi_peek_at_next_level)
2444 (bidi_level_of_next_char, bidi_find_other_level_edge)
2445 (bidi_move_to_visually_next): Compare cache index with
2446 bidi_cache_start rather than with zero.
2447 (bidi_fetch_char): Accept new argument STRING; all callers
2448 changed. Support iteration over a string. Support strings with
2449 display properties. Support unibyte strings. Fix the type of
2450 `len' according to what STRING_CHAR_AND_LENGTH expects.
2451 (bidi_paragraph_init, bidi_resolve_explicit_1)
2452 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
2453 (bidi_level_of_next_char, bidi_move_to_visually_next):
2454 Support iteration over a string.
0bb23927
EZ
2455 (bidi_set_sor_type, bidi_resolve_explicit_1)
2456 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2457 can now be zero (for strings); special values 0 and -1 were
2458 changed to -1 and -2, respectively.
2459 (bidi_char_at_pos): New function.
2460 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2461 Call it instead of FETCH_MULTIBYTE_CHAR.
2462 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2463 initialized to valid values.
2464 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2465 values.
2466 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2467 the test for valid cached positions. Fix the logic for looking up
2468 the sentinel state in the cache. GCPRO the Lisp string we are
2469 iterating.
2470 (bidi_push_it, bidi_pop_it): New functions.
2471 (bidi_initialize): Initialize the bidi cache start stack pointer.
2472 (bidi_cache_ensure_space): New function, refactored from part of
2473 bidi_cache_iterator_state. Don't assume the required size is just
2474 one BIDI_CACHE_CHUNK away.
2475 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2476 (bidi_count_bytes, bidi_char_at_pos): New functions.
2477 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2478 always valid if bidi_cache_idx is valid.
2479 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2480 is valid if it's going to be used.
2481 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2482 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
2483 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2484 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
2485 (bidi_find_other_level_edge, bidi_cache_start_stack):
2486 All variables related to cache indices are now EMACS_INT.
c965adc5 2487
0bb23927
EZ
2488 * dispextern.h (struct bidi_string_data): New structure.
2489 (struct bidi_it): New member `string'. Make flag members be 1-bit
2490 fields, and put them last in the struct.
640c8776
SM
2491 (compute_display_string_pos, compute_display_string_end):
2492 Update prototypes.
0bb23927
EZ
2493 (bidi_push_it, bidi_pop_it): Add prototypes.
2494 (struct iterator_stack_entry): New members bidi_p,
2495 paragraph_embedding, and from_disp_prop_p.
2496 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
2497 (bidi_shelve_cache, bidi_unshelve_cache):
2498 Declare prototypes.
0bb23927
EZ
2499
2500 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2501 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2502 and vector-like objects.
2503
2504 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2505 cache around display iteration.
2506
2507 * window.c (Fwindow_end, window_scroll_pixel_based)
2508 (displayed_window_lines, Frecenter): Save and restore the bidi
2509 cache around display iteration.
2510
3bbd2265
LMI
25112011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2512
2513 * editfns.c (Fdelete_region): Clarify the use of the named
2514 parameters (bug#6788).
2515
adc47434
MR
25162011-07-14 Martin Rudalics <rudalics@gmx.at>
2517
2518 * indent.c (Fvertical_motion): Set and restore w->pointm when
2519 saving and restoring the window's buffer (Bug#9006).
2520
837c31f8
LMI
25212011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2522
2523 * editfns.c (Fstring_to_char): Clarify just what is returned
2524 (bug#6576). Text by Eli Zaretskii.
2525
ac389d0c
JB
25262011-07-13 Juanma Barranquero <lekktu@gmail.com>
2527
2528 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2529
0be0ce47
EZ
25302011-07-13 Eli Zaretskii <eliz@gnu.org>
2531
2532 * buffer.c (mmap_find): Fix a typo.
2533
cd18e7e3
JB
25342011-07-13 Johan Bockgård <bojohan@gnu.org>
2535
2536 Fix execution of x selection hooks.
2537 * xselect.c (Qx_lost_selection_functions)
2538 (Qx_sent_selection_functions): New vars.
2539 (syms_of_xselect): DEFSYM them.
2540 (x_handle_selection_request): Pass Qx_sent_selection_functions
2541 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2542 (x_handle_selection_clear,x_clear_frame_selections):
2543 Pass Qx_lost_selection_functions rather than
2544 Vx_lost_selection_functions to Frun_hook_with_args.
2545
47ea7f44
PE
25462011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2547
ac389d0c 2548 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
2549 The old code sometimes used this field without initializing it.
2550
47ea7f44
PE
2551 * alloc.c (gc_sweep): Don't read past end of array.
2552 In theory, the old code could also have corrupted Emacs internals,
2553 though it'd be very unlikely.
2554
bc985c87
AS
25552011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2556
2557 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 2558 argument. (Bug#4026)
bc985c87 2559
0cf34688
LMI
25602011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2561
b3dadd76
LMI
2562 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2563 key" (bug#4257).
2564
0cf34688
LMI
2565 * window.c (Fset_window_start): Doc fix (bug#4199).
2566 (Fset_window_hscroll): Ditto.
2567
270768cd
PE
25682011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2569
077e3dda 2570 Fix minor new problems caught by GCC 4.6.1.
270768cd 2571 * term.c (init_tty): Remove unused local.
490011a6 2572 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 2573 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 2574 not used otherwise.
270768cd 2575
b1f58454
CY
25762011-07-12 Chong Yidong <cyd@stupidchicken.com>
2577
2578 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2579
22b9578d
LMI
25802011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2581
6e70ab07
LMI
2582 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2583 are the mini-buffer and the echo area (bug#3320).
2584
22b9578d
LMI
2585 * term.c (init_tty): Remove support for supdup, c10 and perq
2586 terminals, which are no longer supported (bug#1482).
2587
8974cc9f
JB
25882011-07-10 Johan Bockgård <bojohan@gnu.org>
2589
2590 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2591
a560d974
JD
25922011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2593
2594 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2595 for non-popups (Bug#3642).
2596
1dae0f0a
AS
25972011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2598
268c2c36 2599 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 2600 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
2601 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2602 * cm.c (losecursor): Likewise.
1dae0f0a
AS
2603 * data.c (fmod): Likewise.
2604 * dispnew.c (swap_glyphs_in_rows): Likewise.
2605 * emacs.c (memory_warning_signal): Likewise.
2606 * floatfns.c (float_error): Likewise.
2607 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2608 (otf_open, font_otf_capability, generate_otf_features)
2609 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2610 Likewise.
2611 * image.c (pbm_read_file): Likewise.
2612 * indent.c (string_display_width): Likewise.
2613 * intervals.c (check_for_interval, search_for_interval)
2614 (inc_interval_count, count_intervals, root_interval)
2615 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2616 * lread.c (defalias): Likewise.
268c2c36 2617 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
2618 * regex.c (set_image_of_range_1, set_image_of_range)
2619 (regex_grow_registers): Likewise.
2620 * sysdep.c (strerror): Likewise.
2621 * termcap.c (valid_filename_p, tprint, main): Likewise.
2622 * tparam.c (main): Likewise.
2623 * unexhp9k800.c (run_time_remap, save_data_space)
2624 (update_file_ptrs, read_header, write_header, calculate_checksum)
2625 (copy_file, copy_rest, display_header): Likewise.
2626 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2627 Likewise.
2628 * xdisp.c (check_it): Likewise.
2629 * xfaces.c (register_color, unregister_color, unregister_colors):
2630 Likewise.
2631 * xfns.c (print_fontset_result): Likewise.
2632 * xrdb.c (member, fatal, main): Likewise.
2633
99033785
PE
26342011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2635
2636 Fix minor problems found by static checking (Bug#9031).
2637 * chartab.c (char_table_set_range, map_sub_char_table):
2638 Remove unused locals.
2639 (uniprop_table): Now static.
2640 * composite.c (_work_char): Remove unused static var.
2641
9cb2ac56
JB
26422011-07-09 Juanma Barranquero <lekktu@gmail.com>
2643
2644 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2645
f25661f0
JD
26462011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2647
2648 * gtkutil.c (qttip_cb): Remove code without function.
2649
8278c4fe
EZ
26502011-07-09 Eli Zaretskii <eliz@gnu.org>
2651
2652 * w32.c (pthread_sigmask): New stub.
2653
1692ae2d 26542011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 2655
8a6ebd58 2656 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
2657 sigprocmask is portable only for single-threaded applications, and
2658 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
2659 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2660 (LIBES): Use it.
2661 * callproc.c (Fcall_process):
2662 * process.c (create_process):
2663 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2664 Use pthread_sigmask, not sigprocmask.
123403e4 2665
1b854618
JD
26662011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2667
2668 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2669 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2670 wrong (Bug#8591).
2671
3fe4b549
JD
26722011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2673
0ce7e563
JD
2674 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2675 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2676 (xg_hide_tooltip): Fix comment.
2677
3fe4b549
JD
2678 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2679 in registerServicesMenuSendTypes.
2680 (validRequestorForSendType): Don't check ns_return_types.
2681
2682 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2683 ns_return_type.
2684
5df75e47
JR
26852011-07-08 Jason Rumney <jasonr@gnu.org>
2686
2687 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2688 frame struct members of non-existent frames (Bug#6284).
2689
699c10bd
JD
26902011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2691
4393663b
JD
2692 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2693 variable firstTime not needed on OSX >= 10.6.
2694 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2695 >= 10.5. Use setKnobProportion, setDoubleValue.
2696
2697 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2698 (MAC_OS_X_VERSION_10_5): Define if not defined.
2699 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2700 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2701 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2702
2703 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2704 cString and lossyCString on OSX >= 10.4
2705
2706 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2707 sizeToFit on OSX >= 10.2.
2708
2709 * nsimage.m (allocInitFromFile): Don't use deprecated method
2710 bestRepresentationForDevice on OSX >= 10.6.
2711
2712 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2713 to avoid warning.
2714
2715 * emacs.c: Declare unexec_init_emacs_zone.
2716
a63e0781
JD
2717 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2718
699c10bd
JD
2719 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2720
2721 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2722 on svcsMenu (Bug#8842).
2723
2724 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2725 ns_return_types.
2726 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2727
2728 * nsterm.m (QUTF8_STRING): Declare.
2729 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2730 (validRequestorForSendType): Return type is (id).
2731 Change indexOfObjectIdenticalTo to indexOfObject.
2732 Check if we have local selection before returning self (Bug#8842).
2733 (writeSelectionToPasteboard): Put local selection into paste board
2734 if we have a local selection (Bug#8842).
2735 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2736
2737 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2738 (ns_get_local_selection): Declare.
2739
54e10184
LMI
27402011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2741
9888ff71
LMI
2742 * keymap.c (describe_map_tree): Don't insert a double newline at
2743 the end of the buffer (bug#1169) and return whether we inserted
2744 something.
2745
54e10184
LMI
2746 * callint.c (Fcall_interactively): Change "reading args" to
2747 "providing args" to try to clarify what it does (bug#1010).
2748
15fa4783
KH
27492011-07-07 Kenichi Handa <handa@m17n.org>
2750
2751 * composite.c (composition_compute_stop_pos): Ignore a static
2752 composition starting before CHARPOS (Bug#8915).
2753
2754 * xdisp.c (handle_composition_prop): Likewise.
2755
a8815b00
EZ
27562011-07-07 Eli Zaretskii <eliz@gnu.org>
2757
2758 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2759 (Bug#9015)
2760
ef7b981d 27612011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
2762
2763 * character.h (unicode_category_t): New enum type.
2764
2765 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2766 (Qchar_code_property_table): New variable.
2767 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2768 (UNIPROP_COMPRESSED_FORM_P): New macros.
2769 (char_table_ascii): Uncompress the compressed values.
2770 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2771 Uncompress the compressed values.
ac389d0c 2772 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
2773 (char_table_ref_and_range): Uncompress the compressed values.
2774 (sub_char_table_set): New arg is_uniprop. Callers changed.
2775 Uncompress the compressed values.
2776 (sub_char_table_set_range): Args changed. Callers changed.
2777 (char_table_set_range): Adjuted for the above change.
2778 (map_sub_char_table): Delete args default_val and parent. Add arg
2779 top. Give decoded values to a Lisp function.
640c8776 2780 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
2781 values to a Lisp function. Gcpro more variables.
2782 (uniprop_table_uncompress)
2783 (uniprop_decode_value_run_length): New functions.
2784 (uniprop_decoder, uniprop_decoder_count): New variables.
2785 (uniprop_get_decoder, uniprop_encode_value_character)
2786 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2787 New functions.
2788 (uniprop_encoder, uniprop_encoder_count): New variables.
2789 (uniprop_get_encoder, uniprop_table)
2790 (Funicode_property_table_internal, Fget_unicode_property_internal)
2791 (Fput_unicode_property_internal): New functions.
2792 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2793 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 2794 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
2795 char-code-property-alist.
2796
640c8776 2797 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
2798 Vunicode_category_table.
2799
640c8776 2800 * font.c (font_range): Adjust for the change of
c805dec0
KH
2801 Vunicode_category_table.
2802
76b397fb
DN
28032011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2804
2805 * m/iris4d.h: Remove file, move contents ...
2806 * s/irix6-5.h: ... here.
2807
22b4128e
PE
28082011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2809
2810 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
2811 * alloc.c (mark_buffer):
2812 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2813 (clone_per_buffer_values): Don't assume that
22b4128e
PE
2814 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2815 This isn't true in general, and it's particularly not true
2816 if Emacs is configured with --with-wide-int.
2817 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2818 New macros, used in the buffer.c change.
2819
869795d6
JD
28202011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2821
2822 * xsettings.c: Use both GConf and GSettings if both are available.
2823 (store_config_changed_event): Add comment.
2824 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2825 (store_tool_bar_style_changed): New functions.
5e617bc2 2826 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
2827 (struct xsettings): Move font inside HAVE_XFT.
2828 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 2829 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 2830 Move inside HAVE_XFT.
640c8776 2831 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
2832 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2833 also.
2834 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 2835 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 2836 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
2837 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2838 (parse_settings): Move check for font inside HAVE_XFT.
2839 (read_settings, apply_xft_settings): Add comment.
2840 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2841 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2842 call store_font_name_changed.
2843 (xft_settings_event): Add comment.
2844 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2845 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2846 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2847 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2848 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
2849 (xsettings_get_system_font, xsettings_get_system_normal_font):
2850 Add comment.
869795d6 2851
d8ed26bd
PE
28522011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2853
2854 Random fixes. E.g., (random) never returned negative values.
2855 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2856 subseconds part to the entropy, as that's a bit more random.
2857 Prefer signed to unsigned, since the signedness doesn't matter and
2858 in general we prefer signed. When given a limit, use a
2859 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2860 latter isn't right if USE_2_TAGS_FOR_INTS.
2861 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2862 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2863
cabf1cac
SM
28642011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2865
2866 * textprop.c (text_property_stickiness):
2867 Obey Vtext_property_default_nonsticky.
2868 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2869 * w32fns.c (syms_of_w32fns):
2870 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2871
6e9b2be9
PE
28722011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2873
2874 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2875 This is more efficient than Ffile_directory_p and avoids a minor race.
2876
90186c68
LMI
28772011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2878
7c301272
LMI
2879 * buffer.c (Foverlay_put): Say what the return value is
2880 (bug#7835).
2881
c4f2d8d4
LMI
2882 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2883 is a directory before asking whether to use the file name
2884 (bug#7564).
ad637907
LMI
2885 (barf_or_query_if_file_exists): Make the "File is a directory"
2886 error be more correct.
c4f2d8d4 2887
90186c68
LMI
2888 * fns.c (Frequire): Remove the mention of the .gz files, since
2889 that's installation-specific, but keep the mention of
2890 `get-load-suffixes'.
2891
da64016e
PE
28922011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2893
2894 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2895 Report string overflow if the output is too long.
2896
7d47b580
JB
28972011-07-04 Juanma Barranquero <lekktu@gmail.com>
2898
a555cb87
JB
2899 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2900 (syms_of_gnutls): Remove duplicate DEFSYM for
2901 Qgnutls_bootprop_verify_hostname_error, an error for
2902 Qgnutls_bootprop_verify_error (which is no longer used).
2903
7d47b580
JB
2904 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2905 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2906 Also (re)move comments that are misplaced or no longer relevant.
2907
1e49bfab
LMI
29082011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2909
2910 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2911
1485f4c0
CY
29122011-07-03 Chong Yidong <cyd@stupidchicken.com>
2913
2914 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2915 and background color parameters if they have been changed.
2916
a9ab721e
LMI
29172011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2918
2919 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2920
cf7cff57
PE
29212011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2922
2e13213d
PE
2923 * xsettings.c (SYSTEM_FONT): Define only when used.
2924 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2925
cf7cff57
PE
2926 * keymap.c (access_keymap_1): Now static.
2927
7a8e04f7
CY
29282011-07-02 Chong Yidong <cyd@stupidchicken.com>
2929
2930 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2931 leave any prefix arg for the up event (Bug#1586).
2932
61352f62
LMI
29332011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2934
69bb1ef7
LMI
2935 * lread.c (syms_of_lread): Mention single symbols defined by
2936 `defvar' or `defconst' (bug#7154).
2937
61352f62 2938 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 2939 (Frequire): Mention get-load-suffixes.
61352f62 2940
28545e04
MR
29412011-07-02 Martin Rudalics <rudalics@gmx.at>
2942
2943 * window.h (window): Remove clone_number slot.
2944 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2945 Remove.
2946 (make_parent_window, make_window, saved_window)
2947 (Fset_window_configuration, save_window_save): Don't deal with
2948 clone numbers.
2949 * buffer.c (Qclone_number): Remove declaration.
2950 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2951
3349e122
SM
29522011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2953
2954 Add multiple inheritance to keymaps.
2955 * keymap.c (Fmake_composed_keymap): New function.
2956 (Fset_keymap_parent): Simplify.
2957 (fix_submap_inheritance): Remove.
2958 (access_keymap_1): New function extracted from access_keymap to handle
2959 embedded parents and handle lists of maps.
2960 (access_keymap): Use it.
2961 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2962 (Fcopy_keymap): Handle embedded parents.
2963 (Fcommand_remapping, define_as_prefix): Simplify.
2964 (Fkey_binding): Simplify.
2965 (syms_of_keymap): Move minibuffer-local-completion-map,
2966 minibuffer-local-filename-completion-map,
2967 minibuffer-local-must-match-map, and
2968 minibuffer-local-filename-must-match-map to Elisp.
2969 (syms_of_keymap): Defsubr make-composed-keymap.
2970 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2971 (parse_menu_item): Trivial simplification.
2972
3279eb87
GM
29732011-07-01 Glenn Morris <rgm@gnu.org>
2974
2975 * Makefile.in (SETTINGS_LIBS): Fix typo.
2976
4550efdf
KI
29772011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2978
2979 * coding.c (Fencode_coding_string): Record the last coding system
2980 used, as the function doc string says (bug#8738).
2981
0949d2b6
JD
29822011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2983
2984 * xsettings.c (store_monospaced_changed): Take new font as arg and
2985 check for change against current_mono_font.
2986 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2987 (emacs_settings_constructor, emacs_settings_get_property)
2988 (emacs_settings_set_property, emacs_settings_class_init)
2989 (emacs_settings_init, gsettings_obj): Remove.
2990 (something_changedCB): New function for HAVE_GSETTINGS.
2991 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2992 with value as argument.
2993 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2994 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 2995 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
2996 "changed".
2997
2998 * xgselect.c: Add defined (HAVE_GSETTINGS).
2999 (xgselect_initialize): Ditto.
3000
3001 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3002 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3003 xg_select.
3004
bbc6b304
PE
30052011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3006
3007 * eval.c (struct backtrace): Simplify and port the data structure.
3008 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3009 signed bit field, as this assumption is not portable and it makes
3010 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3011 "char debug_on_exit : 1" as this is not portable either; instead,
3012 use the portable "unsigned int debug_on_exit : 1". Remove unused
3013 member evalargs. Remove obsolete comments about cc bombing out.
3014
9851bfc5
JD
30152011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3016
51bb811f 3017 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
3018 Let HAVE_GSETTINGS override HAVE_GCONF.
3019 (store_monospaced_changed): New function.
3020 (EMACS_SETTINGS): A new type derived from GObject to handle
3021 GSettings notifications.
3022 (emacs_settings_constructor, emacs_settings_get_property)
3023 (emacs_settings_set_property, emacs_settings_class_init):
3024 New functions.
3025 (gsettings_client, gsettings_obj): New variables.
3026 (GSETTINGS_SCHEMA): New define.
3027 (something_changedCB): Call store_monospaced_changed.
3028 (init_gsettings): New function.
3029 (xsettings_initialize): Call init_gsettings.
3030 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3031 to NULL.
3032
640c8776 3033 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
3034 GCONF_CFLAGS/LIBS.
3035
5386012d
MR
30362011-06-29 Martin Rudalics <rudalics@gmx.at>
3037
3038 * window.c (resize_root_window, grow_mini_window)
3039 (shrink_mini_window): Rename Qresize_root_window to
3040 Qwindow_resize_root_window and Qresize_root_window_vertically to
3041 Qwindow_resize_root_window_vertically.
3042
f13e0b08
PE
30432011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3044
3045 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3046
94515237
JB
30472011-06-27 Juanma Barranquero <lekktu@gmail.com>
3048
3049 * makefile.w32-in: Redesign dependencies so they reflect more
3050 clearly which files are directly included by each source file,
3051 and not through other includes.
3052
e43b6e43
MR
30532011-06-27 Martin Rudalics <rudalics@gmx.at>
3054
3055 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3056 (sort_overlays, overlay_strings): When an overlay's clone number
3057 matches the window's clone number process the overlay even if
3058 the overlay's window property doesn't match the current window.
3059
d68443dc
MR
3060 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3061 (Fwindow_hchild): Rename to Fwindow_left_child.
3062 (Fwindow_next): Rename to Fwindow_next_sibling.
3063 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
3064 (resize_window_check): Rename to window_resize_check.
3065 (resize_window_apply): Rename to window_resize_apply.
3066 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3067 (Fdelete_other_windows_internal, resize_frame_windows)
3068 (Fsplit_window_internal, Fdelete_window_internal)
3069 (grow_mini_window, shrink_mini_window)
3070 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 3071
c7e73be5
JD
30722011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3073
3074 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3075 (emacs_fixed_set_min_size): Remove.
3076 (emacs_fixed_new): Take frame as argument.
3077
3078 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3079 (_EmacsFixedPrivate): Remove minwidth/height.
3080 Add struct frame *f.
3081 (emacs_fixed_init): Initialize priv->f.
3082 (get_parent_class, emacs_fixed_set_min_size): Remove.
3083 (emacs_fixed_new): Set priv->f to argument.
3084 (emacs_fixed_get_preferred_width)
3085 (emacs_fixed_get_preferred_height): Use min_width/height from
3086 frames size_hint to set minimum and natural (Bug#8919).
3087 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3088 and use min_width/height from frames size_hint to set
3089 min_width/height (Bug#8919).
3090
3091 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
3092 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3093 Fix indentation.
c7e73be5 3094
cf99dcf8
EZ
30952011-06-26 Eli Zaretskii <eliz@gnu.org>
3096
3097 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3098 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3099 called at ZV.
3100
029529ac
CY
31012011-06-26 Chong Yidong <cyd@stupidchicken.com>
3102
3103 * process.c (wait_reading_process_output): Bypass select if
3104 waiting for a cell while ignoring keyboard input, and input is
3105 pending. Suggested by Jan Djärv (Bug#8869).
3106
7a7ef429
PE
31072011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3108
3109 Use gnulib's dup2 module instead of rolling our own.
3110 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3111
11fdef7d 31122011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
3113
3114 * dispnew.c (scrolling_window): Before scrolling, turn off a
3115 mouse-highlight in the window being scrolled.
3116
cd3520a4
JB
31172011-06-24 Juanma Barranquero <lekktu@gmail.com>
3118
3119 Move DEFSYM to lisp.h and use everywhere.
3120
3121 * character.h (DEFSYM): Move declaration...
3122 * lisp.h (DEFSYM): ...here.
3123
3124 * gnutls.c:
3125 * minibuf.c:
3126 * w32menu.c:
3127 * w32proc.c:
3128 * w32select.c: Don't include character.h.
3129
3130 * alloc.c (syms_of_alloc):
3131 * buffer.c (syms_of_buffer):
3132 * bytecode.c (syms_of_bytecode):
3133 * callint.c (syms_of_callint):
3134 * casefiddle.c (syms_of_casefiddle):
3135 * casetab.c (init_casetab_once):
3136 * category.c (init_category_once, syms_of_category):
3137 * ccl.c (syms_of_ccl):
3138 * cmds.c (syms_of_cmds):
3139 * composite.c (syms_of_composite):
3140 * dbusbind.c (syms_of_dbusbind):
3141 * dired.c (syms_of_dired):
3142 * dispnew.c (syms_of_display):
3143 * doc.c (syms_of_doc):
3144 * editfns.c (syms_of_editfns):
3145 * emacs.c (syms_of_emacs):
3146 * eval.c (syms_of_eval):
3147 * fileio.c (syms_of_fileio):
3148 * fns.c (syms_of_fns):
3149 * frame.c (syms_of_frame):
3150 * fringe.c (syms_of_fringe):
3151 * insdel.c (syms_of_insdel):
3152 * keymap.c (syms_of_keymap):
3153 * lread.c (init_obarray, syms_of_lread):
3154 * macros.c (syms_of_macros):
3155 * msdos.c (syms_of_msdos):
3156 * print.c (syms_of_print):
3157 * process.c (syms_of_process):
3158 * search.c (syms_of_search):
3159 * sound.c (syms_of_sound):
3160 * syntax.c (init_syntax_once, syms_of_syntax):
3161 * terminal.c (syms_of_terminal):
3162 * textprop.c (syms_of_textprop):
3163 * undo.c (syms_of_undo):
3164 * w32.c (globals_of_w32):
3165 * window.c (syms_of_window):
3166 * xdisp.c (syms_of_xdisp):
3167 * xfaces.c (syms_of_xfaces):
3168 * xfns.c (syms_of_xfns):
3169 * xmenu.c (syms_of_xmenu):
3170 * xsettings.c (syms_of_xsettings):
3171 * xterm.c (syms_of_xterm): Use DEFSYM.
3172
4228cf16
TZ
31732011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3174
cd3520a4 3175 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 3176
7fcccf1e
PE
31772011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3178
7efb4e0e
PE
3179 Integer and buffer overflow fixes (Bug#8873).
3180
ff5844ad
PE
3181 * print.c (printchar, strout): Check for string overflow.
3182 (PRINTPREPARE, printchar, strout):
3183 Don't set size unless allocation succeeds.
3184
90532f02
PE
3185 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3186 for sizes. Check for string overflow more accurately.
3187 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3188
6d84508d
PE
3189 * macros.c: Integer and buffer overflow fixes.
3190 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3191 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3192 Use ptrdiff_t, not int, for sizes.
3193 Don't increment bufsize until after realloc succeeds.
3194 Check for size-calculation overflow.
3195 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3196
437b2cb4
PE
3197 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3198
8b9ac8b4
PE
3199 * lread.c: Integer overflow fixes.
3200 (read_integer): Radix is now EMACS_INT, not int,
3201 to improve quality of diagnostics for out-of-range radices.
3202 Calculate buffer size correctly for out-of-range radices.
3203 (read1): Check for integer overflow in radices, and in
3204 read-circle numbers.
82cb60d3
PE
3205 (read_escape): Avoid int overflow.
3206 (Fload, openp, read_buffer_size, read1)
3207 (substitute_object_recurse, read_vector, read_list, map_obarray):
3208 Use ptrdiff_t, not int, for sizes.
3209 (read1): Use EMACS_INT, not int, for sizes.
20270765 3210 Check for size overflow.
8b9ac8b4 3211
7fcccf1e
PE
3212 * image.c (cache_image): Check for size arithmetic overflow.
3213
bfbbd7e7
PE
3214 * lread.c: Integer overflow issues.
3215 (saved_doc_string_size, saved_doc_string_length)
3216 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3217 Now ptrdiff_t, not int.
3218 (read1): Don't assume doc string length fits in int. Check for
3219 out-of-range doc string lengths.
3220 (read_list): Don't assume file position fits in int.
39019e54 3221 (read_escape): Check for hex character overflow.
bfbbd7e7 3222
4e323265
LL
32232011-06-22 Leo Liu <sdl.web@gmail.com>
3224
3225 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3226 Move to minibuffer.el.
3227
85fece3e
PE
32282011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3229
20b84ce9 3230 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
3231 The following patches are for when GLYPH_DEBUG && !XASSERT.
3232 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3233 * dispnew.c (flush_stdout):
3234 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3235 Mark as externally visible.
3236 * dispnew.c (check_window_matrix_pointers): Now static.
3237 * dispnew.c (window_to_frame_vpos):
3238 * xfns.c (unwind_create_frame):
3239 * xterm.c (x_check_font): Remove unused local.
3240 * scroll.c (CHECK_BOUNDS):
3241 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3242 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3243 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3244 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3245 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3246 Now static.
3247 (debug_method_add): Use va_list and vsprintf rather than relying
3248 on undefined behavior with wrong number of arguments.
3249 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3250 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3251 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3252 since we're not interested in debugging glyphs with old libraries.
3253 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3254 GCC 4.6.0's static checking.
3255
0766b489
PE
32562011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3257
31fd4b32
PE
3258 Integer overflow and signedness fixes (Bug#8873).
3259 A few related buffer overrun fixes, too.
3260
b79e8648
PE
3261 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3262
0766b489
PE
3263 * dispextern.h (struct face.stipple):
3264 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3265 (x_bitmap_mask, x_allocate_bitmap_record)
3266 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3267 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3268 (x_create_bitmap_from_xpm_data):
3269 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3270 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3271 (.bitmaps_last):
3272 * xfaces.c (load_pixmap):
3273 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3274 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3275 (.bitmaps_last, struct x_output.icon_bitmap):
3276 Use ptrdiff_t, not int, for bitmap indexes.
3277 (x_allocate_bitmap_record): Check for size overflow.
3278 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3279
b081724f
PE
3280 Use ptrdiff_t, not int, for overlay counts.
3281 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3282 * editfns.c (overlays_around, get_pos_property):
3283 * textprop.c (get_char_property_and_overlay):
3284 * xdisp.c (next_overlay_change, note_mouse_highlight):
3285 * xfaces.c (face_at_buffer_position):
21514da7
PE
3286 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3287 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3288 (Fnext_overlay_change, Fprevious_overlay_change)
3289 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 3290 Use ptrdiff_t, not int, for sizes.
21514da7 3291 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 3292
3de73e5e
PE
3293 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3294
2606c57b
PE
3295 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3296 (x_session_initialize): Do not assume string length fits in int.
3297
aaafe47a
PE
3298 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3299 This is unlikely, but can occur if DPI is outlandish.
3300
2674ddc8 3301 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
3302 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3303
28154962
PE
3304 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3305 * xrdb.c (magic_file_p, search_magic_path):
3306 Omit last arg SUFFIX; it was always 0. All callers changed.
3307 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3308
7de51af5
PE
3309 * xfont.c (xfont_match): Avoid need for strlen.
3310
25ed6cc3
PE
3311 * xfns.c: Don't assume strlen fits in int.
3312 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3313
4eab31dd
PE
3314 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3315 not unsigned long, as we prefer signed integers. All callers changed.
3316 Detect integer overflow in repeat count.
3317 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 3318 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 3319
171e2a58
PE
3320 * termcap.c: Don't assume sizes fit in int and never overflow.
3321 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3322 (gobble_line): Check for size-calculation overflow.
3323
ad39faca 3324 * minibuf.c (Fread_buffer):
6e5bb2dc 3325 * lread.c (intern, intern_c_string):
74ca2eb3
PE
3326 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3327 Don't assume string length fits in int.
3328
52c61c22 3329 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
3330 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3331
b5b8c9e5
PE
3332 * font.c: Don't assume string length fits in int.
3333 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3334 Use ptrdiff_t, not int.
ccd6111c
PE
3335 (font_intern_prop): Don't assume string length fits in int.
3336 Don't assume integer property fits in fixnum.
3337 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 3338
882f0d81 3339 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 3340 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
3341 Reformulate so as not to need the command string.
3342 Invoke gzip -cd rather than gunzip, as it's more portable.
3343 (lock_info_type, lock_file_1, lock_file):
3344 Don't assume pid_t and time_t fit in unsigned long.
3345 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3346 (current_lock_owner): Prefer signed type for sizes.
3347 Use memcpy, not strncpy, where memcpy is what is really wanted.
3348 Don't assume (via atoi) that time_t and pid_t fit in int.
3349 Check for time_t and/or pid_t out of range, e.g., via a network share.
3350 Don't alloca where an auto var works fine.
3351
93f4cf88
PE
3352 * fileio.c: Fix some integer overflow issues.
3353 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3354 Don't assume string length fits in int.
3355 (directory_file_name): Don't assume string length fits in long.
3356 (make_temp_name): Don't assume pid fits in int, or that its print
3357 length is less than 20.
3358
f3e92b69
PE
3359 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3360
1bfdaf10
PE
3361 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3362
35016e9a
PE
3363 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3364
3d1e65a1
PE
3365 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3366 We prefer signed integers, even for size calculations.
3367
0b963a93
PE
3368 * emacs.c: Don't assume string length fits in 'int'.
3369 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3370 (main): Don't invoke strlen when not needed.
3371
573f4b54
PE
3372 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3373 (XD_DEBUG_MESSAGE): Don't waste a byte.
3374
989f33ba
PE
3375 * callproc.c (getenv_internal_1, getenv_internal)
3376 (Fgetenv_internal):
965d34eb
PE
3377 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3378
e4d29b33
PE
3379 * lread.c (invalid_syntax): Omit length argument.
3380 All uses changed. This doesn't fix a bug, but it simplifies the
3381 code away from its former Hollerith-constant appearance, and it's
3382 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 3383 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 3384
eb49b136
PE
3385 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3386 This didn't break anything, but it didn't help either.
3387 It's confusing to put a bogus integer in a place where the actual
3388 value does not matter.
9f62aeb1 3389 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 3390 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 3391
15375a22
PE
3392 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3393 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3394 implementation.
b61cc01c
PE
3395 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3396 We prefer signed types, and the value cannot exceed the EMACS_INT
3397 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
3398 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3399 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3400 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 3401
53b2623d
PE
3402 * indent.c (sane_tab_width): New function.
3403 (current_column, scan_for_column, Findent_to, position_indentation)
3404 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 3405 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 3406
51cab52b 3407 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 3408
f2ed8a70
PE
3409 * lisp.h (lint_assume): New macro.
3410 * composite.c (composition_gstring_put_cache):
3411 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3412
abe80cc6
PE
3413 * editfns.c, insdel.c:
3414 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 3415
b02c740e
PE
3416 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3417
ebc96716
PE
3418 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3419
b4e50fa0 3420 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 3421 Use much-faster test for byte-length change.
311d5d7c 3422 Don't assume string byte-length fits in 'int'.
a4cf38e4 3423 Check that character arg fits in 'int'.
85461888 3424 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 3425
c0c1ee9f
PE
3426 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3427
a498d7f4
PE
3428 * fns.c (concat): Catch string overflow earlier.
3429 Do not rely on integer wraparound.
3430
51cab52b
PE
3431 * dispextern.h (struct it.overlay_strings_charpos)
3432 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
3433 * xdisp.c (forward_to_next_line_start)
3434 (back_to_previous_visible_line_start)
3435 (reseat_at_next_visible_line_start, next_element_from_buffer):
3436 Don't arbitrarily truncate the value of 'selective' to int.
3437
76031fad
PE
3438 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3439
5eb55db9
PE
3440 * composite.c: Don't truncate sizes to 'int'.
3441 (composition_gstring_p, composition_reseat_it)
3442 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
3443 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3444 not EMACS_UINT, for indexes.
5eb55db9 3445
0703a717
PE
3446 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3447
d6202519
PE
3448 * buffer.c: Include <verify.h>.
3449 (struct sortvec.priority, struct sortstr.priority):
8961a454 3450 Now EMACS_INT, not int.
c20998a7 3451 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
3452 (struct sortstr.size, record_overlay_string)
3453 (struct sortstrlist.size, struct sortlist.used):
3454 Don't truncate size to int.
3455 (record_overlay_string): Check for size-calculation overflow.
d6202519 3456 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 3457
d5a19415
JM
34582011-06-22 Jim Meyering <meyering@redhat.com>
3459
029529ac 3460 Don't leak an XBM-image-sized buffer
d5a19415
JM
3461 * image.c (xbm_load): Free the image buffer after using it.
3462
a9041e6c
PE
34632011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3464
3465 Port to Sun C.
3466 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3467 that Sun C diagnosed.
3468 * fns.c (secure_hash): Fix pointer signedness issue.
3469 * intervals.c (static_offset_intervals): New function.
3470 (offset_intervals): Use it.
3471
7f3f739f
LL
34722011-06-21 Leo Liu <sdl.web@gmail.com>
3473
3474 * deps.mk (fns.o):
3475 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3476 sha512.h.
3477
3478 * fns.c (secure_hash): Rename from crypto_hash_function and change
3479 the first arg to accept symbols.
5b66d427 3480 (Fsecure_hash): New primitive.
7f3f739f
LL
3481 (syms_of_fns): New symbols.
3482
76147d94
DD
34832011-06-20 Deniz Dogan <deniz@dogan.se>
3484
3485 * process.c (Fset_process_buffer): Clarify return value in
3486 docstring.
3487
7d7d0045
CY
34882011-06-18 Chong Yidong <cyd@stupidchicken.com>
3489
3490 * dispnew.c (add_window_display_history): Use BVAR.
3491
3492 * xdisp.c (debug_method_add): Use BVAR.
3493 (check_window_end, dump_glyph_matrix, dump_glyph)
3494 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3495
3496 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3497 Likewise.
3498
3499 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3500 check till after the cache is created in init_frame_faces.
3501
ff2bc410
SM
35022011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3503
3504 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3505
28177add
PE
35062011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3507
dd3482fe
PE
3508 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3509 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3510 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3511
393d71f3 3512 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
3513 * fileio.c (Finsert_file_contents):
3514 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3515 Remove the old (too-loose) buffer overflow checks.
3516 They weren't needed, since make_gap checks for buffer overflow.
3517 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3518 The old code merely checked for Emacs fixnum overflow, and relied
3519 on undefined (wraparound) behavior. The new code avoids undefined
3520 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3521
2e6813b0 3522 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
3523 Tune. Don't use wider integers than needed. Don't use alloca.
3524 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 3525
599a9e4f
PE
3526 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3527
99561444
PE
3528 * insdel.c, lisp.h (buffer_overflow): New function.
3529 (insert_from_buffer_1, replace_range, replace_range_2):
3530 * insdel.c (make_gap_larger):
3531 * editfns.c (Finsert_char):
3532 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3533
28177add
PE
3534 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3535
e69dafad
PE
35362011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3537
a7af7fde 3538 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 3539
b1c46f02
PE
3540 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3541 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3542
e69dafad
PE
3543 * fileio.c: Don't assume EMACS_INT fits in off_t.
3544 (emacs_lseek): New static function.
3545 (Finsert_file_contents, Fwrite_region): Use it.
3546 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3547
566684ea
PE
3548 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3549
e6966cd6
PE
3550 * fns.c: Don't overflow int when computing a list length.
3551 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3552 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3553 truncation on 64-bit hosts. Check for QUIT every
3554 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3555 faster and is responsive enough.
3556 (Flength): Report an error instead of overflowing an integer.
3557 (Fsafe_length): Return a float if the value is not representable
3558 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 3559 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 3560 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 3561
dd0b0efb
PE
3562 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3563 (header_size, word_size): New constants.
3564 (allocate_vectorlike): Don't check size overflow here.
3565 (allocate_vector): Check it here instead, since this is the only
3566 caller of allocate_vectorlike that could cause overflow.
3567 Check that the new vector's length is representable as a fixnum.
3568
86fe5cfe
PE
3569 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3570 The previous code was bogus. For example, next_almost_prime (32)
3571 returned 39, which is undesirable as it is a multiple of 3; and
3572 next_almost_prime (24) returned 25, which is a multiple of 5 so
3573 why was the code bothering to check for multiples of 7?
3574
80e88859
PE
3575 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3576
4a2f0ad6
PE
3577 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3578
f66c7cf8
PE
3579 Variadic C functions now count arguments with ptrdiff_t.
3580 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3581 Back then I didn't know that the Emacs coding style prefers signed int.
3582 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
3583 were being counted with int, which may truncate counts on 64-bit
3584 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
3585 * lisp.h (struct Lisp_Subr.function.aMANY)
3586 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3587 Arg counts are now ptrdiff_t, not size_t.
3588 All variadic functions and their callers changed accordingly.
3589 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3590 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3591 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3592 * callint.c (Fcall_interactively): Check arg count for overflow,
3593 to avoid potential buffer overrun. Use signed char, not 'int',
3594 for 'varies' array, so that we needn't bother to check its size
3595 calculation for overflow.
3596 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3597 * eval.c (apply_lambda):
3598 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3599 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3600 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3601
a1759b76
PE
3602 * callint.c (Fcall_interactively): Don't use index var as event count.
3603
d96be9fc
PE
3604 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3605 * mem-limits.h (SIZE): Remove; no longer used.
3606
a690a978 3607 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 3608
578c21e6
PE
3609 Remove unnecessary casts.
3610 * xterm.c (x_term_init):
3611 * xfns.c (x_set_border_pixel):
3612 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3613 These aren't needed now that we assume ANSI C.
3614
96f53c6c
PE
3615 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3616 It's more likely to cause problems (due to unsigned overflow)
3617 than to cure them.
3618
83c77d31
PE
3619 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3620
ee2079f1
PE
3621 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3622
6da65536
PE
3623 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3624
7147c4a4
PE
3625 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3626
193e32d9
PE
3627 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3628
e5533da6
PE
3629 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3630
9910e595
PE
3631 GLYPH_CODE_FACE returns EMACS_INT, not int.
3632 * dispextern.h (merge_faces):
3633 * xfaces.c (merge_faces):
01103c44
PE
3634 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3635 Don't assume EMACS_INT fits in int.
9910e595 3636
2638320e
PE
3637 * character.h (CHAR_VALID_P): Remove unused parameter.
3638 * fontset.c, lisp.h, xdisp.c: All uses changed.
3639
045eb8d9
PE
3640 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3641
c1f134b5
PE
3642 * fns.c (concat): Minor tuning based on overflow analysis.
3643 This doesn't fix any bugs. Use int to hold character, instead
3644 of constantly refetching from Emacs object. Use XFASTINT, not
3645 XINT, for value known to be a character. Don't bother comparing
3646 a single byte to 0400, as it's always less.
3647
395fcb93 3648 * floatfns.c (Fexpt):
327eeec8
PE
3649 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3650
abbd3d23
PE
3651 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3652 for characters.
3653
684a03ef
PE
3654 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3655
0fed43f3
PE
3656 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3657 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3658 incorrectly succeed when S was a string, because 4294967386 was
3659 truncated before it was used.
3660
8fd02eb7
PE
3661 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3662 Otherwise, an out-of-range integer could cause undefined behavior
3663 on a 64-bit host.
3664
f8c86b69
PE
3665 * composite.c: Use int, not EMACS_INT, for characters.
3666 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3667 EMACS_INT, for values that are known to be in character range.
3668 This doesn't fix any bugs but is the usual style inside Emacs and
3669 may generate better code on 32-bit machines.
3670
34206dd2
PE
3671 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3672 This is for reasons similar to the recent CHAR_STRING fix.
3673 * charset.c (Fencode_char): Check that character arg is actually
3674 a character. Pass an int to ENCODE_CHAR.
3675 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3676 wider than 'int', as a compile-time check to prevent future regressions
3677 in this area.
3678
c5958d4c 3679 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
3680
3681 Make sure a 64-bit char is never passed to CHAR_STRING.
3682 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3683 by silently ignoring the top 32 bits, allowing some values
3684 that were far too large to be valid characters.
3685 * character.h: Include <verify.h>.
3686 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3687 arguments are no wider than unsigned, as a compile-time check
3688 to prevent future regressions in this area.
3689 * data.c (Faset):
01103c44 3690 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
3691 (Fsubst_char_in_region):
3692 * fns.c (concat):
3693 * xdisp.c (decode_mode_spec_coding):
3694 Adjust to CHAR_STRING's new requirement.
3695 * editfns.c (Finsert_char, Fsubst_char_in_region):
3696 * fns.c (concat): Check that character args are actually
3697 characters. Without this test, these functions did the wrong
3698 thing with wildly out-of-range values on 64-bit hosts.
3699
d37ca623
PE
3700 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3701 These casts should not be needed on 32-bit hosts, either.
3702 * keyboard.c (read_char):
3703 * lread.c (Fload): Remove casts to unsigned.
3704
ea204efb
PE
3705 * lisp.h (UNSIGNED_CMP): New macro.
3706 This fixes comparison bugs on 64-bit hosts.
3707 (ASCII_CHAR_P): Use it.
3708 * casefiddle.c (casify_object):
01103c44 3709 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
3710 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3711 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3712 * dispextern.h (FACE_FROM_ID):
3713 * keyboard.c (read_char): Use UNSIGNED_CMP.
3714
41cb286c
PE
3715 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3716 not to EMACS_INT, to avoid GCC warning.
3717
4a1b9832
PE
3718 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3719
55daad71
PE
3720 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3721 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3722 isn't needed on 32-bit machines.
8f95c75c 3723
01103c44
PE
3724 * buffer.c (Fgenerate_new_buffer_name):
3725 Use EMACS_INT for count, not int.
0ceccced 3726 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
3727
3728 * data.c (Qcompiled_function): Now static.
3729
c6f072e7
PE
3730 * window.c (window_body_lines): Now static.
3731
20ce5912
PE
3732 * image.c (gif_load): Rename local to avoid shadowing.
3733
9c4c5f81
PE
3734 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3735 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3736 * alloc.c (make_save_value): Integer argument is now of type
3737 ptrdiff_t, not int.
3738 (mark_object): Use ptrdiff_t, not int.
3739 * lisp.h (pD): New macro.
3740 * print.c (print_object): Use it.
3741
c0c5c8ae
PE
3742 * alloc.c: Use EMACS_INT, not int, to count objects.
3743 (total_conses, total_markers, total_symbols, total_vector_size)
3744 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
3745 (total_free_floats, total_floats, total_free_intervals)
3746 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
3747 Now EMACS_INT, not int. All uses changed.
3748 (Fgarbage_collect): Compute overall total using a double, so that
3749 integer overflow is less likely to be a problem. Check for overflow
3750 when converting back to an integer.
5a25e253
PE
3751 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3752 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3753 These were 'int' variables that could overflow on 64-bit hosts;
3754 they were never used, so remove them instead of repairing them.
211a0b2a 3755 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
3756 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3757 Previously, this ceilinged at INT_MAX, but that doesn't work on
3758 64-bit machines.
e46bb31a 3759 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 3760
c78baabf 3761 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 3762 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
3763 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3764 when a (possibly-narrower) signed value would do just as well.
3765 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 3766
c9d624c6
PE
3767 * alloc.c: Catch some string size overflows that we were missing.
3768 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3769 for convenience in STRING_BYTES_MAX.
3770 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3771 The definition here is exact; the one in lisp.h was approximate.
3772 (allocate_string_data): Check for string overflow. This catches
3773 some instances we weren't catching before. Also, it catches
3774 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3775 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3776 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 3777
c9d624c6
PE
3778 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3779 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 3780 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 3781
353032ce
PE
3782 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3783
2bccce07
PE
3784 * alloc.c (Fmake_string): Check for out-of-range init.
3785
0ac30604
SM
37862011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3787
3788 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3789
c195f2de
JD
37902011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3791
3792 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3793 xg_get_default_scrollbar_width.
3794
3795 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3796 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3797 (style_changed_cb): Call update_theme_scrollbar_width and call
3798 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3799 all frames (Bug#8505).
3800 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3801 Call gtk_window_set_resizable if HAVE_GTK3.
3802 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3803 and height if HAVE_GTK3 (Bug#8505).
3804 (scroll_bar_width_for_theme): New variable.
3805 (update_theme_scrollbar_width): New function.
3806 (xg_get_default_scrollbar_width): Move code to
3807 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3808 (xg_initialize): Call update_theme_scrollbar_width.
3809
3810 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3811
3812 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3813
e10ac9f1
MR
38142011-06-12 Martin Rudalics <rudalics@gmx.at>
3815
3816 * frame.c (make_frame): Call other_buffer_safely instead of
3817 other_buffer.
3818
3819 * window.c (temp_output_buffer_show): Call display_buffer with
3820 second argument Vtemp_buffer_show_specifiers and reset latter
3821 immediately after the call.
3822 (Vtemp_buffer_show_specifiers): New variable.
3823 (auto_window_vscroll_p, next_screen_context_lines)
3824 (Vscroll_preserve_screen_position): Remove leading asterisks from
3825 doc-strings.
3826
2d3c217e 38272011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 3828
7b7f97e8 3829 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
3830 * buffer.c (Qclone_number): Remove for now, as it's unused.
3831 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3832 (record_buffer): Remove unused local.
3833 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3834 (set_frame_buffer_list): Remove; unused.
3835 * frame.h (other_visible_frames): Remove decl.
3836 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3837 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3838 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3839 if HAVE_GPM.
3840 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3841 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3842 Define only if HAVE_GPM.
3843 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3844 (update_hints_inhibit): Remove; never set. All uses removed.
3845 * widgetprv.h (emacsFrameClassRec): Remove decl.
3846 * window.c (delete_deletable_window): Now returns void, since it
3847 wasn't returning anything.
3848 (compare_window_configurations): Remove unused locals.
3849 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3850 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
3851 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3852 the same widths as pointers. This follows up on the 2011-05-06 patch.
3853 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3854 * xterm.h: Likewise.
3855 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3856
1384b89e
JB
38572011-06-12 Juanma Barranquero <lekktu@gmail.com>
3858
3859 * makefile.w32-in: Update dependencies.
3860 (LISP_H): Add lib/intprops.h.
3861
1100a63c
CY
38622011-06-11 Chong Yidong <cyd@stupidchicken.com>
3863
3864 * image.c (gif_load): Add animation frame delay to the metadata.
3865 (syms_of_image): Use DEFSYM. New symbol `delay'.
3866
6198ccd0
MR
38672011-06-11 Martin Rudalics <rudalics@gmx.at>
3868
3869 * window.c (delete_deletable_window): Re-add.
3870 (Fset_window_configuration): Rewrite to handle dead buffers and
3871 consequently deletable windows.
3872 (window_tree, Fwindow_tree): Remove. Supply functionality in
3873 window.el.
3874 (compare_window_configurations): Simplify code.
3875
b6e3633c
AS
38762011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3877
1ab0dee5
AS
3878 * image.c (imagemagick_load_image): Fix type mismatch.
3879 (Fimagemagick_types): Likewise.
3880
b6e3633c
AS
3881 * window.h (replace_buffer_in_windows): Declare.
3882
9397e56f
MR
38832011-06-11 Martin Rudalics <rudalics@gmx.at>
3884
3885 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3886 Qclone_number. Remove external declaration of Qdelete_window.
3887 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3888 code.
640c8776
SM
3889 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3890 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
3891 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3892 buffer list implementation.
3893 (other_buffer_safely): New function.
3894 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3895 calls to replace_buffer_in_windows and
3896 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3897 if allowed.
3898 (record_buffer): Inhibit quitting and rewrite using quittable
3899 functions. Run Qbuffer_list_update_hook if allowed.
3900 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
3901 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3902 Move switch-to-buffer to window.el.
9397e56f
MR
3903 (bury-buffer): Move to window.el.
3904 (Vbuffer_list_update_hook): New variable.
3905
3906 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3907 section.
3908
3909 * window.h (resize_frame_windows): Move up in code.
3910 (Fwindow_frame): Remove EXFUN.
3911 (replace_buffer_in_all_windows): Remove prototype.
3912 (replace_buffer_in_windows_safely): Add prototype.
3913
3914 * window.c: Declare Qdelete_window static again. Move down
3915 declaration of select_count.
3916 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3917 (Fother_window): Move to window.el.
3918 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3919 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3920 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3921 window.el.
3922 (replace_buffer_in_windows): Implement by calling
3923 Qreplace_buffer_in_windows.
3924 (replace_buffer_in_all_windows): Remove with some functionality
3925 moved into replace_buffer_in_windows_safely.
3926 (replace_buffer_in_windows_safely): New function.
3927 (select_window_norecord, select_frame_norecord): Move in front
3928 of run_window_configuration_change_hook. Remove now obsolete
3929 declarations.
640c8776
SM
3930 (Fset_window_buffer): Rewrite doc-string.
3931 Call Qrecord_window_buffer.
9397e56f
MR
3932 (keys_of_window): Move binding for other-window to window.el.
3933
b50691aa
CY
39342011-06-11 Chong Yidong <cyd@stupidchicken.com>
3935
3936 * dispextern.h (struct image): Replace data member, whose int_val
3937 and ptr_val fields were not used by anything, with a single
3938 lisp_val object.
3939
3940 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3941 (gif_clear_image, gif_load, imagemagick_load_image)
3942 (gs_clear_image, gs_load): Callers changed.
3943
3f754b86
PE
39442011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3945
cca69397
PE
3946 * buffer.h: Include <time.h>, for time_t.
3947 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3948
109e28d0
PE
3949 Fix minor problems found by static checking.
3950
60737f02
PE
3951 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3952
4b66faf3
PE
3953 Make identifiers static if they are not used in other modules.
3954 * data.c (Qcompiled_function, Qframe, Qvector):
3955 * image.c (QimageMagick, Qsvg):
3956 * minibuf.c (Qmetadata):
3957 * window.c (resize_window_check, resize_root_window): Now static.
3958 * window.h (resize_window_check, resize_root_window): Remove decls.
3959
109e28d0
PE
3960 * window.c (window_deletion_count, delete_deletable_window):
3961 Remove; unused.
46a4ce9e
PE
3962 (window_body_lines): Now static.
3963 (Fdelete_other_windows_internal): Mark vars as initialized.
3964 Make sure 'resize_failed' is initialized.
3965 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3966 (resize_window_apply): Remove unused local.
3967 * window.h (delete_deletable_window): Remove decl.
3968
109e28d0 3969 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
3970 (imagemagick_load_image): Fix pointer signedness problem by changing
3971 last arg from unsigned char * to char *. All uses changed.
3972 Also, fix a local for similar reasons.
3973 Remove unused locals. Remove locals to avoid shadowing.
3974 (fn_rsvg_handle_free): Remove; unused.
3975 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 3976 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 3977
3f754b86
PE
3978 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3979
2547adb1
CY
39802011-06-10 Chong Yidong <cyd@stupidchicken.com>
3981
3982 * image.c (gif_load): Fix omitted cast error introduced by
3983 2011-06-06 change.
3984
2c8e37d4
MR
39852011-06-10 Martin Rudalics <rudalics@gmx.at>
3986
3987 * window.h (resize_proportionally, orig_total_lines)
3988 (orig_top_line): Remove from window structure.
3989 (set_window_height, set_window_width, change_window_heights)
3990 (Fdelete_window): Remove prototypes.
3991 (resize_frame_windows): Remove duplicate declaration.
3992
440a42e3
EZ
39932011-06-10 Eli Zaretskii <eliz@gnu.org>
3994
3995 * window.h (resize_frame_windows, resize_window_check)
3996 (delete_deletable_window, resize_root_window)
3997 (resize_frame_windows): Declare prototypes.
3998
3999 * window.c (resize_window_apply): Make definition be "static" to
4000 match the prototype.
4001
562dd5e9
MR
40022011-06-10 Martin Rudalics <rudalics@gmx.at>
4003
4004 * window.c: Remove declarations of Qwindow_size_fixed,
4005 window_min_size_1, window_min_size_2, window_min_size,
4006 size_window, window_fixed_size_p, enlarge_window, delete_window.
4007 Remove static from declaration of Qdelete_window, it's
4008 temporarily needed by Fbury_buffer.
4009 (replace_window): Don't assign orig_top_line and
4010 orig_total_lines.
4011 (Fdelete_window, delete_window): Remove. Window deletion is
4012 handled by window.el.
640c8776
SM
4013 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4014 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
4015 (Fdelete_other_windows): Remove. Deleting other windows is
4016 handled by window.el.
4017 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4018 handled in window.el.
4019 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4020 Window minimum sizes are handled in window.el.
4021 (shrink_windows, size_window, set_window_height)
4022 (set_window_width, change_window_heights, window_height)
4023 (window_width, CURBEG, CURSIZE, enlarge_window)
4024 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4025 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4026 handled in window.el.
4027 (make_dummy_parent): Rename to make_parent_window and give it a
4028 second argument horflag.
4029 (make_window): Don't set resize_proportionally any more.
4030 (Fsplit_window): Remove. Windows are split in window.el.
4031 (save_restore_action, save_restore_orig_size)
4032 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4033 Resize mini windows in window.el.
4034 (grow_mini_window, shrink_mini_window): Implement by calling
4035 Qresize_root_window_vertically, resize_window_check and
4036 resize_window_apply.
640c8776
SM
4037 (saved_window, Fset_window_configuration, save_window_save):
4038 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
4039 resize_proportionally.
4040 (window_min_height, window_min_width): Move to window.el.
4041 (keys_of_window): Move bindings for delete-other-windows,
4042 split-window, delete-window and enlarge-window to window.el.
4043
4044 * buffer.c: Temporarily extern Qdelete_window.
4045 (Fbury_buffer): Temporarily call Qdelete_window instead of
4046 Fdelete_window (Fbury_buffer will move to window.el soon).
4047
4048 * frame.c (set_menu_bar_lines_1): Remove code handling
4049 orig_top_line and orig_total_lines.
4050
4051 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4052 set_window_height but set heights directly.
4053 (change_frame_size_1): Use resize_frame_windows.
4054
4055 * xdisp.c (init_xdisp): Don't use set_window_height but set
4056 heights directly.
4057
640c8776
SM
4058 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4059 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
4060 run_window_configuration_change_hook.
4061
4062 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4063 instead of change_window_heights and run
4064 run_window_configuration_change_hook.
4065
1a13852e
MR
40662011-06-09 Martin Rudalics <rudalics@gmx.at>
4067
4068 * window.c (replace_window): Rename second argument REPLACEMENT to
4069 NEW. New third argument SETFLAG. Rewrite.
4070 (delete_window, make_dummy_parent): Call replace_window with
4071 third argument 1.
4072 (window_list_1): Move down in code.
4073 (run_window_configuration_change_hook): Move set_buffer part
4074 before select_frame_norecord part in order to unwind correctly.
4075 Rename count1 to count.
4076 (recombine_windows, delete_deletable_window, resize_root_window)
4077 (Fdelete_other_windows_internal)
4078 (Frun_window_configuration_change_hook, make_parent_window)
4079 (resize_window_check, resize_window_apply, Fresize_window_apply)
4080 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
4081 (Fdelete_window_internal, Fresize_mini_window_internal):
4082 New functions.
1a13852e
MR
4083 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4084
f3d1777e
MR
40852011-06-08 Martin Rudalics <rudalics@gmx.at>
4086
496e208e
MR
4087 * window.h (window): Add some new members to window structure -
4088 normal_lines, normal_cols, new_total, new_normal, clone_number,
4089 splits, nest, prev_buffers, next_buffers.
4090 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 4091 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 4092
f3d1777e
MR
4093 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4094 Remove.
496e208e
MR
4095 (make_dummy_parent): Set new members of windows structure.
4096 (make_window): Move down in code. Handle new members of window
4097 structure.
4098 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4099 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4100 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4101 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
4102 (Fset_window_next_buffers, Fset_window_clone_number):
4103 New functions.
496e208e
MR
4104 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4105 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4106 Doc-string fixes.
4107 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4108 Argument WINDOW can be now internal window too.
4109 (Fwindow_use_time): Move up in code.
4110 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4111 Rewrite doc-string.
4112 (Fset_window_configuration, saved_window)
4113 (Fcurrent_window_configuration, save_window_save): Handle new
4114 members of window structure.
b9e809c2
MR
4115 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4116 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4117 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4118 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4119 Qget_mru_window, Qresize_root_window,
4120 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4121 Qauto_buffer_name; staticpro them.
f3d1777e 4122
abde8f8c
MR
41232011-06-07 Martin Rudalics <rudalics@gmx.at>
4124
4125 * window.c (Fwindow_total_size, Fwindow_left_column)
4126 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4127 (Fwindow_list_1): New functions.
4128 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
4129 (Fwindow_width, Fscroll_left, Fscroll_right):
4130 Use window_body_cols instead of window_box_text_cols.
4131 (delete_window, Fset_window_configuration):
4132 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
4133 (delete_all_subwindows): Take a window as argument and not a
4134 structure. Rewrite.
190b47e6
MR
4135 (window_loop): Remove handling of GET_LRU_WINDOW and
4136 GET_LARGEST_WINDOW.
4137 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
4138
4139 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
4140 window_box_text_cols. delete_all_subwindows now takes a
4141 Lisp_Object as argument.
abde8f8c 4142
640c8776
SM
4143 * indent.c (compute_motion, Fcompute_motion):
4144 Use window_body_cols instead of window_box_text_cols.
abde8f8c 4145
fa8a67e6
MR
4146 * frame.c (delete_frame): Call delete_all_subwindows with root
4147 window as argument.
4148
a54e3482
DC
41492011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4150
4151 * fns.c (Fputhash): Document return value.
4152
60002bf5
CY
41532011-06-06 Chong Yidong <cyd@stupidchicken.com>
4154
4155 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4156
0c671da6 41572011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 4158
b862a52a 4159 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 4160
be44ca6c
PE
4161 Check for overflow when converting integer to cons and back.
4162 * charset.c (Fdefine_charset_internal, Fdecode_char):
4163 Use cons_to_unsigned to catch overflow.
4164 (Fencode_char): Use INTEGER_TO_CONS.
4165 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4166 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4167 * data.c (long_to_cons, cons_to_long): Remove.
4168 (cons_to_unsigned, cons_to_signed): New functions.
4169 These signal an error for invalid or out-of-range values.
4170 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4171 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4172 * font.c (Ffont_variation_glyphs):
4173 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4174 * lisp.h: Include <intprops.h>.
4175 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4176 (cons_to_signed, cons_to_unsigned): New decls.
4177 (long_to_cons, cons_to_long): Remove decls.
4178 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4179 (Fprimitive_undo): Use CONS_TO_INTEGER.
4180 * xfns.c (Fx_window_property): Likewise.
4181 * xselect.c: Include <limits.h>.
4182 (x_own_selection, selection_data_to_lisp_data):
4183 Use INTEGER_TO_CONS.
4184 (x_handle_selection_request, x_handle_selection_clear)
4185 (x_get_foreign_selection, Fx_disown_selection_internal)
4186 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4187 (lisp_data_to_selection_data): Use cons_to_unsigned.
4188 (x_fill_property_data): Use cons_to_signed.
4189 Report values out of range.
4190
d1f3d2af
PE
4191 Check for buffer and string overflow more precisely.
4192 * buffer.h (BUF_BYTES_MAX): New macro.
4193 * lisp.h (STRING_BYTES_MAX): New macro.
4194 * alloc.c (Fmake_string):
4195 * character.c (string_escape_byte8):
4196 * coding.c (coding_alloc_by_realloc):
4197 * doprnt.c (doprnt):
4198 * editfns.c (Fformat):
4199 * eval.c (verror):
4200 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4201 since they may not be the same number.
4202 * editfns.c (Finsert_char):
4203 * fileio.c (Finsert_file_contents):
4204 Likewise for BUF_BYTES_MAX.
4205
dd52fcea
PE
4206 * image.c: Use ptrdiff_t, not int, for sizes.
4207 (slurp_file): Switch from int to ptrdiff_t.
4208 All uses changed.
4209 (slurp_file): Check that file size fits in both size_t (for
4210 malloc) and ptrdiff_t (for sanity and safety).
4211
7f9bbdbb
PE
4212 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4213 if b->modtime has its maximal value.
4214
dfe18f82
PE
4215 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4216
84acfcf0
PE
4217 Don't assume time_t can fit into int.
4218 * buffer.h (struct buffer.modtime): Now time_t, not int.
4219 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4220 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4221
ccd9a01a
PE
4222 Minor fixes for signed vs unsigned integers.
4223 * character.h (MAYBE_UNIFY_CHAR):
4224 * charset.c (maybe_unify_char):
4225 * keyboard.c (read_char, reorder_modifiers):
4226 XINT -> XFASTINT, since the integer must be nonnegative.
4227 * ftfont.c (ftfont_spec_pattern):
4228 * keymap.c (access_keymap, silly_event_symbol_error):
4229 XUINT -> XFASTINT, since the integer must be nonnegative.
4230 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4231 since it makes no difference and we prefer signed.
4232 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4233 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4234 nonnegative.
4235
d6d100dd
SM
42362011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4237
4238 * window.h (Fwindow_frame): Declare.
4239
2b6148e4
PE
42402011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4241
4242 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4243 (SPARE_MEMORY): Always define.
4244 (LARGE_REQUEST): Remove.
4245 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4246
f230ecc9
MR
42472011-06-06 Martin Rudalics <rudalics@gmx.at>
4248
727e958e
MR
4249 * lisp.h: Move EXFUNS for Fframe_root_window,
4250 Fframe_first_window and Fset_frame_selected_window to window.h.
4251
4252 * window.h: Move EXFUNS for Fframe_root_window,
4253 Fframe_first_window and Fset_frame_selected_window here from
4254 lisp.h.
4255
4256 * frame.c (Fwindow_frame, Fframe_first_window)
4257 (Fframe_root_window, Fframe_selected_window)
4258 (Fset_frame_selected_window): Move to window.c.
4259 (Factive_minibuffer_window): Move to minibuf.c.
4260 (Fother_visible_frames_p): New function.
4261
4262 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4263
f230ecc9
MR
4264 * window.c (decode_window, decode_any_window): Move up in code.
4265 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4266 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
4267 (Fwindow_buffer): Move up and rewrite doc-string.
4268 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4269 (Fwindow_prev): New functions.
727e958e
MR
4270 (Fwindow_frame): Move here from frame.c. Accept any window as
4271 argument.
4272 (Fframe_root_window, Fframe_first_window)
4273 (Fframe_selected_window): Move here from frame.c. Accept frame
4274 or arbitrary window as argument. Update doc-strings.
4275 (Fminibuffer_window): Move up in code.
4276 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
4277 (Fset_frame_selected_window): Move here from frame.c.
4278 Marginal rewrite.
727e958e
MR
4279 (Fselected_window, select_window, Fselect_window): Move up in
4280 code. Minor doc-string fixes.
f230ecc9 4281
4d09bcf6
PE
42822011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4283
4284 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4285 Do not assume that spare memory exists; that assumption is valid
4286 only if SYSTEM_MALLOC.
4287 (LARGE_REQUEST): New macro, so that the issue of large requests
4288 is separated from the issue of spare memory.
4289
810928a2
AS
42902011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4291
172418ad
AS
4292 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4293 format. (Bug#8806)
4294
43f862f7
AS
4295 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4296
810928a2
AS
4297 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4298 before statements.
4299
a059fe24
JD
43002011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4301
4302 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4303
4304 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4305
4306 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4307 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4308
989bf368
JB
43092011-06-05 Juanma Barranquero <lekktu@gmail.com>
4310
4311 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4312
4b80f674
CY
43132011-06-04 Chong Yidong <cyd@stupidchicken.com>
4314
4315 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4316 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
4317 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4318 New error handlers.
4b80f674
CY
4319 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4320 Obey Vx_select_enable_clipboard_manager. Catch errors in
4321 x_clipboard_manager_save (Bug#8779).
4322 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 4323 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 4324
99a33b77 43252011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
4326
4327 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4328
99a33b77 43292011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
4330
4331 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4332 in the current matrix if keep_current_p is non-zero.
4333
8264569d
EZ
43342011-06-04 Eli Zaretskii <eliz@gnu.org>
4335
4336 * bidi.c (bidi_level_of_next_char): Fix last change.
4337
57f97249
EZ
43382011-06-03 Eli Zaretskii <eliz@gnu.org>
4339
fec2107c 4340 Support bidi reordering of text covered by display properties.
57f97249 4341
fec2107c
EZ
4342 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4343 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4344 (bidi_cache_search, bidi_cache_iterator_state)
4345 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
4346 (bidi_level_of_next_char, bidi_move_to_visually_next):
4347 Support character positions inside a run of characters covered by a
fec2107c
EZ
4348 display string.
4349 (bidi_paragraph_init, bidi_resolve_explicit_1)
4350 (bidi_level_of_next_char): Call bidi_fetch_char and
4351 bidi_fetch_char_advance instead of FETCH_CHAR and
4352 FETCH_CHAR_ADVANCE.
4353 (bidi_init_it): Initialize new members.
4354 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4355 definitions.
4356 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4357 instead of using explicit *_CHAR codes.
d6d100dd
SM
4358 (bidi_resolve_explicit, bidi_resolve_weak):
4359 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
4360 bidirectional text is supported only in multibyte buffers.
4361 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4362 it to initialize the frame_window_p member of struct bidi_it.
4363 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4364 (bidi_resolve_explicit, bidi_resolve_weak)
4365 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4366 bidi_it->nchars is non-positive.
4367 (bidi_level_of_next_char): Don't try to lookup the cache for the
4368 next/previous character if nothing is cached there yet, or if we
4369 were just reseat()'ed to a new position.
c40e2fb2 4370
0e14fe90
EZ
4371 * xdisp.c (set_cursor_from_row): Set start and stop points
4372 according to the row's direction when priming the loop that looks
4373 for the glyph on which to display cursor.
4374 (single_display_spec_intangible_p): Function deleted.
4375 (display_prop_intangible_p): Reimplement to call
4376 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
4377 Accept 3 additional arguments needed by handle_display_spec.
4378 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
4379 values: lists, `(when COND...)' forms, etc.
4380 (single_display_spec_string_p): Support property values that are
4381 lists with the argument STRING its top-level element.
4382 (display_prop_string_p): Fix the condition for processing a
4383 property that is a list to be consistent with handle_display_spec.
fec2107c 4384 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
4385 last portion of handle_display_prop.
4386 (compute_display_string_pos): Accept additional argument
4387 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4388 value of a `display' property is a "replacing spec".
4389 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4390 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4391 the display property, but just return a value indicating whether
4392 the display property will replace the characters it covers.
4393 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4394 frame_window_p members of struct bidi_it.
d6d100dd
SM
4395 (compute_display_string_pos, compute_display_string_end):
4396 New functions.
fec2107c
EZ
4397 (push_it): Accept second argument POSITION, where pop_it should
4398 jump to continue iteration.
4399 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 4400
fec2107c
EZ
4401 * keyboard.c (adjust_point_for_property): Adjust the call to
4402 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
4403
4404 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
4405 (bidi_init_it): Update prototypes.
4406 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
4407 (compute_display_string_pos, compute_display_string_end):
4408 Declare prototypes.
fec2107c
EZ
4409 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4410 EMACS_INT.
fc6f18ce 4411
40087514 44122011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 4413
57f53182
PE
4414 Malloc failure behavior now depends on size of allocation.
4415 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4416 * lisp.h: Change signatures accordingly.
4417 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4418 All callers changed. (Bug#8762)
4419
4420 * gnutls.c: Use Emacs's memory allocators.
4421 Without this change, the gnutls library would invoke malloc etc.
4422 directly, which causes problems on non-SYNC_INPUT hosts, and which
4423 runs afoul of improving memory_full behavior. (Bug#8761)
4424 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4425 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4426 xfree instead of the default malloc, realloc, free.
4427 (Fgnutls_boot): No need to check for memory allocation failure,
4428 since xmalloc does that for us.
4429
ac32cd99 4430 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
4431 * category.c (hash_get_category_set):
4432 * ccl.c (ccl_driver):
4433 * charset.c (Fdefine_charset_internal):
4434 * charset.h (struct charset.hash_index):
4435 * composite.c (get_composition_id, gstring_lookup_cache)
4436 (composition_gstring_put_cache):
4437 * composite.h (struct composition.hash_index):
4438 * dispextern.h (struct image.hash):
4439 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4440 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4441 (hashfn_equal, hashfn_user_defined, make_hash_table)
4442 (maybe_resize_hash_table, hash_lookup, hash_put)
4443 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4444 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4445 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4446 * image.c (make_image, search_image_cache, lookup_image)
4447 (xpm_put_color_table_h):
4448 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 4449 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 4450 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 4451 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
4452 * alloc.c (allocate_vectorlike):
4453 Check for overflow in vector size calculations.
4454 * ccl.c (ccl_driver):
4455 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
4456 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4457 need to be updated by these changes.
40087514
PE
4458 * fns.c (make_hash_table, maybe_resize_hash_table):
4459 Check for integer overflow with large hash tables.
0de4bb68
PE
4460 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4461 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4462 (SXHASH_REDUCE): New macro.
4463 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4464 Use it instead of discarding useful hash info with large hash values.
4465 (sxhash_float): New function.
4466 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4467 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
4468 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4469 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
4470 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4471 Adjust signatures to match updated version of code.
4472 (consing_since_gc): Now EMACS_INT, since a single hash table can
4473 use more than INT_MAX bytes.
4474
698d32e2
DN
44752011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4476
4477 Make it possible to build with GCC-4.6+ -O2 -flto.
4478
4479 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4480
fd6fa53f
SM
44812011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4482
4483 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4484 Call minibuffer-inactive-mode.
4485
864db017
JB
44862011-05-31 Juanma Barranquero <lekktu@gmail.com>
4487
4488 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4489 Update dependencies.
4490
2ad0baf4
DN
44912011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4492
4493 * data.c (init_data): Remove code for UTS, this system is not
4494 supported anymore.
4495
4fcc2638
DN
44962011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4497
4498 Don't force ./temacs to start in terminal mode.
4499
4500 * frame.c (make_initial_frame): Initialize faces in all cases, not
4501 only when CANNOT_DUMP is defined.
4502 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4503
c56e0fd5
DN
45042011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4505
4506 * dispnew.c (add_window_display_history): Use const for the string
4507 pointer. Remove declaration, not needed.
4508
333d54da 45092011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 4510
55d4c1b2 4511 Use 'inline', not 'INLINE'.
333d54da 4512 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
4513 * alloc.c, fontset.c (INLINE): Remove.
4514 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4515 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4516 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4517 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4518 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4519
738db178
DN
45202011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4521
4522 Make it possible to run ./temacs.
4523
4524 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4525 syms_of_callproc does the same thing. Remove test for
4526 "initialized", do it in the caller.
4527 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4528
620c53a6
SM
45292011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4530
4531 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4532 (read_minibuf): Use get_minibuffer.
4533 (syms_of_minibuf): Use DEFSYM.
4534 (Qmetadata): New var.
4535 * data.c (Qbuffer): Don't make it static.
4536 (syms_of_data): Use DEFSYM.
4537
e003a292
PE
45382011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4539
4540 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4541 (CCL_CODE_MIN): New macro.
4542
ed008a6d
PE
45432011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4544
3687c2ef
PE
4545 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4546
ed008a6d
PE
4547 * eval.c (Qdebug): Now static.
4548 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4549 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4550 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4551
d66c4c7c
CY
45522011-05-29 Chong Yidong <cyd@stupidchicken.com>
4553
4554 * image.c: Various fixes to ImageMagick code comments.
4555 (Fimagemagick_types): Doc fix.
4556
5fbc2025
PE
45572011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4558
0196f88a
PE
4559 Minor fixes prompted by GCC 4.6.0 warnings.
4560
4561 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4562
5fbc2025
PE
4563 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4564 (x_clipboard_manager_save_all): Move extern decl to ...
4565 * xterm.h: ... here, so that it can be checked for consistency.
4566
1dd3c2d9
CY
45672011-05-29 Chong Yidong <cyd@stupidchicken.com>
4568
4569 * xselect.c (x_clipboard_manager_save_frame)
4570 (x_clipboard_manager_save_all): New functions.
4571 (Fx_clipboard_manager_save): Lisp function deleted.
4572
4573 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4574 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4575
4576 * xterm.h: Update prototype.
4577
5ba6571d
WX
45782011-05-28 William Xu <william.xwl@gmail.com>
4579
4580 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4581 exiting (Bug#8239).
4582
3eaff834
JM
45832011-05-28 Jim Meyering <meyering@redhat.com>
4584
e1900994 4585 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
4586 * fns.c (to_uchar): Define.
4587 (crypto_hash_function): Use it to convert some newly-signed
4588 variables to unsigned, to avoid sign-extension bugs. For example,
4589 without this change, (md5 "truc") would evaluate to
4590 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4591 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 4592 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 4593
0f6990a7
PE
45942011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4595
4596 Integer overflow fixes.
c8a9ca5a 4597
08686060
PE
4598 * dbusbind.c: Serial number integer overflow fixes.
4599 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
4600 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4601 to hold a serial number that is too large for a fixnum.
4602 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4603 Check for serial numbers out of range. Decode any serial number
59568bf0 4604 that was so large that it became a float. (Bug#8722)
08686060 4605
2d1fc3c7
PE
4606 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4607 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4608 Use XFASTINT rather than XUINT when numbers are nonnegative.
4609 (xd_append_arg, Fdbus_method_return_internal):
4610 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4611 arguments, check that Lisp number is nonnegative, rather than
59568bf0 4612 silently wrapping negative numbers around. (Bug#8722)
30217ff0 4613 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 4614 (Bug#8722)
2d1fc3c7 4615
c8a9ca5a
PE
4616 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4617
519e1d69
PE
4618 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4619
30569699
PE
4620 ccl: add integer overflow checks
4621 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4622 (IN_INT_RANGE): New macros.
4623 (ccl_driver): Use them to check for integer overflow when
4624 decoding a CCL program. Many of the new checks are whether XINT (x)
4625 fits in int; it doesn't always, on 64-bit hosts. The new version
4626 doesn't catch all possible integer overflows, but it's an
847044ea 4627 improvement. (Bug#8719)
30569699 4628
c11285dc
PE
4629 * alloc.c (make_event_array): Use XINT, not XUINT.
4630 There's no need for unsigned here.
4631
fdccd48e
PE
4632 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4633 This follows up to the 2011-05-06 change that substituted uintptr_t
4634 for EMACS_INT. This case wasn't caught back then.
4635
37910ab2
PE
4636 Rework Fformat to avoid integer overflow issues.
4637 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4638 now (part of C89). Include <verify.h>.
4639 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4640 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4641 (Fformat): Avoid the prepass trying to compute sizes; it was only
4642 approximate and thus did not catch overflow reliably. Instead, walk
4643 through the format just once, formatting and computing sizes as we go,
4644 checking for integer overflow at every step, and allocating a larger
4645 buffer as needed. Keep track separately whether the format is
4646 multibyte. Keep only the most-recently calculated precision, rather
4647 than them all. Record whether each argument has been converted to
4648 string. Use EMACS_INT, not int, for byte and char and arg counts.
4649 Support field widths and precisions larger than INT_MAX. Avoid
4650 sprintf's undefined behavior with conversion specifications such as %#d
4651 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4652 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4653 formatting out-of-range floating point numbers with int
9173deec 4654 formats. (Bug#8668)
37910ab2 4655
2e6578fb
PE
4656 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4657
0ae6bdee
PE
4658 * data.c: Avoid integer truncation in expressions involving floats.
4659 * data.c: Include <intprops.h>.
4660 (arith_driver): When there's an integer overflow in an expression
4661 involving floating point, convert the integers to floating point
4662 so that the resulting value does not suffer from catastrophic
4663 integer truncation. For example, on a 64-bit host (* 4
4664 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4665 Do not rely on undefined behavior after integer overflow.
4666
de883a70
PE
4667 merge count_size_as_multibyte, parse_str_to_multibyte
4668 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 4669 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
4670 Check for integer overflow.
4671 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4672 since it's now a duplicate of the other. This is more of
4673 a character than a buffer op, so better that it's in character.c.
4674 * fns.c, print.c: Adjust to above changes.
4675
2ff916cb
PE
46762011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4677
4678 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4679
f1b54466
PE
46802011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4681
fb1ac845
PE
4682 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4683 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4684 (x_clipboard_manager_save): Now static.
4685 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4686
f1b54466
PE
4687 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4688 (crypto_hash_function): Now static.
4689 Fix pointer signedness problems. Avoid unnecessary initializations.
4690
a9f737ee
CY
46912011-05-27 Chong Yidong <cyd@stupidchicken.com>
4692
4693 * termhooks.h (Vselection_alist): Make it terminal-local.
4694
4695 * terminal.c (create_terminal): Initialize it.
4696
4697 * xselect.c: Support for clipboard managers.
4698 (Vselection_alist): Move to termhooks.h as terminal-local var.
4699 (LOCAL_SELECTION): New macro.
4700 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4701 (symbol_to_x_atom): Remove gratuitous arg.
4702 (x_handle_selection_request, lisp_data_to_selection_data)
4703 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
4704 (x_own_selection, x_get_local_selection, x_convert_selection):
4705 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
4706 (some_frame_on_display): Delete unused function.
4707 (Fx_own_selection_internal, Fx_get_selection_internal)
4708 (Fx_disown_selection_internal, Fx_selection_owner_p)
4709 (Fx_selection_exists_p): New optional frame arg.
4710 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4711 (x_handle_selection_clear): Don't treat other terminals with the
4712 same keyboard specially. Use the terminal-local Vselection_alist.
4713 (x_clear_frame_selections): Use Frun_hook_with_args.
4714
4715 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4716
4717 * xterm.h: Add support for those atoms.
4718
e067f0c1
CY
47192011-05-26 Chong Yidong <cyd@stupidchicken.com>
4720
4721 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4722 (converted_selections, conversion_fail_tag): New global variables.
4723 (x_selection_request_lisp_error): Free the above.
4724 (x_get_local_selection): Remove unnecessary code.
4725 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
4726 of converted selections stored in converted_selections.
4727 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
4728 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4729 (x_convert_selection): New function.
4730 (x_handle_selection_event): Simplify.
4731 (x_get_foreign_selection): Don't ignore incoming requests while
4732 waiting for an answer; this will fail when we implement
4733 SAVE_TARGETS, and seems unnecessary anyway.
4734 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4735 (Vx_sent_selection_functions): Doc fix.
4736
0f4aebc0
LL
47372011-05-26 Leo Liu <sdl.web@gmail.com>
4738
4739 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4740
e61124cd
YM
47412011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4742
4743 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4744
4745 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4746 for fringe update if it has periodic bitmap.
ac389d0c 4747 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
4748 and fringe_bitmap_periodic_p.
4749
4750 * fringe.c (get_fringe_bitmap_data): New function.
4751 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4752 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4753 row. Mark glyph row for fringe update if periodicity changed.
4754
4755 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4756 for fringe update unless it has periodic bitmap.
4757
f16d9837
KH
47582011-05-25 Kenichi Handa <handa@m17n.org>
4759
4760 * xdisp.c (get_next_display_element): Set correct it->face_id for
4761 a static composition.
4762
e1b90ef6
LL
47632011-05-24 Leo Liu <sdl.web@gmail.com>
4764
4765 * deps.mk (fns.o):
4766 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4767
4768 * fns.c (crypto_hash_function, Fsha1): New function.
4769 (Fmd5): Use crypto_hash_function.
4770 (syms_of_fns): Add Ssha1.
4771
7400048f
PE
47722011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4773
4774 * gnutls.c: Remove unused macros.
4775 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4776 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4777 Remove macros that are defined and never used.
4778 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4779
abb71cf4
CY
47802011-05-22 Chong Yidong <cyd@stupidchicken.com>
4781
4782 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4783 (Fx_get_selection_internal): Minor cleanup.
4784 (Fx_own_selection_internal): Rename arguments for consistency with
4785 select.el.
4786
6307db39
PE
47872011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4788
4789 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4790
f3d4e0a4
CY
47912011-05-22 Chong Yidong <cyd@stupidchicken.com>
4792
4793 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4794
4d8ade89
YM
47952011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4796
4797 * dispnew.c (scrolling_window): Don't exclude the case that the
4798 last enabled row in the desired matrix touches the bottom boundary.
4799
32078c8d
GM
48002011-05-21 Glenn Morris <rgm@gnu.org>
4801
4802 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
4803 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4804 and add some more files.
32078c8d 4805
7285dc67
EZ
48062011-05-20 Eli Zaretskii <eliz@gnu.org>
4807
4808 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4809 report_file_error introduced by the change from 2011-05-07.
4810
89d1bd22
PE
48112011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4812
4813 * systime.h (Time): Define only if emacs is defined.
4814 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4815 where the include path doesn't have X11/X.h by default. See
4816 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4817
e23640bb 48182011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
4819
4820 * composite.c (find_automatic_composition): Fix previous change.
4821
b9704ad9
GM
48222011-05-20 Glenn Morris <rgm@gnu.org>
4823
4824 * lisp.mk: New file, split from Makefile.in.
4825 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4826 (shortlisp): Remove.
4827 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4828
4a720484
GM
48292011-05-19 Glenn Morris <rgm@gnu.org>
4830
4831 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4832 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4833 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4834 (lisp): Set the order to that of loadup.el.
4835 (shortlisp): Make it a copy of $lisp.
4836 (SOME_MACHINE_LISP): Remove.
4837 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4838 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4839
a28d4396
KH
48402011-05-18 Kenichi Handa <handa@m17n.org>
4841
4842 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4843 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4844 (find_automatic_composition): Mostly rewrite for efficiency.
4845
a2b1fa8e
JB
48462011-05-18 Juanma Barranquero <lekktu@gmail.com>
4847
4848 * makefile.w32-in: Update dependencies.
4849
8e1f5610
CS
48502011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4851
4852 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 4853 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 4854
7025ee00 48552011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 4856
cdfa6eab
PE
4857 Fix some integer overflow issues, such as string length overflow.
4858
06d6db33
PE
4859 * insdel.c (count_size_as_multibyte): Check for string overflow.
4860
2b4560a8
PE
4861 * character.c (lisp_string_width): Check for string overflow.
4862 Use EMACS_INT, not int, for string indexes and lengths; in
4863 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4864 the resulting string length overflows an EMACS_INT; instead,
4865 report a string overflow if no precision given. When checking for
4866 precision exhaustion, use a check that cannot possibly have
4867 integer overflow. (Bug#8675)
4868 * character.h (lisp_string_width): Adjust to new signature.
4869
cb93f9be
PE
4870 * alloc.c (string_overflow): New function.
4871 (Fmake_string): Use it. This doesn't change behavior, but saves
4872 a few bytes and will simplify future changes.
4873 * character.c (string_escape_byte8): Likewise.
4874 * lisp.h (string_overflow): New decl.
4875
1a1f3366
PE
4876 Fixups, following up to the user-interface timestamp change.
4877 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4878 for UI timestamps, instead of unsigned long.
9fbd6841
PE
4879 * msdos.c (mouse_get_pos): Likewise.
4880 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
4881 * w32gui.h (Time): Define by including "systime.h" rather than by
4882 declaring it ourselves. (Bug#8664)
4883
d4e3e4d3
PE
4884 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4885 * image.c (clear_image_cache): Likewise.
4886
f6a24d19
PE
4887 * term.c (term_mouse_position): Don't assume time_t wraparound.
4888
08dc5ae6
PE
4889 Be more systematic about user-interface timestamps.
4890 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
4891 and sometimes 'EMACS_UINT', to represent these timestamps.
4892 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
4893 This makes the code easier to follow, and makes it easier to catch
4894 integer overflow bugs such as Bug#8664.
4895 * frame.c (Fmouse_position, Fmouse_pixel_position):
4896 Use Time, not unsigned long, for user-interface timestamps.
4897 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4898 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4899 * keyboard.h (last_event_timestamp): Likewise.
4900 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4901 * menu.h (xmenu_show): Likewise.
4902 * term.c (term_mouse_position): Likewise.
4903 * termhooks.h (struct input_event.timestamp): Likewise.
4904 (struct terminal.mouse_position_hook): Likewise.
4905 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4906 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4907 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4908 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4909 what it was before.
4910 * menu.h, termhooks.h: Include "systime.h", for Time.
4911
8e55734a
PE
4912 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4913 Don't assume that the difference between two unsigned long values
4914 can fit into an integer. At this point, we know button_down_time
4915 <= event->timestamp, so the difference must be nonnegative, so
4916 there's no need to cast the result if double-click-time is
4917 nonnegative, as it should be; check that it's nonnegative, just in
4918 case. This bug is triggered when events are more than 2**31 ms
86db42d2 4919 apart (about 25 days). (Bug#8664)
8e55734a 4920
841f1b75 4921 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 4922 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 4923
3e26f69c
PE
4924 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4925 that always fit in int. Use a sentinel instead of a counter, to
4926 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
4927 * frame.h (struct frame): Use int for menu_bar_items_used
4928 instead of EMACS_INT, since it always fits in int.
3e26f69c 4929
5cc152c0
PE
4930 * menu.c (grow_menu_items): Check for int overflow.
4931
d89eb65e
PE
4932 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4933
5235bd3e
PE
4934 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4935 Before, the code was not consistent. These values cannot exceed
4936 2**31 - 1 so there's no need to make them unsigned.
4937 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4938 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4939 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4940 as modifiers.
4941 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4942
bc827e23
PE
4943 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4944 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4945 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4946 presumably because the widths might not match.
4947
78eb494e
PE
4948 * window.c (size_window): Avoid needless test at loop start.
4949
04f2d78b
CB
49502011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4951
4952 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4953
d2fc7e3d 49542011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
4955
4956 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4957
d2fc7e3d 49582011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
4959
4960 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4961 `width' to `bar_area_x' and `bar_area_width', respectively.
4962 (x_scroll_run): Take account of fringe background extension.
4963
04f2d78b
CB
4964 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4965 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
4966 `bar_area_width', respectively.
4967 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4968 background extension.
4969
79b70037
GM
49702011-05-10 Jim Meyering <meyering@redhat.com>
4971
4972 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4973
2f142cc5
JB
49742011-05-10 Juanma Barranquero <lekktu@gmail.com>
4975
4976 * image.c (Finit_image_library): Return t for built-in image types,
4977 like pbm and xbm. (Bug#8640)
4978
57679c86
AS
49792011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4980
4981 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4982
888c9e86
EZ
49832011-05-07 Eli Zaretskii <eliz@gnu.org>
4984
b0512a1d
EZ
4985 * w32console.c (Fset_screen_color): Doc fix.
4986 (Fget_screen_color): New function.
4987 (syms_of_ntterm): Defsubr it.
4988
7285dc67
EZ
4989 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4990 unlink the temporary file if Fcall_process didn't create it in the
4991 first place.
4992 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4993 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
4994 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4995 cue to call_process_cleanup not to close that handle.
4996
4d3fcc8e
BK
49972011-05-07 Ben Key <bkey76@gmail.com>
4998
4999 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5000 one of two shell specific rules, either bootstrap-temacs-CMD or
5001 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5002 to the previous implementation of the bootstrap-temacs rule.
5003 The bootstrap-temacs-CMD rule is similar to the previous
5004 implementation of the bootstrap-temacs rule except that it
5005 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5006 variable.
5007
5008 These changes, along with some changes to nt/configure.bat,
5009 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5010 earlier fix to add support for --cflags and --ldflags options
5011 that include quotes so that it works whether make uses cmd or
5012 sh as the shell.
5013
b4289b64
MA
50142011-05-06 Michael Albinus <michael.albinus@gmx.de>
5015
5016 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5017 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5018 is a constant.
5019 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5020 a string. Handle both cases.
5021 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5022 (Fdbus_register_method): Use Qinvalid_function.
5023
af4c0e28
JB
50242011-05-06 Juanma Barranquero <lekktu@gmail.com>
5025
5026 * makefile.w32-in: Update dependencies.
5027 (LISP_H): Add inttypes.h and stdin.h.
5028 (PROCESS_H): Add unistd.h.
5029
c51453d9
EZ
50302011-05-06 Eli Zaretskii <eliz@gnu.org>
5031
5032 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5033 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5034
8ff0ac3c 50352011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 5036
4c4b566b
PE
5037 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5038
aab2b9b5
PE
5039 * term.c (vfatal): Remove stray call to va_end.
5040 It's not needed and the C Standard doesn't allow it here anyway.
5041
c378da0b
PE
5042 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5043 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5044
288b08c7
PE
5045 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5046 bytes.
5047
e3601888
PE
5048 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5049
db6c0e74
PE
5050 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5051
dd5963ea
PE
5052 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5053
88c9450f
PE
5054 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5055
2f9442b8
PE
5056 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5057
c032b5f8
PE
5058 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5059 * charset.c (Fdefine_charset_internal): Don't initialize
5060 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 5061 32-bit int (Bug#8600).
a108c10b
PE
5062
5063 * lread.c (read_integer): Be more consistent with string-to-number.
5064 Use string_to_number to do the actual conversion; this avoids
5065 rounding errors and fixes some other screwups. Without this fix,
5066 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5067 (digit_to_number): Move earlier, for benefit of read_integer.
5068 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 5069 not a digit in any supported base. (Bug#8602)
a108c10b 5070
ad5f9eea
PE
5071 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5072
aec1708a
PE
5073 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5074 to match comment at start of function. This also removes a
5075 GCC warning about overflow in a 32+64-bit port.
5076
47be4ab5
PE
5077 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5078
371cac43
PE
5079 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5080 Reported by Stefan Monnier in
5081 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
5082 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5083 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 5084
d01a7826
PE
5085 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5086 (EMACS_UINTPTR): Likewise, with uintptr_t.
5087
7fd47d5c
PE
5088 * lisp.h: Prefer 64-bit EMACS_INT if available.
5089 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5090 on 32-bit hosts that have 64-bit int, so that they can access
5091 large files.
122b0c86
PE
5092 However, temporarily disable this change unless the temporary
5093 symbol WIDE_EMACS_INT is defined.
7fd47d5c 5094
8727937b
PE
5095 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5096
8ac068ac
PE
5097 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5098 This removes an assumption that EMACS_INT and long are the same
5099 width as pointers. The assumption is true for Emacs porting targets
5100 now, but we want to make other targets possible.
5101 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5102 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5103 In the rest of the code, change types of integers that hold casted
5104 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5105 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5106 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5107 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5108 No need to cast type when ORing.
5109 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5110 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5111 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5112 assume EMACS_INT is the same width as char *.
5113 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5114 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5115 Remove no-longer-needed casts.
5116 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5117 (xg_tool_bar_help_callback, xg_make_tool_item):
5118 Use EMACS_INTPTR to hold an integer
5119 that will be cast to void *; this can avoid a GCC warning
5120 if EMACS_INT is not the same width as void *.
5121 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5122 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5123 (current_message_1, set_message_1):
5124 Use a local to convert to proper width without a cast.
5125 * xmenu.c (dialog_selection_callback): Likewise.
5126
ede49d71
PE
5127 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5128 Also, don't assume VALBITS / RAND_BITS is less than 5,
5129 and don't rely on undefined behavior when shifting a 1 left into
5130 the sign bit.
5131 * lisp.h (get_random): Change signature to match.
5132
2f30ecd0
PE
5133 * lread.c (hash_string): Use size_t, not int, for hash computation.
5134 Normally we prefer signed values; but hashing is special, because
5135 it's better to use unsigned division on hash table sizes so that
5136 the remainder is nonnegative. Also, size_t is the natural width
5137 for hashing into memory. The previous code used 'int', which doesn't
5138 retain enough info to hash well into very large tables.
5139 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5140
2a866e7b
PE
5141 * dbusbind.c: Don't possibly lose pointer info when converting.
5142 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5143 Use XPNTR rather than XHASH, so that the high-order bits of
5144 the pointer aren't lost when converting through void *.
5145
51639eac
PE
5146 * eval.c (Fautoload): Don't double-shift a pointer.
5147
92394119
PE
5148 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5149
dbdb9a7c
JB
51502011-05-06 Juanma Barranquero <lekktu@gmail.com>
5151
5152 * gnutls.c (DEF_GNUTLS_FN):
5153 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5154
db7a0b4f
AS
51552011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5156
5157 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5158 marker. (Bug#8610)
5159
f7ff1b0f 51602011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
5161
5162 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5163 New version that can reserve upto 2GB of heap space.
5164
f7ff1b0f 51652011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
5166
5167 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5168
639c109b
TZ
51692011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5170
5171 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5172 `gnutls_certificate_set_x509_key_file'.
5173
d2127135
JB
51742011-05-05 Juanma Barranquero <lekktu@gmail.com>
5175
5176 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5177 Update dependencies.
5178
e968f4f3
JB
51792011-05-04 Juanma Barranquero <lekktu@gmail.com>
5180
5181 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5182 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5183 Remove unused parameter `fildes'.
5184 * process.c (read_process_output, send_process): Don't pass it.
5185
84d358f0
JB
51862011-05-04 Juanma Barranquero <lekktu@gmail.com>
5187
5188 Fix previous change: the library cache is defined in w32.c.
5189 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5190 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5191
0898ca10
JB
51922011-05-04 Juanma Barranquero <lekktu@gmail.com>
5193
5194 Implement dynamic loading of GnuTLS on Windows.
5195
5196 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5197 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5198 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5199 Declare.
5200
5201 * gnutls.c (Qgnutls_dll): Define.
5202 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5203 (gnutls_*): Declare function pointers.
5204 (init_gnutls_functions): New function to initialize function pointers.
5205 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5206 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5207 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5208 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5209 (emacs_gnutls_write, emacs_gnutls_read)
5210 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5211 (Fgnutls_available_p): New function.
5212 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5213 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5214 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5215
5216 * image.c: Include w32.h.
5217 (Vimage_type_cache): Delete.
5218 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5219 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5220 (w32_delayed_load): Move to w32.c.
5221
5222 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5223
5224 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5225 (w32_delayed_load): Move from image.c. When loading a library, record
5226 its filename in the :loaded-from property of the library id.
5227 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5228 Initialize and staticpro them.
5229 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5230
5231 * process.c: Include lisp.h before w32.h, not after.
5232 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5233 instead of gnutls_record_check_pending.
5234
5235 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5236
ff4de4aa
TZ
52372011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5238
5239 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5240 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5241 as passed in.
5242
abe95abb
JD
52432011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5244
5245 * xterm.c (x_set_frame_alpha): Do not set property on anything
5246 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5247
e16e55d4
JB
52482011-05-02 Juanma Barranquero <lekktu@gmail.com>
5249
5250 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5251
bafcf6a5
JB
52522011-05-02 Juanma Barranquero <lekktu@gmail.com>
5253
5254 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5255 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5256 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5257 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5258 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5259 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5260 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5261 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5262 (Qgnutls_bootprop_callbacks_verify): Make static.
5263
e7a6747f
AS
52642011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5265
19ed11ba
AS
5266 * callproc.c: Indentation fixup.
5267
e7a6747f 5268 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
5269 (wait_for_termination, interruptible_wait_for_termination):
5270 Move after wait_for_termination_1.
e7a6747f 5271
1ef14cb4
LMI
52722011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5273
5274 * sysdep.c (interruptible_wait_for_termination): New function
5275 which is like wait_for_termination, but allows keyboard
5276 interruptions.
5277
5278 * callproc.c (Fcall_process): Add (:file "file") as an option for
5279 the STDOUT buffer.
5280 (Fcall_process_region): Ditto.
5281
330d880c
EZ
52822011-04-30 Eli Zaretskii <eliz@gnu.org>
5283
8db90b73
EZ
5284 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5285 rather than `XVECTOR (FOO)->size'.
5286
330d880c
EZ
5287 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5288 inttypes.h, as a gnulib replacement is used if it not available in
5289 system headers.
5290
15cbd324
EZ
52912011-04-21 Eli Zaretskii <eliz@gnu.org>
5292
5293 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5294 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5295 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5296
5297 * coding.c (coding_alloc_by_realloc): Error out if destination
5298 will grow beyond MOST_POSITIVE_FIXNUM.
5299 (decode_coding_emacs_mule): Abort if there isn't enough place in
5300 charbuf for the composition carryover bytes. Reserve an extra
5301 space for up to 2 characters produced in a loop.
5302 (decode_coding_iso_2022): Abort if there isn't enough place in
5303 charbuf for the composition carryover bytes.
5304
53052011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 5306
ae940cca
EZ
5307 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5308 aborting when %lld or %lll format is passed.
5309 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5310 %llo or %llx format is passed. (Bug#8545)
5311
03ab8921
EZ
5312 * window.c (window_scroll_line_based): Use a marker instead of
5313 simple variables to record original value of point. (Bug#7952)
5314
afda1437
EZ
5315 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5316 produced by %s or %c overflows available buffer space. (Bug#8545)
5317
f76dee0c
PE
53182011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5319
5320 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 5321 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 5322
fdc5744d
JB
53232011-04-28 Juanma Barranquero <lekktu@gmail.com>
5324
5325 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5326
638f053a
JB
53272011-04-28 Juanma Barranquero <lekktu@gmail.com>
5328
5329 * keyboard.c (Qdelayed_warnings_hook): Define.
5330 (command_loop_1): Run `delayed-warnings-hook'
5331 if Vdelayed_warnings_list is non-nil.
5332 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5333 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5334
d178f871
EZ
53352011-04-28 Eli Zaretskii <eliz@gnu.org>
5336
5337 * doprnt.c (doprnt): Don't return value smaller than the buffer
5338 size if the message was truncated. (Bug#8545).
5339
b124fd93
JB
53402011-04-28 Juanma Barranquero <lekktu@gmail.com>
5341
5342 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5343 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5344
e810457d
PE
53452011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5346
5347 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5348
ea51cceb
JB
53492011-04-27 Juanma Barranquero <lekktu@gmail.com>
5350
5351 * makefile.w32-in: Update dependencies.
5352
94dcfacf
EZ
53532011-04-27 Eli Zaretskii <eliz@gnu.org>
5354
5355 Improve `doprnt' and its usage. (Bug#8545)
5356 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5357 `format_end'. Remove support for %l as a conversion specifier.
5358 Don't use xrealloc. Improve diagnostics when the %l size modifier
5359 is used. Update the commentary.
5360
5361 * eval.c (verror): Simplify calculation of size_t.
5362
5363 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5364 messages.
5365
f61f41d7
PE
53662011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5367
5368 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5369 change.
5370
96fb4434
PE
53712011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5372
5373 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5374 This makes this file independent of the recent pseudovector change.
5375
671875da 53762011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 5377
69e9b5a3
PE
5378 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5379
b5f869a7 5380 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 5381 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 5382 Remove unused local.
c8926152 5383 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 5384
841a1577 5385 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
5386 GCC 4.6.0 optimizes based on type-based alias analysis.
5387 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
5388 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5389 != &v->size, and therefore "v->size = 1; b->size = 2; return
5390 v->size;" must therefore return 1. This assumption is incorrect
5391 for Emacs, since it type-puns struct Lisp_Vector * with many other
5392 types. To fix this problem, this patch adds a new type struct
f904488f 5393 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
5394 and pseudovectors, and helps optimizing compilers not get fooled
5395 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5396 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
5397 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5398 the size member.
eab3844f
PE
5399 (XSETPVECTYPE): Rewrite in terms of new macro.
5400 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5401 This is a bit clearer, and further avoids the possibility of
5402 undesirable aliasing.
5403 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 5404 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
5405 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5406 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
5407 (ASIZE): Now uses header.size rather than size.
5408 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
5409 to avoid the hassle of writing XVECTOR (foo)->header.size.
5410 (struct vectorlike_header): New type.
eab3844f
PE
5411 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5412 object, to help avoid aliasing.
5413 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5414 (SUBRP): Likewise, since Lisp_Subr is a special case.
5415 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5416 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5417 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 5418 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
5419 changed to be "header.size" and "header.next".
5420 * buffer.h (struct buffer): Likewise.
5421 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5422 * frame.h (struct frame): Likewise.
5423 * process.h (struct Lisp_Process): Likewise.
5424 * termhooks.h (struct terminal): Likewise.
5425 * window.c (struct save_window_data, struct saved_window): Likewise.
5426 * window.h (struct window): Likewise.
5427 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5428 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5429 * buffer.c (init_buffer_once): Likewise.
5430 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5431 special case.
5432 * process.c (Fformat_network_address): Use local var for size,
5433 for brevity.
5434
0df1eac5
PE
5435 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5436
847ab9d1 5437 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
5438 * data.c (atof): Remove decl; no longer used or needed.
5439 (digit_to_number): Move to lread.c.
5440 (Fstring_to_number): Use new string_to_number function, to be
5441 consistent with how the Lisp reader treats infinities and NaNs.
5442 Do not assume that floating-point numbers represent EMACS_INT
5443 without losing information; this is not true on most 64-bit hosts.
5444 Avoid double-rounding errors, by insisting on integers when
5445 parsing non-base-10 numbers, as the documentation specifies.
5446 * lisp.h (string_to_number): New decl, replacing ...
5447 (isfloat_string): Remove.
bc0a5c13 5448 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 5449 (read1): Do not accept +. and -. as integers; this
452f4150
PE
5450 appears to have been a coding error. Similarly, do not accept
5451 strings like +-1e0 as floating point numbers. Do not report
5452 overflow for integer overflows unless the base is not 10 which
5453 means we have no simple and reliable way to continue.
5454 Break out the floating-point parsing into a new
5455 function string_to_number, so that Fstring_to_number parses
5456 floating point numbers consistently with the Lisp reader.
04f2d78b 5457 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
5458 (E_CHAR, EXP_INT): Remove, replacing with ...
5459 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5460 (string_to_number): New function, replacing isfloat_string.
5461 This function checks for valid syntax and produces the resulting
5462 Lisp float number too. Rework it so that string-to-number
bc0a5c13 5463 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
5464 so that overflow for non-base-10 numbers is reported only when
5465 there's no portable and simple way to convert to floating point.
452f4150 5466
67769ffc
PE
5467 * textprop.c (set_text_properties_1): Rewrite for clarity,
5468 and to avoid GCC warning about integer overflow.
5469
c20db43f
PE
5470 * intervals.h (struct interval): Use EMACS_INT for members
5471 where EMACS_UINT might cause problems. See
5472 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5473 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5474 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5475 All uses changed.
37aa2f85
PE
5476 (offset_intervals): Tell GCC not to worry about length overflow
5477 when negating a negative length.
c20db43f 5478
2538aa2f
PE
5479 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5480 (overrun_check_free): Likewise.
5481
f2d3008d
PE
5482 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5483 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5484 word size.
5485
ec8df744
PE
5486 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5487 (gnutls_make_error): Rename local to avoid shadowing.
5488 (gnutls_emacs_global_deinit): ifdef out; not used.
5489 (Fgnutls_boot): Use const for pointer to readonly storage.
5490 Comment out unused local. Fix pointer signedness problems.
5491
640ee02d
PE
5492 * lread.c (openp): Don't stuff size_t into an 'int'.
5493 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5494 about possible signed overflow.
5495
6048fb2a
PE
5496 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5497 (GDK_KEY_g): Don't define if already defined.
5498 (xg_prepare_tooltip): Avoid pointer signedness problem.
5499 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5500
fa3c87e1
PE
5501 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5502 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5503
2172544b
PE
5504 * xfns.c (Fx_window_property): Simplify a bit,
5505 to make a bit faster and to avoid GCC 4.6.0 warning.
5506 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5507
9b821a21
PE
5508 * fns.c (internal_equal): Don't assume size_t fits in int.
5509
3c616cfa
PE
5510 * alloc.c (compact_small_strings): Tighten assertion a little.
5511
c2982e87
PE
5512 Replace pEd with more-general pI, and fix some printf arg casts.
5513 * lisp.h (pI): New macro, generalizing old pEd macro to other
5514 conversion specifiers. For example, use "...%"pI"d..." rather
5515 than "...%"pEd"...".
5516 (pEd): Remove. All uses replaced with similar uses of pI.
5517 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5518 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5519 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5520 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5521 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5522 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5523 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5524 64-bit hosts.
5525 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5526 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5527 * print.c (safe_debug_print, print_object): Likewise.
5528 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5529 to int.
6f04d126
PE
5530 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5531 avoiding the 0 flag, which is not portable.
c2982e87
PE
5532 * process.c (Fmake_network_process): Use pI to avoid cast.
5533 * region-cache.c (pp_cache): Likewise.
5534 * xdisp.c (decode_mode_spec): Likewise.
5535 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5536 behavior on 64-bit hosts with printf arg.
6f04d126 5537 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
5538 (x_stop_queuing_selection_requests): Likewise.
5539 (x_get_window_property): Don't truncate byte count to an 'int'
5540 when tracing.
0b432f21 5541
5e073ec7
PE
5542 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5543 here, since it parses constructs like leading '-' and spaces,
5544 which are not wanted; and it overflows with large numbers.
5545 Instead, simply match F[0-9]+, which is what is wanted anyway.
5546
36372bf9
PE
5547 * alloc.c: Remove unportable assumptions about struct layout.
5548 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5549 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5550 (allocate_vectorlike, make_pure_vector): Use the new macros,
5551 plus offsetof, to remove unportable assumptions about struct layout.
5552 These assumptions hold on all porting targets that I know of, but
5553 they are not guaranteed, they're easy to remove, and removing them
5554 makes further changes easier.
5555
0b432f21
PE
5556 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5557 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
5558 (string_overrun_cookie): Now const. Use initializers that
5559 don't formally overflow signed char, to avoid warnings.
000098c1
PE
5560 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5561 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
5562 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5563 multiple of sizeof (EMACS_INT); it need not be, if
5564 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 5565 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 5566
895009e1
JB
55672011-04-26 Juanma Barranquero <lekktu@gmail.com>
5568
5569 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5570
6a7a1b0b
TZ
55712011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5572
5573 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 5574 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
5575 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5576
841a1577 55772011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
5578
5579 * lisp.h (Qdebug): List symbol.
895009e1 5580 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
5581 * keyboard.c (debug-on-event): New variable.
5582 (handle_user_signal): Break into debugger when debug-on-event
5583 matches the current signal symbol.
5584
f2d3ba6f
DN
55852011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5586
5587 * alloc.c (check_sblock, check_string_bytes)
5588 (check_string_free_list): Convert to standard C.
5589
42ce4c63
TZ
55902011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5591
5592 * w32.c (emacs_gnutls_push): Fix typo.
5593
825cd63c
EZ
55942011-04-25 Eli Zaretskii <eliz@gnu.org>
5595
fb11d64d
EZ
5596 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5597 "cast to pointer from integer of different size".
5598
825cd63c
EZ
5599 Improve doprnt and its use in verror. (Bug#8545)
5600 * doprnt.c (doprnt): Document the set of format control sequences
5601 supported by the function. Use SAFE_ALLOCA instead of always
5602 using `alloca'.
5603
5604 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5605 is one byte too soon. Don't use xrealloc; instead xfree and
5606 xmalloc anew.
5607
e061a11b
TZ
56082011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5609
5610 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5611 callbacks stage.
5612
5613 * gnutls.c: Renamed global_initialized to
5614 gnutls_global_initialized. Added internals for the
5615 :verify-hostname-error, :verify-error, and :verify-flags
5616 parameters of `gnutls-boot' and documented those parameters in the
5617 docstring. Start callback support.
9173deec
JB
5618 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5619 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5620 on error. Return error code.
e061a11b
TZ
5621 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5622 (emacs_gnutls_read): Likewise.
5623 (Fgnutls_boot): Return handshake error code.
5624 (emacs_gnutls_handle_error): New function.
5625 (wsaerror_to_errno): Likewise.
5626
5627 * w32.h (emacs_gnutls_pull): Add prototype.
5628 (emacs_gnutls_push): Likewise.
5629
5630 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5631 (emacs_gnutls_push): Likewise.
5632
56332011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5634
5635 * process.c (wait_reading_process_output): Check if GnuTLS
5636 buffered some data internally if no FDs are set for TLS
5637 connections.
5638
5639 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5640 (LIBS): Link to USER_LIBS.
5641 ($(BLD)/gnutls.$(0)): New target.
5642
fa6996bc
EZ
56432011-04-24 Eli Zaretskii <eliz@gnu.org>
5644
eb35682e
EZ
5645 * xdisp.c (handle_single_display_spec): Rename the
5646 display_replaced_before_p argument into display_replaced_p, to
5647 make it consistent with the commentary. Fix typos in the
5648 commentary.
5649
e2ad650c
EZ
5650 * textprop.c (syms_of_textprop): Remove dead code.
5651 (copy_text_properties): Delete obsolete commentary about an
5652 interface that was deleted long ago. Fix typos in the description
5653 of arguments.
5654
1b2de274
EZ
5655 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5656 to changes in oldXMenu/XMenu.h from 2011-04-16.
5657 <menu_help_message, prev_menu_help_message>: Constify.
5658 (IT_menu_make_room): menu->help_text is now `const char **';
5659 adjust.
5660
5661 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5662 to changes in oldXMenu/XMenu.h from 2011-04-16.
5663 (struct XMenu): Declare `help_text' `const char **'.
5664
5665 * xfaces.c <Qunspecified>: Make extern again.
5666
5667 * syntax.c: Include sys/types.h before including regex.h, as
5668 required by Posix.
5669
762b15be
EZ
5670 * doc.c (get_doc_string): Improve the format passed to `error'.
5671
5672 * doprnt.c (doprnt): Improve commentary.
5673
5674 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5675
5676 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5677 them with etags.
5678
f1052e5d
EZ
5679 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5680 changes in globals.h immediately force recompilation.
762b15be
EZ
5681 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5682 $(CURDIR)/s/ms-w32.h.
5683 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 5684
fa6996bc
EZ
5685 * character.c (Fchar_direction): Function deleted.
5686 (syms_of_character): Don't defsubr it.
5687 <char-direction-table>: Deleted.
5688
e6c3da20
EZ
56892011-04-23 Eli Zaretskii <eliz@gnu.org>
5690
5691 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5692 * doprnt.c: Include limits.h.
5693 (SIZE_MAX): New macro.
04f2d78b
CB
5694 (doprnt): Return a size_t value. 2nd arg is now size_t.
5695 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
5696 Improve overflow protection. Support `l' modifier for integer
5697 conversions. Support %l conversion. Don't assume an EMACS_INT
5698 argument for integer conversions and for %c.
5699
5700 * lisp.h (doprnt): Restore prototype.
5701
5702 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5703 $(SRC)/character.h.
5704
5705 * Makefile.in (base_obj): Add back doprnt.o.
5706
5707 * deps.mk (doprnt.o): Add back prerequisites.
5708 (callint.o): Depend on character.h.
5709
5710 * eval.c (internal_lisp_condition_case): Include the handler
5711 representation in the error message.
5712 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5713 when breaking from the loop.
5714
5715 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5716
5717 * callint.c (Fcall_interactively): When displaying error message
5718 about invalid control letter, pass the character's codepoint, not
5719 a pointer to its multibyte form. Improve display of the character
5720 in octal and display also its hex code.
5721
5722 * character.c (char_string): Use %x to display the (unsigned)
5723 codepoint of an invalid character, to avoid displaying a bogus
5724 negative value.
5725
5726 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5727 `error', not SYMBOL_NAME itself.
5728
5729 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5730 character arguments to `error'.
5731
5732 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5733 to `error' in error message about FINAL_CHAR argument. Make sure
5734 FINAL_CHAR is a character, and use %c when it is passed as
5735 argument to `error'.
5736
4ffd0d6b 57372011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
5738
5739 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5740
5741 * w32.c: Include <time.h>.
5742 (sys_localtime): New function.
5743
4ffd0d6b 57442011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
5745
5746 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5747
4ffd0d6b 5748 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 5749
4ffd0d6b 57502011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 5751
4ffd0d6b
GM
5752 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5753 zombies (Bug#8467).
aac0c6e3 5754
04c56954
EZ
57552011-04-19 Eli Zaretskii <eliz@gnu.org>
5756
5757 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5758 gl_state.e_property when gl_state.object is Qt.
5759
5760 * insdel.c (make_gap_larger): Remove limitation of buffer size
5761 to <= INT_MAX.
5762
16a43933
CY
57632011-04-18 Chong Yidong <cyd@stupidchicken.com>
5764
5765 * xdisp.c (lookup_glyphless_char_display)
5766 (produce_glyphless_glyph): Handle cons cell entry in
5767 glyphless-char-display.
5768 (Vglyphless_char_display): Document it.
5769
5770 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5771 glyphless-char-display.
5772
4581706e
CY
57732011-04-17 Chong Yidong <cyd@stupidchicken.com>
5774
5775 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5776
5777 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5778
5779 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5780 definition for no-X builds.
5781
4887c6e2 57822011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 5783
fd35b6f9
PE
5784 Static checks with GCC 4.6.0 and non-default toolkits.
5785
5c1ccb01
PE
5786 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5787
006c5daa
PE
5788 * process.c (keyboard_bit_set): Define only if SIGIO.
5789 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5790 (send_process): Repair possible setjmp clobbering.
5791
efc736d3
PE
5792 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5793
4e2fe2e6
PE
5794 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5795
f97334a2
PE
5796 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5797
4e75f29d
PE
5798 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5799 Define only if needed.
5800
90efadd1
PE
5801 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5802 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 5803 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 5804
3c647824
PE
5805 * dispextern.h (struct redisplay_interface): Rename param
5806 to avoid shadowing.
e264f262 5807 * termhooks.h (struct terminal): Likewise.
761383f4 5808 * xterm.c (xembed_send_message): Likewise.
3c647824 5809
b58c5c4a
PE
5810 * insdel.c (make_gap_smaller): Define only if
5811 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5812
cad59032
PE
5813 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5814 it.
5815
c339dc2e
PE
5816 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5817 so that we aren't warned about unused symbols.
5818
91a3e27b
PE
5819 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5820
399c71d3 5821 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 5822
8ffc96f5
PE
5823 * xfns.c (x_real_positions): Mark locals as initialized.
5824
eef9bc79
PE
5825 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5826
098db9dd
PE
5827 * xterm.c: Fix problems found by static analysis with other toolkits.
5828 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
5829 (x_dispatch_event): Declare static if USE_GTK, and
5830 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 5831 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 5832 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
5833 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5834 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 5835
eb18f6cc
PE
5836 * xmenu.c (menu_help_callback): Pointer type fixes.
5837 Use const pointers when pointing at readonly data. Avoid pointer
5838 signedness clashes.
5839 (FALSE): Remove unused macro.
5840 (update_frame_menubar): Remove unused decl.
5841
1fe72bf8
PE
5842 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5843
60d9e1db
PE
5844 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5845 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5846 (single_menu_item): Rename local to avoid shadowing.
5847
39261c26
PE
5848 * keyboard.c (make_lispy_event): Remove unused local var.
5849
018c5e19
PE
5850 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5851 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5852
63d2b86e
PE
5853 * bitmaps: Change bitmaps from unsigned char back to the X11
5854 compatible char. Avoid the old compiler warnings about
5855 out-of-range initializers by using, for example, '\xab' rather
5856 than 0xab.
5857
aefd87e1
PE
5858 * xgselect.c (xgselect_initialize): Check vs interface
5859 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5860
bf501fb9
PE
5861 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5862
e9829fdf
PE
5863 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5864 to read-only memory.
5865
1086c095
PE
5866 * fns.c (vector): Remove; this old hack is no longer needed.
5867
2baccd04 5868 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 5869 Remove unused var.
dde42981 5870 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 5871
72391843 5872 * xrdb.c (x_load_resources): Omit unused local.
3565b346 5873
436c16df 5874 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 5875 (x_window): Rename locals to avoid shadowing.
dc5ddd85 5876 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 5877
92bb796d 5878 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 5879 (x_term_init): Remove local to avoid shadowing.
92bb796d 5880
764430a3 5881 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
5882
5883 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5884 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5885
d1dfb56c
EZ
58862011-04-16 Eli Zaretskii <eliz@gnu.org>
5887
c4354cb4
EZ
5888 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5889
d1dfb56c
EZ
5890 Fix regex.c, syntax.c and friends for buffers > 2GB.
5891 * syntax.h (struct gl_state_s): Declare character position members
5892 EMACS_INT.
5893
5894 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5895
04f2d78b
CB
5896 * textprop.c (verify_interval_modification, interval_of):
5897 Declare arguments EMACS_INT.
d1dfb56c
EZ
5898
5899 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5900 EMACS_INT.
5901
5902 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5903
5904 * indent.c (Fvertical_motion): Local variable it_start is now
5905 EMACS_INT.
5906
5907 * regex.c (re_match, re_match_2, re_match_2_internal)
5908 (bcmp_translate, regcomp, regexec, print_double_string)
5909 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5910 (re_compile_pattern, re_exec): Declare arguments and local
5911 variables `size_t' and `ssize_t' and return values `regoff_t', as
5912 appropriate.
5913 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5914 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5915 <compile_stack_type>: `size' and `avail' are now `size_t'.
5916
5917 * regex.h <regoff_t>: Use ssize_t, not int.
5918 (re_search, re_search_2, re_match, re_match_2): Arguments that
5919 specify buffer/string position and length are now ssize_t and
5920 size_t. Return type is regoff_t.
5921
613052cd
BK
59222011-04-16 Ben Key <bkey76@gmail.com>
5923
5924 * nsfont.m: Fixed bugs in ns_get_family and
5925 ns_descriptor_to_entity that were caused by using free to
5926 deallocate memory blocks that were allocated by xmalloc (via
5927 xstrdup). This caused Emacs to crash when compiled with
5928 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5929 --enable-checking=xmallocoverrun). xfree is now used to
5930 deallocate these memory blocks.
5931
4170f62f 59322011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 5933
71b41406
PE
5934 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5935
9587a89d
PE
5936 emacs_write: Accept and return EMACS_INT for sizes.
5937 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5938 et seq.
5939 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5940 Accept and return EMACS_INT.
5941 (emacs_gnutls_write): Return the number of bytes written on
5942 partial writes.
5943 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
5944 (emacs_read, emacs_write): Remove check for negative size, as the
5945 Emacs source code has been audited now.
9587a89d
PE
5946 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5947 (emacs_read, emacs_write): Use it.
273a5f82
PE
5948 * process.c (send_process): Adjust to the new signatures of
5949 emacs_write and emacs_gnutls_write. Do not attempt to store
5950 a byte offset into an 'int'; it might overflow.
9587a89d 5951 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 5952
3e047f51
PE
5953 * sound.c: Don't assume sizes fit in 'int'.
5954 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 5955 Return EMACS_INT, not int.
3e047f51 5956 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
5957 Accept EMACS_INT, not int.
5958 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
5959 record read return values.
5960
cc39a9db
BK
59612011-04-15 Ben Key <bkey76@gmail.com>
5962
c9d0ec6d
JB
5963 * keyboard.c (Qundefined): Don't declare static since it is used
5964 in nsfns.m.
5965 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5966 static since they are used in nsfont.m.
cc39a9db 5967
6c60eb9f
SM
59682011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5969
5970 * process.c (Qprocessp): Don't declare static.
5971 * lisp.h (Qprocessp): Declare again.
5972
7990b61a
JB
59732011-04-15 Juanma Barranquero <lekktu@gmail.com>
5974
5975 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5976
5d4cb038
PE
59772011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5978
8bd7b830 5979 Improve C-level modularity by making more things 'static'.
cd64ea1d 5980
e3b27b31
PE
5981 Don't publish debugger-only interfaces to other modules.
5982 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5983 (verify_bytepos, count_markers): Move decls to the only modules
5984 that need them.
5985 * region-cache.h (pp_cache): Likewise.
5986 * window.h (check_all_windows): Likewise.
5987 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5988
5d4cb038
PE
5989 * sysdep.c (croak): Now static, if
5990 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5991 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
5992
5993 * alloc.c (refill_memory_reserve): Now static if
5994 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5995 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 5996
e87b6180
PE
5997 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5998 Define only if USE_LUCID.
5999
ac64929e
PE
6000 * xrdb.c (x_customization_string, x_rm_string): Now static.
6001
6f37259d
PE
6002 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6003 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6004
1683e3ab
PE
6005 * xdisp.c (draw_row_with_mouse_face): Now static.
6006 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6007
de9c2632
PE
6008 * window.h (check_all_windows): Mark externally visible.
6009
2b96acb7
PE
6010 * window.c (window_deletion_count): Now static.
6011
6012 * undo.c: Make symbols static if they're not exported.
6013 (last_undo_buffer, last_boundary_position, pending_boundary):
6014 Now static.
6015
50436f33
PE
6016 * textprop.c (interval_insert_behind_hooks): Now static.
6017 (interval_insert_in_front_hooks): Likewise.
6018
64520e5c
PE
6019 * term.c: Make symbols static if they're not exported.
6020 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6021 (max_frame_lines, tty_set_terminal_modes):
6022 (tty_reset_terminal_modes, tty_turn_off_highlight):
6023 (get_tty_terminal): Now static.
6024 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6025 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 6026 HAVE_WINDOW_SYSTEM.
64520e5c
PE
6027 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6028 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6029
1fa53021
PE
6030 * sysdep.c: Make symbols static if they're not exported.
6031 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6032 Now static.
6033 (sigprocmask_set, full_mask): Remove; unused.
6034 (wait_debugging): Mark as visible.
6035 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6036 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6037
d4b43b22
PE
6038 * syntax.c (syntax_temp): Define only if !__GNUC__.
6039
b7c513d0
PE
6040 * sound.c (current_sound_device, current_sound): Now static.
6041
989b29ad
PE
6042 * search.c (searchbufs, searchbuf_head): Now static.
6043
13a55a78
PE
6044 * scroll.c (scroll_cost): Remove; unused.
6045 * dispextern.h (scroll_cost): Remove decl.
6046
de68a1fc
PE
6047 * region-cache.h (pp_cache): Mark as externally visible.
6048
40ccffa6
PE
6049 * process.c: Make symbols static if they're not exported.
6050 (process_tick, update_tick, create_process, chan_process):
6051 (Vprocess_alist, proc_buffered_char, datagram_access):
6052 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6053 (deactivate_process): Mark defn as static, as well as decl.
6054 * lisp.h (create_process): Remove decl.
6055 * process.h (chan_process, Vprocess_alist): Remove decls.
6056
ad64fc97
PE
6057 * print.c: Make symbols static if they're not exported.
6058 (print_depth, new_backquote_output, being_printed, print_buffer):
6059 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6060 (print_interval, print_number_index, initial_stderr_stream):
6061 Now static.
6062 * lisp.h (Fprinc): Remove decl.
6063 (debug_output_compilation_hack): Mark as externally visible.
6064
adddb265
PE
6065 * sysdep.c (croak): Move decl from here to syssignal.h.
6066 * syssignal.h (croak): Put it here, so the API can be checked when
6067 'croak' is called from dissociate_if_controlling_tty.
6068
1717ede2
PE
6069 * minibuf.c: Make symbols static if they're not exported.
6070 (minibuf_save_list, choose_minibuf_frame): Now static.
6071 * lisp.h (choose_minibuf_frame): Remove decl.
6072
fa5fb2bc
PE
6073 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6074
1e3890d1
PE
6075 * lread.c: Make symbols static if they're not exported.
6076 (read_objects, initial_obarray, oblookup_last_bucket_number):
6077 Now static.
6078 (make_symbol): Remove; unused.
6079 * lisp.h (initial_obarray, make_symbol): Remove decls.
6080
8a1414fa
PE
6081 * keyboard.c: Make symbols static if they're not exported.
6082 (single_kboard, recent_keys_index, total_keys, recent_keys):
6083 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6084 (this_single_command_key_start, echoing, last_auto_save):
6085 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6086 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6087 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6088 (Vlispy_mouse_stem, double_click_count):
6089 Now static.
6090 (force_auto_save_soon): Define only if SIGDANGER.
6091 (ignore_mouse_drag_p): Now static if
6092 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6093 (print_help): Remove; unused.
6094 (stop_character, last_timer_event): Mark as externally visible.
6095 * keyboard.h (ignore_mouse_drag_p): Declare only if
6096 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6097 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6098 * lisp.h (echoing): Remove decl.
6099 (force_auto_save_soon): Declare only if SIGDANGER.
6100 * xdisp.c (redisplay_window): Simplify code, to make it more
6101 obvious that ignore_mouse_drag_p is not accessed if !defined
6102 USE_GTK && !defined HAVE_NS.
6103
93ea6e8f
PE
6104 * intervals.c: Make symbols static if they're not exported.
6105 (merge_properties_sticky, merge_interval_right, delete_interval):
6106 Now static.
6107 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6108
77382fcc
PE
6109 * insdel.c: Make symbols static if they're not exported.
6110 However, leave prepare_to_modify_buffer alone. It's never
6111 called from outside this function, but that appears to be a bug.
6112 (combine_after_change_list, combine_after_change_buffer):
4889fc82 6113 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
6114 (adjust_after_replace_noundo): Remove; unused.
6115 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 6116 (signal_before_change): Remove decls.
77382fcc 6117
9306c32e
PE
6118 * indent.c (val_compute_motion, val_vmotion): Now static.
6119
cd44d2eb
PE
6120 * image.c: Make symbols static if they're not exported.
6121 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6122 if USE_GTK.
6123 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6124 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6125
ad9a7a06
PE
6126 * fringe.c (standard_bitmaps): Now static.
6127 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6128
81626931
PE
6129 * frame.c: Make symbols static if they're not exported.
6130 (x_report_frame_params, make_terminal_frame): Now static.
6131 (get_frame_param): Now static, unless HAVE_NS.
6132 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6133 (x_get_resource_string): Remove; not used.
6134 * frame.h (make_terminal_frame, x_report_frame_params):
6135 (x_get_resource_string); Remove decls.
6136 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6137 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6138
239f9db9
PE
6139 * font.c, fontset.c: Make symbols static if they're not exported.
6140 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6141 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6142 * font.c (font_close_object): Now static.
6143 * font.h (font_close_object): Remove.
6144 * fontset.c (FONTSET_OBJLIST): Remove.
6145 (free_realized_fontset) #if-0 the body, which does nothing.
6146 (face_suitable_for_char_p): #if-0, as it's never called.
6147 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
6148 * xfaces.c (face_at_string_position):
6149 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
6150 since 0 is always ASCII.
6151
dfcf3579
PE
6152 * fns.c (weak_hash_tables): Now static.
6153
5045092b
PE
6154 * fileio.c: Make symbols static if they're not exported.
6155 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6156 (Vwrite_region_annotation_buffers): Now static.
6157
57a96f5c
PE
6158 * eval.c: Make symbols static if they're not exported.
6159 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6160 * lisp.h (backtrace_list): Remove decl.
6161
35f08c38
PE
6162 * emacs.c: Make symbols static if they're not exported.
6163 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6164 (fatal_error_code, fatal_error_signal_hook, standard_args):
6165 Now static.
6166 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6167 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6168 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6169 * lisp.h (fatal_error_signal_hook): Remove decl.
6170 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6171
f44bd759
PE
6172 * editfns.c: Move a (normally-unused) function to its only use.
6173 * editfns.c, lisp.h (get_operating_system_release): Remove.
6174 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6175 worth the hassle of breaking this out.
6176
b532497d
PE
6177 * xterm.c: Make symbols static if they're not exported.
6178 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6179 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6180 (x_destroy_window, x_delete_display):
6181 Now static.
6182 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6183 (x_mouse_leave): Remove; unused.
6184 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6185 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6186 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6187 Remove decls.
6188 (x_mouse_leave): Declare only if WINDOWSNT.
6189 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6190 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6191 USE_X_TOOLKIT.
6192
1675728f
PE
6193 * ftxfont.c: Make symbols static if they're not exported.
6194 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6195 HAVE_FREETYPE.
6196 * font.h (ftxfont_driver): Likewise.
6197
e4cebfca
PE
6198 * xfns.c: Make symbols static if they're not exported.
6199 (x_last_font_name, x_display_info_for_name):
6200 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6201 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6202 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6203 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6204 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6205 (last_show_tip_args): Now static.
6206 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6207 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6208 (x_screen_planes): Remove; unused.
6209 * dispextern.h (x_screen_planes): Remove decl.
6210
5bf46f05
PE
6211 * dispnew.c: Make symbols static if they're not exported.
6212 * dispextern.h (redraw_garbaged_frames, scrolling):
6213 (increment_row_positions): Remove.
6214 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6215 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6216 Now static.
6217 (redraw_garbaged_frames): Remove; unused.
6218
435f4c28
PE
6219 * xfaces.c: Make symbols static if they're not exported.
6220 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6221 Remove decls.
6222 * xterm.h (defined_color): Remove decls.
6223 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6224 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6225 (menu_face_changed_default, defined_color, free_realized_face):
6226 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6227 (ascii_face_of_lisp_face): Remove; unused.
6228
8524aef3
PE
6229 * xdisp.c: Make symbols static if they're not exported.
6230 * dispextern.h (scratch_glyph_row, window_box_edges):
6231 (glyph_to_pixel_coords, set_cursor_from_row):
6232 (get_next_display_element, set_iterator_to_next):
6233 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6234 (show_mouse_face): Remove decls
6235 * frame.h (message_buf_print): Likewise.
6236 * lisp.h (pop_message, set_message, check_point_in_composition):
6237 Likewise.
6238 * xterm.h (set_vertical_scroll_bar): Likewise.
6239 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6240 (message_buf_print, scratch_glyph_row, displayed_buffer):
6241 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6242 (get_next_display_element, show_mouse_face, window_box_edges):
6243 (frame_to_window_pixel_xy, check_point_in_composition):
6244 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6245 (glyph_to_pixel_coords): Remove; unused.
6246
16390cd2
PE
6247 * dired.c (file_name_completion): Now static.
6248
6249 * dbusbind.c (xd_in_read_queued_messages): Now static.
6250
a25f4dfa
PE
6251 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6252 * data.c (circular_list_error): Remove.
6253
14a9c8df
PE
6254 * commands.h (last_point_position, last_point_position_buffer):
6255 (last_point_position_window): Remove decls.
6256 * keyboard.c: Make these variables static.
6257
04f2d78b
CB
6258 * coding.h (coding, code_convert_region, encode_coding_gap):
6259 Remove decls.
74ab6df5
PE
6260 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6261 (iso_code_class, detect_coding, code_convert_region): Now static.
6262 (encode_coding_gap): Remove; unused.
6263
38dfbee1
PE
6264 * chartab.c (chartab_chars, chartab_bits): Now static.
6265
a2cb4e63
PE
6266 * charset.h (charset_iso_8859_1): Remove decl.
6267 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6268 Now static.
6269
127198fd
PE
6270 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6271 * ccl.c (Vccl_program_table): Now static.
6272 (check_ccl_update): Remove; unused.
6273
d85b608f
PE
6274 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6275 * category.h: ... from here.
6276 * category.c (check_category_table, set_category_set): Now static.
6277
31cd66f3
PE
6278 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6279 * lisp.h: Remove these decls.
6280
c358e587
PE
6281 * buffer.c (buffer_count): Remove unused var.
6282
e78aecca
PE
6283 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6284 so that it's not optimized away.
6285 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6286 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6287 exported only to the debugger.
6288
e192d7d3 6289 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 6290 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 6291
92470028
PE
6292 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6293 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6294 was inaccessible from Lisp.
6295 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6296 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6297
244ed907
PE
6298 alloc.c: Import and export fewer symbols, and remove unused items.
6299 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6300 is defined.
6301 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6302 it's not optimized away by whole-program optimization.
6303 (message_enable_multibyte, free_misc): Remove.
6304 (catchlist, handlerlist, mark_backtrace):
6305 Declare only if BYTE_MARK_STACK.
6306 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6307 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6308 (message_enable_multibyte): Remove decl.
6309 (free_misc, interval_free_list, float_block, float_block_index):
6310 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6311 (cons_free_list, last_marked_index):
6312 Now static.
6313 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6314 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6315 (mark_backtrace): Define only if BYTE_MARK_STACK.
6316 * xdisp.c (message_enable_multibyte): Now static.
6317
61c2b50e 6318 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
6319 This makes it easier for human readers (and static analyzers)
6320 to see whether these variables are used from other modules.
6321 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6322 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6323 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6324 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6325 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6326 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6327 * xmenu.c, xselect.c:
6328 Declare Q* vars static if they are not used in other modules.
6329 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6330 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6331 Remove decls of unexported vars.
6332 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6333
95c82688
PE
6334 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6335
16a97296
PE
6336 Make Emacs functions such as Fatom 'static' by default.
6337 This makes it easier for human readers (and static analyzers)
6338 to see whether these functions can be called from other modules.
6339 DEFUN now defines a static function. To make the function external
6340 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
6341 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6342 (Finit_image_library):
16a97296
PE
6343 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6344 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6345 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6346 Remove decls, since these functions are now static.
6347 (Funintern, Fget_internal_run_time): New decls, since these functions
6348 were already external.
95c82688 6349
16a97296
PE
6350 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6351 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6352 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6353 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6354 * keyboard.c, keymap.c, lread.c:
6355 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6356 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6357 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6358 Mark functions with DEFUE instead of DEFUN,
6359 if they are used in other modules.
6360 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6361 decls for now-static functions.
6362 * buffer.h (Fdelete_overlay): Remove decl.
6363 * callproc.c (Fgetenv_internal): Mark as internal.
6364 * composite.c (Fremove_list_of_text_properties): Remove decl.
6365 (Fcomposition_get_gstring): New forward static decl.
6366 * composite.h (Fcomposite_get_gstring): Remove decl.
6367 * dired.c (Ffile_attributes): New forward static decl.
6368 * doc.c (Fdocumntation_property): New forward static decl.
6369 * eval.c (Ffetch_bytecode): New forward static decl.
6370 (Funintern): Remove extern decl; now in .h file where it belongs.
6371 * fileio.c (Fmake_symbolic_link): New forward static decl.
6372 * image.c (Finit_image_library): New forward static decl.
6373 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6374 * intervals.h (Fprevious_property_change):
6375 (Fremove_list_of_text_properties): Remove decls.
6376 * keyboard.c (Fthis_command_keys): Remove decl.
6377 (Fcommand_execute): New forward static decl.
6378 * keymap.c (Flookup_key): New forward static decl.
6379 (Fcopy_keymap): Now static.
6380 * keymap.h (Flookup_key): Remove decl.
6381 * process.c (Fget_process): New forward static decl.
6382 (Fprocess_datagram_address): Mark as internal.
6383 * syntax.c (Fsyntax_table_p): New forward static decl.
6384 (skip_chars): Remove duplicate decl.
6385 * textprop.c (Fprevious_property_change): New forward static decl.
6386 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6387 Now internal.
6388 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6389 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6390
785bbd42
PE
6391 * editfns.c (Fformat): Remove unreachable code.
6392
8b913b57
AS
63932011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6394
6395 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6396 change. (Bug#8496)
6397
a6744a35
EZ
63982011-04-13 Eli Zaretskii <eliz@gnu.org>
6399
6400 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6401 when at ZV. (Bug#8487)
6402
e7974947
AS
64032011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6404
baad03f0
AS
6405 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6406 (Bug#8437)
6407 * keyboard.c (parse_tool_bar_item): Likewise.
6408 * sound.c (sound_cleanup, alsa_close): Likewise.
6409 * termcap.c (tgetent): Likewise.
6410 * xfns.c (x_default_font_parameter): Likewise.
6411 * xsettings.c (read_and_apply_settings): Likewise.
6412
e7974947
AS
6413 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6414 (overrun_check_free): Protoize.
6415
28272684
PE
64162011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6417
6418 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6419 since callers should never pass a negative size.
6420 Change the signature to match that of plain 'read' and 'write'; see
6421 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6422 * lisp.h: Update prototypes of emacs_write and emacs_read.
6423
11997c76
EZ
64242011-04-11 Eli Zaretskii <eliz@gnu.org>
6425
6426 * xdisp.c (redisplay_window): Don't try to determine the character
6427 position of the scroll margin if the window start point w->startp
e896f03c 6428 is outside the buffer's accessible region. (Bug#8468)
11997c76 6429
8a2cbd72
EZ
64302011-04-10 Eli Zaretskii <eliz@gnu.org>
6431
6432 Fix write-region and its subroutines for buffers > 2GB.
6433 * fileio.c (a_write, e_write): Modify declaration of arguments and
6434 local variables to support buffers larger than 2GB.
6435 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6436
6437 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6438 argument, local variables, and return value.
6439
6440 * lisp.h: Update prototypes of emacs_write and emacs_read.
6441
6442 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6443
4073e537 64442011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 6445
1ebfdcb6
PE
6446 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6447
b2ded58d
PE
6448 Fix more problems found by GCC 4.6.0's static checks.
6449
7d66342c
PE
6450 * xdisp.c (vmessage): Use a better test for character truncation.
6451
bbf47d44
PE
6452 * charset.c (load_charset_map): <, not <=, for optimization,
6453 and to avoid potential problems with integer overflow.
9248994d 6454 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 6455 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 6456 * editfns.c (Fformat): Likewise.
1e69125e 6457 * syntax.c (skip_chars): Likewise.
3befa583 6458
e3019616
PE
6459 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6460 This also lets GCC 4.6.0 generate slightly better loop code.
6461
becfa255
PE
6462 * callint.c (Fcall_interactively): <, not <=, for optimization.
6463 (Fcall_interactively): Count the number of arguments produced,
6464 not the number of arguments given. This is simpler and lets GCC
6465 4.6.0 generate slightly better code.
6466
dae0cd48
PE
6467 * ftfont.c: Distingish more carefully between FcChar8 and char.
6468 The previous code passed unsigned char * to a functions like
6469 strlen and xstrcasecmp that expect char *, which does not
6470 conform to the C standard.
6471 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6472 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6473 char * when the C standard requires it.
6474
76032d70
PE
6475 * keyboard.c (read_char): Remove unused var.
6476
eb3f1cc8
PE
6477 * eval.c: Port to Windows vsnprintf (Bug#8435).
6478 Include <limits.h>.
6479 (SIZE_MAX): Define if the headers do not.
6480 (verror): Do not give up if vsnprintf returns a negative count.
6481 Instead, grow the buffer. This ports to Windows vsnprintf, which
6482 does not conform to C99. Problem reported by Eli Zaretskii.
6483 Also, simplify the allocation scheme, by avoiding the need for
6484 calling realloc, and removing the ALLOCATED variable.
6485
70476b54
PE
6486 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6487
12020a9e
PE
6488 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6489 But keep the doprint source code for now, as we might revamp it
6490 and use it again (Bug#8435).
ea6c7ae6
PE
6491 * lisp.h (doprnt): Remove.
6492 * Makefile.in (base_obj): Remove doprnt.o.
6493 * deps.mk (doprnt.o): Remove.
6494
5fdb398c
PE
6495 error: Print 32- and 64-bit integers portably (Bug#8435).
6496 Without this change, on typical 64-bit hosts error ("...%d...", N)
6497 was used to print both 32- and 64-bit integers N, which relied on
6498 undefined behavior.
6499 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6500 New macro.
6501 * lisp.h (error, verror): Mark as printf-like functions.
6502 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6503 Report overflow in size calculations when allocating printf buffer.
6504 Do not truncate output string at its first null byte.
6505 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6506 Truncate the output at a character boundary, since vsnprintf does not
6507 do that.
6508 * charset.c (check_iso_charset_parameter): Convert internal
6509 character to string before calling 'error', since %c now has the
6510 printf meaning.
6511 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6512 overflow when computing char to be passed to 'error'. Do not
6513 pass Lisp_Object to 'error'; pass the integer instead.
6514 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6515 formatted with plain %d.
6516
b189fa66
PE
6517 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6518
bff87ef0
PE
6519 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6520
7e2cac20
PE
6521 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6522
ce4d90b5
PE
6523 * xterm.c (x_catch_errors): Remove duplicate declaration.
6524
266c9547
PE
6525 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6526
79c49ad2
PE
6527 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6528
368f4090
JM
65292011-04-10 Jim Meyering <meyering@redhat.com>
6530
6531 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6532 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6533 return ssize_t not "int", and use size_t as the buffer length.
6534 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6535 * gnutls.h: Update declarations.
6536 * process.c (read_process_output): Use ssize_t, to match.
6537 (send_process): Likewise.
6538
a32d4040
CY
65392011-04-09 Chong Yidong <cyd@stupidchicken.com>
6540
6541 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6542
8546720e 65432011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 6544
04f2d78b
CB
6545 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6546 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 6547
8546720e
GM
6548 * xterm.c (handle_one_xevent):
6549 * xmenu.c (create_and_show_popup_menu):
6550 * xselect.c (x_decline_selection_request)
6551 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 6552
0a2f5c1a 65532011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
6554
6555 Fix some uses of `int' instead of EMACS_INT.
6556 * search.c (string_match_1, fast_string_match)
6557 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6558 (scan_buffer, find_next_newline_no_quit)
6559 (find_before_next_newline, search_command, Freplace_match)
6560 (Fmatch_data): Make some `int' variables be EMACS_INT.
6561
6562 * xdisp.c (display_count_lines): 3rd argument and return value now
6563 EMACS_INT. All callers changed.
6564 (pint2hrstr): Last argument is now EMACS_INT.
6565
6566 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6567 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6568 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6569 (decode_coding_utf_16, decode_coding_emacs_mule)
6570 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6571 (decode_coding_ccl, decode_coding_charset)
6572 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6573 (decode_coding_iso_2022, decode_coding_emacs_mule)
6574 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6575 <char_offset, last_offset>: Declare EMACS_INT.
6576 (encode_coding_utf_8, encode_coding_utf_16)
6577 (encode_coding_emacs_mule, encode_invocation_designation)
6578 (encode_designation_at_bol, encode_coding_iso_2022)
6579 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6580 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6581 Declare EMACS_INT.
6582 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6583 (encode_invocation_designation): Last argument P_NCHARS is now
6584 EMACS_INT.
6585 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6586 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6587
6588 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6589 All users changed.
6590
6591 * ccl.c (Fccl_execute_on_string): Declare some variables
6592 EMACS_INT.
6593
8546720e 65942011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
6595
6596 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6597
4e19a977
CS
65982011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6599
6600 * process.c (Fformat_network_address): Doc fix.
6601
87302331
R
66022011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6603
6604 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6605
cbb59342
CY
66062011-04-08 Chong Yidong <cyd@stupidchicken.com>
6607
6608 * keyboard.c (read_char): Call Lisp function help-form-show,
6609 instead of using internal_with_output_to_temp_buffer.
6610 (Qhelp_form_show): New var.
e0d38eeb 6611 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
6612
6613 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6614
6615 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6616
e67a13ab
CY
66172011-04-06 Chong Yidong <cyd@stupidchicken.com>
6618
04f2d78b
CB
6619 * process.c (Flist_processes): Remove to Lisp.
6620 (list_processes_1): Delete.
e67a13ab 6621
973f782d
EZ
66222011-04-06 Eli Zaretskii <eliz@gnu.org>
6623
7c106b1e
EZ
6624 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6625
973f782d
EZ
6626 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6627
41cf7d1a 66282011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 6629
ca23cc88
PE
6630 Fix more problems found by GCC 4.6.0's static checks.
6631
f390e2d5
PE
6632 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6633
42eea0d0
PE
6634 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6635
b69769da 6636 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 6637
f9541e84
PE
6638 * xdisp.c (vmessage): Mark as a printf-like function.
6639
13841b55
PE
6640 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6641
c136c10f
PE
6642 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6643
5e2d4a30
PE
6644 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6645 printf-like functions.
6646 (tiff_load): Add casts to remove these marks before passing them
6647 to system-supplied API.
6648
583f48b9
PE
6649 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6650
b25d760e
PE
6651 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6652 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
6653 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6654 directly, rather than having caller test rule sign. This avoids
6655 some unnecessary tests.
6656 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6657 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6658 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 6659
bc7b6697 6660 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 6661 (xfont_open): Avoid unnecessary tests.
bc7b6697 6662
27ccc379
PE
6663 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6664
dcd5c89a
PE
6665 * composite.h, composite.c (composition_gstring_put_cache):
6666 Use EMACS_INT, not int, for length.
6667
b13a45c6
PE
6668 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6669 breaking out part of COMPOSITION_DECODE_RULE.
6670 (COMPOSITION_DECODE_RULE): Use it.
6671 * composite.c (get_composition_id): Remove unused local vars,
6672 by using the new macro.
6673
1e792e4d
PE
6674 * textprop.c (set_text_properties_1): Change while to do-while,
6675 since the condition is always true at first.
6676
dc6c6455 6677 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
6678 (interval_deletion_adjustment): Return unsigned value.
6679 All uses changed.
dc6c6455 6680
aba7731a
PE
6681 * process.c (list_processes_1, create_pty, read_process_output):
6682 (exec_sentinel): Remove vars that were set but not used.
afd4052b 6683 (create_pty): Remove unnecessary "volatile"s.
bc57d757 6684 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 6685 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 6686 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 6687
fdfc4bf3
PE
6688 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6689
fca8fe46 6690 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 6691 (update_syntax_table): Use unsigned instead of int.
fca8fe46 6692
06a0259a 6693 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 6694 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 6695 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 6696
e7b9e80f
PE
6697 * print.c (print_error_message): Avoid int overflow.
6698
56201685
PE
6699 * font.c (font_list_entities): Redo for clarity,
6700 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6701
78834453 6702 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 6703 (font_score): Avoid potential overflow in diff calculation.
78834453 6704
0bc0b309 6705 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 6706 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 6707
e610eaca
PE
6708 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6709
b895abce
PE
6710 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6711 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6712 can always succeed if overflow has undefined behavior.
6713
1f1d9321 6714 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 6715 (wordify): Omit three unnecessary tests.
1f1d9321 6716
c59478bc
PE
6717 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6718 All callers changed. This avoids the need for an unused var.
6719
79b73827
PE
6720 * casefiddle.c (casify_region): Remove var that is set but not used.
6721
a4db5dfe
PE
6722 * dired.c (file_name_completion): Remove var that is set but not used.
6723
43aae36e
PE
6724 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6725
2a47c44d 6726 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 6727 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 6728
a37c69bf
PE
6729 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6730 Check for integer overflow on size calculations.
6731
328ab8e7
PE
6732 * buffer.c (Fprevious_overlay_change): Remove var that is set
6733 but not used.
6734
e5a2a5cb
PE
6735 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6736 Remove vars that are set but not used.
8d84a6eb 6737 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 6738 (timer_check_2): Mark vars as initialized.
e5a2a5cb 6739
a60e5f68
PE
6740 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6741
f661cb61 6742 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 6743 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 6744
f0397f5a
PE
6745 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6746 that are set but not used.
6747
8664db06 6748 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 6749 if XCreateBitmapFromData fails (Bug#8410).
8664db06 6750
6abdaa4a
PE
6751 * xselect.c (x_get_local_selection, x_handle_property_notify):
6752 Remove vars that are set but not used.
6753
0ce7538d 6754 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 6755 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 6756
9ae848fc
PE
6757 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6758 Remove var that is set but not used.
0b918413
PE
6759 (scroll_bar_windows_size): Now size_t, not int.
6760 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6761 Check for overflow.
9ae848fc 6762
a5a62657
PE
6763 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6764 (map_tty_color) [!defined MSDOS]: Likewise.
6765
5c5cdd39
PE
6766 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6767
66ebf983
PE
6768 * coding.c: Remove vars that are set but not used.
6769 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6770 All callers changed.
6771 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6772 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6773 (decode_coding_charset): Remove vars that are set but not used.
6774
1be4d761
PE
6775 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6776 that is set but not used.
6777
47553fa8
PE
6778 * print.c (print_object): Remove var that is set but not used.
6779
1f7196bf 6780 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
6781 The gnulib version avoids calling malloc in the usual case,
6782 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6783 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6784 * filelock.c (current_lock_owner): Likewise.
6785 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6786 * sysdep.c: Include allocator.h, careadlinkat.h.
6787 (emacs_no_realloc_allocator): New static constant.
6788 (emacs_readlink): New function.
fdb61804
PE
6789 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6790 ../lib/careadlinkat.h.
d1fdcab7 6791
f84c17c7
SM
67922011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6793
6794 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6795 first non-nil return value).
6796
ef3862ad
JD
67972011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6798
6799 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6800 if not defined (Bug#8403).
6801
376a7006
JB
68022011-04-02 Juanma Barranquero <lekktu@gmail.com>
6803
6804 * xdisp.c (display_count_lines): Remove parameter `start',
6805 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6806 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6807 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6808 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6809 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6810 and thereabouts. All callers changed.
6811 (get_per_char_metric): Remove parameter `f', unused since
6812 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6813
6ca3801d
JM
68142011-04-02 Jim Meyering <meyering@redhat.com>
6815
6816 do not dereference NULL upon failed strdup
6817 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6818 (ns_get_family): Likewise.
6819
d8e2b5ba
JB
68202011-04-02 Juanma Barranquero <lekktu@gmail.com>
6821
6822 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6823
8c74fcbd
JD
68242011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6825
6826 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6827 later (Bug#8403).
6828
7200d79c
SM
68292011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6830
03408648 6831 Add lexical binding.
7200d79c 6832
03408648
SM
6833 * window.c (Ftemp_output_buffer_show): New fun.
6834 (Fsave_window_excursion):
6835 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6836
6837 * lread.c (lisp_file_lexically_bound_p): New function.
6838 (Fload): Bind Qlexical_binding.
6839 (readevalloop): Remove `evalfun' arg.
6840 Bind Qinternal_interpreter_environment.
6841 (Feval_buffer): Bind Qlexical_binding.
6842 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6843 Mark as dynamic.
6844 (syms_of_lread): Declare `lexical-binding'.
6845
6846 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6847
6848 * keyboard.c (eval_dyn): New fun.
6849 (menu_item_eval_property): Use it.
ca105506
SM
6850
6851 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 6852
03408648
SM
6853 * fns.c (concat, mapcar1): Accept byte-code-functions.
6854
6855 * eval.c (Fsetq): Handle lexical vars.
6856 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6857 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6858 (FletX, Flet): Obey lexical binding.
6859 (Fcommandp): Handle closures.
6860 (Feval): New `lexical' arg.
6861 (eval_sub): New function extracted from Feval. Use it almost
6862 everywhere where Feval was used. Look up vars in lexical env.
6863 Handle closures.
6864 (Ffunctionp): Move from subr.el.
6865 (Ffuncall): Handle closures.
6866 (apply_lambda): Remove `eval_flags'.
6867 (funcall_lambda): Handle closures and new byte-code-functions.
6868 (Fspecial_variable_p): New function.
6869 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6870 but without exporting it to Lisp.
23aba0ea 6871
23aba0ea 6872 * doc.c (Fdocumentation, store_function_docstring):
03408648 6873 * data.c (Finteractive_form): Handle closures.
23aba0ea 6874
03408648
SM
6875 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6876 interactive spec.
ba83908c 6877
04f2d78b
CB
6878 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6879 New byte-codes.
03408648
SM
6880 (exec_byte_code): New function extracted from Fbyte_code to handle new
6881 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 6882
03408648 6883 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 6884
03408648 6885 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 6886
e2abce01
JB
68872011-03-31 Juanma Barranquero <lekktu@gmail.com>
6888
6889 * xdisp.c (redisplay_internal): Fix prototype.
6890
63696a73 68912011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 6892
63696a73 6893 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
6894 (try_scrolling): Use it when setting scroll_limit.
6895 Limit scrolling to 100 screen lines.
63696a73
EZ
6896 (redisplay_window): Even when falling back on "recentering",
6897 position point in the window according to scroll-conservatively,
6898 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6899
6900 (try_scrolling): When point is above the window, allow searching
6901 as far as scroll_max, or one screenful, to compute vertical
6902 distance from PT to the scroll margin position. This prevents
6903 try_scrolling from unnecessarily failing when
6904 scroll-conservatively is set to a value slightly larger than the
6905 window height. Clean up the case of PT below the margin at bottom
6906 of window: scroll_max can no longer be INT_MAX. When aggressive
6907 scrolling is in use, don't let point enter the opposite scroll
6908 margin as result of the scroll.
6909 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
6910 threshold of 100 lines for never-recentering scrolling.
6911
e4cc2dfc
JB
69122011-03-31 Juanma Barranquero <lekktu@gmail.com>
6913
6914 * dispextern.h (move_it_by_lines):
6915 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6916 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6917 (message_log_check_duplicate): Remove parameters `prev_bol' and
6918 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6919 (redisplay_internal): Remove parameter `preserve_echo_area',
6920 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6921
6922 * indent.c (Fvertical_motion):
6923 * window.c (window_scroll_pixel_based, Frecenter):
6924 Don't pass `need_y_p' to `move_it_by_lines'.
6925
1c470562
SM
69262011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6927
44f230aa
SM
6928 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6929 steal a few bits to be more compact.
6930 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6931 Remove unneeded casts.
6932
1c470562
SM
6933 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6934
888adce9
ZK
69352011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6936
6937 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6938 binding" message (bug#7967).
6939
f838ed7b
PE
69402011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6941
77861b95
PE
6942 Fix more problems found by GCC 4.6.0's static checks.
6943
de6dbc14
PE
6944 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6945 Remove unused local var.
6946
f838ed7b
PE
6947 * editfns.c (Fmessage_box): Remove unused local var.
6948
792c7b2b
PE
6949 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6950 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6951 Omit unused local vars.
c499e557 6952 * window.c (shrink_windows): Omit unused local var.
b01a1c29 6953 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
6954 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6955 Omit unused local var.
6956
ba0165e1
PE
6957 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6958 Don't assume string length fits in int.
32ad8845 6959 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 6960 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 6961
3c59b4c9
PE
6962 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6963 instead of alloca (Bug#8344).
6964
a3eed478 6965 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 6966 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 6967
eb4d412d
PE
6968 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6969
1658b401
PE
6970 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6971 concerns.
6972
6973 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6974
6975 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 6976
9a2c6e05
PE
6977 * keyboard.c (syms_of_keyboard): Use the same style as later
6978 in this function when indexing through an array. This also
6979 works around GCC bug 48267.
6980
03d0a109
PE
6981 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6982
44f730c8
PE
6983 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6984
fe75f926
PE
6985 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6986 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6987
ffa8c828
PE
6988 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6989 This avoids undefined behavior on integer overflow, and is a bit
6990 more convenient anyway since it is compared to a size_t variable.
6991
c5101a77
PE
6992 Variadic C functions now count arguments with size_t, not int.
6993 This avoids an unnecessary limitation on 64-bit machines, which
6994 caused (substring ...) to crash on large vectors (Bug#8344).
6995 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6996 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 6997 All variadic functions and their callers changed accordingly.
c5101a77
PE
6998 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6999 * data.c (arith_driver, float_arith_driver): Likewise.
7000 * editfns.c (general_insert_function): Likewise.
7001 * eval.c (struct backtrace.nargs, interactive_p)
7002 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7003 (funcall_lambda, mark_backtrace): Likewise.
7004 * fns.c (concat): Likewise.
7005 * frame.c (x_set_frame_parameters): Likewise.
7006 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7007 0 if not found, not -1. All callers changed.
7008
dd3f25f7
PE
7009 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7010 (stack_copy_size): Now size_t, not int.
7011 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7012
461c2ab9
JB
70132011-03-28 Juanma Barranquero <lekktu@gmail.com>
7014
7015 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7016 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7017 All callers changed.
7018
7019 * lisp.h (multibyte_char_to_unibyte):
7020 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7021 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7022 * character.h (CHAR_TO_BYTE8):
7023 * cmds.c (internal_self_insert):
7024 * editfns.c (general_insert_function):
7025 * keymap.c (push_key_description):
7026 * search.c (Freplace_match):
7027 * xdisp.c (message_dolog, set_message_1): All callers changed.
7028
f6d62986
SM
70292011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7030
7031 * keyboard.c (safe_run_hook_funcall): New function.
7032 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7033 don't set the hook to nil, but remove the offending function instead.
7034 (Qcommand_hook_internal): Remove, unused.
7035 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7036 Vcommand_hook_internal.
7037
7038 * eval.c (enum run_hooks_condition): Remove.
7039 (funcall_nil, funcall_not): New functions.
7040 (run_hook_with_args): Call each function through a `funcall' argument.
7041 Remove `cond' argument, now redundant.
7042 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7043 (Frun_hook_with_args_until_failure): Adjust accordingly.
7044 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7045
1db5b1ad
JB
70462011-03-28 Juanma Barranquero <lekktu@gmail.com>
7047
7048 * dispextern.h (string_buffer_position): Remove declaration.
7049
7050 * print.c (strout): Remove parameter `multibyte', unused since
7051 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7052
7053 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7054 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7055 All callers changed.
7056
7057 * w32.c (_wsa_errlist): Use braces for struct initializers.
7058
7059 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7060 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7061 All callers changed.
7062 (string_buffer_position): Likewise. Also, make static (it's never
7063 used outside xdisp.c).
7064 (cursor_row_p): Remove parameter `w', unused since
7065 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7066 (decode_mode_spec): Remove parameter `precision', introduced during
7067 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7068 All callers changed.
7069
5ffb62aa
JD
70702011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7071
7072 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7073
461c2ab9 70742011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
7075
7076 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7077 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7078 (ns_update_auto_hide_menu_bar): New functions.
7079 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7080 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7081 ns_constrain_all_frames.
7082 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7083 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7084
5c380ffb
JD
70852011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7086
7087 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7088
9af30bdf
GM
70892011-03-27 Glenn Morris <rgm@gnu.org>
7090
7091 * syssignal.h: Replace RETSIGTYPE with void.
7092 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7093 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7094 Replace SIGTYPE with void everywhere.
7095 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7096 * s/template.h (SIGTYPE): Remove commented out definition.
7097
e2abce01
JB
70982011-03-26 Eli Zaretskii <eliz@gnu.org>
7099
7100 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7101 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7102
f868cd8a
JB
71032011-03-26 Juanma Barranquero <lekktu@gmail.com>
7104
59eb0929
JB
7105 * w32.c (read_unc_volume): Use parameter `henum', instead of
7106 global variable `wget_enum_handle'.
7107
7108 * keymap.c (describe_vector): Remove parameters `indices' and
7109 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7110 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7111
f868cd8a
JB
7112 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7113
7114 * keyboard.c (timer_check): Remove parameter `do_it_now',
7115 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7116 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7117 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7118
7119 * keyboard.c (read_char):
7120 * w32menu.c (w32_menu_display_help):
7121 * xmenu.c (show_help_event, menu_help_callback):
7122 Adjust calls to `show_help_echo'.
7123
7124 * gtkutil.c (xg_maybe_add_timer):
7125 * keyboard.c (readable_events):
7126 * process.c (wait_reading_process_output):
7127 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7128
7129 * insdel.c (adjust_markers_gap_motion):
7130 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7131 (gap_left, gap_right): Don't call it.
7132
2ecf6fdb
CY
71332011-03-25 Chong Yidong <cyd@stupidchicken.com>
7134
7135 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7136 incurred during fontification.
7137
6b1f9ba4
JB
71382011-03-25 Juanma Barranquero <lekktu@gmail.com>
7139
7140 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7141 (DEFVAR_PER_BUFFER): Don't pass it.
7142
7143 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7144 (scrolling_window): Don't pass it.
7145
0f4a96b5
JB
71462011-03-25 Juanma Barranquero <lekktu@gmail.com>
7147
7148 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7149
7150 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7151 and `suffix'.
7152 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7153 of variables specific to SELinux and computation of `encoded_absname'.
7154
7155 * image.c (XPutPixel): Remove unused variable `height'.
7156
7157 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7158
7159 * unexw32.c (get_section_info): Remove unused variable `section'.
7160
7161 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7162 (system_process_attributes): Remove unused variable `sess'.
7163 (sys_read): Remove unused variable `err'.
7164
7165 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7166 (w32_wnd_proc): Remove unused variable `isdead'.
7167 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7168 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7169 (x_create_tip_frame): Remove unused variable `tem'.
7170
7171 * w32inevt.c (w32_console_read_socket):
7172 Remove unused variable `no_events'.
7173
7174 * w32term.c (x_draw_composite_glyph_string_foreground):
7175 Remove unused variable `width'.
7176
1149507c
JB
71772011-03-24 Juanma Barranquero <lekktu@gmail.com>
7178
7179 * w32term.c (x_set_glyph_string_clipping):
7180 Don't pass uninitialized region to CombineRgn.
7181
9c88f339
JB
71822011-03-23 Juanma Barranquero <lekktu@gmail.com>
7183
7184 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7185 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7186 (Fx_close_connection): Remove unused variable `i'.
7187
7188 * w32font.c (w32font_draw): Return number of glyphs.
7189 (w32font_open_internal): Remove unused variable `i'.
7190 (w32font_driver): Add missing initializer.
7191
7192 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7193 (fill_in_menu): Remove unused variable `items_added'.
7194
7195 * w32term.c (last_mouse_press_frame): Remove static global variable.
7196 (w32_clip_to_row): Remove unused variable `f'.
7197 (x_delete_terminal): Remove unused variable `i'.
7198
7199 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7200 (NOTHING): Remove unused static global variable.
7201 (uniscribe_check_otf): Remove unused variable `table'.
7202 (uniscribe_font_driver): Add missing initializers.
7203
dee091a3
JD
72042011-03-23 Julien Danjou <julien@danjou.info>
7205
7206 * term.c (Fsuspend_tty, Fresume_tty):
7207 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7208 * window.c (temp_output_buffer_show):
7209 * insdel.c (signal_before_change):
7210 * frame.c (Fhandle_switch_frame):
7211 * fileio.c (Fdo_auto_save):
7212 * emacs.c (Fkill_emacs):
7213 * editfns.c (save_excursion_restore):
7214 * cmds.c (internal_self_insert):
7215 * callint.c (Fcall_interactively):
7216 * buffer.c (Fkill_all_local_variables):
7217 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7218 Use Frun_hooks.
0f4a96b5 7219 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
7220 unconditionnaly since it does the check itself.
7221
2c520ab5 72222011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 7223
c9c49752
PE
7224 Fix more problems found by GCC 4.5.2's static checks.
7225
8abc3f12
PE
7226 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7227 the first time through the loop, since we know p0 < p1 then.
7228 This also avoids a gcc -Wstrict-overflow warning.
7229
a2d26660
PE
7230 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7231 leading to a memory leak, possible in functions like
7232 load_charset_map_from_file that can allocate an unbounded number
b12ef411 7233 of objects (Bug#8318).
a2d26660 7234
916c72e9
PE
7235 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7236 that could (at least in theory) be that large.
7237
19ab8a18
PE
7238 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7239 This is less likely to overflow, and avoids undefined behavior if
7240 overflow does occur. All callers changed. Use strtoul to scan
7241 for the unsigned long integer.
b7cbbd6f
PE
7242 (pint2hrstr): Simplify and tune code slightly.
7243 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 7244
f0641eff
PE
7245 * scroll.c (do_scrolling): Work around GCC bug 48228.
7246 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7247
7f650bb9
PE
7248 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7249 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
7250 (validate_x_resource_name): Simplify count usage.
7251 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 7252
37dd57d1
PE
7253 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7254 fail (Bug#8306).
81e56e61 7255
699979fc 7256 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 7257
401bf9b4
PE
7258 * process.c (Fmake_network_process): Use socklen_t, not int,
7259 where POSIX says socklen_t is required in portable programs.
7260 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 7261 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
7262 (Fmake_network_process, server_accept_connection):
7263 (wait_reading_process_output, read_process_output):
7264 Likewise.
7265
b93aacde
PE
7266 * process.c: Rename or move locals to avoid shadowing.
7267 (list_processes_1, Fmake_network_process):
7268 (read_process_output_error_handler, exec_sentinel_error_handler):
7269 Rename or move locals.
4dc343ee 7270 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 7271 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 7272 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 7273 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 7274 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 7275
af8a867c 7276 Make tparam.h and terminfo.c consistent.
44f230aa
SM
7277 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7278 Include tparam.h instead, since it declares them.
af8a867c
PE
7279 * cm.h (PC): Remove extern decl; tparam.h now does this.
7280 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7281 * terminfo.c: Include tparam.h, to check interfaces.
7282 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7283 (tparam): Adjust signature to match interface in tparam.h;
7284 this removes some undefined behavior. Check that outstring and len
7285 are zero, which they always are with Emacs.
7286 * tparam.h (PC, BC, UP): New extern decls.
7287
0248044d 7288 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 7289 (xftfont_open): Rename locals to avoid shadowing.
0248044d 7290
8ff096c1 7291 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
7292 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7293 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 7294 (ftfont_list): Remove unused local.
49eaafba
PE
7295 (get_adstyle_property, ftfont_pattern_entity):
7296 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7297 Rename locals to avoid shadowing.
8ff096c1 7298
e2be39f6
PE
7299 * xfont.c (xfont_list_family): Mark var as initialized.
7300
c9735e30
PE
7301 * xml.c (make_dom): Now static.
7302
8f5201ae
PE
7303 * composite.c (composition_compute_stop_pos): Rename local to
7304 avoid shadowing.
b246f932
PE
7305 (composition_reseat_it): Remove unused locals.
7306 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 7307 (composition_update_it): Mark var as initialized.
11b61122
PE
7308 (find_automatic_composition): Mark vars as initialized,
7309 with a FIXME (Bug#8290).
8f5201ae 7310
760fbc2c
PE
7311 character.h: Rename locals to avoid shadowing.
7312 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7313 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7314 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7315 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7316 to avoid shadowing.
7317
ff08eb85
PE
7318 * textprop.c (property_change_between_p): Remove; unused.
7319
fc7bf025
PE
7320 * intervals.c (interval_start_pos): Now static.
7321
235d7abc
PE
7322 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7323
44f230aa
SM
7324 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7325 Rename locals to avoid shadowing.
3e7d6594 7326
50060332
PE
7327 * sound.c (wav_play, au_play, Fplay_sound_internal):
7328 Fix pointer signedness.
d01f234b 7329 (alsa_choose_format): Remove unused local var.
c83b8872
PE
7330 (wav_play): Initialize a variable to 0, to prevent undefined
7331 behavior (Bug#8278).
50060332 7332
c4fc4e30
PE
7333 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7334
918436ed
PE
7335 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7336
c939f91b
PE
7337 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7338 clobbering (Bug#8298).
b9c7f648
PE
7339 * sysdep.c (sys_subshell): Likewise.
7340 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 7341
6bd8c144
PE
7342 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7343 This should get cleaned up, so that child_setup has the
7344 same signature on all platforms.
7345
7710357c 7346 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 7347 (relocate_fd): Rename locals to avoid shadowing.
7710357c 7348
c59da222
CY
73492011-03-22 Chong Yidong <cyd@stupidchicken.com>
7350
7351 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7352 not to be necessary, and produces flickering.
7353
66b87493
GM
73542011-03-20 Glenn Morris <rgm@gnu.org>
7355
7356 * config.in: Remove file.
7357
45b6f6d5
JB
73582011-03-20 Juanma Barranquero <lekktu@gmail.com>
7359
7360 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7361 are now in src/globals.h.
7362 (syms_of_minibuf): Remove spurious & from previous change.
7363
3ec03f7e
LL
73642011-03-20 Leo <sdl.web@gmail.com>
7365
7366 * minibuf.c (completing-read-function): New variable.
7367 (completing-read-default): Rename from completing-read.
7368 (completing-read): Call completing-read-function.
7369
b14e3e21
CY
73702011-03-19 Juanma Barranquero <lekktu@gmail.com>
7371
7372 * xfaces.c (Fx_load_color_file):
7373 Read color file from absolute filename (bug#8250).
7374
f2b726e6
JB
73752011-03-19 Juanma Barranquero <lekktu@gmail.com>
7376
7377 * makefile.w32-in: Update dependencies.
7378
09f6ff02
EZ
73792011-03-17 Eli Zaretskii <eliz@gnu.org>
7380
7381 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7382
29a6015a
PE
73832011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7384
a3a6c54e
PE
7385 Fix more problems found by GCC 4.5.2's static checks.
7386
b766f867
PE
7387 * process.c (make_serial_process_unwind, send_process_trap):
7388 (sigchld_handler): Now static.
7389
be02381c
PE
7390 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7391 That way, the code declares only the vars that it needs.
7392 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7393 * s/cygwin.h (PTY_ITERATION): Likewise.
7394 * s/darwin.h (PTY_ITERATION): Likewise.
7395 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7396
57048744
PE
7397 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7398 * process.c (allocate_pty): Don't declare stb unless it's needed.
7399
7914961c 7400 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
7401 (CONSTANTLIM): Remove; unused.
7402 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7403 Define only if needed.
7914961c 7404
b3967b18
PE
7405 * unexelf.c (unexec): Name an expression,
7406 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
7407 Use a different way to cause a compilation error if anyone uses
7408 n rather than nn, a way that does not involve shadowing.
73366a00 7409 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 7410
29a6015a
PE
7411 * deps.mk (unexalpha.o): Remove; unused.
7412
43cfc33e 7413 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 7414 * unexec.h: New file.
ce701a33
PE
7415 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7416 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7417 Depend on unexec.h.
7418 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7419 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7420 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 7421 Change as necessary to match prototype in unexec.h.
ce701a33 7422
01f44d5a
PE
7423 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7424 shadowing.
4f63c6bb 7425 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 7426
a6670b0b
PE
7427 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7428 Rename locals to avoid shadowing.
7429
cef2010d 7430 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 7431 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 7432
d4d7173a
PE
7433 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7434
f08b802a
PE
7435 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7436 warning when compiling print.c.
7437
3ddb0639
PE
7438 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7439 instead of using an uninitialized var.
5ad03b97 7440 (font_sort_entities): Mark var as initialized.
3ddb0639 7441
170a2692
PE
7442 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7443
e663c700
PE
7444 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7445 pointers to constants.
89bc529a 7446 (font_parse_fcname): Remove unused vars.
7b81e2d0 7447 (font_delete_unmatched): Now static.
ea838e10 7448 (font_get_spec): Remove; unused.
13a547c6
PE
7449 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7450 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7451 Rename or move locals to avoid shadowing.
e663c700 7452
2a80c887 7453 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 7454 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 7455
1384fa33 7456 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 7457 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 7458
8b2c52e9
PE
7459 * alloc.c (mark_backtrace): Move decl from here ...
7460 * lisp.h: ... to here, so that it can be checked.
7461
475545b5 7462 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 7463 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
7464 (lisp_indirect_variable): Name an expression,
7465 to avoid gcc -Wbad-function-cast warning.
1faed8ae 7466 (Fdefvar): Rename locals to avoid shadowing.
475545b5 7467
b1349114 7468 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 7469 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 7470 Use const pointer when appropriate.
b1349114 7471
a2928364
PE
7472 * lisp.h (get_system_name, get_operating_system_release):
7473 Move decls here, to check interfaces.
7474 * process.c (get_operating_system_release): Move decl to lisp.h.
7475 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
7476 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7477 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7478 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
7479 (Fformat_time_string, Fencode_time, Finsert_char):
7480 (Ftranslate_region_internal, Fformat):
7481 Rename or remove local vars to avoid shadowing.
9710023e 7482 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 7483
a415e694
PE
7484 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7485 avoid shadowing.
7486
8ef4622d
PE
7487 * lisp.h (eassert): Check that the argument compiles, even if
7488 ENABLE_CHECKING is not defined.
7489
946f9a5b
PE
7490 * data.c (Findirect_variable): Name an expression, to avoid
7491 gcc -Wbad-function-cast warning.
112396d6 7492 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 7493 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
7494 (Fmake_variable_buffer_local, Fmake_local_variable):
7495 Mark variables as initialized.
52746918 7496 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 7497
e5aab7e7 7498 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
7499 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7500 Rename locals to avoid shadowing.
dff45157
PE
7501 (mark_stack): Move local variables into the #ifdef region where
7502 they're used.
7bc26fdb
PE
7503 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7504 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7505 needed otherwise.
7506 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7507 (GC_STRING_CHARS): Remove; not used.
d40d4be1 7508 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 7509
e5aab7e7
PE
7510 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7511 avoids undefined behavior in theory.
7512
4da60324
PE
7513 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7514
88043301
PE
7515 Use functions, not macros, for up- and down-casing (Bug#8254).
7516 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7517 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7518 to use the following functions instead of these macros.
7519 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7520 EMACS_INT, since callers assume the returned value fits in int.
7521 (upcase1): Likewise, for UPCASE_TABLE.
7522 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 7523 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 7524 the race-condition problem in the old DOWNCASE.
88043301 7525
19ed5445
PE
7526 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7527 Rename locals to avoid shadowing.
7528 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
7529 (regex_compile, re_search_2, re_match_2_internal):
7530 Remove unused local vars.
952db0d7
PE
7531 (FREE_VAR): Rewrite so as not to use empty "else",
7532 which gcc can warn about.
da053e48 7533 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
7534 (RETALLOC_IF): Define only if needed.
7535 (WORDCHAR_P): Likewise. This one is never needed, but is used
7536 only in a comment talking about a compiler bug, so put inside
7537 the #if 0 of that comment.
7538 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7539 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7540 Remove; unused.
19ed5445 7541
1f3561e4 7542 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
7543 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7544 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 7545
ded6f8f7
PE
7546 * search.c (simple_search): Remove unused var.
7547
dbd37a95
PE
7548 * dired.c (compile_pattern): Move decl from here ...
7549 * lisp.h: ... to here, so that it can be checked.
7550 (struct re_registers): New forward decl.
7551
7e47afad
PE
7552 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7553
85f24f61
PE
7554 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7555 All uses changed.
7556 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7557 Rename locals to avoid shadowing.
5671df8f 7558 (Fvertical_motion): Mark locals as initialized.
85f24f61 7559
181aa2be 7560 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 7561 (casify_region): Mark local as initialized.
181aa2be 7562
930d429c
PE
7563 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7564
7082eac6
PE
7565 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7566 New macros, so that the caller can use some names other than
7567 gcpro1, gcpro2, etc.
7568 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7569 of the new macros.
7570 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7571 argument, for consistency with GCPRO2_VAR, etc: it is now the
7572 prefix of the variable, not the variable itself. All uses
7573 changed.
38b2c076
PE
7574 * dired.c (directory_files_internal, file_name_completion):
7575 Rename locals to avoid shadowing.
7576
15206ed9
PE
7577 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7578 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7579 dired.c's scmp function, had undefined behavior.
7580 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7581 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7582 * buffer.h: ... to here, because these macros use current_buffer,
7583 and the new implementation with inline functions needs to have
7584 current_buffer in scope now, rather than later when the macros
7585 are used.
7586 (downcase, upcase1): New static inline functions.
7587 (DOWNCASE, UPCASE1): Reimplement using these functions.
7588 This avoids undefined behavior in expressions like
7589 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7590 from race conditions in accessing the global variables
7591 case_temp1 and case_temp2.
7592 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7593 * lisp.h (case_temp1, case_temp2): Remove their decls.
7594 * character.h (ASCII_CHAR_P): Move from here ...
7595 * lisp.h: ... to here, so that the inline functions mentioned
7596 above can use them.
7597
4a6bea26
PE
7598 * dired.c (directory_files_internal_unwind): Now static.
7599
f14b7e14
PE
7600 * fileio.c (file_name_as_directory, directory_file_name):
7601 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7602 Now static.
2893f146
PE
7603 (file_name_as_directory): Use const pointers when appropriate.
7604 (Fexpand_file_name): Likewise. In particular, newdir might
7605 point at constant storage, so make it a const pointer.
fd4ead52 7606 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
7607 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7608 signedness issues.
f839df0c
PE
7609 (Fset_file_times, Finsert_file_contents, auto_save_error):
7610 Rename locals to avoid shadowing.
f14b7e14 7611
5716756e 7612 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
7613 (Ftry_completion, Fall_completions): Rename or remove locals
7614 to avoid shadowing.
5716756e 7615
b4c3046a
PE
7616 * marker.c (bytepos_to_charpos): Remove; unused.
7617
b45db522
PE
7618 * lisp.h (verify_bytepos, count_markers): New decls,
7619 so that gcc does not warn that these functions aren't declared.
7620
85876d07
PE
7621 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7622 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 7623 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 7624 (copy_text): Remove unused local var.
85876d07 7625
03d78a21 7626 * filelock.c (within_one_second): Now static.
b3dd38ab 7627 (lock_file_1): Rename local to avoid shadowing.
03d78a21 7628
5df8f01b
PE
7629 * buffer.c (fix_overlays_before): Mark locals as initialized.
7630 (fix_start_end_in_overlays): Likewise. This function should be
7631 simplified by using pointers-to-pointers, but that's a different
7632 matter.
b1d876f1 7633 (switch_to_buffer_1): Now static.
8f54f30a
PE
7634 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7635 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 7636
a70072c9 7637 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 7638 Fix pointer signedness issue.
edced198
PE
7639 (sys_subshell): Mark local as volatile if checking for lint,
7640 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 7641 (MAXPATHLEN): Define only if needed.
a70072c9 7642
a0977c44
PE
7643 * process.c (serial_open, serial_configure): Move decls from here ...
7644 * systty.h: ... to here, so that they can be checked.
7645
a884fdcc
PE
7646 * fns.c (get_random, seed_random): Move extern decls from here ...
7647 * lisp.h: ... to here, so that they can be checked.
7648
604efe86 7649 * sysdep.c (reset_io): Now static.
b8950c94 7650 (wait_for_termination_signal): Remove; unused.
604efe86 7651
38fc62d9
PE
7652 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7653 (copy_keymap_item, append_key, push_text_char_description):
7654 Now static.
1004a21a 7655 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 7656 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
7657 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7658 (describe_map_tree):
7659 Rename locals to avoid shadowing.
38fc62d9 7660
2f2650da
PE
7661 * keyboard.c: Declare functions static if they are not used elsewhere.
7662 (echo_char, echo_dash, cmd_error, top_level_2):
7663 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
7664 (read_char, kbd_buffer_get_event, make_lispy_position):
7665 (make_lispy_event, make_lispy_movement, apply_modifiers):
7666 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7667 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7668 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 7669 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 7670 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 7671
a053e86c 7672 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
7673 (mark_kboards): Move decl here ...
7674 * alloc.c (mark_kboards): ... from here.
a053e86c 7675
4752793e
PE
7676 * lisp.h (force_auto_save_soon): New decl.
7677
74f10ca7 7678 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
7679 (DEFINE_DUMMY_FUNCTION): New macro.
7680 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7681 Use it.
c03cd23f
PE
7682 (main): Add casts to avoid warnings
7683 if GCC considers string literals to be constants.
74f10ca7 7684
022e70d4
PE
7685 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7686
59d6fe83
PE
7687 * dbusbind.c: Pointer signedness fixes.
7688 (xd_signature, xd_append_arg, xd_initialize):
7689 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7690 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7691 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7692 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7693
78320123
PE
7694 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7695 if GCC considers string literals to be constants.
49cebcca 7696 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 7697
35ac2a97
SM
76982011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7699
fb103ca9
SM
7700 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7701 (print_preprocess, print_object): New macro to fix last change.
7702
35ac2a97
SM
7703 * print.c (print_preprocess): Don't forget font objects.
7704
62973b41
JB
77052011-03-16 Juanma Barranquero <lekktu@gmail.com>
7706
7707 * emacs.c (USAGE3): Doc fixes.
7708
0e48bb22
AS
77092011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7710
7711 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7712 structure.
7713
7684e57b
JB
77142011-03-14 Juanma Barranquero <lekktu@gmail.com>
7715
7716 * lisp.h (VWindow_system, Qfile_name_history):
7717 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7718 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7719 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7720
7721 * w32select.c: Don't #include "keyboard.h".
c96bbc66 7722 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
7723
7724 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7725 * w32console.c (detect_input_pending, read_input_pending)
7726 (encode_terminal_code):
7727 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7728 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7729 (w32_system_caret_y, Qfile_name_history):
7730 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7731 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7732 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7733 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7734 * w32proc.c (Qlocal, report_file_error):
7735 * w32term.c (Vwindow_system, updating_frame):
7736 * w32uniscribe.c (initialized, uniscribe_font_driver):
7737 Remove unneeded extern declarations.
7738
2aa46d6c
CY
77392011-03-14 Chong Yidong <cyd@stupidchicken.com>
7740
c96bbc66 7741 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 7742
cffc6f3b
CY
77432011-03-13 Chong Yidong <cyd@stupidchicken.com>
7744
7745 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7746 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7747 These macros can no longer be used for assignment.
7748
44f230aa
SM
7749 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7750 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
7751 (record_buffer_markers, fetch_buffer_markers): New functions for
7752 recording and fetching special buffer markers.
7753 (set_buffer_internal_1, set_buffer_temp): Use them.
7754
7755 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7756
7757 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7758
7759 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7760 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7761
7762 * xdisp.c (hscroll_window_tree):
7763 (reconsider_clip_changes): Use PT instead of BUF_PT.
7764
d251f04b
EZ
77652011-03-13 Eli Zaretskii <eliz@gnu.org>
7766
7767 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7768 $(EMACS_ROOT)/lib/intprops.h.
7769
f0c77cd1
PE
77702011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7771
3eca4629
PE
7772 Fix more problems found by GCC 4.5.2's static checks.
7773
7c86ee98
PE
7774 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7775 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
7776 (xg_free_frame_widgets): Make it clear that a local variable is
7777 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
7778 (gdk_window_get_screen): Make it clear that this macro is needed
7779 only if USE_GTK_TOOLTIP.
1e5524e7
PE
7780 (int_gtk_range_get_value): New function, which avoids a diagnostic
7781 from gcc -Wbad-function-cast.
7782 (xg_set_toolkit_scroll_bar_thumb): Use it.
7783 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7784 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
7785 (get_utf8_string, xg_get_file_with_chooser):
7786 Rename locals to avoid shadowing.
7787 (create_dialog): Move locals to avoid shadowing.
7c86ee98 7788
41729b81
PE
7789 * xgselect.c (xg_select): Remove unused var.
7790
f0c77cd1
PE
7791 * image.c (four_corners_best): Mark locals as initialized.
7792 (gif_load): Initialize transparent_p to zero (Bug#8238).
7793 Mark another local as initialized.
ec6cf4c6 7794 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 7795
ce0ad53d 7796 * image.c (clear_image_cache): Now static.
d5d5a617 7797 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 7798 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
7799 (x_edge_detection): Remove unnecessary cast that
7800 gcc -Wbad-function-cast diagnoses.
2037898d 7801 (gif_load): Fix pointer signedness.
6ae141d6
PE
7802 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7803 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 7804
33383987 78052011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 7806
d32df629
PE
7807 Improve quality of tests for time stamp overflow.
7808 For example, without this patch (encode-time 0 0 0 1 1
7809 1152921504606846976) returns the obviously-bogus value (-948597
7810 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7811 reports time overflow. See
7812 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
7813 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7814 * editfns.c: Include limits.h and intprops.h.
7815 (TIME_T_MIN, TIME_T_MAX): New macros.
7816 (time_overflow): Move earlier, to before first use.
7817 (hi_time, lo_time): New functions, for an accurate test for
7818 out-of-range times.
7819 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7820 (Fget_internal_run_time): Don't assume time_t fits in int.
7821 (make_time): Use list2 instead of Fcons twice.
7822 (Fdecode_time): More accurate test for out-of-range times.
7823 (check_tm_member): New function.
7824 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
7825 (lisp_time_argument): Don't rely on undefined left-shift and
7826 right-shift behavior when checking for time stamp overflow.
8be6f318 7827
fe31d94c
PE
7828 * editfns.c (time_overflow): New function, refactoring common code.
7829 (Fformat_time_string, Fdecode_time, Fencode_time):
7830 (Fcurrent_time_string): Use it.
7831
8be6f318
PE
7832 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7833 * dired.c (make_time): Move to ...
7834 * editfns.c (make_time): ... here.
7835 * systime.h: Note the move.
7836
09d9db2c 78372011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 7838
126bc0dc
YM
7839 * fringe.c (update_window_fringes): Remove unused variables.
7840
c47cbdfd
YM
7841 * unexmacosx.c (copy_data_segment): Also copy __got section.
7842 (Bug#8223)
7843
7ac80be9
EZ
78442011-03-12 Eli Zaretskii <eliz@gnu.org>
7845
c96bbc66 7846 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
7847 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7848 Constify `char *' arguments and their references according to
7849 prototypes in tparam.h.
7850
ecb0f94d 7851 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 7852
7ac80be9
EZ
7853 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7854 Adapt all references accordingly.
7855
7856 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7857
ef1fd07e
TT
78582011-03-11 Tom Tromey <tromey@redhat.com>
7859
7860 * buffer.c (syms_of_buffer): Remove obsolete comment.
7861
7ef4b50c
EZ
78622011-03-11 Eli Zaretskii <eliz@gnu.org>
7863
7864 * termhooks.h (encode_terminal_code): Declare prototype.
7865
7866 * msdos.c (encode_terminal_code): Don't declare prototype.
7867
7868 * term.c (encode_terminal_code): Now external again, used by
7869 w32console.c and msdos.c.
7870
44f230aa
SM
7871 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7872 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 7873
4b1ec863 78742011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 7875
1714f52b 7876 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 7877
4b1ec863
PE
7878 * fringe.c (update_window_fringes): Mark locals as initialized
7879 (Bug#8227).
7880 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 7881
524c7aa6
PE
7882 * alloc.c (mark_fringe_data): Move decl from here ...
7883 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7884 to check its interface.
7885 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7886
a5c0af81 7887 * fontset.c (free_realized_fontset): Now static.
7519b8cd 7888 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 7889 (fontset_font): Mark local as initialized.
a9a06e0b 7890 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 7891
b4716021
PE
7892 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7893
811e9bac 7894 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 7895 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
7896 (x_own_selection, Fx_disown_selection_internal): Rename locals
7897 to avoid shadowing.
7898 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 7899
7e3ab302
PE
7900 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7901 so that the caller can use some name other than gcpro1.
7902 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
7903 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7904 (Fx_backspace_delete_keys_p):
7905 Use them to avoid shadowing, and rename vars to avoid shadowing.
7906 (x_decode_color, x_set_name, x_window): Now static.
6b437900 7907 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 7908 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
7909 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7910 Remove unused locals.
7e3ab302
PE
7911 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7912 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7913 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7914 macros.
f78faa98 7915
e2b13473
PE
7916 * xterm.h (x_mouse_leave): New decl.
7917
77f23912
PE
7918 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7919 Remove unused functions.
cdf4ba58
PE
7920 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7921 (x_calc_absolute_position): Now static.
7411c686 7922 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 7923 Don't declare local "event" unless it's used.
ed7bf3a5
PE
7924 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7925 unless they are used.
38d0b34a
PE
7926 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7927 (x_fatal_error_signal): Remove; not used.
a6067996
PE
7928 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7929 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7930 (x_error_catcher, x_connection_closed, x_error_handler):
7931 (x_error_quitter, xembed_send_message, x_iconify_frame):
7932 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 7933 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 7934 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 7935
44f230aa
SM
7936 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7937 Rename or move locals to avoid shadowing.
6b463e58 7938 (tty_defined_color, merge_face_heights): Now static.
5967d051 7939 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
7940 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7941 does not deduce is never used uninitialized.
73719eba
PE
7942 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7943 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 7944
426994c3 7945 * terminal.c (store_terminal_param): Now static.
5489860b 7946
032f1620 7947 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 7948 (set_frame_menubar): Remove unused local.
d4323972 7949 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
7950 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7951 since they might point to immutable storage.
281585b0
PE
7952 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7953 since it's unused otherwise.
032f1620 7954
367c19e5 7955 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 7956 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
7957 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7958 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 7959 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
7960 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7961 does not deduce are never used uninitialized.
70739cbe 7962
07b48fa9
PE
7963 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7964
8868a238 7965 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
7966 * window.c (window_loop, size_window):
7967 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 7968
7e5cf297 7969 * window.c (display_buffer): Now static.
d6550a9f
PE
7970 (size_window): Mark variables that gcc -Wuninitialized
7971 does not deduce are never used uninitialized.
a586633d
PE
7972 * window.h (check_all_windows): New decl, to forestall
7973 gcc -Wmissing-prototypes diagnostic.
5b555da1 7974 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 7975
f6095868
PE
7976 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7977 shadowing.
7978 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
7979 Include <limits.h>.
7980 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7981 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
7982 (load_charset_map): Mark variables that gcc -Wuninitialized
7983 does not deduce are never used uninitialized.
53df7c11 7984 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 7985
f38b440c
PE
7986 * coding.c (coding_set_source, coding_set_destination):
7987 Use "else { /* comment */ }" rather than "else /* comment */;"
7988 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
7989 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7990 a block, when the outer 'i' will do.
7991 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7992 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7993 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7994 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7995 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7996 Rename locals to avoid shadowing.
7997 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
7998 * coding.c (emacs_mule_char, encode_invocation_designation):
7999 Now static, since they're not used elsewhere.
413bb2db 8000 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 8001 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
8002 (decode_coding_emacs_mule): Mark variables that gcc
8003 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
8004 (detect_coding_iso_2022): Initialize a local variable that might
8005 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 8006 this initialization is needed. (Bug#8211)
5f58e762
PE
8007 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8008 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8009 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8010 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8011 Remove unused macros.
f38b440c 8012
232b38b9 8013 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 8014 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 8015 * character.c (string_count_byte8): Likewise.
232b38b9 8016
fb90da1b
PE
8017 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8018 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8019
fb93dbc2
PE
8020 * chartab.c (copy_sub_char_table): Now static, since it's not used
8021 elsewhere.
5c156ace
PE
8022 (sub_char_table_ref_and_range, char_table_ref_and_range):
8023 Rename locals to avoid shadowing.
bbcd0949 8024 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 8025
7d3b3862 8026 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 8027 (BIDI_BOB): Remove unused macro.
7d3b3862 8028
6be7d3da
PE
8029 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8030 deduce are never used uninitialized.
c2ed9c8b 8031 * term.c (encode_terminal_code): Likewise.
6be7d3da 8032
75f8807f 8033 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 8034
50938595
PE
8035 * tparam.h: New file.
8036 * term.c, tparam.h: Include it.
8037 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8038 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8039 Move these decls to tparam.h, and make them agree with what
8040 is actually in tparam.c. The previous trick of using incompatible
8041 decls in different modules does not conform to the C standard.
8042 All callers of tparam changed to use tparam's actual API.
8043 * tparam.c (tparam1, tparam, tgoto):
8044 Use const pointers where appropriate.
8045
fbceeba2
PE
8046 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8047 * cm.h (struct cm): Likewise.
8048 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8049 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8050 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8051 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8052 (turn_on_face, init_tty): Likewise.
8053 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 8054
7f3f1250
PE
8055 * term.c (term_mouse_position): Rename local to avoid shadowing.
8056
e6ca6543
PE
8057 * alloc.c (mark_ttys): Move decl from here ...
8058 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8059
c40f8d15
AS
80602011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8061
8062 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8063
cfe0661d
JB
80642011-03-09 Juanma Barranquero <lekktu@gmail.com>
8065
8066 * search.c (compile_pattern_1): Remove argument regp, unused since
8067 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8068 (compile_pattern): Don't pass it.
8069
0afb4571
J
80702011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8071
8072 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8073 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8074 for ! HAVE_GTK3.
8075 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8076
8077 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8078
8079 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8080 gdk_window_get_screen, gdk_window_get_geometry,
8081 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8082 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8083 (xg_get_pixbuf_from_pixmap): New function.
8084 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8085 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8086 Call xg_get_pixbuf_from_pixmap instead of
8087 gdk_pixbuf_get_from_drawable.
8088 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8089 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8090 (xg_check_special_colors): Use GtkStyleContext and its functions
8091 for HAVE_GTK3.
8092 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8093 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8094 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
8095 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8096 Call gtk_widget_get_preferred_size.
0afb4571
J
8097 (xg_frame_resized): gdk_window_get_geometry only takes 5
8098 parameters.
44f230aa
SM
8099 (xg_win_to_widget, xg_event_is_for_menubar):
8100 Call gdk_x11_window_lookup_for_display.
0afb4571
J
8101 (xg_set_widget_bg): New function.
8102 (delete_cb): New function.
895009e1 8103 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
8104 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
8105 (xg_set_background_color): Call xg_set_widget_bg.
8106 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8107 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8108 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8109 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8110 if ! HAVE_GTK3.
8111 (update_frame_tool_bar): Call gtk_widget_hide.
8112 (xg_initialize): Use GDK_KEY_g.
8113
8114 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8115 if ! HAVE_GTK3
8116 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8117
8118 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8119 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8120 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8121
1c2cc4ef
JB
81222011-03-08 Juanma Barranquero <lekktu@gmail.com>
8123
8124 * w32xfns.c (select_palette): Check success of RealizePalette against
8125 GDI_ERROR, not zero.
8126
33383987 8127See ChangeLog.11 for earlier changes.
aac0c6e3
MR
8128
8129;; Local Variables:
8130;; coding: utf-8
aac0c6e3
MR
8131;; End:
8132
33383987 8133 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
8134
8135 This file is part of GNU Emacs.
8136
8137 GNU Emacs is free software: you can redistribute it and/or modify
8138 it under the terms of the GNU General Public License as published by
8139 the Free Software Foundation, either version 3 of the License, or
8140 (at your option) any later version.
8141
8142 GNU Emacs is distributed in the hope that it will be useful,
8143 but WITHOUT ANY WARRANTY; without even the implied warranty of
8144 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8145 GNU General Public License for more details.
8146
8147 You should have received a copy of the GNU General Public License
8148 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.