Fix my mail address.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
9a79b20c
AS
12011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2
3 * print.c (print_object): Print empty symbol as ##.
4
5 * lread.c (read1): Read ## as empty symbol.
6
d8c2fa78
AA
72011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
8
9 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
10 setting frame foreground color (Bug#9175).
11 (x_set_background_color): Likewise.
12
ffe57a7a
AA
13 * nsmenu.m (-setText): Size tooltip dimensions precisely to
14 contents (Bug#9176).
15 (EmacsTooltip -init): Remove bezels and add shadows to
16 tooltip windows.
17
bf3492a5
AA
18 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
19 or scroll bar (Bug#8470).
20
d55e9c53
AA
21 * nsfont.m (nsfont_open): Remove assignment to voffset and
22 unnecessary vars hshink, expand, hd, full_height, min_height.
23 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
24
25 * nsterm.h (nsfont_info): Remove voffset field.
26
d8c2fa78 272011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
28
29 Implement strike-through and overline on NextStep (Bug#8863).
30
31 * nsfont.m (nsfont_open): Use underline position provided by font,
32 instead of hard-coded value of 2.
33 (nsfont_draw): Call ns_draw_text_decoration instead.
34
35 * nsterm.h: Add declaration for ns_draw_text_decoration.
36
37 * nsterm.m (ns_draw_text_decoration): New function for drawing
38 underline, overline, and strike-through.
39 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
40 ns_draw_text_decoration. Change treatment of cursor drawing to
41 accomodate underlining, etc.
42
4cc60b9b
EZ
432011-07-28 Eli Zaretskii <eliz@gnu.org>
44
bc7ece87
EZ
45 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
46 default.
4cc60b9b 47
476371c4
PE
482011-07-28 Paul Eggert <eggert@cs.ucla.edu>
49
66606eea
PE
50 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
51 Without this fix, if a signal arrives just after memory fills up,
52 'malloc' might be invoked reentrantly.
53
476371c4
PE
54 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
55 In other words, assume that every image size is allowed, on non-X
56 hosts. This assumption is probably wrong, but it lets Emacs compile.
57
f3fcc40d
AS
582011-07-28 Andreas Schwab <schwab@linux-m68k.org>
59
60 * regex.c (re_iswctype): Convert return values to boolean.
61
350c992f
EZ
622011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
63
64 * xdisp.c (compute_display_string_pos): Don't use cached display
65 string position if the buffer had its restriction changed.
66 (Bug#9184)
67
5266b4bb
PE
682011-07-28 Paul Eggert <eggert@cs.ucla.edu>
69
70 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
71
2573a837 722011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 73
41f55ccd 74 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 75
39e378da
PE
76 * bidi.c: Integer size and overflow fixes.
77 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
78 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
79 (bidi_cache_find_level_change, bidi_cache_ensure_space)
80 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
81 (bidi_find_other_level_edge):
82 Use ptrdiff_t instead of EMACS_INT where either will do.
83 This works better on 32-bit hosts configured --with-wide-int.
84 (bidi_cache_ensure_space): Check for size-calculation overflow.
85 Use % rather than repeated addition, for better worst-case speed.
86 Don't set bidi_cache_size until after xrealloc returns, because it
87 might not return.
88 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
89 (bidi_cache_ensure_space): Also check that the bidi cache size
90 does not exceed that of the largest Lisp string or buffer. See Eli
91 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 92
5e927815
PE
93 * alloc.c (__malloc_size_t): Remove.
94 All uses replaced by size_t. See Andreas Schwab's note
95 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
96
ca4aa935
PE
97 * image.c: Improve checking for integer overflow.
98 (check_image_size): Assume that f is nonnull, since
99 it is always nonnull in practice. This is one less thing to
100 worry about when checking for integer overflow later.
101 (x_check_image_size): New function, which checks for integer
102 overflow issues inside X.
103 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
104 This removes the need for a memory_full check.
105 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
106 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
107 (xbm_read_bitmap_data): Change locals back to 'int', since
108 their values must fit in 'int'.
109 (xpm_load_image, png_load, tiff_load):
110 Invoke x_create_x_image_and_pixmap earlier,
111 to avoid much needless work if the image is too large.
112 (tiff_load): Treat overly large images as if
113 x_create_x_image_and_pixmap failed, not as malloc failures.
114 (gs_load): Use x_check_image_size.
115
5f8f9cc2
PE
116 * gtkutil.c: Omit integer casts.
117 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
118 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
119
5adf60bc
PE
120 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
121
c8907a93
PE
122 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
123 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
124 would wrongly return t on a 64-bit host.
125
e3c25c68
PE
126 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
127 The plain *_OVERFLOW macros run afoul of GCC bug 49705
128 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
129 and therefore cause GCC to emit a bogus diagnostic in some cases.
130
3f791afe
PE
131 * image.c: Integer signedness and overflow and related fixes.
132 This is not an exhaustive set of fixes, but it's time to
133 record what I've got.
134 (lookup_pixel_color, check_image_size): Remove redundant decls.
135 (check_image_size): Don't assume that arbitrary EMACS_INT values
136 fit in 'int', or that arbitrary 'double' values fit in 'int'.
137 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
138 (tiff_load, imagemagick_load_image):
139 Check for overflow in size calculations.
140 (x_create_x_image_and_pixmap): Remove unnecessary test for
141 xmalloc returning NULL; that can't happen.
142 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
143 (xpm_color_bucket): Use better integer hashing function.
144 (xpm_cache_color): Don't possibly over-allocate memory.
145 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
146 (gif_memory_source):
147 Use ptrdiff_t, not int or size_t, to record sizes.
148 (png_load): Don't assume values greater than 2**31 fit in 'int'.
149 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
150 either works, as we prefer signed integers.
151 (tiff_read_from_memory, tiff_write_from_memory):
152 Return tsize_t, not size_t, since that's what the TIFF API wants.
153 (tiff_read_from_memory): Don't fail simply because the read would
154 go past EOF; instead, return a short read.
155 (tiff_load): Omit no-longer-needed casts.
156 (Fimagemagick_types): Don't assume size fits into 'int'.
157
3cc5a532
PE
158 Improve hashing quality when configured --with-wide-int.
159 * fns.c (hash_string): New function, taken from sxhash_string.
160 Do not discard information about ASCII character case; this
161 discarding is no longer needed.
162 (sxhash-string): Use it. Change sig to match it. Caller changed.
163 * lisp.h: Declare it.
164 * lread.c (hash_string): Remove, since we now use fns.c's version.
165 The fns.c version returns a wider integer if --with-wide-int is
166 specified, so this should help the quality of the hashing a bit.
167
b312a492
PE
168 * emacs.c: Integer overflow minor fix.
169 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
170 Define only if GNU_LINUX.
171 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
172
dfd153ae
PE
173 * dispnew.c: Integer signedness and overflow fixes.
174 Remove unnecessary forward decls, that were a maintenance hassle.
175 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
176 All uses changed.
177 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
178 (scrolling_window): Use ptrdiff_t, not int, for byte count.
179 (prepare_desired_row, line_draw_cost):
180 Use int, not unsigned, where either works.
181 (save_current_matrix, restore_current_matrix):
182 Use ptrdiff_t, not size_t, where either works.
183 (init_display): Check for overflow more accurately, and without
184 relying on undefined behavior.
185
a81d11a3
PE
186 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
187 Remove, replacing with the new symbols in lisp.h. All uses changed.
188 * fileio.c (make_temp_name):
189 * filelock.c (lock_file_1, lock_file):
190 * xdisp.c (message_dolog):
191 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
192 Use pMd etc. instead.
193 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
194 replacing the pWIDE etc. symbols removed from editfns.c.
195
3300e6fd
PE
196 * keyboard.h (num_input_events): Now uintmax_t.
197 This is (very slightly) less likely to mess up due to wraparound.
198 All uses changed.
199
fd05c7e9
PE
200 * buffer.c: Integer signedness fixes.
201 (alloc_buffer_text, enlarge_buffer_text):
202 Use ptrdiff_t rather than size_t when either will do, as we prefer
203 signed integers.
204
903fe15d
PE
205 * alloc.c: Integer signedness and overflow fixes.
206 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
207 (__malloc_size_t): Default to size_t, not to int.
208 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
209 (Fgarbage_collect, mark_object_loop_halt, mark_object):
210 Prefer ptrdiff_t to size_t when either would do, as we prefer
211 signed integers.
212 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
213 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
214 Now const. Initialize with values that are in range even if char
215 is signed.
216 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
217 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
218 These functions do the right thing with sizes > 2**32.
219 (check_depth): Now ptrdiff_t, not int.
220 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
221 Adjust to new way of storing sizes. Check for size overflow bugs
222 in rest of code.
223 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
224 slightly wrong anyway, as it missed one instance of
225 XMALLOC_OVERRUN_CHECK_OVERHEAD.
226 (refill_memory_reserve): Omit needless cast to size_t.
227 (mark_object_loop_halt): Mark as externally visible.
228
ac82cc6a
PE
229 * xselect.c: Integer signedness and overflow fixes.
230 (Fx_register_dnd_atom, x_handle_dnd_message):
231 Use ptrdiff_t, not size_t, since we prefer signed.
232 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
233 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
234 x_dnd_atoms_size and x_dnd_atoms_length.
235
c2d1e36d
PE
236 * doprnt.c: Prefer signed to unsigned when either works.
237 * eval.c (verror):
238 * doprnt.c (doprnt):
239 * lisp.h (doprnt):
240 * xdisp.c (vmessage):
241 Use ptrdiff_t, not size_t, when using or implementing doprnt,
242 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
243 prefer signed arithmetic to avoid comparison confusion.
244 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
245 but is a bit tricky.
246
0e926e56
PE
247 Assume freestanding C89 headers, string.h, stdlib.h.
248 * data.c, doprnt.c, floatfns.c, print.c:
249 Include float.h unconditionally.
250 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
251 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
252 * regex.c: Likewise for stddef.h, string.h.
253 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
254 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
255 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
256 (STDC_HEADERS): Remove obsolete defines.
257 * sysdep.c: Include limits.h unconditionally.
258
9cfdb3ec
PE
259 Assume support for memcmp, memcpy, memmove, memset.
260 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
261 * regex.c (memcmp, memcpy):
262 Remove; we assume C89 now.
263
264 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
265 (__malloc_safe_bcopy): Remove; no longer needed.
266
cf950e6b 267 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
268 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
269 well either way, and we prefer signed to unsigned.
270
dbf38e02
LMI
2712011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
272
273 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
274 closes the connection while we're reading (bug#9182).
275
d6f0886c
JD
2762011-07-25 Jan Djärv <jan.h.d@swipnet.se>
277
278 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
279 are specified (Bug#9168).
280
2eb1f9e6
PE
2812011-07-25 Paul Eggert <eggert@cs.ucla.edu>
282
283 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
284 Found by GCC static checking and --with-wide-int on a 32-bit host.
285
22381272 2862011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
287
288 * xdisp.c (compute_display_string_pos): Fix logic of caching
289 previous display string position. Initialize cached_prev_pos to
290 -1. Fixes slow-down at the beginning of a buffer.
291
f25e39b4
EZ
2922011-07-24 Eli Zaretskii <eliz@gnu.org>
293
294 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
295 for attrs[LFACE_FONTSET_INDEX].
296
04c4b52e
PE
2972011-07-23 Paul Eggert <eggert@cs.ucla.edu>
298
299 * xml.c (parse_region): Remove unused local
300 that was recently introduced.
301
c1734fbd
EZ
3022011-07-23 Eli Zaretskii <eliz@gnu.org>
303
be18c5a5
EZ
304 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
305 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
306
c1734fbd
EZ
307 * xdisp.c (move_it_in_display_line_to): Record the best matching
308 position for TO_CHARPOS while scanning the line, and restore it on
309 exit if none of the characters scanned was an exact match. Fixes
a9269c18
EZ
310 vertical-motion and pos-visible-in-window-p under bidi redisplay
311 when exact match is impossible due to invisible text, and the
312 lines are truncated.
313
a258d627
JD
3142011-07-23 Jan Djärv <jan.h.d@swipnet.se>
315
316 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
317 for OSX >= 10.7.
318
b6d5a689
EZ
3192011-07-22 Eli Zaretskii <eliz@gnu.org>
320
0f74f785
EZ
321 Fix a significant slow-down of cursor motion with C-n, C-p,
322 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
323 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 324 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
325 (next_element_from_buffer): Call compute_stop_pos_backwards to
326 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
327 base_level_stop.
328 (reseat): Don't look for prev_stop, as that could mean a very long
329 run.
330 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
331 <cached_disp_overlay_modiff>: Cache for last found display string
332 position.
551918c1 333 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
334 about the same buffer in the same area of character positions, and
335 the buffer wasn't changed since the time the display string
336 position was cached.
551918c1 337
b2d0c91a
EZ
3382011-07-22 Eli Zaretskii <eliz@gnu.org>
339
340 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
341 is an integer, which is important for empty lines. (Bug#9149)
342
043604ee
CY
3432011-07-22 Chong Yidong <cyd@stupidchicken.com>
344
345 * frame.c (Fmodify_frame_parameters): In tty case, update the
346 default face if necessary (Bug#4238).
347
da4adb04
CY
3482011-07-21 Chong Yidong <cyd@stupidchicken.com>
349
350 * editfns.c (Fstring_to_char): No need to explain what a character
351 is in the docstring (Bug#6576).
352
9abd0532
LMI
3532011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
354
355 * xml.c (parse_region): Make sure we always return a tree.
356
36881d16
HK
3572011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
358
359 * xml.c (parse_region): If a document contains only comments,
360 return that, too.
361
1e98674d
LMI
3622011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
363
364 * xml.c (make_dom): Return comments, too.
365
590bd467
PE
3662011-07-19 Paul Eggert <eggert@cs.ucla.edu>
367
368 Port to OpenBSD.
369 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
370 and the surrounding thread.
371 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
372 rather than fgets, and retry after EINTR. Otherwise, 'emacs
373 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
374 timer goes off.
375 * s/openbsd.h (BROKEN_SIGIO): Define.
376 * unexelf.c (unexec) [__OpenBSD__]:
377 Don't update the .mdebug section of the Alpha COFF symbol table.
378
f41628b2
LMI
3792011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
380
381 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
382 (bug#8460).
383
b59b67c5
PE
3842011-07-18 Paul Eggert <eggert@cs.ucla.edu>
385
15e3a074
PE
386 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
387 This fixes some race conditions on the permissions of any newly
388 created file.
389
41bed37d
PE
390 * alloc.c (valid_pointer_p): Use pipe, not open.
391 This fixes some permissions issues when debugging.
392
b59b67c5
PE
393 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
394 If fchown fails to set both uid and gid, try to set just gid,
395 as that is sometimes allowed. Adjust the file's mode to eliminate
396 setuid or setgid bits that are inappropriate if fchown fails.
397
925a6be7
SM
3982011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
399
400 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
401 to compare Lisp_Objects.
402 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
403 global_gnutls_log_level, don't mistake it for a Lisp_Object.
404 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
405
52968808
AS
4062011-07-17 Andreas Schwab <schwab@linux-m68k.org>
407
0a6a104b
AS
408 * lread.c (read_integer): Unread even EOF character.
409 (read1): Likewise. Properly record start position of symbol.
410
52968808
AS
411 * lread.c (read1): Read `#:' as empty uninterned symbol if no
412 symbol character follows.
413
9e381cdd
PE
4142011-07-17 Paul Eggert <eggert@cs.ucla.edu>
415
416 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
417 This works around a problem with the previous change to Fcopy_file.
418 Recent glibc declares fchown with __attribute__((warn_unused_result)),
419 and without this change, GCC might complain about discarding
420 fchown's return value.
421
b5641435
JB
4222011-07-16 Juanma Barranquero <lekktu@gmail.com>
423
424 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
425
a8031457
PE
4262011-07-16 Paul Eggert <eggert@cs.ucla.edu>
427
428 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
429
dd889327
LMI
4302011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
431
750c33f7
LMI
432 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
433 it's used from the C level.
434
dd889327
LMI
435 * process.c: Use the same condition for POLL_FOR_INPUT in both
436 keyboard.c and process.c (bug#1858).
437
87e86684
LM
4382011-07-09 Lawrence Mitchell <wence@gmx.li>
439
440 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
441 (Fgnutls_boot): Use it.
442
64348f40
AS
4432011-07-15 Andreas Schwab <schwab@linux-m68k.org>
444
445 * doc.c (Fsubstitute_command_keys): Revert last change.
446
1d698799
LMI
4472011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
448
f863868c
LMI
449 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
450 quotes the next character, and doesn't affect other longer
451 sequences (bug#8935).
452
1d698799
LMI
453 * lread.c (syms_of_lread): Clarify that is isn't only
454 `eval-buffer' and `eval-defun' that's affected by
455 `lexical-binding' (bug#8460).
456
aa4b6df6
EZ
4572011-07-15 Eli Zaretskii <eliz@gnu.org>
458
459 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
460 bidi redisplay when a line includes both an image and is
461 truncated.
462
5d856da6
PE
4632011-07-14 Paul Eggert <eggert@cs.ucla.edu>
464
ad6042bb
PE
465 Fix minor problems found by static checking.
466 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
467 (elsz): Now a signed constant, not a size_t var. We prefer signed
468 types to unsigned, to avoid integer comparison confusion. Without
469 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
470 "cannot optimize loop, the loop counter may overflow", a symptom
471 of the confusion.
f00bbb22 472 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
473 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
474
6468f31c
LMI
4752011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
476
49080b10
LMI
477 * search.c (Fre_search_backward): Mention `case-fold-search' in
478 all the re_search_* functions (bug#8138).
479
6468f31c
LMI
480 * keyboard.c (Fopen_dribble_file): Document when the file is
481 closed (bug#8056).
482
c965adc5
EZ
4832011-07-14 Eli Zaretskii <eliz@gnu.org>
484
df9733bf
EZ
485 * bidi.c (bidi_dump_cached_states): Fix format of displaying
486 bidi_cache_idx.
487
0bb23927
EZ
488 Support bidi reordering of display and overlay strings.
489 * xdisp.c (compute_display_string_pos)
490 (compute_display_string_end): Accept additional argument STRING.
491 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
492 (reseat_to_string): Initialize bidi_it->string.s and
493 bidi_it->string.schars.
494 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
495 NULL (avoids a crash in bidi_paragraph_init). Initialize
496 itb.string.lstring.
497 (init_iterator): Call bidi_init_it only of a valid
498 buffer position was specified. Initialize paragraph_embedding to
499 L2R.
500 (reseat_to_string): Initialize the bidi iterator.
501 (display_string): If we need to ignore text properties of
502 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
503 original value of -1 will not work with bidi.)
504 (compute_display_string_pos): First arg is now struct
505 `text_pos *'; all callers changed. Support display properties on
506 Lisp strings.
507 (compute_display_string_end): Support display properties on Lisp
508 strings.
509 (init_iterator, reseat_1, reseat_to_string): Initialize the
510 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
511 when iterating on a string not from display properties).
512 (compute_display_string_pos, compute_display_string_end): Fix
513 calculation of the object to scan. Fixes an error when using
514 arrow keys.
515 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
516 base_level_stop; instead, set base_level_stop to BEGV. Fixes
517 crashes in vertical-motion.
518 (next_element_from_buffer): Improve commentary for when
519 the iterator is before prev_stop.
520 (init_iterator): Initialize bidi_p from the default value of
521 bidi-display-reordering, not from buffer-local value. Use the
522 buffer-local value only if initializing for buffer iteration.
523 (handle_invisible_prop): Support invisible properties on strings
524 that are being bidi-reordered.
525 (set_iterator_to_next): Support bidi reordering of C strings and
526 Lisp strings.
527 (next_element_from_string): Support bidi reordering of Lisp
528 strings.
529 (handle_stop_backwards): Support Lisp strings as well.
530 (display_string): Support display of R2L glyph rows. Use
531 IT_STRING_CHARPOS when displaying from a Lisp string.
532 (init_iterator): Don't initialize it->bidi_p for strings
533 here.
534 (reseat_to_string): Initialize it->bidi_p for strings here.
535 (next_element_from_string, next_element_from_c_string)
536 (next_element_from_buffer): Add xassert's for correspondence
537 between IT's object being iterated and it->bidi_it.string
538 structure.
539 (face_before_or_after_it_pos): Support bidi iteration.
540 (next_element_from_c_string): Handle the case of the first string
541 character that is not the first one in the visual order.
542 (get_visually_first_element): New function, refactored from common
543 parts of next_element_from_buffer, next_element_from_string, and
544 next_element_from_c_string.
545 (tool_bar_lines_needed, redisplay_tool_bar)
546 (display_menu_bar): Force left-to-right direction. Add a FIXME
547 comment for making that be controlled by a user option.
548 (push_it, pop_it): Save and restore the state of the
549 bidi iterator. Save and restore the bidi_p flag.
550 (pop_it): Iterate out of display property for string iteration as
551 well.
552 (iterate_out_of_display_property): Support iteration over strings.
553 (handle_single_display_spec): Set up it->bidi_it for iteration
554 over a display string, and call bidi_init_it.
555 (handle_single_display_spec, next_overlay_string)
556 (get_overlay_strings_1, push_display_prop): Set up the bidi
557 iterator for displaying display or overlay strings.
558 (forward_to_next_line_start): Don't use the shortcut if
559 bidi-iterating.
560 (back_to_previous_visible_line_start): If handle_display_prop
561 pushed the iterator stack, restore the internal state of the bidi
562 iterator by calling bidi_pop_it same number of times.
563 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
564 and we are bidi-iterating, don't decrement the iterator position;
565 instead, set the first_elt flag in the bidi iterator, to produce
566 the same effect.
567 (reseat_1): Remove redundant setting of string_from_display_prop_p.
568 (push_display_prop): xassert that we are iterating a buffer.
569 (push_it, pop_it): Save and restore paragraph_embedding member.
570 (handle_single_display_spec, next_overlay_string)
571 (get_overlay_strings_1, reseat_1, reseat_to_string)
572 (push_display_prop): Set up the `unibyte' member of bidi_it.string
573 correctly. Don't assume unibyte strings are not bidi-reordered.
574 (compute_display_string_pos)
575 (compute_display_string_end): Fix handling the case of C string.
576 (push_it, pop_it): Save and restore from_disp_prop_p.
577 (handle_single_display_spec, push_display_prop): Set the
578 from_disp_prop_p flag.
579 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
580 (pop_it): Call iterate_out_of_display_property only if we are
581 popping after iteration over a string that came from a display
582 property. Fix a typo in popping stretch info. Add an assertion
583 for verifying that the iterator position is in sync with the bidi
584 iterator.
585 (handle_single_display_spec, get_overlay_strings_1)
586 (push_display_prop): Fix initialization of paragraph direction for
587 string when that of the parent object is not yet determined.
588 (reseat_1): Call bidi_init_it to resync the bidi
589 iterator with IT's position. (Bug#7616)
590 (find_row_edges): If ROW->start.pos gives position
591 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
592 (handle_stop, back_to_previous_visible_line_start, reseat_1):
593 Reset the from_disp_prop_p flag.
594 (SAVE_IT, RESTORE_IT): New macros.
595 (pos_visible_p, face_before_or_after_it_pos)
596 (back_to_previous_visible_line_start)
597 (move_it_in_display_line_to, move_it_in_display_line)
598 (move_it_to, move_it_vertically_backward, move_it_by_lines)
599 (try_scrolling, redisplay_window, display_line): Use them when
600 saving a temporary copy of the iterator and restoring it back.
601 (back_to_previous_visible_line_start, reseat_1)
602 (init_iterator): Empty the bidi cache "stack".
603 (move_it_in_display_line_to): If iterator ended up at
604 EOL, but we never saw any buffer positions smaller than
605 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
606 motion in bidi-reordered lines.
607 (move_it_in_display_line_to): Record prev_method and prev_pos
608 immediately before the call to set_iterator_to_next. Fixes cursor
609 motion in bidi-reordered lines with stretch glyphs and strings
610 displayed in margins. (Bug#8133) (Bug#8867)
611 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
612 TO_CHARPOS.
613 (pos_visible_p): Support positions in bidi-reordered lines. Save
614 and restore bidi cache.
615
616 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
617 (bidi_paragraph_info): Delete unused struct.
618 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
619 (bidi_cache_start): New variable.
620 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
621 to zero.
622 (bidi_cache_fetch_state, bidi_cache_search)
623 (bidi_cache_find_level_change, bidi_cache_iterator_state)
624 (bidi_cache_find, bidi_peek_at_next_level)
625 (bidi_level_of_next_char, bidi_find_other_level_edge)
626 (bidi_move_to_visually_next): Compare cache index with
627 bidi_cache_start rather than with zero.
628 (bidi_fetch_char): Accept new argument STRING; all callers
629 changed. Support iteration over a string. Support strings with
630 display properties. Support unibyte strings. Fix the type of
631 `len' according to what STRING_CHAR_AND_LENGTH expects.
632 (bidi_paragraph_init, bidi_resolve_explicit_1)
633 (bidi_resolve_explicit, bidi_resolve_weak)
634 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
635 iteration over a string.
636 (bidi_set_sor_type, bidi_resolve_explicit_1)
637 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
638 can now be zero (for strings); special values 0 and -1 were
639 changed to -1 and -2, respectively.
640 (bidi_char_at_pos): New function.
641 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
642 Call it instead of FETCH_MULTIBYTE_CHAR.
643 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
644 initialized to valid values.
645 (bidi_init_it): Don't initialize charpos and bytepos with invalid
646 values.
647 (bidi_level_of_next_char): Allow the sentinel "position" to pass
648 the test for valid cached positions. Fix the logic for looking up
649 the sentinel state in the cache. GCPRO the Lisp string we are
650 iterating.
651 (bidi_push_it, bidi_pop_it): New functions.
652 (bidi_initialize): Initialize the bidi cache start stack pointer.
653 (bidi_cache_ensure_space): New function, refactored from part of
654 bidi_cache_iterator_state. Don't assume the required size is just
655 one BIDI_CACHE_CHUNK away.
656 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
657 (bidi_count_bytes, bidi_char_at_pos): New functions.
658 (bidi_cache_search): Don't assume bidi_cache_last_idx is
659 always valid if bidi_cache_idx is valid.
660 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
661 is valid if it's going to be used.
662 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
663 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
664 (bidi_cache_find_level_change, bidi_cache_ensure_space)
665 (bidi_cache_iterator_state, bidi_cache_find)
666 (bidi_find_other_level_edge, bidi_cache_start_stack): All
667 variables related to cache indices are now EMACS_INT.
668
0bb23927
EZ
669 * dispextern.h (struct bidi_string_data): New structure.
670 (struct bidi_it): New member `string'. Make flag members be 1-bit
671 fields, and put them last in the struct.
672 (compute_display_string_pos, compute_display_string_end): Update
673 prototypes.
674 (bidi_push_it, bidi_pop_it): Add prototypes.
675 (struct iterator_stack_entry): New members bidi_p,
676 paragraph_embedding, and from_disp_prop_p.
677 (struct it): Member bidi_p is now a bit field 1 bit wide.
678 (bidi_shelve_cache, bidi_unshelve_cache): Declare
679 prototypes.
680
681 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
682 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
683 and vector-like objects.
684
685 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
686 cache around display iteration.
687
688 * window.c (Fwindow_end, window_scroll_pixel_based)
689 (displayed_window_lines, Frecenter): Save and restore the bidi
690 cache around display iteration.
691
3bbd2265
LMI
6922011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
693
694 * editfns.c (Fdelete_region): Clarify the use of the named
695 parameters (bug#6788).
696
adc47434
MR
6972011-07-14 Martin Rudalics <rudalics@gmx.at>
698
699 * indent.c (Fvertical_motion): Set and restore w->pointm when
700 saving and restoring the window's buffer (Bug#9006).
701
837c31f8
LMI
7022011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
703
704 * editfns.c (Fstring_to_char): Clarify just what is returned
705 (bug#6576). Text by Eli Zaretskii.
706
ac389d0c
JB
7072011-07-13 Juanma Barranquero <lekktu@gmail.com>
708
709 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
710
0be0ce47
EZ
7112011-07-13 Eli Zaretskii <eliz@gnu.org>
712
713 * buffer.c (mmap_find): Fix a typo.
714
cd18e7e3
JB
7152011-07-13 Johan Bockgård <bojohan@gnu.org>
716
717 Fix execution of x selection hooks.
718 * xselect.c (Qx_lost_selection_functions)
719 (Qx_sent_selection_functions): New vars.
720 (syms_of_xselect): DEFSYM them.
721 (x_handle_selection_request): Pass Qx_sent_selection_functions
722 rather than Vx_sent_selection_functions to Frun_hook_with_args.
723 (x_handle_selection_clear,x_clear_frame_selections):
724 Pass Qx_lost_selection_functions rather than
725 Vx_lost_selection_functions to Frun_hook_with_args.
726
47ea7f44
PE
7272011-07-13 Paul Eggert <eggert@cs.ucla.edu>
728
ac389d0c 729 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
730 The old code sometimes used this field without initializing it.
731
47ea7f44
PE
732 * alloc.c (gc_sweep): Don't read past end of array.
733 In theory, the old code could also have corrupted Emacs internals,
734 though it'd be very unlikely.
735
bc985c87
AS
7362011-07-12 Andreas Schwab <schwab@linux-m68k.org>
737
738 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 739 argument. (Bug#4026)
bc985c87 740
0cf34688
LMI
7412011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
742
b3dadd76
LMI
743 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
744 key" (bug#4257).
745
0cf34688
LMI
746 * window.c (Fset_window_start): Doc fix (bug#4199).
747 (Fset_window_hscroll): Ditto.
748
270768cd
PE
7492011-07-12 Paul Eggert <eggert@cs.ucla.edu>
750
077e3dda 751 Fix minor new problems caught by GCC 4.6.1.
270768cd 752 * term.c (init_tty): Remove unused local.
490011a6 753 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 754 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 755 not used otherwise.
270768cd 756
b1f58454
CY
7572011-07-12 Chong Yidong <cyd@stupidchicken.com>
758
759 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
760
22b9578d
LMI
7612011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
762
6e70ab07
LMI
763 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
764 are the mini-buffer and the echo area (bug#3320).
765
22b9578d
LMI
766 * term.c (init_tty): Remove support for supdup, c10 and perq
767 terminals, which are no longer supported (bug#1482).
768
8974cc9f
JB
7692011-07-10 Johan Bockgård <bojohan@gnu.org>
770
771 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
772
a560d974
JD
7732011-07-10 Jan Djärv <jan.h.d@swipnet.se>
774
775 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
776 for non-popups (Bug#3642).
777
1dae0f0a
AS
7782011-07-10 Andreas Schwab <schwab@linux-m68k.org>
779
268c2c36 780 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 781 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
782 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
783 * cm.c (losecursor): Likewise.
1dae0f0a
AS
784 * data.c (fmod): Likewise.
785 * dispnew.c (swap_glyphs_in_rows): Likewise.
786 * emacs.c (memory_warning_signal): Likewise.
787 * floatfns.c (float_error): Likewise.
788 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
789 (otf_open, font_otf_capability, generate_otf_features)
790 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
791 Likewise.
792 * image.c (pbm_read_file): Likewise.
793 * indent.c (string_display_width): Likewise.
794 * intervals.c (check_for_interval, search_for_interval)
795 (inc_interval_count, count_intervals, root_interval)
796 (adjust_intervals_for_insertion, make_new_interval): Likewise.
797 * lread.c (defalias): Likewise.
268c2c36 798 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
799 * regex.c (set_image_of_range_1, set_image_of_range)
800 (regex_grow_registers): Likewise.
801 * sysdep.c (strerror): Likewise.
802 * termcap.c (valid_filename_p, tprint, main): Likewise.
803 * tparam.c (main): Likewise.
804 * unexhp9k800.c (run_time_remap, save_data_space)
805 (update_file_ptrs, read_header, write_header, calculate_checksum)
806 (copy_file, copy_rest, display_header): Likewise.
807 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
808 Likewise.
809 * xdisp.c (check_it): Likewise.
810 * xfaces.c (register_color, unregister_color, unregister_colors):
811 Likewise.
812 * xfns.c (print_fontset_result): Likewise.
813 * xrdb.c (member, fatal, main): Likewise.
814
99033785
PE
8152011-07-10 Paul Eggert <eggert@cs.ucla.edu>
816
817 Fix minor problems found by static checking (Bug#9031).
818 * chartab.c (char_table_set_range, map_sub_char_table):
819 Remove unused locals.
820 (uniprop_table): Now static.
821 * composite.c (_work_char): Remove unused static var.
822
9cb2ac56
JB
8232011-07-09 Juanma Barranquero <lekktu@gmail.com>
824
825 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
826
f25661f0
JD
8272011-07-09 Jan Djärv <jan.h.d@swipnet.se>
828
829 * gtkutil.c (qttip_cb): Remove code without function.
830
8278c4fe
EZ
8312011-07-09 Eli Zaretskii <eliz@gnu.org>
832
833 * w32.c (pthread_sigmask): New stub.
834
1692ae2d 8352011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 836
8a6ebd58 837 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
838 sigprocmask is portable only for single-threaded applications, and
839 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
840 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
841 (LIBES): Use it.
842 * callproc.c (Fcall_process):
843 * process.c (create_process):
844 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
845 Use pthread_sigmask, not sigprocmask.
123403e4 846
1b854618
JD
8472011-07-08 Jan Djärv <jan.h.d@swipnet.se>
848
849 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
850 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
851 wrong (Bug#8591).
852
3fe4b549
JD
8532011-07-08 Jan Djärv <jan.h.d@swipnet.se>
854
0ce7e563
JD
855 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
856 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
857 (xg_hide_tooltip): Fix comment.
858
3fe4b549
JD
859 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
860 in registerServicesMenuSendTypes.
861 (validRequestorForSendType): Don't check ns_return_types.
862
863 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
864 ns_return_type.
865
5df75e47
JR
8662011-07-08 Jason Rumney <jasonr@gnu.org>
867
868 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
869 frame struct members of non-existent frames (Bug#6284).
870
699c10bd
JD
8712011-07-08 Jan Djärv <jan.h.d@swipnet.se>
872
4393663b
JD
873 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
874 variable firstTime not needed on OSX >= 10.6.
875 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
876 >= 10.5. Use setKnobProportion, setDoubleValue.
877
878 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
879 (MAC_OS_X_VERSION_10_5): Define if not defined.
880 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
881 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
882 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
883
884 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
885 cString and lossyCString on OSX >= 10.4
886
887 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
888 sizeToFit on OSX >= 10.2.
889
890 * nsimage.m (allocInitFromFile): Don't use deprecated method
891 bestRepresentationForDevice on OSX >= 10.6.
892
893 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
894 to avoid warning.
895
896 * emacs.c: Declare unexec_init_emacs_zone.
897
a63e0781
JD
898 * nsgui.h: Fix compiler warning about gnulib redefining verify.
899
699c10bd
JD
900 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
901
902 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
903 on svcsMenu (Bug#8842).
904
905 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
906 ns_return_types.
907 (Fns_list_services): Just return Qnil on 10.6, code not working there.
908
909 * nsterm.m (QUTF8_STRING): Declare.
910 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
911 (validRequestorForSendType): Return type is (id).
912 Change indexOfObjectIdenticalTo to indexOfObject.
913 Check if we have local selection before returning self (Bug#8842).
914 (writeSelectionToPasteboard): Put local selection into paste board
915 if we have a local selection (Bug#8842).
916 (syms_of_nsterm): DEFSYM QUTF8_STRING.
917
918 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
919 (ns_get_local_selection): Declare.
920
54e10184
LMI
9212011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
922
9888ff71
LMI
923 * keymap.c (describe_map_tree): Don't insert a double newline at
924 the end of the buffer (bug#1169) and return whether we inserted
925 something.
926
54e10184
LMI
927 * callint.c (Fcall_interactively): Change "reading args" to
928 "providing args" to try to clarify what it does (bug#1010).
929
15fa4783
KH
9302011-07-07 Kenichi Handa <handa@m17n.org>
931
932 * composite.c (composition_compute_stop_pos): Ignore a static
933 composition starting before CHARPOS (Bug#8915).
934
935 * xdisp.c (handle_composition_prop): Likewise.
936
a8815b00
EZ
9372011-07-07 Eli Zaretskii <eliz@gnu.org>
938
939 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
940 (Bug#9015)
941
ef7b981d 9422011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
943
944 * character.h (unicode_category_t): New enum type.
945
946 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
947 (Qchar_code_property_table): New variable.
948 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
949 (UNIPROP_COMPRESSED_FORM_P): New macros.
950 (char_table_ascii): Uncompress the compressed values.
951 (sub_char_table_ref): New arg is_uniprop. Callers changed.
952 Uncompress the compressed values.
ac389d0c 953 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
954 (char_table_ref_and_range): Uncompress the compressed values.
955 (sub_char_table_set): New arg is_uniprop. Callers changed.
956 Uncompress the compressed values.
957 (sub_char_table_set_range): Args changed. Callers changed.
958 (char_table_set_range): Adjuted for the above change.
959 (map_sub_char_table): Delete args default_val and parent. Add arg
960 top. Give decoded values to a Lisp function.
961 (map_char_table): Adjusted for the above change. Give decoded
962 values to a Lisp function. Gcpro more variables.
963 (uniprop_table_uncompress)
964 (uniprop_decode_value_run_length): New functions.
965 (uniprop_decoder, uniprop_decoder_count): New variables.
966 (uniprop_get_decoder, uniprop_encode_value_character)
967 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
968 New functions.
969 (uniprop_encoder, uniprop_encoder_count): New variables.
970 (uniprop_get_encoder, uniprop_table)
971 (Funicode_property_table_internal, Fget_unicode_property_internal)
972 (Fput_unicode_property_internal): New functions.
973 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
974 Sunicode_property_table_internal, Sget_unicode_property_internal,
975 and Sput_unicode_property_internal. Defvar_lisp
976 char-code-property-alist.
977
978 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
979 Vunicode_category_table.
980
981 * font.c (font_range): Adjusted for the change of
982 Vunicode_category_table.
983
76b397fb
DN
9842011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
985
986 * m/iris4d.h: Remove file, move contents ...
987 * s/irix6-5.h: ... here.
988
22b4128e
PE
9892011-07-06 Paul Eggert <eggert@cs.ucla.edu>
990
991 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
992 * alloc.c (mark_buffer):
993 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
994 (clone_per_buffer_values): Don't assume that
22b4128e
PE
995 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
996 This isn't true in general, and it's particularly not true
997 if Emacs is configured with --with-wide-int.
998 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
999 New macros, used in the buffer.c change.
1000
869795d6
JD
10012011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1002
1003 * xsettings.c: Use both GConf and GSettings if both are available.
1004 (store_config_changed_event): Add comment.
1005 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1006 (store_tool_bar_style_changed): New functions.
1007 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1008 (struct xsettings): Move font inside HAVE_XFT.
1009 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
1010 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
1011 Move inside HAVE_XFT.
1012 (something_changed_gsettingsCB): Renamed from something_changedCB.
1013 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1014 also.
1015 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
1016 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1017 (something_changed_gconfCB): Renamed from something_changedCB.
1018 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1019 (parse_settings): Move check for font inside HAVE_XFT.
1020 (read_settings, apply_xft_settings): Add comment.
1021 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1022 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1023 call store_font_name_changed.
1024 (xft_settings_event): Add comment.
1025 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1026 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1027 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1028 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1029 (xsettings_initialize): Call init_gsettings last.
1030 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
1031 comment.
1032
d8ed26bd
PE
10332011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1034
1035 Random fixes. E.g., (random) never returned negative values.
1036 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1037 subseconds part to the entropy, as that's a bit more random.
1038 Prefer signed to unsigned, since the signedness doesn't matter and
1039 in general we prefer signed. When given a limit, use a
1040 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1041 latter isn't right if USE_2_TAGS_FOR_INTS.
1042 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1043 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1044
cabf1cac
SM
10452011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1046
1047 * textprop.c (text_property_stickiness):
1048 Obey Vtext_property_default_nonsticky.
1049 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1050 * w32fns.c (syms_of_w32fns):
1051 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1052
6e9b2be9
PE
10532011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1054
1055 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1056 This is more efficient than Ffile_directory_p and avoids a minor race.
1057
90186c68
LMI
10582011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1059
7c301272
LMI
1060 * buffer.c (Foverlay_put): Say what the return value is
1061 (bug#7835).
1062
c4f2d8d4
LMI
1063 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1064 is a directory before asking whether to use the file name
1065 (bug#7564).
ad637907
LMI
1066 (barf_or_query_if_file_exists): Make the "File is a directory"
1067 error be more correct.
c4f2d8d4 1068
90186c68
LMI
1069 * fns.c (Frequire): Remove the mention of the .gz files, since
1070 that's installation-specific, but keep the mention of
1071 `get-load-suffixes'.
1072
da64016e
PE
10732011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1074
1075 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1076 Report string overflow if the output is too long.
1077
7d47b580
JB
10782011-07-04 Juanma Barranquero <lekktu@gmail.com>
1079
a555cb87
JB
1080 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1081 (syms_of_gnutls): Remove duplicate DEFSYM for
1082 Qgnutls_bootprop_verify_hostname_error, an error for
1083 Qgnutls_bootprop_verify_error (which is no longer used).
1084
7d47b580
JB
1085 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1086 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1087 Also (re)move comments that are misplaced or no longer relevant.
1088
1e49bfab
LMI
10892011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1090
1091 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1092
1485f4c0
CY
10932011-07-03 Chong Yidong <cyd@stupidchicken.com>
1094
1095 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1096 and background color parameters if they have been changed.
1097
a9ab721e
LMI
10982011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1099
1100 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1101
cf7cff57
PE
11022011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1103
2e13213d
PE
1104 * xsettings.c (SYSTEM_FONT): Define only when used.
1105 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1106
cf7cff57
PE
1107 * keymap.c (access_keymap_1): Now static.
1108
7a8e04f7
CY
11092011-07-02 Chong Yidong <cyd@stupidchicken.com>
1110
1111 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1112 leave any prefix arg for the up event (Bug#1586).
1113
61352f62
LMI
11142011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1115
69bb1ef7
LMI
1116 * lread.c (syms_of_lread): Mention single symbols defined by
1117 `defvar' or `defconst' (bug#7154).
1118
61352f62 1119 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 1120 (Frequire): Mention get-load-suffixes.
61352f62 1121
28545e04
MR
11222011-07-02 Martin Rudalics <rudalics@gmx.at>
1123
1124 * window.h (window): Remove clone_number slot.
1125 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1126 Remove.
1127 (make_parent_window, make_window, saved_window)
1128 (Fset_window_configuration, save_window_save): Don't deal with
1129 clone numbers.
1130 * buffer.c (Qclone_number): Remove declaration.
1131 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1132
3349e122
SM
11332011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1134
1135 Add multiple inheritance to keymaps.
1136 * keymap.c (Fmake_composed_keymap): New function.
1137 (Fset_keymap_parent): Simplify.
1138 (fix_submap_inheritance): Remove.
1139 (access_keymap_1): New function extracted from access_keymap to handle
1140 embedded parents and handle lists of maps.
1141 (access_keymap): Use it.
1142 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
1143 (Fcopy_keymap): Handle embedded parents.
1144 (Fcommand_remapping, define_as_prefix): Simplify.
1145 (Fkey_binding): Simplify.
1146 (syms_of_keymap): Move minibuffer-local-completion-map,
1147 minibuffer-local-filename-completion-map,
1148 minibuffer-local-must-match-map, and
1149 minibuffer-local-filename-must-match-map to Elisp.
1150 (syms_of_keymap): Defsubr make-composed-keymap.
1151 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1152 (parse_menu_item): Trivial simplification.
1153
3279eb87
GM
11542011-07-01 Glenn Morris <rgm@gnu.org>
1155
1156 * Makefile.in (SETTINGS_LIBS): Fix typo.
1157
4550efdf
KI
11582011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1159
1160 * coding.c (Fencode_coding_string): Record the last coding system
1161 used, as the function doc string says (bug#8738).
1162
0949d2b6
JD
11632011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1164
1165 * xsettings.c (store_monospaced_changed): Take new font as arg and
1166 check for change against current_mono_font.
1167 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1168 (emacs_settings_constructor, emacs_settings_get_property)
1169 (emacs_settings_set_property, emacs_settings_class_init)
1170 (emacs_settings_init, gsettings_obj): Remove.
1171 (something_changedCB): New function for HAVE_GSETTINGS.
1172 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1173 with value as argument.
1174 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1175 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 1176 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
1177 "changed".
1178
1179 * xgselect.c: Add defined (HAVE_GSETTINGS).
1180 (xgselect_initialize): Ditto.
1181
1182 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1183 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1184 xg_select.
1185
bbc6b304
PE
11862011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1187
1188 * eval.c (struct backtrace): Simplify and port the data structure.
1189 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1190 signed bit field, as this assumption is not portable and it makes
1191 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1192 "char debug_on_exit : 1" as this is not portable either; instead,
1193 use the portable "unsigned int debug_on_exit : 1". Remove unused
1194 member evalargs. Remove obsolete comments about cc bombing out.
1195
9851bfc5
JD
11962011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1197
51bb811f 1198 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
1199 Let HAVE_GSETTINGS override HAVE_GCONF.
1200 (store_monospaced_changed): New function.
1201 (EMACS_SETTINGS): A new type derived from GObject to handle
1202 GSettings notifications.
1203 (emacs_settings_constructor, emacs_settings_get_property)
1204 (emacs_settings_set_property, emacs_settings_class_init):
1205 New functions.
1206 (gsettings_client, gsettings_obj): New variables.
1207 (GSETTINGS_SCHEMA): New define.
1208 (something_changedCB): Call store_monospaced_changed.
1209 (init_gsettings): New function.
1210 (xsettings_initialize): Call init_gsettings.
1211 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1212 to NULL.
1213
1214 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
1215 GCONF_CFLAGS/LIBS.
1216
5386012d
MR
12172011-06-29 Martin Rudalics <rudalics@gmx.at>
1218
1219 * window.c (resize_root_window, grow_mini_window)
1220 (shrink_mini_window): Rename Qresize_root_window to
1221 Qwindow_resize_root_window and Qresize_root_window_vertically to
1222 Qwindow_resize_root_window_vertically.
1223
f13e0b08
PE
12242011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1225
1226 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1227
94515237
JB
12282011-06-27 Juanma Barranquero <lekktu@gmail.com>
1229
1230 * makefile.w32-in: Redesign dependencies so they reflect more
1231 clearly which files are directly included by each source file,
1232 and not through other includes.
1233
e43b6e43
MR
12342011-06-27 Martin Rudalics <rudalics@gmx.at>
1235
1236 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1237 (sort_overlays, overlay_strings): When an overlay's clone number
1238 matches the window's clone number process the overlay even if
1239 the overlay's window property doesn't match the current window.
1240
d68443dc
MR
1241 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1242 (Fwindow_hchild): Rename to Fwindow_left_child.
1243 (Fwindow_next): Rename to Fwindow_next_sibling.
1244 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
1245 (resize_window_check): Rename to window_resize_check.
1246 (resize_window_apply): Rename to window_resize_apply.
1247 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1248 (Fdelete_other_windows_internal, resize_frame_windows)
1249 (Fsplit_window_internal, Fdelete_window_internal)
1250 (grow_mini_window, shrink_mini_window)
1251 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 1252
c7e73be5
JD
12532011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1254
1255 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1256 (emacs_fixed_set_min_size): Remove.
1257 (emacs_fixed_new): Take frame as argument.
1258
1259 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1260 (_EmacsFixedPrivate): Remove minwidth/height.
1261 Add struct frame *f.
1262 (emacs_fixed_init): Initialize priv->f.
1263 (get_parent_class, emacs_fixed_set_min_size): Remove.
1264 (emacs_fixed_new): Set priv->f to argument.
1265 (emacs_fixed_get_preferred_width)
1266 (emacs_fixed_get_preferred_height): Use min_width/height from
1267 frames size_hint to set minimum and natural (Bug#8919).
1268 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1269 and use min_width/height from frames size_hint to set
1270 min_width/height (Bug#8919).
1271
1272 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
1273 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1274 Fix indentation.
c7e73be5 1275
cf99dcf8
EZ
12762011-06-26 Eli Zaretskii <eliz@gnu.org>
1277
1278 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1279 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1280 called at ZV.
1281
029529ac
CY
12822011-06-26 Chong Yidong <cyd@stupidchicken.com>
1283
1284 * process.c (wait_reading_process_output): Bypass select if
1285 waiting for a cell while ignoring keyboard input, and input is
1286 pending. Suggested by Jan Djärv (Bug#8869).
1287
7a7ef429
PE
12882011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1289
1290 Use gnulib's dup2 module instead of rolling our own.
1291 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1292
11fdef7d 12932011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
1294
1295 * dispnew.c (scrolling_window): Before scrolling, turn off a
1296 mouse-highlight in the window being scrolled.
1297
cd3520a4
JB
12982011-06-24 Juanma Barranquero <lekktu@gmail.com>
1299
1300 Move DEFSYM to lisp.h and use everywhere.
1301
1302 * character.h (DEFSYM): Move declaration...
1303 * lisp.h (DEFSYM): ...here.
1304
1305 * gnutls.c:
1306 * minibuf.c:
1307 * w32menu.c:
1308 * w32proc.c:
1309 * w32select.c: Don't include character.h.
1310
1311 * alloc.c (syms_of_alloc):
1312 * buffer.c (syms_of_buffer):
1313 * bytecode.c (syms_of_bytecode):
1314 * callint.c (syms_of_callint):
1315 * casefiddle.c (syms_of_casefiddle):
1316 * casetab.c (init_casetab_once):
1317 * category.c (init_category_once, syms_of_category):
1318 * ccl.c (syms_of_ccl):
1319 * cmds.c (syms_of_cmds):
1320 * composite.c (syms_of_composite):
1321 * dbusbind.c (syms_of_dbusbind):
1322 * dired.c (syms_of_dired):
1323 * dispnew.c (syms_of_display):
1324 * doc.c (syms_of_doc):
1325 * editfns.c (syms_of_editfns):
1326 * emacs.c (syms_of_emacs):
1327 * eval.c (syms_of_eval):
1328 * fileio.c (syms_of_fileio):
1329 * fns.c (syms_of_fns):
1330 * frame.c (syms_of_frame):
1331 * fringe.c (syms_of_fringe):
1332 * insdel.c (syms_of_insdel):
1333 * keymap.c (syms_of_keymap):
1334 * lread.c (init_obarray, syms_of_lread):
1335 * macros.c (syms_of_macros):
1336 * msdos.c (syms_of_msdos):
1337 * print.c (syms_of_print):
1338 * process.c (syms_of_process):
1339 * search.c (syms_of_search):
1340 * sound.c (syms_of_sound):
1341 * syntax.c (init_syntax_once, syms_of_syntax):
1342 * terminal.c (syms_of_terminal):
1343 * textprop.c (syms_of_textprop):
1344 * undo.c (syms_of_undo):
1345 * w32.c (globals_of_w32):
1346 * window.c (syms_of_window):
1347 * xdisp.c (syms_of_xdisp):
1348 * xfaces.c (syms_of_xfaces):
1349 * xfns.c (syms_of_xfns):
1350 * xmenu.c (syms_of_xmenu):
1351 * xsettings.c (syms_of_xsettings):
1352 * xterm.c (syms_of_xterm): Use DEFSYM.
1353
4228cf16
TZ
13542011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1355
cd3520a4 1356 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 1357
7fcccf1e
PE
13582011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1359
7efb4e0e
PE
1360 Integer and buffer overflow fixes (Bug#8873).
1361
ff5844ad
PE
1362 * print.c (printchar, strout): Check for string overflow.
1363 (PRINTPREPARE, printchar, strout):
1364 Don't set size unless allocation succeeds.
1365
90532f02
PE
1366 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1367 for sizes. Check for string overflow more accurately.
1368 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1369
6d84508d
PE
1370 * macros.c: Integer and buffer overflow fixes.
1371 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1372 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1373 Use ptrdiff_t, not int, for sizes.
1374 Don't increment bufsize until after realloc succeeds.
1375 Check for size-calculation overflow.
1376 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1377
437b2cb4
PE
1378 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1379
8b9ac8b4
PE
1380 * lread.c: Integer overflow fixes.
1381 (read_integer): Radix is now EMACS_INT, not int,
1382 to improve quality of diagnostics for out-of-range radices.
1383 Calculate buffer size correctly for out-of-range radices.
1384 (read1): Check for integer overflow in radices, and in
1385 read-circle numbers.
82cb60d3
PE
1386 (read_escape): Avoid int overflow.
1387 (Fload, openp, read_buffer_size, read1)
1388 (substitute_object_recurse, read_vector, read_list, map_obarray):
1389 Use ptrdiff_t, not int, for sizes.
1390 (read1): Use EMACS_INT, not int, for sizes.
20270765 1391 Check for size overflow.
8b9ac8b4 1392
7fcccf1e
PE
1393 * image.c (cache_image): Check for size arithmetic overflow.
1394
bfbbd7e7
PE
1395 * lread.c: Integer overflow issues.
1396 (saved_doc_string_size, saved_doc_string_length)
1397 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1398 Now ptrdiff_t, not int.
1399 (read1): Don't assume doc string length fits in int. Check for
1400 out-of-range doc string lengths.
1401 (read_list): Don't assume file position fits in int.
39019e54 1402 (read_escape): Check for hex character overflow.
bfbbd7e7 1403
4e323265
LL
14042011-06-22 Leo Liu <sdl.web@gmail.com>
1405
1406 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1407 Move to minibuffer.el.
1408
85fece3e
PE
14092011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1410
20b84ce9 1411 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
1412 The following patches are for when GLYPH_DEBUG && !XASSERT.
1413 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1414 * dispnew.c (flush_stdout):
1415 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1416 Mark as externally visible.
1417 * dispnew.c (check_window_matrix_pointers): Now static.
1418 * dispnew.c (window_to_frame_vpos):
1419 * xfns.c (unwind_create_frame):
1420 * xterm.c (x_check_font): Remove unused local.
1421 * scroll.c (CHECK_BOUNDS):
1422 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1423 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1424 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1425 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1426 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1427 Now static.
1428 (debug_method_add): Use va_list and vsprintf rather than relying
1429 on undefined behavior with wrong number of arguments.
1430 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1431 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1432 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1433 since we're not interested in debugging glyphs with old libraries.
1434 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1435 GCC 4.6.0's static checking.
1436
0766b489
PE
14372011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1438
31fd4b32
PE
1439 Integer overflow and signedness fixes (Bug#8873).
1440 A few related buffer overrun fixes, too.
1441
b79e8648
PE
1442 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1443
0766b489
PE
1444 * dispextern.h (struct face.stipple):
1445 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1446 (x_bitmap_mask, x_allocate_bitmap_record)
1447 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1448 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1449 (x_create_bitmap_from_xpm_data):
1450 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1451 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1452 (.bitmaps_last):
1453 * xfaces.c (load_pixmap):
1454 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1455 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1456 (.bitmaps_last, struct x_output.icon_bitmap):
1457 Use ptrdiff_t, not int, for bitmap indexes.
1458 (x_allocate_bitmap_record): Check for size overflow.
1459 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1460
b081724f
PE
1461 Use ptrdiff_t, not int, for overlay counts.
1462 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1463 * editfns.c (overlays_around, get_pos_property):
1464 * textprop.c (get_char_property_and_overlay):
1465 * xdisp.c (next_overlay_change, note_mouse_highlight):
1466 * xfaces.c (face_at_buffer_position):
21514da7
PE
1467 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1468 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1469 (Fnext_overlay_change, Fprevious_overlay_change)
1470 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 1471 Use ptrdiff_t, not int, for sizes.
21514da7 1472 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 1473
3de73e5e
PE
1474 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1475
2606c57b
PE
1476 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1477 (x_session_initialize): Do not assume string length fits in int.
1478
aaafe47a
PE
1479 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1480 This is unlikely, but can occur if DPI is outlandish.
1481
2674ddc8 1482 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
1483 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1484
28154962
PE
1485 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1486 * xrdb.c (magic_file_p, search_magic_path):
1487 Omit last arg SUFFIX; it was always 0. All callers changed.
1488 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1489
7de51af5
PE
1490 * xfont.c (xfont_match): Avoid need for strlen.
1491
25ed6cc3
PE
1492 * xfns.c: Don't assume strlen fits in int.
1493 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1494
4eab31dd
PE
1495 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1496 not unsigned long, as we prefer signed integers. All callers changed.
1497 Detect integer overflow in repeat count.
1498 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 1499 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 1500
171e2a58
PE
1501 * termcap.c: Don't assume sizes fit in int and never overflow.
1502 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1503 (gobble_line): Check for size-calculation overflow.
1504
ad39faca 1505 * minibuf.c (Fread_buffer):
6e5bb2dc 1506 * lread.c (intern, intern_c_string):
74ca2eb3
PE
1507 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1508 Don't assume string length fits in int.
1509
52c61c22 1510 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
1511 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1512
b5b8c9e5
PE
1513 * font.c: Don't assume string length fits in int.
1514 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1515 Use ptrdiff_t, not int.
ccd6111c
PE
1516 (font_intern_prop): Don't assume string length fits in int.
1517 Don't assume integer property fits in fixnum.
1518 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 1519
882f0d81 1520 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 1521 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
1522 Reformulate so as not to need the command string.
1523 Invoke gzip -cd rather than gunzip, as it's more portable.
1524 (lock_info_type, lock_file_1, lock_file):
1525 Don't assume pid_t and time_t fit in unsigned long.
1526 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1527 (current_lock_owner): Prefer signed type for sizes.
1528 Use memcpy, not strncpy, where memcpy is what is really wanted.
1529 Don't assume (via atoi) that time_t and pid_t fit in int.
1530 Check for time_t and/or pid_t out of range, e.g., via a network share.
1531 Don't alloca where an auto var works fine.
1532
93f4cf88
PE
1533 * fileio.c: Fix some integer overflow issues.
1534 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1535 Don't assume string length fits in int.
1536 (directory_file_name): Don't assume string length fits in long.
1537 (make_temp_name): Don't assume pid fits in int, or that its print
1538 length is less than 20.
1539
f3e92b69
PE
1540 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1541
1bfdaf10
PE
1542 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1543
35016e9a
PE
1544 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1545
3d1e65a1
PE
1546 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1547 We prefer signed integers, even for size calculations.
1548
0b963a93
PE
1549 * emacs.c: Don't assume string length fits in 'int'.
1550 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1551 (main): Don't invoke strlen when not needed.
1552
573f4b54
PE
1553 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1554 (XD_DEBUG_MESSAGE): Don't waste a byte.
1555
989f33ba
PE
1556 * callproc.c (getenv_internal_1, getenv_internal)
1557 (Fgetenv_internal):
965d34eb
PE
1558 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1559
e4d29b33
PE
1560 * lread.c (invalid_syntax): Omit length argument.
1561 All uses changed. This doesn't fix a bug, but it simplifies the
1562 code away from its former Hollerith-constant appearance, and it's
1563 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 1564 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 1565
eb49b136
PE
1566 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1567 This didn't break anything, but it didn't help either.
1568 It's confusing to put a bogus integer in a place where the actual
1569 value does not matter.
9f62aeb1 1570 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 1571 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 1572
15375a22
PE
1573 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1574 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1575 implementation.
b61cc01c
PE
1576 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1577 We prefer signed types, and the value cannot exceed the EMACS_INT
1578 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
1579 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1580 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1581 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 1582
53b2623d
PE
1583 * indent.c (sane_tab_width): New function.
1584 (current_column, scan_for_column, Findent_to, position_indentation)
1585 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 1586 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 1587
51cab52b 1588 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 1589
f2ed8a70
PE
1590 * lisp.h (lint_assume): New macro.
1591 * composite.c (composition_gstring_put_cache):
1592 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1593
abe80cc6
PE
1594 * editfns.c, insdel.c:
1595 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 1596
b02c740e
PE
1597 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1598
ebc96716
PE
1599 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1600
b4e50fa0 1601 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 1602 Use much-faster test for byte-length change.
311d5d7c 1603 Don't assume string byte-length fits in 'int'.
a4cf38e4 1604 Check that character arg fits in 'int'.
85461888 1605 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 1606
c0c1ee9f
PE
1607 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1608
a498d7f4
PE
1609 * fns.c (concat): Catch string overflow earlier.
1610 Do not rely on integer wraparound.
1611
51cab52b
PE
1612 * dispextern.h (struct it.overlay_strings_charpos)
1613 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
1614 * xdisp.c (forward_to_next_line_start)
1615 (back_to_previous_visible_line_start)
1616 (reseat_at_next_visible_line_start, next_element_from_buffer):
1617 Don't arbitrarily truncate the value of 'selective' to int.
1618
76031fad
PE
1619 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1620
5eb55db9
PE
1621 * composite.c: Don't truncate sizes to 'int'.
1622 (composition_gstring_p, composition_reseat_it)
1623 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
1624 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1625 not EMACS_UINT, for indexes.
5eb55db9 1626
0703a717
PE
1627 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1628
d6202519
PE
1629 * buffer.c: Include <verify.h>.
1630 (struct sortvec.priority, struct sortstr.priority):
8961a454 1631 Now EMACS_INT, not int.
c20998a7 1632 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
1633 (struct sortstr.size, record_overlay_string)
1634 (struct sortstrlist.size, struct sortlist.used):
1635 Don't truncate size to int.
1636 (record_overlay_string): Check for size-calculation overflow.
d6202519 1637 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 1638
d5a19415
JM
16392011-06-22 Jim Meyering <meyering@redhat.com>
1640
029529ac 1641 Don't leak an XBM-image-sized buffer
d5a19415
JM
1642 * image.c (xbm_load): Free the image buffer after using it.
1643
a9041e6c
PE
16442011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1645
1646 Port to Sun C.
1647 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1648 that Sun C diagnosed.
1649 * fns.c (secure_hash): Fix pointer signedness issue.
1650 * intervals.c (static_offset_intervals): New function.
1651 (offset_intervals): Use it.
1652
7f3f739f
LL
16532011-06-21 Leo Liu <sdl.web@gmail.com>
1654
1655 * deps.mk (fns.o):
1656 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1657 sha512.h.
1658
1659 * fns.c (secure_hash): Rename from crypto_hash_function and change
1660 the first arg to accept symbols.
5b66d427 1661 (Fsecure_hash): New primitive.
7f3f739f
LL
1662 (syms_of_fns): New symbols.
1663
76147d94
DD
16642011-06-20 Deniz Dogan <deniz@dogan.se>
1665
1666 * process.c (Fset_process_buffer): Clarify return value in
1667 docstring.
1668
7d7d0045
CY
16692011-06-18 Chong Yidong <cyd@stupidchicken.com>
1670
1671 * dispnew.c (add_window_display_history): Use BVAR.
1672
1673 * xdisp.c (debug_method_add): Use BVAR.
1674 (check_window_end, dump_glyph_matrix, dump_glyph)
1675 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1676
1677 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1678 Likewise.
1679
1680 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1681 check till after the cache is created in init_frame_faces.
1682
ff2bc410
SM
16832011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1684
1685 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1686
28177add
PE
16872011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1688
dd3482fe
PE
1689 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1690 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1691 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1692
393d71f3 1693 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
1694 * fileio.c (Finsert_file_contents):
1695 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1696 Remove the old (too-loose) buffer overflow checks.
1697 They weren't needed, since make_gap checks for buffer overflow.
1698 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1699 The old code merely checked for Emacs fixnum overflow, and relied
1700 on undefined (wraparound) behavior. The new code avoids undefined
1701 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1702
2e6813b0 1703 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
1704 Tune. Don't use wider integers than needed. Don't use alloca.
1705 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 1706
599a9e4f
PE
1707 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1708
99561444
PE
1709 * insdel.c, lisp.h (buffer_overflow): New function.
1710 (insert_from_buffer_1, replace_range, replace_range_2):
1711 * insdel.c (make_gap_larger):
1712 * editfns.c (Finsert_char):
1713 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1714
28177add
PE
1715 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1716
e69dafad
PE
17172011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1718
a7af7fde 1719 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 1720
b1c46f02
PE
1721 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1722 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1723
e69dafad
PE
1724 * fileio.c: Don't assume EMACS_INT fits in off_t.
1725 (emacs_lseek): New static function.
1726 (Finsert_file_contents, Fwrite_region): Use it.
1727 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1728
566684ea
PE
1729 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1730
e6966cd6
PE
1731 * fns.c: Don't overflow int when computing a list length.
1732 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1733 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1734 truncation on 64-bit hosts. Check for QUIT every
1735 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1736 faster and is responsive enough.
1737 (Flength): Report an error instead of overflowing an integer.
1738 (Fsafe_length): Return a float if the value is not representable
1739 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 1740 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 1741 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 1742
dd0b0efb
PE
1743 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1744 (header_size, word_size): New constants.
1745 (allocate_vectorlike): Don't check size overflow here.
1746 (allocate_vector): Check it here instead, since this is the only
1747 caller of allocate_vectorlike that could cause overflow.
1748 Check that the new vector's length is representable as a fixnum.
1749
86fe5cfe
PE
1750 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1751 The previous code was bogus. For example, next_almost_prime (32)
1752 returned 39, which is undesirable as it is a multiple of 3; and
1753 next_almost_prime (24) returned 25, which is a multiple of 5 so
1754 why was the code bothering to check for multiples of 7?
1755
80e88859
PE
1756 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1757
4a2f0ad6
PE
1758 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1759
f66c7cf8
PE
1760 Variadic C functions now count arguments with ptrdiff_t.
1761 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1762 Back then I didn't know that the Emacs coding style prefers signed int.
1763 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
1764 were being counted with int, which may truncate counts on 64-bit
1765 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
1766 * lisp.h (struct Lisp_Subr.function.aMANY)
1767 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1768 Arg counts are now ptrdiff_t, not size_t.
1769 All variadic functions and their callers changed accordingly.
1770 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1771 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1772 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1773 * callint.c (Fcall_interactively): Check arg count for overflow,
1774 to avoid potential buffer overrun. Use signed char, not 'int',
1775 for 'varies' array, so that we needn't bother to check its size
1776 calculation for overflow.
1777 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1778 * eval.c (apply_lambda):
1779 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1780 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1781 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1782
a1759b76
PE
1783 * callint.c (Fcall_interactively): Don't use index var as event count.
1784
d96be9fc
PE
1785 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1786 * mem-limits.h (SIZE): Remove; no longer used.
1787
a690a978 1788 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 1789
578c21e6
PE
1790 Remove unnecessary casts.
1791 * xterm.c (x_term_init):
1792 * xfns.c (x_set_border_pixel):
1793 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1794 These aren't needed now that we assume ANSI C.
1795
96f53c6c
PE
1796 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1797 It's more likely to cause problems (due to unsigned overflow)
1798 than to cure them.
1799
83c77d31
PE
1800 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1801
ee2079f1
PE
1802 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1803
6da65536
PE
1804 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1805
7147c4a4
PE
1806 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1807
193e32d9
PE
1808 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1809
e5533da6
PE
1810 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1811
9910e595
PE
1812 GLYPH_CODE_FACE returns EMACS_INT, not int.
1813 * dispextern.h (merge_faces):
1814 * xfaces.c (merge_faces):
01103c44
PE
1815 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1816 Don't assume EMACS_INT fits in int.
9910e595 1817
2638320e
PE
1818 * character.h (CHAR_VALID_P): Remove unused parameter.
1819 * fontset.c, lisp.h, xdisp.c: All uses changed.
1820
045eb8d9
PE
1821 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1822
c1f134b5
PE
1823 * fns.c (concat): Minor tuning based on overflow analysis.
1824 This doesn't fix any bugs. Use int to hold character, instead
1825 of constantly refetching from Emacs object. Use XFASTINT, not
1826 XINT, for value known to be a character. Don't bother comparing
1827 a single byte to 0400, as it's always less.
1828
395fcb93 1829 * floatfns.c (Fexpt):
327eeec8
PE
1830 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1831
abbd3d23
PE
1832 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1833 for characters.
1834
684a03ef
PE
1835 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1836
0fed43f3
PE
1837 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1838 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1839 incorrectly succeed when S was a string, because 4294967386 was
1840 truncated before it was used.
1841
8fd02eb7
PE
1842 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1843 Otherwise, an out-of-range integer could cause undefined behavior
1844 on a 64-bit host.
1845
f8c86b69
PE
1846 * composite.c: Use int, not EMACS_INT, for characters.
1847 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1848 EMACS_INT, for values that are known to be in character range.
1849 This doesn't fix any bugs but is the usual style inside Emacs and
1850 may generate better code on 32-bit machines.
1851
34206dd2
PE
1852 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1853 This is for reasons similar to the recent CHAR_STRING fix.
1854 * charset.c (Fencode_char): Check that character arg is actually
1855 a character. Pass an int to ENCODE_CHAR.
1856 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1857 wider than 'int', as a compile-time check to prevent future regressions
1858 in this area.
1859
c5958d4c 1860 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
1861
1862 Make sure a 64-bit char is never passed to CHAR_STRING.
1863 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1864 by silently ignoring the top 32 bits, allowing some values
1865 that were far too large to be valid characters.
1866 * character.h: Include <verify.h>.
1867 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1868 arguments are no wider than unsigned, as a compile-time check
1869 to prevent future regressions in this area.
1870 * data.c (Faset):
01103c44 1871 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
1872 (Fsubst_char_in_region):
1873 * fns.c (concat):
1874 * xdisp.c (decode_mode_spec_coding):
1875 Adjust to CHAR_STRING's new requirement.
1876 * editfns.c (Finsert_char, Fsubst_char_in_region):
1877 * fns.c (concat): Check that character args are actually
1878 characters. Without this test, these functions did the wrong
1879 thing with wildly out-of-range values on 64-bit hosts.
1880
d37ca623
PE
1881 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1882 These casts should not be needed on 32-bit hosts, either.
1883 * keyboard.c (read_char):
1884 * lread.c (Fload): Remove casts to unsigned.
1885
ea204efb
PE
1886 * lisp.h (UNSIGNED_CMP): New macro.
1887 This fixes comparison bugs on 64-bit hosts.
1888 (ASCII_CHAR_P): Use it.
1889 * casefiddle.c (casify_object):
01103c44 1890 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
1891 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1892 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1893 * dispextern.h (FACE_FROM_ID):
1894 * keyboard.c (read_char): Use UNSIGNED_CMP.
1895
41cb286c
PE
1896 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1897 not to EMACS_INT, to avoid GCC warning.
1898
4a1b9832
PE
1899 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1900
55daad71
PE
1901 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1902 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1903 isn't needed on 32-bit machines.
8f95c75c 1904
01103c44
PE
1905 * buffer.c (Fgenerate_new_buffer_name):
1906 Use EMACS_INT for count, not int.
0ceccced 1907 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
1908
1909 * data.c (Qcompiled_function): Now static.
1910
c6f072e7
PE
1911 * window.c (window_body_lines): Now static.
1912
20ce5912
PE
1913 * image.c (gif_load): Rename local to avoid shadowing.
1914
9c4c5f81
PE
1915 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1916 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1917 * alloc.c (make_save_value): Integer argument is now of type
1918 ptrdiff_t, not int.
1919 (mark_object): Use ptrdiff_t, not int.
1920 * lisp.h (pD): New macro.
1921 * print.c (print_object): Use it.
1922
c0c5c8ae
PE
1923 * alloc.c: Use EMACS_INT, not int, to count objects.
1924 (total_conses, total_markers, total_symbols, total_vector_size)
1925 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
1926 (total_free_floats, total_floats, total_free_intervals)
1927 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
1928 Now EMACS_INT, not int. All uses changed.
1929 (Fgarbage_collect): Compute overall total using a double, so that
1930 integer overflow is less likely to be a problem. Check for overflow
1931 when converting back to an integer.
5a25e253
PE
1932 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
1933 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
1934 These were 'int' variables that could overflow on 64-bit hosts;
1935 they were never used, so remove them instead of repairing them.
211a0b2a 1936 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
1937 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
1938 Previously, this ceilinged at INT_MAX, but that doesn't work on
1939 64-bit machines.
e46bb31a 1940 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 1941
c78baabf 1942 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 1943 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
1944 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
1945 when a (possibly-narrower) signed value would do just as well.
1946 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 1947
c9d624c6
PE
1948 * alloc.c: Catch some string size overflows that we were missing.
1949 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
1950 for convenience in STRING_BYTES_MAX.
1951 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
1952 The definition here is exact; the one in lisp.h was approximate.
1953 (allocate_string_data): Check for string overflow. This catches
1954 some instances we weren't catching before. Also, it catches
1955 size_t overflow on (unusual) hosts where SIZE_MAX <= min
1956 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
1957 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 1958
c9d624c6
PE
1959 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
1960 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
1961 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
1962
353032ce
PE
1963 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
1964
2bccce07
PE
1965 * alloc.c (Fmake_string): Check for out-of-range init.
1966
0ac30604
SM
19672011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
1968
1969 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
1970
c195f2de
JD
19712011-06-14 Jan Djärv <jan.h.d@swipnet.se>
1972
1973 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
1974 xg_get_default_scrollbar_width.
1975
1976 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
1977 (int_gtk_range_get_value): Move to the scroll bar part of the file.
1978 (style_changed_cb): Call update_theme_scrollbar_width and call
1979 x_set_scroll_bar_default_width and xg_frame_set_char_size for
1980 all frames (Bug#8505).
1981 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
1982 Call gtk_window_set_resizable if HAVE_GTK3.
1983 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
1984 and height if HAVE_GTK3 (Bug#8505).
1985 (scroll_bar_width_for_theme): New variable.
1986 (update_theme_scrollbar_width): New function.
1987 (xg_get_default_scrollbar_width): Move code to
1988 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
1989 (xg_initialize): Call update_theme_scrollbar_width.
1990
1991 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
1992
1993 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
1994
e10ac9f1
MR
19952011-06-12 Martin Rudalics <rudalics@gmx.at>
1996
1997 * frame.c (make_frame): Call other_buffer_safely instead of
1998 other_buffer.
1999
2000 * window.c (temp_output_buffer_show): Call display_buffer with
2001 second argument Vtemp_buffer_show_specifiers and reset latter
2002 immediately after the call.
2003 (Vtemp_buffer_show_specifiers): New variable.
2004 (auto_window_vscroll_p, next_screen_context_lines)
2005 (Vscroll_preserve_screen_position): Remove leading asterisks from
2006 doc-strings.
2007
2d3c217e 20082011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 2009
7b7f97e8 2010 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
2011 * buffer.c (Qclone_number): Remove for now, as it's unused.
2012 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2013 (record_buffer): Remove unused local.
2014 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2015 (set_frame_buffer_list): Remove; unused.
2016 * frame.h (other_visible_frames): Remove decl.
2017 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2018 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2019 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2020 if HAVE_GPM.
2021 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2022 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2023 Define only if HAVE_GPM.
2024 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2025 (update_hints_inhibit): Remove; never set. All uses removed.
2026 * widgetprv.h (emacsFrameClassRec): Remove decl.
2027 * window.c (delete_deletable_window): Now returns void, since it
2028 wasn't returning anything.
2029 (compare_window_configurations): Remove unused locals.
2030 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2031 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
2032 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2033 the same widths as pointers. This follows up on the 2011-05-06 patch.
2034 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2035 * xterm.h: Likewise.
2036 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2037
1384b89e
JB
20382011-06-12 Juanma Barranquero <lekktu@gmail.com>
2039
2040 * makefile.w32-in: Update dependencies.
2041 (LISP_H): Add lib/intprops.h.
2042
1100a63c
CY
20432011-06-11 Chong Yidong <cyd@stupidchicken.com>
2044
2045 * image.c (gif_load): Add animation frame delay to the metadata.
2046 (syms_of_image): Use DEFSYM. New symbol `delay'.
2047
6198ccd0
MR
20482011-06-11 Martin Rudalics <rudalics@gmx.at>
2049
2050 * window.c (delete_deletable_window): Re-add.
2051 (Fset_window_configuration): Rewrite to handle dead buffers and
2052 consequently deletable windows.
2053 (window_tree, Fwindow_tree): Remove. Supply functionality in
2054 window.el.
2055 (compare_window_configurations): Simplify code.
2056
b6e3633c
AS
20572011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2058
1ab0dee5
AS
2059 * image.c (imagemagick_load_image): Fix type mismatch.
2060 (Fimagemagick_types): Likewise.
2061
b6e3633c
AS
2062 * window.h (replace_buffer_in_windows): Declare.
2063
9397e56f
MR
20642011-06-11 Martin Rudalics <rudalics@gmx.at>
2065
2066 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2067 Qclone_number. Remove external declaration of Qdelete_window.
2068 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2069 code.
2070 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
2071 Qbuffer_list_update_hook if allowed.
2072 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2073 buffer list implementation.
2074 (other_buffer_safely): New function.
2075 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2076 calls to replace_buffer_in_windows and
2077 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2078 if allowed.
2079 (record_buffer): Inhibit quitting and rewrite using quittable
2080 functions. Run Qbuffer_list_update_hook if allowed.
2081 (Frecord_buffer, Funrecord_buffer): New functions.
2082 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
2083 switch-to-buffer to window.el.
2084 (bury-buffer): Move to window.el.
2085 (Vbuffer_list_update_hook): New variable.
2086
2087 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2088 section.
2089
2090 * window.h (resize_frame_windows): Move up in code.
2091 (Fwindow_frame): Remove EXFUN.
2092 (replace_buffer_in_all_windows): Remove prototype.
2093 (replace_buffer_in_windows_safely): Add prototype.
2094
2095 * window.c: Declare Qdelete_window static again. Move down
2096 declaration of select_count.
2097 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2098 (Fother_window): Move to window.el.
2099 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2100 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2101 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2102 window.el.
2103 (replace_buffer_in_windows): Implement by calling
2104 Qreplace_buffer_in_windows.
2105 (replace_buffer_in_all_windows): Remove with some functionality
2106 moved into replace_buffer_in_windows_safely.
2107 (replace_buffer_in_windows_safely): New function.
2108 (select_window_norecord, select_frame_norecord): Move in front
2109 of run_window_configuration_change_hook. Remove now obsolete
2110 declarations.
2111 (Fset_window_buffer): Rewrite doc-string. Call
2112 Qrecord_window_buffer.
2113 (keys_of_window): Move binding for other-window to window.el.
2114
b50691aa
CY
21152011-06-11 Chong Yidong <cyd@stupidchicken.com>
2116
2117 * dispextern.h (struct image): Replace data member, whose int_val
2118 and ptr_val fields were not used by anything, with a single
2119 lisp_val object.
2120
2121 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2122 (gif_clear_image, gif_load, imagemagick_load_image)
2123 (gs_clear_image, gs_load): Callers changed.
2124
3f754b86
PE
21252011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2126
cca69397
PE
2127 * buffer.h: Include <time.h>, for time_t.
2128 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2129
109e28d0
PE
2130 Fix minor problems found by static checking.
2131
60737f02
PE
2132 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2133
4b66faf3
PE
2134 Make identifiers static if they are not used in other modules.
2135 * data.c (Qcompiled_function, Qframe, Qvector):
2136 * image.c (QimageMagick, Qsvg):
2137 * minibuf.c (Qmetadata):
2138 * window.c (resize_window_check, resize_root_window): Now static.
2139 * window.h (resize_window_check, resize_root_window): Remove decls.
2140
109e28d0
PE
2141 * window.c (window_deletion_count, delete_deletable_window):
2142 Remove; unused.
46a4ce9e
PE
2143 (window_body_lines): Now static.
2144 (Fdelete_other_windows_internal): Mark vars as initialized.
2145 Make sure 'resize_failed' is initialized.
2146 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2147 (resize_window_apply): Remove unused local.
2148 * window.h (delete_deletable_window): Remove decl.
2149
109e28d0 2150 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
2151 (imagemagick_load_image): Fix pointer signedness problem by changing
2152 last arg from unsigned char * to char *. All uses changed.
2153 Also, fix a local for similar reasons.
2154 Remove unused locals. Remove locals to avoid shadowing.
2155 (fn_rsvg_handle_free): Remove; unused.
2156 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 2157 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 2158
3f754b86
PE
2159 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2160
2547adb1
CY
21612011-06-10 Chong Yidong <cyd@stupidchicken.com>
2162
2163 * image.c (gif_load): Fix omitted cast error introduced by
2164 2011-06-06 change.
2165
2c8e37d4
MR
21662011-06-10 Martin Rudalics <rudalics@gmx.at>
2167
2168 * window.h (resize_proportionally, orig_total_lines)
2169 (orig_top_line): Remove from window structure.
2170 (set_window_height, set_window_width, change_window_heights)
2171 (Fdelete_window): Remove prototypes.
2172 (resize_frame_windows): Remove duplicate declaration.
2173
440a42e3
EZ
21742011-06-10 Eli Zaretskii <eliz@gnu.org>
2175
2176 * window.h (resize_frame_windows, resize_window_check)
2177 (delete_deletable_window, resize_root_window)
2178 (resize_frame_windows): Declare prototypes.
2179
2180 * window.c (resize_window_apply): Make definition be "static" to
2181 match the prototype.
2182
562dd5e9
MR
21832011-06-10 Martin Rudalics <rudalics@gmx.at>
2184
2185 * window.c: Remove declarations of Qwindow_size_fixed,
2186 window_min_size_1, window_min_size_2, window_min_size,
2187 size_window, window_fixed_size_p, enlarge_window, delete_window.
2188 Remove static from declaration of Qdelete_window, it's
2189 temporarily needed by Fbury_buffer.
2190 (replace_window): Don't assign orig_top_line and
2191 orig_total_lines.
2192 (Fdelete_window, delete_window): Remove. Window deletion is
2193 handled by window.el.
2194 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
2195 Fdelete_window calls with calls to Qdelete_window.
2196 (Fdelete_other_windows): Remove. Deleting other windows is
2197 handled by window.el.
2198 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2199 handled in window.el.
2200 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2201 Window minimum sizes are handled in window.el.
2202 (shrink_windows, size_window, set_window_height)
2203 (set_window_width, change_window_heights, window_height)
2204 (window_width, CURBEG, CURSIZE, enlarge_window)
2205 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2206 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2207 handled in window.el.
2208 (make_dummy_parent): Rename to make_parent_window and give it a
2209 second argument horflag.
2210 (make_window): Don't set resize_proportionally any more.
2211 (Fsplit_window): Remove. Windows are split in window.el.
2212 (save_restore_action, save_restore_orig_size)
2213 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2214 Resize mini windows in window.el.
2215 (grow_mini_window, shrink_mini_window): Implement by calling
2216 Qresize_root_window_vertically, resize_window_check and
2217 resize_window_apply.
2218 (saved_window, Fset_window_configuration, save_window_save): Do
2219 not handle orig_top_line, orig_total_lines, and
2220 resize_proportionally.
2221 (window_min_height, window_min_width): Move to window.el.
2222 (keys_of_window): Move bindings for delete-other-windows,
2223 split-window, delete-window and enlarge-window to window.el.
2224
2225 * buffer.c: Temporarily extern Qdelete_window.
2226 (Fbury_buffer): Temporarily call Qdelete_window instead of
2227 Fdelete_window (Fbury_buffer will move to window.el soon).
2228
2229 * frame.c (set_menu_bar_lines_1): Remove code handling
2230 orig_top_line and orig_total_lines.
2231
2232 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2233 set_window_height but set heights directly.
2234 (change_frame_size_1): Use resize_frame_windows.
2235
2236 * xdisp.c (init_xdisp): Don't use set_window_height but set
2237 heights directly.
2238
2239 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
2240 resize_frame_windows instead of change_window_heights and run
2241 run_window_configuration_change_hook.
2242
2243 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2244 instead of change_window_heights and run
2245 run_window_configuration_change_hook.
2246
1a13852e
MR
22472011-06-09 Martin Rudalics <rudalics@gmx.at>
2248
2249 * window.c (replace_window): Rename second argument REPLACEMENT to
2250 NEW. New third argument SETFLAG. Rewrite.
2251 (delete_window, make_dummy_parent): Call replace_window with
2252 third argument 1.
2253 (window_list_1): Move down in code.
2254 (run_window_configuration_change_hook): Move set_buffer part
2255 before select_frame_norecord part in order to unwind correctly.
2256 Rename count1 to count.
2257 (recombine_windows, delete_deletable_window, resize_root_window)
2258 (Fdelete_other_windows_internal)
2259 (Frun_window_configuration_change_hook, make_parent_window)
2260 (resize_window_check, resize_window_apply, Fresize_window_apply)
2261 (resize_frame_windows, Fsplit_window_internal)
2262 (Fdelete_window_internal, Fresize_mini_window_internal): New
2263 functions.
2264 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2265
f3d1777e
MR
22662011-06-08 Martin Rudalics <rudalics@gmx.at>
2267
496e208e
MR
2268 * window.h (window): Add some new members to window structure -
2269 normal_lines, normal_cols, new_total, new_normal, clone_number,
2270 splits, nest, prev_buffers, next_buffers.
2271 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 2272 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 2273
f3d1777e
MR
2274 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2275 Remove.
496e208e
MR
2276 (make_dummy_parent): Set new members of windows structure.
2277 (make_window): Move down in code. Handle new members of window
2278 structure.
2279 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2280 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2281 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2282 (Fset_window_prev_buffers, Fwindow_next_buffers)
2283 (Fset_window_next_buffers, Fset_window_clone_number): New
2284 functions.
2285 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2286 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2287 Doc-string fixes.
2288 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2289 Argument WINDOW can be now internal window too.
2290 (Fwindow_use_time): Move up in code.
2291 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2292 Rewrite doc-string.
2293 (Fset_window_configuration, saved_window)
2294 (Fcurrent_window_configuration, save_window_save): Handle new
2295 members of window structure.
b9e809c2
MR
2296 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2297 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2298 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2299 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2300 Qget_mru_window, Qresize_root_window,
2301 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2302 Qauto_buffer_name; staticpro them.
f3d1777e 2303
abde8f8c
MR
23042011-06-07 Martin Rudalics <rudalics@gmx.at>
2305
2306 * window.c (Fwindow_total_size, Fwindow_left_column)
2307 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2308 (Fwindow_list_1): New functions.
2309 (window_box_text_cols): Replace with window_body_cols.
2310 (Fwindow_width, Fscroll_left, Fscroll_right): Use
2311 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
2312 (delete_window, Fset_window_configuration): Call
2313 delete_all_subwindows with window as argument.
2314 (delete_all_subwindows): Take a window as argument and not a
2315 structure. Rewrite.
190b47e6
MR
2316 (window_loop): Remove handling of GET_LRU_WINDOW and
2317 GET_LARGEST_WINDOW.
2318 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
2319
2320 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
2321 window_box_text_cols. delete_all_subwindows now takes a
2322 Lisp_Object as argument.
abde8f8c
MR
2323
2324 * indent.c (compute_motion, Fcompute_motion): Use
2325 window_body_cols instead of window_box_text_cols.
2326
fa8a67e6
MR
2327 * frame.c (delete_frame): Call delete_all_subwindows with root
2328 window as argument.
2329
a54e3482
DC
23302011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2331
2332 * fns.c (Fputhash): Document return value.
2333
60002bf5
CY
23342011-06-06 Chong Yidong <cyd@stupidchicken.com>
2335
2336 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2337
0c671da6 23382011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 2339
b862a52a 2340 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 2341
be44ca6c
PE
2342 Check for overflow when converting integer to cons and back.
2343 * charset.c (Fdefine_charset_internal, Fdecode_char):
2344 Use cons_to_unsigned to catch overflow.
2345 (Fencode_char): Use INTEGER_TO_CONS.
2346 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2347 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2348 * data.c (long_to_cons, cons_to_long): Remove.
2349 (cons_to_unsigned, cons_to_signed): New functions.
2350 These signal an error for invalid or out-of-range values.
2351 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2352 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2353 * font.c (Ffont_variation_glyphs):
2354 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2355 * lisp.h: Include <intprops.h>.
2356 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2357 (cons_to_signed, cons_to_unsigned): New decls.
2358 (long_to_cons, cons_to_long): Remove decls.
2359 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2360 (Fprimitive_undo): Use CONS_TO_INTEGER.
2361 * xfns.c (Fx_window_property): Likewise.
2362 * xselect.c: Include <limits.h>.
2363 (x_own_selection, selection_data_to_lisp_data):
2364 Use INTEGER_TO_CONS.
2365 (x_handle_selection_request, x_handle_selection_clear)
2366 (x_get_foreign_selection, Fx_disown_selection_internal)
2367 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2368 (lisp_data_to_selection_data): Use cons_to_unsigned.
2369 (x_fill_property_data): Use cons_to_signed.
2370 Report values out of range.
2371
d1f3d2af
PE
2372 Check for buffer and string overflow more precisely.
2373 * buffer.h (BUF_BYTES_MAX): New macro.
2374 * lisp.h (STRING_BYTES_MAX): New macro.
2375 * alloc.c (Fmake_string):
2376 * character.c (string_escape_byte8):
2377 * coding.c (coding_alloc_by_realloc):
2378 * doprnt.c (doprnt):
2379 * editfns.c (Fformat):
2380 * eval.c (verror):
2381 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2382 since they may not be the same number.
2383 * editfns.c (Finsert_char):
2384 * fileio.c (Finsert_file_contents):
2385 Likewise for BUF_BYTES_MAX.
2386
dd52fcea
PE
2387 * image.c: Use ptrdiff_t, not int, for sizes.
2388 (slurp_file): Switch from int to ptrdiff_t.
2389 All uses changed.
2390 (slurp_file): Check that file size fits in both size_t (for
2391 malloc) and ptrdiff_t (for sanity and safety).
2392
7f9bbdbb
PE
2393 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2394 if b->modtime has its maximal value.
2395
dfe18f82
PE
2396 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2397
84acfcf0
PE
2398 Don't assume time_t can fit into int.
2399 * buffer.h (struct buffer.modtime): Now time_t, not int.
2400 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2401 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2402
ccd9a01a
PE
2403 Minor fixes for signed vs unsigned integers.
2404 * character.h (MAYBE_UNIFY_CHAR):
2405 * charset.c (maybe_unify_char):
2406 * keyboard.c (read_char, reorder_modifiers):
2407 XINT -> XFASTINT, since the integer must be nonnegative.
2408 * ftfont.c (ftfont_spec_pattern):
2409 * keymap.c (access_keymap, silly_event_symbol_error):
2410 XUINT -> XFASTINT, since the integer must be nonnegative.
2411 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2412 since it makes no difference and we prefer signed.
2413 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2414 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2415 nonnegative.
2416
d6d100dd
SM
24172011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2418
2419 * window.h (Fwindow_frame): Declare.
2420
2b6148e4
PE
24212011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2422
2423 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2424 (SPARE_MEMORY): Always define.
2425 (LARGE_REQUEST): Remove.
2426 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2427
f230ecc9
MR
24282011-06-06 Martin Rudalics <rudalics@gmx.at>
2429
727e958e
MR
2430 * lisp.h: Move EXFUNS for Fframe_root_window,
2431 Fframe_first_window and Fset_frame_selected_window to window.h.
2432
2433 * window.h: Move EXFUNS for Fframe_root_window,
2434 Fframe_first_window and Fset_frame_selected_window here from
2435 lisp.h.
2436
2437 * frame.c (Fwindow_frame, Fframe_first_window)
2438 (Fframe_root_window, Fframe_selected_window)
2439 (Fset_frame_selected_window): Move to window.c.
2440 (Factive_minibuffer_window): Move to minibuf.c.
2441 (Fother_visible_frames_p): New function.
2442
2443 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2444
f230ecc9
MR
2445 * window.c (decode_window, decode_any_window): Move up in code.
2446 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2447 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
2448 (Fwindow_buffer): Move up and rewrite doc-string.
2449 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2450 (Fwindow_prev): New functions.
727e958e
MR
2451 (Fwindow_frame): Move here from frame.c. Accept any window as
2452 argument.
2453 (Fframe_root_window, Fframe_first_window)
2454 (Fframe_selected_window): Move here from frame.c. Accept frame
2455 or arbitrary window as argument. Update doc-strings.
2456 (Fminibuffer_window): Move up in code.
2457 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
2458 (Fset_frame_selected_window): Move here from frame.c.
2459 Marginal rewrite.
727e958e
MR
2460 (Fselected_window, select_window, Fselect_window): Move up in
2461 code. Minor doc-string fixes.
f230ecc9 2462
4d09bcf6
PE
24632011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2464
2465 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2466 Do not assume that spare memory exists; that assumption is valid
2467 only if SYSTEM_MALLOC.
2468 (LARGE_REQUEST): New macro, so that the issue of large requests
2469 is separated from the issue of spare memory.
2470
810928a2
AS
24712011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2472
172418ad
AS
2473 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2474 format. (Bug#8806)
2475
43f862f7
AS
2476 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2477
810928a2
AS
2478 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2479 before statements.
2480
a059fe24
JD
24812011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2482
2483 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2484
2485 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2486
2487 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2488 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2489
989bf368
JB
24902011-06-05 Juanma Barranquero <lekktu@gmail.com>
2491
2492 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2493
4b80f674
CY
24942011-06-04 Chong Yidong <cyd@stupidchicken.com>
2495
2496 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2497 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
2498 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2499 New error handlers.
4b80f674
CY
2500 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2501 Obey Vx_select_enable_clipboard_manager. Catch errors in
2502 x_clipboard_manager_save (Bug#8779).
2503 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 2504 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 2505
99a33b77 25062011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
2507
2508 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2509
99a33b77 25102011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
2511
2512 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2513 in the current matrix if keep_current_p is non-zero.
2514
8264569d
EZ
25152011-06-04 Eli Zaretskii <eliz@gnu.org>
2516
2517 * bidi.c (bidi_level_of_next_char): Fix last change.
2518
57f97249
EZ
25192011-06-03 Eli Zaretskii <eliz@gnu.org>
2520
fec2107c 2521 Support bidi reordering of text covered by display properties.
57f97249 2522
fec2107c
EZ
2523 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2524 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2525 (bidi_cache_search, bidi_cache_iterator_state)
2526 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
2527 (bidi_level_of_next_char, bidi_move_to_visually_next):
2528 Support character positions inside a run of characters covered by a
fec2107c
EZ
2529 display string.
2530 (bidi_paragraph_init, bidi_resolve_explicit_1)
2531 (bidi_level_of_next_char): Call bidi_fetch_char and
2532 bidi_fetch_char_advance instead of FETCH_CHAR and
2533 FETCH_CHAR_ADVANCE.
2534 (bidi_init_it): Initialize new members.
2535 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2536 definitions.
2537 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2538 instead of using explicit *_CHAR codes.
d6d100dd
SM
2539 (bidi_resolve_explicit, bidi_resolve_weak):
2540 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
2541 bidirectional text is supported only in multibyte buffers.
2542 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2543 it to initialize the frame_window_p member of struct bidi_it.
2544 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2545 (bidi_resolve_explicit, bidi_resolve_weak)
2546 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2547 bidi_it->nchars is non-positive.
2548 (bidi_level_of_next_char): Don't try to lookup the cache for the
2549 next/previous character if nothing is cached there yet, or if we
2550 were just reseat()'ed to a new position.
c40e2fb2 2551
0e14fe90
EZ
2552 * xdisp.c (set_cursor_from_row): Set start and stop points
2553 according to the row's direction when priming the loop that looks
2554 for the glyph on which to display cursor.
2555 (single_display_spec_intangible_p): Function deleted.
2556 (display_prop_intangible_p): Reimplement to call
2557 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
2558 Accept 3 additional arguments needed by handle_display_spec.
2559 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
2560 values: lists, `(when COND...)' forms, etc.
2561 (single_display_spec_string_p): Support property values that are
2562 lists with the argument STRING its top-level element.
2563 (display_prop_string_p): Fix the condition for processing a
2564 property that is a list to be consistent with handle_display_spec.
fec2107c 2565 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
2566 last portion of handle_display_prop.
2567 (compute_display_string_pos): Accept additional argument
2568 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2569 value of a `display' property is a "replacing spec".
2570 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2571 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2572 the display property, but just return a value indicating whether
2573 the display property will replace the characters it covers.
2574 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2575 frame_window_p members of struct bidi_it.
d6d100dd
SM
2576 (compute_display_string_pos, compute_display_string_end):
2577 New functions.
fec2107c
EZ
2578 (push_it): Accept second argument POSITION, where pop_it should
2579 jump to continue iteration.
2580 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 2581
fec2107c
EZ
2582 * keyboard.c (adjust_point_for_property): Adjust the call to
2583 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
2584
2585 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
2586 (bidi_init_it): Update prototypes.
2587 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
2588 (compute_display_string_pos, compute_display_string_end):
2589 Declare prototypes.
fec2107c
EZ
2590 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2591 EMACS_INT.
fc6f18ce 2592
40087514 25932011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 2594
57f53182
PE
2595 Malloc failure behavior now depends on size of allocation.
2596 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2597 * lisp.h: Change signatures accordingly.
2598 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2599 All callers changed. (Bug#8762)
2600
2601 * gnutls.c: Use Emacs's memory allocators.
2602 Without this change, the gnutls library would invoke malloc etc.
2603 directly, which causes problems on non-SYNC_INPUT hosts, and which
2604 runs afoul of improving memory_full behavior. (Bug#8761)
2605 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2606 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2607 xfree instead of the default malloc, realloc, free.
2608 (Fgnutls_boot): No need to check for memory allocation failure,
2609 since xmalloc does that for us.
2610
ac32cd99 2611 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
2612 * category.c (hash_get_category_set):
2613 * ccl.c (ccl_driver):
2614 * charset.c (Fdefine_charset_internal):
2615 * charset.h (struct charset.hash_index):
2616 * composite.c (get_composition_id, gstring_lookup_cache)
2617 (composition_gstring_put_cache):
2618 * composite.h (struct composition.hash_index):
2619 * dispextern.h (struct image.hash):
2620 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2621 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2622 (hashfn_equal, hashfn_user_defined, make_hash_table)
2623 (maybe_resize_hash_table, hash_lookup, hash_put)
2624 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2625 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2626 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2627 * image.c (make_image, search_image_cache, lookup_image)
2628 (xpm_put_color_table_h):
2629 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 2630 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 2631 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 2632 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
2633 * alloc.c (allocate_vectorlike):
2634 Check for overflow in vector size calculations.
2635 * ccl.c (ccl_driver):
2636 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
2637 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2638 need to be updated by these changes.
40087514
PE
2639 * fns.c (make_hash_table, maybe_resize_hash_table):
2640 Check for integer overflow with large hash tables.
0de4bb68
PE
2641 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2642 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2643 (SXHASH_REDUCE): New macro.
2644 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2645 Use it instead of discarding useful hash info with large hash values.
2646 (sxhash_float): New function.
2647 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2648 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
2649 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2650 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
2651 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2652 Adjust signatures to match updated version of code.
2653 (consing_since_gc): Now EMACS_INT, since a single hash table can
2654 use more than INT_MAX bytes.
2655
698d32e2
DN
26562011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2657
2658 Make it possible to build with GCC-4.6+ -O2 -flto.
2659
2660 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2661
fd6fa53f
SM
26622011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2663
2664 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2665 Call minibuffer-inactive-mode.
2666
864db017
JB
26672011-05-31 Juanma Barranquero <lekktu@gmail.com>
2668
2669 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2670 Update dependencies.
2671
2ad0baf4
DN
26722011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2673
2674 * data.c (init_data): Remove code for UTS, this system is not
2675 supported anymore.
2676
4fcc2638
DN
26772011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2678
2679 Don't force ./temacs to start in terminal mode.
2680
2681 * frame.c (make_initial_frame): Initialize faces in all cases, not
2682 only when CANNOT_DUMP is defined.
2683 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2684
c56e0fd5
DN
26852011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2686
2687 * dispnew.c (add_window_display_history): Use const for the string
2688 pointer. Remove declaration, not needed.
2689
333d54da 26902011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 2691
55d4c1b2 2692 Use 'inline', not 'INLINE'.
333d54da 2693 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
2694 * alloc.c, fontset.c (INLINE): Remove.
2695 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2696 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2697 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2698 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2699 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2700
738db178
DN
27012011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2702
2703 Make it possible to run ./temacs.
2704
2705 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2706 syms_of_callproc does the same thing. Remove test for
2707 "initialized", do it in the caller.
2708 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2709
620c53a6
SM
27102011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2711
2712 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2713 (read_minibuf): Use get_minibuffer.
2714 (syms_of_minibuf): Use DEFSYM.
2715 (Qmetadata): New var.
2716 * data.c (Qbuffer): Don't make it static.
2717 (syms_of_data): Use DEFSYM.
2718
e003a292
PE
27192011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2720
2721 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2722 (CCL_CODE_MIN): New macro.
2723
ed008a6d
PE
27242011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2725
3687c2ef
PE
2726 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2727
ed008a6d
PE
2728 * eval.c (Qdebug): Now static.
2729 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2730 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2731 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2732
d66c4c7c
CY
27332011-05-29 Chong Yidong <cyd@stupidchicken.com>
2734
2735 * image.c: Various fixes to ImageMagick code comments.
2736 (Fimagemagick_types): Doc fix.
2737
5fbc2025
PE
27382011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2739
0196f88a
PE
2740 Minor fixes prompted by GCC 4.6.0 warnings.
2741
2742 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2743
5fbc2025
PE
2744 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2745 (x_clipboard_manager_save_all): Move extern decl to ...
2746 * xterm.h: ... here, so that it can be checked for consistency.
2747
1dd3c2d9
CY
27482011-05-29 Chong Yidong <cyd@stupidchicken.com>
2749
2750 * xselect.c (x_clipboard_manager_save_frame)
2751 (x_clipboard_manager_save_all): New functions.
2752 (Fx_clipboard_manager_save): Lisp function deleted.
2753
2754 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2755 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2756
2757 * xterm.h: Update prototype.
2758
5ba6571d
WX
27592011-05-28 William Xu <william.xwl@gmail.com>
2760
2761 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2762 exiting (Bug#8239).
2763
3eaff834
JM
27642011-05-28 Jim Meyering <meyering@redhat.com>
2765
e1900994 2766 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
2767 * fns.c (to_uchar): Define.
2768 (crypto_hash_function): Use it to convert some newly-signed
2769 variables to unsigned, to avoid sign-extension bugs. For example,
2770 without this change, (md5 "truc") would evaluate to
2771 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2772 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 2773 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 2774
0f6990a7
PE
27752011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2776
2777 Integer overflow fixes.
c8a9ca5a 2778
08686060
PE
2779 * dbusbind.c: Serial number integer overflow fixes.
2780 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
2781 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2782 to hold a serial number that is too large for a fixnum.
2783 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2784 Check for serial numbers out of range. Decode any serial number
59568bf0 2785 that was so large that it became a float. (Bug#8722)
08686060 2786
2d1fc3c7
PE
2787 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2788 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2789 Use XFASTINT rather than XUINT when numbers are nonnegative.
2790 (xd_append_arg, Fdbus_method_return_internal):
2791 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2792 arguments, check that Lisp number is nonnegative, rather than
59568bf0 2793 silently wrapping negative numbers around. (Bug#8722)
30217ff0 2794 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 2795 (Bug#8722)
2d1fc3c7 2796
c8a9ca5a
PE
2797 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2798
519e1d69
PE
2799 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2800
30569699
PE
2801 ccl: add integer overflow checks
2802 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2803 (IN_INT_RANGE): New macros.
2804 (ccl_driver): Use them to check for integer overflow when
2805 decoding a CCL program. Many of the new checks are whether XINT (x)
2806 fits in int; it doesn't always, on 64-bit hosts. The new version
2807 doesn't catch all possible integer overflows, but it's an
847044ea 2808 improvement. (Bug#8719)
30569699 2809
c11285dc
PE
2810 * alloc.c (make_event_array): Use XINT, not XUINT.
2811 There's no need for unsigned here.
2812
fdccd48e
PE
2813 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2814 This follows up to the 2011-05-06 change that substituted uintptr_t
2815 for EMACS_INT. This case wasn't caught back then.
2816
37910ab2
PE
2817 Rework Fformat to avoid integer overflow issues.
2818 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2819 now (part of C89). Include <verify.h>.
2820 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2821 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2822 (Fformat): Avoid the prepass trying to compute sizes; it was only
2823 approximate and thus did not catch overflow reliably. Instead, walk
2824 through the format just once, formatting and computing sizes as we go,
2825 checking for integer overflow at every step, and allocating a larger
2826 buffer as needed. Keep track separately whether the format is
2827 multibyte. Keep only the most-recently calculated precision, rather
2828 than them all. Record whether each argument has been converted to
2829 string. Use EMACS_INT, not int, for byte and char and arg counts.
2830 Support field widths and precisions larger than INT_MAX. Avoid
2831 sprintf's undefined behavior with conversion specifications such as %#d
2832 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2833 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2834 formatting out-of-range floating point numbers with int
9173deec 2835 formats. (Bug#8668)
37910ab2 2836
2e6578fb
PE
2837 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2838
0ae6bdee
PE
2839 * data.c: Avoid integer truncation in expressions involving floats.
2840 * data.c: Include <intprops.h>.
2841 (arith_driver): When there's an integer overflow in an expression
2842 involving floating point, convert the integers to floating point
2843 so that the resulting value does not suffer from catastrophic
2844 integer truncation. For example, on a 64-bit host (* 4
2845 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2846 Do not rely on undefined behavior after integer overflow.
2847
de883a70
PE
2848 merge count_size_as_multibyte, parse_str_to_multibyte
2849 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 2850 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
2851 Check for integer overflow.
2852 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2853 since it's now a duplicate of the other. This is more of
2854 a character than a buffer op, so better that it's in character.c.
2855 * fns.c, print.c: Adjust to above changes.
2856
2ff916cb
PE
28572011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2858
2859 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2860
f1b54466
PE
28612011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2862
fb1ac845
PE
2863 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2864 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2865 (x_clipboard_manager_save): Now static.
2866 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2867
f1b54466
PE
2868 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2869 (crypto_hash_function): Now static.
2870 Fix pointer signedness problems. Avoid unnecessary initializations.
2871
a9f737ee
CY
28722011-05-27 Chong Yidong <cyd@stupidchicken.com>
2873
2874 * termhooks.h (Vselection_alist): Make it terminal-local.
2875
2876 * terminal.c (create_terminal): Initialize it.
2877
2878 * xselect.c: Support for clipboard managers.
2879 (Vselection_alist): Move to termhooks.h as terminal-local var.
2880 (LOCAL_SELECTION): New macro.
2881 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2882 (symbol_to_x_atom): Remove gratuitous arg.
2883 (x_handle_selection_request, lisp_data_to_selection_data)
2884 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
2885 (x_own_selection, x_get_local_selection, x_convert_selection):
2886 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
2887 (some_frame_on_display): Delete unused function.
2888 (Fx_own_selection_internal, Fx_get_selection_internal)
2889 (Fx_disown_selection_internal, Fx_selection_owner_p)
2890 (Fx_selection_exists_p): New optional frame arg.
2891 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2892 (x_handle_selection_clear): Don't treat other terminals with the
2893 same keyboard specially. Use the terminal-local Vselection_alist.
2894 (x_clear_frame_selections): Use Frun_hook_with_args.
2895
2896 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2897
2898 * xterm.h: Add support for those atoms.
2899
e067f0c1
CY
29002011-05-26 Chong Yidong <cyd@stupidchicken.com>
2901
2902 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2903 (converted_selections, conversion_fail_tag): New global variables.
2904 (x_selection_request_lisp_error): Free the above.
2905 (x_get_local_selection): Remove unnecessary code.
2906 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
2907 of converted selections stored in converted_selections.
2908 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
2909 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2910 (x_convert_selection): New function.
2911 (x_handle_selection_event): Simplify.
2912 (x_get_foreign_selection): Don't ignore incoming requests while
2913 waiting for an answer; this will fail when we implement
2914 SAVE_TARGETS, and seems unnecessary anyway.
2915 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2916 (Vx_sent_selection_functions): Doc fix.
2917
0f4aebc0
LL
29182011-05-26 Leo Liu <sdl.web@gmail.com>
2919
2920 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2921
e61124cd
YM
29222011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2923
2924 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
2925
2926 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
2927 for fringe update if it has periodic bitmap.
ac389d0c 2928 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
2929 and fringe_bitmap_periodic_p.
2930
2931 * fringe.c (get_fringe_bitmap_data): New function.
2932 (draw_fringe_bitmap_1, update_window_fringes): Use it.
2933 (update_window_fringes): Record periodicity of fringe bitmap in glyph
2934 row. Mark glyph row for fringe update if periodicity changed.
2935
2936 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
2937 for fringe update unless it has periodic bitmap.
2938
f16d9837
KH
29392011-05-25 Kenichi Handa <handa@m17n.org>
2940
2941 * xdisp.c (get_next_display_element): Set correct it->face_id for
2942 a static composition.
2943
e1b90ef6
LL
29442011-05-24 Leo Liu <sdl.web@gmail.com>
2945
2946 * deps.mk (fns.o):
2947 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
2948
2949 * fns.c (crypto_hash_function, Fsha1): New function.
2950 (Fmd5): Use crypto_hash_function.
2951 (syms_of_fns): Add Ssha1.
2952
7400048f
PE
29532011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2954
2955 * gnutls.c: Remove unused macros.
2956 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
2957 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
2958 Remove macros that are defined and never used.
2959 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
2960
abb71cf4
CY
29612011-05-22 Chong Yidong <cyd@stupidchicken.com>
2962
2963 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
2964 (Fx_get_selection_internal): Minor cleanup.
2965 (Fx_own_selection_internal): Rename arguments for consistency with
2966 select.el.
2967
6307db39
PE
29682011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2969
2970 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
2971
f3d4e0a4
CY
29722011-05-22 Chong Yidong <cyd@stupidchicken.com>
2973
2974 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
2975
4d8ade89
YM
29762011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2977
2978 * dispnew.c (scrolling_window): Don't exclude the case that the
2979 last enabled row in the desired matrix touches the bottom boundary.
2980
32078c8d
GM
29812011-05-21 Glenn Morris <rgm@gnu.org>
2982
2983 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
2984 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
2985 and add some more files.
32078c8d 2986
7285dc67
EZ
29872011-05-20 Eli Zaretskii <eliz@gnu.org>
2988
2989 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
2990 report_file_error introduced by the change from 2011-05-07.
2991
89d1bd22
PE
29922011-05-20 Paul Eggert <eggert@cs.ucla.edu>
2993
2994 * systime.h (Time): Define only if emacs is defined.
2995 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
2996 where the include path doesn't have X11/X.h by default. See
2997 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
2998
e23640bb 29992011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
3000
3001 * composite.c (find_automatic_composition): Fix previous change.
3002
b9704ad9
GM
30032011-05-20 Glenn Morris <rgm@gnu.org>
3004
3005 * lisp.mk: New file, split from Makefile.in.
3006 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3007 (shortlisp): Remove.
3008 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3009
4a720484
GM
30102011-05-19 Glenn Morris <rgm@gnu.org>
3011
3012 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3013 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3014 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3015 (lisp): Set the order to that of loadup.el.
3016 (shortlisp): Make it a copy of $lisp.
3017 (SOME_MACHINE_LISP): Remove.
3018 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3019 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3020
a28d4396
KH
30212011-05-18 Kenichi Handa <handa@m17n.org>
3022
3023 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3024 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3025 (find_automatic_composition): Mostly rewrite for efficiency.
3026
a2b1fa8e
JB
30272011-05-18 Juanma Barranquero <lekktu@gmail.com>
3028
3029 * makefile.w32-in: Update dependencies.
3030
8e1f5610
CS
30312011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3032
3033 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 3034 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 3035
7025ee00 30362011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 3037
cdfa6eab
PE
3038 Fix some integer overflow issues, such as string length overflow.
3039
06d6db33
PE
3040 * insdel.c (count_size_as_multibyte): Check for string overflow.
3041
2b4560a8
PE
3042 * character.c (lisp_string_width): Check for string overflow.
3043 Use EMACS_INT, not int, for string indexes and lengths; in
3044 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3045 the resulting string length overflows an EMACS_INT; instead,
3046 report a string overflow if no precision given. When checking for
3047 precision exhaustion, use a check that cannot possibly have
3048 integer overflow. (Bug#8675)
3049 * character.h (lisp_string_width): Adjust to new signature.
3050
cb93f9be
PE
3051 * alloc.c (string_overflow): New function.
3052 (Fmake_string): Use it. This doesn't change behavior, but saves
3053 a few bytes and will simplify future changes.
3054 * character.c (string_escape_byte8): Likewise.
3055 * lisp.h (string_overflow): New decl.
3056
1a1f3366
PE
3057 Fixups, following up to the user-interface timestamp change.
3058 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3059 for UI timestamps, instead of unsigned long.
9fbd6841
PE
3060 * msdos.c (mouse_get_pos): Likewise.
3061 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
3062 * w32gui.h (Time): Define by including "systime.h" rather than by
3063 declaring it ourselves. (Bug#8664)
3064
d4e3e4d3
PE
3065 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3066 * image.c (clear_image_cache): Likewise.
3067
f6a24d19
PE
3068 * term.c (term_mouse_position): Don't assume time_t wraparound.
3069
08dc5ae6
PE
3070 Be more systematic about user-interface timestamps.
3071 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
3072 and sometimes 'EMACS_UINT', to represent these timestamps.
3073 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
3074 This makes the code easier to follow, and makes it easier to catch
3075 integer overflow bugs such as Bug#8664.
3076 * frame.c (Fmouse_position, Fmouse_pixel_position):
3077 Use Time, not unsigned long, for user-interface timestamps.
3078 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3079 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3080 * keyboard.h (last_event_timestamp): Likewise.
3081 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3082 * menu.h (xmenu_show): Likewise.
3083 * term.c (term_mouse_position): Likewise.
3084 * termhooks.h (struct input_event.timestamp): Likewise.
3085 (struct terminal.mouse_position_hook): Likewise.
3086 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3087 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3088 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3089 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3090 what it was before.
3091 * menu.h, termhooks.h: Include "systime.h", for Time.
3092
8e55734a
PE
3093 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3094 Don't assume that the difference between two unsigned long values
3095 can fit into an integer. At this point, we know button_down_time
3096 <= event->timestamp, so the difference must be nonnegative, so
3097 there's no need to cast the result if double-click-time is
3098 nonnegative, as it should be; check that it's nonnegative, just in
3099 case. This bug is triggered when events are more than 2**31 ms
86db42d2 3100 apart (about 25 days). (Bug#8664)
8e55734a 3101
841f1b75 3102 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 3103 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 3104
3e26f69c
PE
3105 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3106 that always fit in int. Use a sentinel instead of a counter, to
3107 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
3108 * frame.h (struct frame): Use int for menu_bar_items_used
3109 instead of EMACS_INT, since it always fits in int.
3e26f69c 3110
5cc152c0
PE
3111 * menu.c (grow_menu_items): Check for int overflow.
3112
d89eb65e
PE
3113 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3114
5235bd3e
PE
3115 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3116 Before, the code was not consistent. These values cannot exceed
3117 2**31 - 1 so there's no need to make them unsigned.
3118 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3119 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3120 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3121 as modifiers.
3122 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3123
bc827e23
PE
3124 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3125 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3126 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3127 presumably because the widths might not match.
3128
78eb494e
PE
3129 * window.c (size_window): Avoid needless test at loop start.
3130
04f2d78b
CB
31312011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3132
3133 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3134
d2fc7e3d 31352011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
3136
3137 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3138
d2fc7e3d 31392011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
3140
3141 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
3142 `width' to `bar_area_x' and `bar_area_width', respectively.
3143 (x_scroll_run): Take account of fringe background extension.
3144
04f2d78b
CB
3145 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3146 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
3147 `bar_area_width', respectively.
3148 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3149 background extension.
3150
79b70037
GM
31512011-05-10 Jim Meyering <meyering@redhat.com>
3152
3153 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3154
2f142cc5
JB
31552011-05-10 Juanma Barranquero <lekktu@gmail.com>
3156
3157 * image.c (Finit_image_library): Return t for built-in image types,
3158 like pbm and xbm. (Bug#8640)
3159
57679c86
AS
31602011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3161
3162 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3163
888c9e86
EZ
31642011-05-07 Eli Zaretskii <eliz@gnu.org>
3165
b0512a1d
EZ
3166 * w32console.c (Fset_screen_color): Doc fix.
3167 (Fget_screen_color): New function.
3168 (syms_of_ntterm): Defsubr it.
3169
7285dc67
EZ
3170 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3171 unlink the temporary file if Fcall_process didn't create it in the
3172 first place.
3173 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3174 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
3175 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3176 cue to call_process_cleanup not to close that handle.
3177
4d3fcc8e
BK
31782011-05-07 Ben Key <bkey76@gmail.com>
3179
3180 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3181 one of two shell specific rules, either bootstrap-temacs-CMD or
3182 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3183 to the previous implementation of the bootstrap-temacs rule.
3184 The bootstrap-temacs-CMD rule is similar to the previous
3185 implementation of the bootstrap-temacs rule except that it
3186 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3187 variable.
3188
3189 These changes, along with some changes to nt/configure.bat,
3190 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3191 earlier fix to add support for --cflags and --ldflags options
3192 that include quotes so that it works whether make uses cmd or
3193 sh as the shell.
3194
b4289b64
MA
31952011-05-06 Michael Albinus <michael.albinus@gmx.de>
3196
3197 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3198 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3199 is a constant.
3200 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3201 a string. Handle both cases.
3202 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3203 (Fdbus_register_method): Use Qinvalid_function.
3204
af4c0e28
JB
32052011-05-06 Juanma Barranquero <lekktu@gmail.com>
3206
3207 * makefile.w32-in: Update dependencies.
3208 (LISP_H): Add inttypes.h and stdin.h.
3209 (PROCESS_H): Add unistd.h.
3210
c51453d9
EZ
32112011-05-06 Eli Zaretskii <eliz@gnu.org>
3212
3213 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3214 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3215
8ff0ac3c 32162011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 3217
4c4b566b
PE
3218 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3219
aab2b9b5
PE
3220 * term.c (vfatal): Remove stray call to va_end.
3221 It's not needed and the C Standard doesn't allow it here anyway.
3222
c378da0b
PE
3223 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3224 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3225
288b08c7
PE
3226 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3227 bytes.
3228
e3601888
PE
3229 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3230
db6c0e74
PE
3231 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3232
dd5963ea
PE
3233 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3234
88c9450f
PE
3235 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3236
2f9442b8
PE
3237 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3238
c032b5f8
PE
3239 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3240 * charset.c (Fdefine_charset_internal): Don't initialize
3241 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 3242 32-bit int (Bug#8600).
a108c10b
PE
3243
3244 * lread.c (read_integer): Be more consistent with string-to-number.
3245 Use string_to_number to do the actual conversion; this avoids
3246 rounding errors and fixes some other screwups. Without this fix,
3247 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3248 (digit_to_number): Move earlier, for benefit of read_integer.
3249 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 3250 not a digit in any supported base. (Bug#8602)
a108c10b 3251
ad5f9eea
PE
3252 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3253
aec1708a
PE
3254 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3255 to match comment at start of function. This also removes a
3256 GCC warning about overflow in a 32+64-bit port.
3257
47be4ab5
PE
3258 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3259
371cac43
PE
3260 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3261 Reported by Stefan Monnier in
3262 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
3263 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3264 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 3265
d01a7826
PE
3266 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3267 (EMACS_UINTPTR): Likewise, with uintptr_t.
3268
7fd47d5c
PE
3269 * lisp.h: Prefer 64-bit EMACS_INT if available.
3270 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3271 on 32-bit hosts that have 64-bit int, so that they can access
3272 large files.
122b0c86
PE
3273 However, temporarily disable this change unless the temporary
3274 symbol WIDE_EMACS_INT is defined.
7fd47d5c 3275
8727937b
PE
3276 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3277
8ac068ac
PE
3278 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3279 This removes an assumption that EMACS_INT and long are the same
3280 width as pointers. The assumption is true for Emacs porting targets
3281 now, but we want to make other targets possible.
3282 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3283 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3284 In the rest of the code, change types of integers that hold casted
3285 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3286 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3287 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3288 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3289 No need to cast type when ORing.
3290 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3291 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3292 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3293 assume EMACS_INT is the same width as char *.
3294 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3295 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3296 Remove no-longer-needed casts.
3297 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3298 (xg_tool_bar_help_callback, xg_make_tool_item):
3299 Use EMACS_INTPTR to hold an integer
3300 that will be cast to void *; this can avoid a GCC warning
3301 if EMACS_INT is not the same width as void *.
3302 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3303 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3304 (current_message_1, set_message_1):
3305 Use a local to convert to proper width without a cast.
3306 * xmenu.c (dialog_selection_callback): Likewise.
3307
ede49d71
PE
3308 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3309 Also, don't assume VALBITS / RAND_BITS is less than 5,
3310 and don't rely on undefined behavior when shifting a 1 left into
3311 the sign bit.
3312 * lisp.h (get_random): Change signature to match.
3313
2f30ecd0
PE
3314 * lread.c (hash_string): Use size_t, not int, for hash computation.
3315 Normally we prefer signed values; but hashing is special, because
3316 it's better to use unsigned division on hash table sizes so that
3317 the remainder is nonnegative. Also, size_t is the natural width
3318 for hashing into memory. The previous code used 'int', which doesn't
3319 retain enough info to hash well into very large tables.
3320 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3321
2a866e7b
PE
3322 * dbusbind.c: Don't possibly lose pointer info when converting.
3323 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3324 Use XPNTR rather than XHASH, so that the high-order bits of
3325 the pointer aren't lost when converting through void *.
3326
51639eac
PE
3327 * eval.c (Fautoload): Don't double-shift a pointer.
3328
92394119
PE
3329 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3330
dbdb9a7c
JB
33312011-05-06 Juanma Barranquero <lekktu@gmail.com>
3332
3333 * gnutls.c (DEF_GNUTLS_FN):
3334 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3335
db7a0b4f
AS
33362011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3337
3338 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3339 marker. (Bug#8610)
3340
f7ff1b0f 33412011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
3342
3343 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3344 New version that can reserve upto 2GB of heap space.
3345
f7ff1b0f 33462011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
3347
3348 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3349
639c109b
TZ
33502011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3351
3352 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3353 `gnutls_certificate_set_x509_key_file'.
3354
d2127135
JB
33552011-05-05 Juanma Barranquero <lekktu@gmail.com>
3356
3357 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3358 Update dependencies.
3359
e968f4f3
JB
33602011-05-04 Juanma Barranquero <lekktu@gmail.com>
3361
3362 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3363 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3364 Remove unused parameter `fildes'.
3365 * process.c (read_process_output, send_process): Don't pass it.
3366
84d358f0
JB
33672011-05-04 Juanma Barranquero <lekktu@gmail.com>
3368
3369 Fix previous change: the library cache is defined in w32.c.
3370 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3371 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3372
0898ca10
JB
33732011-05-04 Juanma Barranquero <lekktu@gmail.com>
3374
3375 Implement dynamic loading of GnuTLS on Windows.
3376
3377 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3378 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3379 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3380 Declare.
3381
3382 * gnutls.c (Qgnutls_dll): Define.
3383 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3384 (gnutls_*): Declare function pointers.
3385 (init_gnutls_functions): New function to initialize function pointers.
3386 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3387 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3388 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3389 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3390 (emacs_gnutls_write, emacs_gnutls_read)
3391 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3392 (Fgnutls_available_p): New function.
3393 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3394 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3395 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3396
3397 * image.c: Include w32.h.
3398 (Vimage_type_cache): Delete.
3399 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3400 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3401 (w32_delayed_load): Move to w32.c.
3402
3403 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3404
3405 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3406 (w32_delayed_load): Move from image.c. When loading a library, record
3407 its filename in the :loaded-from property of the library id.
3408 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3409 Initialize and staticpro them.
3410 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3411
3412 * process.c: Include lisp.h before w32.h, not after.
3413 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3414 instead of gnutls_record_check_pending.
3415
3416 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3417
ff4de4aa
TZ
34182011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3419
3420 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3421 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3422 as passed in.
3423
abe95abb
JD
34242011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3425
3426 * xterm.c (x_set_frame_alpha): Do not set property on anything
3427 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3428
e16e55d4
JB
34292011-05-02 Juanma Barranquero <lekktu@gmail.com>
3430
3431 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3432
bafcf6a5
JB
34332011-05-02 Juanma Barranquero <lekktu@gmail.com>
3434
3435 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3436 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3437 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3438 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3439 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3440 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3441 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3442 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3443 (Qgnutls_bootprop_callbacks_verify): Make static.
3444
e7a6747f
AS
34452011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3446
19ed11ba
AS
3447 * callproc.c: Indentation fixup.
3448
e7a6747f 3449 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
3450 (wait_for_termination, interruptible_wait_for_termination):
3451 Move after wait_for_termination_1.
e7a6747f 3452
1ef14cb4
LMI
34532011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3454
3455 * sysdep.c (interruptible_wait_for_termination): New function
3456 which is like wait_for_termination, but allows keyboard
3457 interruptions.
3458
3459 * callproc.c (Fcall_process): Add (:file "file") as an option for
3460 the STDOUT buffer.
3461 (Fcall_process_region): Ditto.
3462
330d880c
EZ
34632011-04-30 Eli Zaretskii <eliz@gnu.org>
3464
8db90b73
EZ
3465 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3466 rather than `XVECTOR (FOO)->size'.
3467
330d880c
EZ
3468 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3469 inttypes.h, as a gnulib replacement is used if it not available in
3470 system headers.
3471
15cbd324
EZ
34722011-04-21 Eli Zaretskii <eliz@gnu.org>
3473
3474 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3475 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3476 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3477
3478 * coding.c (coding_alloc_by_realloc): Error out if destination
3479 will grow beyond MOST_POSITIVE_FIXNUM.
3480 (decode_coding_emacs_mule): Abort if there isn't enough place in
3481 charbuf for the composition carryover bytes. Reserve an extra
3482 space for up to 2 characters produced in a loop.
3483 (decode_coding_iso_2022): Abort if there isn't enough place in
3484 charbuf for the composition carryover bytes.
3485
34862011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 3487
ae940cca
EZ
3488 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3489 aborting when %lld or %lll format is passed.
3490 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3491 %llo or %llx format is passed. (Bug#8545)
3492
03ab8921
EZ
3493 * window.c (window_scroll_line_based): Use a marker instead of
3494 simple variables to record original value of point. (Bug#7952)
3495
afda1437
EZ
3496 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3497 produced by %s or %c overflows available buffer space. (Bug#8545)
3498
f76dee0c
PE
34992011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3500
3501 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 3502 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 3503
fdc5744d
JB
35042011-04-28 Juanma Barranquero <lekktu@gmail.com>
3505
3506 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3507
638f053a
JB
35082011-04-28 Juanma Barranquero <lekktu@gmail.com>
3509
3510 * keyboard.c (Qdelayed_warnings_hook): Define.
3511 (command_loop_1): Run `delayed-warnings-hook'
3512 if Vdelayed_warnings_list is non-nil.
3513 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3514 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3515
d178f871
EZ
35162011-04-28 Eli Zaretskii <eliz@gnu.org>
3517
3518 * doprnt.c (doprnt): Don't return value smaller than the buffer
3519 size if the message was truncated. (Bug#8545).
3520
b124fd93
JB
35212011-04-28 Juanma Barranquero <lekktu@gmail.com>
3522
3523 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3524 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3525
e810457d
PE
35262011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3527
3528 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3529
ea51cceb
JB
35302011-04-27 Juanma Barranquero <lekktu@gmail.com>
3531
3532 * makefile.w32-in: Update dependencies.
3533
94dcfacf
EZ
35342011-04-27 Eli Zaretskii <eliz@gnu.org>
3535
3536 Improve `doprnt' and its usage. (Bug#8545)
3537 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3538 `format_end'. Remove support for %l as a conversion specifier.
3539 Don't use xrealloc. Improve diagnostics when the %l size modifier
3540 is used. Update the commentary.
3541
3542 * eval.c (verror): Simplify calculation of size_t.
3543
3544 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3545 messages.
3546
f61f41d7
PE
35472011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3548
3549 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3550 change.
3551
96fb4434
PE
35522011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3553
3554 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3555 This makes this file independent of the recent pseudovector change.
3556
671875da 35572011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 3558
69e9b5a3
PE
3559 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3560
b5f869a7 3561 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 3562 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 3563 Remove unused local.
c8926152 3564 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 3565
841a1577 3566 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
3567 GCC 4.6.0 optimizes based on type-based alias analysis.
3568 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
3569 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3570 != &v->size, and therefore "v->size = 1; b->size = 2; return
3571 v->size;" must therefore return 1. This assumption is incorrect
3572 for Emacs, since it type-puns struct Lisp_Vector * with many other
3573 types. To fix this problem, this patch adds a new type struct
f904488f 3574 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
3575 and pseudovectors, and helps optimizing compilers not get fooled
3576 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3577 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
3578 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3579 the size member.
eab3844f
PE
3580 (XSETPVECTYPE): Rewrite in terms of new macro.
3581 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3582 This is a bit clearer, and further avoids the possibility of
3583 undesirable aliasing.
3584 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 3585 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
3586 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3587 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
3588 (ASIZE): Now uses header.size rather than size.
3589 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
3590 to avoid the hassle of writing XVECTOR (foo)->header.size.
3591 (struct vectorlike_header): New type.
eab3844f
PE
3592 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3593 object, to help avoid aliasing.
3594 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3595 (SUBRP): Likewise, since Lisp_Subr is a special case.
3596 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3597 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3598 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 3599 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
3600 changed to be "header.size" and "header.next".
3601 * buffer.h (struct buffer): Likewise.
3602 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3603 * frame.h (struct frame): Likewise.
3604 * process.h (struct Lisp_Process): Likewise.
3605 * termhooks.h (struct terminal): Likewise.
3606 * window.c (struct save_window_data, struct saved_window): Likewise.
3607 * window.h (struct window): Likewise.
3608 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3609 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3610 * buffer.c (init_buffer_once): Likewise.
3611 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3612 special case.
3613 * process.c (Fformat_network_address): Use local var for size,
3614 for brevity.
3615
0df1eac5
PE
3616 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3617
847ab9d1 3618 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
3619 * data.c (atof): Remove decl; no longer used or needed.
3620 (digit_to_number): Move to lread.c.
3621 (Fstring_to_number): Use new string_to_number function, to be
3622 consistent with how the Lisp reader treats infinities and NaNs.
3623 Do not assume that floating-point numbers represent EMACS_INT
3624 without losing information; this is not true on most 64-bit hosts.
3625 Avoid double-rounding errors, by insisting on integers when
3626 parsing non-base-10 numbers, as the documentation specifies.
3627 * lisp.h (string_to_number): New decl, replacing ...
3628 (isfloat_string): Remove.
bc0a5c13 3629 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 3630 (read1): Do not accept +. and -. as integers; this
452f4150
PE
3631 appears to have been a coding error. Similarly, do not accept
3632 strings like +-1e0 as floating point numbers. Do not report
3633 overflow for integer overflows unless the base is not 10 which
3634 means we have no simple and reliable way to continue.
3635 Break out the floating-point parsing into a new
3636 function string_to_number, so that Fstring_to_number parses
3637 floating point numbers consistently with the Lisp reader.
04f2d78b 3638 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
3639 (E_CHAR, EXP_INT): Remove, replacing with ...
3640 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3641 (string_to_number): New function, replacing isfloat_string.
3642 This function checks for valid syntax and produces the resulting
3643 Lisp float number too. Rework it so that string-to-number
bc0a5c13 3644 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
3645 so that overflow for non-base-10 numbers is reported only when
3646 there's no portable and simple way to convert to floating point.
452f4150 3647
67769ffc
PE
3648 * textprop.c (set_text_properties_1): Rewrite for clarity,
3649 and to avoid GCC warning about integer overflow.
3650
c20db43f
PE
3651 * intervals.h (struct interval): Use EMACS_INT for members
3652 where EMACS_UINT might cause problems. See
3653 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3654 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3655 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3656 All uses changed.
37aa2f85
PE
3657 (offset_intervals): Tell GCC not to worry about length overflow
3658 when negating a negative length.
c20db43f 3659
2538aa2f
PE
3660 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3661 (overrun_check_free): Likewise.
3662
f2d3008d
PE
3663 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3664 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3665 word size.
3666
ec8df744
PE
3667 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3668 (gnutls_make_error): Rename local to avoid shadowing.
3669 (gnutls_emacs_global_deinit): ifdef out; not used.
3670 (Fgnutls_boot): Use const for pointer to readonly storage.
3671 Comment out unused local. Fix pointer signedness problems.
3672
640ee02d
PE
3673 * lread.c (openp): Don't stuff size_t into an 'int'.
3674 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3675 about possible signed overflow.
3676
6048fb2a
PE
3677 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3678 (GDK_KEY_g): Don't define if already defined.
3679 (xg_prepare_tooltip): Avoid pointer signedness problem.
3680 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3681
fa3c87e1
PE
3682 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3683 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3684
2172544b
PE
3685 * xfns.c (Fx_window_property): Simplify a bit,
3686 to make a bit faster and to avoid GCC 4.6.0 warning.
3687 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3688
9b821a21
PE
3689 * fns.c (internal_equal): Don't assume size_t fits in int.
3690
3c616cfa
PE
3691 * alloc.c (compact_small_strings): Tighten assertion a little.
3692
c2982e87
PE
3693 Replace pEd with more-general pI, and fix some printf arg casts.
3694 * lisp.h (pI): New macro, generalizing old pEd macro to other
3695 conversion specifiers. For example, use "...%"pI"d..." rather
3696 than "...%"pEd"...".
3697 (pEd): Remove. All uses replaced with similar uses of pI.
3698 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3699 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3700 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3701 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3702 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3703 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3704 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3705 64-bit hosts.
3706 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3707 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3708 * print.c (safe_debug_print, print_object): Likewise.
3709 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3710 to int.
6f04d126
PE
3711 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3712 avoiding the 0 flag, which is not portable.
c2982e87
PE
3713 * process.c (Fmake_network_process): Use pI to avoid cast.
3714 * region-cache.c (pp_cache): Likewise.
3715 * xdisp.c (decode_mode_spec): Likewise.
3716 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3717 behavior on 64-bit hosts with printf arg.
6f04d126 3718 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
3719 (x_stop_queuing_selection_requests): Likewise.
3720 (x_get_window_property): Don't truncate byte count to an 'int'
3721 when tracing.
0b432f21 3722
5e073ec7
PE
3723 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3724 here, since it parses constructs like leading '-' and spaces,
3725 which are not wanted; and it overflows with large numbers.
3726 Instead, simply match F[0-9]+, which is what is wanted anyway.
3727
36372bf9
PE
3728 * alloc.c: Remove unportable assumptions about struct layout.
3729 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3730 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3731 (allocate_vectorlike, make_pure_vector): Use the new macros,
3732 plus offsetof, to remove unportable assumptions about struct layout.
3733 These assumptions hold on all porting targets that I know of, but
3734 they are not guaranteed, they're easy to remove, and removing them
3735 makes further changes easier.
3736
0b432f21
PE
3737 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3738 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
3739 (string_overrun_cookie): Now const. Use initializers that
3740 don't formally overflow signed char, to avoid warnings.
000098c1
PE
3741 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3742 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
3743 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3744 multiple of sizeof (EMACS_INT); it need not be, if
3745 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 3746 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 3747
895009e1
JB
37482011-04-26 Juanma Barranquero <lekktu@gmail.com>
3749
3750 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3751
6a7a1b0b
TZ
37522011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3753
3754 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 3755 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
3756 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3757
841a1577 37582011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
3759
3760 * lisp.h (Qdebug): List symbol.
895009e1 3761 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
3762 * keyboard.c (debug-on-event): New variable.
3763 (handle_user_signal): Break into debugger when debug-on-event
3764 matches the current signal symbol.
3765
f2d3ba6f
DN
37662011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3767
3768 * alloc.c (check_sblock, check_string_bytes)
3769 (check_string_free_list): Convert to standard C.
3770
42ce4c63
TZ
37712011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3772
3773 * w32.c (emacs_gnutls_push): Fix typo.
3774
825cd63c
EZ
37752011-04-25 Eli Zaretskii <eliz@gnu.org>
3776
fb11d64d
EZ
3777 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3778 "cast to pointer from integer of different size".
3779
825cd63c
EZ
3780 Improve doprnt and its use in verror. (Bug#8545)
3781 * doprnt.c (doprnt): Document the set of format control sequences
3782 supported by the function. Use SAFE_ALLOCA instead of always
3783 using `alloca'.
3784
3785 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3786 is one byte too soon. Don't use xrealloc; instead xfree and
3787 xmalloc anew.
3788
e061a11b
TZ
37892011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3790
3791 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3792 callbacks stage.
3793
3794 * gnutls.c: Renamed global_initialized to
3795 gnutls_global_initialized. Added internals for the
3796 :verify-hostname-error, :verify-error, and :verify-flags
3797 parameters of `gnutls-boot' and documented those parameters in the
3798 docstring. Start callback support.
9173deec
JB
3799 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3800 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3801 on error. Return error code.
e061a11b
TZ
3802 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3803 (emacs_gnutls_read): Likewise.
3804 (Fgnutls_boot): Return handshake error code.
3805 (emacs_gnutls_handle_error): New function.
3806 (wsaerror_to_errno): Likewise.
3807
3808 * w32.h (emacs_gnutls_pull): Add prototype.
3809 (emacs_gnutls_push): Likewise.
3810
3811 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3812 (emacs_gnutls_push): Likewise.
3813
38142011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3815
3816 * process.c (wait_reading_process_output): Check if GnuTLS
3817 buffered some data internally if no FDs are set for TLS
3818 connections.
3819
3820 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3821 (LIBS): Link to USER_LIBS.
3822 ($(BLD)/gnutls.$(0)): New target.
3823
fa6996bc
EZ
38242011-04-24 Eli Zaretskii <eliz@gnu.org>
3825
eb35682e
EZ
3826 * xdisp.c (handle_single_display_spec): Rename the
3827 display_replaced_before_p argument into display_replaced_p, to
3828 make it consistent with the commentary. Fix typos in the
3829 commentary.
3830
e2ad650c
EZ
3831 * textprop.c (syms_of_textprop): Remove dead code.
3832 (copy_text_properties): Delete obsolete commentary about an
3833 interface that was deleted long ago. Fix typos in the description
3834 of arguments.
3835
1b2de274
EZ
3836 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3837 to changes in oldXMenu/XMenu.h from 2011-04-16.
3838 <menu_help_message, prev_menu_help_message>: Constify.
3839 (IT_menu_make_room): menu->help_text is now `const char **';
3840 adjust.
3841
3842 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3843 to changes in oldXMenu/XMenu.h from 2011-04-16.
3844 (struct XMenu): Declare `help_text' `const char **'.
3845
3846 * xfaces.c <Qunspecified>: Make extern again.
3847
3848 * syntax.c: Include sys/types.h before including regex.h, as
3849 required by Posix.
3850
762b15be
EZ
3851 * doc.c (get_doc_string): Improve the format passed to `error'.
3852
3853 * doprnt.c (doprnt): Improve commentary.
3854
3855 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3856
3857 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3858 them with etags.
3859
f1052e5d
EZ
3860 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3861 changes in globals.h immediately force recompilation.
762b15be
EZ
3862 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3863 $(CURDIR)/s/ms-w32.h.
3864 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 3865
fa6996bc
EZ
3866 * character.c (Fchar_direction): Function deleted.
3867 (syms_of_character): Don't defsubr it.
3868 <char-direction-table>: Deleted.
3869
e6c3da20
EZ
38702011-04-23 Eli Zaretskii <eliz@gnu.org>
3871
3872 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3873 * doprnt.c: Include limits.h.
3874 (SIZE_MAX): New macro.
04f2d78b
CB
3875 (doprnt): Return a size_t value. 2nd arg is now size_t.
3876 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
3877 Improve overflow protection. Support `l' modifier for integer
3878 conversions. Support %l conversion. Don't assume an EMACS_INT
3879 argument for integer conversions and for %c.
3880
3881 * lisp.h (doprnt): Restore prototype.
3882
3883 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3884 $(SRC)/character.h.
3885
3886 * Makefile.in (base_obj): Add back doprnt.o.
3887
3888 * deps.mk (doprnt.o): Add back prerequisites.
3889 (callint.o): Depend on character.h.
3890
3891 * eval.c (internal_lisp_condition_case): Include the handler
3892 representation in the error message.
3893 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3894 when breaking from the loop.
3895
3896 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3897
3898 * callint.c (Fcall_interactively): When displaying error message
3899 about invalid control letter, pass the character's codepoint, not
3900 a pointer to its multibyte form. Improve display of the character
3901 in octal and display also its hex code.
3902
3903 * character.c (char_string): Use %x to display the (unsigned)
3904 codepoint of an invalid character, to avoid displaying a bogus
3905 negative value.
3906
3907 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3908 `error', not SYMBOL_NAME itself.
3909
3910 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3911 character arguments to `error'.
3912
3913 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3914 to `error' in error message about FINAL_CHAR argument. Make sure
3915 FINAL_CHAR is a character, and use %c when it is passed as
3916 argument to `error'.
3917
4ffd0d6b 39182011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
3919
3920 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3921
3922 * w32.c: Include <time.h>.
3923 (sys_localtime): New function.
3924
4ffd0d6b 39252011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
3926
3927 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
3928
4ffd0d6b 3929 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 3930
4ffd0d6b 39312011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 3932
4ffd0d6b
GM
3933 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
3934 zombies (Bug#8467).
aac0c6e3 3935
04c56954
EZ
39362011-04-19 Eli Zaretskii <eliz@gnu.org>
3937
3938 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
3939 gl_state.e_property when gl_state.object is Qt.
3940
3941 * insdel.c (make_gap_larger): Remove limitation of buffer size
3942 to <= INT_MAX.
3943
16a43933
CY
39442011-04-18 Chong Yidong <cyd@stupidchicken.com>
3945
3946 * xdisp.c (lookup_glyphless_char_display)
3947 (produce_glyphless_glyph): Handle cons cell entry in
3948 glyphless-char-display.
3949 (Vglyphless_char_display): Document it.
3950
3951 * term.c (produce_glyphless_glyph): Handle cons cell entry in
3952 glyphless-char-display.
3953
4581706e
CY
39542011-04-17 Chong Yidong <cyd@stupidchicken.com>
3955
3956 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
3957
3958 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
3959
3960 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
3961 definition for no-X builds.
3962
4887c6e2 39632011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 3964
fd35b6f9
PE
3965 Static checks with GCC 4.6.0 and non-default toolkits.
3966
5c1ccb01
PE
3967 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
3968
006c5daa
PE
3969 * process.c (keyboard_bit_set): Define only if SIGIO.
3970 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
3971 (send_process): Repair possible setjmp clobbering.
3972
efc736d3
PE
3973 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
3974
4e2fe2e6
PE
3975 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
3976
f97334a2
PE
3977 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
3978
4e75f29d
PE
3979 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
3980 Define only if needed.
3981
90efadd1
PE
3982 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
3983 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 3984 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 3985
3c647824
PE
3986 * dispextern.h (struct redisplay_interface): Rename param
3987 to avoid shadowing.
e264f262 3988 * termhooks.h (struct terminal): Likewise.
761383f4 3989 * xterm.c (xembed_send_message): Likewise.
3c647824 3990
b58c5c4a
PE
3991 * insdel.c (make_gap_smaller): Define only if
3992 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
3993
cad59032
PE
3994 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
3995 it.
3996
c339dc2e
PE
3997 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
3998 so that we aren't warned about unused symbols.
3999
91a3e27b
PE
4000 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4001
399c71d3 4002 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 4003
8ffc96f5
PE
4004 * xfns.c (x_real_positions): Mark locals as initialized.
4005
eef9bc79
PE
4006 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4007
098db9dd
PE
4008 * xterm.c: Fix problems found by static analysis with other toolkits.
4009 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
4010 (x_dispatch_event): Declare static if USE_GTK, and
4011 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 4012 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 4013 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
4014 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4015 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 4016
eb18f6cc
PE
4017 * xmenu.c (menu_help_callback): Pointer type fixes.
4018 Use const pointers when pointing at readonly data. Avoid pointer
4019 signedness clashes.
4020 (FALSE): Remove unused macro.
4021 (update_frame_menubar): Remove unused decl.
4022
1fe72bf8
PE
4023 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4024
60d9e1db
PE
4025 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4026 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4027 (single_menu_item): Rename local to avoid shadowing.
4028
39261c26
PE
4029 * keyboard.c (make_lispy_event): Remove unused local var.
4030
018c5e19
PE
4031 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4032 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4033
63d2b86e
PE
4034 * bitmaps: Change bitmaps from unsigned char back to the X11
4035 compatible char. Avoid the old compiler warnings about
4036 out-of-range initializers by using, for example, '\xab' rather
4037 than 0xab.
4038
aefd87e1
PE
4039 * xgselect.c (xgselect_initialize): Check vs interface
4040 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4041
bf501fb9
PE
4042 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4043
e9829fdf
PE
4044 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4045 to read-only memory.
4046
1086c095
PE
4047 * fns.c (vector): Remove; this old hack is no longer needed.
4048
2baccd04 4049 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 4050 Remove unused var.
dde42981 4051 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 4052
72391843 4053 * xrdb.c (x_load_resources): Omit unused local.
3565b346 4054
436c16df 4055 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 4056 (x_window): Rename locals to avoid shadowing.
dc5ddd85 4057 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 4058
92bb796d 4059 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 4060 (x_term_init): Remove local to avoid shadowing.
92bb796d 4061
764430a3 4062 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
4063
4064 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4065 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4066
d1dfb56c
EZ
40672011-04-16 Eli Zaretskii <eliz@gnu.org>
4068
c4354cb4
EZ
4069 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4070
d1dfb56c
EZ
4071 Fix regex.c, syntax.c and friends for buffers > 2GB.
4072 * syntax.h (struct gl_state_s): Declare character position members
4073 EMACS_INT.
4074
4075 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4076
04f2d78b
CB
4077 * textprop.c (verify_interval_modification, interval_of):
4078 Declare arguments EMACS_INT.
d1dfb56c
EZ
4079
4080 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4081 EMACS_INT.
4082
4083 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4084
4085 * indent.c (Fvertical_motion): Local variable it_start is now
4086 EMACS_INT.
4087
4088 * regex.c (re_match, re_match_2, re_match_2_internal)
4089 (bcmp_translate, regcomp, regexec, print_double_string)
4090 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4091 (re_compile_pattern, re_exec): Declare arguments and local
4092 variables `size_t' and `ssize_t' and return values `regoff_t', as
4093 appropriate.
4094 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4095 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4096 <compile_stack_type>: `size' and `avail' are now `size_t'.
4097
4098 * regex.h <regoff_t>: Use ssize_t, not int.
4099 (re_search, re_search_2, re_match, re_match_2): Arguments that
4100 specify buffer/string position and length are now ssize_t and
4101 size_t. Return type is regoff_t.
4102
613052cd
BK
41032011-04-16 Ben Key <bkey76@gmail.com>
4104
4105 * nsfont.m: Fixed bugs in ns_get_family and
4106 ns_descriptor_to_entity that were caused by using free to
4107 deallocate memory blocks that were allocated by xmalloc (via
4108 xstrdup). This caused Emacs to crash when compiled with
4109 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4110 --enable-checking=xmallocoverrun). xfree is now used to
4111 deallocate these memory blocks.
4112
4170f62f 41132011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 4114
71b41406
PE
4115 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4116
9587a89d
PE
4117 emacs_write: Accept and return EMACS_INT for sizes.
4118 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4119 et seq.
4120 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4121 Accept and return EMACS_INT.
4122 (emacs_gnutls_write): Return the number of bytes written on
4123 partial writes.
4124 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
4125 (emacs_read, emacs_write): Remove check for negative size, as the
4126 Emacs source code has been audited now.
9587a89d
PE
4127 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4128 (emacs_read, emacs_write): Use it.
273a5f82
PE
4129 * process.c (send_process): Adjust to the new signatures of
4130 emacs_write and emacs_gnutls_write. Do not attempt to store
4131 a byte offset into an 'int'; it might overflow.
9587a89d 4132 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 4133
3e047f51
PE
4134 * sound.c: Don't assume sizes fit in 'int'.
4135 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 4136 Return EMACS_INT, not int.
3e047f51 4137 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
4138 Accept EMACS_INT, not int.
4139 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
4140 record read return values.
4141
cc39a9db
BK
41422011-04-15 Ben Key <bkey76@gmail.com>
4143
c9d0ec6d
JB
4144 * keyboard.c (Qundefined): Don't declare static since it is used
4145 in nsfns.m.
4146 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4147 static since they are used in nsfont.m.
cc39a9db 4148
6c60eb9f
SM
41492011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4150
4151 * process.c (Qprocessp): Don't declare static.
4152 * lisp.h (Qprocessp): Declare again.
4153
7990b61a
JB
41542011-04-15 Juanma Barranquero <lekktu@gmail.com>
4155
4156 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4157
5d4cb038
PE
41582011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4159
8bd7b830 4160 Improve C-level modularity by making more things 'static'.
cd64ea1d 4161
e3b27b31
PE
4162 Don't publish debugger-only interfaces to other modules.
4163 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4164 (verify_bytepos, count_markers): Move decls to the only modules
4165 that need them.
4166 * region-cache.h (pp_cache): Likewise.
4167 * window.h (check_all_windows): Likewise.
4168 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4169
5d4cb038
PE
4170 * sysdep.c (croak): Now static, if
4171 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4172 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
4173
4174 * alloc.c (refill_memory_reserve): Now static if
4175 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4176 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 4177
e87b6180
PE
4178 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4179 Define only if USE_LUCID.
4180
ac64929e
PE
4181 * xrdb.c (x_customization_string, x_rm_string): Now static.
4182
6f37259d
PE
4183 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4184 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4185
1683e3ab
PE
4186 * xdisp.c (draw_row_with_mouse_face): Now static.
4187 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4188
de9c2632
PE
4189 * window.h (check_all_windows): Mark externally visible.
4190
2b96acb7
PE
4191 * window.c (window_deletion_count): Now static.
4192
4193 * undo.c: Make symbols static if they're not exported.
4194 (last_undo_buffer, last_boundary_position, pending_boundary):
4195 Now static.
4196
50436f33
PE
4197 * textprop.c (interval_insert_behind_hooks): Now static.
4198 (interval_insert_in_front_hooks): Likewise.
4199
64520e5c
PE
4200 * term.c: Make symbols static if they're not exported.
4201 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4202 (max_frame_lines, tty_set_terminal_modes):
4203 (tty_reset_terminal_modes, tty_turn_off_highlight):
4204 (get_tty_terminal): Now static.
4205 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4206 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 4207 HAVE_WINDOW_SYSTEM.
64520e5c
PE
4208 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4209 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4210
1fa53021
PE
4211 * sysdep.c: Make symbols static if they're not exported.
4212 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4213 Now static.
4214 (sigprocmask_set, full_mask): Remove; unused.
4215 (wait_debugging): Mark as visible.
4216 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4217 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4218
d4b43b22
PE
4219 * syntax.c (syntax_temp): Define only if !__GNUC__.
4220
b7c513d0
PE
4221 * sound.c (current_sound_device, current_sound): Now static.
4222
989b29ad
PE
4223 * search.c (searchbufs, searchbuf_head): Now static.
4224
13a55a78
PE
4225 * scroll.c (scroll_cost): Remove; unused.
4226 * dispextern.h (scroll_cost): Remove decl.
4227
de68a1fc
PE
4228 * region-cache.h (pp_cache): Mark as externally visible.
4229
40ccffa6
PE
4230 * process.c: Make symbols static if they're not exported.
4231 (process_tick, update_tick, create_process, chan_process):
4232 (Vprocess_alist, proc_buffered_char, datagram_access):
4233 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4234 (deactivate_process): Mark defn as static, as well as decl.
4235 * lisp.h (create_process): Remove decl.
4236 * process.h (chan_process, Vprocess_alist): Remove decls.
4237
ad64fc97
PE
4238 * print.c: Make symbols static if they're not exported.
4239 (print_depth, new_backquote_output, being_printed, print_buffer):
4240 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4241 (print_interval, print_number_index, initial_stderr_stream):
4242 Now static.
4243 * lisp.h (Fprinc): Remove decl.
4244 (debug_output_compilation_hack): Mark as externally visible.
4245
adddb265
PE
4246 * sysdep.c (croak): Move decl from here to syssignal.h.
4247 * syssignal.h (croak): Put it here, so the API can be checked when
4248 'croak' is called from dissociate_if_controlling_tty.
4249
1717ede2
PE
4250 * minibuf.c: Make symbols static if they're not exported.
4251 (minibuf_save_list, choose_minibuf_frame): Now static.
4252 * lisp.h (choose_minibuf_frame): Remove decl.
4253
fa5fb2bc
PE
4254 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4255
1e3890d1
PE
4256 * lread.c: Make symbols static if they're not exported.
4257 (read_objects, initial_obarray, oblookup_last_bucket_number):
4258 Now static.
4259 (make_symbol): Remove; unused.
4260 * lisp.h (initial_obarray, make_symbol): Remove decls.
4261
8a1414fa
PE
4262 * keyboard.c: Make symbols static if they're not exported.
4263 (single_kboard, recent_keys_index, total_keys, recent_keys):
4264 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4265 (this_single_command_key_start, echoing, last_auto_save):
4266 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4267 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4268 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4269 (Vlispy_mouse_stem, double_click_count):
4270 Now static.
4271 (force_auto_save_soon): Define only if SIGDANGER.
4272 (ignore_mouse_drag_p): Now static if
4273 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4274 (print_help): Remove; unused.
4275 (stop_character, last_timer_event): Mark as externally visible.
4276 * keyboard.h (ignore_mouse_drag_p): Declare only if
4277 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4278 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4279 * lisp.h (echoing): Remove decl.
4280 (force_auto_save_soon): Declare only if SIGDANGER.
4281 * xdisp.c (redisplay_window): Simplify code, to make it more
4282 obvious that ignore_mouse_drag_p is not accessed if !defined
4283 USE_GTK && !defined HAVE_NS.
4284
93ea6e8f
PE
4285 * intervals.c: Make symbols static if they're not exported.
4286 (merge_properties_sticky, merge_interval_right, delete_interval):
4287 Now static.
4288 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4289
77382fcc
PE
4290 * insdel.c: Make symbols static if they're not exported.
4291 However, leave prepare_to_modify_buffer alone. It's never
4292 called from outside this function, but that appears to be a bug.
4293 (combine_after_change_list, combine_after_change_buffer):
4889fc82 4294 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
4295 (adjust_after_replace_noundo): Remove; unused.
4296 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 4297 (signal_before_change): Remove decls.
77382fcc 4298
9306c32e
PE
4299 * indent.c (val_compute_motion, val_vmotion): Now static.
4300
cd44d2eb
PE
4301 * image.c: Make symbols static if they're not exported.
4302 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4303 if USE_GTK.
4304 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4305 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4306
ad9a7a06
PE
4307 * fringe.c (standard_bitmaps): Now static.
4308 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4309
81626931
PE
4310 * frame.c: Make symbols static if they're not exported.
4311 (x_report_frame_params, make_terminal_frame): Now static.
4312 (get_frame_param): Now static, unless HAVE_NS.
4313 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4314 (x_get_resource_string): Remove; not used.
4315 * frame.h (make_terminal_frame, x_report_frame_params):
4316 (x_get_resource_string); Remove decls.
4317 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4318 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4319
239f9db9
PE
4320 * font.c, fontset.c: Make symbols static if they're not exported.
4321 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4322 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4323 * font.c (font_close_object): Now static.
4324 * font.h (font_close_object): Remove.
4325 * fontset.c (FONTSET_OBJLIST): Remove.
4326 (free_realized_fontset) #if-0 the body, which does nothing.
4327 (face_suitable_for_char_p): #if-0, as it's never called.
4328 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
4329 * xfaces.c (face_at_string_position):
4330 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
4331 since 0 is always ASCII.
4332
dfcf3579
PE
4333 * fns.c (weak_hash_tables): Now static.
4334
5045092b
PE
4335 * fileio.c: Make symbols static if they're not exported.
4336 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4337 (Vwrite_region_annotation_buffers): Now static.
4338
57a96f5c
PE
4339 * eval.c: Make symbols static if they're not exported.
4340 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4341 * lisp.h (backtrace_list): Remove decl.
4342
35f08c38
PE
4343 * emacs.c: Make symbols static if they're not exported.
4344 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4345 (fatal_error_code, fatal_error_signal_hook, standard_args):
4346 Now static.
4347 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4348 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4349 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4350 * lisp.h (fatal_error_signal_hook): Remove decl.
4351 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4352
f44bd759
PE
4353 * editfns.c: Move a (normally-unused) function to its only use.
4354 * editfns.c, lisp.h (get_operating_system_release): Remove.
4355 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4356 worth the hassle of breaking this out.
4357
b532497d
PE
4358 * xterm.c: Make symbols static if they're not exported.
4359 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4360 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4361 (x_destroy_window, x_delete_display):
4362 Now static.
4363 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4364 (x_mouse_leave): Remove; unused.
4365 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4366 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4367 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4368 Remove decls.
4369 (x_mouse_leave): Declare only if WINDOWSNT.
4370 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4371 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4372 USE_X_TOOLKIT.
4373
1675728f
PE
4374 * ftxfont.c: Make symbols static if they're not exported.
4375 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4376 HAVE_FREETYPE.
4377 * font.h (ftxfont_driver): Likewise.
4378
e4cebfca
PE
4379 * xfns.c: Make symbols static if they're not exported.
4380 (x_last_font_name, x_display_info_for_name):
4381 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4382 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4383 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4384 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4385 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4386 (last_show_tip_args): Now static.
4387 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4388 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4389 (x_screen_planes): Remove; unused.
4390 * dispextern.h (x_screen_planes): Remove decl.
4391
5bf46f05
PE
4392 * dispnew.c: Make symbols static if they're not exported.
4393 * dispextern.h (redraw_garbaged_frames, scrolling):
4394 (increment_row_positions): Remove.
4395 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4396 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4397 Now static.
4398 (redraw_garbaged_frames): Remove; unused.
4399
435f4c28
PE
4400 * xfaces.c: Make symbols static if they're not exported.
4401 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4402 Remove decls.
4403 * xterm.h (defined_color): Remove decls.
4404 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4405 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4406 (menu_face_changed_default, defined_color, free_realized_face):
4407 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4408 (ascii_face_of_lisp_face): Remove; unused.
4409
8524aef3
PE
4410 * xdisp.c: Make symbols static if they're not exported.
4411 * dispextern.h (scratch_glyph_row, window_box_edges):
4412 (glyph_to_pixel_coords, set_cursor_from_row):
4413 (get_next_display_element, set_iterator_to_next):
4414 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4415 (show_mouse_face): Remove decls
4416 * frame.h (message_buf_print): Likewise.
4417 * lisp.h (pop_message, set_message, check_point_in_composition):
4418 Likewise.
4419 * xterm.h (set_vertical_scroll_bar): Likewise.
4420 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4421 (message_buf_print, scratch_glyph_row, displayed_buffer):
4422 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4423 (get_next_display_element, show_mouse_face, window_box_edges):
4424 (frame_to_window_pixel_xy, check_point_in_composition):
4425 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4426 (glyph_to_pixel_coords): Remove; unused.
4427
16390cd2
PE
4428 * dired.c (file_name_completion): Now static.
4429
4430 * dbusbind.c (xd_in_read_queued_messages): Now static.
4431
a25f4dfa
PE
4432 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4433 * data.c (circular_list_error): Remove.
4434
14a9c8df
PE
4435 * commands.h (last_point_position, last_point_position_buffer):
4436 (last_point_position_window): Remove decls.
4437 * keyboard.c: Make these variables static.
4438
04f2d78b
CB
4439 * coding.h (coding, code_convert_region, encode_coding_gap):
4440 Remove decls.
74ab6df5
PE
4441 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4442 (iso_code_class, detect_coding, code_convert_region): Now static.
4443 (encode_coding_gap): Remove; unused.
4444
38dfbee1
PE
4445 * chartab.c (chartab_chars, chartab_bits): Now static.
4446
a2cb4e63
PE
4447 * charset.h (charset_iso_8859_1): Remove decl.
4448 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4449 Now static.
4450
127198fd
PE
4451 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4452 * ccl.c (Vccl_program_table): Now static.
4453 (check_ccl_update): Remove; unused.
4454
d85b608f
PE
4455 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4456 * category.h: ... from here.
4457 * category.c (check_category_table, set_category_set): Now static.
4458
31cd66f3
PE
4459 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4460 * lisp.h: Remove these decls.
4461
c358e587
PE
4462 * buffer.c (buffer_count): Remove unused var.
4463
e78aecca
PE
4464 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4465 so that it's not optimized away.
4466 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4467 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4468 exported only to the debugger.
4469
e192d7d3 4470 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 4471 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 4472
92470028
PE
4473 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4474 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4475 was inaccessible from Lisp.
4476 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4477 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4478
244ed907
PE
4479 alloc.c: Import and export fewer symbols, and remove unused items.
4480 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4481 is defined.
4482 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4483 it's not optimized away by whole-program optimization.
4484 (message_enable_multibyte, free_misc): Remove.
4485 (catchlist, handlerlist, mark_backtrace):
4486 Declare only if BYTE_MARK_STACK.
4487 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4488 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4489 (message_enable_multibyte): Remove decl.
4490 (free_misc, interval_free_list, float_block, float_block_index):
4491 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4492 (cons_free_list, last_marked_index):
4493 Now static.
4494 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4495 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4496 (mark_backtrace): Define only if BYTE_MARK_STACK.
4497 * xdisp.c (message_enable_multibyte): Now static.
4498
61c2b50e 4499 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
4500 This makes it easier for human readers (and static analyzers)
4501 to see whether these variables are used from other modules.
4502 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4503 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4504 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4505 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4506 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4507 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4508 * xmenu.c, xselect.c:
4509 Declare Q* vars static if they are not used in other modules.
4510 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4511 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4512 Remove decls of unexported vars.
4513 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4514
95c82688
PE
4515 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4516
16a97296
PE
4517 Make Emacs functions such as Fatom 'static' by default.
4518 This makes it easier for human readers (and static analyzers)
4519 to see whether these functions can be called from other modules.
4520 DEFUN now defines a static function. To make the function external
4521 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
4522 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4523 (Finit_image_library):
16a97296
PE
4524 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4525 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4526 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4527 Remove decls, since these functions are now static.
4528 (Funintern, Fget_internal_run_time): New decls, since these functions
4529 were already external.
95c82688 4530
16a97296
PE
4531 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4532 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4533 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4534 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4535 * keyboard.c, keymap.c, lread.c:
4536 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4537 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4538 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4539 Mark functions with DEFUE instead of DEFUN,
4540 if they are used in other modules.
4541 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4542 decls for now-static functions.
4543 * buffer.h (Fdelete_overlay): Remove decl.
4544 * callproc.c (Fgetenv_internal): Mark as internal.
4545 * composite.c (Fremove_list_of_text_properties): Remove decl.
4546 (Fcomposition_get_gstring): New forward static decl.
4547 * composite.h (Fcomposite_get_gstring): Remove decl.
4548 * dired.c (Ffile_attributes): New forward static decl.
4549 * doc.c (Fdocumntation_property): New forward static decl.
4550 * eval.c (Ffetch_bytecode): New forward static decl.
4551 (Funintern): Remove extern decl; now in .h file where it belongs.
4552 * fileio.c (Fmake_symbolic_link): New forward static decl.
4553 * image.c (Finit_image_library): New forward static decl.
4554 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4555 * intervals.h (Fprevious_property_change):
4556 (Fremove_list_of_text_properties): Remove decls.
4557 * keyboard.c (Fthis_command_keys): Remove decl.
4558 (Fcommand_execute): New forward static decl.
4559 * keymap.c (Flookup_key): New forward static decl.
4560 (Fcopy_keymap): Now static.
4561 * keymap.h (Flookup_key): Remove decl.
4562 * process.c (Fget_process): New forward static decl.
4563 (Fprocess_datagram_address): Mark as internal.
4564 * syntax.c (Fsyntax_table_p): New forward static decl.
4565 (skip_chars): Remove duplicate decl.
4566 * textprop.c (Fprevious_property_change): New forward static decl.
4567 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4568 Now internal.
4569 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4570 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4571
785bbd42
PE
4572 * editfns.c (Fformat): Remove unreachable code.
4573
8b913b57
AS
45742011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4575
4576 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4577 change. (Bug#8496)
4578
a6744a35
EZ
45792011-04-13 Eli Zaretskii <eliz@gnu.org>
4580
4581 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4582 when at ZV. (Bug#8487)
4583
e7974947
AS
45842011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4585
baad03f0
AS
4586 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4587 (Bug#8437)
4588 * keyboard.c (parse_tool_bar_item): Likewise.
4589 * sound.c (sound_cleanup, alsa_close): Likewise.
4590 * termcap.c (tgetent): Likewise.
4591 * xfns.c (x_default_font_parameter): Likewise.
4592 * xsettings.c (read_and_apply_settings): Likewise.
4593
e7974947
AS
4594 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4595 (overrun_check_free): Protoize.
4596
28272684
PE
45972011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4598
4599 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4600 since callers should never pass a negative size.
4601 Change the signature to match that of plain 'read' and 'write'; see
4602 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4603 * lisp.h: Update prototypes of emacs_write and emacs_read.
4604
11997c76
EZ
46052011-04-11 Eli Zaretskii <eliz@gnu.org>
4606
4607 * xdisp.c (redisplay_window): Don't try to determine the character
4608 position of the scroll margin if the window start point w->startp
e896f03c 4609 is outside the buffer's accessible region. (Bug#8468)
11997c76 4610
8a2cbd72
EZ
46112011-04-10 Eli Zaretskii <eliz@gnu.org>
4612
4613 Fix write-region and its subroutines for buffers > 2GB.
4614 * fileio.c (a_write, e_write): Modify declaration of arguments and
4615 local variables to support buffers larger than 2GB.
4616 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4617
4618 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4619 argument, local variables, and return value.
4620
4621 * lisp.h: Update prototypes of emacs_write and emacs_read.
4622
4623 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4624
4073e537 46252011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 4626
1ebfdcb6
PE
4627 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4628
b2ded58d
PE
4629 Fix more problems found by GCC 4.6.0's static checks.
4630
7d66342c
PE
4631 * xdisp.c (vmessage): Use a better test for character truncation.
4632
bbf47d44
PE
4633 * charset.c (load_charset_map): <, not <=, for optimization,
4634 and to avoid potential problems with integer overflow.
9248994d 4635 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 4636 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 4637 * editfns.c (Fformat): Likewise.
1e69125e 4638 * syntax.c (skip_chars): Likewise.
3befa583 4639
e3019616
PE
4640 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4641 This also lets GCC 4.6.0 generate slightly better loop code.
4642
becfa255
PE
4643 * callint.c (Fcall_interactively): <, not <=, for optimization.
4644 (Fcall_interactively): Count the number of arguments produced,
4645 not the number of arguments given. This is simpler and lets GCC
4646 4.6.0 generate slightly better code.
4647
dae0cd48
PE
4648 * ftfont.c: Distingish more carefully between FcChar8 and char.
4649 The previous code passed unsigned char * to a functions like
4650 strlen and xstrcasecmp that expect char *, which does not
4651 conform to the C standard.
4652 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4653 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4654 char * when the C standard requires it.
4655
76032d70
PE
4656 * keyboard.c (read_char): Remove unused var.
4657
eb3f1cc8
PE
4658 * eval.c: Port to Windows vsnprintf (Bug#8435).
4659 Include <limits.h>.
4660 (SIZE_MAX): Define if the headers do not.
4661 (verror): Do not give up if vsnprintf returns a negative count.
4662 Instead, grow the buffer. This ports to Windows vsnprintf, which
4663 does not conform to C99. Problem reported by Eli Zaretskii.
4664 Also, simplify the allocation scheme, by avoiding the need for
4665 calling realloc, and removing the ALLOCATED variable.
4666
70476b54
PE
4667 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4668
12020a9e
PE
4669 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4670 But keep the doprint source code for now, as we might revamp it
4671 and use it again (Bug#8435).
ea6c7ae6
PE
4672 * lisp.h (doprnt): Remove.
4673 * Makefile.in (base_obj): Remove doprnt.o.
4674 * deps.mk (doprnt.o): Remove.
4675
5fdb398c
PE
4676 error: Print 32- and 64-bit integers portably (Bug#8435).
4677 Without this change, on typical 64-bit hosts error ("...%d...", N)
4678 was used to print both 32- and 64-bit integers N, which relied on
4679 undefined behavior.
4680 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4681 New macro.
4682 * lisp.h (error, verror): Mark as printf-like functions.
4683 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4684 Report overflow in size calculations when allocating printf buffer.
4685 Do not truncate output string at its first null byte.
4686 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4687 Truncate the output at a character boundary, since vsnprintf does not
4688 do that.
4689 * charset.c (check_iso_charset_parameter): Convert internal
4690 character to string before calling 'error', since %c now has the
4691 printf meaning.
4692 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4693 overflow when computing char to be passed to 'error'. Do not
4694 pass Lisp_Object to 'error'; pass the integer instead.
4695 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4696 formatted with plain %d.
4697
b189fa66
PE
4698 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4699
bff87ef0
PE
4700 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4701
7e2cac20
PE
4702 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4703
ce4d90b5
PE
4704 * xterm.c (x_catch_errors): Remove duplicate declaration.
4705
266c9547
PE
4706 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4707
79c49ad2
PE
4708 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4709
368f4090
JM
47102011-04-10 Jim Meyering <meyering@redhat.com>
4711
4712 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4713 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4714 return ssize_t not "int", and use size_t as the buffer length.
4715 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4716 * gnutls.h: Update declarations.
4717 * process.c (read_process_output): Use ssize_t, to match.
4718 (send_process): Likewise.
4719
a32d4040
CY
47202011-04-09 Chong Yidong <cyd@stupidchicken.com>
4721
4722 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4723
8546720e 47242011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 4725
04f2d78b
CB
4726 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4727 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 4728
8546720e
GM
4729 * xterm.c (handle_one_xevent):
4730 * xmenu.c (create_and_show_popup_menu):
4731 * xselect.c (x_decline_selection_request)
4732 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 4733
0a2f5c1a 47342011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
4735
4736 Fix some uses of `int' instead of EMACS_INT.
4737 * search.c (string_match_1, fast_string_match)
4738 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4739 (scan_buffer, find_next_newline_no_quit)
4740 (find_before_next_newline, search_command, Freplace_match)
4741 (Fmatch_data): Make some `int' variables be EMACS_INT.
4742
4743 * xdisp.c (display_count_lines): 3rd argument and return value now
4744 EMACS_INT. All callers changed.
4745 (pint2hrstr): Last argument is now EMACS_INT.
4746
4747 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4748 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4749 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4750 (decode_coding_utf_16, decode_coding_emacs_mule)
4751 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4752 (decode_coding_ccl, decode_coding_charset)
4753 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4754 (decode_coding_iso_2022, decode_coding_emacs_mule)
4755 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4756 <char_offset, last_offset>: Declare EMACS_INT.
4757 (encode_coding_utf_8, encode_coding_utf_16)
4758 (encode_coding_emacs_mule, encode_invocation_designation)
4759 (encode_designation_at_bol, encode_coding_iso_2022)
4760 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4761 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4762 Declare EMACS_INT.
4763 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4764 (encode_invocation_designation): Last argument P_NCHARS is now
4765 EMACS_INT.
4766 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4767 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4768
4769 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4770 All users changed.
4771
4772 * ccl.c (Fccl_execute_on_string): Declare some variables
4773 EMACS_INT.
4774
8546720e 47752011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
4776
4777 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4778
4e19a977
CS
47792011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4780
4781 * process.c (Fformat_network_address): Doc fix.
4782
87302331
R
47832011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4784
4785 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4786
cbb59342
CY
47872011-04-08 Chong Yidong <cyd@stupidchicken.com>
4788
4789 * keyboard.c (read_char): Call Lisp function help-form-show,
4790 instead of using internal_with_output_to_temp_buffer.
4791 (Qhelp_form_show): New var.
e0d38eeb 4792 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
4793
4794 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4795
4796 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4797
e67a13ab
CY
47982011-04-06 Chong Yidong <cyd@stupidchicken.com>
4799
04f2d78b
CB
4800 * process.c (Flist_processes): Remove to Lisp.
4801 (list_processes_1): Delete.
e67a13ab 4802
973f782d
EZ
48032011-04-06 Eli Zaretskii <eliz@gnu.org>
4804
7c106b1e
EZ
4805 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4806
973f782d
EZ
4807 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4808
41cf7d1a 48092011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 4810
ca23cc88
PE
4811 Fix more problems found by GCC 4.6.0's static checks.
4812
f390e2d5
PE
4813 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4814
42eea0d0
PE
4815 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4816
b69769da 4817 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 4818
f9541e84
PE
4819 * xdisp.c (vmessage): Mark as a printf-like function.
4820
13841b55
PE
4821 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4822
c136c10f
PE
4823 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4824
5e2d4a30
PE
4825 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4826 printf-like functions.
4827 (tiff_load): Add casts to remove these marks before passing them
4828 to system-supplied API.
4829
583f48b9
PE
4830 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4831
b25d760e
PE
4832 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4833 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
4834 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4835 directly, rather than having caller test rule sign. This avoids
4836 some unnecessary tests.
4837 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4838 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4839 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 4840
bc7b6697 4841 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 4842 (xfont_open): Avoid unnecessary tests.
bc7b6697 4843
27ccc379
PE
4844 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4845
dcd5c89a
PE
4846 * composite.h, composite.c (composition_gstring_put_cache):
4847 Use EMACS_INT, not int, for length.
4848
b13a45c6
PE
4849 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4850 breaking out part of COMPOSITION_DECODE_RULE.
4851 (COMPOSITION_DECODE_RULE): Use it.
4852 * composite.c (get_composition_id): Remove unused local vars,
4853 by using the new macro.
4854
1e792e4d
PE
4855 * textprop.c (set_text_properties_1): Change while to do-while,
4856 since the condition is always true at first.
4857
dc6c6455 4858 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
4859 (interval_deletion_adjustment): Return unsigned value.
4860 All uses changed.
dc6c6455 4861
aba7731a
PE
4862 * process.c (list_processes_1, create_pty, read_process_output):
4863 (exec_sentinel): Remove vars that were set but not used.
afd4052b 4864 (create_pty): Remove unnecessary "volatile"s.
bc57d757 4865 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 4866 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 4867 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 4868
fdfc4bf3
PE
4869 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4870
fca8fe46 4871 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 4872 (update_syntax_table): Use unsigned instead of int.
fca8fe46 4873
06a0259a 4874 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 4875 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 4876 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 4877
e7b9e80f
PE
4878 * print.c (print_error_message): Avoid int overflow.
4879
56201685
PE
4880 * font.c (font_list_entities): Redo for clarity,
4881 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4882
78834453 4883 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 4884 (font_score): Avoid potential overflow in diff calculation.
78834453 4885
0bc0b309 4886 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 4887 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 4888
e610eaca
PE
4889 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4890
b895abce
PE
4891 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4892 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4893 can always succeed if overflow has undefined behavior.
4894
1f1d9321 4895 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 4896 (wordify): Omit three unnecessary tests.
1f1d9321 4897
c59478bc
PE
4898 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4899 All callers changed. This avoids the need for an unused var.
4900
79b73827
PE
4901 * casefiddle.c (casify_region): Remove var that is set but not used.
4902
a4db5dfe
PE
4903 * dired.c (file_name_completion): Remove var that is set but not used.
4904
43aae36e
PE
4905 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4906
2a47c44d 4907 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 4908 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 4909
a37c69bf
PE
4910 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4911 Check for integer overflow on size calculations.
4912
328ab8e7
PE
4913 * buffer.c (Fprevious_overlay_change): Remove var that is set
4914 but not used.
4915
e5a2a5cb
PE
4916 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4917 Remove vars that are set but not used.
8d84a6eb 4918 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 4919 (timer_check_2): Mark vars as initialized.
e5a2a5cb 4920
a60e5f68
PE
4921 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4922
f661cb61 4923 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 4924 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 4925
f0397f5a
PE
4926 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
4927 that are set but not used.
4928
8664db06 4929 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 4930 if XCreateBitmapFromData fails (Bug#8410).
8664db06 4931
6abdaa4a
PE
4932 * xselect.c (x_get_local_selection, x_handle_property_notify):
4933 Remove vars that are set but not used.
4934
0ce7538d 4935 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 4936 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 4937
9ae848fc
PE
4938 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
4939 Remove var that is set but not used.
0b918413
PE
4940 (scroll_bar_windows_size): Now size_t, not int.
4941 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
4942 Check for overflow.
9ae848fc 4943
a5a62657
PE
4944 * xfaces.c (realize_named_face): Remove vars that are set but not used.
4945 (map_tty_color) [!defined MSDOS]: Likewise.
4946
5c5cdd39
PE
4947 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
4948
66ebf983
PE
4949 * coding.c: Remove vars that are set but not used.
4950 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
4951 All callers changed.
4952 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
4953 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
4954 (decode_coding_charset): Remove vars that are set but not used.
4955
1be4d761
PE
4956 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
4957 that is set but not used.
4958
47553fa8
PE
4959 * print.c (print_object): Remove var that is set but not used.
4960
1f7196bf 4961 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
4962 The gnulib version avoids calling malloc in the usual case,
4963 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
4964 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
4965 * filelock.c (current_lock_owner): Likewise.
4966 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
4967 * sysdep.c: Include allocator.h, careadlinkat.h.
4968 (emacs_no_realloc_allocator): New static constant.
4969 (emacs_readlink): New function.
fdb61804
PE
4970 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
4971 ../lib/careadlinkat.h.
d1fdcab7 4972
f84c17c7
SM
49732011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
4974
4975 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
4976 first non-nil return value).
4977
ef3862ad
JD
49782011-04-03 Jan Djärv <jan.h.d@swipnet.se>
4979
4980 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
4981 if not defined (Bug#8403).
4982
376a7006
JB
49832011-04-02 Juanma Barranquero <lekktu@gmail.com>
4984
4985 * xdisp.c (display_count_lines): Remove parameter `start',
4986 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4987 (get_char_face_and_encoding): Remove parameter `multibyte_p',
4988 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4989 (fill_stretch_glyph_string): Remove parameters `row' and `area',
4990 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
4991 and thereabouts. All callers changed.
4992 (get_per_char_metric): Remove parameter `f', unused since
4993 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4994
6ca3801d
JM
49952011-04-02 Jim Meyering <meyering@redhat.com>
4996
4997 do not dereference NULL upon failed strdup
4998 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
4999 (ns_get_family): Likewise.
5000
d8e2b5ba
JB
50012011-04-02 Juanma Barranquero <lekktu@gmail.com>
5002
5003 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5004
8c74fcbd
JD
50052011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5006
5007 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5008 later (Bug#8403).
5009
7200d79c
SM
50102011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5011
03408648 5012 Add lexical binding.
7200d79c 5013
03408648
SM
5014 * window.c (Ftemp_output_buffer_show): New fun.
5015 (Fsave_window_excursion):
5016 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5017
5018 * lread.c (lisp_file_lexically_bound_p): New function.
5019 (Fload): Bind Qlexical_binding.
5020 (readevalloop): Remove `evalfun' arg.
5021 Bind Qinternal_interpreter_environment.
5022 (Feval_buffer): Bind Qlexical_binding.
5023 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5024 Mark as dynamic.
5025 (syms_of_lread): Declare `lexical-binding'.
5026
5027 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5028
5029 * keyboard.c (eval_dyn): New fun.
5030 (menu_item_eval_property): Use it.
ca105506
SM
5031
5032 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 5033
03408648
SM
5034 * fns.c (concat, mapcar1): Accept byte-code-functions.
5035
5036 * eval.c (Fsetq): Handle lexical vars.
5037 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5038 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5039 (FletX, Flet): Obey lexical binding.
5040 (Fcommandp): Handle closures.
5041 (Feval): New `lexical' arg.
5042 (eval_sub): New function extracted from Feval. Use it almost
5043 everywhere where Feval was used. Look up vars in lexical env.
5044 Handle closures.
5045 (Ffunctionp): Move from subr.el.
5046 (Ffuncall): Handle closures.
5047 (apply_lambda): Remove `eval_flags'.
5048 (funcall_lambda): Handle closures and new byte-code-functions.
5049 (Fspecial_variable_p): New function.
5050 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5051 but without exporting it to Lisp.
23aba0ea 5052
23aba0ea 5053 * doc.c (Fdocumentation, store_function_docstring):
03408648 5054 * data.c (Finteractive_form): Handle closures.
23aba0ea 5055
03408648
SM
5056 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5057 interactive spec.
ba83908c 5058
04f2d78b
CB
5059 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5060 New byte-codes.
03408648
SM
5061 (exec_byte_code): New function extracted from Fbyte_code to handle new
5062 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 5063
03408648 5064 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 5065
03408648 5066 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 5067
e2abce01
JB
50682011-03-31 Juanma Barranquero <lekktu@gmail.com>
5069
5070 * xdisp.c (redisplay_internal): Fix prototype.
5071
63696a73 50722011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 5073
63696a73 5074 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
5075 (try_scrolling): Use it when setting scroll_limit.
5076 Limit scrolling to 100 screen lines.
63696a73
EZ
5077 (redisplay_window): Even when falling back on "recentering",
5078 position point in the window according to scroll-conservatively,
5079 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5080
5081 (try_scrolling): When point is above the window, allow searching
5082 as far as scroll_max, or one screenful, to compute vertical
5083 distance from PT to the scroll margin position. This prevents
5084 try_scrolling from unnecessarily failing when
5085 scroll-conservatively is set to a value slightly larger than the
5086 window height. Clean up the case of PT below the margin at bottom
5087 of window: scroll_max can no longer be INT_MAX. When aggressive
5088 scrolling is in use, don't let point enter the opposite scroll
5089 margin as result of the scroll.
5090 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
5091 threshold of 100 lines for never-recentering scrolling.
5092
e4cc2dfc
JB
50932011-03-31 Juanma Barranquero <lekktu@gmail.com>
5094
5095 * dispextern.h (move_it_by_lines):
5096 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5097 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5098 (message_log_check_duplicate): Remove parameters `prev_bol' and
5099 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5100 (redisplay_internal): Remove parameter `preserve_echo_area',
5101 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5102
5103 * indent.c (Fvertical_motion):
5104 * window.c (window_scroll_pixel_based, Frecenter):
5105 Don't pass `need_y_p' to `move_it_by_lines'.
5106
1c470562
SM
51072011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5108
44f230aa
SM
5109 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5110 steal a few bits to be more compact.
5111 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5112 Remove unneeded casts.
5113
1c470562
SM
5114 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5115
888adce9
ZK
51162011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5117
5118 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5119 binding" message (bug#7967).
5120
f838ed7b
PE
51212011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5122
77861b95
PE
5123 Fix more problems found by GCC 4.6.0's static checks.
5124
de6dbc14
PE
5125 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5126 Remove unused local var.
5127
f838ed7b
PE
5128 * editfns.c (Fmessage_box): Remove unused local var.
5129
792c7b2b
PE
5130 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5131 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5132 Omit unused local vars.
c499e557 5133 * window.c (shrink_windows): Omit unused local var.
b01a1c29 5134 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
5135 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5136 Omit unused local var.
5137
ba0165e1
PE
5138 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5139 Don't assume string length fits in int.
32ad8845 5140 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 5141 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 5142
3c59b4c9
PE
5143 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5144 instead of alloca (Bug#8344).
5145
a3eed478 5146 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 5147 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 5148
eb4d412d
PE
5149 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5150
1658b401
PE
5151 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5152 concerns.
5153
5154 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5155
5156 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 5157
9a2c6e05
PE
5158 * keyboard.c (syms_of_keyboard): Use the same style as later
5159 in this function when indexing through an array. This also
5160 works around GCC bug 48267.
5161
03d0a109
PE
5162 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5163
44f730c8
PE
5164 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5165
fe75f926
PE
5166 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5167 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5168
ffa8c828
PE
5169 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5170 This avoids undefined behavior on integer overflow, and is a bit
5171 more convenient anyway since it is compared to a size_t variable.
5172
c5101a77
PE
5173 Variadic C functions now count arguments with size_t, not int.
5174 This avoids an unnecessary limitation on 64-bit machines, which
5175 caused (substring ...) to crash on large vectors (Bug#8344).
5176 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5177 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 5178 All variadic functions and their callers changed accordingly.
c5101a77
PE
5179 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5180 * data.c (arith_driver, float_arith_driver): Likewise.
5181 * editfns.c (general_insert_function): Likewise.
5182 * eval.c (struct backtrace.nargs, interactive_p)
5183 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5184 (funcall_lambda, mark_backtrace): Likewise.
5185 * fns.c (concat): Likewise.
5186 * frame.c (x_set_frame_parameters): Likewise.
5187 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5188 0 if not found, not -1. All callers changed.
5189
dd3f25f7
PE
5190 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5191 (stack_copy_size): Now size_t, not int.
5192 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5193
461c2ab9
JB
51942011-03-28 Juanma Barranquero <lekktu@gmail.com>
5195
5196 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5197 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5198 All callers changed.
5199
5200 * lisp.h (multibyte_char_to_unibyte):
5201 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5202 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5203 * character.h (CHAR_TO_BYTE8):
5204 * cmds.c (internal_self_insert):
5205 * editfns.c (general_insert_function):
5206 * keymap.c (push_key_description):
5207 * search.c (Freplace_match):
5208 * xdisp.c (message_dolog, set_message_1): All callers changed.
5209
f6d62986
SM
52102011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5211
5212 * keyboard.c (safe_run_hook_funcall): New function.
5213 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5214 don't set the hook to nil, but remove the offending function instead.
5215 (Qcommand_hook_internal): Remove, unused.
5216 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5217 Vcommand_hook_internal.
5218
5219 * eval.c (enum run_hooks_condition): Remove.
5220 (funcall_nil, funcall_not): New functions.
5221 (run_hook_with_args): Call each function through a `funcall' argument.
5222 Remove `cond' argument, now redundant.
5223 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5224 (Frun_hook_with_args_until_failure): Adjust accordingly.
5225 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5226
1db5b1ad
JB
52272011-03-28 Juanma Barranquero <lekktu@gmail.com>
5228
5229 * dispextern.h (string_buffer_position): Remove declaration.
5230
5231 * print.c (strout): Remove parameter `multibyte', unused since
5232 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5233
5234 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5235 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5236 All callers changed.
5237
5238 * w32.c (_wsa_errlist): Use braces for struct initializers.
5239
5240 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5241 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5242 All callers changed.
5243 (string_buffer_position): Likewise. Also, make static (it's never
5244 used outside xdisp.c).
5245 (cursor_row_p): Remove parameter `w', unused since
5246 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5247 (decode_mode_spec): Remove parameter `precision', introduced during
5248 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5249 All callers changed.
5250
5ffb62aa
JD
52512011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5252
5253 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5254
461c2ab9 52552011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
5256
5257 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5258 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5259 (ns_update_auto_hide_menu_bar): New functions.
5260 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5261 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5262 ns_constrain_all_frames.
5263 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5264 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5265
5c380ffb
JD
52662011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5267
5268 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5269
9af30bdf
GM
52702011-03-27 Glenn Morris <rgm@gnu.org>
5271
5272 * syssignal.h: Replace RETSIGTYPE with void.
5273 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5274 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5275 Replace SIGTYPE with void everywhere.
5276 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5277 * s/template.h (SIGTYPE): Remove commented out definition.
5278
e2abce01
JB
52792011-03-26 Eli Zaretskii <eliz@gnu.org>
5280
5281 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5282 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5283
f868cd8a
JB
52842011-03-26 Juanma Barranquero <lekktu@gmail.com>
5285
59eb0929
JB
5286 * w32.c (read_unc_volume): Use parameter `henum', instead of
5287 global variable `wget_enum_handle'.
5288
5289 * keymap.c (describe_vector): Remove parameters `indices' and
5290 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5291 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5292
f868cd8a
JB
5293 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5294
5295 * keyboard.c (timer_check): Remove parameter `do_it_now',
5296 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5297 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5298 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5299
5300 * keyboard.c (read_char):
5301 * w32menu.c (w32_menu_display_help):
5302 * xmenu.c (show_help_event, menu_help_callback):
5303 Adjust calls to `show_help_echo'.
5304
5305 * gtkutil.c (xg_maybe_add_timer):
5306 * keyboard.c (readable_events):
5307 * process.c (wait_reading_process_output):
5308 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5309
5310 * insdel.c (adjust_markers_gap_motion):
5311 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5312 (gap_left, gap_right): Don't call it.
5313
2ecf6fdb
CY
53142011-03-25 Chong Yidong <cyd@stupidchicken.com>
5315
5316 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5317 incurred during fontification.
5318
6b1f9ba4
JB
53192011-03-25 Juanma Barranquero <lekktu@gmail.com>
5320
5321 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5322 (DEFVAR_PER_BUFFER): Don't pass it.
5323
5324 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5325 (scrolling_window): Don't pass it.
5326
0f4a96b5
JB
53272011-03-25 Juanma Barranquero <lekktu@gmail.com>
5328
5329 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5330
5331 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5332 and `suffix'.
5333 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5334 of variables specific to SELinux and computation of `encoded_absname'.
5335
5336 * image.c (XPutPixel): Remove unused variable `height'.
5337
5338 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5339
5340 * unexw32.c (get_section_info): Remove unused variable `section'.
5341
5342 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5343 (system_process_attributes): Remove unused variable `sess'.
5344 (sys_read): Remove unused variable `err'.
5345
5346 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5347 (w32_wnd_proc): Remove unused variable `isdead'.
5348 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5349 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5350 (x_create_tip_frame): Remove unused variable `tem'.
5351
5352 * w32inevt.c (w32_console_read_socket):
5353 Remove unused variable `no_events'.
5354
5355 * w32term.c (x_draw_composite_glyph_string_foreground):
5356 Remove unused variable `width'.
5357
1149507c
JB
53582011-03-24 Juanma Barranquero <lekktu@gmail.com>
5359
5360 * w32term.c (x_set_glyph_string_clipping):
5361 Don't pass uninitialized region to CombineRgn.
5362
9c88f339
JB
53632011-03-23 Juanma Barranquero <lekktu@gmail.com>
5364
5365 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5366 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5367 (Fx_close_connection): Remove unused variable `i'.
5368
5369 * w32font.c (w32font_draw): Return number of glyphs.
5370 (w32font_open_internal): Remove unused variable `i'.
5371 (w32font_driver): Add missing initializer.
5372
5373 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5374 (fill_in_menu): Remove unused variable `items_added'.
5375
5376 * w32term.c (last_mouse_press_frame): Remove static global variable.
5377 (w32_clip_to_row): Remove unused variable `f'.
5378 (x_delete_terminal): Remove unused variable `i'.
5379
5380 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5381 (NOTHING): Remove unused static global variable.
5382 (uniscribe_check_otf): Remove unused variable `table'.
5383 (uniscribe_font_driver): Add missing initializers.
5384
dee091a3
JD
53852011-03-23 Julien Danjou <julien@danjou.info>
5386
5387 * term.c (Fsuspend_tty, Fresume_tty):
5388 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5389 * window.c (temp_output_buffer_show):
5390 * insdel.c (signal_before_change):
5391 * frame.c (Fhandle_switch_frame):
5392 * fileio.c (Fdo_auto_save):
5393 * emacs.c (Fkill_emacs):
5394 * editfns.c (save_excursion_restore):
5395 * cmds.c (internal_self_insert):
5396 * callint.c (Fcall_interactively):
5397 * buffer.c (Fkill_all_local_variables):
5398 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5399 Use Frun_hooks.
0f4a96b5 5400 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
5401 unconditionnaly since it does the check itself.
5402
2c520ab5 54032011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 5404
c9c49752
PE
5405 Fix more problems found by GCC 4.5.2's static checks.
5406
8abc3f12
PE
5407 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5408 the first time through the loop, since we know p0 < p1 then.
5409 This also avoids a gcc -Wstrict-overflow warning.
5410
a2d26660
PE
5411 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5412 leading to a memory leak, possible in functions like
5413 load_charset_map_from_file that can allocate an unbounded number
b12ef411 5414 of objects (Bug#8318).
a2d26660 5415
916c72e9
PE
5416 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5417 that could (at least in theory) be that large.
5418
19ab8a18
PE
5419 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5420 This is less likely to overflow, and avoids undefined behavior if
5421 overflow does occur. All callers changed. Use strtoul to scan
5422 for the unsigned long integer.
b7cbbd6f
PE
5423 (pint2hrstr): Simplify and tune code slightly.
5424 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 5425
f0641eff
PE
5426 * scroll.c (do_scrolling): Work around GCC bug 48228.
5427 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5428
7f650bb9
PE
5429 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5430 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
5431 (validate_x_resource_name): Simplify count usage.
5432 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 5433
37dd57d1
PE
5434 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5435 fail (Bug#8306).
81e56e61 5436
699979fc 5437 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 5438
401bf9b4
PE
5439 * process.c (Fmake_network_process): Use socklen_t, not int,
5440 where POSIX says socklen_t is required in portable programs.
5441 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 5442 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
5443 (Fmake_network_process, server_accept_connection):
5444 (wait_reading_process_output, read_process_output):
5445 Likewise.
5446
b93aacde
PE
5447 * process.c: Rename or move locals to avoid shadowing.
5448 (list_processes_1, Fmake_network_process):
5449 (read_process_output_error_handler, exec_sentinel_error_handler):
5450 Rename or move locals.
4dc343ee 5451 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 5452 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 5453 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 5454 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 5455 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 5456
af8a867c 5457 Make tparam.h and terminfo.c consistent.
44f230aa
SM
5458 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5459 Include tparam.h instead, since it declares them.
af8a867c
PE
5460 * cm.h (PC): Remove extern decl; tparam.h now does this.
5461 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5462 * terminfo.c: Include tparam.h, to check interfaces.
5463 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5464 (tparam): Adjust signature to match interface in tparam.h;
5465 this removes some undefined behavior. Check that outstring and len
5466 are zero, which they always are with Emacs.
5467 * tparam.h (PC, BC, UP): New extern decls.
5468
0248044d 5469 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 5470 (xftfont_open): Rename locals to avoid shadowing.
0248044d 5471
8ff096c1 5472 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
5473 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5474 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 5475 (ftfont_list): Remove unused local.
49eaafba
PE
5476 (get_adstyle_property, ftfont_pattern_entity):
5477 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5478 Rename locals to avoid shadowing.
8ff096c1 5479
e2be39f6
PE
5480 * xfont.c (xfont_list_family): Mark var as initialized.
5481
c9735e30
PE
5482 * xml.c (make_dom): Now static.
5483
8f5201ae
PE
5484 * composite.c (composition_compute_stop_pos): Rename local to
5485 avoid shadowing.
b246f932
PE
5486 (composition_reseat_it): Remove unused locals.
5487 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 5488 (composition_update_it): Mark var as initialized.
11b61122
PE
5489 (find_automatic_composition): Mark vars as initialized,
5490 with a FIXME (Bug#8290).
8f5201ae 5491
760fbc2c
PE
5492 character.h: Rename locals to avoid shadowing.
5493 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5494 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5495 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5496 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5497 to avoid shadowing.
5498
ff08eb85
PE
5499 * textprop.c (property_change_between_p): Remove; unused.
5500
fc7bf025
PE
5501 * intervals.c (interval_start_pos): Now static.
5502
235d7abc
PE
5503 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5504
44f230aa
SM
5505 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5506 Rename locals to avoid shadowing.
3e7d6594 5507
50060332
PE
5508 * sound.c (wav_play, au_play, Fplay_sound_internal):
5509 Fix pointer signedness.
d01f234b 5510 (alsa_choose_format): Remove unused local var.
c83b8872
PE
5511 (wav_play): Initialize a variable to 0, to prevent undefined
5512 behavior (Bug#8278).
50060332 5513
c4fc4e30
PE
5514 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5515
918436ed
PE
5516 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5517
c939f91b
PE
5518 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5519 clobbering (Bug#8298).
b9c7f648
PE
5520 * sysdep.c (sys_subshell): Likewise.
5521 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 5522
6bd8c144
PE
5523 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5524 This should get cleaned up, so that child_setup has the
5525 same signature on all platforms.
5526
7710357c 5527 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 5528 (relocate_fd): Rename locals to avoid shadowing.
7710357c 5529
c59da222
CY
55302011-03-22 Chong Yidong <cyd@stupidchicken.com>
5531
5532 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5533 not to be necessary, and produces flickering.
5534
66b87493
GM
55352011-03-20 Glenn Morris <rgm@gnu.org>
5536
5537 * config.in: Remove file.
5538
45b6f6d5
JB
55392011-03-20 Juanma Barranquero <lekktu@gmail.com>
5540
5541 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5542 are now in src/globals.h.
5543 (syms_of_minibuf): Remove spurious & from previous change.
5544
3ec03f7e
LL
55452011-03-20 Leo <sdl.web@gmail.com>
5546
5547 * minibuf.c (completing-read-function): New variable.
5548 (completing-read-default): Rename from completing-read.
5549 (completing-read): Call completing-read-function.
5550
b14e3e21
CY
55512011-03-19 Juanma Barranquero <lekktu@gmail.com>
5552
5553 * xfaces.c (Fx_load_color_file):
5554 Read color file from absolute filename (bug#8250).
5555
f2b726e6
JB
55562011-03-19 Juanma Barranquero <lekktu@gmail.com>
5557
5558 * makefile.w32-in: Update dependencies.
5559
09f6ff02
EZ
55602011-03-17 Eli Zaretskii <eliz@gnu.org>
5561
5562 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5563
29a6015a
PE
55642011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5565
a3a6c54e
PE
5566 Fix more problems found by GCC 4.5.2's static checks.
5567
b766f867
PE
5568 * process.c (make_serial_process_unwind, send_process_trap):
5569 (sigchld_handler): Now static.
5570
be02381c
PE
5571 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5572 That way, the code declares only the vars that it needs.
5573 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5574 * s/cygwin.h (PTY_ITERATION): Likewise.
5575 * s/darwin.h (PTY_ITERATION): Likewise.
5576 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5577
57048744
PE
5578 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5579 * process.c (allocate_pty): Don't declare stb unless it's needed.
5580
7914961c 5581 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
5582 (CONSTANTLIM): Remove; unused.
5583 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5584 Define only if needed.
7914961c 5585
b3967b18
PE
5586 * unexelf.c (unexec): Name an expression,
5587 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
5588 Use a different way to cause a compilation error if anyone uses
5589 n rather than nn, a way that does not involve shadowing.
73366a00 5590 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 5591
29a6015a
PE
5592 * deps.mk (unexalpha.o): Remove; unused.
5593
43cfc33e 5594 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 5595 * unexec.h: New file.
ce701a33
PE
5596 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5597 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5598 Depend on unexec.h.
5599 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5600 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5601 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 5602 Change as necessary to match prototype in unexec.h.
ce701a33 5603
01f44d5a
PE
5604 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5605 shadowing.
4f63c6bb 5606 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 5607
a6670b0b
PE
5608 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5609 Rename locals to avoid shadowing.
5610
cef2010d 5611 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 5612 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 5613
d4d7173a
PE
5614 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5615
f08b802a
PE
5616 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5617 warning when compiling print.c.
5618
3ddb0639
PE
5619 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5620 instead of using an uninitialized var.
5ad03b97 5621 (font_sort_entities): Mark var as initialized.
3ddb0639 5622
170a2692
PE
5623 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5624
e663c700
PE
5625 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5626 pointers to constants.
89bc529a 5627 (font_parse_fcname): Remove unused vars.
7b81e2d0 5628 (font_delete_unmatched): Now static.
ea838e10 5629 (font_get_spec): Remove; unused.
13a547c6
PE
5630 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5631 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5632 Rename or move locals to avoid shadowing.
e663c700 5633
2a80c887 5634 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 5635 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 5636
1384fa33 5637 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 5638 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 5639
8b2c52e9
PE
5640 * alloc.c (mark_backtrace): Move decl from here ...
5641 * lisp.h: ... to here, so that it can be checked.
5642
475545b5 5643 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 5644 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
5645 (lisp_indirect_variable): Name an expression,
5646 to avoid gcc -Wbad-function-cast warning.
1faed8ae 5647 (Fdefvar): Rename locals to avoid shadowing.
475545b5 5648
b1349114 5649 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 5650 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 5651 Use const pointer when appropriate.
b1349114 5652
a2928364
PE
5653 * lisp.h (get_system_name, get_operating_system_release):
5654 Move decls here, to check interfaces.
5655 * process.c (get_operating_system_release): Move decl to lisp.h.
5656 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
5657 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5658 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5659 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
5660 (Fformat_time_string, Fencode_time, Finsert_char):
5661 (Ftranslate_region_internal, Fformat):
5662 Rename or remove local vars to avoid shadowing.
9710023e 5663 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 5664
a415e694
PE
5665 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5666 avoid shadowing.
5667
8ef4622d
PE
5668 * lisp.h (eassert): Check that the argument compiles, even if
5669 ENABLE_CHECKING is not defined.
5670
946f9a5b
PE
5671 * data.c (Findirect_variable): Name an expression, to avoid
5672 gcc -Wbad-function-cast warning.
112396d6 5673 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 5674 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
5675 (Fmake_variable_buffer_local, Fmake_local_variable):
5676 Mark variables as initialized.
52746918 5677 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 5678
e5aab7e7 5679 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
5680 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5681 Rename locals to avoid shadowing.
dff45157
PE
5682 (mark_stack): Move local variables into the #ifdef region where
5683 they're used.
7bc26fdb
PE
5684 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5685 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5686 needed otherwise.
5687 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5688 (GC_STRING_CHARS): Remove; not used.
d40d4be1 5689 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 5690
e5aab7e7
PE
5691 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5692 avoids undefined behavior in theory.
5693
4da60324
PE
5694 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5695
88043301
PE
5696 Use functions, not macros, for up- and down-casing (Bug#8254).
5697 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5698 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5699 to use the following functions instead of these macros.
5700 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5701 EMACS_INT, since callers assume the returned value fits in int.
5702 (upcase1): Likewise, for UPCASE_TABLE.
5703 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 5704 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 5705 the race-condition problem in the old DOWNCASE.
88043301 5706
19ed5445
PE
5707 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5708 Rename locals to avoid shadowing.
5709 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
5710 (regex_compile, re_search_2, re_match_2_internal):
5711 Remove unused local vars.
952db0d7
PE
5712 (FREE_VAR): Rewrite so as not to use empty "else",
5713 which gcc can warn about.
da053e48 5714 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
5715 (RETALLOC_IF): Define only if needed.
5716 (WORDCHAR_P): Likewise. This one is never needed, but is used
5717 only in a comment talking about a compiler bug, so put inside
5718 the #if 0 of that comment.
5719 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5720 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5721 Remove; unused.
19ed5445 5722
1f3561e4 5723 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
5724 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5725 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 5726
ded6f8f7
PE
5727 * search.c (simple_search): Remove unused var.
5728
dbd37a95
PE
5729 * dired.c (compile_pattern): Move decl from here ...
5730 * lisp.h: ... to here, so that it can be checked.
5731 (struct re_registers): New forward decl.
5732
7e47afad
PE
5733 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5734
85f24f61
PE
5735 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5736 All uses changed.
5737 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5738 Rename locals to avoid shadowing.
5671df8f 5739 (Fvertical_motion): Mark locals as initialized.
85f24f61 5740
181aa2be 5741 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 5742 (casify_region): Mark local as initialized.
181aa2be 5743
930d429c
PE
5744 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5745
7082eac6
PE
5746 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5747 New macros, so that the caller can use some names other than
5748 gcpro1, gcpro2, etc.
5749 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5750 of the new macros.
5751 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5752 argument, for consistency with GCPRO2_VAR, etc: it is now the
5753 prefix of the variable, not the variable itself. All uses
5754 changed.
38b2c076
PE
5755 * dired.c (directory_files_internal, file_name_completion):
5756 Rename locals to avoid shadowing.
5757
15206ed9
PE
5758 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5759 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5760 dired.c's scmp function, had undefined behavior.
5761 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5762 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5763 * buffer.h: ... to here, because these macros use current_buffer,
5764 and the new implementation with inline functions needs to have
5765 current_buffer in scope now, rather than later when the macros
5766 are used.
5767 (downcase, upcase1): New static inline functions.
5768 (DOWNCASE, UPCASE1): Reimplement using these functions.
5769 This avoids undefined behavior in expressions like
5770 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5771 from race conditions in accessing the global variables
5772 case_temp1 and case_temp2.
5773 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5774 * lisp.h (case_temp1, case_temp2): Remove their decls.
5775 * character.h (ASCII_CHAR_P): Move from here ...
5776 * lisp.h: ... to here, so that the inline functions mentioned
5777 above can use them.
5778
4a6bea26
PE
5779 * dired.c (directory_files_internal_unwind): Now static.
5780
f14b7e14
PE
5781 * fileio.c (file_name_as_directory, directory_file_name):
5782 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5783 Now static.
2893f146
PE
5784 (file_name_as_directory): Use const pointers when appropriate.
5785 (Fexpand_file_name): Likewise. In particular, newdir might
5786 point at constant storage, so make it a const pointer.
fd4ead52 5787 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
5788 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5789 signedness issues.
f839df0c
PE
5790 (Fset_file_times, Finsert_file_contents, auto_save_error):
5791 Rename locals to avoid shadowing.
f14b7e14 5792
5716756e 5793 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
5794 (Ftry_completion, Fall_completions): Rename or remove locals
5795 to avoid shadowing.
5716756e 5796
b4c3046a
PE
5797 * marker.c (bytepos_to_charpos): Remove; unused.
5798
b45db522
PE
5799 * lisp.h (verify_bytepos, count_markers): New decls,
5800 so that gcc does not warn that these functions aren't declared.
5801
85876d07
PE
5802 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5803 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 5804 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 5805 (copy_text): Remove unused local var.
85876d07 5806
03d78a21 5807 * filelock.c (within_one_second): Now static.
b3dd38ab 5808 (lock_file_1): Rename local to avoid shadowing.
03d78a21 5809
5df8f01b
PE
5810 * buffer.c (fix_overlays_before): Mark locals as initialized.
5811 (fix_start_end_in_overlays): Likewise. This function should be
5812 simplified by using pointers-to-pointers, but that's a different
5813 matter.
b1d876f1 5814 (switch_to_buffer_1): Now static.
8f54f30a
PE
5815 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5816 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 5817
a70072c9 5818 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 5819 Fix pointer signedness issue.
edced198
PE
5820 (sys_subshell): Mark local as volatile if checking for lint,
5821 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 5822 (MAXPATHLEN): Define only if needed.
a70072c9 5823
a0977c44
PE
5824 * process.c (serial_open, serial_configure): Move decls from here ...
5825 * systty.h: ... to here, so that they can be checked.
5826
a884fdcc
PE
5827 * fns.c (get_random, seed_random): Move extern decls from here ...
5828 * lisp.h: ... to here, so that they can be checked.
5829
604efe86 5830 * sysdep.c (reset_io): Now static.
b8950c94 5831 (wait_for_termination_signal): Remove; unused.
604efe86 5832
38fc62d9
PE
5833 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5834 (copy_keymap_item, append_key, push_text_char_description):
5835 Now static.
1004a21a 5836 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 5837 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
5838 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5839 (describe_map_tree):
5840 Rename locals to avoid shadowing.
38fc62d9 5841
2f2650da
PE
5842 * keyboard.c: Declare functions static if they are not used elsewhere.
5843 (echo_char, echo_dash, cmd_error, top_level_2):
5844 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
5845 (read_char, kbd_buffer_get_event, make_lispy_position):
5846 (make_lispy_event, make_lispy_movement, apply_modifiers):
5847 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5848 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5849 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 5850 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 5851 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 5852
a053e86c 5853 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
5854 (mark_kboards): Move decl here ...
5855 * alloc.c (mark_kboards): ... from here.
a053e86c 5856
4752793e
PE
5857 * lisp.h (force_auto_save_soon): New decl.
5858
74f10ca7 5859 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
5860 (DEFINE_DUMMY_FUNCTION): New macro.
5861 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5862 Use it.
c03cd23f
PE
5863 (main): Add casts to avoid warnings
5864 if GCC considers string literals to be constants.
74f10ca7 5865
022e70d4
PE
5866 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5867
59d6fe83
PE
5868 * dbusbind.c: Pointer signedness fixes.
5869 (xd_signature, xd_append_arg, xd_initialize):
5870 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5871 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5872 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5873 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5874
78320123
PE
5875 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5876 if GCC considers string literals to be constants.
49cebcca 5877 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 5878
35ac2a97
SM
58792011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5880
fb103ca9
SM
5881 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5882 (print_preprocess, print_object): New macro to fix last change.
5883
35ac2a97
SM
5884 * print.c (print_preprocess): Don't forget font objects.
5885
62973b41
JB
58862011-03-16 Juanma Barranquero <lekktu@gmail.com>
5887
5888 * emacs.c (USAGE3): Doc fixes.
5889
0e48bb22
AS
58902011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5891
5892 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5893 structure.
5894
7684e57b
JB
58952011-03-14 Juanma Barranquero <lekktu@gmail.com>
5896
5897 * lisp.h (VWindow_system, Qfile_name_history):
5898 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5899 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5900 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5901
5902 * w32select.c: Don't #include "keyboard.h".
c96bbc66 5903 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
5904
5905 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5906 * w32console.c (detect_input_pending, read_input_pending)
5907 (encode_terminal_code):
5908 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5909 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5910 (w32_system_caret_y, Qfile_name_history):
5911 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5912 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5913 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5914 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5915 * w32proc.c (Qlocal, report_file_error):
5916 * w32term.c (Vwindow_system, updating_frame):
5917 * w32uniscribe.c (initialized, uniscribe_font_driver):
5918 Remove unneeded extern declarations.
5919
2aa46d6c
CY
59202011-03-14 Chong Yidong <cyd@stupidchicken.com>
5921
c96bbc66 5922 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 5923
cffc6f3b
CY
59242011-03-13 Chong Yidong <cyd@stupidchicken.com>
5925
5926 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
5927 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
5928 These macros can no longer be used for assignment.
5929
44f230aa
SM
5930 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5931 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
5932 (record_buffer_markers, fetch_buffer_markers): New functions for
5933 recording and fetching special buffer markers.
5934 (set_buffer_internal_1, set_buffer_temp): Use them.
5935
5936 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
5937
5938 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
5939
5940 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
5941 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
5942
5943 * xdisp.c (hscroll_window_tree):
5944 (reconsider_clip_changes): Use PT instead of BUF_PT.
5945
d251f04b
EZ
59462011-03-13 Eli Zaretskii <eliz@gnu.org>
5947
5948 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
5949 $(EMACS_ROOT)/lib/intprops.h.
5950
f0c77cd1
PE
59512011-03-13 Paul Eggert <eggert@cs.ucla.edu>
5952
3eca4629
PE
5953 Fix more problems found by GCC 4.5.2's static checks.
5954
7c86ee98
PE
5955 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
5956 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
5957 (xg_free_frame_widgets): Make it clear that a local variable is
5958 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
5959 (gdk_window_get_screen): Make it clear that this macro is needed
5960 only if USE_GTK_TOOLTIP.
1e5524e7
PE
5961 (int_gtk_range_get_value): New function, which avoids a diagnostic
5962 from gcc -Wbad-function-cast.
5963 (xg_set_toolkit_scroll_bar_thumb): Use it.
5964 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
5965 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
5966 (get_utf8_string, xg_get_file_with_chooser):
5967 Rename locals to avoid shadowing.
5968 (create_dialog): Move locals to avoid shadowing.
7c86ee98 5969
41729b81
PE
5970 * xgselect.c (xg_select): Remove unused var.
5971
f0c77cd1
PE
5972 * image.c (four_corners_best): Mark locals as initialized.
5973 (gif_load): Initialize transparent_p to zero (Bug#8238).
5974 Mark another local as initialized.
ec6cf4c6 5975 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 5976
ce0ad53d 5977 * image.c (clear_image_cache): Now static.
d5d5a617 5978 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 5979 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
5980 (x_edge_detection): Remove unnecessary cast that
5981 gcc -Wbad-function-cast diagnoses.
2037898d 5982 (gif_load): Fix pointer signedness.
6ae141d6
PE
5983 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
5984 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 5985
33383987 59862011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 5987
d32df629
PE
5988 Improve quality of tests for time stamp overflow.
5989 For example, without this patch (encode-time 0 0 0 1 1
5990 1152921504606846976) returns the obviously-bogus value (-948597
5991 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
5992 reports time overflow. See
5993 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
5994 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
5995 * editfns.c: Include limits.h and intprops.h.
5996 (TIME_T_MIN, TIME_T_MAX): New macros.
5997 (time_overflow): Move earlier, to before first use.
5998 (hi_time, lo_time): New functions, for an accurate test for
5999 out-of-range times.
6000 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6001 (Fget_internal_run_time): Don't assume time_t fits in int.
6002 (make_time): Use list2 instead of Fcons twice.
6003 (Fdecode_time): More accurate test for out-of-range times.
6004 (check_tm_member): New function.
6005 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
6006 (lisp_time_argument): Don't rely on undefined left-shift and
6007 right-shift behavior when checking for time stamp overflow.
8be6f318 6008
fe31d94c
PE
6009 * editfns.c (time_overflow): New function, refactoring common code.
6010 (Fformat_time_string, Fdecode_time, Fencode_time):
6011 (Fcurrent_time_string): Use it.
6012
8be6f318
PE
6013 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6014 * dired.c (make_time): Move to ...
6015 * editfns.c (make_time): ... here.
6016 * systime.h: Note the move.
6017
09d9db2c 60182011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 6019
126bc0dc
YM
6020 * fringe.c (update_window_fringes): Remove unused variables.
6021
c47cbdfd
YM
6022 * unexmacosx.c (copy_data_segment): Also copy __got section.
6023 (Bug#8223)
6024
7ac80be9
EZ
60252011-03-12 Eli Zaretskii <eliz@gnu.org>
6026
c96bbc66 6027 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
6028 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6029 Constify `char *' arguments and their references according to
6030 prototypes in tparam.h.
6031
ecb0f94d 6032 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 6033
7ac80be9
EZ
6034 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6035 Adapt all references accordingly.
6036
6037 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6038
ef1fd07e
TT
60392011-03-11 Tom Tromey <tromey@redhat.com>
6040
6041 * buffer.c (syms_of_buffer): Remove obsolete comment.
6042
7ef4b50c
EZ
60432011-03-11 Eli Zaretskii <eliz@gnu.org>
6044
6045 * termhooks.h (encode_terminal_code): Declare prototype.
6046
6047 * msdos.c (encode_terminal_code): Don't declare prototype.
6048
6049 * term.c (encode_terminal_code): Now external again, used by
6050 w32console.c and msdos.c.
6051
44f230aa
SM
6052 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6053 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 6054
4b1ec863 60552011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 6056
1714f52b 6057 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 6058
4b1ec863
PE
6059 * fringe.c (update_window_fringes): Mark locals as initialized
6060 (Bug#8227).
6061 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 6062
524c7aa6
PE
6063 * alloc.c (mark_fringe_data): Move decl from here ...
6064 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6065 to check its interface.
6066 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6067
a5c0af81 6068 * fontset.c (free_realized_fontset): Now static.
7519b8cd 6069 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 6070 (fontset_font): Mark local as initialized.
a9a06e0b 6071 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 6072
b4716021
PE
6073 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6074
811e9bac 6075 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 6076 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
6077 (x_own_selection, Fx_disown_selection_internal): Rename locals
6078 to avoid shadowing.
6079 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 6080
7e3ab302
PE
6081 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6082 so that the caller can use some name other than gcpro1.
6083 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
6084 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6085 (Fx_backspace_delete_keys_p):
6086 Use them to avoid shadowing, and rename vars to avoid shadowing.
6087 (x_decode_color, x_set_name, x_window): Now static.
6b437900 6088 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 6089 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
6090 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6091 Remove unused locals.
7e3ab302
PE
6092 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6093 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6094 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6095 macros.
f78faa98 6096
e2b13473
PE
6097 * xterm.h (x_mouse_leave): New decl.
6098
77f23912
PE
6099 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6100 Remove unused functions.
cdf4ba58
PE
6101 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6102 (x_calc_absolute_position): Now static.
7411c686 6103 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 6104 Don't declare local "event" unless it's used.
ed7bf3a5
PE
6105 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6106 unless they are used.
38d0b34a
PE
6107 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6108 (x_fatal_error_signal): Remove; not used.
a6067996
PE
6109 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6110 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6111 (x_error_catcher, x_connection_closed, x_error_handler):
6112 (x_error_quitter, xembed_send_message, x_iconify_frame):
6113 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 6114 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 6115 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 6116
44f230aa
SM
6117 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6118 Rename or move locals to avoid shadowing.
6b463e58 6119 (tty_defined_color, merge_face_heights): Now static.
5967d051 6120 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
6121 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6122 does not deduce is never used uninitialized.
73719eba
PE
6123 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6124 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 6125
426994c3 6126 * terminal.c (store_terminal_param): Now static.
5489860b 6127
032f1620 6128 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 6129 (set_frame_menubar): Remove unused local.
d4323972 6130 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
6131 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6132 since they might point to immutable storage.
281585b0
PE
6133 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6134 since it's unused otherwise.
032f1620 6135
367c19e5 6136 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 6137 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
6138 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6139 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 6140 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
6141 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
6142 does not deduce are never used uninitialized.
70739cbe 6143
07b48fa9
PE
6144 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6145
8868a238 6146 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
6147 * window.c (window_loop, size_window):
6148 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 6149
7e5cf297 6150 * window.c (display_buffer): Now static.
d6550a9f
PE
6151 (size_window): Mark variables that gcc -Wuninitialized
6152 does not deduce are never used uninitialized.
a586633d
PE
6153 * window.h (check_all_windows): New decl, to forestall
6154 gcc -Wmissing-prototypes diagnostic.
5b555da1 6155 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 6156
f6095868
PE
6157 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6158 shadowing.
6159 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
6160 Include <limits.h>.
6161 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6162 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
6163 (load_charset_map): Mark variables that gcc -Wuninitialized
6164 does not deduce are never used uninitialized.
53df7c11 6165 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 6166
f38b440c
PE
6167 * coding.c (coding_set_source, coding_set_destination):
6168 Use "else { /* comment */ }" rather than "else /* comment */;"
6169 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
6170 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6171 a block, when the outer 'i' will do.
6172 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6173 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6174 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6175 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6176 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6177 Rename locals to avoid shadowing.
6178 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
6179 * coding.c (emacs_mule_char, encode_invocation_designation):
6180 Now static, since they're not used elsewhere.
413bb2db 6181 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 6182 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
6183 (decode_coding_emacs_mule): Mark variables that gcc
6184 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
6185 (detect_coding_iso_2022): Initialize a local variable that might
6186 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 6187 this initialization is needed. (Bug#8211)
5f58e762
PE
6188 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6189 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6190 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6191 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6192 Remove unused macros.
f38b440c 6193
232b38b9 6194 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 6195 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 6196 * character.c (string_count_byte8): Likewise.
232b38b9 6197
fb90da1b
PE
6198 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6199 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6200
fb93dbc2
PE
6201 * chartab.c (copy_sub_char_table): Now static, since it's not used
6202 elsewhere.
5c156ace
PE
6203 (sub_char_table_ref_and_range, char_table_ref_and_range):
6204 Rename locals to avoid shadowing.
bbcd0949 6205 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 6206
7d3b3862 6207 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 6208 (BIDI_BOB): Remove unused macro.
7d3b3862 6209
6be7d3da
PE
6210 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6211 deduce are never used uninitialized.
c2ed9c8b 6212 * term.c (encode_terminal_code): Likewise.
6be7d3da 6213
75f8807f 6214 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 6215
50938595
PE
6216 * tparam.h: New file.
6217 * term.c, tparam.h: Include it.
6218 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6219 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6220 Move these decls to tparam.h, and make them agree with what
6221 is actually in tparam.c. The previous trick of using incompatible
6222 decls in different modules does not conform to the C standard.
6223 All callers of tparam changed to use tparam's actual API.
6224 * tparam.c (tparam1, tparam, tgoto):
6225 Use const pointers where appropriate.
6226
fbceeba2
PE
6227 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6228 * cm.h (struct cm): Likewise.
6229 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6230 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6231 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6232 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6233 (turn_on_face, init_tty): Likewise.
6234 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 6235
7f3f1250
PE
6236 * term.c (term_mouse_position): Rename local to avoid shadowing.
6237
e6ca6543
PE
6238 * alloc.c (mark_ttys): Move decl from here ...
6239 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6240
c40f8d15
AS
62412011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6242
6243 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6244
cfe0661d
JB
62452011-03-09 Juanma Barranquero <lekktu@gmail.com>
6246
6247 * search.c (compile_pattern_1): Remove argument regp, unused since
6248 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6249 (compile_pattern): Don't pass it.
6250
0afb4571
J
62512011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6252
6253 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6254 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6255 for ! HAVE_GTK3.
6256 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6257
6258 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6259
6260 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6261 gdk_window_get_screen, gdk_window_get_geometry,
6262 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6263 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6264 (xg_get_pixbuf_from_pixmap): New function.
6265 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6266 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6267 Call xg_get_pixbuf_from_pixmap instead of
6268 gdk_pixbuf_get_from_drawable.
6269 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6270 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6271 (xg_check_special_colors): Use GtkStyleContext and its functions
6272 for HAVE_GTK3.
6273 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6274 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6275 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
6276 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6277 Call gtk_widget_get_preferred_size.
0afb4571
J
6278 (xg_frame_resized): gdk_window_get_geometry only takes 5
6279 parameters.
44f230aa
SM
6280 (xg_win_to_widget, xg_event_is_for_menubar):
6281 Call gdk_x11_window_lookup_for_display.
0afb4571
J
6282 (xg_set_widget_bg): New function.
6283 (delete_cb): New function.
895009e1 6284 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
6285 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6286 (xg_set_background_color): Call xg_set_widget_bg.
6287 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6288 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6289 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6290 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6291 if ! HAVE_GTK3.
6292 (update_frame_tool_bar): Call gtk_widget_hide.
6293 (xg_initialize): Use GDK_KEY_g.
6294
6295 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6296 if ! HAVE_GTK3
6297 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6298
6299 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6300 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6301 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6302
1c2cc4ef
JB
63032011-03-08 Juanma Barranquero <lekktu@gmail.com>
6304
6305 * w32xfns.c (select_palette): Check success of RealizePalette against
6306 GDI_ERROR, not zero.
6307
33383987 6308See ChangeLog.11 for earlier changes.
aac0c6e3
MR
6309
6310;; Local Variables:
6311;; coding: utf-8
aac0c6e3
MR
6312;; End:
6313
33383987 6314 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
6315
6316 This file is part of GNU Emacs.
6317
6318 GNU Emacs is free software: you can redistribute it and/or modify
6319 it under the terms of the GNU General Public License as published by
6320 the Free Software Foundation, either version 3 of the License, or
6321 (at your option) any later version.
6322
6323 GNU Emacs is distributed in the hope that it will be useful,
6324 but WITHOUT ANY WARRANTY; without even the implied warranty of
6325 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6326 GNU General Public License for more details.
6327
6328 You should have received a copy of the GNU General Public License
6329 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.