* xterm.c (x_alloc_nearest_color_1): Use a more-precise algorithm
[bpt/emacs.git] / src / ChangeLog
CommitLineData
13bdea59
PE
12011-06-13 Paul Eggert <eggert@cs.ucla.edu>
2
5efd304b
PE
3 * xterm.c (x_alloc_nearest_color_1): Use a more-precise algorithm
4 for nearest color, one that neither overflows nor relies on unsigned
5 arithmetic.
6
578c21e6
PE
7 Remove unnecessary casts.
8 * xterm.c (x_term_init):
9 * xfns.c (x_set_border_pixel):
10 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
11 These aren't needed now that we assume ANSI C.
12
96f53c6c
PE
13 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
14 It's more likely to cause problems (due to unsigned overflow)
15 than to cure them.
16
83c77d31
PE
17 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
18
ee2079f1
PE
19 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
20
6da65536
PE
21 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
22
7147c4a4
PE
23 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
24
193e32d9
PE
25 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
26
e5533da6
PE
27 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
28
9910e595
PE
29 GLYPH_CODE_FACE returns EMACS_INT, not int.
30 * dispextern.h (merge_faces):
31 * xfaces.c (merge_faces):
32 * xdisp.c (get_next_display_element):
33 (next_element_from_display_vector): Don't assume EMACS_INT fits in int.
34
2638320e
PE
35 * character.h (CHAR_VALID_P): Remove unused parameter.
36 * fontset.c, lisp.h, xdisp.c: All uses changed.
37
045eb8d9
PE
38 * editfns.c (Ftranslate_region_internal): Omit redundant test.
39
c1f134b5
PE
40 * fns.c (concat): Minor tuning based on overflow analysis.
41 This doesn't fix any bugs. Use int to hold character, instead
42 of constantly refetching from Emacs object. Use XFASTINT, not
43 XINT, for value known to be a character. Don't bother comparing
44 a single byte to 0400, as it's always less.
45
395fcb93 46 * floatfns.c (Fexpt):
327eeec8
PE
47 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
48
abbd3d23
PE
49 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
50 for characters.
51
684a03ef
PE
52 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
53
0fed43f3
PE
54 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
55 Without this fix, on a 64-bit host (aset S 0 4294967386) would
56 incorrectly succeed when S was a string, because 4294967386 was
57 truncated before it was used.
58
8fd02eb7
PE
59 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
60 Otherwise, an out-of-range integer could cause undefined behavior
61 on a 64-bit host.
62
f8c86b69
PE
63 * composite.c: Use int, not EMACS_INT, for characters.
64 (fill_gstring_body, composition_compute_stop_pos): Use int, not
65 EMACS_INT, for values that are known to be in character range.
66 This doesn't fix any bugs but is the usual style inside Emacs and
67 may generate better code on 32-bit machines.
68
34206dd2
PE
69 Make sure a 64-bit char is never passed to ENCODE_CHAR.
70 This is for reasons similar to the recent CHAR_STRING fix.
71 * charset.c (Fencode_char): Check that character arg is actually
72 a character. Pass an int to ENCODE_CHAR.
73 * charset.h (ENCODE_CHAR): Verify that the character argument is no
74 wider than 'int', as a compile-time check to prevent future regressions
75 in this area.
76
c5958d4c 77 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
78
79 Make sure a 64-bit char is never passed to CHAR_STRING.
80 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
81 by silently ignoring the top 32 bits, allowing some values
82 that were far too large to be valid characters.
83 * character.h: Include <verify.h>.
84 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
85 arguments are no wider than unsigned, as a compile-time check
86 to prevent future regressions in this area.
87 * data.c (Faset):
88 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char):
89 (Fsubst_char_in_region):
90 * fns.c (concat):
91 * xdisp.c (decode_mode_spec_coding):
92 Adjust to CHAR_STRING's new requirement.
93 * editfns.c (Finsert_char, Fsubst_char_in_region):
94 * fns.c (concat): Check that character args are actually
95 characters. Without this test, these functions did the wrong
96 thing with wildly out-of-range values on 64-bit hosts.
97
ea204efb
PE
982011-06-12 Paul Eggert <eggert@cs.ucla.edu>
99
d37ca623
PE
100 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
101 These casts should not be needed on 32-bit hosts, either.
102 * keyboard.c (read_char):
103 * lread.c (Fload): Remove casts to unsigned.
104
ea204efb
PE
105 * lisp.h (UNSIGNED_CMP): New macro.
106 This fixes comparison bugs on 64-bit hosts.
107 (ASCII_CHAR_P): Use it.
108 * casefiddle.c (casify_object):
109 * character.h (ASCII_BYTE_P, CHAR_VALID_P):
110 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
111 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
112 * dispextern.h (FACE_FROM_ID):
113 * keyboard.c (read_char): Use UNSIGNED_CMP.
114
fc83f7d3 1152011-06-11 Paul Eggert <eggert@cs.ucla.edu>
666398f3 116
41cb286c
PE
117 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
118 not to EMACS_INT, to avoid GCC warning.
119
4a1b9832
PE
120 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
121
55daad71
PE
122 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
123 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
124 isn't needed on 32-bit machines.
8f95c75c 125
666398f3 126 * buffer.c (Fgenerate_new_buffer_name): Use EMACS_INT for count, not int.
0ceccced 127 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
128
129 * data.c (Qcompiled_function): Now static.
130
c6f072e7
PE
131 * window.c (window_body_lines): Now static.
132
20ce5912
PE
133 * image.c (gif_load): Rename local to avoid shadowing.
134
9c4c5f81
PE
135 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
136 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
137 * alloc.c (make_save_value): Integer argument is now of type
138 ptrdiff_t, not int.
139 (mark_object): Use ptrdiff_t, not int.
140 * lisp.h (pD): New macro.
141 * print.c (print_object): Use it.
142
c0c5c8ae
PE
143 * alloc.c: Use EMACS_INT, not int, to count objects.
144 (total_conses, total_markers, total_symbols, total_vector_size)
145 (total_free_conses, total_free_markers, total_free_symbols)
146 (total_free_floats, total_floats, total_free_intervals, total_intervals)
147 (total_strings, total_free_strings):
148 Now EMACS_INT, not int. All uses changed.
149 (Fgarbage_collect): Compute overall total using a double, so that
150 integer overflow is less likely to be a problem. Check for overflow
151 when converting back to an integer.
5a25e253
PE
152 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
153 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
154 These were 'int' variables that could overflow on 64-bit hosts;
155 they were never used, so remove them instead of repairing them.
211a0b2a 156 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
157 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
158 Previously, this ceilinged at INT_MAX, but that doesn't work on
159 64-bit machines.
e46bb31a 160 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 161
c78baabf 162 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 163 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
164 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
165 when a (possibly-narrower) signed value would do just as well.
166 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 167
c9d624c6
PE
168 * alloc.c: Catch some string size overflows that we were missing.
169 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
170 for convenience in STRING_BYTES_MAX.
171 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
172 The definition here is exact; the one in lisp.h was approximate.
173 (allocate_string_data): Check for string overflow. This catches
174 some instances we weren't catching before. Also, it catches
175 size_t overflow on (unusual) hosts where SIZE_MAX <= min
176 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
177 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 178
c9d624c6
PE
179 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
180 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
181 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
182
353032ce
PE
183 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
184
2bccce07
PE
185 * alloc.c (Fmake_string): Check for out-of-range init.
186
b50691aa
CY
1872011-06-11 Chong Yidong <cyd@stupidchicken.com>
188
189 * dispextern.h (struct image): Replace data member, whose int_val
190 and ptr_val fields were not used by anything, with a single
191 lisp_val object.
192
193 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
194 (gif_clear_image, gif_load, imagemagick_load_image)
195 (gs_clear_image, gs_load): Callers changed.
196
3f754b86
PE
1972011-06-10 Paul Eggert <eggert@cs.ucla.edu>
198
cca69397
PE
199 * buffer.h: Include <time.h>, for time_t.
200 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
201
109e28d0
PE
202 Fix minor problems found by static checking.
203
60737f02
PE
204 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
205
4b66faf3
PE
206 Make identifiers static if they are not used in other modules.
207 * data.c (Qcompiled_function, Qframe, Qvector):
208 * image.c (QimageMagick, Qsvg):
209 * minibuf.c (Qmetadata):
210 * window.c (resize_window_check, resize_root_window): Now static.
211 * window.h (resize_window_check, resize_root_window): Remove decls.
212
109e28d0
PE
213 * window.c (window_deletion_count, delete_deletable_window):
214 Remove; unused.
46a4ce9e
PE
215 (window_body_lines): Now static.
216 (Fdelete_other_windows_internal): Mark vars as initialized.
217 Make sure 'resize_failed' is initialized.
218 (run_window_configuration_change_hook): Rename local to avoid shadowing.
219 (resize_window_apply): Remove unused local.
220 * window.h (delete_deletable_window): Remove decl.
221
109e28d0 222 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
223 (imagemagick_load_image): Fix pointer signedness problem by changing
224 last arg from unsigned char * to char *. All uses changed.
225 Also, fix a local for similar reasons.
226 Remove unused locals. Remove locals to avoid shadowing.
227 (fn_rsvg_handle_free): Remove; unused.
228 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 229 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 230
3f754b86
PE
231 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
232
2547adb1
CY
2332011-06-10 Chong Yidong <cyd@stupidchicken.com>
234
235 * image.c (gif_load): Fix omitted cast error introduced by
236 2011-06-06 change.
237
2c8e37d4
MR
2382011-06-10 Martin Rudalics <rudalics@gmx.at>
239
240 * window.h (resize_proportionally, orig_total_lines)
241 (orig_top_line): Remove from window structure.
242 (set_window_height, set_window_width, change_window_heights)
243 (Fdelete_window): Remove prototypes.
244 (resize_frame_windows): Remove duplicate declaration.
245
440a42e3
EZ
2462011-06-10 Eli Zaretskii <eliz@gnu.org>
247
248 * window.h (resize_frame_windows, resize_window_check)
249 (delete_deletable_window, resize_root_window)
250 (resize_frame_windows): Declare prototypes.
251
252 * window.c (resize_window_apply): Make definition be "static" to
253 match the prototype.
254
562dd5e9
MR
2552011-06-10 Martin Rudalics <rudalics@gmx.at>
256
257 * window.c: Remove declarations of Qwindow_size_fixed,
258 window_min_size_1, window_min_size_2, window_min_size,
259 size_window, window_fixed_size_p, enlarge_window, delete_window.
260 Remove static from declaration of Qdelete_window, it's
261 temporarily needed by Fbury_buffer.
262 (replace_window): Don't assign orig_top_line and
263 orig_total_lines.
264 (Fdelete_window, delete_window): Remove. Window deletion is
265 handled by window.el.
266 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
267 Fdelete_window calls with calls to Qdelete_window.
268 (Fdelete_other_windows): Remove. Deleting other windows is
269 handled by window.el.
270 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
271 handled in window.el.
272 (window_min_size_2, window_min_size_1, window_min_size): Remove.
273 Window minimum sizes are handled in window.el.
274 (shrink_windows, size_window, set_window_height)
275 (set_window_width, change_window_heights, window_height)
276 (window_width, CURBEG, CURSIZE, enlarge_window)
277 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
278 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
279 handled in window.el.
280 (make_dummy_parent): Rename to make_parent_window and give it a
281 second argument horflag.
282 (make_window): Don't set resize_proportionally any more.
283 (Fsplit_window): Remove. Windows are split in window.el.
284 (save_restore_action, save_restore_orig_size)
285 (shrink_window_lowest_first, save_restore_orig_size): Remove.
286 Resize mini windows in window.el.
287 (grow_mini_window, shrink_mini_window): Implement by calling
288 Qresize_root_window_vertically, resize_window_check and
289 resize_window_apply.
290 (saved_window, Fset_window_configuration, save_window_save): Do
291 not handle orig_top_line, orig_total_lines, and
292 resize_proportionally.
293 (window_min_height, window_min_width): Move to window.el.
294 (keys_of_window): Move bindings for delete-other-windows,
295 split-window, delete-window and enlarge-window to window.el.
296
297 * buffer.c: Temporarily extern Qdelete_window.
298 (Fbury_buffer): Temporarily call Qdelete_window instead of
299 Fdelete_window (Fbury_buffer will move to window.el soon).
300
301 * frame.c (set_menu_bar_lines_1): Remove code handling
302 orig_top_line and orig_total_lines.
303
304 * dispnew.c (adjust_frame_glyphs_initially): Don't use
305 set_window_height but set heights directly.
306 (change_frame_size_1): Use resize_frame_windows.
307
308 * xdisp.c (init_xdisp): Don't use set_window_height but set
309 heights directly.
310
311 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
312 resize_frame_windows instead of change_window_heights and run
313 run_window_configuration_change_hook.
314
315 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
316 instead of change_window_heights and run
317 run_window_configuration_change_hook.
318
1a13852e
MR
3192011-06-09 Martin Rudalics <rudalics@gmx.at>
320
321 * window.c (replace_window): Rename second argument REPLACEMENT to
322 NEW. New third argument SETFLAG. Rewrite.
323 (delete_window, make_dummy_parent): Call replace_window with
324 third argument 1.
325 (window_list_1): Move down in code.
326 (run_window_configuration_change_hook): Move set_buffer part
327 before select_frame_norecord part in order to unwind correctly.
328 Rename count1 to count.
329 (recombine_windows, delete_deletable_window, resize_root_window)
330 (Fdelete_other_windows_internal)
331 (Frun_window_configuration_change_hook, make_parent_window)
332 (resize_window_check, resize_window_apply, Fresize_window_apply)
333 (resize_frame_windows, Fsplit_window_internal)
334 (Fdelete_window_internal, Fresize_mini_window_internal): New
335 functions.
336 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
337
f3d1777e
MR
3382011-06-08 Martin Rudalics <rudalics@gmx.at>
339
496e208e
MR
340 * window.h (window): Add some new members to window structure -
341 normal_lines, normal_cols, new_total, new_normal, clone_number,
342 splits, nest, prev_buffers, next_buffers.
343 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 344 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 345
f3d1777e
MR
346 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
347 Remove.
496e208e
MR
348 (make_dummy_parent): Set new members of windows structure.
349 (make_window): Move down in code. Handle new members of window
350 structure.
351 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
352 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
353 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
354 (Fset_window_prev_buffers, Fwindow_next_buffers)
355 (Fset_window_next_buffers, Fset_window_clone_number): New
356 functions.
357 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
358 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
359 Doc-string fixes.
360 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
361 Argument WINDOW can be now internal window too.
362 (Fwindow_use_time): Move up in code.
363 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
364 Rewrite doc-string.
365 (Fset_window_configuration, saved_window)
366 (Fcurrent_window_configuration, save_window_save): Handle new
367 members of window structure.
b9e809c2
MR
368 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
369 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
370 (syms_of_window): New Lisp objects Qrecord_window_buffer,
371 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
372 Qget_mru_window, Qresize_root_window,
373 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
374 Qauto_buffer_name; staticpro them.
f3d1777e 375
abde8f8c
MR
3762011-06-07 Martin Rudalics <rudalics@gmx.at>
377
378 * window.c (Fwindow_total_size, Fwindow_left_column)
379 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
380 (Fwindow_list_1): New functions.
381 (window_box_text_cols): Replace with window_body_cols.
382 (Fwindow_width, Fscroll_left, Fscroll_right): Use
383 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
384 (delete_window, Fset_window_configuration): Call
385 delete_all_subwindows with window as argument.
386 (delete_all_subwindows): Take a window as argument and not a
387 structure. Rewrite.
190b47e6
MR
388 (window_loop): Remove handling of GET_LRU_WINDOW and
389 GET_LARGEST_WINDOW.
390 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
391
392 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
393 window_box_text_cols. delete_all_subwindows now takes a
394 Lisp_Object as argument.
abde8f8c
MR
395
396 * indent.c (compute_motion, Fcompute_motion): Use
397 window_body_cols instead of window_box_text_cols.
398
fa8a67e6
MR
399 * frame.c (delete_frame): Call delete_all_subwindows with root
400 window as argument.
401
a54e3482
DC
4022011-06-07 Daniel Colascione <dan.colascione@gmail.com>
403
404 * fns.c (Fputhash): Document return value.
405
60002bf5
CY
4062011-06-06 Chong Yidong <cyd@stupidchicken.com>
407
408 * image.c (gif_load): Implement gif89a spec "no disposal" method.
409
0c671da6 4102011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 411
b862a52a 412 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 413
be44ca6c
PE
414 Check for overflow when converting integer to cons and back.
415 * charset.c (Fdefine_charset_internal, Fdecode_char):
416 Use cons_to_unsigned to catch overflow.
417 (Fencode_char): Use INTEGER_TO_CONS.
418 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
419 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
420 * data.c (long_to_cons, cons_to_long): Remove.
421 (cons_to_unsigned, cons_to_signed): New functions.
422 These signal an error for invalid or out-of-range values.
423 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
424 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
425 * font.c (Ffont_variation_glyphs):
426 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
427 * lisp.h: Include <intprops.h>.
428 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
429 (cons_to_signed, cons_to_unsigned): New decls.
430 (long_to_cons, cons_to_long): Remove decls.
431 * undo.c (record_first_change): Use INTEGER_TO_CONS.
432 (Fprimitive_undo): Use CONS_TO_INTEGER.
433 * xfns.c (Fx_window_property): Likewise.
434 * xselect.c: Include <limits.h>.
435 (x_own_selection, selection_data_to_lisp_data):
436 Use INTEGER_TO_CONS.
437 (x_handle_selection_request, x_handle_selection_clear)
438 (x_get_foreign_selection, Fx_disown_selection_internal)
439 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
440 (lisp_data_to_selection_data): Use cons_to_unsigned.
441 (x_fill_property_data): Use cons_to_signed.
442 Report values out of range.
443
d1f3d2af
PE
444 Check for buffer and string overflow more precisely.
445 * buffer.h (BUF_BYTES_MAX): New macro.
446 * lisp.h (STRING_BYTES_MAX): New macro.
447 * alloc.c (Fmake_string):
448 * character.c (string_escape_byte8):
449 * coding.c (coding_alloc_by_realloc):
450 * doprnt.c (doprnt):
451 * editfns.c (Fformat):
452 * eval.c (verror):
453 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
454 since they may not be the same number.
455 * editfns.c (Finsert_char):
456 * fileio.c (Finsert_file_contents):
457 Likewise for BUF_BYTES_MAX.
458
dd52fcea
PE
459 * image.c: Use ptrdiff_t, not int, for sizes.
460 (slurp_file): Switch from int to ptrdiff_t.
461 All uses changed.
462 (slurp_file): Check that file size fits in both size_t (for
463 malloc) and ptrdiff_t (for sanity and safety).
464
7f9bbdbb
PE
465 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
466 if b->modtime has its maximal value.
467
dfe18f82
PE
468 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
469
84acfcf0
PE
470 Don't assume time_t can fit into int.
471 * buffer.h (struct buffer.modtime): Now time_t, not int.
472 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
473 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
474
ccd9a01a
PE
475 Minor fixes for signed vs unsigned integers.
476 * character.h (MAYBE_UNIFY_CHAR):
477 * charset.c (maybe_unify_char):
478 * keyboard.c (read_char, reorder_modifiers):
479 XINT -> XFASTINT, since the integer must be nonnegative.
480 * ftfont.c (ftfont_spec_pattern):
481 * keymap.c (access_keymap, silly_event_symbol_error):
482 XUINT -> XFASTINT, since the integer must be nonnegative.
483 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
484 since it makes no difference and we prefer signed.
485 * keyboard.c (record_char): Use XUINT when all the neighbors do.
486 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
487 nonnegative.
488
d6d100dd
SM
4892011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
490
491 * window.h (Fwindow_frame): Declare.
492
2b6148e4
PE
4932011-06-06 Paul Eggert <eggert@cs.ucla.edu>
494
495 * alloc.c: Simplify handling of large-request failures (Bug#8800).
496 (SPARE_MEMORY): Always define.
497 (LARGE_REQUEST): Remove.
498 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
499
f230ecc9
MR
5002011-06-06 Martin Rudalics <rudalics@gmx.at>
501
727e958e
MR
502 * lisp.h: Move EXFUNS for Fframe_root_window,
503 Fframe_first_window and Fset_frame_selected_window to window.h.
504
505 * window.h: Move EXFUNS for Fframe_root_window,
506 Fframe_first_window and Fset_frame_selected_window here from
507 lisp.h.
508
509 * frame.c (Fwindow_frame, Fframe_first_window)
510 (Fframe_root_window, Fframe_selected_window)
511 (Fset_frame_selected_window): Move to window.c.
512 (Factive_minibuffer_window): Move to minibuf.c.
513 (Fother_visible_frames_p): New function.
514
515 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
516
f230ecc9
MR
517 * window.c (decode_window, decode_any_window): Move up in code.
518 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
519 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
520 (Fwindow_buffer): Move up and rewrite doc-string.
521 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
522 (Fwindow_prev): New functions.
727e958e
MR
523 (Fwindow_frame): Move here from frame.c. Accept any window as
524 argument.
525 (Fframe_root_window, Fframe_first_window)
526 (Fframe_selected_window): Move here from frame.c. Accept frame
527 or arbitrary window as argument. Update doc-strings.
528 (Fminibuffer_window): Move up in code.
529 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
530 (Fset_frame_selected_window): Move here from frame.c.
531 Marginal rewrite.
727e958e
MR
532 (Fselected_window, select_window, Fselect_window): Move up in
533 code. Minor doc-string fixes.
f230ecc9 534
4d09bcf6
PE
5352011-06-06 Paul Eggert <eggert@cs.ucla.edu>
536
537 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
538 Do not assume that spare memory exists; that assumption is valid
539 only if SYSTEM_MALLOC.
540 (LARGE_REQUEST): New macro, so that the issue of large requests
541 is separated from the issue of spare memory.
542
810928a2
AS
5432011-06-05 Andreas Schwab <schwab@linux-m68k.org>
544
172418ad
AS
545 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
546 format. (Bug#8806)
547
43f862f7
AS
548 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
549
810928a2
AS
550 * xfns.c (x_set_scroll_bar_default_width): Move declarations
551 before statements.
552
a059fe24
JD
5532011-06-05 Jan Djärv <jan.h.d@swipnet.se>
554
555 * gtkutil.c (xg_get_default_scrollbar_width): New function.
556
557 * gtkutil.h: Declare xg_get_default_scrollbar_width.
558
559 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
560 min width by calling x_set_scroll_bar_default_width (Bug#8505).
561
989bf368
JB
5622011-06-05 Juanma Barranquero <lekktu@gmail.com>
563
564 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
565
4b80f674
CY
5662011-06-04 Chong Yidong <cyd@stupidchicken.com>
567
568 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
569 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
570 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
571 New error handlers.
4b80f674
CY
572 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
573 Obey Vx_select_enable_clipboard_manager. Catch errors in
574 x_clipboard_manager_save (Bug#8779).
575 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 576 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 577
99a33b77 5782011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
579
580 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
581
99a33b77 5822011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
583
584 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
585 in the current matrix if keep_current_p is non-zero.
586
8264569d
EZ
5872011-06-04 Eli Zaretskii <eliz@gnu.org>
588
589 * bidi.c (bidi_level_of_next_char): Fix last change.
590
57f97249
EZ
5912011-06-03 Eli Zaretskii <eliz@gnu.org>
592
fec2107c 593 Support bidi reordering of text covered by display properties.
57f97249 594
fec2107c
EZ
595 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
596 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
597 (bidi_cache_search, bidi_cache_iterator_state)
598 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
599 (bidi_level_of_next_char, bidi_move_to_visually_next):
600 Support character positions inside a run of characters covered by a
fec2107c
EZ
601 display string.
602 (bidi_paragraph_init, bidi_resolve_explicit_1)
603 (bidi_level_of_next_char): Call bidi_fetch_char and
604 bidi_fetch_char_advance instead of FETCH_CHAR and
605 FETCH_CHAR_ADVANCE.
606 (bidi_init_it): Initialize new members.
607 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
608 definitions.
609 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
610 instead of using explicit *_CHAR codes.
d6d100dd
SM
611 (bidi_resolve_explicit, bidi_resolve_weak):
612 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
613 bidirectional text is supported only in multibyte buffers.
614 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
615 it to initialize the frame_window_p member of struct bidi_it.
616 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
617 (bidi_resolve_explicit, bidi_resolve_weak)
618 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
619 bidi_it->nchars is non-positive.
620 (bidi_level_of_next_char): Don't try to lookup the cache for the
621 next/previous character if nothing is cached there yet, or if we
622 were just reseat()'ed to a new position.
c40e2fb2 623
0e14fe90
EZ
624 * xdisp.c (set_cursor_from_row): Set start and stop points
625 according to the row's direction when priming the loop that looks
626 for the glyph on which to display cursor.
627 (single_display_spec_intangible_p): Function deleted.
628 (display_prop_intangible_p): Reimplement to call
629 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
630 Accept 3 additional arguments needed by handle_display_spec.
631 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
632 values: lists, `(when COND...)' forms, etc.
633 (single_display_spec_string_p): Support property values that are
634 lists with the argument STRING its top-level element.
635 (display_prop_string_p): Fix the condition for processing a
636 property that is a list to be consistent with handle_display_spec.
fec2107c 637 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
638 last portion of handle_display_prop.
639 (compute_display_string_pos): Accept additional argument
640 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
641 value of a `display' property is a "replacing spec".
642 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
643 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
644 the display property, but just return a value indicating whether
645 the display property will replace the characters it covers.
646 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
647 frame_window_p members of struct bidi_it.
d6d100dd
SM
648 (compute_display_string_pos, compute_display_string_end):
649 New functions.
fec2107c
EZ
650 (push_it): Accept second argument POSITION, where pop_it should
651 jump to continue iteration.
652 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 653
fec2107c
EZ
654 * keyboard.c (adjust_point_for_property): Adjust the call to
655 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
656
657 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
658 (bidi_init_it): Update prototypes.
659 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
660 (compute_display_string_pos, compute_display_string_end):
661 Declare prototypes.
fec2107c
EZ
662 (struct bidi_it): New members nchars and disp_pos. ch_len is now
663 EMACS_INT.
fc6f18ce 664
40087514 6652011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 666
57f53182
PE
667 Malloc failure behavior now depends on size of allocation.
668 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
669 * lisp.h: Change signatures accordingly.
670 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
671 All callers changed. (Bug#8762)
672
673 * gnutls.c: Use Emacs's memory allocators.
674 Without this change, the gnutls library would invoke malloc etc.
675 directly, which causes problems on non-SYNC_INPUT hosts, and which
676 runs afoul of improving memory_full behavior. (Bug#8761)
677 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
678 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
679 xfree instead of the default malloc, realloc, free.
680 (Fgnutls_boot): No need to check for memory allocation failure,
681 since xmalloc does that for us.
682
ac32cd99 683 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
684 * category.c (hash_get_category_set):
685 * ccl.c (ccl_driver):
686 * charset.c (Fdefine_charset_internal):
687 * charset.h (struct charset.hash_index):
688 * composite.c (get_composition_id, gstring_lookup_cache)
689 (composition_gstring_put_cache):
690 * composite.h (struct composition.hash_index):
691 * dispextern.h (struct image.hash):
692 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
693 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
694 (hashfn_equal, hashfn_user_defined, make_hash_table)
695 (maybe_resize_hash_table, hash_lookup, hash_put)
696 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
697 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
698 (Fsxhash, Fgethash, Fputhash, Fmaphash):
699 * image.c (make_image, search_image_cache, lookup_image)
700 (xpm_put_color_table_h):
701 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 702 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
703 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
704 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
705 * alloc.c (allocate_vectorlike):
706 Check for overflow in vector size calculations.
707 * ccl.c (ccl_driver):
708 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
709 * fns.c, image.c: Remove unnecessary static decls that would otherwise
710 need to be updated by these changes.
40087514
PE
711 * fns.c (make_hash_table, maybe_resize_hash_table):
712 Check for integer overflow with large hash tables.
0de4bb68
PE
713 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
714 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
715 (SXHASH_REDUCE): New macro.
716 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
717 Use it instead of discarding useful hash info with large hash values.
718 (sxhash_float): New function.
719 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
720 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
721 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
722 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
723 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
724 Adjust signatures to match updated version of code.
725 (consing_since_gc): Now EMACS_INT, since a single hash table can
726 use more than INT_MAX bytes.
727
698d32e2
DN
7282011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
729
730 Make it possible to build with GCC-4.6+ -O2 -flto.
731
732 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
733
fd6fa53f
SM
7342011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
735
736 * minibuf.c (get_minibuffer, read_minibuf_unwind):
737 Call minibuffer-inactive-mode.
738
864db017
JB
7392011-05-31 Juanma Barranquero <lekktu@gmail.com>
740
741 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
742 Update dependencies.
743
2ad0baf4
DN
7442011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
745
746 * data.c (init_data): Remove code for UTS, this system is not
747 supported anymore.
748
4fcc2638
DN
7492011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
750
751 Don't force ./temacs to start in terminal mode.
752
753 * frame.c (make_initial_frame): Initialize faces in all cases, not
754 only when CANNOT_DUMP is defined.
755 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
756
c56e0fd5
DN
7572011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
758
759 * dispnew.c (add_window_display_history): Use const for the string
760 pointer. Remove declaration, not needed.
761
333d54da 7622011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 763
55d4c1b2 764 Use 'inline', not 'INLINE'.
333d54da 765 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
766 * alloc.c, fontset.c (INLINE): Remove.
767 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
768 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
769 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
770 * gmalloc.c (register_heapinfo): Use inline unconditionally.
771 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
772
738db178
DN
7732011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
774
775 Make it possible to run ./temacs.
776
777 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
778 syms_of_callproc does the same thing. Remove test for
779 "initialized", do it in the caller.
780 * emacs.c (main): Avoid calling set_initial_environment when dumping.
781
620c53a6
SM
7822011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
783
784 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
785 (read_minibuf): Use get_minibuffer.
786 (syms_of_minibuf): Use DEFSYM.
787 (Qmetadata): New var.
788 * data.c (Qbuffer): Don't make it static.
789 (syms_of_data): Use DEFSYM.
790
e003a292
PE
7912011-05-31 Paul Eggert <eggert@cs.ucla.edu>
792
793 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
794 (CCL_CODE_MIN): New macro.
795
ed008a6d
PE
7962011-05-30 Paul Eggert <eggert@cs.ucla.edu>
797
3687c2ef
PE
798 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
799
ed008a6d
PE
800 * eval.c (Qdebug): Now static.
801 * lisp.h (Qdebug): Remove decl. This reverts a part of the
802 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
803 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
804
d66c4c7c
CY
8052011-05-29 Chong Yidong <cyd@stupidchicken.com>
806
807 * image.c: Various fixes to ImageMagick code comments.
808 (Fimagemagick_types): Doc fix.
809
5fbc2025
PE
8102011-05-29 Paul Eggert <eggert@cs.ucla.edu>
811
0196f88a
PE
812 Minor fixes prompted by GCC 4.6.0 warnings.
813
814 * xselect.c (converted_selections, conversion_fail_tag): Now static.
815
5fbc2025
PE
816 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
817 (x_clipboard_manager_save_all): Move extern decl to ...
818 * xterm.h: ... here, so that it can be checked for consistency.
819
1dd3c2d9
CY
8202011-05-29 Chong Yidong <cyd@stupidchicken.com>
821
822 * xselect.c (x_clipboard_manager_save_frame)
823 (x_clipboard_manager_save_all): New functions.
824 (Fx_clipboard_manager_save): Lisp function deleted.
825
826 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
827 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
828
829 * xterm.h: Update prototype.
830
5ba6571d
WX
8312011-05-28 William Xu <william.xwl@gmail.com>
832
833 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
834 exiting (Bug#8239).
835
3eaff834
JM
8362011-05-28 Jim Meyering <meyering@redhat.com>
837
e1900994 838 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
839 * fns.c (to_uchar): Define.
840 (crypto_hash_function): Use it to convert some newly-signed
841 variables to unsigned, to avoid sign-extension bugs. For example,
842 without this change, (md5 "truc") would evaluate to
843 45723a2aff78ff4fff7fff1114760e62 rather than the expected
844 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 845 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 846
0f6990a7
PE
8472011-05-27 Paul Eggert <eggert@cs.ucla.edu>
848
849 Integer overflow fixes.
c8a9ca5a 850
08686060
PE
851 * dbusbind.c: Serial number integer overflow fixes.
852 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
853 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
854 to hold a serial number that is too large for a fixnum.
855 (Fdbus_method_return_internal, Fdbus_method_error_internal):
856 Check for serial numbers out of range. Decode any serial number
59568bf0 857 that was so large that it became a float. (Bug#8722)
08686060 858
2d1fc3c7
PE
859 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
860 (Fdbus_call_method, Fdbus_call_method_asynchronously):
861 Use XFASTINT rather than XUINT when numbers are nonnegative.
862 (xd_append_arg, Fdbus_method_return_internal):
863 (Fdbus_method_error_internal): Likewise. Also, for unsigned
864 arguments, check that Lisp number is nonnegative, rather than
59568bf0 865 silently wrapping negative numbers around. (Bug#8722)
30217ff0 866 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 867 (Bug#8722)
2d1fc3c7 868
c8a9ca5a
PE
869 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
870
519e1d69
PE
871 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
872
30569699
PE
873 ccl: add integer overflow checks
874 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
875 (IN_INT_RANGE): New macros.
876 (ccl_driver): Use them to check for integer overflow when
877 decoding a CCL program. Many of the new checks are whether XINT (x)
878 fits in int; it doesn't always, on 64-bit hosts. The new version
879 doesn't catch all possible integer overflows, but it's an
847044ea 880 improvement. (Bug#8719)
30569699 881
c11285dc
PE
882 * alloc.c (make_event_array): Use XINT, not XUINT.
883 There's no need for unsigned here.
884
fdccd48e
PE
885 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
886 This follows up to the 2011-05-06 change that substituted uintptr_t
887 for EMACS_INT. This case wasn't caught back then.
888
37910ab2
PE
889 Rework Fformat to avoid integer overflow issues.
890 * editfns.c: Include <float.h> unconditionally, as it's everywhere
891 now (part of C89). Include <verify.h>.
892 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
893 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
894 (Fformat): Avoid the prepass trying to compute sizes; it was only
895 approximate and thus did not catch overflow reliably. Instead, walk
896 through the format just once, formatting and computing sizes as we go,
897 checking for integer overflow at every step, and allocating a larger
898 buffer as needed. Keep track separately whether the format is
899 multibyte. Keep only the most-recently calculated precision, rather
900 than them all. Record whether each argument has been converted to
901 string. Use EMACS_INT, not int, for byte and char and arg counts.
902 Support field widths and precisions larger than INT_MAX. Avoid
903 sprintf's undefined behavior with conversion specifications such as %#d
904 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
905 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
906 formatting out-of-range floating point numbers with int
907 formats. (Bug#8668)
908
2e6578fb
PE
909 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
910
0ae6bdee
PE
911 * data.c: Avoid integer truncation in expressions involving floats.
912 * data.c: Include <intprops.h>.
913 (arith_driver): When there's an integer overflow in an expression
914 involving floating point, convert the integers to floating point
915 so that the resulting value does not suffer from catastrophic
916 integer truncation. For example, on a 64-bit host (* 4
917 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
918 Do not rely on undefined behavior after integer overflow.
919
de883a70
PE
920 merge count_size_as_multibyte, parse_str_to_multibyte
921 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 922 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
923 Check for integer overflow.
924 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
925 since it's now a duplicate of the other. This is more of
926 a character than a buffer op, so better that it's in character.c.
927 * fns.c, print.c: Adjust to above changes.
928
2ff916cb
PE
9292011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
930
931 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
932
f1b54466
PE
9332011-05-27 Paul Eggert <eggert@cs.ucla.edu>
934
fb1ac845
PE
935 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
936 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
937 (x_clipboard_manager_save): Now static.
938 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
939
f1b54466
PE
940 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
941 (crypto_hash_function): Now static.
942 Fix pointer signedness problems. Avoid unnecessary initializations.
943
a9f737ee
CY
9442011-05-27 Chong Yidong <cyd@stupidchicken.com>
945
946 * termhooks.h (Vselection_alist): Make it terminal-local.
947
948 * terminal.c (create_terminal): Initialize it.
949
950 * xselect.c: Support for clipboard managers.
951 (Vselection_alist): Move to termhooks.h as terminal-local var.
952 (LOCAL_SELECTION): New macro.
953 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
954 (symbol_to_x_atom): Remove gratuitous arg.
955 (x_handle_selection_request, lisp_data_to_selection_data)
956 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
957 (x_own_selection, x_get_local_selection, x_convert_selection):
958 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
959 (some_frame_on_display): Delete unused function.
960 (Fx_own_selection_internal, Fx_get_selection_internal)
961 (Fx_disown_selection_internal, Fx_selection_owner_p)
962 (Fx_selection_exists_p): New optional frame arg.
963 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
964 (x_handle_selection_clear): Don't treat other terminals with the
965 same keyboard specially. Use the terminal-local Vselection_alist.
966 (x_clear_frame_selections): Use Frun_hook_with_args.
967
968 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
969
970 * xterm.h: Add support for those atoms.
971
e067f0c1
CY
9722011-05-26 Chong Yidong <cyd@stupidchicken.com>
973
974 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
975 (converted_selections, conversion_fail_tag): New global variables.
976 (x_selection_request_lisp_error): Free the above.
977 (x_get_local_selection): Remove unnecessary code.
978 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
979 of converted selections stored in converted_selections.
980 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
981 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
982 (x_convert_selection): New function.
983 (x_handle_selection_event): Simplify.
984 (x_get_foreign_selection): Don't ignore incoming requests while
985 waiting for an answer; this will fail when we implement
986 SAVE_TARGETS, and seems unnecessary anyway.
987 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
988 (Vx_sent_selection_functions): Doc fix.
989
0f4aebc0
LL
9902011-05-26 Leo Liu <sdl.web@gmail.com>
991
992 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
993
e61124cd
YM
9942011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
995
996 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
997
998 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
999 for fringe update if it has periodic bitmap.
1000 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1001 and fringe_bitmap_periodic_p.
1002
1003 * fringe.c (get_fringe_bitmap_data): New function.
1004 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1005 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1006 row. Mark glyph row for fringe update if periodicity changed.
1007
1008 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1009 for fringe update unless it has periodic bitmap.
1010
f16d9837
KH
10112011-05-25 Kenichi Handa <handa@m17n.org>
1012
1013 * xdisp.c (get_next_display_element): Set correct it->face_id for
1014 a static composition.
1015
e1b90ef6
LL
10162011-05-24 Leo Liu <sdl.web@gmail.com>
1017
1018 * deps.mk (fns.o):
1019 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1020
1021 * fns.c (crypto_hash_function, Fsha1): New function.
1022 (Fmd5): Use crypto_hash_function.
1023 (syms_of_fns): Add Ssha1.
1024
7400048f
PE
10252011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1026
1027 * gnutls.c: Remove unused macros.
1028 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1029 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1030 Remove macros that are defined and never used.
1031 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1032
abb71cf4
CY
10332011-05-22 Chong Yidong <cyd@stupidchicken.com>
1034
1035 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1036 (Fx_get_selection_internal): Minor cleanup.
1037 (Fx_own_selection_internal): Rename arguments for consistency with
1038 select.el.
1039
6307db39
PE
10402011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1041
1042 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1043
f3d4e0a4
CY
10442011-05-22 Chong Yidong <cyd@stupidchicken.com>
1045
1046 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1047
4d8ade89
YM
10482011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1049
1050 * dispnew.c (scrolling_window): Don't exclude the case that the
1051 last enabled row in the desired matrix touches the bottom boundary.
1052
32078c8d
GM
10532011-05-21 Glenn Morris <rgm@gnu.org>
1054
1055 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
1056 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1057 and add some more files.
32078c8d 1058
7285dc67
EZ
10592011-05-20 Eli Zaretskii <eliz@gnu.org>
1060
1061 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1062 report_file_error introduced by the change from 2011-05-07.
1063
89d1bd22
PE
10642011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1065
1066 * systime.h (Time): Define only if emacs is defined.
1067 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1068 where the include path doesn't have X11/X.h by default. See
1069 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1070
e23640bb 10712011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
1072
1073 * composite.c (find_automatic_composition): Fix previous change.
1074
b9704ad9
GM
10752011-05-20 Glenn Morris <rgm@gnu.org>
1076
1077 * lisp.mk: New file, split from Makefile.in.
1078 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1079 (shortlisp): Remove.
1080 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1081
4a720484
GM
10822011-05-19 Glenn Morris <rgm@gnu.org>
1083
1084 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1085 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1086 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1087 (lisp): Set the order to that of loadup.el.
1088 (shortlisp): Make it a copy of $lisp.
1089 (SOME_MACHINE_LISP): Remove.
1090 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1091 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1092
a28d4396
KH
10932011-05-18 Kenichi Handa <handa@m17n.org>
1094
1095 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1096 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1097 (find_automatic_composition): Mostly rewrite for efficiency.
1098
a2b1fa8e
JB
10992011-05-18 Juanma Barranquero <lekktu@gmail.com>
1100
1101 * makefile.w32-in: Update dependencies.
1102
8e1f5610
CS
11032011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1104
1105 * menu.c: Include limits.h (fixes the MS-Windows build broken by
1106 revision 104625).
1107
7025ee00 11082011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 1109
cdfa6eab
PE
1110 Fix some integer overflow issues, such as string length overflow.
1111
06d6db33
PE
1112 * insdel.c (count_size_as_multibyte): Check for string overflow.
1113
2b4560a8
PE
1114 * character.c (lisp_string_width): Check for string overflow.
1115 Use EMACS_INT, not int, for string indexes and lengths; in
1116 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1117 the resulting string length overflows an EMACS_INT; instead,
1118 report a string overflow if no precision given. When checking for
1119 precision exhaustion, use a check that cannot possibly have
1120 integer overflow. (Bug#8675)
1121 * character.h (lisp_string_width): Adjust to new signature.
1122
cb93f9be
PE
1123 * alloc.c (string_overflow): New function.
1124 (Fmake_string): Use it. This doesn't change behavior, but saves
1125 a few bytes and will simplify future changes.
1126 * character.c (string_escape_byte8): Likewise.
1127 * lisp.h (string_overflow): New decl.
1128
1a1f3366
PE
1129 Fixups, following up to the user-interface timestamp change.
1130 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1131 for UI timestamps, instead of unsigned long.
9fbd6841
PE
1132 * msdos.c (mouse_get_pos): Likewise.
1133 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
1134 * w32gui.h (Time): Define by including "systime.h" rather than by
1135 declaring it ourselves. (Bug#8664)
1136
d4e3e4d3
PE
1137 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1138 * image.c (clear_image_cache): Likewise.
1139
f6a24d19
PE
1140 * term.c (term_mouse_position): Don't assume time_t wraparound.
1141
08dc5ae6
PE
1142 Be more systematic about user-interface timestamps.
1143 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
1144 and sometimes 'EMACS_UINT', to represent these timestamps.
1145 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
1146 This makes the code easier to follow, and makes it easier to catch
1147 integer overflow bugs such as Bug#8664.
1148 * frame.c (Fmouse_position, Fmouse_pixel_position):
1149 Use Time, not unsigned long, for user-interface timestamps.
1150 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1151 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1152 * keyboard.h (last_event_timestamp): Likewise.
1153 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1154 * menu.h (xmenu_show): Likewise.
1155 * term.c (term_mouse_position): Likewise.
1156 * termhooks.h (struct input_event.timestamp): Likewise.
1157 (struct terminal.mouse_position_hook): Likewise.
1158 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1159 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1160 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1161 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1162 what it was before.
1163 * menu.h, termhooks.h: Include "systime.h", for Time.
1164
8e55734a
PE
1165 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1166 Don't assume that the difference between two unsigned long values
1167 can fit into an integer. At this point, we know button_down_time
1168 <= event->timestamp, so the difference must be nonnegative, so
1169 there's no need to cast the result if double-click-time is
1170 nonnegative, as it should be; check that it's nonnegative, just in
1171 case. This bug is triggered when events are more than 2**31 ms
86db42d2 1172 apart (about 25 days). (Bug#8664)
8e55734a 1173
841f1b75 1174 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 1175 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 1176
3e26f69c
PE
1177 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1178 that always fit in int. Use a sentinel instead of a counter, to
1179 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
1180 * frame.h (struct frame): Use int for menu_bar_items_used
1181 instead of EMACS_INT, since it always fits in int.
3e26f69c 1182
5cc152c0
PE
1183 * menu.c (grow_menu_items): Check for int overflow.
1184
d89eb65e
PE
1185 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1186
5235bd3e
PE
1187 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1188 Before, the code was not consistent. These values cannot exceed
1189 2**31 - 1 so there's no need to make them unsigned.
1190 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1191 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1192 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1193 as modifiers.
1194 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1195
bc827e23
PE
1196 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1197 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1198 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1199 presumably because the widths might not match.
1200
78eb494e
PE
1201 * window.c (size_window): Avoid needless test at loop start.
1202
04f2d78b
CB
12032011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1204
1205 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1206
d2fc7e3d 12072011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
1208
1209 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1210
d2fc7e3d 12112011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
1212
1213 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1214 `width' to `bar_area_x' and `bar_area_width', respectively.
1215 (x_scroll_run): Take account of fringe background extension.
1216
04f2d78b
CB
1217 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1218 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
1219 `bar_area_width', respectively.
1220 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1221 background extension.
1222
79b70037
GM
12232011-05-10 Jim Meyering <meyering@redhat.com>
1224
1225 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1226
2f142cc5
JB
12272011-05-10 Juanma Barranquero <lekktu@gmail.com>
1228
1229 * image.c (Finit_image_library): Return t for built-in image types,
1230 like pbm and xbm. (Bug#8640)
1231
57679c86
AS
12322011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1233
1234 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1235
888c9e86
EZ
12362011-05-07 Eli Zaretskii <eliz@gnu.org>
1237
b0512a1d
EZ
1238 * w32console.c (Fset_screen_color): Doc fix.
1239 (Fget_screen_color): New function.
1240 (syms_of_ntterm): Defsubr it.
1241
7285dc67
EZ
1242 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1243 unlink the temporary file if Fcall_process didn't create it in the
1244 first place.
1245 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1246 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
1247 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1248 cue to call_process_cleanup not to close that handle.
1249
4d3fcc8e
BK
12502011-05-07 Ben Key <bkey76@gmail.com>
1251
1252 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1253 one of two shell specific rules, either bootstrap-temacs-CMD or
1254 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1255 to the previous implementation of the bootstrap-temacs rule.
1256 The bootstrap-temacs-CMD rule is similar to the previous
1257 implementation of the bootstrap-temacs rule except that it
1258 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1259 variable.
1260
1261 These changes, along with some changes to nt/configure.bat,
1262 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1263 earlier fix to add support for --cflags and --ldflags options
1264 that include quotes so that it works whether make uses cmd or
1265 sh as the shell.
1266
b4289b64
MA
12672011-05-06 Michael Albinus <michael.albinus@gmx.de>
1268
1269 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1270 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1271 is a constant.
1272 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1273 a string. Handle both cases.
1274 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1275 (Fdbus_register_method): Use Qinvalid_function.
1276
af4c0e28
JB
12772011-05-06 Juanma Barranquero <lekktu@gmail.com>
1278
1279 * makefile.w32-in: Update dependencies.
1280 (LISP_H): Add inttypes.h and stdin.h.
1281 (PROCESS_H): Add unistd.h.
1282
c51453d9
EZ
12832011-05-06 Eli Zaretskii <eliz@gnu.org>
1284
1285 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1286 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1287
8ff0ac3c 12882011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 1289
4c4b566b
PE
1290 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1291
aab2b9b5
PE
1292 * term.c (vfatal): Remove stray call to va_end.
1293 It's not needed and the C Standard doesn't allow it here anyway.
1294
c378da0b
PE
1295 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1296 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1297
288b08c7
PE
1298 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1299 bytes.
1300
e3601888
PE
1301 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1302
db6c0e74
PE
1303 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1304
dd5963ea
PE
1305 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1306
88c9450f
PE
1307 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1308
2f9442b8
PE
1309 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1310
c032b5f8
PE
1311 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1312 * charset.c (Fdefine_charset_internal): Don't initialize
1313 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 1314 32-bit int (Bug#8600).
a108c10b
PE
1315
1316 * lread.c (read_integer): Be more consistent with string-to-number.
1317 Use string_to_number to do the actual conversion; this avoids
1318 rounding errors and fixes some other screwups. Without this fix,
1319 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1320 (digit_to_number): Move earlier, for benefit of read_integer.
1321 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 1322 not a digit in any supported base. (Bug#8602)
a108c10b 1323
ad5f9eea
PE
1324 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1325
aec1708a
PE
1326 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1327 to match comment at start of function. This also removes a
1328 GCC warning about overflow in a 32+64-bit port.
1329
47be4ab5
PE
1330 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1331
371cac43
PE
1332 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1333 Reported by Stefan Monnier in
1334 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
1335 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1336 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 1337
d01a7826
PE
1338 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1339 (EMACS_UINTPTR): Likewise, with uintptr_t.
1340
7fd47d5c
PE
1341 * lisp.h: Prefer 64-bit EMACS_INT if available.
1342 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1343 on 32-bit hosts that have 64-bit int, so that they can access
1344 large files.
122b0c86
PE
1345 However, temporarily disable this change unless the temporary
1346 symbol WIDE_EMACS_INT is defined.
7fd47d5c 1347
8727937b
PE
1348 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1349
8ac068ac
PE
1350 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1351 This removes an assumption that EMACS_INT and long are the same
1352 width as pointers. The assumption is true for Emacs porting targets
1353 now, but we want to make other targets possible.
1354 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1355 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1356 In the rest of the code, change types of integers that hold casted
1357 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1358 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1359 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1360 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1361 No need to cast type when ORing.
1362 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1363 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1364 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1365 assume EMACS_INT is the same width as char *.
1366 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1367 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1368 Remove no-longer-needed casts.
1369 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1370 (xg_tool_bar_help_callback, xg_make_tool_item):
1371 Use EMACS_INTPTR to hold an integer
1372 that will be cast to void *; this can avoid a GCC warning
1373 if EMACS_INT is not the same width as void *.
1374 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1375 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1376 (current_message_1, set_message_1):
1377 Use a local to convert to proper width without a cast.
1378 * xmenu.c (dialog_selection_callback): Likewise.
1379
ede49d71
PE
1380 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1381 Also, don't assume VALBITS / RAND_BITS is less than 5,
1382 and don't rely on undefined behavior when shifting a 1 left into
1383 the sign bit.
1384 * lisp.h (get_random): Change signature to match.
1385
2f30ecd0
PE
1386 * lread.c (hash_string): Use size_t, not int, for hash computation.
1387 Normally we prefer signed values; but hashing is special, because
1388 it's better to use unsigned division on hash table sizes so that
1389 the remainder is nonnegative. Also, size_t is the natural width
1390 for hashing into memory. The previous code used 'int', which doesn't
1391 retain enough info to hash well into very large tables.
1392 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1393
2a866e7b
PE
1394 * dbusbind.c: Don't possibly lose pointer info when converting.
1395 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1396 Use XPNTR rather than XHASH, so that the high-order bits of
1397 the pointer aren't lost when converting through void *.
1398
51639eac
PE
1399 * eval.c (Fautoload): Don't double-shift a pointer.
1400
92394119
PE
1401 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1402
dbdb9a7c
JB
14032011-05-06 Juanma Barranquero <lekktu@gmail.com>
1404
1405 * gnutls.c (DEF_GNUTLS_FN):
1406 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1407
db7a0b4f
AS
14082011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1409
1410 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1411 marker. (Bug#8610)
1412
f7ff1b0f 14132011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
1414
1415 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1416 New version that can reserve upto 2GB of heap space.
1417
f7ff1b0f 14182011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
1419
1420 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1421
639c109b
TZ
14222011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1423
1424 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1425 `gnutls_certificate_set_x509_key_file'.
1426
d2127135
JB
14272011-05-05 Juanma Barranquero <lekktu@gmail.com>
1428
1429 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1430 Update dependencies.
1431
e968f4f3
JB
14322011-05-04 Juanma Barranquero <lekktu@gmail.com>
1433
1434 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1435 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1436 Remove unused parameter `fildes'.
1437 * process.c (read_process_output, send_process): Don't pass it.
1438
84d358f0
JB
14392011-05-04 Juanma Barranquero <lekktu@gmail.com>
1440
1441 Fix previous change: the library cache is defined in w32.c.
1442 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1443 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1444
0898ca10
JB
14452011-05-04 Juanma Barranquero <lekktu@gmail.com>
1446
1447 Implement dynamic loading of GnuTLS on Windows.
1448
1449 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1450 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1451 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1452 Declare.
1453
1454 * gnutls.c (Qgnutls_dll): Define.
1455 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1456 (gnutls_*): Declare function pointers.
1457 (init_gnutls_functions): New function to initialize function pointers.
1458 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1459 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1460 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1461 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1462 (emacs_gnutls_write, emacs_gnutls_read)
1463 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1464 (Fgnutls_available_p): New function.
1465 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1466 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1467 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1468
1469 * image.c: Include w32.h.
1470 (Vimage_type_cache): Delete.
1471 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1472 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1473 (w32_delayed_load): Move to w32.c.
1474
1475 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1476
1477 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1478 (w32_delayed_load): Move from image.c. When loading a library, record
1479 its filename in the :loaded-from property of the library id.
1480 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1481 Initialize and staticpro them.
1482 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1483
1484 * process.c: Include lisp.h before w32.h, not after.
1485 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1486 instead of gnutls_record_check_pending.
1487
1488 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1489
ff4de4aa
TZ
14902011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1491
1492 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1493 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1494 as passed in.
1495
abe95abb
JD
14962011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1497
1498 * xterm.c (x_set_frame_alpha): Do not set property on anything
1499 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1500
e16e55d4
JB
15012011-05-02 Juanma Barranquero <lekktu@gmail.com>
1502
1503 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1504
bafcf6a5
JB
15052011-05-02 Juanma Barranquero <lekktu@gmail.com>
1506
1507 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1508 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1509 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1510 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1511 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1512 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1513 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1514 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1515 (Qgnutls_bootprop_callbacks_verify): Make static.
1516
e7a6747f
AS
15172011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1518
19ed11ba
AS
1519 * callproc.c: Indentation fixup.
1520
e7a6747f 1521 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
1522 (wait_for_termination, interruptible_wait_for_termination):
1523 Move after wait_for_termination_1.
e7a6747f 1524
1ef14cb4
LMI
15252011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1526
1527 * sysdep.c (interruptible_wait_for_termination): New function
1528 which is like wait_for_termination, but allows keyboard
1529 interruptions.
1530
1531 * callproc.c (Fcall_process): Add (:file "file") as an option for
1532 the STDOUT buffer.
1533 (Fcall_process_region): Ditto.
1534
330d880c
EZ
15352011-04-30 Eli Zaretskii <eliz@gnu.org>
1536
8db90b73
EZ
1537 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1538 rather than `XVECTOR (FOO)->size'.
1539
330d880c
EZ
1540 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1541 inttypes.h, as a gnulib replacement is used if it not available in
1542 system headers.
1543
15cbd324
EZ
15442011-04-21 Eli Zaretskii <eliz@gnu.org>
1545
1546 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1547 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1548 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1549
1550 * coding.c (coding_alloc_by_realloc): Error out if destination
1551 will grow beyond MOST_POSITIVE_FIXNUM.
1552 (decode_coding_emacs_mule): Abort if there isn't enough place in
1553 charbuf for the composition carryover bytes. Reserve an extra
1554 space for up to 2 characters produced in a loop.
1555 (decode_coding_iso_2022): Abort if there isn't enough place in
1556 charbuf for the composition carryover bytes.
1557
15582011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 1559
ae940cca
EZ
1560 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1561 aborting when %lld or %lll format is passed.
1562 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1563 %llo or %llx format is passed. (Bug#8545)
1564
03ab8921
EZ
1565 * window.c (window_scroll_line_based): Use a marker instead of
1566 simple variables to record original value of point. (Bug#7952)
1567
afda1437
EZ
1568 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1569 produced by %s or %c overflows available buffer space. (Bug#8545)
1570
f76dee0c
PE
15712011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1572
1573 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 1574 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 1575
fdc5744d
JB
15762011-04-28 Juanma Barranquero <lekktu@gmail.com>
1577
1578 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1579
638f053a
JB
15802011-04-28 Juanma Barranquero <lekktu@gmail.com>
1581
1582 * keyboard.c (Qdelayed_warnings_hook): Define.
1583 (command_loop_1): Run `delayed-warnings-hook'
1584 if Vdelayed_warnings_list is non-nil.
1585 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1586 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1587
d178f871
EZ
15882011-04-28 Eli Zaretskii <eliz@gnu.org>
1589
1590 * doprnt.c (doprnt): Don't return value smaller than the buffer
1591 size if the message was truncated. (Bug#8545).
1592
b124fd93
JB
15932011-04-28 Juanma Barranquero <lekktu@gmail.com>
1594
1595 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1596 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1597
e810457d
PE
15982011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1599
1600 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1601
ea51cceb
JB
16022011-04-27 Juanma Barranquero <lekktu@gmail.com>
1603
1604 * makefile.w32-in: Update dependencies.
1605
94dcfacf
EZ
16062011-04-27 Eli Zaretskii <eliz@gnu.org>
1607
1608 Improve `doprnt' and its usage. (Bug#8545)
1609 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1610 `format_end'. Remove support for %l as a conversion specifier.
1611 Don't use xrealloc. Improve diagnostics when the %l size modifier
1612 is used. Update the commentary.
1613
1614 * eval.c (verror): Simplify calculation of size_t.
1615
1616 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1617 messages.
1618
f61f41d7
PE
16192011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1620
1621 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1622 change.
1623
96fb4434
PE
16242011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1625
1626 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1627 This makes this file independent of the recent pseudovector change.
1628
671875da 16292011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 1630
69e9b5a3
PE
1631 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1632
b5f869a7 1633 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 1634 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 1635 Remove unused local.
c8926152 1636 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 1637
841a1577 1638 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
1639 GCC 4.6.0 optimizes based on type-based alias analysis.
1640 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
1641 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1642 != &v->size, and therefore "v->size = 1; b->size = 2; return
1643 v->size;" must therefore return 1. This assumption is incorrect
1644 for Emacs, since it type-puns struct Lisp_Vector * with many other
1645 types. To fix this problem, this patch adds a new type struct
f904488f 1646 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
1647 and pseudovectors, and helps optimizing compilers not get fooled
1648 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1649 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
1650 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1651 the size member.
eab3844f
PE
1652 (XSETPVECTYPE): Rewrite in terms of new macro.
1653 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1654 This is a bit clearer, and further avoids the possibility of
1655 undesirable aliasing.
1656 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 1657 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
1658 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1659 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
1660 (ASIZE): Now uses header.size rather than size.
1661 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
1662 to avoid the hassle of writing XVECTOR (foo)->header.size.
1663 (struct vectorlike_header): New type.
eab3844f
PE
1664 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1665 object, to help avoid aliasing.
1666 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1667 (SUBRP): Likewise, since Lisp_Subr is a special case.
1668 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1669 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1670 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 1671 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
1672 changed to be "header.size" and "header.next".
1673 * buffer.h (struct buffer): Likewise.
1674 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1675 * frame.h (struct frame): Likewise.
1676 * process.h (struct Lisp_Process): Likewise.
1677 * termhooks.h (struct terminal): Likewise.
1678 * window.c (struct save_window_data, struct saved_window): Likewise.
1679 * window.h (struct window): Likewise.
1680 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1681 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1682 * buffer.c (init_buffer_once): Likewise.
1683 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1684 special case.
1685 * process.c (Fformat_network_address): Use local var for size,
1686 for brevity.
1687
0df1eac5
PE
1688 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1689
847ab9d1 1690 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
1691 * data.c (atof): Remove decl; no longer used or needed.
1692 (digit_to_number): Move to lread.c.
1693 (Fstring_to_number): Use new string_to_number function, to be
1694 consistent with how the Lisp reader treats infinities and NaNs.
1695 Do not assume that floating-point numbers represent EMACS_INT
1696 without losing information; this is not true on most 64-bit hosts.
1697 Avoid double-rounding errors, by insisting on integers when
1698 parsing non-base-10 numbers, as the documentation specifies.
1699 * lisp.h (string_to_number): New decl, replacing ...
1700 (isfloat_string): Remove.
bc0a5c13 1701 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 1702 (read1): Do not accept +. and -. as integers; this
452f4150
PE
1703 appears to have been a coding error. Similarly, do not accept
1704 strings like +-1e0 as floating point numbers. Do not report
1705 overflow for integer overflows unless the base is not 10 which
1706 means we have no simple and reliable way to continue.
1707 Break out the floating-point parsing into a new
1708 function string_to_number, so that Fstring_to_number parses
1709 floating point numbers consistently with the Lisp reader.
04f2d78b 1710 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
1711 (E_CHAR, EXP_INT): Remove, replacing with ...
1712 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1713 (string_to_number): New function, replacing isfloat_string.
1714 This function checks for valid syntax and produces the resulting
1715 Lisp float number too. Rework it so that string-to-number
bc0a5c13 1716 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
1717 so that overflow for non-base-10 numbers is reported only when
1718 there's no portable and simple way to convert to floating point.
452f4150 1719
67769ffc
PE
1720 * textprop.c (set_text_properties_1): Rewrite for clarity,
1721 and to avoid GCC warning about integer overflow.
1722
c20db43f
PE
1723 * intervals.h (struct interval): Use EMACS_INT for members
1724 where EMACS_UINT might cause problems. See
1725 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1726 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1727 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1728 All uses changed.
37aa2f85
PE
1729 (offset_intervals): Tell GCC not to worry about length overflow
1730 when negating a negative length.
c20db43f 1731
2538aa2f
PE
1732 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1733 (overrun_check_free): Likewise.
1734
f2d3008d
PE
1735 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1736 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1737 word size.
1738
ec8df744
PE
1739 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1740 (gnutls_make_error): Rename local to avoid shadowing.
1741 (gnutls_emacs_global_deinit): ifdef out; not used.
1742 (Fgnutls_boot): Use const for pointer to readonly storage.
1743 Comment out unused local. Fix pointer signedness problems.
1744
640ee02d
PE
1745 * lread.c (openp): Don't stuff size_t into an 'int'.
1746 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
1747 about possible signed overflow.
1748
6048fb2a
PE
1749 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1750 (GDK_KEY_g): Don't define if already defined.
1751 (xg_prepare_tooltip): Avoid pointer signedness problem.
1752 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
1753
fa3c87e1
PE
1754 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
1755 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
1756
2172544b
PE
1757 * xfns.c (Fx_window_property): Simplify a bit,
1758 to make a bit faster and to avoid GCC 4.6.0 warning.
1759 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
1760
9b821a21
PE
1761 * fns.c (internal_equal): Don't assume size_t fits in int.
1762
3c616cfa
PE
1763 * alloc.c (compact_small_strings): Tighten assertion a little.
1764
c2982e87
PE
1765 Replace pEd with more-general pI, and fix some printf arg casts.
1766 * lisp.h (pI): New macro, generalizing old pEd macro to other
1767 conversion specifiers. For example, use "...%"pI"d..." rather
1768 than "...%"pEd"...".
1769 (pEd): Remove. All uses replaced with similar uses of pI.
1770 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
1771 * alloc.c (check_pure_size): Don't overflow by converting size to int.
1772 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
1773 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
1774 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
1775 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
1776 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
1777 64-bit hosts.
1778 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
1779 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
1780 * print.c (safe_debug_print, print_object): Likewise.
1781 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
1782 to int.
6f04d126
PE
1783 Use pI instead of if-then-else-abort. Use %p to avoid casts,
1784 avoiding the 0 flag, which is not portable.
c2982e87
PE
1785 * process.c (Fmake_network_process): Use pI to avoid cast.
1786 * region-cache.c (pp_cache): Likewise.
1787 * xdisp.c (decode_mode_spec): Likewise.
1788 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
1789 behavior on 64-bit hosts with printf arg.
6f04d126 1790 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
1791 (x_stop_queuing_selection_requests): Likewise.
1792 (x_get_window_property): Don't truncate byte count to an 'int'
1793 when tracing.
0b432f21 1794
5e073ec7
PE
1795 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
1796 here, since it parses constructs like leading '-' and spaces,
1797 which are not wanted; and it overflows with large numbers.
1798 Instead, simply match F[0-9]+, which is what is wanted anyway.
1799
36372bf9
PE
1800 * alloc.c: Remove unportable assumptions about struct layout.
1801 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
1802 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
1803 (allocate_vectorlike, make_pure_vector): Use the new macros,
1804 plus offsetof, to remove unportable assumptions about struct layout.
1805 These assumptions hold on all porting targets that I know of, but
1806 they are not guaranteed, they're easy to remove, and removing them
1807 makes further changes easier.
1808
0b432f21
PE
1809 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1810 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
1811 (string_overrun_cookie): Now const. Use initializers that
1812 don't formally overflow signed char, to avoid warnings.
000098c1
PE
1813 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1814 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
1815 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1816 multiple of sizeof (EMACS_INT); it need not be, if
1817 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 1818 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 1819
895009e1
JB
18202011-04-26 Juanma Barranquero <lekktu@gmail.com>
1821
1822 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1823
6a7a1b0b
TZ
18242011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1825
1826 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 1827 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
1828 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1829
841a1577 18302011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
1831
1832 * lisp.h (Qdebug): List symbol.
895009e1 1833 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
1834 * keyboard.c (debug-on-event): New variable.
1835 (handle_user_signal): Break into debugger when debug-on-event
1836 matches the current signal symbol.
1837
f2d3ba6f
DN
18382011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1839
1840 * alloc.c (check_sblock, check_string_bytes)
1841 (check_string_free_list): Convert to standard C.
1842
42ce4c63
TZ
18432011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1844
1845 * w32.c (emacs_gnutls_push): Fix typo.
1846
825cd63c
EZ
18472011-04-25 Eli Zaretskii <eliz@gnu.org>
1848
fb11d64d
EZ
1849 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1850 "cast to pointer from integer of different size".
1851
825cd63c
EZ
1852 Improve doprnt and its use in verror. (Bug#8545)
1853 * doprnt.c (doprnt): Document the set of format control sequences
1854 supported by the function. Use SAFE_ALLOCA instead of always
1855 using `alloca'.
1856
1857 * eval.c (verror): Don't limit the buffer size at size_max-1, that
1858 is one byte too soon. Don't use xrealloc; instead xfree and
1859 xmalloc anew.
1860
e061a11b
TZ
18612011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
1862
1863 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
1864 callbacks stage.
1865
1866 * gnutls.c: Renamed global_initialized to
1867 gnutls_global_initialized. Added internals for the
1868 :verify-hostname-error, :verify-error, and :verify-flags
1869 parameters of `gnutls-boot' and documented those parameters in the
1870 docstring. Start callback support.
1871 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
1872 unless a fatal error occured. Call gnutls_alert_send_appropriate
1873 on error. Return error code.
1874 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
1875 (emacs_gnutls_read): Likewise.
1876 (Fgnutls_boot): Return handshake error code.
1877 (emacs_gnutls_handle_error): New function.
1878 (wsaerror_to_errno): Likewise.
1879
1880 * w32.h (emacs_gnutls_pull): Add prototype.
1881 (emacs_gnutls_push): Likewise.
1882
1883 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
1884 (emacs_gnutls_push): Likewise.
1885
18862011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
1887
1888 * process.c (wait_reading_process_output): Check if GnuTLS
1889 buffered some data internally if no FDs are set for TLS
1890 connections.
1891
1892 * makefile.w32-in (OBJ2): Add gnutls.$(O).
1893 (LIBS): Link to USER_LIBS.
1894 ($(BLD)/gnutls.$(0)): New target.
1895
fa6996bc
EZ
18962011-04-24 Eli Zaretskii <eliz@gnu.org>
1897
eb35682e
EZ
1898 * xdisp.c (handle_single_display_spec): Rename the
1899 display_replaced_before_p argument into display_replaced_p, to
1900 make it consistent with the commentary. Fix typos in the
1901 commentary.
1902
e2ad650c
EZ
1903 * textprop.c (syms_of_textprop): Remove dead code.
1904 (copy_text_properties): Delete obsolete commentary about an
1905 interface that was deleted long ago. Fix typos in the description
1906 of arguments.
1907
1b2de274
EZ
1908 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
1909 to changes in oldXMenu/XMenu.h from 2011-04-16.
1910 <menu_help_message, prev_menu_help_message>: Constify.
1911 (IT_menu_make_room): menu->help_text is now `const char **';
1912 adjust.
1913
1914 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
1915 to changes in oldXMenu/XMenu.h from 2011-04-16.
1916 (struct XMenu): Declare `help_text' `const char **'.
1917
1918 * xfaces.c <Qunspecified>: Make extern again.
1919
1920 * syntax.c: Include sys/types.h before including regex.h, as
1921 required by Posix.
1922
762b15be
EZ
1923 * doc.c (get_doc_string): Improve the format passed to `error'.
1924
1925 * doprnt.c (doprnt): Improve commentary.
1926
1927 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
1928
1929 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
1930 them with etags.
1931
f1052e5d
EZ
1932 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
1933 changes in globals.h immediately force recompilation.
762b15be
EZ
1934 (TAGS): Depend on $(CURDIR)/m/intel386.h and
1935 $(CURDIR)/s/ms-w32.h.
1936 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 1937
fa6996bc
EZ
1938 * character.c (Fchar_direction): Function deleted.
1939 (syms_of_character): Don't defsubr it.
1940 <char-direction-table>: Deleted.
1941
e6c3da20
EZ
19422011-04-23 Eli Zaretskii <eliz@gnu.org>
1943
1944 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
1945 * doprnt.c: Include limits.h.
1946 (SIZE_MAX): New macro.
04f2d78b
CB
1947 (doprnt): Return a size_t value. 2nd arg is now size_t.
1948 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
1949 Improve overflow protection. Support `l' modifier for integer
1950 conversions. Support %l conversion. Don't assume an EMACS_INT
1951 argument for integer conversions and for %c.
1952
1953 * lisp.h (doprnt): Restore prototype.
1954
1955 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
1956 $(SRC)/character.h.
1957
1958 * Makefile.in (base_obj): Add back doprnt.o.
1959
1960 * deps.mk (doprnt.o): Add back prerequisites.
1961 (callint.o): Depend on character.h.
1962
1963 * eval.c (internal_lisp_condition_case): Include the handler
1964 representation in the error message.
1965 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1966 when breaking from the loop.
1967
1968 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1969
1970 * callint.c (Fcall_interactively): When displaying error message
1971 about invalid control letter, pass the character's codepoint, not
1972 a pointer to its multibyte form. Improve display of the character
1973 in octal and display also its hex code.
1974
1975 * character.c (char_string): Use %x to display the (unsigned)
1976 codepoint of an invalid character, to avoid displaying a bogus
1977 negative value.
1978
1979 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1980 `error', not SYMBOL_NAME itself.
1981
1982 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1983 character arguments to `error'.
1984
1985 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1986 to `error' in error message about FINAL_CHAR argument. Make sure
1987 FINAL_CHAR is a character, and use %c when it is passed as
1988 argument to `error'.
1989
4ffd0d6b 19902011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
1991
1992 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1993
1994 * w32.c: Include <time.h>.
1995 (sys_localtime): New function.
1996
4ffd0d6b 19972011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
1998
1999 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2000
4ffd0d6b 2001 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 2002
4ffd0d6b 20032011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 2004
4ffd0d6b
GM
2005 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2006 zombies (Bug#8467).
aac0c6e3 2007
04c56954
EZ
20082011-04-19 Eli Zaretskii <eliz@gnu.org>
2009
2010 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2011 gl_state.e_property when gl_state.object is Qt.
2012
2013 * insdel.c (make_gap_larger): Remove limitation of buffer size
2014 to <= INT_MAX.
2015
16a43933
CY
20162011-04-18 Chong Yidong <cyd@stupidchicken.com>
2017
2018 * xdisp.c (lookup_glyphless_char_display)
2019 (produce_glyphless_glyph): Handle cons cell entry in
2020 glyphless-char-display.
2021 (Vglyphless_char_display): Document it.
2022
2023 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2024 glyphless-char-display.
2025
4581706e
CY
20262011-04-17 Chong Yidong <cyd@stupidchicken.com>
2027
2028 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2029
2030 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2031
2032 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2033 definition for no-X builds.
2034
4887c6e2 20352011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 2036
fd35b6f9
PE
2037 Static checks with GCC 4.6.0 and non-default toolkits.
2038
5c1ccb01
PE
2039 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2040
006c5daa
PE
2041 * process.c (keyboard_bit_set): Define only if SIGIO.
2042 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2043 (send_process): Repair possible setjmp clobbering.
2044
efc736d3
PE
2045 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2046
4e2fe2e6
PE
2047 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2048
f97334a2
PE
2049 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2050
4e75f29d
PE
2051 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2052 Define only if needed.
2053
90efadd1
PE
2054 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2055 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 2056 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 2057
3c647824
PE
2058 * dispextern.h (struct redisplay_interface): Rename param
2059 to avoid shadowing.
e264f262 2060 * termhooks.h (struct terminal): Likewise.
761383f4 2061 * xterm.c (xembed_send_message): Likewise.
3c647824 2062
b58c5c4a
PE
2063 * insdel.c (make_gap_smaller): Define only if
2064 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2065
cad59032
PE
2066 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2067 it.
2068
c339dc2e
PE
2069 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2070 so that we aren't warned about unused symbols.
2071
91a3e27b
PE
2072 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2073
399c71d3 2074 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 2075
8ffc96f5
PE
2076 * xfns.c (x_real_positions): Mark locals as initialized.
2077
eef9bc79
PE
2078 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2079
098db9dd
PE
2080 * xterm.c: Fix problems found by static analysis with other toolkits.
2081 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
2082 (x_dispatch_event): Declare static if USE_GTK, and
2083 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 2084 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 2085 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
2086 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2087 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 2088
eb18f6cc
PE
2089 * xmenu.c (menu_help_callback): Pointer type fixes.
2090 Use const pointers when pointing at readonly data. Avoid pointer
2091 signedness clashes.
2092 (FALSE): Remove unused macro.
2093 (update_frame_menubar): Remove unused decl.
2094
1fe72bf8
PE
2095 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2096
60d9e1db
PE
2097 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2098 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2099 (single_menu_item): Rename local to avoid shadowing.
2100
39261c26
PE
2101 * keyboard.c (make_lispy_event): Remove unused local var.
2102
018c5e19
PE
2103 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2104 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2105
63d2b86e
PE
2106 * bitmaps: Change bitmaps from unsigned char back to the X11
2107 compatible char. Avoid the old compiler warnings about
2108 out-of-range initializers by using, for example, '\xab' rather
2109 than 0xab.
2110
aefd87e1
PE
2111 * xgselect.c (xgselect_initialize): Check vs interface
2112 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2113
bf501fb9
PE
2114 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2115
e9829fdf
PE
2116 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2117 to read-only memory.
2118
1086c095
PE
2119 * fns.c (vector): Remove; this old hack is no longer needed.
2120
2baccd04 2121 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 2122 Remove unused var.
dde42981 2123 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 2124
72391843 2125 * xrdb.c (x_load_resources): Omit unused local.
3565b346 2126
436c16df 2127 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 2128 (x_window): Rename locals to avoid shadowing.
dc5ddd85 2129 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 2130
92bb796d 2131 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 2132 (x_term_init): Remove local to avoid shadowing.
92bb796d 2133
764430a3 2134 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
2135
2136 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2137 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2138
d1dfb56c
EZ
21392011-04-16 Eli Zaretskii <eliz@gnu.org>
2140
c4354cb4
EZ
2141 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2142
d1dfb56c
EZ
2143 Fix regex.c, syntax.c and friends for buffers > 2GB.
2144 * syntax.h (struct gl_state_s): Declare character position members
2145 EMACS_INT.
2146
2147 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2148
04f2d78b
CB
2149 * textprop.c (verify_interval_modification, interval_of):
2150 Declare arguments EMACS_INT.
d1dfb56c
EZ
2151
2152 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2153 EMACS_INT.
2154
2155 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2156
2157 * indent.c (Fvertical_motion): Local variable it_start is now
2158 EMACS_INT.
2159
2160 * regex.c (re_match, re_match_2, re_match_2_internal)
2161 (bcmp_translate, regcomp, regexec, print_double_string)
2162 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2163 (re_compile_pattern, re_exec): Declare arguments and local
2164 variables `size_t' and `ssize_t' and return values `regoff_t', as
2165 appropriate.
2166 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2167 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2168 <compile_stack_type>: `size' and `avail' are now `size_t'.
2169
2170 * regex.h <regoff_t>: Use ssize_t, not int.
2171 (re_search, re_search_2, re_match, re_match_2): Arguments that
2172 specify buffer/string position and length are now ssize_t and
2173 size_t. Return type is regoff_t.
2174
613052cd
BK
21752011-04-16 Ben Key <bkey76@gmail.com>
2176
2177 * nsfont.m: Fixed bugs in ns_get_family and
2178 ns_descriptor_to_entity that were caused by using free to
2179 deallocate memory blocks that were allocated by xmalloc (via
2180 xstrdup). This caused Emacs to crash when compiled with
2181 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2182 --enable-checking=xmallocoverrun). xfree is now used to
2183 deallocate these memory blocks.
2184
4170f62f 21852011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 2186
71b41406
PE
2187 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2188
9587a89d
PE
2189 emacs_write: Accept and return EMACS_INT for sizes.
2190 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2191 et seq.
2192 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2193 Accept and return EMACS_INT.
2194 (emacs_gnutls_write): Return the number of bytes written on
2195 partial writes.
2196 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
2197 (emacs_read, emacs_write): Remove check for negative size, as the
2198 Emacs source code has been audited now.
9587a89d
PE
2199 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2200 (emacs_read, emacs_write): Use it.
273a5f82
PE
2201 * process.c (send_process): Adjust to the new signatures of
2202 emacs_write and emacs_gnutls_write. Do not attempt to store
2203 a byte offset into an 'int'; it might overflow.
9587a89d 2204 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 2205
3e047f51
PE
2206 * sound.c: Don't assume sizes fit in 'int'.
2207 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 2208 Return EMACS_INT, not int.
3e047f51 2209 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
2210 Accept EMACS_INT, not int.
2211 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
2212 record read return values.
2213
cc39a9db
BK
22142011-04-15 Ben Key <bkey76@gmail.com>
2215
c9d0ec6d
JB
2216 * keyboard.c (Qundefined): Don't declare static since it is used
2217 in nsfns.m.
2218 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2219 static since they are used in nsfont.m.
cc39a9db 2220
6c60eb9f
SM
22212011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2222
2223 * process.c (Qprocessp): Don't declare static.
2224 * lisp.h (Qprocessp): Declare again.
2225
7990b61a
JB
22262011-04-15 Juanma Barranquero <lekktu@gmail.com>
2227
2228 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2229
5d4cb038
PE
22302011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2231
8bd7b830 2232 Improve C-level modularity by making more things 'static'.
cd64ea1d 2233
e3b27b31
PE
2234 Don't publish debugger-only interfaces to other modules.
2235 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2236 (verify_bytepos, count_markers): Move decls to the only modules
2237 that need them.
2238 * region-cache.h (pp_cache): Likewise.
2239 * window.h (check_all_windows): Likewise.
2240 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2241
5d4cb038
PE
2242 * sysdep.c (croak): Now static, if
2243 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2244 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
2245
2246 * alloc.c (refill_memory_reserve): Now static if
2247 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2248 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 2249
e87b6180
PE
2250 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2251 Define only if USE_LUCID.
2252
ac64929e
PE
2253 * xrdb.c (x_customization_string, x_rm_string): Now static.
2254
6f37259d
PE
2255 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2256 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2257
1683e3ab
PE
2258 * xdisp.c (draw_row_with_mouse_face): Now static.
2259 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2260
de9c2632
PE
2261 * window.h (check_all_windows): Mark externally visible.
2262
2b96acb7
PE
2263 * window.c (window_deletion_count): Now static.
2264
2265 * undo.c: Make symbols static if they're not exported.
2266 (last_undo_buffer, last_boundary_position, pending_boundary):
2267 Now static.
2268
50436f33
PE
2269 * textprop.c (interval_insert_behind_hooks): Now static.
2270 (interval_insert_in_front_hooks): Likewise.
2271
64520e5c
PE
2272 * term.c: Make symbols static if they're not exported.
2273 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2274 (max_frame_lines, tty_set_terminal_modes):
2275 (tty_reset_terminal_modes, tty_turn_off_highlight):
2276 (get_tty_terminal): Now static.
2277 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2278 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 2279 HAVE_WINDOW_SYSTEM.
64520e5c
PE
2280 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2281 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2282
1fa53021
PE
2283 * sysdep.c: Make symbols static if they're not exported.
2284 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2285 Now static.
2286 (sigprocmask_set, full_mask): Remove; unused.
2287 (wait_debugging): Mark as visible.
2288 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2289 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2290
d4b43b22
PE
2291 * syntax.c (syntax_temp): Define only if !__GNUC__.
2292
b7c513d0
PE
2293 * sound.c (current_sound_device, current_sound): Now static.
2294
989b29ad
PE
2295 * search.c (searchbufs, searchbuf_head): Now static.
2296
13a55a78
PE
2297 * scroll.c (scroll_cost): Remove; unused.
2298 * dispextern.h (scroll_cost): Remove decl.
2299
de68a1fc
PE
2300 * region-cache.h (pp_cache): Mark as externally visible.
2301
40ccffa6
PE
2302 * process.c: Make symbols static if they're not exported.
2303 (process_tick, update_tick, create_process, chan_process):
2304 (Vprocess_alist, proc_buffered_char, datagram_access):
2305 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2306 (deactivate_process): Mark defn as static, as well as decl.
2307 * lisp.h (create_process): Remove decl.
2308 * process.h (chan_process, Vprocess_alist): Remove decls.
2309
ad64fc97
PE
2310 * print.c: Make symbols static if they're not exported.
2311 (print_depth, new_backquote_output, being_printed, print_buffer):
2312 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2313 (print_interval, print_number_index, initial_stderr_stream):
2314 Now static.
2315 * lisp.h (Fprinc): Remove decl.
2316 (debug_output_compilation_hack): Mark as externally visible.
2317
adddb265
PE
2318 * sysdep.c (croak): Move decl from here to syssignal.h.
2319 * syssignal.h (croak): Put it here, so the API can be checked when
2320 'croak' is called from dissociate_if_controlling_tty.
2321
1717ede2
PE
2322 * minibuf.c: Make symbols static if they're not exported.
2323 (minibuf_save_list, choose_minibuf_frame): Now static.
2324 * lisp.h (choose_minibuf_frame): Remove decl.
2325
fa5fb2bc
PE
2326 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2327
1e3890d1
PE
2328 * lread.c: Make symbols static if they're not exported.
2329 (read_objects, initial_obarray, oblookup_last_bucket_number):
2330 Now static.
2331 (make_symbol): Remove; unused.
2332 * lisp.h (initial_obarray, make_symbol): Remove decls.
2333
8a1414fa
PE
2334 * keyboard.c: Make symbols static if they're not exported.
2335 (single_kboard, recent_keys_index, total_keys, recent_keys):
2336 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2337 (this_single_command_key_start, echoing, last_auto_save):
2338 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2339 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2340 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2341 (Vlispy_mouse_stem, double_click_count):
2342 Now static.
2343 (force_auto_save_soon): Define only if SIGDANGER.
2344 (ignore_mouse_drag_p): Now static if
2345 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2346 (print_help): Remove; unused.
2347 (stop_character, last_timer_event): Mark as externally visible.
2348 * keyboard.h (ignore_mouse_drag_p): Declare only if
2349 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2350 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2351 * lisp.h (echoing): Remove decl.
2352 (force_auto_save_soon): Declare only if SIGDANGER.
2353 * xdisp.c (redisplay_window): Simplify code, to make it more
2354 obvious that ignore_mouse_drag_p is not accessed if !defined
2355 USE_GTK && !defined HAVE_NS.
2356
93ea6e8f
PE
2357 * intervals.c: Make symbols static if they're not exported.
2358 (merge_properties_sticky, merge_interval_right, delete_interval):
2359 Now static.
2360 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2361
77382fcc
PE
2362 * insdel.c: Make symbols static if they're not exported.
2363 However, leave prepare_to_modify_buffer alone. It's never
2364 called from outside this function, but that appears to be a bug.
2365 (combine_after_change_list, combine_after_change_buffer):
4889fc82 2366 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
2367 (adjust_after_replace_noundo): Remove; unused.
2368 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 2369 (signal_before_change): Remove decls.
77382fcc 2370
9306c32e
PE
2371 * indent.c (val_compute_motion, val_vmotion): Now static.
2372
cd44d2eb
PE
2373 * image.c: Make symbols static if they're not exported.
2374 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2375 if USE_GTK.
2376 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2377 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2378
ad9a7a06
PE
2379 * fringe.c (standard_bitmaps): Now static.
2380 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2381
81626931
PE
2382 * frame.c: Make symbols static if they're not exported.
2383 (x_report_frame_params, make_terminal_frame): Now static.
2384 (get_frame_param): Now static, unless HAVE_NS.
2385 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2386 (x_get_resource_string): Remove; not used.
2387 * frame.h (make_terminal_frame, x_report_frame_params):
2388 (x_get_resource_string); Remove decls.
2389 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2390 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2391
239f9db9
PE
2392 * font.c, fontset.c: Make symbols static if they're not exported.
2393 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2394 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2395 * font.c (font_close_object): Now static.
2396 * font.h (font_close_object): Remove.
2397 * fontset.c (FONTSET_OBJLIST): Remove.
2398 (free_realized_fontset) #if-0 the body, which does nothing.
2399 (face_suitable_for_char_p): #if-0, as it's never called.
2400 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
2401 * xfaces.c (face_at_string_position):
2402 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
2403 since 0 is always ASCII.
2404
dfcf3579
PE
2405 * fns.c (weak_hash_tables): Now static.
2406
5045092b
PE
2407 * fileio.c: Make symbols static if they're not exported.
2408 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2409 (Vwrite_region_annotation_buffers): Now static.
2410
57a96f5c
PE
2411 * eval.c: Make symbols static if they're not exported.
2412 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2413 * lisp.h (backtrace_list): Remove decl.
2414
35f08c38
PE
2415 * emacs.c: Make symbols static if they're not exported.
2416 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2417 (fatal_error_code, fatal_error_signal_hook, standard_args):
2418 Now static.
2419 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2420 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2421 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2422 * lisp.h (fatal_error_signal_hook): Remove decl.
2423 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2424
f44bd759
PE
2425 * editfns.c: Move a (normally-unused) function to its only use.
2426 * editfns.c, lisp.h (get_operating_system_release): Remove.
2427 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2428 worth the hassle of breaking this out.
2429
b532497d
PE
2430 * xterm.c: Make symbols static if they're not exported.
2431 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2432 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2433 (x_destroy_window, x_delete_display):
2434 Now static.
2435 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2436 (x_mouse_leave): Remove; unused.
2437 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2438 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2439 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2440 Remove decls.
2441 (x_mouse_leave): Declare only if WINDOWSNT.
2442 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2443 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2444 USE_X_TOOLKIT.
2445
1675728f
PE
2446 * ftxfont.c: Make symbols static if they're not exported.
2447 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2448 HAVE_FREETYPE.
2449 * font.h (ftxfont_driver): Likewise.
2450
e4cebfca
PE
2451 * xfns.c: Make symbols static if they're not exported.
2452 (x_last_font_name, x_display_info_for_name):
2453 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2454 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2455 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2456 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2457 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2458 (last_show_tip_args): Now static.
2459 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2460 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2461 (x_screen_planes): Remove; unused.
2462 * dispextern.h (x_screen_planes): Remove decl.
2463
5bf46f05
PE
2464 * dispnew.c: Make symbols static if they're not exported.
2465 * dispextern.h (redraw_garbaged_frames, scrolling):
2466 (increment_row_positions): Remove.
2467 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2468 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2469 Now static.
2470 (redraw_garbaged_frames): Remove; unused.
2471
435f4c28
PE
2472 * xfaces.c: Make symbols static if they're not exported.
2473 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2474 Remove decls.
2475 * xterm.h (defined_color): Remove decls.
2476 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2477 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2478 (menu_face_changed_default, defined_color, free_realized_face):
2479 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2480 (ascii_face_of_lisp_face): Remove; unused.
2481
8524aef3
PE
2482 * xdisp.c: Make symbols static if they're not exported.
2483 * dispextern.h (scratch_glyph_row, window_box_edges):
2484 (glyph_to_pixel_coords, set_cursor_from_row):
2485 (get_next_display_element, set_iterator_to_next):
2486 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2487 (show_mouse_face): Remove decls
2488 * frame.h (message_buf_print): Likewise.
2489 * lisp.h (pop_message, set_message, check_point_in_composition):
2490 Likewise.
2491 * xterm.h (set_vertical_scroll_bar): Likewise.
2492 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2493 (message_buf_print, scratch_glyph_row, displayed_buffer):
2494 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2495 (get_next_display_element, show_mouse_face, window_box_edges):
2496 (frame_to_window_pixel_xy, check_point_in_composition):
2497 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2498 (glyph_to_pixel_coords): Remove; unused.
2499
16390cd2
PE
2500 * dired.c (file_name_completion): Now static.
2501
2502 * dbusbind.c (xd_in_read_queued_messages): Now static.
2503
a25f4dfa
PE
2504 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2505 * data.c (circular_list_error): Remove.
2506
14a9c8df
PE
2507 * commands.h (last_point_position, last_point_position_buffer):
2508 (last_point_position_window): Remove decls.
2509 * keyboard.c: Make these variables static.
2510
04f2d78b
CB
2511 * coding.h (coding, code_convert_region, encode_coding_gap):
2512 Remove decls.
74ab6df5
PE
2513 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2514 (iso_code_class, detect_coding, code_convert_region): Now static.
2515 (encode_coding_gap): Remove; unused.
2516
38dfbee1
PE
2517 * chartab.c (chartab_chars, chartab_bits): Now static.
2518
a2cb4e63
PE
2519 * charset.h (charset_iso_8859_1): Remove decl.
2520 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2521 Now static.
2522
127198fd
PE
2523 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2524 * ccl.c (Vccl_program_table): Now static.
2525 (check_ccl_update): Remove; unused.
2526
d85b608f
PE
2527 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2528 * category.h: ... from here.
2529 * category.c (check_category_table, set_category_set): Now static.
2530
31cd66f3
PE
2531 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2532 * lisp.h: Remove these decls.
2533
c358e587
PE
2534 * buffer.c (buffer_count): Remove unused var.
2535
e78aecca
PE
2536 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2537 so that it's not optimized away.
2538 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2539 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2540 exported only to the debugger.
2541
e192d7d3 2542 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 2543 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 2544
92470028
PE
2545 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2546 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2547 was inaccessible from Lisp.
2548 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2549 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2550
244ed907
PE
2551 alloc.c: Import and export fewer symbols, and remove unused items.
2552 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2553 is defined.
2554 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2555 it's not optimized away by whole-program optimization.
2556 (message_enable_multibyte, free_misc): Remove.
2557 (catchlist, handlerlist, mark_backtrace):
2558 Declare only if BYTE_MARK_STACK.
2559 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2560 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2561 (message_enable_multibyte): Remove decl.
2562 (free_misc, interval_free_list, float_block, float_block_index):
2563 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2564 (cons_free_list, last_marked_index):
2565 Now static.
2566 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2567 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2568 (mark_backtrace): Define only if BYTE_MARK_STACK.
2569 * xdisp.c (message_enable_multibyte): Now static.
2570
61c2b50e 2571 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
2572 This makes it easier for human readers (and static analyzers)
2573 to see whether these variables are used from other modules.
2574 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2575 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2576 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2577 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2578 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2579 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2580 * xmenu.c, xselect.c:
2581 Declare Q* vars static if they are not used in other modules.
2582 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2583 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2584 Remove decls of unexported vars.
2585 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2586
95c82688
PE
2587 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2588
16a97296
PE
2589 Make Emacs functions such as Fatom 'static' by default.
2590 This makes it easier for human readers (and static analyzers)
2591 to see whether these functions can be called from other modules.
2592 DEFUN now defines a static function. To make the function external
2593 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
2594 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2595 (Finit_image_library):
16a97296
PE
2596 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2597 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2598 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2599 Remove decls, since these functions are now static.
2600 (Funintern, Fget_internal_run_time): New decls, since these functions
2601 were already external.
95c82688 2602
16a97296
PE
2603 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2604 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2605 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2606 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2607 * keyboard.c, keymap.c, lread.c:
2608 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2609 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2610 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2611 Mark functions with DEFUE instead of DEFUN,
2612 if they are used in other modules.
2613 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2614 decls for now-static functions.
2615 * buffer.h (Fdelete_overlay): Remove decl.
2616 * callproc.c (Fgetenv_internal): Mark as internal.
2617 * composite.c (Fremove_list_of_text_properties): Remove decl.
2618 (Fcomposition_get_gstring): New forward static decl.
2619 * composite.h (Fcomposite_get_gstring): Remove decl.
2620 * dired.c (Ffile_attributes): New forward static decl.
2621 * doc.c (Fdocumntation_property): New forward static decl.
2622 * eval.c (Ffetch_bytecode): New forward static decl.
2623 (Funintern): Remove extern decl; now in .h file where it belongs.
2624 * fileio.c (Fmake_symbolic_link): New forward static decl.
2625 * image.c (Finit_image_library): New forward static decl.
2626 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2627 * intervals.h (Fprevious_property_change):
2628 (Fremove_list_of_text_properties): Remove decls.
2629 * keyboard.c (Fthis_command_keys): Remove decl.
2630 (Fcommand_execute): New forward static decl.
2631 * keymap.c (Flookup_key): New forward static decl.
2632 (Fcopy_keymap): Now static.
2633 * keymap.h (Flookup_key): Remove decl.
2634 * process.c (Fget_process): New forward static decl.
2635 (Fprocess_datagram_address): Mark as internal.
2636 * syntax.c (Fsyntax_table_p): New forward static decl.
2637 (skip_chars): Remove duplicate decl.
2638 * textprop.c (Fprevious_property_change): New forward static decl.
2639 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2640 Now internal.
2641 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2642 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2643
785bbd42
PE
2644 * editfns.c (Fformat): Remove unreachable code.
2645
8b913b57
AS
26462011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2647
2648 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2649 change. (Bug#8496)
2650
a6744a35
EZ
26512011-04-13 Eli Zaretskii <eliz@gnu.org>
2652
2653 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2654 when at ZV. (Bug#8487)
2655
e7974947
AS
26562011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2657
baad03f0
AS
2658 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2659 (Bug#8437)
2660 * keyboard.c (parse_tool_bar_item): Likewise.
2661 * sound.c (sound_cleanup, alsa_close): Likewise.
2662 * termcap.c (tgetent): Likewise.
2663 * xfns.c (x_default_font_parameter): Likewise.
2664 * xsettings.c (read_and_apply_settings): Likewise.
2665
e7974947
AS
2666 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2667 (overrun_check_free): Protoize.
2668
28272684
PE
26692011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2670
2671 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2672 since callers should never pass a negative size.
2673 Change the signature to match that of plain 'read' and 'write'; see
2674 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2675 * lisp.h: Update prototypes of emacs_write and emacs_read.
2676
11997c76
EZ
26772011-04-11 Eli Zaretskii <eliz@gnu.org>
2678
2679 * xdisp.c (redisplay_window): Don't try to determine the character
2680 position of the scroll margin if the window start point w->startp
e896f03c 2681 is outside the buffer's accessible region. (Bug#8468)
11997c76 2682
8a2cbd72
EZ
26832011-04-10 Eli Zaretskii <eliz@gnu.org>
2684
2685 Fix write-region and its subroutines for buffers > 2GB.
2686 * fileio.c (a_write, e_write): Modify declaration of arguments and
2687 local variables to support buffers larger than 2GB.
2688 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2689
2690 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2691 argument, local variables, and return value.
2692
2693 * lisp.h: Update prototypes of emacs_write and emacs_read.
2694
2695 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2696
4073e537 26972011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 2698
1ebfdcb6
PE
2699 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2700
b2ded58d
PE
2701 Fix more problems found by GCC 4.6.0's static checks.
2702
7d66342c
PE
2703 * xdisp.c (vmessage): Use a better test for character truncation.
2704
bbf47d44
PE
2705 * charset.c (load_charset_map): <, not <=, for optimization,
2706 and to avoid potential problems with integer overflow.
9248994d 2707 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 2708 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 2709 * editfns.c (Fformat): Likewise.
1e69125e 2710 * syntax.c (skip_chars): Likewise.
3befa583 2711
e3019616
PE
2712 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2713 This also lets GCC 4.6.0 generate slightly better loop code.
2714
becfa255
PE
2715 * callint.c (Fcall_interactively): <, not <=, for optimization.
2716 (Fcall_interactively): Count the number of arguments produced,
2717 not the number of arguments given. This is simpler and lets GCC
2718 4.6.0 generate slightly better code.
2719
dae0cd48
PE
2720 * ftfont.c: Distingish more carefully between FcChar8 and char.
2721 The previous code passed unsigned char * to a functions like
2722 strlen and xstrcasecmp that expect char *, which does not
2723 conform to the C standard.
2724 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2725 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2726 char * when the C standard requires it.
2727
76032d70
PE
2728 * keyboard.c (read_char): Remove unused var.
2729
eb3f1cc8
PE
2730 * eval.c: Port to Windows vsnprintf (Bug#8435).
2731 Include <limits.h>.
2732 (SIZE_MAX): Define if the headers do not.
2733 (verror): Do not give up if vsnprintf returns a negative count.
2734 Instead, grow the buffer. This ports to Windows vsnprintf, which
2735 does not conform to C99. Problem reported by Eli Zaretskii.
2736 Also, simplify the allocation scheme, by avoiding the need for
2737 calling realloc, and removing the ALLOCATED variable.
2738
70476b54
PE
2739 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2740
12020a9e
PE
2741 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2742 But keep the doprint source code for now, as we might revamp it
2743 and use it again (Bug#8435).
ea6c7ae6
PE
2744 * lisp.h (doprnt): Remove.
2745 * Makefile.in (base_obj): Remove doprnt.o.
2746 * deps.mk (doprnt.o): Remove.
2747
5fdb398c
PE
2748 error: Print 32- and 64-bit integers portably (Bug#8435).
2749 Without this change, on typical 64-bit hosts error ("...%d...", N)
2750 was used to print both 32- and 64-bit integers N, which relied on
2751 undefined behavior.
2752 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
2753 New macro.
2754 * lisp.h (error, verror): Mark as printf-like functions.
2755 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
2756 Report overflow in size calculations when allocating printf buffer.
2757 Do not truncate output string at its first null byte.
2758 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
2759 Truncate the output at a character boundary, since vsnprintf does not
2760 do that.
2761 * charset.c (check_iso_charset_parameter): Convert internal
2762 character to string before calling 'error', since %c now has the
2763 printf meaning.
2764 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
2765 overflow when computing char to be passed to 'error'. Do not
2766 pass Lisp_Object to 'error'; pass the integer instead.
2767 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
2768 formatted with plain %d.
2769
b189fa66
PE
2770 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
2771
bff87ef0
PE
2772 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
2773
7e2cac20
PE
2774 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
2775
ce4d90b5
PE
2776 * xterm.c (x_catch_errors): Remove duplicate declaration.
2777
266c9547
PE
2778 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
2779
79c49ad2
PE
2780 * xdisp.c, lisp.h (message_nolog): Remove; unused.
2781
368f4090
JM
27822011-04-10 Jim Meyering <meyering@redhat.com>
2783
2784 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
2785 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
2786 return ssize_t not "int", and use size_t as the buffer length.
2787 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
2788 * gnutls.h: Update declarations.
2789 * process.c (read_process_output): Use ssize_t, to match.
2790 (send_process): Likewise.
2791
a32d4040
CY
27922011-04-09 Chong Yidong <cyd@stupidchicken.com>
2793
2794 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
2795
8546720e 27962011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 2797
04f2d78b
CB
2798 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
2799 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 2800
8546720e
GM
2801 * xterm.c (handle_one_xevent):
2802 * xmenu.c (create_and_show_popup_menu):
2803 * xselect.c (x_decline_selection_request)
2804 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 2805
0a2f5c1a 28062011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
2807
2808 Fix some uses of `int' instead of EMACS_INT.
2809 * search.c (string_match_1, fast_string_match)
2810 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2811 (scan_buffer, find_next_newline_no_quit)
2812 (find_before_next_newline, search_command, Freplace_match)
2813 (Fmatch_data): Make some `int' variables be EMACS_INT.
2814
2815 * xdisp.c (display_count_lines): 3rd argument and return value now
2816 EMACS_INT. All callers changed.
2817 (pint2hrstr): Last argument is now EMACS_INT.
2818
2819 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2820 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2821 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2822 (decode_coding_utf_16, decode_coding_emacs_mule)
2823 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2824 (decode_coding_ccl, decode_coding_charset)
2825 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2826 (decode_coding_iso_2022, decode_coding_emacs_mule)
2827 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2828 <char_offset, last_offset>: Declare EMACS_INT.
2829 (encode_coding_utf_8, encode_coding_utf_16)
2830 (encode_coding_emacs_mule, encode_invocation_designation)
2831 (encode_designation_at_bol, encode_coding_iso_2022)
2832 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2833 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2834 Declare EMACS_INT.
2835 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2836 (encode_invocation_designation): Last argument P_NCHARS is now
2837 EMACS_INT.
2838 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2839 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2840
2841 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2842 All users changed.
2843
2844 * ccl.c (Fccl_execute_on_string): Declare some variables
2845 EMACS_INT.
2846
8546720e 28472011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
2848
2849 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2850
4e19a977
CS
28512011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2852
2853 * process.c (Fformat_network_address): Doc fix.
2854
87302331
R
28552011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2856
2857 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
2858
cbb59342
CY
28592011-04-08 Chong Yidong <cyd@stupidchicken.com>
2860
2861 * keyboard.c (read_char): Call Lisp function help-form-show,
2862 instead of using internal_with_output_to_temp_buffer.
2863 (Qhelp_form_show): New var.
e0d38eeb 2864 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
2865
2866 * print.c (internal_with_output_to_temp_buffer): Function deleted.
2867
2868 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
2869
e67a13ab
CY
28702011-04-06 Chong Yidong <cyd@stupidchicken.com>
2871
04f2d78b
CB
2872 * process.c (Flist_processes): Remove to Lisp.
2873 (list_processes_1): Delete.
e67a13ab 2874
973f782d
EZ
28752011-04-06 Eli Zaretskii <eliz@gnu.org>
2876
7c106b1e
EZ
2877 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
2878
973f782d
EZ
2879 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
2880
41cf7d1a 28812011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 2882
ca23cc88
PE
2883 Fix more problems found by GCC 4.6.0's static checks.
2884
f390e2d5
PE
2885 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
2886
42eea0d0
PE
2887 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
2888
b69769da 2889 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 2890
f9541e84
PE
2891 * xdisp.c (vmessage): Mark as a printf-like function.
2892
13841b55
PE
2893 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
2894
c136c10f
PE
2895 * sound.c (sound_warning): Don't crash if arg contains a printf format.
2896
5e2d4a30
PE
2897 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
2898 printf-like functions.
2899 (tiff_load): Add casts to remove these marks before passing them
2900 to system-supplied API.
2901
583f48b9
PE
2902 * eval.c (Fsignal): Remove excess argument to 'fatal'.
2903
b25d760e
PE
2904 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
2905 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
2906 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
2907 directly, rather than having caller test rule sign. This avoids
2908 some unnecessary tests.
2909 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
2910 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
2911 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 2912
bc7b6697 2913 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 2914 (xfont_open): Avoid unnecessary tests.
bc7b6697 2915
27ccc379
PE
2916 * composite.c (composition_gstring_put_cache): Use unsigned integer.
2917
dcd5c89a
PE
2918 * composite.h, composite.c (composition_gstring_put_cache):
2919 Use EMACS_INT, not int, for length.
2920
b13a45c6
PE
2921 * composite.h (COMPOSITION_DECODE_REFS): New macro,
2922 breaking out part of COMPOSITION_DECODE_RULE.
2923 (COMPOSITION_DECODE_RULE): Use it.
2924 * composite.c (get_composition_id): Remove unused local vars,
2925 by using the new macro.
2926
1e792e4d
PE
2927 * textprop.c (set_text_properties_1): Change while to do-while,
2928 since the condition is always true at first.
2929
dc6c6455 2930 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
2931 (interval_deletion_adjustment): Return unsigned value.
2932 All uses changed.
dc6c6455 2933
aba7731a
PE
2934 * process.c (list_processes_1, create_pty, read_process_output):
2935 (exec_sentinel): Remove vars that were set but not used.
afd4052b 2936 (create_pty): Remove unnecessary "volatile"s.
bc57d757 2937 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 2938 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 2939 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 2940
fdfc4bf3
PE
2941 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
2942
fca8fe46 2943 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 2944 (update_syntax_table): Use unsigned instead of int.
fca8fe46 2945
06a0259a 2946 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 2947 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 2948 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 2949
e7b9e80f
PE
2950 * print.c (print_error_message): Avoid int overflow.
2951
56201685
PE
2952 * font.c (font_list_entities): Redo for clarity,
2953 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
2954
78834453 2955 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 2956 (font_score): Avoid potential overflow in diff calculation.
78834453 2957
0bc0b309 2958 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 2959 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 2960
e610eaca
PE
2961 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2962
b895abce
PE
2963 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2964 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2965 can always succeed if overflow has undefined behavior.
2966
1f1d9321 2967 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 2968 (wordify): Omit three unnecessary tests.
1f1d9321 2969
c59478bc
PE
2970 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2971 All callers changed. This avoids the need for an unused var.
2972
79b73827
PE
2973 * casefiddle.c (casify_region): Remove var that is set but not used.
2974
a4db5dfe
PE
2975 * dired.c (file_name_completion): Remove var that is set but not used.
2976
43aae36e
PE
2977 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2978
2a47c44d 2979 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 2980 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 2981
a37c69bf
PE
2982 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2983 Check for integer overflow on size calculations.
2984
328ab8e7
PE
2985 * buffer.c (Fprevious_overlay_change): Remove var that is set
2986 but not used.
2987
e5a2a5cb
PE
2988 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2989 Remove vars that are set but not used.
8d84a6eb 2990 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 2991 (timer_check_2): Mark vars as initialized.
e5a2a5cb 2992
a60e5f68
PE
2993 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2994
f661cb61 2995 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 2996 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 2997
f0397f5a
PE
2998 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2999 that are set but not used.
3000
8664db06 3001 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 3002 if XCreateBitmapFromData fails (Bug#8410).
8664db06 3003
6abdaa4a
PE
3004 * xselect.c (x_get_local_selection, x_handle_property_notify):
3005 Remove vars that are set but not used.
3006
0ce7538d 3007 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 3008 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 3009
9ae848fc
PE
3010 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3011 Remove var that is set but not used.
0b918413
PE
3012 (scroll_bar_windows_size): Now size_t, not int.
3013 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3014 Check for overflow.
9ae848fc 3015
a5a62657
PE
3016 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3017 (map_tty_color) [!defined MSDOS]: Likewise.
3018
5c5cdd39
PE
3019 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3020
66ebf983
PE
3021 * coding.c: Remove vars that are set but not used.
3022 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3023 All callers changed.
3024 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3025 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3026 (decode_coding_charset): Remove vars that are set but not used.
3027
1be4d761
PE
3028 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3029 that is set but not used.
3030
47553fa8
PE
3031 * print.c (print_object): Remove var that is set but not used.
3032
1f7196bf 3033 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
3034 The gnulib version avoids calling malloc in the usual case,
3035 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3036 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3037 * filelock.c (current_lock_owner): Likewise.
3038 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3039 * sysdep.c: Include allocator.h, careadlinkat.h.
3040 (emacs_no_realloc_allocator): New static constant.
3041 (emacs_readlink): New function.
fdb61804
PE
3042 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3043 ../lib/careadlinkat.h.
d1fdcab7 3044
f84c17c7
SM
30452011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3046
3047 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3048 first non-nil return value).
3049
ef3862ad
JD
30502011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3051
3052 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3053 if not defined (Bug#8403).
3054
376a7006
JB
30552011-04-02 Juanma Barranquero <lekktu@gmail.com>
3056
3057 * xdisp.c (display_count_lines): Remove parameter `start',
3058 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3059 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3060 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3061 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3062 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3063 and thereabouts. All callers changed.
3064 (get_per_char_metric): Remove parameter `f', unused since
3065 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3066
6ca3801d
JM
30672011-04-02 Jim Meyering <meyering@redhat.com>
3068
3069 do not dereference NULL upon failed strdup
3070 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3071 (ns_get_family): Likewise.
3072
d8e2b5ba
JB
30732011-04-02 Juanma Barranquero <lekktu@gmail.com>
3074
3075 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3076
8c74fcbd
JD
30772011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3078
3079 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3080 later (Bug#8403).
3081
7200d79c
SM
30822011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3083
03408648 3084 Add lexical binding.
7200d79c 3085
03408648
SM
3086 * window.c (Ftemp_output_buffer_show): New fun.
3087 (Fsave_window_excursion):
3088 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3089
3090 * lread.c (lisp_file_lexically_bound_p): New function.
3091 (Fload): Bind Qlexical_binding.
3092 (readevalloop): Remove `evalfun' arg.
3093 Bind Qinternal_interpreter_environment.
3094 (Feval_buffer): Bind Qlexical_binding.
3095 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3096 Mark as dynamic.
3097 (syms_of_lread): Declare `lexical-binding'.
3098
3099 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3100
3101 * keyboard.c (eval_dyn): New fun.
3102 (menu_item_eval_property): Use it.
ca105506
SM
3103
3104 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 3105
03408648
SM
3106 * fns.c (concat, mapcar1): Accept byte-code-functions.
3107
3108 * eval.c (Fsetq): Handle lexical vars.
3109 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3110 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3111 (FletX, Flet): Obey lexical binding.
3112 (Fcommandp): Handle closures.
3113 (Feval): New `lexical' arg.
3114 (eval_sub): New function extracted from Feval. Use it almost
3115 everywhere where Feval was used. Look up vars in lexical env.
3116 Handle closures.
3117 (Ffunctionp): Move from subr.el.
3118 (Ffuncall): Handle closures.
3119 (apply_lambda): Remove `eval_flags'.
3120 (funcall_lambda): Handle closures and new byte-code-functions.
3121 (Fspecial_variable_p): New function.
3122 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3123 but without exporting it to Lisp.
23aba0ea 3124
23aba0ea 3125 * doc.c (Fdocumentation, store_function_docstring):
03408648 3126 * data.c (Finteractive_form): Handle closures.
23aba0ea 3127
03408648
SM
3128 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3129 interactive spec.
ba83908c 3130
04f2d78b
CB
3131 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3132 New byte-codes.
03408648
SM
3133 (exec_byte_code): New function extracted from Fbyte_code to handle new
3134 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 3135
03408648 3136 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 3137
03408648 3138 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 3139
e2abce01
JB
31402011-03-31 Juanma Barranquero <lekktu@gmail.com>
3141
3142 * xdisp.c (redisplay_internal): Fix prototype.
3143
63696a73 31442011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 3145
63696a73 3146 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
3147 (try_scrolling): Use it when setting scroll_limit.
3148 Limit scrolling to 100 screen lines.
63696a73
EZ
3149 (redisplay_window): Even when falling back on "recentering",
3150 position point in the window according to scroll-conservatively,
3151 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3152
3153 (try_scrolling): When point is above the window, allow searching
3154 as far as scroll_max, or one screenful, to compute vertical
3155 distance from PT to the scroll margin position. This prevents
3156 try_scrolling from unnecessarily failing when
3157 scroll-conservatively is set to a value slightly larger than the
3158 window height. Clean up the case of PT below the margin at bottom
3159 of window: scroll_max can no longer be INT_MAX. When aggressive
3160 scrolling is in use, don't let point enter the opposite scroll
3161 margin as result of the scroll.
3162 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
3163 threshold of 100 lines for never-recentering scrolling.
3164
e4cc2dfc
JB
31652011-03-31 Juanma Barranquero <lekktu@gmail.com>
3166
3167 * dispextern.h (move_it_by_lines):
3168 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3169 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3170 (message_log_check_duplicate): Remove parameters `prev_bol' and
3171 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3172 (redisplay_internal): Remove parameter `preserve_echo_area',
3173 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3174
3175 * indent.c (Fvertical_motion):
3176 * window.c (window_scroll_pixel_based, Frecenter):
3177 Don't pass `need_y_p' to `move_it_by_lines'.
3178
1c470562
SM
31792011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3180
44f230aa
SM
3181 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3182 steal a few bits to be more compact.
3183 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3184 Remove unneeded casts.
3185
1c470562
SM
3186 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3187
888adce9
ZK
31882011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3189
3190 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3191 binding" message (bug#7967).
3192
f838ed7b
PE
31932011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3194
77861b95
PE
3195 Fix more problems found by GCC 4.6.0's static checks.
3196
de6dbc14
PE
3197 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3198 Remove unused local var.
3199
f838ed7b
PE
3200 * editfns.c (Fmessage_box): Remove unused local var.
3201
792c7b2b
PE
3202 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3203 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3204 Omit unused local vars.
c499e557 3205 * window.c (shrink_windows): Omit unused local var.
b01a1c29 3206 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
3207 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3208 Omit unused local var.
3209
ba0165e1
PE
3210 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3211 Don't assume string length fits in int.
32ad8845 3212 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 3213 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 3214
3c59b4c9
PE
3215 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3216 instead of alloca (Bug#8344).
3217
a3eed478 3218 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 3219 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 3220
eb4d412d
PE
3221 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3222
1658b401
PE
3223 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3224 concerns.
3225
3226 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3227
3228 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 3229
9a2c6e05
PE
3230 * keyboard.c (syms_of_keyboard): Use the same style as later
3231 in this function when indexing through an array. This also
3232 works around GCC bug 48267.
3233
03d0a109
PE
3234 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3235
44f730c8
PE
3236 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3237
fe75f926
PE
3238 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3239 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3240
ffa8c828
PE
3241 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3242 This avoids undefined behavior on integer overflow, and is a bit
3243 more convenient anyway since it is compared to a size_t variable.
3244
c5101a77
PE
3245 Variadic C functions now count arguments with size_t, not int.
3246 This avoids an unnecessary limitation on 64-bit machines, which
3247 caused (substring ...) to crash on large vectors (Bug#8344).
3248 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3249 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 3250 All variadic functions and their callers changed accordingly.
c5101a77
PE
3251 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3252 * data.c (arith_driver, float_arith_driver): Likewise.
3253 * editfns.c (general_insert_function): Likewise.
3254 * eval.c (struct backtrace.nargs, interactive_p)
3255 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3256 (funcall_lambda, mark_backtrace): Likewise.
3257 * fns.c (concat): Likewise.
3258 * frame.c (x_set_frame_parameters): Likewise.
3259 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3260 0 if not found, not -1. All callers changed.
3261
dd3f25f7
PE
3262 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3263 (stack_copy_size): Now size_t, not int.
3264 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3265
461c2ab9
JB
32662011-03-28 Juanma Barranquero <lekktu@gmail.com>
3267
3268 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3269 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3270 All callers changed.
3271
3272 * lisp.h (multibyte_char_to_unibyte):
3273 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3274 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3275 * character.h (CHAR_TO_BYTE8):
3276 * cmds.c (internal_self_insert):
3277 * editfns.c (general_insert_function):
3278 * keymap.c (push_key_description):
3279 * search.c (Freplace_match):
3280 * xdisp.c (message_dolog, set_message_1): All callers changed.
3281
f6d62986
SM
32822011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3283
3284 * keyboard.c (safe_run_hook_funcall): New function.
3285 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3286 don't set the hook to nil, but remove the offending function instead.
3287 (Qcommand_hook_internal): Remove, unused.
3288 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3289 Vcommand_hook_internal.
3290
3291 * eval.c (enum run_hooks_condition): Remove.
3292 (funcall_nil, funcall_not): New functions.
3293 (run_hook_with_args): Call each function through a `funcall' argument.
3294 Remove `cond' argument, now redundant.
3295 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3296 (Frun_hook_with_args_until_failure): Adjust accordingly.
3297 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3298
1db5b1ad
JB
32992011-03-28 Juanma Barranquero <lekktu@gmail.com>
3300
3301 * dispextern.h (string_buffer_position): Remove declaration.
3302
3303 * print.c (strout): Remove parameter `multibyte', unused since
3304 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3305
3306 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3307 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3308 All callers changed.
3309
3310 * w32.c (_wsa_errlist): Use braces for struct initializers.
3311
3312 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3313 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3314 All callers changed.
3315 (string_buffer_position): Likewise. Also, make static (it's never
3316 used outside xdisp.c).
3317 (cursor_row_p): Remove parameter `w', unused since
3318 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3319 (decode_mode_spec): Remove parameter `precision', introduced during
3320 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3321 All callers changed.
3322
5ffb62aa
JD
33232011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3324
3325 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3326
461c2ab9 33272011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
3328
3329 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3330 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3331 (ns_update_auto_hide_menu_bar): New functions.
3332 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3333 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3334 ns_constrain_all_frames.
3335 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3336 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3337
5c380ffb
JD
33382011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3339
3340 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3341
9af30bdf
GM
33422011-03-27 Glenn Morris <rgm@gnu.org>
3343
3344 * syssignal.h: Replace RETSIGTYPE with void.
3345 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3346 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3347 Replace SIGTYPE with void everywhere.
3348 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3349 * s/template.h (SIGTYPE): Remove commented out definition.
3350
e2abce01
JB
33512011-03-26 Eli Zaretskii <eliz@gnu.org>
3352
3353 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3354 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3355
f868cd8a
JB
33562011-03-26 Juanma Barranquero <lekktu@gmail.com>
3357
59eb0929
JB
3358 * w32.c (read_unc_volume): Use parameter `henum', instead of
3359 global variable `wget_enum_handle'.
3360
3361 * keymap.c (describe_vector): Remove parameters `indices' and
3362 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3363 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3364
f868cd8a
JB
3365 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3366
3367 * keyboard.c (timer_check): Remove parameter `do_it_now',
3368 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3369 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3370 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3371
3372 * keyboard.c (read_char):
3373 * w32menu.c (w32_menu_display_help):
3374 * xmenu.c (show_help_event, menu_help_callback):
3375 Adjust calls to `show_help_echo'.
3376
3377 * gtkutil.c (xg_maybe_add_timer):
3378 * keyboard.c (readable_events):
3379 * process.c (wait_reading_process_output):
3380 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3381
3382 * insdel.c (adjust_markers_gap_motion):
3383 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3384 (gap_left, gap_right): Don't call it.
3385
2ecf6fdb
CY
33862011-03-25 Chong Yidong <cyd@stupidchicken.com>
3387
3388 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3389 incurred during fontification.
3390
6b1f9ba4
JB
33912011-03-25 Juanma Barranquero <lekktu@gmail.com>
3392
3393 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3394 (DEFVAR_PER_BUFFER): Don't pass it.
3395
3396 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3397 (scrolling_window): Don't pass it.
3398
0f4a96b5
JB
33992011-03-25 Juanma Barranquero <lekktu@gmail.com>
3400
3401 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3402
3403 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3404 and `suffix'.
3405 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3406 of variables specific to SELinux and computation of `encoded_absname'.
3407
3408 * image.c (XPutPixel): Remove unused variable `height'.
3409
3410 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3411
3412 * unexw32.c (get_section_info): Remove unused variable `section'.
3413
3414 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3415 (system_process_attributes): Remove unused variable `sess'.
3416 (sys_read): Remove unused variable `err'.
3417
3418 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3419 (w32_wnd_proc): Remove unused variable `isdead'.
3420 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3421 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3422 (x_create_tip_frame): Remove unused variable `tem'.
3423
3424 * w32inevt.c (w32_console_read_socket):
3425 Remove unused variable `no_events'.
3426
3427 * w32term.c (x_draw_composite_glyph_string_foreground):
3428 Remove unused variable `width'.
3429
1149507c
JB
34302011-03-24 Juanma Barranquero <lekktu@gmail.com>
3431
3432 * w32term.c (x_set_glyph_string_clipping):
3433 Don't pass uninitialized region to CombineRgn.
3434
9c88f339
JB
34352011-03-23 Juanma Barranquero <lekktu@gmail.com>
3436
3437 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3438 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3439 (Fx_close_connection): Remove unused variable `i'.
3440
3441 * w32font.c (w32font_draw): Return number of glyphs.
3442 (w32font_open_internal): Remove unused variable `i'.
3443 (w32font_driver): Add missing initializer.
3444
3445 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3446 (fill_in_menu): Remove unused variable `items_added'.
3447
3448 * w32term.c (last_mouse_press_frame): Remove static global variable.
3449 (w32_clip_to_row): Remove unused variable `f'.
3450 (x_delete_terminal): Remove unused variable `i'.
3451
3452 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3453 (NOTHING): Remove unused static global variable.
3454 (uniscribe_check_otf): Remove unused variable `table'.
3455 (uniscribe_font_driver): Add missing initializers.
3456
dee091a3
JD
34572011-03-23 Julien Danjou <julien@danjou.info>
3458
3459 * term.c (Fsuspend_tty, Fresume_tty):
3460 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3461 * window.c (temp_output_buffer_show):
3462 * insdel.c (signal_before_change):
3463 * frame.c (Fhandle_switch_frame):
3464 * fileio.c (Fdo_auto_save):
3465 * emacs.c (Fkill_emacs):
3466 * editfns.c (save_excursion_restore):
3467 * cmds.c (internal_self_insert):
3468 * callint.c (Fcall_interactively):
3469 * buffer.c (Fkill_all_local_variables):
3470 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3471 Use Frun_hooks.
0f4a96b5 3472 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
3473 unconditionnaly since it does the check itself.
3474
2c520ab5 34752011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 3476
c9c49752
PE
3477 Fix more problems found by GCC 4.5.2's static checks.
3478
8abc3f12
PE
3479 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3480 the first time through the loop, since we know p0 < p1 then.
3481 This also avoids a gcc -Wstrict-overflow warning.
3482
a2d26660
PE
3483 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3484 leading to a memory leak, possible in functions like
3485 load_charset_map_from_file that can allocate an unbounded number
b12ef411 3486 of objects (Bug#8318).
a2d26660 3487
916c72e9
PE
3488 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3489 that could (at least in theory) be that large.
3490
19ab8a18
PE
3491 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3492 This is less likely to overflow, and avoids undefined behavior if
3493 overflow does occur. All callers changed. Use strtoul to scan
3494 for the unsigned long integer.
b7cbbd6f
PE
3495 (pint2hrstr): Simplify and tune code slightly.
3496 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 3497
f0641eff
PE
3498 * scroll.c (do_scrolling): Work around GCC bug 48228.
3499 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3500
7f650bb9
PE
3501 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3502 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
3503 (validate_x_resource_name): Simplify count usage.
3504 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 3505
37dd57d1
PE
3506 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3507 fail (Bug#8306).
81e56e61 3508
699979fc 3509 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 3510
401bf9b4
PE
3511 * process.c (Fmake_network_process): Use socklen_t, not int,
3512 where POSIX says socklen_t is required in portable programs.
3513 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 3514 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
3515 (Fmake_network_process, server_accept_connection):
3516 (wait_reading_process_output, read_process_output):
3517 Likewise.
3518
b93aacde
PE
3519 * process.c: Rename or move locals to avoid shadowing.
3520 (list_processes_1, Fmake_network_process):
3521 (read_process_output_error_handler, exec_sentinel_error_handler):
3522 Rename or move locals.
4dc343ee 3523 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 3524 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 3525 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 3526 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 3527 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 3528
af8a867c 3529 Make tparam.h and terminfo.c consistent.
44f230aa
SM
3530 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3531 Include tparam.h instead, since it declares them.
af8a867c
PE
3532 * cm.h (PC): Remove extern decl; tparam.h now does this.
3533 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3534 * terminfo.c: Include tparam.h, to check interfaces.
3535 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3536 (tparam): Adjust signature to match interface in tparam.h;
3537 this removes some undefined behavior. Check that outstring and len
3538 are zero, which they always are with Emacs.
3539 * tparam.h (PC, BC, UP): New extern decls.
3540
0248044d 3541 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 3542 (xftfont_open): Rename locals to avoid shadowing.
0248044d 3543
8ff096c1 3544 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
3545 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3546 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 3547 (ftfont_list): Remove unused local.
49eaafba
PE
3548 (get_adstyle_property, ftfont_pattern_entity):
3549 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3550 Rename locals to avoid shadowing.
8ff096c1 3551
e2be39f6
PE
3552 * xfont.c (xfont_list_family): Mark var as initialized.
3553
c9735e30
PE
3554 * xml.c (make_dom): Now static.
3555
8f5201ae
PE
3556 * composite.c (composition_compute_stop_pos): Rename local to
3557 avoid shadowing.
b246f932
PE
3558 (composition_reseat_it): Remove unused locals.
3559 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 3560 (composition_update_it): Mark var as initialized.
11b61122
PE
3561 (find_automatic_composition): Mark vars as initialized,
3562 with a FIXME (Bug#8290).
8f5201ae 3563
760fbc2c
PE
3564 character.h: Rename locals to avoid shadowing.
3565 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3566 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3567 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3568 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3569 to avoid shadowing.
3570
ff08eb85
PE
3571 * textprop.c (property_change_between_p): Remove; unused.
3572
fc7bf025
PE
3573 * intervals.c (interval_start_pos): Now static.
3574
235d7abc
PE
3575 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3576
44f230aa
SM
3577 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3578 Rename locals to avoid shadowing.
3e7d6594 3579
50060332
PE
3580 * sound.c (wav_play, au_play, Fplay_sound_internal):
3581 Fix pointer signedness.
d01f234b 3582 (alsa_choose_format): Remove unused local var.
c83b8872
PE
3583 (wav_play): Initialize a variable to 0, to prevent undefined
3584 behavior (Bug#8278).
50060332 3585
c4fc4e30
PE
3586 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3587
918436ed
PE
3588 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3589
c939f91b
PE
3590 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3591 clobbering (Bug#8298).
b9c7f648
PE
3592 * sysdep.c (sys_subshell): Likewise.
3593 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 3594
6bd8c144
PE
3595 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3596 This should get cleaned up, so that child_setup has the
3597 same signature on all platforms.
3598
7710357c 3599 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 3600 (relocate_fd): Rename locals to avoid shadowing.
7710357c 3601
c59da222
CY
36022011-03-22 Chong Yidong <cyd@stupidchicken.com>
3603
3604 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3605 not to be necessary, and produces flickering.
3606
66b87493
GM
36072011-03-20 Glenn Morris <rgm@gnu.org>
3608
3609 * config.in: Remove file.
3610
45b6f6d5
JB
36112011-03-20 Juanma Barranquero <lekktu@gmail.com>
3612
3613 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3614 are now in src/globals.h.
3615 (syms_of_minibuf): Remove spurious & from previous change.
3616
3ec03f7e
LL
36172011-03-20 Leo <sdl.web@gmail.com>
3618
3619 * minibuf.c (completing-read-function): New variable.
3620 (completing-read-default): Rename from completing-read.
3621 (completing-read): Call completing-read-function.
3622
b14e3e21
CY
36232011-03-19 Juanma Barranquero <lekktu@gmail.com>
3624
3625 * xfaces.c (Fx_load_color_file):
3626 Read color file from absolute filename (bug#8250).
3627
f2b726e6
JB
36282011-03-19 Juanma Barranquero <lekktu@gmail.com>
3629
3630 * makefile.w32-in: Update dependencies.
3631
09f6ff02
EZ
36322011-03-17 Eli Zaretskii <eliz@gnu.org>
3633
3634 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3635
29a6015a
PE
36362011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3637
a3a6c54e
PE
3638 Fix more problems found by GCC 4.5.2's static checks.
3639
b766f867
PE
3640 * process.c (make_serial_process_unwind, send_process_trap):
3641 (sigchld_handler): Now static.
3642
be02381c
PE
3643 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3644 That way, the code declares only the vars that it needs.
3645 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3646 * s/cygwin.h (PTY_ITERATION): Likewise.
3647 * s/darwin.h (PTY_ITERATION): Likewise.
3648 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3649
57048744
PE
3650 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3651 * process.c (allocate_pty): Don't declare stb unless it's needed.
3652
7914961c 3653 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
3654 (CONSTANTLIM): Remove; unused.
3655 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3656 Define only if needed.
7914961c 3657
b3967b18
PE
3658 * unexelf.c (unexec): Name an expression,
3659 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
3660 Use a different way to cause a compilation error if anyone uses
3661 n rather than nn, a way that does not involve shadowing.
73366a00 3662 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 3663
29a6015a
PE
3664 * deps.mk (unexalpha.o): Remove; unused.
3665
43cfc33e 3666 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 3667 * unexec.h: New file.
ce701a33
PE
3668 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3669 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3670 Depend on unexec.h.
3671 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3672 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3673 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 3674 Change as necessary to match prototype in unexec.h.
ce701a33 3675
01f44d5a
PE
3676 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3677 shadowing.
4f63c6bb 3678 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 3679
a6670b0b
PE
3680 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3681 Rename locals to avoid shadowing.
3682
cef2010d 3683 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 3684 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 3685
d4d7173a
PE
3686 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3687
f08b802a
PE
3688 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3689 warning when compiling print.c.
3690
3ddb0639
PE
3691 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3692 instead of using an uninitialized var.
5ad03b97 3693 (font_sort_entities): Mark var as initialized.
3ddb0639 3694
170a2692
PE
3695 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3696
e663c700
PE
3697 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3698 pointers to constants.
89bc529a 3699 (font_parse_fcname): Remove unused vars.
7b81e2d0 3700 (font_delete_unmatched): Now static.
ea838e10 3701 (font_get_spec): Remove; unused.
13a547c6
PE
3702 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3703 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3704 Rename or move locals to avoid shadowing.
e663c700 3705
2a80c887 3706 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 3707 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 3708
1384fa33 3709 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 3710 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 3711
8b2c52e9
PE
3712 * alloc.c (mark_backtrace): Move decl from here ...
3713 * lisp.h: ... to here, so that it can be checked.
3714
475545b5 3715 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 3716 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
3717 (lisp_indirect_variable): Name an expression,
3718 to avoid gcc -Wbad-function-cast warning.
1faed8ae 3719 (Fdefvar): Rename locals to avoid shadowing.
475545b5 3720
b1349114 3721 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 3722 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 3723 Use const pointer when appropriate.
b1349114 3724
a2928364
PE
3725 * lisp.h (get_system_name, get_operating_system_release):
3726 Move decls here, to check interfaces.
3727 * process.c (get_operating_system_release): Move decl to lisp.h.
3728 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
3729 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3730 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3731 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
3732 (Fformat_time_string, Fencode_time, Finsert_char):
3733 (Ftranslate_region_internal, Fformat):
3734 Rename or remove local vars to avoid shadowing.
9710023e 3735 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 3736
a415e694
PE
3737 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3738 avoid shadowing.
3739
8ef4622d
PE
3740 * lisp.h (eassert): Check that the argument compiles, even if
3741 ENABLE_CHECKING is not defined.
3742
946f9a5b
PE
3743 * data.c (Findirect_variable): Name an expression, to avoid
3744 gcc -Wbad-function-cast warning.
112396d6 3745 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 3746 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
3747 (Fmake_variable_buffer_local, Fmake_local_variable):
3748 Mark variables as initialized.
52746918 3749 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 3750
e5aab7e7 3751 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
3752 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
3753 Rename locals to avoid shadowing.
dff45157
PE
3754 (mark_stack): Move local variables into the #ifdef region where
3755 they're used.
7bc26fdb
PE
3756 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
3757 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
3758 needed otherwise.
3759 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
3760 (GC_STRING_CHARS): Remove; not used.
d40d4be1 3761 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 3762
e5aab7e7
PE
3763 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
3764 avoids undefined behavior in theory.
3765
4da60324
PE
3766 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
3767
88043301
PE
3768 Use functions, not macros, for up- and down-casing (Bug#8254).
3769 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3770 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
3771 to use the following functions instead of these macros.
3772 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
3773 EMACS_INT, since callers assume the returned value fits in int.
3774 (upcase1): Likewise, for UPCASE_TABLE.
3775 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 3776 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 3777 the race-condition problem in the old DOWNCASE.
88043301 3778
19ed5445
PE
3779 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
3780 Rename locals to avoid shadowing.
3781 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
3782 (regex_compile, re_search_2, re_match_2_internal):
3783 Remove unused local vars.
952db0d7
PE
3784 (FREE_VAR): Rewrite so as not to use empty "else",
3785 which gcc can warn about.
da053e48 3786 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
3787 (RETALLOC_IF): Define only if needed.
3788 (WORDCHAR_P): Likewise. This one is never needed, but is used
3789 only in a comment talking about a compiler bug, so put inside
3790 the #if 0 of that comment.
3791 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
3792 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
3793 Remove; unused.
19ed5445 3794
1f3561e4 3795 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
3796 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
3797 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 3798
ded6f8f7
PE
3799 * search.c (simple_search): Remove unused var.
3800
dbd37a95
PE
3801 * dired.c (compile_pattern): Move decl from here ...
3802 * lisp.h: ... to here, so that it can be checked.
3803 (struct re_registers): New forward decl.
3804
7e47afad
PE
3805 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3806
85f24f61
PE
3807 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3808 All uses changed.
3809 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3810 Rename locals to avoid shadowing.
5671df8f 3811 (Fvertical_motion): Mark locals as initialized.
85f24f61 3812
181aa2be 3813 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 3814 (casify_region): Mark local as initialized.
181aa2be 3815
930d429c
PE
3816 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3817
7082eac6
PE
3818 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3819 New macros, so that the caller can use some names other than
3820 gcpro1, gcpro2, etc.
3821 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3822 of the new macros.
3823 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3824 argument, for consistency with GCPRO2_VAR, etc: it is now the
3825 prefix of the variable, not the variable itself. All uses
3826 changed.
38b2c076
PE
3827 * dired.c (directory_files_internal, file_name_completion):
3828 Rename locals to avoid shadowing.
3829
15206ed9
PE
3830 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3831 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3832 dired.c's scmp function, had undefined behavior.
3833 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3834 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3835 * buffer.h: ... to here, because these macros use current_buffer,
3836 and the new implementation with inline functions needs to have
3837 current_buffer in scope now, rather than later when the macros
3838 are used.
3839 (downcase, upcase1): New static inline functions.
3840 (DOWNCASE, UPCASE1): Reimplement using these functions.
3841 This avoids undefined behavior in expressions like
3842 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3843 from race conditions in accessing the global variables
3844 case_temp1 and case_temp2.
3845 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3846 * lisp.h (case_temp1, case_temp2): Remove their decls.
3847 * character.h (ASCII_CHAR_P): Move from here ...
3848 * lisp.h: ... to here, so that the inline functions mentioned
3849 above can use them.
3850
4a6bea26
PE
3851 * dired.c (directory_files_internal_unwind): Now static.
3852
f14b7e14
PE
3853 * fileio.c (file_name_as_directory, directory_file_name):
3854 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
3855 Now static.
2893f146
PE
3856 (file_name_as_directory): Use const pointers when appropriate.
3857 (Fexpand_file_name): Likewise. In particular, newdir might
3858 point at constant storage, so make it a const pointer.
fd4ead52 3859 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
3860 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
3861 signedness issues.
f839df0c
PE
3862 (Fset_file_times, Finsert_file_contents, auto_save_error):
3863 Rename locals to avoid shadowing.
f14b7e14 3864
5716756e 3865 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
3866 (Ftry_completion, Fall_completions): Rename or remove locals
3867 to avoid shadowing.
5716756e 3868
b4c3046a
PE
3869 * marker.c (bytepos_to_charpos): Remove; unused.
3870
b45db522
PE
3871 * lisp.h (verify_bytepos, count_markers): New decls,
3872 so that gcc does not warn that these functions aren't declared.
3873
85876d07
PE
3874 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
3875 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 3876 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 3877 (copy_text): Remove unused local var.
85876d07 3878
03d78a21 3879 * filelock.c (within_one_second): Now static.
b3dd38ab 3880 (lock_file_1): Rename local to avoid shadowing.
03d78a21 3881
5df8f01b
PE
3882 * buffer.c (fix_overlays_before): Mark locals as initialized.
3883 (fix_start_end_in_overlays): Likewise. This function should be
3884 simplified by using pointers-to-pointers, but that's a different
3885 matter.
b1d876f1 3886 (switch_to_buffer_1): Now static.
8f54f30a
PE
3887 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
3888 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 3889
a70072c9 3890 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 3891 Fix pointer signedness issue.
edced198
PE
3892 (sys_subshell): Mark local as volatile if checking for lint,
3893 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 3894 (MAXPATHLEN): Define only if needed.
a70072c9 3895
a0977c44
PE
3896 * process.c (serial_open, serial_configure): Move decls from here ...
3897 * systty.h: ... to here, so that they can be checked.
3898
a884fdcc
PE
3899 * fns.c (get_random, seed_random): Move extern decls from here ...
3900 * lisp.h: ... to here, so that they can be checked.
3901
604efe86 3902 * sysdep.c (reset_io): Now static.
b8950c94 3903 (wait_for_termination_signal): Remove; unused.
604efe86 3904
38fc62d9
PE
3905 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
3906 (copy_keymap_item, append_key, push_text_char_description):
3907 Now static.
1004a21a 3908 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 3909 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
3910 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
3911 (describe_map_tree):
3912 Rename locals to avoid shadowing.
38fc62d9 3913
2f2650da
PE
3914 * keyboard.c: Declare functions static if they are not used elsewhere.
3915 (echo_char, echo_dash, cmd_error, top_level_2):
3916 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
3917 (read_char, kbd_buffer_get_event, make_lispy_position):
3918 (make_lispy_event, make_lispy_movement, apply_modifiers):
3919 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
3920 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
3921 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 3922 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 3923 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 3924
a053e86c 3925 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
3926 (mark_kboards): Move decl here ...
3927 * alloc.c (mark_kboards): ... from here.
a053e86c 3928
4752793e
PE
3929 * lisp.h (force_auto_save_soon): New decl.
3930
74f10ca7 3931 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
3932 (DEFINE_DUMMY_FUNCTION): New macro.
3933 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
3934 Use it.
c03cd23f
PE
3935 (main): Add casts to avoid warnings
3936 if GCC considers string literals to be constants.
74f10ca7 3937
022e70d4
PE
3938 * lisp.h (fatal_error_signal): Add decl, since it's exported.
3939
59d6fe83
PE
3940 * dbusbind.c: Pointer signedness fixes.
3941 (xd_signature, xd_append_arg, xd_initialize):
3942 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3943 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3944 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
3945 (Fdbus_register_signal): Use SSDATA when the context wants char *.
3946
78320123
PE
3947 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
3948 if GCC considers string literals to be constants.
49cebcca 3949 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 3950
35ac2a97
SM
39512011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
3952
fb103ca9
SM
3953 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
3954 (print_preprocess, print_object): New macro to fix last change.
3955
35ac2a97
SM
3956 * print.c (print_preprocess): Don't forget font objects.
3957
62973b41
JB
39582011-03-16 Juanma Barranquero <lekktu@gmail.com>
3959
3960 * emacs.c (USAGE3): Doc fixes.
3961
0e48bb22
AS
39622011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3963
3964 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3965 structure.
3966
7684e57b
JB
39672011-03-14 Juanma Barranquero <lekktu@gmail.com>
3968
3969 * lisp.h (VWindow_system, Qfile_name_history):
3970 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3971 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3972 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3973
3974 * w32select.c: Don't #include "keyboard.h".
c96bbc66 3975 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
3976
3977 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3978 * w32console.c (detect_input_pending, read_input_pending)
3979 (encode_terminal_code):
3980 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3981 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3982 (w32_system_caret_y, Qfile_name_history):
3983 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3984 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3985 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3986 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3987 * w32proc.c (Qlocal, report_file_error):
3988 * w32term.c (Vwindow_system, updating_frame):
3989 * w32uniscribe.c (initialized, uniscribe_font_driver):
3990 Remove unneeded extern declarations.
3991
2aa46d6c
CY
39922011-03-14 Chong Yidong <cyd@stupidchicken.com>
3993
c96bbc66 3994 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 3995
cffc6f3b
CY
39962011-03-13 Chong Yidong <cyd@stupidchicken.com>
3997
3998 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3999 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4000 These macros can no longer be used for assignment.
4001
44f230aa
SM
4002 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4003 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
4004 (record_buffer_markers, fetch_buffer_markers): New functions for
4005 recording and fetching special buffer markers.
4006 (set_buffer_internal_1, set_buffer_temp): Use them.
4007
4008 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4009
4010 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4011
4012 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4013 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4014
4015 * xdisp.c (hscroll_window_tree):
4016 (reconsider_clip_changes): Use PT instead of BUF_PT.
4017
d251f04b
EZ
40182011-03-13 Eli Zaretskii <eliz@gnu.org>
4019
4020 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4021 $(EMACS_ROOT)/lib/intprops.h.
4022
f0c77cd1
PE
40232011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4024
3eca4629
PE
4025 Fix more problems found by GCC 4.5.2's static checks.
4026
7c86ee98
PE
4027 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4028 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
4029 (xg_free_frame_widgets): Make it clear that a local variable is
4030 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
4031 (gdk_window_get_screen): Make it clear that this macro is needed
4032 only if USE_GTK_TOOLTIP.
1e5524e7
PE
4033 (int_gtk_range_get_value): New function, which avoids a diagnostic
4034 from gcc -Wbad-function-cast.
4035 (xg_set_toolkit_scroll_bar_thumb): Use it.
4036 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4037 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
4038 (get_utf8_string, xg_get_file_with_chooser):
4039 Rename locals to avoid shadowing.
4040 (create_dialog): Move locals to avoid shadowing.
7c86ee98 4041
41729b81
PE
4042 * xgselect.c (xg_select): Remove unused var.
4043
f0c77cd1
PE
4044 * image.c (four_corners_best): Mark locals as initialized.
4045 (gif_load): Initialize transparent_p to zero (Bug#8238).
4046 Mark another local as initialized.
ec6cf4c6 4047 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 4048
ce0ad53d 4049 * image.c (clear_image_cache): Now static.
d5d5a617 4050 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 4051 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
4052 (x_edge_detection): Remove unnecessary cast that
4053 gcc -Wbad-function-cast diagnoses.
2037898d 4054 (gif_load): Fix pointer signedness.
6ae141d6
PE
4055 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4056 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 4057
33383987 40582011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 4059
d32df629
PE
4060 Improve quality of tests for time stamp overflow.
4061 For example, without this patch (encode-time 0 0 0 1 1
4062 1152921504606846976) returns the obviously-bogus value (-948597
4063 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4064 reports time overflow. See
4065 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
4066 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4067 * editfns.c: Include limits.h and intprops.h.
4068 (TIME_T_MIN, TIME_T_MAX): New macros.
4069 (time_overflow): Move earlier, to before first use.
4070 (hi_time, lo_time): New functions, for an accurate test for
4071 out-of-range times.
4072 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4073 (Fget_internal_run_time): Don't assume time_t fits in int.
4074 (make_time): Use list2 instead of Fcons twice.
4075 (Fdecode_time): More accurate test for out-of-range times.
4076 (check_tm_member): New function.
4077 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
4078 (lisp_time_argument): Don't rely on undefined left-shift and
4079 right-shift behavior when checking for time stamp overflow.
8be6f318 4080
fe31d94c
PE
4081 * editfns.c (time_overflow): New function, refactoring common code.
4082 (Fformat_time_string, Fdecode_time, Fencode_time):
4083 (Fcurrent_time_string): Use it.
4084
8be6f318
PE
4085 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4086 * dired.c (make_time): Move to ...
4087 * editfns.c (make_time): ... here.
4088 * systime.h: Note the move.
4089
09d9db2c 40902011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 4091
126bc0dc
YM
4092 * fringe.c (update_window_fringes): Remove unused variables.
4093
c47cbdfd
YM
4094 * unexmacosx.c (copy_data_segment): Also copy __got section.
4095 (Bug#8223)
4096
7ac80be9
EZ
40972011-03-12 Eli Zaretskii <eliz@gnu.org>
4098
c96bbc66 4099 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
4100 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4101 Constify `char *' arguments and their references according to
4102 prototypes in tparam.h.
4103
ecb0f94d 4104 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 4105
7ac80be9
EZ
4106 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4107 Adapt all references accordingly.
4108
4109 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4110
ef1fd07e
TT
41112011-03-11 Tom Tromey <tromey@redhat.com>
4112
4113 * buffer.c (syms_of_buffer): Remove obsolete comment.
4114
7ef4b50c
EZ
41152011-03-11 Eli Zaretskii <eliz@gnu.org>
4116
4117 * termhooks.h (encode_terminal_code): Declare prototype.
4118
4119 * msdos.c (encode_terminal_code): Don't declare prototype.
4120
4121 * term.c (encode_terminal_code): Now external again, used by
4122 w32console.c and msdos.c.
4123
44f230aa
SM
4124 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4125 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 4126
4b1ec863 41272011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 4128
1714f52b 4129 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 4130
4b1ec863
PE
4131 * fringe.c (update_window_fringes): Mark locals as initialized
4132 (Bug#8227).
4133 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 4134
524c7aa6
PE
4135 * alloc.c (mark_fringe_data): Move decl from here ...
4136 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4137 to check its interface.
4138 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4139
a5c0af81 4140 * fontset.c (free_realized_fontset): Now static.
7519b8cd 4141 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 4142 (fontset_font): Mark local as initialized.
a9a06e0b 4143 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 4144
b4716021
PE
4145 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4146
811e9bac 4147 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 4148 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
4149 (x_own_selection, Fx_disown_selection_internal): Rename locals
4150 to avoid shadowing.
4151 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 4152
7e3ab302
PE
4153 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4154 so that the caller can use some name other than gcpro1.
4155 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
4156 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4157 (Fx_backspace_delete_keys_p):
4158 Use them to avoid shadowing, and rename vars to avoid shadowing.
4159 (x_decode_color, x_set_name, x_window): Now static.
6b437900 4160 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 4161 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
4162 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4163 Remove unused locals.
7e3ab302
PE
4164 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4165 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4166 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4167 macros.
f78faa98 4168
e2b13473
PE
4169 * xterm.h (x_mouse_leave): New decl.
4170
77f23912
PE
4171 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4172 Remove unused functions.
cdf4ba58
PE
4173 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4174 (x_calc_absolute_position): Now static.
7411c686 4175 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 4176 Don't declare local "event" unless it's used.
ed7bf3a5
PE
4177 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4178 unless they are used.
38d0b34a
PE
4179 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4180 (x_fatal_error_signal): Remove; not used.
a6067996
PE
4181 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4182 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4183 (x_error_catcher, x_connection_closed, x_error_handler):
4184 (x_error_quitter, xembed_send_message, x_iconify_frame):
4185 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 4186 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 4187 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 4188
44f230aa
SM
4189 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4190 Rename or move locals to avoid shadowing.
6b463e58 4191 (tty_defined_color, merge_face_heights): Now static.
5967d051 4192 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
4193 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4194 does not deduce is never used uninitialized.
73719eba
PE
4195 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4196 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 4197
426994c3 4198 * terminal.c (store_terminal_param): Now static.
5489860b 4199
032f1620 4200 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 4201 (set_frame_menubar): Remove unused local.
d4323972 4202 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
4203 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4204 since they might point to immutable storage.
281585b0
PE
4205 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4206 since it's unused otherwise.
032f1620 4207
367c19e5 4208 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 4209 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
4210 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4211 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 4212 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
4213 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4214 does not deduce are never used uninitialized.
70739cbe 4215
07b48fa9
PE
4216 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4217
8868a238 4218 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
4219 * window.c (window_loop, size_window):
4220 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 4221
7e5cf297 4222 * window.c (display_buffer): Now static.
d6550a9f
PE
4223 (size_window): Mark variables that gcc -Wuninitialized
4224 does not deduce are never used uninitialized.
a586633d
PE
4225 * window.h (check_all_windows): New decl, to forestall
4226 gcc -Wmissing-prototypes diagnostic.
5b555da1 4227 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 4228
f6095868
PE
4229 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4230 shadowing.
4231 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
4232 Include <limits.h>.
4233 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4234 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
4235 (load_charset_map): Mark variables that gcc -Wuninitialized
4236 does not deduce are never used uninitialized.
53df7c11 4237 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 4238
f38b440c
PE
4239 * coding.c (coding_set_source, coding_set_destination):
4240 Use "else { /* comment */ }" rather than "else /* comment */;"
4241 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
4242 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4243 a block, when the outer 'i' will do.
4244 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4245 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4246 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4247 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4248 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4249 Rename locals to avoid shadowing.
4250 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
4251 * coding.c (emacs_mule_char, encode_invocation_designation):
4252 Now static, since they're not used elsewhere.
413bb2db 4253 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 4254 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
4255 (decode_coding_emacs_mule): Mark variables that gcc
4256 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
4257 (detect_coding_iso_2022): Initialize a local variable that might
4258 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 4259 this initialization is needed. (Bug#8211)
5f58e762
PE
4260 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4261 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4262 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4263 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4264 Remove unused macros.
f38b440c 4265
232b38b9 4266 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 4267 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 4268 * character.c (string_count_byte8): Likewise.
232b38b9 4269
fb90da1b
PE
4270 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4271 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4272
fb93dbc2
PE
4273 * chartab.c (copy_sub_char_table): Now static, since it's not used
4274 elsewhere.
5c156ace
PE
4275 (sub_char_table_ref_and_range, char_table_ref_and_range):
4276 Rename locals to avoid shadowing.
bbcd0949 4277 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 4278
7d3b3862 4279 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 4280 (BIDI_BOB): Remove unused macro.
7d3b3862 4281
6be7d3da
PE
4282 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4283 deduce are never used uninitialized.
c2ed9c8b 4284 * term.c (encode_terminal_code): Likewise.
6be7d3da 4285
75f8807f 4286 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 4287
50938595
PE
4288 * tparam.h: New file.
4289 * term.c, tparam.h: Include it.
4290 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4291 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4292 Move these decls to tparam.h, and make them agree with what
4293 is actually in tparam.c. The previous trick of using incompatible
4294 decls in different modules does not conform to the C standard.
4295 All callers of tparam changed to use tparam's actual API.
4296 * tparam.c (tparam1, tparam, tgoto):
4297 Use const pointers where appropriate.
4298
fbceeba2
PE
4299 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4300 * cm.h (struct cm): Likewise.
4301 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4302 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4303 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4304 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4305 (turn_on_face, init_tty): Likewise.
4306 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 4307
7f3f1250
PE
4308 * term.c (term_mouse_position): Rename local to avoid shadowing.
4309
e6ca6543
PE
4310 * alloc.c (mark_ttys): Move decl from here ...
4311 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4312
c40f8d15
AS
43132011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4314
4315 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4316
cfe0661d
JB
43172011-03-09 Juanma Barranquero <lekktu@gmail.com>
4318
4319 * search.c (compile_pattern_1): Remove argument regp, unused since
4320 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4321 (compile_pattern): Don't pass it.
4322
0afb4571
J
43232011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4324
4325 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4326 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4327 for ! HAVE_GTK3.
4328 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4329
4330 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4331
4332 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4333 gdk_window_get_screen, gdk_window_get_geometry,
4334 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4335 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4336 (xg_get_pixbuf_from_pixmap): New function.
4337 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4338 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4339 Call xg_get_pixbuf_from_pixmap instead of
4340 gdk_pixbuf_get_from_drawable.
4341 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4342 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4343 (xg_check_special_colors): Use GtkStyleContext and its functions
4344 for HAVE_GTK3.
4345 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4346 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4347 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
4348 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4349 Call gtk_widget_get_preferred_size.
0afb4571
J
4350 (xg_frame_resized): gdk_window_get_geometry only takes 5
4351 parameters.
44f230aa
SM
4352 (xg_win_to_widget, xg_event_is_for_menubar):
4353 Call gdk_x11_window_lookup_for_display.
0afb4571
J
4354 (xg_set_widget_bg): New function.
4355 (delete_cb): New function.
895009e1 4356 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
4357 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4358 (xg_set_background_color): Call xg_set_widget_bg.
4359 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4360 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4361 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4362 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4363 if ! HAVE_GTK3.
4364 (update_frame_tool_bar): Call gtk_widget_hide.
4365 (xg_initialize): Use GDK_KEY_g.
4366
4367 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4368 if ! HAVE_GTK3
4369 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4370
4371 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4372 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4373 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4374
1c2cc4ef
JB
43752011-03-08 Juanma Barranquero <lekktu@gmail.com>
4376
4377 * w32xfns.c (select_palette): Check success of RealizePalette against
4378 GDI_ERROR, not zero.
4379
33383987 4380See ChangeLog.11 for earlier changes.
aac0c6e3
MR
4381
4382;; Local Variables:
4383;; coding: utf-8
aac0c6e3
MR
4384;; End:
4385
33383987 4386 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
4387
4388 This file is part of GNU Emacs.
4389
4390 GNU Emacs is free software: you can redistribute it and/or modify
4391 it under the terms of the GNU General Public License as published by
4392 the Free Software Foundation, either version 3 of the License, or
4393 (at your option) any later version.
4394
4395 GNU Emacs is distributed in the hope that it will be useful,
4396 but WITHOUT ANY WARRANTY; without even the implied warranty of
4397 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4398 GNU General Public License for more details.
4399
4400 You should have received a copy of the GNU General Public License
4401 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.