* alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
[bpt/emacs.git] / src / ChangeLog
CommitLineData
4887c6e2 12011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 2
4e75f29d
PE
3 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4 Define only if needed.
5
90efadd1
PE
6 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 8 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 9
3c647824
PE
10 * dispextern.h (struct redisplay_interface): Rename param
11 to avoid shadowing.
e264f262 12 * termhooks.h (struct terminal): Likewise.
761383f4 13 * xterm.c (xembed_send_message): Likewise.
3c647824 14
b58c5c4a
PE
15 * insdel.c (make_gap_smaller): Define only if
16 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
17
cad59032
PE
18 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
19 it.
20
c339dc2e
PE
21 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
22 so that we aren't warned about unused symbols.
23
91a3e27b
PE
24 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
25
94578f9c
PE
26 * xdisp.c (x_produce_glyphs): Avoid possibly-uninitialized
27 var (Bug#8512).
7a3fb125 28
8ffc96f5
PE
29 * xfns.c (x_real_positions): Mark locals as initialized.
30
eef9bc79
PE
31 * xmenu.c (xmenu_show): Don't use uninitialized vars.
32
098db9dd
PE
33 * xterm.c: Fix problems found by static analysis with other toolkits.
34 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
35 (x_dispatch_event): Declare static if USE_GTK, and
36 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 37 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 38 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
098db9dd
PE
39 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only if
40 defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
41
eb18f6cc
PE
42 * xmenu.c (menu_help_callback): Pointer type fixes.
43 Use const pointers when pointing at readonly data. Avoid pointer
44 signedness clashes.
45 (FALSE): Remove unused macro.
46 (update_frame_menubar): Remove unused decl.
47
1fe72bf8
PE
48 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
49
60d9e1db
PE
50 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
51 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
52 (single_menu_item): Rename local to avoid shadowing.
53
39261c26
PE
54 * keyboard.c (make_lispy_event): Remove unused local var.
55
018c5e19
PE
56 * frame.c, frame.h (x_get_resource_string): Bring this back, but
57 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
58
63d2b86e
PE
59 * bitmaps: Change bitmaps from unsigned char back to the X11
60 compatible char. Avoid the old compiler warnings about
61 out-of-range initializers by using, for example, '\xab' rather
62 than 0xab.
63
aefd87e1
PE
64 * xgselect.c (xgselect_initialize): Check vs interface
65 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
66
bf501fb9
PE
67 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
68
e9829fdf
PE
69 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
70 to read-only memory.
71
1086c095
PE
72 * fns.c (vector): Remove; this old hack is no longer needed.
73
2baccd04 74 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 75 Remove unused var.
dde42981 76 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 77
72391843 78 * xrdb.c (x_load_resources): Omit unused local.
3565b346 79
436c16df 80 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 81 (x_window): Rename locals to avoid shadowing.
dc5ddd85 82 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 83
92bb796d 84 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 85 (x_term_init): Remove local to avoid shadowing.
92bb796d 86
764430a3 87 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
88
89 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
90 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
91
4170f62f 922011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 93
71b41406
PE
94 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
95
9587a89d
PE
96 emacs_write: Accept and return EMACS_INT for sizes.
97 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
98 et seq.
99 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
100 Accept and return EMACS_INT.
101 (emacs_gnutls_write): Return the number of bytes written on
102 partial writes.
103 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
104 (emacs_read, emacs_write): Remove check for negative size, as the
105 Emacs source code has been audited now.
9587a89d
PE
106 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
107 (emacs_read, emacs_write): Use it.
273a5f82
PE
108 * process.c (send_process): Adjust to the new signatures of
109 emacs_write and emacs_gnutls_write. Do not attempt to store
110 a byte offset into an 'int'; it might overflow.
9587a89d 111 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 112
3e047f51
PE
113 * sound.c: Don't assume sizes fit in 'int'.
114 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 115 Return EMACS_INT, not int.
3e047f51 116 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
117 Accept EMACS_INT, not int.
118 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
119 record read return values.
120
cc39a9db
BK
1212011-04-15 Ben Key <bkey76@gmail.com>
122
123 * keyboard.c (Qundefined): Don't declare static since it is
124 used in nsfns.m.
125 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't
126 declare static since they are used in nsfont.m.
127
6c60eb9f
SM
1282011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
129
130 * process.c (Qprocessp): Don't declare static.
131 * lisp.h (Qprocessp): Declare again.
132
7990b61a
JB
1332011-04-15 Juanma Barranquero <lekktu@gmail.com>
134
135 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
136
5d4cb038
PE
1372011-04-14 Paul Eggert <eggert@cs.ucla.edu>
138
8bd7b830 139 Improve C-level modularity by making more things 'static'.
cd64ea1d 140
e3b27b31
PE
141 Don't publish debugger-only interfaces to other modules.
142 * lisp.h (safe_debug_print, debug_output_compilation_hack):
143 (verify_bytepos, count_markers): Move decls to the only modules
144 that need them.
145 * region-cache.h (pp_cache): Likewise.
146 * window.h (check_all_windows): Likewise.
147 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
148
5d4cb038
PE
149 * sysdep.c (croak): Now static, if
150 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
151 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
152
153 * alloc.c (refill_memory_reserve): Now static if
154 !defined REL_ALLOC || defined SYSTEM_MALLOC.
155 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 156
e87b6180
PE
157 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
158 Define only if USE_LUCID.
159
ac64929e
PE
160 * xrdb.c (x_customization_string, x_rm_string): Now static.
161
6f37259d
PE
162 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
163 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
164
1683e3ab
PE
165 * xdisp.c (draw_row_with_mouse_face): Now static.
166 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
167
de9c2632
PE
168 * window.h (check_all_windows): Mark externally visible.
169
2b96acb7
PE
170 * window.c (window_deletion_count): Now static.
171
172 * undo.c: Make symbols static if they're not exported.
173 (last_undo_buffer, last_boundary_position, pending_boundary):
174 Now static.
175
50436f33
PE
176 * textprop.c (interval_insert_behind_hooks): Now static.
177 (interval_insert_in_front_hooks): Likewise.
178
64520e5c
PE
179 * term.c: Make symbols static if they're not exported.
180 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
181 (max_frame_lines, tty_set_terminal_modes):
182 (tty_reset_terminal_modes, tty_turn_off_highlight):
183 (get_tty_terminal): Now static.
184 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
185 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 186 HAVE_WINDOW_SYSTEM.
64520e5c
PE
187 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
188 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
189
1fa53021
PE
190 * sysdep.c: Make symbols static if they're not exported.
191 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
192 Now static.
193 (sigprocmask_set, full_mask): Remove; unused.
194 (wait_debugging): Mark as visible.
195 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
196 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
197
d4b43b22
PE
198 * syntax.c (syntax_temp): Define only if !__GNUC__.
199
b7c513d0
PE
200 * sound.c (current_sound_device, current_sound): Now static.
201
989b29ad
PE
202 * search.c (searchbufs, searchbuf_head): Now static.
203
13a55a78
PE
204 * scroll.c (scroll_cost): Remove; unused.
205 * dispextern.h (scroll_cost): Remove decl.
206
de68a1fc
PE
207 * region-cache.h (pp_cache): Mark as externally visible.
208
40ccffa6
PE
209 * process.c: Make symbols static if they're not exported.
210 (process_tick, update_tick, create_process, chan_process):
211 (Vprocess_alist, proc_buffered_char, datagram_access):
212 (fd_callback_data, send_process_frame, process_sent_to): Now static.
213 (deactivate_process): Mark defn as static, as well as decl.
214 * lisp.h (create_process): Remove decl.
215 * process.h (chan_process, Vprocess_alist): Remove decls.
216
ad64fc97
PE
217 * print.c: Make symbols static if they're not exported.
218 (print_depth, new_backquote_output, being_printed, print_buffer):
219 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
220 (print_interval, print_number_index, initial_stderr_stream):
221 Now static.
222 * lisp.h (Fprinc): Remove decl.
223 (debug_output_compilation_hack): Mark as externally visible.
224
adddb265
PE
225 * sysdep.c (croak): Move decl from here to syssignal.h.
226 * syssignal.h (croak): Put it here, so the API can be checked when
227 'croak' is called from dissociate_if_controlling_tty.
228
1717ede2
PE
229 * minibuf.c: Make symbols static if they're not exported.
230 (minibuf_save_list, choose_minibuf_frame): Now static.
231 * lisp.h (choose_minibuf_frame): Remove decl.
232
fa5fb2bc
PE
233 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
234
1e3890d1
PE
235 * lread.c: Make symbols static if they're not exported.
236 (read_objects, initial_obarray, oblookup_last_bucket_number):
237 Now static.
238 (make_symbol): Remove; unused.
239 * lisp.h (initial_obarray, make_symbol): Remove decls.
240
8a1414fa
PE
241 * keyboard.c: Make symbols static if they're not exported.
242 (single_kboard, recent_keys_index, total_keys, recent_keys):
243 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
244 (this_single_command_key_start, echoing, last_auto_save):
245 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
246 (command_loop, echo_now, keyboard_init_hook, help_char_p):
247 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
248 (Vlispy_mouse_stem, double_click_count):
249 Now static.
250 (force_auto_save_soon): Define only if SIGDANGER.
251 (ignore_mouse_drag_p): Now static if
252 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
253 (print_help): Remove; unused.
254 (stop_character, last_timer_event): Mark as externally visible.
255 * keyboard.h (ignore_mouse_drag_p): Declare only if
256 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
257 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
258 * lisp.h (echoing): Remove decl.
259 (force_auto_save_soon): Declare only if SIGDANGER.
260 * xdisp.c (redisplay_window): Simplify code, to make it more
261 obvious that ignore_mouse_drag_p is not accessed if !defined
262 USE_GTK && !defined HAVE_NS.
263
93ea6e8f
PE
264 * intervals.c: Make symbols static if they're not exported.
265 (merge_properties_sticky, merge_interval_right, delete_interval):
266 Now static.
267 * intervals.h (merge_interval_right, delete_interval): Remove decls.
268
77382fcc
PE
269 * insdel.c: Make symbols static if they're not exported.
270 However, leave prepare_to_modify_buffer alone. It's never
271 called from outside this function, but that appears to be a bug.
272 (combine_after_change_list, combine_after_change_buffer):
4889fc82 273 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
274 (adjust_after_replace_noundo): Remove; unused.
275 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 276 (signal_before_change): Remove decls.
77382fcc 277
9306c32e
PE
278 * indent.c (val_compute_motion, val_vmotion): Now static.
279
cd44d2eb
PE
280 * image.c: Make symbols static if they're not exported.
281 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
282 if USE_GTK.
283 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
284 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
285
ad9a7a06
PE
286 * fringe.c (standard_bitmaps): Now static.
287 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
288
81626931
PE
289 * frame.c: Make symbols static if they're not exported.
290 (x_report_frame_params, make_terminal_frame): Now static.
291 (get_frame_param): Now static, unless HAVE_NS.
292 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
293 (x_get_resource_string): Remove; not used.
294 * frame.h (make_terminal_frame, x_report_frame_params):
295 (x_get_resource_string); Remove decls.
296 (x_fullscreen_adjust): Declare only if WINDOWSNT.
297 * lisp.h (get_frame_param): Declare only if HAVE_NS.
298
239f9db9
PE
299 * font.c, fontset.c: Make symbols static if they're not exported.
300 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
301 (FACE_SUITABLE_FOR_CHAR_P): Use it.
302 * font.c (font_close_object): Now static.
303 * font.h (font_close_object): Remove.
304 * fontset.c (FONTSET_OBJLIST): Remove.
305 (free_realized_fontset) #if-0 the body, which does nothing.
306 (face_suitable_for_char_p): #if-0, as it's never called.
307 * fontset.h (face_suitable_for_char_p): Remove decl.
308 * xfaces.c (face_at_string_position): Use
309 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
310 since 0 is always ASCII.
311
dfcf3579
PE
312 * fns.c (weak_hash_tables): Now static.
313
5045092b
PE
314 * fileio.c: Make symbols static if they're not exported.
315 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
316 (Vwrite_region_annotation_buffers): Now static.
317
57a96f5c
PE
318 * eval.c: Make symbols static if they're not exported.
319 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
320 * lisp.h (backtrace_list): Remove decl.
321
35f08c38
PE
322 * emacs.c: Make symbols static if they're not exported.
323 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
324 (fatal_error_code, fatal_error_signal_hook, standard_args):
325 Now static.
326 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
327 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
328 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
329 * lisp.h (fatal_error_signal_hook): Remove decl.
330 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
331
f44bd759
PE
332 * editfns.c: Move a (normally-unused) function to its only use.
333 * editfns.c, lisp.h (get_operating_system_release): Remove.
334 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
335 worth the hassle of breaking this out.
336
b532497d
PE
337 * xterm.c: Make symbols static if they're not exported.
338 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
339 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
340 (x_destroy_window, x_delete_display):
341 Now static.
342 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
343 (x_mouse_leave): Remove; unused.
344 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
345 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
346 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
347 Remove decls.
348 (x_mouse_leave): Declare only if WINDOWSNT.
349 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
350 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
351 USE_X_TOOLKIT.
352
1675728f
PE
353 * ftxfont.c: Make symbols static if they're not exported.
354 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
355 HAVE_FREETYPE.
356 * font.h (ftxfont_driver): Likewise.
357
e4cebfca
PE
358 * xfns.c: Make symbols static if they're not exported.
359 (x_last_font_name, x_display_info_for_name):
360 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
361 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
362 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
363 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
364 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
365 (last_show_tip_args): Now static.
366 (xic_defaut_fontset, xic_create_fontsetname): Define only if
367 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
368 (x_screen_planes): Remove; unused.
369 * dispextern.h (x_screen_planes): Remove decl.
370
5bf46f05
PE
371 * dispnew.c: Make symbols static if they're not exported.
372 * dispextern.h (redraw_garbaged_frames, scrolling):
373 (increment_row_positions): Remove.
374 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
375 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
376 Now static.
377 (redraw_garbaged_frames): Remove; unused.
378
435f4c28
PE
379 * xfaces.c: Make symbols static if they're not exported.
380 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
381 Remove decls.
382 * xterm.h (defined_color): Remove decls.
383 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
384 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
385 (menu_face_changed_default, defined_color, free_realized_face):
386 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
387 (ascii_face_of_lisp_face): Remove; unused.
388
8524aef3
PE
389 * xdisp.c: Make symbols static if they're not exported.
390 * dispextern.h (scratch_glyph_row, window_box_edges):
391 (glyph_to_pixel_coords, set_cursor_from_row):
392 (get_next_display_element, set_iterator_to_next):
393 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
394 (show_mouse_face): Remove decls
395 * frame.h (message_buf_print): Likewise.
396 * lisp.h (pop_message, set_message, check_point_in_composition):
397 Likewise.
398 * xterm.h (set_vertical_scroll_bar): Likewise.
399 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
400 (message_buf_print, scratch_glyph_row, displayed_buffer):
401 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
402 (get_next_display_element, show_mouse_face, window_box_edges):
403 (frame_to_window_pixel_xy, check_point_in_composition):
404 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
405 (glyph_to_pixel_coords): Remove; unused.
406
16390cd2
PE
407 * dired.c (file_name_completion): Now static.
408
409 * dbusbind.c (xd_in_read_queued_messages): Now static.
410
a25f4dfa
PE
411 * lisp.h (circular_list_error, FOREACH): Remove; unused.
412 * data.c (circular_list_error): Remove.
413
14a9c8df
PE
414 * commands.h (last_point_position, last_point_position_buffer):
415 (last_point_position_window): Remove decls.
416 * keyboard.c: Make these variables static.
417
74ab6df5
PE
418 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
419 decls.
420 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
421 (iso_code_class, detect_coding, code_convert_region): Now static.
422 (encode_coding_gap): Remove; unused.
423
38dfbee1
PE
424 * chartab.c (chartab_chars, chartab_bits): Now static.
425
a2cb4e63
PE
426 * charset.h (charset_iso_8859_1): Remove decl.
427 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
428 Now static.
429
127198fd
PE
430 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
431 * ccl.c (Vccl_program_table): Now static.
432 (check_ccl_update): Remove; unused.
433
d85b608f
PE
434 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
435 * category.h: ... from here.
436 * category.c (check_category_table, set_category_set): Now static.
437
31cd66f3
PE
438 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
439 * lisp.h: Remove these decls.
440
c358e587
PE
441 * buffer.c (buffer_count): Remove unused var.
442
e78aecca
PE
443 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
444 so that it's not optimized away.
445 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
446 * dispextern.h (bidi_dump_cached_states): Remove, since it's
447 exported only to the debugger.
448
e192d7d3
PE
449 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
450 * atimer.h (run_all_atimers): Removed; not exported.
451
92470028
PE
452 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
453 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
454 was inaccessible from Lisp.
455 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
456 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
457
244ed907
PE
458 alloc.c: Import and export fewer symbols, and remove unused items.
459 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
460 is defined.
461 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
462 it's not optimized away by whole-program optimization.
463 (message_enable_multibyte, free_misc): Remove.
464 (catchlist, handlerlist, mark_backtrace):
465 Declare only if BYTE_MARK_STACK.
466 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
467 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
468 (message_enable_multibyte): Remove decl.
469 (free_misc, interval_free_list, float_block, float_block_index):
470 (n_float_blocks, float_free_list, cons_block, cons_block_index):
471 (cons_free_list, last_marked_index):
472 Now static.
473 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
474 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
475 (mark_backtrace): Define only if BYTE_MARK_STACK.
476 * xdisp.c (message_enable_multibyte): Now static.
477
955cbe7b
PE
478 Declare Lisp_Object Q* variables to be 'static' if not exproted.
479 This makes it easier for human readers (and static analyzers)
480 to see whether these variables are used from other modules.
481 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
482 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
483 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
484 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
485 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
486 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
487 * xmenu.c, xselect.c:
488 Declare Q* vars static if they are not used in other modules.
489 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
490 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
491 Remove decls of unexported vars.
492 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
493
95c82688
PE
494 * lisp.h (DEFINE_FUNC): Make sname 'static'.
495
16a97296
PE
496 Make Emacs functions such as Fatom 'static' by default.
497 This makes it easier for human readers (and static analyzers)
498 to see whether these functions can be called from other modules.
499 DEFUN now defines a static function. To make the function external
500 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
501 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
502 (Finit_image_library):
16a97296
PE
503 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
504 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
505 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
506 Remove decls, since these functions are now static.
507 (Funintern, Fget_internal_run_time): New decls, since these functions
508 were already external.
95c82688 509
16a97296
PE
510 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
511 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
512 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
513 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
514 * keyboard.c, keymap.c, lread.c:
515 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
516 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
517 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
518 Mark functions with DEFUE instead of DEFUN,
519 if they are used in other modules.
520 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
521 decls for now-static functions.
522 * buffer.h (Fdelete_overlay): Remove decl.
523 * callproc.c (Fgetenv_internal): Mark as internal.
524 * composite.c (Fremove_list_of_text_properties): Remove decl.
525 (Fcomposition_get_gstring): New forward static decl.
526 * composite.h (Fcomposite_get_gstring): Remove decl.
527 * dired.c (Ffile_attributes): New forward static decl.
528 * doc.c (Fdocumntation_property): New forward static decl.
529 * eval.c (Ffetch_bytecode): New forward static decl.
530 (Funintern): Remove extern decl; now in .h file where it belongs.
531 * fileio.c (Fmake_symbolic_link): New forward static decl.
532 * image.c (Finit_image_library): New forward static decl.
533 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
534 * intervals.h (Fprevious_property_change):
535 (Fremove_list_of_text_properties): Remove decls.
536 * keyboard.c (Fthis_command_keys): Remove decl.
537 (Fcommand_execute): New forward static decl.
538 * keymap.c (Flookup_key): New forward static decl.
539 (Fcopy_keymap): Now static.
540 * keymap.h (Flookup_key): Remove decl.
541 * process.c (Fget_process): New forward static decl.
542 (Fprocess_datagram_address): Mark as internal.
543 * syntax.c (Fsyntax_table_p): New forward static decl.
544 (skip_chars): Remove duplicate decl.
545 * textprop.c (Fprevious_property_change): New forward static decl.
546 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
547 Now internal.
548 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
549 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
550
785bbd42
PE
551 * editfns.c (Fformat): Remove unreachable code.
552
8b913b57
AS
5532011-04-14 Andreas Schwab <schwab@linux-m68k.org>
554
555 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
556 change. (Bug#8496)
557
a6744a35
EZ
5582011-04-13 Eli Zaretskii <eliz@gnu.org>
559
560 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
561 when at ZV. (Bug#8487)
562
e7974947
AS
5632011-04-12 Andreas Schwab <schwab@linux-m68k.org>
564
baad03f0
AS
565 * charset.c (Fclear_charset_maps): Use xfree instead of free.
566 (Bug#8437)
567 * keyboard.c (parse_tool_bar_item): Likewise.
568 * sound.c (sound_cleanup, alsa_close): Likewise.
569 * termcap.c (tgetent): Likewise.
570 * xfns.c (x_default_font_parameter): Likewise.
571 * xsettings.c (read_and_apply_settings): Likewise.
572
e7974947
AS
573 * alloc.c (overrun_check_malloc, overrun_check_realloc)
574 (overrun_check_free): Protoize.
575
28272684
PE
5762011-04-12 Paul Eggert <eggert@cs.ucla.edu>
577
578 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
579 since callers should never pass a negative size.
580 Change the signature to match that of plain 'read' and 'write'; see
581 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
582 * lisp.h: Update prototypes of emacs_write and emacs_read.
583
11997c76
EZ
5842011-04-11 Eli Zaretskii <eliz@gnu.org>
585
586 * xdisp.c (redisplay_window): Don't try to determine the character
587 position of the scroll margin if the window start point w->startp
e896f03c 588 is outside the buffer's accessible region. (Bug#8468)
11997c76 589
8a2cbd72
EZ
5902011-04-10 Eli Zaretskii <eliz@gnu.org>
591
592 Fix write-region and its subroutines for buffers > 2GB.
593 * fileio.c (a_write, e_write): Modify declaration of arguments and
594 local variables to support buffers larger than 2GB.
595 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
596
597 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
598 argument, local variables, and return value.
599
600 * lisp.h: Update prototypes of emacs_write and emacs_read.
601
602 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
603
4073e537 6042011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 605
1ebfdcb6
PE
606 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
607
b2ded58d
PE
608 Fix more problems found by GCC 4.6.0's static checks.
609
7d66342c
PE
610 * xdisp.c (vmessage): Use a better test for character truncation.
611
bbf47d44
PE
612 * charset.c (load_charset_map): <, not <=, for optimization,
613 and to avoid potential problems with integer overflow.
9248994d 614 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 615 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 616 * editfns.c (Fformat): Likewise.
1e69125e 617 * syntax.c (skip_chars): Likewise.
3befa583 618
e3019616
PE
619 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
620 This also lets GCC 4.6.0 generate slightly better loop code.
621
becfa255
PE
622 * callint.c (Fcall_interactively): <, not <=, for optimization.
623 (Fcall_interactively): Count the number of arguments produced,
624 not the number of arguments given. This is simpler and lets GCC
625 4.6.0 generate slightly better code.
626
dae0cd48
PE
627 * ftfont.c: Distingish more carefully between FcChar8 and char.
628 The previous code passed unsigned char * to a functions like
629 strlen and xstrcasecmp that expect char *, which does not
630 conform to the C standard.
631 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
632 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
633 char * when the C standard requires it.
634
76032d70
PE
635 * keyboard.c (read_char): Remove unused var.
636
eb3f1cc8
PE
637 * eval.c: Port to Windows vsnprintf (Bug#8435).
638 Include <limits.h>.
639 (SIZE_MAX): Define if the headers do not.
640 (verror): Do not give up if vsnprintf returns a negative count.
641 Instead, grow the buffer. This ports to Windows vsnprintf, which
642 does not conform to C99. Problem reported by Eli Zaretskii.
643 Also, simplify the allocation scheme, by avoiding the need for
644 calling realloc, and removing the ALLOCATED variable.
645
70476b54
PE
646 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
647
12020a9e
PE
648 Remove invocations of doprnt, as Emacs now uses vsnprintf.
649 But keep the doprint source code for now, as we might revamp it
650 and use it again (Bug#8435).
ea6c7ae6
PE
651 * lisp.h (doprnt): Remove.
652 * Makefile.in (base_obj): Remove doprnt.o.
653 * deps.mk (doprnt.o): Remove.
654
5fdb398c
PE
655 error: Print 32- and 64-bit integers portably (Bug#8435).
656 Without this change, on typical 64-bit hosts error ("...%d...", N)
657 was used to print both 32- and 64-bit integers N, which relied on
658 undefined behavior.
659 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
660 New macro.
661 * lisp.h (error, verror): Mark as printf-like functions.
662 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
663 Report overflow in size calculations when allocating printf buffer.
664 Do not truncate output string at its first null byte.
665 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
666 Truncate the output at a character boundary, since vsnprintf does not
667 do that.
668 * charset.c (check_iso_charset_parameter): Convert internal
669 character to string before calling 'error', since %c now has the
670 printf meaning.
671 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
672 overflow when computing char to be passed to 'error'. Do not
673 pass Lisp_Object to 'error'; pass the integer instead.
674 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
675 formatted with plain %d.
676
b189fa66
PE
677 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
678
bff87ef0
PE
679 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
680
7e2cac20
PE
681 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
682
ce4d90b5
PE
683 * xterm.c (x_catch_errors): Remove duplicate declaration.
684
266c9547
PE
685 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
686
79c49ad2
PE
687 * xdisp.c, lisp.h (message_nolog): Remove; unused.
688
368f4090
JM
6892011-04-10 Jim Meyering <meyering@redhat.com>
690
691 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
692 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
693 return ssize_t not "int", and use size_t as the buffer length.
694 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
695 * gnutls.h: Update declarations.
696 * process.c (read_process_output): Use ssize_t, to match.
697 (send_process): Likewise.
698
a32d4040
CY
6992011-04-09 Chong Yidong <cyd@stupidchicken.com>
700
701 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
702
8546720e 7032011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 704
8546720e
GM
705 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
706 unsigned char, to match FcChar8 type definition.
aac0c6e3 707
8546720e
GM
708 * xterm.c (handle_one_xevent):
709 * xmenu.c (create_and_show_popup_menu):
710 * xselect.c (x_decline_selection_request)
711 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 712
0a2f5c1a 7132011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
714
715 Fix some uses of `int' instead of EMACS_INT.
716 * search.c (string_match_1, fast_string_match)
717 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
718 (scan_buffer, find_next_newline_no_quit)
719 (find_before_next_newline, search_command, Freplace_match)
720 (Fmatch_data): Make some `int' variables be EMACS_INT.
721
722 * xdisp.c (display_count_lines): 3rd argument and return value now
723 EMACS_INT. All callers changed.
724 (pint2hrstr): Last argument is now EMACS_INT.
725
726 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
727 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
728 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
729 (decode_coding_utf_16, decode_coding_emacs_mule)
730 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
731 (decode_coding_ccl, decode_coding_charset)
732 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
733 (decode_coding_iso_2022, decode_coding_emacs_mule)
734 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
735 <char_offset, last_offset>: Declare EMACS_INT.
736 (encode_coding_utf_8, encode_coding_utf_16)
737 (encode_coding_emacs_mule, encode_invocation_designation)
738 (encode_designation_at_bol, encode_coding_iso_2022)
739 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
740 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
741 Declare EMACS_INT.
742 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
743 (encode_invocation_designation): Last argument P_NCHARS is now
744 EMACS_INT.
745 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
746 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
747
748 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
749 All users changed.
750
751 * ccl.c (Fccl_execute_on_string): Declare some variables
752 EMACS_INT.
753
8546720e 7542011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
755
756 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
757
4e19a977
CS
7582011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
759
760 * process.c (Fformat_network_address): Doc fix.
761
87302331
R
7622011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
763
764 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
765
cbb59342
CY
7662011-04-08 Chong Yidong <cyd@stupidchicken.com>
767
768 * keyboard.c (read_char): Call Lisp function help-form-show,
769 instead of using internal_with_output_to_temp_buffer.
770 (Qhelp_form_show): New var.
e0d38eeb 771 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
772
773 * print.c (internal_with_output_to_temp_buffer): Function deleted.
774
775 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
776
e67a13ab
CY
7772011-04-06 Chong Yidong <cyd@stupidchicken.com>
778
779 * process.c (Flist_processes): Removed to Lisp.
780 (list_processes_1): Deleted.
781
973f782d
EZ
7822011-04-06 Eli Zaretskii <eliz@gnu.org>
783
7c106b1e
EZ
784 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
785
973f782d
EZ
786 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
787
41cf7d1a 7882011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 789
ca23cc88
PE
790 Fix more problems found by GCC 4.6.0's static checks.
791
f390e2d5
PE
792 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
793
42eea0d0
PE
794 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
795
b69769da 796 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 797
f9541e84
PE
798 * xdisp.c (vmessage): Mark as a printf-like function.
799
13841b55
PE
800 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
801
c136c10f
PE
802 * sound.c (sound_warning): Don't crash if arg contains a printf format.
803
5e2d4a30
PE
804 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
805 printf-like functions.
806 (tiff_load): Add casts to remove these marks before passing them
807 to system-supplied API.
808
583f48b9
PE
809 * eval.c (Fsignal): Remove excess argument to 'fatal'.
810
b25d760e
PE
811 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
812 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
813 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
814 directly, rather than having caller test rule sign. This avoids
815 some unnecessary tests.
816 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
817 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
818 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 819
bc7b6697 820 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 821 (xfont_open): Avoid unnecessary tests.
bc7b6697 822
27ccc379
PE
823 * composite.c (composition_gstring_put_cache): Use unsigned integer.
824
dcd5c89a
PE
825 * composite.h, composite.c (composition_gstring_put_cache):
826 Use EMACS_INT, not int, for length.
827
b13a45c6
PE
828 * composite.h (COMPOSITION_DECODE_REFS): New macro,
829 breaking out part of COMPOSITION_DECODE_RULE.
830 (COMPOSITION_DECODE_RULE): Use it.
831 * composite.c (get_composition_id): Remove unused local vars,
832 by using the new macro.
833
1e792e4d
PE
834 * textprop.c (set_text_properties_1): Change while to do-while,
835 since the condition is always true at first.
836
dc6c6455 837 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
838 (interval_deletion_adjustment): Return unsigned value.
839 All uses changed.
dc6c6455 840
aba7731a
PE
841 * process.c (list_processes_1, create_pty, read_process_output):
842 (exec_sentinel): Remove vars that were set but not used.
afd4052b 843 (create_pty): Remove unnecessary "volatile"s.
bc57d757 844 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 845 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 846 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 847
fdfc4bf3
PE
848 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
849
fca8fe46 850 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 851 (update_syntax_table): Use unsigned instead of int.
fca8fe46 852
06a0259a 853 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 854 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 855 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 856
e7b9e80f
PE
857 * print.c (print_error_message): Avoid int overflow.
858
56201685
PE
859 * font.c (font_list_entities): Redo for clarity,
860 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
861
78834453 862 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 863 (font_score): Avoid potential overflow in diff calculation.
78834453 864
0bc0b309 865 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 866 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 867
e610eaca
PE
868 * eval.c (funcall_lambda): Rename local to avoid shadowing.
869
b895abce
PE
870 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
871 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
872 can always succeed if overflow has undefined behavior.
873
1f1d9321 874 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 875 (wordify): Omit three unnecessary tests.
1f1d9321 876
c59478bc
PE
877 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
878 All callers changed. This avoids the need for an unused var.
879
79b73827
PE
880 * casefiddle.c (casify_region): Remove var that is set but not used.
881
a4db5dfe
PE
882 * dired.c (file_name_completion): Remove var that is set but not used.
883
43aae36e
PE
884 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
885
2a47c44d 886 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 887 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 888
a37c69bf
PE
889 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
890 Check for integer overflow on size calculations.
891
328ab8e7
PE
892 * buffer.c (Fprevious_overlay_change): Remove var that is set
893 but not used.
894
e5a2a5cb
PE
895 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
896 Remove vars that are set but not used.
8d84a6eb 897 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 898 (timer_check_2): Mark vars as initialized.
e5a2a5cb 899
a60e5f68
PE
900 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
901
f661cb61 902 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 903 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 904
f0397f5a
PE
905 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
906 that are set but not used.
907
8664db06 908 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 909 if XCreateBitmapFromData fails (Bug#8410).
8664db06 910
6abdaa4a
PE
911 * xselect.c (x_get_local_selection, x_handle_property_notify):
912 Remove vars that are set but not used.
913
0ce7538d 914 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 915 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 916
9ae848fc
PE
917 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
918 Remove var that is set but not used.
0b918413
PE
919 (scroll_bar_windows_size): Now size_t, not int.
920 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
921 Check for overflow.
9ae848fc 922
a5a62657
PE
923 * xfaces.c (realize_named_face): Remove vars that are set but not used.
924 (map_tty_color) [!defined MSDOS]: Likewise.
925
5c5cdd39
PE
926 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
927
66ebf983
PE
928 * coding.c: Remove vars that are set but not used.
929 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
930 All callers changed.
931 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
932 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
933 (decode_coding_charset): Remove vars that are set but not used.
934
1be4d761
PE
935 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
936 that is set but not used.
937
47553fa8
PE
938 * print.c (print_object): Remove var that is set but not used.
939
1f7196bf 940 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
941 The gnulib version avoids calling malloc in the usual case,
942 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
943 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
944 * filelock.c (current_lock_owner): Likewise.
945 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
946 * sysdep.c: Include allocator.h, careadlinkat.h.
947 (emacs_no_realloc_allocator): New static constant.
948 (emacs_readlink): New function.
fdb61804
PE
949 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
950 ../lib/careadlinkat.h.
d1fdcab7 951
f84c17c7
SM
9522011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
953
954 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
955 first non-nil return value).
956
ef3862ad
JD
9572011-04-03 Jan Djärv <jan.h.d@swipnet.se>
958
959 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
960 if not defined (Bug#8403).
961
376a7006
JB
9622011-04-02 Juanma Barranquero <lekktu@gmail.com>
963
964 * xdisp.c (display_count_lines): Remove parameter `start',
965 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
966 (get_char_face_and_encoding): Remove parameter `multibyte_p',
967 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
968 (fill_stretch_glyph_string): Remove parameters `row' and `area',
969 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
970 and thereabouts. All callers changed.
971 (get_per_char_metric): Remove parameter `f', unused since
972 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
973
6ca3801d
JM
9742011-04-02 Jim Meyering <meyering@redhat.com>
975
976 do not dereference NULL upon failed strdup
977 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
978 (ns_get_family): Likewise.
979
d8e2b5ba
JB
9802011-04-02 Juanma Barranquero <lekktu@gmail.com>
981
982 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
983
8c74fcbd
JD
9842011-04-02 Jan Djärv <jan.h.d@swipnet.se>
985
986 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
987 later (Bug#8403).
988
7200d79c
SM
9892011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
990
03408648 991 Add lexical binding.
7200d79c 992
03408648
SM
993 * window.c (Ftemp_output_buffer_show): New fun.
994 (Fsave_window_excursion):
995 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
996
997 * lread.c (lisp_file_lexically_bound_p): New function.
998 (Fload): Bind Qlexical_binding.
999 (readevalloop): Remove `evalfun' arg.
1000 Bind Qinternal_interpreter_environment.
1001 (Feval_buffer): Bind Qlexical_binding.
1002 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
1003 Mark as dynamic.
1004 (syms_of_lread): Declare `lexical-binding'.
1005
1006 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
1007
1008 * keyboard.c (eval_dyn): New fun.
1009 (menu_item_eval_property): Use it.
ca105506
SM
1010
1011 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 1012
03408648
SM
1013 * fns.c (concat, mapcar1): Accept byte-code-functions.
1014
1015 * eval.c (Fsetq): Handle lexical vars.
1016 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
1017 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
1018 (FletX, Flet): Obey lexical binding.
1019 (Fcommandp): Handle closures.
1020 (Feval): New `lexical' arg.
1021 (eval_sub): New function extracted from Feval. Use it almost
1022 everywhere where Feval was used. Look up vars in lexical env.
1023 Handle closures.
1024 (Ffunctionp): Move from subr.el.
1025 (Ffuncall): Handle closures.
1026 (apply_lambda): Remove `eval_flags'.
1027 (funcall_lambda): Handle closures and new byte-code-functions.
1028 (Fspecial_variable_p): New function.
1029 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
1030 but without exporting it to Lisp.
23aba0ea 1031
23aba0ea 1032 * doc.c (Fdocumentation, store_function_docstring):
03408648 1033 * data.c (Finteractive_form): Handle closures.
23aba0ea 1034
03408648
SM
1035 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
1036 interactive spec.
ba83908c 1037
03408648
SM
1038 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
1039 byte-codes.
1040 (exec_byte_code): New function extracted from Fbyte_code to handle new
1041 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 1042
03408648 1043 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 1044
03408648 1045 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 1046
e2abce01
JB
10472011-03-31 Juanma Barranquero <lekktu@gmail.com>
1048
1049 * xdisp.c (redisplay_internal): Fix prototype.
1050
63696a73 10512011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 1052
63696a73
EZ
1053 * xdisp.c (SCROLL_LIMIT): New macro.
1054 (try_scrolling): Use it when setting scroll_limit. Limit
1055 scrolling to 100 screen lines.
1056 (redisplay_window): Even when falling back on "recentering",
1057 position point in the window according to scroll-conservatively,
1058 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
1059
1060 (try_scrolling): When point is above the window, allow searching
1061 as far as scroll_max, or one screenful, to compute vertical
1062 distance from PT to the scroll margin position. This prevents
1063 try_scrolling from unnecessarily failing when
1064 scroll-conservatively is set to a value slightly larger than the
1065 window height. Clean up the case of PT below the margin at bottom
1066 of window: scroll_max can no longer be INT_MAX. When aggressive
1067 scrolling is in use, don't let point enter the opposite scroll
1068 margin as result of the scroll.
1069 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
1070 threshold of 100 lines for never-recentering scrolling.
1071
e4cc2dfc
JB
10722011-03-31 Juanma Barranquero <lekktu@gmail.com>
1073
1074 * dispextern.h (move_it_by_lines):
1075 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
1076 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
1077 (message_log_check_duplicate): Remove parameters `prev_bol' and
1078 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1079 (redisplay_internal): Remove parameter `preserve_echo_area',
1080 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
1081
1082 * indent.c (Fvertical_motion):
1083 * window.c (window_scroll_pixel_based, Frecenter):
1084 Don't pass `need_y_p' to `move_it_by_lines'.
1085
1c470562
SM
10862011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
1087
44f230aa
SM
1088 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
1089 steal a few bits to be more compact.
1090 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
1091 Remove unneeded casts.
1092
1c470562
SM
1093 * bytecode.c (Fbyte_code): CAR and CDR can GC.
1094
888adce9
ZK
10952011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
1096
1097 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
1098 binding" message (bug#7967).
1099
f838ed7b
PE
11002011-03-30 Paul Eggert <eggert@cs.ucla.edu>
1101
77861b95
PE
1102 Fix more problems found by GCC 4.6.0's static checks.
1103
de6dbc14
PE
1104 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
1105 Remove unused local var.
1106
f838ed7b
PE
1107 * editfns.c (Fmessage_box): Remove unused local var.
1108
792c7b2b
PE
1109 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
1110 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1111 Omit unused local vars.
c499e557 1112 * window.c (shrink_windows): Omit unused local var.
b01a1c29 1113 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
1114 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
1115 Omit unused local var.
1116
ba0165e1
PE
1117 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
1118 Don't assume string length fits in int.
32ad8845 1119 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 1120 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 1121
3c59b4c9
PE
1122 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
1123 instead of alloca (Bug#8344).
1124
a3eed478 1125 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 1126 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 1127
eb4d412d
PE
1128 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
1129
1658b401
PE
1130 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
1131 concerns.
1132
1133 * term.c (produce_glyphless_glyph): Remove unnecessary test.
1134
1135 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 1136
9a2c6e05
PE
1137 * keyboard.c (syms_of_keyboard): Use the same style as later
1138 in this function when indexing through an array. This also
1139 works around GCC bug 48267.
1140
03d0a109
PE
1141 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
1142
44f730c8
PE
1143 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
1144
fe75f926
PE
1145 * chartab.c (sub_char_table_ref_and_range): Redo for slight
1146 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
1147
ffa8c828
PE
1148 * keyboard.c, keyboard.h (num_input_events): Now size_t.
1149 This avoids undefined behavior on integer overflow, and is a bit
1150 more convenient anyway since it is compared to a size_t variable.
1151
c5101a77
PE
1152 Variadic C functions now count arguments with size_t, not int.
1153 This avoids an unnecessary limitation on 64-bit machines, which
1154 caused (substring ...) to crash on large vectors (Bug#8344).
1155 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
1156 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 1157 All variadic functions and their callers changed accordingly.
c5101a77
PE
1158 (struct gcpro.nvars): Now size_t, not int. All uses changed.
1159 * data.c (arith_driver, float_arith_driver): Likewise.
1160 * editfns.c (general_insert_function): Likewise.
1161 * eval.c (struct backtrace.nargs, interactive_p)
1162 (internal_condition_case_n, run_hook_with_args, apply_lambda)
1163 (funcall_lambda, mark_backtrace): Likewise.
1164 * fns.c (concat): Likewise.
1165 * frame.c (x_set_frame_parameters): Likewise.
1166 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
1167 0 if not found, not -1. All callers changed.
1168
dd3f25f7
PE
1169 * alloc.c (garbage_collect): Don't assume stack size fits in int.
1170 (stack_copy_size): Now size_t, not int.
1171 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
1172
461c2ab9
JB
11732011-03-28 Juanma Barranquero <lekktu@gmail.com>
1174
1175 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
1176 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1177 All callers changed.
1178
1179 * lisp.h (multibyte_char_to_unibyte):
1180 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
1181 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1182 * character.h (CHAR_TO_BYTE8):
1183 * cmds.c (internal_self_insert):
1184 * editfns.c (general_insert_function):
1185 * keymap.c (push_key_description):
1186 * search.c (Freplace_match):
1187 * xdisp.c (message_dolog, set_message_1): All callers changed.
1188
f6d62986
SM
11892011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1190
1191 * keyboard.c (safe_run_hook_funcall): New function.
1192 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
1193 don't set the hook to nil, but remove the offending function instead.
1194 (Qcommand_hook_internal): Remove, unused.
1195 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
1196 Vcommand_hook_internal.
1197
1198 * eval.c (enum run_hooks_condition): Remove.
1199 (funcall_nil, funcall_not): New functions.
1200 (run_hook_with_args): Call each function through a `funcall' argument.
1201 Remove `cond' argument, now redundant.
1202 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
1203 (Frun_hook_with_args_until_failure): Adjust accordingly.
1204 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
1205
1db5b1ad
JB
12062011-03-28 Juanma Barranquero <lekktu@gmail.com>
1207
1208 * dispextern.h (string_buffer_position): Remove declaration.
1209
1210 * print.c (strout): Remove parameter `multibyte', unused since
1211 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
1212
1213 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
1214 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
1215 All callers changed.
1216
1217 * w32.c (_wsa_errlist): Use braces for struct initializers.
1218
1219 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
1220 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
1221 All callers changed.
1222 (string_buffer_position): Likewise. Also, make static (it's never
1223 used outside xdisp.c).
1224 (cursor_row_p): Remove parameter `w', unused since
1225 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
1226 (decode_mode_spec): Remove parameter `precision', introduced during
1227 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
1228 All callers changed.
1229
5ffb62aa
JD
12302011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1231
1232 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
1233
461c2ab9 12342011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
1235
1236 * nsterm.m (ns_menu_bar_is_hidden): New variable.
1237 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
1238 (ns_update_auto_hide_menu_bar): New functions.
1239 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
1240 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
1241 ns_constrain_all_frames.
1242 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
1243 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
1244
5c380ffb
JD
12452011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1246
1247 * nsmenu.m (runDialogAt): Remove argument to timer_check.
1248
9af30bdf
GM
12492011-03-27 Glenn Morris <rgm@gnu.org>
1250
1251 * syssignal.h: Replace RETSIGTYPE with void.
1252 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
1253 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
1254 Replace SIGTYPE with void everywhere.
1255 * s/usg5-4-common.h (SIGTYPE): Remove definition.
1256 * s/template.h (SIGTYPE): Remove commented out definition.
1257
e2abce01
JB
12582011-03-26 Eli Zaretskii <eliz@gnu.org>
1259
1260 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
1261 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
1262
f868cd8a
JB
12632011-03-26 Juanma Barranquero <lekktu@gmail.com>
1264
59eb0929
JB
1265 * w32.c (read_unc_volume): Use parameter `henum', instead of
1266 global variable `wget_enum_handle'.
1267
1268 * keymap.c (describe_vector): Remove parameters `indices' and
1269 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
1270 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
1271
f868cd8a
JB
1272 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
1273
1274 * keyboard.c (timer_check): Remove parameter `do_it_now',
1275 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
1276 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
1277 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
1278
1279 * keyboard.c (read_char):
1280 * w32menu.c (w32_menu_display_help):
1281 * xmenu.c (show_help_event, menu_help_callback):
1282 Adjust calls to `show_help_echo'.
1283
1284 * gtkutil.c (xg_maybe_add_timer):
1285 * keyboard.c (readable_events):
1286 * process.c (wait_reading_process_output):
1287 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
1288
1289 * insdel.c (adjust_markers_gap_motion):
1290 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
1291 (gap_left, gap_right): Don't call it.
1292
2ecf6fdb
CY
12932011-03-25 Chong Yidong <cyd@stupidchicken.com>
1294
1295 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
1296 incurred during fontification.
1297
6b1f9ba4
JB
12982011-03-25 Juanma Barranquero <lekktu@gmail.com>
1299
1300 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
1301 (DEFVAR_PER_BUFFER): Don't pass it.
1302
1303 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
1304 (scrolling_window): Don't pass it.
1305
0f4a96b5
JB
13062011-03-25 Juanma Barranquero <lekktu@gmail.com>
1307
1308 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
1309
1310 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
1311 and `suffix'.
1312 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
1313 of variables specific to SELinux and computation of `encoded_absname'.
1314
1315 * image.c (XPutPixel): Remove unused variable `height'.
1316
1317 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
1318
1319 * unexw32.c (get_section_info): Remove unused variable `section'.
1320
1321 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
1322 (system_process_attributes): Remove unused variable `sess'.
1323 (sys_read): Remove unused variable `err'.
1324
1325 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
1326 (w32_wnd_proc): Remove unused variable `isdead'.
1327 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
1328 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
1329 (x_create_tip_frame): Remove unused variable `tem'.
1330
1331 * w32inevt.c (w32_console_read_socket):
1332 Remove unused variable `no_events'.
1333
1334 * w32term.c (x_draw_composite_glyph_string_foreground):
1335 Remove unused variable `width'.
1336
1149507c
JB
13372011-03-24 Juanma Barranquero <lekktu@gmail.com>
1338
1339 * w32term.c (x_set_glyph_string_clipping):
1340 Don't pass uninitialized region to CombineRgn.
1341
9c88f339
JB
13422011-03-23 Juanma Barranquero <lekktu@gmail.com>
1343
1344 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
1345 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
1346 (Fx_close_connection): Remove unused variable `i'.
1347
1348 * w32font.c (w32font_draw): Return number of glyphs.
1349 (w32font_open_internal): Remove unused variable `i'.
1350 (w32font_driver): Add missing initializer.
1351
1352 * w32menu.c (utf8to16): Remove unused variable `utf16'.
1353 (fill_in_menu): Remove unused variable `items_added'.
1354
1355 * w32term.c (last_mouse_press_frame): Remove static global variable.
1356 (w32_clip_to_row): Remove unused variable `f'.
1357 (x_delete_terminal): Remove unused variable `i'.
1358
1359 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
1360 (NOTHING): Remove unused static global variable.
1361 (uniscribe_check_otf): Remove unused variable `table'.
1362 (uniscribe_font_driver): Add missing initializers.
1363
dee091a3
JD
13642011-03-23 Julien Danjou <julien@danjou.info>
1365
1366 * term.c (Fsuspend_tty, Fresume_tty):
1367 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
1368 * window.c (temp_output_buffer_show):
1369 * insdel.c (signal_before_change):
1370 * frame.c (Fhandle_switch_frame):
1371 * fileio.c (Fdo_auto_save):
1372 * emacs.c (Fkill_emacs):
1373 * editfns.c (save_excursion_restore):
1374 * cmds.c (internal_self_insert):
1375 * callint.c (Fcall_interactively):
1376 * buffer.c (Fkill_all_local_variables):
1377 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
1378 Use Frun_hooks.
0f4a96b5 1379 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
1380 unconditionnaly since it does the check itself.
1381
2c520ab5 13822011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 1383
c9c49752
PE
1384 Fix more problems found by GCC 4.5.2's static checks.
1385
8abc3f12
PE
1386 * coding.c (encode_coding_raw_text): Avoid unnecessary test
1387 the first time through the loop, since we know p0 < p1 then.
1388 This also avoids a gcc -Wstrict-overflow warning.
1389
a2d26660
PE
1390 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
1391 leading to a memory leak, possible in functions like
1392 load_charset_map_from_file that can allocate an unbounded number
b12ef411 1393 of objects (Bug#8318).
a2d26660 1394
916c72e9
PE
1395 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
1396 that could (at least in theory) be that large.
1397
19ab8a18
PE
1398 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
1399 This is less likely to overflow, and avoids undefined behavior if
1400 overflow does occur. All callers changed. Use strtoul to scan
1401 for the unsigned long integer.
b7cbbd6f
PE
1402 (pint2hrstr): Simplify and tune code slightly.
1403 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 1404
f0641eff
PE
1405 * scroll.c (do_scrolling): Work around GCC bug 48228.
1406 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
1407
7f650bb9
PE
1408 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
1409 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
1410 (validate_x_resource_name): Simplify count usage.
1411 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 1412
37dd57d1
PE
1413 * fileio.c (Fcopy_file): Report error if fchown or fchmod
1414 fail (Bug#8306).
81e56e61 1415
699979fc 1416 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 1417
401bf9b4
PE
1418 * process.c (Fmake_network_process): Use socklen_t, not int,
1419 where POSIX says socklen_t is required in portable programs.
1420 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 1421 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
1422 (Fmake_network_process, server_accept_connection):
1423 (wait_reading_process_output, read_process_output):
1424 Likewise.
1425
b93aacde
PE
1426 * process.c: Rename or move locals to avoid shadowing.
1427 (list_processes_1, Fmake_network_process):
1428 (read_process_output_error_handler, exec_sentinel_error_handler):
1429 Rename or move locals.
4dc343ee 1430 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 1431 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 1432 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 1433 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 1434 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 1435
af8a867c 1436 Make tparam.h and terminfo.c consistent.
44f230aa
SM
1437 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
1438 Include tparam.h instead, since it declares them.
af8a867c
PE
1439 * cm.h (PC): Remove extern decl; tparam.h now does this.
1440 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
1441 * terminfo.c: Include tparam.h, to check interfaces.
1442 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
1443 (tparam): Adjust signature to match interface in tparam.h;
1444 this removes some undefined behavior. Check that outstring and len
1445 are zero, which they always are with Emacs.
1446 * tparam.h (PC, BC, UP): New extern decls.
1447
0248044d 1448 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 1449 (xftfont_open): Rename locals to avoid shadowing.
0248044d 1450
8ff096c1 1451 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
1452 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
1453 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 1454 (ftfont_list): Remove unused local.
49eaafba
PE
1455 (get_adstyle_property, ftfont_pattern_entity):
1456 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
1457 Rename locals to avoid shadowing.
8ff096c1 1458
e2be39f6
PE
1459 * xfont.c (xfont_list_family): Mark var as initialized.
1460
c9735e30
PE
1461 * xml.c (make_dom): Now static.
1462
8f5201ae
PE
1463 * composite.c (composition_compute_stop_pos): Rename local to
1464 avoid shadowing.
b246f932
PE
1465 (composition_reseat_it): Remove unused locals.
1466 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 1467 (composition_update_it): Mark var as initialized.
11b61122
PE
1468 (find_automatic_composition): Mark vars as initialized,
1469 with a FIXME (Bug#8290).
8f5201ae 1470
760fbc2c
PE
1471 character.h: Rename locals to avoid shadowing.
1472 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
1473 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
1474 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
1475 (BUF_DEC_POS): Be more systematic about renaming local temporaries
1476 to avoid shadowing.
1477
ff08eb85
PE
1478 * textprop.c (property_change_between_p): Remove; unused.
1479
fc7bf025
PE
1480 * intervals.c (interval_start_pos): Now static.
1481
235d7abc
PE
1482 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
1483
44f230aa
SM
1484 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
1485 Rename locals to avoid shadowing.
3e7d6594 1486
50060332
PE
1487 * sound.c (wav_play, au_play, Fplay_sound_internal):
1488 Fix pointer signedness.
d01f234b 1489 (alsa_choose_format): Remove unused local var.
c83b8872
PE
1490 (wav_play): Initialize a variable to 0, to prevent undefined
1491 behavior (Bug#8278).
50060332 1492
c4fc4e30
PE
1493 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
1494
918436ed
PE
1495 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
1496
c939f91b
PE
1497 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
1498 clobbering (Bug#8298).
b9c7f648
PE
1499 * sysdep.c (sys_subshell): Likewise.
1500 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 1501
6bd8c144
PE
1502 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
1503 This should get cleaned up, so that child_setup has the
1504 same signature on all platforms.
1505
7710357c 1506 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 1507 (relocate_fd): Rename locals to avoid shadowing.
7710357c 1508
c59da222
CY
15092011-03-22 Chong Yidong <cyd@stupidchicken.com>
1510
1511 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
1512 not to be necessary, and produces flickering.
1513
66b87493
GM
15142011-03-20 Glenn Morris <rgm@gnu.org>
1515
1516 * config.in: Remove file.
1517
45b6f6d5
JB
15182011-03-20 Juanma Barranquero <lekktu@gmail.com>
1519
1520 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
1521 are now in src/globals.h.
1522 (syms_of_minibuf): Remove spurious & from previous change.
1523
3ec03f7e
LL
15242011-03-20 Leo <sdl.web@gmail.com>
1525
1526 * minibuf.c (completing-read-function): New variable.
1527 (completing-read-default): Rename from completing-read.
1528 (completing-read): Call completing-read-function.
1529
b14e3e21
CY
15302011-03-19 Juanma Barranquero <lekktu@gmail.com>
1531
1532 * xfaces.c (Fx_load_color_file):
1533 Read color file from absolute filename (bug#8250).
1534
f2b726e6
JB
15352011-03-19 Juanma Barranquero <lekktu@gmail.com>
1536
1537 * makefile.w32-in: Update dependencies.
1538
09f6ff02
EZ
15392011-03-17 Eli Zaretskii <eliz@gnu.org>
1540
1541 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
1542
29a6015a
PE
15432011-03-17 Paul Eggert <eggert@cs.ucla.edu>
1544
a3a6c54e
PE
1545 Fix more problems found by GCC 4.5.2's static checks.
1546
b766f867
PE
1547 * process.c (make_serial_process_unwind, send_process_trap):
1548 (sigchld_handler): Now static.
1549
be02381c
PE
1550 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
1551 That way, the code declares only the vars that it needs.
1552 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
1553 * s/cygwin.h (PTY_ITERATION): Likewise.
1554 * s/darwin.h (PTY_ITERATION): Likewise.
1555 * s/gnu-linux.h (PTY_ITERATION): Likewise.
1556
57048744
PE
1557 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
1558 * process.c (allocate_pty): Don't declare stb unless it's needed.
1559
7914961c 1560 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
1561 (CONSTANTLIM): Remove; unused.
1562 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
1563 Define only if needed.
7914961c 1564
b3967b18
PE
1565 * unexelf.c (unexec): Name an expression,
1566 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
1567 Use a different way to cause a compilation error if anyone uses
1568 n rather than nn, a way that does not involve shadowing.
73366a00 1569 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 1570
29a6015a
PE
1571 * deps.mk (unexalpha.o): Remove; unused.
1572
43cfc33e 1573 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 1574 * unexec.h: New file.
ce701a33
PE
1575 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
1576 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
1577 Depend on unexec.h.
1578 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
1579 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
1580 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 1581 Change as necessary to match prototype in unexec.h.
ce701a33 1582
01f44d5a
PE
1583 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
1584 shadowing.
4f63c6bb 1585 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 1586
a6670b0b
PE
1587 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
1588 Rename locals to avoid shadowing.
1589
cef2010d 1590 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 1591 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 1592
d4d7173a
PE
1593 * print.c (Fredirect_debugging_output): Fix pointer signedess.
1594
f08b802a
PE
1595 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
1596 warning when compiling print.c.
1597
3ddb0639
PE
1598 * font.c (font_unparse_fcname): Abort in an "impossible" situation
1599 instead of using an uninitialized var.
5ad03b97 1600 (font_sort_entities): Mark var as initialized.
3ddb0639 1601
170a2692
PE
1602 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
1603
e663c700
PE
1604 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
1605 pointers to constants.
89bc529a 1606 (font_parse_fcname): Remove unused vars.
7b81e2d0 1607 (font_delete_unmatched): Now static.
ea838e10 1608 (font_get_spec): Remove; unused.
13a547c6
PE
1609 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
1610 (font_update_drivers, Ffont_get_glyphs, font_add_log):
1611 Rename or move locals to avoid shadowing.
e663c700 1612
2a80c887 1613 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 1614 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 1615
1384fa33 1616 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 1617 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 1618
8b2c52e9
PE
1619 * alloc.c (mark_backtrace): Move decl from here ...
1620 * lisp.h: ... to here, so that it can be checked.
1621
475545b5 1622 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 1623 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
1624 (lisp_indirect_variable): Name an expression,
1625 to avoid gcc -Wbad-function-cast warning.
1faed8ae 1626 (Fdefvar): Rename locals to avoid shadowing.
475545b5 1627
b1349114 1628 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 1629 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 1630 Use const pointer when appropriate.
b1349114 1631
a2928364
PE
1632 * lisp.h (get_system_name, get_operating_system_release):
1633 Move decls here, to check interfaces.
1634 * process.c (get_operating_system_release): Move decl to lisp.h.
1635 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
1636 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
1637 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
1638 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
1639 (Fformat_time_string, Fencode_time, Finsert_char):
1640 (Ftranslate_region_internal, Fformat):
1641 Rename or remove local vars to avoid shadowing.
9710023e 1642 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 1643
a415e694
PE
1644 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
1645 avoid shadowing.
1646
8ef4622d
PE
1647 * lisp.h (eassert): Check that the argument compiles, even if
1648 ENABLE_CHECKING is not defined.
1649
946f9a5b
PE
1650 * data.c (Findirect_variable): Name an expression, to avoid
1651 gcc -Wbad-function-cast warning.
112396d6 1652 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 1653 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
1654 (Fmake_variable_buffer_local, Fmake_local_variable):
1655 Mark variables as initialized.
52746918 1656 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 1657
e5aab7e7 1658 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
1659 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
1660 Rename locals to avoid shadowing.
dff45157
PE
1661 (mark_stack): Move local variables into the #ifdef region where
1662 they're used.
7bc26fdb
PE
1663 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
1664 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
1665 needed otherwise.
1666 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
1667 (GC_STRING_CHARS): Remove; not used.
d40d4be1 1668 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 1669
e5aab7e7
PE
1670 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
1671 avoids undefined behavior in theory.
1672
4da60324
PE
1673 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
1674
88043301
PE
1675 Use functions, not macros, for up- and down-casing (Bug#8254).
1676 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1677 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
1678 to use the following functions instead of these macros.
1679 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
1680 EMACS_INT, since callers assume the returned value fits in int.
1681 (upcase1): Likewise, for UPCASE_TABLE.
1682 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 1683 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 1684 the race-condition problem in the old DOWNCASE.
88043301 1685
19ed5445
PE
1686 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
1687 Rename locals to avoid shadowing.
1688 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
1689 (regex_compile, re_search_2, re_match_2_internal):
1690 Remove unused local vars.
952db0d7
PE
1691 (FREE_VAR): Rewrite so as not to use empty "else",
1692 which gcc can warn about.
da053e48 1693 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
1694 (RETALLOC_IF): Define only if needed.
1695 (WORDCHAR_P): Likewise. This one is never needed, but is used
1696 only in a comment talking about a compiler bug, so put inside
1697 the #if 0 of that comment.
1698 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
1699 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
1700 Remove; unused.
19ed5445 1701
1f3561e4 1702 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
1703 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
1704 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 1705
ded6f8f7
PE
1706 * search.c (simple_search): Remove unused var.
1707
dbd37a95
PE
1708 * dired.c (compile_pattern): Move decl from here ...
1709 * lisp.h: ... to here, so that it can be checked.
1710 (struct re_registers): New forward decl.
1711
7e47afad
PE
1712 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
1713
85f24f61
PE
1714 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
1715 All uses changed.
1716 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
1717 Rename locals to avoid shadowing.
5671df8f 1718 (Fvertical_motion): Mark locals as initialized.
85f24f61 1719
181aa2be 1720 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 1721 (casify_region): Mark local as initialized.
181aa2be 1722
930d429c
PE
1723 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
1724
7082eac6
PE
1725 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
1726 New macros, so that the caller can use some names other than
1727 gcpro1, gcpro2, etc.
1728 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
1729 of the new macros.
1730 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
1731 argument, for consistency with GCPRO2_VAR, etc: it is now the
1732 prefix of the variable, not the variable itself. All uses
1733 changed.
38b2c076
PE
1734 * dired.c (directory_files_internal, file_name_completion):
1735 Rename locals to avoid shadowing.
1736
15206ed9
PE
1737 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
1738 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
1739 dired.c's scmp function, had undefined behavior.
1740 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1741 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
1742 * buffer.h: ... to here, because these macros use current_buffer,
1743 and the new implementation with inline functions needs to have
1744 current_buffer in scope now, rather than later when the macros
1745 are used.
1746 (downcase, upcase1): New static inline functions.
1747 (DOWNCASE, UPCASE1): Reimplement using these functions.
1748 This avoids undefined behavior in expressions like
1749 DOWNCASE (x) == DOWNCASE (y), which previously suffered
1750 from race conditions in accessing the global variables
1751 case_temp1 and case_temp2.
1752 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
1753 * lisp.h (case_temp1, case_temp2): Remove their decls.
1754 * character.h (ASCII_CHAR_P): Move from here ...
1755 * lisp.h: ... to here, so that the inline functions mentioned
1756 above can use them.
1757
4a6bea26
PE
1758 * dired.c (directory_files_internal_unwind): Now static.
1759
f14b7e14
PE
1760 * fileio.c (file_name_as_directory, directory_file_name):
1761 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
1762 Now static.
2893f146
PE
1763 (file_name_as_directory): Use const pointers when appropriate.
1764 (Fexpand_file_name): Likewise. In particular, newdir might
1765 point at constant storage, so make it a const pointer.
fd4ead52 1766 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
1767 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
1768 signedness issues.
f839df0c
PE
1769 (Fset_file_times, Finsert_file_contents, auto_save_error):
1770 Rename locals to avoid shadowing.
f14b7e14 1771
5716756e 1772 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
1773 (Ftry_completion, Fall_completions): Rename or remove locals
1774 to avoid shadowing.
5716756e 1775
b4c3046a
PE
1776 * marker.c (bytepos_to_charpos): Remove; unused.
1777
b45db522
PE
1778 * lisp.h (verify_bytepos, count_markers): New decls,
1779 so that gcc does not warn that these functions aren't declared.
1780
85876d07
PE
1781 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
1782 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 1783 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 1784 (copy_text): Remove unused local var.
85876d07 1785
03d78a21 1786 * filelock.c (within_one_second): Now static.
b3dd38ab 1787 (lock_file_1): Rename local to avoid shadowing.
03d78a21 1788
5df8f01b
PE
1789 * buffer.c (fix_overlays_before): Mark locals as initialized.
1790 (fix_start_end_in_overlays): Likewise. This function should be
1791 simplified by using pointers-to-pointers, but that's a different
1792 matter.
b1d876f1 1793 (switch_to_buffer_1): Now static.
8f54f30a
PE
1794 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
1795 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 1796
a70072c9 1797 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 1798 Fix pointer signedness issue.
edced198
PE
1799 (sys_subshell): Mark local as volatile if checking for lint,
1800 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 1801 (MAXPATHLEN): Define only if needed.
a70072c9 1802
a0977c44
PE
1803 * process.c (serial_open, serial_configure): Move decls from here ...
1804 * systty.h: ... to here, so that they can be checked.
1805
a884fdcc
PE
1806 * fns.c (get_random, seed_random): Move extern decls from here ...
1807 * lisp.h: ... to here, so that they can be checked.
1808
604efe86 1809 * sysdep.c (reset_io): Now static.
b8950c94 1810 (wait_for_termination_signal): Remove; unused.
604efe86 1811
38fc62d9
PE
1812 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
1813 (copy_keymap_item, append_key, push_text_char_description):
1814 Now static.
1004a21a 1815 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 1816 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
1817 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
1818 (describe_map_tree):
1819 Rename locals to avoid shadowing.
38fc62d9 1820
2f2650da
PE
1821 * keyboard.c: Declare functions static if they are not used elsewhere.
1822 (echo_char, echo_dash, cmd_error, top_level_2):
1823 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
1824 (read_char, kbd_buffer_get_event, make_lispy_position):
1825 (make_lispy_event, make_lispy_movement, apply_modifiers):
1826 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
1827 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
1828 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 1829 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 1830 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 1831
a053e86c 1832 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
1833 (mark_kboards): Move decl here ...
1834 * alloc.c (mark_kboards): ... from here.
a053e86c 1835
4752793e
PE
1836 * lisp.h (force_auto_save_soon): New decl.
1837
74f10ca7 1838 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
1839 (DEFINE_DUMMY_FUNCTION): New macro.
1840 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
1841 Use it.
c03cd23f
PE
1842 (main): Add casts to avoid warnings
1843 if GCC considers string literals to be constants.
74f10ca7 1844
022e70d4
PE
1845 * lisp.h (fatal_error_signal): Add decl, since it's exported.
1846
59d6fe83
PE
1847 * dbusbind.c: Pointer signedness fixes.
1848 (xd_signature, xd_append_arg, xd_initialize):
1849 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1850 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1851 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
1852 (Fdbus_register_signal): Use SSDATA when the context wants char *.
1853
78320123
PE
1854 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
1855 if GCC considers string literals to be constants.
49cebcca 1856 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 1857
35ac2a97
SM
18582011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
1859
fb103ca9
SM
1860 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
1861 (print_preprocess, print_object): New macro to fix last change.
1862
35ac2a97
SM
1863 * print.c (print_preprocess): Don't forget font objects.
1864
62973b41
JB
18652011-03-16 Juanma Barranquero <lekktu@gmail.com>
1866
1867 * emacs.c (USAGE3): Doc fixes.
1868
0e48bb22
AS
18692011-03-15 Andreas Schwab <schwab@linux-m68k.org>
1870
1871 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
1872 structure.
1873
7684e57b
JB
18742011-03-14 Juanma Barranquero <lekktu@gmail.com>
1875
1876 * lisp.h (VWindow_system, Qfile_name_history):
1877 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
1878 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
1879 (w32_system_caret_x, w32_system_caret_y): Declare extern.
1880
1881 * w32select.c: Don't #include "keyboard.h".
c96bbc66 1882 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
1883
1884 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
1885 * w32console.c (detect_input_pending, read_input_pending)
1886 (encode_terminal_code):
1887 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
1888 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
1889 (w32_system_caret_y, Qfile_name_history):
1890 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
1891 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
1892 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
1893 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
1894 * w32proc.c (Qlocal, report_file_error):
1895 * w32term.c (Vwindow_system, updating_frame):
1896 * w32uniscribe.c (initialized, uniscribe_font_driver):
1897 Remove unneeded extern declarations.
1898
2aa46d6c
CY
18992011-03-14 Chong Yidong <cyd@stupidchicken.com>
1900
c96bbc66 1901 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 1902
cffc6f3b
CY
19032011-03-13 Chong Yidong <cyd@stupidchicken.com>
1904
1905 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
1906 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
1907 These macros can no longer be used for assignment.
1908
44f230aa
SM
1909 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1910 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
1911 (record_buffer_markers, fetch_buffer_markers): New functions for
1912 recording and fetching special buffer markers.
1913 (set_buffer_internal_1, set_buffer_temp): Use them.
1914
1915 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
1916
1917 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
1918
1919 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
1920 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
1921
1922 * xdisp.c (hscroll_window_tree):
1923 (reconsider_clip_changes): Use PT instead of BUF_PT.
1924
d251f04b
EZ
19252011-03-13 Eli Zaretskii <eliz@gnu.org>
1926
1927 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
1928 $(EMACS_ROOT)/lib/intprops.h.
1929
f0c77cd1
PE
19302011-03-13 Paul Eggert <eggert@cs.ucla.edu>
1931
3eca4629
PE
1932 Fix more problems found by GCC 4.5.2's static checks.
1933
7c86ee98
PE
1934 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
1935 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
1936 (xg_free_frame_widgets): Make it clear that a local variable is
1937 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
1938 (gdk_window_get_screen): Make it clear that this macro is needed
1939 only if USE_GTK_TOOLTIP.
1e5524e7
PE
1940 (int_gtk_range_get_value): New function, which avoids a diagnostic
1941 from gcc -Wbad-function-cast.
1942 (xg_set_toolkit_scroll_bar_thumb): Use it.
1943 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
1944 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
1945 (get_utf8_string, xg_get_file_with_chooser):
1946 Rename locals to avoid shadowing.
1947 (create_dialog): Move locals to avoid shadowing.
7c86ee98 1948
41729b81
PE
1949 * xgselect.c (xg_select): Remove unused var.
1950
f0c77cd1
PE
1951 * image.c (four_corners_best): Mark locals as initialized.
1952 (gif_load): Initialize transparent_p to zero (Bug#8238).
1953 Mark another local as initialized.
ec6cf4c6 1954 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 1955
ce0ad53d 1956 * image.c (clear_image_cache): Now static.
d5d5a617 1957 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 1958 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
1959 (x_edge_detection): Remove unnecessary cast that
1960 gcc -Wbad-function-cast diagnoses.
2037898d 1961 (gif_load): Fix pointer signedness.
6ae141d6
PE
1962 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
1963 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 1964
33383987 19652011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 1966
d32df629
PE
1967 Improve quality of tests for time stamp overflow.
1968 For example, without this patch (encode-time 0 0 0 1 1
1969 1152921504606846976) returns the obviously-bogus value (-948597
1970 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
1971 reports time overflow. See
1972 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
1973 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
1974 * editfns.c: Include limits.h and intprops.h.
1975 (TIME_T_MIN, TIME_T_MAX): New macros.
1976 (time_overflow): Move earlier, to before first use.
1977 (hi_time, lo_time): New functions, for an accurate test for
1978 out-of-range times.
1979 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
1980 (Fget_internal_run_time): Don't assume time_t fits in int.
1981 (make_time): Use list2 instead of Fcons twice.
1982 (Fdecode_time): More accurate test for out-of-range times.
1983 (check_tm_member): New function.
1984 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
1985 (lisp_time_argument): Don't rely on undefined left-shift and
1986 right-shift behavior when checking for time stamp overflow.
8be6f318 1987
fe31d94c
PE
1988 * editfns.c (time_overflow): New function, refactoring common code.
1989 (Fformat_time_string, Fdecode_time, Fencode_time):
1990 (Fcurrent_time_string): Use it.
1991
8be6f318
PE
1992 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
1993 * dired.c (make_time): Move to ...
1994 * editfns.c (make_time): ... here.
1995 * systime.h: Note the move.
1996
09d9db2c 19972011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 1998
126bc0dc
YM
1999 * fringe.c (update_window_fringes): Remove unused variables.
2000
c47cbdfd
YM
2001 * unexmacosx.c (copy_data_segment): Also copy __got section.
2002 (Bug#8223)
2003
7ac80be9
EZ
20042011-03-12 Eli Zaretskii <eliz@gnu.org>
2005
c96bbc66 2006 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
2007 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
2008 Constify `char *' arguments and their references according to
2009 prototypes in tparam.h.
2010
ecb0f94d 2011 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 2012
7ac80be9
EZ
2013 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
2014 Adapt all references accordingly.
2015
2016 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
2017
ef1fd07e
TT
20182011-03-11 Tom Tromey <tromey@redhat.com>
2019
2020 * buffer.c (syms_of_buffer): Remove obsolete comment.
2021
7ef4b50c
EZ
20222011-03-11 Eli Zaretskii <eliz@gnu.org>
2023
2024 * termhooks.h (encode_terminal_code): Declare prototype.
2025
2026 * msdos.c (encode_terminal_code): Don't declare prototype.
2027
2028 * term.c (encode_terminal_code): Now external again, used by
2029 w32console.c and msdos.c.
2030
44f230aa
SM
2031 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
2032 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 2033
4b1ec863 20342011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 2035
1714f52b 2036 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 2037
4b1ec863
PE
2038 * fringe.c (update_window_fringes): Mark locals as initialized
2039 (Bug#8227).
2040 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 2041
524c7aa6
PE
2042 * alloc.c (mark_fringe_data): Move decl from here ...
2043 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
2044 to check its interface.
2045 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
2046
a5c0af81 2047 * fontset.c (free_realized_fontset): Now static.
7519b8cd 2048 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 2049 (fontset_font): Mark local as initialized.
a9a06e0b 2050 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 2051
b4716021
PE
2052 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
2053
811e9bac 2054 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 2055 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
2056 (x_own_selection, Fx_disown_selection_internal): Rename locals
2057 to avoid shadowing.
2058 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 2059
7e3ab302
PE
2060 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
2061 so that the caller can use some name other than gcpro1.
2062 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
2063 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2064 (Fx_backspace_delete_keys_p):
2065 Use them to avoid shadowing, and rename vars to avoid shadowing.
2066 (x_decode_color, x_set_name, x_window): Now static.
6b437900 2067 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 2068 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
2069 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
2070 Remove unused locals.
7e3ab302
PE
2071 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2072 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
2073 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
2074 macros.
f78faa98 2075
e2b13473
PE
2076 * xterm.h (x_mouse_leave): New decl.
2077
77f23912
PE
2078 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
2079 Remove unused functions.
cdf4ba58
PE
2080 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
2081 (x_calc_absolute_position): Now static.
7411c686 2082 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 2083 Don't declare local "event" unless it's used.
ed7bf3a5
PE
2084 (x_iconify_frame, x_free_frame_resources): Don't declare locals
2085 unless they are used.
38d0b34a
PE
2086 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
2087 (x_fatal_error_signal): Remove; not used.
a6067996
PE
2088 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
2089 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
2090 (x_error_catcher, x_connection_closed, x_error_handler):
2091 (x_error_quitter, xembed_send_message, x_iconify_frame):
2092 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 2093 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 2094 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 2095
44f230aa
SM
2096 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
2097 Rename or move locals to avoid shadowing.
6b463e58 2098 (tty_defined_color, merge_face_heights): Now static.
5967d051 2099 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
2100 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
2101 does not deduce is never used uninitialized.
73719eba
PE
2102 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
2103 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 2104
426994c3 2105 * terminal.c (store_terminal_param): Now static.
5489860b 2106
032f1620 2107 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 2108 (set_frame_menubar): Remove unused local.
d4323972 2109 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
2110 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
2111 since they might point to immutable storage.
281585b0
PE
2112 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
2113 since it's unused otherwise.
032f1620 2114
367c19e5 2115 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 2116 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
2117 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
2118 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 2119 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
2120 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
2121 does not deduce are never used uninitialized.
70739cbe 2122
07b48fa9
PE
2123 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
2124
8868a238 2125 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
2126 * window.c (window_loop, size_window):
2127 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 2128
7e5cf297 2129 * window.c (display_buffer): Now static.
d6550a9f
PE
2130 (size_window): Mark variables that gcc -Wuninitialized
2131 does not deduce are never used uninitialized.
a586633d
PE
2132 * window.h (check_all_windows): New decl, to forestall
2133 gcc -Wmissing-prototypes diagnostic.
5b555da1 2134 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 2135
f6095868
PE
2136 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
2137 shadowing.
2138 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
2139 Include <limits.h>.
2140 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
2141 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
2142 (load_charset_map): Mark variables that gcc -Wuninitialized
2143 does not deduce are never used uninitialized.
53df7c11 2144 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 2145
f38b440c
PE
2146 * coding.c (coding_set_source, coding_set_destination):
2147 Use "else { /* comment */ }" rather than "else /* comment */;"
2148 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
2149 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
2150 a block, when the outer 'i' will do.
2151 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
2152 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
2153 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
2154 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
2155 (Fdecode_sjis_char, Fdefine_coding_system_internal):
2156 Rename locals to avoid shadowing.
2157 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
2158 * coding.c (emacs_mule_char, encode_invocation_designation):
2159 Now static, since they're not used elsewhere.
413bb2db 2160 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 2161 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
2162 (decode_coding_emacs_mule): Mark variables that gcc
2163 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
2164 (detect_coding_iso_2022): Initialize a local variable that might
2165 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 2166 this initialization is needed. (Bug#8211)
5f58e762
PE
2167 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
2168 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
2169 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
2170 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
2171 Remove unused macros.
f38b440c 2172
232b38b9 2173 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 2174 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 2175 * character.c (string_count_byte8): Likewise.
232b38b9 2176
fb90da1b
PE
2177 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
2178 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
2179
fb93dbc2
PE
2180 * chartab.c (copy_sub_char_table): Now static, since it's not used
2181 elsewhere.
5c156ace
PE
2182 (sub_char_table_ref_and_range, char_table_ref_and_range):
2183 Rename locals to avoid shadowing.
bbcd0949 2184 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 2185
7d3b3862 2186 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 2187 (BIDI_BOB): Remove unused macro.
7d3b3862 2188
6be7d3da
PE
2189 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
2190 deduce are never used uninitialized.
c2ed9c8b 2191 * term.c (encode_terminal_code): Likewise.
6be7d3da 2192
75f8807f 2193 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 2194
50938595
PE
2195 * tparam.h: New file.
2196 * term.c, tparam.h: Include it.
2197 * deps.mk (term.o, tparam.o): Depend on tparam.h.
2198 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
2199 Move these decls to tparam.h, and make them agree with what
2200 is actually in tparam.c. The previous trick of using incompatible
2201 decls in different modules does not conform to the C standard.
2202 All callers of tparam changed to use tparam's actual API.
2203 * tparam.c (tparam1, tparam, tgoto):
2204 Use const pointers where appropriate.
2205
fbceeba2
PE
2206 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
2207 * cm.h (struct cm): Likewise.
2208 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
2209 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
2210 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
2211 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
2212 (turn_on_face, init_tty): Likewise.
2213 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 2214
7f3f1250
PE
2215 * term.c (term_mouse_position): Rename local to avoid shadowing.
2216
e6ca6543
PE
2217 * alloc.c (mark_ttys): Move decl from here ...
2218 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
2219
c40f8d15
AS
22202011-03-11 Andreas Schwab <schwab@linux-m68k.org>
2221
2222 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
2223
cfe0661d
JB
22242011-03-09 Juanma Barranquero <lekktu@gmail.com>
2225
2226 * search.c (compile_pattern_1): Remove argument regp, unused since
2227 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
2228 (compile_pattern): Don't pass it.
2229
0afb4571
J
22302011-03-08 Jan Djärv <jan.h.d@swipnet.se>
2231
2232 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
2233 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
2234 for ! HAVE_GTK3.
2235 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
2236
2237 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
2238
2239 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
2240 gdk_window_get_screen, gdk_window_get_geometry,
2241 gdk_x11_window_lookup_for_display and GDK_KEY_g.
2242 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
2243 (xg_get_pixbuf_from_pixmap): New function.
2244 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
2245 to Pixmap, take frame as parameter, remove GdkColormap parameter.
2246 Call xg_get_pixbuf_from_pixmap instead of
2247 gdk_pixbuf_get_from_drawable.
2248 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
2249 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
2250 (xg_check_special_colors): Use GtkStyleContext and its functions
2251 for HAVE_GTK3.
2252 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
2253 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
2254 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
2255 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
2256 Call gtk_widget_get_preferred_size.
0afb4571
J
2257 (xg_frame_resized): gdk_window_get_geometry only takes 5
2258 parameters.
44f230aa
SM
2259 (xg_win_to_widget, xg_event_is_for_menubar):
2260 Call gdk_x11_window_lookup_for_display.
0afb4571
J
2261 (xg_set_widget_bg): New function.
2262 (delete_cb): New function.
2263 (xg_create_frame_widgets): connect delete-event to delete_cb.
2264 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
2265 (xg_set_background_color): Call xg_set_widget_bg.
2266 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
2267 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
2268 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
2269 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
2270 if ! HAVE_GTK3.
2271 (update_frame_tool_bar): Call gtk_widget_hide.
2272 (xg_initialize): Use GDK_KEY_g.
2273
2274 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
2275 if ! HAVE_GTK3
2276 (x_session_initialize): Call gdk_x11_set_sm_client_id.
2277
2278 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
2279 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
2280 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
2281
1c2cc4ef
JB
22822011-03-08 Juanma Barranquero <lekktu@gmail.com>
2283
2284 * w32xfns.c (select_palette): Check success of RealizePalette against
2285 GDI_ERROR, not zero.
2286
33383987 2287See ChangeLog.11 for earlier changes.
aac0c6e3
MR
2288
2289;; Local Variables:
2290;; coding: utf-8
aac0c6e3
MR
2291;; End:
2292
33383987 2293 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
2294
2295 This file is part of GNU Emacs.
2296
2297 GNU Emacs is free software: you can redistribute it and/or modify
2298 it under the terms of the GNU General Public License as published by
2299 the Free Software Foundation, either version 3 of the License, or
2300 (at your option) any later version.
2301
2302 GNU Emacs is distributed in the hope that it will be useful,
2303 but WITHOUT ANY WARRANTY; without even the implied warranty of
2304 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
2305 GNU General Public License for more details.
2306
2307 You should have received a copy of the GNU General Public License
2308 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.