* alloc.c (inhibit_garbage_collection): Set gc_cons_threshold to max value.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
c9d624c6
PE
12011-06-08 Paul Eggert <eggert@cs.ucla.edu>
2
c0c5c8ae
PE
3 * alloc.c: Use EMACS_INT, not int, to count objects.
4 (total_conses, total_markers, total_symbols, total_vector_size)
5 (total_free_conses, total_free_markers, total_free_symbols)
6 (total_free_floats, total_floats, total_free_intervals, total_intervals)
7 (total_strings, total_free_strings):
8 Now EMACS_INT, not int. All uses changed.
9 (Fgarbage_collect): Compute overall total using a double, so that
10 integer overflow is less likely to be a problem. Check for overflow
11 when converting back to an integer.
5a25e253
PE
12 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
13 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
14 These were 'int' variables that could overflow on 64-bit hosts;
15 they were never used, so remove them instead of repairing them.
211a0b2a 16 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
17 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
18 Previously, this ceilinged at INT_MAX, but that doesn't work on
19 64-bit machines.
c0c5c8ae 20
c78baabf 21 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 22 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
23 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
24 when a (possibly-narrower) signed value would do just as well.
25 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 26
c9d624c6
PE
27 * alloc.c: Catch some string size overflows that we were missing.
28 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
29 for convenience in STRING_BYTES_MAX.
30 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
31 The definition here is exact; the one in lisp.h was approximate.
32 (allocate_string_data): Check for string overflow. This catches
33 some instances we weren't catching before. Also, it catches
34 size_t overflow on (unusual) hosts where SIZE_MAX <= min
35 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
36 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 37
c9d624c6
PE
38 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
39 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
40 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
41
2bccce07
PE
422011-06-07 Paul Eggert <eggert@cs.ucla.edu>
43
353032ce
PE
44 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
45
2bccce07
PE
46 * alloc.c (Fmake_string): Check for out-of-range init.
47
a54e3482
DC
482011-06-07 Daniel Colascione <dan.colascione@gmail.com>
49
50 * fns.c (Fputhash): Document return value.
51
60002bf5
CY
522011-06-06 Chong Yidong <cyd@stupidchicken.com>
53
54 * image.c (gif_load): Implement gif89a spec "no disposal" method.
55
0c671da6 562011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 57
b862a52a 58 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 59
be44ca6c
PE
60 Check for overflow when converting integer to cons and back.
61 * charset.c (Fdefine_charset_internal, Fdecode_char):
62 Use cons_to_unsigned to catch overflow.
63 (Fencode_char): Use INTEGER_TO_CONS.
64 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
65 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
66 * data.c (long_to_cons, cons_to_long): Remove.
67 (cons_to_unsigned, cons_to_signed): New functions.
68 These signal an error for invalid or out-of-range values.
69 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
70 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
71 * font.c (Ffont_variation_glyphs):
72 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
73 * lisp.h: Include <intprops.h>.
74 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
75 (cons_to_signed, cons_to_unsigned): New decls.
76 (long_to_cons, cons_to_long): Remove decls.
77 * undo.c (record_first_change): Use INTEGER_TO_CONS.
78 (Fprimitive_undo): Use CONS_TO_INTEGER.
79 * xfns.c (Fx_window_property): Likewise.
80 * xselect.c: Include <limits.h>.
81 (x_own_selection, selection_data_to_lisp_data):
82 Use INTEGER_TO_CONS.
83 (x_handle_selection_request, x_handle_selection_clear)
84 (x_get_foreign_selection, Fx_disown_selection_internal)
85 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
86 (lisp_data_to_selection_data): Use cons_to_unsigned.
87 (x_fill_property_data): Use cons_to_signed.
88 Report values out of range.
89
d1f3d2af
PE
90 Check for buffer and string overflow more precisely.
91 * buffer.h (BUF_BYTES_MAX): New macro.
92 * lisp.h (STRING_BYTES_MAX): New macro.
93 * alloc.c (Fmake_string):
94 * character.c (string_escape_byte8):
95 * coding.c (coding_alloc_by_realloc):
96 * doprnt.c (doprnt):
97 * editfns.c (Fformat):
98 * eval.c (verror):
99 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
100 since they may not be the same number.
101 * editfns.c (Finsert_char):
102 * fileio.c (Finsert_file_contents):
103 Likewise for BUF_BYTES_MAX.
104
dd52fcea
PE
105 * image.c: Use ptrdiff_t, not int, for sizes.
106 (slurp_file): Switch from int to ptrdiff_t.
107 All uses changed.
108 (slurp_file): Check that file size fits in both size_t (for
109 malloc) and ptrdiff_t (for sanity and safety).
110
7f9bbdbb
PE
111 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
112 if b->modtime has its maximal value.
113
dfe18f82
PE
114 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
115
84acfcf0
PE
116 Don't assume time_t can fit into int.
117 * buffer.h (struct buffer.modtime): Now time_t, not int.
118 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
119 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
120
ccd9a01a
PE
121 Minor fixes for signed vs unsigned integers.
122 * character.h (MAYBE_UNIFY_CHAR):
123 * charset.c (maybe_unify_char):
124 * keyboard.c (read_char, reorder_modifiers):
125 XINT -> XFASTINT, since the integer must be nonnegative.
126 * ftfont.c (ftfont_spec_pattern):
127 * keymap.c (access_keymap, silly_event_symbol_error):
128 XUINT -> XFASTINT, since the integer must be nonnegative.
129 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
130 since it makes no difference and we prefer signed.
131 * keyboard.c (record_char): Use XUINT when all the neighbors do.
132 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
133 nonnegative.
134
d6d100dd
SM
1352011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
136
137 * window.h (Fwindow_frame): Declare.
138
2b6148e4
PE
1392011-06-06 Paul Eggert <eggert@cs.ucla.edu>
140
141 * alloc.c: Simplify handling of large-request failures (Bug#8800).
142 (SPARE_MEMORY): Always define.
143 (LARGE_REQUEST): Remove.
144 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
145
f230ecc9
MR
1462011-06-06 Martin Rudalics <rudalics@gmx.at>
147
727e958e
MR
148 * lisp.h: Move EXFUNS for Fframe_root_window,
149 Fframe_first_window and Fset_frame_selected_window to window.h.
150
151 * window.h: Move EXFUNS for Fframe_root_window,
152 Fframe_first_window and Fset_frame_selected_window here from
153 lisp.h.
154
155 * frame.c (Fwindow_frame, Fframe_first_window)
156 (Fframe_root_window, Fframe_selected_window)
157 (Fset_frame_selected_window): Move to window.c.
158 (Factive_minibuffer_window): Move to minibuf.c.
159 (Fother_visible_frames_p): New function.
160
161 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
162
f230ecc9
MR
163 * window.c (decode_window, decode_any_window): Move up in code.
164 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
165 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
166 (Fwindow_buffer): Move up and rewrite doc-string.
167 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
168 (Fwindow_prev): New functions.
727e958e
MR
169 (Fwindow_frame): Move here from frame.c. Accept any window as
170 argument.
171 (Fframe_root_window, Fframe_first_window)
172 (Fframe_selected_window): Move here from frame.c. Accept frame
173 or arbitrary window as argument. Update doc-strings.
174 (Fminibuffer_window): Move up in code.
175 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
176 (Fset_frame_selected_window): Move here from frame.c.
177 Marginal rewrite.
727e958e
MR
178 (Fselected_window, select_window, Fselect_window): Move up in
179 code. Minor doc-string fixes.
f230ecc9 180
4d09bcf6
PE
1812011-06-06 Paul Eggert <eggert@cs.ucla.edu>
182
183 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
184 Do not assume that spare memory exists; that assumption is valid
185 only if SYSTEM_MALLOC.
186 (LARGE_REQUEST): New macro, so that the issue of large requests
187 is separated from the issue of spare memory.
188
810928a2
AS
1892011-06-05 Andreas Schwab <schwab@linux-m68k.org>
190
172418ad
AS
191 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
192 format. (Bug#8806)
193
43f862f7
AS
194 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
195
810928a2
AS
196 * xfns.c (x_set_scroll_bar_default_width): Move declarations
197 before statements.
198
a059fe24
JD
1992011-06-05 Jan Djärv <jan.h.d@swipnet.se>
200
201 * gtkutil.c (xg_get_default_scrollbar_width): New function.
202
203 * gtkutil.h: Declare xg_get_default_scrollbar_width.
204
205 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
206 min width by calling x_set_scroll_bar_default_width (Bug#8505).
207
989bf368
JB
2082011-06-05 Juanma Barranquero <lekktu@gmail.com>
209
210 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
211
4b80f674
CY
2122011-06-04 Chong Yidong <cyd@stupidchicken.com>
213
214 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
215 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
216 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
217 New error handlers.
4b80f674
CY
218 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
219 Obey Vx_select_enable_clipboard_manager. Catch errors in
220 x_clipboard_manager_save (Bug#8779).
221 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 222 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 223
99a33b77 2242011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
225
226 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
227
99a33b77 2282011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
229
230 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
231 in the current matrix if keep_current_p is non-zero.
232
8264569d
EZ
2332011-06-04 Eli Zaretskii <eliz@gnu.org>
234
235 * bidi.c (bidi_level_of_next_char): Fix last change.
236
57f97249
EZ
2372011-06-03 Eli Zaretskii <eliz@gnu.org>
238
fec2107c 239 Support bidi reordering of text covered by display properties.
57f97249 240
fec2107c
EZ
241 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
242 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
243 (bidi_cache_search, bidi_cache_iterator_state)
244 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
245 (bidi_level_of_next_char, bidi_move_to_visually_next):
246 Support character positions inside a run of characters covered by a
fec2107c
EZ
247 display string.
248 (bidi_paragraph_init, bidi_resolve_explicit_1)
249 (bidi_level_of_next_char): Call bidi_fetch_char and
250 bidi_fetch_char_advance instead of FETCH_CHAR and
251 FETCH_CHAR_ADVANCE.
252 (bidi_init_it): Initialize new members.
253 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
254 definitions.
255 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
256 instead of using explicit *_CHAR codes.
d6d100dd
SM
257 (bidi_resolve_explicit, bidi_resolve_weak):
258 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
259 bidirectional text is supported only in multibyte buffers.
260 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
261 it to initialize the frame_window_p member of struct bidi_it.
262 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
263 (bidi_resolve_explicit, bidi_resolve_weak)
264 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
265 bidi_it->nchars is non-positive.
266 (bidi_level_of_next_char): Don't try to lookup the cache for the
267 next/previous character if nothing is cached there yet, or if we
268 were just reseat()'ed to a new position.
c40e2fb2 269
0e14fe90
EZ
270 * xdisp.c (set_cursor_from_row): Set start and stop points
271 according to the row's direction when priming the loop that looks
272 for the glyph on which to display cursor.
273 (single_display_spec_intangible_p): Function deleted.
274 (display_prop_intangible_p): Reimplement to call
275 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
276 Accept 3 additional arguments needed by handle_display_spec.
277 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
278 values: lists, `(when COND...)' forms, etc.
279 (single_display_spec_string_p): Support property values that are
280 lists with the argument STRING its top-level element.
281 (display_prop_string_p): Fix the condition for processing a
282 property that is a list to be consistent with handle_display_spec.
fec2107c 283 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
284 last portion of handle_display_prop.
285 (compute_display_string_pos): Accept additional argument
286 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
287 value of a `display' property is a "replacing spec".
288 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
289 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
290 the display property, but just return a value indicating whether
291 the display property will replace the characters it covers.
292 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
293 frame_window_p members of struct bidi_it.
d6d100dd
SM
294 (compute_display_string_pos, compute_display_string_end):
295 New functions.
fec2107c
EZ
296 (push_it): Accept second argument POSITION, where pop_it should
297 jump to continue iteration.
298 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 299
fec2107c
EZ
300 * keyboard.c (adjust_point_for_property): Adjust the call to
301 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
302
303 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
304 (bidi_init_it): Update prototypes.
305 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
306 (compute_display_string_pos, compute_display_string_end):
307 Declare prototypes.
fec2107c
EZ
308 (struct bidi_it): New members nchars and disp_pos. ch_len is now
309 EMACS_INT.
fc6f18ce 310
40087514 3112011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 312
57f53182
PE
313 Malloc failure behavior now depends on size of allocation.
314 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
315 * lisp.h: Change signatures accordingly.
316 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
317 All callers changed. (Bug#8762)
318
319 * gnutls.c: Use Emacs's memory allocators.
320 Without this change, the gnutls library would invoke malloc etc.
321 directly, which causes problems on non-SYNC_INPUT hosts, and which
322 runs afoul of improving memory_full behavior. (Bug#8761)
323 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
324 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
325 xfree instead of the default malloc, realloc, free.
326 (Fgnutls_boot): No need to check for memory allocation failure,
327 since xmalloc does that for us.
328
ac32cd99 329 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
330 * category.c (hash_get_category_set):
331 * ccl.c (ccl_driver):
332 * charset.c (Fdefine_charset_internal):
333 * charset.h (struct charset.hash_index):
334 * composite.c (get_composition_id, gstring_lookup_cache)
335 (composition_gstring_put_cache):
336 * composite.h (struct composition.hash_index):
337 * dispextern.h (struct image.hash):
338 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
339 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
340 (hashfn_equal, hashfn_user_defined, make_hash_table)
341 (maybe_resize_hash_table, hash_lookup, hash_put)
342 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
343 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
344 (Fsxhash, Fgethash, Fputhash, Fmaphash):
345 * image.c (make_image, search_image_cache, lookup_image)
346 (xpm_put_color_table_h):
347 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 348 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
349 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
350 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
351 * alloc.c (allocate_vectorlike):
352 Check for overflow in vector size calculations.
353 * ccl.c (ccl_driver):
354 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
355 * fns.c, image.c: Remove unnecessary static decls that would otherwise
356 need to be updated by these changes.
40087514
PE
357 * fns.c (make_hash_table, maybe_resize_hash_table):
358 Check for integer overflow with large hash tables.
0de4bb68
PE
359 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
360 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
361 (SXHASH_REDUCE): New macro.
362 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
363 Use it instead of discarding useful hash info with large hash values.
364 (sxhash_float): New function.
365 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
366 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
367 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
368 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
369 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
370 Adjust signatures to match updated version of code.
371 (consing_since_gc): Now EMACS_INT, since a single hash table can
372 use more than INT_MAX bytes.
373
698d32e2
DN
3742011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
375
376 Make it possible to build with GCC-4.6+ -O2 -flto.
377
378 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
379
fd6fa53f
SM
3802011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
381
382 * minibuf.c (get_minibuffer, read_minibuf_unwind):
383 Call minibuffer-inactive-mode.
384
864db017
JB
3852011-05-31 Juanma Barranquero <lekktu@gmail.com>
386
387 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
388 Update dependencies.
389
2ad0baf4
DN
3902011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
391
392 * data.c (init_data): Remove code for UTS, this system is not
393 supported anymore.
394
4fcc2638
DN
3952011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
396
397 Don't force ./temacs to start in terminal mode.
398
399 * frame.c (make_initial_frame): Initialize faces in all cases, not
400 only when CANNOT_DUMP is defined.
401 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
402
c56e0fd5
DN
4032011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
404
405 * dispnew.c (add_window_display_history): Use const for the string
406 pointer. Remove declaration, not needed.
407
333d54da 4082011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 409
55d4c1b2 410 Use 'inline', not 'INLINE'.
333d54da 411 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
412 * alloc.c, fontset.c (INLINE): Remove.
413 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
414 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
415 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
416 * gmalloc.c (register_heapinfo): Use inline unconditionally.
417 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
418
738db178
DN
4192011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
420
421 Make it possible to run ./temacs.
422
423 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
424 syms_of_callproc does the same thing. Remove test for
425 "initialized", do it in the caller.
426 * emacs.c (main): Avoid calling set_initial_environment when dumping.
427
620c53a6
SM
4282011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
429
430 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
431 (read_minibuf): Use get_minibuffer.
432 (syms_of_minibuf): Use DEFSYM.
433 (Qmetadata): New var.
434 * data.c (Qbuffer): Don't make it static.
435 (syms_of_data): Use DEFSYM.
436
e003a292
PE
4372011-05-31 Paul Eggert <eggert@cs.ucla.edu>
438
439 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
440 (CCL_CODE_MIN): New macro.
441
ed008a6d
PE
4422011-05-30 Paul Eggert <eggert@cs.ucla.edu>
443
3687c2ef
PE
444 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
445
ed008a6d
PE
446 * eval.c (Qdebug): Now static.
447 * lisp.h (Qdebug): Remove decl. This reverts a part of the
448 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
449 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
450
d66c4c7c
CY
4512011-05-29 Chong Yidong <cyd@stupidchicken.com>
452
453 * image.c: Various fixes to ImageMagick code comments.
454 (Fimagemagick_types): Doc fix.
455
5fbc2025
PE
4562011-05-29 Paul Eggert <eggert@cs.ucla.edu>
457
0196f88a
PE
458 Minor fixes prompted by GCC 4.6.0 warnings.
459
460 * xselect.c (converted_selections, conversion_fail_tag): Now static.
461
5fbc2025
PE
462 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
463 (x_clipboard_manager_save_all): Move extern decl to ...
464 * xterm.h: ... here, so that it can be checked for consistency.
465
1dd3c2d9
CY
4662011-05-29 Chong Yidong <cyd@stupidchicken.com>
467
468 * xselect.c (x_clipboard_manager_save_frame)
469 (x_clipboard_manager_save_all): New functions.
470 (Fx_clipboard_manager_save): Lisp function deleted.
471
472 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
473 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
474
475 * xterm.h: Update prototype.
476
5ba6571d
WX
4772011-05-28 William Xu <william.xwl@gmail.com>
478
479 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
480 exiting (Bug#8239).
481
3eaff834
JM
4822011-05-28 Jim Meyering <meyering@redhat.com>
483
e1900994 484 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
485 * fns.c (to_uchar): Define.
486 (crypto_hash_function): Use it to convert some newly-signed
487 variables to unsigned, to avoid sign-extension bugs. For example,
488 without this change, (md5 "truc") would evaluate to
489 45723a2aff78ff4fff7fff1114760e62 rather than the expected
490 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 491 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 492
0f6990a7
PE
4932011-05-27 Paul Eggert <eggert@cs.ucla.edu>
494
495 Integer overflow fixes.
c8a9ca5a 496
08686060
PE
497 * dbusbind.c: Serial number integer overflow fixes.
498 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
499 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
500 to hold a serial number that is too large for a fixnum.
501 (Fdbus_method_return_internal, Fdbus_method_error_internal):
502 Check for serial numbers out of range. Decode any serial number
59568bf0 503 that was so large that it became a float. (Bug#8722)
08686060 504
2d1fc3c7
PE
505 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
506 (Fdbus_call_method, Fdbus_call_method_asynchronously):
507 Use XFASTINT rather than XUINT when numbers are nonnegative.
508 (xd_append_arg, Fdbus_method_return_internal):
509 (Fdbus_method_error_internal): Likewise. Also, for unsigned
510 arguments, check that Lisp number is nonnegative, rather than
59568bf0 511 silently wrapping negative numbers around. (Bug#8722)
30217ff0 512 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 513 (Bug#8722)
2d1fc3c7 514
c8a9ca5a
PE
515 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
516
519e1d69
PE
517 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
518
30569699
PE
519 ccl: add integer overflow checks
520 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
521 (IN_INT_RANGE): New macros.
522 (ccl_driver): Use them to check for integer overflow when
523 decoding a CCL program. Many of the new checks are whether XINT (x)
524 fits in int; it doesn't always, on 64-bit hosts. The new version
525 doesn't catch all possible integer overflows, but it's an
847044ea 526 improvement. (Bug#8719)
30569699 527
c11285dc
PE
528 * alloc.c (make_event_array): Use XINT, not XUINT.
529 There's no need for unsigned here.
530
fdccd48e
PE
531 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
532 This follows up to the 2011-05-06 change that substituted uintptr_t
533 for EMACS_INT. This case wasn't caught back then.
534
37910ab2
PE
535 Rework Fformat to avoid integer overflow issues.
536 * editfns.c: Include <float.h> unconditionally, as it's everywhere
537 now (part of C89). Include <verify.h>.
538 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
539 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
540 (Fformat): Avoid the prepass trying to compute sizes; it was only
541 approximate and thus did not catch overflow reliably. Instead, walk
542 through the format just once, formatting and computing sizes as we go,
543 checking for integer overflow at every step, and allocating a larger
544 buffer as needed. Keep track separately whether the format is
545 multibyte. Keep only the most-recently calculated precision, rather
546 than them all. Record whether each argument has been converted to
547 string. Use EMACS_INT, not int, for byte and char and arg counts.
548 Support field widths and precisions larger than INT_MAX. Avoid
549 sprintf's undefined behavior with conversion specifications such as %#d
550 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
551 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
552 formatting out-of-range floating point numbers with int
553 formats. (Bug#8668)
554
2e6578fb
PE
555 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
556
0ae6bdee
PE
557 * data.c: Avoid integer truncation in expressions involving floats.
558 * data.c: Include <intprops.h>.
559 (arith_driver): When there's an integer overflow in an expression
560 involving floating point, convert the integers to floating point
561 so that the resulting value does not suffer from catastrophic
562 integer truncation. For example, on a 64-bit host (* 4
563 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
564 Do not rely on undefined behavior after integer overflow.
565
de883a70
PE
566 merge count_size_as_multibyte, parse_str_to_multibyte
567 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 568 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
569 Check for integer overflow.
570 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
571 since it's now a duplicate of the other. This is more of
572 a character than a buffer op, so better that it's in character.c.
573 * fns.c, print.c: Adjust to above changes.
574
2ff916cb
PE
5752011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
576
577 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
578
f1b54466
PE
5792011-05-27 Paul Eggert <eggert@cs.ucla.edu>
580
fb1ac845
PE
581 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
582 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
583 (x_clipboard_manager_save): Now static.
584 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
585
f1b54466
PE
586 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
587 (crypto_hash_function): Now static.
588 Fix pointer signedness problems. Avoid unnecessary initializations.
589
a9f737ee
CY
5902011-05-27 Chong Yidong <cyd@stupidchicken.com>
591
592 * termhooks.h (Vselection_alist): Make it terminal-local.
593
594 * terminal.c (create_terminal): Initialize it.
595
596 * xselect.c: Support for clipboard managers.
597 (Vselection_alist): Move to termhooks.h as terminal-local var.
598 (LOCAL_SELECTION): New macro.
599 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
600 (symbol_to_x_atom): Remove gratuitous arg.
601 (x_handle_selection_request, lisp_data_to_selection_data)
602 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
603 (x_own_selection, x_get_local_selection, x_convert_selection):
604 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
605 (some_frame_on_display): Delete unused function.
606 (Fx_own_selection_internal, Fx_get_selection_internal)
607 (Fx_disown_selection_internal, Fx_selection_owner_p)
608 (Fx_selection_exists_p): New optional frame arg.
609 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
610 (x_handle_selection_clear): Don't treat other terminals with the
611 same keyboard specially. Use the terminal-local Vselection_alist.
612 (x_clear_frame_selections): Use Frun_hook_with_args.
613
614 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
615
616 * xterm.h: Add support for those atoms.
617
e067f0c1
CY
6182011-05-26 Chong Yidong <cyd@stupidchicken.com>
619
620 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
621 (converted_selections, conversion_fail_tag): New global variables.
622 (x_selection_request_lisp_error): Free the above.
623 (x_get_local_selection): Remove unnecessary code.
624 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
625 of converted selections stored in converted_selections.
626 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
627 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
628 (x_convert_selection): New function.
629 (x_handle_selection_event): Simplify.
630 (x_get_foreign_selection): Don't ignore incoming requests while
631 waiting for an answer; this will fail when we implement
632 SAVE_TARGETS, and seems unnecessary anyway.
633 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
634 (Vx_sent_selection_functions): Doc fix.
635
0f4aebc0
LL
6362011-05-26 Leo Liu <sdl.web@gmail.com>
637
638 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
639
e61124cd
YM
6402011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
641
642 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
643
644 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
645 for fringe update if it has periodic bitmap.
646 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
647 and fringe_bitmap_periodic_p.
648
649 * fringe.c (get_fringe_bitmap_data): New function.
650 (draw_fringe_bitmap_1, update_window_fringes): Use it.
651 (update_window_fringes): Record periodicity of fringe bitmap in glyph
652 row. Mark glyph row for fringe update if periodicity changed.
653
654 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
655 for fringe update unless it has periodic bitmap.
656
f16d9837
KH
6572011-05-25 Kenichi Handa <handa@m17n.org>
658
659 * xdisp.c (get_next_display_element): Set correct it->face_id for
660 a static composition.
661
e1b90ef6
LL
6622011-05-24 Leo Liu <sdl.web@gmail.com>
663
664 * deps.mk (fns.o):
665 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
666
667 * fns.c (crypto_hash_function, Fsha1): New function.
668 (Fmd5): Use crypto_hash_function.
669 (syms_of_fns): Add Ssha1.
670
7400048f
PE
6712011-05-22 Paul Eggert <eggert@cs.ucla.edu>
672
673 * gnutls.c: Remove unused macros.
674 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
675 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
676 Remove macros that are defined and never used.
677 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
678
abb71cf4
CY
6792011-05-22 Chong Yidong <cyd@stupidchicken.com>
680
681 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
682 (Fx_get_selection_internal): Minor cleanup.
683 (Fx_own_selection_internal): Rename arguments for consistency with
684 select.el.
685
6307db39
PE
6862011-05-22 Paul Eggert <eggert@cs.ucla.edu>
687
688 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
689
f3d4e0a4
CY
6902011-05-22 Chong Yidong <cyd@stupidchicken.com>
691
692 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
693
4d8ade89
YM
6942011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
695
696 * dispnew.c (scrolling_window): Don't exclude the case that the
697 last enabled row in the desired matrix touches the bottom boundary.
698
32078c8d
GM
6992011-05-21 Glenn Morris <rgm@gnu.org>
700
701 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
702 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
703 and add some more files.
32078c8d 704
7285dc67
EZ
7052011-05-20 Eli Zaretskii <eliz@gnu.org>
706
707 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
708 report_file_error introduced by the change from 2011-05-07.
709
89d1bd22
PE
7102011-05-20 Paul Eggert <eggert@cs.ucla.edu>
711
712 * systime.h (Time): Define only if emacs is defined.
713 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
714 where the include path doesn't have X11/X.h by default. See
715 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
716
e23640bb 7172011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
718
719 * composite.c (find_automatic_composition): Fix previous change.
720
b9704ad9
GM
7212011-05-20 Glenn Morris <rgm@gnu.org>
722
723 * lisp.mk: New file, split from Makefile.in.
724 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
725 (shortlisp): Remove.
726 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
727
4a720484
GM
7282011-05-19 Glenn Morris <rgm@gnu.org>
729
730 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
731 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
732 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
733 (lisp): Set the order to that of loadup.el.
734 (shortlisp): Make it a copy of $lisp.
735 (SOME_MACHINE_LISP): Remove.
736 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
737 Use just $shortlisp, not $SOME_MACHINE_LISP too.
738
a28d4396
KH
7392011-05-18 Kenichi Handa <handa@m17n.org>
740
741 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
742 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
743 (find_automatic_composition): Mostly rewrite for efficiency.
744
a2b1fa8e
JB
7452011-05-18 Juanma Barranquero <lekktu@gmail.com>
746
747 * makefile.w32-in: Update dependencies.
748
8e1f5610
CS
7492011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
750
751 * menu.c: Include limits.h (fixes the MS-Windows build broken by
752 revision 104625).
753
7025ee00 7542011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 755
cdfa6eab
PE
756 Fix some integer overflow issues, such as string length overflow.
757
06d6db33
PE
758 * insdel.c (count_size_as_multibyte): Check for string overflow.
759
2b4560a8
PE
760 * character.c (lisp_string_width): Check for string overflow.
761 Use EMACS_INT, not int, for string indexes and lengths; in
762 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
763 the resulting string length overflows an EMACS_INT; instead,
764 report a string overflow if no precision given. When checking for
765 precision exhaustion, use a check that cannot possibly have
766 integer overflow. (Bug#8675)
767 * character.h (lisp_string_width): Adjust to new signature.
768
cb93f9be
PE
769 * alloc.c (string_overflow): New function.
770 (Fmake_string): Use it. This doesn't change behavior, but saves
771 a few bytes and will simplify future changes.
772 * character.c (string_escape_byte8): Likewise.
773 * lisp.h (string_overflow): New decl.
774
1a1f3366
PE
775 Fixups, following up to the user-interface timestamp change.
776 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
777 for UI timestamps, instead of unsigned long.
9fbd6841
PE
778 * msdos.c (mouse_get_pos): Likewise.
779 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
780 * w32gui.h (Time): Define by including "systime.h" rather than by
781 declaring it ourselves. (Bug#8664)
782
d4e3e4d3
PE
783 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
784 * image.c (clear_image_cache): Likewise.
785
f6a24d19
PE
786 * term.c (term_mouse_position): Don't assume time_t wraparound.
787
08dc5ae6
PE
788 Be more systematic about user-interface timestamps.
789 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
790 and sometimes 'EMACS_UINT', to represent these timestamps.
791 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
792 This makes the code easier to follow, and makes it easier to catch
793 integer overflow bugs such as Bug#8664.
794 * frame.c (Fmouse_position, Fmouse_pixel_position):
795 Use Time, not unsigned long, for user-interface timestamps.
796 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
797 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
798 * keyboard.h (last_event_timestamp): Likewise.
799 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
800 * menu.h (xmenu_show): Likewise.
801 * term.c (term_mouse_position): Likewise.
802 * termhooks.h (struct input_event.timestamp): Likewise.
803 (struct terminal.mouse_position_hook): Likewise.
804 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
805 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
806 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
807 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
808 what it was before.
809 * menu.h, termhooks.h: Include "systime.h", for Time.
810
8e55734a
PE
811 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
812 Don't assume that the difference between two unsigned long values
813 can fit into an integer. At this point, we know button_down_time
814 <= event->timestamp, so the difference must be nonnegative, so
815 there's no need to cast the result if double-click-time is
816 nonnegative, as it should be; check that it's nonnegative, just in
817 case. This bug is triggered when events are more than 2**31 ms
86db42d2 818 apart (about 25 days). (Bug#8664)
8e55734a 819
841f1b75 820 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 821 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 822
3e26f69c
PE
823 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
824 that always fit in int. Use a sentinel instead of a counter, to
825 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
826 * frame.h (struct frame): Use int for menu_bar_items_used
827 instead of EMACS_INT, since it always fits in int.
3e26f69c 828
5cc152c0
PE
829 * menu.c (grow_menu_items): Check for int overflow.
830
d89eb65e
PE
831 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
832
5235bd3e
PE
833 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
834 Before, the code was not consistent. These values cannot exceed
835 2**31 - 1 so there's no need to make them unsigned.
836 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
837 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
838 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
839 as modifiers.
840 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
841
bc827e23
PE
842 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
843 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
844 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
845 presumably because the widths might not match.
846
78eb494e
PE
847 * window.c (size_window): Avoid needless test at loop start.
848
04f2d78b
CB
8492011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
850
851 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
852
d2fc7e3d 8532011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
854
855 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
856
d2fc7e3d 8572011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
858
859 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
860 `width' to `bar_area_x' and `bar_area_width', respectively.
861 (x_scroll_run): Take account of fringe background extension.
862
04f2d78b
CB
863 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
864 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
865 `bar_area_width', respectively.
866 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
867 background extension.
868
79b70037
GM
8692011-05-10 Jim Meyering <meyering@redhat.com>
870
871 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
872
2f142cc5
JB
8732011-05-10 Juanma Barranquero <lekktu@gmail.com>
874
875 * image.c (Finit_image_library): Return t for built-in image types,
876 like pbm and xbm. (Bug#8640)
877
57679c86
AS
8782011-05-09 Andreas Schwab <schwab@linux-m68k.org>
879
880 * w32menu.c (set_frame_menubar): Fix submenu allocation.
881
888c9e86
EZ
8822011-05-07 Eli Zaretskii <eliz@gnu.org>
883
b0512a1d
EZ
884 * w32console.c (Fset_screen_color): Doc fix.
885 (Fget_screen_color): New function.
886 (syms_of_ntterm): Defsubr it.
887
7285dc67
EZ
888 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
889 unlink the temporary file if Fcall_process didn't create it in the
890 first place.
891 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
892 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
893 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
894 cue to call_process_cleanup not to close that handle.
895
4d3fcc8e
BK
8962011-05-07 Ben Key <bkey76@gmail.com>
897
898 * makefile.w32-in: The bootstrap-temacs rule now makes use of
899 one of two shell specific rules, either bootstrap-temacs-CMD or
900 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
901 to the previous implementation of the bootstrap-temacs rule.
902 The bootstrap-temacs-CMD rule is similar to the previous
903 implementation of the bootstrap-temacs rule except that it
904 makes use of the ESC_CFLAGS variable instead of the CFLAGS
905 variable.
906
907 These changes, along with some changes to nt/configure.bat,
908 nt/gmake.defs, and nt/nmake.defs, are required to extend my
909 earlier fix to add support for --cflags and --ldflags options
910 that include quotes so that it works whether make uses cmd or
911 sh as the shell.
912
b4289b64
MA
9132011-05-06 Michael Albinus <michael.albinus@gmx.de>
914
915 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
916 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
917 is a constant.
918 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
919 a string. Handle both cases.
920 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
921 (Fdbus_register_method): Use Qinvalid_function.
922
af4c0e28
JB
9232011-05-06 Juanma Barranquero <lekktu@gmail.com>
924
925 * makefile.w32-in: Update dependencies.
926 (LISP_H): Add inttypes.h and stdin.h.
927 (PROCESS_H): Add unistd.h.
928
c51453d9
EZ
9292011-05-06 Eli Zaretskii <eliz@gnu.org>
930
931 * lread.c: Include limits.h (fixes the MS-Windows build broken by
932 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
933
8ff0ac3c 9342011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 935
4c4b566b
PE
936 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
937
aab2b9b5
PE
938 * term.c (vfatal): Remove stray call to va_end.
939 It's not needed and the C Standard doesn't allow it here anyway.
940
c378da0b
PE
941 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
942 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
943
288b08c7
PE
944 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
945 bytes.
946
e3601888
PE
947 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
948
db6c0e74
PE
949 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
950
dd5963ea
PE
951 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
952
88c9450f
PE
953 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
954
2f9442b8
PE
955 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
956
c032b5f8
PE
957 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
958 * charset.c (Fdefine_charset_internal): Don't initialize
959 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 960 32-bit int (Bug#8600).
a108c10b
PE
961
962 * lread.c (read_integer): Be more consistent with string-to-number.
963 Use string_to_number to do the actual conversion; this avoids
964 rounding errors and fixes some other screwups. Without this fix,
965 for example, #x1fffffffffffffff was misread as -2305843009213693952.
966 (digit_to_number): Move earlier, for benefit of read_integer.
967 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 968 not a digit in any supported base. (Bug#8602)
a108c10b 969
ad5f9eea
PE
970 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
971
aec1708a
PE
972 * dispnew.c (scrolling_window): Return 1 if we scrolled,
973 to match comment at start of function. This also removes a
974 GCC warning about overflow in a 32+64-bit port.
975
47be4ab5
PE
976 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
977
371cac43
PE
978 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
979 Reported by Stefan Monnier in
980 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
981 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
982 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 983
d01a7826
PE
984 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
985 (EMACS_UINTPTR): Likewise, with uintptr_t.
986
7fd47d5c
PE
987 * lisp.h: Prefer 64-bit EMACS_INT if available.
988 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
989 on 32-bit hosts that have 64-bit int, so that they can access
990 large files.
122b0c86
PE
991 However, temporarily disable this change unless the temporary
992 symbol WIDE_EMACS_INT is defined.
7fd47d5c 993
8727937b
PE
994 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
995
8ac068ac
PE
996 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
997 This removes an assumption that EMACS_INT and long are the same
998 width as pointers. The assumption is true for Emacs porting targets
999 now, but we want to make other targets possible.
1000 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1001 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1002 In the rest of the code, change types of integers that hold casted
1003 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1004 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1005 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1006 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1007 No need to cast type when ORing.
1008 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1009 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1010 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1011 assume EMACS_INT is the same width as char *.
1012 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1013 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1014 Remove no-longer-needed casts.
1015 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1016 (xg_tool_bar_help_callback, xg_make_tool_item):
1017 Use EMACS_INTPTR to hold an integer
1018 that will be cast to void *; this can avoid a GCC warning
1019 if EMACS_INT is not the same width as void *.
1020 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1021 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1022 (current_message_1, set_message_1):
1023 Use a local to convert to proper width without a cast.
1024 * xmenu.c (dialog_selection_callback): Likewise.
1025
ede49d71
PE
1026 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1027 Also, don't assume VALBITS / RAND_BITS is less than 5,
1028 and don't rely on undefined behavior when shifting a 1 left into
1029 the sign bit.
1030 * lisp.h (get_random): Change signature to match.
1031
2f30ecd0
PE
1032 * lread.c (hash_string): Use size_t, not int, for hash computation.
1033 Normally we prefer signed values; but hashing is special, because
1034 it's better to use unsigned division on hash table sizes so that
1035 the remainder is nonnegative. Also, size_t is the natural width
1036 for hashing into memory. The previous code used 'int', which doesn't
1037 retain enough info to hash well into very large tables.
1038 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1039
2a866e7b
PE
1040 * dbusbind.c: Don't possibly lose pointer info when converting.
1041 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1042 Use XPNTR rather than XHASH, so that the high-order bits of
1043 the pointer aren't lost when converting through void *.
1044
51639eac
PE
1045 * eval.c (Fautoload): Don't double-shift a pointer.
1046
92394119
PE
1047 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1048
dbdb9a7c
JB
10492011-05-06 Juanma Barranquero <lekktu@gmail.com>
1050
1051 * gnutls.c (DEF_GNUTLS_FN):
1052 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1053
db7a0b4f
AS
10542011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1055
1056 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1057 marker. (Bug#8610)
1058
f7ff1b0f 10592011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
1060
1061 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1062 New version that can reserve upto 2GB of heap space.
1063
f7ff1b0f 10642011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
1065
1066 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1067
639c109b
TZ
10682011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1069
1070 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1071 `gnutls_certificate_set_x509_key_file'.
1072
d2127135
JB
10732011-05-05 Juanma Barranquero <lekktu@gmail.com>
1074
1075 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1076 Update dependencies.
1077
e968f4f3
JB
10782011-05-04 Juanma Barranquero <lekktu@gmail.com>
1079
1080 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1081 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1082 Remove unused parameter `fildes'.
1083 * process.c (read_process_output, send_process): Don't pass it.
1084
84d358f0
JB
10852011-05-04 Juanma Barranquero <lekktu@gmail.com>
1086
1087 Fix previous change: the library cache is defined in w32.c.
1088 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1089 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1090
0898ca10
JB
10912011-05-04 Juanma Barranquero <lekktu@gmail.com>
1092
1093 Implement dynamic loading of GnuTLS on Windows.
1094
1095 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1096 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1097 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1098 Declare.
1099
1100 * gnutls.c (Qgnutls_dll): Define.
1101 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1102 (gnutls_*): Declare function pointers.
1103 (init_gnutls_functions): New function to initialize function pointers.
1104 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1105 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1106 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1107 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1108 (emacs_gnutls_write, emacs_gnutls_read)
1109 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1110 (Fgnutls_available_p): New function.
1111 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1112 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1113 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1114
1115 * image.c: Include w32.h.
1116 (Vimage_type_cache): Delete.
1117 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1118 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1119 (w32_delayed_load): Move to w32.c.
1120
1121 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1122
1123 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1124 (w32_delayed_load): Move from image.c. When loading a library, record
1125 its filename in the :loaded-from property of the library id.
1126 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1127 Initialize and staticpro them.
1128 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1129
1130 * process.c: Include lisp.h before w32.h, not after.
1131 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1132 instead of gnutls_record_check_pending.
1133
1134 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1135
ff4de4aa
TZ
11362011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1137
1138 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1139 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1140 as passed in.
1141
abe95abb
JD
11422011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1143
1144 * xterm.c (x_set_frame_alpha): Do not set property on anything
1145 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1146
e16e55d4
JB
11472011-05-02 Juanma Barranquero <lekktu@gmail.com>
1148
1149 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1150
bafcf6a5
JB
11512011-05-02 Juanma Barranquero <lekktu@gmail.com>
1152
1153 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1154 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1155 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1156 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1157 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1158 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1159 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1160 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1161 (Qgnutls_bootprop_callbacks_verify): Make static.
1162
e7a6747f
AS
11632011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1164
19ed11ba
AS
1165 * callproc.c: Indentation fixup.
1166
e7a6747f 1167 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
1168 (wait_for_termination, interruptible_wait_for_termination):
1169 Move after wait_for_termination_1.
e7a6747f 1170
1ef14cb4
LMI
11712011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1172
1173 * sysdep.c (interruptible_wait_for_termination): New function
1174 which is like wait_for_termination, but allows keyboard
1175 interruptions.
1176
1177 * callproc.c (Fcall_process): Add (:file "file") as an option for
1178 the STDOUT buffer.
1179 (Fcall_process_region): Ditto.
1180
330d880c
EZ
11812011-04-30 Eli Zaretskii <eliz@gnu.org>
1182
8db90b73
EZ
1183 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1184 rather than `XVECTOR (FOO)->size'.
1185
330d880c
EZ
1186 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1187 inttypes.h, as a gnulib replacement is used if it not available in
1188 system headers.
1189
15cbd324
EZ
11902011-04-21 Eli Zaretskii <eliz@gnu.org>
1191
1192 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1193 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1194 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1195
1196 * coding.c (coding_alloc_by_realloc): Error out if destination
1197 will grow beyond MOST_POSITIVE_FIXNUM.
1198 (decode_coding_emacs_mule): Abort if there isn't enough place in
1199 charbuf for the composition carryover bytes. Reserve an extra
1200 space for up to 2 characters produced in a loop.
1201 (decode_coding_iso_2022): Abort if there isn't enough place in
1202 charbuf for the composition carryover bytes.
1203
12042011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 1205
ae940cca
EZ
1206 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1207 aborting when %lld or %lll format is passed.
1208 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1209 %llo or %llx format is passed. (Bug#8545)
1210
03ab8921
EZ
1211 * window.c (window_scroll_line_based): Use a marker instead of
1212 simple variables to record original value of point. (Bug#7952)
1213
afda1437
EZ
1214 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1215 produced by %s or %c overflows available buffer space. (Bug#8545)
1216
f76dee0c
PE
12172011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1218
1219 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 1220 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 1221
fdc5744d
JB
12222011-04-28 Juanma Barranquero <lekktu@gmail.com>
1223
1224 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1225
638f053a
JB
12262011-04-28 Juanma Barranquero <lekktu@gmail.com>
1227
1228 * keyboard.c (Qdelayed_warnings_hook): Define.
1229 (command_loop_1): Run `delayed-warnings-hook'
1230 if Vdelayed_warnings_list is non-nil.
1231 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1232 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1233
d178f871
EZ
12342011-04-28 Eli Zaretskii <eliz@gnu.org>
1235
1236 * doprnt.c (doprnt): Don't return value smaller than the buffer
1237 size if the message was truncated. (Bug#8545).
1238
b124fd93
JB
12392011-04-28 Juanma Barranquero <lekktu@gmail.com>
1240
1241 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1242 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1243
e810457d
PE
12442011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1245
1246 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1247
ea51cceb
JB
12482011-04-27 Juanma Barranquero <lekktu@gmail.com>
1249
1250 * makefile.w32-in: Update dependencies.
1251
94dcfacf
EZ
12522011-04-27 Eli Zaretskii <eliz@gnu.org>
1253
1254 Improve `doprnt' and its usage. (Bug#8545)
1255 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1256 `format_end'. Remove support for %l as a conversion specifier.
1257 Don't use xrealloc. Improve diagnostics when the %l size modifier
1258 is used. Update the commentary.
1259
1260 * eval.c (verror): Simplify calculation of size_t.
1261
1262 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1263 messages.
1264
f61f41d7
PE
12652011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1266
1267 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1268 change.
1269
96fb4434
PE
12702011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1271
1272 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1273 This makes this file independent of the recent pseudovector change.
1274
671875da 12752011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 1276
69e9b5a3
PE
1277 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1278
b5f869a7 1279 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 1280 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 1281 Remove unused local.
c8926152 1282 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 1283
841a1577 1284 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
1285 GCC 4.6.0 optimizes based on type-based alias analysis.
1286 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
1287 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1288 != &v->size, and therefore "v->size = 1; b->size = 2; return
1289 v->size;" must therefore return 1. This assumption is incorrect
1290 for Emacs, since it type-puns struct Lisp_Vector * with many other
1291 types. To fix this problem, this patch adds a new type struct
f904488f 1292 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
1293 and pseudovectors, and helps optimizing compilers not get fooled
1294 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1295 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
1296 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1297 the size member.
eab3844f
PE
1298 (XSETPVECTYPE): Rewrite in terms of new macro.
1299 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1300 This is a bit clearer, and further avoids the possibility of
1301 undesirable aliasing.
1302 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 1303 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
1304 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1305 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
1306 (ASIZE): Now uses header.size rather than size.
1307 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
1308 to avoid the hassle of writing XVECTOR (foo)->header.size.
1309 (struct vectorlike_header): New type.
eab3844f
PE
1310 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1311 object, to help avoid aliasing.
1312 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1313 (SUBRP): Likewise, since Lisp_Subr is a special case.
1314 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1315 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1316 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 1317 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
1318 changed to be "header.size" and "header.next".
1319 * buffer.h (struct buffer): Likewise.
1320 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1321 * frame.h (struct frame): Likewise.
1322 * process.h (struct Lisp_Process): Likewise.
1323 * termhooks.h (struct terminal): Likewise.
1324 * window.c (struct save_window_data, struct saved_window): Likewise.
1325 * window.h (struct window): Likewise.
1326 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1327 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1328 * buffer.c (init_buffer_once): Likewise.
1329 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1330 special case.
1331 * process.c (Fformat_network_address): Use local var for size,
1332 for brevity.
1333
0df1eac5
PE
1334 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1335
847ab9d1 1336 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
1337 * data.c (atof): Remove decl; no longer used or needed.
1338 (digit_to_number): Move to lread.c.
1339 (Fstring_to_number): Use new string_to_number function, to be
1340 consistent with how the Lisp reader treats infinities and NaNs.
1341 Do not assume that floating-point numbers represent EMACS_INT
1342 without losing information; this is not true on most 64-bit hosts.
1343 Avoid double-rounding errors, by insisting on integers when
1344 parsing non-base-10 numbers, as the documentation specifies.
1345 * lisp.h (string_to_number): New decl, replacing ...
1346 (isfloat_string): Remove.
bc0a5c13 1347 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 1348 (read1): Do not accept +. and -. as integers; this
452f4150
PE
1349 appears to have been a coding error. Similarly, do not accept
1350 strings like +-1e0 as floating point numbers. Do not report
1351 overflow for integer overflows unless the base is not 10 which
1352 means we have no simple and reliable way to continue.
1353 Break out the floating-point parsing into a new
1354 function string_to_number, so that Fstring_to_number parses
1355 floating point numbers consistently with the Lisp reader.
04f2d78b 1356 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
1357 (E_CHAR, EXP_INT): Remove, replacing with ...
1358 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1359 (string_to_number): New function, replacing isfloat_string.
1360 This function checks for valid syntax and produces the resulting
1361 Lisp float number too. Rework it so that string-to-number
bc0a5c13 1362 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
1363 so that overflow for non-base-10 numbers is reported only when
1364 there's no portable and simple way to convert to floating point.
452f4150 1365
67769ffc
PE
1366 * textprop.c (set_text_properties_1): Rewrite for clarity,
1367 and to avoid GCC warning about integer overflow.
1368
c20db43f
PE
1369 * intervals.h (struct interval): Use EMACS_INT for members
1370 where EMACS_UINT might cause problems. See
1371 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1372 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1373 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1374 All uses changed.
37aa2f85
PE
1375 (offset_intervals): Tell GCC not to worry about length overflow
1376 when negating a negative length.
c20db43f 1377
2538aa2f
PE
1378 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1379 (overrun_check_free): Likewise.
1380
f2d3008d
PE
1381 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1382 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1383 word size.
1384
ec8df744
PE
1385 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1386 (gnutls_make_error): Rename local to avoid shadowing.
1387 (gnutls_emacs_global_deinit): ifdef out; not used.
1388 (Fgnutls_boot): Use const for pointer to readonly storage.
1389 Comment out unused local. Fix pointer signedness problems.
1390
640ee02d
PE
1391 * lread.c (openp): Don't stuff size_t into an 'int'.
1392 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
1393 about possible signed overflow.
1394
6048fb2a
PE
1395 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1396 (GDK_KEY_g): Don't define if already defined.
1397 (xg_prepare_tooltip): Avoid pointer signedness problem.
1398 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
1399
fa3c87e1
PE
1400 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
1401 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
1402
2172544b
PE
1403 * xfns.c (Fx_window_property): Simplify a bit,
1404 to make a bit faster and to avoid GCC 4.6.0 warning.
1405 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
1406
9b821a21
PE
1407 * fns.c (internal_equal): Don't assume size_t fits in int.
1408
3c616cfa
PE
1409 * alloc.c (compact_small_strings): Tighten assertion a little.
1410
c2982e87
PE
1411 Replace pEd with more-general pI, and fix some printf arg casts.
1412 * lisp.h (pI): New macro, generalizing old pEd macro to other
1413 conversion specifiers. For example, use "...%"pI"d..." rather
1414 than "...%"pEd"...".
1415 (pEd): Remove. All uses replaced with similar uses of pI.
1416 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
1417 * alloc.c (check_pure_size): Don't overflow by converting size to int.
1418 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
1419 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
1420 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
1421 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
1422 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
1423 64-bit hosts.
1424 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
1425 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
1426 * print.c (safe_debug_print, print_object): Likewise.
1427 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
1428 to int.
6f04d126
PE
1429 Use pI instead of if-then-else-abort. Use %p to avoid casts,
1430 avoiding the 0 flag, which is not portable.
c2982e87
PE
1431 * process.c (Fmake_network_process): Use pI to avoid cast.
1432 * region-cache.c (pp_cache): Likewise.
1433 * xdisp.c (decode_mode_spec): Likewise.
1434 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
1435 behavior on 64-bit hosts with printf arg.
6f04d126 1436 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
1437 (x_stop_queuing_selection_requests): Likewise.
1438 (x_get_window_property): Don't truncate byte count to an 'int'
1439 when tracing.
0b432f21 1440
5e073ec7
PE
1441 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
1442 here, since it parses constructs like leading '-' and spaces,
1443 which are not wanted; and it overflows with large numbers.
1444 Instead, simply match F[0-9]+, which is what is wanted anyway.
1445
36372bf9
PE
1446 * alloc.c: Remove unportable assumptions about struct layout.
1447 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
1448 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
1449 (allocate_vectorlike, make_pure_vector): Use the new macros,
1450 plus offsetof, to remove unportable assumptions about struct layout.
1451 These assumptions hold on all porting targets that I know of, but
1452 they are not guaranteed, they're easy to remove, and removing them
1453 makes further changes easier.
1454
0b432f21
PE
1455 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1456 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
1457 (string_overrun_cookie): Now const. Use initializers that
1458 don't formally overflow signed char, to avoid warnings.
000098c1
PE
1459 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1460 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
1461 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1462 multiple of sizeof (EMACS_INT); it need not be, if
1463 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 1464 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 1465
895009e1
JB
14662011-04-26 Juanma Barranquero <lekktu@gmail.com>
1467
1468 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1469
6a7a1b0b
TZ
14702011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1471
1472 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 1473 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
1474 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1475
841a1577 14762011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
1477
1478 * lisp.h (Qdebug): List symbol.
895009e1 1479 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
1480 * keyboard.c (debug-on-event): New variable.
1481 (handle_user_signal): Break into debugger when debug-on-event
1482 matches the current signal symbol.
1483
f2d3ba6f
DN
14842011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1485
1486 * alloc.c (check_sblock, check_string_bytes)
1487 (check_string_free_list): Convert to standard C.
1488
42ce4c63
TZ
14892011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1490
1491 * w32.c (emacs_gnutls_push): Fix typo.
1492
825cd63c
EZ
14932011-04-25 Eli Zaretskii <eliz@gnu.org>
1494
fb11d64d
EZ
1495 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1496 "cast to pointer from integer of different size".
1497
825cd63c
EZ
1498 Improve doprnt and its use in verror. (Bug#8545)
1499 * doprnt.c (doprnt): Document the set of format control sequences
1500 supported by the function. Use SAFE_ALLOCA instead of always
1501 using `alloca'.
1502
1503 * eval.c (verror): Don't limit the buffer size at size_max-1, that
1504 is one byte too soon. Don't use xrealloc; instead xfree and
1505 xmalloc anew.
1506
e061a11b
TZ
15072011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
1508
1509 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
1510 callbacks stage.
1511
1512 * gnutls.c: Renamed global_initialized to
1513 gnutls_global_initialized. Added internals for the
1514 :verify-hostname-error, :verify-error, and :verify-flags
1515 parameters of `gnutls-boot' and documented those parameters in the
1516 docstring. Start callback support.
1517 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
1518 unless a fatal error occured. Call gnutls_alert_send_appropriate
1519 on error. Return error code.
1520 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
1521 (emacs_gnutls_read): Likewise.
1522 (Fgnutls_boot): Return handshake error code.
1523 (emacs_gnutls_handle_error): New function.
1524 (wsaerror_to_errno): Likewise.
1525
1526 * w32.h (emacs_gnutls_pull): Add prototype.
1527 (emacs_gnutls_push): Likewise.
1528
1529 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
1530 (emacs_gnutls_push): Likewise.
1531
15322011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
1533
1534 * process.c (wait_reading_process_output): Check if GnuTLS
1535 buffered some data internally if no FDs are set for TLS
1536 connections.
1537
1538 * makefile.w32-in (OBJ2): Add gnutls.$(O).
1539 (LIBS): Link to USER_LIBS.
1540 ($(BLD)/gnutls.$(0)): New target.
1541
fa6996bc
EZ
15422011-04-24 Eli Zaretskii <eliz@gnu.org>
1543
eb35682e
EZ
1544 * xdisp.c (handle_single_display_spec): Rename the
1545 display_replaced_before_p argument into display_replaced_p, to
1546 make it consistent with the commentary. Fix typos in the
1547 commentary.
1548
e2ad650c
EZ
1549 * textprop.c (syms_of_textprop): Remove dead code.
1550 (copy_text_properties): Delete obsolete commentary about an
1551 interface that was deleted long ago. Fix typos in the description
1552 of arguments.
1553
1b2de274
EZ
1554 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
1555 to changes in oldXMenu/XMenu.h from 2011-04-16.
1556 <menu_help_message, prev_menu_help_message>: Constify.
1557 (IT_menu_make_room): menu->help_text is now `const char **';
1558 adjust.
1559
1560 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
1561 to changes in oldXMenu/XMenu.h from 2011-04-16.
1562 (struct XMenu): Declare `help_text' `const char **'.
1563
1564 * xfaces.c <Qunspecified>: Make extern again.
1565
1566 * syntax.c: Include sys/types.h before including regex.h, as
1567 required by Posix.
1568
762b15be
EZ
1569 * doc.c (get_doc_string): Improve the format passed to `error'.
1570
1571 * doprnt.c (doprnt): Improve commentary.
1572
1573 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
1574
1575 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
1576 them with etags.
1577
f1052e5d
EZ
1578 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
1579 changes in globals.h immediately force recompilation.
762b15be
EZ
1580 (TAGS): Depend on $(CURDIR)/m/intel386.h and
1581 $(CURDIR)/s/ms-w32.h.
1582 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 1583
fa6996bc
EZ
1584 * character.c (Fchar_direction): Function deleted.
1585 (syms_of_character): Don't defsubr it.
1586 <char-direction-table>: Deleted.
1587
e6c3da20
EZ
15882011-04-23 Eli Zaretskii <eliz@gnu.org>
1589
1590 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
1591 * doprnt.c: Include limits.h.
1592 (SIZE_MAX): New macro.
04f2d78b
CB
1593 (doprnt): Return a size_t value. 2nd arg is now size_t.
1594 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
1595 Improve overflow protection. Support `l' modifier for integer
1596 conversions. Support %l conversion. Don't assume an EMACS_INT
1597 argument for integer conversions and for %c.
1598
1599 * lisp.h (doprnt): Restore prototype.
1600
1601 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
1602 $(SRC)/character.h.
1603
1604 * Makefile.in (base_obj): Add back doprnt.o.
1605
1606 * deps.mk (doprnt.o): Add back prerequisites.
1607 (callint.o): Depend on character.h.
1608
1609 * eval.c (internal_lisp_condition_case): Include the handler
1610 representation in the error message.
1611 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1612 when breaking from the loop.
1613
1614 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1615
1616 * callint.c (Fcall_interactively): When displaying error message
1617 about invalid control letter, pass the character's codepoint, not
1618 a pointer to its multibyte form. Improve display of the character
1619 in octal and display also its hex code.
1620
1621 * character.c (char_string): Use %x to display the (unsigned)
1622 codepoint of an invalid character, to avoid displaying a bogus
1623 negative value.
1624
1625 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1626 `error', not SYMBOL_NAME itself.
1627
1628 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1629 character arguments to `error'.
1630
1631 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1632 to `error' in error message about FINAL_CHAR argument. Make sure
1633 FINAL_CHAR is a character, and use %c when it is passed as
1634 argument to `error'.
1635
4ffd0d6b 16362011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
1637
1638 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1639
1640 * w32.c: Include <time.h>.
1641 (sys_localtime): New function.
1642
4ffd0d6b 16432011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
1644
1645 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1646
4ffd0d6b 1647 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 1648
4ffd0d6b 16492011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 1650
4ffd0d6b
GM
1651 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1652 zombies (Bug#8467).
aac0c6e3 1653
04c56954
EZ
16542011-04-19 Eli Zaretskii <eliz@gnu.org>
1655
1656 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1657 gl_state.e_property when gl_state.object is Qt.
1658
1659 * insdel.c (make_gap_larger): Remove limitation of buffer size
1660 to <= INT_MAX.
1661
16a43933
CY
16622011-04-18 Chong Yidong <cyd@stupidchicken.com>
1663
1664 * xdisp.c (lookup_glyphless_char_display)
1665 (produce_glyphless_glyph): Handle cons cell entry in
1666 glyphless-char-display.
1667 (Vglyphless_char_display): Document it.
1668
1669 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1670 glyphless-char-display.
1671
4581706e
CY
16722011-04-17 Chong Yidong <cyd@stupidchicken.com>
1673
1674 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1675
1676 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1677
1678 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1679 definition for no-X builds.
1680
4887c6e2 16812011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 1682
fd35b6f9
PE
1683 Static checks with GCC 4.6.0 and non-default toolkits.
1684
5c1ccb01
PE
1685 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1686
006c5daa
PE
1687 * process.c (keyboard_bit_set): Define only if SIGIO.
1688 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1689 (send_process): Repair possible setjmp clobbering.
1690
efc736d3
PE
1691 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1692
4e2fe2e6
PE
1693 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1694
f97334a2
PE
1695 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1696
4e75f29d
PE
1697 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1698 Define only if needed.
1699
90efadd1
PE
1700 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1701 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 1702 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 1703
3c647824
PE
1704 * dispextern.h (struct redisplay_interface): Rename param
1705 to avoid shadowing.
e264f262 1706 * termhooks.h (struct terminal): Likewise.
761383f4 1707 * xterm.c (xembed_send_message): Likewise.
3c647824 1708
b58c5c4a
PE
1709 * insdel.c (make_gap_smaller): Define only if
1710 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
1711
cad59032
PE
1712 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
1713 it.
1714
c339dc2e
PE
1715 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1716 so that we aren't warned about unused symbols.
1717
91a3e27b
PE
1718 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1719
399c71d3 1720 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 1721
8ffc96f5
PE
1722 * xfns.c (x_real_positions): Mark locals as initialized.
1723
eef9bc79
PE
1724 * xmenu.c (xmenu_show): Don't use uninitialized vars.
1725
098db9dd
PE
1726 * xterm.c: Fix problems found by static analysis with other toolkits.
1727 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
1728 (x_dispatch_event): Declare static if USE_GTK, and
1729 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 1730 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 1731 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
1732 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1733 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 1734
eb18f6cc
PE
1735 * xmenu.c (menu_help_callback): Pointer type fixes.
1736 Use const pointers when pointing at readonly data. Avoid pointer
1737 signedness clashes.
1738 (FALSE): Remove unused macro.
1739 (update_frame_menubar): Remove unused decl.
1740
1fe72bf8
PE
1741 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1742
60d9e1db
PE
1743 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1744 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1745 (single_menu_item): Rename local to avoid shadowing.
1746
39261c26
PE
1747 * keyboard.c (make_lispy_event): Remove unused local var.
1748
018c5e19
PE
1749 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1750 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1751
63d2b86e
PE
1752 * bitmaps: Change bitmaps from unsigned char back to the X11
1753 compatible char. Avoid the old compiler warnings about
1754 out-of-range initializers by using, for example, '\xab' rather
1755 than 0xab.
1756
aefd87e1
PE
1757 * xgselect.c (xgselect_initialize): Check vs interface
1758 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1759
bf501fb9
PE
1760 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1761
e9829fdf
PE
1762 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1763 to read-only memory.
1764
1086c095
PE
1765 * fns.c (vector): Remove; this old hack is no longer needed.
1766
2baccd04 1767 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 1768 Remove unused var.
dde42981 1769 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 1770
72391843 1771 * xrdb.c (x_load_resources): Omit unused local.
3565b346 1772
436c16df 1773 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 1774 (x_window): Rename locals to avoid shadowing.
dc5ddd85 1775 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 1776
92bb796d 1777 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 1778 (x_term_init): Remove local to avoid shadowing.
92bb796d 1779
764430a3 1780 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
1781
1782 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1783 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1784
d1dfb56c
EZ
17852011-04-16 Eli Zaretskii <eliz@gnu.org>
1786
c4354cb4
EZ
1787 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1788
d1dfb56c
EZ
1789 Fix regex.c, syntax.c and friends for buffers > 2GB.
1790 * syntax.h (struct gl_state_s): Declare character position members
1791 EMACS_INT.
1792
1793 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1794
04f2d78b
CB
1795 * textprop.c (verify_interval_modification, interval_of):
1796 Declare arguments EMACS_INT.
d1dfb56c
EZ
1797
1798 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1799 EMACS_INT.
1800
1801 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1802
1803 * indent.c (Fvertical_motion): Local variable it_start is now
1804 EMACS_INT.
1805
1806 * regex.c (re_match, re_match_2, re_match_2_internal)
1807 (bcmp_translate, regcomp, regexec, print_double_string)
1808 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1809 (re_compile_pattern, re_exec): Declare arguments and local
1810 variables `size_t' and `ssize_t' and return values `regoff_t', as
1811 appropriate.
1812 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1813 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1814 <compile_stack_type>: `size' and `avail' are now `size_t'.
1815
1816 * regex.h <regoff_t>: Use ssize_t, not int.
1817 (re_search, re_search_2, re_match, re_match_2): Arguments that
1818 specify buffer/string position and length are now ssize_t and
1819 size_t. Return type is regoff_t.
1820
613052cd
BK
18212011-04-16 Ben Key <bkey76@gmail.com>
1822
1823 * nsfont.m: Fixed bugs in ns_get_family and
1824 ns_descriptor_to_entity that were caused by using free to
1825 deallocate memory blocks that were allocated by xmalloc (via
1826 xstrdup). This caused Emacs to crash when compiled with
1827 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1828 --enable-checking=xmallocoverrun). xfree is now used to
1829 deallocate these memory blocks.
1830
4170f62f 18312011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 1832
71b41406
PE
1833 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1834
9587a89d
PE
1835 emacs_write: Accept and return EMACS_INT for sizes.
1836 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1837 et seq.
1838 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1839 Accept and return EMACS_INT.
1840 (emacs_gnutls_write): Return the number of bytes written on
1841 partial writes.
1842 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
1843 (emacs_read, emacs_write): Remove check for negative size, as the
1844 Emacs source code has been audited now.
9587a89d
PE
1845 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1846 (emacs_read, emacs_write): Use it.
273a5f82
PE
1847 * process.c (send_process): Adjust to the new signatures of
1848 emacs_write and emacs_gnutls_write. Do not attempt to store
1849 a byte offset into an 'int'; it might overflow.
9587a89d 1850 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 1851
3e047f51
PE
1852 * sound.c: Don't assume sizes fit in 'int'.
1853 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 1854 Return EMACS_INT, not int.
3e047f51 1855 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
1856 Accept EMACS_INT, not int.
1857 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
1858 record read return values.
1859
cc39a9db
BK
18602011-04-15 Ben Key <bkey76@gmail.com>
1861
c9d0ec6d
JB
1862 * keyboard.c (Qundefined): Don't declare static since it is used
1863 in nsfns.m.
1864 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1865 static since they are used in nsfont.m.
cc39a9db 1866
6c60eb9f
SM
18672011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1868
1869 * process.c (Qprocessp): Don't declare static.
1870 * lisp.h (Qprocessp): Declare again.
1871
7990b61a
JB
18722011-04-15 Juanma Barranquero <lekktu@gmail.com>
1873
1874 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1875
5d4cb038
PE
18762011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1877
8bd7b830 1878 Improve C-level modularity by making more things 'static'.
cd64ea1d 1879
e3b27b31
PE
1880 Don't publish debugger-only interfaces to other modules.
1881 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1882 (verify_bytepos, count_markers): Move decls to the only modules
1883 that need them.
1884 * region-cache.h (pp_cache): Likewise.
1885 * window.h (check_all_windows): Likewise.
1886 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1887
5d4cb038
PE
1888 * sysdep.c (croak): Now static, if
1889 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1890 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
1891
1892 * alloc.c (refill_memory_reserve): Now static if
1893 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1894 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 1895
e87b6180
PE
1896 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1897 Define only if USE_LUCID.
1898
ac64929e
PE
1899 * xrdb.c (x_customization_string, x_rm_string): Now static.
1900
6f37259d
PE
1901 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1902 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1903
1683e3ab
PE
1904 * xdisp.c (draw_row_with_mouse_face): Now static.
1905 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1906
de9c2632
PE
1907 * window.h (check_all_windows): Mark externally visible.
1908
2b96acb7
PE
1909 * window.c (window_deletion_count): Now static.
1910
1911 * undo.c: Make symbols static if they're not exported.
1912 (last_undo_buffer, last_boundary_position, pending_boundary):
1913 Now static.
1914
50436f33
PE
1915 * textprop.c (interval_insert_behind_hooks): Now static.
1916 (interval_insert_in_front_hooks): Likewise.
1917
64520e5c
PE
1918 * term.c: Make symbols static if they're not exported.
1919 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1920 (max_frame_lines, tty_set_terminal_modes):
1921 (tty_reset_terminal_modes, tty_turn_off_highlight):
1922 (get_tty_terminal): Now static.
1923 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1924 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 1925 HAVE_WINDOW_SYSTEM.
64520e5c
PE
1926 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
1927 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
1928
1fa53021
PE
1929 * sysdep.c: Make symbols static if they're not exported.
1930 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
1931 Now static.
1932 (sigprocmask_set, full_mask): Remove; unused.
1933 (wait_debugging): Mark as visible.
1934 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
1935 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
1936
d4b43b22
PE
1937 * syntax.c (syntax_temp): Define only if !__GNUC__.
1938
b7c513d0
PE
1939 * sound.c (current_sound_device, current_sound): Now static.
1940
989b29ad
PE
1941 * search.c (searchbufs, searchbuf_head): Now static.
1942
13a55a78
PE
1943 * scroll.c (scroll_cost): Remove; unused.
1944 * dispextern.h (scroll_cost): Remove decl.
1945
de68a1fc
PE
1946 * region-cache.h (pp_cache): Mark as externally visible.
1947
40ccffa6
PE
1948 * process.c: Make symbols static if they're not exported.
1949 (process_tick, update_tick, create_process, chan_process):
1950 (Vprocess_alist, proc_buffered_char, datagram_access):
1951 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1952 (deactivate_process): Mark defn as static, as well as decl.
1953 * lisp.h (create_process): Remove decl.
1954 * process.h (chan_process, Vprocess_alist): Remove decls.
1955
ad64fc97
PE
1956 * print.c: Make symbols static if they're not exported.
1957 (print_depth, new_backquote_output, being_printed, print_buffer):
1958 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1959 (print_interval, print_number_index, initial_stderr_stream):
1960 Now static.
1961 * lisp.h (Fprinc): Remove decl.
1962 (debug_output_compilation_hack): Mark as externally visible.
1963
adddb265
PE
1964 * sysdep.c (croak): Move decl from here to syssignal.h.
1965 * syssignal.h (croak): Put it here, so the API can be checked when
1966 'croak' is called from dissociate_if_controlling_tty.
1967
1717ede2
PE
1968 * minibuf.c: Make symbols static if they're not exported.
1969 (minibuf_save_list, choose_minibuf_frame): Now static.
1970 * lisp.h (choose_minibuf_frame): Remove decl.
1971
fa5fb2bc
PE
1972 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1973
1e3890d1
PE
1974 * lread.c: Make symbols static if they're not exported.
1975 (read_objects, initial_obarray, oblookup_last_bucket_number):
1976 Now static.
1977 (make_symbol): Remove; unused.
1978 * lisp.h (initial_obarray, make_symbol): Remove decls.
1979
8a1414fa
PE
1980 * keyboard.c: Make symbols static if they're not exported.
1981 (single_kboard, recent_keys_index, total_keys, recent_keys):
1982 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1983 (this_single_command_key_start, echoing, last_auto_save):
1984 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1985 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1986 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1987 (Vlispy_mouse_stem, double_click_count):
1988 Now static.
1989 (force_auto_save_soon): Define only if SIGDANGER.
1990 (ignore_mouse_drag_p): Now static if
1991 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1992 (print_help): Remove; unused.
1993 (stop_character, last_timer_event): Mark as externally visible.
1994 * keyboard.h (ignore_mouse_drag_p): Declare only if
1995 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1996 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1997 * lisp.h (echoing): Remove decl.
1998 (force_auto_save_soon): Declare only if SIGDANGER.
1999 * xdisp.c (redisplay_window): Simplify code, to make it more
2000 obvious that ignore_mouse_drag_p is not accessed if !defined
2001 USE_GTK && !defined HAVE_NS.
2002
93ea6e8f
PE
2003 * intervals.c: Make symbols static if they're not exported.
2004 (merge_properties_sticky, merge_interval_right, delete_interval):
2005 Now static.
2006 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2007
77382fcc
PE
2008 * insdel.c: Make symbols static if they're not exported.
2009 However, leave prepare_to_modify_buffer alone. It's never
2010 called from outside this function, but that appears to be a bug.
2011 (combine_after_change_list, combine_after_change_buffer):
4889fc82 2012 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
2013 (adjust_after_replace_noundo): Remove; unused.
2014 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 2015 (signal_before_change): Remove decls.
77382fcc 2016
9306c32e
PE
2017 * indent.c (val_compute_motion, val_vmotion): Now static.
2018
cd44d2eb
PE
2019 * image.c: Make symbols static if they're not exported.
2020 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2021 if USE_GTK.
2022 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2023 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2024
ad9a7a06
PE
2025 * fringe.c (standard_bitmaps): Now static.
2026 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2027
81626931
PE
2028 * frame.c: Make symbols static if they're not exported.
2029 (x_report_frame_params, make_terminal_frame): Now static.
2030 (get_frame_param): Now static, unless HAVE_NS.
2031 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2032 (x_get_resource_string): Remove; not used.
2033 * frame.h (make_terminal_frame, x_report_frame_params):
2034 (x_get_resource_string); Remove decls.
2035 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2036 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2037
239f9db9
PE
2038 * font.c, fontset.c: Make symbols static if they're not exported.
2039 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2040 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2041 * font.c (font_close_object): Now static.
2042 * font.h (font_close_object): Remove.
2043 * fontset.c (FONTSET_OBJLIST): Remove.
2044 (free_realized_fontset) #if-0 the body, which does nothing.
2045 (face_suitable_for_char_p): #if-0, as it's never called.
2046 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
2047 * xfaces.c (face_at_string_position):
2048 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
2049 since 0 is always ASCII.
2050
dfcf3579
PE
2051 * fns.c (weak_hash_tables): Now static.
2052
5045092b
PE
2053 * fileio.c: Make symbols static if they're not exported.
2054 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2055 (Vwrite_region_annotation_buffers): Now static.
2056
57a96f5c
PE
2057 * eval.c: Make symbols static if they're not exported.
2058 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2059 * lisp.h (backtrace_list): Remove decl.
2060
35f08c38
PE
2061 * emacs.c: Make symbols static if they're not exported.
2062 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2063 (fatal_error_code, fatal_error_signal_hook, standard_args):
2064 Now static.
2065 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2066 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2067 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2068 * lisp.h (fatal_error_signal_hook): Remove decl.
2069 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2070
f44bd759
PE
2071 * editfns.c: Move a (normally-unused) function to its only use.
2072 * editfns.c, lisp.h (get_operating_system_release): Remove.
2073 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2074 worth the hassle of breaking this out.
2075
b532497d
PE
2076 * xterm.c: Make symbols static if they're not exported.
2077 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2078 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2079 (x_destroy_window, x_delete_display):
2080 Now static.
2081 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2082 (x_mouse_leave): Remove; unused.
2083 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2084 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2085 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2086 Remove decls.
2087 (x_mouse_leave): Declare only if WINDOWSNT.
2088 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2089 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2090 USE_X_TOOLKIT.
2091
1675728f
PE
2092 * ftxfont.c: Make symbols static if they're not exported.
2093 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2094 HAVE_FREETYPE.
2095 * font.h (ftxfont_driver): Likewise.
2096
e4cebfca
PE
2097 * xfns.c: Make symbols static if they're not exported.
2098 (x_last_font_name, x_display_info_for_name):
2099 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2100 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2101 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2102 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2103 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2104 (last_show_tip_args): Now static.
2105 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2106 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2107 (x_screen_planes): Remove; unused.
2108 * dispextern.h (x_screen_planes): Remove decl.
2109
5bf46f05
PE
2110 * dispnew.c: Make symbols static if they're not exported.
2111 * dispextern.h (redraw_garbaged_frames, scrolling):
2112 (increment_row_positions): Remove.
2113 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2114 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2115 Now static.
2116 (redraw_garbaged_frames): Remove; unused.
2117
435f4c28
PE
2118 * xfaces.c: Make symbols static if they're not exported.
2119 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2120 Remove decls.
2121 * xterm.h (defined_color): Remove decls.
2122 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2123 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2124 (menu_face_changed_default, defined_color, free_realized_face):
2125 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2126 (ascii_face_of_lisp_face): Remove; unused.
2127
8524aef3
PE
2128 * xdisp.c: Make symbols static if they're not exported.
2129 * dispextern.h (scratch_glyph_row, window_box_edges):
2130 (glyph_to_pixel_coords, set_cursor_from_row):
2131 (get_next_display_element, set_iterator_to_next):
2132 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2133 (show_mouse_face): Remove decls
2134 * frame.h (message_buf_print): Likewise.
2135 * lisp.h (pop_message, set_message, check_point_in_composition):
2136 Likewise.
2137 * xterm.h (set_vertical_scroll_bar): Likewise.
2138 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2139 (message_buf_print, scratch_glyph_row, displayed_buffer):
2140 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2141 (get_next_display_element, show_mouse_face, window_box_edges):
2142 (frame_to_window_pixel_xy, check_point_in_composition):
2143 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2144 (glyph_to_pixel_coords): Remove; unused.
2145
16390cd2
PE
2146 * dired.c (file_name_completion): Now static.
2147
2148 * dbusbind.c (xd_in_read_queued_messages): Now static.
2149
a25f4dfa
PE
2150 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2151 * data.c (circular_list_error): Remove.
2152
14a9c8df
PE
2153 * commands.h (last_point_position, last_point_position_buffer):
2154 (last_point_position_window): Remove decls.
2155 * keyboard.c: Make these variables static.
2156
04f2d78b
CB
2157 * coding.h (coding, code_convert_region, encode_coding_gap):
2158 Remove decls.
74ab6df5
PE
2159 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2160 (iso_code_class, detect_coding, code_convert_region): Now static.
2161 (encode_coding_gap): Remove; unused.
2162
38dfbee1
PE
2163 * chartab.c (chartab_chars, chartab_bits): Now static.
2164
a2cb4e63
PE
2165 * charset.h (charset_iso_8859_1): Remove decl.
2166 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2167 Now static.
2168
127198fd
PE
2169 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2170 * ccl.c (Vccl_program_table): Now static.
2171 (check_ccl_update): Remove; unused.
2172
d85b608f
PE
2173 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2174 * category.h: ... from here.
2175 * category.c (check_category_table, set_category_set): Now static.
2176
31cd66f3
PE
2177 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2178 * lisp.h: Remove these decls.
2179
c358e587
PE
2180 * buffer.c (buffer_count): Remove unused var.
2181
e78aecca
PE
2182 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2183 so that it's not optimized away.
2184 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2185 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2186 exported only to the debugger.
2187
e192d7d3 2188 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 2189 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 2190
92470028
PE
2191 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2192 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2193 was inaccessible from Lisp.
2194 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2195 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2196
244ed907
PE
2197 alloc.c: Import and export fewer symbols, and remove unused items.
2198 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2199 is defined.
2200 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2201 it's not optimized away by whole-program optimization.
2202 (message_enable_multibyte, free_misc): Remove.
2203 (catchlist, handlerlist, mark_backtrace):
2204 Declare only if BYTE_MARK_STACK.
2205 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2206 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2207 (message_enable_multibyte): Remove decl.
2208 (free_misc, interval_free_list, float_block, float_block_index):
2209 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2210 (cons_free_list, last_marked_index):
2211 Now static.
2212 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2213 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2214 (mark_backtrace): Define only if BYTE_MARK_STACK.
2215 * xdisp.c (message_enable_multibyte): Now static.
2216
61c2b50e 2217 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
2218 This makes it easier for human readers (and static analyzers)
2219 to see whether these variables are used from other modules.
2220 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2221 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2222 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2223 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2224 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2225 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2226 * xmenu.c, xselect.c:
2227 Declare Q* vars static if they are not used in other modules.
2228 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2229 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2230 Remove decls of unexported vars.
2231 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2232
95c82688
PE
2233 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2234
16a97296
PE
2235 Make Emacs functions such as Fatom 'static' by default.
2236 This makes it easier for human readers (and static analyzers)
2237 to see whether these functions can be called from other modules.
2238 DEFUN now defines a static function. To make the function external
2239 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
2240 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2241 (Finit_image_library):
16a97296
PE
2242 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2243 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2244 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2245 Remove decls, since these functions are now static.
2246 (Funintern, Fget_internal_run_time): New decls, since these functions
2247 were already external.
95c82688 2248
16a97296
PE
2249 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2250 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2251 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2252 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2253 * keyboard.c, keymap.c, lread.c:
2254 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2255 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2256 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2257 Mark functions with DEFUE instead of DEFUN,
2258 if they are used in other modules.
2259 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2260 decls for now-static functions.
2261 * buffer.h (Fdelete_overlay): Remove decl.
2262 * callproc.c (Fgetenv_internal): Mark as internal.
2263 * composite.c (Fremove_list_of_text_properties): Remove decl.
2264 (Fcomposition_get_gstring): New forward static decl.
2265 * composite.h (Fcomposite_get_gstring): Remove decl.
2266 * dired.c (Ffile_attributes): New forward static decl.
2267 * doc.c (Fdocumntation_property): New forward static decl.
2268 * eval.c (Ffetch_bytecode): New forward static decl.
2269 (Funintern): Remove extern decl; now in .h file where it belongs.
2270 * fileio.c (Fmake_symbolic_link): New forward static decl.
2271 * image.c (Finit_image_library): New forward static decl.
2272 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2273 * intervals.h (Fprevious_property_change):
2274 (Fremove_list_of_text_properties): Remove decls.
2275 * keyboard.c (Fthis_command_keys): Remove decl.
2276 (Fcommand_execute): New forward static decl.
2277 * keymap.c (Flookup_key): New forward static decl.
2278 (Fcopy_keymap): Now static.
2279 * keymap.h (Flookup_key): Remove decl.
2280 * process.c (Fget_process): New forward static decl.
2281 (Fprocess_datagram_address): Mark as internal.
2282 * syntax.c (Fsyntax_table_p): New forward static decl.
2283 (skip_chars): Remove duplicate decl.
2284 * textprop.c (Fprevious_property_change): New forward static decl.
2285 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2286 Now internal.
2287 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2288 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2289
785bbd42
PE
2290 * editfns.c (Fformat): Remove unreachable code.
2291
8b913b57
AS
22922011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2293
2294 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2295 change. (Bug#8496)
2296
a6744a35
EZ
22972011-04-13 Eli Zaretskii <eliz@gnu.org>
2298
2299 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2300 when at ZV. (Bug#8487)
2301
e7974947
AS
23022011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2303
baad03f0
AS
2304 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2305 (Bug#8437)
2306 * keyboard.c (parse_tool_bar_item): Likewise.
2307 * sound.c (sound_cleanup, alsa_close): Likewise.
2308 * termcap.c (tgetent): Likewise.
2309 * xfns.c (x_default_font_parameter): Likewise.
2310 * xsettings.c (read_and_apply_settings): Likewise.
2311
e7974947
AS
2312 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2313 (overrun_check_free): Protoize.
2314
28272684
PE
23152011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2316
2317 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2318 since callers should never pass a negative size.
2319 Change the signature to match that of plain 'read' and 'write'; see
2320 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2321 * lisp.h: Update prototypes of emacs_write and emacs_read.
2322
11997c76
EZ
23232011-04-11 Eli Zaretskii <eliz@gnu.org>
2324
2325 * xdisp.c (redisplay_window): Don't try to determine the character
2326 position of the scroll margin if the window start point w->startp
e896f03c 2327 is outside the buffer's accessible region. (Bug#8468)
11997c76 2328
8a2cbd72
EZ
23292011-04-10 Eli Zaretskii <eliz@gnu.org>
2330
2331 Fix write-region and its subroutines for buffers > 2GB.
2332 * fileio.c (a_write, e_write): Modify declaration of arguments and
2333 local variables to support buffers larger than 2GB.
2334 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2335
2336 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2337 argument, local variables, and return value.
2338
2339 * lisp.h: Update prototypes of emacs_write and emacs_read.
2340
2341 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2342
4073e537 23432011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 2344
1ebfdcb6
PE
2345 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2346
b2ded58d
PE
2347 Fix more problems found by GCC 4.6.0's static checks.
2348
7d66342c
PE
2349 * xdisp.c (vmessage): Use a better test for character truncation.
2350
bbf47d44
PE
2351 * charset.c (load_charset_map): <, not <=, for optimization,
2352 and to avoid potential problems with integer overflow.
9248994d 2353 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 2354 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 2355 * editfns.c (Fformat): Likewise.
1e69125e 2356 * syntax.c (skip_chars): Likewise.
3befa583 2357
e3019616
PE
2358 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2359 This also lets GCC 4.6.0 generate slightly better loop code.
2360
becfa255
PE
2361 * callint.c (Fcall_interactively): <, not <=, for optimization.
2362 (Fcall_interactively): Count the number of arguments produced,
2363 not the number of arguments given. This is simpler and lets GCC
2364 4.6.0 generate slightly better code.
2365
dae0cd48
PE
2366 * ftfont.c: Distingish more carefully between FcChar8 and char.
2367 The previous code passed unsigned char * to a functions like
2368 strlen and xstrcasecmp that expect char *, which does not
2369 conform to the C standard.
2370 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2371 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2372 char * when the C standard requires it.
2373
76032d70
PE
2374 * keyboard.c (read_char): Remove unused var.
2375
eb3f1cc8
PE
2376 * eval.c: Port to Windows vsnprintf (Bug#8435).
2377 Include <limits.h>.
2378 (SIZE_MAX): Define if the headers do not.
2379 (verror): Do not give up if vsnprintf returns a negative count.
2380 Instead, grow the buffer. This ports to Windows vsnprintf, which
2381 does not conform to C99. Problem reported by Eli Zaretskii.
2382 Also, simplify the allocation scheme, by avoiding the need for
2383 calling realloc, and removing the ALLOCATED variable.
2384
70476b54
PE
2385 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2386
12020a9e
PE
2387 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2388 But keep the doprint source code for now, as we might revamp it
2389 and use it again (Bug#8435).
ea6c7ae6
PE
2390 * lisp.h (doprnt): Remove.
2391 * Makefile.in (base_obj): Remove doprnt.o.
2392 * deps.mk (doprnt.o): Remove.
2393
5fdb398c
PE
2394 error: Print 32- and 64-bit integers portably (Bug#8435).
2395 Without this change, on typical 64-bit hosts error ("...%d...", N)
2396 was used to print both 32- and 64-bit integers N, which relied on
2397 undefined behavior.
2398 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
2399 New macro.
2400 * lisp.h (error, verror): Mark as printf-like functions.
2401 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
2402 Report overflow in size calculations when allocating printf buffer.
2403 Do not truncate output string at its first null byte.
2404 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
2405 Truncate the output at a character boundary, since vsnprintf does not
2406 do that.
2407 * charset.c (check_iso_charset_parameter): Convert internal
2408 character to string before calling 'error', since %c now has the
2409 printf meaning.
2410 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
2411 overflow when computing char to be passed to 'error'. Do not
2412 pass Lisp_Object to 'error'; pass the integer instead.
2413 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
2414 formatted with plain %d.
2415
b189fa66
PE
2416 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
2417
bff87ef0
PE
2418 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
2419
7e2cac20
PE
2420 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
2421
ce4d90b5
PE
2422 * xterm.c (x_catch_errors): Remove duplicate declaration.
2423
266c9547
PE
2424 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
2425
79c49ad2
PE
2426 * xdisp.c, lisp.h (message_nolog): Remove; unused.
2427
368f4090
JM
24282011-04-10 Jim Meyering <meyering@redhat.com>
2429
2430 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
2431 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
2432 return ssize_t not "int", and use size_t as the buffer length.
2433 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
2434 * gnutls.h: Update declarations.
2435 * process.c (read_process_output): Use ssize_t, to match.
2436 (send_process): Likewise.
2437
a32d4040
CY
24382011-04-09 Chong Yidong <cyd@stupidchicken.com>
2439
2440 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
2441
8546720e 24422011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 2443
04f2d78b
CB
2444 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
2445 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 2446
8546720e
GM
2447 * xterm.c (handle_one_xevent):
2448 * xmenu.c (create_and_show_popup_menu):
2449 * xselect.c (x_decline_selection_request)
2450 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 2451
0a2f5c1a 24522011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
2453
2454 Fix some uses of `int' instead of EMACS_INT.
2455 * search.c (string_match_1, fast_string_match)
2456 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2457 (scan_buffer, find_next_newline_no_quit)
2458 (find_before_next_newline, search_command, Freplace_match)
2459 (Fmatch_data): Make some `int' variables be EMACS_INT.
2460
2461 * xdisp.c (display_count_lines): 3rd argument and return value now
2462 EMACS_INT. All callers changed.
2463 (pint2hrstr): Last argument is now EMACS_INT.
2464
2465 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2466 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2467 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2468 (decode_coding_utf_16, decode_coding_emacs_mule)
2469 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2470 (decode_coding_ccl, decode_coding_charset)
2471 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2472 (decode_coding_iso_2022, decode_coding_emacs_mule)
2473 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2474 <char_offset, last_offset>: Declare EMACS_INT.
2475 (encode_coding_utf_8, encode_coding_utf_16)
2476 (encode_coding_emacs_mule, encode_invocation_designation)
2477 (encode_designation_at_bol, encode_coding_iso_2022)
2478 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2479 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2480 Declare EMACS_INT.
2481 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2482 (encode_invocation_designation): Last argument P_NCHARS is now
2483 EMACS_INT.
2484 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2485 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2486
2487 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2488 All users changed.
2489
2490 * ccl.c (Fccl_execute_on_string): Declare some variables
2491 EMACS_INT.
2492
8546720e 24932011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
2494
2495 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2496
4e19a977
CS
24972011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2498
2499 * process.c (Fformat_network_address): Doc fix.
2500
87302331
R
25012011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2502
2503 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
2504
cbb59342
CY
25052011-04-08 Chong Yidong <cyd@stupidchicken.com>
2506
2507 * keyboard.c (read_char): Call Lisp function help-form-show,
2508 instead of using internal_with_output_to_temp_buffer.
2509 (Qhelp_form_show): New var.
e0d38eeb 2510 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
2511
2512 * print.c (internal_with_output_to_temp_buffer): Function deleted.
2513
2514 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
2515
e67a13ab
CY
25162011-04-06 Chong Yidong <cyd@stupidchicken.com>
2517
04f2d78b
CB
2518 * process.c (Flist_processes): Remove to Lisp.
2519 (list_processes_1): Delete.
e67a13ab 2520
973f782d
EZ
25212011-04-06 Eli Zaretskii <eliz@gnu.org>
2522
7c106b1e
EZ
2523 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
2524
973f782d
EZ
2525 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
2526
41cf7d1a 25272011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 2528
ca23cc88
PE
2529 Fix more problems found by GCC 4.6.0's static checks.
2530
f390e2d5
PE
2531 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
2532
42eea0d0
PE
2533 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
2534
b69769da 2535 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 2536
f9541e84
PE
2537 * xdisp.c (vmessage): Mark as a printf-like function.
2538
13841b55
PE
2539 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
2540
c136c10f
PE
2541 * sound.c (sound_warning): Don't crash if arg contains a printf format.
2542
5e2d4a30
PE
2543 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
2544 printf-like functions.
2545 (tiff_load): Add casts to remove these marks before passing them
2546 to system-supplied API.
2547
583f48b9
PE
2548 * eval.c (Fsignal): Remove excess argument to 'fatal'.
2549
b25d760e
PE
2550 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
2551 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
2552 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
2553 directly, rather than having caller test rule sign. This avoids
2554 some unnecessary tests.
2555 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
2556 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
2557 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 2558
bc7b6697 2559 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 2560 (xfont_open): Avoid unnecessary tests.
bc7b6697 2561
27ccc379
PE
2562 * composite.c (composition_gstring_put_cache): Use unsigned integer.
2563
dcd5c89a
PE
2564 * composite.h, composite.c (composition_gstring_put_cache):
2565 Use EMACS_INT, not int, for length.
2566
b13a45c6
PE
2567 * composite.h (COMPOSITION_DECODE_REFS): New macro,
2568 breaking out part of COMPOSITION_DECODE_RULE.
2569 (COMPOSITION_DECODE_RULE): Use it.
2570 * composite.c (get_composition_id): Remove unused local vars,
2571 by using the new macro.
2572
1e792e4d
PE
2573 * textprop.c (set_text_properties_1): Change while to do-while,
2574 since the condition is always true at first.
2575
dc6c6455 2576 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
2577 (interval_deletion_adjustment): Return unsigned value.
2578 All uses changed.
dc6c6455 2579
aba7731a
PE
2580 * process.c (list_processes_1, create_pty, read_process_output):
2581 (exec_sentinel): Remove vars that were set but not used.
afd4052b 2582 (create_pty): Remove unnecessary "volatile"s.
bc57d757 2583 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 2584 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 2585 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 2586
fdfc4bf3
PE
2587 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
2588
fca8fe46 2589 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 2590 (update_syntax_table): Use unsigned instead of int.
fca8fe46 2591
06a0259a 2592 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 2593 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 2594 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 2595
e7b9e80f
PE
2596 * print.c (print_error_message): Avoid int overflow.
2597
56201685
PE
2598 * font.c (font_list_entities): Redo for clarity,
2599 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
2600
78834453 2601 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 2602 (font_score): Avoid potential overflow in diff calculation.
78834453 2603
0bc0b309 2604 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 2605 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 2606
e610eaca
PE
2607 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2608
b895abce
PE
2609 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2610 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2611 can always succeed if overflow has undefined behavior.
2612
1f1d9321 2613 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 2614 (wordify): Omit three unnecessary tests.
1f1d9321 2615
c59478bc
PE
2616 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2617 All callers changed. This avoids the need for an unused var.
2618
79b73827
PE
2619 * casefiddle.c (casify_region): Remove var that is set but not used.
2620
a4db5dfe
PE
2621 * dired.c (file_name_completion): Remove var that is set but not used.
2622
43aae36e
PE
2623 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2624
2a47c44d 2625 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 2626 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 2627
a37c69bf
PE
2628 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2629 Check for integer overflow on size calculations.
2630
328ab8e7
PE
2631 * buffer.c (Fprevious_overlay_change): Remove var that is set
2632 but not used.
2633
e5a2a5cb
PE
2634 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2635 Remove vars that are set but not used.
8d84a6eb 2636 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 2637 (timer_check_2): Mark vars as initialized.
e5a2a5cb 2638
a60e5f68
PE
2639 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2640
f661cb61 2641 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 2642 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 2643
f0397f5a
PE
2644 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2645 that are set but not used.
2646
8664db06 2647 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 2648 if XCreateBitmapFromData fails (Bug#8410).
8664db06 2649
6abdaa4a
PE
2650 * xselect.c (x_get_local_selection, x_handle_property_notify):
2651 Remove vars that are set but not used.
2652
0ce7538d 2653 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 2654 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 2655
9ae848fc
PE
2656 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2657 Remove var that is set but not used.
0b918413
PE
2658 (scroll_bar_windows_size): Now size_t, not int.
2659 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2660 Check for overflow.
9ae848fc 2661
a5a62657
PE
2662 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2663 (map_tty_color) [!defined MSDOS]: Likewise.
2664
5c5cdd39
PE
2665 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2666
66ebf983
PE
2667 * coding.c: Remove vars that are set but not used.
2668 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2669 All callers changed.
2670 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2671 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2672 (decode_coding_charset): Remove vars that are set but not used.
2673
1be4d761
PE
2674 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2675 that is set but not used.
2676
47553fa8
PE
2677 * print.c (print_object): Remove var that is set but not used.
2678
1f7196bf 2679 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
2680 The gnulib version avoids calling malloc in the usual case,
2681 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2682 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2683 * filelock.c (current_lock_owner): Likewise.
2684 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2685 * sysdep.c: Include allocator.h, careadlinkat.h.
2686 (emacs_no_realloc_allocator): New static constant.
2687 (emacs_readlink): New function.
fdb61804
PE
2688 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2689 ../lib/careadlinkat.h.
d1fdcab7 2690
f84c17c7
SM
26912011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2692
2693 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2694 first non-nil return value).
2695
ef3862ad
JD
26962011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2697
2698 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2699 if not defined (Bug#8403).
2700
376a7006
JB
27012011-04-02 Juanma Barranquero <lekktu@gmail.com>
2702
2703 * xdisp.c (display_count_lines): Remove parameter `start',
2704 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2705 (get_char_face_and_encoding): Remove parameter `multibyte_p',
2706 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2707 (fill_stretch_glyph_string): Remove parameters `row' and `area',
2708 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
2709 and thereabouts. All callers changed.
2710 (get_per_char_metric): Remove parameter `f', unused since
2711 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2712
6ca3801d
JM
27132011-04-02 Jim Meyering <meyering@redhat.com>
2714
2715 do not dereference NULL upon failed strdup
2716 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2717 (ns_get_family): Likewise.
2718
d8e2b5ba
JB
27192011-04-02 Juanma Barranquero <lekktu@gmail.com>
2720
2721 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2722
8c74fcbd
JD
27232011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2724
2725 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
2726 later (Bug#8403).
2727
7200d79c
SM
27282011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2729
03408648 2730 Add lexical binding.
7200d79c 2731
03408648
SM
2732 * window.c (Ftemp_output_buffer_show): New fun.
2733 (Fsave_window_excursion):
2734 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2735
2736 * lread.c (lisp_file_lexically_bound_p): New function.
2737 (Fload): Bind Qlexical_binding.
2738 (readevalloop): Remove `evalfun' arg.
2739 Bind Qinternal_interpreter_environment.
2740 (Feval_buffer): Bind Qlexical_binding.
2741 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2742 Mark as dynamic.
2743 (syms_of_lread): Declare `lexical-binding'.
2744
2745 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2746
2747 * keyboard.c (eval_dyn): New fun.
2748 (menu_item_eval_property): Use it.
ca105506
SM
2749
2750 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 2751
03408648
SM
2752 * fns.c (concat, mapcar1): Accept byte-code-functions.
2753
2754 * eval.c (Fsetq): Handle lexical vars.
2755 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2756 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2757 (FletX, Flet): Obey lexical binding.
2758 (Fcommandp): Handle closures.
2759 (Feval): New `lexical' arg.
2760 (eval_sub): New function extracted from Feval. Use it almost
2761 everywhere where Feval was used. Look up vars in lexical env.
2762 Handle closures.
2763 (Ffunctionp): Move from subr.el.
2764 (Ffuncall): Handle closures.
2765 (apply_lambda): Remove `eval_flags'.
2766 (funcall_lambda): Handle closures and new byte-code-functions.
2767 (Fspecial_variable_p): New function.
2768 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
2769 but without exporting it to Lisp.
23aba0ea 2770
23aba0ea 2771 * doc.c (Fdocumentation, store_function_docstring):
03408648 2772 * data.c (Finteractive_form): Handle closures.
23aba0ea 2773
03408648
SM
2774 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
2775 interactive spec.
ba83908c 2776
04f2d78b
CB
2777 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
2778 New byte-codes.
03408648
SM
2779 (exec_byte_code): New function extracted from Fbyte_code to handle new
2780 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 2781
03408648 2782 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 2783
03408648 2784 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 2785
e2abce01
JB
27862011-03-31 Juanma Barranquero <lekktu@gmail.com>
2787
2788 * xdisp.c (redisplay_internal): Fix prototype.
2789
63696a73 27902011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 2791
63696a73 2792 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
2793 (try_scrolling): Use it when setting scroll_limit.
2794 Limit scrolling to 100 screen lines.
63696a73
EZ
2795 (redisplay_window): Even when falling back on "recentering",
2796 position point in the window according to scroll-conservatively,
2797 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2798
2799 (try_scrolling): When point is above the window, allow searching
2800 as far as scroll_max, or one screenful, to compute vertical
2801 distance from PT to the scroll margin position. This prevents
2802 try_scrolling from unnecessarily failing when
2803 scroll-conservatively is set to a value slightly larger than the
2804 window height. Clean up the case of PT below the margin at bottom
2805 of window: scroll_max can no longer be INT_MAX. When aggressive
2806 scrolling is in use, don't let point enter the opposite scroll
2807 margin as result of the scroll.
2808 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
2809 threshold of 100 lines for never-recentering scrolling.
2810
e4cc2dfc
JB
28112011-03-31 Juanma Barranquero <lekktu@gmail.com>
2812
2813 * dispextern.h (move_it_by_lines):
2814 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2815 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2816 (message_log_check_duplicate): Remove parameters `prev_bol' and
2817 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2818 (redisplay_internal): Remove parameter `preserve_echo_area',
2819 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2820
2821 * indent.c (Fvertical_motion):
2822 * window.c (window_scroll_pixel_based, Frecenter):
2823 Don't pass `need_y_p' to `move_it_by_lines'.
2824
1c470562
SM
28252011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2826
44f230aa
SM
2827 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2828 steal a few bits to be more compact.
2829 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2830 Remove unneeded casts.
2831
1c470562
SM
2832 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2833
888adce9
ZK
28342011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2835
2836 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2837 binding" message (bug#7967).
2838
f838ed7b
PE
28392011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2840
77861b95
PE
2841 Fix more problems found by GCC 4.6.0's static checks.
2842
de6dbc14
PE
2843 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2844 Remove unused local var.
2845
f838ed7b
PE
2846 * editfns.c (Fmessage_box): Remove unused local var.
2847
792c7b2b
PE
2848 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2849 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2850 Omit unused local vars.
c499e557 2851 * window.c (shrink_windows): Omit unused local var.
b01a1c29 2852 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
2853 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2854 Omit unused local var.
2855
ba0165e1
PE
2856 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2857 Don't assume string length fits in int.
32ad8845 2858 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 2859 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 2860
3c59b4c9
PE
2861 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2862 instead of alloca (Bug#8344).
2863
a3eed478 2864 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 2865 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 2866
eb4d412d
PE
2867 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2868
1658b401
PE
2869 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2870 concerns.
2871
2872 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2873
2874 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 2875
9a2c6e05
PE
2876 * keyboard.c (syms_of_keyboard): Use the same style as later
2877 in this function when indexing through an array. This also
2878 works around GCC bug 48267.
2879
03d0a109
PE
2880 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2881
44f730c8
PE
2882 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2883
fe75f926
PE
2884 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2885 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2886
ffa8c828
PE
2887 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2888 This avoids undefined behavior on integer overflow, and is a bit
2889 more convenient anyway since it is compared to a size_t variable.
2890
c5101a77
PE
2891 Variadic C functions now count arguments with size_t, not int.
2892 This avoids an unnecessary limitation on 64-bit machines, which
2893 caused (substring ...) to crash on large vectors (Bug#8344).
2894 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2895 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 2896 All variadic functions and their callers changed accordingly.
c5101a77
PE
2897 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2898 * data.c (arith_driver, float_arith_driver): Likewise.
2899 * editfns.c (general_insert_function): Likewise.
2900 * eval.c (struct backtrace.nargs, interactive_p)
2901 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2902 (funcall_lambda, mark_backtrace): Likewise.
2903 * fns.c (concat): Likewise.
2904 * frame.c (x_set_frame_parameters): Likewise.
2905 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2906 0 if not found, not -1. All callers changed.
2907
dd3f25f7
PE
2908 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2909 (stack_copy_size): Now size_t, not int.
2910 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2911
461c2ab9
JB
29122011-03-28 Juanma Barranquero <lekktu@gmail.com>
2913
2914 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2915 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2916 All callers changed.
2917
2918 * lisp.h (multibyte_char_to_unibyte):
2919 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2920 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2921 * character.h (CHAR_TO_BYTE8):
2922 * cmds.c (internal_self_insert):
2923 * editfns.c (general_insert_function):
2924 * keymap.c (push_key_description):
2925 * search.c (Freplace_match):
2926 * xdisp.c (message_dolog, set_message_1): All callers changed.
2927
f6d62986
SM
29282011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2929
2930 * keyboard.c (safe_run_hook_funcall): New function.
2931 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
2932 don't set the hook to nil, but remove the offending function instead.
2933 (Qcommand_hook_internal): Remove, unused.
2934 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
2935 Vcommand_hook_internal.
2936
2937 * eval.c (enum run_hooks_condition): Remove.
2938 (funcall_nil, funcall_not): New functions.
2939 (run_hook_with_args): Call each function through a `funcall' argument.
2940 Remove `cond' argument, now redundant.
2941 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
2942 (Frun_hook_with_args_until_failure): Adjust accordingly.
2943 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
2944
1db5b1ad
JB
29452011-03-28 Juanma Barranquero <lekktu@gmail.com>
2946
2947 * dispextern.h (string_buffer_position): Remove declaration.
2948
2949 * print.c (strout): Remove parameter `multibyte', unused since
2950 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2951
2952 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2953 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2954 All callers changed.
2955
2956 * w32.c (_wsa_errlist): Use braces for struct initializers.
2957
2958 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2959 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2960 All callers changed.
2961 (string_buffer_position): Likewise. Also, make static (it's never
2962 used outside xdisp.c).
2963 (cursor_row_p): Remove parameter `w', unused since
2964 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2965 (decode_mode_spec): Remove parameter `precision', introduced during
2966 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2967 All callers changed.
2968
5ffb62aa
JD
29692011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2970
2971 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2972
461c2ab9 29732011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
2974
2975 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2976 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2977 (ns_update_auto_hide_menu_bar): New functions.
2978 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2979 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2980 ns_constrain_all_frames.
2981 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2982 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2983
5c380ffb
JD
29842011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2985
2986 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2987
9af30bdf
GM
29882011-03-27 Glenn Morris <rgm@gnu.org>
2989
2990 * syssignal.h: Replace RETSIGTYPE with void.
2991 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2992 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2993 Replace SIGTYPE with void everywhere.
2994 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2995 * s/template.h (SIGTYPE): Remove commented out definition.
2996
e2abce01
JB
29972011-03-26 Eli Zaretskii <eliz@gnu.org>
2998
2999 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3000 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3001
f868cd8a
JB
30022011-03-26 Juanma Barranquero <lekktu@gmail.com>
3003
59eb0929
JB
3004 * w32.c (read_unc_volume): Use parameter `henum', instead of
3005 global variable `wget_enum_handle'.
3006
3007 * keymap.c (describe_vector): Remove parameters `indices' and
3008 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3009 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3010
f868cd8a
JB
3011 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3012
3013 * keyboard.c (timer_check): Remove parameter `do_it_now',
3014 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3015 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3016 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3017
3018 * keyboard.c (read_char):
3019 * w32menu.c (w32_menu_display_help):
3020 * xmenu.c (show_help_event, menu_help_callback):
3021 Adjust calls to `show_help_echo'.
3022
3023 * gtkutil.c (xg_maybe_add_timer):
3024 * keyboard.c (readable_events):
3025 * process.c (wait_reading_process_output):
3026 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3027
3028 * insdel.c (adjust_markers_gap_motion):
3029 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3030 (gap_left, gap_right): Don't call it.
3031
2ecf6fdb
CY
30322011-03-25 Chong Yidong <cyd@stupidchicken.com>
3033
3034 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3035 incurred during fontification.
3036
6b1f9ba4
JB
30372011-03-25 Juanma Barranquero <lekktu@gmail.com>
3038
3039 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3040 (DEFVAR_PER_BUFFER): Don't pass it.
3041
3042 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3043 (scrolling_window): Don't pass it.
3044
0f4a96b5
JB
30452011-03-25 Juanma Barranquero <lekktu@gmail.com>
3046
3047 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3048
3049 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3050 and `suffix'.
3051 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3052 of variables specific to SELinux and computation of `encoded_absname'.
3053
3054 * image.c (XPutPixel): Remove unused variable `height'.
3055
3056 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3057
3058 * unexw32.c (get_section_info): Remove unused variable `section'.
3059
3060 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3061 (system_process_attributes): Remove unused variable `sess'.
3062 (sys_read): Remove unused variable `err'.
3063
3064 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3065 (w32_wnd_proc): Remove unused variable `isdead'.
3066 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3067 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3068 (x_create_tip_frame): Remove unused variable `tem'.
3069
3070 * w32inevt.c (w32_console_read_socket):
3071 Remove unused variable `no_events'.
3072
3073 * w32term.c (x_draw_composite_glyph_string_foreground):
3074 Remove unused variable `width'.
3075
1149507c
JB
30762011-03-24 Juanma Barranquero <lekktu@gmail.com>
3077
3078 * w32term.c (x_set_glyph_string_clipping):
3079 Don't pass uninitialized region to CombineRgn.
3080
9c88f339
JB
30812011-03-23 Juanma Barranquero <lekktu@gmail.com>
3082
3083 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3084 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3085 (Fx_close_connection): Remove unused variable `i'.
3086
3087 * w32font.c (w32font_draw): Return number of glyphs.
3088 (w32font_open_internal): Remove unused variable `i'.
3089 (w32font_driver): Add missing initializer.
3090
3091 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3092 (fill_in_menu): Remove unused variable `items_added'.
3093
3094 * w32term.c (last_mouse_press_frame): Remove static global variable.
3095 (w32_clip_to_row): Remove unused variable `f'.
3096 (x_delete_terminal): Remove unused variable `i'.
3097
3098 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3099 (NOTHING): Remove unused static global variable.
3100 (uniscribe_check_otf): Remove unused variable `table'.
3101 (uniscribe_font_driver): Add missing initializers.
3102
dee091a3
JD
31032011-03-23 Julien Danjou <julien@danjou.info>
3104
3105 * term.c (Fsuspend_tty, Fresume_tty):
3106 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3107 * window.c (temp_output_buffer_show):
3108 * insdel.c (signal_before_change):
3109 * frame.c (Fhandle_switch_frame):
3110 * fileio.c (Fdo_auto_save):
3111 * emacs.c (Fkill_emacs):
3112 * editfns.c (save_excursion_restore):
3113 * cmds.c (internal_self_insert):
3114 * callint.c (Fcall_interactively):
3115 * buffer.c (Fkill_all_local_variables):
3116 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3117 Use Frun_hooks.
0f4a96b5 3118 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
3119 unconditionnaly since it does the check itself.
3120
2c520ab5 31212011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 3122
c9c49752
PE
3123 Fix more problems found by GCC 4.5.2's static checks.
3124
8abc3f12
PE
3125 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3126 the first time through the loop, since we know p0 < p1 then.
3127 This also avoids a gcc -Wstrict-overflow warning.
3128
a2d26660
PE
3129 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3130 leading to a memory leak, possible in functions like
3131 load_charset_map_from_file that can allocate an unbounded number
b12ef411 3132 of objects (Bug#8318).
a2d26660 3133
916c72e9
PE
3134 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3135 that could (at least in theory) be that large.
3136
19ab8a18
PE
3137 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3138 This is less likely to overflow, and avoids undefined behavior if
3139 overflow does occur. All callers changed. Use strtoul to scan
3140 for the unsigned long integer.
b7cbbd6f
PE
3141 (pint2hrstr): Simplify and tune code slightly.
3142 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 3143
f0641eff
PE
3144 * scroll.c (do_scrolling): Work around GCC bug 48228.
3145 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3146
7f650bb9
PE
3147 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3148 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
3149 (validate_x_resource_name): Simplify count usage.
3150 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 3151
37dd57d1
PE
3152 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3153 fail (Bug#8306).
81e56e61 3154
699979fc 3155 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 3156
401bf9b4
PE
3157 * process.c (Fmake_network_process): Use socklen_t, not int,
3158 where POSIX says socklen_t is required in portable programs.
3159 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 3160 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
3161 (Fmake_network_process, server_accept_connection):
3162 (wait_reading_process_output, read_process_output):
3163 Likewise.
3164
b93aacde
PE
3165 * process.c: Rename or move locals to avoid shadowing.
3166 (list_processes_1, Fmake_network_process):
3167 (read_process_output_error_handler, exec_sentinel_error_handler):
3168 Rename or move locals.
4dc343ee 3169 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 3170 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 3171 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 3172 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 3173 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 3174
af8a867c 3175 Make tparam.h and terminfo.c consistent.
44f230aa
SM
3176 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3177 Include tparam.h instead, since it declares them.
af8a867c
PE
3178 * cm.h (PC): Remove extern decl; tparam.h now does this.
3179 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3180 * terminfo.c: Include tparam.h, to check interfaces.
3181 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3182 (tparam): Adjust signature to match interface in tparam.h;
3183 this removes some undefined behavior. Check that outstring and len
3184 are zero, which they always are with Emacs.
3185 * tparam.h (PC, BC, UP): New extern decls.
3186
0248044d 3187 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 3188 (xftfont_open): Rename locals to avoid shadowing.
0248044d 3189
8ff096c1 3190 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
3191 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3192 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 3193 (ftfont_list): Remove unused local.
49eaafba
PE
3194 (get_adstyle_property, ftfont_pattern_entity):
3195 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3196 Rename locals to avoid shadowing.
8ff096c1 3197
e2be39f6
PE
3198 * xfont.c (xfont_list_family): Mark var as initialized.
3199
c9735e30
PE
3200 * xml.c (make_dom): Now static.
3201
8f5201ae
PE
3202 * composite.c (composition_compute_stop_pos): Rename local to
3203 avoid shadowing.
b246f932
PE
3204 (composition_reseat_it): Remove unused locals.
3205 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 3206 (composition_update_it): Mark var as initialized.
11b61122
PE
3207 (find_automatic_composition): Mark vars as initialized,
3208 with a FIXME (Bug#8290).
8f5201ae 3209
760fbc2c
PE
3210 character.h: Rename locals to avoid shadowing.
3211 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3212 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3213 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3214 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3215 to avoid shadowing.
3216
ff08eb85
PE
3217 * textprop.c (property_change_between_p): Remove; unused.
3218
fc7bf025
PE
3219 * intervals.c (interval_start_pos): Now static.
3220
235d7abc
PE
3221 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3222
44f230aa
SM
3223 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3224 Rename locals to avoid shadowing.
3e7d6594 3225
50060332
PE
3226 * sound.c (wav_play, au_play, Fplay_sound_internal):
3227 Fix pointer signedness.
d01f234b 3228 (alsa_choose_format): Remove unused local var.
c83b8872
PE
3229 (wav_play): Initialize a variable to 0, to prevent undefined
3230 behavior (Bug#8278).
50060332 3231
c4fc4e30
PE
3232 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3233
918436ed
PE
3234 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3235
c939f91b
PE
3236 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3237 clobbering (Bug#8298).
b9c7f648
PE
3238 * sysdep.c (sys_subshell): Likewise.
3239 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 3240
6bd8c144
PE
3241 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3242 This should get cleaned up, so that child_setup has the
3243 same signature on all platforms.
3244
7710357c 3245 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 3246 (relocate_fd): Rename locals to avoid shadowing.
7710357c 3247
c59da222
CY
32482011-03-22 Chong Yidong <cyd@stupidchicken.com>
3249
3250 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3251 not to be necessary, and produces flickering.
3252
66b87493
GM
32532011-03-20 Glenn Morris <rgm@gnu.org>
3254
3255 * config.in: Remove file.
3256
45b6f6d5
JB
32572011-03-20 Juanma Barranquero <lekktu@gmail.com>
3258
3259 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3260 are now in src/globals.h.
3261 (syms_of_minibuf): Remove spurious & from previous change.
3262
3ec03f7e
LL
32632011-03-20 Leo <sdl.web@gmail.com>
3264
3265 * minibuf.c (completing-read-function): New variable.
3266 (completing-read-default): Rename from completing-read.
3267 (completing-read): Call completing-read-function.
3268
b14e3e21
CY
32692011-03-19 Juanma Barranquero <lekktu@gmail.com>
3270
3271 * xfaces.c (Fx_load_color_file):
3272 Read color file from absolute filename (bug#8250).
3273
f2b726e6
JB
32742011-03-19 Juanma Barranquero <lekktu@gmail.com>
3275
3276 * makefile.w32-in: Update dependencies.
3277
09f6ff02
EZ
32782011-03-17 Eli Zaretskii <eliz@gnu.org>
3279
3280 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3281
29a6015a
PE
32822011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3283
a3a6c54e
PE
3284 Fix more problems found by GCC 4.5.2's static checks.
3285
b766f867
PE
3286 * process.c (make_serial_process_unwind, send_process_trap):
3287 (sigchld_handler): Now static.
3288
be02381c
PE
3289 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3290 That way, the code declares only the vars that it needs.
3291 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3292 * s/cygwin.h (PTY_ITERATION): Likewise.
3293 * s/darwin.h (PTY_ITERATION): Likewise.
3294 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3295
57048744
PE
3296 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3297 * process.c (allocate_pty): Don't declare stb unless it's needed.
3298
7914961c 3299 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
3300 (CONSTANTLIM): Remove; unused.
3301 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3302 Define only if needed.
7914961c 3303
b3967b18
PE
3304 * unexelf.c (unexec): Name an expression,
3305 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
3306 Use a different way to cause a compilation error if anyone uses
3307 n rather than nn, a way that does not involve shadowing.
73366a00 3308 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 3309
29a6015a
PE
3310 * deps.mk (unexalpha.o): Remove; unused.
3311
43cfc33e 3312 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 3313 * unexec.h: New file.
ce701a33
PE
3314 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3315 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3316 Depend on unexec.h.
3317 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3318 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3319 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 3320 Change as necessary to match prototype in unexec.h.
ce701a33 3321
01f44d5a
PE
3322 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3323 shadowing.
4f63c6bb 3324 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 3325
a6670b0b
PE
3326 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3327 Rename locals to avoid shadowing.
3328
cef2010d 3329 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 3330 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 3331
d4d7173a
PE
3332 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3333
f08b802a
PE
3334 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3335 warning when compiling print.c.
3336
3ddb0639
PE
3337 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3338 instead of using an uninitialized var.
5ad03b97 3339 (font_sort_entities): Mark var as initialized.
3ddb0639 3340
170a2692
PE
3341 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3342
e663c700
PE
3343 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3344 pointers to constants.
89bc529a 3345 (font_parse_fcname): Remove unused vars.
7b81e2d0 3346 (font_delete_unmatched): Now static.
ea838e10 3347 (font_get_spec): Remove; unused.
13a547c6
PE
3348 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3349 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3350 Rename or move locals to avoid shadowing.
e663c700 3351
2a80c887 3352 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 3353 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 3354
1384fa33 3355 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 3356 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 3357
8b2c52e9
PE
3358 * alloc.c (mark_backtrace): Move decl from here ...
3359 * lisp.h: ... to here, so that it can be checked.
3360
475545b5 3361 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 3362 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
3363 (lisp_indirect_variable): Name an expression,
3364 to avoid gcc -Wbad-function-cast warning.
1faed8ae 3365 (Fdefvar): Rename locals to avoid shadowing.
475545b5 3366
b1349114 3367 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 3368 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 3369 Use const pointer when appropriate.
b1349114 3370
a2928364
PE
3371 * lisp.h (get_system_name, get_operating_system_release):
3372 Move decls here, to check interfaces.
3373 * process.c (get_operating_system_release): Move decl to lisp.h.
3374 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
3375 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3376 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3377 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
3378 (Fformat_time_string, Fencode_time, Finsert_char):
3379 (Ftranslate_region_internal, Fformat):
3380 Rename or remove local vars to avoid shadowing.
9710023e 3381 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 3382
a415e694
PE
3383 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3384 avoid shadowing.
3385
8ef4622d
PE
3386 * lisp.h (eassert): Check that the argument compiles, even if
3387 ENABLE_CHECKING is not defined.
3388
946f9a5b
PE
3389 * data.c (Findirect_variable): Name an expression, to avoid
3390 gcc -Wbad-function-cast warning.
112396d6 3391 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 3392 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
3393 (Fmake_variable_buffer_local, Fmake_local_variable):
3394 Mark variables as initialized.
52746918 3395 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 3396
e5aab7e7 3397 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
3398 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
3399 Rename locals to avoid shadowing.
dff45157
PE
3400 (mark_stack): Move local variables into the #ifdef region where
3401 they're used.
7bc26fdb
PE
3402 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
3403 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
3404 needed otherwise.
3405 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
3406 (GC_STRING_CHARS): Remove; not used.
d40d4be1 3407 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 3408
e5aab7e7
PE
3409 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
3410 avoids undefined behavior in theory.
3411
4da60324
PE
3412 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
3413
88043301
PE
3414 Use functions, not macros, for up- and down-casing (Bug#8254).
3415 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3416 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
3417 to use the following functions instead of these macros.
3418 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
3419 EMACS_INT, since callers assume the returned value fits in int.
3420 (upcase1): Likewise, for UPCASE_TABLE.
3421 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 3422 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 3423 the race-condition problem in the old DOWNCASE.
88043301 3424
19ed5445
PE
3425 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
3426 Rename locals to avoid shadowing.
3427 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
3428 (regex_compile, re_search_2, re_match_2_internal):
3429 Remove unused local vars.
952db0d7
PE
3430 (FREE_VAR): Rewrite so as not to use empty "else",
3431 which gcc can warn about.
da053e48 3432 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
3433 (RETALLOC_IF): Define only if needed.
3434 (WORDCHAR_P): Likewise. This one is never needed, but is used
3435 only in a comment talking about a compiler bug, so put inside
3436 the #if 0 of that comment.
3437 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
3438 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
3439 Remove; unused.
19ed5445 3440
1f3561e4 3441 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
3442 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
3443 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 3444
ded6f8f7
PE
3445 * search.c (simple_search): Remove unused var.
3446
dbd37a95
PE
3447 * dired.c (compile_pattern): Move decl from here ...
3448 * lisp.h: ... to here, so that it can be checked.
3449 (struct re_registers): New forward decl.
3450
7e47afad
PE
3451 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3452
85f24f61
PE
3453 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3454 All uses changed.
3455 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3456 Rename locals to avoid shadowing.
5671df8f 3457 (Fvertical_motion): Mark locals as initialized.
85f24f61 3458
181aa2be 3459 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 3460 (casify_region): Mark local as initialized.
181aa2be 3461
930d429c
PE
3462 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3463
7082eac6
PE
3464 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3465 New macros, so that the caller can use some names other than
3466 gcpro1, gcpro2, etc.
3467 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3468 of the new macros.
3469 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3470 argument, for consistency with GCPRO2_VAR, etc: it is now the
3471 prefix of the variable, not the variable itself. All uses
3472 changed.
38b2c076
PE
3473 * dired.c (directory_files_internal, file_name_completion):
3474 Rename locals to avoid shadowing.
3475
15206ed9
PE
3476 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3477 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3478 dired.c's scmp function, had undefined behavior.
3479 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3480 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3481 * buffer.h: ... to here, because these macros use current_buffer,
3482 and the new implementation with inline functions needs to have
3483 current_buffer in scope now, rather than later when the macros
3484 are used.
3485 (downcase, upcase1): New static inline functions.
3486 (DOWNCASE, UPCASE1): Reimplement using these functions.
3487 This avoids undefined behavior in expressions like
3488 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3489 from race conditions in accessing the global variables
3490 case_temp1 and case_temp2.
3491 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3492 * lisp.h (case_temp1, case_temp2): Remove their decls.
3493 * character.h (ASCII_CHAR_P): Move from here ...
3494 * lisp.h: ... to here, so that the inline functions mentioned
3495 above can use them.
3496
4a6bea26
PE
3497 * dired.c (directory_files_internal_unwind): Now static.
3498
f14b7e14
PE
3499 * fileio.c (file_name_as_directory, directory_file_name):
3500 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
3501 Now static.
2893f146
PE
3502 (file_name_as_directory): Use const pointers when appropriate.
3503 (Fexpand_file_name): Likewise. In particular, newdir might
3504 point at constant storage, so make it a const pointer.
fd4ead52 3505 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
3506 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
3507 signedness issues.
f839df0c
PE
3508 (Fset_file_times, Finsert_file_contents, auto_save_error):
3509 Rename locals to avoid shadowing.
f14b7e14 3510
5716756e 3511 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
3512 (Ftry_completion, Fall_completions): Rename or remove locals
3513 to avoid shadowing.
5716756e 3514
b4c3046a
PE
3515 * marker.c (bytepos_to_charpos): Remove; unused.
3516
b45db522
PE
3517 * lisp.h (verify_bytepos, count_markers): New decls,
3518 so that gcc does not warn that these functions aren't declared.
3519
85876d07
PE
3520 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
3521 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 3522 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 3523 (copy_text): Remove unused local var.
85876d07 3524
03d78a21 3525 * filelock.c (within_one_second): Now static.
b3dd38ab 3526 (lock_file_1): Rename local to avoid shadowing.
03d78a21 3527
5df8f01b
PE
3528 * buffer.c (fix_overlays_before): Mark locals as initialized.
3529 (fix_start_end_in_overlays): Likewise. This function should be
3530 simplified by using pointers-to-pointers, but that's a different
3531 matter.
b1d876f1 3532 (switch_to_buffer_1): Now static.
8f54f30a
PE
3533 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
3534 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 3535
a70072c9 3536 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 3537 Fix pointer signedness issue.
edced198
PE
3538 (sys_subshell): Mark local as volatile if checking for lint,
3539 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 3540 (MAXPATHLEN): Define only if needed.
a70072c9 3541
a0977c44
PE
3542 * process.c (serial_open, serial_configure): Move decls from here ...
3543 * systty.h: ... to here, so that they can be checked.
3544
a884fdcc
PE
3545 * fns.c (get_random, seed_random): Move extern decls from here ...
3546 * lisp.h: ... to here, so that they can be checked.
3547
604efe86 3548 * sysdep.c (reset_io): Now static.
b8950c94 3549 (wait_for_termination_signal): Remove; unused.
604efe86 3550
38fc62d9
PE
3551 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
3552 (copy_keymap_item, append_key, push_text_char_description):
3553 Now static.
1004a21a 3554 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 3555 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
3556 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
3557 (describe_map_tree):
3558 Rename locals to avoid shadowing.
38fc62d9 3559
2f2650da
PE
3560 * keyboard.c: Declare functions static if they are not used elsewhere.
3561 (echo_char, echo_dash, cmd_error, top_level_2):
3562 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
3563 (read_char, kbd_buffer_get_event, make_lispy_position):
3564 (make_lispy_event, make_lispy_movement, apply_modifiers):
3565 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
3566 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
3567 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 3568 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 3569 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 3570
a053e86c 3571 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
3572 (mark_kboards): Move decl here ...
3573 * alloc.c (mark_kboards): ... from here.
a053e86c 3574
4752793e
PE
3575 * lisp.h (force_auto_save_soon): New decl.
3576
74f10ca7 3577 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
3578 (DEFINE_DUMMY_FUNCTION): New macro.
3579 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
3580 Use it.
c03cd23f
PE
3581 (main): Add casts to avoid warnings
3582 if GCC considers string literals to be constants.
74f10ca7 3583
022e70d4
PE
3584 * lisp.h (fatal_error_signal): Add decl, since it's exported.
3585
59d6fe83
PE
3586 * dbusbind.c: Pointer signedness fixes.
3587 (xd_signature, xd_append_arg, xd_initialize):
3588 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3589 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3590 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
3591 (Fdbus_register_signal): Use SSDATA when the context wants char *.
3592
78320123
PE
3593 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
3594 if GCC considers string literals to be constants.
49cebcca 3595 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 3596
35ac2a97
SM
35972011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
3598
fb103ca9
SM
3599 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
3600 (print_preprocess, print_object): New macro to fix last change.
3601
35ac2a97
SM
3602 * print.c (print_preprocess): Don't forget font objects.
3603
62973b41
JB
36042011-03-16 Juanma Barranquero <lekktu@gmail.com>
3605
3606 * emacs.c (USAGE3): Doc fixes.
3607
0e48bb22
AS
36082011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3609
3610 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3611 structure.
3612
7684e57b
JB
36132011-03-14 Juanma Barranquero <lekktu@gmail.com>
3614
3615 * lisp.h (VWindow_system, Qfile_name_history):
3616 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3617 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3618 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3619
3620 * w32select.c: Don't #include "keyboard.h".
c96bbc66 3621 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
3622
3623 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3624 * w32console.c (detect_input_pending, read_input_pending)
3625 (encode_terminal_code):
3626 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3627 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3628 (w32_system_caret_y, Qfile_name_history):
3629 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3630 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3631 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3632 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3633 * w32proc.c (Qlocal, report_file_error):
3634 * w32term.c (Vwindow_system, updating_frame):
3635 * w32uniscribe.c (initialized, uniscribe_font_driver):
3636 Remove unneeded extern declarations.
3637
2aa46d6c
CY
36382011-03-14 Chong Yidong <cyd@stupidchicken.com>
3639
c96bbc66 3640 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 3641
cffc6f3b
CY
36422011-03-13 Chong Yidong <cyd@stupidchicken.com>
3643
3644 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3645 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3646 These macros can no longer be used for assignment.
3647
44f230aa
SM
3648 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3649 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
3650 (record_buffer_markers, fetch_buffer_markers): New functions for
3651 recording and fetching special buffer markers.
3652 (set_buffer_internal_1, set_buffer_temp): Use them.
3653
3654 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3655
3656 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3657
3658 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3659 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3660
3661 * xdisp.c (hscroll_window_tree):
3662 (reconsider_clip_changes): Use PT instead of BUF_PT.
3663
d251f04b
EZ
36642011-03-13 Eli Zaretskii <eliz@gnu.org>
3665
3666 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3667 $(EMACS_ROOT)/lib/intprops.h.
3668
f0c77cd1
PE
36692011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3670
3eca4629
PE
3671 Fix more problems found by GCC 4.5.2's static checks.
3672
7c86ee98
PE
3673 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3674 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
3675 (xg_free_frame_widgets): Make it clear that a local variable is
3676 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
3677 (gdk_window_get_screen): Make it clear that this macro is needed
3678 only if USE_GTK_TOOLTIP.
1e5524e7
PE
3679 (int_gtk_range_get_value): New function, which avoids a diagnostic
3680 from gcc -Wbad-function-cast.
3681 (xg_set_toolkit_scroll_bar_thumb): Use it.
3682 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3683 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
3684 (get_utf8_string, xg_get_file_with_chooser):
3685 Rename locals to avoid shadowing.
3686 (create_dialog): Move locals to avoid shadowing.
7c86ee98 3687
41729b81
PE
3688 * xgselect.c (xg_select): Remove unused var.
3689
f0c77cd1
PE
3690 * image.c (four_corners_best): Mark locals as initialized.
3691 (gif_load): Initialize transparent_p to zero (Bug#8238).
3692 Mark another local as initialized.
ec6cf4c6 3693 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 3694
ce0ad53d 3695 * image.c (clear_image_cache): Now static.
d5d5a617 3696 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 3697 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
3698 (x_edge_detection): Remove unnecessary cast that
3699 gcc -Wbad-function-cast diagnoses.
2037898d 3700 (gif_load): Fix pointer signedness.
6ae141d6
PE
3701 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
3702 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 3703
33383987 37042011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 3705
d32df629
PE
3706 Improve quality of tests for time stamp overflow.
3707 For example, without this patch (encode-time 0 0 0 1 1
3708 1152921504606846976) returns the obviously-bogus value (-948597
3709 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
3710 reports time overflow. See
3711 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
3712 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
3713 * editfns.c: Include limits.h and intprops.h.
3714 (TIME_T_MIN, TIME_T_MAX): New macros.
3715 (time_overflow): Move earlier, to before first use.
3716 (hi_time, lo_time): New functions, for an accurate test for
3717 out-of-range times.
3718 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3719 (Fget_internal_run_time): Don't assume time_t fits in int.
3720 (make_time): Use list2 instead of Fcons twice.
3721 (Fdecode_time): More accurate test for out-of-range times.
3722 (check_tm_member): New function.
3723 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
3724 (lisp_time_argument): Don't rely on undefined left-shift and
3725 right-shift behavior when checking for time stamp overflow.
8be6f318 3726
fe31d94c
PE
3727 * editfns.c (time_overflow): New function, refactoring common code.
3728 (Fformat_time_string, Fdecode_time, Fencode_time):
3729 (Fcurrent_time_string): Use it.
3730
8be6f318
PE
3731 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3732 * dired.c (make_time): Move to ...
3733 * editfns.c (make_time): ... here.
3734 * systime.h: Note the move.
3735
09d9db2c 37362011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 3737
126bc0dc
YM
3738 * fringe.c (update_window_fringes): Remove unused variables.
3739
c47cbdfd
YM
3740 * unexmacosx.c (copy_data_segment): Also copy __got section.
3741 (Bug#8223)
3742
7ac80be9
EZ
37432011-03-12 Eli Zaretskii <eliz@gnu.org>
3744
c96bbc66 3745 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
3746 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3747 Constify `char *' arguments and their references according to
3748 prototypes in tparam.h.
3749
ecb0f94d 3750 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 3751
7ac80be9
EZ
3752 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3753 Adapt all references accordingly.
3754
3755 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3756
ef1fd07e
TT
37572011-03-11 Tom Tromey <tromey@redhat.com>
3758
3759 * buffer.c (syms_of_buffer): Remove obsolete comment.
3760
7ef4b50c
EZ
37612011-03-11 Eli Zaretskii <eliz@gnu.org>
3762
3763 * termhooks.h (encode_terminal_code): Declare prototype.
3764
3765 * msdos.c (encode_terminal_code): Don't declare prototype.
3766
3767 * term.c (encode_terminal_code): Now external again, used by
3768 w32console.c and msdos.c.
3769
44f230aa
SM
3770 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
3771 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 3772
4b1ec863 37732011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 3774
1714f52b 3775 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 3776
4b1ec863
PE
3777 * fringe.c (update_window_fringes): Mark locals as initialized
3778 (Bug#8227).
3779 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 3780
524c7aa6
PE
3781 * alloc.c (mark_fringe_data): Move decl from here ...
3782 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3783 to check its interface.
3784 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3785
a5c0af81 3786 * fontset.c (free_realized_fontset): Now static.
7519b8cd 3787 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 3788 (fontset_font): Mark local as initialized.
a9a06e0b 3789 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 3790
b4716021
PE
3791 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3792
811e9bac 3793 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 3794 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
3795 (x_own_selection, Fx_disown_selection_internal): Rename locals
3796 to avoid shadowing.
3797 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 3798
7e3ab302
PE
3799 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3800 so that the caller can use some name other than gcpro1.
3801 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
3802 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3803 (Fx_backspace_delete_keys_p):
3804 Use them to avoid shadowing, and rename vars to avoid shadowing.
3805 (x_decode_color, x_set_name, x_window): Now static.
6b437900 3806 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 3807 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
3808 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3809 Remove unused locals.
7e3ab302
PE
3810 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3811 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3812 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3813 macros.
f78faa98 3814
e2b13473
PE
3815 * xterm.h (x_mouse_leave): New decl.
3816
77f23912
PE
3817 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3818 Remove unused functions.
cdf4ba58
PE
3819 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3820 (x_calc_absolute_position): Now static.
7411c686 3821 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 3822 Don't declare local "event" unless it's used.
ed7bf3a5
PE
3823 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3824 unless they are used.
38d0b34a
PE
3825 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3826 (x_fatal_error_signal): Remove; not used.
a6067996
PE
3827 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3828 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3829 (x_error_catcher, x_connection_closed, x_error_handler):
3830 (x_error_quitter, xembed_send_message, x_iconify_frame):
3831 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 3832 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 3833 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 3834
44f230aa
SM
3835 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3836 Rename or move locals to avoid shadowing.
6b463e58 3837 (tty_defined_color, merge_face_heights): Now static.
5967d051 3838 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
3839 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3840 does not deduce is never used uninitialized.
73719eba
PE
3841 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3842 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 3843
426994c3 3844 * terminal.c (store_terminal_param): Now static.
5489860b 3845
032f1620 3846 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 3847 (set_frame_menubar): Remove unused local.
d4323972 3848 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
3849 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3850 since they might point to immutable storage.
281585b0
PE
3851 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3852 since it's unused otherwise.
032f1620 3853
367c19e5 3854 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 3855 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
3856 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3857 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 3858 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
3859 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3860 does not deduce are never used uninitialized.
70739cbe 3861
07b48fa9
PE
3862 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3863
8868a238 3864 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
3865 * window.c (window_loop, size_window):
3866 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 3867
7e5cf297 3868 * window.c (display_buffer): Now static.
d6550a9f
PE
3869 (size_window): Mark variables that gcc -Wuninitialized
3870 does not deduce are never used uninitialized.
a586633d
PE
3871 * window.h (check_all_windows): New decl, to forestall
3872 gcc -Wmissing-prototypes diagnostic.
5b555da1 3873 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 3874
f6095868
PE
3875 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3876 shadowing.
3877 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
3878 Include <limits.h>.
3879 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3880 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
3881 (load_charset_map): Mark variables that gcc -Wuninitialized
3882 does not deduce are never used uninitialized.
53df7c11 3883 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 3884
f38b440c
PE
3885 * coding.c (coding_set_source, coding_set_destination):
3886 Use "else { /* comment */ }" rather than "else /* comment */;"
3887 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
3888 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3889 a block, when the outer 'i' will do.
3890 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3891 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3892 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3893 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3894 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3895 Rename locals to avoid shadowing.
3896 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
3897 * coding.c (emacs_mule_char, encode_invocation_designation):
3898 Now static, since they're not used elsewhere.
413bb2db 3899 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 3900 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
3901 (decode_coding_emacs_mule): Mark variables that gcc
3902 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
3903 (detect_coding_iso_2022): Initialize a local variable that might
3904 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 3905 this initialization is needed. (Bug#8211)
5f58e762
PE
3906 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3907 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3908 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3909 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3910 Remove unused macros.
f38b440c 3911
232b38b9 3912 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 3913 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 3914 * character.c (string_count_byte8): Likewise.
232b38b9 3915
fb90da1b
PE
3916 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3917 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3918
fb93dbc2
PE
3919 * chartab.c (copy_sub_char_table): Now static, since it's not used
3920 elsewhere.
5c156ace
PE
3921 (sub_char_table_ref_and_range, char_table_ref_and_range):
3922 Rename locals to avoid shadowing.
bbcd0949 3923 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 3924
7d3b3862 3925 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 3926 (BIDI_BOB): Remove unused macro.
7d3b3862 3927
6be7d3da
PE
3928 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
3929 deduce are never used uninitialized.
c2ed9c8b 3930 * term.c (encode_terminal_code): Likewise.
6be7d3da 3931
75f8807f 3932 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 3933
50938595
PE
3934 * tparam.h: New file.
3935 * term.c, tparam.h: Include it.
3936 * deps.mk (term.o, tparam.o): Depend on tparam.h.
3937 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
3938 Move these decls to tparam.h, and make them agree with what
3939 is actually in tparam.c. The previous trick of using incompatible
3940 decls in different modules does not conform to the C standard.
3941 All callers of tparam changed to use tparam's actual API.
3942 * tparam.c (tparam1, tparam, tgoto):
3943 Use const pointers where appropriate.
3944
fbceeba2
PE
3945 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3946 * cm.h (struct cm): Likewise.
3947 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3948 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3949 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3950 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3951 (turn_on_face, init_tty): Likewise.
3952 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 3953
7f3f1250
PE
3954 * term.c (term_mouse_position): Rename local to avoid shadowing.
3955
e6ca6543
PE
3956 * alloc.c (mark_ttys): Move decl from here ...
3957 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3958
c40f8d15
AS
39592011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3960
3961 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3962
cfe0661d
JB
39632011-03-09 Juanma Barranquero <lekktu@gmail.com>
3964
3965 * search.c (compile_pattern_1): Remove argument regp, unused since
3966 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3967 (compile_pattern): Don't pass it.
3968
0afb4571
J
39692011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3970
3971 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3972 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3973 for ! HAVE_GTK3.
3974 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3975
3976 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3977
3978 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3979 gdk_window_get_screen, gdk_window_get_geometry,
3980 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3981 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3982 (xg_get_pixbuf_from_pixmap): New function.
3983 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3984 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3985 Call xg_get_pixbuf_from_pixmap instead of
3986 gdk_pixbuf_get_from_drawable.
3987 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3988 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3989 (xg_check_special_colors): Use GtkStyleContext and its functions
3990 for HAVE_GTK3.
3991 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3992 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3993 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
3994 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3995 Call gtk_widget_get_preferred_size.
0afb4571
J
3996 (xg_frame_resized): gdk_window_get_geometry only takes 5
3997 parameters.
44f230aa
SM
3998 (xg_win_to_widget, xg_event_is_for_menubar):
3999 Call gdk_x11_window_lookup_for_display.
0afb4571
J
4000 (xg_set_widget_bg): New function.
4001 (delete_cb): New function.
895009e1 4002 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
4003 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4004 (xg_set_background_color): Call xg_set_widget_bg.
4005 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4006 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4007 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4008 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4009 if ! HAVE_GTK3.
4010 (update_frame_tool_bar): Call gtk_widget_hide.
4011 (xg_initialize): Use GDK_KEY_g.
4012
4013 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4014 if ! HAVE_GTK3
4015 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4016
4017 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4018 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4019 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4020
1c2cc4ef
JB
40212011-03-08 Juanma Barranquero <lekktu@gmail.com>
4022
4023 * w32xfns.c (select_palette): Check success of RealizePalette against
4024 GDI_ERROR, not zero.
4025
33383987 4026See ChangeLog.11 for earlier changes.
aac0c6e3
MR
4027
4028;; Local Variables:
4029;; coding: utf-8
aac0c6e3
MR
4030;; End:
4031
33383987 4032 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
4033
4034 This file is part of GNU Emacs.
4035
4036 GNU Emacs is free software: you can redistribute it and/or modify
4037 it under the terms of the GNU General Public License as published by
4038 the Free Software Foundation, either version 3 of the License, or
4039 (at your option) any later version.
4040
4041 GNU Emacs is distributed in the hope that it will be useful,
4042 but WITHOUT ANY WARRANTY; without even the implied warranty of
4043 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4044 GNU General Public License for more details.
4045
4046 You should have received a copy of the GNU General Public License
4047 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.