Remove stray comment.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
8b9587d7
PE
12011-04-20 Paul Eggert <eggert@cs.ucla.edu>
2
67769ffc
PE
3 * textprop.c (set_text_properties_1): Rewrite for clarity,
4 and to avoid GCC warning about integer overflow.
5
c20db43f
PE
6 * intervals.h (struct interval): Use EMACS_INT for members
7 where EMACS_UINT might cause problems. See
8 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
9 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
10 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
11 All uses changed.
37aa2f85
PE
12 (offset_intervals): Tell GCC not to worry about length overflow
13 when negating a negative length.
c20db43f 14
2538aa2f
PE
15 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
16 (overrun_check_free): Likewise.
17
8b9587d7
PE
18 Make the Lisp reader and string-to-float more consistent.
19 * data.c (atof): Remove decl; no longer used or needed.
20 (Fstring_to_number): Use new string_to_float function, to be
21 consistent with how the Lisp reader treats infinities and NaNs.
22 Do not assume that floating-point numbers represent EMACS_INT
23 without losing information; this is not true on most 64-bit hosts.
24 Avoid double-rounding errors, by insisting on integers when
25 parsing non-base-10 numbers, as the documentation specifies.
26 Report integer overflow instead of silently converting to
27 integers.
28 * lisp.h (string_to_float): New decl, replacing ...
29 (isfloat_string): Remove.
30 * lread.c (read1): Do not accept +. and -. as integers; this
31 appears to have been a coding error. Similarly, do not accept
32 strings like +-1e0 as floating point numbers. Do not report
33 overflow for some integer overflows and not others; instead,
34 report them all. Break out the floating-point parsing into a new
35 function string_to_float, so that Fstring_to_number parses
36 floating point numbers consistently with the Lisp reader.
37 (string_to_float): New function, replacing isfloat_string.
38 This function checks for valid syntax and produces the resulting
39 Lisp float number too.
c2982e87 40
f2d3008d
PE
41 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
42 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
43 word size.
44
ec8df744
PE
45 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
46 (gnutls_make_error): Rename local to avoid shadowing.
47 (gnutls_emacs_global_deinit): ifdef out; not used.
48 (Fgnutls_boot): Use const for pointer to readonly storage.
49 Comment out unused local. Fix pointer signedness problems.
50
640ee02d
PE
51 * lread.c (openp): Don't stuff size_t into an 'int'.
52 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
53 about possible signed overflow.
54
6048fb2a
PE
55 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
56 (GDK_KEY_g): Don't define if already defined.
57 (xg_prepare_tooltip): Avoid pointer signedness problem.
58 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
59
fa3c87e1
PE
60 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
61 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
62
2172544b
PE
63 * xfns.c (Fx_window_property): Simplify a bit,
64 to make a bit faster and to avoid GCC 4.6.0 warning.
65 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
66
9b821a21
PE
67 * fns.c (internal_equal): Don't assume size_t fits in int.
68
3c616cfa
PE
69 * alloc.c (compact_small_strings): Tighten assertion a little.
70
c2982e87
PE
71 Replace pEd with more-general pI, and fix some printf arg casts.
72 * lisp.h (pI): New macro, generalizing old pEd macro to other
73 conversion specifiers. For example, use "...%"pI"d..." rather
74 than "...%"pEd"...".
75 (pEd): Remove. All uses replaced with similar uses of pI.
76 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
77 * alloc.c (check_pure_size): Don't overflow by converting size to int.
78 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
79 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
80 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
81 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
82 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
83 64-bit hosts.
84 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
85 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
86 * print.c (safe_debug_print, print_object): Likewise.
87 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
88 to int.
6f04d126
PE
89 Use pI instead of if-then-else-abort. Use %p to avoid casts,
90 avoiding the 0 flag, which is not portable.
c2982e87
PE
91 * process.c (Fmake_network_process): Use pI to avoid cast.
92 * region-cache.c (pp_cache): Likewise.
93 * xdisp.c (decode_mode_spec): Likewise.
94 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
95 behavior on 64-bit hosts with printf arg.
6f04d126 96 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
97 (x_stop_queuing_selection_requests): Likewise.
98 (x_get_window_property): Don't truncate byte count to an 'int'
99 when tracing.
0b432f21 100
5e073ec7
PE
101 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
102 here, since it parses constructs like leading '-' and spaces,
103 which are not wanted; and it overflows with large numbers.
104 Instead, simply match F[0-9]+, which is what is wanted anyway.
105
36372bf9
PE
106 * alloc.c: Remove unportable assumptions about struct layout.
107 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
108 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
109 (allocate_vectorlike, make_pure_vector): Use the new macros,
110 plus offsetof, to remove unportable assumptions about struct layout.
111 These assumptions hold on all porting targets that I know of, but
112 they are not guaranteed, they're easy to remove, and removing them
113 makes further changes easier.
114
0b432f21
PE
115 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
116 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
117 (string_overrun_cookie): Now const. Use initializers that
118 don't formally overflow signed char, to avoid warnings.
000098c1
PE
119 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
120 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
121 (allocate_buffer): Don't assume sizeof (struct buffer) is a
122 multiple of sizeof (EMACS_INT); it need not be, if
123 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 124 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 125
04c56954
EZ
1262011-04-19 Eli Zaretskii <eliz@gnu.org>
127
128 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
129 gl_state.e_property when gl_state.object is Qt.
130
131 * insdel.c (make_gap_larger): Remove limitation of buffer size
132 to <= INT_MAX.
133
16a43933
CY
1342011-04-18 Chong Yidong <cyd@stupidchicken.com>
135
136 * xdisp.c (lookup_glyphless_char_display)
137 (produce_glyphless_glyph): Handle cons cell entry in
138 glyphless-char-display.
139 (Vglyphless_char_display): Document it.
140
141 * term.c (produce_glyphless_glyph): Handle cons cell entry in
142 glyphless-char-display.
143
4581706e
CY
1442011-04-17 Chong Yidong <cyd@stupidchicken.com>
145
146 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
147
148 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
149
150 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
151 definition for no-X builds.
152
4887c6e2 1532011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 154
fd35b6f9
PE
155 Static checks with GCC 4.6.0 and non-default toolkits.
156
5c1ccb01
PE
157 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
158
006c5daa
PE
159 * process.c (keyboard_bit_set): Define only if SIGIO.
160 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
161 (send_process): Repair possible setjmp clobbering.
162
efc736d3
PE
163 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
164
4e2fe2e6
PE
165 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
166
f97334a2
PE
167 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
168
4e75f29d
PE
169 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
170 Define only if needed.
171
90efadd1
PE
172 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
173 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 174 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 175
3c647824
PE
176 * dispextern.h (struct redisplay_interface): Rename param
177 to avoid shadowing.
e264f262 178 * termhooks.h (struct terminal): Likewise.
761383f4 179 * xterm.c (xembed_send_message): Likewise.
3c647824 180
b58c5c4a
PE
181 * insdel.c (make_gap_smaller): Define only if
182 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
183
cad59032
PE
184 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
185 it.
186
c339dc2e
PE
187 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
188 so that we aren't warned about unused symbols.
189
91a3e27b
PE
190 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
191
399c71d3 192 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 193
8ffc96f5
PE
194 * xfns.c (x_real_positions): Mark locals as initialized.
195
eef9bc79
PE
196 * xmenu.c (xmenu_show): Don't use uninitialized vars.
197
098db9dd
PE
198 * xterm.c: Fix problems found by static analysis with other toolkits.
199 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
200 (x_dispatch_event): Declare static if USE_GTK, and
201 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 202 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 203 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
098db9dd
PE
204 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only if
205 defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
206
eb18f6cc
PE
207 * xmenu.c (menu_help_callback): Pointer type fixes.
208 Use const pointers when pointing at readonly data. Avoid pointer
209 signedness clashes.
210 (FALSE): Remove unused macro.
211 (update_frame_menubar): Remove unused decl.
212
1fe72bf8
PE
213 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
214
60d9e1db
PE
215 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
216 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
217 (single_menu_item): Rename local to avoid shadowing.
218
39261c26
PE
219 * keyboard.c (make_lispy_event): Remove unused local var.
220
018c5e19
PE
221 * frame.c, frame.h (x_get_resource_string): Bring this back, but
222 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
223
63d2b86e
PE
224 * bitmaps: Change bitmaps from unsigned char back to the X11
225 compatible char. Avoid the old compiler warnings about
226 out-of-range initializers by using, for example, '\xab' rather
227 than 0xab.
228
aefd87e1
PE
229 * xgselect.c (xgselect_initialize): Check vs interface
230 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
231
bf501fb9
PE
232 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
233
e9829fdf
PE
234 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
235 to read-only memory.
236
1086c095
PE
237 * fns.c (vector): Remove; this old hack is no longer needed.
238
2baccd04 239 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 240 Remove unused var.
dde42981 241 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 242
72391843 243 * xrdb.c (x_load_resources): Omit unused local.
3565b346 244
436c16df 245 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 246 (x_window): Rename locals to avoid shadowing.
dc5ddd85 247 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 248
92bb796d 249 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 250 (x_term_init): Remove local to avoid shadowing.
92bb796d 251
764430a3 252 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
253
254 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
255 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
256
d1dfb56c
EZ
2572011-04-16 Eli Zaretskii <eliz@gnu.org>
258
c4354cb4
EZ
259 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
260
d1dfb56c
EZ
261 Fix regex.c, syntax.c and friends for buffers > 2GB.
262 * syntax.h (struct gl_state_s): Declare character position members
263 EMACS_INT.
264
265 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
266
267 * textprop.c (verify_interval_modification, interval_of): Declare
268 arguments EMACS_INT.
269
270 * intervals.c (adjust_intervals_for_insertion): Declare arguments
271 EMACS_INT.
272
273 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
274
275 * indent.c (Fvertical_motion): Local variable it_start is now
276 EMACS_INT.
277
278 * regex.c (re_match, re_match_2, re_match_2_internal)
279 (bcmp_translate, regcomp, regexec, print_double_string)
280 (group_in_compile_stack, re_search, re_search_2, regex_compile)
281 (re_compile_pattern, re_exec): Declare arguments and local
282 variables `size_t' and `ssize_t' and return values `regoff_t', as
283 appropriate.
284 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
285 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
286 <compile_stack_type>: `size' and `avail' are now `size_t'.
287
288 * regex.h <regoff_t>: Use ssize_t, not int.
289 (re_search, re_search_2, re_match, re_match_2): Arguments that
290 specify buffer/string position and length are now ssize_t and
291 size_t. Return type is regoff_t.
292
613052cd
BK
2932011-04-16 Ben Key <bkey76@gmail.com>
294
295 * nsfont.m: Fixed bugs in ns_get_family and
296 ns_descriptor_to_entity that were caused by using free to
297 deallocate memory blocks that were allocated by xmalloc (via
298 xstrdup). This caused Emacs to crash when compiled with
299 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
300 --enable-checking=xmallocoverrun). xfree is now used to
301 deallocate these memory blocks.
302
4170f62f 3032011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 304
71b41406
PE
305 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
306
9587a89d
PE
307 emacs_write: Accept and return EMACS_INT for sizes.
308 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
309 et seq.
310 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
311 Accept and return EMACS_INT.
312 (emacs_gnutls_write): Return the number of bytes written on
313 partial writes.
314 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
315 (emacs_read, emacs_write): Remove check for negative size, as the
316 Emacs source code has been audited now.
9587a89d
PE
317 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
318 (emacs_read, emacs_write): Use it.
273a5f82
PE
319 * process.c (send_process): Adjust to the new signatures of
320 emacs_write and emacs_gnutls_write. Do not attempt to store
321 a byte offset into an 'int'; it might overflow.
9587a89d 322 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 323
3e047f51
PE
324 * sound.c: Don't assume sizes fit in 'int'.
325 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 326 Return EMACS_INT, not int.
3e047f51 327 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
328 Accept EMACS_INT, not int.
329 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
330 record read return values.
331
cc39a9db
BK
3322011-04-15 Ben Key <bkey76@gmail.com>
333
c9d0ec6d
JB
334 * keyboard.c (Qundefined): Don't declare static since it is used
335 in nsfns.m.
336 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
337 static since they are used in nsfont.m.
cc39a9db 338
6c60eb9f
SM
3392011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
340
341 * process.c (Qprocessp): Don't declare static.
342 * lisp.h (Qprocessp): Declare again.
343
7990b61a
JB
3442011-04-15 Juanma Barranquero <lekktu@gmail.com>
345
346 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
347
5d4cb038
PE
3482011-04-14 Paul Eggert <eggert@cs.ucla.edu>
349
8bd7b830 350 Improve C-level modularity by making more things 'static'.
cd64ea1d 351
e3b27b31
PE
352 Don't publish debugger-only interfaces to other modules.
353 * lisp.h (safe_debug_print, debug_output_compilation_hack):
354 (verify_bytepos, count_markers): Move decls to the only modules
355 that need them.
356 * region-cache.h (pp_cache): Likewise.
357 * window.h (check_all_windows): Likewise.
358 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
359
5d4cb038
PE
360 * sysdep.c (croak): Now static, if
361 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
362 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
363
364 * alloc.c (refill_memory_reserve): Now static if
365 !defined REL_ALLOC || defined SYSTEM_MALLOC.
366 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 367
e87b6180
PE
368 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
369 Define only if USE_LUCID.
370
ac64929e
PE
371 * xrdb.c (x_customization_string, x_rm_string): Now static.
372
6f37259d
PE
373 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
374 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
375
1683e3ab
PE
376 * xdisp.c (draw_row_with_mouse_face): Now static.
377 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
378
de9c2632
PE
379 * window.h (check_all_windows): Mark externally visible.
380
2b96acb7
PE
381 * window.c (window_deletion_count): Now static.
382
383 * undo.c: Make symbols static if they're not exported.
384 (last_undo_buffer, last_boundary_position, pending_boundary):
385 Now static.
386
50436f33
PE
387 * textprop.c (interval_insert_behind_hooks): Now static.
388 (interval_insert_in_front_hooks): Likewise.
389
64520e5c
PE
390 * term.c: Make symbols static if they're not exported.
391 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
392 (max_frame_lines, tty_set_terminal_modes):
393 (tty_reset_terminal_modes, tty_turn_off_highlight):
394 (get_tty_terminal): Now static.
395 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
396 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 397 HAVE_WINDOW_SYSTEM.
64520e5c
PE
398 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
399 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
400
1fa53021
PE
401 * sysdep.c: Make symbols static if they're not exported.
402 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
403 Now static.
404 (sigprocmask_set, full_mask): Remove; unused.
405 (wait_debugging): Mark as visible.
406 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
407 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
408
d4b43b22
PE
409 * syntax.c (syntax_temp): Define only if !__GNUC__.
410
b7c513d0
PE
411 * sound.c (current_sound_device, current_sound): Now static.
412
989b29ad
PE
413 * search.c (searchbufs, searchbuf_head): Now static.
414
13a55a78
PE
415 * scroll.c (scroll_cost): Remove; unused.
416 * dispextern.h (scroll_cost): Remove decl.
417
de68a1fc
PE
418 * region-cache.h (pp_cache): Mark as externally visible.
419
40ccffa6
PE
420 * process.c: Make symbols static if they're not exported.
421 (process_tick, update_tick, create_process, chan_process):
422 (Vprocess_alist, proc_buffered_char, datagram_access):
423 (fd_callback_data, send_process_frame, process_sent_to): Now static.
424 (deactivate_process): Mark defn as static, as well as decl.
425 * lisp.h (create_process): Remove decl.
426 * process.h (chan_process, Vprocess_alist): Remove decls.
427
ad64fc97
PE
428 * print.c: Make symbols static if they're not exported.
429 (print_depth, new_backquote_output, being_printed, print_buffer):
430 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
431 (print_interval, print_number_index, initial_stderr_stream):
432 Now static.
433 * lisp.h (Fprinc): Remove decl.
434 (debug_output_compilation_hack): Mark as externally visible.
435
adddb265
PE
436 * sysdep.c (croak): Move decl from here to syssignal.h.
437 * syssignal.h (croak): Put it here, so the API can be checked when
438 'croak' is called from dissociate_if_controlling_tty.
439
1717ede2
PE
440 * minibuf.c: Make symbols static if they're not exported.
441 (minibuf_save_list, choose_minibuf_frame): Now static.
442 * lisp.h (choose_minibuf_frame): Remove decl.
443
fa5fb2bc
PE
444 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
445
1e3890d1
PE
446 * lread.c: Make symbols static if they're not exported.
447 (read_objects, initial_obarray, oblookup_last_bucket_number):
448 Now static.
449 (make_symbol): Remove; unused.
450 * lisp.h (initial_obarray, make_symbol): Remove decls.
451
8a1414fa
PE
452 * keyboard.c: Make symbols static if they're not exported.
453 (single_kboard, recent_keys_index, total_keys, recent_keys):
454 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
455 (this_single_command_key_start, echoing, last_auto_save):
456 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
457 (command_loop, echo_now, keyboard_init_hook, help_char_p):
458 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
459 (Vlispy_mouse_stem, double_click_count):
460 Now static.
461 (force_auto_save_soon): Define only if SIGDANGER.
462 (ignore_mouse_drag_p): Now static if
463 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
464 (print_help): Remove; unused.
465 (stop_character, last_timer_event): Mark as externally visible.
466 * keyboard.h (ignore_mouse_drag_p): Declare only if
467 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
468 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
469 * lisp.h (echoing): Remove decl.
470 (force_auto_save_soon): Declare only if SIGDANGER.
471 * xdisp.c (redisplay_window): Simplify code, to make it more
472 obvious that ignore_mouse_drag_p is not accessed if !defined
473 USE_GTK && !defined HAVE_NS.
474
93ea6e8f
PE
475 * intervals.c: Make symbols static if they're not exported.
476 (merge_properties_sticky, merge_interval_right, delete_interval):
477 Now static.
478 * intervals.h (merge_interval_right, delete_interval): Remove decls.
479
77382fcc
PE
480 * insdel.c: Make symbols static if they're not exported.
481 However, leave prepare_to_modify_buffer alone. It's never
482 called from outside this function, but that appears to be a bug.
483 (combine_after_change_list, combine_after_change_buffer):
4889fc82 484 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
485 (adjust_after_replace_noundo): Remove; unused.
486 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 487 (signal_before_change): Remove decls.
77382fcc 488
9306c32e
PE
489 * indent.c (val_compute_motion, val_vmotion): Now static.
490
cd44d2eb
PE
491 * image.c: Make symbols static if they're not exported.
492 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
493 if USE_GTK.
494 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
495 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
496
ad9a7a06
PE
497 * fringe.c (standard_bitmaps): Now static.
498 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
499
81626931
PE
500 * frame.c: Make symbols static if they're not exported.
501 (x_report_frame_params, make_terminal_frame): Now static.
502 (get_frame_param): Now static, unless HAVE_NS.
503 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
504 (x_get_resource_string): Remove; not used.
505 * frame.h (make_terminal_frame, x_report_frame_params):
506 (x_get_resource_string); Remove decls.
507 (x_fullscreen_adjust): Declare only if WINDOWSNT.
508 * lisp.h (get_frame_param): Declare only if HAVE_NS.
509
239f9db9
PE
510 * font.c, fontset.c: Make symbols static if they're not exported.
511 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
512 (FACE_SUITABLE_FOR_CHAR_P): Use it.
513 * font.c (font_close_object): Now static.
514 * font.h (font_close_object): Remove.
515 * fontset.c (FONTSET_OBJLIST): Remove.
516 (free_realized_fontset) #if-0 the body, which does nothing.
517 (face_suitable_for_char_p): #if-0, as it's never called.
518 * fontset.h (face_suitable_for_char_p): Remove decl.
519 * xfaces.c (face_at_string_position): Use
520 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
521 since 0 is always ASCII.
522
dfcf3579
PE
523 * fns.c (weak_hash_tables): Now static.
524
5045092b
PE
525 * fileio.c: Make symbols static if they're not exported.
526 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
527 (Vwrite_region_annotation_buffers): Now static.
528
57a96f5c
PE
529 * eval.c: Make symbols static if they're not exported.
530 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
531 * lisp.h (backtrace_list): Remove decl.
532
35f08c38
PE
533 * emacs.c: Make symbols static if they're not exported.
534 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
535 (fatal_error_code, fatal_error_signal_hook, standard_args):
536 Now static.
537 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
538 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
539 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
540 * lisp.h (fatal_error_signal_hook): Remove decl.
541 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
542
f44bd759
PE
543 * editfns.c: Move a (normally-unused) function to its only use.
544 * editfns.c, lisp.h (get_operating_system_release): Remove.
545 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
546 worth the hassle of breaking this out.
547
b532497d
PE
548 * xterm.c: Make symbols static if they're not exported.
549 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
550 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
551 (x_destroy_window, x_delete_display):
552 Now static.
553 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
554 (x_mouse_leave): Remove; unused.
555 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
556 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
557 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
558 Remove decls.
559 (x_mouse_leave): Declare only if WINDOWSNT.
560 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
561 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
562 USE_X_TOOLKIT.
563
1675728f
PE
564 * ftxfont.c: Make symbols static if they're not exported.
565 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
566 HAVE_FREETYPE.
567 * font.h (ftxfont_driver): Likewise.
568
e4cebfca
PE
569 * xfns.c: Make symbols static if they're not exported.
570 (x_last_font_name, x_display_info_for_name):
571 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
572 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
573 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
574 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
575 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
576 (last_show_tip_args): Now static.
577 (xic_defaut_fontset, xic_create_fontsetname): Define only if
578 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
579 (x_screen_planes): Remove; unused.
580 * dispextern.h (x_screen_planes): Remove decl.
581
5bf46f05
PE
582 * dispnew.c: Make symbols static if they're not exported.
583 * dispextern.h (redraw_garbaged_frames, scrolling):
584 (increment_row_positions): Remove.
585 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
586 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
587 Now static.
588 (redraw_garbaged_frames): Remove; unused.
589
435f4c28
PE
590 * xfaces.c: Make symbols static if they're not exported.
591 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
592 Remove decls.
593 * xterm.h (defined_color): Remove decls.
594 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
595 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
596 (menu_face_changed_default, defined_color, free_realized_face):
597 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
598 (ascii_face_of_lisp_face): Remove; unused.
599
8524aef3
PE
600 * xdisp.c: Make symbols static if they're not exported.
601 * dispextern.h (scratch_glyph_row, window_box_edges):
602 (glyph_to_pixel_coords, set_cursor_from_row):
603 (get_next_display_element, set_iterator_to_next):
604 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
605 (show_mouse_face): Remove decls
606 * frame.h (message_buf_print): Likewise.
607 * lisp.h (pop_message, set_message, check_point_in_composition):
608 Likewise.
609 * xterm.h (set_vertical_scroll_bar): Likewise.
610 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
611 (message_buf_print, scratch_glyph_row, displayed_buffer):
612 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
613 (get_next_display_element, show_mouse_face, window_box_edges):
614 (frame_to_window_pixel_xy, check_point_in_composition):
615 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
616 (glyph_to_pixel_coords): Remove; unused.
617
16390cd2
PE
618 * dired.c (file_name_completion): Now static.
619
620 * dbusbind.c (xd_in_read_queued_messages): Now static.
621
a25f4dfa
PE
622 * lisp.h (circular_list_error, FOREACH): Remove; unused.
623 * data.c (circular_list_error): Remove.
624
14a9c8df
PE
625 * commands.h (last_point_position, last_point_position_buffer):
626 (last_point_position_window): Remove decls.
627 * keyboard.c: Make these variables static.
628
74ab6df5
PE
629 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
630 decls.
631 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
632 (iso_code_class, detect_coding, code_convert_region): Now static.
633 (encode_coding_gap): Remove; unused.
634
38dfbee1
PE
635 * chartab.c (chartab_chars, chartab_bits): Now static.
636
a2cb4e63
PE
637 * charset.h (charset_iso_8859_1): Remove decl.
638 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
639 Now static.
640
127198fd
PE
641 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
642 * ccl.c (Vccl_program_table): Now static.
643 (check_ccl_update): Remove; unused.
644
d85b608f
PE
645 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
646 * category.h: ... from here.
647 * category.c (check_category_table, set_category_set): Now static.
648
31cd66f3
PE
649 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
650 * lisp.h: Remove these decls.
651
c358e587
PE
652 * buffer.c (buffer_count): Remove unused var.
653
e78aecca
PE
654 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
655 so that it's not optimized away.
656 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
657 * dispextern.h (bidi_dump_cached_states): Remove, since it's
658 exported only to the debugger.
659
e192d7d3
PE
660 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
661 * atimer.h (run_all_atimers): Removed; not exported.
662
92470028
PE
663 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
664 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
665 was inaccessible from Lisp.
666 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
667 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
668
244ed907
PE
669 alloc.c: Import and export fewer symbols, and remove unused items.
670 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
671 is defined.
672 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
673 it's not optimized away by whole-program optimization.
674 (message_enable_multibyte, free_misc): Remove.
675 (catchlist, handlerlist, mark_backtrace):
676 Declare only if BYTE_MARK_STACK.
677 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
678 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
679 (message_enable_multibyte): Remove decl.
680 (free_misc, interval_free_list, float_block, float_block_index):
681 (n_float_blocks, float_free_list, cons_block, cons_block_index):
682 (cons_free_list, last_marked_index):
683 Now static.
684 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
685 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
686 (mark_backtrace): Define only if BYTE_MARK_STACK.
687 * xdisp.c (message_enable_multibyte): Now static.
688
61c2b50e 689 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
690 This makes it easier for human readers (and static analyzers)
691 to see whether these variables are used from other modules.
692 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
693 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
694 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
695 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
696 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
697 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
698 * xmenu.c, xselect.c:
699 Declare Q* vars static if they are not used in other modules.
700 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
701 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
702 Remove decls of unexported vars.
703 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
704
95c82688
PE
705 * lisp.h (DEFINE_FUNC): Make sname 'static'.
706
16a97296
PE
707 Make Emacs functions such as Fatom 'static' by default.
708 This makes it easier for human readers (and static analyzers)
709 to see whether these functions can be called from other modules.
710 DEFUN now defines a static function. To make the function external
711 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
712 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
713 (Finit_image_library):
16a97296
PE
714 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
715 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
716 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
717 Remove decls, since these functions are now static.
718 (Funintern, Fget_internal_run_time): New decls, since these functions
719 were already external.
95c82688 720
16a97296
PE
721 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
722 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
723 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
724 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
725 * keyboard.c, keymap.c, lread.c:
726 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
727 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
728 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
729 Mark functions with DEFUE instead of DEFUN,
730 if they are used in other modules.
731 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
732 decls for now-static functions.
733 * buffer.h (Fdelete_overlay): Remove decl.
734 * callproc.c (Fgetenv_internal): Mark as internal.
735 * composite.c (Fremove_list_of_text_properties): Remove decl.
736 (Fcomposition_get_gstring): New forward static decl.
737 * composite.h (Fcomposite_get_gstring): Remove decl.
738 * dired.c (Ffile_attributes): New forward static decl.
739 * doc.c (Fdocumntation_property): New forward static decl.
740 * eval.c (Ffetch_bytecode): New forward static decl.
741 (Funintern): Remove extern decl; now in .h file where it belongs.
742 * fileio.c (Fmake_symbolic_link): New forward static decl.
743 * image.c (Finit_image_library): New forward static decl.
744 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
745 * intervals.h (Fprevious_property_change):
746 (Fremove_list_of_text_properties): Remove decls.
747 * keyboard.c (Fthis_command_keys): Remove decl.
748 (Fcommand_execute): New forward static decl.
749 * keymap.c (Flookup_key): New forward static decl.
750 (Fcopy_keymap): Now static.
751 * keymap.h (Flookup_key): Remove decl.
752 * process.c (Fget_process): New forward static decl.
753 (Fprocess_datagram_address): Mark as internal.
754 * syntax.c (Fsyntax_table_p): New forward static decl.
755 (skip_chars): Remove duplicate decl.
756 * textprop.c (Fprevious_property_change): New forward static decl.
757 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
758 Now internal.
759 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
760 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
761
785bbd42
PE
762 * editfns.c (Fformat): Remove unreachable code.
763
8b913b57
AS
7642011-04-14 Andreas Schwab <schwab@linux-m68k.org>
765
766 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
767 change. (Bug#8496)
768
a6744a35
EZ
7692011-04-13 Eli Zaretskii <eliz@gnu.org>
770
771 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
772 when at ZV. (Bug#8487)
773
e7974947
AS
7742011-04-12 Andreas Schwab <schwab@linux-m68k.org>
775
baad03f0
AS
776 * charset.c (Fclear_charset_maps): Use xfree instead of free.
777 (Bug#8437)
778 * keyboard.c (parse_tool_bar_item): Likewise.
779 * sound.c (sound_cleanup, alsa_close): Likewise.
780 * termcap.c (tgetent): Likewise.
781 * xfns.c (x_default_font_parameter): Likewise.
782 * xsettings.c (read_and_apply_settings): Likewise.
783
e7974947
AS
784 * alloc.c (overrun_check_malloc, overrun_check_realloc)
785 (overrun_check_free): Protoize.
786
28272684
PE
7872011-04-12 Paul Eggert <eggert@cs.ucla.edu>
788
789 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
790 since callers should never pass a negative size.
791 Change the signature to match that of plain 'read' and 'write'; see
792 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
793 * lisp.h: Update prototypes of emacs_write and emacs_read.
794
11997c76
EZ
7952011-04-11 Eli Zaretskii <eliz@gnu.org>
796
797 * xdisp.c (redisplay_window): Don't try to determine the character
798 position of the scroll margin if the window start point w->startp
e896f03c 799 is outside the buffer's accessible region. (Bug#8468)
11997c76 800
8a2cbd72
EZ
8012011-04-10 Eli Zaretskii <eliz@gnu.org>
802
803 Fix write-region and its subroutines for buffers > 2GB.
804 * fileio.c (a_write, e_write): Modify declaration of arguments and
805 local variables to support buffers larger than 2GB.
806 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
807
808 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
809 argument, local variables, and return value.
810
811 * lisp.h: Update prototypes of emacs_write and emacs_read.
812
813 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
814
4073e537 8152011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 816
1ebfdcb6
PE
817 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
818
b2ded58d
PE
819 Fix more problems found by GCC 4.6.0's static checks.
820
7d66342c
PE
821 * xdisp.c (vmessage): Use a better test for character truncation.
822
bbf47d44
PE
823 * charset.c (load_charset_map): <, not <=, for optimization,
824 and to avoid potential problems with integer overflow.
9248994d 825 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 826 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 827 * editfns.c (Fformat): Likewise.
1e69125e 828 * syntax.c (skip_chars): Likewise.
3befa583 829
e3019616
PE
830 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
831 This also lets GCC 4.6.0 generate slightly better loop code.
832
becfa255
PE
833 * callint.c (Fcall_interactively): <, not <=, for optimization.
834 (Fcall_interactively): Count the number of arguments produced,
835 not the number of arguments given. This is simpler and lets GCC
836 4.6.0 generate slightly better code.
837
dae0cd48
PE
838 * ftfont.c: Distingish more carefully between FcChar8 and char.
839 The previous code passed unsigned char * to a functions like
840 strlen and xstrcasecmp that expect char *, which does not
841 conform to the C standard.
842 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
843 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
844 char * when the C standard requires it.
845
76032d70
PE
846 * keyboard.c (read_char): Remove unused var.
847
eb3f1cc8
PE
848 * eval.c: Port to Windows vsnprintf (Bug#8435).
849 Include <limits.h>.
850 (SIZE_MAX): Define if the headers do not.
851 (verror): Do not give up if vsnprintf returns a negative count.
852 Instead, grow the buffer. This ports to Windows vsnprintf, which
853 does not conform to C99. Problem reported by Eli Zaretskii.
854 Also, simplify the allocation scheme, by avoiding the need for
855 calling realloc, and removing the ALLOCATED variable.
856
70476b54
PE
857 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
858
12020a9e
PE
859 Remove invocations of doprnt, as Emacs now uses vsnprintf.
860 But keep the doprint source code for now, as we might revamp it
861 and use it again (Bug#8435).
ea6c7ae6
PE
862 * lisp.h (doprnt): Remove.
863 * Makefile.in (base_obj): Remove doprnt.o.
864 * deps.mk (doprnt.o): Remove.
865
5fdb398c
PE
866 error: Print 32- and 64-bit integers portably (Bug#8435).
867 Without this change, on typical 64-bit hosts error ("...%d...", N)
868 was used to print both 32- and 64-bit integers N, which relied on
869 undefined behavior.
870 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
871 New macro.
872 * lisp.h (error, verror): Mark as printf-like functions.
873 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
874 Report overflow in size calculations when allocating printf buffer.
875 Do not truncate output string at its first null byte.
876 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
877 Truncate the output at a character boundary, since vsnprintf does not
878 do that.
879 * charset.c (check_iso_charset_parameter): Convert internal
880 character to string before calling 'error', since %c now has the
881 printf meaning.
882 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
883 overflow when computing char to be passed to 'error'. Do not
884 pass Lisp_Object to 'error'; pass the integer instead.
885 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
886 formatted with plain %d.
887
b189fa66
PE
888 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
889
bff87ef0
PE
890 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
891
7e2cac20
PE
892 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
893
ce4d90b5
PE
894 * xterm.c (x_catch_errors): Remove duplicate declaration.
895
266c9547
PE
896 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
897
79c49ad2
PE
898 * xdisp.c, lisp.h (message_nolog): Remove; unused.
899
368f4090
JM
9002011-04-10 Jim Meyering <meyering@redhat.com>
901
902 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
903 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
904 return ssize_t not "int", and use size_t as the buffer length.
905 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
906 * gnutls.h: Update declarations.
907 * process.c (read_process_output): Use ssize_t, to match.
908 (send_process): Likewise.
909
a32d4040
CY
9102011-04-09 Chong Yidong <cyd@stupidchicken.com>
911
912 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
913
8546720e 9142011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 915
8546720e
GM
916 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
917 unsigned char, to match FcChar8 type definition.
aac0c6e3 918
8546720e
GM
919 * xterm.c (handle_one_xevent):
920 * xmenu.c (create_and_show_popup_menu):
921 * xselect.c (x_decline_selection_request)
922 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 923
0a2f5c1a 9242011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
925
926 Fix some uses of `int' instead of EMACS_INT.
927 * search.c (string_match_1, fast_string_match)
928 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
929 (scan_buffer, find_next_newline_no_quit)
930 (find_before_next_newline, search_command, Freplace_match)
931 (Fmatch_data): Make some `int' variables be EMACS_INT.
932
933 * xdisp.c (display_count_lines): 3rd argument and return value now
934 EMACS_INT. All callers changed.
935 (pint2hrstr): Last argument is now EMACS_INT.
936
937 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
938 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
939 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
940 (decode_coding_utf_16, decode_coding_emacs_mule)
941 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
942 (decode_coding_ccl, decode_coding_charset)
943 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
944 (decode_coding_iso_2022, decode_coding_emacs_mule)
945 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
946 <char_offset, last_offset>: Declare EMACS_INT.
947 (encode_coding_utf_8, encode_coding_utf_16)
948 (encode_coding_emacs_mule, encode_invocation_designation)
949 (encode_designation_at_bol, encode_coding_iso_2022)
950 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
951 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
952 Declare EMACS_INT.
953 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
954 (encode_invocation_designation): Last argument P_NCHARS is now
955 EMACS_INT.
956 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
957 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
958
959 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
960 All users changed.
961
962 * ccl.c (Fccl_execute_on_string): Declare some variables
963 EMACS_INT.
964
8546720e 9652011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
966
967 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
968
4e19a977
CS
9692011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
970
971 * process.c (Fformat_network_address): Doc fix.
972
87302331
R
9732011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
974
975 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
976
cbb59342
CY
9772011-04-08 Chong Yidong <cyd@stupidchicken.com>
978
979 * keyboard.c (read_char): Call Lisp function help-form-show,
980 instead of using internal_with_output_to_temp_buffer.
981 (Qhelp_form_show): New var.
e0d38eeb 982 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
983
984 * print.c (internal_with_output_to_temp_buffer): Function deleted.
985
986 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
987
e67a13ab
CY
9882011-04-06 Chong Yidong <cyd@stupidchicken.com>
989
990 * process.c (Flist_processes): Removed to Lisp.
991 (list_processes_1): Deleted.
992
973f782d
EZ
9932011-04-06 Eli Zaretskii <eliz@gnu.org>
994
7c106b1e
EZ
995 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
996
973f782d
EZ
997 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
998
41cf7d1a 9992011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 1000
ca23cc88
PE
1001 Fix more problems found by GCC 4.6.0's static checks.
1002
f390e2d5
PE
1003 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
1004
42eea0d0
PE
1005 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
1006
b69769da 1007 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 1008
f9541e84
PE
1009 * xdisp.c (vmessage): Mark as a printf-like function.
1010
13841b55
PE
1011 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
1012
c136c10f
PE
1013 * sound.c (sound_warning): Don't crash if arg contains a printf format.
1014
5e2d4a30
PE
1015 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
1016 printf-like functions.
1017 (tiff_load): Add casts to remove these marks before passing them
1018 to system-supplied API.
1019
583f48b9
PE
1020 * eval.c (Fsignal): Remove excess argument to 'fatal'.
1021
b25d760e
PE
1022 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
1023 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
1024 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
1025 directly, rather than having caller test rule sign. This avoids
1026 some unnecessary tests.
1027 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
1028 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
1029 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 1030
bc7b6697 1031 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 1032 (xfont_open): Avoid unnecessary tests.
bc7b6697 1033
27ccc379
PE
1034 * composite.c (composition_gstring_put_cache): Use unsigned integer.
1035
dcd5c89a
PE
1036 * composite.h, composite.c (composition_gstring_put_cache):
1037 Use EMACS_INT, not int, for length.
1038
b13a45c6
PE
1039 * composite.h (COMPOSITION_DECODE_REFS): New macro,
1040 breaking out part of COMPOSITION_DECODE_RULE.
1041 (COMPOSITION_DECODE_RULE): Use it.
1042 * composite.c (get_composition_id): Remove unused local vars,
1043 by using the new macro.
1044
1e792e4d
PE
1045 * textprop.c (set_text_properties_1): Change while to do-while,
1046 since the condition is always true at first.
1047
dc6c6455 1048 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
1049 (interval_deletion_adjustment): Return unsigned value.
1050 All uses changed.
dc6c6455 1051
aba7731a
PE
1052 * process.c (list_processes_1, create_pty, read_process_output):
1053 (exec_sentinel): Remove vars that were set but not used.
afd4052b 1054 (create_pty): Remove unnecessary "volatile"s.
bc57d757 1055 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 1056 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 1057 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 1058
fdfc4bf3
PE
1059 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
1060
fca8fe46 1061 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 1062 (update_syntax_table): Use unsigned instead of int.
fca8fe46 1063
06a0259a 1064 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 1065 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 1066 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 1067
e7b9e80f
PE
1068 * print.c (print_error_message): Avoid int overflow.
1069
56201685
PE
1070 * font.c (font_list_entities): Redo for clarity,
1071 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
1072
78834453 1073 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 1074 (font_score): Avoid potential overflow in diff calculation.
78834453 1075
0bc0b309 1076 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 1077 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 1078
e610eaca
PE
1079 * eval.c (funcall_lambda): Rename local to avoid shadowing.
1080
b895abce
PE
1081 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
1082 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
1083 can always succeed if overflow has undefined behavior.
1084
1f1d9321 1085 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 1086 (wordify): Omit three unnecessary tests.
1f1d9321 1087
c59478bc
PE
1088 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
1089 All callers changed. This avoids the need for an unused var.
1090
79b73827
PE
1091 * casefiddle.c (casify_region): Remove var that is set but not used.
1092
a4db5dfe
PE
1093 * dired.c (file_name_completion): Remove var that is set but not used.
1094
43aae36e
PE
1095 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
1096
2a47c44d 1097 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 1098 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 1099
a37c69bf
PE
1100 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
1101 Check for integer overflow on size calculations.
1102
328ab8e7
PE
1103 * buffer.c (Fprevious_overlay_change): Remove var that is set
1104 but not used.
1105
e5a2a5cb
PE
1106 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
1107 Remove vars that are set but not used.
8d84a6eb 1108 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 1109 (timer_check_2): Mark vars as initialized.
e5a2a5cb 1110
a60e5f68
PE
1111 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
1112
f661cb61 1113 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 1114 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 1115
f0397f5a
PE
1116 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
1117 that are set but not used.
1118
8664db06 1119 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 1120 if XCreateBitmapFromData fails (Bug#8410).
8664db06 1121
6abdaa4a
PE
1122 * xselect.c (x_get_local_selection, x_handle_property_notify):
1123 Remove vars that are set but not used.
1124
0ce7538d 1125 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 1126 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 1127
9ae848fc
PE
1128 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
1129 Remove var that is set but not used.
0b918413
PE
1130 (scroll_bar_windows_size): Now size_t, not int.
1131 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
1132 Check for overflow.
9ae848fc 1133
a5a62657
PE
1134 * xfaces.c (realize_named_face): Remove vars that are set but not used.
1135 (map_tty_color) [!defined MSDOS]: Likewise.
1136
5c5cdd39
PE
1137 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
1138
66ebf983
PE
1139 * coding.c: Remove vars that are set but not used.
1140 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
1141 All callers changed.
1142 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
1143 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
1144 (decode_coding_charset): Remove vars that are set but not used.
1145
1be4d761
PE
1146 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
1147 that is set but not used.
1148
47553fa8
PE
1149 * print.c (print_object): Remove var that is set but not used.
1150
1f7196bf 1151 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
1152 The gnulib version avoids calling malloc in the usual case,
1153 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
1154 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
1155 * filelock.c (current_lock_owner): Likewise.
1156 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
1157 * sysdep.c: Include allocator.h, careadlinkat.h.
1158 (emacs_no_realloc_allocator): New static constant.
1159 (emacs_readlink): New function.
fdb61804
PE
1160 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
1161 ../lib/careadlinkat.h.
d1fdcab7 1162
f84c17c7
SM
11632011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
1164
1165 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
1166 first non-nil return value).
1167
ef3862ad
JD
11682011-04-03 Jan Djärv <jan.h.d@swipnet.se>
1169
1170 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
1171 if not defined (Bug#8403).
1172
376a7006
JB
11732011-04-02 Juanma Barranquero <lekktu@gmail.com>
1174
1175 * xdisp.c (display_count_lines): Remove parameter `start',
1176 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1177 (get_char_face_and_encoding): Remove parameter `multibyte_p',
1178 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1179 (fill_stretch_glyph_string): Remove parameters `row' and `area',
1180 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
1181 and thereabouts. All callers changed.
1182 (get_per_char_metric): Remove parameter `f', unused since
1183 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1184
6ca3801d
JM
11852011-04-02 Jim Meyering <meyering@redhat.com>
1186
1187 do not dereference NULL upon failed strdup
1188 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
1189 (ns_get_family): Likewise.
1190
d8e2b5ba
JB
11912011-04-02 Juanma Barranquero <lekktu@gmail.com>
1192
1193 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
1194
8c74fcbd
JD
11952011-04-02 Jan Djärv <jan.h.d@swipnet.se>
1196
1197 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
1198 later (Bug#8403).
1199
7200d79c
SM
12002011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
1201
03408648 1202 Add lexical binding.
7200d79c 1203
03408648
SM
1204 * window.c (Ftemp_output_buffer_show): New fun.
1205 (Fsave_window_excursion):
1206 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
1207
1208 * lread.c (lisp_file_lexically_bound_p): New function.
1209 (Fload): Bind Qlexical_binding.
1210 (readevalloop): Remove `evalfun' arg.
1211 Bind Qinternal_interpreter_environment.
1212 (Feval_buffer): Bind Qlexical_binding.
1213 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
1214 Mark as dynamic.
1215 (syms_of_lread): Declare `lexical-binding'.
1216
1217 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
1218
1219 * keyboard.c (eval_dyn): New fun.
1220 (menu_item_eval_property): Use it.
ca105506
SM
1221
1222 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 1223
03408648
SM
1224 * fns.c (concat, mapcar1): Accept byte-code-functions.
1225
1226 * eval.c (Fsetq): Handle lexical vars.
1227 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
1228 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
1229 (FletX, Flet): Obey lexical binding.
1230 (Fcommandp): Handle closures.
1231 (Feval): New `lexical' arg.
1232 (eval_sub): New function extracted from Feval. Use it almost
1233 everywhere where Feval was used. Look up vars in lexical env.
1234 Handle closures.
1235 (Ffunctionp): Move from subr.el.
1236 (Ffuncall): Handle closures.
1237 (apply_lambda): Remove `eval_flags'.
1238 (funcall_lambda): Handle closures and new byte-code-functions.
1239 (Fspecial_variable_p): New function.
1240 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
1241 but without exporting it to Lisp.
23aba0ea 1242
23aba0ea 1243 * doc.c (Fdocumentation, store_function_docstring):
03408648 1244 * data.c (Finteractive_form): Handle closures.
23aba0ea 1245
03408648
SM
1246 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
1247 interactive spec.
ba83908c 1248
03408648
SM
1249 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
1250 byte-codes.
1251 (exec_byte_code): New function extracted from Fbyte_code to handle new
1252 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 1253
03408648 1254 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 1255
03408648 1256 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 1257
e2abce01
JB
12582011-03-31 Juanma Barranquero <lekktu@gmail.com>
1259
1260 * xdisp.c (redisplay_internal): Fix prototype.
1261
63696a73 12622011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 1263
63696a73
EZ
1264 * xdisp.c (SCROLL_LIMIT): New macro.
1265 (try_scrolling): Use it when setting scroll_limit. Limit
1266 scrolling to 100 screen lines.
1267 (redisplay_window): Even when falling back on "recentering",
1268 position point in the window according to scroll-conservatively,
1269 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
1270
1271 (try_scrolling): When point is above the window, allow searching
1272 as far as scroll_max, or one screenful, to compute vertical
1273 distance from PT to the scroll margin position. This prevents
1274 try_scrolling from unnecessarily failing when
1275 scroll-conservatively is set to a value slightly larger than the
1276 window height. Clean up the case of PT below the margin at bottom
1277 of window: scroll_max can no longer be INT_MAX. When aggressive
1278 scrolling is in use, don't let point enter the opposite scroll
1279 margin as result of the scroll.
1280 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
1281 threshold of 100 lines for never-recentering scrolling.
1282
e4cc2dfc
JB
12832011-03-31 Juanma Barranquero <lekktu@gmail.com>
1284
1285 * dispextern.h (move_it_by_lines):
1286 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
1287 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
1288 (message_log_check_duplicate): Remove parameters `prev_bol' and
1289 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1290 (redisplay_internal): Remove parameter `preserve_echo_area',
1291 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
1292
1293 * indent.c (Fvertical_motion):
1294 * window.c (window_scroll_pixel_based, Frecenter):
1295 Don't pass `need_y_p' to `move_it_by_lines'.
1296
1c470562
SM
12972011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
1298
44f230aa
SM
1299 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
1300 steal a few bits to be more compact.
1301 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
1302 Remove unneeded casts.
1303
1c470562
SM
1304 * bytecode.c (Fbyte_code): CAR and CDR can GC.
1305
888adce9
ZK
13062011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
1307
1308 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
1309 binding" message (bug#7967).
1310
f838ed7b
PE
13112011-03-30 Paul Eggert <eggert@cs.ucla.edu>
1312
77861b95
PE
1313 Fix more problems found by GCC 4.6.0's static checks.
1314
de6dbc14
PE
1315 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
1316 Remove unused local var.
1317
f838ed7b
PE
1318 * editfns.c (Fmessage_box): Remove unused local var.
1319
792c7b2b
PE
1320 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
1321 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1322 Omit unused local vars.
c499e557 1323 * window.c (shrink_windows): Omit unused local var.
b01a1c29 1324 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
1325 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
1326 Omit unused local var.
1327
ba0165e1
PE
1328 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
1329 Don't assume string length fits in int.
32ad8845 1330 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 1331 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 1332
3c59b4c9
PE
1333 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
1334 instead of alloca (Bug#8344).
1335
a3eed478 1336 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 1337 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 1338
eb4d412d
PE
1339 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
1340
1658b401
PE
1341 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
1342 concerns.
1343
1344 * term.c (produce_glyphless_glyph): Remove unnecessary test.
1345
1346 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 1347
9a2c6e05
PE
1348 * keyboard.c (syms_of_keyboard): Use the same style as later
1349 in this function when indexing through an array. This also
1350 works around GCC bug 48267.
1351
03d0a109
PE
1352 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
1353
44f730c8
PE
1354 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
1355
fe75f926
PE
1356 * chartab.c (sub_char_table_ref_and_range): Redo for slight
1357 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
1358
ffa8c828
PE
1359 * keyboard.c, keyboard.h (num_input_events): Now size_t.
1360 This avoids undefined behavior on integer overflow, and is a bit
1361 more convenient anyway since it is compared to a size_t variable.
1362
c5101a77
PE
1363 Variadic C functions now count arguments with size_t, not int.
1364 This avoids an unnecessary limitation on 64-bit machines, which
1365 caused (substring ...) to crash on large vectors (Bug#8344).
1366 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
1367 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 1368 All variadic functions and their callers changed accordingly.
c5101a77
PE
1369 (struct gcpro.nvars): Now size_t, not int. All uses changed.
1370 * data.c (arith_driver, float_arith_driver): Likewise.
1371 * editfns.c (general_insert_function): Likewise.
1372 * eval.c (struct backtrace.nargs, interactive_p)
1373 (internal_condition_case_n, run_hook_with_args, apply_lambda)
1374 (funcall_lambda, mark_backtrace): Likewise.
1375 * fns.c (concat): Likewise.
1376 * frame.c (x_set_frame_parameters): Likewise.
1377 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
1378 0 if not found, not -1. All callers changed.
1379
dd3f25f7
PE
1380 * alloc.c (garbage_collect): Don't assume stack size fits in int.
1381 (stack_copy_size): Now size_t, not int.
1382 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
1383
461c2ab9
JB
13842011-03-28 Juanma Barranquero <lekktu@gmail.com>
1385
1386 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
1387 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1388 All callers changed.
1389
1390 * lisp.h (multibyte_char_to_unibyte):
1391 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
1392 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1393 * character.h (CHAR_TO_BYTE8):
1394 * cmds.c (internal_self_insert):
1395 * editfns.c (general_insert_function):
1396 * keymap.c (push_key_description):
1397 * search.c (Freplace_match):
1398 * xdisp.c (message_dolog, set_message_1): All callers changed.
1399
f6d62986
SM
14002011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1401
1402 * keyboard.c (safe_run_hook_funcall): New function.
1403 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
1404 don't set the hook to nil, but remove the offending function instead.
1405 (Qcommand_hook_internal): Remove, unused.
1406 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
1407 Vcommand_hook_internal.
1408
1409 * eval.c (enum run_hooks_condition): Remove.
1410 (funcall_nil, funcall_not): New functions.
1411 (run_hook_with_args): Call each function through a `funcall' argument.
1412 Remove `cond' argument, now redundant.
1413 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
1414 (Frun_hook_with_args_until_failure): Adjust accordingly.
1415 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
1416
1db5b1ad
JB
14172011-03-28 Juanma Barranquero <lekktu@gmail.com>
1418
1419 * dispextern.h (string_buffer_position): Remove declaration.
1420
1421 * print.c (strout): Remove parameter `multibyte', unused since
1422 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
1423
1424 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
1425 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
1426 All callers changed.
1427
1428 * w32.c (_wsa_errlist): Use braces for struct initializers.
1429
1430 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
1431 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
1432 All callers changed.
1433 (string_buffer_position): Likewise. Also, make static (it's never
1434 used outside xdisp.c).
1435 (cursor_row_p): Remove parameter `w', unused since
1436 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
1437 (decode_mode_spec): Remove parameter `precision', introduced during
1438 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
1439 All callers changed.
1440
5ffb62aa
JD
14412011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1442
1443 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
1444
461c2ab9 14452011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
1446
1447 * nsterm.m (ns_menu_bar_is_hidden): New variable.
1448 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
1449 (ns_update_auto_hide_menu_bar): New functions.
1450 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
1451 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
1452 ns_constrain_all_frames.
1453 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
1454 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
1455
5c380ffb
JD
14562011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1457
1458 * nsmenu.m (runDialogAt): Remove argument to timer_check.
1459
9af30bdf
GM
14602011-03-27 Glenn Morris <rgm@gnu.org>
1461
1462 * syssignal.h: Replace RETSIGTYPE with void.
1463 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
1464 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
1465 Replace SIGTYPE with void everywhere.
1466 * s/usg5-4-common.h (SIGTYPE): Remove definition.
1467 * s/template.h (SIGTYPE): Remove commented out definition.
1468
e2abce01
JB
14692011-03-26 Eli Zaretskii <eliz@gnu.org>
1470
1471 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
1472 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
1473
f868cd8a
JB
14742011-03-26 Juanma Barranquero <lekktu@gmail.com>
1475
59eb0929
JB
1476 * w32.c (read_unc_volume): Use parameter `henum', instead of
1477 global variable `wget_enum_handle'.
1478
1479 * keymap.c (describe_vector): Remove parameters `indices' and
1480 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
1481 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
1482
f868cd8a
JB
1483 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
1484
1485 * keyboard.c (timer_check): Remove parameter `do_it_now',
1486 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
1487 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
1488 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
1489
1490 * keyboard.c (read_char):
1491 * w32menu.c (w32_menu_display_help):
1492 * xmenu.c (show_help_event, menu_help_callback):
1493 Adjust calls to `show_help_echo'.
1494
1495 * gtkutil.c (xg_maybe_add_timer):
1496 * keyboard.c (readable_events):
1497 * process.c (wait_reading_process_output):
1498 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
1499
1500 * insdel.c (adjust_markers_gap_motion):
1501 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
1502 (gap_left, gap_right): Don't call it.
1503
2ecf6fdb
CY
15042011-03-25 Chong Yidong <cyd@stupidchicken.com>
1505
1506 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
1507 incurred during fontification.
1508
6b1f9ba4
JB
15092011-03-25 Juanma Barranquero <lekktu@gmail.com>
1510
1511 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
1512 (DEFVAR_PER_BUFFER): Don't pass it.
1513
1514 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
1515 (scrolling_window): Don't pass it.
1516
0f4a96b5
JB
15172011-03-25 Juanma Barranquero <lekktu@gmail.com>
1518
1519 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
1520
1521 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
1522 and `suffix'.
1523 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
1524 of variables specific to SELinux and computation of `encoded_absname'.
1525
1526 * image.c (XPutPixel): Remove unused variable `height'.
1527
1528 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
1529
1530 * unexw32.c (get_section_info): Remove unused variable `section'.
1531
1532 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
1533 (system_process_attributes): Remove unused variable `sess'.
1534 (sys_read): Remove unused variable `err'.
1535
1536 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
1537 (w32_wnd_proc): Remove unused variable `isdead'.
1538 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
1539 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
1540 (x_create_tip_frame): Remove unused variable `tem'.
1541
1542 * w32inevt.c (w32_console_read_socket):
1543 Remove unused variable `no_events'.
1544
1545 * w32term.c (x_draw_composite_glyph_string_foreground):
1546 Remove unused variable `width'.
1547
1149507c
JB
15482011-03-24 Juanma Barranquero <lekktu@gmail.com>
1549
1550 * w32term.c (x_set_glyph_string_clipping):
1551 Don't pass uninitialized region to CombineRgn.
1552
9c88f339
JB
15532011-03-23 Juanma Barranquero <lekktu@gmail.com>
1554
1555 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
1556 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
1557 (Fx_close_connection): Remove unused variable `i'.
1558
1559 * w32font.c (w32font_draw): Return number of glyphs.
1560 (w32font_open_internal): Remove unused variable `i'.
1561 (w32font_driver): Add missing initializer.
1562
1563 * w32menu.c (utf8to16): Remove unused variable `utf16'.
1564 (fill_in_menu): Remove unused variable `items_added'.
1565
1566 * w32term.c (last_mouse_press_frame): Remove static global variable.
1567 (w32_clip_to_row): Remove unused variable `f'.
1568 (x_delete_terminal): Remove unused variable `i'.
1569
1570 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
1571 (NOTHING): Remove unused static global variable.
1572 (uniscribe_check_otf): Remove unused variable `table'.
1573 (uniscribe_font_driver): Add missing initializers.
1574
dee091a3
JD
15752011-03-23 Julien Danjou <julien@danjou.info>
1576
1577 * term.c (Fsuspend_tty, Fresume_tty):
1578 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
1579 * window.c (temp_output_buffer_show):
1580 * insdel.c (signal_before_change):
1581 * frame.c (Fhandle_switch_frame):
1582 * fileio.c (Fdo_auto_save):
1583 * emacs.c (Fkill_emacs):
1584 * editfns.c (save_excursion_restore):
1585 * cmds.c (internal_self_insert):
1586 * callint.c (Fcall_interactively):
1587 * buffer.c (Fkill_all_local_variables):
1588 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
1589 Use Frun_hooks.
0f4a96b5 1590 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
1591 unconditionnaly since it does the check itself.
1592
2c520ab5 15932011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 1594
c9c49752
PE
1595 Fix more problems found by GCC 4.5.2's static checks.
1596
8abc3f12
PE
1597 * coding.c (encode_coding_raw_text): Avoid unnecessary test
1598 the first time through the loop, since we know p0 < p1 then.
1599 This also avoids a gcc -Wstrict-overflow warning.
1600
a2d26660
PE
1601 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
1602 leading to a memory leak, possible in functions like
1603 load_charset_map_from_file that can allocate an unbounded number
b12ef411 1604 of objects (Bug#8318).
a2d26660 1605
916c72e9
PE
1606 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
1607 that could (at least in theory) be that large.
1608
19ab8a18
PE
1609 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
1610 This is less likely to overflow, and avoids undefined behavior if
1611 overflow does occur. All callers changed. Use strtoul to scan
1612 for the unsigned long integer.
b7cbbd6f
PE
1613 (pint2hrstr): Simplify and tune code slightly.
1614 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 1615
f0641eff
PE
1616 * scroll.c (do_scrolling): Work around GCC bug 48228.
1617 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
1618
7f650bb9
PE
1619 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
1620 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
1621 (validate_x_resource_name): Simplify count usage.
1622 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 1623
37dd57d1
PE
1624 * fileio.c (Fcopy_file): Report error if fchown or fchmod
1625 fail (Bug#8306).
81e56e61 1626
699979fc 1627 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 1628
401bf9b4
PE
1629 * process.c (Fmake_network_process): Use socklen_t, not int,
1630 where POSIX says socklen_t is required in portable programs.
1631 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 1632 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
1633 (Fmake_network_process, server_accept_connection):
1634 (wait_reading_process_output, read_process_output):
1635 Likewise.
1636
b93aacde
PE
1637 * process.c: Rename or move locals to avoid shadowing.
1638 (list_processes_1, Fmake_network_process):
1639 (read_process_output_error_handler, exec_sentinel_error_handler):
1640 Rename or move locals.
4dc343ee 1641 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 1642 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 1643 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 1644 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 1645 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 1646
af8a867c 1647 Make tparam.h and terminfo.c consistent.
44f230aa
SM
1648 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
1649 Include tparam.h instead, since it declares them.
af8a867c
PE
1650 * cm.h (PC): Remove extern decl; tparam.h now does this.
1651 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
1652 * terminfo.c: Include tparam.h, to check interfaces.
1653 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
1654 (tparam): Adjust signature to match interface in tparam.h;
1655 this removes some undefined behavior. Check that outstring and len
1656 are zero, which they always are with Emacs.
1657 * tparam.h (PC, BC, UP): New extern decls.
1658
0248044d 1659 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 1660 (xftfont_open): Rename locals to avoid shadowing.
0248044d 1661
8ff096c1 1662 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
1663 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
1664 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 1665 (ftfont_list): Remove unused local.
49eaafba
PE
1666 (get_adstyle_property, ftfont_pattern_entity):
1667 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
1668 Rename locals to avoid shadowing.
8ff096c1 1669
e2be39f6
PE
1670 * xfont.c (xfont_list_family): Mark var as initialized.
1671
c9735e30
PE
1672 * xml.c (make_dom): Now static.
1673
8f5201ae
PE
1674 * composite.c (composition_compute_stop_pos): Rename local to
1675 avoid shadowing.
b246f932
PE
1676 (composition_reseat_it): Remove unused locals.
1677 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 1678 (composition_update_it): Mark var as initialized.
11b61122
PE
1679 (find_automatic_composition): Mark vars as initialized,
1680 with a FIXME (Bug#8290).
8f5201ae 1681
760fbc2c
PE
1682 character.h: Rename locals to avoid shadowing.
1683 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
1684 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
1685 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
1686 (BUF_DEC_POS): Be more systematic about renaming local temporaries
1687 to avoid shadowing.
1688
ff08eb85
PE
1689 * textprop.c (property_change_between_p): Remove; unused.
1690
fc7bf025
PE
1691 * intervals.c (interval_start_pos): Now static.
1692
235d7abc
PE
1693 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
1694
44f230aa
SM
1695 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
1696 Rename locals to avoid shadowing.
3e7d6594 1697
50060332
PE
1698 * sound.c (wav_play, au_play, Fplay_sound_internal):
1699 Fix pointer signedness.
d01f234b 1700 (alsa_choose_format): Remove unused local var.
c83b8872
PE
1701 (wav_play): Initialize a variable to 0, to prevent undefined
1702 behavior (Bug#8278).
50060332 1703
c4fc4e30
PE
1704 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
1705
918436ed
PE
1706 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
1707
c939f91b
PE
1708 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
1709 clobbering (Bug#8298).
b9c7f648
PE
1710 * sysdep.c (sys_subshell): Likewise.
1711 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 1712
6bd8c144
PE
1713 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
1714 This should get cleaned up, so that child_setup has the
1715 same signature on all platforms.
1716
7710357c 1717 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 1718 (relocate_fd): Rename locals to avoid shadowing.
7710357c 1719
c59da222
CY
17202011-03-22 Chong Yidong <cyd@stupidchicken.com>
1721
1722 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
1723 not to be necessary, and produces flickering.
1724
66b87493
GM
17252011-03-20 Glenn Morris <rgm@gnu.org>
1726
1727 * config.in: Remove file.
1728
45b6f6d5
JB
17292011-03-20 Juanma Barranquero <lekktu@gmail.com>
1730
1731 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
1732 are now in src/globals.h.
1733 (syms_of_minibuf): Remove spurious & from previous change.
1734
3ec03f7e
LL
17352011-03-20 Leo <sdl.web@gmail.com>
1736
1737 * minibuf.c (completing-read-function): New variable.
1738 (completing-read-default): Rename from completing-read.
1739 (completing-read): Call completing-read-function.
1740
b14e3e21
CY
17412011-03-19 Juanma Barranquero <lekktu@gmail.com>
1742
1743 * xfaces.c (Fx_load_color_file):
1744 Read color file from absolute filename (bug#8250).
1745
f2b726e6
JB
17462011-03-19 Juanma Barranquero <lekktu@gmail.com>
1747
1748 * makefile.w32-in: Update dependencies.
1749
09f6ff02
EZ
17502011-03-17 Eli Zaretskii <eliz@gnu.org>
1751
1752 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
1753
29a6015a
PE
17542011-03-17 Paul Eggert <eggert@cs.ucla.edu>
1755
a3a6c54e
PE
1756 Fix more problems found by GCC 4.5.2's static checks.
1757
b766f867
PE
1758 * process.c (make_serial_process_unwind, send_process_trap):
1759 (sigchld_handler): Now static.
1760
be02381c
PE
1761 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
1762 That way, the code declares only the vars that it needs.
1763 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
1764 * s/cygwin.h (PTY_ITERATION): Likewise.
1765 * s/darwin.h (PTY_ITERATION): Likewise.
1766 * s/gnu-linux.h (PTY_ITERATION): Likewise.
1767
57048744
PE
1768 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
1769 * process.c (allocate_pty): Don't declare stb unless it's needed.
1770
7914961c 1771 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
1772 (CONSTANTLIM): Remove; unused.
1773 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
1774 Define only if needed.
7914961c 1775
b3967b18
PE
1776 * unexelf.c (unexec): Name an expression,
1777 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
1778 Use a different way to cause a compilation error if anyone uses
1779 n rather than nn, a way that does not involve shadowing.
73366a00 1780 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 1781
29a6015a
PE
1782 * deps.mk (unexalpha.o): Remove; unused.
1783
43cfc33e 1784 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 1785 * unexec.h: New file.
ce701a33
PE
1786 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
1787 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
1788 Depend on unexec.h.
1789 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
1790 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
1791 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 1792 Change as necessary to match prototype in unexec.h.
ce701a33 1793
01f44d5a
PE
1794 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
1795 shadowing.
4f63c6bb 1796 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 1797
a6670b0b
PE
1798 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
1799 Rename locals to avoid shadowing.
1800
cef2010d 1801 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 1802 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 1803
d4d7173a
PE
1804 * print.c (Fredirect_debugging_output): Fix pointer signedess.
1805
f08b802a
PE
1806 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
1807 warning when compiling print.c.
1808
3ddb0639
PE
1809 * font.c (font_unparse_fcname): Abort in an "impossible" situation
1810 instead of using an uninitialized var.
5ad03b97 1811 (font_sort_entities): Mark var as initialized.
3ddb0639 1812
170a2692
PE
1813 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
1814
e663c700
PE
1815 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
1816 pointers to constants.
89bc529a 1817 (font_parse_fcname): Remove unused vars.
7b81e2d0 1818 (font_delete_unmatched): Now static.
ea838e10 1819 (font_get_spec): Remove; unused.
13a547c6
PE
1820 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
1821 (font_update_drivers, Ffont_get_glyphs, font_add_log):
1822 Rename or move locals to avoid shadowing.
e663c700 1823
2a80c887 1824 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 1825 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 1826
1384fa33 1827 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 1828 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 1829
8b2c52e9
PE
1830 * alloc.c (mark_backtrace): Move decl from here ...
1831 * lisp.h: ... to here, so that it can be checked.
1832
475545b5 1833 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 1834 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
1835 (lisp_indirect_variable): Name an expression,
1836 to avoid gcc -Wbad-function-cast warning.
1faed8ae 1837 (Fdefvar): Rename locals to avoid shadowing.
475545b5 1838
b1349114 1839 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 1840 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 1841 Use const pointer when appropriate.
b1349114 1842
a2928364
PE
1843 * lisp.h (get_system_name, get_operating_system_release):
1844 Move decls here, to check interfaces.
1845 * process.c (get_operating_system_release): Move decl to lisp.h.
1846 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
1847 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
1848 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
1849 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
1850 (Fformat_time_string, Fencode_time, Finsert_char):
1851 (Ftranslate_region_internal, Fformat):
1852 Rename or remove local vars to avoid shadowing.
9710023e 1853 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 1854
a415e694
PE
1855 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
1856 avoid shadowing.
1857
8ef4622d
PE
1858 * lisp.h (eassert): Check that the argument compiles, even if
1859 ENABLE_CHECKING is not defined.
1860
946f9a5b
PE
1861 * data.c (Findirect_variable): Name an expression, to avoid
1862 gcc -Wbad-function-cast warning.
112396d6 1863 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 1864 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
1865 (Fmake_variable_buffer_local, Fmake_local_variable):
1866 Mark variables as initialized.
52746918 1867 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 1868
e5aab7e7 1869 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
1870 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
1871 Rename locals to avoid shadowing.
dff45157
PE
1872 (mark_stack): Move local variables into the #ifdef region where
1873 they're used.
7bc26fdb
PE
1874 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
1875 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
1876 needed otherwise.
1877 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
1878 (GC_STRING_CHARS): Remove; not used.
d40d4be1 1879 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 1880
e5aab7e7
PE
1881 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
1882 avoids undefined behavior in theory.
1883
4da60324
PE
1884 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
1885
88043301
PE
1886 Use functions, not macros, for up- and down-casing (Bug#8254).
1887 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1888 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
1889 to use the following functions instead of these macros.
1890 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
1891 EMACS_INT, since callers assume the returned value fits in int.
1892 (upcase1): Likewise, for UPCASE_TABLE.
1893 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 1894 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 1895 the race-condition problem in the old DOWNCASE.
88043301 1896
19ed5445
PE
1897 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
1898 Rename locals to avoid shadowing.
1899 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
1900 (regex_compile, re_search_2, re_match_2_internal):
1901 Remove unused local vars.
952db0d7
PE
1902 (FREE_VAR): Rewrite so as not to use empty "else",
1903 which gcc can warn about.
da053e48 1904 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
1905 (RETALLOC_IF): Define only if needed.
1906 (WORDCHAR_P): Likewise. This one is never needed, but is used
1907 only in a comment talking about a compiler bug, so put inside
1908 the #if 0 of that comment.
1909 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
1910 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
1911 Remove; unused.
19ed5445 1912
1f3561e4 1913 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
1914 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
1915 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 1916
ded6f8f7
PE
1917 * search.c (simple_search): Remove unused var.
1918
dbd37a95
PE
1919 * dired.c (compile_pattern): Move decl from here ...
1920 * lisp.h: ... to here, so that it can be checked.
1921 (struct re_registers): New forward decl.
1922
7e47afad
PE
1923 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
1924
85f24f61
PE
1925 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
1926 All uses changed.
1927 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
1928 Rename locals to avoid shadowing.
5671df8f 1929 (Fvertical_motion): Mark locals as initialized.
85f24f61 1930
181aa2be 1931 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 1932 (casify_region): Mark local as initialized.
181aa2be 1933
930d429c
PE
1934 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
1935
7082eac6
PE
1936 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
1937 New macros, so that the caller can use some names other than
1938 gcpro1, gcpro2, etc.
1939 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
1940 of the new macros.
1941 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
1942 argument, for consistency with GCPRO2_VAR, etc: it is now the
1943 prefix of the variable, not the variable itself. All uses
1944 changed.
38b2c076
PE
1945 * dired.c (directory_files_internal, file_name_completion):
1946 Rename locals to avoid shadowing.
1947
15206ed9
PE
1948 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
1949 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
1950 dired.c's scmp function, had undefined behavior.
1951 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1952 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
1953 * buffer.h: ... to here, because these macros use current_buffer,
1954 and the new implementation with inline functions needs to have
1955 current_buffer in scope now, rather than later when the macros
1956 are used.
1957 (downcase, upcase1): New static inline functions.
1958 (DOWNCASE, UPCASE1): Reimplement using these functions.
1959 This avoids undefined behavior in expressions like
1960 DOWNCASE (x) == DOWNCASE (y), which previously suffered
1961 from race conditions in accessing the global variables
1962 case_temp1 and case_temp2.
1963 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
1964 * lisp.h (case_temp1, case_temp2): Remove their decls.
1965 * character.h (ASCII_CHAR_P): Move from here ...
1966 * lisp.h: ... to here, so that the inline functions mentioned
1967 above can use them.
1968
4a6bea26
PE
1969 * dired.c (directory_files_internal_unwind): Now static.
1970
f14b7e14
PE
1971 * fileio.c (file_name_as_directory, directory_file_name):
1972 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
1973 Now static.
2893f146
PE
1974 (file_name_as_directory): Use const pointers when appropriate.
1975 (Fexpand_file_name): Likewise. In particular, newdir might
1976 point at constant storage, so make it a const pointer.
fd4ead52 1977 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
1978 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
1979 signedness issues.
f839df0c
PE
1980 (Fset_file_times, Finsert_file_contents, auto_save_error):
1981 Rename locals to avoid shadowing.
f14b7e14 1982
5716756e 1983 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
1984 (Ftry_completion, Fall_completions): Rename or remove locals
1985 to avoid shadowing.
5716756e 1986
b4c3046a
PE
1987 * marker.c (bytepos_to_charpos): Remove; unused.
1988
b45db522
PE
1989 * lisp.h (verify_bytepos, count_markers): New decls,
1990 so that gcc does not warn that these functions aren't declared.
1991
85876d07
PE
1992 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
1993 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 1994 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 1995 (copy_text): Remove unused local var.
85876d07 1996
03d78a21 1997 * filelock.c (within_one_second): Now static.
b3dd38ab 1998 (lock_file_1): Rename local to avoid shadowing.
03d78a21 1999
5df8f01b
PE
2000 * buffer.c (fix_overlays_before): Mark locals as initialized.
2001 (fix_start_end_in_overlays): Likewise. This function should be
2002 simplified by using pointers-to-pointers, but that's a different
2003 matter.
b1d876f1 2004 (switch_to_buffer_1): Now static.
8f54f30a
PE
2005 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
2006 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 2007
a70072c9 2008 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 2009 Fix pointer signedness issue.
edced198
PE
2010 (sys_subshell): Mark local as volatile if checking for lint,
2011 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 2012 (MAXPATHLEN): Define only if needed.
a70072c9 2013
a0977c44
PE
2014 * process.c (serial_open, serial_configure): Move decls from here ...
2015 * systty.h: ... to here, so that they can be checked.
2016
a884fdcc
PE
2017 * fns.c (get_random, seed_random): Move extern decls from here ...
2018 * lisp.h: ... to here, so that they can be checked.
2019
604efe86 2020 * sysdep.c (reset_io): Now static.
b8950c94 2021 (wait_for_termination_signal): Remove; unused.
604efe86 2022
38fc62d9
PE
2023 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
2024 (copy_keymap_item, append_key, push_text_char_description):
2025 Now static.
1004a21a 2026 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 2027 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
2028 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
2029 (describe_map_tree):
2030 Rename locals to avoid shadowing.
38fc62d9 2031
2f2650da
PE
2032 * keyboard.c: Declare functions static if they are not used elsewhere.
2033 (echo_char, echo_dash, cmd_error, top_level_2):
2034 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
2035 (read_char, kbd_buffer_get_event, make_lispy_position):
2036 (make_lispy_event, make_lispy_movement, apply_modifiers):
2037 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
2038 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
2039 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 2040 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 2041 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 2042
a053e86c 2043 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
2044 (mark_kboards): Move decl here ...
2045 * alloc.c (mark_kboards): ... from here.
a053e86c 2046
4752793e
PE
2047 * lisp.h (force_auto_save_soon): New decl.
2048
74f10ca7 2049 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
2050 (DEFINE_DUMMY_FUNCTION): New macro.
2051 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
2052 Use it.
c03cd23f
PE
2053 (main): Add casts to avoid warnings
2054 if GCC considers string literals to be constants.
74f10ca7 2055
022e70d4
PE
2056 * lisp.h (fatal_error_signal): Add decl, since it's exported.
2057
59d6fe83
PE
2058 * dbusbind.c: Pointer signedness fixes.
2059 (xd_signature, xd_append_arg, xd_initialize):
2060 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2061 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2062 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
2063 (Fdbus_register_signal): Use SSDATA when the context wants char *.
2064
78320123
PE
2065 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
2066 if GCC considers string literals to be constants.
49cebcca 2067 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 2068
35ac2a97
SM
20692011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
2070
fb103ca9
SM
2071 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
2072 (print_preprocess, print_object): New macro to fix last change.
2073
35ac2a97
SM
2074 * print.c (print_preprocess): Don't forget font objects.
2075
62973b41
JB
20762011-03-16 Juanma Barranquero <lekktu@gmail.com>
2077
2078 * emacs.c (USAGE3): Doc fixes.
2079
0e48bb22
AS
20802011-03-15 Andreas Schwab <schwab@linux-m68k.org>
2081
2082 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
2083 structure.
2084
7684e57b
JB
20852011-03-14 Juanma Barranquero <lekktu@gmail.com>
2086
2087 * lisp.h (VWindow_system, Qfile_name_history):
2088 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
2089 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
2090 (w32_system_caret_x, w32_system_caret_y): Declare extern.
2091
2092 * w32select.c: Don't #include "keyboard.h".
c96bbc66 2093 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
2094
2095 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
2096 * w32console.c (detect_input_pending, read_input_pending)
2097 (encode_terminal_code):
2098 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
2099 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
2100 (w32_system_caret_y, Qfile_name_history):
2101 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
2102 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
2103 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
2104 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
2105 * w32proc.c (Qlocal, report_file_error):
2106 * w32term.c (Vwindow_system, updating_frame):
2107 * w32uniscribe.c (initialized, uniscribe_font_driver):
2108 Remove unneeded extern declarations.
2109
2aa46d6c
CY
21102011-03-14 Chong Yidong <cyd@stupidchicken.com>
2111
c96bbc66 2112 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 2113
cffc6f3b
CY
21142011-03-13 Chong Yidong <cyd@stupidchicken.com>
2115
2116 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
2117 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
2118 These macros can no longer be used for assignment.
2119
44f230aa
SM
2120 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2121 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
2122 (record_buffer_markers, fetch_buffer_markers): New functions for
2123 recording and fetching special buffer markers.
2124 (set_buffer_internal_1, set_buffer_temp): Use them.
2125
2126 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
2127
2128 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
2129
2130 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
2131 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
2132
2133 * xdisp.c (hscroll_window_tree):
2134 (reconsider_clip_changes): Use PT instead of BUF_PT.
2135
d251f04b
EZ
21362011-03-13 Eli Zaretskii <eliz@gnu.org>
2137
2138 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
2139 $(EMACS_ROOT)/lib/intprops.h.
2140
f0c77cd1
PE
21412011-03-13 Paul Eggert <eggert@cs.ucla.edu>
2142
3eca4629
PE
2143 Fix more problems found by GCC 4.5.2's static checks.
2144
7c86ee98
PE
2145 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
2146 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
2147 (xg_free_frame_widgets): Make it clear that a local variable is
2148 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
2149 (gdk_window_get_screen): Make it clear that this macro is needed
2150 only if USE_GTK_TOOLTIP.
1e5524e7
PE
2151 (int_gtk_range_get_value): New function, which avoids a diagnostic
2152 from gcc -Wbad-function-cast.
2153 (xg_set_toolkit_scroll_bar_thumb): Use it.
2154 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
2155 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
2156 (get_utf8_string, xg_get_file_with_chooser):
2157 Rename locals to avoid shadowing.
2158 (create_dialog): Move locals to avoid shadowing.
7c86ee98 2159
41729b81
PE
2160 * xgselect.c (xg_select): Remove unused var.
2161
f0c77cd1
PE
2162 * image.c (four_corners_best): Mark locals as initialized.
2163 (gif_load): Initialize transparent_p to zero (Bug#8238).
2164 Mark another local as initialized.
ec6cf4c6 2165 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 2166
ce0ad53d 2167 * image.c (clear_image_cache): Now static.
d5d5a617 2168 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 2169 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
2170 (x_edge_detection): Remove unnecessary cast that
2171 gcc -Wbad-function-cast diagnoses.
2037898d 2172 (gif_load): Fix pointer signedness.
6ae141d6
PE
2173 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
2174 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 2175
33383987 21762011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 2177
d32df629
PE
2178 Improve quality of tests for time stamp overflow.
2179 For example, without this patch (encode-time 0 0 0 1 1
2180 1152921504606846976) returns the obviously-bogus value (-948597
2181 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
2182 reports time overflow. See
2183 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
2184 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
2185 * editfns.c: Include limits.h and intprops.h.
2186 (TIME_T_MIN, TIME_T_MAX): New macros.
2187 (time_overflow): Move earlier, to before first use.
2188 (hi_time, lo_time): New functions, for an accurate test for
2189 out-of-range times.
2190 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
2191 (Fget_internal_run_time): Don't assume time_t fits in int.
2192 (make_time): Use list2 instead of Fcons twice.
2193 (Fdecode_time): More accurate test for out-of-range times.
2194 (check_tm_member): New function.
2195 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
2196 (lisp_time_argument): Don't rely on undefined left-shift and
2197 right-shift behavior when checking for time stamp overflow.
8be6f318 2198
fe31d94c
PE
2199 * editfns.c (time_overflow): New function, refactoring common code.
2200 (Fformat_time_string, Fdecode_time, Fencode_time):
2201 (Fcurrent_time_string): Use it.
2202
8be6f318
PE
2203 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
2204 * dired.c (make_time): Move to ...
2205 * editfns.c (make_time): ... here.
2206 * systime.h: Note the move.
2207
09d9db2c 22082011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 2209
126bc0dc
YM
2210 * fringe.c (update_window_fringes): Remove unused variables.
2211
c47cbdfd
YM
2212 * unexmacosx.c (copy_data_segment): Also copy __got section.
2213 (Bug#8223)
2214
7ac80be9
EZ
22152011-03-12 Eli Zaretskii <eliz@gnu.org>
2216
c96bbc66 2217 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
2218 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
2219 Constify `char *' arguments and their references according to
2220 prototypes in tparam.h.
2221
ecb0f94d 2222 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 2223
7ac80be9
EZ
2224 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
2225 Adapt all references accordingly.
2226
2227 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
2228
ef1fd07e
TT
22292011-03-11 Tom Tromey <tromey@redhat.com>
2230
2231 * buffer.c (syms_of_buffer): Remove obsolete comment.
2232
7ef4b50c
EZ
22332011-03-11 Eli Zaretskii <eliz@gnu.org>
2234
2235 * termhooks.h (encode_terminal_code): Declare prototype.
2236
2237 * msdos.c (encode_terminal_code): Don't declare prototype.
2238
2239 * term.c (encode_terminal_code): Now external again, used by
2240 w32console.c and msdos.c.
2241
44f230aa
SM
2242 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
2243 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 2244
4b1ec863 22452011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 2246
1714f52b 2247 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 2248
4b1ec863
PE
2249 * fringe.c (update_window_fringes): Mark locals as initialized
2250 (Bug#8227).
2251 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 2252
524c7aa6
PE
2253 * alloc.c (mark_fringe_data): Move decl from here ...
2254 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
2255 to check its interface.
2256 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
2257
a5c0af81 2258 * fontset.c (free_realized_fontset): Now static.
7519b8cd 2259 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 2260 (fontset_font): Mark local as initialized.
a9a06e0b 2261 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 2262
b4716021
PE
2263 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
2264
811e9bac 2265 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 2266 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
2267 (x_own_selection, Fx_disown_selection_internal): Rename locals
2268 to avoid shadowing.
2269 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 2270
7e3ab302
PE
2271 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
2272 so that the caller can use some name other than gcpro1.
2273 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
2274 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2275 (Fx_backspace_delete_keys_p):
2276 Use them to avoid shadowing, and rename vars to avoid shadowing.
2277 (x_decode_color, x_set_name, x_window): Now static.
6b437900 2278 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 2279 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
2280 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
2281 Remove unused locals.
7e3ab302
PE
2282 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2283 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
2284 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
2285 macros.
f78faa98 2286
e2b13473
PE
2287 * xterm.h (x_mouse_leave): New decl.
2288
77f23912
PE
2289 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
2290 Remove unused functions.
cdf4ba58
PE
2291 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
2292 (x_calc_absolute_position): Now static.
7411c686 2293 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 2294 Don't declare local "event" unless it's used.
ed7bf3a5
PE
2295 (x_iconify_frame, x_free_frame_resources): Don't declare locals
2296 unless they are used.
38d0b34a
PE
2297 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
2298 (x_fatal_error_signal): Remove; not used.
a6067996
PE
2299 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
2300 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
2301 (x_error_catcher, x_connection_closed, x_error_handler):
2302 (x_error_quitter, xembed_send_message, x_iconify_frame):
2303 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 2304 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 2305 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 2306
44f230aa
SM
2307 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
2308 Rename or move locals to avoid shadowing.
6b463e58 2309 (tty_defined_color, merge_face_heights): Now static.
5967d051 2310 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
2311 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
2312 does not deduce is never used uninitialized.
73719eba
PE
2313 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
2314 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 2315
426994c3 2316 * terminal.c (store_terminal_param): Now static.
5489860b 2317
032f1620 2318 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 2319 (set_frame_menubar): Remove unused local.
d4323972 2320 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
2321 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
2322 since they might point to immutable storage.
281585b0
PE
2323 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
2324 since it's unused otherwise.
032f1620 2325
367c19e5 2326 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 2327 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
2328 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
2329 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 2330 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
2331 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
2332 does not deduce are never used uninitialized.
70739cbe 2333
07b48fa9
PE
2334 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
2335
8868a238 2336 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
2337 * window.c (window_loop, size_window):
2338 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 2339
7e5cf297 2340 * window.c (display_buffer): Now static.
d6550a9f
PE
2341 (size_window): Mark variables that gcc -Wuninitialized
2342 does not deduce are never used uninitialized.
a586633d
PE
2343 * window.h (check_all_windows): New decl, to forestall
2344 gcc -Wmissing-prototypes diagnostic.
5b555da1 2345 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 2346
f6095868
PE
2347 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
2348 shadowing.
2349 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
2350 Include <limits.h>.
2351 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
2352 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
2353 (load_charset_map): Mark variables that gcc -Wuninitialized
2354 does not deduce are never used uninitialized.
53df7c11 2355 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 2356
f38b440c
PE
2357 * coding.c (coding_set_source, coding_set_destination):
2358 Use "else { /* comment */ }" rather than "else /* comment */;"
2359 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
2360 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
2361 a block, when the outer 'i' will do.
2362 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
2363 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
2364 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
2365 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
2366 (Fdecode_sjis_char, Fdefine_coding_system_internal):
2367 Rename locals to avoid shadowing.
2368 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
2369 * coding.c (emacs_mule_char, encode_invocation_designation):
2370 Now static, since they're not used elsewhere.
413bb2db 2371 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 2372 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
2373 (decode_coding_emacs_mule): Mark variables that gcc
2374 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
2375 (detect_coding_iso_2022): Initialize a local variable that might
2376 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 2377 this initialization is needed. (Bug#8211)
5f58e762
PE
2378 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
2379 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
2380 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
2381 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
2382 Remove unused macros.
f38b440c 2383
232b38b9 2384 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 2385 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 2386 * character.c (string_count_byte8): Likewise.
232b38b9 2387
fb90da1b
PE
2388 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
2389 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
2390
fb93dbc2
PE
2391 * chartab.c (copy_sub_char_table): Now static, since it's not used
2392 elsewhere.
5c156ace
PE
2393 (sub_char_table_ref_and_range, char_table_ref_and_range):
2394 Rename locals to avoid shadowing.
bbcd0949 2395 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 2396
7d3b3862 2397 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 2398 (BIDI_BOB): Remove unused macro.
7d3b3862 2399
6be7d3da
PE
2400 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
2401 deduce are never used uninitialized.
c2ed9c8b 2402 * term.c (encode_terminal_code): Likewise.
6be7d3da 2403
75f8807f 2404 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 2405
50938595
PE
2406 * tparam.h: New file.
2407 * term.c, tparam.h: Include it.
2408 * deps.mk (term.o, tparam.o): Depend on tparam.h.
2409 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
2410 Move these decls to tparam.h, and make them agree with what
2411 is actually in tparam.c. The previous trick of using incompatible
2412 decls in different modules does not conform to the C standard.
2413 All callers of tparam changed to use tparam's actual API.
2414 * tparam.c (tparam1, tparam, tgoto):
2415 Use const pointers where appropriate.
2416
fbceeba2
PE
2417 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
2418 * cm.h (struct cm): Likewise.
2419 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
2420 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
2421 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
2422 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
2423 (turn_on_face, init_tty): Likewise.
2424 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 2425
7f3f1250
PE
2426 * term.c (term_mouse_position): Rename local to avoid shadowing.
2427
e6ca6543
PE
2428 * alloc.c (mark_ttys): Move decl from here ...
2429 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
2430
c40f8d15
AS
24312011-03-11 Andreas Schwab <schwab@linux-m68k.org>
2432
2433 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
2434
cfe0661d
JB
24352011-03-09 Juanma Barranquero <lekktu@gmail.com>
2436
2437 * search.c (compile_pattern_1): Remove argument regp, unused since
2438 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
2439 (compile_pattern): Don't pass it.
2440
0afb4571
J
24412011-03-08 Jan Djärv <jan.h.d@swipnet.se>
2442
2443 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
2444 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
2445 for ! HAVE_GTK3.
2446 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
2447
2448 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
2449
2450 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
2451 gdk_window_get_screen, gdk_window_get_geometry,
2452 gdk_x11_window_lookup_for_display and GDK_KEY_g.
2453 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
2454 (xg_get_pixbuf_from_pixmap): New function.
2455 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
2456 to Pixmap, take frame as parameter, remove GdkColormap parameter.
2457 Call xg_get_pixbuf_from_pixmap instead of
2458 gdk_pixbuf_get_from_drawable.
2459 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
2460 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
2461 (xg_check_special_colors): Use GtkStyleContext and its functions
2462 for HAVE_GTK3.
2463 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
2464 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
2465 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
2466 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
2467 Call gtk_widget_get_preferred_size.
0afb4571
J
2468 (xg_frame_resized): gdk_window_get_geometry only takes 5
2469 parameters.
44f230aa
SM
2470 (xg_win_to_widget, xg_event_is_for_menubar):
2471 Call gdk_x11_window_lookup_for_display.
0afb4571
J
2472 (xg_set_widget_bg): New function.
2473 (delete_cb): New function.
2474 (xg_create_frame_widgets): connect delete-event to delete_cb.
2475 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
2476 (xg_set_background_color): Call xg_set_widget_bg.
2477 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
2478 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
2479 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
2480 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
2481 if ! HAVE_GTK3.
2482 (update_frame_tool_bar): Call gtk_widget_hide.
2483 (xg_initialize): Use GDK_KEY_g.
2484
2485 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
2486 if ! HAVE_GTK3
2487 (x_session_initialize): Call gdk_x11_set_sm_client_id.
2488
2489 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
2490 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
2491 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
2492
1c2cc4ef
JB
24932011-03-08 Juanma Barranquero <lekktu@gmail.com>
2494
2495 * w32xfns.c (select_palette): Check success of RealizePalette against
2496 GDI_ERROR, not zero.
2497
33383987 2498See ChangeLog.11 for earlier changes.
aac0c6e3
MR
2499
2500;; Local Variables:
2501;; coding: utf-8
aac0c6e3
MR
2502;; End:
2503
33383987 2504 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
2505
2506 This file is part of GNU Emacs.
2507
2508 GNU Emacs is free software: you can redistribute it and/or modify
2509 it under the terms of the GNU General Public License as published by
2510 the Free Software Foundation, either version 3 of the License, or
2511 (at your option) any later version.
2512
2513 GNU Emacs is distributed in the hope that it will be useful,
2514 but WITHOUT ANY WARRANTY; without even the implied warranty of
2515 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
2516 GNU General Public License for more details.
2517
2518 You should have received a copy of the GNU General Public License
2519 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.