Move more stuff from src/s to configure
[bpt/emacs.git] / src / ChangeLog
CommitLineData
308aab79
GM
12012-07-12 Glenn Morris <rgm@gnu.org>
2
7ccad002
GM
3 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
4 * s/hpux10-20.h (RUN_TIME_REMAP):
5 * s/bsd-common.h (TABDLY): Move to configure.
6
7 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
8
9 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
10
ea0bbd17
GM
11 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
12 (BROKEN_SIGPOLL): Let configure set them.
13
14 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 15
308aab79
GM
16 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
17 * s/template.h: Move NARROWPROTO to configure.
18
ee1cf5cf
GM
192012-07-11 Glenn Morris <rgm@gnu.org>
20
30fe9bf4
GM
21 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
22 unused since 2011-01-17 change to systty.h.
23
ee1cf5cf
GM
24 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
25 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
26 Move HAVE_PTYS and HAVE_SOCKETS to configure.
27
63e47e07
PE
282012-07-11 Paul Eggert <eggert@cs.ucla.edu>
29
30 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
31
c43fb4c3
GM
322012-07-11 Glenn Morris <rgm@gnu.org>
33
34 * s/darwin.h, s/gnu-linux.h, s/template.h:
35 Move INTERRUPT_INPUT to configure.
36
e8df9267
DA
372012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
38
39 Minor adjustments to interning code.
40 * lisp.h (intern, intern_c_string): Redefine as static inline
41 wrappers for intern_1 and intern_c_string_1, respectively.
42 (intern_1, intern_c_string_1): Rename prototypes.
2bce5643
DA
43 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
44 Vobarray checking.
e8df9267
DA
45 * font.c (font_intern_prop): Likewise. Adjust comment.
46 * w32font.c (intern_font_name): Likewise.
47
34348bd4
AS
482012-07-11 Andreas Schwab <schwab@linux-m68k.org>
49
d96a1e0c
AS
50 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
51
34348bd4
AS
52 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
53 of Fcar/Fcdr if possible.
54 * font.c (check_otf_features): Likewise.
55 * fontset.c (Fnew_fontset): Likewise.
56 * gnutls.c (Fgnutls_boot): Likewise.
57 * minibuf.c (read_minibuf): Likewise.
58 * msdos.c (IT_set_frame_parameters): Likewise.
59 * xmenu.c (Fx_popup_dialog): Likewise.
60 * w32menu.c (Fx_popup_dialog): Likewise.
61
c8add24e
GM
622012-07-11 Glenn Morris <rgm@gnu.org>
63
4b575b3c
GM
64 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
65 since nothing has defined it on these platforms.
66
09f4e3b0
GM
67 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
68 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
69
172bedef
GM
70 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
71 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
72 Move CLASH_DETECTION to configure.
73
249685df
GM
74 * s/gnu.h: Remove file, which is now empty.
75
c8add24e
GM
76 * s/gnu.h, s/gnu-linux.h:
77 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
78
b41253a3
JW
792012-07-11 John Wiegley <johnw@newartisans.com>
80
81 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
82 function attribute, so we only use it if it exists in the
83 compiler.
84
d923b542
DA
852012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
86
87 Avoid call to strlen in fast_c_string_match_ignore_case.
88 * search.c (fast_c_string_match_ignore_case): Change to use
89 length argument. Adjust users accordingly.
90 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
91
5ebbef1d
PE
922012-07-11 Paul Eggert <eggert@cs.ucla.edu>
93
bb352260
PE
94 Assume mkdir, rmdir.
95 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
96 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
97
57054ddd
PE
98 Assume rename.
99 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
100
b747d3f7
PE
101 Assume perror.
102 * s/hpux10-20.h (HAVE_PERROR): Remove.
103 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
104 Remove dummy definition, as this problem was obsolete long ago.
105
5ebbef1d
PE
106 Assume strerror.
107 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
108
984e7f30
DA
1092012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
110
111 Avoid calls to strlen in font processing functions.
112 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
d923b542 113 (font_open_by_name): Change to use length argument. Adjust
984e7f30 114 users accordingly.
d923b542
DA
115 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
116 Adjust prototypes.
117 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
118 Change to return ptrdiff_t.
984e7f30
DA
119 (xfont_list_pattern, xfont_match): Use length returned by
120 xfont_decode_coding_xlfd.
121 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
122
20e94fdd
GM
1232012-07-11 Glenn Morris <rgm@gnu.org>
124
9d596af3
GM
125 * s/darwin.h, s/freebsd.h, s/netbsd.h:
126 Move DONT_REOPEN_PTY to configure.
127
20e94fdd
GM
128 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
129 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
130
e99a530f
PE
1312012-07-10 Paul Eggert <eggert@cs.ucla.edu>
132
22ffb973
PE
133 Remove "#define unix" that is no longer needed (Bug#11905).
134 * s/aix4-2.h (unix): Remove; no longer needed.
135
e9a9ae03
PE
136 EMACS_TIME simplification (Bug#11875).
137 This replaces macros (which typically do not work in GDB)
138 with functions, typedefs and enums, making the code easier to debug.
139 The functional style also makes code easier to read and maintain.
140 * systime.h: Include <sys/time.h> on all hosts, not just if
141 WINDOWSNT, since 'struct timeval' is needed in general.
142 (EMACS_TIME): Now a typedef, not a macro.
143 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
144 not macros.
145 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
146 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
147 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
148 (EMACS_TIME_LE): Now functions, not macros.
149 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
150 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
151 which are not functions. All uses rewritten to use:
152 (make_emacs_time): New function.
153 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
154 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
155 not functions. All uses rewritten to use the following, respectively:
156 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
157 (add_emacs_time, sub_emacs_time): New functions.
158 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
159 * fileio.c (Fcopy_file):
160 * xterm.c (XTflash): Get the current time closer to when it's used.
161 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
162
ffacb126
PE
163 * bytecode.c (targets): Suppress -Woverride-init warnings.
164
e99a530f
PE
165 Simplify by avoiding confusing use of strncpy etc.
166 * doc.c (Fsnarf_documentation):
167 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
168 * frame.c (Fmake_terminal_frame):
169 * gtkutil.c (get_utf8_string):
170 * lread.c (openp):
171 * nsmenu.m (ns_update_menubar):
172 * regex.c (regerror):
173 Prefer memcpy to strncpy and strncat when either will do.
174 * fileio.c (Fsubstitute_in_file_name):
175 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
176 (menu_separator_name_p):
177 * nsmenu.m (ns_update_menubar):
178 Prefer memcmp to strncmp when either will do.
179 * nsterm.m: Include <ftoastr.h>.
180 (ns_get_color):
181 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
182 Prefer snprintf to strncpy.
183 * nsterm.m (ns_term_init):
184 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
185 * nsterm.m (ns_term_init):
186 Avoid the need for strncpy, by using build_string or
187 make_unibyte_string directly. Use dtoastr, not snprintf.
188 * process.c (Fmake_network_process): Diagnose service names that
189 are too long, rather than silently truncating them or creating
190 non-null-terminated names.
191 (Fnetwork_interface_info): Likewise, for interface names.
192 * sysdep.c (system_process_attributes) [GNU_LINUX]:
193 Prefer sprintf to strncat.
194 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
195 Prefer vsnprintf to vsprintf + strncpy.
196
c59592b3
GM
1972012-07-10 Glenn Morris <rgm@gnu.org>
198
199 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
200 Clarify fallback case.
201
7d7bbefd
DA
2022012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
203
204 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
205 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
206 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 207 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
208 where argument type is known to be a Lisp_Cons.
209
3a4c8000
TT
2102012-07-10 Tom Tromey <tromey@redhat.com>
211
212 * bytecode.c (BYTE_CODE_THREADED): New macro.
213 (BYTE_CODES): New macro. Replaces all old byte-code defines.
214 (enum byte_code_op): New type.
215 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
216 (exec_byte_code): Use them. Use token threading when applicable.
217
2a0213a6
DA
2182012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
219
220 Optimize pure C strings initialization.
221 * lisp.h (make_pure_string): Fix prototype.
222 (build_pure_c_string): New function, defined as static inline. This
223 provides a better opportunity to optimize away calls to strlen when
224 the function is called with compile-time constant argument.
225 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
226 argument, adjust users accordingly. Use build_pure_c_string where
227 appropriate.
228 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
229 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
230 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
231
cb1caeaf
DA
2322012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
233
234 Avoid calls to strlen in miscellaneous functions.
235 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
236 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
237 * lread.c (openp): Likewise.
238
c293e30c
DA
2392012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
240
241 Avoid calls to strlen in path processing functions.
242 * fileio.c (file_name_as_directory): Add comment. Change to add
243 srclen argument and return the length of result. Adjust users
244 accordingly.
245 (directory_file_name): Fix comment. Change to add srclen argument,
cb1caeaf 246 swap 1st and 2nd arguments to obey the common convention. Adjust
c293e30c
DA
247 users accordingly.
248 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
249
9e059e3f
GM
2502012-07-10 Glenn Morris <rgm@gnu.org>
251
d02eb359
GM
252 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
253 Move PENDING_OUTPUT_COUNT definition to configure.
254
882cf227
GM
255 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
256 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
257 * s/gnu.h (DATA_START): Move definitions to configure.
258
af6e839f
GM
259 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
260 We include usg5-4-common.h, which defines them both.
261
40289a12
GM
262 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
263 O_RDONLY already includes it).
264
9e059e3f
GM
265 Stop ns builds setting the EMACSLOADPATH environment variable.
266 * nsterm.m (ns_load_path): Rename from ns_init_paths.
267 Now it does not set EMACSLOADPATH, just returns the load-path string.
268 * nsterm.h: Update accordingly.
269 * lread.c [HAVE_NS]: Include nsterm.h.
270 (init_lread) [HAVE_NS]: Use ns_load_path.
271 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
272
7c4e8ec0
GM
2732012-07-09 Glenn Morris <rgm@gnu.org>
274
d4f600ff
GM
275 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
276 since the included bsd-common.h does so.
277
cbb31951
GM
278 Stop ns builds setting the EMACSPATH environment variable.
279 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
280 (ns_init_paths): Do not set EMACSPATH.
281 * nsterm.h (ns_exec_path): Add it.
282 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
283 Use ns_exec_path.
284
7c4e8ec0
GM
285 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
286
26bccfae
PE
2872012-07-09 Paul Eggert <eggert@cs.ucla.edu>
288
a0bee46f
PE
289 * process.c (wait_reading_process_output): 'waitchannels' was unset
290 when read_kbd || !NILP (wait_for_cell); fix this.
291
5994c183
PE
292 Add GCC-style 'const' attribute to functions that can use it.
293 * character.h (char_resolve_modifier_mask):
294 * keyboard.h (make_ctrl_char):
295 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
296 (init_character_once, next_almost_prime, init_fns, init_image)
297 (flush_pending_output, init_sound):
298 * mem-limits.h (start_of_data):
299 * menu.h (finish_menu_items):
300 Add ATTRIBUTE_CONST.
301 * emacs.c (DEFINE_DUMMY_FUNCTION):
302 Declare the dummy function with ATTRIBUTE_CONST.
303 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
304 Add decls with ATTRIBUTE_CONST.
305
26bccfae
PE
306 Minor improvements to make_formatted_string.
307 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
308 where int is good enough, as vsprintf returns an int.
309 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
310
a8290ec3
DA
3112012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
312
313 Use make_formatted_string to avoid double length calculation.
314 * lisp.h (make_formatted_string): New prototype.
315 * alloc.c (make_formatted_string): New function.
316 * buffer.c (Fgenerate_new_buffer_name): Use it.
317 * dbus.c (syms_of_dbusbind): Likewise.
318 * editfns.c (Fcurrent_time_zone): Likewise.
319 * filelock.c (get_boot_time): Likewise.
320 * frame.c (make_terminal_frame, set_term_frame_name)
321 (x_report_frame_params): Likewise.
322 * image.c (gs_load): Likewise.
323 * minibuf.c (get_minibuffer): Likewise.
324 * msdos.c (dos_set_window_size): Likewise.
325 * process.c (make_process): Likewise.
326 * xdisp.c (ensure_echo_area_buffers): Likewise.
327 * xsettings.c (apply_xft_settings): Likewise.
328
d01ba2f1
GM
3292012-07-09 Glenn Morris <rgm@gnu.org>
330
331 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
332 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
333 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
334 * nsterm.h (ns_etc_directory): Add it.
335 * callproc.c [HAVE_NS]: Include nsterm.h.
336 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
337
f1f924b6
DA
3382012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
339
340 Move marker debugging code under MARKER_DEBUG.
341 * marker.c (MARKER_DEBUG): Move marker debugging code under
342 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
343 for bootstrap with --enable-checking (~3x slowdown reported
344 by Juanma Barranquero <lekktu@gmail.com>).
345 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
346
ab531b66
PE
3472012-07-08 Paul Eggert <eggert@cs.ucla.edu>
348
349 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
350 See <http://bugs.gnu.org/11825#29>.
351
c4b3bc8a
EZ
3522012-07-08 Eli Zaretskii <eliz@gnu.org>
353
354 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
355 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
356 (display_line): Add commentary about displaying truncation glyphs
357 on GUI frames.
358 (produce_special_glyphs): Move here from term.c.
359
360 * term.c (produce_special_glyphs): Move to xdisp.c.
361
362 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
363 section.
c4b3bc8a 364
b676b881
AS
3652012-07-07 Andreas Schwab <schwab@linux-m68k.org>
366
f17c5273
AS
367 * xdisp.c (display_line): Avoid warning about implicit declaration
368 of FRAME_FONT.
369
298819b9
AS
370 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
371
b676b881
AS
372 * lisp.h: Remove empty conditional.
373
6045c4fd
PE
3742012-07-07 Paul Eggert <eggert@cs.ucla.edu>
375
b3350bf9
PE
376 * lread.c (load_path_check): Now static.
377
6045c4fd
PE
378 Fix some minor --with-ns problems found by static checking.
379 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
380 (x_set_font) [!HAVE_X_WINDOWS]:
381 * image.c (xpm_load_image) [HAVE_NS]:
382 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
383 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
384 Remove unused local.
385 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
386 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
387 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
388 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
389 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
390 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
391 Fix pointer signedness problem.
392 * xfaces.c (FRAME_X_FONT_TABLE):
393 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
394
929e7845
GM
3952012-07-07 Glenn Morris <rgm@gnu.org>
396
397 * lread.c (load_path_check): New function, split from init_lread.
398 (init_lread): Reorganize. Motivation:
399 If EMACSLOADPATH is set, check/warn about that rather than the
400 defaults, which we are not going to use. Hence we can remove
401 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
402 Don't warn if site-lisp directories are missing.
403 If not installed, start from a blank load-path, since
404 PATH_LOADSEARCH refers to the eventual installation directories.
405
58dd0aa4
EZ
4062012-07-07 Eli Zaretskii <eliz@gnu.org>
407
408 Support truncation and continuation glyphs on GUI frames, when
409 fringes are disabled. (Bug#11832)
410 * xdisp.c (init_iterator): Get dimensions of truncation and
411 continuation glyphs even if on GUI frames. Adjust
412 it->last_visible_x on GUI frames when the left or right fringes,
413 or both, are absent.
414 (start_display, move_it_in_display_line_to): Handle the case of a
415 GUI frame without a fringe to display continuation or truncation
416 glyphs.
417 (insert_left_trunc_glyphs): Support GUI frames: make sure
418 truncation glyphs overwrite enough glyphs from the current line to
419 have sufficient space in pixels.
420 (display_line): Support truncation and continuation glyphs on GUI
421 frames. If some spare pixels are left on the line after inserting
422 the truncation glyphs, fill that space with a stretch glyph of a
423 suitably computed width.
424
425 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
426 produce_glyphs, to support GUI sessions.
427
31571fd7
PE
4282012-07-07 Paul Eggert <eggert@cs.ucla.edu>
429
5a16b9bc
PE
430 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
431
f3047c75
PE
432 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
433
31571fd7
PE
434 Do not require float-time's arg to fit in time_t (Bug#11825).
435 This works better on hosts where time_t is unsigned, and where
436 float-time is applied to the (negative) difference between two times.
437 * editfns.c (decode_time_components): Last arg is now double *,
438 not int *, and means to store all the result as a double, without
439 worrying about whether the seconds part fits in time_t.
440 All callers changed.
441 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
442 All callers changed.
443 (Ffloat_time): Do not fail merely because the specified time falls
444 outside of time_t range.
445
4516fbef
GM
4462012-07-07 Glenn Morris <rgm@gnu.org>
447
448 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
449 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
450 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
451
07adc2c6
JB
4522012-07-07 Juanma Barranquero <lekktu@gmail.com>
453
454 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
455 Update dependencies.
456
457 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
458
fd573f31
PE
4592012-07-06 Paul Eggert <eggert@cs.ucla.edu>
460
fee5959d
PE
461 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
462 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
463 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
464 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
465 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
466 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
467
fd573f31
PE
468 * xfont.c (compare_font_names): Redo to omit the need for casts.
469
ddadbc0e
AS
4702012-07-06 Andreas Schwab <schwab@linux-m68k.org>
471
fca8d6b6
AS
472 * xfns.c (Fx_change_window_property): Doc fix.
473 * w32fns.c (Fx_change_window_property): Doc fix.
474
ddadbc0e
AS
475 * w32fns.c (Fx_window_property): Accept the same arguments as the
476 X Windows version. Doc fix.
477 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
478
f247498e
JB
4792012-07-06 Juanma Barranquero <lekktu@gmail.com>
480 Eli Zaretskii <eliz@gnu.org>
481
482 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
483 Windows-specific code from nt/config.nt moved here.
484 Obsolete settings removed.
485
216ee680
PE
4862012-07-06 Paul Eggert <eggert@cs.ucla.edu>
487
488 * process.c: Avoid unnecessary calls to gettime.
489 (wait_reading_process_output): Don't get the time of day
490 when gobbling data immediately and not waiting, as there's no need
491 for it in that case. This removes a FIXME.
492
bdd091e4
JD
4932012-07-06 Jan Djärv <jan.h.d@swipnet.se>
494
495 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
496 is defined (Bug#11768).
497
9d44f8ce
DA
4982012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
499
500 Fix marker debugging code.
501 * marker.c (byte_char_debug_check): Do not perform the check
502 if buffer is not multibyte.
090bd7cb
JB
503 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
504 Call byte_char_debug_check with correct arguments.
9d44f8ce 505
90fc4786
DA
5062012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
507
508 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
509 * marker.c (byte_char_debug_check, count_markers):
510 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
511 (byte_debug_flag): Remove.
512 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
513 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
514
7b7ae965
DA
5152012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
516
4e57b342
DA
517 Avoid code repetition in marker-related functions.
518 * marker.c (attach_marker): New function.
519 (Fset_marker, set_marker_restricted, set_marker_both)
520 (set_marker_restricted_both): Use it.
521 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
522 Consistently rename charno to charpos.
523 (marker_position): Add eassert.
524 (marker_byte_position): Convert to eassert.
525
5262012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
527
528 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 529 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 530 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 531
657924ff
DA
5322012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
533
534 Introduce fast path for the widely used marker operation.
535 * alloc.c (build_marker): New function.
536 * lisp.h (build_marker): New prototype.
537 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
538 * composite.c (autocmp_chars): Likewise.
539 * editfns.c (buildmark): Remove.
540 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
541 (save_restriction_save): Use build_marker.
542 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
543 * window.c (save_window_save): Likewise.
544
041a49a6
DA
5452012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
546
547 Do not use Fdelete_overlay in delete_all_overlays
548 to avoid redundant calls to unchain_overlay.
549 * buffer.c (drop_overlay): New function.
550 (delete_all_overlays, Fdelete_overlay): Use it.
551 * minibuf.c (get_minibuffer): Fix comment.
552
7dca65a4
PE
5532012-07-06 Paul Eggert <eggert@cs.ucla.edu>
554
555 Port to OpenBSD 5.1 amd64.
556 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
557 This is needed for OpenBSD, and should be harmless on all BSD systems.
558 Also, include <sys/sysctl.h>, as it should be available on all
559 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
560 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
561 use p_pid member, not kp_proc.pid.
562
8eb876e2
GM
5632012-07-06 Glenn Morris <rgm@gnu.org>
564
565 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
566
38182d90
PE
5672012-07-05 Paul Eggert <eggert@cs.ucla.edu>
568
569 More xmalloc and related cleanup.
570 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
571 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
572 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
573 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
574 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
575 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
576 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
577 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
578 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
579 * xterm.c:
580 Omit needless casts involving void * pointers and allocation.
581 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
582 as the former is more robust if P's type is changed.
583 Prefer xzalloc to xmalloc + memset 0.
584 Simplify malloc-or-realloc to realloc.
585 Don't worry about xmalloc returning a null pointer.
586 Prefer xstrdup to xmalloc + strcpy.
587 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
588 growing it.
589 * keyboard.c (apply_modifiers_uncached): Prefer local array to
590 alloca of a constant.
591
6dd5a677
EZ
5922012-07-05 Eli Zaretskii <eliz@gnu.org>
593
594 * xdisp.c (display_line): Fix horizontal pixel coordinates when
595 hscroll is larger than the line width. Fixes long and futile
596 looping inside extend_face_to_end_of_line (on a TTY) producing
597 glyphs that are not needed and thrown away.
598
6b312f0f
DA
5992012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
600
601 * marker.c (set_marker_restricted_both): Simplify by using
602 clip_to_bounds.
603
f520ef9b
PE
6042012-07-05 Paul Eggert <eggert@cs.ucla.edu>
605
606 * editfns.c (region_limit): Simplify by using clip_to_bounds.
607
383b7c95
JD
6082012-07-05 Jan Djärv <jan.h.d@swipnet.se>
609
610 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
611 not defined (Bug#11768).
612 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
613 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
614 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
615 followed by gtk_box_set_homogeneous (Bug#11768).
616 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
617 (update_theme_scrollbar_width, xg_create_scroll_bar):
618 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
619 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
620 (is_box_type): New function (Bug#11768).
621 (xg_tool_item_stale_p): Call is_box_type.
5293d758 622 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
623 with default display (Bug#11768).
624
d6e7bf45
EZ
6252012-07-05 Eli Zaretskii <eliz@gnu.org>
626
627 * xdisp.c (window_hscroll_limited): New function.
628 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
629 coordinates when window's hscroll is set to insanely large
630 values. (Bug#11857)
631
431391ec
JB
6322012-07-05 Juanma Barranquero <lekktu@gmail.com>
633
634 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
635 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
636
23f86fce
DA
6372012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
638
639 Cleanup xmalloc.
640 * lisp.h (xzalloc): New prototype. Omit needless casts.
641 * alloc.c (xzalloc): New function. Omit needless casts.
642 * charset.c: Omit needless casts. Convert all calls to
643 xmalloc with following memset to xzalloc.
644 * dispnew.c: Likewise.
645 * fringe.c: Likewise.
646 * image.c: Likewise.
647 * sound.c: Likewise.
648 * term.c: Likewise.
649 * w32fns.c: Likewise.
650 * w32font.c: Likewise.
651 * w32term.c: Likewise.
652 * xfaces.c: Likewise.
653 * xfns.c: Likewise.
654 * xterm.c: Likewise.
655 * atimer.c: Omit needless casts.
656 * buffer.c: Likewise.
657 * callproc.c: Likewise.
658 * ccl.c: Likewise.
659 * coding.c: Likewise.
660 * composite.c: Likewise.
661 * doc.c: Likewise.
662 * doprnt.c: Likewise.
663 * editfns.c: Likewise.
664 * emacs.c: Likewise.
665 * eval.c: Likewise.
666 * filelock.c: Likewise.
667 * fns.c: Likewise.
668 * gtkutil.c: Likewise.
669 * keyboard.c: Likewise.
670 * lisp.h: Likewise.
671 * lread.c: Likewise.
672 * minibuf.c: Likewise.
673 * msdos.c: Likewise.
674 * print.c: Likewise.
675 * process.c: Likewise.
676 * region-cache.c: Likewise.
677 * search.c: Likewise.
678 * sysdep.c: Likewise.
679 * termcap.c: Likewise.
680 * terminal.c: Likewise.
681 * tparam.c: Likewise.
682 * w16select.c: Likewise.
683 * w32.c: Likewise.
684 * w32reg.c: Likewise.
685 * w32select.c: Likewise.
686 * w32uniscribe.c: Likewise.
687 * widget.c: Likewise.
688 * xdisp.c: Likewise.
689 * xmenu.c: Likewise.
690 * xrdb.c: Likewise.
691 * xselect.c: Likewise.
692
0497dc44
PE
6932012-07-05 Paul Eggert <eggert@cs.ucla.edu>
694
695 * fileio.c (time_error_value): Check the right error number.
696 Problem reported by Troels Nielsen in
697 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
698
356e7178
PE
6992012-07-04 Paul Eggert <eggert@cs.ucla.edu>
700
4e71fd89
PE
701 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
702 This should be fixed in a better way; see Eli Zaretskii in
703 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
704 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
705
f0941253
PE
706 * fileio.c (time_error_value): Rename from special_mtime.
707 The old name's problems were noted by Eli Zaretskii in
708 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
709
065c9eb4
PE
710 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
711 This variable's comment says Emacs needs at least one GDB-visible
712 symbol of type enum pvec_type, to work around GDB problems.
713 The symbol's value doesn't matter.
714
356e7178
PE
715 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
716 that causes compilation to fail on pre-C99 compilers.
717
95f61aa2
JB
7182012-07-04 Juanma Barranquero <lekktu@gmail.com>
719
720 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
721 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
722
3884d954
DA
7232012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
724
d209e2fb 725 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
726 headers for buffer_defaults and buffer_local_symbols.
727 Reported by Juanma Barranquero <lekktu@gmail.com>.
728
ee28be33
SM
7292012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
730
731 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
732 * lisp.h (enum pvec_type): Use fewer bits.
733 (PSEUDOVECTOR_SIZE_BITS): New constant.
734 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
735 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
736 change in pvec_type.
737 (PSEUDOVECTOR_TYPEP): New macro.
738 (TYPED_PSEUDOVECTORP): Use it.
739 * fns.c (internal_equal): Adapt code to extract pvectype.
740 * emacs.c (gdb_pvec_type): Update type.
741 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
742 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
743 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
744 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
745 (sweep_vectors): Use it. Use local var `total_bytes' instead of
746 abusing vector->header.next.nbytes.
747 (live_vector_p): Use PVEC_TYPE.
748 (mark_object): Adapt code to extract pvectype. Use switch.
749
c7f2cd7f
PE
7502012-07-04 Paul Eggert <eggert@cs.ucla.edu>
751
752 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
753 Tighten new eassert a bit.
754
8ce70ed2
DA
7552012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
756
757 Fix compilation with --enable-gcc-warnings and -O1
758 optimization level.
759 * doprnt.c (doprnt): Change type of tem to int, initialize
760 to avoid compiler warning. Add eassert.
761 * search.c (simple_search): Initialize match_byte to avoid
762 compiler warning. Add eassert.
763
dea7f1e5
PE
7642012-07-04 Paul Eggert <eggert@cs.ucla.edu>
765
24a212eb
PE
766 Avoid weird behavior with large horizontal scrolls.
767 Without this change, for example, large hscroll values would
768 mess up Emacs's display on Fedora 15 x86, presumably due to
769 overflows in int calculations in the display code.
770 Also, if buffers had long lines, Emacs would freeze.
771 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
772 (set_window_hscroll): New function, containing the old guts of
773 Fset_window_hscroll. Return the clipped value.
774 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
775 This avoids the need to check against PTRDIFF_MAX.
776
dea7f1e5
PE
777 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
778
76046526
DA
7792012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
780
781 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
782
39adff0d
PE
7832012-07-04 Paul Eggert <eggert@cs.ucla.edu>
784
63807d47
PE
785 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
786 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
787 since GCC 4.4.6 issues a bogus warning for them.
788
39adff0d
PE
789 Fix bugs in file timestamp newness comparisons.
790 * fileio.c (Ffile_newer_than_file_p):
791 * lread.c (Fload): Use full timestamp resolution of files,
792 not just the 1-second resolution, so that files that are only
793 slightly newer still count as newer.
794 * fileio.c (Ffile_newer_than_file_p): Don't assume file
795 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
796
dbeed9a6
PE
7972012-07-03 Paul Eggert <eggert@cs.ucla.edu>
798
799 * fileio.c: Improve handling of file time marker. (Bug#11852)
800 (special_mtime): New function.
801 (Finsert_file_contents, Fverify_visited_file_modtime):
802 Use it to set special mtime values consistently.
803
636334d6
AS
8042012-07-03 Andreas Schwab <schwab@linux-m68k.org>
805
806 * fileio.c (Finsert_file_contents): Properly handle st_mtime
807 marker for non-existing file. (Bug#11852)
808
e2017fe2
GM
8092012-07-03 Glenn Morris <rgm@gnu.org>
810
811 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
812 and did not make it into globals.h).
813
404dbd37
TT
8142012-07-03 Tom Tromey <tromey@redhat.com>
815
816 * window.c (Fset_window_margins, Fset_window_fringes)
817 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
818 * textprop.c (Fprevious_property_change): No longer static.
819 * syntax.c (Fsyntax_table_p): No longer static.
820 * process.c (Fget_process, Fprocess_datagram_address): No longer
821 static.
822 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
823 * keyboard.c (Fcommand_execute): No longer static.
824 Remove EXFUN.
825 * insdel.c (Fcombine_after_change_execute): No longer static.
826 * image.c (Finit_image_library): No longer static.
827 * fileio.c (Fmake_symbolic_link): No longer static.
828 * eval.c (Ffetch_bytecode): No longer static.
829 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
830 * doc.c (Fdocumentation_property, Fsnarf_documentation):
831 No longer static.
404dbd37
TT
832 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
833 static.
834 * dired.c (Ffile_attributes): No longer static.
835 * composite.c (Fcomposition_get_gstring): No longer static.
836 * callproc.c (Fgetenv_internal): No longer static.
837
838 * ccl.h: Remove EXFUNs.
839 * buffer.h: Remove EXFUNs.
840 * dispextern.h: Remove EXFUNs.
841 * intervals.h: Remove EXFUNs.
842 * fontset.h: Remove EXFUN.
843 * font.h: Remove EXFUNs.
844 * dosfns.c (system_process_attributes): Remove EXFUN.
845 * keymap.h: Remove EXFUNs.
846 * lisp.h: Remove EXFUNs.
847 * w32term.h: Remove EXFUNs.
848 * window.h: Remove EXFUNs.
849 * xsettings.h: Remove EXFUN.
850 * xterm.h: Remove EXFUN.
851
8e4fd1e1
GM
8522012-07-03 Glenn Morris <rgm@gnu.org>
853
854 * lisp.h (Frandom): Make it visible to C.
855 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
856 buffer for invisible buffers. (Bug#1229)
857
ca95b3eb
DA
8582012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
859
860 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
861 values which aren't power of 2.
862 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
863 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
864 accordingly.
865
7555c33f
SM
8662012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
867
868 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
869
870 * alloc.c (mark_object): Revert part of last patch to use `switch'.
871
d12e8f5a
DA
8722012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
873
874 * alloc.c (allocate_vector_block): Remove redundant
875 calls to mallopt if DOUG_LEA_MALLOC is defined.
876 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
877 avoid calls to mallopt if zero_vector is returned.
878
296094c3
DA
8792012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
880
881 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
882 is enabled, avoid dereferencing NULL current_sblock if
883 running undumped.
884
36429c89
DA
8852012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
886
887 Cleanup basic buffer management.
888 * buffer.h (struct buffer): Change layout to use generic vector
889 marking code. Fix some comments. Change type of 'clip_changed'
890 to bitfield. Remove unused #ifndef old.
891 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
892 (GET_OVERLAYS_AT): Fix indentation.
893 (for_each_per_buffer_object_at): New macro.
894 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
895 (Fbuffer_local_variables): Use it.
896 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
897 * alloc.c (allocate_buffer): Adjust to match new layout of
898 struct buffer. Fix comment.
899 (mark_overlay): New function.
900 (mark_buffer): Use it. Use mark_vectorlike to mark normal
901 Lisp area of struct buffer.
902 (mark_object): Use it. Adjust marking of misc objects
903 and related comments.
904
3b3e4cac
PE
9052012-07-02 Paul Eggert <eggert@cs.ucla.edu>
906
907 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
908 wrapper that is not needed because the wrapped code is a no-op (zero
909 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
910 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
911
cf5c0175
DA
9122012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
913
914 * alloc.c (mark_buffer): Simplify. Remove prototype.
915 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 916 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
917 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
918 redundant calls to mark_vectorlike for bool vectors.
919
ca26824c
GM
9202012-06-30 Glenn Morris <rgm@gnu.org>
921
2e4c5312
GM
922 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
923
ca26824c
GM
924 * epaths.in (PATH_SITELOADSEARCH): New.
925 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
926 This is rather than relying on --enable-locallisppath elements
927 having "site-lisp" in their names. (Bug#10208#25, 11658)
928
0d23c240
EZ
9292012-06-30 Eli Zaretskii <eliz@gnu.org>
930
c9240d7a
EZ
931 * w32proc.c (sys_select): Accept and ignore one more argument.
932
933 * w32.c (emacs_gnutls_pull): Call select with one more argument.
934
0d23c240 935 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 936 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
937
938 * sysdep.c: Don't include dos.h and dosfns.h.
939
940 * process.c (sys_select):
941 * msdos.c (sys_select): Accept one more argument and ignore it.
942
943 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
944 adapt data types and code to that.
945
946 * dosfns.c:
947 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
948 which clashes with the gnulib function of the same name.
949
af5a5a98
AS
9502012-06-30 Andreas Schwab <schwab@linux-m68k.org>
951
c5e4379c
AS
952 * font.c (font_style_to_value, font_style_symbolic)
953 (font_prop_validate_style): Add type checks for values in
954 font_style_table.
955
af5a5a98
AS
956 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
957 argument.
958 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
959 uses.
960
8d38f461
EZ
9612012-06-29 Eli Zaretskii <eliz@gnu.org>
962
2e5a6631
EZ
963 * xdisp.c (try_window_id): Undo last change.
964
8d38f461
EZ
965 * w32.c (getwd): Adjust commentary about startup_dir.
966 (init_environment): Always call sys_access, even in non-MSVC
967 builds. Don't chdir to the directory of the Emacs executable.
968 This undoes code from 1997 which was justified by the need to
969 "avoid conflicts when removing and renaming directories". But its
970 downside was that every relative file name was being interpreted
971 relative to the directory of the Emacs executable, which can never
972 be TRT. In particular, it broke sys_access when called with
973 relative file names.
974 (sys_access): Map GetLastError to errno.
975
2af3565e
DA
9762012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
977
978 * window.h (struct window): Change type of 'fringes_outside_margins'
979 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 980 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
981 Adjust comment.
982 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
983 to ptrdiff_t.
984
c8d3a25c 9852012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 986
c8d3a25c
GM
987 * gnutls.c (emacs_gnutls_handshake):
988 Add QUIT to make the loop interruptible.
57570cd3 989
c8d3a25c 9902012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 991
c8d3a25c
GM
992 * charset.c (init_charset): Make lack of etc/charsets fatal.
993
3e984ee8
DA
9942012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
995
996 * editfns.c (region_limit): Fix type mismatch.
997
ef884f23
DA
9982012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
999
1000 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
1001 undefined. Convert from xassert to eassert.
1002 * nsmenu.m: Convert from xassert to eassert.
1003 * nsterm.m: Likewise.
1004
7d7e0027
SM
10052012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
1006
1007 * editfns.c (region_limit): Clip to narrowing (bug#11770).
1008
aa754e6a
PE
10092012-06-28 Paul Eggert <eggert@cs.ucla.edu>
1010
1011 Avoid integer overflow on scroll-left and scroll-right.
1012 * window.c (HSCROLL_MAX): New macro.
1013 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
1014 overflow when requested scroll falls outside ptrdiff_t range.
1015
80b00b08
DA
10162012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1017
1018 * window.h (struct window): Change type of 'hscroll',
1019 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
1020 'last_modified' and 'last_overlay_modified' to EMACS_INT.
1021 Adjust users accordingly.
1022 * xdisp.c (try_cursor_movement): Replace type check with eassert.
1023 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
1024 from EMACS_INT to ptrdiff_t.
1025 (make_window): Omit redundant initialization.
1026
62b2bcf6
JB
10272012-06-28 Juanma Barranquero <lekktu@gmail.com>
1028
1029 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
1030
45942c7d
DA
10312012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1032
1033 * window.h (struct window): Change type of 'use_time' and
1034 'sequence_number' from Lisp_Object to int.
1035 * frame.c (make_frame): Adjust users accordingly.
1036 * print.c (print_object): Likewise.
1037 * window.c (select_window, Fwindow_use_time, make_parent_window)
1038 (make_window): Likewise.
1039
e509cfa6
DA
10402012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1041
1042 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
1043 enabled with --enable-checking=[all,glyphs] configure option.
1044 Fix GLYPH_DEBUG usage assuming that it may be undefined,
1045 adjust comments accordingly.
1046 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
1047 undefined, adjust comments accordingly.
1048 * image.c: Likewise.
1049 * scroll.c: Likewise.
1050 * w32fns.c: Likewise.
1051 * w32term.c: Likewise.
1052 * xdisp.c: Likewise.
1053 * xfaces.c: Likewise.
1054 * xfns.c: Likewise.
1055 * xterm.c: Likewise.
1056
a54e2c05
DA
10572012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1058
1059 Generalize run-time debugging checks.
1060 * dispextern.h (XASSERTS): Remove.
1061 * fontset.c (xassert): Remove.
1062 Convert from xassert to eassert.
1063 * alloc.c: Convert from xassert to eassert.
1064 * bidi.c: Likewise.
1065 * dispnew.c: Likewise.
1066 * fns.c: Likewise.
1067 * fringe.c: Likewise.
1068 * ftfont.c: Likewise.
1069 * gtkutil.c: Likewise.
1070 * image.c: Likewise.
1071 * keyboard.c: Likewise.
1072 * menu.c: Likewise.
1073 * process.c: Likewise.
1074 * scroll.c: Likewise.
1075 * sound.c: Likewise.
1076 * term.c: Likewise.
1077 * w32console.c: Likewise.
1078 * w32fns.c: Likewise.
1079 * w32term.c: Likewise.
1080 * window.c: Likewise.
1081 * xdisp.c: Likewise.
1082 * xfaces.c: Likewise.
1083 * xfns.c: Likewise.
1084 * xselect.c: Likewise.
1085 * xterm.c: Likewise.
1086
1ec4b7b2
SM
10872012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
1088
1089 * fns.c (maybe_resize_hash_table): Output message when growing the
1090 purify-hashtable.
1091
2014308a
DA
10922012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1093
1094 * alloc.c (allocate_string_data): Remove dead code.
1095 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
1096 avoid GCC warning about unused macro.
1097
246155eb
DA
10982012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1099
1100 * alloc.c (allocate_string): Omit intervals initialization.
1101 * alloc.c (make_uninit_multibyte_string): Initialize intervals
1102 as in make_pure_string and make_pure_c_string.
1103
43184b7b
DA
11042012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1105
d209e2fb 1106 * alloc.c (allocate_string): Fix last change.
43184b7b 1107
3fe6dd74
DA
11082012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1109
d209e2fb 1110 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
1111 to memset, add explicit initialization where appropriate.
1112
1ba6038a
GM
11132012-06-27 Glenn Morris <rgm@gnu.org>
1114
1115 * lisp.mk (lisp): Remove paths.elc.
1116
c89926a5
CY
11172012-06-27 Chong Yidong <cyd@gnu.org>
1118
1119 * doc.c (Fsubstitute_command_keys): Fix punctuation.
1120
ed6b3510
JW
11212012-06-26 John Wiegley <johnw@newartisans.com>
1122
1ec4b7b2 1123 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
1124 on Mac OS X Lion: __mod_init_func and __mod_term_func.
1125
ed6b3510
JW
1126 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
1127 when building with Clang.
1128
8edd4a2b
SM
11292012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
1130
1131 * eval.c (Fapply): Allow calling it with a single argument.
1132
f6f62d1b
EZ
11332012-06-26 Eli Zaretskii <eliz@gnu.org>
1134
1135 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
1136 _stricmp and _strnicmp.
1137 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
1138
62efea5e
DA
11392012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1140
1141 * alloc.c (allocate_window): Zero out non-Lisp part of newly
1142 allocated window.
1143 (allocate_process): Likewise for new process.
8edd4a2b 1144 (allocate_terminal): Change to use offsetof.
62efea5e
DA
1145 (allocate_frame): Likewise.
1146 * frame.c (make_frame): Omit redundant initialization.
1147 * window.c (make_parent_window): Use memset.
1148 (make_window): Omit redundant initialization.
1149 * process.c (make_process): Omit redundant initialization.
1150 * terminal.c (create_terminal): Likewise.
1151
42997f4d
DA
11522012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1153
1154 * term.c (delete_tty): Remove redundant call to memset.
1155
1130ecfc
DA
11562012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1157
1158 * alloc.c: Remove build_string.
1159 * lisp.h: Define build_string as static inline. This provides
1160 a better opportunity to optimize away calls to strlen when the
1161 function is called with compile-time constant argument.
1162 * image.c (imagemagick_error): Convert to build_string.
1163 * w32proc.c (sys_spawnve): Likewise.
1164 * xterm.c (x_term_init): Likewise.
1165
cf38a720
PE
11662012-06-26 Paul Eggert <eggert@cs.ucla.edu>
1167
99027bdd
PE
1168 Use sprintf return value instead of invoking strlen on result.
1169 In the old days this wasn't portable, since some sprintf
1170 implementations returned char *. But they died out years ago and
1171 Emacs already assumes sprintf returns int.
1172 Similarly for float_to_string.
1173 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
1174 * ccl.c (ccl_driver):
1175 * character.c (string_escape_byte8):
1176 * data.c (Fnumber_to_string):
1177 * doprnt.c (doprnt):
1178 * print.c (print_object):
1179 * xdisp.c (message_dolog):
1180 * xfns.c (syms_of_xfns):
1181 Use sprintf or float_to_string result to avoid need to call strlen.
1182 * data.c (Fnumber_to_string):
1183 Use make_unibyte_string, since the string must be ASCII.
1184 * lisp.h, print.c (float_to_string): Now returns int length.
1185 * term.c (produce_glyphless_glyph):
1186 Use sprintf result rather than recomputing it.
1187
cf38a720
PE
1188 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
1189 * Makefile.in (ALL_CFLAGS):
1190 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
1191 * gmalloc.c, regex.c: Include <config.h> unconditionally.
1192
3511c784
DA
11932012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1194
0a08eb21 1195 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
1196 strcasecmp if available.
1197 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
1198
fb7da12e
AS
11992012-06-25 Andreas Schwab <schwab@linux-m68k.org>
1200
1201 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
1202 Avoid comma operator.
1203 * menu.c (push_submenu_start, push_submenu_end)
1204 (push_left_right_boundary, push_menu_pane): Likewise.
1205 * msdos.c (dos_rawgetc): Likewise.
1206
afa2ffd8
DA
12072012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1208
1209 * xfns.c (xic_create_fontsetname): Remove redundant calls
1210 to memset.
1211
b3b4476b
PE
12122012-06-25 Paul Eggert <eggert@cs.ucla.edu>
1213
4495ff38
PE
1214 * gtkutil.c (get_utf8_string): Remove redundant assignment.
1215 sprintf already null-terminates its output.
1216
b3b4476b
PE
1217 * xfns.c (x_window): Remove redundant cast.
1218
b00876c9
DA
12192012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1220
1221 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
1222 `const char *' to `char *' to avoid compiler warning.
1223
d188e26b
PE
12242012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1225
885d1d74
PE
1226 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
1227 instead of truncating it to 63 (admittedly a generous limit).
1228
d188e26b
PE
1229 * process.c: Fix spelling and caps in comments.
1230
e2f560b1
DN
12312012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
1232
e86db54b 1233 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
1234 * sysdep.c (setpgrp): Remove definition, not used in this file.
1235
7583a3a1
JB
12362012-06-24 Juanma Barranquero <lekktu@gmail.com>
1237
1238 * makefile.w32-in: Update dependencies.
1239
696056c2
EZ
12402012-06-24 Eli Zaretskii <eliz@gnu.org>
1241
1242 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
1243 (SYSTIME_H): Add nt/inc/sys/time.h.
1244
1245 * systime.h [WINDOWSNT]: Include sys/time.h.
1246
1247 * s/ms-w32.h (struct timespec): Definition moved from
1248 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
1249
845ca893
PE
12502012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1251
1252 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
1253 * buffer.h (buffer_slot_type_mismatch):
1254 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1255 * eval.c (unwind_to_catch):
1256 * image.c (my_png_error, my_error_exit):
1257 * keyboard.c (quit_throw_to_read_char, user_error)
1258 (Fexit_recursive_edit, Fabort_recursive_edit):
1259 * lisp.h (die, args_out_of_range, args_out_of_range_3)
1260 (wrong_type_argument, buffer_overflow, __executable_start)
1261 (memory_full, buffer_memory_full, string_overflow, Fthrow)
1262 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
1263 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
1264 (fatal):
1265 (child_setup) [!DOS_NT]:
1266 * lread.c (end_of_file_error, invalid_syntax):
1267 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1268 * puresize.h (pure_write_error):
1269 * search.c (matcher_overflow):
1270 * sound.c (sound_perror, alsa_sound_perror):
1271 * sysdep.c, syssignal.h (croak):
1272 * term.c (maybe_fatal, vfatal):
1273 * textprop.c (text_read_only):
1274 * undo.c (user_error):
1275 * unexmacosx.c (unexec_error):
1276 * xterm.c (x_ins_del_lines, x_delete_glyphs):
1277 Use _Noreturn rather than NO_RETURN.
1278 No need for separate decl merely because of _Noreturn.
1279 * sound.c (sound_warning, parse_sound):
1280 Remove unnecessary forward decls.
1281
f1dd8073
PE
12822012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1283
1284 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
1285 * lisp.h (WAIT_READING_MAX): New macro.
1286 * dispnew.c (Fsleep_for, sit_for):
1287 * keyboard.c (kbd_buffer_get_event):
1288 * process.c (Faccept_process_output):
1289 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
1290 This improves on the previous patch, which introduced a bug
1291 when time_t is unsigned and as wide as intmax_t.
1292 See <http://bugs.gnu.org/9000#51>.
1293
b82c1755
EZ
12942012-06-23 Eli Zaretskii <eliz@gnu.org>
1295
1296 * dispnew.c (sit_for, Fsleep_for):
1297 * keyboard.c (kbd_buffer_get_event):
1298 * process.c (Faccept_process_output): Avoid compiler warnings when
1299 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
1300
ca300656
JB
13012012-06-23 Juanma Barranquero <lekktu@gmail.com>
1302
049ec95b
JB
1303 * makefile.w32-in: Update dependencies.
1304
ca300656
JB
1305 * w32.c (ltime): Add return type and declare static.
1306 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
1307
db7b8d06
PE
13082012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1309
1310 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
1311 Privately reported by Herbert J. Skuhra.
1312 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
1313 All uses changed.
1314 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
1315 not make_lisp_timeval, when the argument is of type EMACS_TIME.
1316
0bd8297f
EZ
13172012-06-23 Eli Zaretskii <eliz@gnu.org>
1318
96512555
EZ
1319 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
1320 last argument of make_unibyte_string.
1321
0bd8297f
EZ
1322 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
1323 language ID in the event parameters.
1324
1325 * w32term.c (w32_read_socket): Put the new keyboard codepage into
1326 event.code, not the obscure "character set ID".
1327
63def6b6
CY
13282012-06-23 Chong Yidong <cyd@gnu.org>
1329
1330 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
1331
e8a02204
EZ
13322012-06-23 Eli Zaretskii <eliz@gnu.org>
1333
388cdec0
EZ
1334 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
1335 * w32.c (fdutimens): New function.
1336
1337 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
1338
1339 * s/ms-w32.h (pselect): Redirect to sys_select.
1340
1341 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
1342
e8a02204
EZ
1343 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
1344 in the logic of incrementing and decrementing the value of
1345 use_relocatable_buffers.
1346
d054f3fb
PE
13472012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1348
1349 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
1350 Privately reported by Herbert J. Skuhra.
1351 [__FreeBSD__]: Remove "*/" typo after "#include".
1352 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
1353 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
1354 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
1355 Don't assume EMACS_TIME and struct timeval are the same type.
1356
d35af63c
PE
13572012-06-22 Paul Eggert <eggert@cs.ucla.edu>
1358
1359 Support higher-resolution time stamps (Bug#9000).
1360 The time stamps are only nanosecond-resolution at the C level,
1361 since that's the best that any real-world system supports now.
1362 But they are picosecond-resolution at the Lisp level, as that's
1363 easy, and leaves room for future OS improvements.
1364
1365 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
1366 (LIBES): Use it.
1367
1368 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
1369 Don't get current time unless it's needed.
1370
1371 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
1372 now provides it if it's absent.
1373 (start_atimer): Port to higher-res time stamps.
1374 Check for time stamp overflow. Don't get current time more
1375 often than is needed.
1376
1377 * buffer.h (struct buffer): Buffer modtime now has high resolution.
1378 Include systime.h, not time.h.
1379 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
1380
1381 * dired.c: Include stat-time.h.
1382 (Ffile-attributes): File times now have higher resolution.
1383
1384 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
1385 (struct image): Timestamp now has higher resolution.
1386
1387 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
1388 has at least microseconds now. All uses removed.
1389 (update_frame, update_single_window, update_window, update_frame_1)
1390 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
1391
1392 * editfns.c (time_overflow): Now extern.
1393 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
1394 (float-time, Fformat_time_string, Fcurrent_time_string)
1395 (Fcurrent_time_zone): Accept and generate higher-resolution
1396 time stamps.
1397 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
1398 (decode_time_components, lisp_seconds_argument): New functions.
1399 (make_time): Now static.
1400 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
1401 Report an error if the time is invalid, rather than having the caller
1402 do that.
1403
1404 * fileio.c: Include <stat-time.h>
1405 (Fcopy_file): Copy higher-resolution time stamps.
1406 Prefer to set the time stamp via a file descriptor if that works.
1407 (Fset_file_times, Finsert_file_contents, Fwrite_region)
1408 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
1409 (Fvisited_file_modtime, Fset_visited_file_modtime):
1410 Support higher-resolution time stamps.
1411
1412 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
1413
1414 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
1415
1416 * image.c (prepare_image_for_display, clear_image_cache)
1417 (lookup_image): Port to higer-resolution time stamps.
1418
1419 * keyboard.c (start_polling, bind_polling_period):
1420 Check for time stamp overflow.
1421 (read_char, kbd_buffer_get_event, timer_start_idle)
1422 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
1423 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
1424 Port to higher-resolution time stamps. Do not assume time_t is signed.
1425 (decode_timer): New function. Timers are now vectors of length 9,
1426 not 8, to accommodate the picosecond component.
1427 (timer_check_2): Use it.
1428
1429 * nsterm.m (select_timeout, timeval_subtract): Remove.
1430 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
1431 as they're a bit more accurate and handle overflow better.
1432 (ns_select): Change prototype to be compatible with pselect.
1433 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
1434 * nsterm.h (ns_select): Adjust prototype.
1435
1436 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
1437 us-resolution time stamps.
1438 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
1439
1440 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
1441
1442 * lisp.h (time_overflow): New decl.
1443 (wait_reading_process_output): First arg is now intmax_t, not int,
1444 to accommodate larger waits.
1445
1446 * process.h (struct Lisp_Process.read_output_delay):
1447 Now counts nanoseconds, not microseconds.
1448 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
1449 EMACS_HAS_USECS.
1450 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
1451 (wait_reading_process_output):
1452 Port to ns-resolution time stamps.
1453 (Faccept_process_output, wait_reading_process_output):
1454 Check for time stamp overflow. Do not assume time_t is signed.
1455 (select_wrapper): Remove; we now use pselect.
1456 (Fprocess_attributes): Now generates ns-resolution time stamps.
1457
1458 * sysdep.c: Include utimens.h. Don't include utime.h
1459 or worry about struct utimbuf; gnulib does that for us now.
1460 (gettimeofday): Remove; gnulib provides a substitute.
1461 (make_timeval): New function.
1462 (set_file_times): Now sets ns-resolution time stamps.
1463 New arg FD; all uses changed.
1464 (time_from_jiffies, ltime_from_jiffies, get_up_time)
1465 (system_process_attributes):
1466 Now returns ns-resolution time stamp. All uses changed.
1467 Check for time stamp overflow.
1468
1469 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
1470 provides a substitute now.
1471
1472 * systime.h: Include timespec.h rather than sys/time.h and time.h,
1473 since it guarantees struct timespec.
1474 (EMACS_TIME): Now struct timespec, so that we can support
1475 ns-resolution time stamps.
1476 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
1477 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
1478 (EMACS_USECS): Remove.
1479 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
1480 so multiply the arg by 1000 before storing it.
1481 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
1482 New macros.
1483 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
1484 Port to ns-resolution time stamps.
1485 (EMACS_TIME_NEG_P): Remove; replaced by....
1486 (EMACS_TIME_SIGN): New macro.
1487 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
1488 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
1489 (set_file_times, make_time, lisp_time_argument): Adjust signature.
1490 (make_timeval, make_lisp_time, decode_time_components): New decls.
1491 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
1492 that it mishandled time_t overflow. You can't compare by subtracting!
1493 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
1494 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
1495
1496 * term.c: Include <sys/time.h>.
1497 (timeval_to_Time): New function, for proper overflow wraparound.
1498 (term_mouse_position, term_mouse_click): Use it.
1499
1500 * undo.c (record_first_change): Support higher-resolution time stamps
1501 in the undo buffer.
1502 (Fprimitive_undo): Use them when restoring time stamps.
1503
1504 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
1505 (w32_get_internal_run_time):
1506 Port to higher-resolution Emacs time stamps.
1507 (ltime): Now accepts single 64-bit integer, as that's more convenient
1508 for callers.
1509
1510 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
1511
1512 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
1513 for compatibility with pselect. Support ns-resolution time stamps.
1514
1515 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
1516
1517 * xselect.c (wait_for_property_change, x_get_foreign_selection):
1518 Check for time stamp overflow, and support ns-resolution time stamps.
1519
1520 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
1521 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
1522 (timeval_subtract): Remove; no longer needed.
1523 (XTflash, XTring_bell, x_wait_for_event):
1524 Port to ns-resolution time stamps. Don't assume time_t is signed.
1525
b6a92dfe
CY
15262012-06-22 Chong Yidong <cyd@gnu.org>
1527
1528 * xdisp.c (x_consider_frame_title): Revert last change.
1529
d251c37c
EZ
15302012-06-22 Eli Zaretskii <eliz@gnu.org>
1531
1532 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
1533 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
1534 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
1535 staticidx goes up to 1597 out of 1600 = 0x640.)
1536
f10deafb
PE
15372012-06-20 Paul Eggert <eggert@cs.ucla.edu>
1538
1539 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
1540 Otherwise, the umask might be mistakenly 0 while handling input signals.
1541
ec6de1e2
SM
15422012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
1543
1544 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
1545
28be1ada
DA
15462012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
1547
1548 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
1549 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
1550 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
1551 access to `contents' member of Lisp_Vector objects with AREF and ASET
1552 where appropriate.
1553
c6bf3022
CY
15542012-06-19 Chong Yidong <cyd@gnu.org>
1555
1556 * frame.c (delete_frame): When selecting a frame on a different
1557 text terminal, do not alter the terminal's top-frame.
1558
1559 * xdisp.c (format_mode_line_unwind_data): Record the target
1560 frame's selected window and its terminal's top-frame.
1561 (unwind_format_mode_line): Restore them.
1562 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
1563 Callers changed.
1564 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
1565 since tty frames can be explicitly named.
1566 (prepare_menu_bars): Likewise.
1567
1568 * term.c (Ftty_top_frame): New function.
1569
defd4196
PE
15702012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1571
1572 Port byte-code-meter to modern targets.
1573 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
1574 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 1575 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
1576 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
1577 (METER_1, METER_2): Simplify.
1578
1053a871
SM
15792012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
1580
1581 * data.c (Fdefalias): Return `symbol' (bug#11686).
1582
b7e8d081
MR
15832012-06-18 Martin Rudalics <rudalics@gmx.at>
1584
1585 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
1586 gets killed during executing of this function (Bug#11665).
1587 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
1588 (Vkill_buffer_query_functions): In doc-string say that functions
1589 run by this hook should not change the current buffer.
1590
7ea2b339
PE
15912012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1592
1593 Fix recently-introduced process.c problems found by static checking.
1594 * process.c (write_queue_push, write_queue_pop, send_process):
1595 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
1596 (write_queue_pop): Fix pointer signedness problem.
1597 (send_process): Remove unused local.
1598
96a313a1
CY
15992012-06-17 Chong Yidong <cyd@gnu.org>
1600
1601 * xdisp.c (redisplay_internal): No need to redisplay terminal
1602 frames that are not on top.
1603
20ca2e94
TN
16042012-06-17 Troels Nielsen <bn.troels@gmail.com>
1605
1606 * process.c (make_process): Initialize write_queue.
1607 (write_queue_push, write_queue_pop): New functions.
1608 (send_process): Use them to maintain correct ordering of process
1609 writes (Bug#10815).
1610
9a900ca9
PE
16112012-06-17 Paul Eggert <eggert@cs.ucla.edu>
1612
310fbfa8
PE
1613 * lisp.h (eassert): Assume C89 or later.
1614 This removes the need for CHECK.
1615 (CHECK): Remove. Its comments about always evaluating its
1616 argument were confusing, as 'eassert' typically does not evaluate
1617 its argument.
1618
27bb1ca4
PE
1619 * coding.c (produce_chars): Use ptrdiff_t, not int.
1620
9a900ca9
PE
1621 * xterm.c (x_draw_underwave): Check for integer overflow.
1622 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
1623
41b7f8bc 16242012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
1625
1626 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
1627 referenced (Bug#11583).
1628
9b0e3eba
AA
16292012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
1630
1631 Implement wave-style variant of underlining.
1632 * dispextern.h (face_underline_type): New enum.
1633 (face): Add field for underline type.
1634 * nsterm.m (ns_draw_underwave): New function.
1635 (ns_draw_text_decoration): Use it.
1636 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
1637 New functions.
1638 (x_draw_glyph_string): Use them.
1639 * xfaces.c (Qline, Qwave): New Lisp objects.
1640 (check_lface_attrs, merge_face_ref)
1053a871
SM
1641 (Finternal_set_lisp_face_attribute, realize_x_face):
1642 Handle wave-style underline face attributes.
9b0e3eba
AA
1643 * xterm.c (x_draw_underwave): New function.
1644 (x_draw_glyph_string): Use it.
1645
0fb52f11
JB
16462012-06-16 Juanma Barranquero <lekktu@gmail.com>
1647
1648 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
1649 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
1650 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
1651 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
1652 ($(BLD)/w32select.$(O)): Update dependencies.
1653
e5560ff7
AS
16542012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1655
1656 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
1657 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
1658 * character.c (_fetch_multibyte_char_p): Remove.
1659 * alloc.c: Include "character.h" before "buffer.h".
1660 * bidi.c: Likewise.
1661 * buffer.c: Likewise.
1662 * bytecode.c: Likewise.
1663 * callint.c: Likewise.
1664 * callproc.c: Likewise.
1665 * casefiddle.c: Likewise.
1666 * casetab.c: Likewise.
1667 * category.c: Likewise.
1668 * cmds.c: Likewise.
1669 * coding.c: Likewise.
1670 * composite.c: Likewise.
1671 * dired.c: Likewise.
1672 * dispnew.c: Likewise.
1673 * doc.c: Likewise.
1674 * dosfns.c: Likewise.
1675 * editfns.c: Likewise.
1676 * emacs.c: Likewise.
1677 * fileio.c: Likewise.
1678 * filelock.c: Likewise.
1679 * font.c: Likewise.
1680 * fontset.c: Likewise.
1681 * fringe.c: Likewise.
1682 * indent.c: Likewise.
1683 * insdel.c: Likewise.
1684 * intervals.c: Likewise.
1685 * keyboard.c: Likewise.
1686 * keymap.c: Likewise.
1687 * lread.c: Likewise.
1688 * macros.c: Likewise.
1689 * marker.c: Likewise.
1690 * minibuf.c: Likewise.
1691 * nsfns.m: Likewise.
1692 * nsmenu.m: Likewise.
1693 * print.c: Likewise.
1694 * process.c: Likewise.
1695 * regex.c: Likewise.
1696 * region-cache.c: Likewise.
1697 * search.c: Likewise.
1698 * syntax.c: Likewise.
1699 * term.c: Likewise.
1700 * textprop.c: Likewise.
1701 * undo.c: Likewise.
1702 * unexsol.c: Likewise.
1703 * w16select.c: Likewise.
1704 * w32fns.c: Likewise.
1705 * w32menu.c: Likewise.
1706 * window.c: Likewise.
1707 * xdisp.c: Likewise.
1708 * xfns.c: Likewise.
1709 * xmenu.c: Likewise.
1710 * xml.c: Likewise.
1711 * xselect.c: Likewise.
1712
2f07e6af
EZ
17132012-06-16 Eli Zaretskii <eliz@gnu.org>
1714
1053a871
SM
1715 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
1716 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 1717 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
1718 row.
1719 (handle_face_prop): Use chunk-relative overlay string index when
1720 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
1721 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
1722 the rightmost. (Bug#11720)
2f07e6af 1723
29b83cec
AS
17242012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1725
1726 * category.h (CHAR_HAS_CATEGORY): Define as inline.
1727 (CATEGORY_MEMBER): Enforce 1/0 value.
1728 * category.c (_temp_category_set): Remove.
1729
4c5501e9
EZ
17302012-06-16 Eli Zaretskii <eliz@gnu.org>
1731
1732 * window.c (Fdelete_other_windows_internal)
1733 (Fdelete_window_internal): Don't access frame's mouse highlight
1734 info of the initial frame. (Bug#11677)
1735
2b570124
PE
17362012-06-14 Paul Eggert <eggert@cs.ucla.edu>
1737
e93864f9
PE
1738 * .gdbinit (xgetint): Fix recently-introduced paren typo.
1739 Assume USE_2_TAGS_FOR_INTS.
1740 (xreload): Adjust $tagmask width to match recent lisp.h change.
1741
2b570124
PE
1742 Simplify lisp.h in minor ways that should not affect code.
1743 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
1744 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
1745 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
1746 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
1747 (INTTYPEBITS): New macro, for clarity.
1748 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
1749 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
1750 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
1751 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
1752 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
1753
81755f69
JB
17542012-06-13 Juanma Barranquero <lekktu@gmail.com>
1755
1756 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
1757
16192a57
GM
17582012-06-13 Glenn Morris <rgm@gnu.org>
1759
1760 * s/bsd-common.h (BSD4_3):
1761 * s/usg5-4-common.h (USG5_4): No longer define; unused.
1762
646b5f55
AS
17632012-06-13 Andreas Schwab <schwab@linux-m68k.org>
1764
1765 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
1766 instead of union.
1767 (XLI, XIL): Define.
1053a871
SM
1768 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
1769 Use them.
1770 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 1771 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 1772 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
1773 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
1774 * frame.c (delete_frame): Remove outdated comment.
1775 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
1776 USE_LISP_UNION_TYPE.
1777 (Fw32_unregister_hot_key): Likewise.
1778 (Fw32_toggle_lock_key): Likewise.
1779 * w32menu.c (add_menu_item): Likewise.
1780 (w32_menu_display_help): Use XIL instead of checking
1781 USE_LISP_UNION_TYPE.
1782 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
1783 (init_heap): Likewise.
1784 * w32term.c (w32_read_socket): Update comment.
1785
1d3823c9
GM
17862012-06-13 Glenn Morris <rgm@gnu.org>
1787
c62ff706
GM
1788 * s/usg5-4-common.h, src/s/unixware.h:
1789 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
1790
1d3823c9
GM
1791 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
1792
bfe3e0a2
PE
17932012-06-13 Paul Eggert <eggert@cs.ucla.edu>
1794
1795 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
1796 * alloc.c (make_number) [!defined make_number]:
1797 Remove, as lisp.h always defines this now.
1798 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
1799 (roundup_size): Verify that it is a power of 2.
1800 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
1801 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
1802 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
1803 -DUSE_LSB_TAG=0, to override the automatically-selected default.
1804 USE_LSB_TAG now is always defined to be either 0 or 1.
1805 All uses changed.
1806 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
1807 code works fine either way, and efficiency is not a concern here,
1808 as the union type is for debugging, not for production.
1809 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
1810 Use an inline function on all platforms when using the union type,
1811 since this is simpler and 'static inline' can be used portably
1812 within Emacs now.
1813 (LISP_INITIALLY_ZERO): New macro.
1814 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
1815 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
1816
45fa9c0f
GM
18172012-06-12 Glenn Morris <rgm@gnu.org>
1818
b4492cba
GM
1819 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
1820
1821 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 1822
45fa9c0f
GM
1823 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
1824 Move BROKEN_SIGIO to configure.
1825
1826 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
1827 Move NO_TERMIO to configure.
1828
0e25d334
CY
18292012-06-12 Chong Yidong <cyd@gnu.org>
1830
1831 * image.c (imagemagick_load_image): Use MagickFlattenImage if
1832 MagickMergeImageLayers is undefined. Use pixel pusher loop if
1833 MagickExportImagePixels is undefined.
1834
43682bb6
PE
18352012-06-12 Paul Eggert <eggert@cs.ucla.edu>
1836
1837 * image.c (imagemagick_load_image): Remove unused label.
1838
a9be7d2b
GM
18392012-06-11 Glenn Morris <rgm@gnu.org>
1840
1841 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1842 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
1843 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
1844 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
1845
3017f87f
SM
18462012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
1847
1848 * alloc.c (make_byte_code): New function.
1849 (Fmake_byte_code): Use it. Don't purify here.
1850 * lread.c (read1): Use it as well to avoid extra allocation.
1851
1b9b4cf4
CY
18522012-06-11 Chong Yidong <cyd@gnu.org>
1853
1854 * image.c (imagemagick_load_image): Implement transparency.
1855
95988fcf
AS
18562012-06-10 Andreas Schwab <schwab@linux-m68k.org>
1857
1858 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
1859 account for preceding backslashes. (Bug#11663)
1860
cd4eb164
CY
18612012-06-09 Chong Yidong <cyd@gnu.org>
1862
1863 * term.c: Support italics in capable terminals (Bug#9652).
1864 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
1865 (turn_on_face): Output using TS_enter_italic_mode if available.
1866 Don't handle unused blinking and alt-charset cases.
1867 (turn_off_face): Handle italic case; discard unused tty_blinking_p
1868 and tty_alt_charset_p cases.
1869 (tty_capable_p, init_tty): Support italics.
1870
1871 * termchar.h (struct tty_display_info): Add field for italics.
1872 Remove unused blink field.
1873
1874 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
1875 Handle slant.
1876
1877 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
1878 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
1879 tty_alt_charset_p. Add tty_italic_p.
1880
ff88beb8
MA
18812012-06-09 Michael Albinus <michael.albinus@gmx.de>
1882
1883 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
1884 dbus_type_is_basic if available.
1885 (xd_extract_signed, xd_extract_unsigned): Rename from
1886 extract_signed and extract_unsigned, respectively. Adapt callers.
1887
44286096
CY
18882012-06-09 Chong Yidong <cyd@gnu.org>
1889
1682701f
CY
1890 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
1891
44286096
CY
1892 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
1893 case (Bug#9752).
1894
d86feb17
PE
18952012-06-08 Paul Eggert <eggert@cs.ucla.edu>
1896
1897 * xdisp.c (vmessage): Treat frame message as multibyte.
1898 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
1899 would generate the diagnostic "Making \302\247 buffer-local while
1900 let-bound!".
1901
d5c20fe8
EZ
19022012-06-08 Eli Zaretskii <eliz@gnu.org>
1903
1904 * dispnew.c (showing_window_margins_p): Undo last change, which
1905 was done due to an inadvertent commit.
1906 (adjust_frame_glyphs_for_frame_redisplay): Do call
1907 showing_window_margins_p.
1908
513749ee
SM
19092012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1910
1911 * eval.c (Fmake_var_non_special): New primitive.
1912 (syms_of_eval): Defsubr it.
1913 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
1914
d4a8f5c1
JB
19152012-06-08 Juanma Barranquero <lekktu@gmail.com>
1916
1917 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
1918 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
1919
8bbbc977
EZ
19202012-06-08 Eli Zaretskii <eliz@gnu.org>
1921
1922 * alloc.c (allocate_vectorlike): Fix last change.
1923
f3372c87
DA
19242012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
1925
1926 Block-based vector allocation of small vectors.
1927 * lisp.h (struct vectorlike_header): New field `nbytes',
1928 adjust comment accordingly.
1929 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
1930 to denote vector blocks. Adjust users (live_vector_p,
1931 mark_maybe_pointer, valid_lisp_object_p) accordingly.
1932 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
1933 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
1934 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
1935 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
1936 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
1937 (roundup_size): New constant.
1938 (struct vector_block): New data type.
1939 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 1940 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
1941 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
1942 (sweep_vectors): New functions.
1943 (allocate_vectorlike): Return `zero_vector' as the only vector of
1944 0 items. Allocate new vector from block if vector size is less than
1945 or equal to VBLOCK_BYTES_MAX.
1946 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
1947 (init_alloc_once): Add call to init_vectors.
1948
4f18a4ed
SM
19492012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1950
1951 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
1952
86f158bc
PE
19532012-06-07 Paul Eggert <eggert@cs.ucla.edu>
1954
1955 * doprnt.c (doprnt): Truncate multibyte char correctly.
1956 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
1957 would mishandle a string argument "Xc" if X was a multibyte
1958 character of length 2: it would truncate after X's first byte
1959 rather than including all of X.
1960
c5cfcbe0
CY
19612012-06-06 Chong Yidong <cyd@gnu.org>
1962
1963 * buffer.c (word_wrap): Doc fix.
1964
c05cf390
PE
19652012-06-04 Paul Eggert <eggert@cs.ucla.edu>
1966
1967 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
1968
0c3461de
GM
19692012-06-03 Glenn Morris <rgm@gnu.org>
1970
1971 * xdisp.c (tool-bar-style): Doc fix.
1972
c71232db
UM
19732012-06-03 Ulrich Müller <ulm@gentoo.org>
1974
1975 * Makefile.in (PAXCTL): Define.
1976 (temacs$(EXEEXT)): Disable memory randomization for the temacs
1977 binary via PaX flags if the paxctl utility is available.
1978 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
1979 Restore PaX flags to their default. (Bug#11398)
1980
383f7350
CY
19812012-06-03 Chong Yidong <cyd@gnu.org>
1982
1983 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
1984 buffer (Bug#11226).
1985
5f2c76c6
CY
19862012-06-03 Chong Yidong <cyd@gnu.org>
1987
1988 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
1989 (note_mode_line_or_margin_highlight): If there is no help echo,
1990 use mode-line-default-help-echo. Handle the case where the mouse
1991 position is past the end of the mode line string.
1992
1993 * buffer.c (buffer_local_value_1): New function, split from
1994 Fbuffer_local_value; can return Qunbound.
1995 (Fbuffer_local_value): Use it.
1996 (Vmode_line_format): Docstring tweaks.
1997
773d47f6
PE
19982012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1999
2000 * sysdep.c (system_process_attributes): Improve comment.
2001
f2d6a3df
SM
20022012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
2003
2004 * keyboard.c: Export real-this-command to Elisp.
2005 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
2006 and DEFVAR it. Update all users.
2007
63810350
PE
20082012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2009
7bd5c1f4
PE
2010 * minibuf.c (Fassoc_string): Remove duplicate declaration.
2011
63810350
PE
2012 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
2013 Convert pctcpu and pctmem to Lisp float properly.
2014 Let the compiler fold better, as 100.0/0x8000 is exact.
2015
a2821611
AS
20162012-06-02 Andreas Schwab <schwab@linux-m68k.org>
2017
2018 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
2019 cons_block.
2020
5fceba1d
PE
20212012-06-01 Paul Eggert <eggert@cs.ucla.edu>
2022
2023 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
2024
c98ff5dd
DA
20252012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
2026
2027 For a 'struct window', replace some Lisp_Object fields to
2028 bitfields where appropriate, remove unused fields.
2029 * window.h (struct window): Remove unused 'last_mark_x' and
2030 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
2031 change it's type from Lisp_Object to bitfield.
2032 Change type of 'force_start', 'optional_new_start',
2033 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
2034 fields from Lisp_Object to bitfield. Adjust users accordingly.
2035
ca34e0be
PE
20362012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2037
2038 Pacify gcc -Wdouble-precision when using Xaw.
2039 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
2040 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
2041 Use 'float' consistently, rather than 'float' in most places
2042 and 'double' in a couple of places.
2043
efc00ab1 20442012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
2045
2046 * xdisp.c (handle_stop): Detect whether we have overlay strings
2047 loaded by testing it->current.overlay_string_index to be
2048 non-negative, instead of checking whether n_overlay_strings is
2049 positive. (Bug#11587)
2050
efc00ab1 20512012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
2052
2053 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
2054
2055 * doc.c (Fsubstitute_command_keys): Doc fix.
2056
efc00ab1 20572012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
2058
2059 * search.c (search_buffer): Remove calls to
2060 r_alloc_inhibit_buffer_relocation, as it is now called by
2061 maybe_unify_char, which was the cause of relocation of buffer text
2062 in bug#11519.
2063
efc00ab1 20642012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
2065
2066 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
2067 for the duration of call to load_charset, to avoid problems with
2068 callers of maybe_unify_char that access buffer text through C
2069 pointers.
2070
2071 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
2072 decrement the inhibition flag, instead of just setting or
2073 resetting it.
2074
ba93a187
PE
20752012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2076
2077 Remove obsolete '#define static' cruft.
2078 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
2079 This #undef was "temporary" in 2000; it is no longer needed
2080 now that '#define static' has gone away.
2081 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
2082 (gray_bitmap_bits): Remove; no longer needed.
2083 All uses replaced with definiens.
2084 * xterm.c: Include "bitmaps/gray.xbm".
2085
9e4bf381
PE
20862012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2087
2088 Clean up __executable_start, monstartup when --enable-profiling.
2089 The following changes affect the code only when profiling.
2090 * dispnew.c (__executable_start): Rename from safe_bcopy.
2091 Define only on platforms that need it.
2092 * emacs.c: Include <sys/gmon.h> when profiling.
2093 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
2094 (__executable_start): Remove decl, since lisp.h does it now.
2095 (safe_bcopy): Remove decl; no longer has that name.
2096 (main): Coalesce #if into single bit of code, for simplicity.
2097 Cast pointers to uintptr_t, since standard libraries want integers
2098 and not pointers.
2099 * lisp.h (__executable_start): New decl.
2100
32d72c2f
GM
21012012-05-31 Glenn Morris <rgm@gnu.org>
2102
2103 * image.c (Fimagemagick_types): Doc fix.
2104
baac5bc7
JM
21052012-05-30 Jim Meyering <meyering@redhat.com>
2106
2107 * callproc.c (Fcall_process_region): Include directory component
2108 in mkstemp error message (Bug#11586).
2109
72cb32cf
PE
21102012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2111
2112 * alloc.c, lisp.h (make_pure_vector): Now static.
2113
61b108cc
SM
21142012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
2115
2116 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
2117 Move to byte-run.el.
2118 (Fautoload): Do the hash-doc more carefully.
2119 * data.c (Fdefalias): Purify definition, except for keymaps.
2120 (Qdefun): Move from eval.c.
2121 * lisp.h (Qdefun): Remove.
2122 * lread.c (read1): Tiny simplification.
2123
471fe23d
TN
21242012-05-29 Troels Nielsen <bn.troels@gmail.com>
2125
934f3f58 2126 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
2127 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
2128 Bug#9642, but explicitly check that the buffer the overlay would
2129 be moved to is live and rearrange lines to make sure that errors
2130 will not put the overlay in an inconsistent state.
2131 (Fdelete_overlay): Cosmetics.
2132
85d0efd1
EZ
21332012-05-28 Eli Zaretskii <eliz@gnu.org>
2134
2135 * w32term.c (my_bring_window_to_top): New function.
2136 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
2137 could be different from the original one.
2138 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
2139 (Bug#11513)
2140
2141 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
2142 by calling BringWindowToTop.
2143
2144 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
2145 (WM_EMACS_END): Increase by one.
2146
da92a98c
PE
21472012-05-28 Paul Eggert <eggert@cs.ucla.edu>
2148
2149 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
2150 This avoids undefined behavior that might cause the eassert
2151 to not catch an out-of-range value.
2152
74d1f848
JB
21532012-05-28 Juanma Barranquero <lekktu@gmail.com>
2154
2155 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
2156 Update dependencies.
2157
9e1a06fc
EZ
21582012-05-27 Eli Zaretskii <eliz@gnu.org>
2159
2160 * bidi.c (bidi_mirror_char): Fix last change.
2161
f3dd7312
AS
21622012-05-27 Andreas Schwab <schwab@linux-m68k.org>
2163
2164 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
2165 when referring to sectname field in printf format.
2166
81899c91
PE
21672012-05-27 Paul Eggert <eggert@cs.ucla.edu>
2168
57b81a9f
PE
2169 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
2170 Only r_alloc_inhibit_buffer_relocation needed to be added;
2171 the others were already declared.
2172
81899c91
PE
2173 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
2174 before checking whether it's out of range. Put the check inside
2175 eassert. See
2176 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
2177
33017faf 21782012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
2179
2180 * callproc.c (Fcall_process): Restore a line that was accidentally
2181 commented out in the 2011-02-13 change (bug#11547).
2182
33017faf 21832012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
2184
2185 * lisp.h [REL_ALLOC]: Add prototypes for external functions
2186 defined on ralloc.c.
2187
2188 * buffer.c [REL_ALLOC]: Remove prototypes of
2189 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
2190 they are now on lisp.h.
2191
2192 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
2193
2194 * search.c (search_buffer): Use it to inhibit relocation of buffer
2195 text while re_search_2 is doing its job, because re_search_2 is
2196 passed C pointers to buffer text. (Bug#11519)
2197
23415acf
EZ
2198 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
2199 Update value to 24.
2200
44e27368
EZ
2201 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
2202 state after an additional call to move_it_in_display_line_to, keep
2203 the values of it->max_ascent and it->max_descent found for the
2204 entire line.
2205 (pos_visible_p): Revert the comparison against bottom_y to what it
2206 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
2207 (Bug#11464)
2208
c1892f11
PE
22092012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2210
2211 Fix coding-related core dumps with gcc -ftrapv.
2212 The code was computing A - B, where A and B are pointers, and B is
2213 random garbage. This can lead to core dumps on platforms that
2214 have special pointer registers, and it also leads to core dumps on
2215 x86-64 when compiled with gcc -ftrapv. The fix is to compute
2216 A - B only when B is initialized properly.
2217 * coding.c (coding_set_source, coding_set_destination): Return void.
2218 (coding_change_source, coding_change_destinations): New functions,
2219 with the old behaviors of coding_set_source and coding_set_destination.
2220 All callers that need an offset changed to use these new functions.
2221
eb7afdad
GM
22222012-05-26 Glenn Morris <rgm@gnu.org>
2223
2224 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
2225
f12fdf02
EZ
22262012-05-26 Eli Zaretskii <eliz@gnu.org>
2227
53a63be6 2228 Extend mouse support on W32 text-mode console.
61b108cc
SM
2229 * xdisp.c (draw_row_with_mouse_face):
2230 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 2231
eb3f6f01 2232 * w32console.c: Include window.h.
61b108cc
SM
2233 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
2234 New functions.
eb3f6f01
EZ
2235 (initialize_w32_display): Initialize mouse-highlight data.
2236
53a63be6
EZ
2237 * w32inevt.c: Include termchar.h and window.h.
2238 (do_mouse_event): Support mouse-autoselect-window. When the mouse
2239 moves, call note_mouse_highlight. If help_echo changed, call
2240 gen_help_event to produce help-echo message in the echo area.
2241 Call clear_mouse_face if mouse_face_hidden is set in the mouse
2242 highlight info.
2243
4cfd81f6
PE
22442012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2245
2246 * lread.c (read1): Simplify slightly to avoid an overflow warning
2247 with GCC 4.7.0 on x86-64.
2248
4446092a
EZ
22492012-05-26 Eli Zaretskii <eliz@gnu.org>
2250
2251 * bidi.c (bidi_mirror_char): Revert last change: an int is
2252 definitely wide enough here.
2253
42b2a986 22542012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 2255
42b2a986 2256 Fix integer width and related bugs (Bug#9874).
eb106a49 2257 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
2258 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
2259 (string_bytes, check_sblock, allocate_string_data):
2260 (compact_small_strings, Fmake_bool_vector, make_string)
2261 (make_unibyte_string, make_multibyte_string)
2262 (make_string_from_bytes, make_specified_string)
2263 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
2264 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
2265 (mark_vectorlike):
2266 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2267 (allocate_pseudovector):
2268 Use int, not EMACS_INT, where int is wide enough.
2269 (inhibit_garbage_collection, Fgarbage_collect):
2270 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2271 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
2272 int might not be wide enough.
2273 (bidi_cache_search, bidi_cache_find, bidi_init_it)
2274 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
2275 (bidi_at_paragraph_end, bidi_find_paragraph_start)
2276 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2277 (bidi_level_of_next_char, bidi_move_to_visually_next):
2278 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2279 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
2280 (Fkill_buffer, Fset_buffer_major_mode)
2281 (advance_to_char_boundary, Fbuffer_swap_text)
2282 (Fset_buffer_multibyte, overlays_at, overlays_in)
2283 (overlay_touches_p, struct sortvec, record_overlay_string)
2284 (overlay_strings, recenter_overlay_lists)
2285 (adjust_overlays_for_insert, adjust_overlays_for_delete)
2286 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
2287 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
2288 (Foverlay_recenter, last_overlay_modification_hooks_used)
2289 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
2290 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
2291 (validate_region): Omit unnecessary test for b <= e,
2292 since that's guaranteed by the previous test.
d311d28c
PE
2293 (adjust_overlays_for_delete): Avoid pos + length overflow.
2294 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
2295 (report_overlay_modification):
2296 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2297 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
2298 Omit pointer cast, which isn't needed anyway, and doesn't work
2299 after the EMACS_INT -> ptrdiff_t change.
02481186 2300 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
2301 * buffer.h: Adjust decls to match defn changes elsewhere.
2302 (struct buffer_text, struct buffer):
2303 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2304 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
2305 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
2306 not int, to avoid needless 32-bit limit on 64-bit hosts.
2307 (exec_byte_code): Use tighter memory-full test, one that checks
2308 for alloca overflow. Don't compute the address of the object just
2309 before an array, as that's not portable. Use EMACS_INT, not
2310 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
2311 * callint.c (Fcall_interactively):
2312 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2313 * callproc.c (call_process_kill, Fcall_process):
2314 Don't assume pid_t fits into an Emacs fixnum.
2315 (call_process_cleanup, Fcall_process, child_setup):
2316 Don't assume pid_t fits into int.
2317 (call_process_cleanup, Fcall_process, delete_temp_file)
2318 (Fcall_process_region):
2319 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2320 (Fcall_process): Simplify handling of volatile integers.
2321 Use int, not EMACS_INT, where int will do.
2322 * casefiddle.c (casify_object, casify_region, operate_on_word)
2323 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
2324 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2325 (casify_object): Avoid integer overflow when overallocating buffer.
2326 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 2327 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
2328 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
2329 * category.h (CATEGORYP): Don't assume arg is nonnegative.
2330 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
2331 integers are now checked earlier. All uses replaced with XINT.
2332 (ccl_driver):
2333 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2334 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
2335 (ccl_driver, Fregister_code_conversion_map):
2336 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
2337 (resolve_symbol_ccl_program): Check that vector header is in range.
2338 Always copy the vector, so that we can check its contents reliably
2339 now rather than having to recheck each instruction as it's being
2340 executed. Check that vector words fit in 'int'.
2341 (ccl_get_compiled_code, Fregister_ccl_program)
2342 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
2343 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
2344 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
2345 contents are in range.
2346 (Fccl_execute_on_string): Check that status is in range.
2347 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
2348 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
2349 Accept and return EMACS_INT, not int, because callers can pass values
2350 out of 'int' range.
2351 (c_string_width, strwidth, lisp_string_width, chars_in_text)
2352 (multibyte_chars_in_text, parse_str_as_multibyte)
2353 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
2354 (str_as_unibyte, str_to_unibyte, string_count_byte8)
2355 (string_escape_byte8, Fget_byte):
2356 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 2357 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
2358 avoid mishandling large integers.
2359 * character.h: Adjust decls to match defn changes elsewhere.
2360 * charset.c (load_charset_map_from_file, find_charsets_in_text)
2361 (Ffind_charset_region):
2362 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2363 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
2364 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 2365 Don't assume fixnum fits in int.
d311d28c
PE
2366 (load_charset_map_from_vector, Fmap_charset_chars):
2367 Remove now-unnecessary CHECK_NATNUMs.
2368 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
2369 Don't rely on undefined behavior with signed left shift overflow.
2370 Don't assume unsigned int fits into fixnum, or that fixnum fits
2371 into unsigned int. Don't require max_code to be a valid fixnum;
2372 that's not true for gb10830 4-byte on a 32-bit host. Allow
2373 invalid_code to be a cons, for the same reason. Require code_offset
2374 to be a character. Avoid int overflow if max_char is close
2375 to INT_MAX.
2376 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
2377 this is intended anyway and avoids some undefined behavior.
2378 (load_charset_map): Pass unsigned, not int, as 2nd arg of
2379 INDEX_TO_CODE_POINT, as that's what it expects.
2380 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
2381 * charset.h (DECODE_CHAR): Return int, not unsigned;
2382 this is what was intended anyway, and it avoids undefined behavior.
2383 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
2384 integer-overflow issues.
2385 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
2386 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
2387 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
2388 * chartab.c (Fmake_char_table, Fset_char_table_range)
2389 (uniprop_get_decoder, uniprop_get_encoder):
2390 Don't assume fixnum fits in int.
2391 * cmds.c (move_point): New function, that does the gist of
2392 Fforward_char and Fbackward_char, but does so while checking
2393 for integer overflow more accurately.
c96e5d6a 2394 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
2395 (Fforward_line, Fend_of_line, internal_self_insert)
2396 (internal_self_insert):
2397 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2398 Fix a FIXME, by checking for integer overflow when calculating
2399 target_clm and actual_clm.
2400 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 2401 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
2402 (ASSURE_DESTINATION, coding_alloc_by_realloc)
2403 (coding_alloc_by_making_gap, alloc_destination)
2404 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
2405 (encode_coding_utf_16, detect_coding_emacs_mule)
2406 (decode_coding_emacs_mule, encode_coding_emacs_mule)
2407 (detect_coding_iso_2022, decode_coding_iso_2022)
2408 (encode_invocation_designation, encode_designation_at_bol)
2409 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2410 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
2411 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
2412 (encode_coding_ccl, encode_coding_raw_text)
2413 (detect_coding_charset, decode_coding_charset)
2414 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
2415 (produce_composition, produce_charset, produce_annotation)
2416 (decode_coding, handle_composition_annotation)
2417 (handle_charset_annotation, consume_chars, decode_coding_gap)
2418 (decode_coding_object, encode_coding_object, detect_coding_system)
2419 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
2420 (code_convert_region, code_convert_string)
8f50130c
PE
2421 (Fdefine_coding_system_internal)
2422 (coding_set_source, coding_set_destination):
d311d28c
PE
2423 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2424 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
2425 (Fdefine_coding_system_internal):
2426 Don't assume fixnums fit in int.
2427 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 2428 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
2429 (Funencodable_char_position, Fcheck_coding_systems_region)
2430 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 2431 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 2432 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 2433 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 2434 Don't access memory outside of the args array.
d311d28c 2435 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
2436 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
2437 result of ENCODE_CHAR.
d311d28c
PE
2438 * coding.h: Adjust decls to match defn changes elsewhere.
2439 (struct coding_system):
2440 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2441 * composite.c (get_composition_id, find_composition)
2442 (run_composition_function, update_compositions)
2443 (compose_text, composition_gstring_put_cache)
2444 (composition_gstring_p, composition_gstring_width)
2445 (fill_gstring_header, fill_gstring_body, autocmp_chars)
2446 (composition_compute_stop_pos, composition_reseat_it)
2447 (composition_update_it, struct position_record)
2448 (find_automatic_composition, composition_adjust_point)
2449 (Fcomposition_get_gstring, Ffind_composition_internal):
2450 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2451 (update_compositions):
2452 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2453 * composite.h: Adjust decls to match defn changes elsewhere.
2454 (struct composition):
2455 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2456 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2457 Do not attempt to compute the address of the object just before a
2458 buffer; this is not portable.
2459 (Faref, Faset):
2460 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2461 (Faset): Use int, not EMACS_INT, where int is wide enough.
2462 (Fstring_to_number): Don't assume fixnums fit in int.
2463 (Frem): Don't assume arg is nonnegative.
2464 * dbusbind.c (xd_append_arg): Check for integers out of range.
2465 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 2466 (extract_signed, extract_unsigned): New functions.
243e0530
PE
2467 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
2468 (xd_get_connection_references): Return ptrdiff_t, not int.
2469 All uses changed.
2470 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
2471 (xd_read_message_1):
2472 Use int, not unsigned, where the dbus API uses int.
2473 (Fdbus_message_internal): Don't overflow mtype.
2474 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
2475 * dired.c (directory_files_internal, file_name_completion, scmp)
2476 (file_name_completion_stat):
2477 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2478 (file_name_completion): Don't overflow matchcount.
2479 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
2480 * dispextern.h: Adjust decls to match defn changes elsewhere.
2481 (struct text_pos, struct glyph, struct bidi_saved_info)
2482 (struct bidi_string_data, struct bidi_it, struct composition_it)
2483 (struct it):
2484 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2485 (struct display_pos, struct composition_it, struct it):
2486 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2487 * dispnew.c (increment_matrix_positions)
2488 (increment_row_positions, mode_line_string)
2489 (marginal_area_string):
2490 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 2491 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
2492 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2493 (duration_to_sec_usec): New function, to check for overflow better.
2494 (Fsleep_for, sit_for): Use it.
2495 * doc.c (get_doc_string, store_function_docstring):
2496 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2497 (get_doc_string, Fsnarf_documentation):
2498 Use int, not EMACS_INT, where int is wide enough.
2499 (get_doc_string):
2500 Use SAFE_ALLOCA, not alloca.
2501 Check for overflow when converting EMACS_INT to off_t.
2502 * doprnt.c (doprnt):
2503 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2504 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
2505 Don't assume uid_t fits into fixnum.
2506 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
2507 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
2508 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
2509 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
2510 (general_insert_function)
2511 (Finsert_char, make_buffer_string, make_buffer_string_both)
2512 (update_buffer_properties, Fbuffer_substring)
2513 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
2514 (Fsubst_char_in_region, check_translation)
2515 (Ftranslate_region_internal, save_restriction_restore, Fformat)
2516 (transpose_markers, Ftranspose_regions):
2517 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2518 (clip_to_bounds): Move to lisp.h as an inline function).
2519 (Fconstrain_to_field): Don't assume integers are nonnegative.
2520 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
2521 (Fsubst_char_in_region, Fsave_restriction):
2522 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2523 (Femacs_pid): Don't assume pid_t fits into fixnum.
2524 (lo_time): Use int, not EMACS_INT, when int suffices.
2525 (lisp_time_argument): Check for usec out of range.
2526 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
2527 (Fuser_login_name, Fuser_full_name): Signal an error
2528 if a uid argument is out of range, rather than relying on
2529 undefined behavior.
c8d5c857
PE
2530 (Fformat_time_string): Remove now-unnecessary check.
2531 lisp_time_argument checks for out-of-range usec now.
243e0530 2532 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
2533 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
2534 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
2535 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
2536 (init_cmdargs, Fdump_emacs):
2537 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2538 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
2539 the bottom (typically) 32 bits of the fixnum.
2540 * eval.c (specpdl_size, call_debugger):
2541 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2542 (when_entered_debugger, Fbacktrace_debug):
2543 Don't assume fixnum can fit in int.
2544 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
2545 the object just before a buffer; this is not portable.
2546 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
2547 (grow_specpdl, unbind_to):
2548 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2549 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
2550 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 2551 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
2552 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
2553 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
2554 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2555 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
2556 (a_write, e_write):
2557 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2558 (Fcopy_file, non_regular_nbytes, read_non_regular)
2559 (Finsert_file_contents):
2560 Use int, not EMACS_INT, where int is wide enough.
2561 (READ_BUF_SIZE): Verify that it fits in int.
2562 (Finsert_file_contents): Check that counts are in proper range,
2563 rather than assuming fixnums fit into ptrdiff_t etc.
2564 Don't assume fixnums fit into int.
125b3835 2565 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
2566 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
2567 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
2568 (string_char_to_byte, string_byte_to_char)
2569 (string_make_multibyte, string_to_multibyte)
2570 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
2571 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
2572 (substring_both, Fdelete, internal_equal, Ffillarray)
2573 (Fclear_string, mapcar1)
2574 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
2575 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
2576 (larger_vector, make_hash_table, maybe_resize_hash_table)
2577 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
2578 (Fmaphash, secure_hash):
2579 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2580 (concat): Check for string index and length overflow.
2581 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
2582 (Frequire):
2583 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2584 (larger_vector): New API (vec, incr_min, size_max) replaces old
2585 one (vec, new_size, init). This catches size overflow.
2586 INIT was removed because it was always Qnil.
2587 All callers changed.
2588 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
2589 the upper bound on a hash table index size.
2590 (make_hash_table, maybe_resize_hash_table): Use it.
2591 (secure_hash): Computer start_byte and end_byte only after
2592 they're known to be in ptrdiff_t range.
2593 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
2594 (Ffont_get_glyphs, Ffont_at):
2595 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2596 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
2597 (Flist_fonts, Fopen_font):
2598 Don't assume fixnum can fit in int.
2599 (check_gstring): Don't assume index can fit in int.
2600 (font_match_p): Check that fixnum is a character, not a nonnegative
2601 fixnum, since the later code needs to stuff it into an int.
2602 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
2603 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
2604 conversion overflow issues.
2605 (Fopen_font): Check for integer out of range.
2606 (Ffont_get_glyphs): Don't assume index can fit in int.
2607 * font.h: Adjust decls to match defn changes elsewhere.
2608 * fontset.c (reorder_font_vector): Redo score calculation to avoid
2609 integer overflow.
2610 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
2611 printmax_t, where ptrdiff_t is wide enough.
2612 (Finternal_char_font):
2613 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2614 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
2615 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
2616 (Fset_frame_position, x_set_frame_parameters)
2617 (x_set_line_spacing, x_set_border_width)
2618 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
2619 Check that fixnums are in proper range for system types.
2620 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
2621 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2622 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
2623 Use SAFE_ALLOCA_LISP, not alloca.
2624 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
2625 intptr_t is wide enough.
2626 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
2627 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
2628 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
2629 Check for fixnum out of range.
2630 * ftfont.c (ftfont_list): Don't assume index fits in int.
2631 Check that fixnums are in proper range for system types.
2632 (ftfont_shape_by_flt):
2633 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
2634 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2635 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2636 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
2637 Check that fixnums are in proper range for system types.
2638 * gnutls.h: Adjust decls to match defn changes elsewhere.
2639 * gtkutil.c (xg_dialog_run):
2640 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2641 (update_frame_tool_bar):
2642 Check that fixnums are in proper range for system types.
2643 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 2644 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
2645 * indent.c (last_known_column, last_known_column_point):
2646 (current_column_bol_cache):
2647 (skip_invisible, current_column, check_display_width):
2648 (check_display_width, scan_for_column, current_column_1)
2649 (Findent_to, Fcurrent_indentation, position_indentation)
2650 (indented_beyond_p, Fmove_to_column, compute_motion):
2651 (Fcompute_motion, Fvertical_motion):
2652 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2653 (last_known_column_modified): Use EMACS_INT, not int.
2654 (check_display_width):
2655 (Fcompute_motion):
2656 Check that fixnums and floats are in proper range for system types.
2657 (compute_motion): Don't assume index or fixnum fits in int.
2658 (compute_motion, Fcompute_motion):
2659 Use int, not EMACS_INT, when it is wide enough.
2660 (vmotion): Omit local var start_hpos that is always 0; that way
2661 we don't need to worry about overflow in expressions involving it.
2662 * indent.h: Adjust decls to match defn changes elsewhere.
2663 (struct position):
2664 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2665 Use int, not EMACS_INT, where int is wide enough.
2666 Remove unused members ovstring_chars_done and tab_offset;
2667 all uses removed.
2668 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
2669 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
2670 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
2671 (make_gap, copy_text, insert, insert_and_inherit)
2672 (insert_before_markers, insert_before_markers_and_inherit)
2673 (insert_1, count_combining_before, count_combining_after)
2674 (insert_1_both, insert_from_string)
2675 (insert_from_string_before_markers, insert_from_string_1)
2676 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
2677 (adjust_after_replace, adjust_after_insert, replace_range)
2678 (replace_range_2, del_range, del_range_1, del_range_byte)
2679 (del_range_both, del_range_2, modify_region)
2680 (prepare_to_modify_buffer, signal_before_change)
2681 (signal_after_change, Fcombine_after_change_execute):
2682 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2683 * intervals.c (traverse_intervals, rotate_right, rotate_left)
2684 (balance_an_interval, split_interval_right, split_interval_left)
2685 (find_interval, next_interval, update_interval)
2686 (adjust_intervals_for_insertion, delete_node, delete_interval)
2687 (interval_deletion_adjustment, adjust_intervals_for_deletion)
2688 (static_offset_intervals, offset_intervals)
2689 (merge_interval_right, merge_interval_left, make_new_interval)
2690 (graft_intervals_into_buffer, temp_set_point_both)
2691 (temp_set_point, set_point, adjust_for_invis_intang)
2692 (set_point_both, move_if_not_intangible, get_property_and_range)
2693 (get_local_map, copy_intervals, copy_intervals_to_string)
2694 (compare_string_intervals, set_intervals_multibyte_1):
2695 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2696 * intervals.h: Adjust decls to match defn changes elsewhere.
2697 (struct interval):
2698 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2699 * keyboard.c (this_command_key_count, this_single_command_key_start)
2700 (before_command_key_count, before_command_echo_length, echo_now)
2701 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
2702 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
2703 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
2704 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
2705 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2706 (last_non_minibuf_size, last_point_position, echo_truncate)
2707 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
2708 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
2709 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
2710 (stuff_buffered_input):
2711 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2712 (last_auto_save, command_loop_1, read_char):
2713 Use EMACS_INT, not int, to avoid integer overflow.
2714 (record_char): Avoid overflow in total_keys computation.
2715 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
2716 * keyboard.h: Adjust decls to match defn changes elsewhere.
2717 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
2718 (Fkey_description, Fdescribe_vector, Flookup_key):
2719 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2720 (click_position): New function, to check that positions are in range.
2721 (Fcurrent_active_maps):
2722 (describe_command):
2723 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2724 (Faccessible_keymaps, Fkey_description):
2725 (preferred_sequence_p):
2726 Don't assume fixnum can fit into int.
2727 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
2728 Check for integer overflow in size calculations.
2729 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
2730 avoid mishandling large integers.
2731 * lisp.h: Adjust decls to match defn changes elsewhere.
2732 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
2733 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
2734 (struct Lisp_Marker):
2735 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2736 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
2737 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
2738 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
2739 All callers changed.
2740 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
2741 Assume the arg has valid form, since it always does.
2742 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
2743 unsigned integer system type.
2744 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
2745 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
2746 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2747 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
2748 (duration_to_sec_usec): New decl.
2749 * lread.c (read_from_string_index, read_from_string_index_byte)
2750 (read_from_string_limit, readchar, unreadchar, openp)
2751 (read_internal_start, read1, oblookup):
2752 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2753 (Fload, readevalloop, Feval_buffer, Feval_region):
2754 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2755 (openp): Check for out-of-range argument to 'access'.
2756 (read1): Use int, not EMACS_INT, where int is wide enough.
2757 Don't assume fixnum fits into int.
6efdadfd 2758 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
2759 (read_filtered_event): Use duration_to_sec_usec
2760 to do proper overflow checking on durations.
d311d28c
PE
2761 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
2762 in size calculation.
2763 (Fexecute_kbd_macro):
2764 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2765 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
2766 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
2767 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
2768 (set_marker_both, set_marker_restricted_both, marker_position)
2769 (marker_byte_position, Fbuffer_has_markers_at):
2770 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2771 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 2772 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
2773 It now merely ensures that the menu is large enough, without
2774 necessarily growing it, as this avoids some integer overflow issues.
2775 All callers changed.
2776 (keymap_panes, parse_single_submenu, Fx_popup_menu):
2777 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2778 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
2779 Use SAFE_ALLOCA_LISP, not alloca.
2780 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
2781 to EMACS_INT. Check that fixnums are in proper range for system types.
2782 * minibuf.c (minibuf_prompt_width, string_to_object)
2783 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
2784 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
2785 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2786 (get_minibuffer, read_minibuf_unwind):
2787 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2788 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
2789 this simplifies overflow checking. All callers changed.
2790 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
2791 (Ftest_completion):
2792 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2793 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
2794 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
2795 Check that fixnums are in proper range for system types.
2796 (Fx_create_frame, Fx_show_tip):
2797 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2798 * nsfont.m (ns_findfonts, nsfont_list_family):
2799 Don't assume fixnum fits in long.
2800 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
2801 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2802 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
2803 wide enough.
17fdb222 2804 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
2805 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2806 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
2807 (PRINTDECLARE, PRINTPREPARE):
2808 (strout, print_string):
2809 (print, print_preprocess, print_check_string_charset_prop)
2810 (print_object):
2811 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2812 (PRINTDECLARE):
2813 (temp_output_buffer_setup, Fprin1_to_string, print_object):
2814 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2815 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 2816 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 2817 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
2818 (print_error_message): Use SAFE_ALLOCA, not alloca.
2819 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
2820 (print_depth, new_backquote_output, print_number_index):
2821 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
2822 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
2823 (Fset_process_window_size, Fformat_network_address)
2824 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 2825 (sigchld_handler):
d311d28c 2826 Check that fixnums are in proper range for system types.
d44287d4 2827 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
2828 Check for process-ids out of pid_t range rather than relying on
2829 undefined behavior.
e4d81efc 2830 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
2831 (Fformat_network_address, read_process_output, send_process)
2832 (Fprocess_send_region, status_notify):
2833 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2834 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
2835 (wait_reading_process_output, read_process_output, exec_sentinel):
2836 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2837 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
2838 (Faccept_process_output): Use duration_to_sec_usec to do proper
2839 overflow checking on durations.
dde14581
PE
2840 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
2841 Don't assume pid_t fits in int.
02481186
PE
2842 * process.h (struct Lisp_Process): Members tick and update_tick
2843 are now of type EMACS_INT, not int.
b62b53e8
PE
2844 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
2845 configured --with-wide-int.
d311d28c
PE
2846 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
2847 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
2848 * search.c (looking_at_1, string_match_1):
2849 (fast_string_match, fast_c_string_match_ignore_case)
2850 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
2851 (scan_newline, find_before_next_newline, search_command)
2852 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
2853 (set_search_regs, wordify):
2854 (Freplace_match):
2855 (Fmatch_data):
2856 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2857 (string_match_1, search_buffer, set_search_regs):
2858 (Fmatch_data):
2859 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2860 (wordify): Check for overflow in size calculation.
2861 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
2862 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
2863 Check that fixnums are in proper range for system types.
2864 * sound.c (struct sound_device)
2865 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
2866 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2867 (Fplay_sound_internal):
2868 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 2869 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
2870 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
2871 (Fparse_partial_sexp):
2872 Don't assume fixnums can fit in int.
2873 (struct lisp_parse_state, find_start_pos, find_start_value)
2874 (find_start_value_byte, find_start_begv)
2875 (update_syntax_table, char_quoted, dec_bytepos)
2876 (find_defun_start, prev_char_comend_first, back_comment):
2877 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
2878 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
2879 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2880 (Finternal_describe_syntax_value): Check that match_lisp is a
2881 character, not an integer, since the code stuffs it into int.
2882 (scan_words, scan_sexps_forward):
2883 Check that fixnums are in proper range for system types.
2884 (Fforward_word):
2885 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2886 (scan_sexps_forward):
2887 Use CHARACTERP, not INTEGERP, since the value must fit into int.
2888 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
2889 * syntax.h: Adjust decls to match defn changes elsewhere.
2890 (struct gl_state_s):
2891 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
2892 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
2893 MOST_POSITIVE_FIXNUM.
d311d28c
PE
2894 * sysdep.c (wait_for_termination_1, wait_for_termination)
2895 (interruptible_wait_for_termination, mkdir):
2896 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
2897 (emacs_read, emacs_write):
2898 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
2899 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
2900 and double all fit in int.
d311d28c
PE
2901 * term.c (set_tty_color_mode):
2902 Check that fixnums are in proper range for system types.
2903 * termhooks.h (struct input_event):
2904 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2905 * textprop.c (validate_interval_range, interval_of)
2906 (Fadd_text_properties, set_text_properties_1)
2907 (Fremove_text_properties, Fremove_list_of_text_properties)
2908 (Ftext_property_any, Ftext_property_not_all)
2909 (copy_text_properties, text_property_list, extend_property_ranges)
2910 (verify_interval_modification):
2911 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2912 (Fnext_single_char_property_change)
2913 (Fprevious_single_char_property_change):
2914 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
2915 (copy_text_properties):
2916 Check for integer overflow in index calculation.
d311d28c
PE
2917 * undo.c (last_boundary_position, record_point, record_insert)
2918 (record_delete, record_marker_adjustment, record_change)
2919 (record_property_change):
2920 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2921 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
2922 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2923 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2924 (Fx_hide_tip, Fx_file_dialog):
2925 * w32menu.c (set_frame_menubar):
2926 Use ptrdiff_t, not int, for consistency with rest of code.
2927 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
2928 (select_window, Fdelete_other_windows_internal)
2929 (window_scroll_pixel_based, window_scroll_line_based)
2930 (Frecenter, Fset_window_configuration):
2931 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2932 (Fset_window_hscroll, run_window_configuration_change_hook)
2933 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 2934 (Fscroll_other_window, Frecenter):
d311d28c
PE
2935 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2936 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
2937 Don't assume fixnum fits in int.
2938 (Fset_window_scroll_bars):
2939 Check that fixnums are in proper range for system types.
2940 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
2941 (string_pos, c_string_pos, number_of_chars, init_iterator)
2942 (in_ellipses_for_invisible_text_p, init_from_display_pos)
2943 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
2944 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
2945 (face_before_or_after_it_pos, handle_invisible_prop)
2946 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
2947 (display_prop_intangible_p, string_buffer_position_lim)
2948 (string_buffer_position, handle_composition_prop, load_overlay_strings)
2949 (get_overlay_strings_1, get_overlay_strings)
2950 (iterate_out_of_display_property, forward_to_next_line_start)
2951 (back_to_previous_visible_line_start, reseat, reseat_to_string)
2952 (get_next_display_element, set_iterator_to_next)
2953 (get_visually_first_element, compute_stop_pos_backwards)
2954 (handle_stop_backwards, next_element_from_buffer)
2955 (move_it_in_display_line_to, move_it_in_display_line)
2956 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2957 (add_to_log, message_dolog, message_log_check_duplicate)
2958 (message2, message2_nolog, message3, message3_nolog
2959 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
2960 (current_message_1, truncate_echo_area, truncate_message_1)
2961 (set_message, set_message_1, store_mode_line_noprop)
2962 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
2963 (text_outside_line_unchanged_p, check_point_in_composition)
2964 (reconsider_clip_changes)
2965 (redisplay_internal, set_cursor_from_row, try_scrolling)
2966 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
2967 (redisplay_window, find_last_unchanged_at_beg_row)
2968 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
2969 (trailing_whitespace_p, find_row_edges, display_line)
2970 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
2971 (display_mode_element, store_mode_line_string)
2972 (pint2str, pint2hrstr, decode_mode_spec)
2973 (display_count_lines, display_string, draw_glyphs)
2974 (x_produce_glyphs, x_insert_glyphs)
2975 (rows_from_pos_range, mouse_face_from_buffer_pos)
2976 (fast_find_string_pos, mouse_face_from_string_pos)
2977 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2978 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2979 (safe_call, init_from_display_pos, handle_fontified_prop)
2980 (handle_single_display_spec, load_overlay_strings)
2981 (with_echo_area_buffer, setup_echo_area_for_printing)
2982 (display_echo_area, echo_area_display)
2983 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
2984 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
2985 (redisplay_window, dump_glyph_row, display_mode_line)
2986 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 2987 (handle_display_spec, display_prop_string_p):
d311d28c
PE
2988 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2989 (handle_single_display_spec, build_desired_tool_bar_string)
2990 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
2991 (get_specified_cursor_type):
2992 Check that fixnums are in proper range for system types.
2993 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
2994 (Flookup_image_map):
2995 Don't assume fixnums fit in int.
2996 (compare_overlay_entries):
2997 Avoid mishandling comparisons due to subtraction overflow.
2998 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
2999 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
3000 (handle_tool_bar_click):
3001 Use int, not unsigned, since we prefer signed and the signedness
3002 doesn't matter here.
3003 (get_next_display_element, next_element_from_display_vector):
3004 Use int, not EMACS_INT, when int is wide enough.
3005 (start_hourglass): Use duration_to_sec_usec to do proper
3006 overflow checking on durations.
3007 * xfaces.c (Fbitmap_spec_p):
3008 Check that fixnums are in proper range for system types.
3009 (compare_fonts_by_sort_order):
3010 Avoid mishandling comparisons due to subtraction overflow.
3011 (Fx_family_fonts, realize_basic_faces):
3012 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3013 (Fx_family_fonts):
3014 Don't assume fixnum fits in int.
3015 Use SAFE_ALLOCA_LISP, not alloca.
3016 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
3017 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
3018 (face_at_buffer_position, face_for_overlay_string)
3019 (face_at_string_position):
3020 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3021 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
3022 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
3023 (Fx_show_tip):
3024 Check that fixnums are in proper range for system types.
3025 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3026 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
3027 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3028 (Fx_change_window_property): Don't assume fixnums fit in int.
3029 * xfont.c (xfont_chars_supported):
3030 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3031 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
3032 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
3033 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3034 * xml.c (parse_region):
3035 * xrdb.c (magic_file_p):
3036 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3037 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
3038 (x_get_local_selection, x_reply_selection_request)
3039 (x_handle_selection_request, wait_for_property_change):
3040 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3041 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
3042 short is wide enough.
3043 (x_send_client_event): Don't assume fixnum fits in int.
3044 * xterm.c (x_x_to_emacs_modifiers):
3045 Don't assume EMACS_INT overflows nicely into int.
3046 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
3047 may come from Lisp.
3048 (handle_one_xevent): NATNUMP can eval its arg twice.
3049 (x_connection_closed):
3050 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3051 * xterm.h: Adjust decls to match defn changes elsewhere.
3052 (struct scroll_bar): Use struct vectorlike_header
3053 rather than rolling our own approximation.
3054 (SCROLL_BAR_VEC_SIZE): Remove; not used.
3055
c6574eb5
GM
30562012-05-25 Glenn Morris <rgm@gnu.org>
3057
3058 * lisp.mk (lisp): Update for more files being compiled now.
3059
e8d32c7e
SM
30602012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
3061
48def666
SM
3062 * lread.c: Remove `read_pure' which makes no difference.
3063 (read_pure): Remove var.
3064 (unreadpure): Remove function.
3065 (readevalloop): Don't call read_list with -1 flag.
3066 (read1, read_vector): Don't test read_pure any more.
3067 (read_list): Simplify.
3068
e8d32c7e
SM
3069 * fileio.c, character.h: Minor style tweaks.
3070
4b2addb7
DA
30712012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
3072
3073 * window.h (clip_changed): Remove useless declaration.
3074
584461b2
JB
30752012-05-22 Juanma Barranquero <lekktu@gmail.com>
3076
3077 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
3078 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
3079
34374650
PE
30802012-05-22 Paul Eggert <eggert@cs.ucla.edu>
3081
3082 Remove src/m/*.
3083 This directory predates autoconf and is no longer needed nowadays.
3084 Move its few remaining bits of functionality to where they're needed.
3085 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
3086 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
3087 * m/template.h: Remove.
3088 * Makefile.in (M_FILE): Remove. All uses removed.
3089 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
3090 * lisp.h (USE_LSB_TAG):
3091 * mem-limits.h (EXCEEDS_LISP_PTR):
3092 Use VAL_MAX, not VALBITS, in #if.
3093 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
3094 (EMACS_UINT): Define unconditionally now.
3095 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
3096 (BITS_PER_EMACS_INT): New constants, replacing
3097 what used to be in config.h, but not useful in #if.
3098 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
3099 define them any more.
3100 (VAL_MAX): New macro.
3101 (VALMASK): Use it.
3102 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
3103 BITS_PER_EMACS_INT, in #if.
3104 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
3105 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
3106 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
3107 * s/ms-w32.h (DATA_START):
3108 Move here from removed file m/intel386.h.
3109 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
3110 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
3111
261cb4bb
PE
31122012-05-21 Paul Eggert <eggert@cs.ucla.edu>
3113
3114 Assume C89 or later.
3115 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
3116 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
3117 (xrealloc):
3118 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
3119 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
3120 * textprop.c, tparam.c (NULL): Remove.
3121 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
3122 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
3123 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
3124 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
3125 * xterm.c (input_signal_count): Assume volatile works.
3126
ff23cd9f
KB
31272012-05-21 Ken Brown <kbrown@cornell.edu>
3128
3129 * xgselect.c (xg_select): Fix first argument in call to 'select'
3130 (bug#11508).
3131
1b170bc6
KB
31322012-05-20 Ken Brown <kbrown@cornell.edu>
3133
3134 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 3135 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 3136
b2f4d39f
KB
31372012-05-19 Ken Brown <kbrown@cornell.edu>
3138
3139 * xfns.c (x_in_use): Remove `static' qualifier.
3140 * xterm.h (x_in_use): Declare.
3141 * xgselect.c: Include xterm.h.
3142 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
3143 and `display_arg' (bug#9754).
3144
003fdae2
PE
31452012-05-19 Paul Eggert <eggert@cs.ucla.edu>
3146
9232a6d9
PE
3147 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
3148
003fdae2
PE
3149 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
3150 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
3151
784b56e2
EZ
31522012-05-18 Eli Zaretskii <eliz@gnu.org>
3153
3154 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
3155
3156 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 3157 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
3158
3159 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
3160 reference to image_cache->refcount.
3161 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
3162
a0a79cde
JL
31632012-05-17 Juri Linkov <juri@jurta.org>
3164
3165 * search.c (Fword_search_regexp, Fword_search_backward)
3166 (Fword_search_forward, Fword_search_backward_lax)
3167 (Fword_search_forward_lax): Move functions to isearch.el
3168 (bug#10145, bug#11381).
3169
b0572523
PE
31702012-05-16 Paul Eggert <eggert@cs.ucla.edu>
3171
3172 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
3173
9660f5fc
SM
31742012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3175
3176 * lread.c (init_obarray): Declare Qt and Qnil as special.
3177
4374de83
GM
31782012-05-14 Glenn Morris <rgm@gnu.org>
3179
3180 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 3181 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 3182
dc44c39a
PE
31832012-05-14 Paul Eggert <eggert@cs.ucla.edu>
3184
078c97cb
PE
3185 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
3186
dc44c39a
PE
3187 * unexaix.c: Port to more-recent AIX compilers.
3188 (report_error, report_error_1, make_hdr, copy_sym)
3189 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
3190 Make arguments const char *, not char *, to avoid violations of C
3191 standard and to fix some AIX warnings reported by Gilles Pion.
3192
e18afed7 31932012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
3194
3195 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
3196 already have overlays loaded.
3197 (handle_single_display_spec): Before returning without displaying
3198 fringe bitmap, synchronize the bidi iterator with the main display
3199 iterator, by calling iterate_out_of_display_property.
3200 (iterate_out_of_display_property): Detect buffer iteration by
3201 testing that it->string is a Lisp string.
3202 (get_next_display_element): When the current object is exhausted,
3203 and there's something on it->stack, call set_iterator_to_next to
3204 proceed with what's on the stack, instead of returning zero.
3205 (set_iterator_to_next): If called at the end of a Lisp string,
3206 proceed to consider_string_end without incrementing string
3207 position. Don't increment display vector index past the end of
3208 the display vector. (Bug#11417)
c8fb9dc6
EZ
3209 (pos_visible_p): Don't report a position visible when move_it_to
3210 stopped at the last line of window, which happens to be scanned
3211 backwards by the bidi iteration. (Bug#11464)
ac268e67 3212
e18afed7 32132012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
3214
3215 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
3216 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
3217 are on a TTY, and thus unable to display on the fringes.
3218 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
3219 so we need to signal to the caller that this is a "replacing"
3220 display spec. This fixes display when the spec is invalid or we
3221 are on a TTY.
3222
e18afed7 32232012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
3224
3225 * unexaix.c (make_hdr): Fix typo in prototype.
3226 This bug broke the build on AIX. Problem reported by Gilles Pion.
3227
9d0a235a
MA
32282012-05-14 Michael Albinus <michael.albinus@gmx.de>
3229
3230 * keyboard.c (kbd_buffer_get_event): Read special events also in
3231 batch mode. (Bug#11415)
3232
9e6b06ed
GM
32332012-05-12 Glenn Morris <rgm@gnu.org>
3234
3235 * ns.mk: Update for ns_appbindir no longer having trailing "/".
3236
c1a1d7a3
EZ
32372012-05-12 Eli Zaretskii <eliz@gnu.org>
3238
3239 * lisp.mk (lisp): Add newcomment.elc.
3240
3fe7cdc8
GM
32412012-05-12 Glenn Morris <rgm@gnu.org>
3242
3243 * Makefile.in (MKDIR_P): New, set by configure.
3244 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
3245
53f7d2c0
PE
32462012-05-11 Paul Eggert <eggert@cs.ucla.edu>
3247
3248 Remove unused function hourglass_started.
3249 * dispextern.h (hourglass_started):
3250 * w32fns.c (hourglass_started):
3251 * xdisp.c (hourglass_started): Remove.
3252
75aafb17
JB
32532012-05-10 Juanma Barranquero <lekktu@gmail.com>
3254
3255 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
3256 Update dependencies.
3257
12959e8e
PE
32582012-05-10 Paul Eggert <eggert@cs.ucla.edu>
3259
97107e2e
PE
3260 * xgselect.c (xg_select): Put maxfds+1 into a var.
3261 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
3262
12959e8e
PE
3263 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
3264
836d29b3
DA
32652012-05-10 Dave Abrahams <dave@boostpro.com>
3266
3267 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
3268 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
3269
5cb67954
MA
32702012-05-09 Michael Albinus <michael.albinus@gmx.de>
3271
3272 * dbusbind.c (xd_registered_buses): New internal Lisp object.
3273 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
3274 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
3275 Initialize xd_registered_buses.
3276
3478ec45
PE
32772012-05-09 Paul Eggert <eggert@cs.ucla.edu>
3278
b263a6b0
PE
3279 Untag more efficiently if USE_LSB_TAG.
3280 This is based on a proposal by YAMAMOTO Mitsuharu in
3281 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
3282 For an admittedly artificial (nth 8000 longlist) benchmark on
3283 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
3284 Emacs's overall text size by 1%.
3285 * lisp.h (XUNTAG): New macro.
3286 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
3287 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
3288 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
3289 * eval.c (Fautoload):
3290 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
3291 * frame.h (XFRAME): Use XUNTAG.
3292
3478ec45
PE
3293 Port recent dbusbind.c changes to 32-bit --with-wide-int.
3294 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
3295 Remove unportable assumptions about print widths of types like
3296 dbus_uint32_t.
3297 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
3298 intptr_t when converting between pointer and integer, to avoid GCC
3299 warnings about wrong width.
3300
666b903b 33012012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
3302
3303 * w32proc.c (new_child): Force Windows to reserve only 64KB of
3304 stack for each reader_thread, instead of defaulting to 8MB
3305 determined by the linker. This avoids failures in creating
3306 subprocesses on Windows 7, see the discussion in this thread:
3307 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
3308
b120cc17
JC
33092012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
3310
3311 Fix up display of the *Minibuf-0* buffer in the mini window.
3312 * keyboard.c (read_char): Don't clear the echo area if there's no
3313 message to clear.
3314 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 3315 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 3316
9a4b36f8
MA
33172012-05-07 Michael Albinus <michael.albinus@gmx.de>
3318
3319 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
3320 batch mode.
3321
e5f9458f
CY
33222012-05-06 Chong Yidong <cyd@gnu.org>
3323
3324 * lisp.mk (lisp): Update.
3325
eceeb5fc 33262012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
3327
3328 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
3329
71873e2b
SM
33302012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3331
3332 * data.c (PUT_ERROR): New macro.
3333 (syms_of_data): Use it. Add new error type `user-error'.
3334 * undo.c (user_error): New function.
3335 (Fprimitive_undo): Use it.
3336 * print.c (print_error_message): Adjust print style for `user-error'.
3337 * keyboard.c (user_error): New function.
3338 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
3339
ab0fa4e4
PE
33402012-05-03 Paul Eggert <eggert@cs.ucla.edu>
3341
3342 Do not limit current-time-string to years 1000..9999.
3343 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
3344 (Fcurrent_time_string): Support any year that is supported by the
3345 underlying localtime representation. Don't use asctime, as it
3346 has undefined behavior for years outside the range -999..9999.
3347
7ed806a7
PE
33482012-05-02 Paul Eggert <eggert@cs.ucla.edu>
3349
3350 Fix race conditions involving setenv, gmtime, localtime, asctime.
3351 Without this fix, interrupts could mess up code that uses these
3352 nonreentrant functions, since setting TZ invalidates existing
3353 tm_zone or tzname values, and since most of these functions return
3354 pointers to static storage.
3355 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
3356 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
3357 Grow the critical sections to include not just invoking
3358 localtime/gmtime, but also accessing these functions' results
3359 including their tm_zone values if any, and any related TZ setting.
3360 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
3361 so that the struct tm is saved in the critical section.
3362 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
3363 motivated by the fact that memory allocation needs to be outside
3364 the critical section.
3365
0c16dfed
DA
33662012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
3367
3368 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
3369 with RESET_INTERVAL.
3370
3371 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3372 Remove duplicated buffer name initialization.
3373
3f83ace8
JM
33742012-05-02 Jim Meyering <jim@meyering.net>
3375
3376 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
3377
c7b8541e
JM
3378 * xfns.c (x_window): Use xstrdup (Bug#11375).
3379
90207a15 33802012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
3381
3382 * xdisp.c (pos_visible_p): If already at a newline from the
3383 display string before the 'while' loop, don't walk back the glyphs
3384 from it3.glyph_row. Solves assertion violation when the display
3385 string begins with a newline (egg.el). (Bug#11367)
3386
b593d6a9
AH
33872012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
3388
3389 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
3390 Move to simple.el.
3391
4737362e
GM
33922012-05-01 Glenn Morris <rgm@gnu.org>
3393
99cf43f9
GM
3394 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
3395 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
3396 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
3397 All were removed before 23.1.
3398
9311dcff
GM
3399 * dispnew.c: Remove HAVE_LIBNCURSES test;
3400 it is always true on relevant platforms.
3401
4d5c6349
GM
3402 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
3403 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
3404
4737362e
GM
3405 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
3406
74dd3a6b
AS
34072012-04-30 Andreas Schwab <schwab@linux-m68k.org>
3408
3409 * .gdbinit (xpr): Remove checks for no longer existing misc types.
3410 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
3411 Remove.
3412
13c379ee
PE
34132012-04-28 Paul Eggert <eggert@cs.ucla.edu>
3414
3415 Do not avoid creating empty evaporating overlays (Bug#9642).
3416 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
3417 That is, do not delete an evaporating overlay if it becomes
3418 empty after its bounds are adjusted to fit within its buffer.
3419 This fix caused other problems, and I'm reverting it until we get
3420 to the bottom of them.
3421
a8e7d6d7 34222012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
3423
3424 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
3425
a8e7d6d7 34262012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
3427
3428 * xdisp.c (pos_visible_p): If the window start position is beyond
3429 ZV, start the display from buffer beginning. Prevents assertion
3430 violation in init_iterator when the minibuffer window is scrolled
3431 via the scroll bar.
3432
3433 * window.c (window_scroll_pixel_based): Likewise.
3434
a8e7d6d7 34352012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
3436
3437 * keymap.c (where_is_internal): Doc fix (Bug#10872).
3438
a8e7d6d7 34392012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
3440
3441 * fileio.c (Fcopy_file, Fset_file_selinux_context):
3442 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
3443
a8e7d6d7 34442012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 3445
b593d6a9
AH
3446 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
3447 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 3448
1c6900d9
EZ
34492012-04-26 Eli Zaretskii <eliz@gnu.org>
3450
4c3fa1d9
EZ
3451 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
3452 display element, check also the underlying string or buffer
3453 character. (Bug#11341)
3454
1c6900d9
EZ
3455 * w32menu.c: Include w32heap.h.
3456 (add_menu_item): If the call to AppendMenuW (via
3457 unicode_append_menu) fails, disable Unicode menus only if we are
3458 running on Windows 9X/Me.
3459
42bf8205
AS
34602012-04-24 Andreas Schwab <schwab@linux-m68k.org>
3461
3462 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
3463 (xgetint): Add missing shift for LSB tags.
3464
b1bac16e
MR
34652012-04-24 Martin Rudalics <rudalics@gmx.at>
3466
3467 * keyboard.c (read_char): Don't wipe echo area for select window
3468 events: These might get delayed via `mouse-autoselect-window'
3469 (Bug#11304).
3470
d69621cc
JB
34712012-04-24 Juanma Barranquero <lekktu@gmail.com>
3472
3473 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
3474 manipulation of :loaded-from data.
3475
02fd101b
JB
34762012-04-23 Juanma Barranquero <lekktu@gmail.com>
3477
3478 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
3479 now a cons (bug#11311).
3480
888bec30
PE
34812012-04-23 Paul Eggert <eggert@cs.ucla.edu>
3482
89a438bd
PE
3483 Do not create empty overlays with the evaporate property (Bug#9642).
3484 * buffer.c (Fmove_overlay): Delete an evaporating overlay
3485 if it becomes empty after its bounds are adjusted to fit within
3486 its buffer. Without this fix, in a nonempty buffer (let ((o
3487 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
3488 yields an empty overlay that has the evaporate property, which is
3489 not supposed to happen.
3490
1068fe4d
PE
3491 Fix minor GTK3 problems found by static checking.
3492 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3493 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3494 (struct _EmacsFixedClass, emacs_fixed_get_type):
3495 Move decls here from emacsgtkfixed.h, since they needn't be public.
3496 (emacs_fixed_get_type): Now static.
3497 (emacs_fixed_class_init): Omit unused local.
3498 (emacs_fixed_child_type): Remove; unused.
3499 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3500 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3501 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
3502 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
3503 (EMACS_FIXED_GET_CLASS): Remove; unused.
3504 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
3505
888bec30
PE
3506 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
3507 Problem reported by Juanma Barranquero for Windows -Wunused-function.
3508
de85e130
PE
35092012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3510
d0baac98 3511 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 3512 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
3513 (__malloc_size_t, __malloc_ptrdiff_t):
3514 Remove. All uses removed, replaced by the definiens if needed,
3515 since we can assume C89 or better now.
3516 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
3517 (protect_malloc_state, align, get_contiguous_space)
3518 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
3519 (malloc_atfork_handler_child, malloc_enable_thread)
3520 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
3521 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
3522 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
3523 (special_realloc, _realloc_internal_nolock, _realloc_internal)
3524 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
3525 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
3526 Define using prototypes, not old style.
3527 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
3528 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
3529 (align): Don't assume that signed integer overflow wraps around.
3530 Omit unused local var.
3531 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
3532 (_free_internal_nolock, memalign, mallochook, reallochook):
3533 Omit no-longer-needed casts.
3534 (valloc): Use getpagesize, not __getpagesize.
3535 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
3536 (struct hdr): The 'magic' member is now size_t, not unsigned long.
3537
de85e130
PE
3538 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
3539
dcbf5805
MA
35402012-04-22 Michael Albinus <michael.albinus@gmx.de>
3541
3542 Move functions from C to Lisp. Make non-blocking method calls
3543 the default. Implement further D-Bus standard interfaces.
3544
3545 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
3546 (QCdbus_request_name_allow_replacement)
3547 (QCdbus_request_name_replace_existing)
3548 (QCdbus_request_name_do_not_queue)
3549 (QCdbus_request_name_reply_primary_owner)
3550 (QCdbus_request_name_reply_in_queue)
3551 (QCdbus_request_name_reply_exists)
3552 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
3553 (QCdbus_registered_serial, QCdbus_registered_method)
3554 (QCdbus_registered_signal): New Lisp objects.
3555 (XD_DEBUG_MESSAGE): Use sizeof.
3556 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
3557 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
3558 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
3559 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
3560 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
3561 (xd_signature, xd_append_arg): Allow float for integer types.
3562 (xd_get_connection_references): New function.
b593d6a9
AH
3563 (xd_get_connection_address): Rename from xd_initialize.
3564 Return cached address.
dcbf5805
MA
3565 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
3566 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
3567 level.
3568 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 3569 Return number of refcounts.
dcbf5805
MA
3570 (Fdbus_get_unique_name): Make stronger parameter check.
3571 (Fdbus_message_internal): New defun.
3572 (Fdbus_call_method, Fdbus_call_method_asynchronously)
3573 (Fdbus_method_return_internal, Fdbus_method_error_internal)
3574 (Fdbus_send_signal, Fdbus_register_service)
3575 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
3576 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
3577 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
3578 (Vdbus_compiled_version, Vdbus_runtime_version)
3579 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
3580 (Vdbus_message_type_method_return, Vdbus_message_type_error)
3581 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
3582 (Vdbus_registered_buses, Vdbus_registered_objects_table):
3583 Adapt docstring.
dcbf5805 3584
52828e02
PE
35852012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3586
da05bc4c
PE
3587 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
3588 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
3589 Do not assume ptrdiff_t is the same width as 'int'.
3590
52828e02
PE
3591 * alloc.c: Handle unusual debugging option combinations.
3592 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
3593 since the two debugging options are incompatible.
3594 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
3595 is defined.
3596 (mem_init, mem_insert, mem_insert_fixup):
3597 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
3598 (NEED_MEM_INSERT): Remove; no longer needed.
3599
f01769f9
LL
36002012-04-22 Leo Liu <sdl.web@gmail.com>
3601
3602 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
3603
5790543d
PE
36042012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3605
3606 * sysdep.c [__FreeBSD__]: Minor cleanups.
3607 (list_system_processes, system_process_attributes) [__FreeBSD__]:
3608 Use Emacs indenting style more consistently. Avoid some casts.
3609 Use 'double' consistently rather than mixing 'float' and 'double'.
3610
b91b7e4d
EW
36112012-04-21 Eduard Wiebe <usenet@pusto.de>
3612
b593d6a9
AH
3613 * sysdep.c (list_system_processes, system_process_attributes):
3614 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 3615
6114eb15
AS
36162012-04-21 Andreas Schwab <schwab@linux-m68k.org>
3617
3618 * lisp.mk (lisp): Update.
3619
2f38dff7
PE
36202012-04-20 Paul Eggert <eggert@cs.ucla.edu>
3621
3622 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
3623 It is never used otherwise.
3624
4ae29f89
SM
36252012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
3626
3627 * print.c (print_preprocess): Only check print_depth if print-circle
3628 is nil.
3629 (print_object): Check for cycles even when print-circle is nil and
3630 print-gensym is t, but only check print_depth if print-circle is nil.
3631
f30d612a
CY
36322012-04-20 Chong Yidong <cyd@gnu.org>
3633
3634 * process.c (wait_reading_process_output): If EIO occurs on a pty,
3635 set the status to "failed" and ensure that sentinel is run.
3636
c07a4c0b 36372012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
3638
3639 * process.c (Fset_process_inherit_coding_system_flag)
3640 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 3641 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 3642
c07a4c0b 36432012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
3644
3645 * xdisp.c (string_buffer_position_lim): Limit starting position to
3646 BEGV.
3647 (set_cursor_from_row): If called for a mode-line or header-line
3648 row, return zero immediately.
3649 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
3650 farther than the first row after the header line, if any.
3651 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
3652 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
3653
c07a4c0b 36542012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 3655
4ae29f89
SM
3656 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
3657 (bug#11238).
ad3a2b41 3658
c07a4c0b 36592012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 36602012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
3661
3662 configure: new option --enable-gcc-warnings (Bug#11207)
3663 * Makefile.in (C_WARNINGS_SWITCH): Remove.
3664 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
3665 (ALL_CFLAGS): Use new macros rather than old.
3666 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
3667 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
3668 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
3669 -Wunused-result, -Wunused-variable. This should go away once
3670 the Emacs and Gnulib regex code is merged.
3671 (xmalloc, xrealloc): Now static.
3672
aba027e8
PE
36732012-04-17 Paul Eggert <eggert@cs.ucla.edu>
3674
3675 * dired.c (Fsystem_groups): Remove unused local.
3676
e5a36063
GM
36772012-04-17 Glenn Morris <rgm@gnu.org>
3678
3679 * dired.c (Fsystem_users): Doc fix.
3680
316411f0
DA
36812012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
3682
3683 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
3684 (syms_of_dired): Add them.
3685
9426aba4
PE
36862012-04-16 Paul Eggert <eggert@cs.ucla.edu>
3687
b62a57be
PE
3688 Fix minor alloc.c problems found by static checking.
3689 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
3690 New extern decls, to avoid calling undeclared functions.
3691 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
3692 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
3693 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
3694 (NEED_MEM_INSERT): New macro.
3695 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 3696 Remove one incorrect comment and fix another.
b62a57be 3697
3539f31f
PE
3698 Fix minor ralloc.c problems found by static checking.
3699 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3700 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
3701 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
3702 (r_alloc_sbrk): Now static.
3703
a041960a
PE
3704 Improve ralloc.c interface checking.
3705 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3706 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
3707 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
3708 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
3709 [REL_ALLOC]: ... to here, to check interface.
3710 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
3711 Remove decls. This fixes an "It stinks!".
3712
9426aba4
PE
3713 * alloc.c (which_symbols): Fix alignment issue / type clash.
3714
d55c12ed
AS
37152012-04-15 Andreas Schwab <schwab@linux-m68k.org>
3716
3717 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
3718 (struct Lisp_Misc_Any): Likewise.
3719 (struct Lisp_Free): Likewise.
3720 * alloc.c (union aligned_Lisp_Symbol): Define.
3721 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
3722 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
3723 (union aligned_Lisp_Misc): Define.
3724 (MARKER_BLOCK_SIZE, struct marker_block): Use union
3725 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 3726 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 3727
b948ce8b
PE
37282012-04-14 Paul Eggert <eggert@cs.ucla.edu>
3729
3730 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
3731 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
3732 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
3733 * s/netbsd.h, s/sol2-6.h:
3734 Remove definition of GC_MARK_STACK, since the default now works.
3735 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
3736 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
3737 no longer the default.
3738 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
3739
35dc09a1 37402012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 3741
35dc09a1
GM
3742 * lread.c (lisp_file_lexically_bound_p):
3743 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 3744
35dc09a1
GM
37452012-04-14 Eli Zaretskii <eliz@gnu.org>
3746
3747 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
3748 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
3749
37502012-04-14 Jan Djärv <jan.h.d@swipnet.se>
3751
3752 * nsterm.m (constrainFrameRect): Always constrain when there is only
3753 one screen (Bug#10962).
3754
bcd86815
KB
37552012-04-13 Ken Brown <kbrown@cornell.edu>
3756
3757 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
3758
c25df26e
RT
37592012-04-13 Reuben Thomas <rrt@sc3d.org>
3760
3761 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
3762
0fc59f1e
DC
37632012-04-11 Daniel Colascione <dancol@dancol.org>
3764
3765 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
3766 against is gone. It's better to use vfork now so that when Cygwin
3767 gains a new, working vfork, we use it automatically (bug#10398).
3768
de8c03dc
SM
37692012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3770
3771 * window.c (save_window_save): Obey window-point-insertion-type.
3772
2f097256
GM
37732012-04-11 Glenn Morris <rgm@gnu.org>
3774
3775 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
3776
453b951e
SM
37772012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3778
3779 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
3780
75f1671a 37812012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
3782
3783 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
3784 (force_quit_count): New var.
3785 (handle_interrupt): Use it.
3786
2a8ce227
JB
37872012-04-10 Juanma Barranquero <lekktu@gmail.com>
3788
3789 * w32.c (w32_delayed_load): Record the full path of the library
3790 being loaded (bug#10424).
3791
935396c0
GM
37922012-04-09 Glenn Morris <rgm@gnu.org>
3793
05920a43
GM
3794 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
3795 not just in the obarray, before snarfing them. (Bug#11036)
3796
935396c0
GM
3797 * Makefile.in ($(leimdir)/leim-list.el):
3798 Pass EMACS rather than BUILT_EMACS.
3799
a18ecafa
TZ
38002012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
3801
3802 * process.c (make_process):
3803 * process.h: Add integer `gnutls_handshakes_tried' member to
3804 process struct.
3805
6bbef4e5
JC
3806 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
3807 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
3808
3809 * gnutls.c (gnutls_log_function2i): Convenience log function.
3810 (emacs_gnutls_read): Use new log functions,
3811 `gnutls_handshakes_tried' process member, and
3812 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
3813 attempts per process (connection).
3814
b4d3bc10
CY
38152012-04-09 Chong Yidong <cyd@gnu.org>
3816
3817 * eval.c (Fuser_variable_p, user_variable_p_eh)
3818 (lisp_indirect_variable): Functions deleted.
3819 (Fdefvar): Caller changed.
3820
3821 * callint.c (Finteractive, Fcall_interactively):
3822 * minibuf.c (Fread_variable): Callers changed.
3823
70f4d973
EZ
38242012-04-09 Eli Zaretskii <eliz@gnu.org>
3825
3826 * xdisp.c (set_cursor_from_row): If the display string appears in
3827 the buffer at position that is closer to point than the position
3828 after the display string, display the cursor on the first glyph of
3829 the display string. Fixes cursor display when a 'display' text
3830 property immediately follows invisible text. (Bug#11094)
3831
cb3c2e3e
PE
38322012-04-09 Paul Eggert <eggert@cs.ucla.edu>
3833
3834 composite.c: use 'double' consistently
3835 * composite.c (get_composition_id): Use 'double' consistently
3836 instead of converting 'float' to 'double' and vice versa; this is
3837 easier to understand and avoids a GCC warning.
3838
fd06db5d
GM
38392012-04-09 Glenn Morris <rgm@gnu.org>
3840
50fe702a
GM
3841 * Makefile.in: Generate leim-list with bootstrap-emacs, in
3842 preparation for dumping it with emacs. (Bug#4789)
3843 (leimdir): New variable.
3844 ($(leimdir)/leim-list.el): New rule.
3845 (emacs$(EXEEXT)): Depend on leim-list.el.
3846
fd06db5d
GM
3847 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
3848 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
3849 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
3850
55c131ee
AS
38512012-04-08 Andreas Schwab <schwab@linux-m68k.org>
3852
3853 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
3854 proper alignment.
3855
9209588f
JB
38562012-04-07 Juanma Barranquero <lekktu@gmail.com>
3857
3858 * xml.c (init_libxml2_functions) [WINDOWSNT]:
3859 Remove unused local variable.
3860
e3fb2efb
PE
38612012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3862
3863 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
3864 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
3865 (mark_memory): Mark Lisp_Objects only if pointers might hide in
3866 objects, as mark_maybe_pointer will catch them otherwise.
3867 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
3868 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
3869
b5385551
PE
38702012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3871
3872 Fix typo that broke non-Windows builds.
3873 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
3874
9078ead6
EZ
38752012-04-07 Eli Zaretskii <eliz@gnu.org>
3876
3877 Support building on MS-Windows with libxml2.
3878
3879 * makefile.w32-in (OBJ2): Add xml.$(O).
3880 (GLOBAL_SOURCES): Add xml.c.
3881 ($(BLD)/xml.$(O)): New dependency list.
3882
3883 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
3884 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
3885 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
3886 [!WINDOWSNT]: New macros.
3887 (init_libxml2_functions, libxml2_loaded_p): New functions.
3888 (parse_region): Call fn_xmlCheckVersion instead of using the macro
3889 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
3890 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
3891 Calls xmlCleanupParser only if libxml2 was loaded (or statically
3892 linked in).
6bbef4e5
JC
3893 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
3894 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
3895 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
3896
3897 * emacs.c: Don't include libxml/parser.h.
3898 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
3899 xmlCleanupParser directly.
3900
3901 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
3902
3811fdf3
EZ
39032012-04-07 Eli Zaretskii <eliz@gnu.org>
3904
3905 * indent.c (Fvertical_motion): If there is a display string at
3906 point, use it.vpos to compute how many lines to backtrack after
3907 move_it_to point. (Bug#11133)
3908
2f8e16b2
EZ
39092012-04-06 Eli Zaretskii <eliz@gnu.org>
3910
3911 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
3912 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
3913 about subtle differences between FETCH_CHAR* and STRING_CHAR*
3914 macros related to unification of CJK characters. For the details,
3915 see the discussion following the message here:
3916 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
3917
3d439cd1
CY
39182012-04-04 Chong Yidong <cyd@gnu.org>
3919
3920 * keyboard.c (Vdelayed_warnings_list): Doc fix.
3921
8bc53d00
EZ
39222012-04-01 Eli Zaretskii <eliz@gnu.org>
3923
3924 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
3925 instead of alloca. (Bug#11138)
3926
3b0512a3
AS
39272012-04-01 Andreas Schwab <schwab@linux-m68k.org>
3928
3929 * w32menu.c (is_simple_dialog): Properly check lisp types.
3930 (Bug#11141)
3931
8427ddd2
EZ
39322012-03-31 Eli Zaretskii <eliz@gnu.org>
3933
979022ef
EZ
3934 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
3935 position we get to after a call to move_it_to fails the
3936 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
3937 only if we wind up in a string from display property. (Bug#11063)
3938
a6b1c7cc
EZ
3939 * window.c (Fdelete_other_windows_internal): Invalidate the row
3940 and column information about mouse highlight, so that redisplay
3941 restores it after reallocating the glyph matrices. (Bug#7464)
3942
8427ddd2
EZ
3943 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
3944 string comes from a `display' text property, use the buffer
3945 position of that property as if we actually saw that position in
3946 the row's glyphs.
697ba24b
EZ
3947 (move_it_by_lines): Remove the assertion that
3948 "it->current_x == 0 && it->hpos == 0" which can be legitimately
3949 violated when there's a before-string at the beginning of a line.
3950 (Bug#11063)
8427ddd2 3951
65a0a738
EZ
39522012-03-30 Eli Zaretskii <eliz@gnu.org>
3953
3954 * xdisp.c (append_space_for_newline): If the default face was
3955 remapped, use the remapped face for the appended newline.
3956 (extend_face_to_end_of_line): Use the remapped default face for
3957 extending the face to the end of the line.
3958 (display_line): Call extend_face_to_end_of_line when the default
3959 face was remapped. (Bug#11068)
3960
581355cc
EZ
39612012-03-29 Eli Zaretskii <eliz@gnu.org>
3962
3963 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
3964
e8fc049f
SM
39652012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3966
3967 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
3968
4fb9a543
GM
39692012-03-27 Glenn Morris <rgm@gnu.org>
3970
3971 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
3972 Doc fixes.
3973
679910f1
KH
39742012-03-26 Kenichi Handa <handa@m17n.org>
3975
3976 * dispextern.h (struct glyph): Fix previous change. Change the
3977 bit length of glyphless.ch to 25 (Bug#11082).
3978
90d49b7f
CY
39792012-03-26 Chong Yidong <cyd@gnu.org>
3980
3981 * keyboard.c (Vselection_inhibit_update_commands): New variable.
3982 (command_loop_1): Use it; inhibit selection update for
3983 handle-select-window too (Bug#8996).
3984
f514f6f0
FP
39852012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
3986
e8fc049f 3987 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 3988
bf43fa51
KH
39892012-03-25 Kenichi Handa <handa@m17n.org>
3990
3991 * dispextern.h (struct glyph): Change the bit length of
3992 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
3993
8a0c01dd
EZ
39942012-03-24 Eli Zaretskii <eliz@gnu.org>
3995
3996 * s/ms-w32.h (tzname): Include time.h before redirecting to
3997 _tzname. Fixes the MSVC build. (Bug#9960)
3998
7d1c3a76
AS
39992012-03-24 Andreas Schwab <schwab@linux-m68k.org>
4000
8ed79523
AS
4001 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
4002 characters.
4003
7d1c3a76
AS
4004 * xterm.c (XTread_socket): Only modify handling_signal if
4005 !SYNC_INPUT. (Bug#11080)
4006
e99a9b8b
EZ
40072012-03-23 Eli Zaretskii <eliz@gnu.org>
4008
4009 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
4010 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
4011 when fetching a multibyte character consumes more bytes than
4012 CHAR_BYTES returns, due to unification of CJK characters in
4013 string_char. (Bug#11073)
4014
5063c0e1
TN
40152012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
4016
4017 * process.c (wait_reading_process_output): Handle pty disconnect
4018 by refraining from sending oneself a SIGCHLD (bug#10933).
4019
9f851fbd
CY
40202012-03-22 Chong Yidong <cyd@gnu.org>
4021
4022 * dispextern.h (struct it): New member string_from_prefix_prop_p.
4023
5063c0e1 4024 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
4025 Mark string as coming from a prefix property.
4026 (handle_face_prop): Use default face for prefix strings (Bug#4281).
4027 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
4028
fb5b8aca
CY
40292012-03-21 Chong Yidong <cyd@gnu.org>
4030
4031 * xfaces.c (Vface_remapping_alist): Doc fix.
4032
62356a1b
EZ
40332012-03-20 Eli Zaretskii <eliz@gnu.org>
4034
4035 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
4036 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
4037 Doc fixes.
62356a1b 4038
025de85b
CY
40392012-03-20 Chong Yidong <cyd@gnu.org>
4040
4041 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
4042 to reflect default non-nil value of redisplay-dont-pause.
4043
4827f94e
KH
40442012-03-19 Kenichi Handa <handa@m17n.org>
4045
4046 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
4047 it fit in a valid range (Bug#11003).
4048
e50a24a2
EZ
40492012-03-18 Eli Zaretskii <eliz@gnu.org>
4050
4051 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
4052 that is not from display property, accept the row as a "cursor
4053 row" if one of the string's character has a non-nil `cursor'
4054 property. Fixes cursor positioning when there are newlines in
4055 overlay strings, e.g. in icomplete.el. (Bug#11035)
4056
9af5ed87
PE
40572012-03-12 Paul Eggert <eggert@cs.ucla.edu>
4058
4059 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
4060
d1f55f16
CY
40612012-03-12 Chong Yidong <cyd@gnu.org>
4062
4063 * eval.c (inhibit_lisp_code): Rename from
4064 inhibit_window_configuration_change_hook; move from window.c.
4065
4066 * xfns.c (unwind_create_frame_1, Fx_create_frame):
4067 * window.c (run_window_configuration_change_hook)
4068 (syms_of_window): Callers changed.
4069
66c5eebd
CY
40702012-03-11 Chong Yidong <cyd@gnu.org>
4071
413df973
CY
4072 * keymap.c (Fkey_description): Doc fix (Bug#9700).
4073
66c5eebd
CY
4074 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
4075
1de11f56
CY
40762012-03-10 Chong Yidong <cyd@gnu.org>
4077
4078 * frame.c (other_visible_frames): Don't assume the selected frame
4079 is visible (Bug#10955).
4080
cae07000
SM
40812012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
4082
4083 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
4084
89c94350
JD
40852012-03-08 Jan Djärv <jan.h.d@swipnet.se>
4086
4087 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
4088 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
4089 zero (Bug#10954).
4090
999dd333
GM
40912012-03-03 Glenn Morris <rgm@gnu.org>
4092
01a6dcc8 4093 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 4094
de0100f2
EZ
40952012-03-02 Eli Zaretskii <eliz@gnu.org>
4096
4097 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
4098 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
4099 (redisplay_window, next_element_from_string): Fix typos in
4100 comments.
3e441275
EZ
4101 (redisplay_window): Pass to move_it_vertically the margin in
4102 pixels, not in screen lines.
de0100f2 4103
96a72ee9
GM
41042012-03-02 Glenn Morris <rgm@gnu.org>
4105
4106 * buffer.c (buffer-list-update-hook): Doc fix.
4107
312508d7
EZ
41082012-02-29 Eli Zaretskii <eliz@gnu.org>
4109
4110 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
4111 push_it before setting up the iterator for the first overlay
4112 string, even if we have an empty string loaded.
4113 (next_overlay_string): If there's an empty string on the iterator
4114 stack, pop the stack. (Bug#10903)
4115
27f3c637
PE
41162012-02-25 Paul Eggert <eggert@cs.ucla.edu>
4117
4118 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
4119 Suggested by Stefan Monnier in
4120 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
4121 * alloc.c (widen_to_Lisp_Object): New static function.
4122 (mark_memory): Also mark Lisp_Objects by fetching pointer words
4123 and widening them to Lisp_Objects. This would work even if
4124 USE_LSB_TAG is defined and wide integers are used, which might
4125 happen in a future version of Emacs.
4126
3c9dfce6
CY
41272012-02-25 Chong Yidong <cyd@gnu.org>
4128
fa74b241
CY
4129 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
4130 Doc fix.
4131
3c9dfce6
CY
4132 * xselect.c (Fx_selection_exists_p): Doc fix.
4133 (x_clipboard_manager_save_all): Print an informative message
4134 before saving to clipboard manager.
4135
9486df08
CY
41362012-02-24 Chong Yidong <cyd@gnu.org>
4137
4138 * keyboard.c (process_special_events): Handle all X selection
4139 requests in kbd_buffer, not just the next one (Bug#8869).
4140
f01d3321
CY
41412012-02-23 Chong Yidong <cyd@gnu.org>
4142
4143 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
4144 call when setting menu-bar-lines and tool-bar-lines parameters.
4145 (unwind_create_frame_1): New helper function.
4146
4147 * window.c (inhibit_window_configuration_change_hook): New var.
4148 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 4149 (syms_of_window): Initialize it.
f01d3321 4150
86b847b6
CY
41512012-02-22 Chong Yidong <cyd@gnu.org>
4152
4153 * xterm.c (x_draw_image_relief): Add missing type check for
4154 Vtool_bar_button_margin (Bug#10743).
4155
a59225b1
CY
41562012-02-21 Chong Yidong <cyd@gnu.org>
4157
4158 * fileio.c (Vfile_name_handler_alist): Doc fix.
4159
4160 * buffer.c (Fget_file_buffer): Protect against invalid file
4161 handler return value.
4162
310f5bd4
PE
41632012-02-20 Paul Eggert <eggert@cs.ucla.edu>
4164
cb3a28cc
PE
4165 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
4166 when computing $valmask.
4167
310f5bd4
PE
4168 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
4169 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
4170 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
4171 It's useless in that case, and it can cause problems on hosts
4172 that allocate halves of EMACS_INT values separately.
4173 Reported by Dan Horák. Diagnosed by Andreas Schwab in
4174 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
4175 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
4176 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
4177 it avoids undefined behavior on hosts where shifting right by more
4178 than the word width has undefined behavior.
4179
2375c96a
CY
41802012-02-19 Chong Yidong <cyd@gnu.org>
4181
4182 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
4183 (Funhandled_file_name_directory, Ffile_name_as_directory)
4184 (Fdirectory_file_name, Fexpand_file_name)
4185 (Fsubstitute_in_file_name): Protect against invalid file handler
4186 return values (Bug#10845).
4187
3eb49e71
EZ
41882012-02-18 Eli Zaretskii <eliz@gnu.org>
4189
4190 * .gdbinit (pitx): Fix incorrect references to fields of the
4191 iterator stack.
4192
7b926f3f
CY
41932012-02-17 Chong Yidong <cyd@gnu.org>
4194
4195 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
4196
11273115
PE
41972012-02-15 Paul Eggert <eggert@cs.ucla.edu>
4198
4199 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
4200 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
4201
c3a70e2b
CY
42022012-02-15 Chong Yidong <cyd@gnu.org>
4203
4204 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
4205 marked as special. Also, starting docstrings with * is obsolete.
4206
0ca43699
AS
42072012-02-13 Andreas Schwab <schwab@linux-m68k.org>
4208
4209 * gnutls.c (emacs_gnutls_write): Fix last change.
4210
2e8f3c56
LI
42112012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
4212
4213 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
4214 send_process.
4215
af70074f
SM
42162012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
4217
4218 * keymap.c (Fsingle_key_description): Handle char ranges.
4219
95986d52
CY
42202012-02-12 Chong Yidong <cyd@gnu.org>
4221
afd83bd1
CY
4222 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
4223 as that creates a dangerous corner case.
4224
95986d52
CY
4225 * window.c (Fdelete_window_internal): Invalidate the mouse
4226 highlight (Bug#9904).
4227
bd7da63e
GM
42282012-02-12 Glenn Morris <rgm@gnu.org>
4229
4230 * xselect.c (Fx_own_selection_internal)
4231 (Fx_get_selection_internal, Fx_disown_selection_internal)
4232 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
4233 * nsselect.m (Fx_own_selection_internal)
4234 (Fx_disown_selection_internal, Fx_selection_exists_p)
4235 (Fx_selection_owner_p, Fx_get_selection_internal):
4236 Sync docs and argument specs with the xselect.c versions.
4237
77abcbc2
LI
42382012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
4239
4240 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
4241
90b671e2
EZ
42422012-02-11 Eli Zaretskii <eliz@gnu.org>
4243
1c0ca0b7
EZ
4244 * w32select.c (Fx_selection_exists_p): Sync doc string and
4245 argument list with xselect.c. (Bug#10783)
4246
4247 * w16select.c (Fx_selection_exists_p): Sync doc string and
4248 argument list with xselect.c. (Bug#10783)
90b671e2 4249
49241268
GM
42502012-02-10 Glenn Morris <rgm@gnu.org>
4251
4252 * fns.c (Fsecure_hash): Doc fix.
4253
f998bbe7 42542012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
4255
4256 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
4257
0992bd9c
CY
42582012-02-07 Chong Yidong <cyd@gnu.org>
4259
4260 * buffer.c (Fbuffer_local_variables)
4261 (buffer_lisp_local_variables): Handle unbound vars correctly;
4262 don't let Qunbound leak into Lisp.
4263
af008560
GM
42642012-02-07 Glenn Morris <rgm@gnu.org>
4265
dd605cc4
GM
4266 * image.c (Fimagemagick_types): Doc fix.
4267
af008560
GM
4268 * image.c (imagemagick-render-type): Change it from a lisp object
4269 to an integer. Move the doc here from the lisp manual.
4270 Treat all values not equal to 0 the same.
4271
1449fa1d
CY
42722012-02-06 Chong Yidong <cyd@gnu.org>
4273
4274 * doc.c (store_function_docstring): Avoid applying docstring of
4275 alias to base function (Bug#2603).
4276
3723ec07
AS
42772012-02-04 Andreas Schwab <schwab@linux-m68k.org>
4278
4279 * .gdbinit (pp1, pv1): Remove redundant defines.
4280 (pr): Use pp.
4281
79c1cc1e
CY
42822012-02-04 Chong Yidong <cyd@gnu.org>
4283
4284 * nsterm.m: Declare a global (Bug#10694).
4285
d7f29f8e
EZ
42862012-02-04 Eli Zaretskii <eliz@gnu.org>
4287
cae07000
SM
4288 * w32.c (get_emacs_configuration_options):
4289 Include --enable-checking, if specified, in the return value.
d7f29f8e 4290
3b95a6f9
MR
42912012-02-04 Martin Rudalics <rudalics@gmx.at>
4292
4293 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
4294 after rounding frame sizes. (Bug#9723)
4295
d6fa96a6
EZ
42962012-02-04 Eli Zaretskii <eliz@gnu.org>
4297
4298 * keyboard.c (adjust_point_for_property): Don't position point
4299 before BEGV. (Bug#10696)
4300
df0b2940
PE
43012012-02-03 Paul Eggert <eggert@cs.ucla.edu>
4302
4303 Handle overflow when computing char display width (Bug#9496).
4304 * character.c (char_width): Return EMACS_INT, not int.
4305 (char_width, c_string_width): Check for overflow when
4306 computing the width; this is possible now that individual
4307 characters can have unbounded width. Problem introduced
4308 by merge from Emacs 23 on 2012-01-19.
4309
6bee44d6
MA
43102012-02-02 Michael Albinus <michael.albinus@gmx.de>
4311
4312 * dbusbind.c (Fdbus_register_method): Mention the return value
4313 :ignore in the docstring.
4314
44f92739
GM
43152012-02-02 Glenn Morris <rgm@gnu.org>
4316
1b9f60cc
GM
4317 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
4318
44f92739
GM
4319 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4320 Unconditionally set to t. (Bug#10673)
4321 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4322 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4323 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
4324
c5d3843c
KH
43252012-02-02 Kenichi Handa <handa@m17n.org>
4326
4327 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
4328 0, do not call append_composite_glyph.
4329
159462d4 43302012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
4331
4332 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
4333 NULL (Bug#6988).
4334 (x_produce_glyphs): If the component of a composition is a null
4335 string, set it->pixel_width to 1 to avoid zero-width glyph.
4336
78cef877
EZ
43372012-02-01 Eli Zaretskii <eliz@gnu.org>
4338
4339 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
4340 first 2 arguments are identical. This makes inserting large
4341 output from a subprocess an order of magnitude faster on
4342 MS-Windows, where all sbrk'ed memory is always contiguous.
4343
97897668
GM
43442012-01-31 Glenn Morris <rgm@gnu.org>
4345
4346 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 4347 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
4348 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
4349
31fd3586
GM
43502012-01-29 Glenn Morris <rgm@gnu.org>
4351
4352 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
4353
0e24a8b2
CY
43542012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
4355
4356 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
4357
cc0adcb0
CY
43582012-01-28 Chong Yidong <cyd@gnu.org>
4359
4360 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
4361
acc28cb9
CY
43622012-01-26 Chong Yidong <cyd@gnu.org>
4363
9c69cfb7
CY
4364 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
4365
acc28cb9
CY
4366 * search.c (Fsearch_forward, Fsearch_backward): Document negative
4367 repeat counts (Bug#10507).
4368
48da7392
GM
43692012-01-26 Glenn Morris <rgm@gnu.org>
4370
4371 * lread.c (syms_of_lread): Doc fix.
4372
14af5f7f
CY
43732012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
4374
4375 * coding.c (encode_designation_at_bol): Change return value to
4376 EMACS_INT.
4377
0b21c100
CY
43782012-01-25 Chong Yidong <cyd@gnu.org>
4379
4380 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
4381
3c2907f7
CY
43822012-01-21 Chong Yidong <cyd@gnu.org>
4383
4384 * floatfns.c (Fcopysign): Make the second argument non-optional,
4385 since nil is not allowed anyway.
4386
959ad23f
AS
43872012-01-21 Andreas Schwab <schwab@linux-m68k.org>
4388
4389 * process.c (read_process_output): Use p instead of XPROCESS (proc).
4390 (send_process): Likewise.
4391
34a02f46
MR
43922012-01-19 Martin Rudalics <rudalics@gmx.at>
4393
4394 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
4395 (Vwindow_persistent_parameters): Do not use Qstate.
4396 Rewrite doc-strings.
34a02f46 4397
1259009a 43982012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
4399
4400 * character.c (char_width): New function.
70d4fdf6
GM
4401 (Fchar_width, c_string_width, lisp_string_width):
4402 Use char_width (Bug#9496).
25ed9e61 4403
6a6ee00d
MR
44042012-01-16 Martin Rudalics <rudalics@gmx.at>
4405
4406 * window.c (Vwindow_persistent_parameters): New variable.
4407 (Fset_window_configuration, save_window_save): Handle persistent
4408 window parameters.
4409
c85efaf7
EZ
44102012-01-14 Eli Zaretskii <eliz@gnu.org>
4411
4412 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
4413 thrashing the stack of the thread. (Bug#9087)
4414
5944709e
PE
44152012-01-12 Paul Eggert <eggert@cs.ucla.edu>
4416
4417 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
4418
e71f5d99
EZ
44192012-01-11 Eli Zaretskii <eliz@gnu.org>
4420
4421 * xdisp.c (rows_from_pos_range): Handle the case where the
4422 highlight ends on a newline. (Bug#10464)
4423 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
4424 he end column for display of highlight that ends on a newline
4425 before a R2L line.
4426
ce316182
GM
44272012-01-11 Glenn Morris <rgm@gnu.org>
4428
4429 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
4430 from load-path also when installation-directory is nil. (Bug#10208)
4431
5b43da69
GM
44322012-01-10 Glenn Morris <rgm@gnu.org>
4433
74cc8ff9
GM
4434 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
4435
7d8d6e4e
GM
4436 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
4437 Update template values to be closer to their typical values these days.
5b43da69 4438
a0db8d43
EZ
44392012-01-09 Eli Zaretskii <eliz@gnu.org>
4440
4441 * xdisp.c (rows_from_pos_range): Accept additional argument
4442 DISP_STRING, and accept any glyph in a row whose object is that
4443 string as eligible for mouse highlight. Fixes mouse highlight of
4444 display strings from overlays. (Bug#10464)
4445
9a0115ab 44462012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 4447
b9110d6a 4448 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
4449 * fileio.c (auto_saving_dir_umask): New static var.
4450 (Fmake_directory_internal): Use it.
4451 (do_auto_save_make_dir): Set it, instead of invoking chmod after
4452 creating the directory. The old code temporarily assigns
4453 too-generous permissions to the directory.
4454 (do_auto_save_eh): Clear it.
b9110d6a 4455 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
4456 that the var is always cleared.
4457
6c1bd3f3
EZ
44582012-01-07 Eli Zaretskii <eliz@gnu.org>
4459
4460 * search.c (scan_buffer): Pass character positions to
4461 know_region_cache, not byte positions. (Bug#6540)
4462
069d2b50
L
44632012-01-07 LynX <_LynX@bk.ru> (tiny change)
4464
4465 * w32.c (sys_rename): Report EXDEV when rename of a directory
4466 fails because the target is on another logical disk. (Bug#10284)
4467
75bf0d33
DB
44682012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
4469
4470 * xterm.c (x_embed_request_focus): New function.
4471
4472 * xterm.h: Add prototype.
4473
4474 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
4475
1c6e5a32
GM
44762012-01-05 Glenn Morris <rgm@gnu.org>
4477
4478 * emacs.c (emacs_copyright): Update short copyright year to 2012.
4479
651e947e
EZ
44802012-01-01 Eli Zaretskii <eliz@gnu.org>
4481
4482 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
4483 Load gnutls_transport_set_lowat only if GnuTLS version is below
4484 2.11.1.
4485 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
4486 GnuTLS versions below 2.11.1.
4487
3778cdd8
AL
44882011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
4489
4490 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
4491 to the doc string advising against its use for altering the way
4492 windows are scrolled.
4493
0e5317f7
KH
44942011-12-28 Kenichi Handa <handa@m17n.org>
4495
4496 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
4497 coding-system ASCII compatible only when it does not produce BOM
4498 on encoding (Bug#10383).
4499
93d5ca1f
JD
45002011-12-26 Jan Djärv <jan.h.d@swipnet.se>
4501
4502 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
4503 can scroll.
4504 (create_and_show_popup_menu): Always use menu_position_func for
4505 Gtk3 (Bug#10361).
4506
ca22b785
AS
45072011-12-24 Andreas Schwab <schwab@linux-m68k.org>
4508
4509 * callint.c (Fcall_interactively): Don't truncate prompt string.
4510
d048e1e6
EZ
45112011-12-23 Eli Zaretskii <eliz@gnu.org>
4512
4513 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
4514 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 4515 resumed from there (after widening). (Bug#10360)
d048e1e6 4516
5ccaba1f
JD
45172011-12-22 Jan Djärv <jan.h.d@swipnet.se>
4518
4519 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
4520
204ee57f
JD
45212011-12-21 Jan Djärv <jan.h.d@swipnet.se>
4522
b81d40f0
JB
4523 * nsterm.m (x_free_frame_resources):
4524 Release f->output_data.ns->miniimage.
204ee57f
JD
4525 (ns_index_color): Fix indentation. Do not retain
4526 color_table->colors[i].
4527
4528 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
4529 before returning.
4530
4531 * nsfns.m (x_set_background_color): Assign return value from
4532 ns_index_color to face-background instead of NSColor*.
4533 (ns_implicitly_set_icon_type): Fix indentation.
4534 Change assignment in for loop to comparison.
4535
4536 * emacs.c (ns_pool): New variable.
4537 (main): Assign ns_pool.
4538 (Fkill_emacs): Call ns_release_autorelease_pool.
4539
4540 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
4541 autorelease fdesc, release fdAttrs and tdict.
4542 (ns_get_covering_families): Release charset.
4543 (ns_findfonts): Release NSFontDescriptor created with new.
4544 (ns_uni_to_glyphs): Fix indentation.
4545 (setString): Release attrStr before assigning new value.
4546
c803b2b7
JD
45472011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4548
678f4426
JD
4549 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
4550 and NS_IMPL_COCOA.
4551 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
4552 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
4553
cd394be1 45542011-12-18 David Reitter <reitter@cmu.edu>
678f4426 4555
5fecd5fc
JD
4556 * nsterm.m (ns_term_init): Subscribe for notifications
4557 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
4558 to method trackingNotification in EmacsMenu.
4559
4560 * nsmenu.m (trackingMenu): New variable.
3771cb17 4561 (trackingNotification): New method (from Aquamacs).
5fecd5fc 4562 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 4563 from Aquamacs (Bug#7030).
678f4426
JD
4564
45652011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 4566
c803b2b7
JD
4567 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
4568 (symbol_to_nsstring): Fix indentation.
4569 (ns_symbol_to_pb): New function.
cae07000
SM
4570 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
4571 (Fns_rotate_cut_buffers_internal): Remove.
4572 (Fns_store_selection_internal): Rename from
c803b2b7
JD
4573 Fns_store_cut_buffer_internal.
4574 (ns_get_foreign_selection, Fx_own_selection_internal)
4575 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
4576 (Fns_get_selection_internal, Fns_store_selection_internal):
4577 Use ns_symbol_to_pb and check if return value is nil.
4578 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
4579 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
4580 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
4581 renamed to Sns_store_selection_internal.
4582 (ns_handle_selection_request): Move code to Fx_own_selection_internal
4583 and remove this function.
4584 (ns_handle_selection_clear): Remove, never used.
4585 (Fx_own_selection_internal): Move code from ns_handle_selection_request
4586 here.
4587
e1b01a3a
KB
45882011-12-17 Ken Brown <kbrown@cornell.edu>
4589
4590 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
4591 GID is unknown (Bug#10257).
4592
2adb6e85
PE
45932011-12-17 Paul Eggert <eggert@cs.ucla.edu>
4594
4595 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
4596 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
4597 which caused a build failure on GNU/Linux IA-64. This problem was
4598 introduced by my 2011-10-07 patch.
4599
d1d7b339
JL
46002011-12-15 Juri Linkov <juri@jurta.org>
4601
4602 * image.c (imagemagick_error): New function. (Bug#10112)
4603 (imagemagick_load_image): Comment out `MagickSetResolution' call.
4604 Use `imagemagick_error' where ImageMagick functions return
4605 `MagickFalse'.
4606 (Fimagemagick_types): Add `Fnreverse' to return the list in the
4607 proper order.
4608
100d5755
KH
46092011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4610
4611 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
4612 fill background (Bug#8992).
4613
454592a6
MR
46142011-12-13 Martin Rudalics <rudalics@gmx.at>
4615
4616 * window.c (Vwindow_combination_resize)
4617 (Vwindow_combination_limit): Use t instead of non-nil in
4618 doc-strings.
61d4b438
MR
4619 (Vrecenter_redisplay): Add first sentence of doc-string on
4620 separate line.
53524d93 4621 (Frecenter): Fix doc-string typo.
454592a6 4622
3633e3aa
KH
46232011-12-11 Kenichi Handa <handa@m17n.org>
4624
4625 * coding.c (Funencodable_char_position): Pay attention to the
4626 buffer text relocation (Bug#9389).
4627
7b9d523a 46282011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 4629
7b9d523a
JD
4630 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
4631 gtk_init (Bug#10100).
4632
b73189c6
EZ
46332011-12-10 Eli Zaretskii <eliz@gnu.org>
4634
4635 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
4636 IT->string is nil. (Bug#10263)
4637
f7dfe5d6
JD
46382011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4639
83faebb4
JD
4640 * nsterm.h (x_free_frame_resources): Declare.
4641
f7dfe5d6
JD
4642 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
4643 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
4644
4645 * nsterm.h (ns_get_defaults_value): Declare.
4646
4647 * nsterm.m (ns_default): Call ns_get_defaults_value.
4648
7cd4e72c
EZ
46492011-12-09 Eli Zaretskii <eliz@gnu.org>
4650
4651 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
4652 (Bug#10170)
4653
b34d7317
YM
46542011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4655
4656 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
4657 that where the value of an _OBJC_* symbol points to is in the .bss
4658 section (Bug#10240).
4659
76470ad1
KH
46602011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4661
4662 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 4663 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 4664
745fff94
KH
46652011-12-08 Kenichi Handa <handa@m17n.org>
4666
4667 * ftfont.c (get_adstyle_property): Fix previous change
4668 (Bug#10233).
4669
6e44397c
JB
46702011-12-07 Juanma Barranquero <lekktu@gmail.com>
4671
4672 * w32.c (init_environment): If no_site_lisp, remove site-lisp
4673 dirs from the default value of EMACSLOADPATH (bug#10208).
4674
7efa6272
GM
46752011-12-07 Glenn Morris <rgm@gnu.org>
4676
4677 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
4678 installation and source directories as well. (Bug#10208)
4679
f6fc4d87
CY
46802011-12-06 Chong Yidong <cyd@gnu.org>
4681
4682 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
4683
2bf26180
GM
46842011-12-06 Glenn Morris <rgm@gnu.org>
4685
4686 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
4687 as an error, not just -1. (Bug#10217)
4688
3a6ad4f0
CY
46892011-12-05 Chong Yidong <cyd@gnu.org>
4690
4691 * keyboard.c (process_special_events): New function.
4692 (swallow_events, Finput_pending_p): Use it (Bug#10195).
4693
75a3b399
PE
46942011-12-05 Paul Eggert <eggert@cs.ucla.edu>
4695
4696 * coding.c (encode_designation_at_bol): Don't use uninitialized
4697 local variable (Bug#9318).
4698
c3c9e25e
KH
46992011-12-05 Kenichi Handa <handa@m17n.org>
4700
4701 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
4702 return Qnil (Bug#8046, Bug#10193).
4703
5eb05ea3
KH
47042011-12-05 Kenichi Handa <handa@m17n.org>
4705
4706 * coding.c (encode_designation_at_bol): New args charbuf_end and
4707 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
4708 (coding_set_source): Return how many bytes coding->source was
4709 relocated.
4710 (coding_set_destination): Return how many bytes
4711 coding->destination was relocated.
4712 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 4713 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
4714
47152011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4716
4717 * coding.c (CODING_CHAR_CHARSET_P): New macro.
4718 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
4719 macro (Bug#9318).
4720
47212011-12-05 Andreas Schwab <schwab@linux-m68k.org>
4722
4723 The following changes are to fix Bug#9318.
4724
a79703f5 4725 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
4726 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
4727 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 4728 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 4729
7dbda6df
JB
47302011-12-05 Juanma Barranquero <lekktu@gmail.com>
4731
4732 * lisp.h (process_quit_flag): Fix external declaration.
4733
6d5eb5b0
SM
47342011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
4735
4736 Don't macro-inline non-performance-critical code.
4737 * eval.c (process_quit_flag): New function.
4738 * lisp.h (QUIT): Use it.
4739
a0c3fad0
JD
47402011-12-04 Jan Djärv <jan.h.d@swipnet.se>
4741
4742 * nsfns.m (get_geometry_from_preferences): New function.
4743 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
4744
6c07aac2
AS
47452011-12-04 Andreas Schwab <schwab@linux-m68k.org>
4746
4747 * emacs.c (Qkill_emacs): Define.
4748 (syms_of_emacs): Initialize it.
4749 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
4750 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
4751 (quit_throw_to_read_char): Add parameter `from_signal'.
4752 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
4753 * lisp.h (QUIT): Call Fkill_emacs if requested.
4754
c052ead4
JD
47552011-12-03 Jan Djärv <jan.h.d@swipnet.se>
4756
4757 * widget.c (update_wm_hints): Return if wmshell is null.
4758 (widget_update_wm_size_hints): New function.
4759
4760 * widget.h (widget_update_wm_size_hints): Declare.
4761
4762 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
4763 widget_update_wm_size_hints (Bug#10104).
4764
9e49252b
EZ
47652011-12-03 Eli Zaretskii <eliz@gnu.org>
4766
4767 * xdisp.c (handle_invisible_prop): If the invisible text ends just
4768 before a newline, prepare the bidi iterator for consuming the
4769 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 4770 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 4771
02b16839
JL
47722011-12-02 Juri Linkov <juri@jurta.org>
4773
4774 * search.c (Fword_search_regexp): New Lisp function created from
4775 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
4776 (Fword_search_backward, Fword_search_forward)
4777 (Fword_search_backward_lax, Fword_search_forward_lax):
4778 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
4779 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
4780
0068070e
SM
47812011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
4782
4783 * fileio.c (Finsert_file_contents): Move after-change-function call
4784 to before the "handled:" label, since all "goto handled" appear in
4785 cases where the *-change-functions have already been properly called
4786 (bug#10117).
4787
3360a3fc
AS
47882011-12-01 Andreas Schwab <schwab@linux-m68k.org>
4789
4790 * keyboard.c (interrupt_signal): Don't call kill-emacs when
4791 waiting for input. (Bug#10169)
4792
73d6c093
EZ
47932011-11-30 Eli Zaretskii <eliz@gnu.org>
4794
4795 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
4796 verifies glyph row's hash code--we have just reallocated the
4797 glyphs, so their contents can be complete garbage. (Bug#10164)
4798
febe6bea
JB
47992011-11-30 Juanma Barranquero <lekktu@gmail.com>
4800
4801 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
4802
801a4313
EZ
48032011-11-30 Eli Zaretskii <eliz@gnu.org>
4804
4805 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
4806 attributes are tested _before_ calling verify_row_hash, to protect
4807 against GCC re-ordering of the tests. (Bug#10164)
4808
2b56b87e
JD
48092011-11-29 Jan Djärv <jan.h.d@swipnet.se>
4810
4811 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
4812
4813 * xterm.c (handle_one_xevent): Only set async_visible and friends
4814 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 4815 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
4816 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
4817
dbf31225
PE
48182011-11-28 Paul Eggert <eggert@cs.ucla.edu>
4819
4820 Remove GCPRO-related macros that exist only to avoid shadowing locals.
4821 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
4822 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
4823 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4824 All uses changed to use GCPRO1 etc.
4825 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
4826 Revert to old implementation (i.e., before 2011-03-11).
4827
1305621b
YM
48282011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4829
4830 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
4831 of scroll runs so as to avoid assigning disabled bogus rows and
4832 unnecessary graphics copy operations.
4833
8c9afb46
EZ
48342011-11-27 Eli Zaretskii <eliz@gnu.org>
4835
4836 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
4837 (snprintf) [_MSC_VER]: Redirect to _snprintf.
4838 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
4839 (malloc, free, realloc, calloc): Redirect to e_* only when
4840 compiling Emacs.
4841
4842 * lisp.h (GCTYPEBITS): Move before first use.
4843 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
4844 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
4845 this macro definition.
4846
4847 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
4848 _MSC_VER.
4849
54e9e3bf
JD
48502011-11-27 Jan Djärv <jan.h.d@swipnet.se>
4851
6d5eb5b0
SM
4852 * gtkutil.c (xg_create_frame_widgets):
4853 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
4854 present with Gtk+ 2.0.
4855
83aca1cb
PE
48562011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4857
4858 * fileio.c (Finsert_file_contents): Undo previous change; see
4859 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4860
5b76caa4
PE
48612011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4862
4863 Rename locals to avoid shadowing.
4864 * fileio.c (Finsert_file_contents):
4865 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
4866 * process.c (wait_reading_process_output):
4867 Rename inner 'proc' to 'p' to avoid shadowing.
4868 Indent for consistency with usual Emacs style.
4869
8c535114
EZ
48702011-11-25 Eli Zaretskii <eliz@gnu.org>
4871
4872 * xdisp.c (redisplay_window): If cursor row is not fully visible
4873 after recentering, and scroll-conservatively is set to a large
4874 number, scroll window by a few more lines to make the cursor fully
4875 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
4876 (start_display): Don't move to the next line if the display should
4877 start at a newline that is part of a display vector or an overlay
4878 string. (Bug#10119)
8c535114 4879
fa4fdb5c
JL
48802011-11-24 Juri Linkov <juri@jurta.org>
4881
4882 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
4883 after the `MagickPingImage' call. (Bug#10112)
4884
90ec88df
CY
48852011-11-23 Chong Yidong <cyd@gnu.org>
4886
4887 * window.c (Fcoordinates_in_window_p): Accept only live windows.
4888
56e2e794
MR
48892011-11-23 Martin Rudalics <rudalics@gmx.at>
4890
4891 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
4892 making another buffer current. (Bug#10114)
4893
b6e64c41
GM
48942011-11-23 Glenn Morris <rgm@gnu.org>
4895
4896 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
4897
6b21de18
CY
48982011-11-23 Chong Yidong <cyd@gnu.org>
4899
4900 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
4901 using it (Bug#5984).
4902
b12cd789
EZ
49032011-11-22 Eli Zaretskii <eliz@gnu.org>
4904
4905 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
4906 and header-lines, as they don't have one computed for them.
4907 (Bug#10098)
4908
4909 * .gdbinit (prow): Make displayed values more self-explaining.
4910 Add row's hash code.
4911
261b6fd4
LMI
49122011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
4913
4914 * process.c (wait_reading_process_output): Fix asynchrounous
4915 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 4916 (wait_reading_process_output): Add comment and URL.
261b6fd4 4917
e7cfd277
JD
49182011-11-21 Jan Djärv <jan.h.d@swipnet.se>
4919
4920 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
4921
a9b9b7f5
CY
49222011-11-21 Chong Yidong <cyd@gnu.org>
4923
4924 * window.c (Fnext_window, Fprevious_window): Doc fix.
4925
b0d15b4f
SM
49262011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4927
4928 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
4929
fe7a3057
JB
49302011-11-20 Juanma Barranquero <lekktu@gmail.com>
4931
4932 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
4933
d2999b1a
MR
49342011-11-20 Martin Rudalics <rudalics@gmx.at>
4935
4936 * window.c (Fset_window_combination_limit): Rename argument
4937 STATUS to LIMIT.
4938 (Vwindow_combination_limit): Remove "status" from doc-string.
4939
d5ff9cd0
AS
49402011-11-20 Andreas Schwab <schwab@linux-m68k.org>
4941
4942 * m/ibms390.h: Remove.
4943 * m/ibms390x.h: Don't include "ibms390.h".
4944
a5bb9bd3
SM
49452011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4946
4947 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
4948 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
4949
cd1181db
JB
49502011-11-20 Juanma Barranquero <lekktu@gmail.com>
4951
4952 * casetab.c (Fset_case_table):
4953 * charset.c (Fcharset_after): Fix typos.
4954
615a3b8d 49552011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 4956
17e845af
PE
4957 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
4958 Otherwise, valgrind does not work on some platforms.
4959 Problem reported by Andreas Schwab in
6a0bf43d
PE
4960 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
4961 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
4962 is set, removing the need for VIRT_ADDRESS_VARIES.
4963 (PURE_P): Use a more-efficient implementation that needs just one
4964 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
4965 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
4966 to 4 (xorl, subq, cmpq, setbe).
4967 * alloc.c (pure): Always extern now, since that's the
4968 VIRT_ADDR_VARIES behavior.
4969 (PURE_POINTER_P): Use a single comparison, not two, for
4970 consistency with the new puresize.h.
4971 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
4972 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
4973 Remove VIRT_ADDR_VARIES no longer needed.
4974
f8fe6f96
EZ
49752011-11-19 Eli Zaretskii <eliz@gnu.org>
4976
4977 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
4978 (erase_phys_cursor, update_window_cursor, show_mouse_face)
4979 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
4980 behave as if the cursor position were at the window margin.
4981
4982 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
4983 and the cursor position is out of bounds, behave as if the cursor
4984 position were at the window margin. (Bug#10075)
4985
df05a53c
CY
49862011-11-18 Chong Yidong <cyd@gnu.org>
4987
4988 * window.c (Fwindow_combination_limit): Make first argument
4989 non-optional, since it is meaningless for live windows like the
4990 selected window.
61ccba97 4991
2071918e
DA
49922011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
4993
4994 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
4995
b50a28de
SM
49962011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
4997
4998 * intervals.c: Fix grafting over the whole buffer (bug#10071).
4999 (graft_intervals_into_buffer): Simplify.
5000
015137db
EZ
50012011-11-18 Eli Zaretskii <eliz@gnu.org>
5002
5003 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
5004 hash values of the two rows.
5005 (copy_row_except_pointers): Preserve the used[] arrays and the
5006 hash values of the two rows. (Bug#10035)
68c95424 5007 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
5008
5009 * xdisp.c (row_hash): New function, body extracted from
5010 compute_line_metrics.
5011 (compute_line_metrics): Call row_hash, instead of computing the
5012 hash code inline.
5013
5014 * dispnew.c (verify_row_hash): Call row_hash for computing the
5015 hash code of a row, instead of duplicating code from xdisp.c.
5016
5017 * dispextern.h (row_hash): Add prototype.
5018
a2addb04
TH
50192011-11-18 Tassilo Horn <tassilo@member.fsf.org>
5020
5021 * frame.c (delete_frame): Don't delete the terminal when the last
5022 X frame is closed if emacs is built with GTK toolkit.
5023
df85d315
JB
50242011-11-17 Juanma Barranquero <lekktu@gmail.com>
5025
5026 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
5027
a0c2d0ae
MR
50282011-11-17 Martin Rudalics <rudalics@gmx.at>
5029
5030 * window.c (Vwindow_splits): Rename to
5031 Vwindow_combination_resize. Suggested by Juri Linkov.
5032 (Fsplit_window_internal): Use Vwindow_combination_resize instead
5033 of Vwindow_splits.
5034
58179cce
JB
50352011-11-16 Juanma Barranquero <lekktu@gmail.com>
5036
7877f373
JB
5037 * nsfns.m (Fns_font_name):
5038 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 5039
b6f67890
MR
50402011-11-16 Martin Rudalics <rudalics@gmx.at>
5041
5042 * window.h (window): Rename slot "nest" to "combination_limit".
5043 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
5044 (Fset_window_nest): Rename to Fset_window_combination_limit.
5045 (Vwindow_nest): Rename to Vwindow_combination_limit.
5046 (recombine_windows, make_parent_window, make_window)
5047 (Fsplit_window_internal, saved_window)
5048 (Fset_window_configuration, save_window_save): Rename all
5049 occurrences of window_nest to window_combination_limit.
5050
c7015153
JB
50512011-11-15 Juanma Barranquero <lekktu@gmail.com>
5052
5053 * image.c (imagemagick_load_image): Fix typo.
5054
322ad6ec
EZ
50552011-11-14 Eli Zaretskii <eliz@gnu.org>
5056
5057 * xdisp.c (display_line): Move the call to
5058 highlight_trailing_whitespace before the call to
5059 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
5060 faces of all the glyphs to compute ROW's hash value.
5061 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 5062
f067b8ec
JB
50632011-11-14 Juanma Barranquero <lekktu@gmail.com>
5064
5065 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
5066 just return (bug#10044).
5067
1e5b2111
EZ
50682011-11-12 Eli Zaretskii <eliz@gnu.org>
5069
7ef3cbd5
EZ
5070 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
5071 with user-defined heap size. Bump the default size of the temacs
5072 heap to 27MB, to avoid memory warning when running temacs.
5073 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
5074
1e5b2111
EZ
5075 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
5076 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
5077 (verify_row_hash) [XASSERTS]: New function.
5078 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
5079 that the hash value of glyph rows is correct.
1e5b2111 5080
89d61221
MR
50812011-11-12 Martin Rudalics <rudalics@gmx.at>
5082
5083 * window.h (window): Remove splits slot.
5084 * window.c (Fwindow_splits, Fset_window_splits): Remove.
5085 (Fdelete_other_windows_internal, make_parent_window)
5086 (make_window, Fsplit_window_internal, Fdelete_window_internal)
5087 (Fset_window_configuration, save_window_save): Don't deal with
5088 split status of windows.
5089 (saved_window): Remove splits slot.
5090 (Vwindow_splits): Rewrite doc-string.
5091
97f18cc8
JD
50922011-11-11 Jan Djärv <jan.h.d@swipnet.se>
5093
5094 * xfns.c (unwind_create_frame):
5095 * nsfns.m (unwind_create_frame):
5096 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
5097 Vframe_list (Bug#9999).
5098
22a648b4
DA
50992011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
5100
0b381c7e 5101 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 5102
659afede
KH
51032011-11-11 Kenichi Handa <handa@m17n.org>
5104
5105 * callproc.c (Fcall_process): Set the member dst_multibyte of
5106 process_coding.
5107
9ac0394b
KH
51082011-11-11 Johan Bockgård <bojohan@gnu.org>
5109
5110 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
5111 avoid a crash (bug#9496).
5112
2fbdc249
CY
51132011-11-09 Chong Yidong <cyd@gnu.org>
5114
5115 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
5116 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
5117
ac6b1f81
PE
51182011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5119
5120 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
5121
09db192c
PE
51222011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5123
5124 Avoid some portability problems by eschewing 'extern inline' functions.
5125 The trivial performance wins aren't worth the portability hassles; see
5126 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
5127 et seq.
5128 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5129 (window_box_width, window_box_left, window_box_left_offset)
5130 (window_box_right, window_box_right_offset): Undo previous change,
5131 by removing the "extern"s.
5132 * intervals.c (adjust_intervals_for_insertion)
5133 (adjust_intervals_for_deletion): Undo previous change,
5134 making these static again.
5135 (offset_intervals, temp_set_point_both, temp_set_point)
5136 (copy_intervals_to_string): No longer inline.
5137 * xdisp.c (window_text_bottom_y, window_box_width)
5138 (window_box_height, window_box_left_offset)
5139 (window_box_right_offset, window_box_left, window_box_right)
5140 (window_box): No longer inline.
5141
105216ed
CY
51422011-11-08 Chong Yidong <cyd@gnu.org>
5143
5144 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
5145 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
5146 Signal an error if not a live window.
105216ed
CY
5147 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
5148 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
5149
ae9e237f
JB
51502011-11-07 Juanma Barranquero <lekktu@gmail.com>
5151
5152 * lisp.h (syms_of_abbrev): Remove declaration.
5153 Reported by CHENG Gao <chenggao@royau.me>.
5154
c7aa8333
EZ
51552011-11-07 Eli Zaretskii <eliz@gnu.org>
5156
5157 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
5158 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
5159 of temacs in GUI mode.
5160
be7f5545
MR
51612011-11-07 Martin Rudalics <rudalics@gmx.at>
5162
5163 * window.h: Declare delete_all_child_windows instead of
5164 delete_all_subwindows.
5165 * window.c (Fwindow_nest, Fset_window_nest)
5166 (Fset_window_new_total, Fset_window_new_normal)
5167 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
5168 (delete_all_subwindows): Rename to delete_all_child_windows.
5169 (Fdelete_other_windows_internal, Fset_window_configuration):
5170 Call delete_all_child_windows instead of delete_all_subwindows.
5171 * frame.c (delete_frame): Call delete_all_child_windows instead
5172 of delete_all_subwindows.
5173
ca78dc43
PE
51742011-11-07 Paul Eggert <eggert@cs.ucla.edu>
5175
5176 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
5177 This is also needed for porting to any host where GC_MARK_STACK is
5178 not GC_MAKE_GCPROS_NOOPS.
5179 (which_symbols): Use it.
5180
a0241d01
KH
51812011-11-07 Kenichi Handa <handa@m17n.org>
5182
5183 * coding.c (coding_set_destination): Check coding->src_pos only
5184 when coding->src_object is a buffer (bug#9910).
5185
5186 * process.c (send_process): Set the member src_multibyte of coding
5187 to 0 (bug#9911) when sending a unibyte text.
5188
5189 * callproc.c (Fcall_process): Set the member src_multibyte of
5190 process_coding to 0 (bug#9912).
5191
a64bfdfa 51922011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
5193
5194 * xmenu.c (cleanup_widget_value_tree): New function.
5195 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
5196 calling free_menubar_widget_value_tree directly (Bug#9830).
5197
cb41b32a
PE
51982011-11-06 Paul Eggert <eggert@cs.ucla.edu>
5199
5200 Fix some portability problems with 'inline'.
5201 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5202 (window_box_width, window_box_left, window_box_left_offset)
5203 (window_box_right, window_box_right_offset): Declare extern.
5204 Otherwise, these inline functions do not conform to C99 and
5205 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
5206 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
5207 * intervals.c (adjust_intervals_for_insertion)
5208 (adjust_intervals_for_deletion): Now extern, because otherwise the
5209 extern inline functions 'offset_intervals' couldn't refer to it.
5210 (static_offset_intervals): Remove.
5211 (offset_intervals): Rewrite using the old contents of
5212 static_offset_intervals. The old version didn't conform to C99
5213 because an extern inline function contained a reference to an
5214 identifier with static linkage.
5215
b7041366
AS
52162011-11-06 Andreas Schwab <schwab@linux-m68k.org>
5217
5218 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
5219 GC.
5220
88a37c4d
EZ
52212011-11-06 Eli Zaretskii <eliz@gnu.org>
5222
5223 * xdisp.c (init_iterator, reseat_to_string): Don't set the
5224 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
5225 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
5226 return Qleft_to_right.
5227
49745b39
CY
52282011-11-06 Chong Yidong <cyd@gnu.org>
5229
5230 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
5231 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
5232 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
5233 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
5234 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
5235 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
5236 (Fwindow_vscroll): Doc fix.
5237 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
5238 argument, since it makes no sense to pass a live window and for
5239 consistency with window-child.
5240
1f05cd82
CS
52412011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
5242
5243 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
5244 support MSVC.
5245
22610910
JR
52462011-11-05 Jason Rumney <jasonr@gnu.org>
5247
5248 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
5249 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
5250 fonts (Bug#6029).
5251 (add_font_entity_to_list): Fix logic errors in mixed boolean and
5252 bitwise arithmetic preventing use of unicode-sip and non-truetype
5253 opentype fonts.
5254
a06776b2
EZ
52552011-11-05 Eli Zaretskii <eliz@gnu.org>
5256
3ad924ba
EZ
5257 * s/ms-w32.h (fstat, stat, utime): Move redirections to
5258 "emacs"-only part.
5259
a06776b2
EZ
5260 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
5261 initialization code to keep similarity to xfns.c after changes
5262 from 2011-11-05.
5263
c9e7db78
JD
52642011-11-05 Jan Djärv <jan.h.d@swipnet.se>
5265
a97f8f3f
JD
5266 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
5267 (unwind_create_frame): New function (Bug#9943).
5268 (Fx_create_frame): Restructure code to be more similar to the one in
5269 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
5270 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
5271 Move terminal->reference_count++ just before making the frame official
5272 (Bug#9943).
5273
5274 * nsterm.m (x_free_frame_resources): New function.
5275 (x_destroy_window): Move code to x_free_frame_resources.
5276
c9e7db78 5277 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
5278 (Fx_create_frame, x_create_tip_frame):
5279 Move terminal->reference_count++ just before making the frame
75f1671a 5280 official. Move initialization of image_cache_refcount and
c9e7db78
JD
5281 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
5282
a6fc3b5c
EZ
52832011-11-05 Eli Zaretskii <eliz@gnu.org>
5284
5285 Support MSVC build with newer versions of Visual Studio.
5286 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
5287 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
5288 nt/gmake.defs.
5289
5290 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
5291 which are not supported by MSVC.
5292 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
5293 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
5294 bitfields.
5295 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
5296 types in bitfields.
5297 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
5298
5299 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
5300
58179cce 53012011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
5302
5303 Support MSVC build with newer versions of Visual Studio.
5304 * w32.c: Don't include w32api.h for MSVC.
5305 (init_environment) [_MSC_VER]: Call sys_access, not _access.
5306
5307 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
5308 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
5309 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
5310 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
5311 e_* cousins.
5312 (alloca) [_MSC_VER]: Define to _alloca.
5313
5314 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
5315
5316 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
5317
a58c13ed
EZ
53182011-11-04 Eli Zaretskii <eliz@gnu.org>
5319
5320 * xdisp.c (note_mouse_highlight): If either of
5321 previous/next-single-property-change returns nil, treat that as
5322 the beginning or the end of the buffer. (Bug#9955)
5323
fe0b6370
JD
53242011-11-04 Jan Djärv <jan.h.d@swipnet.se>
5325
a58c13ed 5326 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
5327 label is not null (Bug#9951).
5328 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
5329 may be NULL.
5330
89bd5ee1
EZ
53312011-11-04 Eli Zaretskii <eliz@gnu.org>
5332
5333 * window.c (Fwindow_body_size): Mention in the doc string that the
5334 return value is in frame's canonical units. (Bug#9949)
5335
84c3edb9
EZ
53362011-11-03 Eli Zaretskii <eliz@gnu.org>
5337
4e2fb5c7
EZ
5338 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
5339
84c3edb9 5340 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 5341 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 5342 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 5343
bc17a887
EZ
53442011-11-01 Eli Zaretskii <eliz@gnu.org>
5345
5346 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
5347 Don't stop backward scan on the continuation glyph, even though
5348 its CHARPOS is positive.
6d5eb5b0
SM
5349 (mouse_face_from_buffer_pos, note_mouse_highlight):
5350 Rename cover_string to disp_string.
bc17a887 5351
4ee88440
MR
53522011-11-01 Martin Rudalics <rudalics@gmx.at>
5353
5354 * window.c (temp_output_buffer_show): Don't use
5355 Vtemp_buffer_show_specifiers.
5356 (Vtemp_buffer_show_specifiers): Remove unused variable.
5357
c2ff3c02
EZ
53582011-10-30 Eli Zaretskii <eliz@gnu.org>
5359
5360 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
5361 past the beginning of the current glyph matrix.
5362
58179cce 53632011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
5364
5365 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
5366 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
5367 HAVE_GTK3 (Bug#9869).
b77a6a7f 5368
3b574623
JD
5369 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
5370 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
5371
b77a6a7f
JD
5372 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
5373
5374 * xterm.c: Declare x_handle_net_wm_state to return int.
5375 (handle_one_xevent): Check if we are iconified but don't have
5376 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
5377 (get_current_wm_state): Return non-zero if not hidden,
5378 check for _NET_WM_STATE_HIDDEN (Bug#9893).
5379 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
5380 (x_handle_net_wm_state): Return what get_current_wm_state returns.
5381 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
5382
196e41e4
PE
53832011-10-29 Paul Eggert <eggert@cs.ucla.edu>
5384
5385 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
5386 so that this new function doesn't get optimized away by a
5387 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
5388
021f2e1a
AS
53892011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5390
5391 * frame.h (MOUSE_HL_INFO): Remove excess parens.
5392
8b058d44
EZ
53932011-10-29 Eli Zaretskii <eliz@gnu.org>
5394
5395 Fix the `xbytecode' command.
5396 * .gdbinit (xprintbytestr): New command.
b50a28de 5397 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
5398 (xbytecode): Print the byte-code string as well.
5399
4452fb80
EZ
54002011-10-29 Kim Storm <storm@cua.dk>
5401
8b058d44
EZ
5402 * alloc.c (which_symbols): New function.
5403
21b72067
AS
54042011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5405
5406 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
5407 line. (Bug#9903)
5408
83ed7b5c
GM
54092011-10-29 Glenn Morris <rgm@gnu.org>
5410
5411 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
5412 Not clear what it was for, and it causes various bugs. (Bug#9839)
5413
5a7a728b
EZ
54142011-10-28 Eli Zaretskii <eliz@gnu.org>
5415
5416 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
5417 possible random value that matches one of those tested as
5418 condition to clear the mouse face.
5419
d3d0842f
CY
54202011-10-28 Chong Yidong <cyd@gnu.org>
5421
5422 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
5423
31b39d13
DN
54242011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
5425
5426 * window.c (make_window): Initialize phys_cursor_on_p.
5427
9aba6043
SM
54282011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
5429
5430 * lisp.h (struct Lisp_Symbol): Update comments.
5431
c20992f4
JB
54322011-10-28 Juanma Barranquero <lekktu@gmail.com>
5433
5434 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
5435
db4f02f2
EZ
54362011-10-28 Eli Zaretskii <eliz@gnu.org>
5437
5438 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
5439 <oslsachem@gmail.com> for helping to debug this.
5440
5441 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
5442 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
5443 (g_b_init_get_glyph_outline_w): New static variables.
5444 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
5445 (GetGlyphOutlineW_Proc): New typedefs.
5446 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
5447 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
5448 New functions.
5449 (w32font_open_internal, compute_metrics):
5450 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
5451 instead of calling the "wide" APIs directly.
5452
5453 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
5454
5455 * w32.h (syms_of_w32font): Add prototype.
5456
87e68db4
JB
54572011-10-27 Juanma Barranquero <lekktu@gmail.com>
5458
5459 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
5460 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
5461 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
5462 (Fmove_to_window_line): Doc fix.
5463
435c1d67
CY
54642011-10-27 Chong Yidong <cyd@gnu.org>
5465
5466 * process.c (make_process): Set gnutls_state to NULL.
5467
5468 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
5469 non-NULL, regardless of GNUTLS_INITSTAGE.
5470 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
5471 an error. Set process slots as soon as we allocate them.
5472
5473 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
5474
9c6c6f49
CY
54752011-10-27 Chong Yidong <cyd@gnu.org>
5476
9aba6043
SM
5477 * gnutls.c (emacs_gnutls_deinit): New function.
5478 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
5479 (Fgnutls_deinit, Fgnutls_boot): Use it.
5480
5481 * process.c (make_process): Initialize GnuTLS credentials to NULL.
5482 (deactivate_process): Call emacs_gnutls_deinit.
5483
657d08d3
JB
54842011-10-27 Juanma Barranquero <lekktu@gmail.com>
5485
5486 * image.c (x_create_x_image_and_pixmap):
5487 * w32.c (sys_rename, w32_delayed_load):
5488 * w32font.c (fill_in_logfont):
5489 * w32reg.c (x_get_string_resource): Silence compiler warnings.
5490
5430d399
JB
54912011-10-26 Juanma Barranquero <lekktu@gmail.com>
5492
5493 * w32fns.c (w32_default_color_map): New function,
5494 extracted from Fw32_default_color_map.
a7ef684b 5495 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 5496
fe0055fa
PE
54972011-10-25 Paul Eggert <eggert@cs.ucla.edu>
5498
5499 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
5500
e6346438
SM
55012011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
5502
5503 * keyboard.c (test_undefined): New function (bug#9751).
5504 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
5505
e112cc37
ET
55062011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
5507
5508 * sysdep.c (init_sys_modes): Fix the check for the controlling
5509 terminal (Bug#6649).
5510
7b5d6677
EZ
55112011-10-20 Eli Zaretskii <eliz@gnu.org>
5512
5513 * dispextern.h (struct bidi_it): New member next_en_type.
5514
5515 * bidi.c (bidi_line_init): Initialize the next_en_type member.
5516 (bidi_resolve_explicit_1): When next_en_pos is valid for the
5517 current character, check also for next_en_type being WEAK_EN.
5518 (bidi_resolve_weak): Don't enter the expensive loop if the current
5519 position is before next_en_pos. Record the bidi type of the first
5520 non-ET, non-BN character we find, in addition to its position.
5521 (bidi_level_of_next_char): Invalidate next_en_type when
5522 next_en_pos is over-stepped.
5523
7da0b018
PE
55242011-10-20 Paul Eggert <eggert@cs.ucla.edu>
5525
5526 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
5527 * editfns.c: Rewrite current-time-zone so that it invokes
5528 the equivalent of (format-time-string "%Z") to get the time zone name.
5529 This fixes a bug when the time zone name contains characters that
5530 need converting from the system time locale to Emacs internal format.
5531 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
5532 that patch fixed format-time-string to do the conversion, but
5533 I forgot to fix current-time-zone.
5534 (format_time_string): New function, containing most of
5535 what Fformat_time_string used to contain.
5536 (Fformat_time_string): Rewrite in terms of format_time_string.
5537 This doesn't change this function's behavior.
5538 (current-time-zone): Rewrite to use format_time_string.
5539 This fixes the bug reported by Michael Schierl in
5540 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
5541 Jason Rumney's 2007-06-07 change worked around this bug, but
5542 didn't fix it.
5543 * systime.h (tzname, timezone): Remove no-longer-used declarations.
5544
8547b010
EZ
55452011-10-19 Eli Zaretskii <eliz@gnu.org>
5546
5547 * xdisp.c (start_display): If the character at POS is displayed
5548 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
5549 (try_window_reusing_current_matrix): If a line ends in a display
5550 vector or the next line starts in a display vector, continue
5551 redrawing the window even though the character position of
5552 start_row was reached.
8547b010
EZ
5553 (Bug#9771, part 2)
5554
4e948d15
CY
55552011-10-18 Chong Yidong <cyd@gnu.org>
5556
5557 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
5558 with nobreak-char-display too.
5559
4787455f
EZ
55602011-10-18 Eli Zaretskii <eliz@gnu.org>
5561
5562 Fix part 3 of bug#9771.
5563 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
5564 (bidi_resolve_neutral): Don't enter the expensive loop looking for
5565 non-neutral characters if the current character is a paragraph
5566 separator (a.k.a. Newline). This avoids running the same
5567 expensive loop twice, once when we consume the preceding newline
5568 and the other time when the line actually needs to be displayed.
5569 Avoid the loop when we see neutrals on the base embedding level
5570 following a character whose directionality is the same as the
5571 paragraph's. This avoids running the expensive loop when a line
5572 ends in a long sequence of neutrals, like control characters.
5573 Add assertion against STRONG_AL type. Slightly rearrange code
5574 that determines the type of a neutral given the first non-neutral
5575 that follows it.
5576 (bidi_level_of_next_char): Set next_en_pos to zero when
5577 invalidating its info.
5578
2c91f553
EZ
55792011-10-17 Eli Zaretskii <eliz@gnu.org>
5580
5581 * xdisp.c (push_display_prop): Determine whether to record string
5582 or buffer position by IT->string, not by IT->method. Allow
5583 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
5584 (move_it_vertically_backward): Don't look for character position
5585 immediately after the newline when in a continuation line.
5586 (Bug#9771, part 1)
2c91f553 5587
c7b08b0d
MR
55882011-10-15 Martin Rudalics <rudalics@gmx.at>
5589
5590 * window.c (coordinates_in_window): Rewrite and delabelize
5591 vertical border check. (Bug#5357) (Bug#9618)
5592
6b02f655
SM
55932011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
5594
5595 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
5596 errors in XSetWindowBorder (bug#9310).
5597
81d40c92
DA
55982011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
5599
5600 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
5601 avoid crash when xmalloc overrun checking is enabled.
5602
d4172c3b
EZ
56032011-10-13 Eli Zaretskii <eliz@gnu.org>
5604
5605 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
5606 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
5607 cursor motion with <left> and <right> arrow keys.
5608
5609 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
5610 some callers set that themselves.
5611
b00eea75
EZ
56122011-10-12 Eli Zaretskii <eliz@gnu.org>
5613
5614 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
5615 display string and the previous row comes from the same string and
5616 is empty. (Bug#9739) (Bug#9738)
5617
8fe012c4
SM
56182011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
5619
5620 * doc.c (get_doc_string): Encode file name (bug#9735).
5621
0074aef2
EZ
56222011-10-12 Eli Zaretskii <eliz@gnu.org>
5623
79beb178
EZ
5624 * bidi.c (bidi_level_of_next_char):
5625 * xdisp.c (get_visually_first_element): Remove old incorrect
5626 comments regarding the Unicode Line Separator character.
5627
0074aef2
EZ
5628 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
5629
6e4b3fbe
DA
56302011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
5631
5632 * alloc.c (Fgc_status): Do not access beyond zombies array
5633 boundary if nzombies > MAX_ZOMBIES.
5634 * alloc.c (dump_zombies): Add missing format specifier.
5635
0324f3af
PE
56362011-10-12 Paul Eggert <eggert@cs.ucla.edu>
5637
b5525cac
PE
5638 * xdisp.c (set_cursor_from_row): Simplify conditionals,
5639 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
5640
0324f3af
PE
5641 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
5642 Some packages use them to denote characters with modifiers.
5643
e9b5f888
AS
56442011-10-11 Andreas Schwab <schwab@linux-m68k.org>
5645
5646 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
5647 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
5648 matching a pp-number. Rename parameter var to var1.
5649
127827c0
SM
56502011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
5651
5652 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
5653
c8fd3bd0
GM
56542011-10-08 Glenn Morris <rgm@gnu.org>
5655
5656 * callint.c (Fcall_interactively): Give a more explicit error for the
5657 'c' case with a non-character input. (Bug#8479)
5658
352ec8ff
EZ
56592011-10-08 Eli Zaretskii <eliz@gnu.org>
5660
03669ccb
EZ
5661 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
5662 lines.
7061c986
EZ
5663 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
5664 lines that are hscrolled on the left.
03669ccb 5665
352ec8ff
EZ
5666 * dispnew.c (buffer_posn_from_coords): Account for a possible
5667 presence of header-line. (Bug#4426)
5668
a66cfb1c
SM
56692011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
5670
6b02f655
SM
5671 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
5672 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 5673
7c5ee88e
PE
56742011-10-07 Paul Eggert <eggert@cs.ucla.edu>
5675
5676 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
5677 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
5678 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
5679 this makes Emacs dump core during garbage collection on rare
5680 occasions. sizeof is obviously inferior to offsetof here, so
5681 stick with offsetof.
5682 (GC_POINTER_ALIGNMENT): New macro.
5683 (mark_memory): Omit 3rd (offset) arg; caller changed.
5684 Don't assume EMACS_INT alignment is the same as pointer alignment.
5685
df1bbe5b
SM
56862011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
5687
5688 * keyboard.c (read_key_sequence_remapped): New var.
5689 (read_key_sequence): Compute remapping in the right buffer.
5690 (command_loop_1): Use read_key_sequence's remapping directly.
5691
51553db6
SM
56922011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
5693
32c1fffd
SM
5694 * dired.c (file_name_completion): Don't expand file name.
5695 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
5696 before checking file name handler.
5697
51553db6
SM
5698 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
5699 they've been requested explicitly (bug#9591).
5700
b6bd1599 57012011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
5702
5703 * keymap.c (Fsingle_key_description): Use make_specified_string
5704 instead of build_string to build string from push_key_description.
5705 (Bug#5193)
5706
f701dc2a
PE
57072011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5708
4222c55d
PE
5709 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
5710 This fixes a Y2038 bug on 64-bit hosts.
5711 * buffer.c (reset_buffer):
5712 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
5713 (Fclear_buffer_auto_save_failure):
5714 Use 0, not -1, to represent an unset failure time, since time_t
5715 might not be signed.
5716
f701dc2a
PE
5717 Remove dependency on glibc malloc internals.
5718 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5719 Move back here from lisp.h, but with their new implementations.
5720 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5721 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
5722 * charset.c (charset_table_init): New static var.
5723 (syms_of_charset): Use it instead of xmalloc. This removes a
5724 dependency on glibc malloc internals. See Eli Zaretskii's comment in
5725 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
5726 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5727 Move back to alloc.c.
5728 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5729 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
5730
9ceebf39
JD
57312011-09-30 Jan Djärv <jan.h.d@swipnet.se>
5732
5733 * nsterm.m (windowDidResize): Call x_set_window_size only when
5734 ns_in_resize is true. Otherwise set pixelwidth/height and
5735 call change_frame_size (Bug#9628).
5736
cb993c58
PE
57372011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5738
3930c88b
PE
5739 Port --enable-checking=all to Fedora 14 x86-64.
5740 * charset.c (syms_of_charset): Also account for glibc malloc's
5741 internal overhead when calculating the initial malloc maximum.
5742
cb993c58
PE
5743 Port --enable-checking=all to Fedora 14 x86.
5744 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5745 Move to lisp.h.
5746 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
5747 (overrun_check_realloc, overrun_check_free):
5748 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
5749 That way, xmalloc returns a properly-aligned pointer even if
5750 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
5751 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
5752 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
5753 into account when calculating the initial malloc maximum.
5754 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5755 Move here from alloc.c, so that charset.c can use it too.
5756 Properly align; the old code wasn't right for common 32-bit hosts
5757 when configured with --enable-checking=all.
5758 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5759 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
5760
31bed486
EZ
57612011-09-29 Eli Zaretskii <eliz@gnu.org>
5762
04c70788 5763 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
5764 use EDOM.
5765
fbcaa2f3
EZ
57662011-09-28 Eli Zaretskii <eliz@gnu.org>
5767
5768 * xdisp.c (compute_display_string_end): If there's no display
5769 string at CHARPOS, return -1.
5770
5771 * bidi.c (bidi_fetch_char): When compute_display_string_end
5772 returns a negative value, treat the character as a normal
5773 character not covered by a display string. (Bug#9624)
5774
a239d4e9
JB
57752011-09-28 Juanma Barranquero <lekktu@gmail.com>
5776
5777 * lread.c (Fread_from_string): Fix typo in docstring.
5778
88652fd5
EZ
57792011-09-27 Eli Zaretskii <eliz@gnu.org>
5780
5781 * xdisp.c (handle_invisible_prop): If invisible text ends on a
5782 newline, reseat the iterator instead of bidi-iterating there one
5783 character at a time. (Bug#9610)
32c1fffd
SM
5784 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
5785 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 5786
ed497dd4
AS
57872011-09-27 Andreas Schwab <schwab@linux-m68k.org>
5788
5789 * lread.c (readevalloop): Use correct code for NBSP.
5790 (read1): Likewise. (Bug#9608)
5791
b2bf61aa
MA
57922011-09-25 Michael Albinus <michael.albinus@gmx.de>
5793
5794 * dbusbind.c (Fdbus_register_signal): When service is not
5795 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
5796
32bbb17c
GM
57972011-09-25 Glenn Morris <rgm@gnu.org>
5798
5799 * buffer.c (truncate-lines): Doc fix.
5800
94e0933e
CY
58012011-09-24 Chong Yidong <cyd@stupidchicken.com>
5802
5803 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
5804 (Fset_window_next_buffers): Doc fix.
5805
cddde921
GM
58062011-09-24 Glenn Morris <rgm@gnu.org>
5807
5808 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
5809
1260aef1
PE
58102011-09-24 Paul Eggert <eggert@cs.ucla.edu>
5811
25b4bfa0
PE
5812 Fix minor problems found by static checking.
5813 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
5814 * indent.c (Fvertical_motion): Fix == vs = typo.
5815
e3cbd34b
EZ
58162011-09-24 Eli Zaretskii <eliz@gnu.org>
5817
a66cfb1c
SM
5818 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
5819 Default value is now t. Doc fix.
6bf7006f 5820
e3cbd34b 5821 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 5822 logic when moving up, not only when moving down. Fix the
e3cbd34b 5823 confusing name and values of the it_overshoot_expected variable;
32c1fffd 5824 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
5825
5826 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
5827 CHARPOS is covered by a display string which includes newlines.
5828 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
5829 is covered by a display string with embedded newlines.
5830
a3de0cbd
MA
58312011-09-24 Michael Albinus <michael.albinus@gmx.de>
5832
5833 * dbusbind.c (Fdbus_register_signal): Add match rule to
5834 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
5835 (Fdbus_register_method, Vdbus_registered_objects_table):
5836 Fix docstring.
a3de0cbd 5837
b260039d
JM
58382011-09-24 Jim Meyering <meyering@redhat.com>
5839
32c1fffd 5840 do not ignore write error for any output size
b260039d
JM
5841 The previous change was incomplete.
5842 While it makes emacs --batch detect the vast majority of stdout
5843 write failures, errors were still ignored whenever the output size is
5844 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
5845 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
5846 && echo FAIL: ignored write error
5847 FAIL: ignored write error
5848 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
5849 && echo FAIL: ignored write error
5850 FAIL: ignored write error
5851 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
5852
8eca8a7c
AS
58532011-09-23 Andreas Schwab <schwab@linux-m68k.org>
5854
5855 * emacs.c (Fkill_emacs): In noninteractive mode exit
5856 non-successfully if a write error occurred on stdout. (Bug#9574)
5857
3341db62
EZ
58582011-09-21 Eli Zaretskii <eliz@gnu.org>
5859
5860 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
5861 the xassert test.
5862
5863 * dispextern.h (struct it): Update the comment documenting what
5864 can it->OBJECT be.
5865
8c203dbf
EZ
58662011-09-20 Eli Zaretskii <eliz@gnu.org>
5867
5868 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
5869 a display string, extend search for cursor position to end of row.
5870 (find_row_edges): If the row ends in a newline from a display
5871 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
5872 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
5873 (Fcurrent_bidi_paragraph_direction): Fix search for previous
5874 non-empty line. Fixes confusing cursor motion with arrow keys at
5875 the beginning of a line that starts with whitespace.
8c203dbf 5876
a4824228
LMI
58772011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5878
5879 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
5880 (bug#9493).
5881
33ed493b
CY
58822011-09-18 Chong Yidong <cyd@stupidchicken.com>
5883
5884 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
5885 boolean (Bug#9154).
5886
56cd55c8
EZ
58872011-09-18 Eli Zaretskii <eliz@gnu.org>
5888
5889 * xdisp.c (display_line): Record maximum and minimum buffer
5890 positions even if no glyphs were produced (e.g., by a zero-width
5891 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
5892 buffer positions that will be removed from the glyph row because
5893 they don't fit.
c02dcedf
EZ
5894 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
5895 column is beyond frame width: don't subtract 1 "pixel" when
5896 computing width of the stretch.
3e62b7e0
EZ
5897 (reseat_at_next_visible_line_start): Undo the change made on
5898 2011-09-17 that saved paragraph information and restored it after
5899 the call to `reseat'. (Bug#9545)
56cd55c8 5900
5ed99d36 59012011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
5902
5903 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
5904 and turn window cursor on if cleared (Bug#9415).
5905
5ed99d36 59062011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
5907
5908 * search.c (boyer_moore): Take unibyte characters from pattern
5909 literally. (Bug#9458)
5910
9bade7b2
EZ
59112011-09-18 Eli Zaretskii <eliz@gnu.org>
5912
5913 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
5914
e5e9d610
PE
59152011-09-18 Paul Eggert <eggert@cs.ucla.edu>
5916
87e4427a
PE
5917 Fix minor problem found by static checking.
5918 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
5919 initialized, to pacify gcc -Wuninitialized.
5920
e5e9d610
PE
5921 * fileio.c: Report proper errno when syscall falls.
5922 (Finsert_file_contents): Save and restore errno,
5923 so that report_file_error outputs the correct diagnostic.
5924 (Fwrite_region) [CLASH_DETECTION]: Likewise.
5925
a1674f0b
EZ
59262011-09-18 Eli Zaretskii <eliz@gnu.org>
5927
5928 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
5929
fbfb6dd4
EZ
59302011-09-17 Eli Zaretskii <eliz@gnu.org>
5931
5932 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
5933 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
5934
bb187662
EZ
59352011-09-17 Eli Zaretskii <eliz@gnu.org>
5936
1137e8b8 5937 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 5938 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
5939
5940 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
5941 (bidi_find_paragraph_start): Search back for paragraph beginning
5942 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
5943 (bidi_move_to_visually_next): Only trigger paragraph-related
5944 computations when the last character is a newline or at EOB, not
5945 just any NEUTRAL_B. (Bug#9470)
5946
bb187662
EZ
5947 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
5948 truncated lines if point is covered by a display string. (Bug#9524)
5949
2e621251
PE
59502011-09-16 Paul Eggert <eggert@cs.ucla.edu>
5951
5952 * xselect.c: Relax test for outgoing X longs (Bug#9498).
5953 (cons_to_x_long): New function.
5954 (lisp_data_to_selection_data): Use it. Correct the test for
5955 short-versus-long data; it was negated. Break out of vector
5956 loop, for efficiency, when a long datum is discovered.
5957
91a15bc6
SM
59582011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
5959
5960 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
5961
b41c3a35
EZ
59622011-09-16 Eli Zaretskii <eliz@gnu.org>
5963
5964 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
5965 GCC PR/17406) by declaring this function with external scope.
5966
7812ba2d
PE
59672011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5968
5969 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
5970 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
5971
cf7edc2a
AS
59722011-09-15 Andreas Schwab <schwab@linux-m68k.org>
5973
5974 * editfns.c (Fformat): Correctly handle text properties on "%%".
5975
bd01620e
EZ
59762011-09-15 Eli Zaretskii <eliz@gnu.org>
5977
5978 * xterm.c (x_draw_composite_glyph_string_foreground):
5979 * w32term.c (x_draw_composite_glyph_string_foreground):
5980 * term.c (encode_terminal_code):
5981 * composite.c (composition_update_it, get_composition_id):
5982 * xdisp.c (get_next_display_element)
5983 (fill_composite_glyph_string): Add comments about special meaning
5984 of TAB characters in a composition.
5985
a02719a3
PE
59862011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5987
5988 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
5989 This occurs when processing a multibyte format.
5990 Problem reported by Wolfgang Jenker.
a02719a3 5991
72589a3c
JB
59922011-09-15 Johan Bockgård <bojohan@gnu.org>
5993
5994 * xdisp.c (try_cursor_movement): Only check for exact match if
5995 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
5996
1c14176c
PE
59972011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5998
5999 Remove unused external symbols.
6000 * dispextern.h (calc_pixel_width_or_height): Remove decl.
6001 * xdisp.c (calc_pixel_width_or_height): Now static.
6002 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
6003 * indent.c (check_display_width):
6004 * w32term.c: Fix comment to match code.
6005 * xterm.c, xterm.h (x_catching_errors): Remove.
6006
d2eea5b5
PE
60072011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6008
6009 * xselect.c: Use signed conversions more consistently (Bug#9498).
6010 (selection_data_to_lisp_data): Assume incoming selection data are
6011 signed integers, not unsigned. This is to be consistent with
6012 outgoing selection data, which was modified to use signed integers
6013 in as part of the fix to Bug#9196 in response to Jan D.'s comment
6014 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
6015 expects long, not unsigned long.
6016
46888499
EZ
60172011-09-14 Eli Zaretskii <eliz@gnu.org>
6018
6019 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
6020 computation of loop end. Reported by Johan Bockgård
6021 <bojohan@gnu.org>.
6022
ef8ef9fb
CY
60232011-09-13 Chong Yidong <cyd@stupidchicken.com>
6024
6025 * frame.c (Fother_visible_frames_p): Function deleted.
6026
fa819fed
EZ
60272011-09-12 Eli Zaretskii <eliz@gnu.org>
6028
6029 * indent.c (compute_motion): Process display vector front to back
6030 rather than the other way around. (Bug#2496)
6031
2ba8e008
SM
60322011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
6033
6034 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
6035
20f53c69
CY
60362011-09-11 Chong Yidong <cyd@stupidchicken.com>
6037
6038 * minibuf.c (Fread_from_minibuffer): Doc fix.
6039
d562d7a4
EZ
60402011-09-11 Eli Zaretskii <eliz@gnu.org>
6041
6042 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
6043 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
6044
1c4d7f3d
LMI
60452011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6046
6047 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
6048 value for non-existent files.
6049
b885bf36
EZ
60502011-09-11 Eli Zaretskii <eliz@gnu.org>
6051
6052 * fileio.c (Finsert_file_contents): If the file cannot be opened,
6053 set its "size" to -1. This will set the modtime_size field of
6054 the corresponding buffer to -1, which is what
6055 verify-visited-file-modtime expects for files that do not exist.
6056 (Bug#9139)
6057
6612f0bf
PE
60582011-09-11 Paul Eggert <eggert@cs.ucla.edu>
6059
6060 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
6061 here ...
6062 * lisp.h: ... from here. push_key_description is no longer
6063 defined in keyboard.c, so its declaration should not be in
6064 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
6065 logically belongs with push_key_description.
6066
dfb3f755
PE
60672011-09-10 Paul Eggert <eggert@cs.ucla.edu>
6068
6069 * buffer.h: Include <sys/types.h> instead of <time.h>.
6070 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
6071 Problem reported by Herbert J. Skuhra.
6072
3134906c
LMI
60732011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
6074
6075 * xml.c (parse_region): Make the parsing work for
6076 non-comment-starting XML files again (bug#9144).
6077
8d903f4e
AS
60782011-09-10 Andreas Schwab <schwab@linux-m68k.org>
6079
6080 * image.c (gif_load): Fix calculation of bottom and right corner.
6081 (Bug#9468)
6082
80ad64f4
EZ
60832011-09-10 Eli Zaretskii <eliz@gnu.org>
6084
6085 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
6086 redisplay in small windows.
6087
208a048d
EZ
60882011-09-09 Eli Zaretskii <eliz@gnu.org>
6089
6090 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
6091
9b1c252e
MR
60922011-09-08 Martin Rudalics <rudalics@gmx.at>
6093
6094 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
6095 Operate on live windows only.
6096
2949f33b
JB
60972011-09-08 Juanma Barranquero <lekktu@gmail.com>
6098
6099 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
6100
e08dcafd
EZ
61012011-09-07 Eli Zaretskii <eliz@gnu.org>
6102
6103 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
6104 only under bidi iteration.
6105
115b96bd
JD
61062011-09-07 Jan Djärv <jan.h.d@swipnet.se>
6107
6108 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
6109
c8199d0f
PE
61102011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6111
6112 isnan: Fix porting problem to Solaris 10 with bundled gcc.
6113 Without this fix, the command to link temacs failed due to an
6114 undefined symbol __builtin_isnan. This is because
6115 /usr/include/iso/math_c99.h #defines isnan(x) to
6116 __builtin_isnan(x), but the bundled gcc, which identifies itself
6117 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
6118 a __builtin_isnan.
6119 * floatfns.c (isnan): #undef, and then #define to a clone of
6120 what's in data.c.
6121 (Fisnan): Always define, since it's always available now.
6122 (syms_of_floatfns): Always define isnan at the Lisp level.
6123
e39b275c 61242011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
6125
6126 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
6127
b2db44d9 61282011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 6129
f4af5137 6130 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
6131 The previous code assumed that file offsets (off_t values) fit in
6132 EMACS_INT variables, which is not true on typical 32-bit hosts.
6133 The code messed up by falsely reporting buffer overflow in cases
6134 such as (insert-file-contents "big" nil 1 2) into an empty buffer
6135 when "big" contains more than 2**29 bytes, even though this
6136 inserts just one byte and does not overflow the buffer.
6137 (Finsert_file_contents): Store file offsets as off_t
6138 values, not as EMACS_INT values. Check for overflow when
6139 converting between EMACS_INT and off_t. When checking for
6140 buffer overflow or for overlap, take the offsets into account.
6141 Don't use EMACS_INT for small values where int suffices.
6142 When checking for overlap, fix a typo: ZV was used where
6143 ZV_BYTE was intended.
6144 (Fwrite_region): Don't assume off_t fits into 'long'.
6145 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
6146
ecfc0a49
MA
61472011-09-05 Michael Albinus <michael.albinus@gmx.de>
6148
6149 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
6150
6511acf2 61512011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 6152
0999621a 6153 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
6154
6155 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 6156 (esprintf, exprintf, evxprintf): New functions.
62f19c19 6157 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 6158 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
6159 (modify_event_symbol): Do not assume that the length of
6160 name_alist_or_stem is safe to alloca and fits in int.
6161 (Fexecute_extended_command): Likewise for function name and binding.
6162 (Frecursion_depth): Wrap around reliably on integer overflow.
6163 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
6164 since some callers pass EMACS_INT values.
6165 (Fsingle_key_description): Don't crash if symbol name contains more
6166 than MAX_ALLOCA bytes.
6167 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
6168 (get_minibuffer): Arg is now EMACS_INT, not int.
6169 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 6170 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
6171 * window.h (command_loop_level, minibuf_level): Reflect API changes.
6172
2be7d702
PE
6173 * dbusbind.c (signature_cat): New function.
6174 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
6175 Do not overrun buffer; instead, report string overflow.
6176
9d1df220
PE
6177 * dispnew.c (add_window_display_history): Don't overrun buffer.
6178 Truncate instead; this is OK since it's just a log.
6179
33ef5c64
PE
6180 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
6181 even if the time zone offset is outlandishly large.
6182 Don't mishandle offset == INT_MIN.
6183
66c6fdd5
PE
6184 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
6185 when creating daemon; the previous buffer-overflow check was incorrect.
6186
d749b01b
PE
6187 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
6188 which has the guts of the old verror function.
6189
b5cd1905
PE
6190 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
6191 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
6192
6e1a67fb
PE
6193 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
6194 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 6195 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 6196 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
6197 length of string rather than counting it via multiple sprintfs;
6198 that's simpler and more reliable.
c21721cc
PE
6199 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
6200 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
6201 sprintf, in case result does not fit in int.
6202
c57b67fc
PE
6203 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
6204 (fontset_from_font): Print it.
6205
8a401434
PE
6206 * frame.c (tty_frame_count): Now printmax_t, not int.
6207 (make_terminal_frame, set_term_frame_name): Print it.
6208 (x_report_frame_params): In X, window IDs are unsigned long,
6209 not signed long, so print them as unsigned.
6210 (validate_x_resource_name): Check for implausibly long names,
6211 and don't assume name length fits in 'int'.
6212 (x_get_resource_string): Don't blindly alloca invocation name;
6213 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
6214 not fit in int.
6215
6e1a67fb
PE
6216 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
6217 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
6218 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
6219
0df02bf3
PE
6220 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
6221 Use esprintf, not sprintf, in case result does not fit in int.
6222
48e30793
PE
6223 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6224 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
6225 it as a large positive number.
6226 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
6227 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6228
a66ff6d8
PE
6229 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
6230 in case result does not fit in int.
6231
aca216ff
PE
6232 * print.c (float_to_string): Detect width overflow more reliably.
6233 (print_object): Make sprintf buffer a bit bigger, to avoid potential
6234 buffer overrun. Don't assume list length fits in 'int'. Treat
6235 print length of 0 as 0, not as infinity; to be consistent with other
6236 uses of print length in this function. Don't overflow print length
6237 index. Don't assume hash table size fits in 'long', or that
6238 vectorlike size fits in 'unsigned long'.
6239
31c286f7
PE
6240 * process.c (make_process): Use printmax_t, not int, to format
6241 process-name gensyms.
6242
55e5faa1
PE
6243 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
6244
80f2e268
PE
6245 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
6246 to avoid potential buffer overrun.
6247
670741ab
PE
6248 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
6249 if X resource line is longer than 512 bytes.
6250
b7163a50
PE
6251 * xfns.c (x_window): Make sprintf buffer a bit bigger
6252 to avoid potential buffer overrun.
6253
ae58ff1f
PE
6254 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
6255
c43c8a6a
PE
6256 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
6257
3f8236f4
PE
62582011-09-04 Paul Eggert <eggert@cs.ucla.edu>
6259
53e9fe90 6260 Integer overflow fixes for scrolling, etc.
6511acf2
PE
6261 Without these, Emacs silently mishandles large integers sometimes.
6262 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
6263 it were "C-u 1 M-x recenter" on a typical 64-bit host.
6264
6511acf2
PE
6265 * xdisp.c (try_window_id): Check Emacs fixnum range before
6266 converting to 'int'.
806add1d 6267
6511acf2 6268 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
6269 Check that an Emacs fixnum is in range before assigning it to 'int'.
6270 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
6271 values converted from Emacs fixnums.
6272 (Frecenter): Don't wrap around a line count if it is out of 'int'
6273 range; instead, treat it as an extreme value.
6274 (Fset_window_configuration, compare_window_configurations):
6275 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
6276
6511acf2
PE
6277 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
6278 that can exceed INT_MAX. Check that EMACS_INT value is in range
6279 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
6280 (match_limit): Don't assume that a fixnum can fit in 'int'.
6281
6511acf2 6282 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
6283 exceed INT_MAX.
6284
6511acf2 6285 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
6286 (Fvertical_motion): Don't wrap around LINES values that don't fit
6287 in 'int'. Instead, treat them as extreme values. This is good
6288 enough for windows, which can't have more than INT_MAX lines anyway.
6289
fcb901a7
LMI
62902011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6291
0f2f6b6d
LMI
6292 * Require libxml/parser.h to avoid compilation warning.
6293
fcb901a7
LMI
6294 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
6295
6296 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
6297 since this reportedly can destroy thread storage.
6298
6e20a0d4
CY
62992011-08-30 Chong Yidong <cyd@stupidchicken.com>
6300
6301 * syntax.c (find_defun_start): Update all cache variables if
6302 exiting early (Bug#9401).
6303
148ae00e
EZ
63042011-08-30 Eli Zaretskii <eliz@gnu.org>
6305
f6cfbd8f
EZ
6306 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
6307
148ae00e
EZ
6308 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
6309 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
6310 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
6311
6312 * term.c (tty_append_glyph): New function.
6313 (produce_stretch_glyph): Static function and its prototype deleted.
6314
a66cfb1c
SM
6315 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
6316 Add prototypes.
148ae00e 6317
c4a07a4c
PE
63182011-08-29 Paul Eggert <eggert@cs.ucla.edu>
6319
6320 * image.c (parse_image_spec): Check for nonnegative, not for positive,
6321 when checking :margin (Bug#9390).
6322 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 6323 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
6324 so that the name doesn't mislead. All uses changed.
6325
6bc8cd65
JB
63262011-08-28 Johan Bockgård <bojohan@gnu.org>
6327
6328 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
6329 set_tty_hooks.
6330
dca4927e
EZ
63312011-08-27 Eli Zaretskii <eliz@gnu.org>
6332
6333 * xdisp.c (move_it_to): Don't bail out early when reaching
6334 position beyond to_charpos, if we are scanning backwards.
6335 (move_it_vertically_backward): When DY == 0, make sure we get to
6336 the first character in the line after the newline.
6337
f2cad773
PE
63382011-08-27 Paul Eggert <eggert@cs.ucla.edu>
6339
6340 * ccl.c: Improve and simplify overflow checking (Bug#9196).
6341 (ccl_driver): Do not generate an out-of-range pointer.
6342 (Fccl_execute_on_string): Remove unnecessary check for
6343 integer overflow, noted by Stefan Monnier in
6344 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
6345 Remove a FIXME that didn't need fixing.
6346 Simplify the newly-introduced buffer reallocation code.
6347
0cae2cdb
JB
63482011-08-27 Juanma Barranquero <lekktu@gmail.com>
6349
6350 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
6351
5fc295a4 63522011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 6353
70c60eb2 6354 Integer and memory overflow issues (Bug#9196).
726e0ab1 6355
d31850da
PE
6356 * doc.c (get_doc_string): Rework so that
6357 get_doc_string_buffer_size is the actual buffer size, rather than
6358 being 1 less than the actual buffer size; this makes xpalloc more
6359 convenient.
6360
a69fbedb
PE
6361 * image.c (x_allocate_bitmap_record, cache_image):
6362 * xselect.c (Fx_register_dnd_atom):
6363 Simplify previous changes by using xpalloc.
6364
fe5c5d37
PE
6365 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
6366 since either will do and ptrdiff_t is convenient with xpalloc.
6367
0065d054
PE
6368 * charset.c (charset_table_size)
6369 (struct charset_sort_data.priority): Now ptrdiff_t.
6370 (charset_compare): Don't overflow if priorities differ greatly.
6371 (Fsort_charsets): Don't assume list length fits in int.
6372 Check for size-calculation overflow when allocating sort data.
6373 (syms_of_charset): Allocate an initial charset table that is
6374 just under 64 KiB, to avoid problems with glibc malloc and mmap.
6375
6376 * cmds.c (internal_self_insert): Check for size-calculation overflow.
6377
6378 * composite.h (struct composition.glyph_len): Now int, not unsigned.
6379 The actual value is always <= INT_MAX, and leaving it unsigned made
6380 overflow checking harder.
6381
6382 * dispextern.h (struct glyph_matrix.rows_allocated)
6383 (struct face_cache.size): Now ptrdiff_t, for convenience in use
6384 with xpalloc. The values are still always <= INT_MAX.
6385
6386 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
6387
6388 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
6389 (SAFE_NALLOCA): New macro.
6390
6391 * region-cache.c (struct boundary.pos, find_cache_boundary)
6392 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
6393 (set_cache_region, invalidate_region_cache)
6394 (revalidate_region_cache, know_region_cache, region_cache_forward)
6395 (region_cache_backward, pp_cache):
6396 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
6397 so that ptrdiff_t * can be passed to xpalloc.
6398 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
6399 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
6400 (pp_cache): Don't assume cache_len fits in int.
6401 * region-cache.h: Adjust extern decls to match.
6402
6403 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
6404 EMACS_INT, since either will do, for xpalloc.
6405
6406 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
6407 (xnmalloc, xnrealloc, xpalloc): New functions.
6408
726e0ab1
PE
6409 * bidi.c (bidi_shelve_header_size): New constant.
6410 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
6411 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
6412
51f30bc5 6413 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
6414 * buffer.c (overlays_at, overlays_in, record_overlay_string)
6415 (overlay_strings):
6416 Don't update size of array until after memory allocation succeeds,
6417 because xmalloc/xrealloc may not return.
0065d054
PE
6418 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
6419 now that we have proper integer overflow checking.
6420 (record_overlay_string, overlay_strings): Catch overflows when
6421 calculating size of overlay_str_buf.
726e0ab1 6422
0065d054
PE
6423 * callproc.c (Fcall_process): Check for size overflow when
6424 calculating size of args2.
6425 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
6426 Normally we prefer signed values, but sticking with ptrdiff_t would
6427 require adding more-complicated checks.
726e0ab1
PE
6428
6429 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
6430 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
6431 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 6432 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
6433
6434 * character.c (Fstring): Check for size-calculation overflow.
6435
6436 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
6437 unnecessary integer overflow. Check for size overflow.
6438 (encode_coding_object): Don't update size until xmalloc succeeds.
6439
6440 * composite.c (get_composition_id): Check for overflow in glyph
6441 length calculations.
6442
6443 Integer and memory overflow fixes for display code.
6444 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
6445 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
6446 (scrolling_window): Check for overflow in size calculations.
6447 (line_draw_cost, realloc_glyph_pool, add_row_entry):
6448 Don't assume glyph table len fits in int.
6449 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
6450 (row_table_size): Now ptrdiff_t, not int.
6451 (scrolling_window): Avoid overflow in size calculations.
6452 Don't update size until allocation succeeds.
6453 * fns.c (concat): Check for overflow in size calculations.
6454 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
6455 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6456 (NEXT_ALMOST_PRIME_LIMIT): New constant.
6457
6458 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
6459 (get_doc_string): Check for size calculation overflow.
6460 Don't update size until allocation succeeds.
6461 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
6462 EMACS_INT, where ptrdiff_t will do.
6463 (Fsubstitute_command_keys): Check for string overflow.
6464
6465 * editfns.c (set_time_zone_rule): Don't assume environment length
6466 fits in int.
6467 (message_length): Now ptrdiff_t, not int.
6468 (Fmessage_box): Don't update size until allocation succeeds.
6469 Don't assume message length fits in int.
6470 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
6471
0065d054
PE
6472 * emacs.c (main): Do not reallocate argv, since there is a null at
6473 the end that can be overwritten, and this way there's no need to
6474 worry about size-calculation overflow.
6475 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
6476
6477 * eval.c (init_eval_once, grow_specpdl): Don't update size until
6478 alloc succeeds.
6479 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
6480
6481 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
6482 (x_set_scroll_bar_width, x_figure_window_size):
6483 Check for integer overflow.
6484 (x_set_alpha): Do not assume XINT fits in int.
6485
6486 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
6487 This is for the members text_lines, text_cols, total_lines, total_cols,
6488 where the system imposes an 'int' limit.
6489
6490 * fringe.c (Fdefine_fringe_bitmap):
6491 Don't update size until alloc works.
6492
6493 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
6494 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
6495
6496 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
6497 Check for size-calculation overflow.
6498 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
6499 do, as we prefer signed integers.
6500 (id_to_widget.max_size, id_to_widget.used)
6501 (xg_store_widget_in_map, xg_remove_widget_from_map)
6502 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
6503 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
6504 Use and return ptrdiff_t, not int.
6505 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
6506 * gtkutil.h: Change prototypes to match the above.
6507
6508 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
6509 are duplicate now that they've been promoted to lisp.h.
6510 (x_allocate_bitmap_record, x_alloc_image_color)
6511 (make_image_cache, cache_image, xpm_load):
6512 Don't update size until alloc is done.
6513 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
6514 (x_detect_edges):
3256efce 6515 Check for size calculation overflow.
726e0ab1
PE
6516 (ct_colors_allocated_max): New constant.
6517 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
6518 overflow.
3256efce 6519
726e0ab1
PE
6520 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
6521 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
6522 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
6523 Use ptrdiff_t, not int, to count maps.
6524 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
6525 calculations. Don't update size until allocation succeeds.
6526 Redo calculations to avoid overflow.
726e0ab1
PE
6527 * keyboard.h: Change prototypes to match the above.
6528
6529 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
6530 to count maps.
6531 (current_minor_maps): Check for size calculation overflow.
6532 * keymap.h: Change prototypes to match the above.
6533
6534 * lread.c (read1, init_obarray): Don't update size until alloc done.
6535
6536 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
6537 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
6538
726e0ab1
PE
6539 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
6540 Now ptrdiff_t, not int.
6541 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
6542 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
6543
6544 * process.c (Fnetwork_interface_list): Check for overflow
6545 in size calculation.
6546
6547 * region-cache.c (move_cache_gap): Check for size calculation overflow.
6548
6549 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
6550 overflow. Don't bother calling xmalloc when xrealloc will do.
6551
6552 * search.c (Freplace_match): Check for size calculation overflow.
6553 (Fset_match_data): Don't assume list lengths fit in 'int'.
6554
6555 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
6556 for command line length. Do not attempt to address one before the
6557 beginning of an array, as that's not portable.
6558
6559 * term.c (max_frame_lines): Remove; unused.
6560 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
6561 not int.
6562 (encode_terminal_code, calculate_costs): Check for size
6563 calculation overflow.
6564 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
6565 table lengths and related sizes. Don't update size until alloc
6566 done. Redo calculations to avoid overflow.
6567 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
6568
6569 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
6570 subtracting pointers.
6571 (gobble_line): Check for overflow more carefully. Don't update size
6572 until alloc done.
6573
6574 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
6575 Don't update size until alloc done.
6576 Redo size calculations to avoid overflow.
6577 Check for size calculation overflow.
0065d054 6578 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
6579
6580 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
6581 Use ptrdiff_t, not int, for sizes.
6582 (store_mode_line_noprop_char): Don't update size until alloc done.
6583
0065d054
PE
6584 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
6585 Use ptrdiff_t, not int, for sizes.
6586 (Finternal_make_lisp_face, cache_face):
6587 Check for size calculation overflow.
6588 (cache_face): Treat size calculation overflows as if they were
6589 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
6590
6591 * xfns.c (x_encode_text, x_set_name_internal)
6592 (Fx_change_window_property): Use ptrdiff_t, not int, to count
6593 sizes, since they can exceed INT_MAX in size. Check for size
6594 calculation overflow.
6595
0065d054
PE
6596 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
6597 (xg_select): Check for size calculation overflow.
726e0ab1
PE
6598 Don't update size until alloc done.
6599
0065d054 6600 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 6601 as sprintf is limited to int lengths.
1d526e2f 6602
252c5ee1
PE
6603 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
6604 (X_LONG_MIN): New macros.
864d7ce7
PE
6605 Use them to make the following changes clearer.
6606 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
6607 This change doesn't affect the value now, but it may help remind
6608 future maintainers not to raise the value too much later.
6609 (SELECTION_QUANTUM): Remove, replacing with ...
6610 (selection_quantum): ... new function, which avoids overflow.
6611 All uses changed.
6612 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
6613 assumption that selection length fits in 'int'.
6614 (x_reply_selection_request, x_handle_selection_request)
6615 (x_get_window_property, receive_incremental_selection)
6616 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
6617 (lisp_data_to_selection_data, clean_local_selection_data):
6618 Use ptrdiff_t, not int, to record length of selection.
6619 (x_reply_selection_request, x_get_window_property)
6620 (receive_incremental_selection, x_property_data_to_lisp):
6621 Redo calculations to avoid overflow.
6622 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 6623 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
6624 something.
6625 (x_get_window_property, receive_incremental_selection)
6626 (lisp_data_to_selection_data, x_property_data_to_lisp):
6627 Check for size-calculation overflow.
6628 (x_get_window_property, receive_incremental_selection)
6629 (lisp_data_to_selection_data, Fx_register_dnd_atom):
6630 Don't store size until memory allocation succeeds.
6631 (x_get_window_property): Plug memory leak on memory exhaustion.
6632 Don't double-block input; malloc is safe here. Don't assume 2**34
6633 - 4 fits in unsigned long. Add an xassert to check
6634 XGetWindowProperty overflow. Be more careful about overflow
6635 calculations, and distinguish size from memory overflow better.
6636 (receive_incremental_selection): When tracing, don't assume
6637 unsigned int is less than INT_MAX.
6638 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
6639 harmful) conversions of unsigned short to int.
6640 (lisp_data_to_selection_data): Don't assume that integers
6641 in the range -65535 through -1 fit in an X unsigned short.
6642 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
6643 result parameters unless successful. Rely on cons_to_unsigned
6644 to report problems with elements; the old code wasn't right anyway.
6645 (x_check_property_data): Check for int overflow; we cannot use
6646 a wider type due to X limits.
6647 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
6648
726e0ab1 6649 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 6650
0065d054
PE
6651 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
6652 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
6653 (x_color_cells): Don't store size until memory allocation succeeds.
6654 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 6655 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
6656 (x_term_init): Don't assume length fits in int (sprintf is limited
6657 to int size).
bc18e09d 6658
ebfa62c0
PE
6659 Use ptrdiff_t for composition IDs.
6660 * character.c (lisp_string_width):
6661 * composite.c (composition_table_size, n_compositions)
6662 (get_composition_id, composition_gstring_from_id):
6663 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
6664 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
6665 * window.c (Frecenter):
6666 Use ptrdiff_t, not int, for composition IDs.
6667 * composite.c (get_composition_id): Check for integer overflow.
6668 * composite.h: Adjust prototypes to match the above changes.
6669
d3411f89
PE
6670 Use ptrdiff_t for hash table indexes.
6671 * category.c (hash_get_category_set):
6672 * ccl.c (ccl_driver):
6673 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
6674 * coding.c (coding_system_charset_list, detect_coding_system):
6675 * coding.h (struct coding_system.id):
6676 * composite.c (get_composition_id, gstring_lookup_cache):
6677 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
6678 * image.c (xpm_get_color_table_h):
6679 * lisp.h (hash_lookup, hash_put):
6680 * minibuf.c (Ftest_completion):
6681 Use ptrdiff_t for hash table indexes, not int (which is too
6682 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
6683 32-bit --with-wide-int hosts).
6684
e097a6fa
PE
6685 * charset.c (Fdefine_charset_internal): Check for integer overflow.
6686 Add a FIXME comment about memory leaks.
6687 (syms_of_charset): Don't assume xmalloc returns.
6688
5637687f
PE
6689 Don't assume that stated character widths fit in int.
6690 * character.c (Fchar_width, c_string_width, lisp_string_width):
6691 * character.h (CHAR_WIDTH):
6692 * indent.c (MULTIBYTE_BYTES_WIDTH):
6693 Use sanitize_char_width to avoid undefined and/or bad behavior
6694 with outlandish widths.
a66cfb1c 6695 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
6696 now that we have two such functions. All uses changed.
6697 (sanitize_char_width): New inline function.
6698
a2271ba2
PE
6699 Don't assume that tab-width fits in int.
6700 * character.h (sanitize_width): New inline function.
6701 (SANE_TAB_WIDTH): New macro.
6702 (ASCII_CHAR_WIDTH): Use it.
6703 * indent.c (sane_tab_width): Remove. All uses replaced by
6704 SANE_TAB_WIDTH (current_buffer).
6705 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
6706
18c52557
PE
6707 * fileio.c: Integer overflow issues with file modes.
6708 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
6709
caeeedc1
PE
6710 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
6711 Remove unreachable code.
6712 (read_hex, load_charset_map_from_file): Check for integer overflow.
6713
6df6ae42 6714 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
6715 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
6716 (x_send_scroll_bar_event): Likewise. Check that the size does not
6717 exceed limits imposed by XClientMessageEvent, as well as the usual
6718 ptrdiff_t and size_t limits.
6719
b13995db
PE
6720 * keyboard.c: Overflow, signedness and related fixes.
6721 (make_lispy_movement): Use same integer type in forward decl
6722 that is used in the definition.
6723 (read_key_sequence, keyremap_step):
6724 Change bufsize argument back to int, undoing my 2011-03-30 change.
6725 We prefer signed types, and int is wide enough here.
6726 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
6727 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
6728 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
6729 length, not size_t. Use ptrdiff_t for index, not int.
6730 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
6731 possibility of integer overflow.
6732
13464394
PE
6733 Overflow, signedness and related fixes for images.
6734
6735 * dispextern.h (struct it.stack[0].u.image.image_id)
6736 (struct_it.image_id, struct image.id, struct image_cache.size)
6737 (struct image_cache.used, struct image_cache.ref_count):
6738 * gtkutil.c (update_frame_tool_bar):
6739 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
6740 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
6741 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
6742 * nsmenu.m (update_frame_tool_bar):
6743 * xdisp.c (calc_pixel_width_or_height):
6744 * xfns.c (image_cache_refcount):
6745 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
6746 on typical 64-bit hosts.
6747
6748 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6749 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
6750 Omit unnecessary casts to int.
6751 (parse_image_spec): Check that integers fall into 'int' range
6752 when the callers expect that.
6753 (image_ascent): Redo ascent calculation to avoid int overflow.
6754 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
6755 (lookup_image): Remove unnecessary tests.
6756 (xbm_image_p): Locals are now of int, not EMACS_INT,
6757 since parse_image_check makes sure they fit into int.
6758 (png_load, gif_load, svg_load_image):
6759 Prefer int to unsigned where either will do.
6760 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
6761 old tiff_error_handler and tiff_warning_handler.
6762 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
6763 stack buffer overflows. It uses only the features of vsnprintf
6764 that are common to both POSIX and native Microsoft.
6765 (tiff_error_handler, tiff_warning_handler): Use it.
6766 (tiff_load, gif_load, imagemagick_load_image):
6767 Don't assume :index value fits in 'int'.
6768 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
6769 (imagemagick_load_image): Check that crop parameters fit into
6770 the integer types that MagickCropImage accepts. Don't assume
6771 Vimagemagick_render_type has a nonnegative value. Don't assume
6772 size_t fits in 'long'.
6773 (gs_load): Use printmax_t to print the widest integers possible.
6774 Check for integer overflow when computing image height and width.
6775
c11821d4
EZ
67762011-08-26 Eli Zaretskii <eliz@gnu.org>
6777
6778 * xdisp.c (redisplay_window): Don't force window start if point
6779 will be invisible in the resulting window. (Bug#9324)
6780
0c95fcf7
EZ
67812011-08-25 Eli Zaretskii <eliz@gnu.org>
6782
6783 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
6784 the display spec is of the form `(space ...)'.
6785 (handle_display_spec): Return the value returned by
6786 handle_single_display_spec, not just 1 or zero.
6787 (handle_single_display_spec): If the display spec is of the form
6788 `(space ...)', and specifies display in the text area, return 2
6789 rather than 1.
fee65a97 6790 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
6791 accurately, and prefer exact match for point under bidi.
6792 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
6793
6794 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
6795 into disp_prop; all users changed.
6796
6797 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
6798 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
6799 for the text covered by the display property.
6800
e4ed06f1
CY
68012011-08-25 Chong Yidong <cyd@stupidchicken.com>
6802
6803 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
6804 Change return value to nil.
6805 (Frecord_buffer): Delete unused function.
6806
f67cdd7f
EZ
68072011-08-24 Eli Zaretskii <eliz@gnu.org>
6808
5980d4c6
EZ
6809 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
6810 buffers, return left-to-right.
8610fe8b
EZ
6811 (set_cursor_from_row): Consider candidate row a win if its glyph
6812 represents a newline and point is on that newline. Fixes cursor
6813 positioning on the newline at EOL of R2L text within L2R
6814 paragraph, and vice versa.
6815 (try_cursor_movement): Check continued rows, in addition to
6816 continuation rows. Fixes unwarranted scroll when point enters a
6817 continued line of R2L text within an L2R paragraph, or vice versa.
6818 (cursor_row_p): Consider the case of point being equal to
6819 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
6820 from the end of a short line to the beginning of a continued line
6821 of R2L text within L2R paragraph.
6822 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
6823 composed characters.
5980d4c6 6824
f67cdd7f
EZ
6825 * bidi.c (bidi_check_type): Use xassert.
6826 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
6827 members.
6828
bca633fb
EZ
68292011-08-23 Eli Zaretskii <eliz@gnu.org>
6830
6831 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
6832 a character.
6833
4a5885a7
CY
68342011-08-23 Chong Yidong <cyd@stupidchicken.com>
6835
6836 * nsfont.m (ns_otf_to_script): Fix typo.
6837
0902a04e
KH
68382011-08-22 Kenichi Handa <handa@m17n.org>
6839
6840 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
6841 extra slot even if the purpose is char-code-property-table.
6842
1a2e6670
EZ
68432011-08-23 Eli Zaretskii <eliz@gnu.org>
6844
8ddde651
EZ
6845 * xdisp.c (redisplay_window): When computing centering_position,
6846 account for the height of the header line. (Bug#8874)
6847
425cc014
EZ
6848 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
6849 instead of CHAR_TO_BYTE. Fixes a crash when a completion
6850 candidate is selected by the mouse, and that candidate has a
6851 composed character under the mouse.
6852
1a2e6670
EZ
6853 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
6854 coordinates reported by pos-visible-in-window-p for a composed
6855 character in column zero.
6856
8b76d6f8
SM
68572011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
6858
6859 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
6860
dac347dd
EZ
68612011-08-22 Eli Zaretskii <eliz@gnu.org>
6862
6863 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
6864 consider it a hit if to_charpos is anywhere in the range of the
6865 composed buffer positions.
6866
e013fb34
CY
68672011-08-22 Chong Yidong <cyd@stupidchicken.com>
6868
6869 * image.c (gif_load): Don't assume that each subimage has the same
6870 dimensions as the base image. Handle disposal method that is
6871 "undefined" by the gif spec (Bug#9335).
6872
bd1ba3e8
CY
68732011-08-20 Chong Yidong <cyd@stupidchicken.com>
6874
6875 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 6876 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 6877
54a1215b
EZ
68782011-08-19 Eli Zaretskii <eliz@gnu.org>
6879
823564e5
EZ
6880 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
6881 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
6882 from an Org mode buffer to a Speedbar frame.
6883
54a1215b
EZ
6884 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
6885 a composition, take its buffer position from IT->cmp_it.charpos.
6886 Fixes cursor positioning at the beginning of a line that begins
6887 with a composed character.
6888
9778ebcc
EZ
68892011-08-18 Eli Zaretskii <eliz@gnu.org>
6890
0be6ee06
EZ
6891 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
6892 character bidirectional type, use STRONG_L instead. Fixes crashes
6893 in a buffer produced by `describe-categories'.
6894
9778ebcc
EZ
6895 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
6896 members before the level stack, so they would be saved and
6897 restored when copying iterator state. Fixes incorrect reordering
6898 around TABs covered by display properties.
6899
156bffbe
AS
69002011-08-18 Andreas Schwab <schwab@linux-m68k.org>
6901
6b02f655 6902 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 6903
72ad093b
CY
69042011-08-17 Chong Yidong <cyd@stupidchicken.com>
6905
6906 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
6907 (internal_condition_case_2, internal_condition_case_n):
6908 Remove unnecessary aborts (Bug#9081).
72ad093b 6909
35774242
EZ
69102011-08-17 Eli Zaretskii <eliz@gnu.org>
6911
6912 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
6913 has no `load' handler, try opening the file locally. (Bug#9311)
6914
db76dd85
KB
69152011-08-16 Ken Brown <kbrown@cornell.edu>
6916
6917 * gmalloc.c: Expand comment.
6918
b215eee5
EZ
69192011-08-16 Eli Zaretskii <eliz@gnu.org>
6920
6921 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
6922 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
6923
a4579d33
KB
69242011-08-16 Ken Brown <kbrown@cornell.edu>
6925
6926 Fix memory allocation problems in Cygwin build (Bug#9273).
6927
6928 * unexcw.c ( __malloc_initialized): Declare external variable.
6929 (fixup_executable): Force the dumped emacs to reinitialize malloc.
6930
8b76d6f8
SM
6931 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
6932 New variables.
a4579d33
KB
6933 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
6934 dumped emacs.
6935 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
6936 in the static heap.
6937 [CYGWIN] (special_realloc): New function.
6938 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
6939 requests to realloc storage in the static heap.
6940
3ebec551
PE
69412011-08-15 Paul Eggert <eggert@cs.ucla.edu>
6942
6943 * bidi.c (bidi_initialize): Remove unused local.
6944
9fd8be00
EZ
69452011-08-15 Eli Zaretskii <eliz@gnu.org>
6946
6b02f655
SM
6947 * bidimirror.h:
6948 * biditype.h: Remove file.
6949 * makefile.w32-in ($(BLD)/bidi.$(O)):
6950 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
6951
6952 * dispextern.h: Fix a typo in the comment to bidi_type_t.
6953
6954 * chartab.c: Improve commentary for the uniprop_table API.
6955
32413314
EZ
6956 * bidi.c (bidi_paragraph_init): Support zero value of
6957 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
6958 (bidi_initialize): Use uniprop_table instead of including
6959 biditype.h and bidimirror.h.
32413314 6960
9fd8be00
EZ
6961 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
6962 coordinates of the iterator when restoring from ppos_it.
6963 (Bug#9296)
6964
5cf2b69b
KH
69652011-08-14 Kenichi Handa <handa@m17n.org>
6966
6967 * process.c (create_process): Call setup_process_coding_systems
72ad093b 6968 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 6969
daf17d00
EZ
69702011-08-14 Eli Zaretskii <eliz@gnu.org>
6971
6972 * xdisp.c (move_it_in_display_line_to): Don't invoke
6973 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
6974 ppos_it. Fixes vertical cursor motion when line beginning is
6975 covered by an image. (Bug#9296)
6976
08e3161a
JD
69772011-08-14 Jan Djärv <jan.h.d@swipnet.se>
6978
6979 * nsterm.h (ns_run_ascript): Declare.
6980 (NSAPP_DATA2_RUNASSCRIPT): Define.
6981
6982 * nsfns.m (as_script, as_result, as_status): New static variables.
6983 (ns_run_ascript): New function.
5e617bc2 6984 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
6985 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
6986 the event loop. Get status from as_status (Bug#7276).
6987
6988 * nsterm.m (sendEvent): If event is NSApplicationDefined and
6989 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
6990 the event loop (Bug#7276).
6991
a3720aa2
AS
69922011-08-14 Andreas Schwab <schwab@linux-m68k.org>
6993
6994 * gnutls.c (QCgnutls_bootprop_priority)
6995 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
6996 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
6997 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
6998 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
6999 (QCgnutls_bootprop_verify_hostname_error)
7000 (QCgnutls_bootprop_callbacks_verify): Rename from
7001 Qgnutls_bootprop_..., all uses changed.
7002
7003 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
7004 uses changed.
7005
0a0d27fb
PE
70062011-08-14 Paul Eggert <eggert@cs.ucla.edu>
7007
19d5c50c
PE
7008 * xfaces.c (Qframe_set_background_mode): Now static.
7009 * dispextern.h (Qframe_set_background_mode): Remove decl.
7010
0a0d27fb
PE
7011 * process.c (Fnetwork_interface_info): Declare local only if needed.
7012
377538cb
JD
70132011-08-13 Jan Djärv <jan.h.d@swipnet.se>
7014
7015 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
7016 (Fnetwork_interface_list): Allocate in increments of bytes instead
7017 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
7018 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
7019 sockaddr.
7020 (struct ifflag_def): notrailers is smart on OSX.
7021 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
7022 Get hardware address with getifaddrs if available.
7023
08fff70c
EZ
70242011-08-12 Eli Zaretskii <eliz@gnu.org>
7025
7026 * xdisp.c (iterate_out_of_display_property): xassert that
7027 IT->position is set to within IT->object's boundaries. Break from
7028 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
7029 when IT->position is set up wrongly due to some bug.
7030 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
7031 (push_display_prop): Allow GET_FROM_STRING as IT->method on
7032 entry. Force push_it to save on the stack the current
7033 buffer/string position, to be restored by pop_it. Fix flags in
7034 the iterator structure wrt the object coming from a display
7035 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
7036 properties. (Bug#9284)
7037
7be1c708 70382011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 7039
7be1c708
CY
7040 * fontset.c (fontset_get_font_group): Add proper type checks.
7041 (Bug#9172)
aac0c6e3 7042
7be1c708 70432011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 7044
7be1c708
CY
7045 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
7046 and LC_VERSION_MIN_MACOSX.
7047 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
7048 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 7049
97bb72a6
EZ
70502011-08-08 Eli Zaretskii <eliz@gnu.org>
7051
7052 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
7053 no-display-properties-and-no-overlays under bidi display.
7054 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 7055 properties and overlays.
97bb72a6 7056
d5617611
CY
70572011-08-08 Chong Yidong <cyd@stupidchicken.com>
7058
37e11a63
CY
7059 * editfns.c (Fset_time_zone_rule): Document relationship with the
7060 setenv function.
7061
d5617611
CY
7062 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
7063 the font entity extracted from the cache (Bug#8109).
7064
58872834
CY
70652011-08-07 Chong Yidong <cyd@stupidchicken.com>
7066
7067 * composite.c (autocmp_chars): Don't reset point. That is done by
7068 restore_point_unwind (Bug#5984).
7069
75bfc667
JL
70702011-08-07 Juri Linkov <juri@jurta.org>
7071
7072 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
7073 to show the arg `TIME' instead of `TIMEVAL'.
7074
d1410150
EZ
70752011-08-06 Eli Zaretskii <eliz@gnu.org>
7076
7077 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
7078 display property strides EOL and includes a newline, as in
7079 longlines-mode. (Bug#9254)
75b771e4
EZ
7080 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
7081 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
7082
7083 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
7084 is non-zero, even if the data buffer is NULL. Fixes a crash in
7085 vertical-motion with longlines-mode. (Bug#9254)
7086
35928349
EZ
70872011-08-05 Eli Zaretskii <eliz@gnu.org>
7088
ec7cc85b
EZ
7089 * bidi.c <bidi_cache_total_alloc>: Now static.
7090 (bidi_initialize): Initialize bidi_cache_total_alloc.
7091
8b76d6f8 7092 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
7093 cache. (Bug#9221)
7094
7095 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
7096 amount allocated this far in `bidi_cache_total_alloc'.
7097 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
7098 non-zero, only free the data buffer without restoring the cache
7099 contents. All callers changed.
7100
7101 * dispextern.h (bidi_unshelve_cache): Update prototype.
7102
7103 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
7104 (move_it_in_display_line, move_it_to)
7105 (move_it_vertically_backward, move_it_by_lines): Replace the call
7106 to xfree to an equivalent call to bidi_unshelve_cache.
7107 (move_it_in_display_line_to): Fix logic of returning
412b6358 7108 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 7109
e2e2423b
EZ
71102011-08-05 Eli Zaretskii <eliz@gnu.org>
7111
7112 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
7113 came from a string character with a `cursor' property. (Bug#9229)
7114
ae9e757a
JD
71152011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7116
7117 * Makefile.in (LIB_PTHREAD): New variable.
7118 (LIBES): Add LIB_PTHREAD (Bug#9216).
7119
7120 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
7121 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
7122
213bd7f2
AS
71232011-08-04 Andreas Schwab <schwab@linux-m68k.org>
7124
6b02f655 7125 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 7126
99aaf75f
JD
71272011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7128
7129 * xterm.c (x_find_topmost_parent): New function.
7130 (x_set_frame_alpha): Find topmost parent window with
7131 x_find_topmost_parent and set the property there also (bug#9181).
7132 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
7133
c74e9d86
PE
71342011-08-04 Paul Eggert <eggert@cs.ucla.edu>
7135
7136 * callproc.c (Fcall_process): Avoid vfork clobbering
7137 the local vars buffer, coding_systems, current_dir.
7138
640c8776
SM
71392011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
7140
7141 * keymap.c (Fmake_composed_keymap): Move to subr.el.
7142
f26d0e4c
PE
71432011-08-03 Paul Eggert <eggert@cs.ucla.edu>
7144
8a10d76c
PE
7145 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
7146 so that it is not optimized away.
7147
f26d0e4c
PE
7148 * xdisp.c (compute_display_string_pos): Remove unused local.
7149
55439c61
EZ
71502011-08-02 Eli Zaretskii <eliz@gnu.org>
7151
7152 Fix slow cursor motion and scrolling in large buffers with
7153 selective display, like Org Mode buffers. (Bug#9218)
7154
7155 * dispextern.h (struct bidi_it): New member disp_prop_p.
7156
7157 * xdisp.c: Remove one-slot cache of display string positions.
7158 (compute_display_string_pos): Accept an additional argument
5e617bc2 7159 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
7160 for a display string or property. If found, set DISP_PROP_P
7161 non-zero.
7162
7163 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
7164 DISP_PROP_P, and pass it to compute_display_string_pos.
7165 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
7166 non-zero. All callers of bidi_fetch_char changed.
7167
fb33fa43
SM
71682011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
7169
7170 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
7171
b099e063
DM
71722010-12-03 Don March <don@ohspite.net>
7173
7174 * keymap.c (Fdefine_key): Fix non-prefix key error message when
7175 last character M-[char] is translated to ESC [char] (bug#7541).
7176
5cc7f7af
KH
71772011-08-02 Kenichi Handa <handa@m17n.org>
7178
d0fffa3f 7179 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
7180
7181 * chartab.c (uniprop_table): Make it non-static.
7182
525d5e6e
EZ
71832011-08-01 Eli Zaretskii <eliz@gnu.org>
7184
7185 * xdisp.c (forward_to_next_line_start): Accept additional argument
7186 BIDI_IT_PREV, and store into it the state of the bidi iterator had
7187 on the newline.
7188 (reseat_at_next_visible_line_start): Use the bidi iterator state
7189 returned by forward_to_next_line_start to restore the state of
7190 it->bidi_it after backing up to previous newline. (Bug#9212)
7191
31011111
AS
71922011-07-30 Andreas Schwab <schwab@linux-m68k.org>
7193
7194 * regex.c (re_comp): Protoize.
7195 (re_exec): Fix return type.
7196 (regexec): Fix type of `ret'. (Bug#9203)
7197
476371c4
PE
71982011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7199
e5d76069
PE
7200 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
7201 This is needed if max-image-size is a floating-point number.
7202
9a79b20c
AS
72032011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7204
7205 * print.c (print_object): Print empty symbol as ##.
7206
7207 * lread.c (read1): Read ## as empty symbol.
7208
d8c2fa78
AA
72092011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
7210
7211 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
7212 setting frame foreground color (Bug#9175).
7213 (x_set_background_color): Likewise.
7214
ffe57a7a
AA
7215 * nsmenu.m (-setText): Size tooltip dimensions precisely to
7216 contents (Bug#9176).
7217 (EmacsTooltip -init): Remove bezels and add shadows to
7218 tooltip windows.
7219
bf3492a5
AA
7220 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
7221 or scroll bar (Bug#8470).
7222
d55e9c53
AA
7223 * nsfont.m (nsfont_open): Remove assignment to voffset and
7224 unnecessary vars hshink, expand, hd, full_height, min_height.
7225 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
7226
7227 * nsterm.h (nsfont_info): Remove voffset field.
7228
d8c2fa78 72292011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
7230
7231 Implement strike-through and overline on NextStep (Bug#8863).
7232
7233 * nsfont.m (nsfont_open): Use underline position provided by font,
7234 instead of hard-coded value of 2.
7235 (nsfont_draw): Call ns_draw_text_decoration instead.
7236
7237 * nsterm.h: Add declaration for ns_draw_text_decoration.
7238
7239 * nsterm.m (ns_draw_text_decoration): New function for drawing
7240 underline, overline, and strike-through.
7241 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
7242 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 7243 accommodate underlining, etc.
4843aac3 7244
4cc60b9b
EZ
72452011-07-28 Eli Zaretskii <eliz@gnu.org>
7246
bc7ece87
EZ
7247 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
7248 default.
4cc60b9b 7249
476371c4
PE
72502011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7251
66606eea
PE
7252 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
7253 Without this fix, if a signal arrives just after memory fills up,
7254 'malloc' might be invoked reentrantly.
7255
476371c4
PE
7256 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
7257 In other words, assume that every image size is allowed, on non-X
7258 hosts. This assumption is probably wrong, but it lets Emacs compile.
7259
f3fcc40d
AS
72602011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7261
7262 * regex.c (re_iswctype): Convert return values to boolean.
7263
350c992f
EZ
72642011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
7265
7266 * xdisp.c (compute_display_string_pos): Don't use cached display
7267 string position if the buffer had its restriction changed.
7268 (Bug#9184)
7269
5266b4bb
PE
72702011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7271
7272 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7273
2573a837 72742011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 7275
41f55ccd 7276 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 7277
39e378da
PE
7278 * bidi.c: Integer size and overflow fixes.
7279 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
7280 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
7281 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7282 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
7283 (bidi_find_other_level_edge):
7284 Use ptrdiff_t instead of EMACS_INT where either will do.
7285 This works better on 32-bit hosts configured --with-wide-int.
7286 (bidi_cache_ensure_space): Check for size-calculation overflow.
7287 Use % rather than repeated addition, for better worst-case speed.
7288 Don't set bidi_cache_size until after xrealloc returns, because it
7289 might not return.
7290 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
7291 (bidi_cache_ensure_space): Also check that the bidi cache size
7292 does not exceed that of the largest Lisp string or buffer. See Eli
7293 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 7294
5e927815
PE
7295 * alloc.c (__malloc_size_t): Remove.
7296 All uses replaced by size_t. See Andreas Schwab's note
7297 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
7298
ca4aa935
PE
7299 * image.c: Improve checking for integer overflow.
7300 (check_image_size): Assume that f is nonnull, since
7301 it is always nonnull in practice. This is one less thing to
7302 worry about when checking for integer overflow later.
7303 (x_check_image_size): New function, which checks for integer
7304 overflow issues inside X.
7305 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
7306 This removes the need for a memory_full check.
7307 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
7308 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
7309 (xbm_read_bitmap_data): Change locals back to 'int', since
7310 their values must fit in 'int'.
7311 (xpm_load_image, png_load, tiff_load):
7312 Invoke x_create_x_image_and_pixmap earlier,
7313 to avoid much needless work if the image is too large.
7314 (tiff_load): Treat overly large images as if
7315 x_create_x_image_and_pixmap failed, not as malloc failures.
7316 (gs_load): Use x_check_image_size.
7317
5f8f9cc2
PE
7318 * gtkutil.c: Omit integer casts.
7319 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
7320 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
7321
5adf60bc
PE
7322 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
7323
c8907a93
PE
7324 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
7325 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
7326 would wrongly return t on a 64-bit host.
7327
e3c25c68
PE
7328 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
7329 The plain *_OVERFLOW macros run afoul of GCC bug 49705
7330 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
7331 and therefore cause GCC to emit a bogus diagnostic in some cases.
7332
3f791afe
PE
7333 * image.c: Integer signedness and overflow and related fixes.
7334 This is not an exhaustive set of fixes, but it's time to
7335 record what I've got.
7336 (lookup_pixel_color, check_image_size): Remove redundant decls.
7337 (check_image_size): Don't assume that arbitrary EMACS_INT values
7338 fit in 'int', or that arbitrary 'double' values fit in 'int'.
7339 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
7340 (tiff_load, imagemagick_load_image):
7341 Check for overflow in size calculations.
7342 (x_create_x_image_and_pixmap): Remove unnecessary test for
7343 xmalloc returning NULL; that can't happen.
7344 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
7345 (xpm_color_bucket): Use better integer hashing function.
7346 (xpm_cache_color): Don't possibly over-allocate memory.
7347 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
7348 (gif_memory_source):
7349 Use ptrdiff_t, not int or size_t, to record sizes.
7350 (png_load): Don't assume values greater than 2**31 fit in 'int'.
7351 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
7352 either works, as we prefer signed integers.
7353 (tiff_read_from_memory, tiff_write_from_memory):
7354 Return tsize_t, not size_t, since that's what the TIFF API wants.
7355 (tiff_read_from_memory): Don't fail simply because the read would
7356 go past EOF; instead, return a short read.
7357 (tiff_load): Omit no-longer-needed casts.
7358 (Fimagemagick_types): Don't assume size fits into 'int'.
7359
3cc5a532
PE
7360 Improve hashing quality when configured --with-wide-int.
7361 * fns.c (hash_string): New function, taken from sxhash_string.
7362 Do not discard information about ASCII character case; this
7363 discarding is no longer needed.
7364 (sxhash-string): Use it. Change sig to match it. Caller changed.
7365 * lisp.h: Declare it.
7366 * lread.c (hash_string): Remove, since we now use fns.c's version.
7367 The fns.c version returns a wider integer if --with-wide-int is
7368 specified, so this should help the quality of the hashing a bit.
7369
b312a492
PE
7370 * emacs.c: Integer overflow minor fix.
7371 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
7372 Define only if GNU_LINUX.
7373 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
7374
dfd153ae
PE
7375 * dispnew.c: Integer signedness and overflow fixes.
7376 Remove unnecessary forward decls, that were a maintenance hassle.
7377 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
7378 All uses changed.
7379 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
7380 (scrolling_window): Use ptrdiff_t, not int, for byte count.
7381 (prepare_desired_row, line_draw_cost):
7382 Use int, not unsigned, where either works.
7383 (save_current_matrix, restore_current_matrix):
7384 Use ptrdiff_t, not size_t, where either works.
7385 (init_display): Check for overflow more accurately, and without
7386 relying on undefined behavior.
7387
a81d11a3
PE
7388 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
7389 Remove, replacing with the new symbols in lisp.h. All uses changed.
7390 * fileio.c (make_temp_name):
7391 * filelock.c (lock_file_1, lock_file):
7392 * xdisp.c (message_dolog):
7393 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
7394 Use pMd etc. instead.
7395 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
7396 replacing the pWIDE etc. symbols removed from editfns.c.
7397
3300e6fd
PE
7398 * keyboard.h (num_input_events): Now uintmax_t.
7399 This is (very slightly) less likely to mess up due to wraparound.
7400 All uses changed.
7401
fd05c7e9
PE
7402 * buffer.c: Integer signedness fixes.
7403 (alloc_buffer_text, enlarge_buffer_text):
7404 Use ptrdiff_t rather than size_t when either will do, as we prefer
7405 signed integers.
7406
903fe15d
PE
7407 * alloc.c: Integer signedness and overflow fixes.
7408 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
7409 (__malloc_size_t): Default to size_t, not to int.
7410 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
7411 (Fgarbage_collect, mark_object_loop_halt, mark_object):
7412 Prefer ptrdiff_t to size_t when either would do, as we prefer
7413 signed integers.
7414 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
7415 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
7416 Now const. Initialize with values that are in range even if char
7417 is signed.
7418 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
7419 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
7420 These functions do the right thing with sizes > 2**32.
7421 (check_depth): Now ptrdiff_t, not int.
7422 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
7423 Adjust to new way of storing sizes. Check for size overflow bugs
7424 in rest of code.
7425 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
7426 slightly wrong anyway, as it missed one instance of
7427 XMALLOC_OVERRUN_CHECK_OVERHEAD.
7428 (refill_memory_reserve): Omit needless cast to size_t.
7429 (mark_object_loop_halt): Mark as externally visible.
7430
ac82cc6a
PE
7431 * xselect.c: Integer signedness and overflow fixes.
7432 (Fx_register_dnd_atom, x_handle_dnd_message):
7433 Use ptrdiff_t, not size_t, since we prefer signed.
7434 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
7435 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
7436 x_dnd_atoms_size and x_dnd_atoms_length.
7437
c2d1e36d
PE
7438 * doprnt.c: Prefer signed to unsigned when either works.
7439 * eval.c (verror):
7440 * doprnt.c (doprnt):
7441 * lisp.h (doprnt):
7442 * xdisp.c (vmessage):
7443 Use ptrdiff_t, not size_t, when using or implementing doprnt,
7444 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
7445 prefer signed arithmetic to avoid comparison confusion.
7446 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
7447 but is a bit tricky.
7448
0e926e56
PE
7449 Assume freestanding C89 headers, string.h, stdlib.h.
7450 * data.c, doprnt.c, floatfns.c, print.c:
7451 Include float.h unconditionally.
7452 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
7453 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
7454 * regex.c: Likewise for stddef.h, string.h.
7455 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
7456 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
7457 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
7458 (STDC_HEADERS): Remove obsolete defines.
7459 * sysdep.c: Include limits.h unconditionally.
7460
9cfdb3ec
PE
7461 Assume support for memcmp, memcpy, memmove, memset.
7462 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
7463 * regex.c (memcmp, memcpy):
7464 Remove; we assume C89 now.
7465
7466 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
7467 (__malloc_safe_bcopy): Remove; no longer needed.
7468
cf950e6b 7469 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
7470 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
7471 well either way, and we prefer signed to unsigned.
7472
dbf38e02
LMI
74732011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
7474
7475 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
7476 closes the connection while we're reading (bug#9182).
7477
d6f0886c 74782011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 7479
d6f0886c
JD
7480 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
7481 are specified (Bug#9168).
24e0f6b1 7482
2eb1f9e6
PE
74832011-07-25 Paul Eggert <eggert@cs.ucla.edu>
7484
7485 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
7486 Found by GCC static checking and --with-wide-int on a 32-bit host.
7487
22381272 74882011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
7489
7490 * xdisp.c (compute_display_string_pos): Fix logic of caching
7491 previous display string position. Initialize cached_prev_pos to
7492 -1. Fixes slow-down at the beginning of a buffer.
7493
f25e39b4
EZ
74942011-07-24 Eli Zaretskii <eliz@gnu.org>
7495
7496 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
7497 for attrs[LFACE_FONTSET_INDEX].
7498
04c4b52e
PE
74992011-07-23 Paul Eggert <eggert@cs.ucla.edu>
7500
7501 * xml.c (parse_region): Remove unused local
7502 that was recently introduced.
7503
c1734fbd
EZ
75042011-07-23 Eli Zaretskii <eliz@gnu.org>
7505
be18c5a5
EZ
7506 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
7507 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
7508
c1734fbd
EZ
7509 * xdisp.c (move_it_in_display_line_to): Record the best matching
7510 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
7511 exit if none of the characters scanned was an exact match.
7512 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
7513 when exact match is impossible due to invisible text, and the
7514 lines are truncated.
7515
a258d627
JD
75162011-07-23 Jan Djärv <jan.h.d@swipnet.se>
7517
7518 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
7519 for OSX >= 10.7.
7520
b6d5a689
EZ
75212011-07-22 Eli Zaretskii <eliz@gnu.org>
7522
0f74f785
EZ
7523 Fix a significant slow-down of cursor motion with C-n, C-p,
7524 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
7525 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 7526 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
7527 (next_element_from_buffer): Call compute_stop_pos_backwards to
7528 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
7529 base_level_stop.
7530 (reseat): Don't look for prev_stop, as that could mean a very long
7531 run.
7532 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
7533 <cached_disp_overlay_modiff>: Cache for last found display string
7534 position.
551918c1 7535 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
7536 about the same buffer in the same area of character positions, and
7537 the buffer wasn't changed since the time the display string
7538 position was cached.
551918c1 7539
b2d0c91a
EZ
75402011-07-22 Eli Zaretskii <eliz@gnu.org>
7541
7542 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
7543 is an integer, which is important for empty lines. (Bug#9149)
7544
043604ee
CY
75452011-07-22 Chong Yidong <cyd@stupidchicken.com>
7546
7547 * frame.c (Fmodify_frame_parameters): In tty case, update the
7548 default face if necessary (Bug#4238).
7549
da4adb04
CY
75502011-07-21 Chong Yidong <cyd@stupidchicken.com>
7551
7552 * editfns.c (Fstring_to_char): No need to explain what a character
7553 is in the docstring (Bug#6576).
7554
9abd0532
LMI
75552011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7556
7557 * xml.c (parse_region): Make sure we always return a tree.
7558
36881d16
HK
75592011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
7560
7561 * xml.c (parse_region): If a document contains only comments,
7562 return that, too.
7563
1e98674d
LMI
75642011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7565
7566 * xml.c (make_dom): Return comments, too.
7567
590bd467
PE
75682011-07-19 Paul Eggert <eggert@cs.ucla.edu>
7569
7570 Port to OpenBSD.
7571 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
7572 and the surrounding thread.
7573 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
7574 rather than fgets, and retry after EINTR. Otherwise, 'emacs
7575 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
7576 timer goes off.
7577 * s/openbsd.h (BROKEN_SIGIO): Define.
7578 * unexelf.c (unexec) [__OpenBSD__]:
7579 Don't update the .mdebug section of the Alpha COFF symbol table.
7580
f41628b2
LMI
75812011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7582
7583 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
7584 (bug#8460).
7585
b59b67c5
PE
75862011-07-18 Paul Eggert <eggert@cs.ucla.edu>
7587
15e3a074
PE
7588 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
7589 This fixes some race conditions on the permissions of any newly
7590 created file.
7591
41bed37d
PE
7592 * alloc.c (valid_pointer_p): Use pipe, not open.
7593 This fixes some permissions issues when debugging.
7594
b59b67c5
PE
7595 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
7596 If fchown fails to set both uid and gid, try to set just gid,
7597 as that is sometimes allowed. Adjust the file's mode to eliminate
7598 setuid or setgid bits that are inappropriate if fchown fails.
7599
925a6be7
SM
76002011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
7601
7602 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
7603 to compare Lisp_Objects.
7604 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
7605 global_gnutls_log_level, don't mistake it for a Lisp_Object.
7606 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
7607
52968808
AS
76082011-07-17 Andreas Schwab <schwab@linux-m68k.org>
7609
0a6a104b
AS
7610 * lread.c (read_integer): Unread even EOF character.
7611 (read1): Likewise. Properly record start position of symbol.
7612
52968808
AS
7613 * lread.c (read1): Read `#:' as empty uninterned symbol if no
7614 symbol character follows.
7615
9e381cdd
PE
76162011-07-17 Paul Eggert <eggert@cs.ucla.edu>
7617
7618 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
7619 This works around a problem with the previous change to Fcopy_file.
7620 Recent glibc declares fchown with __attribute__((warn_unused_result)),
7621 and without this change, GCC might complain about discarding
7622 fchown's return value.
7623
b5641435
JB
76242011-07-16 Juanma Barranquero <lekktu@gmail.com>
7625
7626 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
7627
a8031457
PE
76282011-07-16 Paul Eggert <eggert@cs.ucla.edu>
7629
7630 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
7631
dd889327
LMI
76322011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
7633
750c33f7
LMI
7634 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
7635 it's used from the C level.
7636
dd889327
LMI
7637 * process.c: Use the same condition for POLL_FOR_INPUT in both
7638 keyboard.c and process.c (bug#1858).
7639
87e86684
LM
76402011-07-09 Lawrence Mitchell <wence@gmx.li>
7641
7642 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
7643 (Fgnutls_boot): Use it.
7644
64348f40
AS
76452011-07-15 Andreas Schwab <schwab@linux-m68k.org>
7646
7647 * doc.c (Fsubstitute_command_keys): Revert last change.
7648
1d698799
LMI
76492011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
7650
f863868c
LMI
7651 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
7652 quotes the next character, and doesn't affect other longer
7653 sequences (bug#8935).
7654
1d698799
LMI
7655 * lread.c (syms_of_lread): Clarify that is isn't only
7656 `eval-buffer' and `eval-defun' that's affected by
7657 `lexical-binding' (bug#8460).
7658
aa4b6df6
EZ
76592011-07-15 Eli Zaretskii <eliz@gnu.org>
7660
7661 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 7662 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 7663
5d856da6
PE
76642011-07-14 Paul Eggert <eggert@cs.ucla.edu>
7665
ad6042bb
PE
7666 Fix minor problems found by static checking.
7667 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
7668 (elsz): Now a signed constant, not a size_t var. We prefer signed
7669 types to unsigned, to avoid integer comparison confusion. Without
7670 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
7671 "cannot optimize loop, the loop counter may overflow", a symptom
7672 of the confusion.
f00bbb22 7673 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
7674 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
7675
6468f31c
LMI
76762011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7677
49080b10
LMI
7678 * search.c (Fre_search_backward): Mention `case-fold-search' in
7679 all the re_search_* functions (bug#8138).
7680
6468f31c
LMI
7681 * keyboard.c (Fopen_dribble_file): Document when the file is
7682 closed (bug#8056).
7683
c965adc5
EZ
76842011-07-14 Eli Zaretskii <eliz@gnu.org>
7685
df9733bf
EZ
7686 * bidi.c (bidi_dump_cached_states): Fix format of displaying
7687 bidi_cache_idx.
7688
0bb23927
EZ
7689 Support bidi reordering of display and overlay strings.
7690 * xdisp.c (compute_display_string_pos)
7691 (compute_display_string_end): Accept additional argument STRING.
7692 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
7693 (reseat_to_string): Initialize bidi_it->string.s and
7694 bidi_it->string.schars.
7695 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
7696 NULL (avoids a crash in bidi_paragraph_init).
7697 Initialize itb.string.lstring.
0bb23927
EZ
7698 (init_iterator): Call bidi_init_it only of a valid
7699 buffer position was specified. Initialize paragraph_embedding to
7700 L2R.
7701 (reseat_to_string): Initialize the bidi iterator.
7702 (display_string): If we need to ignore text properties of
7703 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
7704 original value of -1 will not work with bidi.)
7705 (compute_display_string_pos): First arg is now struct
7706 `text_pos *'; all callers changed. Support display properties on
7707 Lisp strings.
7708 (compute_display_string_end): Support display properties on Lisp
7709 strings.
7710 (init_iterator, reseat_1, reseat_to_string): Initialize the
7711 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
7712 when iterating on a string not from display properties).
640c8776
SM
7713 (compute_display_string_pos, compute_display_string_end):
7714 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
7715 arrow keys.
7716 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
7717 base_level_stop; instead, set base_level_stop to BEGV.
7718 Fixes crashes in vertical-motion.
0bb23927
EZ
7719 (next_element_from_buffer): Improve commentary for when
7720 the iterator is before prev_stop.
7721 (init_iterator): Initialize bidi_p from the default value of
7722 bidi-display-reordering, not from buffer-local value. Use the
7723 buffer-local value only if initializing for buffer iteration.
7724 (handle_invisible_prop): Support invisible properties on strings
7725 that are being bidi-reordered.
7726 (set_iterator_to_next): Support bidi reordering of C strings and
7727 Lisp strings.
7728 (next_element_from_string): Support bidi reordering of Lisp
7729 strings.
7730 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
7731 (display_string): Support display of R2L glyph rows.
7732 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
7733 (init_iterator): Don't initialize it->bidi_p for strings
7734 here.
7735 (reseat_to_string): Initialize it->bidi_p for strings here.
7736 (next_element_from_string, next_element_from_c_string)
7737 (next_element_from_buffer): Add xassert's for correspondence
7738 between IT's object being iterated and it->bidi_it.string
7739 structure.
7740 (face_before_or_after_it_pos): Support bidi iteration.
7741 (next_element_from_c_string): Handle the case of the first string
7742 character that is not the first one in the visual order.
7743 (get_visually_first_element): New function, refactored from common
7744 parts of next_element_from_buffer, next_element_from_string, and
7745 next_element_from_c_string.
7746 (tool_bar_lines_needed, redisplay_tool_bar)
7747 (display_menu_bar): Force left-to-right direction. Add a FIXME
7748 comment for making that be controlled by a user option.
7749 (push_it, pop_it): Save and restore the state of the
7750 bidi iterator. Save and restore the bidi_p flag.
7751 (pop_it): Iterate out of display property for string iteration as
7752 well.
7753 (iterate_out_of_display_property): Support iteration over strings.
7754 (handle_single_display_spec): Set up it->bidi_it for iteration
7755 over a display string, and call bidi_init_it.
7756 (handle_single_display_spec, next_overlay_string)
7757 (get_overlay_strings_1, push_display_prop): Set up the bidi
7758 iterator for displaying display or overlay strings.
7759 (forward_to_next_line_start): Don't use the shortcut if
7760 bidi-iterating.
7761 (back_to_previous_visible_line_start): If handle_display_prop
7762 pushed the iterator stack, restore the internal state of the bidi
7763 iterator by calling bidi_pop_it same number of times.
7764 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
7765 and we are bidi-iterating, don't decrement the iterator position;
7766 instead, set the first_elt flag in the bidi iterator, to produce
7767 the same effect.
7768 (reseat_1): Remove redundant setting of string_from_display_prop_p.
7769 (push_display_prop): xassert that we are iterating a buffer.
7770 (push_it, pop_it): Save and restore paragraph_embedding member.
7771 (handle_single_display_spec, next_overlay_string)
7772 (get_overlay_strings_1, reseat_1, reseat_to_string)
7773 (push_display_prop): Set up the `unibyte' member of bidi_it.string
7774 correctly. Don't assume unibyte strings are not bidi-reordered.
7775 (compute_display_string_pos)
7776 (compute_display_string_end): Fix handling the case of C string.
7777 (push_it, pop_it): Save and restore from_disp_prop_p.
7778 (handle_single_display_spec, push_display_prop): Set the
7779 from_disp_prop_p flag.
7780 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
7781 (pop_it): Call iterate_out_of_display_property only if we are
7782 popping after iteration over a string that came from a display
7783 property. Fix a typo in popping stretch info. Add an assertion
7784 for verifying that the iterator position is in sync with the bidi
7785 iterator.
7786 (handle_single_display_spec, get_overlay_strings_1)
7787 (push_display_prop): Fix initialization of paragraph direction for
7788 string when that of the parent object is not yet determined.
7789 (reseat_1): Call bidi_init_it to resync the bidi
7790 iterator with IT's position. (Bug#7616)
7791 (find_row_edges): If ROW->start.pos gives position
7792 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
7793 (handle_stop, back_to_previous_visible_line_start, reseat_1):
7794 Reset the from_disp_prop_p flag.
7795 (SAVE_IT, RESTORE_IT): New macros.
7796 (pos_visible_p, face_before_or_after_it_pos)
7797 (back_to_previous_visible_line_start)
7798 (move_it_in_display_line_to, move_it_in_display_line)
7799 (move_it_to, move_it_vertically_backward, move_it_by_lines)
7800 (try_scrolling, redisplay_window, display_line): Use them when
7801 saving a temporary copy of the iterator and restoring it back.
7802 (back_to_previous_visible_line_start, reseat_1)
7803 (init_iterator): Empty the bidi cache "stack".
7804 (move_it_in_display_line_to): If iterator ended up at
7805 EOL, but we never saw any buffer positions smaller than
7806 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
7807 motion in bidi-reordered lines.
7808 (move_it_in_display_line_to): Record prev_method and prev_pos
7809 immediately before the call to set_iterator_to_next. Fixes cursor
7810 motion in bidi-reordered lines with stretch glyphs and strings
7811 displayed in margins. (Bug#8133) (Bug#8867)
7812 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
7813 TO_CHARPOS.
640c8776
SM
7814 (pos_visible_p): Support positions in bidi-reordered lines.
7815 Save and restore bidi cache.
0bb23927
EZ
7816
7817 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
7818 (bidi_paragraph_info): Delete unused struct.
7819 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
7820 (bidi_cache_start): New variable.
7821 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
7822 to zero.
7823 (bidi_cache_fetch_state, bidi_cache_search)
7824 (bidi_cache_find_level_change, bidi_cache_iterator_state)
7825 (bidi_cache_find, bidi_peek_at_next_level)
7826 (bidi_level_of_next_char, bidi_find_other_level_edge)
7827 (bidi_move_to_visually_next): Compare cache index with
7828 bidi_cache_start rather than with zero.
7829 (bidi_fetch_char): Accept new argument STRING; all callers
7830 changed. Support iteration over a string. Support strings with
7831 display properties. Support unibyte strings. Fix the type of
7832 `len' according to what STRING_CHAR_AND_LENGTH expects.
7833 (bidi_paragraph_init, bidi_resolve_explicit_1)
7834 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
7835 (bidi_level_of_next_char, bidi_move_to_visually_next):
7836 Support iteration over a string.
0bb23927
EZ
7837 (bidi_set_sor_type, bidi_resolve_explicit_1)
7838 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
7839 can now be zero (for strings); special values 0 and -1 were
7840 changed to -1 and -2, respectively.
7841 (bidi_char_at_pos): New function.
7842 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
7843 Call it instead of FETCH_MULTIBYTE_CHAR.
7844 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
7845 initialized to valid values.
7846 (bidi_init_it): Don't initialize charpos and bytepos with invalid
7847 values.
7848 (bidi_level_of_next_char): Allow the sentinel "position" to pass
7849 the test for valid cached positions. Fix the logic for looking up
7850 the sentinel state in the cache. GCPRO the Lisp string we are
7851 iterating.
7852 (bidi_push_it, bidi_pop_it): New functions.
7853 (bidi_initialize): Initialize the bidi cache start stack pointer.
7854 (bidi_cache_ensure_space): New function, refactored from part of
7855 bidi_cache_iterator_state. Don't assume the required size is just
7856 one BIDI_CACHE_CHUNK away.
7857 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
7858 (bidi_count_bytes, bidi_char_at_pos): New functions.
7859 (bidi_cache_search): Don't assume bidi_cache_last_idx is
7860 always valid if bidi_cache_idx is valid.
7861 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
7862 is valid if it's going to be used.
7863 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
7864 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
7865 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7866 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
7867 (bidi_find_other_level_edge, bidi_cache_start_stack):
7868 All variables related to cache indices are now EMACS_INT.
c965adc5 7869
0bb23927
EZ
7870 * dispextern.h (struct bidi_string_data): New structure.
7871 (struct bidi_it): New member `string'. Make flag members be 1-bit
7872 fields, and put them last in the struct.
640c8776
SM
7873 (compute_display_string_pos, compute_display_string_end):
7874 Update prototypes.
0bb23927
EZ
7875 (bidi_push_it, bidi_pop_it): Add prototypes.
7876 (struct iterator_stack_entry): New members bidi_p,
7877 paragraph_embedding, and from_disp_prop_p.
7878 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
7879 (bidi_shelve_cache, bidi_unshelve_cache):
7880 Declare prototypes.
0bb23927
EZ
7881
7882 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
7883 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
7884 and vector-like objects.
7885
7886 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
7887 cache around display iteration.
7888
7889 * window.c (Fwindow_end, window_scroll_pixel_based)
7890 (displayed_window_lines, Frecenter): Save and restore the bidi
7891 cache around display iteration.
7892
3bbd2265
LMI
78932011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7894
7895 * editfns.c (Fdelete_region): Clarify the use of the named
7896 parameters (bug#6788).
7897
adc47434
MR
78982011-07-14 Martin Rudalics <rudalics@gmx.at>
7899
7900 * indent.c (Fvertical_motion): Set and restore w->pointm when
7901 saving and restoring the window's buffer (Bug#9006).
7902
837c31f8
LMI
79032011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
7904
7905 * editfns.c (Fstring_to_char): Clarify just what is returned
7906 (bug#6576). Text by Eli Zaretskii.
7907
ac389d0c
JB
79082011-07-13 Juanma Barranquero <lekktu@gmail.com>
7909
7910 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
7911
0be0ce47
EZ
79122011-07-13 Eli Zaretskii <eliz@gnu.org>
7913
7914 * buffer.c (mmap_find): Fix a typo.
7915
cd18e7e3
JB
79162011-07-13 Johan Bockgård <bojohan@gnu.org>
7917
7918 Fix execution of x selection hooks.
7919 * xselect.c (Qx_lost_selection_functions)
7920 (Qx_sent_selection_functions): New vars.
7921 (syms_of_xselect): DEFSYM them.
7922 (x_handle_selection_request): Pass Qx_sent_selection_functions
7923 rather than Vx_sent_selection_functions to Frun_hook_with_args.
7924 (x_handle_selection_clear,x_clear_frame_selections):
7925 Pass Qx_lost_selection_functions rather than
7926 Vx_lost_selection_functions to Frun_hook_with_args.
7927
47ea7f44
PE
79282011-07-13 Paul Eggert <eggert@cs.ucla.edu>
7929
ac389d0c 7930 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
7931 The old code sometimes used this field without initializing it.
7932
47ea7f44
PE
7933 * alloc.c (gc_sweep): Don't read past end of array.
7934 In theory, the old code could also have corrupted Emacs internals,
7935 though it'd be very unlikely.
7936
bc985c87
AS
79372011-07-12 Andreas Schwab <schwab@linux-m68k.org>
7938
7939 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 7940 argument. (Bug#4026)
bc985c87 7941
0cf34688
LMI
79422011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
7943
b3dadd76
LMI
7944 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
7945 key" (bug#4257).
7946
0cf34688
LMI
7947 * window.c (Fset_window_start): Doc fix (bug#4199).
7948 (Fset_window_hscroll): Ditto.
7949
270768cd
PE
79502011-07-12 Paul Eggert <eggert@cs.ucla.edu>
7951
077e3dda 7952 Fix minor new problems caught by GCC 4.6.1.
270768cd 7953 * term.c (init_tty): Remove unused local.
490011a6 7954 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 7955 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 7956 not used otherwise.
270768cd 7957
b1f58454
CY
79582011-07-12 Chong Yidong <cyd@stupidchicken.com>
7959
7960 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
7961
22b9578d
LMI
79622011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7963
6e70ab07
LMI
7964 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
7965 are the mini-buffer and the echo area (bug#3320).
7966
22b9578d
LMI
7967 * term.c (init_tty): Remove support for supdup, c10 and perq
7968 terminals, which are no longer supported (bug#1482).
7969
8974cc9f
JB
79702011-07-10 Johan Bockgård <bojohan@gnu.org>
7971
7972 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
7973
a560d974
JD
79742011-07-10 Jan Djärv <jan.h.d@swipnet.se>
7975
7976 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
7977 for non-popups (Bug#3642).
7978
1dae0f0a
AS
79792011-07-10 Andreas Schwab <schwab@linux-m68k.org>
7980
268c2c36 7981 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 7982 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
7983 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
7984 * cm.c (losecursor): Likewise.
1dae0f0a
AS
7985 * data.c (fmod): Likewise.
7986 * dispnew.c (swap_glyphs_in_rows): Likewise.
7987 * emacs.c (memory_warning_signal): Likewise.
7988 * floatfns.c (float_error): Likewise.
7989 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
7990 (otf_open, font_otf_capability, generate_otf_features)
7991 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
7992 Likewise.
7993 * image.c (pbm_read_file): Likewise.
7994 * indent.c (string_display_width): Likewise.
7995 * intervals.c (check_for_interval, search_for_interval)
7996 (inc_interval_count, count_intervals, root_interval)
7997 (adjust_intervals_for_insertion, make_new_interval): Likewise.
7998 * lread.c (defalias): Likewise.
268c2c36 7999 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
8000 * regex.c (set_image_of_range_1, set_image_of_range)
8001 (regex_grow_registers): Likewise.
8002 * sysdep.c (strerror): Likewise.
8003 * termcap.c (valid_filename_p, tprint, main): Likewise.
8004 * tparam.c (main): Likewise.
8005 * unexhp9k800.c (run_time_remap, save_data_space)
8006 (update_file_ptrs, read_header, write_header, calculate_checksum)
8007 (copy_file, copy_rest, display_header): Likewise.
8008 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
8009 Likewise.
8010 * xdisp.c (check_it): Likewise.
8011 * xfaces.c (register_color, unregister_color, unregister_colors):
8012 Likewise.
8013 * xfns.c (print_fontset_result): Likewise.
8014 * xrdb.c (member, fatal, main): Likewise.
8015
99033785
PE
80162011-07-10 Paul Eggert <eggert@cs.ucla.edu>
8017
8018 Fix minor problems found by static checking (Bug#9031).
8019 * chartab.c (char_table_set_range, map_sub_char_table):
8020 Remove unused locals.
8021 (uniprop_table): Now static.
8022 * composite.c (_work_char): Remove unused static var.
8023
9cb2ac56
JB
80242011-07-09 Juanma Barranquero <lekktu@gmail.com>
8025
8026 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
8027
f25661f0
JD
80282011-07-09 Jan Djärv <jan.h.d@swipnet.se>
8029
8030 * gtkutil.c (qttip_cb): Remove code without function.
8031
8278c4fe
EZ
80322011-07-09 Eli Zaretskii <eliz@gnu.org>
8033
8034 * w32.c (pthread_sigmask): New stub.
8035
1692ae2d 80362011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 8037
8a6ebd58 8038 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
8039 sigprocmask is portable only for single-threaded applications, and
8040 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
8041 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
8042 (LIBES): Use it.
8043 * callproc.c (Fcall_process):
8044 * process.c (create_process):
8045 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
8046 Use pthread_sigmask, not sigprocmask.
123403e4 8047
1b854618
JD
80482011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8049
8050 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
8051 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
8052 wrong (Bug#8591).
8053
3fe4b549
JD
80542011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8055
0ce7e563
JD
8056 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
8057 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
8058 (xg_hide_tooltip): Fix comment.
8059
3fe4b549
JD
8060 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
8061 in registerServicesMenuSendTypes.
8062 (validRequestorForSendType): Don't check ns_return_types.
8063
8064 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
8065 ns_return_type.
8066
5df75e47
JR
80672011-07-08 Jason Rumney <jasonr@gnu.org>
8068
22610910
JR
8069 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
8070 SH_SHOW for hidden windows (Bug#5482).
8071
5df75e47
JR
8072 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
8073 frame struct members of non-existent frames (Bug#6284).
8074
699c10bd
JD
80752011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8076
4393663b
JD
8077 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
8078 variable firstTime not needed on OSX >= 10.6.
8079 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
8080 >= 10.5. Use setKnobProportion, setDoubleValue.
8081
8082 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
8083 (MAC_OS_X_VERSION_10_5): Define if not defined.
8084 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
8085 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
8086 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
8087
8088 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 8089 cString and lossyCString on OSX >= 10.4.
4393663b 8090
58179cce 8091 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
8092 sizeToFit on OSX >= 10.2.
8093
8094 * nsimage.m (allocInitFromFile): Don't use deprecated method
8095 bestRepresentationForDevice on OSX >= 10.6.
8096
8097 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
8098 to avoid warning.
8099
8100 * emacs.c: Declare unexec_init_emacs_zone.
8101
a63e0781
JD
8102 * nsgui.h: Fix compiler warning about gnulib redefining verify.
8103
699c10bd
JD
8104 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
8105
8106 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
8107 on svcsMenu (Bug#8842).
8108
8109 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
8110 ns_return_types.
8111 (Fns_list_services): Just return Qnil on 10.6, code not working there.
8112
8113 * nsterm.m (QUTF8_STRING): Declare.
8114 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
8115 (validRequestorForSendType): Return type is (id).
8116 Change indexOfObjectIdenticalTo to indexOfObject.
8117 Check if we have local selection before returning self (Bug#8842).
8118 (writeSelectionToPasteboard): Put local selection into paste board
8119 if we have a local selection (Bug#8842).
8120 (syms_of_nsterm): DEFSYM QUTF8_STRING.
8121
8122 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
8123 (ns_get_local_selection): Declare.
8124
54e10184
LMI
81252011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
8126
9888ff71
LMI
8127 * keymap.c (describe_map_tree): Don't insert a double newline at
8128 the end of the buffer (bug#1169) and return whether we inserted
8129 something.
8130
54e10184
LMI
8131 * callint.c (Fcall_interactively): Change "reading args" to
8132 "providing args" to try to clarify what it does (bug#1010).
8133
15fa4783
KH
81342011-07-07 Kenichi Handa <handa@m17n.org>
8135
8136 * composite.c (composition_compute_stop_pos): Ignore a static
8137 composition starting before CHARPOS (Bug#8915).
8138
8139 * xdisp.c (handle_composition_prop): Likewise.
8140
a8815b00
EZ
81412011-07-07 Eli Zaretskii <eliz@gnu.org>
8142
8143 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
8144 (Bug#9015)
8145
ef7b981d 81462011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
8147
8148 * character.h (unicode_category_t): New enum type.
8149
8150 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
8151 (Qchar_code_property_table): New variable.
8152 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
8153 (UNIPROP_COMPRESSED_FORM_P): New macros.
8154 (char_table_ascii): Uncompress the compressed values.
8155 (sub_char_table_ref): New arg is_uniprop. Callers changed.
8156 Uncompress the compressed values.
ac389d0c 8157 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
8158 (char_table_ref_and_range): Uncompress the compressed values.
8159 (sub_char_table_set): New arg is_uniprop. Callers changed.
8160 Uncompress the compressed values.
8161 (sub_char_table_set_range): Args changed. Callers changed.
8162 (char_table_set_range): Adjuted for the above change.
8163 (map_sub_char_table): Delete args default_val and parent. Add arg
8164 top. Give decoded values to a Lisp function.
640c8776 8165 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
8166 values to a Lisp function. Gcpro more variables.
8167 (uniprop_table_uncompress)
8168 (uniprop_decode_value_run_length): New functions.
8169 (uniprop_decoder, uniprop_decoder_count): New variables.
8170 (uniprop_get_decoder, uniprop_encode_value_character)
8171 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
8172 New functions.
8173 (uniprop_encoder, uniprop_encoder_count): New variables.
8174 (uniprop_get_encoder, uniprop_table)
8175 (Funicode_property_table_internal, Fget_unicode_property_internal)
8176 (Fput_unicode_property_internal): New functions.
8177 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
8178 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 8179 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
8180 char-code-property-alist.
8181
640c8776 8182 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
8183 Vunicode_category_table.
8184
640c8776 8185 * font.c (font_range): Adjust for the change of
c805dec0
KH
8186 Vunicode_category_table.
8187
76b397fb
DN
81882011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
8189
8190 * m/iris4d.h: Remove file, move contents ...
8191 * s/irix6-5.h: ... here.
8192
22b4128e
PE
81932011-07-06 Paul Eggert <eggert@cs.ucla.edu>
8194
8195 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
8196 * alloc.c (mark_buffer):
8197 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
8198 (clone_per_buffer_values): Don't assume that
22b4128e
PE
8199 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
8200 This isn't true in general, and it's particularly not true
8201 if Emacs is configured with --with-wide-int.
8202 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
8203 New macros, used in the buffer.c change.
8204
869795d6
JD
82052011-07-05 Jan Djärv <jan.h.d@swipnet.se>
8206
8207 * xsettings.c: Use both GConf and GSettings if both are available.
8208 (store_config_changed_event): Add comment.
8209 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
8210 (store_tool_bar_style_changed): New functions.
5e617bc2 8211 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
8212 (struct xsettings): Move font inside HAVE_XFT.
8213 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 8214 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 8215 Move inside HAVE_XFT.
640c8776 8216 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
8217 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
8218 also.
8219 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 8220 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 8221 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
8222 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
8223 (parse_settings): Move check for font inside HAVE_XFT.
8224 (read_settings, apply_xft_settings): Add comment.
8225 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
8226 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
8227 call store_font_name_changed.
8228 (xft_settings_event): Add comment.
8229 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
8230 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
8231 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
8232 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
8233 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
8234 (xsettings_get_system_font, xsettings_get_system_normal_font):
8235 Add comment.
869795d6 8236
d8ed26bd
PE
82372011-07-05 Paul Eggert <eggert@cs.ucla.edu>
8238
8239 Random fixes. E.g., (random) never returned negative values.
8240 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
8241 subseconds part to the entropy, as that's a bit more random.
8242 Prefer signed to unsigned, since the signedness doesn't matter and
8243 in general we prefer signed. When given a limit, use a
8244 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
8245 latter isn't right if USE_2_TAGS_FOR_INTS.
8246 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
8247 not 0..VALMASK. Don't discard "excess" bits that random () returns.
8248
cabf1cac
SM
82492011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
8250
8251 * textprop.c (text_property_stickiness):
8252 Obey Vtext_property_default_nonsticky.
8253 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
8254 * w32fns.c (syms_of_w32fns):
8255 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
8256
6e9b2be9
PE
82572011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8258
8259 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
8260 This is more efficient than Ffile_directory_p and avoids a minor race.
8261
90186c68
LMI
82622011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
8263
7c301272
LMI
8264 * buffer.c (Foverlay_put): Say what the return value is
8265 (bug#7835).
8266
c4f2d8d4
LMI
8267 * fileio.c (barf_or_query_if_file_exists): Check first if the file
8268 is a directory before asking whether to use the file name
8269 (bug#7564).
ad637907
LMI
8270 (barf_or_query_if_file_exists): Make the "File is a directory"
8271 error be more correct.
c4f2d8d4 8272
90186c68
LMI
8273 * fns.c (Frequire): Remove the mention of the .gz files, since
8274 that's installation-specific, but keep the mention of
8275 `get-load-suffixes'.
8276
da64016e
PE
82772011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8278
8279 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
8280 Report string overflow if the output is too long.
8281
7d47b580
JB
82822011-07-04 Juanma Barranquero <lekktu@gmail.com>
8283
a555cb87
JB
8284 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
8285 (syms_of_gnutls): Remove duplicate DEFSYM for
8286 Qgnutls_bootprop_verify_hostname_error, an error for
8287 Qgnutls_bootprop_verify_error (which is no longer used).
8288
7d47b580
JB
8289 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
8290 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
8291 Also (re)move comments that are misplaced or no longer relevant.
8292
1e49bfab
LMI
82932011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8294
8295 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
8296
1485f4c0
CY
82972011-07-03 Chong Yidong <cyd@stupidchicken.com>
8298
8299 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
8300 and background color parameters if they have been changed.
8301
a9ab721e
LMI
83022011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8303
8304 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
8305
cf7cff57
PE
83062011-07-03 Paul Eggert <eggert@cs.ucla.edu>
8307
2e13213d
PE
8308 * xsettings.c (SYSTEM_FONT): Define only when used.
8309 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
8310
cf7cff57
PE
8311 * keymap.c (access_keymap_1): Now static.
8312
7a8e04f7
CY
83132011-07-02 Chong Yidong <cyd@stupidchicken.com>
8314
8315 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
8316 leave any prefix arg for the up event (Bug#1586).
8317
61352f62
LMI
83182011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
8319
69bb1ef7
LMI
8320 * lread.c (syms_of_lread): Mention single symbols defined by
8321 `defvar' or `defconst' (bug#7154).
8322
61352f62 8323 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 8324 (Frequire): Mention get-load-suffixes.
61352f62 8325
28545e04
MR
83262011-07-02 Martin Rudalics <rudalics@gmx.at>
8327
8328 * window.h (window): Remove clone_number slot.
8329 * window.c (Fwindow_clone_number, Fset_window_clone_number):
8330 Remove.
8331 (make_parent_window, make_window, saved_window)
8332 (Fset_window_configuration, save_window_save): Don't deal with
8333 clone numbers.
8334 * buffer.c (Qclone_number): Remove declaration.
8335 (sort_overlays, overlay_strings): Don't deal with clone numbers.
8336
3349e122
SM
83372011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
8338
8339 Add multiple inheritance to keymaps.
8340 * keymap.c (Fmake_composed_keymap): New function.
8341 (Fset_keymap_parent): Simplify.
8342 (fix_submap_inheritance): Remove.
8343 (access_keymap_1): New function extracted from access_keymap to handle
8344 embedded parents and handle lists of maps.
8345 (access_keymap): Use it.
8346 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
8347 (Fcopy_keymap): Handle embedded parents.
8348 (Fcommand_remapping, define_as_prefix): Simplify.
8349 (Fkey_binding): Simplify.
8350 (syms_of_keymap): Move minibuffer-local-completion-map,
8351 minibuffer-local-filename-completion-map,
8352 minibuffer-local-must-match-map, and
8353 minibuffer-local-filename-must-match-map to Elisp.
8354 (syms_of_keymap): Defsubr make-composed-keymap.
8355 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
8356 (parse_menu_item): Trivial simplification.
8357
3279eb87
GM
83582011-07-01 Glenn Morris <rgm@gnu.org>
8359
8360 * Makefile.in (SETTINGS_LIBS): Fix typo.
8361
4550efdf
KI
83622011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
8363
8364 * coding.c (Fencode_coding_string): Record the last coding system
8365 used, as the function doc string says (bug#8738).
8366
0949d2b6
JD
83672011-07-01 Jan Djärv <jan.h.d@swipnet.se>
8368
8369 * xsettings.c (store_monospaced_changed): Take new font as arg and
8370 check for change against current_mono_font.
8371 (EMACS_TYPE_SETTINGS): Remove this and related defines.
8372 (emacs_settings_constructor, emacs_settings_get_property)
8373 (emacs_settings_set_property, emacs_settings_class_init)
8374 (emacs_settings_init, gsettings_obj): Remove.
8375 (something_changedCB): New function for HAVE_GSETTINGS.
8376 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
8377 with value as argument.
8378 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
8379 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 8380 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
8381 "changed".
8382
8383 * xgselect.c: Add defined (HAVE_GSETTINGS).
8384 (xgselect_initialize): Ditto.
8385
8386 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
8387 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
8388 xg_select.
8389
bbc6b304
PE
83902011-07-01 Paul Eggert <eggert@cs.ucla.edu>
8391
8392 * eval.c (struct backtrace): Simplify and port the data structure.
8393 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
8394 signed bit field, as this assumption is not portable and it makes
8395 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
8396 "char debug_on_exit : 1" as this is not portable either; instead,
8397 use the portable "unsigned int debug_on_exit : 1". Remove unused
8398 member evalargs. Remove obsolete comments about cc bombing out.
8399
9851bfc5
JD
84002011-06-30 Jan Djärv <jan.h.d@swipnet.se>
8401
51bb811f 8402 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
8403 Let HAVE_GSETTINGS override HAVE_GCONF.
8404 (store_monospaced_changed): New function.
8405 (EMACS_SETTINGS): A new type derived from GObject to handle
8406 GSettings notifications.
8407 (emacs_settings_constructor, emacs_settings_get_property)
8408 (emacs_settings_set_property, emacs_settings_class_init):
8409 New functions.
8410 (gsettings_client, gsettings_obj): New variables.
8411 (GSETTINGS_SCHEMA): New define.
8412 (something_changedCB): Call store_monospaced_changed.
8413 (init_gsettings): New function.
8414 (xsettings_initialize): Call init_gsettings.
8415 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
8416 to NULL.
8417
640c8776 8418 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
8419 GCONF_CFLAGS/LIBS.
8420
5386012d
MR
84212011-06-29 Martin Rudalics <rudalics@gmx.at>
8422
8423 * window.c (resize_root_window, grow_mini_window)
8424 (shrink_mini_window): Rename Qresize_root_window to
8425 Qwindow_resize_root_window and Qresize_root_window_vertically to
8426 Qwindow_resize_root_window_vertically.
8427
f13e0b08
PE
84282011-06-28 Paul Eggert <eggert@cs.ucla.edu>
8429
8430 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
8431
94515237
JB
84322011-06-27 Juanma Barranquero <lekktu@gmail.com>
8433
8434 * makefile.w32-in: Redesign dependencies so they reflect more
8435 clearly which files are directly included by each source file,
8436 and not through other includes.
8437
e43b6e43
MR
84382011-06-27 Martin Rudalics <rudalics@gmx.at>
8439
8440 * buffer.c (Qclone_number): Declare static and DEFSYM it.
8441 (sort_overlays, overlay_strings): When an overlay's clone number
8442 matches the window's clone number process the overlay even if
8443 the overlay's window property doesn't match the current window.
8444
d68443dc
MR
8445 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
8446 (Fwindow_hchild): Rename to Fwindow_left_child.
8447 (Fwindow_next): Rename to Fwindow_next_sibling.
8448 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
8449 (resize_window_check): Rename to window_resize_check.
8450 (resize_window_apply): Rename to window_resize_apply.
8451 (Fresize_window_apply): Rename to Fwindow_resize_apply.
8452 (Fdelete_other_windows_internal, resize_frame_windows)
8453 (Fsplit_window_internal, Fdelete_window_internal)
8454 (grow_mini_window, shrink_mini_window)
8455 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 8456
c7e73be5
JD
84572011-06-26 Jan Djärv <jan.h.d@swipnet.se>
8458
8459 * emacsgtkfixed.h: State that this is only used with Gtk+3.
8460 (emacs_fixed_set_min_size): Remove.
8461 (emacs_fixed_new): Take frame as argument.
8462
8463 * emacsgtkfixed.c: State that this is only used with Gtk+3.
8464 (_EmacsFixedPrivate): Remove minwidth/height.
8465 Add struct frame *f.
8466 (emacs_fixed_init): Initialize priv->f.
8467 (get_parent_class, emacs_fixed_set_min_size): Remove.
8468 (emacs_fixed_new): Set priv->f to argument.
8469 (emacs_fixed_get_preferred_width)
8470 (emacs_fixed_get_preferred_height): Use min_width/height from
8471 frames size_hint to set minimum and natural (Bug#8919).
8472 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
8473 and use min_width/height from frames size_hint to set
8474 min_width/height (Bug#8919).
8475
8476 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
8477 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
8478 Fix indentation.
c7e73be5 8479
cf99dcf8
EZ
84802011-06-26 Eli Zaretskii <eliz@gnu.org>
8481
8482 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
8483 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
8484 called at ZV.
8485
029529ac
CY
84862011-06-26 Chong Yidong <cyd@stupidchicken.com>
8487
8488 * process.c (wait_reading_process_output): Bypass select if
8489 waiting for a cell while ignoring keyboard input, and input is
8490 pending. Suggested by Jan Djärv (Bug#8869).
8491
7a7ef429
PE
84922011-06-25 Paul Eggert <eggert@cs.ucla.edu>
8493
8494 Use gnulib's dup2 module instead of rolling our own.
8495 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
8496
11fdef7d 84972011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
8498
8499 * dispnew.c (scrolling_window): Before scrolling, turn off a
8500 mouse-highlight in the window being scrolled.
8501
cd3520a4
JB
85022011-06-24 Juanma Barranquero <lekktu@gmail.com>
8503
8504 Move DEFSYM to lisp.h and use everywhere.
8505
8506 * character.h (DEFSYM): Move declaration...
8507 * lisp.h (DEFSYM): ...here.
8508
8509 * gnutls.c:
8510 * minibuf.c:
8511 * w32menu.c:
8512 * w32proc.c:
8513 * w32select.c: Don't include character.h.
8514
8515 * alloc.c (syms_of_alloc):
8516 * buffer.c (syms_of_buffer):
8517 * bytecode.c (syms_of_bytecode):
8518 * callint.c (syms_of_callint):
8519 * casefiddle.c (syms_of_casefiddle):
8520 * casetab.c (init_casetab_once):
8521 * category.c (init_category_once, syms_of_category):
8522 * ccl.c (syms_of_ccl):
8523 * cmds.c (syms_of_cmds):
8524 * composite.c (syms_of_composite):
8525 * dbusbind.c (syms_of_dbusbind):
8526 * dired.c (syms_of_dired):
8527 * dispnew.c (syms_of_display):
8528 * doc.c (syms_of_doc):
8529 * editfns.c (syms_of_editfns):
8530 * emacs.c (syms_of_emacs):
8531 * eval.c (syms_of_eval):
8532 * fileio.c (syms_of_fileio):
8533 * fns.c (syms_of_fns):
8534 * frame.c (syms_of_frame):
8535 * fringe.c (syms_of_fringe):
8536 * insdel.c (syms_of_insdel):
8537 * keymap.c (syms_of_keymap):
8538 * lread.c (init_obarray, syms_of_lread):
8539 * macros.c (syms_of_macros):
8540 * msdos.c (syms_of_msdos):
8541 * print.c (syms_of_print):
8542 * process.c (syms_of_process):
8543 * search.c (syms_of_search):
8544 * sound.c (syms_of_sound):
8545 * syntax.c (init_syntax_once, syms_of_syntax):
8546 * terminal.c (syms_of_terminal):
8547 * textprop.c (syms_of_textprop):
8548 * undo.c (syms_of_undo):
8549 * w32.c (globals_of_w32):
8550 * window.c (syms_of_window):
8551 * xdisp.c (syms_of_xdisp):
8552 * xfaces.c (syms_of_xfaces):
8553 * xfns.c (syms_of_xfns):
8554 * xmenu.c (syms_of_xmenu):
8555 * xsettings.c (syms_of_xsettings):
8556 * xterm.c (syms_of_xterm): Use DEFSYM.
8557
4228cf16
TZ
85582011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
8559
cd3520a4 8560 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 8561
7fcccf1e
PE
85622011-06-23 Paul Eggert <eggert@cs.ucla.edu>
8563
7efb4e0e
PE
8564 Integer and buffer overflow fixes (Bug#8873).
8565
ff5844ad
PE
8566 * print.c (printchar, strout): Check for string overflow.
8567 (PRINTPREPARE, printchar, strout):
8568 Don't set size unless allocation succeeds.
8569
90532f02
PE
8570 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
8571 for sizes. Check for string overflow more accurately.
8572 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
8573
6d84508d
PE
8574 * macros.c: Integer and buffer overflow fixes.
8575 * keyboard.h (struct keyboard.kbd_macro_bufsize):
8576 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
8577 Use ptrdiff_t, not int, for sizes.
8578 Don't increment bufsize until after realloc succeeds.
8579 Check for size-calculation overflow.
8580 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
8581
437b2cb4
PE
8582 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
8583
8b9ac8b4
PE
8584 * lread.c: Integer overflow fixes.
8585 (read_integer): Radix is now EMACS_INT, not int,
8586 to improve quality of diagnostics for out-of-range radices.
8587 Calculate buffer size correctly for out-of-range radices.
8588 (read1): Check for integer overflow in radices, and in
8589 read-circle numbers.
82cb60d3
PE
8590 (read_escape): Avoid int overflow.
8591 (Fload, openp, read_buffer_size, read1)
8592 (substitute_object_recurse, read_vector, read_list, map_obarray):
8593 Use ptrdiff_t, not int, for sizes.
8594 (read1): Use EMACS_INT, not int, for sizes.
20270765 8595 Check for size overflow.
8b9ac8b4 8596
7fcccf1e
PE
8597 * image.c (cache_image): Check for size arithmetic overflow.
8598
bfbbd7e7
PE
8599 * lread.c: Integer overflow issues.
8600 (saved_doc_string_size, saved_doc_string_length)
8601 (prev_saved_doc_string_size, prev_saved_doc_string_length):
8602 Now ptrdiff_t, not int.
8603 (read1): Don't assume doc string length fits in int. Check for
8604 out-of-range doc string lengths.
8605 (read_list): Don't assume file position fits in int.
39019e54 8606 (read_escape): Check for hex character overflow.
bfbbd7e7 8607
4e323265
LL
86082011-06-22 Leo Liu <sdl.web@gmail.com>
8609
8610 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
8611 Move to minibuffer.el.
8612
85fece3e
PE
86132011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8614
20b84ce9 8615 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
8616 The following patches are for when GLYPH_DEBUG && !XASSERT.
8617 * dispextern.h (trace_redisplay_p, dump_glyph_string):
8618 * dispnew.c (flush_stdout):
8619 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
8620 Mark as externally visible.
8621 * dispnew.c (check_window_matrix_pointers): Now static.
8622 * dispnew.c (window_to_frame_vpos):
8623 * xfns.c (unwind_create_frame):
8624 * xterm.c (x_check_font): Remove unused local.
8625 * scroll.c (CHECK_BOUNDS):
8626 * xfaces.c (cache_fache): Rename local to avoid shadowing.
8627 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
8628 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
8629 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
8630 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
8631 Now static.
8632 (debug_method_add): Use va_list and vsprintf rather than relying
8633 on undefined behavior with wrong number of arguments.
8634 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
8635 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
8636 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
8637 since we're not interested in debugging glyphs with old libraries.
8638 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
8639 GCC 4.6.0's static checking.
8640
0766b489
PE
86412011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8642
31fd4b32
PE
8643 Integer overflow and signedness fixes (Bug#8873).
8644 A few related buffer overrun fixes, too.
8645
b79e8648
PE
8646 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
8647
0766b489
PE
8648 * dispextern.h (struct face.stipple):
8649 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
8650 (x_bitmap_mask, x_allocate_bitmap_record)
8651 (x_create_bitmap_from_data, x_create_bitmap_from_file)
8652 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
8653 (x_create_bitmap_from_xpm_data):
8654 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
8655 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
8656 (.bitmaps_last):
8657 * xfaces.c (load_pixmap):
8658 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
8659 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
8660 (.bitmaps_last, struct x_output.icon_bitmap):
8661 Use ptrdiff_t, not int, for bitmap indexes.
8662 (x_allocate_bitmap_record): Check for size overflow.
8663 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
8664
b081724f
PE
8665 Use ptrdiff_t, not int, for overlay counts.
8666 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
8667 * editfns.c (overlays_around, get_pos_property):
8668 * textprop.c (get_char_property_and_overlay):
8669 * xdisp.c (next_overlay_change, note_mouse_highlight):
8670 * xfaces.c (face_at_buffer_position):
21514da7
PE
8671 * buffer.c (OVERLAY_COUNT_MAX): New macro.
8672 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
8673 (Fnext_overlay_change, Fprevious_overlay_change)
8674 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 8675 Use ptrdiff_t, not int, for sizes.
21514da7 8676 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 8677
3de73e5e
PE
8678 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
8679
2606c57b
PE
8680 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
8681 (x_session_initialize): Do not assume string length fits in int.
8682
aaafe47a
PE
8683 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
8684 This is unlikely, but can occur if DPI is outlandish.
8685
2674ddc8 8686 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
8687 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
8688
28154962
PE
8689 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
8690 * xrdb.c (magic_file_p, search_magic_path):
8691 Omit last arg SUFFIX; it was always 0. All callers changed.
8692 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
8693
7de51af5
PE
8694 * xfont.c (xfont_match): Avoid need for strlen.
8695
25ed6cc3
PE
8696 * xfns.c: Don't assume strlen fits in int.
8697 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
8698
4eab31dd
PE
8699 * xdisp.c (message_log_check_duplicate): Return intmax_t,
8700 not unsigned long, as we prefer signed integers. All callers changed.
8701 Detect integer overflow in repeat count.
8702 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 8703 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 8704
171e2a58
PE
8705 * termcap.c: Don't assume sizes fit in int and never overflow.
8706 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
8707 (gobble_line): Check for size-calculation overflow.
8708
ad39faca 8709 * minibuf.c (Fread_buffer):
6e5bb2dc 8710 * lread.c (intern, intern_c_string):
74ca2eb3
PE
8711 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
8712 Don't assume string length fits in int.
8713
52c61c22 8714 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
8715 * gtkutil.c (style_changed_cb): Avoid need for strlen.
8716
b5b8c9e5
PE
8717 * font.c: Don't assume string length fits in int.
8718 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
8719 Use ptrdiff_t, not int.
ccd6111c
PE
8720 (font_intern_prop): Don't assume string length fits in int.
8721 Don't assume integer property fits in fixnum.
8722 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 8723
882f0d81 8724 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 8725 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
8726 Reformulate so as not to need the command string.
8727 Invoke gzip -cd rather than gunzip, as it's more portable.
8728 (lock_info_type, lock_file_1, lock_file):
8729 Don't assume pid_t and time_t fit in unsigned long.
8730 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
8731 (current_lock_owner): Prefer signed type for sizes.
8732 Use memcpy, not strncpy, where memcpy is what is really wanted.
8733 Don't assume (via atoi) that time_t and pid_t fit in int.
8734 Check for time_t and/or pid_t out of range, e.g., via a network share.
8735 Don't alloca where an auto var works fine.
8736
93f4cf88
PE
8737 * fileio.c: Fix some integer overflow issues.
8738 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
8739 Don't assume string length fits in int.
8740 (directory_file_name): Don't assume string length fits in long.
8741 (make_temp_name): Don't assume pid fits in int, or that its print
8742 length is less than 20.
8743
f3e92b69
PE
8744 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
8745
1bfdaf10
PE
8746 * coding.c (make_subsidiaries): Don't assume string length fits in int.
8747
35016e9a
PE
8748 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
8749
3d1e65a1
PE
8750 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
8751 We prefer signed integers, even for size calculations.
8752
0b963a93
PE
8753 * emacs.c: Don't assume string length fits in 'int'.
8754 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
8755 (main): Don't invoke strlen when not needed.
8756
573f4b54
PE
8757 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
8758 (XD_DEBUG_MESSAGE): Don't waste a byte.
8759
989f33ba
PE
8760 * callproc.c (getenv_internal_1, getenv_internal)
8761 (Fgetenv_internal):
965d34eb
PE
8762 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
8763
e4d29b33
PE
8764 * lread.c (invalid_syntax): Omit length argument.
8765 All uses changed. This doesn't fix a bug, but it simplifies the
8766 code away from its former Hollerith-constant appearance, and it's
8767 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 8768 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 8769
eb49b136
PE
8770 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
8771 This didn't break anything, but it didn't help either.
8772 It's confusing to put a bogus integer in a place where the actual
8773 value does not matter.
9f62aeb1 8774 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 8775 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 8776
15375a22
PE
8777 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
8778 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
8779 implementation.
b61cc01c
PE
8780 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
8781 We prefer signed types, and the value cannot exceed the EMACS_INT
8782 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
8783 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
8784 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
8785 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 8786
53b2623d
PE
8787 * indent.c (sane_tab_width): New function.
8788 (current_column, scan_for_column, Findent_to, position_indentation)
8789 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 8790 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 8791
51cab52b 8792 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 8793
f2ed8a70
PE
8794 * lisp.h (lint_assume): New macro.
8795 * composite.c (composition_gstring_put_cache):
8796 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
8797
abe80cc6
PE
8798 * editfns.c, insdel.c:
8799 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 8800
b02c740e
PE
8801 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
8802
ebc96716
PE
8803 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
8804
b4e50fa0 8805 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 8806 Use much-faster test for byte-length change.
311d5d7c 8807 Don't assume string byte-length fits in 'int'.
a4cf38e4 8808 Check that character arg fits in 'int'.
85461888 8809 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 8810
c0c1ee9f
PE
8811 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
8812
a498d7f4
PE
8813 * fns.c (concat): Catch string overflow earlier.
8814 Do not rely on integer wraparound.
8815
51cab52b
PE
8816 * dispextern.h (struct it.overlay_strings_charpos)
8817 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
8818 * xdisp.c (forward_to_next_line_start)
8819 (back_to_previous_visible_line_start)
8820 (reseat_at_next_visible_line_start, next_element_from_buffer):
8821 Don't arbitrarily truncate the value of 'selective' to int.
8822
76031fad
PE
8823 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
8824
5eb55db9
PE
8825 * composite.c: Don't truncate sizes to 'int'.
8826 (composition_gstring_p, composition_reseat_it)
8827 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
8828 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
8829 not EMACS_UINT, for indexes.
5eb55db9 8830
0703a717
PE
8831 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
8832
d6202519
PE
8833 * buffer.c: Include <verify.h>.
8834 (struct sortvec.priority, struct sortstr.priority):
8961a454 8835 Now EMACS_INT, not int.
c20998a7 8836 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
8837 (struct sortstr.size, record_overlay_string)
8838 (struct sortstrlist.size, struct sortlist.used):
8839 Don't truncate size to int.
8840 (record_overlay_string): Check for size-calculation overflow.
d6202519 8841 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 8842
d5a19415
JM
88432011-06-22 Jim Meyering <meyering@redhat.com>
8844
029529ac 8845 Don't leak an XBM-image-sized buffer
d5a19415
JM
8846 * image.c (xbm_load): Free the image buffer after using it.
8847
a9041e6c
PE
88482011-06-21 Paul Eggert <eggert@cs.ucla.edu>
8849
8850 Port to Sun C.
8851 * composite.c (find_automatic_composition): Omit needless 'return 0;'
8852 that Sun C diagnosed.
8853 * fns.c (secure_hash): Fix pointer signedness issue.
8854 * intervals.c (static_offset_intervals): New function.
8855 (offset_intervals): Use it.
8856
7f3f739f
LL
88572011-06-21 Leo Liu <sdl.web@gmail.com>
8858
8859 * deps.mk (fns.o):
8860 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
8861 sha512.h.
8862
8863 * fns.c (secure_hash): Rename from crypto_hash_function and change
8864 the first arg to accept symbols.
5b66d427 8865 (Fsecure_hash): New primitive.
7f3f739f
LL
8866 (syms_of_fns): New symbols.
8867
76147d94
DD
88682011-06-20 Deniz Dogan <deniz@dogan.se>
8869
8870 * process.c (Fset_process_buffer): Clarify return value in
8871 docstring.
8872
7d7d0045
CY
88732011-06-18 Chong Yidong <cyd@stupidchicken.com>
8874
8875 * dispnew.c (add_window_display_history): Use BVAR.
8876
8877 * xdisp.c (debug_method_add): Use BVAR.
8878 (check_window_end, dump_glyph_matrix, dump_glyph)
8879 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
8880
8881 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
8882 Likewise.
8883
8884 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
8885 check till after the cache is created in init_frame_faces.
8886
ff2bc410
SM
88872011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
8888
8889 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
8890
28177add
PE
88912011-06-16 Paul Eggert <eggert@cs.ucla.edu>
8892
dd3482fe
PE
8893 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
8894 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
8895 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
8896
393d71f3 8897 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
8898 * fileio.c (Finsert_file_contents):
8899 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
8900 Remove the old (too-loose) buffer overflow checks.
8901 They weren't needed, since make_gap checks for buffer overflow.
8902 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
8903 The old code merely checked for Emacs fixnum overflow, and relied
8904 on undefined (wraparound) behavior. The new code avoids undefined
8905 behavior, and also checks for ptrdiff_t and/or size_t overflow.
8906
2e6813b0 8907 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
8908 Tune. Don't use wider integers than needed. Don't use alloca.
8909 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 8910
599a9e4f
PE
8911 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
8912
99561444
PE
8913 * insdel.c, lisp.h (buffer_overflow): New function.
8914 (insert_from_buffer_1, replace_range, replace_range_2):
8915 * insdel.c (make_gap_larger):
8916 * editfns.c (Finsert_char):
8917 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
8918
28177add
PE
8919 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
8920
e69dafad
PE
89212011-06-15 Paul Eggert <eggert@cs.ucla.edu>
8922
4baa020d 8923 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 8924
b1c46f02
PE
8925 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
8926 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
8927
e69dafad
PE
8928 * fileio.c: Don't assume EMACS_INT fits in off_t.
8929 (emacs_lseek): New static function.
8930 (Finsert_file_contents, Fwrite_region): Use it.
8931 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
8932
566684ea
PE
8933 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
8934
e6966cd6
PE
8935 * fns.c: Don't overflow int when computing a list length.
8936 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
8937 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
8938 truncation on 64-bit hosts. Check for QUIT every
8939 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
8940 faster and is responsive enough.
8941 (Flength): Report an error instead of overflowing an integer.
8942 (Fsafe_length): Return a float if the value is not representable
8943 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 8944 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 8945 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 8946
dd0b0efb
PE
8947 * alloc.c: Check that resized vectors' lengths fit in fixnums.
8948 (header_size, word_size): New constants.
8949 (allocate_vectorlike): Don't check size overflow here.
8950 (allocate_vector): Check it here instead, since this is the only
8951 caller of allocate_vectorlike that could cause overflow.
8952 Check that the new vector's length is representable as a fixnum.
8953
86fe5cfe
PE
8954 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
8955 The previous code was bogus. For example, next_almost_prime (32)
8956 returned 39, which is undesirable as it is a multiple of 3; and
8957 next_almost_prime (24) returned 25, which is a multiple of 5 so
8958 why was the code bothering to check for multiples of 7?
8959
80e88859
PE
8960 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
8961
4a2f0ad6
PE
8962 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
8963
f66c7cf8
PE
8964 Variadic C functions now count arguments with ptrdiff_t.
8965 This partly undoes my 2011-03-30 change, which replaced int with size_t.
8966 Back then I didn't know that the Emacs coding style prefers signed int.
8967 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
8968 were being counted with int, which may truncate counts on 64-bit
8969 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
8970 * lisp.h (struct Lisp_Subr.function.aMANY)
8971 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
8972 Arg counts are now ptrdiff_t, not size_t.
8973 All variadic functions and their callers changed accordingly.
8974 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
8975 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
8976 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
8977 * callint.c (Fcall_interactively): Check arg count for overflow,
8978 to avoid potential buffer overrun. Use signed char, not 'int',
8979 for 'varies' array, so that we needn't bother to check its size
8980 calculation for overflow.
8981 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
8982 * eval.c (apply_lambda):
8983 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
8984 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
8985 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
8986
a1759b76
PE
8987 * callint.c (Fcall_interactively): Don't use index var as event count.
8988
d96be9fc
PE
8989 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
8990 * mem-limits.h (SIZE): Remove; no longer used.
8991
a690a978 8992 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 8993
578c21e6
PE
8994 Remove unnecessary casts.
8995 * xterm.c (x_term_init):
8996 * xfns.c (x_set_border_pixel):
8997 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
8998 These aren't needed now that we assume ANSI C.
8999
96f53c6c
PE
9000 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
9001 It's more likely to cause problems (due to unsigned overflow)
9002 than to cure them.
9003
83c77d31
PE
9004 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
9005
ee2079f1
PE
9006 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
9007
6da65536
PE
9008 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
9009
7147c4a4
PE
9010 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
9011
193e32d9
PE
9012 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
9013
e5533da6
PE
9014 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
9015
9910e595
PE
9016 GLYPH_CODE_FACE returns EMACS_INT, not int.
9017 * dispextern.h (merge_faces):
9018 * xfaces.c (merge_faces):
01103c44
PE
9019 * xdisp.c (get_next_display_element, next_element_from_display_vector):
9020 Don't assume EMACS_INT fits in int.
9910e595 9021
2638320e
PE
9022 * character.h (CHAR_VALID_P): Remove unused parameter.
9023 * fontset.c, lisp.h, xdisp.c: All uses changed.
9024
045eb8d9
PE
9025 * editfns.c (Ftranslate_region_internal): Omit redundant test.
9026
c1f134b5
PE
9027 * fns.c (concat): Minor tuning based on overflow analysis.
9028 This doesn't fix any bugs. Use int to hold character, instead
9029 of constantly refetching from Emacs object. Use XFASTINT, not
9030 XINT, for value known to be a character. Don't bother comparing
9031 a single byte to 0400, as it's always less.
9032
395fcb93 9033 * floatfns.c (Fexpt):
327eeec8
PE
9034 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
9035
abbd3d23
PE
9036 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
9037 for characters.
9038
684a03ef
PE
9039 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
9040
0fed43f3
PE
9041 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
9042 Without this fix, on a 64-bit host (aset S 0 4294967386) would
9043 incorrectly succeed when S was a string, because 4294967386 was
9044 truncated before it was used.
9045
8fd02eb7
PE
9046 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
9047 Otherwise, an out-of-range integer could cause undefined behavior
9048 on a 64-bit host.
9049
f8c86b69
PE
9050 * composite.c: Use int, not EMACS_INT, for characters.
9051 (fill_gstring_body, composition_compute_stop_pos): Use int, not
9052 EMACS_INT, for values that are known to be in character range.
9053 This doesn't fix any bugs but is the usual style inside Emacs and
9054 may generate better code on 32-bit machines.
9055
34206dd2
PE
9056 Make sure a 64-bit char is never passed to ENCODE_CHAR.
9057 This is for reasons similar to the recent CHAR_STRING fix.
9058 * charset.c (Fencode_char): Check that character arg is actually
9059 a character. Pass an int to ENCODE_CHAR.
9060 * charset.h (ENCODE_CHAR): Verify that the character argument is no
9061 wider than 'int', as a compile-time check to prevent future regressions
9062 in this area.
9063
c5958d4c 9064 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
9065
9066 Make sure a 64-bit char is never passed to CHAR_STRING.
9067 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
9068 by silently ignoring the top 32 bits, allowing some values
9069 that were far too large to be valid characters.
9070 * character.h: Include <verify.h>.
9071 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
9072 arguments are no wider than unsigned, as a compile-time check
9073 to prevent future regressions in this area.
9074 * data.c (Faset):
01103c44 9075 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
9076 (Fsubst_char_in_region):
9077 * fns.c (concat):
9078 * xdisp.c (decode_mode_spec_coding):
9079 Adjust to CHAR_STRING's new requirement.
9080 * editfns.c (Finsert_char, Fsubst_char_in_region):
9081 * fns.c (concat): Check that character args are actually
9082 characters. Without this test, these functions did the wrong
9083 thing with wildly out-of-range values on 64-bit hosts.
9084
d37ca623
PE
9085 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
9086 These casts should not be needed on 32-bit hosts, either.
9087 * keyboard.c (read_char):
9088 * lread.c (Fload): Remove casts to unsigned.
9089
ea204efb
PE
9090 * lisp.h (UNSIGNED_CMP): New macro.
9091 This fixes comparison bugs on 64-bit hosts.
9092 (ASCII_CHAR_P): Use it.
9093 * casefiddle.c (casify_object):
01103c44 9094 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
9095 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
9096 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
9097 * dispextern.h (FACE_FROM_ID):
9098 * keyboard.c (read_char): Use UNSIGNED_CMP.
9099
41cb286c
PE
9100 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
9101 not to EMACS_INT, to avoid GCC warning.
9102
4a1b9832
PE
9103 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
9104
55daad71
PE
9105 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
9106 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
9107 isn't needed on 32-bit machines.
8f95c75c 9108
01103c44
PE
9109 * buffer.c (Fgenerate_new_buffer_name):
9110 Use EMACS_INT for count, not int.
0ceccced 9111 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
9112
9113 * data.c (Qcompiled_function): Now static.
9114
c6f072e7
PE
9115 * window.c (window_body_lines): Now static.
9116
20ce5912
PE
9117 * image.c (gif_load): Rename local to avoid shadowing.
9118
9c4c5f81
PE
9119 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
9120 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
9121 * alloc.c (make_save_value): Integer argument is now of type
9122 ptrdiff_t, not int.
9123 (mark_object): Use ptrdiff_t, not int.
9124 * lisp.h (pD): New macro.
9125 * print.c (print_object): Use it.
9126
c0c5c8ae
PE
9127 * alloc.c: Use EMACS_INT, not int, to count objects.
9128 (total_conses, total_markers, total_symbols, total_vector_size)
9129 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
9130 (total_free_floats, total_floats, total_free_intervals)
9131 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
9132 Now EMACS_INT, not int. All uses changed.
9133 (Fgarbage_collect): Compute overall total using a double, so that
9134 integer overflow is less likely to be a problem. Check for overflow
9135 when converting back to an integer.
5a25e253
PE
9136 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
9137 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
9138 These were 'int' variables that could overflow on 64-bit hosts;
9139 they were never used, so remove them instead of repairing them.
211a0b2a 9140 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
9141 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
9142 Previously, this ceilinged at INT_MAX, but that doesn't work on
9143 64-bit machines.
e46bb31a 9144 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 9145
c78baabf 9146 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 9147 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
9148 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
9149 when a (possibly-narrower) signed value would do just as well.
9150 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 9151
c9d624c6
PE
9152 * alloc.c: Catch some string size overflows that we were missing.
9153 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
9154 for convenience in STRING_BYTES_MAX.
9155 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
9156 The definition here is exact; the one in lisp.h was approximate.
9157 (allocate_string_data): Check for string overflow. This catches
9158 some instances we weren't catching before. Also, it catches
9159 size_t overflow on (unusual) hosts where SIZE_MAX <= min
9160 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
9161 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 9162
c9d624c6
PE
9163 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
9164 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 9165 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 9166
353032ce
PE
9167 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
9168
2bccce07
PE
9169 * alloc.c (Fmake_string): Check for out-of-range init.
9170
0ac30604
SM
91712011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
9172
9173 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
9174
c195f2de
JD
91752011-06-14 Jan Djärv <jan.h.d@swipnet.se>
9176
9177 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
9178 xg_get_default_scrollbar_width.
9179
9180 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
9181 (int_gtk_range_get_value): Move to the scroll bar part of the file.
9182 (style_changed_cb): Call update_theme_scrollbar_width and call
9183 x_set_scroll_bar_default_width and xg_frame_set_char_size for
9184 all frames (Bug#8505).
9185 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
9186 Call gtk_window_set_resizable if HAVE_GTK3.
9187 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
9188 and height if HAVE_GTK3 (Bug#8505).
9189 (scroll_bar_width_for_theme): New variable.
9190 (update_theme_scrollbar_width): New function.
9191 (xg_get_default_scrollbar_width): Move code to
9192 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
9193 (xg_initialize): Call update_theme_scrollbar_width.
9194
9195 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
9196
9197 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
9198
e10ac9f1
MR
91992011-06-12 Martin Rudalics <rudalics@gmx.at>
9200
9201 * frame.c (make_frame): Call other_buffer_safely instead of
9202 other_buffer.
9203
9204 * window.c (temp_output_buffer_show): Call display_buffer with
9205 second argument Vtemp_buffer_show_specifiers and reset latter
9206 immediately after the call.
9207 (Vtemp_buffer_show_specifiers): New variable.
9208 (auto_window_vscroll_p, next_screen_context_lines)
9209 (Vscroll_preserve_screen_position): Remove leading asterisks from
9210 doc-strings.
9211
2d3c217e 92122011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 9213
7b7f97e8 9214 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
9215 * buffer.c (Qclone_number): Remove for now, as it's unused.
9216 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
9217 (record_buffer): Remove unused local.
9218 * frame.c (other_visible_frames, frame_buffer_list): Now static.
9219 (set_frame_buffer_list): Remove; unused.
9220 * frame.h (other_visible_frames): Remove decl.
9221 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
9222 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
9223 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
9224 if HAVE_GPM.
9225 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
9226 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
9227 Define only if HAVE_GPM.
9228 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
9229 (update_hints_inhibit): Remove; never set. All uses removed.
9230 * widgetprv.h (emacsFrameClassRec): Remove decl.
9231 * window.c (delete_deletable_window): Now returns void, since it
9232 wasn't returning anything.
9233 (compare_window_configurations): Remove unused locals.
9234 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
9235 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
9236 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
9237 the same widths as pointers. This follows up on the 2011-05-06 patch.
9238 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
9239 * xterm.h: Likewise.
9240 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
9241
1384b89e
JB
92422011-06-12 Juanma Barranquero <lekktu@gmail.com>
9243
9244 * makefile.w32-in: Update dependencies.
9245 (LISP_H): Add lib/intprops.h.
9246
1100a63c
CY
92472011-06-11 Chong Yidong <cyd@stupidchicken.com>
9248
9249 * image.c (gif_load): Add animation frame delay to the metadata.
9250 (syms_of_image): Use DEFSYM. New symbol `delay'.
9251
6198ccd0
MR
92522011-06-11 Martin Rudalics <rudalics@gmx.at>
9253
9254 * window.c (delete_deletable_window): Re-add.
9255 (Fset_window_configuration): Rewrite to handle dead buffers and
9256 consequently deletable windows.
9257 (window_tree, Fwindow_tree): Remove. Supply functionality in
9258 window.el.
9259 (compare_window_configurations): Simplify code.
9260
b6e3633c
AS
92612011-06-11 Andreas Schwab <schwab@linux-m68k.org>
9262
1ab0dee5
AS
9263 * image.c (imagemagick_load_image): Fix type mismatch.
9264 (Fimagemagick_types): Likewise.
9265
b6e3633c
AS
9266 * window.h (replace_buffer_in_windows): Declare.
9267
9397e56f
MR
92682011-06-11 Martin Rudalics <rudalics@gmx.at>
9269
9270 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
9271 Qclone_number. Remove external declaration of Qdelete_window.
9272 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
9273 code.
640c8776
SM
9274 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
9275 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
9276 (Fother_buffer): Rewrite doc-string. Major rewrite for new
9277 buffer list implementation.
9278 (other_buffer_safely): New function.
9279 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
9280 calls to replace_buffer_in_windows and
9281 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
9282 if allowed.
9283 (record_buffer): Inhibit quitting and rewrite using quittable
9284 functions. Run Qbuffer_list_update_hook if allowed.
9285 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
9286 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
9287 Move switch-to-buffer to window.el.
9397e56f
MR
9288 (bury-buffer): Move to window.el.
9289 (Vbuffer_list_update_hook): New variable.
9290
9291 * lisp.h (other_buffer_safely): Add prototype in buffer.c
9292 section.
9293
9294 * window.h (resize_frame_windows): Move up in code.
9295 (Fwindow_frame): Remove EXFUN.
9296 (replace_buffer_in_all_windows): Remove prototype.
9297 (replace_buffer_in_windows_safely): Add prototype.
9298
9299 * window.c: Declare Qdelete_window static again. Move down
9300 declaration of select_count.
9301 (Fnext_window, Fprevious_window): Rewrite doc-strings.
9302 (Fother_window): Move to window.el.
9303 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
9304 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
9305 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
9306 window.el.
9307 (replace_buffer_in_windows): Implement by calling
9308 Qreplace_buffer_in_windows.
9309 (replace_buffer_in_all_windows): Remove with some functionality
9310 moved into replace_buffer_in_windows_safely.
9311 (replace_buffer_in_windows_safely): New function.
9312 (select_window_norecord, select_frame_norecord): Move in front
9313 of run_window_configuration_change_hook. Remove now obsolete
9314 declarations.
640c8776
SM
9315 (Fset_window_buffer): Rewrite doc-string.
9316 Call Qrecord_window_buffer.
9397e56f
MR
9317 (keys_of_window): Move binding for other-window to window.el.
9318
b50691aa
CY
93192011-06-11 Chong Yidong <cyd@stupidchicken.com>
9320
9321 * dispextern.h (struct image): Replace data member, whose int_val
9322 and ptr_val fields were not used by anything, with a single
9323 lisp_val object.
9324
9325 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
9326 (gif_clear_image, gif_load, imagemagick_load_image)
9327 (gs_clear_image, gs_load): Callers changed.
9328
3f754b86
PE
93292011-06-10 Paul Eggert <eggert@cs.ucla.edu>
9330
cca69397
PE
9331 * buffer.h: Include <time.h>, for time_t.
9332 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
9333
109e28d0
PE
9334 Fix minor problems found by static checking.
9335
60737f02
PE
9336 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
9337
4b66faf3
PE
9338 Make identifiers static if they are not used in other modules.
9339 * data.c (Qcompiled_function, Qframe, Qvector):
9340 * image.c (QimageMagick, Qsvg):
9341 * minibuf.c (Qmetadata):
9342 * window.c (resize_window_check, resize_root_window): Now static.
9343 * window.h (resize_window_check, resize_root_window): Remove decls.
9344
109e28d0
PE
9345 * window.c (window_deletion_count, delete_deletable_window):
9346 Remove; unused.
46a4ce9e
PE
9347 (window_body_lines): Now static.
9348 (Fdelete_other_windows_internal): Mark vars as initialized.
9349 Make sure 'resize_failed' is initialized.
9350 (run_window_configuration_change_hook): Rename local to avoid shadowing.
9351 (resize_window_apply): Remove unused local.
9352 * window.h (delete_deletable_window): Remove decl.
9353
109e28d0 9354 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
9355 (imagemagick_load_image): Fix pointer signedness problem by changing
9356 last arg from unsigned char * to char *. All uses changed.
9357 Also, fix a local for similar reasons.
9358 Remove unused locals. Remove locals to avoid shadowing.
9359 (fn_rsvg_handle_free): Remove; unused.
9360 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 9361 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 9362
3f754b86
PE
9363 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
9364
2547adb1
CY
93652011-06-10 Chong Yidong <cyd@stupidchicken.com>
9366
9367 * image.c (gif_load): Fix omitted cast error introduced by
9368 2011-06-06 change.
9369
2c8e37d4
MR
93702011-06-10 Martin Rudalics <rudalics@gmx.at>
9371
9372 * window.h (resize_proportionally, orig_total_lines)
9373 (orig_top_line): Remove from window structure.
9374 (set_window_height, set_window_width, change_window_heights)
9375 (Fdelete_window): Remove prototypes.
9376 (resize_frame_windows): Remove duplicate declaration.
9377
440a42e3
EZ
93782011-06-10 Eli Zaretskii <eliz@gnu.org>
9379
9380 * window.h (resize_frame_windows, resize_window_check)
9381 (delete_deletable_window, resize_root_window)
9382 (resize_frame_windows): Declare prototypes.
9383
9384 * window.c (resize_window_apply): Make definition be "static" to
9385 match the prototype.
9386
562dd5e9
MR
93872011-06-10 Martin Rudalics <rudalics@gmx.at>
9388
9389 * window.c: Remove declarations of Qwindow_size_fixed,
9390 window_min_size_1, window_min_size_2, window_min_size,
9391 size_window, window_fixed_size_p, enlarge_window, delete_window.
9392 Remove static from declaration of Qdelete_window, it's
9393 temporarily needed by Fbury_buffer.
9394 (replace_window): Don't assign orig_top_line and
9395 orig_total_lines.
9396 (Fdelete_window, delete_window): Remove. Window deletion is
9397 handled by window.el.
640c8776
SM
9398 (window_loop): Remove DELETE_OTHER_WINDOWS case.
9399 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
9400 (Fdelete_other_windows): Remove. Deleting other windows is
9401 handled by window.el.
9402 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
9403 handled in window.el.
9404 (window_min_size_2, window_min_size_1, window_min_size): Remove.
9405 Window minimum sizes are handled in window.el.
9406 (shrink_windows, size_window, set_window_height)
9407 (set_window_width, change_window_heights, window_height)
9408 (window_width, CURBEG, CURSIZE, enlarge_window)
9409 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
9410 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
9411 handled in window.el.
9412 (make_dummy_parent): Rename to make_parent_window and give it a
9413 second argument horflag.
9414 (make_window): Don't set resize_proportionally any more.
9415 (Fsplit_window): Remove. Windows are split in window.el.
9416 (save_restore_action, save_restore_orig_size)
9417 (shrink_window_lowest_first, save_restore_orig_size): Remove.
9418 Resize mini windows in window.el.
9419 (grow_mini_window, shrink_mini_window): Implement by calling
9420 Qresize_root_window_vertically, resize_window_check and
9421 resize_window_apply.
640c8776
SM
9422 (saved_window, Fset_window_configuration, save_window_save):
9423 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
9424 resize_proportionally.
9425 (window_min_height, window_min_width): Move to window.el.
9426 (keys_of_window): Move bindings for delete-other-windows,
9427 split-window, delete-window and enlarge-window to window.el.
9428
9429 * buffer.c: Temporarily extern Qdelete_window.
9430 (Fbury_buffer): Temporarily call Qdelete_window instead of
9431 Fdelete_window (Fbury_buffer will move to window.el soon).
9432
9433 * frame.c (set_menu_bar_lines_1): Remove code handling
9434 orig_top_line and orig_total_lines.
9435
9436 * dispnew.c (adjust_frame_glyphs_initially): Don't use
9437 set_window_height but set heights directly.
9438 (change_frame_size_1): Use resize_frame_windows.
9439
9440 * xdisp.c (init_xdisp): Don't use set_window_height but set
9441 heights directly.
9442
640c8776
SM
9443 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
9444 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
9445 run_window_configuration_change_hook.
9446
9447 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
9448 instead of change_window_heights and run
9449 run_window_configuration_change_hook.
9450
1a13852e
MR
94512011-06-09 Martin Rudalics <rudalics@gmx.at>
9452
9453 * window.c (replace_window): Rename second argument REPLACEMENT to
9454 NEW. New third argument SETFLAG. Rewrite.
9455 (delete_window, make_dummy_parent): Call replace_window with
9456 third argument 1.
9457 (window_list_1): Move down in code.
9458 (run_window_configuration_change_hook): Move set_buffer part
9459 before select_frame_norecord part in order to unwind correctly.
9460 Rename count1 to count.
9461 (recombine_windows, delete_deletable_window, resize_root_window)
9462 (Fdelete_other_windows_internal)
9463 (Frun_window_configuration_change_hook, make_parent_window)
9464 (resize_window_check, resize_window_apply, Fresize_window_apply)
9465 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
9466 (Fdelete_window_internal, Fresize_mini_window_internal):
9467 New functions.
1a13852e
MR
9468 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
9469
f3d1777e
MR
94702011-06-08 Martin Rudalics <rudalics@gmx.at>
9471
496e208e
MR
9472 * window.h (window): Add some new members to window structure -
9473 normal_lines, normal_cols, new_total, new_normal, clone_number,
9474 splits, nest, prev_buffers, next_buffers.
9475 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 9476 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 9477
f3d1777e
MR
9478 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
9479 Remove.
496e208e
MR
9480 (make_dummy_parent): Set new members of windows structure.
9481 (make_window): Move down in code. Handle new members of window
9482 structure.
9483 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
9484 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
9485 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
9486 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
9487 (Fset_window_next_buffers, Fset_window_clone_number):
9488 New functions.
496e208e
MR
9489 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
9490 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
9491 Doc-string fixes.
9492 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
9493 Argument WINDOW can be now internal window too.
9494 (Fwindow_use_time): Move up in code.
9495 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
9496 Rewrite doc-string.
9497 (Fset_window_configuration, saved_window)
9498 (Fcurrent_window_configuration, save_window_save): Handle new
9499 members of window structure.
b9e809c2
MR
9500 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
9501 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
9502 (syms_of_window): New Lisp objects Qrecord_window_buffer,
9503 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
9504 Qget_mru_window, Qresize_root_window,
9505 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
9506 Qauto_buffer_name; staticpro them.
f3d1777e 9507
abde8f8c
MR
95082011-06-07 Martin Rudalics <rudalics@gmx.at>
9509
9510 * window.c (Fwindow_total_size, Fwindow_left_column)
9511 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
9512 (Fwindow_list_1): New functions.
9513 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
9514 (Fwindow_width, Fscroll_left, Fscroll_right):
9515 Use window_body_cols instead of window_box_text_cols.
9516 (delete_window, Fset_window_configuration):
9517 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
9518 (delete_all_subwindows): Take a window as argument and not a
9519 structure. Rewrite.
190b47e6
MR
9520 (window_loop): Remove handling of GET_LRU_WINDOW and
9521 GET_LARGEST_WINDOW.
9522 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
9523
9524 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
9525 window_box_text_cols. delete_all_subwindows now takes a
9526 Lisp_Object as argument.
abde8f8c 9527
640c8776
SM
9528 * indent.c (compute_motion, Fcompute_motion):
9529 Use window_body_cols instead of window_box_text_cols.
abde8f8c 9530
fa8a67e6
MR
9531 * frame.c (delete_frame): Call delete_all_subwindows with root
9532 window as argument.
9533
a54e3482
DC
95342011-06-07 Daniel Colascione <dan.colascione@gmail.com>
9535
9536 * fns.c (Fputhash): Document return value.
9537
60002bf5
CY
95382011-06-06 Chong Yidong <cyd@stupidchicken.com>
9539
9540 * image.c (gif_load): Implement gif89a spec "no disposal" method.
9541
0c671da6 95422011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 9543
b862a52a 9544 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 9545
be44ca6c
PE
9546 Check for overflow when converting integer to cons and back.
9547 * charset.c (Fdefine_charset_internal, Fdecode_char):
9548 Use cons_to_unsigned to catch overflow.
9549 (Fencode_char): Use INTEGER_TO_CONS.
9550 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
9551 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
9552 * data.c (long_to_cons, cons_to_long): Remove.
9553 (cons_to_unsigned, cons_to_signed): New functions.
9554 These signal an error for invalid or out-of-range values.
9555 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
9556 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
9557 * font.c (Ffont_variation_glyphs):
9558 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
9559 * lisp.h: Include <intprops.h>.
9560 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
9561 (cons_to_signed, cons_to_unsigned): New decls.
9562 (long_to_cons, cons_to_long): Remove decls.
9563 * undo.c (record_first_change): Use INTEGER_TO_CONS.
9564 (Fprimitive_undo): Use CONS_TO_INTEGER.
9565 * xfns.c (Fx_window_property): Likewise.
9566 * xselect.c: Include <limits.h>.
9567 (x_own_selection, selection_data_to_lisp_data):
9568 Use INTEGER_TO_CONS.
9569 (x_handle_selection_request, x_handle_selection_clear)
9570 (x_get_foreign_selection, Fx_disown_selection_internal)
9571 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
9572 (lisp_data_to_selection_data): Use cons_to_unsigned.
9573 (x_fill_property_data): Use cons_to_signed.
9574 Report values out of range.
9575
d1f3d2af
PE
9576 Check for buffer and string overflow more precisely.
9577 * buffer.h (BUF_BYTES_MAX): New macro.
9578 * lisp.h (STRING_BYTES_MAX): New macro.
9579 * alloc.c (Fmake_string):
9580 * character.c (string_escape_byte8):
9581 * coding.c (coding_alloc_by_realloc):
9582 * doprnt.c (doprnt):
9583 * editfns.c (Fformat):
9584 * eval.c (verror):
9585 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
9586 since they may not be the same number.
9587 * editfns.c (Finsert_char):
9588 * fileio.c (Finsert_file_contents):
9589 Likewise for BUF_BYTES_MAX.
9590
dd52fcea
PE
9591 * image.c: Use ptrdiff_t, not int, for sizes.
9592 (slurp_file): Switch from int to ptrdiff_t.
9593 All uses changed.
9594 (slurp_file): Check that file size fits in both size_t (for
9595 malloc) and ptrdiff_t (for sanity and safety).
9596
7f9bbdbb
PE
9597 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
9598 if b->modtime has its maximal value.
9599
dfe18f82
PE
9600 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
9601
84acfcf0
PE
9602 Don't assume time_t can fit into int.
9603 * buffer.h (struct buffer.modtime): Now time_t, not int.
9604 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
9605 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
9606
ccd9a01a
PE
9607 Minor fixes for signed vs unsigned integers.
9608 * character.h (MAYBE_UNIFY_CHAR):
9609 * charset.c (maybe_unify_char):
9610 * keyboard.c (read_char, reorder_modifiers):
9611 XINT -> XFASTINT, since the integer must be nonnegative.
9612 * ftfont.c (ftfont_spec_pattern):
9613 * keymap.c (access_keymap, silly_event_symbol_error):
9614 XUINT -> XFASTINT, since the integer must be nonnegative.
9615 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
9616 since it makes no difference and we prefer signed.
9617 * keyboard.c (record_char): Use XUINT when all the neighbors do.
9618 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
9619 nonnegative.
9620
d6d100dd
SM
96212011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
9622
9623 * window.h (Fwindow_frame): Declare.
9624
2b6148e4
PE
96252011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9626
9627 * alloc.c: Simplify handling of large-request failures (Bug#8800).
9628 (SPARE_MEMORY): Always define.
9629 (LARGE_REQUEST): Remove.
9630 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
9631
f230ecc9
MR
96322011-06-06 Martin Rudalics <rudalics@gmx.at>
9633
727e958e
MR
9634 * lisp.h: Move EXFUNS for Fframe_root_window,
9635 Fframe_first_window and Fset_frame_selected_window to window.h.
9636
9637 * window.h: Move EXFUNS for Fframe_root_window,
9638 Fframe_first_window and Fset_frame_selected_window here from
9639 lisp.h.
9640
9641 * frame.c (Fwindow_frame, Fframe_first_window)
9642 (Fframe_root_window, Fframe_selected_window)
9643 (Fset_frame_selected_window): Move to window.c.
9644 (Factive_minibuffer_window): Move to minibuf.c.
9645 (Fother_visible_frames_p): New function.
9646
9647 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
9648
f230ecc9
MR
9649 * window.c (decode_window, decode_any_window): Move up in code.
9650 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
9651 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
9652 (Fwindow_buffer): Move up and rewrite doc-string.
9653 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
9654 (Fwindow_prev): New functions.
727e958e
MR
9655 (Fwindow_frame): Move here from frame.c. Accept any window as
9656 argument.
9657 (Fframe_root_window, Fframe_first_window)
9658 (Fframe_selected_window): Move here from frame.c. Accept frame
9659 or arbitrary window as argument. Update doc-strings.
9660 (Fminibuffer_window): Move up in code.
9661 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
9662 (Fset_frame_selected_window): Move here from frame.c.
9663 Marginal rewrite.
727e958e
MR
9664 (Fselected_window, select_window, Fselect_window): Move up in
9665 code. Minor doc-string fixes.
f230ecc9 9666
4d09bcf6
PE
96672011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9668
9669 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
9670 Do not assume that spare memory exists; that assumption is valid
9671 only if SYSTEM_MALLOC.
9672 (LARGE_REQUEST): New macro, so that the issue of large requests
9673 is separated from the issue of spare memory.
9674
810928a2
AS
96752011-06-05 Andreas Schwab <schwab@linux-m68k.org>
9676
172418ad
AS
9677 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
9678 format. (Bug#8806)
9679
43f862f7
AS
9680 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
9681
810928a2
AS
9682 * xfns.c (x_set_scroll_bar_default_width): Move declarations
9683 before statements.
9684
a059fe24
JD
96852011-06-05 Jan Djärv <jan.h.d@swipnet.se>
9686
9687 * gtkutil.c (xg_get_default_scrollbar_width): New function.
9688
9689 * gtkutil.h: Declare xg_get_default_scrollbar_width.
9690
9691 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
9692 min width by calling x_set_scroll_bar_default_width (Bug#8505).
9693
989bf368
JB
96942011-06-05 Juanma Barranquero <lekktu@gmail.com>
9695
9696 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
9697
4b80f674
CY
96982011-06-04 Chong Yidong <cyd@stupidchicken.com>
9699
9700 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
9701 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
9702 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
9703 New error handlers.
4b80f674
CY
9704 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
9705 Obey Vx_select_enable_clipboard_manager. Catch errors in
9706 x_clipboard_manager_save (Bug#8779).
9707 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 9708 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 9709
99a33b77 97102011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
9711
9712 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
9713
99a33b77 97142011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
9715
9716 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
9717 in the current matrix if keep_current_p is non-zero.
9718
8264569d
EZ
97192011-06-04 Eli Zaretskii <eliz@gnu.org>
9720
9721 * bidi.c (bidi_level_of_next_char): Fix last change.
9722
57f97249
EZ
97232011-06-03 Eli Zaretskii <eliz@gnu.org>
9724
fec2107c 9725 Support bidi reordering of text covered by display properties.
57f97249 9726
fec2107c
EZ
9727 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
9728 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
9729 (bidi_cache_search, bidi_cache_iterator_state)
9730 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
9731 (bidi_level_of_next_char, bidi_move_to_visually_next):
9732 Support character positions inside a run of characters covered by a
fec2107c
EZ
9733 display string.
9734 (bidi_paragraph_init, bidi_resolve_explicit_1)
9735 (bidi_level_of_next_char): Call bidi_fetch_char and
9736 bidi_fetch_char_advance instead of FETCH_CHAR and
9737 FETCH_CHAR_ADVANCE.
9738 (bidi_init_it): Initialize new members.
9739 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
9740 definitions.
9741 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
9742 instead of using explicit *_CHAR codes.
d6d100dd
SM
9743 (bidi_resolve_explicit, bidi_resolve_weak):
9744 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
9745 bidirectional text is supported only in multibyte buffers.
9746 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
9747 it to initialize the frame_window_p member of struct bidi_it.
9748 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
9749 (bidi_resolve_explicit, bidi_resolve_weak)
9750 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
9751 bidi_it->nchars is non-positive.
9752 (bidi_level_of_next_char): Don't try to lookup the cache for the
9753 next/previous character if nothing is cached there yet, or if we
9754 were just reseat()'ed to a new position.
c40e2fb2 9755
0e14fe90
EZ
9756 * xdisp.c (set_cursor_from_row): Set start and stop points
9757 according to the row's direction when priming the loop that looks
9758 for the glyph on which to display cursor.
9759 (single_display_spec_intangible_p): Function deleted.
9760 (display_prop_intangible_p): Reimplement to call
9761 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
9762 Accept 3 additional arguments needed by handle_display_spec.
9763 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
9764 values: lists, `(when COND...)' forms, etc.
9765 (single_display_spec_string_p): Support property values that are
9766 lists with the argument STRING its top-level element.
9767 (display_prop_string_p): Fix the condition for processing a
9768 property that is a list to be consistent with handle_display_spec.
fec2107c 9769 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
9770 last portion of handle_display_prop.
9771 (compute_display_string_pos): Accept additional argument
9772 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
9773 value of a `display' property is a "replacing spec".
9774 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
9775 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
9776 the display property, but just return a value indicating whether
9777 the display property will replace the characters it covers.
9778 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
9779 frame_window_p members of struct bidi_it.
d6d100dd
SM
9780 (compute_display_string_pos, compute_display_string_end):
9781 New functions.
fec2107c
EZ
9782 (push_it): Accept second argument POSITION, where pop_it should
9783 jump to continue iteration.
9784 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 9785
fec2107c
EZ
9786 * keyboard.c (adjust_point_for_property): Adjust the call to
9787 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
9788
9789 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
9790 (bidi_init_it): Update prototypes.
9791 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
9792 (compute_display_string_pos, compute_display_string_end):
9793 Declare prototypes.
fec2107c
EZ
9794 (struct bidi_it): New members nchars and disp_pos. ch_len is now
9795 EMACS_INT.
fc6f18ce 9796
40087514 97972011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 9798
57f53182
PE
9799 Malloc failure behavior now depends on size of allocation.
9800 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
9801 * lisp.h: Change signatures accordingly.
9802 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
9803 All callers changed. (Bug#8762)
9804
9805 * gnutls.c: Use Emacs's memory allocators.
9806 Without this change, the gnutls library would invoke malloc etc.
9807 directly, which causes problems on non-SYNC_INPUT hosts, and which
9808 runs afoul of improving memory_full behavior. (Bug#8761)
9809 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
9810 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
9811 xfree instead of the default malloc, realloc, free.
9812 (Fgnutls_boot): No need to check for memory allocation failure,
9813 since xmalloc does that for us.
9814
ac32cd99 9815 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
9816 * category.c (hash_get_category_set):
9817 * ccl.c (ccl_driver):
9818 * charset.c (Fdefine_charset_internal):
9819 * charset.h (struct charset.hash_index):
9820 * composite.c (get_composition_id, gstring_lookup_cache)
9821 (composition_gstring_put_cache):
9822 * composite.h (struct composition.hash_index):
9823 * dispextern.h (struct image.hash):
9824 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
9825 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
9826 (hashfn_equal, hashfn_user_defined, make_hash_table)
9827 (maybe_resize_hash_table, hash_lookup, hash_put)
9828 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
9829 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
9830 (Fsxhash, Fgethash, Fputhash, Fmaphash):
9831 * image.c (make_image, search_image_cache, lookup_image)
9832 (xpm_put_color_table_h):
9833 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 9834 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 9835 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 9836 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
9837 * alloc.c (allocate_vectorlike):
9838 Check for overflow in vector size calculations.
9839 * ccl.c (ccl_driver):
9840 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
9841 * fns.c, image.c: Remove unnecessary static decls that would otherwise
9842 need to be updated by these changes.
40087514
PE
9843 * fns.c (make_hash_table, maybe_resize_hash_table):
9844 Check for integer overflow with large hash tables.
0de4bb68
PE
9845 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
9846 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
9847 (SXHASH_REDUCE): New macro.
9848 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
9849 Use it instead of discarding useful hash info with large hash values.
9850 (sxhash_float): New function.
9851 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
9852 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
9853 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
9854 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
9855 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
9856 Adjust signatures to match updated version of code.
9857 (consing_since_gc): Now EMACS_INT, since a single hash table can
9858 use more than INT_MAX bytes.
9859
698d32e2
DN
98602011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
9861
9862 Make it possible to build with GCC-4.6+ -O2 -flto.
9863
9864 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
9865
fd6fa53f
SM
98662011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
9867
9868 * minibuf.c (get_minibuffer, read_minibuf_unwind):
9869 Call minibuffer-inactive-mode.
9870
864db017
JB
98712011-05-31 Juanma Barranquero <lekktu@gmail.com>
9872
9873 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
9874 Update dependencies.
9875
2ad0baf4
DN
98762011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9877
9878 * data.c (init_data): Remove code for UTS, this system is not
9879 supported anymore.
9880
4fcc2638
DN
98812011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9882
9883 Don't force ./temacs to start in terminal mode.
9884
9885 * frame.c (make_initial_frame): Initialize faces in all cases, not
9886 only when CANNOT_DUMP is defined.
9887 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
9888
c56e0fd5
DN
98892011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9890
9891 * dispnew.c (add_window_display_history): Use const for the string
9892 pointer. Remove declaration, not needed.
9893
333d54da 98942011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 9895
55d4c1b2 9896 Use 'inline', not 'INLINE'.
333d54da 9897 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
9898 * alloc.c, fontset.c (INLINE): Remove.
9899 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
9900 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
9901 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
9902 * gmalloc.c (register_heapinfo): Use inline unconditionally.
9903 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
9904
738db178
DN
99052011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9906
9907 Make it possible to run ./temacs.
9908
9909 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
9910 syms_of_callproc does the same thing. Remove test for
9911 "initialized", do it in the caller.
9912 * emacs.c (main): Avoid calling set_initial_environment when dumping.
9913
620c53a6
SM
99142011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
9915
9916 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
9917 (read_minibuf): Use get_minibuffer.
9918 (syms_of_minibuf): Use DEFSYM.
9919 (Qmetadata): New var.
9920 * data.c (Qbuffer): Don't make it static.
9921 (syms_of_data): Use DEFSYM.
9922
e003a292
PE
99232011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9924
9925 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
9926 (CCL_CODE_MIN): New macro.
9927
ed008a6d
PE
99282011-05-30 Paul Eggert <eggert@cs.ucla.edu>
9929
3687c2ef
PE
9930 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
9931
ed008a6d
PE
9932 * eval.c (Qdebug): Now static.
9933 * lisp.h (Qdebug): Remove decl. This reverts a part of the
9934 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
9935 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
9936
d66c4c7c
CY
99372011-05-29 Chong Yidong <cyd@stupidchicken.com>
9938
9939 * image.c: Various fixes to ImageMagick code comments.
9940 (Fimagemagick_types): Doc fix.
9941
5fbc2025
PE
99422011-05-29 Paul Eggert <eggert@cs.ucla.edu>
9943
0196f88a
PE
9944 Minor fixes prompted by GCC 4.6.0 warnings.
9945
9946 * xselect.c (converted_selections, conversion_fail_tag): Now static.
9947
5fbc2025
PE
9948 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
9949 (x_clipboard_manager_save_all): Move extern decl to ...
9950 * xterm.h: ... here, so that it can be checked for consistency.
9951
1dd3c2d9
CY
99522011-05-29 Chong Yidong <cyd@stupidchicken.com>
9953
9954 * xselect.c (x_clipboard_manager_save_frame)
9955 (x_clipboard_manager_save_all): New functions.
9956 (Fx_clipboard_manager_save): Lisp function deleted.
9957
9958 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
9959 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
9960
9961 * xterm.h: Update prototype.
9962
5ba6571d
WX
99632011-05-28 William Xu <william.xwl@gmail.com>
9964
9965 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
9966 exiting (Bug#8239).
9967
3eaff834
JM
99682011-05-28 Jim Meyering <meyering@redhat.com>
9969
e1900994 9970 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
9971 * fns.c (to_uchar): Define.
9972 (crypto_hash_function): Use it to convert some newly-signed
9973 variables to unsigned, to avoid sign-extension bugs. For example,
9974 without this change, (md5 "truc") would evaluate to
9975 45723a2aff78ff4fff7fff1114760e62 rather than the expected
9976 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 9977 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 9978
0f6990a7
PE
99792011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9980
9981 Integer overflow fixes.
c8a9ca5a 9982
08686060
PE
9983 * dbusbind.c: Serial number integer overflow fixes.
9984 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
9985 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
9986 to hold a serial number that is too large for a fixnum.
9987 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9988 Check for serial numbers out of range. Decode any serial number
59568bf0 9989 that was so large that it became a float. (Bug#8722)
08686060 9990
2d1fc3c7
PE
9991 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
9992 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9993 Use XFASTINT rather than XUINT when numbers are nonnegative.
9994 (xd_append_arg, Fdbus_method_return_internal):
9995 (Fdbus_method_error_internal): Likewise. Also, for unsigned
9996 arguments, check that Lisp number is nonnegative, rather than
59568bf0 9997 silently wrapping negative numbers around. (Bug#8722)
30217ff0 9998 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 9999 (Bug#8722)
2d1fc3c7 10000
c8a9ca5a
PE
10001 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
10002
519e1d69
PE
10003 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
10004
6df6ae42 10005 ccl: Add integer overflow checks.
30569699
PE
10006 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
10007 (IN_INT_RANGE): New macros.
10008 (ccl_driver): Use them to check for integer overflow when
10009 decoding a CCL program. Many of the new checks are whether XINT (x)
10010 fits in int; it doesn't always, on 64-bit hosts. The new version
10011 doesn't catch all possible integer overflows, but it's an
847044ea 10012 improvement. (Bug#8719)
30569699 10013
c11285dc
PE
10014 * alloc.c (make_event_array): Use XINT, not XUINT.
10015 There's no need for unsigned here.
10016
fdccd48e
PE
10017 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
10018 This follows up to the 2011-05-06 change that substituted uintptr_t
10019 for EMACS_INT. This case wasn't caught back then.
10020
37910ab2
PE
10021 Rework Fformat to avoid integer overflow issues.
10022 * editfns.c: Include <float.h> unconditionally, as it's everywhere
10023 now (part of C89). Include <verify.h>.
10024 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
10025 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
10026 (Fformat): Avoid the prepass trying to compute sizes; it was only
10027 approximate and thus did not catch overflow reliably. Instead, walk
10028 through the format just once, formatting and computing sizes as we go,
10029 checking for integer overflow at every step, and allocating a larger
10030 buffer as needed. Keep track separately whether the format is
10031 multibyte. Keep only the most-recently calculated precision, rather
10032 than them all. Record whether each argument has been converted to
10033 string. Use EMACS_INT, not int, for byte and char and arg counts.
10034 Support field widths and precisions larger than INT_MAX. Avoid
10035 sprintf's undefined behavior with conversion specifications such as %#d
10036 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
10037 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
10038 formatting out-of-range floating point numbers with int
9173deec 10039 formats. (Bug#8668)
37910ab2 10040
2e6578fb
PE
10041 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
10042
0ae6bdee
PE
10043 * data.c: Avoid integer truncation in expressions involving floats.
10044 * data.c: Include <intprops.h>.
10045 (arith_driver): When there's an integer overflow in an expression
10046 involving floating point, convert the integers to floating point
10047 so that the resulting value does not suffer from catastrophic
10048 integer truncation. For example, on a 64-bit host (* 4
10049 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
10050 Do not rely on undefined behavior after integer overflow.
10051
de883a70
PE
10052 merge count_size_as_multibyte, parse_str_to_multibyte
10053 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 10054 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
10055 Check for integer overflow.
10056 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
10057 since it's now a duplicate of the other. This is more of
10058 a character than a buffer op, so better that it's in character.c.
10059 * fns.c, print.c: Adjust to above changes.
10060
2ff916cb
PE
100612011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
10062
10063 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
10064
f1b54466
PE
100652011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10066
fb1ac845
PE
10067 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10068 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
10069 (x_clipboard_manager_save): Now static.
10070 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
10071
f1b54466
PE
10072 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10073 (crypto_hash_function): Now static.
10074 Fix pointer signedness problems. Avoid unnecessary initializations.
10075
a9f737ee
CY
100762011-05-27 Chong Yidong <cyd@stupidchicken.com>
10077
10078 * termhooks.h (Vselection_alist): Make it terminal-local.
10079
10080 * terminal.c (create_terminal): Initialize it.
10081
10082 * xselect.c: Support for clipboard managers.
10083 (Vselection_alist): Move to termhooks.h as terminal-local var.
10084 (LOCAL_SELECTION): New macro.
10085 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
10086 (symbol_to_x_atom): Remove gratuitous arg.
10087 (x_handle_selection_request, lisp_data_to_selection_data)
10088 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
10089 (x_own_selection, x_get_local_selection, x_convert_selection):
10090 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
10091 (some_frame_on_display): Delete unused function.
10092 (Fx_own_selection_internal, Fx_get_selection_internal)
10093 (Fx_disown_selection_internal, Fx_selection_owner_p)
10094 (Fx_selection_exists_p): New optional frame arg.
10095 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
10096 (x_handle_selection_clear): Don't treat other terminals with the
10097 same keyboard specially. Use the terminal-local Vselection_alist.
10098 (x_clear_frame_selections): Use Frun_hook_with_args.
10099
10100 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
10101
10102 * xterm.h: Add support for those atoms.
10103
e067f0c1
CY
101042011-05-26 Chong Yidong <cyd@stupidchicken.com>
10105
10106 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
10107 (converted_selections, conversion_fail_tag): New global variables.
10108 (x_selection_request_lisp_error): Free the above.
10109 (x_get_local_selection): Remove unnecessary code.
10110 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
10111 of converted selections stored in converted_selections.
10112 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
10113 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
10114 (x_convert_selection): New function.
10115 (x_handle_selection_event): Simplify.
10116 (x_get_foreign_selection): Don't ignore incoming requests while
10117 waiting for an answer; this will fail when we implement
10118 SAVE_TARGETS, and seems unnecessary anyway.
10119 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
10120 (Vx_sent_selection_functions): Doc fix.
10121
0f4aebc0
LL
101222011-05-26 Leo Liu <sdl.web@gmail.com>
10123
10124 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
10125
e61124cd
YM
101262011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10127
10128 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
10129
10130 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
10131 for fringe update if it has periodic bitmap.
ac389d0c 10132 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
10133 and fringe_bitmap_periodic_p.
10134
10135 * fringe.c (get_fringe_bitmap_data): New function.
10136 (draw_fringe_bitmap_1, update_window_fringes): Use it.
10137 (update_window_fringes): Record periodicity of fringe bitmap in glyph
10138 row. Mark glyph row for fringe update if periodicity changed.
10139
10140 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
10141 for fringe update unless it has periodic bitmap.
10142
f16d9837
KH
101432011-05-25 Kenichi Handa <handa@m17n.org>
10144
10145 * xdisp.c (get_next_display_element): Set correct it->face_id for
10146 a static composition.
10147
e1b90ef6
LL
101482011-05-24 Leo Liu <sdl.web@gmail.com>
10149
10150 * deps.mk (fns.o):
10151 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
10152
10153 * fns.c (crypto_hash_function, Fsha1): New function.
10154 (Fmd5): Use crypto_hash_function.
10155 (syms_of_fns): Add Ssha1.
10156
7400048f
PE
101572011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10158
10159 * gnutls.c: Remove unused macros.
10160 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
10161 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
10162 Remove macros that are defined and never used.
10163 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
10164
abb71cf4
CY
101652011-05-22 Chong Yidong <cyd@stupidchicken.com>
10166
10167 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
10168 (Fx_get_selection_internal): Minor cleanup.
10169 (Fx_own_selection_internal): Rename arguments for consistency with
10170 select.el.
10171
6307db39
PE
101722011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10173
10174 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
10175
f3d4e0a4
CY
101762011-05-22 Chong Yidong <cyd@stupidchicken.com>
10177
10178 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
10179
4d8ade89
YM
101802011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10181
10182 * dispnew.c (scrolling_window): Don't exclude the case that the
10183 last enabled row in the desired matrix touches the bottom boundary.
10184
32078c8d
GM
101852011-05-21 Glenn Morris <rgm@gnu.org>
10186
10187 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
10188 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
10189 and add some more files.
32078c8d 10190
7285dc67
EZ
101912011-05-20 Eli Zaretskii <eliz@gnu.org>
10192
10193 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
10194 report_file_error introduced by the change from 2011-05-07.
10195
89d1bd22
PE
101962011-05-20 Paul Eggert <eggert@cs.ucla.edu>
10197
10198 * systime.h (Time): Define only if emacs is defined.
10199 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
10200 where the include path doesn't have X11/X.h by default. See
10201 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
10202
cd394be1 102032011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
10204
10205 * composite.c (find_automatic_composition): Fix previous change.
10206
b9704ad9
GM
102072011-05-20 Glenn Morris <rgm@gnu.org>
10208
10209 * lisp.mk: New file, split from Makefile.in.
10210 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
10211 (shortlisp): Remove.
10212 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
10213
4a720484
GM
102142011-05-19 Glenn Morris <rgm@gnu.org>
10215
10216 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
10217 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
10218 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
10219 (lisp): Set the order to that of loadup.el.
10220 (shortlisp): Make it a copy of $lisp.
10221 (SOME_MACHINE_LISP): Remove.
10222 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
10223 Use just $shortlisp, not $SOME_MACHINE_LISP too.
10224
a28d4396
KH
102252011-05-18 Kenichi Handa <handa@m17n.org>
10226
10227 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
10228 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
10229 (find_automatic_composition): Mostly rewrite for efficiency.
10230
a2b1fa8e
JB
102312011-05-18 Juanma Barranquero <lekktu@gmail.com>
10232
10233 * makefile.w32-in: Update dependencies.
10234
8e1f5610
CS
102352011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
10236
10237 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 10238 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 10239
7025ee00 102402011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 10241
cdfa6eab
PE
10242 Fix some integer overflow issues, such as string length overflow.
10243
06d6db33
PE
10244 * insdel.c (count_size_as_multibyte): Check for string overflow.
10245
2b4560a8
PE
10246 * character.c (lisp_string_width): Check for string overflow.
10247 Use EMACS_INT, not int, for string indexes and lengths; in
10248 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
10249 the resulting string length overflows an EMACS_INT; instead,
10250 report a string overflow if no precision given. When checking for
10251 precision exhaustion, use a check that cannot possibly have
10252 integer overflow. (Bug#8675)
10253 * character.h (lisp_string_width): Adjust to new signature.
10254
cb93f9be
PE
10255 * alloc.c (string_overflow): New function.
10256 (Fmake_string): Use it. This doesn't change behavior, but saves
10257 a few bytes and will simplify future changes.
10258 * character.c (string_escape_byte8): Likewise.
10259 * lisp.h (string_overflow): New decl.
10260
1a1f3366
PE
10261 Fixups, following up to the user-interface timestamp change.
10262 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
10263 for UI timestamps, instead of unsigned long.
9fbd6841
PE
10264 * msdos.c (mouse_get_pos): Likewise.
10265 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
10266 * w32gui.h (Time): Define by including "systime.h" rather than by
10267 declaring it ourselves. (Bug#8664)
10268
d4e3e4d3
PE
10269 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
10270 * image.c (clear_image_cache): Likewise.
10271
f6a24d19
PE
10272 * term.c (term_mouse_position): Don't assume time_t wraparound.
10273
08dc5ae6
PE
10274 Be more systematic about user-interface timestamps.
10275 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
10276 and sometimes 'EMACS_UINT', to represent these timestamps.
10277 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
10278 This makes the code easier to follow, and makes it easier to catch
10279 integer overflow bugs such as Bug#8664.
10280 * frame.c (Fmouse_position, Fmouse_pixel_position):
10281 Use Time, not unsigned long, for user-interface timestamps.
10282 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
10283 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
10284 * keyboard.h (last_event_timestamp): Likewise.
10285 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
10286 * menu.h (xmenu_show): Likewise.
10287 * term.c (term_mouse_position): Likewise.
10288 * termhooks.h (struct input_event.timestamp): Likewise.
10289 (struct terminal.mouse_position_hook): Likewise.
10290 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
10291 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
10292 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
10293 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
10294 what it was before.
10295 * menu.h, termhooks.h: Include "systime.h", for Time.
10296
8e55734a
PE
10297 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
10298 Don't assume that the difference between two unsigned long values
10299 can fit into an integer. At this point, we know button_down_time
10300 <= event->timestamp, so the difference must be nonnegative, so
10301 there's no need to cast the result if double-click-time is
10302 nonnegative, as it should be; check that it's nonnegative, just in
10303 case. This bug is triggered when events are more than 2**31 ms
86db42d2 10304 apart (about 25 days). (Bug#8664)
8e55734a 10305
841f1b75 10306 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 10307 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 10308
3e26f69c
PE
10309 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
10310 that always fit in int. Use a sentinel instead of a counter, to
10311 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
10312 * frame.h (struct frame): Use int for menu_bar_items_used
10313 instead of EMACS_INT, since it always fits in int.
3e26f69c 10314
5cc152c0
PE
10315 * menu.c (grow_menu_items): Check for int overflow.
10316
d89eb65e
PE
10317 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
10318
5235bd3e
PE
10319 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
10320 Before, the code was not consistent. These values cannot exceed
10321 2**31 - 1 so there's no need to make them unsigned.
10322 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
10323 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
10324 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
10325 as modifiers.
10326 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
10327
bc827e23
PE
10328 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
10329 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
10330 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
10331 presumably because the widths might not match.
10332
78eb494e
PE
10333 * window.c (size_window): Avoid needless test at loop start.
10334
04f2d78b
CB
103352011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
10336
10337 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
10338
d2fc7e3d 103392011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
10340
10341 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
10342
d2fc7e3d 103432011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
10344
10345 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
10346 `width' to `bar_area_x' and `bar_area_width', respectively.
10347 (x_scroll_run): Take account of fringe background extension.
10348
04f2d78b
CB
10349 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
10350 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
10351 `bar_area_width', respectively.
10352 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
10353 background extension.
10354
79b70037
GM
103552011-05-10 Jim Meyering <meyering@redhat.com>
10356
10357 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
10358
2f142cc5
JB
103592011-05-10 Juanma Barranquero <lekktu@gmail.com>
10360
10361 * image.c (Finit_image_library): Return t for built-in image types,
10362 like pbm and xbm. (Bug#8640)
10363
57679c86
AS
103642011-05-09 Andreas Schwab <schwab@linux-m68k.org>
10365
10366 * w32menu.c (set_frame_menubar): Fix submenu allocation.
10367
888c9e86
EZ
103682011-05-07 Eli Zaretskii <eliz@gnu.org>
10369
b0512a1d
EZ
10370 * w32console.c (Fset_screen_color): Doc fix.
10371 (Fget_screen_color): New function.
10372 (syms_of_ntterm): Defsubr it.
10373
7285dc67
EZ
10374 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
10375 unlink the temporary file if Fcall_process didn't create it in the
10376 first place.
10377 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
10378 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
10379 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
10380 cue to call_process_cleanup not to close that handle.
10381
4d3fcc8e
BK
103822011-05-07 Ben Key <bkey76@gmail.com>
10383
10384 * makefile.w32-in: The bootstrap-temacs rule now makes use of
10385 one of two shell specific rules, either bootstrap-temacs-CMD or
10386 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
10387 to the previous implementation of the bootstrap-temacs rule.
10388 The bootstrap-temacs-CMD rule is similar to the previous
10389 implementation of the bootstrap-temacs rule except that it
10390 makes use of the ESC_CFLAGS variable instead of the CFLAGS
10391 variable.
10392
10393 These changes, along with some changes to nt/configure.bat,
10394 nt/gmake.defs, and nt/nmake.defs, are required to extend my
10395 earlier fix to add support for --cflags and --ldflags options
10396 that include quotes so that it works whether make uses cmd or
10397 sh as the shell.
10398
b4289b64
MA
103992011-05-06 Michael Albinus <michael.albinus@gmx.de>
10400
10401 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
10402 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
10403 is a constant.
10404 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
10405 a string. Handle both cases.
10406 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
10407 (Fdbus_register_method): Use Qinvalid_function.
10408
af4c0e28
JB
104092011-05-06 Juanma Barranquero <lekktu@gmail.com>
10410
10411 * makefile.w32-in: Update dependencies.
10412 (LISP_H): Add inttypes.h and stdin.h.
10413 (PROCESS_H): Add unistd.h.
10414
c51453d9
EZ
104152011-05-06 Eli Zaretskii <eliz@gnu.org>
10416
10417 * lread.c: Include limits.h (fixes the MS-Windows build broken by
10418 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
10419
8ff0ac3c 104202011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 10421
4c4b566b
PE
10422 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
10423
aab2b9b5
PE
10424 * term.c (vfatal): Remove stray call to va_end.
10425 It's not needed and the C Standard doesn't allow it here anyway.
10426
c378da0b
PE
10427 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
10428 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
10429
288b08c7
PE
10430 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
10431 bytes.
10432
e3601888
PE
10433 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
10434
db6c0e74
PE
10435 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
10436
dd5963ea
PE
10437 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
10438
88c9450f
PE
10439 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
10440
2f9442b8
PE
10441 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
10442
c032b5f8
PE
10443 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
10444 * charset.c (Fdefine_charset_internal): Don't initialize
10445 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 10446 32-bit int (Bug#8600).
a108c10b
PE
10447
10448 * lread.c (read_integer): Be more consistent with string-to-number.
10449 Use string_to_number to do the actual conversion; this avoids
10450 rounding errors and fixes some other screwups. Without this fix,
10451 for example, #x1fffffffffffffff was misread as -2305843009213693952.
10452 (digit_to_number): Move earlier, for benefit of read_integer.
10453 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 10454 not a digit in any supported base. (Bug#8602)
a108c10b 10455
ad5f9eea
PE
10456 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
10457
aec1708a
PE
10458 * dispnew.c (scrolling_window): Return 1 if we scrolled,
10459 to match comment at start of function. This also removes a
10460 GCC warning about overflow in a 32+64-bit port.
10461
47be4ab5
PE
10462 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
10463
371cac43
PE
10464 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
10465 Reported by Stefan Monnier in
10466 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
10467 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10468 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 10469
d01a7826
PE
10470 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
10471 (EMACS_UINTPTR): Likewise, with uintptr_t.
10472
7fd47d5c
PE
10473 * lisp.h: Prefer 64-bit EMACS_INT if available.
10474 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
10475 on 32-bit hosts that have 64-bit int, so that they can access
10476 large files.
122b0c86
PE
10477 However, temporarily disable this change unless the temporary
10478 symbol WIDE_EMACS_INT is defined.
7fd47d5c 10479
8727937b
PE
10480 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
10481
8ac068ac
PE
10482 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
10483 This removes an assumption that EMACS_INT and long are the same
10484 width as pointers. The assumption is true for Emacs porting targets
10485 now, but we want to make other targets possible.
10486 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
10487 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
10488 In the rest of the code, change types of integers that hold casted
10489 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
10490 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
10491 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
10492 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
10493 No need to cast type when ORing.
10494 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
10495 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
10496 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
10497 assume EMACS_INT is the same width as char *.
10498 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
10499 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
10500 Remove no-longer-needed casts.
10501 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
10502 (xg_tool_bar_help_callback, xg_make_tool_item):
10503 Use EMACS_INTPTR to hold an integer
10504 that will be cast to void *; this can avoid a GCC warning
10505 if EMACS_INT is not the same width as void *.
10506 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
10507 * xdisp.c (display_echo_area_1, resize_mini_window_1):
10508 (current_message_1, set_message_1):
10509 Use a local to convert to proper width without a cast.
10510 * xmenu.c (dialog_selection_callback): Likewise.
10511
ede49d71
PE
10512 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
10513 Also, don't assume VALBITS / RAND_BITS is less than 5,
10514 and don't rely on undefined behavior when shifting a 1 left into
10515 the sign bit.
10516 * lisp.h (get_random): Change signature to match.
10517
2f30ecd0
PE
10518 * lread.c (hash_string): Use size_t, not int, for hash computation.
10519 Normally we prefer signed values; but hashing is special, because
10520 it's better to use unsigned division on hash table sizes so that
10521 the remainder is nonnegative. Also, size_t is the natural width
10522 for hashing into memory. The previous code used 'int', which doesn't
10523 retain enough info to hash well into very large tables.
10524 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
10525
2a866e7b
PE
10526 * dbusbind.c: Don't possibly lose pointer info when converting.
10527 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10528 Use XPNTR rather than XHASH, so that the high-order bits of
10529 the pointer aren't lost when converting through void *.
10530
51639eac
PE
10531 * eval.c (Fautoload): Don't double-shift a pointer.
10532
92394119
PE
10533 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
10534
dbdb9a7c
JB
105352011-05-06 Juanma Barranquero <lekktu@gmail.com>
10536
10537 * gnutls.c (DEF_GNUTLS_FN):
10538 * image.c (DEF_IMGLIB_FN): Make function pointers static.
10539
db7a0b4f
AS
105402011-05-05 Andreas Schwab <schwab@linux-m68k.org>
10541
10542 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
10543 marker. (Bug#8610)
10544
cd394be1 105452011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
10546
10547 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
10548 New version that can reserve upto 2GB of heap space.
10549
f7ff1b0f 105502011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
10551
10552 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
10553
639c109b
TZ
105542011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
10555
10556 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
10557 `gnutls_certificate_set_x509_key_file'.
10558
d2127135
JB
105592011-05-05 Juanma Barranquero <lekktu@gmail.com>
10560
10561 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
10562 Update dependencies.
10563
e968f4f3
JB
105642011-05-04 Juanma Barranquero <lekktu@gmail.com>
10565
10566 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
10567 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
10568 Remove unused parameter `fildes'.
10569 * process.c (read_process_output, send_process): Don't pass it.
10570
84d358f0
JB
105712011-05-04 Juanma Barranquero <lekktu@gmail.com>
10572
10573 Fix previous change: the library cache is defined in w32.c.
10574 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
10575 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
10576
0898ca10
JB
105772011-05-04 Juanma Barranquero <lekktu@gmail.com>
10578
10579 Implement dynamic loading of GnuTLS on Windows.
10580
10581 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
10582 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
10583 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10584 Declare.
10585
10586 * gnutls.c (Qgnutls_dll): Define.
10587 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
10588 (gnutls_*): Declare function pointers.
10589 (init_gnutls_functions): New function to initialize function pointers.
10590 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
10591 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
10592 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10593 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
10594 (emacs_gnutls_write, emacs_gnutls_read)
10595 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
10596 (Fgnutls_available_p): New function.
10597 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
10598 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
10599 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
10600
10601 * image.c: Include w32.h.
10602 (Vimage_type_cache): Delete.
10603 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
10604 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
10605 (w32_delayed_load): Move to w32.c.
10606
10607 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
10608
10609 * w32.c (QCloaded_from, Vlibrary_cache): Define.
10610 (w32_delayed_load): Move from image.c. When loading a library, record
10611 its filename in the :loaded-from property of the library id.
10612 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
10613 Initialize and staticpro them.
10614 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
10615
10616 * process.c: Include lisp.h before w32.h, not after.
10617 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
10618 instead of gnutls_record_check_pending.
10619
10620 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
10621
ff4de4aa
TZ
106222011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
10623
10624 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
10625 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
10626 as passed in.
10627
abe95abb
JD
106282011-05-03 Jan Djärv <jan.h.d@swipnet.se>
10629
10630 * xterm.c (x_set_frame_alpha): Do not set property on anything
10631 else than FRAME_X_OUTER_WINDOW (Bug#8608).
10632
e16e55d4
JB
106332011-05-02 Juanma Barranquero <lekktu@gmail.com>
10634
10635 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
10636
bafcf6a5
JB
106372011-05-02 Juanma Barranquero <lekktu@gmail.com>
10638
10639 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
10640 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
10641 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
10642 (gnutls_global_initialized, Qgnutls_bootprop_priority)
10643 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
10644 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
10645 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
10646 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
10647 (Qgnutls_bootprop_callbacks_verify): Make static.
10648
e7a6747f
AS
106492011-05-01 Andreas Schwab <schwab@linux-m68k.org>
10650
19ed11ba
AS
10651 * callproc.c: Indentation fixup.
10652
e7a6747f 10653 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
10654 (wait_for_termination, interruptible_wait_for_termination):
10655 Move after wait_for_termination_1.
e7a6747f 10656
1ef14cb4
LMI
106572011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
10658
10659 * sysdep.c (interruptible_wait_for_termination): New function
10660 which is like wait_for_termination, but allows keyboard
10661 interruptions.
10662
10663 * callproc.c (Fcall_process): Add (:file "file") as an option for
10664 the STDOUT buffer.
10665 (Fcall_process_region): Ditto.
10666
330d880c
EZ
106672011-04-30 Eli Zaretskii <eliz@gnu.org>
10668
8db90b73
EZ
10669 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
10670 rather than `XVECTOR (FOO)->size'.
10671
330d880c
EZ
10672 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
10673 inttypes.h, as a gnulib replacement is used if it not available in
10674 system headers.
10675
15cbd324
EZ
106762011-04-21 Eli Zaretskii <eliz@gnu.org>
10677
10678 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
10679 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
10680 of MOST_POSITIVE_FIXNUM. (Bug#8528)
10681
10682 * coding.c (coding_alloc_by_realloc): Error out if destination
10683 will grow beyond MOST_POSITIVE_FIXNUM.
10684 (decode_coding_emacs_mule): Abort if there isn't enough place in
10685 charbuf for the composition carryover bytes. Reserve an extra
10686 space for up to 2 characters produced in a loop.
10687 (decode_coding_iso_2022): Abort if there isn't enough place in
10688 charbuf for the composition carryover bytes.
10689
106902011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 10691
ae940cca
EZ
10692 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
10693 aborting when %lld or %lll format is passed.
10694 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
10695 %llo or %llx format is passed. (Bug#8545)
10696
03ab8921
EZ
10697 * window.c (window_scroll_line_based): Use a marker instead of
10698 simple variables to record original value of point. (Bug#7952)
10699
afda1437
EZ
10700 * doprnt.c (doprnt): Fix the case where a multibyte sequence
10701 produced by %s or %c overflows available buffer space. (Bug#8545)
10702
f76dee0c
PE
107032011-04-28 Paul Eggert <eggert@cs.ucla.edu>
10704
10705 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 10706 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 10707
fdc5744d
JB
107082011-04-28 Juanma Barranquero <lekktu@gmail.com>
10709
10710 * w32.c (init_environment): Warn about defaulting HOME to C:\.
10711
638f053a
JB
107122011-04-28 Juanma Barranquero <lekktu@gmail.com>
10713
10714 * keyboard.c (Qdelayed_warnings_hook): Define.
10715 (command_loop_1): Run `delayed-warnings-hook'
10716 if Vdelayed_warnings_list is non-nil.
10717 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
10718 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
10719
d178f871
EZ
107202011-04-28 Eli Zaretskii <eliz@gnu.org>
10721
10722 * doprnt.c (doprnt): Don't return value smaller than the buffer
10723 size if the message was truncated. (Bug#8545).
10724
b124fd93
JB
107252011-04-28 Juanma Barranquero <lekktu@gmail.com>
10726
10727 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
10728 (Fx_window_property): #if-0 the whole functions, not just the bodies.
10729
e810457d
PE
107302011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10731
10732 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
10733
ea51cceb
JB
107342011-04-27 Juanma Barranquero <lekktu@gmail.com>
10735
10736 * makefile.w32-in: Update dependencies.
10737
94dcfacf
EZ
107382011-04-27 Eli Zaretskii <eliz@gnu.org>
10739
10740 Improve `doprnt' and its usage. (Bug#8545)
10741 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
10742 `format_end'. Remove support for %l as a conversion specifier.
10743 Don't use xrealloc. Improve diagnostics when the %l size modifier
10744 is used. Update the commentary.
10745
10746 * eval.c (verror): Simplify calculation of size_t.
10747
10748 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
10749 messages.
10750
f61f41d7
PE
107512011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
10752
10753 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
10754 change.
10755
96fb4434
PE
107562011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10757
10758 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
10759 This makes this file independent of the recent pseudovector change.
10760
671875da 107612011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 10762
69e9b5a3
PE
10763 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
10764
b5f869a7 10765 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 10766 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 10767 Remove unused local.
c8926152 10768 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 10769
841a1577 10770 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
10771 GCC 4.6.0 optimizes based on type-based alias analysis.
10772 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
10773 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
10774 != &v->size, and therefore "v->size = 1; b->size = 2; return
10775 v->size;" must therefore return 1. This assumption is incorrect
10776 for Emacs, since it type-puns struct Lisp_Vector * with many other
10777 types. To fix this problem, this patch adds a new type struct
f904488f 10778 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
10779 and pseudovectors, and helps optimizing compilers not get fooled
10780 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
10781 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
10782 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
10783 the size member.
eab3844f
PE
10784 (XSETPVECTYPE): Rewrite in terms of new macro.
10785 (XSETPVECTYPESIZE): New macro, specifying both type and size.
10786 This is a bit clearer, and further avoids the possibility of
10787 undesirable aliasing.
10788 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 10789 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
10790 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
10791 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
10792 (ASIZE): Now uses header.size rather than size.
10793 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
10794 to avoid the hassle of writing XVECTOR (foo)->header.size.
10795 (struct vectorlike_header): New type.
eab3844f
PE
10796 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
10797 object, to help avoid aliasing.
10798 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
10799 (SUBRP): Likewise, since Lisp_Subr is a special case.
10800 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
10801 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
10802 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 10803 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
10804 changed to be "header.size" and "header.next".
10805 * buffer.h (struct buffer): Likewise.
10806 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
10807 * frame.h (struct frame): Likewise.
10808 * process.h (struct Lisp_Process): Likewise.
10809 * termhooks.h (struct terminal): Likewise.
10810 * window.c (struct save_window_data, struct saved_window): Likewise.
10811 * window.h (struct window): Likewise.
10812 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
10813 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
10814 * buffer.c (init_buffer_once): Likewise.
10815 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
10816 special case.
10817 * process.c (Fformat_network_address): Use local var for size,
10818 for brevity.
10819
0df1eac5
PE
10820 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
10821
847ab9d1 10822 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
10823 * data.c (atof): Remove decl; no longer used or needed.
10824 (digit_to_number): Move to lread.c.
10825 (Fstring_to_number): Use new string_to_number function, to be
10826 consistent with how the Lisp reader treats infinities and NaNs.
10827 Do not assume that floating-point numbers represent EMACS_INT
10828 without losing information; this is not true on most 64-bit hosts.
10829 Avoid double-rounding errors, by insisting on integers when
10830 parsing non-base-10 numbers, as the documentation specifies.
10831 * lisp.h (string_to_number): New decl, replacing ...
10832 (isfloat_string): Remove.
bc0a5c13 10833 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 10834 (read1): Do not accept +. and -. as integers; this
452f4150
PE
10835 appears to have been a coding error. Similarly, do not accept
10836 strings like +-1e0 as floating point numbers. Do not report
10837 overflow for integer overflows unless the base is not 10 which
10838 means we have no simple and reliable way to continue.
10839 Break out the floating-point parsing into a new
10840 function string_to_number, so that Fstring_to_number parses
10841 floating point numbers consistently with the Lisp reader.
04f2d78b 10842 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
10843 (E_CHAR, EXP_INT): Remove, replacing with ...
10844 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
10845 (string_to_number): New function, replacing isfloat_string.
10846 This function checks for valid syntax and produces the resulting
10847 Lisp float number too. Rework it so that string-to-number
bc0a5c13 10848 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
10849 so that overflow for non-base-10 numbers is reported only when
10850 there's no portable and simple way to convert to floating point.
452f4150 10851
67769ffc
PE
10852 * textprop.c (set_text_properties_1): Rewrite for clarity,
10853 and to avoid GCC warning about integer overflow.
10854
c20db43f
PE
10855 * intervals.h (struct interval): Use EMACS_INT for members
10856 where EMACS_UINT might cause problems. See
10857 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
10858 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
10859 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
10860 All uses changed.
37aa2f85
PE
10861 (offset_intervals): Tell GCC not to worry about length overflow
10862 when negating a negative length.
c20db43f 10863
2538aa2f
PE
10864 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
10865 (overrun_check_free): Likewise.
10866
f2d3008d
PE
10867 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
10868 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
10869 word size.
10870
ec8df744
PE
10871 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10872 (gnutls_make_error): Rename local to avoid shadowing.
10873 (gnutls_emacs_global_deinit): ifdef out; not used.
10874 (Fgnutls_boot): Use const for pointer to readonly storage.
10875 Comment out unused local. Fix pointer signedness problems.
10876
640ee02d
PE
10877 * lread.c (openp): Don't stuff size_t into an 'int'.
10878 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
10879 about possible signed overflow.
10880
6048fb2a
PE
10881 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10882 (GDK_KEY_g): Don't define if already defined.
10883 (xg_prepare_tooltip): Avoid pointer signedness problem.
10884 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
10885
fa3c87e1
PE
10886 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
10887 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
10888
2172544b
PE
10889 * xfns.c (Fx_window_property): Simplify a bit,
10890 to make a bit faster and to avoid GCC 4.6.0 warning.
10891 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
10892
9b821a21
PE
10893 * fns.c (internal_equal): Don't assume size_t fits in int.
10894
3c616cfa
PE
10895 * alloc.c (compact_small_strings): Tighten assertion a little.
10896
c2982e87
PE
10897 Replace pEd with more-general pI, and fix some printf arg casts.
10898 * lisp.h (pI): New macro, generalizing old pEd macro to other
10899 conversion specifiers. For example, use "...%"pI"d..." rather
10900 than "...%"pEd"...".
10901 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 10902 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
10903 * alloc.c (check_pure_size): Don't overflow by converting size to int.
10904 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
10905 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
10906 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
10907 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
10908 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
10909 64-bit hosts.
10910 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
10911 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
10912 * print.c (safe_debug_print, print_object): Likewise.
10913 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
10914 to int.
6f04d126
PE
10915 Use pI instead of if-then-else-abort. Use %p to avoid casts,
10916 avoiding the 0 flag, which is not portable.
c2982e87
PE
10917 * process.c (Fmake_network_process): Use pI to avoid cast.
10918 * region-cache.c (pp_cache): Likewise.
10919 * xdisp.c (decode_mode_spec): Likewise.
10920 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
10921 behavior on 64-bit hosts with printf arg.
6f04d126 10922 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
10923 (x_stop_queuing_selection_requests): Likewise.
10924 (x_get_window_property): Don't truncate byte count to an 'int'
10925 when tracing.
0b432f21 10926
5e073ec7
PE
10927 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
10928 here, since it parses constructs like leading '-' and spaces,
10929 which are not wanted; and it overflows with large numbers.
10930 Instead, simply match F[0-9]+, which is what is wanted anyway.
10931
36372bf9
PE
10932 * alloc.c: Remove unportable assumptions about struct layout.
10933 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
10934 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
10935 (allocate_vectorlike, make_pure_vector): Use the new macros,
10936 plus offsetof, to remove unportable assumptions about struct layout.
10937 These assumptions hold on all porting targets that I know of, but
10938 they are not guaranteed, they're easy to remove, and removing them
10939 makes further changes easier.
10940
0b432f21
PE
10941 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
10942 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
10943 (string_overrun_cookie): Now const. Use initializers that
10944 don't formally overflow signed char, to avoid warnings.
000098c1
PE
10945 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
10946 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
10947 (allocate_buffer): Don't assume sizeof (struct buffer) is a
10948 multiple of sizeof (EMACS_INT); it need not be, if
10949 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 10950 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 10951
895009e1
JB
109522011-04-26 Juanma Barranquero <lekktu@gmail.com>
10953
10954 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
10955
6a7a1b0b
TZ
109562011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
10957
10958 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 10959 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
10960 Reported by Paul Eggert <eggert@cs.ucla.edu>.
10961
841a1577 109622011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
10963
10964 * lisp.h (Qdebug): List symbol.
895009e1 10965 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
10966 * keyboard.c (debug-on-event): New variable.
10967 (handle_user_signal): Break into debugger when debug-on-event
10968 matches the current signal symbol.
10969
f2d3ba6f
DN
109702011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
10971
10972 * alloc.c (check_sblock, check_string_bytes)
10973 (check_string_free_list): Convert to standard C.
10974
42ce4c63
TZ
109752011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
10976
10977 * w32.c (emacs_gnutls_push): Fix typo.
10978
825cd63c
EZ
109792011-04-25 Eli Zaretskii <eliz@gnu.org>
10980
fb11d64d
EZ
10981 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
10982 "cast to pointer from integer of different size".
10983
825cd63c
EZ
10984 Improve doprnt and its use in verror. (Bug#8545)
10985 * doprnt.c (doprnt): Document the set of format control sequences
10986 supported by the function. Use SAFE_ALLOCA instead of always
10987 using `alloca'.
10988
10989 * eval.c (verror): Don't limit the buffer size at size_max-1, that
10990 is one byte too soon. Don't use xrealloc; instead xfree and
10991 xmalloc anew.
10992
e061a11b
TZ
109932011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
10994
10995 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
10996 callbacks stage.
10997
10998 * gnutls.c: Renamed global_initialized to
10999 gnutls_global_initialized. Added internals for the
11000 :verify-hostname-error, :verify-error, and :verify-flags
11001 parameters of `gnutls-boot' and documented those parameters in the
11002 docstring. Start callback support.
9173deec
JB
11003 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
11004 unless a fatal error occurred. Call gnutls_alert_send_appropriate
11005 on error. Return error code.
e061a11b
TZ
11006 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
11007 (emacs_gnutls_read): Likewise.
11008 (Fgnutls_boot): Return handshake error code.
11009 (emacs_gnutls_handle_error): New function.
11010 (wsaerror_to_errno): Likewise.
11011
11012 * w32.h (emacs_gnutls_pull): Add prototype.
11013 (emacs_gnutls_push): Likewise.
11014
11015 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
11016 (emacs_gnutls_push): Likewise.
11017
110182011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
11019
11020 * process.c (wait_reading_process_output): Check if GnuTLS
11021 buffered some data internally if no FDs are set for TLS
11022 connections.
11023
11024 * makefile.w32-in (OBJ2): Add gnutls.$(O).
11025 (LIBS): Link to USER_LIBS.
11026 ($(BLD)/gnutls.$(0)): New target.
11027
fa6996bc
EZ
110282011-04-24 Eli Zaretskii <eliz@gnu.org>
11029
eb35682e
EZ
11030 * xdisp.c (handle_single_display_spec): Rename the
11031 display_replaced_before_p argument into display_replaced_p, to
11032 make it consistent with the commentary. Fix typos in the
11033 commentary.
11034
e2ad650c
EZ
11035 * textprop.c (syms_of_textprop): Remove dead code.
11036 (copy_text_properties): Delete obsolete commentary about an
11037 interface that was deleted long ago. Fix typos in the description
11038 of arguments.
11039
1b2de274
EZ
11040 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
11041 to changes in oldXMenu/XMenu.h from 2011-04-16.
11042 <menu_help_message, prev_menu_help_message>: Constify.
11043 (IT_menu_make_room): menu->help_text is now `const char **';
11044 adjust.
11045
11046 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
11047 to changes in oldXMenu/XMenu.h from 2011-04-16.
11048 (struct XMenu): Declare `help_text' `const char **'.
11049
11050 * xfaces.c <Qunspecified>: Make extern again.
11051
11052 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 11053 required by POSIX.
1b2de274 11054
762b15be
EZ
11055 * doc.c (get_doc_string): Improve the format passed to `error'.
11056
11057 * doprnt.c (doprnt): Improve commentary.
11058
11059 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
11060
11061 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
11062 them with etags.
11063
f1052e5d
EZ
11064 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
11065 changes in globals.h immediately force recompilation.
762b15be
EZ
11066 (TAGS): Depend on $(CURDIR)/m/intel386.h and
11067 $(CURDIR)/s/ms-w32.h.
11068 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 11069
fa6996bc
EZ
11070 * character.c (Fchar_direction): Function deleted.
11071 (syms_of_character): Don't defsubr it.
11072 <char-direction-table>: Deleted.
11073
e6c3da20
EZ
110742011-04-23 Eli Zaretskii <eliz@gnu.org>
11075
11076 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
11077 * doprnt.c: Include limits.h.
11078 (SIZE_MAX): New macro.
04f2d78b
CB
11079 (doprnt): Return a size_t value. 2nd arg is now size_t.
11080 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
11081 Improve overflow protection. Support `l' modifier for integer
11082 conversions. Support %l conversion. Don't assume an EMACS_INT
11083 argument for integer conversions and for %c.
11084
11085 * lisp.h (doprnt): Restore prototype.
11086
11087 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
11088 $(SRC)/character.h.
11089
11090 * Makefile.in (base_obj): Add back doprnt.o.
11091
11092 * deps.mk (doprnt.o): Add back prerequisites.
11093 (callint.o): Depend on character.h.
11094
11095 * eval.c (internal_lisp_condition_case): Include the handler
11096 representation in the error message.
11097 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
11098 when breaking from the loop.
11099
11100 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
11101
11102 * callint.c (Fcall_interactively): When displaying error message
11103 about invalid control letter, pass the character's codepoint, not
11104 a pointer to its multibyte form. Improve display of the character
11105 in octal and display also its hex code.
11106
11107 * character.c (char_string): Use %x to display the (unsigned)
11108 codepoint of an invalid character, to avoid displaying a bogus
11109 negative value.
11110
11111 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
11112 `error', not SYMBOL_NAME itself.
11113
11114 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
11115 character arguments to `error'.
11116
11117 * charset.c (check_iso_charset_parameter): Fix incorrect argument
11118 to `error' in error message about FINAL_CHAR argument. Make sure
11119 FINAL_CHAR is a character, and use %c when it is passed as
11120 argument to `error'.
11121
4ffd0d6b 111222011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
11123
11124 * s/ms-w32.h (localtime): Redirect to sys_localtime.
11125
11126 * w32.c: Include <time.h>.
11127 (sys_localtime): New function.
11128
4ffd0d6b 111292011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
11130
11131 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
11132
4ffd0d6b 11133 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 11134
4ffd0d6b 111352011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 11136
4ffd0d6b
GM
11137 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
11138 zombies (Bug#8467).
aac0c6e3 11139
04c56954
EZ
111402011-04-19 Eli Zaretskii <eliz@gnu.org>
11141
11142 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
11143 gl_state.e_property when gl_state.object is Qt.
11144
11145 * insdel.c (make_gap_larger): Remove limitation of buffer size
11146 to <= INT_MAX.
11147
16a43933
CY
111482011-04-18 Chong Yidong <cyd@stupidchicken.com>
11149
11150 * xdisp.c (lookup_glyphless_char_display)
11151 (produce_glyphless_glyph): Handle cons cell entry in
11152 glyphless-char-display.
11153 (Vglyphless_char_display): Document it.
11154
11155 * term.c (produce_glyphless_glyph): Handle cons cell entry in
11156 glyphless-char-display.
11157
4581706e
CY
111582011-04-17 Chong Yidong <cyd@stupidchicken.com>
11159
11160 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
11161
11162 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
11163
11164 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
11165 definition for no-X builds.
11166
4887c6e2 111672011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 11168
fd35b6f9
PE
11169 Static checks with GCC 4.6.0 and non-default toolkits.
11170
5c1ccb01
PE
11171 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
11172
006c5daa
PE
11173 * process.c (keyboard_bit_set): Define only if SIGIO.
11174 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
11175 (send_process): Repair possible setjmp clobbering.
11176
efc736d3
PE
11177 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
11178
4e2fe2e6
PE
11179 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
11180
f97334a2
PE
11181 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
11182
4e75f29d
PE
11183 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
11184 Define only if needed.
11185
90efadd1
PE
11186 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
11187 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 11188 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 11189
3c647824
PE
11190 * dispextern.h (struct redisplay_interface): Rename param
11191 to avoid shadowing.
e264f262 11192 * termhooks.h (struct terminal): Likewise.
761383f4 11193 * xterm.c (xembed_send_message): Likewise.
3c647824 11194
b58c5c4a
PE
11195 * insdel.c (make_gap_smaller): Define only if
11196 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
11197
cad59032
PE
11198 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
11199 it.
11200
c339dc2e
PE
11201 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
11202 so that we aren't warned about unused symbols.
11203
91a3e27b
PE
11204 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
11205
399c71d3 11206 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 11207
8ffc96f5
PE
11208 * xfns.c (x_real_positions): Mark locals as initialized.
11209
eef9bc79
PE
11210 * xmenu.c (xmenu_show): Don't use uninitialized vars.
11211
098db9dd
PE
11212 * xterm.c: Fix problems found by static analysis with other toolkits.
11213 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
11214 (x_dispatch_event): Declare static if USE_GTK, and
11215 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 11216 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 11217 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
11218 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
11219 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 11220
eb18f6cc
PE
11221 * xmenu.c (menu_help_callback): Pointer type fixes.
11222 Use const pointers when pointing at readonly data. Avoid pointer
11223 signedness clashes.
11224 (FALSE): Remove unused macro.
11225 (update_frame_menubar): Remove unused decl.
11226
1fe72bf8
PE
11227 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
11228
60d9e1db
PE
11229 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
11230 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
11231 (single_menu_item): Rename local to avoid shadowing.
11232
39261c26
PE
11233 * keyboard.c (make_lispy_event): Remove unused local var.
11234
018c5e19
PE
11235 * frame.c, frame.h (x_get_resource_string): Bring this back, but
11236 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
11237
63d2b86e
PE
11238 * bitmaps: Change bitmaps from unsigned char back to the X11
11239 compatible char. Avoid the old compiler warnings about
11240 out-of-range initializers by using, for example, '\xab' rather
11241 than 0xab.
11242
aefd87e1
PE
11243 * xgselect.c (xgselect_initialize): Check vs interface
11244 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
11245
bf501fb9
PE
11246 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
11247
e9829fdf
PE
11248 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
11249 to read-only memory.
11250
1086c095
PE
11251 * fns.c (vector): Remove; this old hack is no longer needed.
11252
2baccd04 11253 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 11254 Remove unused var.
dde42981 11255 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 11256
72391843 11257 * xrdb.c (x_load_resources): Omit unused local.
3565b346 11258
436c16df 11259 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 11260 (x_window): Rename locals to avoid shadowing.
dc5ddd85 11261 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 11262
92bb796d 11263 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 11264 (x_term_init): Remove local to avoid shadowing.
92bb796d 11265
764430a3 11266 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
11267
11268 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
11269 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
11270
d1dfb56c
EZ
112712011-04-16 Eli Zaretskii <eliz@gnu.org>
11272
c4354cb4
EZ
11273 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
11274
d1dfb56c
EZ
11275 Fix regex.c, syntax.c and friends for buffers > 2GB.
11276 * syntax.h (struct gl_state_s): Declare character position members
11277 EMACS_INT.
11278
11279 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
11280
04f2d78b
CB
11281 * textprop.c (verify_interval_modification, interval_of):
11282 Declare arguments EMACS_INT.
d1dfb56c
EZ
11283
11284 * intervals.c (adjust_intervals_for_insertion): Declare arguments
11285 EMACS_INT.
11286
11287 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
11288
11289 * indent.c (Fvertical_motion): Local variable it_start is now
11290 EMACS_INT.
11291
11292 * regex.c (re_match, re_match_2, re_match_2_internal)
11293 (bcmp_translate, regcomp, regexec, print_double_string)
11294 (group_in_compile_stack, re_search, re_search_2, regex_compile)
11295 (re_compile_pattern, re_exec): Declare arguments and local
11296 variables `size_t' and `ssize_t' and return values `regoff_t', as
11297 appropriate.
11298 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
11299 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
11300 <compile_stack_type>: `size' and `avail' are now `size_t'.
11301
11302 * regex.h <regoff_t>: Use ssize_t, not int.
11303 (re_search, re_search_2, re_match, re_match_2): Arguments that
11304 specify buffer/string position and length are now ssize_t and
11305 size_t. Return type is regoff_t.
11306
613052cd
BK
113072011-04-16 Ben Key <bkey76@gmail.com>
11308
11309 * nsfont.m: Fixed bugs in ns_get_family and
11310 ns_descriptor_to_entity that were caused by using free to
11311 deallocate memory blocks that were allocated by xmalloc (via
11312 xstrdup). This caused Emacs to crash when compiled with
11313 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
11314 --enable-checking=xmallocoverrun). xfree is now used to
11315 deallocate these memory blocks.
11316
4170f62f 113172011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 11318
71b41406
PE
11319 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
11320
9587a89d
PE
11321 emacs_write: Accept and return EMACS_INT for sizes.
11322 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
11323 et seq.
11324 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
11325 Accept and return EMACS_INT.
11326 (emacs_gnutls_write): Return the number of bytes written on
11327 partial writes.
11328 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
11329 (emacs_read, emacs_write): Remove check for negative size, as the
11330 Emacs source code has been audited now.
9587a89d
PE
11331 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
11332 (emacs_read, emacs_write): Use it.
273a5f82
PE
11333 * process.c (send_process): Adjust to the new signatures of
11334 emacs_write and emacs_gnutls_write. Do not attempt to store
11335 a byte offset into an 'int'; it might overflow.
9587a89d 11336 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 11337
3e047f51
PE
11338 * sound.c: Don't assume sizes fit in 'int'.
11339 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 11340 Return EMACS_INT, not int.
3e047f51 11341 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
11342 Accept EMACS_INT, not int.
11343 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
11344 record read return values.
11345
cc39a9db
BK
113462011-04-15 Ben Key <bkey76@gmail.com>
11347
c9d0ec6d
JB
11348 * keyboard.c (Qundefined): Don't declare static since it is used
11349 in nsfns.m.
11350 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
11351 static since they are used in nsfont.m.
cc39a9db 11352
6c60eb9f
SM
113532011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
11354
11355 * process.c (Qprocessp): Don't declare static.
11356 * lisp.h (Qprocessp): Declare again.
11357
7990b61a
JB
113582011-04-15 Juanma Barranquero <lekktu@gmail.com>
11359
11360 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
11361
5d4cb038
PE
113622011-04-14 Paul Eggert <eggert@cs.ucla.edu>
11363
8bd7b830 11364 Improve C-level modularity by making more things 'static'.
cd64ea1d 11365
e3b27b31
PE
11366 Don't publish debugger-only interfaces to other modules.
11367 * lisp.h (safe_debug_print, debug_output_compilation_hack):
11368 (verify_bytepos, count_markers): Move decls to the only modules
11369 that need them.
11370 * region-cache.h (pp_cache): Likewise.
11371 * window.h (check_all_windows): Likewise.
11372 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
11373
5d4cb038
PE
11374 * sysdep.c (croak): Now static, if
11375 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
11376 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
11377
11378 * alloc.c (refill_memory_reserve): Now static if
11379 !defined REL_ALLOC || defined SYSTEM_MALLOC.
11380 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 11381
e87b6180
PE
11382 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
11383 Define only if USE_LUCID.
11384
ac64929e
PE
11385 * xrdb.c (x_customization_string, x_rm_string): Now static.
11386
6f37259d
PE
11387 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
11388 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
11389
1683e3ab
PE
11390 * xdisp.c (draw_row_with_mouse_face): Now static.
11391 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
11392
de9c2632
PE
11393 * window.h (check_all_windows): Mark externally visible.
11394
2b96acb7
PE
11395 * window.c (window_deletion_count): Now static.
11396
11397 * undo.c: Make symbols static if they're not exported.
11398 (last_undo_buffer, last_boundary_position, pending_boundary):
11399 Now static.
11400
50436f33
PE
11401 * textprop.c (interval_insert_behind_hooks): Now static.
11402 (interval_insert_in_front_hooks): Likewise.
11403
64520e5c
PE
11404 * term.c: Make symbols static if they're not exported.
11405 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
11406 (max_frame_lines, tty_set_terminal_modes):
11407 (tty_reset_terminal_modes, tty_turn_off_highlight):
11408 (get_tty_terminal): Now static.
11409 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
11410 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 11411 HAVE_WINDOW_SYSTEM.
64520e5c
PE
11412 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
11413 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
11414
1fa53021
PE
11415 * sysdep.c: Make symbols static if they're not exported.
11416 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
11417 Now static.
11418 (sigprocmask_set, full_mask): Remove; unused.
11419 (wait_debugging): Mark as visible.
11420 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
11421 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
11422
d4b43b22
PE
11423 * syntax.c (syntax_temp): Define only if !__GNUC__.
11424
b7c513d0
PE
11425 * sound.c (current_sound_device, current_sound): Now static.
11426
989b29ad
PE
11427 * search.c (searchbufs, searchbuf_head): Now static.
11428
13a55a78
PE
11429 * scroll.c (scroll_cost): Remove; unused.
11430 * dispextern.h (scroll_cost): Remove decl.
11431
de68a1fc
PE
11432 * region-cache.h (pp_cache): Mark as externally visible.
11433
40ccffa6
PE
11434 * process.c: Make symbols static if they're not exported.
11435 (process_tick, update_tick, create_process, chan_process):
11436 (Vprocess_alist, proc_buffered_char, datagram_access):
11437 (fd_callback_data, send_process_frame, process_sent_to): Now static.
11438 (deactivate_process): Mark defn as static, as well as decl.
11439 * lisp.h (create_process): Remove decl.
11440 * process.h (chan_process, Vprocess_alist): Remove decls.
11441
ad64fc97
PE
11442 * print.c: Make symbols static if they're not exported.
11443 (print_depth, new_backquote_output, being_printed, print_buffer):
11444 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
11445 (print_interval, print_number_index, initial_stderr_stream):
11446 Now static.
11447 * lisp.h (Fprinc): Remove decl.
11448 (debug_output_compilation_hack): Mark as externally visible.
11449
adddb265
PE
11450 * sysdep.c (croak): Move decl from here to syssignal.h.
11451 * syssignal.h (croak): Put it here, so the API can be checked when
11452 'croak' is called from dissociate_if_controlling_tty.
11453
1717ede2
PE
11454 * minibuf.c: Make symbols static if they're not exported.
11455 (minibuf_save_list, choose_minibuf_frame): Now static.
11456 * lisp.h (choose_minibuf_frame): Remove decl.
11457
fa5fb2bc
PE
11458 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
11459
1e3890d1
PE
11460 * lread.c: Make symbols static if they're not exported.
11461 (read_objects, initial_obarray, oblookup_last_bucket_number):
11462 Now static.
11463 (make_symbol): Remove; unused.
11464 * lisp.h (initial_obarray, make_symbol): Remove decls.
11465
8a1414fa
PE
11466 * keyboard.c: Make symbols static if they're not exported.
11467 (single_kboard, recent_keys_index, total_keys, recent_keys):
11468 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
11469 (this_single_command_key_start, echoing, last_auto_save):
11470 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
11471 (command_loop, echo_now, keyboard_init_hook, help_char_p):
11472 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
11473 (Vlispy_mouse_stem, double_click_count):
11474 Now static.
11475 (force_auto_save_soon): Define only if SIGDANGER.
11476 (ignore_mouse_drag_p): Now static if
11477 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
11478 (print_help): Remove; unused.
11479 (stop_character, last_timer_event): Mark as externally visible.
11480 * keyboard.h (ignore_mouse_drag_p): Declare only if
11481 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
11482 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
11483 * lisp.h (echoing): Remove decl.
11484 (force_auto_save_soon): Declare only if SIGDANGER.
11485 * xdisp.c (redisplay_window): Simplify code, to make it more
11486 obvious that ignore_mouse_drag_p is not accessed if !defined
11487 USE_GTK && !defined HAVE_NS.
11488
93ea6e8f
PE
11489 * intervals.c: Make symbols static if they're not exported.
11490 (merge_properties_sticky, merge_interval_right, delete_interval):
11491 Now static.
11492 * intervals.h (merge_interval_right, delete_interval): Remove decls.
11493
77382fcc
PE
11494 * insdel.c: Make symbols static if they're not exported.
11495 However, leave prepare_to_modify_buffer alone. It's never
11496 called from outside this function, but that appears to be a bug.
11497 (combine_after_change_list, combine_after_change_buffer):
4889fc82 11498 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
11499 (adjust_after_replace_noundo): Remove; unused.
11500 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 11501 (signal_before_change): Remove decls.
77382fcc 11502
9306c32e
PE
11503 * indent.c (val_compute_motion, val_vmotion): Now static.
11504
cd44d2eb
PE
11505 * image.c: Make symbols static if they're not exported.
11506 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
11507 if USE_GTK.
11508 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
11509 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
11510
ad9a7a06
PE
11511 * fringe.c (standard_bitmaps): Now static.
11512 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
11513
81626931
PE
11514 * frame.c: Make symbols static if they're not exported.
11515 (x_report_frame_params, make_terminal_frame): Now static.
11516 (get_frame_param): Now static, unless HAVE_NS.
11517 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
11518 (x_get_resource_string): Remove; not used.
11519 * frame.h (make_terminal_frame, x_report_frame_params):
11520 (x_get_resource_string); Remove decls.
11521 (x_fullscreen_adjust): Declare only if WINDOWSNT.
11522 * lisp.h (get_frame_param): Declare only if HAVE_NS.
11523
239f9db9
PE
11524 * font.c, fontset.c: Make symbols static if they're not exported.
11525 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
11526 (FACE_SUITABLE_FOR_CHAR_P): Use it.
11527 * font.c (font_close_object): Now static.
11528 * font.h (font_close_object): Remove.
11529 * fontset.c (FONTSET_OBJLIST): Remove.
11530 (free_realized_fontset) #if-0 the body, which does nothing.
11531 (face_suitable_for_char_p): #if-0, as it's never called.
11532 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
11533 * xfaces.c (face_at_string_position):
11534 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
11535 since 0 is always ASCII.
11536
dfcf3579
PE
11537 * fns.c (weak_hash_tables): Now static.
11538
5045092b
PE
11539 * fileio.c: Make symbols static if they're not exported.
11540 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
11541 (Vwrite_region_annotation_buffers): Now static.
11542
57a96f5c
PE
11543 * eval.c: Make symbols static if they're not exported.
11544 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
11545 * lisp.h (backtrace_list): Remove decl.
11546
35f08c38
PE
11547 * emacs.c: Make symbols static if they're not exported.
11548 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
11549 (fatal_error_code, fatal_error_signal_hook, standard_args):
11550 Now static.
11551 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
11552 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
11553 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
11554 * lisp.h (fatal_error_signal_hook): Remove decl.
11555 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
11556
f44bd759
PE
11557 * editfns.c: Move a (normally-unused) function to its only use.
11558 * editfns.c, lisp.h (get_operating_system_release): Remove.
11559 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
11560 worth the hassle of breaking this out.
11561
b532497d
PE
11562 * xterm.c: Make symbols static if they're not exported.
11563 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
11564 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
11565 (x_destroy_window, x_delete_display):
11566 Now static.
11567 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
11568 (x_mouse_leave): Remove; unused.
11569 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
11570 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
11571 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
11572 Remove decls.
11573 (x_mouse_leave): Declare only if WINDOWSNT.
11574 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
11575 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
11576 USE_X_TOOLKIT.
11577
1675728f
PE
11578 * ftxfont.c: Make symbols static if they're not exported.
11579 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
11580 HAVE_FREETYPE.
11581 * font.h (ftxfont_driver): Likewise.
11582
e4cebfca
PE
11583 * xfns.c: Make symbols static if they're not exported.
11584 (x_last_font_name, x_display_info_for_name):
11585 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
11586 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
11587 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
11588 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
11589 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
11590 (last_show_tip_args): Now static.
11591 (xic_defaut_fontset, xic_create_fontsetname): Define only if
11592 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
11593 (x_screen_planes): Remove; unused.
11594 * dispextern.h (x_screen_planes): Remove decl.
11595
5bf46f05
PE
11596 * dispnew.c: Make symbols static if they're not exported.
11597 * dispextern.h (redraw_garbaged_frames, scrolling):
11598 (increment_row_positions): Remove.
11599 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
11600 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
11601 Now static.
11602 (redraw_garbaged_frames): Remove; unused.
11603
435f4c28
PE
11604 * xfaces.c: Make symbols static if they're not exported.
11605 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
11606 Remove decls.
11607 * xterm.h (defined_color): Remove decls.
11608 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
11609 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
11610 (menu_face_changed_default, defined_color, free_realized_face):
11611 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
11612 (ascii_face_of_lisp_face): Remove; unused.
11613
8524aef3
PE
11614 * xdisp.c: Make symbols static if they're not exported.
11615 * dispextern.h (scratch_glyph_row, window_box_edges):
11616 (glyph_to_pixel_coords, set_cursor_from_row):
11617 (get_next_display_element, set_iterator_to_next):
11618 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
11619 (show_mouse_face): Remove decls
11620 * frame.h (message_buf_print): Likewise.
11621 * lisp.h (pop_message, set_message, check_point_in_composition):
11622 Likewise.
11623 * xterm.h (set_vertical_scroll_bar): Likewise.
11624 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
11625 (message_buf_print, scratch_glyph_row, displayed_buffer):
11626 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
11627 (get_next_display_element, show_mouse_face, window_box_edges):
11628 (frame_to_window_pixel_xy, check_point_in_composition):
11629 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
11630 (glyph_to_pixel_coords): Remove; unused.
11631
16390cd2
PE
11632 * dired.c (file_name_completion): Now static.
11633
11634 * dbusbind.c (xd_in_read_queued_messages): Now static.
11635
a25f4dfa
PE
11636 * lisp.h (circular_list_error, FOREACH): Remove; unused.
11637 * data.c (circular_list_error): Remove.
11638
14a9c8df
PE
11639 * commands.h (last_point_position, last_point_position_buffer):
11640 (last_point_position_window): Remove decls.
11641 * keyboard.c: Make these variables static.
11642
04f2d78b
CB
11643 * coding.h (coding, code_convert_region, encode_coding_gap):
11644 Remove decls.
74ab6df5
PE
11645 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
11646 (iso_code_class, detect_coding, code_convert_region): Now static.
11647 (encode_coding_gap): Remove; unused.
11648
38dfbee1
PE
11649 * chartab.c (chartab_chars, chartab_bits): Now static.
11650
a2cb4e63
PE
11651 * charset.h (charset_iso_8859_1): Remove decl.
11652 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
11653 Now static.
11654
127198fd
PE
11655 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
11656 * ccl.c (Vccl_program_table): Now static.
11657 (check_ccl_update): Remove; unused.
11658
d85b608f
PE
11659 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
11660 * category.h: ... from here.
11661 * category.c (check_category_table, set_category_set): Now static.
11662
31cd66f3
PE
11663 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
11664 * lisp.h: Remove these decls.
11665
c358e587
PE
11666 * buffer.c (buffer_count): Remove unused var.
11667
e78aecca
PE
11668 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
11669 so that it's not optimized away.
11670 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
11671 * dispextern.h (bidi_dump_cached_states): Remove, since it's
11672 exported only to the debugger.
11673
e192d7d3 11674 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 11675 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 11676
92470028
PE
11677 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
11678 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
11679 was inaccessible from Lisp.
11680 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
11681 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
11682
244ed907
PE
11683 alloc.c: Import and export fewer symbols, and remove unused items.
11684 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
11685 is defined.
11686 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
11687 it's not optimized away by whole-program optimization.
11688 (message_enable_multibyte, free_misc): Remove.
11689 (catchlist, handlerlist, mark_backtrace):
11690 Declare only if BYTE_MARK_STACK.
11691 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
11692 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
11693 (message_enable_multibyte): Remove decl.
11694 (free_misc, interval_free_list, float_block, float_block_index):
11695 (n_float_blocks, float_free_list, cons_block, cons_block_index):
11696 (cons_free_list, last_marked_index):
11697 Now static.
11698 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
11699 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
11700 (mark_backtrace): Define only if BYTE_MARK_STACK.
11701 * xdisp.c (message_enable_multibyte): Now static.
11702
61c2b50e 11703 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
11704 This makes it easier for human readers (and static analyzers)
11705 to see whether these variables are used from other modules.
11706 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
11707 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
11708 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
11709 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
11710 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
11711 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
11712 * xmenu.c, xselect.c:
11713 Declare Q* vars static if they are not used in other modules.
11714 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
11715 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
11716 Remove decls of unexported vars.
11717 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
11718
95c82688
PE
11719 * lisp.h (DEFINE_FUNC): Make sname 'static'.
11720
16a97296
PE
11721 Make Emacs functions such as Fatom 'static' by default.
11722 This makes it easier for human readers (and static analyzers)
11723 to see whether these functions can be called from other modules.
11724 DEFUN now defines a static function. To make the function external
11725 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
11726 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
11727 (Finit_image_library):
16a97296
PE
11728 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
11729 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
11730 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
11731 Remove decls, since these functions are now static.
11732 (Funintern, Fget_internal_run_time): New decls, since these functions
11733 were already external.
95c82688 11734
16a97296
PE
11735 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
11736 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
11737 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
11738 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
11739 * keyboard.c, keymap.c, lread.c:
11740 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
11741 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
11742 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
11743 Mark functions with DEFUE instead of DEFUN,
11744 if they are used in other modules.
11745 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
11746 decls for now-static functions.
11747 * buffer.h (Fdelete_overlay): Remove decl.
11748 * callproc.c (Fgetenv_internal): Mark as internal.
11749 * composite.c (Fremove_list_of_text_properties): Remove decl.
11750 (Fcomposition_get_gstring): New forward static decl.
11751 * composite.h (Fcomposite_get_gstring): Remove decl.
11752 * dired.c (Ffile_attributes): New forward static decl.
11753 * doc.c (Fdocumntation_property): New forward static decl.
11754 * eval.c (Ffetch_bytecode): New forward static decl.
11755 (Funintern): Remove extern decl; now in .h file where it belongs.
11756 * fileio.c (Fmake_symbolic_link): New forward static decl.
11757 * image.c (Finit_image_library): New forward static decl.
11758 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
11759 * intervals.h (Fprevious_property_change):
11760 (Fremove_list_of_text_properties): Remove decls.
11761 * keyboard.c (Fthis_command_keys): Remove decl.
11762 (Fcommand_execute): New forward static decl.
11763 * keymap.c (Flookup_key): New forward static decl.
11764 (Fcopy_keymap): Now static.
11765 * keymap.h (Flookup_key): Remove decl.
11766 * process.c (Fget_process): New forward static decl.
11767 (Fprocess_datagram_address): Mark as internal.
11768 * syntax.c (Fsyntax_table_p): New forward static decl.
11769 (skip_chars): Remove duplicate decl.
11770 * textprop.c (Fprevious_property_change): New forward static decl.
11771 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
11772 Now internal.
11773 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
11774 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
11775
785bbd42
PE
11776 * editfns.c (Fformat): Remove unreachable code.
11777
8b913b57
AS
117782011-04-14 Andreas Schwab <schwab@linux-m68k.org>
11779
11780 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
11781 change. (Bug#8496)
11782
a6744a35
EZ
117832011-04-13 Eli Zaretskii <eliz@gnu.org>
11784
11785 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
11786 when at ZV. (Bug#8487)
11787
e7974947
AS
117882011-04-12 Andreas Schwab <schwab@linux-m68k.org>
11789
baad03f0
AS
11790 * charset.c (Fclear_charset_maps): Use xfree instead of free.
11791 (Bug#8437)
11792 * keyboard.c (parse_tool_bar_item): Likewise.
11793 * sound.c (sound_cleanup, alsa_close): Likewise.
11794 * termcap.c (tgetent): Likewise.
11795 * xfns.c (x_default_font_parameter): Likewise.
11796 * xsettings.c (read_and_apply_settings): Likewise.
11797
e7974947
AS
11798 * alloc.c (overrun_check_malloc, overrun_check_realloc)
11799 (overrun_check_free): Protoize.
11800
28272684
PE
118012011-04-12 Paul Eggert <eggert@cs.ucla.edu>
11802
11803 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
11804 since callers should never pass a negative size.
11805 Change the signature to match that of plain 'read' and 'write'; see
11806 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
11807 * lisp.h: Update prototypes of emacs_write and emacs_read.
11808
11997c76
EZ
118092011-04-11 Eli Zaretskii <eliz@gnu.org>
11810
11811 * xdisp.c (redisplay_window): Don't try to determine the character
11812 position of the scroll margin if the window start point w->startp
e896f03c 11813 is outside the buffer's accessible region. (Bug#8468)
11997c76 11814
8a2cbd72
EZ
118152011-04-10 Eli Zaretskii <eliz@gnu.org>
11816
11817 Fix write-region and its subroutines for buffers > 2GB.
11818 * fileio.c (a_write, e_write): Modify declaration of arguments and
11819 local variables to support buffers larger than 2GB.
11820 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
11821
11822 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
11823 argument, local variables, and return value.
11824
11825 * lisp.h: Update prototypes of emacs_write and emacs_read.
11826
11827 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
11828
4073e537 118292011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 11830
1ebfdcb6
PE
11831 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
11832
b2ded58d
PE
11833 Fix more problems found by GCC 4.6.0's static checks.
11834
7d66342c
PE
11835 * xdisp.c (vmessage): Use a better test for character truncation.
11836
bbf47d44
PE
11837 * charset.c (load_charset_map): <, not <=, for optimization,
11838 and to avoid potential problems with integer overflow.
9248994d 11839 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 11840 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 11841 * editfns.c (Fformat): Likewise.
1e69125e 11842 * syntax.c (skip_chars): Likewise.
3befa583 11843
e3019616
PE
11844 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
11845 This also lets GCC 4.6.0 generate slightly better loop code.
11846
becfa255
PE
11847 * callint.c (Fcall_interactively): <, not <=, for optimization.
11848 (Fcall_interactively): Count the number of arguments produced,
11849 not the number of arguments given. This is simpler and lets GCC
11850 4.6.0 generate slightly better code.
11851
dae0cd48
PE
11852 * ftfont.c: Distingish more carefully between FcChar8 and char.
11853 The previous code passed unsigned char * to a functions like
11854 strlen and xstrcasecmp that expect char *, which does not
11855 conform to the C standard.
11856 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
11857 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
11858 char * when the C standard requires it.
11859
76032d70
PE
11860 * keyboard.c (read_char): Remove unused var.
11861
eb3f1cc8
PE
11862 * eval.c: Port to Windows vsnprintf (Bug#8435).
11863 Include <limits.h>.
11864 (SIZE_MAX): Define if the headers do not.
11865 (verror): Do not give up if vsnprintf returns a negative count.
11866 Instead, grow the buffer. This ports to Windows vsnprintf, which
11867 does not conform to C99. Problem reported by Eli Zaretskii.
11868 Also, simplify the allocation scheme, by avoiding the need for
11869 calling realloc, and removing the ALLOCATED variable.
11870
70476b54
PE
11871 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
11872
12020a9e
PE
11873 Remove invocations of doprnt, as Emacs now uses vsnprintf.
11874 But keep the doprint source code for now, as we might revamp it
11875 and use it again (Bug#8435).
ea6c7ae6
PE
11876 * lisp.h (doprnt): Remove.
11877 * Makefile.in (base_obj): Remove doprnt.o.
11878 * deps.mk (doprnt.o): Remove.
11879
5fdb398c
PE
11880 error: Print 32- and 64-bit integers portably (Bug#8435).
11881 Without this change, on typical 64-bit hosts error ("...%d...", N)
11882 was used to print both 32- and 64-bit integers N, which relied on
11883 undefined behavior.
61bdb816 11884 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
11885 * lisp.h (error, verror): Mark as printf-like functions.
11886 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
11887 Report overflow in size calculations when allocating printf buffer.
11888 Do not truncate output string at its first null byte.
11889 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
11890 Truncate the output at a character boundary, since vsnprintf does not
11891 do that.
11892 * charset.c (check_iso_charset_parameter): Convert internal
11893 character to string before calling 'error', since %c now has the
11894 printf meaning.
11895 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
11896 overflow when computing char to be passed to 'error'. Do not
11897 pass Lisp_Object to 'error'; pass the integer instead.
11898 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
11899 formatted with plain %d.
11900
b189fa66
PE
11901 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
11902
bff87ef0
PE
11903 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
11904
7e2cac20
PE
11905 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
11906
ce4d90b5
PE
11907 * xterm.c (x_catch_errors): Remove duplicate declaration.
11908
266c9547
PE
11909 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
11910
79c49ad2
PE
11911 * xdisp.c, lisp.h (message_nolog): Remove; unused.
11912
368f4090
JM
119132011-04-10 Jim Meyering <meyering@redhat.com>
11914
11915 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
11916 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
11917 return ssize_t not "int", and use size_t as the buffer length.
11918 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
11919 * gnutls.h: Update declarations.
11920 * process.c (read_process_output): Use ssize_t, to match.
11921 (send_process): Likewise.
11922
a32d4040
CY
119232011-04-09 Chong Yidong <cyd@stupidchicken.com>
11924
11925 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
11926
8546720e 119272011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 11928
04f2d78b
CB
11929 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
11930 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 11931
8546720e
GM
11932 * xterm.c (handle_one_xevent):
11933 * xmenu.c (create_and_show_popup_menu):
11934 * xselect.c (x_decline_selection_request)
11935 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 11936
0a2f5c1a 119372011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
11938
11939 Fix some uses of `int' instead of EMACS_INT.
11940 * search.c (string_match_1, fast_string_match)
11941 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
11942 (scan_buffer, find_next_newline_no_quit)
11943 (find_before_next_newline, search_command, Freplace_match)
11944 (Fmatch_data): Make some `int' variables be EMACS_INT.
11945
11946 * xdisp.c (display_count_lines): 3rd argument and return value now
11947 EMACS_INT. All callers changed.
11948 (pint2hrstr): Last argument is now EMACS_INT.
11949
11950 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
11951 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
11952 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
11953 (decode_coding_utf_16, decode_coding_emacs_mule)
11954 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
11955 (decode_coding_ccl, decode_coding_charset)
11956 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
11957 (decode_coding_iso_2022, decode_coding_emacs_mule)
11958 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
11959 <char_offset, last_offset>: Declare EMACS_INT.
11960 (encode_coding_utf_8, encode_coding_utf_16)
11961 (encode_coding_emacs_mule, encode_invocation_designation)
11962 (encode_designation_at_bol, encode_coding_iso_2022)
11963 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
11964 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
11965 Declare EMACS_INT.
11966 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
11967 (encode_invocation_designation): Last argument P_NCHARS is now
11968 EMACS_INT.
11969 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
11970 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
11971
11972 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
11973 All users changed.
11974
11975 * ccl.c (Fccl_execute_on_string): Declare some variables
11976 EMACS_INT.
11977
8546720e 119782011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
11979
11980 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
11981
4e19a977
CS
119822011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
11983
11984 * process.c (Fformat_network_address): Doc fix.
11985
87302331
R
119862011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
11987
ee7683eb 11988 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 11989
cbb59342
CY
119902011-04-08 Chong Yidong <cyd@stupidchicken.com>
11991
11992 * keyboard.c (read_char): Call Lisp function help-form-show,
11993 instead of using internal_with_output_to_temp_buffer.
11994 (Qhelp_form_show): New var.
e0d38eeb 11995 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
11996
11997 * print.c (internal_with_output_to_temp_buffer): Function deleted.
11998
11999 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
12000
e67a13ab
CY
120012011-04-06 Chong Yidong <cyd@stupidchicken.com>
12002
04f2d78b
CB
12003 * process.c (Flist_processes): Remove to Lisp.
12004 (list_processes_1): Delete.
e67a13ab 12005
973f782d
EZ
120062011-04-06 Eli Zaretskii <eliz@gnu.org>
12007
7c106b1e
EZ
12008 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
12009
973f782d
EZ
12010 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
12011
41cf7d1a 120122011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 12013
ca23cc88
PE
12014 Fix more problems found by GCC 4.6.0's static checks.
12015
f390e2d5
PE
12016 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
12017
42eea0d0
PE
12018 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
12019
b69769da 12020 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 12021
f9541e84
PE
12022 * xdisp.c (vmessage): Mark as a printf-like function.
12023
13841b55
PE
12024 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
12025
c136c10f
PE
12026 * sound.c (sound_warning): Don't crash if arg contains a printf format.
12027
5e2d4a30
PE
12028 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
12029 printf-like functions.
12030 (tiff_load): Add casts to remove these marks before passing them
12031 to system-supplied API.
12032
583f48b9
PE
12033 * eval.c (Fsignal): Remove excess argument to 'fatal'.
12034
b25d760e
PE
12035 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
12036 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
12037 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
12038 directly, rather than having caller test rule sign. This avoids
12039 some unnecessary tests.
12040 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
12041 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
12042 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 12043
bc7b6697 12044 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 12045 (xfont_open): Avoid unnecessary tests.
bc7b6697 12046
27ccc379
PE
12047 * composite.c (composition_gstring_put_cache): Use unsigned integer.
12048
dcd5c89a
PE
12049 * composite.h, composite.c (composition_gstring_put_cache):
12050 Use EMACS_INT, not int, for length.
12051
b13a45c6
PE
12052 * composite.h (COMPOSITION_DECODE_REFS): New macro,
12053 breaking out part of COMPOSITION_DECODE_RULE.
12054 (COMPOSITION_DECODE_RULE): Use it.
12055 * composite.c (get_composition_id): Remove unused local vars,
12056 by using the new macro.
12057
1e792e4d
PE
12058 * textprop.c (set_text_properties_1): Change while to do-while,
12059 since the condition is always true at first.
12060
dc6c6455 12061 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
12062 (interval_deletion_adjustment): Return unsigned value.
12063 All uses changed.
dc6c6455 12064
aba7731a
PE
12065 * process.c (list_processes_1, create_pty, read_process_output):
12066 (exec_sentinel): Remove vars that were set but not used.
afd4052b 12067 (create_pty): Remove unnecessary "volatile"s.
bc57d757 12068 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 12069 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 12070 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 12071
fdfc4bf3
PE
12072 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
12073
fca8fe46 12074 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 12075 (update_syntax_table): Use unsigned instead of int.
fca8fe46 12076
06a0259a 12077 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 12078 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 12079 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 12080
e7b9e80f
PE
12081 * print.c (print_error_message): Avoid int overflow.
12082
56201685
PE
12083 * font.c (font_list_entities): Redo for clarity,
12084 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
12085
78834453 12086 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 12087 (font_score): Avoid potential overflow in diff calculation.
78834453 12088
0bc0b309 12089 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 12090 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 12091
e610eaca
PE
12092 * eval.c (funcall_lambda): Rename local to avoid shadowing.
12093
b895abce
PE
12094 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
12095 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
12096 can always succeed if overflow has undefined behavior.
12097
1f1d9321 12098 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 12099 (wordify): Omit three unnecessary tests.
1f1d9321 12100
c59478bc
PE
12101 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
12102 All callers changed. This avoids the need for an unused var.
12103
79b73827
PE
12104 * casefiddle.c (casify_region): Remove var that is set but not used.
12105
a4db5dfe
PE
12106 * dired.c (file_name_completion): Remove var that is set but not used.
12107
43aae36e
PE
12108 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
12109
2a47c44d 12110 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 12111 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 12112
a37c69bf
PE
12113 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
12114 Check for integer overflow on size calculations.
12115
328ab8e7
PE
12116 * buffer.c (Fprevious_overlay_change): Remove var that is set
12117 but not used.
12118
e5a2a5cb
PE
12119 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
12120 Remove vars that are set but not used.
8d84a6eb 12121 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 12122 (timer_check_2): Mark vars as initialized.
e5a2a5cb 12123
a60e5f68
PE
12124 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
12125
f661cb61 12126 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 12127 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 12128
f0397f5a
PE
12129 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
12130 that are set but not used.
12131
8664db06 12132 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 12133 if XCreateBitmapFromData fails (Bug#8410).
8664db06 12134
6abdaa4a
PE
12135 * xselect.c (x_get_local_selection, x_handle_property_notify):
12136 Remove vars that are set but not used.
12137
0ce7538d 12138 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 12139 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 12140
9ae848fc
PE
12141 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
12142 Remove var that is set but not used.
0b918413
PE
12143 (scroll_bar_windows_size): Now size_t, not int.
12144 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
12145 Check for overflow.
9ae848fc 12146
a5a62657
PE
12147 * xfaces.c (realize_named_face): Remove vars that are set but not used.
12148 (map_tty_color) [!defined MSDOS]: Likewise.
12149
5c5cdd39
PE
12150 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
12151
66ebf983
PE
12152 * coding.c: Remove vars that are set but not used.
12153 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
12154 All callers changed.
12155 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
12156 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
12157 (decode_coding_charset): Remove vars that are set but not used.
12158
1be4d761
PE
12159 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
12160 that is set but not used.
12161
47553fa8
PE
12162 * print.c (print_object): Remove var that is set but not used.
12163
1f7196bf 12164 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
12165 The gnulib version avoids calling malloc in the usual case,
12166 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
12167 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
12168 * filelock.c (current_lock_owner): Likewise.
12169 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
12170 * sysdep.c: Include allocator.h, careadlinkat.h.
12171 (emacs_no_realloc_allocator): New static constant.
12172 (emacs_readlink): New function.
fdb61804
PE
12173 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
12174 ../lib/careadlinkat.h.
d1fdcab7 12175
f84c17c7
SM
121762011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
12177
12178 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
12179 first non-nil return value).
12180
ef3862ad
JD
121812011-04-03 Jan Djärv <jan.h.d@swipnet.se>
12182
12183 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
12184 if not defined (Bug#8403).
12185
376a7006
JB
121862011-04-02 Juanma Barranquero <lekktu@gmail.com>
12187
12188 * xdisp.c (display_count_lines): Remove parameter `start',
12189 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12190 (get_char_face_and_encoding): Remove parameter `multibyte_p',
12191 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12192 (fill_stretch_glyph_string): Remove parameters `row' and `area',
12193 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
12194 and thereabouts. All callers changed.
12195 (get_per_char_metric): Remove parameter `f', unused since
12196 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12197
6ca3801d
JM
121982011-04-02 Jim Meyering <meyering@redhat.com>
12199
12200 do not dereference NULL upon failed strdup
12201 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
12202 (ns_get_family): Likewise.
12203
d8e2b5ba
JB
122042011-04-02 Juanma Barranquero <lekktu@gmail.com>
12205
12206 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
12207
8c74fcbd
JD
122082011-04-02 Jan Djärv <jan.h.d@swipnet.se>
12209
12210 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
12211 later (Bug#8403).
12212
7200d79c
SM
122132011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
12214
03408648 12215 Add lexical binding.
7200d79c 12216
03408648
SM
12217 * window.c (Ftemp_output_buffer_show): New fun.
12218 (Fsave_window_excursion):
12219 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
12220
12221 * lread.c (lisp_file_lexically_bound_p): New function.
12222 (Fload): Bind Qlexical_binding.
12223 (readevalloop): Remove `evalfun' arg.
12224 Bind Qinternal_interpreter_environment.
12225 (Feval_buffer): Bind Qlexical_binding.
12226 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
12227 Mark as dynamic.
12228 (syms_of_lread): Declare `lexical-binding'.
12229
12230 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
12231
12232 * keyboard.c (eval_dyn): New fun.
12233 (menu_item_eval_property): Use it.
ca105506
SM
12234
12235 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 12236
03408648
SM
12237 * fns.c (concat, mapcar1): Accept byte-code-functions.
12238
12239 * eval.c (Fsetq): Handle lexical vars.
12240 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
12241 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
12242 (FletX, Flet): Obey lexical binding.
12243 (Fcommandp): Handle closures.
12244 (Feval): New `lexical' arg.
12245 (eval_sub): New function extracted from Feval. Use it almost
12246 everywhere where Feval was used. Look up vars in lexical env.
12247 Handle closures.
12248 (Ffunctionp): Move from subr.el.
12249 (Ffuncall): Handle closures.
12250 (apply_lambda): Remove `eval_flags'.
12251 (funcall_lambda): Handle closures and new byte-code-functions.
12252 (Fspecial_variable_p): New function.
12253 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
12254 but without exporting it to Lisp.
23aba0ea 12255
23aba0ea 12256 * doc.c (Fdocumentation, store_function_docstring):
03408648 12257 * data.c (Finteractive_form): Handle closures.
23aba0ea 12258
03408648
SM
12259 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
12260 interactive spec.
ba83908c 12261
04f2d78b
CB
12262 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
12263 New byte-codes.
03408648
SM
12264 (exec_byte_code): New function extracted from Fbyte_code to handle new
12265 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 12266
03408648 12267 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 12268
03408648 12269 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 12270
e2abce01
JB
122712011-03-31 Juanma Barranquero <lekktu@gmail.com>
12272
12273 * xdisp.c (redisplay_internal): Fix prototype.
12274
63696a73 122752011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 12276
63696a73 12277 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
12278 (try_scrolling): Use it when setting scroll_limit.
12279 Limit scrolling to 100 screen lines.
63696a73
EZ
12280 (redisplay_window): Even when falling back on "recentering",
12281 position point in the window according to scroll-conservatively,
12282 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
12283
12284 (try_scrolling): When point is above the window, allow searching
12285 as far as scroll_max, or one screenful, to compute vertical
12286 distance from PT to the scroll margin position. This prevents
12287 try_scrolling from unnecessarily failing when
12288 scroll-conservatively is set to a value slightly larger than the
12289 window height. Clean up the case of PT below the margin at bottom
12290 of window: scroll_max can no longer be INT_MAX. When aggressive
12291 scrolling is in use, don't let point enter the opposite scroll
12292 margin as result of the scroll.
12293 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
12294 threshold of 100 lines for never-recentering scrolling.
12295
e4cc2dfc
JB
122962011-03-31 Juanma Barranquero <lekktu@gmail.com>
12297
12298 * dispextern.h (move_it_by_lines):
12299 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
12300 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
12301 (message_log_check_duplicate): Remove parameters `prev_bol' and
12302 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12303 (redisplay_internal): Remove parameter `preserve_echo_area',
12304 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
12305
12306 * indent.c (Fvertical_motion):
12307 * window.c (window_scroll_pixel_based, Frecenter):
12308 Don't pass `need_y_p' to `move_it_by_lines'.
12309
1c470562
SM
123102011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
12311
44f230aa
SM
12312 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
12313 steal a few bits to be more compact.
12314 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
12315 Remove unneeded casts.
12316
1c470562
SM
12317 * bytecode.c (Fbyte_code): CAR and CDR can GC.
12318
888adce9
ZK
123192011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
12320
12321 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
12322 binding" message (bug#7967).
12323
f838ed7b
PE
123242011-03-30 Paul Eggert <eggert@cs.ucla.edu>
12325
77861b95
PE
12326 Fix more problems found by GCC 4.6.0's static checks.
12327
de6dbc14
PE
12328 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
12329 Remove unused local var.
12330
f838ed7b
PE
12331 * editfns.c (Fmessage_box): Remove unused local var.
12332
792c7b2b
PE
12333 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
12334 (note_mode_line_or_margin_highlight, note_mouse_highlight):
12335 Omit unused local vars.
c499e557 12336 * window.c (shrink_windows): Omit unused local var.
b01a1c29 12337 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
12338 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
12339 Omit unused local var.
12340
ba0165e1
PE
12341 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
12342 Don't assume string length fits in int.
32ad8845 12343 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 12344 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 12345
3c59b4c9
PE
12346 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
12347 instead of alloca (Bug#8344).
12348
a3eed478 12349 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 12350 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 12351
eb4d412d
PE
12352 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
12353
1658b401
PE
12354 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
12355 concerns.
12356
12357 * term.c (produce_glyphless_glyph): Remove unnecessary test.
12358
12359 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 12360
9a2c6e05
PE
12361 * keyboard.c (syms_of_keyboard): Use the same style as later
12362 in this function when indexing through an array. This also
12363 works around GCC bug 48267.
12364
03d0a109
PE
12365 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
12366
44f730c8
PE
12367 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
12368
fe75f926
PE
12369 * chartab.c (sub_char_table_ref_and_range): Redo for slight
12370 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
12371
ffa8c828
PE
12372 * keyboard.c, keyboard.h (num_input_events): Now size_t.
12373 This avoids undefined behavior on integer overflow, and is a bit
12374 more convenient anyway since it is compared to a size_t variable.
12375
c5101a77
PE
12376 Variadic C functions now count arguments with size_t, not int.
12377 This avoids an unnecessary limitation on 64-bit machines, which
12378 caused (substring ...) to crash on large vectors (Bug#8344).
12379 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
12380 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 12381 All variadic functions and their callers changed accordingly.
c5101a77
PE
12382 (struct gcpro.nvars): Now size_t, not int. All uses changed.
12383 * data.c (arith_driver, float_arith_driver): Likewise.
12384 * editfns.c (general_insert_function): Likewise.
12385 * eval.c (struct backtrace.nargs, interactive_p)
12386 (internal_condition_case_n, run_hook_with_args, apply_lambda)
12387 (funcall_lambda, mark_backtrace): Likewise.
12388 * fns.c (concat): Likewise.
12389 * frame.c (x_set_frame_parameters): Likewise.
12390 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
12391 0 if not found, not -1. All callers changed.
12392
dd3f25f7
PE
12393 * alloc.c (garbage_collect): Don't assume stack size fits in int.
12394 (stack_copy_size): Now size_t, not int.
12395 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
12396
461c2ab9
JB
123972011-03-28 Juanma Barranquero <lekktu@gmail.com>
12398
12399 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
12400 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12401 All callers changed.
12402
12403 * lisp.h (multibyte_char_to_unibyte):
12404 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
12405 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12406 * character.h (CHAR_TO_BYTE8):
12407 * cmds.c (internal_self_insert):
12408 * editfns.c (general_insert_function):
12409 * keymap.c (push_key_description):
12410 * search.c (Freplace_match):
12411 * xdisp.c (message_dolog, set_message_1): All callers changed.
12412
f6d62986
SM
124132011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
12414
12415 * keyboard.c (safe_run_hook_funcall): New function.
12416 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
12417 don't set the hook to nil, but remove the offending function instead.
12418 (Qcommand_hook_internal): Remove, unused.
12419 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
12420 Vcommand_hook_internal.
12421
12422 * eval.c (enum run_hooks_condition): Remove.
12423 (funcall_nil, funcall_not): New functions.
12424 (run_hook_with_args): Call each function through a `funcall' argument.
12425 Remove `cond' argument, now redundant.
12426 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
12427 (Frun_hook_with_args_until_failure): Adjust accordingly.
12428 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
12429
1db5b1ad
JB
124302011-03-28 Juanma Barranquero <lekktu@gmail.com>
12431
12432 * dispextern.h (string_buffer_position): Remove declaration.
12433
12434 * print.c (strout): Remove parameter `multibyte', unused since
12435 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
12436
12437 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
12438 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
12439 All callers changed.
12440
12441 * w32.c (_wsa_errlist): Use braces for struct initializers.
12442
12443 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
12444 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
12445 All callers changed.
12446 (string_buffer_position): Likewise. Also, make static (it's never
12447 used outside xdisp.c).
12448 (cursor_row_p): Remove parameter `w', unused since
12449 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
12450 (decode_mode_spec): Remove parameter `precision', introduced during
12451 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
12452 All callers changed.
12453
5ffb62aa
JD
124542011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12455
12456 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
12457
461c2ab9 124582011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
12459
12460 * nsterm.m (ns_menu_bar_is_hidden): New variable.
12461 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
12462 (ns_update_auto_hide_menu_bar): New functions.
12463 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
12464 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
12465 ns_constrain_all_frames.
12466 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
12467 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
12468
5c380ffb
JD
124692011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12470
12471 * nsmenu.m (runDialogAt): Remove argument to timer_check.
12472
9af30bdf
GM
124732011-03-27 Glenn Morris <rgm@gnu.org>
12474
12475 * syssignal.h: Replace RETSIGTYPE with void.
12476 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
12477 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
12478 Replace SIGTYPE with void everywhere.
12479 * s/usg5-4-common.h (SIGTYPE): Remove definition.
12480 * s/template.h (SIGTYPE): Remove commented out definition.
12481
e2abce01
JB
124822011-03-26 Eli Zaretskii <eliz@gnu.org>
12483
12484 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
12485 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
12486
f868cd8a
JB
124872011-03-26 Juanma Barranquero <lekktu@gmail.com>
12488
59eb0929
JB
12489 * w32.c (read_unc_volume): Use parameter `henum', instead of
12490 global variable `wget_enum_handle'.
12491
12492 * keymap.c (describe_vector): Remove parameters `indices' and
12493 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
12494 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
12495
f868cd8a
JB
12496 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
12497
12498 * keyboard.c (timer_check): Remove parameter `do_it_now',
12499 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
12500 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
12501 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
12502
12503 * keyboard.c (read_char):
12504 * w32menu.c (w32_menu_display_help):
12505 * xmenu.c (show_help_event, menu_help_callback):
12506 Adjust calls to `show_help_echo'.
12507
12508 * gtkutil.c (xg_maybe_add_timer):
12509 * keyboard.c (readable_events):
12510 * process.c (wait_reading_process_output):
12511 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
12512
12513 * insdel.c (adjust_markers_gap_motion):
12514 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
12515 (gap_left, gap_right): Don't call it.
12516
2ecf6fdb
CY
125172011-03-25 Chong Yidong <cyd@stupidchicken.com>
12518
12519 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
12520 incurred during fontification.
12521
6b1f9ba4
JB
125222011-03-25 Juanma Barranquero <lekktu@gmail.com>
12523
12524 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
12525 (DEFVAR_PER_BUFFER): Don't pass it.
12526
12527 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
12528 (scrolling_window): Don't pass it.
12529
0f4a96b5
JB
125302011-03-25 Juanma Barranquero <lekktu@gmail.com>
12531
12532 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
12533
12534 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
12535 and `suffix'.
12536 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
12537 of variables specific to SELinux and computation of `encoded_absname'.
12538
12539 * image.c (XPutPixel): Remove unused variable `height'.
12540
12541 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
12542
12543 * unexw32.c (get_section_info): Remove unused variable `section'.
12544
12545 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
12546 (system_process_attributes): Remove unused variable `sess'.
12547 (sys_read): Remove unused variable `err'.
12548
12549 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
12550 (w32_wnd_proc): Remove unused variable `isdead'.
12551 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
12552 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
12553 (x_create_tip_frame): Remove unused variable `tem'.
12554
12555 * w32inevt.c (w32_console_read_socket):
12556 Remove unused variable `no_events'.
12557
12558 * w32term.c (x_draw_composite_glyph_string_foreground):
12559 Remove unused variable `width'.
12560
1149507c
JB
125612011-03-24 Juanma Barranquero <lekktu@gmail.com>
12562
12563 * w32term.c (x_set_glyph_string_clipping):
12564 Don't pass uninitialized region to CombineRgn.
12565
9c88f339
JB
125662011-03-23 Juanma Barranquero <lekktu@gmail.com>
12567
12568 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
12569 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
12570 (Fx_close_connection): Remove unused variable `i'.
12571
12572 * w32font.c (w32font_draw): Return number of glyphs.
12573 (w32font_open_internal): Remove unused variable `i'.
12574 (w32font_driver): Add missing initializer.
12575
12576 * w32menu.c (utf8to16): Remove unused variable `utf16'.
12577 (fill_in_menu): Remove unused variable `items_added'.
12578
12579 * w32term.c (last_mouse_press_frame): Remove static global variable.
12580 (w32_clip_to_row): Remove unused variable `f'.
12581 (x_delete_terminal): Remove unused variable `i'.
12582
12583 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
12584 (NOTHING): Remove unused static global variable.
12585 (uniscribe_check_otf): Remove unused variable `table'.
12586 (uniscribe_font_driver): Add missing initializers.
12587
dee091a3
JD
125882011-03-23 Julien Danjou <julien@danjou.info>
12589
12590 * term.c (Fsuspend_tty, Fresume_tty):
12591 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
12592 * window.c (temp_output_buffer_show):
12593 * insdel.c (signal_before_change):
12594 * frame.c (Fhandle_switch_frame):
12595 * fileio.c (Fdo_auto_save):
12596 * emacs.c (Fkill_emacs):
12597 * editfns.c (save_excursion_restore):
12598 * cmds.c (internal_self_insert):
12599 * callint.c (Fcall_interactively):
12600 * buffer.c (Fkill_all_local_variables):
12601 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
12602 Use Frun_hooks.
0f4a96b5 12603 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 12604 unconditionally since it does the check itself.
dee091a3 12605
2c520ab5 126062011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 12607
c9c49752
PE
12608 Fix more problems found by GCC 4.5.2's static checks.
12609
8abc3f12
PE
12610 * coding.c (encode_coding_raw_text): Avoid unnecessary test
12611 the first time through the loop, since we know p0 < p1 then.
12612 This also avoids a gcc -Wstrict-overflow warning.
12613
a2d26660
PE
12614 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
12615 leading to a memory leak, possible in functions like
12616 load_charset_map_from_file that can allocate an unbounded number
b12ef411 12617 of objects (Bug#8318).
a2d26660 12618
916c72e9
PE
12619 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
12620 that could (at least in theory) be that large.
12621
19ab8a18
PE
12622 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
12623 This is less likely to overflow, and avoids undefined behavior if
12624 overflow does occur. All callers changed. Use strtoul to scan
12625 for the unsigned long integer.
b7cbbd6f
PE
12626 (pint2hrstr): Simplify and tune code slightly.
12627 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 12628
f0641eff
PE
12629 * scroll.c (do_scrolling): Work around GCC bug 48228.
12630 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
12631
7f650bb9
PE
12632 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
12633 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
12634 (validate_x_resource_name): Simplify count usage.
12635 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 12636
37dd57d1
PE
12637 * fileio.c (Fcopy_file): Report error if fchown or fchmod
12638 fail (Bug#8306).
81e56e61 12639
699979fc 12640 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 12641
401bf9b4
PE
12642 * process.c (Fmake_network_process): Use socklen_t, not int,
12643 where POSIX says socklen_t is required in portable programs.
12644 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 12645 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
12646 (Fmake_network_process, server_accept_connection):
12647 (wait_reading_process_output, read_process_output):
12648 Likewise.
12649
b93aacde
PE
12650 * process.c: Rename or move locals to avoid shadowing.
12651 (list_processes_1, Fmake_network_process):
12652 (read_process_output_error_handler, exec_sentinel_error_handler):
12653 Rename or move locals.
4dc343ee 12654 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 12655 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 12656 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 12657 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 12658 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 12659
af8a867c 12660 Make tparam.h and terminfo.c consistent.
44f230aa
SM
12661 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
12662 Include tparam.h instead, since it declares them.
af8a867c
PE
12663 * cm.h (PC): Remove extern decl; tparam.h now does this.
12664 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
12665 * terminfo.c: Include tparam.h, to check interfaces.
12666 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
12667 (tparam): Adjust signature to match interface in tparam.h;
12668 this removes some undefined behavior. Check that outstring and len
12669 are zero, which they always are with Emacs.
12670 * tparam.h (PC, BC, UP): New extern decls.
12671
0248044d 12672 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 12673 (xftfont_open): Rename locals to avoid shadowing.
0248044d 12674
8ff096c1 12675 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
12676 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
12677 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 12678 (ftfont_list): Remove unused local.
49eaafba
PE
12679 (get_adstyle_property, ftfont_pattern_entity):
12680 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
12681 Rename locals to avoid shadowing.
8ff096c1 12682
e2be39f6
PE
12683 * xfont.c (xfont_list_family): Mark var as initialized.
12684
c9735e30
PE
12685 * xml.c (make_dom): Now static.
12686
8f5201ae
PE
12687 * composite.c (composition_compute_stop_pos): Rename local to
12688 avoid shadowing.
b246f932
PE
12689 (composition_reseat_it): Remove unused locals.
12690 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 12691 (composition_update_it): Mark var as initialized.
11b61122
PE
12692 (find_automatic_composition): Mark vars as initialized,
12693 with a FIXME (Bug#8290).
8f5201ae 12694
760fbc2c
PE
12695 character.h: Rename locals to avoid shadowing.
12696 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
12697 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
12698 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
12699 (BUF_DEC_POS): Be more systematic about renaming local temporaries
12700 to avoid shadowing.
12701
ff08eb85
PE
12702 * textprop.c (property_change_between_p): Remove; unused.
12703
fc7bf025
PE
12704 * intervals.c (interval_start_pos): Now static.
12705
235d7abc
PE
12706 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
12707
44f230aa
SM
12708 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
12709 Rename locals to avoid shadowing.
3e7d6594 12710
50060332
PE
12711 * sound.c (wav_play, au_play, Fplay_sound_internal):
12712 Fix pointer signedness.
d01f234b 12713 (alsa_choose_format): Remove unused local var.
c83b8872
PE
12714 (wav_play): Initialize a variable to 0, to prevent undefined
12715 behavior (Bug#8278).
50060332 12716
c4fc4e30
PE
12717 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
12718
918436ed
PE
12719 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
12720
c939f91b
PE
12721 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
12722 clobbering (Bug#8298).
b9c7f648
PE
12723 * sysdep.c (sys_subshell): Likewise.
12724 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 12725
6bd8c144
PE
12726 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
12727 This should get cleaned up, so that child_setup has the
12728 same signature on all platforms.
12729
7710357c 12730 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 12731 (relocate_fd): Rename locals to avoid shadowing.
7710357c 12732
c59da222
CY
127332011-03-22 Chong Yidong <cyd@stupidchicken.com>
12734
12735 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
12736 not to be necessary, and produces flickering.
12737
66b87493
GM
127382011-03-20 Glenn Morris <rgm@gnu.org>
12739
12740 * config.in: Remove file.
12741
45b6f6d5
JB
127422011-03-20 Juanma Barranquero <lekktu@gmail.com>
12743
12744 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
12745 are now in src/globals.h.
12746 (syms_of_minibuf): Remove spurious & from previous change.
12747
cd394be1 127482011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
12749
12750 * minibuf.c (completing-read-function): New variable.
12751 (completing-read-default): Rename from completing-read.
12752 (completing-read): Call completing-read-function.
12753
b14e3e21
CY
127542011-03-19 Juanma Barranquero <lekktu@gmail.com>
12755
12756 * xfaces.c (Fx_load_color_file):
12757 Read color file from absolute filename (bug#8250).
12758
f2b726e6
JB
127592011-03-19 Juanma Barranquero <lekktu@gmail.com>
12760
12761 * makefile.w32-in: Update dependencies.
12762
09f6ff02
EZ
127632011-03-17 Eli Zaretskii <eliz@gnu.org>
12764
12765 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
12766
29a6015a
PE
127672011-03-17 Paul Eggert <eggert@cs.ucla.edu>
12768
a3a6c54e
PE
12769 Fix more problems found by GCC 4.5.2's static checks.
12770
b766f867
PE
12771 * process.c (make_serial_process_unwind, send_process_trap):
12772 (sigchld_handler): Now static.
12773
be02381c
PE
12774 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
12775 That way, the code declares only the vars that it needs.
12776 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
12777 * s/cygwin.h (PTY_ITERATION): Likewise.
12778 * s/darwin.h (PTY_ITERATION): Likewise.
12779 * s/gnu-linux.h (PTY_ITERATION): Likewise.
12780
57048744
PE
12781 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
12782 * process.c (allocate_pty): Don't declare stb unless it's needed.
12783
7914961c 12784 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
12785 (CONSTANTLIM): Remove; unused.
12786 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
12787 Define only if needed.
7914961c 12788
b3967b18
PE
12789 * unexelf.c (unexec): Name an expression,
12790 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
12791 Use a different way to cause a compilation error if anyone uses
12792 n rather than nn, a way that does not involve shadowing.
73366a00 12793 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 12794
29a6015a
PE
12795 * deps.mk (unexalpha.o): Remove; unused.
12796
43cfc33e 12797 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 12798 * unexec.h: New file.
ce701a33
PE
12799 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
12800 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
12801 Depend on unexec.h.
12802 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
12803 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
12804 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 12805 Change as necessary to match prototype in unexec.h.
ce701a33 12806
01f44d5a
PE
12807 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
12808 shadowing.
4f63c6bb 12809 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 12810
a6670b0b
PE
12811 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
12812 Rename locals to avoid shadowing.
12813
cef2010d 12814 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 12815 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 12816
d4d7173a
PE
12817 * print.c (Fredirect_debugging_output): Fix pointer signedess.
12818
f08b802a
PE
12819 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
12820 warning when compiling print.c.
12821
3ddb0639
PE
12822 * font.c (font_unparse_fcname): Abort in an "impossible" situation
12823 instead of using an uninitialized var.
5ad03b97 12824 (font_sort_entities): Mark var as initialized.
3ddb0639 12825
170a2692
PE
12826 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
12827
e663c700
PE
12828 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
12829 pointers to constants.
89bc529a 12830 (font_parse_fcname): Remove unused vars.
7b81e2d0 12831 (font_delete_unmatched): Now static.
ea838e10 12832 (font_get_spec): Remove; unused.
13a547c6
PE
12833 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
12834 (font_update_drivers, Ffont_get_glyphs, font_add_log):
12835 Rename or move locals to avoid shadowing.
e663c700 12836
2a80c887 12837 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 12838 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 12839
1384fa33 12840 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 12841 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 12842
8b2c52e9
PE
12843 * alloc.c (mark_backtrace): Move decl from here ...
12844 * lisp.h: ... to here, so that it can be checked.
12845
475545b5 12846 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 12847 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
12848 (lisp_indirect_variable): Name an expression,
12849 to avoid gcc -Wbad-function-cast warning.
1faed8ae 12850 (Fdefvar): Rename locals to avoid shadowing.
475545b5 12851
b1349114 12852 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 12853 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 12854 Use const pointer when appropriate.
b1349114 12855
a2928364
PE
12856 * lisp.h (get_system_name, get_operating_system_release):
12857 Move decls here, to check interfaces.
12858 * process.c (get_operating_system_release): Move decl to lisp.h.
12859 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
12860 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
12861 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
12862 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
12863 (Fformat_time_string, Fencode_time, Finsert_char):
12864 (Ftranslate_region_internal, Fformat):
12865 Rename or remove local vars to avoid shadowing.
9710023e 12866 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 12867
a415e694
PE
12868 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
12869 avoid shadowing.
12870
8ef4622d
PE
12871 * lisp.h (eassert): Check that the argument compiles, even if
12872 ENABLE_CHECKING is not defined.
12873
946f9a5b
PE
12874 * data.c (Findirect_variable): Name an expression, to avoid
12875 gcc -Wbad-function-cast warning.
112396d6 12876 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 12877 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
12878 (Fmake_variable_buffer_local, Fmake_local_variable):
12879 Mark variables as initialized.
52746918 12880 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 12881
e5aab7e7 12882 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
12883 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
12884 Rename locals to avoid shadowing.
dff45157
PE
12885 (mark_stack): Move local variables into the #ifdef region where
12886 they're used.
7bc26fdb
PE
12887 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
12888 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
12889 needed otherwise.
12890 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
12891 (GC_STRING_CHARS): Remove; not used.
d40d4be1 12892 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 12893
e5aab7e7
PE
12894 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
12895 avoids undefined behavior in theory.
12896
4da60324
PE
12897 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
12898
88043301
PE
12899 Use functions, not macros, for up- and down-casing (Bug#8254).
12900 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12901 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
12902 to use the following functions instead of these macros.
12903 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
12904 EMACS_INT, since callers assume the returned value fits in int.
12905 (upcase1): Likewise, for UPCASE_TABLE.
12906 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 12907 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 12908 the race-condition problem in the old DOWNCASE.
88043301 12909
19ed5445
PE
12910 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
12911 Rename locals to avoid shadowing.
12912 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
12913 (regex_compile, re_search_2, re_match_2_internal):
12914 Remove unused local vars.
952db0d7
PE
12915 (FREE_VAR): Rewrite so as not to use empty "else",
12916 which gcc can warn about.
da053e48 12917 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
12918 (RETALLOC_IF): Define only if needed.
12919 (WORDCHAR_P): Likewise. This one is never needed, but is used
12920 only in a comment talking about a compiler bug, so put inside
12921 the #if 0 of that comment.
12922 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
12923 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
12924 Remove; unused.
19ed5445 12925
1f3561e4 12926 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
12927 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
12928 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 12929
ded6f8f7
PE
12930 * search.c (simple_search): Remove unused var.
12931
dbd37a95
PE
12932 * dired.c (compile_pattern): Move decl from here ...
12933 * lisp.h: ... to here, so that it can be checked.
12934 (struct re_registers): New forward decl.
12935
7e47afad
PE
12936 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
12937
85f24f61
PE
12938 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
12939 All uses changed.
12940 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
12941 Rename locals to avoid shadowing.
5671df8f 12942 (Fvertical_motion): Mark locals as initialized.
85f24f61 12943
181aa2be 12944 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 12945 (casify_region): Mark local as initialized.
181aa2be 12946
930d429c
PE
12947 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
12948
7082eac6
PE
12949 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
12950 New macros, so that the caller can use some names other than
12951 gcpro1, gcpro2, etc.
12952 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
12953 of the new macros.
12954 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
12955 argument, for consistency with GCPRO2_VAR, etc: it is now the
12956 prefix of the variable, not the variable itself. All uses
12957 changed.
38b2c076
PE
12958 * dired.c (directory_files_internal, file_name_completion):
12959 Rename locals to avoid shadowing.
12960
15206ed9
PE
12961 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
12962 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
12963 dired.c's scmp function, had undefined behavior.
12964 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12965 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
12966 * buffer.h: ... to here, because these macros use current_buffer,
12967 and the new implementation with inline functions needs to have
12968 current_buffer in scope now, rather than later when the macros
12969 are used.
12970 (downcase, upcase1): New static inline functions.
12971 (DOWNCASE, UPCASE1): Reimplement using these functions.
12972 This avoids undefined behavior in expressions like
12973 DOWNCASE (x) == DOWNCASE (y), which previously suffered
12974 from race conditions in accessing the global variables
12975 case_temp1 and case_temp2.
12976 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
12977 * lisp.h (case_temp1, case_temp2): Remove their decls.
12978 * character.h (ASCII_CHAR_P): Move from here ...
12979 * lisp.h: ... to here, so that the inline functions mentioned
12980 above can use them.
12981
4a6bea26
PE
12982 * dired.c (directory_files_internal_unwind): Now static.
12983
f14b7e14
PE
12984 * fileio.c (file_name_as_directory, directory_file_name):
12985 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
12986 Now static.
2893f146
PE
12987 (file_name_as_directory): Use const pointers when appropriate.
12988 (Fexpand_file_name): Likewise. In particular, newdir might
12989 point at constant storage, so make it a const pointer.
fd4ead52 12990 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
12991 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
12992 signedness issues.
f839df0c
PE
12993 (Fset_file_times, Finsert_file_contents, auto_save_error):
12994 Rename locals to avoid shadowing.
f14b7e14 12995
5716756e 12996 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
12997 (Ftry_completion, Fall_completions): Rename or remove locals
12998 to avoid shadowing.
5716756e 12999
b4c3046a
PE
13000 * marker.c (bytepos_to_charpos): Remove; unused.
13001
b45db522
PE
13002 * lisp.h (verify_bytepos, count_markers): New decls,
13003 so that gcc does not warn that these functions aren't declared.
13004
85876d07
PE
13005 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
13006 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 13007 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 13008 (copy_text): Remove unused local var.
85876d07 13009
03d78a21 13010 * filelock.c (within_one_second): Now static.
b3dd38ab 13011 (lock_file_1): Rename local to avoid shadowing.
03d78a21 13012
5df8f01b
PE
13013 * buffer.c (fix_overlays_before): Mark locals as initialized.
13014 (fix_start_end_in_overlays): Likewise. This function should be
13015 simplified by using pointers-to-pointers, but that's a different
13016 matter.
b1d876f1 13017 (switch_to_buffer_1): Now static.
8f54f30a
PE
13018 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
13019 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 13020
a70072c9 13021 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 13022 Fix pointer signedness issue.
edced198
PE
13023 (sys_subshell): Mark local as volatile if checking for lint,
13024 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 13025 (MAXPATHLEN): Define only if needed.
a70072c9 13026
a0977c44
PE
13027 * process.c (serial_open, serial_configure): Move decls from here ...
13028 * systty.h: ... to here, so that they can be checked.
13029
a884fdcc
PE
13030 * fns.c (get_random, seed_random): Move extern decls from here ...
13031 * lisp.h: ... to here, so that they can be checked.
13032
604efe86 13033 * sysdep.c (reset_io): Now static.
b8950c94 13034 (wait_for_termination_signal): Remove; unused.
604efe86 13035
38fc62d9
PE
13036 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
13037 (copy_keymap_item, append_key, push_text_char_description):
13038 Now static.
1004a21a 13039 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 13040 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
13041 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
13042 (describe_map_tree):
13043 Rename locals to avoid shadowing.
38fc62d9 13044
2f2650da
PE
13045 * keyboard.c: Declare functions static if they are not used elsewhere.
13046 (echo_char, echo_dash, cmd_error, top_level_2):
13047 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
13048 (read_char, kbd_buffer_get_event, make_lispy_position):
13049 (make_lispy_event, make_lispy_movement, apply_modifiers):
13050 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
13051 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
13052 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 13053 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 13054 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 13055
a053e86c 13056 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
13057 (mark_kboards): Move decl here ...
13058 * alloc.c (mark_kboards): ... from here.
a053e86c 13059
4752793e
PE
13060 * lisp.h (force_auto_save_soon): New decl.
13061
74f10ca7 13062 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
13063 (DEFINE_DUMMY_FUNCTION): New macro.
13064 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
13065 Use it.
c03cd23f
PE
13066 (main): Add casts to avoid warnings
13067 if GCC considers string literals to be constants.
74f10ca7 13068
022e70d4
PE
13069 * lisp.h (fatal_error_signal): Add decl, since it's exported.
13070
59d6fe83
PE
13071 * dbusbind.c: Pointer signedness fixes.
13072 (xd_signature, xd_append_arg, xd_initialize):
13073 (Fdbus_call_method, Fdbus_call_method_asynchronously):
13074 (Fdbus_method_return_internal, Fdbus_method_error_internal):
13075 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
13076 (Fdbus_register_signal): Use SSDATA when the context wants char *.
13077
78320123
PE
13078 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
13079 if GCC considers string literals to be constants.
49cebcca 13080 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 13081
35ac2a97
SM
130822011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
13083
fb103ca9
SM
13084 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
13085 (print_preprocess, print_object): New macro to fix last change.
13086
35ac2a97
SM
13087 * print.c (print_preprocess): Don't forget font objects.
13088
62973b41
JB
130892011-03-16 Juanma Barranquero <lekktu@gmail.com>
13090
13091 * emacs.c (USAGE3): Doc fixes.
13092
0e48bb22
AS
130932011-03-15 Andreas Schwab <schwab@linux-m68k.org>
13094
13095 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
13096 structure.
13097
7684e57b
JB
130982011-03-14 Juanma Barranquero <lekktu@gmail.com>
13099
13100 * lisp.h (VWindow_system, Qfile_name_history):
13101 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
13102 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
13103 (w32_system_caret_x, w32_system_caret_y): Declare extern.
13104
13105 * w32select.c: Don't #include "keyboard.h".
c96bbc66 13106 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
13107
13108 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
13109 * w32console.c (detect_input_pending, read_input_pending)
13110 (encode_terminal_code):
13111 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
13112 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
13113 (w32_system_caret_y, Qfile_name_history):
13114 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
13115 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
13116 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
13117 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
13118 * w32proc.c (Qlocal, report_file_error):
13119 * w32term.c (Vwindow_system, updating_frame):
13120 * w32uniscribe.c (initialized, uniscribe_font_driver):
13121 Remove unneeded extern declarations.
13122
2aa46d6c
CY
131232011-03-14 Chong Yidong <cyd@stupidchicken.com>
13124
c96bbc66 13125 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 13126
cffc6f3b
CY
131272011-03-13 Chong Yidong <cyd@stupidchicken.com>
13128
13129 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
13130 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
13131 These macros can no longer be used for assignment.
13132
44f230aa
SM
13133 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
13134 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
13135 (record_buffer_markers, fetch_buffer_markers): New functions for
13136 recording and fetching special buffer markers.
13137 (set_buffer_internal_1, set_buffer_temp): Use them.
13138
13139 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
13140
13141 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
13142
13143 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
13144 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
13145
13146 * xdisp.c (hscroll_window_tree):
13147 (reconsider_clip_changes): Use PT instead of BUF_PT.
13148
d251f04b
EZ
131492011-03-13 Eli Zaretskii <eliz@gnu.org>
13150
13151 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
13152 $(EMACS_ROOT)/lib/intprops.h.
13153
f0c77cd1
PE
131542011-03-13 Paul Eggert <eggert@cs.ucla.edu>
13155
3eca4629
PE
13156 Fix more problems found by GCC 4.5.2's static checks.
13157
7c86ee98
PE
13158 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
13159 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
13160 (xg_free_frame_widgets): Make it clear that a local variable is
13161 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
13162 (gdk_window_get_screen): Make it clear that this macro is needed
13163 only if USE_GTK_TOOLTIP.
1e5524e7
PE
13164 (int_gtk_range_get_value): New function, which avoids a diagnostic
13165 from gcc -Wbad-function-cast.
13166 (xg_set_toolkit_scroll_bar_thumb): Use it.
13167 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
13168 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
13169 (get_utf8_string, xg_get_file_with_chooser):
13170 Rename locals to avoid shadowing.
13171 (create_dialog): Move locals to avoid shadowing.
7c86ee98 13172
41729b81
PE
13173 * xgselect.c (xg_select): Remove unused var.
13174
f0c77cd1
PE
13175 * image.c (four_corners_best): Mark locals as initialized.
13176 (gif_load): Initialize transparent_p to zero (Bug#8238).
13177 Mark another local as initialized.
ec6cf4c6 13178 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 13179
ce0ad53d 13180 * image.c (clear_image_cache): Now static.
d5d5a617 13181 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 13182 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
13183 (x_edge_detection): Remove unnecessary cast that
13184 gcc -Wbad-function-cast diagnoses.
2037898d 13185 (gif_load): Fix pointer signedness.
6ae141d6
PE
13186 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
13187 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 13188
33383987 131892011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 13190
d32df629
PE
13191 Improve quality of tests for time stamp overflow.
13192 For example, without this patch (encode-time 0 0 0 1 1
13193 1152921504606846976) returns the obviously-bogus value (-948597
13194 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
13195 reports time overflow. See
13196 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
13197 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
13198 * editfns.c: Include limits.h and intprops.h.
13199 (TIME_T_MIN, TIME_T_MAX): New macros.
13200 (time_overflow): Move earlier, to before first use.
13201 (hi_time, lo_time): New functions, for an accurate test for
13202 out-of-range times.
13203 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
13204 (Fget_internal_run_time): Don't assume time_t fits in int.
13205 (make_time): Use list2 instead of Fcons twice.
13206 (Fdecode_time): More accurate test for out-of-range times.
13207 (check_tm_member): New function.
13208 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
13209 (lisp_time_argument): Don't rely on undefined left-shift and
13210 right-shift behavior when checking for time stamp overflow.
8be6f318 13211
fe31d94c
PE
13212 * editfns.c (time_overflow): New function, refactoring common code.
13213 (Fformat_time_string, Fdecode_time, Fencode_time):
13214 (Fcurrent_time_string): Use it.
13215
8be6f318
PE
13216 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
13217 * dired.c (make_time): Move to ...
13218 * editfns.c (make_time): ... here.
13219 * systime.h: Note the move.
13220
09d9db2c 132212011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 13222
126bc0dc
YM
13223 * fringe.c (update_window_fringes): Remove unused variables.
13224
c47cbdfd
YM
13225 * unexmacosx.c (copy_data_segment): Also copy __got section.
13226 (Bug#8223)
13227
7ac80be9
EZ
132282011-03-12 Eli Zaretskii <eliz@gnu.org>
13229
c96bbc66 13230 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
13231 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
13232 Constify `char *' arguments and their references according to
13233 prototypes in tparam.h.
13234
ecb0f94d 13235 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 13236
7ac80be9
EZ
13237 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
13238 Adapt all references accordingly.
13239
13240 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
13241
ef1fd07e
TT
132422011-03-11 Tom Tromey <tromey@redhat.com>
13243
13244 * buffer.c (syms_of_buffer): Remove obsolete comment.
13245
7ef4b50c
EZ
132462011-03-11 Eli Zaretskii <eliz@gnu.org>
13247
13248 * termhooks.h (encode_terminal_code): Declare prototype.
13249
13250 * msdos.c (encode_terminal_code): Don't declare prototype.
13251
13252 * term.c (encode_terminal_code): Now external again, used by
13253 w32console.c and msdos.c.
13254
44f230aa
SM
13255 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
13256 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 13257
4b1ec863 132582011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 13259
1714f52b 13260 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 13261
4b1ec863
PE
13262 * fringe.c (update_window_fringes): Mark locals as initialized
13263 (Bug#8227).
13264 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 13265
524c7aa6
PE
13266 * alloc.c (mark_fringe_data): Move decl from here ...
13267 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
13268 to check its interface.
13269 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
13270
a5c0af81 13271 * fontset.c (free_realized_fontset): Now static.
7519b8cd 13272 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 13273 (fontset_font): Mark local as initialized.
a9a06e0b 13274 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 13275
b4716021
PE
13276 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
13277
811e9bac 13278 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 13279 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
13280 (x_own_selection, Fx_disown_selection_internal): Rename locals
13281 to avoid shadowing.
13282 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 13283
7e3ab302
PE
13284 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
13285 so that the caller can use some name other than gcpro1.
13286 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
13287 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13288 (Fx_backspace_delete_keys_p):
13289 Use them to avoid shadowing, and rename vars to avoid shadowing.
13290 (x_decode_color, x_set_name, x_window): Now static.
6b437900 13291 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 13292 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
13293 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
13294 Remove unused locals.
7e3ab302
PE
13295 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13296 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
13297 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
13298 macros.
f78faa98 13299
e2b13473
PE
13300 * xterm.h (x_mouse_leave): New decl.
13301
77f23912
PE
13302 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
13303 Remove unused functions.
cdf4ba58
PE
13304 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
13305 (x_calc_absolute_position): Now static.
7411c686 13306 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 13307 Don't declare local "event" unless it's used.
ed7bf3a5
PE
13308 (x_iconify_frame, x_free_frame_resources): Don't declare locals
13309 unless they are used.
38d0b34a
PE
13310 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
13311 (x_fatal_error_signal): Remove; not used.
a6067996
PE
13312 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
13313 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
13314 (x_error_catcher, x_connection_closed, x_error_handler):
13315 (x_error_quitter, xembed_send_message, x_iconify_frame):
13316 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 13317 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 13318 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 13319
44f230aa
SM
13320 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
13321 Rename or move locals to avoid shadowing.
6b463e58 13322 (tty_defined_color, merge_face_heights): Now static.
5967d051 13323 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
13324 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
13325 does not deduce is never used uninitialized.
73719eba
PE
13326 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
13327 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 13328
426994c3 13329 * terminal.c (store_terminal_param): Now static.
5489860b 13330
032f1620 13331 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 13332 (set_frame_menubar): Remove unused local.
d4323972 13333 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
13334 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
13335 since they might point to immutable storage.
281585b0
PE
13336 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
13337 since it's unused otherwise.
032f1620 13338
367c19e5 13339 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 13340 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
13341 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
13342 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 13343 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
13344 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
13345 does not deduce are never used uninitialized.
70739cbe 13346
07b48fa9
PE
13347 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
13348
8868a238 13349 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
13350 * window.c (window_loop, size_window):
13351 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 13352
7e5cf297 13353 * window.c (display_buffer): Now static.
d6550a9f
PE
13354 (size_window): Mark variables that gcc -Wuninitialized
13355 does not deduce are never used uninitialized.
a586633d
PE
13356 * window.h (check_all_windows): New decl, to forestall
13357 gcc -Wmissing-prototypes diagnostic.
5b555da1 13358 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 13359
f6095868
PE
13360 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
13361 shadowing.
13362 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
13363 Include <limits.h>.
13364 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
13365 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
13366 (load_charset_map): Mark variables that gcc -Wuninitialized
13367 does not deduce are never used uninitialized.
53df7c11 13368 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 13369
f38b440c
PE
13370 * coding.c (coding_set_source, coding_set_destination):
13371 Use "else { /* comment */ }" rather than "else /* comment */;"
13372 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
13373 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
13374 a block, when the outer 'i' will do.
13375 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
13376 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
13377 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
13378 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
13379 (Fdecode_sjis_char, Fdefine_coding_system_internal):
13380 Rename locals to avoid shadowing.
13381 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
13382 * coding.c (emacs_mule_char, encode_invocation_designation):
13383 Now static, since they're not used elsewhere.
413bb2db 13384 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 13385 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
13386 (decode_coding_emacs_mule): Mark variables that gcc
13387 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
13388 (detect_coding_iso_2022): Initialize a local variable that might
13389 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 13390 this initialization is needed. (Bug#8211)
5f58e762
PE
13391 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
13392 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
13393 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
13394 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
13395 Remove unused macros.
f38b440c 13396
232b38b9 13397 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 13398 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 13399 * character.c (string_count_byte8): Likewise.
232b38b9 13400
fb90da1b
PE
13401 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
13402 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
13403
fb93dbc2
PE
13404 * chartab.c (copy_sub_char_table): Now static, since it's not used
13405 elsewhere.
5c156ace
PE
13406 (sub_char_table_ref_and_range, char_table_ref_and_range):
13407 Rename locals to avoid shadowing.
bbcd0949 13408 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 13409
7d3b3862 13410 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 13411 (BIDI_BOB): Remove unused macro.
7d3b3862 13412
6be7d3da
PE
13413 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
13414 deduce are never used uninitialized.
c2ed9c8b 13415 * term.c (encode_terminal_code): Likewise.
6be7d3da 13416
75f8807f 13417 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 13418
50938595
PE
13419 * tparam.h: New file.
13420 * term.c, tparam.h: Include it.
13421 * deps.mk (term.o, tparam.o): Depend on tparam.h.
13422 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
13423 Move these decls to tparam.h, and make them agree with what
13424 is actually in tparam.c. The previous trick of using incompatible
13425 decls in different modules does not conform to the C standard.
13426 All callers of tparam changed to use tparam's actual API.
13427 * tparam.c (tparam1, tparam, tgoto):
13428 Use const pointers where appropriate.
13429
fbceeba2
PE
13430 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
13431 * cm.h (struct cm): Likewise.
13432 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
13433 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
13434 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
13435 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
13436 (turn_on_face, init_tty): Likewise.
13437 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 13438
7f3f1250
PE
13439 * term.c (term_mouse_position): Rename local to avoid shadowing.
13440
e6ca6543
PE
13441 * alloc.c (mark_ttys): Move decl from here ...
13442 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
13443
c40f8d15
AS
134442011-03-11 Andreas Schwab <schwab@linux-m68k.org>
13445
13446 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
13447
cfe0661d
JB
134482011-03-09 Juanma Barranquero <lekktu@gmail.com>
13449
13450 * search.c (compile_pattern_1): Remove argument regp, unused since
13451 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
13452 (compile_pattern): Don't pass it.
13453
0afb4571
J
134542011-03-08 Jan Djärv <jan.h.d@swipnet.se>
13455
13456 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
13457 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
13458 for ! HAVE_GTK3.
13459 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
13460
13461 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
13462
13463 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
13464 gdk_window_get_screen, gdk_window_get_geometry,
13465 gdk_x11_window_lookup_for_display and GDK_KEY_g.
13466 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
13467 (xg_get_pixbuf_from_pixmap): New function.
13468 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
13469 to Pixmap, take frame as parameter, remove GdkColormap parameter.
13470 Call xg_get_pixbuf_from_pixmap instead of
13471 gdk_pixbuf_get_from_drawable.
13472 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
13473 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
13474 (xg_check_special_colors): Use GtkStyleContext and its functions
13475 for HAVE_GTK3.
13476 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
13477 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
13478 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
13479 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
13480 Call gtk_widget_get_preferred_size.
0afb4571
J
13481 (xg_frame_resized): gdk_window_get_geometry only takes 5
13482 parameters.
44f230aa
SM
13483 (xg_win_to_widget, xg_event_is_for_menubar):
13484 Call gdk_x11_window_lookup_for_display.
0afb4571
J
13485 (xg_set_widget_bg): New function.
13486 (delete_cb): New function.
895009e1 13487 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 13488 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
13489 (xg_set_background_color): Call xg_set_widget_bg.
13490 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
13491 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
13492 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
13493 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
13494 if ! HAVE_GTK3.
13495 (update_frame_tool_bar): Call gtk_widget_hide.
13496 (xg_initialize): Use GDK_KEY_g.
13497
13498 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
13499 if ! HAVE_GTK3
13500 (x_session_initialize): Call gdk_x11_set_sm_client_id.
13501
13502 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
13503 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
13504 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
13505
1c2cc4ef
JB
135062011-03-08 Juanma Barranquero <lekktu@gmail.com>
13507
13508 * w32xfns.c (select_palette): Check success of RealizePalette against
13509 GDI_ERROR, not zero.
13510
33383987 13511See ChangeLog.11 for earlier changes.
aac0c6e3
MR
13512
13513;; Local Variables:
13514;; coding: utf-8
aac0c6e3
MR
13515;; End:
13516
2f097256 13517 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
13518
13519 This file is part of GNU Emacs.
13520
13521 GNU Emacs is free software: you can redistribute it and/or modify
13522 it under the terms of the GNU General Public License as published by
13523 the Free Software Foundation, either version 3 of the License, or
13524 (at your option) any later version.
13525
13526 GNU Emacs is distributed in the hope that it will be useful,
13527 but WITHOUT ANY WARRANTY; without even the implied warranty of
13528 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13529 GNU General Public License for more details.
13530
13531 You should have received a copy of the GNU General Public License
13532 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.