Minor adjustments to interning code.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
e8df9267
DA
12012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
2
3 Minor adjustments to interning code.
4 * lisp.h (intern, intern_c_string): Redefine as static inline
5 wrappers for intern_1 and intern_c_string_1, respectively.
6 (intern_1, intern_c_string_1): Rename prototypes.
7 * lread.c (intern_1, intern_c_string_1): Simplify Vobarray checking.
8 * font.c (font_intern_prop): Likewise. Adjust comment.
9 * w32font.c (intern_font_name): Likewise.
10
34348bd4
AS
112012-07-11 Andreas Schwab <schwab@linux-m68k.org>
12
d96a1e0c
AS
13 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
14
34348bd4
AS
15 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
16 of Fcar/Fcdr if possible.
17 * font.c (check_otf_features): Likewise.
18 * fontset.c (Fnew_fontset): Likewise.
19 * gnutls.c (Fgnutls_boot): Likewise.
20 * minibuf.c (read_minibuf): Likewise.
21 * msdos.c (IT_set_frame_parameters): Likewise.
22 * xmenu.c (Fx_popup_dialog): Likewise.
23 * w32menu.c (Fx_popup_dialog): Likewise.
24
c8add24e
GM
252012-07-11 Glenn Morris <rgm@gnu.org>
26
09f4e3b0
GM
27 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
28 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
29
172bedef
GM
30 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
31 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
32 Move CLASH_DETECTION to configure.
33
249685df
GM
34 * s/gnu.h: Remove file, which is now empty.
35
c8add24e
GM
36 * s/gnu.h, s/gnu-linux.h:
37 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
38
b41253a3
JW
392012-07-11 John Wiegley <johnw@newartisans.com>
40
41 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
42 function attribute, so we only use it if it exists in the
43 compiler.
44
d923b542
DA
452012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
46
47 Avoid call to strlen in fast_c_string_match_ignore_case.
48 * search.c (fast_c_string_match_ignore_case): Change to use
49 length argument. Adjust users accordingly.
50 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
51
5ebbef1d
PE
522012-07-11 Paul Eggert <eggert@cs.ucla.edu>
53
bb352260
PE
54 Assume mkdir, rmdir.
55 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
56 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
57
57054ddd
PE
58 Assume rename.
59 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
60
b747d3f7
PE
61 Assume perror.
62 * s/hpux10-20.h (HAVE_PERROR): Remove.
63 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
64 Remove dummy definition, as this problem was obsolete long ago.
65
5ebbef1d
PE
66 Assume strerror.
67 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
68
984e7f30
DA
692012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
70
71 Avoid calls to strlen in font processing functions.
72 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
d923b542 73 (font_open_by_name): Change to use length argument. Adjust
984e7f30 74 users accordingly.
d923b542
DA
75 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
76 Adjust prototypes.
77 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
78 Change to return ptrdiff_t.
984e7f30
DA
79 (xfont_list_pattern, xfont_match): Use length returned by
80 xfont_decode_coding_xlfd.
81 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
82
20e94fdd
GM
832012-07-11 Glenn Morris <rgm@gnu.org>
84
9d596af3
GM
85 * s/darwin.h, s/freebsd.h, s/netbsd.h:
86 Move DONT_REOPEN_PTY to configure.
87
20e94fdd
GM
88 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
89 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
90
e99a530f
PE
912012-07-10 Paul Eggert <eggert@cs.ucla.edu>
92
22ffb973
PE
93 Remove "#define unix" that is no longer needed (Bug#11905).
94 * s/aix4-2.h (unix): Remove; no longer needed.
95
e9a9ae03
PE
96 EMACS_TIME simplification (Bug#11875).
97 This replaces macros (which typically do not work in GDB)
98 with functions, typedefs and enums, making the code easier to debug.
99 The functional style also makes code easier to read and maintain.
100 * systime.h: Include <sys/time.h> on all hosts, not just if
101 WINDOWSNT, since 'struct timeval' is needed in general.
102 (EMACS_TIME): Now a typedef, not a macro.
103 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
104 not macros.
105 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
106 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
107 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
108 (EMACS_TIME_LE): Now functions, not macros.
109 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
110 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
111 which are not functions. All uses rewritten to use:
112 (make_emacs_time): New function.
113 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
114 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
115 not functions. All uses rewritten to use the following, respectively:
116 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
117 (add_emacs_time, sub_emacs_time): New functions.
118 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
119 * fileio.c (Fcopy_file):
120 * xterm.c (XTflash): Get the current time closer to when it's used.
121 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
122
ffacb126
PE
123 * bytecode.c (targets): Suppress -Woverride-init warnings.
124
e99a530f
PE
125 Simplify by avoiding confusing use of strncpy etc.
126 * doc.c (Fsnarf_documentation):
127 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
128 * frame.c (Fmake_terminal_frame):
129 * gtkutil.c (get_utf8_string):
130 * lread.c (openp):
131 * nsmenu.m (ns_update_menubar):
132 * regex.c (regerror):
133 Prefer memcpy to strncpy and strncat when either will do.
134 * fileio.c (Fsubstitute_in_file_name):
135 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
136 (menu_separator_name_p):
137 * nsmenu.m (ns_update_menubar):
138 Prefer memcmp to strncmp when either will do.
139 * nsterm.m: Include <ftoastr.h>.
140 (ns_get_color):
141 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
142 Prefer snprintf to strncpy.
143 * nsterm.m (ns_term_init):
144 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
145 * nsterm.m (ns_term_init):
146 Avoid the need for strncpy, by using build_string or
147 make_unibyte_string directly. Use dtoastr, not snprintf.
148 * process.c (Fmake_network_process): Diagnose service names that
149 are too long, rather than silently truncating them or creating
150 non-null-terminated names.
151 (Fnetwork_interface_info): Likewise, for interface names.
152 * sysdep.c (system_process_attributes) [GNU_LINUX]:
153 Prefer sprintf to strncat.
154 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
155 Prefer vsnprintf to vsprintf + strncpy.
156
c59592b3
GM
1572012-07-10 Glenn Morris <rgm@gnu.org>
158
159 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
160 Clarify fallback case.
161
7d7bbefd
DA
1622012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
163
164 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
165 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
166 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 167 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
168 where argument type is known to be a Lisp_Cons.
169
3a4c8000
TT
1702012-07-10 Tom Tromey <tromey@redhat.com>
171
172 * bytecode.c (BYTE_CODE_THREADED): New macro.
173 (BYTE_CODES): New macro. Replaces all old byte-code defines.
174 (enum byte_code_op): New type.
175 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
176 (exec_byte_code): Use them. Use token threading when applicable.
177
2a0213a6
DA
1782012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
179
180 Optimize pure C strings initialization.
181 * lisp.h (make_pure_string): Fix prototype.
182 (build_pure_c_string): New function, defined as static inline. This
183 provides a better opportunity to optimize away calls to strlen when
184 the function is called with compile-time constant argument.
185 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
186 argument, adjust users accordingly. Use build_pure_c_string where
187 appropriate.
188 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
189 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
190 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
191
cb1caeaf
DA
1922012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
193
194 Avoid calls to strlen in miscellaneous functions.
195 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
196 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
197 * lread.c (openp): Likewise.
198
c293e30c
DA
1992012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
200
201 Avoid calls to strlen in path processing functions.
202 * fileio.c (file_name_as_directory): Add comment. Change to add
203 srclen argument and return the length of result. Adjust users
204 accordingly.
205 (directory_file_name): Fix comment. Change to add srclen argument,
cb1caeaf 206 swap 1st and 2nd arguments to obey the common convention. Adjust
c293e30c
DA
207 users accordingly.
208 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
209
9e059e3f
GM
2102012-07-10 Glenn Morris <rgm@gnu.org>
211
d02eb359
GM
212 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
213 Move PENDING_OUTPUT_COUNT definition to configure.
214
882cf227
GM
215 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
216 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
217 * s/gnu.h (DATA_START): Move definitions to configure.
218
af6e839f
GM
219 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
220 We include usg5-4-common.h, which defines them both.
221
40289a12
GM
222 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
223 O_RDONLY already includes it).
224
9e059e3f
GM
225 Stop ns builds setting the EMACSLOADPATH environment variable.
226 * nsterm.m (ns_load_path): Rename from ns_init_paths.
227 Now it does not set EMACSLOADPATH, just returns the load-path string.
228 * nsterm.h: Update accordingly.
229 * lread.c [HAVE_NS]: Include nsterm.h.
230 (init_lread) [HAVE_NS]: Use ns_load_path.
231 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
232
7c4e8ec0
GM
2332012-07-09 Glenn Morris <rgm@gnu.org>
234
d4f600ff
GM
235 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
236 since the included bsd-common.h does so.
237
cbb31951
GM
238 Stop ns builds setting the EMACSPATH environment variable.
239 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
240 (ns_init_paths): Do not set EMACSPATH.
241 * nsterm.h (ns_exec_path): Add it.
242 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
243 Use ns_exec_path.
244
7c4e8ec0
GM
245 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
246
26bccfae
PE
2472012-07-09 Paul Eggert <eggert@cs.ucla.edu>
248
a0bee46f
PE
249 * process.c (wait_reading_process_output): 'waitchannels' was unset
250 when read_kbd || !NILP (wait_for_cell); fix this.
251
5994c183
PE
252 Add GCC-style 'const' attribute to functions that can use it.
253 * character.h (char_resolve_modifier_mask):
254 * keyboard.h (make_ctrl_char):
255 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
256 (init_character_once, next_almost_prime, init_fns, init_image)
257 (flush_pending_output, init_sound):
258 * mem-limits.h (start_of_data):
259 * menu.h (finish_menu_items):
260 Add ATTRIBUTE_CONST.
261 * emacs.c (DEFINE_DUMMY_FUNCTION):
262 Declare the dummy function with ATTRIBUTE_CONST.
263 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
264 Add decls with ATTRIBUTE_CONST.
265
26bccfae
PE
266 Minor improvements to make_formatted_string.
267 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
268 where int is good enough, as vsprintf returns an int.
269 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
270
a8290ec3
DA
2712012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
272
273 Use make_formatted_string to avoid double length calculation.
274 * lisp.h (make_formatted_string): New prototype.
275 * alloc.c (make_formatted_string): New function.
276 * buffer.c (Fgenerate_new_buffer_name): Use it.
277 * dbus.c (syms_of_dbusbind): Likewise.
278 * editfns.c (Fcurrent_time_zone): Likewise.
279 * filelock.c (get_boot_time): Likewise.
280 * frame.c (make_terminal_frame, set_term_frame_name)
281 (x_report_frame_params): Likewise.
282 * image.c (gs_load): Likewise.
283 * minibuf.c (get_minibuffer): Likewise.
284 * msdos.c (dos_set_window_size): Likewise.
285 * process.c (make_process): Likewise.
286 * xdisp.c (ensure_echo_area_buffers): Likewise.
287 * xsettings.c (apply_xft_settings): Likewise.
288
d01ba2f1
GM
2892012-07-09 Glenn Morris <rgm@gnu.org>
290
291 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
292 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
293 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
294 * nsterm.h (ns_etc_directory): Add it.
295 * callproc.c [HAVE_NS]: Include nsterm.h.
296 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
297
f1f924b6
DA
2982012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
299
300 Move marker debugging code under MARKER_DEBUG.
301 * marker.c (MARKER_DEBUG): Move marker debugging code under
302 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
303 for bootstrap with --enable-checking (~3x slowdown reported
304 by Juanma Barranquero <lekktu@gmail.com>).
305 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
306
ab531b66
PE
3072012-07-08 Paul Eggert <eggert@cs.ucla.edu>
308
309 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
310 See <http://bugs.gnu.org/11825#29>.
311
c4b3bc8a
EZ
3122012-07-08 Eli Zaretskii <eliz@gnu.org>
313
314 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
315 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
316 (display_line): Add commentary about displaying truncation glyphs
317 on GUI frames.
318 (produce_special_glyphs): Move here from term.c.
319
320 * term.c (produce_special_glyphs): Move to xdisp.c.
321
322 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
323 section.
c4b3bc8a 324
b676b881
AS
3252012-07-07 Andreas Schwab <schwab@linux-m68k.org>
326
f17c5273
AS
327 * xdisp.c (display_line): Avoid warning about implicit declaration
328 of FRAME_FONT.
329
298819b9
AS
330 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
331
b676b881
AS
332 * lisp.h: Remove empty conditional.
333
6045c4fd
PE
3342012-07-07 Paul Eggert <eggert@cs.ucla.edu>
335
b3350bf9
PE
336 * lread.c (load_path_check): Now static.
337
6045c4fd
PE
338 Fix some minor --with-ns problems found by static checking.
339 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
340 (x_set_font) [!HAVE_X_WINDOWS]:
341 * image.c (xpm_load_image) [HAVE_NS]:
342 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
343 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
344 Remove unused local.
345 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
346 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
347 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
348 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
349 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
350 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
351 Fix pointer signedness problem.
352 * xfaces.c (FRAME_X_FONT_TABLE):
353 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
354
929e7845
GM
3552012-07-07 Glenn Morris <rgm@gnu.org>
356
357 * lread.c (load_path_check): New function, split from init_lread.
358 (init_lread): Reorganize. Motivation:
359 If EMACSLOADPATH is set, check/warn about that rather than the
360 defaults, which we are not going to use. Hence we can remove
361 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
362 Don't warn if site-lisp directories are missing.
363 If not installed, start from a blank load-path, since
364 PATH_LOADSEARCH refers to the eventual installation directories.
365
58dd0aa4
EZ
3662012-07-07 Eli Zaretskii <eliz@gnu.org>
367
368 Support truncation and continuation glyphs on GUI frames, when
369 fringes are disabled. (Bug#11832)
370 * xdisp.c (init_iterator): Get dimensions of truncation and
371 continuation glyphs even if on GUI frames. Adjust
372 it->last_visible_x on GUI frames when the left or right fringes,
373 or both, are absent.
374 (start_display, move_it_in_display_line_to): Handle the case of a
375 GUI frame without a fringe to display continuation or truncation
376 glyphs.
377 (insert_left_trunc_glyphs): Support GUI frames: make sure
378 truncation glyphs overwrite enough glyphs from the current line to
379 have sufficient space in pixels.
380 (display_line): Support truncation and continuation glyphs on GUI
381 frames. If some spare pixels are left on the line after inserting
382 the truncation glyphs, fill that space with a stretch glyph of a
383 suitably computed width.
384
385 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
386 produce_glyphs, to support GUI sessions.
387
31571fd7
PE
3882012-07-07 Paul Eggert <eggert@cs.ucla.edu>
389
5a16b9bc
PE
390 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
391
f3047c75
PE
392 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
393
31571fd7
PE
394 Do not require float-time's arg to fit in time_t (Bug#11825).
395 This works better on hosts where time_t is unsigned, and where
396 float-time is applied to the (negative) difference between two times.
397 * editfns.c (decode_time_components): Last arg is now double *,
398 not int *, and means to store all the result as a double, without
399 worrying about whether the seconds part fits in time_t.
400 All callers changed.
401 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
402 All callers changed.
403 (Ffloat_time): Do not fail merely because the specified time falls
404 outside of time_t range.
405
4516fbef
GM
4062012-07-07 Glenn Morris <rgm@gnu.org>
407
408 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
409 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
410 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
411
07adc2c6
JB
4122012-07-07 Juanma Barranquero <lekktu@gmail.com>
413
414 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
415 Update dependencies.
416
417 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
418
fd573f31
PE
4192012-07-06 Paul Eggert <eggert@cs.ucla.edu>
420
fee5959d
PE
421 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
422 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
423 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
424 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
425 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
426 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
427
fd573f31
PE
428 * xfont.c (compare_font_names): Redo to omit the need for casts.
429
ddadbc0e
AS
4302012-07-06 Andreas Schwab <schwab@linux-m68k.org>
431
fca8d6b6
AS
432 * xfns.c (Fx_change_window_property): Doc fix.
433 * w32fns.c (Fx_change_window_property): Doc fix.
434
ddadbc0e
AS
435 * w32fns.c (Fx_window_property): Accept the same arguments as the
436 X Windows version. Doc fix.
437 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
438
f247498e
JB
4392012-07-06 Juanma Barranquero <lekktu@gmail.com>
440 Eli Zaretskii <eliz@gnu.org>
441
442 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
443 Windows-specific code from nt/config.nt moved here.
444 Obsolete settings removed.
445
216ee680
PE
4462012-07-06 Paul Eggert <eggert@cs.ucla.edu>
447
448 * process.c: Avoid unnecessary calls to gettime.
449 (wait_reading_process_output): Don't get the time of day
450 when gobbling data immediately and not waiting, as there's no need
451 for it in that case. This removes a FIXME.
452
bdd091e4
JD
4532012-07-06 Jan Djärv <jan.h.d@swipnet.se>
454
455 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
456 is defined (Bug#11768).
457
9d44f8ce
DA
4582012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
459
460 Fix marker debugging code.
461 * marker.c (byte_char_debug_check): Do not perform the check
462 if buffer is not multibyte.
090bd7cb
JB
463 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
464 Call byte_char_debug_check with correct arguments.
9d44f8ce 465
90fc4786
DA
4662012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
467
468 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
469 * marker.c (byte_char_debug_check, count_markers):
470 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
471 (byte_debug_flag): Remove.
472 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
473 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
474
7b7ae965
DA
4752012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
476
4e57b342
DA
477 Avoid code repetition in marker-related functions.
478 * marker.c (attach_marker): New function.
479 (Fset_marker, set_marker_restricted, set_marker_both)
480 (set_marker_restricted_both): Use it.
481 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
482 Consistently rename charno to charpos.
483 (marker_position): Add eassert.
484 (marker_byte_position): Convert to eassert.
485
4862012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
487
488 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 489 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 490 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 491
657924ff
DA
4922012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
493
494 Introduce fast path for the widely used marker operation.
495 * alloc.c (build_marker): New function.
496 * lisp.h (build_marker): New prototype.
497 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
498 * composite.c (autocmp_chars): Likewise.
499 * editfns.c (buildmark): Remove.
500 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
501 (save_restriction_save): Use build_marker.
502 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
503 * window.c (save_window_save): Likewise.
504
041a49a6
DA
5052012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
506
507 Do not use Fdelete_overlay in delete_all_overlays
508 to avoid redundant calls to unchain_overlay.
509 * buffer.c (drop_overlay): New function.
510 (delete_all_overlays, Fdelete_overlay): Use it.
511 * minibuf.c (get_minibuffer): Fix comment.
512
7dca65a4
PE
5132012-07-06 Paul Eggert <eggert@cs.ucla.edu>
514
515 Port to OpenBSD 5.1 amd64.
516 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
517 This is needed for OpenBSD, and should be harmless on all BSD systems.
518 Also, include <sys/sysctl.h>, as it should be available on all
519 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
520 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
521 use p_pid member, not kp_proc.pid.
522
8eb876e2
GM
5232012-07-06 Glenn Morris <rgm@gnu.org>
524
525 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
526
38182d90
PE
5272012-07-05 Paul Eggert <eggert@cs.ucla.edu>
528
529 More xmalloc and related cleanup.
530 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
531 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
532 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
533 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
534 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
535 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
536 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
537 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
538 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
539 * xterm.c:
540 Omit needless casts involving void * pointers and allocation.
541 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
542 as the former is more robust if P's type is changed.
543 Prefer xzalloc to xmalloc + memset 0.
544 Simplify malloc-or-realloc to realloc.
545 Don't worry about xmalloc returning a null pointer.
546 Prefer xstrdup to xmalloc + strcpy.
547 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
548 growing it.
549 * keyboard.c (apply_modifiers_uncached): Prefer local array to
550 alloca of a constant.
551
6dd5a677
EZ
5522012-07-05 Eli Zaretskii <eliz@gnu.org>
553
554 * xdisp.c (display_line): Fix horizontal pixel coordinates when
555 hscroll is larger than the line width. Fixes long and futile
556 looping inside extend_face_to_end_of_line (on a TTY) producing
557 glyphs that are not needed and thrown away.
558
6b312f0f
DA
5592012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
560
561 * marker.c (set_marker_restricted_both): Simplify by using
562 clip_to_bounds.
563
f520ef9b
PE
5642012-07-05 Paul Eggert <eggert@cs.ucla.edu>
565
566 * editfns.c (region_limit): Simplify by using clip_to_bounds.
567
383b7c95
JD
5682012-07-05 Jan Djärv <jan.h.d@swipnet.se>
569
570 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
571 not defined (Bug#11768).
572 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
573 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
574 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
575 followed by gtk_box_set_homogeneous (Bug#11768).
576 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
577 (update_theme_scrollbar_width, xg_create_scroll_bar):
578 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
579 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
580 (is_box_type): New function (Bug#11768).
581 (xg_tool_item_stale_p): Call is_box_type.
5293d758 582 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
583 with default display (Bug#11768).
584
d6e7bf45
EZ
5852012-07-05 Eli Zaretskii <eliz@gnu.org>
586
587 * xdisp.c (window_hscroll_limited): New function.
588 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
589 coordinates when window's hscroll is set to insanely large
590 values. (Bug#11857)
591
431391ec
JB
5922012-07-05 Juanma Barranquero <lekktu@gmail.com>
593
594 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
595 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
596
23f86fce
DA
5972012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
598
599 Cleanup xmalloc.
600 * lisp.h (xzalloc): New prototype. Omit needless casts.
601 * alloc.c (xzalloc): New function. Omit needless casts.
602 * charset.c: Omit needless casts. Convert all calls to
603 xmalloc with following memset to xzalloc.
604 * dispnew.c: Likewise.
605 * fringe.c: Likewise.
606 * image.c: Likewise.
607 * sound.c: Likewise.
608 * term.c: Likewise.
609 * w32fns.c: Likewise.
610 * w32font.c: Likewise.
611 * w32term.c: Likewise.
612 * xfaces.c: Likewise.
613 * xfns.c: Likewise.
614 * xterm.c: Likewise.
615 * atimer.c: Omit needless casts.
616 * buffer.c: Likewise.
617 * callproc.c: Likewise.
618 * ccl.c: Likewise.
619 * coding.c: Likewise.
620 * composite.c: Likewise.
621 * doc.c: Likewise.
622 * doprnt.c: Likewise.
623 * editfns.c: Likewise.
624 * emacs.c: Likewise.
625 * eval.c: Likewise.
626 * filelock.c: Likewise.
627 * fns.c: Likewise.
628 * gtkutil.c: Likewise.
629 * keyboard.c: Likewise.
630 * lisp.h: Likewise.
631 * lread.c: Likewise.
632 * minibuf.c: Likewise.
633 * msdos.c: Likewise.
634 * print.c: Likewise.
635 * process.c: Likewise.
636 * region-cache.c: Likewise.
637 * search.c: Likewise.
638 * sysdep.c: Likewise.
639 * termcap.c: Likewise.
640 * terminal.c: Likewise.
641 * tparam.c: Likewise.
642 * w16select.c: Likewise.
643 * w32.c: Likewise.
644 * w32reg.c: Likewise.
645 * w32select.c: Likewise.
646 * w32uniscribe.c: Likewise.
647 * widget.c: Likewise.
648 * xdisp.c: Likewise.
649 * xmenu.c: Likewise.
650 * xrdb.c: Likewise.
651 * xselect.c: Likewise.
652
0497dc44
PE
6532012-07-05 Paul Eggert <eggert@cs.ucla.edu>
654
655 * fileio.c (time_error_value): Check the right error number.
656 Problem reported by Troels Nielsen in
657 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
658
356e7178
PE
6592012-07-04 Paul Eggert <eggert@cs.ucla.edu>
660
4e71fd89
PE
661 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
662 This should be fixed in a better way; see Eli Zaretskii in
663 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
664 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
665
f0941253
PE
666 * fileio.c (time_error_value): Rename from special_mtime.
667 The old name's problems were noted by Eli Zaretskii in
668 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
669
065c9eb4
PE
670 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
671 This variable's comment says Emacs needs at least one GDB-visible
672 symbol of type enum pvec_type, to work around GDB problems.
673 The symbol's value doesn't matter.
674
356e7178
PE
675 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
676 that causes compilation to fail on pre-C99 compilers.
677
95f61aa2
JB
6782012-07-04 Juanma Barranquero <lekktu@gmail.com>
679
680 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
681 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
682
3884d954
DA
6832012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
684
d209e2fb 685 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
686 headers for buffer_defaults and buffer_local_symbols.
687 Reported by Juanma Barranquero <lekktu@gmail.com>.
688
ee28be33
SM
6892012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
690
691 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
692 * lisp.h (enum pvec_type): Use fewer bits.
693 (PSEUDOVECTOR_SIZE_BITS): New constant.
694 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
695 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
696 change in pvec_type.
697 (PSEUDOVECTOR_TYPEP): New macro.
698 (TYPED_PSEUDOVECTORP): Use it.
699 * fns.c (internal_equal): Adapt code to extract pvectype.
700 * emacs.c (gdb_pvec_type): Update type.
701 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
702 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
703 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
704 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
705 (sweep_vectors): Use it. Use local var `total_bytes' instead of
706 abusing vector->header.next.nbytes.
707 (live_vector_p): Use PVEC_TYPE.
708 (mark_object): Adapt code to extract pvectype. Use switch.
709
c7f2cd7f
PE
7102012-07-04 Paul Eggert <eggert@cs.ucla.edu>
711
712 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
713 Tighten new eassert a bit.
714
8ce70ed2
DA
7152012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
716
717 Fix compilation with --enable-gcc-warnings and -O1
718 optimization level.
719 * doprnt.c (doprnt): Change type of tem to int, initialize
720 to avoid compiler warning. Add eassert.
721 * search.c (simple_search): Initialize match_byte to avoid
722 compiler warning. Add eassert.
723
dea7f1e5
PE
7242012-07-04 Paul Eggert <eggert@cs.ucla.edu>
725
24a212eb
PE
726 Avoid weird behavior with large horizontal scrolls.
727 Without this change, for example, large hscroll values would
728 mess up Emacs's display on Fedora 15 x86, presumably due to
729 overflows in int calculations in the display code.
730 Also, if buffers had long lines, Emacs would freeze.
731 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
732 (set_window_hscroll): New function, containing the old guts of
733 Fset_window_hscroll. Return the clipped value.
734 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
735 This avoids the need to check against PTRDIFF_MAX.
736
dea7f1e5
PE
737 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
738
76046526
DA
7392012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
740
741 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
742
39adff0d
PE
7432012-07-04 Paul Eggert <eggert@cs.ucla.edu>
744
63807d47
PE
745 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
746 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
747 since GCC 4.4.6 issues a bogus warning for them.
748
39adff0d
PE
749 Fix bugs in file timestamp newness comparisons.
750 * fileio.c (Ffile_newer_than_file_p):
751 * lread.c (Fload): Use full timestamp resolution of files,
752 not just the 1-second resolution, so that files that are only
753 slightly newer still count as newer.
754 * fileio.c (Ffile_newer_than_file_p): Don't assume file
755 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
756
dbeed9a6
PE
7572012-07-03 Paul Eggert <eggert@cs.ucla.edu>
758
759 * fileio.c: Improve handling of file time marker. (Bug#11852)
760 (special_mtime): New function.
761 (Finsert_file_contents, Fverify_visited_file_modtime):
762 Use it to set special mtime values consistently.
763
636334d6
AS
7642012-07-03 Andreas Schwab <schwab@linux-m68k.org>
765
766 * fileio.c (Finsert_file_contents): Properly handle st_mtime
767 marker for non-existing file. (Bug#11852)
768
e2017fe2
GM
7692012-07-03 Glenn Morris <rgm@gnu.org>
770
771 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
772 and did not make it into globals.h).
773
404dbd37
TT
7742012-07-03 Tom Tromey <tromey@redhat.com>
775
776 * window.c (Fset_window_margins, Fset_window_fringes)
777 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
778 * textprop.c (Fprevious_property_change): No longer static.
779 * syntax.c (Fsyntax_table_p): No longer static.
780 * process.c (Fget_process, Fprocess_datagram_address): No longer
781 static.
782 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
783 * keyboard.c (Fcommand_execute): No longer static.
784 Remove EXFUN.
785 * insdel.c (Fcombine_after_change_execute): No longer static.
786 * image.c (Finit_image_library): No longer static.
787 * fileio.c (Fmake_symbolic_link): No longer static.
788 * eval.c (Ffetch_bytecode): No longer static.
789 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
790 * doc.c (Fdocumentation_property, Fsnarf_documentation):
791 No longer static.
404dbd37
TT
792 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
793 static.
794 * dired.c (Ffile_attributes): No longer static.
795 * composite.c (Fcomposition_get_gstring): No longer static.
796 * callproc.c (Fgetenv_internal): No longer static.
797
798 * ccl.h: Remove EXFUNs.
799 * buffer.h: Remove EXFUNs.
800 * dispextern.h: Remove EXFUNs.
801 * intervals.h: Remove EXFUNs.
802 * fontset.h: Remove EXFUN.
803 * font.h: Remove EXFUNs.
804 * dosfns.c (system_process_attributes): Remove EXFUN.
805 * keymap.h: Remove EXFUNs.
806 * lisp.h: Remove EXFUNs.
807 * w32term.h: Remove EXFUNs.
808 * window.h: Remove EXFUNs.
809 * xsettings.h: Remove EXFUN.
810 * xterm.h: Remove EXFUN.
811
8e4fd1e1
GM
8122012-07-03 Glenn Morris <rgm@gnu.org>
813
814 * lisp.h (Frandom): Make it visible to C.
815 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
816 buffer for invisible buffers. (Bug#1229)
817
ca95b3eb
DA
8182012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
819
820 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
821 values which aren't power of 2.
822 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
823 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
824 accordingly.
825
7555c33f
SM
8262012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
827
828 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
829
830 * alloc.c (mark_object): Revert part of last patch to use `switch'.
831
d12e8f5a
DA
8322012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
833
834 * alloc.c (allocate_vector_block): Remove redundant
835 calls to mallopt if DOUG_LEA_MALLOC is defined.
836 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
837 avoid calls to mallopt if zero_vector is returned.
838
296094c3
DA
8392012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
840
841 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
842 is enabled, avoid dereferencing NULL current_sblock if
843 running undumped.
844
36429c89
DA
8452012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
846
847 Cleanup basic buffer management.
848 * buffer.h (struct buffer): Change layout to use generic vector
849 marking code. Fix some comments. Change type of 'clip_changed'
850 to bitfield. Remove unused #ifndef old.
851 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
852 (GET_OVERLAYS_AT): Fix indentation.
853 (for_each_per_buffer_object_at): New macro.
854 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
855 (Fbuffer_local_variables): Use it.
856 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
857 * alloc.c (allocate_buffer): Adjust to match new layout of
858 struct buffer. Fix comment.
859 (mark_overlay): New function.
860 (mark_buffer): Use it. Use mark_vectorlike to mark normal
861 Lisp area of struct buffer.
862 (mark_object): Use it. Adjust marking of misc objects
863 and related comments.
864
3b3e4cac
PE
8652012-07-02 Paul Eggert <eggert@cs.ucla.edu>
866
867 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
868 wrapper that is not needed because the wrapped code is a no-op (zero
869 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
870 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
871
cf5c0175
DA
8722012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
873
874 * alloc.c (mark_buffer): Simplify. Remove prototype.
875 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 876 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
877 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
878 redundant calls to mark_vectorlike for bool vectors.
879
ca26824c
GM
8802012-06-30 Glenn Morris <rgm@gnu.org>
881
2e4c5312
GM
882 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
883
ca26824c
GM
884 * epaths.in (PATH_SITELOADSEARCH): New.
885 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
886 This is rather than relying on --enable-locallisppath elements
887 having "site-lisp" in their names. (Bug#10208#25, 11658)
888
0d23c240
EZ
8892012-06-30 Eli Zaretskii <eliz@gnu.org>
890
c9240d7a
EZ
891 * w32proc.c (sys_select): Accept and ignore one more argument.
892
893 * w32.c (emacs_gnutls_pull): Call select with one more argument.
894
0d23c240 895 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 896 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
897
898 * sysdep.c: Don't include dos.h and dosfns.h.
899
900 * process.c (sys_select):
901 * msdos.c (sys_select): Accept one more argument and ignore it.
902
903 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
904 adapt data types and code to that.
905
906 * dosfns.c:
907 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
908 which clashes with the gnulib function of the same name.
909
af5a5a98
AS
9102012-06-30 Andreas Schwab <schwab@linux-m68k.org>
911
c5e4379c
AS
912 * font.c (font_style_to_value, font_style_symbolic)
913 (font_prop_validate_style): Add type checks for values in
914 font_style_table.
915
af5a5a98
AS
916 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
917 argument.
918 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
919 uses.
920
8d38f461
EZ
9212012-06-29 Eli Zaretskii <eliz@gnu.org>
922
2e5a6631
EZ
923 * xdisp.c (try_window_id): Undo last change.
924
8d38f461
EZ
925 * w32.c (getwd): Adjust commentary about startup_dir.
926 (init_environment): Always call sys_access, even in non-MSVC
927 builds. Don't chdir to the directory of the Emacs executable.
928 This undoes code from 1997 which was justified by the need to
929 "avoid conflicts when removing and renaming directories". But its
930 downside was that every relative file name was being interpreted
931 relative to the directory of the Emacs executable, which can never
932 be TRT. In particular, it broke sys_access when called with
933 relative file names.
934 (sys_access): Map GetLastError to errno.
935
2af3565e
DA
9362012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
937
938 * window.h (struct window): Change type of 'fringes_outside_margins'
939 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 940 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
941 Adjust comment.
942 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
943 to ptrdiff_t.
944
c8d3a25c 9452012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 946
c8d3a25c
GM
947 * gnutls.c (emacs_gnutls_handshake):
948 Add QUIT to make the loop interruptible.
57570cd3 949
c8d3a25c 9502012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 951
c8d3a25c
GM
952 * charset.c (init_charset): Make lack of etc/charsets fatal.
953
3e984ee8
DA
9542012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
955
956 * editfns.c (region_limit): Fix type mismatch.
957
ef884f23
DA
9582012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
959
960 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
961 undefined. Convert from xassert to eassert.
962 * nsmenu.m: Convert from xassert to eassert.
963 * nsterm.m: Likewise.
964
7d7e0027
SM
9652012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
966
967 * editfns.c (region_limit): Clip to narrowing (bug#11770).
968
aa754e6a
PE
9692012-06-28 Paul Eggert <eggert@cs.ucla.edu>
970
971 Avoid integer overflow on scroll-left and scroll-right.
972 * window.c (HSCROLL_MAX): New macro.
973 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
974 overflow when requested scroll falls outside ptrdiff_t range.
975
80b00b08
DA
9762012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
977
978 * window.h (struct window): Change type of 'hscroll',
979 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
980 'last_modified' and 'last_overlay_modified' to EMACS_INT.
981 Adjust users accordingly.
982 * xdisp.c (try_cursor_movement): Replace type check with eassert.
983 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
984 from EMACS_INT to ptrdiff_t.
985 (make_window): Omit redundant initialization.
986
62b2bcf6
JB
9872012-06-28 Juanma Barranquero <lekktu@gmail.com>
988
989 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
990
45942c7d
DA
9912012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
992
993 * window.h (struct window): Change type of 'use_time' and
994 'sequence_number' from Lisp_Object to int.
995 * frame.c (make_frame): Adjust users accordingly.
996 * print.c (print_object): Likewise.
997 * window.c (select_window, Fwindow_use_time, make_parent_window)
998 (make_window): Likewise.
999
e509cfa6
DA
10002012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1001
1002 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
1003 enabled with --enable-checking=[all,glyphs] configure option.
1004 Fix GLYPH_DEBUG usage assuming that it may be undefined,
1005 adjust comments accordingly.
1006 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
1007 undefined, adjust comments accordingly.
1008 * image.c: Likewise.
1009 * scroll.c: Likewise.
1010 * w32fns.c: Likewise.
1011 * w32term.c: Likewise.
1012 * xdisp.c: Likewise.
1013 * xfaces.c: Likewise.
1014 * xfns.c: Likewise.
1015 * xterm.c: Likewise.
1016
a54e2c05
DA
10172012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1018
1019 Generalize run-time debugging checks.
1020 * dispextern.h (XASSERTS): Remove.
1021 * fontset.c (xassert): Remove.
1022 Convert from xassert to eassert.
1023 * alloc.c: Convert from xassert to eassert.
1024 * bidi.c: Likewise.
1025 * dispnew.c: Likewise.
1026 * fns.c: Likewise.
1027 * fringe.c: Likewise.
1028 * ftfont.c: Likewise.
1029 * gtkutil.c: Likewise.
1030 * image.c: Likewise.
1031 * keyboard.c: Likewise.
1032 * menu.c: Likewise.
1033 * process.c: Likewise.
1034 * scroll.c: Likewise.
1035 * sound.c: Likewise.
1036 * term.c: Likewise.
1037 * w32console.c: Likewise.
1038 * w32fns.c: Likewise.
1039 * w32term.c: Likewise.
1040 * window.c: Likewise.
1041 * xdisp.c: Likewise.
1042 * xfaces.c: Likewise.
1043 * xfns.c: Likewise.
1044 * xselect.c: Likewise.
1045 * xterm.c: Likewise.
1046
1ec4b7b2
SM
10472012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
1048
1049 * fns.c (maybe_resize_hash_table): Output message when growing the
1050 purify-hashtable.
1051
2014308a
DA
10522012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1053
1054 * alloc.c (allocate_string_data): Remove dead code.
1055 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
1056 avoid GCC warning about unused macro.
1057
246155eb
DA
10582012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1059
1060 * alloc.c (allocate_string): Omit intervals initialization.
1061 * alloc.c (make_uninit_multibyte_string): Initialize intervals
1062 as in make_pure_string and make_pure_c_string.
1063
43184b7b
DA
10642012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1065
d209e2fb 1066 * alloc.c (allocate_string): Fix last change.
43184b7b 1067
3fe6dd74
DA
10682012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1069
d209e2fb 1070 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
1071 to memset, add explicit initialization where appropriate.
1072
1ba6038a
GM
10732012-06-27 Glenn Morris <rgm@gnu.org>
1074
1075 * lisp.mk (lisp): Remove paths.elc.
1076
c89926a5
CY
10772012-06-27 Chong Yidong <cyd@gnu.org>
1078
1079 * doc.c (Fsubstitute_command_keys): Fix punctuation.
1080
ed6b3510
JW
10812012-06-26 John Wiegley <johnw@newartisans.com>
1082
1ec4b7b2 1083 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
1084 on Mac OS X Lion: __mod_init_func and __mod_term_func.
1085
ed6b3510
JW
1086 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
1087 when building with Clang.
1088
8edd4a2b
SM
10892012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
1090
1091 * eval.c (Fapply): Allow calling it with a single argument.
1092
f6f62d1b
EZ
10932012-06-26 Eli Zaretskii <eliz@gnu.org>
1094
1095 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
1096 _stricmp and _strnicmp.
1097 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
1098
62efea5e
DA
10992012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1100
1101 * alloc.c (allocate_window): Zero out non-Lisp part of newly
1102 allocated window.
1103 (allocate_process): Likewise for new process.
8edd4a2b 1104 (allocate_terminal): Change to use offsetof.
62efea5e
DA
1105 (allocate_frame): Likewise.
1106 * frame.c (make_frame): Omit redundant initialization.
1107 * window.c (make_parent_window): Use memset.
1108 (make_window): Omit redundant initialization.
1109 * process.c (make_process): Omit redundant initialization.
1110 * terminal.c (create_terminal): Likewise.
1111
42997f4d
DA
11122012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1113
1114 * term.c (delete_tty): Remove redundant call to memset.
1115
1130ecfc
DA
11162012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1117
1118 * alloc.c: Remove build_string.
1119 * lisp.h: Define build_string as static inline. This provides
1120 a better opportunity to optimize away calls to strlen when the
1121 function is called with compile-time constant argument.
1122 * image.c (imagemagick_error): Convert to build_string.
1123 * w32proc.c (sys_spawnve): Likewise.
1124 * xterm.c (x_term_init): Likewise.
1125
cf38a720
PE
11262012-06-26 Paul Eggert <eggert@cs.ucla.edu>
1127
99027bdd
PE
1128 Use sprintf return value instead of invoking strlen on result.
1129 In the old days this wasn't portable, since some sprintf
1130 implementations returned char *. But they died out years ago and
1131 Emacs already assumes sprintf returns int.
1132 Similarly for float_to_string.
1133 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
1134 * ccl.c (ccl_driver):
1135 * character.c (string_escape_byte8):
1136 * data.c (Fnumber_to_string):
1137 * doprnt.c (doprnt):
1138 * print.c (print_object):
1139 * xdisp.c (message_dolog):
1140 * xfns.c (syms_of_xfns):
1141 Use sprintf or float_to_string result to avoid need to call strlen.
1142 * data.c (Fnumber_to_string):
1143 Use make_unibyte_string, since the string must be ASCII.
1144 * lisp.h, print.c (float_to_string): Now returns int length.
1145 * term.c (produce_glyphless_glyph):
1146 Use sprintf result rather than recomputing it.
1147
cf38a720
PE
1148 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
1149 * Makefile.in (ALL_CFLAGS):
1150 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
1151 * gmalloc.c, regex.c: Include <config.h> unconditionally.
1152
3511c784
DA
11532012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1154
0a08eb21 1155 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
1156 strcasecmp if available.
1157 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
1158
fb7da12e
AS
11592012-06-25 Andreas Schwab <schwab@linux-m68k.org>
1160
1161 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
1162 Avoid comma operator.
1163 * menu.c (push_submenu_start, push_submenu_end)
1164 (push_left_right_boundary, push_menu_pane): Likewise.
1165 * msdos.c (dos_rawgetc): Likewise.
1166
afa2ffd8
DA
11672012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1168
1169 * xfns.c (xic_create_fontsetname): Remove redundant calls
1170 to memset.
1171
b3b4476b
PE
11722012-06-25 Paul Eggert <eggert@cs.ucla.edu>
1173
4495ff38
PE
1174 * gtkutil.c (get_utf8_string): Remove redundant assignment.
1175 sprintf already null-terminates its output.
1176
b3b4476b
PE
1177 * xfns.c (x_window): Remove redundant cast.
1178
b00876c9
DA
11792012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1180
1181 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
1182 `const char *' to `char *' to avoid compiler warning.
1183
d188e26b
PE
11842012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1185
885d1d74
PE
1186 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
1187 instead of truncating it to 63 (admittedly a generous limit).
1188
d188e26b
PE
1189 * process.c: Fix spelling and caps in comments.
1190
e2f560b1
DN
11912012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
1192
e86db54b 1193 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
1194 * sysdep.c (setpgrp): Remove definition, not used in this file.
1195
7583a3a1
JB
11962012-06-24 Juanma Barranquero <lekktu@gmail.com>
1197
1198 * makefile.w32-in: Update dependencies.
1199
696056c2
EZ
12002012-06-24 Eli Zaretskii <eliz@gnu.org>
1201
1202 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
1203 (SYSTIME_H): Add nt/inc/sys/time.h.
1204
1205 * systime.h [WINDOWSNT]: Include sys/time.h.
1206
1207 * s/ms-w32.h (struct timespec): Definition moved from
1208 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
1209
845ca893
PE
12102012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1211
1212 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
1213 * buffer.h (buffer_slot_type_mismatch):
1214 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1215 * eval.c (unwind_to_catch):
1216 * image.c (my_png_error, my_error_exit):
1217 * keyboard.c (quit_throw_to_read_char, user_error)
1218 (Fexit_recursive_edit, Fabort_recursive_edit):
1219 * lisp.h (die, args_out_of_range, args_out_of_range_3)
1220 (wrong_type_argument, buffer_overflow, __executable_start)
1221 (memory_full, buffer_memory_full, string_overflow, Fthrow)
1222 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
1223 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
1224 (fatal):
1225 (child_setup) [!DOS_NT]:
1226 * lread.c (end_of_file_error, invalid_syntax):
1227 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1228 * puresize.h (pure_write_error):
1229 * search.c (matcher_overflow):
1230 * sound.c (sound_perror, alsa_sound_perror):
1231 * sysdep.c, syssignal.h (croak):
1232 * term.c (maybe_fatal, vfatal):
1233 * textprop.c (text_read_only):
1234 * undo.c (user_error):
1235 * unexmacosx.c (unexec_error):
1236 * xterm.c (x_ins_del_lines, x_delete_glyphs):
1237 Use _Noreturn rather than NO_RETURN.
1238 No need for separate decl merely because of _Noreturn.
1239 * sound.c (sound_warning, parse_sound):
1240 Remove unnecessary forward decls.
1241
f1dd8073
PE
12422012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1243
1244 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
1245 * lisp.h (WAIT_READING_MAX): New macro.
1246 * dispnew.c (Fsleep_for, sit_for):
1247 * keyboard.c (kbd_buffer_get_event):
1248 * process.c (Faccept_process_output):
1249 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
1250 This improves on the previous patch, which introduced a bug
1251 when time_t is unsigned and as wide as intmax_t.
1252 See <http://bugs.gnu.org/9000#51>.
1253
b82c1755
EZ
12542012-06-23 Eli Zaretskii <eliz@gnu.org>
1255
1256 * dispnew.c (sit_for, Fsleep_for):
1257 * keyboard.c (kbd_buffer_get_event):
1258 * process.c (Faccept_process_output): Avoid compiler warnings when
1259 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
1260
ca300656
JB
12612012-06-23 Juanma Barranquero <lekktu@gmail.com>
1262
049ec95b
JB
1263 * makefile.w32-in: Update dependencies.
1264
ca300656
JB
1265 * w32.c (ltime): Add return type and declare static.
1266 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
1267
db7b8d06
PE
12682012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1269
1270 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
1271 Privately reported by Herbert J. Skuhra.
1272 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
1273 All uses changed.
1274 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
1275 not make_lisp_timeval, when the argument is of type EMACS_TIME.
1276
0bd8297f
EZ
12772012-06-23 Eli Zaretskii <eliz@gnu.org>
1278
96512555
EZ
1279 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
1280 last argument of make_unibyte_string.
1281
0bd8297f
EZ
1282 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
1283 language ID in the event parameters.
1284
1285 * w32term.c (w32_read_socket): Put the new keyboard codepage into
1286 event.code, not the obscure "character set ID".
1287
63def6b6
CY
12882012-06-23 Chong Yidong <cyd@gnu.org>
1289
1290 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
1291
e8a02204
EZ
12922012-06-23 Eli Zaretskii <eliz@gnu.org>
1293
388cdec0
EZ
1294 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
1295 * w32.c (fdutimens): New function.
1296
1297 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
1298
1299 * s/ms-w32.h (pselect): Redirect to sys_select.
1300
1301 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
1302
e8a02204
EZ
1303 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
1304 in the logic of incrementing and decrementing the value of
1305 use_relocatable_buffers.
1306
d054f3fb
PE
13072012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1308
1309 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
1310 Privately reported by Herbert J. Skuhra.
1311 [__FreeBSD__]: Remove "*/" typo after "#include".
1312 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
1313 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
1314 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
1315 Don't assume EMACS_TIME and struct timeval are the same type.
1316
d35af63c
PE
13172012-06-22 Paul Eggert <eggert@cs.ucla.edu>
1318
1319 Support higher-resolution time stamps (Bug#9000).
1320 The time stamps are only nanosecond-resolution at the C level,
1321 since that's the best that any real-world system supports now.
1322 But they are picosecond-resolution at the Lisp level, as that's
1323 easy, and leaves room for future OS improvements.
1324
1325 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
1326 (LIBES): Use it.
1327
1328 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
1329 Don't get current time unless it's needed.
1330
1331 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
1332 now provides it if it's absent.
1333 (start_atimer): Port to higher-res time stamps.
1334 Check for time stamp overflow. Don't get current time more
1335 often than is needed.
1336
1337 * buffer.h (struct buffer): Buffer modtime now has high resolution.
1338 Include systime.h, not time.h.
1339 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
1340
1341 * dired.c: Include stat-time.h.
1342 (Ffile-attributes): File times now have higher resolution.
1343
1344 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
1345 (struct image): Timestamp now has higher resolution.
1346
1347 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
1348 has at least microseconds now. All uses removed.
1349 (update_frame, update_single_window, update_window, update_frame_1)
1350 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
1351
1352 * editfns.c (time_overflow): Now extern.
1353 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
1354 (float-time, Fformat_time_string, Fcurrent_time_string)
1355 (Fcurrent_time_zone): Accept and generate higher-resolution
1356 time stamps.
1357 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
1358 (decode_time_components, lisp_seconds_argument): New functions.
1359 (make_time): Now static.
1360 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
1361 Report an error if the time is invalid, rather than having the caller
1362 do that.
1363
1364 * fileio.c: Include <stat-time.h>
1365 (Fcopy_file): Copy higher-resolution time stamps.
1366 Prefer to set the time stamp via a file descriptor if that works.
1367 (Fset_file_times, Finsert_file_contents, Fwrite_region)
1368 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
1369 (Fvisited_file_modtime, Fset_visited_file_modtime):
1370 Support higher-resolution time stamps.
1371
1372 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
1373
1374 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
1375
1376 * image.c (prepare_image_for_display, clear_image_cache)
1377 (lookup_image): Port to higer-resolution time stamps.
1378
1379 * keyboard.c (start_polling, bind_polling_period):
1380 Check for time stamp overflow.
1381 (read_char, kbd_buffer_get_event, timer_start_idle)
1382 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
1383 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
1384 Port to higher-resolution time stamps. Do not assume time_t is signed.
1385 (decode_timer): New function. Timers are now vectors of length 9,
1386 not 8, to accommodate the picosecond component.
1387 (timer_check_2): Use it.
1388
1389 * nsterm.m (select_timeout, timeval_subtract): Remove.
1390 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
1391 as they're a bit more accurate and handle overflow better.
1392 (ns_select): Change prototype to be compatible with pselect.
1393 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
1394 * nsterm.h (ns_select): Adjust prototype.
1395
1396 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
1397 us-resolution time stamps.
1398 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
1399
1400 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
1401
1402 * lisp.h (time_overflow): New decl.
1403 (wait_reading_process_output): First arg is now intmax_t, not int,
1404 to accommodate larger waits.
1405
1406 * process.h (struct Lisp_Process.read_output_delay):
1407 Now counts nanoseconds, not microseconds.
1408 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
1409 EMACS_HAS_USECS.
1410 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
1411 (wait_reading_process_output):
1412 Port to ns-resolution time stamps.
1413 (Faccept_process_output, wait_reading_process_output):
1414 Check for time stamp overflow. Do not assume time_t is signed.
1415 (select_wrapper): Remove; we now use pselect.
1416 (Fprocess_attributes): Now generates ns-resolution time stamps.
1417
1418 * sysdep.c: Include utimens.h. Don't include utime.h
1419 or worry about struct utimbuf; gnulib does that for us now.
1420 (gettimeofday): Remove; gnulib provides a substitute.
1421 (make_timeval): New function.
1422 (set_file_times): Now sets ns-resolution time stamps.
1423 New arg FD; all uses changed.
1424 (time_from_jiffies, ltime_from_jiffies, get_up_time)
1425 (system_process_attributes):
1426 Now returns ns-resolution time stamp. All uses changed.
1427 Check for time stamp overflow.
1428
1429 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
1430 provides a substitute now.
1431
1432 * systime.h: Include timespec.h rather than sys/time.h and time.h,
1433 since it guarantees struct timespec.
1434 (EMACS_TIME): Now struct timespec, so that we can support
1435 ns-resolution time stamps.
1436 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
1437 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
1438 (EMACS_USECS): Remove.
1439 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
1440 so multiply the arg by 1000 before storing it.
1441 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
1442 New macros.
1443 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
1444 Port to ns-resolution time stamps.
1445 (EMACS_TIME_NEG_P): Remove; replaced by....
1446 (EMACS_TIME_SIGN): New macro.
1447 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
1448 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
1449 (set_file_times, make_time, lisp_time_argument): Adjust signature.
1450 (make_timeval, make_lisp_time, decode_time_components): New decls.
1451 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
1452 that it mishandled time_t overflow. You can't compare by subtracting!
1453 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
1454 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
1455
1456 * term.c: Include <sys/time.h>.
1457 (timeval_to_Time): New function, for proper overflow wraparound.
1458 (term_mouse_position, term_mouse_click): Use it.
1459
1460 * undo.c (record_first_change): Support higher-resolution time stamps
1461 in the undo buffer.
1462 (Fprimitive_undo): Use them when restoring time stamps.
1463
1464 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
1465 (w32_get_internal_run_time):
1466 Port to higher-resolution Emacs time stamps.
1467 (ltime): Now accepts single 64-bit integer, as that's more convenient
1468 for callers.
1469
1470 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
1471
1472 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
1473 for compatibility with pselect. Support ns-resolution time stamps.
1474
1475 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
1476
1477 * xselect.c (wait_for_property_change, x_get_foreign_selection):
1478 Check for time stamp overflow, and support ns-resolution time stamps.
1479
1480 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
1481 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
1482 (timeval_subtract): Remove; no longer needed.
1483 (XTflash, XTring_bell, x_wait_for_event):
1484 Port to ns-resolution time stamps. Don't assume time_t is signed.
1485
b6a92dfe
CY
14862012-06-22 Chong Yidong <cyd@gnu.org>
1487
1488 * xdisp.c (x_consider_frame_title): Revert last change.
1489
d251c37c
EZ
14902012-06-22 Eli Zaretskii <eliz@gnu.org>
1491
1492 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
1493 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
1494 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
1495 staticidx goes up to 1597 out of 1600 = 0x640.)
1496
f10deafb
PE
14972012-06-20 Paul Eggert <eggert@cs.ucla.edu>
1498
1499 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
1500 Otherwise, the umask might be mistakenly 0 while handling input signals.
1501
ec6de1e2
SM
15022012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
1503
1504 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
1505
28be1ada
DA
15062012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
1507
1508 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
1509 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
1510 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
1511 access to `contents' member of Lisp_Vector objects with AREF and ASET
1512 where appropriate.
1513
c6bf3022
CY
15142012-06-19 Chong Yidong <cyd@gnu.org>
1515
1516 * frame.c (delete_frame): When selecting a frame on a different
1517 text terminal, do not alter the terminal's top-frame.
1518
1519 * xdisp.c (format_mode_line_unwind_data): Record the target
1520 frame's selected window and its terminal's top-frame.
1521 (unwind_format_mode_line): Restore them.
1522 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
1523 Callers changed.
1524 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
1525 since tty frames can be explicitly named.
1526 (prepare_menu_bars): Likewise.
1527
1528 * term.c (Ftty_top_frame): New function.
1529
defd4196
PE
15302012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1531
1532 Port byte-code-meter to modern targets.
1533 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
1534 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 1535 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
1536 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
1537 (METER_1, METER_2): Simplify.
1538
1053a871
SM
15392012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
1540
1541 * data.c (Fdefalias): Return `symbol' (bug#11686).
1542
b7e8d081
MR
15432012-06-18 Martin Rudalics <rudalics@gmx.at>
1544
1545 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
1546 gets killed during executing of this function (Bug#11665).
1547 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
1548 (Vkill_buffer_query_functions): In doc-string say that functions
1549 run by this hook should not change the current buffer.
1550
7ea2b339
PE
15512012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1552
1553 Fix recently-introduced process.c problems found by static checking.
1554 * process.c (write_queue_push, write_queue_pop, send_process):
1555 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
1556 (write_queue_pop): Fix pointer signedness problem.
1557 (send_process): Remove unused local.
1558
96a313a1
CY
15592012-06-17 Chong Yidong <cyd@gnu.org>
1560
1561 * xdisp.c (redisplay_internal): No need to redisplay terminal
1562 frames that are not on top.
1563
20ca2e94
TN
15642012-06-17 Troels Nielsen <bn.troels@gmail.com>
1565
1566 * process.c (make_process): Initialize write_queue.
1567 (write_queue_push, write_queue_pop): New functions.
1568 (send_process): Use them to maintain correct ordering of process
1569 writes (Bug#10815).
1570
9a900ca9
PE
15712012-06-17 Paul Eggert <eggert@cs.ucla.edu>
1572
310fbfa8
PE
1573 * lisp.h (eassert): Assume C89 or later.
1574 This removes the need for CHECK.
1575 (CHECK): Remove. Its comments about always evaluating its
1576 argument were confusing, as 'eassert' typically does not evaluate
1577 its argument.
1578
27bb1ca4
PE
1579 * coding.c (produce_chars): Use ptrdiff_t, not int.
1580
9a900ca9
PE
1581 * xterm.c (x_draw_underwave): Check for integer overflow.
1582 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
1583
41b7f8bc 15842012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
1585
1586 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
1587 referenced (Bug#11583).
1588
9b0e3eba
AA
15892012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
1590
1591 Implement wave-style variant of underlining.
1592 * dispextern.h (face_underline_type): New enum.
1593 (face): Add field for underline type.
1594 * nsterm.m (ns_draw_underwave): New function.
1595 (ns_draw_text_decoration): Use it.
1596 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
1597 New functions.
1598 (x_draw_glyph_string): Use them.
1599 * xfaces.c (Qline, Qwave): New Lisp objects.
1600 (check_lface_attrs, merge_face_ref)
1053a871
SM
1601 (Finternal_set_lisp_face_attribute, realize_x_face):
1602 Handle wave-style underline face attributes.
9b0e3eba
AA
1603 * xterm.c (x_draw_underwave): New function.
1604 (x_draw_glyph_string): Use it.
1605
0fb52f11
JB
16062012-06-16 Juanma Barranquero <lekktu@gmail.com>
1607
1608 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
1609 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
1610 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
1611 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
1612 ($(BLD)/w32select.$(O)): Update dependencies.
1613
e5560ff7
AS
16142012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1615
1616 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
1617 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
1618 * character.c (_fetch_multibyte_char_p): Remove.
1619 * alloc.c: Include "character.h" before "buffer.h".
1620 * bidi.c: Likewise.
1621 * buffer.c: Likewise.
1622 * bytecode.c: Likewise.
1623 * callint.c: Likewise.
1624 * callproc.c: Likewise.
1625 * casefiddle.c: Likewise.
1626 * casetab.c: Likewise.
1627 * category.c: Likewise.
1628 * cmds.c: Likewise.
1629 * coding.c: Likewise.
1630 * composite.c: Likewise.
1631 * dired.c: Likewise.
1632 * dispnew.c: Likewise.
1633 * doc.c: Likewise.
1634 * dosfns.c: Likewise.
1635 * editfns.c: Likewise.
1636 * emacs.c: Likewise.
1637 * fileio.c: Likewise.
1638 * filelock.c: Likewise.
1639 * font.c: Likewise.
1640 * fontset.c: Likewise.
1641 * fringe.c: Likewise.
1642 * indent.c: Likewise.
1643 * insdel.c: Likewise.
1644 * intervals.c: Likewise.
1645 * keyboard.c: Likewise.
1646 * keymap.c: Likewise.
1647 * lread.c: Likewise.
1648 * macros.c: Likewise.
1649 * marker.c: Likewise.
1650 * minibuf.c: Likewise.
1651 * nsfns.m: Likewise.
1652 * nsmenu.m: Likewise.
1653 * print.c: Likewise.
1654 * process.c: Likewise.
1655 * regex.c: Likewise.
1656 * region-cache.c: Likewise.
1657 * search.c: Likewise.
1658 * syntax.c: Likewise.
1659 * term.c: Likewise.
1660 * textprop.c: Likewise.
1661 * undo.c: Likewise.
1662 * unexsol.c: Likewise.
1663 * w16select.c: Likewise.
1664 * w32fns.c: Likewise.
1665 * w32menu.c: Likewise.
1666 * window.c: Likewise.
1667 * xdisp.c: Likewise.
1668 * xfns.c: Likewise.
1669 * xmenu.c: Likewise.
1670 * xml.c: Likewise.
1671 * xselect.c: Likewise.
1672
2f07e6af
EZ
16732012-06-16 Eli Zaretskii <eliz@gnu.org>
1674
1053a871
SM
1675 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
1676 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 1677 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
1678 row.
1679 (handle_face_prop): Use chunk-relative overlay string index when
1680 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
1681 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
1682 the rightmost. (Bug#11720)
2f07e6af 1683
29b83cec
AS
16842012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1685
1686 * category.h (CHAR_HAS_CATEGORY): Define as inline.
1687 (CATEGORY_MEMBER): Enforce 1/0 value.
1688 * category.c (_temp_category_set): Remove.
1689
4c5501e9
EZ
16902012-06-16 Eli Zaretskii <eliz@gnu.org>
1691
1692 * window.c (Fdelete_other_windows_internal)
1693 (Fdelete_window_internal): Don't access frame's mouse highlight
1694 info of the initial frame. (Bug#11677)
1695
2b570124
PE
16962012-06-14 Paul Eggert <eggert@cs.ucla.edu>
1697
e93864f9
PE
1698 * .gdbinit (xgetint): Fix recently-introduced paren typo.
1699 Assume USE_2_TAGS_FOR_INTS.
1700 (xreload): Adjust $tagmask width to match recent lisp.h change.
1701
2b570124
PE
1702 Simplify lisp.h in minor ways that should not affect code.
1703 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
1704 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
1705 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
1706 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
1707 (INTTYPEBITS): New macro, for clarity.
1708 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
1709 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
1710 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
1711 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
1712 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
1713
81755f69
JB
17142012-06-13 Juanma Barranquero <lekktu@gmail.com>
1715
1716 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
1717
16192a57
GM
17182012-06-13 Glenn Morris <rgm@gnu.org>
1719
1720 * s/bsd-common.h (BSD4_3):
1721 * s/usg5-4-common.h (USG5_4): No longer define; unused.
1722
646b5f55
AS
17232012-06-13 Andreas Schwab <schwab@linux-m68k.org>
1724
1725 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
1726 instead of union.
1727 (XLI, XIL): Define.
1053a871
SM
1728 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
1729 Use them.
1730 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 1731 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 1732 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
1733 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
1734 * frame.c (delete_frame): Remove outdated comment.
1735 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
1736 USE_LISP_UNION_TYPE.
1737 (Fw32_unregister_hot_key): Likewise.
1738 (Fw32_toggle_lock_key): Likewise.
1739 * w32menu.c (add_menu_item): Likewise.
1740 (w32_menu_display_help): Use XIL instead of checking
1741 USE_LISP_UNION_TYPE.
1742 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
1743 (init_heap): Likewise.
1744 * w32term.c (w32_read_socket): Update comment.
1745
1d3823c9
GM
17462012-06-13 Glenn Morris <rgm@gnu.org>
1747
c62ff706
GM
1748 * s/usg5-4-common.h, src/s/unixware.h:
1749 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
1750
1d3823c9
GM
1751 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
1752
bfe3e0a2
PE
17532012-06-13 Paul Eggert <eggert@cs.ucla.edu>
1754
1755 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
1756 * alloc.c (make_number) [!defined make_number]:
1757 Remove, as lisp.h always defines this now.
1758 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
1759 (roundup_size): Verify that it is a power of 2.
1760 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
1761 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
1762 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
1763 -DUSE_LSB_TAG=0, to override the automatically-selected default.
1764 USE_LSB_TAG now is always defined to be either 0 or 1.
1765 All uses changed.
1766 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
1767 code works fine either way, and efficiency is not a concern here,
1768 as the union type is for debugging, not for production.
1769 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
1770 Use an inline function on all platforms when using the union type,
1771 since this is simpler and 'static inline' can be used portably
1772 within Emacs now.
1773 (LISP_INITIALLY_ZERO): New macro.
1774 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
1775 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
1776
45fa9c0f
GM
17772012-06-12 Glenn Morris <rgm@gnu.org>
1778
b4492cba
GM
1779 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
1780
1781 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 1782
45fa9c0f
GM
1783 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
1784 Move BROKEN_SIGIO to configure.
1785
1786 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
1787 Move NO_TERMIO to configure.
1788
0e25d334
CY
17892012-06-12 Chong Yidong <cyd@gnu.org>
1790
1791 * image.c (imagemagick_load_image): Use MagickFlattenImage if
1792 MagickMergeImageLayers is undefined. Use pixel pusher loop if
1793 MagickExportImagePixels is undefined.
1794
43682bb6
PE
17952012-06-12 Paul Eggert <eggert@cs.ucla.edu>
1796
1797 * image.c (imagemagick_load_image): Remove unused label.
1798
a9be7d2b
GM
17992012-06-11 Glenn Morris <rgm@gnu.org>
1800
1801 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1802 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
1803 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
1804 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
1805
3017f87f
SM
18062012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
1807
1808 * alloc.c (make_byte_code): New function.
1809 (Fmake_byte_code): Use it. Don't purify here.
1810 * lread.c (read1): Use it as well to avoid extra allocation.
1811
1b9b4cf4
CY
18122012-06-11 Chong Yidong <cyd@gnu.org>
1813
1814 * image.c (imagemagick_load_image): Implement transparency.
1815
95988fcf
AS
18162012-06-10 Andreas Schwab <schwab@linux-m68k.org>
1817
1818 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
1819 account for preceding backslashes. (Bug#11663)
1820
cd4eb164
CY
18212012-06-09 Chong Yidong <cyd@gnu.org>
1822
1823 * term.c: Support italics in capable terminals (Bug#9652).
1824 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
1825 (turn_on_face): Output using TS_enter_italic_mode if available.
1826 Don't handle unused blinking and alt-charset cases.
1827 (turn_off_face): Handle italic case; discard unused tty_blinking_p
1828 and tty_alt_charset_p cases.
1829 (tty_capable_p, init_tty): Support italics.
1830
1831 * termchar.h (struct tty_display_info): Add field for italics.
1832 Remove unused blink field.
1833
1834 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
1835 Handle slant.
1836
1837 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
1838 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
1839 tty_alt_charset_p. Add tty_italic_p.
1840
ff88beb8
MA
18412012-06-09 Michael Albinus <michael.albinus@gmx.de>
1842
1843 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
1844 dbus_type_is_basic if available.
1845 (xd_extract_signed, xd_extract_unsigned): Rename from
1846 extract_signed and extract_unsigned, respectively. Adapt callers.
1847
44286096
CY
18482012-06-09 Chong Yidong <cyd@gnu.org>
1849
1682701f
CY
1850 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
1851
44286096
CY
1852 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
1853 case (Bug#9752).
1854
d86feb17
PE
18552012-06-08 Paul Eggert <eggert@cs.ucla.edu>
1856
1857 * xdisp.c (vmessage): Treat frame message as multibyte.
1858 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
1859 would generate the diagnostic "Making \302\247 buffer-local while
1860 let-bound!".
1861
d5c20fe8
EZ
18622012-06-08 Eli Zaretskii <eliz@gnu.org>
1863
1864 * dispnew.c (showing_window_margins_p): Undo last change, which
1865 was done due to an inadvertent commit.
1866 (adjust_frame_glyphs_for_frame_redisplay): Do call
1867 showing_window_margins_p.
1868
513749ee
SM
18692012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1870
1871 * eval.c (Fmake_var_non_special): New primitive.
1872 (syms_of_eval): Defsubr it.
1873 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
1874
d4a8f5c1
JB
18752012-06-08 Juanma Barranquero <lekktu@gmail.com>
1876
1877 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
1878 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
1879
8bbbc977
EZ
18802012-06-08 Eli Zaretskii <eliz@gnu.org>
1881
1882 * alloc.c (allocate_vectorlike): Fix last change.
1883
f3372c87
DA
18842012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
1885
1886 Block-based vector allocation of small vectors.
1887 * lisp.h (struct vectorlike_header): New field `nbytes',
1888 adjust comment accordingly.
1889 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
1890 to denote vector blocks. Adjust users (live_vector_p,
1891 mark_maybe_pointer, valid_lisp_object_p) accordingly.
1892 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
1893 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
1894 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
1895 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
1896 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
1897 (roundup_size): New constant.
1898 (struct vector_block): New data type.
1899 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 1900 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
1901 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
1902 (sweep_vectors): New functions.
1903 (allocate_vectorlike): Return `zero_vector' as the only vector of
1904 0 items. Allocate new vector from block if vector size is less than
1905 or equal to VBLOCK_BYTES_MAX.
1906 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
1907 (init_alloc_once): Add call to init_vectors.
1908
4f18a4ed
SM
19092012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1910
1911 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
1912
86f158bc
PE
19132012-06-07 Paul Eggert <eggert@cs.ucla.edu>
1914
1915 * doprnt.c (doprnt): Truncate multibyte char correctly.
1916 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
1917 would mishandle a string argument "Xc" if X was a multibyte
1918 character of length 2: it would truncate after X's first byte
1919 rather than including all of X.
1920
c5cfcbe0
CY
19212012-06-06 Chong Yidong <cyd@gnu.org>
1922
1923 * buffer.c (word_wrap): Doc fix.
1924
c05cf390
PE
19252012-06-04 Paul Eggert <eggert@cs.ucla.edu>
1926
1927 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
1928
0c3461de
GM
19292012-06-03 Glenn Morris <rgm@gnu.org>
1930
1931 * xdisp.c (tool-bar-style): Doc fix.
1932
c71232db
UM
19332012-06-03 Ulrich Müller <ulm@gentoo.org>
1934
1935 * Makefile.in (PAXCTL): Define.
1936 (temacs$(EXEEXT)): Disable memory randomization for the temacs
1937 binary via PaX flags if the paxctl utility is available.
1938 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
1939 Restore PaX flags to their default. (Bug#11398)
1940
383f7350
CY
19412012-06-03 Chong Yidong <cyd@gnu.org>
1942
1943 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
1944 buffer (Bug#11226).
1945
5f2c76c6
CY
19462012-06-03 Chong Yidong <cyd@gnu.org>
1947
1948 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
1949 (note_mode_line_or_margin_highlight): If there is no help echo,
1950 use mode-line-default-help-echo. Handle the case where the mouse
1951 position is past the end of the mode line string.
1952
1953 * buffer.c (buffer_local_value_1): New function, split from
1954 Fbuffer_local_value; can return Qunbound.
1955 (Fbuffer_local_value): Use it.
1956 (Vmode_line_format): Docstring tweaks.
1957
773d47f6
PE
19582012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1959
1960 * sysdep.c (system_process_attributes): Improve comment.
1961
f2d6a3df
SM
19622012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
1963
1964 * keyboard.c: Export real-this-command to Elisp.
1965 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
1966 and DEFVAR it. Update all users.
1967
63810350
PE
19682012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1969
7bd5c1f4
PE
1970 * minibuf.c (Fassoc_string): Remove duplicate declaration.
1971
63810350
PE
1972 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
1973 Convert pctcpu and pctmem to Lisp float properly.
1974 Let the compiler fold better, as 100.0/0x8000 is exact.
1975
a2821611
AS
19762012-06-02 Andreas Schwab <schwab@linux-m68k.org>
1977
1978 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
1979 cons_block.
1980
5fceba1d
PE
19812012-06-01 Paul Eggert <eggert@cs.ucla.edu>
1982
1983 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
1984
c98ff5dd
DA
19852012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
1986
1987 For a 'struct window', replace some Lisp_Object fields to
1988 bitfields where appropriate, remove unused fields.
1989 * window.h (struct window): Remove unused 'last_mark_x' and
1990 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
1991 change it's type from Lisp_Object to bitfield.
1992 Change type of 'force_start', 'optional_new_start',
1993 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
1994 fields from Lisp_Object to bitfield. Adjust users accordingly.
1995
ca34e0be
PE
19962012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1997
1998 Pacify gcc -Wdouble-precision when using Xaw.
1999 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
2000 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
2001 Use 'float' consistently, rather than 'float' in most places
2002 and 'double' in a couple of places.
2003
efc00ab1 20042012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
2005
2006 * xdisp.c (handle_stop): Detect whether we have overlay strings
2007 loaded by testing it->current.overlay_string_index to be
2008 non-negative, instead of checking whether n_overlay_strings is
2009 positive. (Bug#11587)
2010
efc00ab1 20112012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
2012
2013 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
2014
2015 * doc.c (Fsubstitute_command_keys): Doc fix.
2016
efc00ab1 20172012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
2018
2019 * search.c (search_buffer): Remove calls to
2020 r_alloc_inhibit_buffer_relocation, as it is now called by
2021 maybe_unify_char, which was the cause of relocation of buffer text
2022 in bug#11519.
2023
efc00ab1 20242012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
2025
2026 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
2027 for the duration of call to load_charset, to avoid problems with
2028 callers of maybe_unify_char that access buffer text through C
2029 pointers.
2030
2031 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
2032 decrement the inhibition flag, instead of just setting or
2033 resetting it.
2034
ba93a187
PE
20352012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2036
2037 Remove obsolete '#define static' cruft.
2038 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
2039 This #undef was "temporary" in 2000; it is no longer needed
2040 now that '#define static' has gone away.
2041 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
2042 (gray_bitmap_bits): Remove; no longer needed.
2043 All uses replaced with definiens.
2044 * xterm.c: Include "bitmaps/gray.xbm".
2045
9e4bf381
PE
20462012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2047
2048 Clean up __executable_start, monstartup when --enable-profiling.
2049 The following changes affect the code only when profiling.
2050 * dispnew.c (__executable_start): Rename from safe_bcopy.
2051 Define only on platforms that need it.
2052 * emacs.c: Include <sys/gmon.h> when profiling.
2053 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
2054 (__executable_start): Remove decl, since lisp.h does it now.
2055 (safe_bcopy): Remove decl; no longer has that name.
2056 (main): Coalesce #if into single bit of code, for simplicity.
2057 Cast pointers to uintptr_t, since standard libraries want integers
2058 and not pointers.
2059 * lisp.h (__executable_start): New decl.
2060
32d72c2f
GM
20612012-05-31 Glenn Morris <rgm@gnu.org>
2062
2063 * image.c (Fimagemagick_types): Doc fix.
2064
baac5bc7
JM
20652012-05-30 Jim Meyering <meyering@redhat.com>
2066
2067 * callproc.c (Fcall_process_region): Include directory component
2068 in mkstemp error message (Bug#11586).
2069
72cb32cf
PE
20702012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2071
2072 * alloc.c, lisp.h (make_pure_vector): Now static.
2073
61b108cc
SM
20742012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
2075
2076 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
2077 Move to byte-run.el.
2078 (Fautoload): Do the hash-doc more carefully.
2079 * data.c (Fdefalias): Purify definition, except for keymaps.
2080 (Qdefun): Move from eval.c.
2081 * lisp.h (Qdefun): Remove.
2082 * lread.c (read1): Tiny simplification.
2083
471fe23d
TN
20842012-05-29 Troels Nielsen <bn.troels@gmail.com>
2085
934f3f58 2086 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
2087 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
2088 Bug#9642, but explicitly check that the buffer the overlay would
2089 be moved to is live and rearrange lines to make sure that errors
2090 will not put the overlay in an inconsistent state.
2091 (Fdelete_overlay): Cosmetics.
2092
85d0efd1
EZ
20932012-05-28 Eli Zaretskii <eliz@gnu.org>
2094
2095 * w32term.c (my_bring_window_to_top): New function.
2096 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
2097 could be different from the original one.
2098 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
2099 (Bug#11513)
2100
2101 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
2102 by calling BringWindowToTop.
2103
2104 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
2105 (WM_EMACS_END): Increase by one.
2106
da92a98c
PE
21072012-05-28 Paul Eggert <eggert@cs.ucla.edu>
2108
2109 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
2110 This avoids undefined behavior that might cause the eassert
2111 to not catch an out-of-range value.
2112
74d1f848
JB
21132012-05-28 Juanma Barranquero <lekktu@gmail.com>
2114
2115 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
2116 Update dependencies.
2117
9e1a06fc
EZ
21182012-05-27 Eli Zaretskii <eliz@gnu.org>
2119
2120 * bidi.c (bidi_mirror_char): Fix last change.
2121
f3dd7312
AS
21222012-05-27 Andreas Schwab <schwab@linux-m68k.org>
2123
2124 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
2125 when referring to sectname field in printf format.
2126
81899c91
PE
21272012-05-27 Paul Eggert <eggert@cs.ucla.edu>
2128
57b81a9f
PE
2129 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
2130 Only r_alloc_inhibit_buffer_relocation needed to be added;
2131 the others were already declared.
2132
81899c91
PE
2133 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
2134 before checking whether it's out of range. Put the check inside
2135 eassert. See
2136 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
2137
33017faf 21382012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
2139
2140 * callproc.c (Fcall_process): Restore a line that was accidentally
2141 commented out in the 2011-02-13 change (bug#11547).
2142
33017faf 21432012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
2144
2145 * lisp.h [REL_ALLOC]: Add prototypes for external functions
2146 defined on ralloc.c.
2147
2148 * buffer.c [REL_ALLOC]: Remove prototypes of
2149 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
2150 they are now on lisp.h.
2151
2152 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
2153
2154 * search.c (search_buffer): Use it to inhibit relocation of buffer
2155 text while re_search_2 is doing its job, because re_search_2 is
2156 passed C pointers to buffer text. (Bug#11519)
2157
23415acf
EZ
2158 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
2159 Update value to 24.
2160
44e27368
EZ
2161 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
2162 state after an additional call to move_it_in_display_line_to, keep
2163 the values of it->max_ascent and it->max_descent found for the
2164 entire line.
2165 (pos_visible_p): Revert the comparison against bottom_y to what it
2166 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
2167 (Bug#11464)
2168
c1892f11
PE
21692012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2170
2171 Fix coding-related core dumps with gcc -ftrapv.
2172 The code was computing A - B, where A and B are pointers, and B is
2173 random garbage. This can lead to core dumps on platforms that
2174 have special pointer registers, and it also leads to core dumps on
2175 x86-64 when compiled with gcc -ftrapv. The fix is to compute
2176 A - B only when B is initialized properly.
2177 * coding.c (coding_set_source, coding_set_destination): Return void.
2178 (coding_change_source, coding_change_destinations): New functions,
2179 with the old behaviors of coding_set_source and coding_set_destination.
2180 All callers that need an offset changed to use these new functions.
2181
eb7afdad
GM
21822012-05-26 Glenn Morris <rgm@gnu.org>
2183
2184 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
2185
f12fdf02
EZ
21862012-05-26 Eli Zaretskii <eliz@gnu.org>
2187
53a63be6 2188 Extend mouse support on W32 text-mode console.
61b108cc
SM
2189 * xdisp.c (draw_row_with_mouse_face):
2190 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 2191
eb3f6f01 2192 * w32console.c: Include window.h.
61b108cc
SM
2193 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
2194 New functions.
eb3f6f01
EZ
2195 (initialize_w32_display): Initialize mouse-highlight data.
2196
53a63be6
EZ
2197 * w32inevt.c: Include termchar.h and window.h.
2198 (do_mouse_event): Support mouse-autoselect-window. When the mouse
2199 moves, call note_mouse_highlight. If help_echo changed, call
2200 gen_help_event to produce help-echo message in the echo area.
2201 Call clear_mouse_face if mouse_face_hidden is set in the mouse
2202 highlight info.
2203
4cfd81f6
PE
22042012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2205
2206 * lread.c (read1): Simplify slightly to avoid an overflow warning
2207 with GCC 4.7.0 on x86-64.
2208
4446092a
EZ
22092012-05-26 Eli Zaretskii <eliz@gnu.org>
2210
2211 * bidi.c (bidi_mirror_char): Revert last change: an int is
2212 definitely wide enough here.
2213
42b2a986 22142012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 2215
42b2a986 2216 Fix integer width and related bugs (Bug#9874).
eb106a49 2217 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
2218 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
2219 (string_bytes, check_sblock, allocate_string_data):
2220 (compact_small_strings, Fmake_bool_vector, make_string)
2221 (make_unibyte_string, make_multibyte_string)
2222 (make_string_from_bytes, make_specified_string)
2223 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
2224 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
2225 (mark_vectorlike):
2226 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2227 (allocate_pseudovector):
2228 Use int, not EMACS_INT, where int is wide enough.
2229 (inhibit_garbage_collection, Fgarbage_collect):
2230 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2231 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
2232 int might not be wide enough.
2233 (bidi_cache_search, bidi_cache_find, bidi_init_it)
2234 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
2235 (bidi_at_paragraph_end, bidi_find_paragraph_start)
2236 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2237 (bidi_level_of_next_char, bidi_move_to_visually_next):
2238 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2239 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
2240 (Fkill_buffer, Fset_buffer_major_mode)
2241 (advance_to_char_boundary, Fbuffer_swap_text)
2242 (Fset_buffer_multibyte, overlays_at, overlays_in)
2243 (overlay_touches_p, struct sortvec, record_overlay_string)
2244 (overlay_strings, recenter_overlay_lists)
2245 (adjust_overlays_for_insert, adjust_overlays_for_delete)
2246 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
2247 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
2248 (Foverlay_recenter, last_overlay_modification_hooks_used)
2249 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
2250 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
2251 (validate_region): Omit unnecessary test for b <= e,
2252 since that's guaranteed by the previous test.
d311d28c
PE
2253 (adjust_overlays_for_delete): Avoid pos + length overflow.
2254 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
2255 (report_overlay_modification):
2256 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2257 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
2258 Omit pointer cast, which isn't needed anyway, and doesn't work
2259 after the EMACS_INT -> ptrdiff_t change.
02481186 2260 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
2261 * buffer.h: Adjust decls to match defn changes elsewhere.
2262 (struct buffer_text, struct buffer):
2263 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2264 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
2265 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
2266 not int, to avoid needless 32-bit limit on 64-bit hosts.
2267 (exec_byte_code): Use tighter memory-full test, one that checks
2268 for alloca overflow. Don't compute the address of the object just
2269 before an array, as that's not portable. Use EMACS_INT, not
2270 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
2271 * callint.c (Fcall_interactively):
2272 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2273 * callproc.c (call_process_kill, Fcall_process):
2274 Don't assume pid_t fits into an Emacs fixnum.
2275 (call_process_cleanup, Fcall_process, child_setup):
2276 Don't assume pid_t fits into int.
2277 (call_process_cleanup, Fcall_process, delete_temp_file)
2278 (Fcall_process_region):
2279 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2280 (Fcall_process): Simplify handling of volatile integers.
2281 Use int, not EMACS_INT, where int will do.
2282 * casefiddle.c (casify_object, casify_region, operate_on_word)
2283 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
2284 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2285 (casify_object): Avoid integer overflow when overallocating buffer.
2286 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 2287 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
2288 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
2289 * category.h (CATEGORYP): Don't assume arg is nonnegative.
2290 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
2291 integers are now checked earlier. All uses replaced with XINT.
2292 (ccl_driver):
2293 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2294 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
2295 (ccl_driver, Fregister_code_conversion_map):
2296 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
2297 (resolve_symbol_ccl_program): Check that vector header is in range.
2298 Always copy the vector, so that we can check its contents reliably
2299 now rather than having to recheck each instruction as it's being
2300 executed. Check that vector words fit in 'int'.
2301 (ccl_get_compiled_code, Fregister_ccl_program)
2302 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
2303 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
2304 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
2305 contents are in range.
2306 (Fccl_execute_on_string): Check that status is in range.
2307 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
2308 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
2309 Accept and return EMACS_INT, not int, because callers can pass values
2310 out of 'int' range.
2311 (c_string_width, strwidth, lisp_string_width, chars_in_text)
2312 (multibyte_chars_in_text, parse_str_as_multibyte)
2313 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
2314 (str_as_unibyte, str_to_unibyte, string_count_byte8)
2315 (string_escape_byte8, Fget_byte):
2316 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 2317 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
2318 avoid mishandling large integers.
2319 * character.h: Adjust decls to match defn changes elsewhere.
2320 * charset.c (load_charset_map_from_file, find_charsets_in_text)
2321 (Ffind_charset_region):
2322 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2323 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
2324 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 2325 Don't assume fixnum fits in int.
d311d28c
PE
2326 (load_charset_map_from_vector, Fmap_charset_chars):
2327 Remove now-unnecessary CHECK_NATNUMs.
2328 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
2329 Don't rely on undefined behavior with signed left shift overflow.
2330 Don't assume unsigned int fits into fixnum, or that fixnum fits
2331 into unsigned int. Don't require max_code to be a valid fixnum;
2332 that's not true for gb10830 4-byte on a 32-bit host. Allow
2333 invalid_code to be a cons, for the same reason. Require code_offset
2334 to be a character. Avoid int overflow if max_char is close
2335 to INT_MAX.
2336 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
2337 this is intended anyway and avoids some undefined behavior.
2338 (load_charset_map): Pass unsigned, not int, as 2nd arg of
2339 INDEX_TO_CODE_POINT, as that's what it expects.
2340 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
2341 * charset.h (DECODE_CHAR): Return int, not unsigned;
2342 this is what was intended anyway, and it avoids undefined behavior.
2343 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
2344 integer-overflow issues.
2345 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
2346 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
2347 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
2348 * chartab.c (Fmake_char_table, Fset_char_table_range)
2349 (uniprop_get_decoder, uniprop_get_encoder):
2350 Don't assume fixnum fits in int.
2351 * cmds.c (move_point): New function, that does the gist of
2352 Fforward_char and Fbackward_char, but does so while checking
2353 for integer overflow more accurately.
c96e5d6a 2354 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
2355 (Fforward_line, Fend_of_line, internal_self_insert)
2356 (internal_self_insert):
2357 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2358 Fix a FIXME, by checking for integer overflow when calculating
2359 target_clm and actual_clm.
2360 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 2361 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
2362 (ASSURE_DESTINATION, coding_alloc_by_realloc)
2363 (coding_alloc_by_making_gap, alloc_destination)
2364 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
2365 (encode_coding_utf_16, detect_coding_emacs_mule)
2366 (decode_coding_emacs_mule, encode_coding_emacs_mule)
2367 (detect_coding_iso_2022, decode_coding_iso_2022)
2368 (encode_invocation_designation, encode_designation_at_bol)
2369 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2370 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
2371 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
2372 (encode_coding_ccl, encode_coding_raw_text)
2373 (detect_coding_charset, decode_coding_charset)
2374 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
2375 (produce_composition, produce_charset, produce_annotation)
2376 (decode_coding, handle_composition_annotation)
2377 (handle_charset_annotation, consume_chars, decode_coding_gap)
2378 (decode_coding_object, encode_coding_object, detect_coding_system)
2379 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
2380 (code_convert_region, code_convert_string)
8f50130c
PE
2381 (Fdefine_coding_system_internal)
2382 (coding_set_source, coding_set_destination):
d311d28c
PE
2383 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2384 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
2385 (Fdefine_coding_system_internal):
2386 Don't assume fixnums fit in int.
2387 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 2388 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
2389 (Funencodable_char_position, Fcheck_coding_systems_region)
2390 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 2391 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 2392 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 2393 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 2394 Don't access memory outside of the args array.
d311d28c 2395 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
2396 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
2397 result of ENCODE_CHAR.
d311d28c
PE
2398 * coding.h: Adjust decls to match defn changes elsewhere.
2399 (struct coding_system):
2400 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2401 * composite.c (get_composition_id, find_composition)
2402 (run_composition_function, update_compositions)
2403 (compose_text, composition_gstring_put_cache)
2404 (composition_gstring_p, composition_gstring_width)
2405 (fill_gstring_header, fill_gstring_body, autocmp_chars)
2406 (composition_compute_stop_pos, composition_reseat_it)
2407 (composition_update_it, struct position_record)
2408 (find_automatic_composition, composition_adjust_point)
2409 (Fcomposition_get_gstring, Ffind_composition_internal):
2410 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2411 (update_compositions):
2412 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2413 * composite.h: Adjust decls to match defn changes elsewhere.
2414 (struct composition):
2415 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2416 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2417 Do not attempt to compute the address of the object just before a
2418 buffer; this is not portable.
2419 (Faref, Faset):
2420 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2421 (Faset): Use int, not EMACS_INT, where int is wide enough.
2422 (Fstring_to_number): Don't assume fixnums fit in int.
2423 (Frem): Don't assume arg is nonnegative.
2424 * dbusbind.c (xd_append_arg): Check for integers out of range.
2425 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 2426 (extract_signed, extract_unsigned): New functions.
243e0530
PE
2427 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
2428 (xd_get_connection_references): Return ptrdiff_t, not int.
2429 All uses changed.
2430 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
2431 (xd_read_message_1):
2432 Use int, not unsigned, where the dbus API uses int.
2433 (Fdbus_message_internal): Don't overflow mtype.
2434 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
2435 * dired.c (directory_files_internal, file_name_completion, scmp)
2436 (file_name_completion_stat):
2437 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2438 (file_name_completion): Don't overflow matchcount.
2439 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
2440 * dispextern.h: Adjust decls to match defn changes elsewhere.
2441 (struct text_pos, struct glyph, struct bidi_saved_info)
2442 (struct bidi_string_data, struct bidi_it, struct composition_it)
2443 (struct it):
2444 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2445 (struct display_pos, struct composition_it, struct it):
2446 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2447 * dispnew.c (increment_matrix_positions)
2448 (increment_row_positions, mode_line_string)
2449 (marginal_area_string):
2450 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 2451 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
2452 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2453 (duration_to_sec_usec): New function, to check for overflow better.
2454 (Fsleep_for, sit_for): Use it.
2455 * doc.c (get_doc_string, store_function_docstring):
2456 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2457 (get_doc_string, Fsnarf_documentation):
2458 Use int, not EMACS_INT, where int is wide enough.
2459 (get_doc_string):
2460 Use SAFE_ALLOCA, not alloca.
2461 Check for overflow when converting EMACS_INT to off_t.
2462 * doprnt.c (doprnt):
2463 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2464 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
2465 Don't assume uid_t fits into fixnum.
2466 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
2467 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
2468 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
2469 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
2470 (general_insert_function)
2471 (Finsert_char, make_buffer_string, make_buffer_string_both)
2472 (update_buffer_properties, Fbuffer_substring)
2473 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
2474 (Fsubst_char_in_region, check_translation)
2475 (Ftranslate_region_internal, save_restriction_restore, Fformat)
2476 (transpose_markers, Ftranspose_regions):
2477 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2478 (clip_to_bounds): Move to lisp.h as an inline function).
2479 (Fconstrain_to_field): Don't assume integers are nonnegative.
2480 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
2481 (Fsubst_char_in_region, Fsave_restriction):
2482 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2483 (Femacs_pid): Don't assume pid_t fits into fixnum.
2484 (lo_time): Use int, not EMACS_INT, when int suffices.
2485 (lisp_time_argument): Check for usec out of range.
2486 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
2487 (Fuser_login_name, Fuser_full_name): Signal an error
2488 if a uid argument is out of range, rather than relying on
2489 undefined behavior.
c8d5c857
PE
2490 (Fformat_time_string): Remove now-unnecessary check.
2491 lisp_time_argument checks for out-of-range usec now.
243e0530 2492 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
2493 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
2494 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
2495 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
2496 (init_cmdargs, Fdump_emacs):
2497 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2498 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
2499 the bottom (typically) 32 bits of the fixnum.
2500 * eval.c (specpdl_size, call_debugger):
2501 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2502 (when_entered_debugger, Fbacktrace_debug):
2503 Don't assume fixnum can fit in int.
2504 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
2505 the object just before a buffer; this is not portable.
2506 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
2507 (grow_specpdl, unbind_to):
2508 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2509 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
2510 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 2511 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
2512 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
2513 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
2514 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2515 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
2516 (a_write, e_write):
2517 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2518 (Fcopy_file, non_regular_nbytes, read_non_regular)
2519 (Finsert_file_contents):
2520 Use int, not EMACS_INT, where int is wide enough.
2521 (READ_BUF_SIZE): Verify that it fits in int.
2522 (Finsert_file_contents): Check that counts are in proper range,
2523 rather than assuming fixnums fit into ptrdiff_t etc.
2524 Don't assume fixnums fit into int.
125b3835 2525 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
2526 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
2527 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
2528 (string_char_to_byte, string_byte_to_char)
2529 (string_make_multibyte, string_to_multibyte)
2530 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
2531 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
2532 (substring_both, Fdelete, internal_equal, Ffillarray)
2533 (Fclear_string, mapcar1)
2534 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
2535 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
2536 (larger_vector, make_hash_table, maybe_resize_hash_table)
2537 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
2538 (Fmaphash, secure_hash):
2539 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2540 (concat): Check for string index and length overflow.
2541 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
2542 (Frequire):
2543 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2544 (larger_vector): New API (vec, incr_min, size_max) replaces old
2545 one (vec, new_size, init). This catches size overflow.
2546 INIT was removed because it was always Qnil.
2547 All callers changed.
2548 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
2549 the upper bound on a hash table index size.
2550 (make_hash_table, maybe_resize_hash_table): Use it.
2551 (secure_hash): Computer start_byte and end_byte only after
2552 they're known to be in ptrdiff_t range.
2553 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
2554 (Ffont_get_glyphs, Ffont_at):
2555 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2556 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
2557 (Flist_fonts, Fopen_font):
2558 Don't assume fixnum can fit in int.
2559 (check_gstring): Don't assume index can fit in int.
2560 (font_match_p): Check that fixnum is a character, not a nonnegative
2561 fixnum, since the later code needs to stuff it into an int.
2562 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
2563 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
2564 conversion overflow issues.
2565 (Fopen_font): Check for integer out of range.
2566 (Ffont_get_glyphs): Don't assume index can fit in int.
2567 * font.h: Adjust decls to match defn changes elsewhere.
2568 * fontset.c (reorder_font_vector): Redo score calculation to avoid
2569 integer overflow.
2570 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
2571 printmax_t, where ptrdiff_t is wide enough.
2572 (Finternal_char_font):
2573 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2574 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
2575 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
2576 (Fset_frame_position, x_set_frame_parameters)
2577 (x_set_line_spacing, x_set_border_width)
2578 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
2579 Check that fixnums are in proper range for system types.
2580 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
2581 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2582 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
2583 Use SAFE_ALLOCA_LISP, not alloca.
2584 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
2585 intptr_t is wide enough.
2586 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
2587 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
2588 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
2589 Check for fixnum out of range.
2590 * ftfont.c (ftfont_list): Don't assume index fits in int.
2591 Check that fixnums are in proper range for system types.
2592 (ftfont_shape_by_flt):
2593 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
2594 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2595 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2596 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
2597 Check that fixnums are in proper range for system types.
2598 * gnutls.h: Adjust decls to match defn changes elsewhere.
2599 * gtkutil.c (xg_dialog_run):
2600 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2601 (update_frame_tool_bar):
2602 Check that fixnums are in proper range for system types.
2603 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 2604 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
2605 * indent.c (last_known_column, last_known_column_point):
2606 (current_column_bol_cache):
2607 (skip_invisible, current_column, check_display_width):
2608 (check_display_width, scan_for_column, current_column_1)
2609 (Findent_to, Fcurrent_indentation, position_indentation)
2610 (indented_beyond_p, Fmove_to_column, compute_motion):
2611 (Fcompute_motion, Fvertical_motion):
2612 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2613 (last_known_column_modified): Use EMACS_INT, not int.
2614 (check_display_width):
2615 (Fcompute_motion):
2616 Check that fixnums and floats are in proper range for system types.
2617 (compute_motion): Don't assume index or fixnum fits in int.
2618 (compute_motion, Fcompute_motion):
2619 Use int, not EMACS_INT, when it is wide enough.
2620 (vmotion): Omit local var start_hpos that is always 0; that way
2621 we don't need to worry about overflow in expressions involving it.
2622 * indent.h: Adjust decls to match defn changes elsewhere.
2623 (struct position):
2624 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2625 Use int, not EMACS_INT, where int is wide enough.
2626 Remove unused members ovstring_chars_done and tab_offset;
2627 all uses removed.
2628 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
2629 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
2630 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
2631 (make_gap, copy_text, insert, insert_and_inherit)
2632 (insert_before_markers, insert_before_markers_and_inherit)
2633 (insert_1, count_combining_before, count_combining_after)
2634 (insert_1_both, insert_from_string)
2635 (insert_from_string_before_markers, insert_from_string_1)
2636 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
2637 (adjust_after_replace, adjust_after_insert, replace_range)
2638 (replace_range_2, del_range, del_range_1, del_range_byte)
2639 (del_range_both, del_range_2, modify_region)
2640 (prepare_to_modify_buffer, signal_before_change)
2641 (signal_after_change, Fcombine_after_change_execute):
2642 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2643 * intervals.c (traverse_intervals, rotate_right, rotate_left)
2644 (balance_an_interval, split_interval_right, split_interval_left)
2645 (find_interval, next_interval, update_interval)
2646 (adjust_intervals_for_insertion, delete_node, delete_interval)
2647 (interval_deletion_adjustment, adjust_intervals_for_deletion)
2648 (static_offset_intervals, offset_intervals)
2649 (merge_interval_right, merge_interval_left, make_new_interval)
2650 (graft_intervals_into_buffer, temp_set_point_both)
2651 (temp_set_point, set_point, adjust_for_invis_intang)
2652 (set_point_both, move_if_not_intangible, get_property_and_range)
2653 (get_local_map, copy_intervals, copy_intervals_to_string)
2654 (compare_string_intervals, set_intervals_multibyte_1):
2655 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2656 * intervals.h: Adjust decls to match defn changes elsewhere.
2657 (struct interval):
2658 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2659 * keyboard.c (this_command_key_count, this_single_command_key_start)
2660 (before_command_key_count, before_command_echo_length, echo_now)
2661 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
2662 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
2663 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
2664 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
2665 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2666 (last_non_minibuf_size, last_point_position, echo_truncate)
2667 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
2668 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
2669 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
2670 (stuff_buffered_input):
2671 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2672 (last_auto_save, command_loop_1, read_char):
2673 Use EMACS_INT, not int, to avoid integer overflow.
2674 (record_char): Avoid overflow in total_keys computation.
2675 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
2676 * keyboard.h: Adjust decls to match defn changes elsewhere.
2677 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
2678 (Fkey_description, Fdescribe_vector, Flookup_key):
2679 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2680 (click_position): New function, to check that positions are in range.
2681 (Fcurrent_active_maps):
2682 (describe_command):
2683 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2684 (Faccessible_keymaps, Fkey_description):
2685 (preferred_sequence_p):
2686 Don't assume fixnum can fit into int.
2687 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
2688 Check for integer overflow in size calculations.
2689 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
2690 avoid mishandling large integers.
2691 * lisp.h: Adjust decls to match defn changes elsewhere.
2692 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
2693 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
2694 (struct Lisp_Marker):
2695 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2696 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
2697 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
2698 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
2699 All callers changed.
2700 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
2701 Assume the arg has valid form, since it always does.
2702 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
2703 unsigned integer system type.
2704 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
2705 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
2706 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2707 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
2708 (duration_to_sec_usec): New decl.
2709 * lread.c (read_from_string_index, read_from_string_index_byte)
2710 (read_from_string_limit, readchar, unreadchar, openp)
2711 (read_internal_start, read1, oblookup):
2712 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2713 (Fload, readevalloop, Feval_buffer, Feval_region):
2714 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2715 (openp): Check for out-of-range argument to 'access'.
2716 (read1): Use int, not EMACS_INT, where int is wide enough.
2717 Don't assume fixnum fits into int.
6efdadfd 2718 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
2719 (read_filtered_event): Use duration_to_sec_usec
2720 to do proper overflow checking on durations.
d311d28c
PE
2721 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
2722 in size calculation.
2723 (Fexecute_kbd_macro):
2724 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2725 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
2726 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
2727 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
2728 (set_marker_both, set_marker_restricted_both, marker_position)
2729 (marker_byte_position, Fbuffer_has_markers_at):
2730 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2731 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 2732 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
2733 It now merely ensures that the menu is large enough, without
2734 necessarily growing it, as this avoids some integer overflow issues.
2735 All callers changed.
2736 (keymap_panes, parse_single_submenu, Fx_popup_menu):
2737 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2738 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
2739 Use SAFE_ALLOCA_LISP, not alloca.
2740 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
2741 to EMACS_INT. Check that fixnums are in proper range for system types.
2742 * minibuf.c (minibuf_prompt_width, string_to_object)
2743 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
2744 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
2745 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2746 (get_minibuffer, read_minibuf_unwind):
2747 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2748 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
2749 this simplifies overflow checking. All callers changed.
2750 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
2751 (Ftest_completion):
2752 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2753 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
2754 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
2755 Check that fixnums are in proper range for system types.
2756 (Fx_create_frame, Fx_show_tip):
2757 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2758 * nsfont.m (ns_findfonts, nsfont_list_family):
2759 Don't assume fixnum fits in long.
2760 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
2761 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2762 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
2763 wide enough.
17fdb222 2764 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
2765 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2766 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
2767 (PRINTDECLARE, PRINTPREPARE):
2768 (strout, print_string):
2769 (print, print_preprocess, print_check_string_charset_prop)
2770 (print_object):
2771 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2772 (PRINTDECLARE):
2773 (temp_output_buffer_setup, Fprin1_to_string, print_object):
2774 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2775 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 2776 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 2777 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
2778 (print_error_message): Use SAFE_ALLOCA, not alloca.
2779 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
2780 (print_depth, new_backquote_output, print_number_index):
2781 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
2782 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
2783 (Fset_process_window_size, Fformat_network_address)
2784 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 2785 (sigchld_handler):
d311d28c 2786 Check that fixnums are in proper range for system types.
d44287d4 2787 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
2788 Check for process-ids out of pid_t range rather than relying on
2789 undefined behavior.
e4d81efc 2790 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
2791 (Fformat_network_address, read_process_output, send_process)
2792 (Fprocess_send_region, status_notify):
2793 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2794 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
2795 (wait_reading_process_output, read_process_output, exec_sentinel):
2796 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2797 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
2798 (Faccept_process_output): Use duration_to_sec_usec to do proper
2799 overflow checking on durations.
dde14581
PE
2800 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
2801 Don't assume pid_t fits in int.
02481186
PE
2802 * process.h (struct Lisp_Process): Members tick and update_tick
2803 are now of type EMACS_INT, not int.
b62b53e8
PE
2804 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
2805 configured --with-wide-int.
d311d28c
PE
2806 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
2807 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
2808 * search.c (looking_at_1, string_match_1):
2809 (fast_string_match, fast_c_string_match_ignore_case)
2810 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
2811 (scan_newline, find_before_next_newline, search_command)
2812 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
2813 (set_search_regs, wordify):
2814 (Freplace_match):
2815 (Fmatch_data):
2816 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2817 (string_match_1, search_buffer, set_search_regs):
2818 (Fmatch_data):
2819 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2820 (wordify): Check for overflow in size calculation.
2821 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
2822 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
2823 Check that fixnums are in proper range for system types.
2824 * sound.c (struct sound_device)
2825 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
2826 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2827 (Fplay_sound_internal):
2828 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 2829 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
2830 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
2831 (Fparse_partial_sexp):
2832 Don't assume fixnums can fit in int.
2833 (struct lisp_parse_state, find_start_pos, find_start_value)
2834 (find_start_value_byte, find_start_begv)
2835 (update_syntax_table, char_quoted, dec_bytepos)
2836 (find_defun_start, prev_char_comend_first, back_comment):
2837 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
2838 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
2839 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2840 (Finternal_describe_syntax_value): Check that match_lisp is a
2841 character, not an integer, since the code stuffs it into int.
2842 (scan_words, scan_sexps_forward):
2843 Check that fixnums are in proper range for system types.
2844 (Fforward_word):
2845 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2846 (scan_sexps_forward):
2847 Use CHARACTERP, not INTEGERP, since the value must fit into int.
2848 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
2849 * syntax.h: Adjust decls to match defn changes elsewhere.
2850 (struct gl_state_s):
2851 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
2852 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
2853 MOST_POSITIVE_FIXNUM.
d311d28c
PE
2854 * sysdep.c (wait_for_termination_1, wait_for_termination)
2855 (interruptible_wait_for_termination, mkdir):
2856 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
2857 (emacs_read, emacs_write):
2858 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
2859 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
2860 and double all fit in int.
d311d28c
PE
2861 * term.c (set_tty_color_mode):
2862 Check that fixnums are in proper range for system types.
2863 * termhooks.h (struct input_event):
2864 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2865 * textprop.c (validate_interval_range, interval_of)
2866 (Fadd_text_properties, set_text_properties_1)
2867 (Fremove_text_properties, Fremove_list_of_text_properties)
2868 (Ftext_property_any, Ftext_property_not_all)
2869 (copy_text_properties, text_property_list, extend_property_ranges)
2870 (verify_interval_modification):
2871 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2872 (Fnext_single_char_property_change)
2873 (Fprevious_single_char_property_change):
2874 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
2875 (copy_text_properties):
2876 Check for integer overflow in index calculation.
d311d28c
PE
2877 * undo.c (last_boundary_position, record_point, record_insert)
2878 (record_delete, record_marker_adjustment, record_change)
2879 (record_property_change):
2880 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2881 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
2882 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2883 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2884 (Fx_hide_tip, Fx_file_dialog):
2885 * w32menu.c (set_frame_menubar):
2886 Use ptrdiff_t, not int, for consistency with rest of code.
2887 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
2888 (select_window, Fdelete_other_windows_internal)
2889 (window_scroll_pixel_based, window_scroll_line_based)
2890 (Frecenter, Fset_window_configuration):
2891 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2892 (Fset_window_hscroll, run_window_configuration_change_hook)
2893 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 2894 (Fscroll_other_window, Frecenter):
d311d28c
PE
2895 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2896 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
2897 Don't assume fixnum fits in int.
2898 (Fset_window_scroll_bars):
2899 Check that fixnums are in proper range for system types.
2900 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
2901 (string_pos, c_string_pos, number_of_chars, init_iterator)
2902 (in_ellipses_for_invisible_text_p, init_from_display_pos)
2903 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
2904 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
2905 (face_before_or_after_it_pos, handle_invisible_prop)
2906 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
2907 (display_prop_intangible_p, string_buffer_position_lim)
2908 (string_buffer_position, handle_composition_prop, load_overlay_strings)
2909 (get_overlay_strings_1, get_overlay_strings)
2910 (iterate_out_of_display_property, forward_to_next_line_start)
2911 (back_to_previous_visible_line_start, reseat, reseat_to_string)
2912 (get_next_display_element, set_iterator_to_next)
2913 (get_visually_first_element, compute_stop_pos_backwards)
2914 (handle_stop_backwards, next_element_from_buffer)
2915 (move_it_in_display_line_to, move_it_in_display_line)
2916 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2917 (add_to_log, message_dolog, message_log_check_duplicate)
2918 (message2, message2_nolog, message3, message3_nolog
2919 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
2920 (current_message_1, truncate_echo_area, truncate_message_1)
2921 (set_message, set_message_1, store_mode_line_noprop)
2922 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
2923 (text_outside_line_unchanged_p, check_point_in_composition)
2924 (reconsider_clip_changes)
2925 (redisplay_internal, set_cursor_from_row, try_scrolling)
2926 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
2927 (redisplay_window, find_last_unchanged_at_beg_row)
2928 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
2929 (trailing_whitespace_p, find_row_edges, display_line)
2930 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
2931 (display_mode_element, store_mode_line_string)
2932 (pint2str, pint2hrstr, decode_mode_spec)
2933 (display_count_lines, display_string, draw_glyphs)
2934 (x_produce_glyphs, x_insert_glyphs)
2935 (rows_from_pos_range, mouse_face_from_buffer_pos)
2936 (fast_find_string_pos, mouse_face_from_string_pos)
2937 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2938 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2939 (safe_call, init_from_display_pos, handle_fontified_prop)
2940 (handle_single_display_spec, load_overlay_strings)
2941 (with_echo_area_buffer, setup_echo_area_for_printing)
2942 (display_echo_area, echo_area_display)
2943 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
2944 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
2945 (redisplay_window, dump_glyph_row, display_mode_line)
2946 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 2947 (handle_display_spec, display_prop_string_p):
d311d28c
PE
2948 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2949 (handle_single_display_spec, build_desired_tool_bar_string)
2950 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
2951 (get_specified_cursor_type):
2952 Check that fixnums are in proper range for system types.
2953 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
2954 (Flookup_image_map):
2955 Don't assume fixnums fit in int.
2956 (compare_overlay_entries):
2957 Avoid mishandling comparisons due to subtraction overflow.
2958 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
2959 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
2960 (handle_tool_bar_click):
2961 Use int, not unsigned, since we prefer signed and the signedness
2962 doesn't matter here.
2963 (get_next_display_element, next_element_from_display_vector):
2964 Use int, not EMACS_INT, when int is wide enough.
2965 (start_hourglass): Use duration_to_sec_usec to do proper
2966 overflow checking on durations.
2967 * xfaces.c (Fbitmap_spec_p):
2968 Check that fixnums are in proper range for system types.
2969 (compare_fonts_by_sort_order):
2970 Avoid mishandling comparisons due to subtraction overflow.
2971 (Fx_family_fonts, realize_basic_faces):
2972 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2973 (Fx_family_fonts):
2974 Don't assume fixnum fits in int.
2975 Use SAFE_ALLOCA_LISP, not alloca.
2976 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
2977 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
2978 (face_at_buffer_position, face_for_overlay_string)
2979 (face_at_string_position):
2980 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2981 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
2982 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
2983 (Fx_show_tip):
2984 Check that fixnums are in proper range for system types.
2985 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2986 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
2987 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2988 (Fx_change_window_property): Don't assume fixnums fit in int.
2989 * xfont.c (xfont_chars_supported):
2990 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2991 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
2992 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
2993 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2994 * xml.c (parse_region):
2995 * xrdb.c (magic_file_p):
2996 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2997 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
2998 (x_get_local_selection, x_reply_selection_request)
2999 (x_handle_selection_request, wait_for_property_change):
3000 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3001 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
3002 short is wide enough.
3003 (x_send_client_event): Don't assume fixnum fits in int.
3004 * xterm.c (x_x_to_emacs_modifiers):
3005 Don't assume EMACS_INT overflows nicely into int.
3006 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
3007 may come from Lisp.
3008 (handle_one_xevent): NATNUMP can eval its arg twice.
3009 (x_connection_closed):
3010 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3011 * xterm.h: Adjust decls to match defn changes elsewhere.
3012 (struct scroll_bar): Use struct vectorlike_header
3013 rather than rolling our own approximation.
3014 (SCROLL_BAR_VEC_SIZE): Remove; not used.
3015
c6574eb5
GM
30162012-05-25 Glenn Morris <rgm@gnu.org>
3017
3018 * lisp.mk (lisp): Update for more files being compiled now.
3019
e8d32c7e
SM
30202012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
3021
48def666
SM
3022 * lread.c: Remove `read_pure' which makes no difference.
3023 (read_pure): Remove var.
3024 (unreadpure): Remove function.
3025 (readevalloop): Don't call read_list with -1 flag.
3026 (read1, read_vector): Don't test read_pure any more.
3027 (read_list): Simplify.
3028
e8d32c7e
SM
3029 * fileio.c, character.h: Minor style tweaks.
3030
4b2addb7
DA
30312012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
3032
3033 * window.h (clip_changed): Remove useless declaration.
3034
584461b2
JB
30352012-05-22 Juanma Barranquero <lekktu@gmail.com>
3036
3037 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
3038 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
3039
34374650
PE
30402012-05-22 Paul Eggert <eggert@cs.ucla.edu>
3041
3042 Remove src/m/*.
3043 This directory predates autoconf and is no longer needed nowadays.
3044 Move its few remaining bits of functionality to where they're needed.
3045 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
3046 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
3047 * m/template.h: Remove.
3048 * Makefile.in (M_FILE): Remove. All uses removed.
3049 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
3050 * lisp.h (USE_LSB_TAG):
3051 * mem-limits.h (EXCEEDS_LISP_PTR):
3052 Use VAL_MAX, not VALBITS, in #if.
3053 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
3054 (EMACS_UINT): Define unconditionally now.
3055 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
3056 (BITS_PER_EMACS_INT): New constants, replacing
3057 what used to be in config.h, but not useful in #if.
3058 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
3059 define them any more.
3060 (VAL_MAX): New macro.
3061 (VALMASK): Use it.
3062 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
3063 BITS_PER_EMACS_INT, in #if.
3064 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
3065 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
3066 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
3067 * s/ms-w32.h (DATA_START):
3068 Move here from removed file m/intel386.h.
3069 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
3070 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
3071
261cb4bb
PE
30722012-05-21 Paul Eggert <eggert@cs.ucla.edu>
3073
3074 Assume C89 or later.
3075 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
3076 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
3077 (xrealloc):
3078 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
3079 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
3080 * textprop.c, tparam.c (NULL): Remove.
3081 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
3082 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
3083 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
3084 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
3085 * xterm.c (input_signal_count): Assume volatile works.
3086
ff23cd9f
KB
30872012-05-21 Ken Brown <kbrown@cornell.edu>
3088
3089 * xgselect.c (xg_select): Fix first argument in call to 'select'
3090 (bug#11508).
3091
1b170bc6
KB
30922012-05-20 Ken Brown <kbrown@cornell.edu>
3093
3094 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 3095 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 3096
b2f4d39f
KB
30972012-05-19 Ken Brown <kbrown@cornell.edu>
3098
3099 * xfns.c (x_in_use): Remove `static' qualifier.
3100 * xterm.h (x_in_use): Declare.
3101 * xgselect.c: Include xterm.h.
3102 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
3103 and `display_arg' (bug#9754).
3104
003fdae2
PE
31052012-05-19 Paul Eggert <eggert@cs.ucla.edu>
3106
9232a6d9
PE
3107 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
3108
003fdae2
PE
3109 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
3110 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
3111
784b56e2
EZ
31122012-05-18 Eli Zaretskii <eliz@gnu.org>
3113
3114 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
3115
3116 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 3117 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
3118
3119 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
3120 reference to image_cache->refcount.
3121 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
3122
a0a79cde
JL
31232012-05-17 Juri Linkov <juri@jurta.org>
3124
3125 * search.c (Fword_search_regexp, Fword_search_backward)
3126 (Fword_search_forward, Fword_search_backward_lax)
3127 (Fword_search_forward_lax): Move functions to isearch.el
3128 (bug#10145, bug#11381).
3129
b0572523
PE
31302012-05-16 Paul Eggert <eggert@cs.ucla.edu>
3131
3132 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
3133
9660f5fc
SM
31342012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3135
3136 * lread.c (init_obarray): Declare Qt and Qnil as special.
3137
4374de83
GM
31382012-05-14 Glenn Morris <rgm@gnu.org>
3139
3140 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 3141 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 3142
dc44c39a
PE
31432012-05-14 Paul Eggert <eggert@cs.ucla.edu>
3144
078c97cb
PE
3145 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
3146
dc44c39a
PE
3147 * unexaix.c: Port to more-recent AIX compilers.
3148 (report_error, report_error_1, make_hdr, copy_sym)
3149 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
3150 Make arguments const char *, not char *, to avoid violations of C
3151 standard and to fix some AIX warnings reported by Gilles Pion.
3152
e18afed7 31532012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
3154
3155 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
3156 already have overlays loaded.
3157 (handle_single_display_spec): Before returning without displaying
3158 fringe bitmap, synchronize the bidi iterator with the main display
3159 iterator, by calling iterate_out_of_display_property.
3160 (iterate_out_of_display_property): Detect buffer iteration by
3161 testing that it->string is a Lisp string.
3162 (get_next_display_element): When the current object is exhausted,
3163 and there's something on it->stack, call set_iterator_to_next to
3164 proceed with what's on the stack, instead of returning zero.
3165 (set_iterator_to_next): If called at the end of a Lisp string,
3166 proceed to consider_string_end without incrementing string
3167 position. Don't increment display vector index past the end of
3168 the display vector. (Bug#11417)
c8fb9dc6
EZ
3169 (pos_visible_p): Don't report a position visible when move_it_to
3170 stopped at the last line of window, which happens to be scanned
3171 backwards by the bidi iteration. (Bug#11464)
ac268e67 3172
e18afed7 31732012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
3174
3175 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
3176 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
3177 are on a TTY, and thus unable to display on the fringes.
3178 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
3179 so we need to signal to the caller that this is a "replacing"
3180 display spec. This fixes display when the spec is invalid or we
3181 are on a TTY.
3182
e18afed7 31832012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
3184
3185 * unexaix.c (make_hdr): Fix typo in prototype.
3186 This bug broke the build on AIX. Problem reported by Gilles Pion.
3187
9d0a235a
MA
31882012-05-14 Michael Albinus <michael.albinus@gmx.de>
3189
3190 * keyboard.c (kbd_buffer_get_event): Read special events also in
3191 batch mode. (Bug#11415)
3192
9e6b06ed
GM
31932012-05-12 Glenn Morris <rgm@gnu.org>
3194
3195 * ns.mk: Update for ns_appbindir no longer having trailing "/".
3196
c1a1d7a3
EZ
31972012-05-12 Eli Zaretskii <eliz@gnu.org>
3198
3199 * lisp.mk (lisp): Add newcomment.elc.
3200
3fe7cdc8
GM
32012012-05-12 Glenn Morris <rgm@gnu.org>
3202
3203 * Makefile.in (MKDIR_P): New, set by configure.
3204 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
3205
53f7d2c0
PE
32062012-05-11 Paul Eggert <eggert@cs.ucla.edu>
3207
3208 Remove unused function hourglass_started.
3209 * dispextern.h (hourglass_started):
3210 * w32fns.c (hourglass_started):
3211 * xdisp.c (hourglass_started): Remove.
3212
75aafb17
JB
32132012-05-10 Juanma Barranquero <lekktu@gmail.com>
3214
3215 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
3216 Update dependencies.
3217
12959e8e
PE
32182012-05-10 Paul Eggert <eggert@cs.ucla.edu>
3219
97107e2e
PE
3220 * xgselect.c (xg_select): Put maxfds+1 into a var.
3221 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
3222
12959e8e
PE
3223 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
3224
836d29b3
DA
32252012-05-10 Dave Abrahams <dave@boostpro.com>
3226
3227 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
3228 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
3229
5cb67954
MA
32302012-05-09 Michael Albinus <michael.albinus@gmx.de>
3231
3232 * dbusbind.c (xd_registered_buses): New internal Lisp object.
3233 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
3234 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
3235 Initialize xd_registered_buses.
3236
3478ec45
PE
32372012-05-09 Paul Eggert <eggert@cs.ucla.edu>
3238
b263a6b0
PE
3239 Untag more efficiently if USE_LSB_TAG.
3240 This is based on a proposal by YAMAMOTO Mitsuharu in
3241 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
3242 For an admittedly artificial (nth 8000 longlist) benchmark on
3243 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
3244 Emacs's overall text size by 1%.
3245 * lisp.h (XUNTAG): New macro.
3246 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
3247 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
3248 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
3249 * eval.c (Fautoload):
3250 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
3251 * frame.h (XFRAME): Use XUNTAG.
3252
3478ec45
PE
3253 Port recent dbusbind.c changes to 32-bit --with-wide-int.
3254 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
3255 Remove unportable assumptions about print widths of types like
3256 dbus_uint32_t.
3257 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
3258 intptr_t when converting between pointer and integer, to avoid GCC
3259 warnings about wrong width.
3260
666b903b 32612012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
3262
3263 * w32proc.c (new_child): Force Windows to reserve only 64KB of
3264 stack for each reader_thread, instead of defaulting to 8MB
3265 determined by the linker. This avoids failures in creating
3266 subprocesses on Windows 7, see the discussion in this thread:
3267 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
3268
b120cc17
JC
32692012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
3270
3271 Fix up display of the *Minibuf-0* buffer in the mini window.
3272 * keyboard.c (read_char): Don't clear the echo area if there's no
3273 message to clear.
3274 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 3275 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 3276
9a4b36f8
MA
32772012-05-07 Michael Albinus <michael.albinus@gmx.de>
3278
3279 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
3280 batch mode.
3281
e5f9458f
CY
32822012-05-06 Chong Yidong <cyd@gnu.org>
3283
3284 * lisp.mk (lisp): Update.
3285
eceeb5fc 32862012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
3287
3288 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
3289
71873e2b
SM
32902012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3291
3292 * data.c (PUT_ERROR): New macro.
3293 (syms_of_data): Use it. Add new error type `user-error'.
3294 * undo.c (user_error): New function.
3295 (Fprimitive_undo): Use it.
3296 * print.c (print_error_message): Adjust print style for `user-error'.
3297 * keyboard.c (user_error): New function.
3298 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
3299
ab0fa4e4
PE
33002012-05-03 Paul Eggert <eggert@cs.ucla.edu>
3301
3302 Do not limit current-time-string to years 1000..9999.
3303 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
3304 (Fcurrent_time_string): Support any year that is supported by the
3305 underlying localtime representation. Don't use asctime, as it
3306 has undefined behavior for years outside the range -999..9999.
3307
7ed806a7
PE
33082012-05-02 Paul Eggert <eggert@cs.ucla.edu>
3309
3310 Fix race conditions involving setenv, gmtime, localtime, asctime.
3311 Without this fix, interrupts could mess up code that uses these
3312 nonreentrant functions, since setting TZ invalidates existing
3313 tm_zone or tzname values, and since most of these functions return
3314 pointers to static storage.
3315 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
3316 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
3317 Grow the critical sections to include not just invoking
3318 localtime/gmtime, but also accessing these functions' results
3319 including their tm_zone values if any, and any related TZ setting.
3320 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
3321 so that the struct tm is saved in the critical section.
3322 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
3323 motivated by the fact that memory allocation needs to be outside
3324 the critical section.
3325
0c16dfed
DA
33262012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
3327
3328 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
3329 with RESET_INTERVAL.
3330
3331 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3332 Remove duplicated buffer name initialization.
3333
3f83ace8
JM
33342012-05-02 Jim Meyering <jim@meyering.net>
3335
3336 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
3337
c7b8541e
JM
3338 * xfns.c (x_window): Use xstrdup (Bug#11375).
3339
90207a15 33402012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
3341
3342 * xdisp.c (pos_visible_p): If already at a newline from the
3343 display string before the 'while' loop, don't walk back the glyphs
3344 from it3.glyph_row. Solves assertion violation when the display
3345 string begins with a newline (egg.el). (Bug#11367)
3346
b593d6a9
AH
33472012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
3348
3349 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
3350 Move to simple.el.
3351
4737362e
GM
33522012-05-01 Glenn Morris <rgm@gnu.org>
3353
99cf43f9
GM
3354 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
3355 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
3356 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
3357 All were removed before 23.1.
3358
9311dcff
GM
3359 * dispnew.c: Remove HAVE_LIBNCURSES test;
3360 it is always true on relevant platforms.
3361
4d5c6349
GM
3362 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
3363 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
3364
4737362e
GM
3365 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
3366
74dd3a6b
AS
33672012-04-30 Andreas Schwab <schwab@linux-m68k.org>
3368
3369 * .gdbinit (xpr): Remove checks for no longer existing misc types.
3370 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
3371 Remove.
3372
13c379ee
PE
33732012-04-28 Paul Eggert <eggert@cs.ucla.edu>
3374
3375 Do not avoid creating empty evaporating overlays (Bug#9642).
3376 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
3377 That is, do not delete an evaporating overlay if it becomes
3378 empty after its bounds are adjusted to fit within its buffer.
3379 This fix caused other problems, and I'm reverting it until we get
3380 to the bottom of them.
3381
a8e7d6d7 33822012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
3383
3384 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
3385
a8e7d6d7 33862012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
3387
3388 * xdisp.c (pos_visible_p): If the window start position is beyond
3389 ZV, start the display from buffer beginning. Prevents assertion
3390 violation in init_iterator when the minibuffer window is scrolled
3391 via the scroll bar.
3392
3393 * window.c (window_scroll_pixel_based): Likewise.
3394
a8e7d6d7 33952012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
3396
3397 * keymap.c (where_is_internal): Doc fix (Bug#10872).
3398
a8e7d6d7 33992012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
3400
3401 * fileio.c (Fcopy_file, Fset_file_selinux_context):
3402 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
3403
a8e7d6d7 34042012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 3405
b593d6a9
AH
3406 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
3407 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 3408
1c6900d9
EZ
34092012-04-26 Eli Zaretskii <eliz@gnu.org>
3410
4c3fa1d9
EZ
3411 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
3412 display element, check also the underlying string or buffer
3413 character. (Bug#11341)
3414
1c6900d9
EZ
3415 * w32menu.c: Include w32heap.h.
3416 (add_menu_item): If the call to AppendMenuW (via
3417 unicode_append_menu) fails, disable Unicode menus only if we are
3418 running on Windows 9X/Me.
3419
42bf8205
AS
34202012-04-24 Andreas Schwab <schwab@linux-m68k.org>
3421
3422 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
3423 (xgetint): Add missing shift for LSB tags.
3424
b1bac16e
MR
34252012-04-24 Martin Rudalics <rudalics@gmx.at>
3426
3427 * keyboard.c (read_char): Don't wipe echo area for select window
3428 events: These might get delayed via `mouse-autoselect-window'
3429 (Bug#11304).
3430
d69621cc
JB
34312012-04-24 Juanma Barranquero <lekktu@gmail.com>
3432
3433 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
3434 manipulation of :loaded-from data.
3435
02fd101b
JB
34362012-04-23 Juanma Barranquero <lekktu@gmail.com>
3437
3438 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
3439 now a cons (bug#11311).
3440
888bec30
PE
34412012-04-23 Paul Eggert <eggert@cs.ucla.edu>
3442
89a438bd
PE
3443 Do not create empty overlays with the evaporate property (Bug#9642).
3444 * buffer.c (Fmove_overlay): Delete an evaporating overlay
3445 if it becomes empty after its bounds are adjusted to fit within
3446 its buffer. Without this fix, in a nonempty buffer (let ((o
3447 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
3448 yields an empty overlay that has the evaporate property, which is
3449 not supposed to happen.
3450
1068fe4d
PE
3451 Fix minor GTK3 problems found by static checking.
3452 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3453 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3454 (struct _EmacsFixedClass, emacs_fixed_get_type):
3455 Move decls here from emacsgtkfixed.h, since they needn't be public.
3456 (emacs_fixed_get_type): Now static.
3457 (emacs_fixed_class_init): Omit unused local.
3458 (emacs_fixed_child_type): Remove; unused.
3459 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3460 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3461 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
3462 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
3463 (EMACS_FIXED_GET_CLASS): Remove; unused.
3464 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
3465
888bec30
PE
3466 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
3467 Problem reported by Juanma Barranquero for Windows -Wunused-function.
3468
de85e130
PE
34692012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3470
d0baac98 3471 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 3472 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
3473 (__malloc_size_t, __malloc_ptrdiff_t):
3474 Remove. All uses removed, replaced by the definiens if needed,
3475 since we can assume C89 or better now.
3476 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
3477 (protect_malloc_state, align, get_contiguous_space)
3478 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
3479 (malloc_atfork_handler_child, malloc_enable_thread)
3480 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
3481 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
3482 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
3483 (special_realloc, _realloc_internal_nolock, _realloc_internal)
3484 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
3485 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
3486 Define using prototypes, not old style.
3487 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
3488 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
3489 (align): Don't assume that signed integer overflow wraps around.
3490 Omit unused local var.
3491 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
3492 (_free_internal_nolock, memalign, mallochook, reallochook):
3493 Omit no-longer-needed casts.
3494 (valloc): Use getpagesize, not __getpagesize.
3495 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
3496 (struct hdr): The 'magic' member is now size_t, not unsigned long.
3497
de85e130
PE
3498 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
3499
dcbf5805
MA
35002012-04-22 Michael Albinus <michael.albinus@gmx.de>
3501
3502 Move functions from C to Lisp. Make non-blocking method calls
3503 the default. Implement further D-Bus standard interfaces.
3504
3505 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
3506 (QCdbus_request_name_allow_replacement)
3507 (QCdbus_request_name_replace_existing)
3508 (QCdbus_request_name_do_not_queue)
3509 (QCdbus_request_name_reply_primary_owner)
3510 (QCdbus_request_name_reply_in_queue)
3511 (QCdbus_request_name_reply_exists)
3512 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
3513 (QCdbus_registered_serial, QCdbus_registered_method)
3514 (QCdbus_registered_signal): New Lisp objects.
3515 (XD_DEBUG_MESSAGE): Use sizeof.
3516 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
3517 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
3518 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
3519 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
3520 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
3521 (xd_signature, xd_append_arg): Allow float for integer types.
3522 (xd_get_connection_references): New function.
b593d6a9
AH
3523 (xd_get_connection_address): Rename from xd_initialize.
3524 Return cached address.
dcbf5805
MA
3525 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
3526 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
3527 level.
3528 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 3529 Return number of refcounts.
dcbf5805
MA
3530 (Fdbus_get_unique_name): Make stronger parameter check.
3531 (Fdbus_message_internal): New defun.
3532 (Fdbus_call_method, Fdbus_call_method_asynchronously)
3533 (Fdbus_method_return_internal, Fdbus_method_error_internal)
3534 (Fdbus_send_signal, Fdbus_register_service)
3535 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
3536 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
3537 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
3538 (Vdbus_compiled_version, Vdbus_runtime_version)
3539 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
3540 (Vdbus_message_type_method_return, Vdbus_message_type_error)
3541 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
3542 (Vdbus_registered_buses, Vdbus_registered_objects_table):
3543 Adapt docstring.
dcbf5805 3544
52828e02
PE
35452012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3546
da05bc4c
PE
3547 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
3548 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
3549 Do not assume ptrdiff_t is the same width as 'int'.
3550
52828e02
PE
3551 * alloc.c: Handle unusual debugging option combinations.
3552 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
3553 since the two debugging options are incompatible.
3554 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
3555 is defined.
3556 (mem_init, mem_insert, mem_insert_fixup):
3557 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
3558 (NEED_MEM_INSERT): Remove; no longer needed.
3559
f01769f9
LL
35602012-04-22 Leo Liu <sdl.web@gmail.com>
3561
3562 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
3563
5790543d
PE
35642012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3565
3566 * sysdep.c [__FreeBSD__]: Minor cleanups.
3567 (list_system_processes, system_process_attributes) [__FreeBSD__]:
3568 Use Emacs indenting style more consistently. Avoid some casts.
3569 Use 'double' consistently rather than mixing 'float' and 'double'.
3570
b91b7e4d
EW
35712012-04-21 Eduard Wiebe <usenet@pusto.de>
3572
b593d6a9
AH
3573 * sysdep.c (list_system_processes, system_process_attributes):
3574 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 3575
6114eb15
AS
35762012-04-21 Andreas Schwab <schwab@linux-m68k.org>
3577
3578 * lisp.mk (lisp): Update.
3579
2f38dff7
PE
35802012-04-20 Paul Eggert <eggert@cs.ucla.edu>
3581
3582 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
3583 It is never used otherwise.
3584
4ae29f89
SM
35852012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
3586
3587 * print.c (print_preprocess): Only check print_depth if print-circle
3588 is nil.
3589 (print_object): Check for cycles even when print-circle is nil and
3590 print-gensym is t, but only check print_depth if print-circle is nil.
3591
f30d612a
CY
35922012-04-20 Chong Yidong <cyd@gnu.org>
3593
3594 * process.c (wait_reading_process_output): If EIO occurs on a pty,
3595 set the status to "failed" and ensure that sentinel is run.
3596
c07a4c0b 35972012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
3598
3599 * process.c (Fset_process_inherit_coding_system_flag)
3600 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 3601 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 3602
c07a4c0b 36032012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
3604
3605 * xdisp.c (string_buffer_position_lim): Limit starting position to
3606 BEGV.
3607 (set_cursor_from_row): If called for a mode-line or header-line
3608 row, return zero immediately.
3609 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
3610 farther than the first row after the header line, if any.
3611 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
3612 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
3613
c07a4c0b 36142012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 3615
4ae29f89
SM
3616 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
3617 (bug#11238).
ad3a2b41 3618
c07a4c0b 36192012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 36202012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
3621
3622 configure: new option --enable-gcc-warnings (Bug#11207)
3623 * Makefile.in (C_WARNINGS_SWITCH): Remove.
3624 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
3625 (ALL_CFLAGS): Use new macros rather than old.
3626 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
3627 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
3628 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
3629 -Wunused-result, -Wunused-variable. This should go away once
3630 the Emacs and Gnulib regex code is merged.
3631 (xmalloc, xrealloc): Now static.
3632
aba027e8
PE
36332012-04-17 Paul Eggert <eggert@cs.ucla.edu>
3634
3635 * dired.c (Fsystem_groups): Remove unused local.
3636
e5a36063
GM
36372012-04-17 Glenn Morris <rgm@gnu.org>
3638
3639 * dired.c (Fsystem_users): Doc fix.
3640
316411f0
DA
36412012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
3642
3643 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
3644 (syms_of_dired): Add them.
3645
9426aba4
PE
36462012-04-16 Paul Eggert <eggert@cs.ucla.edu>
3647
b62a57be
PE
3648 Fix minor alloc.c problems found by static checking.
3649 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
3650 New extern decls, to avoid calling undeclared functions.
3651 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
3652 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
3653 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
3654 (NEED_MEM_INSERT): New macro.
3655 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 3656 Remove one incorrect comment and fix another.
b62a57be 3657
3539f31f
PE
3658 Fix minor ralloc.c problems found by static checking.
3659 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3660 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
3661 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
3662 (r_alloc_sbrk): Now static.
3663
a041960a
PE
3664 Improve ralloc.c interface checking.
3665 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3666 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
3667 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
3668 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
3669 [REL_ALLOC]: ... to here, to check interface.
3670 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
3671 Remove decls. This fixes an "It stinks!".
3672
9426aba4
PE
3673 * alloc.c (which_symbols): Fix alignment issue / type clash.
3674
d55c12ed
AS
36752012-04-15 Andreas Schwab <schwab@linux-m68k.org>
3676
3677 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
3678 (struct Lisp_Misc_Any): Likewise.
3679 (struct Lisp_Free): Likewise.
3680 * alloc.c (union aligned_Lisp_Symbol): Define.
3681 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
3682 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
3683 (union aligned_Lisp_Misc): Define.
3684 (MARKER_BLOCK_SIZE, struct marker_block): Use union
3685 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 3686 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 3687
b948ce8b
PE
36882012-04-14 Paul Eggert <eggert@cs.ucla.edu>
3689
3690 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
3691 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
3692 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
3693 * s/netbsd.h, s/sol2-6.h:
3694 Remove definition of GC_MARK_STACK, since the default now works.
3695 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
3696 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
3697 no longer the default.
3698 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
3699
35dc09a1 37002012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 3701
35dc09a1
GM
3702 * lread.c (lisp_file_lexically_bound_p):
3703 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 3704
35dc09a1
GM
37052012-04-14 Eli Zaretskii <eliz@gnu.org>
3706
3707 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
3708 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
3709
37102012-04-14 Jan Djärv <jan.h.d@swipnet.se>
3711
3712 * nsterm.m (constrainFrameRect): Always constrain when there is only
3713 one screen (Bug#10962).
3714
bcd86815
KB
37152012-04-13 Ken Brown <kbrown@cornell.edu>
3716
3717 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
3718
c25df26e
RT
37192012-04-13 Reuben Thomas <rrt@sc3d.org>
3720
3721 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
3722
0fc59f1e
DC
37232012-04-11 Daniel Colascione <dancol@dancol.org>
3724
3725 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
3726 against is gone. It's better to use vfork now so that when Cygwin
3727 gains a new, working vfork, we use it automatically (bug#10398).
3728
de8c03dc
SM
37292012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3730
3731 * window.c (save_window_save): Obey window-point-insertion-type.
3732
2f097256
GM
37332012-04-11 Glenn Morris <rgm@gnu.org>
3734
3735 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
3736
453b951e
SM
37372012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3738
3739 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
3740
75f1671a 37412012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
3742
3743 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
3744 (force_quit_count): New var.
3745 (handle_interrupt): Use it.
3746
2a8ce227
JB
37472012-04-10 Juanma Barranquero <lekktu@gmail.com>
3748
3749 * w32.c (w32_delayed_load): Record the full path of the library
3750 being loaded (bug#10424).
3751
935396c0
GM
37522012-04-09 Glenn Morris <rgm@gnu.org>
3753
05920a43
GM
3754 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
3755 not just in the obarray, before snarfing them. (Bug#11036)
3756
935396c0
GM
3757 * Makefile.in ($(leimdir)/leim-list.el):
3758 Pass EMACS rather than BUILT_EMACS.
3759
a18ecafa
TZ
37602012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
3761
3762 * process.c (make_process):
3763 * process.h: Add integer `gnutls_handshakes_tried' member to
3764 process struct.
3765
6bbef4e5
JC
3766 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
3767 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
3768
3769 * gnutls.c (gnutls_log_function2i): Convenience log function.
3770 (emacs_gnutls_read): Use new log functions,
3771 `gnutls_handshakes_tried' process member, and
3772 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
3773 attempts per process (connection).
3774
b4d3bc10
CY
37752012-04-09 Chong Yidong <cyd@gnu.org>
3776
3777 * eval.c (Fuser_variable_p, user_variable_p_eh)
3778 (lisp_indirect_variable): Functions deleted.
3779 (Fdefvar): Caller changed.
3780
3781 * callint.c (Finteractive, Fcall_interactively):
3782 * minibuf.c (Fread_variable): Callers changed.
3783
70f4d973
EZ
37842012-04-09 Eli Zaretskii <eliz@gnu.org>
3785
3786 * xdisp.c (set_cursor_from_row): If the display string appears in
3787 the buffer at position that is closer to point than the position
3788 after the display string, display the cursor on the first glyph of
3789 the display string. Fixes cursor display when a 'display' text
3790 property immediately follows invisible text. (Bug#11094)
3791
cb3c2e3e
PE
37922012-04-09 Paul Eggert <eggert@cs.ucla.edu>
3793
3794 composite.c: use 'double' consistently
3795 * composite.c (get_composition_id): Use 'double' consistently
3796 instead of converting 'float' to 'double' and vice versa; this is
3797 easier to understand and avoids a GCC warning.
3798
fd06db5d
GM
37992012-04-09 Glenn Morris <rgm@gnu.org>
3800
50fe702a
GM
3801 * Makefile.in: Generate leim-list with bootstrap-emacs, in
3802 preparation for dumping it with emacs. (Bug#4789)
3803 (leimdir): New variable.
3804 ($(leimdir)/leim-list.el): New rule.
3805 (emacs$(EXEEXT)): Depend on leim-list.el.
3806
fd06db5d
GM
3807 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
3808 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
3809 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
3810
55c131ee
AS
38112012-04-08 Andreas Schwab <schwab@linux-m68k.org>
3812
3813 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
3814 proper alignment.
3815
9209588f
JB
38162012-04-07 Juanma Barranquero <lekktu@gmail.com>
3817
3818 * xml.c (init_libxml2_functions) [WINDOWSNT]:
3819 Remove unused local variable.
3820
e3fb2efb
PE
38212012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3822
3823 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
3824 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
3825 (mark_memory): Mark Lisp_Objects only if pointers might hide in
3826 objects, as mark_maybe_pointer will catch them otherwise.
3827 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
3828 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
3829
b5385551
PE
38302012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3831
3832 Fix typo that broke non-Windows builds.
3833 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
3834
9078ead6
EZ
38352012-04-07 Eli Zaretskii <eliz@gnu.org>
3836
3837 Support building on MS-Windows with libxml2.
3838
3839 * makefile.w32-in (OBJ2): Add xml.$(O).
3840 (GLOBAL_SOURCES): Add xml.c.
3841 ($(BLD)/xml.$(O)): New dependency list.
3842
3843 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
3844 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
3845 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
3846 [!WINDOWSNT]: New macros.
3847 (init_libxml2_functions, libxml2_loaded_p): New functions.
3848 (parse_region): Call fn_xmlCheckVersion instead of using the macro
3849 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
3850 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
3851 Calls xmlCleanupParser only if libxml2 was loaded (or statically
3852 linked in).
6bbef4e5
JC
3853 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
3854 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
3855 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
3856
3857 * emacs.c: Don't include libxml/parser.h.
3858 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
3859 xmlCleanupParser directly.
3860
3861 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
3862
3811fdf3
EZ
38632012-04-07 Eli Zaretskii <eliz@gnu.org>
3864
3865 * indent.c (Fvertical_motion): If there is a display string at
3866 point, use it.vpos to compute how many lines to backtrack after
3867 move_it_to point. (Bug#11133)
3868
2f8e16b2
EZ
38692012-04-06 Eli Zaretskii <eliz@gnu.org>
3870
3871 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
3872 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
3873 about subtle differences between FETCH_CHAR* and STRING_CHAR*
3874 macros related to unification of CJK characters. For the details,
3875 see the discussion following the message here:
3876 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
3877
3d439cd1
CY
38782012-04-04 Chong Yidong <cyd@gnu.org>
3879
3880 * keyboard.c (Vdelayed_warnings_list): Doc fix.
3881
8bc53d00
EZ
38822012-04-01 Eli Zaretskii <eliz@gnu.org>
3883
3884 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
3885 instead of alloca. (Bug#11138)
3886
3b0512a3
AS
38872012-04-01 Andreas Schwab <schwab@linux-m68k.org>
3888
3889 * w32menu.c (is_simple_dialog): Properly check lisp types.
3890 (Bug#11141)
3891
8427ddd2
EZ
38922012-03-31 Eli Zaretskii <eliz@gnu.org>
3893
979022ef
EZ
3894 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
3895 position we get to after a call to move_it_to fails the
3896 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
3897 only if we wind up in a string from display property. (Bug#11063)
3898
a6b1c7cc
EZ
3899 * window.c (Fdelete_other_windows_internal): Invalidate the row
3900 and column information about mouse highlight, so that redisplay
3901 restores it after reallocating the glyph matrices. (Bug#7464)
3902
8427ddd2
EZ
3903 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
3904 string comes from a `display' text property, use the buffer
3905 position of that property as if we actually saw that position in
3906 the row's glyphs.
697ba24b
EZ
3907 (move_it_by_lines): Remove the assertion that
3908 "it->current_x == 0 && it->hpos == 0" which can be legitimately
3909 violated when there's a before-string at the beginning of a line.
3910 (Bug#11063)
8427ddd2 3911
65a0a738
EZ
39122012-03-30 Eli Zaretskii <eliz@gnu.org>
3913
3914 * xdisp.c (append_space_for_newline): If the default face was
3915 remapped, use the remapped face for the appended newline.
3916 (extend_face_to_end_of_line): Use the remapped default face for
3917 extending the face to the end of the line.
3918 (display_line): Call extend_face_to_end_of_line when the default
3919 face was remapped. (Bug#11068)
3920
581355cc
EZ
39212012-03-29 Eli Zaretskii <eliz@gnu.org>
3922
3923 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
3924
e8fc049f
SM
39252012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3926
3927 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
3928
4fb9a543
GM
39292012-03-27 Glenn Morris <rgm@gnu.org>
3930
3931 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
3932 Doc fixes.
3933
679910f1
KH
39342012-03-26 Kenichi Handa <handa@m17n.org>
3935
3936 * dispextern.h (struct glyph): Fix previous change. Change the
3937 bit length of glyphless.ch to 25 (Bug#11082).
3938
90d49b7f
CY
39392012-03-26 Chong Yidong <cyd@gnu.org>
3940
3941 * keyboard.c (Vselection_inhibit_update_commands): New variable.
3942 (command_loop_1): Use it; inhibit selection update for
3943 handle-select-window too (Bug#8996).
3944
f514f6f0
FP
39452012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
3946
e8fc049f 3947 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 3948
bf43fa51
KH
39492012-03-25 Kenichi Handa <handa@m17n.org>
3950
3951 * dispextern.h (struct glyph): Change the bit length of
3952 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
3953
8a0c01dd
EZ
39542012-03-24 Eli Zaretskii <eliz@gnu.org>
3955
3956 * s/ms-w32.h (tzname): Include time.h before redirecting to
3957 _tzname. Fixes the MSVC build. (Bug#9960)
3958
7d1c3a76
AS
39592012-03-24 Andreas Schwab <schwab@linux-m68k.org>
3960
8ed79523
AS
3961 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
3962 characters.
3963
7d1c3a76
AS
3964 * xterm.c (XTread_socket): Only modify handling_signal if
3965 !SYNC_INPUT. (Bug#11080)
3966
e99a9b8b
EZ
39672012-03-23 Eli Zaretskii <eliz@gnu.org>
3968
3969 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
3970 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
3971 when fetching a multibyte character consumes more bytes than
3972 CHAR_BYTES returns, due to unification of CJK characters in
3973 string_char. (Bug#11073)
3974
5063c0e1
TN
39752012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
3976
3977 * process.c (wait_reading_process_output): Handle pty disconnect
3978 by refraining from sending oneself a SIGCHLD (bug#10933).
3979
9f851fbd
CY
39802012-03-22 Chong Yidong <cyd@gnu.org>
3981
3982 * dispextern.h (struct it): New member string_from_prefix_prop_p.
3983
5063c0e1 3984 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
3985 Mark string as coming from a prefix property.
3986 (handle_face_prop): Use default face for prefix strings (Bug#4281).
3987 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
3988
fb5b8aca
CY
39892012-03-21 Chong Yidong <cyd@gnu.org>
3990
3991 * xfaces.c (Vface_remapping_alist): Doc fix.
3992
62356a1b
EZ
39932012-03-20 Eli Zaretskii <eliz@gnu.org>
3994
3995 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
3996 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
3997 Doc fixes.
62356a1b 3998
025de85b
CY
39992012-03-20 Chong Yidong <cyd@gnu.org>
4000
4001 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
4002 to reflect default non-nil value of redisplay-dont-pause.
4003
4827f94e
KH
40042012-03-19 Kenichi Handa <handa@m17n.org>
4005
4006 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
4007 it fit in a valid range (Bug#11003).
4008
e50a24a2
EZ
40092012-03-18 Eli Zaretskii <eliz@gnu.org>
4010
4011 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
4012 that is not from display property, accept the row as a "cursor
4013 row" if one of the string's character has a non-nil `cursor'
4014 property. Fixes cursor positioning when there are newlines in
4015 overlay strings, e.g. in icomplete.el. (Bug#11035)
4016
9af5ed87
PE
40172012-03-12 Paul Eggert <eggert@cs.ucla.edu>
4018
4019 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
4020
d1f55f16
CY
40212012-03-12 Chong Yidong <cyd@gnu.org>
4022
4023 * eval.c (inhibit_lisp_code): Rename from
4024 inhibit_window_configuration_change_hook; move from window.c.
4025
4026 * xfns.c (unwind_create_frame_1, Fx_create_frame):
4027 * window.c (run_window_configuration_change_hook)
4028 (syms_of_window): Callers changed.
4029
66c5eebd
CY
40302012-03-11 Chong Yidong <cyd@gnu.org>
4031
413df973
CY
4032 * keymap.c (Fkey_description): Doc fix (Bug#9700).
4033
66c5eebd
CY
4034 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
4035
1de11f56
CY
40362012-03-10 Chong Yidong <cyd@gnu.org>
4037
4038 * frame.c (other_visible_frames): Don't assume the selected frame
4039 is visible (Bug#10955).
4040
cae07000
SM
40412012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
4042
4043 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
4044
89c94350
JD
40452012-03-08 Jan Djärv <jan.h.d@swipnet.se>
4046
4047 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
4048 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
4049 zero (Bug#10954).
4050
999dd333
GM
40512012-03-03 Glenn Morris <rgm@gnu.org>
4052
01a6dcc8 4053 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 4054
de0100f2
EZ
40552012-03-02 Eli Zaretskii <eliz@gnu.org>
4056
4057 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
4058 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
4059 (redisplay_window, next_element_from_string): Fix typos in
4060 comments.
3e441275
EZ
4061 (redisplay_window): Pass to move_it_vertically the margin in
4062 pixels, not in screen lines.
de0100f2 4063
96a72ee9
GM
40642012-03-02 Glenn Morris <rgm@gnu.org>
4065
4066 * buffer.c (buffer-list-update-hook): Doc fix.
4067
312508d7
EZ
40682012-02-29 Eli Zaretskii <eliz@gnu.org>
4069
4070 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
4071 push_it before setting up the iterator for the first overlay
4072 string, even if we have an empty string loaded.
4073 (next_overlay_string): If there's an empty string on the iterator
4074 stack, pop the stack. (Bug#10903)
4075
27f3c637
PE
40762012-02-25 Paul Eggert <eggert@cs.ucla.edu>
4077
4078 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
4079 Suggested by Stefan Monnier in
4080 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
4081 * alloc.c (widen_to_Lisp_Object): New static function.
4082 (mark_memory): Also mark Lisp_Objects by fetching pointer words
4083 and widening them to Lisp_Objects. This would work even if
4084 USE_LSB_TAG is defined and wide integers are used, which might
4085 happen in a future version of Emacs.
4086
3c9dfce6
CY
40872012-02-25 Chong Yidong <cyd@gnu.org>
4088
fa74b241
CY
4089 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
4090 Doc fix.
4091
3c9dfce6
CY
4092 * xselect.c (Fx_selection_exists_p): Doc fix.
4093 (x_clipboard_manager_save_all): Print an informative message
4094 before saving to clipboard manager.
4095
9486df08
CY
40962012-02-24 Chong Yidong <cyd@gnu.org>
4097
4098 * keyboard.c (process_special_events): Handle all X selection
4099 requests in kbd_buffer, not just the next one (Bug#8869).
4100
f01d3321
CY
41012012-02-23 Chong Yidong <cyd@gnu.org>
4102
4103 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
4104 call when setting menu-bar-lines and tool-bar-lines parameters.
4105 (unwind_create_frame_1): New helper function.
4106
4107 * window.c (inhibit_window_configuration_change_hook): New var.
4108 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 4109 (syms_of_window): Initialize it.
f01d3321 4110
86b847b6
CY
41112012-02-22 Chong Yidong <cyd@gnu.org>
4112
4113 * xterm.c (x_draw_image_relief): Add missing type check for
4114 Vtool_bar_button_margin (Bug#10743).
4115
a59225b1
CY
41162012-02-21 Chong Yidong <cyd@gnu.org>
4117
4118 * fileio.c (Vfile_name_handler_alist): Doc fix.
4119
4120 * buffer.c (Fget_file_buffer): Protect against invalid file
4121 handler return value.
4122
310f5bd4
PE
41232012-02-20 Paul Eggert <eggert@cs.ucla.edu>
4124
cb3a28cc
PE
4125 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
4126 when computing $valmask.
4127
310f5bd4
PE
4128 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
4129 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
4130 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
4131 It's useless in that case, and it can cause problems on hosts
4132 that allocate halves of EMACS_INT values separately.
4133 Reported by Dan Horák. Diagnosed by Andreas Schwab in
4134 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
4135 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
4136 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
4137 it avoids undefined behavior on hosts where shifting right by more
4138 than the word width has undefined behavior.
4139
2375c96a
CY
41402012-02-19 Chong Yidong <cyd@gnu.org>
4141
4142 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
4143 (Funhandled_file_name_directory, Ffile_name_as_directory)
4144 (Fdirectory_file_name, Fexpand_file_name)
4145 (Fsubstitute_in_file_name): Protect against invalid file handler
4146 return values (Bug#10845).
4147
3eb49e71
EZ
41482012-02-18 Eli Zaretskii <eliz@gnu.org>
4149
4150 * .gdbinit (pitx): Fix incorrect references to fields of the
4151 iterator stack.
4152
7b926f3f
CY
41532012-02-17 Chong Yidong <cyd@gnu.org>
4154
4155 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
4156
11273115
PE
41572012-02-15 Paul Eggert <eggert@cs.ucla.edu>
4158
4159 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
4160 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
4161
c3a70e2b
CY
41622012-02-15 Chong Yidong <cyd@gnu.org>
4163
4164 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
4165 marked as special. Also, starting docstrings with * is obsolete.
4166
0ca43699
AS
41672012-02-13 Andreas Schwab <schwab@linux-m68k.org>
4168
4169 * gnutls.c (emacs_gnutls_write): Fix last change.
4170
2e8f3c56
LI
41712012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
4172
4173 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
4174 send_process.
4175
af70074f
SM
41762012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
4177
4178 * keymap.c (Fsingle_key_description): Handle char ranges.
4179
95986d52
CY
41802012-02-12 Chong Yidong <cyd@gnu.org>
4181
afd83bd1
CY
4182 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
4183 as that creates a dangerous corner case.
4184
95986d52
CY
4185 * window.c (Fdelete_window_internal): Invalidate the mouse
4186 highlight (Bug#9904).
4187
bd7da63e
GM
41882012-02-12 Glenn Morris <rgm@gnu.org>
4189
4190 * xselect.c (Fx_own_selection_internal)
4191 (Fx_get_selection_internal, Fx_disown_selection_internal)
4192 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
4193 * nsselect.m (Fx_own_selection_internal)
4194 (Fx_disown_selection_internal, Fx_selection_exists_p)
4195 (Fx_selection_owner_p, Fx_get_selection_internal):
4196 Sync docs and argument specs with the xselect.c versions.
4197
77abcbc2
LI
41982012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
4199
4200 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
4201
90b671e2
EZ
42022012-02-11 Eli Zaretskii <eliz@gnu.org>
4203
1c0ca0b7
EZ
4204 * w32select.c (Fx_selection_exists_p): Sync doc string and
4205 argument list with xselect.c. (Bug#10783)
4206
4207 * w16select.c (Fx_selection_exists_p): Sync doc string and
4208 argument list with xselect.c. (Bug#10783)
90b671e2 4209
49241268
GM
42102012-02-10 Glenn Morris <rgm@gnu.org>
4211
4212 * fns.c (Fsecure_hash): Doc fix.
4213
f998bbe7 42142012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
4215
4216 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
4217
0992bd9c
CY
42182012-02-07 Chong Yidong <cyd@gnu.org>
4219
4220 * buffer.c (Fbuffer_local_variables)
4221 (buffer_lisp_local_variables): Handle unbound vars correctly;
4222 don't let Qunbound leak into Lisp.
4223
af008560
GM
42242012-02-07 Glenn Morris <rgm@gnu.org>
4225
dd605cc4
GM
4226 * image.c (Fimagemagick_types): Doc fix.
4227
af008560
GM
4228 * image.c (imagemagick-render-type): Change it from a lisp object
4229 to an integer. Move the doc here from the lisp manual.
4230 Treat all values not equal to 0 the same.
4231
1449fa1d
CY
42322012-02-06 Chong Yidong <cyd@gnu.org>
4233
4234 * doc.c (store_function_docstring): Avoid applying docstring of
4235 alias to base function (Bug#2603).
4236
3723ec07
AS
42372012-02-04 Andreas Schwab <schwab@linux-m68k.org>
4238
4239 * .gdbinit (pp1, pv1): Remove redundant defines.
4240 (pr): Use pp.
4241
79c1cc1e
CY
42422012-02-04 Chong Yidong <cyd@gnu.org>
4243
4244 * nsterm.m: Declare a global (Bug#10694).
4245
d7f29f8e
EZ
42462012-02-04 Eli Zaretskii <eliz@gnu.org>
4247
cae07000
SM
4248 * w32.c (get_emacs_configuration_options):
4249 Include --enable-checking, if specified, in the return value.
d7f29f8e 4250
3b95a6f9
MR
42512012-02-04 Martin Rudalics <rudalics@gmx.at>
4252
4253 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
4254 after rounding frame sizes. (Bug#9723)
4255
d6fa96a6
EZ
42562012-02-04 Eli Zaretskii <eliz@gnu.org>
4257
4258 * keyboard.c (adjust_point_for_property): Don't position point
4259 before BEGV. (Bug#10696)
4260
df0b2940
PE
42612012-02-03 Paul Eggert <eggert@cs.ucla.edu>
4262
4263 Handle overflow when computing char display width (Bug#9496).
4264 * character.c (char_width): Return EMACS_INT, not int.
4265 (char_width, c_string_width): Check for overflow when
4266 computing the width; this is possible now that individual
4267 characters can have unbounded width. Problem introduced
4268 by merge from Emacs 23 on 2012-01-19.
4269
6bee44d6
MA
42702012-02-02 Michael Albinus <michael.albinus@gmx.de>
4271
4272 * dbusbind.c (Fdbus_register_method): Mention the return value
4273 :ignore in the docstring.
4274
44f92739
GM
42752012-02-02 Glenn Morris <rgm@gnu.org>
4276
1b9f60cc
GM
4277 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
4278
44f92739
GM
4279 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4280 Unconditionally set to t. (Bug#10673)
4281 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4282 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4283 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
4284
c5d3843c
KH
42852012-02-02 Kenichi Handa <handa@m17n.org>
4286
4287 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
4288 0, do not call append_composite_glyph.
4289
159462d4 42902012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
4291
4292 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
4293 NULL (Bug#6988).
4294 (x_produce_glyphs): If the component of a composition is a null
4295 string, set it->pixel_width to 1 to avoid zero-width glyph.
4296
78cef877
EZ
42972012-02-01 Eli Zaretskii <eliz@gnu.org>
4298
4299 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
4300 first 2 arguments are identical. This makes inserting large
4301 output from a subprocess an order of magnitude faster on
4302 MS-Windows, where all sbrk'ed memory is always contiguous.
4303
97897668
GM
43042012-01-31 Glenn Morris <rgm@gnu.org>
4305
4306 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 4307 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
4308 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
4309
31fd3586
GM
43102012-01-29 Glenn Morris <rgm@gnu.org>
4311
4312 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
4313
0e24a8b2
CY
43142012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
4315
4316 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
4317
cc0adcb0
CY
43182012-01-28 Chong Yidong <cyd@gnu.org>
4319
4320 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
4321
acc28cb9
CY
43222012-01-26 Chong Yidong <cyd@gnu.org>
4323
9c69cfb7
CY
4324 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
4325
acc28cb9
CY
4326 * search.c (Fsearch_forward, Fsearch_backward): Document negative
4327 repeat counts (Bug#10507).
4328
48da7392
GM
43292012-01-26 Glenn Morris <rgm@gnu.org>
4330
4331 * lread.c (syms_of_lread): Doc fix.
4332
14af5f7f
CY
43332012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
4334
4335 * coding.c (encode_designation_at_bol): Change return value to
4336 EMACS_INT.
4337
0b21c100
CY
43382012-01-25 Chong Yidong <cyd@gnu.org>
4339
4340 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
4341
3c2907f7
CY
43422012-01-21 Chong Yidong <cyd@gnu.org>
4343
4344 * floatfns.c (Fcopysign): Make the second argument non-optional,
4345 since nil is not allowed anyway.
4346
959ad23f
AS
43472012-01-21 Andreas Schwab <schwab@linux-m68k.org>
4348
4349 * process.c (read_process_output): Use p instead of XPROCESS (proc).
4350 (send_process): Likewise.
4351
34a02f46
MR
43522012-01-19 Martin Rudalics <rudalics@gmx.at>
4353
4354 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
4355 (Vwindow_persistent_parameters): Do not use Qstate.
4356 Rewrite doc-strings.
34a02f46 4357
1259009a 43582012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
4359
4360 * character.c (char_width): New function.
70d4fdf6
GM
4361 (Fchar_width, c_string_width, lisp_string_width):
4362 Use char_width (Bug#9496).
25ed9e61 4363
6a6ee00d
MR
43642012-01-16 Martin Rudalics <rudalics@gmx.at>
4365
4366 * window.c (Vwindow_persistent_parameters): New variable.
4367 (Fset_window_configuration, save_window_save): Handle persistent
4368 window parameters.
4369
c85efaf7
EZ
43702012-01-14 Eli Zaretskii <eliz@gnu.org>
4371
4372 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
4373 thrashing the stack of the thread. (Bug#9087)
4374
5944709e
PE
43752012-01-12 Paul Eggert <eggert@cs.ucla.edu>
4376
4377 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
4378
e71f5d99
EZ
43792012-01-11 Eli Zaretskii <eliz@gnu.org>
4380
4381 * xdisp.c (rows_from_pos_range): Handle the case where the
4382 highlight ends on a newline. (Bug#10464)
4383 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
4384 he end column for display of highlight that ends on a newline
4385 before a R2L line.
4386
ce316182
GM
43872012-01-11 Glenn Morris <rgm@gnu.org>
4388
4389 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
4390 from load-path also when installation-directory is nil. (Bug#10208)
4391
5b43da69
GM
43922012-01-10 Glenn Morris <rgm@gnu.org>
4393
74cc8ff9
GM
4394 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
4395
7d8d6e4e
GM
4396 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
4397 Update template values to be closer to their typical values these days.
5b43da69 4398
a0db8d43
EZ
43992012-01-09 Eli Zaretskii <eliz@gnu.org>
4400
4401 * xdisp.c (rows_from_pos_range): Accept additional argument
4402 DISP_STRING, and accept any glyph in a row whose object is that
4403 string as eligible for mouse highlight. Fixes mouse highlight of
4404 display strings from overlays. (Bug#10464)
4405
9a0115ab 44062012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 4407
b9110d6a 4408 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
4409 * fileio.c (auto_saving_dir_umask): New static var.
4410 (Fmake_directory_internal): Use it.
4411 (do_auto_save_make_dir): Set it, instead of invoking chmod after
4412 creating the directory. The old code temporarily assigns
4413 too-generous permissions to the directory.
4414 (do_auto_save_eh): Clear it.
b9110d6a 4415 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
4416 that the var is always cleared.
4417
6c1bd3f3
EZ
44182012-01-07 Eli Zaretskii <eliz@gnu.org>
4419
4420 * search.c (scan_buffer): Pass character positions to
4421 know_region_cache, not byte positions. (Bug#6540)
4422
069d2b50
L
44232012-01-07 LynX <_LynX@bk.ru> (tiny change)
4424
4425 * w32.c (sys_rename): Report EXDEV when rename of a directory
4426 fails because the target is on another logical disk. (Bug#10284)
4427
75bf0d33
DB
44282012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
4429
4430 * xterm.c (x_embed_request_focus): New function.
4431
4432 * xterm.h: Add prototype.
4433
4434 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
4435
1c6e5a32
GM
44362012-01-05 Glenn Morris <rgm@gnu.org>
4437
4438 * emacs.c (emacs_copyright): Update short copyright year to 2012.
4439
651e947e
EZ
44402012-01-01 Eli Zaretskii <eliz@gnu.org>
4441
4442 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
4443 Load gnutls_transport_set_lowat only if GnuTLS version is below
4444 2.11.1.
4445 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
4446 GnuTLS versions below 2.11.1.
4447
3778cdd8
AL
44482011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
4449
4450 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
4451 to the doc string advising against its use for altering the way
4452 windows are scrolled.
4453
0e5317f7
KH
44542011-12-28 Kenichi Handa <handa@m17n.org>
4455
4456 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
4457 coding-system ASCII compatible only when it does not produce BOM
4458 on encoding (Bug#10383).
4459
93d5ca1f
JD
44602011-12-26 Jan Djärv <jan.h.d@swipnet.se>
4461
4462 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
4463 can scroll.
4464 (create_and_show_popup_menu): Always use menu_position_func for
4465 Gtk3 (Bug#10361).
4466
ca22b785
AS
44672011-12-24 Andreas Schwab <schwab@linux-m68k.org>
4468
4469 * callint.c (Fcall_interactively): Don't truncate prompt string.
4470
d048e1e6
EZ
44712011-12-23 Eli Zaretskii <eliz@gnu.org>
4472
4473 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
4474 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 4475 resumed from there (after widening). (Bug#10360)
d048e1e6 4476
5ccaba1f
JD
44772011-12-22 Jan Djärv <jan.h.d@swipnet.se>
4478
4479 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
4480
204ee57f
JD
44812011-12-21 Jan Djärv <jan.h.d@swipnet.se>
4482
b81d40f0
JB
4483 * nsterm.m (x_free_frame_resources):
4484 Release f->output_data.ns->miniimage.
204ee57f
JD
4485 (ns_index_color): Fix indentation. Do not retain
4486 color_table->colors[i].
4487
4488 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
4489 before returning.
4490
4491 * nsfns.m (x_set_background_color): Assign return value from
4492 ns_index_color to face-background instead of NSColor*.
4493 (ns_implicitly_set_icon_type): Fix indentation.
4494 Change assignment in for loop to comparison.
4495
4496 * emacs.c (ns_pool): New variable.
4497 (main): Assign ns_pool.
4498 (Fkill_emacs): Call ns_release_autorelease_pool.
4499
4500 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
4501 autorelease fdesc, release fdAttrs and tdict.
4502 (ns_get_covering_families): Release charset.
4503 (ns_findfonts): Release NSFontDescriptor created with new.
4504 (ns_uni_to_glyphs): Fix indentation.
4505 (setString): Release attrStr before assigning new value.
4506
c803b2b7
JD
45072011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4508
678f4426
JD
4509 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
4510 and NS_IMPL_COCOA.
4511 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
4512 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
4513
cd394be1 45142011-12-18 David Reitter <reitter@cmu.edu>
678f4426 4515
5fecd5fc
JD
4516 * nsterm.m (ns_term_init): Subscribe for notifications
4517 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
4518 to method trackingNotification in EmacsMenu.
4519
4520 * nsmenu.m (trackingMenu): New variable.
3771cb17 4521 (trackingNotification): New method (from Aquamacs).
5fecd5fc 4522 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 4523 from Aquamacs (Bug#7030).
678f4426
JD
4524
45252011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 4526
c803b2b7
JD
4527 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
4528 (symbol_to_nsstring): Fix indentation.
4529 (ns_symbol_to_pb): New function.
cae07000
SM
4530 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
4531 (Fns_rotate_cut_buffers_internal): Remove.
4532 (Fns_store_selection_internal): Rename from
c803b2b7
JD
4533 Fns_store_cut_buffer_internal.
4534 (ns_get_foreign_selection, Fx_own_selection_internal)
4535 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
4536 (Fns_get_selection_internal, Fns_store_selection_internal):
4537 Use ns_symbol_to_pb and check if return value is nil.
4538 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
4539 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
4540 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
4541 renamed to Sns_store_selection_internal.
4542 (ns_handle_selection_request): Move code to Fx_own_selection_internal
4543 and remove this function.
4544 (ns_handle_selection_clear): Remove, never used.
4545 (Fx_own_selection_internal): Move code from ns_handle_selection_request
4546 here.
4547
e1b01a3a
KB
45482011-12-17 Ken Brown <kbrown@cornell.edu>
4549
4550 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
4551 GID is unknown (Bug#10257).
4552
2adb6e85
PE
45532011-12-17 Paul Eggert <eggert@cs.ucla.edu>
4554
4555 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
4556 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
4557 which caused a build failure on GNU/Linux IA-64. This problem was
4558 introduced by my 2011-10-07 patch.
4559
d1d7b339
JL
45602011-12-15 Juri Linkov <juri@jurta.org>
4561
4562 * image.c (imagemagick_error): New function. (Bug#10112)
4563 (imagemagick_load_image): Comment out `MagickSetResolution' call.
4564 Use `imagemagick_error' where ImageMagick functions return
4565 `MagickFalse'.
4566 (Fimagemagick_types): Add `Fnreverse' to return the list in the
4567 proper order.
4568
100d5755
KH
45692011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4570
4571 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
4572 fill background (Bug#8992).
4573
454592a6
MR
45742011-12-13 Martin Rudalics <rudalics@gmx.at>
4575
4576 * window.c (Vwindow_combination_resize)
4577 (Vwindow_combination_limit): Use t instead of non-nil in
4578 doc-strings.
61d4b438
MR
4579 (Vrecenter_redisplay): Add first sentence of doc-string on
4580 separate line.
53524d93 4581 (Frecenter): Fix doc-string typo.
454592a6 4582
3633e3aa
KH
45832011-12-11 Kenichi Handa <handa@m17n.org>
4584
4585 * coding.c (Funencodable_char_position): Pay attention to the
4586 buffer text relocation (Bug#9389).
4587
7b9d523a 45882011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 4589
7b9d523a
JD
4590 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
4591 gtk_init (Bug#10100).
4592
b73189c6
EZ
45932011-12-10 Eli Zaretskii <eliz@gnu.org>
4594
4595 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
4596 IT->string is nil. (Bug#10263)
4597
f7dfe5d6
JD
45982011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4599
83faebb4
JD
4600 * nsterm.h (x_free_frame_resources): Declare.
4601
f7dfe5d6
JD
4602 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
4603 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
4604
4605 * nsterm.h (ns_get_defaults_value): Declare.
4606
4607 * nsterm.m (ns_default): Call ns_get_defaults_value.
4608
7cd4e72c
EZ
46092011-12-09 Eli Zaretskii <eliz@gnu.org>
4610
4611 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
4612 (Bug#10170)
4613
b34d7317
YM
46142011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4615
4616 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
4617 that where the value of an _OBJC_* symbol points to is in the .bss
4618 section (Bug#10240).
4619
76470ad1
KH
46202011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4621
4622 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 4623 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 4624
745fff94
KH
46252011-12-08 Kenichi Handa <handa@m17n.org>
4626
4627 * ftfont.c (get_adstyle_property): Fix previous change
4628 (Bug#10233).
4629
6e44397c
JB
46302011-12-07 Juanma Barranquero <lekktu@gmail.com>
4631
4632 * w32.c (init_environment): If no_site_lisp, remove site-lisp
4633 dirs from the default value of EMACSLOADPATH (bug#10208).
4634
7efa6272
GM
46352011-12-07 Glenn Morris <rgm@gnu.org>
4636
4637 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
4638 installation and source directories as well. (Bug#10208)
4639
f6fc4d87
CY
46402011-12-06 Chong Yidong <cyd@gnu.org>
4641
4642 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
4643
2bf26180
GM
46442011-12-06 Glenn Morris <rgm@gnu.org>
4645
4646 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
4647 as an error, not just -1. (Bug#10217)
4648
3a6ad4f0
CY
46492011-12-05 Chong Yidong <cyd@gnu.org>
4650
4651 * keyboard.c (process_special_events): New function.
4652 (swallow_events, Finput_pending_p): Use it (Bug#10195).
4653
75a3b399
PE
46542011-12-05 Paul Eggert <eggert@cs.ucla.edu>
4655
4656 * coding.c (encode_designation_at_bol): Don't use uninitialized
4657 local variable (Bug#9318).
4658
c3c9e25e
KH
46592011-12-05 Kenichi Handa <handa@m17n.org>
4660
4661 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
4662 return Qnil (Bug#8046, Bug#10193).
4663
5eb05ea3
KH
46642011-12-05 Kenichi Handa <handa@m17n.org>
4665
4666 * coding.c (encode_designation_at_bol): New args charbuf_end and
4667 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
4668 (coding_set_source): Return how many bytes coding->source was
4669 relocated.
4670 (coding_set_destination): Return how many bytes
4671 coding->destination was relocated.
4672 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 4673 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
4674
46752011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4676
4677 * coding.c (CODING_CHAR_CHARSET_P): New macro.
4678 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
4679 macro (Bug#9318).
4680
46812011-12-05 Andreas Schwab <schwab@linux-m68k.org>
4682
4683 The following changes are to fix Bug#9318.
4684
a79703f5 4685 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
4686 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
4687 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 4688 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 4689
7dbda6df
JB
46902011-12-05 Juanma Barranquero <lekktu@gmail.com>
4691
4692 * lisp.h (process_quit_flag): Fix external declaration.
4693
6d5eb5b0
SM
46942011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
4695
4696 Don't macro-inline non-performance-critical code.
4697 * eval.c (process_quit_flag): New function.
4698 * lisp.h (QUIT): Use it.
4699
a0c3fad0
JD
47002011-12-04 Jan Djärv <jan.h.d@swipnet.se>
4701
4702 * nsfns.m (get_geometry_from_preferences): New function.
4703 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
4704
6c07aac2
AS
47052011-12-04 Andreas Schwab <schwab@linux-m68k.org>
4706
4707 * emacs.c (Qkill_emacs): Define.
4708 (syms_of_emacs): Initialize it.
4709 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
4710 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
4711 (quit_throw_to_read_char): Add parameter `from_signal'.
4712 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
4713 * lisp.h (QUIT): Call Fkill_emacs if requested.
4714
c052ead4
JD
47152011-12-03 Jan Djärv <jan.h.d@swipnet.se>
4716
4717 * widget.c (update_wm_hints): Return if wmshell is null.
4718 (widget_update_wm_size_hints): New function.
4719
4720 * widget.h (widget_update_wm_size_hints): Declare.
4721
4722 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
4723 widget_update_wm_size_hints (Bug#10104).
4724
9e49252b
EZ
47252011-12-03 Eli Zaretskii <eliz@gnu.org>
4726
4727 * xdisp.c (handle_invisible_prop): If the invisible text ends just
4728 before a newline, prepare the bidi iterator for consuming the
4729 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 4730 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 4731
02b16839
JL
47322011-12-02 Juri Linkov <juri@jurta.org>
4733
4734 * search.c (Fword_search_regexp): New Lisp function created from
4735 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
4736 (Fword_search_backward, Fword_search_forward)
4737 (Fword_search_backward_lax, Fword_search_forward_lax):
4738 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
4739 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
4740
0068070e
SM
47412011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
4742
4743 * fileio.c (Finsert_file_contents): Move after-change-function call
4744 to before the "handled:" label, since all "goto handled" appear in
4745 cases where the *-change-functions have already been properly called
4746 (bug#10117).
4747
3360a3fc
AS
47482011-12-01 Andreas Schwab <schwab@linux-m68k.org>
4749
4750 * keyboard.c (interrupt_signal): Don't call kill-emacs when
4751 waiting for input. (Bug#10169)
4752
73d6c093
EZ
47532011-11-30 Eli Zaretskii <eliz@gnu.org>
4754
4755 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
4756 verifies glyph row's hash code--we have just reallocated the
4757 glyphs, so their contents can be complete garbage. (Bug#10164)
4758
febe6bea
JB
47592011-11-30 Juanma Barranquero <lekktu@gmail.com>
4760
4761 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
4762
801a4313
EZ
47632011-11-30 Eli Zaretskii <eliz@gnu.org>
4764
4765 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
4766 attributes are tested _before_ calling verify_row_hash, to protect
4767 against GCC re-ordering of the tests. (Bug#10164)
4768
2b56b87e
JD
47692011-11-29 Jan Djärv <jan.h.d@swipnet.se>
4770
4771 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
4772
4773 * xterm.c (handle_one_xevent): Only set async_visible and friends
4774 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 4775 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
4776 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
4777
dbf31225
PE
47782011-11-28 Paul Eggert <eggert@cs.ucla.edu>
4779
4780 Remove GCPRO-related macros that exist only to avoid shadowing locals.
4781 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
4782 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
4783 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4784 All uses changed to use GCPRO1 etc.
4785 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
4786 Revert to old implementation (i.e., before 2011-03-11).
4787
1305621b
YM
47882011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4789
4790 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
4791 of scroll runs so as to avoid assigning disabled bogus rows and
4792 unnecessary graphics copy operations.
4793
8c9afb46
EZ
47942011-11-27 Eli Zaretskii <eliz@gnu.org>
4795
4796 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
4797 (snprintf) [_MSC_VER]: Redirect to _snprintf.
4798 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
4799 (malloc, free, realloc, calloc): Redirect to e_* only when
4800 compiling Emacs.
4801
4802 * lisp.h (GCTYPEBITS): Move before first use.
4803 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
4804 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
4805 this macro definition.
4806
4807 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
4808 _MSC_VER.
4809
54e9e3bf
JD
48102011-11-27 Jan Djärv <jan.h.d@swipnet.se>
4811
6d5eb5b0
SM
4812 * gtkutil.c (xg_create_frame_widgets):
4813 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
4814 present with Gtk+ 2.0.
4815
83aca1cb
PE
48162011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4817
4818 * fileio.c (Finsert_file_contents): Undo previous change; see
4819 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4820
5b76caa4
PE
48212011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4822
4823 Rename locals to avoid shadowing.
4824 * fileio.c (Finsert_file_contents):
4825 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
4826 * process.c (wait_reading_process_output):
4827 Rename inner 'proc' to 'p' to avoid shadowing.
4828 Indent for consistency with usual Emacs style.
4829
8c535114
EZ
48302011-11-25 Eli Zaretskii <eliz@gnu.org>
4831
4832 * xdisp.c (redisplay_window): If cursor row is not fully visible
4833 after recentering, and scroll-conservatively is set to a large
4834 number, scroll window by a few more lines to make the cursor fully
4835 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
4836 (start_display): Don't move to the next line if the display should
4837 start at a newline that is part of a display vector or an overlay
4838 string. (Bug#10119)
8c535114 4839
fa4fdb5c
JL
48402011-11-24 Juri Linkov <juri@jurta.org>
4841
4842 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
4843 after the `MagickPingImage' call. (Bug#10112)
4844
90ec88df
CY
48452011-11-23 Chong Yidong <cyd@gnu.org>
4846
4847 * window.c (Fcoordinates_in_window_p): Accept only live windows.
4848
56e2e794
MR
48492011-11-23 Martin Rudalics <rudalics@gmx.at>
4850
4851 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
4852 making another buffer current. (Bug#10114)
4853
b6e64c41
GM
48542011-11-23 Glenn Morris <rgm@gnu.org>
4855
4856 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
4857
6b21de18
CY
48582011-11-23 Chong Yidong <cyd@gnu.org>
4859
4860 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
4861 using it (Bug#5984).
4862
b12cd789
EZ
48632011-11-22 Eli Zaretskii <eliz@gnu.org>
4864
4865 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
4866 and header-lines, as they don't have one computed for them.
4867 (Bug#10098)
4868
4869 * .gdbinit (prow): Make displayed values more self-explaining.
4870 Add row's hash code.
4871
261b6fd4
LMI
48722011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
4873
4874 * process.c (wait_reading_process_output): Fix asynchrounous
4875 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 4876 (wait_reading_process_output): Add comment and URL.
261b6fd4 4877
e7cfd277
JD
48782011-11-21 Jan Djärv <jan.h.d@swipnet.se>
4879
4880 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
4881
a9b9b7f5
CY
48822011-11-21 Chong Yidong <cyd@gnu.org>
4883
4884 * window.c (Fnext_window, Fprevious_window): Doc fix.
4885
b0d15b4f
SM
48862011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4887
4888 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
4889
fe7a3057
JB
48902011-11-20 Juanma Barranquero <lekktu@gmail.com>
4891
4892 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
4893
d2999b1a
MR
48942011-11-20 Martin Rudalics <rudalics@gmx.at>
4895
4896 * window.c (Fset_window_combination_limit): Rename argument
4897 STATUS to LIMIT.
4898 (Vwindow_combination_limit): Remove "status" from doc-string.
4899
d5ff9cd0
AS
49002011-11-20 Andreas Schwab <schwab@linux-m68k.org>
4901
4902 * m/ibms390.h: Remove.
4903 * m/ibms390x.h: Don't include "ibms390.h".
4904
a5bb9bd3
SM
49052011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4906
4907 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
4908 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
4909
cd1181db
JB
49102011-11-20 Juanma Barranquero <lekktu@gmail.com>
4911
4912 * casetab.c (Fset_case_table):
4913 * charset.c (Fcharset_after): Fix typos.
4914
615a3b8d 49152011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 4916
17e845af
PE
4917 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
4918 Otherwise, valgrind does not work on some platforms.
4919 Problem reported by Andreas Schwab in
6a0bf43d
PE
4920 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
4921 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
4922 is set, removing the need for VIRT_ADDRESS_VARIES.
4923 (PURE_P): Use a more-efficient implementation that needs just one
4924 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
4925 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
4926 to 4 (xorl, subq, cmpq, setbe).
4927 * alloc.c (pure): Always extern now, since that's the
4928 VIRT_ADDR_VARIES behavior.
4929 (PURE_POINTER_P): Use a single comparison, not two, for
4930 consistency with the new puresize.h.
4931 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
4932 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
4933 Remove VIRT_ADDR_VARIES no longer needed.
4934
f8fe6f96
EZ
49352011-11-19 Eli Zaretskii <eliz@gnu.org>
4936
4937 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
4938 (erase_phys_cursor, update_window_cursor, show_mouse_face)
4939 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
4940 behave as if the cursor position were at the window margin.
4941
4942 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
4943 and the cursor position is out of bounds, behave as if the cursor
4944 position were at the window margin. (Bug#10075)
4945
df05a53c
CY
49462011-11-18 Chong Yidong <cyd@gnu.org>
4947
4948 * window.c (Fwindow_combination_limit): Make first argument
4949 non-optional, since it is meaningless for live windows like the
4950 selected window.
61ccba97 4951
2071918e
DA
49522011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
4953
4954 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
4955
b50a28de
SM
49562011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
4957
4958 * intervals.c: Fix grafting over the whole buffer (bug#10071).
4959 (graft_intervals_into_buffer): Simplify.
4960
015137db
EZ
49612011-11-18 Eli Zaretskii <eliz@gnu.org>
4962
4963 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
4964 hash values of the two rows.
4965 (copy_row_except_pointers): Preserve the used[] arrays and the
4966 hash values of the two rows. (Bug#10035)
68c95424 4967 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
4968
4969 * xdisp.c (row_hash): New function, body extracted from
4970 compute_line_metrics.
4971 (compute_line_metrics): Call row_hash, instead of computing the
4972 hash code inline.
4973
4974 * dispnew.c (verify_row_hash): Call row_hash for computing the
4975 hash code of a row, instead of duplicating code from xdisp.c.
4976
4977 * dispextern.h (row_hash): Add prototype.
4978
a2addb04
TH
49792011-11-18 Tassilo Horn <tassilo@member.fsf.org>
4980
4981 * frame.c (delete_frame): Don't delete the terminal when the last
4982 X frame is closed if emacs is built with GTK toolkit.
4983
df85d315
JB
49842011-11-17 Juanma Barranquero <lekktu@gmail.com>
4985
4986 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
4987
a0c2d0ae
MR
49882011-11-17 Martin Rudalics <rudalics@gmx.at>
4989
4990 * window.c (Vwindow_splits): Rename to
4991 Vwindow_combination_resize. Suggested by Juri Linkov.
4992 (Fsplit_window_internal): Use Vwindow_combination_resize instead
4993 of Vwindow_splits.
4994
58179cce
JB
49952011-11-16 Juanma Barranquero <lekktu@gmail.com>
4996
7877f373
JB
4997 * nsfns.m (Fns_font_name):
4998 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 4999
b6f67890
MR
50002011-11-16 Martin Rudalics <rudalics@gmx.at>
5001
5002 * window.h (window): Rename slot "nest" to "combination_limit".
5003 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
5004 (Fset_window_nest): Rename to Fset_window_combination_limit.
5005 (Vwindow_nest): Rename to Vwindow_combination_limit.
5006 (recombine_windows, make_parent_window, make_window)
5007 (Fsplit_window_internal, saved_window)
5008 (Fset_window_configuration, save_window_save): Rename all
5009 occurrences of window_nest to window_combination_limit.
5010
c7015153
JB
50112011-11-15 Juanma Barranquero <lekktu@gmail.com>
5012
5013 * image.c (imagemagick_load_image): Fix typo.
5014
322ad6ec
EZ
50152011-11-14 Eli Zaretskii <eliz@gnu.org>
5016
5017 * xdisp.c (display_line): Move the call to
5018 highlight_trailing_whitespace before the call to
5019 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
5020 faces of all the glyphs to compute ROW's hash value.
5021 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 5022
f067b8ec
JB
50232011-11-14 Juanma Barranquero <lekktu@gmail.com>
5024
5025 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
5026 just return (bug#10044).
5027
1e5b2111
EZ
50282011-11-12 Eli Zaretskii <eliz@gnu.org>
5029
7ef3cbd5
EZ
5030 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
5031 with user-defined heap size. Bump the default size of the temacs
5032 heap to 27MB, to avoid memory warning when running temacs.
5033 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
5034
1e5b2111
EZ
5035 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
5036 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
5037 (verify_row_hash) [XASSERTS]: New function.
5038 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
5039 that the hash value of glyph rows is correct.
1e5b2111 5040
89d61221
MR
50412011-11-12 Martin Rudalics <rudalics@gmx.at>
5042
5043 * window.h (window): Remove splits slot.
5044 * window.c (Fwindow_splits, Fset_window_splits): Remove.
5045 (Fdelete_other_windows_internal, make_parent_window)
5046 (make_window, Fsplit_window_internal, Fdelete_window_internal)
5047 (Fset_window_configuration, save_window_save): Don't deal with
5048 split status of windows.
5049 (saved_window): Remove splits slot.
5050 (Vwindow_splits): Rewrite doc-string.
5051
97f18cc8
JD
50522011-11-11 Jan Djärv <jan.h.d@swipnet.se>
5053
5054 * xfns.c (unwind_create_frame):
5055 * nsfns.m (unwind_create_frame):
5056 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
5057 Vframe_list (Bug#9999).
5058
22a648b4
DA
50592011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
5060
0b381c7e 5061 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 5062
659afede
KH
50632011-11-11 Kenichi Handa <handa@m17n.org>
5064
5065 * callproc.c (Fcall_process): Set the member dst_multibyte of
5066 process_coding.
5067
9ac0394b
KH
50682011-11-11 Johan Bockgård <bojohan@gnu.org>
5069
5070 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
5071 avoid a crash (bug#9496).
5072
2fbdc249
CY
50732011-11-09 Chong Yidong <cyd@gnu.org>
5074
5075 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
5076 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
5077
ac6b1f81
PE
50782011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5079
5080 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
5081
09db192c
PE
50822011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5083
5084 Avoid some portability problems by eschewing 'extern inline' functions.
5085 The trivial performance wins aren't worth the portability hassles; see
5086 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
5087 et seq.
5088 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5089 (window_box_width, window_box_left, window_box_left_offset)
5090 (window_box_right, window_box_right_offset): Undo previous change,
5091 by removing the "extern"s.
5092 * intervals.c (adjust_intervals_for_insertion)
5093 (adjust_intervals_for_deletion): Undo previous change,
5094 making these static again.
5095 (offset_intervals, temp_set_point_both, temp_set_point)
5096 (copy_intervals_to_string): No longer inline.
5097 * xdisp.c (window_text_bottom_y, window_box_width)
5098 (window_box_height, window_box_left_offset)
5099 (window_box_right_offset, window_box_left, window_box_right)
5100 (window_box): No longer inline.
5101
105216ed
CY
51022011-11-08 Chong Yidong <cyd@gnu.org>
5103
5104 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
5105 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
5106 Signal an error if not a live window.
105216ed
CY
5107 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
5108 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
5109
ae9e237f
JB
51102011-11-07 Juanma Barranquero <lekktu@gmail.com>
5111
5112 * lisp.h (syms_of_abbrev): Remove declaration.
5113 Reported by CHENG Gao <chenggao@royau.me>.
5114
c7aa8333
EZ
51152011-11-07 Eli Zaretskii <eliz@gnu.org>
5116
5117 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
5118 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
5119 of temacs in GUI mode.
5120
be7f5545
MR
51212011-11-07 Martin Rudalics <rudalics@gmx.at>
5122
5123 * window.h: Declare delete_all_child_windows instead of
5124 delete_all_subwindows.
5125 * window.c (Fwindow_nest, Fset_window_nest)
5126 (Fset_window_new_total, Fset_window_new_normal)
5127 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
5128 (delete_all_subwindows): Rename to delete_all_child_windows.
5129 (Fdelete_other_windows_internal, Fset_window_configuration):
5130 Call delete_all_child_windows instead of delete_all_subwindows.
5131 * frame.c (delete_frame): Call delete_all_child_windows instead
5132 of delete_all_subwindows.
5133
ca78dc43
PE
51342011-11-07 Paul Eggert <eggert@cs.ucla.edu>
5135
5136 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
5137 This is also needed for porting to any host where GC_MARK_STACK is
5138 not GC_MAKE_GCPROS_NOOPS.
5139 (which_symbols): Use it.
5140
a0241d01
KH
51412011-11-07 Kenichi Handa <handa@m17n.org>
5142
5143 * coding.c (coding_set_destination): Check coding->src_pos only
5144 when coding->src_object is a buffer (bug#9910).
5145
5146 * process.c (send_process): Set the member src_multibyte of coding
5147 to 0 (bug#9911) when sending a unibyte text.
5148
5149 * callproc.c (Fcall_process): Set the member src_multibyte of
5150 process_coding to 0 (bug#9912).
5151
a64bfdfa 51522011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
5153
5154 * xmenu.c (cleanup_widget_value_tree): New function.
5155 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
5156 calling free_menubar_widget_value_tree directly (Bug#9830).
5157
cb41b32a
PE
51582011-11-06 Paul Eggert <eggert@cs.ucla.edu>
5159
5160 Fix some portability problems with 'inline'.
5161 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5162 (window_box_width, window_box_left, window_box_left_offset)
5163 (window_box_right, window_box_right_offset): Declare extern.
5164 Otherwise, these inline functions do not conform to C99 and
5165 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
5166 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
5167 * intervals.c (adjust_intervals_for_insertion)
5168 (adjust_intervals_for_deletion): Now extern, because otherwise the
5169 extern inline functions 'offset_intervals' couldn't refer to it.
5170 (static_offset_intervals): Remove.
5171 (offset_intervals): Rewrite using the old contents of
5172 static_offset_intervals. The old version didn't conform to C99
5173 because an extern inline function contained a reference to an
5174 identifier with static linkage.
5175
b7041366
AS
51762011-11-06 Andreas Schwab <schwab@linux-m68k.org>
5177
5178 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
5179 GC.
5180
88a37c4d
EZ
51812011-11-06 Eli Zaretskii <eliz@gnu.org>
5182
5183 * xdisp.c (init_iterator, reseat_to_string): Don't set the
5184 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
5185 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
5186 return Qleft_to_right.
5187
49745b39
CY
51882011-11-06 Chong Yidong <cyd@gnu.org>
5189
5190 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
5191 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
5192 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
5193 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
5194 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
5195 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
5196 (Fwindow_vscroll): Doc fix.
5197 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
5198 argument, since it makes no sense to pass a live window and for
5199 consistency with window-child.
5200
1f05cd82
CS
52012011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
5202
5203 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
5204 support MSVC.
5205
22610910
JR
52062011-11-05 Jason Rumney <jasonr@gnu.org>
5207
5208 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
5209 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
5210 fonts (Bug#6029).
5211 (add_font_entity_to_list): Fix logic errors in mixed boolean and
5212 bitwise arithmetic preventing use of unicode-sip and non-truetype
5213 opentype fonts.
5214
a06776b2
EZ
52152011-11-05 Eli Zaretskii <eliz@gnu.org>
5216
3ad924ba
EZ
5217 * s/ms-w32.h (fstat, stat, utime): Move redirections to
5218 "emacs"-only part.
5219
a06776b2
EZ
5220 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
5221 initialization code to keep similarity to xfns.c after changes
5222 from 2011-11-05.
5223
c9e7db78
JD
52242011-11-05 Jan Djärv <jan.h.d@swipnet.se>
5225
a97f8f3f
JD
5226 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
5227 (unwind_create_frame): New function (Bug#9943).
5228 (Fx_create_frame): Restructure code to be more similar to the one in
5229 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
5230 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
5231 Move terminal->reference_count++ just before making the frame official
5232 (Bug#9943).
5233
5234 * nsterm.m (x_free_frame_resources): New function.
5235 (x_destroy_window): Move code to x_free_frame_resources.
5236
c9e7db78 5237 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
5238 (Fx_create_frame, x_create_tip_frame):
5239 Move terminal->reference_count++ just before making the frame
75f1671a 5240 official. Move initialization of image_cache_refcount and
c9e7db78
JD
5241 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
5242
a6fc3b5c
EZ
52432011-11-05 Eli Zaretskii <eliz@gnu.org>
5244
5245 Support MSVC build with newer versions of Visual Studio.
5246 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
5247 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
5248 nt/gmake.defs.
5249
5250 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
5251 which are not supported by MSVC.
5252 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
5253 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
5254 bitfields.
5255 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
5256 types in bitfields.
5257 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
5258
5259 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
5260
58179cce 52612011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
5262
5263 Support MSVC build with newer versions of Visual Studio.
5264 * w32.c: Don't include w32api.h for MSVC.
5265 (init_environment) [_MSC_VER]: Call sys_access, not _access.
5266
5267 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
5268 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
5269 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
5270 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
5271 e_* cousins.
5272 (alloca) [_MSC_VER]: Define to _alloca.
5273
5274 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
5275
5276 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
5277
a58c13ed
EZ
52782011-11-04 Eli Zaretskii <eliz@gnu.org>
5279
5280 * xdisp.c (note_mouse_highlight): If either of
5281 previous/next-single-property-change returns nil, treat that as
5282 the beginning or the end of the buffer. (Bug#9955)
5283
fe0b6370
JD
52842011-11-04 Jan Djärv <jan.h.d@swipnet.se>
5285
a58c13ed 5286 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
5287 label is not null (Bug#9951).
5288 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
5289 may be NULL.
5290
89bd5ee1
EZ
52912011-11-04 Eli Zaretskii <eliz@gnu.org>
5292
5293 * window.c (Fwindow_body_size): Mention in the doc string that the
5294 return value is in frame's canonical units. (Bug#9949)
5295
84c3edb9
EZ
52962011-11-03 Eli Zaretskii <eliz@gnu.org>
5297
4e2fb5c7
EZ
5298 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
5299
84c3edb9 5300 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 5301 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 5302 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 5303
bc17a887
EZ
53042011-11-01 Eli Zaretskii <eliz@gnu.org>
5305
5306 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
5307 Don't stop backward scan on the continuation glyph, even though
5308 its CHARPOS is positive.
6d5eb5b0
SM
5309 (mouse_face_from_buffer_pos, note_mouse_highlight):
5310 Rename cover_string to disp_string.
bc17a887 5311
4ee88440
MR
53122011-11-01 Martin Rudalics <rudalics@gmx.at>
5313
5314 * window.c (temp_output_buffer_show): Don't use
5315 Vtemp_buffer_show_specifiers.
5316 (Vtemp_buffer_show_specifiers): Remove unused variable.
5317
c2ff3c02
EZ
53182011-10-30 Eli Zaretskii <eliz@gnu.org>
5319
5320 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
5321 past the beginning of the current glyph matrix.
5322
58179cce 53232011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
5324
5325 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
5326 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
5327 HAVE_GTK3 (Bug#9869).
b77a6a7f 5328
3b574623
JD
5329 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
5330 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
5331
b77a6a7f
JD
5332 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
5333
5334 * xterm.c: Declare x_handle_net_wm_state to return int.
5335 (handle_one_xevent): Check if we are iconified but don't have
5336 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
5337 (get_current_wm_state): Return non-zero if not hidden,
5338 check for _NET_WM_STATE_HIDDEN (Bug#9893).
5339 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
5340 (x_handle_net_wm_state): Return what get_current_wm_state returns.
5341 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
5342
196e41e4
PE
53432011-10-29 Paul Eggert <eggert@cs.ucla.edu>
5344
5345 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
5346 so that this new function doesn't get optimized away by a
5347 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
5348
021f2e1a
AS
53492011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5350
5351 * frame.h (MOUSE_HL_INFO): Remove excess parens.
5352
8b058d44
EZ
53532011-10-29 Eli Zaretskii <eliz@gnu.org>
5354
5355 Fix the `xbytecode' command.
5356 * .gdbinit (xprintbytestr): New command.
b50a28de 5357 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
5358 (xbytecode): Print the byte-code string as well.
5359
4452fb80
EZ
53602011-10-29 Kim Storm <storm@cua.dk>
5361
8b058d44
EZ
5362 * alloc.c (which_symbols): New function.
5363
21b72067
AS
53642011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5365
5366 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
5367 line. (Bug#9903)
5368
83ed7b5c
GM
53692011-10-29 Glenn Morris <rgm@gnu.org>
5370
5371 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
5372 Not clear what it was for, and it causes various bugs. (Bug#9839)
5373
5a7a728b
EZ
53742011-10-28 Eli Zaretskii <eliz@gnu.org>
5375
5376 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
5377 possible random value that matches one of those tested as
5378 condition to clear the mouse face.
5379
d3d0842f
CY
53802011-10-28 Chong Yidong <cyd@gnu.org>
5381
5382 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
5383
31b39d13
DN
53842011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
5385
5386 * window.c (make_window): Initialize phys_cursor_on_p.
5387
9aba6043
SM
53882011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
5389
5390 * lisp.h (struct Lisp_Symbol): Update comments.
5391
c20992f4
JB
53922011-10-28 Juanma Barranquero <lekktu@gmail.com>
5393
5394 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
5395
db4f02f2
EZ
53962011-10-28 Eli Zaretskii <eliz@gnu.org>
5397
5398 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
5399 <oslsachem@gmail.com> for helping to debug this.
5400
5401 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
5402 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
5403 (g_b_init_get_glyph_outline_w): New static variables.
5404 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
5405 (GetGlyphOutlineW_Proc): New typedefs.
5406 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
5407 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
5408 New functions.
5409 (w32font_open_internal, compute_metrics):
5410 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
5411 instead of calling the "wide" APIs directly.
5412
5413 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
5414
5415 * w32.h (syms_of_w32font): Add prototype.
5416
87e68db4
JB
54172011-10-27 Juanma Barranquero <lekktu@gmail.com>
5418
5419 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
5420 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
5421 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
5422 (Fmove_to_window_line): Doc fix.
5423
435c1d67
CY
54242011-10-27 Chong Yidong <cyd@gnu.org>
5425
5426 * process.c (make_process): Set gnutls_state to NULL.
5427
5428 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
5429 non-NULL, regardless of GNUTLS_INITSTAGE.
5430 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
5431 an error. Set process slots as soon as we allocate them.
5432
5433 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
5434
9c6c6f49
CY
54352011-10-27 Chong Yidong <cyd@gnu.org>
5436
9aba6043
SM
5437 * gnutls.c (emacs_gnutls_deinit): New function.
5438 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
5439 (Fgnutls_deinit, Fgnutls_boot): Use it.
5440
5441 * process.c (make_process): Initialize GnuTLS credentials to NULL.
5442 (deactivate_process): Call emacs_gnutls_deinit.
5443
657d08d3
JB
54442011-10-27 Juanma Barranquero <lekktu@gmail.com>
5445
5446 * image.c (x_create_x_image_and_pixmap):
5447 * w32.c (sys_rename, w32_delayed_load):
5448 * w32font.c (fill_in_logfont):
5449 * w32reg.c (x_get_string_resource): Silence compiler warnings.
5450
5430d399
JB
54512011-10-26 Juanma Barranquero <lekktu@gmail.com>
5452
5453 * w32fns.c (w32_default_color_map): New function,
5454 extracted from Fw32_default_color_map.
a7ef684b 5455 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 5456
fe0055fa
PE
54572011-10-25 Paul Eggert <eggert@cs.ucla.edu>
5458
5459 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
5460
e6346438
SM
54612011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
5462
5463 * keyboard.c (test_undefined): New function (bug#9751).
5464 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
5465
e112cc37
ET
54662011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
5467
5468 * sysdep.c (init_sys_modes): Fix the check for the controlling
5469 terminal (Bug#6649).
5470
7b5d6677
EZ
54712011-10-20 Eli Zaretskii <eliz@gnu.org>
5472
5473 * dispextern.h (struct bidi_it): New member next_en_type.
5474
5475 * bidi.c (bidi_line_init): Initialize the next_en_type member.
5476 (bidi_resolve_explicit_1): When next_en_pos is valid for the
5477 current character, check also for next_en_type being WEAK_EN.
5478 (bidi_resolve_weak): Don't enter the expensive loop if the current
5479 position is before next_en_pos. Record the bidi type of the first
5480 non-ET, non-BN character we find, in addition to its position.
5481 (bidi_level_of_next_char): Invalidate next_en_type when
5482 next_en_pos is over-stepped.
5483
7da0b018
PE
54842011-10-20 Paul Eggert <eggert@cs.ucla.edu>
5485
5486 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
5487 * editfns.c: Rewrite current-time-zone so that it invokes
5488 the equivalent of (format-time-string "%Z") to get the time zone name.
5489 This fixes a bug when the time zone name contains characters that
5490 need converting from the system time locale to Emacs internal format.
5491 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
5492 that patch fixed format-time-string to do the conversion, but
5493 I forgot to fix current-time-zone.
5494 (format_time_string): New function, containing most of
5495 what Fformat_time_string used to contain.
5496 (Fformat_time_string): Rewrite in terms of format_time_string.
5497 This doesn't change this function's behavior.
5498 (current-time-zone): Rewrite to use format_time_string.
5499 This fixes the bug reported by Michael Schierl in
5500 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
5501 Jason Rumney's 2007-06-07 change worked around this bug, but
5502 didn't fix it.
5503 * systime.h (tzname, timezone): Remove no-longer-used declarations.
5504
8547b010
EZ
55052011-10-19 Eli Zaretskii <eliz@gnu.org>
5506
5507 * xdisp.c (start_display): If the character at POS is displayed
5508 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
5509 (try_window_reusing_current_matrix): If a line ends in a display
5510 vector or the next line starts in a display vector, continue
5511 redrawing the window even though the character position of
5512 start_row was reached.
8547b010
EZ
5513 (Bug#9771, part 2)
5514
4e948d15
CY
55152011-10-18 Chong Yidong <cyd@gnu.org>
5516
5517 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
5518 with nobreak-char-display too.
5519
4787455f
EZ
55202011-10-18 Eli Zaretskii <eliz@gnu.org>
5521
5522 Fix part 3 of bug#9771.
5523 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
5524 (bidi_resolve_neutral): Don't enter the expensive loop looking for
5525 non-neutral characters if the current character is a paragraph
5526 separator (a.k.a. Newline). This avoids running the same
5527 expensive loop twice, once when we consume the preceding newline
5528 and the other time when the line actually needs to be displayed.
5529 Avoid the loop when we see neutrals on the base embedding level
5530 following a character whose directionality is the same as the
5531 paragraph's. This avoids running the expensive loop when a line
5532 ends in a long sequence of neutrals, like control characters.
5533 Add assertion against STRONG_AL type. Slightly rearrange code
5534 that determines the type of a neutral given the first non-neutral
5535 that follows it.
5536 (bidi_level_of_next_char): Set next_en_pos to zero when
5537 invalidating its info.
5538
2c91f553
EZ
55392011-10-17 Eli Zaretskii <eliz@gnu.org>
5540
5541 * xdisp.c (push_display_prop): Determine whether to record string
5542 or buffer position by IT->string, not by IT->method. Allow
5543 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
5544 (move_it_vertically_backward): Don't look for character position
5545 immediately after the newline when in a continuation line.
5546 (Bug#9771, part 1)
2c91f553 5547
c7b08b0d
MR
55482011-10-15 Martin Rudalics <rudalics@gmx.at>
5549
5550 * window.c (coordinates_in_window): Rewrite and delabelize
5551 vertical border check. (Bug#5357) (Bug#9618)
5552
6b02f655
SM
55532011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
5554
5555 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
5556 errors in XSetWindowBorder (bug#9310).
5557
81d40c92
DA
55582011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
5559
5560 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
5561 avoid crash when xmalloc overrun checking is enabled.
5562
d4172c3b
EZ
55632011-10-13 Eli Zaretskii <eliz@gnu.org>
5564
5565 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
5566 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
5567 cursor motion with <left> and <right> arrow keys.
5568
5569 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
5570 some callers set that themselves.
5571
b00eea75
EZ
55722011-10-12 Eli Zaretskii <eliz@gnu.org>
5573
5574 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
5575 display string and the previous row comes from the same string and
5576 is empty. (Bug#9739) (Bug#9738)
5577
8fe012c4
SM
55782011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
5579
5580 * doc.c (get_doc_string): Encode file name (bug#9735).
5581
0074aef2
EZ
55822011-10-12 Eli Zaretskii <eliz@gnu.org>
5583
79beb178
EZ
5584 * bidi.c (bidi_level_of_next_char):
5585 * xdisp.c (get_visually_first_element): Remove old incorrect
5586 comments regarding the Unicode Line Separator character.
5587
0074aef2
EZ
5588 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
5589
6e4b3fbe
DA
55902011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
5591
5592 * alloc.c (Fgc_status): Do not access beyond zombies array
5593 boundary if nzombies > MAX_ZOMBIES.
5594 * alloc.c (dump_zombies): Add missing format specifier.
5595
0324f3af
PE
55962011-10-12 Paul Eggert <eggert@cs.ucla.edu>
5597
b5525cac
PE
5598 * xdisp.c (set_cursor_from_row): Simplify conditionals,
5599 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
5600
0324f3af
PE
5601 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
5602 Some packages use them to denote characters with modifiers.
5603
e9b5f888
AS
56042011-10-11 Andreas Schwab <schwab@linux-m68k.org>
5605
5606 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
5607 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
5608 matching a pp-number. Rename parameter var to var1.
5609
127827c0
SM
56102011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
5611
5612 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
5613
c8fd3bd0
GM
56142011-10-08 Glenn Morris <rgm@gnu.org>
5615
5616 * callint.c (Fcall_interactively): Give a more explicit error for the
5617 'c' case with a non-character input. (Bug#8479)
5618
352ec8ff
EZ
56192011-10-08 Eli Zaretskii <eliz@gnu.org>
5620
03669ccb
EZ
5621 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
5622 lines.
7061c986
EZ
5623 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
5624 lines that are hscrolled on the left.
03669ccb 5625
352ec8ff
EZ
5626 * dispnew.c (buffer_posn_from_coords): Account for a possible
5627 presence of header-line. (Bug#4426)
5628
a66cfb1c
SM
56292011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
5630
6b02f655
SM
5631 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
5632 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 5633
7c5ee88e
PE
56342011-10-07 Paul Eggert <eggert@cs.ucla.edu>
5635
5636 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
5637 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
5638 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
5639 this makes Emacs dump core during garbage collection on rare
5640 occasions. sizeof is obviously inferior to offsetof here, so
5641 stick with offsetof.
5642 (GC_POINTER_ALIGNMENT): New macro.
5643 (mark_memory): Omit 3rd (offset) arg; caller changed.
5644 Don't assume EMACS_INT alignment is the same as pointer alignment.
5645
df1bbe5b
SM
56462011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
5647
5648 * keyboard.c (read_key_sequence_remapped): New var.
5649 (read_key_sequence): Compute remapping in the right buffer.
5650 (command_loop_1): Use read_key_sequence's remapping directly.
5651
51553db6
SM
56522011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
5653
32c1fffd
SM
5654 * dired.c (file_name_completion): Don't expand file name.
5655 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
5656 before checking file name handler.
5657
51553db6
SM
5658 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
5659 they've been requested explicitly (bug#9591).
5660
b6bd1599 56612011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
5662
5663 * keymap.c (Fsingle_key_description): Use make_specified_string
5664 instead of build_string to build string from push_key_description.
5665 (Bug#5193)
5666
f701dc2a
PE
56672011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5668
4222c55d
PE
5669 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
5670 This fixes a Y2038 bug on 64-bit hosts.
5671 * buffer.c (reset_buffer):
5672 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
5673 (Fclear_buffer_auto_save_failure):
5674 Use 0, not -1, to represent an unset failure time, since time_t
5675 might not be signed.
5676
f701dc2a
PE
5677 Remove dependency on glibc malloc internals.
5678 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5679 Move back here from lisp.h, but with their new implementations.
5680 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5681 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
5682 * charset.c (charset_table_init): New static var.
5683 (syms_of_charset): Use it instead of xmalloc. This removes a
5684 dependency on glibc malloc internals. See Eli Zaretskii's comment in
5685 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
5686 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5687 Move back to alloc.c.
5688 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5689 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
5690
9ceebf39
JD
56912011-09-30 Jan Djärv <jan.h.d@swipnet.se>
5692
5693 * nsterm.m (windowDidResize): Call x_set_window_size only when
5694 ns_in_resize is true. Otherwise set pixelwidth/height and
5695 call change_frame_size (Bug#9628).
5696
cb993c58
PE
56972011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5698
3930c88b
PE
5699 Port --enable-checking=all to Fedora 14 x86-64.
5700 * charset.c (syms_of_charset): Also account for glibc malloc's
5701 internal overhead when calculating the initial malloc maximum.
5702
cb993c58
PE
5703 Port --enable-checking=all to Fedora 14 x86.
5704 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5705 Move to lisp.h.
5706 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
5707 (overrun_check_realloc, overrun_check_free):
5708 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
5709 That way, xmalloc returns a properly-aligned pointer even if
5710 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
5711 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
5712 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
5713 into account when calculating the initial malloc maximum.
5714 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5715 Move here from alloc.c, so that charset.c can use it too.
5716 Properly align; the old code wasn't right for common 32-bit hosts
5717 when configured with --enable-checking=all.
5718 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5719 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
5720
31bed486
EZ
57212011-09-29 Eli Zaretskii <eliz@gnu.org>
5722
04c70788 5723 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
5724 use EDOM.
5725
fbcaa2f3
EZ
57262011-09-28 Eli Zaretskii <eliz@gnu.org>
5727
5728 * xdisp.c (compute_display_string_end): If there's no display
5729 string at CHARPOS, return -1.
5730
5731 * bidi.c (bidi_fetch_char): When compute_display_string_end
5732 returns a negative value, treat the character as a normal
5733 character not covered by a display string. (Bug#9624)
5734
a239d4e9
JB
57352011-09-28 Juanma Barranquero <lekktu@gmail.com>
5736
5737 * lread.c (Fread_from_string): Fix typo in docstring.
5738
88652fd5
EZ
57392011-09-27 Eli Zaretskii <eliz@gnu.org>
5740
5741 * xdisp.c (handle_invisible_prop): If invisible text ends on a
5742 newline, reseat the iterator instead of bidi-iterating there one
5743 character at a time. (Bug#9610)
32c1fffd
SM
5744 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
5745 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 5746
ed497dd4
AS
57472011-09-27 Andreas Schwab <schwab@linux-m68k.org>
5748
5749 * lread.c (readevalloop): Use correct code for NBSP.
5750 (read1): Likewise. (Bug#9608)
5751
b2bf61aa
MA
57522011-09-25 Michael Albinus <michael.albinus@gmx.de>
5753
5754 * dbusbind.c (Fdbus_register_signal): When service is not
5755 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
5756
32bbb17c
GM
57572011-09-25 Glenn Morris <rgm@gnu.org>
5758
5759 * buffer.c (truncate-lines): Doc fix.
5760
94e0933e
CY
57612011-09-24 Chong Yidong <cyd@stupidchicken.com>
5762
5763 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
5764 (Fset_window_next_buffers): Doc fix.
5765
cddde921
GM
57662011-09-24 Glenn Morris <rgm@gnu.org>
5767
5768 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
5769
1260aef1
PE
57702011-09-24 Paul Eggert <eggert@cs.ucla.edu>
5771
25b4bfa0
PE
5772 Fix minor problems found by static checking.
5773 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
5774 * indent.c (Fvertical_motion): Fix == vs = typo.
5775
e3cbd34b
EZ
57762011-09-24 Eli Zaretskii <eliz@gnu.org>
5777
a66cfb1c
SM
5778 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
5779 Default value is now t. Doc fix.
6bf7006f 5780
e3cbd34b 5781 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 5782 logic when moving up, not only when moving down. Fix the
e3cbd34b 5783 confusing name and values of the it_overshoot_expected variable;
32c1fffd 5784 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
5785
5786 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
5787 CHARPOS is covered by a display string which includes newlines.
5788 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
5789 is covered by a display string with embedded newlines.
5790
a3de0cbd
MA
57912011-09-24 Michael Albinus <michael.albinus@gmx.de>
5792
5793 * dbusbind.c (Fdbus_register_signal): Add match rule to
5794 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
5795 (Fdbus_register_method, Vdbus_registered_objects_table):
5796 Fix docstring.
a3de0cbd 5797
b260039d
JM
57982011-09-24 Jim Meyering <meyering@redhat.com>
5799
32c1fffd 5800 do not ignore write error for any output size
b260039d
JM
5801 The previous change was incomplete.
5802 While it makes emacs --batch detect the vast majority of stdout
5803 write failures, errors were still ignored whenever the output size is
5804 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
5805 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
5806 && echo FAIL: ignored write error
5807 FAIL: ignored write error
5808 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
5809 && echo FAIL: ignored write error
5810 FAIL: ignored write error
5811 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
5812
8eca8a7c
AS
58132011-09-23 Andreas Schwab <schwab@linux-m68k.org>
5814
5815 * emacs.c (Fkill_emacs): In noninteractive mode exit
5816 non-successfully if a write error occurred on stdout. (Bug#9574)
5817
3341db62
EZ
58182011-09-21 Eli Zaretskii <eliz@gnu.org>
5819
5820 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
5821 the xassert test.
5822
5823 * dispextern.h (struct it): Update the comment documenting what
5824 can it->OBJECT be.
5825
8c203dbf
EZ
58262011-09-20 Eli Zaretskii <eliz@gnu.org>
5827
5828 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
5829 a display string, extend search for cursor position to end of row.
5830 (find_row_edges): If the row ends in a newline from a display
5831 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
5832 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
5833 (Fcurrent_bidi_paragraph_direction): Fix search for previous
5834 non-empty line. Fixes confusing cursor motion with arrow keys at
5835 the beginning of a line that starts with whitespace.
8c203dbf 5836
a4824228
LMI
58372011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5838
5839 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
5840 (bug#9493).
5841
33ed493b
CY
58422011-09-18 Chong Yidong <cyd@stupidchicken.com>
5843
5844 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
5845 boolean (Bug#9154).
5846
56cd55c8
EZ
58472011-09-18 Eli Zaretskii <eliz@gnu.org>
5848
5849 * xdisp.c (display_line): Record maximum and minimum buffer
5850 positions even if no glyphs were produced (e.g., by a zero-width
5851 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
5852 buffer positions that will be removed from the glyph row because
5853 they don't fit.
c02dcedf
EZ
5854 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
5855 column is beyond frame width: don't subtract 1 "pixel" when
5856 computing width of the stretch.
3e62b7e0
EZ
5857 (reseat_at_next_visible_line_start): Undo the change made on
5858 2011-09-17 that saved paragraph information and restored it after
5859 the call to `reseat'. (Bug#9545)
56cd55c8 5860
5ed99d36 58612011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
5862
5863 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
5864 and turn window cursor on if cleared (Bug#9415).
5865
5ed99d36 58662011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
5867
5868 * search.c (boyer_moore): Take unibyte characters from pattern
5869 literally. (Bug#9458)
5870
9bade7b2
EZ
58712011-09-18 Eli Zaretskii <eliz@gnu.org>
5872
5873 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
5874
e5e9d610
PE
58752011-09-18 Paul Eggert <eggert@cs.ucla.edu>
5876
87e4427a
PE
5877 Fix minor problem found by static checking.
5878 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
5879 initialized, to pacify gcc -Wuninitialized.
5880
e5e9d610
PE
5881 * fileio.c: Report proper errno when syscall falls.
5882 (Finsert_file_contents): Save and restore errno,
5883 so that report_file_error outputs the correct diagnostic.
5884 (Fwrite_region) [CLASH_DETECTION]: Likewise.
5885
a1674f0b
EZ
58862011-09-18 Eli Zaretskii <eliz@gnu.org>
5887
5888 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
5889
fbfb6dd4
EZ
58902011-09-17 Eli Zaretskii <eliz@gnu.org>
5891
5892 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
5893 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
5894
bb187662
EZ
58952011-09-17 Eli Zaretskii <eliz@gnu.org>
5896
1137e8b8 5897 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 5898 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
5899
5900 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
5901 (bidi_find_paragraph_start): Search back for paragraph beginning
5902 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
5903 (bidi_move_to_visually_next): Only trigger paragraph-related
5904 computations when the last character is a newline or at EOB, not
5905 just any NEUTRAL_B. (Bug#9470)
5906
bb187662
EZ
5907 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
5908 truncated lines if point is covered by a display string. (Bug#9524)
5909
2e621251
PE
59102011-09-16 Paul Eggert <eggert@cs.ucla.edu>
5911
5912 * xselect.c: Relax test for outgoing X longs (Bug#9498).
5913 (cons_to_x_long): New function.
5914 (lisp_data_to_selection_data): Use it. Correct the test for
5915 short-versus-long data; it was negated. Break out of vector
5916 loop, for efficiency, when a long datum is discovered.
5917
91a15bc6
SM
59182011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
5919
5920 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
5921
b41c3a35
EZ
59222011-09-16 Eli Zaretskii <eliz@gnu.org>
5923
5924 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
5925 GCC PR/17406) by declaring this function with external scope.
5926
7812ba2d
PE
59272011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5928
5929 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
5930 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
5931
cf7edc2a
AS
59322011-09-15 Andreas Schwab <schwab@linux-m68k.org>
5933
5934 * editfns.c (Fformat): Correctly handle text properties on "%%".
5935
bd01620e
EZ
59362011-09-15 Eli Zaretskii <eliz@gnu.org>
5937
5938 * xterm.c (x_draw_composite_glyph_string_foreground):
5939 * w32term.c (x_draw_composite_glyph_string_foreground):
5940 * term.c (encode_terminal_code):
5941 * composite.c (composition_update_it, get_composition_id):
5942 * xdisp.c (get_next_display_element)
5943 (fill_composite_glyph_string): Add comments about special meaning
5944 of TAB characters in a composition.
5945
a02719a3
PE
59462011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5947
5948 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
5949 This occurs when processing a multibyte format.
5950 Problem reported by Wolfgang Jenker.
a02719a3 5951
72589a3c
JB
59522011-09-15 Johan Bockgård <bojohan@gnu.org>
5953
5954 * xdisp.c (try_cursor_movement): Only check for exact match if
5955 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
5956
1c14176c
PE
59572011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5958
5959 Remove unused external symbols.
5960 * dispextern.h (calc_pixel_width_or_height): Remove decl.
5961 * xdisp.c (calc_pixel_width_or_height): Now static.
5962 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
5963 * indent.c (check_display_width):
5964 * w32term.c: Fix comment to match code.
5965 * xterm.c, xterm.h (x_catching_errors): Remove.
5966
d2eea5b5
PE
59672011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5968
5969 * xselect.c: Use signed conversions more consistently (Bug#9498).
5970 (selection_data_to_lisp_data): Assume incoming selection data are
5971 signed integers, not unsigned. This is to be consistent with
5972 outgoing selection data, which was modified to use signed integers
5973 in as part of the fix to Bug#9196 in response to Jan D.'s comment
5974 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
5975 expects long, not unsigned long.
5976
46888499
EZ
59772011-09-14 Eli Zaretskii <eliz@gnu.org>
5978
5979 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
5980 computation of loop end. Reported by Johan Bockgård
5981 <bojohan@gnu.org>.
5982
ef8ef9fb
CY
59832011-09-13 Chong Yidong <cyd@stupidchicken.com>
5984
5985 * frame.c (Fother_visible_frames_p): Function deleted.
5986
fa819fed
EZ
59872011-09-12 Eli Zaretskii <eliz@gnu.org>
5988
5989 * indent.c (compute_motion): Process display vector front to back
5990 rather than the other way around. (Bug#2496)
5991
2ba8e008
SM
59922011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
5993
5994 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
5995
20f53c69
CY
59962011-09-11 Chong Yidong <cyd@stupidchicken.com>
5997
5998 * minibuf.c (Fread_from_minibuffer): Doc fix.
5999
d562d7a4
EZ
60002011-09-11 Eli Zaretskii <eliz@gnu.org>
6001
6002 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
6003 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
6004
1c4d7f3d
LMI
60052011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6006
6007 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
6008 value for non-existent files.
6009
b885bf36
EZ
60102011-09-11 Eli Zaretskii <eliz@gnu.org>
6011
6012 * fileio.c (Finsert_file_contents): If the file cannot be opened,
6013 set its "size" to -1. This will set the modtime_size field of
6014 the corresponding buffer to -1, which is what
6015 verify-visited-file-modtime expects for files that do not exist.
6016 (Bug#9139)
6017
6612f0bf
PE
60182011-09-11 Paul Eggert <eggert@cs.ucla.edu>
6019
6020 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
6021 here ...
6022 * lisp.h: ... from here. push_key_description is no longer
6023 defined in keyboard.c, so its declaration should not be in
6024 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
6025 logically belongs with push_key_description.
6026
dfb3f755
PE
60272011-09-10 Paul Eggert <eggert@cs.ucla.edu>
6028
6029 * buffer.h: Include <sys/types.h> instead of <time.h>.
6030 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
6031 Problem reported by Herbert J. Skuhra.
6032
3134906c
LMI
60332011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
6034
6035 * xml.c (parse_region): Make the parsing work for
6036 non-comment-starting XML files again (bug#9144).
6037
8d903f4e
AS
60382011-09-10 Andreas Schwab <schwab@linux-m68k.org>
6039
6040 * image.c (gif_load): Fix calculation of bottom and right corner.
6041 (Bug#9468)
6042
80ad64f4
EZ
60432011-09-10 Eli Zaretskii <eliz@gnu.org>
6044
6045 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
6046 redisplay in small windows.
6047
208a048d
EZ
60482011-09-09 Eli Zaretskii <eliz@gnu.org>
6049
6050 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
6051
9b1c252e
MR
60522011-09-08 Martin Rudalics <rudalics@gmx.at>
6053
6054 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
6055 Operate on live windows only.
6056
2949f33b
JB
60572011-09-08 Juanma Barranquero <lekktu@gmail.com>
6058
6059 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
6060
e08dcafd
EZ
60612011-09-07 Eli Zaretskii <eliz@gnu.org>
6062
6063 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
6064 only under bidi iteration.
6065
115b96bd
JD
60662011-09-07 Jan Djärv <jan.h.d@swipnet.se>
6067
6068 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
6069
c8199d0f
PE
60702011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6071
6072 isnan: Fix porting problem to Solaris 10 with bundled gcc.
6073 Without this fix, the command to link temacs failed due to an
6074 undefined symbol __builtin_isnan. This is because
6075 /usr/include/iso/math_c99.h #defines isnan(x) to
6076 __builtin_isnan(x), but the bundled gcc, which identifies itself
6077 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
6078 a __builtin_isnan.
6079 * floatfns.c (isnan): #undef, and then #define to a clone of
6080 what's in data.c.
6081 (Fisnan): Always define, since it's always available now.
6082 (syms_of_floatfns): Always define isnan at the Lisp level.
6083
e39b275c 60842011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
6085
6086 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
6087
b2db44d9 60882011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 6089
f4af5137 6090 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
6091 The previous code assumed that file offsets (off_t values) fit in
6092 EMACS_INT variables, which is not true on typical 32-bit hosts.
6093 The code messed up by falsely reporting buffer overflow in cases
6094 such as (insert-file-contents "big" nil 1 2) into an empty buffer
6095 when "big" contains more than 2**29 bytes, even though this
6096 inserts just one byte and does not overflow the buffer.
6097 (Finsert_file_contents): Store file offsets as off_t
6098 values, not as EMACS_INT values. Check for overflow when
6099 converting between EMACS_INT and off_t. When checking for
6100 buffer overflow or for overlap, take the offsets into account.
6101 Don't use EMACS_INT for small values where int suffices.
6102 When checking for overlap, fix a typo: ZV was used where
6103 ZV_BYTE was intended.
6104 (Fwrite_region): Don't assume off_t fits into 'long'.
6105 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
6106
ecfc0a49
MA
61072011-09-05 Michael Albinus <michael.albinus@gmx.de>
6108
6109 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
6110
6511acf2 61112011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 6112
0999621a 6113 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
6114
6115 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 6116 (esprintf, exprintf, evxprintf): New functions.
62f19c19 6117 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 6118 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
6119 (modify_event_symbol): Do not assume that the length of
6120 name_alist_or_stem is safe to alloca and fits in int.
6121 (Fexecute_extended_command): Likewise for function name and binding.
6122 (Frecursion_depth): Wrap around reliably on integer overflow.
6123 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
6124 since some callers pass EMACS_INT values.
6125 (Fsingle_key_description): Don't crash if symbol name contains more
6126 than MAX_ALLOCA bytes.
6127 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
6128 (get_minibuffer): Arg is now EMACS_INT, not int.
6129 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 6130 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
6131 * window.h (command_loop_level, minibuf_level): Reflect API changes.
6132
2be7d702
PE
6133 * dbusbind.c (signature_cat): New function.
6134 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
6135 Do not overrun buffer; instead, report string overflow.
6136
9d1df220
PE
6137 * dispnew.c (add_window_display_history): Don't overrun buffer.
6138 Truncate instead; this is OK since it's just a log.
6139
33ef5c64
PE
6140 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
6141 even if the time zone offset is outlandishly large.
6142 Don't mishandle offset == INT_MIN.
6143
66c6fdd5
PE
6144 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
6145 when creating daemon; the previous buffer-overflow check was incorrect.
6146
d749b01b
PE
6147 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
6148 which has the guts of the old verror function.
6149
b5cd1905
PE
6150 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
6151 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
6152
6e1a67fb
PE
6153 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
6154 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 6155 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 6156 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
6157 length of string rather than counting it via multiple sprintfs;
6158 that's simpler and more reliable.
c21721cc
PE
6159 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
6160 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
6161 sprintf, in case result does not fit in int.
6162
c57b67fc
PE
6163 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
6164 (fontset_from_font): Print it.
6165
8a401434
PE
6166 * frame.c (tty_frame_count): Now printmax_t, not int.
6167 (make_terminal_frame, set_term_frame_name): Print it.
6168 (x_report_frame_params): In X, window IDs are unsigned long,
6169 not signed long, so print them as unsigned.
6170 (validate_x_resource_name): Check for implausibly long names,
6171 and don't assume name length fits in 'int'.
6172 (x_get_resource_string): Don't blindly alloca invocation name;
6173 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
6174 not fit in int.
6175
6e1a67fb
PE
6176 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
6177 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
6178 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
6179
0df02bf3
PE
6180 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
6181 Use esprintf, not sprintf, in case result does not fit in int.
6182
48e30793
PE
6183 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6184 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
6185 it as a large positive number.
6186 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
6187 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6188
a66ff6d8
PE
6189 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
6190 in case result does not fit in int.
6191
aca216ff
PE
6192 * print.c (float_to_string): Detect width overflow more reliably.
6193 (print_object): Make sprintf buffer a bit bigger, to avoid potential
6194 buffer overrun. Don't assume list length fits in 'int'. Treat
6195 print length of 0 as 0, not as infinity; to be consistent with other
6196 uses of print length in this function. Don't overflow print length
6197 index. Don't assume hash table size fits in 'long', or that
6198 vectorlike size fits in 'unsigned long'.
6199
31c286f7
PE
6200 * process.c (make_process): Use printmax_t, not int, to format
6201 process-name gensyms.
6202
55e5faa1
PE
6203 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
6204
80f2e268
PE
6205 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
6206 to avoid potential buffer overrun.
6207
670741ab
PE
6208 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
6209 if X resource line is longer than 512 bytes.
6210
b7163a50
PE
6211 * xfns.c (x_window): Make sprintf buffer a bit bigger
6212 to avoid potential buffer overrun.
6213
ae58ff1f
PE
6214 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
6215
c43c8a6a
PE
6216 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
6217
3f8236f4
PE
62182011-09-04 Paul Eggert <eggert@cs.ucla.edu>
6219
53e9fe90 6220 Integer overflow fixes for scrolling, etc.
6511acf2
PE
6221 Without these, Emacs silently mishandles large integers sometimes.
6222 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
6223 it were "C-u 1 M-x recenter" on a typical 64-bit host.
6224
6511acf2
PE
6225 * xdisp.c (try_window_id): Check Emacs fixnum range before
6226 converting to 'int'.
806add1d 6227
6511acf2 6228 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
6229 Check that an Emacs fixnum is in range before assigning it to 'int'.
6230 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
6231 values converted from Emacs fixnums.
6232 (Frecenter): Don't wrap around a line count if it is out of 'int'
6233 range; instead, treat it as an extreme value.
6234 (Fset_window_configuration, compare_window_configurations):
6235 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
6236
6511acf2
PE
6237 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
6238 that can exceed INT_MAX. Check that EMACS_INT value is in range
6239 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
6240 (match_limit): Don't assume that a fixnum can fit in 'int'.
6241
6511acf2 6242 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
6243 exceed INT_MAX.
6244
6511acf2 6245 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
6246 (Fvertical_motion): Don't wrap around LINES values that don't fit
6247 in 'int'. Instead, treat them as extreme values. This is good
6248 enough for windows, which can't have more than INT_MAX lines anyway.
6249
fcb901a7
LMI
62502011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6251
0f2f6b6d
LMI
6252 * Require libxml/parser.h to avoid compilation warning.
6253
fcb901a7
LMI
6254 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
6255
6256 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
6257 since this reportedly can destroy thread storage.
6258
6e20a0d4
CY
62592011-08-30 Chong Yidong <cyd@stupidchicken.com>
6260
6261 * syntax.c (find_defun_start): Update all cache variables if
6262 exiting early (Bug#9401).
6263
148ae00e
EZ
62642011-08-30 Eli Zaretskii <eliz@gnu.org>
6265
f6cfbd8f
EZ
6266 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
6267
148ae00e
EZ
6268 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
6269 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
6270 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
6271
6272 * term.c (tty_append_glyph): New function.
6273 (produce_stretch_glyph): Static function and its prototype deleted.
6274
a66cfb1c
SM
6275 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
6276 Add prototypes.
148ae00e 6277
c4a07a4c
PE
62782011-08-29 Paul Eggert <eggert@cs.ucla.edu>
6279
6280 * image.c (parse_image_spec): Check for nonnegative, not for positive,
6281 when checking :margin (Bug#9390).
6282 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 6283 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
6284 so that the name doesn't mislead. All uses changed.
6285
6bc8cd65
JB
62862011-08-28 Johan Bockgård <bojohan@gnu.org>
6287
6288 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
6289 set_tty_hooks.
6290
dca4927e
EZ
62912011-08-27 Eli Zaretskii <eliz@gnu.org>
6292
6293 * xdisp.c (move_it_to): Don't bail out early when reaching
6294 position beyond to_charpos, if we are scanning backwards.
6295 (move_it_vertically_backward): When DY == 0, make sure we get to
6296 the first character in the line after the newline.
6297
f2cad773
PE
62982011-08-27 Paul Eggert <eggert@cs.ucla.edu>
6299
6300 * ccl.c: Improve and simplify overflow checking (Bug#9196).
6301 (ccl_driver): Do not generate an out-of-range pointer.
6302 (Fccl_execute_on_string): Remove unnecessary check for
6303 integer overflow, noted by Stefan Monnier in
6304 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
6305 Remove a FIXME that didn't need fixing.
6306 Simplify the newly-introduced buffer reallocation code.
6307
0cae2cdb
JB
63082011-08-27 Juanma Barranquero <lekktu@gmail.com>
6309
6310 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
6311
5fc295a4 63122011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 6313
70c60eb2 6314 Integer and memory overflow issues (Bug#9196).
726e0ab1 6315
d31850da
PE
6316 * doc.c (get_doc_string): Rework so that
6317 get_doc_string_buffer_size is the actual buffer size, rather than
6318 being 1 less than the actual buffer size; this makes xpalloc more
6319 convenient.
6320
a69fbedb
PE
6321 * image.c (x_allocate_bitmap_record, cache_image):
6322 * xselect.c (Fx_register_dnd_atom):
6323 Simplify previous changes by using xpalloc.
6324
fe5c5d37
PE
6325 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
6326 since either will do and ptrdiff_t is convenient with xpalloc.
6327
0065d054
PE
6328 * charset.c (charset_table_size)
6329 (struct charset_sort_data.priority): Now ptrdiff_t.
6330 (charset_compare): Don't overflow if priorities differ greatly.
6331 (Fsort_charsets): Don't assume list length fits in int.
6332 Check for size-calculation overflow when allocating sort data.
6333 (syms_of_charset): Allocate an initial charset table that is
6334 just under 64 KiB, to avoid problems with glibc malloc and mmap.
6335
6336 * cmds.c (internal_self_insert): Check for size-calculation overflow.
6337
6338 * composite.h (struct composition.glyph_len): Now int, not unsigned.
6339 The actual value is always <= INT_MAX, and leaving it unsigned made
6340 overflow checking harder.
6341
6342 * dispextern.h (struct glyph_matrix.rows_allocated)
6343 (struct face_cache.size): Now ptrdiff_t, for convenience in use
6344 with xpalloc. The values are still always <= INT_MAX.
6345
6346 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
6347
6348 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
6349 (SAFE_NALLOCA): New macro.
6350
6351 * region-cache.c (struct boundary.pos, find_cache_boundary)
6352 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
6353 (set_cache_region, invalidate_region_cache)
6354 (revalidate_region_cache, know_region_cache, region_cache_forward)
6355 (region_cache_backward, pp_cache):
6356 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
6357 so that ptrdiff_t * can be passed to xpalloc.
6358 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
6359 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
6360 (pp_cache): Don't assume cache_len fits in int.
6361 * region-cache.h: Adjust extern decls to match.
6362
6363 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
6364 EMACS_INT, since either will do, for xpalloc.
6365
6366 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
6367 (xnmalloc, xnrealloc, xpalloc): New functions.
6368
726e0ab1
PE
6369 * bidi.c (bidi_shelve_header_size): New constant.
6370 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
6371 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
6372
51f30bc5 6373 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
6374 * buffer.c (overlays_at, overlays_in, record_overlay_string)
6375 (overlay_strings):
6376 Don't update size of array until after memory allocation succeeds,
6377 because xmalloc/xrealloc may not return.
0065d054
PE
6378 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
6379 now that we have proper integer overflow checking.
6380 (record_overlay_string, overlay_strings): Catch overflows when
6381 calculating size of overlay_str_buf.
726e0ab1 6382
0065d054
PE
6383 * callproc.c (Fcall_process): Check for size overflow when
6384 calculating size of args2.
6385 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
6386 Normally we prefer signed values, but sticking with ptrdiff_t would
6387 require adding more-complicated checks.
726e0ab1
PE
6388
6389 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
6390 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
6391 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 6392 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
6393
6394 * character.c (Fstring): Check for size-calculation overflow.
6395
6396 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
6397 unnecessary integer overflow. Check for size overflow.
6398 (encode_coding_object): Don't update size until xmalloc succeeds.
6399
6400 * composite.c (get_composition_id): Check for overflow in glyph
6401 length calculations.
6402
6403 Integer and memory overflow fixes for display code.
6404 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
6405 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
6406 (scrolling_window): Check for overflow in size calculations.
6407 (line_draw_cost, realloc_glyph_pool, add_row_entry):
6408 Don't assume glyph table len fits in int.
6409 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
6410 (row_table_size): Now ptrdiff_t, not int.
6411 (scrolling_window): Avoid overflow in size calculations.
6412 Don't update size until allocation succeeds.
6413 * fns.c (concat): Check for overflow in size calculations.
6414 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
6415 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6416 (NEXT_ALMOST_PRIME_LIMIT): New constant.
6417
6418 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
6419 (get_doc_string): Check for size calculation overflow.
6420 Don't update size until allocation succeeds.
6421 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
6422 EMACS_INT, where ptrdiff_t will do.
6423 (Fsubstitute_command_keys): Check for string overflow.
6424
6425 * editfns.c (set_time_zone_rule): Don't assume environment length
6426 fits in int.
6427 (message_length): Now ptrdiff_t, not int.
6428 (Fmessage_box): Don't update size until allocation succeeds.
6429 Don't assume message length fits in int.
6430 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
6431
0065d054
PE
6432 * emacs.c (main): Do not reallocate argv, since there is a null at
6433 the end that can be overwritten, and this way there's no need to
6434 worry about size-calculation overflow.
6435 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
6436
6437 * eval.c (init_eval_once, grow_specpdl): Don't update size until
6438 alloc succeeds.
6439 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
6440
6441 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
6442 (x_set_scroll_bar_width, x_figure_window_size):
6443 Check for integer overflow.
6444 (x_set_alpha): Do not assume XINT fits in int.
6445
6446 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
6447 This is for the members text_lines, text_cols, total_lines, total_cols,
6448 where the system imposes an 'int' limit.
6449
6450 * fringe.c (Fdefine_fringe_bitmap):
6451 Don't update size until alloc works.
6452
6453 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
6454 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
6455
6456 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
6457 Check for size-calculation overflow.
6458 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
6459 do, as we prefer signed integers.
6460 (id_to_widget.max_size, id_to_widget.used)
6461 (xg_store_widget_in_map, xg_remove_widget_from_map)
6462 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
6463 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
6464 Use and return ptrdiff_t, not int.
6465 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
6466 * gtkutil.h: Change prototypes to match the above.
6467
6468 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
6469 are duplicate now that they've been promoted to lisp.h.
6470 (x_allocate_bitmap_record, x_alloc_image_color)
6471 (make_image_cache, cache_image, xpm_load):
6472 Don't update size until alloc is done.
6473 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
6474 (x_detect_edges):
3256efce 6475 Check for size calculation overflow.
726e0ab1
PE
6476 (ct_colors_allocated_max): New constant.
6477 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
6478 overflow.
3256efce 6479
726e0ab1
PE
6480 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
6481 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
6482 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
6483 Use ptrdiff_t, not int, to count maps.
6484 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
6485 calculations. Don't update size until allocation succeeds.
6486 Redo calculations to avoid overflow.
726e0ab1
PE
6487 * keyboard.h: Change prototypes to match the above.
6488
6489 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
6490 to count maps.
6491 (current_minor_maps): Check for size calculation overflow.
6492 * keymap.h: Change prototypes to match the above.
6493
6494 * lread.c (read1, init_obarray): Don't update size until alloc done.
6495
6496 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
6497 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
6498
726e0ab1
PE
6499 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
6500 Now ptrdiff_t, not int.
6501 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
6502 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
6503
6504 * process.c (Fnetwork_interface_list): Check for overflow
6505 in size calculation.
6506
6507 * region-cache.c (move_cache_gap): Check for size calculation overflow.
6508
6509 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
6510 overflow. Don't bother calling xmalloc when xrealloc will do.
6511
6512 * search.c (Freplace_match): Check for size calculation overflow.
6513 (Fset_match_data): Don't assume list lengths fit in 'int'.
6514
6515 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
6516 for command line length. Do not attempt to address one before the
6517 beginning of an array, as that's not portable.
6518
6519 * term.c (max_frame_lines): Remove; unused.
6520 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
6521 not int.
6522 (encode_terminal_code, calculate_costs): Check for size
6523 calculation overflow.
6524 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
6525 table lengths and related sizes. Don't update size until alloc
6526 done. Redo calculations to avoid overflow.
6527 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
6528
6529 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
6530 subtracting pointers.
6531 (gobble_line): Check for overflow more carefully. Don't update size
6532 until alloc done.
6533
6534 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
6535 Don't update size until alloc done.
6536 Redo size calculations to avoid overflow.
6537 Check for size calculation overflow.
0065d054 6538 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
6539
6540 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
6541 Use ptrdiff_t, not int, for sizes.
6542 (store_mode_line_noprop_char): Don't update size until alloc done.
6543
0065d054
PE
6544 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
6545 Use ptrdiff_t, not int, for sizes.
6546 (Finternal_make_lisp_face, cache_face):
6547 Check for size calculation overflow.
6548 (cache_face): Treat size calculation overflows as if they were
6549 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
6550
6551 * xfns.c (x_encode_text, x_set_name_internal)
6552 (Fx_change_window_property): Use ptrdiff_t, not int, to count
6553 sizes, since they can exceed INT_MAX in size. Check for size
6554 calculation overflow.
6555
0065d054
PE
6556 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
6557 (xg_select): Check for size calculation overflow.
726e0ab1
PE
6558 Don't update size until alloc done.
6559
0065d054 6560 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 6561 as sprintf is limited to int lengths.
1d526e2f 6562
252c5ee1
PE
6563 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
6564 (X_LONG_MIN): New macros.
864d7ce7
PE
6565 Use them to make the following changes clearer.
6566 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
6567 This change doesn't affect the value now, but it may help remind
6568 future maintainers not to raise the value too much later.
6569 (SELECTION_QUANTUM): Remove, replacing with ...
6570 (selection_quantum): ... new function, which avoids overflow.
6571 All uses changed.
6572 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
6573 assumption that selection length fits in 'int'.
6574 (x_reply_selection_request, x_handle_selection_request)
6575 (x_get_window_property, receive_incremental_selection)
6576 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
6577 (lisp_data_to_selection_data, clean_local_selection_data):
6578 Use ptrdiff_t, not int, to record length of selection.
6579 (x_reply_selection_request, x_get_window_property)
6580 (receive_incremental_selection, x_property_data_to_lisp):
6581 Redo calculations to avoid overflow.
6582 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 6583 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
6584 something.
6585 (x_get_window_property, receive_incremental_selection)
6586 (lisp_data_to_selection_data, x_property_data_to_lisp):
6587 Check for size-calculation overflow.
6588 (x_get_window_property, receive_incremental_selection)
6589 (lisp_data_to_selection_data, Fx_register_dnd_atom):
6590 Don't store size until memory allocation succeeds.
6591 (x_get_window_property): Plug memory leak on memory exhaustion.
6592 Don't double-block input; malloc is safe here. Don't assume 2**34
6593 - 4 fits in unsigned long. Add an xassert to check
6594 XGetWindowProperty overflow. Be more careful about overflow
6595 calculations, and distinguish size from memory overflow better.
6596 (receive_incremental_selection): When tracing, don't assume
6597 unsigned int is less than INT_MAX.
6598 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
6599 harmful) conversions of unsigned short to int.
6600 (lisp_data_to_selection_data): Don't assume that integers
6601 in the range -65535 through -1 fit in an X unsigned short.
6602 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
6603 result parameters unless successful. Rely on cons_to_unsigned
6604 to report problems with elements; the old code wasn't right anyway.
6605 (x_check_property_data): Check for int overflow; we cannot use
6606 a wider type due to X limits.
6607 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
6608
726e0ab1 6609 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 6610
0065d054
PE
6611 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
6612 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
6613 (x_color_cells): Don't store size until memory allocation succeeds.
6614 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 6615 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
6616 (x_term_init): Don't assume length fits in int (sprintf is limited
6617 to int size).
bc18e09d 6618
ebfa62c0
PE
6619 Use ptrdiff_t for composition IDs.
6620 * character.c (lisp_string_width):
6621 * composite.c (composition_table_size, n_compositions)
6622 (get_composition_id, composition_gstring_from_id):
6623 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
6624 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
6625 * window.c (Frecenter):
6626 Use ptrdiff_t, not int, for composition IDs.
6627 * composite.c (get_composition_id): Check for integer overflow.
6628 * composite.h: Adjust prototypes to match the above changes.
6629
d3411f89
PE
6630 Use ptrdiff_t for hash table indexes.
6631 * category.c (hash_get_category_set):
6632 * ccl.c (ccl_driver):
6633 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
6634 * coding.c (coding_system_charset_list, detect_coding_system):
6635 * coding.h (struct coding_system.id):
6636 * composite.c (get_composition_id, gstring_lookup_cache):
6637 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
6638 * image.c (xpm_get_color_table_h):
6639 * lisp.h (hash_lookup, hash_put):
6640 * minibuf.c (Ftest_completion):
6641 Use ptrdiff_t for hash table indexes, not int (which is too
6642 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
6643 32-bit --with-wide-int hosts).
6644
e097a6fa
PE
6645 * charset.c (Fdefine_charset_internal): Check for integer overflow.
6646 Add a FIXME comment about memory leaks.
6647 (syms_of_charset): Don't assume xmalloc returns.
6648
5637687f
PE
6649 Don't assume that stated character widths fit in int.
6650 * character.c (Fchar_width, c_string_width, lisp_string_width):
6651 * character.h (CHAR_WIDTH):
6652 * indent.c (MULTIBYTE_BYTES_WIDTH):
6653 Use sanitize_char_width to avoid undefined and/or bad behavior
6654 with outlandish widths.
a66cfb1c 6655 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
6656 now that we have two such functions. All uses changed.
6657 (sanitize_char_width): New inline function.
6658
a2271ba2
PE
6659 Don't assume that tab-width fits in int.
6660 * character.h (sanitize_width): New inline function.
6661 (SANE_TAB_WIDTH): New macro.
6662 (ASCII_CHAR_WIDTH): Use it.
6663 * indent.c (sane_tab_width): Remove. All uses replaced by
6664 SANE_TAB_WIDTH (current_buffer).
6665 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
6666
18c52557
PE
6667 * fileio.c: Integer overflow issues with file modes.
6668 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
6669
caeeedc1
PE
6670 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
6671 Remove unreachable code.
6672 (read_hex, load_charset_map_from_file): Check for integer overflow.
6673
6df6ae42 6674 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
6675 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
6676 (x_send_scroll_bar_event): Likewise. Check that the size does not
6677 exceed limits imposed by XClientMessageEvent, as well as the usual
6678 ptrdiff_t and size_t limits.
6679
b13995db
PE
6680 * keyboard.c: Overflow, signedness and related fixes.
6681 (make_lispy_movement): Use same integer type in forward decl
6682 that is used in the definition.
6683 (read_key_sequence, keyremap_step):
6684 Change bufsize argument back to int, undoing my 2011-03-30 change.
6685 We prefer signed types, and int is wide enough here.
6686 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
6687 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
6688 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
6689 length, not size_t. Use ptrdiff_t for index, not int.
6690 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
6691 possibility of integer overflow.
6692
13464394
PE
6693 Overflow, signedness and related fixes for images.
6694
6695 * dispextern.h (struct it.stack[0].u.image.image_id)
6696 (struct_it.image_id, struct image.id, struct image_cache.size)
6697 (struct image_cache.used, struct image_cache.ref_count):
6698 * gtkutil.c (update_frame_tool_bar):
6699 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
6700 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
6701 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
6702 * nsmenu.m (update_frame_tool_bar):
6703 * xdisp.c (calc_pixel_width_or_height):
6704 * xfns.c (image_cache_refcount):
6705 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
6706 on typical 64-bit hosts.
6707
6708 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6709 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
6710 Omit unnecessary casts to int.
6711 (parse_image_spec): Check that integers fall into 'int' range
6712 when the callers expect that.
6713 (image_ascent): Redo ascent calculation to avoid int overflow.
6714 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
6715 (lookup_image): Remove unnecessary tests.
6716 (xbm_image_p): Locals are now of int, not EMACS_INT,
6717 since parse_image_check makes sure they fit into int.
6718 (png_load, gif_load, svg_load_image):
6719 Prefer int to unsigned where either will do.
6720 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
6721 old tiff_error_handler and tiff_warning_handler.
6722 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
6723 stack buffer overflows. It uses only the features of vsnprintf
6724 that are common to both POSIX and native Microsoft.
6725 (tiff_error_handler, tiff_warning_handler): Use it.
6726 (tiff_load, gif_load, imagemagick_load_image):
6727 Don't assume :index value fits in 'int'.
6728 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
6729 (imagemagick_load_image): Check that crop parameters fit into
6730 the integer types that MagickCropImage accepts. Don't assume
6731 Vimagemagick_render_type has a nonnegative value. Don't assume
6732 size_t fits in 'long'.
6733 (gs_load): Use printmax_t to print the widest integers possible.
6734 Check for integer overflow when computing image height and width.
6735
c11821d4
EZ
67362011-08-26 Eli Zaretskii <eliz@gnu.org>
6737
6738 * xdisp.c (redisplay_window): Don't force window start if point
6739 will be invisible in the resulting window. (Bug#9324)
6740
0c95fcf7
EZ
67412011-08-25 Eli Zaretskii <eliz@gnu.org>
6742
6743 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
6744 the display spec is of the form `(space ...)'.
6745 (handle_display_spec): Return the value returned by
6746 handle_single_display_spec, not just 1 or zero.
6747 (handle_single_display_spec): If the display spec is of the form
6748 `(space ...)', and specifies display in the text area, return 2
6749 rather than 1.
fee65a97 6750 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
6751 accurately, and prefer exact match for point under bidi.
6752 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
6753
6754 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
6755 into disp_prop; all users changed.
6756
6757 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
6758 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
6759 for the text covered by the display property.
6760
e4ed06f1
CY
67612011-08-25 Chong Yidong <cyd@stupidchicken.com>
6762
6763 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
6764 Change return value to nil.
6765 (Frecord_buffer): Delete unused function.
6766
f67cdd7f
EZ
67672011-08-24 Eli Zaretskii <eliz@gnu.org>
6768
5980d4c6
EZ
6769 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
6770 buffers, return left-to-right.
8610fe8b
EZ
6771 (set_cursor_from_row): Consider candidate row a win if its glyph
6772 represents a newline and point is on that newline. Fixes cursor
6773 positioning on the newline at EOL of R2L text within L2R
6774 paragraph, and vice versa.
6775 (try_cursor_movement): Check continued rows, in addition to
6776 continuation rows. Fixes unwarranted scroll when point enters a
6777 continued line of R2L text within an L2R paragraph, or vice versa.
6778 (cursor_row_p): Consider the case of point being equal to
6779 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
6780 from the end of a short line to the beginning of a continued line
6781 of R2L text within L2R paragraph.
6782 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
6783 composed characters.
5980d4c6 6784
f67cdd7f
EZ
6785 * bidi.c (bidi_check_type): Use xassert.
6786 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
6787 members.
6788
bca633fb
EZ
67892011-08-23 Eli Zaretskii <eliz@gnu.org>
6790
6791 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
6792 a character.
6793
4a5885a7
CY
67942011-08-23 Chong Yidong <cyd@stupidchicken.com>
6795
6796 * nsfont.m (ns_otf_to_script): Fix typo.
6797
0902a04e
KH
67982011-08-22 Kenichi Handa <handa@m17n.org>
6799
6800 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
6801 extra slot even if the purpose is char-code-property-table.
6802
1a2e6670
EZ
68032011-08-23 Eli Zaretskii <eliz@gnu.org>
6804
8ddde651
EZ
6805 * xdisp.c (redisplay_window): When computing centering_position,
6806 account for the height of the header line. (Bug#8874)
6807
425cc014
EZ
6808 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
6809 instead of CHAR_TO_BYTE. Fixes a crash when a completion
6810 candidate is selected by the mouse, and that candidate has a
6811 composed character under the mouse.
6812
1a2e6670
EZ
6813 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
6814 coordinates reported by pos-visible-in-window-p for a composed
6815 character in column zero.
6816
8b76d6f8
SM
68172011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
6818
6819 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
6820
dac347dd
EZ
68212011-08-22 Eli Zaretskii <eliz@gnu.org>
6822
6823 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
6824 consider it a hit if to_charpos is anywhere in the range of the
6825 composed buffer positions.
6826
e013fb34
CY
68272011-08-22 Chong Yidong <cyd@stupidchicken.com>
6828
6829 * image.c (gif_load): Don't assume that each subimage has the same
6830 dimensions as the base image. Handle disposal method that is
6831 "undefined" by the gif spec (Bug#9335).
6832
bd1ba3e8
CY
68332011-08-20 Chong Yidong <cyd@stupidchicken.com>
6834
6835 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 6836 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 6837
54a1215b
EZ
68382011-08-19 Eli Zaretskii <eliz@gnu.org>
6839
823564e5
EZ
6840 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
6841 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
6842 from an Org mode buffer to a Speedbar frame.
6843
54a1215b
EZ
6844 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
6845 a composition, take its buffer position from IT->cmp_it.charpos.
6846 Fixes cursor positioning at the beginning of a line that begins
6847 with a composed character.
6848
9778ebcc
EZ
68492011-08-18 Eli Zaretskii <eliz@gnu.org>
6850
0be6ee06
EZ
6851 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
6852 character bidirectional type, use STRONG_L instead. Fixes crashes
6853 in a buffer produced by `describe-categories'.
6854
9778ebcc
EZ
6855 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
6856 members before the level stack, so they would be saved and
6857 restored when copying iterator state. Fixes incorrect reordering
6858 around TABs covered by display properties.
6859
156bffbe
AS
68602011-08-18 Andreas Schwab <schwab@linux-m68k.org>
6861
6b02f655 6862 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 6863
72ad093b
CY
68642011-08-17 Chong Yidong <cyd@stupidchicken.com>
6865
6866 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
6867 (internal_condition_case_2, internal_condition_case_n):
6868 Remove unnecessary aborts (Bug#9081).
72ad093b 6869
35774242
EZ
68702011-08-17 Eli Zaretskii <eliz@gnu.org>
6871
6872 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
6873 has no `load' handler, try opening the file locally. (Bug#9311)
6874
db76dd85
KB
68752011-08-16 Ken Brown <kbrown@cornell.edu>
6876
6877 * gmalloc.c: Expand comment.
6878
b215eee5
EZ
68792011-08-16 Eli Zaretskii <eliz@gnu.org>
6880
6881 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
6882 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
6883
a4579d33
KB
68842011-08-16 Ken Brown <kbrown@cornell.edu>
6885
6886 Fix memory allocation problems in Cygwin build (Bug#9273).
6887
6888 * unexcw.c ( __malloc_initialized): Declare external variable.
6889 (fixup_executable): Force the dumped emacs to reinitialize malloc.
6890
8b76d6f8
SM
6891 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
6892 New variables.
a4579d33
KB
6893 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
6894 dumped emacs.
6895 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
6896 in the static heap.
6897 [CYGWIN] (special_realloc): New function.
6898 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
6899 requests to realloc storage in the static heap.
6900
3ebec551
PE
69012011-08-15 Paul Eggert <eggert@cs.ucla.edu>
6902
6903 * bidi.c (bidi_initialize): Remove unused local.
6904
9fd8be00
EZ
69052011-08-15 Eli Zaretskii <eliz@gnu.org>
6906
6b02f655
SM
6907 * bidimirror.h:
6908 * biditype.h: Remove file.
6909 * makefile.w32-in ($(BLD)/bidi.$(O)):
6910 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
6911
6912 * dispextern.h: Fix a typo in the comment to bidi_type_t.
6913
6914 * chartab.c: Improve commentary for the uniprop_table API.
6915
32413314
EZ
6916 * bidi.c (bidi_paragraph_init): Support zero value of
6917 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
6918 (bidi_initialize): Use uniprop_table instead of including
6919 biditype.h and bidimirror.h.
32413314 6920
9fd8be00
EZ
6921 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
6922 coordinates of the iterator when restoring from ppos_it.
6923 (Bug#9296)
6924
5cf2b69b
KH
69252011-08-14 Kenichi Handa <handa@m17n.org>
6926
6927 * process.c (create_process): Call setup_process_coding_systems
72ad093b 6928 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 6929
daf17d00
EZ
69302011-08-14 Eli Zaretskii <eliz@gnu.org>
6931
6932 * xdisp.c (move_it_in_display_line_to): Don't invoke
6933 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
6934 ppos_it. Fixes vertical cursor motion when line beginning is
6935 covered by an image. (Bug#9296)
6936
08e3161a
JD
69372011-08-14 Jan Djärv <jan.h.d@swipnet.se>
6938
6939 * nsterm.h (ns_run_ascript): Declare.
6940 (NSAPP_DATA2_RUNASSCRIPT): Define.
6941
6942 * nsfns.m (as_script, as_result, as_status): New static variables.
6943 (ns_run_ascript): New function.
5e617bc2 6944 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
6945 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
6946 the event loop. Get status from as_status (Bug#7276).
6947
6948 * nsterm.m (sendEvent): If event is NSApplicationDefined and
6949 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
6950 the event loop (Bug#7276).
6951
a3720aa2
AS
69522011-08-14 Andreas Schwab <schwab@linux-m68k.org>
6953
6954 * gnutls.c (QCgnutls_bootprop_priority)
6955 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
6956 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
6957 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
6958 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
6959 (QCgnutls_bootprop_verify_hostname_error)
6960 (QCgnutls_bootprop_callbacks_verify): Rename from
6961 Qgnutls_bootprop_..., all uses changed.
6962
6963 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
6964 uses changed.
6965
0a0d27fb
PE
69662011-08-14 Paul Eggert <eggert@cs.ucla.edu>
6967
19d5c50c
PE
6968 * xfaces.c (Qframe_set_background_mode): Now static.
6969 * dispextern.h (Qframe_set_background_mode): Remove decl.
6970
0a0d27fb
PE
6971 * process.c (Fnetwork_interface_info): Declare local only if needed.
6972
377538cb
JD
69732011-08-13 Jan Djärv <jan.h.d@swipnet.se>
6974
6975 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
6976 (Fnetwork_interface_list): Allocate in increments of bytes instead
6977 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
6978 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
6979 sockaddr.
6980 (struct ifflag_def): notrailers is smart on OSX.
6981 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
6982 Get hardware address with getifaddrs if available.
6983
08fff70c
EZ
69842011-08-12 Eli Zaretskii <eliz@gnu.org>
6985
6986 * xdisp.c (iterate_out_of_display_property): xassert that
6987 IT->position is set to within IT->object's boundaries. Break from
6988 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
6989 when IT->position is set up wrongly due to some bug.
6990 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
6991 (push_display_prop): Allow GET_FROM_STRING as IT->method on
6992 entry. Force push_it to save on the stack the current
6993 buffer/string position, to be restored by pop_it. Fix flags in
6994 the iterator structure wrt the object coming from a display
6995 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
6996 properties. (Bug#9284)
6997
7be1c708 69982011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 6999
7be1c708
CY
7000 * fontset.c (fontset_get_font_group): Add proper type checks.
7001 (Bug#9172)
aac0c6e3 7002
7be1c708 70032011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 7004
7be1c708
CY
7005 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
7006 and LC_VERSION_MIN_MACOSX.
7007 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
7008 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 7009
97bb72a6
EZ
70102011-08-08 Eli Zaretskii <eliz@gnu.org>
7011
7012 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
7013 no-display-properties-and-no-overlays under bidi display.
7014 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 7015 properties and overlays.
97bb72a6 7016
d5617611
CY
70172011-08-08 Chong Yidong <cyd@stupidchicken.com>
7018
37e11a63
CY
7019 * editfns.c (Fset_time_zone_rule): Document relationship with the
7020 setenv function.
7021
d5617611
CY
7022 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
7023 the font entity extracted from the cache (Bug#8109).
7024
58872834
CY
70252011-08-07 Chong Yidong <cyd@stupidchicken.com>
7026
7027 * composite.c (autocmp_chars): Don't reset point. That is done by
7028 restore_point_unwind (Bug#5984).
7029
75bfc667
JL
70302011-08-07 Juri Linkov <juri@jurta.org>
7031
7032 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
7033 to show the arg `TIME' instead of `TIMEVAL'.
7034
d1410150
EZ
70352011-08-06 Eli Zaretskii <eliz@gnu.org>
7036
7037 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
7038 display property strides EOL and includes a newline, as in
7039 longlines-mode. (Bug#9254)
75b771e4
EZ
7040 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
7041 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
7042
7043 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
7044 is non-zero, even if the data buffer is NULL. Fixes a crash in
7045 vertical-motion with longlines-mode. (Bug#9254)
7046
35928349
EZ
70472011-08-05 Eli Zaretskii <eliz@gnu.org>
7048
ec7cc85b
EZ
7049 * bidi.c <bidi_cache_total_alloc>: Now static.
7050 (bidi_initialize): Initialize bidi_cache_total_alloc.
7051
8b76d6f8 7052 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
7053 cache. (Bug#9221)
7054
7055 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
7056 amount allocated this far in `bidi_cache_total_alloc'.
7057 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
7058 non-zero, only free the data buffer without restoring the cache
7059 contents. All callers changed.
7060
7061 * dispextern.h (bidi_unshelve_cache): Update prototype.
7062
7063 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
7064 (move_it_in_display_line, move_it_to)
7065 (move_it_vertically_backward, move_it_by_lines): Replace the call
7066 to xfree to an equivalent call to bidi_unshelve_cache.
7067 (move_it_in_display_line_to): Fix logic of returning
412b6358 7068 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 7069
e2e2423b
EZ
70702011-08-05 Eli Zaretskii <eliz@gnu.org>
7071
7072 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
7073 came from a string character with a `cursor' property. (Bug#9229)
7074
ae9e757a
JD
70752011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7076
7077 * Makefile.in (LIB_PTHREAD): New variable.
7078 (LIBES): Add LIB_PTHREAD (Bug#9216).
7079
7080 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
7081 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
7082
213bd7f2
AS
70832011-08-04 Andreas Schwab <schwab@linux-m68k.org>
7084
6b02f655 7085 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 7086
99aaf75f
JD
70872011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7088
7089 * xterm.c (x_find_topmost_parent): New function.
7090 (x_set_frame_alpha): Find topmost parent window with
7091 x_find_topmost_parent and set the property there also (bug#9181).
7092 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
7093
c74e9d86
PE
70942011-08-04 Paul Eggert <eggert@cs.ucla.edu>
7095
7096 * callproc.c (Fcall_process): Avoid vfork clobbering
7097 the local vars buffer, coding_systems, current_dir.
7098
640c8776
SM
70992011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
7100
7101 * keymap.c (Fmake_composed_keymap): Move to subr.el.
7102
f26d0e4c
PE
71032011-08-03 Paul Eggert <eggert@cs.ucla.edu>
7104
8a10d76c
PE
7105 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
7106 so that it is not optimized away.
7107
f26d0e4c
PE
7108 * xdisp.c (compute_display_string_pos): Remove unused local.
7109
55439c61
EZ
71102011-08-02 Eli Zaretskii <eliz@gnu.org>
7111
7112 Fix slow cursor motion and scrolling in large buffers with
7113 selective display, like Org Mode buffers. (Bug#9218)
7114
7115 * dispextern.h (struct bidi_it): New member disp_prop_p.
7116
7117 * xdisp.c: Remove one-slot cache of display string positions.
7118 (compute_display_string_pos): Accept an additional argument
5e617bc2 7119 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
7120 for a display string or property. If found, set DISP_PROP_P
7121 non-zero.
7122
7123 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
7124 DISP_PROP_P, and pass it to compute_display_string_pos.
7125 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
7126 non-zero. All callers of bidi_fetch_char changed.
7127
fb33fa43
SM
71282011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
7129
7130 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
7131
b099e063
DM
71322010-12-03 Don March <don@ohspite.net>
7133
7134 * keymap.c (Fdefine_key): Fix non-prefix key error message when
7135 last character M-[char] is translated to ESC [char] (bug#7541).
7136
5cc7f7af
KH
71372011-08-02 Kenichi Handa <handa@m17n.org>
7138
d0fffa3f 7139 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
7140
7141 * chartab.c (uniprop_table): Make it non-static.
7142
525d5e6e
EZ
71432011-08-01 Eli Zaretskii <eliz@gnu.org>
7144
7145 * xdisp.c (forward_to_next_line_start): Accept additional argument
7146 BIDI_IT_PREV, and store into it the state of the bidi iterator had
7147 on the newline.
7148 (reseat_at_next_visible_line_start): Use the bidi iterator state
7149 returned by forward_to_next_line_start to restore the state of
7150 it->bidi_it after backing up to previous newline. (Bug#9212)
7151
31011111
AS
71522011-07-30 Andreas Schwab <schwab@linux-m68k.org>
7153
7154 * regex.c (re_comp): Protoize.
7155 (re_exec): Fix return type.
7156 (regexec): Fix type of `ret'. (Bug#9203)
7157
476371c4
PE
71582011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7159
e5d76069
PE
7160 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
7161 This is needed if max-image-size is a floating-point number.
7162
9a79b20c
AS
71632011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7164
7165 * print.c (print_object): Print empty symbol as ##.
7166
7167 * lread.c (read1): Read ## as empty symbol.
7168
d8c2fa78
AA
71692011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
7170
7171 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
7172 setting frame foreground color (Bug#9175).
7173 (x_set_background_color): Likewise.
7174
ffe57a7a
AA
7175 * nsmenu.m (-setText): Size tooltip dimensions precisely to
7176 contents (Bug#9176).
7177 (EmacsTooltip -init): Remove bezels and add shadows to
7178 tooltip windows.
7179
bf3492a5
AA
7180 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
7181 or scroll bar (Bug#8470).
7182
d55e9c53
AA
7183 * nsfont.m (nsfont_open): Remove assignment to voffset and
7184 unnecessary vars hshink, expand, hd, full_height, min_height.
7185 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
7186
7187 * nsterm.h (nsfont_info): Remove voffset field.
7188
d8c2fa78 71892011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
7190
7191 Implement strike-through and overline on NextStep (Bug#8863).
7192
7193 * nsfont.m (nsfont_open): Use underline position provided by font,
7194 instead of hard-coded value of 2.
7195 (nsfont_draw): Call ns_draw_text_decoration instead.
7196
7197 * nsterm.h: Add declaration for ns_draw_text_decoration.
7198
7199 * nsterm.m (ns_draw_text_decoration): New function for drawing
7200 underline, overline, and strike-through.
7201 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
7202 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 7203 accommodate underlining, etc.
4843aac3 7204
4cc60b9b
EZ
72052011-07-28 Eli Zaretskii <eliz@gnu.org>
7206
bc7ece87
EZ
7207 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
7208 default.
4cc60b9b 7209
476371c4
PE
72102011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7211
66606eea
PE
7212 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
7213 Without this fix, if a signal arrives just after memory fills up,
7214 'malloc' might be invoked reentrantly.
7215
476371c4
PE
7216 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
7217 In other words, assume that every image size is allowed, on non-X
7218 hosts. This assumption is probably wrong, but it lets Emacs compile.
7219
f3fcc40d
AS
72202011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7221
7222 * regex.c (re_iswctype): Convert return values to boolean.
7223
350c992f
EZ
72242011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
7225
7226 * xdisp.c (compute_display_string_pos): Don't use cached display
7227 string position if the buffer had its restriction changed.
7228 (Bug#9184)
7229
5266b4bb
PE
72302011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7231
7232 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7233
2573a837 72342011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 7235
41f55ccd 7236 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 7237
39e378da
PE
7238 * bidi.c: Integer size and overflow fixes.
7239 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
7240 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
7241 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7242 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
7243 (bidi_find_other_level_edge):
7244 Use ptrdiff_t instead of EMACS_INT where either will do.
7245 This works better on 32-bit hosts configured --with-wide-int.
7246 (bidi_cache_ensure_space): Check for size-calculation overflow.
7247 Use % rather than repeated addition, for better worst-case speed.
7248 Don't set bidi_cache_size until after xrealloc returns, because it
7249 might not return.
7250 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
7251 (bidi_cache_ensure_space): Also check that the bidi cache size
7252 does not exceed that of the largest Lisp string or buffer. See Eli
7253 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 7254
5e927815
PE
7255 * alloc.c (__malloc_size_t): Remove.
7256 All uses replaced by size_t. See Andreas Schwab's note
7257 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
7258
ca4aa935
PE
7259 * image.c: Improve checking for integer overflow.
7260 (check_image_size): Assume that f is nonnull, since
7261 it is always nonnull in practice. This is one less thing to
7262 worry about when checking for integer overflow later.
7263 (x_check_image_size): New function, which checks for integer
7264 overflow issues inside X.
7265 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
7266 This removes the need for a memory_full check.
7267 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
7268 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
7269 (xbm_read_bitmap_data): Change locals back to 'int', since
7270 their values must fit in 'int'.
7271 (xpm_load_image, png_load, tiff_load):
7272 Invoke x_create_x_image_and_pixmap earlier,
7273 to avoid much needless work if the image is too large.
7274 (tiff_load): Treat overly large images as if
7275 x_create_x_image_and_pixmap failed, not as malloc failures.
7276 (gs_load): Use x_check_image_size.
7277
5f8f9cc2
PE
7278 * gtkutil.c: Omit integer casts.
7279 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
7280 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
7281
5adf60bc
PE
7282 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
7283
c8907a93
PE
7284 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
7285 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
7286 would wrongly return t on a 64-bit host.
7287
e3c25c68
PE
7288 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
7289 The plain *_OVERFLOW macros run afoul of GCC bug 49705
7290 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
7291 and therefore cause GCC to emit a bogus diagnostic in some cases.
7292
3f791afe
PE
7293 * image.c: Integer signedness and overflow and related fixes.
7294 This is not an exhaustive set of fixes, but it's time to
7295 record what I've got.
7296 (lookup_pixel_color, check_image_size): Remove redundant decls.
7297 (check_image_size): Don't assume that arbitrary EMACS_INT values
7298 fit in 'int', or that arbitrary 'double' values fit in 'int'.
7299 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
7300 (tiff_load, imagemagick_load_image):
7301 Check for overflow in size calculations.
7302 (x_create_x_image_and_pixmap): Remove unnecessary test for
7303 xmalloc returning NULL; that can't happen.
7304 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
7305 (xpm_color_bucket): Use better integer hashing function.
7306 (xpm_cache_color): Don't possibly over-allocate memory.
7307 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
7308 (gif_memory_source):
7309 Use ptrdiff_t, not int or size_t, to record sizes.
7310 (png_load): Don't assume values greater than 2**31 fit in 'int'.
7311 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
7312 either works, as we prefer signed integers.
7313 (tiff_read_from_memory, tiff_write_from_memory):
7314 Return tsize_t, not size_t, since that's what the TIFF API wants.
7315 (tiff_read_from_memory): Don't fail simply because the read would
7316 go past EOF; instead, return a short read.
7317 (tiff_load): Omit no-longer-needed casts.
7318 (Fimagemagick_types): Don't assume size fits into 'int'.
7319
3cc5a532
PE
7320 Improve hashing quality when configured --with-wide-int.
7321 * fns.c (hash_string): New function, taken from sxhash_string.
7322 Do not discard information about ASCII character case; this
7323 discarding is no longer needed.
7324 (sxhash-string): Use it. Change sig to match it. Caller changed.
7325 * lisp.h: Declare it.
7326 * lread.c (hash_string): Remove, since we now use fns.c's version.
7327 The fns.c version returns a wider integer if --with-wide-int is
7328 specified, so this should help the quality of the hashing a bit.
7329
b312a492
PE
7330 * emacs.c: Integer overflow minor fix.
7331 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
7332 Define only if GNU_LINUX.
7333 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
7334
dfd153ae
PE
7335 * dispnew.c: Integer signedness and overflow fixes.
7336 Remove unnecessary forward decls, that were a maintenance hassle.
7337 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
7338 All uses changed.
7339 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
7340 (scrolling_window): Use ptrdiff_t, not int, for byte count.
7341 (prepare_desired_row, line_draw_cost):
7342 Use int, not unsigned, where either works.
7343 (save_current_matrix, restore_current_matrix):
7344 Use ptrdiff_t, not size_t, where either works.
7345 (init_display): Check for overflow more accurately, and without
7346 relying on undefined behavior.
7347
a81d11a3
PE
7348 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
7349 Remove, replacing with the new symbols in lisp.h. All uses changed.
7350 * fileio.c (make_temp_name):
7351 * filelock.c (lock_file_1, lock_file):
7352 * xdisp.c (message_dolog):
7353 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
7354 Use pMd etc. instead.
7355 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
7356 replacing the pWIDE etc. symbols removed from editfns.c.
7357
3300e6fd
PE
7358 * keyboard.h (num_input_events): Now uintmax_t.
7359 This is (very slightly) less likely to mess up due to wraparound.
7360 All uses changed.
7361
fd05c7e9
PE
7362 * buffer.c: Integer signedness fixes.
7363 (alloc_buffer_text, enlarge_buffer_text):
7364 Use ptrdiff_t rather than size_t when either will do, as we prefer
7365 signed integers.
7366
903fe15d
PE
7367 * alloc.c: Integer signedness and overflow fixes.
7368 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
7369 (__malloc_size_t): Default to size_t, not to int.
7370 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
7371 (Fgarbage_collect, mark_object_loop_halt, mark_object):
7372 Prefer ptrdiff_t to size_t when either would do, as we prefer
7373 signed integers.
7374 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
7375 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
7376 Now const. Initialize with values that are in range even if char
7377 is signed.
7378 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
7379 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
7380 These functions do the right thing with sizes > 2**32.
7381 (check_depth): Now ptrdiff_t, not int.
7382 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
7383 Adjust to new way of storing sizes. Check for size overflow bugs
7384 in rest of code.
7385 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
7386 slightly wrong anyway, as it missed one instance of
7387 XMALLOC_OVERRUN_CHECK_OVERHEAD.
7388 (refill_memory_reserve): Omit needless cast to size_t.
7389 (mark_object_loop_halt): Mark as externally visible.
7390
ac82cc6a
PE
7391 * xselect.c: Integer signedness and overflow fixes.
7392 (Fx_register_dnd_atom, x_handle_dnd_message):
7393 Use ptrdiff_t, not size_t, since we prefer signed.
7394 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
7395 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
7396 x_dnd_atoms_size and x_dnd_atoms_length.
7397
c2d1e36d
PE
7398 * doprnt.c: Prefer signed to unsigned when either works.
7399 * eval.c (verror):
7400 * doprnt.c (doprnt):
7401 * lisp.h (doprnt):
7402 * xdisp.c (vmessage):
7403 Use ptrdiff_t, not size_t, when using or implementing doprnt,
7404 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
7405 prefer signed arithmetic to avoid comparison confusion.
7406 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
7407 but is a bit tricky.
7408
0e926e56
PE
7409 Assume freestanding C89 headers, string.h, stdlib.h.
7410 * data.c, doprnt.c, floatfns.c, print.c:
7411 Include float.h unconditionally.
7412 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
7413 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
7414 * regex.c: Likewise for stddef.h, string.h.
7415 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
7416 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
7417 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
7418 (STDC_HEADERS): Remove obsolete defines.
7419 * sysdep.c: Include limits.h unconditionally.
7420
9cfdb3ec
PE
7421 Assume support for memcmp, memcpy, memmove, memset.
7422 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
7423 * regex.c (memcmp, memcpy):
7424 Remove; we assume C89 now.
7425
7426 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
7427 (__malloc_safe_bcopy): Remove; no longer needed.
7428
cf950e6b 7429 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
7430 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
7431 well either way, and we prefer signed to unsigned.
7432
dbf38e02
LMI
74332011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
7434
7435 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
7436 closes the connection while we're reading (bug#9182).
7437
d6f0886c 74382011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 7439
d6f0886c
JD
7440 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
7441 are specified (Bug#9168).
24e0f6b1 7442
2eb1f9e6
PE
74432011-07-25 Paul Eggert <eggert@cs.ucla.edu>
7444
7445 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
7446 Found by GCC static checking and --with-wide-int on a 32-bit host.
7447
22381272 74482011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
7449
7450 * xdisp.c (compute_display_string_pos): Fix logic of caching
7451 previous display string position. Initialize cached_prev_pos to
7452 -1. Fixes slow-down at the beginning of a buffer.
7453
f25e39b4
EZ
74542011-07-24 Eli Zaretskii <eliz@gnu.org>
7455
7456 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
7457 for attrs[LFACE_FONTSET_INDEX].
7458
04c4b52e
PE
74592011-07-23 Paul Eggert <eggert@cs.ucla.edu>
7460
7461 * xml.c (parse_region): Remove unused local
7462 that was recently introduced.
7463
c1734fbd
EZ
74642011-07-23 Eli Zaretskii <eliz@gnu.org>
7465
be18c5a5
EZ
7466 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
7467 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
7468
c1734fbd
EZ
7469 * xdisp.c (move_it_in_display_line_to): Record the best matching
7470 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
7471 exit if none of the characters scanned was an exact match.
7472 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
7473 when exact match is impossible due to invisible text, and the
7474 lines are truncated.
7475
a258d627
JD
74762011-07-23 Jan Djärv <jan.h.d@swipnet.se>
7477
7478 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
7479 for OSX >= 10.7.
7480
b6d5a689
EZ
74812011-07-22 Eli Zaretskii <eliz@gnu.org>
7482
0f74f785
EZ
7483 Fix a significant slow-down of cursor motion with C-n, C-p,
7484 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
7485 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 7486 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
7487 (next_element_from_buffer): Call compute_stop_pos_backwards to
7488 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
7489 base_level_stop.
7490 (reseat): Don't look for prev_stop, as that could mean a very long
7491 run.
7492 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
7493 <cached_disp_overlay_modiff>: Cache for last found display string
7494 position.
551918c1 7495 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
7496 about the same buffer in the same area of character positions, and
7497 the buffer wasn't changed since the time the display string
7498 position was cached.
551918c1 7499
b2d0c91a
EZ
75002011-07-22 Eli Zaretskii <eliz@gnu.org>
7501
7502 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
7503 is an integer, which is important for empty lines. (Bug#9149)
7504
043604ee
CY
75052011-07-22 Chong Yidong <cyd@stupidchicken.com>
7506
7507 * frame.c (Fmodify_frame_parameters): In tty case, update the
7508 default face if necessary (Bug#4238).
7509
da4adb04
CY
75102011-07-21 Chong Yidong <cyd@stupidchicken.com>
7511
7512 * editfns.c (Fstring_to_char): No need to explain what a character
7513 is in the docstring (Bug#6576).
7514
9abd0532
LMI
75152011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7516
7517 * xml.c (parse_region): Make sure we always return a tree.
7518
36881d16
HK
75192011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
7520
7521 * xml.c (parse_region): If a document contains only comments,
7522 return that, too.
7523
1e98674d
LMI
75242011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7525
7526 * xml.c (make_dom): Return comments, too.
7527
590bd467
PE
75282011-07-19 Paul Eggert <eggert@cs.ucla.edu>
7529
7530 Port to OpenBSD.
7531 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
7532 and the surrounding thread.
7533 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
7534 rather than fgets, and retry after EINTR. Otherwise, 'emacs
7535 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
7536 timer goes off.
7537 * s/openbsd.h (BROKEN_SIGIO): Define.
7538 * unexelf.c (unexec) [__OpenBSD__]:
7539 Don't update the .mdebug section of the Alpha COFF symbol table.
7540
f41628b2
LMI
75412011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7542
7543 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
7544 (bug#8460).
7545
b59b67c5
PE
75462011-07-18 Paul Eggert <eggert@cs.ucla.edu>
7547
15e3a074
PE
7548 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
7549 This fixes some race conditions on the permissions of any newly
7550 created file.
7551
41bed37d
PE
7552 * alloc.c (valid_pointer_p): Use pipe, not open.
7553 This fixes some permissions issues when debugging.
7554
b59b67c5
PE
7555 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
7556 If fchown fails to set both uid and gid, try to set just gid,
7557 as that is sometimes allowed. Adjust the file's mode to eliminate
7558 setuid or setgid bits that are inappropriate if fchown fails.
7559
925a6be7
SM
75602011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
7561
7562 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
7563 to compare Lisp_Objects.
7564 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
7565 global_gnutls_log_level, don't mistake it for a Lisp_Object.
7566 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
7567
52968808
AS
75682011-07-17 Andreas Schwab <schwab@linux-m68k.org>
7569
0a6a104b
AS
7570 * lread.c (read_integer): Unread even EOF character.
7571 (read1): Likewise. Properly record start position of symbol.
7572
52968808
AS
7573 * lread.c (read1): Read `#:' as empty uninterned symbol if no
7574 symbol character follows.
7575
9e381cdd
PE
75762011-07-17 Paul Eggert <eggert@cs.ucla.edu>
7577
7578 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
7579 This works around a problem with the previous change to Fcopy_file.
7580 Recent glibc declares fchown with __attribute__((warn_unused_result)),
7581 and without this change, GCC might complain about discarding
7582 fchown's return value.
7583
b5641435
JB
75842011-07-16 Juanma Barranquero <lekktu@gmail.com>
7585
7586 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
7587
a8031457
PE
75882011-07-16 Paul Eggert <eggert@cs.ucla.edu>
7589
7590 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
7591
dd889327
LMI
75922011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
7593
750c33f7
LMI
7594 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
7595 it's used from the C level.
7596
dd889327
LMI
7597 * process.c: Use the same condition for POLL_FOR_INPUT in both
7598 keyboard.c and process.c (bug#1858).
7599
87e86684
LM
76002011-07-09 Lawrence Mitchell <wence@gmx.li>
7601
7602 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
7603 (Fgnutls_boot): Use it.
7604
64348f40
AS
76052011-07-15 Andreas Schwab <schwab@linux-m68k.org>
7606
7607 * doc.c (Fsubstitute_command_keys): Revert last change.
7608
1d698799
LMI
76092011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
7610
f863868c
LMI
7611 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
7612 quotes the next character, and doesn't affect other longer
7613 sequences (bug#8935).
7614
1d698799
LMI
7615 * lread.c (syms_of_lread): Clarify that is isn't only
7616 `eval-buffer' and `eval-defun' that's affected by
7617 `lexical-binding' (bug#8460).
7618
aa4b6df6
EZ
76192011-07-15 Eli Zaretskii <eliz@gnu.org>
7620
7621 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 7622 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 7623
5d856da6
PE
76242011-07-14 Paul Eggert <eggert@cs.ucla.edu>
7625
ad6042bb
PE
7626 Fix minor problems found by static checking.
7627 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
7628 (elsz): Now a signed constant, not a size_t var. We prefer signed
7629 types to unsigned, to avoid integer comparison confusion. Without
7630 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
7631 "cannot optimize loop, the loop counter may overflow", a symptom
7632 of the confusion.
f00bbb22 7633 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
7634 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
7635
6468f31c
LMI
76362011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7637
49080b10
LMI
7638 * search.c (Fre_search_backward): Mention `case-fold-search' in
7639 all the re_search_* functions (bug#8138).
7640
6468f31c
LMI
7641 * keyboard.c (Fopen_dribble_file): Document when the file is
7642 closed (bug#8056).
7643
c965adc5
EZ
76442011-07-14 Eli Zaretskii <eliz@gnu.org>
7645
df9733bf
EZ
7646 * bidi.c (bidi_dump_cached_states): Fix format of displaying
7647 bidi_cache_idx.
7648
0bb23927
EZ
7649 Support bidi reordering of display and overlay strings.
7650 * xdisp.c (compute_display_string_pos)
7651 (compute_display_string_end): Accept additional argument STRING.
7652 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
7653 (reseat_to_string): Initialize bidi_it->string.s and
7654 bidi_it->string.schars.
7655 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
7656 NULL (avoids a crash in bidi_paragraph_init).
7657 Initialize itb.string.lstring.
0bb23927
EZ
7658 (init_iterator): Call bidi_init_it only of a valid
7659 buffer position was specified. Initialize paragraph_embedding to
7660 L2R.
7661 (reseat_to_string): Initialize the bidi iterator.
7662 (display_string): If we need to ignore text properties of
7663 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
7664 original value of -1 will not work with bidi.)
7665 (compute_display_string_pos): First arg is now struct
7666 `text_pos *'; all callers changed. Support display properties on
7667 Lisp strings.
7668 (compute_display_string_end): Support display properties on Lisp
7669 strings.
7670 (init_iterator, reseat_1, reseat_to_string): Initialize the
7671 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
7672 when iterating on a string not from display properties).
640c8776
SM
7673 (compute_display_string_pos, compute_display_string_end):
7674 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
7675 arrow keys.
7676 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
7677 base_level_stop; instead, set base_level_stop to BEGV.
7678 Fixes crashes in vertical-motion.
0bb23927
EZ
7679 (next_element_from_buffer): Improve commentary for when
7680 the iterator is before prev_stop.
7681 (init_iterator): Initialize bidi_p from the default value of
7682 bidi-display-reordering, not from buffer-local value. Use the
7683 buffer-local value only if initializing for buffer iteration.
7684 (handle_invisible_prop): Support invisible properties on strings
7685 that are being bidi-reordered.
7686 (set_iterator_to_next): Support bidi reordering of C strings and
7687 Lisp strings.
7688 (next_element_from_string): Support bidi reordering of Lisp
7689 strings.
7690 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
7691 (display_string): Support display of R2L glyph rows.
7692 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
7693 (init_iterator): Don't initialize it->bidi_p for strings
7694 here.
7695 (reseat_to_string): Initialize it->bidi_p for strings here.
7696 (next_element_from_string, next_element_from_c_string)
7697 (next_element_from_buffer): Add xassert's for correspondence
7698 between IT's object being iterated and it->bidi_it.string
7699 structure.
7700 (face_before_or_after_it_pos): Support bidi iteration.
7701 (next_element_from_c_string): Handle the case of the first string
7702 character that is not the first one in the visual order.
7703 (get_visually_first_element): New function, refactored from common
7704 parts of next_element_from_buffer, next_element_from_string, and
7705 next_element_from_c_string.
7706 (tool_bar_lines_needed, redisplay_tool_bar)
7707 (display_menu_bar): Force left-to-right direction. Add a FIXME
7708 comment for making that be controlled by a user option.
7709 (push_it, pop_it): Save and restore the state of the
7710 bidi iterator. Save and restore the bidi_p flag.
7711 (pop_it): Iterate out of display property for string iteration as
7712 well.
7713 (iterate_out_of_display_property): Support iteration over strings.
7714 (handle_single_display_spec): Set up it->bidi_it for iteration
7715 over a display string, and call bidi_init_it.
7716 (handle_single_display_spec, next_overlay_string)
7717 (get_overlay_strings_1, push_display_prop): Set up the bidi
7718 iterator for displaying display or overlay strings.
7719 (forward_to_next_line_start): Don't use the shortcut if
7720 bidi-iterating.
7721 (back_to_previous_visible_line_start): If handle_display_prop
7722 pushed the iterator stack, restore the internal state of the bidi
7723 iterator by calling bidi_pop_it same number of times.
7724 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
7725 and we are bidi-iterating, don't decrement the iterator position;
7726 instead, set the first_elt flag in the bidi iterator, to produce
7727 the same effect.
7728 (reseat_1): Remove redundant setting of string_from_display_prop_p.
7729 (push_display_prop): xassert that we are iterating a buffer.
7730 (push_it, pop_it): Save and restore paragraph_embedding member.
7731 (handle_single_display_spec, next_overlay_string)
7732 (get_overlay_strings_1, reseat_1, reseat_to_string)
7733 (push_display_prop): Set up the `unibyte' member of bidi_it.string
7734 correctly. Don't assume unibyte strings are not bidi-reordered.
7735 (compute_display_string_pos)
7736 (compute_display_string_end): Fix handling the case of C string.
7737 (push_it, pop_it): Save and restore from_disp_prop_p.
7738 (handle_single_display_spec, push_display_prop): Set the
7739 from_disp_prop_p flag.
7740 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
7741 (pop_it): Call iterate_out_of_display_property only if we are
7742 popping after iteration over a string that came from a display
7743 property. Fix a typo in popping stretch info. Add an assertion
7744 for verifying that the iterator position is in sync with the bidi
7745 iterator.
7746 (handle_single_display_spec, get_overlay_strings_1)
7747 (push_display_prop): Fix initialization of paragraph direction for
7748 string when that of the parent object is not yet determined.
7749 (reseat_1): Call bidi_init_it to resync the bidi
7750 iterator with IT's position. (Bug#7616)
7751 (find_row_edges): If ROW->start.pos gives position
7752 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
7753 (handle_stop, back_to_previous_visible_line_start, reseat_1):
7754 Reset the from_disp_prop_p flag.
7755 (SAVE_IT, RESTORE_IT): New macros.
7756 (pos_visible_p, face_before_or_after_it_pos)
7757 (back_to_previous_visible_line_start)
7758 (move_it_in_display_line_to, move_it_in_display_line)
7759 (move_it_to, move_it_vertically_backward, move_it_by_lines)
7760 (try_scrolling, redisplay_window, display_line): Use them when
7761 saving a temporary copy of the iterator and restoring it back.
7762 (back_to_previous_visible_line_start, reseat_1)
7763 (init_iterator): Empty the bidi cache "stack".
7764 (move_it_in_display_line_to): If iterator ended up at
7765 EOL, but we never saw any buffer positions smaller than
7766 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
7767 motion in bidi-reordered lines.
7768 (move_it_in_display_line_to): Record prev_method and prev_pos
7769 immediately before the call to set_iterator_to_next. Fixes cursor
7770 motion in bidi-reordered lines with stretch glyphs and strings
7771 displayed in margins. (Bug#8133) (Bug#8867)
7772 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
7773 TO_CHARPOS.
640c8776
SM
7774 (pos_visible_p): Support positions in bidi-reordered lines.
7775 Save and restore bidi cache.
0bb23927
EZ
7776
7777 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
7778 (bidi_paragraph_info): Delete unused struct.
7779 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
7780 (bidi_cache_start): New variable.
7781 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
7782 to zero.
7783 (bidi_cache_fetch_state, bidi_cache_search)
7784 (bidi_cache_find_level_change, bidi_cache_iterator_state)
7785 (bidi_cache_find, bidi_peek_at_next_level)
7786 (bidi_level_of_next_char, bidi_find_other_level_edge)
7787 (bidi_move_to_visually_next): Compare cache index with
7788 bidi_cache_start rather than with zero.
7789 (bidi_fetch_char): Accept new argument STRING; all callers
7790 changed. Support iteration over a string. Support strings with
7791 display properties. Support unibyte strings. Fix the type of
7792 `len' according to what STRING_CHAR_AND_LENGTH expects.
7793 (bidi_paragraph_init, bidi_resolve_explicit_1)
7794 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
7795 (bidi_level_of_next_char, bidi_move_to_visually_next):
7796 Support iteration over a string.
0bb23927
EZ
7797 (bidi_set_sor_type, bidi_resolve_explicit_1)
7798 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
7799 can now be zero (for strings); special values 0 and -1 were
7800 changed to -1 and -2, respectively.
7801 (bidi_char_at_pos): New function.
7802 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
7803 Call it instead of FETCH_MULTIBYTE_CHAR.
7804 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
7805 initialized to valid values.
7806 (bidi_init_it): Don't initialize charpos and bytepos with invalid
7807 values.
7808 (bidi_level_of_next_char): Allow the sentinel "position" to pass
7809 the test for valid cached positions. Fix the logic for looking up
7810 the sentinel state in the cache. GCPRO the Lisp string we are
7811 iterating.
7812 (bidi_push_it, bidi_pop_it): New functions.
7813 (bidi_initialize): Initialize the bidi cache start stack pointer.
7814 (bidi_cache_ensure_space): New function, refactored from part of
7815 bidi_cache_iterator_state. Don't assume the required size is just
7816 one BIDI_CACHE_CHUNK away.
7817 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
7818 (bidi_count_bytes, bidi_char_at_pos): New functions.
7819 (bidi_cache_search): Don't assume bidi_cache_last_idx is
7820 always valid if bidi_cache_idx is valid.
7821 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
7822 is valid if it's going to be used.
7823 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
7824 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
7825 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7826 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
7827 (bidi_find_other_level_edge, bidi_cache_start_stack):
7828 All variables related to cache indices are now EMACS_INT.
c965adc5 7829
0bb23927
EZ
7830 * dispextern.h (struct bidi_string_data): New structure.
7831 (struct bidi_it): New member `string'. Make flag members be 1-bit
7832 fields, and put them last in the struct.
640c8776
SM
7833 (compute_display_string_pos, compute_display_string_end):
7834 Update prototypes.
0bb23927
EZ
7835 (bidi_push_it, bidi_pop_it): Add prototypes.
7836 (struct iterator_stack_entry): New members bidi_p,
7837 paragraph_embedding, and from_disp_prop_p.
7838 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
7839 (bidi_shelve_cache, bidi_unshelve_cache):
7840 Declare prototypes.
0bb23927
EZ
7841
7842 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
7843 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
7844 and vector-like objects.
7845
7846 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
7847 cache around display iteration.
7848
7849 * window.c (Fwindow_end, window_scroll_pixel_based)
7850 (displayed_window_lines, Frecenter): Save and restore the bidi
7851 cache around display iteration.
7852
3bbd2265
LMI
78532011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7854
7855 * editfns.c (Fdelete_region): Clarify the use of the named
7856 parameters (bug#6788).
7857
adc47434
MR
78582011-07-14 Martin Rudalics <rudalics@gmx.at>
7859
7860 * indent.c (Fvertical_motion): Set and restore w->pointm when
7861 saving and restoring the window's buffer (Bug#9006).
7862
837c31f8
LMI
78632011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
7864
7865 * editfns.c (Fstring_to_char): Clarify just what is returned
7866 (bug#6576). Text by Eli Zaretskii.
7867
ac389d0c
JB
78682011-07-13 Juanma Barranquero <lekktu@gmail.com>
7869
7870 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
7871
0be0ce47
EZ
78722011-07-13 Eli Zaretskii <eliz@gnu.org>
7873
7874 * buffer.c (mmap_find): Fix a typo.
7875
cd18e7e3
JB
78762011-07-13 Johan Bockgård <bojohan@gnu.org>
7877
7878 Fix execution of x selection hooks.
7879 * xselect.c (Qx_lost_selection_functions)
7880 (Qx_sent_selection_functions): New vars.
7881 (syms_of_xselect): DEFSYM them.
7882 (x_handle_selection_request): Pass Qx_sent_selection_functions
7883 rather than Vx_sent_selection_functions to Frun_hook_with_args.
7884 (x_handle_selection_clear,x_clear_frame_selections):
7885 Pass Qx_lost_selection_functions rather than
7886 Vx_lost_selection_functions to Frun_hook_with_args.
7887
47ea7f44
PE
78882011-07-13 Paul Eggert <eggert@cs.ucla.edu>
7889
ac389d0c 7890 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
7891 The old code sometimes used this field without initializing it.
7892
47ea7f44
PE
7893 * alloc.c (gc_sweep): Don't read past end of array.
7894 In theory, the old code could also have corrupted Emacs internals,
7895 though it'd be very unlikely.
7896
bc985c87
AS
78972011-07-12 Andreas Schwab <schwab@linux-m68k.org>
7898
7899 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 7900 argument. (Bug#4026)
bc985c87 7901
0cf34688
LMI
79022011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
7903
b3dadd76
LMI
7904 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
7905 key" (bug#4257).
7906
0cf34688
LMI
7907 * window.c (Fset_window_start): Doc fix (bug#4199).
7908 (Fset_window_hscroll): Ditto.
7909
270768cd
PE
79102011-07-12 Paul Eggert <eggert@cs.ucla.edu>
7911
077e3dda 7912 Fix minor new problems caught by GCC 4.6.1.
270768cd 7913 * term.c (init_tty): Remove unused local.
490011a6 7914 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 7915 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 7916 not used otherwise.
270768cd 7917
b1f58454
CY
79182011-07-12 Chong Yidong <cyd@stupidchicken.com>
7919
7920 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
7921
22b9578d
LMI
79222011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7923
6e70ab07
LMI
7924 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
7925 are the mini-buffer and the echo area (bug#3320).
7926
22b9578d
LMI
7927 * term.c (init_tty): Remove support for supdup, c10 and perq
7928 terminals, which are no longer supported (bug#1482).
7929
8974cc9f
JB
79302011-07-10 Johan Bockgård <bojohan@gnu.org>
7931
7932 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
7933
a560d974
JD
79342011-07-10 Jan Djärv <jan.h.d@swipnet.se>
7935
7936 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
7937 for non-popups (Bug#3642).
7938
1dae0f0a
AS
79392011-07-10 Andreas Schwab <schwab@linux-m68k.org>
7940
268c2c36 7941 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 7942 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
7943 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
7944 * cm.c (losecursor): Likewise.
1dae0f0a
AS
7945 * data.c (fmod): Likewise.
7946 * dispnew.c (swap_glyphs_in_rows): Likewise.
7947 * emacs.c (memory_warning_signal): Likewise.
7948 * floatfns.c (float_error): Likewise.
7949 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
7950 (otf_open, font_otf_capability, generate_otf_features)
7951 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
7952 Likewise.
7953 * image.c (pbm_read_file): Likewise.
7954 * indent.c (string_display_width): Likewise.
7955 * intervals.c (check_for_interval, search_for_interval)
7956 (inc_interval_count, count_intervals, root_interval)
7957 (adjust_intervals_for_insertion, make_new_interval): Likewise.
7958 * lread.c (defalias): Likewise.
268c2c36 7959 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
7960 * regex.c (set_image_of_range_1, set_image_of_range)
7961 (regex_grow_registers): Likewise.
7962 * sysdep.c (strerror): Likewise.
7963 * termcap.c (valid_filename_p, tprint, main): Likewise.
7964 * tparam.c (main): Likewise.
7965 * unexhp9k800.c (run_time_remap, save_data_space)
7966 (update_file_ptrs, read_header, write_header, calculate_checksum)
7967 (copy_file, copy_rest, display_header): Likewise.
7968 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
7969 Likewise.
7970 * xdisp.c (check_it): Likewise.
7971 * xfaces.c (register_color, unregister_color, unregister_colors):
7972 Likewise.
7973 * xfns.c (print_fontset_result): Likewise.
7974 * xrdb.c (member, fatal, main): Likewise.
7975
99033785
PE
79762011-07-10 Paul Eggert <eggert@cs.ucla.edu>
7977
7978 Fix minor problems found by static checking (Bug#9031).
7979 * chartab.c (char_table_set_range, map_sub_char_table):
7980 Remove unused locals.
7981 (uniprop_table): Now static.
7982 * composite.c (_work_char): Remove unused static var.
7983
9cb2ac56
JB
79842011-07-09 Juanma Barranquero <lekktu@gmail.com>
7985
7986 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
7987
f25661f0
JD
79882011-07-09 Jan Djärv <jan.h.d@swipnet.se>
7989
7990 * gtkutil.c (qttip_cb): Remove code without function.
7991
8278c4fe
EZ
79922011-07-09 Eli Zaretskii <eliz@gnu.org>
7993
7994 * w32.c (pthread_sigmask): New stub.
7995
1692ae2d 79962011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 7997
8a6ebd58 7998 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
7999 sigprocmask is portable only for single-threaded applications, and
8000 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
8001 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
8002 (LIBES): Use it.
8003 * callproc.c (Fcall_process):
8004 * process.c (create_process):
8005 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
8006 Use pthread_sigmask, not sigprocmask.
123403e4 8007
1b854618
JD
80082011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8009
8010 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
8011 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
8012 wrong (Bug#8591).
8013
3fe4b549
JD
80142011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8015
0ce7e563
JD
8016 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
8017 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
8018 (xg_hide_tooltip): Fix comment.
8019
3fe4b549
JD
8020 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
8021 in registerServicesMenuSendTypes.
8022 (validRequestorForSendType): Don't check ns_return_types.
8023
8024 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
8025 ns_return_type.
8026
5df75e47
JR
80272011-07-08 Jason Rumney <jasonr@gnu.org>
8028
22610910
JR
8029 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
8030 SH_SHOW for hidden windows (Bug#5482).
8031
5df75e47
JR
8032 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
8033 frame struct members of non-existent frames (Bug#6284).
8034
699c10bd
JD
80352011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8036
4393663b
JD
8037 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
8038 variable firstTime not needed on OSX >= 10.6.
8039 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
8040 >= 10.5. Use setKnobProportion, setDoubleValue.
8041
8042 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
8043 (MAC_OS_X_VERSION_10_5): Define if not defined.
8044 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
8045 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
8046 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
8047
8048 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 8049 cString and lossyCString on OSX >= 10.4.
4393663b 8050
58179cce 8051 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
8052 sizeToFit on OSX >= 10.2.
8053
8054 * nsimage.m (allocInitFromFile): Don't use deprecated method
8055 bestRepresentationForDevice on OSX >= 10.6.
8056
8057 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
8058 to avoid warning.
8059
8060 * emacs.c: Declare unexec_init_emacs_zone.
8061
a63e0781
JD
8062 * nsgui.h: Fix compiler warning about gnulib redefining verify.
8063
699c10bd
JD
8064 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
8065
8066 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
8067 on svcsMenu (Bug#8842).
8068
8069 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
8070 ns_return_types.
8071 (Fns_list_services): Just return Qnil on 10.6, code not working there.
8072
8073 * nsterm.m (QUTF8_STRING): Declare.
8074 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
8075 (validRequestorForSendType): Return type is (id).
8076 Change indexOfObjectIdenticalTo to indexOfObject.
8077 Check if we have local selection before returning self (Bug#8842).
8078 (writeSelectionToPasteboard): Put local selection into paste board
8079 if we have a local selection (Bug#8842).
8080 (syms_of_nsterm): DEFSYM QUTF8_STRING.
8081
8082 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
8083 (ns_get_local_selection): Declare.
8084
54e10184
LMI
80852011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
8086
9888ff71
LMI
8087 * keymap.c (describe_map_tree): Don't insert a double newline at
8088 the end of the buffer (bug#1169) and return whether we inserted
8089 something.
8090
54e10184
LMI
8091 * callint.c (Fcall_interactively): Change "reading args" to
8092 "providing args" to try to clarify what it does (bug#1010).
8093
15fa4783
KH
80942011-07-07 Kenichi Handa <handa@m17n.org>
8095
8096 * composite.c (composition_compute_stop_pos): Ignore a static
8097 composition starting before CHARPOS (Bug#8915).
8098
8099 * xdisp.c (handle_composition_prop): Likewise.
8100
a8815b00
EZ
81012011-07-07 Eli Zaretskii <eliz@gnu.org>
8102
8103 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
8104 (Bug#9015)
8105
ef7b981d 81062011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
8107
8108 * character.h (unicode_category_t): New enum type.
8109
8110 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
8111 (Qchar_code_property_table): New variable.
8112 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
8113 (UNIPROP_COMPRESSED_FORM_P): New macros.
8114 (char_table_ascii): Uncompress the compressed values.
8115 (sub_char_table_ref): New arg is_uniprop. Callers changed.
8116 Uncompress the compressed values.
ac389d0c 8117 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
8118 (char_table_ref_and_range): Uncompress the compressed values.
8119 (sub_char_table_set): New arg is_uniprop. Callers changed.
8120 Uncompress the compressed values.
8121 (sub_char_table_set_range): Args changed. Callers changed.
8122 (char_table_set_range): Adjuted for the above change.
8123 (map_sub_char_table): Delete args default_val and parent. Add arg
8124 top. Give decoded values to a Lisp function.
640c8776 8125 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
8126 values to a Lisp function. Gcpro more variables.
8127 (uniprop_table_uncompress)
8128 (uniprop_decode_value_run_length): New functions.
8129 (uniprop_decoder, uniprop_decoder_count): New variables.
8130 (uniprop_get_decoder, uniprop_encode_value_character)
8131 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
8132 New functions.
8133 (uniprop_encoder, uniprop_encoder_count): New variables.
8134 (uniprop_get_encoder, uniprop_table)
8135 (Funicode_property_table_internal, Fget_unicode_property_internal)
8136 (Fput_unicode_property_internal): New functions.
8137 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
8138 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 8139 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
8140 char-code-property-alist.
8141
640c8776 8142 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
8143 Vunicode_category_table.
8144
640c8776 8145 * font.c (font_range): Adjust for the change of
c805dec0
KH
8146 Vunicode_category_table.
8147
76b397fb
DN
81482011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
8149
8150 * m/iris4d.h: Remove file, move contents ...
8151 * s/irix6-5.h: ... here.
8152
22b4128e
PE
81532011-07-06 Paul Eggert <eggert@cs.ucla.edu>
8154
8155 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
8156 * alloc.c (mark_buffer):
8157 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
8158 (clone_per_buffer_values): Don't assume that
22b4128e
PE
8159 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
8160 This isn't true in general, and it's particularly not true
8161 if Emacs is configured with --with-wide-int.
8162 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
8163 New macros, used in the buffer.c change.
8164
869795d6
JD
81652011-07-05 Jan Djärv <jan.h.d@swipnet.se>
8166
8167 * xsettings.c: Use both GConf and GSettings if both are available.
8168 (store_config_changed_event): Add comment.
8169 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
8170 (store_tool_bar_style_changed): New functions.
5e617bc2 8171 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
8172 (struct xsettings): Move font inside HAVE_XFT.
8173 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 8174 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 8175 Move inside HAVE_XFT.
640c8776 8176 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
8177 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
8178 also.
8179 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 8180 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 8181 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
8182 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
8183 (parse_settings): Move check for font inside HAVE_XFT.
8184 (read_settings, apply_xft_settings): Add comment.
8185 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
8186 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
8187 call store_font_name_changed.
8188 (xft_settings_event): Add comment.
8189 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
8190 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
8191 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
8192 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
8193 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
8194 (xsettings_get_system_font, xsettings_get_system_normal_font):
8195 Add comment.
869795d6 8196
d8ed26bd
PE
81972011-07-05 Paul Eggert <eggert@cs.ucla.edu>
8198
8199 Random fixes. E.g., (random) never returned negative values.
8200 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
8201 subseconds part to the entropy, as that's a bit more random.
8202 Prefer signed to unsigned, since the signedness doesn't matter and
8203 in general we prefer signed. When given a limit, use a
8204 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
8205 latter isn't right if USE_2_TAGS_FOR_INTS.
8206 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
8207 not 0..VALMASK. Don't discard "excess" bits that random () returns.
8208
cabf1cac
SM
82092011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
8210
8211 * textprop.c (text_property_stickiness):
8212 Obey Vtext_property_default_nonsticky.
8213 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
8214 * w32fns.c (syms_of_w32fns):
8215 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
8216
6e9b2be9
PE
82172011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8218
8219 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
8220 This is more efficient than Ffile_directory_p and avoids a minor race.
8221
90186c68
LMI
82222011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
8223
7c301272
LMI
8224 * buffer.c (Foverlay_put): Say what the return value is
8225 (bug#7835).
8226
c4f2d8d4
LMI
8227 * fileio.c (barf_or_query_if_file_exists): Check first if the file
8228 is a directory before asking whether to use the file name
8229 (bug#7564).
ad637907
LMI
8230 (barf_or_query_if_file_exists): Make the "File is a directory"
8231 error be more correct.
c4f2d8d4 8232
90186c68
LMI
8233 * fns.c (Frequire): Remove the mention of the .gz files, since
8234 that's installation-specific, but keep the mention of
8235 `get-load-suffixes'.
8236
da64016e
PE
82372011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8238
8239 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
8240 Report string overflow if the output is too long.
8241
7d47b580
JB
82422011-07-04 Juanma Barranquero <lekktu@gmail.com>
8243
a555cb87
JB
8244 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
8245 (syms_of_gnutls): Remove duplicate DEFSYM for
8246 Qgnutls_bootprop_verify_hostname_error, an error for
8247 Qgnutls_bootprop_verify_error (which is no longer used).
8248
7d47b580
JB
8249 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
8250 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
8251 Also (re)move comments that are misplaced or no longer relevant.
8252
1e49bfab
LMI
82532011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8254
8255 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
8256
1485f4c0
CY
82572011-07-03 Chong Yidong <cyd@stupidchicken.com>
8258
8259 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
8260 and background color parameters if they have been changed.
8261
a9ab721e
LMI
82622011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8263
8264 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
8265
cf7cff57
PE
82662011-07-03 Paul Eggert <eggert@cs.ucla.edu>
8267
2e13213d
PE
8268 * xsettings.c (SYSTEM_FONT): Define only when used.
8269 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
8270
cf7cff57
PE
8271 * keymap.c (access_keymap_1): Now static.
8272
7a8e04f7
CY
82732011-07-02 Chong Yidong <cyd@stupidchicken.com>
8274
8275 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
8276 leave any prefix arg for the up event (Bug#1586).
8277
61352f62
LMI
82782011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
8279
69bb1ef7
LMI
8280 * lread.c (syms_of_lread): Mention single symbols defined by
8281 `defvar' or `defconst' (bug#7154).
8282
61352f62 8283 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 8284 (Frequire): Mention get-load-suffixes.
61352f62 8285
28545e04
MR
82862011-07-02 Martin Rudalics <rudalics@gmx.at>
8287
8288 * window.h (window): Remove clone_number slot.
8289 * window.c (Fwindow_clone_number, Fset_window_clone_number):
8290 Remove.
8291 (make_parent_window, make_window, saved_window)
8292 (Fset_window_configuration, save_window_save): Don't deal with
8293 clone numbers.
8294 * buffer.c (Qclone_number): Remove declaration.
8295 (sort_overlays, overlay_strings): Don't deal with clone numbers.
8296
3349e122
SM
82972011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
8298
8299 Add multiple inheritance to keymaps.
8300 * keymap.c (Fmake_composed_keymap): New function.
8301 (Fset_keymap_parent): Simplify.
8302 (fix_submap_inheritance): Remove.
8303 (access_keymap_1): New function extracted from access_keymap to handle
8304 embedded parents and handle lists of maps.
8305 (access_keymap): Use it.
8306 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
8307 (Fcopy_keymap): Handle embedded parents.
8308 (Fcommand_remapping, define_as_prefix): Simplify.
8309 (Fkey_binding): Simplify.
8310 (syms_of_keymap): Move minibuffer-local-completion-map,
8311 minibuffer-local-filename-completion-map,
8312 minibuffer-local-must-match-map, and
8313 minibuffer-local-filename-must-match-map to Elisp.
8314 (syms_of_keymap): Defsubr make-composed-keymap.
8315 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
8316 (parse_menu_item): Trivial simplification.
8317
3279eb87
GM
83182011-07-01 Glenn Morris <rgm@gnu.org>
8319
8320 * Makefile.in (SETTINGS_LIBS): Fix typo.
8321
4550efdf
KI
83222011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
8323
8324 * coding.c (Fencode_coding_string): Record the last coding system
8325 used, as the function doc string says (bug#8738).
8326
0949d2b6
JD
83272011-07-01 Jan Djärv <jan.h.d@swipnet.se>
8328
8329 * xsettings.c (store_monospaced_changed): Take new font as arg and
8330 check for change against current_mono_font.
8331 (EMACS_TYPE_SETTINGS): Remove this and related defines.
8332 (emacs_settings_constructor, emacs_settings_get_property)
8333 (emacs_settings_set_property, emacs_settings_class_init)
8334 (emacs_settings_init, gsettings_obj): Remove.
8335 (something_changedCB): New function for HAVE_GSETTINGS.
8336 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
8337 with value as argument.
8338 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
8339 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 8340 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
8341 "changed".
8342
8343 * xgselect.c: Add defined (HAVE_GSETTINGS).
8344 (xgselect_initialize): Ditto.
8345
8346 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
8347 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
8348 xg_select.
8349
bbc6b304
PE
83502011-07-01 Paul Eggert <eggert@cs.ucla.edu>
8351
8352 * eval.c (struct backtrace): Simplify and port the data structure.
8353 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
8354 signed bit field, as this assumption is not portable and it makes
8355 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
8356 "char debug_on_exit : 1" as this is not portable either; instead,
8357 use the portable "unsigned int debug_on_exit : 1". Remove unused
8358 member evalargs. Remove obsolete comments about cc bombing out.
8359
9851bfc5
JD
83602011-06-30 Jan Djärv <jan.h.d@swipnet.se>
8361
51bb811f 8362 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
8363 Let HAVE_GSETTINGS override HAVE_GCONF.
8364 (store_monospaced_changed): New function.
8365 (EMACS_SETTINGS): A new type derived from GObject to handle
8366 GSettings notifications.
8367 (emacs_settings_constructor, emacs_settings_get_property)
8368 (emacs_settings_set_property, emacs_settings_class_init):
8369 New functions.
8370 (gsettings_client, gsettings_obj): New variables.
8371 (GSETTINGS_SCHEMA): New define.
8372 (something_changedCB): Call store_monospaced_changed.
8373 (init_gsettings): New function.
8374 (xsettings_initialize): Call init_gsettings.
8375 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
8376 to NULL.
8377
640c8776 8378 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
8379 GCONF_CFLAGS/LIBS.
8380
5386012d
MR
83812011-06-29 Martin Rudalics <rudalics@gmx.at>
8382
8383 * window.c (resize_root_window, grow_mini_window)
8384 (shrink_mini_window): Rename Qresize_root_window to
8385 Qwindow_resize_root_window and Qresize_root_window_vertically to
8386 Qwindow_resize_root_window_vertically.
8387
f13e0b08
PE
83882011-06-28 Paul Eggert <eggert@cs.ucla.edu>
8389
8390 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
8391
94515237
JB
83922011-06-27 Juanma Barranquero <lekktu@gmail.com>
8393
8394 * makefile.w32-in: Redesign dependencies so they reflect more
8395 clearly which files are directly included by each source file,
8396 and not through other includes.
8397
e43b6e43
MR
83982011-06-27 Martin Rudalics <rudalics@gmx.at>
8399
8400 * buffer.c (Qclone_number): Declare static and DEFSYM it.
8401 (sort_overlays, overlay_strings): When an overlay's clone number
8402 matches the window's clone number process the overlay even if
8403 the overlay's window property doesn't match the current window.
8404
d68443dc
MR
8405 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
8406 (Fwindow_hchild): Rename to Fwindow_left_child.
8407 (Fwindow_next): Rename to Fwindow_next_sibling.
8408 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
8409 (resize_window_check): Rename to window_resize_check.
8410 (resize_window_apply): Rename to window_resize_apply.
8411 (Fresize_window_apply): Rename to Fwindow_resize_apply.
8412 (Fdelete_other_windows_internal, resize_frame_windows)
8413 (Fsplit_window_internal, Fdelete_window_internal)
8414 (grow_mini_window, shrink_mini_window)
8415 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 8416
c7e73be5
JD
84172011-06-26 Jan Djärv <jan.h.d@swipnet.se>
8418
8419 * emacsgtkfixed.h: State that this is only used with Gtk+3.
8420 (emacs_fixed_set_min_size): Remove.
8421 (emacs_fixed_new): Take frame as argument.
8422
8423 * emacsgtkfixed.c: State that this is only used with Gtk+3.
8424 (_EmacsFixedPrivate): Remove minwidth/height.
8425 Add struct frame *f.
8426 (emacs_fixed_init): Initialize priv->f.
8427 (get_parent_class, emacs_fixed_set_min_size): Remove.
8428 (emacs_fixed_new): Set priv->f to argument.
8429 (emacs_fixed_get_preferred_width)
8430 (emacs_fixed_get_preferred_height): Use min_width/height from
8431 frames size_hint to set minimum and natural (Bug#8919).
8432 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
8433 and use min_width/height from frames size_hint to set
8434 min_width/height (Bug#8919).
8435
8436 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
8437 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
8438 Fix indentation.
c7e73be5 8439
cf99dcf8
EZ
84402011-06-26 Eli Zaretskii <eliz@gnu.org>
8441
8442 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
8443 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
8444 called at ZV.
8445
029529ac
CY
84462011-06-26 Chong Yidong <cyd@stupidchicken.com>
8447
8448 * process.c (wait_reading_process_output): Bypass select if
8449 waiting for a cell while ignoring keyboard input, and input is
8450 pending. Suggested by Jan Djärv (Bug#8869).
8451
7a7ef429
PE
84522011-06-25 Paul Eggert <eggert@cs.ucla.edu>
8453
8454 Use gnulib's dup2 module instead of rolling our own.
8455 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
8456
11fdef7d 84572011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
8458
8459 * dispnew.c (scrolling_window): Before scrolling, turn off a
8460 mouse-highlight in the window being scrolled.
8461
cd3520a4
JB
84622011-06-24 Juanma Barranquero <lekktu@gmail.com>
8463
8464 Move DEFSYM to lisp.h and use everywhere.
8465
8466 * character.h (DEFSYM): Move declaration...
8467 * lisp.h (DEFSYM): ...here.
8468
8469 * gnutls.c:
8470 * minibuf.c:
8471 * w32menu.c:
8472 * w32proc.c:
8473 * w32select.c: Don't include character.h.
8474
8475 * alloc.c (syms_of_alloc):
8476 * buffer.c (syms_of_buffer):
8477 * bytecode.c (syms_of_bytecode):
8478 * callint.c (syms_of_callint):
8479 * casefiddle.c (syms_of_casefiddle):
8480 * casetab.c (init_casetab_once):
8481 * category.c (init_category_once, syms_of_category):
8482 * ccl.c (syms_of_ccl):
8483 * cmds.c (syms_of_cmds):
8484 * composite.c (syms_of_composite):
8485 * dbusbind.c (syms_of_dbusbind):
8486 * dired.c (syms_of_dired):
8487 * dispnew.c (syms_of_display):
8488 * doc.c (syms_of_doc):
8489 * editfns.c (syms_of_editfns):
8490 * emacs.c (syms_of_emacs):
8491 * eval.c (syms_of_eval):
8492 * fileio.c (syms_of_fileio):
8493 * fns.c (syms_of_fns):
8494 * frame.c (syms_of_frame):
8495 * fringe.c (syms_of_fringe):
8496 * insdel.c (syms_of_insdel):
8497 * keymap.c (syms_of_keymap):
8498 * lread.c (init_obarray, syms_of_lread):
8499 * macros.c (syms_of_macros):
8500 * msdos.c (syms_of_msdos):
8501 * print.c (syms_of_print):
8502 * process.c (syms_of_process):
8503 * search.c (syms_of_search):
8504 * sound.c (syms_of_sound):
8505 * syntax.c (init_syntax_once, syms_of_syntax):
8506 * terminal.c (syms_of_terminal):
8507 * textprop.c (syms_of_textprop):
8508 * undo.c (syms_of_undo):
8509 * w32.c (globals_of_w32):
8510 * window.c (syms_of_window):
8511 * xdisp.c (syms_of_xdisp):
8512 * xfaces.c (syms_of_xfaces):
8513 * xfns.c (syms_of_xfns):
8514 * xmenu.c (syms_of_xmenu):
8515 * xsettings.c (syms_of_xsettings):
8516 * xterm.c (syms_of_xterm): Use DEFSYM.
8517
4228cf16
TZ
85182011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
8519
cd3520a4 8520 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 8521
7fcccf1e
PE
85222011-06-23 Paul Eggert <eggert@cs.ucla.edu>
8523
7efb4e0e
PE
8524 Integer and buffer overflow fixes (Bug#8873).
8525
ff5844ad
PE
8526 * print.c (printchar, strout): Check for string overflow.
8527 (PRINTPREPARE, printchar, strout):
8528 Don't set size unless allocation succeeds.
8529
90532f02
PE
8530 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
8531 for sizes. Check for string overflow more accurately.
8532 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
8533
6d84508d
PE
8534 * macros.c: Integer and buffer overflow fixes.
8535 * keyboard.h (struct keyboard.kbd_macro_bufsize):
8536 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
8537 Use ptrdiff_t, not int, for sizes.
8538 Don't increment bufsize until after realloc succeeds.
8539 Check for size-calculation overflow.
8540 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
8541
437b2cb4
PE
8542 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
8543
8b9ac8b4
PE
8544 * lread.c: Integer overflow fixes.
8545 (read_integer): Radix is now EMACS_INT, not int,
8546 to improve quality of diagnostics for out-of-range radices.
8547 Calculate buffer size correctly for out-of-range radices.
8548 (read1): Check for integer overflow in radices, and in
8549 read-circle numbers.
82cb60d3
PE
8550 (read_escape): Avoid int overflow.
8551 (Fload, openp, read_buffer_size, read1)
8552 (substitute_object_recurse, read_vector, read_list, map_obarray):
8553 Use ptrdiff_t, not int, for sizes.
8554 (read1): Use EMACS_INT, not int, for sizes.
20270765 8555 Check for size overflow.
8b9ac8b4 8556
7fcccf1e
PE
8557 * image.c (cache_image): Check for size arithmetic overflow.
8558
bfbbd7e7
PE
8559 * lread.c: Integer overflow issues.
8560 (saved_doc_string_size, saved_doc_string_length)
8561 (prev_saved_doc_string_size, prev_saved_doc_string_length):
8562 Now ptrdiff_t, not int.
8563 (read1): Don't assume doc string length fits in int. Check for
8564 out-of-range doc string lengths.
8565 (read_list): Don't assume file position fits in int.
39019e54 8566 (read_escape): Check for hex character overflow.
bfbbd7e7 8567
4e323265
LL
85682011-06-22 Leo Liu <sdl.web@gmail.com>
8569
8570 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
8571 Move to minibuffer.el.
8572
85fece3e
PE
85732011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8574
20b84ce9 8575 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
8576 The following patches are for when GLYPH_DEBUG && !XASSERT.
8577 * dispextern.h (trace_redisplay_p, dump_glyph_string):
8578 * dispnew.c (flush_stdout):
8579 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
8580 Mark as externally visible.
8581 * dispnew.c (check_window_matrix_pointers): Now static.
8582 * dispnew.c (window_to_frame_vpos):
8583 * xfns.c (unwind_create_frame):
8584 * xterm.c (x_check_font): Remove unused local.
8585 * scroll.c (CHECK_BOUNDS):
8586 * xfaces.c (cache_fache): Rename local to avoid shadowing.
8587 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
8588 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
8589 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
8590 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
8591 Now static.
8592 (debug_method_add): Use va_list and vsprintf rather than relying
8593 on undefined behavior with wrong number of arguments.
8594 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
8595 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
8596 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
8597 since we're not interested in debugging glyphs with old libraries.
8598 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
8599 GCC 4.6.0's static checking.
8600
0766b489
PE
86012011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8602
31fd4b32
PE
8603 Integer overflow and signedness fixes (Bug#8873).
8604 A few related buffer overrun fixes, too.
8605
b79e8648
PE
8606 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
8607
0766b489
PE
8608 * dispextern.h (struct face.stipple):
8609 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
8610 (x_bitmap_mask, x_allocate_bitmap_record)
8611 (x_create_bitmap_from_data, x_create_bitmap_from_file)
8612 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
8613 (x_create_bitmap_from_xpm_data):
8614 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
8615 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
8616 (.bitmaps_last):
8617 * xfaces.c (load_pixmap):
8618 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
8619 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
8620 (.bitmaps_last, struct x_output.icon_bitmap):
8621 Use ptrdiff_t, not int, for bitmap indexes.
8622 (x_allocate_bitmap_record): Check for size overflow.
8623 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
8624
b081724f
PE
8625 Use ptrdiff_t, not int, for overlay counts.
8626 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
8627 * editfns.c (overlays_around, get_pos_property):
8628 * textprop.c (get_char_property_and_overlay):
8629 * xdisp.c (next_overlay_change, note_mouse_highlight):
8630 * xfaces.c (face_at_buffer_position):
21514da7
PE
8631 * buffer.c (OVERLAY_COUNT_MAX): New macro.
8632 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
8633 (Fnext_overlay_change, Fprevious_overlay_change)
8634 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 8635 Use ptrdiff_t, not int, for sizes.
21514da7 8636 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 8637
3de73e5e
PE
8638 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
8639
2606c57b
PE
8640 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
8641 (x_session_initialize): Do not assume string length fits in int.
8642
aaafe47a
PE
8643 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
8644 This is unlikely, but can occur if DPI is outlandish.
8645
2674ddc8 8646 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
8647 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
8648
28154962
PE
8649 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
8650 * xrdb.c (magic_file_p, search_magic_path):
8651 Omit last arg SUFFIX; it was always 0. All callers changed.
8652 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
8653
7de51af5
PE
8654 * xfont.c (xfont_match): Avoid need for strlen.
8655
25ed6cc3
PE
8656 * xfns.c: Don't assume strlen fits in int.
8657 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
8658
4eab31dd
PE
8659 * xdisp.c (message_log_check_duplicate): Return intmax_t,
8660 not unsigned long, as we prefer signed integers. All callers changed.
8661 Detect integer overflow in repeat count.
8662 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 8663 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 8664
171e2a58
PE
8665 * termcap.c: Don't assume sizes fit in int and never overflow.
8666 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
8667 (gobble_line): Check for size-calculation overflow.
8668
ad39faca 8669 * minibuf.c (Fread_buffer):
6e5bb2dc 8670 * lread.c (intern, intern_c_string):
74ca2eb3
PE
8671 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
8672 Don't assume string length fits in int.
8673
52c61c22 8674 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
8675 * gtkutil.c (style_changed_cb): Avoid need for strlen.
8676
b5b8c9e5
PE
8677 * font.c: Don't assume string length fits in int.
8678 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
8679 Use ptrdiff_t, not int.
ccd6111c
PE
8680 (font_intern_prop): Don't assume string length fits in int.
8681 Don't assume integer property fits in fixnum.
8682 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 8683
882f0d81 8684 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 8685 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
8686 Reformulate so as not to need the command string.
8687 Invoke gzip -cd rather than gunzip, as it's more portable.
8688 (lock_info_type, lock_file_1, lock_file):
8689 Don't assume pid_t and time_t fit in unsigned long.
8690 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
8691 (current_lock_owner): Prefer signed type for sizes.
8692 Use memcpy, not strncpy, where memcpy is what is really wanted.
8693 Don't assume (via atoi) that time_t and pid_t fit in int.
8694 Check for time_t and/or pid_t out of range, e.g., via a network share.
8695 Don't alloca where an auto var works fine.
8696
93f4cf88
PE
8697 * fileio.c: Fix some integer overflow issues.
8698 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
8699 Don't assume string length fits in int.
8700 (directory_file_name): Don't assume string length fits in long.
8701 (make_temp_name): Don't assume pid fits in int, or that its print
8702 length is less than 20.
8703
f3e92b69
PE
8704 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
8705
1bfdaf10
PE
8706 * coding.c (make_subsidiaries): Don't assume string length fits in int.
8707
35016e9a
PE
8708 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
8709
3d1e65a1
PE
8710 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
8711 We prefer signed integers, even for size calculations.
8712
0b963a93
PE
8713 * emacs.c: Don't assume string length fits in 'int'.
8714 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
8715 (main): Don't invoke strlen when not needed.
8716
573f4b54
PE
8717 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
8718 (XD_DEBUG_MESSAGE): Don't waste a byte.
8719
989f33ba
PE
8720 * callproc.c (getenv_internal_1, getenv_internal)
8721 (Fgetenv_internal):
965d34eb
PE
8722 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
8723
e4d29b33
PE
8724 * lread.c (invalid_syntax): Omit length argument.
8725 All uses changed. This doesn't fix a bug, but it simplifies the
8726 code away from its former Hollerith-constant appearance, and it's
8727 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 8728 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 8729
eb49b136
PE
8730 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
8731 This didn't break anything, but it didn't help either.
8732 It's confusing to put a bogus integer in a place where the actual
8733 value does not matter.
9f62aeb1 8734 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 8735 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 8736
15375a22
PE
8737 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
8738 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
8739 implementation.
b61cc01c
PE
8740 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
8741 We prefer signed types, and the value cannot exceed the EMACS_INT
8742 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
8743 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
8744 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
8745 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 8746
53b2623d
PE
8747 * indent.c (sane_tab_width): New function.
8748 (current_column, scan_for_column, Findent_to, position_indentation)
8749 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 8750 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 8751
51cab52b 8752 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 8753
f2ed8a70
PE
8754 * lisp.h (lint_assume): New macro.
8755 * composite.c (composition_gstring_put_cache):
8756 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
8757
abe80cc6
PE
8758 * editfns.c, insdel.c:
8759 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 8760
b02c740e
PE
8761 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
8762
ebc96716
PE
8763 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
8764
b4e50fa0 8765 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 8766 Use much-faster test for byte-length change.
311d5d7c 8767 Don't assume string byte-length fits in 'int'.
a4cf38e4 8768 Check that character arg fits in 'int'.
85461888 8769 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 8770
c0c1ee9f
PE
8771 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
8772
a498d7f4
PE
8773 * fns.c (concat): Catch string overflow earlier.
8774 Do not rely on integer wraparound.
8775
51cab52b
PE
8776 * dispextern.h (struct it.overlay_strings_charpos)
8777 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
8778 * xdisp.c (forward_to_next_line_start)
8779 (back_to_previous_visible_line_start)
8780 (reseat_at_next_visible_line_start, next_element_from_buffer):
8781 Don't arbitrarily truncate the value of 'selective' to int.
8782
76031fad
PE
8783 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
8784
5eb55db9
PE
8785 * composite.c: Don't truncate sizes to 'int'.
8786 (composition_gstring_p, composition_reseat_it)
8787 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
8788 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
8789 not EMACS_UINT, for indexes.
5eb55db9 8790
0703a717
PE
8791 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
8792
d6202519
PE
8793 * buffer.c: Include <verify.h>.
8794 (struct sortvec.priority, struct sortstr.priority):
8961a454 8795 Now EMACS_INT, not int.
c20998a7 8796 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
8797 (struct sortstr.size, record_overlay_string)
8798 (struct sortstrlist.size, struct sortlist.used):
8799 Don't truncate size to int.
8800 (record_overlay_string): Check for size-calculation overflow.
d6202519 8801 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 8802
d5a19415
JM
88032011-06-22 Jim Meyering <meyering@redhat.com>
8804
029529ac 8805 Don't leak an XBM-image-sized buffer
d5a19415
JM
8806 * image.c (xbm_load): Free the image buffer after using it.
8807
a9041e6c
PE
88082011-06-21 Paul Eggert <eggert@cs.ucla.edu>
8809
8810 Port to Sun C.
8811 * composite.c (find_automatic_composition): Omit needless 'return 0;'
8812 that Sun C diagnosed.
8813 * fns.c (secure_hash): Fix pointer signedness issue.
8814 * intervals.c (static_offset_intervals): New function.
8815 (offset_intervals): Use it.
8816
7f3f739f
LL
88172011-06-21 Leo Liu <sdl.web@gmail.com>
8818
8819 * deps.mk (fns.o):
8820 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
8821 sha512.h.
8822
8823 * fns.c (secure_hash): Rename from crypto_hash_function and change
8824 the first arg to accept symbols.
5b66d427 8825 (Fsecure_hash): New primitive.
7f3f739f
LL
8826 (syms_of_fns): New symbols.
8827
76147d94
DD
88282011-06-20 Deniz Dogan <deniz@dogan.se>
8829
8830 * process.c (Fset_process_buffer): Clarify return value in
8831 docstring.
8832
7d7d0045
CY
88332011-06-18 Chong Yidong <cyd@stupidchicken.com>
8834
8835 * dispnew.c (add_window_display_history): Use BVAR.
8836
8837 * xdisp.c (debug_method_add): Use BVAR.
8838 (check_window_end, dump_glyph_matrix, dump_glyph)
8839 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
8840
8841 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
8842 Likewise.
8843
8844 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
8845 check till after the cache is created in init_frame_faces.
8846
ff2bc410
SM
88472011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
8848
8849 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
8850
28177add
PE
88512011-06-16 Paul Eggert <eggert@cs.ucla.edu>
8852
dd3482fe
PE
8853 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
8854 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
8855 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
8856
393d71f3 8857 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
8858 * fileio.c (Finsert_file_contents):
8859 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
8860 Remove the old (too-loose) buffer overflow checks.
8861 They weren't needed, since make_gap checks for buffer overflow.
8862 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
8863 The old code merely checked for Emacs fixnum overflow, and relied
8864 on undefined (wraparound) behavior. The new code avoids undefined
8865 behavior, and also checks for ptrdiff_t and/or size_t overflow.
8866
2e6813b0 8867 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
8868 Tune. Don't use wider integers than needed. Don't use alloca.
8869 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 8870
599a9e4f
PE
8871 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
8872
99561444
PE
8873 * insdel.c, lisp.h (buffer_overflow): New function.
8874 (insert_from_buffer_1, replace_range, replace_range_2):
8875 * insdel.c (make_gap_larger):
8876 * editfns.c (Finsert_char):
8877 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
8878
28177add
PE
8879 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
8880
e69dafad
PE
88812011-06-15 Paul Eggert <eggert@cs.ucla.edu>
8882
4baa020d 8883 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 8884
b1c46f02
PE
8885 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
8886 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
8887
e69dafad
PE
8888 * fileio.c: Don't assume EMACS_INT fits in off_t.
8889 (emacs_lseek): New static function.
8890 (Finsert_file_contents, Fwrite_region): Use it.
8891 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
8892
566684ea
PE
8893 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
8894
e6966cd6
PE
8895 * fns.c: Don't overflow int when computing a list length.
8896 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
8897 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
8898 truncation on 64-bit hosts. Check for QUIT every
8899 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
8900 faster and is responsive enough.
8901 (Flength): Report an error instead of overflowing an integer.
8902 (Fsafe_length): Return a float if the value is not representable
8903 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 8904 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 8905 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 8906
dd0b0efb
PE
8907 * alloc.c: Check that resized vectors' lengths fit in fixnums.
8908 (header_size, word_size): New constants.
8909 (allocate_vectorlike): Don't check size overflow here.
8910 (allocate_vector): Check it here instead, since this is the only
8911 caller of allocate_vectorlike that could cause overflow.
8912 Check that the new vector's length is representable as a fixnum.
8913
86fe5cfe
PE
8914 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
8915 The previous code was bogus. For example, next_almost_prime (32)
8916 returned 39, which is undesirable as it is a multiple of 3; and
8917 next_almost_prime (24) returned 25, which is a multiple of 5 so
8918 why was the code bothering to check for multiples of 7?
8919
80e88859
PE
8920 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
8921
4a2f0ad6
PE
8922 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
8923
f66c7cf8
PE
8924 Variadic C functions now count arguments with ptrdiff_t.
8925 This partly undoes my 2011-03-30 change, which replaced int with size_t.
8926 Back then I didn't know that the Emacs coding style prefers signed int.
8927 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
8928 were being counted with int, which may truncate counts on 64-bit
8929 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
8930 * lisp.h (struct Lisp_Subr.function.aMANY)
8931 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
8932 Arg counts are now ptrdiff_t, not size_t.
8933 All variadic functions and their callers changed accordingly.
8934 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
8935 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
8936 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
8937 * callint.c (Fcall_interactively): Check arg count for overflow,
8938 to avoid potential buffer overrun. Use signed char, not 'int',
8939 for 'varies' array, so that we needn't bother to check its size
8940 calculation for overflow.
8941 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
8942 * eval.c (apply_lambda):
8943 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
8944 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
8945 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
8946
a1759b76
PE
8947 * callint.c (Fcall_interactively): Don't use index var as event count.
8948
d96be9fc
PE
8949 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
8950 * mem-limits.h (SIZE): Remove; no longer used.
8951
a690a978 8952 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 8953
578c21e6
PE
8954 Remove unnecessary casts.
8955 * xterm.c (x_term_init):
8956 * xfns.c (x_set_border_pixel):
8957 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
8958 These aren't needed now that we assume ANSI C.
8959
96f53c6c
PE
8960 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
8961 It's more likely to cause problems (due to unsigned overflow)
8962 than to cure them.
8963
83c77d31
PE
8964 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
8965
ee2079f1
PE
8966 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
8967
6da65536
PE
8968 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
8969
7147c4a4
PE
8970 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
8971
193e32d9
PE
8972 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
8973
e5533da6
PE
8974 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
8975
9910e595
PE
8976 GLYPH_CODE_FACE returns EMACS_INT, not int.
8977 * dispextern.h (merge_faces):
8978 * xfaces.c (merge_faces):
01103c44
PE
8979 * xdisp.c (get_next_display_element, next_element_from_display_vector):
8980 Don't assume EMACS_INT fits in int.
9910e595 8981
2638320e
PE
8982 * character.h (CHAR_VALID_P): Remove unused parameter.
8983 * fontset.c, lisp.h, xdisp.c: All uses changed.
8984
045eb8d9
PE
8985 * editfns.c (Ftranslate_region_internal): Omit redundant test.
8986
c1f134b5
PE
8987 * fns.c (concat): Minor tuning based on overflow analysis.
8988 This doesn't fix any bugs. Use int to hold character, instead
8989 of constantly refetching from Emacs object. Use XFASTINT, not
8990 XINT, for value known to be a character. Don't bother comparing
8991 a single byte to 0400, as it's always less.
8992
395fcb93 8993 * floatfns.c (Fexpt):
327eeec8
PE
8994 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
8995
abbd3d23
PE
8996 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
8997 for characters.
8998
684a03ef
PE
8999 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
9000
0fed43f3
PE
9001 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
9002 Without this fix, on a 64-bit host (aset S 0 4294967386) would
9003 incorrectly succeed when S was a string, because 4294967386 was
9004 truncated before it was used.
9005
8fd02eb7
PE
9006 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
9007 Otherwise, an out-of-range integer could cause undefined behavior
9008 on a 64-bit host.
9009
f8c86b69
PE
9010 * composite.c: Use int, not EMACS_INT, for characters.
9011 (fill_gstring_body, composition_compute_stop_pos): Use int, not
9012 EMACS_INT, for values that are known to be in character range.
9013 This doesn't fix any bugs but is the usual style inside Emacs and
9014 may generate better code on 32-bit machines.
9015
34206dd2
PE
9016 Make sure a 64-bit char is never passed to ENCODE_CHAR.
9017 This is for reasons similar to the recent CHAR_STRING fix.
9018 * charset.c (Fencode_char): Check that character arg is actually
9019 a character. Pass an int to ENCODE_CHAR.
9020 * charset.h (ENCODE_CHAR): Verify that the character argument is no
9021 wider than 'int', as a compile-time check to prevent future regressions
9022 in this area.
9023
c5958d4c 9024 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
9025
9026 Make sure a 64-bit char is never passed to CHAR_STRING.
9027 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
9028 by silently ignoring the top 32 bits, allowing some values
9029 that were far too large to be valid characters.
9030 * character.h: Include <verify.h>.
9031 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
9032 arguments are no wider than unsigned, as a compile-time check
9033 to prevent future regressions in this area.
9034 * data.c (Faset):
01103c44 9035 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
9036 (Fsubst_char_in_region):
9037 * fns.c (concat):
9038 * xdisp.c (decode_mode_spec_coding):
9039 Adjust to CHAR_STRING's new requirement.
9040 * editfns.c (Finsert_char, Fsubst_char_in_region):
9041 * fns.c (concat): Check that character args are actually
9042 characters. Without this test, these functions did the wrong
9043 thing with wildly out-of-range values on 64-bit hosts.
9044
d37ca623
PE
9045 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
9046 These casts should not be needed on 32-bit hosts, either.
9047 * keyboard.c (read_char):
9048 * lread.c (Fload): Remove casts to unsigned.
9049
ea204efb
PE
9050 * lisp.h (UNSIGNED_CMP): New macro.
9051 This fixes comparison bugs on 64-bit hosts.
9052 (ASCII_CHAR_P): Use it.
9053 * casefiddle.c (casify_object):
01103c44 9054 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
9055 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
9056 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
9057 * dispextern.h (FACE_FROM_ID):
9058 * keyboard.c (read_char): Use UNSIGNED_CMP.
9059
41cb286c
PE
9060 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
9061 not to EMACS_INT, to avoid GCC warning.
9062
4a1b9832
PE
9063 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
9064
55daad71
PE
9065 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
9066 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
9067 isn't needed on 32-bit machines.
8f95c75c 9068
01103c44
PE
9069 * buffer.c (Fgenerate_new_buffer_name):
9070 Use EMACS_INT for count, not int.
0ceccced 9071 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
9072
9073 * data.c (Qcompiled_function): Now static.
9074
c6f072e7
PE
9075 * window.c (window_body_lines): Now static.
9076
20ce5912
PE
9077 * image.c (gif_load): Rename local to avoid shadowing.
9078
9c4c5f81
PE
9079 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
9080 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
9081 * alloc.c (make_save_value): Integer argument is now of type
9082 ptrdiff_t, not int.
9083 (mark_object): Use ptrdiff_t, not int.
9084 * lisp.h (pD): New macro.
9085 * print.c (print_object): Use it.
9086
c0c5c8ae
PE
9087 * alloc.c: Use EMACS_INT, not int, to count objects.
9088 (total_conses, total_markers, total_symbols, total_vector_size)
9089 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
9090 (total_free_floats, total_floats, total_free_intervals)
9091 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
9092 Now EMACS_INT, not int. All uses changed.
9093 (Fgarbage_collect): Compute overall total using a double, so that
9094 integer overflow is less likely to be a problem. Check for overflow
9095 when converting back to an integer.
5a25e253
PE
9096 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
9097 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
9098 These were 'int' variables that could overflow on 64-bit hosts;
9099 they were never used, so remove them instead of repairing them.
211a0b2a 9100 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
9101 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
9102 Previously, this ceilinged at INT_MAX, but that doesn't work on
9103 64-bit machines.
e46bb31a 9104 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 9105
c78baabf 9106 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 9107 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
9108 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
9109 when a (possibly-narrower) signed value would do just as well.
9110 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 9111
c9d624c6
PE
9112 * alloc.c: Catch some string size overflows that we were missing.
9113 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
9114 for convenience in STRING_BYTES_MAX.
9115 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
9116 The definition here is exact; the one in lisp.h was approximate.
9117 (allocate_string_data): Check for string overflow. This catches
9118 some instances we weren't catching before. Also, it catches
9119 size_t overflow on (unusual) hosts where SIZE_MAX <= min
9120 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
9121 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 9122
c9d624c6
PE
9123 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
9124 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 9125 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 9126
353032ce
PE
9127 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
9128
2bccce07
PE
9129 * alloc.c (Fmake_string): Check for out-of-range init.
9130
0ac30604
SM
91312011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
9132
9133 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
9134
c195f2de
JD
91352011-06-14 Jan Djärv <jan.h.d@swipnet.se>
9136
9137 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
9138 xg_get_default_scrollbar_width.
9139
9140 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
9141 (int_gtk_range_get_value): Move to the scroll bar part of the file.
9142 (style_changed_cb): Call update_theme_scrollbar_width and call
9143 x_set_scroll_bar_default_width and xg_frame_set_char_size for
9144 all frames (Bug#8505).
9145 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
9146 Call gtk_window_set_resizable if HAVE_GTK3.
9147 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
9148 and height if HAVE_GTK3 (Bug#8505).
9149 (scroll_bar_width_for_theme): New variable.
9150 (update_theme_scrollbar_width): New function.
9151 (xg_get_default_scrollbar_width): Move code to
9152 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
9153 (xg_initialize): Call update_theme_scrollbar_width.
9154
9155 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
9156
9157 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
9158
e10ac9f1
MR
91592011-06-12 Martin Rudalics <rudalics@gmx.at>
9160
9161 * frame.c (make_frame): Call other_buffer_safely instead of
9162 other_buffer.
9163
9164 * window.c (temp_output_buffer_show): Call display_buffer with
9165 second argument Vtemp_buffer_show_specifiers and reset latter
9166 immediately after the call.
9167 (Vtemp_buffer_show_specifiers): New variable.
9168 (auto_window_vscroll_p, next_screen_context_lines)
9169 (Vscroll_preserve_screen_position): Remove leading asterisks from
9170 doc-strings.
9171
2d3c217e 91722011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 9173
7b7f97e8 9174 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
9175 * buffer.c (Qclone_number): Remove for now, as it's unused.
9176 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
9177 (record_buffer): Remove unused local.
9178 * frame.c (other_visible_frames, frame_buffer_list): Now static.
9179 (set_frame_buffer_list): Remove; unused.
9180 * frame.h (other_visible_frames): Remove decl.
9181 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
9182 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
9183 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
9184 if HAVE_GPM.
9185 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
9186 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
9187 Define only if HAVE_GPM.
9188 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
9189 (update_hints_inhibit): Remove; never set. All uses removed.
9190 * widgetprv.h (emacsFrameClassRec): Remove decl.
9191 * window.c (delete_deletable_window): Now returns void, since it
9192 wasn't returning anything.
9193 (compare_window_configurations): Remove unused locals.
9194 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
9195 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
9196 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
9197 the same widths as pointers. This follows up on the 2011-05-06 patch.
9198 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
9199 * xterm.h: Likewise.
9200 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
9201
1384b89e
JB
92022011-06-12 Juanma Barranquero <lekktu@gmail.com>
9203
9204 * makefile.w32-in: Update dependencies.
9205 (LISP_H): Add lib/intprops.h.
9206
1100a63c
CY
92072011-06-11 Chong Yidong <cyd@stupidchicken.com>
9208
9209 * image.c (gif_load): Add animation frame delay to the metadata.
9210 (syms_of_image): Use DEFSYM. New symbol `delay'.
9211
6198ccd0
MR
92122011-06-11 Martin Rudalics <rudalics@gmx.at>
9213
9214 * window.c (delete_deletable_window): Re-add.
9215 (Fset_window_configuration): Rewrite to handle dead buffers and
9216 consequently deletable windows.
9217 (window_tree, Fwindow_tree): Remove. Supply functionality in
9218 window.el.
9219 (compare_window_configurations): Simplify code.
9220
b6e3633c
AS
92212011-06-11 Andreas Schwab <schwab@linux-m68k.org>
9222
1ab0dee5
AS
9223 * image.c (imagemagick_load_image): Fix type mismatch.
9224 (Fimagemagick_types): Likewise.
9225
b6e3633c
AS
9226 * window.h (replace_buffer_in_windows): Declare.
9227
9397e56f
MR
92282011-06-11 Martin Rudalics <rudalics@gmx.at>
9229
9230 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
9231 Qclone_number. Remove external declaration of Qdelete_window.
9232 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
9233 code.
640c8776
SM
9234 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
9235 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
9236 (Fother_buffer): Rewrite doc-string. Major rewrite for new
9237 buffer list implementation.
9238 (other_buffer_safely): New function.
9239 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
9240 calls to replace_buffer_in_windows and
9241 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
9242 if allowed.
9243 (record_buffer): Inhibit quitting and rewrite using quittable
9244 functions. Run Qbuffer_list_update_hook if allowed.
9245 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
9246 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
9247 Move switch-to-buffer to window.el.
9397e56f
MR
9248 (bury-buffer): Move to window.el.
9249 (Vbuffer_list_update_hook): New variable.
9250
9251 * lisp.h (other_buffer_safely): Add prototype in buffer.c
9252 section.
9253
9254 * window.h (resize_frame_windows): Move up in code.
9255 (Fwindow_frame): Remove EXFUN.
9256 (replace_buffer_in_all_windows): Remove prototype.
9257 (replace_buffer_in_windows_safely): Add prototype.
9258
9259 * window.c: Declare Qdelete_window static again. Move down
9260 declaration of select_count.
9261 (Fnext_window, Fprevious_window): Rewrite doc-strings.
9262 (Fother_window): Move to window.el.
9263 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
9264 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
9265 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
9266 window.el.
9267 (replace_buffer_in_windows): Implement by calling
9268 Qreplace_buffer_in_windows.
9269 (replace_buffer_in_all_windows): Remove with some functionality
9270 moved into replace_buffer_in_windows_safely.
9271 (replace_buffer_in_windows_safely): New function.
9272 (select_window_norecord, select_frame_norecord): Move in front
9273 of run_window_configuration_change_hook. Remove now obsolete
9274 declarations.
640c8776
SM
9275 (Fset_window_buffer): Rewrite doc-string.
9276 Call Qrecord_window_buffer.
9397e56f
MR
9277 (keys_of_window): Move binding for other-window to window.el.
9278
b50691aa
CY
92792011-06-11 Chong Yidong <cyd@stupidchicken.com>
9280
9281 * dispextern.h (struct image): Replace data member, whose int_val
9282 and ptr_val fields were not used by anything, with a single
9283 lisp_val object.
9284
9285 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
9286 (gif_clear_image, gif_load, imagemagick_load_image)
9287 (gs_clear_image, gs_load): Callers changed.
9288
3f754b86
PE
92892011-06-10 Paul Eggert <eggert@cs.ucla.edu>
9290
cca69397
PE
9291 * buffer.h: Include <time.h>, for time_t.
9292 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
9293
109e28d0
PE
9294 Fix minor problems found by static checking.
9295
60737f02
PE
9296 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
9297
4b66faf3
PE
9298 Make identifiers static if they are not used in other modules.
9299 * data.c (Qcompiled_function, Qframe, Qvector):
9300 * image.c (QimageMagick, Qsvg):
9301 * minibuf.c (Qmetadata):
9302 * window.c (resize_window_check, resize_root_window): Now static.
9303 * window.h (resize_window_check, resize_root_window): Remove decls.
9304
109e28d0
PE
9305 * window.c (window_deletion_count, delete_deletable_window):
9306 Remove; unused.
46a4ce9e
PE
9307 (window_body_lines): Now static.
9308 (Fdelete_other_windows_internal): Mark vars as initialized.
9309 Make sure 'resize_failed' is initialized.
9310 (run_window_configuration_change_hook): Rename local to avoid shadowing.
9311 (resize_window_apply): Remove unused local.
9312 * window.h (delete_deletable_window): Remove decl.
9313
109e28d0 9314 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
9315 (imagemagick_load_image): Fix pointer signedness problem by changing
9316 last arg from unsigned char * to char *. All uses changed.
9317 Also, fix a local for similar reasons.
9318 Remove unused locals. Remove locals to avoid shadowing.
9319 (fn_rsvg_handle_free): Remove; unused.
9320 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 9321 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 9322
3f754b86
PE
9323 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
9324
2547adb1
CY
93252011-06-10 Chong Yidong <cyd@stupidchicken.com>
9326
9327 * image.c (gif_load): Fix omitted cast error introduced by
9328 2011-06-06 change.
9329
2c8e37d4
MR
93302011-06-10 Martin Rudalics <rudalics@gmx.at>
9331
9332 * window.h (resize_proportionally, orig_total_lines)
9333 (orig_top_line): Remove from window structure.
9334 (set_window_height, set_window_width, change_window_heights)
9335 (Fdelete_window): Remove prototypes.
9336 (resize_frame_windows): Remove duplicate declaration.
9337
440a42e3
EZ
93382011-06-10 Eli Zaretskii <eliz@gnu.org>
9339
9340 * window.h (resize_frame_windows, resize_window_check)
9341 (delete_deletable_window, resize_root_window)
9342 (resize_frame_windows): Declare prototypes.
9343
9344 * window.c (resize_window_apply): Make definition be "static" to
9345 match the prototype.
9346
562dd5e9
MR
93472011-06-10 Martin Rudalics <rudalics@gmx.at>
9348
9349 * window.c: Remove declarations of Qwindow_size_fixed,
9350 window_min_size_1, window_min_size_2, window_min_size,
9351 size_window, window_fixed_size_p, enlarge_window, delete_window.
9352 Remove static from declaration of Qdelete_window, it's
9353 temporarily needed by Fbury_buffer.
9354 (replace_window): Don't assign orig_top_line and
9355 orig_total_lines.
9356 (Fdelete_window, delete_window): Remove. Window deletion is
9357 handled by window.el.
640c8776
SM
9358 (window_loop): Remove DELETE_OTHER_WINDOWS case.
9359 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
9360 (Fdelete_other_windows): Remove. Deleting other windows is
9361 handled by window.el.
9362 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
9363 handled in window.el.
9364 (window_min_size_2, window_min_size_1, window_min_size): Remove.
9365 Window minimum sizes are handled in window.el.
9366 (shrink_windows, size_window, set_window_height)
9367 (set_window_width, change_window_heights, window_height)
9368 (window_width, CURBEG, CURSIZE, enlarge_window)
9369 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
9370 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
9371 handled in window.el.
9372 (make_dummy_parent): Rename to make_parent_window and give it a
9373 second argument horflag.
9374 (make_window): Don't set resize_proportionally any more.
9375 (Fsplit_window): Remove. Windows are split in window.el.
9376 (save_restore_action, save_restore_orig_size)
9377 (shrink_window_lowest_first, save_restore_orig_size): Remove.
9378 Resize mini windows in window.el.
9379 (grow_mini_window, shrink_mini_window): Implement by calling
9380 Qresize_root_window_vertically, resize_window_check and
9381 resize_window_apply.
640c8776
SM
9382 (saved_window, Fset_window_configuration, save_window_save):
9383 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
9384 resize_proportionally.
9385 (window_min_height, window_min_width): Move to window.el.
9386 (keys_of_window): Move bindings for delete-other-windows,
9387 split-window, delete-window and enlarge-window to window.el.
9388
9389 * buffer.c: Temporarily extern Qdelete_window.
9390 (Fbury_buffer): Temporarily call Qdelete_window instead of
9391 Fdelete_window (Fbury_buffer will move to window.el soon).
9392
9393 * frame.c (set_menu_bar_lines_1): Remove code handling
9394 orig_top_line and orig_total_lines.
9395
9396 * dispnew.c (adjust_frame_glyphs_initially): Don't use
9397 set_window_height but set heights directly.
9398 (change_frame_size_1): Use resize_frame_windows.
9399
9400 * xdisp.c (init_xdisp): Don't use set_window_height but set
9401 heights directly.
9402
640c8776
SM
9403 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
9404 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
9405 run_window_configuration_change_hook.
9406
9407 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
9408 instead of change_window_heights and run
9409 run_window_configuration_change_hook.
9410
1a13852e
MR
94112011-06-09 Martin Rudalics <rudalics@gmx.at>
9412
9413 * window.c (replace_window): Rename second argument REPLACEMENT to
9414 NEW. New third argument SETFLAG. Rewrite.
9415 (delete_window, make_dummy_parent): Call replace_window with
9416 third argument 1.
9417 (window_list_1): Move down in code.
9418 (run_window_configuration_change_hook): Move set_buffer part
9419 before select_frame_norecord part in order to unwind correctly.
9420 Rename count1 to count.
9421 (recombine_windows, delete_deletable_window, resize_root_window)
9422 (Fdelete_other_windows_internal)
9423 (Frun_window_configuration_change_hook, make_parent_window)
9424 (resize_window_check, resize_window_apply, Fresize_window_apply)
9425 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
9426 (Fdelete_window_internal, Fresize_mini_window_internal):
9427 New functions.
1a13852e
MR
9428 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
9429
f3d1777e
MR
94302011-06-08 Martin Rudalics <rudalics@gmx.at>
9431
496e208e
MR
9432 * window.h (window): Add some new members to window structure -
9433 normal_lines, normal_cols, new_total, new_normal, clone_number,
9434 splits, nest, prev_buffers, next_buffers.
9435 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 9436 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 9437
f3d1777e
MR
9438 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
9439 Remove.
496e208e
MR
9440 (make_dummy_parent): Set new members of windows structure.
9441 (make_window): Move down in code. Handle new members of window
9442 structure.
9443 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
9444 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
9445 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
9446 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
9447 (Fset_window_next_buffers, Fset_window_clone_number):
9448 New functions.
496e208e
MR
9449 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
9450 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
9451 Doc-string fixes.
9452 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
9453 Argument WINDOW can be now internal window too.
9454 (Fwindow_use_time): Move up in code.
9455 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
9456 Rewrite doc-string.
9457 (Fset_window_configuration, saved_window)
9458 (Fcurrent_window_configuration, save_window_save): Handle new
9459 members of window structure.
b9e809c2
MR
9460 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
9461 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
9462 (syms_of_window): New Lisp objects Qrecord_window_buffer,
9463 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
9464 Qget_mru_window, Qresize_root_window,
9465 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
9466 Qauto_buffer_name; staticpro them.
f3d1777e 9467
abde8f8c
MR
94682011-06-07 Martin Rudalics <rudalics@gmx.at>
9469
9470 * window.c (Fwindow_total_size, Fwindow_left_column)
9471 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
9472 (Fwindow_list_1): New functions.
9473 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
9474 (Fwindow_width, Fscroll_left, Fscroll_right):
9475 Use window_body_cols instead of window_box_text_cols.
9476 (delete_window, Fset_window_configuration):
9477 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
9478 (delete_all_subwindows): Take a window as argument and not a
9479 structure. Rewrite.
190b47e6
MR
9480 (window_loop): Remove handling of GET_LRU_WINDOW and
9481 GET_LARGEST_WINDOW.
9482 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
9483
9484 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
9485 window_box_text_cols. delete_all_subwindows now takes a
9486 Lisp_Object as argument.
abde8f8c 9487
640c8776
SM
9488 * indent.c (compute_motion, Fcompute_motion):
9489 Use window_body_cols instead of window_box_text_cols.
abde8f8c 9490
fa8a67e6
MR
9491 * frame.c (delete_frame): Call delete_all_subwindows with root
9492 window as argument.
9493
a54e3482
DC
94942011-06-07 Daniel Colascione <dan.colascione@gmail.com>
9495
9496 * fns.c (Fputhash): Document return value.
9497
60002bf5
CY
94982011-06-06 Chong Yidong <cyd@stupidchicken.com>
9499
9500 * image.c (gif_load): Implement gif89a spec "no disposal" method.
9501
0c671da6 95022011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 9503
b862a52a 9504 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 9505
be44ca6c
PE
9506 Check for overflow when converting integer to cons and back.
9507 * charset.c (Fdefine_charset_internal, Fdecode_char):
9508 Use cons_to_unsigned to catch overflow.
9509 (Fencode_char): Use INTEGER_TO_CONS.
9510 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
9511 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
9512 * data.c (long_to_cons, cons_to_long): Remove.
9513 (cons_to_unsigned, cons_to_signed): New functions.
9514 These signal an error for invalid or out-of-range values.
9515 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
9516 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
9517 * font.c (Ffont_variation_glyphs):
9518 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
9519 * lisp.h: Include <intprops.h>.
9520 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
9521 (cons_to_signed, cons_to_unsigned): New decls.
9522 (long_to_cons, cons_to_long): Remove decls.
9523 * undo.c (record_first_change): Use INTEGER_TO_CONS.
9524 (Fprimitive_undo): Use CONS_TO_INTEGER.
9525 * xfns.c (Fx_window_property): Likewise.
9526 * xselect.c: Include <limits.h>.
9527 (x_own_selection, selection_data_to_lisp_data):
9528 Use INTEGER_TO_CONS.
9529 (x_handle_selection_request, x_handle_selection_clear)
9530 (x_get_foreign_selection, Fx_disown_selection_internal)
9531 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
9532 (lisp_data_to_selection_data): Use cons_to_unsigned.
9533 (x_fill_property_data): Use cons_to_signed.
9534 Report values out of range.
9535
d1f3d2af
PE
9536 Check for buffer and string overflow more precisely.
9537 * buffer.h (BUF_BYTES_MAX): New macro.
9538 * lisp.h (STRING_BYTES_MAX): New macro.
9539 * alloc.c (Fmake_string):
9540 * character.c (string_escape_byte8):
9541 * coding.c (coding_alloc_by_realloc):
9542 * doprnt.c (doprnt):
9543 * editfns.c (Fformat):
9544 * eval.c (verror):
9545 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
9546 since they may not be the same number.
9547 * editfns.c (Finsert_char):
9548 * fileio.c (Finsert_file_contents):
9549 Likewise for BUF_BYTES_MAX.
9550
dd52fcea
PE
9551 * image.c: Use ptrdiff_t, not int, for sizes.
9552 (slurp_file): Switch from int to ptrdiff_t.
9553 All uses changed.
9554 (slurp_file): Check that file size fits in both size_t (for
9555 malloc) and ptrdiff_t (for sanity and safety).
9556
7f9bbdbb
PE
9557 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
9558 if b->modtime has its maximal value.
9559
dfe18f82
PE
9560 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
9561
84acfcf0
PE
9562 Don't assume time_t can fit into int.
9563 * buffer.h (struct buffer.modtime): Now time_t, not int.
9564 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
9565 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
9566
ccd9a01a
PE
9567 Minor fixes for signed vs unsigned integers.
9568 * character.h (MAYBE_UNIFY_CHAR):
9569 * charset.c (maybe_unify_char):
9570 * keyboard.c (read_char, reorder_modifiers):
9571 XINT -> XFASTINT, since the integer must be nonnegative.
9572 * ftfont.c (ftfont_spec_pattern):
9573 * keymap.c (access_keymap, silly_event_symbol_error):
9574 XUINT -> XFASTINT, since the integer must be nonnegative.
9575 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
9576 since it makes no difference and we prefer signed.
9577 * keyboard.c (record_char): Use XUINT when all the neighbors do.
9578 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
9579 nonnegative.
9580
d6d100dd
SM
95812011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
9582
9583 * window.h (Fwindow_frame): Declare.
9584
2b6148e4
PE
95852011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9586
9587 * alloc.c: Simplify handling of large-request failures (Bug#8800).
9588 (SPARE_MEMORY): Always define.
9589 (LARGE_REQUEST): Remove.
9590 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
9591
f230ecc9
MR
95922011-06-06 Martin Rudalics <rudalics@gmx.at>
9593
727e958e
MR
9594 * lisp.h: Move EXFUNS for Fframe_root_window,
9595 Fframe_first_window and Fset_frame_selected_window to window.h.
9596
9597 * window.h: Move EXFUNS for Fframe_root_window,
9598 Fframe_first_window and Fset_frame_selected_window here from
9599 lisp.h.
9600
9601 * frame.c (Fwindow_frame, Fframe_first_window)
9602 (Fframe_root_window, Fframe_selected_window)
9603 (Fset_frame_selected_window): Move to window.c.
9604 (Factive_minibuffer_window): Move to minibuf.c.
9605 (Fother_visible_frames_p): New function.
9606
9607 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
9608
f230ecc9
MR
9609 * window.c (decode_window, decode_any_window): Move up in code.
9610 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
9611 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
9612 (Fwindow_buffer): Move up and rewrite doc-string.
9613 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
9614 (Fwindow_prev): New functions.
727e958e
MR
9615 (Fwindow_frame): Move here from frame.c. Accept any window as
9616 argument.
9617 (Fframe_root_window, Fframe_first_window)
9618 (Fframe_selected_window): Move here from frame.c. Accept frame
9619 or arbitrary window as argument. Update doc-strings.
9620 (Fminibuffer_window): Move up in code.
9621 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
9622 (Fset_frame_selected_window): Move here from frame.c.
9623 Marginal rewrite.
727e958e
MR
9624 (Fselected_window, select_window, Fselect_window): Move up in
9625 code. Minor doc-string fixes.
f230ecc9 9626
4d09bcf6
PE
96272011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9628
9629 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
9630 Do not assume that spare memory exists; that assumption is valid
9631 only if SYSTEM_MALLOC.
9632 (LARGE_REQUEST): New macro, so that the issue of large requests
9633 is separated from the issue of spare memory.
9634
810928a2
AS
96352011-06-05 Andreas Schwab <schwab@linux-m68k.org>
9636
172418ad
AS
9637 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
9638 format. (Bug#8806)
9639
43f862f7
AS
9640 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
9641
810928a2
AS
9642 * xfns.c (x_set_scroll_bar_default_width): Move declarations
9643 before statements.
9644
a059fe24
JD
96452011-06-05 Jan Djärv <jan.h.d@swipnet.se>
9646
9647 * gtkutil.c (xg_get_default_scrollbar_width): New function.
9648
9649 * gtkutil.h: Declare xg_get_default_scrollbar_width.
9650
9651 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
9652 min width by calling x_set_scroll_bar_default_width (Bug#8505).
9653
989bf368
JB
96542011-06-05 Juanma Barranquero <lekktu@gmail.com>
9655
9656 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
9657
4b80f674
CY
96582011-06-04 Chong Yidong <cyd@stupidchicken.com>
9659
9660 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
9661 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
9662 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
9663 New error handlers.
4b80f674
CY
9664 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
9665 Obey Vx_select_enable_clipboard_manager. Catch errors in
9666 x_clipboard_manager_save (Bug#8779).
9667 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 9668 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 9669
99a33b77 96702011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
9671
9672 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
9673
99a33b77 96742011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
9675
9676 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
9677 in the current matrix if keep_current_p is non-zero.
9678
8264569d
EZ
96792011-06-04 Eli Zaretskii <eliz@gnu.org>
9680
9681 * bidi.c (bidi_level_of_next_char): Fix last change.
9682
57f97249
EZ
96832011-06-03 Eli Zaretskii <eliz@gnu.org>
9684
fec2107c 9685 Support bidi reordering of text covered by display properties.
57f97249 9686
fec2107c
EZ
9687 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
9688 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
9689 (bidi_cache_search, bidi_cache_iterator_state)
9690 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
9691 (bidi_level_of_next_char, bidi_move_to_visually_next):
9692 Support character positions inside a run of characters covered by a
fec2107c
EZ
9693 display string.
9694 (bidi_paragraph_init, bidi_resolve_explicit_1)
9695 (bidi_level_of_next_char): Call bidi_fetch_char and
9696 bidi_fetch_char_advance instead of FETCH_CHAR and
9697 FETCH_CHAR_ADVANCE.
9698 (bidi_init_it): Initialize new members.
9699 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
9700 definitions.
9701 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
9702 instead of using explicit *_CHAR codes.
d6d100dd
SM
9703 (bidi_resolve_explicit, bidi_resolve_weak):
9704 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
9705 bidirectional text is supported only in multibyte buffers.
9706 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
9707 it to initialize the frame_window_p member of struct bidi_it.
9708 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
9709 (bidi_resolve_explicit, bidi_resolve_weak)
9710 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
9711 bidi_it->nchars is non-positive.
9712 (bidi_level_of_next_char): Don't try to lookup the cache for the
9713 next/previous character if nothing is cached there yet, or if we
9714 were just reseat()'ed to a new position.
c40e2fb2 9715
0e14fe90
EZ
9716 * xdisp.c (set_cursor_from_row): Set start and stop points
9717 according to the row's direction when priming the loop that looks
9718 for the glyph on which to display cursor.
9719 (single_display_spec_intangible_p): Function deleted.
9720 (display_prop_intangible_p): Reimplement to call
9721 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
9722 Accept 3 additional arguments needed by handle_display_spec.
9723 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
9724 values: lists, `(when COND...)' forms, etc.
9725 (single_display_spec_string_p): Support property values that are
9726 lists with the argument STRING its top-level element.
9727 (display_prop_string_p): Fix the condition for processing a
9728 property that is a list to be consistent with handle_display_spec.
fec2107c 9729 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
9730 last portion of handle_display_prop.
9731 (compute_display_string_pos): Accept additional argument
9732 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
9733 value of a `display' property is a "replacing spec".
9734 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
9735 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
9736 the display property, but just return a value indicating whether
9737 the display property will replace the characters it covers.
9738 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
9739 frame_window_p members of struct bidi_it.
d6d100dd
SM
9740 (compute_display_string_pos, compute_display_string_end):
9741 New functions.
fec2107c
EZ
9742 (push_it): Accept second argument POSITION, where pop_it should
9743 jump to continue iteration.
9744 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 9745
fec2107c
EZ
9746 * keyboard.c (adjust_point_for_property): Adjust the call to
9747 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
9748
9749 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
9750 (bidi_init_it): Update prototypes.
9751 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
9752 (compute_display_string_pos, compute_display_string_end):
9753 Declare prototypes.
fec2107c
EZ
9754 (struct bidi_it): New members nchars and disp_pos. ch_len is now
9755 EMACS_INT.
fc6f18ce 9756
40087514 97572011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 9758
57f53182
PE
9759 Malloc failure behavior now depends on size of allocation.
9760 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
9761 * lisp.h: Change signatures accordingly.
9762 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
9763 All callers changed. (Bug#8762)
9764
9765 * gnutls.c: Use Emacs's memory allocators.
9766 Without this change, the gnutls library would invoke malloc etc.
9767 directly, which causes problems on non-SYNC_INPUT hosts, and which
9768 runs afoul of improving memory_full behavior. (Bug#8761)
9769 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
9770 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
9771 xfree instead of the default malloc, realloc, free.
9772 (Fgnutls_boot): No need to check for memory allocation failure,
9773 since xmalloc does that for us.
9774
ac32cd99 9775 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
9776 * category.c (hash_get_category_set):
9777 * ccl.c (ccl_driver):
9778 * charset.c (Fdefine_charset_internal):
9779 * charset.h (struct charset.hash_index):
9780 * composite.c (get_composition_id, gstring_lookup_cache)
9781 (composition_gstring_put_cache):
9782 * composite.h (struct composition.hash_index):
9783 * dispextern.h (struct image.hash):
9784 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
9785 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
9786 (hashfn_equal, hashfn_user_defined, make_hash_table)
9787 (maybe_resize_hash_table, hash_lookup, hash_put)
9788 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
9789 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
9790 (Fsxhash, Fgethash, Fputhash, Fmaphash):
9791 * image.c (make_image, search_image_cache, lookup_image)
9792 (xpm_put_color_table_h):
9793 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 9794 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 9795 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 9796 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
9797 * alloc.c (allocate_vectorlike):
9798 Check for overflow in vector size calculations.
9799 * ccl.c (ccl_driver):
9800 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
9801 * fns.c, image.c: Remove unnecessary static decls that would otherwise
9802 need to be updated by these changes.
40087514
PE
9803 * fns.c (make_hash_table, maybe_resize_hash_table):
9804 Check for integer overflow with large hash tables.
0de4bb68
PE
9805 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
9806 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
9807 (SXHASH_REDUCE): New macro.
9808 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
9809 Use it instead of discarding useful hash info with large hash values.
9810 (sxhash_float): New function.
9811 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
9812 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
9813 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
9814 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
9815 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
9816 Adjust signatures to match updated version of code.
9817 (consing_since_gc): Now EMACS_INT, since a single hash table can
9818 use more than INT_MAX bytes.
9819
698d32e2
DN
98202011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
9821
9822 Make it possible to build with GCC-4.6+ -O2 -flto.
9823
9824 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
9825
fd6fa53f
SM
98262011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
9827
9828 * minibuf.c (get_minibuffer, read_minibuf_unwind):
9829 Call minibuffer-inactive-mode.
9830
864db017
JB
98312011-05-31 Juanma Barranquero <lekktu@gmail.com>
9832
9833 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
9834 Update dependencies.
9835
2ad0baf4
DN
98362011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9837
9838 * data.c (init_data): Remove code for UTS, this system is not
9839 supported anymore.
9840
4fcc2638
DN
98412011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9842
9843 Don't force ./temacs to start in terminal mode.
9844
9845 * frame.c (make_initial_frame): Initialize faces in all cases, not
9846 only when CANNOT_DUMP is defined.
9847 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
9848
c56e0fd5
DN
98492011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9850
9851 * dispnew.c (add_window_display_history): Use const for the string
9852 pointer. Remove declaration, not needed.
9853
333d54da 98542011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 9855
55d4c1b2 9856 Use 'inline', not 'INLINE'.
333d54da 9857 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
9858 * alloc.c, fontset.c (INLINE): Remove.
9859 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
9860 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
9861 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
9862 * gmalloc.c (register_heapinfo): Use inline unconditionally.
9863 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
9864
738db178
DN
98652011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9866
9867 Make it possible to run ./temacs.
9868
9869 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
9870 syms_of_callproc does the same thing. Remove test for
9871 "initialized", do it in the caller.
9872 * emacs.c (main): Avoid calling set_initial_environment when dumping.
9873
620c53a6
SM
98742011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
9875
9876 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
9877 (read_minibuf): Use get_minibuffer.
9878 (syms_of_minibuf): Use DEFSYM.
9879 (Qmetadata): New var.
9880 * data.c (Qbuffer): Don't make it static.
9881 (syms_of_data): Use DEFSYM.
9882
e003a292
PE
98832011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9884
9885 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
9886 (CCL_CODE_MIN): New macro.
9887
ed008a6d
PE
98882011-05-30 Paul Eggert <eggert@cs.ucla.edu>
9889
3687c2ef
PE
9890 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
9891
ed008a6d
PE
9892 * eval.c (Qdebug): Now static.
9893 * lisp.h (Qdebug): Remove decl. This reverts a part of the
9894 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
9895 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
9896
d66c4c7c
CY
98972011-05-29 Chong Yidong <cyd@stupidchicken.com>
9898
9899 * image.c: Various fixes to ImageMagick code comments.
9900 (Fimagemagick_types): Doc fix.
9901
5fbc2025
PE
99022011-05-29 Paul Eggert <eggert@cs.ucla.edu>
9903
0196f88a
PE
9904 Minor fixes prompted by GCC 4.6.0 warnings.
9905
9906 * xselect.c (converted_selections, conversion_fail_tag): Now static.
9907
5fbc2025
PE
9908 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
9909 (x_clipboard_manager_save_all): Move extern decl to ...
9910 * xterm.h: ... here, so that it can be checked for consistency.
9911
1dd3c2d9
CY
99122011-05-29 Chong Yidong <cyd@stupidchicken.com>
9913
9914 * xselect.c (x_clipboard_manager_save_frame)
9915 (x_clipboard_manager_save_all): New functions.
9916 (Fx_clipboard_manager_save): Lisp function deleted.
9917
9918 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
9919 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
9920
9921 * xterm.h: Update prototype.
9922
5ba6571d
WX
99232011-05-28 William Xu <william.xwl@gmail.com>
9924
9925 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
9926 exiting (Bug#8239).
9927
3eaff834
JM
99282011-05-28 Jim Meyering <meyering@redhat.com>
9929
e1900994 9930 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
9931 * fns.c (to_uchar): Define.
9932 (crypto_hash_function): Use it to convert some newly-signed
9933 variables to unsigned, to avoid sign-extension bugs. For example,
9934 without this change, (md5 "truc") would evaluate to
9935 45723a2aff78ff4fff7fff1114760e62 rather than the expected
9936 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 9937 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 9938
0f6990a7
PE
99392011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9940
9941 Integer overflow fixes.
c8a9ca5a 9942
08686060
PE
9943 * dbusbind.c: Serial number integer overflow fixes.
9944 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
9945 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
9946 to hold a serial number that is too large for a fixnum.
9947 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9948 Check for serial numbers out of range. Decode any serial number
59568bf0 9949 that was so large that it became a float. (Bug#8722)
08686060 9950
2d1fc3c7
PE
9951 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
9952 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9953 Use XFASTINT rather than XUINT when numbers are nonnegative.
9954 (xd_append_arg, Fdbus_method_return_internal):
9955 (Fdbus_method_error_internal): Likewise. Also, for unsigned
9956 arguments, check that Lisp number is nonnegative, rather than
59568bf0 9957 silently wrapping negative numbers around. (Bug#8722)
30217ff0 9958 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 9959 (Bug#8722)
2d1fc3c7 9960
c8a9ca5a
PE
9961 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
9962
519e1d69
PE
9963 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
9964
6df6ae42 9965 ccl: Add integer overflow checks.
30569699
PE
9966 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
9967 (IN_INT_RANGE): New macros.
9968 (ccl_driver): Use them to check for integer overflow when
9969 decoding a CCL program. Many of the new checks are whether XINT (x)
9970 fits in int; it doesn't always, on 64-bit hosts. The new version
9971 doesn't catch all possible integer overflows, but it's an
847044ea 9972 improvement. (Bug#8719)
30569699 9973
c11285dc
PE
9974 * alloc.c (make_event_array): Use XINT, not XUINT.
9975 There's no need for unsigned here.
9976
fdccd48e
PE
9977 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
9978 This follows up to the 2011-05-06 change that substituted uintptr_t
9979 for EMACS_INT. This case wasn't caught back then.
9980
37910ab2
PE
9981 Rework Fformat to avoid integer overflow issues.
9982 * editfns.c: Include <float.h> unconditionally, as it's everywhere
9983 now (part of C89). Include <verify.h>.
9984 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
9985 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
9986 (Fformat): Avoid the prepass trying to compute sizes; it was only
9987 approximate and thus did not catch overflow reliably. Instead, walk
9988 through the format just once, formatting and computing sizes as we go,
9989 checking for integer overflow at every step, and allocating a larger
9990 buffer as needed. Keep track separately whether the format is
9991 multibyte. Keep only the most-recently calculated precision, rather
9992 than them all. Record whether each argument has been converted to
9993 string. Use EMACS_INT, not int, for byte and char and arg counts.
9994 Support field widths and precisions larger than INT_MAX. Avoid
9995 sprintf's undefined behavior with conversion specifications such as %#d
9996 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
9997 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
9998 formatting out-of-range floating point numbers with int
9173deec 9999 formats. (Bug#8668)
37910ab2 10000
2e6578fb
PE
10001 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
10002
0ae6bdee
PE
10003 * data.c: Avoid integer truncation in expressions involving floats.
10004 * data.c: Include <intprops.h>.
10005 (arith_driver): When there's an integer overflow in an expression
10006 involving floating point, convert the integers to floating point
10007 so that the resulting value does not suffer from catastrophic
10008 integer truncation. For example, on a 64-bit host (* 4
10009 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
10010 Do not rely on undefined behavior after integer overflow.
10011
de883a70
PE
10012 merge count_size_as_multibyte, parse_str_to_multibyte
10013 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 10014 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
10015 Check for integer overflow.
10016 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
10017 since it's now a duplicate of the other. This is more of
10018 a character than a buffer op, so better that it's in character.c.
10019 * fns.c, print.c: Adjust to above changes.
10020
2ff916cb
PE
100212011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
10022
10023 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
10024
f1b54466
PE
100252011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10026
fb1ac845
PE
10027 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10028 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
10029 (x_clipboard_manager_save): Now static.
10030 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
10031
f1b54466
PE
10032 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10033 (crypto_hash_function): Now static.
10034 Fix pointer signedness problems. Avoid unnecessary initializations.
10035
a9f737ee
CY
100362011-05-27 Chong Yidong <cyd@stupidchicken.com>
10037
10038 * termhooks.h (Vselection_alist): Make it terminal-local.
10039
10040 * terminal.c (create_terminal): Initialize it.
10041
10042 * xselect.c: Support for clipboard managers.
10043 (Vselection_alist): Move to termhooks.h as terminal-local var.
10044 (LOCAL_SELECTION): New macro.
10045 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
10046 (symbol_to_x_atom): Remove gratuitous arg.
10047 (x_handle_selection_request, lisp_data_to_selection_data)
10048 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
10049 (x_own_selection, x_get_local_selection, x_convert_selection):
10050 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
10051 (some_frame_on_display): Delete unused function.
10052 (Fx_own_selection_internal, Fx_get_selection_internal)
10053 (Fx_disown_selection_internal, Fx_selection_owner_p)
10054 (Fx_selection_exists_p): New optional frame arg.
10055 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
10056 (x_handle_selection_clear): Don't treat other terminals with the
10057 same keyboard specially. Use the terminal-local Vselection_alist.
10058 (x_clear_frame_selections): Use Frun_hook_with_args.
10059
10060 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
10061
10062 * xterm.h: Add support for those atoms.
10063
e067f0c1
CY
100642011-05-26 Chong Yidong <cyd@stupidchicken.com>
10065
10066 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
10067 (converted_selections, conversion_fail_tag): New global variables.
10068 (x_selection_request_lisp_error): Free the above.
10069 (x_get_local_selection): Remove unnecessary code.
10070 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
10071 of converted selections stored in converted_selections.
10072 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
10073 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
10074 (x_convert_selection): New function.
10075 (x_handle_selection_event): Simplify.
10076 (x_get_foreign_selection): Don't ignore incoming requests while
10077 waiting for an answer; this will fail when we implement
10078 SAVE_TARGETS, and seems unnecessary anyway.
10079 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
10080 (Vx_sent_selection_functions): Doc fix.
10081
0f4aebc0
LL
100822011-05-26 Leo Liu <sdl.web@gmail.com>
10083
10084 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
10085
e61124cd
YM
100862011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10087
10088 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
10089
10090 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
10091 for fringe update if it has periodic bitmap.
ac389d0c 10092 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
10093 and fringe_bitmap_periodic_p.
10094
10095 * fringe.c (get_fringe_bitmap_data): New function.
10096 (draw_fringe_bitmap_1, update_window_fringes): Use it.
10097 (update_window_fringes): Record periodicity of fringe bitmap in glyph
10098 row. Mark glyph row for fringe update if periodicity changed.
10099
10100 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
10101 for fringe update unless it has periodic bitmap.
10102
f16d9837
KH
101032011-05-25 Kenichi Handa <handa@m17n.org>
10104
10105 * xdisp.c (get_next_display_element): Set correct it->face_id for
10106 a static composition.
10107
e1b90ef6
LL
101082011-05-24 Leo Liu <sdl.web@gmail.com>
10109
10110 * deps.mk (fns.o):
10111 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
10112
10113 * fns.c (crypto_hash_function, Fsha1): New function.
10114 (Fmd5): Use crypto_hash_function.
10115 (syms_of_fns): Add Ssha1.
10116
7400048f
PE
101172011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10118
10119 * gnutls.c: Remove unused macros.
10120 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
10121 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
10122 Remove macros that are defined and never used.
10123 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
10124
abb71cf4
CY
101252011-05-22 Chong Yidong <cyd@stupidchicken.com>
10126
10127 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
10128 (Fx_get_selection_internal): Minor cleanup.
10129 (Fx_own_selection_internal): Rename arguments for consistency with
10130 select.el.
10131
6307db39
PE
101322011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10133
10134 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
10135
f3d4e0a4
CY
101362011-05-22 Chong Yidong <cyd@stupidchicken.com>
10137
10138 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
10139
4d8ade89
YM
101402011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10141
10142 * dispnew.c (scrolling_window): Don't exclude the case that the
10143 last enabled row in the desired matrix touches the bottom boundary.
10144
32078c8d
GM
101452011-05-21 Glenn Morris <rgm@gnu.org>
10146
10147 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
10148 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
10149 and add some more files.
32078c8d 10150
7285dc67
EZ
101512011-05-20 Eli Zaretskii <eliz@gnu.org>
10152
10153 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
10154 report_file_error introduced by the change from 2011-05-07.
10155
89d1bd22
PE
101562011-05-20 Paul Eggert <eggert@cs.ucla.edu>
10157
10158 * systime.h (Time): Define only if emacs is defined.
10159 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
10160 where the include path doesn't have X11/X.h by default. See
10161 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
10162
cd394be1 101632011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
10164
10165 * composite.c (find_automatic_composition): Fix previous change.
10166
b9704ad9
GM
101672011-05-20 Glenn Morris <rgm@gnu.org>
10168
10169 * lisp.mk: New file, split from Makefile.in.
10170 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
10171 (shortlisp): Remove.
10172 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
10173
4a720484
GM
101742011-05-19 Glenn Morris <rgm@gnu.org>
10175
10176 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
10177 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
10178 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
10179 (lisp): Set the order to that of loadup.el.
10180 (shortlisp): Make it a copy of $lisp.
10181 (SOME_MACHINE_LISP): Remove.
10182 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
10183 Use just $shortlisp, not $SOME_MACHINE_LISP too.
10184
a28d4396
KH
101852011-05-18 Kenichi Handa <handa@m17n.org>
10186
10187 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
10188 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
10189 (find_automatic_composition): Mostly rewrite for efficiency.
10190
a2b1fa8e
JB
101912011-05-18 Juanma Barranquero <lekktu@gmail.com>
10192
10193 * makefile.w32-in: Update dependencies.
10194
8e1f5610
CS
101952011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
10196
10197 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 10198 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 10199
7025ee00 102002011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 10201
cdfa6eab
PE
10202 Fix some integer overflow issues, such as string length overflow.
10203
06d6db33
PE
10204 * insdel.c (count_size_as_multibyte): Check for string overflow.
10205
2b4560a8
PE
10206 * character.c (lisp_string_width): Check for string overflow.
10207 Use EMACS_INT, not int, for string indexes and lengths; in
10208 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
10209 the resulting string length overflows an EMACS_INT; instead,
10210 report a string overflow if no precision given. When checking for
10211 precision exhaustion, use a check that cannot possibly have
10212 integer overflow. (Bug#8675)
10213 * character.h (lisp_string_width): Adjust to new signature.
10214
cb93f9be
PE
10215 * alloc.c (string_overflow): New function.
10216 (Fmake_string): Use it. This doesn't change behavior, but saves
10217 a few bytes and will simplify future changes.
10218 * character.c (string_escape_byte8): Likewise.
10219 * lisp.h (string_overflow): New decl.
10220
1a1f3366
PE
10221 Fixups, following up to the user-interface timestamp change.
10222 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
10223 for UI timestamps, instead of unsigned long.
9fbd6841
PE
10224 * msdos.c (mouse_get_pos): Likewise.
10225 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
10226 * w32gui.h (Time): Define by including "systime.h" rather than by
10227 declaring it ourselves. (Bug#8664)
10228
d4e3e4d3
PE
10229 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
10230 * image.c (clear_image_cache): Likewise.
10231
f6a24d19
PE
10232 * term.c (term_mouse_position): Don't assume time_t wraparound.
10233
08dc5ae6
PE
10234 Be more systematic about user-interface timestamps.
10235 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
10236 and sometimes 'EMACS_UINT', to represent these timestamps.
10237 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
10238 This makes the code easier to follow, and makes it easier to catch
10239 integer overflow bugs such as Bug#8664.
10240 * frame.c (Fmouse_position, Fmouse_pixel_position):
10241 Use Time, not unsigned long, for user-interface timestamps.
10242 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
10243 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
10244 * keyboard.h (last_event_timestamp): Likewise.
10245 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
10246 * menu.h (xmenu_show): Likewise.
10247 * term.c (term_mouse_position): Likewise.
10248 * termhooks.h (struct input_event.timestamp): Likewise.
10249 (struct terminal.mouse_position_hook): Likewise.
10250 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
10251 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
10252 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
10253 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
10254 what it was before.
10255 * menu.h, termhooks.h: Include "systime.h", for Time.
10256
8e55734a
PE
10257 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
10258 Don't assume that the difference between two unsigned long values
10259 can fit into an integer. At this point, we know button_down_time
10260 <= event->timestamp, so the difference must be nonnegative, so
10261 there's no need to cast the result if double-click-time is
10262 nonnegative, as it should be; check that it's nonnegative, just in
10263 case. This bug is triggered when events are more than 2**31 ms
86db42d2 10264 apart (about 25 days). (Bug#8664)
8e55734a 10265
841f1b75 10266 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 10267 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 10268
3e26f69c
PE
10269 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
10270 that always fit in int. Use a sentinel instead of a counter, to
10271 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
10272 * frame.h (struct frame): Use int for menu_bar_items_used
10273 instead of EMACS_INT, since it always fits in int.
3e26f69c 10274
5cc152c0
PE
10275 * menu.c (grow_menu_items): Check for int overflow.
10276
d89eb65e
PE
10277 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
10278
5235bd3e
PE
10279 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
10280 Before, the code was not consistent. These values cannot exceed
10281 2**31 - 1 so there's no need to make them unsigned.
10282 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
10283 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
10284 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
10285 as modifiers.
10286 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
10287
bc827e23
PE
10288 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
10289 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
10290 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
10291 presumably because the widths might not match.
10292
78eb494e
PE
10293 * window.c (size_window): Avoid needless test at loop start.
10294
04f2d78b
CB
102952011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
10296
10297 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
10298
d2fc7e3d 102992011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
10300
10301 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
10302
d2fc7e3d 103032011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
10304
10305 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
10306 `width' to `bar_area_x' and `bar_area_width', respectively.
10307 (x_scroll_run): Take account of fringe background extension.
10308
04f2d78b
CB
10309 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
10310 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
10311 `bar_area_width', respectively.
10312 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
10313 background extension.
10314
79b70037
GM
103152011-05-10 Jim Meyering <meyering@redhat.com>
10316
10317 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
10318
2f142cc5
JB
103192011-05-10 Juanma Barranquero <lekktu@gmail.com>
10320
10321 * image.c (Finit_image_library): Return t for built-in image types,
10322 like pbm and xbm. (Bug#8640)
10323
57679c86
AS
103242011-05-09 Andreas Schwab <schwab@linux-m68k.org>
10325
10326 * w32menu.c (set_frame_menubar): Fix submenu allocation.
10327
888c9e86
EZ
103282011-05-07 Eli Zaretskii <eliz@gnu.org>
10329
b0512a1d
EZ
10330 * w32console.c (Fset_screen_color): Doc fix.
10331 (Fget_screen_color): New function.
10332 (syms_of_ntterm): Defsubr it.
10333
7285dc67
EZ
10334 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
10335 unlink the temporary file if Fcall_process didn't create it in the
10336 first place.
10337 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
10338 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
10339 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
10340 cue to call_process_cleanup not to close that handle.
10341
4d3fcc8e
BK
103422011-05-07 Ben Key <bkey76@gmail.com>
10343
10344 * makefile.w32-in: The bootstrap-temacs rule now makes use of
10345 one of two shell specific rules, either bootstrap-temacs-CMD or
10346 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
10347 to the previous implementation of the bootstrap-temacs rule.
10348 The bootstrap-temacs-CMD rule is similar to the previous
10349 implementation of the bootstrap-temacs rule except that it
10350 makes use of the ESC_CFLAGS variable instead of the CFLAGS
10351 variable.
10352
10353 These changes, along with some changes to nt/configure.bat,
10354 nt/gmake.defs, and nt/nmake.defs, are required to extend my
10355 earlier fix to add support for --cflags and --ldflags options
10356 that include quotes so that it works whether make uses cmd or
10357 sh as the shell.
10358
b4289b64
MA
103592011-05-06 Michael Albinus <michael.albinus@gmx.de>
10360
10361 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
10362 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
10363 is a constant.
10364 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
10365 a string. Handle both cases.
10366 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
10367 (Fdbus_register_method): Use Qinvalid_function.
10368
af4c0e28
JB
103692011-05-06 Juanma Barranquero <lekktu@gmail.com>
10370
10371 * makefile.w32-in: Update dependencies.
10372 (LISP_H): Add inttypes.h and stdin.h.
10373 (PROCESS_H): Add unistd.h.
10374
c51453d9
EZ
103752011-05-06 Eli Zaretskii <eliz@gnu.org>
10376
10377 * lread.c: Include limits.h (fixes the MS-Windows build broken by
10378 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
10379
8ff0ac3c 103802011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 10381
4c4b566b
PE
10382 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
10383
aab2b9b5
PE
10384 * term.c (vfatal): Remove stray call to va_end.
10385 It's not needed and the C Standard doesn't allow it here anyway.
10386
c378da0b
PE
10387 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
10388 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
10389
288b08c7
PE
10390 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
10391 bytes.
10392
e3601888
PE
10393 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
10394
db6c0e74
PE
10395 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
10396
dd5963ea
PE
10397 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
10398
88c9450f
PE
10399 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
10400
2f9442b8
PE
10401 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
10402
c032b5f8
PE
10403 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
10404 * charset.c (Fdefine_charset_internal): Don't initialize
10405 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 10406 32-bit int (Bug#8600).
a108c10b
PE
10407
10408 * lread.c (read_integer): Be more consistent with string-to-number.
10409 Use string_to_number to do the actual conversion; this avoids
10410 rounding errors and fixes some other screwups. Without this fix,
10411 for example, #x1fffffffffffffff was misread as -2305843009213693952.
10412 (digit_to_number): Move earlier, for benefit of read_integer.
10413 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 10414 not a digit in any supported base. (Bug#8602)
a108c10b 10415
ad5f9eea
PE
10416 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
10417
aec1708a
PE
10418 * dispnew.c (scrolling_window): Return 1 if we scrolled,
10419 to match comment at start of function. This also removes a
10420 GCC warning about overflow in a 32+64-bit port.
10421
47be4ab5
PE
10422 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
10423
371cac43
PE
10424 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
10425 Reported by Stefan Monnier in
10426 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
10427 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10428 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 10429
d01a7826
PE
10430 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
10431 (EMACS_UINTPTR): Likewise, with uintptr_t.
10432
7fd47d5c
PE
10433 * lisp.h: Prefer 64-bit EMACS_INT if available.
10434 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
10435 on 32-bit hosts that have 64-bit int, so that they can access
10436 large files.
122b0c86
PE
10437 However, temporarily disable this change unless the temporary
10438 symbol WIDE_EMACS_INT is defined.
7fd47d5c 10439
8727937b
PE
10440 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
10441
8ac068ac
PE
10442 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
10443 This removes an assumption that EMACS_INT and long are the same
10444 width as pointers. The assumption is true for Emacs porting targets
10445 now, but we want to make other targets possible.
10446 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
10447 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
10448 In the rest of the code, change types of integers that hold casted
10449 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
10450 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
10451 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
10452 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
10453 No need to cast type when ORing.
10454 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
10455 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
10456 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
10457 assume EMACS_INT is the same width as char *.
10458 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
10459 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
10460 Remove no-longer-needed casts.
10461 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
10462 (xg_tool_bar_help_callback, xg_make_tool_item):
10463 Use EMACS_INTPTR to hold an integer
10464 that will be cast to void *; this can avoid a GCC warning
10465 if EMACS_INT is not the same width as void *.
10466 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
10467 * xdisp.c (display_echo_area_1, resize_mini_window_1):
10468 (current_message_1, set_message_1):
10469 Use a local to convert to proper width without a cast.
10470 * xmenu.c (dialog_selection_callback): Likewise.
10471
ede49d71
PE
10472 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
10473 Also, don't assume VALBITS / RAND_BITS is less than 5,
10474 and don't rely on undefined behavior when shifting a 1 left into
10475 the sign bit.
10476 * lisp.h (get_random): Change signature to match.
10477
2f30ecd0
PE
10478 * lread.c (hash_string): Use size_t, not int, for hash computation.
10479 Normally we prefer signed values; but hashing is special, because
10480 it's better to use unsigned division on hash table sizes so that
10481 the remainder is nonnegative. Also, size_t is the natural width
10482 for hashing into memory. The previous code used 'int', which doesn't
10483 retain enough info to hash well into very large tables.
10484 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
10485
2a866e7b
PE
10486 * dbusbind.c: Don't possibly lose pointer info when converting.
10487 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10488 Use XPNTR rather than XHASH, so that the high-order bits of
10489 the pointer aren't lost when converting through void *.
10490
51639eac
PE
10491 * eval.c (Fautoload): Don't double-shift a pointer.
10492
92394119
PE
10493 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
10494
dbdb9a7c
JB
104952011-05-06 Juanma Barranquero <lekktu@gmail.com>
10496
10497 * gnutls.c (DEF_GNUTLS_FN):
10498 * image.c (DEF_IMGLIB_FN): Make function pointers static.
10499
db7a0b4f
AS
105002011-05-05 Andreas Schwab <schwab@linux-m68k.org>
10501
10502 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
10503 marker. (Bug#8610)
10504
cd394be1 105052011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
10506
10507 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
10508 New version that can reserve upto 2GB of heap space.
10509
f7ff1b0f 105102011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
10511
10512 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
10513
639c109b
TZ
105142011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
10515
10516 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
10517 `gnutls_certificate_set_x509_key_file'.
10518
d2127135
JB
105192011-05-05 Juanma Barranquero <lekktu@gmail.com>
10520
10521 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
10522 Update dependencies.
10523
e968f4f3
JB
105242011-05-04 Juanma Barranquero <lekktu@gmail.com>
10525
10526 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
10527 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
10528 Remove unused parameter `fildes'.
10529 * process.c (read_process_output, send_process): Don't pass it.
10530
84d358f0
JB
105312011-05-04 Juanma Barranquero <lekktu@gmail.com>
10532
10533 Fix previous change: the library cache is defined in w32.c.
10534 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
10535 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
10536
0898ca10
JB
105372011-05-04 Juanma Barranquero <lekktu@gmail.com>
10538
10539 Implement dynamic loading of GnuTLS on Windows.
10540
10541 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
10542 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
10543 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10544 Declare.
10545
10546 * gnutls.c (Qgnutls_dll): Define.
10547 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
10548 (gnutls_*): Declare function pointers.
10549 (init_gnutls_functions): New function to initialize function pointers.
10550 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
10551 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
10552 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10553 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
10554 (emacs_gnutls_write, emacs_gnutls_read)
10555 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
10556 (Fgnutls_available_p): New function.
10557 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
10558 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
10559 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
10560
10561 * image.c: Include w32.h.
10562 (Vimage_type_cache): Delete.
10563 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
10564 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
10565 (w32_delayed_load): Move to w32.c.
10566
10567 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
10568
10569 * w32.c (QCloaded_from, Vlibrary_cache): Define.
10570 (w32_delayed_load): Move from image.c. When loading a library, record
10571 its filename in the :loaded-from property of the library id.
10572 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
10573 Initialize and staticpro them.
10574 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
10575
10576 * process.c: Include lisp.h before w32.h, not after.
10577 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
10578 instead of gnutls_record_check_pending.
10579
10580 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
10581
ff4de4aa
TZ
105822011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
10583
10584 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
10585 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
10586 as passed in.
10587
abe95abb
JD
105882011-05-03 Jan Djärv <jan.h.d@swipnet.se>
10589
10590 * xterm.c (x_set_frame_alpha): Do not set property on anything
10591 else than FRAME_X_OUTER_WINDOW (Bug#8608).
10592
e16e55d4
JB
105932011-05-02 Juanma Barranquero <lekktu@gmail.com>
10594
10595 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
10596
bafcf6a5
JB
105972011-05-02 Juanma Barranquero <lekktu@gmail.com>
10598
10599 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
10600 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
10601 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
10602 (gnutls_global_initialized, Qgnutls_bootprop_priority)
10603 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
10604 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
10605 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
10606 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
10607 (Qgnutls_bootprop_callbacks_verify): Make static.
10608
e7a6747f
AS
106092011-05-01 Andreas Schwab <schwab@linux-m68k.org>
10610
19ed11ba
AS
10611 * callproc.c: Indentation fixup.
10612
e7a6747f 10613 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
10614 (wait_for_termination, interruptible_wait_for_termination):
10615 Move after wait_for_termination_1.
e7a6747f 10616
1ef14cb4
LMI
106172011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
10618
10619 * sysdep.c (interruptible_wait_for_termination): New function
10620 which is like wait_for_termination, but allows keyboard
10621 interruptions.
10622
10623 * callproc.c (Fcall_process): Add (:file "file") as an option for
10624 the STDOUT buffer.
10625 (Fcall_process_region): Ditto.
10626
330d880c
EZ
106272011-04-30 Eli Zaretskii <eliz@gnu.org>
10628
8db90b73
EZ
10629 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
10630 rather than `XVECTOR (FOO)->size'.
10631
330d880c
EZ
10632 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
10633 inttypes.h, as a gnulib replacement is used if it not available in
10634 system headers.
10635
15cbd324
EZ
106362011-04-21 Eli Zaretskii <eliz@gnu.org>
10637
10638 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
10639 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
10640 of MOST_POSITIVE_FIXNUM. (Bug#8528)
10641
10642 * coding.c (coding_alloc_by_realloc): Error out if destination
10643 will grow beyond MOST_POSITIVE_FIXNUM.
10644 (decode_coding_emacs_mule): Abort if there isn't enough place in
10645 charbuf for the composition carryover bytes. Reserve an extra
10646 space for up to 2 characters produced in a loop.
10647 (decode_coding_iso_2022): Abort if there isn't enough place in
10648 charbuf for the composition carryover bytes.
10649
106502011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 10651
ae940cca
EZ
10652 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
10653 aborting when %lld or %lll format is passed.
10654 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
10655 %llo or %llx format is passed. (Bug#8545)
10656
03ab8921
EZ
10657 * window.c (window_scroll_line_based): Use a marker instead of
10658 simple variables to record original value of point. (Bug#7952)
10659
afda1437
EZ
10660 * doprnt.c (doprnt): Fix the case where a multibyte sequence
10661 produced by %s or %c overflows available buffer space. (Bug#8545)
10662
f76dee0c
PE
106632011-04-28 Paul Eggert <eggert@cs.ucla.edu>
10664
10665 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 10666 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 10667
fdc5744d
JB
106682011-04-28 Juanma Barranquero <lekktu@gmail.com>
10669
10670 * w32.c (init_environment): Warn about defaulting HOME to C:\.
10671
638f053a
JB
106722011-04-28 Juanma Barranquero <lekktu@gmail.com>
10673
10674 * keyboard.c (Qdelayed_warnings_hook): Define.
10675 (command_loop_1): Run `delayed-warnings-hook'
10676 if Vdelayed_warnings_list is non-nil.
10677 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
10678 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
10679
d178f871
EZ
106802011-04-28 Eli Zaretskii <eliz@gnu.org>
10681
10682 * doprnt.c (doprnt): Don't return value smaller than the buffer
10683 size if the message was truncated. (Bug#8545).
10684
b124fd93
JB
106852011-04-28 Juanma Barranquero <lekktu@gmail.com>
10686
10687 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
10688 (Fx_window_property): #if-0 the whole functions, not just the bodies.
10689
e810457d
PE
106902011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10691
10692 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
10693
ea51cceb
JB
106942011-04-27 Juanma Barranquero <lekktu@gmail.com>
10695
10696 * makefile.w32-in: Update dependencies.
10697
94dcfacf
EZ
106982011-04-27 Eli Zaretskii <eliz@gnu.org>
10699
10700 Improve `doprnt' and its usage. (Bug#8545)
10701 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
10702 `format_end'. Remove support for %l as a conversion specifier.
10703 Don't use xrealloc. Improve diagnostics when the %l size modifier
10704 is used. Update the commentary.
10705
10706 * eval.c (verror): Simplify calculation of size_t.
10707
10708 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
10709 messages.
10710
f61f41d7
PE
107112011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
10712
10713 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
10714 change.
10715
96fb4434
PE
107162011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10717
10718 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
10719 This makes this file independent of the recent pseudovector change.
10720
671875da 107212011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 10722
69e9b5a3
PE
10723 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
10724
b5f869a7 10725 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 10726 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 10727 Remove unused local.
c8926152 10728 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 10729
841a1577 10730 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
10731 GCC 4.6.0 optimizes based on type-based alias analysis.
10732 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
10733 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
10734 != &v->size, and therefore "v->size = 1; b->size = 2; return
10735 v->size;" must therefore return 1. This assumption is incorrect
10736 for Emacs, since it type-puns struct Lisp_Vector * with many other
10737 types. To fix this problem, this patch adds a new type struct
f904488f 10738 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
10739 and pseudovectors, and helps optimizing compilers not get fooled
10740 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
10741 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
10742 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
10743 the size member.
eab3844f
PE
10744 (XSETPVECTYPE): Rewrite in terms of new macro.
10745 (XSETPVECTYPESIZE): New macro, specifying both type and size.
10746 This is a bit clearer, and further avoids the possibility of
10747 undesirable aliasing.
10748 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 10749 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
10750 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
10751 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
10752 (ASIZE): Now uses header.size rather than size.
10753 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
10754 to avoid the hassle of writing XVECTOR (foo)->header.size.
10755 (struct vectorlike_header): New type.
eab3844f
PE
10756 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
10757 object, to help avoid aliasing.
10758 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
10759 (SUBRP): Likewise, since Lisp_Subr is a special case.
10760 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
10761 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
10762 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 10763 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
10764 changed to be "header.size" and "header.next".
10765 * buffer.h (struct buffer): Likewise.
10766 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
10767 * frame.h (struct frame): Likewise.
10768 * process.h (struct Lisp_Process): Likewise.
10769 * termhooks.h (struct terminal): Likewise.
10770 * window.c (struct save_window_data, struct saved_window): Likewise.
10771 * window.h (struct window): Likewise.
10772 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
10773 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
10774 * buffer.c (init_buffer_once): Likewise.
10775 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
10776 special case.
10777 * process.c (Fformat_network_address): Use local var for size,
10778 for brevity.
10779
0df1eac5
PE
10780 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
10781
847ab9d1 10782 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
10783 * data.c (atof): Remove decl; no longer used or needed.
10784 (digit_to_number): Move to lread.c.
10785 (Fstring_to_number): Use new string_to_number function, to be
10786 consistent with how the Lisp reader treats infinities and NaNs.
10787 Do not assume that floating-point numbers represent EMACS_INT
10788 without losing information; this is not true on most 64-bit hosts.
10789 Avoid double-rounding errors, by insisting on integers when
10790 parsing non-base-10 numbers, as the documentation specifies.
10791 * lisp.h (string_to_number): New decl, replacing ...
10792 (isfloat_string): Remove.
bc0a5c13 10793 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 10794 (read1): Do not accept +. and -. as integers; this
452f4150
PE
10795 appears to have been a coding error. Similarly, do not accept
10796 strings like +-1e0 as floating point numbers. Do not report
10797 overflow for integer overflows unless the base is not 10 which
10798 means we have no simple and reliable way to continue.
10799 Break out the floating-point parsing into a new
10800 function string_to_number, so that Fstring_to_number parses
10801 floating point numbers consistently with the Lisp reader.
04f2d78b 10802 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
10803 (E_CHAR, EXP_INT): Remove, replacing with ...
10804 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
10805 (string_to_number): New function, replacing isfloat_string.
10806 This function checks for valid syntax and produces the resulting
10807 Lisp float number too. Rework it so that string-to-number
bc0a5c13 10808 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
10809 so that overflow for non-base-10 numbers is reported only when
10810 there's no portable and simple way to convert to floating point.
452f4150 10811
67769ffc
PE
10812 * textprop.c (set_text_properties_1): Rewrite for clarity,
10813 and to avoid GCC warning about integer overflow.
10814
c20db43f
PE
10815 * intervals.h (struct interval): Use EMACS_INT for members
10816 where EMACS_UINT might cause problems. See
10817 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
10818 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
10819 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
10820 All uses changed.
37aa2f85
PE
10821 (offset_intervals): Tell GCC not to worry about length overflow
10822 when negating a negative length.
c20db43f 10823
2538aa2f
PE
10824 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
10825 (overrun_check_free): Likewise.
10826
f2d3008d
PE
10827 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
10828 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
10829 word size.
10830
ec8df744
PE
10831 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10832 (gnutls_make_error): Rename local to avoid shadowing.
10833 (gnutls_emacs_global_deinit): ifdef out; not used.
10834 (Fgnutls_boot): Use const for pointer to readonly storage.
10835 Comment out unused local. Fix pointer signedness problems.
10836
640ee02d
PE
10837 * lread.c (openp): Don't stuff size_t into an 'int'.
10838 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
10839 about possible signed overflow.
10840
6048fb2a
PE
10841 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10842 (GDK_KEY_g): Don't define if already defined.
10843 (xg_prepare_tooltip): Avoid pointer signedness problem.
10844 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
10845
fa3c87e1
PE
10846 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
10847 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
10848
2172544b
PE
10849 * xfns.c (Fx_window_property): Simplify a bit,
10850 to make a bit faster and to avoid GCC 4.6.0 warning.
10851 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
10852
9b821a21
PE
10853 * fns.c (internal_equal): Don't assume size_t fits in int.
10854
3c616cfa
PE
10855 * alloc.c (compact_small_strings): Tighten assertion a little.
10856
c2982e87
PE
10857 Replace pEd with more-general pI, and fix some printf arg casts.
10858 * lisp.h (pI): New macro, generalizing old pEd macro to other
10859 conversion specifiers. For example, use "...%"pI"d..." rather
10860 than "...%"pEd"...".
10861 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 10862 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
10863 * alloc.c (check_pure_size): Don't overflow by converting size to int.
10864 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
10865 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
10866 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
10867 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
10868 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
10869 64-bit hosts.
10870 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
10871 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
10872 * print.c (safe_debug_print, print_object): Likewise.
10873 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
10874 to int.
6f04d126
PE
10875 Use pI instead of if-then-else-abort. Use %p to avoid casts,
10876 avoiding the 0 flag, which is not portable.
c2982e87
PE
10877 * process.c (Fmake_network_process): Use pI to avoid cast.
10878 * region-cache.c (pp_cache): Likewise.
10879 * xdisp.c (decode_mode_spec): Likewise.
10880 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
10881 behavior on 64-bit hosts with printf arg.
6f04d126 10882 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
10883 (x_stop_queuing_selection_requests): Likewise.
10884 (x_get_window_property): Don't truncate byte count to an 'int'
10885 when tracing.
0b432f21 10886
5e073ec7
PE
10887 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
10888 here, since it parses constructs like leading '-' and spaces,
10889 which are not wanted; and it overflows with large numbers.
10890 Instead, simply match F[0-9]+, which is what is wanted anyway.
10891
36372bf9
PE
10892 * alloc.c: Remove unportable assumptions about struct layout.
10893 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
10894 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
10895 (allocate_vectorlike, make_pure_vector): Use the new macros,
10896 plus offsetof, to remove unportable assumptions about struct layout.
10897 These assumptions hold on all porting targets that I know of, but
10898 they are not guaranteed, they're easy to remove, and removing them
10899 makes further changes easier.
10900
0b432f21
PE
10901 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
10902 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
10903 (string_overrun_cookie): Now const. Use initializers that
10904 don't formally overflow signed char, to avoid warnings.
000098c1
PE
10905 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
10906 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
10907 (allocate_buffer): Don't assume sizeof (struct buffer) is a
10908 multiple of sizeof (EMACS_INT); it need not be, if
10909 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 10910 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 10911
895009e1
JB
109122011-04-26 Juanma Barranquero <lekktu@gmail.com>
10913
10914 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
10915
6a7a1b0b
TZ
109162011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
10917
10918 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 10919 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
10920 Reported by Paul Eggert <eggert@cs.ucla.edu>.
10921
841a1577 109222011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
10923
10924 * lisp.h (Qdebug): List symbol.
895009e1 10925 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
10926 * keyboard.c (debug-on-event): New variable.
10927 (handle_user_signal): Break into debugger when debug-on-event
10928 matches the current signal symbol.
10929
f2d3ba6f
DN
109302011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
10931
10932 * alloc.c (check_sblock, check_string_bytes)
10933 (check_string_free_list): Convert to standard C.
10934
42ce4c63
TZ
109352011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
10936
10937 * w32.c (emacs_gnutls_push): Fix typo.
10938
825cd63c
EZ
109392011-04-25 Eli Zaretskii <eliz@gnu.org>
10940
fb11d64d
EZ
10941 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
10942 "cast to pointer from integer of different size".
10943
825cd63c
EZ
10944 Improve doprnt and its use in verror. (Bug#8545)
10945 * doprnt.c (doprnt): Document the set of format control sequences
10946 supported by the function. Use SAFE_ALLOCA instead of always
10947 using `alloca'.
10948
10949 * eval.c (verror): Don't limit the buffer size at size_max-1, that
10950 is one byte too soon. Don't use xrealloc; instead xfree and
10951 xmalloc anew.
10952
e061a11b
TZ
109532011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
10954
10955 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
10956 callbacks stage.
10957
10958 * gnutls.c: Renamed global_initialized to
10959 gnutls_global_initialized. Added internals for the
10960 :verify-hostname-error, :verify-error, and :verify-flags
10961 parameters of `gnutls-boot' and documented those parameters in the
10962 docstring. Start callback support.
9173deec
JB
10963 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
10964 unless a fatal error occurred. Call gnutls_alert_send_appropriate
10965 on error. Return error code.
e061a11b
TZ
10966 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
10967 (emacs_gnutls_read): Likewise.
10968 (Fgnutls_boot): Return handshake error code.
10969 (emacs_gnutls_handle_error): New function.
10970 (wsaerror_to_errno): Likewise.
10971
10972 * w32.h (emacs_gnutls_pull): Add prototype.
10973 (emacs_gnutls_push): Likewise.
10974
10975 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
10976 (emacs_gnutls_push): Likewise.
10977
109782011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
10979
10980 * process.c (wait_reading_process_output): Check if GnuTLS
10981 buffered some data internally if no FDs are set for TLS
10982 connections.
10983
10984 * makefile.w32-in (OBJ2): Add gnutls.$(O).
10985 (LIBS): Link to USER_LIBS.
10986 ($(BLD)/gnutls.$(0)): New target.
10987
fa6996bc
EZ
109882011-04-24 Eli Zaretskii <eliz@gnu.org>
10989
eb35682e
EZ
10990 * xdisp.c (handle_single_display_spec): Rename the
10991 display_replaced_before_p argument into display_replaced_p, to
10992 make it consistent with the commentary. Fix typos in the
10993 commentary.
10994
e2ad650c
EZ
10995 * textprop.c (syms_of_textprop): Remove dead code.
10996 (copy_text_properties): Delete obsolete commentary about an
10997 interface that was deleted long ago. Fix typos in the description
10998 of arguments.
10999
1b2de274
EZ
11000 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
11001 to changes in oldXMenu/XMenu.h from 2011-04-16.
11002 <menu_help_message, prev_menu_help_message>: Constify.
11003 (IT_menu_make_room): menu->help_text is now `const char **';
11004 adjust.
11005
11006 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
11007 to changes in oldXMenu/XMenu.h from 2011-04-16.
11008 (struct XMenu): Declare `help_text' `const char **'.
11009
11010 * xfaces.c <Qunspecified>: Make extern again.
11011
11012 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 11013 required by POSIX.
1b2de274 11014
762b15be
EZ
11015 * doc.c (get_doc_string): Improve the format passed to `error'.
11016
11017 * doprnt.c (doprnt): Improve commentary.
11018
11019 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
11020
11021 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
11022 them with etags.
11023
f1052e5d
EZ
11024 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
11025 changes in globals.h immediately force recompilation.
762b15be
EZ
11026 (TAGS): Depend on $(CURDIR)/m/intel386.h and
11027 $(CURDIR)/s/ms-w32.h.
11028 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 11029
fa6996bc
EZ
11030 * character.c (Fchar_direction): Function deleted.
11031 (syms_of_character): Don't defsubr it.
11032 <char-direction-table>: Deleted.
11033
e6c3da20
EZ
110342011-04-23 Eli Zaretskii <eliz@gnu.org>
11035
11036 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
11037 * doprnt.c: Include limits.h.
11038 (SIZE_MAX): New macro.
04f2d78b
CB
11039 (doprnt): Return a size_t value. 2nd arg is now size_t.
11040 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
11041 Improve overflow protection. Support `l' modifier for integer
11042 conversions. Support %l conversion. Don't assume an EMACS_INT
11043 argument for integer conversions and for %c.
11044
11045 * lisp.h (doprnt): Restore prototype.
11046
11047 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
11048 $(SRC)/character.h.
11049
11050 * Makefile.in (base_obj): Add back doprnt.o.
11051
11052 * deps.mk (doprnt.o): Add back prerequisites.
11053 (callint.o): Depend on character.h.
11054
11055 * eval.c (internal_lisp_condition_case): Include the handler
11056 representation in the error message.
11057 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
11058 when breaking from the loop.
11059
11060 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
11061
11062 * callint.c (Fcall_interactively): When displaying error message
11063 about invalid control letter, pass the character's codepoint, not
11064 a pointer to its multibyte form. Improve display of the character
11065 in octal and display also its hex code.
11066
11067 * character.c (char_string): Use %x to display the (unsigned)
11068 codepoint of an invalid character, to avoid displaying a bogus
11069 negative value.
11070
11071 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
11072 `error', not SYMBOL_NAME itself.
11073
11074 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
11075 character arguments to `error'.
11076
11077 * charset.c (check_iso_charset_parameter): Fix incorrect argument
11078 to `error' in error message about FINAL_CHAR argument. Make sure
11079 FINAL_CHAR is a character, and use %c when it is passed as
11080 argument to `error'.
11081
4ffd0d6b 110822011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
11083
11084 * s/ms-w32.h (localtime): Redirect to sys_localtime.
11085
11086 * w32.c: Include <time.h>.
11087 (sys_localtime): New function.
11088
4ffd0d6b 110892011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
11090
11091 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
11092
4ffd0d6b 11093 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 11094
4ffd0d6b 110952011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 11096
4ffd0d6b
GM
11097 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
11098 zombies (Bug#8467).
aac0c6e3 11099
04c56954
EZ
111002011-04-19 Eli Zaretskii <eliz@gnu.org>
11101
11102 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
11103 gl_state.e_property when gl_state.object is Qt.
11104
11105 * insdel.c (make_gap_larger): Remove limitation of buffer size
11106 to <= INT_MAX.
11107
16a43933
CY
111082011-04-18 Chong Yidong <cyd@stupidchicken.com>
11109
11110 * xdisp.c (lookup_glyphless_char_display)
11111 (produce_glyphless_glyph): Handle cons cell entry in
11112 glyphless-char-display.
11113 (Vglyphless_char_display): Document it.
11114
11115 * term.c (produce_glyphless_glyph): Handle cons cell entry in
11116 glyphless-char-display.
11117
4581706e
CY
111182011-04-17 Chong Yidong <cyd@stupidchicken.com>
11119
11120 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
11121
11122 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
11123
11124 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
11125 definition for no-X builds.
11126
4887c6e2 111272011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 11128
fd35b6f9
PE
11129 Static checks with GCC 4.6.0 and non-default toolkits.
11130
5c1ccb01
PE
11131 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
11132
006c5daa
PE
11133 * process.c (keyboard_bit_set): Define only if SIGIO.
11134 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
11135 (send_process): Repair possible setjmp clobbering.
11136
efc736d3
PE
11137 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
11138
4e2fe2e6
PE
11139 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
11140
f97334a2
PE
11141 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
11142
4e75f29d
PE
11143 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
11144 Define only if needed.
11145
90efadd1
PE
11146 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
11147 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 11148 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 11149
3c647824
PE
11150 * dispextern.h (struct redisplay_interface): Rename param
11151 to avoid shadowing.
e264f262 11152 * termhooks.h (struct terminal): Likewise.
761383f4 11153 * xterm.c (xembed_send_message): Likewise.
3c647824 11154
b58c5c4a
PE
11155 * insdel.c (make_gap_smaller): Define only if
11156 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
11157
cad59032
PE
11158 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
11159 it.
11160
c339dc2e
PE
11161 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
11162 so that we aren't warned about unused symbols.
11163
91a3e27b
PE
11164 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
11165
399c71d3 11166 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 11167
8ffc96f5
PE
11168 * xfns.c (x_real_positions): Mark locals as initialized.
11169
eef9bc79
PE
11170 * xmenu.c (xmenu_show): Don't use uninitialized vars.
11171
098db9dd
PE
11172 * xterm.c: Fix problems found by static analysis with other toolkits.
11173 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
11174 (x_dispatch_event): Declare static if USE_GTK, and
11175 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 11176 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 11177 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
11178 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
11179 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 11180
eb18f6cc
PE
11181 * xmenu.c (menu_help_callback): Pointer type fixes.
11182 Use const pointers when pointing at readonly data. Avoid pointer
11183 signedness clashes.
11184 (FALSE): Remove unused macro.
11185 (update_frame_menubar): Remove unused decl.
11186
1fe72bf8
PE
11187 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
11188
60d9e1db
PE
11189 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
11190 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
11191 (single_menu_item): Rename local to avoid shadowing.
11192
39261c26
PE
11193 * keyboard.c (make_lispy_event): Remove unused local var.
11194
018c5e19
PE
11195 * frame.c, frame.h (x_get_resource_string): Bring this back, but
11196 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
11197
63d2b86e
PE
11198 * bitmaps: Change bitmaps from unsigned char back to the X11
11199 compatible char. Avoid the old compiler warnings about
11200 out-of-range initializers by using, for example, '\xab' rather
11201 than 0xab.
11202
aefd87e1
PE
11203 * xgselect.c (xgselect_initialize): Check vs interface
11204 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
11205
bf501fb9
PE
11206 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
11207
e9829fdf
PE
11208 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
11209 to read-only memory.
11210
1086c095
PE
11211 * fns.c (vector): Remove; this old hack is no longer needed.
11212
2baccd04 11213 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 11214 Remove unused var.
dde42981 11215 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 11216
72391843 11217 * xrdb.c (x_load_resources): Omit unused local.
3565b346 11218
436c16df 11219 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 11220 (x_window): Rename locals to avoid shadowing.
dc5ddd85 11221 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 11222
92bb796d 11223 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 11224 (x_term_init): Remove local to avoid shadowing.
92bb796d 11225
764430a3 11226 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
11227
11228 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
11229 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
11230
d1dfb56c
EZ
112312011-04-16 Eli Zaretskii <eliz@gnu.org>
11232
c4354cb4
EZ
11233 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
11234
d1dfb56c
EZ
11235 Fix regex.c, syntax.c and friends for buffers > 2GB.
11236 * syntax.h (struct gl_state_s): Declare character position members
11237 EMACS_INT.
11238
11239 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
11240
04f2d78b
CB
11241 * textprop.c (verify_interval_modification, interval_of):
11242 Declare arguments EMACS_INT.
d1dfb56c
EZ
11243
11244 * intervals.c (adjust_intervals_for_insertion): Declare arguments
11245 EMACS_INT.
11246
11247 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
11248
11249 * indent.c (Fvertical_motion): Local variable it_start is now
11250 EMACS_INT.
11251
11252 * regex.c (re_match, re_match_2, re_match_2_internal)
11253 (bcmp_translate, regcomp, regexec, print_double_string)
11254 (group_in_compile_stack, re_search, re_search_2, regex_compile)
11255 (re_compile_pattern, re_exec): Declare arguments and local
11256 variables `size_t' and `ssize_t' and return values `regoff_t', as
11257 appropriate.
11258 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
11259 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
11260 <compile_stack_type>: `size' and `avail' are now `size_t'.
11261
11262 * regex.h <regoff_t>: Use ssize_t, not int.
11263 (re_search, re_search_2, re_match, re_match_2): Arguments that
11264 specify buffer/string position and length are now ssize_t and
11265 size_t. Return type is regoff_t.
11266
613052cd
BK
112672011-04-16 Ben Key <bkey76@gmail.com>
11268
11269 * nsfont.m: Fixed bugs in ns_get_family and
11270 ns_descriptor_to_entity that were caused by using free to
11271 deallocate memory blocks that were allocated by xmalloc (via
11272 xstrdup). This caused Emacs to crash when compiled with
11273 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
11274 --enable-checking=xmallocoverrun). xfree is now used to
11275 deallocate these memory blocks.
11276
4170f62f 112772011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 11278
71b41406
PE
11279 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
11280
9587a89d
PE
11281 emacs_write: Accept and return EMACS_INT for sizes.
11282 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
11283 et seq.
11284 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
11285 Accept and return EMACS_INT.
11286 (emacs_gnutls_write): Return the number of bytes written on
11287 partial writes.
11288 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
11289 (emacs_read, emacs_write): Remove check for negative size, as the
11290 Emacs source code has been audited now.
9587a89d
PE
11291 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
11292 (emacs_read, emacs_write): Use it.
273a5f82
PE
11293 * process.c (send_process): Adjust to the new signatures of
11294 emacs_write and emacs_gnutls_write. Do not attempt to store
11295 a byte offset into an 'int'; it might overflow.
9587a89d 11296 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 11297
3e047f51
PE
11298 * sound.c: Don't assume sizes fit in 'int'.
11299 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 11300 Return EMACS_INT, not int.
3e047f51 11301 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
11302 Accept EMACS_INT, not int.
11303 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
11304 record read return values.
11305
cc39a9db
BK
113062011-04-15 Ben Key <bkey76@gmail.com>
11307
c9d0ec6d
JB
11308 * keyboard.c (Qundefined): Don't declare static since it is used
11309 in nsfns.m.
11310 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
11311 static since they are used in nsfont.m.
cc39a9db 11312
6c60eb9f
SM
113132011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
11314
11315 * process.c (Qprocessp): Don't declare static.
11316 * lisp.h (Qprocessp): Declare again.
11317
7990b61a
JB
113182011-04-15 Juanma Barranquero <lekktu@gmail.com>
11319
11320 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
11321
5d4cb038
PE
113222011-04-14 Paul Eggert <eggert@cs.ucla.edu>
11323
8bd7b830 11324 Improve C-level modularity by making more things 'static'.
cd64ea1d 11325
e3b27b31
PE
11326 Don't publish debugger-only interfaces to other modules.
11327 * lisp.h (safe_debug_print, debug_output_compilation_hack):
11328 (verify_bytepos, count_markers): Move decls to the only modules
11329 that need them.
11330 * region-cache.h (pp_cache): Likewise.
11331 * window.h (check_all_windows): Likewise.
11332 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
11333
5d4cb038
PE
11334 * sysdep.c (croak): Now static, if
11335 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
11336 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
11337
11338 * alloc.c (refill_memory_reserve): Now static if
11339 !defined REL_ALLOC || defined SYSTEM_MALLOC.
11340 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 11341
e87b6180
PE
11342 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
11343 Define only if USE_LUCID.
11344
ac64929e
PE
11345 * xrdb.c (x_customization_string, x_rm_string): Now static.
11346
6f37259d
PE
11347 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
11348 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
11349
1683e3ab
PE
11350 * xdisp.c (draw_row_with_mouse_face): Now static.
11351 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
11352
de9c2632
PE
11353 * window.h (check_all_windows): Mark externally visible.
11354
2b96acb7
PE
11355 * window.c (window_deletion_count): Now static.
11356
11357 * undo.c: Make symbols static if they're not exported.
11358 (last_undo_buffer, last_boundary_position, pending_boundary):
11359 Now static.
11360
50436f33
PE
11361 * textprop.c (interval_insert_behind_hooks): Now static.
11362 (interval_insert_in_front_hooks): Likewise.
11363
64520e5c
PE
11364 * term.c: Make symbols static if they're not exported.
11365 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
11366 (max_frame_lines, tty_set_terminal_modes):
11367 (tty_reset_terminal_modes, tty_turn_off_highlight):
11368 (get_tty_terminal): Now static.
11369 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
11370 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 11371 HAVE_WINDOW_SYSTEM.
64520e5c
PE
11372 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
11373 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
11374
1fa53021
PE
11375 * sysdep.c: Make symbols static if they're not exported.
11376 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
11377 Now static.
11378 (sigprocmask_set, full_mask): Remove; unused.
11379 (wait_debugging): Mark as visible.
11380 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
11381 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
11382
d4b43b22
PE
11383 * syntax.c (syntax_temp): Define only if !__GNUC__.
11384
b7c513d0
PE
11385 * sound.c (current_sound_device, current_sound): Now static.
11386
989b29ad
PE
11387 * search.c (searchbufs, searchbuf_head): Now static.
11388
13a55a78
PE
11389 * scroll.c (scroll_cost): Remove; unused.
11390 * dispextern.h (scroll_cost): Remove decl.
11391
de68a1fc
PE
11392 * region-cache.h (pp_cache): Mark as externally visible.
11393
40ccffa6
PE
11394 * process.c: Make symbols static if they're not exported.
11395 (process_tick, update_tick, create_process, chan_process):
11396 (Vprocess_alist, proc_buffered_char, datagram_access):
11397 (fd_callback_data, send_process_frame, process_sent_to): Now static.
11398 (deactivate_process): Mark defn as static, as well as decl.
11399 * lisp.h (create_process): Remove decl.
11400 * process.h (chan_process, Vprocess_alist): Remove decls.
11401
ad64fc97
PE
11402 * print.c: Make symbols static if they're not exported.
11403 (print_depth, new_backquote_output, being_printed, print_buffer):
11404 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
11405 (print_interval, print_number_index, initial_stderr_stream):
11406 Now static.
11407 * lisp.h (Fprinc): Remove decl.
11408 (debug_output_compilation_hack): Mark as externally visible.
11409
adddb265
PE
11410 * sysdep.c (croak): Move decl from here to syssignal.h.
11411 * syssignal.h (croak): Put it here, so the API can be checked when
11412 'croak' is called from dissociate_if_controlling_tty.
11413
1717ede2
PE
11414 * minibuf.c: Make symbols static if they're not exported.
11415 (minibuf_save_list, choose_minibuf_frame): Now static.
11416 * lisp.h (choose_minibuf_frame): Remove decl.
11417
fa5fb2bc
PE
11418 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
11419
1e3890d1
PE
11420 * lread.c: Make symbols static if they're not exported.
11421 (read_objects, initial_obarray, oblookup_last_bucket_number):
11422 Now static.
11423 (make_symbol): Remove; unused.
11424 * lisp.h (initial_obarray, make_symbol): Remove decls.
11425
8a1414fa
PE
11426 * keyboard.c: Make symbols static if they're not exported.
11427 (single_kboard, recent_keys_index, total_keys, recent_keys):
11428 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
11429 (this_single_command_key_start, echoing, last_auto_save):
11430 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
11431 (command_loop, echo_now, keyboard_init_hook, help_char_p):
11432 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
11433 (Vlispy_mouse_stem, double_click_count):
11434 Now static.
11435 (force_auto_save_soon): Define only if SIGDANGER.
11436 (ignore_mouse_drag_p): Now static if
11437 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
11438 (print_help): Remove; unused.
11439 (stop_character, last_timer_event): Mark as externally visible.
11440 * keyboard.h (ignore_mouse_drag_p): Declare only if
11441 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
11442 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
11443 * lisp.h (echoing): Remove decl.
11444 (force_auto_save_soon): Declare only if SIGDANGER.
11445 * xdisp.c (redisplay_window): Simplify code, to make it more
11446 obvious that ignore_mouse_drag_p is not accessed if !defined
11447 USE_GTK && !defined HAVE_NS.
11448
93ea6e8f
PE
11449 * intervals.c: Make symbols static if they're not exported.
11450 (merge_properties_sticky, merge_interval_right, delete_interval):
11451 Now static.
11452 * intervals.h (merge_interval_right, delete_interval): Remove decls.
11453
77382fcc
PE
11454 * insdel.c: Make symbols static if they're not exported.
11455 However, leave prepare_to_modify_buffer alone. It's never
11456 called from outside this function, but that appears to be a bug.
11457 (combine_after_change_list, combine_after_change_buffer):
4889fc82 11458 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
11459 (adjust_after_replace_noundo): Remove; unused.
11460 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 11461 (signal_before_change): Remove decls.
77382fcc 11462
9306c32e
PE
11463 * indent.c (val_compute_motion, val_vmotion): Now static.
11464
cd44d2eb
PE
11465 * image.c: Make symbols static if they're not exported.
11466 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
11467 if USE_GTK.
11468 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
11469 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
11470
ad9a7a06
PE
11471 * fringe.c (standard_bitmaps): Now static.
11472 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
11473
81626931
PE
11474 * frame.c: Make symbols static if they're not exported.
11475 (x_report_frame_params, make_terminal_frame): Now static.
11476 (get_frame_param): Now static, unless HAVE_NS.
11477 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
11478 (x_get_resource_string): Remove; not used.
11479 * frame.h (make_terminal_frame, x_report_frame_params):
11480 (x_get_resource_string); Remove decls.
11481 (x_fullscreen_adjust): Declare only if WINDOWSNT.
11482 * lisp.h (get_frame_param): Declare only if HAVE_NS.
11483
239f9db9
PE
11484 * font.c, fontset.c: Make symbols static if they're not exported.
11485 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
11486 (FACE_SUITABLE_FOR_CHAR_P): Use it.
11487 * font.c (font_close_object): Now static.
11488 * font.h (font_close_object): Remove.
11489 * fontset.c (FONTSET_OBJLIST): Remove.
11490 (free_realized_fontset) #if-0 the body, which does nothing.
11491 (face_suitable_for_char_p): #if-0, as it's never called.
11492 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
11493 * xfaces.c (face_at_string_position):
11494 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
11495 since 0 is always ASCII.
11496
dfcf3579
PE
11497 * fns.c (weak_hash_tables): Now static.
11498
5045092b
PE
11499 * fileio.c: Make symbols static if they're not exported.
11500 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
11501 (Vwrite_region_annotation_buffers): Now static.
11502
57a96f5c
PE
11503 * eval.c: Make symbols static if they're not exported.
11504 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
11505 * lisp.h (backtrace_list): Remove decl.
11506
35f08c38
PE
11507 * emacs.c: Make symbols static if they're not exported.
11508 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
11509 (fatal_error_code, fatal_error_signal_hook, standard_args):
11510 Now static.
11511 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
11512 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
11513 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
11514 * lisp.h (fatal_error_signal_hook): Remove decl.
11515 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
11516
f44bd759
PE
11517 * editfns.c: Move a (normally-unused) function to its only use.
11518 * editfns.c, lisp.h (get_operating_system_release): Remove.
11519 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
11520 worth the hassle of breaking this out.
11521
b532497d
PE
11522 * xterm.c: Make symbols static if they're not exported.
11523 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
11524 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
11525 (x_destroy_window, x_delete_display):
11526 Now static.
11527 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
11528 (x_mouse_leave): Remove; unused.
11529 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
11530 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
11531 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
11532 Remove decls.
11533 (x_mouse_leave): Declare only if WINDOWSNT.
11534 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
11535 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
11536 USE_X_TOOLKIT.
11537
1675728f
PE
11538 * ftxfont.c: Make symbols static if they're not exported.
11539 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
11540 HAVE_FREETYPE.
11541 * font.h (ftxfont_driver): Likewise.
11542
e4cebfca
PE
11543 * xfns.c: Make symbols static if they're not exported.
11544 (x_last_font_name, x_display_info_for_name):
11545 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
11546 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
11547 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
11548 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
11549 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
11550 (last_show_tip_args): Now static.
11551 (xic_defaut_fontset, xic_create_fontsetname): Define only if
11552 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
11553 (x_screen_planes): Remove; unused.
11554 * dispextern.h (x_screen_planes): Remove decl.
11555
5bf46f05
PE
11556 * dispnew.c: Make symbols static if they're not exported.
11557 * dispextern.h (redraw_garbaged_frames, scrolling):
11558 (increment_row_positions): Remove.
11559 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
11560 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
11561 Now static.
11562 (redraw_garbaged_frames): Remove; unused.
11563
435f4c28
PE
11564 * xfaces.c: Make symbols static if they're not exported.
11565 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
11566 Remove decls.
11567 * xterm.h (defined_color): Remove decls.
11568 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
11569 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
11570 (menu_face_changed_default, defined_color, free_realized_face):
11571 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
11572 (ascii_face_of_lisp_face): Remove; unused.
11573
8524aef3
PE
11574 * xdisp.c: Make symbols static if they're not exported.
11575 * dispextern.h (scratch_glyph_row, window_box_edges):
11576 (glyph_to_pixel_coords, set_cursor_from_row):
11577 (get_next_display_element, set_iterator_to_next):
11578 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
11579 (show_mouse_face): Remove decls
11580 * frame.h (message_buf_print): Likewise.
11581 * lisp.h (pop_message, set_message, check_point_in_composition):
11582 Likewise.
11583 * xterm.h (set_vertical_scroll_bar): Likewise.
11584 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
11585 (message_buf_print, scratch_glyph_row, displayed_buffer):
11586 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
11587 (get_next_display_element, show_mouse_face, window_box_edges):
11588 (frame_to_window_pixel_xy, check_point_in_composition):
11589 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
11590 (glyph_to_pixel_coords): Remove; unused.
11591
16390cd2
PE
11592 * dired.c (file_name_completion): Now static.
11593
11594 * dbusbind.c (xd_in_read_queued_messages): Now static.
11595
a25f4dfa
PE
11596 * lisp.h (circular_list_error, FOREACH): Remove; unused.
11597 * data.c (circular_list_error): Remove.
11598
14a9c8df
PE
11599 * commands.h (last_point_position, last_point_position_buffer):
11600 (last_point_position_window): Remove decls.
11601 * keyboard.c: Make these variables static.
11602
04f2d78b
CB
11603 * coding.h (coding, code_convert_region, encode_coding_gap):
11604 Remove decls.
74ab6df5
PE
11605 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
11606 (iso_code_class, detect_coding, code_convert_region): Now static.
11607 (encode_coding_gap): Remove; unused.
11608
38dfbee1
PE
11609 * chartab.c (chartab_chars, chartab_bits): Now static.
11610
a2cb4e63
PE
11611 * charset.h (charset_iso_8859_1): Remove decl.
11612 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
11613 Now static.
11614
127198fd
PE
11615 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
11616 * ccl.c (Vccl_program_table): Now static.
11617 (check_ccl_update): Remove; unused.
11618
d85b608f
PE
11619 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
11620 * category.h: ... from here.
11621 * category.c (check_category_table, set_category_set): Now static.
11622
31cd66f3
PE
11623 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
11624 * lisp.h: Remove these decls.
11625
c358e587
PE
11626 * buffer.c (buffer_count): Remove unused var.
11627
e78aecca
PE
11628 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
11629 so that it's not optimized away.
11630 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
11631 * dispextern.h (bidi_dump_cached_states): Remove, since it's
11632 exported only to the debugger.
11633
e192d7d3 11634 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 11635 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 11636
92470028
PE
11637 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
11638 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
11639 was inaccessible from Lisp.
11640 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
11641 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
11642
244ed907
PE
11643 alloc.c: Import and export fewer symbols, and remove unused items.
11644 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
11645 is defined.
11646 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
11647 it's not optimized away by whole-program optimization.
11648 (message_enable_multibyte, free_misc): Remove.
11649 (catchlist, handlerlist, mark_backtrace):
11650 Declare only if BYTE_MARK_STACK.
11651 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
11652 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
11653 (message_enable_multibyte): Remove decl.
11654 (free_misc, interval_free_list, float_block, float_block_index):
11655 (n_float_blocks, float_free_list, cons_block, cons_block_index):
11656 (cons_free_list, last_marked_index):
11657 Now static.
11658 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
11659 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
11660 (mark_backtrace): Define only if BYTE_MARK_STACK.
11661 * xdisp.c (message_enable_multibyte): Now static.
11662
61c2b50e 11663 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
11664 This makes it easier for human readers (and static analyzers)
11665 to see whether these variables are used from other modules.
11666 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
11667 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
11668 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
11669 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
11670 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
11671 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
11672 * xmenu.c, xselect.c:
11673 Declare Q* vars static if they are not used in other modules.
11674 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
11675 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
11676 Remove decls of unexported vars.
11677 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
11678
95c82688
PE
11679 * lisp.h (DEFINE_FUNC): Make sname 'static'.
11680
16a97296
PE
11681 Make Emacs functions such as Fatom 'static' by default.
11682 This makes it easier for human readers (and static analyzers)
11683 to see whether these functions can be called from other modules.
11684 DEFUN now defines a static function. To make the function external
11685 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
11686 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
11687 (Finit_image_library):
16a97296
PE
11688 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
11689 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
11690 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
11691 Remove decls, since these functions are now static.
11692 (Funintern, Fget_internal_run_time): New decls, since these functions
11693 were already external.
95c82688 11694
16a97296
PE
11695 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
11696 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
11697 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
11698 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
11699 * keyboard.c, keymap.c, lread.c:
11700 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
11701 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
11702 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
11703 Mark functions with DEFUE instead of DEFUN,
11704 if they are used in other modules.
11705 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
11706 decls for now-static functions.
11707 * buffer.h (Fdelete_overlay): Remove decl.
11708 * callproc.c (Fgetenv_internal): Mark as internal.
11709 * composite.c (Fremove_list_of_text_properties): Remove decl.
11710 (Fcomposition_get_gstring): New forward static decl.
11711 * composite.h (Fcomposite_get_gstring): Remove decl.
11712 * dired.c (Ffile_attributes): New forward static decl.
11713 * doc.c (Fdocumntation_property): New forward static decl.
11714 * eval.c (Ffetch_bytecode): New forward static decl.
11715 (Funintern): Remove extern decl; now in .h file where it belongs.
11716 * fileio.c (Fmake_symbolic_link): New forward static decl.
11717 * image.c (Finit_image_library): New forward static decl.
11718 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
11719 * intervals.h (Fprevious_property_change):
11720 (Fremove_list_of_text_properties): Remove decls.
11721 * keyboard.c (Fthis_command_keys): Remove decl.
11722 (Fcommand_execute): New forward static decl.
11723 * keymap.c (Flookup_key): New forward static decl.
11724 (Fcopy_keymap): Now static.
11725 * keymap.h (Flookup_key): Remove decl.
11726 * process.c (Fget_process): New forward static decl.
11727 (Fprocess_datagram_address): Mark as internal.
11728 * syntax.c (Fsyntax_table_p): New forward static decl.
11729 (skip_chars): Remove duplicate decl.
11730 * textprop.c (Fprevious_property_change): New forward static decl.
11731 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
11732 Now internal.
11733 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
11734 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
11735
785bbd42
PE
11736 * editfns.c (Fformat): Remove unreachable code.
11737
8b913b57
AS
117382011-04-14 Andreas Schwab <schwab@linux-m68k.org>
11739
11740 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
11741 change. (Bug#8496)
11742
a6744a35
EZ
117432011-04-13 Eli Zaretskii <eliz@gnu.org>
11744
11745 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
11746 when at ZV. (Bug#8487)
11747
e7974947
AS
117482011-04-12 Andreas Schwab <schwab@linux-m68k.org>
11749
baad03f0
AS
11750 * charset.c (Fclear_charset_maps): Use xfree instead of free.
11751 (Bug#8437)
11752 * keyboard.c (parse_tool_bar_item): Likewise.
11753 * sound.c (sound_cleanup, alsa_close): Likewise.
11754 * termcap.c (tgetent): Likewise.
11755 * xfns.c (x_default_font_parameter): Likewise.
11756 * xsettings.c (read_and_apply_settings): Likewise.
11757
e7974947
AS
11758 * alloc.c (overrun_check_malloc, overrun_check_realloc)
11759 (overrun_check_free): Protoize.
11760
28272684
PE
117612011-04-12 Paul Eggert <eggert@cs.ucla.edu>
11762
11763 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
11764 since callers should never pass a negative size.
11765 Change the signature to match that of plain 'read' and 'write'; see
11766 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
11767 * lisp.h: Update prototypes of emacs_write and emacs_read.
11768
11997c76
EZ
117692011-04-11 Eli Zaretskii <eliz@gnu.org>
11770
11771 * xdisp.c (redisplay_window): Don't try to determine the character
11772 position of the scroll margin if the window start point w->startp
e896f03c 11773 is outside the buffer's accessible region. (Bug#8468)
11997c76 11774
8a2cbd72
EZ
117752011-04-10 Eli Zaretskii <eliz@gnu.org>
11776
11777 Fix write-region and its subroutines for buffers > 2GB.
11778 * fileio.c (a_write, e_write): Modify declaration of arguments and
11779 local variables to support buffers larger than 2GB.
11780 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
11781
11782 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
11783 argument, local variables, and return value.
11784
11785 * lisp.h: Update prototypes of emacs_write and emacs_read.
11786
11787 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
11788
4073e537 117892011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 11790
1ebfdcb6
PE
11791 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
11792
b2ded58d
PE
11793 Fix more problems found by GCC 4.6.0's static checks.
11794
7d66342c
PE
11795 * xdisp.c (vmessage): Use a better test for character truncation.
11796
bbf47d44
PE
11797 * charset.c (load_charset_map): <, not <=, for optimization,
11798 and to avoid potential problems with integer overflow.
9248994d 11799 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 11800 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 11801 * editfns.c (Fformat): Likewise.
1e69125e 11802 * syntax.c (skip_chars): Likewise.
3befa583 11803
e3019616
PE
11804 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
11805 This also lets GCC 4.6.0 generate slightly better loop code.
11806
becfa255
PE
11807 * callint.c (Fcall_interactively): <, not <=, for optimization.
11808 (Fcall_interactively): Count the number of arguments produced,
11809 not the number of arguments given. This is simpler and lets GCC
11810 4.6.0 generate slightly better code.
11811
dae0cd48
PE
11812 * ftfont.c: Distingish more carefully between FcChar8 and char.
11813 The previous code passed unsigned char * to a functions like
11814 strlen and xstrcasecmp that expect char *, which does not
11815 conform to the C standard.
11816 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
11817 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
11818 char * when the C standard requires it.
11819
76032d70
PE
11820 * keyboard.c (read_char): Remove unused var.
11821
eb3f1cc8
PE
11822 * eval.c: Port to Windows vsnprintf (Bug#8435).
11823 Include <limits.h>.
11824 (SIZE_MAX): Define if the headers do not.
11825 (verror): Do not give up if vsnprintf returns a negative count.
11826 Instead, grow the buffer. This ports to Windows vsnprintf, which
11827 does not conform to C99. Problem reported by Eli Zaretskii.
11828 Also, simplify the allocation scheme, by avoiding the need for
11829 calling realloc, and removing the ALLOCATED variable.
11830
70476b54
PE
11831 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
11832
12020a9e
PE
11833 Remove invocations of doprnt, as Emacs now uses vsnprintf.
11834 But keep the doprint source code for now, as we might revamp it
11835 and use it again (Bug#8435).
ea6c7ae6
PE
11836 * lisp.h (doprnt): Remove.
11837 * Makefile.in (base_obj): Remove doprnt.o.
11838 * deps.mk (doprnt.o): Remove.
11839
5fdb398c
PE
11840 error: Print 32- and 64-bit integers portably (Bug#8435).
11841 Without this change, on typical 64-bit hosts error ("...%d...", N)
11842 was used to print both 32- and 64-bit integers N, which relied on
11843 undefined behavior.
61bdb816 11844 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
11845 * lisp.h (error, verror): Mark as printf-like functions.
11846 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
11847 Report overflow in size calculations when allocating printf buffer.
11848 Do not truncate output string at its first null byte.
11849 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
11850 Truncate the output at a character boundary, since vsnprintf does not
11851 do that.
11852 * charset.c (check_iso_charset_parameter): Convert internal
11853 character to string before calling 'error', since %c now has the
11854 printf meaning.
11855 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
11856 overflow when computing char to be passed to 'error'. Do not
11857 pass Lisp_Object to 'error'; pass the integer instead.
11858 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
11859 formatted with plain %d.
11860
b189fa66
PE
11861 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
11862
bff87ef0
PE
11863 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
11864
7e2cac20
PE
11865 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
11866
ce4d90b5
PE
11867 * xterm.c (x_catch_errors): Remove duplicate declaration.
11868
266c9547
PE
11869 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
11870
79c49ad2
PE
11871 * xdisp.c, lisp.h (message_nolog): Remove; unused.
11872
368f4090
JM
118732011-04-10 Jim Meyering <meyering@redhat.com>
11874
11875 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
11876 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
11877 return ssize_t not "int", and use size_t as the buffer length.
11878 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
11879 * gnutls.h: Update declarations.
11880 * process.c (read_process_output): Use ssize_t, to match.
11881 (send_process): Likewise.
11882
a32d4040
CY
118832011-04-09 Chong Yidong <cyd@stupidchicken.com>
11884
11885 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
11886
8546720e 118872011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 11888
04f2d78b
CB
11889 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
11890 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 11891
8546720e
GM
11892 * xterm.c (handle_one_xevent):
11893 * xmenu.c (create_and_show_popup_menu):
11894 * xselect.c (x_decline_selection_request)
11895 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 11896
0a2f5c1a 118972011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
11898
11899 Fix some uses of `int' instead of EMACS_INT.
11900 * search.c (string_match_1, fast_string_match)
11901 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
11902 (scan_buffer, find_next_newline_no_quit)
11903 (find_before_next_newline, search_command, Freplace_match)
11904 (Fmatch_data): Make some `int' variables be EMACS_INT.
11905
11906 * xdisp.c (display_count_lines): 3rd argument and return value now
11907 EMACS_INT. All callers changed.
11908 (pint2hrstr): Last argument is now EMACS_INT.
11909
11910 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
11911 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
11912 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
11913 (decode_coding_utf_16, decode_coding_emacs_mule)
11914 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
11915 (decode_coding_ccl, decode_coding_charset)
11916 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
11917 (decode_coding_iso_2022, decode_coding_emacs_mule)
11918 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
11919 <char_offset, last_offset>: Declare EMACS_INT.
11920 (encode_coding_utf_8, encode_coding_utf_16)
11921 (encode_coding_emacs_mule, encode_invocation_designation)
11922 (encode_designation_at_bol, encode_coding_iso_2022)
11923 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
11924 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
11925 Declare EMACS_INT.
11926 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
11927 (encode_invocation_designation): Last argument P_NCHARS is now
11928 EMACS_INT.
11929 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
11930 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
11931
11932 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
11933 All users changed.
11934
11935 * ccl.c (Fccl_execute_on_string): Declare some variables
11936 EMACS_INT.
11937
8546720e 119382011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
11939
11940 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
11941
4e19a977
CS
119422011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
11943
11944 * process.c (Fformat_network_address): Doc fix.
11945
87302331
R
119462011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
11947
ee7683eb 11948 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 11949
cbb59342
CY
119502011-04-08 Chong Yidong <cyd@stupidchicken.com>
11951
11952 * keyboard.c (read_char): Call Lisp function help-form-show,
11953 instead of using internal_with_output_to_temp_buffer.
11954 (Qhelp_form_show): New var.
e0d38eeb 11955 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
11956
11957 * print.c (internal_with_output_to_temp_buffer): Function deleted.
11958
11959 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
11960
e67a13ab
CY
119612011-04-06 Chong Yidong <cyd@stupidchicken.com>
11962
04f2d78b
CB
11963 * process.c (Flist_processes): Remove to Lisp.
11964 (list_processes_1): Delete.
e67a13ab 11965
973f782d
EZ
119662011-04-06 Eli Zaretskii <eliz@gnu.org>
11967
7c106b1e
EZ
11968 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
11969
973f782d
EZ
11970 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
11971
41cf7d1a 119722011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 11973
ca23cc88
PE
11974 Fix more problems found by GCC 4.6.0's static checks.
11975
f390e2d5
PE
11976 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
11977
42eea0d0
PE
11978 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
11979
b69769da 11980 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 11981
f9541e84
PE
11982 * xdisp.c (vmessage): Mark as a printf-like function.
11983
13841b55
PE
11984 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
11985
c136c10f
PE
11986 * sound.c (sound_warning): Don't crash if arg contains a printf format.
11987
5e2d4a30
PE
11988 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
11989 printf-like functions.
11990 (tiff_load): Add casts to remove these marks before passing them
11991 to system-supplied API.
11992
583f48b9
PE
11993 * eval.c (Fsignal): Remove excess argument to 'fatal'.
11994
b25d760e
PE
11995 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
11996 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
11997 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
11998 directly, rather than having caller test rule sign. This avoids
11999 some unnecessary tests.
12000 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
12001 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
12002 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 12003
bc7b6697 12004 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 12005 (xfont_open): Avoid unnecessary tests.
bc7b6697 12006
27ccc379
PE
12007 * composite.c (composition_gstring_put_cache): Use unsigned integer.
12008
dcd5c89a
PE
12009 * composite.h, composite.c (composition_gstring_put_cache):
12010 Use EMACS_INT, not int, for length.
12011
b13a45c6
PE
12012 * composite.h (COMPOSITION_DECODE_REFS): New macro,
12013 breaking out part of COMPOSITION_DECODE_RULE.
12014 (COMPOSITION_DECODE_RULE): Use it.
12015 * composite.c (get_composition_id): Remove unused local vars,
12016 by using the new macro.
12017
1e792e4d
PE
12018 * textprop.c (set_text_properties_1): Change while to do-while,
12019 since the condition is always true at first.
12020
dc6c6455 12021 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
12022 (interval_deletion_adjustment): Return unsigned value.
12023 All uses changed.
dc6c6455 12024
aba7731a
PE
12025 * process.c (list_processes_1, create_pty, read_process_output):
12026 (exec_sentinel): Remove vars that were set but not used.
afd4052b 12027 (create_pty): Remove unnecessary "volatile"s.
bc57d757 12028 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 12029 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 12030 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 12031
fdfc4bf3
PE
12032 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
12033
fca8fe46 12034 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 12035 (update_syntax_table): Use unsigned instead of int.
fca8fe46 12036
06a0259a 12037 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 12038 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 12039 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 12040
e7b9e80f
PE
12041 * print.c (print_error_message): Avoid int overflow.
12042
56201685
PE
12043 * font.c (font_list_entities): Redo for clarity,
12044 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
12045
78834453 12046 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 12047 (font_score): Avoid potential overflow in diff calculation.
78834453 12048
0bc0b309 12049 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 12050 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 12051
e610eaca
PE
12052 * eval.c (funcall_lambda): Rename local to avoid shadowing.
12053
b895abce
PE
12054 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
12055 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
12056 can always succeed if overflow has undefined behavior.
12057
1f1d9321 12058 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 12059 (wordify): Omit three unnecessary tests.
1f1d9321 12060
c59478bc
PE
12061 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
12062 All callers changed. This avoids the need for an unused var.
12063
79b73827
PE
12064 * casefiddle.c (casify_region): Remove var that is set but not used.
12065
a4db5dfe
PE
12066 * dired.c (file_name_completion): Remove var that is set but not used.
12067
43aae36e
PE
12068 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
12069
2a47c44d 12070 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 12071 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 12072
a37c69bf
PE
12073 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
12074 Check for integer overflow on size calculations.
12075
328ab8e7
PE
12076 * buffer.c (Fprevious_overlay_change): Remove var that is set
12077 but not used.
12078
e5a2a5cb
PE
12079 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
12080 Remove vars that are set but not used.
8d84a6eb 12081 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 12082 (timer_check_2): Mark vars as initialized.
e5a2a5cb 12083
a60e5f68
PE
12084 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
12085
f661cb61 12086 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 12087 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 12088
f0397f5a
PE
12089 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
12090 that are set but not used.
12091
8664db06 12092 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 12093 if XCreateBitmapFromData fails (Bug#8410).
8664db06 12094
6abdaa4a
PE
12095 * xselect.c (x_get_local_selection, x_handle_property_notify):
12096 Remove vars that are set but not used.
12097
0ce7538d 12098 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 12099 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 12100
9ae848fc
PE
12101 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
12102 Remove var that is set but not used.
0b918413
PE
12103 (scroll_bar_windows_size): Now size_t, not int.
12104 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
12105 Check for overflow.
9ae848fc 12106
a5a62657
PE
12107 * xfaces.c (realize_named_face): Remove vars that are set but not used.
12108 (map_tty_color) [!defined MSDOS]: Likewise.
12109
5c5cdd39
PE
12110 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
12111
66ebf983
PE
12112 * coding.c: Remove vars that are set but not used.
12113 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
12114 All callers changed.
12115 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
12116 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
12117 (decode_coding_charset): Remove vars that are set but not used.
12118
1be4d761
PE
12119 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
12120 that is set but not used.
12121
47553fa8
PE
12122 * print.c (print_object): Remove var that is set but not used.
12123
1f7196bf 12124 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
12125 The gnulib version avoids calling malloc in the usual case,
12126 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
12127 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
12128 * filelock.c (current_lock_owner): Likewise.
12129 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
12130 * sysdep.c: Include allocator.h, careadlinkat.h.
12131 (emacs_no_realloc_allocator): New static constant.
12132 (emacs_readlink): New function.
fdb61804
PE
12133 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
12134 ../lib/careadlinkat.h.
d1fdcab7 12135
f84c17c7
SM
121362011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
12137
12138 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
12139 first non-nil return value).
12140
ef3862ad
JD
121412011-04-03 Jan Djärv <jan.h.d@swipnet.se>
12142
12143 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
12144 if not defined (Bug#8403).
12145
376a7006
JB
121462011-04-02 Juanma Barranquero <lekktu@gmail.com>
12147
12148 * xdisp.c (display_count_lines): Remove parameter `start',
12149 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12150 (get_char_face_and_encoding): Remove parameter `multibyte_p',
12151 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12152 (fill_stretch_glyph_string): Remove parameters `row' and `area',
12153 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
12154 and thereabouts. All callers changed.
12155 (get_per_char_metric): Remove parameter `f', unused since
12156 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12157
6ca3801d
JM
121582011-04-02 Jim Meyering <meyering@redhat.com>
12159
12160 do not dereference NULL upon failed strdup
12161 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
12162 (ns_get_family): Likewise.
12163
d8e2b5ba
JB
121642011-04-02 Juanma Barranquero <lekktu@gmail.com>
12165
12166 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
12167
8c74fcbd
JD
121682011-04-02 Jan Djärv <jan.h.d@swipnet.se>
12169
12170 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
12171 later (Bug#8403).
12172
7200d79c
SM
121732011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
12174
03408648 12175 Add lexical binding.
7200d79c 12176
03408648
SM
12177 * window.c (Ftemp_output_buffer_show): New fun.
12178 (Fsave_window_excursion):
12179 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
12180
12181 * lread.c (lisp_file_lexically_bound_p): New function.
12182 (Fload): Bind Qlexical_binding.
12183 (readevalloop): Remove `evalfun' arg.
12184 Bind Qinternal_interpreter_environment.
12185 (Feval_buffer): Bind Qlexical_binding.
12186 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
12187 Mark as dynamic.
12188 (syms_of_lread): Declare `lexical-binding'.
12189
12190 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
12191
12192 * keyboard.c (eval_dyn): New fun.
12193 (menu_item_eval_property): Use it.
ca105506
SM
12194
12195 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 12196
03408648
SM
12197 * fns.c (concat, mapcar1): Accept byte-code-functions.
12198
12199 * eval.c (Fsetq): Handle lexical vars.
12200 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
12201 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
12202 (FletX, Flet): Obey lexical binding.
12203 (Fcommandp): Handle closures.
12204 (Feval): New `lexical' arg.
12205 (eval_sub): New function extracted from Feval. Use it almost
12206 everywhere where Feval was used. Look up vars in lexical env.
12207 Handle closures.
12208 (Ffunctionp): Move from subr.el.
12209 (Ffuncall): Handle closures.
12210 (apply_lambda): Remove `eval_flags'.
12211 (funcall_lambda): Handle closures and new byte-code-functions.
12212 (Fspecial_variable_p): New function.
12213 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
12214 but without exporting it to Lisp.
23aba0ea 12215
23aba0ea 12216 * doc.c (Fdocumentation, store_function_docstring):
03408648 12217 * data.c (Finteractive_form): Handle closures.
23aba0ea 12218
03408648
SM
12219 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
12220 interactive spec.
ba83908c 12221
04f2d78b
CB
12222 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
12223 New byte-codes.
03408648
SM
12224 (exec_byte_code): New function extracted from Fbyte_code to handle new
12225 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 12226
03408648 12227 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 12228
03408648 12229 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 12230
e2abce01
JB
122312011-03-31 Juanma Barranquero <lekktu@gmail.com>
12232
12233 * xdisp.c (redisplay_internal): Fix prototype.
12234
63696a73 122352011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 12236
63696a73 12237 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
12238 (try_scrolling): Use it when setting scroll_limit.
12239 Limit scrolling to 100 screen lines.
63696a73
EZ
12240 (redisplay_window): Even when falling back on "recentering",
12241 position point in the window according to scroll-conservatively,
12242 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
12243
12244 (try_scrolling): When point is above the window, allow searching
12245 as far as scroll_max, or one screenful, to compute vertical
12246 distance from PT to the scroll margin position. This prevents
12247 try_scrolling from unnecessarily failing when
12248 scroll-conservatively is set to a value slightly larger than the
12249 window height. Clean up the case of PT below the margin at bottom
12250 of window: scroll_max can no longer be INT_MAX. When aggressive
12251 scrolling is in use, don't let point enter the opposite scroll
12252 margin as result of the scroll.
12253 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
12254 threshold of 100 lines for never-recentering scrolling.
12255
e4cc2dfc
JB
122562011-03-31 Juanma Barranquero <lekktu@gmail.com>
12257
12258 * dispextern.h (move_it_by_lines):
12259 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
12260 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
12261 (message_log_check_duplicate): Remove parameters `prev_bol' and
12262 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12263 (redisplay_internal): Remove parameter `preserve_echo_area',
12264 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
12265
12266 * indent.c (Fvertical_motion):
12267 * window.c (window_scroll_pixel_based, Frecenter):
12268 Don't pass `need_y_p' to `move_it_by_lines'.
12269
1c470562
SM
122702011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
12271
44f230aa
SM
12272 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
12273 steal a few bits to be more compact.
12274 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
12275 Remove unneeded casts.
12276
1c470562
SM
12277 * bytecode.c (Fbyte_code): CAR and CDR can GC.
12278
888adce9
ZK
122792011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
12280
12281 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
12282 binding" message (bug#7967).
12283
f838ed7b
PE
122842011-03-30 Paul Eggert <eggert@cs.ucla.edu>
12285
77861b95
PE
12286 Fix more problems found by GCC 4.6.0's static checks.
12287
de6dbc14
PE
12288 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
12289 Remove unused local var.
12290
f838ed7b
PE
12291 * editfns.c (Fmessage_box): Remove unused local var.
12292
792c7b2b
PE
12293 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
12294 (note_mode_line_or_margin_highlight, note_mouse_highlight):
12295 Omit unused local vars.
c499e557 12296 * window.c (shrink_windows): Omit unused local var.
b01a1c29 12297 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
12298 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
12299 Omit unused local var.
12300
ba0165e1
PE
12301 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
12302 Don't assume string length fits in int.
32ad8845 12303 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 12304 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 12305
3c59b4c9
PE
12306 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
12307 instead of alloca (Bug#8344).
12308
a3eed478 12309 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 12310 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 12311
eb4d412d
PE
12312 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
12313
1658b401
PE
12314 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
12315 concerns.
12316
12317 * term.c (produce_glyphless_glyph): Remove unnecessary test.
12318
12319 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 12320
9a2c6e05
PE
12321 * keyboard.c (syms_of_keyboard): Use the same style as later
12322 in this function when indexing through an array. This also
12323 works around GCC bug 48267.
12324
03d0a109
PE
12325 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
12326
44f730c8
PE
12327 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
12328
fe75f926
PE
12329 * chartab.c (sub_char_table_ref_and_range): Redo for slight
12330 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
12331
ffa8c828
PE
12332 * keyboard.c, keyboard.h (num_input_events): Now size_t.
12333 This avoids undefined behavior on integer overflow, and is a bit
12334 more convenient anyway since it is compared to a size_t variable.
12335
c5101a77
PE
12336 Variadic C functions now count arguments with size_t, not int.
12337 This avoids an unnecessary limitation on 64-bit machines, which
12338 caused (substring ...) to crash on large vectors (Bug#8344).
12339 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
12340 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 12341 All variadic functions and their callers changed accordingly.
c5101a77
PE
12342 (struct gcpro.nvars): Now size_t, not int. All uses changed.
12343 * data.c (arith_driver, float_arith_driver): Likewise.
12344 * editfns.c (general_insert_function): Likewise.
12345 * eval.c (struct backtrace.nargs, interactive_p)
12346 (internal_condition_case_n, run_hook_with_args, apply_lambda)
12347 (funcall_lambda, mark_backtrace): Likewise.
12348 * fns.c (concat): Likewise.
12349 * frame.c (x_set_frame_parameters): Likewise.
12350 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
12351 0 if not found, not -1. All callers changed.
12352
dd3f25f7
PE
12353 * alloc.c (garbage_collect): Don't assume stack size fits in int.
12354 (stack_copy_size): Now size_t, not int.
12355 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
12356
461c2ab9
JB
123572011-03-28 Juanma Barranquero <lekktu@gmail.com>
12358
12359 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
12360 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12361 All callers changed.
12362
12363 * lisp.h (multibyte_char_to_unibyte):
12364 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
12365 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12366 * character.h (CHAR_TO_BYTE8):
12367 * cmds.c (internal_self_insert):
12368 * editfns.c (general_insert_function):
12369 * keymap.c (push_key_description):
12370 * search.c (Freplace_match):
12371 * xdisp.c (message_dolog, set_message_1): All callers changed.
12372
f6d62986
SM
123732011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
12374
12375 * keyboard.c (safe_run_hook_funcall): New function.
12376 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
12377 don't set the hook to nil, but remove the offending function instead.
12378 (Qcommand_hook_internal): Remove, unused.
12379 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
12380 Vcommand_hook_internal.
12381
12382 * eval.c (enum run_hooks_condition): Remove.
12383 (funcall_nil, funcall_not): New functions.
12384 (run_hook_with_args): Call each function through a `funcall' argument.
12385 Remove `cond' argument, now redundant.
12386 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
12387 (Frun_hook_with_args_until_failure): Adjust accordingly.
12388 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
12389
1db5b1ad
JB
123902011-03-28 Juanma Barranquero <lekktu@gmail.com>
12391
12392 * dispextern.h (string_buffer_position): Remove declaration.
12393
12394 * print.c (strout): Remove parameter `multibyte', unused since
12395 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
12396
12397 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
12398 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
12399 All callers changed.
12400
12401 * w32.c (_wsa_errlist): Use braces for struct initializers.
12402
12403 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
12404 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
12405 All callers changed.
12406 (string_buffer_position): Likewise. Also, make static (it's never
12407 used outside xdisp.c).
12408 (cursor_row_p): Remove parameter `w', unused since
12409 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
12410 (decode_mode_spec): Remove parameter `precision', introduced during
12411 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
12412 All callers changed.
12413
5ffb62aa
JD
124142011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12415
12416 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
12417
461c2ab9 124182011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
12419
12420 * nsterm.m (ns_menu_bar_is_hidden): New variable.
12421 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
12422 (ns_update_auto_hide_menu_bar): New functions.
12423 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
12424 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
12425 ns_constrain_all_frames.
12426 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
12427 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
12428
5c380ffb
JD
124292011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12430
12431 * nsmenu.m (runDialogAt): Remove argument to timer_check.
12432
9af30bdf
GM
124332011-03-27 Glenn Morris <rgm@gnu.org>
12434
12435 * syssignal.h: Replace RETSIGTYPE with void.
12436 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
12437 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
12438 Replace SIGTYPE with void everywhere.
12439 * s/usg5-4-common.h (SIGTYPE): Remove definition.
12440 * s/template.h (SIGTYPE): Remove commented out definition.
12441
e2abce01
JB
124422011-03-26 Eli Zaretskii <eliz@gnu.org>
12443
12444 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
12445 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
12446
f868cd8a
JB
124472011-03-26 Juanma Barranquero <lekktu@gmail.com>
12448
59eb0929
JB
12449 * w32.c (read_unc_volume): Use parameter `henum', instead of
12450 global variable `wget_enum_handle'.
12451
12452 * keymap.c (describe_vector): Remove parameters `indices' and
12453 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
12454 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
12455
f868cd8a
JB
12456 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
12457
12458 * keyboard.c (timer_check): Remove parameter `do_it_now',
12459 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
12460 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
12461 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
12462
12463 * keyboard.c (read_char):
12464 * w32menu.c (w32_menu_display_help):
12465 * xmenu.c (show_help_event, menu_help_callback):
12466 Adjust calls to `show_help_echo'.
12467
12468 * gtkutil.c (xg_maybe_add_timer):
12469 * keyboard.c (readable_events):
12470 * process.c (wait_reading_process_output):
12471 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
12472
12473 * insdel.c (adjust_markers_gap_motion):
12474 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
12475 (gap_left, gap_right): Don't call it.
12476
2ecf6fdb
CY
124772011-03-25 Chong Yidong <cyd@stupidchicken.com>
12478
12479 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
12480 incurred during fontification.
12481
6b1f9ba4
JB
124822011-03-25 Juanma Barranquero <lekktu@gmail.com>
12483
12484 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
12485 (DEFVAR_PER_BUFFER): Don't pass it.
12486
12487 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
12488 (scrolling_window): Don't pass it.
12489
0f4a96b5
JB
124902011-03-25 Juanma Barranquero <lekktu@gmail.com>
12491
12492 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
12493
12494 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
12495 and `suffix'.
12496 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
12497 of variables specific to SELinux and computation of `encoded_absname'.
12498
12499 * image.c (XPutPixel): Remove unused variable `height'.
12500
12501 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
12502
12503 * unexw32.c (get_section_info): Remove unused variable `section'.
12504
12505 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
12506 (system_process_attributes): Remove unused variable `sess'.
12507 (sys_read): Remove unused variable `err'.
12508
12509 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
12510 (w32_wnd_proc): Remove unused variable `isdead'.
12511 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
12512 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
12513 (x_create_tip_frame): Remove unused variable `tem'.
12514
12515 * w32inevt.c (w32_console_read_socket):
12516 Remove unused variable `no_events'.
12517
12518 * w32term.c (x_draw_composite_glyph_string_foreground):
12519 Remove unused variable `width'.
12520
1149507c
JB
125212011-03-24 Juanma Barranquero <lekktu@gmail.com>
12522
12523 * w32term.c (x_set_glyph_string_clipping):
12524 Don't pass uninitialized region to CombineRgn.
12525
9c88f339
JB
125262011-03-23 Juanma Barranquero <lekktu@gmail.com>
12527
12528 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
12529 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
12530 (Fx_close_connection): Remove unused variable `i'.
12531
12532 * w32font.c (w32font_draw): Return number of glyphs.
12533 (w32font_open_internal): Remove unused variable `i'.
12534 (w32font_driver): Add missing initializer.
12535
12536 * w32menu.c (utf8to16): Remove unused variable `utf16'.
12537 (fill_in_menu): Remove unused variable `items_added'.
12538
12539 * w32term.c (last_mouse_press_frame): Remove static global variable.
12540 (w32_clip_to_row): Remove unused variable `f'.
12541 (x_delete_terminal): Remove unused variable `i'.
12542
12543 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
12544 (NOTHING): Remove unused static global variable.
12545 (uniscribe_check_otf): Remove unused variable `table'.
12546 (uniscribe_font_driver): Add missing initializers.
12547
dee091a3
JD
125482011-03-23 Julien Danjou <julien@danjou.info>
12549
12550 * term.c (Fsuspend_tty, Fresume_tty):
12551 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
12552 * window.c (temp_output_buffer_show):
12553 * insdel.c (signal_before_change):
12554 * frame.c (Fhandle_switch_frame):
12555 * fileio.c (Fdo_auto_save):
12556 * emacs.c (Fkill_emacs):
12557 * editfns.c (save_excursion_restore):
12558 * cmds.c (internal_self_insert):
12559 * callint.c (Fcall_interactively):
12560 * buffer.c (Fkill_all_local_variables):
12561 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
12562 Use Frun_hooks.
0f4a96b5 12563 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 12564 unconditionally since it does the check itself.
dee091a3 12565
2c520ab5 125662011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 12567
c9c49752
PE
12568 Fix more problems found by GCC 4.5.2's static checks.
12569
8abc3f12
PE
12570 * coding.c (encode_coding_raw_text): Avoid unnecessary test
12571 the first time through the loop, since we know p0 < p1 then.
12572 This also avoids a gcc -Wstrict-overflow warning.
12573
a2d26660
PE
12574 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
12575 leading to a memory leak, possible in functions like
12576 load_charset_map_from_file that can allocate an unbounded number
b12ef411 12577 of objects (Bug#8318).
a2d26660 12578
916c72e9
PE
12579 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
12580 that could (at least in theory) be that large.
12581
19ab8a18
PE
12582 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
12583 This is less likely to overflow, and avoids undefined behavior if
12584 overflow does occur. All callers changed. Use strtoul to scan
12585 for the unsigned long integer.
b7cbbd6f
PE
12586 (pint2hrstr): Simplify and tune code slightly.
12587 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 12588
f0641eff
PE
12589 * scroll.c (do_scrolling): Work around GCC bug 48228.
12590 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
12591
7f650bb9
PE
12592 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
12593 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
12594 (validate_x_resource_name): Simplify count usage.
12595 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 12596
37dd57d1
PE
12597 * fileio.c (Fcopy_file): Report error if fchown or fchmod
12598 fail (Bug#8306).
81e56e61 12599
699979fc 12600 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 12601
401bf9b4
PE
12602 * process.c (Fmake_network_process): Use socklen_t, not int,
12603 where POSIX says socklen_t is required in portable programs.
12604 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 12605 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
12606 (Fmake_network_process, server_accept_connection):
12607 (wait_reading_process_output, read_process_output):
12608 Likewise.
12609
b93aacde
PE
12610 * process.c: Rename or move locals to avoid shadowing.
12611 (list_processes_1, Fmake_network_process):
12612 (read_process_output_error_handler, exec_sentinel_error_handler):
12613 Rename or move locals.
4dc343ee 12614 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 12615 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 12616 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 12617 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 12618 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 12619
af8a867c 12620 Make tparam.h and terminfo.c consistent.
44f230aa
SM
12621 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
12622 Include tparam.h instead, since it declares them.
af8a867c
PE
12623 * cm.h (PC): Remove extern decl; tparam.h now does this.
12624 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
12625 * terminfo.c: Include tparam.h, to check interfaces.
12626 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
12627 (tparam): Adjust signature to match interface in tparam.h;
12628 this removes some undefined behavior. Check that outstring and len
12629 are zero, which they always are with Emacs.
12630 * tparam.h (PC, BC, UP): New extern decls.
12631
0248044d 12632 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 12633 (xftfont_open): Rename locals to avoid shadowing.
0248044d 12634
8ff096c1 12635 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
12636 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
12637 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 12638 (ftfont_list): Remove unused local.
49eaafba
PE
12639 (get_adstyle_property, ftfont_pattern_entity):
12640 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
12641 Rename locals to avoid shadowing.
8ff096c1 12642
e2be39f6
PE
12643 * xfont.c (xfont_list_family): Mark var as initialized.
12644
c9735e30
PE
12645 * xml.c (make_dom): Now static.
12646
8f5201ae
PE
12647 * composite.c (composition_compute_stop_pos): Rename local to
12648 avoid shadowing.
b246f932
PE
12649 (composition_reseat_it): Remove unused locals.
12650 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 12651 (composition_update_it): Mark var as initialized.
11b61122
PE
12652 (find_automatic_composition): Mark vars as initialized,
12653 with a FIXME (Bug#8290).
8f5201ae 12654
760fbc2c
PE
12655 character.h: Rename locals to avoid shadowing.
12656 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
12657 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
12658 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
12659 (BUF_DEC_POS): Be more systematic about renaming local temporaries
12660 to avoid shadowing.
12661
ff08eb85
PE
12662 * textprop.c (property_change_between_p): Remove; unused.
12663
fc7bf025
PE
12664 * intervals.c (interval_start_pos): Now static.
12665
235d7abc
PE
12666 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
12667
44f230aa
SM
12668 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
12669 Rename locals to avoid shadowing.
3e7d6594 12670
50060332
PE
12671 * sound.c (wav_play, au_play, Fplay_sound_internal):
12672 Fix pointer signedness.
d01f234b 12673 (alsa_choose_format): Remove unused local var.
c83b8872
PE
12674 (wav_play): Initialize a variable to 0, to prevent undefined
12675 behavior (Bug#8278).
50060332 12676
c4fc4e30
PE
12677 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
12678
918436ed
PE
12679 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
12680
c939f91b
PE
12681 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
12682 clobbering (Bug#8298).
b9c7f648
PE
12683 * sysdep.c (sys_subshell): Likewise.
12684 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 12685
6bd8c144
PE
12686 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
12687 This should get cleaned up, so that child_setup has the
12688 same signature on all platforms.
12689
7710357c 12690 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 12691 (relocate_fd): Rename locals to avoid shadowing.
7710357c 12692
c59da222
CY
126932011-03-22 Chong Yidong <cyd@stupidchicken.com>
12694
12695 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
12696 not to be necessary, and produces flickering.
12697
66b87493
GM
126982011-03-20 Glenn Morris <rgm@gnu.org>
12699
12700 * config.in: Remove file.
12701
45b6f6d5
JB
127022011-03-20 Juanma Barranquero <lekktu@gmail.com>
12703
12704 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
12705 are now in src/globals.h.
12706 (syms_of_minibuf): Remove spurious & from previous change.
12707
cd394be1 127082011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
12709
12710 * minibuf.c (completing-read-function): New variable.
12711 (completing-read-default): Rename from completing-read.
12712 (completing-read): Call completing-read-function.
12713
b14e3e21
CY
127142011-03-19 Juanma Barranquero <lekktu@gmail.com>
12715
12716 * xfaces.c (Fx_load_color_file):
12717 Read color file from absolute filename (bug#8250).
12718
f2b726e6
JB
127192011-03-19 Juanma Barranquero <lekktu@gmail.com>
12720
12721 * makefile.w32-in: Update dependencies.
12722
09f6ff02
EZ
127232011-03-17 Eli Zaretskii <eliz@gnu.org>
12724
12725 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
12726
29a6015a
PE
127272011-03-17 Paul Eggert <eggert@cs.ucla.edu>
12728
a3a6c54e
PE
12729 Fix more problems found by GCC 4.5.2's static checks.
12730
b766f867
PE
12731 * process.c (make_serial_process_unwind, send_process_trap):
12732 (sigchld_handler): Now static.
12733
be02381c
PE
12734 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
12735 That way, the code declares only the vars that it needs.
12736 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
12737 * s/cygwin.h (PTY_ITERATION): Likewise.
12738 * s/darwin.h (PTY_ITERATION): Likewise.
12739 * s/gnu-linux.h (PTY_ITERATION): Likewise.
12740
57048744
PE
12741 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
12742 * process.c (allocate_pty): Don't declare stb unless it's needed.
12743
7914961c 12744 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
12745 (CONSTANTLIM): Remove; unused.
12746 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
12747 Define only if needed.
7914961c 12748
b3967b18
PE
12749 * unexelf.c (unexec): Name an expression,
12750 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
12751 Use a different way to cause a compilation error if anyone uses
12752 n rather than nn, a way that does not involve shadowing.
73366a00 12753 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 12754
29a6015a
PE
12755 * deps.mk (unexalpha.o): Remove; unused.
12756
43cfc33e 12757 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 12758 * unexec.h: New file.
ce701a33
PE
12759 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
12760 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
12761 Depend on unexec.h.
12762 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
12763 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
12764 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 12765 Change as necessary to match prototype in unexec.h.
ce701a33 12766
01f44d5a
PE
12767 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
12768 shadowing.
4f63c6bb 12769 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 12770
a6670b0b
PE
12771 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
12772 Rename locals to avoid shadowing.
12773
cef2010d 12774 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 12775 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 12776
d4d7173a
PE
12777 * print.c (Fredirect_debugging_output): Fix pointer signedess.
12778
f08b802a
PE
12779 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
12780 warning when compiling print.c.
12781
3ddb0639
PE
12782 * font.c (font_unparse_fcname): Abort in an "impossible" situation
12783 instead of using an uninitialized var.
5ad03b97 12784 (font_sort_entities): Mark var as initialized.
3ddb0639 12785
170a2692
PE
12786 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
12787
e663c700
PE
12788 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
12789 pointers to constants.
89bc529a 12790 (font_parse_fcname): Remove unused vars.
7b81e2d0 12791 (font_delete_unmatched): Now static.
ea838e10 12792 (font_get_spec): Remove; unused.
13a547c6
PE
12793 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
12794 (font_update_drivers, Ffont_get_glyphs, font_add_log):
12795 Rename or move locals to avoid shadowing.
e663c700 12796
2a80c887 12797 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 12798 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 12799
1384fa33 12800 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 12801 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 12802
8b2c52e9
PE
12803 * alloc.c (mark_backtrace): Move decl from here ...
12804 * lisp.h: ... to here, so that it can be checked.
12805
475545b5 12806 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 12807 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
12808 (lisp_indirect_variable): Name an expression,
12809 to avoid gcc -Wbad-function-cast warning.
1faed8ae 12810 (Fdefvar): Rename locals to avoid shadowing.
475545b5 12811
b1349114 12812 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 12813 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 12814 Use const pointer when appropriate.
b1349114 12815
a2928364
PE
12816 * lisp.h (get_system_name, get_operating_system_release):
12817 Move decls here, to check interfaces.
12818 * process.c (get_operating_system_release): Move decl to lisp.h.
12819 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
12820 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
12821 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
12822 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
12823 (Fformat_time_string, Fencode_time, Finsert_char):
12824 (Ftranslate_region_internal, Fformat):
12825 Rename or remove local vars to avoid shadowing.
9710023e 12826 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 12827
a415e694
PE
12828 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
12829 avoid shadowing.
12830
8ef4622d
PE
12831 * lisp.h (eassert): Check that the argument compiles, even if
12832 ENABLE_CHECKING is not defined.
12833
946f9a5b
PE
12834 * data.c (Findirect_variable): Name an expression, to avoid
12835 gcc -Wbad-function-cast warning.
112396d6 12836 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 12837 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
12838 (Fmake_variable_buffer_local, Fmake_local_variable):
12839 Mark variables as initialized.
52746918 12840 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 12841
e5aab7e7 12842 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
12843 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
12844 Rename locals to avoid shadowing.
dff45157
PE
12845 (mark_stack): Move local variables into the #ifdef region where
12846 they're used.
7bc26fdb
PE
12847 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
12848 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
12849 needed otherwise.
12850 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
12851 (GC_STRING_CHARS): Remove; not used.
d40d4be1 12852 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 12853
e5aab7e7
PE
12854 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
12855 avoids undefined behavior in theory.
12856
4da60324
PE
12857 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
12858
88043301
PE
12859 Use functions, not macros, for up- and down-casing (Bug#8254).
12860 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12861 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
12862 to use the following functions instead of these macros.
12863 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
12864 EMACS_INT, since callers assume the returned value fits in int.
12865 (upcase1): Likewise, for UPCASE_TABLE.
12866 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 12867 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 12868 the race-condition problem in the old DOWNCASE.
88043301 12869
19ed5445
PE
12870 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
12871 Rename locals to avoid shadowing.
12872 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
12873 (regex_compile, re_search_2, re_match_2_internal):
12874 Remove unused local vars.
952db0d7
PE
12875 (FREE_VAR): Rewrite so as not to use empty "else",
12876 which gcc can warn about.
da053e48 12877 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
12878 (RETALLOC_IF): Define only if needed.
12879 (WORDCHAR_P): Likewise. This one is never needed, but is used
12880 only in a comment talking about a compiler bug, so put inside
12881 the #if 0 of that comment.
12882 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
12883 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
12884 Remove; unused.
19ed5445 12885
1f3561e4 12886 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
12887 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
12888 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 12889
ded6f8f7
PE
12890 * search.c (simple_search): Remove unused var.
12891
dbd37a95
PE
12892 * dired.c (compile_pattern): Move decl from here ...
12893 * lisp.h: ... to here, so that it can be checked.
12894 (struct re_registers): New forward decl.
12895
7e47afad
PE
12896 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
12897
85f24f61
PE
12898 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
12899 All uses changed.
12900 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
12901 Rename locals to avoid shadowing.
5671df8f 12902 (Fvertical_motion): Mark locals as initialized.
85f24f61 12903
181aa2be 12904 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 12905 (casify_region): Mark local as initialized.
181aa2be 12906
930d429c
PE
12907 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
12908
7082eac6
PE
12909 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
12910 New macros, so that the caller can use some names other than
12911 gcpro1, gcpro2, etc.
12912 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
12913 of the new macros.
12914 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
12915 argument, for consistency with GCPRO2_VAR, etc: it is now the
12916 prefix of the variable, not the variable itself. All uses
12917 changed.
38b2c076
PE
12918 * dired.c (directory_files_internal, file_name_completion):
12919 Rename locals to avoid shadowing.
12920
15206ed9
PE
12921 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
12922 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
12923 dired.c's scmp function, had undefined behavior.
12924 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12925 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
12926 * buffer.h: ... to here, because these macros use current_buffer,
12927 and the new implementation with inline functions needs to have
12928 current_buffer in scope now, rather than later when the macros
12929 are used.
12930 (downcase, upcase1): New static inline functions.
12931 (DOWNCASE, UPCASE1): Reimplement using these functions.
12932 This avoids undefined behavior in expressions like
12933 DOWNCASE (x) == DOWNCASE (y), which previously suffered
12934 from race conditions in accessing the global variables
12935 case_temp1 and case_temp2.
12936 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
12937 * lisp.h (case_temp1, case_temp2): Remove their decls.
12938 * character.h (ASCII_CHAR_P): Move from here ...
12939 * lisp.h: ... to here, so that the inline functions mentioned
12940 above can use them.
12941
4a6bea26
PE
12942 * dired.c (directory_files_internal_unwind): Now static.
12943
f14b7e14
PE
12944 * fileio.c (file_name_as_directory, directory_file_name):
12945 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
12946 Now static.
2893f146
PE
12947 (file_name_as_directory): Use const pointers when appropriate.
12948 (Fexpand_file_name): Likewise. In particular, newdir might
12949 point at constant storage, so make it a const pointer.
fd4ead52 12950 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
12951 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
12952 signedness issues.
f839df0c
PE
12953 (Fset_file_times, Finsert_file_contents, auto_save_error):
12954 Rename locals to avoid shadowing.
f14b7e14 12955
5716756e 12956 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
12957 (Ftry_completion, Fall_completions): Rename or remove locals
12958 to avoid shadowing.
5716756e 12959
b4c3046a
PE
12960 * marker.c (bytepos_to_charpos): Remove; unused.
12961
b45db522
PE
12962 * lisp.h (verify_bytepos, count_markers): New decls,
12963 so that gcc does not warn that these functions aren't declared.
12964
85876d07
PE
12965 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
12966 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 12967 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 12968 (copy_text): Remove unused local var.
85876d07 12969
03d78a21 12970 * filelock.c (within_one_second): Now static.
b3dd38ab 12971 (lock_file_1): Rename local to avoid shadowing.
03d78a21 12972
5df8f01b
PE
12973 * buffer.c (fix_overlays_before): Mark locals as initialized.
12974 (fix_start_end_in_overlays): Likewise. This function should be
12975 simplified by using pointers-to-pointers, but that's a different
12976 matter.
b1d876f1 12977 (switch_to_buffer_1): Now static.
8f54f30a
PE
12978 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
12979 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 12980
a70072c9 12981 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 12982 Fix pointer signedness issue.
edced198
PE
12983 (sys_subshell): Mark local as volatile if checking for lint,
12984 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 12985 (MAXPATHLEN): Define only if needed.
a70072c9 12986
a0977c44
PE
12987 * process.c (serial_open, serial_configure): Move decls from here ...
12988 * systty.h: ... to here, so that they can be checked.
12989
a884fdcc
PE
12990 * fns.c (get_random, seed_random): Move extern decls from here ...
12991 * lisp.h: ... to here, so that they can be checked.
12992
604efe86 12993 * sysdep.c (reset_io): Now static.
b8950c94 12994 (wait_for_termination_signal): Remove; unused.
604efe86 12995
38fc62d9
PE
12996 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
12997 (copy_keymap_item, append_key, push_text_char_description):
12998 Now static.
1004a21a 12999 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 13000 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
13001 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
13002 (describe_map_tree):
13003 Rename locals to avoid shadowing.
38fc62d9 13004
2f2650da
PE
13005 * keyboard.c: Declare functions static if they are not used elsewhere.
13006 (echo_char, echo_dash, cmd_error, top_level_2):
13007 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
13008 (read_char, kbd_buffer_get_event, make_lispy_position):
13009 (make_lispy_event, make_lispy_movement, apply_modifiers):
13010 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
13011 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
13012 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 13013 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 13014 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 13015
a053e86c 13016 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
13017 (mark_kboards): Move decl here ...
13018 * alloc.c (mark_kboards): ... from here.
a053e86c 13019
4752793e
PE
13020 * lisp.h (force_auto_save_soon): New decl.
13021
74f10ca7 13022 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
13023 (DEFINE_DUMMY_FUNCTION): New macro.
13024 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
13025 Use it.
c03cd23f
PE
13026 (main): Add casts to avoid warnings
13027 if GCC considers string literals to be constants.
74f10ca7 13028
022e70d4
PE
13029 * lisp.h (fatal_error_signal): Add decl, since it's exported.
13030
59d6fe83
PE
13031 * dbusbind.c: Pointer signedness fixes.
13032 (xd_signature, xd_append_arg, xd_initialize):
13033 (Fdbus_call_method, Fdbus_call_method_asynchronously):
13034 (Fdbus_method_return_internal, Fdbus_method_error_internal):
13035 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
13036 (Fdbus_register_signal): Use SSDATA when the context wants char *.
13037
78320123
PE
13038 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
13039 if GCC considers string literals to be constants.
49cebcca 13040 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 13041
35ac2a97
SM
130422011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
13043
fb103ca9
SM
13044 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
13045 (print_preprocess, print_object): New macro to fix last change.
13046
35ac2a97
SM
13047 * print.c (print_preprocess): Don't forget font objects.
13048
62973b41
JB
130492011-03-16 Juanma Barranquero <lekktu@gmail.com>
13050
13051 * emacs.c (USAGE3): Doc fixes.
13052
0e48bb22
AS
130532011-03-15 Andreas Schwab <schwab@linux-m68k.org>
13054
13055 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
13056 structure.
13057
7684e57b
JB
130582011-03-14 Juanma Barranquero <lekktu@gmail.com>
13059
13060 * lisp.h (VWindow_system, Qfile_name_history):
13061 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
13062 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
13063 (w32_system_caret_x, w32_system_caret_y): Declare extern.
13064
13065 * w32select.c: Don't #include "keyboard.h".
c96bbc66 13066 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
13067
13068 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
13069 * w32console.c (detect_input_pending, read_input_pending)
13070 (encode_terminal_code):
13071 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
13072 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
13073 (w32_system_caret_y, Qfile_name_history):
13074 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
13075 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
13076 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
13077 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
13078 * w32proc.c (Qlocal, report_file_error):
13079 * w32term.c (Vwindow_system, updating_frame):
13080 * w32uniscribe.c (initialized, uniscribe_font_driver):
13081 Remove unneeded extern declarations.
13082
2aa46d6c
CY
130832011-03-14 Chong Yidong <cyd@stupidchicken.com>
13084
c96bbc66 13085 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 13086
cffc6f3b
CY
130872011-03-13 Chong Yidong <cyd@stupidchicken.com>
13088
13089 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
13090 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
13091 These macros can no longer be used for assignment.
13092
44f230aa
SM
13093 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
13094 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
13095 (record_buffer_markers, fetch_buffer_markers): New functions for
13096 recording and fetching special buffer markers.
13097 (set_buffer_internal_1, set_buffer_temp): Use them.
13098
13099 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
13100
13101 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
13102
13103 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
13104 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
13105
13106 * xdisp.c (hscroll_window_tree):
13107 (reconsider_clip_changes): Use PT instead of BUF_PT.
13108
d251f04b
EZ
131092011-03-13 Eli Zaretskii <eliz@gnu.org>
13110
13111 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
13112 $(EMACS_ROOT)/lib/intprops.h.
13113
f0c77cd1
PE
131142011-03-13 Paul Eggert <eggert@cs.ucla.edu>
13115
3eca4629
PE
13116 Fix more problems found by GCC 4.5.2's static checks.
13117
7c86ee98
PE
13118 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
13119 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
13120 (xg_free_frame_widgets): Make it clear that a local variable is
13121 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
13122 (gdk_window_get_screen): Make it clear that this macro is needed
13123 only if USE_GTK_TOOLTIP.
1e5524e7
PE
13124 (int_gtk_range_get_value): New function, which avoids a diagnostic
13125 from gcc -Wbad-function-cast.
13126 (xg_set_toolkit_scroll_bar_thumb): Use it.
13127 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
13128 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
13129 (get_utf8_string, xg_get_file_with_chooser):
13130 Rename locals to avoid shadowing.
13131 (create_dialog): Move locals to avoid shadowing.
7c86ee98 13132
41729b81
PE
13133 * xgselect.c (xg_select): Remove unused var.
13134
f0c77cd1
PE
13135 * image.c (four_corners_best): Mark locals as initialized.
13136 (gif_load): Initialize transparent_p to zero (Bug#8238).
13137 Mark another local as initialized.
ec6cf4c6 13138 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 13139
ce0ad53d 13140 * image.c (clear_image_cache): Now static.
d5d5a617 13141 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 13142 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
13143 (x_edge_detection): Remove unnecessary cast that
13144 gcc -Wbad-function-cast diagnoses.
2037898d 13145 (gif_load): Fix pointer signedness.
6ae141d6
PE
13146 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
13147 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 13148
33383987 131492011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 13150
d32df629
PE
13151 Improve quality of tests for time stamp overflow.
13152 For example, without this patch (encode-time 0 0 0 1 1
13153 1152921504606846976) returns the obviously-bogus value (-948597
13154 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
13155 reports time overflow. See
13156 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
13157 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
13158 * editfns.c: Include limits.h and intprops.h.
13159 (TIME_T_MIN, TIME_T_MAX): New macros.
13160 (time_overflow): Move earlier, to before first use.
13161 (hi_time, lo_time): New functions, for an accurate test for
13162 out-of-range times.
13163 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
13164 (Fget_internal_run_time): Don't assume time_t fits in int.
13165 (make_time): Use list2 instead of Fcons twice.
13166 (Fdecode_time): More accurate test for out-of-range times.
13167 (check_tm_member): New function.
13168 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
13169 (lisp_time_argument): Don't rely on undefined left-shift and
13170 right-shift behavior when checking for time stamp overflow.
8be6f318 13171
fe31d94c
PE
13172 * editfns.c (time_overflow): New function, refactoring common code.
13173 (Fformat_time_string, Fdecode_time, Fencode_time):
13174 (Fcurrent_time_string): Use it.
13175
8be6f318
PE
13176 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
13177 * dired.c (make_time): Move to ...
13178 * editfns.c (make_time): ... here.
13179 * systime.h: Note the move.
13180
09d9db2c 131812011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 13182
126bc0dc
YM
13183 * fringe.c (update_window_fringes): Remove unused variables.
13184
c47cbdfd
YM
13185 * unexmacosx.c (copy_data_segment): Also copy __got section.
13186 (Bug#8223)
13187
7ac80be9
EZ
131882011-03-12 Eli Zaretskii <eliz@gnu.org>
13189
c96bbc66 13190 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
13191 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
13192 Constify `char *' arguments and their references according to
13193 prototypes in tparam.h.
13194
ecb0f94d 13195 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 13196
7ac80be9
EZ
13197 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
13198 Adapt all references accordingly.
13199
13200 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
13201
ef1fd07e
TT
132022011-03-11 Tom Tromey <tromey@redhat.com>
13203
13204 * buffer.c (syms_of_buffer): Remove obsolete comment.
13205
7ef4b50c
EZ
132062011-03-11 Eli Zaretskii <eliz@gnu.org>
13207
13208 * termhooks.h (encode_terminal_code): Declare prototype.
13209
13210 * msdos.c (encode_terminal_code): Don't declare prototype.
13211
13212 * term.c (encode_terminal_code): Now external again, used by
13213 w32console.c and msdos.c.
13214
44f230aa
SM
13215 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
13216 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 13217
4b1ec863 132182011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 13219
1714f52b 13220 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 13221
4b1ec863
PE
13222 * fringe.c (update_window_fringes): Mark locals as initialized
13223 (Bug#8227).
13224 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 13225
524c7aa6
PE
13226 * alloc.c (mark_fringe_data): Move decl from here ...
13227 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
13228 to check its interface.
13229 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
13230
a5c0af81 13231 * fontset.c (free_realized_fontset): Now static.
7519b8cd 13232 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 13233 (fontset_font): Mark local as initialized.
a9a06e0b 13234 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 13235
b4716021
PE
13236 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
13237
811e9bac 13238 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 13239 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
13240 (x_own_selection, Fx_disown_selection_internal): Rename locals
13241 to avoid shadowing.
13242 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 13243
7e3ab302
PE
13244 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
13245 so that the caller can use some name other than gcpro1.
13246 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
13247 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13248 (Fx_backspace_delete_keys_p):
13249 Use them to avoid shadowing, and rename vars to avoid shadowing.
13250 (x_decode_color, x_set_name, x_window): Now static.
6b437900 13251 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 13252 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
13253 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
13254 Remove unused locals.
7e3ab302
PE
13255 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13256 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
13257 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
13258 macros.
f78faa98 13259
e2b13473
PE
13260 * xterm.h (x_mouse_leave): New decl.
13261
77f23912
PE
13262 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
13263 Remove unused functions.
cdf4ba58
PE
13264 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
13265 (x_calc_absolute_position): Now static.
7411c686 13266 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 13267 Don't declare local "event" unless it's used.
ed7bf3a5
PE
13268 (x_iconify_frame, x_free_frame_resources): Don't declare locals
13269 unless they are used.
38d0b34a
PE
13270 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
13271 (x_fatal_error_signal): Remove; not used.
a6067996
PE
13272 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
13273 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
13274 (x_error_catcher, x_connection_closed, x_error_handler):
13275 (x_error_quitter, xembed_send_message, x_iconify_frame):
13276 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 13277 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 13278 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 13279
44f230aa
SM
13280 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
13281 Rename or move locals to avoid shadowing.
6b463e58 13282 (tty_defined_color, merge_face_heights): Now static.
5967d051 13283 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
13284 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
13285 does not deduce is never used uninitialized.
73719eba
PE
13286 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
13287 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 13288
426994c3 13289 * terminal.c (store_terminal_param): Now static.
5489860b 13290
032f1620 13291 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 13292 (set_frame_menubar): Remove unused local.
d4323972 13293 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
13294 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
13295 since they might point to immutable storage.
281585b0
PE
13296 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
13297 since it's unused otherwise.
032f1620 13298
367c19e5 13299 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 13300 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
13301 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
13302 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 13303 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
13304 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
13305 does not deduce are never used uninitialized.
70739cbe 13306
07b48fa9
PE
13307 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
13308
8868a238 13309 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
13310 * window.c (window_loop, size_window):
13311 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 13312
7e5cf297 13313 * window.c (display_buffer): Now static.
d6550a9f
PE
13314 (size_window): Mark variables that gcc -Wuninitialized
13315 does not deduce are never used uninitialized.
a586633d
PE
13316 * window.h (check_all_windows): New decl, to forestall
13317 gcc -Wmissing-prototypes diagnostic.
5b555da1 13318 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 13319
f6095868
PE
13320 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
13321 shadowing.
13322 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
13323 Include <limits.h>.
13324 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
13325 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
13326 (load_charset_map): Mark variables that gcc -Wuninitialized
13327 does not deduce are never used uninitialized.
53df7c11 13328 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 13329
f38b440c
PE
13330 * coding.c (coding_set_source, coding_set_destination):
13331 Use "else { /* comment */ }" rather than "else /* comment */;"
13332 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
13333 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
13334 a block, when the outer 'i' will do.
13335 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
13336 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
13337 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
13338 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
13339 (Fdecode_sjis_char, Fdefine_coding_system_internal):
13340 Rename locals to avoid shadowing.
13341 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
13342 * coding.c (emacs_mule_char, encode_invocation_designation):
13343 Now static, since they're not used elsewhere.
413bb2db 13344 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 13345 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
13346 (decode_coding_emacs_mule): Mark variables that gcc
13347 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
13348 (detect_coding_iso_2022): Initialize a local variable that might
13349 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 13350 this initialization is needed. (Bug#8211)
5f58e762
PE
13351 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
13352 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
13353 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
13354 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
13355 Remove unused macros.
f38b440c 13356
232b38b9 13357 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 13358 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 13359 * character.c (string_count_byte8): Likewise.
232b38b9 13360
fb90da1b
PE
13361 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
13362 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
13363
fb93dbc2
PE
13364 * chartab.c (copy_sub_char_table): Now static, since it's not used
13365 elsewhere.
5c156ace
PE
13366 (sub_char_table_ref_and_range, char_table_ref_and_range):
13367 Rename locals to avoid shadowing.
bbcd0949 13368 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 13369
7d3b3862 13370 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 13371 (BIDI_BOB): Remove unused macro.
7d3b3862 13372
6be7d3da
PE
13373 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
13374 deduce are never used uninitialized.
c2ed9c8b 13375 * term.c (encode_terminal_code): Likewise.
6be7d3da 13376
75f8807f 13377 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 13378
50938595
PE
13379 * tparam.h: New file.
13380 * term.c, tparam.h: Include it.
13381 * deps.mk (term.o, tparam.o): Depend on tparam.h.
13382 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
13383 Move these decls to tparam.h, and make them agree with what
13384 is actually in tparam.c. The previous trick of using incompatible
13385 decls in different modules does not conform to the C standard.
13386 All callers of tparam changed to use tparam's actual API.
13387 * tparam.c (tparam1, tparam, tgoto):
13388 Use const pointers where appropriate.
13389
fbceeba2
PE
13390 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
13391 * cm.h (struct cm): Likewise.
13392 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
13393 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
13394 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
13395 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
13396 (turn_on_face, init_tty): Likewise.
13397 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 13398
7f3f1250
PE
13399 * term.c (term_mouse_position): Rename local to avoid shadowing.
13400
e6ca6543
PE
13401 * alloc.c (mark_ttys): Move decl from here ...
13402 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
13403
c40f8d15
AS
134042011-03-11 Andreas Schwab <schwab@linux-m68k.org>
13405
13406 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
13407
cfe0661d
JB
134082011-03-09 Juanma Barranquero <lekktu@gmail.com>
13409
13410 * search.c (compile_pattern_1): Remove argument regp, unused since
13411 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
13412 (compile_pattern): Don't pass it.
13413
0afb4571
J
134142011-03-08 Jan Djärv <jan.h.d@swipnet.se>
13415
13416 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
13417 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
13418 for ! HAVE_GTK3.
13419 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
13420
13421 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
13422
13423 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
13424 gdk_window_get_screen, gdk_window_get_geometry,
13425 gdk_x11_window_lookup_for_display and GDK_KEY_g.
13426 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
13427 (xg_get_pixbuf_from_pixmap): New function.
13428 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
13429 to Pixmap, take frame as parameter, remove GdkColormap parameter.
13430 Call xg_get_pixbuf_from_pixmap instead of
13431 gdk_pixbuf_get_from_drawable.
13432 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
13433 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
13434 (xg_check_special_colors): Use GtkStyleContext and its functions
13435 for HAVE_GTK3.
13436 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
13437 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
13438 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
13439 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
13440 Call gtk_widget_get_preferred_size.
0afb4571
J
13441 (xg_frame_resized): gdk_window_get_geometry only takes 5
13442 parameters.
44f230aa
SM
13443 (xg_win_to_widget, xg_event_is_for_menubar):
13444 Call gdk_x11_window_lookup_for_display.
0afb4571
J
13445 (xg_set_widget_bg): New function.
13446 (delete_cb): New function.
895009e1 13447 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 13448 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
13449 (xg_set_background_color): Call xg_set_widget_bg.
13450 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
13451 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
13452 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
13453 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
13454 if ! HAVE_GTK3.
13455 (update_frame_tool_bar): Call gtk_widget_hide.
13456 (xg_initialize): Use GDK_KEY_g.
13457
13458 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
13459 if ! HAVE_GTK3
13460 (x_session_initialize): Call gdk_x11_set_sm_client_id.
13461
13462 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
13463 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
13464 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
13465
1c2cc4ef
JB
134662011-03-08 Juanma Barranquero <lekktu@gmail.com>
13467
13468 * w32xfns.c (select_palette): Check success of RealizePalette against
13469 GDI_ERROR, not zero.
13470
33383987 13471See ChangeLog.11 for earlier changes.
aac0c6e3
MR
13472
13473;; Local Variables:
13474;; coding: utf-8
aac0c6e3
MR
13475;; End:
13476
2f097256 13477 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
13478
13479 This file is part of GNU Emacs.
13480
13481 GNU Emacs is free software: you can redistribute it and/or modify
13482 it under the terms of the GNU General Public License as published by
13483 the Free Software Foundation, either version 3 of the License, or
13484 (at your option) any later version.
13485
13486 GNU Emacs is distributed in the hope that it will be useful,
13487 but WITHOUT ANY WARRANTY; without even the implied warranty of
13488 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13489 GNU General Public License for more details.
13490
13491 You should have received a copy of the GNU General Public License
13492 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.