Add missing defcustom :version tags
[bpt/emacs.git] / src / ChangeLog
CommitLineData
f998bbe7 12012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
2
3 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
4
0992bd9c
CY
52012-02-07 Chong Yidong <cyd@gnu.org>
6
7 * buffer.c (Fbuffer_local_variables)
8 (buffer_lisp_local_variables): Handle unbound vars correctly;
9 don't let Qunbound leak into Lisp.
10
af008560
GM
112012-02-07 Glenn Morris <rgm@gnu.org>
12
dd605cc4
GM
13 * image.c (Fimagemagick_types): Doc fix.
14
af008560
GM
15 * image.c (imagemagick-render-type): Change it from a lisp object
16 to an integer. Move the doc here from the lisp manual.
17 Treat all values not equal to 0 the same.
18
1449fa1d
CY
192012-02-06 Chong Yidong <cyd@gnu.org>
20
21 * doc.c (store_function_docstring): Avoid applying docstring of
22 alias to base function (Bug#2603).
23
3723ec07
AS
242012-02-04 Andreas Schwab <schwab@linux-m68k.org>
25
26 * .gdbinit (pp1, pv1): Remove redundant defines.
27 (pr): Use pp.
28
79c1cc1e
CY
292012-02-04 Chong Yidong <cyd@gnu.org>
30
31 * nsterm.m: Declare a global (Bug#10694).
32
d7f29f8e
EZ
332012-02-04 Eli Zaretskii <eliz@gnu.org>
34
35 * w32.c (get_emacs_configuration_options): Include
36 --enable-checking, if specified, in the return value.
37
3b95a6f9
MR
382012-02-04 Martin Rudalics <rudalics@gmx.at>
39
40 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
41 after rounding frame sizes. (Bug#9723)
42
d6fa96a6
EZ
432012-02-04 Eli Zaretskii <eliz@gnu.org>
44
45 * keyboard.c (adjust_point_for_property): Don't position point
46 before BEGV. (Bug#10696)
47
df0b2940
PE
482012-02-03 Paul Eggert <eggert@cs.ucla.edu>
49
50 Handle overflow when computing char display width (Bug#9496).
51 * character.c (char_width): Return EMACS_INT, not int.
52 (char_width, c_string_width): Check for overflow when
53 computing the width; this is possible now that individual
54 characters can have unbounded width. Problem introduced
55 by merge from Emacs 23 on 2012-01-19.
56
6bee44d6
MA
572012-02-02 Michael Albinus <michael.albinus@gmx.de>
58
59 * dbusbind.c (Fdbus_register_method): Mention the return value
60 :ignore in the docstring.
61
44f92739
GM
622012-02-02 Glenn Morris <rgm@gnu.org>
63
1b9f60cc
GM
64 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
65
44f92739
GM
66 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
67 Unconditionally set to t. (Bug#10673)
68 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
69 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
70 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
71
c5d3843c
KH
722012-02-02 Kenichi Handa <handa@m17n.org>
73
74 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
75 0, do not call append_composite_glyph.
76
159462d4 772012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
78
79 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
80 NULL (Bug#6988).
81 (x_produce_glyphs): If the component of a composition is a null
82 string, set it->pixel_width to 1 to avoid zero-width glyph.
83
78cef877
EZ
842012-02-01 Eli Zaretskii <eliz@gnu.org>
85
86 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
87 first 2 arguments are identical. This makes inserting large
88 output from a subprocess an order of magnitude faster on
89 MS-Windows, where all sbrk'ed memory is always contiguous.
90
97897668
GM
912012-01-31 Glenn Morris <rgm@gnu.org>
92
93 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 94 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
95 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
96
31fd3586
GM
972012-01-29 Glenn Morris <rgm@gnu.org>
98
99 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
100
0e24a8b2
CY
1012012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
102
103 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
104
cc0adcb0
CY
1052012-01-28 Chong Yidong <cyd@gnu.org>
106
107 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
108
acc28cb9
CY
1092012-01-26 Chong Yidong <cyd@gnu.org>
110
9c69cfb7
CY
111 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
112
acc28cb9
CY
113 * search.c (Fsearch_forward, Fsearch_backward): Document negative
114 repeat counts (Bug#10507).
115
48da7392
GM
1162012-01-26 Glenn Morris <rgm@gnu.org>
117
118 * lread.c (syms_of_lread): Doc fix.
119
14af5f7f
CY
1202012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
121
122 * coding.c (encode_designation_at_bol): Change return value to
123 EMACS_INT.
124
0b21c100
CY
1252012-01-25 Chong Yidong <cyd@gnu.org>
126
127 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
128
3c2907f7
CY
1292012-01-21 Chong Yidong <cyd@gnu.org>
130
131 * floatfns.c (Fcopysign): Make the second argument non-optional,
132 since nil is not allowed anyway.
133
959ad23f
AS
1342012-01-21 Andreas Schwab <schwab@linux-m68k.org>
135
136 * process.c (read_process_output): Use p instead of XPROCESS (proc).
137 (send_process): Likewise.
138
34a02f46
MR
1392012-01-19 Martin Rudalics <rudalics@gmx.at>
140
141 * window.c (save_window_save, Fcurrent_window_configuration)
142 (Vwindow_persistent_parameters): Do not use Qstate. Rewrite
143 doc-strings.
144
1259009a 1452012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
146
147 * character.c (char_width): New function.
70d4fdf6
GM
148 (Fchar_width, c_string_width, lisp_string_width):
149 Use char_width (Bug#9496).
25ed9e61 150
6a6ee00d
MR
1512012-01-16 Martin Rudalics <rudalics@gmx.at>
152
153 * window.c (Vwindow_persistent_parameters): New variable.
154 (Fset_window_configuration, save_window_save): Handle persistent
155 window parameters.
156
c85efaf7
EZ
1572012-01-14 Eli Zaretskii <eliz@gnu.org>
158
159 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
160 thrashing the stack of the thread. (Bug#9087)
161
5944709e
PE
1622012-01-12 Paul Eggert <eggert@cs.ucla.edu>
163
164 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
165
e71f5d99
EZ
1662012-01-11 Eli Zaretskii <eliz@gnu.org>
167
168 * xdisp.c (rows_from_pos_range): Handle the case where the
169 highlight ends on a newline. (Bug#10464)
170 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
171 he end column for display of highlight that ends on a newline
172 before a R2L line.
173
ce316182
GM
1742012-01-11 Glenn Morris <rgm@gnu.org>
175
176 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
177 from load-path also when installation-directory is nil. (Bug#10208)
178
5b43da69
GM
1792012-01-10 Glenn Morris <rgm@gnu.org>
180
74cc8ff9
GM
181 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
182
7d8d6e4e
GM
183 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
184 Update template values to be closer to their typical values these days.
5b43da69 185
a0db8d43
EZ
1862012-01-09 Eli Zaretskii <eliz@gnu.org>
187
188 * xdisp.c (rows_from_pos_range): Accept additional argument
189 DISP_STRING, and accept any glyph in a row whose object is that
190 string as eligible for mouse highlight. Fixes mouse highlight of
191 display strings from overlays. (Bug#10464)
192
9a0115ab 1932012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 194
b9110d6a 195 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
196 * fileio.c (auto_saving_dir_umask): New static var.
197 (Fmake_directory_internal): Use it.
198 (do_auto_save_make_dir): Set it, instead of invoking chmod after
199 creating the directory. The old code temporarily assigns
200 too-generous permissions to the directory.
201 (do_auto_save_eh): Clear it.
b9110d6a 202 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
203 that the var is always cleared.
204
6c1bd3f3
EZ
2052012-01-07 Eli Zaretskii <eliz@gnu.org>
206
207 * search.c (scan_buffer): Pass character positions to
208 know_region_cache, not byte positions. (Bug#6540)
209
069d2b50
L
2102012-01-07 LynX <_LynX@bk.ru> (tiny change)
211
212 * w32.c (sys_rename): Report EXDEV when rename of a directory
213 fails because the target is on another logical disk. (Bug#10284)
214
75bf0d33
DB
2152012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
216
217 * xterm.c (x_embed_request_focus): New function.
218
219 * xterm.h: Add prototype.
220
221 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
222
1c6e5a32
GM
2232012-01-05 Glenn Morris <rgm@gnu.org>
224
225 * emacs.c (emacs_copyright): Update short copyright year to 2012.
226
651e947e
EZ
2272012-01-01 Eli Zaretskii <eliz@gnu.org>
228
229 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
230 Load gnutls_transport_set_lowat only if GnuTLS version is below
231 2.11.1.
232 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
233 GnuTLS versions below 2.11.1.
234
3778cdd8
AL
2352011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
236
237 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
238 to the doc string advising against its use for altering the way
239 windows are scrolled.
240
0e5317f7
KH
2412011-12-28 Kenichi Handa <handa@m17n.org>
242
243 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
244 coding-system ASCII compatible only when it does not produce BOM
245 on encoding (Bug#10383).
246
93d5ca1f
JD
2472011-12-26 Jan Djärv <jan.h.d@swipnet.se>
248
249 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
250 can scroll.
251 (create_and_show_popup_menu): Always use menu_position_func for
252 Gtk3 (Bug#10361).
253
ca22b785
AS
2542011-12-24 Andreas Schwab <schwab@linux-m68k.org>
255
256 * callint.c (Fcall_interactively): Don't truncate prompt string.
257
d048e1e6
EZ
2582011-12-23 Eli Zaretskii <eliz@gnu.org>
259
260 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
261 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 262 resumed from there (after widening). (Bug#10360)
d048e1e6 263
5ccaba1f
JD
2642011-12-22 Jan Djärv <jan.h.d@swipnet.se>
265
266 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
267
204ee57f
JD
2682011-12-21 Jan Djärv <jan.h.d@swipnet.se>
269
b81d40f0
JB
270 * nsterm.m (x_free_frame_resources):
271 Release f->output_data.ns->miniimage.
204ee57f
JD
272 (ns_index_color): Fix indentation. Do not retain
273 color_table->colors[i].
274
275 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
276 before returning.
277
278 * nsfns.m (x_set_background_color): Assign return value from
279 ns_index_color to face-background instead of NSColor*.
280 (ns_implicitly_set_icon_type): Fix indentation.
281 Change assignment in for loop to comparison.
282
283 * emacs.c (ns_pool): New variable.
284 (main): Assign ns_pool.
285 (Fkill_emacs): Call ns_release_autorelease_pool.
286
287 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
288 autorelease fdesc, release fdAttrs and tdict.
289 (ns_get_covering_families): Release charset.
290 (ns_findfonts): Release NSFontDescriptor created with new.
291 (ns_uni_to_glyphs): Fix indentation.
292 (setString): Release attrStr before assigning new value.
293
c803b2b7
JD
2942011-12-18 Jan Djärv <jan.h.d@swipnet.se>
295
678f4426
JD
296 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
297 and NS_IMPL_COCOA.
298 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
299 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
300
cd394be1 3012011-12-18 David Reitter <reitter@cmu.edu>
678f4426 302
5fecd5fc
JD
303 * nsterm.m (ns_term_init): Subscribe for notifications
304 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
305 to method trackingNotification in EmacsMenu.
306
307 * nsmenu.m (trackingMenu): New variable.
3771cb17 308 (trackingNotification): New method (from Aquamacs).
5fecd5fc 309 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 310 from Aquamacs (Bug#7030).
678f4426
JD
311
3122011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 313
c803b2b7
JD
314 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
315 (symbol_to_nsstring): Fix indentation.
316 (ns_symbol_to_pb): New function.
317 (Fns_get_selection_internal): Renamed from Fns_get_cut_buffer_internal.
318 (Fns_rotate_cut_buffers_internal): Removed.
319 (Fns_store_selection_internal): Renamed from
320 Fns_store_cut_buffer_internal.
321 (ns_get_foreign_selection, Fx_own_selection_internal)
322 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
323 (Fns_get_selection_internal, Fns_store_selection_internal):
324 Use ns_symbol_to_pb and check if return value is nil.
325 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
326 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
327 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
328 renamed to Sns_store_selection_internal.
329 (ns_handle_selection_request): Move code to Fx_own_selection_internal
330 and remove this function.
331 (ns_handle_selection_clear): Remove, never used.
332 (Fx_own_selection_internal): Move code from ns_handle_selection_request
333 here.
334
e1b01a3a
KB
3352011-12-17 Ken Brown <kbrown@cornell.edu>
336
337 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
338 GID is unknown (Bug#10257).
339
2adb6e85
PE
3402011-12-17 Paul Eggert <eggert@cs.ucla.edu>
341
342 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
343 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
344 which caused a build failure on GNU/Linux IA-64. This problem was
345 introduced by my 2011-10-07 patch.
346
d1d7b339
JL
3472011-12-15 Juri Linkov <juri@jurta.org>
348
349 * image.c (imagemagick_error): New function. (Bug#10112)
350 (imagemagick_load_image): Comment out `MagickSetResolution' call.
351 Use `imagemagick_error' where ImageMagick functions return
352 `MagickFalse'.
353 (Fimagemagick_types): Add `Fnreverse' to return the list in the
354 proper order.
355
100d5755
KH
3562011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
357
358 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
359 fill background (Bug#8992).
360
454592a6
MR
3612011-12-13 Martin Rudalics <rudalics@gmx.at>
362
363 * window.c (Vwindow_combination_resize)
364 (Vwindow_combination_limit): Use t instead of non-nil in
365 doc-strings.
61d4b438
MR
366 (Vrecenter_redisplay): Add first sentence of doc-string on
367 separate line.
53524d93 368 (Frecenter): Fix doc-string typo.
454592a6 369
3633e3aa
KH
3702011-12-11 Kenichi Handa <handa@m17n.org>
371
372 * coding.c (Funencodable_char_position): Pay attention to the
373 buffer text relocation (Bug#9389).
374
7b9d523a
JD
3752011-12-10 Jan Djärv <jan.h.d@swipnet.se>
376
377 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
378 gtk_init (Bug#10100).
379
b73189c6
EZ
3802011-12-10 Eli Zaretskii <eliz@gnu.org>
381
382 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
383 IT->string is nil. (Bug#10263)
384
f7dfe5d6
JD
3852011-12-10 Jan Djärv <jan.h.d@swipnet.se>
386
83faebb4
JD
387 * nsterm.h (x_free_frame_resources): Declare.
388
f7dfe5d6
JD
389 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
390 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
391
392 * nsterm.h (ns_get_defaults_value): Declare.
393
394 * nsterm.m (ns_default): Call ns_get_defaults_value.
395
7cd4e72c
EZ
3962011-12-09 Eli Zaretskii <eliz@gnu.org>
397
398 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
399 (Bug#10170)
400
b34d7317
YM
4012011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
402
403 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
404 that where the value of an _OBJC_* symbol points to is in the .bss
405 section (Bug#10240).
406
76470ad1
KH
4072011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
408
409 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 410 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 411
745fff94
KH
4122011-12-08 Kenichi Handa <handa@m17n.org>
413
414 * ftfont.c (get_adstyle_property): Fix previous change
415 (Bug#10233).
416
6e44397c
JB
4172011-12-07 Juanma Barranquero <lekktu@gmail.com>
418
419 * w32.c (init_environment): If no_site_lisp, remove site-lisp
420 dirs from the default value of EMACSLOADPATH (bug#10208).
421
7efa6272
GM
4222011-12-07 Glenn Morris <rgm@gnu.org>
423
424 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
425 installation and source directories as well. (Bug#10208)
426
f6fc4d87
CY
4272011-12-06 Chong Yidong <cyd@gnu.org>
428
429 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
430
2bf26180
GM
4312011-12-06 Glenn Morris <rgm@gnu.org>
432
433 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
434 as an error, not just -1. (Bug#10217)
435
3a6ad4f0
CY
4362011-12-05 Chong Yidong <cyd@gnu.org>
437
438 * keyboard.c (process_special_events): New function.
439 (swallow_events, Finput_pending_p): Use it (Bug#10195).
440
75a3b399
PE
4412011-12-05 Paul Eggert <eggert@cs.ucla.edu>
442
443 * coding.c (encode_designation_at_bol): Don't use uninitialized
444 local variable (Bug#9318).
445
c3c9e25e
KH
4462011-12-05 Kenichi Handa <handa@m17n.org>
447
448 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
449 return Qnil (Bug#8046, Bug#10193).
450
5eb05ea3
KH
4512011-12-05 Kenichi Handa <handa@m17n.org>
452
453 * coding.c (encode_designation_at_bol): New args charbuf_end and
454 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
455 (coding_set_source): Return how many bytes coding->source was
456 relocated.
457 (coding_set_destination): Return how many bytes
458 coding->destination was relocated.
459 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
460 (CODING_CHAR_CHARSET_P): Adjusted for the avove changes.
5eb05ea3
KH
461
4622011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
463
464 * coding.c (CODING_CHAR_CHARSET_P): New macro.
465 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
466 macro (Bug#9318).
467
4682011-12-05 Andreas Schwab <schwab@linux-m68k.org>
469
470 The following changes are to fix Bug#9318.
471
a79703f5 472 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
473 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
474 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 475 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 476
7dbda6df
JB
4772011-12-05 Juanma Barranquero <lekktu@gmail.com>
478
479 * lisp.h (process_quit_flag): Fix external declaration.
480
6d5eb5b0
SM
4812011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
482
483 Don't macro-inline non-performance-critical code.
484 * eval.c (process_quit_flag): New function.
485 * lisp.h (QUIT): Use it.
486
a0c3fad0
JD
4872011-12-04 Jan Djärv <jan.h.d@swipnet.se>
488
489 * nsfns.m (get_geometry_from_preferences): New function.
490 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
491
6c07aac2
AS
4922011-12-04 Andreas Schwab <schwab@linux-m68k.org>
493
494 * emacs.c (Qkill_emacs): Define.
495 (syms_of_emacs): Initialize it.
496 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
497 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
498 (quit_throw_to_read_char): Add parameter `from_signal'.
499 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
500 * lisp.h (QUIT): Call Fkill_emacs if requested.
501
c052ead4
JD
5022011-12-03 Jan Djärv <jan.h.d@swipnet.se>
503
504 * widget.c (update_wm_hints): Return if wmshell is null.
505 (widget_update_wm_size_hints): New function.
506
507 * widget.h (widget_update_wm_size_hints): Declare.
508
509 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
510 widget_update_wm_size_hints (Bug#10104).
511
9e49252b
EZ
5122011-12-03 Eli Zaretskii <eliz@gnu.org>
513
514 * xdisp.c (handle_invisible_prop): If the invisible text ends just
515 before a newline, prepare the bidi iterator for consuming the
516 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 517 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 518
02b16839
JL
5192011-12-02 Juri Linkov <juri@jurta.org>
520
521 * search.c (Fword_search_regexp): New Lisp function created from
522 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
523 (Fword_search_backward, Fword_search_forward)
524 (Fword_search_backward_lax, Fword_search_forward_lax):
525 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
526 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
527
0068070e
SM
5282011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
529
530 * fileio.c (Finsert_file_contents): Move after-change-function call
531 to before the "handled:" label, since all "goto handled" appear in
532 cases where the *-change-functions have already been properly called
533 (bug#10117).
534
3360a3fc
AS
5352011-12-01 Andreas Schwab <schwab@linux-m68k.org>
536
537 * keyboard.c (interrupt_signal): Don't call kill-emacs when
538 waiting for input. (Bug#10169)
539
73d6c093
EZ
5402011-11-30 Eli Zaretskii <eliz@gnu.org>
541
542 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
543 verifies glyph row's hash code--we have just reallocated the
544 glyphs, so their contents can be complete garbage. (Bug#10164)
545
febe6bea
JB
5462011-11-30 Juanma Barranquero <lekktu@gmail.com>
547
548 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
549
801a4313
EZ
5502011-11-30 Eli Zaretskii <eliz@gnu.org>
551
552 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
553 attributes are tested _before_ calling verify_row_hash, to protect
554 against GCC re-ordering of the tests. (Bug#10164)
555
2b56b87e
JD
5562011-11-29 Jan Djärv <jan.h.d@swipnet.se>
557
558 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
559
560 * xterm.c (handle_one_xevent): Only set async_visible and friends
561 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 562 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
563 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
564
dbf31225
PE
5652011-11-28 Paul Eggert <eggert@cs.ucla.edu>
566
567 Remove GCPRO-related macros that exist only to avoid shadowing locals.
568 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
569 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
570 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
571 All uses changed to use GCPRO1 etc.
572 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
573 Revert to old implementation (i.e., before 2011-03-11).
574
1305621b
YM
5752011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
576
577 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
578 of scroll runs so as to avoid assigning disabled bogus rows and
579 unnecessary graphics copy operations.
580
8c9afb46
EZ
5812011-11-27 Eli Zaretskii <eliz@gnu.org>
582
583 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
584 (snprintf) [_MSC_VER]: Redirect to _snprintf.
585 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
586 (malloc, free, realloc, calloc): Redirect to e_* only when
587 compiling Emacs.
588
589 * lisp.h (GCTYPEBITS): Move before first use.
590 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
591 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
592 this macro definition.
593
594 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
595 _MSC_VER.
596
54e9e3bf
JD
5972011-11-27 Jan Djärv <jan.h.d@swipnet.se>
598
6d5eb5b0
SM
599 * gtkutil.c (xg_create_frame_widgets):
600 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
601 present with Gtk+ 2.0.
602
83aca1cb
PE
6032011-11-26 Paul Eggert <eggert@cs.ucla.edu>
604
605 * fileio.c (Finsert_file_contents): Undo previous change; see
606 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
607
5b76caa4
PE
6082011-11-26 Paul Eggert <eggert@cs.ucla.edu>
609
610 Rename locals to avoid shadowing.
611 * fileio.c (Finsert_file_contents):
612 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
613 * process.c (wait_reading_process_output):
614 Rename inner 'proc' to 'p' to avoid shadowing.
615 Indent for consistency with usual Emacs style.
616
8c535114
EZ
6172011-11-25 Eli Zaretskii <eliz@gnu.org>
618
619 * xdisp.c (redisplay_window): If cursor row is not fully visible
620 after recentering, and scroll-conservatively is set to a large
621 number, scroll window by a few more lines to make the cursor fully
622 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
623 (start_display): Don't move to the next line if the display should
624 start at a newline that is part of a display vector or an overlay
625 string. (Bug#10119)
8c535114 626
fa4fdb5c
JL
6272011-11-24 Juri Linkov <juri@jurta.org>
628
629 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
630 after the `MagickPingImage' call. (Bug#10112)
631
90ec88df
CY
6322011-11-23 Chong Yidong <cyd@gnu.org>
633
634 * window.c (Fcoordinates_in_window_p): Accept only live windows.
635
56e2e794
MR
6362011-11-23 Martin Rudalics <rudalics@gmx.at>
637
638 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
639 making another buffer current. (Bug#10114)
640
b6e64c41
GM
6412011-11-23 Glenn Morris <rgm@gnu.org>
642
643 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
644
6b21de18
CY
6452011-11-23 Chong Yidong <cyd@gnu.org>
646
647 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
648 using it (Bug#5984).
649
b12cd789
EZ
6502011-11-22 Eli Zaretskii <eliz@gnu.org>
651
652 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
653 and header-lines, as they don't have one computed for them.
654 (Bug#10098)
655
656 * .gdbinit (prow): Make displayed values more self-explaining.
657 Add row's hash code.
658
261b6fd4
LMI
6592011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
660
661 * process.c (wait_reading_process_output): Fix asynchrounous
662 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 663 (wait_reading_process_output): Add comment and URL.
261b6fd4 664
e7cfd277
JD
6652011-11-21 Jan Djärv <jan.h.d@swipnet.se>
666
667 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
668
a9b9b7f5
CY
6692011-11-21 Chong Yidong <cyd@gnu.org>
670
671 * window.c (Fnext_window, Fprevious_window): Doc fix.
672
b0d15b4f
SM
6732011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
674
675 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
676
fe7a3057
JB
6772011-11-20 Juanma Barranquero <lekktu@gmail.com>
678
679 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
680
d2999b1a
MR
6812011-11-20 Martin Rudalics <rudalics@gmx.at>
682
683 * window.c (Fset_window_combination_limit): Rename argument
684 STATUS to LIMIT.
685 (Vwindow_combination_limit): Remove "status" from doc-string.
686
d5ff9cd0
AS
6872011-11-20 Andreas Schwab <schwab@linux-m68k.org>
688
689 * m/ibms390.h: Remove.
690 * m/ibms390x.h: Don't include "ibms390.h".
691
a5bb9bd3
SM
6922011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
693
694 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
695 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
696
cd1181db
JB
6972011-11-20 Juanma Barranquero <lekktu@gmail.com>
698
699 * casetab.c (Fset_case_table):
700 * charset.c (Fcharset_after): Fix typos.
701
615a3b8d 7022011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 703
17e845af
PE
704 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
705 Otherwise, valgrind does not work on some platforms.
706 Problem reported by Andreas Schwab in
6a0bf43d
PE
707 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
708 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
709 is set, removing the need for VIRT_ADDRESS_VARIES.
710 (PURE_P): Use a more-efficient implementation that needs just one
711 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
712 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
713 to 4 (xorl, subq, cmpq, setbe).
714 * alloc.c (pure): Always extern now, since that's the
715 VIRT_ADDR_VARIES behavior.
716 (PURE_POINTER_P): Use a single comparison, not two, for
717 consistency with the new puresize.h.
718 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
719 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
720 Remove VIRT_ADDR_VARIES no longer needed.
721
f8fe6f96
EZ
7222011-11-19 Eli Zaretskii <eliz@gnu.org>
723
724 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
725 (erase_phys_cursor, update_window_cursor, show_mouse_face)
726 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
727 behave as if the cursor position were at the window margin.
728
729 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
730 and the cursor position is out of bounds, behave as if the cursor
731 position were at the window margin. (Bug#10075)
732
df05a53c
CY
7332011-11-18 Chong Yidong <cyd@gnu.org>
734
735 * window.c (Fwindow_combination_limit): Make first argument
736 non-optional, since it is meaningless for live windows like the
737 selected window.
738
2071918e
DA
7392011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
740
741 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
742
b50a28de
SM
7432011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
744
745 * intervals.c: Fix grafting over the whole buffer (bug#10071).
746 (graft_intervals_into_buffer): Simplify.
747
015137db
EZ
7482011-11-18 Eli Zaretskii <eliz@gnu.org>
749
750 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
751 hash values of the two rows.
752 (copy_row_except_pointers): Preserve the used[] arrays and the
753 hash values of the two rows. (Bug#10035)
68c95424 754 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
755
756 * xdisp.c (row_hash): New function, body extracted from
757 compute_line_metrics.
758 (compute_line_metrics): Call row_hash, instead of computing the
759 hash code inline.
760
761 * dispnew.c (verify_row_hash): Call row_hash for computing the
762 hash code of a row, instead of duplicating code from xdisp.c.
763
764 * dispextern.h (row_hash): Add prototype.
765
a2addb04
TH
7662011-11-18 Tassilo Horn <tassilo@member.fsf.org>
767
768 * frame.c (delete_frame): Don't delete the terminal when the last
769 X frame is closed if emacs is built with GTK toolkit.
770
df85d315
JB
7712011-11-17 Juanma Barranquero <lekktu@gmail.com>
772
773 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
774
a0c2d0ae
MR
7752011-11-17 Martin Rudalics <rudalics@gmx.at>
776
777 * window.c (Vwindow_splits): Rename to
778 Vwindow_combination_resize. Suggested by Juri Linkov.
779 (Fsplit_window_internal): Use Vwindow_combination_resize instead
780 of Vwindow_splits.
781
58179cce
JB
7822011-11-16 Juanma Barranquero <lekktu@gmail.com>
783
7877f373
JB
784 * nsfns.m (Fns_font_name):
785 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 786
b6f67890
MR
7872011-11-16 Martin Rudalics <rudalics@gmx.at>
788
789 * window.h (window): Rename slot "nest" to "combination_limit".
790 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
791 (Fset_window_nest): Rename to Fset_window_combination_limit.
792 (Vwindow_nest): Rename to Vwindow_combination_limit.
793 (recombine_windows, make_parent_window, make_window)
794 (Fsplit_window_internal, saved_window)
795 (Fset_window_configuration, save_window_save): Rename all
796 occurrences of window_nest to window_combination_limit.
797
c7015153
JB
7982011-11-15 Juanma Barranquero <lekktu@gmail.com>
799
800 * image.c (imagemagick_load_image): Fix typo.
801
322ad6ec
EZ
8022011-11-14 Eli Zaretskii <eliz@gnu.org>
803
804 * xdisp.c (display_line): Move the call to
805 highlight_trailing_whitespace before the call to
806 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
807 faces of all the glyphs to compute ROW's hash value.
808 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 809
f067b8ec
JB
8102011-11-14 Juanma Barranquero <lekktu@gmail.com>
811
812 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
813 just return (bug#10044).
814
1e5b2111
EZ
8152011-11-12 Eli Zaretskii <eliz@gnu.org>
816
7ef3cbd5
EZ
817 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
818 with user-defined heap size. Bump the default size of the temacs
819 heap to 27MB, to avoid memory warning when running temacs.
820 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
821
1e5b2111
EZ
822 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
823 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
824 (verify_row_hash) [XASSERTS]: New function.
825 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
826 that the hash value of glyph rows is correct.
1e5b2111 827
89d61221
MR
8282011-11-12 Martin Rudalics <rudalics@gmx.at>
829
830 * window.h (window): Remove splits slot.
831 * window.c (Fwindow_splits, Fset_window_splits): Remove.
832 (Fdelete_other_windows_internal, make_parent_window)
833 (make_window, Fsplit_window_internal, Fdelete_window_internal)
834 (Fset_window_configuration, save_window_save): Don't deal with
835 split status of windows.
836 (saved_window): Remove splits slot.
837 (Vwindow_splits): Rewrite doc-string.
838
97f18cc8
JD
8392011-11-11 Jan Djärv <jan.h.d@swipnet.se>
840
841 * xfns.c (unwind_create_frame):
842 * nsfns.m (unwind_create_frame):
843 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
844 Vframe_list (Bug#9999).
845
22a648b4
DA
8462011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
847
0b381c7e 848 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 849
659afede
KH
8502011-11-11 Kenichi Handa <handa@m17n.org>
851
852 * callproc.c (Fcall_process): Set the member dst_multibyte of
853 process_coding.
854
9ac0394b
KH
8552011-11-11 Johan Bockgård <bojohan@gnu.org>
856
857 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
858 avoid a crash (bug#9496).
859
2fbdc249
CY
8602011-11-09 Chong Yidong <cyd@gnu.org>
861
862 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
863 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
864
ac6b1f81
PE
8652011-11-08 Paul Eggert <eggert@cs.ucla.edu>
866
867 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
868
09db192c
PE
8692011-11-08 Paul Eggert <eggert@cs.ucla.edu>
870
871 Avoid some portability problems by eschewing 'extern inline' functions.
872 The trivial performance wins aren't worth the portability hassles; see
873 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
874 et seq.
875 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
876 (window_box_width, window_box_left, window_box_left_offset)
877 (window_box_right, window_box_right_offset): Undo previous change,
878 by removing the "extern"s.
879 * intervals.c (adjust_intervals_for_insertion)
880 (adjust_intervals_for_deletion): Undo previous change,
881 making these static again.
882 (offset_intervals, temp_set_point_both, temp_set_point)
883 (copy_intervals_to_string): No longer inline.
884 * xdisp.c (window_text_bottom_y, window_box_width)
885 (window_box_height, window_box_left_offset)
886 (window_box_right_offset, window_box_left, window_box_right)
887 (window_box): No longer inline.
888
105216ed
CY
8892011-11-08 Chong Yidong <cyd@gnu.org>
890
891 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
892 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
893 Signal an error if not a live window.
105216ed
CY
894 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
895 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
896
ae9e237f
JB
8972011-11-07 Juanma Barranquero <lekktu@gmail.com>
898
899 * lisp.h (syms_of_abbrev): Remove declaration.
900 Reported by CHENG Gao <chenggao@royau.me>.
901
c7aa8333
EZ
9022011-11-07 Eli Zaretskii <eliz@gnu.org>
903
904 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
905 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
906 of temacs in GUI mode.
907
be7f5545
MR
9082011-11-07 Martin Rudalics <rudalics@gmx.at>
909
910 * window.h: Declare delete_all_child_windows instead of
911 delete_all_subwindows.
912 * window.c (Fwindow_nest, Fset_window_nest)
913 (Fset_window_new_total, Fset_window_new_normal)
914 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
915 (delete_all_subwindows): Rename to delete_all_child_windows.
916 (Fdelete_other_windows_internal, Fset_window_configuration):
917 Call delete_all_child_windows instead of delete_all_subwindows.
918 * frame.c (delete_frame): Call delete_all_child_windows instead
919 of delete_all_subwindows.
920
ca78dc43
PE
9212011-11-07 Paul Eggert <eggert@cs.ucla.edu>
922
923 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
924 This is also needed for porting to any host where GC_MARK_STACK is
925 not GC_MAKE_GCPROS_NOOPS.
926 (which_symbols): Use it.
927
a0241d01
KH
9282011-11-07 Kenichi Handa <handa@m17n.org>
929
930 * coding.c (coding_set_destination): Check coding->src_pos only
931 when coding->src_object is a buffer (bug#9910).
932
933 * process.c (send_process): Set the member src_multibyte of coding
934 to 0 (bug#9911) when sending a unibyte text.
935
936 * callproc.c (Fcall_process): Set the member src_multibyte of
937 process_coding to 0 (bug#9912).
938
a64bfdfa 9392011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
940
941 * xmenu.c (cleanup_widget_value_tree): New function.
942 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
943 calling free_menubar_widget_value_tree directly (Bug#9830).
944
cb41b32a
PE
9452011-11-06 Paul Eggert <eggert@cs.ucla.edu>
946
947 Fix some portability problems with 'inline'.
948 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
949 (window_box_width, window_box_left, window_box_left_offset)
950 (window_box_right, window_box_right_offset): Declare extern.
951 Otherwise, these inline functions do not conform to C99 and
952 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
953 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
954 * intervals.c (adjust_intervals_for_insertion)
955 (adjust_intervals_for_deletion): Now extern, because otherwise the
956 extern inline functions 'offset_intervals' couldn't refer to it.
957 (static_offset_intervals): Remove.
958 (offset_intervals): Rewrite using the old contents of
959 static_offset_intervals. The old version didn't conform to C99
960 because an extern inline function contained a reference to an
961 identifier with static linkage.
962
b7041366
AS
9632011-11-06 Andreas Schwab <schwab@linux-m68k.org>
964
965 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
966 GC.
967
88a37c4d
EZ
9682011-11-06 Eli Zaretskii <eliz@gnu.org>
969
970 * xdisp.c (init_iterator, reseat_to_string): Don't set the
971 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
972 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
973 return Qleft_to_right.
974
49745b39
CY
9752011-11-06 Chong Yidong <cyd@gnu.org>
976
977 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
978 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
979 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
980 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
981 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
982 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
983 (Fwindow_vscroll): Doc fix.
984 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
985 argument, since it makes no sense to pass a live window and for
986 consistency with window-child.
987
1f05cd82
CS
9882011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
989
990 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
991 support MSVC.
992
22610910
JR
9932011-11-05 Jason Rumney <jasonr@gnu.org>
994
995 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
996 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
997 fonts (Bug#6029).
998 (add_font_entity_to_list): Fix logic errors in mixed boolean and
999 bitwise arithmetic preventing use of unicode-sip and non-truetype
1000 opentype fonts.
1001
a06776b2
EZ
10022011-11-05 Eli Zaretskii <eliz@gnu.org>
1003
3ad924ba
EZ
1004 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1005 "emacs"-only part.
1006
a06776b2
EZ
1007 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1008 initialization code to keep similarity to xfns.c after changes
1009 from 2011-11-05.
1010
c9e7db78
JD
10112011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1012
a97f8f3f
JD
1013 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1014 (unwind_create_frame): New function (Bug#9943).
1015 (Fx_create_frame): Restructure code to be more similar to the one in
1016 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1017 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1018 Move terminal->reference_count++ just before making the frame official
1019 (Bug#9943).
1020
1021 * nsterm.m (x_free_frame_resources): New function.
1022 (x_destroy_window): Move code to x_free_frame_resources.
1023
c9e7db78 1024 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
1025 (Fx_create_frame, x_create_tip_frame):
1026 Move terminal->reference_count++ just before making the frame
c9e7db78
JD
1027 official. Move initialization of image_cache_refcount and
1028 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1029
a6fc3b5c
EZ
10302011-11-05 Eli Zaretskii <eliz@gnu.org>
1031
1032 Support MSVC build with newer versions of Visual Studio.
1033 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1034 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1035 nt/gmake.defs.
1036
1037 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1038 which are not supported by MSVC.
1039 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1040 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1041 bitfields.
1042 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1043 types in bitfields.
1044 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1045
1046 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1047
58179cce 10482011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
1049
1050 Support MSVC build with newer versions of Visual Studio.
1051 * w32.c: Don't include w32api.h for MSVC.
1052 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1053
1054 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1055 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1056 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1057 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1058 e_* cousins.
1059 (alloca) [_MSC_VER]: Define to _alloca.
1060
1061 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1062
1063 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1064
a58c13ed
EZ
10652011-11-04 Eli Zaretskii <eliz@gnu.org>
1066
1067 * xdisp.c (note_mouse_highlight): If either of
1068 previous/next-single-property-change returns nil, treat that as
1069 the beginning or the end of the buffer. (Bug#9955)
1070
fe0b6370
JD
10712011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1072
a58c13ed 1073 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
1074 label is not null (Bug#9951).
1075 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1076 may be NULL.
1077
89bd5ee1
EZ
10782011-11-04 Eli Zaretskii <eliz@gnu.org>
1079
1080 * window.c (Fwindow_body_size): Mention in the doc string that the
1081 return value is in frame's canonical units. (Bug#9949)
1082
84c3edb9
EZ
10832011-11-03 Eli Zaretskii <eliz@gnu.org>
1084
4e2fb5c7
EZ
1085 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1086
84c3edb9 1087 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 1088 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 1089 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 1090
bc17a887
EZ
10912011-11-01 Eli Zaretskii <eliz@gnu.org>
1092
1093 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1094 Don't stop backward scan on the continuation glyph, even though
1095 its CHARPOS is positive.
6d5eb5b0
SM
1096 (mouse_face_from_buffer_pos, note_mouse_highlight):
1097 Rename cover_string to disp_string.
bc17a887 1098
4ee88440
MR
10992011-11-01 Martin Rudalics <rudalics@gmx.at>
1100
1101 * window.c (temp_output_buffer_show): Don't use
1102 Vtemp_buffer_show_specifiers.
1103 (Vtemp_buffer_show_specifiers): Remove unused variable.
1104
c2ff3c02
EZ
11052011-10-30 Eli Zaretskii <eliz@gnu.org>
1106
1107 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1108 past the beginning of the current glyph matrix.
1109
58179cce 11102011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
1111
1112 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1113 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1114 HAVE_GTK3 (Bug#9869).
b77a6a7f 1115
3b574623
JD
1116 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1117 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1118
b77a6a7f
JD
1119 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1120
1121 * xterm.c: Declare x_handle_net_wm_state to return int.
1122 (handle_one_xevent): Check if we are iconified but don't have
1123 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1124 (get_current_wm_state): Return non-zero if not hidden,
1125 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1126 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1127 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1128 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1129
196e41e4
PE
11302011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1131
1132 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1133 so that this new function doesn't get optimized away by a
1134 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1135
021f2e1a
AS
11362011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1137
1138 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1139
8b058d44
EZ
11402011-10-29 Eli Zaretskii <eliz@gnu.org>
1141
1142 Fix the `xbytecode' command.
1143 * .gdbinit (xprintbytestr): New command.
b50a28de 1144 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
1145 (xbytecode): Print the byte-code string as well.
1146
4452fb80
EZ
11472011-10-29 Kim Storm <storm@cua.dk>
1148
8b058d44
EZ
1149 * alloc.c (which_symbols): New function.
1150
21b72067
AS
11512011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1152
1153 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1154 line. (Bug#9903)
1155
83ed7b5c
GM
11562011-10-29 Glenn Morris <rgm@gnu.org>
1157
1158 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1159 Not clear what it was for, and it causes various bugs. (Bug#9839)
1160
5a7a728b
EZ
11612011-10-28 Eli Zaretskii <eliz@gnu.org>
1162
1163 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1164 possible random value that matches one of those tested as
1165 condition to clear the mouse face.
1166
d3d0842f
CY
11672011-10-28 Chong Yidong <cyd@gnu.org>
1168
1169 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1170
31b39d13
DN
11712011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1172
1173 * window.c (make_window): Initialize phys_cursor_on_p.
1174
9aba6043
SM
11752011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1176
1177 * lisp.h (struct Lisp_Symbol): Update comments.
1178
c20992f4
JB
11792011-10-28 Juanma Barranquero <lekktu@gmail.com>
1180
1181 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1182
db4f02f2
EZ
11832011-10-28 Eli Zaretskii <eliz@gnu.org>
1184
1185 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1186 <oslsachem@gmail.com> for helping to debug this.
1187
1188 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1189 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1190 (g_b_init_get_glyph_outline_w): New static variables.
1191 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1192 (GetGlyphOutlineW_Proc): New typedefs.
1193 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
1194 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1195 New functions.
1196 (w32font_open_internal, compute_metrics):
1197 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
1198 instead of calling the "wide" APIs directly.
1199
1200 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1201
1202 * w32.h (syms_of_w32font): Add prototype.
1203
87e68db4
JB
12042011-10-27 Juanma Barranquero <lekktu@gmail.com>
1205
1206 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1207 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1208 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1209 (Fmove_to_window_line): Doc fix.
1210
435c1d67
CY
12112011-10-27 Chong Yidong <cyd@gnu.org>
1212
1213 * process.c (make_process): Set gnutls_state to NULL.
1214
1215 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1216 non-NULL, regardless of GNUTLS_INITSTAGE.
1217 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1218 an error. Set process slots as soon as we allocate them.
1219
1220 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1221
9c6c6f49
CY
12222011-10-27 Chong Yidong <cyd@gnu.org>
1223
9aba6043
SM
1224 * gnutls.c (emacs_gnutls_deinit): New function.
1225 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
1226 (Fgnutls_deinit, Fgnutls_boot): Use it.
1227
1228 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1229 (deactivate_process): Call emacs_gnutls_deinit.
1230
657d08d3
JB
12312011-10-27 Juanma Barranquero <lekktu@gmail.com>
1232
1233 * image.c (x_create_x_image_and_pixmap):
1234 * w32.c (sys_rename, w32_delayed_load):
1235 * w32font.c (fill_in_logfont):
1236 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1237
5430d399
JB
12382011-10-26 Juanma Barranquero <lekktu@gmail.com>
1239
1240 * w32fns.c (w32_default_color_map): New function,
1241 extracted from Fw32_default_color_map.
a7ef684b 1242 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 1243
fe0055fa
PE
12442011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1245
1246 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1247
e6346438
SM
12482011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1249
1250 * keyboard.c (test_undefined): New function (bug#9751).
1251 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1252
e112cc37
ET
12532011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1254
1255 * sysdep.c (init_sys_modes): Fix the check for the controlling
1256 terminal (Bug#6649).
1257
7b5d6677
EZ
12582011-10-20 Eli Zaretskii <eliz@gnu.org>
1259
1260 * dispextern.h (struct bidi_it): New member next_en_type.
1261
1262 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1263 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1264 current character, check also for next_en_type being WEAK_EN.
1265 (bidi_resolve_weak): Don't enter the expensive loop if the current
1266 position is before next_en_pos. Record the bidi type of the first
1267 non-ET, non-BN character we find, in addition to its position.
1268 (bidi_level_of_next_char): Invalidate next_en_type when
1269 next_en_pos is over-stepped.
1270
7da0b018
PE
12712011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1272
1273 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1274 * editfns.c: Rewrite current-time-zone so that it invokes
1275 the equivalent of (format-time-string "%Z") to get the time zone name.
1276 This fixes a bug when the time zone name contains characters that
1277 need converting from the system time locale to Emacs internal format.
1278 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1279 that patch fixed format-time-string to do the conversion, but
1280 I forgot to fix current-time-zone.
1281 (format_time_string): New function, containing most of
1282 what Fformat_time_string used to contain.
1283 (Fformat_time_string): Rewrite in terms of format_time_string.
1284 This doesn't change this function's behavior.
1285 (current-time-zone): Rewrite to use format_time_string.
1286 This fixes the bug reported by Michael Schierl in
1287 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1288 Jason Rumney's 2007-06-07 change worked around this bug, but
1289 didn't fix it.
1290 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1291
8547b010
EZ
12922011-10-19 Eli Zaretskii <eliz@gnu.org>
1293
1294 * xdisp.c (start_display): If the character at POS is displayed
1295 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
1296 (try_window_reusing_current_matrix): If a line ends in a display
1297 vector or the next line starts in a display vector, continue
1298 redrawing the window even though the character position of
1299 start_row was reached.
8547b010
EZ
1300 (Bug#9771, part 2)
1301
4e948d15
CY
13022011-10-18 Chong Yidong <cyd@gnu.org>
1303
1304 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1305 with nobreak-char-display too.
1306
4787455f
EZ
13072011-10-18 Eli Zaretskii <eliz@gnu.org>
1308
1309 Fix part 3 of bug#9771.
1310 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1311 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1312 non-neutral characters if the current character is a paragraph
1313 separator (a.k.a. Newline). This avoids running the same
1314 expensive loop twice, once when we consume the preceding newline
1315 and the other time when the line actually needs to be displayed.
1316 Avoid the loop when we see neutrals on the base embedding level
1317 following a character whose directionality is the same as the
1318 paragraph's. This avoids running the expensive loop when a line
1319 ends in a long sequence of neutrals, like control characters.
1320 Add assertion against STRONG_AL type. Slightly rearrange code
1321 that determines the type of a neutral given the first non-neutral
1322 that follows it.
1323 (bidi_level_of_next_char): Set next_en_pos to zero when
1324 invalidating its info.
1325
2c91f553
EZ
13262011-10-17 Eli Zaretskii <eliz@gnu.org>
1327
1328 * xdisp.c (push_display_prop): Determine whether to record string
1329 or buffer position by IT->string, not by IT->method. Allow
1330 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
1331 (move_it_vertically_backward): Don't look for character position
1332 immediately after the newline when in a continuation line.
1333 (Bug#9771, part 1)
2c91f553 1334
c7b08b0d
MR
13352011-10-15 Martin Rudalics <rudalics@gmx.at>
1336
1337 * window.c (coordinates_in_window): Rewrite and delabelize
1338 vertical border check. (Bug#5357) (Bug#9618)
1339
6b02f655
SM
13402011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1341
1342 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1343 errors in XSetWindowBorder (bug#9310).
1344
81d40c92
DA
13452011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1346
1347 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1348 avoid crash when xmalloc overrun checking is enabled.
1349
d4172c3b
EZ
13502011-10-13 Eli Zaretskii <eliz@gnu.org>
1351
1352 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1353 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1354 cursor motion with <left> and <right> arrow keys.
1355
1356 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1357 some callers set that themselves.
1358
b00eea75
EZ
13592011-10-12 Eli Zaretskii <eliz@gnu.org>
1360
1361 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1362 display string and the previous row comes from the same string and
1363 is empty. (Bug#9739) (Bug#9738)
1364
8fe012c4
SM
13652011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1366
1367 * doc.c (get_doc_string): Encode file name (bug#9735).
1368
0074aef2
EZ
13692011-10-12 Eli Zaretskii <eliz@gnu.org>
1370
79beb178
EZ
1371 * bidi.c (bidi_level_of_next_char):
1372 * xdisp.c (get_visually_first_element): Remove old incorrect
1373 comments regarding the Unicode Line Separator character.
1374
0074aef2
EZ
1375 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1376
6e4b3fbe
DA
13772011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1378
1379 * alloc.c (Fgc_status): Do not access beyond zombies array
1380 boundary if nzombies > MAX_ZOMBIES.
1381 * alloc.c (dump_zombies): Add missing format specifier.
1382
0324f3af
PE
13832011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1384
b5525cac
PE
1385 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1386 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1387
0324f3af
PE
1388 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1389 Some packages use them to denote characters with modifiers.
1390
e9b5f888
AS
13912011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1392
1393 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1394 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1395 matching a pp-number. Rename parameter var to var1.
1396
127827c0
SM
13972011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1398
1399 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1400
c8fd3bd0
GM
14012011-10-08 Glenn Morris <rgm@gnu.org>
1402
1403 * callint.c (Fcall_interactively): Give a more explicit error for the
1404 'c' case with a non-character input. (Bug#8479)
1405
352ec8ff
EZ
14062011-10-08 Eli Zaretskii <eliz@gnu.org>
1407
03669ccb
EZ
1408 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1409 lines.
7061c986
EZ
1410 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1411 lines that are hscrolled on the left.
03669ccb 1412
352ec8ff
EZ
1413 * dispnew.c (buffer_posn_from_coords): Account for a possible
1414 presence of header-line. (Bug#4426)
1415
a66cfb1c
SM
14162011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1417
6b02f655
SM
1418 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1419 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 1420
7c5ee88e
PE
14212011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1422
1423 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1424 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1425 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1426 this makes Emacs dump core during garbage collection on rare
1427 occasions. sizeof is obviously inferior to offsetof here, so
1428 stick with offsetof.
1429 (GC_POINTER_ALIGNMENT): New macro.
1430 (mark_memory): Omit 3rd (offset) arg; caller changed.
1431 Don't assume EMACS_INT alignment is the same as pointer alignment.
1432
df1bbe5b
SM
14332011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1434
1435 * keyboard.c (read_key_sequence_remapped): New var.
1436 (read_key_sequence): Compute remapping in the right buffer.
1437 (command_loop_1): Use read_key_sequence's remapping directly.
1438
51553db6
SM
14392011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1440
32c1fffd
SM
1441 * dired.c (file_name_completion): Don't expand file name.
1442 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1443 before checking file name handler.
1444
51553db6
SM
1445 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1446 they've been requested explicitly (bug#9591).
1447
b6bd1599 14482011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
1449
1450 * keymap.c (Fsingle_key_description): Use make_specified_string
1451 instead of build_string to build string from push_key_description.
1452 (Bug#5193)
1453
f701dc2a
PE
14542011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1455
4222c55d
PE
1456 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1457 This fixes a Y2038 bug on 64-bit hosts.
1458 * buffer.c (reset_buffer):
1459 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1460 (Fclear_buffer_auto_save_failure):
1461 Use 0, not -1, to represent an unset failure time, since time_t
1462 might not be signed.
1463
f701dc2a
PE
1464 Remove dependency on glibc malloc internals.
1465 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1466 Move back here from lisp.h, but with their new implementations.
1467 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1468 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1469 * charset.c (charset_table_init): New static var.
1470 (syms_of_charset): Use it instead of xmalloc. This removes a
1471 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1472 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1473 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1474 Move back to alloc.c.
1475 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1476 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1477
9ceebf39
JD
14782011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1479
1480 * nsterm.m (windowDidResize): Call x_set_window_size only when
1481 ns_in_resize is true. Otherwise set pixelwidth/height and
1482 call change_frame_size (Bug#9628).
1483
cb993c58
PE
14842011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1485
3930c88b
PE
1486 Port --enable-checking=all to Fedora 14 x86-64.
1487 * charset.c (syms_of_charset): Also account for glibc malloc's
1488 internal overhead when calculating the initial malloc maximum.
1489
cb993c58
PE
1490 Port --enable-checking=all to Fedora 14 x86.
1491 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1492 Move to lisp.h.
1493 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1494 (overrun_check_realloc, overrun_check_free):
1495 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1496 That way, xmalloc returns a properly-aligned pointer even if
1497 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1498 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1499 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1500 into account when calculating the initial malloc maximum.
1501 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1502 Move here from alloc.c, so that charset.c can use it too.
1503 Properly align; the old code wasn't right for common 32-bit hosts
1504 when configured with --enable-checking=all.
1505 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1506 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1507
31bed486
EZ
15082011-09-29 Eli Zaretskii <eliz@gnu.org>
1509
04c70788 1510 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
1511 use EDOM.
1512
fbcaa2f3
EZ
15132011-09-28 Eli Zaretskii <eliz@gnu.org>
1514
1515 * xdisp.c (compute_display_string_end): If there's no display
1516 string at CHARPOS, return -1.
1517
1518 * bidi.c (bidi_fetch_char): When compute_display_string_end
1519 returns a negative value, treat the character as a normal
1520 character not covered by a display string. (Bug#9624)
1521
a239d4e9
JB
15222011-09-28 Juanma Barranquero <lekktu@gmail.com>
1523
1524 * lread.c (Fread_from_string): Fix typo in docstring.
1525
88652fd5
EZ
15262011-09-27 Eli Zaretskii <eliz@gnu.org>
1527
1528 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1529 newline, reseat the iterator instead of bidi-iterating there one
1530 character at a time. (Bug#9610)
32c1fffd
SM
1531 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1532 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 1533
ed497dd4
AS
15342011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1535
1536 * lread.c (readevalloop): Use correct code for NBSP.
1537 (read1): Likewise. (Bug#9608)
1538
b2bf61aa
MA
15392011-09-25 Michael Albinus <michael.albinus@gmx.de>
1540
1541 * dbusbind.c (Fdbus_register_signal): When service is not
1542 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1543
32bbb17c
GM
15442011-09-25 Glenn Morris <rgm@gnu.org>
1545
1546 * buffer.c (truncate-lines): Doc fix.
1547
94e0933e
CY
15482011-09-24 Chong Yidong <cyd@stupidchicken.com>
1549
1550 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1551 (Fset_window_next_buffers): Doc fix.
1552
cddde921
GM
15532011-09-24 Glenn Morris <rgm@gnu.org>
1554
1555 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1556
1260aef1
PE
15572011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1558
25b4bfa0
PE
1559 Fix minor problems found by static checking.
1560 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
1561 * indent.c (Fvertical_motion): Fix == vs = typo.
1562
e3cbd34b
EZ
15632011-09-24 Eli Zaretskii <eliz@gnu.org>
1564
a66cfb1c
SM
1565 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1566 Default value is now t. Doc fix.
6bf7006f 1567
e3cbd34b 1568 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 1569 logic when moving up, not only when moving down. Fix the
e3cbd34b 1570 confusing name and values of the it_overshoot_expected variable;
32c1fffd 1571 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
1572
1573 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1574 CHARPOS is covered by a display string which includes newlines.
1575 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1576 is covered by a display string with embedded newlines.
1577
a3de0cbd
MA
15782011-09-24 Michael Albinus <michael.albinus@gmx.de>
1579
1580 * dbusbind.c (Fdbus_register_signal): Add match rule to
1581 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
1582 (Fdbus_register_method, Vdbus_registered_objects_table):
1583 Fix docstring.
a3de0cbd 1584
b260039d
JM
15852011-09-24 Jim Meyering <meyering@redhat.com>
1586
32c1fffd 1587 do not ignore write error for any output size
b260039d
JM
1588 The previous change was incomplete.
1589 While it makes emacs --batch detect the vast majority of stdout
1590 write failures, errors were still ignored whenever the output size is
1591 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1592 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1593 && echo FAIL: ignored write error
1594 FAIL: ignored write error
1595 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1596 && echo FAIL: ignored write error
1597 FAIL: ignored write error
1598 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1599
8eca8a7c
AS
16002011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1601
1602 * emacs.c (Fkill_emacs): In noninteractive mode exit
1603 non-successfully if a write error occurred on stdout. (Bug#9574)
1604
3341db62
EZ
16052011-09-21 Eli Zaretskii <eliz@gnu.org>
1606
1607 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1608 the xassert test.
1609
1610 * dispextern.h (struct it): Update the comment documenting what
1611 can it->OBJECT be.
1612
8c203dbf
EZ
16132011-09-20 Eli Zaretskii <eliz@gnu.org>
1614
1615 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1616 a display string, extend search for cursor position to end of row.
1617 (find_row_edges): If the row ends in a newline from a display
1618 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1619 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
1620 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1621 non-empty line. Fixes confusing cursor motion with arrow keys at
1622 the beginning of a line that starts with whitespace.
8c203dbf 1623
a4824228
LMI
16242011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1625
1626 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1627 (bug#9493).
1628
33ed493b
CY
16292011-09-18 Chong Yidong <cyd@stupidchicken.com>
1630
1631 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1632 boolean (Bug#9154).
1633
56cd55c8
EZ
16342011-09-18 Eli Zaretskii <eliz@gnu.org>
1635
1636 * xdisp.c (display_line): Record maximum and minimum buffer
1637 positions even if no glyphs were produced (e.g., by a zero-width
1638 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1639 buffer positions that will be removed from the glyph row because
1640 they don't fit.
c02dcedf
EZ
1641 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1642 column is beyond frame width: don't subtract 1 "pixel" when
1643 computing width of the stretch.
3e62b7e0
EZ
1644 (reseat_at_next_visible_line_start): Undo the change made on
1645 2011-09-17 that saved paragraph information and restored it after
1646 the call to `reseat'. (Bug#9545)
56cd55c8 1647
5ed99d36 16482011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
1649
1650 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1651 and turn window cursor on if cleared (Bug#9415).
1652
5ed99d36 16532011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
1654
1655 * search.c (boyer_moore): Take unibyte characters from pattern
1656 literally. (Bug#9458)
1657
9bade7b2
EZ
16582011-09-18 Eli Zaretskii <eliz@gnu.org>
1659
1660 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1661
e5e9d610
PE
16622011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1663
87e4427a
PE
1664 Fix minor problem found by static checking.
1665 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1666 initialized, to pacify gcc -Wuninitialized.
1667
e5e9d610
PE
1668 * fileio.c: Report proper errno when syscall falls.
1669 (Finsert_file_contents): Save and restore errno,
1670 so that report_file_error outputs the correct diagnostic.
1671 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1672
a1674f0b
EZ
16732011-09-18 Eli Zaretskii <eliz@gnu.org>
1674
1675 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1676
fbfb6dd4
EZ
16772011-09-17 Eli Zaretskii <eliz@gnu.org>
1678
1679 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1680 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1681
bb187662
EZ
16822011-09-17 Eli Zaretskii <eliz@gnu.org>
1683
1137e8b8 1684 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 1685 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
1686
1687 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1688 (bidi_find_paragraph_start): Search back for paragraph beginning
1689 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1690 (bidi_move_to_visually_next): Only trigger paragraph-related
1691 computations when the last character is a newline or at EOB, not
1692 just any NEUTRAL_B. (Bug#9470)
1693
bb187662
EZ
1694 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1695 truncated lines if point is covered by a display string. (Bug#9524)
1696
2e621251
PE
16972011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1698
1699 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1700 (cons_to_x_long): New function.
1701 (lisp_data_to_selection_data): Use it. Correct the test for
1702 short-versus-long data; it was negated. Break out of vector
1703 loop, for efficiency, when a long datum is discovered.
1704
91a15bc6
SM
17052011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1706
1707 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1708
b41c3a35
EZ
17092011-09-16 Eli Zaretskii <eliz@gnu.org>
1710
1711 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1712 GCC PR/17406) by declaring this function with external scope.
1713
7812ba2d
PE
17142011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1715
1716 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1717 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1718
cf7edc2a
AS
17192011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1720
1721 * editfns.c (Fformat): Correctly handle text properties on "%%".
1722
bd01620e
EZ
17232011-09-15 Eli Zaretskii <eliz@gnu.org>
1724
1725 * xterm.c (x_draw_composite_glyph_string_foreground):
1726 * w32term.c (x_draw_composite_glyph_string_foreground):
1727 * term.c (encode_terminal_code):
1728 * composite.c (composition_update_it, get_composition_id):
1729 * xdisp.c (get_next_display_element)
1730 (fill_composite_glyph_string): Add comments about special meaning
1731 of TAB characters in a composition.
1732
a02719a3
PE
17332011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1734
1735 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
1736 This occurs when processing a multibyte format.
1737 Problem reported by Wolfgang Jenker.
a02719a3 1738
72589a3c
JB
17392011-09-15 Johan Bockgård <bojohan@gnu.org>
1740
1741 * xdisp.c (try_cursor_movement): Only check for exact match if
1742 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1743
1c14176c
PE
17442011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1745
1746 Remove unused external symbols.
1747 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1748 * xdisp.c (calc_pixel_width_or_height): Now static.
1749 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1750 * indent.c (check_display_width):
1751 * w32term.c: Fix comment to match code.
1752 * xterm.c, xterm.h (x_catching_errors): Remove.
1753
d2eea5b5
PE
17542011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1755
1756 * xselect.c: Use signed conversions more consistently (Bug#9498).
1757 (selection_data_to_lisp_data): Assume incoming selection data are
1758 signed integers, not unsigned. This is to be consistent with
1759 outgoing selection data, which was modified to use signed integers
1760 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1761 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1762 expects long, not unsigned long.
1763
46888499
EZ
17642011-09-14 Eli Zaretskii <eliz@gnu.org>
1765
1766 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1767 computation of loop end. Reported by Johan Bockgård
1768 <bojohan@gnu.org>.
1769
ef8ef9fb
CY
17702011-09-13 Chong Yidong <cyd@stupidchicken.com>
1771
1772 * frame.c (Fother_visible_frames_p): Function deleted.
1773
fa819fed
EZ
17742011-09-12 Eli Zaretskii <eliz@gnu.org>
1775
1776 * indent.c (compute_motion): Process display vector front to back
1777 rather than the other way around. (Bug#2496)
1778
2ba8e008
SM
17792011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1780
1781 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1782
20f53c69
CY
17832011-09-11 Chong Yidong <cyd@stupidchicken.com>
1784
1785 * minibuf.c (Fread_from_minibuffer): Doc fix.
1786
d562d7a4
EZ
17872011-09-11 Eli Zaretskii <eliz@gnu.org>
1788
1789 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1790 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1791
1c4d7f3d
LMI
17922011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1793
1794 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1795 value for non-existent files.
1796
b885bf36
EZ
17972011-09-11 Eli Zaretskii <eliz@gnu.org>
1798
1799 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1800 set its "size" to -1. This will set the modtime_size field of
1801 the corresponding buffer to -1, which is what
1802 verify-visited-file-modtime expects for files that do not exist.
1803 (Bug#9139)
1804
6612f0bf
PE
18052011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1806
1807 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1808 here ...
1809 * lisp.h: ... from here. push_key_description is no longer
1810 defined in keyboard.c, so its declaration should not be in
1811 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1812 logically belongs with push_key_description.
1813
dfb3f755
PE
18142011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1815
1816 * buffer.h: Include <sys/types.h> instead of <time.h>.
1817 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1818 Problem reported by Herbert J. Skuhra.
1819
3134906c
LMI
18202011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1821
1822 * xml.c (parse_region): Make the parsing work for
1823 non-comment-starting XML files again (bug#9144).
1824
8d903f4e
AS
18252011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1826
1827 * image.c (gif_load): Fix calculation of bottom and right corner.
1828 (Bug#9468)
1829
80ad64f4
EZ
18302011-09-10 Eli Zaretskii <eliz@gnu.org>
1831
1832 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1833 redisplay in small windows.
1834
208a048d
EZ
18352011-09-09 Eli Zaretskii <eliz@gnu.org>
1836
1837 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1838
9b1c252e
MR
18392011-09-08 Martin Rudalics <rudalics@gmx.at>
1840
1841 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1842 Operate on live windows only.
1843
2949f33b
JB
18442011-09-08 Juanma Barranquero <lekktu@gmail.com>
1845
1846 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1847
e08dcafd
EZ
18482011-09-07 Eli Zaretskii <eliz@gnu.org>
1849
1850 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1851 only under bidi iteration.
1852
115b96bd
JD
18532011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1854
1855 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1856
c8199d0f
PE
18572011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1858
1859 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1860 Without this fix, the command to link temacs failed due to an
1861 undefined symbol __builtin_isnan. This is because
1862 /usr/include/iso/math_c99.h #defines isnan(x) to
1863 __builtin_isnan(x), but the bundled gcc, which identifies itself
1864 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1865 a __builtin_isnan.
1866 * floatfns.c (isnan): #undef, and then #define to a clone of
1867 what's in data.c.
1868 (Fisnan): Always define, since it's always available now.
1869 (syms_of_floatfns): Always define isnan at the Lisp level.
1870
e39b275c 18712011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
1872
1873 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1874
b2db44d9 18752011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 1876
f4af5137 1877 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
1878 The previous code assumed that file offsets (off_t values) fit in
1879 EMACS_INT variables, which is not true on typical 32-bit hosts.
1880 The code messed up by falsely reporting buffer overflow in cases
1881 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1882 when "big" contains more than 2**29 bytes, even though this
1883 inserts just one byte and does not overflow the buffer.
1884 (Finsert_file_contents): Store file offsets as off_t
1885 values, not as EMACS_INT values. Check for overflow when
1886 converting between EMACS_INT and off_t. When checking for
1887 buffer overflow or for overlap, take the offsets into account.
1888 Don't use EMACS_INT for small values where int suffices.
1889 When checking for overlap, fix a typo: ZV was used where
1890 ZV_BYTE was intended.
1891 (Fwrite_region): Don't assume off_t fits into 'long'.
1892 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1893
ecfc0a49
MA
18942011-09-05 Michael Albinus <michael.albinus@gmx.de>
1895
1896 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1897
6511acf2 18982011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 1899
0999621a 1900 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
1901
1902 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 1903 (esprintf, exprintf, evxprintf): New functions.
62f19c19 1904 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 1905 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
1906 (modify_event_symbol): Do not assume that the length of
1907 name_alist_or_stem is safe to alloca and fits in int.
1908 (Fexecute_extended_command): Likewise for function name and binding.
1909 (Frecursion_depth): Wrap around reliably on integer overflow.
1910 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1911 since some callers pass EMACS_INT values.
1912 (Fsingle_key_description): Don't crash if symbol name contains more
1913 than MAX_ALLOCA bytes.
1914 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1915 (get_minibuffer): Arg is now EMACS_INT, not int.
1916 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 1917 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
1918 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1919
2be7d702
PE
1920 * dbusbind.c (signature_cat): New function.
1921 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
1922 Do not overrun buffer; instead, report string overflow.
1923
9d1df220
PE
1924 * dispnew.c (add_window_display_history): Don't overrun buffer.
1925 Truncate instead; this is OK since it's just a log.
1926
33ef5c64
PE
1927 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1928 even if the time zone offset is outlandishly large.
1929 Don't mishandle offset == INT_MIN.
1930
66c6fdd5
PE
1931 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1932 when creating daemon; the previous buffer-overflow check was incorrect.
1933
d749b01b
PE
1934 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1935 which has the guts of the old verror function.
1936
b5cd1905
PE
1937 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1938 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1939
6e1a67fb
PE
1940 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1941 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 1942 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 1943 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
1944 length of string rather than counting it via multiple sprintfs;
1945 that's simpler and more reliable.
c21721cc
PE
1946 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1947 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1948 sprintf, in case result does not fit in int.
1949
c57b67fc
PE
1950 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1951 (fontset_from_font): Print it.
1952
8a401434
PE
1953 * frame.c (tty_frame_count): Now printmax_t, not int.
1954 (make_terminal_frame, set_term_frame_name): Print it.
1955 (x_report_frame_params): In X, window IDs are unsigned long,
1956 not signed long, so print them as unsigned.
1957 (validate_x_resource_name): Check for implausibly long names,
1958 and don't assume name length fits in 'int'.
1959 (x_get_resource_string): Don't blindly alloca invocation name;
1960 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1961 not fit in int.
1962
6e1a67fb
PE
1963 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1964 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
1965 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1966
0df02bf3
PE
1967 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1968 Use esprintf, not sprintf, in case result does not fit in int.
1969
48e30793
PE
1970 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1971 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1972 it as a large positive number.
1973 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1974 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1975
a66ff6d8
PE
1976 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1977 in case result does not fit in int.
1978
aca216ff
PE
1979 * print.c (float_to_string): Detect width overflow more reliably.
1980 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1981 buffer overrun. Don't assume list length fits in 'int'. Treat
1982 print length of 0 as 0, not as infinity; to be consistent with other
1983 uses of print length in this function. Don't overflow print length
1984 index. Don't assume hash table size fits in 'long', or that
1985 vectorlike size fits in 'unsigned long'.
1986
31c286f7
PE
1987 * process.c (make_process): Use printmax_t, not int, to format
1988 process-name gensyms.
1989
55e5faa1
PE
1990 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1991
80f2e268
PE
1992 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1993 to avoid potential buffer overrun.
1994
670741ab
PE
1995 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1996 if X resource line is longer than 512 bytes.
1997
b7163a50
PE
1998 * xfns.c (x_window): Make sprintf buffer a bit bigger
1999 to avoid potential buffer overrun.
2000
ae58ff1f
PE
2001 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2002
c43c8a6a
PE
2003 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2004
3f8236f4
PE
20052011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2006
53e9fe90 2007 Integer overflow fixes for scrolling, etc.
6511acf2
PE
2008 Without these, Emacs silently mishandles large integers sometimes.
2009 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
2010 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2011
6511acf2
PE
2012 * xdisp.c (try_window_id): Check Emacs fixnum range before
2013 converting to 'int'.
806add1d 2014
6511acf2 2015 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
2016 Check that an Emacs fixnum is in range before assigning it to 'int'.
2017 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2018 values converted from Emacs fixnums.
2019 (Frecenter): Don't wrap around a line count if it is out of 'int'
2020 range; instead, treat it as an extreme value.
2021 (Fset_window_configuration, compare_window_configurations):
2022 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2023
6511acf2
PE
2024 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2025 that can exceed INT_MAX. Check that EMACS_INT value is in range
2026 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
2027 (match_limit): Don't assume that a fixnum can fit in 'int'.
2028
6511acf2 2029 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
2030 exceed INT_MAX.
2031
6511acf2 2032 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
2033 (Fvertical_motion): Don't wrap around LINES values that don't fit
2034 in 'int'. Instead, treat them as extreme values. This is good
2035 enough for windows, which can't have more than INT_MAX lines anyway.
2036
fcb901a7
LMI
20372011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2038
0f2f6b6d
LMI
2039 * Require libxml/parser.h to avoid compilation warning.
2040
fcb901a7
LMI
2041 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2042
2043 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2044 since this reportedly can destroy thread storage.
2045
6e20a0d4
CY
20462011-08-30 Chong Yidong <cyd@stupidchicken.com>
2047
2048 * syntax.c (find_defun_start): Update all cache variables if
2049 exiting early (Bug#9401).
2050
148ae00e
EZ
20512011-08-30 Eli Zaretskii <eliz@gnu.org>
2052
f6cfbd8f
EZ
2053 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2054
148ae00e
EZ
2055 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2056 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2057 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2058
2059 * term.c (tty_append_glyph): New function.
2060 (produce_stretch_glyph): Static function and its prototype deleted.
2061
a66cfb1c
SM
2062 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2063 Add prototypes.
148ae00e 2064
c4a07a4c
PE
20652011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2066
2067 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2068 when checking :margin (Bug#9390).
2069 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 2070 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
2071 so that the name doesn't mislead. All uses changed.
2072
6bc8cd65
JB
20732011-08-28 Johan Bockgård <bojohan@gnu.org>
2074
2075 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2076 set_tty_hooks.
2077
dca4927e
EZ
20782011-08-27 Eli Zaretskii <eliz@gnu.org>
2079
2080 * xdisp.c (move_it_to): Don't bail out early when reaching
2081 position beyond to_charpos, if we are scanning backwards.
2082 (move_it_vertically_backward): When DY == 0, make sure we get to
2083 the first character in the line after the newline.
2084
f2cad773
PE
20852011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2086
2087 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2088 (ccl_driver): Do not generate an out-of-range pointer.
2089 (Fccl_execute_on_string): Remove unnecessary check for
2090 integer overflow, noted by Stefan Monnier in
2091 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2092 Remove a FIXME that didn't need fixing.
2093 Simplify the newly-introduced buffer reallocation code.
2094
0cae2cdb
JB
20952011-08-27 Juanma Barranquero <lekktu@gmail.com>
2096
2097 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2098
5fc295a4 20992011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 2100
70c60eb2 2101 Integer and memory overflow issues (Bug#9196).
726e0ab1 2102
d31850da
PE
2103 * doc.c (get_doc_string): Rework so that
2104 get_doc_string_buffer_size is the actual buffer size, rather than
2105 being 1 less than the actual buffer size; this makes xpalloc more
2106 convenient.
2107
a69fbedb
PE
2108 * image.c (x_allocate_bitmap_record, cache_image):
2109 * xselect.c (Fx_register_dnd_atom):
2110 Simplify previous changes by using xpalloc.
2111
fe5c5d37
PE
2112 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2113 since either will do and ptrdiff_t is convenient with xpalloc.
2114
0065d054
PE
2115 * charset.c (charset_table_size)
2116 (struct charset_sort_data.priority): Now ptrdiff_t.
2117 (charset_compare): Don't overflow if priorities differ greatly.
2118 (Fsort_charsets): Don't assume list length fits in int.
2119 Check for size-calculation overflow when allocating sort data.
2120 (syms_of_charset): Allocate an initial charset table that is
2121 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2122
2123 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2124
2125 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2126 The actual value is always <= INT_MAX, and leaving it unsigned made
2127 overflow checking harder.
2128
2129 * dispextern.h (struct glyph_matrix.rows_allocated)
2130 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2131 with xpalloc. The values are still always <= INT_MAX.
2132
2133 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2134
2135 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2136 (SAFE_NALLOCA): New macro.
2137
2138 * region-cache.c (struct boundary.pos, find_cache_boundary)
2139 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2140 (set_cache_region, invalidate_region_cache)
2141 (revalidate_region_cache, know_region_cache, region_cache_forward)
2142 (region_cache_backward, pp_cache):
2143 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2144 so that ptrdiff_t * can be passed to xpalloc.
2145 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2146 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2147 (pp_cache): Don't assume cache_len fits in int.
2148 * region-cache.h: Adjust extern decls to match.
2149
2150 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2151 EMACS_INT, since either will do, for xpalloc.
2152
2153 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2154 (xnmalloc, xnrealloc, xpalloc): New functions.
2155
726e0ab1
PE
2156 * bidi.c (bidi_shelve_header_size): New constant.
2157 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2158 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2159
51f30bc5 2160 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
2161 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2162 (overlay_strings):
2163 Don't update size of array until after memory allocation succeeds,
2164 because xmalloc/xrealloc may not return.
0065d054
PE
2165 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2166 now that we have proper integer overflow checking.
2167 (record_overlay_string, overlay_strings): Catch overflows when
2168 calculating size of overlay_str_buf.
726e0ab1 2169
0065d054
PE
2170 * callproc.c (Fcall_process): Check for size overflow when
2171 calculating size of args2.
2172 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2173 Normally we prefer signed values, but sticking with ptrdiff_t would
2174 require adding more-complicated checks.
726e0ab1
PE
2175
2176 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2177 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2178 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 2179 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
2180
2181 * character.c (Fstring): Check for size-calculation overflow.
2182
2183 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2184 unnecessary integer overflow. Check for size overflow.
2185 (encode_coding_object): Don't update size until xmalloc succeeds.
2186
2187 * composite.c (get_composition_id): Check for overflow in glyph
2188 length calculations.
2189
2190 Integer and memory overflow fixes for display code.
2191 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2192 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2193 (scrolling_window): Check for overflow in size calculations.
2194 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2195 Don't assume glyph table len fits in int.
2196 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2197 (row_table_size): Now ptrdiff_t, not int.
2198 (scrolling_window): Avoid overflow in size calculations.
2199 Don't update size until allocation succeeds.
2200 * fns.c (concat): Check for overflow in size calculations.
2201 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2202 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2203 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2204
2205 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2206 (get_doc_string): Check for size calculation overflow.
2207 Don't update size until allocation succeeds.
2208 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2209 EMACS_INT, where ptrdiff_t will do.
2210 (Fsubstitute_command_keys): Check for string overflow.
2211
2212 * editfns.c (set_time_zone_rule): Don't assume environment length
2213 fits in int.
2214 (message_length): Now ptrdiff_t, not int.
2215 (Fmessage_box): Don't update size until allocation succeeds.
2216 Don't assume message length fits in int.
2217 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2218
0065d054
PE
2219 * emacs.c (main): Do not reallocate argv, since there is a null at
2220 the end that can be overwritten, and this way there's no need to
2221 worry about size-calculation overflow.
2222 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
2223
2224 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2225 alloc succeeds.
2226 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2227
2228 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2229 (x_set_scroll_bar_width, x_figure_window_size):
2230 Check for integer overflow.
2231 (x_set_alpha): Do not assume XINT fits in int.
2232
2233 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2234 This is for the members text_lines, text_cols, total_lines, total_cols,
2235 where the system imposes an 'int' limit.
2236
2237 * fringe.c (Fdefine_fringe_bitmap):
2238 Don't update size until alloc works.
2239
2240 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2241 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2242
2243 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2244 Check for size-calculation overflow.
2245 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2246 do, as we prefer signed integers.
2247 (id_to_widget.max_size, id_to_widget.used)
2248 (xg_store_widget_in_map, xg_remove_widget_from_map)
2249 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2250 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2251 Use and return ptrdiff_t, not int.
2252 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2253 * gtkutil.h: Change prototypes to match the above.
2254
2255 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2256 are duplicate now that they've been promoted to lisp.h.
2257 (x_allocate_bitmap_record, x_alloc_image_color)
2258 (make_image_cache, cache_image, xpm_load):
2259 Don't update size until alloc is done.
2260 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2261 (x_detect_edges):
3256efce 2262 Check for size calculation overflow.
726e0ab1
PE
2263 (ct_colors_allocated_max): New constant.
2264 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2265 overflow.
3256efce 2266
726e0ab1
PE
2267 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2268 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2269 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2270 Use ptrdiff_t, not int, to count maps.
2271 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
2272 calculations. Don't update size until allocation succeeds.
2273 Redo calculations to avoid overflow.
726e0ab1
PE
2274 * keyboard.h: Change prototypes to match the above.
2275
2276 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2277 to count maps.
2278 (current_minor_maps): Check for size calculation overflow.
2279 * keymap.h: Change prototypes to match the above.
2280
2281 * lread.c (read1, init_obarray): Don't update size until alloc done.
2282
2283 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2284 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2285
726e0ab1
PE
2286 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2287 Now ptrdiff_t, not int.
2288 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2289 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2290
2291 * process.c (Fnetwork_interface_list): Check for overflow
2292 in size calculation.
2293
2294 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2295
2296 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2297 overflow. Don't bother calling xmalloc when xrealloc will do.
2298
2299 * search.c (Freplace_match): Check for size calculation overflow.
2300 (Fset_match_data): Don't assume list lengths fit in 'int'.
2301
2302 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2303 for command line length. Do not attempt to address one before the
2304 beginning of an array, as that's not portable.
2305
2306 * term.c (max_frame_lines): Remove; unused.
2307 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2308 not int.
2309 (encode_terminal_code, calculate_costs): Check for size
2310 calculation overflow.
2311 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2312 table lengths and related sizes. Don't update size until alloc
2313 done. Redo calculations to avoid overflow.
2314 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2315
2316 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2317 subtracting pointers.
2318 (gobble_line): Check for overflow more carefully. Don't update size
2319 until alloc done.
2320
2321 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2322 Don't update size until alloc done.
2323 Redo size calculations to avoid overflow.
2324 Check for size calculation overflow.
0065d054 2325 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
2326
2327 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2328 Use ptrdiff_t, not int, for sizes.
2329 (store_mode_line_noprop_char): Don't update size until alloc done.
2330
0065d054
PE
2331 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2332 Use ptrdiff_t, not int, for sizes.
2333 (Finternal_make_lisp_face, cache_face):
2334 Check for size calculation overflow.
2335 (cache_face): Treat size calculation overflows as if they were
2336 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
2337
2338 * xfns.c (x_encode_text, x_set_name_internal)
2339 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2340 sizes, since they can exceed INT_MAX in size. Check for size
2341 calculation overflow.
2342
0065d054
PE
2343 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2344 (xg_select): Check for size calculation overflow.
726e0ab1
PE
2345 Don't update size until alloc done.
2346
0065d054 2347 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 2348 as sprintf is limited to int lengths.
1d526e2f 2349
252c5ee1
PE
2350 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2351 (X_LONG_MIN): New macros.
864d7ce7
PE
2352 Use them to make the following changes clearer.
2353 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2354 This change doesn't affect the value now, but it may help remind
2355 future maintainers not to raise the value too much later.
2356 (SELECTION_QUANTUM): Remove, replacing with ...
2357 (selection_quantum): ... new function, which avoids overflow.
2358 All uses changed.
2359 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2360 assumption that selection length fits in 'int'.
2361 (x_reply_selection_request, x_handle_selection_request)
2362 (x_get_window_property, receive_incremental_selection)
2363 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2364 (lisp_data_to_selection_data, clean_local_selection_data):
2365 Use ptrdiff_t, not int, to record length of selection.
2366 (x_reply_selection_request, x_get_window_property)
2367 (receive_incremental_selection, x_property_data_to_lisp):
2368 Redo calculations to avoid overflow.
2369 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 2370 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
2371 something.
2372 (x_get_window_property, receive_incremental_selection)
2373 (lisp_data_to_selection_data, x_property_data_to_lisp):
2374 Check for size-calculation overflow.
2375 (x_get_window_property, receive_incremental_selection)
2376 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2377 Don't store size until memory allocation succeeds.
2378 (x_get_window_property): Plug memory leak on memory exhaustion.
2379 Don't double-block input; malloc is safe here. Don't assume 2**34
2380 - 4 fits in unsigned long. Add an xassert to check
2381 XGetWindowProperty overflow. Be more careful about overflow
2382 calculations, and distinguish size from memory overflow better.
2383 (receive_incremental_selection): When tracing, don't assume
2384 unsigned int is less than INT_MAX.
2385 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2386 harmful) conversions of unsigned short to int.
2387 (lisp_data_to_selection_data): Don't assume that integers
2388 in the range -65535 through -1 fit in an X unsigned short.
2389 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2390 result parameters unless successful. Rely on cons_to_unsigned
2391 to report problems with elements; the old code wasn't right anyway.
2392 (x_check_property_data): Check for int overflow; we cannot use
2393 a wider type due to X limits.
2394 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2395
726e0ab1 2396 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 2397
0065d054
PE
2398 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2399 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
2400 (x_color_cells): Don't store size until memory allocation succeeds.
2401 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 2402 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
2403 (x_term_init): Don't assume length fits in int (sprintf is limited
2404 to int size).
bc18e09d 2405
ebfa62c0
PE
2406 Use ptrdiff_t for composition IDs.
2407 * character.c (lisp_string_width):
2408 * composite.c (composition_table_size, n_compositions)
2409 (get_composition_id, composition_gstring_from_id):
2410 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2411 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2412 * window.c (Frecenter):
2413 Use ptrdiff_t, not int, for composition IDs.
2414 * composite.c (get_composition_id): Check for integer overflow.
2415 * composite.h: Adjust prototypes to match the above changes.
2416
d3411f89
PE
2417 Use ptrdiff_t for hash table indexes.
2418 * category.c (hash_get_category_set):
2419 * ccl.c (ccl_driver):
2420 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2421 * coding.c (coding_system_charset_list, detect_coding_system):
2422 * coding.h (struct coding_system.id):
2423 * composite.c (get_composition_id, gstring_lookup_cache):
2424 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2425 * image.c (xpm_get_color_table_h):
2426 * lisp.h (hash_lookup, hash_put):
2427 * minibuf.c (Ftest_completion):
2428 Use ptrdiff_t for hash table indexes, not int (which is too
2429 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2430 32-bit --with-wide-int hosts).
2431
e097a6fa
PE
2432 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2433 Add a FIXME comment about memory leaks.
2434 (syms_of_charset): Don't assume xmalloc returns.
2435
5637687f
PE
2436 Don't assume that stated character widths fit in int.
2437 * character.c (Fchar_width, c_string_width, lisp_string_width):
2438 * character.h (CHAR_WIDTH):
2439 * indent.c (MULTIBYTE_BYTES_WIDTH):
2440 Use sanitize_char_width to avoid undefined and/or bad behavior
2441 with outlandish widths.
a66cfb1c 2442 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
2443 now that we have two such functions. All uses changed.
2444 (sanitize_char_width): New inline function.
2445
a2271ba2
PE
2446 Don't assume that tab-width fits in int.
2447 * character.h (sanitize_width): New inline function.
2448 (SANE_TAB_WIDTH): New macro.
2449 (ASCII_CHAR_WIDTH): Use it.
2450 * indent.c (sane_tab_width): Remove. All uses replaced by
2451 SANE_TAB_WIDTH (current_buffer).
2452 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2453
18c52557
PE
2454 * fileio.c: Integer overflow issues with file modes.
2455 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2456
caeeedc1
PE
2457 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2458 Remove unreachable code.
2459 (read_hex, load_charset_map_from_file): Check for integer overflow.
2460
6df6ae42 2461 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
2462 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2463 (x_send_scroll_bar_event): Likewise. Check that the size does not
2464 exceed limits imposed by XClientMessageEvent, as well as the usual
2465 ptrdiff_t and size_t limits.
2466
b13995db
PE
2467 * keyboard.c: Overflow, signedness and related fixes.
2468 (make_lispy_movement): Use same integer type in forward decl
2469 that is used in the definition.
2470 (read_key_sequence, keyremap_step):
2471 Change bufsize argument back to int, undoing my 2011-03-30 change.
2472 We prefer signed types, and int is wide enough here.
2473 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2474 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2475 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2476 length, not size_t. Use ptrdiff_t for index, not int.
2477 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2478 possibility of integer overflow.
2479
13464394
PE
2480 Overflow, signedness and related fixes for images.
2481
2482 * dispextern.h (struct it.stack[0].u.image.image_id)
2483 (struct_it.image_id, struct image.id, struct image_cache.size)
2484 (struct image_cache.used, struct image_cache.ref_count):
2485 * gtkutil.c (update_frame_tool_bar):
2486 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2487 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2488 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2489 * nsmenu.m (update_frame_tool_bar):
2490 * xdisp.c (calc_pixel_width_or_height):
2491 * xfns.c (image_cache_refcount):
2492 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2493 on typical 64-bit hosts.
2494
2495 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2496 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2497 Omit unnecessary casts to int.
2498 (parse_image_spec): Check that integers fall into 'int' range
2499 when the callers expect that.
2500 (image_ascent): Redo ascent calculation to avoid int overflow.
2501 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2502 (lookup_image): Remove unnecessary tests.
2503 (xbm_image_p): Locals are now of int, not EMACS_INT,
2504 since parse_image_check makes sure they fit into int.
2505 (png_load, gif_load, svg_load_image):
2506 Prefer int to unsigned where either will do.
2507 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
2508 old tiff_error_handler and tiff_warning_handler.
2509 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
2510 stack buffer overflows. It uses only the features of vsnprintf
2511 that are common to both POSIX and native Microsoft.
2512 (tiff_error_handler, tiff_warning_handler): Use it.
2513 (tiff_load, gif_load, imagemagick_load_image):
2514 Don't assume :index value fits in 'int'.
2515 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2516 (imagemagick_load_image): Check that crop parameters fit into
2517 the integer types that MagickCropImage accepts. Don't assume
2518 Vimagemagick_render_type has a nonnegative value. Don't assume
2519 size_t fits in 'long'.
2520 (gs_load): Use printmax_t to print the widest integers possible.
2521 Check for integer overflow when computing image height and width.
2522
c11821d4
EZ
25232011-08-26 Eli Zaretskii <eliz@gnu.org>
2524
2525 * xdisp.c (redisplay_window): Don't force window start if point
2526 will be invisible in the resulting window. (Bug#9324)
2527
0c95fcf7
EZ
25282011-08-25 Eli Zaretskii <eliz@gnu.org>
2529
2530 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2531 the display spec is of the form `(space ...)'.
2532 (handle_display_spec): Return the value returned by
2533 handle_single_display_spec, not just 1 or zero.
2534 (handle_single_display_spec): If the display spec is of the form
2535 `(space ...)', and specifies display in the text area, return 2
2536 rather than 1.
fee65a97 2537 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
2538 accurately, and prefer exact match for point under bidi.
2539 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
2540
2541 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2542 into disp_prop; all users changed.
2543
2544 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2545 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2546 for the text covered by the display property.
2547
e4ed06f1
CY
25482011-08-25 Chong Yidong <cyd@stupidchicken.com>
2549
2550 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2551 Change return value to nil.
2552 (Frecord_buffer): Delete unused function.
2553
f67cdd7f
EZ
25542011-08-24 Eli Zaretskii <eliz@gnu.org>
2555
5980d4c6
EZ
2556 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2557 buffers, return left-to-right.
8610fe8b
EZ
2558 (set_cursor_from_row): Consider candidate row a win if its glyph
2559 represents a newline and point is on that newline. Fixes cursor
2560 positioning on the newline at EOL of R2L text within L2R
2561 paragraph, and vice versa.
2562 (try_cursor_movement): Check continued rows, in addition to
2563 continuation rows. Fixes unwarranted scroll when point enters a
2564 continued line of R2L text within an L2R paragraph, or vice versa.
2565 (cursor_row_p): Consider the case of point being equal to
2566 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2567 from the end of a short line to the beginning of a continued line
2568 of R2L text within L2R paragraph.
2569 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2570 composed characters.
5980d4c6 2571
f67cdd7f
EZ
2572 * bidi.c (bidi_check_type): Use xassert.
2573 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2574 members.
2575
bca633fb
EZ
25762011-08-23 Eli Zaretskii <eliz@gnu.org>
2577
2578 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2579 a character.
2580
4a5885a7
CY
25812011-08-23 Chong Yidong <cyd@stupidchicken.com>
2582
2583 * nsfont.m (ns_otf_to_script): Fix typo.
2584
0902a04e
KH
25852011-08-22 Kenichi Handa <handa@m17n.org>
2586
2587 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2588 extra slot even if the purpose is char-code-property-table.
2589
1a2e6670
EZ
25902011-08-23 Eli Zaretskii <eliz@gnu.org>
2591
8ddde651
EZ
2592 * xdisp.c (redisplay_window): When computing centering_position,
2593 account for the height of the header line. (Bug#8874)
2594
425cc014
EZ
2595 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2596 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2597 candidate is selected by the mouse, and that candidate has a
2598 composed character under the mouse.
2599
1a2e6670
EZ
2600 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2601 coordinates reported by pos-visible-in-window-p for a composed
2602 character in column zero.
2603
8b76d6f8
SM
26042011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2605
2606 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2607
dac347dd
EZ
26082011-08-22 Eli Zaretskii <eliz@gnu.org>
2609
2610 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2611 consider it a hit if to_charpos is anywhere in the range of the
2612 composed buffer positions.
2613
e013fb34
CY
26142011-08-22 Chong Yidong <cyd@stupidchicken.com>
2615
2616 * image.c (gif_load): Don't assume that each subimage has the same
2617 dimensions as the base image. Handle disposal method that is
2618 "undefined" by the gif spec (Bug#9335).
2619
bd1ba3e8
CY
26202011-08-20 Chong Yidong <cyd@stupidchicken.com>
2621
2622 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 2623 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 2624
54a1215b
EZ
26252011-08-19 Eli Zaretskii <eliz@gnu.org>
2626
823564e5
EZ
2627 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2628 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2629 from an Org mode buffer to a Speedbar frame.
2630
54a1215b
EZ
2631 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2632 a composition, take its buffer position from IT->cmp_it.charpos.
2633 Fixes cursor positioning at the beginning of a line that begins
2634 with a composed character.
2635
9778ebcc
EZ
26362011-08-18 Eli Zaretskii <eliz@gnu.org>
2637
0be6ee06
EZ
2638 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2639 character bidirectional type, use STRONG_L instead. Fixes crashes
2640 in a buffer produced by `describe-categories'.
2641
9778ebcc
EZ
2642 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2643 members before the level stack, so they would be saved and
2644 restored when copying iterator state. Fixes incorrect reordering
2645 around TABs covered by display properties.
2646
156bffbe
AS
26472011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2648
6b02f655 2649 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 2650
72ad093b
CY
26512011-08-17 Chong Yidong <cyd@stupidchicken.com>
2652
2653 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
2654 (internal_condition_case_2, internal_condition_case_n):
2655 Remove unnecessary aborts (Bug#9081).
72ad093b 2656
35774242
EZ
26572011-08-17 Eli Zaretskii <eliz@gnu.org>
2658
2659 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2660 has no `load' handler, try opening the file locally. (Bug#9311)
2661
db76dd85
KB
26622011-08-16 Ken Brown <kbrown@cornell.edu>
2663
2664 * gmalloc.c: Expand comment.
2665
b215eee5
EZ
26662011-08-16 Eli Zaretskii <eliz@gnu.org>
2667
2668 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2669 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2670
a4579d33
KB
26712011-08-16 Ken Brown <kbrown@cornell.edu>
2672
2673 Fix memory allocation problems in Cygwin build (Bug#9273).
2674
2675 * unexcw.c ( __malloc_initialized): Declare external variable.
2676 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2677
8b76d6f8
SM
2678 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2679 New variables.
a4579d33
KB
2680 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2681 dumped emacs.
2682 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2683 in the static heap.
2684 [CYGWIN] (special_realloc): New function.
2685 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2686 requests to realloc storage in the static heap.
2687
3ebec551
PE
26882011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2689
2690 * bidi.c (bidi_initialize): Remove unused local.
2691
9fd8be00
EZ
26922011-08-15 Eli Zaretskii <eliz@gnu.org>
2693
6b02f655
SM
2694 * bidimirror.h:
2695 * biditype.h: Remove file.
2696 * makefile.w32-in ($(BLD)/bidi.$(O)):
2697 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
2698
2699 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2700
2701 * chartab.c: Improve commentary for the uniprop_table API.
2702
32413314
EZ
2703 * bidi.c (bidi_paragraph_init): Support zero value of
2704 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
2705 (bidi_initialize): Use uniprop_table instead of including
2706 biditype.h and bidimirror.h.
32413314 2707
9fd8be00
EZ
2708 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2709 coordinates of the iterator when restoring from ppos_it.
2710 (Bug#9296)
2711
5cf2b69b
KH
27122011-08-14 Kenichi Handa <handa@m17n.org>
2713
2714 * process.c (create_process): Call setup_process_coding_systems
72ad093b 2715 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 2716
daf17d00
EZ
27172011-08-14 Eli Zaretskii <eliz@gnu.org>
2718
2719 * xdisp.c (move_it_in_display_line_to): Don't invoke
2720 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2721 ppos_it. Fixes vertical cursor motion when line beginning is
2722 covered by an image. (Bug#9296)
2723
08e3161a
JD
27242011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2725
2726 * nsterm.h (ns_run_ascript): Declare.
2727 (NSAPP_DATA2_RUNASSCRIPT): Define.
2728
2729 * nsfns.m (as_script, as_result, as_status): New static variables.
2730 (ns_run_ascript): New function.
5e617bc2 2731 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
2732 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2733 the event loop. Get status from as_status (Bug#7276).
2734
2735 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2736 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2737 the event loop (Bug#7276).
2738
a3720aa2
AS
27392011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2740
2741 * gnutls.c (QCgnutls_bootprop_priority)
2742 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2743 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2744 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2745 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2746 (QCgnutls_bootprop_verify_hostname_error)
2747 (QCgnutls_bootprop_callbacks_verify): Rename from
2748 Qgnutls_bootprop_..., all uses changed.
2749
2750 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2751 uses changed.
2752
0a0d27fb
PE
27532011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2754
19d5c50c
PE
2755 * xfaces.c (Qframe_set_background_mode): Now static.
2756 * dispextern.h (Qframe_set_background_mode): Remove decl.
2757
0a0d27fb
PE
2758 * process.c (Fnetwork_interface_info): Declare local only if needed.
2759
377538cb
JD
27602011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2761
2762 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2763 (Fnetwork_interface_list): Allocate in increments of bytes instead
2764 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2765 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2766 sockaddr.
2767 (struct ifflag_def): notrailers is smart on OSX.
2768 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2769 Get hardware address with getifaddrs if available.
2770
08fff70c
EZ
27712011-08-12 Eli Zaretskii <eliz@gnu.org>
2772
2773 * xdisp.c (iterate_out_of_display_property): xassert that
2774 IT->position is set to within IT->object's boundaries. Break from
2775 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
2776 when IT->position is set up wrongly due to some bug.
2777 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
2778 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2779 entry. Force push_it to save on the stack the current
2780 buffer/string position, to be restored by pop_it. Fix flags in
2781 the iterator structure wrt the object coming from a display
2782 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2783 properties. (Bug#9284)
2784
7be1c708 27852011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 2786
7be1c708
CY
2787 * fontset.c (fontset_get_font_group): Add proper type checks.
2788 (Bug#9172)
aac0c6e3 2789
7be1c708 27902011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 2791
7be1c708
CY
2792 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2793 and LC_VERSION_MIN_MACOSX.
2794 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2795 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 2796
97bb72a6
EZ
27972011-08-08 Eli Zaretskii <eliz@gnu.org>
2798
2799 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
2800 no-display-properties-and-no-overlays under bidi display.
2801 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 2802 properties and overlays.
97bb72a6 2803
d5617611
CY
28042011-08-08 Chong Yidong <cyd@stupidchicken.com>
2805
37e11a63
CY
2806 * editfns.c (Fset_time_zone_rule): Document relationship with the
2807 setenv function.
2808
d5617611
CY
2809 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2810 the font entity extracted from the cache (Bug#8109).
2811
58872834
CY
28122011-08-07 Chong Yidong <cyd@stupidchicken.com>
2813
2814 * composite.c (autocmp_chars): Don't reset point. That is done by
2815 restore_point_unwind (Bug#5984).
2816
75bfc667
JL
28172011-08-07 Juri Linkov <juri@jurta.org>
2818
2819 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2820 to show the arg `TIME' instead of `TIMEVAL'.
2821
d1410150
EZ
28222011-08-06 Eli Zaretskii <eliz@gnu.org>
2823
2824 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2825 display property strides EOL and includes a newline, as in
2826 longlines-mode. (Bug#9254)
75b771e4
EZ
2827 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2828 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
2829
2830 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2831 is non-zero, even if the data buffer is NULL. Fixes a crash in
2832 vertical-motion with longlines-mode. (Bug#9254)
2833
35928349
EZ
28342011-08-05 Eli Zaretskii <eliz@gnu.org>
2835
ec7cc85b
EZ
2836 * bidi.c <bidi_cache_total_alloc>: Now static.
2837 (bidi_initialize): Initialize bidi_cache_total_alloc.
2838
8b76d6f8 2839 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
2840 cache. (Bug#9221)
2841
2842 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2843 amount allocated this far in `bidi_cache_total_alloc'.
2844 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2845 non-zero, only free the data buffer without restoring the cache
2846 contents. All callers changed.
2847
2848 * dispextern.h (bidi_unshelve_cache): Update prototype.
2849
2850 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2851 (move_it_in_display_line, move_it_to)
2852 (move_it_vertically_backward, move_it_by_lines): Replace the call
2853 to xfree to an equivalent call to bidi_unshelve_cache.
2854 (move_it_in_display_line_to): Fix logic of returning
412b6358 2855 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 2856
e2e2423b
EZ
28572011-08-05 Eli Zaretskii <eliz@gnu.org>
2858
2859 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2860 came from a string character with a `cursor' property. (Bug#9229)
2861
ae9e757a
JD
28622011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2863
2864 * Makefile.in (LIB_PTHREAD): New variable.
2865 (LIBES): Add LIB_PTHREAD (Bug#9216).
2866
2867 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2868 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2869
213bd7f2
AS
28702011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2871
6b02f655 2872 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 2873
99aaf75f
JD
28742011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2875
2876 * xterm.c (x_find_topmost_parent): New function.
2877 (x_set_frame_alpha): Find topmost parent window with
2878 x_find_topmost_parent and set the property there also (bug#9181).
2879 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2880
c74e9d86
PE
28812011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2882
2883 * callproc.c (Fcall_process): Avoid vfork clobbering
2884 the local vars buffer, coding_systems, current_dir.
2885
640c8776
SM
28862011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2887
2888 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2889
f26d0e4c
PE
28902011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2891
8a10d76c
PE
2892 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2893 so that it is not optimized away.
2894
f26d0e4c
PE
2895 * xdisp.c (compute_display_string_pos): Remove unused local.
2896
55439c61
EZ
28972011-08-02 Eli Zaretskii <eliz@gnu.org>
2898
2899 Fix slow cursor motion and scrolling in large buffers with
2900 selective display, like Org Mode buffers. (Bug#9218)
2901
2902 * dispextern.h (struct bidi_it): New member disp_prop_p.
2903
2904 * xdisp.c: Remove one-slot cache of display string positions.
2905 (compute_display_string_pos): Accept an additional argument
5e617bc2 2906 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
2907 for a display string or property. If found, set DISP_PROP_P
2908 non-zero.
2909
2910 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
2911 DISP_PROP_P, and pass it to compute_display_string_pos.
2912 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
2913 non-zero. All callers of bidi_fetch_char changed.
2914
fb33fa43
SM
29152011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2916
2917 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2918
b099e063
DM
29192010-12-03 Don March <don@ohspite.net>
2920
2921 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2922 last character M-[char] is translated to ESC [char] (bug#7541).
2923
5cc7f7af
KH
29242011-08-02 Kenichi Handa <handa@m17n.org>
2925
d0fffa3f 2926 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
2927
2928 * chartab.c (uniprop_table): Make it non-static.
2929
525d5e6e
EZ
29302011-08-01 Eli Zaretskii <eliz@gnu.org>
2931
2932 * xdisp.c (forward_to_next_line_start): Accept additional argument
2933 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2934 on the newline.
2935 (reseat_at_next_visible_line_start): Use the bidi iterator state
2936 returned by forward_to_next_line_start to restore the state of
2937 it->bidi_it after backing up to previous newline. (Bug#9212)
2938
31011111
AS
29392011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2940
2941 * regex.c (re_comp): Protoize.
2942 (re_exec): Fix return type.
2943 (regexec): Fix type of `ret'. (Bug#9203)
2944
476371c4
PE
29452011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2946
e5d76069
PE
2947 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2948 This is needed if max-image-size is a floating-point number.
2949
9a79b20c
AS
29502011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2951
2952 * print.c (print_object): Print empty symbol as ##.
2953
2954 * lread.c (read1): Read ## as empty symbol.
2955
d8c2fa78
AA
29562011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2957
2958 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2959 setting frame foreground color (Bug#9175).
2960 (x_set_background_color): Likewise.
2961
ffe57a7a
AA
2962 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2963 contents (Bug#9176).
2964 (EmacsTooltip -init): Remove bezels and add shadows to
2965 tooltip windows.
2966
bf3492a5
AA
2967 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2968 or scroll bar (Bug#8470).
2969
d55e9c53
AA
2970 * nsfont.m (nsfont_open): Remove assignment to voffset and
2971 unnecessary vars hshink, expand, hd, full_height, min_height.
2972 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2973
2974 * nsterm.h (nsfont_info): Remove voffset field.
2975
d8c2fa78 29762011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
2977
2978 Implement strike-through and overline on NextStep (Bug#8863).
2979
2980 * nsfont.m (nsfont_open): Use underline position provided by font,
2981 instead of hard-coded value of 2.
2982 (nsfont_draw): Call ns_draw_text_decoration instead.
2983
2984 * nsterm.h: Add declaration for ns_draw_text_decoration.
2985
2986 * nsterm.m (ns_draw_text_decoration): New function for drawing
2987 underline, overline, and strike-through.
2988 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2989 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 2990 accommodate underlining, etc.
4843aac3 2991
4cc60b9b
EZ
29922011-07-28 Eli Zaretskii <eliz@gnu.org>
2993
bc7ece87
EZ
2994 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2995 default.
4cc60b9b 2996
476371c4
PE
29972011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2998
66606eea
PE
2999 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3000 Without this fix, if a signal arrives just after memory fills up,
3001 'malloc' might be invoked reentrantly.
3002
476371c4
PE
3003 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3004 In other words, assume that every image size is allowed, on non-X
3005 hosts. This assumption is probably wrong, but it lets Emacs compile.
3006
f3fcc40d
AS
30072011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3008
3009 * regex.c (re_iswctype): Convert return values to boolean.
3010
350c992f
EZ
30112011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3012
3013 * xdisp.c (compute_display_string_pos): Don't use cached display
3014 string position if the buffer had its restriction changed.
3015 (Bug#9184)
3016
5266b4bb
PE
30172011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3018
3019 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3020
2573a837 30212011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 3022
41f55ccd 3023 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 3024
39e378da
PE
3025 * bidi.c: Integer size and overflow fixes.
3026 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3027 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3028 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3029 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3030 (bidi_find_other_level_edge):
3031 Use ptrdiff_t instead of EMACS_INT where either will do.
3032 This works better on 32-bit hosts configured --with-wide-int.
3033 (bidi_cache_ensure_space): Check for size-calculation overflow.
3034 Use % rather than repeated addition, for better worst-case speed.
3035 Don't set bidi_cache_size until after xrealloc returns, because it
3036 might not return.
3037 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
3038 (bidi_cache_ensure_space): Also check that the bidi cache size
3039 does not exceed that of the largest Lisp string or buffer. See Eli
3040 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 3041
5e927815
PE
3042 * alloc.c (__malloc_size_t): Remove.
3043 All uses replaced by size_t. See Andreas Schwab's note
3044 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3045
ca4aa935
PE
3046 * image.c: Improve checking for integer overflow.
3047 (check_image_size): Assume that f is nonnull, since
3048 it is always nonnull in practice. This is one less thing to
3049 worry about when checking for integer overflow later.
3050 (x_check_image_size): New function, which checks for integer
3051 overflow issues inside X.
3052 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3053 This removes the need for a memory_full check.
3054 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3055 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3056 (xbm_read_bitmap_data): Change locals back to 'int', since
3057 their values must fit in 'int'.
3058 (xpm_load_image, png_load, tiff_load):
3059 Invoke x_create_x_image_and_pixmap earlier,
3060 to avoid much needless work if the image is too large.
3061 (tiff_load): Treat overly large images as if
3062 x_create_x_image_and_pixmap failed, not as malloc failures.
3063 (gs_load): Use x_check_image_size.
3064
5f8f9cc2
PE
3065 * gtkutil.c: Omit integer casts.
3066 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3067 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3068
5adf60bc
PE
3069 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3070
c8907a93
PE
3071 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3072 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3073 would wrongly return t on a 64-bit host.
3074
e3c25c68
PE
3075 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3076 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3077 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3078 and therefore cause GCC to emit a bogus diagnostic in some cases.
3079
3f791afe
PE
3080 * image.c: Integer signedness and overflow and related fixes.
3081 This is not an exhaustive set of fixes, but it's time to
3082 record what I've got.
3083 (lookup_pixel_color, check_image_size): Remove redundant decls.
3084 (check_image_size): Don't assume that arbitrary EMACS_INT values
3085 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3086 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3087 (tiff_load, imagemagick_load_image):
3088 Check for overflow in size calculations.
3089 (x_create_x_image_and_pixmap): Remove unnecessary test for
3090 xmalloc returning NULL; that can't happen.
3091 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3092 (xpm_color_bucket): Use better integer hashing function.
3093 (xpm_cache_color): Don't possibly over-allocate memory.
3094 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3095 (gif_memory_source):
3096 Use ptrdiff_t, not int or size_t, to record sizes.
3097 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3098 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3099 either works, as we prefer signed integers.
3100 (tiff_read_from_memory, tiff_write_from_memory):
3101 Return tsize_t, not size_t, since that's what the TIFF API wants.
3102 (tiff_read_from_memory): Don't fail simply because the read would
3103 go past EOF; instead, return a short read.
3104 (tiff_load): Omit no-longer-needed casts.
3105 (Fimagemagick_types): Don't assume size fits into 'int'.
3106
3cc5a532
PE
3107 Improve hashing quality when configured --with-wide-int.
3108 * fns.c (hash_string): New function, taken from sxhash_string.
3109 Do not discard information about ASCII character case; this
3110 discarding is no longer needed.
3111 (sxhash-string): Use it. Change sig to match it. Caller changed.
3112 * lisp.h: Declare it.
3113 * lread.c (hash_string): Remove, since we now use fns.c's version.
3114 The fns.c version returns a wider integer if --with-wide-int is
3115 specified, so this should help the quality of the hashing a bit.
3116
b312a492
PE
3117 * emacs.c: Integer overflow minor fix.
3118 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3119 Define only if GNU_LINUX.
3120 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3121
dfd153ae
PE
3122 * dispnew.c: Integer signedness and overflow fixes.
3123 Remove unnecessary forward decls, that were a maintenance hassle.
3124 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3125 All uses changed.
3126 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3127 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3128 (prepare_desired_row, line_draw_cost):
3129 Use int, not unsigned, where either works.
3130 (save_current_matrix, restore_current_matrix):
3131 Use ptrdiff_t, not size_t, where either works.
3132 (init_display): Check for overflow more accurately, and without
3133 relying on undefined behavior.
3134
a81d11a3
PE
3135 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3136 Remove, replacing with the new symbols in lisp.h. All uses changed.
3137 * fileio.c (make_temp_name):
3138 * filelock.c (lock_file_1, lock_file):
3139 * xdisp.c (message_dolog):
3140 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3141 Use pMd etc. instead.
3142 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3143 replacing the pWIDE etc. symbols removed from editfns.c.
3144
3300e6fd
PE
3145 * keyboard.h (num_input_events): Now uintmax_t.
3146 This is (very slightly) less likely to mess up due to wraparound.
3147 All uses changed.
3148
fd05c7e9
PE
3149 * buffer.c: Integer signedness fixes.
3150 (alloc_buffer_text, enlarge_buffer_text):
3151 Use ptrdiff_t rather than size_t when either will do, as we prefer
3152 signed integers.
3153
903fe15d
PE
3154 * alloc.c: Integer signedness and overflow fixes.
3155 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3156 (__malloc_size_t): Default to size_t, not to int.
3157 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3158 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3159 Prefer ptrdiff_t to size_t when either would do, as we prefer
3160 signed integers.
3161 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3162 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3163 Now const. Initialize with values that are in range even if char
3164 is signed.
3165 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3166 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3167 These functions do the right thing with sizes > 2**32.
3168 (check_depth): Now ptrdiff_t, not int.
3169 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3170 Adjust to new way of storing sizes. Check for size overflow bugs
3171 in rest of code.
3172 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3173 slightly wrong anyway, as it missed one instance of
3174 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3175 (refill_memory_reserve): Omit needless cast to size_t.
3176 (mark_object_loop_halt): Mark as externally visible.
3177
ac82cc6a
PE
3178 * xselect.c: Integer signedness and overflow fixes.
3179 (Fx_register_dnd_atom, x_handle_dnd_message):
3180 Use ptrdiff_t, not size_t, since we prefer signed.
3181 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3182 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3183 x_dnd_atoms_size and x_dnd_atoms_length.
3184
c2d1e36d
PE
3185 * doprnt.c: Prefer signed to unsigned when either works.
3186 * eval.c (verror):
3187 * doprnt.c (doprnt):
3188 * lisp.h (doprnt):
3189 * xdisp.c (vmessage):
3190 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3191 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3192 prefer signed arithmetic to avoid comparison confusion.
3193 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3194 but is a bit tricky.
3195
0e926e56
PE
3196 Assume freestanding C89 headers, string.h, stdlib.h.
3197 * data.c, doprnt.c, floatfns.c, print.c:
3198 Include float.h unconditionally.
3199 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3200 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3201 * regex.c: Likewise for stddef.h, string.h.
3202 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3203 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3204 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3205 (STDC_HEADERS): Remove obsolete defines.
3206 * sysdep.c: Include limits.h unconditionally.
3207
9cfdb3ec
PE
3208 Assume support for memcmp, memcpy, memmove, memset.
3209 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3210 * regex.c (memcmp, memcpy):
3211 Remove; we assume C89 now.
3212
3213 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3214 (__malloc_safe_bcopy): Remove; no longer needed.
3215
cf950e6b 3216 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
3217 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3218 well either way, and we prefer signed to unsigned.
3219
dbf38e02
LMI
32202011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3221
3222 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3223 closes the connection while we're reading (bug#9182).
3224
d6f0886c 32252011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 3226
d6f0886c
JD
3227 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3228 are specified (Bug#9168).
24e0f6b1 3229
2eb1f9e6
PE
32302011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3231
3232 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3233 Found by GCC static checking and --with-wide-int on a 32-bit host.
3234
22381272 32352011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
3236
3237 * xdisp.c (compute_display_string_pos): Fix logic of caching
3238 previous display string position. Initialize cached_prev_pos to
3239 -1. Fixes slow-down at the beginning of a buffer.
3240
f25e39b4
EZ
32412011-07-24 Eli Zaretskii <eliz@gnu.org>
3242
3243 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3244 for attrs[LFACE_FONTSET_INDEX].
3245
04c4b52e
PE
32462011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3247
3248 * xml.c (parse_region): Remove unused local
3249 that was recently introduced.
3250
c1734fbd
EZ
32512011-07-23 Eli Zaretskii <eliz@gnu.org>
3252
be18c5a5
EZ
3253 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3254 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3255
c1734fbd
EZ
3256 * xdisp.c (move_it_in_display_line_to): Record the best matching
3257 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
3258 exit if none of the characters scanned was an exact match.
3259 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
3260 when exact match is impossible due to invisible text, and the
3261 lines are truncated.
3262
a258d627
JD
32632011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3264
3265 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3266 for OSX >= 10.7.
3267
b6d5a689
EZ
32682011-07-22 Eli Zaretskii <eliz@gnu.org>
3269
0f74f785
EZ
3270 Fix a significant slow-down of cursor motion with C-n, C-p,
3271 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3272 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 3273 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
3274 (next_element_from_buffer): Call compute_stop_pos_backwards to
3275 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
3276 base_level_stop.
3277 (reseat): Don't look for prev_stop, as that could mean a very long
3278 run.
3279 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3280 <cached_disp_overlay_modiff>: Cache for last found display string
3281 position.
551918c1 3282 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
3283 about the same buffer in the same area of character positions, and
3284 the buffer wasn't changed since the time the display string
3285 position was cached.
551918c1 3286
b2d0c91a
EZ
32872011-07-22 Eli Zaretskii <eliz@gnu.org>
3288
3289 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3290 is an integer, which is important for empty lines. (Bug#9149)
3291
043604ee
CY
32922011-07-22 Chong Yidong <cyd@stupidchicken.com>
3293
3294 * frame.c (Fmodify_frame_parameters): In tty case, update the
3295 default face if necessary (Bug#4238).
3296
da4adb04
CY
32972011-07-21 Chong Yidong <cyd@stupidchicken.com>
3298
3299 * editfns.c (Fstring_to_char): No need to explain what a character
3300 is in the docstring (Bug#6576).
3301
9abd0532
LMI
33022011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3303
3304 * xml.c (parse_region): Make sure we always return a tree.
3305
36881d16
HK
33062011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3307
3308 * xml.c (parse_region): If a document contains only comments,
3309 return that, too.
3310
1e98674d
LMI
33112011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3312
3313 * xml.c (make_dom): Return comments, too.
3314
590bd467
PE
33152011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3316
3317 Port to OpenBSD.
3318 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3319 and the surrounding thread.
3320 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3321 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3322 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3323 timer goes off.
3324 * s/openbsd.h (BROKEN_SIGIO): Define.
3325 * unexelf.c (unexec) [__OpenBSD__]:
3326 Don't update the .mdebug section of the Alpha COFF symbol table.
3327
f41628b2
LMI
33282011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3329
3330 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3331 (bug#8460).
3332
b59b67c5
PE
33332011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3334
15e3a074
PE
3335 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3336 This fixes some race conditions on the permissions of any newly
3337 created file.
3338
41bed37d
PE
3339 * alloc.c (valid_pointer_p): Use pipe, not open.
3340 This fixes some permissions issues when debugging.
3341
b59b67c5
PE
3342 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3343 If fchown fails to set both uid and gid, try to set just gid,
3344 as that is sometimes allowed. Adjust the file's mode to eliminate
3345 setuid or setgid bits that are inappropriate if fchown fails.
3346
925a6be7
SM
33472011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3348
3349 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3350 to compare Lisp_Objects.
3351 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3352 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3353 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3354
52968808
AS
33552011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3356
0a6a104b
AS
3357 * lread.c (read_integer): Unread even EOF character.
3358 (read1): Likewise. Properly record start position of symbol.
3359
52968808
AS
3360 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3361 symbol character follows.
3362
9e381cdd
PE
33632011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3364
3365 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3366 This works around a problem with the previous change to Fcopy_file.
3367 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3368 and without this change, GCC might complain about discarding
3369 fchown's return value.
3370
b5641435
JB
33712011-07-16 Juanma Barranquero <lekktu@gmail.com>
3372
3373 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3374
a8031457
PE
33752011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3376
3377 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3378
dd889327
LMI
33792011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3380
750c33f7
LMI
3381 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3382 it's used from the C level.
3383
dd889327
LMI
3384 * process.c: Use the same condition for POLL_FOR_INPUT in both
3385 keyboard.c and process.c (bug#1858).
3386
87e86684
LM
33872011-07-09 Lawrence Mitchell <wence@gmx.li>
3388
3389 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3390 (Fgnutls_boot): Use it.
3391
64348f40
AS
33922011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3393
3394 * doc.c (Fsubstitute_command_keys): Revert last change.
3395
1d698799
LMI
33962011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3397
f863868c
LMI
3398 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3399 quotes the next character, and doesn't affect other longer
3400 sequences (bug#8935).
3401
1d698799
LMI
3402 * lread.c (syms_of_lread): Clarify that is isn't only
3403 `eval-buffer' and `eval-defun' that's affected by
3404 `lexical-binding' (bug#8460).
3405
aa4b6df6
EZ
34062011-07-15 Eli Zaretskii <eliz@gnu.org>
3407
3408 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 3409 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 3410
5d856da6
PE
34112011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3412
ad6042bb
PE
3413 Fix minor problems found by static checking.
3414 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3415 (elsz): Now a signed constant, not a size_t var. We prefer signed
3416 types to unsigned, to avoid integer comparison confusion. Without
3417 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3418 "cannot optimize loop, the loop counter may overflow", a symptom
3419 of the confusion.
f00bbb22 3420 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
3421 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3422
6468f31c
LMI
34232011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3424
49080b10
LMI
3425 * search.c (Fre_search_backward): Mention `case-fold-search' in
3426 all the re_search_* functions (bug#8138).
3427
6468f31c
LMI
3428 * keyboard.c (Fopen_dribble_file): Document when the file is
3429 closed (bug#8056).
3430
c965adc5
EZ
34312011-07-14 Eli Zaretskii <eliz@gnu.org>
3432
df9733bf
EZ
3433 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3434 bidi_cache_idx.
3435
0bb23927
EZ
3436 Support bidi reordering of display and overlay strings.
3437 * xdisp.c (compute_display_string_pos)
3438 (compute_display_string_end): Accept additional argument STRING.
3439 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3440 (reseat_to_string): Initialize bidi_it->string.s and
3441 bidi_it->string.schars.
3442 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
3443 NULL (avoids a crash in bidi_paragraph_init).
3444 Initialize itb.string.lstring.
0bb23927
EZ
3445 (init_iterator): Call bidi_init_it only of a valid
3446 buffer position was specified. Initialize paragraph_embedding to
3447 L2R.
3448 (reseat_to_string): Initialize the bidi iterator.
3449 (display_string): If we need to ignore text properties of
3450 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3451 original value of -1 will not work with bidi.)
3452 (compute_display_string_pos): First arg is now struct
3453 `text_pos *'; all callers changed. Support display properties on
3454 Lisp strings.
3455 (compute_display_string_end): Support display properties on Lisp
3456 strings.
3457 (init_iterator, reseat_1, reseat_to_string): Initialize the
3458 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3459 when iterating on a string not from display properties).
640c8776
SM
3460 (compute_display_string_pos, compute_display_string_end):
3461 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
3462 arrow keys.
3463 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
3464 base_level_stop; instead, set base_level_stop to BEGV.
3465 Fixes crashes in vertical-motion.
0bb23927
EZ
3466 (next_element_from_buffer): Improve commentary for when
3467 the iterator is before prev_stop.
3468 (init_iterator): Initialize bidi_p from the default value of
3469 bidi-display-reordering, not from buffer-local value. Use the
3470 buffer-local value only if initializing for buffer iteration.
3471 (handle_invisible_prop): Support invisible properties on strings
3472 that are being bidi-reordered.
3473 (set_iterator_to_next): Support bidi reordering of C strings and
3474 Lisp strings.
3475 (next_element_from_string): Support bidi reordering of Lisp
3476 strings.
3477 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
3478 (display_string): Support display of R2L glyph rows.
3479 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
3480 (init_iterator): Don't initialize it->bidi_p for strings
3481 here.
3482 (reseat_to_string): Initialize it->bidi_p for strings here.
3483 (next_element_from_string, next_element_from_c_string)
3484 (next_element_from_buffer): Add xassert's for correspondence
3485 between IT's object being iterated and it->bidi_it.string
3486 structure.
3487 (face_before_or_after_it_pos): Support bidi iteration.
3488 (next_element_from_c_string): Handle the case of the first string
3489 character that is not the first one in the visual order.
3490 (get_visually_first_element): New function, refactored from common
3491 parts of next_element_from_buffer, next_element_from_string, and
3492 next_element_from_c_string.
3493 (tool_bar_lines_needed, redisplay_tool_bar)
3494 (display_menu_bar): Force left-to-right direction. Add a FIXME
3495 comment for making that be controlled by a user option.
3496 (push_it, pop_it): Save and restore the state of the
3497 bidi iterator. Save and restore the bidi_p flag.
3498 (pop_it): Iterate out of display property for string iteration as
3499 well.
3500 (iterate_out_of_display_property): Support iteration over strings.
3501 (handle_single_display_spec): Set up it->bidi_it for iteration
3502 over a display string, and call bidi_init_it.
3503 (handle_single_display_spec, next_overlay_string)
3504 (get_overlay_strings_1, push_display_prop): Set up the bidi
3505 iterator for displaying display or overlay strings.
3506 (forward_to_next_line_start): Don't use the shortcut if
3507 bidi-iterating.
3508 (back_to_previous_visible_line_start): If handle_display_prop
3509 pushed the iterator stack, restore the internal state of the bidi
3510 iterator by calling bidi_pop_it same number of times.
3511 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3512 and we are bidi-iterating, don't decrement the iterator position;
3513 instead, set the first_elt flag in the bidi iterator, to produce
3514 the same effect.
3515 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3516 (push_display_prop): xassert that we are iterating a buffer.
3517 (push_it, pop_it): Save and restore paragraph_embedding member.
3518 (handle_single_display_spec, next_overlay_string)
3519 (get_overlay_strings_1, reseat_1, reseat_to_string)
3520 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3521 correctly. Don't assume unibyte strings are not bidi-reordered.
3522 (compute_display_string_pos)
3523 (compute_display_string_end): Fix handling the case of C string.
3524 (push_it, pop_it): Save and restore from_disp_prop_p.
3525 (handle_single_display_spec, push_display_prop): Set the
3526 from_disp_prop_p flag.
3527 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3528 (pop_it): Call iterate_out_of_display_property only if we are
3529 popping after iteration over a string that came from a display
3530 property. Fix a typo in popping stretch info. Add an assertion
3531 for verifying that the iterator position is in sync with the bidi
3532 iterator.
3533 (handle_single_display_spec, get_overlay_strings_1)
3534 (push_display_prop): Fix initialization of paragraph direction for
3535 string when that of the parent object is not yet determined.
3536 (reseat_1): Call bidi_init_it to resync the bidi
3537 iterator with IT's position. (Bug#7616)
3538 (find_row_edges): If ROW->start.pos gives position
3539 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3540 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3541 Reset the from_disp_prop_p flag.
3542 (SAVE_IT, RESTORE_IT): New macros.
3543 (pos_visible_p, face_before_or_after_it_pos)
3544 (back_to_previous_visible_line_start)
3545 (move_it_in_display_line_to, move_it_in_display_line)
3546 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3547 (try_scrolling, redisplay_window, display_line): Use them when
3548 saving a temporary copy of the iterator and restoring it back.
3549 (back_to_previous_visible_line_start, reseat_1)
3550 (init_iterator): Empty the bidi cache "stack".
3551 (move_it_in_display_line_to): If iterator ended up at
3552 EOL, but we never saw any buffer positions smaller than
3553 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3554 motion in bidi-reordered lines.
3555 (move_it_in_display_line_to): Record prev_method and prev_pos
3556 immediately before the call to set_iterator_to_next. Fixes cursor
3557 motion in bidi-reordered lines with stretch glyphs and strings
3558 displayed in margins. (Bug#8133) (Bug#8867)
3559 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3560 TO_CHARPOS.
640c8776
SM
3561 (pos_visible_p): Support positions in bidi-reordered lines.
3562 Save and restore bidi cache.
0bb23927
EZ
3563
3564 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3565 (bidi_paragraph_info): Delete unused struct.
3566 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3567 (bidi_cache_start): New variable.
3568 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3569 to zero.
3570 (bidi_cache_fetch_state, bidi_cache_search)
3571 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3572 (bidi_cache_find, bidi_peek_at_next_level)
3573 (bidi_level_of_next_char, bidi_find_other_level_edge)
3574 (bidi_move_to_visually_next): Compare cache index with
3575 bidi_cache_start rather than with zero.
3576 (bidi_fetch_char): Accept new argument STRING; all callers
3577 changed. Support iteration over a string. Support strings with
3578 display properties. Support unibyte strings. Fix the type of
3579 `len' according to what STRING_CHAR_AND_LENGTH expects.
3580 (bidi_paragraph_init, bidi_resolve_explicit_1)
3581 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
3582 (bidi_level_of_next_char, bidi_move_to_visually_next):
3583 Support iteration over a string.
0bb23927
EZ
3584 (bidi_set_sor_type, bidi_resolve_explicit_1)
3585 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3586 can now be zero (for strings); special values 0 and -1 were
3587 changed to -1 and -2, respectively.
3588 (bidi_char_at_pos): New function.
3589 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3590 Call it instead of FETCH_MULTIBYTE_CHAR.
3591 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3592 initialized to valid values.
3593 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3594 values.
3595 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3596 the test for valid cached positions. Fix the logic for looking up
3597 the sentinel state in the cache. GCPRO the Lisp string we are
3598 iterating.
3599 (bidi_push_it, bidi_pop_it): New functions.
3600 (bidi_initialize): Initialize the bidi cache start stack pointer.
3601 (bidi_cache_ensure_space): New function, refactored from part of
3602 bidi_cache_iterator_state. Don't assume the required size is just
3603 one BIDI_CACHE_CHUNK away.
3604 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3605 (bidi_count_bytes, bidi_char_at_pos): New functions.
3606 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3607 always valid if bidi_cache_idx is valid.
3608 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3609 is valid if it's going to be used.
3610 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3611 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
3612 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3613 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
3614 (bidi_find_other_level_edge, bidi_cache_start_stack):
3615 All variables related to cache indices are now EMACS_INT.
c965adc5 3616
0bb23927
EZ
3617 * dispextern.h (struct bidi_string_data): New structure.
3618 (struct bidi_it): New member `string'. Make flag members be 1-bit
3619 fields, and put them last in the struct.
640c8776
SM
3620 (compute_display_string_pos, compute_display_string_end):
3621 Update prototypes.
0bb23927
EZ
3622 (bidi_push_it, bidi_pop_it): Add prototypes.
3623 (struct iterator_stack_entry): New members bidi_p,
3624 paragraph_embedding, and from_disp_prop_p.
3625 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
3626 (bidi_shelve_cache, bidi_unshelve_cache):
3627 Declare prototypes.
0bb23927
EZ
3628
3629 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3630 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3631 and vector-like objects.
3632
3633 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3634 cache around display iteration.
3635
3636 * window.c (Fwindow_end, window_scroll_pixel_based)
3637 (displayed_window_lines, Frecenter): Save and restore the bidi
3638 cache around display iteration.
3639
3bbd2265
LMI
36402011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3641
3642 * editfns.c (Fdelete_region): Clarify the use of the named
3643 parameters (bug#6788).
3644
adc47434
MR
36452011-07-14 Martin Rudalics <rudalics@gmx.at>
3646
3647 * indent.c (Fvertical_motion): Set and restore w->pointm when
3648 saving and restoring the window's buffer (Bug#9006).
3649
837c31f8
LMI
36502011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3651
3652 * editfns.c (Fstring_to_char): Clarify just what is returned
3653 (bug#6576). Text by Eli Zaretskii.
3654
ac389d0c
JB
36552011-07-13 Juanma Barranquero <lekktu@gmail.com>
3656
3657 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3658
0be0ce47
EZ
36592011-07-13 Eli Zaretskii <eliz@gnu.org>
3660
3661 * buffer.c (mmap_find): Fix a typo.
3662
cd18e7e3
JB
36632011-07-13 Johan Bockgård <bojohan@gnu.org>
3664
3665 Fix execution of x selection hooks.
3666 * xselect.c (Qx_lost_selection_functions)
3667 (Qx_sent_selection_functions): New vars.
3668 (syms_of_xselect): DEFSYM them.
3669 (x_handle_selection_request): Pass Qx_sent_selection_functions
3670 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3671 (x_handle_selection_clear,x_clear_frame_selections):
3672 Pass Qx_lost_selection_functions rather than
3673 Vx_lost_selection_functions to Frun_hook_with_args.
3674
47ea7f44
PE
36752011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3676
ac389d0c 3677 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
3678 The old code sometimes used this field without initializing it.
3679
47ea7f44
PE
3680 * alloc.c (gc_sweep): Don't read past end of array.
3681 In theory, the old code could also have corrupted Emacs internals,
3682 though it'd be very unlikely.
3683
bc985c87
AS
36842011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3685
3686 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 3687 argument. (Bug#4026)
bc985c87 3688
0cf34688
LMI
36892011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3690
b3dadd76
LMI
3691 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3692 key" (bug#4257).
3693
0cf34688
LMI
3694 * window.c (Fset_window_start): Doc fix (bug#4199).
3695 (Fset_window_hscroll): Ditto.
3696
270768cd
PE
36972011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3698
077e3dda 3699 Fix minor new problems caught by GCC 4.6.1.
270768cd 3700 * term.c (init_tty): Remove unused local.
490011a6 3701 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 3702 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 3703 not used otherwise.
270768cd 3704
b1f58454
CY
37052011-07-12 Chong Yidong <cyd@stupidchicken.com>
3706
3707 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3708
22b9578d
LMI
37092011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3710
6e70ab07
LMI
3711 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3712 are the mini-buffer and the echo area (bug#3320).
3713
22b9578d
LMI
3714 * term.c (init_tty): Remove support for supdup, c10 and perq
3715 terminals, which are no longer supported (bug#1482).
3716
8974cc9f
JB
37172011-07-10 Johan Bockgård <bojohan@gnu.org>
3718
3719 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3720
a560d974
JD
37212011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3722
3723 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3724 for non-popups (Bug#3642).
3725
1dae0f0a
AS
37262011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3727
268c2c36 3728 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 3729 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
3730 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3731 * cm.c (losecursor): Likewise.
1dae0f0a
AS
3732 * data.c (fmod): Likewise.
3733 * dispnew.c (swap_glyphs_in_rows): Likewise.
3734 * emacs.c (memory_warning_signal): Likewise.
3735 * floatfns.c (float_error): Likewise.
3736 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3737 (otf_open, font_otf_capability, generate_otf_features)
3738 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3739 Likewise.
3740 * image.c (pbm_read_file): Likewise.
3741 * indent.c (string_display_width): Likewise.
3742 * intervals.c (check_for_interval, search_for_interval)
3743 (inc_interval_count, count_intervals, root_interval)
3744 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3745 * lread.c (defalias): Likewise.
268c2c36 3746 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
3747 * regex.c (set_image_of_range_1, set_image_of_range)
3748 (regex_grow_registers): Likewise.
3749 * sysdep.c (strerror): Likewise.
3750 * termcap.c (valid_filename_p, tprint, main): Likewise.
3751 * tparam.c (main): Likewise.
3752 * unexhp9k800.c (run_time_remap, save_data_space)
3753 (update_file_ptrs, read_header, write_header, calculate_checksum)
3754 (copy_file, copy_rest, display_header): Likewise.
3755 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3756 Likewise.
3757 * xdisp.c (check_it): Likewise.
3758 * xfaces.c (register_color, unregister_color, unregister_colors):
3759 Likewise.
3760 * xfns.c (print_fontset_result): Likewise.
3761 * xrdb.c (member, fatal, main): Likewise.
3762
99033785
PE
37632011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3764
3765 Fix minor problems found by static checking (Bug#9031).
3766 * chartab.c (char_table_set_range, map_sub_char_table):
3767 Remove unused locals.
3768 (uniprop_table): Now static.
3769 * composite.c (_work_char): Remove unused static var.
3770
9cb2ac56
JB
37712011-07-09 Juanma Barranquero <lekktu@gmail.com>
3772
3773 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3774
f25661f0
JD
37752011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3776
3777 * gtkutil.c (qttip_cb): Remove code without function.
3778
8278c4fe
EZ
37792011-07-09 Eli Zaretskii <eliz@gnu.org>
3780
3781 * w32.c (pthread_sigmask): New stub.
3782
1692ae2d 37832011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 3784
8a6ebd58 3785 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
3786 sigprocmask is portable only for single-threaded applications, and
3787 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
3788 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3789 (LIBES): Use it.
3790 * callproc.c (Fcall_process):
3791 * process.c (create_process):
3792 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3793 Use pthread_sigmask, not sigprocmask.
123403e4 3794
1b854618
JD
37952011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3796
3797 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3798 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3799 wrong (Bug#8591).
3800
3fe4b549
JD
38012011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3802
0ce7e563
JD
3803 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3804 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3805 (xg_hide_tooltip): Fix comment.
3806
3fe4b549
JD
3807 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3808 in registerServicesMenuSendTypes.
3809 (validRequestorForSendType): Don't check ns_return_types.
3810
3811 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3812 ns_return_type.
3813
5df75e47
JR
38142011-07-08 Jason Rumney <jasonr@gnu.org>
3815
22610910
JR
3816 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3817 SH_SHOW for hidden windows (Bug#5482).
3818
5df75e47
JR
3819 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3820 frame struct members of non-existent frames (Bug#6284).
3821
699c10bd
JD
38222011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3823
4393663b
JD
3824 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3825 variable firstTime not needed on OSX >= 10.6.
3826 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3827 >= 10.5. Use setKnobProportion, setDoubleValue.
3828
3829 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3830 (MAC_OS_X_VERSION_10_5): Define if not defined.
3831 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3832 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3833 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3834
3835 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3836 cString and lossyCString on OSX >= 10.4
3837
58179cce 3838 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
3839 sizeToFit on OSX >= 10.2.
3840
3841 * nsimage.m (allocInitFromFile): Don't use deprecated method
3842 bestRepresentationForDevice on OSX >= 10.6.
3843
3844 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3845 to avoid warning.
3846
3847 * emacs.c: Declare unexec_init_emacs_zone.
3848
a63e0781
JD
3849 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3850
699c10bd
JD
3851 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3852
3853 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3854 on svcsMenu (Bug#8842).
3855
3856 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3857 ns_return_types.
3858 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3859
3860 * nsterm.m (QUTF8_STRING): Declare.
3861 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3862 (validRequestorForSendType): Return type is (id).
3863 Change indexOfObjectIdenticalTo to indexOfObject.
3864 Check if we have local selection before returning self (Bug#8842).
3865 (writeSelectionToPasteboard): Put local selection into paste board
3866 if we have a local selection (Bug#8842).
3867 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3868
3869 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3870 (ns_get_local_selection): Declare.
3871
54e10184
LMI
38722011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3873
9888ff71
LMI
3874 * keymap.c (describe_map_tree): Don't insert a double newline at
3875 the end of the buffer (bug#1169) and return whether we inserted
3876 something.
3877
54e10184
LMI
3878 * callint.c (Fcall_interactively): Change "reading args" to
3879 "providing args" to try to clarify what it does (bug#1010).
3880
15fa4783
KH
38812011-07-07 Kenichi Handa <handa@m17n.org>
3882
3883 * composite.c (composition_compute_stop_pos): Ignore a static
3884 composition starting before CHARPOS (Bug#8915).
3885
3886 * xdisp.c (handle_composition_prop): Likewise.
3887
a8815b00
EZ
38882011-07-07 Eli Zaretskii <eliz@gnu.org>
3889
3890 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3891 (Bug#9015)
3892
ef7b981d 38932011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
3894
3895 * character.h (unicode_category_t): New enum type.
3896
3897 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3898 (Qchar_code_property_table): New variable.
3899 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3900 (UNIPROP_COMPRESSED_FORM_P): New macros.
3901 (char_table_ascii): Uncompress the compressed values.
3902 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3903 Uncompress the compressed values.
ac389d0c 3904 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
3905 (char_table_ref_and_range): Uncompress the compressed values.
3906 (sub_char_table_set): New arg is_uniprop. Callers changed.
3907 Uncompress the compressed values.
3908 (sub_char_table_set_range): Args changed. Callers changed.
3909 (char_table_set_range): Adjuted for the above change.
3910 (map_sub_char_table): Delete args default_val and parent. Add arg
3911 top. Give decoded values to a Lisp function.
640c8776 3912 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
3913 values to a Lisp function. Gcpro more variables.
3914 (uniprop_table_uncompress)
3915 (uniprop_decode_value_run_length): New functions.
3916 (uniprop_decoder, uniprop_decoder_count): New variables.
3917 (uniprop_get_decoder, uniprop_encode_value_character)
3918 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3919 New functions.
3920 (uniprop_encoder, uniprop_encoder_count): New variables.
3921 (uniprop_get_encoder, uniprop_table)
3922 (Funicode_property_table_internal, Fget_unicode_property_internal)
3923 (Fput_unicode_property_internal): New functions.
3924 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3925 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 3926 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
3927 char-code-property-alist.
3928
640c8776 3929 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
3930 Vunicode_category_table.
3931
640c8776 3932 * font.c (font_range): Adjust for the change of
c805dec0
KH
3933 Vunicode_category_table.
3934
76b397fb
DN
39352011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3936
3937 * m/iris4d.h: Remove file, move contents ...
3938 * s/irix6-5.h: ... here.
3939
22b4128e
PE
39402011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3941
3942 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
3943 * alloc.c (mark_buffer):
3944 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3945 (clone_per_buffer_values): Don't assume that
22b4128e
PE
3946 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3947 This isn't true in general, and it's particularly not true
3948 if Emacs is configured with --with-wide-int.
3949 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3950 New macros, used in the buffer.c change.
3951
869795d6
JD
39522011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3953
3954 * xsettings.c: Use both GConf and GSettings if both are available.
3955 (store_config_changed_event): Add comment.
3956 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3957 (store_tool_bar_style_changed): New functions.
5e617bc2 3958 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
3959 (struct xsettings): Move font inside HAVE_XFT.
3960 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 3961 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 3962 Move inside HAVE_XFT.
640c8776 3963 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
3964 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3965 also.
3966 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 3967 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 3968 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
3969 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3970 (parse_settings): Move check for font inside HAVE_XFT.
3971 (read_settings, apply_xft_settings): Add comment.
3972 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3973 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3974 call store_font_name_changed.
3975 (xft_settings_event): Add comment.
3976 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3977 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3978 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3979 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3980 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
3981 (xsettings_get_system_font, xsettings_get_system_normal_font):
3982 Add comment.
869795d6 3983
d8ed26bd
PE
39842011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3985
3986 Random fixes. E.g., (random) never returned negative values.
3987 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3988 subseconds part to the entropy, as that's a bit more random.
3989 Prefer signed to unsigned, since the signedness doesn't matter and
3990 in general we prefer signed. When given a limit, use a
3991 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3992 latter isn't right if USE_2_TAGS_FOR_INTS.
3993 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3994 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3995
cabf1cac
SM
39962011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3997
3998 * textprop.c (text_property_stickiness):
3999 Obey Vtext_property_default_nonsticky.
4000 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4001 * w32fns.c (syms_of_w32fns):
4002 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4003
6e9b2be9
PE
40042011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4005
4006 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4007 This is more efficient than Ffile_directory_p and avoids a minor race.
4008
90186c68
LMI
40092011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4010
7c301272
LMI
4011 * buffer.c (Foverlay_put): Say what the return value is
4012 (bug#7835).
4013
c4f2d8d4
LMI
4014 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4015 is a directory before asking whether to use the file name
4016 (bug#7564).
ad637907
LMI
4017 (barf_or_query_if_file_exists): Make the "File is a directory"
4018 error be more correct.
c4f2d8d4 4019
90186c68
LMI
4020 * fns.c (Frequire): Remove the mention of the .gz files, since
4021 that's installation-specific, but keep the mention of
4022 `get-load-suffixes'.
4023
da64016e
PE
40242011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4025
4026 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4027 Report string overflow if the output is too long.
4028
7d47b580
JB
40292011-07-04 Juanma Barranquero <lekktu@gmail.com>
4030
a555cb87
JB
4031 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4032 (syms_of_gnutls): Remove duplicate DEFSYM for
4033 Qgnutls_bootprop_verify_hostname_error, an error for
4034 Qgnutls_bootprop_verify_error (which is no longer used).
4035
7d47b580
JB
4036 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4037 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4038 Also (re)move comments that are misplaced or no longer relevant.
4039
1e49bfab
LMI
40402011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4041
4042 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4043
1485f4c0
CY
40442011-07-03 Chong Yidong <cyd@stupidchicken.com>
4045
4046 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4047 and background color parameters if they have been changed.
4048
a9ab721e
LMI
40492011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4050
4051 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4052
cf7cff57
PE
40532011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4054
2e13213d
PE
4055 * xsettings.c (SYSTEM_FONT): Define only when used.
4056 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4057
cf7cff57
PE
4058 * keymap.c (access_keymap_1): Now static.
4059
7a8e04f7
CY
40602011-07-02 Chong Yidong <cyd@stupidchicken.com>
4061
4062 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4063 leave any prefix arg for the up event (Bug#1586).
4064
61352f62
LMI
40652011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4066
69bb1ef7
LMI
4067 * lread.c (syms_of_lread): Mention single symbols defined by
4068 `defvar' or `defconst' (bug#7154).
4069
61352f62 4070 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 4071 (Frequire): Mention get-load-suffixes.
61352f62 4072
28545e04
MR
40732011-07-02 Martin Rudalics <rudalics@gmx.at>
4074
4075 * window.h (window): Remove clone_number slot.
4076 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4077 Remove.
4078 (make_parent_window, make_window, saved_window)
4079 (Fset_window_configuration, save_window_save): Don't deal with
4080 clone numbers.
4081 * buffer.c (Qclone_number): Remove declaration.
4082 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4083
3349e122
SM
40842011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4085
4086 Add multiple inheritance to keymaps.
4087 * keymap.c (Fmake_composed_keymap): New function.
4088 (Fset_keymap_parent): Simplify.
4089 (fix_submap_inheritance): Remove.
4090 (access_keymap_1): New function extracted from access_keymap to handle
4091 embedded parents and handle lists of maps.
4092 (access_keymap): Use it.
4093 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4094 (Fcopy_keymap): Handle embedded parents.
4095 (Fcommand_remapping, define_as_prefix): Simplify.
4096 (Fkey_binding): Simplify.
4097 (syms_of_keymap): Move minibuffer-local-completion-map,
4098 minibuffer-local-filename-completion-map,
4099 minibuffer-local-must-match-map, and
4100 minibuffer-local-filename-must-match-map to Elisp.
4101 (syms_of_keymap): Defsubr make-composed-keymap.
4102 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4103 (parse_menu_item): Trivial simplification.
4104
3279eb87
GM
41052011-07-01 Glenn Morris <rgm@gnu.org>
4106
4107 * Makefile.in (SETTINGS_LIBS): Fix typo.
4108
4550efdf
KI
41092011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4110
4111 * coding.c (Fencode_coding_string): Record the last coding system
4112 used, as the function doc string says (bug#8738).
4113
0949d2b6
JD
41142011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4115
4116 * xsettings.c (store_monospaced_changed): Take new font as arg and
4117 check for change against current_mono_font.
4118 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4119 (emacs_settings_constructor, emacs_settings_get_property)
4120 (emacs_settings_set_property, emacs_settings_class_init)
4121 (emacs_settings_init, gsettings_obj): Remove.
4122 (something_changedCB): New function for HAVE_GSETTINGS.
4123 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4124 with value as argument.
4125 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4126 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 4127 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
4128 "changed".
4129
4130 * xgselect.c: Add defined (HAVE_GSETTINGS).
4131 (xgselect_initialize): Ditto.
4132
4133 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4134 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4135 xg_select.
4136
bbc6b304
PE
41372011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4138
4139 * eval.c (struct backtrace): Simplify and port the data structure.
4140 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4141 signed bit field, as this assumption is not portable and it makes
4142 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4143 "char debug_on_exit : 1" as this is not portable either; instead,
4144 use the portable "unsigned int debug_on_exit : 1". Remove unused
4145 member evalargs. Remove obsolete comments about cc bombing out.
4146
9851bfc5
JD
41472011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4148
51bb811f 4149 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
4150 Let HAVE_GSETTINGS override HAVE_GCONF.
4151 (store_monospaced_changed): New function.
4152 (EMACS_SETTINGS): A new type derived from GObject to handle
4153 GSettings notifications.
4154 (emacs_settings_constructor, emacs_settings_get_property)
4155 (emacs_settings_set_property, emacs_settings_class_init):
4156 New functions.
4157 (gsettings_client, gsettings_obj): New variables.
4158 (GSETTINGS_SCHEMA): New define.
4159 (something_changedCB): Call store_monospaced_changed.
4160 (init_gsettings): New function.
4161 (xsettings_initialize): Call init_gsettings.
4162 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4163 to NULL.
4164
640c8776 4165 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
4166 GCONF_CFLAGS/LIBS.
4167
5386012d
MR
41682011-06-29 Martin Rudalics <rudalics@gmx.at>
4169
4170 * window.c (resize_root_window, grow_mini_window)
4171 (shrink_mini_window): Rename Qresize_root_window to
4172 Qwindow_resize_root_window and Qresize_root_window_vertically to
4173 Qwindow_resize_root_window_vertically.
4174
f13e0b08
PE
41752011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4176
4177 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4178
94515237
JB
41792011-06-27 Juanma Barranquero <lekktu@gmail.com>
4180
4181 * makefile.w32-in: Redesign dependencies so they reflect more
4182 clearly which files are directly included by each source file,
4183 and not through other includes.
4184
e43b6e43
MR
41852011-06-27 Martin Rudalics <rudalics@gmx.at>
4186
4187 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4188 (sort_overlays, overlay_strings): When an overlay's clone number
4189 matches the window's clone number process the overlay even if
4190 the overlay's window property doesn't match the current window.
4191
d68443dc
MR
4192 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4193 (Fwindow_hchild): Rename to Fwindow_left_child.
4194 (Fwindow_next): Rename to Fwindow_next_sibling.
4195 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
4196 (resize_window_check): Rename to window_resize_check.
4197 (resize_window_apply): Rename to window_resize_apply.
4198 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4199 (Fdelete_other_windows_internal, resize_frame_windows)
4200 (Fsplit_window_internal, Fdelete_window_internal)
4201 (grow_mini_window, shrink_mini_window)
4202 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 4203
c7e73be5
JD
42042011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4205
4206 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4207 (emacs_fixed_set_min_size): Remove.
4208 (emacs_fixed_new): Take frame as argument.
4209
4210 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4211 (_EmacsFixedPrivate): Remove minwidth/height.
4212 Add struct frame *f.
4213 (emacs_fixed_init): Initialize priv->f.
4214 (get_parent_class, emacs_fixed_set_min_size): Remove.
4215 (emacs_fixed_new): Set priv->f to argument.
4216 (emacs_fixed_get_preferred_width)
4217 (emacs_fixed_get_preferred_height): Use min_width/height from
4218 frames size_hint to set minimum and natural (Bug#8919).
4219 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4220 and use min_width/height from frames size_hint to set
4221 min_width/height (Bug#8919).
4222
4223 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
4224 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4225 Fix indentation.
c7e73be5 4226
cf99dcf8
EZ
42272011-06-26 Eli Zaretskii <eliz@gnu.org>
4228
4229 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4230 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4231 called at ZV.
4232
029529ac
CY
42332011-06-26 Chong Yidong <cyd@stupidchicken.com>
4234
4235 * process.c (wait_reading_process_output): Bypass select if
4236 waiting for a cell while ignoring keyboard input, and input is
4237 pending. Suggested by Jan Djärv (Bug#8869).
4238
7a7ef429
PE
42392011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4240
4241 Use gnulib's dup2 module instead of rolling our own.
4242 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4243
11fdef7d 42442011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
4245
4246 * dispnew.c (scrolling_window): Before scrolling, turn off a
4247 mouse-highlight in the window being scrolled.
4248
cd3520a4
JB
42492011-06-24 Juanma Barranquero <lekktu@gmail.com>
4250
4251 Move DEFSYM to lisp.h and use everywhere.
4252
4253 * character.h (DEFSYM): Move declaration...
4254 * lisp.h (DEFSYM): ...here.
4255
4256 * gnutls.c:
4257 * minibuf.c:
4258 * w32menu.c:
4259 * w32proc.c:
4260 * w32select.c: Don't include character.h.
4261
4262 * alloc.c (syms_of_alloc):
4263 * buffer.c (syms_of_buffer):
4264 * bytecode.c (syms_of_bytecode):
4265 * callint.c (syms_of_callint):
4266 * casefiddle.c (syms_of_casefiddle):
4267 * casetab.c (init_casetab_once):
4268 * category.c (init_category_once, syms_of_category):
4269 * ccl.c (syms_of_ccl):
4270 * cmds.c (syms_of_cmds):
4271 * composite.c (syms_of_composite):
4272 * dbusbind.c (syms_of_dbusbind):
4273 * dired.c (syms_of_dired):
4274 * dispnew.c (syms_of_display):
4275 * doc.c (syms_of_doc):
4276 * editfns.c (syms_of_editfns):
4277 * emacs.c (syms_of_emacs):
4278 * eval.c (syms_of_eval):
4279 * fileio.c (syms_of_fileio):
4280 * fns.c (syms_of_fns):
4281 * frame.c (syms_of_frame):
4282 * fringe.c (syms_of_fringe):
4283 * insdel.c (syms_of_insdel):
4284 * keymap.c (syms_of_keymap):
4285 * lread.c (init_obarray, syms_of_lread):
4286 * macros.c (syms_of_macros):
4287 * msdos.c (syms_of_msdos):
4288 * print.c (syms_of_print):
4289 * process.c (syms_of_process):
4290 * search.c (syms_of_search):
4291 * sound.c (syms_of_sound):
4292 * syntax.c (init_syntax_once, syms_of_syntax):
4293 * terminal.c (syms_of_terminal):
4294 * textprop.c (syms_of_textprop):
4295 * undo.c (syms_of_undo):
4296 * w32.c (globals_of_w32):
4297 * window.c (syms_of_window):
4298 * xdisp.c (syms_of_xdisp):
4299 * xfaces.c (syms_of_xfaces):
4300 * xfns.c (syms_of_xfns):
4301 * xmenu.c (syms_of_xmenu):
4302 * xsettings.c (syms_of_xsettings):
4303 * xterm.c (syms_of_xterm): Use DEFSYM.
4304
4228cf16
TZ
43052011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4306
cd3520a4 4307 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 4308
7fcccf1e
PE
43092011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4310
7efb4e0e
PE
4311 Integer and buffer overflow fixes (Bug#8873).
4312
ff5844ad
PE
4313 * print.c (printchar, strout): Check for string overflow.
4314 (PRINTPREPARE, printchar, strout):
4315 Don't set size unless allocation succeeds.
4316
90532f02
PE
4317 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4318 for sizes. Check for string overflow more accurately.
4319 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4320
6d84508d
PE
4321 * macros.c: Integer and buffer overflow fixes.
4322 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4323 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4324 Use ptrdiff_t, not int, for sizes.
4325 Don't increment bufsize until after realloc succeeds.
4326 Check for size-calculation overflow.
4327 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4328
437b2cb4
PE
4329 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4330
8b9ac8b4
PE
4331 * lread.c: Integer overflow fixes.
4332 (read_integer): Radix is now EMACS_INT, not int,
4333 to improve quality of diagnostics for out-of-range radices.
4334 Calculate buffer size correctly for out-of-range radices.
4335 (read1): Check for integer overflow in radices, and in
4336 read-circle numbers.
82cb60d3
PE
4337 (read_escape): Avoid int overflow.
4338 (Fload, openp, read_buffer_size, read1)
4339 (substitute_object_recurse, read_vector, read_list, map_obarray):
4340 Use ptrdiff_t, not int, for sizes.
4341 (read1): Use EMACS_INT, not int, for sizes.
20270765 4342 Check for size overflow.
8b9ac8b4 4343
7fcccf1e
PE
4344 * image.c (cache_image): Check for size arithmetic overflow.
4345
bfbbd7e7
PE
4346 * lread.c: Integer overflow issues.
4347 (saved_doc_string_size, saved_doc_string_length)
4348 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4349 Now ptrdiff_t, not int.
4350 (read1): Don't assume doc string length fits in int. Check for
4351 out-of-range doc string lengths.
4352 (read_list): Don't assume file position fits in int.
39019e54 4353 (read_escape): Check for hex character overflow.
bfbbd7e7 4354
4e323265
LL
43552011-06-22 Leo Liu <sdl.web@gmail.com>
4356
4357 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4358 Move to minibuffer.el.
4359
85fece3e
PE
43602011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4361
20b84ce9 4362 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
4363 The following patches are for when GLYPH_DEBUG && !XASSERT.
4364 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4365 * dispnew.c (flush_stdout):
4366 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4367 Mark as externally visible.
4368 * dispnew.c (check_window_matrix_pointers): Now static.
4369 * dispnew.c (window_to_frame_vpos):
4370 * xfns.c (unwind_create_frame):
4371 * xterm.c (x_check_font): Remove unused local.
4372 * scroll.c (CHECK_BOUNDS):
4373 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4374 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4375 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4376 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4377 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4378 Now static.
4379 (debug_method_add): Use va_list and vsprintf rather than relying
4380 on undefined behavior with wrong number of arguments.
4381 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4382 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4383 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4384 since we're not interested in debugging glyphs with old libraries.
4385 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4386 GCC 4.6.0's static checking.
4387
0766b489
PE
43882011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4389
31fd4b32
PE
4390 Integer overflow and signedness fixes (Bug#8873).
4391 A few related buffer overrun fixes, too.
4392
b79e8648
PE
4393 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4394
0766b489
PE
4395 * dispextern.h (struct face.stipple):
4396 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4397 (x_bitmap_mask, x_allocate_bitmap_record)
4398 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4399 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4400 (x_create_bitmap_from_xpm_data):
4401 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4402 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4403 (.bitmaps_last):
4404 * xfaces.c (load_pixmap):
4405 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4406 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4407 (.bitmaps_last, struct x_output.icon_bitmap):
4408 Use ptrdiff_t, not int, for bitmap indexes.
4409 (x_allocate_bitmap_record): Check for size overflow.
4410 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4411
b081724f
PE
4412 Use ptrdiff_t, not int, for overlay counts.
4413 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4414 * editfns.c (overlays_around, get_pos_property):
4415 * textprop.c (get_char_property_and_overlay):
4416 * xdisp.c (next_overlay_change, note_mouse_highlight):
4417 * xfaces.c (face_at_buffer_position):
21514da7
PE
4418 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4419 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4420 (Fnext_overlay_change, Fprevious_overlay_change)
4421 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 4422 Use ptrdiff_t, not int, for sizes.
21514da7 4423 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 4424
3de73e5e
PE
4425 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4426
2606c57b
PE
4427 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4428 (x_session_initialize): Do not assume string length fits in int.
4429
aaafe47a
PE
4430 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4431 This is unlikely, but can occur if DPI is outlandish.
4432
2674ddc8 4433 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
4434 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4435
28154962
PE
4436 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4437 * xrdb.c (magic_file_p, search_magic_path):
4438 Omit last arg SUFFIX; it was always 0. All callers changed.
4439 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4440
7de51af5
PE
4441 * xfont.c (xfont_match): Avoid need for strlen.
4442
25ed6cc3
PE
4443 * xfns.c: Don't assume strlen fits in int.
4444 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4445
4eab31dd
PE
4446 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4447 not unsigned long, as we prefer signed integers. All callers changed.
4448 Detect integer overflow in repeat count.
4449 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 4450 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 4451
171e2a58
PE
4452 * termcap.c: Don't assume sizes fit in int and never overflow.
4453 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4454 (gobble_line): Check for size-calculation overflow.
4455
ad39faca 4456 * minibuf.c (Fread_buffer):
6e5bb2dc 4457 * lread.c (intern, intern_c_string):
74ca2eb3
PE
4458 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4459 Don't assume string length fits in int.
4460
52c61c22 4461 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
4462 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4463
b5b8c9e5
PE
4464 * font.c: Don't assume string length fits in int.
4465 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4466 Use ptrdiff_t, not int.
ccd6111c
PE
4467 (font_intern_prop): Don't assume string length fits in int.
4468 Don't assume integer property fits in fixnum.
4469 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 4470
882f0d81 4471 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 4472 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
4473 Reformulate so as not to need the command string.
4474 Invoke gzip -cd rather than gunzip, as it's more portable.
4475 (lock_info_type, lock_file_1, lock_file):
4476 Don't assume pid_t and time_t fit in unsigned long.
4477 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4478 (current_lock_owner): Prefer signed type for sizes.
4479 Use memcpy, not strncpy, where memcpy is what is really wanted.
4480 Don't assume (via atoi) that time_t and pid_t fit in int.
4481 Check for time_t and/or pid_t out of range, e.g., via a network share.
4482 Don't alloca where an auto var works fine.
4483
93f4cf88
PE
4484 * fileio.c: Fix some integer overflow issues.
4485 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4486 Don't assume string length fits in int.
4487 (directory_file_name): Don't assume string length fits in long.
4488 (make_temp_name): Don't assume pid fits in int, or that its print
4489 length is less than 20.
4490
f3e92b69
PE
4491 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4492
1bfdaf10
PE
4493 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4494
35016e9a
PE
4495 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4496
3d1e65a1
PE
4497 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4498 We prefer signed integers, even for size calculations.
4499
0b963a93
PE
4500 * emacs.c: Don't assume string length fits in 'int'.
4501 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4502 (main): Don't invoke strlen when not needed.
4503
573f4b54
PE
4504 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4505 (XD_DEBUG_MESSAGE): Don't waste a byte.
4506
989f33ba
PE
4507 * callproc.c (getenv_internal_1, getenv_internal)
4508 (Fgetenv_internal):
965d34eb
PE
4509 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4510
e4d29b33
PE
4511 * lread.c (invalid_syntax): Omit length argument.
4512 All uses changed. This doesn't fix a bug, but it simplifies the
4513 code away from its former Hollerith-constant appearance, and it's
4514 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 4515 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 4516
eb49b136
PE
4517 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4518 This didn't break anything, but it didn't help either.
4519 It's confusing to put a bogus integer in a place where the actual
4520 value does not matter.
9f62aeb1 4521 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 4522 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 4523
15375a22
PE
4524 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4525 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4526 implementation.
b61cc01c
PE
4527 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4528 We prefer signed types, and the value cannot exceed the EMACS_INT
4529 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
4530 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4531 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4532 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 4533
53b2623d
PE
4534 * indent.c (sane_tab_width): New function.
4535 (current_column, scan_for_column, Findent_to, position_indentation)
4536 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 4537 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 4538
51cab52b 4539 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 4540
f2ed8a70
PE
4541 * lisp.h (lint_assume): New macro.
4542 * composite.c (composition_gstring_put_cache):
4543 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4544
abe80cc6
PE
4545 * editfns.c, insdel.c:
4546 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 4547
b02c740e
PE
4548 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4549
ebc96716
PE
4550 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4551
b4e50fa0 4552 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 4553 Use much-faster test for byte-length change.
311d5d7c 4554 Don't assume string byte-length fits in 'int'.
a4cf38e4 4555 Check that character arg fits in 'int'.
85461888 4556 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 4557
c0c1ee9f
PE
4558 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4559
a498d7f4
PE
4560 * fns.c (concat): Catch string overflow earlier.
4561 Do not rely on integer wraparound.
4562
51cab52b
PE
4563 * dispextern.h (struct it.overlay_strings_charpos)
4564 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
4565 * xdisp.c (forward_to_next_line_start)
4566 (back_to_previous_visible_line_start)
4567 (reseat_at_next_visible_line_start, next_element_from_buffer):
4568 Don't arbitrarily truncate the value of 'selective' to int.
4569
76031fad
PE
4570 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4571
5eb55db9
PE
4572 * composite.c: Don't truncate sizes to 'int'.
4573 (composition_gstring_p, composition_reseat_it)
4574 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
4575 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4576 not EMACS_UINT, for indexes.
5eb55db9 4577
0703a717
PE
4578 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4579
d6202519
PE
4580 * buffer.c: Include <verify.h>.
4581 (struct sortvec.priority, struct sortstr.priority):
8961a454 4582 Now EMACS_INT, not int.
c20998a7 4583 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
4584 (struct sortstr.size, record_overlay_string)
4585 (struct sortstrlist.size, struct sortlist.used):
4586 Don't truncate size to int.
4587 (record_overlay_string): Check for size-calculation overflow.
d6202519 4588 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 4589
d5a19415
JM
45902011-06-22 Jim Meyering <meyering@redhat.com>
4591
029529ac 4592 Don't leak an XBM-image-sized buffer
d5a19415
JM
4593 * image.c (xbm_load): Free the image buffer after using it.
4594
a9041e6c
PE
45952011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4596
4597 Port to Sun C.
4598 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4599 that Sun C diagnosed.
4600 * fns.c (secure_hash): Fix pointer signedness issue.
4601 * intervals.c (static_offset_intervals): New function.
4602 (offset_intervals): Use it.
4603
7f3f739f
LL
46042011-06-21 Leo Liu <sdl.web@gmail.com>
4605
4606 * deps.mk (fns.o):
4607 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4608 sha512.h.
4609
4610 * fns.c (secure_hash): Rename from crypto_hash_function and change
4611 the first arg to accept symbols.
5b66d427 4612 (Fsecure_hash): New primitive.
7f3f739f
LL
4613 (syms_of_fns): New symbols.
4614
76147d94
DD
46152011-06-20 Deniz Dogan <deniz@dogan.se>
4616
4617 * process.c (Fset_process_buffer): Clarify return value in
4618 docstring.
4619
7d7d0045
CY
46202011-06-18 Chong Yidong <cyd@stupidchicken.com>
4621
4622 * dispnew.c (add_window_display_history): Use BVAR.
4623
4624 * xdisp.c (debug_method_add): Use BVAR.
4625 (check_window_end, dump_glyph_matrix, dump_glyph)
4626 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4627
4628 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4629 Likewise.
4630
4631 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4632 check till after the cache is created in init_frame_faces.
4633
ff2bc410
SM
46342011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4635
4636 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4637
28177add
PE
46382011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4639
dd3482fe
PE
4640 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4641 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4642 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4643
393d71f3 4644 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
4645 * fileio.c (Finsert_file_contents):
4646 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4647 Remove the old (too-loose) buffer overflow checks.
4648 They weren't needed, since make_gap checks for buffer overflow.
4649 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4650 The old code merely checked for Emacs fixnum overflow, and relied
4651 on undefined (wraparound) behavior. The new code avoids undefined
4652 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4653
2e6813b0 4654 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
4655 Tune. Don't use wider integers than needed. Don't use alloca.
4656 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 4657
599a9e4f
PE
4658 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4659
99561444
PE
4660 * insdel.c, lisp.h (buffer_overflow): New function.
4661 (insert_from_buffer_1, replace_range, replace_range_2):
4662 * insdel.c (make_gap_larger):
4663 * editfns.c (Finsert_char):
4664 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4665
28177add
PE
4666 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4667
e69dafad
PE
46682011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4669
4baa020d 4670 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 4671
b1c46f02
PE
4672 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4673 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4674
e69dafad
PE
4675 * fileio.c: Don't assume EMACS_INT fits in off_t.
4676 (emacs_lseek): New static function.
4677 (Finsert_file_contents, Fwrite_region): Use it.
4678 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4679
566684ea
PE
4680 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4681
e6966cd6
PE
4682 * fns.c: Don't overflow int when computing a list length.
4683 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4684 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4685 truncation on 64-bit hosts. Check for QUIT every
4686 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4687 faster and is responsive enough.
4688 (Flength): Report an error instead of overflowing an integer.
4689 (Fsafe_length): Return a float if the value is not representable
4690 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 4691 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 4692 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 4693
dd0b0efb
PE
4694 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4695 (header_size, word_size): New constants.
4696 (allocate_vectorlike): Don't check size overflow here.
4697 (allocate_vector): Check it here instead, since this is the only
4698 caller of allocate_vectorlike that could cause overflow.
4699 Check that the new vector's length is representable as a fixnum.
4700
86fe5cfe
PE
4701 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4702 The previous code was bogus. For example, next_almost_prime (32)
4703 returned 39, which is undesirable as it is a multiple of 3; and
4704 next_almost_prime (24) returned 25, which is a multiple of 5 so
4705 why was the code bothering to check for multiples of 7?
4706
80e88859
PE
4707 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4708
4a2f0ad6
PE
4709 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4710
f66c7cf8
PE
4711 Variadic C functions now count arguments with ptrdiff_t.
4712 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4713 Back then I didn't know that the Emacs coding style prefers signed int.
4714 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
4715 were being counted with int, which may truncate counts on 64-bit
4716 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
4717 * lisp.h (struct Lisp_Subr.function.aMANY)
4718 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4719 Arg counts are now ptrdiff_t, not size_t.
4720 All variadic functions and their callers changed accordingly.
4721 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4722 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4723 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4724 * callint.c (Fcall_interactively): Check arg count for overflow,
4725 to avoid potential buffer overrun. Use signed char, not 'int',
4726 for 'varies' array, so that we needn't bother to check its size
4727 calculation for overflow.
4728 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4729 * eval.c (apply_lambda):
4730 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4731 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4732 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4733
a1759b76
PE
4734 * callint.c (Fcall_interactively): Don't use index var as event count.
4735
d96be9fc
PE
4736 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4737 * mem-limits.h (SIZE): Remove; no longer used.
4738
a690a978 4739 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 4740
578c21e6
PE
4741 Remove unnecessary casts.
4742 * xterm.c (x_term_init):
4743 * xfns.c (x_set_border_pixel):
4744 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4745 These aren't needed now that we assume ANSI C.
4746
96f53c6c
PE
4747 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4748 It's more likely to cause problems (due to unsigned overflow)
4749 than to cure them.
4750
83c77d31
PE
4751 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4752
ee2079f1
PE
4753 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4754
6da65536
PE
4755 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4756
7147c4a4
PE
4757 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4758
193e32d9
PE
4759 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4760
e5533da6
PE
4761 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4762
9910e595
PE
4763 GLYPH_CODE_FACE returns EMACS_INT, not int.
4764 * dispextern.h (merge_faces):
4765 * xfaces.c (merge_faces):
01103c44
PE
4766 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4767 Don't assume EMACS_INT fits in int.
9910e595 4768
2638320e
PE
4769 * character.h (CHAR_VALID_P): Remove unused parameter.
4770 * fontset.c, lisp.h, xdisp.c: All uses changed.
4771
045eb8d9
PE
4772 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4773
c1f134b5
PE
4774 * fns.c (concat): Minor tuning based on overflow analysis.
4775 This doesn't fix any bugs. Use int to hold character, instead
4776 of constantly refetching from Emacs object. Use XFASTINT, not
4777 XINT, for value known to be a character. Don't bother comparing
4778 a single byte to 0400, as it's always less.
4779
395fcb93 4780 * floatfns.c (Fexpt):
327eeec8
PE
4781 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4782
abbd3d23
PE
4783 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4784 for characters.
4785
684a03ef
PE
4786 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4787
0fed43f3
PE
4788 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4789 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4790 incorrectly succeed when S was a string, because 4294967386 was
4791 truncated before it was used.
4792
8fd02eb7
PE
4793 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4794 Otherwise, an out-of-range integer could cause undefined behavior
4795 on a 64-bit host.
4796
f8c86b69
PE
4797 * composite.c: Use int, not EMACS_INT, for characters.
4798 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4799 EMACS_INT, for values that are known to be in character range.
4800 This doesn't fix any bugs but is the usual style inside Emacs and
4801 may generate better code on 32-bit machines.
4802
34206dd2
PE
4803 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4804 This is for reasons similar to the recent CHAR_STRING fix.
4805 * charset.c (Fencode_char): Check that character arg is actually
4806 a character. Pass an int to ENCODE_CHAR.
4807 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4808 wider than 'int', as a compile-time check to prevent future regressions
4809 in this area.
4810
c5958d4c 4811 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
4812
4813 Make sure a 64-bit char is never passed to CHAR_STRING.
4814 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4815 by silently ignoring the top 32 bits, allowing some values
4816 that were far too large to be valid characters.
4817 * character.h: Include <verify.h>.
4818 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4819 arguments are no wider than unsigned, as a compile-time check
4820 to prevent future regressions in this area.
4821 * data.c (Faset):
01103c44 4822 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
4823 (Fsubst_char_in_region):
4824 * fns.c (concat):
4825 * xdisp.c (decode_mode_spec_coding):
4826 Adjust to CHAR_STRING's new requirement.
4827 * editfns.c (Finsert_char, Fsubst_char_in_region):
4828 * fns.c (concat): Check that character args are actually
4829 characters. Without this test, these functions did the wrong
4830 thing with wildly out-of-range values on 64-bit hosts.
4831
d37ca623
PE
4832 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4833 These casts should not be needed on 32-bit hosts, either.
4834 * keyboard.c (read_char):
4835 * lread.c (Fload): Remove casts to unsigned.
4836
ea204efb
PE
4837 * lisp.h (UNSIGNED_CMP): New macro.
4838 This fixes comparison bugs on 64-bit hosts.
4839 (ASCII_CHAR_P): Use it.
4840 * casefiddle.c (casify_object):
01103c44 4841 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
4842 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4843 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4844 * dispextern.h (FACE_FROM_ID):
4845 * keyboard.c (read_char): Use UNSIGNED_CMP.
4846
41cb286c
PE
4847 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4848 not to EMACS_INT, to avoid GCC warning.
4849
4a1b9832
PE
4850 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4851
55daad71
PE
4852 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4853 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4854 isn't needed on 32-bit machines.
8f95c75c 4855
01103c44
PE
4856 * buffer.c (Fgenerate_new_buffer_name):
4857 Use EMACS_INT for count, not int.
0ceccced 4858 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
4859
4860 * data.c (Qcompiled_function): Now static.
4861
c6f072e7
PE
4862 * window.c (window_body_lines): Now static.
4863
20ce5912
PE
4864 * image.c (gif_load): Rename local to avoid shadowing.
4865
9c4c5f81
PE
4866 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4867 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4868 * alloc.c (make_save_value): Integer argument is now of type
4869 ptrdiff_t, not int.
4870 (mark_object): Use ptrdiff_t, not int.
4871 * lisp.h (pD): New macro.
4872 * print.c (print_object): Use it.
4873
c0c5c8ae
PE
4874 * alloc.c: Use EMACS_INT, not int, to count objects.
4875 (total_conses, total_markers, total_symbols, total_vector_size)
4876 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
4877 (total_free_floats, total_floats, total_free_intervals)
4878 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
4879 Now EMACS_INT, not int. All uses changed.
4880 (Fgarbage_collect): Compute overall total using a double, so that
4881 integer overflow is less likely to be a problem. Check for overflow
4882 when converting back to an integer.
5a25e253
PE
4883 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4884 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4885 These were 'int' variables that could overflow on 64-bit hosts;
4886 they were never used, so remove them instead of repairing them.
211a0b2a 4887 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
4888 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4889 Previously, this ceilinged at INT_MAX, but that doesn't work on
4890 64-bit machines.
e46bb31a 4891 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 4892
c78baabf 4893 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 4894 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
4895 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4896 when a (possibly-narrower) signed value would do just as well.
4897 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 4898
c9d624c6
PE
4899 * alloc.c: Catch some string size overflows that we were missing.
4900 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4901 for convenience in STRING_BYTES_MAX.
4902 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4903 The definition here is exact; the one in lisp.h was approximate.
4904 (allocate_string_data): Check for string overflow. This catches
4905 some instances we weren't catching before. Also, it catches
4906 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4907 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4908 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 4909
c9d624c6
PE
4910 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4911 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 4912 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 4913
353032ce
PE
4914 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4915
2bccce07
PE
4916 * alloc.c (Fmake_string): Check for out-of-range init.
4917
0ac30604
SM
49182011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4919
4920 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4921
c195f2de
JD
49222011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4923
4924 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4925 xg_get_default_scrollbar_width.
4926
4927 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4928 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4929 (style_changed_cb): Call update_theme_scrollbar_width and call
4930 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4931 all frames (Bug#8505).
4932 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4933 Call gtk_window_set_resizable if HAVE_GTK3.
4934 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4935 and height if HAVE_GTK3 (Bug#8505).
4936 (scroll_bar_width_for_theme): New variable.
4937 (update_theme_scrollbar_width): New function.
4938 (xg_get_default_scrollbar_width): Move code to
4939 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4940 (xg_initialize): Call update_theme_scrollbar_width.
4941
4942 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4943
4944 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4945
e10ac9f1
MR
49462011-06-12 Martin Rudalics <rudalics@gmx.at>
4947
4948 * frame.c (make_frame): Call other_buffer_safely instead of
4949 other_buffer.
4950
4951 * window.c (temp_output_buffer_show): Call display_buffer with
4952 second argument Vtemp_buffer_show_specifiers and reset latter
4953 immediately after the call.
4954 (Vtemp_buffer_show_specifiers): New variable.
4955 (auto_window_vscroll_p, next_screen_context_lines)
4956 (Vscroll_preserve_screen_position): Remove leading asterisks from
4957 doc-strings.
4958
2d3c217e 49592011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 4960
7b7f97e8 4961 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
4962 * buffer.c (Qclone_number): Remove for now, as it's unused.
4963 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4964 (record_buffer): Remove unused local.
4965 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4966 (set_frame_buffer_list): Remove; unused.
4967 * frame.h (other_visible_frames): Remove decl.
4968 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4969 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4970 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4971 if HAVE_GPM.
4972 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4973 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4974 Define only if HAVE_GPM.
4975 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4976 (update_hints_inhibit): Remove; never set. All uses removed.
4977 * widgetprv.h (emacsFrameClassRec): Remove decl.
4978 * window.c (delete_deletable_window): Now returns void, since it
4979 wasn't returning anything.
4980 (compare_window_configurations): Remove unused locals.
4981 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4982 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
4983 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4984 the same widths as pointers. This follows up on the 2011-05-06 patch.
4985 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4986 * xterm.h: Likewise.
4987 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4988
1384b89e
JB
49892011-06-12 Juanma Barranquero <lekktu@gmail.com>
4990
4991 * makefile.w32-in: Update dependencies.
4992 (LISP_H): Add lib/intprops.h.
4993
1100a63c
CY
49942011-06-11 Chong Yidong <cyd@stupidchicken.com>
4995
4996 * image.c (gif_load): Add animation frame delay to the metadata.
4997 (syms_of_image): Use DEFSYM. New symbol `delay'.
4998
6198ccd0
MR
49992011-06-11 Martin Rudalics <rudalics@gmx.at>
5000
5001 * window.c (delete_deletable_window): Re-add.
5002 (Fset_window_configuration): Rewrite to handle dead buffers and
5003 consequently deletable windows.
5004 (window_tree, Fwindow_tree): Remove. Supply functionality in
5005 window.el.
5006 (compare_window_configurations): Simplify code.
5007
b6e3633c
AS
50082011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5009
1ab0dee5
AS
5010 * image.c (imagemagick_load_image): Fix type mismatch.
5011 (Fimagemagick_types): Likewise.
5012
b6e3633c
AS
5013 * window.h (replace_buffer_in_windows): Declare.
5014
9397e56f
MR
50152011-06-11 Martin Rudalics <rudalics@gmx.at>
5016
5017 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5018 Qclone_number. Remove external declaration of Qdelete_window.
5019 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5020 code.
640c8776
SM
5021 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5022 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
5023 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5024 buffer list implementation.
5025 (other_buffer_safely): New function.
5026 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5027 calls to replace_buffer_in_windows and
5028 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5029 if allowed.
5030 (record_buffer): Inhibit quitting and rewrite using quittable
5031 functions. Run Qbuffer_list_update_hook if allowed.
5032 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
5033 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5034 Move switch-to-buffer to window.el.
9397e56f
MR
5035 (bury-buffer): Move to window.el.
5036 (Vbuffer_list_update_hook): New variable.
5037
5038 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5039 section.
5040
5041 * window.h (resize_frame_windows): Move up in code.
5042 (Fwindow_frame): Remove EXFUN.
5043 (replace_buffer_in_all_windows): Remove prototype.
5044 (replace_buffer_in_windows_safely): Add prototype.
5045
5046 * window.c: Declare Qdelete_window static again. Move down
5047 declaration of select_count.
5048 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5049 (Fother_window): Move to window.el.
5050 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5051 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5052 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5053 window.el.
5054 (replace_buffer_in_windows): Implement by calling
5055 Qreplace_buffer_in_windows.
5056 (replace_buffer_in_all_windows): Remove with some functionality
5057 moved into replace_buffer_in_windows_safely.
5058 (replace_buffer_in_windows_safely): New function.
5059 (select_window_norecord, select_frame_norecord): Move in front
5060 of run_window_configuration_change_hook. Remove now obsolete
5061 declarations.
640c8776
SM
5062 (Fset_window_buffer): Rewrite doc-string.
5063 Call Qrecord_window_buffer.
9397e56f
MR
5064 (keys_of_window): Move binding for other-window to window.el.
5065
b50691aa
CY
50662011-06-11 Chong Yidong <cyd@stupidchicken.com>
5067
5068 * dispextern.h (struct image): Replace data member, whose int_val
5069 and ptr_val fields were not used by anything, with a single
5070 lisp_val object.
5071
5072 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5073 (gif_clear_image, gif_load, imagemagick_load_image)
5074 (gs_clear_image, gs_load): Callers changed.
5075
3f754b86
PE
50762011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5077
cca69397
PE
5078 * buffer.h: Include <time.h>, for time_t.
5079 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5080
109e28d0
PE
5081 Fix minor problems found by static checking.
5082
60737f02
PE
5083 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5084
4b66faf3
PE
5085 Make identifiers static if they are not used in other modules.
5086 * data.c (Qcompiled_function, Qframe, Qvector):
5087 * image.c (QimageMagick, Qsvg):
5088 * minibuf.c (Qmetadata):
5089 * window.c (resize_window_check, resize_root_window): Now static.
5090 * window.h (resize_window_check, resize_root_window): Remove decls.
5091
109e28d0
PE
5092 * window.c (window_deletion_count, delete_deletable_window):
5093 Remove; unused.
46a4ce9e
PE
5094 (window_body_lines): Now static.
5095 (Fdelete_other_windows_internal): Mark vars as initialized.
5096 Make sure 'resize_failed' is initialized.
5097 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5098 (resize_window_apply): Remove unused local.
5099 * window.h (delete_deletable_window): Remove decl.
5100
109e28d0 5101 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
5102 (imagemagick_load_image): Fix pointer signedness problem by changing
5103 last arg from unsigned char * to char *. All uses changed.
5104 Also, fix a local for similar reasons.
5105 Remove unused locals. Remove locals to avoid shadowing.
5106 (fn_rsvg_handle_free): Remove; unused.
5107 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 5108 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 5109
3f754b86
PE
5110 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5111
2547adb1
CY
51122011-06-10 Chong Yidong <cyd@stupidchicken.com>
5113
5114 * image.c (gif_load): Fix omitted cast error introduced by
5115 2011-06-06 change.
5116
2c8e37d4
MR
51172011-06-10 Martin Rudalics <rudalics@gmx.at>
5118
5119 * window.h (resize_proportionally, orig_total_lines)
5120 (orig_top_line): Remove from window structure.
5121 (set_window_height, set_window_width, change_window_heights)
5122 (Fdelete_window): Remove prototypes.
5123 (resize_frame_windows): Remove duplicate declaration.
5124
440a42e3
EZ
51252011-06-10 Eli Zaretskii <eliz@gnu.org>
5126
5127 * window.h (resize_frame_windows, resize_window_check)
5128 (delete_deletable_window, resize_root_window)
5129 (resize_frame_windows): Declare prototypes.
5130
5131 * window.c (resize_window_apply): Make definition be "static" to
5132 match the prototype.
5133
562dd5e9
MR
51342011-06-10 Martin Rudalics <rudalics@gmx.at>
5135
5136 * window.c: Remove declarations of Qwindow_size_fixed,
5137 window_min_size_1, window_min_size_2, window_min_size,
5138 size_window, window_fixed_size_p, enlarge_window, delete_window.
5139 Remove static from declaration of Qdelete_window, it's
5140 temporarily needed by Fbury_buffer.
5141 (replace_window): Don't assign orig_top_line and
5142 orig_total_lines.
5143 (Fdelete_window, delete_window): Remove. Window deletion is
5144 handled by window.el.
640c8776
SM
5145 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5146 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
5147 (Fdelete_other_windows): Remove. Deleting other windows is
5148 handled by window.el.
5149 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5150 handled in window.el.
5151 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5152 Window minimum sizes are handled in window.el.
5153 (shrink_windows, size_window, set_window_height)
5154 (set_window_width, change_window_heights, window_height)
5155 (window_width, CURBEG, CURSIZE, enlarge_window)
5156 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5157 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5158 handled in window.el.
5159 (make_dummy_parent): Rename to make_parent_window and give it a
5160 second argument horflag.
5161 (make_window): Don't set resize_proportionally any more.
5162 (Fsplit_window): Remove. Windows are split in window.el.
5163 (save_restore_action, save_restore_orig_size)
5164 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5165 Resize mini windows in window.el.
5166 (grow_mini_window, shrink_mini_window): Implement by calling
5167 Qresize_root_window_vertically, resize_window_check and
5168 resize_window_apply.
640c8776
SM
5169 (saved_window, Fset_window_configuration, save_window_save):
5170 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
5171 resize_proportionally.
5172 (window_min_height, window_min_width): Move to window.el.
5173 (keys_of_window): Move bindings for delete-other-windows,
5174 split-window, delete-window and enlarge-window to window.el.
5175
5176 * buffer.c: Temporarily extern Qdelete_window.
5177 (Fbury_buffer): Temporarily call Qdelete_window instead of
5178 Fdelete_window (Fbury_buffer will move to window.el soon).
5179
5180 * frame.c (set_menu_bar_lines_1): Remove code handling
5181 orig_top_line and orig_total_lines.
5182
5183 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5184 set_window_height but set heights directly.
5185 (change_frame_size_1): Use resize_frame_windows.
5186
5187 * xdisp.c (init_xdisp): Don't use set_window_height but set
5188 heights directly.
5189
640c8776
SM
5190 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5191 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
5192 run_window_configuration_change_hook.
5193
5194 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5195 instead of change_window_heights and run
5196 run_window_configuration_change_hook.
5197
1a13852e
MR
51982011-06-09 Martin Rudalics <rudalics@gmx.at>
5199
5200 * window.c (replace_window): Rename second argument REPLACEMENT to
5201 NEW. New third argument SETFLAG. Rewrite.
5202 (delete_window, make_dummy_parent): Call replace_window with
5203 third argument 1.
5204 (window_list_1): Move down in code.
5205 (run_window_configuration_change_hook): Move set_buffer part
5206 before select_frame_norecord part in order to unwind correctly.
5207 Rename count1 to count.
5208 (recombine_windows, delete_deletable_window, resize_root_window)
5209 (Fdelete_other_windows_internal)
5210 (Frun_window_configuration_change_hook, make_parent_window)
5211 (resize_window_check, resize_window_apply, Fresize_window_apply)
5212 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
5213 (Fdelete_window_internal, Fresize_mini_window_internal):
5214 New functions.
1a13852e
MR
5215 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5216
f3d1777e
MR
52172011-06-08 Martin Rudalics <rudalics@gmx.at>
5218
496e208e
MR
5219 * window.h (window): Add some new members to window structure -
5220 normal_lines, normal_cols, new_total, new_normal, clone_number,
5221 splits, nest, prev_buffers, next_buffers.
5222 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 5223 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 5224
f3d1777e
MR
5225 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5226 Remove.
496e208e
MR
5227 (make_dummy_parent): Set new members of windows structure.
5228 (make_window): Move down in code. Handle new members of window
5229 structure.
5230 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5231 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5232 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5233 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
5234 (Fset_window_next_buffers, Fset_window_clone_number):
5235 New functions.
496e208e
MR
5236 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5237 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5238 Doc-string fixes.
5239 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5240 Argument WINDOW can be now internal window too.
5241 (Fwindow_use_time): Move up in code.
5242 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5243 Rewrite doc-string.
5244 (Fset_window_configuration, saved_window)
5245 (Fcurrent_window_configuration, save_window_save): Handle new
5246 members of window structure.
b9e809c2
MR
5247 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5248 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5249 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5250 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5251 Qget_mru_window, Qresize_root_window,
5252 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5253 Qauto_buffer_name; staticpro them.
f3d1777e 5254
abde8f8c
MR
52552011-06-07 Martin Rudalics <rudalics@gmx.at>
5256
5257 * window.c (Fwindow_total_size, Fwindow_left_column)
5258 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5259 (Fwindow_list_1): New functions.
5260 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
5261 (Fwindow_width, Fscroll_left, Fscroll_right):
5262 Use window_body_cols instead of window_box_text_cols.
5263 (delete_window, Fset_window_configuration):
5264 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
5265 (delete_all_subwindows): Take a window as argument and not a
5266 structure. Rewrite.
190b47e6
MR
5267 (window_loop): Remove handling of GET_LRU_WINDOW and
5268 GET_LARGEST_WINDOW.
5269 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
5270
5271 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
5272 window_box_text_cols. delete_all_subwindows now takes a
5273 Lisp_Object as argument.
abde8f8c 5274
640c8776
SM
5275 * indent.c (compute_motion, Fcompute_motion):
5276 Use window_body_cols instead of window_box_text_cols.
abde8f8c 5277
fa8a67e6
MR
5278 * frame.c (delete_frame): Call delete_all_subwindows with root
5279 window as argument.
5280
a54e3482
DC
52812011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5282
5283 * fns.c (Fputhash): Document return value.
5284
60002bf5
CY
52852011-06-06 Chong Yidong <cyd@stupidchicken.com>
5286
5287 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5288
0c671da6 52892011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 5290
b862a52a 5291 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 5292
be44ca6c
PE
5293 Check for overflow when converting integer to cons and back.
5294 * charset.c (Fdefine_charset_internal, Fdecode_char):
5295 Use cons_to_unsigned to catch overflow.
5296 (Fencode_char): Use INTEGER_TO_CONS.
5297 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5298 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5299 * data.c (long_to_cons, cons_to_long): Remove.
5300 (cons_to_unsigned, cons_to_signed): New functions.
5301 These signal an error for invalid or out-of-range values.
5302 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5303 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5304 * font.c (Ffont_variation_glyphs):
5305 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5306 * lisp.h: Include <intprops.h>.
5307 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5308 (cons_to_signed, cons_to_unsigned): New decls.
5309 (long_to_cons, cons_to_long): Remove decls.
5310 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5311 (Fprimitive_undo): Use CONS_TO_INTEGER.
5312 * xfns.c (Fx_window_property): Likewise.
5313 * xselect.c: Include <limits.h>.
5314 (x_own_selection, selection_data_to_lisp_data):
5315 Use INTEGER_TO_CONS.
5316 (x_handle_selection_request, x_handle_selection_clear)
5317 (x_get_foreign_selection, Fx_disown_selection_internal)
5318 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5319 (lisp_data_to_selection_data): Use cons_to_unsigned.
5320 (x_fill_property_data): Use cons_to_signed.
5321 Report values out of range.
5322
d1f3d2af
PE
5323 Check for buffer and string overflow more precisely.
5324 * buffer.h (BUF_BYTES_MAX): New macro.
5325 * lisp.h (STRING_BYTES_MAX): New macro.
5326 * alloc.c (Fmake_string):
5327 * character.c (string_escape_byte8):
5328 * coding.c (coding_alloc_by_realloc):
5329 * doprnt.c (doprnt):
5330 * editfns.c (Fformat):
5331 * eval.c (verror):
5332 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5333 since they may not be the same number.
5334 * editfns.c (Finsert_char):
5335 * fileio.c (Finsert_file_contents):
5336 Likewise for BUF_BYTES_MAX.
5337
dd52fcea
PE
5338 * image.c: Use ptrdiff_t, not int, for sizes.
5339 (slurp_file): Switch from int to ptrdiff_t.
5340 All uses changed.
5341 (slurp_file): Check that file size fits in both size_t (for
5342 malloc) and ptrdiff_t (for sanity and safety).
5343
7f9bbdbb
PE
5344 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5345 if b->modtime has its maximal value.
5346
dfe18f82
PE
5347 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5348
84acfcf0
PE
5349 Don't assume time_t can fit into int.
5350 * buffer.h (struct buffer.modtime): Now time_t, not int.
5351 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5352 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5353
ccd9a01a
PE
5354 Minor fixes for signed vs unsigned integers.
5355 * character.h (MAYBE_UNIFY_CHAR):
5356 * charset.c (maybe_unify_char):
5357 * keyboard.c (read_char, reorder_modifiers):
5358 XINT -> XFASTINT, since the integer must be nonnegative.
5359 * ftfont.c (ftfont_spec_pattern):
5360 * keymap.c (access_keymap, silly_event_symbol_error):
5361 XUINT -> XFASTINT, since the integer must be nonnegative.
5362 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5363 since it makes no difference and we prefer signed.
5364 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5365 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5366 nonnegative.
5367
d6d100dd
SM
53682011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5369
5370 * window.h (Fwindow_frame): Declare.
5371
2b6148e4
PE
53722011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5373
5374 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5375 (SPARE_MEMORY): Always define.
5376 (LARGE_REQUEST): Remove.
5377 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5378
f230ecc9
MR
53792011-06-06 Martin Rudalics <rudalics@gmx.at>
5380
727e958e
MR
5381 * lisp.h: Move EXFUNS for Fframe_root_window,
5382 Fframe_first_window and Fset_frame_selected_window to window.h.
5383
5384 * window.h: Move EXFUNS for Fframe_root_window,
5385 Fframe_first_window and Fset_frame_selected_window here from
5386 lisp.h.
5387
5388 * frame.c (Fwindow_frame, Fframe_first_window)
5389 (Fframe_root_window, Fframe_selected_window)
5390 (Fset_frame_selected_window): Move to window.c.
5391 (Factive_minibuffer_window): Move to minibuf.c.
5392 (Fother_visible_frames_p): New function.
5393
5394 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5395
f230ecc9
MR
5396 * window.c (decode_window, decode_any_window): Move up in code.
5397 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5398 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
5399 (Fwindow_buffer): Move up and rewrite doc-string.
5400 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5401 (Fwindow_prev): New functions.
727e958e
MR
5402 (Fwindow_frame): Move here from frame.c. Accept any window as
5403 argument.
5404 (Fframe_root_window, Fframe_first_window)
5405 (Fframe_selected_window): Move here from frame.c. Accept frame
5406 or arbitrary window as argument. Update doc-strings.
5407 (Fminibuffer_window): Move up in code.
5408 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
5409 (Fset_frame_selected_window): Move here from frame.c.
5410 Marginal rewrite.
727e958e
MR
5411 (Fselected_window, select_window, Fselect_window): Move up in
5412 code. Minor doc-string fixes.
f230ecc9 5413
4d09bcf6
PE
54142011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5415
5416 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5417 Do not assume that spare memory exists; that assumption is valid
5418 only if SYSTEM_MALLOC.
5419 (LARGE_REQUEST): New macro, so that the issue of large requests
5420 is separated from the issue of spare memory.
5421
810928a2
AS
54222011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5423
172418ad
AS
5424 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5425 format. (Bug#8806)
5426
43f862f7
AS
5427 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5428
810928a2
AS
5429 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5430 before statements.
5431
a059fe24
JD
54322011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5433
5434 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5435
5436 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5437
5438 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5439 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5440
989bf368
JB
54412011-06-05 Juanma Barranquero <lekktu@gmail.com>
5442
5443 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5444
4b80f674
CY
54452011-06-04 Chong Yidong <cyd@stupidchicken.com>
5446
5447 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5448 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
5449 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5450 New error handlers.
4b80f674
CY
5451 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5452 Obey Vx_select_enable_clipboard_manager. Catch errors in
5453 x_clipboard_manager_save (Bug#8779).
5454 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 5455 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 5456
99a33b77 54572011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
5458
5459 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5460
99a33b77 54612011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
5462
5463 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5464 in the current matrix if keep_current_p is non-zero.
5465
8264569d
EZ
54662011-06-04 Eli Zaretskii <eliz@gnu.org>
5467
5468 * bidi.c (bidi_level_of_next_char): Fix last change.
5469
57f97249
EZ
54702011-06-03 Eli Zaretskii <eliz@gnu.org>
5471
fec2107c 5472 Support bidi reordering of text covered by display properties.
57f97249 5473
fec2107c
EZ
5474 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5475 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5476 (bidi_cache_search, bidi_cache_iterator_state)
5477 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
5478 (bidi_level_of_next_char, bidi_move_to_visually_next):
5479 Support character positions inside a run of characters covered by a
fec2107c
EZ
5480 display string.
5481 (bidi_paragraph_init, bidi_resolve_explicit_1)
5482 (bidi_level_of_next_char): Call bidi_fetch_char and
5483 bidi_fetch_char_advance instead of FETCH_CHAR and
5484 FETCH_CHAR_ADVANCE.
5485 (bidi_init_it): Initialize new members.
5486 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5487 definitions.
5488 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5489 instead of using explicit *_CHAR codes.
d6d100dd
SM
5490 (bidi_resolve_explicit, bidi_resolve_weak):
5491 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
5492 bidirectional text is supported only in multibyte buffers.
5493 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5494 it to initialize the frame_window_p member of struct bidi_it.
5495 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5496 (bidi_resolve_explicit, bidi_resolve_weak)
5497 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5498 bidi_it->nchars is non-positive.
5499 (bidi_level_of_next_char): Don't try to lookup the cache for the
5500 next/previous character if nothing is cached there yet, or if we
5501 were just reseat()'ed to a new position.
c40e2fb2 5502
0e14fe90
EZ
5503 * xdisp.c (set_cursor_from_row): Set start and stop points
5504 according to the row's direction when priming the loop that looks
5505 for the glyph on which to display cursor.
5506 (single_display_spec_intangible_p): Function deleted.
5507 (display_prop_intangible_p): Reimplement to call
5508 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
5509 Accept 3 additional arguments needed by handle_display_spec.
5510 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
5511 values: lists, `(when COND...)' forms, etc.
5512 (single_display_spec_string_p): Support property values that are
5513 lists with the argument STRING its top-level element.
5514 (display_prop_string_p): Fix the condition for processing a
5515 property that is a list to be consistent with handle_display_spec.
fec2107c 5516 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
5517 last portion of handle_display_prop.
5518 (compute_display_string_pos): Accept additional argument
5519 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5520 value of a `display' property is a "replacing spec".
5521 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5522 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5523 the display property, but just return a value indicating whether
5524 the display property will replace the characters it covers.
5525 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5526 frame_window_p members of struct bidi_it.
d6d100dd
SM
5527 (compute_display_string_pos, compute_display_string_end):
5528 New functions.
fec2107c
EZ
5529 (push_it): Accept second argument POSITION, where pop_it should
5530 jump to continue iteration.
5531 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 5532
fec2107c
EZ
5533 * keyboard.c (adjust_point_for_property): Adjust the call to
5534 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
5535
5536 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
5537 (bidi_init_it): Update prototypes.
5538 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
5539 (compute_display_string_pos, compute_display_string_end):
5540 Declare prototypes.
fec2107c
EZ
5541 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5542 EMACS_INT.
fc6f18ce 5543
40087514 55442011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 5545
57f53182
PE
5546 Malloc failure behavior now depends on size of allocation.
5547 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5548 * lisp.h: Change signatures accordingly.
5549 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5550 All callers changed. (Bug#8762)
5551
5552 * gnutls.c: Use Emacs's memory allocators.
5553 Without this change, the gnutls library would invoke malloc etc.
5554 directly, which causes problems on non-SYNC_INPUT hosts, and which
5555 runs afoul of improving memory_full behavior. (Bug#8761)
5556 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5557 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5558 xfree instead of the default malloc, realloc, free.
5559 (Fgnutls_boot): No need to check for memory allocation failure,
5560 since xmalloc does that for us.
5561
ac32cd99 5562 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
5563 * category.c (hash_get_category_set):
5564 * ccl.c (ccl_driver):
5565 * charset.c (Fdefine_charset_internal):
5566 * charset.h (struct charset.hash_index):
5567 * composite.c (get_composition_id, gstring_lookup_cache)
5568 (composition_gstring_put_cache):
5569 * composite.h (struct composition.hash_index):
5570 * dispextern.h (struct image.hash):
5571 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5572 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5573 (hashfn_equal, hashfn_user_defined, make_hash_table)
5574 (maybe_resize_hash_table, hash_lookup, hash_put)
5575 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5576 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5577 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5578 * image.c (make_image, search_image_cache, lookup_image)
5579 (xpm_put_color_table_h):
5580 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 5581 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 5582 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 5583 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
5584 * alloc.c (allocate_vectorlike):
5585 Check for overflow in vector size calculations.
5586 * ccl.c (ccl_driver):
5587 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
5588 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5589 need to be updated by these changes.
40087514
PE
5590 * fns.c (make_hash_table, maybe_resize_hash_table):
5591 Check for integer overflow with large hash tables.
0de4bb68
PE
5592 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5593 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5594 (SXHASH_REDUCE): New macro.
5595 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5596 Use it instead of discarding useful hash info with large hash values.
5597 (sxhash_float): New function.
5598 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5599 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
5600 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5601 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
5602 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5603 Adjust signatures to match updated version of code.
5604 (consing_since_gc): Now EMACS_INT, since a single hash table can
5605 use more than INT_MAX bytes.
5606
698d32e2
DN
56072011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5608
5609 Make it possible to build with GCC-4.6+ -O2 -flto.
5610
5611 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5612
fd6fa53f
SM
56132011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5614
5615 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5616 Call minibuffer-inactive-mode.
5617
864db017
JB
56182011-05-31 Juanma Barranquero <lekktu@gmail.com>
5619
5620 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5621 Update dependencies.
5622
2ad0baf4
DN
56232011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5624
5625 * data.c (init_data): Remove code for UTS, this system is not
5626 supported anymore.
5627
4fcc2638
DN
56282011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5629
5630 Don't force ./temacs to start in terminal mode.
5631
5632 * frame.c (make_initial_frame): Initialize faces in all cases, not
5633 only when CANNOT_DUMP is defined.
5634 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5635
c56e0fd5
DN
56362011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5637
5638 * dispnew.c (add_window_display_history): Use const for the string
5639 pointer. Remove declaration, not needed.
5640
333d54da 56412011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 5642
55d4c1b2 5643 Use 'inline', not 'INLINE'.
333d54da 5644 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
5645 * alloc.c, fontset.c (INLINE): Remove.
5646 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5647 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5648 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5649 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5650 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5651
738db178
DN
56522011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5653
5654 Make it possible to run ./temacs.
5655
5656 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5657 syms_of_callproc does the same thing. Remove test for
5658 "initialized", do it in the caller.
5659 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5660
620c53a6
SM
56612011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5662
5663 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5664 (read_minibuf): Use get_minibuffer.
5665 (syms_of_minibuf): Use DEFSYM.
5666 (Qmetadata): New var.
5667 * data.c (Qbuffer): Don't make it static.
5668 (syms_of_data): Use DEFSYM.
5669
e003a292
PE
56702011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5671
5672 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5673 (CCL_CODE_MIN): New macro.
5674
ed008a6d
PE
56752011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5676
3687c2ef
PE
5677 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5678
ed008a6d
PE
5679 * eval.c (Qdebug): Now static.
5680 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5681 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5682 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5683
d66c4c7c
CY
56842011-05-29 Chong Yidong <cyd@stupidchicken.com>
5685
5686 * image.c: Various fixes to ImageMagick code comments.
5687 (Fimagemagick_types): Doc fix.
5688
5fbc2025
PE
56892011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5690
0196f88a
PE
5691 Minor fixes prompted by GCC 4.6.0 warnings.
5692
5693 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5694
5fbc2025
PE
5695 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5696 (x_clipboard_manager_save_all): Move extern decl to ...
5697 * xterm.h: ... here, so that it can be checked for consistency.
5698
1dd3c2d9
CY
56992011-05-29 Chong Yidong <cyd@stupidchicken.com>
5700
5701 * xselect.c (x_clipboard_manager_save_frame)
5702 (x_clipboard_manager_save_all): New functions.
5703 (Fx_clipboard_manager_save): Lisp function deleted.
5704
5705 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5706 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5707
5708 * xterm.h: Update prototype.
5709
5ba6571d
WX
57102011-05-28 William Xu <william.xwl@gmail.com>
5711
5712 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5713 exiting (Bug#8239).
5714
3eaff834
JM
57152011-05-28 Jim Meyering <meyering@redhat.com>
5716
e1900994 5717 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
5718 * fns.c (to_uchar): Define.
5719 (crypto_hash_function): Use it to convert some newly-signed
5720 variables to unsigned, to avoid sign-extension bugs. For example,
5721 without this change, (md5 "truc") would evaluate to
5722 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5723 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 5724 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 5725
0f6990a7
PE
57262011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5727
5728 Integer overflow fixes.
c8a9ca5a 5729
08686060
PE
5730 * dbusbind.c: Serial number integer overflow fixes.
5731 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
5732 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5733 to hold a serial number that is too large for a fixnum.
5734 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5735 Check for serial numbers out of range. Decode any serial number
59568bf0 5736 that was so large that it became a float. (Bug#8722)
08686060 5737
2d1fc3c7
PE
5738 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5739 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5740 Use XFASTINT rather than XUINT when numbers are nonnegative.
5741 (xd_append_arg, Fdbus_method_return_internal):
5742 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5743 arguments, check that Lisp number is nonnegative, rather than
59568bf0 5744 silently wrapping negative numbers around. (Bug#8722)
30217ff0 5745 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 5746 (Bug#8722)
2d1fc3c7 5747
c8a9ca5a
PE
5748 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5749
519e1d69
PE
5750 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5751
6df6ae42 5752 ccl: Add integer overflow checks.
30569699
PE
5753 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5754 (IN_INT_RANGE): New macros.
5755 (ccl_driver): Use them to check for integer overflow when
5756 decoding a CCL program. Many of the new checks are whether XINT (x)
5757 fits in int; it doesn't always, on 64-bit hosts. The new version
5758 doesn't catch all possible integer overflows, but it's an
847044ea 5759 improvement. (Bug#8719)
30569699 5760
c11285dc
PE
5761 * alloc.c (make_event_array): Use XINT, not XUINT.
5762 There's no need for unsigned here.
5763
fdccd48e
PE
5764 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5765 This follows up to the 2011-05-06 change that substituted uintptr_t
5766 for EMACS_INT. This case wasn't caught back then.
5767
37910ab2
PE
5768 Rework Fformat to avoid integer overflow issues.
5769 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5770 now (part of C89). Include <verify.h>.
5771 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5772 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5773 (Fformat): Avoid the prepass trying to compute sizes; it was only
5774 approximate and thus did not catch overflow reliably. Instead, walk
5775 through the format just once, formatting and computing sizes as we go,
5776 checking for integer overflow at every step, and allocating a larger
5777 buffer as needed. Keep track separately whether the format is
5778 multibyte. Keep only the most-recently calculated precision, rather
5779 than them all. Record whether each argument has been converted to
5780 string. Use EMACS_INT, not int, for byte and char and arg counts.
5781 Support field widths and precisions larger than INT_MAX. Avoid
5782 sprintf's undefined behavior with conversion specifications such as %#d
5783 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5784 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5785 formatting out-of-range floating point numbers with int
9173deec 5786 formats. (Bug#8668)
37910ab2 5787
2e6578fb
PE
5788 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5789
0ae6bdee
PE
5790 * data.c: Avoid integer truncation in expressions involving floats.
5791 * data.c: Include <intprops.h>.
5792 (arith_driver): When there's an integer overflow in an expression
5793 involving floating point, convert the integers to floating point
5794 so that the resulting value does not suffer from catastrophic
5795 integer truncation. For example, on a 64-bit host (* 4
5796 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5797 Do not rely on undefined behavior after integer overflow.
5798
de883a70
PE
5799 merge count_size_as_multibyte, parse_str_to_multibyte
5800 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 5801 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
5802 Check for integer overflow.
5803 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5804 since it's now a duplicate of the other. This is more of
5805 a character than a buffer op, so better that it's in character.c.
5806 * fns.c, print.c: Adjust to above changes.
5807
2ff916cb
PE
58082011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5809
5810 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5811
f1b54466
PE
58122011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5813
fb1ac845
PE
5814 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5815 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5816 (x_clipboard_manager_save): Now static.
5817 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5818
f1b54466
PE
5819 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5820 (crypto_hash_function): Now static.
5821 Fix pointer signedness problems. Avoid unnecessary initializations.
5822
a9f737ee
CY
58232011-05-27 Chong Yidong <cyd@stupidchicken.com>
5824
5825 * termhooks.h (Vselection_alist): Make it terminal-local.
5826
5827 * terminal.c (create_terminal): Initialize it.
5828
5829 * xselect.c: Support for clipboard managers.
5830 (Vselection_alist): Move to termhooks.h as terminal-local var.
5831 (LOCAL_SELECTION): New macro.
5832 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5833 (symbol_to_x_atom): Remove gratuitous arg.
5834 (x_handle_selection_request, lisp_data_to_selection_data)
5835 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
5836 (x_own_selection, x_get_local_selection, x_convert_selection):
5837 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
5838 (some_frame_on_display): Delete unused function.
5839 (Fx_own_selection_internal, Fx_get_selection_internal)
5840 (Fx_disown_selection_internal, Fx_selection_owner_p)
5841 (Fx_selection_exists_p): New optional frame arg.
5842 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5843 (x_handle_selection_clear): Don't treat other terminals with the
5844 same keyboard specially. Use the terminal-local Vselection_alist.
5845 (x_clear_frame_selections): Use Frun_hook_with_args.
5846
5847 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5848
5849 * xterm.h: Add support for those atoms.
5850
e067f0c1
CY
58512011-05-26 Chong Yidong <cyd@stupidchicken.com>
5852
5853 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5854 (converted_selections, conversion_fail_tag): New global variables.
5855 (x_selection_request_lisp_error): Free the above.
5856 (x_get_local_selection): Remove unnecessary code.
5857 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
5858 of converted selections stored in converted_selections.
5859 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
5860 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5861 (x_convert_selection): New function.
5862 (x_handle_selection_event): Simplify.
5863 (x_get_foreign_selection): Don't ignore incoming requests while
5864 waiting for an answer; this will fail when we implement
5865 SAVE_TARGETS, and seems unnecessary anyway.
5866 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5867 (Vx_sent_selection_functions): Doc fix.
5868
0f4aebc0
LL
58692011-05-26 Leo Liu <sdl.web@gmail.com>
5870
5871 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5872
e61124cd
YM
58732011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5874
5875 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5876
5877 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5878 for fringe update if it has periodic bitmap.
ac389d0c 5879 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
5880 and fringe_bitmap_periodic_p.
5881
5882 * fringe.c (get_fringe_bitmap_data): New function.
5883 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5884 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5885 row. Mark glyph row for fringe update if periodicity changed.
5886
5887 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5888 for fringe update unless it has periodic bitmap.
5889
f16d9837
KH
58902011-05-25 Kenichi Handa <handa@m17n.org>
5891
5892 * xdisp.c (get_next_display_element): Set correct it->face_id for
5893 a static composition.
5894
e1b90ef6
LL
58952011-05-24 Leo Liu <sdl.web@gmail.com>
5896
5897 * deps.mk (fns.o):
5898 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5899
5900 * fns.c (crypto_hash_function, Fsha1): New function.
5901 (Fmd5): Use crypto_hash_function.
5902 (syms_of_fns): Add Ssha1.
5903
7400048f
PE
59042011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5905
5906 * gnutls.c: Remove unused macros.
5907 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5908 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5909 Remove macros that are defined and never used.
5910 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5911
abb71cf4
CY
59122011-05-22 Chong Yidong <cyd@stupidchicken.com>
5913
5914 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5915 (Fx_get_selection_internal): Minor cleanup.
5916 (Fx_own_selection_internal): Rename arguments for consistency with
5917 select.el.
5918
6307db39
PE
59192011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5920
5921 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5922
f3d4e0a4
CY
59232011-05-22 Chong Yidong <cyd@stupidchicken.com>
5924
5925 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5926
4d8ade89
YM
59272011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5928
5929 * dispnew.c (scrolling_window): Don't exclude the case that the
5930 last enabled row in the desired matrix touches the bottom boundary.
5931
32078c8d
GM
59322011-05-21 Glenn Morris <rgm@gnu.org>
5933
5934 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
5935 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5936 and add some more files.
32078c8d 5937
7285dc67
EZ
59382011-05-20 Eli Zaretskii <eliz@gnu.org>
5939
5940 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5941 report_file_error introduced by the change from 2011-05-07.
5942
89d1bd22
PE
59432011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5944
5945 * systime.h (Time): Define only if emacs is defined.
5946 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5947 where the include path doesn't have X11/X.h by default. See
5948 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5949
cd394be1 59502011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
5951
5952 * composite.c (find_automatic_composition): Fix previous change.
5953
b9704ad9
GM
59542011-05-20 Glenn Morris <rgm@gnu.org>
5955
5956 * lisp.mk: New file, split from Makefile.in.
5957 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5958 (shortlisp): Remove.
5959 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5960
4a720484
GM
59612011-05-19 Glenn Morris <rgm@gnu.org>
5962
5963 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5964 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5965 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5966 (lisp): Set the order to that of loadup.el.
5967 (shortlisp): Make it a copy of $lisp.
5968 (SOME_MACHINE_LISP): Remove.
5969 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5970 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5971
a28d4396
KH
59722011-05-18 Kenichi Handa <handa@m17n.org>
5973
5974 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5975 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5976 (find_automatic_composition): Mostly rewrite for efficiency.
5977
a2b1fa8e
JB
59782011-05-18 Juanma Barranquero <lekktu@gmail.com>
5979
5980 * makefile.w32-in: Update dependencies.
5981
8e1f5610
CS
59822011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5983
5984 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 5985 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 5986
7025ee00 59872011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 5988
cdfa6eab
PE
5989 Fix some integer overflow issues, such as string length overflow.
5990
06d6db33
PE
5991 * insdel.c (count_size_as_multibyte): Check for string overflow.
5992
2b4560a8
PE
5993 * character.c (lisp_string_width): Check for string overflow.
5994 Use EMACS_INT, not int, for string indexes and lengths; in
5995 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5996 the resulting string length overflows an EMACS_INT; instead,
5997 report a string overflow if no precision given. When checking for
5998 precision exhaustion, use a check that cannot possibly have
5999 integer overflow. (Bug#8675)
6000 * character.h (lisp_string_width): Adjust to new signature.
6001
cb93f9be
PE
6002 * alloc.c (string_overflow): New function.
6003 (Fmake_string): Use it. This doesn't change behavior, but saves
6004 a few bytes and will simplify future changes.
6005 * character.c (string_escape_byte8): Likewise.
6006 * lisp.h (string_overflow): New decl.
6007
1a1f3366
PE
6008 Fixups, following up to the user-interface timestamp change.
6009 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6010 for UI timestamps, instead of unsigned long.
9fbd6841
PE
6011 * msdos.c (mouse_get_pos): Likewise.
6012 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
6013 * w32gui.h (Time): Define by including "systime.h" rather than by
6014 declaring it ourselves. (Bug#8664)
6015
d4e3e4d3
PE
6016 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6017 * image.c (clear_image_cache): Likewise.
6018
f6a24d19
PE
6019 * term.c (term_mouse_position): Don't assume time_t wraparound.
6020
08dc5ae6
PE
6021 Be more systematic about user-interface timestamps.
6022 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
6023 and sometimes 'EMACS_UINT', to represent these timestamps.
6024 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
6025 This makes the code easier to follow, and makes it easier to catch
6026 integer overflow bugs such as Bug#8664.
6027 * frame.c (Fmouse_position, Fmouse_pixel_position):
6028 Use Time, not unsigned long, for user-interface timestamps.
6029 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6030 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6031 * keyboard.h (last_event_timestamp): Likewise.
6032 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6033 * menu.h (xmenu_show): Likewise.
6034 * term.c (term_mouse_position): Likewise.
6035 * termhooks.h (struct input_event.timestamp): Likewise.
6036 (struct terminal.mouse_position_hook): Likewise.
6037 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6038 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6039 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6040 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6041 what it was before.
6042 * menu.h, termhooks.h: Include "systime.h", for Time.
6043
8e55734a
PE
6044 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6045 Don't assume that the difference between two unsigned long values
6046 can fit into an integer. At this point, we know button_down_time
6047 <= event->timestamp, so the difference must be nonnegative, so
6048 there's no need to cast the result if double-click-time is
6049 nonnegative, as it should be; check that it's nonnegative, just in
6050 case. This bug is triggered when events are more than 2**31 ms
86db42d2 6051 apart (about 25 days). (Bug#8664)
8e55734a 6052
841f1b75 6053 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 6054 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 6055
3e26f69c
PE
6056 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6057 that always fit in int. Use a sentinel instead of a counter, to
6058 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
6059 * frame.h (struct frame): Use int for menu_bar_items_used
6060 instead of EMACS_INT, since it always fits in int.
3e26f69c 6061
5cc152c0
PE
6062 * menu.c (grow_menu_items): Check for int overflow.
6063
d89eb65e
PE
6064 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6065
5235bd3e
PE
6066 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6067 Before, the code was not consistent. These values cannot exceed
6068 2**31 - 1 so there's no need to make them unsigned.
6069 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6070 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6071 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6072 as modifiers.
6073 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6074
bc827e23
PE
6075 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6076 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6077 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6078 presumably because the widths might not match.
6079
78eb494e
PE
6080 * window.c (size_window): Avoid needless test at loop start.
6081
04f2d78b
CB
60822011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6083
6084 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6085
d2fc7e3d 60862011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
6087
6088 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6089
d2fc7e3d 60902011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
6091
6092 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6093 `width' to `bar_area_x' and `bar_area_width', respectively.
6094 (x_scroll_run): Take account of fringe background extension.
6095
04f2d78b
CB
6096 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6097 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
6098 `bar_area_width', respectively.
6099 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6100 background extension.
6101
79b70037
GM
61022011-05-10 Jim Meyering <meyering@redhat.com>
6103
6104 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6105
2f142cc5
JB
61062011-05-10 Juanma Barranquero <lekktu@gmail.com>
6107
6108 * image.c (Finit_image_library): Return t for built-in image types,
6109 like pbm and xbm. (Bug#8640)
6110
57679c86
AS
61112011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6112
6113 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6114
888c9e86
EZ
61152011-05-07 Eli Zaretskii <eliz@gnu.org>
6116
b0512a1d
EZ
6117 * w32console.c (Fset_screen_color): Doc fix.
6118 (Fget_screen_color): New function.
6119 (syms_of_ntterm): Defsubr it.
6120
7285dc67
EZ
6121 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6122 unlink the temporary file if Fcall_process didn't create it in the
6123 first place.
6124 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6125 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
6126 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6127 cue to call_process_cleanup not to close that handle.
6128
4d3fcc8e
BK
61292011-05-07 Ben Key <bkey76@gmail.com>
6130
6131 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6132 one of two shell specific rules, either bootstrap-temacs-CMD or
6133 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6134 to the previous implementation of the bootstrap-temacs rule.
6135 The bootstrap-temacs-CMD rule is similar to the previous
6136 implementation of the bootstrap-temacs rule except that it
6137 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6138 variable.
6139
6140 These changes, along with some changes to nt/configure.bat,
6141 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6142 earlier fix to add support for --cflags and --ldflags options
6143 that include quotes so that it works whether make uses cmd or
6144 sh as the shell.
6145
b4289b64
MA
61462011-05-06 Michael Albinus <michael.albinus@gmx.de>
6147
6148 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6149 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6150 is a constant.
6151 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6152 a string. Handle both cases.
6153 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6154 (Fdbus_register_method): Use Qinvalid_function.
6155
af4c0e28
JB
61562011-05-06 Juanma Barranquero <lekktu@gmail.com>
6157
6158 * makefile.w32-in: Update dependencies.
6159 (LISP_H): Add inttypes.h and stdin.h.
6160 (PROCESS_H): Add unistd.h.
6161
c51453d9
EZ
61622011-05-06 Eli Zaretskii <eliz@gnu.org>
6163
6164 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6165 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6166
8ff0ac3c 61672011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 6168
4c4b566b
PE
6169 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6170
aab2b9b5
PE
6171 * term.c (vfatal): Remove stray call to va_end.
6172 It's not needed and the C Standard doesn't allow it here anyway.
6173
c378da0b
PE
6174 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6175 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6176
288b08c7
PE
6177 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6178 bytes.
6179
e3601888
PE
6180 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6181
db6c0e74
PE
6182 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6183
dd5963ea
PE
6184 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6185
88c9450f
PE
6186 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6187
2f9442b8
PE
6188 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6189
c032b5f8
PE
6190 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6191 * charset.c (Fdefine_charset_internal): Don't initialize
6192 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 6193 32-bit int (Bug#8600).
a108c10b
PE
6194
6195 * lread.c (read_integer): Be more consistent with string-to-number.
6196 Use string_to_number to do the actual conversion; this avoids
6197 rounding errors and fixes some other screwups. Without this fix,
6198 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6199 (digit_to_number): Move earlier, for benefit of read_integer.
6200 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 6201 not a digit in any supported base. (Bug#8602)
a108c10b 6202
ad5f9eea
PE
6203 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6204
aec1708a
PE
6205 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6206 to match comment at start of function. This also removes a
6207 GCC warning about overflow in a 32+64-bit port.
6208
47be4ab5
PE
6209 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6210
371cac43
PE
6211 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6212 Reported by Stefan Monnier in
6213 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
6214 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6215 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 6216
d01a7826
PE
6217 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6218 (EMACS_UINTPTR): Likewise, with uintptr_t.
6219
7fd47d5c
PE
6220 * lisp.h: Prefer 64-bit EMACS_INT if available.
6221 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6222 on 32-bit hosts that have 64-bit int, so that they can access
6223 large files.
122b0c86
PE
6224 However, temporarily disable this change unless the temporary
6225 symbol WIDE_EMACS_INT is defined.
7fd47d5c 6226
8727937b
PE
6227 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6228
8ac068ac
PE
6229 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6230 This removes an assumption that EMACS_INT and long are the same
6231 width as pointers. The assumption is true for Emacs porting targets
6232 now, but we want to make other targets possible.
6233 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6234 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6235 In the rest of the code, change types of integers that hold casted
6236 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6237 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6238 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6239 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6240 No need to cast type when ORing.
6241 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6242 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6243 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6244 assume EMACS_INT is the same width as char *.
6245 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6246 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6247 Remove no-longer-needed casts.
6248 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6249 (xg_tool_bar_help_callback, xg_make_tool_item):
6250 Use EMACS_INTPTR to hold an integer
6251 that will be cast to void *; this can avoid a GCC warning
6252 if EMACS_INT is not the same width as void *.
6253 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6254 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6255 (current_message_1, set_message_1):
6256 Use a local to convert to proper width without a cast.
6257 * xmenu.c (dialog_selection_callback): Likewise.
6258
ede49d71
PE
6259 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6260 Also, don't assume VALBITS / RAND_BITS is less than 5,
6261 and don't rely on undefined behavior when shifting a 1 left into
6262 the sign bit.
6263 * lisp.h (get_random): Change signature to match.
6264
2f30ecd0
PE
6265 * lread.c (hash_string): Use size_t, not int, for hash computation.
6266 Normally we prefer signed values; but hashing is special, because
6267 it's better to use unsigned division on hash table sizes so that
6268 the remainder is nonnegative. Also, size_t is the natural width
6269 for hashing into memory. The previous code used 'int', which doesn't
6270 retain enough info to hash well into very large tables.
6271 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6272
2a866e7b
PE
6273 * dbusbind.c: Don't possibly lose pointer info when converting.
6274 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6275 Use XPNTR rather than XHASH, so that the high-order bits of
6276 the pointer aren't lost when converting through void *.
6277
51639eac
PE
6278 * eval.c (Fautoload): Don't double-shift a pointer.
6279
92394119
PE
6280 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6281
dbdb9a7c
JB
62822011-05-06 Juanma Barranquero <lekktu@gmail.com>
6283
6284 * gnutls.c (DEF_GNUTLS_FN):
6285 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6286
db7a0b4f
AS
62872011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6288
6289 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6290 marker. (Bug#8610)
6291
cd394be1 62922011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
6293
6294 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6295 New version that can reserve upto 2GB of heap space.
6296
f7ff1b0f 62972011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
6298
6299 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6300
639c109b
TZ
63012011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6302
6303 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6304 `gnutls_certificate_set_x509_key_file'.
6305
d2127135
JB
63062011-05-05 Juanma Barranquero <lekktu@gmail.com>
6307
6308 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6309 Update dependencies.
6310
e968f4f3
JB
63112011-05-04 Juanma Barranquero <lekktu@gmail.com>
6312
6313 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6314 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6315 Remove unused parameter `fildes'.
6316 * process.c (read_process_output, send_process): Don't pass it.
6317
84d358f0
JB
63182011-05-04 Juanma Barranquero <lekktu@gmail.com>
6319
6320 Fix previous change: the library cache is defined in w32.c.
6321 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6322 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6323
0898ca10
JB
63242011-05-04 Juanma Barranquero <lekktu@gmail.com>
6325
6326 Implement dynamic loading of GnuTLS on Windows.
6327
6328 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6329 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6330 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6331 Declare.
6332
6333 * gnutls.c (Qgnutls_dll): Define.
6334 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6335 (gnutls_*): Declare function pointers.
6336 (init_gnutls_functions): New function to initialize function pointers.
6337 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6338 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6339 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6340 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6341 (emacs_gnutls_write, emacs_gnutls_read)
6342 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6343 (Fgnutls_available_p): New function.
6344 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6345 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6346 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6347
6348 * image.c: Include w32.h.
6349 (Vimage_type_cache): Delete.
6350 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6351 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6352 (w32_delayed_load): Move to w32.c.
6353
6354 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6355
6356 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6357 (w32_delayed_load): Move from image.c. When loading a library, record
6358 its filename in the :loaded-from property of the library id.
6359 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6360 Initialize and staticpro them.
6361 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6362
6363 * process.c: Include lisp.h before w32.h, not after.
6364 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6365 instead of gnutls_record_check_pending.
6366
6367 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6368
ff4de4aa
TZ
63692011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6370
6371 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6372 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6373 as passed in.
6374
abe95abb
JD
63752011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6376
6377 * xterm.c (x_set_frame_alpha): Do not set property on anything
6378 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6379
e16e55d4
JB
63802011-05-02 Juanma Barranquero <lekktu@gmail.com>
6381
6382 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6383
bafcf6a5
JB
63842011-05-02 Juanma Barranquero <lekktu@gmail.com>
6385
6386 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6387 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6388 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6389 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6390 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6391 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6392 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6393 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6394 (Qgnutls_bootprop_callbacks_verify): Make static.
6395
e7a6747f
AS
63962011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6397
19ed11ba
AS
6398 * callproc.c: Indentation fixup.
6399
e7a6747f 6400 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
6401 (wait_for_termination, interruptible_wait_for_termination):
6402 Move after wait_for_termination_1.
e7a6747f 6403
1ef14cb4
LMI
64042011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6405
6406 * sysdep.c (interruptible_wait_for_termination): New function
6407 which is like wait_for_termination, but allows keyboard
6408 interruptions.
6409
6410 * callproc.c (Fcall_process): Add (:file "file") as an option for
6411 the STDOUT buffer.
6412 (Fcall_process_region): Ditto.
6413
330d880c
EZ
64142011-04-30 Eli Zaretskii <eliz@gnu.org>
6415
8db90b73
EZ
6416 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6417 rather than `XVECTOR (FOO)->size'.
6418
330d880c
EZ
6419 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6420 inttypes.h, as a gnulib replacement is used if it not available in
6421 system headers.
6422
15cbd324
EZ
64232011-04-21 Eli Zaretskii <eliz@gnu.org>
6424
6425 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6426 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6427 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6428
6429 * coding.c (coding_alloc_by_realloc): Error out if destination
6430 will grow beyond MOST_POSITIVE_FIXNUM.
6431 (decode_coding_emacs_mule): Abort if there isn't enough place in
6432 charbuf for the composition carryover bytes. Reserve an extra
6433 space for up to 2 characters produced in a loop.
6434 (decode_coding_iso_2022): Abort if there isn't enough place in
6435 charbuf for the composition carryover bytes.
6436
64372011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 6438
ae940cca
EZ
6439 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6440 aborting when %lld or %lll format is passed.
6441 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6442 %llo or %llx format is passed. (Bug#8545)
6443
03ab8921
EZ
6444 * window.c (window_scroll_line_based): Use a marker instead of
6445 simple variables to record original value of point. (Bug#7952)
6446
afda1437
EZ
6447 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6448 produced by %s or %c overflows available buffer space. (Bug#8545)
6449
f76dee0c
PE
64502011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6451
6452 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 6453 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 6454
fdc5744d
JB
64552011-04-28 Juanma Barranquero <lekktu@gmail.com>
6456
6457 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6458
638f053a
JB
64592011-04-28 Juanma Barranquero <lekktu@gmail.com>
6460
6461 * keyboard.c (Qdelayed_warnings_hook): Define.
6462 (command_loop_1): Run `delayed-warnings-hook'
6463 if Vdelayed_warnings_list is non-nil.
6464 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6465 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6466
d178f871
EZ
64672011-04-28 Eli Zaretskii <eliz@gnu.org>
6468
6469 * doprnt.c (doprnt): Don't return value smaller than the buffer
6470 size if the message was truncated. (Bug#8545).
6471
b124fd93
JB
64722011-04-28 Juanma Barranquero <lekktu@gmail.com>
6473
6474 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6475 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6476
e810457d
PE
64772011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6478
6479 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6480
ea51cceb
JB
64812011-04-27 Juanma Barranquero <lekktu@gmail.com>
6482
6483 * makefile.w32-in: Update dependencies.
6484
94dcfacf
EZ
64852011-04-27 Eli Zaretskii <eliz@gnu.org>
6486
6487 Improve `doprnt' and its usage. (Bug#8545)
6488 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6489 `format_end'. Remove support for %l as a conversion specifier.
6490 Don't use xrealloc. Improve diagnostics when the %l size modifier
6491 is used. Update the commentary.
6492
6493 * eval.c (verror): Simplify calculation of size_t.
6494
6495 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6496 messages.
6497
f61f41d7
PE
64982011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6499
6500 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6501 change.
6502
96fb4434
PE
65032011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6504
6505 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6506 This makes this file independent of the recent pseudovector change.
6507
671875da 65082011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 6509
69e9b5a3
PE
6510 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6511
b5f869a7 6512 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 6513 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 6514 Remove unused local.
c8926152 6515 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 6516
841a1577 6517 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
6518 GCC 4.6.0 optimizes based on type-based alias analysis.
6519 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
6520 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6521 != &v->size, and therefore "v->size = 1; b->size = 2; return
6522 v->size;" must therefore return 1. This assumption is incorrect
6523 for Emacs, since it type-puns struct Lisp_Vector * with many other
6524 types. To fix this problem, this patch adds a new type struct
f904488f 6525 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
6526 and pseudovectors, and helps optimizing compilers not get fooled
6527 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6528 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
6529 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6530 the size member.
eab3844f
PE
6531 (XSETPVECTYPE): Rewrite in terms of new macro.
6532 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6533 This is a bit clearer, and further avoids the possibility of
6534 undesirable aliasing.
6535 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 6536 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
6537 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6538 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
6539 (ASIZE): Now uses header.size rather than size.
6540 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
6541 to avoid the hassle of writing XVECTOR (foo)->header.size.
6542 (struct vectorlike_header): New type.
eab3844f
PE
6543 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6544 object, to help avoid aliasing.
6545 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6546 (SUBRP): Likewise, since Lisp_Subr is a special case.
6547 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6548 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6549 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 6550 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
6551 changed to be "header.size" and "header.next".
6552 * buffer.h (struct buffer): Likewise.
6553 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6554 * frame.h (struct frame): Likewise.
6555 * process.h (struct Lisp_Process): Likewise.
6556 * termhooks.h (struct terminal): Likewise.
6557 * window.c (struct save_window_data, struct saved_window): Likewise.
6558 * window.h (struct window): Likewise.
6559 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6560 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6561 * buffer.c (init_buffer_once): Likewise.
6562 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6563 special case.
6564 * process.c (Fformat_network_address): Use local var for size,
6565 for brevity.
6566
0df1eac5
PE
6567 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6568
847ab9d1 6569 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
6570 * data.c (atof): Remove decl; no longer used or needed.
6571 (digit_to_number): Move to lread.c.
6572 (Fstring_to_number): Use new string_to_number function, to be
6573 consistent with how the Lisp reader treats infinities and NaNs.
6574 Do not assume that floating-point numbers represent EMACS_INT
6575 without losing information; this is not true on most 64-bit hosts.
6576 Avoid double-rounding errors, by insisting on integers when
6577 parsing non-base-10 numbers, as the documentation specifies.
6578 * lisp.h (string_to_number): New decl, replacing ...
6579 (isfloat_string): Remove.
bc0a5c13 6580 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 6581 (read1): Do not accept +. and -. as integers; this
452f4150
PE
6582 appears to have been a coding error. Similarly, do not accept
6583 strings like +-1e0 as floating point numbers. Do not report
6584 overflow for integer overflows unless the base is not 10 which
6585 means we have no simple and reliable way to continue.
6586 Break out the floating-point parsing into a new
6587 function string_to_number, so that Fstring_to_number parses
6588 floating point numbers consistently with the Lisp reader.
04f2d78b 6589 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
6590 (E_CHAR, EXP_INT): Remove, replacing with ...
6591 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6592 (string_to_number): New function, replacing isfloat_string.
6593 This function checks for valid syntax and produces the resulting
6594 Lisp float number too. Rework it so that string-to-number
bc0a5c13 6595 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
6596 so that overflow for non-base-10 numbers is reported only when
6597 there's no portable and simple way to convert to floating point.
452f4150 6598
67769ffc
PE
6599 * textprop.c (set_text_properties_1): Rewrite for clarity,
6600 and to avoid GCC warning about integer overflow.
6601
c20db43f
PE
6602 * intervals.h (struct interval): Use EMACS_INT for members
6603 where EMACS_UINT might cause problems. See
6604 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6605 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6606 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6607 All uses changed.
37aa2f85
PE
6608 (offset_intervals): Tell GCC not to worry about length overflow
6609 when negating a negative length.
c20db43f 6610
2538aa2f
PE
6611 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6612 (overrun_check_free): Likewise.
6613
f2d3008d
PE
6614 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6615 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6616 word size.
6617
ec8df744
PE
6618 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6619 (gnutls_make_error): Rename local to avoid shadowing.
6620 (gnutls_emacs_global_deinit): ifdef out; not used.
6621 (Fgnutls_boot): Use const for pointer to readonly storage.
6622 Comment out unused local. Fix pointer signedness problems.
6623
640ee02d
PE
6624 * lread.c (openp): Don't stuff size_t into an 'int'.
6625 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6626 about possible signed overflow.
6627
6048fb2a
PE
6628 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6629 (GDK_KEY_g): Don't define if already defined.
6630 (xg_prepare_tooltip): Avoid pointer signedness problem.
6631 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6632
fa3c87e1
PE
6633 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6634 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6635
2172544b
PE
6636 * xfns.c (Fx_window_property): Simplify a bit,
6637 to make a bit faster and to avoid GCC 4.6.0 warning.
6638 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6639
9b821a21
PE
6640 * fns.c (internal_equal): Don't assume size_t fits in int.
6641
3c616cfa
PE
6642 * alloc.c (compact_small_strings): Tighten assertion a little.
6643
c2982e87
PE
6644 Replace pEd with more-general pI, and fix some printf arg casts.
6645 * lisp.h (pI): New macro, generalizing old pEd macro to other
6646 conversion specifiers. For example, use "...%"pI"d..." rather
6647 than "...%"pEd"...".
6648 (pEd): Remove. All uses replaced with similar uses of pI.
6649 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6650 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6651 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6652 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6653 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6654 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6655 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6656 64-bit hosts.
6657 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6658 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6659 * print.c (safe_debug_print, print_object): Likewise.
6660 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6661 to int.
6f04d126
PE
6662 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6663 avoiding the 0 flag, which is not portable.
c2982e87
PE
6664 * process.c (Fmake_network_process): Use pI to avoid cast.
6665 * region-cache.c (pp_cache): Likewise.
6666 * xdisp.c (decode_mode_spec): Likewise.
6667 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6668 behavior on 64-bit hosts with printf arg.
6f04d126 6669 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
6670 (x_stop_queuing_selection_requests): Likewise.
6671 (x_get_window_property): Don't truncate byte count to an 'int'
6672 when tracing.
0b432f21 6673
5e073ec7
PE
6674 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6675 here, since it parses constructs like leading '-' and spaces,
6676 which are not wanted; and it overflows with large numbers.
6677 Instead, simply match F[0-9]+, which is what is wanted anyway.
6678
36372bf9
PE
6679 * alloc.c: Remove unportable assumptions about struct layout.
6680 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6681 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6682 (allocate_vectorlike, make_pure_vector): Use the new macros,
6683 plus offsetof, to remove unportable assumptions about struct layout.
6684 These assumptions hold on all porting targets that I know of, but
6685 they are not guaranteed, they're easy to remove, and removing them
6686 makes further changes easier.
6687
0b432f21
PE
6688 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6689 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
6690 (string_overrun_cookie): Now const. Use initializers that
6691 don't formally overflow signed char, to avoid warnings.
000098c1
PE
6692 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6693 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
6694 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6695 multiple of sizeof (EMACS_INT); it need not be, if
6696 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 6697 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 6698
895009e1
JB
66992011-04-26 Juanma Barranquero <lekktu@gmail.com>
6700
6701 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6702
6a7a1b0b
TZ
67032011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6704
6705 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 6706 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
6707 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6708
841a1577 67092011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
6710
6711 * lisp.h (Qdebug): List symbol.
895009e1 6712 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
6713 * keyboard.c (debug-on-event): New variable.
6714 (handle_user_signal): Break into debugger when debug-on-event
6715 matches the current signal symbol.
6716
f2d3ba6f
DN
67172011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6718
6719 * alloc.c (check_sblock, check_string_bytes)
6720 (check_string_free_list): Convert to standard C.
6721
42ce4c63
TZ
67222011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6723
6724 * w32.c (emacs_gnutls_push): Fix typo.
6725
825cd63c
EZ
67262011-04-25 Eli Zaretskii <eliz@gnu.org>
6727
fb11d64d
EZ
6728 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6729 "cast to pointer from integer of different size".
6730
825cd63c
EZ
6731 Improve doprnt and its use in verror. (Bug#8545)
6732 * doprnt.c (doprnt): Document the set of format control sequences
6733 supported by the function. Use SAFE_ALLOCA instead of always
6734 using `alloca'.
6735
6736 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6737 is one byte too soon. Don't use xrealloc; instead xfree and
6738 xmalloc anew.
6739
e061a11b
TZ
67402011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6741
6742 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6743 callbacks stage.
6744
6745 * gnutls.c: Renamed global_initialized to
6746 gnutls_global_initialized. Added internals for the
6747 :verify-hostname-error, :verify-error, and :verify-flags
6748 parameters of `gnutls-boot' and documented those parameters in the
6749 docstring. Start callback support.
9173deec
JB
6750 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6751 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6752 on error. Return error code.
e061a11b
TZ
6753 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6754 (emacs_gnutls_read): Likewise.
6755 (Fgnutls_boot): Return handshake error code.
6756 (emacs_gnutls_handle_error): New function.
6757 (wsaerror_to_errno): Likewise.
6758
6759 * w32.h (emacs_gnutls_pull): Add prototype.
6760 (emacs_gnutls_push): Likewise.
6761
6762 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6763 (emacs_gnutls_push): Likewise.
6764
67652011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6766
6767 * process.c (wait_reading_process_output): Check if GnuTLS
6768 buffered some data internally if no FDs are set for TLS
6769 connections.
6770
6771 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6772 (LIBS): Link to USER_LIBS.
6773 ($(BLD)/gnutls.$(0)): New target.
6774
fa6996bc
EZ
67752011-04-24 Eli Zaretskii <eliz@gnu.org>
6776
eb35682e
EZ
6777 * xdisp.c (handle_single_display_spec): Rename the
6778 display_replaced_before_p argument into display_replaced_p, to
6779 make it consistent with the commentary. Fix typos in the
6780 commentary.
6781
e2ad650c
EZ
6782 * textprop.c (syms_of_textprop): Remove dead code.
6783 (copy_text_properties): Delete obsolete commentary about an
6784 interface that was deleted long ago. Fix typos in the description
6785 of arguments.
6786
1b2de274
EZ
6787 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6788 to changes in oldXMenu/XMenu.h from 2011-04-16.
6789 <menu_help_message, prev_menu_help_message>: Constify.
6790 (IT_menu_make_room): menu->help_text is now `const char **';
6791 adjust.
6792
6793 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6794 to changes in oldXMenu/XMenu.h from 2011-04-16.
6795 (struct XMenu): Declare `help_text' `const char **'.
6796
6797 * xfaces.c <Qunspecified>: Make extern again.
6798
6799 * syntax.c: Include sys/types.h before including regex.h, as
6800 required by Posix.
6801
762b15be
EZ
6802 * doc.c (get_doc_string): Improve the format passed to `error'.
6803
6804 * doprnt.c (doprnt): Improve commentary.
6805
6806 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6807
6808 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6809 them with etags.
6810
f1052e5d
EZ
6811 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6812 changes in globals.h immediately force recompilation.
762b15be
EZ
6813 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6814 $(CURDIR)/s/ms-w32.h.
6815 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 6816
fa6996bc
EZ
6817 * character.c (Fchar_direction): Function deleted.
6818 (syms_of_character): Don't defsubr it.
6819 <char-direction-table>: Deleted.
6820
e6c3da20
EZ
68212011-04-23 Eli Zaretskii <eliz@gnu.org>
6822
6823 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6824 * doprnt.c: Include limits.h.
6825 (SIZE_MAX): New macro.
04f2d78b
CB
6826 (doprnt): Return a size_t value. 2nd arg is now size_t.
6827 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
6828 Improve overflow protection. Support `l' modifier for integer
6829 conversions. Support %l conversion. Don't assume an EMACS_INT
6830 argument for integer conversions and for %c.
6831
6832 * lisp.h (doprnt): Restore prototype.
6833
6834 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6835 $(SRC)/character.h.
6836
6837 * Makefile.in (base_obj): Add back doprnt.o.
6838
6839 * deps.mk (doprnt.o): Add back prerequisites.
6840 (callint.o): Depend on character.h.
6841
6842 * eval.c (internal_lisp_condition_case): Include the handler
6843 representation in the error message.
6844 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6845 when breaking from the loop.
6846
6847 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6848
6849 * callint.c (Fcall_interactively): When displaying error message
6850 about invalid control letter, pass the character's codepoint, not
6851 a pointer to its multibyte form. Improve display of the character
6852 in octal and display also its hex code.
6853
6854 * character.c (char_string): Use %x to display the (unsigned)
6855 codepoint of an invalid character, to avoid displaying a bogus
6856 negative value.
6857
6858 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6859 `error', not SYMBOL_NAME itself.
6860
6861 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6862 character arguments to `error'.
6863
6864 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6865 to `error' in error message about FINAL_CHAR argument. Make sure
6866 FINAL_CHAR is a character, and use %c when it is passed as
6867 argument to `error'.
6868
4ffd0d6b 68692011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
6870
6871 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6872
6873 * w32.c: Include <time.h>.
6874 (sys_localtime): New function.
6875
4ffd0d6b 68762011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
6877
6878 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6879
4ffd0d6b 6880 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 6881
4ffd0d6b 68822011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 6883
4ffd0d6b
GM
6884 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6885 zombies (Bug#8467).
aac0c6e3 6886
04c56954
EZ
68872011-04-19 Eli Zaretskii <eliz@gnu.org>
6888
6889 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6890 gl_state.e_property when gl_state.object is Qt.
6891
6892 * insdel.c (make_gap_larger): Remove limitation of buffer size
6893 to <= INT_MAX.
6894
16a43933
CY
68952011-04-18 Chong Yidong <cyd@stupidchicken.com>
6896
6897 * xdisp.c (lookup_glyphless_char_display)
6898 (produce_glyphless_glyph): Handle cons cell entry in
6899 glyphless-char-display.
6900 (Vglyphless_char_display): Document it.
6901
6902 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6903 glyphless-char-display.
6904
4581706e
CY
69052011-04-17 Chong Yidong <cyd@stupidchicken.com>
6906
6907 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6908
6909 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6910
6911 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6912 definition for no-X builds.
6913
4887c6e2 69142011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 6915
fd35b6f9
PE
6916 Static checks with GCC 4.6.0 and non-default toolkits.
6917
5c1ccb01
PE
6918 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6919
006c5daa
PE
6920 * process.c (keyboard_bit_set): Define only if SIGIO.
6921 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6922 (send_process): Repair possible setjmp clobbering.
6923
efc736d3
PE
6924 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6925
4e2fe2e6
PE
6926 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6927
f97334a2
PE
6928 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6929
4e75f29d
PE
6930 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6931 Define only if needed.
6932
90efadd1
PE
6933 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6934 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 6935 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 6936
3c647824
PE
6937 * dispextern.h (struct redisplay_interface): Rename param
6938 to avoid shadowing.
e264f262 6939 * termhooks.h (struct terminal): Likewise.
761383f4 6940 * xterm.c (xembed_send_message): Likewise.
3c647824 6941
b58c5c4a
PE
6942 * insdel.c (make_gap_smaller): Define only if
6943 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6944
cad59032
PE
6945 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6946 it.
6947
c339dc2e
PE
6948 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6949 so that we aren't warned about unused symbols.
6950
91a3e27b
PE
6951 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6952
399c71d3 6953 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 6954
8ffc96f5
PE
6955 * xfns.c (x_real_positions): Mark locals as initialized.
6956
eef9bc79
PE
6957 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6958
098db9dd
PE
6959 * xterm.c: Fix problems found by static analysis with other toolkits.
6960 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
6961 (x_dispatch_event): Declare static if USE_GTK, and
6962 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 6963 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 6964 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
6965 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6966 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 6967
eb18f6cc
PE
6968 * xmenu.c (menu_help_callback): Pointer type fixes.
6969 Use const pointers when pointing at readonly data. Avoid pointer
6970 signedness clashes.
6971 (FALSE): Remove unused macro.
6972 (update_frame_menubar): Remove unused decl.
6973
1fe72bf8
PE
6974 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6975
60d9e1db
PE
6976 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6977 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6978 (single_menu_item): Rename local to avoid shadowing.
6979
39261c26
PE
6980 * keyboard.c (make_lispy_event): Remove unused local var.
6981
018c5e19
PE
6982 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6983 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6984
63d2b86e
PE
6985 * bitmaps: Change bitmaps from unsigned char back to the X11
6986 compatible char. Avoid the old compiler warnings about
6987 out-of-range initializers by using, for example, '\xab' rather
6988 than 0xab.
6989
aefd87e1
PE
6990 * xgselect.c (xgselect_initialize): Check vs interface
6991 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6992
bf501fb9
PE
6993 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6994
e9829fdf
PE
6995 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6996 to read-only memory.
6997
1086c095
PE
6998 * fns.c (vector): Remove; this old hack is no longer needed.
6999
2baccd04 7000 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 7001 Remove unused var.
dde42981 7002 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 7003
72391843 7004 * xrdb.c (x_load_resources): Omit unused local.
3565b346 7005
436c16df 7006 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 7007 (x_window): Rename locals to avoid shadowing.
dc5ddd85 7008 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 7009
92bb796d 7010 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 7011 (x_term_init): Remove local to avoid shadowing.
92bb796d 7012
764430a3 7013 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
7014
7015 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7016 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7017
d1dfb56c
EZ
70182011-04-16 Eli Zaretskii <eliz@gnu.org>
7019
c4354cb4
EZ
7020 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7021
d1dfb56c
EZ
7022 Fix regex.c, syntax.c and friends for buffers > 2GB.
7023 * syntax.h (struct gl_state_s): Declare character position members
7024 EMACS_INT.
7025
7026 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7027
04f2d78b
CB
7028 * textprop.c (verify_interval_modification, interval_of):
7029 Declare arguments EMACS_INT.
d1dfb56c
EZ
7030
7031 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7032 EMACS_INT.
7033
7034 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7035
7036 * indent.c (Fvertical_motion): Local variable it_start is now
7037 EMACS_INT.
7038
7039 * regex.c (re_match, re_match_2, re_match_2_internal)
7040 (bcmp_translate, regcomp, regexec, print_double_string)
7041 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7042 (re_compile_pattern, re_exec): Declare arguments and local
7043 variables `size_t' and `ssize_t' and return values `regoff_t', as
7044 appropriate.
7045 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7046 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7047 <compile_stack_type>: `size' and `avail' are now `size_t'.
7048
7049 * regex.h <regoff_t>: Use ssize_t, not int.
7050 (re_search, re_search_2, re_match, re_match_2): Arguments that
7051 specify buffer/string position and length are now ssize_t and
7052 size_t. Return type is regoff_t.
7053
613052cd
BK
70542011-04-16 Ben Key <bkey76@gmail.com>
7055
7056 * nsfont.m: Fixed bugs in ns_get_family and
7057 ns_descriptor_to_entity that were caused by using free to
7058 deallocate memory blocks that were allocated by xmalloc (via
7059 xstrdup). This caused Emacs to crash when compiled with
7060 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7061 --enable-checking=xmallocoverrun). xfree is now used to
7062 deallocate these memory blocks.
7063
4170f62f 70642011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 7065
71b41406
PE
7066 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7067
9587a89d
PE
7068 emacs_write: Accept and return EMACS_INT for sizes.
7069 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7070 et seq.
7071 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7072 Accept and return EMACS_INT.
7073 (emacs_gnutls_write): Return the number of bytes written on
7074 partial writes.
7075 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
7076 (emacs_read, emacs_write): Remove check for negative size, as the
7077 Emacs source code has been audited now.
9587a89d
PE
7078 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7079 (emacs_read, emacs_write): Use it.
273a5f82
PE
7080 * process.c (send_process): Adjust to the new signatures of
7081 emacs_write and emacs_gnutls_write. Do not attempt to store
7082 a byte offset into an 'int'; it might overflow.
9587a89d 7083 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 7084
3e047f51
PE
7085 * sound.c: Don't assume sizes fit in 'int'.
7086 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 7087 Return EMACS_INT, not int.
3e047f51 7088 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
7089 Accept EMACS_INT, not int.
7090 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
7091 record read return values.
7092
cc39a9db
BK
70932011-04-15 Ben Key <bkey76@gmail.com>
7094
c9d0ec6d
JB
7095 * keyboard.c (Qundefined): Don't declare static since it is used
7096 in nsfns.m.
7097 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7098 static since they are used in nsfont.m.
cc39a9db 7099
6c60eb9f
SM
71002011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7101
7102 * process.c (Qprocessp): Don't declare static.
7103 * lisp.h (Qprocessp): Declare again.
7104
7990b61a
JB
71052011-04-15 Juanma Barranquero <lekktu@gmail.com>
7106
7107 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7108
5d4cb038
PE
71092011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7110
8bd7b830 7111 Improve C-level modularity by making more things 'static'.
cd64ea1d 7112
e3b27b31
PE
7113 Don't publish debugger-only interfaces to other modules.
7114 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7115 (verify_bytepos, count_markers): Move decls to the only modules
7116 that need them.
7117 * region-cache.h (pp_cache): Likewise.
7118 * window.h (check_all_windows): Likewise.
7119 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7120
5d4cb038
PE
7121 * sysdep.c (croak): Now static, if
7122 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7123 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
7124
7125 * alloc.c (refill_memory_reserve): Now static if
7126 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7127 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 7128
e87b6180
PE
7129 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7130 Define only if USE_LUCID.
7131
ac64929e
PE
7132 * xrdb.c (x_customization_string, x_rm_string): Now static.
7133
6f37259d
PE
7134 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7135 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7136
1683e3ab
PE
7137 * xdisp.c (draw_row_with_mouse_face): Now static.
7138 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7139
de9c2632
PE
7140 * window.h (check_all_windows): Mark externally visible.
7141
2b96acb7
PE
7142 * window.c (window_deletion_count): Now static.
7143
7144 * undo.c: Make symbols static if they're not exported.
7145 (last_undo_buffer, last_boundary_position, pending_boundary):
7146 Now static.
7147
50436f33
PE
7148 * textprop.c (interval_insert_behind_hooks): Now static.
7149 (interval_insert_in_front_hooks): Likewise.
7150
64520e5c
PE
7151 * term.c: Make symbols static if they're not exported.
7152 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7153 (max_frame_lines, tty_set_terminal_modes):
7154 (tty_reset_terminal_modes, tty_turn_off_highlight):
7155 (get_tty_terminal): Now static.
7156 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7157 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 7158 HAVE_WINDOW_SYSTEM.
64520e5c
PE
7159 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7160 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7161
1fa53021
PE
7162 * sysdep.c: Make symbols static if they're not exported.
7163 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7164 Now static.
7165 (sigprocmask_set, full_mask): Remove; unused.
7166 (wait_debugging): Mark as visible.
7167 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7168 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7169
d4b43b22
PE
7170 * syntax.c (syntax_temp): Define only if !__GNUC__.
7171
b7c513d0
PE
7172 * sound.c (current_sound_device, current_sound): Now static.
7173
989b29ad
PE
7174 * search.c (searchbufs, searchbuf_head): Now static.
7175
13a55a78
PE
7176 * scroll.c (scroll_cost): Remove; unused.
7177 * dispextern.h (scroll_cost): Remove decl.
7178
de68a1fc
PE
7179 * region-cache.h (pp_cache): Mark as externally visible.
7180
40ccffa6
PE
7181 * process.c: Make symbols static if they're not exported.
7182 (process_tick, update_tick, create_process, chan_process):
7183 (Vprocess_alist, proc_buffered_char, datagram_access):
7184 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7185 (deactivate_process): Mark defn as static, as well as decl.
7186 * lisp.h (create_process): Remove decl.
7187 * process.h (chan_process, Vprocess_alist): Remove decls.
7188
ad64fc97
PE
7189 * print.c: Make symbols static if they're not exported.
7190 (print_depth, new_backquote_output, being_printed, print_buffer):
7191 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7192 (print_interval, print_number_index, initial_stderr_stream):
7193 Now static.
7194 * lisp.h (Fprinc): Remove decl.
7195 (debug_output_compilation_hack): Mark as externally visible.
7196
adddb265
PE
7197 * sysdep.c (croak): Move decl from here to syssignal.h.
7198 * syssignal.h (croak): Put it here, so the API can be checked when
7199 'croak' is called from dissociate_if_controlling_tty.
7200
1717ede2
PE
7201 * minibuf.c: Make symbols static if they're not exported.
7202 (minibuf_save_list, choose_minibuf_frame): Now static.
7203 * lisp.h (choose_minibuf_frame): Remove decl.
7204
fa5fb2bc
PE
7205 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7206
1e3890d1
PE
7207 * lread.c: Make symbols static if they're not exported.
7208 (read_objects, initial_obarray, oblookup_last_bucket_number):
7209 Now static.
7210 (make_symbol): Remove; unused.
7211 * lisp.h (initial_obarray, make_symbol): Remove decls.
7212
8a1414fa
PE
7213 * keyboard.c: Make symbols static if they're not exported.
7214 (single_kboard, recent_keys_index, total_keys, recent_keys):
7215 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7216 (this_single_command_key_start, echoing, last_auto_save):
7217 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7218 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7219 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7220 (Vlispy_mouse_stem, double_click_count):
7221 Now static.
7222 (force_auto_save_soon): Define only if SIGDANGER.
7223 (ignore_mouse_drag_p): Now static if
7224 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7225 (print_help): Remove; unused.
7226 (stop_character, last_timer_event): Mark as externally visible.
7227 * keyboard.h (ignore_mouse_drag_p): Declare only if
7228 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7229 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7230 * lisp.h (echoing): Remove decl.
7231 (force_auto_save_soon): Declare only if SIGDANGER.
7232 * xdisp.c (redisplay_window): Simplify code, to make it more
7233 obvious that ignore_mouse_drag_p is not accessed if !defined
7234 USE_GTK && !defined HAVE_NS.
7235
93ea6e8f
PE
7236 * intervals.c: Make symbols static if they're not exported.
7237 (merge_properties_sticky, merge_interval_right, delete_interval):
7238 Now static.
7239 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7240
77382fcc
PE
7241 * insdel.c: Make symbols static if they're not exported.
7242 However, leave prepare_to_modify_buffer alone. It's never
7243 called from outside this function, but that appears to be a bug.
7244 (combine_after_change_list, combine_after_change_buffer):
4889fc82 7245 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
7246 (adjust_after_replace_noundo): Remove; unused.
7247 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 7248 (signal_before_change): Remove decls.
77382fcc 7249
9306c32e
PE
7250 * indent.c (val_compute_motion, val_vmotion): Now static.
7251
cd44d2eb
PE
7252 * image.c: Make symbols static if they're not exported.
7253 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7254 if USE_GTK.
7255 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7256 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7257
ad9a7a06
PE
7258 * fringe.c (standard_bitmaps): Now static.
7259 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7260
81626931
PE
7261 * frame.c: Make symbols static if they're not exported.
7262 (x_report_frame_params, make_terminal_frame): Now static.
7263 (get_frame_param): Now static, unless HAVE_NS.
7264 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7265 (x_get_resource_string): Remove; not used.
7266 * frame.h (make_terminal_frame, x_report_frame_params):
7267 (x_get_resource_string); Remove decls.
7268 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7269 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7270
239f9db9
PE
7271 * font.c, fontset.c: Make symbols static if they're not exported.
7272 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7273 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7274 * font.c (font_close_object): Now static.
7275 * font.h (font_close_object): Remove.
7276 * fontset.c (FONTSET_OBJLIST): Remove.
7277 (free_realized_fontset) #if-0 the body, which does nothing.
7278 (face_suitable_for_char_p): #if-0, as it's never called.
7279 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
7280 * xfaces.c (face_at_string_position):
7281 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
7282 since 0 is always ASCII.
7283
dfcf3579
PE
7284 * fns.c (weak_hash_tables): Now static.
7285
5045092b
PE
7286 * fileio.c: Make symbols static if they're not exported.
7287 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7288 (Vwrite_region_annotation_buffers): Now static.
7289
57a96f5c
PE
7290 * eval.c: Make symbols static if they're not exported.
7291 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7292 * lisp.h (backtrace_list): Remove decl.
7293
35f08c38
PE
7294 * emacs.c: Make symbols static if they're not exported.
7295 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7296 (fatal_error_code, fatal_error_signal_hook, standard_args):
7297 Now static.
7298 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7299 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7300 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7301 * lisp.h (fatal_error_signal_hook): Remove decl.
7302 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7303
f44bd759
PE
7304 * editfns.c: Move a (normally-unused) function to its only use.
7305 * editfns.c, lisp.h (get_operating_system_release): Remove.
7306 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7307 worth the hassle of breaking this out.
7308
b532497d
PE
7309 * xterm.c: Make symbols static if they're not exported.
7310 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7311 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7312 (x_destroy_window, x_delete_display):
7313 Now static.
7314 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7315 (x_mouse_leave): Remove; unused.
7316 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7317 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7318 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7319 Remove decls.
7320 (x_mouse_leave): Declare only if WINDOWSNT.
7321 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7322 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7323 USE_X_TOOLKIT.
7324
1675728f
PE
7325 * ftxfont.c: Make symbols static if they're not exported.
7326 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7327 HAVE_FREETYPE.
7328 * font.h (ftxfont_driver): Likewise.
7329
e4cebfca
PE
7330 * xfns.c: Make symbols static if they're not exported.
7331 (x_last_font_name, x_display_info_for_name):
7332 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7333 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7334 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7335 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7336 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7337 (last_show_tip_args): Now static.
7338 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7339 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7340 (x_screen_planes): Remove; unused.
7341 * dispextern.h (x_screen_planes): Remove decl.
7342
5bf46f05
PE
7343 * dispnew.c: Make symbols static if they're not exported.
7344 * dispextern.h (redraw_garbaged_frames, scrolling):
7345 (increment_row_positions): Remove.
7346 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7347 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7348 Now static.
7349 (redraw_garbaged_frames): Remove; unused.
7350
435f4c28
PE
7351 * xfaces.c: Make symbols static if they're not exported.
7352 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7353 Remove decls.
7354 * xterm.h (defined_color): Remove decls.
7355 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7356 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7357 (menu_face_changed_default, defined_color, free_realized_face):
7358 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7359 (ascii_face_of_lisp_face): Remove; unused.
7360
8524aef3
PE
7361 * xdisp.c: Make symbols static if they're not exported.
7362 * dispextern.h (scratch_glyph_row, window_box_edges):
7363 (glyph_to_pixel_coords, set_cursor_from_row):
7364 (get_next_display_element, set_iterator_to_next):
7365 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7366 (show_mouse_face): Remove decls
7367 * frame.h (message_buf_print): Likewise.
7368 * lisp.h (pop_message, set_message, check_point_in_composition):
7369 Likewise.
7370 * xterm.h (set_vertical_scroll_bar): Likewise.
7371 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7372 (message_buf_print, scratch_glyph_row, displayed_buffer):
7373 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7374 (get_next_display_element, show_mouse_face, window_box_edges):
7375 (frame_to_window_pixel_xy, check_point_in_composition):
7376 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7377 (glyph_to_pixel_coords): Remove; unused.
7378
16390cd2
PE
7379 * dired.c (file_name_completion): Now static.
7380
7381 * dbusbind.c (xd_in_read_queued_messages): Now static.
7382
a25f4dfa
PE
7383 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7384 * data.c (circular_list_error): Remove.
7385
14a9c8df
PE
7386 * commands.h (last_point_position, last_point_position_buffer):
7387 (last_point_position_window): Remove decls.
7388 * keyboard.c: Make these variables static.
7389
04f2d78b
CB
7390 * coding.h (coding, code_convert_region, encode_coding_gap):
7391 Remove decls.
74ab6df5
PE
7392 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7393 (iso_code_class, detect_coding, code_convert_region): Now static.
7394 (encode_coding_gap): Remove; unused.
7395
38dfbee1
PE
7396 * chartab.c (chartab_chars, chartab_bits): Now static.
7397
a2cb4e63
PE
7398 * charset.h (charset_iso_8859_1): Remove decl.
7399 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7400 Now static.
7401
127198fd
PE
7402 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7403 * ccl.c (Vccl_program_table): Now static.
7404 (check_ccl_update): Remove; unused.
7405
d85b608f
PE
7406 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7407 * category.h: ... from here.
7408 * category.c (check_category_table, set_category_set): Now static.
7409
31cd66f3
PE
7410 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7411 * lisp.h: Remove these decls.
7412
c358e587
PE
7413 * buffer.c (buffer_count): Remove unused var.
7414
e78aecca
PE
7415 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7416 so that it's not optimized away.
7417 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7418 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7419 exported only to the debugger.
7420
e192d7d3 7421 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 7422 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 7423
92470028
PE
7424 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7425 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7426 was inaccessible from Lisp.
7427 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7428 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7429
244ed907
PE
7430 alloc.c: Import and export fewer symbols, and remove unused items.
7431 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7432 is defined.
7433 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7434 it's not optimized away by whole-program optimization.
7435 (message_enable_multibyte, free_misc): Remove.
7436 (catchlist, handlerlist, mark_backtrace):
7437 Declare only if BYTE_MARK_STACK.
7438 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7439 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7440 (message_enable_multibyte): Remove decl.
7441 (free_misc, interval_free_list, float_block, float_block_index):
7442 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7443 (cons_free_list, last_marked_index):
7444 Now static.
7445 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7446 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7447 (mark_backtrace): Define only if BYTE_MARK_STACK.
7448 * xdisp.c (message_enable_multibyte): Now static.
7449
61c2b50e 7450 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
7451 This makes it easier for human readers (and static analyzers)
7452 to see whether these variables are used from other modules.
7453 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7454 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7455 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7456 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7457 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7458 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7459 * xmenu.c, xselect.c:
7460 Declare Q* vars static if they are not used in other modules.
7461 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7462 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7463 Remove decls of unexported vars.
7464 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7465
95c82688
PE
7466 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7467
16a97296
PE
7468 Make Emacs functions such as Fatom 'static' by default.
7469 This makes it easier for human readers (and static analyzers)
7470 to see whether these functions can be called from other modules.
7471 DEFUN now defines a static function. To make the function external
7472 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
7473 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7474 (Finit_image_library):
16a97296
PE
7475 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7476 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7477 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7478 Remove decls, since these functions are now static.
7479 (Funintern, Fget_internal_run_time): New decls, since these functions
7480 were already external.
95c82688 7481
16a97296
PE
7482 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7483 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7484 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7485 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7486 * keyboard.c, keymap.c, lread.c:
7487 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7488 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7489 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7490 Mark functions with DEFUE instead of DEFUN,
7491 if they are used in other modules.
7492 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7493 decls for now-static functions.
7494 * buffer.h (Fdelete_overlay): Remove decl.
7495 * callproc.c (Fgetenv_internal): Mark as internal.
7496 * composite.c (Fremove_list_of_text_properties): Remove decl.
7497 (Fcomposition_get_gstring): New forward static decl.
7498 * composite.h (Fcomposite_get_gstring): Remove decl.
7499 * dired.c (Ffile_attributes): New forward static decl.
7500 * doc.c (Fdocumntation_property): New forward static decl.
7501 * eval.c (Ffetch_bytecode): New forward static decl.
7502 (Funintern): Remove extern decl; now in .h file where it belongs.
7503 * fileio.c (Fmake_symbolic_link): New forward static decl.
7504 * image.c (Finit_image_library): New forward static decl.
7505 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7506 * intervals.h (Fprevious_property_change):
7507 (Fremove_list_of_text_properties): Remove decls.
7508 * keyboard.c (Fthis_command_keys): Remove decl.
7509 (Fcommand_execute): New forward static decl.
7510 * keymap.c (Flookup_key): New forward static decl.
7511 (Fcopy_keymap): Now static.
7512 * keymap.h (Flookup_key): Remove decl.
7513 * process.c (Fget_process): New forward static decl.
7514 (Fprocess_datagram_address): Mark as internal.
7515 * syntax.c (Fsyntax_table_p): New forward static decl.
7516 (skip_chars): Remove duplicate decl.
7517 * textprop.c (Fprevious_property_change): New forward static decl.
7518 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7519 Now internal.
7520 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7521 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7522
785bbd42
PE
7523 * editfns.c (Fformat): Remove unreachable code.
7524
8b913b57
AS
75252011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7526
7527 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7528 change. (Bug#8496)
7529
a6744a35
EZ
75302011-04-13 Eli Zaretskii <eliz@gnu.org>
7531
7532 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7533 when at ZV. (Bug#8487)
7534
e7974947
AS
75352011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7536
baad03f0
AS
7537 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7538 (Bug#8437)
7539 * keyboard.c (parse_tool_bar_item): Likewise.
7540 * sound.c (sound_cleanup, alsa_close): Likewise.
7541 * termcap.c (tgetent): Likewise.
7542 * xfns.c (x_default_font_parameter): Likewise.
7543 * xsettings.c (read_and_apply_settings): Likewise.
7544
e7974947
AS
7545 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7546 (overrun_check_free): Protoize.
7547
28272684
PE
75482011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7549
7550 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7551 since callers should never pass a negative size.
7552 Change the signature to match that of plain 'read' and 'write'; see
7553 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7554 * lisp.h: Update prototypes of emacs_write and emacs_read.
7555
11997c76
EZ
75562011-04-11 Eli Zaretskii <eliz@gnu.org>
7557
7558 * xdisp.c (redisplay_window): Don't try to determine the character
7559 position of the scroll margin if the window start point w->startp
e896f03c 7560 is outside the buffer's accessible region. (Bug#8468)
11997c76 7561
8a2cbd72
EZ
75622011-04-10 Eli Zaretskii <eliz@gnu.org>
7563
7564 Fix write-region and its subroutines for buffers > 2GB.
7565 * fileio.c (a_write, e_write): Modify declaration of arguments and
7566 local variables to support buffers larger than 2GB.
7567 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7568
7569 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7570 argument, local variables, and return value.
7571
7572 * lisp.h: Update prototypes of emacs_write and emacs_read.
7573
7574 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7575
4073e537 75762011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 7577
1ebfdcb6
PE
7578 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7579
b2ded58d
PE
7580 Fix more problems found by GCC 4.6.0's static checks.
7581
7d66342c
PE
7582 * xdisp.c (vmessage): Use a better test for character truncation.
7583
bbf47d44
PE
7584 * charset.c (load_charset_map): <, not <=, for optimization,
7585 and to avoid potential problems with integer overflow.
9248994d 7586 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 7587 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 7588 * editfns.c (Fformat): Likewise.
1e69125e 7589 * syntax.c (skip_chars): Likewise.
3befa583 7590
e3019616
PE
7591 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7592 This also lets GCC 4.6.0 generate slightly better loop code.
7593
becfa255
PE
7594 * callint.c (Fcall_interactively): <, not <=, for optimization.
7595 (Fcall_interactively): Count the number of arguments produced,
7596 not the number of arguments given. This is simpler and lets GCC
7597 4.6.0 generate slightly better code.
7598
dae0cd48
PE
7599 * ftfont.c: Distingish more carefully between FcChar8 and char.
7600 The previous code passed unsigned char * to a functions like
7601 strlen and xstrcasecmp that expect char *, which does not
7602 conform to the C standard.
7603 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7604 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7605 char * when the C standard requires it.
7606
76032d70
PE
7607 * keyboard.c (read_char): Remove unused var.
7608
eb3f1cc8
PE
7609 * eval.c: Port to Windows vsnprintf (Bug#8435).
7610 Include <limits.h>.
7611 (SIZE_MAX): Define if the headers do not.
7612 (verror): Do not give up if vsnprintf returns a negative count.
7613 Instead, grow the buffer. This ports to Windows vsnprintf, which
7614 does not conform to C99. Problem reported by Eli Zaretskii.
7615 Also, simplify the allocation scheme, by avoiding the need for
7616 calling realloc, and removing the ALLOCATED variable.
7617
70476b54
PE
7618 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7619
12020a9e
PE
7620 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7621 But keep the doprint source code for now, as we might revamp it
7622 and use it again (Bug#8435).
ea6c7ae6
PE
7623 * lisp.h (doprnt): Remove.
7624 * Makefile.in (base_obj): Remove doprnt.o.
7625 * deps.mk (doprnt.o): Remove.
7626
5fdb398c
PE
7627 error: Print 32- and 64-bit integers portably (Bug#8435).
7628 Without this change, on typical 64-bit hosts error ("...%d...", N)
7629 was used to print both 32- and 64-bit integers N, which relied on
7630 undefined behavior.
7631 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7632 New macro.
7633 * lisp.h (error, verror): Mark as printf-like functions.
7634 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7635 Report overflow in size calculations when allocating printf buffer.
7636 Do not truncate output string at its first null byte.
7637 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7638 Truncate the output at a character boundary, since vsnprintf does not
7639 do that.
7640 * charset.c (check_iso_charset_parameter): Convert internal
7641 character to string before calling 'error', since %c now has the
7642 printf meaning.
7643 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7644 overflow when computing char to be passed to 'error'. Do not
7645 pass Lisp_Object to 'error'; pass the integer instead.
7646 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7647 formatted with plain %d.
7648
b189fa66
PE
7649 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7650
bff87ef0
PE
7651 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7652
7e2cac20
PE
7653 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7654
ce4d90b5
PE
7655 * xterm.c (x_catch_errors): Remove duplicate declaration.
7656
266c9547
PE
7657 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7658
79c49ad2
PE
7659 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7660
368f4090
JM
76612011-04-10 Jim Meyering <meyering@redhat.com>
7662
7663 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7664 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7665 return ssize_t not "int", and use size_t as the buffer length.
7666 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7667 * gnutls.h: Update declarations.
7668 * process.c (read_process_output): Use ssize_t, to match.
7669 (send_process): Likewise.
7670
a32d4040
CY
76712011-04-09 Chong Yidong <cyd@stupidchicken.com>
7672
7673 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7674
8546720e 76752011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 7676
04f2d78b
CB
7677 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7678 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 7679
8546720e
GM
7680 * xterm.c (handle_one_xevent):
7681 * xmenu.c (create_and_show_popup_menu):
7682 * xselect.c (x_decline_selection_request)
7683 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 7684
0a2f5c1a 76852011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
7686
7687 Fix some uses of `int' instead of EMACS_INT.
7688 * search.c (string_match_1, fast_string_match)
7689 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7690 (scan_buffer, find_next_newline_no_quit)
7691 (find_before_next_newline, search_command, Freplace_match)
7692 (Fmatch_data): Make some `int' variables be EMACS_INT.
7693
7694 * xdisp.c (display_count_lines): 3rd argument and return value now
7695 EMACS_INT. All callers changed.
7696 (pint2hrstr): Last argument is now EMACS_INT.
7697
7698 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7699 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7700 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7701 (decode_coding_utf_16, decode_coding_emacs_mule)
7702 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7703 (decode_coding_ccl, decode_coding_charset)
7704 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7705 (decode_coding_iso_2022, decode_coding_emacs_mule)
7706 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7707 <char_offset, last_offset>: Declare EMACS_INT.
7708 (encode_coding_utf_8, encode_coding_utf_16)
7709 (encode_coding_emacs_mule, encode_invocation_designation)
7710 (encode_designation_at_bol, encode_coding_iso_2022)
7711 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7712 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7713 Declare EMACS_INT.
7714 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7715 (encode_invocation_designation): Last argument P_NCHARS is now
7716 EMACS_INT.
7717 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7718 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7719
7720 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7721 All users changed.
7722
7723 * ccl.c (Fccl_execute_on_string): Declare some variables
7724 EMACS_INT.
7725
8546720e 77262011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
7727
7728 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7729
4e19a977
CS
77302011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7731
7732 * process.c (Fformat_network_address): Doc fix.
7733
87302331
R
77342011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7735
ee7683eb 7736 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 7737
cbb59342
CY
77382011-04-08 Chong Yidong <cyd@stupidchicken.com>
7739
7740 * keyboard.c (read_char): Call Lisp function help-form-show,
7741 instead of using internal_with_output_to_temp_buffer.
7742 (Qhelp_form_show): New var.
e0d38eeb 7743 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
7744
7745 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7746
7747 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7748
e67a13ab
CY
77492011-04-06 Chong Yidong <cyd@stupidchicken.com>
7750
04f2d78b
CB
7751 * process.c (Flist_processes): Remove to Lisp.
7752 (list_processes_1): Delete.
e67a13ab 7753
973f782d
EZ
77542011-04-06 Eli Zaretskii <eliz@gnu.org>
7755
7c106b1e
EZ
7756 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7757
973f782d
EZ
7758 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7759
41cf7d1a 77602011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 7761
ca23cc88
PE
7762 Fix more problems found by GCC 4.6.0's static checks.
7763
f390e2d5
PE
7764 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7765
42eea0d0
PE
7766 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7767
b69769da 7768 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 7769
f9541e84
PE
7770 * xdisp.c (vmessage): Mark as a printf-like function.
7771
13841b55
PE
7772 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7773
c136c10f
PE
7774 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7775
5e2d4a30
PE
7776 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7777 printf-like functions.
7778 (tiff_load): Add casts to remove these marks before passing them
7779 to system-supplied API.
7780
583f48b9
PE
7781 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7782
b25d760e
PE
7783 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7784 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
7785 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7786 directly, rather than having caller test rule sign. This avoids
7787 some unnecessary tests.
7788 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7789 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7790 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 7791
bc7b6697 7792 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 7793 (xfont_open): Avoid unnecessary tests.
bc7b6697 7794
27ccc379
PE
7795 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7796
dcd5c89a
PE
7797 * composite.h, composite.c (composition_gstring_put_cache):
7798 Use EMACS_INT, not int, for length.
7799
b13a45c6
PE
7800 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7801 breaking out part of COMPOSITION_DECODE_RULE.
7802 (COMPOSITION_DECODE_RULE): Use it.
7803 * composite.c (get_composition_id): Remove unused local vars,
7804 by using the new macro.
7805
1e792e4d
PE
7806 * textprop.c (set_text_properties_1): Change while to do-while,
7807 since the condition is always true at first.
7808
dc6c6455 7809 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
7810 (interval_deletion_adjustment): Return unsigned value.
7811 All uses changed.
dc6c6455 7812
aba7731a
PE
7813 * process.c (list_processes_1, create_pty, read_process_output):
7814 (exec_sentinel): Remove vars that were set but not used.
afd4052b 7815 (create_pty): Remove unnecessary "volatile"s.
bc57d757 7816 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 7817 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 7818 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 7819
fdfc4bf3
PE
7820 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7821
fca8fe46 7822 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 7823 (update_syntax_table): Use unsigned instead of int.
fca8fe46 7824
06a0259a 7825 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 7826 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 7827 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 7828
e7b9e80f
PE
7829 * print.c (print_error_message): Avoid int overflow.
7830
56201685
PE
7831 * font.c (font_list_entities): Redo for clarity,
7832 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7833
78834453 7834 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 7835 (font_score): Avoid potential overflow in diff calculation.
78834453 7836
0bc0b309 7837 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 7838 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 7839
e610eaca
PE
7840 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7841
b895abce
PE
7842 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7843 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7844 can always succeed if overflow has undefined behavior.
7845
1f1d9321 7846 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 7847 (wordify): Omit three unnecessary tests.
1f1d9321 7848
c59478bc
PE
7849 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7850 All callers changed. This avoids the need for an unused var.
7851
79b73827
PE
7852 * casefiddle.c (casify_region): Remove var that is set but not used.
7853
a4db5dfe
PE
7854 * dired.c (file_name_completion): Remove var that is set but not used.
7855
43aae36e
PE
7856 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7857
2a47c44d 7858 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 7859 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 7860
a37c69bf
PE
7861 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7862 Check for integer overflow on size calculations.
7863
328ab8e7
PE
7864 * buffer.c (Fprevious_overlay_change): Remove var that is set
7865 but not used.
7866
e5a2a5cb
PE
7867 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7868 Remove vars that are set but not used.
8d84a6eb 7869 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 7870 (timer_check_2): Mark vars as initialized.
e5a2a5cb 7871
a60e5f68
PE
7872 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7873
f661cb61 7874 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 7875 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 7876
f0397f5a
PE
7877 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7878 that are set but not used.
7879
8664db06 7880 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 7881 if XCreateBitmapFromData fails (Bug#8410).
8664db06 7882
6abdaa4a
PE
7883 * xselect.c (x_get_local_selection, x_handle_property_notify):
7884 Remove vars that are set but not used.
7885
0ce7538d 7886 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 7887 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 7888
9ae848fc
PE
7889 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7890 Remove var that is set but not used.
0b918413
PE
7891 (scroll_bar_windows_size): Now size_t, not int.
7892 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7893 Check for overflow.
9ae848fc 7894
a5a62657
PE
7895 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7896 (map_tty_color) [!defined MSDOS]: Likewise.
7897
5c5cdd39
PE
7898 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7899
66ebf983
PE
7900 * coding.c: Remove vars that are set but not used.
7901 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7902 All callers changed.
7903 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7904 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7905 (decode_coding_charset): Remove vars that are set but not used.
7906
1be4d761
PE
7907 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7908 that is set but not used.
7909
47553fa8
PE
7910 * print.c (print_object): Remove var that is set but not used.
7911
1f7196bf 7912 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
7913 The gnulib version avoids calling malloc in the usual case,
7914 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7915 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7916 * filelock.c (current_lock_owner): Likewise.
7917 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7918 * sysdep.c: Include allocator.h, careadlinkat.h.
7919 (emacs_no_realloc_allocator): New static constant.
7920 (emacs_readlink): New function.
fdb61804
PE
7921 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7922 ../lib/careadlinkat.h.
d1fdcab7 7923
f84c17c7
SM
79242011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7925
7926 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7927 first non-nil return value).
7928
ef3862ad
JD
79292011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7930
7931 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7932 if not defined (Bug#8403).
7933
376a7006
JB
79342011-04-02 Juanma Barranquero <lekktu@gmail.com>
7935
7936 * xdisp.c (display_count_lines): Remove parameter `start',
7937 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7938 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7939 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7940 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7941 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7942 and thereabouts. All callers changed.
7943 (get_per_char_metric): Remove parameter `f', unused since
7944 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7945
6ca3801d
JM
79462011-04-02 Jim Meyering <meyering@redhat.com>
7947
7948 do not dereference NULL upon failed strdup
7949 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7950 (ns_get_family): Likewise.
7951
d8e2b5ba
JB
79522011-04-02 Juanma Barranquero <lekktu@gmail.com>
7953
7954 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7955
8c74fcbd
JD
79562011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7957
7958 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7959 later (Bug#8403).
7960
7200d79c
SM
79612011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7962
03408648 7963 Add lexical binding.
7200d79c 7964
03408648
SM
7965 * window.c (Ftemp_output_buffer_show): New fun.
7966 (Fsave_window_excursion):
7967 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7968
7969 * lread.c (lisp_file_lexically_bound_p): New function.
7970 (Fload): Bind Qlexical_binding.
7971 (readevalloop): Remove `evalfun' arg.
7972 Bind Qinternal_interpreter_environment.
7973 (Feval_buffer): Bind Qlexical_binding.
7974 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7975 Mark as dynamic.
7976 (syms_of_lread): Declare `lexical-binding'.
7977
7978 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7979
7980 * keyboard.c (eval_dyn): New fun.
7981 (menu_item_eval_property): Use it.
ca105506
SM
7982
7983 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 7984
03408648
SM
7985 * fns.c (concat, mapcar1): Accept byte-code-functions.
7986
7987 * eval.c (Fsetq): Handle lexical vars.
7988 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7989 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7990 (FletX, Flet): Obey lexical binding.
7991 (Fcommandp): Handle closures.
7992 (Feval): New `lexical' arg.
7993 (eval_sub): New function extracted from Feval. Use it almost
7994 everywhere where Feval was used. Look up vars in lexical env.
7995 Handle closures.
7996 (Ffunctionp): Move from subr.el.
7997 (Ffuncall): Handle closures.
7998 (apply_lambda): Remove `eval_flags'.
7999 (funcall_lambda): Handle closures and new byte-code-functions.
8000 (Fspecial_variable_p): New function.
8001 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8002 but without exporting it to Lisp.
23aba0ea 8003
23aba0ea 8004 * doc.c (Fdocumentation, store_function_docstring):
03408648 8005 * data.c (Finteractive_form): Handle closures.
23aba0ea 8006
03408648
SM
8007 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8008 interactive spec.
ba83908c 8009
04f2d78b
CB
8010 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8011 New byte-codes.
03408648
SM
8012 (exec_byte_code): New function extracted from Fbyte_code to handle new
8013 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 8014
03408648 8015 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 8016
03408648 8017 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 8018
e2abce01
JB
80192011-03-31 Juanma Barranquero <lekktu@gmail.com>
8020
8021 * xdisp.c (redisplay_internal): Fix prototype.
8022
63696a73 80232011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 8024
63696a73 8025 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
8026 (try_scrolling): Use it when setting scroll_limit.
8027 Limit scrolling to 100 screen lines.
63696a73
EZ
8028 (redisplay_window): Even when falling back on "recentering",
8029 position point in the window according to scroll-conservatively,
8030 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8031
8032 (try_scrolling): When point is above the window, allow searching
8033 as far as scroll_max, or one screenful, to compute vertical
8034 distance from PT to the scroll margin position. This prevents
8035 try_scrolling from unnecessarily failing when
8036 scroll-conservatively is set to a value slightly larger than the
8037 window height. Clean up the case of PT below the margin at bottom
8038 of window: scroll_max can no longer be INT_MAX. When aggressive
8039 scrolling is in use, don't let point enter the opposite scroll
8040 margin as result of the scroll.
8041 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
8042 threshold of 100 lines for never-recentering scrolling.
8043
e4cc2dfc
JB
80442011-03-31 Juanma Barranquero <lekktu@gmail.com>
8045
8046 * dispextern.h (move_it_by_lines):
8047 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8048 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8049 (message_log_check_duplicate): Remove parameters `prev_bol' and
8050 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8051 (redisplay_internal): Remove parameter `preserve_echo_area',
8052 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8053
8054 * indent.c (Fvertical_motion):
8055 * window.c (window_scroll_pixel_based, Frecenter):
8056 Don't pass `need_y_p' to `move_it_by_lines'.
8057
1c470562
SM
80582011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8059
44f230aa
SM
8060 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8061 steal a few bits to be more compact.
8062 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8063 Remove unneeded casts.
8064
1c470562
SM
8065 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8066
888adce9
ZK
80672011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8068
8069 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8070 binding" message (bug#7967).
8071
f838ed7b
PE
80722011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8073
77861b95
PE
8074 Fix more problems found by GCC 4.6.0's static checks.
8075
de6dbc14
PE
8076 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8077 Remove unused local var.
8078
f838ed7b
PE
8079 * editfns.c (Fmessage_box): Remove unused local var.
8080
792c7b2b
PE
8081 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8082 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8083 Omit unused local vars.
c499e557 8084 * window.c (shrink_windows): Omit unused local var.
b01a1c29 8085 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
8086 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8087 Omit unused local var.
8088
ba0165e1
PE
8089 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8090 Don't assume string length fits in int.
32ad8845 8091 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 8092 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 8093
3c59b4c9
PE
8094 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8095 instead of alloca (Bug#8344).
8096
a3eed478 8097 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 8098 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 8099
eb4d412d
PE
8100 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8101
1658b401
PE
8102 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8103 concerns.
8104
8105 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8106
8107 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 8108
9a2c6e05
PE
8109 * keyboard.c (syms_of_keyboard): Use the same style as later
8110 in this function when indexing through an array. This also
8111 works around GCC bug 48267.
8112
03d0a109
PE
8113 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8114
44f730c8
PE
8115 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8116
fe75f926
PE
8117 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8118 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8119
ffa8c828
PE
8120 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8121 This avoids undefined behavior on integer overflow, and is a bit
8122 more convenient anyway since it is compared to a size_t variable.
8123
c5101a77
PE
8124 Variadic C functions now count arguments with size_t, not int.
8125 This avoids an unnecessary limitation on 64-bit machines, which
8126 caused (substring ...) to crash on large vectors (Bug#8344).
8127 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8128 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 8129 All variadic functions and their callers changed accordingly.
c5101a77
PE
8130 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8131 * data.c (arith_driver, float_arith_driver): Likewise.
8132 * editfns.c (general_insert_function): Likewise.
8133 * eval.c (struct backtrace.nargs, interactive_p)
8134 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8135 (funcall_lambda, mark_backtrace): Likewise.
8136 * fns.c (concat): Likewise.
8137 * frame.c (x_set_frame_parameters): Likewise.
8138 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8139 0 if not found, not -1. All callers changed.
8140
dd3f25f7
PE
8141 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8142 (stack_copy_size): Now size_t, not int.
8143 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8144
461c2ab9
JB
81452011-03-28 Juanma Barranquero <lekktu@gmail.com>
8146
8147 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8148 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8149 All callers changed.
8150
8151 * lisp.h (multibyte_char_to_unibyte):
8152 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8153 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8154 * character.h (CHAR_TO_BYTE8):
8155 * cmds.c (internal_self_insert):
8156 * editfns.c (general_insert_function):
8157 * keymap.c (push_key_description):
8158 * search.c (Freplace_match):
8159 * xdisp.c (message_dolog, set_message_1): All callers changed.
8160
f6d62986
SM
81612011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8162
8163 * keyboard.c (safe_run_hook_funcall): New function.
8164 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8165 don't set the hook to nil, but remove the offending function instead.
8166 (Qcommand_hook_internal): Remove, unused.
8167 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8168 Vcommand_hook_internal.
8169
8170 * eval.c (enum run_hooks_condition): Remove.
8171 (funcall_nil, funcall_not): New functions.
8172 (run_hook_with_args): Call each function through a `funcall' argument.
8173 Remove `cond' argument, now redundant.
8174 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8175 (Frun_hook_with_args_until_failure): Adjust accordingly.
8176 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8177
1db5b1ad
JB
81782011-03-28 Juanma Barranquero <lekktu@gmail.com>
8179
8180 * dispextern.h (string_buffer_position): Remove declaration.
8181
8182 * print.c (strout): Remove parameter `multibyte', unused since
8183 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8184
8185 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8186 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8187 All callers changed.
8188
8189 * w32.c (_wsa_errlist): Use braces for struct initializers.
8190
8191 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8192 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8193 All callers changed.
8194 (string_buffer_position): Likewise. Also, make static (it's never
8195 used outside xdisp.c).
8196 (cursor_row_p): Remove parameter `w', unused since
8197 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8198 (decode_mode_spec): Remove parameter `precision', introduced during
8199 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8200 All callers changed.
8201
5ffb62aa
JD
82022011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8203
8204 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8205
461c2ab9 82062011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
8207
8208 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8209 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8210 (ns_update_auto_hide_menu_bar): New functions.
8211 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8212 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8213 ns_constrain_all_frames.
8214 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8215 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8216
5c380ffb
JD
82172011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8218
8219 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8220
9af30bdf
GM
82212011-03-27 Glenn Morris <rgm@gnu.org>
8222
8223 * syssignal.h: Replace RETSIGTYPE with void.
8224 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8225 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8226 Replace SIGTYPE with void everywhere.
8227 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8228 * s/template.h (SIGTYPE): Remove commented out definition.
8229
e2abce01
JB
82302011-03-26 Eli Zaretskii <eliz@gnu.org>
8231
8232 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8233 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8234
f868cd8a
JB
82352011-03-26 Juanma Barranquero <lekktu@gmail.com>
8236
59eb0929
JB
8237 * w32.c (read_unc_volume): Use parameter `henum', instead of
8238 global variable `wget_enum_handle'.
8239
8240 * keymap.c (describe_vector): Remove parameters `indices' and
8241 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8242 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8243
f868cd8a
JB
8244 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8245
8246 * keyboard.c (timer_check): Remove parameter `do_it_now',
8247 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8248 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8249 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8250
8251 * keyboard.c (read_char):
8252 * w32menu.c (w32_menu_display_help):
8253 * xmenu.c (show_help_event, menu_help_callback):
8254 Adjust calls to `show_help_echo'.
8255
8256 * gtkutil.c (xg_maybe_add_timer):
8257 * keyboard.c (readable_events):
8258 * process.c (wait_reading_process_output):
8259 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8260
8261 * insdel.c (adjust_markers_gap_motion):
8262 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8263 (gap_left, gap_right): Don't call it.
8264
2ecf6fdb
CY
82652011-03-25 Chong Yidong <cyd@stupidchicken.com>
8266
8267 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8268 incurred during fontification.
8269
6b1f9ba4
JB
82702011-03-25 Juanma Barranquero <lekktu@gmail.com>
8271
8272 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8273 (DEFVAR_PER_BUFFER): Don't pass it.
8274
8275 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8276 (scrolling_window): Don't pass it.
8277
0f4a96b5
JB
82782011-03-25 Juanma Barranquero <lekktu@gmail.com>
8279
8280 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8281
8282 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8283 and `suffix'.
8284 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8285 of variables specific to SELinux and computation of `encoded_absname'.
8286
8287 * image.c (XPutPixel): Remove unused variable `height'.
8288
8289 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8290
8291 * unexw32.c (get_section_info): Remove unused variable `section'.
8292
8293 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8294 (system_process_attributes): Remove unused variable `sess'.
8295 (sys_read): Remove unused variable `err'.
8296
8297 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8298 (w32_wnd_proc): Remove unused variable `isdead'.
8299 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8300 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8301 (x_create_tip_frame): Remove unused variable `tem'.
8302
8303 * w32inevt.c (w32_console_read_socket):
8304 Remove unused variable `no_events'.
8305
8306 * w32term.c (x_draw_composite_glyph_string_foreground):
8307 Remove unused variable `width'.
8308
1149507c
JB
83092011-03-24 Juanma Barranquero <lekktu@gmail.com>
8310
8311 * w32term.c (x_set_glyph_string_clipping):
8312 Don't pass uninitialized region to CombineRgn.
8313
9c88f339
JB
83142011-03-23 Juanma Barranquero <lekktu@gmail.com>
8315
8316 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8317 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8318 (Fx_close_connection): Remove unused variable `i'.
8319
8320 * w32font.c (w32font_draw): Return number of glyphs.
8321 (w32font_open_internal): Remove unused variable `i'.
8322 (w32font_driver): Add missing initializer.
8323
8324 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8325 (fill_in_menu): Remove unused variable `items_added'.
8326
8327 * w32term.c (last_mouse_press_frame): Remove static global variable.
8328 (w32_clip_to_row): Remove unused variable `f'.
8329 (x_delete_terminal): Remove unused variable `i'.
8330
8331 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8332 (NOTHING): Remove unused static global variable.
8333 (uniscribe_check_otf): Remove unused variable `table'.
8334 (uniscribe_font_driver): Add missing initializers.
8335
dee091a3
JD
83362011-03-23 Julien Danjou <julien@danjou.info>
8337
8338 * term.c (Fsuspend_tty, Fresume_tty):
8339 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8340 * window.c (temp_output_buffer_show):
8341 * insdel.c (signal_before_change):
8342 * frame.c (Fhandle_switch_frame):
8343 * fileio.c (Fdo_auto_save):
8344 * emacs.c (Fkill_emacs):
8345 * editfns.c (save_excursion_restore):
8346 * cmds.c (internal_self_insert):
8347 * callint.c (Fcall_interactively):
8348 * buffer.c (Fkill_all_local_variables):
8349 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8350 Use Frun_hooks.
0f4a96b5 8351 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 8352 unconditionally since it does the check itself.
dee091a3 8353
2c520ab5 83542011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 8355
c9c49752
PE
8356 Fix more problems found by GCC 4.5.2's static checks.
8357
8abc3f12
PE
8358 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8359 the first time through the loop, since we know p0 < p1 then.
8360 This also avoids a gcc -Wstrict-overflow warning.
8361
a2d26660
PE
8362 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8363 leading to a memory leak, possible in functions like
8364 load_charset_map_from_file that can allocate an unbounded number
b12ef411 8365 of objects (Bug#8318).
a2d26660 8366
916c72e9
PE
8367 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8368 that could (at least in theory) be that large.
8369
19ab8a18
PE
8370 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8371 This is less likely to overflow, and avoids undefined behavior if
8372 overflow does occur. All callers changed. Use strtoul to scan
8373 for the unsigned long integer.
b7cbbd6f
PE
8374 (pint2hrstr): Simplify and tune code slightly.
8375 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 8376
f0641eff
PE
8377 * scroll.c (do_scrolling): Work around GCC bug 48228.
8378 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8379
7f650bb9
PE
8380 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8381 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
8382 (validate_x_resource_name): Simplify count usage.
8383 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 8384
37dd57d1
PE
8385 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8386 fail (Bug#8306).
81e56e61 8387
699979fc 8388 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 8389
401bf9b4
PE
8390 * process.c (Fmake_network_process): Use socklen_t, not int,
8391 where POSIX says socklen_t is required in portable programs.
8392 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 8393 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
8394 (Fmake_network_process, server_accept_connection):
8395 (wait_reading_process_output, read_process_output):
8396 Likewise.
8397
b93aacde
PE
8398 * process.c: Rename or move locals to avoid shadowing.
8399 (list_processes_1, Fmake_network_process):
8400 (read_process_output_error_handler, exec_sentinel_error_handler):
8401 Rename or move locals.
4dc343ee 8402 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 8403 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 8404 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 8405 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 8406 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 8407
af8a867c 8408 Make tparam.h and terminfo.c consistent.
44f230aa
SM
8409 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8410 Include tparam.h instead, since it declares them.
af8a867c
PE
8411 * cm.h (PC): Remove extern decl; tparam.h now does this.
8412 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8413 * terminfo.c: Include tparam.h, to check interfaces.
8414 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8415 (tparam): Adjust signature to match interface in tparam.h;
8416 this removes some undefined behavior. Check that outstring and len
8417 are zero, which they always are with Emacs.
8418 * tparam.h (PC, BC, UP): New extern decls.
8419
0248044d 8420 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 8421 (xftfont_open): Rename locals to avoid shadowing.
0248044d 8422
8ff096c1 8423 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
8424 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8425 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 8426 (ftfont_list): Remove unused local.
49eaafba
PE
8427 (get_adstyle_property, ftfont_pattern_entity):
8428 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8429 Rename locals to avoid shadowing.
8ff096c1 8430
e2be39f6
PE
8431 * xfont.c (xfont_list_family): Mark var as initialized.
8432
c9735e30
PE
8433 * xml.c (make_dom): Now static.
8434
8f5201ae
PE
8435 * composite.c (composition_compute_stop_pos): Rename local to
8436 avoid shadowing.
b246f932
PE
8437 (composition_reseat_it): Remove unused locals.
8438 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 8439 (composition_update_it): Mark var as initialized.
11b61122
PE
8440 (find_automatic_composition): Mark vars as initialized,
8441 with a FIXME (Bug#8290).
8f5201ae 8442
760fbc2c
PE
8443 character.h: Rename locals to avoid shadowing.
8444 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8445 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8446 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8447 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8448 to avoid shadowing.
8449
ff08eb85
PE
8450 * textprop.c (property_change_between_p): Remove; unused.
8451
fc7bf025
PE
8452 * intervals.c (interval_start_pos): Now static.
8453
235d7abc
PE
8454 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8455
44f230aa
SM
8456 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8457 Rename locals to avoid shadowing.
3e7d6594 8458
50060332
PE
8459 * sound.c (wav_play, au_play, Fplay_sound_internal):
8460 Fix pointer signedness.
d01f234b 8461 (alsa_choose_format): Remove unused local var.
c83b8872
PE
8462 (wav_play): Initialize a variable to 0, to prevent undefined
8463 behavior (Bug#8278).
50060332 8464
c4fc4e30
PE
8465 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8466
918436ed
PE
8467 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8468
c939f91b
PE
8469 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8470 clobbering (Bug#8298).
b9c7f648
PE
8471 * sysdep.c (sys_subshell): Likewise.
8472 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 8473
6bd8c144
PE
8474 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8475 This should get cleaned up, so that child_setup has the
8476 same signature on all platforms.
8477
7710357c 8478 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 8479 (relocate_fd): Rename locals to avoid shadowing.
7710357c 8480
c59da222
CY
84812011-03-22 Chong Yidong <cyd@stupidchicken.com>
8482
8483 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8484 not to be necessary, and produces flickering.
8485
66b87493
GM
84862011-03-20 Glenn Morris <rgm@gnu.org>
8487
8488 * config.in: Remove file.
8489
45b6f6d5
JB
84902011-03-20 Juanma Barranquero <lekktu@gmail.com>
8491
8492 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8493 are now in src/globals.h.
8494 (syms_of_minibuf): Remove spurious & from previous change.
8495
cd394be1 84962011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
8497
8498 * minibuf.c (completing-read-function): New variable.
8499 (completing-read-default): Rename from completing-read.
8500 (completing-read): Call completing-read-function.
8501
b14e3e21
CY
85022011-03-19 Juanma Barranquero <lekktu@gmail.com>
8503
8504 * xfaces.c (Fx_load_color_file):
8505 Read color file from absolute filename (bug#8250).
8506
f2b726e6
JB
85072011-03-19 Juanma Barranquero <lekktu@gmail.com>
8508
8509 * makefile.w32-in: Update dependencies.
8510
09f6ff02
EZ
85112011-03-17 Eli Zaretskii <eliz@gnu.org>
8512
8513 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8514
29a6015a
PE
85152011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8516
a3a6c54e
PE
8517 Fix more problems found by GCC 4.5.2's static checks.
8518
b766f867
PE
8519 * process.c (make_serial_process_unwind, send_process_trap):
8520 (sigchld_handler): Now static.
8521
be02381c
PE
8522 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8523 That way, the code declares only the vars that it needs.
8524 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8525 * s/cygwin.h (PTY_ITERATION): Likewise.
8526 * s/darwin.h (PTY_ITERATION): Likewise.
8527 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8528
57048744
PE
8529 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8530 * process.c (allocate_pty): Don't declare stb unless it's needed.
8531
7914961c 8532 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
8533 (CONSTANTLIM): Remove; unused.
8534 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8535 Define only if needed.
7914961c 8536
b3967b18
PE
8537 * unexelf.c (unexec): Name an expression,
8538 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
8539 Use a different way to cause a compilation error if anyone uses
8540 n rather than nn, a way that does not involve shadowing.
73366a00 8541 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 8542
29a6015a
PE
8543 * deps.mk (unexalpha.o): Remove; unused.
8544
43cfc33e 8545 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 8546 * unexec.h: New file.
ce701a33
PE
8547 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8548 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8549 Depend on unexec.h.
8550 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8551 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8552 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 8553 Change as necessary to match prototype in unexec.h.
ce701a33 8554
01f44d5a
PE
8555 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8556 shadowing.
4f63c6bb 8557 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 8558
a6670b0b
PE
8559 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8560 Rename locals to avoid shadowing.
8561
cef2010d 8562 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 8563 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 8564
d4d7173a
PE
8565 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8566
f08b802a
PE
8567 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8568 warning when compiling print.c.
8569
3ddb0639
PE
8570 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8571 instead of using an uninitialized var.
5ad03b97 8572 (font_sort_entities): Mark var as initialized.
3ddb0639 8573
170a2692
PE
8574 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8575
e663c700
PE
8576 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8577 pointers to constants.
89bc529a 8578 (font_parse_fcname): Remove unused vars.
7b81e2d0 8579 (font_delete_unmatched): Now static.
ea838e10 8580 (font_get_spec): Remove; unused.
13a547c6
PE
8581 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8582 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8583 Rename or move locals to avoid shadowing.
e663c700 8584
2a80c887 8585 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 8586 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 8587
1384fa33 8588 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 8589 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 8590
8b2c52e9
PE
8591 * alloc.c (mark_backtrace): Move decl from here ...
8592 * lisp.h: ... to here, so that it can be checked.
8593
475545b5 8594 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 8595 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
8596 (lisp_indirect_variable): Name an expression,
8597 to avoid gcc -Wbad-function-cast warning.
1faed8ae 8598 (Fdefvar): Rename locals to avoid shadowing.
475545b5 8599
b1349114 8600 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 8601 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 8602 Use const pointer when appropriate.
b1349114 8603
a2928364
PE
8604 * lisp.h (get_system_name, get_operating_system_release):
8605 Move decls here, to check interfaces.
8606 * process.c (get_operating_system_release): Move decl to lisp.h.
8607 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
8608 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8609 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8610 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
8611 (Fformat_time_string, Fencode_time, Finsert_char):
8612 (Ftranslate_region_internal, Fformat):
8613 Rename or remove local vars to avoid shadowing.
9710023e 8614 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 8615
a415e694
PE
8616 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8617 avoid shadowing.
8618
8ef4622d
PE
8619 * lisp.h (eassert): Check that the argument compiles, even if
8620 ENABLE_CHECKING is not defined.
8621
946f9a5b
PE
8622 * data.c (Findirect_variable): Name an expression, to avoid
8623 gcc -Wbad-function-cast warning.
112396d6 8624 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 8625 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
8626 (Fmake_variable_buffer_local, Fmake_local_variable):
8627 Mark variables as initialized.
52746918 8628 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 8629
e5aab7e7 8630 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
8631 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8632 Rename locals to avoid shadowing.
dff45157
PE
8633 (mark_stack): Move local variables into the #ifdef region where
8634 they're used.
7bc26fdb
PE
8635 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8636 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8637 needed otherwise.
8638 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8639 (GC_STRING_CHARS): Remove; not used.
d40d4be1 8640 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 8641
e5aab7e7
PE
8642 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8643 avoids undefined behavior in theory.
8644
4da60324
PE
8645 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8646
88043301
PE
8647 Use functions, not macros, for up- and down-casing (Bug#8254).
8648 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8649 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8650 to use the following functions instead of these macros.
8651 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8652 EMACS_INT, since callers assume the returned value fits in int.
8653 (upcase1): Likewise, for UPCASE_TABLE.
8654 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 8655 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 8656 the race-condition problem in the old DOWNCASE.
88043301 8657
19ed5445
PE
8658 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8659 Rename locals to avoid shadowing.
8660 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
8661 (regex_compile, re_search_2, re_match_2_internal):
8662 Remove unused local vars.
952db0d7
PE
8663 (FREE_VAR): Rewrite so as not to use empty "else",
8664 which gcc can warn about.
da053e48 8665 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
8666 (RETALLOC_IF): Define only if needed.
8667 (WORDCHAR_P): Likewise. This one is never needed, but is used
8668 only in a comment talking about a compiler bug, so put inside
8669 the #if 0 of that comment.
8670 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8671 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8672 Remove; unused.
19ed5445 8673
1f3561e4 8674 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
8675 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8676 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 8677
ded6f8f7
PE
8678 * search.c (simple_search): Remove unused var.
8679
dbd37a95
PE
8680 * dired.c (compile_pattern): Move decl from here ...
8681 * lisp.h: ... to here, so that it can be checked.
8682 (struct re_registers): New forward decl.
8683
7e47afad
PE
8684 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8685
85f24f61
PE
8686 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8687 All uses changed.
8688 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8689 Rename locals to avoid shadowing.
5671df8f 8690 (Fvertical_motion): Mark locals as initialized.
85f24f61 8691
181aa2be 8692 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 8693 (casify_region): Mark local as initialized.
181aa2be 8694
930d429c
PE
8695 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8696
7082eac6
PE
8697 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8698 New macros, so that the caller can use some names other than
8699 gcpro1, gcpro2, etc.
8700 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8701 of the new macros.
8702 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8703 argument, for consistency with GCPRO2_VAR, etc: it is now the
8704 prefix of the variable, not the variable itself. All uses
8705 changed.
38b2c076
PE
8706 * dired.c (directory_files_internal, file_name_completion):
8707 Rename locals to avoid shadowing.
8708
15206ed9
PE
8709 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8710 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8711 dired.c's scmp function, had undefined behavior.
8712 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8713 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8714 * buffer.h: ... to here, because these macros use current_buffer,
8715 and the new implementation with inline functions needs to have
8716 current_buffer in scope now, rather than later when the macros
8717 are used.
8718 (downcase, upcase1): New static inline functions.
8719 (DOWNCASE, UPCASE1): Reimplement using these functions.
8720 This avoids undefined behavior in expressions like
8721 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8722 from race conditions in accessing the global variables
8723 case_temp1 and case_temp2.
8724 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8725 * lisp.h (case_temp1, case_temp2): Remove their decls.
8726 * character.h (ASCII_CHAR_P): Move from here ...
8727 * lisp.h: ... to here, so that the inline functions mentioned
8728 above can use them.
8729
4a6bea26
PE
8730 * dired.c (directory_files_internal_unwind): Now static.
8731
f14b7e14
PE
8732 * fileio.c (file_name_as_directory, directory_file_name):
8733 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8734 Now static.
2893f146
PE
8735 (file_name_as_directory): Use const pointers when appropriate.
8736 (Fexpand_file_name): Likewise. In particular, newdir might
8737 point at constant storage, so make it a const pointer.
fd4ead52 8738 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
8739 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8740 signedness issues.
f839df0c
PE
8741 (Fset_file_times, Finsert_file_contents, auto_save_error):
8742 Rename locals to avoid shadowing.
f14b7e14 8743
5716756e 8744 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
8745 (Ftry_completion, Fall_completions): Rename or remove locals
8746 to avoid shadowing.
5716756e 8747
b4c3046a
PE
8748 * marker.c (bytepos_to_charpos): Remove; unused.
8749
b45db522
PE
8750 * lisp.h (verify_bytepos, count_markers): New decls,
8751 so that gcc does not warn that these functions aren't declared.
8752
85876d07
PE
8753 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8754 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 8755 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 8756 (copy_text): Remove unused local var.
85876d07 8757
03d78a21 8758 * filelock.c (within_one_second): Now static.
b3dd38ab 8759 (lock_file_1): Rename local to avoid shadowing.
03d78a21 8760
5df8f01b
PE
8761 * buffer.c (fix_overlays_before): Mark locals as initialized.
8762 (fix_start_end_in_overlays): Likewise. This function should be
8763 simplified by using pointers-to-pointers, but that's a different
8764 matter.
b1d876f1 8765 (switch_to_buffer_1): Now static.
8f54f30a
PE
8766 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8767 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 8768
a70072c9 8769 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 8770 Fix pointer signedness issue.
edced198
PE
8771 (sys_subshell): Mark local as volatile if checking for lint,
8772 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 8773 (MAXPATHLEN): Define only if needed.
a70072c9 8774
a0977c44
PE
8775 * process.c (serial_open, serial_configure): Move decls from here ...
8776 * systty.h: ... to here, so that they can be checked.
8777
a884fdcc
PE
8778 * fns.c (get_random, seed_random): Move extern decls from here ...
8779 * lisp.h: ... to here, so that they can be checked.
8780
604efe86 8781 * sysdep.c (reset_io): Now static.
b8950c94 8782 (wait_for_termination_signal): Remove; unused.
604efe86 8783
38fc62d9
PE
8784 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8785 (copy_keymap_item, append_key, push_text_char_description):
8786 Now static.
1004a21a 8787 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 8788 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
8789 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8790 (describe_map_tree):
8791 Rename locals to avoid shadowing.
38fc62d9 8792
2f2650da
PE
8793 * keyboard.c: Declare functions static if they are not used elsewhere.
8794 (echo_char, echo_dash, cmd_error, top_level_2):
8795 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
8796 (read_char, kbd_buffer_get_event, make_lispy_position):
8797 (make_lispy_event, make_lispy_movement, apply_modifiers):
8798 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8799 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8800 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 8801 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 8802 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 8803
a053e86c 8804 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
8805 (mark_kboards): Move decl here ...
8806 * alloc.c (mark_kboards): ... from here.
a053e86c 8807
4752793e
PE
8808 * lisp.h (force_auto_save_soon): New decl.
8809
74f10ca7 8810 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
8811 (DEFINE_DUMMY_FUNCTION): New macro.
8812 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8813 Use it.
c03cd23f
PE
8814 (main): Add casts to avoid warnings
8815 if GCC considers string literals to be constants.
74f10ca7 8816
022e70d4
PE
8817 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8818
59d6fe83
PE
8819 * dbusbind.c: Pointer signedness fixes.
8820 (xd_signature, xd_append_arg, xd_initialize):
8821 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8822 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8823 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8824 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8825
78320123
PE
8826 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8827 if GCC considers string literals to be constants.
49cebcca 8828 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 8829
35ac2a97
SM
88302011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8831
fb103ca9
SM
8832 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8833 (print_preprocess, print_object): New macro to fix last change.
8834
35ac2a97
SM
8835 * print.c (print_preprocess): Don't forget font objects.
8836
62973b41
JB
88372011-03-16 Juanma Barranquero <lekktu@gmail.com>
8838
8839 * emacs.c (USAGE3): Doc fixes.
8840
0e48bb22
AS
88412011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8842
8843 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8844 structure.
8845
7684e57b
JB
88462011-03-14 Juanma Barranquero <lekktu@gmail.com>
8847
8848 * lisp.h (VWindow_system, Qfile_name_history):
8849 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8850 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8851 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8852
8853 * w32select.c: Don't #include "keyboard.h".
c96bbc66 8854 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
8855
8856 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8857 * w32console.c (detect_input_pending, read_input_pending)
8858 (encode_terminal_code):
8859 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8860 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8861 (w32_system_caret_y, Qfile_name_history):
8862 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8863 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8864 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8865 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8866 * w32proc.c (Qlocal, report_file_error):
8867 * w32term.c (Vwindow_system, updating_frame):
8868 * w32uniscribe.c (initialized, uniscribe_font_driver):
8869 Remove unneeded extern declarations.
8870
2aa46d6c
CY
88712011-03-14 Chong Yidong <cyd@stupidchicken.com>
8872
c96bbc66 8873 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 8874
cffc6f3b
CY
88752011-03-13 Chong Yidong <cyd@stupidchicken.com>
8876
8877 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8878 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8879 These macros can no longer be used for assignment.
8880
44f230aa
SM
8881 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8882 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
8883 (record_buffer_markers, fetch_buffer_markers): New functions for
8884 recording and fetching special buffer markers.
8885 (set_buffer_internal_1, set_buffer_temp): Use them.
8886
8887 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8888
8889 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8890
8891 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8892 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8893
8894 * xdisp.c (hscroll_window_tree):
8895 (reconsider_clip_changes): Use PT instead of BUF_PT.
8896
d251f04b
EZ
88972011-03-13 Eli Zaretskii <eliz@gnu.org>
8898
8899 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8900 $(EMACS_ROOT)/lib/intprops.h.
8901
f0c77cd1
PE
89022011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8903
3eca4629
PE
8904 Fix more problems found by GCC 4.5.2's static checks.
8905
7c86ee98
PE
8906 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8907 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
8908 (xg_free_frame_widgets): Make it clear that a local variable is
8909 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
8910 (gdk_window_get_screen): Make it clear that this macro is needed
8911 only if USE_GTK_TOOLTIP.
1e5524e7
PE
8912 (int_gtk_range_get_value): New function, which avoids a diagnostic
8913 from gcc -Wbad-function-cast.
8914 (xg_set_toolkit_scroll_bar_thumb): Use it.
8915 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8916 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
8917 (get_utf8_string, xg_get_file_with_chooser):
8918 Rename locals to avoid shadowing.
8919 (create_dialog): Move locals to avoid shadowing.
7c86ee98 8920
41729b81
PE
8921 * xgselect.c (xg_select): Remove unused var.
8922
f0c77cd1
PE
8923 * image.c (four_corners_best): Mark locals as initialized.
8924 (gif_load): Initialize transparent_p to zero (Bug#8238).
8925 Mark another local as initialized.
ec6cf4c6 8926 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 8927
ce0ad53d 8928 * image.c (clear_image_cache): Now static.
d5d5a617 8929 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 8930 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
8931 (x_edge_detection): Remove unnecessary cast that
8932 gcc -Wbad-function-cast diagnoses.
2037898d 8933 (gif_load): Fix pointer signedness.
6ae141d6
PE
8934 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8935 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 8936
33383987 89372011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 8938
d32df629
PE
8939 Improve quality of tests for time stamp overflow.
8940 For example, without this patch (encode-time 0 0 0 1 1
8941 1152921504606846976) returns the obviously-bogus value (-948597
8942 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8943 reports time overflow. See
8944 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
8945 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8946 * editfns.c: Include limits.h and intprops.h.
8947 (TIME_T_MIN, TIME_T_MAX): New macros.
8948 (time_overflow): Move earlier, to before first use.
8949 (hi_time, lo_time): New functions, for an accurate test for
8950 out-of-range times.
8951 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8952 (Fget_internal_run_time): Don't assume time_t fits in int.
8953 (make_time): Use list2 instead of Fcons twice.
8954 (Fdecode_time): More accurate test for out-of-range times.
8955 (check_tm_member): New function.
8956 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
8957 (lisp_time_argument): Don't rely on undefined left-shift and
8958 right-shift behavior when checking for time stamp overflow.
8be6f318 8959
fe31d94c
PE
8960 * editfns.c (time_overflow): New function, refactoring common code.
8961 (Fformat_time_string, Fdecode_time, Fencode_time):
8962 (Fcurrent_time_string): Use it.
8963
8be6f318
PE
8964 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8965 * dired.c (make_time): Move to ...
8966 * editfns.c (make_time): ... here.
8967 * systime.h: Note the move.
8968
09d9db2c 89692011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 8970
126bc0dc
YM
8971 * fringe.c (update_window_fringes): Remove unused variables.
8972
c47cbdfd
YM
8973 * unexmacosx.c (copy_data_segment): Also copy __got section.
8974 (Bug#8223)
8975
7ac80be9
EZ
89762011-03-12 Eli Zaretskii <eliz@gnu.org>
8977
c96bbc66 8978 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
8979 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8980 Constify `char *' arguments and their references according to
8981 prototypes in tparam.h.
8982
ecb0f94d 8983 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 8984
7ac80be9
EZ
8985 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8986 Adapt all references accordingly.
8987
8988 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8989
ef1fd07e
TT
89902011-03-11 Tom Tromey <tromey@redhat.com>
8991
8992 * buffer.c (syms_of_buffer): Remove obsolete comment.
8993
7ef4b50c
EZ
89942011-03-11 Eli Zaretskii <eliz@gnu.org>
8995
8996 * termhooks.h (encode_terminal_code): Declare prototype.
8997
8998 * msdos.c (encode_terminal_code): Don't declare prototype.
8999
9000 * term.c (encode_terminal_code): Now external again, used by
9001 w32console.c and msdos.c.
9002
44f230aa
SM
9003 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9004 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 9005
4b1ec863 90062011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 9007
1714f52b 9008 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 9009
4b1ec863
PE
9010 * fringe.c (update_window_fringes): Mark locals as initialized
9011 (Bug#8227).
9012 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 9013
524c7aa6
PE
9014 * alloc.c (mark_fringe_data): Move decl from here ...
9015 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9016 to check its interface.
9017 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9018
a5c0af81 9019 * fontset.c (free_realized_fontset): Now static.
7519b8cd 9020 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 9021 (fontset_font): Mark local as initialized.
a9a06e0b 9022 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 9023
b4716021
PE
9024 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9025
811e9bac 9026 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 9027 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
9028 (x_own_selection, Fx_disown_selection_internal): Rename locals
9029 to avoid shadowing.
9030 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 9031
7e3ab302
PE
9032 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9033 so that the caller can use some name other than gcpro1.
9034 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
9035 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9036 (Fx_backspace_delete_keys_p):
9037 Use them to avoid shadowing, and rename vars to avoid shadowing.
9038 (x_decode_color, x_set_name, x_window): Now static.
6b437900 9039 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 9040 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
9041 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9042 Remove unused locals.
7e3ab302
PE
9043 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9044 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9045 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9046 macros.
f78faa98 9047
e2b13473
PE
9048 * xterm.h (x_mouse_leave): New decl.
9049
77f23912
PE
9050 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9051 Remove unused functions.
cdf4ba58
PE
9052 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9053 (x_calc_absolute_position): Now static.
7411c686 9054 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 9055 Don't declare local "event" unless it's used.
ed7bf3a5
PE
9056 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9057 unless they are used.
38d0b34a
PE
9058 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9059 (x_fatal_error_signal): Remove; not used.
a6067996
PE
9060 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9061 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9062 (x_error_catcher, x_connection_closed, x_error_handler):
9063 (x_error_quitter, xembed_send_message, x_iconify_frame):
9064 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 9065 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 9066 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 9067
44f230aa
SM
9068 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9069 Rename or move locals to avoid shadowing.
6b463e58 9070 (tty_defined_color, merge_face_heights): Now static.
5967d051 9071 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
9072 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9073 does not deduce is never used uninitialized.
73719eba
PE
9074 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9075 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 9076
426994c3 9077 * terminal.c (store_terminal_param): Now static.
5489860b 9078
032f1620 9079 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 9080 (set_frame_menubar): Remove unused local.
d4323972 9081 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
9082 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9083 since they might point to immutable storage.
281585b0
PE
9084 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9085 since it's unused otherwise.
032f1620 9086
367c19e5 9087 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 9088 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
9089 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9090 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 9091 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
9092 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9093 does not deduce are never used uninitialized.
70739cbe 9094
07b48fa9
PE
9095 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9096
8868a238 9097 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
9098 * window.c (window_loop, size_window):
9099 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 9100
7e5cf297 9101 * window.c (display_buffer): Now static.
d6550a9f
PE
9102 (size_window): Mark variables that gcc -Wuninitialized
9103 does not deduce are never used uninitialized.
a586633d
PE
9104 * window.h (check_all_windows): New decl, to forestall
9105 gcc -Wmissing-prototypes diagnostic.
5b555da1 9106 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 9107
f6095868
PE
9108 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9109 shadowing.
9110 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
9111 Include <limits.h>.
9112 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9113 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
9114 (load_charset_map): Mark variables that gcc -Wuninitialized
9115 does not deduce are never used uninitialized.
53df7c11 9116 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 9117
f38b440c
PE
9118 * coding.c (coding_set_source, coding_set_destination):
9119 Use "else { /* comment */ }" rather than "else /* comment */;"
9120 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
9121 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9122 a block, when the outer 'i' will do.
9123 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9124 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9125 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9126 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9127 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9128 Rename locals to avoid shadowing.
9129 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
9130 * coding.c (emacs_mule_char, encode_invocation_designation):
9131 Now static, since they're not used elsewhere.
413bb2db 9132 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 9133 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
9134 (decode_coding_emacs_mule): Mark variables that gcc
9135 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
9136 (detect_coding_iso_2022): Initialize a local variable that might
9137 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 9138 this initialization is needed. (Bug#8211)
5f58e762
PE
9139 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9140 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9141 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9142 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9143 Remove unused macros.
f38b440c 9144
232b38b9 9145 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 9146 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 9147 * character.c (string_count_byte8): Likewise.
232b38b9 9148
fb90da1b
PE
9149 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9150 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9151
fb93dbc2
PE
9152 * chartab.c (copy_sub_char_table): Now static, since it's not used
9153 elsewhere.
5c156ace
PE
9154 (sub_char_table_ref_and_range, char_table_ref_and_range):
9155 Rename locals to avoid shadowing.
bbcd0949 9156 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 9157
7d3b3862 9158 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 9159 (BIDI_BOB): Remove unused macro.
7d3b3862 9160
6be7d3da
PE
9161 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9162 deduce are never used uninitialized.
c2ed9c8b 9163 * term.c (encode_terminal_code): Likewise.
6be7d3da 9164
75f8807f 9165 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 9166
50938595
PE
9167 * tparam.h: New file.
9168 * term.c, tparam.h: Include it.
9169 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9170 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9171 Move these decls to tparam.h, and make them agree with what
9172 is actually in tparam.c. The previous trick of using incompatible
9173 decls in different modules does not conform to the C standard.
9174 All callers of tparam changed to use tparam's actual API.
9175 * tparam.c (tparam1, tparam, tgoto):
9176 Use const pointers where appropriate.
9177
fbceeba2
PE
9178 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9179 * cm.h (struct cm): Likewise.
9180 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9181 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9182 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9183 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9184 (turn_on_face, init_tty): Likewise.
9185 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 9186
7f3f1250
PE
9187 * term.c (term_mouse_position): Rename local to avoid shadowing.
9188
e6ca6543
PE
9189 * alloc.c (mark_ttys): Move decl from here ...
9190 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9191
c40f8d15
AS
91922011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9193
9194 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9195
cfe0661d
JB
91962011-03-09 Juanma Barranquero <lekktu@gmail.com>
9197
9198 * search.c (compile_pattern_1): Remove argument regp, unused since
9199 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9200 (compile_pattern): Don't pass it.
9201
0afb4571
J
92022011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9203
9204 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9205 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9206 for ! HAVE_GTK3.
9207 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9208
9209 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9210
9211 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9212 gdk_window_get_screen, gdk_window_get_geometry,
9213 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9214 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9215 (xg_get_pixbuf_from_pixmap): New function.
9216 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9217 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9218 Call xg_get_pixbuf_from_pixmap instead of
9219 gdk_pixbuf_get_from_drawable.
9220 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9221 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9222 (xg_check_special_colors): Use GtkStyleContext and its functions
9223 for HAVE_GTK3.
9224 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9225 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9226 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
9227 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9228 Call gtk_widget_get_preferred_size.
0afb4571
J
9229 (xg_frame_resized): gdk_window_get_geometry only takes 5
9230 parameters.
44f230aa
SM
9231 (xg_win_to_widget, xg_event_is_for_menubar):
9232 Call gdk_x11_window_lookup_for_display.
0afb4571
J
9233 (xg_set_widget_bg): New function.
9234 (delete_cb): New function.
895009e1 9235 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 9236 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
9237 (xg_set_background_color): Call xg_set_widget_bg.
9238 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9239 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9240 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9241 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9242 if ! HAVE_GTK3.
9243 (update_frame_tool_bar): Call gtk_widget_hide.
9244 (xg_initialize): Use GDK_KEY_g.
9245
9246 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9247 if ! HAVE_GTK3
9248 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9249
9250 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9251 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9252 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9253
1c2cc4ef
JB
92542011-03-08 Juanma Barranquero <lekktu@gmail.com>
9255
9256 * w32xfns.c (select_palette): Check success of RealizePalette against
9257 GDI_ERROR, not zero.
9258
33383987 9259See ChangeLog.11 for earlier changes.
aac0c6e3
MR
9260
9261;; Local Variables:
9262;; coding: utf-8
aac0c6e3
MR
9263;; End:
9264
acaf905b 9265 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
9266
9267 This file is part of GNU Emacs.
9268
9269 GNU Emacs is free software: you can redistribute it and/or modify
9270 it under the terms of the GNU General Public License as published by
9271 the Free Software Foundation, either version 3 of the License, or
9272 (at your option) any later version.
9273
9274 GNU Emacs is distributed in the hope that it will be useful,
9275 but WITHOUT ANY WARRANTY; without even the implied warranty of
9276 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9277 GNU General Public License for more details.
9278
9279 You should have received a copy of the GNU General Public License
9280 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.