Comment why gc_aset can be triggered during GC.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
8834c57a
PE
12012-08-03 Paul Eggert <eggert@cs.ucla.edu>
2
98c6f1e3
PE
3 Remove unnecessary casts involving pointers.
4 These casts are no longer needed now that we assume C89 or later,
5 since they involve casting to or from void *.
6 * alloc.c (make_pure_string, make_pure_c_string, pure_cons)
7 (make_pure_float, make_pure_vector):
8 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP):
9 * macros.c (Fstart_kbd_macro):
10 * menu.c (find_and_return_menu_selection):
11 * minibuf.c (read_minibuf_noninteractive):
12 * sysdep.c (closedir):
13 * xdisp.c (x_produce_glyphs):
14 * xfaces.c (compare_fonts_by_sort_order):
15 * xfns.c (x_real_positions, select_visual):
16 * xselect.c (x_stop_queuing_selection_requests)
17 (x_get_window_property, x_get_window_property_as_lisp_data):
18 * xterm.c (x_set_frame_alpha, x_find_modifier_meanings):
19 Remove unnecessary pointer casts.
20 * alloc.c (record_xmalloc): New function.
21 * lisp.h (record_xmalloc): New decl.
22 (SAFE_ALLOCA): Now takes just one arg -- the size -- and acts
23 more like a function. This is because the pointer cast is not
24 needed. All uses changed.
25 * print.c (print_string, print_error_message): Avoid length recalc.
26
8834c57a
PE
27 Improve fix for macroexp crash with debugging (Bug#12118).
28 * lisp.h (ASET) [ENABLE_CHECKING]: Pay attention to
29 ARRAY_MARK_FLAG when checking subscripts, because ASET is
30 not supposed to be invoked from the garbage collector.
31 See Andreas Schwab in <http://bugs.gnu.org/12118#25>.
32 (gc_aset): New function, which is like ASET but can be
33 used in the garbage collector.
34 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
35 (set_hash_index): Use it instead of ASET.
36
6dad7178
EZ
372012-08-03 Eli Zaretskii <eliz@gnu.org>
38
39 Support symlinks on latest versions of MS-Windows.
40 * w32.c: Include winioctl.h and aclapi.h.
41 (is_symlink, chase_symlinks, enable_privilege, restore_privilege)
42 (revert_to_self): Forward declarations of static functions.
43 <static BOOL g_b_init_get_security_info>:
44 <g_b_init_create_symbolic_link>: New static flags.
45 (globals_of_w32): Initialize them to zero.
46 (GetSecurityInfo_Proc, CreateSymbolicLink_Proc): New typedefs.
47 (map_w32_filename): Improve commentary. Simplify switch.
48 (SYMBOLIC_LINK_FLAG_DIRECTORY): Define if not defined in system
49 headers (most versions of MinGW w32api don't).
50 (get_security_info, create_symbolic_link)
51 (get_file_security_desc_by_handle, is_symlink, chase_symlinks):
52 New functions.
53 (sys_access, sys_chmod): Call 'chase_symlinks' to resolve symlinks
54 in the argument file name.
55 (sys_access): Call unc_volume_file_attributes only if
56 GetFileAttributes fails with network-related error codes.
57 (sys_rename): Diagnose renaming of a symlink when the user doesn't
58 have the required privileges.
59 (get_file_security_desc_by_name): Renamed from
60 get_file_security_desc.
61 (stat_worker): New function, with most of the guts of 'stat', and
62 with addition of handling of symlinks and support for 'lstat'. If
63 possible, get file's attributes and security information by
64 handle, not by name. Produce S_IFLNK bit for symlinks, when
65 called from 'lstat'.
66 (stat, lstat): New functions, call 'stat_worker'.
67 (symlink, readlink, careadlinkat): Rewritten to create and resolve
68 symlinks when the underlying filesystem supports them.
69
f162bcc3
PE
702012-08-02 Paul Eggert <eggert@cs.ucla.edu>
71
79ea6c20
PE
72 Fix macroexp crash on Windows with debugging (Bug#12118).
73 * lisp.h (ASET) [ENABLE_CHECKING]: Ignore ARRAY_MARK_FLAG when
74 checking subscripts; problem introduced with the recent
75 "ASET (a, i, v)" rather than "AREF (a, i) = v" patch.
76 (ARRAY_MARK_FLAG): Now a macro as well as a constant,
77 since it's used in non-static inline functions now.
78
c0ce93fd
PE
79 * xfaces.c (face_at_buffer_position, face_for_overlay_string):
80 Don't assume buffer size fits in 'int'. Remove unused local.
c71f5156 81
f162bcc3
PE
82 Use C99-style 'extern inline' if available.
83 * buffer.h (BUFFER_INLINE):
84 * category.h (CATEGORY_INLINE):
85 * character.h (CHARACTER_INLINE):
86 * charset.h (CHARSET_INLINE):
87 * composite.h (COMPOSITE_INLINE):
88 * dispextern.h (DISPEXTERN_INLINE):
89 * lisp.h (LISP_INLINE):
90 * systime.h (SYSTIME_INLINE):
91 New macro, replacing 'static inline' in this header.
92 * buffer.h, category.h, character.h, charset.h, composite.h:
93 * dispextern.h, lisp.h, systime.h:
94 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
95 * alloc.c (LISP_INLINE):
96 * buffer.c (BUFFER_INLINE):
97 * category.c (CATEGORY_INLINE):
98 * character.c (CHARACTER_INLINE):
99 * charset.c (CHARSET_INLINE):
100 * composite.c (COMPOSITE_INLINE):
101 * dispnew.c (DISPEXTERN_INLINE):
102 * sysdep.c (SYSTIME_INLINE):
103 Define to EXTERN_INLINE, so that the corresponding functions
104 are compiled into code.
105 * conf_post.h (INLINE, EXTERN_INLINE, INLINE_HEADER_BEGIN)
106 (INLINE_HEADER_END): New macros.
107 * lisp.h (PSEUDOVECTOR_FLAG): Now a macro as well as a constant,
108 since it's used in non-static inline functions now.
a8333d03 109 (VALMASK) [!USE_LSB_TAG]: Likewise.
f162bcc3 110
837b365b
GM
1112012-08-02 Glenn Morris <rgm@gnu.org>
112
d66b744d
GM
113 * s/: Remove empty directory.
114
837b365b
GM
115 * s/ms-w32.h: Move to ../nt/inc.
116 * makefile.w32-in (TAGS, TAGS-gmake, MS_W32_H):
117 Update for new ms-w32.h location.
118
13294f95
PE
1192012-08-02 Paul Eggert <eggert@cs.ucla.edu>
120
121 Port to Solaris 8.
122 * syswait.h (WRETCODE): Remove, consistently with ../configure.ac.
123
90df0db3
GM
1242012-08-02 Glenn Morris <rgm@gnu.org>
125
126 * nsterm.m (ns_exec_path, ns_load_path): Use SEPCHAR rather than
127 hard-coding the path separator.
128
4939150c
PE
1292012-08-01 Paul Eggert <eggert@cs.ucla.edu>
130
131 Use "ASET (a, i, v)" rather than "AREF (a, i) = v".
132 This how ASET and AREF are supposed to work, and makes
133 it easier to think about future improvements. See
134 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00026.html>.
135 * charset.h (set_charset_attr): New function.
136 All lvalue-style uses of CHARSET_DECODER etc. changed to use it.
137 * lisp.h (ASET): Rewrite so as not to use AREF in an lvalue style.
138 (aref_addr): New function. All uses of &AREF(...) changed.
139 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
140 (set_hash_index): New functions. All lvalue-style uses of
141 HASH_KEY etc. changed.
142 * keyboard.c (set_prop): New function. All lvalue-style uses
143 of PROP changed.
144
947b2afd
AA
1452012-08-01 Alp Aker <alp.tekin.aker@gmail.com>
146
147 * nsterm.m (ns_set_vertical_scroll_bar, ns_redeem_scroll_bar)
148 (EmacsWindow-accessibilityAttributeValue, EmacsScroller-initFrame:)
149 (EmacsScroller-dealloc): Adjust to use WVAR. (Bug#12114)
150 * nsfns.m (ns_set_name_as_filename): Likewise.
151 * nsmenu.m (ns_update_menubar): Likewise.
152 * nsselect.m (symbol_to_nsstring): Adjust to use SVAR.
153
4f5d0325
EZ
1542012-08-01 Eli Zaretskii <eliz@gnu.org>
155
2008beae
EZ
156 * .gdbinit (xcar, xcdr, xlist, xwindow, nextcons, xprintsym):
157 Adapt to latest changes in field names of the corresponding Lisp
288479f6 158 objects.
2008beae 159
4f5d0325
EZ
160 * xdisp.c (try_window_id): Use WVAR in IF_DEBUG code.
161
fe3cc771
GM
1622012-08-01 Glenn Morris <rgm@gnu.org>
163
164 * s/msdos.h: Remove file.
165 * conf_post.h [MSDOS]: New section, moved from s/msdos.h.
166 * Makefile.in (S_FILE): Remove.
167 (config_h): Remove S_FILE.
168
c90acc54
JB
1692012-08-01 Juanma Barranquero <lekktu@gmail.com>
170
171 * s/ms-w32.h (DEVICE_SEP, IS_DIRECTORY_SEP, IS_ANY_SEP):
172 Remove; moved to nt/config.nt.
173
d8a05828
DA
1742012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
175
176 Use INTERNAL_FIELD for conses and overlays.
177 * lisp.h (struct Lisp_Cons): Use INTERNAL_FIELD.
178 Remove obsolete comment.
179 (MVAR): New macro.
180 (struct Lisp_Overlay): Use INTERNAL_FIELD.
181 * alloc.c, buffer.c, buffer.h, fns.c: Adjust users.
182
8271d590
DA
1832012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
184
185 Use INTERNAL_FIELD for symbols.
186 * lisp.h (SVAR): New macro. Adjust users.
187 * alloc.c, bytecode.c, cmds.c, data.c, doc.c, eval.c:
188 * fns.c, keyboard.c, lread.c, xterm.c: Users changed.
189
3193acd2
DA
1902012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
191
192 Use INTERNAL_FIELD for processes.
193 * process.h (PVAR): New macro. Adjust style.
194 (struct Lisp_Process): Change Lisp_Object members to INTERNAL_FIELD.
195 * print.c, process.c, sysdep.c, w32.c, xdisp.c: Users changed.
196
3a45383a
DA
1972012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
198
199 Use INTERNAL_FIELD for windows.
200 * window.h (WVAR): New macro.
201 (struct window): Change Lisp_Object members to INTERNAL_FIELD.
202 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
203 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
204 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, nsterm.m, print.c:
205 * textprop.c, w32fns.c, w32menu.c, w32term.c, window.c, xdisp.c:
206 * xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
207
c1dbc63c
PE
2082012-08-01 Paul Eggert <eggert@cs.ucla.edu>
209
210 * coding.h (CODING_ATTR_FLUSHING): Remove; unused and wouldn't work.
211
5c0c0e8a
GM
2122012-08-01 Glenn Morris <rgm@gnu.org>
213
214 * lisp.h (IS_DIRECTORY_SEP, IS_DEVICE_SEP, IS_ANY_SEP):
215 Move to configure.ac.
216
552a99b4
JB
2172012-08-01 Juanma Barranquero <lekktu@gmail.com>
218
219 * makefile.w32-in (CONFIG_H): Update dependencies.
220 (CONF_POST_H): New macro.
221
222 * s/ms-w32.h (SEPCHAR, NULL_DEVICE): Remove; moved to nt/config.nt.
223
8d8e2dfe
GM
2242012-07-31 Glenn Morris <rgm@gnu.org>
225
bc96620a
GM
226 * Makefile.in (S_FILE): No longer set by configure.
227
476b1b2d
GM
228 * conf_post.h (config_opsysfile): Move earlier, so that WINDOWSNT
229 is available.
230 (alloca.h) [WINDOWSNT]: Don't include it on MS Windows.
231
b2c7a106
GM
232 * process.h (NULL_DEVICE):
233 * emacs.c (SEPCHAR):
234 * editfns.c (USER_FULL_NAME): Let configure set them.
235
d53d062a
GM
236 * s/README, s/template.h: Remove files.
237
4515017f
GM
238 * conf_post.h [HPUX]: Undefine HAVE_RANDOM and HAVE_RINT.
239
8d8e2dfe
GM
240 * conf_post.h (AMPERSAND_FULL_NAME, subprocesses):
241 Move to configure.ac.
242
5b20b3cc
EZ
2432012-07-31 Eli Zaretskii <eliz@gnu.org>
244
1e0afd9a
EZ
245 * .gdbinit (xframe): Adapt to introduction of FVAR and the
246 resulting renaming of 'struct frame' members.
247
5b20b3cc
EZ
248 * w32menu.c (w32_menu_show): Revert bogus introduction of FVAR.
249
250 * fontset.c (dump_fontset): Fix compilation with ENABLE_CHECKING
251 after introduction of FVAR.
252
f1310128
JD
2532012-07-31 Jan Djärv <jan.h.d@swipnet.se>
254
79e721e0
JD
255 * nsmenu.m (update_frame_tool_bar): Change key from NSObject* to id.
256
257 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Use drawInRect
258 instead of compositeToPoint.
259 (applicationShouldTerminate): Pass NS String literal to NSRunAlertPanel.
260
8d7c7eed 261 * nsfns.m, nsmenu.m, nsterm.m: Adopt to struct frame/FVAR changes.
f1310128 262
e34f7f79
DA
2632012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
264
265 Generalize INTERNAL_FIELD between buffers, keyboards and frames.
266 * lisp.h (INTERNAL_FIELD): New macro.
267 * buffer.h (BUFFER_INTERNAL_FIELD): Removed.
268 (BVAR): Change to use INTERNAL_FIELD.
269 * keyboard.h (KBOARD_INTERNAL_FIELD): Likewise.
270 (KVAR): Change to use INTERNAL_FIELD.
271 * frame.h (FVAR): New macro.
272 (struct frame): Use INTERNAL_FIELD for all Lisp_Object fields.
3a45383a
DA
273 * alloc.c, buffer.c, data.c, dispnew.c, dosfns.c, eval.c, frame.c:
274 * fringe.c, gtkutil.c, minibuf.c, nsfns.m, nsterm.m, print.c:
275 * term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
e34f7f79
DA
276 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
277
c09bfb2f
DA
2782012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
279
280 Miscellaneous fixes for non-default X toolkits.
281 * xfns.c (Fx_file_dialog): Change to SSDATA to avoid warnings.
282 * xterm.c (x_frame_of_widget): Remove redundant prototype.
283 Move under #ifdef USE_LUCID.
284 (x_create_toolkit_scroll_bar): Adjust scroll_bar_name
285 definition and usage to avoid warnings.
286
14c114ae
JD
2872012-07-31 Jan Djärv <jan.h.d@swipnet.se>
288
289 * nsterm.m (openFiles): Fix previous checkin.
290
3bd21e82
PE
2912012-07-31 Paul Eggert <eggert@cs.ucla.edu>
292
293 * indent.c (compute_motion): Remove unused local.
294
c1529ded
GM
2952012-07-31 Glenn Morris <rgm@gnu.org>
296
400d5621
GM
297 * s/usg5-4-common.h (wait3, WRETCODE): Let configure set them.
298
268e2432
GM
299 * conf_post.h [USG5_4]:
300 Move remaining contents of s/usg5-4-common.h here.
301 * s/usg5-4-common.h: Remove file.
302
7552f3ee
GM
303 * conf_post.h [IRIX6_5]: Move remaining contents of s/irix6-5.h here.
304 * s/irix6-5.h: Remove file.
305
6a381852
GM
306 * conf_post.h [DARWIN_OS]: Move remaining contents of s/darwin.h here.
307 * s/darwin.h: Remove file.
308
c1529ded
GM
309 * conf_post.h [HPUX]: Move random, srandom here from s/hpux10-20.h.
310 * s/hpux10-20.h: Remove file, which is now empty.
311
b429a4ee
GM
3122012-07-30 Glenn Morris <rgm@gnu.org>
313
314 * conf_post.h: New, split from configure.ac's AH_BOTTOM.
315 * Makefile.in (config_h): Add conf_post.h.
316 * makefile.w32-in (CONFIG_H): Add conf_post.h.
317
adff3182
JD
3182012-07-30 Jan Djärv <jan.h.d@swipnet.se>
319
320 * nsterm.m (ns_do_open_file): New variable.
b9031d69 321 (ns_term_init): Set ns_do_open_file to YES after run returns.
adff3182
JD
322 (openFile, openTempFile, openFileWithoutUI, openFiles): Open
323 files only if ns_do_open_file.
324
c32af1e4
PE
3252012-07-30 Paul Eggert <eggert@cs.ucla.edu>
326
7393bcbb
PE
327 * lisp.h (SWITCH_ENUM_CAST): Remove. All uses removed.
328 This no-op macro hasn't been needed for many years.
329 * src/regex.c (SWITCH_ENUM_CAST) [!emacs]: Likewise.
330
c32af1e4
PE
331 Export DIRECTORY_SEP, TYPEMASK, VALMASK to GDB.
332 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]: Add lsb_bits.
333 * lisp.h (enum lsb_bits) [USE_LSB_TAG]: New enum, for
334 gdb_make_enums_visible.
335 (TYPEMASK, VALMASK) [USE_LSB_TAGS]: Now enum constants, not macros.
336 (DIRECTORY_SEP): Now a constant, not a macro.
337
302fc036
EZ
3382012-07-30 Eli Zaretskii <eliz@gnu.org>
339
340 * w32fns.c (w32_wnd_proc): Pass w32_keyboard_codepage to
341 w32_kbd_patch_key as the 2nd arg. (Bug#12082)
342
343 * w32term.c <w32_keyboard_codepage>: Renamed from
344 keyboard_codepage and now external. All users changed.
345
346 * w32term.h: Add declaration of w32_keyboard_codepage.
347
348 * w32inevt.c (w32_kbd_patch_key): Accept an additional argument --
349 the codepage to translate keys to Unicode. If this argument is
350 -1, use the value returned by GetConsoleCP. All callers changed.
351
88fb40b4
PE
3522012-07-30 Paul Eggert <eggert@cs.ucla.edu>
353
0aee6912
PE
354 Update .PHONY listings in makefiles.
355 * Makefile.in (.PHONY): Add all, mostlyclean, clean,
356 bootstrap-clean, distclean, maintainer-clean, versioclean,
357 extraclean, frc.
358
88fb40b4
PE
359 * lisp.h (STRING_BYTES_BOUND): Cast entire result to ptrdiff_t.
360 This is a bit clearer. Fix some commentary typos.
361
0a763bd1
GM
3622012-07-30 Glenn Morris <rgm@gnu.org>
363
32bac6d6
GM
364 * s/netbsd.h: Let configure include signal.h if needed.
365 Remove file, which is now empty.
366
b65e7c46
GM
367 * s/usg5-4-common.h (_longjmp, _setjmp, TIOCSIGSEND):
368 Let configure set them.
369 * s/irix6-5.h (_longjmp, _setjmp, TIOCSIGSEND):
370 No more need to undefine.
0a763bd1 371
169304bd
AS
3722012-07-30 Andreas Schwab <schwab@linux-m68k.org>
373
374 * keymap.c (Fkey_description): Don't remove 0x80 bit from
375 non-single-byte char when adding meta modifier. (Bug#12090)
376
6cd7a139
DA
3772012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
378
379 Convert safe_call to use variable number of arguments.
380 * xdisp.c (safe_call): Convert to use varargs. Adjust users.
381 (safe_call2): Fix comment.
382 * lisp.h (safe_call): Adjust prototype.
383 * coding.c (encode_coding_object): Change to use safe_call2.
384 * xfaces.c (merge_face_heights): Change to use safe_call1.
385
d34d6ffc
GM
3862012-07-30 Glenn Morris <rgm@gnu.org>
387
7b8a48e4 388 * s/aix4-2.h (sigmask): No need to undefine it, since syssignal.h
227f5bd0 389 does that unconditionally. Remove file, which is now empty.
7b8a48e4 390
d34d6ffc
GM
391 * s/freebsd.h, s/gnu-linux.h, s/sol2-6.h, s/unixware.h:
392 Remove empty files.
393
03a660a6
PE
3942012-07-30 Paul Eggert <eggert@cs.ucla.edu>
395
396 Export to GDB most of lisp.h's remaining object-like macros.
397 * lisp.h (min, max): Move earlier, because they're used earlier now.
398 (INTMASK, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK)
399 (CHAR_TABLE_STANDARD_SLOTS, CHARTAB_SIZE_BITS_0)
400 (CHARTAB_SIZE_BITS_1, CHARTAB_SIZE_BITS_2, CHARTAB_SIZE_BITS_3)
401 (DEFAULT_HASH_SIZE, COMPILED_ARGLIST, COMPILED_BYTECODE)
402 (COMPILED_CONSTANTS, COMPILED_STACK_DEPTH, COMPILED_DOC_STRING)
403 (COMPILED_INTERACTIVE, CHAR_ALT, CHAR_SUPER, CHAR_HYPER, CHAR_SHIFT)
404 (CHAR_CTL, CHAR_META, CHAR_MODIFIER_MASK, CHARACTERBITS)
405 (MANY, UNEVALLED, FLOAT_TO_STRING_BUFSIZE, MAX_ALLOCA):
406 Now constants, for GDB. They need not be macros.
407 (MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM, STRING_BYTES_BOUND):
408 Now constants, for GDB, as well as macros, for static initializers.
409 (CHAR_TABLE_STANDARD_SLOTS, CHAR_TABLE_EXTRA_SLOTS):
410 Move to after the definition of struct Lisp_Char_Table,
411 since the former now needs that type defined.
412 (enum CHARTAB_SIZE_BITS, enum CHAR_TABLE_STANDARD_SLOTS)
413 (enum DEFAULT_HASH_SIZE, enum Lisp_Compiled, enum char_bits)
414 (enum maxargs, enum FLOAT_TO_STRING_BUFSIZE, enum MAX_ALLOCA):
415 New enums, for gdb_make_enums_visible.
416 (GLYPH_MODE_LINE_FACE): Remove; unused.
88fb40b4 417 * alloc.c (STRING_BYTES_MAX): Now a constant, not a macro.
03a660a6
PE
418 (gdb_make_enums_visible): Add enum CHARTAB_SIZE_BITS, enum
419 CHAR_TABLE_STANDARD_SLOTS, enum char_bits, enum DEFAULT_HASH_SIZE,
420 enum FLOAT_TO_STRING_BUFSIZE, enum Lisp_Bits, enum Lisp_Compiled,
421 enum maxargs, enum MAX_ALLOCA.
422 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): Remove.
423 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Remove;
424 no longer needed, now that they are done in lisp.h.
425
e499d0ee
DA
4262012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
427
428 Cleanup string bytes checking.
429 * alloc.c (GC_STRING_BYTES, CHECK_STRING_BYTES): Remove. Convert
430 all users to STRING_BYTES or string_bytes if GC_CHECK_STRING_BYTES.
431 (check_string_bytes): Define to empty if not GC_CHECK_STRING_BYTES.
432 (check_sblock, compact_small_strings): Simplify.
433
d5040d2d
PE
4342012-07-29 Paul Eggert <eggert@cs.ucla.edu>
435
436 * lisp.h (LISP_INT_TAG, LISP_INT1_TAG, LISP_STRING_TAG): Remove.
437 These macros are confusing and no longer need to be defined, as
438 the enum values now suffice. All uses replaced with definiens.
439 (Lisp_Int1, Lisp_String): Define directly; this is clearer.
440
7f259ae6
JB
4412012-07-29 Juanma Barranquero <lekktu@gmail.com>
442
443 * makefile.w32-in (LISP_H, $(BLD)/emacs.$(O), $(BLD)/w32inevt.$(O))
444 ($(BLD)/w32console.$(O)): Update dependencies.
445
7e63e0c3
DA
4462012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
447
448 Remove HIDE_LISP_IMPLEMENTATION and cleanup cons free list check.
449 * lisp.h (HIDE_LISP_IMPLEMENTATION): Remove as useless for a long
450 time. Adjust users.
451 (CHECK_CONS_LIST): Remove. Convert all users to check_cons_list.
452
ffd817eb
JD
4532012-07-29 Jan Djärv <jan.h.d@swipnet.se>
454
455 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
456 setting sitelisp (Bug#12010).
457
417a7a0e
EZ
4582012-07-29 Eli Zaretskii <eliz@gnu.org>
459
460 * w32heap.h (OS_9X): Renamed from OS_WINDOWS_95.
461
462 * w32heap.c (cache_system_info):
463 * w32.c (sys_rename):
464 * w32proc.c (find_child_console, sys_kill): All users changed.
465
387d4d92
PE
4662012-07-29 Paul Eggert <eggert@cs.ucla.edu>
467
468 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
469
55a6cca6
EZ
4702012-07-29 Eli Zaretskii <eliz@gnu.org>
471
472 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
473
dbcf001c
DA
4742012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
475
476 Cleanup statistics calculation in Fgarbage_collect.
477 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start. Fix
478 zombies percentage calculation. Simplify elapsed time calculation.
479
e2688e4a
DA
4802012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
481
482 Generalize marker debugging code under MARKER_DEBUG and use eassert.
483 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
484 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
485 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
486 (replace_range, replace_range_2, del_range_2): Change to eassert.
487 * marker.c (byte_char_debug_check): Adjust style.
488
b46a6a83
PE
4892012-07-29 Paul Eggert <eggert@cs.ucla.edu>
490
491 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
492 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
493 long-ago-commented-out code that talks about "WIN32".
494 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
495 All uses changed.
496
e32a5799
PE
4972012-07-28 Paul Eggert <eggert@cs.ucla.edu>
498
499 Use Gnulib stdalign module (Bug#9772, Bug#9960).
500 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
501 Simplify by using alignof.
502 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
503 * lisp.h: Include <stdalign.h>.
504 (GCALIGNMENT): New macro and constant.
505 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
506 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
507 (stdalign): New macro, if not already defined.
508
df81cd29
EZ
5092012-07-28 Eli Zaretskii <eliz@gnu.org>
510
01bd1b0d
EZ
511 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
512 * w32inevt.c: Include w32inevt.h.
513 (w32_read_console_input): New inline function, calls either
514 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
515 w32_console_unicode_input.
516 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
517 (w32_kbd_patch_key, key_event): Use the codepage returned by
518 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
519 (key_event): use uChar.UnicodeChar only if
520 w32_console_unicode_input is non-zero.
521
522 * w32console.c: Include w32heap.h.
523 <w32_console_unicode_input>: New global variable.
524 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
525 family of Windows, zero otherwise.
526
527 * w32inevt.h: Declare w32_console_unicode_input.
528
df81cd29
EZ
529 * xdisp.c (init_iterator): Don't reference tip_frame in a build
530 --without-x. (Bug#11742)
531
c20fdd9e
PE
5322012-07-27 Paul Eggert <eggert@cs.ucla.edu>
533
534 Adjust GDB to reflect pvec_type changes (Bug#12036).
535 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
536 2012-07-04 changes to pseudovector representation. Problem
537 reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
538
32770973 5392012-07-27 Michael Albinus <michael.albinus@gmx.de>
e518bc71
MA
540
541 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
542 bus address.
543 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
544
3438fe21
EZ
5452012-07-27 Eli Zaretskii <eliz@gnu.org>
546
bcfbc9de
EZ
547 * alloc.c (listn): Fix the order the arguments are consed onto the
548 list.
549
3438fe21
EZ
550 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
551 enumeration constants, as PURE and HEAP are too general, and clash
552 with other headers and sources, such as gmalloc.c and the
553 MS-Windows system headers. All users changed.
554
eeaea515
DA
5552012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
556
557 Revert last save_excursion_save and save_excursion_restore changes.
558 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
559 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
560
073c88c2
DA
5612012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
562
563 Fix recently-introduced typos in Windows port.
564 Reported by Martin Rudalics <rudalics@gmx.at>.
565 * w32.c (init_environment): Replace comma with semicolon.
eeaea515 566 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
073c88c2 567
4706125e
PE
5682012-07-27 Paul Eggert <eggert@cs.ucla.edu>
569
570 Improve GDB symbol export (Bug#12036).
571 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
572 arms of an 'if', not using conditional expressions; otherwise GDB
573 complains about the types in the unevaluated arm when the argument
574 is an integer literal.
575 (xgetint): Simplify expression.
576 * alloc.c (gdb_make_enums_visible): New constant. This ports to
577 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
578 Zaretskii in <http://bugs.gnu.org/12036#13>.
579 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
580 needed now that we have gdb_make_enums_visible.
581 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
582 (enum enum_USE_LSB_TAG):
583 New enum types, packaging up enums that need to be exported to GDB.
584
694b6c97
DA
5852012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
586
587 Utility function to make a list from specified amount of objects.
588 * lisp.h (enum constype): New datatype.
589 (listn): New prototype.
590 * alloc.c (listn): New function.
591 (Fmemory_use_count, syms_of_alloc): Use it.
592 * buffer.c (syms_of_buffer): Likewise.
593 * callint.c (syms_of_callint): Likewise.
594 * charset.c (define_charset_internal): Likewise.
595 * coding.c (syms_of_coding): Likewise.
596 * keymap.c (syms_of_keymap): Likewise.
597 * search.c (syms_of_search): Likewise.
598 * syntax.c (syms_of_syntax): Likewise.
599 * w32.c (init_environment): Likewise.
600 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
601 * xdisp.c (syms_of_xdisp): Likewise.
602 * xfns.c (syms_of_xfns): Likewise.
603
6195f384
DA
6042012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
605
606 Fast save_excursion_save and save_excursion_restore.
607 * lisp.h (struct Lisp_Excursion): New data type.
608 (PVEC_EXCURSION): New pseudovector type.
609 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
610 to deal with it. Adjust comments.
611 (init_marker, attach_marker): New prototype.
612 (unchain_marker): Adjust prototype.
613 * marker.c (attach_marker): Change to global.
614 (init_marker): New function.
615 * alloc.c (Fmake_marker, build_marker): Use it.
616 (build_marker): More easserts.
617 (mark_object): Handle struct Lisp_Excursion.
618 * editfns.c (save_excursion_save, save_excursion_restore):
619 Reimplement to use struct Lisp_Excursion. Add comments.
620
5eceb8fb
PE
6212012-07-26 Paul Eggert <eggert@cs.ucla.edu>
622
623 Fix export of symbols to GDB (Bug#12036).
624 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
625 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
626 emacs.c, as this is a more-suitable home. Had this been done earlier
627 the fix for 12036 would have avoided some of the problems noted in
628 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
629 would have been more obvious.
562157c8
PE
630 * emacs.c: Do not include <verify.h>; no longer needed.
631 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
5eceb8fb
PE
632 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
633 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
634 Remove; now done in lisp.h.
635 * lisp.h (PUBLISH_TO_GDB): New macro.
636 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
637 (DATA_SEG_BITS): Use it.
638 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
639 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
640 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
641 not be usable in #if. This simplifies things.
642
d6749401
JB
6432012-07-26 Juanma Barranquero <lekktu@gmail.com>
644
645 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
646
1781b9e9
PE
6472012-07-26 Paul Eggert <eggert@cs.ucla.edu>
648
d89518db 649 Simplify export of symbols to GDB (Bug#12036).
1781b9e9
PE
650 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
651 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
652 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
653 Adjust to changes in lisp.h and emacs.c, by using
654 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
655 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
656 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
657 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
658 instead of gdb_valbits.
659 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
660 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
661 instead of gdb_array_mark_flag.
662 (xboolvector): Get size from $->size, not $->header.size.
663 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
664 (xreload, hook-run, hookpost-run): Remove.
665 * emacs.c: Include <verify.h>.
666 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
667 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
668 Remove.
669 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
670 (gdb_USE_LSB_TAG): New enum constants.
671 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
672 Also define these as enum constants, so they're visible to GDB.
673 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
674 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
675 as constants, so they're visible to GDB.
676 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
677 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
678 Now enum constants, not macros, so they're visible to GDB.
679 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
680 more convenient now. All uses changed.
681 (VALMASK) [USE_LSB_TAG]: Also define in this case.
682 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
683
3628596a
DA
6842012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
685
686 Explicitly free restriction data that are not needed anymore.
687 * editfns.c (save_restriction_restore): Free restriction data.
688
7abaf5cc
SM
6892012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
690
691 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
692 add argument, tune behavior, and adjust all callers.
693
71f88e00
PE
6942012-07-25 Paul Eggert <eggert@cs.ucla.edu>
695
696 Use typedef for EMACS_INT, EMACS_UINT.
697 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
698 than macros. This simplifies debugging in the usual case, since
699 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
700 and it allows expressions involving EMACS_INT casts.
701 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
702
57ec3034
JD
7032012-07-25 Jan Djärv <jan.h.d@swipnet.se>
704
705 * nsterm.m (ns_read_socket): Return early if there is a modal
706 window (Bug#12043).
707
8137e7b3
MR
7082012-07-25 Martin Rudalics <rudalics@gmx.at>
709
710 * frame.c (Fredirect_frame_focus): In doc-string don't mention
711 that FOCUS-FRAME can be omitted.
712
04e9897c
DA
7132012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
714
715 Adjust buffer text indirection counters at the end of Fkill_buffer.
716 * buffer.c (Fkill_buffer): Adjust indirection counters when the
717 buffer is definitely dead. This should really fix an issue reported
718 by Christoph Scholtes again. (Bug#12007).
719 (init_buffer_once): Initialize indirection counters of
720 buffer_defaults and buffer_local_symbols (for sanity and safety).
721
8a0484e1
EZ
7222012-07-24 Eli Zaretskii <eliz@gnu.org>
723
724 * xdisp.c (init_iterator): Don't compute dimensions of truncation
725 and continuation glyphs on tooltip frames, leave them at zero.
726 Avoids continued lines in tooltips. (Bug#11832)
727
fa691a83
DA
7282012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
729
730 Simplify copy_overlay.
04e9897c 731 * buffer.c (copy_overlay): Simplify. Use build_marker.
fa691a83
DA
732 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
733
436bc8e0
EZ
7342012-07-23 Eli Zaretskii <eliz@gnu.org>
735
736 * print.c (print_object): Don't crash when a frame's name is nil
737 or invalid. (Bug#12025)
738
739 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
740 it signals an error when a tooltip frame is being created.
741
d7a7fda3
DA
7422012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
743
744 Cleanup miscellaneous objects allocation and initialization.
745 * alloc.c (allocate_misc): Change to static. Add argument to
746 specify the subtype. Adjust comment and users.
747 (build_overlay): New function.
748 * buffer.c (copy_overlays, Fmake_overlay): Use it.
749 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
750 (allocate_misc): Remove prototype.
751 (build_overlay): Add prototype.
752
7532012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
372f8ffc
DA
754
755 Swap buffer text indirection counters in Fbuffer_swap_text.
756 * buffer.c (Fbuffer_swap_text): Swap indirections too.
757 This avoids crash reported by Christoph Scholtes at
758 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
759
9d7fa573
JD
7602012-07-22 Jan Djärv <jan.h.d@swipnet.se>
761
762 * nsmenu.m (Popdown_data): New struct.
763 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
764 free Popdown_data.
765 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
766 (initWithContentRect): Make imgView and contentView non-static
767 and autorelease them. Also autorelease img and matrix (Bug#12005).
768 (dealloc): Remove (Bug#12005).
769
0dd6d66d
DA
7702012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
771
772 Adjust consing_since_gc when objects are explicitly freed.
773 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
774 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
775 (free_cons, free_misc): Subtract object size from consing_since_gc.
776
d36d71df
DA
7772012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
778
779 Simplify and cleanup markers positioning code.
780 * marker.c (attach_marker): More useful eassert.
781 (live_buffer, set_marker_internal): New function.
782 (Fset_marker, set_marker_restricted): Use set_marker_internal.
783 (set_marker_both, set_marker_restricted_both): Use live_buffer.
784
fb9ea40f
PE
7852012-07-22 Paul Eggert <eggert@cs.ucla.edu>
786
787 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
788 as it's limited by the amount of memory, not by INT_MAX.
789
2d5c5f7d
EZ
7902012-07-21 Eli Zaretskii <eliz@gnu.org>
791
07fb592e
EZ
792 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
793 in special-event-map. See the discussion at
794 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
795 for the reasons.
796
37a9eac8 797 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
2d5c5f7d
EZ
798 info.dwItemData. Fixes crashes on 64-bit Windows. Suggested by
799 Fabrice Popineau <fabrice.popineau@supelec.fr>.
800
c4328746
JD
8012012-07-21 Jan Djärv <jan.h.d@swipnet.se>
802
803 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 804 (conversationIdentifier): Return value is NSInteger.
784051c4 805 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 806
6e5d1c12
CY
8072012-07-21 Chong Yidong <cyd@gnu.org>
808
809 * window.c (decode_any_window): Signal an error if the window is
810 on a dead frame (Bug#11984).
811
9928463d
DA
8122012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
813
814 Add indirection counting to speed up Fkill_buffer.
815 * buffer.h (struct buffer): New member.
816 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
817 (Fmake_indirect_buffer): Set indirection counter to -1, increment
818 base buffer indirection counter.
819 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
820 (Fkill_buffer): Adjust indirection counters as needed, don't walk
821 through buffer list if indirection counter is 0.
822
f8643a6b
DA
8232012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
824
825 Extend the value returned by Fgarbage_collect with heap statistics.
826 * alloc.c (Qheap): New symbol.
827 (syms_of_alloc): DEFSYM it.
828 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
829 (Fmemory_free): Remove.
830 (syms_of_alloc): Don't defsubr it.
831 * buffer.c (Fcompact_buffer): Remove.
832 (syms_of_buffer): Don't defsubr it.
833
dac616ff
DA
8342012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
835
836 Make maybe_gc inline.
837 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
838 * lisp.h (consing_since_gc, gc_relative_threshold)
839 (memory_full_cons_threshold): Revert declaration.
840 (maybe_gc): Remove prototype, define as inline.
841 * alloc.c: Remove old commented-out code.
842 (consing_since_gc, gc_relative_threshold)
843 (memory_full_cons_threshold): Revert to global.
844 (maybe_gc): Remove.
845
d7ea76b4
DA
8462012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
847
848 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
849 * lisp.h (build_unibyte_string): New function.
850 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
851 * sysdep.c, w32fns.c, xfns.c: Use it.
852 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
853 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
854 Adjust users accordingly.
855 * font.h (font_open_by_name): Adjust prototype.
856
765e61e3
DA
8572012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
858
859 Cleanup calls to Fgarbage_collect.
860 * lisp.h (maybe_gc): New prototype.
861 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
862 Remove declarations.
863 * alloc.c (maybe_gc): New function.
864 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
865 Make them static.
866 * bytecode.c (MAYBE_GC): Use maybe_gc.
867 * eval.c (eval_sub, Ffuncall): Likewise.
868 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
869 to avoid dependency from auto-save feature.
870
52b852c7
PE
8712012-07-19 Paul Eggert <eggert@cs.ucla.edu>
872
873 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
874 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
875 'for_each_per_buffer_object_at'.
876 All uses changed. It's better to use upper-case for macros that
877 cannot be implemented as functions, to give the reader a clue
878 that they're special.
879
5db81e33
SM
8802012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
881
882 * alloc.c (Fgarbage_collect): Tweak docstring.
883
5b835e1d
DA
8842012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
885
886 Tweak the value returned from Fgarbage_collect again.
887 * alloc.c (Fgarbage_collect): New return value, as confirmed in
888 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
889 Adjust documentation.
890 (total_vector_bytes): Rename to total_vector_slots, adjust
891 accounting.
892 (total_free_vector_bytes): Rename to total_free_vector_slots,
893 adjust accounting.
894 (Qstring_bytes, Qvector_slots): New symbols.
895 (syms_of_alloc): DEFSYM them.
896
9cd47b72
DA
8972012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
898
899 Buffer compaction primitive which may be used from Lisp.
900 * buffer.c (compact_buffer, Fcompact_buffer): New function.
901 (syms_of_buffer): Register Fcompact_buffer.
902 * alloc.c (Fgarbage_collect): Use compact_buffer.
903 * buffer.h (compact_buffer): New prototype.
904 (struct buffer_text): New member.
905
d17337e5
DA
9062012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
907
908 New macro to iterate over all buffers, miscellaneous cleanups.
909 * lisp.h (all_buffers): Remove declaration.
910 * buffer.h (all_buffers): Add declaration, with comment.
911 (for_each_buffer): New macro.
912 * alloc.c (Fgarbage_collect, mark_object): Use it.
913 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
914 (init_buffer): Likewise.
915 * data.c (Fset_default): Likewise.
916 * coding.c (code_conversion_restore): Remove redundant check
917 for dead buffer.
918 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
919
60cfd278
AS
9202012-07-18 Andreas Schwab <schwab@linux-m68k.org>
921
922 Fix bug that created negative-length intervals.
923 * intervals.c (merge_interval_right, merge_interval_left):
924 Do not zero out this interval if it is absorbed by its children,
925 as this interval's total length doesn't change in that case. See
926 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
927
d06714cb
PE
9282012-07-18 Paul Eggert <eggert@cs.ucla.edu>
929
83713154
PE
930 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
931 when invoking (make-bool-vector N t) and N is a positive
932 multiple of 8 -- the last 8 bits were mistakenly cleared.
933
d06714cb
PE
934 Remove some struct layout assumptions in bool vectors.
935 * alloc.c (bool_header_size): New constant.
936 (header_size, word_size): Move earlier, as they're now used earlier.
937 Use 'word_size' in a few more places, where it's appropriate.
938 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
939 padding before the data member of a bool vector.
940 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
941 than doing the check by hand with an abort ().
942
464d5a5e
SM
9432012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
944
5fbc0409
SM
945 * eval.c (Fdefvar): Don't check constants since we only set the var if
946 it's not yet defined anyway (bug#11904).
947
464d5a5e
SM
948 * lisp.h (last_undo_boundary): Declare new var.
949 * keyboard.c (command_loop_1): Set it.
950 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
951 were auto-added by the command loop (bug#11774).
952
8dc2e44a
AS
9532012-07-18 Andreas Schwab <schwab@linux-m68k.org>
954
955 * w32font.c (Qsymbol): Remove local definition.
956 (syms_of_w32font): Don't DEFSYM it.
957
169925ec
DA
9582012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
959
960 Fix sweep_vectors to handle large bool vectors correctly.
961 * alloc.c (sweep_vectors): Account total_vector_bytes for
962 bool vectors larger than VBLOCK_BYTES_MAX.
963
5fbfb018
CY
9642012-07-18 Chong Yidong <cyd@gnu.org>
965
966 * frame.c (x_set_frame_parameters): Revert bogus change introduced
967 in 2012-05-25 commit by Paul Eggert (Bug#11738).
968
3ab6e069
DA
9692012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
970
971 Return more descriptive data from Fgarbage_collect.
972 Suggested by Stefan Monnier in
973 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
974 * alloc.c (bounded_number): New function.
975 (total_buffers, total_vectors): New variable.
976 (total_string_size): Rename to total_string_bytes, adjust users.
977 (total_vector_size): Rename to total_vector_bytes, adjust users.
978 (sweep_vectors): Account total_vectors and total_vector_bytes.
979 (Fgarbage_collect): New return value. Adjust documentation.
980 (gc_sweep): Account total_buffers.
981 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
982 (VECTOR_SIZE): Remove.
983 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
984 (Qinterval, Qmisc): New symbols.
985 (syms_of_data): Initialize them.
986 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
987 (Qcons, Qbuffer): New declarations.
988
6d02fe5b
PE
9892012-07-17 Paul Eggert <eggert@cs.ucla.edu>
990
991 * alloc.c (Fmemory_free): Account for memory-free's own storage.
992 Round up, not down. Improve doc.
993
b7ffe040
DA
9942012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
995
996 Restore old code in allocate_string_data to avoid Faset breakage.
997 Reported by Julien Danjou <julien@danjou.info> in
998 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
999 * alloc.c (allocate_string_data): Restore old code with minor
1000 adjustments, fix comment to explain this subtle issue.
1001
4dc7c8d5
SM
10022012-07-17 Eli Zaretskii <eliz@gnu.org>
1003
1004 Remove FILE_SYSTEM_CASE.
1005 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
1006
1007 * fileio.c (FILE_SYSTEM_CASE): Don't define.
1008 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
1009 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
1010 call-process-region passes it through expand-file-name.
1011
1012 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
1013
10142012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1015
1016 Fix crash when creating indirect buffer (Bug#11917)
1017 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
1018 Don't handle unbound variables specially if non-zero.
1019 (Fbuffer_local_variables): Pass zero.
1020 (clone_per_buffer_values): Pass non-zero.
1021
10222012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1023
1024 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
1025 to make the loop interruptible.
1026
10272012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1028
1029 * gnutls.c (emacs_gnutls_handshake): Only retry if
1030 GNUTLS_E_INTERRUPTED.
1031
cce7fefc
DA
10322012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1033
1034 Cleanup and convert miscellaneous checks to eassert.
1035 * alloc.c (mark_interval): Fix comment, partially rephrase
1036 old comment from intervals.h (see below).
1037 * intervals.c (find_interval, adjust_intervals_for_insertion)
1038 (delete_interval, adjust_intervals_for_deletion)
1039 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
1040 Convert to eassert.
1041 (adjust_intervals_for_insertion, make_new_interval):
1042 Remove obsolete and unused code.
1043 * intervals.h (struct interval): Remove obsolete comment.
1044 * textprotp.c (erase_properties): Remove unused code.
1045 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
1046 (Fremove_list_of_text_properties): Convert to eassert.
1047
9ea10cc3
CY
10482012-07-17 Chong Yidong <cyd@gnu.org>
1049
1050 * editfns.c (Finsert_char): Doc fix.
1051
3900d5de
DA
10522012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1053
1054 Fix previous change to make Fmemory_free always accurate.
1055 * alloc.c (make_interval): Update total_free_intervals.
1056 (make_float): Likewise for total_free_floats.
1057 (free_cons, Fcons): Likewise for total_free_conses.
1058 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
1059 Likewise for total_free_vector_bytes.
1060 (Fmake_symbol): Likewise for total_free_symbols.
1061 (bytes_free): Remove.
1062
7098646f
DA
10632012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1064
1065 Simple free memory accounting feature.
1066 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
1067 (sweep_vectors): Accumulate size of free vectors.
1068 (Fgarbage_collect): Setup bytes_free.
1069 (Fmemory_free): New function.
1070 (syms_of_alloc): Register it.
1071
22657b40
DA
10722012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1073
1074 Cleanup overlays checking.
1075 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
1076 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
1077 eassert and OVERLAYP.
1078 (sort_overlays): Change to use OVERLAYP.
1079
ddfc8813
RK
10802012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
1081
1082 * editfns.c (Finsert_char): Make it interactive, and make the
1083 second arg optional. Copy interactive spec and docstring from
1084 ucs-insert.
1085
7c26cf3c
PE
10862012-07-17 Paul Eggert <eggert@cs.ucla.edu>
1087
1088 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
1089 Unlike the other wrapped functions, fabs has an unspecified
1090 effect on errno.
1091
5d127af9
JD
10922012-07-16 Jan Djärv <jan.h.d@swipnet.se>
1093
1094 * nsterm.m (keyDown): Interpret flags without left/right bits
1095 as the left key (Bug#11670).
1096
6a0dd1d7
DA
10972012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
1098
1099 Remove empty and useless init functions.
1100 * lisp.h (init_character_once, init_fns, init_image)
1101 (init_filelock, init_sound): Remove prototype.
1102 * character.c (init_character_once): Remove.
1103 * filelock.c (init_filelock): Likewise.
1104 * fns.c (init_fns): Likewise.
1105 * image.c (init_image): Likewise.
1106 * sound.c (init_sound): Likewise.
1107 * emacs.c (main): Adjust accordingly.
1108
7a6136fd
DA
11092012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
1110
1111 * gtkutil.h: Tiny cleanups.
1112 (use_old_gtk_file_dialog): Remove useless declaration.
1113 (xg_uses_old_file_dialog): Add suggested const attribute.
1114
ce811ad9
EZ
11152012-07-15 Eli Zaretskii <eliz@gnu.org>
1116
1117 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
1118 (bidi_paragraph_init): Use it to limit search forward for a strong
1119 directional character in abnormally large paragraphs full of
1120 neutral or weak characters. (Bug#11943)
1121
c9adfeaa
SF
11222012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
1123
1124 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
1125 the toolbar (Bug#9451).
1126 (xg_make_tool_item): Give the widget event box a transparent
1127 background.
1128
fff62aa9
DA
11292012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
1130
1131 Cleanup basic allocation variables and functions.
1132 * alloc.c (ignore_warnings, init_intervals, init_float)
1133 (init_cons, init_symbol, init_marker): Remove.
1134 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
1135 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
1136 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
1137 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
1138 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
1139 (staticidx, init_alloc_once, init_strings, free_ablock):
1140 Remove redundant initialization.
1141 * fns.c (init_weak_hash_tables): Remove.
1142 * lisp.h (init_weak_hash_tables): Remove prototype.
1143
9730daca
DA
11442012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
1145
1146 Use zero_vector where appropriate.
1147 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
1148 accordingly.
1149 * lisp.h (zero_vector): New declaration.
1150 * font.c (null_vector): Remove.
1151 (syms_of_font): Remove initialization and staticpro.
1152 (font_list_entities, font_find_for_lface): Change to use zero_vector.
1153 * keymap.c (Faccessible_keymaps): Likewise.
1154
2e2d2a13
LL
11552012-07-15 Leo Liu <sdl.web@gmail.com>
1156
1157 * fringe.c: Fix typo in comments.
1158
cd276f6e
LL
11592012-07-14 Leo Liu <sdl.web@gmail.com>
1160
1161 * fringe.c: Add a new bitmap exclamation-mark.
1162
5a1131d9
EZ
11632012-07-14 Eli Zaretskii <eliz@gnu.org>
1164
1165 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
1166
1167 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
1168 (HAVE_MENUS): Don't define, defined by editing config.in with
1169 msdos/sed2v2.inp.
1170 (GMALLOC_INHIBIT_VALLOC): Don't define.
1171 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
1172
22e983b7
JB
11732012-07-14 Juanma Barranquero <lekktu@gmail.com>
1174
1175 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
1176
5b3f250f
GM
11772012-07-14 Glenn Morris <rgm@gnu.org>
1178
1179 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
1180 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
1181 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
1182
33d63ff4
GM
11832012-07-13 Glenn Morris <rgm@gnu.org>
1184
5b633342
GM
1185 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
1186
33d63ff4
GM
1187 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
1188 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
1189
b55b9f85
JD
11902012-07-13 Jan Djärv <jan.h.d@swipnet.se>
1191
0dc8cf50
JD
1192 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
1193 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
1194 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
1195 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
1196 where appropriate.
1197 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
1198 as boolean expression.
1199 (x_set_window_size): Remove unused variable toolbar.
1200 (ns_get_color_default, ns_mod_to_lisp): Remove.
1201 (ns_mouse_position): Remove unused variables xchar and ychar.
1202 (ns_compute_glyph_string_overhangs): Remove unused variable face.
1203 (ns_set_vertical_scroll_bar): Remove unused variable count.
1204 (ns_delete_terminal): Remove unused variable i.
1205 (ns_term_init): Remove unused variables r, g and b.
1206 (mouseDown): Remove unused variable window.
1207 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
1208 (initFrameFromEmacs): Remove unused variable vbextra.
1209 (mouseEntered): Remove unused variables p and dpyinfo.
1210 (mouseExited): Remove unused variables p and r.
1211 (ns_define_frame_cursor, ns_clear_frame_area)
1212 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
1213 (menuDown): Assign [sender tag] to variable and cast the variable.
1214
1215 * nsterm.h (menuDown): Add id as type to argument sender.
1216 (ns_display_info_for_name): Add Lisp_Object argument.
1217 (ns_term_init): Add Lisp_Object argument.
1218 (ns_map_event_to_object): Add void argument.
1219 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
1220 prototype with arguments and only declare if __OBJC__.
1221 (nxatoms_of_nsselect): Add void argument.
1222 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
1223 (ns_alloc_autorelease_pool): Add void argument.
1224 (ns_release_autorelease_pool): Add void* argument.
1225 (ns_get_defaults_value): Add const char* argument.
1226
1227 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
1228 (initFromContents): Use SSDATA where appropriate.
1229 (ns_update_menubar): Add braces to ambigous if-else.
1230 (initWithTitle): Put () around assignment in if statement.
1231 (ns_menu_show): Remove unused variables window and keymap.
1232 (update_frame_tool_bar): Remove unused variable selected_p.
1233 (initWithContentRect): Remove unused variable this_cmd_name.
1234
1235 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
1236 appropriate.
1237 (setXBMColor): Remove unused variable len.
1238 (setPixmapData): Put () around assignment in loop statement.
1239
1240 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
1241 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
1242 where appropriate.
1243 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
1244 around assignment in loop statement.
1245 (nsfont_open): Remove unused variable i.
1246 (nsfont_open): Remove unused variable len.
1247 (nsfont_draw): Remove unused variable cs.
1248
1249 * nsfns.m (x_set_icon_name, ns_set_name_internal)
1250 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
1251 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
1252 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
1253 (Fns_font_name, Fns_perform_service)
1254 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
1255 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
1256 (ns_set_name): Remove unused variable view.
1257 (x_set_menu_bar_lines): Remove unused variable olines.
1258 (x_set_tool_bar_lines): Remove unused variable root_window.
1259 (Fns_list_colors): Put () around assignment in while statement.
1260 (Fns_perform_service): Remove unused variable len.
1261 (Fns_display_usable_bounds): Remove unused variable top.
1262 (syms_of_nsfns): Remove unused variable i.
1263
b55b9f85
JD
1264 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
1265 memcpy (Bug#11907).
1266
ed9265fc 12672012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
1268
1269 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
1270 and free it with DestroyExceptionInfo (Bug#11558).
1271
ef099b57
JB
12722012-07-13 Juanma Barranquero <lekktu@gmail.com>
1273
1274 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
1275 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
1276 Set here, not in nt/config.nt.
1277
ea814a5d
EZ
12782012-07-13 Eli Zaretskii <eliz@gnu.org>
1279
1280 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
1281 cursor overflow into the last glyph on display line when the right
1282 fringe is off. (Bug#11832)
1283
1a952767
PE
12842012-07-13 Paul Eggert <eggert@cs.ucla.edu>
1285
1286 * xdisp.c (produce_special_glyphs): Now static.
1287 * dispextern.h (produce_special_glyphs): Remove decl.
1288
983188fd
GM
12892012-07-13 Glenn Morris <rgm@gnu.org>
1290
8d7c7eed 1291 * s/bsd-common.h, s/cygwin.h: Remove empty files.
32fb4bb6
GM
1292 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
1293
983188fd
GM
1294 * s/usg5-4-common.h (USG, USG5):
1295 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
1296 * s/sol2-6.h (SOLARIS2):
1297 * s/irix6-5.h (IRIX6_5):
1298 * s/hpux10-20.h (USG, USG5, HPUX):
1299 * s/gnu-linux.h (USG, GNU_LINUX):
1300 * s/freebsd.h (BSD_SYSTEM):
1301 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
1302 * s/cygwin.h (CYGWIN):
1303 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
1304 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
1305
d1e68667 13062012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
1307
1308 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 1309
6de0e799
GM
13102012-07-13 Glenn Morris <rgm@gnu.org>
1311
739ae010
GM
1312 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
1313
dbee5793
GM
1314 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
1315
6de0e799
GM
1316 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
1317 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
1318
b82da769
GM
13192012-07-12 Glenn Morris <rgm@gnu.org>
1320
4fae5a7a 1321 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
1322
1323 * process.c (init_process_emacs): Rename from init_process.
1324 The old name is also the name of a Mach system call.
1325 * lisp.h, emacs.c: Update for this name change.
1326 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
1327 longer needed.
1328
5a979817
EZ
13292012-07-12 Eli Zaretskii <eliz@gnu.org>
1330
1331 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
1332 memmove call that removes glyphs covered by the left truncation
1333 glyph. Improve commentary.
1334 (display_line): Fix display of continuation glyphs on GUI frames
1335 when the right fringe is turned off and variable-size fonts are
1336 used in the window. Move the code that appends a stretch glyph to
1337 produce_special_glyphs, so that it could be used for truncation
1338 and continuation glyphs alike.
1339 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
1340 glyph of a suitably computed width, to align the special glyphs at
1341 the window margin. Code moved from display_line. (Bug#11832)
1342
3e91a053
GM
13432012-07-12 Glenn Morris <rgm@gnu.org>
1344
ba9e4b84
GM
1345 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
1346
1347 * s/gnu-linux.h, s/hpux10-20.h:
1348 Do not unconditionally define HAVE_XRMSETDATABASE.
1349
3e91a053
GM
1350 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
1351
b300b1f4
PE
13522012-07-12 Paul Eggert <eggert@cs.ucla.edu>
1353
1354 Fix typos that broke OS X build.
1355 Reported by Randal L. Schwartz in
1356 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
1357 * nsterm.m (ns_timeout): Add missing local decl.
1358 (ns_get_color): snprintf -> sprintf, to fix typo.
1359
6e777848
GM
13602012-07-12 Glenn Morris <rgm@gnu.org>
1361
3f922c37
GM
1362 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
1363 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
1364 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
1365 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
1366
0ab7b23a
GM
1367 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
1368 Move PTY_OPEN to configure.
1369
6e777848
GM
1370 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1371 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
1372 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
1373
4a7edc24
DA
13742012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
1375
1376 Use empty_unibyte_string where applicable.
1377 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
1378 * lread.c (read1): Likewise.
1379 * xsettings.c (syms_of_xsettings): Likewise.
1380
308aab79
GM
13812012-07-12 Glenn Morris <rgm@gnu.org>
1382
42bd1719
GM
1383 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
1384 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
1385 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
1386 * s/hpux10-20.h (RUN_TIME_REMAP):
1387 * s/bsd-common.h (TABDLY): Move to configure.
1388
1389 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
1390
1391 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
1392
ea0bbd17 1393 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 1394 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
1395
1396 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 1397
308aab79
GM
1398 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
1399 * s/template.h: Move NARROWPROTO to configure.
1400
ee1cf5cf
GM
14012012-07-11 Glenn Morris <rgm@gnu.org>
1402
30fe9bf4
GM
1403 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
1404 unused since 2011-01-17 change to systty.h.
1405
ee1cf5cf
GM
1406 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
1407 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1408 Move HAVE_PTYS and HAVE_SOCKETS to configure.
1409
63e47e07
PE
14102012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1411
1412 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
1413
c43fb4c3
GM
14142012-07-11 Glenn Morris <rgm@gnu.org>
1415
1416 * s/darwin.h, s/gnu-linux.h, s/template.h:
1417 Move INTERRUPT_INPUT to configure.
1418
e8df9267
DA
14192012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1420
1421 Minor adjustments to interning code.
1422 * lisp.h (intern, intern_c_string): Redefine as static inline
1423 wrappers for intern_1 and intern_c_string_1, respectively.
1424 (intern_1, intern_c_string_1): Rename prototypes.
2bce5643
DA
1425 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
1426 Vobarray checking.
e8df9267
DA
1427 * font.c (font_intern_prop): Likewise. Adjust comment.
1428 * w32font.c (intern_font_name): Likewise.
1429
34348bd4
AS
14302012-07-11 Andreas Schwab <schwab@linux-m68k.org>
1431
d96a1e0c
AS
1432 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
1433
34348bd4
AS
1434 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
1435 of Fcar/Fcdr if possible.
1436 * font.c (check_otf_features): Likewise.
1437 * fontset.c (Fnew_fontset): Likewise.
1438 * gnutls.c (Fgnutls_boot): Likewise.
1439 * minibuf.c (read_minibuf): Likewise.
1440 * msdos.c (IT_set_frame_parameters): Likewise.
1441 * xmenu.c (Fx_popup_dialog): Likewise.
1442 * w32menu.c (Fx_popup_dialog): Likewise.
1443
c8add24e
GM
14442012-07-11 Glenn Morris <rgm@gnu.org>
1445
4b575b3c
GM
1446 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
1447 since nothing has defined it on these platforms.
1448
09f4e3b0
GM
1449 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
1450 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
1451
172bedef
GM
1452 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1453 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1454 Move CLASH_DETECTION to configure.
1455
249685df
GM
1456 * s/gnu.h: Remove file, which is now empty.
1457
c8add24e
GM
1458 * s/gnu.h, s/gnu-linux.h:
1459 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
1460
b41253a3
JW
14612012-07-11 John Wiegley <johnw@newartisans.com>
1462
1463 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
1464 function attribute, so we only use it if it exists in the
1465 compiler.
1466
d923b542
DA
14672012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1468
1469 Avoid call to strlen in fast_c_string_match_ignore_case.
1470 * search.c (fast_c_string_match_ignore_case): Change to use
1471 length argument. Adjust users accordingly.
1472 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
1473
5ebbef1d
PE
14742012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1475
bb352260
PE
1476 Assume mkdir, rmdir.
1477 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
1478 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
1479
57054ddd
PE
1480 Assume rename.
1481 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
1482
b747d3f7
PE
1483 Assume perror.
1484 * s/hpux10-20.h (HAVE_PERROR): Remove.
1485 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
1486 Remove dummy definition, as this problem was obsolete long ago.
1487
5ebbef1d
PE
1488 Assume strerror.
1489 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
1490
984e7f30
DA
14912012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1492
1493 Avoid calls to strlen in font processing functions.
1494 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
d923b542 1495 (font_open_by_name): Change to use length argument. Adjust
984e7f30 1496 users accordingly.
d923b542
DA
1497 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
1498 Adjust prototypes.
1499 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
1500 Change to return ptrdiff_t.
984e7f30
DA
1501 (xfont_list_pattern, xfont_match): Use length returned by
1502 xfont_decode_coding_xlfd.
1503 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
1504
20e94fdd
GM
15052012-07-11 Glenn Morris <rgm@gnu.org>
1506
9d596af3
GM
1507 * s/darwin.h, s/freebsd.h, s/netbsd.h:
1508 Move DONT_REOPEN_PTY to configure.
1509
20e94fdd
GM
1510 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
1511 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
1512
e99a530f
PE
15132012-07-10 Paul Eggert <eggert@cs.ucla.edu>
1514
22ffb973
PE
1515 Remove "#define unix" that is no longer needed (Bug#11905).
1516 * s/aix4-2.h (unix): Remove; no longer needed.
1517
e9a9ae03
PE
1518 EMACS_TIME simplification (Bug#11875).
1519 This replaces macros (which typically do not work in GDB)
1520 with functions, typedefs and enums, making the code easier to debug.
1521 The functional style also makes code easier to read and maintain.
1522 * systime.h: Include <sys/time.h> on all hosts, not just if
1523 WINDOWSNT, since 'struct timeval' is needed in general.
1524 (EMACS_TIME): Now a typedef, not a macro.
1525 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
1526 not macros.
1527 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
1528 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
1529 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
1530 (EMACS_TIME_LE): Now functions, not macros.
1531 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
1532 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
1533 which are not functions. All uses rewritten to use:
1534 (make_emacs_time): New function.
1535 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
1536 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
1537 not functions. All uses rewritten to use the following, respectively:
1538 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
1539 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 1540 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
1541 * fileio.c (Fcopy_file):
1542 * xterm.c (XTflash): Get the current time closer to when it's used.
1543 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
1544
ffacb126
PE
1545 * bytecode.c (targets): Suppress -Woverride-init warnings.
1546
e99a530f
PE
1547 Simplify by avoiding confusing use of strncpy etc.
1548 * doc.c (Fsnarf_documentation):
1549 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
1550 * frame.c (Fmake_terminal_frame):
1551 * gtkutil.c (get_utf8_string):
1552 * lread.c (openp):
1553 * nsmenu.m (ns_update_menubar):
1554 * regex.c (regerror):
1555 Prefer memcpy to strncpy and strncat when either will do.
1556 * fileio.c (Fsubstitute_in_file_name):
1557 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
1558 (menu_separator_name_p):
1559 * nsmenu.m (ns_update_menubar):
1560 Prefer memcmp to strncmp when either will do.
1561 * nsterm.m: Include <ftoastr.h>.
1562 (ns_get_color):
1563 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
1564 Prefer snprintf to strncpy.
1565 * nsterm.m (ns_term_init):
1566 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
1567 * nsterm.m (ns_term_init):
1568 Avoid the need for strncpy, by using build_string or
1569 make_unibyte_string directly. Use dtoastr, not snprintf.
1570 * process.c (Fmake_network_process): Diagnose service names that
1571 are too long, rather than silently truncating them or creating
1572 non-null-terminated names.
1573 (Fnetwork_interface_info): Likewise, for interface names.
1574 * sysdep.c (system_process_attributes) [GNU_LINUX]:
1575 Prefer sprintf to strncat.
1576 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
1577 Prefer vsnprintf to vsprintf + strncpy.
1578
c59592b3
GM
15792012-07-10 Glenn Morris <rgm@gnu.org>
1580
1581 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
1582 Clarify fallback case.
1583
7d7bbefd
DA
15842012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1585
1586 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
1587 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
1588 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 1589 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
1590 where argument type is known to be a Lisp_Cons.
1591
3a4c8000
TT
15922012-07-10 Tom Tromey <tromey@redhat.com>
1593
1594 * bytecode.c (BYTE_CODE_THREADED): New macro.
1595 (BYTE_CODES): New macro. Replaces all old byte-code defines.
1596 (enum byte_code_op): New type.
1597 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
1598 (exec_byte_code): Use them. Use token threading when applicable.
1599
2a0213a6
DA
16002012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1601
1602 Optimize pure C strings initialization.
1603 * lisp.h (make_pure_string): Fix prototype.
1604 (build_pure_c_string): New function, defined as static inline. This
1605 provides a better opportunity to optimize away calls to strlen when
1606 the function is called with compile-time constant argument.
1607 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
1608 argument, adjust users accordingly. Use build_pure_c_string where
1609 appropriate.
1610 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
1611 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
1612 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
1613
cb1caeaf
DA
16142012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1615
1616 Avoid calls to strlen in miscellaneous functions.
1617 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
1618 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
1619 * lread.c (openp): Likewise.
1620
c293e30c
DA
16212012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1622
1623 Avoid calls to strlen in path processing functions.
1624 * fileio.c (file_name_as_directory): Add comment. Change to add
1625 srclen argument and return the length of result. Adjust users
1626 accordingly.
1627 (directory_file_name): Fix comment. Change to add srclen argument,
cb1caeaf 1628 swap 1st and 2nd arguments to obey the common convention. Adjust
c293e30c
DA
1629 users accordingly.
1630 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
1631
9e059e3f
GM
16322012-07-10 Glenn Morris <rgm@gnu.org>
1633
d02eb359
GM
1634 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
1635 Move PENDING_OUTPUT_COUNT definition to configure.
1636
882cf227
GM
1637 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
1638 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
1639 * s/gnu.h (DATA_START): Move definitions to configure.
1640
af6e839f
GM
1641 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
1642 We include usg5-4-common.h, which defines them both.
1643
40289a12
GM
1644 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
1645 O_RDONLY already includes it).
1646
9e059e3f
GM
1647 Stop ns builds setting the EMACSLOADPATH environment variable.
1648 * nsterm.m (ns_load_path): Rename from ns_init_paths.
1649 Now it does not set EMACSLOADPATH, just returns the load-path string.
1650 * nsterm.h: Update accordingly.
1651 * lread.c [HAVE_NS]: Include nsterm.h.
1652 (init_lread) [HAVE_NS]: Use ns_load_path.
1653 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
1654
7c4e8ec0
GM
16552012-07-09 Glenn Morris <rgm@gnu.org>
1656
d4f600ff
GM
1657 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
1658 since the included bsd-common.h does so.
1659
cbb31951
GM
1660 Stop ns builds setting the EMACSPATH environment variable.
1661 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
1662 (ns_init_paths): Do not set EMACSPATH.
1663 * nsterm.h (ns_exec_path): Add it.
1664 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
1665 Use ns_exec_path.
1666
7c4e8ec0
GM
1667 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
1668
26bccfae
PE
16692012-07-09 Paul Eggert <eggert@cs.ucla.edu>
1670
a0bee46f
PE
1671 * process.c (wait_reading_process_output): 'waitchannels' was unset
1672 when read_kbd || !NILP (wait_for_cell); fix this.
1673
5994c183
PE
1674 Add GCC-style 'const' attribute to functions that can use it.
1675 * character.h (char_resolve_modifier_mask):
1676 * keyboard.h (make_ctrl_char):
1677 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
1678 (init_character_once, next_almost_prime, init_fns, init_image)
1679 (flush_pending_output, init_sound):
1680 * mem-limits.h (start_of_data):
1681 * menu.h (finish_menu_items):
1682 Add ATTRIBUTE_CONST.
1683 * emacs.c (DEFINE_DUMMY_FUNCTION):
1684 Declare the dummy function with ATTRIBUTE_CONST.
1685 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
1686 Add decls with ATTRIBUTE_CONST.
1687
26bccfae
PE
1688 Minor improvements to make_formatted_string.
1689 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
1690 where int is good enough, as vsprintf returns an int.
1691 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
1692
a8290ec3
DA
16932012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1694
1695 Use make_formatted_string to avoid double length calculation.
1696 * lisp.h (make_formatted_string): New prototype.
1697 * alloc.c (make_formatted_string): New function.
1698 * buffer.c (Fgenerate_new_buffer_name): Use it.
1699 * dbus.c (syms_of_dbusbind): Likewise.
1700 * editfns.c (Fcurrent_time_zone): Likewise.
1701 * filelock.c (get_boot_time): Likewise.
1702 * frame.c (make_terminal_frame, set_term_frame_name)
1703 (x_report_frame_params): Likewise.
1704 * image.c (gs_load): Likewise.
1705 * minibuf.c (get_minibuffer): Likewise.
1706 * msdos.c (dos_set_window_size): Likewise.
1707 * process.c (make_process): Likewise.
1708 * xdisp.c (ensure_echo_area_buffers): Likewise.
1709 * xsettings.c (apply_xft_settings): Likewise.
1710
d01ba2f1
GM
17112012-07-09 Glenn Morris <rgm@gnu.org>
1712
1713 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
1714 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
1715 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
1716 * nsterm.h (ns_etc_directory): Add it.
1717 * callproc.c [HAVE_NS]: Include nsterm.h.
1718 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
1719
f1f924b6
DA
17202012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1721
1722 Move marker debugging code under MARKER_DEBUG.
1723 * marker.c (MARKER_DEBUG): Move marker debugging code under
1724 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
1725 for bootstrap with --enable-checking (~3x slowdown reported
1726 by Juanma Barranquero <lekktu@gmail.com>).
1727 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
1728
ab531b66
PE
17292012-07-08 Paul Eggert <eggert@cs.ucla.edu>
1730
1731 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
1732 See <http://bugs.gnu.org/11825#29>.
1733
c4b3bc8a
EZ
17342012-07-08 Eli Zaretskii <eliz@gnu.org>
1735
1736 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
1737 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
1738 (display_line): Add commentary about displaying truncation glyphs
1739 on GUI frames.
1740 (produce_special_glyphs): Move here from term.c.
1741
1742 * term.c (produce_special_glyphs): Move to xdisp.c.
1743
1744 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
1745 section.
c4b3bc8a 1746
b676b881
AS
17472012-07-07 Andreas Schwab <schwab@linux-m68k.org>
1748
f17c5273
AS
1749 * xdisp.c (display_line): Avoid warning about implicit declaration
1750 of FRAME_FONT.
1751
298819b9
AS
1752 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
1753
b676b881
AS
1754 * lisp.h: Remove empty conditional.
1755
6045c4fd
PE
17562012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1757
b3350bf9
PE
1758 * lread.c (load_path_check): Now static.
1759
6045c4fd
PE
1760 Fix some minor --with-ns problems found by static checking.
1761 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
1762 (x_set_font) [!HAVE_X_WINDOWS]:
1763 * image.c (xpm_load_image) [HAVE_NS]:
1764 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
1765 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
1766 Remove unused local.
1767 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
1768 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
1769 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
1770 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
1771 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
1772 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
1773 Fix pointer signedness problem.
1774 * xfaces.c (FRAME_X_FONT_TABLE):
1775 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
1776
929e7845
GM
17772012-07-07 Glenn Morris <rgm@gnu.org>
1778
1779 * lread.c (load_path_check): New function, split from init_lread.
1780 (init_lread): Reorganize. Motivation:
1781 If EMACSLOADPATH is set, check/warn about that rather than the
1782 defaults, which we are not going to use. Hence we can remove
1783 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
1784 Don't warn if site-lisp directories are missing.
1785 If not installed, start from a blank load-path, since
1786 PATH_LOADSEARCH refers to the eventual installation directories.
1787
58dd0aa4
EZ
17882012-07-07 Eli Zaretskii <eliz@gnu.org>
1789
1790 Support truncation and continuation glyphs on GUI frames, when
1791 fringes are disabled. (Bug#11832)
1792 * xdisp.c (init_iterator): Get dimensions of truncation and
1793 continuation glyphs even if on GUI frames. Adjust
1794 it->last_visible_x on GUI frames when the left or right fringes,
1795 or both, are absent.
1796 (start_display, move_it_in_display_line_to): Handle the case of a
1797 GUI frame without a fringe to display continuation or truncation
1798 glyphs.
1799 (insert_left_trunc_glyphs): Support GUI frames: make sure
1800 truncation glyphs overwrite enough glyphs from the current line to
1801 have sufficient space in pixels.
1802 (display_line): Support truncation and continuation glyphs on GUI
1803 frames. If some spare pixels are left on the line after inserting
1804 the truncation glyphs, fill that space with a stretch glyph of a
1805 suitably computed width.
1806
1807 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
1808 produce_glyphs, to support GUI sessions.
1809
31571fd7
PE
18102012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1811
5a16b9bc
PE
1812 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
1813
f3047c75
PE
1814 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
1815
31571fd7
PE
1816 Do not require float-time's arg to fit in time_t (Bug#11825).
1817 This works better on hosts where time_t is unsigned, and where
1818 float-time is applied to the (negative) difference between two times.
1819 * editfns.c (decode_time_components): Last arg is now double *,
1820 not int *, and means to store all the result as a double, without
1821 worrying about whether the seconds part fits in time_t.
1822 All callers changed.
1823 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
1824 All callers changed.
1825 (Ffloat_time): Do not fail merely because the specified time falls
1826 outside of time_t range.
1827
4516fbef
GM
18282012-07-07 Glenn Morris <rgm@gnu.org>
1829
1830 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
1831 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
1832 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
1833
07adc2c6
JB
18342012-07-07 Juanma Barranquero <lekktu@gmail.com>
1835
1836 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
1837 Update dependencies.
1838
1839 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
1840
fd573f31
PE
18412012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1842
fee5959d
PE
1843 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
1844 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
1845 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
1846 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
1847 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
1848 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
1849
fd573f31
PE
1850 * xfont.c (compare_font_names): Redo to omit the need for casts.
1851
ddadbc0e
AS
18522012-07-06 Andreas Schwab <schwab@linux-m68k.org>
1853
fca8d6b6
AS
1854 * xfns.c (Fx_change_window_property): Doc fix.
1855 * w32fns.c (Fx_change_window_property): Doc fix.
1856
ddadbc0e
AS
1857 * w32fns.c (Fx_window_property): Accept the same arguments as the
1858 X Windows version. Doc fix.
1859 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
1860
ed9265fc 18612012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
1862 Eli Zaretskii <eliz@gnu.org>
1863
1864 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
1865 Windows-specific code from nt/config.nt moved here.
1866 Obsolete settings removed.
1867
216ee680
PE
18682012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1869
1870 * process.c: Avoid unnecessary calls to gettime.
1871 (wait_reading_process_output): Don't get the time of day
1872 when gobbling data immediately and not waiting, as there's no need
1873 for it in that case. This removes a FIXME.
1874
bdd091e4
JD
18752012-07-06 Jan Djärv <jan.h.d@swipnet.se>
1876
1877 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
1878 is defined (Bug#11768).
1879
9d44f8ce
DA
18802012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1881
1882 Fix marker debugging code.
1883 * marker.c (byte_char_debug_check): Do not perform the check
1884 if buffer is not multibyte.
090bd7cb
JB
1885 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1886 Call byte_char_debug_check with correct arguments.
9d44f8ce 1887
90fc4786
DA
18882012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1889
1890 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
1891 * marker.c (byte_char_debug_check, count_markers):
1892 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
1893 (byte_debug_flag): Remove.
1894 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1895 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
1896
7b7ae965
DA
18972012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1898
4e57b342
DA
1899 Avoid code repetition in marker-related functions.
1900 * marker.c (attach_marker): New function.
1901 (Fset_marker, set_marker_restricted, set_marker_both)
1902 (set_marker_restricted_both): Use it.
1903 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
1904 Consistently rename charno to charpos.
1905 (marker_position): Add eassert.
1906 (marker_byte_position): Convert to eassert.
1907
19082012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1909
1910 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 1911 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 1912 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 1913
657924ff
DA
19142012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1915
1916 Introduce fast path for the widely used marker operation.
1917 * alloc.c (build_marker): New function.
1918 * lisp.h (build_marker): New prototype.
1919 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
1920 * composite.c (autocmp_chars): Likewise.
1921 * editfns.c (buildmark): Remove.
1922 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
1923 (save_restriction_save): Use build_marker.
1924 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
1925 * window.c (save_window_save): Likewise.
1926
041a49a6
DA
19272012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1928
1929 Do not use Fdelete_overlay in delete_all_overlays
1930 to avoid redundant calls to unchain_overlay.
1931 * buffer.c (drop_overlay): New function.
1932 (delete_all_overlays, Fdelete_overlay): Use it.
1933 * minibuf.c (get_minibuffer): Fix comment.
1934
7dca65a4
PE
19352012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1936
1937 Port to OpenBSD 5.1 amd64.
1938 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
1939 This is needed for OpenBSD, and should be harmless on all BSD systems.
1940 Also, include <sys/sysctl.h>, as it should be available on all
1941 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
1942 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
1943 use p_pid member, not kp_proc.pid.
1944
8eb876e2
GM
19452012-07-06 Glenn Morris <rgm@gnu.org>
1946
1947 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
1948
38182d90
PE
19492012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1950
1951 More xmalloc and related cleanup.
1952 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
1953 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
1954 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
1955 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
1956 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
1957 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
1958 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
1959 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
1960 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
1961 * xterm.c:
1962 Omit needless casts involving void * pointers and allocation.
1963 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
1964 as the former is more robust if P's type is changed.
1965 Prefer xzalloc to xmalloc + memset 0.
1966 Simplify malloc-or-realloc to realloc.
1967 Don't worry about xmalloc returning a null pointer.
1968 Prefer xstrdup to xmalloc + strcpy.
1969 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
1970 growing it.
1971 * keyboard.c (apply_modifiers_uncached): Prefer local array to
1972 alloca of a constant.
1973
6dd5a677
EZ
19742012-07-05 Eli Zaretskii <eliz@gnu.org>
1975
1976 * xdisp.c (display_line): Fix horizontal pixel coordinates when
1977 hscroll is larger than the line width. Fixes long and futile
1978 looping inside extend_face_to_end_of_line (on a TTY) producing
1979 glyphs that are not needed and thrown away.
1980
6b312f0f
DA
19812012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1982
1983 * marker.c (set_marker_restricted_both): Simplify by using
1984 clip_to_bounds.
1985
f520ef9b
PE
19862012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1987
1988 * editfns.c (region_limit): Simplify by using clip_to_bounds.
1989
383b7c95
JD
19902012-07-05 Jan Djärv <jan.h.d@swipnet.se>
1991
1992 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
1993 not defined (Bug#11768).
1994 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
1995 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
1996 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
1997 followed by gtk_box_set_homogeneous (Bug#11768).
1998 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
1999 (update_theme_scrollbar_width, xg_create_scroll_bar):
2000 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
2001 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
2002 (is_box_type): New function (Bug#11768).
2003 (xg_tool_item_stale_p): Call is_box_type.
5293d758 2004 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
2005 with default display (Bug#11768).
2006
d6e7bf45
EZ
20072012-07-05 Eli Zaretskii <eliz@gnu.org>
2008
2009 * xdisp.c (window_hscroll_limited): New function.
2010 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
2011 coordinates when window's hscroll is set to insanely large
2012 values. (Bug#11857)
2013
431391ec
JB
20142012-07-05 Juanma Barranquero <lekktu@gmail.com>
2015
2016 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
2017 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
2018
23f86fce
DA
20192012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
2020
2021 Cleanup xmalloc.
2022 * lisp.h (xzalloc): New prototype. Omit needless casts.
2023 * alloc.c (xzalloc): New function. Omit needless casts.
2024 * charset.c: Omit needless casts. Convert all calls to
2025 xmalloc with following memset to xzalloc.
2026 * dispnew.c: Likewise.
2027 * fringe.c: Likewise.
2028 * image.c: Likewise.
2029 * sound.c: Likewise.
2030 * term.c: Likewise.
2031 * w32fns.c: Likewise.
2032 * w32font.c: Likewise.
2033 * w32term.c: Likewise.
2034 * xfaces.c: Likewise.
2035 * xfns.c: Likewise.
2036 * xterm.c: Likewise.
2037 * atimer.c: Omit needless casts.
2038 * buffer.c: Likewise.
2039 * callproc.c: Likewise.
2040 * ccl.c: Likewise.
2041 * coding.c: Likewise.
2042 * composite.c: Likewise.
2043 * doc.c: Likewise.
2044 * doprnt.c: Likewise.
2045 * editfns.c: Likewise.
2046 * emacs.c: Likewise.
2047 * eval.c: Likewise.
2048 * filelock.c: Likewise.
2049 * fns.c: Likewise.
2050 * gtkutil.c: Likewise.
2051 * keyboard.c: Likewise.
2052 * lisp.h: Likewise.
2053 * lread.c: Likewise.
2054 * minibuf.c: Likewise.
2055 * msdos.c: Likewise.
2056 * print.c: Likewise.
2057 * process.c: Likewise.
2058 * region-cache.c: Likewise.
2059 * search.c: Likewise.
2060 * sysdep.c: Likewise.
2061 * termcap.c: Likewise.
2062 * terminal.c: Likewise.
2063 * tparam.c: Likewise.
2064 * w16select.c: Likewise.
2065 * w32.c: Likewise.
2066 * w32reg.c: Likewise.
2067 * w32select.c: Likewise.
2068 * w32uniscribe.c: Likewise.
2069 * widget.c: Likewise.
2070 * xdisp.c: Likewise.
2071 * xmenu.c: Likewise.
2072 * xrdb.c: Likewise.
2073 * xselect.c: Likewise.
2074
0497dc44
PE
20752012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2076
2077 * fileio.c (time_error_value): Check the right error number.
2078 Problem reported by Troels Nielsen in
2079 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
2080
356e7178
PE
20812012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2082
4e71fd89
PE
2083 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
2084 This should be fixed in a better way; see Eli Zaretskii in
2085 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
2086 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
2087
f0941253
PE
2088 * fileio.c (time_error_value): Rename from special_mtime.
2089 The old name's problems were noted by Eli Zaretskii in
2090 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
2091
065c9eb4
PE
2092 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
2093 This variable's comment says Emacs needs at least one GDB-visible
2094 symbol of type enum pvec_type, to work around GDB problems.
2095 The symbol's value doesn't matter.
2096
356e7178
PE
2097 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
2098 that causes compilation to fail on pre-C99 compilers.
2099
ed9265fc 21002012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
2101
2102 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
2103 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
2104
3884d954
DA
21052012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2106
d209e2fb 2107 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
2108 headers for buffer_defaults and buffer_local_symbols.
2109 Reported by Juanma Barranquero <lekktu@gmail.com>.
2110
ee28be33
SM
21112012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2112
2113 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
2114 * lisp.h (enum pvec_type): Use fewer bits.
2115 (PSEUDOVECTOR_SIZE_BITS): New constant.
2116 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
2117 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
2118 change in pvec_type.
2119 (PSEUDOVECTOR_TYPEP): New macro.
2120 (TYPED_PSEUDOVECTORP): Use it.
2121 * fns.c (internal_equal): Adapt code to extract pvectype.
2122 * emacs.c (gdb_pvec_type): Update type.
2123 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
2124 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
2125 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
2126 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
2127 (sweep_vectors): Use it. Use local var `total_bytes' instead of
2128 abusing vector->header.next.nbytes.
2129 (live_vector_p): Use PVEC_TYPE.
2130 (mark_object): Adapt code to extract pvectype. Use switch.
2131
c7f2cd7f
PE
21322012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2133
2134 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
2135 Tighten new eassert a bit.
2136
8ce70ed2
DA
21372012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2138
2139 Fix compilation with --enable-gcc-warnings and -O1
2140 optimization level.
2141 * doprnt.c (doprnt): Change type of tem to int, initialize
2142 to avoid compiler warning. Add eassert.
2143 * search.c (simple_search): Initialize match_byte to avoid
2144 compiler warning. Add eassert.
2145
dea7f1e5
PE
21462012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2147
24a212eb
PE
2148 Avoid weird behavior with large horizontal scrolls.
2149 Without this change, for example, large hscroll values would
2150 mess up Emacs's display on Fedora 15 x86, presumably due to
2151 overflows in int calculations in the display code.
2152 Also, if buffers had long lines, Emacs would freeze.
2153 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
2154 (set_window_hscroll): New function, containing the old guts of
2155 Fset_window_hscroll. Return the clipped value.
2156 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
2157 This avoids the need to check against PTRDIFF_MAX.
2158
dea7f1e5
PE
2159 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
2160
76046526
DA
21612012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2162
2163 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
2164
39adff0d
PE
21652012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2166
63807d47
PE
2167 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
2168 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
2169 since GCC 4.4.6 issues a bogus warning for them.
2170
39adff0d
PE
2171 Fix bugs in file timestamp newness comparisons.
2172 * fileio.c (Ffile_newer_than_file_p):
2173 * lread.c (Fload): Use full timestamp resolution of files,
2174 not just the 1-second resolution, so that files that are only
2175 slightly newer still count as newer.
2176 * fileio.c (Ffile_newer_than_file_p): Don't assume file
2177 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
2178
dbeed9a6
PE
21792012-07-03 Paul Eggert <eggert@cs.ucla.edu>
2180
2181 * fileio.c: Improve handling of file time marker. (Bug#11852)
2182 (special_mtime): New function.
2183 (Finsert_file_contents, Fverify_visited_file_modtime):
2184 Use it to set special mtime values consistently.
2185
636334d6
AS
21862012-07-03 Andreas Schwab <schwab@linux-m68k.org>
2187
2188 * fileio.c (Finsert_file_contents): Properly handle st_mtime
2189 marker for non-existing file. (Bug#11852)
2190
e2017fe2
GM
21912012-07-03 Glenn Morris <rgm@gnu.org>
2192
2193 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
2194 and did not make it into globals.h).
2195
404dbd37
TT
21962012-07-03 Tom Tromey <tromey@redhat.com>
2197
2198 * window.c (Fset_window_margins, Fset_window_fringes)
2199 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
2200 * textprop.c (Fprevious_property_change): No longer static.
2201 * syntax.c (Fsyntax_table_p): No longer static.
2202 * process.c (Fget_process, Fprocess_datagram_address): No longer
2203 static.
2204 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
2205 * keyboard.c (Fcommand_execute): No longer static.
2206 Remove EXFUN.
2207 * insdel.c (Fcombine_after_change_execute): No longer static.
2208 * image.c (Finit_image_library): No longer static.
2209 * fileio.c (Fmake_symbolic_link): No longer static.
2210 * eval.c (Ffetch_bytecode): No longer static.
2211 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
2212 * doc.c (Fdocumentation_property, Fsnarf_documentation):
2213 No longer static.
404dbd37
TT
2214 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
2215 static.
2216 * dired.c (Ffile_attributes): No longer static.
2217 * composite.c (Fcomposition_get_gstring): No longer static.
2218 * callproc.c (Fgetenv_internal): No longer static.
2219
2220 * ccl.h: Remove EXFUNs.
2221 * buffer.h: Remove EXFUNs.
2222 * dispextern.h: Remove EXFUNs.
2223 * intervals.h: Remove EXFUNs.
2224 * fontset.h: Remove EXFUN.
2225 * font.h: Remove EXFUNs.
2226 * dosfns.c (system_process_attributes): Remove EXFUN.
2227 * keymap.h: Remove EXFUNs.
2228 * lisp.h: Remove EXFUNs.
2229 * w32term.h: Remove EXFUNs.
2230 * window.h: Remove EXFUNs.
2231 * xsettings.h: Remove EXFUN.
2232 * xterm.h: Remove EXFUN.
2233
8e4fd1e1
GM
22342012-07-03 Glenn Morris <rgm@gnu.org>
2235
2236 * lisp.h (Frandom): Make it visible to C.
2237 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
2238 buffer for invisible buffers. (Bug#1229)
2239
ca95b3eb
DA
22402012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2241
2242 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
2243 values which aren't power of 2.
2244 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
2245 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
2246 accordingly.
2247
7555c33f
SM
22482012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
2249
2250 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
2251
2252 * alloc.c (mark_object): Revert part of last patch to use `switch'.
2253
d12e8f5a
DA
22542012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2255
2256 * alloc.c (allocate_vector_block): Remove redundant
2257 calls to mallopt if DOUG_LEA_MALLOC is defined.
2258 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
2259 avoid calls to mallopt if zero_vector is returned.
2260
296094c3
DA
22612012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2262
2263 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
2264 is enabled, avoid dereferencing NULL current_sblock if
2265 running undumped.
2266
36429c89
DA
22672012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2268
2269 Cleanup basic buffer management.
2270 * buffer.h (struct buffer): Change layout to use generic vector
2271 marking code. Fix some comments. Change type of 'clip_changed'
2272 to bitfield. Remove unused #ifndef old.
2273 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
2274 (GET_OVERLAYS_AT): Fix indentation.
2275 (for_each_per_buffer_object_at): New macro.
2276 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
2277 (Fbuffer_local_variables): Use it.
2278 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
2279 * alloc.c (allocate_buffer): Adjust to match new layout of
2280 struct buffer. Fix comment.
2281 (mark_overlay): New function.
2282 (mark_buffer): Use it. Use mark_vectorlike to mark normal
2283 Lisp area of struct buffer.
2284 (mark_object): Use it. Adjust marking of misc objects
2285 and related comments.
2286
3b3e4cac
PE
22872012-07-02 Paul Eggert <eggert@cs.ucla.edu>
2288
2289 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
2290 wrapper that is not needed because the wrapped code is a no-op (zero
2291 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
2292 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
2293
cf5c0175
DA
22942012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
2295
2296 * alloc.c (mark_buffer): Simplify. Remove prototype.
2297 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 2298 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
2299 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
2300 redundant calls to mark_vectorlike for bool vectors.
2301
ca26824c
GM
23022012-06-30 Glenn Morris <rgm@gnu.org>
2303
2e4c5312
GM
2304 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
2305
ca26824c
GM
2306 * epaths.in (PATH_SITELOADSEARCH): New.
2307 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
2308 This is rather than relying on --enable-locallisppath elements
2309 having "site-lisp" in their names. (Bug#10208#25, 11658)
2310
0d23c240
EZ
23112012-06-30 Eli Zaretskii <eliz@gnu.org>
2312
c9240d7a
EZ
2313 * w32proc.c (sys_select): Accept and ignore one more argument.
2314
2315 * w32.c (emacs_gnutls_pull): Call select with one more argument.
2316
0d23c240 2317 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 2318 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
2319
2320 * sysdep.c: Don't include dos.h and dosfns.h.
2321
2322 * process.c (sys_select):
2323 * msdos.c (sys_select): Accept one more argument and ignore it.
2324
2325 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
2326 adapt data types and code to that.
2327
2328 * dosfns.c:
2329 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
2330 which clashes with the gnulib function of the same name.
2331
af5a5a98
AS
23322012-06-30 Andreas Schwab <schwab@linux-m68k.org>
2333
c5e4379c
AS
2334 * font.c (font_style_to_value, font_style_symbolic)
2335 (font_prop_validate_style): Add type checks for values in
2336 font_style_table.
2337
af5a5a98
AS
2338 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
2339 argument.
2340 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
2341 uses.
2342
8d38f461
EZ
23432012-06-29 Eli Zaretskii <eliz@gnu.org>
2344
2e5a6631
EZ
2345 * xdisp.c (try_window_id): Undo last change.
2346
8d38f461
EZ
2347 * w32.c (getwd): Adjust commentary about startup_dir.
2348 (init_environment): Always call sys_access, even in non-MSVC
2349 builds. Don't chdir to the directory of the Emacs executable.
2350 This undoes code from 1997 which was justified by the need to
2351 "avoid conflicts when removing and renaming directories". But its
2352 downside was that every relative file name was being interpreted
2353 relative to the directory of the Emacs executable, which can never
2354 be TRT. In particular, it broke sys_access when called with
2355 relative file names.
2356 (sys_access): Map GetLastError to errno.
2357
2af3565e
DA
23582012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2359
2360 * window.h (struct window): Change type of 'fringes_outside_margins'
2361 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 2362 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
2363 Adjust comment.
2364 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
2365 to ptrdiff_t.
2366
c8d3a25c 23672012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 2368
c8d3a25c
GM
2369 * gnutls.c (emacs_gnutls_handshake):
2370 Add QUIT to make the loop interruptible.
57570cd3 2371
c8d3a25c 23722012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 2373
c8d3a25c
GM
2374 * charset.c (init_charset): Make lack of etc/charsets fatal.
2375
3e984ee8
DA
23762012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2377
2378 * editfns.c (region_limit): Fix type mismatch.
2379
ef884f23
DA
23802012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2381
2382 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
2383 undefined. Convert from xassert to eassert.
2384 * nsmenu.m: Convert from xassert to eassert.
2385 * nsterm.m: Likewise.
2386
7d7e0027
SM
23872012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
2388
2389 * editfns.c (region_limit): Clip to narrowing (bug#11770).
2390
aa754e6a
PE
23912012-06-28 Paul Eggert <eggert@cs.ucla.edu>
2392
2393 Avoid integer overflow on scroll-left and scroll-right.
2394 * window.c (HSCROLL_MAX): New macro.
2395 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
2396 overflow when requested scroll falls outside ptrdiff_t range.
2397
80b00b08
DA
23982012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2399
2400 * window.h (struct window): Change type of 'hscroll',
2401 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
2402 'last_modified' and 'last_overlay_modified' to EMACS_INT.
2403 Adjust users accordingly.
2404 * xdisp.c (try_cursor_movement): Replace type check with eassert.
2405 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
2406 from EMACS_INT to ptrdiff_t.
2407 (make_window): Omit redundant initialization.
2408
62b2bcf6
JB
24092012-06-28 Juanma Barranquero <lekktu@gmail.com>
2410
2411 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
2412
45942c7d
DA
24132012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2414
2415 * window.h (struct window): Change type of 'use_time' and
2416 'sequence_number' from Lisp_Object to int.
2417 * frame.c (make_frame): Adjust users accordingly.
2418 * print.c (print_object): Likewise.
2419 * window.c (select_window, Fwindow_use_time, make_parent_window)
2420 (make_window): Likewise.
2421
e509cfa6
DA
24222012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2423
2424 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
2425 enabled with --enable-checking=[all,glyphs] configure option.
2426 Fix GLYPH_DEBUG usage assuming that it may be undefined,
2427 adjust comments accordingly.
2428 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
2429 undefined, adjust comments accordingly.
2430 * image.c: Likewise.
2431 * scroll.c: Likewise.
2432 * w32fns.c: Likewise.
2433 * w32term.c: Likewise.
2434 * xdisp.c: Likewise.
2435 * xfaces.c: Likewise.
2436 * xfns.c: Likewise.
2437 * xterm.c: Likewise.
2438
a54e2c05
DA
24392012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2440
2441 Generalize run-time debugging checks.
2442 * dispextern.h (XASSERTS): Remove.
2443 * fontset.c (xassert): Remove.
2444 Convert from xassert to eassert.
2445 * alloc.c: Convert from xassert to eassert.
2446 * bidi.c: Likewise.
2447 * dispnew.c: Likewise.
2448 * fns.c: Likewise.
2449 * fringe.c: Likewise.
2450 * ftfont.c: Likewise.
2451 * gtkutil.c: Likewise.
2452 * image.c: Likewise.
2453 * keyboard.c: Likewise.
2454 * menu.c: Likewise.
2455 * process.c: Likewise.
2456 * scroll.c: Likewise.
2457 * sound.c: Likewise.
2458 * term.c: Likewise.
2459 * w32console.c: Likewise.
2460 * w32fns.c: Likewise.
2461 * w32term.c: Likewise.
2462 * window.c: Likewise.
2463 * xdisp.c: Likewise.
2464 * xfaces.c: Likewise.
2465 * xfns.c: Likewise.
2466 * xselect.c: Likewise.
2467 * xterm.c: Likewise.
2468
1ec4b7b2
SM
24692012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
2470
2471 * fns.c (maybe_resize_hash_table): Output message when growing the
2472 purify-hashtable.
2473
2014308a
DA
24742012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2475
2476 * alloc.c (allocate_string_data): Remove dead code.
2477 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
2478 avoid GCC warning about unused macro.
2479
246155eb
DA
24802012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2481
2482 * alloc.c (allocate_string): Omit intervals initialization.
2483 * alloc.c (make_uninit_multibyte_string): Initialize intervals
2484 as in make_pure_string and make_pure_c_string.
2485
43184b7b
DA
24862012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2487
d209e2fb 2488 * alloc.c (allocate_string): Fix last change.
43184b7b 2489
3fe6dd74
DA
24902012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2491
d209e2fb 2492 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
2493 to memset, add explicit initialization where appropriate.
2494
1ba6038a
GM
24952012-06-27 Glenn Morris <rgm@gnu.org>
2496
2497 * lisp.mk (lisp): Remove paths.elc.
2498
c89926a5
CY
24992012-06-27 Chong Yidong <cyd@gnu.org>
2500
2501 * doc.c (Fsubstitute_command_keys): Fix punctuation.
2502
ed6b3510
JW
25032012-06-26 John Wiegley <johnw@newartisans.com>
2504
1ec4b7b2 2505 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
2506 on Mac OS X Lion: __mod_init_func and __mod_term_func.
2507
ed6b3510
JW
2508 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
2509 when building with Clang.
2510
8edd4a2b
SM
25112012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
2512
2513 * eval.c (Fapply): Allow calling it with a single argument.
2514
f6f62d1b
EZ
25152012-06-26 Eli Zaretskii <eliz@gnu.org>
2516
2517 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
2518 _stricmp and _strnicmp.
2519 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
2520
62efea5e
DA
25212012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2522
2523 * alloc.c (allocate_window): Zero out non-Lisp part of newly
2524 allocated window.
2525 (allocate_process): Likewise for new process.
8edd4a2b 2526 (allocate_terminal): Change to use offsetof.
62efea5e
DA
2527 (allocate_frame): Likewise.
2528 * frame.c (make_frame): Omit redundant initialization.
2529 * window.c (make_parent_window): Use memset.
2530 (make_window): Omit redundant initialization.
2531 * process.c (make_process): Omit redundant initialization.
2532 * terminal.c (create_terminal): Likewise.
2533
42997f4d
DA
25342012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2535
2536 * term.c (delete_tty): Remove redundant call to memset.
2537
1130ecfc
DA
25382012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2539
2540 * alloc.c: Remove build_string.
2541 * lisp.h: Define build_string as static inline. This provides
2542 a better opportunity to optimize away calls to strlen when the
2543 function is called with compile-time constant argument.
2544 * image.c (imagemagick_error): Convert to build_string.
2545 * w32proc.c (sys_spawnve): Likewise.
2546 * xterm.c (x_term_init): Likewise.
2547
cf38a720
PE
25482012-06-26 Paul Eggert <eggert@cs.ucla.edu>
2549
99027bdd
PE
2550 Use sprintf return value instead of invoking strlen on result.
2551 In the old days this wasn't portable, since some sprintf
2552 implementations returned char *. But they died out years ago and
2553 Emacs already assumes sprintf returns int.
2554 Similarly for float_to_string.
2555 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
2556 * ccl.c (ccl_driver):
2557 * character.c (string_escape_byte8):
2558 * data.c (Fnumber_to_string):
2559 * doprnt.c (doprnt):
2560 * print.c (print_object):
2561 * xdisp.c (message_dolog):
2562 * xfns.c (syms_of_xfns):
2563 Use sprintf or float_to_string result to avoid need to call strlen.
2564 * data.c (Fnumber_to_string):
2565 Use make_unibyte_string, since the string must be ASCII.
2566 * lisp.h, print.c (float_to_string): Now returns int length.
2567 * term.c (produce_glyphless_glyph):
2568 Use sprintf result rather than recomputing it.
2569
cf38a720
PE
2570 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
2571 * Makefile.in (ALL_CFLAGS):
2572 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
2573 * gmalloc.c, regex.c: Include <config.h> unconditionally.
2574
3511c784
DA
25752012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2576
0a08eb21 2577 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
2578 strcasecmp if available.
2579 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
2580
fb7da12e
AS
25812012-06-25 Andreas Schwab <schwab@linux-m68k.org>
2582
2583 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
2584 Avoid comma operator.
2585 * menu.c (push_submenu_start, push_submenu_end)
2586 (push_left_right_boundary, push_menu_pane): Likewise.
2587 * msdos.c (dos_rawgetc): Likewise.
2588
afa2ffd8
DA
25892012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2590
2591 * xfns.c (xic_create_fontsetname): Remove redundant calls
2592 to memset.
2593
b3b4476b
PE
25942012-06-25 Paul Eggert <eggert@cs.ucla.edu>
2595
4495ff38
PE
2596 * gtkutil.c (get_utf8_string): Remove redundant assignment.
2597 sprintf already null-terminates its output.
2598
b3b4476b
PE
2599 * xfns.c (x_window): Remove redundant cast.
2600
b00876c9
DA
26012012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2602
2603 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
2604 `const char *' to `char *' to avoid compiler warning.
2605
d188e26b
PE
26062012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2607
885d1d74
PE
2608 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
2609 instead of truncating it to 63 (admittedly a generous limit).
2610
d188e26b
PE
2611 * process.c: Fix spelling and caps in comments.
2612
e2f560b1
DN
26132012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
2614
e86db54b 2615 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
2616 * sysdep.c (setpgrp): Remove definition, not used in this file.
2617
7583a3a1
JB
26182012-06-24 Juanma Barranquero <lekktu@gmail.com>
2619
2620 * makefile.w32-in: Update dependencies.
2621
696056c2
EZ
26222012-06-24 Eli Zaretskii <eliz@gnu.org>
2623
2624 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
2625 (SYSTIME_H): Add nt/inc/sys/time.h.
2626
2627 * systime.h [WINDOWSNT]: Include sys/time.h.
2628
2629 * s/ms-w32.h (struct timespec): Definition moved from
2630 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
2631
845ca893
PE
26322012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2633
2634 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
2635 * buffer.h (buffer_slot_type_mismatch):
2636 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2637 * eval.c (unwind_to_catch):
2638 * image.c (my_png_error, my_error_exit):
2639 * keyboard.c (quit_throw_to_read_char, user_error)
2640 (Fexit_recursive_edit, Fabort_recursive_edit):
2641 * lisp.h (die, args_out_of_range, args_out_of_range_3)
2642 (wrong_type_argument, buffer_overflow, __executable_start)
2643 (memory_full, buffer_memory_full, string_overflow, Fthrow)
2644 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
2645 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
2646 (fatal):
2647 (child_setup) [!DOS_NT]:
2648 * lread.c (end_of_file_error, invalid_syntax):
2649 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2650 * puresize.h (pure_write_error):
2651 * search.c (matcher_overflow):
2652 * sound.c (sound_perror, alsa_sound_perror):
2653 * sysdep.c, syssignal.h (croak):
2654 * term.c (maybe_fatal, vfatal):
2655 * textprop.c (text_read_only):
2656 * undo.c (user_error):
2657 * unexmacosx.c (unexec_error):
2658 * xterm.c (x_ins_del_lines, x_delete_glyphs):
2659 Use _Noreturn rather than NO_RETURN.
2660 No need for separate decl merely because of _Noreturn.
2661 * sound.c (sound_warning, parse_sound):
2662 Remove unnecessary forward decls.
2663
f1dd8073
PE
26642012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2665
2666 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
2667 * lisp.h (WAIT_READING_MAX): New macro.
2668 * dispnew.c (Fsleep_for, sit_for):
2669 * keyboard.c (kbd_buffer_get_event):
2670 * process.c (Faccept_process_output):
2671 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
2672 This improves on the previous patch, which introduced a bug
2673 when time_t is unsigned and as wide as intmax_t.
2674 See <http://bugs.gnu.org/9000#51>.
2675
b82c1755
EZ
26762012-06-23 Eli Zaretskii <eliz@gnu.org>
2677
2678 * dispnew.c (sit_for, Fsleep_for):
2679 * keyboard.c (kbd_buffer_get_event):
2680 * process.c (Faccept_process_output): Avoid compiler warnings when
2681 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
2682
ca300656
JB
26832012-06-23 Juanma Barranquero <lekktu@gmail.com>
2684
049ec95b
JB
2685 * makefile.w32-in: Update dependencies.
2686
ca300656
JB
2687 * w32.c (ltime): Add return type and declare static.
2688 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
2689
db7b8d06
PE
26902012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2691
2692 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
2693 Privately reported by Herbert J. Skuhra.
2694 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
2695 All uses changed.
2696 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
2697 not make_lisp_timeval, when the argument is of type EMACS_TIME.
2698
0bd8297f
EZ
26992012-06-23 Eli Zaretskii <eliz@gnu.org>
2700
96512555
EZ
2701 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
2702 last argument of make_unibyte_string.
2703
0bd8297f
EZ
2704 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
2705 language ID in the event parameters.
2706
2707 * w32term.c (w32_read_socket): Put the new keyboard codepage into
2708 event.code, not the obscure "character set ID".
2709
63def6b6
CY
27102012-06-23 Chong Yidong <cyd@gnu.org>
2711
2712 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
2713
e8a02204
EZ
27142012-06-23 Eli Zaretskii <eliz@gnu.org>
2715
388cdec0
EZ
2716 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
2717 * w32.c (fdutimens): New function.
2718
2719 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
2720
2721 * s/ms-w32.h (pselect): Redirect to sys_select.
2722
2723 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
2724
e8a02204
EZ
2725 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
2726 in the logic of incrementing and decrementing the value of
2727 use_relocatable_buffers.
2728
d054f3fb
PE
27292012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2730
2731 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
2732 Privately reported by Herbert J. Skuhra.
2733 [__FreeBSD__]: Remove "*/" typo after "#include".
2734 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
2735 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
2736 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
2737 Don't assume EMACS_TIME and struct timeval are the same type.
2738
d35af63c
PE
27392012-06-22 Paul Eggert <eggert@cs.ucla.edu>
2740
2741 Support higher-resolution time stamps (Bug#9000).
2742 The time stamps are only nanosecond-resolution at the C level,
2743 since that's the best that any real-world system supports now.
2744 But they are picosecond-resolution at the Lisp level, as that's
2745 easy, and leaves room for future OS improvements.
2746
2747 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
2748 (LIBES): Use it.
2749
2750 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
2751 Don't get current time unless it's needed.
2752
2753 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
2754 now provides it if it's absent.
2755 (start_atimer): Port to higher-res time stamps.
2756 Check for time stamp overflow. Don't get current time more
2757 often than is needed.
2758
2759 * buffer.h (struct buffer): Buffer modtime now has high resolution.
2760 Include systime.h, not time.h.
2761 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
2762
2763 * dired.c: Include stat-time.h.
2764 (Ffile-attributes): File times now have higher resolution.
2765
2766 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
2767 (struct image): Timestamp now has higher resolution.
2768
2769 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
2770 has at least microseconds now. All uses removed.
2771 (update_frame, update_single_window, update_window, update_frame_1)
2772 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
2773
2774 * editfns.c (time_overflow): Now extern.
2775 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
2776 (float-time, Fformat_time_string, Fcurrent_time_string)
2777 (Fcurrent_time_zone): Accept and generate higher-resolution
2778 time stamps.
2779 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
2780 (decode_time_components, lisp_seconds_argument): New functions.
2781 (make_time): Now static.
2782 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
2783 Report an error if the time is invalid, rather than having the caller
2784 do that.
2785
2786 * fileio.c: Include <stat-time.h>
2787 (Fcopy_file): Copy higher-resolution time stamps.
2788 Prefer to set the time stamp via a file descriptor if that works.
2789 (Fset_file_times, Finsert_file_contents, Fwrite_region)
2790 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
2791 (Fvisited_file_modtime, Fset_visited_file_modtime):
2792 Support higher-resolution time stamps.
2793
2794 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
2795
2796 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
2797
2798 * image.c (prepare_image_for_display, clear_image_cache)
2799 (lookup_image): Port to higer-resolution time stamps.
2800
2801 * keyboard.c (start_polling, bind_polling_period):
2802 Check for time stamp overflow.
2803 (read_char, kbd_buffer_get_event, timer_start_idle)
2804 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
2805 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
2806 Port to higher-resolution time stamps. Do not assume time_t is signed.
2807 (decode_timer): New function. Timers are now vectors of length 9,
2808 not 8, to accommodate the picosecond component.
2809 (timer_check_2): Use it.
2810
2811 * nsterm.m (select_timeout, timeval_subtract): Remove.
2812 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
2813 as they're a bit more accurate and handle overflow better.
2814 (ns_select): Change prototype to be compatible with pselect.
2815 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
2816 * nsterm.h (ns_select): Adjust prototype.
2817
2818 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
2819 us-resolution time stamps.
2820 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
2821
2822 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
2823
2824 * lisp.h (time_overflow): New decl.
2825 (wait_reading_process_output): First arg is now intmax_t, not int,
2826 to accommodate larger waits.
2827
2828 * process.h (struct Lisp_Process.read_output_delay):
2829 Now counts nanoseconds, not microseconds.
2830 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
2831 EMACS_HAS_USECS.
2832 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
2833 (wait_reading_process_output):
2834 Port to ns-resolution time stamps.
2835 (Faccept_process_output, wait_reading_process_output):
2836 Check for time stamp overflow. Do not assume time_t is signed.
2837 (select_wrapper): Remove; we now use pselect.
2838 (Fprocess_attributes): Now generates ns-resolution time stamps.
2839
2840 * sysdep.c: Include utimens.h. Don't include utime.h
2841 or worry about struct utimbuf; gnulib does that for us now.
2842 (gettimeofday): Remove; gnulib provides a substitute.
2843 (make_timeval): New function.
2844 (set_file_times): Now sets ns-resolution time stamps.
2845 New arg FD; all uses changed.
2846 (time_from_jiffies, ltime_from_jiffies, get_up_time)
2847 (system_process_attributes):
2848 Now returns ns-resolution time stamp. All uses changed.
2849 Check for time stamp overflow.
2850
2851 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
2852 provides a substitute now.
2853
2854 * systime.h: Include timespec.h rather than sys/time.h and time.h,
2855 since it guarantees struct timespec.
2856 (EMACS_TIME): Now struct timespec, so that we can support
2857 ns-resolution time stamps.
2858 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
2859 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
2860 (EMACS_USECS): Remove.
2861 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
2862 so multiply the arg by 1000 before storing it.
2863 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
2864 New macros.
2865 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
2866 Port to ns-resolution time stamps.
2867 (EMACS_TIME_NEG_P): Remove; replaced by....
2868 (EMACS_TIME_SIGN): New macro.
2869 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
2870 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
2871 (set_file_times, make_time, lisp_time_argument): Adjust signature.
2872 (make_timeval, make_lisp_time, decode_time_components): New decls.
2873 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
2874 that it mishandled time_t overflow. You can't compare by subtracting!
2875 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
2876 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
2877
2878 * term.c: Include <sys/time.h>.
2879 (timeval_to_Time): New function, for proper overflow wraparound.
2880 (term_mouse_position, term_mouse_click): Use it.
2881
2882 * undo.c (record_first_change): Support higher-resolution time stamps
2883 in the undo buffer.
2884 (Fprimitive_undo): Use them when restoring time stamps.
2885
2886 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
2887 (w32_get_internal_run_time):
2888 Port to higher-resolution Emacs time stamps.
2889 (ltime): Now accepts single 64-bit integer, as that's more convenient
2890 for callers.
2891
2892 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
2893
2894 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
2895 for compatibility with pselect. Support ns-resolution time stamps.
2896
2897 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
2898
2899 * xselect.c (wait_for_property_change, x_get_foreign_selection):
2900 Check for time stamp overflow, and support ns-resolution time stamps.
2901
2902 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
2903 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
2904 (timeval_subtract): Remove; no longer needed.
2905 (XTflash, XTring_bell, x_wait_for_event):
2906 Port to ns-resolution time stamps. Don't assume time_t is signed.
2907
b6a92dfe
CY
29082012-06-22 Chong Yidong <cyd@gnu.org>
2909
2910 * xdisp.c (x_consider_frame_title): Revert last change.
2911
d251c37c
EZ
29122012-06-22 Eli Zaretskii <eliz@gnu.org>
2913
2914 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
2915 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
2916 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
2917 staticidx goes up to 1597 out of 1600 = 0x640.)
2918
f10deafb
PE
29192012-06-20 Paul Eggert <eggert@cs.ucla.edu>
2920
2921 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
2922 Otherwise, the umask might be mistakenly 0 while handling input signals.
2923
ec6de1e2
SM
29242012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
2925
2926 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
2927
28be1ada
DA
29282012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
2929
2930 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
2931 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
2932 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
2933 access to `contents' member of Lisp_Vector objects with AREF and ASET
2934 where appropriate.
2935
c6bf3022
CY
29362012-06-19 Chong Yidong <cyd@gnu.org>
2937
2938 * frame.c (delete_frame): When selecting a frame on a different
2939 text terminal, do not alter the terminal's top-frame.
2940
2941 * xdisp.c (format_mode_line_unwind_data): Record the target
2942 frame's selected window and its terminal's top-frame.
2943 (unwind_format_mode_line): Restore them.
2944 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
2945 Callers changed.
2946 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
2947 since tty frames can be explicitly named.
2948 (prepare_menu_bars): Likewise.
2949
2950 * term.c (Ftty_top_frame): New function.
2951
defd4196
PE
29522012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2953
2954 Port byte-code-meter to modern targets.
2955 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
2956 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 2957 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
2958 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
2959 (METER_1, METER_2): Simplify.
2960
1053a871
SM
29612012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
2962
2963 * data.c (Fdefalias): Return `symbol' (bug#11686).
2964
b7e8d081
MR
29652012-06-18 Martin Rudalics <rudalics@gmx.at>
2966
2967 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
2968 gets killed during executing of this function (Bug#11665).
2969 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
2970 (Vkill_buffer_query_functions): In doc-string say that functions
2971 run by this hook should not change the current buffer.
2972
7ea2b339
PE
29732012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2974
2975 Fix recently-introduced process.c problems found by static checking.
2976 * process.c (write_queue_push, write_queue_pop, send_process):
2977 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
2978 (write_queue_pop): Fix pointer signedness problem.
2979 (send_process): Remove unused local.
2980
96a313a1
CY
29812012-06-17 Chong Yidong <cyd@gnu.org>
2982
2983 * xdisp.c (redisplay_internal): No need to redisplay terminal
2984 frames that are not on top.
2985
20ca2e94
TN
29862012-06-17 Troels Nielsen <bn.troels@gmail.com>
2987
2988 * process.c (make_process): Initialize write_queue.
2989 (write_queue_push, write_queue_pop): New functions.
2990 (send_process): Use them to maintain correct ordering of process
2991 writes (Bug#10815).
2992
9a900ca9
PE
29932012-06-17 Paul Eggert <eggert@cs.ucla.edu>
2994
310fbfa8
PE
2995 * lisp.h (eassert): Assume C89 or later.
2996 This removes the need for CHECK.
2997 (CHECK): Remove. Its comments about always evaluating its
2998 argument were confusing, as 'eassert' typically does not evaluate
2999 its argument.
3000
27bb1ca4
PE
3001 * coding.c (produce_chars): Use ptrdiff_t, not int.
3002
9a900ca9
PE
3003 * xterm.c (x_draw_underwave): Check for integer overflow.
3004 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
3005
41b7f8bc 30062012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
3007
3008 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
3009 referenced (Bug#11583).
3010
9b0e3eba
AA
30112012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
3012
3013 Implement wave-style variant of underlining.
3014 * dispextern.h (face_underline_type): New enum.
3015 (face): Add field for underline type.
3016 * nsterm.m (ns_draw_underwave): New function.
3017 (ns_draw_text_decoration): Use it.
3018 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
3019 New functions.
3020 (x_draw_glyph_string): Use them.
3021 * xfaces.c (Qline, Qwave): New Lisp objects.
3022 (check_lface_attrs, merge_face_ref)
1053a871
SM
3023 (Finternal_set_lisp_face_attribute, realize_x_face):
3024 Handle wave-style underline face attributes.
9b0e3eba
AA
3025 * xterm.c (x_draw_underwave): New function.
3026 (x_draw_glyph_string): Use it.
3027
0fb52f11
JB
30282012-06-16 Juanma Barranquero <lekktu@gmail.com>
3029
3030 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
3031 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
3032 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
3033 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
3034 ($(BLD)/w32select.$(O)): Update dependencies.
3035
e5560ff7
AS
30362012-06-16 Andreas Schwab <schwab@linux-m68k.org>
3037
3038 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
3039 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
3040 * character.c (_fetch_multibyte_char_p): Remove.
3041 * alloc.c: Include "character.h" before "buffer.h".
3042 * bidi.c: Likewise.
3043 * buffer.c: Likewise.
3044 * bytecode.c: Likewise.
3045 * callint.c: Likewise.
3046 * callproc.c: Likewise.
3047 * casefiddle.c: Likewise.
3048 * casetab.c: Likewise.
3049 * category.c: Likewise.
3050 * cmds.c: Likewise.
3051 * coding.c: Likewise.
3052 * composite.c: Likewise.
3053 * dired.c: Likewise.
3054 * dispnew.c: Likewise.
3055 * doc.c: Likewise.
3056 * dosfns.c: Likewise.
3057 * editfns.c: Likewise.
3058 * emacs.c: Likewise.
3059 * fileio.c: Likewise.
3060 * filelock.c: Likewise.
3061 * font.c: Likewise.
3062 * fontset.c: Likewise.
3063 * fringe.c: Likewise.
3064 * indent.c: Likewise.
3065 * insdel.c: Likewise.
3066 * intervals.c: Likewise.
3067 * keyboard.c: Likewise.
3068 * keymap.c: Likewise.
3069 * lread.c: Likewise.
3070 * macros.c: Likewise.
3071 * marker.c: Likewise.
3072 * minibuf.c: Likewise.
3073 * nsfns.m: Likewise.
3074 * nsmenu.m: Likewise.
3075 * print.c: Likewise.
3076 * process.c: Likewise.
3077 * regex.c: Likewise.
3078 * region-cache.c: Likewise.
3079 * search.c: Likewise.
3080 * syntax.c: Likewise.
3081 * term.c: Likewise.
3082 * textprop.c: Likewise.
3083 * undo.c: Likewise.
3084 * unexsol.c: Likewise.
3085 * w16select.c: Likewise.
3086 * w32fns.c: Likewise.
3087 * w32menu.c: Likewise.
3088 * window.c: Likewise.
3089 * xdisp.c: Likewise.
3090 * xfns.c: Likewise.
3091 * xmenu.c: Likewise.
3092 * xml.c: Likewise.
3093 * xselect.c: Likewise.
3094
2f07e6af
EZ
30952012-06-16 Eli Zaretskii <eliz@gnu.org>
3096
1053a871
SM
3097 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
3098 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 3099 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
3100 row.
3101 (handle_face_prop): Use chunk-relative overlay string index when
3102 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
3103 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
3104 the rightmost. (Bug#11720)
2f07e6af 3105
29b83cec
AS
31062012-06-16 Andreas Schwab <schwab@linux-m68k.org>
3107
3108 * category.h (CHAR_HAS_CATEGORY): Define as inline.
3109 (CATEGORY_MEMBER): Enforce 1/0 value.
3110 * category.c (_temp_category_set): Remove.
3111
4c5501e9
EZ
31122012-06-16 Eli Zaretskii <eliz@gnu.org>
3113
3114 * window.c (Fdelete_other_windows_internal)
3115 (Fdelete_window_internal): Don't access frame's mouse highlight
3116 info of the initial frame. (Bug#11677)
3117
2b570124
PE
31182012-06-14 Paul Eggert <eggert@cs.ucla.edu>
3119
e93864f9
PE
3120 * .gdbinit (xgetint): Fix recently-introduced paren typo.
3121 Assume USE_2_TAGS_FOR_INTS.
3122 (xreload): Adjust $tagmask width to match recent lisp.h change.
3123
2b570124
PE
3124 Simplify lisp.h in minor ways that should not affect code.
3125 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
3126 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
3127 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
3128 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
3129 (INTTYPEBITS): New macro, for clarity.
3130 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
3131 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
3132 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
3133 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
3134 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
3135
81755f69
JB
31362012-06-13 Juanma Barranquero <lekktu@gmail.com>
3137
3138 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
3139
16192a57
GM
31402012-06-13 Glenn Morris <rgm@gnu.org>
3141
3142 * s/bsd-common.h (BSD4_3):
3143 * s/usg5-4-common.h (USG5_4): No longer define; unused.
3144
646b5f55
AS
31452012-06-13 Andreas Schwab <schwab@linux-m68k.org>
3146
3147 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
3148 instead of union.
3149 (XLI, XIL): Define.
1053a871
SM
3150 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
3151 Use them.
3152 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 3153 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 3154 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
3155 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
3156 * frame.c (delete_frame): Remove outdated comment.
3157 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
3158 USE_LISP_UNION_TYPE.
3159 (Fw32_unregister_hot_key): Likewise.
3160 (Fw32_toggle_lock_key): Likewise.
3161 * w32menu.c (add_menu_item): Likewise.
3162 (w32_menu_display_help): Use XIL instead of checking
3163 USE_LISP_UNION_TYPE.
3164 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
3165 (init_heap): Likewise.
3166 * w32term.c (w32_read_socket): Update comment.
3167
1d3823c9
GM
31682012-06-13 Glenn Morris <rgm@gnu.org>
3169
c62ff706
GM
3170 * s/usg5-4-common.h, src/s/unixware.h:
3171 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
3172
1d3823c9
GM
3173 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
3174
bfe3e0a2
PE
31752012-06-13 Paul Eggert <eggert@cs.ucla.edu>
3176
3177 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
3178 * alloc.c (make_number) [!defined make_number]:
3179 Remove, as lisp.h always defines this now.
3180 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
3181 (roundup_size): Verify that it is a power of 2.
3182 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
3183 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
3184 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
3185 -DUSE_LSB_TAG=0, to override the automatically-selected default.
3186 USE_LSB_TAG now is always defined to be either 0 or 1.
3187 All uses changed.
3188 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
3189 code works fine either way, and efficiency is not a concern here,
3190 as the union type is for debugging, not for production.
3191 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
3192 Use an inline function on all platforms when using the union type,
3193 since this is simpler and 'static inline' can be used portably
3194 within Emacs now.
3195 (LISP_INITIALLY_ZERO): New macro.
3196 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
3197 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
3198
45fa9c0f
GM
31992012-06-12 Glenn Morris <rgm@gnu.org>
3200
b4492cba
GM
3201 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
3202
3203 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 3204
45fa9c0f
GM
3205 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
3206 Move BROKEN_SIGIO to configure.
3207
3208 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
3209 Move NO_TERMIO to configure.
3210
0e25d334
CY
32112012-06-12 Chong Yidong <cyd@gnu.org>
3212
3213 * image.c (imagemagick_load_image): Use MagickFlattenImage if
3214 MagickMergeImageLayers is undefined. Use pixel pusher loop if
3215 MagickExportImagePixels is undefined.
3216
43682bb6
PE
32172012-06-12 Paul Eggert <eggert@cs.ucla.edu>
3218
3219 * image.c (imagemagick_load_image): Remove unused label.
3220
a9be7d2b
GM
32212012-06-11 Glenn Morris <rgm@gnu.org>
3222
3223 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
3224 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
3225 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
3226 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
3227
3017f87f
SM
32282012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
3229
3230 * alloc.c (make_byte_code): New function.
3231 (Fmake_byte_code): Use it. Don't purify here.
3232 * lread.c (read1): Use it as well to avoid extra allocation.
3233
1b9b4cf4
CY
32342012-06-11 Chong Yidong <cyd@gnu.org>
3235
3236 * image.c (imagemagick_load_image): Implement transparency.
3237
95988fcf
AS
32382012-06-10 Andreas Schwab <schwab@linux-m68k.org>
3239
3240 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
3241 account for preceding backslashes. (Bug#11663)
3242
cd4eb164
CY
32432012-06-09 Chong Yidong <cyd@gnu.org>
3244
3245 * term.c: Support italics in capable terminals (Bug#9652).
3246 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
3247 (turn_on_face): Output using TS_enter_italic_mode if available.
3248 Don't handle unused blinking and alt-charset cases.
3249 (turn_off_face): Handle italic case; discard unused tty_blinking_p
3250 and tty_alt_charset_p cases.
3251 (tty_capable_p, init_tty): Support italics.
3252
3253 * termchar.h (struct tty_display_info): Add field for italics.
3254 Remove unused blink field.
3255
3256 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
3257 Handle slant.
3258
3259 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
3260 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
3261 tty_alt_charset_p. Add tty_italic_p.
3262
ff88beb8
MA
32632012-06-09 Michael Albinus <michael.albinus@gmx.de>
3264
3265 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
3266 dbus_type_is_basic if available.
3267 (xd_extract_signed, xd_extract_unsigned): Rename from
3268 extract_signed and extract_unsigned, respectively. Adapt callers.
3269
44286096
CY
32702012-06-09 Chong Yidong <cyd@gnu.org>
3271
1682701f
CY
3272 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
3273
44286096
CY
3274 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
3275 case (Bug#9752).
3276
d86feb17
PE
32772012-06-08 Paul Eggert <eggert@cs.ucla.edu>
3278
3279 * xdisp.c (vmessage): Treat frame message as multibyte.
3280 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
3281 would generate the diagnostic "Making \302\247 buffer-local while
3282 let-bound!".
3283
d5c20fe8
EZ
32842012-06-08 Eli Zaretskii <eliz@gnu.org>
3285
3286 * dispnew.c (showing_window_margins_p): Undo last change, which
3287 was done due to an inadvertent commit.
3288 (adjust_frame_glyphs_for_frame_redisplay): Do call
3289 showing_window_margins_p.
3290
513749ee
SM
32912012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3292
3293 * eval.c (Fmake_var_non_special): New primitive.
3294 (syms_of_eval): Defsubr it.
3295 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
3296
d4a8f5c1
JB
32972012-06-08 Juanma Barranquero <lekktu@gmail.com>
3298
3299 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
3300 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
3301
8bbbc977
EZ
33022012-06-08 Eli Zaretskii <eliz@gnu.org>
3303
3304 * alloc.c (allocate_vectorlike): Fix last change.
3305
f3372c87
DA
33062012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
3307
3308 Block-based vector allocation of small vectors.
3309 * lisp.h (struct vectorlike_header): New field `nbytes',
3310 adjust comment accordingly.
3311 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
3312 to denote vector blocks. Adjust users (live_vector_p,
3313 mark_maybe_pointer, valid_lisp_object_p) accordingly.
3314 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
3315 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
3316 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
3317 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
3318 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
3319 (roundup_size): New constant.
3320 (struct vector_block): New data type.
3321 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 3322 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
3323 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
3324 (sweep_vectors): New functions.
3325 (allocate_vectorlike): Return `zero_vector' as the only vector of
3326 0 items. Allocate new vector from block if vector size is less than
3327 or equal to VBLOCK_BYTES_MAX.
3328 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
3329 (init_alloc_once): Add call to init_vectors.
3330
4f18a4ed
SM
33312012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3332
3333 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
3334
86f158bc
PE
33352012-06-07 Paul Eggert <eggert@cs.ucla.edu>
3336
3337 * doprnt.c (doprnt): Truncate multibyte char correctly.
3338 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
3339 would mishandle a string argument "Xc" if X was a multibyte
3340 character of length 2: it would truncate after X's first byte
3341 rather than including all of X.
3342
c5cfcbe0
CY
33432012-06-06 Chong Yidong <cyd@gnu.org>
3344
3345 * buffer.c (word_wrap): Doc fix.
3346
c05cf390
PE
33472012-06-04 Paul Eggert <eggert@cs.ucla.edu>
3348
3349 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
3350
0c3461de
GM
33512012-06-03 Glenn Morris <rgm@gnu.org>
3352
3353 * xdisp.c (tool-bar-style): Doc fix.
3354
c71232db
UM
33552012-06-03 Ulrich Müller <ulm@gentoo.org>
3356
3357 * Makefile.in (PAXCTL): Define.
3358 (temacs$(EXEEXT)): Disable memory randomization for the temacs
3359 binary via PaX flags if the paxctl utility is available.
3360 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
3361 Restore PaX flags to their default. (Bug#11398)
3362
383f7350
CY
33632012-06-03 Chong Yidong <cyd@gnu.org>
3364
3365 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
3366 buffer (Bug#11226).
3367
5f2c76c6
CY
33682012-06-03 Chong Yidong <cyd@gnu.org>
3369
3370 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
3371 (note_mode_line_or_margin_highlight): If there is no help echo,
3372 use mode-line-default-help-echo. Handle the case where the mouse
3373 position is past the end of the mode line string.
3374
3375 * buffer.c (buffer_local_value_1): New function, split from
3376 Fbuffer_local_value; can return Qunbound.
3377 (Fbuffer_local_value): Use it.
3378 (Vmode_line_format): Docstring tweaks.
3379
773d47f6
PE
33802012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3381
3382 * sysdep.c (system_process_attributes): Improve comment.
3383
f2d6a3df
SM
33842012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
3385
3386 * keyboard.c: Export real-this-command to Elisp.
3387 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
3388 and DEFVAR it. Update all users.
3389
63810350
PE
33902012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3391
7bd5c1f4
PE
3392 * minibuf.c (Fassoc_string): Remove duplicate declaration.
3393
63810350
PE
3394 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
3395 Convert pctcpu and pctmem to Lisp float properly.
3396 Let the compiler fold better, as 100.0/0x8000 is exact.
3397
a2821611
AS
33982012-06-02 Andreas Schwab <schwab@linux-m68k.org>
3399
3400 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
3401 cons_block.
3402
5fceba1d
PE
34032012-06-01 Paul Eggert <eggert@cs.ucla.edu>
3404
3405 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
3406
c98ff5dd
DA
34072012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
3408
3409 For a 'struct window', replace some Lisp_Object fields to
3410 bitfields where appropriate, remove unused fields.
3411 * window.h (struct window): Remove unused 'last_mark_x' and
3412 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
3413 change it's type from Lisp_Object to bitfield.
3414 Change type of 'force_start', 'optional_new_start',
3415 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
3416 fields from Lisp_Object to bitfield. Adjust users accordingly.
3417
ca34e0be
PE
34182012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3419
3420 Pacify gcc -Wdouble-precision when using Xaw.
3421 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
3422 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
3423 Use 'float' consistently, rather than 'float' in most places
3424 and 'double' in a couple of places.
3425
efc00ab1 34262012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
3427
3428 * xdisp.c (handle_stop): Detect whether we have overlay strings
3429 loaded by testing it->current.overlay_string_index to be
3430 non-negative, instead of checking whether n_overlay_strings is
3431 positive. (Bug#11587)
3432
efc00ab1 34332012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
3434
3435 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
3436
3437 * doc.c (Fsubstitute_command_keys): Doc fix.
3438
efc00ab1 34392012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
3440
3441 * search.c (search_buffer): Remove calls to
3442 r_alloc_inhibit_buffer_relocation, as it is now called by
3443 maybe_unify_char, which was the cause of relocation of buffer text
3444 in bug#11519.
3445
efc00ab1 34462012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
3447
3448 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
3449 for the duration of call to load_charset, to avoid problems with
3450 callers of maybe_unify_char that access buffer text through C
3451 pointers.
3452
3453 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
3454 decrement the inhibition flag, instead of just setting or
3455 resetting it.
3456
ba93a187
PE
34572012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3458
3459 Remove obsolete '#define static' cruft.
3460 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
3461 This #undef was "temporary" in 2000; it is no longer needed
3462 now that '#define static' has gone away.
3463 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
3464 (gray_bitmap_bits): Remove; no longer needed.
3465 All uses replaced with definiens.
3466 * xterm.c: Include "bitmaps/gray.xbm".
3467
9e4bf381
PE
34682012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3469
3470 Clean up __executable_start, monstartup when --enable-profiling.
3471 The following changes affect the code only when profiling.
3472 * dispnew.c (__executable_start): Rename from safe_bcopy.
3473 Define only on platforms that need it.
3474 * emacs.c: Include <sys/gmon.h> when profiling.
3475 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
3476 (__executable_start): Remove decl, since lisp.h does it now.
3477 (safe_bcopy): Remove decl; no longer has that name.
3478 (main): Coalesce #if into single bit of code, for simplicity.
3479 Cast pointers to uintptr_t, since standard libraries want integers
3480 and not pointers.
3481 * lisp.h (__executable_start): New decl.
3482
32d72c2f
GM
34832012-05-31 Glenn Morris <rgm@gnu.org>
3484
3485 * image.c (Fimagemagick_types): Doc fix.
3486
baac5bc7
JM
34872012-05-30 Jim Meyering <meyering@redhat.com>
3488
3489 * callproc.c (Fcall_process_region): Include directory component
3490 in mkstemp error message (Bug#11586).
3491
72cb32cf
PE
34922012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3493
3494 * alloc.c, lisp.h (make_pure_vector): Now static.
3495
61b108cc
SM
34962012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
3497
3498 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
3499 Move to byte-run.el.
3500 (Fautoload): Do the hash-doc more carefully.
3501 * data.c (Fdefalias): Purify definition, except for keymaps.
3502 (Qdefun): Move from eval.c.
3503 * lisp.h (Qdefun): Remove.
3504 * lread.c (read1): Tiny simplification.
3505
471fe23d
TN
35062012-05-29 Troels Nielsen <bn.troels@gmail.com>
3507
934f3f58 3508 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
3509 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
3510 Bug#9642, but explicitly check that the buffer the overlay would
3511 be moved to is live and rearrange lines to make sure that errors
3512 will not put the overlay in an inconsistent state.
3513 (Fdelete_overlay): Cosmetics.
3514
85d0efd1
EZ
35152012-05-28 Eli Zaretskii <eliz@gnu.org>
3516
3517 * w32term.c (my_bring_window_to_top): New function.
3518 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
3519 could be different from the original one.
3520 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
3521 (Bug#11513)
3522
3523 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
3524 by calling BringWindowToTop.
3525
3526 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
3527 (WM_EMACS_END): Increase by one.
3528
da92a98c
PE
35292012-05-28 Paul Eggert <eggert@cs.ucla.edu>
3530
3531 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
3532 This avoids undefined behavior that might cause the eassert
3533 to not catch an out-of-range value.
3534
74d1f848
JB
35352012-05-28 Juanma Barranquero <lekktu@gmail.com>
3536
3537 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
3538 Update dependencies.
3539
9e1a06fc
EZ
35402012-05-27 Eli Zaretskii <eliz@gnu.org>
3541
3542 * bidi.c (bidi_mirror_char): Fix last change.
3543
f3dd7312
AS
35442012-05-27 Andreas Schwab <schwab@linux-m68k.org>
3545
3546 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
3547 when referring to sectname field in printf format.
3548
81899c91
PE
35492012-05-27 Paul Eggert <eggert@cs.ucla.edu>
3550
57b81a9f
PE
3551 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
3552 Only r_alloc_inhibit_buffer_relocation needed to be added;
3553 the others were already declared.
3554
81899c91
PE
3555 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
3556 before checking whether it's out of range. Put the check inside
3557 eassert. See
3558 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
3559
33017faf 35602012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
3561
3562 * callproc.c (Fcall_process): Restore a line that was accidentally
3563 commented out in the 2011-02-13 change (bug#11547).
3564
33017faf 35652012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
3566
3567 * lisp.h [REL_ALLOC]: Add prototypes for external functions
3568 defined on ralloc.c.
3569
3570 * buffer.c [REL_ALLOC]: Remove prototypes of
3571 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
3572 they are now on lisp.h.
3573
3574 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
3575
3576 * search.c (search_buffer): Use it to inhibit relocation of buffer
3577 text while re_search_2 is doing its job, because re_search_2 is
3578 passed C pointers to buffer text. (Bug#11519)
3579
23415acf
EZ
3580 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
3581 Update value to 24.
3582
44e27368
EZ
3583 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
3584 state after an additional call to move_it_in_display_line_to, keep
3585 the values of it->max_ascent and it->max_descent found for the
3586 entire line.
3587 (pos_visible_p): Revert the comparison against bottom_y to what it
3588 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
3589 (Bug#11464)
3590
c1892f11
PE
35912012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3592
3593 Fix coding-related core dumps with gcc -ftrapv.
3594 The code was computing A - B, where A and B are pointers, and B is
3595 random garbage. This can lead to core dumps on platforms that
3596 have special pointer registers, and it also leads to core dumps on
3597 x86-64 when compiled with gcc -ftrapv. The fix is to compute
3598 A - B only when B is initialized properly.
3599 * coding.c (coding_set_source, coding_set_destination): Return void.
3600 (coding_change_source, coding_change_destinations): New functions,
3601 with the old behaviors of coding_set_source and coding_set_destination.
3602 All callers that need an offset changed to use these new functions.
3603
eb7afdad
GM
36042012-05-26 Glenn Morris <rgm@gnu.org>
3605
3606 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
3607
f12fdf02
EZ
36082012-05-26 Eli Zaretskii <eliz@gnu.org>
3609
53a63be6 3610 Extend mouse support on W32 text-mode console.
61b108cc
SM
3611 * xdisp.c (draw_row_with_mouse_face):
3612 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 3613
eb3f6f01 3614 * w32console.c: Include window.h.
61b108cc
SM
3615 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
3616 New functions.
eb3f6f01
EZ
3617 (initialize_w32_display): Initialize mouse-highlight data.
3618
53a63be6
EZ
3619 * w32inevt.c: Include termchar.h and window.h.
3620 (do_mouse_event): Support mouse-autoselect-window. When the mouse
3621 moves, call note_mouse_highlight. If help_echo changed, call
3622 gen_help_event to produce help-echo message in the echo area.
3623 Call clear_mouse_face if mouse_face_hidden is set in the mouse
3624 highlight info.
3625
4cfd81f6
PE
36262012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3627
3628 * lread.c (read1): Simplify slightly to avoid an overflow warning
3629 with GCC 4.7.0 on x86-64.
3630
4446092a
EZ
36312012-05-26 Eli Zaretskii <eliz@gnu.org>
3632
3633 * bidi.c (bidi_mirror_char): Revert last change: an int is
3634 definitely wide enough here.
3635
42b2a986 36362012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 3637
42b2a986 3638 Fix integer width and related bugs (Bug#9874).
eb106a49 3639 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
3640 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
3641 (string_bytes, check_sblock, allocate_string_data):
3642 (compact_small_strings, Fmake_bool_vector, make_string)
3643 (make_unibyte_string, make_multibyte_string)
3644 (make_string_from_bytes, make_specified_string)
3645 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
3646 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
3647 (mark_vectorlike):
3648 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3649 (allocate_pseudovector):
3650 Use int, not EMACS_INT, where int is wide enough.
3651 (inhibit_garbage_collection, Fgarbage_collect):
3652 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3653 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
3654 int might not be wide enough.
3655 (bidi_cache_search, bidi_cache_find, bidi_init_it)
3656 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
3657 (bidi_at_paragraph_end, bidi_find_paragraph_start)
3658 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3659 (bidi_level_of_next_char, bidi_move_to_visually_next):
3660 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3661 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
3662 (Fkill_buffer, Fset_buffer_major_mode)
3663 (advance_to_char_boundary, Fbuffer_swap_text)
3664 (Fset_buffer_multibyte, overlays_at, overlays_in)
3665 (overlay_touches_p, struct sortvec, record_overlay_string)
3666 (overlay_strings, recenter_overlay_lists)
3667 (adjust_overlays_for_insert, adjust_overlays_for_delete)
3668 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
3669 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
3670 (Foverlay_recenter, last_overlay_modification_hooks_used)
3671 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
3672 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
3673 (validate_region): Omit unnecessary test for b <= e,
3674 since that's guaranteed by the previous test.
d311d28c
PE
3675 (adjust_overlays_for_delete): Avoid pos + length overflow.
3676 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
3677 (report_overlay_modification):
3678 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3679 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
3680 Omit pointer cast, which isn't needed anyway, and doesn't work
3681 after the EMACS_INT -> ptrdiff_t change.
02481186 3682 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
3683 * buffer.h: Adjust decls to match defn changes elsewhere.
3684 (struct buffer_text, struct buffer):
3685 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3686 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
3687 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
3688 not int, to avoid needless 32-bit limit on 64-bit hosts.
3689 (exec_byte_code): Use tighter memory-full test, one that checks
3690 for alloca overflow. Don't compute the address of the object just
3691 before an array, as that's not portable. Use EMACS_INT, not
3692 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
3693 * callint.c (Fcall_interactively):
3694 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3695 * callproc.c (call_process_kill, Fcall_process):
3696 Don't assume pid_t fits into an Emacs fixnum.
3697 (call_process_cleanup, Fcall_process, child_setup):
3698 Don't assume pid_t fits into int.
3699 (call_process_cleanup, Fcall_process, delete_temp_file)
3700 (Fcall_process_region):
3701 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3702 (Fcall_process): Simplify handling of volatile integers.
3703 Use int, not EMACS_INT, where int will do.
3704 * casefiddle.c (casify_object, casify_region, operate_on_word)
3705 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
3706 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3707 (casify_object): Avoid integer overflow when overallocating buffer.
3708 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 3709 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
3710 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
3711 * category.h (CATEGORYP): Don't assume arg is nonnegative.
3712 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
3713 integers are now checked earlier. All uses replaced with XINT.
3714 (ccl_driver):
3715 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3716 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
3717 (ccl_driver, Fregister_code_conversion_map):
3718 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
3719 (resolve_symbol_ccl_program): Check that vector header is in range.
3720 Always copy the vector, so that we can check its contents reliably
3721 now rather than having to recheck each instruction as it's being
3722 executed. Check that vector words fit in 'int'.
3723 (ccl_get_compiled_code, Fregister_ccl_program)
3724 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
3725 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
3726 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
3727 contents are in range.
3728 (Fccl_execute_on_string): Check that status is in range.
3729 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
3730 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
3731 Accept and return EMACS_INT, not int, because callers can pass values
3732 out of 'int' range.
3733 (c_string_width, strwidth, lisp_string_width, chars_in_text)
3734 (multibyte_chars_in_text, parse_str_as_multibyte)
3735 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
3736 (str_as_unibyte, str_to_unibyte, string_count_byte8)
3737 (string_escape_byte8, Fget_byte):
3738 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 3739 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
3740 avoid mishandling large integers.
3741 * character.h: Adjust decls to match defn changes elsewhere.
3742 * charset.c (load_charset_map_from_file, find_charsets_in_text)
3743 (Ffind_charset_region):
3744 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3745 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
3746 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 3747 Don't assume fixnum fits in int.
d311d28c
PE
3748 (load_charset_map_from_vector, Fmap_charset_chars):
3749 Remove now-unnecessary CHECK_NATNUMs.
3750 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
3751 Don't rely on undefined behavior with signed left shift overflow.
3752 Don't assume unsigned int fits into fixnum, or that fixnum fits
3753 into unsigned int. Don't require max_code to be a valid fixnum;
3754 that's not true for gb10830 4-byte on a 32-bit host. Allow
3755 invalid_code to be a cons, for the same reason. Require code_offset
3756 to be a character. Avoid int overflow if max_char is close
3757 to INT_MAX.
3758 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
3759 this is intended anyway and avoids some undefined behavior.
3760 (load_charset_map): Pass unsigned, not int, as 2nd arg of
3761 INDEX_TO_CODE_POINT, as that's what it expects.
3762 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
3763 * charset.h (DECODE_CHAR): Return int, not unsigned;
3764 this is what was intended anyway, and it avoids undefined behavior.
3765 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
3766 integer-overflow issues.
3767 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
3768 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
3769 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
3770 * chartab.c (Fmake_char_table, Fset_char_table_range)
3771 (uniprop_get_decoder, uniprop_get_encoder):
3772 Don't assume fixnum fits in int.
3773 * cmds.c (move_point): New function, that does the gist of
3774 Fforward_char and Fbackward_char, but does so while checking
3775 for integer overflow more accurately.
c96e5d6a 3776 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
3777 (Fforward_line, Fend_of_line, internal_self_insert)
3778 (internal_self_insert):
3779 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3780 Fix a FIXME, by checking for integer overflow when calculating
3781 target_clm and actual_clm.
3782 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 3783 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
3784 (ASSURE_DESTINATION, coding_alloc_by_realloc)
3785 (coding_alloc_by_making_gap, alloc_destination)
3786 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
3787 (encode_coding_utf_16, detect_coding_emacs_mule)
3788 (decode_coding_emacs_mule, encode_coding_emacs_mule)
3789 (detect_coding_iso_2022, decode_coding_iso_2022)
3790 (encode_invocation_designation, encode_designation_at_bol)
3791 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3792 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
3793 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
3794 (encode_coding_ccl, encode_coding_raw_text)
3795 (detect_coding_charset, decode_coding_charset)
3796 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
3797 (produce_composition, produce_charset, produce_annotation)
3798 (decode_coding, handle_composition_annotation)
3799 (handle_charset_annotation, consume_chars, decode_coding_gap)
3800 (decode_coding_object, encode_coding_object, detect_coding_system)
3801 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
3802 (code_convert_region, code_convert_string)
8f50130c
PE
3803 (Fdefine_coding_system_internal)
3804 (coding_set_source, coding_set_destination):
d311d28c
PE
3805 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3806 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
3807 (Fdefine_coding_system_internal):
3808 Don't assume fixnums fit in int.
3809 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 3810 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
3811 (Funencodable_char_position, Fcheck_coding_systems_region)
3812 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 3813 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 3814 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 3815 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 3816 Don't access memory outside of the args array.
d311d28c 3817 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
3818 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
3819 result of ENCODE_CHAR.
d311d28c
PE
3820 * coding.h: Adjust decls to match defn changes elsewhere.
3821 (struct coding_system):
3822 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3823 * composite.c (get_composition_id, find_composition)
3824 (run_composition_function, update_compositions)
3825 (compose_text, composition_gstring_put_cache)
3826 (composition_gstring_p, composition_gstring_width)
3827 (fill_gstring_header, fill_gstring_body, autocmp_chars)
3828 (composition_compute_stop_pos, composition_reseat_it)
3829 (composition_update_it, struct position_record)
3830 (find_automatic_composition, composition_adjust_point)
3831 (Fcomposition_get_gstring, Ffind_composition_internal):
3832 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3833 (update_compositions):
3834 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3835 * composite.h: Adjust decls to match defn changes elsewhere.
3836 (struct composition):
3837 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3838 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
3839 Do not attempt to compute the address of the object just before a
3840 buffer; this is not portable.
3841 (Faref, Faset):
3842 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3843 (Faset): Use int, not EMACS_INT, where int is wide enough.
3844 (Fstring_to_number): Don't assume fixnums fit in int.
3845 (Frem): Don't assume arg is nonnegative.
3846 * dbusbind.c (xd_append_arg): Check for integers out of range.
3847 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 3848 (extract_signed, extract_unsigned): New functions.
243e0530
PE
3849 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
3850 (xd_get_connection_references): Return ptrdiff_t, not int.
3851 All uses changed.
3852 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
3853 (xd_read_message_1):
3854 Use int, not unsigned, where the dbus API uses int.
3855 (Fdbus_message_internal): Don't overflow mtype.
3856 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
3857 * dired.c (directory_files_internal, file_name_completion, scmp)
3858 (file_name_completion_stat):
3859 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3860 (file_name_completion): Don't overflow matchcount.
3861 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
3862 * dispextern.h: Adjust decls to match defn changes elsewhere.
3863 (struct text_pos, struct glyph, struct bidi_saved_info)
3864 (struct bidi_string_data, struct bidi_it, struct composition_it)
3865 (struct it):
3866 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3867 (struct display_pos, struct composition_it, struct it):
3868 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3869 * dispnew.c (increment_matrix_positions)
3870 (increment_row_positions, mode_line_string)
3871 (marginal_area_string):
3872 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 3873 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
3874 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3875 (duration_to_sec_usec): New function, to check for overflow better.
3876 (Fsleep_for, sit_for): Use it.
3877 * doc.c (get_doc_string, store_function_docstring):
3878 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3879 (get_doc_string, Fsnarf_documentation):
3880 Use int, not EMACS_INT, where int is wide enough.
3881 (get_doc_string):
3882 Use SAFE_ALLOCA, not alloca.
3883 Check for overflow when converting EMACS_INT to off_t.
3884 * doprnt.c (doprnt):
3885 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3886 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
3887 Don't assume uid_t fits into fixnum.
3888 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
3889 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
3890 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
3891 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
3892 (general_insert_function)
3893 (Finsert_char, make_buffer_string, make_buffer_string_both)
3894 (update_buffer_properties, Fbuffer_substring)
3895 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
3896 (Fsubst_char_in_region, check_translation)
3897 (Ftranslate_region_internal, save_restriction_restore, Fformat)
3898 (transpose_markers, Ftranspose_regions):
3899 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3900 (clip_to_bounds): Move to lisp.h as an inline function).
3901 (Fconstrain_to_field): Don't assume integers are nonnegative.
3902 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
3903 (Fsubst_char_in_region, Fsave_restriction):
3904 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3905 (Femacs_pid): Don't assume pid_t fits into fixnum.
3906 (lo_time): Use int, not EMACS_INT, when int suffices.
3907 (lisp_time_argument): Check for usec out of range.
3908 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
3909 (Fuser_login_name, Fuser_full_name): Signal an error
3910 if a uid argument is out of range, rather than relying on
3911 undefined behavior.
c8d5c857
PE
3912 (Fformat_time_string): Remove now-unnecessary check.
3913 lisp_time_argument checks for out-of-range usec now.
243e0530 3914 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
3915 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
3916 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
3917 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
3918 (init_cmdargs, Fdump_emacs):
3919 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3920 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
3921 the bottom (typically) 32 bits of the fixnum.
3922 * eval.c (specpdl_size, call_debugger):
3923 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3924 (when_entered_debugger, Fbacktrace_debug):
3925 Don't assume fixnum can fit in int.
3926 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
3927 the object just before a buffer; this is not portable.
3928 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
3929 (grow_specpdl, unbind_to):
3930 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3931 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
3932 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 3933 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
3934 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
3935 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
3936 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3937 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
3938 (a_write, e_write):
3939 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3940 (Fcopy_file, non_regular_nbytes, read_non_regular)
3941 (Finsert_file_contents):
3942 Use int, not EMACS_INT, where int is wide enough.
3943 (READ_BUF_SIZE): Verify that it fits in int.
3944 (Finsert_file_contents): Check that counts are in proper range,
3945 rather than assuming fixnums fit into ptrdiff_t etc.
3946 Don't assume fixnums fit into int.
125b3835 3947 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
3948 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
3949 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
3950 (string_char_to_byte, string_byte_to_char)
3951 (string_make_multibyte, string_to_multibyte)
3952 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
3953 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
3954 (substring_both, Fdelete, internal_equal, Ffillarray)
3955 (Fclear_string, mapcar1)
3956 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
3957 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
3958 (larger_vector, make_hash_table, maybe_resize_hash_table)
3959 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
3960 (Fmaphash, secure_hash):
3961 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3962 (concat): Check for string index and length overflow.
3963 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
3964 (Frequire):
3965 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3966 (larger_vector): New API (vec, incr_min, size_max) replaces old
3967 one (vec, new_size, init). This catches size overflow.
3968 INIT was removed because it was always Qnil.
3969 All callers changed.
3970 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
3971 the upper bound on a hash table index size.
3972 (make_hash_table, maybe_resize_hash_table): Use it.
3973 (secure_hash): Computer start_byte and end_byte only after
3974 they're known to be in ptrdiff_t range.
3975 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
3976 (Ffont_get_glyphs, Ffont_at):
3977 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3978 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
3979 (Flist_fonts, Fopen_font):
3980 Don't assume fixnum can fit in int.
3981 (check_gstring): Don't assume index can fit in int.
3982 (font_match_p): Check that fixnum is a character, not a nonnegative
3983 fixnum, since the later code needs to stuff it into an int.
3984 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
3985 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
3986 conversion overflow issues.
3987 (Fopen_font): Check for integer out of range.
3988 (Ffont_get_glyphs): Don't assume index can fit in int.
3989 * font.h: Adjust decls to match defn changes elsewhere.
3990 * fontset.c (reorder_font_vector): Redo score calculation to avoid
3991 integer overflow.
3992 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
3993 printmax_t, where ptrdiff_t is wide enough.
3994 (Finternal_char_font):
3995 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3996 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
3997 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
3998 (Fset_frame_position, x_set_frame_parameters)
3999 (x_set_line_spacing, x_set_border_width)
4000 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
4001 Check that fixnums are in proper range for system types.
4002 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
4003 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4004 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
4005 Use SAFE_ALLOCA_LISP, not alloca.
4006 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
4007 intptr_t is wide enough.
4008 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
4009 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
4010 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
4011 Check for fixnum out of range.
4012 * ftfont.c (ftfont_list): Don't assume index fits in int.
4013 Check that fixnums are in proper range for system types.
4014 (ftfont_shape_by_flt):
4015 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
4016 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4017 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4018 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
4019 Check that fixnums are in proper range for system types.
4020 * gnutls.h: Adjust decls to match defn changes elsewhere.
4021 * gtkutil.c (xg_dialog_run):
4022 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4023 (update_frame_tool_bar):
4024 Check that fixnums are in proper range for system types.
4025 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 4026 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
4027 * indent.c (last_known_column, last_known_column_point):
4028 (current_column_bol_cache):
4029 (skip_invisible, current_column, check_display_width):
4030 (check_display_width, scan_for_column, current_column_1)
4031 (Findent_to, Fcurrent_indentation, position_indentation)
4032 (indented_beyond_p, Fmove_to_column, compute_motion):
4033 (Fcompute_motion, Fvertical_motion):
4034 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4035 (last_known_column_modified): Use EMACS_INT, not int.
4036 (check_display_width):
4037 (Fcompute_motion):
4038 Check that fixnums and floats are in proper range for system types.
4039 (compute_motion): Don't assume index or fixnum fits in int.
4040 (compute_motion, Fcompute_motion):
4041 Use int, not EMACS_INT, when it is wide enough.
4042 (vmotion): Omit local var start_hpos that is always 0; that way
4043 we don't need to worry about overflow in expressions involving it.
4044 * indent.h: Adjust decls to match defn changes elsewhere.
4045 (struct position):
4046 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4047 Use int, not EMACS_INT, where int is wide enough.
4048 Remove unused members ovstring_chars_done and tab_offset;
4049 all uses removed.
4050 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
4051 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
4052 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
4053 (make_gap, copy_text, insert, insert_and_inherit)
4054 (insert_before_markers, insert_before_markers_and_inherit)
4055 (insert_1, count_combining_before, count_combining_after)
4056 (insert_1_both, insert_from_string)
4057 (insert_from_string_before_markers, insert_from_string_1)
4058 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
4059 (adjust_after_replace, adjust_after_insert, replace_range)
4060 (replace_range_2, del_range, del_range_1, del_range_byte)
4061 (del_range_both, del_range_2, modify_region)
4062 (prepare_to_modify_buffer, signal_before_change)
4063 (signal_after_change, Fcombine_after_change_execute):
4064 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4065 * intervals.c (traverse_intervals, rotate_right, rotate_left)
4066 (balance_an_interval, split_interval_right, split_interval_left)
4067 (find_interval, next_interval, update_interval)
4068 (adjust_intervals_for_insertion, delete_node, delete_interval)
4069 (interval_deletion_adjustment, adjust_intervals_for_deletion)
4070 (static_offset_intervals, offset_intervals)
4071 (merge_interval_right, merge_interval_left, make_new_interval)
4072 (graft_intervals_into_buffer, temp_set_point_both)
4073 (temp_set_point, set_point, adjust_for_invis_intang)
4074 (set_point_both, move_if_not_intangible, get_property_and_range)
4075 (get_local_map, copy_intervals, copy_intervals_to_string)
4076 (compare_string_intervals, set_intervals_multibyte_1):
4077 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4078 * intervals.h: Adjust decls to match defn changes elsewhere.
4079 (struct interval):
4080 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4081 * keyboard.c (this_command_key_count, this_single_command_key_start)
4082 (before_command_key_count, before_command_echo_length, echo_now)
4083 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
4084 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
4085 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
4086 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
4087 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4088 (last_non_minibuf_size, last_point_position, echo_truncate)
4089 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
4090 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
4091 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
4092 (stuff_buffered_input):
4093 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4094 (last_auto_save, command_loop_1, read_char):
4095 Use EMACS_INT, not int, to avoid integer overflow.
4096 (record_char): Avoid overflow in total_keys computation.
4097 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
4098 * keyboard.h: Adjust decls to match defn changes elsewhere.
4099 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
4100 (Fkey_description, Fdescribe_vector, Flookup_key):
4101 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4102 (click_position): New function, to check that positions are in range.
4103 (Fcurrent_active_maps):
4104 (describe_command):
4105 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4106 (Faccessible_keymaps, Fkey_description):
4107 (preferred_sequence_p):
4108 Don't assume fixnum can fit into int.
4109 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
4110 Check for integer overflow in size calculations.
4111 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
4112 avoid mishandling large integers.
4113 * lisp.h: Adjust decls to match defn changes elsewhere.
4114 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
4115 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
4116 (struct Lisp_Marker):
4117 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4118 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
4119 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
4120 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
4121 All callers changed.
4122 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
4123 Assume the arg has valid form, since it always does.
4124 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
4125 unsigned integer system type.
4126 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
4127 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
4128 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4129 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
4130 (duration_to_sec_usec): New decl.
4131 * lread.c (read_from_string_index, read_from_string_index_byte)
4132 (read_from_string_limit, readchar, unreadchar, openp)
4133 (read_internal_start, read1, oblookup):
4134 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4135 (Fload, readevalloop, Feval_buffer, Feval_region):
4136 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4137 (openp): Check for out-of-range argument to 'access'.
4138 (read1): Use int, not EMACS_INT, where int is wide enough.
4139 Don't assume fixnum fits into int.
6efdadfd 4140 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
4141 (read_filtered_event): Use duration_to_sec_usec
4142 to do proper overflow checking on durations.
d311d28c
PE
4143 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
4144 in size calculation.
4145 (Fexecute_kbd_macro):
4146 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4147 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
4148 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
4149 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
4150 (set_marker_both, set_marker_restricted_both, marker_position)
4151 (marker_byte_position, Fbuffer_has_markers_at):
4152 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4153 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 4154 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
4155 It now merely ensures that the menu is large enough, without
4156 necessarily growing it, as this avoids some integer overflow issues.
4157 All callers changed.
4158 (keymap_panes, parse_single_submenu, Fx_popup_menu):
4159 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4160 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
4161 Use SAFE_ALLOCA_LISP, not alloca.
4162 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
4163 to EMACS_INT. Check that fixnums are in proper range for system types.
4164 * minibuf.c (minibuf_prompt_width, string_to_object)
4165 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
4166 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
4167 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4168 (get_minibuffer, read_minibuf_unwind):
4169 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4170 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
4171 this simplifies overflow checking. All callers changed.
4172 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
4173 (Ftest_completion):
4174 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4175 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
4176 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
4177 Check that fixnums are in proper range for system types.
4178 (Fx_create_frame, Fx_show_tip):
4179 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4180 * nsfont.m (ns_findfonts, nsfont_list_family):
4181 Don't assume fixnum fits in long.
4182 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
4183 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4184 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
4185 wide enough.
17fdb222 4186 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
4187 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4188 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
4189 (PRINTDECLARE, PRINTPREPARE):
4190 (strout, print_string):
4191 (print, print_preprocess, print_check_string_charset_prop)
4192 (print_object):
4193 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4194 (PRINTDECLARE):
4195 (temp_output_buffer_setup, Fprin1_to_string, print_object):
4196 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4197 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 4198 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 4199 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
4200 (print_error_message): Use SAFE_ALLOCA, not alloca.
4201 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
4202 (print_depth, new_backquote_output, print_number_index):
4203 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
4204 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
4205 (Fset_process_window_size, Fformat_network_address)
4206 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 4207 (sigchld_handler):
d311d28c 4208 Check that fixnums are in proper range for system types.
d44287d4 4209 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
4210 Check for process-ids out of pid_t range rather than relying on
4211 undefined behavior.
e4d81efc 4212 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
4213 (Fformat_network_address, read_process_output, send_process)
4214 (Fprocess_send_region, status_notify):
4215 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4216 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
4217 (wait_reading_process_output, read_process_output, exec_sentinel):
4218 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4219 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
4220 (Faccept_process_output): Use duration_to_sec_usec to do proper
4221 overflow checking on durations.
dde14581
PE
4222 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
4223 Don't assume pid_t fits in int.
02481186
PE
4224 * process.h (struct Lisp_Process): Members tick and update_tick
4225 are now of type EMACS_INT, not int.
b62b53e8
PE
4226 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
4227 configured --with-wide-int.
d311d28c
PE
4228 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
4229 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
4230 * search.c (looking_at_1, string_match_1):
4231 (fast_string_match, fast_c_string_match_ignore_case)
4232 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
4233 (scan_newline, find_before_next_newline, search_command)
4234 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
4235 (set_search_regs, wordify):
4236 (Freplace_match):
4237 (Fmatch_data):
4238 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4239 (string_match_1, search_buffer, set_search_regs):
4240 (Fmatch_data):
4241 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4242 (wordify): Check for overflow in size calculation.
4243 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
4244 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
4245 Check that fixnums are in proper range for system types.
4246 * sound.c (struct sound_device)
4247 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
4248 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4249 (Fplay_sound_internal):
4250 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 4251 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
4252 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
4253 (Fparse_partial_sexp):
4254 Don't assume fixnums can fit in int.
4255 (struct lisp_parse_state, find_start_pos, find_start_value)
4256 (find_start_value_byte, find_start_begv)
4257 (update_syntax_table, char_quoted, dec_bytepos)
4258 (find_defun_start, prev_char_comend_first, back_comment):
4259 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
4260 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
4261 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4262 (Finternal_describe_syntax_value): Check that match_lisp is a
4263 character, not an integer, since the code stuffs it into int.
4264 (scan_words, scan_sexps_forward):
4265 Check that fixnums are in proper range for system types.
4266 (Fforward_word):
4267 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4268 (scan_sexps_forward):
4269 Use CHARACTERP, not INTEGERP, since the value must fit into int.
4270 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
4271 * syntax.h: Adjust decls to match defn changes elsewhere.
4272 (struct gl_state_s):
4273 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
4274 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
4275 MOST_POSITIVE_FIXNUM.
d311d28c
PE
4276 * sysdep.c (wait_for_termination_1, wait_for_termination)
4277 (interruptible_wait_for_termination, mkdir):
4278 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
4279 (emacs_read, emacs_write):
4280 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
4281 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
4282 and double all fit in int.
d311d28c
PE
4283 * term.c (set_tty_color_mode):
4284 Check that fixnums are in proper range for system types.
4285 * termhooks.h (struct input_event):
4286 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4287 * textprop.c (validate_interval_range, interval_of)
4288 (Fadd_text_properties, set_text_properties_1)
4289 (Fremove_text_properties, Fremove_list_of_text_properties)
4290 (Ftext_property_any, Ftext_property_not_all)
4291 (copy_text_properties, text_property_list, extend_property_ranges)
4292 (verify_interval_modification):
4293 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4294 (Fnext_single_char_property_change)
4295 (Fprevious_single_char_property_change):
4296 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
4297 (copy_text_properties):
4298 Check for integer overflow in index calculation.
d311d28c
PE
4299 * undo.c (last_boundary_position, record_point, record_insert)
4300 (record_delete, record_marker_adjustment, record_change)
4301 (record_property_change):
4302 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4303 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
4304 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4305 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4306 (Fx_hide_tip, Fx_file_dialog):
4307 * w32menu.c (set_frame_menubar):
4308 Use ptrdiff_t, not int, for consistency with rest of code.
4309 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
4310 (select_window, Fdelete_other_windows_internal)
4311 (window_scroll_pixel_based, window_scroll_line_based)
4312 (Frecenter, Fset_window_configuration):
4313 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4314 (Fset_window_hscroll, run_window_configuration_change_hook)
4315 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 4316 (Fscroll_other_window, Frecenter):
d311d28c
PE
4317 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4318 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
4319 Don't assume fixnum fits in int.
4320 (Fset_window_scroll_bars):
4321 Check that fixnums are in proper range for system types.
4322 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
4323 (string_pos, c_string_pos, number_of_chars, init_iterator)
4324 (in_ellipses_for_invisible_text_p, init_from_display_pos)
4325 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
4326 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
4327 (face_before_or_after_it_pos, handle_invisible_prop)
4328 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
4329 (display_prop_intangible_p, string_buffer_position_lim)
4330 (string_buffer_position, handle_composition_prop, load_overlay_strings)
4331 (get_overlay_strings_1, get_overlay_strings)
4332 (iterate_out_of_display_property, forward_to_next_line_start)
4333 (back_to_previous_visible_line_start, reseat, reseat_to_string)
4334 (get_next_display_element, set_iterator_to_next)
4335 (get_visually_first_element, compute_stop_pos_backwards)
4336 (handle_stop_backwards, next_element_from_buffer)
4337 (move_it_in_display_line_to, move_it_in_display_line)
4338 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4339 (add_to_log, message_dolog, message_log_check_duplicate)
4340 (message2, message2_nolog, message3, message3_nolog
4341 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
4342 (current_message_1, truncate_echo_area, truncate_message_1)
4343 (set_message, set_message_1, store_mode_line_noprop)
4344 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
4345 (text_outside_line_unchanged_p, check_point_in_composition)
4346 (reconsider_clip_changes)
4347 (redisplay_internal, set_cursor_from_row, try_scrolling)
4348 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
4349 (redisplay_window, find_last_unchanged_at_beg_row)
4350 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
4351 (trailing_whitespace_p, find_row_edges, display_line)
4352 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
4353 (display_mode_element, store_mode_line_string)
4354 (pint2str, pint2hrstr, decode_mode_spec)
4355 (display_count_lines, display_string, draw_glyphs)
4356 (x_produce_glyphs, x_insert_glyphs)
4357 (rows_from_pos_range, mouse_face_from_buffer_pos)
4358 (fast_find_string_pos, mouse_face_from_string_pos)
4359 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4360 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4361 (safe_call, init_from_display_pos, handle_fontified_prop)
4362 (handle_single_display_spec, load_overlay_strings)
4363 (with_echo_area_buffer, setup_echo_area_for_printing)
4364 (display_echo_area, echo_area_display)
4365 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
4366 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
4367 (redisplay_window, dump_glyph_row, display_mode_line)
4368 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 4369 (handle_display_spec, display_prop_string_p):
d311d28c
PE
4370 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4371 (handle_single_display_spec, build_desired_tool_bar_string)
4372 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
4373 (get_specified_cursor_type):
4374 Check that fixnums are in proper range for system types.
4375 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
4376 (Flookup_image_map):
4377 Don't assume fixnums fit in int.
4378 (compare_overlay_entries):
4379 Avoid mishandling comparisons due to subtraction overflow.
4380 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
4381 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
4382 (handle_tool_bar_click):
4383 Use int, not unsigned, since we prefer signed and the signedness
4384 doesn't matter here.
4385 (get_next_display_element, next_element_from_display_vector):
4386 Use int, not EMACS_INT, when int is wide enough.
4387 (start_hourglass): Use duration_to_sec_usec to do proper
4388 overflow checking on durations.
4389 * xfaces.c (Fbitmap_spec_p):
4390 Check that fixnums are in proper range for system types.
4391 (compare_fonts_by_sort_order):
4392 Avoid mishandling comparisons due to subtraction overflow.
4393 (Fx_family_fonts, realize_basic_faces):
4394 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4395 (Fx_family_fonts):
4396 Don't assume fixnum fits in int.
4397 Use SAFE_ALLOCA_LISP, not alloca.
4398 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
4399 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
4400 (face_at_buffer_position, face_for_overlay_string)
4401 (face_at_string_position):
4402 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4403 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
4404 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
4405 (Fx_show_tip):
4406 Check that fixnums are in proper range for system types.
4407 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4408 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
4409 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4410 (Fx_change_window_property): Don't assume fixnums fit in int.
4411 * xfont.c (xfont_chars_supported):
4412 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4413 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
4414 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
4415 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4416 * xml.c (parse_region):
4417 * xrdb.c (magic_file_p):
4418 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4419 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
4420 (x_get_local_selection, x_reply_selection_request)
4421 (x_handle_selection_request, wait_for_property_change):
4422 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4423 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
4424 short is wide enough.
4425 (x_send_client_event): Don't assume fixnum fits in int.
4426 * xterm.c (x_x_to_emacs_modifiers):
4427 Don't assume EMACS_INT overflows nicely into int.
4428 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
4429 may come from Lisp.
4430 (handle_one_xevent): NATNUMP can eval its arg twice.
4431 (x_connection_closed):
4432 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4433 * xterm.h: Adjust decls to match defn changes elsewhere.
4434 (struct scroll_bar): Use struct vectorlike_header
4435 rather than rolling our own approximation.
4436 (SCROLL_BAR_VEC_SIZE): Remove; not used.
4437
c6574eb5
GM
44382012-05-25 Glenn Morris <rgm@gnu.org>
4439
4440 * lisp.mk (lisp): Update for more files being compiled now.
4441
e8d32c7e
SM
44422012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
4443
48def666
SM
4444 * lread.c: Remove `read_pure' which makes no difference.
4445 (read_pure): Remove var.
4446 (unreadpure): Remove function.
4447 (readevalloop): Don't call read_list with -1 flag.
4448 (read1, read_vector): Don't test read_pure any more.
4449 (read_list): Simplify.
4450
e8d32c7e
SM
4451 * fileio.c, character.h: Minor style tweaks.
4452
4b2addb7
DA
44532012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
4454
4455 * window.h (clip_changed): Remove useless declaration.
4456
584461b2
JB
44572012-05-22 Juanma Barranquero <lekktu@gmail.com>
4458
4459 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
4460 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
4461
34374650
PE
44622012-05-22 Paul Eggert <eggert@cs.ucla.edu>
4463
4464 Remove src/m/*.
4465 This directory predates autoconf and is no longer needed nowadays.
4466 Move its few remaining bits of functionality to where they're needed.
4467 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
4468 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
4469 * m/template.h: Remove.
4470 * Makefile.in (M_FILE): Remove. All uses removed.
4471 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
4472 * lisp.h (USE_LSB_TAG):
4473 * mem-limits.h (EXCEEDS_LISP_PTR):
4474 Use VAL_MAX, not VALBITS, in #if.
4475 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
4476 (EMACS_UINT): Define unconditionally now.
4477 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
4478 (BITS_PER_EMACS_INT): New constants, replacing
4479 what used to be in config.h, but not useful in #if.
4480 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
4481 define them any more.
4482 (VAL_MAX): New macro.
4483 (VALMASK): Use it.
4484 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
4485 BITS_PER_EMACS_INT, in #if.
4486 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
4487 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
4488 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
4489 * s/ms-w32.h (DATA_START):
4490 Move here from removed file m/intel386.h.
4491 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
4492 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
4493
261cb4bb
PE
44942012-05-21 Paul Eggert <eggert@cs.ucla.edu>
4495
4496 Assume C89 or later.
4497 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
4498 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
4499 (xrealloc):
4500 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
4501 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
4502 * textprop.c, tparam.c (NULL): Remove.
4503 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
4504 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
4505 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
4506 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
4507 * xterm.c (input_signal_count): Assume volatile works.
4508
ff23cd9f
KB
45092012-05-21 Ken Brown <kbrown@cornell.edu>
4510
4511 * xgselect.c (xg_select): Fix first argument in call to 'select'
4512 (bug#11508).
4513
1b170bc6
KB
45142012-05-20 Ken Brown <kbrown@cornell.edu>
4515
4516 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 4517 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 4518
b2f4d39f
KB
45192012-05-19 Ken Brown <kbrown@cornell.edu>
4520
4521 * xfns.c (x_in_use): Remove `static' qualifier.
4522 * xterm.h (x_in_use): Declare.
4523 * xgselect.c: Include xterm.h.
4524 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
4525 and `display_arg' (bug#9754).
4526
003fdae2
PE
45272012-05-19 Paul Eggert <eggert@cs.ucla.edu>
4528
9232a6d9
PE
4529 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
4530
003fdae2
PE
4531 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
4532 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
4533
784b56e2
EZ
45342012-05-18 Eli Zaretskii <eliz@gnu.org>
4535
4536 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
4537
4538 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 4539 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
4540
4541 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
4542 reference to image_cache->refcount.
4543 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
4544
a0a79cde
JL
45452012-05-17 Juri Linkov <juri@jurta.org>
4546
4547 * search.c (Fword_search_regexp, Fword_search_backward)
4548 (Fword_search_forward, Fword_search_backward_lax)
4549 (Fword_search_forward_lax): Move functions to isearch.el
4550 (bug#10145, bug#11381).
4551
b0572523
PE
45522012-05-16 Paul Eggert <eggert@cs.ucla.edu>
4553
4554 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
4555
9660f5fc
SM
45562012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
4557
4558 * lread.c (init_obarray): Declare Qt and Qnil as special.
4559
4374de83
GM
45602012-05-14 Glenn Morris <rgm@gnu.org>
4561
4562 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 4563 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 4564
dc44c39a
PE
45652012-05-14 Paul Eggert <eggert@cs.ucla.edu>
4566
078c97cb
PE
4567 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
4568
dc44c39a
PE
4569 * unexaix.c: Port to more-recent AIX compilers.
4570 (report_error, report_error_1, make_hdr, copy_sym)
4571 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
4572 Make arguments const char *, not char *, to avoid violations of C
4573 standard and to fix some AIX warnings reported by Gilles Pion.
4574
e18afed7 45752012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
4576
4577 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
4578 already have overlays loaded.
4579 (handle_single_display_spec): Before returning without displaying
4580 fringe bitmap, synchronize the bidi iterator with the main display
4581 iterator, by calling iterate_out_of_display_property.
4582 (iterate_out_of_display_property): Detect buffer iteration by
4583 testing that it->string is a Lisp string.
4584 (get_next_display_element): When the current object is exhausted,
4585 and there's something on it->stack, call set_iterator_to_next to
4586 proceed with what's on the stack, instead of returning zero.
4587 (set_iterator_to_next): If called at the end of a Lisp string,
4588 proceed to consider_string_end without incrementing string
4589 position. Don't increment display vector index past the end of
4590 the display vector. (Bug#11417)
c8fb9dc6
EZ
4591 (pos_visible_p): Don't report a position visible when move_it_to
4592 stopped at the last line of window, which happens to be scanned
4593 backwards by the bidi iteration. (Bug#11464)
ac268e67 4594
e18afed7 45952012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
4596
4597 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
4598 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
4599 are on a TTY, and thus unable to display on the fringes.
4600 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
4601 so we need to signal to the caller that this is a "replacing"
4602 display spec. This fixes display when the spec is invalid or we
4603 are on a TTY.
4604
e18afed7 46052012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
4606
4607 * unexaix.c (make_hdr): Fix typo in prototype.
4608 This bug broke the build on AIX. Problem reported by Gilles Pion.
4609
9d0a235a
MA
46102012-05-14 Michael Albinus <michael.albinus@gmx.de>
4611
4612 * keyboard.c (kbd_buffer_get_event): Read special events also in
4613 batch mode. (Bug#11415)
4614
9e6b06ed
GM
46152012-05-12 Glenn Morris <rgm@gnu.org>
4616
4617 * ns.mk: Update for ns_appbindir no longer having trailing "/".
4618
c1a1d7a3
EZ
46192012-05-12 Eli Zaretskii <eliz@gnu.org>
4620
4621 * lisp.mk (lisp): Add newcomment.elc.
4622
3fe7cdc8
GM
46232012-05-12 Glenn Morris <rgm@gnu.org>
4624
4625 * Makefile.in (MKDIR_P): New, set by configure.
4626 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
4627
53f7d2c0
PE
46282012-05-11 Paul Eggert <eggert@cs.ucla.edu>
4629
4630 Remove unused function hourglass_started.
4631 * dispextern.h (hourglass_started):
4632 * w32fns.c (hourglass_started):
4633 * xdisp.c (hourglass_started): Remove.
4634
75aafb17
JB
46352012-05-10 Juanma Barranquero <lekktu@gmail.com>
4636
4637 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
4638 Update dependencies.
4639
12959e8e
PE
46402012-05-10 Paul Eggert <eggert@cs.ucla.edu>
4641
97107e2e
PE
4642 * xgselect.c (xg_select): Put maxfds+1 into a var.
4643 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
4644
12959e8e
PE
4645 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
4646
836d29b3
DA
46472012-05-10 Dave Abrahams <dave@boostpro.com>
4648
4649 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
4650 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
4651
5cb67954
MA
46522012-05-09 Michael Albinus <michael.albinus@gmx.de>
4653
4654 * dbusbind.c (xd_registered_buses): New internal Lisp object.
4655 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
4656 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
4657 Initialize xd_registered_buses.
4658
3478ec45
PE
46592012-05-09 Paul Eggert <eggert@cs.ucla.edu>
4660
b263a6b0
PE
4661 Untag more efficiently if USE_LSB_TAG.
4662 This is based on a proposal by YAMAMOTO Mitsuharu in
4663 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
4664 For an admittedly artificial (nth 8000 longlist) benchmark on
4665 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
4666 Emacs's overall text size by 1%.
4667 * lisp.h (XUNTAG): New macro.
4668 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
4669 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
4670 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
4671 * eval.c (Fautoload):
4672 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
4673 * frame.h (XFRAME): Use XUNTAG.
4674
3478ec45
PE
4675 Port recent dbusbind.c changes to 32-bit --with-wide-int.
4676 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
4677 Remove unportable assumptions about print widths of types like
4678 dbus_uint32_t.
4679 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
4680 intptr_t when converting between pointer and integer, to avoid GCC
4681 warnings about wrong width.
4682
666b903b 46832012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
4684
4685 * w32proc.c (new_child): Force Windows to reserve only 64KB of
4686 stack for each reader_thread, instead of defaulting to 8MB
4687 determined by the linker. This avoids failures in creating
4688 subprocesses on Windows 7, see the discussion in this thread:
4689 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
4690
b120cc17
JC
46912012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
4692
4693 Fix up display of the *Minibuf-0* buffer in the mini window.
4694 * keyboard.c (read_char): Don't clear the echo area if there's no
4695 message to clear.
4696 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 4697 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 4698
9a4b36f8
MA
46992012-05-07 Michael Albinus <michael.albinus@gmx.de>
4700
4701 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
4702 batch mode.
4703
e5f9458f
CY
47042012-05-06 Chong Yidong <cyd@gnu.org>
4705
4706 * lisp.mk (lisp): Update.
4707
eceeb5fc 47082012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
4709
4710 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
4711
71873e2b
SM
47122012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
4713
4714 * data.c (PUT_ERROR): New macro.
4715 (syms_of_data): Use it. Add new error type `user-error'.
4716 * undo.c (user_error): New function.
4717 (Fprimitive_undo): Use it.
4718 * print.c (print_error_message): Adjust print style for `user-error'.
4719 * keyboard.c (user_error): New function.
4720 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
4721
ab0fa4e4
PE
47222012-05-03 Paul Eggert <eggert@cs.ucla.edu>
4723
4724 Do not limit current-time-string to years 1000..9999.
4725 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
4726 (Fcurrent_time_string): Support any year that is supported by the
4727 underlying localtime representation. Don't use asctime, as it
4728 has undefined behavior for years outside the range -999..9999.
4729
7ed806a7
PE
47302012-05-02 Paul Eggert <eggert@cs.ucla.edu>
4731
4732 Fix race conditions involving setenv, gmtime, localtime, asctime.
4733 Without this fix, interrupts could mess up code that uses these
4734 nonreentrant functions, since setting TZ invalidates existing
4735 tm_zone or tzname values, and since most of these functions return
4736 pointers to static storage.
4737 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
4738 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
4739 Grow the critical sections to include not just invoking
4740 localtime/gmtime, but also accessing these functions' results
4741 including their tm_zone values if any, and any related TZ setting.
4742 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
4743 so that the struct tm is saved in the critical section.
4744 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
4745 motivated by the fact that memory allocation needs to be outside
4746 the critical section.
4747
0c16dfed
DA
47482012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
4749
4750 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
4751 with RESET_INTERVAL.
4752
4753 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4754 Remove duplicated buffer name initialization.
4755
3f83ace8
JM
47562012-05-02 Jim Meyering <jim@meyering.net>
4757
4758 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
4759
c7b8541e
JM
4760 * xfns.c (x_window): Use xstrdup (Bug#11375).
4761
90207a15 47622012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
4763
4764 * xdisp.c (pos_visible_p): If already at a newline from the
4765 display string before the 'while' loop, don't walk back the glyphs
4766 from it3.glyph_row. Solves assertion violation when the display
4767 string begins with a newline (egg.el). (Bug#11367)
4768
b593d6a9
AH
47692012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
4770
4771 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
4772 Move to simple.el.
4773
4737362e
GM
47742012-05-01 Glenn Morris <rgm@gnu.org>
4775
99cf43f9
GM
4776 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
4777 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
4778 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
4779 All were removed before 23.1.
4780
9311dcff
GM
4781 * dispnew.c: Remove HAVE_LIBNCURSES test;
4782 it is always true on relevant platforms.
4783
4d5c6349
GM
4784 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
4785 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
4786
4737362e
GM
4787 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
4788
74dd3a6b
AS
47892012-04-30 Andreas Schwab <schwab@linux-m68k.org>
4790
4791 * .gdbinit (xpr): Remove checks for no longer existing misc types.
4792 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
4793 Remove.
4794
13c379ee
PE
47952012-04-28 Paul Eggert <eggert@cs.ucla.edu>
4796
4797 Do not avoid creating empty evaporating overlays (Bug#9642).
4798 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
4799 That is, do not delete an evaporating overlay if it becomes
4800 empty after its bounds are adjusted to fit within its buffer.
4801 This fix caused other problems, and I'm reverting it until we get
4802 to the bottom of them.
4803
a8e7d6d7 48042012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
4805
4806 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
4807
a8e7d6d7 48082012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
4809
4810 * xdisp.c (pos_visible_p): If the window start position is beyond
4811 ZV, start the display from buffer beginning. Prevents assertion
4812 violation in init_iterator when the minibuffer window is scrolled
4813 via the scroll bar.
4814
4815 * window.c (window_scroll_pixel_based): Likewise.
4816
a8e7d6d7 48172012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
4818
4819 * keymap.c (where_is_internal): Doc fix (Bug#10872).
4820
a8e7d6d7 48212012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
4822
4823 * fileio.c (Fcopy_file, Fset_file_selinux_context):
4824 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
4825
a8e7d6d7 48262012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 4827
b593d6a9
AH
4828 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
4829 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 4830
1c6900d9
EZ
48312012-04-26 Eli Zaretskii <eliz@gnu.org>
4832
4c3fa1d9
EZ
4833 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
4834 display element, check also the underlying string or buffer
4835 character. (Bug#11341)
4836
1c6900d9
EZ
4837 * w32menu.c: Include w32heap.h.
4838 (add_menu_item): If the call to AppendMenuW (via
4839 unicode_append_menu) fails, disable Unicode menus only if we are
4840 running on Windows 9X/Me.
4841
42bf8205
AS
48422012-04-24 Andreas Schwab <schwab@linux-m68k.org>
4843
4844 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
4845 (xgetint): Add missing shift for LSB tags.
4846
b1bac16e
MR
48472012-04-24 Martin Rudalics <rudalics@gmx.at>
4848
4849 * keyboard.c (read_char): Don't wipe echo area for select window
4850 events: These might get delayed via `mouse-autoselect-window'
4851 (Bug#11304).
4852
d69621cc
JB
48532012-04-24 Juanma Barranquero <lekktu@gmail.com>
4854
4855 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
4856 manipulation of :loaded-from data.
4857
02fd101b
JB
48582012-04-23 Juanma Barranquero <lekktu@gmail.com>
4859
4860 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
4861 now a cons (bug#11311).
4862
888bec30
PE
48632012-04-23 Paul Eggert <eggert@cs.ucla.edu>
4864
89a438bd
PE
4865 Do not create empty overlays with the evaporate property (Bug#9642).
4866 * buffer.c (Fmove_overlay): Delete an evaporating overlay
4867 if it becomes empty after its bounds are adjusted to fit within
4868 its buffer. Without this fix, in a nonempty buffer (let ((o
4869 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
4870 yields an empty overlay that has the evaporate property, which is
4871 not supposed to happen.
4872
1068fe4d
PE
4873 Fix minor GTK3 problems found by static checking.
4874 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4875 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4876 (struct _EmacsFixedClass, emacs_fixed_get_type):
4877 Move decls here from emacsgtkfixed.h, since they needn't be public.
4878 (emacs_fixed_get_type): Now static.
4879 (emacs_fixed_class_init): Omit unused local.
4880 (emacs_fixed_child_type): Remove; unused.
4881 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4882 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4883 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
4884 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
4885 (EMACS_FIXED_GET_CLASS): Remove; unused.
4886 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
4887
888bec30
PE
4888 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
4889 Problem reported by Juanma Barranquero for Windows -Wunused-function.
4890
de85e130
PE
48912012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4892
d0baac98 4893 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 4894 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
4895 (__malloc_size_t, __malloc_ptrdiff_t):
4896 Remove. All uses removed, replaced by the definiens if needed,
4897 since we can assume C89 or better now.
4898 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
4899 (protect_malloc_state, align, get_contiguous_space)
4900 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
4901 (malloc_atfork_handler_child, malloc_enable_thread)
4902 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
4903 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
4904 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
4905 (special_realloc, _realloc_internal_nolock, _realloc_internal)
4906 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
4907 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
4908 Define using prototypes, not old style.
4909 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
4910 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
4911 (align): Don't assume that signed integer overflow wraps around.
4912 Omit unused local var.
4913 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
4914 (_free_internal_nolock, memalign, mallochook, reallochook):
4915 Omit no-longer-needed casts.
4916 (valloc): Use getpagesize, not __getpagesize.
4917 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
4918 (struct hdr): The 'magic' member is now size_t, not unsigned long.
4919
de85e130
PE
4920 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
4921
dcbf5805
MA
49222012-04-22 Michael Albinus <michael.albinus@gmx.de>
4923
4924 Move functions from C to Lisp. Make non-blocking method calls
4925 the default. Implement further D-Bus standard interfaces.
4926
4927 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
4928 (QCdbus_request_name_allow_replacement)
4929 (QCdbus_request_name_replace_existing)
4930 (QCdbus_request_name_do_not_queue)
4931 (QCdbus_request_name_reply_primary_owner)
4932 (QCdbus_request_name_reply_in_queue)
4933 (QCdbus_request_name_reply_exists)
4934 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
4935 (QCdbus_registered_serial, QCdbus_registered_method)
4936 (QCdbus_registered_signal): New Lisp objects.
4937 (XD_DEBUG_MESSAGE): Use sizeof.
4938 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
4939 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
4940 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
4941 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
4942 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
4943 (xd_signature, xd_append_arg): Allow float for integer types.
4944 (xd_get_connection_references): New function.
b593d6a9
AH
4945 (xd_get_connection_address): Rename from xd_initialize.
4946 Return cached address.
dcbf5805
MA
4947 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
4948 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
4949 level.
4950 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 4951 Return number of refcounts.
dcbf5805
MA
4952 (Fdbus_get_unique_name): Make stronger parameter check.
4953 (Fdbus_message_internal): New defun.
4954 (Fdbus_call_method, Fdbus_call_method_asynchronously)
4955 (Fdbus_method_return_internal, Fdbus_method_error_internal)
4956 (Fdbus_send_signal, Fdbus_register_service)
4957 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
4958 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
4959 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
4960 (Vdbus_compiled_version, Vdbus_runtime_version)
4961 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
4962 (Vdbus_message_type_method_return, Vdbus_message_type_error)
4963 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
4964 (Vdbus_registered_buses, Vdbus_registered_objects_table):
4965 Adapt docstring.
dcbf5805 4966
52828e02
PE
49672012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4968
da05bc4c
PE
4969 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
4970 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
4971 Do not assume ptrdiff_t is the same width as 'int'.
4972
52828e02
PE
4973 * alloc.c: Handle unusual debugging option combinations.
4974 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
4975 since the two debugging options are incompatible.
4976 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
4977 is defined.
4978 (mem_init, mem_insert, mem_insert_fixup):
4979 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
4980 (NEED_MEM_INSERT): Remove; no longer needed.
4981
f01769f9
LL
49822012-04-22 Leo Liu <sdl.web@gmail.com>
4983
4984 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
4985
5790543d
PE
49862012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4987
4988 * sysdep.c [__FreeBSD__]: Minor cleanups.
4989 (list_system_processes, system_process_attributes) [__FreeBSD__]:
4990 Use Emacs indenting style more consistently. Avoid some casts.
4991 Use 'double' consistently rather than mixing 'float' and 'double'.
4992
b91b7e4d
EW
49932012-04-21 Eduard Wiebe <usenet@pusto.de>
4994
b593d6a9
AH
4995 * sysdep.c (list_system_processes, system_process_attributes):
4996 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 4997
6114eb15
AS
49982012-04-21 Andreas Schwab <schwab@linux-m68k.org>
4999
5000 * lisp.mk (lisp): Update.
5001
2f38dff7
PE
50022012-04-20 Paul Eggert <eggert@cs.ucla.edu>
5003
5004 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
5005 It is never used otherwise.
5006
4ae29f89
SM
50072012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
5008
5009 * print.c (print_preprocess): Only check print_depth if print-circle
5010 is nil.
5011 (print_object): Check for cycles even when print-circle is nil and
5012 print-gensym is t, but only check print_depth if print-circle is nil.
5013
f30d612a
CY
50142012-04-20 Chong Yidong <cyd@gnu.org>
5015
5016 * process.c (wait_reading_process_output): If EIO occurs on a pty,
5017 set the status to "failed" and ensure that sentinel is run.
5018
c07a4c0b 50192012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
5020
5021 * process.c (Fset_process_inherit_coding_system_flag)
5022 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 5023 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 5024
c07a4c0b 50252012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
5026
5027 * xdisp.c (string_buffer_position_lim): Limit starting position to
5028 BEGV.
5029 (set_cursor_from_row): If called for a mode-line or header-line
5030 row, return zero immediately.
5031 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
5032 farther than the first row after the header line, if any.
5033 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
5034 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
5035
c07a4c0b 50362012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 5037
4ae29f89
SM
5038 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
5039 (bug#11238).
ad3a2b41 5040
c07a4c0b 50412012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 50422012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
5043
5044 configure: new option --enable-gcc-warnings (Bug#11207)
5045 * Makefile.in (C_WARNINGS_SWITCH): Remove.
5046 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
5047 (ALL_CFLAGS): Use new macros rather than old.
5048 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
5049 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
5050 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
5051 -Wunused-result, -Wunused-variable. This should go away once
5052 the Emacs and Gnulib regex code is merged.
5053 (xmalloc, xrealloc): Now static.
5054
aba027e8
PE
50552012-04-17 Paul Eggert <eggert@cs.ucla.edu>
5056
5057 * dired.c (Fsystem_groups): Remove unused local.
5058
e5a36063
GM
50592012-04-17 Glenn Morris <rgm@gnu.org>
5060
5061 * dired.c (Fsystem_users): Doc fix.
5062
316411f0
DA
50632012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
5064
5065 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
5066 (syms_of_dired): Add them.
5067
9426aba4
PE
50682012-04-16 Paul Eggert <eggert@cs.ucla.edu>
5069
b62a57be
PE
5070 Fix minor alloc.c problems found by static checking.
5071 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
5072 New extern decls, to avoid calling undeclared functions.
5073 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
5074 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
5075 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
5076 (NEED_MEM_INSERT): New macro.
5077 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 5078 Remove one incorrect comment and fix another.
b62a57be 5079
3539f31f
PE
5080 Fix minor ralloc.c problems found by static checking.
5081 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
5082 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
5083 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
5084 (r_alloc_sbrk): Now static.
5085
a041960a
PE
5086 Improve ralloc.c interface checking.
5087 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
5088 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
5089 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
5090 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
5091 [REL_ALLOC]: ... to here, to check interface.
5092 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
5093 Remove decls. This fixes an "It stinks!".
5094
9426aba4
PE
5095 * alloc.c (which_symbols): Fix alignment issue / type clash.
5096
d55c12ed
AS
50972012-04-15 Andreas Schwab <schwab@linux-m68k.org>
5098
5099 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
5100 (struct Lisp_Misc_Any): Likewise.
5101 (struct Lisp_Free): Likewise.
5102 * alloc.c (union aligned_Lisp_Symbol): Define.
5103 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
5104 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
5105 (union aligned_Lisp_Misc): Define.
5106 (MARKER_BLOCK_SIZE, struct marker_block): Use union
5107 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 5108 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 5109
b948ce8b
PE
51102012-04-14 Paul Eggert <eggert@cs.ucla.edu>
5111
5112 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
5113 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
5114 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
5115 * s/netbsd.h, s/sol2-6.h:
5116 Remove definition of GC_MARK_STACK, since the default now works.
5117 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
5118 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
5119 no longer the default.
5120 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
5121
35dc09a1 51222012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 5123
35dc09a1
GM
5124 * lread.c (lisp_file_lexically_bound_p):
5125 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 5126
35dc09a1
GM
51272012-04-14 Eli Zaretskii <eliz@gnu.org>
5128
5129 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
5130 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
5131
51322012-04-14 Jan Djärv <jan.h.d@swipnet.se>
5133
5134 * nsterm.m (constrainFrameRect): Always constrain when there is only
5135 one screen (Bug#10962).
5136
bcd86815
KB
51372012-04-13 Ken Brown <kbrown@cornell.edu>
5138
5139 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
5140
c25df26e
RT
51412012-04-13 Reuben Thomas <rrt@sc3d.org>
5142
5143 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
5144
0fc59f1e
DC
51452012-04-11 Daniel Colascione <dancol@dancol.org>
5146
5147 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
5148 against is gone. It's better to use vfork now so that when Cygwin
5149 gains a new, working vfork, we use it automatically (bug#10398).
5150
de8c03dc
SM
51512012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
5152
5153 * window.c (save_window_save): Obey window-point-insertion-type.
5154
2f097256
GM
51552012-04-11 Glenn Morris <rgm@gnu.org>
5156
5157 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
5158
453b951e
SM
51592012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
5160
5161 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
5162
75f1671a 51632012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
5164
5165 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
5166 (force_quit_count): New var.
5167 (handle_interrupt): Use it.
5168
2a8ce227
JB
51692012-04-10 Juanma Barranquero <lekktu@gmail.com>
5170
5171 * w32.c (w32_delayed_load): Record the full path of the library
5172 being loaded (bug#10424).
5173
935396c0
GM
51742012-04-09 Glenn Morris <rgm@gnu.org>
5175
05920a43
GM
5176 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
5177 not just in the obarray, before snarfing them. (Bug#11036)
5178
935396c0
GM
5179 * Makefile.in ($(leimdir)/leim-list.el):
5180 Pass EMACS rather than BUILT_EMACS.
5181
a18ecafa
TZ
51822012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
5183
5184 * process.c (make_process):
5185 * process.h: Add integer `gnutls_handshakes_tried' member to
5186 process struct.
5187
6bbef4e5
JC
5188 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
5189 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
5190
5191 * gnutls.c (gnutls_log_function2i): Convenience log function.
5192 (emacs_gnutls_read): Use new log functions,
5193 `gnutls_handshakes_tried' process member, and
5194 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
5195 attempts per process (connection).
5196
b4d3bc10
CY
51972012-04-09 Chong Yidong <cyd@gnu.org>
5198
5199 * eval.c (Fuser_variable_p, user_variable_p_eh)
5200 (lisp_indirect_variable): Functions deleted.
5201 (Fdefvar): Caller changed.
5202
5203 * callint.c (Finteractive, Fcall_interactively):
5204 * minibuf.c (Fread_variable): Callers changed.
5205
70f4d973
EZ
52062012-04-09 Eli Zaretskii <eliz@gnu.org>
5207
5208 * xdisp.c (set_cursor_from_row): If the display string appears in
5209 the buffer at position that is closer to point than the position
5210 after the display string, display the cursor on the first glyph of
5211 the display string. Fixes cursor display when a 'display' text
5212 property immediately follows invisible text. (Bug#11094)
5213
cb3c2e3e
PE
52142012-04-09 Paul Eggert <eggert@cs.ucla.edu>
5215
5216 composite.c: use 'double' consistently
5217 * composite.c (get_composition_id): Use 'double' consistently
5218 instead of converting 'float' to 'double' and vice versa; this is
5219 easier to understand and avoids a GCC warning.
5220
fd06db5d
GM
52212012-04-09 Glenn Morris <rgm@gnu.org>
5222
50fe702a
GM
5223 * Makefile.in: Generate leim-list with bootstrap-emacs, in
5224 preparation for dumping it with emacs. (Bug#4789)
5225 (leimdir): New variable.
5226 ($(leimdir)/leim-list.el): New rule.
5227 (emacs$(EXEEXT)): Depend on leim-list.el.
5228
fd06db5d
GM
5229 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
5230 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
5231 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
5232
55c131ee
AS
52332012-04-08 Andreas Schwab <schwab@linux-m68k.org>
5234
5235 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
5236 proper alignment.
5237
9209588f
JB
52382012-04-07 Juanma Barranquero <lekktu@gmail.com>
5239
5240 * xml.c (init_libxml2_functions) [WINDOWSNT]:
5241 Remove unused local variable.
5242
e3fb2efb
PE
52432012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5244
5245 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
5246 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
5247 (mark_memory): Mark Lisp_Objects only if pointers might hide in
5248 objects, as mark_maybe_pointer will catch them otherwise.
5249 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
5250 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
5251
b5385551
PE
52522012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5253
5254 Fix typo that broke non-Windows builds.
5255 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
5256
9078ead6
EZ
52572012-04-07 Eli Zaretskii <eliz@gnu.org>
5258
5259 Support building on MS-Windows with libxml2.
5260
5261 * makefile.w32-in (OBJ2): Add xml.$(O).
5262 (GLOBAL_SOURCES): Add xml.c.
5263 ($(BLD)/xml.$(O)): New dependency list.
5264
5265 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
5266 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
5267 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
5268 [!WINDOWSNT]: New macros.
5269 (init_libxml2_functions, libxml2_loaded_p): New functions.
5270 (parse_region): Call fn_xmlCheckVersion instead of using the macro
5271 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
5272 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
5273 Calls xmlCleanupParser only if libxml2 was loaded (or statically
5274 linked in).
6bbef4e5
JC
5275 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
5276 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
5277 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
5278
5279 * emacs.c: Don't include libxml/parser.h.
5280 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
5281 xmlCleanupParser directly.
5282
5283 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
5284
3811fdf3
EZ
52852012-04-07 Eli Zaretskii <eliz@gnu.org>
5286
5287 * indent.c (Fvertical_motion): If there is a display string at
5288 point, use it.vpos to compute how many lines to backtrack after
5289 move_it_to point. (Bug#11133)
5290
2f8e16b2
EZ
52912012-04-06 Eli Zaretskii <eliz@gnu.org>
5292
5293 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
5294 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
5295 about subtle differences between FETCH_CHAR* and STRING_CHAR*
5296 macros related to unification of CJK characters. For the details,
5297 see the discussion following the message here:
5298 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
5299
3d439cd1
CY
53002012-04-04 Chong Yidong <cyd@gnu.org>
5301
5302 * keyboard.c (Vdelayed_warnings_list): Doc fix.
5303
8bc53d00
EZ
53042012-04-01 Eli Zaretskii <eliz@gnu.org>
5305
5306 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
5307 instead of alloca. (Bug#11138)
5308
3b0512a3
AS
53092012-04-01 Andreas Schwab <schwab@linux-m68k.org>
5310
5311 * w32menu.c (is_simple_dialog): Properly check lisp types.
5312 (Bug#11141)
5313
8427ddd2
EZ
53142012-03-31 Eli Zaretskii <eliz@gnu.org>
5315
979022ef
EZ
5316 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
5317 position we get to after a call to move_it_to fails the
5318 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
5319 only if we wind up in a string from display property. (Bug#11063)
5320
a6b1c7cc
EZ
5321 * window.c (Fdelete_other_windows_internal): Invalidate the row
5322 and column information about mouse highlight, so that redisplay
5323 restores it after reallocating the glyph matrices. (Bug#7464)
5324
8427ddd2
EZ
5325 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
5326 string comes from a `display' text property, use the buffer
5327 position of that property as if we actually saw that position in
5328 the row's glyphs.
697ba24b
EZ
5329 (move_it_by_lines): Remove the assertion that
5330 "it->current_x == 0 && it->hpos == 0" which can be legitimately
5331 violated when there's a before-string at the beginning of a line.
5332 (Bug#11063)
8427ddd2 5333
65a0a738
EZ
53342012-03-30 Eli Zaretskii <eliz@gnu.org>
5335
5336 * xdisp.c (append_space_for_newline): If the default face was
5337 remapped, use the remapped face for the appended newline.
5338 (extend_face_to_end_of_line): Use the remapped default face for
5339 extending the face to the end of the line.
5340 (display_line): Call extend_face_to_end_of_line when the default
5341 face was remapped. (Bug#11068)
5342
581355cc
EZ
53432012-03-29 Eli Zaretskii <eliz@gnu.org>
5344
5345 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
5346
e8fc049f
SM
53472012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5348
5349 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
5350
4fb9a543
GM
53512012-03-27 Glenn Morris <rgm@gnu.org>
5352
5353 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
5354 Doc fixes.
5355
679910f1
KH
53562012-03-26 Kenichi Handa <handa@m17n.org>
5357
5358 * dispextern.h (struct glyph): Fix previous change. Change the
5359 bit length of glyphless.ch to 25 (Bug#11082).
5360
90d49b7f
CY
53612012-03-26 Chong Yidong <cyd@gnu.org>
5362
5363 * keyboard.c (Vselection_inhibit_update_commands): New variable.
5364 (command_loop_1): Use it; inhibit selection update for
5365 handle-select-window too (Bug#8996).
5366
f514f6f0
FP
53672012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
5368
e8fc049f 5369 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 5370
bf43fa51
KH
53712012-03-25 Kenichi Handa <handa@m17n.org>
5372
5373 * dispextern.h (struct glyph): Change the bit length of
5374 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
5375
8a0c01dd
EZ
53762012-03-24 Eli Zaretskii <eliz@gnu.org>
5377
5378 * s/ms-w32.h (tzname): Include time.h before redirecting to
5379 _tzname. Fixes the MSVC build. (Bug#9960)
5380
7d1c3a76
AS
53812012-03-24 Andreas Schwab <schwab@linux-m68k.org>
5382
8ed79523
AS
5383 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
5384 characters.
5385
7d1c3a76
AS
5386 * xterm.c (XTread_socket): Only modify handling_signal if
5387 !SYNC_INPUT. (Bug#11080)
5388
e99a9b8b
EZ
53892012-03-23 Eli Zaretskii <eliz@gnu.org>
5390
5391 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
5392 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
5393 when fetching a multibyte character consumes more bytes than
5394 CHAR_BYTES returns, due to unification of CJK characters in
5395 string_char. (Bug#11073)
5396
5063c0e1
TN
53972012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
5398
5399 * process.c (wait_reading_process_output): Handle pty disconnect
5400 by refraining from sending oneself a SIGCHLD (bug#10933).
5401
9f851fbd
CY
54022012-03-22 Chong Yidong <cyd@gnu.org>
5403
5404 * dispextern.h (struct it): New member string_from_prefix_prop_p.
5405
5063c0e1 5406 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
5407 Mark string as coming from a prefix property.
5408 (handle_face_prop): Use default face for prefix strings (Bug#4281).
5409 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
5410
fb5b8aca
CY
54112012-03-21 Chong Yidong <cyd@gnu.org>
5412
5413 * xfaces.c (Vface_remapping_alist): Doc fix.
5414
62356a1b
EZ
54152012-03-20 Eli Zaretskii <eliz@gnu.org>
5416
5417 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
5418 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
5419 Doc fixes.
62356a1b 5420
025de85b
CY
54212012-03-20 Chong Yidong <cyd@gnu.org>
5422
5423 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
5424 to reflect default non-nil value of redisplay-dont-pause.
5425
4827f94e
KH
54262012-03-19 Kenichi Handa <handa@m17n.org>
5427
5428 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
5429 it fit in a valid range (Bug#11003).
5430
e50a24a2
EZ
54312012-03-18 Eli Zaretskii <eliz@gnu.org>
5432
5433 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
5434 that is not from display property, accept the row as a "cursor
5435 row" if one of the string's character has a non-nil `cursor'
5436 property. Fixes cursor positioning when there are newlines in
5437 overlay strings, e.g. in icomplete.el. (Bug#11035)
5438
9af5ed87
PE
54392012-03-12 Paul Eggert <eggert@cs.ucla.edu>
5440
5441 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
5442
d1f55f16
CY
54432012-03-12 Chong Yidong <cyd@gnu.org>
5444
5445 * eval.c (inhibit_lisp_code): Rename from
5446 inhibit_window_configuration_change_hook; move from window.c.
5447
5448 * xfns.c (unwind_create_frame_1, Fx_create_frame):
5449 * window.c (run_window_configuration_change_hook)
5450 (syms_of_window): Callers changed.
5451
66c5eebd
CY
54522012-03-11 Chong Yidong <cyd@gnu.org>
5453
413df973
CY
5454 * keymap.c (Fkey_description): Doc fix (Bug#9700).
5455
66c5eebd
CY
5456 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
5457
1de11f56
CY
54582012-03-10 Chong Yidong <cyd@gnu.org>
5459
5460 * frame.c (other_visible_frames): Don't assume the selected frame
5461 is visible (Bug#10955).
5462
cae07000
SM
54632012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
5464
5465 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
5466
89c94350
JD
54672012-03-08 Jan Djärv <jan.h.d@swipnet.se>
5468
5469 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
5470 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
5471 zero (Bug#10954).
5472
999dd333
GM
54732012-03-03 Glenn Morris <rgm@gnu.org>
5474
01a6dcc8 5475 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 5476
de0100f2
EZ
54772012-03-02 Eli Zaretskii <eliz@gnu.org>
5478
5479 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
5480 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
5481 (redisplay_window, next_element_from_string): Fix typos in
5482 comments.
3e441275
EZ
5483 (redisplay_window): Pass to move_it_vertically the margin in
5484 pixels, not in screen lines.
de0100f2 5485
96a72ee9
GM
54862012-03-02 Glenn Morris <rgm@gnu.org>
5487
5488 * buffer.c (buffer-list-update-hook): Doc fix.
5489
312508d7
EZ
54902012-02-29 Eli Zaretskii <eliz@gnu.org>
5491
5492 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
5493 push_it before setting up the iterator for the first overlay
5494 string, even if we have an empty string loaded.
5495 (next_overlay_string): If there's an empty string on the iterator
5496 stack, pop the stack. (Bug#10903)
5497
27f3c637
PE
54982012-02-25 Paul Eggert <eggert@cs.ucla.edu>
5499
5500 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
5501 Suggested by Stefan Monnier in
5502 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
5503 * alloc.c (widen_to_Lisp_Object): New static function.
5504 (mark_memory): Also mark Lisp_Objects by fetching pointer words
5505 and widening them to Lisp_Objects. This would work even if
5506 USE_LSB_TAG is defined and wide integers are used, which might
5507 happen in a future version of Emacs.
5508
3c9dfce6
CY
55092012-02-25 Chong Yidong <cyd@gnu.org>
5510
fa74b241
CY
5511 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
5512 Doc fix.
5513
3c9dfce6
CY
5514 * xselect.c (Fx_selection_exists_p): Doc fix.
5515 (x_clipboard_manager_save_all): Print an informative message
5516 before saving to clipboard manager.
5517
9486df08
CY
55182012-02-24 Chong Yidong <cyd@gnu.org>
5519
5520 * keyboard.c (process_special_events): Handle all X selection
5521 requests in kbd_buffer, not just the next one (Bug#8869).
5522
f01d3321
CY
55232012-02-23 Chong Yidong <cyd@gnu.org>
5524
5525 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
5526 call when setting menu-bar-lines and tool-bar-lines parameters.
5527 (unwind_create_frame_1): New helper function.
5528
5529 * window.c (inhibit_window_configuration_change_hook): New var.
5530 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 5531 (syms_of_window): Initialize it.
f01d3321 5532
86b847b6
CY
55332012-02-22 Chong Yidong <cyd@gnu.org>
5534
5535 * xterm.c (x_draw_image_relief): Add missing type check for
5536 Vtool_bar_button_margin (Bug#10743).
5537
a59225b1
CY
55382012-02-21 Chong Yidong <cyd@gnu.org>
5539
5540 * fileio.c (Vfile_name_handler_alist): Doc fix.
5541
5542 * buffer.c (Fget_file_buffer): Protect against invalid file
5543 handler return value.
5544
310f5bd4
PE
55452012-02-20 Paul Eggert <eggert@cs.ucla.edu>
5546
cb3a28cc
PE
5547 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
5548 when computing $valmask.
5549
310f5bd4
PE
5550 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
5551 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
5552 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
5553 It's useless in that case, and it can cause problems on hosts
5554 that allocate halves of EMACS_INT values separately.
5555 Reported by Dan Horák. Diagnosed by Andreas Schwab in
5556 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
5557 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
5558 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
5559 it avoids undefined behavior on hosts where shifting right by more
5560 than the word width has undefined behavior.
5561
2375c96a
CY
55622012-02-19 Chong Yidong <cyd@gnu.org>
5563
5564 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
5565 (Funhandled_file_name_directory, Ffile_name_as_directory)
5566 (Fdirectory_file_name, Fexpand_file_name)
5567 (Fsubstitute_in_file_name): Protect against invalid file handler
5568 return values (Bug#10845).
5569
3eb49e71
EZ
55702012-02-18 Eli Zaretskii <eliz@gnu.org>
5571
5572 * .gdbinit (pitx): Fix incorrect references to fields of the
5573 iterator stack.
5574
7b926f3f
CY
55752012-02-17 Chong Yidong <cyd@gnu.org>
5576
5577 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
5578
11273115
PE
55792012-02-15 Paul Eggert <eggert@cs.ucla.edu>
5580
5581 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
5582 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
5583
c3a70e2b
CY
55842012-02-15 Chong Yidong <cyd@gnu.org>
5585
5586 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
5587 marked as special. Also, starting docstrings with * is obsolete.
5588
0ca43699
AS
55892012-02-13 Andreas Schwab <schwab@linux-m68k.org>
5590
5591 * gnutls.c (emacs_gnutls_write): Fix last change.
5592
2e8f3c56
LI
55932012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
5594
5595 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
5596 send_process.
5597
af70074f
SM
55982012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
5599
5600 * keymap.c (Fsingle_key_description): Handle char ranges.
5601
95986d52
CY
56022012-02-12 Chong Yidong <cyd@gnu.org>
5603
afd83bd1
CY
5604 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
5605 as that creates a dangerous corner case.
5606
95986d52
CY
5607 * window.c (Fdelete_window_internal): Invalidate the mouse
5608 highlight (Bug#9904).
5609
bd7da63e
GM
56102012-02-12 Glenn Morris <rgm@gnu.org>
5611
5612 * xselect.c (Fx_own_selection_internal)
5613 (Fx_get_selection_internal, Fx_disown_selection_internal)
5614 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
5615 * nsselect.m (Fx_own_selection_internal)
5616 (Fx_disown_selection_internal, Fx_selection_exists_p)
5617 (Fx_selection_owner_p, Fx_get_selection_internal):
5618 Sync docs and argument specs with the xselect.c versions.
5619
77abcbc2
LI
56202012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
5621
5622 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
5623
90b671e2
EZ
56242012-02-11 Eli Zaretskii <eliz@gnu.org>
5625
1c0ca0b7
EZ
5626 * w32select.c (Fx_selection_exists_p): Sync doc string and
5627 argument list with xselect.c. (Bug#10783)
5628
5629 * w16select.c (Fx_selection_exists_p): Sync doc string and
5630 argument list with xselect.c. (Bug#10783)
90b671e2 5631
49241268
GM
56322012-02-10 Glenn Morris <rgm@gnu.org>
5633
5634 * fns.c (Fsecure_hash): Doc fix.
5635
f998bbe7 56362012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
5637
5638 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
5639
0992bd9c
CY
56402012-02-07 Chong Yidong <cyd@gnu.org>
5641
5642 * buffer.c (Fbuffer_local_variables)
5643 (buffer_lisp_local_variables): Handle unbound vars correctly;
5644 don't let Qunbound leak into Lisp.
5645
af008560
GM
56462012-02-07 Glenn Morris <rgm@gnu.org>
5647
dd605cc4
GM
5648 * image.c (Fimagemagick_types): Doc fix.
5649
af008560
GM
5650 * image.c (imagemagick-render-type): Change it from a lisp object
5651 to an integer. Move the doc here from the lisp manual.
5652 Treat all values not equal to 0 the same.
5653
1449fa1d
CY
56542012-02-06 Chong Yidong <cyd@gnu.org>
5655
5656 * doc.c (store_function_docstring): Avoid applying docstring of
5657 alias to base function (Bug#2603).
5658
3723ec07
AS
56592012-02-04 Andreas Schwab <schwab@linux-m68k.org>
5660
5661 * .gdbinit (pp1, pv1): Remove redundant defines.
5662 (pr): Use pp.
5663
79c1cc1e
CY
56642012-02-04 Chong Yidong <cyd@gnu.org>
5665
5666 * nsterm.m: Declare a global (Bug#10694).
5667
d7f29f8e
EZ
56682012-02-04 Eli Zaretskii <eliz@gnu.org>
5669
cae07000
SM
5670 * w32.c (get_emacs_configuration_options):
5671 Include --enable-checking, if specified, in the return value.
d7f29f8e 5672
3b95a6f9
MR
56732012-02-04 Martin Rudalics <rudalics@gmx.at>
5674
5675 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
5676 after rounding frame sizes. (Bug#9723)
5677
d6fa96a6
EZ
56782012-02-04 Eli Zaretskii <eliz@gnu.org>
5679
5680 * keyboard.c (adjust_point_for_property): Don't position point
5681 before BEGV. (Bug#10696)
5682
df0b2940
PE
56832012-02-03 Paul Eggert <eggert@cs.ucla.edu>
5684
5685 Handle overflow when computing char display width (Bug#9496).
5686 * character.c (char_width): Return EMACS_INT, not int.
5687 (char_width, c_string_width): Check for overflow when
5688 computing the width; this is possible now that individual
5689 characters can have unbounded width. Problem introduced
5690 by merge from Emacs 23 on 2012-01-19.
5691
6bee44d6
MA
56922012-02-02 Michael Albinus <michael.albinus@gmx.de>
5693
5694 * dbusbind.c (Fdbus_register_method): Mention the return value
5695 :ignore in the docstring.
5696
44f92739
GM
56972012-02-02 Glenn Morris <rgm@gnu.org>
5698
1b9f60cc
GM
5699 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
5700
44f92739
GM
5701 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5702 Unconditionally set to t. (Bug#10673)
5703 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5704 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
5705 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
5706
c5d3843c
KH
57072012-02-02 Kenichi Handa <handa@m17n.org>
5708
5709 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
5710 0, do not call append_composite_glyph.
5711
159462d4 57122012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
5713
5714 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
5715 NULL (Bug#6988).
5716 (x_produce_glyphs): If the component of a composition is a null
5717 string, set it->pixel_width to 1 to avoid zero-width glyph.
5718
78cef877
EZ
57192012-02-01 Eli Zaretskii <eliz@gnu.org>
5720
5721 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
5722 first 2 arguments are identical. This makes inserting large
5723 output from a subprocess an order of magnitude faster on
5724 MS-Windows, where all sbrk'ed memory is always contiguous.
5725
97897668
GM
57262012-01-31 Glenn Morris <rgm@gnu.org>
5727
5728 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 5729 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
5730 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
5731
31fd3586
GM
57322012-01-29 Glenn Morris <rgm@gnu.org>
5733
5734 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
5735
0e24a8b2
CY
57362012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
5737
5738 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
5739
cc0adcb0
CY
57402012-01-28 Chong Yidong <cyd@gnu.org>
5741
5742 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
5743
acc28cb9
CY
57442012-01-26 Chong Yidong <cyd@gnu.org>
5745
9c69cfb7
CY
5746 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
5747
acc28cb9
CY
5748 * search.c (Fsearch_forward, Fsearch_backward): Document negative
5749 repeat counts (Bug#10507).
5750
48da7392
GM
57512012-01-26 Glenn Morris <rgm@gnu.org>
5752
5753 * lread.c (syms_of_lread): Doc fix.
5754
14af5f7f
CY
57552012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
5756
5757 * coding.c (encode_designation_at_bol): Change return value to
5758 EMACS_INT.
5759
0b21c100
CY
57602012-01-25 Chong Yidong <cyd@gnu.org>
5761
5762 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
5763
3c2907f7
CY
57642012-01-21 Chong Yidong <cyd@gnu.org>
5765
5766 * floatfns.c (Fcopysign): Make the second argument non-optional,
5767 since nil is not allowed anyway.
5768
959ad23f
AS
57692012-01-21 Andreas Schwab <schwab@linux-m68k.org>
5770
5771 * process.c (read_process_output): Use p instead of XPROCESS (proc).
5772 (send_process): Likewise.
5773
34a02f46
MR
57742012-01-19 Martin Rudalics <rudalics@gmx.at>
5775
5776 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
5777 (Vwindow_persistent_parameters): Do not use Qstate.
5778 Rewrite doc-strings.
34a02f46 5779
1259009a 57802012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
5781
5782 * character.c (char_width): New function.
70d4fdf6
GM
5783 (Fchar_width, c_string_width, lisp_string_width):
5784 Use char_width (Bug#9496).
25ed9e61 5785
6a6ee00d
MR
57862012-01-16 Martin Rudalics <rudalics@gmx.at>
5787
5788 * window.c (Vwindow_persistent_parameters): New variable.
5789 (Fset_window_configuration, save_window_save): Handle persistent
5790 window parameters.
5791
c85efaf7
EZ
57922012-01-14 Eli Zaretskii <eliz@gnu.org>
5793
5794 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
5795 thrashing the stack of the thread. (Bug#9087)
5796
5944709e
PE
57972012-01-12 Paul Eggert <eggert@cs.ucla.edu>
5798
5799 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
5800
e71f5d99
EZ
58012012-01-11 Eli Zaretskii <eliz@gnu.org>
5802
5803 * xdisp.c (rows_from_pos_range): Handle the case where the
5804 highlight ends on a newline. (Bug#10464)
5805 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
5806 he end column for display of highlight that ends on a newline
5807 before a R2L line.
5808
ce316182
GM
58092012-01-11 Glenn Morris <rgm@gnu.org>
5810
5811 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
5812 from load-path also when installation-directory is nil. (Bug#10208)
5813
5b43da69
GM
58142012-01-10 Glenn Morris <rgm@gnu.org>
5815
74cc8ff9
GM
5816 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
5817
7d8d6e4e
GM
5818 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
5819 Update template values to be closer to their typical values these days.
5b43da69 5820
a0db8d43
EZ
58212012-01-09 Eli Zaretskii <eliz@gnu.org>
5822
5823 * xdisp.c (rows_from_pos_range): Accept additional argument
5824 DISP_STRING, and accept any glyph in a row whose object is that
5825 string as eligible for mouse highlight. Fixes mouse highlight of
5826 display strings from overlays. (Bug#10464)
5827
9a0115ab 58282012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 5829
b9110d6a 5830 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
5831 * fileio.c (auto_saving_dir_umask): New static var.
5832 (Fmake_directory_internal): Use it.
5833 (do_auto_save_make_dir): Set it, instead of invoking chmod after
5834 creating the directory. The old code temporarily assigns
5835 too-generous permissions to the directory.
5836 (do_auto_save_eh): Clear it.
b9110d6a 5837 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
5838 that the var is always cleared.
5839
6c1bd3f3
EZ
58402012-01-07 Eli Zaretskii <eliz@gnu.org>
5841
5842 * search.c (scan_buffer): Pass character positions to
5843 know_region_cache, not byte positions. (Bug#6540)
5844
069d2b50
L
58452012-01-07 LynX <_LynX@bk.ru> (tiny change)
5846
5847 * w32.c (sys_rename): Report EXDEV when rename of a directory
5848 fails because the target is on another logical disk. (Bug#10284)
5849
75bf0d33
DB
58502012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
5851
5852 * xterm.c (x_embed_request_focus): New function.
5853
5854 * xterm.h: Add prototype.
5855
5856 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
5857
1c6e5a32
GM
58582012-01-05 Glenn Morris <rgm@gnu.org>
5859
5860 * emacs.c (emacs_copyright): Update short copyright year to 2012.
5861
651e947e
EZ
58622012-01-01 Eli Zaretskii <eliz@gnu.org>
5863
5864 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
5865 Load gnutls_transport_set_lowat only if GnuTLS version is below
5866 2.11.1.
5867 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
5868 GnuTLS versions below 2.11.1.
5869
3778cdd8
AL
58702011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
5871
5872 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
5873 to the doc string advising against its use for altering the way
5874 windows are scrolled.
5875
0e5317f7
KH
58762011-12-28 Kenichi Handa <handa@m17n.org>
5877
5878 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
5879 coding-system ASCII compatible only when it does not produce BOM
5880 on encoding (Bug#10383).
5881
93d5ca1f
JD
58822011-12-26 Jan Djärv <jan.h.d@swipnet.se>
5883
5884 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
5885 can scroll.
5886 (create_and_show_popup_menu): Always use menu_position_func for
5887 Gtk3 (Bug#10361).
5888
ca22b785
AS
58892011-12-24 Andreas Schwab <schwab@linux-m68k.org>
5890
5891 * callint.c (Fcall_interactively): Don't truncate prompt string.
5892
d048e1e6
EZ
58932011-12-23 Eli Zaretskii <eliz@gnu.org>
5894
5895 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
5896 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 5897 resumed from there (after widening). (Bug#10360)
d048e1e6 5898
5ccaba1f
JD
58992011-12-22 Jan Djärv <jan.h.d@swipnet.se>
5900
5901 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
5902
204ee57f
JD
59032011-12-21 Jan Djärv <jan.h.d@swipnet.se>
5904
b81d40f0
JB
5905 * nsterm.m (x_free_frame_resources):
5906 Release f->output_data.ns->miniimage.
204ee57f
JD
5907 (ns_index_color): Fix indentation. Do not retain
5908 color_table->colors[i].
5909
5910 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
5911 before returning.
5912
5913 * nsfns.m (x_set_background_color): Assign return value from
5914 ns_index_color to face-background instead of NSColor*.
5915 (ns_implicitly_set_icon_type): Fix indentation.
5916 Change assignment in for loop to comparison.
5917
5918 * emacs.c (ns_pool): New variable.
5919 (main): Assign ns_pool.
5920 (Fkill_emacs): Call ns_release_autorelease_pool.
5921
5922 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
5923 autorelease fdesc, release fdAttrs and tdict.
5924 (ns_get_covering_families): Release charset.
5925 (ns_findfonts): Release NSFontDescriptor created with new.
5926 (ns_uni_to_glyphs): Fix indentation.
5927 (setString): Release attrStr before assigning new value.
5928
c803b2b7
JD
59292011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5930
678f4426
JD
5931 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
5932 and NS_IMPL_COCOA.
5933 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
5934 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
5935
cd394be1 59362011-12-18 David Reitter <reitter@cmu.edu>
678f4426 5937
5fecd5fc
JD
5938 * nsterm.m (ns_term_init): Subscribe for notifications
5939 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
5940 to method trackingNotification in EmacsMenu.
5941
5942 * nsmenu.m (trackingMenu): New variable.
3771cb17 5943 (trackingNotification): New method (from Aquamacs).
5fecd5fc 5944 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 5945 from Aquamacs (Bug#7030).
678f4426
JD
5946
59472011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 5948
c803b2b7
JD
5949 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
5950 (symbol_to_nsstring): Fix indentation.
5951 (ns_symbol_to_pb): New function.
cae07000
SM
5952 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
5953 (Fns_rotate_cut_buffers_internal): Remove.
5954 (Fns_store_selection_internal): Rename from
c803b2b7
JD
5955 Fns_store_cut_buffer_internal.
5956 (ns_get_foreign_selection, Fx_own_selection_internal)
5957 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
5958 (Fns_get_selection_internal, Fns_store_selection_internal):
5959 Use ns_symbol_to_pb and check if return value is nil.
5960 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
5961 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
5962 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
5963 renamed to Sns_store_selection_internal.
5964 (ns_handle_selection_request): Move code to Fx_own_selection_internal
5965 and remove this function.
5966 (ns_handle_selection_clear): Remove, never used.
5967 (Fx_own_selection_internal): Move code from ns_handle_selection_request
5968 here.
5969
e1b01a3a
KB
59702011-12-17 Ken Brown <kbrown@cornell.edu>
5971
5972 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
5973 GID is unknown (Bug#10257).
5974
2adb6e85
PE
59752011-12-17 Paul Eggert <eggert@cs.ucla.edu>
5976
5977 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
5978 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
5979 which caused a build failure on GNU/Linux IA-64. This problem was
5980 introduced by my 2011-10-07 patch.
5981
d1d7b339
JL
59822011-12-15 Juri Linkov <juri@jurta.org>
5983
5984 * image.c (imagemagick_error): New function. (Bug#10112)
5985 (imagemagick_load_image): Comment out `MagickSetResolution' call.
5986 Use `imagemagick_error' where ImageMagick functions return
5987 `MagickFalse'.
5988 (Fimagemagick_types): Add `Fnreverse' to return the list in the
5989 proper order.
5990
100d5755
KH
59912011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5992
5993 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
5994 fill background (Bug#8992).
5995
454592a6
MR
59962011-12-13 Martin Rudalics <rudalics@gmx.at>
5997
5998 * window.c (Vwindow_combination_resize)
5999 (Vwindow_combination_limit): Use t instead of non-nil in
6000 doc-strings.
61d4b438
MR
6001 (Vrecenter_redisplay): Add first sentence of doc-string on
6002 separate line.
53524d93 6003 (Frecenter): Fix doc-string typo.
454592a6 6004
3633e3aa
KH
60052011-12-11 Kenichi Handa <handa@m17n.org>
6006
6007 * coding.c (Funencodable_char_position): Pay attention to the
6008 buffer text relocation (Bug#9389).
6009
7b9d523a 60102011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 6011
7b9d523a
JD
6012 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
6013 gtk_init (Bug#10100).
6014
b73189c6
EZ
60152011-12-10 Eli Zaretskii <eliz@gnu.org>
6016
6017 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
6018 IT->string is nil. (Bug#10263)
6019
f7dfe5d6
JD
60202011-12-10 Jan Djärv <jan.h.d@swipnet.se>
6021
83faebb4
JD
6022 * nsterm.h (x_free_frame_resources): Declare.
6023
f7dfe5d6
JD
6024 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
6025 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
6026
6027 * nsterm.h (ns_get_defaults_value): Declare.
6028
6029 * nsterm.m (ns_default): Call ns_get_defaults_value.
6030
7cd4e72c
EZ
60312011-12-09 Eli Zaretskii <eliz@gnu.org>
6032
6033 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
6034 (Bug#10170)
6035
b34d7317
YM
60362011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6037
6038 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
6039 that where the value of an _OBJC_* symbol points to is in the .bss
6040 section (Bug#10240).
6041
76470ad1
KH
60422011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
6043
6044 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 6045 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 6046
745fff94
KH
60472011-12-08 Kenichi Handa <handa@m17n.org>
6048
6049 * ftfont.c (get_adstyle_property): Fix previous change
6050 (Bug#10233).
6051
6e44397c
JB
60522011-12-07 Juanma Barranquero <lekktu@gmail.com>
6053
6054 * w32.c (init_environment): If no_site_lisp, remove site-lisp
6055 dirs from the default value of EMACSLOADPATH (bug#10208).
6056
7efa6272
GM
60572011-12-07 Glenn Morris <rgm@gnu.org>
6058
6059 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
6060 installation and source directories as well. (Bug#10208)
6061
f6fc4d87
CY
60622011-12-06 Chong Yidong <cyd@gnu.org>
6063
6064 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
6065
2bf26180
GM
60662011-12-06 Glenn Morris <rgm@gnu.org>
6067
6068 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
6069 as an error, not just -1. (Bug#10217)
6070
3a6ad4f0
CY
60712011-12-05 Chong Yidong <cyd@gnu.org>
6072
6073 * keyboard.c (process_special_events): New function.
6074 (swallow_events, Finput_pending_p): Use it (Bug#10195).
6075
75a3b399
PE
60762011-12-05 Paul Eggert <eggert@cs.ucla.edu>
6077
6078 * coding.c (encode_designation_at_bol): Don't use uninitialized
6079 local variable (Bug#9318).
6080
c3c9e25e
KH
60812011-12-05 Kenichi Handa <handa@m17n.org>
6082
6083 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
6084 return Qnil (Bug#8046, Bug#10193).
6085
5eb05ea3
KH
60862011-12-05 Kenichi Handa <handa@m17n.org>
6087
6088 * coding.c (encode_designation_at_bol): New args charbuf_end and
6089 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
6090 (coding_set_source): Return how many bytes coding->source was
6091 relocated.
6092 (coding_set_destination): Return how many bytes
6093 coding->destination was relocated.
6094 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 6095 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
6096
60972011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
6098
6099 * coding.c (CODING_CHAR_CHARSET_P): New macro.
6100 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
6101 macro (Bug#9318).
6102
61032011-12-05 Andreas Schwab <schwab@linux-m68k.org>
6104
6105 The following changes are to fix Bug#9318.
6106
a79703f5 6107 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
6108 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
6109 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 6110 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 6111
7dbda6df
JB
61122011-12-05 Juanma Barranquero <lekktu@gmail.com>
6113
6114 * lisp.h (process_quit_flag): Fix external declaration.
6115
6d5eb5b0
SM
61162011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
6117
6118 Don't macro-inline non-performance-critical code.
6119 * eval.c (process_quit_flag): New function.
6120 * lisp.h (QUIT): Use it.
6121
a0c3fad0
JD
61222011-12-04 Jan Djärv <jan.h.d@swipnet.se>
6123
6124 * nsfns.m (get_geometry_from_preferences): New function.
6125 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
6126
6c07aac2
AS
61272011-12-04 Andreas Schwab <schwab@linux-m68k.org>
6128
6129 * emacs.c (Qkill_emacs): Define.
6130 (syms_of_emacs): Initialize it.
6131 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
6132 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
6133 (quit_throw_to_read_char): Add parameter `from_signal'.
6134 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
6135 * lisp.h (QUIT): Call Fkill_emacs if requested.
6136
c052ead4
JD
61372011-12-03 Jan Djärv <jan.h.d@swipnet.se>
6138
6139 * widget.c (update_wm_hints): Return if wmshell is null.
6140 (widget_update_wm_size_hints): New function.
6141
6142 * widget.h (widget_update_wm_size_hints): Declare.
6143
6144 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
6145 widget_update_wm_size_hints (Bug#10104).
6146
9e49252b
EZ
61472011-12-03 Eli Zaretskii <eliz@gnu.org>
6148
6149 * xdisp.c (handle_invisible_prop): If the invisible text ends just
6150 before a newline, prepare the bidi iterator for consuming the
6151 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 6152 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 6153
02b16839
JL
61542011-12-02 Juri Linkov <juri@jurta.org>
6155
6156 * search.c (Fword_search_regexp): New Lisp function created from
6157 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
6158 (Fword_search_backward, Fword_search_forward)
6159 (Fword_search_backward_lax, Fword_search_forward_lax):
6160 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
6161 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
6162
0068070e
SM
61632011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
6164
6165 * fileio.c (Finsert_file_contents): Move after-change-function call
6166 to before the "handled:" label, since all "goto handled" appear in
6167 cases where the *-change-functions have already been properly called
6168 (bug#10117).
6169
3360a3fc
AS
61702011-12-01 Andreas Schwab <schwab@linux-m68k.org>
6171
6172 * keyboard.c (interrupt_signal): Don't call kill-emacs when
6173 waiting for input. (Bug#10169)
6174
73d6c093
EZ
61752011-11-30 Eli Zaretskii <eliz@gnu.org>
6176
6177 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
6178 verifies glyph row's hash code--we have just reallocated the
6179 glyphs, so their contents can be complete garbage. (Bug#10164)
6180
febe6bea
JB
61812011-11-30 Juanma Barranquero <lekktu@gmail.com>
6182
6183 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
6184
801a4313
EZ
61852011-11-30 Eli Zaretskii <eliz@gnu.org>
6186
6187 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
6188 attributes are tested _before_ calling verify_row_hash, to protect
6189 against GCC re-ordering of the tests. (Bug#10164)
6190
2b56b87e
JD
61912011-11-29 Jan Djärv <jan.h.d@swipnet.se>
6192
6193 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
6194
6195 * xterm.c (handle_one_xevent): Only set async_visible and friends
6196 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 6197 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
6198 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
6199
dbf31225
PE
62002011-11-28 Paul Eggert <eggert@cs.ucla.edu>
6201
6202 Remove GCPRO-related macros that exist only to avoid shadowing locals.
6203 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
6204 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
6205 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6206 All uses changed to use GCPRO1 etc.
6207 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
6208 Revert to old implementation (i.e., before 2011-03-11).
6209
1305621b
YM
62102011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6211
6212 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
6213 of scroll runs so as to avoid assigning disabled bogus rows and
6214 unnecessary graphics copy operations.
6215
8c9afb46
EZ
62162011-11-27 Eli Zaretskii <eliz@gnu.org>
6217
6218 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
6219 (snprintf) [_MSC_VER]: Redirect to _snprintf.
6220 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
6221 (malloc, free, realloc, calloc): Redirect to e_* only when
6222 compiling Emacs.
6223
6224 * lisp.h (GCTYPEBITS): Move before first use.
6225 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
6226 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
6227 this macro definition.
6228
6229 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
6230 _MSC_VER.
6231
54e9e3bf
JD
62322011-11-27 Jan Djärv <jan.h.d@swipnet.se>
6233
6d5eb5b0
SM
6234 * gtkutil.c (xg_create_frame_widgets):
6235 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
6236 present with Gtk+ 2.0.
6237
83aca1cb
PE
62382011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6239
6240 * fileio.c (Finsert_file_contents): Undo previous change; see
6241 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6242
5b76caa4
PE
62432011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6244
6245 Rename locals to avoid shadowing.
6246 * fileio.c (Finsert_file_contents):
6247 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
6248 * process.c (wait_reading_process_output):
6249 Rename inner 'proc' to 'p' to avoid shadowing.
6250 Indent for consistency with usual Emacs style.
6251
8c535114
EZ
62522011-11-25 Eli Zaretskii <eliz@gnu.org>
6253
6254 * xdisp.c (redisplay_window): If cursor row is not fully visible
6255 after recentering, and scroll-conservatively is set to a large
6256 number, scroll window by a few more lines to make the cursor fully
6257 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
6258 (start_display): Don't move to the next line if the display should
6259 start at a newline that is part of a display vector or an overlay
6260 string. (Bug#10119)
8c535114 6261
fa4fdb5c
JL
62622011-11-24 Juri Linkov <juri@jurta.org>
6263
6264 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
6265 after the `MagickPingImage' call. (Bug#10112)
6266
90ec88df
CY
62672011-11-23 Chong Yidong <cyd@gnu.org>
6268
6269 * window.c (Fcoordinates_in_window_p): Accept only live windows.
6270
56e2e794
MR
62712011-11-23 Martin Rudalics <rudalics@gmx.at>
6272
6273 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
6274 making another buffer current. (Bug#10114)
6275
b6e64c41
GM
62762011-11-23 Glenn Morris <rgm@gnu.org>
6277
6278 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
6279
6b21de18
CY
62802011-11-23 Chong Yidong <cyd@gnu.org>
6281
6282 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
6283 using it (Bug#5984).
6284
b12cd789
EZ
62852011-11-22 Eli Zaretskii <eliz@gnu.org>
6286
6287 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
6288 and header-lines, as they don't have one computed for them.
6289 (Bug#10098)
6290
6291 * .gdbinit (prow): Make displayed values more self-explaining.
6292 Add row's hash code.
6293
261b6fd4
LMI
62942011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
6295
6296 * process.c (wait_reading_process_output): Fix asynchrounous
6297 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 6298 (wait_reading_process_output): Add comment and URL.
261b6fd4 6299
e7cfd277
JD
63002011-11-21 Jan Djärv <jan.h.d@swipnet.se>
6301
6302 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
6303
a9b9b7f5
CY
63042011-11-21 Chong Yidong <cyd@gnu.org>
6305
6306 * window.c (Fnext_window, Fprevious_window): Doc fix.
6307
b0d15b4f
SM
63082011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6309
6310 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
6311
fe7a3057
JB
63122011-11-20 Juanma Barranquero <lekktu@gmail.com>
6313
6314 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
6315
d2999b1a
MR
63162011-11-20 Martin Rudalics <rudalics@gmx.at>
6317
6318 * window.c (Fset_window_combination_limit): Rename argument
6319 STATUS to LIMIT.
6320 (Vwindow_combination_limit): Remove "status" from doc-string.
6321
d5ff9cd0
AS
63222011-11-20 Andreas Schwab <schwab@linux-m68k.org>
6323
6324 * m/ibms390.h: Remove.
6325 * m/ibms390x.h: Don't include "ibms390.h".
6326
a5bb9bd3
SM
63272011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6328
6329 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
6330 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
6331
cd1181db
JB
63322011-11-20 Juanma Barranquero <lekktu@gmail.com>
6333
6334 * casetab.c (Fset_case_table):
6335 * charset.c (Fcharset_after): Fix typos.
6336
615a3b8d 63372011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 6338
17e845af
PE
6339 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
6340 Otherwise, valgrind does not work on some platforms.
6341 Problem reported by Andreas Schwab in
6a0bf43d
PE
6342 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
6343 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
6344 is set, removing the need for VIRT_ADDRESS_VARIES.
6345 (PURE_P): Use a more-efficient implementation that needs just one
6346 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
6347 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
6348 to 4 (xorl, subq, cmpq, setbe).
6349 * alloc.c (pure): Always extern now, since that's the
6350 VIRT_ADDR_VARIES behavior.
6351 (PURE_POINTER_P): Use a single comparison, not two, for
6352 consistency with the new puresize.h.
6353 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
6354 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
6355 Remove VIRT_ADDR_VARIES no longer needed.
6356
f8fe6f96
EZ
63572011-11-19 Eli Zaretskii <eliz@gnu.org>
6358
6359 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
6360 (erase_phys_cursor, update_window_cursor, show_mouse_face)
6361 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
6362 behave as if the cursor position were at the window margin.
6363
6364 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
6365 and the cursor position is out of bounds, behave as if the cursor
6366 position were at the window margin. (Bug#10075)
6367
df05a53c
CY
63682011-11-18 Chong Yidong <cyd@gnu.org>
6369
6370 * window.c (Fwindow_combination_limit): Make first argument
6371 non-optional, since it is meaningless for live windows like the
6372 selected window.
61ccba97 6373
2071918e
DA
63742011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
6375
6376 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
6377
b50a28de
SM
63782011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
6379
6380 * intervals.c: Fix grafting over the whole buffer (bug#10071).
6381 (graft_intervals_into_buffer): Simplify.
6382
015137db
EZ
63832011-11-18 Eli Zaretskii <eliz@gnu.org>
6384
6385 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
6386 hash values of the two rows.
6387 (copy_row_except_pointers): Preserve the used[] arrays and the
6388 hash values of the two rows. (Bug#10035)
68c95424 6389 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
6390
6391 * xdisp.c (row_hash): New function, body extracted from
6392 compute_line_metrics.
6393 (compute_line_metrics): Call row_hash, instead of computing the
6394 hash code inline.
6395
6396 * dispnew.c (verify_row_hash): Call row_hash for computing the
6397 hash code of a row, instead of duplicating code from xdisp.c.
6398
6399 * dispextern.h (row_hash): Add prototype.
6400
a2addb04
TH
64012011-11-18 Tassilo Horn <tassilo@member.fsf.org>
6402
6403 * frame.c (delete_frame): Don't delete the terminal when the last
6404 X frame is closed if emacs is built with GTK toolkit.
6405
df85d315
JB
64062011-11-17 Juanma Barranquero <lekktu@gmail.com>
6407
6408 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
6409
a0c2d0ae
MR
64102011-11-17 Martin Rudalics <rudalics@gmx.at>
6411
6412 * window.c (Vwindow_splits): Rename to
6413 Vwindow_combination_resize. Suggested by Juri Linkov.
6414 (Fsplit_window_internal): Use Vwindow_combination_resize instead
6415 of Vwindow_splits.
6416
58179cce
JB
64172011-11-16 Juanma Barranquero <lekktu@gmail.com>
6418
7877f373
JB
6419 * nsfns.m (Fns_font_name):
6420 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 6421
b6f67890
MR
64222011-11-16 Martin Rudalics <rudalics@gmx.at>
6423
6424 * window.h (window): Rename slot "nest" to "combination_limit".
6425 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
6426 (Fset_window_nest): Rename to Fset_window_combination_limit.
6427 (Vwindow_nest): Rename to Vwindow_combination_limit.
6428 (recombine_windows, make_parent_window, make_window)
6429 (Fsplit_window_internal, saved_window)
6430 (Fset_window_configuration, save_window_save): Rename all
6431 occurrences of window_nest to window_combination_limit.
6432
c7015153
JB
64332011-11-15 Juanma Barranquero <lekktu@gmail.com>
6434
6435 * image.c (imagemagick_load_image): Fix typo.
6436
322ad6ec
EZ
64372011-11-14 Eli Zaretskii <eliz@gnu.org>
6438
6439 * xdisp.c (display_line): Move the call to
6440 highlight_trailing_whitespace before the call to
6441 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
6442 faces of all the glyphs to compute ROW's hash value.
6443 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 6444
f067b8ec
JB
64452011-11-14 Juanma Barranquero <lekktu@gmail.com>
6446
6447 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
6448 just return (bug#10044).
6449
1e5b2111
EZ
64502011-11-12 Eli Zaretskii <eliz@gnu.org>
6451
7ef3cbd5
EZ
6452 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
6453 with user-defined heap size. Bump the default size of the temacs
6454 heap to 27MB, to avoid memory warning when running temacs.
6455 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
6456
1e5b2111
EZ
6457 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
6458 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
6459 (verify_row_hash) [XASSERTS]: New function.
6460 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
6461 that the hash value of glyph rows is correct.
1e5b2111 6462
89d61221
MR
64632011-11-12 Martin Rudalics <rudalics@gmx.at>
6464
6465 * window.h (window): Remove splits slot.
6466 * window.c (Fwindow_splits, Fset_window_splits): Remove.
6467 (Fdelete_other_windows_internal, make_parent_window)
6468 (make_window, Fsplit_window_internal, Fdelete_window_internal)
6469 (Fset_window_configuration, save_window_save): Don't deal with
6470 split status of windows.
6471 (saved_window): Remove splits slot.
6472 (Vwindow_splits): Rewrite doc-string.
6473
97f18cc8
JD
64742011-11-11 Jan Djärv <jan.h.d@swipnet.se>
6475
6476 * xfns.c (unwind_create_frame):
6477 * nsfns.m (unwind_create_frame):
6478 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
6479 Vframe_list (Bug#9999).
6480
22a648b4
DA
64812011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
6482
0b381c7e 6483 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 6484
659afede
KH
64852011-11-11 Kenichi Handa <handa@m17n.org>
6486
6487 * callproc.c (Fcall_process): Set the member dst_multibyte of
6488 process_coding.
6489
9ac0394b
KH
64902011-11-11 Johan Bockgård <bojohan@gnu.org>
6491
6492 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
6493 avoid a crash (bug#9496).
6494
2fbdc249
CY
64952011-11-09 Chong Yidong <cyd@gnu.org>
6496
6497 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
6498 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
6499
ac6b1f81
PE
65002011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6501
6502 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
6503
09db192c
PE
65042011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6505
6506 Avoid some portability problems by eschewing 'extern inline' functions.
6507 The trivial performance wins aren't worth the portability hassles; see
6508 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
6509 et seq.
6510 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6511 (window_box_width, window_box_left, window_box_left_offset)
6512 (window_box_right, window_box_right_offset): Undo previous change,
6513 by removing the "extern"s.
6514 * intervals.c (adjust_intervals_for_insertion)
6515 (adjust_intervals_for_deletion): Undo previous change,
6516 making these static again.
6517 (offset_intervals, temp_set_point_both, temp_set_point)
6518 (copy_intervals_to_string): No longer inline.
6519 * xdisp.c (window_text_bottom_y, window_box_width)
6520 (window_box_height, window_box_left_offset)
6521 (window_box_right_offset, window_box_left, window_box_right)
6522 (window_box): No longer inline.
6523
105216ed
CY
65242011-11-08 Chong Yidong <cyd@gnu.org>
6525
6526 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
6527 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
6528 Signal an error if not a live window.
105216ed
CY
6529 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
6530 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
6531
ae9e237f
JB
65322011-11-07 Juanma Barranquero <lekktu@gmail.com>
6533
6534 * lisp.h (syms_of_abbrev): Remove declaration.
6535 Reported by CHENG Gao <chenggao@royau.me>.
6536
c7aa8333
EZ
65372011-11-07 Eli Zaretskii <eliz@gnu.org>
6538
6539 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
6540 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
6541 of temacs in GUI mode.
6542
be7f5545
MR
65432011-11-07 Martin Rudalics <rudalics@gmx.at>
6544
6545 * window.h: Declare delete_all_child_windows instead of
6546 delete_all_subwindows.
6547 * window.c (Fwindow_nest, Fset_window_nest)
6548 (Fset_window_new_total, Fset_window_new_normal)
6549 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
6550 (delete_all_subwindows): Rename to delete_all_child_windows.
6551 (Fdelete_other_windows_internal, Fset_window_configuration):
6552 Call delete_all_child_windows instead of delete_all_subwindows.
6553 * frame.c (delete_frame): Call delete_all_child_windows instead
6554 of delete_all_subwindows.
6555
ca78dc43
PE
65562011-11-07 Paul Eggert <eggert@cs.ucla.edu>
6557
6558 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
6559 This is also needed for porting to any host where GC_MARK_STACK is
6560 not GC_MAKE_GCPROS_NOOPS.
6561 (which_symbols): Use it.
6562
a0241d01
KH
65632011-11-07 Kenichi Handa <handa@m17n.org>
6564
6565 * coding.c (coding_set_destination): Check coding->src_pos only
6566 when coding->src_object is a buffer (bug#9910).
6567
6568 * process.c (send_process): Set the member src_multibyte of coding
6569 to 0 (bug#9911) when sending a unibyte text.
6570
6571 * callproc.c (Fcall_process): Set the member src_multibyte of
6572 process_coding to 0 (bug#9912).
6573
a64bfdfa 65742011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
6575
6576 * xmenu.c (cleanup_widget_value_tree): New function.
6577 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
6578 calling free_menubar_widget_value_tree directly (Bug#9830).
6579
cb41b32a
PE
65802011-11-06 Paul Eggert <eggert@cs.ucla.edu>
6581
6582 Fix some portability problems with 'inline'.
6583 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6584 (window_box_width, window_box_left, window_box_left_offset)
6585 (window_box_right, window_box_right_offset): Declare extern.
6586 Otherwise, these inline functions do not conform to C99 and
6587 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
6588 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
6589 * intervals.c (adjust_intervals_for_insertion)
6590 (adjust_intervals_for_deletion): Now extern, because otherwise the
6591 extern inline functions 'offset_intervals' couldn't refer to it.
6592 (static_offset_intervals): Remove.
6593 (offset_intervals): Rewrite using the old contents of
6594 static_offset_intervals. The old version didn't conform to C99
6595 because an extern inline function contained a reference to an
6596 identifier with static linkage.
6597
b7041366
AS
65982011-11-06 Andreas Schwab <schwab@linux-m68k.org>
6599
6600 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
6601 GC.
6602
88a37c4d
EZ
66032011-11-06 Eli Zaretskii <eliz@gnu.org>
6604
6605 * xdisp.c (init_iterator, reseat_to_string): Don't set the
6606 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
6607 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
6608 return Qleft_to_right.
6609
49745b39
CY
66102011-11-06 Chong Yidong <cyd@gnu.org>
6611
6612 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
6613 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
6614 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
6615 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
6616 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
6617 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
6618 (Fwindow_vscroll): Doc fix.
6619 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
6620 argument, since it makes no sense to pass a live window and for
6621 consistency with window-child.
6622
1f05cd82
CS
66232011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
6624
6625 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
6626 support MSVC.
6627
22610910
JR
66282011-11-05 Jason Rumney <jasonr@gnu.org>
6629
6630 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
6631 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
6632 fonts (Bug#6029).
6633 (add_font_entity_to_list): Fix logic errors in mixed boolean and
6634 bitwise arithmetic preventing use of unicode-sip and non-truetype
6635 opentype fonts.
6636
a06776b2
EZ
66372011-11-05 Eli Zaretskii <eliz@gnu.org>
6638
3ad924ba
EZ
6639 * s/ms-w32.h (fstat, stat, utime): Move redirections to
6640 "emacs"-only part.
6641
a06776b2
EZ
6642 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
6643 initialization code to keep similarity to xfns.c after changes
6644 from 2011-11-05.
6645
c9e7db78
JD
66462011-11-05 Jan Djärv <jan.h.d@swipnet.se>
6647
a97f8f3f
JD
6648 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
6649 (unwind_create_frame): New function (Bug#9943).
6650 (Fx_create_frame): Restructure code to be more similar to the one in
6651 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
6652 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
6653 Move terminal->reference_count++ just before making the frame official
6654 (Bug#9943).
6655
6656 * nsterm.m (x_free_frame_resources): New function.
6657 (x_destroy_window): Move code to x_free_frame_resources.
6658
c9e7db78 6659 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
6660 (Fx_create_frame, x_create_tip_frame):
6661 Move terminal->reference_count++ just before making the frame
75f1671a 6662 official. Move initialization of image_cache_refcount and
c9e7db78
JD
6663 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
6664
a6fc3b5c
EZ
66652011-11-05 Eli Zaretskii <eliz@gnu.org>
6666
6667 Support MSVC build with newer versions of Visual Studio.
6668 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
6669 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
6670 nt/gmake.defs.
6671
6672 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
6673 which are not supported by MSVC.
6674 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
6675 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
6676 bitfields.
6677 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
6678 types in bitfields.
6679 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
6680
6681 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
6682
58179cce 66832011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
6684
6685 Support MSVC build with newer versions of Visual Studio.
6686 * w32.c: Don't include w32api.h for MSVC.
6687 (init_environment) [_MSC_VER]: Call sys_access, not _access.
6688
6689 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
6690 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
6691 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
6692 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
6693 e_* cousins.
6694 (alloca) [_MSC_VER]: Define to _alloca.
6695
6696 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
6697
6698 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
6699
a58c13ed
EZ
67002011-11-04 Eli Zaretskii <eliz@gnu.org>
6701
6702 * xdisp.c (note_mouse_highlight): If either of
6703 previous/next-single-property-change returns nil, treat that as
6704 the beginning or the end of the buffer. (Bug#9955)
6705
fe0b6370
JD
67062011-11-04 Jan Djärv <jan.h.d@swipnet.se>
6707
a58c13ed 6708 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
6709 label is not null (Bug#9951).
6710 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
6711 may be NULL.
6712
89bd5ee1
EZ
67132011-11-04 Eli Zaretskii <eliz@gnu.org>
6714
6715 * window.c (Fwindow_body_size): Mention in the doc string that the
6716 return value is in frame's canonical units. (Bug#9949)
6717
84c3edb9
EZ
67182011-11-03 Eli Zaretskii <eliz@gnu.org>
6719
4e2fb5c7
EZ
6720 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
6721
84c3edb9 6722 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 6723 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 6724 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 6725
bc17a887
EZ
67262011-11-01 Eli Zaretskii <eliz@gnu.org>
6727
6728 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
6729 Don't stop backward scan on the continuation glyph, even though
6730 its CHARPOS is positive.
6d5eb5b0
SM
6731 (mouse_face_from_buffer_pos, note_mouse_highlight):
6732 Rename cover_string to disp_string.
bc17a887 6733
4ee88440
MR
67342011-11-01 Martin Rudalics <rudalics@gmx.at>
6735
6736 * window.c (temp_output_buffer_show): Don't use
6737 Vtemp_buffer_show_specifiers.
6738 (Vtemp_buffer_show_specifiers): Remove unused variable.
6739
c2ff3c02
EZ
67402011-10-30 Eli Zaretskii <eliz@gnu.org>
6741
6742 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
6743 past the beginning of the current glyph matrix.
6744
58179cce 67452011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
6746
6747 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
6748 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
6749 HAVE_GTK3 (Bug#9869).
b77a6a7f 6750
3b574623
JD
6751 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
6752 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
6753
b77a6a7f
JD
6754 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
6755
6756 * xterm.c: Declare x_handle_net_wm_state to return int.
6757 (handle_one_xevent): Check if we are iconified but don't have
6758 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
6759 (get_current_wm_state): Return non-zero if not hidden,
6760 check for _NET_WM_STATE_HIDDEN (Bug#9893).
6761 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
6762 (x_handle_net_wm_state): Return what get_current_wm_state returns.
6763 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
6764
196e41e4
PE
67652011-10-29 Paul Eggert <eggert@cs.ucla.edu>
6766
6767 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
6768 so that this new function doesn't get optimized away by a
6769 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
6770
021f2e1a
AS
67712011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6772
6773 * frame.h (MOUSE_HL_INFO): Remove excess parens.
6774
8b058d44
EZ
67752011-10-29 Eli Zaretskii <eliz@gnu.org>
6776
6777 Fix the `xbytecode' command.
6778 * .gdbinit (xprintbytestr): New command.
b50a28de 6779 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
6780 (xbytecode): Print the byte-code string as well.
6781
4452fb80
EZ
67822011-10-29 Kim Storm <storm@cua.dk>
6783
8b058d44
EZ
6784 * alloc.c (which_symbols): New function.
6785
21b72067
AS
67862011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6787
6788 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
6789 line. (Bug#9903)
6790
83ed7b5c
GM
67912011-10-29 Glenn Morris <rgm@gnu.org>
6792
6793 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
6794 Not clear what it was for, and it causes various bugs. (Bug#9839)
6795
5a7a728b
EZ
67962011-10-28 Eli Zaretskii <eliz@gnu.org>
6797
6798 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
6799 possible random value that matches one of those tested as
6800 condition to clear the mouse face.
6801
d3d0842f
CY
68022011-10-28 Chong Yidong <cyd@gnu.org>
6803
6804 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
6805
31b39d13
DN
68062011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
6807
6808 * window.c (make_window): Initialize phys_cursor_on_p.
6809
9aba6043
SM
68102011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
6811
6812 * lisp.h (struct Lisp_Symbol): Update comments.
6813
c20992f4
JB
68142011-10-28 Juanma Barranquero <lekktu@gmail.com>
6815
6816 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
6817
db4f02f2
EZ
68182011-10-28 Eli Zaretskii <eliz@gnu.org>
6819
6820 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
6821 <oslsachem@gmail.com> for helping to debug this.
6822
6823 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
6824 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
6825 (g_b_init_get_glyph_outline_w): New static variables.
6826 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
6827 (GetGlyphOutlineW_Proc): New typedefs.
6828 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
6829 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
6830 New functions.
6831 (w32font_open_internal, compute_metrics):
6832 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
6833 instead of calling the "wide" APIs directly.
6834
6835 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
6836
6837 * w32.h (syms_of_w32font): Add prototype.
6838
87e68db4
JB
68392011-10-27 Juanma Barranquero <lekktu@gmail.com>
6840
6841 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
6842 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
6843 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
6844 (Fmove_to_window_line): Doc fix.
6845
435c1d67
CY
68462011-10-27 Chong Yidong <cyd@gnu.org>
6847
6848 * process.c (make_process): Set gnutls_state to NULL.
6849
6850 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
6851 non-NULL, regardless of GNUTLS_INITSTAGE.
6852 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
6853 an error. Set process slots as soon as we allocate them.
6854
6855 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
6856
9c6c6f49
CY
68572011-10-27 Chong Yidong <cyd@gnu.org>
6858
9aba6043
SM
6859 * gnutls.c (emacs_gnutls_deinit): New function.
6860 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
6861 (Fgnutls_deinit, Fgnutls_boot): Use it.
6862
6863 * process.c (make_process): Initialize GnuTLS credentials to NULL.
6864 (deactivate_process): Call emacs_gnutls_deinit.
6865
657d08d3
JB
68662011-10-27 Juanma Barranquero <lekktu@gmail.com>
6867
6868 * image.c (x_create_x_image_and_pixmap):
6869 * w32.c (sys_rename, w32_delayed_load):
6870 * w32font.c (fill_in_logfont):
6871 * w32reg.c (x_get_string_resource): Silence compiler warnings.
6872
5430d399
JB
68732011-10-26 Juanma Barranquero <lekktu@gmail.com>
6874
6875 * w32fns.c (w32_default_color_map): New function,
6876 extracted from Fw32_default_color_map.
a7ef684b 6877 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 6878
fe0055fa
PE
68792011-10-25 Paul Eggert <eggert@cs.ucla.edu>
6880
6881 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
6882
e6346438
SM
68832011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
6884
6885 * keyboard.c (test_undefined): New function (bug#9751).
6886 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
6887
e112cc37
ET
68882011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
6889
6890 * sysdep.c (init_sys_modes): Fix the check for the controlling
6891 terminal (Bug#6649).
6892
7b5d6677
EZ
68932011-10-20 Eli Zaretskii <eliz@gnu.org>
6894
6895 * dispextern.h (struct bidi_it): New member next_en_type.
6896
6897 * bidi.c (bidi_line_init): Initialize the next_en_type member.
6898 (bidi_resolve_explicit_1): When next_en_pos is valid for the
6899 current character, check also for next_en_type being WEAK_EN.
6900 (bidi_resolve_weak): Don't enter the expensive loop if the current
6901 position is before next_en_pos. Record the bidi type of the first
6902 non-ET, non-BN character we find, in addition to its position.
6903 (bidi_level_of_next_char): Invalidate next_en_type when
6904 next_en_pos is over-stepped.
6905
7da0b018
PE
69062011-10-20 Paul Eggert <eggert@cs.ucla.edu>
6907
6908 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
6909 * editfns.c: Rewrite current-time-zone so that it invokes
6910 the equivalent of (format-time-string "%Z") to get the time zone name.
6911 This fixes a bug when the time zone name contains characters that
6912 need converting from the system time locale to Emacs internal format.
6913 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
6914 that patch fixed format-time-string to do the conversion, but
6915 I forgot to fix current-time-zone.
6916 (format_time_string): New function, containing most of
6917 what Fformat_time_string used to contain.
6918 (Fformat_time_string): Rewrite in terms of format_time_string.
6919 This doesn't change this function's behavior.
6920 (current-time-zone): Rewrite to use format_time_string.
6921 This fixes the bug reported by Michael Schierl in
6922 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
6923 Jason Rumney's 2007-06-07 change worked around this bug, but
6924 didn't fix it.
6925 * systime.h (tzname, timezone): Remove no-longer-used declarations.
6926
8547b010
EZ
69272011-10-19 Eli Zaretskii <eliz@gnu.org>
6928
6929 * xdisp.c (start_display): If the character at POS is displayed
6930 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
6931 (try_window_reusing_current_matrix): If a line ends in a display
6932 vector or the next line starts in a display vector, continue
6933 redrawing the window even though the character position of
6934 start_row was reached.
8547b010
EZ
6935 (Bug#9771, part 2)
6936
4e948d15
CY
69372011-10-18 Chong Yidong <cyd@gnu.org>
6938
6939 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
6940 with nobreak-char-display too.
6941
4787455f
EZ
69422011-10-18 Eli Zaretskii <eliz@gnu.org>
6943
6944 Fix part 3 of bug#9771.
6945 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
6946 (bidi_resolve_neutral): Don't enter the expensive loop looking for
6947 non-neutral characters if the current character is a paragraph
6948 separator (a.k.a. Newline). This avoids running the same
6949 expensive loop twice, once when we consume the preceding newline
6950 and the other time when the line actually needs to be displayed.
6951 Avoid the loop when we see neutrals on the base embedding level
6952 following a character whose directionality is the same as the
6953 paragraph's. This avoids running the expensive loop when a line
6954 ends in a long sequence of neutrals, like control characters.
6955 Add assertion against STRONG_AL type. Slightly rearrange code
6956 that determines the type of a neutral given the first non-neutral
6957 that follows it.
6958 (bidi_level_of_next_char): Set next_en_pos to zero when
6959 invalidating its info.
6960
2c91f553
EZ
69612011-10-17 Eli Zaretskii <eliz@gnu.org>
6962
6963 * xdisp.c (push_display_prop): Determine whether to record string
6964 or buffer position by IT->string, not by IT->method. Allow
6965 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
6966 (move_it_vertically_backward): Don't look for character position
6967 immediately after the newline when in a continuation line.
6968 (Bug#9771, part 1)
2c91f553 6969
c7b08b0d
MR
69702011-10-15 Martin Rudalics <rudalics@gmx.at>
6971
6972 * window.c (coordinates_in_window): Rewrite and delabelize
6973 vertical border check. (Bug#5357) (Bug#9618)
6974
6b02f655
SM
69752011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
6976
6977 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
6978 errors in XSetWindowBorder (bug#9310).
6979
81d40c92
DA
69802011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
6981
6982 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
6983 avoid crash when xmalloc overrun checking is enabled.
6984
d4172c3b
EZ
69852011-10-13 Eli Zaretskii <eliz@gnu.org>
6986
6987 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
6988 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
6989 cursor motion with <left> and <right> arrow keys.
6990
6991 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
6992 some callers set that themselves.
6993
b00eea75
EZ
69942011-10-12 Eli Zaretskii <eliz@gnu.org>
6995
6996 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
6997 display string and the previous row comes from the same string and
6998 is empty. (Bug#9739) (Bug#9738)
6999
8fe012c4
SM
70002011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
7001
7002 * doc.c (get_doc_string): Encode file name (bug#9735).
7003
0074aef2
EZ
70042011-10-12 Eli Zaretskii <eliz@gnu.org>
7005
79beb178
EZ
7006 * bidi.c (bidi_level_of_next_char):
7007 * xdisp.c (get_visually_first_element): Remove old incorrect
7008 comments regarding the Unicode Line Separator character.
7009
0074aef2
EZ
7010 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
7011
6e4b3fbe
DA
70122011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
7013
7014 * alloc.c (Fgc_status): Do not access beyond zombies array
7015 boundary if nzombies > MAX_ZOMBIES.
7016 * alloc.c (dump_zombies): Add missing format specifier.
7017
0324f3af
PE
70182011-10-12 Paul Eggert <eggert@cs.ucla.edu>
7019
b5525cac
PE
7020 * xdisp.c (set_cursor_from_row): Simplify conditionals,
7021 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
7022
0324f3af
PE
7023 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
7024 Some packages use them to denote characters with modifiers.
7025
e9b5f888
AS
70262011-10-11 Andreas Schwab <schwab@linux-m68k.org>
7027
7028 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
7029 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
7030 matching a pp-number. Rename parameter var to var1.
7031
127827c0
SM
70322011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
7033
7034 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
7035
c8fd3bd0
GM
70362011-10-08 Glenn Morris <rgm@gnu.org>
7037
7038 * callint.c (Fcall_interactively): Give a more explicit error for the
7039 'c' case with a non-character input. (Bug#8479)
7040
352ec8ff
EZ
70412011-10-08 Eli Zaretskii <eliz@gnu.org>
7042
03669ccb
EZ
7043 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
7044 lines.
7061c986
EZ
7045 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
7046 lines that are hscrolled on the left.
03669ccb 7047
352ec8ff
EZ
7048 * dispnew.c (buffer_posn_from_coords): Account for a possible
7049 presence of header-line. (Bug#4426)
7050
a66cfb1c
SM
70512011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
7052
6b02f655
SM
7053 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
7054 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 7055
7c5ee88e
PE
70562011-10-07 Paul Eggert <eggert@cs.ucla.edu>
7057
7058 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
7059 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
7060 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
7061 this makes Emacs dump core during garbage collection on rare
7062 occasions. sizeof is obviously inferior to offsetof here, so
7063 stick with offsetof.
7064 (GC_POINTER_ALIGNMENT): New macro.
7065 (mark_memory): Omit 3rd (offset) arg; caller changed.
7066 Don't assume EMACS_INT alignment is the same as pointer alignment.
7067
df1bbe5b
SM
70682011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
7069
7070 * keyboard.c (read_key_sequence_remapped): New var.
7071 (read_key_sequence): Compute remapping in the right buffer.
7072 (command_loop_1): Use read_key_sequence's remapping directly.
7073
51553db6
SM
70742011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
7075
32c1fffd
SM
7076 * dired.c (file_name_completion): Don't expand file name.
7077 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
7078 before checking file name handler.
7079
51553db6
SM
7080 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
7081 they've been requested explicitly (bug#9591).
7082
b6bd1599 70832011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
7084
7085 * keymap.c (Fsingle_key_description): Use make_specified_string
7086 instead of build_string to build string from push_key_description.
7087 (Bug#5193)
7088
f701dc2a
PE
70892011-09-30 Paul Eggert <eggert@cs.ucla.edu>
7090
4222c55d
PE
7091 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
7092 This fixes a Y2038 bug on 64-bit hosts.
7093 * buffer.c (reset_buffer):
7094 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
7095 (Fclear_buffer_auto_save_failure):
7096 Use 0, not -1, to represent an unset failure time, since time_t
7097 might not be signed.
7098
f701dc2a
PE
7099 Remove dependency on glibc malloc internals.
7100 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7101 Move back here from lisp.h, but with their new implementations.
7102 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7103 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
7104 * charset.c (charset_table_init): New static var.
7105 (syms_of_charset): Use it instead of xmalloc. This removes a
7106 dependency on glibc malloc internals. See Eli Zaretskii's comment in
7107 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
7108 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7109 Move back to alloc.c.
7110 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7111 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
7112
9ceebf39
JD
71132011-09-30 Jan Djärv <jan.h.d@swipnet.se>
7114
7115 * nsterm.m (windowDidResize): Call x_set_window_size only when
7116 ns_in_resize is true. Otherwise set pixelwidth/height and
7117 call change_frame_size (Bug#9628).
7118
cb993c58
PE
71192011-09-30 Paul Eggert <eggert@cs.ucla.edu>
7120
3930c88b
PE
7121 Port --enable-checking=all to Fedora 14 x86-64.
7122 * charset.c (syms_of_charset): Also account for glibc malloc's
7123 internal overhead when calculating the initial malloc maximum.
7124
cb993c58
PE
7125 Port --enable-checking=all to Fedora 14 x86.
7126 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7127 Move to lisp.h.
7128 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
7129 (overrun_check_realloc, overrun_check_free):
7130 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
7131 That way, xmalloc returns a properly-aligned pointer even if
7132 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
7133 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
7134 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
7135 into account when calculating the initial malloc maximum.
7136 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7137 Move here from alloc.c, so that charset.c can use it too.
7138 Properly align; the old code wasn't right for common 32-bit hosts
7139 when configured with --enable-checking=all.
7140 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7141 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
7142
31bed486
EZ
71432011-09-29 Eli Zaretskii <eliz@gnu.org>
7144
04c70788 7145 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
7146 use EDOM.
7147
fbcaa2f3
EZ
71482011-09-28 Eli Zaretskii <eliz@gnu.org>
7149
7150 * xdisp.c (compute_display_string_end): If there's no display
7151 string at CHARPOS, return -1.
7152
7153 * bidi.c (bidi_fetch_char): When compute_display_string_end
7154 returns a negative value, treat the character as a normal
7155 character not covered by a display string. (Bug#9624)
7156
a239d4e9
JB
71572011-09-28 Juanma Barranquero <lekktu@gmail.com>
7158
7159 * lread.c (Fread_from_string): Fix typo in docstring.
7160
88652fd5
EZ
71612011-09-27 Eli Zaretskii <eliz@gnu.org>
7162
7163 * xdisp.c (handle_invisible_prop): If invisible text ends on a
7164 newline, reseat the iterator instead of bidi-iterating there one
7165 character at a time. (Bug#9610)
32c1fffd
SM
7166 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
7167 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 7168
ed497dd4
AS
71692011-09-27 Andreas Schwab <schwab@linux-m68k.org>
7170
7171 * lread.c (readevalloop): Use correct code for NBSP.
7172 (read1): Likewise. (Bug#9608)
7173
b2bf61aa
MA
71742011-09-25 Michael Albinus <michael.albinus@gmx.de>
7175
7176 * dbusbind.c (Fdbus_register_signal): When service is not
7177 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
7178
32bbb17c
GM
71792011-09-25 Glenn Morris <rgm@gnu.org>
7180
7181 * buffer.c (truncate-lines): Doc fix.
7182
94e0933e
CY
71832011-09-24 Chong Yidong <cyd@stupidchicken.com>
7184
7185 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
7186 (Fset_window_next_buffers): Doc fix.
7187
cddde921
GM
71882011-09-24 Glenn Morris <rgm@gnu.org>
7189
7190 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
7191
1260aef1
PE
71922011-09-24 Paul Eggert <eggert@cs.ucla.edu>
7193
25b4bfa0
PE
7194 Fix minor problems found by static checking.
7195 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
7196 * indent.c (Fvertical_motion): Fix == vs = typo.
7197
e3cbd34b
EZ
71982011-09-24 Eli Zaretskii <eliz@gnu.org>
7199
a66cfb1c
SM
7200 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
7201 Default value is now t. Doc fix.
6bf7006f 7202
e3cbd34b 7203 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 7204 logic when moving up, not only when moving down. Fix the
e3cbd34b 7205 confusing name and values of the it_overshoot_expected variable;
32c1fffd 7206 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
7207
7208 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
7209 CHARPOS is covered by a display string which includes newlines.
7210 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
7211 is covered by a display string with embedded newlines.
7212
a3de0cbd
MA
72132011-09-24 Michael Albinus <michael.albinus@gmx.de>
7214
7215 * dbusbind.c (Fdbus_register_signal): Add match rule to
7216 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
7217 (Fdbus_register_method, Vdbus_registered_objects_table):
7218 Fix docstring.
a3de0cbd 7219
b260039d
JM
72202011-09-24 Jim Meyering <meyering@redhat.com>
7221
32c1fffd 7222 do not ignore write error for any output size
b260039d
JM
7223 The previous change was incomplete.
7224 While it makes emacs --batch detect the vast majority of stdout
7225 write failures, errors were still ignored whenever the output size is
7226 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
7227 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
7228 && echo FAIL: ignored write error
7229 FAIL: ignored write error
7230 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
7231 && echo FAIL: ignored write error
7232 FAIL: ignored write error
7233 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
7234
8eca8a7c
AS
72352011-09-23 Andreas Schwab <schwab@linux-m68k.org>
7236
7237 * emacs.c (Fkill_emacs): In noninteractive mode exit
7238 non-successfully if a write error occurred on stdout. (Bug#9574)
7239
3341db62
EZ
72402011-09-21 Eli Zaretskii <eliz@gnu.org>
7241
7242 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
7243 the xassert test.
7244
7245 * dispextern.h (struct it): Update the comment documenting what
7246 can it->OBJECT be.
7247
8c203dbf
EZ
72482011-09-20 Eli Zaretskii <eliz@gnu.org>
7249
7250 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
7251 a display string, extend search for cursor position to end of row.
7252 (find_row_edges): If the row ends in a newline from a display
7253 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
7254 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
7255 (Fcurrent_bidi_paragraph_direction): Fix search for previous
7256 non-empty line. Fixes confusing cursor motion with arrow keys at
7257 the beginning of a line that starts with whitespace.
8c203dbf 7258
a4824228
LMI
72592011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7260
7261 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
7262 (bug#9493).
7263
33ed493b
CY
72642011-09-18 Chong Yidong <cyd@stupidchicken.com>
7265
7266 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
7267 boolean (Bug#9154).
7268
56cd55c8
EZ
72692011-09-18 Eli Zaretskii <eliz@gnu.org>
7270
7271 * xdisp.c (display_line): Record maximum and minimum buffer
7272 positions even if no glyphs were produced (e.g., by a zero-width
7273 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
7274 buffer positions that will be removed from the glyph row because
7275 they don't fit.
c02dcedf
EZ
7276 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
7277 column is beyond frame width: don't subtract 1 "pixel" when
7278 computing width of the stretch.
3e62b7e0
EZ
7279 (reseat_at_next_visible_line_start): Undo the change made on
7280 2011-09-17 that saved paragraph information and restored it after
7281 the call to `reseat'. (Bug#9545)
56cd55c8 7282
5ed99d36 72832011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
7284
7285 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
7286 and turn window cursor on if cleared (Bug#9415).
7287
5ed99d36 72882011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
7289
7290 * search.c (boyer_moore): Take unibyte characters from pattern
7291 literally. (Bug#9458)
7292
9bade7b2
EZ
72932011-09-18 Eli Zaretskii <eliz@gnu.org>
7294
7295 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
7296
e5e9d610
PE
72972011-09-18 Paul Eggert <eggert@cs.ucla.edu>
7298
87e4427a
PE
7299 Fix minor problem found by static checking.
7300 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
7301 initialized, to pacify gcc -Wuninitialized.
7302
e5e9d610
PE
7303 * fileio.c: Report proper errno when syscall falls.
7304 (Finsert_file_contents): Save and restore errno,
7305 so that report_file_error outputs the correct diagnostic.
7306 (Fwrite_region) [CLASH_DETECTION]: Likewise.
7307
a1674f0b
EZ
73082011-09-18 Eli Zaretskii <eliz@gnu.org>
7309
7310 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
7311
fbfb6dd4
EZ
73122011-09-17 Eli Zaretskii <eliz@gnu.org>
7313
7314 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
7315 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
7316
bb187662
EZ
73172011-09-17 Eli Zaretskii <eliz@gnu.org>
7318
1137e8b8 7319 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 7320 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
7321
7322 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
7323 (bidi_find_paragraph_start): Search back for paragraph beginning
7324 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
7325 (bidi_move_to_visually_next): Only trigger paragraph-related
7326 computations when the last character is a newline or at EOB, not
7327 just any NEUTRAL_B. (Bug#9470)
7328
bb187662
EZ
7329 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
7330 truncated lines if point is covered by a display string. (Bug#9524)
7331
2e621251
PE
73322011-09-16 Paul Eggert <eggert@cs.ucla.edu>
7333
7334 * xselect.c: Relax test for outgoing X longs (Bug#9498).
7335 (cons_to_x_long): New function.
7336 (lisp_data_to_selection_data): Use it. Correct the test for
7337 short-versus-long data; it was negated. Break out of vector
7338 loop, for efficiency, when a long datum is discovered.
7339
91a15bc6
SM
73402011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
7341
7342 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
7343
b41c3a35
EZ
73442011-09-16 Eli Zaretskii <eliz@gnu.org>
7345
7346 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
7347 GCC PR/17406) by declaring this function with external scope.
7348
7812ba2d
PE
73492011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7350
7351 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
7352 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
7353
cf7edc2a
AS
73542011-09-15 Andreas Schwab <schwab@linux-m68k.org>
7355
7356 * editfns.c (Fformat): Correctly handle text properties on "%%".
7357
bd01620e
EZ
73582011-09-15 Eli Zaretskii <eliz@gnu.org>
7359
7360 * xterm.c (x_draw_composite_glyph_string_foreground):
7361 * w32term.c (x_draw_composite_glyph_string_foreground):
7362 * term.c (encode_terminal_code):
7363 * composite.c (composition_update_it, get_composition_id):
7364 * xdisp.c (get_next_display_element)
7365 (fill_composite_glyph_string): Add comments about special meaning
7366 of TAB characters in a composition.
7367
a02719a3
PE
73682011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7369
7370 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
7371 This occurs when processing a multibyte format.
7372 Problem reported by Wolfgang Jenker.
a02719a3 7373
72589a3c
JB
73742011-09-15 Johan Bockgård <bojohan@gnu.org>
7375
7376 * xdisp.c (try_cursor_movement): Only check for exact match if
7377 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
7378
1c14176c
PE
73792011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7380
7381 Remove unused external symbols.
7382 * dispextern.h (calc_pixel_width_or_height): Remove decl.
7383 * xdisp.c (calc_pixel_width_or_height): Now static.
7384 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
7385 * indent.c (check_display_width):
7386 * w32term.c: Fix comment to match code.
7387 * xterm.c, xterm.h (x_catching_errors): Remove.
7388
d2eea5b5
PE
73892011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7390
7391 * xselect.c: Use signed conversions more consistently (Bug#9498).
7392 (selection_data_to_lisp_data): Assume incoming selection data are
7393 signed integers, not unsigned. This is to be consistent with
7394 outgoing selection data, which was modified to use signed integers
7395 in as part of the fix to Bug#9196 in response to Jan D.'s comment
7396 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
7397 expects long, not unsigned long.
7398
46888499
EZ
73992011-09-14 Eli Zaretskii <eliz@gnu.org>
7400
7401 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
7402 computation of loop end. Reported by Johan Bockgård
7403 <bojohan@gnu.org>.
7404
ef8ef9fb
CY
74052011-09-13 Chong Yidong <cyd@stupidchicken.com>
7406
7407 * frame.c (Fother_visible_frames_p): Function deleted.
7408
fa819fed
EZ
74092011-09-12 Eli Zaretskii <eliz@gnu.org>
7410
7411 * indent.c (compute_motion): Process display vector front to back
7412 rather than the other way around. (Bug#2496)
7413
2ba8e008
SM
74142011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
7415
7416 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
7417
20f53c69
CY
74182011-09-11 Chong Yidong <cyd@stupidchicken.com>
7419
7420 * minibuf.c (Fread_from_minibuffer): Doc fix.
7421
d562d7a4
EZ
74222011-09-11 Eli Zaretskii <eliz@gnu.org>
7423
7424 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
7425 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
7426
1c4d7f3d
LMI
74272011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7428
7429 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
7430 value for non-existent files.
7431
b885bf36
EZ
74322011-09-11 Eli Zaretskii <eliz@gnu.org>
7433
7434 * fileio.c (Finsert_file_contents): If the file cannot be opened,
7435 set its "size" to -1. This will set the modtime_size field of
7436 the corresponding buffer to -1, which is what
7437 verify-visited-file-modtime expects for files that do not exist.
7438 (Bug#9139)
7439
6612f0bf
PE
74402011-09-11 Paul Eggert <eggert@cs.ucla.edu>
7441
7442 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
7443 here ...
7444 * lisp.h: ... from here. push_key_description is no longer
7445 defined in keyboard.c, so its declaration should not be in
7446 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
7447 logically belongs with push_key_description.
7448
dfb3f755
PE
74492011-09-10 Paul Eggert <eggert@cs.ucla.edu>
7450
7451 * buffer.h: Include <sys/types.h> instead of <time.h>.
7452 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
7453 Problem reported by Herbert J. Skuhra.
7454
3134906c
LMI
74552011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
7456
7457 * xml.c (parse_region): Make the parsing work for
7458 non-comment-starting XML files again (bug#9144).
7459
8d903f4e
AS
74602011-09-10 Andreas Schwab <schwab@linux-m68k.org>
7461
7462 * image.c (gif_load): Fix calculation of bottom and right corner.
7463 (Bug#9468)
7464
80ad64f4
EZ
74652011-09-10 Eli Zaretskii <eliz@gnu.org>
7466
7467 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
7468 redisplay in small windows.
7469
208a048d
EZ
74702011-09-09 Eli Zaretskii <eliz@gnu.org>
7471
7472 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
7473
9b1c252e
MR
74742011-09-08 Martin Rudalics <rudalics@gmx.at>
7475
7476 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
7477 Operate on live windows only.
7478
2949f33b
JB
74792011-09-08 Juanma Barranquero <lekktu@gmail.com>
7480
7481 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
7482
e08dcafd
EZ
74832011-09-07 Eli Zaretskii <eliz@gnu.org>
7484
7485 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
7486 only under bidi iteration.
7487
115b96bd
JD
74882011-09-07 Jan Djärv <jan.h.d@swipnet.se>
7489
7490 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
7491
c8199d0f
PE
74922011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7493
7494 isnan: Fix porting problem to Solaris 10 with bundled gcc.
7495 Without this fix, the command to link temacs failed due to an
7496 undefined symbol __builtin_isnan. This is because
7497 /usr/include/iso/math_c99.h #defines isnan(x) to
7498 __builtin_isnan(x), but the bundled gcc, which identifies itself
7499 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
7500 a __builtin_isnan.
7501 * floatfns.c (isnan): #undef, and then #define to a clone of
7502 what's in data.c.
7503 (Fisnan): Always define, since it's always available now.
7504 (syms_of_floatfns): Always define isnan at the Lisp level.
7505
e39b275c 75062011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
7507
7508 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
7509
b2db44d9 75102011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 7511
f4af5137 7512 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
7513 The previous code assumed that file offsets (off_t values) fit in
7514 EMACS_INT variables, which is not true on typical 32-bit hosts.
7515 The code messed up by falsely reporting buffer overflow in cases
7516 such as (insert-file-contents "big" nil 1 2) into an empty buffer
7517 when "big" contains more than 2**29 bytes, even though this
7518 inserts just one byte and does not overflow the buffer.
7519 (Finsert_file_contents): Store file offsets as off_t
7520 values, not as EMACS_INT values. Check for overflow when
7521 converting between EMACS_INT and off_t. When checking for
7522 buffer overflow or for overlap, take the offsets into account.
7523 Don't use EMACS_INT for small values where int suffices.
7524 When checking for overlap, fix a typo: ZV was used where
7525 ZV_BYTE was intended.
7526 (Fwrite_region): Don't assume off_t fits into 'long'.
7527 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
7528
ecfc0a49
MA
75292011-09-05 Michael Albinus <michael.albinus@gmx.de>
7530
7531 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
7532
6511acf2 75332011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 7534
0999621a 7535 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
7536
7537 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 7538 (esprintf, exprintf, evxprintf): New functions.
62f19c19 7539 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 7540 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
7541 (modify_event_symbol): Do not assume that the length of
7542 name_alist_or_stem is safe to alloca and fits in int.
7543 (Fexecute_extended_command): Likewise for function name and binding.
7544 (Frecursion_depth): Wrap around reliably on integer overflow.
7545 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
7546 since some callers pass EMACS_INT values.
7547 (Fsingle_key_description): Don't crash if symbol name contains more
7548 than MAX_ALLOCA bytes.
7549 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
7550 (get_minibuffer): Arg is now EMACS_INT, not int.
7551 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 7552 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
7553 * window.h (command_loop_level, minibuf_level): Reflect API changes.
7554
2be7d702
PE
7555 * dbusbind.c (signature_cat): New function.
7556 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
7557 Do not overrun buffer; instead, report string overflow.
7558
9d1df220
PE
7559 * dispnew.c (add_window_display_history): Don't overrun buffer.
7560 Truncate instead; this is OK since it's just a log.
7561
33ef5c64
PE
7562 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
7563 even if the time zone offset is outlandishly large.
7564 Don't mishandle offset == INT_MIN.
7565
66c6fdd5
PE
7566 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
7567 when creating daemon; the previous buffer-overflow check was incorrect.
7568
d749b01b
PE
7569 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
7570 which has the guts of the old verror function.
7571
b5cd1905
PE
7572 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
7573 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
7574
6e1a67fb
PE
7575 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
7576 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 7577 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 7578 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
7579 length of string rather than counting it via multiple sprintfs;
7580 that's simpler and more reliable.
c21721cc
PE
7581 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
7582 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
7583 sprintf, in case result does not fit in int.
7584
c57b67fc
PE
7585 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
7586 (fontset_from_font): Print it.
7587
8a401434
PE
7588 * frame.c (tty_frame_count): Now printmax_t, not int.
7589 (make_terminal_frame, set_term_frame_name): Print it.
7590 (x_report_frame_params): In X, window IDs are unsigned long,
7591 not signed long, so print them as unsigned.
7592 (validate_x_resource_name): Check for implausibly long names,
7593 and don't assume name length fits in 'int'.
7594 (x_get_resource_string): Don't blindly alloca invocation name;
7595 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
7596 not fit in int.
7597
6e1a67fb
PE
7598 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
7599 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
7600 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
7601
0df02bf3
PE
7602 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
7603 Use esprintf, not sprintf, in case result does not fit in int.
7604
48e30793
PE
7605 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7606 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
7607 it as a large positive number.
7608 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
7609 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7610
a66ff6d8
PE
7611 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
7612 in case result does not fit in int.
7613
aca216ff
PE
7614 * print.c (float_to_string): Detect width overflow more reliably.
7615 (print_object): Make sprintf buffer a bit bigger, to avoid potential
7616 buffer overrun. Don't assume list length fits in 'int'. Treat
7617 print length of 0 as 0, not as infinity; to be consistent with other
7618 uses of print length in this function. Don't overflow print length
7619 index. Don't assume hash table size fits in 'long', or that
7620 vectorlike size fits in 'unsigned long'.
7621
31c286f7
PE
7622 * process.c (make_process): Use printmax_t, not int, to format
7623 process-name gensyms.
7624
55e5faa1
PE
7625 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
7626
80f2e268
PE
7627 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
7628 to avoid potential buffer overrun.
7629
670741ab
PE
7630 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
7631 if X resource line is longer than 512 bytes.
7632
b7163a50
PE
7633 * xfns.c (x_window): Make sprintf buffer a bit bigger
7634 to avoid potential buffer overrun.
7635
ae58ff1f
PE
7636 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
7637
c43c8a6a
PE
7638 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
7639
3f8236f4
PE
76402011-09-04 Paul Eggert <eggert@cs.ucla.edu>
7641
53e9fe90 7642 Integer overflow fixes for scrolling, etc.
6511acf2
PE
7643 Without these, Emacs silently mishandles large integers sometimes.
7644 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
7645 it were "C-u 1 M-x recenter" on a typical 64-bit host.
7646
6511acf2
PE
7647 * xdisp.c (try_window_id): Check Emacs fixnum range before
7648 converting to 'int'.
806add1d 7649
6511acf2 7650 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
7651 Check that an Emacs fixnum is in range before assigning it to 'int'.
7652 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
7653 values converted from Emacs fixnums.
7654 (Frecenter): Don't wrap around a line count if it is out of 'int'
7655 range; instead, treat it as an extreme value.
7656 (Fset_window_configuration, compare_window_configurations):
7657 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
7658
6511acf2
PE
7659 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
7660 that can exceed INT_MAX. Check that EMACS_INT value is in range
7661 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
7662 (match_limit): Don't assume that a fixnum can fit in 'int'.
7663
6511acf2 7664 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
7665 exceed INT_MAX.
7666
6511acf2 7667 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
7668 (Fvertical_motion): Don't wrap around LINES values that don't fit
7669 in 'int'. Instead, treat them as extreme values. This is good
7670 enough for windows, which can't have more than INT_MAX lines anyway.
7671
fcb901a7
LMI
76722011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7673
0f2f6b6d
LMI
7674 * Require libxml/parser.h to avoid compilation warning.
7675
fcb901a7
LMI
7676 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
7677
7678 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
7679 since this reportedly can destroy thread storage.
7680
6e20a0d4
CY
76812011-08-30 Chong Yidong <cyd@stupidchicken.com>
7682
7683 * syntax.c (find_defun_start): Update all cache variables if
7684 exiting early (Bug#9401).
7685
148ae00e
EZ
76862011-08-30 Eli Zaretskii <eliz@gnu.org>
7687
f6cfbd8f
EZ
7688 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
7689
148ae00e
EZ
7690 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
7691 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
7692 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
7693
7694 * term.c (tty_append_glyph): New function.
7695 (produce_stretch_glyph): Static function and its prototype deleted.
7696
a66cfb1c
SM
7697 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
7698 Add prototypes.
148ae00e 7699
c4a07a4c
PE
77002011-08-29 Paul Eggert <eggert@cs.ucla.edu>
7701
7702 * image.c (parse_image_spec): Check for nonnegative, not for positive,
7703 when checking :margin (Bug#9390).
7704 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 7705 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
7706 so that the name doesn't mislead. All uses changed.
7707
6bc8cd65
JB
77082011-08-28 Johan Bockgård <bojohan@gnu.org>
7709
7710 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
7711 set_tty_hooks.
7712
dca4927e
EZ
77132011-08-27 Eli Zaretskii <eliz@gnu.org>
7714
7715 * xdisp.c (move_it_to): Don't bail out early when reaching
7716 position beyond to_charpos, if we are scanning backwards.
7717 (move_it_vertically_backward): When DY == 0, make sure we get to
7718 the first character in the line after the newline.
7719
f2cad773
PE
77202011-08-27 Paul Eggert <eggert@cs.ucla.edu>
7721
7722 * ccl.c: Improve and simplify overflow checking (Bug#9196).
7723 (ccl_driver): Do not generate an out-of-range pointer.
7724 (Fccl_execute_on_string): Remove unnecessary check for
7725 integer overflow, noted by Stefan Monnier in
7726 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
7727 Remove a FIXME that didn't need fixing.
7728 Simplify the newly-introduced buffer reallocation code.
7729
0cae2cdb
JB
77302011-08-27 Juanma Barranquero <lekktu@gmail.com>
7731
7732 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
7733
5fc295a4 77342011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 7735
70c60eb2 7736 Integer and memory overflow issues (Bug#9196).
726e0ab1 7737
d31850da
PE
7738 * doc.c (get_doc_string): Rework so that
7739 get_doc_string_buffer_size is the actual buffer size, rather than
7740 being 1 less than the actual buffer size; this makes xpalloc more
7741 convenient.
7742
a69fbedb
PE
7743 * image.c (x_allocate_bitmap_record, cache_image):
7744 * xselect.c (Fx_register_dnd_atom):
7745 Simplify previous changes by using xpalloc.
7746
fe5c5d37
PE
7747 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
7748 since either will do and ptrdiff_t is convenient with xpalloc.
7749
0065d054
PE
7750 * charset.c (charset_table_size)
7751 (struct charset_sort_data.priority): Now ptrdiff_t.
7752 (charset_compare): Don't overflow if priorities differ greatly.
7753 (Fsort_charsets): Don't assume list length fits in int.
7754 Check for size-calculation overflow when allocating sort data.
7755 (syms_of_charset): Allocate an initial charset table that is
7756 just under 64 KiB, to avoid problems with glibc malloc and mmap.
7757
7758 * cmds.c (internal_self_insert): Check for size-calculation overflow.
7759
7760 * composite.h (struct composition.glyph_len): Now int, not unsigned.
7761 The actual value is always <= INT_MAX, and leaving it unsigned made
7762 overflow checking harder.
7763
7764 * dispextern.h (struct glyph_matrix.rows_allocated)
7765 (struct face_cache.size): Now ptrdiff_t, for convenience in use
7766 with xpalloc. The values are still always <= INT_MAX.
7767
7768 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
7769
7770 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
7771 (SAFE_NALLOCA): New macro.
7772
7773 * region-cache.c (struct boundary.pos, find_cache_boundary)
7774 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
7775 (set_cache_region, invalidate_region_cache)
7776 (revalidate_region_cache, know_region_cache, region_cache_forward)
7777 (region_cache_backward, pp_cache):
7778 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
7779 so that ptrdiff_t * can be passed to xpalloc.
7780 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
7781 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
7782 (pp_cache): Don't assume cache_len fits in int.
7783 * region-cache.h: Adjust extern decls to match.
7784
7785 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
7786 EMACS_INT, since either will do, for xpalloc.
7787
7788 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
7789 (xnmalloc, xnrealloc, xpalloc): New functions.
7790
726e0ab1
PE
7791 * bidi.c (bidi_shelve_header_size): New constant.
7792 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
7793 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
7794
51f30bc5 7795 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
7796 * buffer.c (overlays_at, overlays_in, record_overlay_string)
7797 (overlay_strings):
7798 Don't update size of array until after memory allocation succeeds,
7799 because xmalloc/xrealloc may not return.
0065d054
PE
7800 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
7801 now that we have proper integer overflow checking.
7802 (record_overlay_string, overlay_strings): Catch overflows when
7803 calculating size of overlay_str_buf.
726e0ab1 7804
0065d054
PE
7805 * callproc.c (Fcall_process): Check for size overflow when
7806 calculating size of args2.
7807 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
7808 Normally we prefer signed values, but sticking with ptrdiff_t would
7809 require adding more-complicated checks.
726e0ab1
PE
7810
7811 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
7812 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
7813 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 7814 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
7815
7816 * character.c (Fstring): Check for size-calculation overflow.
7817
7818 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
7819 unnecessary integer overflow. Check for size overflow.
7820 (encode_coding_object): Don't update size until xmalloc succeeds.
7821
7822 * composite.c (get_composition_id): Check for overflow in glyph
7823 length calculations.
7824
7825 Integer and memory overflow fixes for display code.
7826 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
7827 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
7828 (scrolling_window): Check for overflow in size calculations.
7829 (line_draw_cost, realloc_glyph_pool, add_row_entry):
7830 Don't assume glyph table len fits in int.
7831 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
7832 (row_table_size): Now ptrdiff_t, not int.
7833 (scrolling_window): Avoid overflow in size calculations.
7834 Don't update size until allocation succeeds.
7835 * fns.c (concat): Check for overflow in size calculations.
7836 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
7837 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7838 (NEXT_ALMOST_PRIME_LIMIT): New constant.
7839
7840 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
7841 (get_doc_string): Check for size calculation overflow.
7842 Don't update size until allocation succeeds.
7843 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
7844 EMACS_INT, where ptrdiff_t will do.
7845 (Fsubstitute_command_keys): Check for string overflow.
7846
7847 * editfns.c (set_time_zone_rule): Don't assume environment length
7848 fits in int.
7849 (message_length): Now ptrdiff_t, not int.
7850 (Fmessage_box): Don't update size until allocation succeeds.
7851 Don't assume message length fits in int.
7852 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
7853
0065d054
PE
7854 * emacs.c (main): Do not reallocate argv, since there is a null at
7855 the end that can be overwritten, and this way there's no need to
7856 worry about size-calculation overflow.
7857 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
7858
7859 * eval.c (init_eval_once, grow_specpdl): Don't update size until
7860 alloc succeeds.
7861 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
7862
7863 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
7864 (x_set_scroll_bar_width, x_figure_window_size):
7865 Check for integer overflow.
7866 (x_set_alpha): Do not assume XINT fits in int.
7867
7868 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
7869 This is for the members text_lines, text_cols, total_lines, total_cols,
7870 where the system imposes an 'int' limit.
7871
7872 * fringe.c (Fdefine_fringe_bitmap):
7873 Don't update size until alloc works.
7874
7875 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
7876 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
7877
7878 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
7879 Check for size-calculation overflow.
7880 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
7881 do, as we prefer signed integers.
7882 (id_to_widget.max_size, id_to_widget.used)
7883 (xg_store_widget_in_map, xg_remove_widget_from_map)
7884 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
7885 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
7886 Use and return ptrdiff_t, not int.
7887 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
7888 * gtkutil.h: Change prototypes to match the above.
7889
7890 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
7891 are duplicate now that they've been promoted to lisp.h.
7892 (x_allocate_bitmap_record, x_alloc_image_color)
7893 (make_image_cache, cache_image, xpm_load):
7894 Don't update size until alloc is done.
7895 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
7896 (x_detect_edges):
3256efce 7897 Check for size calculation overflow.
726e0ab1
PE
7898 (ct_colors_allocated_max): New constant.
7899 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
7900 overflow.
3256efce 7901
726e0ab1
PE
7902 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
7903 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
7904 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
7905 Use ptrdiff_t, not int, to count maps.
7906 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
7907 calculations. Don't update size until allocation succeeds.
7908 Redo calculations to avoid overflow.
726e0ab1
PE
7909 * keyboard.h: Change prototypes to match the above.
7910
7911 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
7912 to count maps.
7913 (current_minor_maps): Check for size calculation overflow.
7914 * keymap.h: Change prototypes to match the above.
7915
7916 * lread.c (read1, init_obarray): Don't update size until alloc done.
7917
7918 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
7919 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
7920
726e0ab1
PE
7921 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
7922 Now ptrdiff_t, not int.
7923 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
7924 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
7925
7926 * process.c (Fnetwork_interface_list): Check for overflow
7927 in size calculation.
7928
7929 * region-cache.c (move_cache_gap): Check for size calculation overflow.
7930
7931 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
7932 overflow. Don't bother calling xmalloc when xrealloc will do.
7933
7934 * search.c (Freplace_match): Check for size calculation overflow.
7935 (Fset_match_data): Don't assume list lengths fit in 'int'.
7936
7937 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
7938 for command line length. Do not attempt to address one before the
7939 beginning of an array, as that's not portable.
7940
7941 * term.c (max_frame_lines): Remove; unused.
7942 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
7943 not int.
7944 (encode_terminal_code, calculate_costs): Check for size
7945 calculation overflow.
7946 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
7947 table lengths and related sizes. Don't update size until alloc
7948 done. Redo calculations to avoid overflow.
7949 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
7950
7951 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
7952 subtracting pointers.
7953 (gobble_line): Check for overflow more carefully. Don't update size
7954 until alloc done.
7955
7956 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
7957 Don't update size until alloc done.
7958 Redo size calculations to avoid overflow.
7959 Check for size calculation overflow.
0065d054 7960 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
7961
7962 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
7963 Use ptrdiff_t, not int, for sizes.
7964 (store_mode_line_noprop_char): Don't update size until alloc done.
7965
0065d054
PE
7966 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
7967 Use ptrdiff_t, not int, for sizes.
7968 (Finternal_make_lisp_face, cache_face):
7969 Check for size calculation overflow.
7970 (cache_face): Treat size calculation overflows as if they were
7971 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
7972
7973 * xfns.c (x_encode_text, x_set_name_internal)
7974 (Fx_change_window_property): Use ptrdiff_t, not int, to count
7975 sizes, since they can exceed INT_MAX in size. Check for size
7976 calculation overflow.
7977
0065d054
PE
7978 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
7979 (xg_select): Check for size calculation overflow.
726e0ab1
PE
7980 Don't update size until alloc done.
7981
0065d054 7982 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 7983 as sprintf is limited to int lengths.
1d526e2f 7984
252c5ee1
PE
7985 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
7986 (X_LONG_MIN): New macros.
864d7ce7
PE
7987 Use them to make the following changes clearer.
7988 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
7989 This change doesn't affect the value now, but it may help remind
7990 future maintainers not to raise the value too much later.
7991 (SELECTION_QUANTUM): Remove, replacing with ...
7992 (selection_quantum): ... new function, which avoids overflow.
7993 All uses changed.
7994 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
7995 assumption that selection length fits in 'int'.
7996 (x_reply_selection_request, x_handle_selection_request)
7997 (x_get_window_property, receive_incremental_selection)
7998 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
7999 (lisp_data_to_selection_data, clean_local_selection_data):
8000 Use ptrdiff_t, not int, to record length of selection.
8001 (x_reply_selection_request, x_get_window_property)
8002 (receive_incremental_selection, x_property_data_to_lisp):
8003 Redo calculations to avoid overflow.
8004 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 8005 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
8006 something.
8007 (x_get_window_property, receive_incremental_selection)
8008 (lisp_data_to_selection_data, x_property_data_to_lisp):
8009 Check for size-calculation overflow.
8010 (x_get_window_property, receive_incremental_selection)
8011 (lisp_data_to_selection_data, Fx_register_dnd_atom):
8012 Don't store size until memory allocation succeeds.
8013 (x_get_window_property): Plug memory leak on memory exhaustion.
8014 Don't double-block input; malloc is safe here. Don't assume 2**34
8015 - 4 fits in unsigned long. Add an xassert to check
8016 XGetWindowProperty overflow. Be more careful about overflow
8017 calculations, and distinguish size from memory overflow better.
8018 (receive_incremental_selection): When tracing, don't assume
8019 unsigned int is less than INT_MAX.
8020 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
8021 harmful) conversions of unsigned short to int.
8022 (lisp_data_to_selection_data): Don't assume that integers
8023 in the range -65535 through -1 fit in an X unsigned short.
8024 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
8025 result parameters unless successful. Rely on cons_to_unsigned
8026 to report problems with elements; the old code wasn't right anyway.
8027 (x_check_property_data): Check for int overflow; we cannot use
8028 a wider type due to X limits.
8029 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
8030
726e0ab1 8031 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 8032
0065d054
PE
8033 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
8034 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
8035 (x_color_cells): Don't store size until memory allocation succeeds.
8036 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 8037 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
8038 (x_term_init): Don't assume length fits in int (sprintf is limited
8039 to int size).
bc18e09d 8040
ebfa62c0
PE
8041 Use ptrdiff_t for composition IDs.
8042 * character.c (lisp_string_width):
8043 * composite.c (composition_table_size, n_compositions)
8044 (get_composition_id, composition_gstring_from_id):
8045 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
8046 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
8047 * window.c (Frecenter):
8048 Use ptrdiff_t, not int, for composition IDs.
8049 * composite.c (get_composition_id): Check for integer overflow.
8050 * composite.h: Adjust prototypes to match the above changes.
8051
d3411f89
PE
8052 Use ptrdiff_t for hash table indexes.
8053 * category.c (hash_get_category_set):
8054 * ccl.c (ccl_driver):
8055 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
8056 * coding.c (coding_system_charset_list, detect_coding_system):
8057 * coding.h (struct coding_system.id):
8058 * composite.c (get_composition_id, gstring_lookup_cache):
8059 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
8060 * image.c (xpm_get_color_table_h):
8061 * lisp.h (hash_lookup, hash_put):
8062 * minibuf.c (Ftest_completion):
8063 Use ptrdiff_t for hash table indexes, not int (which is too
8064 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
8065 32-bit --with-wide-int hosts).
8066
e097a6fa
PE
8067 * charset.c (Fdefine_charset_internal): Check for integer overflow.
8068 Add a FIXME comment about memory leaks.
8069 (syms_of_charset): Don't assume xmalloc returns.
8070
5637687f
PE
8071 Don't assume that stated character widths fit in int.
8072 * character.c (Fchar_width, c_string_width, lisp_string_width):
8073 * character.h (CHAR_WIDTH):
8074 * indent.c (MULTIBYTE_BYTES_WIDTH):
8075 Use sanitize_char_width to avoid undefined and/or bad behavior
8076 with outlandish widths.
a66cfb1c 8077 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
8078 now that we have two such functions. All uses changed.
8079 (sanitize_char_width): New inline function.
8080
a2271ba2
PE
8081 Don't assume that tab-width fits in int.
8082 * character.h (sanitize_width): New inline function.
8083 (SANE_TAB_WIDTH): New macro.
8084 (ASCII_CHAR_WIDTH): Use it.
8085 * indent.c (sane_tab_width): Remove. All uses replaced by
8086 SANE_TAB_WIDTH (current_buffer).
8087 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
8088
18c52557
PE
8089 * fileio.c: Integer overflow issues with file modes.
8090 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
8091
caeeedc1
PE
8092 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
8093 Remove unreachable code.
8094 (read_hex, load_charset_map_from_file): Check for integer overflow.
8095
6df6ae42 8096 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
8097 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
8098 (x_send_scroll_bar_event): Likewise. Check that the size does not
8099 exceed limits imposed by XClientMessageEvent, as well as the usual
8100 ptrdiff_t and size_t limits.
8101
b13995db
PE
8102 * keyboard.c: Overflow, signedness and related fixes.
8103 (make_lispy_movement): Use same integer type in forward decl
8104 that is used in the definition.
8105 (read_key_sequence, keyremap_step):
8106 Change bufsize argument back to int, undoing my 2011-03-30 change.
8107 We prefer signed types, and int is wide enough here.
8108 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
8109 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
8110 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
8111 length, not size_t. Use ptrdiff_t for index, not int.
8112 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
8113 possibility of integer overflow.
8114
13464394
PE
8115 Overflow, signedness and related fixes for images.
8116
8117 * dispextern.h (struct it.stack[0].u.image.image_id)
8118 (struct_it.image_id, struct image.id, struct image_cache.size)
8119 (struct image_cache.used, struct image_cache.ref_count):
8120 * gtkutil.c (update_frame_tool_bar):
8121 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
8122 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
8123 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
8124 * nsmenu.m (update_frame_tool_bar):
8125 * xdisp.c (calc_pixel_width_or_height):
8126 * xfns.c (image_cache_refcount):
8127 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
8128 on typical 64-bit hosts.
8129
8130 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
8131 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
8132 Omit unnecessary casts to int.
8133 (parse_image_spec): Check that integers fall into 'int' range
8134 when the callers expect that.
8135 (image_ascent): Redo ascent calculation to avoid int overflow.
8136 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
8137 (lookup_image): Remove unnecessary tests.
8138 (xbm_image_p): Locals are now of int, not EMACS_INT,
8139 since parse_image_check makes sure they fit into int.
8140 (png_load, gif_load, svg_load_image):
8141 Prefer int to unsigned where either will do.
8142 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
8143 old tiff_error_handler and tiff_warning_handler.
8144 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
8145 stack buffer overflows. It uses only the features of vsnprintf
8146 that are common to both POSIX and native Microsoft.
8147 (tiff_error_handler, tiff_warning_handler): Use it.
8148 (tiff_load, gif_load, imagemagick_load_image):
8149 Don't assume :index value fits in 'int'.
8150 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
8151 (imagemagick_load_image): Check that crop parameters fit into
8152 the integer types that MagickCropImage accepts. Don't assume
8153 Vimagemagick_render_type has a nonnegative value. Don't assume
8154 size_t fits in 'long'.
8155 (gs_load): Use printmax_t to print the widest integers possible.
8156 Check for integer overflow when computing image height and width.
8157
c11821d4
EZ
81582011-08-26 Eli Zaretskii <eliz@gnu.org>
8159
8160 * xdisp.c (redisplay_window): Don't force window start if point
8161 will be invisible in the resulting window. (Bug#9324)
8162
0c95fcf7
EZ
81632011-08-25 Eli Zaretskii <eliz@gnu.org>
8164
8165 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
8166 the display spec is of the form `(space ...)'.
8167 (handle_display_spec): Return the value returned by
8168 handle_single_display_spec, not just 1 or zero.
8169 (handle_single_display_spec): If the display spec is of the form
8170 `(space ...)', and specifies display in the text area, return 2
8171 rather than 1.
fee65a97 8172 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
8173 accurately, and prefer exact match for point under bidi.
8174 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
8175
8176 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
8177 into disp_prop; all users changed.
8178
8179 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
8180 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
8181 for the text covered by the display property.
8182
e4ed06f1
CY
81832011-08-25 Chong Yidong <cyd@stupidchicken.com>
8184
8185 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
8186 Change return value to nil.
8187 (Frecord_buffer): Delete unused function.
8188
f67cdd7f
EZ
81892011-08-24 Eli Zaretskii <eliz@gnu.org>
8190
5980d4c6
EZ
8191 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
8192 buffers, return left-to-right.
8610fe8b
EZ
8193 (set_cursor_from_row): Consider candidate row a win if its glyph
8194 represents a newline and point is on that newline. Fixes cursor
8195 positioning on the newline at EOL of R2L text within L2R
8196 paragraph, and vice versa.
8197 (try_cursor_movement): Check continued rows, in addition to
8198 continuation rows. Fixes unwarranted scroll when point enters a
8199 continued line of R2L text within an L2R paragraph, or vice versa.
8200 (cursor_row_p): Consider the case of point being equal to
8201 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
8202 from the end of a short line to the beginning of a continued line
8203 of R2L text within L2R paragraph.
8204 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
8205 composed characters.
5980d4c6 8206
f67cdd7f
EZ
8207 * bidi.c (bidi_check_type): Use xassert.
8208 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
8209 members.
8210
bca633fb
EZ
82112011-08-23 Eli Zaretskii <eliz@gnu.org>
8212
8213 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
8214 a character.
8215
4a5885a7
CY
82162011-08-23 Chong Yidong <cyd@stupidchicken.com>
8217
8218 * nsfont.m (ns_otf_to_script): Fix typo.
8219
0902a04e
KH
82202011-08-22 Kenichi Handa <handa@m17n.org>
8221
8222 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
8223 extra slot even if the purpose is char-code-property-table.
8224
1a2e6670
EZ
82252011-08-23 Eli Zaretskii <eliz@gnu.org>
8226
8ddde651
EZ
8227 * xdisp.c (redisplay_window): When computing centering_position,
8228 account for the height of the header line. (Bug#8874)
8229
425cc014
EZ
8230 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
8231 instead of CHAR_TO_BYTE. Fixes a crash when a completion
8232 candidate is selected by the mouse, and that candidate has a
8233 composed character under the mouse.
8234
1a2e6670
EZ
8235 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
8236 coordinates reported by pos-visible-in-window-p for a composed
8237 character in column zero.
8238
8b76d6f8
SM
82392011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
8240
8241 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
8242
dac347dd
EZ
82432011-08-22 Eli Zaretskii <eliz@gnu.org>
8244
8245 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
8246 consider it a hit if to_charpos is anywhere in the range of the
8247 composed buffer positions.
8248
e013fb34
CY
82492011-08-22 Chong Yidong <cyd@stupidchicken.com>
8250
8251 * image.c (gif_load): Don't assume that each subimage has the same
8252 dimensions as the base image. Handle disposal method that is
8253 "undefined" by the gif spec (Bug#9335).
8254
bd1ba3e8
CY
82552011-08-20 Chong Yidong <cyd@stupidchicken.com>
8256
8257 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 8258 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 8259
54a1215b
EZ
82602011-08-19 Eli Zaretskii <eliz@gnu.org>
8261
823564e5
EZ
8262 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
8263 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
8264 from an Org mode buffer to a Speedbar frame.
8265
54a1215b
EZ
8266 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
8267 a composition, take its buffer position from IT->cmp_it.charpos.
8268 Fixes cursor positioning at the beginning of a line that begins
8269 with a composed character.
8270
9778ebcc
EZ
82712011-08-18 Eli Zaretskii <eliz@gnu.org>
8272
0be6ee06
EZ
8273 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
8274 character bidirectional type, use STRONG_L instead. Fixes crashes
8275 in a buffer produced by `describe-categories'.
8276
9778ebcc
EZ
8277 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
8278 members before the level stack, so they would be saved and
8279 restored when copying iterator state. Fixes incorrect reordering
8280 around TABs covered by display properties.
8281
156bffbe
AS
82822011-08-18 Andreas Schwab <schwab@linux-m68k.org>
8283
6b02f655 8284 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 8285
72ad093b
CY
82862011-08-17 Chong Yidong <cyd@stupidchicken.com>
8287
8288 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
8289 (internal_condition_case_2, internal_condition_case_n):
8290 Remove unnecessary aborts (Bug#9081).
72ad093b 8291
35774242
EZ
82922011-08-17 Eli Zaretskii <eliz@gnu.org>
8293
8294 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
8295 has no `load' handler, try opening the file locally. (Bug#9311)
8296
db76dd85
KB
82972011-08-16 Ken Brown <kbrown@cornell.edu>
8298
8299 * gmalloc.c: Expand comment.
8300
b215eee5
EZ
83012011-08-16 Eli Zaretskii <eliz@gnu.org>
8302
8303 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
8304 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
8305
a4579d33
KB
83062011-08-16 Ken Brown <kbrown@cornell.edu>
8307
8308 Fix memory allocation problems in Cygwin build (Bug#9273).
8309
8310 * unexcw.c ( __malloc_initialized): Declare external variable.
8311 (fixup_executable): Force the dumped emacs to reinitialize malloc.
8312
8b76d6f8
SM
8313 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
8314 New variables.
a4579d33
KB
8315 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
8316 dumped emacs.
8317 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
8318 in the static heap.
8319 [CYGWIN] (special_realloc): New function.
8320 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
8321 requests to realloc storage in the static heap.
8322
3ebec551
PE
83232011-08-15 Paul Eggert <eggert@cs.ucla.edu>
8324
8325 * bidi.c (bidi_initialize): Remove unused local.
8326
9fd8be00
EZ
83272011-08-15 Eli Zaretskii <eliz@gnu.org>
8328
6b02f655
SM
8329 * bidimirror.h:
8330 * biditype.h: Remove file.
8331 * makefile.w32-in ($(BLD)/bidi.$(O)):
8332 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
8333
8334 * dispextern.h: Fix a typo in the comment to bidi_type_t.
8335
8336 * chartab.c: Improve commentary for the uniprop_table API.
8337
32413314
EZ
8338 * bidi.c (bidi_paragraph_init): Support zero value of
8339 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
8340 (bidi_initialize): Use uniprop_table instead of including
8341 biditype.h and bidimirror.h.
32413314 8342
9fd8be00
EZ
8343 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
8344 coordinates of the iterator when restoring from ppos_it.
8345 (Bug#9296)
8346
5cf2b69b
KH
83472011-08-14 Kenichi Handa <handa@m17n.org>
8348
8349 * process.c (create_process): Call setup_process_coding_systems
72ad093b 8350 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 8351
daf17d00
EZ
83522011-08-14 Eli Zaretskii <eliz@gnu.org>
8353
8354 * xdisp.c (move_it_in_display_line_to): Don't invoke
8355 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
8356 ppos_it. Fixes vertical cursor motion when line beginning is
8357 covered by an image. (Bug#9296)
8358
08e3161a
JD
83592011-08-14 Jan Djärv <jan.h.d@swipnet.se>
8360
8361 * nsterm.h (ns_run_ascript): Declare.
8362 (NSAPP_DATA2_RUNASSCRIPT): Define.
8363
8364 * nsfns.m (as_script, as_result, as_status): New static variables.
8365 (ns_run_ascript): New function.
5e617bc2 8366 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
8367 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
8368 the event loop. Get status from as_status (Bug#7276).
8369
8370 * nsterm.m (sendEvent): If event is NSApplicationDefined and
8371 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
8372 the event loop (Bug#7276).
8373
a3720aa2
AS
83742011-08-14 Andreas Schwab <schwab@linux-m68k.org>
8375
8376 * gnutls.c (QCgnutls_bootprop_priority)
8377 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
8378 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
8379 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
8380 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
8381 (QCgnutls_bootprop_verify_hostname_error)
8382 (QCgnutls_bootprop_callbacks_verify): Rename from
8383 Qgnutls_bootprop_..., all uses changed.
8384
8385 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
8386 uses changed.
8387
0a0d27fb
PE
83882011-08-14 Paul Eggert <eggert@cs.ucla.edu>
8389
19d5c50c
PE
8390 * xfaces.c (Qframe_set_background_mode): Now static.
8391 * dispextern.h (Qframe_set_background_mode): Remove decl.
8392
0a0d27fb
PE
8393 * process.c (Fnetwork_interface_info): Declare local only if needed.
8394
377538cb
JD
83952011-08-13 Jan Djärv <jan.h.d@swipnet.se>
8396
8397 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
8398 (Fnetwork_interface_list): Allocate in increments of bytes instead
8399 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
8400 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
8401 sockaddr.
8402 (struct ifflag_def): notrailers is smart on OSX.
8403 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
8404 Get hardware address with getifaddrs if available.
8405
08fff70c
EZ
84062011-08-12 Eli Zaretskii <eliz@gnu.org>
8407
8408 * xdisp.c (iterate_out_of_display_property): xassert that
8409 IT->position is set to within IT->object's boundaries. Break from
8410 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
8411 when IT->position is set up wrongly due to some bug.
8412 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
8413 (push_display_prop): Allow GET_FROM_STRING as IT->method on
8414 entry. Force push_it to save on the stack the current
8415 buffer/string position, to be restored by pop_it. Fix flags in
8416 the iterator structure wrt the object coming from a display
8417 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
8418 properties. (Bug#9284)
8419
7be1c708 84202011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 8421
7be1c708
CY
8422 * fontset.c (fontset_get_font_group): Add proper type checks.
8423 (Bug#9172)
aac0c6e3 8424
7be1c708 84252011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 8426
7be1c708
CY
8427 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
8428 and LC_VERSION_MIN_MACOSX.
8429 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
8430 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 8431
97bb72a6
EZ
84322011-08-08 Eli Zaretskii <eliz@gnu.org>
8433
8434 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
8435 no-display-properties-and-no-overlays under bidi display.
8436 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 8437 properties and overlays.
97bb72a6 8438
d5617611
CY
84392011-08-08 Chong Yidong <cyd@stupidchicken.com>
8440
37e11a63
CY
8441 * editfns.c (Fset_time_zone_rule): Document relationship with the
8442 setenv function.
8443
d5617611
CY
8444 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
8445 the font entity extracted from the cache (Bug#8109).
8446
58872834
CY
84472011-08-07 Chong Yidong <cyd@stupidchicken.com>
8448
8449 * composite.c (autocmp_chars): Don't reset point. That is done by
8450 restore_point_unwind (Bug#5984).
8451
75bfc667
JL
84522011-08-07 Juri Linkov <juri@jurta.org>
8453
8454 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
8455 to show the arg `TIME' instead of `TIMEVAL'.
8456
d1410150
EZ
84572011-08-06 Eli Zaretskii <eliz@gnu.org>
8458
8459 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
8460 display property strides EOL and includes a newline, as in
8461 longlines-mode. (Bug#9254)
75b771e4
EZ
8462 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
8463 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
8464
8465 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
8466 is non-zero, even if the data buffer is NULL. Fixes a crash in
8467 vertical-motion with longlines-mode. (Bug#9254)
8468
35928349
EZ
84692011-08-05 Eli Zaretskii <eliz@gnu.org>
8470
ec7cc85b
EZ
8471 * bidi.c <bidi_cache_total_alloc>: Now static.
8472 (bidi_initialize): Initialize bidi_cache_total_alloc.
8473
8b76d6f8 8474 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
8475 cache. (Bug#9221)
8476
8477 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
8478 amount allocated this far in `bidi_cache_total_alloc'.
8479 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
8480 non-zero, only free the data buffer without restoring the cache
8481 contents. All callers changed.
8482
8483 * dispextern.h (bidi_unshelve_cache): Update prototype.
8484
8485 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
8486 (move_it_in_display_line, move_it_to)
8487 (move_it_vertically_backward, move_it_by_lines): Replace the call
8488 to xfree to an equivalent call to bidi_unshelve_cache.
8489 (move_it_in_display_line_to): Fix logic of returning
412b6358 8490 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 8491
e2e2423b
EZ
84922011-08-05 Eli Zaretskii <eliz@gnu.org>
8493
8494 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
8495 came from a string character with a `cursor' property. (Bug#9229)
8496
ae9e757a
JD
84972011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8498
8499 * Makefile.in (LIB_PTHREAD): New variable.
8500 (LIBES): Add LIB_PTHREAD (Bug#9216).
8501
8502 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
8503 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
8504
213bd7f2
AS
85052011-08-04 Andreas Schwab <schwab@linux-m68k.org>
8506
6b02f655 8507 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 8508
99aaf75f
JD
85092011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8510
8511 * xterm.c (x_find_topmost_parent): New function.
8512 (x_set_frame_alpha): Find topmost parent window with
8513 x_find_topmost_parent and set the property there also (bug#9181).
8514 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
8515
c74e9d86
PE
85162011-08-04 Paul Eggert <eggert@cs.ucla.edu>
8517
8518 * callproc.c (Fcall_process): Avoid vfork clobbering
8519 the local vars buffer, coding_systems, current_dir.
8520
640c8776
SM
85212011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
8522
8523 * keymap.c (Fmake_composed_keymap): Move to subr.el.
8524
f26d0e4c
PE
85252011-08-03 Paul Eggert <eggert@cs.ucla.edu>
8526
8a10d76c
PE
8527 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
8528 so that it is not optimized away.
8529
f26d0e4c
PE
8530 * xdisp.c (compute_display_string_pos): Remove unused local.
8531
55439c61
EZ
85322011-08-02 Eli Zaretskii <eliz@gnu.org>
8533
8534 Fix slow cursor motion and scrolling in large buffers with
8535 selective display, like Org Mode buffers. (Bug#9218)
8536
8537 * dispextern.h (struct bidi_it): New member disp_prop_p.
8538
8539 * xdisp.c: Remove one-slot cache of display string positions.
8540 (compute_display_string_pos): Accept an additional argument
5e617bc2 8541 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
8542 for a display string or property. If found, set DISP_PROP_P
8543 non-zero.
8544
8545 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
8546 DISP_PROP_P, and pass it to compute_display_string_pos.
8547 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
8548 non-zero. All callers of bidi_fetch_char changed.
8549
fb33fa43
SM
85502011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
8551
8552 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
8553
b099e063
DM
85542010-12-03 Don March <don@ohspite.net>
8555
8556 * keymap.c (Fdefine_key): Fix non-prefix key error message when
8557 last character M-[char] is translated to ESC [char] (bug#7541).
8558
5cc7f7af
KH
85592011-08-02 Kenichi Handa <handa@m17n.org>
8560
d0fffa3f 8561 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
8562
8563 * chartab.c (uniprop_table): Make it non-static.
8564
525d5e6e
EZ
85652011-08-01 Eli Zaretskii <eliz@gnu.org>
8566
8567 * xdisp.c (forward_to_next_line_start): Accept additional argument
8568 BIDI_IT_PREV, and store into it the state of the bidi iterator had
8569 on the newline.
8570 (reseat_at_next_visible_line_start): Use the bidi iterator state
8571 returned by forward_to_next_line_start to restore the state of
8572 it->bidi_it after backing up to previous newline. (Bug#9212)
8573
31011111
AS
85742011-07-30 Andreas Schwab <schwab@linux-m68k.org>
8575
8576 * regex.c (re_comp): Protoize.
8577 (re_exec): Fix return type.
8578 (regexec): Fix type of `ret'. (Bug#9203)
8579
476371c4
PE
85802011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8581
e5d76069
PE
8582 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
8583 This is needed if max-image-size is a floating-point number.
8584
9a79b20c
AS
85852011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8586
8587 * print.c (print_object): Print empty symbol as ##.
8588
8589 * lread.c (read1): Read ## as empty symbol.
8590
d8c2fa78
AA
85912011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
8592
8593 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
8594 setting frame foreground color (Bug#9175).
8595 (x_set_background_color): Likewise.
8596
ffe57a7a
AA
8597 * nsmenu.m (-setText): Size tooltip dimensions precisely to
8598 contents (Bug#9176).
8599 (EmacsTooltip -init): Remove bezels and add shadows to
8600 tooltip windows.
8601
bf3492a5
AA
8602 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
8603 or scroll bar (Bug#8470).
8604
d55e9c53
AA
8605 * nsfont.m (nsfont_open): Remove assignment to voffset and
8606 unnecessary vars hshink, expand, hd, full_height, min_height.
8607 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
8608
8609 * nsterm.h (nsfont_info): Remove voffset field.
8610
d8c2fa78 86112011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
8612
8613 Implement strike-through and overline on NextStep (Bug#8863).
8614
8615 * nsfont.m (nsfont_open): Use underline position provided by font,
8616 instead of hard-coded value of 2.
8617 (nsfont_draw): Call ns_draw_text_decoration instead.
8618
8619 * nsterm.h: Add declaration for ns_draw_text_decoration.
8620
8621 * nsterm.m (ns_draw_text_decoration): New function for drawing
8622 underline, overline, and strike-through.
8623 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
8624 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 8625 accommodate underlining, etc.
4843aac3 8626
4cc60b9b
EZ
86272011-07-28 Eli Zaretskii <eliz@gnu.org>
8628
bc7ece87
EZ
8629 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
8630 default.
4cc60b9b 8631
476371c4
PE
86322011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8633
66606eea
PE
8634 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
8635 Without this fix, if a signal arrives just after memory fills up,
8636 'malloc' might be invoked reentrantly.
8637
476371c4
PE
8638 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
8639 In other words, assume that every image size is allowed, on non-X
8640 hosts. This assumption is probably wrong, but it lets Emacs compile.
8641
f3fcc40d
AS
86422011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8643
8644 * regex.c (re_iswctype): Convert return values to boolean.
8645
350c992f
EZ
86462011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
8647
8648 * xdisp.c (compute_display_string_pos): Don't use cached display
8649 string position if the buffer had its restriction changed.
8650 (Bug#9184)
8651
5266b4bb
PE
86522011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8653
8654 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8655
2573a837 86562011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 8657
41f55ccd 8658 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 8659
39e378da
PE
8660 * bidi.c: Integer size and overflow fixes.
8661 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
8662 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
8663 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8664 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
8665 (bidi_find_other_level_edge):
8666 Use ptrdiff_t instead of EMACS_INT where either will do.
8667 This works better on 32-bit hosts configured --with-wide-int.
8668 (bidi_cache_ensure_space): Check for size-calculation overflow.
8669 Use % rather than repeated addition, for better worst-case speed.
8670 Don't set bidi_cache_size until after xrealloc returns, because it
8671 might not return.
8672 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
8673 (bidi_cache_ensure_space): Also check that the bidi cache size
8674 does not exceed that of the largest Lisp string or buffer. See Eli
8675 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 8676
5e927815
PE
8677 * alloc.c (__malloc_size_t): Remove.
8678 All uses replaced by size_t. See Andreas Schwab's note
8679 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
8680
ca4aa935
PE
8681 * image.c: Improve checking for integer overflow.
8682 (check_image_size): Assume that f is nonnull, since
8683 it is always nonnull in practice. This is one less thing to
8684 worry about when checking for integer overflow later.
8685 (x_check_image_size): New function, which checks for integer
8686 overflow issues inside X.
8687 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
8688 This removes the need for a memory_full check.
8689 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
8690 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
8691 (xbm_read_bitmap_data): Change locals back to 'int', since
8692 their values must fit in 'int'.
8693 (xpm_load_image, png_load, tiff_load):
8694 Invoke x_create_x_image_and_pixmap earlier,
8695 to avoid much needless work if the image is too large.
8696 (tiff_load): Treat overly large images as if
8697 x_create_x_image_and_pixmap failed, not as malloc failures.
8698 (gs_load): Use x_check_image_size.
8699
5f8f9cc2
PE
8700 * gtkutil.c: Omit integer casts.
8701 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
8702 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
8703
5adf60bc
PE
8704 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
8705
c8907a93
PE
8706 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
8707 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
8708 would wrongly return t on a 64-bit host.
8709
e3c25c68
PE
8710 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
8711 The plain *_OVERFLOW macros run afoul of GCC bug 49705
8712 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
8713 and therefore cause GCC to emit a bogus diagnostic in some cases.
8714
3f791afe
PE
8715 * image.c: Integer signedness and overflow and related fixes.
8716 This is not an exhaustive set of fixes, but it's time to
8717 record what I've got.
8718 (lookup_pixel_color, check_image_size): Remove redundant decls.
8719 (check_image_size): Don't assume that arbitrary EMACS_INT values
8720 fit in 'int', or that arbitrary 'double' values fit in 'int'.
8721 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
8722 (tiff_load, imagemagick_load_image):
8723 Check for overflow in size calculations.
8724 (x_create_x_image_and_pixmap): Remove unnecessary test for
8725 xmalloc returning NULL; that can't happen.
8726 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
8727 (xpm_color_bucket): Use better integer hashing function.
8728 (xpm_cache_color): Don't possibly over-allocate memory.
8729 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
8730 (gif_memory_source):
8731 Use ptrdiff_t, not int or size_t, to record sizes.
8732 (png_load): Don't assume values greater than 2**31 fit in 'int'.
8733 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
8734 either works, as we prefer signed integers.
8735 (tiff_read_from_memory, tiff_write_from_memory):
8736 Return tsize_t, not size_t, since that's what the TIFF API wants.
8737 (tiff_read_from_memory): Don't fail simply because the read would
8738 go past EOF; instead, return a short read.
8739 (tiff_load): Omit no-longer-needed casts.
8740 (Fimagemagick_types): Don't assume size fits into 'int'.
8741
3cc5a532
PE
8742 Improve hashing quality when configured --with-wide-int.
8743 * fns.c (hash_string): New function, taken from sxhash_string.
8744 Do not discard information about ASCII character case; this
8745 discarding is no longer needed.
8746 (sxhash-string): Use it. Change sig to match it. Caller changed.
8747 * lisp.h: Declare it.
8748 * lread.c (hash_string): Remove, since we now use fns.c's version.
8749 The fns.c version returns a wider integer if --with-wide-int is
8750 specified, so this should help the quality of the hashing a bit.
8751
b312a492
PE
8752 * emacs.c: Integer overflow minor fix.
8753 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
8754 Define only if GNU_LINUX.
8755 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
8756
dfd153ae
PE
8757 * dispnew.c: Integer signedness and overflow fixes.
8758 Remove unnecessary forward decls, that were a maintenance hassle.
8759 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
8760 All uses changed.
8761 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
8762 (scrolling_window): Use ptrdiff_t, not int, for byte count.
8763 (prepare_desired_row, line_draw_cost):
8764 Use int, not unsigned, where either works.
8765 (save_current_matrix, restore_current_matrix):
8766 Use ptrdiff_t, not size_t, where either works.
8767 (init_display): Check for overflow more accurately, and without
8768 relying on undefined behavior.
8769
a81d11a3
PE
8770 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
8771 Remove, replacing with the new symbols in lisp.h. All uses changed.
8772 * fileio.c (make_temp_name):
8773 * filelock.c (lock_file_1, lock_file):
8774 * xdisp.c (message_dolog):
8775 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
8776 Use pMd etc. instead.
8777 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
8778 replacing the pWIDE etc. symbols removed from editfns.c.
8779
3300e6fd
PE
8780 * keyboard.h (num_input_events): Now uintmax_t.
8781 This is (very slightly) less likely to mess up due to wraparound.
8782 All uses changed.
8783
fd05c7e9
PE
8784 * buffer.c: Integer signedness fixes.
8785 (alloc_buffer_text, enlarge_buffer_text):
8786 Use ptrdiff_t rather than size_t when either will do, as we prefer
8787 signed integers.
8788
903fe15d
PE
8789 * alloc.c: Integer signedness and overflow fixes.
8790 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
8791 (__malloc_size_t): Default to size_t, not to int.
8792 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
8793 (Fgarbage_collect, mark_object_loop_halt, mark_object):
8794 Prefer ptrdiff_t to size_t when either would do, as we prefer
8795 signed integers.
8796 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
8797 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
8798 Now const. Initialize with values that are in range even if char
8799 is signed.
8800 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
8801 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
8802 These functions do the right thing with sizes > 2**32.
8803 (check_depth): Now ptrdiff_t, not int.
8804 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
8805 Adjust to new way of storing sizes. Check for size overflow bugs
8806 in rest of code.
8807 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
8808 slightly wrong anyway, as it missed one instance of
8809 XMALLOC_OVERRUN_CHECK_OVERHEAD.
8810 (refill_memory_reserve): Omit needless cast to size_t.
8811 (mark_object_loop_halt): Mark as externally visible.
8812
ac82cc6a
PE
8813 * xselect.c: Integer signedness and overflow fixes.
8814 (Fx_register_dnd_atom, x_handle_dnd_message):
8815 Use ptrdiff_t, not size_t, since we prefer signed.
8816 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
8817 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
8818 x_dnd_atoms_size and x_dnd_atoms_length.
8819
c2d1e36d
PE
8820 * doprnt.c: Prefer signed to unsigned when either works.
8821 * eval.c (verror):
8822 * doprnt.c (doprnt):
8823 * lisp.h (doprnt):
8824 * xdisp.c (vmessage):
8825 Use ptrdiff_t, not size_t, when using or implementing doprnt,
8826 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
8827 prefer signed arithmetic to avoid comparison confusion.
8828 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
8829 but is a bit tricky.
8830
0e926e56
PE
8831 Assume freestanding C89 headers, string.h, stdlib.h.
8832 * data.c, doprnt.c, floatfns.c, print.c:
8833 Include float.h unconditionally.
8834 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
8835 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
8836 * regex.c: Likewise for stddef.h, string.h.
8837 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
8838 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
8839 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
8840 (STDC_HEADERS): Remove obsolete defines.
8841 * sysdep.c: Include limits.h unconditionally.
8842
9cfdb3ec
PE
8843 Assume support for memcmp, memcpy, memmove, memset.
8844 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
8845 * regex.c (memcmp, memcpy):
8846 Remove; we assume C89 now.
8847
8848 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
8849 (__malloc_safe_bcopy): Remove; no longer needed.
8850
cf950e6b 8851 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
8852 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
8853 well either way, and we prefer signed to unsigned.
8854
dbf38e02
LMI
88552011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
8856
8857 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
8858 closes the connection while we're reading (bug#9182).
8859
d6f0886c 88602011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 8861
d6f0886c
JD
8862 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
8863 are specified (Bug#9168).
24e0f6b1 8864
2eb1f9e6
PE
88652011-07-25 Paul Eggert <eggert@cs.ucla.edu>
8866
8867 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
8868 Found by GCC static checking and --with-wide-int on a 32-bit host.
8869
22381272 88702011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
8871
8872 * xdisp.c (compute_display_string_pos): Fix logic of caching
8873 previous display string position. Initialize cached_prev_pos to
8874 -1. Fixes slow-down at the beginning of a buffer.
8875
f25e39b4
EZ
88762011-07-24 Eli Zaretskii <eliz@gnu.org>
8877
8878 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
8879 for attrs[LFACE_FONTSET_INDEX].
8880
04c4b52e
PE
88812011-07-23 Paul Eggert <eggert@cs.ucla.edu>
8882
8883 * xml.c (parse_region): Remove unused local
8884 that was recently introduced.
8885
c1734fbd
EZ
88862011-07-23 Eli Zaretskii <eliz@gnu.org>
8887
be18c5a5
EZ
8888 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
8889 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
8890
c1734fbd
EZ
8891 * xdisp.c (move_it_in_display_line_to): Record the best matching
8892 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
8893 exit if none of the characters scanned was an exact match.
8894 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
8895 when exact match is impossible due to invisible text, and the
8896 lines are truncated.
8897
a258d627
JD
88982011-07-23 Jan Djärv <jan.h.d@swipnet.se>
8899
8900 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
8901 for OSX >= 10.7.
8902
b6d5a689
EZ
89032011-07-22 Eli Zaretskii <eliz@gnu.org>
8904
0f74f785
EZ
8905 Fix a significant slow-down of cursor motion with C-n, C-p,
8906 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
8907 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 8908 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
8909 (next_element_from_buffer): Call compute_stop_pos_backwards to
8910 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
8911 base_level_stop.
8912 (reseat): Don't look for prev_stop, as that could mean a very long
8913 run.
8914 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
8915 <cached_disp_overlay_modiff>: Cache for last found display string
8916 position.
551918c1 8917 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
8918 about the same buffer in the same area of character positions, and
8919 the buffer wasn't changed since the time the display string
8920 position was cached.
551918c1 8921
b2d0c91a
EZ
89222011-07-22 Eli Zaretskii <eliz@gnu.org>
8923
8924 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
8925 is an integer, which is important for empty lines. (Bug#9149)
8926
043604ee
CY
89272011-07-22 Chong Yidong <cyd@stupidchicken.com>
8928
8929 * frame.c (Fmodify_frame_parameters): In tty case, update the
8930 default face if necessary (Bug#4238).
8931
da4adb04
CY
89322011-07-21 Chong Yidong <cyd@stupidchicken.com>
8933
8934 * editfns.c (Fstring_to_char): No need to explain what a character
8935 is in the docstring (Bug#6576).
8936
9abd0532
LMI
89372011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8938
8939 * xml.c (parse_region): Make sure we always return a tree.
8940
36881d16
HK
89412011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
8942
8943 * xml.c (parse_region): If a document contains only comments,
8944 return that, too.
8945
1e98674d
LMI
89462011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8947
8948 * xml.c (make_dom): Return comments, too.
8949
590bd467
PE
89502011-07-19 Paul Eggert <eggert@cs.ucla.edu>
8951
8952 Port to OpenBSD.
8953 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
8954 and the surrounding thread.
8955 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
8956 rather than fgets, and retry after EINTR. Otherwise, 'emacs
8957 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
8958 timer goes off.
8959 * s/openbsd.h (BROKEN_SIGIO): Define.
8960 * unexelf.c (unexec) [__OpenBSD__]:
8961 Don't update the .mdebug section of the Alpha COFF symbol table.
8962
f41628b2
LMI
89632011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
8964
8965 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
8966 (bug#8460).
8967
b59b67c5
PE
89682011-07-18 Paul Eggert <eggert@cs.ucla.edu>
8969
15e3a074
PE
8970 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
8971 This fixes some race conditions on the permissions of any newly
8972 created file.
8973
41bed37d
PE
8974 * alloc.c (valid_pointer_p): Use pipe, not open.
8975 This fixes some permissions issues when debugging.
8976
b59b67c5
PE
8977 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
8978 If fchown fails to set both uid and gid, try to set just gid,
8979 as that is sometimes allowed. Adjust the file's mode to eliminate
8980 setuid or setgid bits that are inappropriate if fchown fails.
8981
925a6be7
SM
89822011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
8983
8984 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
8985 to compare Lisp_Objects.
8986 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
8987 global_gnutls_log_level, don't mistake it for a Lisp_Object.
8988 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
8989
52968808
AS
89902011-07-17 Andreas Schwab <schwab@linux-m68k.org>
8991
0a6a104b
AS
8992 * lread.c (read_integer): Unread even EOF character.
8993 (read1): Likewise. Properly record start position of symbol.
8994
52968808
AS
8995 * lread.c (read1): Read `#:' as empty uninterned symbol if no
8996 symbol character follows.
8997
9e381cdd
PE
89982011-07-17 Paul Eggert <eggert@cs.ucla.edu>
8999
9000 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
9001 This works around a problem with the previous change to Fcopy_file.
9002 Recent glibc declares fchown with __attribute__((warn_unused_result)),
9003 and without this change, GCC might complain about discarding
9004 fchown's return value.
9005
b5641435
JB
90062011-07-16 Juanma Barranquero <lekktu@gmail.com>
9007
9008 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
9009
a8031457
PE
90102011-07-16 Paul Eggert <eggert@cs.ucla.edu>
9011
9012 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
9013
dd889327
LMI
90142011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
9015
750c33f7
LMI
9016 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
9017 it's used from the C level.
9018
dd889327
LMI
9019 * process.c: Use the same condition for POLL_FOR_INPUT in both
9020 keyboard.c and process.c (bug#1858).
9021
87e86684
LM
90222011-07-09 Lawrence Mitchell <wence@gmx.li>
9023
9024 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
9025 (Fgnutls_boot): Use it.
9026
64348f40
AS
90272011-07-15 Andreas Schwab <schwab@linux-m68k.org>
9028
9029 * doc.c (Fsubstitute_command_keys): Revert last change.
9030
1d698799
LMI
90312011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
9032
f863868c
LMI
9033 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
9034 quotes the next character, and doesn't affect other longer
9035 sequences (bug#8935).
9036
1d698799
LMI
9037 * lread.c (syms_of_lread): Clarify that is isn't only
9038 `eval-buffer' and `eval-defun' that's affected by
9039 `lexical-binding' (bug#8460).
9040
aa4b6df6
EZ
90412011-07-15 Eli Zaretskii <eliz@gnu.org>
9042
9043 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 9044 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 9045
5d856da6
PE
90462011-07-14 Paul Eggert <eggert@cs.ucla.edu>
9047
ad6042bb
PE
9048 Fix minor problems found by static checking.
9049 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
9050 (elsz): Now a signed constant, not a size_t var. We prefer signed
9051 types to unsigned, to avoid integer comparison confusion. Without
9052 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
9053 "cannot optimize loop, the loop counter may overflow", a symptom
9054 of the confusion.
f00bbb22 9055 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
9056 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
9057
6468f31c
LMI
90582011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
9059
49080b10
LMI
9060 * search.c (Fre_search_backward): Mention `case-fold-search' in
9061 all the re_search_* functions (bug#8138).
9062
6468f31c
LMI
9063 * keyboard.c (Fopen_dribble_file): Document when the file is
9064 closed (bug#8056).
9065
c965adc5
EZ
90662011-07-14 Eli Zaretskii <eliz@gnu.org>
9067
df9733bf
EZ
9068 * bidi.c (bidi_dump_cached_states): Fix format of displaying
9069 bidi_cache_idx.
9070
0bb23927
EZ
9071 Support bidi reordering of display and overlay strings.
9072 * xdisp.c (compute_display_string_pos)
9073 (compute_display_string_end): Accept additional argument STRING.
9074 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
9075 (reseat_to_string): Initialize bidi_it->string.s and
9076 bidi_it->string.schars.
9077 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
9078 NULL (avoids a crash in bidi_paragraph_init).
9079 Initialize itb.string.lstring.
0bb23927
EZ
9080 (init_iterator): Call bidi_init_it only of a valid
9081 buffer position was specified. Initialize paragraph_embedding to
9082 L2R.
9083 (reseat_to_string): Initialize the bidi iterator.
9084 (display_string): If we need to ignore text properties of
9085 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
9086 original value of -1 will not work with bidi.)
9087 (compute_display_string_pos): First arg is now struct
9088 `text_pos *'; all callers changed. Support display properties on
9089 Lisp strings.
9090 (compute_display_string_end): Support display properties on Lisp
9091 strings.
9092 (init_iterator, reseat_1, reseat_to_string): Initialize the
9093 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
9094 when iterating on a string not from display properties).
640c8776
SM
9095 (compute_display_string_pos, compute_display_string_end):
9096 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
9097 arrow keys.
9098 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
9099 base_level_stop; instead, set base_level_stop to BEGV.
9100 Fixes crashes in vertical-motion.
0bb23927
EZ
9101 (next_element_from_buffer): Improve commentary for when
9102 the iterator is before prev_stop.
9103 (init_iterator): Initialize bidi_p from the default value of
9104 bidi-display-reordering, not from buffer-local value. Use the
9105 buffer-local value only if initializing for buffer iteration.
9106 (handle_invisible_prop): Support invisible properties on strings
9107 that are being bidi-reordered.
9108 (set_iterator_to_next): Support bidi reordering of C strings and
9109 Lisp strings.
9110 (next_element_from_string): Support bidi reordering of Lisp
9111 strings.
9112 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
9113 (display_string): Support display of R2L glyph rows.
9114 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
9115 (init_iterator): Don't initialize it->bidi_p for strings
9116 here.
9117 (reseat_to_string): Initialize it->bidi_p for strings here.
9118 (next_element_from_string, next_element_from_c_string)
9119 (next_element_from_buffer): Add xassert's for correspondence
9120 between IT's object being iterated and it->bidi_it.string
9121 structure.
9122 (face_before_or_after_it_pos): Support bidi iteration.
9123 (next_element_from_c_string): Handle the case of the first string
9124 character that is not the first one in the visual order.
9125 (get_visually_first_element): New function, refactored from common
9126 parts of next_element_from_buffer, next_element_from_string, and
9127 next_element_from_c_string.
9128 (tool_bar_lines_needed, redisplay_tool_bar)
9129 (display_menu_bar): Force left-to-right direction. Add a FIXME
9130 comment for making that be controlled by a user option.
9131 (push_it, pop_it): Save and restore the state of the
9132 bidi iterator. Save and restore the bidi_p flag.
9133 (pop_it): Iterate out of display property for string iteration as
9134 well.
9135 (iterate_out_of_display_property): Support iteration over strings.
9136 (handle_single_display_spec): Set up it->bidi_it for iteration
9137 over a display string, and call bidi_init_it.
9138 (handle_single_display_spec, next_overlay_string)
9139 (get_overlay_strings_1, push_display_prop): Set up the bidi
9140 iterator for displaying display or overlay strings.
9141 (forward_to_next_line_start): Don't use the shortcut if
9142 bidi-iterating.
9143 (back_to_previous_visible_line_start): If handle_display_prop
9144 pushed the iterator stack, restore the internal state of the bidi
9145 iterator by calling bidi_pop_it same number of times.
9146 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
9147 and we are bidi-iterating, don't decrement the iterator position;
9148 instead, set the first_elt flag in the bidi iterator, to produce
9149 the same effect.
9150 (reseat_1): Remove redundant setting of string_from_display_prop_p.
9151 (push_display_prop): xassert that we are iterating a buffer.
9152 (push_it, pop_it): Save and restore paragraph_embedding member.
9153 (handle_single_display_spec, next_overlay_string)
9154 (get_overlay_strings_1, reseat_1, reseat_to_string)
9155 (push_display_prop): Set up the `unibyte' member of bidi_it.string
9156 correctly. Don't assume unibyte strings are not bidi-reordered.
9157 (compute_display_string_pos)
9158 (compute_display_string_end): Fix handling the case of C string.
9159 (push_it, pop_it): Save and restore from_disp_prop_p.
9160 (handle_single_display_spec, push_display_prop): Set the
9161 from_disp_prop_p flag.
9162 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
9163 (pop_it): Call iterate_out_of_display_property only if we are
9164 popping after iteration over a string that came from a display
9165 property. Fix a typo in popping stretch info. Add an assertion
9166 for verifying that the iterator position is in sync with the bidi
9167 iterator.
9168 (handle_single_display_spec, get_overlay_strings_1)
9169 (push_display_prop): Fix initialization of paragraph direction for
9170 string when that of the parent object is not yet determined.
9171 (reseat_1): Call bidi_init_it to resync the bidi
9172 iterator with IT's position. (Bug#7616)
9173 (find_row_edges): If ROW->start.pos gives position
9174 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
9175 (handle_stop, back_to_previous_visible_line_start, reseat_1):
9176 Reset the from_disp_prop_p flag.
9177 (SAVE_IT, RESTORE_IT): New macros.
9178 (pos_visible_p, face_before_or_after_it_pos)
9179 (back_to_previous_visible_line_start)
9180 (move_it_in_display_line_to, move_it_in_display_line)
9181 (move_it_to, move_it_vertically_backward, move_it_by_lines)
9182 (try_scrolling, redisplay_window, display_line): Use them when
9183 saving a temporary copy of the iterator and restoring it back.
9184 (back_to_previous_visible_line_start, reseat_1)
9185 (init_iterator): Empty the bidi cache "stack".
9186 (move_it_in_display_line_to): If iterator ended up at
9187 EOL, but we never saw any buffer positions smaller than
9188 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
9189 motion in bidi-reordered lines.
9190 (move_it_in_display_line_to): Record prev_method and prev_pos
9191 immediately before the call to set_iterator_to_next. Fixes cursor
9192 motion in bidi-reordered lines with stretch glyphs and strings
9193 displayed in margins. (Bug#8133) (Bug#8867)
9194 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
9195 TO_CHARPOS.
640c8776
SM
9196 (pos_visible_p): Support positions in bidi-reordered lines.
9197 Save and restore bidi cache.
0bb23927
EZ
9198
9199 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
9200 (bidi_paragraph_info): Delete unused struct.
9201 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
9202 (bidi_cache_start): New variable.
9203 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
9204 to zero.
9205 (bidi_cache_fetch_state, bidi_cache_search)
9206 (bidi_cache_find_level_change, bidi_cache_iterator_state)
9207 (bidi_cache_find, bidi_peek_at_next_level)
9208 (bidi_level_of_next_char, bidi_find_other_level_edge)
9209 (bidi_move_to_visually_next): Compare cache index with
9210 bidi_cache_start rather than with zero.
9211 (bidi_fetch_char): Accept new argument STRING; all callers
9212 changed. Support iteration over a string. Support strings with
9213 display properties. Support unibyte strings. Fix the type of
9214 `len' according to what STRING_CHAR_AND_LENGTH expects.
9215 (bidi_paragraph_init, bidi_resolve_explicit_1)
9216 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
9217 (bidi_level_of_next_char, bidi_move_to_visually_next):
9218 Support iteration over a string.
0bb23927
EZ
9219 (bidi_set_sor_type, bidi_resolve_explicit_1)
9220 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
9221 can now be zero (for strings); special values 0 and -1 were
9222 changed to -1 and -2, respectively.
9223 (bidi_char_at_pos): New function.
9224 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
9225 Call it instead of FETCH_MULTIBYTE_CHAR.
9226 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
9227 initialized to valid values.
9228 (bidi_init_it): Don't initialize charpos and bytepos with invalid
9229 values.
9230 (bidi_level_of_next_char): Allow the sentinel "position" to pass
9231 the test for valid cached positions. Fix the logic for looking up
9232 the sentinel state in the cache. GCPRO the Lisp string we are
9233 iterating.
9234 (bidi_push_it, bidi_pop_it): New functions.
9235 (bidi_initialize): Initialize the bidi cache start stack pointer.
9236 (bidi_cache_ensure_space): New function, refactored from part of
9237 bidi_cache_iterator_state. Don't assume the required size is just
9238 one BIDI_CACHE_CHUNK away.
9239 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
9240 (bidi_count_bytes, bidi_char_at_pos): New functions.
9241 (bidi_cache_search): Don't assume bidi_cache_last_idx is
9242 always valid if bidi_cache_idx is valid.
9243 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
9244 is valid if it's going to be used.
9245 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
9246 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
9247 (bidi_cache_find_level_change, bidi_cache_ensure_space)
9248 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
9249 (bidi_find_other_level_edge, bidi_cache_start_stack):
9250 All variables related to cache indices are now EMACS_INT.
c965adc5 9251
0bb23927
EZ
9252 * dispextern.h (struct bidi_string_data): New structure.
9253 (struct bidi_it): New member `string'. Make flag members be 1-bit
9254 fields, and put them last in the struct.
640c8776
SM
9255 (compute_display_string_pos, compute_display_string_end):
9256 Update prototypes.
0bb23927
EZ
9257 (bidi_push_it, bidi_pop_it): Add prototypes.
9258 (struct iterator_stack_entry): New members bidi_p,
9259 paragraph_embedding, and from_disp_prop_p.
9260 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
9261 (bidi_shelve_cache, bidi_unshelve_cache):
9262 Declare prototypes.
0bb23927
EZ
9263
9264 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
9265 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
9266 and vector-like objects.
9267
9268 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
9269 cache around display iteration.
9270
9271 * window.c (Fwindow_end, window_scroll_pixel_based)
9272 (displayed_window_lines, Frecenter): Save and restore the bidi
9273 cache around display iteration.
9274
3bbd2265
LMI
92752011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
9276
9277 * editfns.c (Fdelete_region): Clarify the use of the named
9278 parameters (bug#6788).
9279
adc47434
MR
92802011-07-14 Martin Rudalics <rudalics@gmx.at>
9281
9282 * indent.c (Fvertical_motion): Set and restore w->pointm when
9283 saving and restoring the window's buffer (Bug#9006).
9284
837c31f8
LMI
92852011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
9286
9287 * editfns.c (Fstring_to_char): Clarify just what is returned
9288 (bug#6576). Text by Eli Zaretskii.
9289
ac389d0c
JB
92902011-07-13 Juanma Barranquero <lekktu@gmail.com>
9291
9292 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
9293
0be0ce47
EZ
92942011-07-13 Eli Zaretskii <eliz@gnu.org>
9295
9296 * buffer.c (mmap_find): Fix a typo.
9297
cd18e7e3
JB
92982011-07-13 Johan Bockgård <bojohan@gnu.org>
9299
9300 Fix execution of x selection hooks.
9301 * xselect.c (Qx_lost_selection_functions)
9302 (Qx_sent_selection_functions): New vars.
9303 (syms_of_xselect): DEFSYM them.
9304 (x_handle_selection_request): Pass Qx_sent_selection_functions
9305 rather than Vx_sent_selection_functions to Frun_hook_with_args.
9306 (x_handle_selection_clear,x_clear_frame_selections):
9307 Pass Qx_lost_selection_functions rather than
9308 Vx_lost_selection_functions to Frun_hook_with_args.
9309
47ea7f44
PE
93102011-07-13 Paul Eggert <eggert@cs.ucla.edu>
9311
ac389d0c 9312 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
9313 The old code sometimes used this field without initializing it.
9314
47ea7f44
PE
9315 * alloc.c (gc_sweep): Don't read past end of array.
9316 In theory, the old code could also have corrupted Emacs internals,
9317 though it'd be very unlikely.
9318
bc985c87
AS
93192011-07-12 Andreas Schwab <schwab@linux-m68k.org>
9320
9321 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 9322 argument. (Bug#4026)
bc985c87 9323
0cf34688
LMI
93242011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
9325
b3dadd76
LMI
9326 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
9327 key" (bug#4257).
9328
0cf34688
LMI
9329 * window.c (Fset_window_start): Doc fix (bug#4199).
9330 (Fset_window_hscroll): Ditto.
9331
270768cd
PE
93322011-07-12 Paul Eggert <eggert@cs.ucla.edu>
9333
077e3dda 9334 Fix minor new problems caught by GCC 4.6.1.
270768cd 9335 * term.c (init_tty): Remove unused local.
490011a6 9336 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 9337 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 9338 not used otherwise.
270768cd 9339
b1f58454
CY
93402011-07-12 Chong Yidong <cyd@stupidchicken.com>
9341
9342 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
9343
22b9578d
LMI
93442011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
9345
6e70ab07
LMI
9346 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
9347 are the mini-buffer and the echo area (bug#3320).
9348
22b9578d
LMI
9349 * term.c (init_tty): Remove support for supdup, c10 and perq
9350 terminals, which are no longer supported (bug#1482).
9351
8974cc9f
JB
93522011-07-10 Johan Bockgård <bojohan@gnu.org>
9353
9354 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
9355
a560d974
JD
93562011-07-10 Jan Djärv <jan.h.d@swipnet.se>
9357
9358 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
9359 for non-popups (Bug#3642).
9360
1dae0f0a
AS
93612011-07-10 Andreas Schwab <schwab@linux-m68k.org>
9362
268c2c36 9363 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 9364 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
9365 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
9366 * cm.c (losecursor): Likewise.
1dae0f0a
AS
9367 * data.c (fmod): Likewise.
9368 * dispnew.c (swap_glyphs_in_rows): Likewise.
9369 * emacs.c (memory_warning_signal): Likewise.
9370 * floatfns.c (float_error): Likewise.
9371 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
9372 (otf_open, font_otf_capability, generate_otf_features)
9373 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
9374 Likewise.
9375 * image.c (pbm_read_file): Likewise.
9376 * indent.c (string_display_width): Likewise.
9377 * intervals.c (check_for_interval, search_for_interval)
9378 (inc_interval_count, count_intervals, root_interval)
9379 (adjust_intervals_for_insertion, make_new_interval): Likewise.
9380 * lread.c (defalias): Likewise.
268c2c36 9381 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
9382 * regex.c (set_image_of_range_1, set_image_of_range)
9383 (regex_grow_registers): Likewise.
9384 * sysdep.c (strerror): Likewise.
9385 * termcap.c (valid_filename_p, tprint, main): Likewise.
9386 * tparam.c (main): Likewise.
9387 * unexhp9k800.c (run_time_remap, save_data_space)
9388 (update_file_ptrs, read_header, write_header, calculate_checksum)
9389 (copy_file, copy_rest, display_header): Likewise.
9390 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
9391 Likewise.
9392 * xdisp.c (check_it): Likewise.
9393 * xfaces.c (register_color, unregister_color, unregister_colors):
9394 Likewise.
9395 * xfns.c (print_fontset_result): Likewise.
9396 * xrdb.c (member, fatal, main): Likewise.
9397
99033785
PE
93982011-07-10 Paul Eggert <eggert@cs.ucla.edu>
9399
9400 Fix minor problems found by static checking (Bug#9031).
9401 * chartab.c (char_table_set_range, map_sub_char_table):
9402 Remove unused locals.
9403 (uniprop_table): Now static.
9404 * composite.c (_work_char): Remove unused static var.
9405
9cb2ac56
JB
94062011-07-09 Juanma Barranquero <lekktu@gmail.com>
9407
9408 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
9409
f25661f0
JD
94102011-07-09 Jan Djärv <jan.h.d@swipnet.se>
9411
9412 * gtkutil.c (qttip_cb): Remove code without function.
9413
8278c4fe
EZ
94142011-07-09 Eli Zaretskii <eliz@gnu.org>
9415
9416 * w32.c (pthread_sigmask): New stub.
9417
1692ae2d 94182011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 9419
8a6ebd58 9420 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
9421 sigprocmask is portable only for single-threaded applications, and
9422 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
9423 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
9424 (LIBES): Use it.
9425 * callproc.c (Fcall_process):
9426 * process.c (create_process):
9427 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
9428 Use pthread_sigmask, not sigprocmask.
123403e4 9429
1b854618
JD
94302011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9431
9432 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
9433 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
9434 wrong (Bug#8591).
9435
3fe4b549
JD
94362011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9437
0ce7e563
JD
9438 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
9439 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
9440 (xg_hide_tooltip): Fix comment.
9441
3fe4b549
JD
9442 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
9443 in registerServicesMenuSendTypes.
9444 (validRequestorForSendType): Don't check ns_return_types.
9445
9446 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
9447 ns_return_type.
9448
5df75e47
JR
94492011-07-08 Jason Rumney <jasonr@gnu.org>
9450
22610910
JR
9451 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
9452 SH_SHOW for hidden windows (Bug#5482).
9453
5df75e47
JR
9454 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
9455 frame struct members of non-existent frames (Bug#6284).
9456
699c10bd
JD
94572011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9458
4393663b
JD
9459 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
9460 variable firstTime not needed on OSX >= 10.6.
9461 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
9462 >= 10.5. Use setKnobProportion, setDoubleValue.
9463
9464 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
9465 (MAC_OS_X_VERSION_10_5): Define if not defined.
9466 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
9467 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
9468 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
9469
9470 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 9471 cString and lossyCString on OSX >= 10.4.
4393663b 9472
58179cce 9473 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
9474 sizeToFit on OSX >= 10.2.
9475
9476 * nsimage.m (allocInitFromFile): Don't use deprecated method
9477 bestRepresentationForDevice on OSX >= 10.6.
9478
9479 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
9480 to avoid warning.
9481
9482 * emacs.c: Declare unexec_init_emacs_zone.
9483
a63e0781
JD
9484 * nsgui.h: Fix compiler warning about gnulib redefining verify.
9485
699c10bd
JD
9486 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
9487
9488 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
9489 on svcsMenu (Bug#8842).
9490
9491 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
9492 ns_return_types.
9493 (Fns_list_services): Just return Qnil on 10.6, code not working there.
9494
9495 * nsterm.m (QUTF8_STRING): Declare.
9496 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
9497 (validRequestorForSendType): Return type is (id).
9498 Change indexOfObjectIdenticalTo to indexOfObject.
9499 Check if we have local selection before returning self (Bug#8842).
9500 (writeSelectionToPasteboard): Put local selection into paste board
9501 if we have a local selection (Bug#8842).
9502 (syms_of_nsterm): DEFSYM QUTF8_STRING.
9503
9504 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
9505 (ns_get_local_selection): Declare.
9506
54e10184
LMI
95072011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
9508
9888ff71
LMI
9509 * keymap.c (describe_map_tree): Don't insert a double newline at
9510 the end of the buffer (bug#1169) and return whether we inserted
9511 something.
9512
54e10184
LMI
9513 * callint.c (Fcall_interactively): Change "reading args" to
9514 "providing args" to try to clarify what it does (bug#1010).
9515
15fa4783
KH
95162011-07-07 Kenichi Handa <handa@m17n.org>
9517
9518 * composite.c (composition_compute_stop_pos): Ignore a static
9519 composition starting before CHARPOS (Bug#8915).
9520
9521 * xdisp.c (handle_composition_prop): Likewise.
9522
a8815b00
EZ
95232011-07-07 Eli Zaretskii <eliz@gnu.org>
9524
9525 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
9526 (Bug#9015)
9527
ef7b981d 95282011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
9529
9530 * character.h (unicode_category_t): New enum type.
9531
9532 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
9533 (Qchar_code_property_table): New variable.
9534 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
9535 (UNIPROP_COMPRESSED_FORM_P): New macros.
9536 (char_table_ascii): Uncompress the compressed values.
9537 (sub_char_table_ref): New arg is_uniprop. Callers changed.
9538 Uncompress the compressed values.
ac389d0c 9539 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
9540 (char_table_ref_and_range): Uncompress the compressed values.
9541 (sub_char_table_set): New arg is_uniprop. Callers changed.
9542 Uncompress the compressed values.
9543 (sub_char_table_set_range): Args changed. Callers changed.
9544 (char_table_set_range): Adjuted for the above change.
9545 (map_sub_char_table): Delete args default_val and parent. Add arg
9546 top. Give decoded values to a Lisp function.
640c8776 9547 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
9548 values to a Lisp function. Gcpro more variables.
9549 (uniprop_table_uncompress)
9550 (uniprop_decode_value_run_length): New functions.
9551 (uniprop_decoder, uniprop_decoder_count): New variables.
9552 (uniprop_get_decoder, uniprop_encode_value_character)
9553 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
9554 New functions.
9555 (uniprop_encoder, uniprop_encoder_count): New variables.
9556 (uniprop_get_encoder, uniprop_table)
9557 (Funicode_property_table_internal, Fget_unicode_property_internal)
9558 (Fput_unicode_property_internal): New functions.
9559 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
9560 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 9561 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
9562 char-code-property-alist.
9563
640c8776 9564 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
9565 Vunicode_category_table.
9566
640c8776 9567 * font.c (font_range): Adjust for the change of
c805dec0
KH
9568 Vunicode_category_table.
9569
76b397fb
DN
95702011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
9571
9572 * m/iris4d.h: Remove file, move contents ...
9573 * s/irix6-5.h: ... here.
9574
22b4128e
PE
95752011-07-06 Paul Eggert <eggert@cs.ucla.edu>
9576
9577 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
9578 * alloc.c (mark_buffer):
9579 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
9580 (clone_per_buffer_values): Don't assume that
22b4128e
PE
9581 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
9582 This isn't true in general, and it's particularly not true
9583 if Emacs is configured with --with-wide-int.
9584 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
9585 New macros, used in the buffer.c change.
9586
869795d6
JD
95872011-07-05 Jan Djärv <jan.h.d@swipnet.se>
9588
9589 * xsettings.c: Use both GConf and GSettings if both are available.
9590 (store_config_changed_event): Add comment.
9591 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
9592 (store_tool_bar_style_changed): New functions.
5e617bc2 9593 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
9594 (struct xsettings): Move font inside HAVE_XFT.
9595 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 9596 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 9597 Move inside HAVE_XFT.
640c8776 9598 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
9599 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
9600 also.
9601 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 9602 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 9603 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
9604 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
9605 (parse_settings): Move check for font inside HAVE_XFT.
9606 (read_settings, apply_xft_settings): Add comment.
9607 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
9608 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
9609 call store_font_name_changed.
9610 (xft_settings_event): Add comment.
9611 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
9612 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
9613 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
9614 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
9615 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
9616 (xsettings_get_system_font, xsettings_get_system_normal_font):
9617 Add comment.
869795d6 9618
d8ed26bd
PE
96192011-07-05 Paul Eggert <eggert@cs.ucla.edu>
9620
9621 Random fixes. E.g., (random) never returned negative values.
9622 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
9623 subseconds part to the entropy, as that's a bit more random.
9624 Prefer signed to unsigned, since the signedness doesn't matter and
9625 in general we prefer signed. When given a limit, use a
9626 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
9627 latter isn't right if USE_2_TAGS_FOR_INTS.
9628 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
9629 not 0..VALMASK. Don't discard "excess" bits that random () returns.
9630
cabf1cac
SM
96312011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
9632
9633 * textprop.c (text_property_stickiness):
9634 Obey Vtext_property_default_nonsticky.
9635 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
9636 * w32fns.c (syms_of_w32fns):
9637 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
9638
6e9b2be9
PE
96392011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9640
9641 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
9642 This is more efficient than Ffile_directory_p and avoids a minor race.
9643
90186c68
LMI
96442011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
9645
7c301272
LMI
9646 * buffer.c (Foverlay_put): Say what the return value is
9647 (bug#7835).
9648
c4f2d8d4
LMI
9649 * fileio.c (barf_or_query_if_file_exists): Check first if the file
9650 is a directory before asking whether to use the file name
9651 (bug#7564).
ad637907
LMI
9652 (barf_or_query_if_file_exists): Make the "File is a directory"
9653 error be more correct.
c4f2d8d4 9654
90186c68
LMI
9655 * fns.c (Frequire): Remove the mention of the .gz files, since
9656 that's installation-specific, but keep the mention of
9657 `get-load-suffixes'.
9658
da64016e
PE
96592011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9660
9661 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
9662 Report string overflow if the output is too long.
9663
7d47b580
JB
96642011-07-04 Juanma Barranquero <lekktu@gmail.com>
9665
a555cb87
JB
9666 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
9667 (syms_of_gnutls): Remove duplicate DEFSYM for
9668 Qgnutls_bootprop_verify_hostname_error, an error for
9669 Qgnutls_bootprop_verify_error (which is no longer used).
9670
7d47b580
JB
9671 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
9672 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
9673 Also (re)move comments that are misplaced or no longer relevant.
9674
1e49bfab
LMI
96752011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9676
9677 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
9678
1485f4c0
CY
96792011-07-03 Chong Yidong <cyd@stupidchicken.com>
9680
9681 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
9682 and background color parameters if they have been changed.
9683
a9ab721e
LMI
96842011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9685
9686 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
9687
cf7cff57
PE
96882011-07-03 Paul Eggert <eggert@cs.ucla.edu>
9689
2e13213d
PE
9690 * xsettings.c (SYSTEM_FONT): Define only when used.
9691 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
9692
cf7cff57
PE
9693 * keymap.c (access_keymap_1): Now static.
9694
7a8e04f7
CY
96952011-07-02 Chong Yidong <cyd@stupidchicken.com>
9696
9697 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
9698 leave any prefix arg for the up event (Bug#1586).
9699
61352f62
LMI
97002011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
9701
69bb1ef7
LMI
9702 * lread.c (syms_of_lread): Mention single symbols defined by
9703 `defvar' or `defconst' (bug#7154).
9704
61352f62 9705 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 9706 (Frequire): Mention get-load-suffixes.
61352f62 9707
28545e04
MR
97082011-07-02 Martin Rudalics <rudalics@gmx.at>
9709
9710 * window.h (window): Remove clone_number slot.
9711 * window.c (Fwindow_clone_number, Fset_window_clone_number):
9712 Remove.
9713 (make_parent_window, make_window, saved_window)
9714 (Fset_window_configuration, save_window_save): Don't deal with
9715 clone numbers.
9716 * buffer.c (Qclone_number): Remove declaration.
9717 (sort_overlays, overlay_strings): Don't deal with clone numbers.
9718
3349e122
SM
97192011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
9720
9721 Add multiple inheritance to keymaps.
9722 * keymap.c (Fmake_composed_keymap): New function.
9723 (Fset_keymap_parent): Simplify.
9724 (fix_submap_inheritance): Remove.
9725 (access_keymap_1): New function extracted from access_keymap to handle
9726 embedded parents and handle lists of maps.
9727 (access_keymap): Use it.
9728 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
9729 (Fcopy_keymap): Handle embedded parents.
9730 (Fcommand_remapping, define_as_prefix): Simplify.
9731 (Fkey_binding): Simplify.
9732 (syms_of_keymap): Move minibuffer-local-completion-map,
9733 minibuffer-local-filename-completion-map,
9734 minibuffer-local-must-match-map, and
9735 minibuffer-local-filename-must-match-map to Elisp.
9736 (syms_of_keymap): Defsubr make-composed-keymap.
9737 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
9738 (parse_menu_item): Trivial simplification.
9739
3279eb87
GM
97402011-07-01 Glenn Morris <rgm@gnu.org>
9741
9742 * Makefile.in (SETTINGS_LIBS): Fix typo.
9743
4550efdf
KI
97442011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
9745
9746 * coding.c (Fencode_coding_string): Record the last coding system
9747 used, as the function doc string says (bug#8738).
9748
0949d2b6
JD
97492011-07-01 Jan Djärv <jan.h.d@swipnet.se>
9750
9751 * xsettings.c (store_monospaced_changed): Take new font as arg and
9752 check for change against current_mono_font.
9753 (EMACS_TYPE_SETTINGS): Remove this and related defines.
9754 (emacs_settings_constructor, emacs_settings_get_property)
9755 (emacs_settings_set_property, emacs_settings_class_init)
9756 (emacs_settings_init, gsettings_obj): Remove.
9757 (something_changedCB): New function for HAVE_GSETTINGS.
9758 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
9759 with value as argument.
9760 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
9761 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 9762 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
9763 "changed".
9764
9765 * xgselect.c: Add defined (HAVE_GSETTINGS).
9766 (xgselect_initialize): Ditto.
9767
9768 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
9769 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
9770 xg_select.
9771
bbc6b304
PE
97722011-07-01 Paul Eggert <eggert@cs.ucla.edu>
9773
9774 * eval.c (struct backtrace): Simplify and port the data structure.
9775 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
9776 signed bit field, as this assumption is not portable and it makes
9777 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
9778 "char debug_on_exit : 1" as this is not portable either; instead,
9779 use the portable "unsigned int debug_on_exit : 1". Remove unused
9780 member evalargs. Remove obsolete comments about cc bombing out.
9781
9851bfc5
JD
97822011-06-30 Jan Djärv <jan.h.d@swipnet.se>
9783
51bb811f 9784 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
9785 Let HAVE_GSETTINGS override HAVE_GCONF.
9786 (store_monospaced_changed): New function.
9787 (EMACS_SETTINGS): A new type derived from GObject to handle
9788 GSettings notifications.
9789 (emacs_settings_constructor, emacs_settings_get_property)
9790 (emacs_settings_set_property, emacs_settings_class_init):
9791 New functions.
9792 (gsettings_client, gsettings_obj): New variables.
9793 (GSETTINGS_SCHEMA): New define.
9794 (something_changedCB): Call store_monospaced_changed.
9795 (init_gsettings): New function.
9796 (xsettings_initialize): Call init_gsettings.
9797 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
9798 to NULL.
9799
640c8776 9800 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
9801 GCONF_CFLAGS/LIBS.
9802
5386012d
MR
98032011-06-29 Martin Rudalics <rudalics@gmx.at>
9804
9805 * window.c (resize_root_window, grow_mini_window)
9806 (shrink_mini_window): Rename Qresize_root_window to
9807 Qwindow_resize_root_window and Qresize_root_window_vertically to
9808 Qwindow_resize_root_window_vertically.
9809
f13e0b08
PE
98102011-06-28 Paul Eggert <eggert@cs.ucla.edu>
9811
9812 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
9813
94515237
JB
98142011-06-27 Juanma Barranquero <lekktu@gmail.com>
9815
9816 * makefile.w32-in: Redesign dependencies so they reflect more
9817 clearly which files are directly included by each source file,
9818 and not through other includes.
9819
e43b6e43
MR
98202011-06-27 Martin Rudalics <rudalics@gmx.at>
9821
9822 * buffer.c (Qclone_number): Declare static and DEFSYM it.
9823 (sort_overlays, overlay_strings): When an overlay's clone number
9824 matches the window's clone number process the overlay even if
9825 the overlay's window property doesn't match the current window.
9826
d68443dc
MR
9827 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
9828 (Fwindow_hchild): Rename to Fwindow_left_child.
9829 (Fwindow_next): Rename to Fwindow_next_sibling.
9830 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
9831 (resize_window_check): Rename to window_resize_check.
9832 (resize_window_apply): Rename to window_resize_apply.
9833 (Fresize_window_apply): Rename to Fwindow_resize_apply.
9834 (Fdelete_other_windows_internal, resize_frame_windows)
9835 (Fsplit_window_internal, Fdelete_window_internal)
9836 (grow_mini_window, shrink_mini_window)
9837 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 9838
c7e73be5
JD
98392011-06-26 Jan Djärv <jan.h.d@swipnet.se>
9840
9841 * emacsgtkfixed.h: State that this is only used with Gtk+3.
9842 (emacs_fixed_set_min_size): Remove.
9843 (emacs_fixed_new): Take frame as argument.
9844
9845 * emacsgtkfixed.c: State that this is only used with Gtk+3.
9846 (_EmacsFixedPrivate): Remove minwidth/height.
9847 Add struct frame *f.
9848 (emacs_fixed_init): Initialize priv->f.
9849 (get_parent_class, emacs_fixed_set_min_size): Remove.
9850 (emacs_fixed_new): Set priv->f to argument.
9851 (emacs_fixed_get_preferred_width)
9852 (emacs_fixed_get_preferred_height): Use min_width/height from
9853 frames size_hint to set minimum and natural (Bug#8919).
9854 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
9855 and use min_width/height from frames size_hint to set
9856 min_width/height (Bug#8919).
9857
9858 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
9859 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
9860 Fix indentation.
c7e73be5 9861
cf99dcf8
EZ
98622011-06-26 Eli Zaretskii <eliz@gnu.org>
9863
9864 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
9865 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
9866 called at ZV.
9867
029529ac
CY
98682011-06-26 Chong Yidong <cyd@stupidchicken.com>
9869
9870 * process.c (wait_reading_process_output): Bypass select if
9871 waiting for a cell while ignoring keyboard input, and input is
9872 pending. Suggested by Jan Djärv (Bug#8869).
9873
7a7ef429
PE
98742011-06-25 Paul Eggert <eggert@cs.ucla.edu>
9875
9876 Use gnulib's dup2 module instead of rolling our own.
9877 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
9878
11fdef7d 98792011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
9880
9881 * dispnew.c (scrolling_window): Before scrolling, turn off a
9882 mouse-highlight in the window being scrolled.
9883
cd3520a4
JB
98842011-06-24 Juanma Barranquero <lekktu@gmail.com>
9885
9886 Move DEFSYM to lisp.h and use everywhere.
9887
9888 * character.h (DEFSYM): Move declaration...
9889 * lisp.h (DEFSYM): ...here.
9890
9891 * gnutls.c:
9892 * minibuf.c:
9893 * w32menu.c:
9894 * w32proc.c:
9895 * w32select.c: Don't include character.h.
9896
9897 * alloc.c (syms_of_alloc):
9898 * buffer.c (syms_of_buffer):
9899 * bytecode.c (syms_of_bytecode):
9900 * callint.c (syms_of_callint):
9901 * casefiddle.c (syms_of_casefiddle):
9902 * casetab.c (init_casetab_once):
9903 * category.c (init_category_once, syms_of_category):
9904 * ccl.c (syms_of_ccl):
9905 * cmds.c (syms_of_cmds):
9906 * composite.c (syms_of_composite):
9907 * dbusbind.c (syms_of_dbusbind):
9908 * dired.c (syms_of_dired):
9909 * dispnew.c (syms_of_display):
9910 * doc.c (syms_of_doc):
9911 * editfns.c (syms_of_editfns):
9912 * emacs.c (syms_of_emacs):
9913 * eval.c (syms_of_eval):
9914 * fileio.c (syms_of_fileio):
9915 * fns.c (syms_of_fns):
9916 * frame.c (syms_of_frame):
9917 * fringe.c (syms_of_fringe):
9918 * insdel.c (syms_of_insdel):
9919 * keymap.c (syms_of_keymap):
9920 * lread.c (init_obarray, syms_of_lread):
9921 * macros.c (syms_of_macros):
9922 * msdos.c (syms_of_msdos):
9923 * print.c (syms_of_print):
9924 * process.c (syms_of_process):
9925 * search.c (syms_of_search):
9926 * sound.c (syms_of_sound):
9927 * syntax.c (init_syntax_once, syms_of_syntax):
9928 * terminal.c (syms_of_terminal):
9929 * textprop.c (syms_of_textprop):
9930 * undo.c (syms_of_undo):
9931 * w32.c (globals_of_w32):
9932 * window.c (syms_of_window):
9933 * xdisp.c (syms_of_xdisp):
9934 * xfaces.c (syms_of_xfaces):
9935 * xfns.c (syms_of_xfns):
9936 * xmenu.c (syms_of_xmenu):
9937 * xsettings.c (syms_of_xsettings):
9938 * xterm.c (syms_of_xterm): Use DEFSYM.
9939
4228cf16
TZ
99402011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
9941
cd3520a4 9942 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 9943
7fcccf1e
PE
99442011-06-23 Paul Eggert <eggert@cs.ucla.edu>
9945
7efb4e0e
PE
9946 Integer and buffer overflow fixes (Bug#8873).
9947
ff5844ad
PE
9948 * print.c (printchar, strout): Check for string overflow.
9949 (PRINTPREPARE, printchar, strout):
9950 Don't set size unless allocation succeeds.
9951
90532f02
PE
9952 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
9953 for sizes. Check for string overflow more accurately.
9954 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
9955
6d84508d
PE
9956 * macros.c: Integer and buffer overflow fixes.
9957 * keyboard.h (struct keyboard.kbd_macro_bufsize):
9958 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
9959 Use ptrdiff_t, not int, for sizes.
9960 Don't increment bufsize until after realloc succeeds.
9961 Check for size-calculation overflow.
9962 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
9963
437b2cb4
PE
9964 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
9965
8b9ac8b4
PE
9966 * lread.c: Integer overflow fixes.
9967 (read_integer): Radix is now EMACS_INT, not int,
9968 to improve quality of diagnostics for out-of-range radices.
9969 Calculate buffer size correctly for out-of-range radices.
9970 (read1): Check for integer overflow in radices, and in
9971 read-circle numbers.
82cb60d3
PE
9972 (read_escape): Avoid int overflow.
9973 (Fload, openp, read_buffer_size, read1)
9974 (substitute_object_recurse, read_vector, read_list, map_obarray):
9975 Use ptrdiff_t, not int, for sizes.
9976 (read1): Use EMACS_INT, not int, for sizes.
20270765 9977 Check for size overflow.
8b9ac8b4 9978
7fcccf1e
PE
9979 * image.c (cache_image): Check for size arithmetic overflow.
9980
bfbbd7e7
PE
9981 * lread.c: Integer overflow issues.
9982 (saved_doc_string_size, saved_doc_string_length)
9983 (prev_saved_doc_string_size, prev_saved_doc_string_length):
9984 Now ptrdiff_t, not int.
9985 (read1): Don't assume doc string length fits in int. Check for
9986 out-of-range doc string lengths.
9987 (read_list): Don't assume file position fits in int.
39019e54 9988 (read_escape): Check for hex character overflow.
bfbbd7e7 9989
4e323265
LL
99902011-06-22 Leo Liu <sdl.web@gmail.com>
9991
9992 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
9993 Move to minibuffer.el.
9994
85fece3e
PE
99952011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9996
20b84ce9 9997 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
9998 The following patches are for when GLYPH_DEBUG && !XASSERT.
9999 * dispextern.h (trace_redisplay_p, dump_glyph_string):
10000 * dispnew.c (flush_stdout):
10001 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
10002 Mark as externally visible.
10003 * dispnew.c (check_window_matrix_pointers): Now static.
10004 * dispnew.c (window_to_frame_vpos):
10005 * xfns.c (unwind_create_frame):
10006 * xterm.c (x_check_font): Remove unused local.
10007 * scroll.c (CHECK_BOUNDS):
10008 * xfaces.c (cache_fache): Rename local to avoid shadowing.
10009 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
10010 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
10011 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
10012 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
10013 Now static.
10014 (debug_method_add): Use va_list and vsprintf rather than relying
10015 on undefined behavior with wrong number of arguments.
10016 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
10017 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
10018 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
10019 since we're not interested in debugging glyphs with old libraries.
10020 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
10021 GCC 4.6.0's static checking.
10022
0766b489
PE
100232011-06-22 Paul Eggert <eggert@cs.ucla.edu>
10024
31fd4b32
PE
10025 Integer overflow and signedness fixes (Bug#8873).
10026 A few related buffer overrun fixes, too.
10027
b79e8648
PE
10028 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
10029
0766b489
PE
10030 * dispextern.h (struct face.stipple):
10031 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
10032 (x_bitmap_mask, x_allocate_bitmap_record)
10033 (x_create_bitmap_from_data, x_create_bitmap_from_file)
10034 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
10035 (x_create_bitmap_from_xpm_data):
10036 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
10037 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
10038 (.bitmaps_last):
10039 * xfaces.c (load_pixmap):
10040 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
10041 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
10042 (.bitmaps_last, struct x_output.icon_bitmap):
10043 Use ptrdiff_t, not int, for bitmap indexes.
10044 (x_allocate_bitmap_record): Check for size overflow.
10045 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
10046
b081724f
PE
10047 Use ptrdiff_t, not int, for overlay counts.
10048 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
10049 * editfns.c (overlays_around, get_pos_property):
10050 * textprop.c (get_char_property_and_overlay):
10051 * xdisp.c (next_overlay_change, note_mouse_highlight):
10052 * xfaces.c (face_at_buffer_position):
21514da7
PE
10053 * buffer.c (OVERLAY_COUNT_MAX): New macro.
10054 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
10055 (Fnext_overlay_change, Fprevious_overlay_change)
10056 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 10057 Use ptrdiff_t, not int, for sizes.
21514da7 10058 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 10059
3de73e5e
PE
10060 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
10061
2606c57b
PE
10062 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
10063 (x_session_initialize): Do not assume string length fits in int.
10064
aaafe47a
PE
10065 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
10066 This is unlikely, but can occur if DPI is outlandish.
10067
2674ddc8 10068 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
10069 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
10070
28154962
PE
10071 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
10072 * xrdb.c (magic_file_p, search_magic_path):
10073 Omit last arg SUFFIX; it was always 0. All callers changed.
10074 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
10075
7de51af5
PE
10076 * xfont.c (xfont_match): Avoid need for strlen.
10077
25ed6cc3
PE
10078 * xfns.c: Don't assume strlen fits in int.
10079 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
10080
4eab31dd
PE
10081 * xdisp.c (message_log_check_duplicate): Return intmax_t,
10082 not unsigned long, as we prefer signed integers. All callers changed.
10083 Detect integer overflow in repeat count.
10084 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 10085 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 10086
171e2a58
PE
10087 * termcap.c: Don't assume sizes fit in int and never overflow.
10088 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
10089 (gobble_line): Check for size-calculation overflow.
10090
ad39faca 10091 * minibuf.c (Fread_buffer):
6e5bb2dc 10092 * lread.c (intern, intern_c_string):
74ca2eb3
PE
10093 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
10094 Don't assume string length fits in int.
10095
52c61c22 10096 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
10097 * gtkutil.c (style_changed_cb): Avoid need for strlen.
10098
b5b8c9e5
PE
10099 * font.c: Don't assume string length fits in int.
10100 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
10101 Use ptrdiff_t, not int.
ccd6111c
PE
10102 (font_intern_prop): Don't assume string length fits in int.
10103 Don't assume integer property fits in fixnum.
10104 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 10105
882f0d81 10106 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 10107 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
10108 Reformulate so as not to need the command string.
10109 Invoke gzip -cd rather than gunzip, as it's more portable.
10110 (lock_info_type, lock_file_1, lock_file):
10111 Don't assume pid_t and time_t fit in unsigned long.
10112 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
10113 (current_lock_owner): Prefer signed type for sizes.
10114 Use memcpy, not strncpy, where memcpy is what is really wanted.
10115 Don't assume (via atoi) that time_t and pid_t fit in int.
10116 Check for time_t and/or pid_t out of range, e.g., via a network share.
10117 Don't alloca where an auto var works fine.
10118
93f4cf88
PE
10119 * fileio.c: Fix some integer overflow issues.
10120 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
10121 Don't assume string length fits in int.
10122 (directory_file_name): Don't assume string length fits in long.
10123 (make_temp_name): Don't assume pid fits in int, or that its print
10124 length is less than 20.
10125
f3e92b69
PE
10126 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
10127
1bfdaf10
PE
10128 * coding.c (make_subsidiaries): Don't assume string length fits in int.
10129
35016e9a
PE
10130 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
10131
3d1e65a1
PE
10132 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
10133 We prefer signed integers, even for size calculations.
10134
0b963a93
PE
10135 * emacs.c: Don't assume string length fits in 'int'.
10136 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
10137 (main): Don't invoke strlen when not needed.
10138
573f4b54
PE
10139 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
10140 (XD_DEBUG_MESSAGE): Don't waste a byte.
10141
989f33ba
PE
10142 * callproc.c (getenv_internal_1, getenv_internal)
10143 (Fgetenv_internal):
965d34eb
PE
10144 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
10145
e4d29b33
PE
10146 * lread.c (invalid_syntax): Omit length argument.
10147 All uses changed. This doesn't fix a bug, but it simplifies the
10148 code away from its former Hollerith-constant appearance, and it's
10149 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 10150 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 10151
eb49b136
PE
10152 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
10153 This didn't break anything, but it didn't help either.
10154 It's confusing to put a bogus integer in a place where the actual
10155 value does not matter.
9f62aeb1 10156 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 10157 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 10158
15375a22
PE
10159 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
10160 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
10161 implementation.
b61cc01c
PE
10162 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
10163 We prefer signed types, and the value cannot exceed the EMACS_INT
10164 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
10165 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
10166 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
10167 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 10168
53b2623d
PE
10169 * indent.c (sane_tab_width): New function.
10170 (current_column, scan_for_column, Findent_to, position_indentation)
10171 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 10172 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 10173
51cab52b 10174 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 10175
f2ed8a70
PE
10176 * lisp.h (lint_assume): New macro.
10177 * composite.c (composition_gstring_put_cache):
10178 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
10179
abe80cc6
PE
10180 * editfns.c, insdel.c:
10181 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 10182
b02c740e
PE
10183 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
10184
ebc96716
PE
10185 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
10186
b4e50fa0 10187 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 10188 Use much-faster test for byte-length change.
311d5d7c 10189 Don't assume string byte-length fits in 'int'.
a4cf38e4 10190 Check that character arg fits in 'int'.
85461888 10191 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 10192
c0c1ee9f
PE
10193 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
10194
a498d7f4
PE
10195 * fns.c (concat): Catch string overflow earlier.
10196 Do not rely on integer wraparound.
10197
51cab52b
PE
10198 * dispextern.h (struct it.overlay_strings_charpos)
10199 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
10200 * xdisp.c (forward_to_next_line_start)
10201 (back_to_previous_visible_line_start)
10202 (reseat_at_next_visible_line_start, next_element_from_buffer):
10203 Don't arbitrarily truncate the value of 'selective' to int.
10204
76031fad
PE
10205 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
10206
5eb55db9
PE
10207 * composite.c: Don't truncate sizes to 'int'.
10208 (composition_gstring_p, composition_reseat_it)
10209 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
10210 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
10211 not EMACS_UINT, for indexes.
5eb55db9 10212
0703a717
PE
10213 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
10214
d6202519
PE
10215 * buffer.c: Include <verify.h>.
10216 (struct sortvec.priority, struct sortstr.priority):
8961a454 10217 Now EMACS_INT, not int.
c20998a7 10218 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
10219 (struct sortstr.size, record_overlay_string)
10220 (struct sortstrlist.size, struct sortlist.used):
10221 Don't truncate size to int.
10222 (record_overlay_string): Check for size-calculation overflow.
d6202519 10223 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 10224
d5a19415
JM
102252011-06-22 Jim Meyering <meyering@redhat.com>
10226
029529ac 10227 Don't leak an XBM-image-sized buffer
d5a19415
JM
10228 * image.c (xbm_load): Free the image buffer after using it.
10229
a9041e6c
PE
102302011-06-21 Paul Eggert <eggert@cs.ucla.edu>
10231
10232 Port to Sun C.
10233 * composite.c (find_automatic_composition): Omit needless 'return 0;'
10234 that Sun C diagnosed.
10235 * fns.c (secure_hash): Fix pointer signedness issue.
10236 * intervals.c (static_offset_intervals): New function.
10237 (offset_intervals): Use it.
10238
7f3f739f
LL
102392011-06-21 Leo Liu <sdl.web@gmail.com>
10240
10241 * deps.mk (fns.o):
10242 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
10243 sha512.h.
10244
10245 * fns.c (secure_hash): Rename from crypto_hash_function and change
10246 the first arg to accept symbols.
5b66d427 10247 (Fsecure_hash): New primitive.
7f3f739f
LL
10248 (syms_of_fns): New symbols.
10249
76147d94
DD
102502011-06-20 Deniz Dogan <deniz@dogan.se>
10251
10252 * process.c (Fset_process_buffer): Clarify return value in
10253 docstring.
10254
7d7d0045
CY
102552011-06-18 Chong Yidong <cyd@stupidchicken.com>
10256
10257 * dispnew.c (add_window_display_history): Use BVAR.
10258
10259 * xdisp.c (debug_method_add): Use BVAR.
10260 (check_window_end, dump_glyph_matrix, dump_glyph)
10261 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
10262
10263 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
10264 Likewise.
10265
10266 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
10267 check till after the cache is created in init_frame_faces.
10268
ff2bc410
SM
102692011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
10270
10271 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
10272
28177add
PE
102732011-06-16 Paul Eggert <eggert@cs.ucla.edu>
10274
dd3482fe
PE
10275 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
10276 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
10277 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
10278
393d71f3 10279 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
10280 * fileio.c (Finsert_file_contents):
10281 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
10282 Remove the old (too-loose) buffer overflow checks.
10283 They weren't needed, since make_gap checks for buffer overflow.
10284 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
10285 The old code merely checked for Emacs fixnum overflow, and relied
10286 on undefined (wraparound) behavior. The new code avoids undefined
10287 behavior, and also checks for ptrdiff_t and/or size_t overflow.
10288
2e6813b0 10289 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
10290 Tune. Don't use wider integers than needed. Don't use alloca.
10291 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 10292
599a9e4f
PE
10293 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
10294
99561444
PE
10295 * insdel.c, lisp.h (buffer_overflow): New function.
10296 (insert_from_buffer_1, replace_range, replace_range_2):
10297 * insdel.c (make_gap_larger):
10298 * editfns.c (Finsert_char):
10299 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
10300
28177add
PE
10301 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
10302
e69dafad
PE
103032011-06-15 Paul Eggert <eggert@cs.ucla.edu>
10304
4baa020d 10305 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 10306
b1c46f02
PE
10307 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
10308 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
10309
e69dafad
PE
10310 * fileio.c: Don't assume EMACS_INT fits in off_t.
10311 (emacs_lseek): New static function.
10312 (Finsert_file_contents, Fwrite_region): Use it.
10313 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
10314
566684ea
PE
10315 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
10316
e6966cd6
PE
10317 * fns.c: Don't overflow int when computing a list length.
10318 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
10319 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
10320 truncation on 64-bit hosts. Check for QUIT every
10321 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
10322 faster and is responsive enough.
10323 (Flength): Report an error instead of overflowing an integer.
10324 (Fsafe_length): Return a float if the value is not representable
10325 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 10326 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 10327 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 10328
dd0b0efb
PE
10329 * alloc.c: Check that resized vectors' lengths fit in fixnums.
10330 (header_size, word_size): New constants.
10331 (allocate_vectorlike): Don't check size overflow here.
10332 (allocate_vector): Check it here instead, since this is the only
10333 caller of allocate_vectorlike that could cause overflow.
10334 Check that the new vector's length is representable as a fixnum.
10335
86fe5cfe
PE
10336 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
10337 The previous code was bogus. For example, next_almost_prime (32)
10338 returned 39, which is undesirable as it is a multiple of 3; and
10339 next_almost_prime (24) returned 25, which is a multiple of 5 so
10340 why was the code bothering to check for multiples of 7?
10341
80e88859
PE
10342 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
10343
4a2f0ad6
PE
10344 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
10345
f66c7cf8
PE
10346 Variadic C functions now count arguments with ptrdiff_t.
10347 This partly undoes my 2011-03-30 change, which replaced int with size_t.
10348 Back then I didn't know that the Emacs coding style prefers signed int.
10349 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
10350 were being counted with int, which may truncate counts on 64-bit
10351 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
10352 * lisp.h (struct Lisp_Subr.function.aMANY)
10353 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
10354 Arg counts are now ptrdiff_t, not size_t.
10355 All variadic functions and their callers changed accordingly.
10356 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
10357 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
10358 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
10359 * callint.c (Fcall_interactively): Check arg count for overflow,
10360 to avoid potential buffer overrun. Use signed char, not 'int',
10361 for 'varies' array, so that we needn't bother to check its size
10362 calculation for overflow.
10363 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
10364 * eval.c (apply_lambda):
10365 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
10366 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
10367 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
10368
a1759b76
PE
10369 * callint.c (Fcall_interactively): Don't use index var as event count.
10370
d96be9fc
PE
10371 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
10372 * mem-limits.h (SIZE): Remove; no longer used.
10373
a690a978 10374 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 10375
578c21e6
PE
10376 Remove unnecessary casts.
10377 * xterm.c (x_term_init):
10378 * xfns.c (x_set_border_pixel):
10379 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
10380 These aren't needed now that we assume ANSI C.
10381
96f53c6c
PE
10382 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
10383 It's more likely to cause problems (due to unsigned overflow)
10384 than to cure them.
10385
83c77d31
PE
10386 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
10387
ee2079f1
PE
10388 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
10389
6da65536
PE
10390 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
10391
7147c4a4
PE
10392 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
10393
193e32d9
PE
10394 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
10395
e5533da6
PE
10396 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
10397
9910e595
PE
10398 GLYPH_CODE_FACE returns EMACS_INT, not int.
10399 * dispextern.h (merge_faces):
10400 * xfaces.c (merge_faces):
01103c44
PE
10401 * xdisp.c (get_next_display_element, next_element_from_display_vector):
10402 Don't assume EMACS_INT fits in int.
9910e595 10403
2638320e
PE
10404 * character.h (CHAR_VALID_P): Remove unused parameter.
10405 * fontset.c, lisp.h, xdisp.c: All uses changed.
10406
045eb8d9
PE
10407 * editfns.c (Ftranslate_region_internal): Omit redundant test.
10408
c1f134b5
PE
10409 * fns.c (concat): Minor tuning based on overflow analysis.
10410 This doesn't fix any bugs. Use int to hold character, instead
10411 of constantly refetching from Emacs object. Use XFASTINT, not
10412 XINT, for value known to be a character. Don't bother comparing
10413 a single byte to 0400, as it's always less.
10414
395fcb93 10415 * floatfns.c (Fexpt):
327eeec8
PE
10416 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
10417
abbd3d23
PE
10418 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
10419 for characters.
10420
684a03ef
PE
10421 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
10422
0fed43f3
PE
10423 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
10424 Without this fix, on a 64-bit host (aset S 0 4294967386) would
10425 incorrectly succeed when S was a string, because 4294967386 was
10426 truncated before it was used.
10427
8fd02eb7
PE
10428 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
10429 Otherwise, an out-of-range integer could cause undefined behavior
10430 on a 64-bit host.
10431
f8c86b69
PE
10432 * composite.c: Use int, not EMACS_INT, for characters.
10433 (fill_gstring_body, composition_compute_stop_pos): Use int, not
10434 EMACS_INT, for values that are known to be in character range.
10435 This doesn't fix any bugs but is the usual style inside Emacs and
10436 may generate better code on 32-bit machines.
10437
34206dd2
PE
10438 Make sure a 64-bit char is never passed to ENCODE_CHAR.
10439 This is for reasons similar to the recent CHAR_STRING fix.
10440 * charset.c (Fencode_char): Check that character arg is actually
10441 a character. Pass an int to ENCODE_CHAR.
10442 * charset.h (ENCODE_CHAR): Verify that the character argument is no
10443 wider than 'int', as a compile-time check to prevent future regressions
10444 in this area.
10445
c5958d4c 10446 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
10447
10448 Make sure a 64-bit char is never passed to CHAR_STRING.
10449 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
10450 by silently ignoring the top 32 bits, allowing some values
10451 that were far too large to be valid characters.
10452 * character.h: Include <verify.h>.
10453 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
10454 arguments are no wider than unsigned, as a compile-time check
10455 to prevent future regressions in this area.
10456 * data.c (Faset):
01103c44 10457 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
10458 (Fsubst_char_in_region):
10459 * fns.c (concat):
10460 * xdisp.c (decode_mode_spec_coding):
10461 Adjust to CHAR_STRING's new requirement.
10462 * editfns.c (Finsert_char, Fsubst_char_in_region):
10463 * fns.c (concat): Check that character args are actually
10464 characters. Without this test, these functions did the wrong
10465 thing with wildly out-of-range values on 64-bit hosts.
10466
d37ca623
PE
10467 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
10468 These casts should not be needed on 32-bit hosts, either.
10469 * keyboard.c (read_char):
10470 * lread.c (Fload): Remove casts to unsigned.
10471
ea204efb
PE
10472 * lisp.h (UNSIGNED_CMP): New macro.
10473 This fixes comparison bugs on 64-bit hosts.
10474 (ASCII_CHAR_P): Use it.
10475 * casefiddle.c (casify_object):
01103c44 10476 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
10477 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
10478 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
10479 * dispextern.h (FACE_FROM_ID):
10480 * keyboard.c (read_char): Use UNSIGNED_CMP.
10481
41cb286c
PE
10482 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
10483 not to EMACS_INT, to avoid GCC warning.
10484
4a1b9832
PE
10485 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
10486
55daad71
PE
10487 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
10488 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
10489 isn't needed on 32-bit machines.
8f95c75c 10490
01103c44
PE
10491 * buffer.c (Fgenerate_new_buffer_name):
10492 Use EMACS_INT for count, not int.
0ceccced 10493 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
10494
10495 * data.c (Qcompiled_function): Now static.
10496
c6f072e7
PE
10497 * window.c (window_body_lines): Now static.
10498
20ce5912
PE
10499 * image.c (gif_load): Rename local to avoid shadowing.
10500
9c4c5f81
PE
10501 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
10502 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
10503 * alloc.c (make_save_value): Integer argument is now of type
10504 ptrdiff_t, not int.
10505 (mark_object): Use ptrdiff_t, not int.
10506 * lisp.h (pD): New macro.
10507 * print.c (print_object): Use it.
10508
c0c5c8ae
PE
10509 * alloc.c: Use EMACS_INT, not int, to count objects.
10510 (total_conses, total_markers, total_symbols, total_vector_size)
10511 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
10512 (total_free_floats, total_floats, total_free_intervals)
10513 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
10514 Now EMACS_INT, not int. All uses changed.
10515 (Fgarbage_collect): Compute overall total using a double, so that
10516 integer overflow is less likely to be a problem. Check for overflow
10517 when converting back to an integer.
5a25e253
PE
10518 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
10519 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
10520 These were 'int' variables that could overflow on 64-bit hosts;
10521 they were never used, so remove them instead of repairing them.
211a0b2a 10522 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
10523 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
10524 Previously, this ceilinged at INT_MAX, but that doesn't work on
10525 64-bit machines.
e46bb31a 10526 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 10527
c78baabf 10528 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 10529 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
10530 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
10531 when a (possibly-narrower) signed value would do just as well.
10532 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 10533
c9d624c6
PE
10534 * alloc.c: Catch some string size overflows that we were missing.
10535 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
10536 for convenience in STRING_BYTES_MAX.
10537 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
10538 The definition here is exact; the one in lisp.h was approximate.
10539 (allocate_string_data): Check for string overflow. This catches
10540 some instances we weren't catching before. Also, it catches
10541 size_t overflow on (unusual) hosts where SIZE_MAX <= min
10542 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
10543 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 10544
c9d624c6
PE
10545 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
10546 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 10547 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 10548
353032ce
PE
10549 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
10550
2bccce07
PE
10551 * alloc.c (Fmake_string): Check for out-of-range init.
10552
0ac30604
SM
105532011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
10554
10555 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
10556
c195f2de
JD
105572011-06-14 Jan Djärv <jan.h.d@swipnet.se>
10558
10559 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
10560 xg_get_default_scrollbar_width.
10561
10562 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
10563 (int_gtk_range_get_value): Move to the scroll bar part of the file.
10564 (style_changed_cb): Call update_theme_scrollbar_width and call
10565 x_set_scroll_bar_default_width and xg_frame_set_char_size for
10566 all frames (Bug#8505).
10567 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
10568 Call gtk_window_set_resizable if HAVE_GTK3.
10569 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
10570 and height if HAVE_GTK3 (Bug#8505).
10571 (scroll_bar_width_for_theme): New variable.
10572 (update_theme_scrollbar_width): New function.
10573 (xg_get_default_scrollbar_width): Move code to
10574 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
10575 (xg_initialize): Call update_theme_scrollbar_width.
10576
10577 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
10578
10579 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
10580
e10ac9f1
MR
105812011-06-12 Martin Rudalics <rudalics@gmx.at>
10582
10583 * frame.c (make_frame): Call other_buffer_safely instead of
10584 other_buffer.
10585
10586 * window.c (temp_output_buffer_show): Call display_buffer with
10587 second argument Vtemp_buffer_show_specifiers and reset latter
10588 immediately after the call.
10589 (Vtemp_buffer_show_specifiers): New variable.
10590 (auto_window_vscroll_p, next_screen_context_lines)
10591 (Vscroll_preserve_screen_position): Remove leading asterisks from
10592 doc-strings.
10593
2d3c217e 105942011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 10595
7b7f97e8 10596 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
10597 * buffer.c (Qclone_number): Remove for now, as it's unused.
10598 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
10599 (record_buffer): Remove unused local.
10600 * frame.c (other_visible_frames, frame_buffer_list): Now static.
10601 (set_frame_buffer_list): Remove; unused.
10602 * frame.h (other_visible_frames): Remove decl.
10603 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
10604 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
10605 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
10606 if HAVE_GPM.
10607 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
10608 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
10609 Define only if HAVE_GPM.
10610 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
10611 (update_hints_inhibit): Remove; never set. All uses removed.
10612 * widgetprv.h (emacsFrameClassRec): Remove decl.
10613 * window.c (delete_deletable_window): Now returns void, since it
10614 wasn't returning anything.
10615 (compare_window_configurations): Remove unused locals.
10616 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
10617 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
10618 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
10619 the same widths as pointers. This follows up on the 2011-05-06 patch.
10620 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
10621 * xterm.h: Likewise.
10622 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
10623
1384b89e
JB
106242011-06-12 Juanma Barranquero <lekktu@gmail.com>
10625
10626 * makefile.w32-in: Update dependencies.
10627 (LISP_H): Add lib/intprops.h.
10628
1100a63c
CY
106292011-06-11 Chong Yidong <cyd@stupidchicken.com>
10630
10631 * image.c (gif_load): Add animation frame delay to the metadata.
10632 (syms_of_image): Use DEFSYM. New symbol `delay'.
10633
6198ccd0
MR
106342011-06-11 Martin Rudalics <rudalics@gmx.at>
10635
10636 * window.c (delete_deletable_window): Re-add.
10637 (Fset_window_configuration): Rewrite to handle dead buffers and
10638 consequently deletable windows.
10639 (window_tree, Fwindow_tree): Remove. Supply functionality in
10640 window.el.
10641 (compare_window_configurations): Simplify code.
10642
b6e3633c
AS
106432011-06-11 Andreas Schwab <schwab@linux-m68k.org>
10644
1ab0dee5
AS
10645 * image.c (imagemagick_load_image): Fix type mismatch.
10646 (Fimagemagick_types): Likewise.
10647
b6e3633c
AS
10648 * window.h (replace_buffer_in_windows): Declare.
10649
9397e56f
MR
106502011-06-11 Martin Rudalics <rudalics@gmx.at>
10651
10652 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
10653 Qclone_number. Remove external declaration of Qdelete_window.
10654 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
10655 code.
640c8776
SM
10656 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
10657 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
10658 (Fother_buffer): Rewrite doc-string. Major rewrite for new
10659 buffer list implementation.
10660 (other_buffer_safely): New function.
10661 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
10662 calls to replace_buffer_in_windows and
10663 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
10664 if allowed.
10665 (record_buffer): Inhibit quitting and rewrite using quittable
10666 functions. Run Qbuffer_list_update_hook if allowed.
10667 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
10668 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
10669 Move switch-to-buffer to window.el.
9397e56f
MR
10670 (bury-buffer): Move to window.el.
10671 (Vbuffer_list_update_hook): New variable.
10672
10673 * lisp.h (other_buffer_safely): Add prototype in buffer.c
10674 section.
10675
10676 * window.h (resize_frame_windows): Move up in code.
10677 (Fwindow_frame): Remove EXFUN.
10678 (replace_buffer_in_all_windows): Remove prototype.
10679 (replace_buffer_in_windows_safely): Add prototype.
10680
10681 * window.c: Declare Qdelete_window static again. Move down
10682 declaration of select_count.
10683 (Fnext_window, Fprevious_window): Rewrite doc-strings.
10684 (Fother_window): Move to window.el.
10685 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
10686 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
10687 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
10688 window.el.
10689 (replace_buffer_in_windows): Implement by calling
10690 Qreplace_buffer_in_windows.
10691 (replace_buffer_in_all_windows): Remove with some functionality
10692 moved into replace_buffer_in_windows_safely.
10693 (replace_buffer_in_windows_safely): New function.
10694 (select_window_norecord, select_frame_norecord): Move in front
10695 of run_window_configuration_change_hook. Remove now obsolete
10696 declarations.
640c8776
SM
10697 (Fset_window_buffer): Rewrite doc-string.
10698 Call Qrecord_window_buffer.
9397e56f
MR
10699 (keys_of_window): Move binding for other-window to window.el.
10700
b50691aa
CY
107012011-06-11 Chong Yidong <cyd@stupidchicken.com>
10702
10703 * dispextern.h (struct image): Replace data member, whose int_val
10704 and ptr_val fields were not used by anything, with a single
10705 lisp_val object.
10706
10707 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
10708 (gif_clear_image, gif_load, imagemagick_load_image)
10709 (gs_clear_image, gs_load): Callers changed.
10710
3f754b86
PE
107112011-06-10 Paul Eggert <eggert@cs.ucla.edu>
10712
cca69397
PE
10713 * buffer.h: Include <time.h>, for time_t.
10714 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
10715
109e28d0
PE
10716 Fix minor problems found by static checking.
10717
60737f02
PE
10718 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
10719
4b66faf3
PE
10720 Make identifiers static if they are not used in other modules.
10721 * data.c (Qcompiled_function, Qframe, Qvector):
10722 * image.c (QimageMagick, Qsvg):
10723 * minibuf.c (Qmetadata):
10724 * window.c (resize_window_check, resize_root_window): Now static.
10725 * window.h (resize_window_check, resize_root_window): Remove decls.
10726
109e28d0
PE
10727 * window.c (window_deletion_count, delete_deletable_window):
10728 Remove; unused.
46a4ce9e
PE
10729 (window_body_lines): Now static.
10730 (Fdelete_other_windows_internal): Mark vars as initialized.
10731 Make sure 'resize_failed' is initialized.
10732 (run_window_configuration_change_hook): Rename local to avoid shadowing.
10733 (resize_window_apply): Remove unused local.
10734 * window.h (delete_deletable_window): Remove decl.
10735
109e28d0 10736 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
10737 (imagemagick_load_image): Fix pointer signedness problem by changing
10738 last arg from unsigned char * to char *. All uses changed.
10739 Also, fix a local for similar reasons.
10740 Remove unused locals. Remove locals to avoid shadowing.
10741 (fn_rsvg_handle_free): Remove; unused.
10742 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 10743 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 10744
3f754b86
PE
10745 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
10746
2547adb1
CY
107472011-06-10 Chong Yidong <cyd@stupidchicken.com>
10748
10749 * image.c (gif_load): Fix omitted cast error introduced by
10750 2011-06-06 change.
10751
2c8e37d4
MR
107522011-06-10 Martin Rudalics <rudalics@gmx.at>
10753
10754 * window.h (resize_proportionally, orig_total_lines)
10755 (orig_top_line): Remove from window structure.
10756 (set_window_height, set_window_width, change_window_heights)
10757 (Fdelete_window): Remove prototypes.
10758 (resize_frame_windows): Remove duplicate declaration.
10759
440a42e3
EZ
107602011-06-10 Eli Zaretskii <eliz@gnu.org>
10761
10762 * window.h (resize_frame_windows, resize_window_check)
10763 (delete_deletable_window, resize_root_window)
10764 (resize_frame_windows): Declare prototypes.
10765
10766 * window.c (resize_window_apply): Make definition be "static" to
10767 match the prototype.
10768
562dd5e9
MR
107692011-06-10 Martin Rudalics <rudalics@gmx.at>
10770
10771 * window.c: Remove declarations of Qwindow_size_fixed,
10772 window_min_size_1, window_min_size_2, window_min_size,
10773 size_window, window_fixed_size_p, enlarge_window, delete_window.
10774 Remove static from declaration of Qdelete_window, it's
10775 temporarily needed by Fbury_buffer.
10776 (replace_window): Don't assign orig_top_line and
10777 orig_total_lines.
10778 (Fdelete_window, delete_window): Remove. Window deletion is
10779 handled by window.el.
640c8776
SM
10780 (window_loop): Remove DELETE_OTHER_WINDOWS case.
10781 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
10782 (Fdelete_other_windows): Remove. Deleting other windows is
10783 handled by window.el.
10784 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
10785 handled in window.el.
10786 (window_min_size_2, window_min_size_1, window_min_size): Remove.
10787 Window minimum sizes are handled in window.el.
10788 (shrink_windows, size_window, set_window_height)
10789 (set_window_width, change_window_heights, window_height)
10790 (window_width, CURBEG, CURSIZE, enlarge_window)
10791 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
10792 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
10793 handled in window.el.
10794 (make_dummy_parent): Rename to make_parent_window and give it a
10795 second argument horflag.
10796 (make_window): Don't set resize_proportionally any more.
10797 (Fsplit_window): Remove. Windows are split in window.el.
10798 (save_restore_action, save_restore_orig_size)
10799 (shrink_window_lowest_first, save_restore_orig_size): Remove.
10800 Resize mini windows in window.el.
10801 (grow_mini_window, shrink_mini_window): Implement by calling
10802 Qresize_root_window_vertically, resize_window_check and
10803 resize_window_apply.
640c8776
SM
10804 (saved_window, Fset_window_configuration, save_window_save):
10805 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
10806 resize_proportionally.
10807 (window_min_height, window_min_width): Move to window.el.
10808 (keys_of_window): Move bindings for delete-other-windows,
10809 split-window, delete-window and enlarge-window to window.el.
10810
10811 * buffer.c: Temporarily extern Qdelete_window.
10812 (Fbury_buffer): Temporarily call Qdelete_window instead of
10813 Fdelete_window (Fbury_buffer will move to window.el soon).
10814
10815 * frame.c (set_menu_bar_lines_1): Remove code handling
10816 orig_top_line and orig_total_lines.
10817
10818 * dispnew.c (adjust_frame_glyphs_initially): Don't use
10819 set_window_height but set heights directly.
10820 (change_frame_size_1): Use resize_frame_windows.
10821
10822 * xdisp.c (init_xdisp): Don't use set_window_height but set
10823 heights directly.
10824
640c8776
SM
10825 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
10826 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
10827 run_window_configuration_change_hook.
10828
10829 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
10830 instead of change_window_heights and run
10831 run_window_configuration_change_hook.
10832
1a13852e
MR
108332011-06-09 Martin Rudalics <rudalics@gmx.at>
10834
10835 * window.c (replace_window): Rename second argument REPLACEMENT to
10836 NEW. New third argument SETFLAG. Rewrite.
10837 (delete_window, make_dummy_parent): Call replace_window with
10838 third argument 1.
10839 (window_list_1): Move down in code.
10840 (run_window_configuration_change_hook): Move set_buffer part
10841 before select_frame_norecord part in order to unwind correctly.
10842 Rename count1 to count.
10843 (recombine_windows, delete_deletable_window, resize_root_window)
10844 (Fdelete_other_windows_internal)
10845 (Frun_window_configuration_change_hook, make_parent_window)
10846 (resize_window_check, resize_window_apply, Fresize_window_apply)
10847 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
10848 (Fdelete_window_internal, Fresize_mini_window_internal):
10849 New functions.
1a13852e
MR
10850 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
10851
f3d1777e
MR
108522011-06-08 Martin Rudalics <rudalics@gmx.at>
10853
496e208e
MR
10854 * window.h (window): Add some new members to window structure -
10855 normal_lines, normal_cols, new_total, new_normal, clone_number,
10856 splits, nest, prev_buffers, next_buffers.
10857 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 10858 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 10859
f3d1777e
MR
10860 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
10861 Remove.
496e208e
MR
10862 (make_dummy_parent): Set new members of windows structure.
10863 (make_window): Move down in code. Handle new members of window
10864 structure.
10865 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
10866 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
10867 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
10868 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
10869 (Fset_window_next_buffers, Fset_window_clone_number):
10870 New functions.
496e208e
MR
10871 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
10872 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
10873 Doc-string fixes.
10874 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
10875 Argument WINDOW can be now internal window too.
10876 (Fwindow_use_time): Move up in code.
10877 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
10878 Rewrite doc-string.
10879 (Fset_window_configuration, saved_window)
10880 (Fcurrent_window_configuration, save_window_save): Handle new
10881 members of window structure.
b9e809c2
MR
10882 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
10883 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
10884 (syms_of_window): New Lisp objects Qrecord_window_buffer,
10885 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
10886 Qget_mru_window, Qresize_root_window,
10887 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
10888 Qauto_buffer_name; staticpro them.
f3d1777e 10889
abde8f8c
MR
108902011-06-07 Martin Rudalics <rudalics@gmx.at>
10891
10892 * window.c (Fwindow_total_size, Fwindow_left_column)
10893 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
10894 (Fwindow_list_1): New functions.
10895 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
10896 (Fwindow_width, Fscroll_left, Fscroll_right):
10897 Use window_body_cols instead of window_box_text_cols.
10898 (delete_window, Fset_window_configuration):
10899 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
10900 (delete_all_subwindows): Take a window as argument and not a
10901 structure. Rewrite.
190b47e6
MR
10902 (window_loop): Remove handling of GET_LRU_WINDOW and
10903 GET_LARGEST_WINDOW.
10904 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
10905
10906 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
10907 window_box_text_cols. delete_all_subwindows now takes a
10908 Lisp_Object as argument.
abde8f8c 10909
640c8776
SM
10910 * indent.c (compute_motion, Fcompute_motion):
10911 Use window_body_cols instead of window_box_text_cols.
abde8f8c 10912
fa8a67e6
MR
10913 * frame.c (delete_frame): Call delete_all_subwindows with root
10914 window as argument.
10915
a54e3482
DC
109162011-06-07 Daniel Colascione <dan.colascione@gmail.com>
10917
10918 * fns.c (Fputhash): Document return value.
10919
60002bf5
CY
109202011-06-06 Chong Yidong <cyd@stupidchicken.com>
10921
10922 * image.c (gif_load): Implement gif89a spec "no disposal" method.
10923
0c671da6 109242011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 10925
b862a52a 10926 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 10927
be44ca6c
PE
10928 Check for overflow when converting integer to cons and back.
10929 * charset.c (Fdefine_charset_internal, Fdecode_char):
10930 Use cons_to_unsigned to catch overflow.
10931 (Fencode_char): Use INTEGER_TO_CONS.
10932 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
10933 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
10934 * data.c (long_to_cons, cons_to_long): Remove.
10935 (cons_to_unsigned, cons_to_signed): New functions.
10936 These signal an error for invalid or out-of-range values.
10937 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
10938 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
10939 * font.c (Ffont_variation_glyphs):
10940 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
10941 * lisp.h: Include <intprops.h>.
10942 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
10943 (cons_to_signed, cons_to_unsigned): New decls.
10944 (long_to_cons, cons_to_long): Remove decls.
10945 * undo.c (record_first_change): Use INTEGER_TO_CONS.
10946 (Fprimitive_undo): Use CONS_TO_INTEGER.
10947 * xfns.c (Fx_window_property): Likewise.
10948 * xselect.c: Include <limits.h>.
10949 (x_own_selection, selection_data_to_lisp_data):
10950 Use INTEGER_TO_CONS.
10951 (x_handle_selection_request, x_handle_selection_clear)
10952 (x_get_foreign_selection, Fx_disown_selection_internal)
10953 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
10954 (lisp_data_to_selection_data): Use cons_to_unsigned.
10955 (x_fill_property_data): Use cons_to_signed.
10956 Report values out of range.
10957
d1f3d2af
PE
10958 Check for buffer and string overflow more precisely.
10959 * buffer.h (BUF_BYTES_MAX): New macro.
10960 * lisp.h (STRING_BYTES_MAX): New macro.
10961 * alloc.c (Fmake_string):
10962 * character.c (string_escape_byte8):
10963 * coding.c (coding_alloc_by_realloc):
10964 * doprnt.c (doprnt):
10965 * editfns.c (Fformat):
10966 * eval.c (verror):
10967 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
10968 since they may not be the same number.
10969 * editfns.c (Finsert_char):
10970 * fileio.c (Finsert_file_contents):
10971 Likewise for BUF_BYTES_MAX.
10972
dd52fcea
PE
10973 * image.c: Use ptrdiff_t, not int, for sizes.
10974 (slurp_file): Switch from int to ptrdiff_t.
10975 All uses changed.
10976 (slurp_file): Check that file size fits in both size_t (for
10977 malloc) and ptrdiff_t (for sanity and safety).
10978
7f9bbdbb
PE
10979 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
10980 if b->modtime has its maximal value.
10981
dfe18f82
PE
10982 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
10983
84acfcf0
PE
10984 Don't assume time_t can fit into int.
10985 * buffer.h (struct buffer.modtime): Now time_t, not int.
10986 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
10987 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
10988
ccd9a01a
PE
10989 Minor fixes for signed vs unsigned integers.
10990 * character.h (MAYBE_UNIFY_CHAR):
10991 * charset.c (maybe_unify_char):
10992 * keyboard.c (read_char, reorder_modifiers):
10993 XINT -> XFASTINT, since the integer must be nonnegative.
10994 * ftfont.c (ftfont_spec_pattern):
10995 * keymap.c (access_keymap, silly_event_symbol_error):
10996 XUINT -> XFASTINT, since the integer must be nonnegative.
10997 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
10998 since it makes no difference and we prefer signed.
10999 * keyboard.c (record_char): Use XUINT when all the neighbors do.
11000 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
11001 nonnegative.
11002
d6d100dd
SM
110032011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
11004
11005 * window.h (Fwindow_frame): Declare.
11006
2b6148e4
PE
110072011-06-06 Paul Eggert <eggert@cs.ucla.edu>
11008
11009 * alloc.c: Simplify handling of large-request failures (Bug#8800).
11010 (SPARE_MEMORY): Always define.
11011 (LARGE_REQUEST): Remove.
11012 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
11013
f230ecc9
MR
110142011-06-06 Martin Rudalics <rudalics@gmx.at>
11015
727e958e
MR
11016 * lisp.h: Move EXFUNS for Fframe_root_window,
11017 Fframe_first_window and Fset_frame_selected_window to window.h.
11018
11019 * window.h: Move EXFUNS for Fframe_root_window,
11020 Fframe_first_window and Fset_frame_selected_window here from
11021 lisp.h.
11022
11023 * frame.c (Fwindow_frame, Fframe_first_window)
11024 (Fframe_root_window, Fframe_selected_window)
11025 (Fset_frame_selected_window): Move to window.c.
11026 (Factive_minibuffer_window): Move to minibuf.c.
11027 (Fother_visible_frames_p): New function.
11028
11029 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
11030
f230ecc9
MR
11031 * window.c (decode_window, decode_any_window): Move up in code.
11032 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
11033 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
11034 (Fwindow_buffer): Move up and rewrite doc-string.
11035 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
11036 (Fwindow_prev): New functions.
727e958e
MR
11037 (Fwindow_frame): Move here from frame.c. Accept any window as
11038 argument.
11039 (Fframe_root_window, Fframe_first_window)
11040 (Fframe_selected_window): Move here from frame.c. Accept frame
11041 or arbitrary window as argument. Update doc-strings.
11042 (Fminibuffer_window): Move up in code.
11043 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
11044 (Fset_frame_selected_window): Move here from frame.c.
11045 Marginal rewrite.
727e958e
MR
11046 (Fselected_window, select_window, Fselect_window): Move up in
11047 code. Minor doc-string fixes.
f230ecc9 11048
4d09bcf6
PE
110492011-06-06 Paul Eggert <eggert@cs.ucla.edu>
11050
11051 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
11052 Do not assume that spare memory exists; that assumption is valid
11053 only if SYSTEM_MALLOC.
11054 (LARGE_REQUEST): New macro, so that the issue of large requests
11055 is separated from the issue of spare memory.
11056
810928a2
AS
110572011-06-05 Andreas Schwab <schwab@linux-m68k.org>
11058
172418ad
AS
11059 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
11060 format. (Bug#8806)
11061
43f862f7
AS
11062 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
11063
810928a2
AS
11064 * xfns.c (x_set_scroll_bar_default_width): Move declarations
11065 before statements.
11066
a059fe24
JD
110672011-06-05 Jan Djärv <jan.h.d@swipnet.se>
11068
11069 * gtkutil.c (xg_get_default_scrollbar_width): New function.
11070
11071 * gtkutil.h: Declare xg_get_default_scrollbar_width.
11072
11073 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
11074 min width by calling x_set_scroll_bar_default_width (Bug#8505).
11075
989bf368
JB
110762011-06-05 Juanma Barranquero <lekktu@gmail.com>
11077
11078 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
11079
4b80f674
CY
110802011-06-04 Chong Yidong <cyd@stupidchicken.com>
11081
11082 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
11083 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
11084 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
11085 New error handlers.
4b80f674
CY
11086 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
11087 Obey Vx_select_enable_clipboard_manager. Catch errors in
11088 x_clipboard_manager_save (Bug#8779).
11089 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 11090 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 11091
99a33b77 110922011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
11093
11094 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
11095
99a33b77 110962011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
11097
11098 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
11099 in the current matrix if keep_current_p is non-zero.
11100
8264569d
EZ
111012011-06-04 Eli Zaretskii <eliz@gnu.org>
11102
11103 * bidi.c (bidi_level_of_next_char): Fix last change.
11104
57f97249
EZ
111052011-06-03 Eli Zaretskii <eliz@gnu.org>
11106
fec2107c 11107 Support bidi reordering of text covered by display properties.
57f97249 11108
fec2107c
EZ
11109 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
11110 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
11111 (bidi_cache_search, bidi_cache_iterator_state)
11112 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
11113 (bidi_level_of_next_char, bidi_move_to_visually_next):
11114 Support character positions inside a run of characters covered by a
fec2107c
EZ
11115 display string.
11116 (bidi_paragraph_init, bidi_resolve_explicit_1)
11117 (bidi_level_of_next_char): Call bidi_fetch_char and
11118 bidi_fetch_char_advance instead of FETCH_CHAR and
11119 FETCH_CHAR_ADVANCE.
11120 (bidi_init_it): Initialize new members.
11121 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
11122 definitions.
11123 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
11124 instead of using explicit *_CHAR codes.
d6d100dd
SM
11125 (bidi_resolve_explicit, bidi_resolve_weak):
11126 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
11127 bidirectional text is supported only in multibyte buffers.
11128 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
11129 it to initialize the frame_window_p member of struct bidi_it.
11130 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
11131 (bidi_resolve_explicit, bidi_resolve_weak)
11132 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
11133 bidi_it->nchars is non-positive.
11134 (bidi_level_of_next_char): Don't try to lookup the cache for the
11135 next/previous character if nothing is cached there yet, or if we
11136 were just reseat()'ed to a new position.
c40e2fb2 11137
0e14fe90
EZ
11138 * xdisp.c (set_cursor_from_row): Set start and stop points
11139 according to the row's direction when priming the loop that looks
11140 for the glyph on which to display cursor.
11141 (single_display_spec_intangible_p): Function deleted.
11142 (display_prop_intangible_p): Reimplement to call
11143 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
11144 Accept 3 additional arguments needed by handle_display_spec.
11145 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
11146 values: lists, `(when COND...)' forms, etc.
11147 (single_display_spec_string_p): Support property values that are
11148 lists with the argument STRING its top-level element.
11149 (display_prop_string_p): Fix the condition for processing a
11150 property that is a list to be consistent with handle_display_spec.
fec2107c 11151 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
11152 last portion of handle_display_prop.
11153 (compute_display_string_pos): Accept additional argument
11154 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
11155 value of a `display' property is a "replacing spec".
11156 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
11157 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
11158 the display property, but just return a value indicating whether
11159 the display property will replace the characters it covers.
11160 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
11161 frame_window_p members of struct bidi_it.
d6d100dd
SM
11162 (compute_display_string_pos, compute_display_string_end):
11163 New functions.
fec2107c
EZ
11164 (push_it): Accept second argument POSITION, where pop_it should
11165 jump to continue iteration.
11166 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 11167
fec2107c
EZ
11168 * keyboard.c (adjust_point_for_property): Adjust the call to
11169 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
11170
11171 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
11172 (bidi_init_it): Update prototypes.
11173 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
11174 (compute_display_string_pos, compute_display_string_end):
11175 Declare prototypes.
fec2107c
EZ
11176 (struct bidi_it): New members nchars and disp_pos. ch_len is now
11177 EMACS_INT.
fc6f18ce 11178
40087514 111792011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 11180
57f53182
PE
11181 Malloc failure behavior now depends on size of allocation.
11182 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
11183 * lisp.h: Change signatures accordingly.
11184 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
11185 All callers changed. (Bug#8762)
11186
11187 * gnutls.c: Use Emacs's memory allocators.
11188 Without this change, the gnutls library would invoke malloc etc.
11189 directly, which causes problems on non-SYNC_INPUT hosts, and which
11190 runs afoul of improving memory_full behavior. (Bug#8761)
11191 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
11192 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
11193 xfree instead of the default malloc, realloc, free.
11194 (Fgnutls_boot): No need to check for memory allocation failure,
11195 since xmalloc does that for us.
11196
ac32cd99 11197 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
11198 * category.c (hash_get_category_set):
11199 * ccl.c (ccl_driver):
11200 * charset.c (Fdefine_charset_internal):
11201 * charset.h (struct charset.hash_index):
11202 * composite.c (get_composition_id, gstring_lookup_cache)
11203 (composition_gstring_put_cache):
11204 * composite.h (struct composition.hash_index):
11205 * dispextern.h (struct image.hash):
11206 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
11207 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
11208 (hashfn_equal, hashfn_user_defined, make_hash_table)
11209 (maybe_resize_hash_table, hash_lookup, hash_put)
11210 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
11211 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
11212 (Fsxhash, Fgethash, Fputhash, Fmaphash):
11213 * image.c (make_image, search_image_cache, lookup_image)
11214 (xpm_put_color_table_h):
11215 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 11216 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 11217 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 11218 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
11219 * alloc.c (allocate_vectorlike):
11220 Check for overflow in vector size calculations.
11221 * ccl.c (ccl_driver):
11222 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
11223 * fns.c, image.c: Remove unnecessary static decls that would otherwise
11224 need to be updated by these changes.
40087514
PE
11225 * fns.c (make_hash_table, maybe_resize_hash_table):
11226 Check for integer overflow with large hash tables.
0de4bb68
PE
11227 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
11228 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
11229 (SXHASH_REDUCE): New macro.
11230 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
11231 Use it instead of discarding useful hash info with large hash values.
11232 (sxhash_float): New function.
11233 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
11234 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
11235 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
11236 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
11237 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
11238 Adjust signatures to match updated version of code.
11239 (consing_since_gc): Now EMACS_INT, since a single hash table can
11240 use more than INT_MAX bytes.
11241
698d32e2
DN
112422011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
11243
11244 Make it possible to build with GCC-4.6+ -O2 -flto.
11245
11246 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
11247
fd6fa53f
SM
112482011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
11249
11250 * minibuf.c (get_minibuffer, read_minibuf_unwind):
11251 Call minibuffer-inactive-mode.
11252
864db017
JB
112532011-05-31 Juanma Barranquero <lekktu@gmail.com>
11254
11255 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
11256 Update dependencies.
11257
2ad0baf4
DN
112582011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11259
11260 * data.c (init_data): Remove code for UTS, this system is not
11261 supported anymore.
11262
4fcc2638
DN
112632011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11264
11265 Don't force ./temacs to start in terminal mode.
11266
11267 * frame.c (make_initial_frame): Initialize faces in all cases, not
11268 only when CANNOT_DUMP is defined.
11269 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
11270
c56e0fd5
DN
112712011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11272
11273 * dispnew.c (add_window_display_history): Use const for the string
11274 pointer. Remove declaration, not needed.
11275
333d54da 112762011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 11277
55d4c1b2 11278 Use 'inline', not 'INLINE'.
333d54da 11279 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
11280 * alloc.c, fontset.c (INLINE): Remove.
11281 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
11282 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
11283 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
11284 * gmalloc.c (register_heapinfo): Use inline unconditionally.
11285 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
11286
738db178
DN
112872011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11288
11289 Make it possible to run ./temacs.
11290
11291 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
11292 syms_of_callproc does the same thing. Remove test for
11293 "initialized", do it in the caller.
11294 * emacs.c (main): Avoid calling set_initial_environment when dumping.
11295
620c53a6
SM
112962011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
11297
11298 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
11299 (read_minibuf): Use get_minibuffer.
11300 (syms_of_minibuf): Use DEFSYM.
11301 (Qmetadata): New var.
11302 * data.c (Qbuffer): Don't make it static.
11303 (syms_of_data): Use DEFSYM.
11304
e003a292
PE
113052011-05-31 Paul Eggert <eggert@cs.ucla.edu>
11306
11307 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
11308 (CCL_CODE_MIN): New macro.
11309
ed008a6d
PE
113102011-05-30 Paul Eggert <eggert@cs.ucla.edu>
11311
3687c2ef
PE
11312 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
11313
ed008a6d
PE
11314 * eval.c (Qdebug): Now static.
11315 * lisp.h (Qdebug): Remove decl. This reverts a part of the
11316 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
11317 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
11318
d66c4c7c
CY
113192011-05-29 Chong Yidong <cyd@stupidchicken.com>
11320
11321 * image.c: Various fixes to ImageMagick code comments.
11322 (Fimagemagick_types): Doc fix.
11323
5fbc2025
PE
113242011-05-29 Paul Eggert <eggert@cs.ucla.edu>
11325
0196f88a
PE
11326 Minor fixes prompted by GCC 4.6.0 warnings.
11327
11328 * xselect.c (converted_selections, conversion_fail_tag): Now static.
11329
5fbc2025
PE
11330 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
11331 (x_clipboard_manager_save_all): Move extern decl to ...
11332 * xterm.h: ... here, so that it can be checked for consistency.
11333
1dd3c2d9
CY
113342011-05-29 Chong Yidong <cyd@stupidchicken.com>
11335
11336 * xselect.c (x_clipboard_manager_save_frame)
11337 (x_clipboard_manager_save_all): New functions.
11338 (Fx_clipboard_manager_save): Lisp function deleted.
11339
11340 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
11341 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
11342
11343 * xterm.h: Update prototype.
11344
5ba6571d
WX
113452011-05-28 William Xu <william.xwl@gmail.com>
11346
11347 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
11348 exiting (Bug#8239).
11349
3eaff834
JM
113502011-05-28 Jim Meyering <meyering@redhat.com>
11351
e1900994 11352 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
11353 * fns.c (to_uchar): Define.
11354 (crypto_hash_function): Use it to convert some newly-signed
11355 variables to unsigned, to avoid sign-extension bugs. For example,
11356 without this change, (md5 "truc") would evaluate to
11357 45723a2aff78ff4fff7fff1114760e62 rather than the expected
11358 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 11359 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 11360
0f6990a7
PE
113612011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11362
11363 Integer overflow fixes.
c8a9ca5a 11364
08686060
PE
11365 * dbusbind.c: Serial number integer overflow fixes.
11366 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
11367 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
11368 to hold a serial number that is too large for a fixnum.
11369 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11370 Check for serial numbers out of range. Decode any serial number
59568bf0 11371 that was so large that it became a float. (Bug#8722)
08686060 11372
2d1fc3c7
PE
11373 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
11374 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11375 Use XFASTINT rather than XUINT when numbers are nonnegative.
11376 (xd_append_arg, Fdbus_method_return_internal):
11377 (Fdbus_method_error_internal): Likewise. Also, for unsigned
11378 arguments, check that Lisp number is nonnegative, rather than
59568bf0 11379 silently wrapping negative numbers around. (Bug#8722)
30217ff0 11380 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 11381 (Bug#8722)
2d1fc3c7 11382
c8a9ca5a
PE
11383 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
11384
519e1d69
PE
11385 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
11386
6df6ae42 11387 ccl: Add integer overflow checks.
30569699
PE
11388 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
11389 (IN_INT_RANGE): New macros.
11390 (ccl_driver): Use them to check for integer overflow when
11391 decoding a CCL program. Many of the new checks are whether XINT (x)
11392 fits in int; it doesn't always, on 64-bit hosts. The new version
11393 doesn't catch all possible integer overflows, but it's an
847044ea 11394 improvement. (Bug#8719)
30569699 11395
c11285dc
PE
11396 * alloc.c (make_event_array): Use XINT, not XUINT.
11397 There's no need for unsigned here.
11398
fdccd48e
PE
11399 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
11400 This follows up to the 2011-05-06 change that substituted uintptr_t
11401 for EMACS_INT. This case wasn't caught back then.
11402
37910ab2
PE
11403 Rework Fformat to avoid integer overflow issues.
11404 * editfns.c: Include <float.h> unconditionally, as it's everywhere
11405 now (part of C89). Include <verify.h>.
11406 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
11407 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
11408 (Fformat): Avoid the prepass trying to compute sizes; it was only
11409 approximate and thus did not catch overflow reliably. Instead, walk
11410 through the format just once, formatting and computing sizes as we go,
11411 checking for integer overflow at every step, and allocating a larger
11412 buffer as needed. Keep track separately whether the format is
11413 multibyte. Keep only the most-recently calculated precision, rather
11414 than them all. Record whether each argument has been converted to
11415 string. Use EMACS_INT, not int, for byte and char and arg counts.
11416 Support field widths and precisions larger than INT_MAX. Avoid
11417 sprintf's undefined behavior with conversion specifications such as %#d
11418 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
11419 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
11420 formatting out-of-range floating point numbers with int
9173deec 11421 formats. (Bug#8668)
37910ab2 11422
2e6578fb
PE
11423 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
11424
0ae6bdee
PE
11425 * data.c: Avoid integer truncation in expressions involving floats.
11426 * data.c: Include <intprops.h>.
11427 (arith_driver): When there's an integer overflow in an expression
11428 involving floating point, convert the integers to floating point
11429 so that the resulting value does not suffer from catastrophic
11430 integer truncation. For example, on a 64-bit host (* 4
11431 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
11432 Do not rely on undefined behavior after integer overflow.
11433
de883a70
PE
11434 merge count_size_as_multibyte, parse_str_to_multibyte
11435 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 11436 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
11437 Check for integer overflow.
11438 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
11439 since it's now a duplicate of the other. This is more of
11440 a character than a buffer op, so better that it's in character.c.
11441 * fns.c, print.c: Adjust to above changes.
11442
2ff916cb
PE
114432011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
11444
11445 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
11446
f1b54466
PE
114472011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11448
fb1ac845
PE
11449 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11450 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
11451 (x_clipboard_manager_save): Now static.
11452 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
11453
f1b54466
PE
11454 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11455 (crypto_hash_function): Now static.
11456 Fix pointer signedness problems. Avoid unnecessary initializations.
11457
a9f737ee
CY
114582011-05-27 Chong Yidong <cyd@stupidchicken.com>
11459
11460 * termhooks.h (Vselection_alist): Make it terminal-local.
11461
11462 * terminal.c (create_terminal): Initialize it.
11463
11464 * xselect.c: Support for clipboard managers.
11465 (Vselection_alist): Move to termhooks.h as terminal-local var.
11466 (LOCAL_SELECTION): New macro.
11467 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
11468 (symbol_to_x_atom): Remove gratuitous arg.
11469 (x_handle_selection_request, lisp_data_to_selection_data)
11470 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
11471 (x_own_selection, x_get_local_selection, x_convert_selection):
11472 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
11473 (some_frame_on_display): Delete unused function.
11474 (Fx_own_selection_internal, Fx_get_selection_internal)
11475 (Fx_disown_selection_internal, Fx_selection_owner_p)
11476 (Fx_selection_exists_p): New optional frame arg.
11477 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
11478 (x_handle_selection_clear): Don't treat other terminals with the
11479 same keyboard specially. Use the terminal-local Vselection_alist.
11480 (x_clear_frame_selections): Use Frun_hook_with_args.
11481
11482 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
11483
11484 * xterm.h: Add support for those atoms.
11485
e067f0c1
CY
114862011-05-26 Chong Yidong <cyd@stupidchicken.com>
11487
11488 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
11489 (converted_selections, conversion_fail_tag): New global variables.
11490 (x_selection_request_lisp_error): Free the above.
11491 (x_get_local_selection): Remove unnecessary code.
11492 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
11493 of converted selections stored in converted_selections.
11494 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
11495 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
11496 (x_convert_selection): New function.
11497 (x_handle_selection_event): Simplify.
11498 (x_get_foreign_selection): Don't ignore incoming requests while
11499 waiting for an answer; this will fail when we implement
11500 SAVE_TARGETS, and seems unnecessary anyway.
11501 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
11502 (Vx_sent_selection_functions): Doc fix.
11503
0f4aebc0
LL
115042011-05-26 Leo Liu <sdl.web@gmail.com>
11505
11506 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
11507
e61124cd
YM
115082011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11509
11510 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
11511
11512 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
11513 for fringe update if it has periodic bitmap.
ac389d0c 11514 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
11515 and fringe_bitmap_periodic_p.
11516
11517 * fringe.c (get_fringe_bitmap_data): New function.
11518 (draw_fringe_bitmap_1, update_window_fringes): Use it.
11519 (update_window_fringes): Record periodicity of fringe bitmap in glyph
11520 row. Mark glyph row for fringe update if periodicity changed.
11521
11522 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
11523 for fringe update unless it has periodic bitmap.
11524
f16d9837
KH
115252011-05-25 Kenichi Handa <handa@m17n.org>
11526
11527 * xdisp.c (get_next_display_element): Set correct it->face_id for
11528 a static composition.
11529
e1b90ef6
LL
115302011-05-24 Leo Liu <sdl.web@gmail.com>
11531
11532 * deps.mk (fns.o):
11533 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
11534
11535 * fns.c (crypto_hash_function, Fsha1): New function.
11536 (Fmd5): Use crypto_hash_function.
11537 (syms_of_fns): Add Ssha1.
11538
7400048f
PE
115392011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11540
11541 * gnutls.c: Remove unused macros.
11542 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
11543 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
11544 Remove macros that are defined and never used.
11545 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
11546
abb71cf4
CY
115472011-05-22 Chong Yidong <cyd@stupidchicken.com>
11548
11549 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
11550 (Fx_get_selection_internal): Minor cleanup.
11551 (Fx_own_selection_internal): Rename arguments for consistency with
11552 select.el.
11553
6307db39
PE
115542011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11555
11556 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
11557
f3d4e0a4
CY
115582011-05-22 Chong Yidong <cyd@stupidchicken.com>
11559
11560 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
11561
4d8ade89
YM
115622011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11563
11564 * dispnew.c (scrolling_window): Don't exclude the case that the
11565 last enabled row in the desired matrix touches the bottom boundary.
11566
32078c8d
GM
115672011-05-21 Glenn Morris <rgm@gnu.org>
11568
11569 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
11570 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
11571 and add some more files.
32078c8d 11572
7285dc67
EZ
115732011-05-20 Eli Zaretskii <eliz@gnu.org>
11574
11575 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
11576 report_file_error introduced by the change from 2011-05-07.
11577
89d1bd22
PE
115782011-05-20 Paul Eggert <eggert@cs.ucla.edu>
11579
11580 * systime.h (Time): Define only if emacs is defined.
11581 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
11582 where the include path doesn't have X11/X.h by default. See
11583 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
11584
cd394be1 115852011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
11586
11587 * composite.c (find_automatic_composition): Fix previous change.
11588
b9704ad9
GM
115892011-05-20 Glenn Morris <rgm@gnu.org>
11590
11591 * lisp.mk: New file, split from Makefile.in.
11592 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
11593 (shortlisp): Remove.
11594 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
11595
4a720484
GM
115962011-05-19 Glenn Morris <rgm@gnu.org>
11597
11598 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
11599 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
11600 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
11601 (lisp): Set the order to that of loadup.el.
11602 (shortlisp): Make it a copy of $lisp.
11603 (SOME_MACHINE_LISP): Remove.
11604 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
11605 Use just $shortlisp, not $SOME_MACHINE_LISP too.
11606
a28d4396
KH
116072011-05-18 Kenichi Handa <handa@m17n.org>
11608
11609 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
11610 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
11611 (find_automatic_composition): Mostly rewrite for efficiency.
11612
a2b1fa8e
JB
116132011-05-18 Juanma Barranquero <lekktu@gmail.com>
11614
11615 * makefile.w32-in: Update dependencies.
11616
8e1f5610
CS
116172011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
11618
11619 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 11620 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 11621
7025ee00 116222011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 11623
cdfa6eab
PE
11624 Fix some integer overflow issues, such as string length overflow.
11625
06d6db33
PE
11626 * insdel.c (count_size_as_multibyte): Check for string overflow.
11627
2b4560a8
PE
11628 * character.c (lisp_string_width): Check for string overflow.
11629 Use EMACS_INT, not int, for string indexes and lengths; in
11630 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
11631 the resulting string length overflows an EMACS_INT; instead,
11632 report a string overflow if no precision given. When checking for
11633 precision exhaustion, use a check that cannot possibly have
11634 integer overflow. (Bug#8675)
11635 * character.h (lisp_string_width): Adjust to new signature.
11636
cb93f9be
PE
11637 * alloc.c (string_overflow): New function.
11638 (Fmake_string): Use it. This doesn't change behavior, but saves
11639 a few bytes and will simplify future changes.
11640 * character.c (string_escape_byte8): Likewise.
11641 * lisp.h (string_overflow): New decl.
11642
1a1f3366
PE
11643 Fixups, following up to the user-interface timestamp change.
11644 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
11645 for UI timestamps, instead of unsigned long.
9fbd6841
PE
11646 * msdos.c (mouse_get_pos): Likewise.
11647 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
11648 * w32gui.h (Time): Define by including "systime.h" rather than by
11649 declaring it ourselves. (Bug#8664)
11650
d4e3e4d3
PE
11651 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
11652 * image.c (clear_image_cache): Likewise.
11653
f6a24d19
PE
11654 * term.c (term_mouse_position): Don't assume time_t wraparound.
11655
08dc5ae6
PE
11656 Be more systematic about user-interface timestamps.
11657 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
11658 and sometimes 'EMACS_UINT', to represent these timestamps.
11659 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
11660 This makes the code easier to follow, and makes it easier to catch
11661 integer overflow bugs such as Bug#8664.
11662 * frame.c (Fmouse_position, Fmouse_pixel_position):
11663 Use Time, not unsigned long, for user-interface timestamps.
11664 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
11665 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
11666 * keyboard.h (last_event_timestamp): Likewise.
11667 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
11668 * menu.h (xmenu_show): Likewise.
11669 * term.c (term_mouse_position): Likewise.
11670 * termhooks.h (struct input_event.timestamp): Likewise.
11671 (struct terminal.mouse_position_hook): Likewise.
11672 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
11673 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
11674 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
11675 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
11676 what it was before.
11677 * menu.h, termhooks.h: Include "systime.h", for Time.
11678
8e55734a
PE
11679 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
11680 Don't assume that the difference between two unsigned long values
11681 can fit into an integer. At this point, we know button_down_time
11682 <= event->timestamp, so the difference must be nonnegative, so
11683 there's no need to cast the result if double-click-time is
11684 nonnegative, as it should be; check that it's nonnegative, just in
11685 case. This bug is triggered when events are more than 2**31 ms
86db42d2 11686 apart (about 25 days). (Bug#8664)
8e55734a 11687
841f1b75 11688 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 11689 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 11690
3e26f69c
PE
11691 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
11692 that always fit in int. Use a sentinel instead of a counter, to
11693 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
11694 * frame.h (struct frame): Use int for menu_bar_items_used
11695 instead of EMACS_INT, since it always fits in int.
3e26f69c 11696
5cc152c0
PE
11697 * menu.c (grow_menu_items): Check for int overflow.
11698
d89eb65e
PE
11699 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
11700
5235bd3e
PE
11701 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
11702 Before, the code was not consistent. These values cannot exceed
11703 2**31 - 1 so there's no need to make them unsigned.
11704 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
11705 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
11706 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
11707 as modifiers.
11708 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
11709
bc827e23
PE
11710 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
11711 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
11712 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
11713 presumably because the widths might not match.
11714
78eb494e
PE
11715 * window.c (size_window): Avoid needless test at loop start.
11716
04f2d78b
CB
117172011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
11718
11719 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
11720
d2fc7e3d 117212011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
11722
11723 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
11724
d2fc7e3d 117252011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
11726
11727 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
11728 `width' to `bar_area_x' and `bar_area_width', respectively.
11729 (x_scroll_run): Take account of fringe background extension.
11730
04f2d78b
CB
11731 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
11732 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
11733 `bar_area_width', respectively.
11734 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
11735 background extension.
11736
79b70037
GM
117372011-05-10 Jim Meyering <meyering@redhat.com>
11738
11739 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
11740
2f142cc5
JB
117412011-05-10 Juanma Barranquero <lekktu@gmail.com>
11742
11743 * image.c (Finit_image_library): Return t for built-in image types,
11744 like pbm and xbm. (Bug#8640)
11745
57679c86
AS
117462011-05-09 Andreas Schwab <schwab@linux-m68k.org>
11747
11748 * w32menu.c (set_frame_menubar): Fix submenu allocation.
11749
888c9e86
EZ
117502011-05-07 Eli Zaretskii <eliz@gnu.org>
11751
b0512a1d
EZ
11752 * w32console.c (Fset_screen_color): Doc fix.
11753 (Fget_screen_color): New function.
11754 (syms_of_ntterm): Defsubr it.
11755
7285dc67
EZ
11756 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
11757 unlink the temporary file if Fcall_process didn't create it in the
11758 first place.
11759 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
11760 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
11761 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
11762 cue to call_process_cleanup not to close that handle.
11763
4d3fcc8e
BK
117642011-05-07 Ben Key <bkey76@gmail.com>
11765
11766 * makefile.w32-in: The bootstrap-temacs rule now makes use of
11767 one of two shell specific rules, either bootstrap-temacs-CMD or
11768 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
11769 to the previous implementation of the bootstrap-temacs rule.
11770 The bootstrap-temacs-CMD rule is similar to the previous
11771 implementation of the bootstrap-temacs rule except that it
11772 makes use of the ESC_CFLAGS variable instead of the CFLAGS
11773 variable.
11774
11775 These changes, along with some changes to nt/configure.bat,
11776 nt/gmake.defs, and nt/nmake.defs, are required to extend my
11777 earlier fix to add support for --cflags and --ldflags options
11778 that include quotes so that it works whether make uses cmd or
11779 sh as the shell.
11780
b4289b64
MA
117812011-05-06 Michael Albinus <michael.albinus@gmx.de>
11782
11783 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
11784 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
11785 is a constant.
11786 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
11787 a string. Handle both cases.
11788 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
11789 (Fdbus_register_method): Use Qinvalid_function.
11790
af4c0e28
JB
117912011-05-06 Juanma Barranquero <lekktu@gmail.com>
11792
11793 * makefile.w32-in: Update dependencies.
11794 (LISP_H): Add inttypes.h and stdin.h.
11795 (PROCESS_H): Add unistd.h.
11796
c51453d9
EZ
117972011-05-06 Eli Zaretskii <eliz@gnu.org>
11798
11799 * lread.c: Include limits.h (fixes the MS-Windows build broken by
11800 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
11801
8ff0ac3c 118022011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 11803
4c4b566b
PE
11804 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
11805
aab2b9b5
PE
11806 * term.c (vfatal): Remove stray call to va_end.
11807 It's not needed and the C Standard doesn't allow it here anyway.
11808
c378da0b
PE
11809 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
11810 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
11811
288b08c7
PE
11812 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
11813 bytes.
11814
e3601888
PE
11815 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
11816
db6c0e74
PE
11817 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
11818
dd5963ea
PE
11819 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
11820
88c9450f
PE
11821 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
11822
2f9442b8
PE
11823 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
11824
c032b5f8
PE
11825 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
11826 * charset.c (Fdefine_charset_internal): Don't initialize
11827 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 11828 32-bit int (Bug#8600).
a108c10b
PE
11829
11830 * lread.c (read_integer): Be more consistent with string-to-number.
11831 Use string_to_number to do the actual conversion; this avoids
11832 rounding errors and fixes some other screwups. Without this fix,
11833 for example, #x1fffffffffffffff was misread as -2305843009213693952.
11834 (digit_to_number): Move earlier, for benefit of read_integer.
11835 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 11836 not a digit in any supported base. (Bug#8602)
a108c10b 11837
ad5f9eea
PE
11838 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
11839
aec1708a
PE
11840 * dispnew.c (scrolling_window): Return 1 if we scrolled,
11841 to match comment at start of function. This also removes a
11842 GCC warning about overflow in a 32+64-bit port.
11843
47be4ab5
PE
11844 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
11845
371cac43
PE
11846 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
11847 Reported by Stefan Monnier in
11848 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
11849 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11850 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 11851
d01a7826
PE
11852 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
11853 (EMACS_UINTPTR): Likewise, with uintptr_t.
11854
7fd47d5c
PE
11855 * lisp.h: Prefer 64-bit EMACS_INT if available.
11856 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
11857 on 32-bit hosts that have 64-bit int, so that they can access
11858 large files.
122b0c86
PE
11859 However, temporarily disable this change unless the temporary
11860 symbol WIDE_EMACS_INT is defined.
7fd47d5c 11861
8727937b
PE
11862 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
11863
8ac068ac
PE
11864 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
11865 This removes an assumption that EMACS_INT and long are the same
11866 width as pointers. The assumption is true for Emacs porting targets
11867 now, but we want to make other targets possible.
11868 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
11869 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
11870 In the rest of the code, change types of integers that hold casted
11871 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
11872 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
11873 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
11874 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
11875 No need to cast type when ORing.
11876 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
11877 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
11878 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
11879 assume EMACS_INT is the same width as char *.
11880 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
11881 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
11882 Remove no-longer-needed casts.
11883 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
11884 (xg_tool_bar_help_callback, xg_make_tool_item):
11885 Use EMACS_INTPTR to hold an integer
11886 that will be cast to void *; this can avoid a GCC warning
11887 if EMACS_INT is not the same width as void *.
11888 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
11889 * xdisp.c (display_echo_area_1, resize_mini_window_1):
11890 (current_message_1, set_message_1):
11891 Use a local to convert to proper width without a cast.
11892 * xmenu.c (dialog_selection_callback): Likewise.
11893
ede49d71
PE
11894 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
11895 Also, don't assume VALBITS / RAND_BITS is less than 5,
11896 and don't rely on undefined behavior when shifting a 1 left into
11897 the sign bit.
11898 * lisp.h (get_random): Change signature to match.
11899
2f30ecd0
PE
11900 * lread.c (hash_string): Use size_t, not int, for hash computation.
11901 Normally we prefer signed values; but hashing is special, because
11902 it's better to use unsigned division on hash table sizes so that
11903 the remainder is nonnegative. Also, size_t is the natural width
11904 for hashing into memory. The previous code used 'int', which doesn't
11905 retain enough info to hash well into very large tables.
11906 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
11907
2a866e7b
PE
11908 * dbusbind.c: Don't possibly lose pointer info when converting.
11909 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11910 Use XPNTR rather than XHASH, so that the high-order bits of
11911 the pointer aren't lost when converting through void *.
11912
51639eac
PE
11913 * eval.c (Fautoload): Don't double-shift a pointer.
11914
92394119
PE
11915 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
11916
dbdb9a7c
JB
119172011-05-06 Juanma Barranquero <lekktu@gmail.com>
11918
11919 * gnutls.c (DEF_GNUTLS_FN):
11920 * image.c (DEF_IMGLIB_FN): Make function pointers static.
11921
db7a0b4f
AS
119222011-05-05 Andreas Schwab <schwab@linux-m68k.org>
11923
11924 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
11925 marker. (Bug#8610)
11926
cd394be1 119272011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
11928
11929 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
11930 New version that can reserve upto 2GB of heap space.
11931
f7ff1b0f 119322011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
11933
11934 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
11935
639c109b
TZ
119362011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
11937
11938 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
11939 `gnutls_certificate_set_x509_key_file'.
11940
d2127135
JB
119412011-05-05 Juanma Barranquero <lekktu@gmail.com>
11942
11943 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
11944 Update dependencies.
11945
e968f4f3
JB
119462011-05-04 Juanma Barranquero <lekktu@gmail.com>
11947
11948 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
11949 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
11950 Remove unused parameter `fildes'.
11951 * process.c (read_process_output, send_process): Don't pass it.
11952
84d358f0
JB
119532011-05-04 Juanma Barranquero <lekktu@gmail.com>
11954
11955 Fix previous change: the library cache is defined in w32.c.
11956 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
11957 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
11958
0898ca10
JB
119592011-05-04 Juanma Barranquero <lekktu@gmail.com>
11960
11961 Implement dynamic loading of GnuTLS on Windows.
11962
11963 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
11964 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
11965 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11966 Declare.
11967
11968 * gnutls.c (Qgnutls_dll): Define.
11969 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
11970 (gnutls_*): Declare function pointers.
11971 (init_gnutls_functions): New function to initialize function pointers.
11972 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
11973 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
11974 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11975 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
11976 (emacs_gnutls_write, emacs_gnutls_read)
11977 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
11978 (Fgnutls_available_p): New function.
11979 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
11980 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
11981 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
11982
11983 * image.c: Include w32.h.
11984 (Vimage_type_cache): Delete.
11985 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
11986 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
11987 (w32_delayed_load): Move to w32.c.
11988
11989 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
11990
11991 * w32.c (QCloaded_from, Vlibrary_cache): Define.
11992 (w32_delayed_load): Move from image.c. When loading a library, record
11993 its filename in the :loaded-from property of the library id.
11994 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
11995 Initialize and staticpro them.
11996 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
11997
11998 * process.c: Include lisp.h before w32.h, not after.
11999 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
12000 instead of gnutls_record_check_pending.
12001
12002 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
12003
ff4de4aa
TZ
120042011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
12005
12006 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
12007 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
12008 as passed in.
12009
abe95abb
JD
120102011-05-03 Jan Djärv <jan.h.d@swipnet.se>
12011
12012 * xterm.c (x_set_frame_alpha): Do not set property on anything
12013 else than FRAME_X_OUTER_WINDOW (Bug#8608).
12014
e16e55d4
JB
120152011-05-02 Juanma Barranquero <lekktu@gmail.com>
12016
12017 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
12018
bafcf6a5
JB
120192011-05-02 Juanma Barranquero <lekktu@gmail.com>
12020
12021 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
12022 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
12023 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
12024 (gnutls_global_initialized, Qgnutls_bootprop_priority)
12025 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
12026 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
12027 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
12028 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
12029 (Qgnutls_bootprop_callbacks_verify): Make static.
12030
e7a6747f
AS
120312011-05-01 Andreas Schwab <schwab@linux-m68k.org>
12032
19ed11ba
AS
12033 * callproc.c: Indentation fixup.
12034
e7a6747f 12035 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
12036 (wait_for_termination, interruptible_wait_for_termination):
12037 Move after wait_for_termination_1.
e7a6747f 12038
1ef14cb4
LMI
120392011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
12040
12041 * sysdep.c (interruptible_wait_for_termination): New function
12042 which is like wait_for_termination, but allows keyboard
12043 interruptions.
12044
12045 * callproc.c (Fcall_process): Add (:file "file") as an option for
12046 the STDOUT buffer.
12047 (Fcall_process_region): Ditto.
12048
330d880c
EZ
120492011-04-30 Eli Zaretskii <eliz@gnu.org>
12050
8db90b73
EZ
12051 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
12052 rather than `XVECTOR (FOO)->size'.
12053
330d880c
EZ
12054 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
12055 inttypes.h, as a gnulib replacement is used if it not available in
12056 system headers.
12057
15cbd324
EZ
120582011-04-21 Eli Zaretskii <eliz@gnu.org>
12059
12060 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
12061 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
12062 of MOST_POSITIVE_FIXNUM. (Bug#8528)
12063
12064 * coding.c (coding_alloc_by_realloc): Error out if destination
12065 will grow beyond MOST_POSITIVE_FIXNUM.
12066 (decode_coding_emacs_mule): Abort if there isn't enough place in
12067 charbuf for the composition carryover bytes. Reserve an extra
12068 space for up to 2 characters produced in a loop.
12069 (decode_coding_iso_2022): Abort if there isn't enough place in
12070 charbuf for the composition carryover bytes.
12071
120722011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 12073
ae940cca
EZ
12074 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
12075 aborting when %lld or %lll format is passed.
12076 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
12077 %llo or %llx format is passed. (Bug#8545)
12078
03ab8921
EZ
12079 * window.c (window_scroll_line_based): Use a marker instead of
12080 simple variables to record original value of point. (Bug#7952)
12081
afda1437
EZ
12082 * doprnt.c (doprnt): Fix the case where a multibyte sequence
12083 produced by %s or %c overflows available buffer space. (Bug#8545)
12084
f76dee0c
PE
120852011-04-28 Paul Eggert <eggert@cs.ucla.edu>
12086
12087 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 12088 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 12089
fdc5744d
JB
120902011-04-28 Juanma Barranquero <lekktu@gmail.com>
12091
12092 * w32.c (init_environment): Warn about defaulting HOME to C:\.
12093
638f053a
JB
120942011-04-28 Juanma Barranquero <lekktu@gmail.com>
12095
12096 * keyboard.c (Qdelayed_warnings_hook): Define.
12097 (command_loop_1): Run `delayed-warnings-hook'
12098 if Vdelayed_warnings_list is non-nil.
12099 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
12100 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
12101
d178f871
EZ
121022011-04-28 Eli Zaretskii <eliz@gnu.org>
12103
12104 * doprnt.c (doprnt): Don't return value smaller than the buffer
12105 size if the message was truncated. (Bug#8545).
12106
b124fd93
JB
121072011-04-28 Juanma Barranquero <lekktu@gmail.com>
12108
12109 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
12110 (Fx_window_property): #if-0 the whole functions, not just the bodies.
12111
e810457d
PE
121122011-04-27 Paul Eggert <eggert@cs.ucla.edu>
12113
12114 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
12115
ea51cceb
JB
121162011-04-27 Juanma Barranquero <lekktu@gmail.com>
12117
12118 * makefile.w32-in: Update dependencies.
12119
94dcfacf
EZ
121202011-04-27 Eli Zaretskii <eliz@gnu.org>
12121
12122 Improve `doprnt' and its usage. (Bug#8545)
12123 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
12124 `format_end'. Remove support for %l as a conversion specifier.
12125 Don't use xrealloc. Improve diagnostics when the %l size modifier
12126 is used. Update the commentary.
12127
12128 * eval.c (verror): Simplify calculation of size_t.
12129
12130 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
12131 messages.
12132
f61f41d7
PE
121332011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
12134
12135 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
12136 change.
12137
96fb4434
PE
121382011-04-27 Paul Eggert <eggert@cs.ucla.edu>
12139
12140 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
12141 This makes this file independent of the recent pseudovector change.
12142
671875da 121432011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 12144
69e9b5a3
PE
12145 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
12146
b5f869a7 12147 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 12148 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 12149 Remove unused local.
c8926152 12150 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 12151
841a1577 12152 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
12153 GCC 4.6.0 optimizes based on type-based alias analysis.
12154 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
12155 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
12156 != &v->size, and therefore "v->size = 1; b->size = 2; return
12157 v->size;" must therefore return 1. This assumption is incorrect
12158 for Emacs, since it type-puns struct Lisp_Vector * with many other
12159 types. To fix this problem, this patch adds a new type struct
f904488f 12160 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
12161 and pseudovectors, and helps optimizing compilers not get fooled
12162 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
12163 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
12164 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
12165 the size member.
eab3844f
PE
12166 (XSETPVECTYPE): Rewrite in terms of new macro.
12167 (XSETPVECTYPESIZE): New macro, specifying both type and size.
12168 This is a bit clearer, and further avoids the possibility of
12169 undesirable aliasing.
12170 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 12171 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
12172 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
12173 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
12174 (ASIZE): Now uses header.size rather than size.
12175 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
12176 to avoid the hassle of writing XVECTOR (foo)->header.size.
12177 (struct vectorlike_header): New type.
eab3844f
PE
12178 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
12179 object, to help avoid aliasing.
12180 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
12181 (SUBRP): Likewise, since Lisp_Subr is a special case.
12182 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
12183 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
12184 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 12185 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
12186 changed to be "header.size" and "header.next".
12187 * buffer.h (struct buffer): Likewise.
12188 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
12189 * frame.h (struct frame): Likewise.
12190 * process.h (struct Lisp_Process): Likewise.
12191 * termhooks.h (struct terminal): Likewise.
12192 * window.c (struct save_window_data, struct saved_window): Likewise.
12193 * window.h (struct window): Likewise.
12194 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
12195 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
12196 * buffer.c (init_buffer_once): Likewise.
12197 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
12198 special case.
12199 * process.c (Fformat_network_address): Use local var for size,
12200 for brevity.
12201
0df1eac5
PE
12202 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
12203
847ab9d1 12204 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
12205 * data.c (atof): Remove decl; no longer used or needed.
12206 (digit_to_number): Move to lread.c.
12207 (Fstring_to_number): Use new string_to_number function, to be
12208 consistent with how the Lisp reader treats infinities and NaNs.
12209 Do not assume that floating-point numbers represent EMACS_INT
12210 without losing information; this is not true on most 64-bit hosts.
12211 Avoid double-rounding errors, by insisting on integers when
12212 parsing non-base-10 numbers, as the documentation specifies.
12213 * lisp.h (string_to_number): New decl, replacing ...
12214 (isfloat_string): Remove.
bc0a5c13 12215 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 12216 (read1): Do not accept +. and -. as integers; this
452f4150
PE
12217 appears to have been a coding error. Similarly, do not accept
12218 strings like +-1e0 as floating point numbers. Do not report
12219 overflow for integer overflows unless the base is not 10 which
12220 means we have no simple and reliable way to continue.
12221 Break out the floating-point parsing into a new
12222 function string_to_number, so that Fstring_to_number parses
12223 floating point numbers consistently with the Lisp reader.
04f2d78b 12224 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
12225 (E_CHAR, EXP_INT): Remove, replacing with ...
12226 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
12227 (string_to_number): New function, replacing isfloat_string.
12228 This function checks for valid syntax and produces the resulting
12229 Lisp float number too. Rework it so that string-to-number
bc0a5c13 12230 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
12231 so that overflow for non-base-10 numbers is reported only when
12232 there's no portable and simple way to convert to floating point.
452f4150 12233
67769ffc
PE
12234 * textprop.c (set_text_properties_1): Rewrite for clarity,
12235 and to avoid GCC warning about integer overflow.
12236
c20db43f
PE
12237 * intervals.h (struct interval): Use EMACS_INT for members
12238 where EMACS_UINT might cause problems. See
12239 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
12240 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
12241 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
12242 All uses changed.
37aa2f85
PE
12243 (offset_intervals): Tell GCC not to worry about length overflow
12244 when negating a negative length.
c20db43f 12245
2538aa2f
PE
12246 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
12247 (overrun_check_free): Likewise.
12248
f2d3008d
PE
12249 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
12250 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
12251 word size.
12252
ec8df744
PE
12253 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12254 (gnutls_make_error): Rename local to avoid shadowing.
12255 (gnutls_emacs_global_deinit): ifdef out; not used.
12256 (Fgnutls_boot): Use const for pointer to readonly storage.
12257 Comment out unused local. Fix pointer signedness problems.
12258
640ee02d
PE
12259 * lread.c (openp): Don't stuff size_t into an 'int'.
12260 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
12261 about possible signed overflow.
12262
6048fb2a
PE
12263 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12264 (GDK_KEY_g): Don't define if already defined.
12265 (xg_prepare_tooltip): Avoid pointer signedness problem.
12266 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
12267
fa3c87e1
PE
12268 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
12269 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
12270
2172544b
PE
12271 * xfns.c (Fx_window_property): Simplify a bit,
12272 to make a bit faster and to avoid GCC 4.6.0 warning.
12273 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
12274
9b821a21
PE
12275 * fns.c (internal_equal): Don't assume size_t fits in int.
12276
3c616cfa
PE
12277 * alloc.c (compact_small_strings): Tighten assertion a little.
12278
c2982e87
PE
12279 Replace pEd with more-general pI, and fix some printf arg casts.
12280 * lisp.h (pI): New macro, generalizing old pEd macro to other
12281 conversion specifiers. For example, use "...%"pI"d..." rather
12282 than "...%"pEd"...".
12283 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 12284 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
12285 * alloc.c (check_pure_size): Don't overflow by converting size to int.
12286 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
12287 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
12288 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
12289 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
12290 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
12291 64-bit hosts.
12292 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
12293 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
12294 * print.c (safe_debug_print, print_object): Likewise.
12295 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
12296 to int.
6f04d126
PE
12297 Use pI instead of if-then-else-abort. Use %p to avoid casts,
12298 avoiding the 0 flag, which is not portable.
c2982e87
PE
12299 * process.c (Fmake_network_process): Use pI to avoid cast.
12300 * region-cache.c (pp_cache): Likewise.
12301 * xdisp.c (decode_mode_spec): Likewise.
12302 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
12303 behavior on 64-bit hosts with printf arg.
6f04d126 12304 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
12305 (x_stop_queuing_selection_requests): Likewise.
12306 (x_get_window_property): Don't truncate byte count to an 'int'
12307 when tracing.
0b432f21 12308
5e073ec7
PE
12309 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
12310 here, since it parses constructs like leading '-' and spaces,
12311 which are not wanted; and it overflows with large numbers.
12312 Instead, simply match F[0-9]+, which is what is wanted anyway.
12313
36372bf9
PE
12314 * alloc.c: Remove unportable assumptions about struct layout.
12315 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
12316 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
12317 (allocate_vectorlike, make_pure_vector): Use the new macros,
12318 plus offsetof, to remove unportable assumptions about struct layout.
12319 These assumptions hold on all porting targets that I know of, but
12320 they are not guaranteed, they're easy to remove, and removing them
12321 makes further changes easier.
12322
0b432f21
PE
12323 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
12324 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
12325 (string_overrun_cookie): Now const. Use initializers that
12326 don't formally overflow signed char, to avoid warnings.
000098c1
PE
12327 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
12328 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
12329 (allocate_buffer): Don't assume sizeof (struct buffer) is a
12330 multiple of sizeof (EMACS_INT); it need not be, if
12331 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 12332 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 12333
895009e1
JB
123342011-04-26 Juanma Barranquero <lekktu@gmail.com>
12335
12336 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
12337
6a7a1b0b
TZ
123382011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
12339
12340 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 12341 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
12342 Reported by Paul Eggert <eggert@cs.ucla.edu>.
12343
841a1577 123442011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
12345
12346 * lisp.h (Qdebug): List symbol.
895009e1 12347 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
12348 * keyboard.c (debug-on-event): New variable.
12349 (handle_user_signal): Break into debugger when debug-on-event
12350 matches the current signal symbol.
12351
f2d3ba6f
DN
123522011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
12353
12354 * alloc.c (check_sblock, check_string_bytes)
12355 (check_string_free_list): Convert to standard C.
12356
42ce4c63
TZ
123572011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
12358
12359 * w32.c (emacs_gnutls_push): Fix typo.
12360
825cd63c
EZ
123612011-04-25 Eli Zaretskii <eliz@gnu.org>
12362
fb11d64d
EZ
12363 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
12364 "cast to pointer from integer of different size".
12365
825cd63c
EZ
12366 Improve doprnt and its use in verror. (Bug#8545)
12367 * doprnt.c (doprnt): Document the set of format control sequences
12368 supported by the function. Use SAFE_ALLOCA instead of always
12369 using `alloca'.
12370
12371 * eval.c (verror): Don't limit the buffer size at size_max-1, that
12372 is one byte too soon. Don't use xrealloc; instead xfree and
12373 xmalloc anew.
12374
e061a11b
TZ
123752011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
12376
12377 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
12378 callbacks stage.
12379
12380 * gnutls.c: Renamed global_initialized to
12381 gnutls_global_initialized. Added internals for the
12382 :verify-hostname-error, :verify-error, and :verify-flags
12383 parameters of `gnutls-boot' and documented those parameters in the
12384 docstring. Start callback support.
9173deec
JB
12385 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
12386 unless a fatal error occurred. Call gnutls_alert_send_appropriate
12387 on error. Return error code.
e061a11b
TZ
12388 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
12389 (emacs_gnutls_read): Likewise.
12390 (Fgnutls_boot): Return handshake error code.
12391 (emacs_gnutls_handle_error): New function.
12392 (wsaerror_to_errno): Likewise.
12393
12394 * w32.h (emacs_gnutls_pull): Add prototype.
12395 (emacs_gnutls_push): Likewise.
12396
12397 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
12398 (emacs_gnutls_push): Likewise.
12399
124002011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
12401
12402 * process.c (wait_reading_process_output): Check if GnuTLS
12403 buffered some data internally if no FDs are set for TLS
12404 connections.
12405
12406 * makefile.w32-in (OBJ2): Add gnutls.$(O).
12407 (LIBS): Link to USER_LIBS.
12408 ($(BLD)/gnutls.$(0)): New target.
12409
fa6996bc
EZ
124102011-04-24 Eli Zaretskii <eliz@gnu.org>
12411
eb35682e
EZ
12412 * xdisp.c (handle_single_display_spec): Rename the
12413 display_replaced_before_p argument into display_replaced_p, to
12414 make it consistent with the commentary. Fix typos in the
12415 commentary.
12416
e2ad650c
EZ
12417 * textprop.c (syms_of_textprop): Remove dead code.
12418 (copy_text_properties): Delete obsolete commentary about an
12419 interface that was deleted long ago. Fix typos in the description
12420 of arguments.
12421
1b2de274
EZ
12422 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
12423 to changes in oldXMenu/XMenu.h from 2011-04-16.
12424 <menu_help_message, prev_menu_help_message>: Constify.
12425 (IT_menu_make_room): menu->help_text is now `const char **';
12426 adjust.
12427
12428 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
12429 to changes in oldXMenu/XMenu.h from 2011-04-16.
12430 (struct XMenu): Declare `help_text' `const char **'.
12431
12432 * xfaces.c <Qunspecified>: Make extern again.
12433
12434 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 12435 required by POSIX.
1b2de274 12436
762b15be
EZ
12437 * doc.c (get_doc_string): Improve the format passed to `error'.
12438
12439 * doprnt.c (doprnt): Improve commentary.
12440
12441 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
12442
12443 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
12444 them with etags.
12445
f1052e5d
EZ
12446 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
12447 changes in globals.h immediately force recompilation.
762b15be
EZ
12448 (TAGS): Depend on $(CURDIR)/m/intel386.h and
12449 $(CURDIR)/s/ms-w32.h.
12450 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 12451
fa6996bc
EZ
12452 * character.c (Fchar_direction): Function deleted.
12453 (syms_of_character): Don't defsubr it.
12454 <char-direction-table>: Deleted.
12455
e6c3da20
EZ
124562011-04-23 Eli Zaretskii <eliz@gnu.org>
12457
12458 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
12459 * doprnt.c: Include limits.h.
12460 (SIZE_MAX): New macro.
04f2d78b
CB
12461 (doprnt): Return a size_t value. 2nd arg is now size_t.
12462 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
12463 Improve overflow protection. Support `l' modifier for integer
12464 conversions. Support %l conversion. Don't assume an EMACS_INT
12465 argument for integer conversions and for %c.
12466
12467 * lisp.h (doprnt): Restore prototype.
12468
12469 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
12470 $(SRC)/character.h.
12471
12472 * Makefile.in (base_obj): Add back doprnt.o.
12473
12474 * deps.mk (doprnt.o): Add back prerequisites.
12475 (callint.o): Depend on character.h.
12476
12477 * eval.c (internal_lisp_condition_case): Include the handler
12478 representation in the error message.
12479 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
12480 when breaking from the loop.
12481
12482 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
12483
12484 * callint.c (Fcall_interactively): When displaying error message
12485 about invalid control letter, pass the character's codepoint, not
12486 a pointer to its multibyte form. Improve display of the character
12487 in octal and display also its hex code.
12488
12489 * character.c (char_string): Use %x to display the (unsigned)
12490 codepoint of an invalid character, to avoid displaying a bogus
12491 negative value.
12492
12493 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
12494 `error', not SYMBOL_NAME itself.
12495
12496 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
12497 character arguments to `error'.
12498
12499 * charset.c (check_iso_charset_parameter): Fix incorrect argument
12500 to `error' in error message about FINAL_CHAR argument. Make sure
12501 FINAL_CHAR is a character, and use %c when it is passed as
12502 argument to `error'.
12503
4ffd0d6b 125042011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
12505
12506 * s/ms-w32.h (localtime): Redirect to sys_localtime.
12507
12508 * w32.c: Include <time.h>.
12509 (sys_localtime): New function.
12510
4ffd0d6b 125112011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
12512
12513 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
12514
4ffd0d6b 12515 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 12516
4ffd0d6b 125172011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 12518
4ffd0d6b
GM
12519 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
12520 zombies (Bug#8467).
aac0c6e3 12521
04c56954
EZ
125222011-04-19 Eli Zaretskii <eliz@gnu.org>
12523
12524 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
12525 gl_state.e_property when gl_state.object is Qt.
12526
12527 * insdel.c (make_gap_larger): Remove limitation of buffer size
12528 to <= INT_MAX.
12529
16a43933
CY
125302011-04-18 Chong Yidong <cyd@stupidchicken.com>
12531
12532 * xdisp.c (lookup_glyphless_char_display)
12533 (produce_glyphless_glyph): Handle cons cell entry in
12534 glyphless-char-display.
12535 (Vglyphless_char_display): Document it.
12536
12537 * term.c (produce_glyphless_glyph): Handle cons cell entry in
12538 glyphless-char-display.
12539
4581706e
CY
125402011-04-17 Chong Yidong <cyd@stupidchicken.com>
12541
12542 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
12543
12544 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
12545
12546 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
12547 definition for no-X builds.
12548
4887c6e2 125492011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 12550
fd35b6f9
PE
12551 Static checks with GCC 4.6.0 and non-default toolkits.
12552
5c1ccb01
PE
12553 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
12554
006c5daa
PE
12555 * process.c (keyboard_bit_set): Define only if SIGIO.
12556 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
12557 (send_process): Repair possible setjmp clobbering.
12558
efc736d3
PE
12559 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
12560
4e2fe2e6
PE
12561 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
12562
f97334a2
PE
12563 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
12564
4e75f29d
PE
12565 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
12566 Define only if needed.
12567
90efadd1
PE
12568 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
12569 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 12570 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 12571
3c647824
PE
12572 * dispextern.h (struct redisplay_interface): Rename param
12573 to avoid shadowing.
e264f262 12574 * termhooks.h (struct terminal): Likewise.
761383f4 12575 * xterm.c (xembed_send_message): Likewise.
3c647824 12576
b58c5c4a
PE
12577 * insdel.c (make_gap_smaller): Define only if
12578 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
12579
cad59032
PE
12580 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
12581 it.
12582
c339dc2e
PE
12583 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
12584 so that we aren't warned about unused symbols.
12585
91a3e27b
PE
12586 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
12587
399c71d3 12588 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 12589
8ffc96f5
PE
12590 * xfns.c (x_real_positions): Mark locals as initialized.
12591
eef9bc79
PE
12592 * xmenu.c (xmenu_show): Don't use uninitialized vars.
12593
098db9dd
PE
12594 * xterm.c: Fix problems found by static analysis with other toolkits.
12595 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
12596 (x_dispatch_event): Declare static if USE_GTK, and
12597 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 12598 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 12599 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
12600 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
12601 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 12602
eb18f6cc
PE
12603 * xmenu.c (menu_help_callback): Pointer type fixes.
12604 Use const pointers when pointing at readonly data. Avoid pointer
12605 signedness clashes.
12606 (FALSE): Remove unused macro.
12607 (update_frame_menubar): Remove unused decl.
12608
1fe72bf8
PE
12609 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
12610
60d9e1db
PE
12611 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
12612 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
12613 (single_menu_item): Rename local to avoid shadowing.
12614
39261c26
PE
12615 * keyboard.c (make_lispy_event): Remove unused local var.
12616
018c5e19
PE
12617 * frame.c, frame.h (x_get_resource_string): Bring this back, but
12618 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
12619
63d2b86e
PE
12620 * bitmaps: Change bitmaps from unsigned char back to the X11
12621 compatible char. Avoid the old compiler warnings about
12622 out-of-range initializers by using, for example, '\xab' rather
12623 than 0xab.
12624
aefd87e1
PE
12625 * xgselect.c (xgselect_initialize): Check vs interface
12626 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
12627
bf501fb9
PE
12628 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
12629
e9829fdf
PE
12630 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
12631 to read-only memory.
12632
1086c095
PE
12633 * fns.c (vector): Remove; this old hack is no longer needed.
12634
2baccd04 12635 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 12636 Remove unused var.
dde42981 12637 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 12638
72391843 12639 * xrdb.c (x_load_resources): Omit unused local.
3565b346 12640
436c16df 12641 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 12642 (x_window): Rename locals to avoid shadowing.
dc5ddd85 12643 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 12644
92bb796d 12645 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 12646 (x_term_init): Remove local to avoid shadowing.
92bb796d 12647
764430a3 12648 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
12649
12650 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
12651 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
12652
d1dfb56c
EZ
126532011-04-16 Eli Zaretskii <eliz@gnu.org>
12654
c4354cb4
EZ
12655 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
12656
d1dfb56c
EZ
12657 Fix regex.c, syntax.c and friends for buffers > 2GB.
12658 * syntax.h (struct gl_state_s): Declare character position members
12659 EMACS_INT.
12660
12661 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
12662
04f2d78b
CB
12663 * textprop.c (verify_interval_modification, interval_of):
12664 Declare arguments EMACS_INT.
d1dfb56c
EZ
12665
12666 * intervals.c (adjust_intervals_for_insertion): Declare arguments
12667 EMACS_INT.
12668
12669 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
12670
12671 * indent.c (Fvertical_motion): Local variable it_start is now
12672 EMACS_INT.
12673
12674 * regex.c (re_match, re_match_2, re_match_2_internal)
12675 (bcmp_translate, regcomp, regexec, print_double_string)
12676 (group_in_compile_stack, re_search, re_search_2, regex_compile)
12677 (re_compile_pattern, re_exec): Declare arguments and local
12678 variables `size_t' and `ssize_t' and return values `regoff_t', as
12679 appropriate.
12680 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
12681 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
12682 <compile_stack_type>: `size' and `avail' are now `size_t'.
12683
12684 * regex.h <regoff_t>: Use ssize_t, not int.
12685 (re_search, re_search_2, re_match, re_match_2): Arguments that
12686 specify buffer/string position and length are now ssize_t and
12687 size_t. Return type is regoff_t.
12688
613052cd
BK
126892011-04-16 Ben Key <bkey76@gmail.com>
12690
12691 * nsfont.m: Fixed bugs in ns_get_family and
12692 ns_descriptor_to_entity that were caused by using free to
12693 deallocate memory blocks that were allocated by xmalloc (via
12694 xstrdup). This caused Emacs to crash when compiled with
12695 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
12696 --enable-checking=xmallocoverrun). xfree is now used to
12697 deallocate these memory blocks.
12698
4170f62f 126992011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 12700
71b41406
PE
12701 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
12702
9587a89d
PE
12703 emacs_write: Accept and return EMACS_INT for sizes.
12704 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
12705 et seq.
12706 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
12707 Accept and return EMACS_INT.
12708 (emacs_gnutls_write): Return the number of bytes written on
12709 partial writes.
12710 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
12711 (emacs_read, emacs_write): Remove check for negative size, as the
12712 Emacs source code has been audited now.
9587a89d
PE
12713 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
12714 (emacs_read, emacs_write): Use it.
273a5f82
PE
12715 * process.c (send_process): Adjust to the new signatures of
12716 emacs_write and emacs_gnutls_write. Do not attempt to store
12717 a byte offset into an 'int'; it might overflow.
9587a89d 12718 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 12719
3e047f51
PE
12720 * sound.c: Don't assume sizes fit in 'int'.
12721 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 12722 Return EMACS_INT, not int.
3e047f51 12723 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
12724 Accept EMACS_INT, not int.
12725 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
12726 record read return values.
12727
cc39a9db
BK
127282011-04-15 Ben Key <bkey76@gmail.com>
12729
c9d0ec6d
JB
12730 * keyboard.c (Qundefined): Don't declare static since it is used
12731 in nsfns.m.
12732 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
12733 static since they are used in nsfont.m.
cc39a9db 12734
6c60eb9f
SM
127352011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
12736
12737 * process.c (Qprocessp): Don't declare static.
12738 * lisp.h (Qprocessp): Declare again.
12739
7990b61a
JB
127402011-04-15 Juanma Barranquero <lekktu@gmail.com>
12741
12742 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
12743
5d4cb038
PE
127442011-04-14 Paul Eggert <eggert@cs.ucla.edu>
12745
8bd7b830 12746 Improve C-level modularity by making more things 'static'.
cd64ea1d 12747
e3b27b31
PE
12748 Don't publish debugger-only interfaces to other modules.
12749 * lisp.h (safe_debug_print, debug_output_compilation_hack):
12750 (verify_bytepos, count_markers): Move decls to the only modules
12751 that need them.
12752 * region-cache.h (pp_cache): Likewise.
12753 * window.h (check_all_windows): Likewise.
12754 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
12755
5d4cb038
PE
12756 * sysdep.c (croak): Now static, if
12757 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
12758 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
12759
12760 * alloc.c (refill_memory_reserve): Now static if
12761 !defined REL_ALLOC || defined SYSTEM_MALLOC.
12762 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 12763
e87b6180
PE
12764 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
12765 Define only if USE_LUCID.
12766
ac64929e
PE
12767 * xrdb.c (x_customization_string, x_rm_string): Now static.
12768
6f37259d
PE
12769 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
12770 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
12771
1683e3ab
PE
12772 * xdisp.c (draw_row_with_mouse_face): Now static.
12773 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
12774
de9c2632
PE
12775 * window.h (check_all_windows): Mark externally visible.
12776
2b96acb7
PE
12777 * window.c (window_deletion_count): Now static.
12778
12779 * undo.c: Make symbols static if they're not exported.
12780 (last_undo_buffer, last_boundary_position, pending_boundary):
12781 Now static.
12782
50436f33
PE
12783 * textprop.c (interval_insert_behind_hooks): Now static.
12784 (interval_insert_in_front_hooks): Likewise.
12785
64520e5c
PE
12786 * term.c: Make symbols static if they're not exported.
12787 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
12788 (max_frame_lines, tty_set_terminal_modes):
12789 (tty_reset_terminal_modes, tty_turn_off_highlight):
12790 (get_tty_terminal): Now static.
12791 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
12792 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 12793 HAVE_WINDOW_SYSTEM.
64520e5c
PE
12794 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
12795 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
12796
1fa53021
PE
12797 * sysdep.c: Make symbols static if they're not exported.
12798 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
12799 Now static.
12800 (sigprocmask_set, full_mask): Remove; unused.
12801 (wait_debugging): Mark as visible.
12802 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
12803 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
12804
d4b43b22
PE
12805 * syntax.c (syntax_temp): Define only if !__GNUC__.
12806
b7c513d0
PE
12807 * sound.c (current_sound_device, current_sound): Now static.
12808
989b29ad
PE
12809 * search.c (searchbufs, searchbuf_head): Now static.
12810
13a55a78
PE
12811 * scroll.c (scroll_cost): Remove; unused.
12812 * dispextern.h (scroll_cost): Remove decl.
12813
de68a1fc
PE
12814 * region-cache.h (pp_cache): Mark as externally visible.
12815
40ccffa6
PE
12816 * process.c: Make symbols static if they're not exported.
12817 (process_tick, update_tick, create_process, chan_process):
12818 (Vprocess_alist, proc_buffered_char, datagram_access):
12819 (fd_callback_data, send_process_frame, process_sent_to): Now static.
12820 (deactivate_process): Mark defn as static, as well as decl.
12821 * lisp.h (create_process): Remove decl.
12822 * process.h (chan_process, Vprocess_alist): Remove decls.
12823
ad64fc97
PE
12824 * print.c: Make symbols static if they're not exported.
12825 (print_depth, new_backquote_output, being_printed, print_buffer):
12826 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
12827 (print_interval, print_number_index, initial_stderr_stream):
12828 Now static.
12829 * lisp.h (Fprinc): Remove decl.
12830 (debug_output_compilation_hack): Mark as externally visible.
12831
adddb265
PE
12832 * sysdep.c (croak): Move decl from here to syssignal.h.
12833 * syssignal.h (croak): Put it here, so the API can be checked when
12834 'croak' is called from dissociate_if_controlling_tty.
12835
1717ede2
PE
12836 * minibuf.c: Make symbols static if they're not exported.
12837 (minibuf_save_list, choose_minibuf_frame): Now static.
12838 * lisp.h (choose_minibuf_frame): Remove decl.
12839
fa5fb2bc
PE
12840 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
12841
1e3890d1
PE
12842 * lread.c: Make symbols static if they're not exported.
12843 (read_objects, initial_obarray, oblookup_last_bucket_number):
12844 Now static.
12845 (make_symbol): Remove; unused.
12846 * lisp.h (initial_obarray, make_symbol): Remove decls.
12847
8a1414fa
PE
12848 * keyboard.c: Make symbols static if they're not exported.
12849 (single_kboard, recent_keys_index, total_keys, recent_keys):
12850 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
12851 (this_single_command_key_start, echoing, last_auto_save):
12852 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
12853 (command_loop, echo_now, keyboard_init_hook, help_char_p):
12854 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
12855 (Vlispy_mouse_stem, double_click_count):
12856 Now static.
12857 (force_auto_save_soon): Define only if SIGDANGER.
12858 (ignore_mouse_drag_p): Now static if
12859 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
12860 (print_help): Remove; unused.
12861 (stop_character, last_timer_event): Mark as externally visible.
12862 * keyboard.h (ignore_mouse_drag_p): Declare only if
12863 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
12864 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
12865 * lisp.h (echoing): Remove decl.
12866 (force_auto_save_soon): Declare only if SIGDANGER.
12867 * xdisp.c (redisplay_window): Simplify code, to make it more
12868 obvious that ignore_mouse_drag_p is not accessed if !defined
12869 USE_GTK && !defined HAVE_NS.
12870
93ea6e8f
PE
12871 * intervals.c: Make symbols static if they're not exported.
12872 (merge_properties_sticky, merge_interval_right, delete_interval):
12873 Now static.
12874 * intervals.h (merge_interval_right, delete_interval): Remove decls.
12875
77382fcc
PE
12876 * insdel.c: Make symbols static if they're not exported.
12877 However, leave prepare_to_modify_buffer alone. It's never
12878 called from outside this function, but that appears to be a bug.
12879 (combine_after_change_list, combine_after_change_buffer):
4889fc82 12880 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
12881 (adjust_after_replace_noundo): Remove; unused.
12882 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 12883 (signal_before_change): Remove decls.
77382fcc 12884
9306c32e
PE
12885 * indent.c (val_compute_motion, val_vmotion): Now static.
12886
cd44d2eb
PE
12887 * image.c: Make symbols static if they're not exported.
12888 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
12889 if USE_GTK.
12890 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
12891 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
12892
ad9a7a06
PE
12893 * fringe.c (standard_bitmaps): Now static.
12894 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
12895
81626931
PE
12896 * frame.c: Make symbols static if they're not exported.
12897 (x_report_frame_params, make_terminal_frame): Now static.
12898 (get_frame_param): Now static, unless HAVE_NS.
12899 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
12900 (x_get_resource_string): Remove; not used.
12901 * frame.h (make_terminal_frame, x_report_frame_params):
12902 (x_get_resource_string); Remove decls.
12903 (x_fullscreen_adjust): Declare only if WINDOWSNT.
12904 * lisp.h (get_frame_param): Declare only if HAVE_NS.
12905
239f9db9
PE
12906 * font.c, fontset.c: Make symbols static if they're not exported.
12907 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
12908 (FACE_SUITABLE_FOR_CHAR_P): Use it.
12909 * font.c (font_close_object): Now static.
12910 * font.h (font_close_object): Remove.
12911 * fontset.c (FONTSET_OBJLIST): Remove.
12912 (free_realized_fontset) #if-0 the body, which does nothing.
12913 (face_suitable_for_char_p): #if-0, as it's never called.
12914 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
12915 * xfaces.c (face_at_string_position):
12916 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
12917 since 0 is always ASCII.
12918
dfcf3579
PE
12919 * fns.c (weak_hash_tables): Now static.
12920
5045092b
PE
12921 * fileio.c: Make symbols static if they're not exported.
12922 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
12923 (Vwrite_region_annotation_buffers): Now static.
12924
57a96f5c
PE
12925 * eval.c: Make symbols static if they're not exported.
12926 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
12927 * lisp.h (backtrace_list): Remove decl.
12928
35f08c38
PE
12929 * emacs.c: Make symbols static if they're not exported.
12930 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
12931 (fatal_error_code, fatal_error_signal_hook, standard_args):
12932 Now static.
12933 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
12934 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
12935 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
12936 * lisp.h (fatal_error_signal_hook): Remove decl.
12937 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
12938
f44bd759
PE
12939 * editfns.c: Move a (normally-unused) function to its only use.
12940 * editfns.c, lisp.h (get_operating_system_release): Remove.
12941 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
12942 worth the hassle of breaking this out.
12943
b532497d
PE
12944 * xterm.c: Make symbols static if they're not exported.
12945 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
12946 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
12947 (x_destroy_window, x_delete_display):
12948 Now static.
12949 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
12950 (x_mouse_leave): Remove; unused.
12951 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
12952 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
12953 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
12954 Remove decls.
12955 (x_mouse_leave): Declare only if WINDOWSNT.
12956 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
12957 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
12958 USE_X_TOOLKIT.
12959
1675728f
PE
12960 * ftxfont.c: Make symbols static if they're not exported.
12961 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
12962 HAVE_FREETYPE.
12963 * font.h (ftxfont_driver): Likewise.
12964
e4cebfca
PE
12965 * xfns.c: Make symbols static if they're not exported.
12966 (x_last_font_name, x_display_info_for_name):
12967 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
12968 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
12969 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
12970 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
12971 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
12972 (last_show_tip_args): Now static.
12973 (xic_defaut_fontset, xic_create_fontsetname): Define only if
12974 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
12975 (x_screen_planes): Remove; unused.
12976 * dispextern.h (x_screen_planes): Remove decl.
12977
5bf46f05
PE
12978 * dispnew.c: Make symbols static if they're not exported.
12979 * dispextern.h (redraw_garbaged_frames, scrolling):
12980 (increment_row_positions): Remove.
12981 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
12982 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
12983 Now static.
12984 (redraw_garbaged_frames): Remove; unused.
12985
435f4c28
PE
12986 * xfaces.c: Make symbols static if they're not exported.
12987 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
12988 Remove decls.
12989 * xterm.h (defined_color): Remove decls.
12990 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
12991 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
12992 (menu_face_changed_default, defined_color, free_realized_face):
12993 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
12994 (ascii_face_of_lisp_face): Remove; unused.
12995
8524aef3
PE
12996 * xdisp.c: Make symbols static if they're not exported.
12997 * dispextern.h (scratch_glyph_row, window_box_edges):
12998 (glyph_to_pixel_coords, set_cursor_from_row):
12999 (get_next_display_element, set_iterator_to_next):
13000 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
13001 (show_mouse_face): Remove decls
13002 * frame.h (message_buf_print): Likewise.
13003 * lisp.h (pop_message, set_message, check_point_in_composition):
13004 Likewise.
13005 * xterm.h (set_vertical_scroll_bar): Likewise.
13006 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
13007 (message_buf_print, scratch_glyph_row, displayed_buffer):
13008 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
13009 (get_next_display_element, show_mouse_face, window_box_edges):
13010 (frame_to_window_pixel_xy, check_point_in_composition):
13011 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
13012 (glyph_to_pixel_coords): Remove; unused.
13013
16390cd2
PE
13014 * dired.c (file_name_completion): Now static.
13015
13016 * dbusbind.c (xd_in_read_queued_messages): Now static.
13017
a25f4dfa
PE
13018 * lisp.h (circular_list_error, FOREACH): Remove; unused.
13019 * data.c (circular_list_error): Remove.
13020
14a9c8df
PE
13021 * commands.h (last_point_position, last_point_position_buffer):
13022 (last_point_position_window): Remove decls.
13023 * keyboard.c: Make these variables static.
13024
04f2d78b
CB
13025 * coding.h (coding, code_convert_region, encode_coding_gap):
13026 Remove decls.
74ab6df5
PE
13027 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
13028 (iso_code_class, detect_coding, code_convert_region): Now static.
13029 (encode_coding_gap): Remove; unused.
13030
38dfbee1
PE
13031 * chartab.c (chartab_chars, chartab_bits): Now static.
13032
a2cb4e63
PE
13033 * charset.h (charset_iso_8859_1): Remove decl.
13034 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
13035 Now static.
13036
127198fd
PE
13037 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
13038 * ccl.c (Vccl_program_table): Now static.
13039 (check_ccl_update): Remove; unused.
13040
d85b608f
PE
13041 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
13042 * category.h: ... from here.
13043 * category.c (check_category_table, set_category_set): Now static.
13044
31cd66f3
PE
13045 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
13046 * lisp.h: Remove these decls.
13047
c358e587
PE
13048 * buffer.c (buffer_count): Remove unused var.
13049
e78aecca
PE
13050 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
13051 so that it's not optimized away.
13052 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
13053 * dispextern.h (bidi_dump_cached_states): Remove, since it's
13054 exported only to the debugger.
13055
e192d7d3 13056 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 13057 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 13058
92470028
PE
13059 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
13060 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
13061 was inaccessible from Lisp.
13062 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
13063 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
13064
244ed907
PE
13065 alloc.c: Import and export fewer symbols, and remove unused items.
13066 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
13067 is defined.
13068 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
13069 it's not optimized away by whole-program optimization.
13070 (message_enable_multibyte, free_misc): Remove.
13071 (catchlist, handlerlist, mark_backtrace):
13072 Declare only if BYTE_MARK_STACK.
13073 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
13074 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
13075 (message_enable_multibyte): Remove decl.
13076 (free_misc, interval_free_list, float_block, float_block_index):
13077 (n_float_blocks, float_free_list, cons_block, cons_block_index):
13078 (cons_free_list, last_marked_index):
13079 Now static.
13080 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
13081 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
13082 (mark_backtrace): Define only if BYTE_MARK_STACK.
13083 * xdisp.c (message_enable_multibyte): Now static.
13084
61c2b50e 13085 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
13086 This makes it easier for human readers (and static analyzers)
13087 to see whether these variables are used from other modules.
13088 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
13089 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
13090 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
13091 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
13092 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
13093 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
13094 * xmenu.c, xselect.c:
13095 Declare Q* vars static if they are not used in other modules.
13096 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
13097 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
13098 Remove decls of unexported vars.
13099 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
13100
95c82688
PE
13101 * lisp.h (DEFINE_FUNC): Make sname 'static'.
13102
16a97296
PE
13103 Make Emacs functions such as Fatom 'static' by default.
13104 This makes it easier for human readers (and static analyzers)
13105 to see whether these functions can be called from other modules.
13106 DEFUN now defines a static function. To make the function external
13107 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
13108 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
13109 (Finit_image_library):
16a97296
PE
13110 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
13111 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
13112 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
13113 Remove decls, since these functions are now static.
13114 (Funintern, Fget_internal_run_time): New decls, since these functions
13115 were already external.
95c82688 13116
16a97296
PE
13117 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
13118 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
13119 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
13120 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
13121 * keyboard.c, keymap.c, lread.c:
13122 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
13123 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
13124 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
13125 Mark functions with DEFUE instead of DEFUN,
13126 if they are used in other modules.
13127 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
13128 decls for now-static functions.
13129 * buffer.h (Fdelete_overlay): Remove decl.
13130 * callproc.c (Fgetenv_internal): Mark as internal.
13131 * composite.c (Fremove_list_of_text_properties): Remove decl.
13132 (Fcomposition_get_gstring): New forward static decl.
13133 * composite.h (Fcomposite_get_gstring): Remove decl.
13134 * dired.c (Ffile_attributes): New forward static decl.
13135 * doc.c (Fdocumntation_property): New forward static decl.
13136 * eval.c (Ffetch_bytecode): New forward static decl.
13137 (Funintern): Remove extern decl; now in .h file where it belongs.
13138 * fileio.c (Fmake_symbolic_link): New forward static decl.
13139 * image.c (Finit_image_library): New forward static decl.
13140 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
13141 * intervals.h (Fprevious_property_change):
13142 (Fremove_list_of_text_properties): Remove decls.
13143 * keyboard.c (Fthis_command_keys): Remove decl.
13144 (Fcommand_execute): New forward static decl.
13145 * keymap.c (Flookup_key): New forward static decl.
13146 (Fcopy_keymap): Now static.
13147 * keymap.h (Flookup_key): Remove decl.
13148 * process.c (Fget_process): New forward static decl.
13149 (Fprocess_datagram_address): Mark as internal.
13150 * syntax.c (Fsyntax_table_p): New forward static decl.
13151 (skip_chars): Remove duplicate decl.
13152 * textprop.c (Fprevious_property_change): New forward static decl.
13153 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
13154 Now internal.
13155 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
13156 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
13157
785bbd42
PE
13158 * editfns.c (Fformat): Remove unreachable code.
13159
8b913b57
AS
131602011-04-14 Andreas Schwab <schwab@linux-m68k.org>
13161
13162 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
13163 change. (Bug#8496)
13164
a6744a35
EZ
131652011-04-13 Eli Zaretskii <eliz@gnu.org>
13166
13167 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
13168 when at ZV. (Bug#8487)
13169
e7974947
AS
131702011-04-12 Andreas Schwab <schwab@linux-m68k.org>
13171
baad03f0
AS
13172 * charset.c (Fclear_charset_maps): Use xfree instead of free.
13173 (Bug#8437)
13174 * keyboard.c (parse_tool_bar_item): Likewise.
13175 * sound.c (sound_cleanup, alsa_close): Likewise.
13176 * termcap.c (tgetent): Likewise.
13177 * xfns.c (x_default_font_parameter): Likewise.
13178 * xsettings.c (read_and_apply_settings): Likewise.
13179
e7974947
AS
13180 * alloc.c (overrun_check_malloc, overrun_check_realloc)
13181 (overrun_check_free): Protoize.
13182
28272684
PE
131832011-04-12 Paul Eggert <eggert@cs.ucla.edu>
13184
13185 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
13186 since callers should never pass a negative size.
13187 Change the signature to match that of plain 'read' and 'write'; see
13188 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
13189 * lisp.h: Update prototypes of emacs_write and emacs_read.
13190
11997c76
EZ
131912011-04-11 Eli Zaretskii <eliz@gnu.org>
13192
13193 * xdisp.c (redisplay_window): Don't try to determine the character
13194 position of the scroll margin if the window start point w->startp
e896f03c 13195 is outside the buffer's accessible region. (Bug#8468)
11997c76 13196
8a2cbd72
EZ
131972011-04-10 Eli Zaretskii <eliz@gnu.org>
13198
13199 Fix write-region and its subroutines for buffers > 2GB.
13200 * fileio.c (a_write, e_write): Modify declaration of arguments and
13201 local variables to support buffers larger than 2GB.
13202 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
13203
13204 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
13205 argument, local variables, and return value.
13206
13207 * lisp.h: Update prototypes of emacs_write and emacs_read.
13208
13209 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
13210
4073e537 132112011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 13212
1ebfdcb6
PE
13213 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
13214
b2ded58d
PE
13215 Fix more problems found by GCC 4.6.0's static checks.
13216
7d66342c
PE
13217 * xdisp.c (vmessage): Use a better test for character truncation.
13218
bbf47d44
PE
13219 * charset.c (load_charset_map): <, not <=, for optimization,
13220 and to avoid potential problems with integer overflow.
9248994d 13221 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 13222 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 13223 * editfns.c (Fformat): Likewise.
1e69125e 13224 * syntax.c (skip_chars): Likewise.
3befa583 13225
e3019616
PE
13226 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
13227 This also lets GCC 4.6.0 generate slightly better loop code.
13228
becfa255
PE
13229 * callint.c (Fcall_interactively): <, not <=, for optimization.
13230 (Fcall_interactively): Count the number of arguments produced,
13231 not the number of arguments given. This is simpler and lets GCC
13232 4.6.0 generate slightly better code.
13233
dae0cd48
PE
13234 * ftfont.c: Distingish more carefully between FcChar8 and char.
13235 The previous code passed unsigned char * to a functions like
13236 strlen and xstrcasecmp that expect char *, which does not
13237 conform to the C standard.
13238 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
13239 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
13240 char * when the C standard requires it.
13241
76032d70
PE
13242 * keyboard.c (read_char): Remove unused var.
13243
eb3f1cc8
PE
13244 * eval.c: Port to Windows vsnprintf (Bug#8435).
13245 Include <limits.h>.
13246 (SIZE_MAX): Define if the headers do not.
13247 (verror): Do not give up if vsnprintf returns a negative count.
13248 Instead, grow the buffer. This ports to Windows vsnprintf, which
13249 does not conform to C99. Problem reported by Eli Zaretskii.
13250 Also, simplify the allocation scheme, by avoiding the need for
13251 calling realloc, and removing the ALLOCATED variable.
13252
70476b54
PE
13253 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
13254
12020a9e
PE
13255 Remove invocations of doprnt, as Emacs now uses vsnprintf.
13256 But keep the doprint source code for now, as we might revamp it
13257 and use it again (Bug#8435).
ea6c7ae6
PE
13258 * lisp.h (doprnt): Remove.
13259 * Makefile.in (base_obj): Remove doprnt.o.
13260 * deps.mk (doprnt.o): Remove.
13261
5fdb398c
PE
13262 error: Print 32- and 64-bit integers portably (Bug#8435).
13263 Without this change, on typical 64-bit hosts error ("...%d...", N)
13264 was used to print both 32- and 64-bit integers N, which relied on
13265 undefined behavior.
61bdb816 13266 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
13267 * lisp.h (error, verror): Mark as printf-like functions.
13268 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
13269 Report overflow in size calculations when allocating printf buffer.
13270 Do not truncate output string at its first null byte.
13271 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
13272 Truncate the output at a character boundary, since vsnprintf does not
13273 do that.
13274 * charset.c (check_iso_charset_parameter): Convert internal
13275 character to string before calling 'error', since %c now has the
13276 printf meaning.
13277 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
13278 overflow when computing char to be passed to 'error'. Do not
13279 pass Lisp_Object to 'error'; pass the integer instead.
13280 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
13281 formatted with plain %d.
13282
b189fa66
PE
13283 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
13284
bff87ef0
PE
13285 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
13286
7e2cac20
PE
13287 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
13288
ce4d90b5
PE
13289 * xterm.c (x_catch_errors): Remove duplicate declaration.
13290
266c9547
PE
13291 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
13292
79c49ad2
PE
13293 * xdisp.c, lisp.h (message_nolog): Remove; unused.
13294
368f4090
JM
132952011-04-10 Jim Meyering <meyering@redhat.com>
13296
13297 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
13298 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
13299 return ssize_t not "int", and use size_t as the buffer length.
13300 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
13301 * gnutls.h: Update declarations.
13302 * process.c (read_process_output): Use ssize_t, to match.
13303 (send_process): Likewise.
13304
a32d4040
CY
133052011-04-09 Chong Yidong <cyd@stupidchicken.com>
13306
13307 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
13308
8546720e 133092011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 13310
04f2d78b
CB
13311 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
13312 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 13313
8546720e
GM
13314 * xterm.c (handle_one_xevent):
13315 * xmenu.c (create_and_show_popup_menu):
13316 * xselect.c (x_decline_selection_request)
13317 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 13318
0a2f5c1a 133192011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
13320
13321 Fix some uses of `int' instead of EMACS_INT.
13322 * search.c (string_match_1, fast_string_match)
13323 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
13324 (scan_buffer, find_next_newline_no_quit)
13325 (find_before_next_newline, search_command, Freplace_match)
13326 (Fmatch_data): Make some `int' variables be EMACS_INT.
13327
13328 * xdisp.c (display_count_lines): 3rd argument and return value now
13329 EMACS_INT. All callers changed.
13330 (pint2hrstr): Last argument is now EMACS_INT.
13331
13332 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
13333 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
13334 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
13335 (decode_coding_utf_16, decode_coding_emacs_mule)
13336 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
13337 (decode_coding_ccl, decode_coding_charset)
13338 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
13339 (decode_coding_iso_2022, decode_coding_emacs_mule)
13340 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
13341 <char_offset, last_offset>: Declare EMACS_INT.
13342 (encode_coding_utf_8, encode_coding_utf_16)
13343 (encode_coding_emacs_mule, encode_invocation_designation)
13344 (encode_designation_at_bol, encode_coding_iso_2022)
13345 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
13346 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
13347 Declare EMACS_INT.
13348 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
13349 (encode_invocation_designation): Last argument P_NCHARS is now
13350 EMACS_INT.
13351 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
13352 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
13353
13354 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
13355 All users changed.
13356
13357 * ccl.c (Fccl_execute_on_string): Declare some variables
13358 EMACS_INT.
13359
8546720e 133602011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
13361
13362 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
13363
4e19a977
CS
133642011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
13365
13366 * process.c (Fformat_network_address): Doc fix.
13367
87302331
R
133682011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
13369
ee7683eb 13370 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 13371
cbb59342
CY
133722011-04-08 Chong Yidong <cyd@stupidchicken.com>
13373
13374 * keyboard.c (read_char): Call Lisp function help-form-show,
13375 instead of using internal_with_output_to_temp_buffer.
13376 (Qhelp_form_show): New var.
e0d38eeb 13377 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
13378
13379 * print.c (internal_with_output_to_temp_buffer): Function deleted.
13380
13381 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
13382
e67a13ab
CY
133832011-04-06 Chong Yidong <cyd@stupidchicken.com>
13384
04f2d78b
CB
13385 * process.c (Flist_processes): Remove to Lisp.
13386 (list_processes_1): Delete.
e67a13ab 13387
973f782d
EZ
133882011-04-06 Eli Zaretskii <eliz@gnu.org>
13389
7c106b1e
EZ
13390 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
13391
973f782d
EZ
13392 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
13393
41cf7d1a 133942011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 13395
ca23cc88
PE
13396 Fix more problems found by GCC 4.6.0's static checks.
13397
f390e2d5
PE
13398 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
13399
42eea0d0
PE
13400 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
13401
b69769da 13402 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 13403
f9541e84
PE
13404 * xdisp.c (vmessage): Mark as a printf-like function.
13405
13841b55
PE
13406 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
13407
c136c10f
PE
13408 * sound.c (sound_warning): Don't crash if arg contains a printf format.
13409
5e2d4a30
PE
13410 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
13411 printf-like functions.
13412 (tiff_load): Add casts to remove these marks before passing them
13413 to system-supplied API.
13414
583f48b9
PE
13415 * eval.c (Fsignal): Remove excess argument to 'fatal'.
13416
b25d760e
PE
13417 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
13418 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
13419 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
13420 directly, rather than having caller test rule sign. This avoids
13421 some unnecessary tests.
13422 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
13423 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
13424 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 13425
bc7b6697 13426 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 13427 (xfont_open): Avoid unnecessary tests.
bc7b6697 13428
27ccc379
PE
13429 * composite.c (composition_gstring_put_cache): Use unsigned integer.
13430
dcd5c89a
PE
13431 * composite.h, composite.c (composition_gstring_put_cache):
13432 Use EMACS_INT, not int, for length.
13433
b13a45c6
PE
13434 * composite.h (COMPOSITION_DECODE_REFS): New macro,
13435 breaking out part of COMPOSITION_DECODE_RULE.
13436 (COMPOSITION_DECODE_RULE): Use it.
13437 * composite.c (get_composition_id): Remove unused local vars,
13438 by using the new macro.
13439
1e792e4d
PE
13440 * textprop.c (set_text_properties_1): Change while to do-while,
13441 since the condition is always true at first.
13442
dc6c6455 13443 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
13444 (interval_deletion_adjustment): Return unsigned value.
13445 All uses changed.
dc6c6455 13446
aba7731a
PE
13447 * process.c (list_processes_1, create_pty, read_process_output):
13448 (exec_sentinel): Remove vars that were set but not used.
afd4052b 13449 (create_pty): Remove unnecessary "volatile"s.
bc57d757 13450 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 13451 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 13452 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 13453
fdfc4bf3
PE
13454 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
13455
fca8fe46 13456 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 13457 (update_syntax_table): Use unsigned instead of int.
fca8fe46 13458
06a0259a 13459 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 13460 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 13461 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 13462
e7b9e80f
PE
13463 * print.c (print_error_message): Avoid int overflow.
13464
56201685
PE
13465 * font.c (font_list_entities): Redo for clarity,
13466 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
13467
78834453 13468 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 13469 (font_score): Avoid potential overflow in diff calculation.
78834453 13470
0bc0b309 13471 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 13472 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 13473
e610eaca
PE
13474 * eval.c (funcall_lambda): Rename local to avoid shadowing.
13475
b895abce
PE
13476 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
13477 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
13478 can always succeed if overflow has undefined behavior.
13479
1f1d9321 13480 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 13481 (wordify): Omit three unnecessary tests.
1f1d9321 13482
c59478bc
PE
13483 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
13484 All callers changed. This avoids the need for an unused var.
13485
79b73827
PE
13486 * casefiddle.c (casify_region): Remove var that is set but not used.
13487
a4db5dfe
PE
13488 * dired.c (file_name_completion): Remove var that is set but not used.
13489
43aae36e
PE
13490 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
13491
2a47c44d 13492 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 13493 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 13494
a37c69bf
PE
13495 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
13496 Check for integer overflow on size calculations.
13497
328ab8e7
PE
13498 * buffer.c (Fprevious_overlay_change): Remove var that is set
13499 but not used.
13500
e5a2a5cb
PE
13501 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
13502 Remove vars that are set but not used.
8d84a6eb 13503 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 13504 (timer_check_2): Mark vars as initialized.
e5a2a5cb 13505
a60e5f68
PE
13506 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
13507
f661cb61 13508 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 13509 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 13510
f0397f5a
PE
13511 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
13512 that are set but not used.
13513
8664db06 13514 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 13515 if XCreateBitmapFromData fails (Bug#8410).
8664db06 13516
6abdaa4a
PE
13517 * xselect.c (x_get_local_selection, x_handle_property_notify):
13518 Remove vars that are set but not used.
13519
0ce7538d 13520 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 13521 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 13522
9ae848fc
PE
13523 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
13524 Remove var that is set but not used.
0b918413
PE
13525 (scroll_bar_windows_size): Now size_t, not int.
13526 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
13527 Check for overflow.
9ae848fc 13528
a5a62657
PE
13529 * xfaces.c (realize_named_face): Remove vars that are set but not used.
13530 (map_tty_color) [!defined MSDOS]: Likewise.
13531
5c5cdd39
PE
13532 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
13533
66ebf983
PE
13534 * coding.c: Remove vars that are set but not used.
13535 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
13536 All callers changed.
13537 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
13538 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
13539 (decode_coding_charset): Remove vars that are set but not used.
13540
1be4d761
PE
13541 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
13542 that is set but not used.
13543
47553fa8
PE
13544 * print.c (print_object): Remove var that is set but not used.
13545
1f7196bf 13546 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
13547 The gnulib version avoids calling malloc in the usual case,
13548 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
13549 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
13550 * filelock.c (current_lock_owner): Likewise.
13551 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
13552 * sysdep.c: Include allocator.h, careadlinkat.h.
13553 (emacs_no_realloc_allocator): New static constant.
13554 (emacs_readlink): New function.
fdb61804
PE
13555 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
13556 ../lib/careadlinkat.h.
d1fdcab7 13557
f84c17c7
SM
135582011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
13559
13560 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
13561 first non-nil return value).
13562
ef3862ad
JD
135632011-04-03 Jan Djärv <jan.h.d@swipnet.se>
13564
13565 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
13566 if not defined (Bug#8403).
13567
376a7006
JB
135682011-04-02 Juanma Barranquero <lekktu@gmail.com>
13569
13570 * xdisp.c (display_count_lines): Remove parameter `start',
13571 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13572 (get_char_face_and_encoding): Remove parameter `multibyte_p',
13573 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13574 (fill_stretch_glyph_string): Remove parameters `row' and `area',
13575 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
13576 and thereabouts. All callers changed.
13577 (get_per_char_metric): Remove parameter `f', unused since
13578 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13579
6ca3801d
JM
135802011-04-02 Jim Meyering <meyering@redhat.com>
13581
13582 do not dereference NULL upon failed strdup
13583 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
13584 (ns_get_family): Likewise.
13585
d8e2b5ba
JB
135862011-04-02 Juanma Barranquero <lekktu@gmail.com>
13587
13588 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
13589
8c74fcbd
JD
135902011-04-02 Jan Djärv <jan.h.d@swipnet.se>
13591
13592 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
13593 later (Bug#8403).
13594
7200d79c
SM
135952011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
13596
03408648 13597 Add lexical binding.
7200d79c 13598
03408648
SM
13599 * window.c (Ftemp_output_buffer_show): New fun.
13600 (Fsave_window_excursion):
13601 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
13602
13603 * lread.c (lisp_file_lexically_bound_p): New function.
13604 (Fload): Bind Qlexical_binding.
13605 (readevalloop): Remove `evalfun' arg.
13606 Bind Qinternal_interpreter_environment.
13607 (Feval_buffer): Bind Qlexical_binding.
13608 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
13609 Mark as dynamic.
13610 (syms_of_lread): Declare `lexical-binding'.
13611
13612 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
13613
13614 * keyboard.c (eval_dyn): New fun.
13615 (menu_item_eval_property): Use it.
ca105506
SM
13616
13617 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 13618
03408648
SM
13619 * fns.c (concat, mapcar1): Accept byte-code-functions.
13620
13621 * eval.c (Fsetq): Handle lexical vars.
13622 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
13623 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
13624 (FletX, Flet): Obey lexical binding.
13625 (Fcommandp): Handle closures.
13626 (Feval): New `lexical' arg.
13627 (eval_sub): New function extracted from Feval. Use it almost
13628 everywhere where Feval was used. Look up vars in lexical env.
13629 Handle closures.
13630 (Ffunctionp): Move from subr.el.
13631 (Ffuncall): Handle closures.
13632 (apply_lambda): Remove `eval_flags'.
13633 (funcall_lambda): Handle closures and new byte-code-functions.
13634 (Fspecial_variable_p): New function.
13635 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
13636 but without exporting it to Lisp.
23aba0ea 13637
23aba0ea 13638 * doc.c (Fdocumentation, store_function_docstring):
03408648 13639 * data.c (Finteractive_form): Handle closures.
23aba0ea 13640
03408648
SM
13641 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
13642 interactive spec.
ba83908c 13643
04f2d78b
CB
13644 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
13645 New byte-codes.
03408648
SM
13646 (exec_byte_code): New function extracted from Fbyte_code to handle new
13647 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 13648
03408648 13649 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 13650
03408648 13651 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 13652
e2abce01
JB
136532011-03-31 Juanma Barranquero <lekktu@gmail.com>
13654
13655 * xdisp.c (redisplay_internal): Fix prototype.
13656
63696a73 136572011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 13658
63696a73 13659 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
13660 (try_scrolling): Use it when setting scroll_limit.
13661 Limit scrolling to 100 screen lines.
63696a73
EZ
13662 (redisplay_window): Even when falling back on "recentering",
13663 position point in the window according to scroll-conservatively,
13664 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
13665
13666 (try_scrolling): When point is above the window, allow searching
13667 as far as scroll_max, or one screenful, to compute vertical
13668 distance from PT to the scroll margin position. This prevents
13669 try_scrolling from unnecessarily failing when
13670 scroll-conservatively is set to a value slightly larger than the
13671 window height. Clean up the case of PT below the margin at bottom
13672 of window: scroll_max can no longer be INT_MAX. When aggressive
13673 scrolling is in use, don't let point enter the opposite scroll
13674 margin as result of the scroll.
13675 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
13676 threshold of 100 lines for never-recentering scrolling.
13677
e4cc2dfc
JB
136782011-03-31 Juanma Barranquero <lekktu@gmail.com>
13679
13680 * dispextern.h (move_it_by_lines):
13681 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
13682 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
13683 (message_log_check_duplicate): Remove parameters `prev_bol' and
13684 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13685 (redisplay_internal): Remove parameter `preserve_echo_area',
13686 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
13687
13688 * indent.c (Fvertical_motion):
13689 * window.c (window_scroll_pixel_based, Frecenter):
13690 Don't pass `need_y_p' to `move_it_by_lines'.
13691
1c470562
SM
136922011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
13693
44f230aa
SM
13694 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
13695 steal a few bits to be more compact.
13696 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
13697 Remove unneeded casts.
13698
1c470562
SM
13699 * bytecode.c (Fbyte_code): CAR and CDR can GC.
13700
888adce9
ZK
137012011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
13702
13703 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
13704 binding" message (bug#7967).
13705
f838ed7b
PE
137062011-03-30 Paul Eggert <eggert@cs.ucla.edu>
13707
77861b95
PE
13708 Fix more problems found by GCC 4.6.0's static checks.
13709
de6dbc14
PE
13710 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
13711 Remove unused local var.
13712
f838ed7b
PE
13713 * editfns.c (Fmessage_box): Remove unused local var.
13714
792c7b2b
PE
13715 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
13716 (note_mode_line_or_margin_highlight, note_mouse_highlight):
13717 Omit unused local vars.
c499e557 13718 * window.c (shrink_windows): Omit unused local var.
b01a1c29 13719 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
13720 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
13721 Omit unused local var.
13722
ba0165e1
PE
13723 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
13724 Don't assume string length fits in int.
32ad8845 13725 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 13726 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 13727
3c59b4c9
PE
13728 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
13729 instead of alloca (Bug#8344).
13730
a3eed478 13731 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 13732 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 13733
eb4d412d
PE
13734 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
13735
1658b401
PE
13736 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
13737 concerns.
13738
13739 * term.c (produce_glyphless_glyph): Remove unnecessary test.
13740
13741 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 13742
9a2c6e05
PE
13743 * keyboard.c (syms_of_keyboard): Use the same style as later
13744 in this function when indexing through an array. This also
13745 works around GCC bug 48267.
13746
03d0a109
PE
13747 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
13748
44f730c8
PE
13749 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
13750
fe75f926
PE
13751 * chartab.c (sub_char_table_ref_and_range): Redo for slight
13752 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
13753
ffa8c828
PE
13754 * keyboard.c, keyboard.h (num_input_events): Now size_t.
13755 This avoids undefined behavior on integer overflow, and is a bit
13756 more convenient anyway since it is compared to a size_t variable.
13757
c5101a77
PE
13758 Variadic C functions now count arguments with size_t, not int.
13759 This avoids an unnecessary limitation on 64-bit machines, which
13760 caused (substring ...) to crash on large vectors (Bug#8344).
13761 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
13762 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 13763 All variadic functions and their callers changed accordingly.
c5101a77
PE
13764 (struct gcpro.nvars): Now size_t, not int. All uses changed.
13765 * data.c (arith_driver, float_arith_driver): Likewise.
13766 * editfns.c (general_insert_function): Likewise.
13767 * eval.c (struct backtrace.nargs, interactive_p)
13768 (internal_condition_case_n, run_hook_with_args, apply_lambda)
13769 (funcall_lambda, mark_backtrace): Likewise.
13770 * fns.c (concat): Likewise.
13771 * frame.c (x_set_frame_parameters): Likewise.
13772 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
13773 0 if not found, not -1. All callers changed.
13774
dd3f25f7
PE
13775 * alloc.c (garbage_collect): Don't assume stack size fits in int.
13776 (stack_copy_size): Now size_t, not int.
13777 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
13778
461c2ab9
JB
137792011-03-28 Juanma Barranquero <lekktu@gmail.com>
13780
13781 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
13782 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13783 All callers changed.
13784
13785 * lisp.h (multibyte_char_to_unibyte):
13786 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
13787 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13788 * character.h (CHAR_TO_BYTE8):
13789 * cmds.c (internal_self_insert):
13790 * editfns.c (general_insert_function):
13791 * keymap.c (push_key_description):
13792 * search.c (Freplace_match):
13793 * xdisp.c (message_dolog, set_message_1): All callers changed.
13794
f6d62986
SM
137952011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
13796
13797 * keyboard.c (safe_run_hook_funcall): New function.
13798 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
13799 don't set the hook to nil, but remove the offending function instead.
13800 (Qcommand_hook_internal): Remove, unused.
13801 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
13802 Vcommand_hook_internal.
13803
13804 * eval.c (enum run_hooks_condition): Remove.
13805 (funcall_nil, funcall_not): New functions.
13806 (run_hook_with_args): Call each function through a `funcall' argument.
13807 Remove `cond' argument, now redundant.
13808 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
13809 (Frun_hook_with_args_until_failure): Adjust accordingly.
13810 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
13811
1db5b1ad
JB
138122011-03-28 Juanma Barranquero <lekktu@gmail.com>
13813
13814 * dispextern.h (string_buffer_position): Remove declaration.
13815
13816 * print.c (strout): Remove parameter `multibyte', unused since
13817 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
13818
13819 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
13820 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
13821 All callers changed.
13822
13823 * w32.c (_wsa_errlist): Use braces for struct initializers.
13824
13825 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
13826 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
13827 All callers changed.
13828 (string_buffer_position): Likewise. Also, make static (it's never
13829 used outside xdisp.c).
13830 (cursor_row_p): Remove parameter `w', unused since
13831 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
13832 (decode_mode_spec): Remove parameter `precision', introduced during
13833 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
13834 All callers changed.
13835
5ffb62aa
JD
138362011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13837
13838 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
13839
461c2ab9 138402011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
13841
13842 * nsterm.m (ns_menu_bar_is_hidden): New variable.
13843 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
13844 (ns_update_auto_hide_menu_bar): New functions.
13845 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
13846 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
13847 ns_constrain_all_frames.
13848 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
13849 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
13850
5c380ffb
JD
138512011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13852
13853 * nsmenu.m (runDialogAt): Remove argument to timer_check.
13854
9af30bdf
GM
138552011-03-27 Glenn Morris <rgm@gnu.org>
13856
13857 * syssignal.h: Replace RETSIGTYPE with void.
13858 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
13859 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
13860 Replace SIGTYPE with void everywhere.
13861 * s/usg5-4-common.h (SIGTYPE): Remove definition.
13862 * s/template.h (SIGTYPE): Remove commented out definition.
13863
e2abce01
JB
138642011-03-26 Eli Zaretskii <eliz@gnu.org>
13865
13866 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
13867 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
13868
f868cd8a
JB
138692011-03-26 Juanma Barranquero <lekktu@gmail.com>
13870
59eb0929
JB
13871 * w32.c (read_unc_volume): Use parameter `henum', instead of
13872 global variable `wget_enum_handle'.
13873
13874 * keymap.c (describe_vector): Remove parameters `indices' and
13875 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
13876 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
13877
f868cd8a
JB
13878 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
13879
13880 * keyboard.c (timer_check): Remove parameter `do_it_now',
13881 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
13882 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
13883 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
13884
13885 * keyboard.c (read_char):
13886 * w32menu.c (w32_menu_display_help):
13887 * xmenu.c (show_help_event, menu_help_callback):
13888 Adjust calls to `show_help_echo'.
13889
13890 * gtkutil.c (xg_maybe_add_timer):
13891 * keyboard.c (readable_events):
13892 * process.c (wait_reading_process_output):
13893 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
13894
13895 * insdel.c (adjust_markers_gap_motion):
13896 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
13897 (gap_left, gap_right): Don't call it.
13898
2ecf6fdb
CY
138992011-03-25 Chong Yidong <cyd@stupidchicken.com>
13900
13901 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
13902 incurred during fontification.
13903
6b1f9ba4
JB
139042011-03-25 Juanma Barranquero <lekktu@gmail.com>
13905
13906 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
13907 (DEFVAR_PER_BUFFER): Don't pass it.
13908
13909 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
13910 (scrolling_window): Don't pass it.
13911
0f4a96b5
JB
139122011-03-25 Juanma Barranquero <lekktu@gmail.com>
13913
13914 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
13915
13916 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
13917 and `suffix'.
13918 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
13919 of variables specific to SELinux and computation of `encoded_absname'.
13920
13921 * image.c (XPutPixel): Remove unused variable `height'.
13922
13923 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
13924
13925 * unexw32.c (get_section_info): Remove unused variable `section'.
13926
13927 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
13928 (system_process_attributes): Remove unused variable `sess'.
13929 (sys_read): Remove unused variable `err'.
13930
13931 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
13932 (w32_wnd_proc): Remove unused variable `isdead'.
13933 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
13934 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
13935 (x_create_tip_frame): Remove unused variable `tem'.
13936
13937 * w32inevt.c (w32_console_read_socket):
13938 Remove unused variable `no_events'.
13939
13940 * w32term.c (x_draw_composite_glyph_string_foreground):
13941 Remove unused variable `width'.
13942
1149507c
JB
139432011-03-24 Juanma Barranquero <lekktu@gmail.com>
13944
13945 * w32term.c (x_set_glyph_string_clipping):
13946 Don't pass uninitialized region to CombineRgn.
13947
9c88f339
JB
139482011-03-23 Juanma Barranquero <lekktu@gmail.com>
13949
13950 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
13951 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
13952 (Fx_close_connection): Remove unused variable `i'.
13953
13954 * w32font.c (w32font_draw): Return number of glyphs.
13955 (w32font_open_internal): Remove unused variable `i'.
13956 (w32font_driver): Add missing initializer.
13957
13958 * w32menu.c (utf8to16): Remove unused variable `utf16'.
13959 (fill_in_menu): Remove unused variable `items_added'.
13960
13961 * w32term.c (last_mouse_press_frame): Remove static global variable.
13962 (w32_clip_to_row): Remove unused variable `f'.
13963 (x_delete_terminal): Remove unused variable `i'.
13964
13965 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
13966 (NOTHING): Remove unused static global variable.
13967 (uniscribe_check_otf): Remove unused variable `table'.
13968 (uniscribe_font_driver): Add missing initializers.
13969
dee091a3
JD
139702011-03-23 Julien Danjou <julien@danjou.info>
13971
13972 * term.c (Fsuspend_tty, Fresume_tty):
13973 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
13974 * window.c (temp_output_buffer_show):
13975 * insdel.c (signal_before_change):
13976 * frame.c (Fhandle_switch_frame):
13977 * fileio.c (Fdo_auto_save):
13978 * emacs.c (Fkill_emacs):
13979 * editfns.c (save_excursion_restore):
13980 * cmds.c (internal_self_insert):
13981 * callint.c (Fcall_interactively):
13982 * buffer.c (Fkill_all_local_variables):
13983 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
13984 Use Frun_hooks.
0f4a96b5 13985 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 13986 unconditionally since it does the check itself.
dee091a3 13987
2c520ab5 139882011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 13989
c9c49752
PE
13990 Fix more problems found by GCC 4.5.2's static checks.
13991
8abc3f12
PE
13992 * coding.c (encode_coding_raw_text): Avoid unnecessary test
13993 the first time through the loop, since we know p0 < p1 then.
13994 This also avoids a gcc -Wstrict-overflow warning.
13995
a2d26660
PE
13996 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
13997 leading to a memory leak, possible in functions like
13998 load_charset_map_from_file that can allocate an unbounded number
b12ef411 13999 of objects (Bug#8318).
a2d26660 14000
916c72e9
PE
14001 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
14002 that could (at least in theory) be that large.
14003
19ab8a18
PE
14004 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
14005 This is less likely to overflow, and avoids undefined behavior if
14006 overflow does occur. All callers changed. Use strtoul to scan
14007 for the unsigned long integer.
b7cbbd6f
PE
14008 (pint2hrstr): Simplify and tune code slightly.
14009 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 14010
f0641eff
PE
14011 * scroll.c (do_scrolling): Work around GCC bug 48228.
14012 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
14013
7f650bb9
PE
14014 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
14015 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
14016 (validate_x_resource_name): Simplify count usage.
14017 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 14018
37dd57d1
PE
14019 * fileio.c (Fcopy_file): Report error if fchown or fchmod
14020 fail (Bug#8306).
81e56e61 14021
699979fc 14022 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 14023
401bf9b4
PE
14024 * process.c (Fmake_network_process): Use socklen_t, not int,
14025 where POSIX says socklen_t is required in portable programs.
14026 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 14027 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
14028 (Fmake_network_process, server_accept_connection):
14029 (wait_reading_process_output, read_process_output):
14030 Likewise.
14031
b93aacde
PE
14032 * process.c: Rename or move locals to avoid shadowing.
14033 (list_processes_1, Fmake_network_process):
14034 (read_process_output_error_handler, exec_sentinel_error_handler):
14035 Rename or move locals.
4dc343ee 14036 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 14037 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 14038 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 14039 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 14040 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 14041
af8a867c 14042 Make tparam.h and terminfo.c consistent.
44f230aa
SM
14043 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
14044 Include tparam.h instead, since it declares them.
af8a867c
PE
14045 * cm.h (PC): Remove extern decl; tparam.h now does this.
14046 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
14047 * terminfo.c: Include tparam.h, to check interfaces.
14048 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
14049 (tparam): Adjust signature to match interface in tparam.h;
14050 this removes some undefined behavior. Check that outstring and len
14051 are zero, which they always are with Emacs.
14052 * tparam.h (PC, BC, UP): New extern decls.
14053
0248044d 14054 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 14055 (xftfont_open): Rename locals to avoid shadowing.
0248044d 14056
8ff096c1 14057 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
14058 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
14059 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 14060 (ftfont_list): Remove unused local.
49eaafba
PE
14061 (get_adstyle_property, ftfont_pattern_entity):
14062 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
14063 Rename locals to avoid shadowing.
8ff096c1 14064
e2be39f6
PE
14065 * xfont.c (xfont_list_family): Mark var as initialized.
14066
c9735e30
PE
14067 * xml.c (make_dom): Now static.
14068
8f5201ae
PE
14069 * composite.c (composition_compute_stop_pos): Rename local to
14070 avoid shadowing.
b246f932
PE
14071 (composition_reseat_it): Remove unused locals.
14072 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 14073 (composition_update_it): Mark var as initialized.
11b61122
PE
14074 (find_automatic_composition): Mark vars as initialized,
14075 with a FIXME (Bug#8290).
8f5201ae 14076
760fbc2c
PE
14077 character.h: Rename locals to avoid shadowing.
14078 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
14079 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
14080 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
14081 (BUF_DEC_POS): Be more systematic about renaming local temporaries
14082 to avoid shadowing.
14083
ff08eb85
PE
14084 * textprop.c (property_change_between_p): Remove; unused.
14085
fc7bf025
PE
14086 * intervals.c (interval_start_pos): Now static.
14087
235d7abc
PE
14088 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
14089
44f230aa
SM
14090 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
14091 Rename locals to avoid shadowing.
3e7d6594 14092
50060332
PE
14093 * sound.c (wav_play, au_play, Fplay_sound_internal):
14094 Fix pointer signedness.
d01f234b 14095 (alsa_choose_format): Remove unused local var.
c83b8872
PE
14096 (wav_play): Initialize a variable to 0, to prevent undefined
14097 behavior (Bug#8278).
50060332 14098
c4fc4e30
PE
14099 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
14100
918436ed
PE
14101 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
14102
c939f91b
PE
14103 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
14104 clobbering (Bug#8298).
b9c7f648
PE
14105 * sysdep.c (sys_subshell): Likewise.
14106 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 14107
6bd8c144
PE
14108 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
14109 This should get cleaned up, so that child_setup has the
14110 same signature on all platforms.
14111
7710357c 14112 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 14113 (relocate_fd): Rename locals to avoid shadowing.
7710357c 14114
c59da222
CY
141152011-03-22 Chong Yidong <cyd@stupidchicken.com>
14116
14117 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
14118 not to be necessary, and produces flickering.
14119
66b87493
GM
141202011-03-20 Glenn Morris <rgm@gnu.org>
14121
14122 * config.in: Remove file.
14123
45b6f6d5
JB
141242011-03-20 Juanma Barranquero <lekktu@gmail.com>
14125
14126 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
14127 are now in src/globals.h.
14128 (syms_of_minibuf): Remove spurious & from previous change.
14129
cd394be1 141302011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
14131
14132 * minibuf.c (completing-read-function): New variable.
14133 (completing-read-default): Rename from completing-read.
14134 (completing-read): Call completing-read-function.
14135
b14e3e21
CY
141362011-03-19 Juanma Barranquero <lekktu@gmail.com>
14137
14138 * xfaces.c (Fx_load_color_file):
14139 Read color file from absolute filename (bug#8250).
14140
f2b726e6
JB
141412011-03-19 Juanma Barranquero <lekktu@gmail.com>
14142
14143 * makefile.w32-in: Update dependencies.
14144
09f6ff02
EZ
141452011-03-17 Eli Zaretskii <eliz@gnu.org>
14146
14147 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
14148
29a6015a
PE
141492011-03-17 Paul Eggert <eggert@cs.ucla.edu>
14150
a3a6c54e
PE
14151 Fix more problems found by GCC 4.5.2's static checks.
14152
b766f867
PE
14153 * process.c (make_serial_process_unwind, send_process_trap):
14154 (sigchld_handler): Now static.
14155
be02381c
PE
14156 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
14157 That way, the code declares only the vars that it needs.
14158 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
14159 * s/cygwin.h (PTY_ITERATION): Likewise.
14160 * s/darwin.h (PTY_ITERATION): Likewise.
14161 * s/gnu-linux.h (PTY_ITERATION): Likewise.
14162
57048744
PE
14163 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
14164 * process.c (allocate_pty): Don't declare stb unless it's needed.
14165
7914961c 14166 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
14167 (CONSTANTLIM): Remove; unused.
14168 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
14169 Define only if needed.
7914961c 14170
b3967b18
PE
14171 * unexelf.c (unexec): Name an expression,
14172 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
14173 Use a different way to cause a compilation error if anyone uses
14174 n rather than nn, a way that does not involve shadowing.
73366a00 14175 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 14176
29a6015a
PE
14177 * deps.mk (unexalpha.o): Remove; unused.
14178
43cfc33e 14179 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 14180 * unexec.h: New file.
ce701a33
PE
14181 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
14182 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
14183 Depend on unexec.h.
14184 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
14185 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
14186 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 14187 Change as necessary to match prototype in unexec.h.
ce701a33 14188
01f44d5a
PE
14189 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
14190 shadowing.
4f63c6bb 14191 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 14192
a6670b0b
PE
14193 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
14194 Rename locals to avoid shadowing.
14195
cef2010d 14196 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 14197 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 14198
d4d7173a
PE
14199 * print.c (Fredirect_debugging_output): Fix pointer signedess.
14200
f08b802a
PE
14201 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
14202 warning when compiling print.c.
14203
3ddb0639
PE
14204 * font.c (font_unparse_fcname): Abort in an "impossible" situation
14205 instead of using an uninitialized var.
5ad03b97 14206 (font_sort_entities): Mark var as initialized.
3ddb0639 14207
170a2692
PE
14208 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
14209
e663c700
PE
14210 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
14211 pointers to constants.
89bc529a 14212 (font_parse_fcname): Remove unused vars.
7b81e2d0 14213 (font_delete_unmatched): Now static.
ea838e10 14214 (font_get_spec): Remove; unused.
13a547c6
PE
14215 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
14216 (font_update_drivers, Ffont_get_glyphs, font_add_log):
14217 Rename or move locals to avoid shadowing.
e663c700 14218
2a80c887 14219 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 14220 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 14221
1384fa33 14222 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 14223 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 14224
8b2c52e9
PE
14225 * alloc.c (mark_backtrace): Move decl from here ...
14226 * lisp.h: ... to here, so that it can be checked.
14227
475545b5 14228 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 14229 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
14230 (lisp_indirect_variable): Name an expression,
14231 to avoid gcc -Wbad-function-cast warning.
1faed8ae 14232 (Fdefvar): Rename locals to avoid shadowing.
475545b5 14233
b1349114 14234 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 14235 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 14236 Use const pointer when appropriate.
b1349114 14237
a2928364
PE
14238 * lisp.h (get_system_name, get_operating_system_release):
14239 Move decls here, to check interfaces.
14240 * process.c (get_operating_system_release): Move decl to lisp.h.
14241 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
14242 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
14243 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
14244 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
14245 (Fformat_time_string, Fencode_time, Finsert_char):
14246 (Ftranslate_region_internal, Fformat):
14247 Rename or remove local vars to avoid shadowing.
9710023e 14248 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 14249
a415e694
PE
14250 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
14251 avoid shadowing.
14252
8ef4622d
PE
14253 * lisp.h (eassert): Check that the argument compiles, even if
14254 ENABLE_CHECKING is not defined.
14255
946f9a5b
PE
14256 * data.c (Findirect_variable): Name an expression, to avoid
14257 gcc -Wbad-function-cast warning.
112396d6 14258 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 14259 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
14260 (Fmake_variable_buffer_local, Fmake_local_variable):
14261 Mark variables as initialized.
52746918 14262 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 14263
e5aab7e7 14264 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
14265 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
14266 Rename locals to avoid shadowing.
dff45157
PE
14267 (mark_stack): Move local variables into the #ifdef region where
14268 they're used.
7bc26fdb
PE
14269 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
14270 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
14271 needed otherwise.
14272 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
14273 (GC_STRING_CHARS): Remove; not used.
d40d4be1 14274 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 14275
e5aab7e7
PE
14276 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
14277 avoids undefined behavior in theory.
14278
4da60324
PE
14279 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
14280
88043301
PE
14281 Use functions, not macros, for up- and down-casing (Bug#8254).
14282 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14283 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
14284 to use the following functions instead of these macros.
14285 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
14286 EMACS_INT, since callers assume the returned value fits in int.
14287 (upcase1): Likewise, for UPCASE_TABLE.
14288 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 14289 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 14290 the race-condition problem in the old DOWNCASE.
88043301 14291
19ed5445
PE
14292 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
14293 Rename locals to avoid shadowing.
14294 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
14295 (regex_compile, re_search_2, re_match_2_internal):
14296 Remove unused local vars.
952db0d7
PE
14297 (FREE_VAR): Rewrite so as not to use empty "else",
14298 which gcc can warn about.
da053e48 14299 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
14300 (RETALLOC_IF): Define only if needed.
14301 (WORDCHAR_P): Likewise. This one is never needed, but is used
14302 only in a comment talking about a compiler bug, so put inside
14303 the #if 0 of that comment.
14304 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
14305 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
14306 Remove; unused.
19ed5445 14307
1f3561e4 14308 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
14309 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
14310 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 14311
ded6f8f7
PE
14312 * search.c (simple_search): Remove unused var.
14313
dbd37a95
PE
14314 * dired.c (compile_pattern): Move decl from here ...
14315 * lisp.h: ... to here, so that it can be checked.
14316 (struct re_registers): New forward decl.
14317
7e47afad
PE
14318 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
14319
85f24f61
PE
14320 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
14321 All uses changed.
14322 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
14323 Rename locals to avoid shadowing.
5671df8f 14324 (Fvertical_motion): Mark locals as initialized.
85f24f61 14325
181aa2be 14326 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 14327 (casify_region): Mark local as initialized.
181aa2be 14328
930d429c
PE
14329 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
14330
7082eac6
PE
14331 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
14332 New macros, so that the caller can use some names other than
14333 gcpro1, gcpro2, etc.
14334 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
14335 of the new macros.
14336 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
14337 argument, for consistency with GCPRO2_VAR, etc: it is now the
14338 prefix of the variable, not the variable itself. All uses
14339 changed.
38b2c076
PE
14340 * dired.c (directory_files_internal, file_name_completion):
14341 Rename locals to avoid shadowing.
14342
15206ed9
PE
14343 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
14344 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
14345 dired.c's scmp function, had undefined behavior.
14346 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14347 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
14348 * buffer.h: ... to here, because these macros use current_buffer,
14349 and the new implementation with inline functions needs to have
14350 current_buffer in scope now, rather than later when the macros
14351 are used.
14352 (downcase, upcase1): New static inline functions.
14353 (DOWNCASE, UPCASE1): Reimplement using these functions.
14354 This avoids undefined behavior in expressions like
14355 DOWNCASE (x) == DOWNCASE (y), which previously suffered
14356 from race conditions in accessing the global variables
14357 case_temp1 and case_temp2.
14358 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
14359 * lisp.h (case_temp1, case_temp2): Remove their decls.
14360 * character.h (ASCII_CHAR_P): Move from here ...
14361 * lisp.h: ... to here, so that the inline functions mentioned
14362 above can use them.
14363
4a6bea26
PE
14364 * dired.c (directory_files_internal_unwind): Now static.
14365
f14b7e14
PE
14366 * fileio.c (file_name_as_directory, directory_file_name):
14367 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
14368 Now static.
2893f146
PE
14369 (file_name_as_directory): Use const pointers when appropriate.
14370 (Fexpand_file_name): Likewise. In particular, newdir might
14371 point at constant storage, so make it a const pointer.
fd4ead52 14372 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
14373 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
14374 signedness issues.
f839df0c
PE
14375 (Fset_file_times, Finsert_file_contents, auto_save_error):
14376 Rename locals to avoid shadowing.
f14b7e14 14377
5716756e 14378 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
14379 (Ftry_completion, Fall_completions): Rename or remove locals
14380 to avoid shadowing.
5716756e 14381
b4c3046a
PE
14382 * marker.c (bytepos_to_charpos): Remove; unused.
14383
b45db522
PE
14384 * lisp.h (verify_bytepos, count_markers): New decls,
14385 so that gcc does not warn that these functions aren't declared.
14386
85876d07
PE
14387 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
14388 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 14389 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 14390 (copy_text): Remove unused local var.
85876d07 14391
03d78a21 14392 * filelock.c (within_one_second): Now static.
b3dd38ab 14393 (lock_file_1): Rename local to avoid shadowing.
03d78a21 14394
5df8f01b
PE
14395 * buffer.c (fix_overlays_before): Mark locals as initialized.
14396 (fix_start_end_in_overlays): Likewise. This function should be
14397 simplified by using pointers-to-pointers, but that's a different
14398 matter.
b1d876f1 14399 (switch_to_buffer_1): Now static.
8f54f30a
PE
14400 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
14401 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 14402
a70072c9 14403 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 14404 Fix pointer signedness issue.
edced198
PE
14405 (sys_subshell): Mark local as volatile if checking for lint,
14406 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 14407 (MAXPATHLEN): Define only if needed.
a70072c9 14408
a0977c44
PE
14409 * process.c (serial_open, serial_configure): Move decls from here ...
14410 * systty.h: ... to here, so that they can be checked.
14411
a884fdcc
PE
14412 * fns.c (get_random, seed_random): Move extern decls from here ...
14413 * lisp.h: ... to here, so that they can be checked.
14414
604efe86 14415 * sysdep.c (reset_io): Now static.
b8950c94 14416 (wait_for_termination_signal): Remove; unused.
604efe86 14417
38fc62d9
PE
14418 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
14419 (copy_keymap_item, append_key, push_text_char_description):
14420 Now static.
1004a21a 14421 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 14422 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
14423 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
14424 (describe_map_tree):
14425 Rename locals to avoid shadowing.
38fc62d9 14426
2f2650da
PE
14427 * keyboard.c: Declare functions static if they are not used elsewhere.
14428 (echo_char, echo_dash, cmd_error, top_level_2):
14429 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
14430 (read_char, kbd_buffer_get_event, make_lispy_position):
14431 (make_lispy_event, make_lispy_movement, apply_modifiers):
14432 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
14433 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
14434 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 14435 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 14436 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 14437
a053e86c 14438 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
14439 (mark_kboards): Move decl here ...
14440 * alloc.c (mark_kboards): ... from here.
a053e86c 14441
4752793e
PE
14442 * lisp.h (force_auto_save_soon): New decl.
14443
74f10ca7 14444 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
14445 (DEFINE_DUMMY_FUNCTION): New macro.
14446 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
14447 Use it.
c03cd23f
PE
14448 (main): Add casts to avoid warnings
14449 if GCC considers string literals to be constants.
74f10ca7 14450
022e70d4
PE
14451 * lisp.h (fatal_error_signal): Add decl, since it's exported.
14452
59d6fe83
PE
14453 * dbusbind.c: Pointer signedness fixes.
14454 (xd_signature, xd_append_arg, xd_initialize):
14455 (Fdbus_call_method, Fdbus_call_method_asynchronously):
14456 (Fdbus_method_return_internal, Fdbus_method_error_internal):
14457 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
14458 (Fdbus_register_signal): Use SSDATA when the context wants char *.
14459
78320123
PE
14460 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
14461 if GCC considers string literals to be constants.
49cebcca 14462 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 14463
35ac2a97
SM
144642011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
14465
fb103ca9
SM
14466 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
14467 (print_preprocess, print_object): New macro to fix last change.
14468
35ac2a97
SM
14469 * print.c (print_preprocess): Don't forget font objects.
14470
62973b41
JB
144712011-03-16 Juanma Barranquero <lekktu@gmail.com>
14472
14473 * emacs.c (USAGE3): Doc fixes.
14474
0e48bb22
AS
144752011-03-15 Andreas Schwab <schwab@linux-m68k.org>
14476
14477 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
14478 structure.
14479
7684e57b
JB
144802011-03-14 Juanma Barranquero <lekktu@gmail.com>
14481
14482 * lisp.h (VWindow_system, Qfile_name_history):
14483 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
14484 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
14485 (w32_system_caret_x, w32_system_caret_y): Declare extern.
14486
14487 * w32select.c: Don't #include "keyboard.h".
c96bbc66 14488 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
14489
14490 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
14491 * w32console.c (detect_input_pending, read_input_pending)
14492 (encode_terminal_code):
14493 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
14494 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
14495 (w32_system_caret_y, Qfile_name_history):
14496 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
14497 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
14498 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
14499 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
14500 * w32proc.c (Qlocal, report_file_error):
14501 * w32term.c (Vwindow_system, updating_frame):
14502 * w32uniscribe.c (initialized, uniscribe_font_driver):
14503 Remove unneeded extern declarations.
14504
2aa46d6c
CY
145052011-03-14 Chong Yidong <cyd@stupidchicken.com>
14506
c96bbc66 14507 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 14508
cffc6f3b
CY
145092011-03-13 Chong Yidong <cyd@stupidchicken.com>
14510
14511 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
14512 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
14513 These macros can no longer be used for assignment.
14514
44f230aa
SM
14515 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
14516 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
14517 (record_buffer_markers, fetch_buffer_markers): New functions for
14518 recording and fetching special buffer markers.
14519 (set_buffer_internal_1, set_buffer_temp): Use them.
14520
14521 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
14522
14523 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
14524
14525 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
14526 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
14527
14528 * xdisp.c (hscroll_window_tree):
14529 (reconsider_clip_changes): Use PT instead of BUF_PT.
14530
d251f04b
EZ
145312011-03-13 Eli Zaretskii <eliz@gnu.org>
14532
14533 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
14534 $(EMACS_ROOT)/lib/intprops.h.
14535
f0c77cd1
PE
145362011-03-13 Paul Eggert <eggert@cs.ucla.edu>
14537
3eca4629
PE
14538 Fix more problems found by GCC 4.5.2's static checks.
14539
7c86ee98
PE
14540 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
14541 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
14542 (xg_free_frame_widgets): Make it clear that a local variable is
14543 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
14544 (gdk_window_get_screen): Make it clear that this macro is needed
14545 only if USE_GTK_TOOLTIP.
1e5524e7
PE
14546 (int_gtk_range_get_value): New function, which avoids a diagnostic
14547 from gcc -Wbad-function-cast.
14548 (xg_set_toolkit_scroll_bar_thumb): Use it.
14549 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
14550 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
14551 (get_utf8_string, xg_get_file_with_chooser):
14552 Rename locals to avoid shadowing.
14553 (create_dialog): Move locals to avoid shadowing.
7c86ee98 14554
41729b81
PE
14555 * xgselect.c (xg_select): Remove unused var.
14556
f0c77cd1
PE
14557 * image.c (four_corners_best): Mark locals as initialized.
14558 (gif_load): Initialize transparent_p to zero (Bug#8238).
14559 Mark another local as initialized.
ec6cf4c6 14560 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 14561
ce0ad53d 14562 * image.c (clear_image_cache): Now static.
d5d5a617 14563 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 14564 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
14565 (x_edge_detection): Remove unnecessary cast that
14566 gcc -Wbad-function-cast diagnoses.
2037898d 14567 (gif_load): Fix pointer signedness.
6ae141d6
PE
14568 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
14569 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 14570
33383987 145712011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 14572
d32df629
PE
14573 Improve quality of tests for time stamp overflow.
14574 For example, without this patch (encode-time 0 0 0 1 1
14575 1152921504606846976) returns the obviously-bogus value (-948597
14576 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
14577 reports time overflow. See
14578 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
14579 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
14580 * editfns.c: Include limits.h and intprops.h.
14581 (TIME_T_MIN, TIME_T_MAX): New macros.
14582 (time_overflow): Move earlier, to before first use.
14583 (hi_time, lo_time): New functions, for an accurate test for
14584 out-of-range times.
14585 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
14586 (Fget_internal_run_time): Don't assume time_t fits in int.
14587 (make_time): Use list2 instead of Fcons twice.
14588 (Fdecode_time): More accurate test for out-of-range times.
14589 (check_tm_member): New function.
14590 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
14591 (lisp_time_argument): Don't rely on undefined left-shift and
14592 right-shift behavior when checking for time stamp overflow.
8be6f318 14593
fe31d94c
PE
14594 * editfns.c (time_overflow): New function, refactoring common code.
14595 (Fformat_time_string, Fdecode_time, Fencode_time):
14596 (Fcurrent_time_string): Use it.
14597
8be6f318
PE
14598 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
14599 * dired.c (make_time): Move to ...
14600 * editfns.c (make_time): ... here.
14601 * systime.h: Note the move.
14602
09d9db2c 146032011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 14604
126bc0dc
YM
14605 * fringe.c (update_window_fringes): Remove unused variables.
14606
c47cbdfd
YM
14607 * unexmacosx.c (copy_data_segment): Also copy __got section.
14608 (Bug#8223)
14609
7ac80be9
EZ
146102011-03-12 Eli Zaretskii <eliz@gnu.org>
14611
c96bbc66 14612 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
14613 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
14614 Constify `char *' arguments and their references according to
14615 prototypes in tparam.h.
14616
ecb0f94d 14617 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 14618
7ac80be9
EZ
14619 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
14620 Adapt all references accordingly.
14621
14622 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
14623
ef1fd07e
TT
146242011-03-11 Tom Tromey <tromey@redhat.com>
14625
14626 * buffer.c (syms_of_buffer): Remove obsolete comment.
14627
7ef4b50c
EZ
146282011-03-11 Eli Zaretskii <eliz@gnu.org>
14629
14630 * termhooks.h (encode_terminal_code): Declare prototype.
14631
14632 * msdos.c (encode_terminal_code): Don't declare prototype.
14633
14634 * term.c (encode_terminal_code): Now external again, used by
14635 w32console.c and msdos.c.
14636
44f230aa
SM
14637 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
14638 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 14639
4b1ec863 146402011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 14641
1714f52b 14642 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 14643
4b1ec863
PE
14644 * fringe.c (update_window_fringes): Mark locals as initialized
14645 (Bug#8227).
14646 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 14647
524c7aa6
PE
14648 * alloc.c (mark_fringe_data): Move decl from here ...
14649 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
14650 to check its interface.
14651 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
14652
a5c0af81 14653 * fontset.c (free_realized_fontset): Now static.
7519b8cd 14654 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 14655 (fontset_font): Mark local as initialized.
a9a06e0b 14656 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 14657
b4716021
PE
14658 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
14659
811e9bac 14660 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 14661 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
14662 (x_own_selection, Fx_disown_selection_internal): Rename locals
14663 to avoid shadowing.
14664 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 14665
7e3ab302
PE
14666 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
14667 so that the caller can use some name other than gcpro1.
14668 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
14669 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14670 (Fx_backspace_delete_keys_p):
14671 Use them to avoid shadowing, and rename vars to avoid shadowing.
14672 (x_decode_color, x_set_name, x_window): Now static.
6b437900 14673 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 14674 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
14675 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
14676 Remove unused locals.
7e3ab302
PE
14677 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14678 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
14679 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
14680 macros.
f78faa98 14681
e2b13473
PE
14682 * xterm.h (x_mouse_leave): New decl.
14683
77f23912
PE
14684 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
14685 Remove unused functions.
cdf4ba58
PE
14686 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
14687 (x_calc_absolute_position): Now static.
7411c686 14688 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 14689 Don't declare local "event" unless it's used.
ed7bf3a5
PE
14690 (x_iconify_frame, x_free_frame_resources): Don't declare locals
14691 unless they are used.
38d0b34a
PE
14692 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
14693 (x_fatal_error_signal): Remove; not used.
a6067996
PE
14694 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
14695 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
14696 (x_error_catcher, x_connection_closed, x_error_handler):
14697 (x_error_quitter, xembed_send_message, x_iconify_frame):
14698 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 14699 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 14700 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 14701
44f230aa
SM
14702 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
14703 Rename or move locals to avoid shadowing.
6b463e58 14704 (tty_defined_color, merge_face_heights): Now static.
5967d051 14705 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
14706 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
14707 does not deduce is never used uninitialized.
73719eba
PE
14708 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
14709 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 14710
426994c3 14711 * terminal.c (store_terminal_param): Now static.
5489860b 14712
032f1620 14713 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 14714 (set_frame_menubar): Remove unused local.
d4323972 14715 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
14716 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
14717 since they might point to immutable storage.
281585b0
PE
14718 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
14719 since it's unused otherwise.
032f1620 14720
367c19e5 14721 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 14722 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
14723 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
14724 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 14725 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
14726 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
14727 does not deduce are never used uninitialized.
70739cbe 14728
07b48fa9
PE
14729 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
14730
8868a238 14731 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
14732 * window.c (window_loop, size_window):
14733 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 14734
7e5cf297 14735 * window.c (display_buffer): Now static.
d6550a9f
PE
14736 (size_window): Mark variables that gcc -Wuninitialized
14737 does not deduce are never used uninitialized.
a586633d
PE
14738 * window.h (check_all_windows): New decl, to forestall
14739 gcc -Wmissing-prototypes diagnostic.
5b555da1 14740 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 14741
f6095868
PE
14742 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
14743 shadowing.
14744 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
14745 Include <limits.h>.
14746 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
14747 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
14748 (load_charset_map): Mark variables that gcc -Wuninitialized
14749 does not deduce are never used uninitialized.
53df7c11 14750 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 14751
f38b440c
PE
14752 * coding.c (coding_set_source, coding_set_destination):
14753 Use "else { /* comment */ }" rather than "else /* comment */;"
14754 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
14755 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
14756 a block, when the outer 'i' will do.
14757 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
14758 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
14759 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
14760 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
14761 (Fdecode_sjis_char, Fdefine_coding_system_internal):
14762 Rename locals to avoid shadowing.
14763 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
14764 * coding.c (emacs_mule_char, encode_invocation_designation):
14765 Now static, since they're not used elsewhere.
413bb2db 14766 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 14767 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
14768 (decode_coding_emacs_mule): Mark variables that gcc
14769 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
14770 (detect_coding_iso_2022): Initialize a local variable that might
14771 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 14772 this initialization is needed. (Bug#8211)
5f58e762
PE
14773 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
14774 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
14775 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
14776 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
14777 Remove unused macros.
f38b440c 14778
232b38b9 14779 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 14780 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 14781 * character.c (string_count_byte8): Likewise.
232b38b9 14782
fb90da1b
PE
14783 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
14784 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
14785
fb93dbc2
PE
14786 * chartab.c (copy_sub_char_table): Now static, since it's not used
14787 elsewhere.
5c156ace
PE
14788 (sub_char_table_ref_and_range, char_table_ref_and_range):
14789 Rename locals to avoid shadowing.
bbcd0949 14790 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 14791
7d3b3862 14792 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 14793 (BIDI_BOB): Remove unused macro.
7d3b3862 14794
6be7d3da
PE
14795 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
14796 deduce are never used uninitialized.
c2ed9c8b 14797 * term.c (encode_terminal_code): Likewise.
6be7d3da 14798
75f8807f 14799 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 14800
50938595
PE
14801 * tparam.h: New file.
14802 * term.c, tparam.h: Include it.
14803 * deps.mk (term.o, tparam.o): Depend on tparam.h.
14804 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
14805 Move these decls to tparam.h, and make them agree with what
14806 is actually in tparam.c. The previous trick of using incompatible
14807 decls in different modules does not conform to the C standard.
14808 All callers of tparam changed to use tparam's actual API.
14809 * tparam.c (tparam1, tparam, tgoto):
14810 Use const pointers where appropriate.
14811
fbceeba2
PE
14812 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
14813 * cm.h (struct cm): Likewise.
14814 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
14815 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
14816 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
14817 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
14818 (turn_on_face, init_tty): Likewise.
14819 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 14820
7f3f1250
PE
14821 * term.c (term_mouse_position): Rename local to avoid shadowing.
14822
e6ca6543
PE
14823 * alloc.c (mark_ttys): Move decl from here ...
14824 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
14825
c40f8d15
AS
148262011-03-11 Andreas Schwab <schwab@linux-m68k.org>
14827
14828 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
14829
cfe0661d
JB
148302011-03-09 Juanma Barranquero <lekktu@gmail.com>
14831
14832 * search.c (compile_pattern_1): Remove argument regp, unused since
14833 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
14834 (compile_pattern): Don't pass it.
14835
0afb4571
J
148362011-03-08 Jan Djärv <jan.h.d@swipnet.se>
14837
14838 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
14839 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
14840 for ! HAVE_GTK3.
14841 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
14842
14843 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
14844
14845 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
14846 gdk_window_get_screen, gdk_window_get_geometry,
14847 gdk_x11_window_lookup_for_display and GDK_KEY_g.
14848 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
14849 (xg_get_pixbuf_from_pixmap): New function.
14850 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
14851 to Pixmap, take frame as parameter, remove GdkColormap parameter.
14852 Call xg_get_pixbuf_from_pixmap instead of
14853 gdk_pixbuf_get_from_drawable.
14854 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
14855 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
14856 (xg_check_special_colors): Use GtkStyleContext and its functions
14857 for HAVE_GTK3.
14858 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
14859 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
14860 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
14861 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
14862 Call gtk_widget_get_preferred_size.
0afb4571
J
14863 (xg_frame_resized): gdk_window_get_geometry only takes 5
14864 parameters.
44f230aa
SM
14865 (xg_win_to_widget, xg_event_is_for_menubar):
14866 Call gdk_x11_window_lookup_for_display.
0afb4571
J
14867 (xg_set_widget_bg): New function.
14868 (delete_cb): New function.
895009e1 14869 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 14870 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
14871 (xg_set_background_color): Call xg_set_widget_bg.
14872 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
14873 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
14874 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
14875 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
14876 if ! HAVE_GTK3.
14877 (update_frame_tool_bar): Call gtk_widget_hide.
14878 (xg_initialize): Use GDK_KEY_g.
14879
14880 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
14881 if ! HAVE_GTK3
14882 (x_session_initialize): Call gdk_x11_set_sm_client_id.
14883
14884 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
14885 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
14886 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
14887
1c2cc4ef
JB
148882011-03-08 Juanma Barranquero <lekktu@gmail.com>
14889
14890 * w32xfns.c (select_palette): Check success of RealizePalette against
14891 GDI_ERROR, not zero.
14892
33383987 14893See ChangeLog.11 for earlier changes.
aac0c6e3
MR
14894
14895;; Local Variables:
14896;; coding: utf-8
aac0c6e3
MR
14897;; End:
14898
2f097256 14899 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
14900
14901 This file is part of GNU Emacs.
14902
14903 GNU Emacs is free software: you can redistribute it and/or modify
14904 it under the terms of the GNU General Public License as published by
14905 the Free Software Foundation, either version 3 of the License, or
14906 (at your option) any later version.
14907
14908 GNU Emacs is distributed in the hope that it will be useful,
14909 but WITHOUT ANY WARRANTY; without even the implied warranty of
14910 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14911 GNU General Public License for more details.
14912
14913 You should have received a copy of the GNU General Public License
14914 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.