* lisp/minibuffer.el (completion-table-with-quoting): Fix compatibility
[bpt/emacs.git] / src / ChangeLog
CommitLineData
4737362e
GM
12012-05-01 Glenn Morris <rgm@gnu.org>
2
4d5c6349
GM
3 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
4 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
5
4737362e
GM
6 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
7
74dd3a6b
AS
82012-04-30 Andreas Schwab <schwab@linux-m68k.org>
9
10 * .gdbinit (xpr): Remove checks for no longer existing misc types.
11 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
12 Remove.
13
13c379ee
PE
142012-04-28 Paul Eggert <eggert@cs.ucla.edu>
15
16 Do not avoid creating empty evaporating overlays (Bug#9642).
17 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
18 That is, do not delete an evaporating overlay if it becomes
19 empty after its bounds are adjusted to fit within its buffer.
20 This fix caused other problems, and I'm reverting it until we get
21 to the bottom of them.
22
a8e7d6d7 232012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
24
25 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
26
a8e7d6d7 272012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
28
29 * xdisp.c (pos_visible_p): If the window start position is beyond
30 ZV, start the display from buffer beginning. Prevents assertion
31 violation in init_iterator when the minibuffer window is scrolled
32 via the scroll bar.
33
34 * window.c (window_scroll_pixel_based): Likewise.
35
a8e7d6d7 362012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
37
38 * keymap.c (where_is_internal): Doc fix (Bug#10872).
39
a8e7d6d7 402012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
41
42 * fileio.c (Fcopy_file, Fset_file_selinux_context):
43 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
44
a8e7d6d7 452012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685
EZ
46
47 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers): Don't
48 overrun array limits of glyph row's used[] array. (Bug#11288)
49
1c6900d9
EZ
502012-04-26 Eli Zaretskii <eliz@gnu.org>
51
4c3fa1d9
EZ
52 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
53 display element, check also the underlying string or buffer
54 character. (Bug#11341)
55
1c6900d9
EZ
56 * w32menu.c: Include w32heap.h.
57 (add_menu_item): If the call to AppendMenuW (via
58 unicode_append_menu) fails, disable Unicode menus only if we are
59 running on Windows 9X/Me.
60
42bf8205
AS
612012-04-24 Andreas Schwab <schwab@linux-m68k.org>
62
63 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
64 (xgetint): Add missing shift for LSB tags.
65
b1bac16e
MR
662012-04-24 Martin Rudalics <rudalics@gmx.at>
67
68 * keyboard.c (read_char): Don't wipe echo area for select window
69 events: These might get delayed via `mouse-autoselect-window'
70 (Bug#11304).
71
d69621cc
JB
722012-04-24 Juanma Barranquero <lekktu@gmail.com>
73
74 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
75 manipulation of :loaded-from data.
76
02fd101b
JB
772012-04-23 Juanma Barranquero <lekktu@gmail.com>
78
79 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
80 now a cons (bug#11311).
81
888bec30
PE
822012-04-23 Paul Eggert <eggert@cs.ucla.edu>
83
89a438bd
PE
84 Do not create empty overlays with the evaporate property (Bug#9642).
85 * buffer.c (Fmove_overlay): Delete an evaporating overlay
86 if it becomes empty after its bounds are adjusted to fit within
87 its buffer. Without this fix, in a nonempty buffer (let ((o
88 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
89 yields an empty overlay that has the evaporate property, which is
90 not supposed to happen.
91
1068fe4d
PE
92 Fix minor GTK3 problems found by static checking.
93 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
94 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
95 (struct _EmacsFixedClass, emacs_fixed_get_type):
96 Move decls here from emacsgtkfixed.h, since they needn't be public.
97 (emacs_fixed_get_type): Now static.
98 (emacs_fixed_class_init): Omit unused local.
99 (emacs_fixed_child_type): Remove; unused.
100 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
101 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
102 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
103 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
104 (EMACS_FIXED_GET_CLASS): Remove; unused.
105 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
106
888bec30
PE
107 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
108 Problem reported by Juanma Barranquero for Windows -Wunused-function.
109
de85e130
PE
1102012-04-22 Paul Eggert <eggert@cs.ucla.edu>
111
d0baac98
PE
112 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
113 * gmalloc.c: (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
114 (__malloc_size_t, __malloc_ptrdiff_t):
115 Remove. All uses removed, replaced by the definiens if needed,
116 since we can assume C89 or better now.
117 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
118 (protect_malloc_state, align, get_contiguous_space)
119 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
120 (malloc_atfork_handler_child, malloc_enable_thread)
121 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
122 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
123 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
124 (special_realloc, _realloc_internal_nolock, _realloc_internal)
125 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
126 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
127 Define using prototypes, not old style.
128 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
129 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
130 (align): Don't assume that signed integer overflow wraps around.
131 Omit unused local var.
132 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
133 (_free_internal_nolock, memalign, mallochook, reallochook):
134 Omit no-longer-needed casts.
135 (valloc): Use getpagesize, not __getpagesize.
136 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
137 (struct hdr): The 'magic' member is now size_t, not unsigned long.
138
de85e130
PE
139 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
140
dcbf5805
MA
1412012-04-22 Michael Albinus <michael.albinus@gmx.de>
142
143 Move functions from C to Lisp. Make non-blocking method calls
144 the default. Implement further D-Bus standard interfaces.
145
146 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
147 (QCdbus_request_name_allow_replacement)
148 (QCdbus_request_name_replace_existing)
149 (QCdbus_request_name_do_not_queue)
150 (QCdbus_request_name_reply_primary_owner)
151 (QCdbus_request_name_reply_in_queue)
152 (QCdbus_request_name_reply_exists)
153 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
154 (QCdbus_registered_serial, QCdbus_registered_method)
155 (QCdbus_registered_signal): New Lisp objects.
156 (XD_DEBUG_MESSAGE): Use sizeof.
157 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
158 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
159 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
160 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
161 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
162 (xd_signature, xd_append_arg): Allow float for integer types.
163 (xd_get_connection_references): New function.
164 (xd_get_connection_address): Rename from xd_initialize. Return
165 cached address.
166 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
167 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
168 level.
169 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
170 Return number of recounts.
171 (Fdbus_get_unique_name): Make stronger parameter check.
172 (Fdbus_message_internal): New defun.
173 (Fdbus_call_method, Fdbus_call_method_asynchronously)
174 (Fdbus_method_return_internal, Fdbus_method_error_internal)
175 (Fdbus_send_signal, Fdbus_register_service)
176 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
177 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
178 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
179 (Vdbus_compiled_version, Vdbus_runtime_version)
180 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
181 (Vdbus_message_type_method_return, Vdbus_message_type_error)
182 (Vdbus_message_type_signal): New defvars.
183 (Vdbus_registered_buses, Vdbus_registered_objects_table): Adapt
184 docstring.
185
52828e02
PE
1862012-04-22 Paul Eggert <eggert@cs.ucla.edu>
187
da05bc4c
PE
188 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
189 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
190 Do not assume ptrdiff_t is the same width as 'int'.
191
52828e02
PE
192 * alloc.c: Handle unusual debugging option combinations.
193 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
194 since the two debugging options are incompatible.
195 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
196 is defined.
197 (mem_init, mem_insert, mem_insert_fixup):
198 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
199 (NEED_MEM_INSERT): Remove; no longer needed.
200
f01769f9
LL
2012012-04-22 Leo Liu <sdl.web@gmail.com>
202
203 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
204
5790543d
PE
2052012-04-22 Paul Eggert <eggert@cs.ucla.edu>
206
207 * sysdep.c [__FreeBSD__]: Minor cleanups.
208 (list_system_processes, system_process_attributes) [__FreeBSD__]:
209 Use Emacs indenting style more consistently. Avoid some casts.
210 Use 'double' consistently rather than mixing 'float' and 'double'.
211
b91b7e4d
EW
2122012-04-21 Eduard Wiebe <usenet@pusto.de>
213
214 * sysdep.c (list_system_processes, system_process_attributes): Add
215 implementation for FreeBSD (Bug#5243).
216
6114eb15
AS
2172012-04-21 Andreas Schwab <schwab@linux-m68k.org>
218
219 * lisp.mk (lisp): Update.
220
2f38dff7
PE
2212012-04-20 Paul Eggert <eggert@cs.ucla.edu>
222
223 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
224 It is never used otherwise.
225
4ae29f89
SM
2262012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
227
228 * print.c (print_preprocess): Only check print_depth if print-circle
229 is nil.
230 (print_object): Check for cycles even when print-circle is nil and
231 print-gensym is t, but only check print_depth if print-circle is nil.
232
f30d612a
CY
2332012-04-20 Chong Yidong <cyd@gnu.org>
234
235 * process.c (wait_reading_process_output): If EIO occurs on a pty,
236 set the status to "failed" and ensure that sentinel is run.
237
c07a4c0b 2382012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
239
240 * process.c (Fset_process_inherit_coding_system_flag)
241 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 242 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 243
c07a4c0b 2442012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
245
246 * xdisp.c (string_buffer_position_lim): Limit starting position to
247 BEGV.
248 (set_cursor_from_row): If called for a mode-line or header-line
249 row, return zero immediately.
250 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
251 farther than the first row after the header line, if any.
252 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
253 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
254
c07a4c0b 2552012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 256
4ae29f89
SM
257 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
258 (bug#11238).
ad3a2b41 259
c07a4c0b 2602012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 2612012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
262
263 configure: new option --enable-gcc-warnings (Bug#11207)
264 * Makefile.in (C_WARNINGS_SWITCH): Remove.
265 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
266 (ALL_CFLAGS): Use new macros rather than old.
267 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
268 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
269 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
270 -Wunused-result, -Wunused-variable. This should go away once
271 the Emacs and Gnulib regex code is merged.
272 (xmalloc, xrealloc): Now static.
273
aba027e8
PE
2742012-04-17 Paul Eggert <eggert@cs.ucla.edu>
275
276 * dired.c (Fsystem_groups): Remove unused local.
277
e5a36063
GM
2782012-04-17 Glenn Morris <rgm@gnu.org>
279
280 * dired.c (Fsystem_users): Doc fix.
281
316411f0
DA
2822012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
283
284 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
285 (syms_of_dired): Add them.
286
9426aba4
PE
2872012-04-16 Paul Eggert <eggert@cs.ucla.edu>
288
b62a57be
PE
289 Fix minor alloc.c problems found by static checking.
290 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
291 New extern decls, to avoid calling undeclared functions.
292 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
293 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
294 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
295 (NEED_MEM_INSERT): New macro.
296 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 297 Remove one incorrect comment and fix another.
b62a57be 298
3539f31f
PE
299 Fix minor ralloc.c problems found by static checking.
300 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
301 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
302 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
303 (r_alloc_sbrk): Now static.
304
a041960a
PE
305 Improve ralloc.c interface checking.
306 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
307 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
308 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
309 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
310 [REL_ALLOC]: ... to here, to check interface.
311 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
312 Remove decls. This fixes an "It stinks!".
313
9426aba4
PE
314 * alloc.c (which_symbols): Fix alignment issue / type clash.
315
d55c12ed
AS
3162012-04-15 Andreas Schwab <schwab@linux-m68k.org>
317
318 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
319 (struct Lisp_Misc_Any): Likewise.
320 (struct Lisp_Free): Likewise.
321 * alloc.c (union aligned_Lisp_Symbol): Define.
322 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
323 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
324 (union aligned_Lisp_Misc): Define.
325 (MARKER_BLOCK_SIZE, struct marker_block): Use union
326 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 327 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 328
b948ce8b
PE
3292012-04-14 Paul Eggert <eggert@cs.ucla.edu>
330
331 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
332 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
333 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
334 * s/netbsd.h, s/sol2-6.h:
335 Remove definition of GC_MARK_STACK, since the default now works.
336 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
337 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
338 no longer the default.
339 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
340
35dc09a1 3412012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 342
35dc09a1
GM
343 * lread.c (lisp_file_lexically_bound_p):
344 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 345
35dc09a1
GM
3462012-04-14 Eli Zaretskii <eliz@gnu.org>
347
348 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
349 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
350
3512012-04-14 Jan Djärv <jan.h.d@swipnet.se>
352
353 * nsterm.m (constrainFrameRect): Always constrain when there is only
354 one screen (Bug#10962).
355
bcd86815
KB
3562012-04-13 Ken Brown <kbrown@cornell.edu>
357
358 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
359
c25df26e
RT
3602012-04-13 Reuben Thomas <rrt@sc3d.org>
361
362 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
363
0fc59f1e
DC
3642012-04-11 Daniel Colascione <dancol@dancol.org>
365
366 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
367 against is gone. It's better to use vfork now so that when Cygwin
368 gains a new, working vfork, we use it automatically (bug#10398).
369
de8c03dc
SM
3702012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
371
372 * window.c (save_window_save): Obey window-point-insertion-type.
373
2f097256
GM
3742012-04-11 Glenn Morris <rgm@gnu.org>
375
376 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
377
453b951e
SM
3782012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
379
380 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
381
75f1671a 3822012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
383
384 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
385 (force_quit_count): New var.
386 (handle_interrupt): Use it.
387
2a8ce227
JB
3882012-04-10 Juanma Barranquero <lekktu@gmail.com>
389
390 * w32.c (w32_delayed_load): Record the full path of the library
391 being loaded (bug#10424).
392
935396c0
GM
3932012-04-09 Glenn Morris <rgm@gnu.org>
394
05920a43
GM
395 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
396 not just in the obarray, before snarfing them. (Bug#11036)
397
935396c0
GM
398 * Makefile.in ($(leimdir)/leim-list.el):
399 Pass EMACS rather than BUILT_EMACS.
400
a18ecafa
TZ
4012012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
402
403 * process.c (make_process):
404 * process.h: Add integer `gnutls_handshakes_tried' member to
405 process struct.
406
6bbef4e5
JC
407 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
408 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
409
410 * gnutls.c (gnutls_log_function2i): Convenience log function.
411 (emacs_gnutls_read): Use new log functions,
412 `gnutls_handshakes_tried' process member, and
413 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
414 attempts per process (connection).
415
b4d3bc10
CY
4162012-04-09 Chong Yidong <cyd@gnu.org>
417
418 * eval.c (Fuser_variable_p, user_variable_p_eh)
419 (lisp_indirect_variable): Functions deleted.
420 (Fdefvar): Caller changed.
421
422 * callint.c (Finteractive, Fcall_interactively):
423 * minibuf.c (Fread_variable): Callers changed.
424
70f4d973
EZ
4252012-04-09 Eli Zaretskii <eliz@gnu.org>
426
427 * xdisp.c (set_cursor_from_row): If the display string appears in
428 the buffer at position that is closer to point than the position
429 after the display string, display the cursor on the first glyph of
430 the display string. Fixes cursor display when a 'display' text
431 property immediately follows invisible text. (Bug#11094)
432
cb3c2e3e
PE
4332012-04-09 Paul Eggert <eggert@cs.ucla.edu>
434
435 composite.c: use 'double' consistently
436 * composite.c (get_composition_id): Use 'double' consistently
437 instead of converting 'float' to 'double' and vice versa; this is
438 easier to understand and avoids a GCC warning.
439
fd06db5d
GM
4402012-04-09 Glenn Morris <rgm@gnu.org>
441
50fe702a
GM
442 * Makefile.in: Generate leim-list with bootstrap-emacs, in
443 preparation for dumping it with emacs. (Bug#4789)
444 (leimdir): New variable.
445 ($(leimdir)/leim-list.el): New rule.
446 (emacs$(EXEEXT)): Depend on leim-list.el.
447
fd06db5d
GM
448 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
449 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
450 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
451
55c131ee
AS
4522012-04-08 Andreas Schwab <schwab@linux-m68k.org>
453
454 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
455 proper alignment.
456
9209588f
JB
4572012-04-07 Juanma Barranquero <lekktu@gmail.com>
458
459 * xml.c (init_libxml2_functions) [WINDOWSNT]:
460 Remove unused local variable.
461
e3fb2efb
PE
4622012-04-07 Paul Eggert <eggert@cs.ucla.edu>
463
464 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
465 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
466 (mark_memory): Mark Lisp_Objects only if pointers might hide in
467 objects, as mark_maybe_pointer will catch them otherwise.
468 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
469 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
470
b5385551
PE
4712012-04-07 Paul Eggert <eggert@cs.ucla.edu>
472
473 Fix typo that broke non-Windows builds.
474 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
475
9078ead6
EZ
4762012-04-07 Eli Zaretskii <eliz@gnu.org>
477
478 Support building on MS-Windows with libxml2.
479
480 * makefile.w32-in (OBJ2): Add xml.$(O).
481 (GLOBAL_SOURCES): Add xml.c.
482 ($(BLD)/xml.$(O)): New dependency list.
483
484 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
485 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
486 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
487 [!WINDOWSNT]: New macros.
488 (init_libxml2_functions, libxml2_loaded_p): New functions.
489 (parse_region): Call fn_xmlCheckVersion instead of using the macro
490 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
491 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
492 Calls xmlCleanupParser only if libxml2 was loaded (or statically
493 linked in).
6bbef4e5
JC
494 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
495 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
496 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
497
498 * emacs.c: Don't include libxml/parser.h.
499 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
500 xmlCleanupParser directly.
501
502 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
503
3811fdf3
EZ
5042012-04-07 Eli Zaretskii <eliz@gnu.org>
505
506 * indent.c (Fvertical_motion): If there is a display string at
507 point, use it.vpos to compute how many lines to backtrack after
508 move_it_to point. (Bug#11133)
509
2f8e16b2
EZ
5102012-04-06 Eli Zaretskii <eliz@gnu.org>
511
512 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
513 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
514 about subtle differences between FETCH_CHAR* and STRING_CHAR*
515 macros related to unification of CJK characters. For the details,
516 see the discussion following the message here:
517 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
518
3d439cd1
CY
5192012-04-04 Chong Yidong <cyd@gnu.org>
520
521 * keyboard.c (Vdelayed_warnings_list): Doc fix.
522
8bc53d00
EZ
5232012-04-01 Eli Zaretskii <eliz@gnu.org>
524
525 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
526 instead of alloca. (Bug#11138)
527
3b0512a3
AS
5282012-04-01 Andreas Schwab <schwab@linux-m68k.org>
529
530 * w32menu.c (is_simple_dialog): Properly check lisp types.
531 (Bug#11141)
532
8427ddd2
EZ
5332012-03-31 Eli Zaretskii <eliz@gnu.org>
534
979022ef
EZ
535 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
536 position we get to after a call to move_it_to fails the
537 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
538 only if we wind up in a string from display property. (Bug#11063)
539
a6b1c7cc
EZ
540 * window.c (Fdelete_other_windows_internal): Invalidate the row
541 and column information about mouse highlight, so that redisplay
542 restores it after reallocating the glyph matrices. (Bug#7464)
543
8427ddd2
EZ
544 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
545 string comes from a `display' text property, use the buffer
546 position of that property as if we actually saw that position in
547 the row's glyphs.
697ba24b
EZ
548 (move_it_by_lines): Remove the assertion that
549 "it->current_x == 0 && it->hpos == 0" which can be legitimately
550 violated when there's a before-string at the beginning of a line.
551 (Bug#11063)
8427ddd2 552
65a0a738
EZ
5532012-03-30 Eli Zaretskii <eliz@gnu.org>
554
555 * xdisp.c (append_space_for_newline): If the default face was
556 remapped, use the remapped face for the appended newline.
557 (extend_face_to_end_of_line): Use the remapped default face for
558 extending the face to the end of the line.
559 (display_line): Call extend_face_to_end_of_line when the default
560 face was remapped. (Bug#11068)
561
581355cc
EZ
5622012-03-29 Eli Zaretskii <eliz@gnu.org>
563
564 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
565
e8fc049f
SM
5662012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
567
568 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
569
4fb9a543
GM
5702012-03-27 Glenn Morris <rgm@gnu.org>
571
572 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
573 Doc fixes.
574
679910f1
KH
5752012-03-26 Kenichi Handa <handa@m17n.org>
576
577 * dispextern.h (struct glyph): Fix previous change. Change the
578 bit length of glyphless.ch to 25 (Bug#11082).
579
90d49b7f
CY
5802012-03-26 Chong Yidong <cyd@gnu.org>
581
582 * keyboard.c (Vselection_inhibit_update_commands): New variable.
583 (command_loop_1): Use it; inhibit selection update for
584 handle-select-window too (Bug#8996).
585
f514f6f0
FP
5862012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
587
e8fc049f 588 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 589
bf43fa51
KH
5902012-03-25 Kenichi Handa <handa@m17n.org>
591
592 * dispextern.h (struct glyph): Change the bit length of
593 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
594
8a0c01dd
EZ
5952012-03-24 Eli Zaretskii <eliz@gnu.org>
596
597 * s/ms-w32.h (tzname): Include time.h before redirecting to
598 _tzname. Fixes the MSVC build. (Bug#9960)
599
7d1c3a76
AS
6002012-03-24 Andreas Schwab <schwab@linux-m68k.org>
601
8ed79523
AS
602 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
603 characters.
604
7d1c3a76
AS
605 * xterm.c (XTread_socket): Only modify handling_signal if
606 !SYNC_INPUT. (Bug#11080)
607
e99a9b8b
EZ
6082012-03-23 Eli Zaretskii <eliz@gnu.org>
609
610 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
611 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
612 when fetching a multibyte character consumes more bytes than
613 CHAR_BYTES returns, due to unification of CJK characters in
614 string_char. (Bug#11073)
615
5063c0e1
TN
6162012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
617
618 * process.c (wait_reading_process_output): Handle pty disconnect
619 by refraining from sending oneself a SIGCHLD (bug#10933).
620
9f851fbd
CY
6212012-03-22 Chong Yidong <cyd@gnu.org>
622
623 * dispextern.h (struct it): New member string_from_prefix_prop_p.
624
5063c0e1 625 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
626 Mark string as coming from a prefix property.
627 (handle_face_prop): Use default face for prefix strings (Bug#4281).
628 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
629
fb5b8aca
CY
6302012-03-21 Chong Yidong <cyd@gnu.org>
631
632 * xfaces.c (Vface_remapping_alist): Doc fix.
633
62356a1b
EZ
6342012-03-20 Eli Zaretskii <eliz@gnu.org>
635
636 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
637 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
638 Doc fixes.
62356a1b 639
025de85b
CY
6402012-03-20 Chong Yidong <cyd@gnu.org>
641
642 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
643 to reflect default non-nil value of redisplay-dont-pause.
644
4827f94e
KH
6452012-03-19 Kenichi Handa <handa@m17n.org>
646
647 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
648 it fit in a valid range (Bug#11003).
649
e50a24a2
EZ
6502012-03-18 Eli Zaretskii <eliz@gnu.org>
651
652 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
653 that is not from display property, accept the row as a "cursor
654 row" if one of the string's character has a non-nil `cursor'
655 property. Fixes cursor positioning when there are newlines in
656 overlay strings, e.g. in icomplete.el. (Bug#11035)
657
9af5ed87
PE
6582012-03-12 Paul Eggert <eggert@cs.ucla.edu>
659
660 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
661
d1f55f16
CY
6622012-03-12 Chong Yidong <cyd@gnu.org>
663
664 * eval.c (inhibit_lisp_code): Rename from
665 inhibit_window_configuration_change_hook; move from window.c.
666
667 * xfns.c (unwind_create_frame_1, Fx_create_frame):
668 * window.c (run_window_configuration_change_hook)
669 (syms_of_window): Callers changed.
670
66c5eebd
CY
6712012-03-11 Chong Yidong <cyd@gnu.org>
672
413df973
CY
673 * keymap.c (Fkey_description): Doc fix (Bug#9700).
674
66c5eebd
CY
675 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
676
1de11f56
CY
6772012-03-10 Chong Yidong <cyd@gnu.org>
678
679 * frame.c (other_visible_frames): Don't assume the selected frame
680 is visible (Bug#10955).
681
cae07000
SM
6822012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
683
684 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
685
89c94350
JD
6862012-03-08 Jan Djärv <jan.h.d@swipnet.se>
687
688 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
689 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
690 zero (Bug#10954).
691
999dd333
GM
6922012-03-03 Glenn Morris <rgm@gnu.org>
693
01a6dcc8 694 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 695
de0100f2
EZ
6962012-03-02 Eli Zaretskii <eliz@gnu.org>
697
698 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
699 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
700 (redisplay_window, next_element_from_string): Fix typos in
701 comments.
3e441275
EZ
702 (redisplay_window): Pass to move_it_vertically the margin in
703 pixels, not in screen lines.
de0100f2 704
96a72ee9
GM
7052012-03-02 Glenn Morris <rgm@gnu.org>
706
707 * buffer.c (buffer-list-update-hook): Doc fix.
708
312508d7
EZ
7092012-02-29 Eli Zaretskii <eliz@gnu.org>
710
711 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
712 push_it before setting up the iterator for the first overlay
713 string, even if we have an empty string loaded.
714 (next_overlay_string): If there's an empty string on the iterator
715 stack, pop the stack. (Bug#10903)
716
27f3c637
PE
7172012-02-25 Paul Eggert <eggert@cs.ucla.edu>
718
719 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
720 Suggested by Stefan Monnier in
721 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
722 * alloc.c (widen_to_Lisp_Object): New static function.
723 (mark_memory): Also mark Lisp_Objects by fetching pointer words
724 and widening them to Lisp_Objects. This would work even if
725 USE_LSB_TAG is defined and wide integers are used, which might
726 happen in a future version of Emacs.
727
3c9dfce6
CY
7282012-02-25 Chong Yidong <cyd@gnu.org>
729
fa74b241
CY
730 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
731 Doc fix.
732
3c9dfce6
CY
733 * xselect.c (Fx_selection_exists_p): Doc fix.
734 (x_clipboard_manager_save_all): Print an informative message
735 before saving to clipboard manager.
736
9486df08
CY
7372012-02-24 Chong Yidong <cyd@gnu.org>
738
739 * keyboard.c (process_special_events): Handle all X selection
740 requests in kbd_buffer, not just the next one (Bug#8869).
741
f01d3321
CY
7422012-02-23 Chong Yidong <cyd@gnu.org>
743
744 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
745 call when setting menu-bar-lines and tool-bar-lines parameters.
746 (unwind_create_frame_1): New helper function.
747
748 * window.c (inhibit_window_configuration_change_hook): New var.
749 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 750 (syms_of_window): Initialize it.
f01d3321 751
86b847b6
CY
7522012-02-22 Chong Yidong <cyd@gnu.org>
753
754 * xterm.c (x_draw_image_relief): Add missing type check for
755 Vtool_bar_button_margin (Bug#10743).
756
a59225b1
CY
7572012-02-21 Chong Yidong <cyd@gnu.org>
758
759 * fileio.c (Vfile_name_handler_alist): Doc fix.
760
761 * buffer.c (Fget_file_buffer): Protect against invalid file
762 handler return value.
763
310f5bd4
PE
7642012-02-20 Paul Eggert <eggert@cs.ucla.edu>
765
cb3a28cc
PE
766 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
767 when computing $valmask.
768
310f5bd4
PE
769 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
770 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
771 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
772 It's useless in that case, and it can cause problems on hosts
773 that allocate halves of EMACS_INT values separately.
774 Reported by Dan Horák. Diagnosed by Andreas Schwab in
775 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
776 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
777 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
778 it avoids undefined behavior on hosts where shifting right by more
779 than the word width has undefined behavior.
780
2375c96a
CY
7812012-02-19 Chong Yidong <cyd@gnu.org>
782
783 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
784 (Funhandled_file_name_directory, Ffile_name_as_directory)
785 (Fdirectory_file_name, Fexpand_file_name)
786 (Fsubstitute_in_file_name): Protect against invalid file handler
787 return values (Bug#10845).
788
3eb49e71
EZ
7892012-02-18 Eli Zaretskii <eliz@gnu.org>
790
791 * .gdbinit (pitx): Fix incorrect references to fields of the
792 iterator stack.
793
7b926f3f
CY
7942012-02-17 Chong Yidong <cyd@gnu.org>
795
796 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
797
11273115
PE
7982012-02-15 Paul Eggert <eggert@cs.ucla.edu>
799
800 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
801 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
802
c3a70e2b
CY
8032012-02-15 Chong Yidong <cyd@gnu.org>
804
805 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
806 marked as special. Also, starting docstrings with * is obsolete.
807
0ca43699
AS
8082012-02-13 Andreas Schwab <schwab@linux-m68k.org>
809
810 * gnutls.c (emacs_gnutls_write): Fix last change.
811
2e8f3c56
LI
8122012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
813
814 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
815 send_process.
816
af70074f
SM
8172012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
818
819 * keymap.c (Fsingle_key_description): Handle char ranges.
820
95986d52
CY
8212012-02-12 Chong Yidong <cyd@gnu.org>
822
afd83bd1
CY
823 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
824 as that creates a dangerous corner case.
825
95986d52
CY
826 * window.c (Fdelete_window_internal): Invalidate the mouse
827 highlight (Bug#9904).
828
bd7da63e
GM
8292012-02-12 Glenn Morris <rgm@gnu.org>
830
831 * xselect.c (Fx_own_selection_internal)
832 (Fx_get_selection_internal, Fx_disown_selection_internal)
833 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
834 * nsselect.m (Fx_own_selection_internal)
835 (Fx_disown_selection_internal, Fx_selection_exists_p)
836 (Fx_selection_owner_p, Fx_get_selection_internal):
837 Sync docs and argument specs with the xselect.c versions.
838
77abcbc2
LI
8392012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
840
841 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
842
90b671e2
EZ
8432012-02-11 Eli Zaretskii <eliz@gnu.org>
844
1c0ca0b7
EZ
845 * w32select.c (Fx_selection_exists_p): Sync doc string and
846 argument list with xselect.c. (Bug#10783)
847
848 * w16select.c (Fx_selection_exists_p): Sync doc string and
849 argument list with xselect.c. (Bug#10783)
90b671e2 850
49241268
GM
8512012-02-10 Glenn Morris <rgm@gnu.org>
852
853 * fns.c (Fsecure_hash): Doc fix.
854
f998bbe7 8552012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
856
857 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
858
0992bd9c
CY
8592012-02-07 Chong Yidong <cyd@gnu.org>
860
861 * buffer.c (Fbuffer_local_variables)
862 (buffer_lisp_local_variables): Handle unbound vars correctly;
863 don't let Qunbound leak into Lisp.
864
af008560
GM
8652012-02-07 Glenn Morris <rgm@gnu.org>
866
dd605cc4
GM
867 * image.c (Fimagemagick_types): Doc fix.
868
af008560
GM
869 * image.c (imagemagick-render-type): Change it from a lisp object
870 to an integer. Move the doc here from the lisp manual.
871 Treat all values not equal to 0 the same.
872
1449fa1d
CY
8732012-02-06 Chong Yidong <cyd@gnu.org>
874
875 * doc.c (store_function_docstring): Avoid applying docstring of
876 alias to base function (Bug#2603).
877
3723ec07
AS
8782012-02-04 Andreas Schwab <schwab@linux-m68k.org>
879
880 * .gdbinit (pp1, pv1): Remove redundant defines.
881 (pr): Use pp.
882
79c1cc1e
CY
8832012-02-04 Chong Yidong <cyd@gnu.org>
884
885 * nsterm.m: Declare a global (Bug#10694).
886
d7f29f8e
EZ
8872012-02-04 Eli Zaretskii <eliz@gnu.org>
888
cae07000
SM
889 * w32.c (get_emacs_configuration_options):
890 Include --enable-checking, if specified, in the return value.
d7f29f8e 891
3b95a6f9
MR
8922012-02-04 Martin Rudalics <rudalics@gmx.at>
893
894 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
895 after rounding frame sizes. (Bug#9723)
896
d6fa96a6
EZ
8972012-02-04 Eli Zaretskii <eliz@gnu.org>
898
899 * keyboard.c (adjust_point_for_property): Don't position point
900 before BEGV. (Bug#10696)
901
df0b2940
PE
9022012-02-03 Paul Eggert <eggert@cs.ucla.edu>
903
904 Handle overflow when computing char display width (Bug#9496).
905 * character.c (char_width): Return EMACS_INT, not int.
906 (char_width, c_string_width): Check for overflow when
907 computing the width; this is possible now that individual
908 characters can have unbounded width. Problem introduced
909 by merge from Emacs 23 on 2012-01-19.
910
6bee44d6
MA
9112012-02-02 Michael Albinus <michael.albinus@gmx.de>
912
913 * dbusbind.c (Fdbus_register_method): Mention the return value
914 :ignore in the docstring.
915
44f92739
GM
9162012-02-02 Glenn Morris <rgm@gnu.org>
917
1b9f60cc
GM
918 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
919
44f92739
GM
920 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
921 Unconditionally set to t. (Bug#10673)
922 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
923 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
924 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
925
c5d3843c
KH
9262012-02-02 Kenichi Handa <handa@m17n.org>
927
928 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
929 0, do not call append_composite_glyph.
930
159462d4 9312012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
932
933 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
934 NULL (Bug#6988).
935 (x_produce_glyphs): If the component of a composition is a null
936 string, set it->pixel_width to 1 to avoid zero-width glyph.
937
78cef877
EZ
9382012-02-01 Eli Zaretskii <eliz@gnu.org>
939
940 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
941 first 2 arguments are identical. This makes inserting large
942 output from a subprocess an order of magnitude faster on
943 MS-Windows, where all sbrk'ed memory is always contiguous.
944
97897668
GM
9452012-01-31 Glenn Morris <rgm@gnu.org>
946
947 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 948 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
949 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
950
31fd3586
GM
9512012-01-29 Glenn Morris <rgm@gnu.org>
952
953 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
954
0e24a8b2
CY
9552012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
956
957 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
958
cc0adcb0
CY
9592012-01-28 Chong Yidong <cyd@gnu.org>
960
961 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
962
acc28cb9
CY
9632012-01-26 Chong Yidong <cyd@gnu.org>
964
9c69cfb7
CY
965 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
966
acc28cb9
CY
967 * search.c (Fsearch_forward, Fsearch_backward): Document negative
968 repeat counts (Bug#10507).
969
48da7392
GM
9702012-01-26 Glenn Morris <rgm@gnu.org>
971
972 * lread.c (syms_of_lread): Doc fix.
973
14af5f7f
CY
9742012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
975
976 * coding.c (encode_designation_at_bol): Change return value to
977 EMACS_INT.
978
0b21c100
CY
9792012-01-25 Chong Yidong <cyd@gnu.org>
980
981 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
982
3c2907f7
CY
9832012-01-21 Chong Yidong <cyd@gnu.org>
984
985 * floatfns.c (Fcopysign): Make the second argument non-optional,
986 since nil is not allowed anyway.
987
959ad23f
AS
9882012-01-21 Andreas Schwab <schwab@linux-m68k.org>
989
990 * process.c (read_process_output): Use p instead of XPROCESS (proc).
991 (send_process): Likewise.
992
34a02f46
MR
9932012-01-19 Martin Rudalics <rudalics@gmx.at>
994
995 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
996 (Vwindow_persistent_parameters): Do not use Qstate.
997 Rewrite doc-strings.
34a02f46 998
1259009a 9992012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
1000
1001 * character.c (char_width): New function.
70d4fdf6
GM
1002 (Fchar_width, c_string_width, lisp_string_width):
1003 Use char_width (Bug#9496).
25ed9e61 1004
6a6ee00d
MR
10052012-01-16 Martin Rudalics <rudalics@gmx.at>
1006
1007 * window.c (Vwindow_persistent_parameters): New variable.
1008 (Fset_window_configuration, save_window_save): Handle persistent
1009 window parameters.
1010
c85efaf7
EZ
10112012-01-14 Eli Zaretskii <eliz@gnu.org>
1012
1013 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
1014 thrashing the stack of the thread. (Bug#9087)
1015
5944709e
PE
10162012-01-12 Paul Eggert <eggert@cs.ucla.edu>
1017
1018 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
1019
e71f5d99
EZ
10202012-01-11 Eli Zaretskii <eliz@gnu.org>
1021
1022 * xdisp.c (rows_from_pos_range): Handle the case where the
1023 highlight ends on a newline. (Bug#10464)
1024 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
1025 he end column for display of highlight that ends on a newline
1026 before a R2L line.
1027
ce316182
GM
10282012-01-11 Glenn Morris <rgm@gnu.org>
1029
1030 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
1031 from load-path also when installation-directory is nil. (Bug#10208)
1032
5b43da69
GM
10332012-01-10 Glenn Morris <rgm@gnu.org>
1034
74cc8ff9
GM
1035 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
1036
7d8d6e4e
GM
1037 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
1038 Update template values to be closer to their typical values these days.
5b43da69 1039
a0db8d43
EZ
10402012-01-09 Eli Zaretskii <eliz@gnu.org>
1041
1042 * xdisp.c (rows_from_pos_range): Accept additional argument
1043 DISP_STRING, and accept any glyph in a row whose object is that
1044 string as eligible for mouse highlight. Fixes mouse highlight of
1045 display strings from overlays. (Bug#10464)
1046
9a0115ab 10472012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 1048
b9110d6a 1049 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
1050 * fileio.c (auto_saving_dir_umask): New static var.
1051 (Fmake_directory_internal): Use it.
1052 (do_auto_save_make_dir): Set it, instead of invoking chmod after
1053 creating the directory. The old code temporarily assigns
1054 too-generous permissions to the directory.
1055 (do_auto_save_eh): Clear it.
b9110d6a 1056 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
1057 that the var is always cleared.
1058
6c1bd3f3
EZ
10592012-01-07 Eli Zaretskii <eliz@gnu.org>
1060
1061 * search.c (scan_buffer): Pass character positions to
1062 know_region_cache, not byte positions. (Bug#6540)
1063
069d2b50
L
10642012-01-07 LynX <_LynX@bk.ru> (tiny change)
1065
1066 * w32.c (sys_rename): Report EXDEV when rename of a directory
1067 fails because the target is on another logical disk. (Bug#10284)
1068
75bf0d33
DB
10692012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
1070
1071 * xterm.c (x_embed_request_focus): New function.
1072
1073 * xterm.h: Add prototype.
1074
1075 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
1076
1c6e5a32
GM
10772012-01-05 Glenn Morris <rgm@gnu.org>
1078
1079 * emacs.c (emacs_copyright): Update short copyright year to 2012.
1080
651e947e
EZ
10812012-01-01 Eli Zaretskii <eliz@gnu.org>
1082
1083 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
1084 Load gnutls_transport_set_lowat only if GnuTLS version is below
1085 2.11.1.
1086 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
1087 GnuTLS versions below 2.11.1.
1088
3778cdd8
AL
10892011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
1090
1091 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
1092 to the doc string advising against its use for altering the way
1093 windows are scrolled.
1094
0e5317f7
KH
10952011-12-28 Kenichi Handa <handa@m17n.org>
1096
1097 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
1098 coding-system ASCII compatible only when it does not produce BOM
1099 on encoding (Bug#10383).
1100
93d5ca1f
JD
11012011-12-26 Jan Djärv <jan.h.d@swipnet.se>
1102
1103 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
1104 can scroll.
1105 (create_and_show_popup_menu): Always use menu_position_func for
1106 Gtk3 (Bug#10361).
1107
ca22b785
AS
11082011-12-24 Andreas Schwab <schwab@linux-m68k.org>
1109
1110 * callint.c (Fcall_interactively): Don't truncate prompt string.
1111
d048e1e6
EZ
11122011-12-23 Eli Zaretskii <eliz@gnu.org>
1113
1114 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
1115 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 1116 resumed from there (after widening). (Bug#10360)
d048e1e6 1117
5ccaba1f
JD
11182011-12-22 Jan Djärv <jan.h.d@swipnet.se>
1119
1120 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
1121
204ee57f
JD
11222011-12-21 Jan Djärv <jan.h.d@swipnet.se>
1123
b81d40f0
JB
1124 * nsterm.m (x_free_frame_resources):
1125 Release f->output_data.ns->miniimage.
204ee57f
JD
1126 (ns_index_color): Fix indentation. Do not retain
1127 color_table->colors[i].
1128
1129 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
1130 before returning.
1131
1132 * nsfns.m (x_set_background_color): Assign return value from
1133 ns_index_color to face-background instead of NSColor*.
1134 (ns_implicitly_set_icon_type): Fix indentation.
1135 Change assignment in for loop to comparison.
1136
1137 * emacs.c (ns_pool): New variable.
1138 (main): Assign ns_pool.
1139 (Fkill_emacs): Call ns_release_autorelease_pool.
1140
1141 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
1142 autorelease fdesc, release fdAttrs and tdict.
1143 (ns_get_covering_families): Release charset.
1144 (ns_findfonts): Release NSFontDescriptor created with new.
1145 (ns_uni_to_glyphs): Fix indentation.
1146 (setString): Release attrStr before assigning new value.
1147
c803b2b7
JD
11482011-12-18 Jan Djärv <jan.h.d@swipnet.se>
1149
678f4426
JD
1150 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
1151 and NS_IMPL_COCOA.
1152 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
1153 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
1154
cd394be1 11552011-12-18 David Reitter <reitter@cmu.edu>
678f4426 1156
5fecd5fc
JD
1157 * nsterm.m (ns_term_init): Subscribe for notifications
1158 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
1159 to method trackingNotification in EmacsMenu.
1160
1161 * nsmenu.m (trackingMenu): New variable.
3771cb17 1162 (trackingNotification): New method (from Aquamacs).
5fecd5fc 1163 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 1164 from Aquamacs (Bug#7030).
678f4426
JD
1165
11662011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 1167
c803b2b7
JD
1168 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
1169 (symbol_to_nsstring): Fix indentation.
1170 (ns_symbol_to_pb): New function.
cae07000
SM
1171 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
1172 (Fns_rotate_cut_buffers_internal): Remove.
1173 (Fns_store_selection_internal): Rename from
c803b2b7
JD
1174 Fns_store_cut_buffer_internal.
1175 (ns_get_foreign_selection, Fx_own_selection_internal)
1176 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
1177 (Fns_get_selection_internal, Fns_store_selection_internal):
1178 Use ns_symbol_to_pb and check if return value is nil.
1179 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
1180 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
1181 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
1182 renamed to Sns_store_selection_internal.
1183 (ns_handle_selection_request): Move code to Fx_own_selection_internal
1184 and remove this function.
1185 (ns_handle_selection_clear): Remove, never used.
1186 (Fx_own_selection_internal): Move code from ns_handle_selection_request
1187 here.
1188
e1b01a3a
KB
11892011-12-17 Ken Brown <kbrown@cornell.edu>
1190
1191 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
1192 GID is unknown (Bug#10257).
1193
2adb6e85
PE
11942011-12-17 Paul Eggert <eggert@cs.ucla.edu>
1195
1196 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
1197 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
1198 which caused a build failure on GNU/Linux IA-64. This problem was
1199 introduced by my 2011-10-07 patch.
1200
d1d7b339
JL
12012011-12-15 Juri Linkov <juri@jurta.org>
1202
1203 * image.c (imagemagick_error): New function. (Bug#10112)
1204 (imagemagick_load_image): Comment out `MagickSetResolution' call.
1205 Use `imagemagick_error' where ImageMagick functions return
1206 `MagickFalse'.
1207 (Fimagemagick_types): Add `Fnreverse' to return the list in the
1208 proper order.
1209
100d5755
KH
12102011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1211
1212 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
1213 fill background (Bug#8992).
1214
454592a6
MR
12152011-12-13 Martin Rudalics <rudalics@gmx.at>
1216
1217 * window.c (Vwindow_combination_resize)
1218 (Vwindow_combination_limit): Use t instead of non-nil in
1219 doc-strings.
61d4b438
MR
1220 (Vrecenter_redisplay): Add first sentence of doc-string on
1221 separate line.
53524d93 1222 (Frecenter): Fix doc-string typo.
454592a6 1223
3633e3aa
KH
12242011-12-11 Kenichi Handa <handa@m17n.org>
1225
1226 * coding.c (Funencodable_char_position): Pay attention to the
1227 buffer text relocation (Bug#9389).
1228
7b9d523a
JD
12292011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1230
1231 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
1232 gtk_init (Bug#10100).
1233
b73189c6
EZ
12342011-12-10 Eli Zaretskii <eliz@gnu.org>
1235
1236 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
1237 IT->string is nil. (Bug#10263)
1238
f7dfe5d6
JD
12392011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1240
83faebb4
JD
1241 * nsterm.h (x_free_frame_resources): Declare.
1242
f7dfe5d6
JD
1243 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
1244 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
1245
1246 * nsterm.h (ns_get_defaults_value): Declare.
1247
1248 * nsterm.m (ns_default): Call ns_get_defaults_value.
1249
7cd4e72c
EZ
12502011-12-09 Eli Zaretskii <eliz@gnu.org>
1251
1252 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
1253 (Bug#10170)
1254
b34d7317
YM
12552011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1256
1257 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
1258 that where the value of an _OBJC_* symbol points to is in the .bss
1259 section (Bug#10240).
1260
76470ad1
KH
12612011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1262
1263 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 1264 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 1265
745fff94
KH
12662011-12-08 Kenichi Handa <handa@m17n.org>
1267
1268 * ftfont.c (get_adstyle_property): Fix previous change
1269 (Bug#10233).
1270
6e44397c
JB
12712011-12-07 Juanma Barranquero <lekktu@gmail.com>
1272
1273 * w32.c (init_environment): If no_site_lisp, remove site-lisp
1274 dirs from the default value of EMACSLOADPATH (bug#10208).
1275
7efa6272
GM
12762011-12-07 Glenn Morris <rgm@gnu.org>
1277
1278 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
1279 installation and source directories as well. (Bug#10208)
1280
f6fc4d87
CY
12812011-12-06 Chong Yidong <cyd@gnu.org>
1282
1283 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
1284
2bf26180
GM
12852011-12-06 Glenn Morris <rgm@gnu.org>
1286
1287 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
1288 as an error, not just -1. (Bug#10217)
1289
3a6ad4f0
CY
12902011-12-05 Chong Yidong <cyd@gnu.org>
1291
1292 * keyboard.c (process_special_events): New function.
1293 (swallow_events, Finput_pending_p): Use it (Bug#10195).
1294
75a3b399
PE
12952011-12-05 Paul Eggert <eggert@cs.ucla.edu>
1296
1297 * coding.c (encode_designation_at_bol): Don't use uninitialized
1298 local variable (Bug#9318).
1299
c3c9e25e
KH
13002011-12-05 Kenichi Handa <handa@m17n.org>
1301
1302 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
1303 return Qnil (Bug#8046, Bug#10193).
1304
5eb05ea3
KH
13052011-12-05 Kenichi Handa <handa@m17n.org>
1306
1307 * coding.c (encode_designation_at_bol): New args charbuf_end and
1308 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
1309 (coding_set_source): Return how many bytes coding->source was
1310 relocated.
1311 (coding_set_destination): Return how many bytes
1312 coding->destination was relocated.
1313 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 1314 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
1315
13162011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1317
1318 * coding.c (CODING_CHAR_CHARSET_P): New macro.
1319 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
1320 macro (Bug#9318).
1321
13222011-12-05 Andreas Schwab <schwab@linux-m68k.org>
1323
1324 The following changes are to fix Bug#9318.
1325
a79703f5 1326 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
1327 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
1328 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 1329 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 1330
7dbda6df
JB
13312011-12-05 Juanma Barranquero <lekktu@gmail.com>
1332
1333 * lisp.h (process_quit_flag): Fix external declaration.
1334
6d5eb5b0
SM
13352011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
1336
1337 Don't macro-inline non-performance-critical code.
1338 * eval.c (process_quit_flag): New function.
1339 * lisp.h (QUIT): Use it.
1340
a0c3fad0
JD
13412011-12-04 Jan Djärv <jan.h.d@swipnet.se>
1342
1343 * nsfns.m (get_geometry_from_preferences): New function.
1344 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
1345
6c07aac2
AS
13462011-12-04 Andreas Schwab <schwab@linux-m68k.org>
1347
1348 * emacs.c (Qkill_emacs): Define.
1349 (syms_of_emacs): Initialize it.
1350 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
1351 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
1352 (quit_throw_to_read_char): Add parameter `from_signal'.
1353 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
1354 * lisp.h (QUIT): Call Fkill_emacs if requested.
1355
c052ead4
JD
13562011-12-03 Jan Djärv <jan.h.d@swipnet.se>
1357
1358 * widget.c (update_wm_hints): Return if wmshell is null.
1359 (widget_update_wm_size_hints): New function.
1360
1361 * widget.h (widget_update_wm_size_hints): Declare.
1362
1363 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
1364 widget_update_wm_size_hints (Bug#10104).
1365
9e49252b
EZ
13662011-12-03 Eli Zaretskii <eliz@gnu.org>
1367
1368 * xdisp.c (handle_invisible_prop): If the invisible text ends just
1369 before a newline, prepare the bidi iterator for consuming the
1370 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 1371 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 1372
02b16839
JL
13732011-12-02 Juri Linkov <juri@jurta.org>
1374
1375 * search.c (Fword_search_regexp): New Lisp function created from
1376 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1377 (Fword_search_backward, Fword_search_forward)
1378 (Fword_search_backward_lax, Fword_search_forward_lax):
1379 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1380 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1381
0068070e
SM
13822011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1383
1384 * fileio.c (Finsert_file_contents): Move after-change-function call
1385 to before the "handled:" label, since all "goto handled" appear in
1386 cases where the *-change-functions have already been properly called
1387 (bug#10117).
1388
3360a3fc
AS
13892011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1390
1391 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1392 waiting for input. (Bug#10169)
1393
73d6c093
EZ
13942011-11-30 Eli Zaretskii <eliz@gnu.org>
1395
1396 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1397 verifies glyph row's hash code--we have just reallocated the
1398 glyphs, so their contents can be complete garbage. (Bug#10164)
1399
febe6bea
JB
14002011-11-30 Juanma Barranquero <lekktu@gmail.com>
1401
1402 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1403
801a4313
EZ
14042011-11-30 Eli Zaretskii <eliz@gnu.org>
1405
1406 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1407 attributes are tested _before_ calling verify_row_hash, to protect
1408 against GCC re-ordering of the tests. (Bug#10164)
1409
2b56b87e
JD
14102011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1411
1412 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1413
1414 * xterm.c (handle_one_xevent): Only set async_visible and friends
1415 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 1416 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
1417 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1418
dbf31225
PE
14192011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1420
1421 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1422 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1423 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1424 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1425 All uses changed to use GCPRO1 etc.
1426 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1427 Revert to old implementation (i.e., before 2011-03-11).
1428
1305621b
YM
14292011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1430
1431 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1432 of scroll runs so as to avoid assigning disabled bogus rows and
1433 unnecessary graphics copy operations.
1434
8c9afb46
EZ
14352011-11-27 Eli Zaretskii <eliz@gnu.org>
1436
1437 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1438 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1439 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1440 (malloc, free, realloc, calloc): Redirect to e_* only when
1441 compiling Emacs.
1442
1443 * lisp.h (GCTYPEBITS): Move before first use.
1444 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1445 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1446 this macro definition.
1447
1448 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1449 _MSC_VER.
1450
54e9e3bf
JD
14512011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1452
6d5eb5b0
SM
1453 * gtkutil.c (xg_create_frame_widgets):
1454 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
1455 present with Gtk+ 2.0.
1456
83aca1cb
PE
14572011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1458
1459 * fileio.c (Finsert_file_contents): Undo previous change; see
1460 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1461
5b76caa4
PE
14622011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1463
1464 Rename locals to avoid shadowing.
1465 * fileio.c (Finsert_file_contents):
1466 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1467 * process.c (wait_reading_process_output):
1468 Rename inner 'proc' to 'p' to avoid shadowing.
1469 Indent for consistency with usual Emacs style.
1470
8c535114
EZ
14712011-11-25 Eli Zaretskii <eliz@gnu.org>
1472
1473 * xdisp.c (redisplay_window): If cursor row is not fully visible
1474 after recentering, and scroll-conservatively is set to a large
1475 number, scroll window by a few more lines to make the cursor fully
1476 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
1477 (start_display): Don't move to the next line if the display should
1478 start at a newline that is part of a display vector or an overlay
1479 string. (Bug#10119)
8c535114 1480
fa4fdb5c
JL
14812011-11-24 Juri Linkov <juri@jurta.org>
1482
1483 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1484 after the `MagickPingImage' call. (Bug#10112)
1485
90ec88df
CY
14862011-11-23 Chong Yidong <cyd@gnu.org>
1487
1488 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1489
56e2e794
MR
14902011-11-23 Martin Rudalics <rudalics@gmx.at>
1491
1492 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1493 making another buffer current. (Bug#10114)
1494
b6e64c41
GM
14952011-11-23 Glenn Morris <rgm@gnu.org>
1496
1497 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1498
6b21de18
CY
14992011-11-23 Chong Yidong <cyd@gnu.org>
1500
1501 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1502 using it (Bug#5984).
1503
b12cd789
EZ
15042011-11-22 Eli Zaretskii <eliz@gnu.org>
1505
1506 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1507 and header-lines, as they don't have one computed for them.
1508 (Bug#10098)
1509
1510 * .gdbinit (prow): Make displayed values more self-explaining.
1511 Add row's hash code.
1512
261b6fd4
LMI
15132011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1514
1515 * process.c (wait_reading_process_output): Fix asynchrounous
1516 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 1517 (wait_reading_process_output): Add comment and URL.
261b6fd4 1518
e7cfd277
JD
15192011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1520
1521 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1522
a9b9b7f5
CY
15232011-11-21 Chong Yidong <cyd@gnu.org>
1524
1525 * window.c (Fnext_window, Fprevious_window): Doc fix.
1526
b0d15b4f
SM
15272011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1528
1529 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1530
fe7a3057
JB
15312011-11-20 Juanma Barranquero <lekktu@gmail.com>
1532
1533 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1534
d2999b1a
MR
15352011-11-20 Martin Rudalics <rudalics@gmx.at>
1536
1537 * window.c (Fset_window_combination_limit): Rename argument
1538 STATUS to LIMIT.
1539 (Vwindow_combination_limit): Remove "status" from doc-string.
1540
d5ff9cd0
AS
15412011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1542
1543 * m/ibms390.h: Remove.
1544 * m/ibms390x.h: Don't include "ibms390.h".
1545
a5bb9bd3
SM
15462011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1547
1548 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1549 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1550
cd1181db
JB
15512011-11-20 Juanma Barranquero <lekktu@gmail.com>
1552
1553 * casetab.c (Fset_case_table):
1554 * charset.c (Fcharset_after): Fix typos.
1555
615a3b8d 15562011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 1557
17e845af
PE
1558 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1559 Otherwise, valgrind does not work on some platforms.
1560 Problem reported by Andreas Schwab in
6a0bf43d
PE
1561 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1562 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1563 is set, removing the need for VIRT_ADDRESS_VARIES.
1564 (PURE_P): Use a more-efficient implementation that needs just one
1565 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1566 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1567 to 4 (xorl, subq, cmpq, setbe).
1568 * alloc.c (pure): Always extern now, since that's the
1569 VIRT_ADDR_VARIES behavior.
1570 (PURE_POINTER_P): Use a single comparison, not two, for
1571 consistency with the new puresize.h.
1572 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1573 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1574 Remove VIRT_ADDR_VARIES no longer needed.
1575
f8fe6f96
EZ
15762011-11-19 Eli Zaretskii <eliz@gnu.org>
1577
1578 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1579 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1580 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1581 behave as if the cursor position were at the window margin.
1582
1583 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1584 and the cursor position is out of bounds, behave as if the cursor
1585 position were at the window margin. (Bug#10075)
1586
df05a53c
CY
15872011-11-18 Chong Yidong <cyd@gnu.org>
1588
1589 * window.c (Fwindow_combination_limit): Make first argument
1590 non-optional, since it is meaningless for live windows like the
1591 selected window.
1592
2071918e
DA
15932011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1594
1595 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1596
b50a28de
SM
15972011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1598
1599 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1600 (graft_intervals_into_buffer): Simplify.
1601
015137db
EZ
16022011-11-18 Eli Zaretskii <eliz@gnu.org>
1603
1604 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1605 hash values of the two rows.
1606 (copy_row_except_pointers): Preserve the used[] arrays and the
1607 hash values of the two rows. (Bug#10035)
68c95424 1608 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
1609
1610 * xdisp.c (row_hash): New function, body extracted from
1611 compute_line_metrics.
1612 (compute_line_metrics): Call row_hash, instead of computing the
1613 hash code inline.
1614
1615 * dispnew.c (verify_row_hash): Call row_hash for computing the
1616 hash code of a row, instead of duplicating code from xdisp.c.
1617
1618 * dispextern.h (row_hash): Add prototype.
1619
a2addb04
TH
16202011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1621
1622 * frame.c (delete_frame): Don't delete the terminal when the last
1623 X frame is closed if emacs is built with GTK toolkit.
1624
df85d315
JB
16252011-11-17 Juanma Barranquero <lekktu@gmail.com>
1626
1627 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1628
a0c2d0ae
MR
16292011-11-17 Martin Rudalics <rudalics@gmx.at>
1630
1631 * window.c (Vwindow_splits): Rename to
1632 Vwindow_combination_resize. Suggested by Juri Linkov.
1633 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1634 of Vwindow_splits.
1635
58179cce
JB
16362011-11-16 Juanma Barranquero <lekktu@gmail.com>
1637
7877f373
JB
1638 * nsfns.m (Fns_font_name):
1639 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 1640
b6f67890
MR
16412011-11-16 Martin Rudalics <rudalics@gmx.at>
1642
1643 * window.h (window): Rename slot "nest" to "combination_limit".
1644 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1645 (Fset_window_nest): Rename to Fset_window_combination_limit.
1646 (Vwindow_nest): Rename to Vwindow_combination_limit.
1647 (recombine_windows, make_parent_window, make_window)
1648 (Fsplit_window_internal, saved_window)
1649 (Fset_window_configuration, save_window_save): Rename all
1650 occurrences of window_nest to window_combination_limit.
1651
c7015153
JB
16522011-11-15 Juanma Barranquero <lekktu@gmail.com>
1653
1654 * image.c (imagemagick_load_image): Fix typo.
1655
322ad6ec
EZ
16562011-11-14 Eli Zaretskii <eliz@gnu.org>
1657
1658 * xdisp.c (display_line): Move the call to
1659 highlight_trailing_whitespace before the call to
1660 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
1661 faces of all the glyphs to compute ROW's hash value.
1662 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 1663
f067b8ec
JB
16642011-11-14 Juanma Barranquero <lekktu@gmail.com>
1665
1666 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1667 just return (bug#10044).
1668
1e5b2111
EZ
16692011-11-12 Eli Zaretskii <eliz@gnu.org>
1670
7ef3cbd5
EZ
1671 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1672 with user-defined heap size. Bump the default size of the temacs
1673 heap to 27MB, to avoid memory warning when running temacs.
1674 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1675
1e5b2111
EZ
1676 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1677 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
1678 (verify_row_hash) [XASSERTS]: New function.
1679 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1680 that the hash value of glyph rows is correct.
1e5b2111 1681
89d61221
MR
16822011-11-12 Martin Rudalics <rudalics@gmx.at>
1683
1684 * window.h (window): Remove splits slot.
1685 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1686 (Fdelete_other_windows_internal, make_parent_window)
1687 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1688 (Fset_window_configuration, save_window_save): Don't deal with
1689 split status of windows.
1690 (saved_window): Remove splits slot.
1691 (Vwindow_splits): Rewrite doc-string.
1692
97f18cc8
JD
16932011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1694
1695 * xfns.c (unwind_create_frame):
1696 * nsfns.m (unwind_create_frame):
1697 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1698 Vframe_list (Bug#9999).
1699
22a648b4
DA
17002011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1701
0b381c7e 1702 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 1703
659afede
KH
17042011-11-11 Kenichi Handa <handa@m17n.org>
1705
1706 * callproc.c (Fcall_process): Set the member dst_multibyte of
1707 process_coding.
1708
9ac0394b
KH
17092011-11-11 Johan Bockgård <bojohan@gnu.org>
1710
1711 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1712 avoid a crash (bug#9496).
1713
2fbdc249
CY
17142011-11-09 Chong Yidong <cyd@gnu.org>
1715
1716 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1717 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1718
ac6b1f81
PE
17192011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1720
1721 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1722
09db192c
PE
17232011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1724
1725 Avoid some portability problems by eschewing 'extern inline' functions.
1726 The trivial performance wins aren't worth the portability hassles; see
1727 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1728 et seq.
1729 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1730 (window_box_width, window_box_left, window_box_left_offset)
1731 (window_box_right, window_box_right_offset): Undo previous change,
1732 by removing the "extern"s.
1733 * intervals.c (adjust_intervals_for_insertion)
1734 (adjust_intervals_for_deletion): Undo previous change,
1735 making these static again.
1736 (offset_intervals, temp_set_point_both, temp_set_point)
1737 (copy_intervals_to_string): No longer inline.
1738 * xdisp.c (window_text_bottom_y, window_box_width)
1739 (window_box_height, window_box_left_offset)
1740 (window_box_right_offset, window_box_left, window_box_right)
1741 (window_box): No longer inline.
1742
105216ed
CY
17432011-11-08 Chong Yidong <cyd@gnu.org>
1744
1745 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
1746 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1747 Signal an error if not a live window.
105216ed
CY
1748 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1749 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1750
ae9e237f
JB
17512011-11-07 Juanma Barranquero <lekktu@gmail.com>
1752
1753 * lisp.h (syms_of_abbrev): Remove declaration.
1754 Reported by CHENG Gao <chenggao@royau.me>.
1755
c7aa8333
EZ
17562011-11-07 Eli Zaretskii <eliz@gnu.org>
1757
1758 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1759 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1760 of temacs in GUI mode.
1761
be7f5545
MR
17622011-11-07 Martin Rudalics <rudalics@gmx.at>
1763
1764 * window.h: Declare delete_all_child_windows instead of
1765 delete_all_subwindows.
1766 * window.c (Fwindow_nest, Fset_window_nest)
1767 (Fset_window_new_total, Fset_window_new_normal)
1768 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1769 (delete_all_subwindows): Rename to delete_all_child_windows.
1770 (Fdelete_other_windows_internal, Fset_window_configuration):
1771 Call delete_all_child_windows instead of delete_all_subwindows.
1772 * frame.c (delete_frame): Call delete_all_child_windows instead
1773 of delete_all_subwindows.
1774
ca78dc43
PE
17752011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1776
1777 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1778 This is also needed for porting to any host where GC_MARK_STACK is
1779 not GC_MAKE_GCPROS_NOOPS.
1780 (which_symbols): Use it.
1781
a0241d01
KH
17822011-11-07 Kenichi Handa <handa@m17n.org>
1783
1784 * coding.c (coding_set_destination): Check coding->src_pos only
1785 when coding->src_object is a buffer (bug#9910).
1786
1787 * process.c (send_process): Set the member src_multibyte of coding
1788 to 0 (bug#9911) when sending a unibyte text.
1789
1790 * callproc.c (Fcall_process): Set the member src_multibyte of
1791 process_coding to 0 (bug#9912).
1792
a64bfdfa 17932011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
1794
1795 * xmenu.c (cleanup_widget_value_tree): New function.
1796 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1797 calling free_menubar_widget_value_tree directly (Bug#9830).
1798
cb41b32a
PE
17992011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1800
1801 Fix some portability problems with 'inline'.
1802 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1803 (window_box_width, window_box_left, window_box_left_offset)
1804 (window_box_right, window_box_right_offset): Declare extern.
1805 Otherwise, these inline functions do not conform to C99 and
1806 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1807 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1808 * intervals.c (adjust_intervals_for_insertion)
1809 (adjust_intervals_for_deletion): Now extern, because otherwise the
1810 extern inline functions 'offset_intervals' couldn't refer to it.
1811 (static_offset_intervals): Remove.
1812 (offset_intervals): Rewrite using the old contents of
1813 static_offset_intervals. The old version didn't conform to C99
1814 because an extern inline function contained a reference to an
1815 identifier with static linkage.
1816
b7041366
AS
18172011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1818
1819 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1820 GC.
1821
88a37c4d
EZ
18222011-11-06 Eli Zaretskii <eliz@gnu.org>
1823
1824 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1825 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1826 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1827 return Qleft_to_right.
1828
49745b39
CY
18292011-11-06 Chong Yidong <cyd@gnu.org>
1830
1831 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1832 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1833 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1834 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1835 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1836 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1837 (Fwindow_vscroll): Doc fix.
1838 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1839 argument, since it makes no sense to pass a live window and for
1840 consistency with window-child.
1841
1f05cd82
CS
18422011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1843
1844 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1845 support MSVC.
1846
22610910
JR
18472011-11-05 Jason Rumney <jasonr@gnu.org>
1848
1849 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1850 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1851 fonts (Bug#6029).
1852 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1853 bitwise arithmetic preventing use of unicode-sip and non-truetype
1854 opentype fonts.
1855
a06776b2
EZ
18562011-11-05 Eli Zaretskii <eliz@gnu.org>
1857
3ad924ba
EZ
1858 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1859 "emacs"-only part.
1860
a06776b2
EZ
1861 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1862 initialization code to keep similarity to xfns.c after changes
1863 from 2011-11-05.
1864
c9e7db78
JD
18652011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1866
a97f8f3f
JD
1867 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1868 (unwind_create_frame): New function (Bug#9943).
1869 (Fx_create_frame): Restructure code to be more similar to the one in
1870 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1871 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1872 Move terminal->reference_count++ just before making the frame official
1873 (Bug#9943).
1874
1875 * nsterm.m (x_free_frame_resources): New function.
1876 (x_destroy_window): Move code to x_free_frame_resources.
1877
c9e7db78 1878 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
1879 (Fx_create_frame, x_create_tip_frame):
1880 Move terminal->reference_count++ just before making the frame
75f1671a 1881 official. Move initialization of image_cache_refcount and
c9e7db78
JD
1882 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1883
a6fc3b5c
EZ
18842011-11-05 Eli Zaretskii <eliz@gnu.org>
1885
1886 Support MSVC build with newer versions of Visual Studio.
1887 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1888 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1889 nt/gmake.defs.
1890
1891 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1892 which are not supported by MSVC.
1893 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1894 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1895 bitfields.
1896 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1897 types in bitfields.
1898 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1899
1900 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1901
58179cce 19022011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
1903
1904 Support MSVC build with newer versions of Visual Studio.
1905 * w32.c: Don't include w32api.h for MSVC.
1906 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1907
1908 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1909 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1910 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1911 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1912 e_* cousins.
1913 (alloca) [_MSC_VER]: Define to _alloca.
1914
1915 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1916
1917 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1918
a58c13ed
EZ
19192011-11-04 Eli Zaretskii <eliz@gnu.org>
1920
1921 * xdisp.c (note_mouse_highlight): If either of
1922 previous/next-single-property-change returns nil, treat that as
1923 the beginning or the end of the buffer. (Bug#9955)
1924
fe0b6370
JD
19252011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1926
a58c13ed 1927 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
1928 label is not null (Bug#9951).
1929 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1930 may be NULL.
1931
89bd5ee1
EZ
19322011-11-04 Eli Zaretskii <eliz@gnu.org>
1933
1934 * window.c (Fwindow_body_size): Mention in the doc string that the
1935 return value is in frame's canonical units. (Bug#9949)
1936
84c3edb9
EZ
19372011-11-03 Eli Zaretskii <eliz@gnu.org>
1938
4e2fb5c7
EZ
1939 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1940
84c3edb9 1941 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 1942 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 1943 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 1944
bc17a887
EZ
19452011-11-01 Eli Zaretskii <eliz@gnu.org>
1946
1947 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1948 Don't stop backward scan on the continuation glyph, even though
1949 its CHARPOS is positive.
6d5eb5b0
SM
1950 (mouse_face_from_buffer_pos, note_mouse_highlight):
1951 Rename cover_string to disp_string.
bc17a887 1952
4ee88440
MR
19532011-11-01 Martin Rudalics <rudalics@gmx.at>
1954
1955 * window.c (temp_output_buffer_show): Don't use
1956 Vtemp_buffer_show_specifiers.
1957 (Vtemp_buffer_show_specifiers): Remove unused variable.
1958
c2ff3c02
EZ
19592011-10-30 Eli Zaretskii <eliz@gnu.org>
1960
1961 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1962 past the beginning of the current glyph matrix.
1963
58179cce 19642011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
1965
1966 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1967 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1968 HAVE_GTK3 (Bug#9869).
b77a6a7f 1969
3b574623
JD
1970 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1971 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1972
b77a6a7f
JD
1973 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1974
1975 * xterm.c: Declare x_handle_net_wm_state to return int.
1976 (handle_one_xevent): Check if we are iconified but don't have
1977 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1978 (get_current_wm_state): Return non-zero if not hidden,
1979 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1980 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1981 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1982 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1983
196e41e4
PE
19842011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1985
1986 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1987 so that this new function doesn't get optimized away by a
1988 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1989
021f2e1a
AS
19902011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1991
1992 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1993
8b058d44
EZ
19942011-10-29 Eli Zaretskii <eliz@gnu.org>
1995
1996 Fix the `xbytecode' command.
1997 * .gdbinit (xprintbytestr): New command.
b50a28de 1998 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
1999 (xbytecode): Print the byte-code string as well.
2000
4452fb80
EZ
20012011-10-29 Kim Storm <storm@cua.dk>
2002
8b058d44
EZ
2003 * alloc.c (which_symbols): New function.
2004
21b72067
AS
20052011-10-29 Andreas Schwab <schwab@linux-m68k.org>
2006
2007 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
2008 line. (Bug#9903)
2009
83ed7b5c
GM
20102011-10-29 Glenn Morris <rgm@gnu.org>
2011
2012 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
2013 Not clear what it was for, and it causes various bugs. (Bug#9839)
2014
5a7a728b
EZ
20152011-10-28 Eli Zaretskii <eliz@gnu.org>
2016
2017 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
2018 possible random value that matches one of those tested as
2019 condition to clear the mouse face.
2020
d3d0842f
CY
20212011-10-28 Chong Yidong <cyd@gnu.org>
2022
2023 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
2024
31b39d13
DN
20252011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
2026
2027 * window.c (make_window): Initialize phys_cursor_on_p.
2028
9aba6043
SM
20292011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
2030
2031 * lisp.h (struct Lisp_Symbol): Update comments.
2032
c20992f4
JB
20332011-10-28 Juanma Barranquero <lekktu@gmail.com>
2034
2035 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
2036
db4f02f2
EZ
20372011-10-28 Eli Zaretskii <eliz@gnu.org>
2038
2039 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
2040 <oslsachem@gmail.com> for helping to debug this.
2041
2042 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
2043 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
2044 (g_b_init_get_glyph_outline_w): New static variables.
2045 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
2046 (GetGlyphOutlineW_Proc): New typedefs.
2047 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
2048 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
2049 New functions.
2050 (w32font_open_internal, compute_metrics):
2051 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
2052 instead of calling the "wide" APIs directly.
2053
2054 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
2055
2056 * w32.h (syms_of_w32font): Add prototype.
2057
87e68db4
JB
20582011-10-27 Juanma Barranquero <lekktu@gmail.com>
2059
2060 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
2061 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
2062 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
2063 (Fmove_to_window_line): Doc fix.
2064
435c1d67
CY
20652011-10-27 Chong Yidong <cyd@gnu.org>
2066
2067 * process.c (make_process): Set gnutls_state to NULL.
2068
2069 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
2070 non-NULL, regardless of GNUTLS_INITSTAGE.
2071 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
2072 an error. Set process slots as soon as we allocate them.
2073
2074 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
2075
9c6c6f49
CY
20762011-10-27 Chong Yidong <cyd@gnu.org>
2077
9aba6043
SM
2078 * gnutls.c (emacs_gnutls_deinit): New function.
2079 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
2080 (Fgnutls_deinit, Fgnutls_boot): Use it.
2081
2082 * process.c (make_process): Initialize GnuTLS credentials to NULL.
2083 (deactivate_process): Call emacs_gnutls_deinit.
2084
657d08d3
JB
20852011-10-27 Juanma Barranquero <lekktu@gmail.com>
2086
2087 * image.c (x_create_x_image_and_pixmap):
2088 * w32.c (sys_rename, w32_delayed_load):
2089 * w32font.c (fill_in_logfont):
2090 * w32reg.c (x_get_string_resource): Silence compiler warnings.
2091
5430d399
JB
20922011-10-26 Juanma Barranquero <lekktu@gmail.com>
2093
2094 * w32fns.c (w32_default_color_map): New function,
2095 extracted from Fw32_default_color_map.
a7ef684b 2096 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 2097
fe0055fa
PE
20982011-10-25 Paul Eggert <eggert@cs.ucla.edu>
2099
2100 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
2101
e6346438
SM
21022011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
2103
2104 * keyboard.c (test_undefined): New function (bug#9751).
2105 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
2106
e112cc37
ET
21072011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
2108
2109 * sysdep.c (init_sys_modes): Fix the check for the controlling
2110 terminal (Bug#6649).
2111
7b5d6677
EZ
21122011-10-20 Eli Zaretskii <eliz@gnu.org>
2113
2114 * dispextern.h (struct bidi_it): New member next_en_type.
2115
2116 * bidi.c (bidi_line_init): Initialize the next_en_type member.
2117 (bidi_resolve_explicit_1): When next_en_pos is valid for the
2118 current character, check also for next_en_type being WEAK_EN.
2119 (bidi_resolve_weak): Don't enter the expensive loop if the current
2120 position is before next_en_pos. Record the bidi type of the first
2121 non-ET, non-BN character we find, in addition to its position.
2122 (bidi_level_of_next_char): Invalidate next_en_type when
2123 next_en_pos is over-stepped.
2124
7da0b018
PE
21252011-10-20 Paul Eggert <eggert@cs.ucla.edu>
2126
2127 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
2128 * editfns.c: Rewrite current-time-zone so that it invokes
2129 the equivalent of (format-time-string "%Z") to get the time zone name.
2130 This fixes a bug when the time zone name contains characters that
2131 need converting from the system time locale to Emacs internal format.
2132 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
2133 that patch fixed format-time-string to do the conversion, but
2134 I forgot to fix current-time-zone.
2135 (format_time_string): New function, containing most of
2136 what Fformat_time_string used to contain.
2137 (Fformat_time_string): Rewrite in terms of format_time_string.
2138 This doesn't change this function's behavior.
2139 (current-time-zone): Rewrite to use format_time_string.
2140 This fixes the bug reported by Michael Schierl in
2141 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
2142 Jason Rumney's 2007-06-07 change worked around this bug, but
2143 didn't fix it.
2144 * systime.h (tzname, timezone): Remove no-longer-used declarations.
2145
8547b010
EZ
21462011-10-19 Eli Zaretskii <eliz@gnu.org>
2147
2148 * xdisp.c (start_display): If the character at POS is displayed
2149 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
2150 (try_window_reusing_current_matrix): If a line ends in a display
2151 vector or the next line starts in a display vector, continue
2152 redrawing the window even though the character position of
2153 start_row was reached.
8547b010
EZ
2154 (Bug#9771, part 2)
2155
4e948d15
CY
21562011-10-18 Chong Yidong <cyd@gnu.org>
2157
2158 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
2159 with nobreak-char-display too.
2160
4787455f
EZ
21612011-10-18 Eli Zaretskii <eliz@gnu.org>
2162
2163 Fix part 3 of bug#9771.
2164 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
2165 (bidi_resolve_neutral): Don't enter the expensive loop looking for
2166 non-neutral characters if the current character is a paragraph
2167 separator (a.k.a. Newline). This avoids running the same
2168 expensive loop twice, once when we consume the preceding newline
2169 and the other time when the line actually needs to be displayed.
2170 Avoid the loop when we see neutrals on the base embedding level
2171 following a character whose directionality is the same as the
2172 paragraph's. This avoids running the expensive loop when a line
2173 ends in a long sequence of neutrals, like control characters.
2174 Add assertion against STRONG_AL type. Slightly rearrange code
2175 that determines the type of a neutral given the first non-neutral
2176 that follows it.
2177 (bidi_level_of_next_char): Set next_en_pos to zero when
2178 invalidating its info.
2179
2c91f553
EZ
21802011-10-17 Eli Zaretskii <eliz@gnu.org>
2181
2182 * xdisp.c (push_display_prop): Determine whether to record string
2183 or buffer position by IT->string, not by IT->method. Allow
2184 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
2185 (move_it_vertically_backward): Don't look for character position
2186 immediately after the newline when in a continuation line.
2187 (Bug#9771, part 1)
2c91f553 2188
c7b08b0d
MR
21892011-10-15 Martin Rudalics <rudalics@gmx.at>
2190
2191 * window.c (coordinates_in_window): Rewrite and delabelize
2192 vertical border check. (Bug#5357) (Bug#9618)
2193
6b02f655
SM
21942011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
2195
2196 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
2197 errors in XSetWindowBorder (bug#9310).
2198
81d40c92
DA
21992011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
2200
2201 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
2202 avoid crash when xmalloc overrun checking is enabled.
2203
d4172c3b
EZ
22042011-10-13 Eli Zaretskii <eliz@gnu.org>
2205
2206 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
2207 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
2208 cursor motion with <left> and <right> arrow keys.
2209
2210 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
2211 some callers set that themselves.
2212
b00eea75
EZ
22132011-10-12 Eli Zaretskii <eliz@gnu.org>
2214
2215 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
2216 display string and the previous row comes from the same string and
2217 is empty. (Bug#9739) (Bug#9738)
2218
8fe012c4
SM
22192011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
2220
2221 * doc.c (get_doc_string): Encode file name (bug#9735).
2222
0074aef2
EZ
22232011-10-12 Eli Zaretskii <eliz@gnu.org>
2224
79beb178
EZ
2225 * bidi.c (bidi_level_of_next_char):
2226 * xdisp.c (get_visually_first_element): Remove old incorrect
2227 comments regarding the Unicode Line Separator character.
2228
0074aef2
EZ
2229 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
2230
6e4b3fbe
DA
22312011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
2232
2233 * alloc.c (Fgc_status): Do not access beyond zombies array
2234 boundary if nzombies > MAX_ZOMBIES.
2235 * alloc.c (dump_zombies): Add missing format specifier.
2236
0324f3af
PE
22372011-10-12 Paul Eggert <eggert@cs.ucla.edu>
2238
b5525cac
PE
2239 * xdisp.c (set_cursor_from_row): Simplify conditionals,
2240 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
2241
0324f3af
PE
2242 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
2243 Some packages use them to denote characters with modifiers.
2244
e9b5f888
AS
22452011-10-11 Andreas Schwab <schwab@linux-m68k.org>
2246
2247 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
2248 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
2249 matching a pp-number. Rename parameter var to var1.
2250
127827c0
SM
22512011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
2252
2253 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
2254
c8fd3bd0
GM
22552011-10-08 Glenn Morris <rgm@gnu.org>
2256
2257 * callint.c (Fcall_interactively): Give a more explicit error for the
2258 'c' case with a non-character input. (Bug#8479)
2259
352ec8ff
EZ
22602011-10-08 Eli Zaretskii <eliz@gnu.org>
2261
03669ccb
EZ
2262 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
2263 lines.
7061c986
EZ
2264 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
2265 lines that are hscrolled on the left.
03669ccb 2266
352ec8ff
EZ
2267 * dispnew.c (buffer_posn_from_coords): Account for a possible
2268 presence of header-line. (Bug#4426)
2269
a66cfb1c
SM
22702011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
2271
6b02f655
SM
2272 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
2273 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 2274
7c5ee88e
PE
22752011-10-07 Paul Eggert <eggert@cs.ucla.edu>
2276
2277 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
2278 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
2279 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
2280 this makes Emacs dump core during garbage collection on rare
2281 occasions. sizeof is obviously inferior to offsetof here, so
2282 stick with offsetof.
2283 (GC_POINTER_ALIGNMENT): New macro.
2284 (mark_memory): Omit 3rd (offset) arg; caller changed.
2285 Don't assume EMACS_INT alignment is the same as pointer alignment.
2286
df1bbe5b
SM
22872011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
2288
2289 * keyboard.c (read_key_sequence_remapped): New var.
2290 (read_key_sequence): Compute remapping in the right buffer.
2291 (command_loop_1): Use read_key_sequence's remapping directly.
2292
51553db6
SM
22932011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
2294
32c1fffd
SM
2295 * dired.c (file_name_completion): Don't expand file name.
2296 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
2297 before checking file name handler.
2298
51553db6
SM
2299 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
2300 they've been requested explicitly (bug#9591).
2301
b6bd1599 23022011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
2303
2304 * keymap.c (Fsingle_key_description): Use make_specified_string
2305 instead of build_string to build string from push_key_description.
2306 (Bug#5193)
2307
f701dc2a
PE
23082011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2309
4222c55d
PE
2310 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
2311 This fixes a Y2038 bug on 64-bit hosts.
2312 * buffer.c (reset_buffer):
2313 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
2314 (Fclear_buffer_auto_save_failure):
2315 Use 0, not -1, to represent an unset failure time, since time_t
2316 might not be signed.
2317
f701dc2a
PE
2318 Remove dependency on glibc malloc internals.
2319 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2320 Move back here from lisp.h, but with their new implementations.
2321 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2322 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
2323 * charset.c (charset_table_init): New static var.
2324 (syms_of_charset): Use it instead of xmalloc. This removes a
2325 dependency on glibc malloc internals. See Eli Zaretskii's comment in
2326 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
2327 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2328 Move back to alloc.c.
2329 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2330 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
2331
9ceebf39
JD
23322011-09-30 Jan Djärv <jan.h.d@swipnet.se>
2333
2334 * nsterm.m (windowDidResize): Call x_set_window_size only when
2335 ns_in_resize is true. Otherwise set pixelwidth/height and
2336 call change_frame_size (Bug#9628).
2337
cb993c58
PE
23382011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2339
3930c88b
PE
2340 Port --enable-checking=all to Fedora 14 x86-64.
2341 * charset.c (syms_of_charset): Also account for glibc malloc's
2342 internal overhead when calculating the initial malloc maximum.
2343
cb993c58
PE
2344 Port --enable-checking=all to Fedora 14 x86.
2345 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2346 Move to lisp.h.
2347 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
2348 (overrun_check_realloc, overrun_check_free):
2349 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
2350 That way, xmalloc returns a properly-aligned pointer even if
2351 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
2352 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
2353 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
2354 into account when calculating the initial malloc maximum.
2355 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2356 Move here from alloc.c, so that charset.c can use it too.
2357 Properly align; the old code wasn't right for common 32-bit hosts
2358 when configured with --enable-checking=all.
2359 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2360 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
2361
31bed486
EZ
23622011-09-29 Eli Zaretskii <eliz@gnu.org>
2363
04c70788 2364 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
2365 use EDOM.
2366
fbcaa2f3
EZ
23672011-09-28 Eli Zaretskii <eliz@gnu.org>
2368
2369 * xdisp.c (compute_display_string_end): If there's no display
2370 string at CHARPOS, return -1.
2371
2372 * bidi.c (bidi_fetch_char): When compute_display_string_end
2373 returns a negative value, treat the character as a normal
2374 character not covered by a display string. (Bug#9624)
2375
a239d4e9
JB
23762011-09-28 Juanma Barranquero <lekktu@gmail.com>
2377
2378 * lread.c (Fread_from_string): Fix typo in docstring.
2379
88652fd5
EZ
23802011-09-27 Eli Zaretskii <eliz@gnu.org>
2381
2382 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2383 newline, reseat the iterator instead of bidi-iterating there one
2384 character at a time. (Bug#9610)
32c1fffd
SM
2385 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2386 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 2387
ed497dd4
AS
23882011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2389
2390 * lread.c (readevalloop): Use correct code for NBSP.
2391 (read1): Likewise. (Bug#9608)
2392
b2bf61aa
MA
23932011-09-25 Michael Albinus <michael.albinus@gmx.de>
2394
2395 * dbusbind.c (Fdbus_register_signal): When service is not
2396 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2397
32bbb17c
GM
23982011-09-25 Glenn Morris <rgm@gnu.org>
2399
2400 * buffer.c (truncate-lines): Doc fix.
2401
94e0933e
CY
24022011-09-24 Chong Yidong <cyd@stupidchicken.com>
2403
2404 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2405 (Fset_window_next_buffers): Doc fix.
2406
cddde921
GM
24072011-09-24 Glenn Morris <rgm@gnu.org>
2408
2409 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2410
1260aef1
PE
24112011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2412
25b4bfa0
PE
2413 Fix minor problems found by static checking.
2414 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
2415 * indent.c (Fvertical_motion): Fix == vs = typo.
2416
e3cbd34b
EZ
24172011-09-24 Eli Zaretskii <eliz@gnu.org>
2418
a66cfb1c
SM
2419 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2420 Default value is now t. Doc fix.
6bf7006f 2421
e3cbd34b 2422 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 2423 logic when moving up, not only when moving down. Fix the
e3cbd34b 2424 confusing name and values of the it_overshoot_expected variable;
32c1fffd 2425 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
2426
2427 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2428 CHARPOS is covered by a display string which includes newlines.
2429 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2430 is covered by a display string with embedded newlines.
2431
a3de0cbd
MA
24322011-09-24 Michael Albinus <michael.albinus@gmx.de>
2433
2434 * dbusbind.c (Fdbus_register_signal): Add match rule to
2435 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
2436 (Fdbus_register_method, Vdbus_registered_objects_table):
2437 Fix docstring.
a3de0cbd 2438
b260039d
JM
24392011-09-24 Jim Meyering <meyering@redhat.com>
2440
32c1fffd 2441 do not ignore write error for any output size
b260039d
JM
2442 The previous change was incomplete.
2443 While it makes emacs --batch detect the vast majority of stdout
2444 write failures, errors were still ignored whenever the output size is
2445 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2446 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2447 && echo FAIL: ignored write error
2448 FAIL: ignored write error
2449 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2450 && echo FAIL: ignored write error
2451 FAIL: ignored write error
2452 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2453
8eca8a7c
AS
24542011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2455
2456 * emacs.c (Fkill_emacs): In noninteractive mode exit
2457 non-successfully if a write error occurred on stdout. (Bug#9574)
2458
3341db62
EZ
24592011-09-21 Eli Zaretskii <eliz@gnu.org>
2460
2461 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2462 the xassert test.
2463
2464 * dispextern.h (struct it): Update the comment documenting what
2465 can it->OBJECT be.
2466
8c203dbf
EZ
24672011-09-20 Eli Zaretskii <eliz@gnu.org>
2468
2469 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2470 a display string, extend search for cursor position to end of row.
2471 (find_row_edges): If the row ends in a newline from a display
2472 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2473 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
2474 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2475 non-empty line. Fixes confusing cursor motion with arrow keys at
2476 the beginning of a line that starts with whitespace.
8c203dbf 2477
a4824228
LMI
24782011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2479
2480 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2481 (bug#9493).
2482
33ed493b
CY
24832011-09-18 Chong Yidong <cyd@stupidchicken.com>
2484
2485 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2486 boolean (Bug#9154).
2487
56cd55c8
EZ
24882011-09-18 Eli Zaretskii <eliz@gnu.org>
2489
2490 * xdisp.c (display_line): Record maximum and minimum buffer
2491 positions even if no glyphs were produced (e.g., by a zero-width
2492 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2493 buffer positions that will be removed from the glyph row because
2494 they don't fit.
c02dcedf
EZ
2495 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2496 column is beyond frame width: don't subtract 1 "pixel" when
2497 computing width of the stretch.
3e62b7e0
EZ
2498 (reseat_at_next_visible_line_start): Undo the change made on
2499 2011-09-17 that saved paragraph information and restored it after
2500 the call to `reseat'. (Bug#9545)
56cd55c8 2501
5ed99d36 25022011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
2503
2504 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2505 and turn window cursor on if cleared (Bug#9415).
2506
5ed99d36 25072011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
2508
2509 * search.c (boyer_moore): Take unibyte characters from pattern
2510 literally. (Bug#9458)
2511
9bade7b2
EZ
25122011-09-18 Eli Zaretskii <eliz@gnu.org>
2513
2514 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2515
e5e9d610
PE
25162011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2517
87e4427a
PE
2518 Fix minor problem found by static checking.
2519 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2520 initialized, to pacify gcc -Wuninitialized.
2521
e5e9d610
PE
2522 * fileio.c: Report proper errno when syscall falls.
2523 (Finsert_file_contents): Save and restore errno,
2524 so that report_file_error outputs the correct diagnostic.
2525 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2526
a1674f0b
EZ
25272011-09-18 Eli Zaretskii <eliz@gnu.org>
2528
2529 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2530
fbfb6dd4
EZ
25312011-09-17 Eli Zaretskii <eliz@gnu.org>
2532
2533 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2534 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2535
bb187662
EZ
25362011-09-17 Eli Zaretskii <eliz@gnu.org>
2537
1137e8b8 2538 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 2539 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
2540
2541 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2542 (bidi_find_paragraph_start): Search back for paragraph beginning
2543 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2544 (bidi_move_to_visually_next): Only trigger paragraph-related
2545 computations when the last character is a newline or at EOB, not
2546 just any NEUTRAL_B. (Bug#9470)
2547
bb187662
EZ
2548 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2549 truncated lines if point is covered by a display string. (Bug#9524)
2550
2e621251
PE
25512011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2552
2553 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2554 (cons_to_x_long): New function.
2555 (lisp_data_to_selection_data): Use it. Correct the test for
2556 short-versus-long data; it was negated. Break out of vector
2557 loop, for efficiency, when a long datum is discovered.
2558
91a15bc6
SM
25592011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2560
2561 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2562
b41c3a35
EZ
25632011-09-16 Eli Zaretskii <eliz@gnu.org>
2564
2565 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2566 GCC PR/17406) by declaring this function with external scope.
2567
7812ba2d
PE
25682011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2569
2570 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2571 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2572
cf7edc2a
AS
25732011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2574
2575 * editfns.c (Fformat): Correctly handle text properties on "%%".
2576
bd01620e
EZ
25772011-09-15 Eli Zaretskii <eliz@gnu.org>
2578
2579 * xterm.c (x_draw_composite_glyph_string_foreground):
2580 * w32term.c (x_draw_composite_glyph_string_foreground):
2581 * term.c (encode_terminal_code):
2582 * composite.c (composition_update_it, get_composition_id):
2583 * xdisp.c (get_next_display_element)
2584 (fill_composite_glyph_string): Add comments about special meaning
2585 of TAB characters in a composition.
2586
a02719a3
PE
25872011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2588
2589 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
2590 This occurs when processing a multibyte format.
2591 Problem reported by Wolfgang Jenker.
a02719a3 2592
72589a3c
JB
25932011-09-15 Johan Bockgård <bojohan@gnu.org>
2594
2595 * xdisp.c (try_cursor_movement): Only check for exact match if
2596 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2597
1c14176c
PE
25982011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2599
2600 Remove unused external symbols.
2601 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2602 * xdisp.c (calc_pixel_width_or_height): Now static.
2603 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2604 * indent.c (check_display_width):
2605 * w32term.c: Fix comment to match code.
2606 * xterm.c, xterm.h (x_catching_errors): Remove.
2607
d2eea5b5
PE
26082011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2609
2610 * xselect.c: Use signed conversions more consistently (Bug#9498).
2611 (selection_data_to_lisp_data): Assume incoming selection data are
2612 signed integers, not unsigned. This is to be consistent with
2613 outgoing selection data, which was modified to use signed integers
2614 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2615 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2616 expects long, not unsigned long.
2617
46888499
EZ
26182011-09-14 Eli Zaretskii <eliz@gnu.org>
2619
2620 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2621 computation of loop end. Reported by Johan Bockgård
2622 <bojohan@gnu.org>.
2623
ef8ef9fb
CY
26242011-09-13 Chong Yidong <cyd@stupidchicken.com>
2625
2626 * frame.c (Fother_visible_frames_p): Function deleted.
2627
fa819fed
EZ
26282011-09-12 Eli Zaretskii <eliz@gnu.org>
2629
2630 * indent.c (compute_motion): Process display vector front to back
2631 rather than the other way around. (Bug#2496)
2632
2ba8e008
SM
26332011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2634
2635 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2636
20f53c69
CY
26372011-09-11 Chong Yidong <cyd@stupidchicken.com>
2638
2639 * minibuf.c (Fread_from_minibuffer): Doc fix.
2640
d562d7a4
EZ
26412011-09-11 Eli Zaretskii <eliz@gnu.org>
2642
2643 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2644 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2645
1c4d7f3d
LMI
26462011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2647
2648 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2649 value for non-existent files.
2650
b885bf36
EZ
26512011-09-11 Eli Zaretskii <eliz@gnu.org>
2652
2653 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2654 set its "size" to -1. This will set the modtime_size field of
2655 the corresponding buffer to -1, which is what
2656 verify-visited-file-modtime expects for files that do not exist.
2657 (Bug#9139)
2658
6612f0bf
PE
26592011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2660
2661 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2662 here ...
2663 * lisp.h: ... from here. push_key_description is no longer
2664 defined in keyboard.c, so its declaration should not be in
2665 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2666 logically belongs with push_key_description.
2667
dfb3f755
PE
26682011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2669
2670 * buffer.h: Include <sys/types.h> instead of <time.h>.
2671 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2672 Problem reported by Herbert J. Skuhra.
2673
3134906c
LMI
26742011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2675
2676 * xml.c (parse_region): Make the parsing work for
2677 non-comment-starting XML files again (bug#9144).
2678
8d903f4e
AS
26792011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2680
2681 * image.c (gif_load): Fix calculation of bottom and right corner.
2682 (Bug#9468)
2683
80ad64f4
EZ
26842011-09-10 Eli Zaretskii <eliz@gnu.org>
2685
2686 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2687 redisplay in small windows.
2688
208a048d
EZ
26892011-09-09 Eli Zaretskii <eliz@gnu.org>
2690
2691 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2692
9b1c252e
MR
26932011-09-08 Martin Rudalics <rudalics@gmx.at>
2694
2695 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2696 Operate on live windows only.
2697
2949f33b
JB
26982011-09-08 Juanma Barranquero <lekktu@gmail.com>
2699
2700 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2701
e08dcafd
EZ
27022011-09-07 Eli Zaretskii <eliz@gnu.org>
2703
2704 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2705 only under bidi iteration.
2706
115b96bd
JD
27072011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2708
2709 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2710
c8199d0f
PE
27112011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2712
2713 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2714 Without this fix, the command to link temacs failed due to an
2715 undefined symbol __builtin_isnan. This is because
2716 /usr/include/iso/math_c99.h #defines isnan(x) to
2717 __builtin_isnan(x), but the bundled gcc, which identifies itself
2718 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2719 a __builtin_isnan.
2720 * floatfns.c (isnan): #undef, and then #define to a clone of
2721 what's in data.c.
2722 (Fisnan): Always define, since it's always available now.
2723 (syms_of_floatfns): Always define isnan at the Lisp level.
2724
e39b275c 27252011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
2726
2727 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2728
b2db44d9 27292011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 2730
f4af5137 2731 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
2732 The previous code assumed that file offsets (off_t values) fit in
2733 EMACS_INT variables, which is not true on typical 32-bit hosts.
2734 The code messed up by falsely reporting buffer overflow in cases
2735 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2736 when "big" contains more than 2**29 bytes, even though this
2737 inserts just one byte and does not overflow the buffer.
2738 (Finsert_file_contents): Store file offsets as off_t
2739 values, not as EMACS_INT values. Check for overflow when
2740 converting between EMACS_INT and off_t. When checking for
2741 buffer overflow or for overlap, take the offsets into account.
2742 Don't use EMACS_INT for small values where int suffices.
2743 When checking for overlap, fix a typo: ZV was used where
2744 ZV_BYTE was intended.
2745 (Fwrite_region): Don't assume off_t fits into 'long'.
2746 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2747
ecfc0a49
MA
27482011-09-05 Michael Albinus <michael.albinus@gmx.de>
2749
2750 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2751
6511acf2 27522011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 2753
0999621a 2754 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
2755
2756 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 2757 (esprintf, exprintf, evxprintf): New functions.
62f19c19 2758 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 2759 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
2760 (modify_event_symbol): Do not assume that the length of
2761 name_alist_or_stem is safe to alloca and fits in int.
2762 (Fexecute_extended_command): Likewise for function name and binding.
2763 (Frecursion_depth): Wrap around reliably on integer overflow.
2764 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2765 since some callers pass EMACS_INT values.
2766 (Fsingle_key_description): Don't crash if symbol name contains more
2767 than MAX_ALLOCA bytes.
2768 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2769 (get_minibuffer): Arg is now EMACS_INT, not int.
2770 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 2771 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
2772 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2773
2be7d702
PE
2774 * dbusbind.c (signature_cat): New function.
2775 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
2776 Do not overrun buffer; instead, report string overflow.
2777
9d1df220
PE
2778 * dispnew.c (add_window_display_history): Don't overrun buffer.
2779 Truncate instead; this is OK since it's just a log.
2780
33ef5c64
PE
2781 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2782 even if the time zone offset is outlandishly large.
2783 Don't mishandle offset == INT_MIN.
2784
66c6fdd5
PE
2785 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2786 when creating daemon; the previous buffer-overflow check was incorrect.
2787
d749b01b
PE
2788 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2789 which has the guts of the old verror function.
2790
b5cd1905
PE
2791 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2792 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2793
6e1a67fb
PE
2794 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2795 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 2796 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 2797 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
2798 length of string rather than counting it via multiple sprintfs;
2799 that's simpler and more reliable.
c21721cc
PE
2800 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2801 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2802 sprintf, in case result does not fit in int.
2803
c57b67fc
PE
2804 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2805 (fontset_from_font): Print it.
2806
8a401434
PE
2807 * frame.c (tty_frame_count): Now printmax_t, not int.
2808 (make_terminal_frame, set_term_frame_name): Print it.
2809 (x_report_frame_params): In X, window IDs are unsigned long,
2810 not signed long, so print them as unsigned.
2811 (validate_x_resource_name): Check for implausibly long names,
2812 and don't assume name length fits in 'int'.
2813 (x_get_resource_string): Don't blindly alloca invocation name;
2814 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2815 not fit in int.
2816
6e1a67fb
PE
2817 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2818 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
2819 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2820
0df02bf3
PE
2821 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2822 Use esprintf, not sprintf, in case result does not fit in int.
2823
48e30793
PE
2824 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2825 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2826 it as a large positive number.
2827 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2828 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2829
a66ff6d8
PE
2830 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2831 in case result does not fit in int.
2832
aca216ff
PE
2833 * print.c (float_to_string): Detect width overflow more reliably.
2834 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2835 buffer overrun. Don't assume list length fits in 'int'. Treat
2836 print length of 0 as 0, not as infinity; to be consistent with other
2837 uses of print length in this function. Don't overflow print length
2838 index. Don't assume hash table size fits in 'long', or that
2839 vectorlike size fits in 'unsigned long'.
2840
31c286f7
PE
2841 * process.c (make_process): Use printmax_t, not int, to format
2842 process-name gensyms.
2843
55e5faa1
PE
2844 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2845
80f2e268
PE
2846 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2847 to avoid potential buffer overrun.
2848
670741ab
PE
2849 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2850 if X resource line is longer than 512 bytes.
2851
b7163a50
PE
2852 * xfns.c (x_window): Make sprintf buffer a bit bigger
2853 to avoid potential buffer overrun.
2854
ae58ff1f
PE
2855 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2856
c43c8a6a
PE
2857 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2858
3f8236f4
PE
28592011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2860
53e9fe90 2861 Integer overflow fixes for scrolling, etc.
6511acf2
PE
2862 Without these, Emacs silently mishandles large integers sometimes.
2863 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
2864 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2865
6511acf2
PE
2866 * xdisp.c (try_window_id): Check Emacs fixnum range before
2867 converting to 'int'.
806add1d 2868
6511acf2 2869 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
2870 Check that an Emacs fixnum is in range before assigning it to 'int'.
2871 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2872 values converted from Emacs fixnums.
2873 (Frecenter): Don't wrap around a line count if it is out of 'int'
2874 range; instead, treat it as an extreme value.
2875 (Fset_window_configuration, compare_window_configurations):
2876 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2877
6511acf2
PE
2878 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2879 that can exceed INT_MAX. Check that EMACS_INT value is in range
2880 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
2881 (match_limit): Don't assume that a fixnum can fit in 'int'.
2882
6511acf2 2883 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
2884 exceed INT_MAX.
2885
6511acf2 2886 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
2887 (Fvertical_motion): Don't wrap around LINES values that don't fit
2888 in 'int'. Instead, treat them as extreme values. This is good
2889 enough for windows, which can't have more than INT_MAX lines anyway.
2890
fcb901a7
LMI
28912011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2892
0f2f6b6d
LMI
2893 * Require libxml/parser.h to avoid compilation warning.
2894
fcb901a7
LMI
2895 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2896
2897 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2898 since this reportedly can destroy thread storage.
2899
6e20a0d4
CY
29002011-08-30 Chong Yidong <cyd@stupidchicken.com>
2901
2902 * syntax.c (find_defun_start): Update all cache variables if
2903 exiting early (Bug#9401).
2904
148ae00e
EZ
29052011-08-30 Eli Zaretskii <eliz@gnu.org>
2906
f6cfbd8f
EZ
2907 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2908
148ae00e
EZ
2909 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2910 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2911 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2912
2913 * term.c (tty_append_glyph): New function.
2914 (produce_stretch_glyph): Static function and its prototype deleted.
2915
a66cfb1c
SM
2916 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2917 Add prototypes.
148ae00e 2918
c4a07a4c
PE
29192011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2920
2921 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2922 when checking :margin (Bug#9390).
2923 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 2924 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
2925 so that the name doesn't mislead. All uses changed.
2926
6bc8cd65
JB
29272011-08-28 Johan Bockgård <bojohan@gnu.org>
2928
2929 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2930 set_tty_hooks.
2931
dca4927e
EZ
29322011-08-27 Eli Zaretskii <eliz@gnu.org>
2933
2934 * xdisp.c (move_it_to): Don't bail out early when reaching
2935 position beyond to_charpos, if we are scanning backwards.
2936 (move_it_vertically_backward): When DY == 0, make sure we get to
2937 the first character in the line after the newline.
2938
f2cad773
PE
29392011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2940
2941 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2942 (ccl_driver): Do not generate an out-of-range pointer.
2943 (Fccl_execute_on_string): Remove unnecessary check for
2944 integer overflow, noted by Stefan Monnier in
2945 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2946 Remove a FIXME that didn't need fixing.
2947 Simplify the newly-introduced buffer reallocation code.
2948
0cae2cdb
JB
29492011-08-27 Juanma Barranquero <lekktu@gmail.com>
2950
2951 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2952
5fc295a4 29532011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 2954
70c60eb2 2955 Integer and memory overflow issues (Bug#9196).
726e0ab1 2956
d31850da
PE
2957 * doc.c (get_doc_string): Rework so that
2958 get_doc_string_buffer_size is the actual buffer size, rather than
2959 being 1 less than the actual buffer size; this makes xpalloc more
2960 convenient.
2961
a69fbedb
PE
2962 * image.c (x_allocate_bitmap_record, cache_image):
2963 * xselect.c (Fx_register_dnd_atom):
2964 Simplify previous changes by using xpalloc.
2965
fe5c5d37
PE
2966 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2967 since either will do and ptrdiff_t is convenient with xpalloc.
2968
0065d054
PE
2969 * charset.c (charset_table_size)
2970 (struct charset_sort_data.priority): Now ptrdiff_t.
2971 (charset_compare): Don't overflow if priorities differ greatly.
2972 (Fsort_charsets): Don't assume list length fits in int.
2973 Check for size-calculation overflow when allocating sort data.
2974 (syms_of_charset): Allocate an initial charset table that is
2975 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2976
2977 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2978
2979 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2980 The actual value is always <= INT_MAX, and leaving it unsigned made
2981 overflow checking harder.
2982
2983 * dispextern.h (struct glyph_matrix.rows_allocated)
2984 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2985 with xpalloc. The values are still always <= INT_MAX.
2986
2987 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2988
2989 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2990 (SAFE_NALLOCA): New macro.
2991
2992 * region-cache.c (struct boundary.pos, find_cache_boundary)
2993 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2994 (set_cache_region, invalidate_region_cache)
2995 (revalidate_region_cache, know_region_cache, region_cache_forward)
2996 (region_cache_backward, pp_cache):
2997 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2998 so that ptrdiff_t * can be passed to xpalloc.
2999 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
3000 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
3001 (pp_cache): Don't assume cache_len fits in int.
3002 * region-cache.h: Adjust extern decls to match.
3003
3004 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
3005 EMACS_INT, since either will do, for xpalloc.
3006
3007 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
3008 (xnmalloc, xnrealloc, xpalloc): New functions.
3009
726e0ab1
PE
3010 * bidi.c (bidi_shelve_header_size): New constant.
3011 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
3012 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
3013
51f30bc5 3014 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
3015 * buffer.c (overlays_at, overlays_in, record_overlay_string)
3016 (overlay_strings):
3017 Don't update size of array until after memory allocation succeeds,
3018 because xmalloc/xrealloc may not return.
0065d054
PE
3019 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
3020 now that we have proper integer overflow checking.
3021 (record_overlay_string, overlay_strings): Catch overflows when
3022 calculating size of overlay_str_buf.
726e0ab1 3023
0065d054
PE
3024 * callproc.c (Fcall_process): Check for size overflow when
3025 calculating size of args2.
3026 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
3027 Normally we prefer signed values, but sticking with ptrdiff_t would
3028 require adding more-complicated checks.
726e0ab1
PE
3029
3030 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
3031 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
3032 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 3033 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
3034
3035 * character.c (Fstring): Check for size-calculation overflow.
3036
3037 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
3038 unnecessary integer overflow. Check for size overflow.
3039 (encode_coding_object): Don't update size until xmalloc succeeds.
3040
3041 * composite.c (get_composition_id): Check for overflow in glyph
3042 length calculations.
3043
3044 Integer and memory overflow fixes for display code.
3045 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
3046 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
3047 (scrolling_window): Check for overflow in size calculations.
3048 (line_draw_cost, realloc_glyph_pool, add_row_entry):
3049 Don't assume glyph table len fits in int.
3050 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
3051 (row_table_size): Now ptrdiff_t, not int.
3052 (scrolling_window): Avoid overflow in size calculations.
3053 Don't update size until allocation succeeds.
3054 * fns.c (concat): Check for overflow in size calculations.
3055 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
3056 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3057 (NEXT_ALMOST_PRIME_LIMIT): New constant.
3058
3059 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
3060 (get_doc_string): Check for size calculation overflow.
3061 Don't update size until allocation succeeds.
3062 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
3063 EMACS_INT, where ptrdiff_t will do.
3064 (Fsubstitute_command_keys): Check for string overflow.
3065
3066 * editfns.c (set_time_zone_rule): Don't assume environment length
3067 fits in int.
3068 (message_length): Now ptrdiff_t, not int.
3069 (Fmessage_box): Don't update size until allocation succeeds.
3070 Don't assume message length fits in int.
3071 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
3072
0065d054
PE
3073 * emacs.c (main): Do not reallocate argv, since there is a null at
3074 the end that can be overwritten, and this way there's no need to
3075 worry about size-calculation overflow.
3076 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
3077
3078 * eval.c (init_eval_once, grow_specpdl): Don't update size until
3079 alloc succeeds.
3080 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
3081
3082 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
3083 (x_set_scroll_bar_width, x_figure_window_size):
3084 Check for integer overflow.
3085 (x_set_alpha): Do not assume XINT fits in int.
3086
3087 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
3088 This is for the members text_lines, text_cols, total_lines, total_cols,
3089 where the system imposes an 'int' limit.
3090
3091 * fringe.c (Fdefine_fringe_bitmap):
3092 Don't update size until alloc works.
3093
3094 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
3095 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
3096
3097 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
3098 Check for size-calculation overflow.
3099 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
3100 do, as we prefer signed integers.
3101 (id_to_widget.max_size, id_to_widget.used)
3102 (xg_store_widget_in_map, xg_remove_widget_from_map)
3103 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
3104 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
3105 Use and return ptrdiff_t, not int.
3106 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
3107 * gtkutil.h: Change prototypes to match the above.
3108
3109 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
3110 are duplicate now that they've been promoted to lisp.h.
3111 (x_allocate_bitmap_record, x_alloc_image_color)
3112 (make_image_cache, cache_image, xpm_load):
3113 Don't update size until alloc is done.
3114 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
3115 (x_detect_edges):
3256efce 3116 Check for size calculation overflow.
726e0ab1
PE
3117 (ct_colors_allocated_max): New constant.
3118 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
3119 overflow.
3256efce 3120
726e0ab1
PE
3121 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
3122 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
3123 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
3124 Use ptrdiff_t, not int, to count maps.
3125 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
3126 calculations. Don't update size until allocation succeeds.
3127 Redo calculations to avoid overflow.
726e0ab1
PE
3128 * keyboard.h: Change prototypes to match the above.
3129
3130 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
3131 to count maps.
3132 (current_minor_maps): Check for size calculation overflow.
3133 * keymap.h: Change prototypes to match the above.
3134
3135 * lread.c (read1, init_obarray): Don't update size until alloc done.
3136
3137 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
3138 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
3139
726e0ab1
PE
3140 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
3141 Now ptrdiff_t, not int.
3142 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
3143 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
3144
3145 * process.c (Fnetwork_interface_list): Check for overflow
3146 in size calculation.
3147
3148 * region-cache.c (move_cache_gap): Check for size calculation overflow.
3149
3150 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
3151 overflow. Don't bother calling xmalloc when xrealloc will do.
3152
3153 * search.c (Freplace_match): Check for size calculation overflow.
3154 (Fset_match_data): Don't assume list lengths fit in 'int'.
3155
3156 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
3157 for command line length. Do not attempt to address one before the
3158 beginning of an array, as that's not portable.
3159
3160 * term.c (max_frame_lines): Remove; unused.
3161 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
3162 not int.
3163 (encode_terminal_code, calculate_costs): Check for size
3164 calculation overflow.
3165 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
3166 table lengths and related sizes. Don't update size until alloc
3167 done. Redo calculations to avoid overflow.
3168 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
3169
3170 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
3171 subtracting pointers.
3172 (gobble_line): Check for overflow more carefully. Don't update size
3173 until alloc done.
3174
3175 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
3176 Don't update size until alloc done.
3177 Redo size calculations to avoid overflow.
3178 Check for size calculation overflow.
0065d054 3179 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
3180
3181 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
3182 Use ptrdiff_t, not int, for sizes.
3183 (store_mode_line_noprop_char): Don't update size until alloc done.
3184
0065d054
PE
3185 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
3186 Use ptrdiff_t, not int, for sizes.
3187 (Finternal_make_lisp_face, cache_face):
3188 Check for size calculation overflow.
3189 (cache_face): Treat size calculation overflows as if they were
3190 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
3191
3192 * xfns.c (x_encode_text, x_set_name_internal)
3193 (Fx_change_window_property): Use ptrdiff_t, not int, to count
3194 sizes, since they can exceed INT_MAX in size. Check for size
3195 calculation overflow.
3196
0065d054
PE
3197 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
3198 (xg_select): Check for size calculation overflow.
726e0ab1
PE
3199 Don't update size until alloc done.
3200
0065d054 3201 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 3202 as sprintf is limited to int lengths.
1d526e2f 3203
252c5ee1
PE
3204 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
3205 (X_LONG_MIN): New macros.
864d7ce7
PE
3206 Use them to make the following changes clearer.
3207 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
3208 This change doesn't affect the value now, but it may help remind
3209 future maintainers not to raise the value too much later.
3210 (SELECTION_QUANTUM): Remove, replacing with ...
3211 (selection_quantum): ... new function, which avoids overflow.
3212 All uses changed.
3213 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
3214 assumption that selection length fits in 'int'.
3215 (x_reply_selection_request, x_handle_selection_request)
3216 (x_get_window_property, receive_incremental_selection)
3217 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
3218 (lisp_data_to_selection_data, clean_local_selection_data):
3219 Use ptrdiff_t, not int, to record length of selection.
3220 (x_reply_selection_request, x_get_window_property)
3221 (receive_incremental_selection, x_property_data_to_lisp):
3222 Redo calculations to avoid overflow.
3223 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 3224 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
3225 something.
3226 (x_get_window_property, receive_incremental_selection)
3227 (lisp_data_to_selection_data, x_property_data_to_lisp):
3228 Check for size-calculation overflow.
3229 (x_get_window_property, receive_incremental_selection)
3230 (lisp_data_to_selection_data, Fx_register_dnd_atom):
3231 Don't store size until memory allocation succeeds.
3232 (x_get_window_property): Plug memory leak on memory exhaustion.
3233 Don't double-block input; malloc is safe here. Don't assume 2**34
3234 - 4 fits in unsigned long. Add an xassert to check
3235 XGetWindowProperty overflow. Be more careful about overflow
3236 calculations, and distinguish size from memory overflow better.
3237 (receive_incremental_selection): When tracing, don't assume
3238 unsigned int is less than INT_MAX.
3239 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
3240 harmful) conversions of unsigned short to int.
3241 (lisp_data_to_selection_data): Don't assume that integers
3242 in the range -65535 through -1 fit in an X unsigned short.
3243 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
3244 result parameters unless successful. Rely on cons_to_unsigned
3245 to report problems with elements; the old code wasn't right anyway.
3246 (x_check_property_data): Check for int overflow; we cannot use
3247 a wider type due to X limits.
3248 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
3249
726e0ab1 3250 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 3251
0065d054
PE
3252 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
3253 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
3254 (x_color_cells): Don't store size until memory allocation succeeds.
3255 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 3256 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
3257 (x_term_init): Don't assume length fits in int (sprintf is limited
3258 to int size).
bc18e09d 3259
ebfa62c0
PE
3260 Use ptrdiff_t for composition IDs.
3261 * character.c (lisp_string_width):
3262 * composite.c (composition_table_size, n_compositions)
3263 (get_composition_id, composition_gstring_from_id):
3264 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
3265 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
3266 * window.c (Frecenter):
3267 Use ptrdiff_t, not int, for composition IDs.
3268 * composite.c (get_composition_id): Check for integer overflow.
3269 * composite.h: Adjust prototypes to match the above changes.
3270
d3411f89
PE
3271 Use ptrdiff_t for hash table indexes.
3272 * category.c (hash_get_category_set):
3273 * ccl.c (ccl_driver):
3274 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
3275 * coding.c (coding_system_charset_list, detect_coding_system):
3276 * coding.h (struct coding_system.id):
3277 * composite.c (get_composition_id, gstring_lookup_cache):
3278 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
3279 * image.c (xpm_get_color_table_h):
3280 * lisp.h (hash_lookup, hash_put):
3281 * minibuf.c (Ftest_completion):
3282 Use ptrdiff_t for hash table indexes, not int (which is too
3283 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
3284 32-bit --with-wide-int hosts).
3285
e097a6fa
PE
3286 * charset.c (Fdefine_charset_internal): Check for integer overflow.
3287 Add a FIXME comment about memory leaks.
3288 (syms_of_charset): Don't assume xmalloc returns.
3289
5637687f
PE
3290 Don't assume that stated character widths fit in int.
3291 * character.c (Fchar_width, c_string_width, lisp_string_width):
3292 * character.h (CHAR_WIDTH):
3293 * indent.c (MULTIBYTE_BYTES_WIDTH):
3294 Use sanitize_char_width to avoid undefined and/or bad behavior
3295 with outlandish widths.
a66cfb1c 3296 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
3297 now that we have two such functions. All uses changed.
3298 (sanitize_char_width): New inline function.
3299
a2271ba2
PE
3300 Don't assume that tab-width fits in int.
3301 * character.h (sanitize_width): New inline function.
3302 (SANE_TAB_WIDTH): New macro.
3303 (ASCII_CHAR_WIDTH): Use it.
3304 * indent.c (sane_tab_width): Remove. All uses replaced by
3305 SANE_TAB_WIDTH (current_buffer).
3306 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
3307
18c52557
PE
3308 * fileio.c: Integer overflow issues with file modes.
3309 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
3310
caeeedc1
PE
3311 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
3312 Remove unreachable code.
3313 (read_hex, load_charset_map_from_file): Check for integer overflow.
3314
6df6ae42 3315 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
3316 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
3317 (x_send_scroll_bar_event): Likewise. Check that the size does not
3318 exceed limits imposed by XClientMessageEvent, as well as the usual
3319 ptrdiff_t and size_t limits.
3320
b13995db
PE
3321 * keyboard.c: Overflow, signedness and related fixes.
3322 (make_lispy_movement): Use same integer type in forward decl
3323 that is used in the definition.
3324 (read_key_sequence, keyremap_step):
3325 Change bufsize argument back to int, undoing my 2011-03-30 change.
3326 We prefer signed types, and int is wide enough here.
3327 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
3328 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
3329 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
3330 length, not size_t. Use ptrdiff_t for index, not int.
3331 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
3332 possibility of integer overflow.
3333
13464394
PE
3334 Overflow, signedness and related fixes for images.
3335
3336 * dispextern.h (struct it.stack[0].u.image.image_id)
3337 (struct_it.image_id, struct image.id, struct image_cache.size)
3338 (struct image_cache.used, struct image_cache.ref_count):
3339 * gtkutil.c (update_frame_tool_bar):
3340 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
3341 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
3342 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
3343 * nsmenu.m (update_frame_tool_bar):
3344 * xdisp.c (calc_pixel_width_or_height):
3345 * xfns.c (image_cache_refcount):
3346 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
3347 on typical 64-bit hosts.
3348
3349 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3350 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
3351 Omit unnecessary casts to int.
3352 (parse_image_spec): Check that integers fall into 'int' range
3353 when the callers expect that.
3354 (image_ascent): Redo ascent calculation to avoid int overflow.
3355 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
3356 (lookup_image): Remove unnecessary tests.
3357 (xbm_image_p): Locals are now of int, not EMACS_INT,
3358 since parse_image_check makes sure they fit into int.
3359 (png_load, gif_load, svg_load_image):
3360 Prefer int to unsigned where either will do.
3361 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
3362 old tiff_error_handler and tiff_warning_handler.
3363 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
3364 stack buffer overflows. It uses only the features of vsnprintf
3365 that are common to both POSIX and native Microsoft.
3366 (tiff_error_handler, tiff_warning_handler): Use it.
3367 (tiff_load, gif_load, imagemagick_load_image):
3368 Don't assume :index value fits in 'int'.
3369 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
3370 (imagemagick_load_image): Check that crop parameters fit into
3371 the integer types that MagickCropImage accepts. Don't assume
3372 Vimagemagick_render_type has a nonnegative value. Don't assume
3373 size_t fits in 'long'.
3374 (gs_load): Use printmax_t to print the widest integers possible.
3375 Check for integer overflow when computing image height and width.
3376
c11821d4
EZ
33772011-08-26 Eli Zaretskii <eliz@gnu.org>
3378
3379 * xdisp.c (redisplay_window): Don't force window start if point
3380 will be invisible in the resulting window. (Bug#9324)
3381
0c95fcf7
EZ
33822011-08-25 Eli Zaretskii <eliz@gnu.org>
3383
3384 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3385 the display spec is of the form `(space ...)'.
3386 (handle_display_spec): Return the value returned by
3387 handle_single_display_spec, not just 1 or zero.
3388 (handle_single_display_spec): If the display spec is of the form
3389 `(space ...)', and specifies display in the text area, return 2
3390 rather than 1.
fee65a97 3391 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
3392 accurately, and prefer exact match for point under bidi.
3393 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
3394
3395 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3396 into disp_prop; all users changed.
3397
3398 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3399 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3400 for the text covered by the display property.
3401
e4ed06f1
CY
34022011-08-25 Chong Yidong <cyd@stupidchicken.com>
3403
3404 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3405 Change return value to nil.
3406 (Frecord_buffer): Delete unused function.
3407
f67cdd7f
EZ
34082011-08-24 Eli Zaretskii <eliz@gnu.org>
3409
5980d4c6
EZ
3410 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3411 buffers, return left-to-right.
8610fe8b
EZ
3412 (set_cursor_from_row): Consider candidate row a win if its glyph
3413 represents a newline and point is on that newline. Fixes cursor
3414 positioning on the newline at EOL of R2L text within L2R
3415 paragraph, and vice versa.
3416 (try_cursor_movement): Check continued rows, in addition to
3417 continuation rows. Fixes unwarranted scroll when point enters a
3418 continued line of R2L text within an L2R paragraph, or vice versa.
3419 (cursor_row_p): Consider the case of point being equal to
3420 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3421 from the end of a short line to the beginning of a continued line
3422 of R2L text within L2R paragraph.
3423 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3424 composed characters.
5980d4c6 3425
f67cdd7f
EZ
3426 * bidi.c (bidi_check_type): Use xassert.
3427 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3428 members.
3429
bca633fb
EZ
34302011-08-23 Eli Zaretskii <eliz@gnu.org>
3431
3432 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3433 a character.
3434
4a5885a7
CY
34352011-08-23 Chong Yidong <cyd@stupidchicken.com>
3436
3437 * nsfont.m (ns_otf_to_script): Fix typo.
3438
0902a04e
KH
34392011-08-22 Kenichi Handa <handa@m17n.org>
3440
3441 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3442 extra slot even if the purpose is char-code-property-table.
3443
1a2e6670
EZ
34442011-08-23 Eli Zaretskii <eliz@gnu.org>
3445
8ddde651
EZ
3446 * xdisp.c (redisplay_window): When computing centering_position,
3447 account for the height of the header line. (Bug#8874)
3448
425cc014
EZ
3449 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3450 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3451 candidate is selected by the mouse, and that candidate has a
3452 composed character under the mouse.
3453
1a2e6670
EZ
3454 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3455 coordinates reported by pos-visible-in-window-p for a composed
3456 character in column zero.
3457
8b76d6f8
SM
34582011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3459
3460 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3461
dac347dd
EZ
34622011-08-22 Eli Zaretskii <eliz@gnu.org>
3463
3464 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3465 consider it a hit if to_charpos is anywhere in the range of the
3466 composed buffer positions.
3467
e013fb34
CY
34682011-08-22 Chong Yidong <cyd@stupidchicken.com>
3469
3470 * image.c (gif_load): Don't assume that each subimage has the same
3471 dimensions as the base image. Handle disposal method that is
3472 "undefined" by the gif spec (Bug#9335).
3473
bd1ba3e8
CY
34742011-08-20 Chong Yidong <cyd@stupidchicken.com>
3475
3476 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 3477 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 3478
54a1215b
EZ
34792011-08-19 Eli Zaretskii <eliz@gnu.org>
3480
823564e5
EZ
3481 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3482 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3483 from an Org mode buffer to a Speedbar frame.
3484
54a1215b
EZ
3485 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3486 a composition, take its buffer position from IT->cmp_it.charpos.
3487 Fixes cursor positioning at the beginning of a line that begins
3488 with a composed character.
3489
9778ebcc
EZ
34902011-08-18 Eli Zaretskii <eliz@gnu.org>
3491
0be6ee06
EZ
3492 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3493 character bidirectional type, use STRONG_L instead. Fixes crashes
3494 in a buffer produced by `describe-categories'.
3495
9778ebcc
EZ
3496 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3497 members before the level stack, so they would be saved and
3498 restored when copying iterator state. Fixes incorrect reordering
3499 around TABs covered by display properties.
3500
156bffbe
AS
35012011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3502
6b02f655 3503 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 3504
72ad093b
CY
35052011-08-17 Chong Yidong <cyd@stupidchicken.com>
3506
3507 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
3508 (internal_condition_case_2, internal_condition_case_n):
3509 Remove unnecessary aborts (Bug#9081).
72ad093b 3510
35774242
EZ
35112011-08-17 Eli Zaretskii <eliz@gnu.org>
3512
3513 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3514 has no `load' handler, try opening the file locally. (Bug#9311)
3515
db76dd85
KB
35162011-08-16 Ken Brown <kbrown@cornell.edu>
3517
3518 * gmalloc.c: Expand comment.
3519
b215eee5
EZ
35202011-08-16 Eli Zaretskii <eliz@gnu.org>
3521
3522 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3523 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3524
a4579d33
KB
35252011-08-16 Ken Brown <kbrown@cornell.edu>
3526
3527 Fix memory allocation problems in Cygwin build (Bug#9273).
3528
3529 * unexcw.c ( __malloc_initialized): Declare external variable.
3530 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3531
8b76d6f8
SM
3532 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3533 New variables.
a4579d33
KB
3534 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3535 dumped emacs.
3536 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3537 in the static heap.
3538 [CYGWIN] (special_realloc): New function.
3539 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3540 requests to realloc storage in the static heap.
3541
3ebec551
PE
35422011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3543
3544 * bidi.c (bidi_initialize): Remove unused local.
3545
9fd8be00
EZ
35462011-08-15 Eli Zaretskii <eliz@gnu.org>
3547
6b02f655
SM
3548 * bidimirror.h:
3549 * biditype.h: Remove file.
3550 * makefile.w32-in ($(BLD)/bidi.$(O)):
3551 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
3552
3553 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3554
3555 * chartab.c: Improve commentary for the uniprop_table API.
3556
32413314
EZ
3557 * bidi.c (bidi_paragraph_init): Support zero value of
3558 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
3559 (bidi_initialize): Use uniprop_table instead of including
3560 biditype.h and bidimirror.h.
32413314 3561
9fd8be00
EZ
3562 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3563 coordinates of the iterator when restoring from ppos_it.
3564 (Bug#9296)
3565
5cf2b69b
KH
35662011-08-14 Kenichi Handa <handa@m17n.org>
3567
3568 * process.c (create_process): Call setup_process_coding_systems
72ad093b 3569 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 3570
daf17d00
EZ
35712011-08-14 Eli Zaretskii <eliz@gnu.org>
3572
3573 * xdisp.c (move_it_in_display_line_to): Don't invoke
3574 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3575 ppos_it. Fixes vertical cursor motion when line beginning is
3576 covered by an image. (Bug#9296)
3577
08e3161a
JD
35782011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3579
3580 * nsterm.h (ns_run_ascript): Declare.
3581 (NSAPP_DATA2_RUNASSCRIPT): Define.
3582
3583 * nsfns.m (as_script, as_result, as_status): New static variables.
3584 (ns_run_ascript): New function.
5e617bc2 3585 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
3586 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3587 the event loop. Get status from as_status (Bug#7276).
3588
3589 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3590 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3591 the event loop (Bug#7276).
3592
a3720aa2
AS
35932011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3594
3595 * gnutls.c (QCgnutls_bootprop_priority)
3596 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3597 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3598 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3599 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3600 (QCgnutls_bootprop_verify_hostname_error)
3601 (QCgnutls_bootprop_callbacks_verify): Rename from
3602 Qgnutls_bootprop_..., all uses changed.
3603
3604 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3605 uses changed.
3606
0a0d27fb
PE
36072011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3608
19d5c50c
PE
3609 * xfaces.c (Qframe_set_background_mode): Now static.
3610 * dispextern.h (Qframe_set_background_mode): Remove decl.
3611
0a0d27fb
PE
3612 * process.c (Fnetwork_interface_info): Declare local only if needed.
3613
377538cb
JD
36142011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3615
3616 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3617 (Fnetwork_interface_list): Allocate in increments of bytes instead
3618 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3619 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3620 sockaddr.
3621 (struct ifflag_def): notrailers is smart on OSX.
3622 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3623 Get hardware address with getifaddrs if available.
3624
08fff70c
EZ
36252011-08-12 Eli Zaretskii <eliz@gnu.org>
3626
3627 * xdisp.c (iterate_out_of_display_property): xassert that
3628 IT->position is set to within IT->object's boundaries. Break from
3629 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
3630 when IT->position is set up wrongly due to some bug.
3631 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
3632 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3633 entry. Force push_it to save on the stack the current
3634 buffer/string position, to be restored by pop_it. Fix flags in
3635 the iterator structure wrt the object coming from a display
3636 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3637 properties. (Bug#9284)
3638
7be1c708 36392011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 3640
7be1c708
CY
3641 * fontset.c (fontset_get_font_group): Add proper type checks.
3642 (Bug#9172)
aac0c6e3 3643
7be1c708 36442011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 3645
7be1c708
CY
3646 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3647 and LC_VERSION_MIN_MACOSX.
3648 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3649 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 3650
97bb72a6
EZ
36512011-08-08 Eli Zaretskii <eliz@gnu.org>
3652
3653 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
3654 no-display-properties-and-no-overlays under bidi display.
3655 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 3656 properties and overlays.
97bb72a6 3657
d5617611
CY
36582011-08-08 Chong Yidong <cyd@stupidchicken.com>
3659
37e11a63
CY
3660 * editfns.c (Fset_time_zone_rule): Document relationship with the
3661 setenv function.
3662
d5617611
CY
3663 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3664 the font entity extracted from the cache (Bug#8109).
3665
58872834
CY
36662011-08-07 Chong Yidong <cyd@stupidchicken.com>
3667
3668 * composite.c (autocmp_chars): Don't reset point. That is done by
3669 restore_point_unwind (Bug#5984).
3670
75bfc667
JL
36712011-08-07 Juri Linkov <juri@jurta.org>
3672
3673 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3674 to show the arg `TIME' instead of `TIMEVAL'.
3675
d1410150
EZ
36762011-08-06 Eli Zaretskii <eliz@gnu.org>
3677
3678 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3679 display property strides EOL and includes a newline, as in
3680 longlines-mode. (Bug#9254)
75b771e4
EZ
3681 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3682 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
3683
3684 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3685 is non-zero, even if the data buffer is NULL. Fixes a crash in
3686 vertical-motion with longlines-mode. (Bug#9254)
3687
35928349
EZ
36882011-08-05 Eli Zaretskii <eliz@gnu.org>
3689
ec7cc85b
EZ
3690 * bidi.c <bidi_cache_total_alloc>: Now static.
3691 (bidi_initialize): Initialize bidi_cache_total_alloc.
3692
8b76d6f8 3693 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
3694 cache. (Bug#9221)
3695
3696 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3697 amount allocated this far in `bidi_cache_total_alloc'.
3698 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3699 non-zero, only free the data buffer without restoring the cache
3700 contents. All callers changed.
3701
3702 * dispextern.h (bidi_unshelve_cache): Update prototype.
3703
3704 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3705 (move_it_in_display_line, move_it_to)
3706 (move_it_vertically_backward, move_it_by_lines): Replace the call
3707 to xfree to an equivalent call to bidi_unshelve_cache.
3708 (move_it_in_display_line_to): Fix logic of returning
412b6358 3709 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 3710
e2e2423b
EZ
37112011-08-05 Eli Zaretskii <eliz@gnu.org>
3712
3713 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3714 came from a string character with a `cursor' property. (Bug#9229)
3715
ae9e757a
JD
37162011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3717
3718 * Makefile.in (LIB_PTHREAD): New variable.
3719 (LIBES): Add LIB_PTHREAD (Bug#9216).
3720
3721 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3722 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3723
213bd7f2
AS
37242011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3725
6b02f655 3726 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 3727
99aaf75f
JD
37282011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3729
3730 * xterm.c (x_find_topmost_parent): New function.
3731 (x_set_frame_alpha): Find topmost parent window with
3732 x_find_topmost_parent and set the property there also (bug#9181).
3733 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3734
c74e9d86
PE
37352011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3736
3737 * callproc.c (Fcall_process): Avoid vfork clobbering
3738 the local vars buffer, coding_systems, current_dir.
3739
640c8776
SM
37402011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3741
3742 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3743
f26d0e4c
PE
37442011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3745
8a10d76c
PE
3746 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3747 so that it is not optimized away.
3748
f26d0e4c
PE
3749 * xdisp.c (compute_display_string_pos): Remove unused local.
3750
55439c61
EZ
37512011-08-02 Eli Zaretskii <eliz@gnu.org>
3752
3753 Fix slow cursor motion and scrolling in large buffers with
3754 selective display, like Org Mode buffers. (Bug#9218)
3755
3756 * dispextern.h (struct bidi_it): New member disp_prop_p.
3757
3758 * xdisp.c: Remove one-slot cache of display string positions.
3759 (compute_display_string_pos): Accept an additional argument
5e617bc2 3760 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
3761 for a display string or property. If found, set DISP_PROP_P
3762 non-zero.
3763
3764 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
3765 DISP_PROP_P, and pass it to compute_display_string_pos.
3766 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
3767 non-zero. All callers of bidi_fetch_char changed.
3768
fb33fa43
SM
37692011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3770
3771 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3772
b099e063
DM
37732010-12-03 Don March <don@ohspite.net>
3774
3775 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3776 last character M-[char] is translated to ESC [char] (bug#7541).
3777
5cc7f7af
KH
37782011-08-02 Kenichi Handa <handa@m17n.org>
3779
d0fffa3f 3780 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
3781
3782 * chartab.c (uniprop_table): Make it non-static.
3783
525d5e6e
EZ
37842011-08-01 Eli Zaretskii <eliz@gnu.org>
3785
3786 * xdisp.c (forward_to_next_line_start): Accept additional argument
3787 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3788 on the newline.
3789 (reseat_at_next_visible_line_start): Use the bidi iterator state
3790 returned by forward_to_next_line_start to restore the state of
3791 it->bidi_it after backing up to previous newline. (Bug#9212)
3792
31011111
AS
37932011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3794
3795 * regex.c (re_comp): Protoize.
3796 (re_exec): Fix return type.
3797 (regexec): Fix type of `ret'. (Bug#9203)
3798
476371c4
PE
37992011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3800
e5d76069
PE
3801 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3802 This is needed if max-image-size is a floating-point number.
3803
9a79b20c
AS
38042011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3805
3806 * print.c (print_object): Print empty symbol as ##.
3807
3808 * lread.c (read1): Read ## as empty symbol.
3809
d8c2fa78
AA
38102011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3811
3812 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3813 setting frame foreground color (Bug#9175).
3814 (x_set_background_color): Likewise.
3815
ffe57a7a
AA
3816 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3817 contents (Bug#9176).
3818 (EmacsTooltip -init): Remove bezels and add shadows to
3819 tooltip windows.
3820
bf3492a5
AA
3821 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3822 or scroll bar (Bug#8470).
3823
d55e9c53
AA
3824 * nsfont.m (nsfont_open): Remove assignment to voffset and
3825 unnecessary vars hshink, expand, hd, full_height, min_height.
3826 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3827
3828 * nsterm.h (nsfont_info): Remove voffset field.
3829
d8c2fa78 38302011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
3831
3832 Implement strike-through and overline on NextStep (Bug#8863).
3833
3834 * nsfont.m (nsfont_open): Use underline position provided by font,
3835 instead of hard-coded value of 2.
3836 (nsfont_draw): Call ns_draw_text_decoration instead.
3837
3838 * nsterm.h: Add declaration for ns_draw_text_decoration.
3839
3840 * nsterm.m (ns_draw_text_decoration): New function for drawing
3841 underline, overline, and strike-through.
3842 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3843 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 3844 accommodate underlining, etc.
4843aac3 3845
4cc60b9b
EZ
38462011-07-28 Eli Zaretskii <eliz@gnu.org>
3847
bc7ece87
EZ
3848 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3849 default.
4cc60b9b 3850
476371c4
PE
38512011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3852
66606eea
PE
3853 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3854 Without this fix, if a signal arrives just after memory fills up,
3855 'malloc' might be invoked reentrantly.
3856
476371c4
PE
3857 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3858 In other words, assume that every image size is allowed, on non-X
3859 hosts. This assumption is probably wrong, but it lets Emacs compile.
3860
f3fcc40d
AS
38612011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3862
3863 * regex.c (re_iswctype): Convert return values to boolean.
3864
350c992f
EZ
38652011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3866
3867 * xdisp.c (compute_display_string_pos): Don't use cached display
3868 string position if the buffer had its restriction changed.
3869 (Bug#9184)
3870
5266b4bb
PE
38712011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3872
3873 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3874
2573a837 38752011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 3876
41f55ccd 3877 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 3878
39e378da
PE
3879 * bidi.c: Integer size and overflow fixes.
3880 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3881 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3882 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3883 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3884 (bidi_find_other_level_edge):
3885 Use ptrdiff_t instead of EMACS_INT where either will do.
3886 This works better on 32-bit hosts configured --with-wide-int.
3887 (bidi_cache_ensure_space): Check for size-calculation overflow.
3888 Use % rather than repeated addition, for better worst-case speed.
3889 Don't set bidi_cache_size until after xrealloc returns, because it
3890 might not return.
3891 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
3892 (bidi_cache_ensure_space): Also check that the bidi cache size
3893 does not exceed that of the largest Lisp string or buffer. See Eli
3894 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 3895
5e927815
PE
3896 * alloc.c (__malloc_size_t): Remove.
3897 All uses replaced by size_t. See Andreas Schwab's note
3898 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3899
ca4aa935
PE
3900 * image.c: Improve checking for integer overflow.
3901 (check_image_size): Assume that f is nonnull, since
3902 it is always nonnull in practice. This is one less thing to
3903 worry about when checking for integer overflow later.
3904 (x_check_image_size): New function, which checks for integer
3905 overflow issues inside X.
3906 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3907 This removes the need for a memory_full check.
3908 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3909 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3910 (xbm_read_bitmap_data): Change locals back to 'int', since
3911 their values must fit in 'int'.
3912 (xpm_load_image, png_load, tiff_load):
3913 Invoke x_create_x_image_and_pixmap earlier,
3914 to avoid much needless work if the image is too large.
3915 (tiff_load): Treat overly large images as if
3916 x_create_x_image_and_pixmap failed, not as malloc failures.
3917 (gs_load): Use x_check_image_size.
3918
5f8f9cc2
PE
3919 * gtkutil.c: Omit integer casts.
3920 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3921 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3922
5adf60bc
PE
3923 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3924
c8907a93
PE
3925 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3926 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3927 would wrongly return t on a 64-bit host.
3928
e3c25c68
PE
3929 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3930 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3931 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3932 and therefore cause GCC to emit a bogus diagnostic in some cases.
3933
3f791afe
PE
3934 * image.c: Integer signedness and overflow and related fixes.
3935 This is not an exhaustive set of fixes, but it's time to
3936 record what I've got.
3937 (lookup_pixel_color, check_image_size): Remove redundant decls.
3938 (check_image_size): Don't assume that arbitrary EMACS_INT values
3939 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3940 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3941 (tiff_load, imagemagick_load_image):
3942 Check for overflow in size calculations.
3943 (x_create_x_image_and_pixmap): Remove unnecessary test for
3944 xmalloc returning NULL; that can't happen.
3945 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3946 (xpm_color_bucket): Use better integer hashing function.
3947 (xpm_cache_color): Don't possibly over-allocate memory.
3948 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3949 (gif_memory_source):
3950 Use ptrdiff_t, not int or size_t, to record sizes.
3951 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3952 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3953 either works, as we prefer signed integers.
3954 (tiff_read_from_memory, tiff_write_from_memory):
3955 Return tsize_t, not size_t, since that's what the TIFF API wants.
3956 (tiff_read_from_memory): Don't fail simply because the read would
3957 go past EOF; instead, return a short read.
3958 (tiff_load): Omit no-longer-needed casts.
3959 (Fimagemagick_types): Don't assume size fits into 'int'.
3960
3cc5a532
PE
3961 Improve hashing quality when configured --with-wide-int.
3962 * fns.c (hash_string): New function, taken from sxhash_string.
3963 Do not discard information about ASCII character case; this
3964 discarding is no longer needed.
3965 (sxhash-string): Use it. Change sig to match it. Caller changed.
3966 * lisp.h: Declare it.
3967 * lread.c (hash_string): Remove, since we now use fns.c's version.
3968 The fns.c version returns a wider integer if --with-wide-int is
3969 specified, so this should help the quality of the hashing a bit.
3970
b312a492
PE
3971 * emacs.c: Integer overflow minor fix.
3972 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3973 Define only if GNU_LINUX.
3974 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3975
dfd153ae
PE
3976 * dispnew.c: Integer signedness and overflow fixes.
3977 Remove unnecessary forward decls, that were a maintenance hassle.
3978 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3979 All uses changed.
3980 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3981 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3982 (prepare_desired_row, line_draw_cost):
3983 Use int, not unsigned, where either works.
3984 (save_current_matrix, restore_current_matrix):
3985 Use ptrdiff_t, not size_t, where either works.
3986 (init_display): Check for overflow more accurately, and without
3987 relying on undefined behavior.
3988
a81d11a3
PE
3989 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3990 Remove, replacing with the new symbols in lisp.h. All uses changed.
3991 * fileio.c (make_temp_name):
3992 * filelock.c (lock_file_1, lock_file):
3993 * xdisp.c (message_dolog):
3994 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3995 Use pMd etc. instead.
3996 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3997 replacing the pWIDE etc. symbols removed from editfns.c.
3998
3300e6fd
PE
3999 * keyboard.h (num_input_events): Now uintmax_t.
4000 This is (very slightly) less likely to mess up due to wraparound.
4001 All uses changed.
4002
fd05c7e9
PE
4003 * buffer.c: Integer signedness fixes.
4004 (alloc_buffer_text, enlarge_buffer_text):
4005 Use ptrdiff_t rather than size_t when either will do, as we prefer
4006 signed integers.
4007
903fe15d
PE
4008 * alloc.c: Integer signedness and overflow fixes.
4009 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
4010 (__malloc_size_t): Default to size_t, not to int.
4011 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
4012 (Fgarbage_collect, mark_object_loop_halt, mark_object):
4013 Prefer ptrdiff_t to size_t when either would do, as we prefer
4014 signed integers.
4015 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
4016 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
4017 Now const. Initialize with values that are in range even if char
4018 is signed.
4019 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
4020 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
4021 These functions do the right thing with sizes > 2**32.
4022 (check_depth): Now ptrdiff_t, not int.
4023 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
4024 Adjust to new way of storing sizes. Check for size overflow bugs
4025 in rest of code.
4026 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
4027 slightly wrong anyway, as it missed one instance of
4028 XMALLOC_OVERRUN_CHECK_OVERHEAD.
4029 (refill_memory_reserve): Omit needless cast to size_t.
4030 (mark_object_loop_halt): Mark as externally visible.
4031
ac82cc6a
PE
4032 * xselect.c: Integer signedness and overflow fixes.
4033 (Fx_register_dnd_atom, x_handle_dnd_message):
4034 Use ptrdiff_t, not size_t, since we prefer signed.
4035 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
4036 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
4037 x_dnd_atoms_size and x_dnd_atoms_length.
4038
c2d1e36d
PE
4039 * doprnt.c: Prefer signed to unsigned when either works.
4040 * eval.c (verror):
4041 * doprnt.c (doprnt):
4042 * lisp.h (doprnt):
4043 * xdisp.c (vmessage):
4044 Use ptrdiff_t, not size_t, when using or implementing doprnt,
4045 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
4046 prefer signed arithmetic to avoid comparison confusion.
4047 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
4048 but is a bit tricky.
4049
0e926e56
PE
4050 Assume freestanding C89 headers, string.h, stdlib.h.
4051 * data.c, doprnt.c, floatfns.c, print.c:
4052 Include float.h unconditionally.
4053 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
4054 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
4055 * regex.c: Likewise for stddef.h, string.h.
4056 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
4057 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
4058 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
4059 (STDC_HEADERS): Remove obsolete defines.
4060 * sysdep.c: Include limits.h unconditionally.
4061
9cfdb3ec
PE
4062 Assume support for memcmp, memcpy, memmove, memset.
4063 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
4064 * regex.c (memcmp, memcpy):
4065 Remove; we assume C89 now.
4066
4067 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
4068 (__malloc_safe_bcopy): Remove; no longer needed.
4069
cf950e6b 4070 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
4071 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
4072 well either way, and we prefer signed to unsigned.
4073
dbf38e02
LMI
40742011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
4075
4076 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
4077 closes the connection while we're reading (bug#9182).
4078
d6f0886c 40792011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 4080
d6f0886c
JD
4081 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
4082 are specified (Bug#9168).
24e0f6b1 4083
2eb1f9e6
PE
40842011-07-25 Paul Eggert <eggert@cs.ucla.edu>
4085
4086 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
4087 Found by GCC static checking and --with-wide-int on a 32-bit host.
4088
22381272 40892011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
4090
4091 * xdisp.c (compute_display_string_pos): Fix logic of caching
4092 previous display string position. Initialize cached_prev_pos to
4093 -1. Fixes slow-down at the beginning of a buffer.
4094
f25e39b4
EZ
40952011-07-24 Eli Zaretskii <eliz@gnu.org>
4096
4097 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
4098 for attrs[LFACE_FONTSET_INDEX].
4099
04c4b52e
PE
41002011-07-23 Paul Eggert <eggert@cs.ucla.edu>
4101
4102 * xml.c (parse_region): Remove unused local
4103 that was recently introduced.
4104
c1734fbd
EZ
41052011-07-23 Eli Zaretskii <eliz@gnu.org>
4106
be18c5a5
EZ
4107 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
4108 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
4109
c1734fbd
EZ
4110 * xdisp.c (move_it_in_display_line_to): Record the best matching
4111 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
4112 exit if none of the characters scanned was an exact match.
4113 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
4114 when exact match is impossible due to invisible text, and the
4115 lines are truncated.
4116
a258d627
JD
41172011-07-23 Jan Djärv <jan.h.d@swipnet.se>
4118
4119 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
4120 for OSX >= 10.7.
4121
b6d5a689
EZ
41222011-07-22 Eli Zaretskii <eliz@gnu.org>
4123
0f74f785
EZ
4124 Fix a significant slow-down of cursor motion with C-n, C-p,
4125 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
4126 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 4127 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
4128 (next_element_from_buffer): Call compute_stop_pos_backwards to
4129 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
4130 base_level_stop.
4131 (reseat): Don't look for prev_stop, as that could mean a very long
4132 run.
4133 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
4134 <cached_disp_overlay_modiff>: Cache for last found display string
4135 position.
551918c1 4136 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
4137 about the same buffer in the same area of character positions, and
4138 the buffer wasn't changed since the time the display string
4139 position was cached.
551918c1 4140
b2d0c91a
EZ
41412011-07-22 Eli Zaretskii <eliz@gnu.org>
4142
4143 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
4144 is an integer, which is important for empty lines. (Bug#9149)
4145
043604ee
CY
41462011-07-22 Chong Yidong <cyd@stupidchicken.com>
4147
4148 * frame.c (Fmodify_frame_parameters): In tty case, update the
4149 default face if necessary (Bug#4238).
4150
da4adb04
CY
41512011-07-21 Chong Yidong <cyd@stupidchicken.com>
4152
4153 * editfns.c (Fstring_to_char): No need to explain what a character
4154 is in the docstring (Bug#6576).
4155
9abd0532
LMI
41562011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4157
4158 * xml.c (parse_region): Make sure we always return a tree.
4159
36881d16
HK
41602011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
4161
4162 * xml.c (parse_region): If a document contains only comments,
4163 return that, too.
4164
1e98674d
LMI
41652011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4166
4167 * xml.c (make_dom): Return comments, too.
4168
590bd467
PE
41692011-07-19 Paul Eggert <eggert@cs.ucla.edu>
4170
4171 Port to OpenBSD.
4172 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
4173 and the surrounding thread.
4174 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
4175 rather than fgets, and retry after EINTR. Otherwise, 'emacs
4176 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
4177 timer goes off.
4178 * s/openbsd.h (BROKEN_SIGIO): Define.
4179 * unexelf.c (unexec) [__OpenBSD__]:
4180 Don't update the .mdebug section of the Alpha COFF symbol table.
4181
f41628b2
LMI
41822011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4183
4184 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
4185 (bug#8460).
4186
b59b67c5
PE
41872011-07-18 Paul Eggert <eggert@cs.ucla.edu>
4188
15e3a074
PE
4189 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
4190 This fixes some race conditions on the permissions of any newly
4191 created file.
4192
41bed37d
PE
4193 * alloc.c (valid_pointer_p): Use pipe, not open.
4194 This fixes some permissions issues when debugging.
4195
b59b67c5
PE
4196 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
4197 If fchown fails to set both uid and gid, try to set just gid,
4198 as that is sometimes allowed. Adjust the file's mode to eliminate
4199 setuid or setgid bits that are inappropriate if fchown fails.
4200
925a6be7
SM
42012011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
4202
4203 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
4204 to compare Lisp_Objects.
4205 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
4206 global_gnutls_log_level, don't mistake it for a Lisp_Object.
4207 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
4208
52968808
AS
42092011-07-17 Andreas Schwab <schwab@linux-m68k.org>
4210
0a6a104b
AS
4211 * lread.c (read_integer): Unread even EOF character.
4212 (read1): Likewise. Properly record start position of symbol.
4213
52968808
AS
4214 * lread.c (read1): Read `#:' as empty uninterned symbol if no
4215 symbol character follows.
4216
9e381cdd
PE
42172011-07-17 Paul Eggert <eggert@cs.ucla.edu>
4218
4219 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
4220 This works around a problem with the previous change to Fcopy_file.
4221 Recent glibc declares fchown with __attribute__((warn_unused_result)),
4222 and without this change, GCC might complain about discarding
4223 fchown's return value.
4224
b5641435
JB
42252011-07-16 Juanma Barranquero <lekktu@gmail.com>
4226
4227 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
4228
a8031457
PE
42292011-07-16 Paul Eggert <eggert@cs.ucla.edu>
4230
4231 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
4232
dd889327
LMI
42332011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
4234
750c33f7
LMI
4235 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
4236 it's used from the C level.
4237
dd889327
LMI
4238 * process.c: Use the same condition for POLL_FOR_INPUT in both
4239 keyboard.c and process.c (bug#1858).
4240
87e86684
LM
42412011-07-09 Lawrence Mitchell <wence@gmx.li>
4242
4243 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
4244 (Fgnutls_boot): Use it.
4245
64348f40
AS
42462011-07-15 Andreas Schwab <schwab@linux-m68k.org>
4247
4248 * doc.c (Fsubstitute_command_keys): Revert last change.
4249
1d698799
LMI
42502011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
4251
f863868c
LMI
4252 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
4253 quotes the next character, and doesn't affect other longer
4254 sequences (bug#8935).
4255
1d698799
LMI
4256 * lread.c (syms_of_lread): Clarify that is isn't only
4257 `eval-buffer' and `eval-defun' that's affected by
4258 `lexical-binding' (bug#8460).
4259
aa4b6df6
EZ
42602011-07-15 Eli Zaretskii <eliz@gnu.org>
4261
4262 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 4263 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 4264
5d856da6
PE
42652011-07-14 Paul Eggert <eggert@cs.ucla.edu>
4266
ad6042bb
PE
4267 Fix minor problems found by static checking.
4268 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
4269 (elsz): Now a signed constant, not a size_t var. We prefer signed
4270 types to unsigned, to avoid integer comparison confusion. Without
4271 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
4272 "cannot optimize loop, the loop counter may overflow", a symptom
4273 of the confusion.
f00bbb22 4274 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
4275 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
4276
6468f31c
LMI
42772011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4278
49080b10
LMI
4279 * search.c (Fre_search_backward): Mention `case-fold-search' in
4280 all the re_search_* functions (bug#8138).
4281
6468f31c
LMI
4282 * keyboard.c (Fopen_dribble_file): Document when the file is
4283 closed (bug#8056).
4284
c965adc5
EZ
42852011-07-14 Eli Zaretskii <eliz@gnu.org>
4286
df9733bf
EZ
4287 * bidi.c (bidi_dump_cached_states): Fix format of displaying
4288 bidi_cache_idx.
4289
0bb23927
EZ
4290 Support bidi reordering of display and overlay strings.
4291 * xdisp.c (compute_display_string_pos)
4292 (compute_display_string_end): Accept additional argument STRING.
4293 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
4294 (reseat_to_string): Initialize bidi_it->string.s and
4295 bidi_it->string.schars.
4296 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
4297 NULL (avoids a crash in bidi_paragraph_init).
4298 Initialize itb.string.lstring.
0bb23927
EZ
4299 (init_iterator): Call bidi_init_it only of a valid
4300 buffer position was specified. Initialize paragraph_embedding to
4301 L2R.
4302 (reseat_to_string): Initialize the bidi iterator.
4303 (display_string): If we need to ignore text properties of
4304 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
4305 original value of -1 will not work with bidi.)
4306 (compute_display_string_pos): First arg is now struct
4307 `text_pos *'; all callers changed. Support display properties on
4308 Lisp strings.
4309 (compute_display_string_end): Support display properties on Lisp
4310 strings.
4311 (init_iterator, reseat_1, reseat_to_string): Initialize the
4312 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
4313 when iterating on a string not from display properties).
640c8776
SM
4314 (compute_display_string_pos, compute_display_string_end):
4315 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
4316 arrow keys.
4317 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
4318 base_level_stop; instead, set base_level_stop to BEGV.
4319 Fixes crashes in vertical-motion.
0bb23927
EZ
4320 (next_element_from_buffer): Improve commentary for when
4321 the iterator is before prev_stop.
4322 (init_iterator): Initialize bidi_p from the default value of
4323 bidi-display-reordering, not from buffer-local value. Use the
4324 buffer-local value only if initializing for buffer iteration.
4325 (handle_invisible_prop): Support invisible properties on strings
4326 that are being bidi-reordered.
4327 (set_iterator_to_next): Support bidi reordering of C strings and
4328 Lisp strings.
4329 (next_element_from_string): Support bidi reordering of Lisp
4330 strings.
4331 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
4332 (display_string): Support display of R2L glyph rows.
4333 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
4334 (init_iterator): Don't initialize it->bidi_p for strings
4335 here.
4336 (reseat_to_string): Initialize it->bidi_p for strings here.
4337 (next_element_from_string, next_element_from_c_string)
4338 (next_element_from_buffer): Add xassert's for correspondence
4339 between IT's object being iterated and it->bidi_it.string
4340 structure.
4341 (face_before_or_after_it_pos): Support bidi iteration.
4342 (next_element_from_c_string): Handle the case of the first string
4343 character that is not the first one in the visual order.
4344 (get_visually_first_element): New function, refactored from common
4345 parts of next_element_from_buffer, next_element_from_string, and
4346 next_element_from_c_string.
4347 (tool_bar_lines_needed, redisplay_tool_bar)
4348 (display_menu_bar): Force left-to-right direction. Add a FIXME
4349 comment for making that be controlled by a user option.
4350 (push_it, pop_it): Save and restore the state of the
4351 bidi iterator. Save and restore the bidi_p flag.
4352 (pop_it): Iterate out of display property for string iteration as
4353 well.
4354 (iterate_out_of_display_property): Support iteration over strings.
4355 (handle_single_display_spec): Set up it->bidi_it for iteration
4356 over a display string, and call bidi_init_it.
4357 (handle_single_display_spec, next_overlay_string)
4358 (get_overlay_strings_1, push_display_prop): Set up the bidi
4359 iterator for displaying display or overlay strings.
4360 (forward_to_next_line_start): Don't use the shortcut if
4361 bidi-iterating.
4362 (back_to_previous_visible_line_start): If handle_display_prop
4363 pushed the iterator stack, restore the internal state of the bidi
4364 iterator by calling bidi_pop_it same number of times.
4365 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
4366 and we are bidi-iterating, don't decrement the iterator position;
4367 instead, set the first_elt flag in the bidi iterator, to produce
4368 the same effect.
4369 (reseat_1): Remove redundant setting of string_from_display_prop_p.
4370 (push_display_prop): xassert that we are iterating a buffer.
4371 (push_it, pop_it): Save and restore paragraph_embedding member.
4372 (handle_single_display_spec, next_overlay_string)
4373 (get_overlay_strings_1, reseat_1, reseat_to_string)
4374 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4375 correctly. Don't assume unibyte strings are not bidi-reordered.
4376 (compute_display_string_pos)
4377 (compute_display_string_end): Fix handling the case of C string.
4378 (push_it, pop_it): Save and restore from_disp_prop_p.
4379 (handle_single_display_spec, push_display_prop): Set the
4380 from_disp_prop_p flag.
4381 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4382 (pop_it): Call iterate_out_of_display_property only if we are
4383 popping after iteration over a string that came from a display
4384 property. Fix a typo in popping stretch info. Add an assertion
4385 for verifying that the iterator position is in sync with the bidi
4386 iterator.
4387 (handle_single_display_spec, get_overlay_strings_1)
4388 (push_display_prop): Fix initialization of paragraph direction for
4389 string when that of the parent object is not yet determined.
4390 (reseat_1): Call bidi_init_it to resync the bidi
4391 iterator with IT's position. (Bug#7616)
4392 (find_row_edges): If ROW->start.pos gives position
4393 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4394 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4395 Reset the from_disp_prop_p flag.
4396 (SAVE_IT, RESTORE_IT): New macros.
4397 (pos_visible_p, face_before_or_after_it_pos)
4398 (back_to_previous_visible_line_start)
4399 (move_it_in_display_line_to, move_it_in_display_line)
4400 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4401 (try_scrolling, redisplay_window, display_line): Use them when
4402 saving a temporary copy of the iterator and restoring it back.
4403 (back_to_previous_visible_line_start, reseat_1)
4404 (init_iterator): Empty the bidi cache "stack".
4405 (move_it_in_display_line_to): If iterator ended up at
4406 EOL, but we never saw any buffer positions smaller than
4407 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4408 motion in bidi-reordered lines.
4409 (move_it_in_display_line_to): Record prev_method and prev_pos
4410 immediately before the call to set_iterator_to_next. Fixes cursor
4411 motion in bidi-reordered lines with stretch glyphs and strings
4412 displayed in margins. (Bug#8133) (Bug#8867)
4413 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4414 TO_CHARPOS.
640c8776
SM
4415 (pos_visible_p): Support positions in bidi-reordered lines.
4416 Save and restore bidi cache.
0bb23927
EZ
4417
4418 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4419 (bidi_paragraph_info): Delete unused struct.
4420 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4421 (bidi_cache_start): New variable.
4422 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4423 to zero.
4424 (bidi_cache_fetch_state, bidi_cache_search)
4425 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4426 (bidi_cache_find, bidi_peek_at_next_level)
4427 (bidi_level_of_next_char, bidi_find_other_level_edge)
4428 (bidi_move_to_visually_next): Compare cache index with
4429 bidi_cache_start rather than with zero.
4430 (bidi_fetch_char): Accept new argument STRING; all callers
4431 changed. Support iteration over a string. Support strings with
4432 display properties. Support unibyte strings. Fix the type of
4433 `len' according to what STRING_CHAR_AND_LENGTH expects.
4434 (bidi_paragraph_init, bidi_resolve_explicit_1)
4435 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
4436 (bidi_level_of_next_char, bidi_move_to_visually_next):
4437 Support iteration over a string.
0bb23927
EZ
4438 (bidi_set_sor_type, bidi_resolve_explicit_1)
4439 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4440 can now be zero (for strings); special values 0 and -1 were
4441 changed to -1 and -2, respectively.
4442 (bidi_char_at_pos): New function.
4443 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4444 Call it instead of FETCH_MULTIBYTE_CHAR.
4445 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4446 initialized to valid values.
4447 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4448 values.
4449 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4450 the test for valid cached positions. Fix the logic for looking up
4451 the sentinel state in the cache. GCPRO the Lisp string we are
4452 iterating.
4453 (bidi_push_it, bidi_pop_it): New functions.
4454 (bidi_initialize): Initialize the bidi cache start stack pointer.
4455 (bidi_cache_ensure_space): New function, refactored from part of
4456 bidi_cache_iterator_state. Don't assume the required size is just
4457 one BIDI_CACHE_CHUNK away.
4458 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4459 (bidi_count_bytes, bidi_char_at_pos): New functions.
4460 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4461 always valid if bidi_cache_idx is valid.
4462 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4463 is valid if it's going to be used.
4464 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4465 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
4466 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4467 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
4468 (bidi_find_other_level_edge, bidi_cache_start_stack):
4469 All variables related to cache indices are now EMACS_INT.
c965adc5 4470
0bb23927
EZ
4471 * dispextern.h (struct bidi_string_data): New structure.
4472 (struct bidi_it): New member `string'. Make flag members be 1-bit
4473 fields, and put them last in the struct.
640c8776
SM
4474 (compute_display_string_pos, compute_display_string_end):
4475 Update prototypes.
0bb23927
EZ
4476 (bidi_push_it, bidi_pop_it): Add prototypes.
4477 (struct iterator_stack_entry): New members bidi_p,
4478 paragraph_embedding, and from_disp_prop_p.
4479 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
4480 (bidi_shelve_cache, bidi_unshelve_cache):
4481 Declare prototypes.
0bb23927
EZ
4482
4483 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4484 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4485 and vector-like objects.
4486
4487 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4488 cache around display iteration.
4489
4490 * window.c (Fwindow_end, window_scroll_pixel_based)
4491 (displayed_window_lines, Frecenter): Save and restore the bidi
4492 cache around display iteration.
4493
3bbd2265
LMI
44942011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4495
4496 * editfns.c (Fdelete_region): Clarify the use of the named
4497 parameters (bug#6788).
4498
adc47434
MR
44992011-07-14 Martin Rudalics <rudalics@gmx.at>
4500
4501 * indent.c (Fvertical_motion): Set and restore w->pointm when
4502 saving and restoring the window's buffer (Bug#9006).
4503
837c31f8
LMI
45042011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4505
4506 * editfns.c (Fstring_to_char): Clarify just what is returned
4507 (bug#6576). Text by Eli Zaretskii.
4508
ac389d0c
JB
45092011-07-13 Juanma Barranquero <lekktu@gmail.com>
4510
4511 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4512
0be0ce47
EZ
45132011-07-13 Eli Zaretskii <eliz@gnu.org>
4514
4515 * buffer.c (mmap_find): Fix a typo.
4516
cd18e7e3
JB
45172011-07-13 Johan Bockgård <bojohan@gnu.org>
4518
4519 Fix execution of x selection hooks.
4520 * xselect.c (Qx_lost_selection_functions)
4521 (Qx_sent_selection_functions): New vars.
4522 (syms_of_xselect): DEFSYM them.
4523 (x_handle_selection_request): Pass Qx_sent_selection_functions
4524 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4525 (x_handle_selection_clear,x_clear_frame_selections):
4526 Pass Qx_lost_selection_functions rather than
4527 Vx_lost_selection_functions to Frun_hook_with_args.
4528
47ea7f44
PE
45292011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4530
ac389d0c 4531 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
4532 The old code sometimes used this field without initializing it.
4533
47ea7f44
PE
4534 * alloc.c (gc_sweep): Don't read past end of array.
4535 In theory, the old code could also have corrupted Emacs internals,
4536 though it'd be very unlikely.
4537
bc985c87
AS
45382011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4539
4540 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 4541 argument. (Bug#4026)
bc985c87 4542
0cf34688
LMI
45432011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4544
b3dadd76
LMI
4545 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4546 key" (bug#4257).
4547
0cf34688
LMI
4548 * window.c (Fset_window_start): Doc fix (bug#4199).
4549 (Fset_window_hscroll): Ditto.
4550
270768cd
PE
45512011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4552
077e3dda 4553 Fix minor new problems caught by GCC 4.6.1.
270768cd 4554 * term.c (init_tty): Remove unused local.
490011a6 4555 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 4556 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 4557 not used otherwise.
270768cd 4558
b1f58454
CY
45592011-07-12 Chong Yidong <cyd@stupidchicken.com>
4560
4561 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4562
22b9578d
LMI
45632011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4564
6e70ab07
LMI
4565 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4566 are the mini-buffer and the echo area (bug#3320).
4567
22b9578d
LMI
4568 * term.c (init_tty): Remove support for supdup, c10 and perq
4569 terminals, which are no longer supported (bug#1482).
4570
8974cc9f
JB
45712011-07-10 Johan Bockgård <bojohan@gnu.org>
4572
4573 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4574
a560d974
JD
45752011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4576
4577 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4578 for non-popups (Bug#3642).
4579
1dae0f0a
AS
45802011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4581
268c2c36 4582 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 4583 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
4584 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4585 * cm.c (losecursor): Likewise.
1dae0f0a
AS
4586 * data.c (fmod): Likewise.
4587 * dispnew.c (swap_glyphs_in_rows): Likewise.
4588 * emacs.c (memory_warning_signal): Likewise.
4589 * floatfns.c (float_error): Likewise.
4590 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4591 (otf_open, font_otf_capability, generate_otf_features)
4592 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4593 Likewise.
4594 * image.c (pbm_read_file): Likewise.
4595 * indent.c (string_display_width): Likewise.
4596 * intervals.c (check_for_interval, search_for_interval)
4597 (inc_interval_count, count_intervals, root_interval)
4598 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4599 * lread.c (defalias): Likewise.
268c2c36 4600 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
4601 * regex.c (set_image_of_range_1, set_image_of_range)
4602 (regex_grow_registers): Likewise.
4603 * sysdep.c (strerror): Likewise.
4604 * termcap.c (valid_filename_p, tprint, main): Likewise.
4605 * tparam.c (main): Likewise.
4606 * unexhp9k800.c (run_time_remap, save_data_space)
4607 (update_file_ptrs, read_header, write_header, calculate_checksum)
4608 (copy_file, copy_rest, display_header): Likewise.
4609 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4610 Likewise.
4611 * xdisp.c (check_it): Likewise.
4612 * xfaces.c (register_color, unregister_color, unregister_colors):
4613 Likewise.
4614 * xfns.c (print_fontset_result): Likewise.
4615 * xrdb.c (member, fatal, main): Likewise.
4616
99033785
PE
46172011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4618
4619 Fix minor problems found by static checking (Bug#9031).
4620 * chartab.c (char_table_set_range, map_sub_char_table):
4621 Remove unused locals.
4622 (uniprop_table): Now static.
4623 * composite.c (_work_char): Remove unused static var.
4624
9cb2ac56
JB
46252011-07-09 Juanma Barranquero <lekktu@gmail.com>
4626
4627 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4628
f25661f0
JD
46292011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4630
4631 * gtkutil.c (qttip_cb): Remove code without function.
4632
8278c4fe
EZ
46332011-07-09 Eli Zaretskii <eliz@gnu.org>
4634
4635 * w32.c (pthread_sigmask): New stub.
4636
1692ae2d 46372011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 4638
8a6ebd58 4639 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
4640 sigprocmask is portable only for single-threaded applications, and
4641 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
4642 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4643 (LIBES): Use it.
4644 * callproc.c (Fcall_process):
4645 * process.c (create_process):
4646 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4647 Use pthread_sigmask, not sigprocmask.
123403e4 4648
1b854618
JD
46492011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4650
4651 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4652 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4653 wrong (Bug#8591).
4654
3fe4b549
JD
46552011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4656
0ce7e563
JD
4657 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4658 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4659 (xg_hide_tooltip): Fix comment.
4660
3fe4b549
JD
4661 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4662 in registerServicesMenuSendTypes.
4663 (validRequestorForSendType): Don't check ns_return_types.
4664
4665 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4666 ns_return_type.
4667
5df75e47
JR
46682011-07-08 Jason Rumney <jasonr@gnu.org>
4669
22610910
JR
4670 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4671 SH_SHOW for hidden windows (Bug#5482).
4672
5df75e47
JR
4673 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4674 frame struct members of non-existent frames (Bug#6284).
4675
699c10bd
JD
46762011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4677
4393663b
JD
4678 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4679 variable firstTime not needed on OSX >= 10.6.
4680 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4681 >= 10.5. Use setKnobProportion, setDoubleValue.
4682
4683 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4684 (MAC_OS_X_VERSION_10_5): Define if not defined.
4685 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4686 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4687 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4688
4689 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4690 cString and lossyCString on OSX >= 10.4
4691
58179cce 4692 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
4693 sizeToFit on OSX >= 10.2.
4694
4695 * nsimage.m (allocInitFromFile): Don't use deprecated method
4696 bestRepresentationForDevice on OSX >= 10.6.
4697
4698 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4699 to avoid warning.
4700
4701 * emacs.c: Declare unexec_init_emacs_zone.
4702
a63e0781
JD
4703 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4704
699c10bd
JD
4705 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4706
4707 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4708 on svcsMenu (Bug#8842).
4709
4710 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4711 ns_return_types.
4712 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4713
4714 * nsterm.m (QUTF8_STRING): Declare.
4715 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4716 (validRequestorForSendType): Return type is (id).
4717 Change indexOfObjectIdenticalTo to indexOfObject.
4718 Check if we have local selection before returning self (Bug#8842).
4719 (writeSelectionToPasteboard): Put local selection into paste board
4720 if we have a local selection (Bug#8842).
4721 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4722
4723 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4724 (ns_get_local_selection): Declare.
4725
54e10184
LMI
47262011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4727
9888ff71
LMI
4728 * keymap.c (describe_map_tree): Don't insert a double newline at
4729 the end of the buffer (bug#1169) and return whether we inserted
4730 something.
4731
54e10184
LMI
4732 * callint.c (Fcall_interactively): Change "reading args" to
4733 "providing args" to try to clarify what it does (bug#1010).
4734
15fa4783
KH
47352011-07-07 Kenichi Handa <handa@m17n.org>
4736
4737 * composite.c (composition_compute_stop_pos): Ignore a static
4738 composition starting before CHARPOS (Bug#8915).
4739
4740 * xdisp.c (handle_composition_prop): Likewise.
4741
a8815b00
EZ
47422011-07-07 Eli Zaretskii <eliz@gnu.org>
4743
4744 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4745 (Bug#9015)
4746
ef7b981d 47472011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
4748
4749 * character.h (unicode_category_t): New enum type.
4750
4751 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4752 (Qchar_code_property_table): New variable.
4753 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4754 (UNIPROP_COMPRESSED_FORM_P): New macros.
4755 (char_table_ascii): Uncompress the compressed values.
4756 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4757 Uncompress the compressed values.
ac389d0c 4758 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
4759 (char_table_ref_and_range): Uncompress the compressed values.
4760 (sub_char_table_set): New arg is_uniprop. Callers changed.
4761 Uncompress the compressed values.
4762 (sub_char_table_set_range): Args changed. Callers changed.
4763 (char_table_set_range): Adjuted for the above change.
4764 (map_sub_char_table): Delete args default_val and parent. Add arg
4765 top. Give decoded values to a Lisp function.
640c8776 4766 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
4767 values to a Lisp function. Gcpro more variables.
4768 (uniprop_table_uncompress)
4769 (uniprop_decode_value_run_length): New functions.
4770 (uniprop_decoder, uniprop_decoder_count): New variables.
4771 (uniprop_get_decoder, uniprop_encode_value_character)
4772 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4773 New functions.
4774 (uniprop_encoder, uniprop_encoder_count): New variables.
4775 (uniprop_get_encoder, uniprop_table)
4776 (Funicode_property_table_internal, Fget_unicode_property_internal)
4777 (Fput_unicode_property_internal): New functions.
4778 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4779 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 4780 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
4781 char-code-property-alist.
4782
640c8776 4783 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
4784 Vunicode_category_table.
4785
640c8776 4786 * font.c (font_range): Adjust for the change of
c805dec0
KH
4787 Vunicode_category_table.
4788
76b397fb
DN
47892011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4790
4791 * m/iris4d.h: Remove file, move contents ...
4792 * s/irix6-5.h: ... here.
4793
22b4128e
PE
47942011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4795
4796 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
4797 * alloc.c (mark_buffer):
4798 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4799 (clone_per_buffer_values): Don't assume that
22b4128e
PE
4800 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4801 This isn't true in general, and it's particularly not true
4802 if Emacs is configured with --with-wide-int.
4803 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4804 New macros, used in the buffer.c change.
4805
869795d6
JD
48062011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4807
4808 * xsettings.c: Use both GConf and GSettings if both are available.
4809 (store_config_changed_event): Add comment.
4810 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4811 (store_tool_bar_style_changed): New functions.
5e617bc2 4812 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
4813 (struct xsettings): Move font inside HAVE_XFT.
4814 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 4815 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 4816 Move inside HAVE_XFT.
640c8776 4817 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
4818 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4819 also.
4820 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 4821 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 4822 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
4823 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4824 (parse_settings): Move check for font inside HAVE_XFT.
4825 (read_settings, apply_xft_settings): Add comment.
4826 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4827 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4828 call store_font_name_changed.
4829 (xft_settings_event): Add comment.
4830 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4831 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4832 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4833 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4834 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
4835 (xsettings_get_system_font, xsettings_get_system_normal_font):
4836 Add comment.
869795d6 4837
d8ed26bd
PE
48382011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4839
4840 Random fixes. E.g., (random) never returned negative values.
4841 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4842 subseconds part to the entropy, as that's a bit more random.
4843 Prefer signed to unsigned, since the signedness doesn't matter and
4844 in general we prefer signed. When given a limit, use a
4845 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4846 latter isn't right if USE_2_TAGS_FOR_INTS.
4847 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4848 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4849
cabf1cac
SM
48502011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4851
4852 * textprop.c (text_property_stickiness):
4853 Obey Vtext_property_default_nonsticky.
4854 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4855 * w32fns.c (syms_of_w32fns):
4856 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4857
6e9b2be9
PE
48582011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4859
4860 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4861 This is more efficient than Ffile_directory_p and avoids a minor race.
4862
90186c68
LMI
48632011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4864
7c301272
LMI
4865 * buffer.c (Foverlay_put): Say what the return value is
4866 (bug#7835).
4867
c4f2d8d4
LMI
4868 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4869 is a directory before asking whether to use the file name
4870 (bug#7564).
ad637907
LMI
4871 (barf_or_query_if_file_exists): Make the "File is a directory"
4872 error be more correct.
c4f2d8d4 4873
90186c68
LMI
4874 * fns.c (Frequire): Remove the mention of the .gz files, since
4875 that's installation-specific, but keep the mention of
4876 `get-load-suffixes'.
4877
da64016e
PE
48782011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4879
4880 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4881 Report string overflow if the output is too long.
4882
7d47b580
JB
48832011-07-04 Juanma Barranquero <lekktu@gmail.com>
4884
a555cb87
JB
4885 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4886 (syms_of_gnutls): Remove duplicate DEFSYM for
4887 Qgnutls_bootprop_verify_hostname_error, an error for
4888 Qgnutls_bootprop_verify_error (which is no longer used).
4889
7d47b580
JB
4890 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4891 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4892 Also (re)move comments that are misplaced or no longer relevant.
4893
1e49bfab
LMI
48942011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4895
4896 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4897
1485f4c0
CY
48982011-07-03 Chong Yidong <cyd@stupidchicken.com>
4899
4900 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4901 and background color parameters if they have been changed.
4902
a9ab721e
LMI
49032011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4904
4905 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4906
cf7cff57
PE
49072011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4908
2e13213d
PE
4909 * xsettings.c (SYSTEM_FONT): Define only when used.
4910 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4911
cf7cff57
PE
4912 * keymap.c (access_keymap_1): Now static.
4913
7a8e04f7
CY
49142011-07-02 Chong Yidong <cyd@stupidchicken.com>
4915
4916 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4917 leave any prefix arg for the up event (Bug#1586).
4918
61352f62
LMI
49192011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4920
69bb1ef7
LMI
4921 * lread.c (syms_of_lread): Mention single symbols defined by
4922 `defvar' or `defconst' (bug#7154).
4923
61352f62 4924 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 4925 (Frequire): Mention get-load-suffixes.
61352f62 4926
28545e04
MR
49272011-07-02 Martin Rudalics <rudalics@gmx.at>
4928
4929 * window.h (window): Remove clone_number slot.
4930 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4931 Remove.
4932 (make_parent_window, make_window, saved_window)
4933 (Fset_window_configuration, save_window_save): Don't deal with
4934 clone numbers.
4935 * buffer.c (Qclone_number): Remove declaration.
4936 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4937
3349e122
SM
49382011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4939
4940 Add multiple inheritance to keymaps.
4941 * keymap.c (Fmake_composed_keymap): New function.
4942 (Fset_keymap_parent): Simplify.
4943 (fix_submap_inheritance): Remove.
4944 (access_keymap_1): New function extracted from access_keymap to handle
4945 embedded parents and handle lists of maps.
4946 (access_keymap): Use it.
4947 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4948 (Fcopy_keymap): Handle embedded parents.
4949 (Fcommand_remapping, define_as_prefix): Simplify.
4950 (Fkey_binding): Simplify.
4951 (syms_of_keymap): Move minibuffer-local-completion-map,
4952 minibuffer-local-filename-completion-map,
4953 minibuffer-local-must-match-map, and
4954 minibuffer-local-filename-must-match-map to Elisp.
4955 (syms_of_keymap): Defsubr make-composed-keymap.
4956 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4957 (parse_menu_item): Trivial simplification.
4958
3279eb87
GM
49592011-07-01 Glenn Morris <rgm@gnu.org>
4960
4961 * Makefile.in (SETTINGS_LIBS): Fix typo.
4962
4550efdf
KI
49632011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4964
4965 * coding.c (Fencode_coding_string): Record the last coding system
4966 used, as the function doc string says (bug#8738).
4967
0949d2b6
JD
49682011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4969
4970 * xsettings.c (store_monospaced_changed): Take new font as arg and
4971 check for change against current_mono_font.
4972 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4973 (emacs_settings_constructor, emacs_settings_get_property)
4974 (emacs_settings_set_property, emacs_settings_class_init)
4975 (emacs_settings_init, gsettings_obj): Remove.
4976 (something_changedCB): New function for HAVE_GSETTINGS.
4977 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4978 with value as argument.
4979 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4980 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 4981 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
4982 "changed".
4983
4984 * xgselect.c: Add defined (HAVE_GSETTINGS).
4985 (xgselect_initialize): Ditto.
4986
4987 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4988 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4989 xg_select.
4990
bbc6b304
PE
49912011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4992
4993 * eval.c (struct backtrace): Simplify and port the data structure.
4994 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4995 signed bit field, as this assumption is not portable and it makes
4996 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4997 "char debug_on_exit : 1" as this is not portable either; instead,
4998 use the portable "unsigned int debug_on_exit : 1". Remove unused
4999 member evalargs. Remove obsolete comments about cc bombing out.
5000
9851bfc5
JD
50012011-06-30 Jan Djärv <jan.h.d@swipnet.se>
5002
51bb811f 5003 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
5004 Let HAVE_GSETTINGS override HAVE_GCONF.
5005 (store_monospaced_changed): New function.
5006 (EMACS_SETTINGS): A new type derived from GObject to handle
5007 GSettings notifications.
5008 (emacs_settings_constructor, emacs_settings_get_property)
5009 (emacs_settings_set_property, emacs_settings_class_init):
5010 New functions.
5011 (gsettings_client, gsettings_obj): New variables.
5012 (GSETTINGS_SCHEMA): New define.
5013 (something_changedCB): Call store_monospaced_changed.
5014 (init_gsettings): New function.
5015 (xsettings_initialize): Call init_gsettings.
5016 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
5017 to NULL.
5018
640c8776 5019 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
5020 GCONF_CFLAGS/LIBS.
5021
5386012d
MR
50222011-06-29 Martin Rudalics <rudalics@gmx.at>
5023
5024 * window.c (resize_root_window, grow_mini_window)
5025 (shrink_mini_window): Rename Qresize_root_window to
5026 Qwindow_resize_root_window and Qresize_root_window_vertically to
5027 Qwindow_resize_root_window_vertically.
5028
f13e0b08
PE
50292011-06-28 Paul Eggert <eggert@cs.ucla.edu>
5030
5031 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
5032
94515237
JB
50332011-06-27 Juanma Barranquero <lekktu@gmail.com>
5034
5035 * makefile.w32-in: Redesign dependencies so they reflect more
5036 clearly which files are directly included by each source file,
5037 and not through other includes.
5038
e43b6e43
MR
50392011-06-27 Martin Rudalics <rudalics@gmx.at>
5040
5041 * buffer.c (Qclone_number): Declare static and DEFSYM it.
5042 (sort_overlays, overlay_strings): When an overlay's clone number
5043 matches the window's clone number process the overlay even if
5044 the overlay's window property doesn't match the current window.
5045
d68443dc
MR
5046 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
5047 (Fwindow_hchild): Rename to Fwindow_left_child.
5048 (Fwindow_next): Rename to Fwindow_next_sibling.
5049 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
5050 (resize_window_check): Rename to window_resize_check.
5051 (resize_window_apply): Rename to window_resize_apply.
5052 (Fresize_window_apply): Rename to Fwindow_resize_apply.
5053 (Fdelete_other_windows_internal, resize_frame_windows)
5054 (Fsplit_window_internal, Fdelete_window_internal)
5055 (grow_mini_window, shrink_mini_window)
5056 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 5057
c7e73be5
JD
50582011-06-26 Jan Djärv <jan.h.d@swipnet.se>
5059
5060 * emacsgtkfixed.h: State that this is only used with Gtk+3.
5061 (emacs_fixed_set_min_size): Remove.
5062 (emacs_fixed_new): Take frame as argument.
5063
5064 * emacsgtkfixed.c: State that this is only used with Gtk+3.
5065 (_EmacsFixedPrivate): Remove minwidth/height.
5066 Add struct frame *f.
5067 (emacs_fixed_init): Initialize priv->f.
5068 (get_parent_class, emacs_fixed_set_min_size): Remove.
5069 (emacs_fixed_new): Set priv->f to argument.
5070 (emacs_fixed_get_preferred_width)
5071 (emacs_fixed_get_preferred_height): Use min_width/height from
5072 frames size_hint to set minimum and natural (Bug#8919).
5073 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
5074 and use min_width/height from frames size_hint to set
5075 min_width/height (Bug#8919).
5076
5077 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
5078 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
5079 Fix indentation.
c7e73be5 5080
cf99dcf8
EZ
50812011-06-26 Eli Zaretskii <eliz@gnu.org>
5082
5083 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
5084 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
5085 called at ZV.
5086
029529ac
CY
50872011-06-26 Chong Yidong <cyd@stupidchicken.com>
5088
5089 * process.c (wait_reading_process_output): Bypass select if
5090 waiting for a cell while ignoring keyboard input, and input is
5091 pending. Suggested by Jan Djärv (Bug#8869).
5092
7a7ef429
PE
50932011-06-25 Paul Eggert <eggert@cs.ucla.edu>
5094
5095 Use gnulib's dup2 module instead of rolling our own.
5096 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
5097
11fdef7d 50982011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
5099
5100 * dispnew.c (scrolling_window): Before scrolling, turn off a
5101 mouse-highlight in the window being scrolled.
5102
cd3520a4
JB
51032011-06-24 Juanma Barranquero <lekktu@gmail.com>
5104
5105 Move DEFSYM to lisp.h and use everywhere.
5106
5107 * character.h (DEFSYM): Move declaration...
5108 * lisp.h (DEFSYM): ...here.
5109
5110 * gnutls.c:
5111 * minibuf.c:
5112 * w32menu.c:
5113 * w32proc.c:
5114 * w32select.c: Don't include character.h.
5115
5116 * alloc.c (syms_of_alloc):
5117 * buffer.c (syms_of_buffer):
5118 * bytecode.c (syms_of_bytecode):
5119 * callint.c (syms_of_callint):
5120 * casefiddle.c (syms_of_casefiddle):
5121 * casetab.c (init_casetab_once):
5122 * category.c (init_category_once, syms_of_category):
5123 * ccl.c (syms_of_ccl):
5124 * cmds.c (syms_of_cmds):
5125 * composite.c (syms_of_composite):
5126 * dbusbind.c (syms_of_dbusbind):
5127 * dired.c (syms_of_dired):
5128 * dispnew.c (syms_of_display):
5129 * doc.c (syms_of_doc):
5130 * editfns.c (syms_of_editfns):
5131 * emacs.c (syms_of_emacs):
5132 * eval.c (syms_of_eval):
5133 * fileio.c (syms_of_fileio):
5134 * fns.c (syms_of_fns):
5135 * frame.c (syms_of_frame):
5136 * fringe.c (syms_of_fringe):
5137 * insdel.c (syms_of_insdel):
5138 * keymap.c (syms_of_keymap):
5139 * lread.c (init_obarray, syms_of_lread):
5140 * macros.c (syms_of_macros):
5141 * msdos.c (syms_of_msdos):
5142 * print.c (syms_of_print):
5143 * process.c (syms_of_process):
5144 * search.c (syms_of_search):
5145 * sound.c (syms_of_sound):
5146 * syntax.c (init_syntax_once, syms_of_syntax):
5147 * terminal.c (syms_of_terminal):
5148 * textprop.c (syms_of_textprop):
5149 * undo.c (syms_of_undo):
5150 * w32.c (globals_of_w32):
5151 * window.c (syms_of_window):
5152 * xdisp.c (syms_of_xdisp):
5153 * xfaces.c (syms_of_xfaces):
5154 * xfns.c (syms_of_xfns):
5155 * xmenu.c (syms_of_xmenu):
5156 * xsettings.c (syms_of_xsettings):
5157 * xterm.c (syms_of_xterm): Use DEFSYM.
5158
4228cf16
TZ
51592011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
5160
cd3520a4 5161 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 5162
7fcccf1e
PE
51632011-06-23 Paul Eggert <eggert@cs.ucla.edu>
5164
7efb4e0e
PE
5165 Integer and buffer overflow fixes (Bug#8873).
5166
ff5844ad
PE
5167 * print.c (printchar, strout): Check for string overflow.
5168 (PRINTPREPARE, printchar, strout):
5169 Don't set size unless allocation succeeds.
5170
90532f02
PE
5171 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
5172 for sizes. Check for string overflow more accurately.
5173 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
5174
6d84508d
PE
5175 * macros.c: Integer and buffer overflow fixes.
5176 * keyboard.h (struct keyboard.kbd_macro_bufsize):
5177 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
5178 Use ptrdiff_t, not int, for sizes.
5179 Don't increment bufsize until after realloc succeeds.
5180 Check for size-calculation overflow.
5181 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
5182
437b2cb4
PE
5183 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
5184
8b9ac8b4
PE
5185 * lread.c: Integer overflow fixes.
5186 (read_integer): Radix is now EMACS_INT, not int,
5187 to improve quality of diagnostics for out-of-range radices.
5188 Calculate buffer size correctly for out-of-range radices.
5189 (read1): Check for integer overflow in radices, and in
5190 read-circle numbers.
82cb60d3
PE
5191 (read_escape): Avoid int overflow.
5192 (Fload, openp, read_buffer_size, read1)
5193 (substitute_object_recurse, read_vector, read_list, map_obarray):
5194 Use ptrdiff_t, not int, for sizes.
5195 (read1): Use EMACS_INT, not int, for sizes.
20270765 5196 Check for size overflow.
8b9ac8b4 5197
7fcccf1e
PE
5198 * image.c (cache_image): Check for size arithmetic overflow.
5199
bfbbd7e7
PE
5200 * lread.c: Integer overflow issues.
5201 (saved_doc_string_size, saved_doc_string_length)
5202 (prev_saved_doc_string_size, prev_saved_doc_string_length):
5203 Now ptrdiff_t, not int.
5204 (read1): Don't assume doc string length fits in int. Check for
5205 out-of-range doc string lengths.
5206 (read_list): Don't assume file position fits in int.
39019e54 5207 (read_escape): Check for hex character overflow.
bfbbd7e7 5208
4e323265
LL
52092011-06-22 Leo Liu <sdl.web@gmail.com>
5210
5211 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
5212 Move to minibuffer.el.
5213
85fece3e
PE
52142011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5215
20b84ce9 5216 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
5217 The following patches are for when GLYPH_DEBUG && !XASSERT.
5218 * dispextern.h (trace_redisplay_p, dump_glyph_string):
5219 * dispnew.c (flush_stdout):
5220 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
5221 Mark as externally visible.
5222 * dispnew.c (check_window_matrix_pointers): Now static.
5223 * dispnew.c (window_to_frame_vpos):
5224 * xfns.c (unwind_create_frame):
5225 * xterm.c (x_check_font): Remove unused local.
5226 * scroll.c (CHECK_BOUNDS):
5227 * xfaces.c (cache_fache): Rename local to avoid shadowing.
5228 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
5229 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
5230 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
5231 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
5232 Now static.
5233 (debug_method_add): Use va_list and vsprintf rather than relying
5234 on undefined behavior with wrong number of arguments.
5235 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
5236 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
5237 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
5238 since we're not interested in debugging glyphs with old libraries.
5239 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
5240 GCC 4.6.0's static checking.
5241
0766b489
PE
52422011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5243
31fd4b32
PE
5244 Integer overflow and signedness fixes (Bug#8873).
5245 A few related buffer overrun fixes, too.
5246
b79e8648
PE
5247 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
5248
0766b489
PE
5249 * dispextern.h (struct face.stipple):
5250 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
5251 (x_bitmap_mask, x_allocate_bitmap_record)
5252 (x_create_bitmap_from_data, x_create_bitmap_from_file)
5253 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
5254 (x_create_bitmap_from_xpm_data):
5255 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
5256 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
5257 (.bitmaps_last):
5258 * xfaces.c (load_pixmap):
5259 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
5260 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
5261 (.bitmaps_last, struct x_output.icon_bitmap):
5262 Use ptrdiff_t, not int, for bitmap indexes.
5263 (x_allocate_bitmap_record): Check for size overflow.
5264 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
5265
b081724f
PE
5266 Use ptrdiff_t, not int, for overlay counts.
5267 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
5268 * editfns.c (overlays_around, get_pos_property):
5269 * textprop.c (get_char_property_and_overlay):
5270 * xdisp.c (next_overlay_change, note_mouse_highlight):
5271 * xfaces.c (face_at_buffer_position):
21514da7
PE
5272 * buffer.c (OVERLAY_COUNT_MAX): New macro.
5273 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
5274 (Fnext_overlay_change, Fprevious_overlay_change)
5275 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 5276 Use ptrdiff_t, not int, for sizes.
21514da7 5277 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 5278
3de73e5e
PE
5279 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
5280
2606c57b
PE
5281 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
5282 (x_session_initialize): Do not assume string length fits in int.
5283
aaafe47a
PE
5284 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
5285 This is unlikely, but can occur if DPI is outlandish.
5286
2674ddc8 5287 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
5288 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
5289
28154962
PE
5290 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
5291 * xrdb.c (magic_file_p, search_magic_path):
5292 Omit last arg SUFFIX; it was always 0. All callers changed.
5293 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
5294
7de51af5
PE
5295 * xfont.c (xfont_match): Avoid need for strlen.
5296
25ed6cc3
PE
5297 * xfns.c: Don't assume strlen fits in int.
5298 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
5299
4eab31dd
PE
5300 * xdisp.c (message_log_check_duplicate): Return intmax_t,
5301 not unsigned long, as we prefer signed integers. All callers changed.
5302 Detect integer overflow in repeat count.
5303 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 5304 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 5305
171e2a58
PE
5306 * termcap.c: Don't assume sizes fit in int and never overflow.
5307 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
5308 (gobble_line): Check for size-calculation overflow.
5309
ad39faca 5310 * minibuf.c (Fread_buffer):
6e5bb2dc 5311 * lread.c (intern, intern_c_string):
74ca2eb3
PE
5312 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
5313 Don't assume string length fits in int.
5314
52c61c22 5315 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
5316 * gtkutil.c (style_changed_cb): Avoid need for strlen.
5317
b5b8c9e5
PE
5318 * font.c: Don't assume string length fits in int.
5319 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
5320 Use ptrdiff_t, not int.
ccd6111c
PE
5321 (font_intern_prop): Don't assume string length fits in int.
5322 Don't assume integer property fits in fixnum.
5323 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 5324
882f0d81 5325 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 5326 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
5327 Reformulate so as not to need the command string.
5328 Invoke gzip -cd rather than gunzip, as it's more portable.
5329 (lock_info_type, lock_file_1, lock_file):
5330 Don't assume pid_t and time_t fit in unsigned long.
5331 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
5332 (current_lock_owner): Prefer signed type for sizes.
5333 Use memcpy, not strncpy, where memcpy is what is really wanted.
5334 Don't assume (via atoi) that time_t and pid_t fit in int.
5335 Check for time_t and/or pid_t out of range, e.g., via a network share.
5336 Don't alloca where an auto var works fine.
5337
93f4cf88
PE
5338 * fileio.c: Fix some integer overflow issues.
5339 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
5340 Don't assume string length fits in int.
5341 (directory_file_name): Don't assume string length fits in long.
5342 (make_temp_name): Don't assume pid fits in int, or that its print
5343 length is less than 20.
5344
f3e92b69
PE
5345 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
5346
1bfdaf10
PE
5347 * coding.c (make_subsidiaries): Don't assume string length fits in int.
5348
35016e9a
PE
5349 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
5350
3d1e65a1
PE
5351 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
5352 We prefer signed integers, even for size calculations.
5353
0b963a93
PE
5354 * emacs.c: Don't assume string length fits in 'int'.
5355 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
5356 (main): Don't invoke strlen when not needed.
5357
573f4b54
PE
5358 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
5359 (XD_DEBUG_MESSAGE): Don't waste a byte.
5360
989f33ba
PE
5361 * callproc.c (getenv_internal_1, getenv_internal)
5362 (Fgetenv_internal):
965d34eb
PE
5363 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
5364
e4d29b33
PE
5365 * lread.c (invalid_syntax): Omit length argument.
5366 All uses changed. This doesn't fix a bug, but it simplifies the
5367 code away from its former Hollerith-constant appearance, and it's
5368 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 5369 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 5370
eb49b136
PE
5371 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
5372 This didn't break anything, but it didn't help either.
5373 It's confusing to put a bogus integer in a place where the actual
5374 value does not matter.
9f62aeb1 5375 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 5376 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 5377
15375a22
PE
5378 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5379 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5380 implementation.
b61cc01c
PE
5381 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5382 We prefer signed types, and the value cannot exceed the EMACS_INT
5383 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
5384 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5385 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5386 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 5387
53b2623d
PE
5388 * indent.c (sane_tab_width): New function.
5389 (current_column, scan_for_column, Findent_to, position_indentation)
5390 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 5391 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 5392
51cab52b 5393 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 5394
f2ed8a70
PE
5395 * lisp.h (lint_assume): New macro.
5396 * composite.c (composition_gstring_put_cache):
5397 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5398
abe80cc6
PE
5399 * editfns.c, insdel.c:
5400 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 5401
b02c740e
PE
5402 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5403
ebc96716
PE
5404 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5405
b4e50fa0 5406 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 5407 Use much-faster test for byte-length change.
311d5d7c 5408 Don't assume string byte-length fits in 'int'.
a4cf38e4 5409 Check that character arg fits in 'int'.
85461888 5410 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 5411
c0c1ee9f
PE
5412 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5413
a498d7f4
PE
5414 * fns.c (concat): Catch string overflow earlier.
5415 Do not rely on integer wraparound.
5416
51cab52b
PE
5417 * dispextern.h (struct it.overlay_strings_charpos)
5418 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
5419 * xdisp.c (forward_to_next_line_start)
5420 (back_to_previous_visible_line_start)
5421 (reseat_at_next_visible_line_start, next_element_from_buffer):
5422 Don't arbitrarily truncate the value of 'selective' to int.
5423
76031fad
PE
5424 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5425
5eb55db9
PE
5426 * composite.c: Don't truncate sizes to 'int'.
5427 (composition_gstring_p, composition_reseat_it)
5428 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
5429 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5430 not EMACS_UINT, for indexes.
5eb55db9 5431
0703a717
PE
5432 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5433
d6202519
PE
5434 * buffer.c: Include <verify.h>.
5435 (struct sortvec.priority, struct sortstr.priority):
8961a454 5436 Now EMACS_INT, not int.
c20998a7 5437 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
5438 (struct sortstr.size, record_overlay_string)
5439 (struct sortstrlist.size, struct sortlist.used):
5440 Don't truncate size to int.
5441 (record_overlay_string): Check for size-calculation overflow.
d6202519 5442 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 5443
d5a19415
JM
54442011-06-22 Jim Meyering <meyering@redhat.com>
5445
029529ac 5446 Don't leak an XBM-image-sized buffer
d5a19415
JM
5447 * image.c (xbm_load): Free the image buffer after using it.
5448
a9041e6c
PE
54492011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5450
5451 Port to Sun C.
5452 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5453 that Sun C diagnosed.
5454 * fns.c (secure_hash): Fix pointer signedness issue.
5455 * intervals.c (static_offset_intervals): New function.
5456 (offset_intervals): Use it.
5457
7f3f739f
LL
54582011-06-21 Leo Liu <sdl.web@gmail.com>
5459
5460 * deps.mk (fns.o):
5461 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5462 sha512.h.
5463
5464 * fns.c (secure_hash): Rename from crypto_hash_function and change
5465 the first arg to accept symbols.
5b66d427 5466 (Fsecure_hash): New primitive.
7f3f739f
LL
5467 (syms_of_fns): New symbols.
5468
76147d94
DD
54692011-06-20 Deniz Dogan <deniz@dogan.se>
5470
5471 * process.c (Fset_process_buffer): Clarify return value in
5472 docstring.
5473
7d7d0045
CY
54742011-06-18 Chong Yidong <cyd@stupidchicken.com>
5475
5476 * dispnew.c (add_window_display_history): Use BVAR.
5477
5478 * xdisp.c (debug_method_add): Use BVAR.
5479 (check_window_end, dump_glyph_matrix, dump_glyph)
5480 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5481
5482 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5483 Likewise.
5484
5485 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5486 check till after the cache is created in init_frame_faces.
5487
ff2bc410
SM
54882011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5489
5490 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5491
28177add
PE
54922011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5493
dd3482fe
PE
5494 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5495 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5496 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5497
393d71f3 5498 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
5499 * fileio.c (Finsert_file_contents):
5500 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5501 Remove the old (too-loose) buffer overflow checks.
5502 They weren't needed, since make_gap checks for buffer overflow.
5503 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5504 The old code merely checked for Emacs fixnum overflow, and relied
5505 on undefined (wraparound) behavior. The new code avoids undefined
5506 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5507
2e6813b0 5508 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
5509 Tune. Don't use wider integers than needed. Don't use alloca.
5510 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 5511
599a9e4f
PE
5512 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5513
99561444
PE
5514 * insdel.c, lisp.h (buffer_overflow): New function.
5515 (insert_from_buffer_1, replace_range, replace_range_2):
5516 * insdel.c (make_gap_larger):
5517 * editfns.c (Finsert_char):
5518 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5519
28177add
PE
5520 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5521
e69dafad
PE
55222011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5523
4baa020d 5524 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 5525
b1c46f02
PE
5526 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5527 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5528
e69dafad
PE
5529 * fileio.c: Don't assume EMACS_INT fits in off_t.
5530 (emacs_lseek): New static function.
5531 (Finsert_file_contents, Fwrite_region): Use it.
5532 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5533
566684ea
PE
5534 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5535
e6966cd6
PE
5536 * fns.c: Don't overflow int when computing a list length.
5537 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5538 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5539 truncation on 64-bit hosts. Check for QUIT every
5540 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5541 faster and is responsive enough.
5542 (Flength): Report an error instead of overflowing an integer.
5543 (Fsafe_length): Return a float if the value is not representable
5544 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 5545 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 5546 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 5547
dd0b0efb
PE
5548 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5549 (header_size, word_size): New constants.
5550 (allocate_vectorlike): Don't check size overflow here.
5551 (allocate_vector): Check it here instead, since this is the only
5552 caller of allocate_vectorlike that could cause overflow.
5553 Check that the new vector's length is representable as a fixnum.
5554
86fe5cfe
PE
5555 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5556 The previous code was bogus. For example, next_almost_prime (32)
5557 returned 39, which is undesirable as it is a multiple of 3; and
5558 next_almost_prime (24) returned 25, which is a multiple of 5 so
5559 why was the code bothering to check for multiples of 7?
5560
80e88859
PE
5561 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5562
4a2f0ad6
PE
5563 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5564
f66c7cf8
PE
5565 Variadic C functions now count arguments with ptrdiff_t.
5566 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5567 Back then I didn't know that the Emacs coding style prefers signed int.
5568 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
5569 were being counted with int, which may truncate counts on 64-bit
5570 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
5571 * lisp.h (struct Lisp_Subr.function.aMANY)
5572 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5573 Arg counts are now ptrdiff_t, not size_t.
5574 All variadic functions and their callers changed accordingly.
5575 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5576 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5577 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5578 * callint.c (Fcall_interactively): Check arg count for overflow,
5579 to avoid potential buffer overrun. Use signed char, not 'int',
5580 for 'varies' array, so that we needn't bother to check its size
5581 calculation for overflow.
5582 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5583 * eval.c (apply_lambda):
5584 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5585 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5586 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5587
a1759b76
PE
5588 * callint.c (Fcall_interactively): Don't use index var as event count.
5589
d96be9fc
PE
5590 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5591 * mem-limits.h (SIZE): Remove; no longer used.
5592
a690a978 5593 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 5594
578c21e6
PE
5595 Remove unnecessary casts.
5596 * xterm.c (x_term_init):
5597 * xfns.c (x_set_border_pixel):
5598 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5599 These aren't needed now that we assume ANSI C.
5600
96f53c6c
PE
5601 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5602 It's more likely to cause problems (due to unsigned overflow)
5603 than to cure them.
5604
83c77d31
PE
5605 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5606
ee2079f1
PE
5607 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5608
6da65536
PE
5609 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5610
7147c4a4
PE
5611 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5612
193e32d9
PE
5613 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5614
e5533da6
PE
5615 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5616
9910e595
PE
5617 GLYPH_CODE_FACE returns EMACS_INT, not int.
5618 * dispextern.h (merge_faces):
5619 * xfaces.c (merge_faces):
01103c44
PE
5620 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5621 Don't assume EMACS_INT fits in int.
9910e595 5622
2638320e
PE
5623 * character.h (CHAR_VALID_P): Remove unused parameter.
5624 * fontset.c, lisp.h, xdisp.c: All uses changed.
5625
045eb8d9
PE
5626 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5627
c1f134b5
PE
5628 * fns.c (concat): Minor tuning based on overflow analysis.
5629 This doesn't fix any bugs. Use int to hold character, instead
5630 of constantly refetching from Emacs object. Use XFASTINT, not
5631 XINT, for value known to be a character. Don't bother comparing
5632 a single byte to 0400, as it's always less.
5633
395fcb93 5634 * floatfns.c (Fexpt):
327eeec8
PE
5635 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5636
abbd3d23
PE
5637 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5638 for characters.
5639
684a03ef
PE
5640 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5641
0fed43f3
PE
5642 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5643 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5644 incorrectly succeed when S was a string, because 4294967386 was
5645 truncated before it was used.
5646
8fd02eb7
PE
5647 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5648 Otherwise, an out-of-range integer could cause undefined behavior
5649 on a 64-bit host.
5650
f8c86b69
PE
5651 * composite.c: Use int, not EMACS_INT, for characters.
5652 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5653 EMACS_INT, for values that are known to be in character range.
5654 This doesn't fix any bugs but is the usual style inside Emacs and
5655 may generate better code on 32-bit machines.
5656
34206dd2
PE
5657 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5658 This is for reasons similar to the recent CHAR_STRING fix.
5659 * charset.c (Fencode_char): Check that character arg is actually
5660 a character. Pass an int to ENCODE_CHAR.
5661 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5662 wider than 'int', as a compile-time check to prevent future regressions
5663 in this area.
5664
c5958d4c 5665 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
5666
5667 Make sure a 64-bit char is never passed to CHAR_STRING.
5668 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5669 by silently ignoring the top 32 bits, allowing some values
5670 that were far too large to be valid characters.
5671 * character.h: Include <verify.h>.
5672 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5673 arguments are no wider than unsigned, as a compile-time check
5674 to prevent future regressions in this area.
5675 * data.c (Faset):
01103c44 5676 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
5677 (Fsubst_char_in_region):
5678 * fns.c (concat):
5679 * xdisp.c (decode_mode_spec_coding):
5680 Adjust to CHAR_STRING's new requirement.
5681 * editfns.c (Finsert_char, Fsubst_char_in_region):
5682 * fns.c (concat): Check that character args are actually
5683 characters. Without this test, these functions did the wrong
5684 thing with wildly out-of-range values on 64-bit hosts.
5685
d37ca623
PE
5686 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5687 These casts should not be needed on 32-bit hosts, either.
5688 * keyboard.c (read_char):
5689 * lread.c (Fload): Remove casts to unsigned.
5690
ea204efb
PE
5691 * lisp.h (UNSIGNED_CMP): New macro.
5692 This fixes comparison bugs on 64-bit hosts.
5693 (ASCII_CHAR_P): Use it.
5694 * casefiddle.c (casify_object):
01103c44 5695 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
5696 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5697 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5698 * dispextern.h (FACE_FROM_ID):
5699 * keyboard.c (read_char): Use UNSIGNED_CMP.
5700
41cb286c
PE
5701 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5702 not to EMACS_INT, to avoid GCC warning.
5703
4a1b9832
PE
5704 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5705
55daad71
PE
5706 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5707 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5708 isn't needed on 32-bit machines.
8f95c75c 5709
01103c44
PE
5710 * buffer.c (Fgenerate_new_buffer_name):
5711 Use EMACS_INT for count, not int.
0ceccced 5712 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
5713
5714 * data.c (Qcompiled_function): Now static.
5715
c6f072e7
PE
5716 * window.c (window_body_lines): Now static.
5717
20ce5912
PE
5718 * image.c (gif_load): Rename local to avoid shadowing.
5719
9c4c5f81
PE
5720 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5721 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5722 * alloc.c (make_save_value): Integer argument is now of type
5723 ptrdiff_t, not int.
5724 (mark_object): Use ptrdiff_t, not int.
5725 * lisp.h (pD): New macro.
5726 * print.c (print_object): Use it.
5727
c0c5c8ae
PE
5728 * alloc.c: Use EMACS_INT, not int, to count objects.
5729 (total_conses, total_markers, total_symbols, total_vector_size)
5730 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
5731 (total_free_floats, total_floats, total_free_intervals)
5732 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
5733 Now EMACS_INT, not int. All uses changed.
5734 (Fgarbage_collect): Compute overall total using a double, so that
5735 integer overflow is less likely to be a problem. Check for overflow
5736 when converting back to an integer.
5a25e253
PE
5737 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5738 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5739 These were 'int' variables that could overflow on 64-bit hosts;
5740 they were never used, so remove them instead of repairing them.
211a0b2a 5741 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
5742 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5743 Previously, this ceilinged at INT_MAX, but that doesn't work on
5744 64-bit machines.
e46bb31a 5745 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 5746
c78baabf 5747 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 5748 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
5749 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5750 when a (possibly-narrower) signed value would do just as well.
5751 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 5752
c9d624c6
PE
5753 * alloc.c: Catch some string size overflows that we were missing.
5754 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5755 for convenience in STRING_BYTES_MAX.
5756 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5757 The definition here is exact; the one in lisp.h was approximate.
5758 (allocate_string_data): Check for string overflow. This catches
5759 some instances we weren't catching before. Also, it catches
5760 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5761 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5762 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 5763
c9d624c6
PE
5764 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5765 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 5766 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 5767
353032ce
PE
5768 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5769
2bccce07
PE
5770 * alloc.c (Fmake_string): Check for out-of-range init.
5771
0ac30604
SM
57722011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5773
5774 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5775
c195f2de
JD
57762011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5777
5778 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5779 xg_get_default_scrollbar_width.
5780
5781 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5782 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5783 (style_changed_cb): Call update_theme_scrollbar_width and call
5784 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5785 all frames (Bug#8505).
5786 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5787 Call gtk_window_set_resizable if HAVE_GTK3.
5788 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5789 and height if HAVE_GTK3 (Bug#8505).
5790 (scroll_bar_width_for_theme): New variable.
5791 (update_theme_scrollbar_width): New function.
5792 (xg_get_default_scrollbar_width): Move code to
5793 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5794 (xg_initialize): Call update_theme_scrollbar_width.
5795
5796 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5797
5798 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5799
e10ac9f1
MR
58002011-06-12 Martin Rudalics <rudalics@gmx.at>
5801
5802 * frame.c (make_frame): Call other_buffer_safely instead of
5803 other_buffer.
5804
5805 * window.c (temp_output_buffer_show): Call display_buffer with
5806 second argument Vtemp_buffer_show_specifiers and reset latter
5807 immediately after the call.
5808 (Vtemp_buffer_show_specifiers): New variable.
5809 (auto_window_vscroll_p, next_screen_context_lines)
5810 (Vscroll_preserve_screen_position): Remove leading asterisks from
5811 doc-strings.
5812
2d3c217e 58132011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 5814
7b7f97e8 5815 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
5816 * buffer.c (Qclone_number): Remove for now, as it's unused.
5817 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5818 (record_buffer): Remove unused local.
5819 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5820 (set_frame_buffer_list): Remove; unused.
5821 * frame.h (other_visible_frames): Remove decl.
5822 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5823 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5824 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5825 if HAVE_GPM.
5826 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5827 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5828 Define only if HAVE_GPM.
5829 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5830 (update_hints_inhibit): Remove; never set. All uses removed.
5831 * widgetprv.h (emacsFrameClassRec): Remove decl.
5832 * window.c (delete_deletable_window): Now returns void, since it
5833 wasn't returning anything.
5834 (compare_window_configurations): Remove unused locals.
5835 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5836 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
5837 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5838 the same widths as pointers. This follows up on the 2011-05-06 patch.
5839 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5840 * xterm.h: Likewise.
5841 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5842
1384b89e
JB
58432011-06-12 Juanma Barranquero <lekktu@gmail.com>
5844
5845 * makefile.w32-in: Update dependencies.
5846 (LISP_H): Add lib/intprops.h.
5847
1100a63c
CY
58482011-06-11 Chong Yidong <cyd@stupidchicken.com>
5849
5850 * image.c (gif_load): Add animation frame delay to the metadata.
5851 (syms_of_image): Use DEFSYM. New symbol `delay'.
5852
6198ccd0
MR
58532011-06-11 Martin Rudalics <rudalics@gmx.at>
5854
5855 * window.c (delete_deletable_window): Re-add.
5856 (Fset_window_configuration): Rewrite to handle dead buffers and
5857 consequently deletable windows.
5858 (window_tree, Fwindow_tree): Remove. Supply functionality in
5859 window.el.
5860 (compare_window_configurations): Simplify code.
5861
b6e3633c
AS
58622011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5863
1ab0dee5
AS
5864 * image.c (imagemagick_load_image): Fix type mismatch.
5865 (Fimagemagick_types): Likewise.
5866
b6e3633c
AS
5867 * window.h (replace_buffer_in_windows): Declare.
5868
9397e56f
MR
58692011-06-11 Martin Rudalics <rudalics@gmx.at>
5870
5871 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5872 Qclone_number. Remove external declaration of Qdelete_window.
5873 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5874 code.
640c8776
SM
5875 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5876 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
5877 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5878 buffer list implementation.
5879 (other_buffer_safely): New function.
5880 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5881 calls to replace_buffer_in_windows and
5882 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5883 if allowed.
5884 (record_buffer): Inhibit quitting and rewrite using quittable
5885 functions. Run Qbuffer_list_update_hook if allowed.
5886 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
5887 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5888 Move switch-to-buffer to window.el.
9397e56f
MR
5889 (bury-buffer): Move to window.el.
5890 (Vbuffer_list_update_hook): New variable.
5891
5892 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5893 section.
5894
5895 * window.h (resize_frame_windows): Move up in code.
5896 (Fwindow_frame): Remove EXFUN.
5897 (replace_buffer_in_all_windows): Remove prototype.
5898 (replace_buffer_in_windows_safely): Add prototype.
5899
5900 * window.c: Declare Qdelete_window static again. Move down
5901 declaration of select_count.
5902 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5903 (Fother_window): Move to window.el.
5904 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5905 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5906 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5907 window.el.
5908 (replace_buffer_in_windows): Implement by calling
5909 Qreplace_buffer_in_windows.
5910 (replace_buffer_in_all_windows): Remove with some functionality
5911 moved into replace_buffer_in_windows_safely.
5912 (replace_buffer_in_windows_safely): New function.
5913 (select_window_norecord, select_frame_norecord): Move in front
5914 of run_window_configuration_change_hook. Remove now obsolete
5915 declarations.
640c8776
SM
5916 (Fset_window_buffer): Rewrite doc-string.
5917 Call Qrecord_window_buffer.
9397e56f
MR
5918 (keys_of_window): Move binding for other-window to window.el.
5919
b50691aa
CY
59202011-06-11 Chong Yidong <cyd@stupidchicken.com>
5921
5922 * dispextern.h (struct image): Replace data member, whose int_val
5923 and ptr_val fields were not used by anything, with a single
5924 lisp_val object.
5925
5926 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5927 (gif_clear_image, gif_load, imagemagick_load_image)
5928 (gs_clear_image, gs_load): Callers changed.
5929
3f754b86
PE
59302011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5931
cca69397
PE
5932 * buffer.h: Include <time.h>, for time_t.
5933 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5934
109e28d0
PE
5935 Fix minor problems found by static checking.
5936
60737f02
PE
5937 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5938
4b66faf3
PE
5939 Make identifiers static if they are not used in other modules.
5940 * data.c (Qcompiled_function, Qframe, Qvector):
5941 * image.c (QimageMagick, Qsvg):
5942 * minibuf.c (Qmetadata):
5943 * window.c (resize_window_check, resize_root_window): Now static.
5944 * window.h (resize_window_check, resize_root_window): Remove decls.
5945
109e28d0
PE
5946 * window.c (window_deletion_count, delete_deletable_window):
5947 Remove; unused.
46a4ce9e
PE
5948 (window_body_lines): Now static.
5949 (Fdelete_other_windows_internal): Mark vars as initialized.
5950 Make sure 'resize_failed' is initialized.
5951 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5952 (resize_window_apply): Remove unused local.
5953 * window.h (delete_deletable_window): Remove decl.
5954
109e28d0 5955 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
5956 (imagemagick_load_image): Fix pointer signedness problem by changing
5957 last arg from unsigned char * to char *. All uses changed.
5958 Also, fix a local for similar reasons.
5959 Remove unused locals. Remove locals to avoid shadowing.
5960 (fn_rsvg_handle_free): Remove; unused.
5961 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 5962 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 5963
3f754b86
PE
5964 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5965
2547adb1
CY
59662011-06-10 Chong Yidong <cyd@stupidchicken.com>
5967
5968 * image.c (gif_load): Fix omitted cast error introduced by
5969 2011-06-06 change.
5970
2c8e37d4
MR
59712011-06-10 Martin Rudalics <rudalics@gmx.at>
5972
5973 * window.h (resize_proportionally, orig_total_lines)
5974 (orig_top_line): Remove from window structure.
5975 (set_window_height, set_window_width, change_window_heights)
5976 (Fdelete_window): Remove prototypes.
5977 (resize_frame_windows): Remove duplicate declaration.
5978
440a42e3
EZ
59792011-06-10 Eli Zaretskii <eliz@gnu.org>
5980
5981 * window.h (resize_frame_windows, resize_window_check)
5982 (delete_deletable_window, resize_root_window)
5983 (resize_frame_windows): Declare prototypes.
5984
5985 * window.c (resize_window_apply): Make definition be "static" to
5986 match the prototype.
5987
562dd5e9
MR
59882011-06-10 Martin Rudalics <rudalics@gmx.at>
5989
5990 * window.c: Remove declarations of Qwindow_size_fixed,
5991 window_min_size_1, window_min_size_2, window_min_size,
5992 size_window, window_fixed_size_p, enlarge_window, delete_window.
5993 Remove static from declaration of Qdelete_window, it's
5994 temporarily needed by Fbury_buffer.
5995 (replace_window): Don't assign orig_top_line and
5996 orig_total_lines.
5997 (Fdelete_window, delete_window): Remove. Window deletion is
5998 handled by window.el.
640c8776
SM
5999 (window_loop): Remove DELETE_OTHER_WINDOWS case.
6000 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
6001 (Fdelete_other_windows): Remove. Deleting other windows is
6002 handled by window.el.
6003 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
6004 handled in window.el.
6005 (window_min_size_2, window_min_size_1, window_min_size): Remove.
6006 Window minimum sizes are handled in window.el.
6007 (shrink_windows, size_window, set_window_height)
6008 (set_window_width, change_window_heights, window_height)
6009 (window_width, CURBEG, CURSIZE, enlarge_window)
6010 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
6011 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
6012 handled in window.el.
6013 (make_dummy_parent): Rename to make_parent_window and give it a
6014 second argument horflag.
6015 (make_window): Don't set resize_proportionally any more.
6016 (Fsplit_window): Remove. Windows are split in window.el.
6017 (save_restore_action, save_restore_orig_size)
6018 (shrink_window_lowest_first, save_restore_orig_size): Remove.
6019 Resize mini windows in window.el.
6020 (grow_mini_window, shrink_mini_window): Implement by calling
6021 Qresize_root_window_vertically, resize_window_check and
6022 resize_window_apply.
640c8776
SM
6023 (saved_window, Fset_window_configuration, save_window_save):
6024 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
6025 resize_proportionally.
6026 (window_min_height, window_min_width): Move to window.el.
6027 (keys_of_window): Move bindings for delete-other-windows,
6028 split-window, delete-window and enlarge-window to window.el.
6029
6030 * buffer.c: Temporarily extern Qdelete_window.
6031 (Fbury_buffer): Temporarily call Qdelete_window instead of
6032 Fdelete_window (Fbury_buffer will move to window.el soon).
6033
6034 * frame.c (set_menu_bar_lines_1): Remove code handling
6035 orig_top_line and orig_total_lines.
6036
6037 * dispnew.c (adjust_frame_glyphs_initially): Don't use
6038 set_window_height but set heights directly.
6039 (change_frame_size_1): Use resize_frame_windows.
6040
6041 * xdisp.c (init_xdisp): Don't use set_window_height but set
6042 heights directly.
6043
640c8776
SM
6044 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
6045 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
6046 run_window_configuration_change_hook.
6047
6048 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
6049 instead of change_window_heights and run
6050 run_window_configuration_change_hook.
6051
1a13852e
MR
60522011-06-09 Martin Rudalics <rudalics@gmx.at>
6053
6054 * window.c (replace_window): Rename second argument REPLACEMENT to
6055 NEW. New third argument SETFLAG. Rewrite.
6056 (delete_window, make_dummy_parent): Call replace_window with
6057 third argument 1.
6058 (window_list_1): Move down in code.
6059 (run_window_configuration_change_hook): Move set_buffer part
6060 before select_frame_norecord part in order to unwind correctly.
6061 Rename count1 to count.
6062 (recombine_windows, delete_deletable_window, resize_root_window)
6063 (Fdelete_other_windows_internal)
6064 (Frun_window_configuration_change_hook, make_parent_window)
6065 (resize_window_check, resize_window_apply, Fresize_window_apply)
6066 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
6067 (Fdelete_window_internal, Fresize_mini_window_internal):
6068 New functions.
1a13852e
MR
6069 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
6070
f3d1777e
MR
60712011-06-08 Martin Rudalics <rudalics@gmx.at>
6072
496e208e
MR
6073 * window.h (window): Add some new members to window structure -
6074 normal_lines, normal_cols, new_total, new_normal, clone_number,
6075 splits, nest, prev_buffers, next_buffers.
6076 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 6077 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 6078
f3d1777e
MR
6079 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
6080 Remove.
496e208e
MR
6081 (make_dummy_parent): Set new members of windows structure.
6082 (make_window): Move down in code. Handle new members of window
6083 structure.
6084 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
6085 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
6086 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
6087 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
6088 (Fset_window_next_buffers, Fset_window_clone_number):
6089 New functions.
496e208e
MR
6090 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
6091 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
6092 Doc-string fixes.
6093 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
6094 Argument WINDOW can be now internal window too.
6095 (Fwindow_use_time): Move up in code.
6096 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
6097 Rewrite doc-string.
6098 (Fset_window_configuration, saved_window)
6099 (Fcurrent_window_configuration, save_window_save): Handle new
6100 members of window structure.
b9e809c2
MR
6101 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
6102 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
6103 (syms_of_window): New Lisp objects Qrecord_window_buffer,
6104 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
6105 Qget_mru_window, Qresize_root_window,
6106 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
6107 Qauto_buffer_name; staticpro them.
f3d1777e 6108
abde8f8c
MR
61092011-06-07 Martin Rudalics <rudalics@gmx.at>
6110
6111 * window.c (Fwindow_total_size, Fwindow_left_column)
6112 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
6113 (Fwindow_list_1): New functions.
6114 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
6115 (Fwindow_width, Fscroll_left, Fscroll_right):
6116 Use window_body_cols instead of window_box_text_cols.
6117 (delete_window, Fset_window_configuration):
6118 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
6119 (delete_all_subwindows): Take a window as argument and not a
6120 structure. Rewrite.
190b47e6
MR
6121 (window_loop): Remove handling of GET_LRU_WINDOW and
6122 GET_LARGEST_WINDOW.
6123 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
6124
6125 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
6126 window_box_text_cols. delete_all_subwindows now takes a
6127 Lisp_Object as argument.
abde8f8c 6128
640c8776
SM
6129 * indent.c (compute_motion, Fcompute_motion):
6130 Use window_body_cols instead of window_box_text_cols.
abde8f8c 6131
fa8a67e6
MR
6132 * frame.c (delete_frame): Call delete_all_subwindows with root
6133 window as argument.
6134
a54e3482
DC
61352011-06-07 Daniel Colascione <dan.colascione@gmail.com>
6136
6137 * fns.c (Fputhash): Document return value.
6138
60002bf5
CY
61392011-06-06 Chong Yidong <cyd@stupidchicken.com>
6140
6141 * image.c (gif_load): Implement gif89a spec "no disposal" method.
6142
0c671da6 61432011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 6144
b862a52a 6145 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 6146
be44ca6c
PE
6147 Check for overflow when converting integer to cons and back.
6148 * charset.c (Fdefine_charset_internal, Fdecode_char):
6149 Use cons_to_unsigned to catch overflow.
6150 (Fencode_char): Use INTEGER_TO_CONS.
6151 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
6152 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
6153 * data.c (long_to_cons, cons_to_long): Remove.
6154 (cons_to_unsigned, cons_to_signed): New functions.
6155 These signal an error for invalid or out-of-range values.
6156 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
6157 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
6158 * font.c (Ffont_variation_glyphs):
6159 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
6160 * lisp.h: Include <intprops.h>.
6161 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
6162 (cons_to_signed, cons_to_unsigned): New decls.
6163 (long_to_cons, cons_to_long): Remove decls.
6164 * undo.c (record_first_change): Use INTEGER_TO_CONS.
6165 (Fprimitive_undo): Use CONS_TO_INTEGER.
6166 * xfns.c (Fx_window_property): Likewise.
6167 * xselect.c: Include <limits.h>.
6168 (x_own_selection, selection_data_to_lisp_data):
6169 Use INTEGER_TO_CONS.
6170 (x_handle_selection_request, x_handle_selection_clear)
6171 (x_get_foreign_selection, Fx_disown_selection_internal)
6172 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
6173 (lisp_data_to_selection_data): Use cons_to_unsigned.
6174 (x_fill_property_data): Use cons_to_signed.
6175 Report values out of range.
6176
d1f3d2af
PE
6177 Check for buffer and string overflow more precisely.
6178 * buffer.h (BUF_BYTES_MAX): New macro.
6179 * lisp.h (STRING_BYTES_MAX): New macro.
6180 * alloc.c (Fmake_string):
6181 * character.c (string_escape_byte8):
6182 * coding.c (coding_alloc_by_realloc):
6183 * doprnt.c (doprnt):
6184 * editfns.c (Fformat):
6185 * eval.c (verror):
6186 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
6187 since they may not be the same number.
6188 * editfns.c (Finsert_char):
6189 * fileio.c (Finsert_file_contents):
6190 Likewise for BUF_BYTES_MAX.
6191
dd52fcea
PE
6192 * image.c: Use ptrdiff_t, not int, for sizes.
6193 (slurp_file): Switch from int to ptrdiff_t.
6194 All uses changed.
6195 (slurp_file): Check that file size fits in both size_t (for
6196 malloc) and ptrdiff_t (for sanity and safety).
6197
7f9bbdbb
PE
6198 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
6199 if b->modtime has its maximal value.
6200
dfe18f82
PE
6201 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
6202
84acfcf0
PE
6203 Don't assume time_t can fit into int.
6204 * buffer.h (struct buffer.modtime): Now time_t, not int.
6205 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
6206 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
6207
ccd9a01a
PE
6208 Minor fixes for signed vs unsigned integers.
6209 * character.h (MAYBE_UNIFY_CHAR):
6210 * charset.c (maybe_unify_char):
6211 * keyboard.c (read_char, reorder_modifiers):
6212 XINT -> XFASTINT, since the integer must be nonnegative.
6213 * ftfont.c (ftfont_spec_pattern):
6214 * keymap.c (access_keymap, silly_event_symbol_error):
6215 XUINT -> XFASTINT, since the integer must be nonnegative.
6216 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
6217 since it makes no difference and we prefer signed.
6218 * keyboard.c (record_char): Use XUINT when all the neighbors do.
6219 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
6220 nonnegative.
6221
d6d100dd
SM
62222011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
6223
6224 * window.h (Fwindow_frame): Declare.
6225
2b6148e4
PE
62262011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6227
6228 * alloc.c: Simplify handling of large-request failures (Bug#8800).
6229 (SPARE_MEMORY): Always define.
6230 (LARGE_REQUEST): Remove.
6231 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
6232
f230ecc9
MR
62332011-06-06 Martin Rudalics <rudalics@gmx.at>
6234
727e958e
MR
6235 * lisp.h: Move EXFUNS for Fframe_root_window,
6236 Fframe_first_window and Fset_frame_selected_window to window.h.
6237
6238 * window.h: Move EXFUNS for Fframe_root_window,
6239 Fframe_first_window and Fset_frame_selected_window here from
6240 lisp.h.
6241
6242 * frame.c (Fwindow_frame, Fframe_first_window)
6243 (Fframe_root_window, Fframe_selected_window)
6244 (Fset_frame_selected_window): Move to window.c.
6245 (Factive_minibuffer_window): Move to minibuf.c.
6246 (Fother_visible_frames_p): New function.
6247
6248 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
6249
f230ecc9
MR
6250 * window.c (decode_window, decode_any_window): Move up in code.
6251 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
6252 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
6253 (Fwindow_buffer): Move up and rewrite doc-string.
6254 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
6255 (Fwindow_prev): New functions.
727e958e
MR
6256 (Fwindow_frame): Move here from frame.c. Accept any window as
6257 argument.
6258 (Fframe_root_window, Fframe_first_window)
6259 (Fframe_selected_window): Move here from frame.c. Accept frame
6260 or arbitrary window as argument. Update doc-strings.
6261 (Fminibuffer_window): Move up in code.
6262 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
6263 (Fset_frame_selected_window): Move here from frame.c.
6264 Marginal rewrite.
727e958e
MR
6265 (Fselected_window, select_window, Fselect_window): Move up in
6266 code. Minor doc-string fixes.
f230ecc9 6267
4d09bcf6
PE
62682011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6269
6270 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
6271 Do not assume that spare memory exists; that assumption is valid
6272 only if SYSTEM_MALLOC.
6273 (LARGE_REQUEST): New macro, so that the issue of large requests
6274 is separated from the issue of spare memory.
6275
810928a2
AS
62762011-06-05 Andreas Schwab <schwab@linux-m68k.org>
6277
172418ad
AS
6278 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
6279 format. (Bug#8806)
6280
43f862f7
AS
6281 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
6282
810928a2
AS
6283 * xfns.c (x_set_scroll_bar_default_width): Move declarations
6284 before statements.
6285
a059fe24
JD
62862011-06-05 Jan Djärv <jan.h.d@swipnet.se>
6287
6288 * gtkutil.c (xg_get_default_scrollbar_width): New function.
6289
6290 * gtkutil.h: Declare xg_get_default_scrollbar_width.
6291
6292 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
6293 min width by calling x_set_scroll_bar_default_width (Bug#8505).
6294
989bf368
JB
62952011-06-05 Juanma Barranquero <lekktu@gmail.com>
6296
6297 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
6298
4b80f674
CY
62992011-06-04 Chong Yidong <cyd@stupidchicken.com>
6300
6301 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
6302 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
6303 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
6304 New error handlers.
4b80f674
CY
6305 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
6306 Obey Vx_select_enable_clipboard_manager. Catch errors in
6307 x_clipboard_manager_save (Bug#8779).
6308 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 6309 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 6310
99a33b77 63112011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
6312
6313 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
6314
99a33b77 63152011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
6316
6317 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
6318 in the current matrix if keep_current_p is non-zero.
6319
8264569d
EZ
63202011-06-04 Eli Zaretskii <eliz@gnu.org>
6321
6322 * bidi.c (bidi_level_of_next_char): Fix last change.
6323
57f97249
EZ
63242011-06-03 Eli Zaretskii <eliz@gnu.org>
6325
fec2107c 6326 Support bidi reordering of text covered by display properties.
57f97249 6327
fec2107c
EZ
6328 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
6329 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
6330 (bidi_cache_search, bidi_cache_iterator_state)
6331 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
6332 (bidi_level_of_next_char, bidi_move_to_visually_next):
6333 Support character positions inside a run of characters covered by a
fec2107c
EZ
6334 display string.
6335 (bidi_paragraph_init, bidi_resolve_explicit_1)
6336 (bidi_level_of_next_char): Call bidi_fetch_char and
6337 bidi_fetch_char_advance instead of FETCH_CHAR and
6338 FETCH_CHAR_ADVANCE.
6339 (bidi_init_it): Initialize new members.
6340 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
6341 definitions.
6342 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
6343 instead of using explicit *_CHAR codes.
d6d100dd
SM
6344 (bidi_resolve_explicit, bidi_resolve_weak):
6345 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
6346 bidirectional text is supported only in multibyte buffers.
6347 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
6348 it to initialize the frame_window_p member of struct bidi_it.
6349 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
6350 (bidi_resolve_explicit, bidi_resolve_weak)
6351 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
6352 bidi_it->nchars is non-positive.
6353 (bidi_level_of_next_char): Don't try to lookup the cache for the
6354 next/previous character if nothing is cached there yet, or if we
6355 were just reseat()'ed to a new position.
c40e2fb2 6356
0e14fe90
EZ
6357 * xdisp.c (set_cursor_from_row): Set start and stop points
6358 according to the row's direction when priming the loop that looks
6359 for the glyph on which to display cursor.
6360 (single_display_spec_intangible_p): Function deleted.
6361 (display_prop_intangible_p): Reimplement to call
6362 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
6363 Accept 3 additional arguments needed by handle_display_spec.
6364 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
6365 values: lists, `(when COND...)' forms, etc.
6366 (single_display_spec_string_p): Support property values that are
6367 lists with the argument STRING its top-level element.
6368 (display_prop_string_p): Fix the condition for processing a
6369 property that is a list to be consistent with handle_display_spec.
fec2107c 6370 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
6371 last portion of handle_display_prop.
6372 (compute_display_string_pos): Accept additional argument
6373 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6374 value of a `display' property is a "replacing spec".
6375 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6376 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6377 the display property, but just return a value indicating whether
6378 the display property will replace the characters it covers.
6379 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6380 frame_window_p members of struct bidi_it.
d6d100dd
SM
6381 (compute_display_string_pos, compute_display_string_end):
6382 New functions.
fec2107c
EZ
6383 (push_it): Accept second argument POSITION, where pop_it should
6384 jump to continue iteration.
6385 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 6386
fec2107c
EZ
6387 * keyboard.c (adjust_point_for_property): Adjust the call to
6388 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
6389
6390 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
6391 (bidi_init_it): Update prototypes.
6392 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
6393 (compute_display_string_pos, compute_display_string_end):
6394 Declare prototypes.
fec2107c
EZ
6395 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6396 EMACS_INT.
fc6f18ce 6397
40087514 63982011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 6399
57f53182
PE
6400 Malloc failure behavior now depends on size of allocation.
6401 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6402 * lisp.h: Change signatures accordingly.
6403 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6404 All callers changed. (Bug#8762)
6405
6406 * gnutls.c: Use Emacs's memory allocators.
6407 Without this change, the gnutls library would invoke malloc etc.
6408 directly, which causes problems on non-SYNC_INPUT hosts, and which
6409 runs afoul of improving memory_full behavior. (Bug#8761)
6410 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6411 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6412 xfree instead of the default malloc, realloc, free.
6413 (Fgnutls_boot): No need to check for memory allocation failure,
6414 since xmalloc does that for us.
6415
ac32cd99 6416 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
6417 * category.c (hash_get_category_set):
6418 * ccl.c (ccl_driver):
6419 * charset.c (Fdefine_charset_internal):
6420 * charset.h (struct charset.hash_index):
6421 * composite.c (get_composition_id, gstring_lookup_cache)
6422 (composition_gstring_put_cache):
6423 * composite.h (struct composition.hash_index):
6424 * dispextern.h (struct image.hash):
6425 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6426 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6427 (hashfn_equal, hashfn_user_defined, make_hash_table)
6428 (maybe_resize_hash_table, hash_lookup, hash_put)
6429 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6430 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6431 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6432 * image.c (make_image, search_image_cache, lookup_image)
6433 (xpm_put_color_table_h):
6434 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 6435 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 6436 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 6437 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
6438 * alloc.c (allocate_vectorlike):
6439 Check for overflow in vector size calculations.
6440 * ccl.c (ccl_driver):
6441 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
6442 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6443 need to be updated by these changes.
40087514
PE
6444 * fns.c (make_hash_table, maybe_resize_hash_table):
6445 Check for integer overflow with large hash tables.
0de4bb68
PE
6446 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6447 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6448 (SXHASH_REDUCE): New macro.
6449 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6450 Use it instead of discarding useful hash info with large hash values.
6451 (sxhash_float): New function.
6452 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6453 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
6454 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6455 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
6456 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6457 Adjust signatures to match updated version of code.
6458 (consing_since_gc): Now EMACS_INT, since a single hash table can
6459 use more than INT_MAX bytes.
6460
698d32e2
DN
64612011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6462
6463 Make it possible to build with GCC-4.6+ -O2 -flto.
6464
6465 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6466
fd6fa53f
SM
64672011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6468
6469 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6470 Call minibuffer-inactive-mode.
6471
864db017
JB
64722011-05-31 Juanma Barranquero <lekktu@gmail.com>
6473
6474 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6475 Update dependencies.
6476
2ad0baf4
DN
64772011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6478
6479 * data.c (init_data): Remove code for UTS, this system is not
6480 supported anymore.
6481
4fcc2638
DN
64822011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6483
6484 Don't force ./temacs to start in terminal mode.
6485
6486 * frame.c (make_initial_frame): Initialize faces in all cases, not
6487 only when CANNOT_DUMP is defined.
6488 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6489
c56e0fd5
DN
64902011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6491
6492 * dispnew.c (add_window_display_history): Use const for the string
6493 pointer. Remove declaration, not needed.
6494
333d54da 64952011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 6496
55d4c1b2 6497 Use 'inline', not 'INLINE'.
333d54da 6498 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
6499 * alloc.c, fontset.c (INLINE): Remove.
6500 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6501 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6502 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6503 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6504 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6505
738db178
DN
65062011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6507
6508 Make it possible to run ./temacs.
6509
6510 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6511 syms_of_callproc does the same thing. Remove test for
6512 "initialized", do it in the caller.
6513 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6514
620c53a6
SM
65152011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6516
6517 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6518 (read_minibuf): Use get_minibuffer.
6519 (syms_of_minibuf): Use DEFSYM.
6520 (Qmetadata): New var.
6521 * data.c (Qbuffer): Don't make it static.
6522 (syms_of_data): Use DEFSYM.
6523
e003a292
PE
65242011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6525
6526 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6527 (CCL_CODE_MIN): New macro.
6528
ed008a6d
PE
65292011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6530
3687c2ef
PE
6531 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6532
ed008a6d
PE
6533 * eval.c (Qdebug): Now static.
6534 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6535 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6536 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6537
d66c4c7c
CY
65382011-05-29 Chong Yidong <cyd@stupidchicken.com>
6539
6540 * image.c: Various fixes to ImageMagick code comments.
6541 (Fimagemagick_types): Doc fix.
6542
5fbc2025
PE
65432011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6544
0196f88a
PE
6545 Minor fixes prompted by GCC 4.6.0 warnings.
6546
6547 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6548
5fbc2025
PE
6549 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6550 (x_clipboard_manager_save_all): Move extern decl to ...
6551 * xterm.h: ... here, so that it can be checked for consistency.
6552
1dd3c2d9
CY
65532011-05-29 Chong Yidong <cyd@stupidchicken.com>
6554
6555 * xselect.c (x_clipboard_manager_save_frame)
6556 (x_clipboard_manager_save_all): New functions.
6557 (Fx_clipboard_manager_save): Lisp function deleted.
6558
6559 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6560 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6561
6562 * xterm.h: Update prototype.
6563
5ba6571d
WX
65642011-05-28 William Xu <william.xwl@gmail.com>
6565
6566 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6567 exiting (Bug#8239).
6568
3eaff834
JM
65692011-05-28 Jim Meyering <meyering@redhat.com>
6570
e1900994 6571 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
6572 * fns.c (to_uchar): Define.
6573 (crypto_hash_function): Use it to convert some newly-signed
6574 variables to unsigned, to avoid sign-extension bugs. For example,
6575 without this change, (md5 "truc") would evaluate to
6576 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6577 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 6578 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 6579
0f6990a7
PE
65802011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6581
6582 Integer overflow fixes.
c8a9ca5a 6583
08686060
PE
6584 * dbusbind.c: Serial number integer overflow fixes.
6585 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
6586 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6587 to hold a serial number that is too large for a fixnum.
6588 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6589 Check for serial numbers out of range. Decode any serial number
59568bf0 6590 that was so large that it became a float. (Bug#8722)
08686060 6591
2d1fc3c7
PE
6592 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6593 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6594 Use XFASTINT rather than XUINT when numbers are nonnegative.
6595 (xd_append_arg, Fdbus_method_return_internal):
6596 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6597 arguments, check that Lisp number is nonnegative, rather than
59568bf0 6598 silently wrapping negative numbers around. (Bug#8722)
30217ff0 6599 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 6600 (Bug#8722)
2d1fc3c7 6601
c8a9ca5a
PE
6602 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6603
519e1d69
PE
6604 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6605
6df6ae42 6606 ccl: Add integer overflow checks.
30569699
PE
6607 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6608 (IN_INT_RANGE): New macros.
6609 (ccl_driver): Use them to check for integer overflow when
6610 decoding a CCL program. Many of the new checks are whether XINT (x)
6611 fits in int; it doesn't always, on 64-bit hosts. The new version
6612 doesn't catch all possible integer overflows, but it's an
847044ea 6613 improvement. (Bug#8719)
30569699 6614
c11285dc
PE
6615 * alloc.c (make_event_array): Use XINT, not XUINT.
6616 There's no need for unsigned here.
6617
fdccd48e
PE
6618 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6619 This follows up to the 2011-05-06 change that substituted uintptr_t
6620 for EMACS_INT. This case wasn't caught back then.
6621
37910ab2
PE
6622 Rework Fformat to avoid integer overflow issues.
6623 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6624 now (part of C89). Include <verify.h>.
6625 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6626 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6627 (Fformat): Avoid the prepass trying to compute sizes; it was only
6628 approximate and thus did not catch overflow reliably. Instead, walk
6629 through the format just once, formatting and computing sizes as we go,
6630 checking for integer overflow at every step, and allocating a larger
6631 buffer as needed. Keep track separately whether the format is
6632 multibyte. Keep only the most-recently calculated precision, rather
6633 than them all. Record whether each argument has been converted to
6634 string. Use EMACS_INT, not int, for byte and char and arg counts.
6635 Support field widths and precisions larger than INT_MAX. Avoid
6636 sprintf's undefined behavior with conversion specifications such as %#d
6637 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6638 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6639 formatting out-of-range floating point numbers with int
9173deec 6640 formats. (Bug#8668)
37910ab2 6641
2e6578fb
PE
6642 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6643
0ae6bdee
PE
6644 * data.c: Avoid integer truncation in expressions involving floats.
6645 * data.c: Include <intprops.h>.
6646 (arith_driver): When there's an integer overflow in an expression
6647 involving floating point, convert the integers to floating point
6648 so that the resulting value does not suffer from catastrophic
6649 integer truncation. For example, on a 64-bit host (* 4
6650 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6651 Do not rely on undefined behavior after integer overflow.
6652
de883a70
PE
6653 merge count_size_as_multibyte, parse_str_to_multibyte
6654 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 6655 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
6656 Check for integer overflow.
6657 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6658 since it's now a duplicate of the other. This is more of
6659 a character than a buffer op, so better that it's in character.c.
6660 * fns.c, print.c: Adjust to above changes.
6661
2ff916cb
PE
66622011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6663
6664 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6665
f1b54466
PE
66662011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6667
fb1ac845
PE
6668 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6669 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6670 (x_clipboard_manager_save): Now static.
6671 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6672
f1b54466
PE
6673 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6674 (crypto_hash_function): Now static.
6675 Fix pointer signedness problems. Avoid unnecessary initializations.
6676
a9f737ee
CY
66772011-05-27 Chong Yidong <cyd@stupidchicken.com>
6678
6679 * termhooks.h (Vselection_alist): Make it terminal-local.
6680
6681 * terminal.c (create_terminal): Initialize it.
6682
6683 * xselect.c: Support for clipboard managers.
6684 (Vselection_alist): Move to termhooks.h as terminal-local var.
6685 (LOCAL_SELECTION): New macro.
6686 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6687 (symbol_to_x_atom): Remove gratuitous arg.
6688 (x_handle_selection_request, lisp_data_to_selection_data)
6689 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
6690 (x_own_selection, x_get_local_selection, x_convert_selection):
6691 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
6692 (some_frame_on_display): Delete unused function.
6693 (Fx_own_selection_internal, Fx_get_selection_internal)
6694 (Fx_disown_selection_internal, Fx_selection_owner_p)
6695 (Fx_selection_exists_p): New optional frame arg.
6696 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6697 (x_handle_selection_clear): Don't treat other terminals with the
6698 same keyboard specially. Use the terminal-local Vselection_alist.
6699 (x_clear_frame_selections): Use Frun_hook_with_args.
6700
6701 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6702
6703 * xterm.h: Add support for those atoms.
6704
e067f0c1
CY
67052011-05-26 Chong Yidong <cyd@stupidchicken.com>
6706
6707 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6708 (converted_selections, conversion_fail_tag): New global variables.
6709 (x_selection_request_lisp_error): Free the above.
6710 (x_get_local_selection): Remove unnecessary code.
6711 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
6712 of converted selections stored in converted_selections.
6713 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
6714 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6715 (x_convert_selection): New function.
6716 (x_handle_selection_event): Simplify.
6717 (x_get_foreign_selection): Don't ignore incoming requests while
6718 waiting for an answer; this will fail when we implement
6719 SAVE_TARGETS, and seems unnecessary anyway.
6720 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6721 (Vx_sent_selection_functions): Doc fix.
6722
0f4aebc0
LL
67232011-05-26 Leo Liu <sdl.web@gmail.com>
6724
6725 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6726
e61124cd
YM
67272011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6728
6729 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6730
6731 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6732 for fringe update if it has periodic bitmap.
ac389d0c 6733 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
6734 and fringe_bitmap_periodic_p.
6735
6736 * fringe.c (get_fringe_bitmap_data): New function.
6737 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6738 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6739 row. Mark glyph row for fringe update if periodicity changed.
6740
6741 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6742 for fringe update unless it has periodic bitmap.
6743
f16d9837
KH
67442011-05-25 Kenichi Handa <handa@m17n.org>
6745
6746 * xdisp.c (get_next_display_element): Set correct it->face_id for
6747 a static composition.
6748
e1b90ef6
LL
67492011-05-24 Leo Liu <sdl.web@gmail.com>
6750
6751 * deps.mk (fns.o):
6752 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6753
6754 * fns.c (crypto_hash_function, Fsha1): New function.
6755 (Fmd5): Use crypto_hash_function.
6756 (syms_of_fns): Add Ssha1.
6757
7400048f
PE
67582011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6759
6760 * gnutls.c: Remove unused macros.
6761 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6762 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6763 Remove macros that are defined and never used.
6764 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6765
abb71cf4
CY
67662011-05-22 Chong Yidong <cyd@stupidchicken.com>
6767
6768 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6769 (Fx_get_selection_internal): Minor cleanup.
6770 (Fx_own_selection_internal): Rename arguments for consistency with
6771 select.el.
6772
6307db39
PE
67732011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6774
6775 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6776
f3d4e0a4
CY
67772011-05-22 Chong Yidong <cyd@stupidchicken.com>
6778
6779 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6780
4d8ade89
YM
67812011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6782
6783 * dispnew.c (scrolling_window): Don't exclude the case that the
6784 last enabled row in the desired matrix touches the bottom boundary.
6785
32078c8d
GM
67862011-05-21 Glenn Morris <rgm@gnu.org>
6787
6788 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
6789 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6790 and add some more files.
32078c8d 6791
7285dc67
EZ
67922011-05-20 Eli Zaretskii <eliz@gnu.org>
6793
6794 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6795 report_file_error introduced by the change from 2011-05-07.
6796
89d1bd22
PE
67972011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6798
6799 * systime.h (Time): Define only if emacs is defined.
6800 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6801 where the include path doesn't have X11/X.h by default. See
6802 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6803
cd394be1 68042011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
6805
6806 * composite.c (find_automatic_composition): Fix previous change.
6807
b9704ad9
GM
68082011-05-20 Glenn Morris <rgm@gnu.org>
6809
6810 * lisp.mk: New file, split from Makefile.in.
6811 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6812 (shortlisp): Remove.
6813 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6814
4a720484
GM
68152011-05-19 Glenn Morris <rgm@gnu.org>
6816
6817 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6818 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6819 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6820 (lisp): Set the order to that of loadup.el.
6821 (shortlisp): Make it a copy of $lisp.
6822 (SOME_MACHINE_LISP): Remove.
6823 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6824 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6825
a28d4396
KH
68262011-05-18 Kenichi Handa <handa@m17n.org>
6827
6828 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6829 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6830 (find_automatic_composition): Mostly rewrite for efficiency.
6831
a2b1fa8e
JB
68322011-05-18 Juanma Barranquero <lekktu@gmail.com>
6833
6834 * makefile.w32-in: Update dependencies.
6835
8e1f5610
CS
68362011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6837
6838 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 6839 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 6840
7025ee00 68412011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 6842
cdfa6eab
PE
6843 Fix some integer overflow issues, such as string length overflow.
6844
06d6db33
PE
6845 * insdel.c (count_size_as_multibyte): Check for string overflow.
6846
2b4560a8
PE
6847 * character.c (lisp_string_width): Check for string overflow.
6848 Use EMACS_INT, not int, for string indexes and lengths; in
6849 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6850 the resulting string length overflows an EMACS_INT; instead,
6851 report a string overflow if no precision given. When checking for
6852 precision exhaustion, use a check that cannot possibly have
6853 integer overflow. (Bug#8675)
6854 * character.h (lisp_string_width): Adjust to new signature.
6855
cb93f9be
PE
6856 * alloc.c (string_overflow): New function.
6857 (Fmake_string): Use it. This doesn't change behavior, but saves
6858 a few bytes and will simplify future changes.
6859 * character.c (string_escape_byte8): Likewise.
6860 * lisp.h (string_overflow): New decl.
6861
1a1f3366
PE
6862 Fixups, following up to the user-interface timestamp change.
6863 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6864 for UI timestamps, instead of unsigned long.
9fbd6841
PE
6865 * msdos.c (mouse_get_pos): Likewise.
6866 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
6867 * w32gui.h (Time): Define by including "systime.h" rather than by
6868 declaring it ourselves. (Bug#8664)
6869
d4e3e4d3
PE
6870 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6871 * image.c (clear_image_cache): Likewise.
6872
f6a24d19
PE
6873 * term.c (term_mouse_position): Don't assume time_t wraparound.
6874
08dc5ae6
PE
6875 Be more systematic about user-interface timestamps.
6876 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
6877 and sometimes 'EMACS_UINT', to represent these timestamps.
6878 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
6879 This makes the code easier to follow, and makes it easier to catch
6880 integer overflow bugs such as Bug#8664.
6881 * frame.c (Fmouse_position, Fmouse_pixel_position):
6882 Use Time, not unsigned long, for user-interface timestamps.
6883 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6884 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6885 * keyboard.h (last_event_timestamp): Likewise.
6886 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6887 * menu.h (xmenu_show): Likewise.
6888 * term.c (term_mouse_position): Likewise.
6889 * termhooks.h (struct input_event.timestamp): Likewise.
6890 (struct terminal.mouse_position_hook): Likewise.
6891 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6892 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6893 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6894 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6895 what it was before.
6896 * menu.h, termhooks.h: Include "systime.h", for Time.
6897
8e55734a
PE
6898 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6899 Don't assume that the difference between two unsigned long values
6900 can fit into an integer. At this point, we know button_down_time
6901 <= event->timestamp, so the difference must be nonnegative, so
6902 there's no need to cast the result if double-click-time is
6903 nonnegative, as it should be; check that it's nonnegative, just in
6904 case. This bug is triggered when events are more than 2**31 ms
86db42d2 6905 apart (about 25 days). (Bug#8664)
8e55734a 6906
841f1b75 6907 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 6908 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 6909
3e26f69c
PE
6910 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6911 that always fit in int. Use a sentinel instead of a counter, to
6912 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
6913 * frame.h (struct frame): Use int for menu_bar_items_used
6914 instead of EMACS_INT, since it always fits in int.
3e26f69c 6915
5cc152c0
PE
6916 * menu.c (grow_menu_items): Check for int overflow.
6917
d89eb65e
PE
6918 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6919
5235bd3e
PE
6920 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6921 Before, the code was not consistent. These values cannot exceed
6922 2**31 - 1 so there's no need to make them unsigned.
6923 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6924 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6925 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6926 as modifiers.
6927 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6928
bc827e23
PE
6929 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6930 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6931 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6932 presumably because the widths might not match.
6933
78eb494e
PE
6934 * window.c (size_window): Avoid needless test at loop start.
6935
04f2d78b
CB
69362011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6937
6938 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6939
d2fc7e3d 69402011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
6941
6942 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6943
d2fc7e3d 69442011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
6945
6946 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6947 `width' to `bar_area_x' and `bar_area_width', respectively.
6948 (x_scroll_run): Take account of fringe background extension.
6949
04f2d78b
CB
6950 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6951 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
6952 `bar_area_width', respectively.
6953 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6954 background extension.
6955
79b70037
GM
69562011-05-10 Jim Meyering <meyering@redhat.com>
6957
6958 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6959
2f142cc5
JB
69602011-05-10 Juanma Barranquero <lekktu@gmail.com>
6961
6962 * image.c (Finit_image_library): Return t for built-in image types,
6963 like pbm and xbm. (Bug#8640)
6964
57679c86
AS
69652011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6966
6967 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6968
888c9e86
EZ
69692011-05-07 Eli Zaretskii <eliz@gnu.org>
6970
b0512a1d
EZ
6971 * w32console.c (Fset_screen_color): Doc fix.
6972 (Fget_screen_color): New function.
6973 (syms_of_ntterm): Defsubr it.
6974
7285dc67
EZ
6975 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6976 unlink the temporary file if Fcall_process didn't create it in the
6977 first place.
6978 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6979 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
6980 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6981 cue to call_process_cleanup not to close that handle.
6982
4d3fcc8e
BK
69832011-05-07 Ben Key <bkey76@gmail.com>
6984
6985 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6986 one of two shell specific rules, either bootstrap-temacs-CMD or
6987 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6988 to the previous implementation of the bootstrap-temacs rule.
6989 The bootstrap-temacs-CMD rule is similar to the previous
6990 implementation of the bootstrap-temacs rule except that it
6991 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6992 variable.
6993
6994 These changes, along with some changes to nt/configure.bat,
6995 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6996 earlier fix to add support for --cflags and --ldflags options
6997 that include quotes so that it works whether make uses cmd or
6998 sh as the shell.
6999
b4289b64
MA
70002011-05-06 Michael Albinus <michael.albinus@gmx.de>
7001
7002 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
7003 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
7004 is a constant.
7005 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
7006 a string. Handle both cases.
7007 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
7008 (Fdbus_register_method): Use Qinvalid_function.
7009
af4c0e28
JB
70102011-05-06 Juanma Barranquero <lekktu@gmail.com>
7011
7012 * makefile.w32-in: Update dependencies.
7013 (LISP_H): Add inttypes.h and stdin.h.
7014 (PROCESS_H): Add unistd.h.
7015
c51453d9
EZ
70162011-05-06 Eli Zaretskii <eliz@gnu.org>
7017
7018 * lread.c: Include limits.h (fixes the MS-Windows build broken by
7019 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
7020
8ff0ac3c 70212011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 7022
4c4b566b
PE
7023 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
7024
aab2b9b5
PE
7025 * term.c (vfatal): Remove stray call to va_end.
7026 It's not needed and the C Standard doesn't allow it here anyway.
7027
c378da0b
PE
7028 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
7029 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
7030
288b08c7
PE
7031 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
7032 bytes.
7033
e3601888
PE
7034 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
7035
db6c0e74
PE
7036 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7037
dd5963ea
PE
7038 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
7039
88c9450f
PE
7040 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
7041
2f9442b8
PE
7042 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
7043
c032b5f8
PE
7044 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
7045 * charset.c (Fdefine_charset_internal): Don't initialize
7046 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 7047 32-bit int (Bug#8600).
a108c10b
PE
7048
7049 * lread.c (read_integer): Be more consistent with string-to-number.
7050 Use string_to_number to do the actual conversion; this avoids
7051 rounding errors and fixes some other screwups. Without this fix,
7052 for example, #x1fffffffffffffff was misread as -2305843009213693952.
7053 (digit_to_number): Move earlier, for benefit of read_integer.
7054 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 7055 not a digit in any supported base. (Bug#8602)
a108c10b 7056
ad5f9eea
PE
7057 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
7058
aec1708a
PE
7059 * dispnew.c (scrolling_window): Return 1 if we scrolled,
7060 to match comment at start of function. This also removes a
7061 GCC warning about overflow in a 32+64-bit port.
7062
47be4ab5
PE
7063 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
7064
371cac43
PE
7065 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
7066 Reported by Stefan Monnier in
7067 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
7068 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
7069 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 7070
d01a7826
PE
7071 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
7072 (EMACS_UINTPTR): Likewise, with uintptr_t.
7073
7fd47d5c
PE
7074 * lisp.h: Prefer 64-bit EMACS_INT if available.
7075 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
7076 on 32-bit hosts that have 64-bit int, so that they can access
7077 large files.
122b0c86
PE
7078 However, temporarily disable this change unless the temporary
7079 symbol WIDE_EMACS_INT is defined.
7fd47d5c 7080
8727937b
PE
7081 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
7082
8ac068ac
PE
7083 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
7084 This removes an assumption that EMACS_INT and long are the same
7085 width as pointers. The assumption is true for Emacs porting targets
7086 now, but we want to make other targets possible.
7087 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
7088 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
7089 In the rest of the code, change types of integers that hold casted
7090 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
7091 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
7092 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
7093 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
7094 No need to cast type when ORing.
7095 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
7096 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
7097 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
7098 assume EMACS_INT is the same width as char *.
7099 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
7100 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
7101 Remove no-longer-needed casts.
7102 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
7103 (xg_tool_bar_help_callback, xg_make_tool_item):
7104 Use EMACS_INTPTR to hold an integer
7105 that will be cast to void *; this can avoid a GCC warning
7106 if EMACS_INT is not the same width as void *.
7107 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
7108 * xdisp.c (display_echo_area_1, resize_mini_window_1):
7109 (current_message_1, set_message_1):
7110 Use a local to convert to proper width without a cast.
7111 * xmenu.c (dialog_selection_callback): Likewise.
7112
ede49d71
PE
7113 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
7114 Also, don't assume VALBITS / RAND_BITS is less than 5,
7115 and don't rely on undefined behavior when shifting a 1 left into
7116 the sign bit.
7117 * lisp.h (get_random): Change signature to match.
7118
2f30ecd0
PE
7119 * lread.c (hash_string): Use size_t, not int, for hash computation.
7120 Normally we prefer signed values; but hashing is special, because
7121 it's better to use unsigned division on hash table sizes so that
7122 the remainder is nonnegative. Also, size_t is the natural width
7123 for hashing into memory. The previous code used 'int', which doesn't
7124 retain enough info to hash well into very large tables.
7125 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
7126
2a866e7b
PE
7127 * dbusbind.c: Don't possibly lose pointer info when converting.
7128 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
7129 Use XPNTR rather than XHASH, so that the high-order bits of
7130 the pointer aren't lost when converting through void *.
7131
51639eac
PE
7132 * eval.c (Fautoload): Don't double-shift a pointer.
7133
92394119
PE
7134 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
7135
dbdb9a7c
JB
71362011-05-06 Juanma Barranquero <lekktu@gmail.com>
7137
7138 * gnutls.c (DEF_GNUTLS_FN):
7139 * image.c (DEF_IMGLIB_FN): Make function pointers static.
7140
db7a0b4f
AS
71412011-05-05 Andreas Schwab <schwab@linux-m68k.org>
7142
7143 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
7144 marker. (Bug#8610)
7145
cd394be1 71462011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
7147
7148 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
7149 New version that can reserve upto 2GB of heap space.
7150
f7ff1b0f 71512011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
7152
7153 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
7154
639c109b
TZ
71552011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
7156
7157 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
7158 `gnutls_certificate_set_x509_key_file'.
7159
d2127135
JB
71602011-05-05 Juanma Barranquero <lekktu@gmail.com>
7161
7162 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
7163 Update dependencies.
7164
e968f4f3
JB
71652011-05-04 Juanma Barranquero <lekktu@gmail.com>
7166
7167 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
7168 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
7169 Remove unused parameter `fildes'.
7170 * process.c (read_process_output, send_process): Don't pass it.
7171
84d358f0
JB
71722011-05-04 Juanma Barranquero <lekktu@gmail.com>
7173
7174 Fix previous change: the library cache is defined in w32.c.
7175 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
7176 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
7177
0898ca10
JB
71782011-05-04 Juanma Barranquero <lekktu@gmail.com>
7179
7180 Implement dynamic loading of GnuTLS on Windows.
7181
7182 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
7183 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
7184 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7185 Declare.
7186
7187 * gnutls.c (Qgnutls_dll): Define.
7188 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
7189 (gnutls_*): Declare function pointers.
7190 (init_gnutls_functions): New function to initialize function pointers.
7191 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
7192 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
7193 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7194 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
7195 (emacs_gnutls_write, emacs_gnutls_read)
7196 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
7197 (Fgnutls_available_p): New function.
7198 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
7199 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
7200 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
7201
7202 * image.c: Include w32.h.
7203 (Vimage_type_cache): Delete.
7204 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
7205 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
7206 (w32_delayed_load): Move to w32.c.
7207
7208 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
7209
7210 * w32.c (QCloaded_from, Vlibrary_cache): Define.
7211 (w32_delayed_load): Move from image.c. When loading a library, record
7212 its filename in the :loaded-from property of the library id.
7213 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
7214 Initialize and staticpro them.
7215 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
7216
7217 * process.c: Include lisp.h before w32.h, not after.
7218 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
7219 instead of gnutls_record_check_pending.
7220
7221 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
7222
ff4de4aa
TZ
72232011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
7224
7225 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
7226 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
7227 as passed in.
7228
abe95abb
JD
72292011-05-03 Jan Djärv <jan.h.d@swipnet.se>
7230
7231 * xterm.c (x_set_frame_alpha): Do not set property on anything
7232 else than FRAME_X_OUTER_WINDOW (Bug#8608).
7233
e16e55d4
JB
72342011-05-02 Juanma Barranquero <lekktu@gmail.com>
7235
7236 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
7237
bafcf6a5
JB
72382011-05-02 Juanma Barranquero <lekktu@gmail.com>
7239
7240 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
7241 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
7242 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
7243 (gnutls_global_initialized, Qgnutls_bootprop_priority)
7244 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
7245 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
7246 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
7247 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
7248 (Qgnutls_bootprop_callbacks_verify): Make static.
7249
e7a6747f
AS
72502011-05-01 Andreas Schwab <schwab@linux-m68k.org>
7251
19ed11ba
AS
7252 * callproc.c: Indentation fixup.
7253
e7a6747f 7254 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
7255 (wait_for_termination, interruptible_wait_for_termination):
7256 Move after wait_for_termination_1.
e7a6747f 7257
1ef14cb4
LMI
72582011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
7259
7260 * sysdep.c (interruptible_wait_for_termination): New function
7261 which is like wait_for_termination, but allows keyboard
7262 interruptions.
7263
7264 * callproc.c (Fcall_process): Add (:file "file") as an option for
7265 the STDOUT buffer.
7266 (Fcall_process_region): Ditto.
7267
330d880c
EZ
72682011-04-30 Eli Zaretskii <eliz@gnu.org>
7269
8db90b73
EZ
7270 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
7271 rather than `XVECTOR (FOO)->size'.
7272
330d880c
EZ
7273 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
7274 inttypes.h, as a gnulib replacement is used if it not available in
7275 system headers.
7276
15cbd324
EZ
72772011-04-21 Eli Zaretskii <eliz@gnu.org>
7278
7279 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
7280 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
7281 of MOST_POSITIVE_FIXNUM. (Bug#8528)
7282
7283 * coding.c (coding_alloc_by_realloc): Error out if destination
7284 will grow beyond MOST_POSITIVE_FIXNUM.
7285 (decode_coding_emacs_mule): Abort if there isn't enough place in
7286 charbuf for the composition carryover bytes. Reserve an extra
7287 space for up to 2 characters produced in a loop.
7288 (decode_coding_iso_2022): Abort if there isn't enough place in
7289 charbuf for the composition carryover bytes.
7290
72912011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 7292
ae940cca
EZ
7293 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
7294 aborting when %lld or %lll format is passed.
7295 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
7296 %llo or %llx format is passed. (Bug#8545)
7297
03ab8921
EZ
7298 * window.c (window_scroll_line_based): Use a marker instead of
7299 simple variables to record original value of point. (Bug#7952)
7300
afda1437
EZ
7301 * doprnt.c (doprnt): Fix the case where a multibyte sequence
7302 produced by %s or %c overflows available buffer space. (Bug#8545)
7303
f76dee0c
PE
73042011-04-28 Paul Eggert <eggert@cs.ucla.edu>
7305
7306 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 7307 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 7308
fdc5744d
JB
73092011-04-28 Juanma Barranquero <lekktu@gmail.com>
7310
7311 * w32.c (init_environment): Warn about defaulting HOME to C:\.
7312
638f053a
JB
73132011-04-28 Juanma Barranquero <lekktu@gmail.com>
7314
7315 * keyboard.c (Qdelayed_warnings_hook): Define.
7316 (command_loop_1): Run `delayed-warnings-hook'
7317 if Vdelayed_warnings_list is non-nil.
7318 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
7319 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
7320
d178f871
EZ
73212011-04-28 Eli Zaretskii <eliz@gnu.org>
7322
7323 * doprnt.c (doprnt): Don't return value smaller than the buffer
7324 size if the message was truncated. (Bug#8545).
7325
b124fd93
JB
73262011-04-28 Juanma Barranquero <lekktu@gmail.com>
7327
7328 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
7329 (Fx_window_property): #if-0 the whole functions, not just the bodies.
7330
e810457d
PE
73312011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7332
7333 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
7334
ea51cceb
JB
73352011-04-27 Juanma Barranquero <lekktu@gmail.com>
7336
7337 * makefile.w32-in: Update dependencies.
7338
94dcfacf
EZ
73392011-04-27 Eli Zaretskii <eliz@gnu.org>
7340
7341 Improve `doprnt' and its usage. (Bug#8545)
7342 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
7343 `format_end'. Remove support for %l as a conversion specifier.
7344 Don't use xrealloc. Improve diagnostics when the %l size modifier
7345 is used. Update the commentary.
7346
7347 * eval.c (verror): Simplify calculation of size_t.
7348
7349 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
7350 messages.
7351
f61f41d7
PE
73522011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
7353
7354 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
7355 change.
7356
96fb4434
PE
73572011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7358
7359 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
7360 This makes this file independent of the recent pseudovector change.
7361
671875da 73622011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 7363
69e9b5a3
PE
7364 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
7365
b5f869a7 7366 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 7367 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 7368 Remove unused local.
c8926152 7369 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 7370
841a1577 7371 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
7372 GCC 4.6.0 optimizes based on type-based alias analysis.
7373 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
7374 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7375 != &v->size, and therefore "v->size = 1; b->size = 2; return
7376 v->size;" must therefore return 1. This assumption is incorrect
7377 for Emacs, since it type-puns struct Lisp_Vector * with many other
7378 types. To fix this problem, this patch adds a new type struct
f904488f 7379 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
7380 and pseudovectors, and helps optimizing compilers not get fooled
7381 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7382 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
7383 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7384 the size member.
eab3844f
PE
7385 (XSETPVECTYPE): Rewrite in terms of new macro.
7386 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7387 This is a bit clearer, and further avoids the possibility of
7388 undesirable aliasing.
7389 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 7390 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
7391 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7392 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
7393 (ASIZE): Now uses header.size rather than size.
7394 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
7395 to avoid the hassle of writing XVECTOR (foo)->header.size.
7396 (struct vectorlike_header): New type.
eab3844f
PE
7397 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7398 object, to help avoid aliasing.
7399 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7400 (SUBRP): Likewise, since Lisp_Subr is a special case.
7401 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7402 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7403 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 7404 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
7405 changed to be "header.size" and "header.next".
7406 * buffer.h (struct buffer): Likewise.
7407 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7408 * frame.h (struct frame): Likewise.
7409 * process.h (struct Lisp_Process): Likewise.
7410 * termhooks.h (struct terminal): Likewise.
7411 * window.c (struct save_window_data, struct saved_window): Likewise.
7412 * window.h (struct window): Likewise.
7413 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7414 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7415 * buffer.c (init_buffer_once): Likewise.
7416 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7417 special case.
7418 * process.c (Fformat_network_address): Use local var for size,
7419 for brevity.
7420
0df1eac5
PE
7421 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7422
847ab9d1 7423 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
7424 * data.c (atof): Remove decl; no longer used or needed.
7425 (digit_to_number): Move to lread.c.
7426 (Fstring_to_number): Use new string_to_number function, to be
7427 consistent with how the Lisp reader treats infinities and NaNs.
7428 Do not assume that floating-point numbers represent EMACS_INT
7429 without losing information; this is not true on most 64-bit hosts.
7430 Avoid double-rounding errors, by insisting on integers when
7431 parsing non-base-10 numbers, as the documentation specifies.
7432 * lisp.h (string_to_number): New decl, replacing ...
7433 (isfloat_string): Remove.
bc0a5c13 7434 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 7435 (read1): Do not accept +. and -. as integers; this
452f4150
PE
7436 appears to have been a coding error. Similarly, do not accept
7437 strings like +-1e0 as floating point numbers. Do not report
7438 overflow for integer overflows unless the base is not 10 which
7439 means we have no simple and reliable way to continue.
7440 Break out the floating-point parsing into a new
7441 function string_to_number, so that Fstring_to_number parses
7442 floating point numbers consistently with the Lisp reader.
04f2d78b 7443 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
7444 (E_CHAR, EXP_INT): Remove, replacing with ...
7445 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7446 (string_to_number): New function, replacing isfloat_string.
7447 This function checks for valid syntax and produces the resulting
7448 Lisp float number too. Rework it so that string-to-number
bc0a5c13 7449 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
7450 so that overflow for non-base-10 numbers is reported only when
7451 there's no portable and simple way to convert to floating point.
452f4150 7452
67769ffc
PE
7453 * textprop.c (set_text_properties_1): Rewrite for clarity,
7454 and to avoid GCC warning about integer overflow.
7455
c20db43f
PE
7456 * intervals.h (struct interval): Use EMACS_INT for members
7457 where EMACS_UINT might cause problems. See
7458 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7459 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7460 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7461 All uses changed.
37aa2f85
PE
7462 (offset_intervals): Tell GCC not to worry about length overflow
7463 when negating a negative length.
c20db43f 7464
2538aa2f
PE
7465 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7466 (overrun_check_free): Likewise.
7467
f2d3008d
PE
7468 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7469 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7470 word size.
7471
ec8df744
PE
7472 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7473 (gnutls_make_error): Rename local to avoid shadowing.
7474 (gnutls_emacs_global_deinit): ifdef out; not used.
7475 (Fgnutls_boot): Use const for pointer to readonly storage.
7476 Comment out unused local. Fix pointer signedness problems.
7477
640ee02d
PE
7478 * lread.c (openp): Don't stuff size_t into an 'int'.
7479 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7480 about possible signed overflow.
7481
6048fb2a
PE
7482 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7483 (GDK_KEY_g): Don't define if already defined.
7484 (xg_prepare_tooltip): Avoid pointer signedness problem.
7485 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7486
fa3c87e1
PE
7487 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7488 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7489
2172544b
PE
7490 * xfns.c (Fx_window_property): Simplify a bit,
7491 to make a bit faster and to avoid GCC 4.6.0 warning.
7492 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7493
9b821a21
PE
7494 * fns.c (internal_equal): Don't assume size_t fits in int.
7495
3c616cfa
PE
7496 * alloc.c (compact_small_strings): Tighten assertion a little.
7497
c2982e87
PE
7498 Replace pEd with more-general pI, and fix some printf arg casts.
7499 * lisp.h (pI): New macro, generalizing old pEd macro to other
7500 conversion specifiers. For example, use "...%"pI"d..." rather
7501 than "...%"pEd"...".
7502 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 7503 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
7504 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7505 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7506 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7507 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7508 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7509 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7510 64-bit hosts.
7511 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7512 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7513 * print.c (safe_debug_print, print_object): Likewise.
7514 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7515 to int.
6f04d126
PE
7516 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7517 avoiding the 0 flag, which is not portable.
c2982e87
PE
7518 * process.c (Fmake_network_process): Use pI to avoid cast.
7519 * region-cache.c (pp_cache): Likewise.
7520 * xdisp.c (decode_mode_spec): Likewise.
7521 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7522 behavior on 64-bit hosts with printf arg.
6f04d126 7523 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
7524 (x_stop_queuing_selection_requests): Likewise.
7525 (x_get_window_property): Don't truncate byte count to an 'int'
7526 when tracing.
0b432f21 7527
5e073ec7
PE
7528 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7529 here, since it parses constructs like leading '-' and spaces,
7530 which are not wanted; and it overflows with large numbers.
7531 Instead, simply match F[0-9]+, which is what is wanted anyway.
7532
36372bf9
PE
7533 * alloc.c: Remove unportable assumptions about struct layout.
7534 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7535 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7536 (allocate_vectorlike, make_pure_vector): Use the new macros,
7537 plus offsetof, to remove unportable assumptions about struct layout.
7538 These assumptions hold on all porting targets that I know of, but
7539 they are not guaranteed, they're easy to remove, and removing them
7540 makes further changes easier.
7541
0b432f21
PE
7542 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7543 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
7544 (string_overrun_cookie): Now const. Use initializers that
7545 don't formally overflow signed char, to avoid warnings.
000098c1
PE
7546 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7547 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
7548 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7549 multiple of sizeof (EMACS_INT); it need not be, if
7550 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 7551 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 7552
895009e1
JB
75532011-04-26 Juanma Barranquero <lekktu@gmail.com>
7554
7555 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7556
6a7a1b0b
TZ
75572011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7558
7559 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 7560 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
7561 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7562
841a1577 75632011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
7564
7565 * lisp.h (Qdebug): List symbol.
895009e1 7566 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
7567 * keyboard.c (debug-on-event): New variable.
7568 (handle_user_signal): Break into debugger when debug-on-event
7569 matches the current signal symbol.
7570
f2d3ba6f
DN
75712011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7572
7573 * alloc.c (check_sblock, check_string_bytes)
7574 (check_string_free_list): Convert to standard C.
7575
42ce4c63
TZ
75762011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7577
7578 * w32.c (emacs_gnutls_push): Fix typo.
7579
825cd63c
EZ
75802011-04-25 Eli Zaretskii <eliz@gnu.org>
7581
fb11d64d
EZ
7582 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7583 "cast to pointer from integer of different size".
7584
825cd63c
EZ
7585 Improve doprnt and its use in verror. (Bug#8545)
7586 * doprnt.c (doprnt): Document the set of format control sequences
7587 supported by the function. Use SAFE_ALLOCA instead of always
7588 using `alloca'.
7589
7590 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7591 is one byte too soon. Don't use xrealloc; instead xfree and
7592 xmalloc anew.
7593
e061a11b
TZ
75942011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7595
7596 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7597 callbacks stage.
7598
7599 * gnutls.c: Renamed global_initialized to
7600 gnutls_global_initialized. Added internals for the
7601 :verify-hostname-error, :verify-error, and :verify-flags
7602 parameters of `gnutls-boot' and documented those parameters in the
7603 docstring. Start callback support.
9173deec
JB
7604 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7605 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7606 on error. Return error code.
e061a11b
TZ
7607 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7608 (emacs_gnutls_read): Likewise.
7609 (Fgnutls_boot): Return handshake error code.
7610 (emacs_gnutls_handle_error): New function.
7611 (wsaerror_to_errno): Likewise.
7612
7613 * w32.h (emacs_gnutls_pull): Add prototype.
7614 (emacs_gnutls_push): Likewise.
7615
7616 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7617 (emacs_gnutls_push): Likewise.
7618
76192011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7620
7621 * process.c (wait_reading_process_output): Check if GnuTLS
7622 buffered some data internally if no FDs are set for TLS
7623 connections.
7624
7625 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7626 (LIBS): Link to USER_LIBS.
7627 ($(BLD)/gnutls.$(0)): New target.
7628
fa6996bc
EZ
76292011-04-24 Eli Zaretskii <eliz@gnu.org>
7630
eb35682e
EZ
7631 * xdisp.c (handle_single_display_spec): Rename the
7632 display_replaced_before_p argument into display_replaced_p, to
7633 make it consistent with the commentary. Fix typos in the
7634 commentary.
7635
e2ad650c
EZ
7636 * textprop.c (syms_of_textprop): Remove dead code.
7637 (copy_text_properties): Delete obsolete commentary about an
7638 interface that was deleted long ago. Fix typos in the description
7639 of arguments.
7640
1b2de274
EZ
7641 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7642 to changes in oldXMenu/XMenu.h from 2011-04-16.
7643 <menu_help_message, prev_menu_help_message>: Constify.
7644 (IT_menu_make_room): menu->help_text is now `const char **';
7645 adjust.
7646
7647 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7648 to changes in oldXMenu/XMenu.h from 2011-04-16.
7649 (struct XMenu): Declare `help_text' `const char **'.
7650
7651 * xfaces.c <Qunspecified>: Make extern again.
7652
7653 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 7654 required by POSIX.
1b2de274 7655
762b15be
EZ
7656 * doc.c (get_doc_string): Improve the format passed to `error'.
7657
7658 * doprnt.c (doprnt): Improve commentary.
7659
7660 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7661
7662 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7663 them with etags.
7664
f1052e5d
EZ
7665 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7666 changes in globals.h immediately force recompilation.
762b15be
EZ
7667 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7668 $(CURDIR)/s/ms-w32.h.
7669 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 7670
fa6996bc
EZ
7671 * character.c (Fchar_direction): Function deleted.
7672 (syms_of_character): Don't defsubr it.
7673 <char-direction-table>: Deleted.
7674
e6c3da20
EZ
76752011-04-23 Eli Zaretskii <eliz@gnu.org>
7676
7677 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7678 * doprnt.c: Include limits.h.
7679 (SIZE_MAX): New macro.
04f2d78b
CB
7680 (doprnt): Return a size_t value. 2nd arg is now size_t.
7681 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
7682 Improve overflow protection. Support `l' modifier for integer
7683 conversions. Support %l conversion. Don't assume an EMACS_INT
7684 argument for integer conversions and for %c.
7685
7686 * lisp.h (doprnt): Restore prototype.
7687
7688 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7689 $(SRC)/character.h.
7690
7691 * Makefile.in (base_obj): Add back doprnt.o.
7692
7693 * deps.mk (doprnt.o): Add back prerequisites.
7694 (callint.o): Depend on character.h.
7695
7696 * eval.c (internal_lisp_condition_case): Include the handler
7697 representation in the error message.
7698 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7699 when breaking from the loop.
7700
7701 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7702
7703 * callint.c (Fcall_interactively): When displaying error message
7704 about invalid control letter, pass the character's codepoint, not
7705 a pointer to its multibyte form. Improve display of the character
7706 in octal and display also its hex code.
7707
7708 * character.c (char_string): Use %x to display the (unsigned)
7709 codepoint of an invalid character, to avoid displaying a bogus
7710 negative value.
7711
7712 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7713 `error', not SYMBOL_NAME itself.
7714
7715 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7716 character arguments to `error'.
7717
7718 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7719 to `error' in error message about FINAL_CHAR argument. Make sure
7720 FINAL_CHAR is a character, and use %c when it is passed as
7721 argument to `error'.
7722
4ffd0d6b 77232011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
7724
7725 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7726
7727 * w32.c: Include <time.h>.
7728 (sys_localtime): New function.
7729
4ffd0d6b 77302011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
7731
7732 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7733
4ffd0d6b 7734 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 7735
4ffd0d6b 77362011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 7737
4ffd0d6b
GM
7738 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7739 zombies (Bug#8467).
aac0c6e3 7740
04c56954
EZ
77412011-04-19 Eli Zaretskii <eliz@gnu.org>
7742
7743 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7744 gl_state.e_property when gl_state.object is Qt.
7745
7746 * insdel.c (make_gap_larger): Remove limitation of buffer size
7747 to <= INT_MAX.
7748
16a43933
CY
77492011-04-18 Chong Yidong <cyd@stupidchicken.com>
7750
7751 * xdisp.c (lookup_glyphless_char_display)
7752 (produce_glyphless_glyph): Handle cons cell entry in
7753 glyphless-char-display.
7754 (Vglyphless_char_display): Document it.
7755
7756 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7757 glyphless-char-display.
7758
4581706e
CY
77592011-04-17 Chong Yidong <cyd@stupidchicken.com>
7760
7761 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7762
7763 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7764
7765 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7766 definition for no-X builds.
7767
4887c6e2 77682011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 7769
fd35b6f9
PE
7770 Static checks with GCC 4.6.0 and non-default toolkits.
7771
5c1ccb01
PE
7772 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7773
006c5daa
PE
7774 * process.c (keyboard_bit_set): Define only if SIGIO.
7775 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7776 (send_process): Repair possible setjmp clobbering.
7777
efc736d3
PE
7778 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7779
4e2fe2e6
PE
7780 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7781
f97334a2
PE
7782 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7783
4e75f29d
PE
7784 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7785 Define only if needed.
7786
90efadd1
PE
7787 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7788 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 7789 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 7790
3c647824
PE
7791 * dispextern.h (struct redisplay_interface): Rename param
7792 to avoid shadowing.
e264f262 7793 * termhooks.h (struct terminal): Likewise.
761383f4 7794 * xterm.c (xembed_send_message): Likewise.
3c647824 7795
b58c5c4a
PE
7796 * insdel.c (make_gap_smaller): Define only if
7797 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7798
cad59032
PE
7799 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7800 it.
7801
c339dc2e
PE
7802 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7803 so that we aren't warned about unused symbols.
7804
91a3e27b
PE
7805 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7806
399c71d3 7807 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 7808
8ffc96f5
PE
7809 * xfns.c (x_real_positions): Mark locals as initialized.
7810
eef9bc79
PE
7811 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7812
098db9dd
PE
7813 * xterm.c: Fix problems found by static analysis with other toolkits.
7814 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
7815 (x_dispatch_event): Declare static if USE_GTK, and
7816 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 7817 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 7818 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
7819 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7820 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 7821
eb18f6cc
PE
7822 * xmenu.c (menu_help_callback): Pointer type fixes.
7823 Use const pointers when pointing at readonly data. Avoid pointer
7824 signedness clashes.
7825 (FALSE): Remove unused macro.
7826 (update_frame_menubar): Remove unused decl.
7827
1fe72bf8
PE
7828 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7829
60d9e1db
PE
7830 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7831 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7832 (single_menu_item): Rename local to avoid shadowing.
7833
39261c26
PE
7834 * keyboard.c (make_lispy_event): Remove unused local var.
7835
018c5e19
PE
7836 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7837 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7838
63d2b86e
PE
7839 * bitmaps: Change bitmaps from unsigned char back to the X11
7840 compatible char. Avoid the old compiler warnings about
7841 out-of-range initializers by using, for example, '\xab' rather
7842 than 0xab.
7843
aefd87e1
PE
7844 * xgselect.c (xgselect_initialize): Check vs interface
7845 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7846
bf501fb9
PE
7847 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7848
e9829fdf
PE
7849 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7850 to read-only memory.
7851
1086c095
PE
7852 * fns.c (vector): Remove; this old hack is no longer needed.
7853
2baccd04 7854 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 7855 Remove unused var.
dde42981 7856 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 7857
72391843 7858 * xrdb.c (x_load_resources): Omit unused local.
3565b346 7859
436c16df 7860 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 7861 (x_window): Rename locals to avoid shadowing.
dc5ddd85 7862 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 7863
92bb796d 7864 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 7865 (x_term_init): Remove local to avoid shadowing.
92bb796d 7866
764430a3 7867 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
7868
7869 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7870 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7871
d1dfb56c
EZ
78722011-04-16 Eli Zaretskii <eliz@gnu.org>
7873
c4354cb4
EZ
7874 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7875
d1dfb56c
EZ
7876 Fix regex.c, syntax.c and friends for buffers > 2GB.
7877 * syntax.h (struct gl_state_s): Declare character position members
7878 EMACS_INT.
7879
7880 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7881
04f2d78b
CB
7882 * textprop.c (verify_interval_modification, interval_of):
7883 Declare arguments EMACS_INT.
d1dfb56c
EZ
7884
7885 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7886 EMACS_INT.
7887
7888 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7889
7890 * indent.c (Fvertical_motion): Local variable it_start is now
7891 EMACS_INT.
7892
7893 * regex.c (re_match, re_match_2, re_match_2_internal)
7894 (bcmp_translate, regcomp, regexec, print_double_string)
7895 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7896 (re_compile_pattern, re_exec): Declare arguments and local
7897 variables `size_t' and `ssize_t' and return values `regoff_t', as
7898 appropriate.
7899 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7900 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7901 <compile_stack_type>: `size' and `avail' are now `size_t'.
7902
7903 * regex.h <regoff_t>: Use ssize_t, not int.
7904 (re_search, re_search_2, re_match, re_match_2): Arguments that
7905 specify buffer/string position and length are now ssize_t and
7906 size_t. Return type is regoff_t.
7907
613052cd
BK
79082011-04-16 Ben Key <bkey76@gmail.com>
7909
7910 * nsfont.m: Fixed bugs in ns_get_family and
7911 ns_descriptor_to_entity that were caused by using free to
7912 deallocate memory blocks that were allocated by xmalloc (via
7913 xstrdup). This caused Emacs to crash when compiled with
7914 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7915 --enable-checking=xmallocoverrun). xfree is now used to
7916 deallocate these memory blocks.
7917
4170f62f 79182011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 7919
71b41406
PE
7920 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7921
9587a89d
PE
7922 emacs_write: Accept and return EMACS_INT for sizes.
7923 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7924 et seq.
7925 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7926 Accept and return EMACS_INT.
7927 (emacs_gnutls_write): Return the number of bytes written on
7928 partial writes.
7929 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
7930 (emacs_read, emacs_write): Remove check for negative size, as the
7931 Emacs source code has been audited now.
9587a89d
PE
7932 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7933 (emacs_read, emacs_write): Use it.
273a5f82
PE
7934 * process.c (send_process): Adjust to the new signatures of
7935 emacs_write and emacs_gnutls_write. Do not attempt to store
7936 a byte offset into an 'int'; it might overflow.
9587a89d 7937 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 7938
3e047f51
PE
7939 * sound.c: Don't assume sizes fit in 'int'.
7940 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 7941 Return EMACS_INT, not int.
3e047f51 7942 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
7943 Accept EMACS_INT, not int.
7944 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
7945 record read return values.
7946
cc39a9db
BK
79472011-04-15 Ben Key <bkey76@gmail.com>
7948
c9d0ec6d
JB
7949 * keyboard.c (Qundefined): Don't declare static since it is used
7950 in nsfns.m.
7951 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7952 static since they are used in nsfont.m.
cc39a9db 7953
6c60eb9f
SM
79542011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7955
7956 * process.c (Qprocessp): Don't declare static.
7957 * lisp.h (Qprocessp): Declare again.
7958
7990b61a
JB
79592011-04-15 Juanma Barranquero <lekktu@gmail.com>
7960
7961 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7962
5d4cb038
PE
79632011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7964
8bd7b830 7965 Improve C-level modularity by making more things 'static'.
cd64ea1d 7966
e3b27b31
PE
7967 Don't publish debugger-only interfaces to other modules.
7968 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7969 (verify_bytepos, count_markers): Move decls to the only modules
7970 that need them.
7971 * region-cache.h (pp_cache): Likewise.
7972 * window.h (check_all_windows): Likewise.
7973 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7974
5d4cb038
PE
7975 * sysdep.c (croak): Now static, if
7976 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7977 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
7978
7979 * alloc.c (refill_memory_reserve): Now static if
7980 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7981 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 7982
e87b6180
PE
7983 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7984 Define only if USE_LUCID.
7985
ac64929e
PE
7986 * xrdb.c (x_customization_string, x_rm_string): Now static.
7987
6f37259d
PE
7988 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7989 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7990
1683e3ab
PE
7991 * xdisp.c (draw_row_with_mouse_face): Now static.
7992 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7993
de9c2632
PE
7994 * window.h (check_all_windows): Mark externally visible.
7995
2b96acb7
PE
7996 * window.c (window_deletion_count): Now static.
7997
7998 * undo.c: Make symbols static if they're not exported.
7999 (last_undo_buffer, last_boundary_position, pending_boundary):
8000 Now static.
8001
50436f33
PE
8002 * textprop.c (interval_insert_behind_hooks): Now static.
8003 (interval_insert_in_front_hooks): Likewise.
8004
64520e5c
PE
8005 * term.c: Make symbols static if they're not exported.
8006 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
8007 (max_frame_lines, tty_set_terminal_modes):
8008 (tty_reset_terminal_modes, tty_turn_off_highlight):
8009 (get_tty_terminal): Now static.
8010 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
8011 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 8012 HAVE_WINDOW_SYSTEM.
64520e5c
PE
8013 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
8014 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
8015
1fa53021
PE
8016 * sysdep.c: Make symbols static if they're not exported.
8017 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
8018 Now static.
8019 (sigprocmask_set, full_mask): Remove; unused.
8020 (wait_debugging): Mark as visible.
8021 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
8022 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
8023
d4b43b22
PE
8024 * syntax.c (syntax_temp): Define only if !__GNUC__.
8025
b7c513d0
PE
8026 * sound.c (current_sound_device, current_sound): Now static.
8027
989b29ad
PE
8028 * search.c (searchbufs, searchbuf_head): Now static.
8029
13a55a78
PE
8030 * scroll.c (scroll_cost): Remove; unused.
8031 * dispextern.h (scroll_cost): Remove decl.
8032
de68a1fc
PE
8033 * region-cache.h (pp_cache): Mark as externally visible.
8034
40ccffa6
PE
8035 * process.c: Make symbols static if they're not exported.
8036 (process_tick, update_tick, create_process, chan_process):
8037 (Vprocess_alist, proc_buffered_char, datagram_access):
8038 (fd_callback_data, send_process_frame, process_sent_to): Now static.
8039 (deactivate_process): Mark defn as static, as well as decl.
8040 * lisp.h (create_process): Remove decl.
8041 * process.h (chan_process, Vprocess_alist): Remove decls.
8042
ad64fc97
PE
8043 * print.c: Make symbols static if they're not exported.
8044 (print_depth, new_backquote_output, being_printed, print_buffer):
8045 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
8046 (print_interval, print_number_index, initial_stderr_stream):
8047 Now static.
8048 * lisp.h (Fprinc): Remove decl.
8049 (debug_output_compilation_hack): Mark as externally visible.
8050
adddb265
PE
8051 * sysdep.c (croak): Move decl from here to syssignal.h.
8052 * syssignal.h (croak): Put it here, so the API can be checked when
8053 'croak' is called from dissociate_if_controlling_tty.
8054
1717ede2
PE
8055 * minibuf.c: Make symbols static if they're not exported.
8056 (minibuf_save_list, choose_minibuf_frame): Now static.
8057 * lisp.h (choose_minibuf_frame): Remove decl.
8058
fa5fb2bc
PE
8059 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
8060
1e3890d1
PE
8061 * lread.c: Make symbols static if they're not exported.
8062 (read_objects, initial_obarray, oblookup_last_bucket_number):
8063 Now static.
8064 (make_symbol): Remove; unused.
8065 * lisp.h (initial_obarray, make_symbol): Remove decls.
8066
8a1414fa
PE
8067 * keyboard.c: Make symbols static if they're not exported.
8068 (single_kboard, recent_keys_index, total_keys, recent_keys):
8069 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
8070 (this_single_command_key_start, echoing, last_auto_save):
8071 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
8072 (command_loop, echo_now, keyboard_init_hook, help_char_p):
8073 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
8074 (Vlispy_mouse_stem, double_click_count):
8075 Now static.
8076 (force_auto_save_soon): Define only if SIGDANGER.
8077 (ignore_mouse_drag_p): Now static if
8078 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
8079 (print_help): Remove; unused.
8080 (stop_character, last_timer_event): Mark as externally visible.
8081 * keyboard.h (ignore_mouse_drag_p): Declare only if
8082 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
8083 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
8084 * lisp.h (echoing): Remove decl.
8085 (force_auto_save_soon): Declare only if SIGDANGER.
8086 * xdisp.c (redisplay_window): Simplify code, to make it more
8087 obvious that ignore_mouse_drag_p is not accessed if !defined
8088 USE_GTK && !defined HAVE_NS.
8089
93ea6e8f
PE
8090 * intervals.c: Make symbols static if they're not exported.
8091 (merge_properties_sticky, merge_interval_right, delete_interval):
8092 Now static.
8093 * intervals.h (merge_interval_right, delete_interval): Remove decls.
8094
77382fcc
PE
8095 * insdel.c: Make symbols static if they're not exported.
8096 However, leave prepare_to_modify_buffer alone. It's never
8097 called from outside this function, but that appears to be a bug.
8098 (combine_after_change_list, combine_after_change_buffer):
4889fc82 8099 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
8100 (adjust_after_replace_noundo): Remove; unused.
8101 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 8102 (signal_before_change): Remove decls.
77382fcc 8103
9306c32e
PE
8104 * indent.c (val_compute_motion, val_vmotion): Now static.
8105
cd44d2eb
PE
8106 * image.c: Make symbols static if they're not exported.
8107 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
8108 if USE_GTK.
8109 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
8110 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
8111
ad9a7a06
PE
8112 * fringe.c (standard_bitmaps): Now static.
8113 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
8114
81626931
PE
8115 * frame.c: Make symbols static if they're not exported.
8116 (x_report_frame_params, make_terminal_frame): Now static.
8117 (get_frame_param): Now static, unless HAVE_NS.
8118 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
8119 (x_get_resource_string): Remove; not used.
8120 * frame.h (make_terminal_frame, x_report_frame_params):
8121 (x_get_resource_string); Remove decls.
8122 (x_fullscreen_adjust): Declare only if WINDOWSNT.
8123 * lisp.h (get_frame_param): Declare only if HAVE_NS.
8124
239f9db9
PE
8125 * font.c, fontset.c: Make symbols static if they're not exported.
8126 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
8127 (FACE_SUITABLE_FOR_CHAR_P): Use it.
8128 * font.c (font_close_object): Now static.
8129 * font.h (font_close_object): Remove.
8130 * fontset.c (FONTSET_OBJLIST): Remove.
8131 (free_realized_fontset) #if-0 the body, which does nothing.
8132 (face_suitable_for_char_p): #if-0, as it's never called.
8133 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
8134 * xfaces.c (face_at_string_position):
8135 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
8136 since 0 is always ASCII.
8137
dfcf3579
PE
8138 * fns.c (weak_hash_tables): Now static.
8139
5045092b
PE
8140 * fileio.c: Make symbols static if they're not exported.
8141 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
8142 (Vwrite_region_annotation_buffers): Now static.
8143
57a96f5c
PE
8144 * eval.c: Make symbols static if they're not exported.
8145 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
8146 * lisp.h (backtrace_list): Remove decl.
8147
35f08c38
PE
8148 * emacs.c: Make symbols static if they're not exported.
8149 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
8150 (fatal_error_code, fatal_error_signal_hook, standard_args):
8151 Now static.
8152 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
8153 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
8154 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
8155 * lisp.h (fatal_error_signal_hook): Remove decl.
8156 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
8157
f44bd759
PE
8158 * editfns.c: Move a (normally-unused) function to its only use.
8159 * editfns.c, lisp.h (get_operating_system_release): Remove.
8160 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
8161 worth the hassle of breaking this out.
8162
b532497d
PE
8163 * xterm.c: Make symbols static if they're not exported.
8164 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
8165 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
8166 (x_destroy_window, x_delete_display):
8167 Now static.
8168 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
8169 (x_mouse_leave): Remove; unused.
8170 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
8171 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
8172 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
8173 Remove decls.
8174 (x_mouse_leave): Declare only if WINDOWSNT.
8175 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
8176 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
8177 USE_X_TOOLKIT.
8178
1675728f
PE
8179 * ftxfont.c: Make symbols static if they're not exported.
8180 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
8181 HAVE_FREETYPE.
8182 * font.h (ftxfont_driver): Likewise.
8183
e4cebfca
PE
8184 * xfns.c: Make symbols static if they're not exported.
8185 (x_last_font_name, x_display_info_for_name):
8186 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
8187 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
8188 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
8189 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
8190 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
8191 (last_show_tip_args): Now static.
8192 (xic_defaut_fontset, xic_create_fontsetname): Define only if
8193 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
8194 (x_screen_planes): Remove; unused.
8195 * dispextern.h (x_screen_planes): Remove decl.
8196
5bf46f05
PE
8197 * dispnew.c: Make symbols static if they're not exported.
8198 * dispextern.h (redraw_garbaged_frames, scrolling):
8199 (increment_row_positions): Remove.
8200 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
8201 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
8202 Now static.
8203 (redraw_garbaged_frames): Remove; unused.
8204
435f4c28
PE
8205 * xfaces.c: Make symbols static if they're not exported.
8206 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
8207 Remove decls.
8208 * xterm.h (defined_color): Remove decls.
8209 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
8210 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
8211 (menu_face_changed_default, defined_color, free_realized_face):
8212 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
8213 (ascii_face_of_lisp_face): Remove; unused.
8214
8524aef3
PE
8215 * xdisp.c: Make symbols static if they're not exported.
8216 * dispextern.h (scratch_glyph_row, window_box_edges):
8217 (glyph_to_pixel_coords, set_cursor_from_row):
8218 (get_next_display_element, set_iterator_to_next):
8219 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
8220 (show_mouse_face): Remove decls
8221 * frame.h (message_buf_print): Likewise.
8222 * lisp.h (pop_message, set_message, check_point_in_composition):
8223 Likewise.
8224 * xterm.h (set_vertical_scroll_bar): Likewise.
8225 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
8226 (message_buf_print, scratch_glyph_row, displayed_buffer):
8227 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
8228 (get_next_display_element, show_mouse_face, window_box_edges):
8229 (frame_to_window_pixel_xy, check_point_in_composition):
8230 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
8231 (glyph_to_pixel_coords): Remove; unused.
8232
16390cd2
PE
8233 * dired.c (file_name_completion): Now static.
8234
8235 * dbusbind.c (xd_in_read_queued_messages): Now static.
8236
a25f4dfa
PE
8237 * lisp.h (circular_list_error, FOREACH): Remove; unused.
8238 * data.c (circular_list_error): Remove.
8239
14a9c8df
PE
8240 * commands.h (last_point_position, last_point_position_buffer):
8241 (last_point_position_window): Remove decls.
8242 * keyboard.c: Make these variables static.
8243
04f2d78b
CB
8244 * coding.h (coding, code_convert_region, encode_coding_gap):
8245 Remove decls.
74ab6df5
PE
8246 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
8247 (iso_code_class, detect_coding, code_convert_region): Now static.
8248 (encode_coding_gap): Remove; unused.
8249
38dfbee1
PE
8250 * chartab.c (chartab_chars, chartab_bits): Now static.
8251
a2cb4e63
PE
8252 * charset.h (charset_iso_8859_1): Remove decl.
8253 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
8254 Now static.
8255
127198fd
PE
8256 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
8257 * ccl.c (Vccl_program_table): Now static.
8258 (check_ccl_update): Remove; unused.
8259
d85b608f
PE
8260 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
8261 * category.h: ... from here.
8262 * category.c (check_category_table, set_category_set): Now static.
8263
31cd66f3
PE
8264 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
8265 * lisp.h: Remove these decls.
8266
c358e587
PE
8267 * buffer.c (buffer_count): Remove unused var.
8268
e78aecca
PE
8269 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
8270 so that it's not optimized away.
8271 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
8272 * dispextern.h (bidi_dump_cached_states): Remove, since it's
8273 exported only to the debugger.
8274
e192d7d3 8275 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 8276 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 8277
92470028
PE
8278 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
8279 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
8280 was inaccessible from Lisp.
8281 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
8282 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
8283
244ed907
PE
8284 alloc.c: Import and export fewer symbols, and remove unused items.
8285 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
8286 is defined.
8287 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
8288 it's not optimized away by whole-program optimization.
8289 (message_enable_multibyte, free_misc): Remove.
8290 (catchlist, handlerlist, mark_backtrace):
8291 Declare only if BYTE_MARK_STACK.
8292 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
8293 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
8294 (message_enable_multibyte): Remove decl.
8295 (free_misc, interval_free_list, float_block, float_block_index):
8296 (n_float_blocks, float_free_list, cons_block, cons_block_index):
8297 (cons_free_list, last_marked_index):
8298 Now static.
8299 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
8300 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
8301 (mark_backtrace): Define only if BYTE_MARK_STACK.
8302 * xdisp.c (message_enable_multibyte): Now static.
8303
61c2b50e 8304 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
8305 This makes it easier for human readers (and static analyzers)
8306 to see whether these variables are used from other modules.
8307 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
8308 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
8309 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
8310 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
8311 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
8312 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
8313 * xmenu.c, xselect.c:
8314 Declare Q* vars static if they are not used in other modules.
8315 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
8316 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
8317 Remove decls of unexported vars.
8318 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
8319
95c82688
PE
8320 * lisp.h (DEFINE_FUNC): Make sname 'static'.
8321
16a97296
PE
8322 Make Emacs functions such as Fatom 'static' by default.
8323 This makes it easier for human readers (and static analyzers)
8324 to see whether these functions can be called from other modules.
8325 DEFUN now defines a static function. To make the function external
8326 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
8327 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
8328 (Finit_image_library):
16a97296
PE
8329 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
8330 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
8331 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
8332 Remove decls, since these functions are now static.
8333 (Funintern, Fget_internal_run_time): New decls, since these functions
8334 were already external.
95c82688 8335
16a97296
PE
8336 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
8337 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
8338 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
8339 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
8340 * keyboard.c, keymap.c, lread.c:
8341 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
8342 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
8343 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
8344 Mark functions with DEFUE instead of DEFUN,
8345 if they are used in other modules.
8346 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
8347 decls for now-static functions.
8348 * buffer.h (Fdelete_overlay): Remove decl.
8349 * callproc.c (Fgetenv_internal): Mark as internal.
8350 * composite.c (Fremove_list_of_text_properties): Remove decl.
8351 (Fcomposition_get_gstring): New forward static decl.
8352 * composite.h (Fcomposite_get_gstring): Remove decl.
8353 * dired.c (Ffile_attributes): New forward static decl.
8354 * doc.c (Fdocumntation_property): New forward static decl.
8355 * eval.c (Ffetch_bytecode): New forward static decl.
8356 (Funintern): Remove extern decl; now in .h file where it belongs.
8357 * fileio.c (Fmake_symbolic_link): New forward static decl.
8358 * image.c (Finit_image_library): New forward static decl.
8359 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
8360 * intervals.h (Fprevious_property_change):
8361 (Fremove_list_of_text_properties): Remove decls.
8362 * keyboard.c (Fthis_command_keys): Remove decl.
8363 (Fcommand_execute): New forward static decl.
8364 * keymap.c (Flookup_key): New forward static decl.
8365 (Fcopy_keymap): Now static.
8366 * keymap.h (Flookup_key): Remove decl.
8367 * process.c (Fget_process): New forward static decl.
8368 (Fprocess_datagram_address): Mark as internal.
8369 * syntax.c (Fsyntax_table_p): New forward static decl.
8370 (skip_chars): Remove duplicate decl.
8371 * textprop.c (Fprevious_property_change): New forward static decl.
8372 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8373 Now internal.
8374 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8375 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8376
785bbd42
PE
8377 * editfns.c (Fformat): Remove unreachable code.
8378
8b913b57
AS
83792011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8380
8381 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8382 change. (Bug#8496)
8383
a6744a35
EZ
83842011-04-13 Eli Zaretskii <eliz@gnu.org>
8385
8386 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8387 when at ZV. (Bug#8487)
8388
e7974947
AS
83892011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8390
baad03f0
AS
8391 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8392 (Bug#8437)
8393 * keyboard.c (parse_tool_bar_item): Likewise.
8394 * sound.c (sound_cleanup, alsa_close): Likewise.
8395 * termcap.c (tgetent): Likewise.
8396 * xfns.c (x_default_font_parameter): Likewise.
8397 * xsettings.c (read_and_apply_settings): Likewise.
8398
e7974947
AS
8399 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8400 (overrun_check_free): Protoize.
8401
28272684
PE
84022011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8403
8404 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8405 since callers should never pass a negative size.
8406 Change the signature to match that of plain 'read' and 'write'; see
8407 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8408 * lisp.h: Update prototypes of emacs_write and emacs_read.
8409
11997c76
EZ
84102011-04-11 Eli Zaretskii <eliz@gnu.org>
8411
8412 * xdisp.c (redisplay_window): Don't try to determine the character
8413 position of the scroll margin if the window start point w->startp
e896f03c 8414 is outside the buffer's accessible region. (Bug#8468)
11997c76 8415
8a2cbd72
EZ
84162011-04-10 Eli Zaretskii <eliz@gnu.org>
8417
8418 Fix write-region and its subroutines for buffers > 2GB.
8419 * fileio.c (a_write, e_write): Modify declaration of arguments and
8420 local variables to support buffers larger than 2GB.
8421 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8422
8423 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8424 argument, local variables, and return value.
8425
8426 * lisp.h: Update prototypes of emacs_write and emacs_read.
8427
8428 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8429
4073e537 84302011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 8431
1ebfdcb6
PE
8432 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8433
b2ded58d
PE
8434 Fix more problems found by GCC 4.6.0's static checks.
8435
7d66342c
PE
8436 * xdisp.c (vmessage): Use a better test for character truncation.
8437
bbf47d44
PE
8438 * charset.c (load_charset_map): <, not <=, for optimization,
8439 and to avoid potential problems with integer overflow.
9248994d 8440 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 8441 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 8442 * editfns.c (Fformat): Likewise.
1e69125e 8443 * syntax.c (skip_chars): Likewise.
3befa583 8444
e3019616
PE
8445 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8446 This also lets GCC 4.6.0 generate slightly better loop code.
8447
becfa255
PE
8448 * callint.c (Fcall_interactively): <, not <=, for optimization.
8449 (Fcall_interactively): Count the number of arguments produced,
8450 not the number of arguments given. This is simpler and lets GCC
8451 4.6.0 generate slightly better code.
8452
dae0cd48
PE
8453 * ftfont.c: Distingish more carefully between FcChar8 and char.
8454 The previous code passed unsigned char * to a functions like
8455 strlen and xstrcasecmp that expect char *, which does not
8456 conform to the C standard.
8457 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8458 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8459 char * when the C standard requires it.
8460
76032d70
PE
8461 * keyboard.c (read_char): Remove unused var.
8462
eb3f1cc8
PE
8463 * eval.c: Port to Windows vsnprintf (Bug#8435).
8464 Include <limits.h>.
8465 (SIZE_MAX): Define if the headers do not.
8466 (verror): Do not give up if vsnprintf returns a negative count.
8467 Instead, grow the buffer. This ports to Windows vsnprintf, which
8468 does not conform to C99. Problem reported by Eli Zaretskii.
8469 Also, simplify the allocation scheme, by avoiding the need for
8470 calling realloc, and removing the ALLOCATED variable.
8471
70476b54
PE
8472 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8473
12020a9e
PE
8474 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8475 But keep the doprint source code for now, as we might revamp it
8476 and use it again (Bug#8435).
ea6c7ae6
PE
8477 * lisp.h (doprnt): Remove.
8478 * Makefile.in (base_obj): Remove doprnt.o.
8479 * deps.mk (doprnt.o): Remove.
8480
5fdb398c
PE
8481 error: Print 32- and 64-bit integers portably (Bug#8435).
8482 Without this change, on typical 64-bit hosts error ("...%d...", N)
8483 was used to print both 32- and 64-bit integers N, which relied on
8484 undefined behavior.
61bdb816 8485 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
8486 * lisp.h (error, verror): Mark as printf-like functions.
8487 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8488 Report overflow in size calculations when allocating printf buffer.
8489 Do not truncate output string at its first null byte.
8490 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8491 Truncate the output at a character boundary, since vsnprintf does not
8492 do that.
8493 * charset.c (check_iso_charset_parameter): Convert internal
8494 character to string before calling 'error', since %c now has the
8495 printf meaning.
8496 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8497 overflow when computing char to be passed to 'error'. Do not
8498 pass Lisp_Object to 'error'; pass the integer instead.
8499 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8500 formatted with plain %d.
8501
b189fa66
PE
8502 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8503
bff87ef0
PE
8504 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8505
7e2cac20
PE
8506 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8507
ce4d90b5
PE
8508 * xterm.c (x_catch_errors): Remove duplicate declaration.
8509
266c9547
PE
8510 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8511
79c49ad2
PE
8512 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8513
368f4090
JM
85142011-04-10 Jim Meyering <meyering@redhat.com>
8515
8516 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8517 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8518 return ssize_t not "int", and use size_t as the buffer length.
8519 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8520 * gnutls.h: Update declarations.
8521 * process.c (read_process_output): Use ssize_t, to match.
8522 (send_process): Likewise.
8523
a32d4040
CY
85242011-04-09 Chong Yidong <cyd@stupidchicken.com>
8525
8526 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8527
8546720e 85282011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 8529
04f2d78b
CB
8530 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8531 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 8532
8546720e
GM
8533 * xterm.c (handle_one_xevent):
8534 * xmenu.c (create_and_show_popup_menu):
8535 * xselect.c (x_decline_selection_request)
8536 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 8537
0a2f5c1a 85382011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
8539
8540 Fix some uses of `int' instead of EMACS_INT.
8541 * search.c (string_match_1, fast_string_match)
8542 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8543 (scan_buffer, find_next_newline_no_quit)
8544 (find_before_next_newline, search_command, Freplace_match)
8545 (Fmatch_data): Make some `int' variables be EMACS_INT.
8546
8547 * xdisp.c (display_count_lines): 3rd argument and return value now
8548 EMACS_INT. All callers changed.
8549 (pint2hrstr): Last argument is now EMACS_INT.
8550
8551 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8552 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8553 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8554 (decode_coding_utf_16, decode_coding_emacs_mule)
8555 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8556 (decode_coding_ccl, decode_coding_charset)
8557 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8558 (decode_coding_iso_2022, decode_coding_emacs_mule)
8559 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8560 <char_offset, last_offset>: Declare EMACS_INT.
8561 (encode_coding_utf_8, encode_coding_utf_16)
8562 (encode_coding_emacs_mule, encode_invocation_designation)
8563 (encode_designation_at_bol, encode_coding_iso_2022)
8564 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8565 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8566 Declare EMACS_INT.
8567 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8568 (encode_invocation_designation): Last argument P_NCHARS is now
8569 EMACS_INT.
8570 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8571 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8572
8573 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8574 All users changed.
8575
8576 * ccl.c (Fccl_execute_on_string): Declare some variables
8577 EMACS_INT.
8578
8546720e 85792011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
8580
8581 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8582
4e19a977
CS
85832011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8584
8585 * process.c (Fformat_network_address): Doc fix.
8586
87302331
R
85872011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8588
ee7683eb 8589 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 8590
cbb59342
CY
85912011-04-08 Chong Yidong <cyd@stupidchicken.com>
8592
8593 * keyboard.c (read_char): Call Lisp function help-form-show,
8594 instead of using internal_with_output_to_temp_buffer.
8595 (Qhelp_form_show): New var.
e0d38eeb 8596 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
8597
8598 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8599
8600 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8601
e67a13ab
CY
86022011-04-06 Chong Yidong <cyd@stupidchicken.com>
8603
04f2d78b
CB
8604 * process.c (Flist_processes): Remove to Lisp.
8605 (list_processes_1): Delete.
e67a13ab 8606
973f782d
EZ
86072011-04-06 Eli Zaretskii <eliz@gnu.org>
8608
7c106b1e
EZ
8609 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8610
973f782d
EZ
8611 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8612
41cf7d1a 86132011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 8614
ca23cc88
PE
8615 Fix more problems found by GCC 4.6.0's static checks.
8616
f390e2d5
PE
8617 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8618
42eea0d0
PE
8619 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8620
b69769da 8621 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 8622
f9541e84
PE
8623 * xdisp.c (vmessage): Mark as a printf-like function.
8624
13841b55
PE
8625 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8626
c136c10f
PE
8627 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8628
5e2d4a30
PE
8629 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8630 printf-like functions.
8631 (tiff_load): Add casts to remove these marks before passing them
8632 to system-supplied API.
8633
583f48b9
PE
8634 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8635
b25d760e
PE
8636 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8637 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
8638 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8639 directly, rather than having caller test rule sign. This avoids
8640 some unnecessary tests.
8641 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8642 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8643 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 8644
bc7b6697 8645 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 8646 (xfont_open): Avoid unnecessary tests.
bc7b6697 8647
27ccc379
PE
8648 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8649
dcd5c89a
PE
8650 * composite.h, composite.c (composition_gstring_put_cache):
8651 Use EMACS_INT, not int, for length.
8652
b13a45c6
PE
8653 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8654 breaking out part of COMPOSITION_DECODE_RULE.
8655 (COMPOSITION_DECODE_RULE): Use it.
8656 * composite.c (get_composition_id): Remove unused local vars,
8657 by using the new macro.
8658
1e792e4d
PE
8659 * textprop.c (set_text_properties_1): Change while to do-while,
8660 since the condition is always true at first.
8661
dc6c6455 8662 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
8663 (interval_deletion_adjustment): Return unsigned value.
8664 All uses changed.
dc6c6455 8665
aba7731a
PE
8666 * process.c (list_processes_1, create_pty, read_process_output):
8667 (exec_sentinel): Remove vars that were set but not used.
afd4052b 8668 (create_pty): Remove unnecessary "volatile"s.
bc57d757 8669 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 8670 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 8671 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 8672
fdfc4bf3
PE
8673 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8674
fca8fe46 8675 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 8676 (update_syntax_table): Use unsigned instead of int.
fca8fe46 8677
06a0259a 8678 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 8679 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 8680 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 8681
e7b9e80f
PE
8682 * print.c (print_error_message): Avoid int overflow.
8683
56201685
PE
8684 * font.c (font_list_entities): Redo for clarity,
8685 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8686
78834453 8687 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 8688 (font_score): Avoid potential overflow in diff calculation.
78834453 8689
0bc0b309 8690 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 8691 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 8692
e610eaca
PE
8693 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8694
b895abce
PE
8695 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8696 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8697 can always succeed if overflow has undefined behavior.
8698
1f1d9321 8699 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 8700 (wordify): Omit three unnecessary tests.
1f1d9321 8701
c59478bc
PE
8702 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8703 All callers changed. This avoids the need for an unused var.
8704
79b73827
PE
8705 * casefiddle.c (casify_region): Remove var that is set but not used.
8706
a4db5dfe
PE
8707 * dired.c (file_name_completion): Remove var that is set but not used.
8708
43aae36e
PE
8709 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8710
2a47c44d 8711 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 8712 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 8713
a37c69bf
PE
8714 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8715 Check for integer overflow on size calculations.
8716
328ab8e7
PE
8717 * buffer.c (Fprevious_overlay_change): Remove var that is set
8718 but not used.
8719
e5a2a5cb
PE
8720 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8721 Remove vars that are set but not used.
8d84a6eb 8722 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 8723 (timer_check_2): Mark vars as initialized.
e5a2a5cb 8724
a60e5f68
PE
8725 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8726
f661cb61 8727 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 8728 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 8729
f0397f5a
PE
8730 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8731 that are set but not used.
8732
8664db06 8733 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 8734 if XCreateBitmapFromData fails (Bug#8410).
8664db06 8735
6abdaa4a
PE
8736 * xselect.c (x_get_local_selection, x_handle_property_notify):
8737 Remove vars that are set but not used.
8738
0ce7538d 8739 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 8740 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 8741
9ae848fc
PE
8742 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8743 Remove var that is set but not used.
0b918413
PE
8744 (scroll_bar_windows_size): Now size_t, not int.
8745 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8746 Check for overflow.
9ae848fc 8747
a5a62657
PE
8748 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8749 (map_tty_color) [!defined MSDOS]: Likewise.
8750
5c5cdd39
PE
8751 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8752
66ebf983
PE
8753 * coding.c: Remove vars that are set but not used.
8754 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8755 All callers changed.
8756 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8757 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8758 (decode_coding_charset): Remove vars that are set but not used.
8759
1be4d761
PE
8760 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8761 that is set but not used.
8762
47553fa8
PE
8763 * print.c (print_object): Remove var that is set but not used.
8764
1f7196bf 8765 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
8766 The gnulib version avoids calling malloc in the usual case,
8767 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8768 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8769 * filelock.c (current_lock_owner): Likewise.
8770 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8771 * sysdep.c: Include allocator.h, careadlinkat.h.
8772 (emacs_no_realloc_allocator): New static constant.
8773 (emacs_readlink): New function.
fdb61804
PE
8774 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8775 ../lib/careadlinkat.h.
d1fdcab7 8776
f84c17c7
SM
87772011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8778
8779 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8780 first non-nil return value).
8781
ef3862ad
JD
87822011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8783
8784 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8785 if not defined (Bug#8403).
8786
376a7006
JB
87872011-04-02 Juanma Barranquero <lekktu@gmail.com>
8788
8789 * xdisp.c (display_count_lines): Remove parameter `start',
8790 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8791 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8792 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8793 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8794 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8795 and thereabouts. All callers changed.
8796 (get_per_char_metric): Remove parameter `f', unused since
8797 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8798
6ca3801d
JM
87992011-04-02 Jim Meyering <meyering@redhat.com>
8800
8801 do not dereference NULL upon failed strdup
8802 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8803 (ns_get_family): Likewise.
8804
d8e2b5ba
JB
88052011-04-02 Juanma Barranquero <lekktu@gmail.com>
8806
8807 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8808
8c74fcbd
JD
88092011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8810
8811 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8812 later (Bug#8403).
8813
7200d79c
SM
88142011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8815
03408648 8816 Add lexical binding.
7200d79c 8817
03408648
SM
8818 * window.c (Ftemp_output_buffer_show): New fun.
8819 (Fsave_window_excursion):
8820 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8821
8822 * lread.c (lisp_file_lexically_bound_p): New function.
8823 (Fload): Bind Qlexical_binding.
8824 (readevalloop): Remove `evalfun' arg.
8825 Bind Qinternal_interpreter_environment.
8826 (Feval_buffer): Bind Qlexical_binding.
8827 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8828 Mark as dynamic.
8829 (syms_of_lread): Declare `lexical-binding'.
8830
8831 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8832
8833 * keyboard.c (eval_dyn): New fun.
8834 (menu_item_eval_property): Use it.
ca105506
SM
8835
8836 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 8837
03408648
SM
8838 * fns.c (concat, mapcar1): Accept byte-code-functions.
8839
8840 * eval.c (Fsetq): Handle lexical vars.
8841 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8842 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8843 (FletX, Flet): Obey lexical binding.
8844 (Fcommandp): Handle closures.
8845 (Feval): New `lexical' arg.
8846 (eval_sub): New function extracted from Feval. Use it almost
8847 everywhere where Feval was used. Look up vars in lexical env.
8848 Handle closures.
8849 (Ffunctionp): Move from subr.el.
8850 (Ffuncall): Handle closures.
8851 (apply_lambda): Remove `eval_flags'.
8852 (funcall_lambda): Handle closures and new byte-code-functions.
8853 (Fspecial_variable_p): New function.
8854 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8855 but without exporting it to Lisp.
23aba0ea 8856
23aba0ea 8857 * doc.c (Fdocumentation, store_function_docstring):
03408648 8858 * data.c (Finteractive_form): Handle closures.
23aba0ea 8859
03408648
SM
8860 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8861 interactive spec.
ba83908c 8862
04f2d78b
CB
8863 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8864 New byte-codes.
03408648
SM
8865 (exec_byte_code): New function extracted from Fbyte_code to handle new
8866 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 8867
03408648 8868 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 8869
03408648 8870 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 8871
e2abce01
JB
88722011-03-31 Juanma Barranquero <lekktu@gmail.com>
8873
8874 * xdisp.c (redisplay_internal): Fix prototype.
8875
63696a73 88762011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 8877
63696a73 8878 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
8879 (try_scrolling): Use it when setting scroll_limit.
8880 Limit scrolling to 100 screen lines.
63696a73
EZ
8881 (redisplay_window): Even when falling back on "recentering",
8882 position point in the window according to scroll-conservatively,
8883 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8884
8885 (try_scrolling): When point is above the window, allow searching
8886 as far as scroll_max, or one screenful, to compute vertical
8887 distance from PT to the scroll margin position. This prevents
8888 try_scrolling from unnecessarily failing when
8889 scroll-conservatively is set to a value slightly larger than the
8890 window height. Clean up the case of PT below the margin at bottom
8891 of window: scroll_max can no longer be INT_MAX. When aggressive
8892 scrolling is in use, don't let point enter the opposite scroll
8893 margin as result of the scroll.
8894 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
8895 threshold of 100 lines for never-recentering scrolling.
8896
e4cc2dfc
JB
88972011-03-31 Juanma Barranquero <lekktu@gmail.com>
8898
8899 * dispextern.h (move_it_by_lines):
8900 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8901 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8902 (message_log_check_duplicate): Remove parameters `prev_bol' and
8903 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8904 (redisplay_internal): Remove parameter `preserve_echo_area',
8905 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8906
8907 * indent.c (Fvertical_motion):
8908 * window.c (window_scroll_pixel_based, Frecenter):
8909 Don't pass `need_y_p' to `move_it_by_lines'.
8910
1c470562
SM
89112011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8912
44f230aa
SM
8913 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8914 steal a few bits to be more compact.
8915 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8916 Remove unneeded casts.
8917
1c470562
SM
8918 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8919
888adce9
ZK
89202011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8921
8922 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8923 binding" message (bug#7967).
8924
f838ed7b
PE
89252011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8926
77861b95
PE
8927 Fix more problems found by GCC 4.6.0's static checks.
8928
de6dbc14
PE
8929 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8930 Remove unused local var.
8931
f838ed7b
PE
8932 * editfns.c (Fmessage_box): Remove unused local var.
8933
792c7b2b
PE
8934 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8935 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8936 Omit unused local vars.
c499e557 8937 * window.c (shrink_windows): Omit unused local var.
b01a1c29 8938 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
8939 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8940 Omit unused local var.
8941
ba0165e1
PE
8942 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8943 Don't assume string length fits in int.
32ad8845 8944 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 8945 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 8946
3c59b4c9
PE
8947 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8948 instead of alloca (Bug#8344).
8949
a3eed478 8950 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 8951 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 8952
eb4d412d
PE
8953 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8954
1658b401
PE
8955 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8956 concerns.
8957
8958 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8959
8960 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 8961
9a2c6e05
PE
8962 * keyboard.c (syms_of_keyboard): Use the same style as later
8963 in this function when indexing through an array. This also
8964 works around GCC bug 48267.
8965
03d0a109
PE
8966 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8967
44f730c8
PE
8968 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8969
fe75f926
PE
8970 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8971 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8972
ffa8c828
PE
8973 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8974 This avoids undefined behavior on integer overflow, and is a bit
8975 more convenient anyway since it is compared to a size_t variable.
8976
c5101a77
PE
8977 Variadic C functions now count arguments with size_t, not int.
8978 This avoids an unnecessary limitation on 64-bit machines, which
8979 caused (substring ...) to crash on large vectors (Bug#8344).
8980 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8981 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 8982 All variadic functions and their callers changed accordingly.
c5101a77
PE
8983 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8984 * data.c (arith_driver, float_arith_driver): Likewise.
8985 * editfns.c (general_insert_function): Likewise.
8986 * eval.c (struct backtrace.nargs, interactive_p)
8987 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8988 (funcall_lambda, mark_backtrace): Likewise.
8989 * fns.c (concat): Likewise.
8990 * frame.c (x_set_frame_parameters): Likewise.
8991 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8992 0 if not found, not -1. All callers changed.
8993
dd3f25f7
PE
8994 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8995 (stack_copy_size): Now size_t, not int.
8996 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8997
461c2ab9
JB
89982011-03-28 Juanma Barranquero <lekktu@gmail.com>
8999
9000 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
9001 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
9002 All callers changed.
9003
9004 * lisp.h (multibyte_char_to_unibyte):
9005 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
9006 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
9007 * character.h (CHAR_TO_BYTE8):
9008 * cmds.c (internal_self_insert):
9009 * editfns.c (general_insert_function):
9010 * keymap.c (push_key_description):
9011 * search.c (Freplace_match):
9012 * xdisp.c (message_dolog, set_message_1): All callers changed.
9013
f6d62986
SM
90142011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
9015
9016 * keyboard.c (safe_run_hook_funcall): New function.
9017 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
9018 don't set the hook to nil, but remove the offending function instead.
9019 (Qcommand_hook_internal): Remove, unused.
9020 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
9021 Vcommand_hook_internal.
9022
9023 * eval.c (enum run_hooks_condition): Remove.
9024 (funcall_nil, funcall_not): New functions.
9025 (run_hook_with_args): Call each function through a `funcall' argument.
9026 Remove `cond' argument, now redundant.
9027 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
9028 (Frun_hook_with_args_until_failure): Adjust accordingly.
9029 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
9030
1db5b1ad
JB
90312011-03-28 Juanma Barranquero <lekktu@gmail.com>
9032
9033 * dispextern.h (string_buffer_position): Remove declaration.
9034
9035 * print.c (strout): Remove parameter `multibyte', unused since
9036 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
9037
9038 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
9039 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
9040 All callers changed.
9041
9042 * w32.c (_wsa_errlist): Use braces for struct initializers.
9043
9044 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
9045 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
9046 All callers changed.
9047 (string_buffer_position): Likewise. Also, make static (it's never
9048 used outside xdisp.c).
9049 (cursor_row_p): Remove parameter `w', unused since
9050 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
9051 (decode_mode_spec): Remove parameter `precision', introduced during
9052 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
9053 All callers changed.
9054
5ffb62aa
JD
90552011-03-27 Jan Djärv <jan.h.d@swipnet.se>
9056
9057 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
9058
461c2ab9 90592011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
9060
9061 * nsterm.m (ns_menu_bar_is_hidden): New variable.
9062 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
9063 (ns_update_auto_hide_menu_bar): New functions.
9064 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
9065 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
9066 ns_constrain_all_frames.
9067 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
9068 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
9069
5c380ffb
JD
90702011-03-27 Jan Djärv <jan.h.d@swipnet.se>
9071
9072 * nsmenu.m (runDialogAt): Remove argument to timer_check.
9073
9af30bdf
GM
90742011-03-27 Glenn Morris <rgm@gnu.org>
9075
9076 * syssignal.h: Replace RETSIGTYPE with void.
9077 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
9078 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
9079 Replace SIGTYPE with void everywhere.
9080 * s/usg5-4-common.h (SIGTYPE): Remove definition.
9081 * s/template.h (SIGTYPE): Remove commented out definition.
9082
e2abce01
JB
90832011-03-26 Eli Zaretskii <eliz@gnu.org>
9084
9085 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
9086 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
9087
f868cd8a
JB
90882011-03-26 Juanma Barranquero <lekktu@gmail.com>
9089
59eb0929
JB
9090 * w32.c (read_unc_volume): Use parameter `henum', instead of
9091 global variable `wget_enum_handle'.
9092
9093 * keymap.c (describe_vector): Remove parameters `indices' and
9094 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
9095 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
9096
f868cd8a
JB
9097 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
9098
9099 * keyboard.c (timer_check): Remove parameter `do_it_now',
9100 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
9101 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
9102 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
9103
9104 * keyboard.c (read_char):
9105 * w32menu.c (w32_menu_display_help):
9106 * xmenu.c (show_help_event, menu_help_callback):
9107 Adjust calls to `show_help_echo'.
9108
9109 * gtkutil.c (xg_maybe_add_timer):
9110 * keyboard.c (readable_events):
9111 * process.c (wait_reading_process_output):
9112 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
9113
9114 * insdel.c (adjust_markers_gap_motion):
9115 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
9116 (gap_left, gap_right): Don't call it.
9117
2ecf6fdb
CY
91182011-03-25 Chong Yidong <cyd@stupidchicken.com>
9119
9120 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
9121 incurred during fontification.
9122
6b1f9ba4
JB
91232011-03-25 Juanma Barranquero <lekktu@gmail.com>
9124
9125 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
9126 (DEFVAR_PER_BUFFER): Don't pass it.
9127
9128 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
9129 (scrolling_window): Don't pass it.
9130
0f4a96b5
JB
91312011-03-25 Juanma Barranquero <lekktu@gmail.com>
9132
9133 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
9134
9135 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
9136 and `suffix'.
9137 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
9138 of variables specific to SELinux and computation of `encoded_absname'.
9139
9140 * image.c (XPutPixel): Remove unused variable `height'.
9141
9142 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
9143
9144 * unexw32.c (get_section_info): Remove unused variable `section'.
9145
9146 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
9147 (system_process_attributes): Remove unused variable `sess'.
9148 (sys_read): Remove unused variable `err'.
9149
9150 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
9151 (w32_wnd_proc): Remove unused variable `isdead'.
9152 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
9153 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
9154 (x_create_tip_frame): Remove unused variable `tem'.
9155
9156 * w32inevt.c (w32_console_read_socket):
9157 Remove unused variable `no_events'.
9158
9159 * w32term.c (x_draw_composite_glyph_string_foreground):
9160 Remove unused variable `width'.
9161
1149507c
JB
91622011-03-24 Juanma Barranquero <lekktu@gmail.com>
9163
9164 * w32term.c (x_set_glyph_string_clipping):
9165 Don't pass uninitialized region to CombineRgn.
9166
9c88f339
JB
91672011-03-23 Juanma Barranquero <lekktu@gmail.com>
9168
9169 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
9170 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
9171 (Fx_close_connection): Remove unused variable `i'.
9172
9173 * w32font.c (w32font_draw): Return number of glyphs.
9174 (w32font_open_internal): Remove unused variable `i'.
9175 (w32font_driver): Add missing initializer.
9176
9177 * w32menu.c (utf8to16): Remove unused variable `utf16'.
9178 (fill_in_menu): Remove unused variable `items_added'.
9179
9180 * w32term.c (last_mouse_press_frame): Remove static global variable.
9181 (w32_clip_to_row): Remove unused variable `f'.
9182 (x_delete_terminal): Remove unused variable `i'.
9183
9184 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
9185 (NOTHING): Remove unused static global variable.
9186 (uniscribe_check_otf): Remove unused variable `table'.
9187 (uniscribe_font_driver): Add missing initializers.
9188
dee091a3
JD
91892011-03-23 Julien Danjou <julien@danjou.info>
9190
9191 * term.c (Fsuspend_tty, Fresume_tty):
9192 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
9193 * window.c (temp_output_buffer_show):
9194 * insdel.c (signal_before_change):
9195 * frame.c (Fhandle_switch_frame):
9196 * fileio.c (Fdo_auto_save):
9197 * emacs.c (Fkill_emacs):
9198 * editfns.c (save_excursion_restore):
9199 * cmds.c (internal_self_insert):
9200 * callint.c (Fcall_interactively):
9201 * buffer.c (Fkill_all_local_variables):
9202 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
9203 Use Frun_hooks.
0f4a96b5 9204 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 9205 unconditionally since it does the check itself.
dee091a3 9206
2c520ab5 92072011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 9208
c9c49752
PE
9209 Fix more problems found by GCC 4.5.2's static checks.
9210
8abc3f12
PE
9211 * coding.c (encode_coding_raw_text): Avoid unnecessary test
9212 the first time through the loop, since we know p0 < p1 then.
9213 This also avoids a gcc -Wstrict-overflow warning.
9214
a2d26660
PE
9215 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
9216 leading to a memory leak, possible in functions like
9217 load_charset_map_from_file that can allocate an unbounded number
b12ef411 9218 of objects (Bug#8318).
a2d26660 9219
916c72e9
PE
9220 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
9221 that could (at least in theory) be that large.
9222
19ab8a18
PE
9223 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
9224 This is less likely to overflow, and avoids undefined behavior if
9225 overflow does occur. All callers changed. Use strtoul to scan
9226 for the unsigned long integer.
b7cbbd6f
PE
9227 (pint2hrstr): Simplify and tune code slightly.
9228 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 9229
f0641eff
PE
9230 * scroll.c (do_scrolling): Work around GCC bug 48228.
9231 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
9232
7f650bb9
PE
9233 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
9234 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
9235 (validate_x_resource_name): Simplify count usage.
9236 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 9237
37dd57d1
PE
9238 * fileio.c (Fcopy_file): Report error if fchown or fchmod
9239 fail (Bug#8306).
81e56e61 9240
699979fc 9241 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 9242
401bf9b4
PE
9243 * process.c (Fmake_network_process): Use socklen_t, not int,
9244 where POSIX says socklen_t is required in portable programs.
9245 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 9246 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
9247 (Fmake_network_process, server_accept_connection):
9248 (wait_reading_process_output, read_process_output):
9249 Likewise.
9250
b93aacde
PE
9251 * process.c: Rename or move locals to avoid shadowing.
9252 (list_processes_1, Fmake_network_process):
9253 (read_process_output_error_handler, exec_sentinel_error_handler):
9254 Rename or move locals.
4dc343ee 9255 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 9256 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 9257 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 9258 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 9259 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 9260
af8a867c 9261 Make tparam.h and terminfo.c consistent.
44f230aa
SM
9262 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
9263 Include tparam.h instead, since it declares them.
af8a867c
PE
9264 * cm.h (PC): Remove extern decl; tparam.h now does this.
9265 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
9266 * terminfo.c: Include tparam.h, to check interfaces.
9267 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
9268 (tparam): Adjust signature to match interface in tparam.h;
9269 this removes some undefined behavior. Check that outstring and len
9270 are zero, which they always are with Emacs.
9271 * tparam.h (PC, BC, UP): New extern decls.
9272
0248044d 9273 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 9274 (xftfont_open): Rename locals to avoid shadowing.
0248044d 9275
8ff096c1 9276 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
9277 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
9278 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 9279 (ftfont_list): Remove unused local.
49eaafba
PE
9280 (get_adstyle_property, ftfont_pattern_entity):
9281 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
9282 Rename locals to avoid shadowing.
8ff096c1 9283
e2be39f6
PE
9284 * xfont.c (xfont_list_family): Mark var as initialized.
9285
c9735e30
PE
9286 * xml.c (make_dom): Now static.
9287
8f5201ae
PE
9288 * composite.c (composition_compute_stop_pos): Rename local to
9289 avoid shadowing.
b246f932
PE
9290 (composition_reseat_it): Remove unused locals.
9291 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 9292 (composition_update_it): Mark var as initialized.
11b61122
PE
9293 (find_automatic_composition): Mark vars as initialized,
9294 with a FIXME (Bug#8290).
8f5201ae 9295
760fbc2c
PE
9296 character.h: Rename locals to avoid shadowing.
9297 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
9298 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
9299 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
9300 (BUF_DEC_POS): Be more systematic about renaming local temporaries
9301 to avoid shadowing.
9302
ff08eb85
PE
9303 * textprop.c (property_change_between_p): Remove; unused.
9304
fc7bf025
PE
9305 * intervals.c (interval_start_pos): Now static.
9306
235d7abc
PE
9307 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
9308
44f230aa
SM
9309 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
9310 Rename locals to avoid shadowing.
3e7d6594 9311
50060332
PE
9312 * sound.c (wav_play, au_play, Fplay_sound_internal):
9313 Fix pointer signedness.
d01f234b 9314 (alsa_choose_format): Remove unused local var.
c83b8872
PE
9315 (wav_play): Initialize a variable to 0, to prevent undefined
9316 behavior (Bug#8278).
50060332 9317
c4fc4e30
PE
9318 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
9319
918436ed
PE
9320 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
9321
c939f91b
PE
9322 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
9323 clobbering (Bug#8298).
b9c7f648
PE
9324 * sysdep.c (sys_subshell): Likewise.
9325 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 9326
6bd8c144
PE
9327 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
9328 This should get cleaned up, so that child_setup has the
9329 same signature on all platforms.
9330
7710357c 9331 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 9332 (relocate_fd): Rename locals to avoid shadowing.
7710357c 9333
c59da222
CY
93342011-03-22 Chong Yidong <cyd@stupidchicken.com>
9335
9336 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
9337 not to be necessary, and produces flickering.
9338
66b87493
GM
93392011-03-20 Glenn Morris <rgm@gnu.org>
9340
9341 * config.in: Remove file.
9342
45b6f6d5
JB
93432011-03-20 Juanma Barranquero <lekktu@gmail.com>
9344
9345 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
9346 are now in src/globals.h.
9347 (syms_of_minibuf): Remove spurious & from previous change.
9348
cd394be1 93492011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
9350
9351 * minibuf.c (completing-read-function): New variable.
9352 (completing-read-default): Rename from completing-read.
9353 (completing-read): Call completing-read-function.
9354
b14e3e21
CY
93552011-03-19 Juanma Barranquero <lekktu@gmail.com>
9356
9357 * xfaces.c (Fx_load_color_file):
9358 Read color file from absolute filename (bug#8250).
9359
f2b726e6
JB
93602011-03-19 Juanma Barranquero <lekktu@gmail.com>
9361
9362 * makefile.w32-in: Update dependencies.
9363
09f6ff02
EZ
93642011-03-17 Eli Zaretskii <eliz@gnu.org>
9365
9366 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
9367
29a6015a
PE
93682011-03-17 Paul Eggert <eggert@cs.ucla.edu>
9369
a3a6c54e
PE
9370 Fix more problems found by GCC 4.5.2's static checks.
9371
b766f867
PE
9372 * process.c (make_serial_process_unwind, send_process_trap):
9373 (sigchld_handler): Now static.
9374
be02381c
PE
9375 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9376 That way, the code declares only the vars that it needs.
9377 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9378 * s/cygwin.h (PTY_ITERATION): Likewise.
9379 * s/darwin.h (PTY_ITERATION): Likewise.
9380 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9381
57048744
PE
9382 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9383 * process.c (allocate_pty): Don't declare stb unless it's needed.
9384
7914961c 9385 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
9386 (CONSTANTLIM): Remove; unused.
9387 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9388 Define only if needed.
7914961c 9389
b3967b18
PE
9390 * unexelf.c (unexec): Name an expression,
9391 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
9392 Use a different way to cause a compilation error if anyone uses
9393 n rather than nn, a way that does not involve shadowing.
73366a00 9394 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 9395
29a6015a
PE
9396 * deps.mk (unexalpha.o): Remove; unused.
9397
43cfc33e 9398 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 9399 * unexec.h: New file.
ce701a33
PE
9400 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9401 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9402 Depend on unexec.h.
9403 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9404 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9405 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 9406 Change as necessary to match prototype in unexec.h.
ce701a33 9407
01f44d5a
PE
9408 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9409 shadowing.
4f63c6bb 9410 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 9411
a6670b0b
PE
9412 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9413 Rename locals to avoid shadowing.
9414
cef2010d 9415 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 9416 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 9417
d4d7173a
PE
9418 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9419
f08b802a
PE
9420 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9421 warning when compiling print.c.
9422
3ddb0639
PE
9423 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9424 instead of using an uninitialized var.
5ad03b97 9425 (font_sort_entities): Mark var as initialized.
3ddb0639 9426
170a2692
PE
9427 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9428
e663c700
PE
9429 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9430 pointers to constants.
89bc529a 9431 (font_parse_fcname): Remove unused vars.
7b81e2d0 9432 (font_delete_unmatched): Now static.
ea838e10 9433 (font_get_spec): Remove; unused.
13a547c6
PE
9434 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9435 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9436 Rename or move locals to avoid shadowing.
e663c700 9437
2a80c887 9438 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 9439 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 9440
1384fa33 9441 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 9442 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 9443
8b2c52e9
PE
9444 * alloc.c (mark_backtrace): Move decl from here ...
9445 * lisp.h: ... to here, so that it can be checked.
9446
475545b5 9447 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 9448 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
9449 (lisp_indirect_variable): Name an expression,
9450 to avoid gcc -Wbad-function-cast warning.
1faed8ae 9451 (Fdefvar): Rename locals to avoid shadowing.
475545b5 9452
b1349114 9453 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 9454 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 9455 Use const pointer when appropriate.
b1349114 9456
a2928364
PE
9457 * lisp.h (get_system_name, get_operating_system_release):
9458 Move decls here, to check interfaces.
9459 * process.c (get_operating_system_release): Move decl to lisp.h.
9460 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
9461 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9462 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9463 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
9464 (Fformat_time_string, Fencode_time, Finsert_char):
9465 (Ftranslate_region_internal, Fformat):
9466 Rename or remove local vars to avoid shadowing.
9710023e 9467 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 9468
a415e694
PE
9469 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9470 avoid shadowing.
9471
8ef4622d
PE
9472 * lisp.h (eassert): Check that the argument compiles, even if
9473 ENABLE_CHECKING is not defined.
9474
946f9a5b
PE
9475 * data.c (Findirect_variable): Name an expression, to avoid
9476 gcc -Wbad-function-cast warning.
112396d6 9477 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 9478 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
9479 (Fmake_variable_buffer_local, Fmake_local_variable):
9480 Mark variables as initialized.
52746918 9481 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 9482
e5aab7e7 9483 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
9484 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9485 Rename locals to avoid shadowing.
dff45157
PE
9486 (mark_stack): Move local variables into the #ifdef region where
9487 they're used.
7bc26fdb
PE
9488 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9489 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9490 needed otherwise.
9491 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9492 (GC_STRING_CHARS): Remove; not used.
d40d4be1 9493 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 9494
e5aab7e7
PE
9495 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9496 avoids undefined behavior in theory.
9497
4da60324
PE
9498 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9499
88043301
PE
9500 Use functions, not macros, for up- and down-casing (Bug#8254).
9501 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9502 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9503 to use the following functions instead of these macros.
9504 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9505 EMACS_INT, since callers assume the returned value fits in int.
9506 (upcase1): Likewise, for UPCASE_TABLE.
9507 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 9508 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 9509 the race-condition problem in the old DOWNCASE.
88043301 9510
19ed5445
PE
9511 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9512 Rename locals to avoid shadowing.
9513 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
9514 (regex_compile, re_search_2, re_match_2_internal):
9515 Remove unused local vars.
952db0d7
PE
9516 (FREE_VAR): Rewrite so as not to use empty "else",
9517 which gcc can warn about.
da053e48 9518 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
9519 (RETALLOC_IF): Define only if needed.
9520 (WORDCHAR_P): Likewise. This one is never needed, but is used
9521 only in a comment talking about a compiler bug, so put inside
9522 the #if 0 of that comment.
9523 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9524 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9525 Remove; unused.
19ed5445 9526
1f3561e4 9527 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
9528 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9529 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 9530
ded6f8f7
PE
9531 * search.c (simple_search): Remove unused var.
9532
dbd37a95
PE
9533 * dired.c (compile_pattern): Move decl from here ...
9534 * lisp.h: ... to here, so that it can be checked.
9535 (struct re_registers): New forward decl.
9536
7e47afad
PE
9537 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9538
85f24f61
PE
9539 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9540 All uses changed.
9541 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9542 Rename locals to avoid shadowing.
5671df8f 9543 (Fvertical_motion): Mark locals as initialized.
85f24f61 9544
181aa2be 9545 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 9546 (casify_region): Mark local as initialized.
181aa2be 9547
930d429c
PE
9548 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9549
7082eac6
PE
9550 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9551 New macros, so that the caller can use some names other than
9552 gcpro1, gcpro2, etc.
9553 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9554 of the new macros.
9555 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9556 argument, for consistency with GCPRO2_VAR, etc: it is now the
9557 prefix of the variable, not the variable itself. All uses
9558 changed.
38b2c076
PE
9559 * dired.c (directory_files_internal, file_name_completion):
9560 Rename locals to avoid shadowing.
9561
15206ed9
PE
9562 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9563 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9564 dired.c's scmp function, had undefined behavior.
9565 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9566 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9567 * buffer.h: ... to here, because these macros use current_buffer,
9568 and the new implementation with inline functions needs to have
9569 current_buffer in scope now, rather than later when the macros
9570 are used.
9571 (downcase, upcase1): New static inline functions.
9572 (DOWNCASE, UPCASE1): Reimplement using these functions.
9573 This avoids undefined behavior in expressions like
9574 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9575 from race conditions in accessing the global variables
9576 case_temp1 and case_temp2.
9577 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9578 * lisp.h (case_temp1, case_temp2): Remove their decls.
9579 * character.h (ASCII_CHAR_P): Move from here ...
9580 * lisp.h: ... to here, so that the inline functions mentioned
9581 above can use them.
9582
4a6bea26
PE
9583 * dired.c (directory_files_internal_unwind): Now static.
9584
f14b7e14
PE
9585 * fileio.c (file_name_as_directory, directory_file_name):
9586 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9587 Now static.
2893f146
PE
9588 (file_name_as_directory): Use const pointers when appropriate.
9589 (Fexpand_file_name): Likewise. In particular, newdir might
9590 point at constant storage, so make it a const pointer.
fd4ead52 9591 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
9592 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9593 signedness issues.
f839df0c
PE
9594 (Fset_file_times, Finsert_file_contents, auto_save_error):
9595 Rename locals to avoid shadowing.
f14b7e14 9596
5716756e 9597 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
9598 (Ftry_completion, Fall_completions): Rename or remove locals
9599 to avoid shadowing.
5716756e 9600
b4c3046a
PE
9601 * marker.c (bytepos_to_charpos): Remove; unused.
9602
b45db522
PE
9603 * lisp.h (verify_bytepos, count_markers): New decls,
9604 so that gcc does not warn that these functions aren't declared.
9605
85876d07
PE
9606 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9607 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 9608 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 9609 (copy_text): Remove unused local var.
85876d07 9610
03d78a21 9611 * filelock.c (within_one_second): Now static.
b3dd38ab 9612 (lock_file_1): Rename local to avoid shadowing.
03d78a21 9613
5df8f01b
PE
9614 * buffer.c (fix_overlays_before): Mark locals as initialized.
9615 (fix_start_end_in_overlays): Likewise. This function should be
9616 simplified by using pointers-to-pointers, but that's a different
9617 matter.
b1d876f1 9618 (switch_to_buffer_1): Now static.
8f54f30a
PE
9619 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9620 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 9621
a70072c9 9622 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 9623 Fix pointer signedness issue.
edced198
PE
9624 (sys_subshell): Mark local as volatile if checking for lint,
9625 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 9626 (MAXPATHLEN): Define only if needed.
a70072c9 9627
a0977c44
PE
9628 * process.c (serial_open, serial_configure): Move decls from here ...
9629 * systty.h: ... to here, so that they can be checked.
9630
a884fdcc
PE
9631 * fns.c (get_random, seed_random): Move extern decls from here ...
9632 * lisp.h: ... to here, so that they can be checked.
9633
604efe86 9634 * sysdep.c (reset_io): Now static.
b8950c94 9635 (wait_for_termination_signal): Remove; unused.
604efe86 9636
38fc62d9
PE
9637 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9638 (copy_keymap_item, append_key, push_text_char_description):
9639 Now static.
1004a21a 9640 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 9641 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
9642 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9643 (describe_map_tree):
9644 Rename locals to avoid shadowing.
38fc62d9 9645
2f2650da
PE
9646 * keyboard.c: Declare functions static if they are not used elsewhere.
9647 (echo_char, echo_dash, cmd_error, top_level_2):
9648 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
9649 (read_char, kbd_buffer_get_event, make_lispy_position):
9650 (make_lispy_event, make_lispy_movement, apply_modifiers):
9651 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9652 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9653 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 9654 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 9655 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 9656
a053e86c 9657 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
9658 (mark_kboards): Move decl here ...
9659 * alloc.c (mark_kboards): ... from here.
a053e86c 9660
4752793e
PE
9661 * lisp.h (force_auto_save_soon): New decl.
9662
74f10ca7 9663 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
9664 (DEFINE_DUMMY_FUNCTION): New macro.
9665 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9666 Use it.
c03cd23f
PE
9667 (main): Add casts to avoid warnings
9668 if GCC considers string literals to be constants.
74f10ca7 9669
022e70d4
PE
9670 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9671
59d6fe83
PE
9672 * dbusbind.c: Pointer signedness fixes.
9673 (xd_signature, xd_append_arg, xd_initialize):
9674 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9675 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9676 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9677 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9678
78320123
PE
9679 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9680 if GCC considers string literals to be constants.
49cebcca 9681 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 9682
35ac2a97
SM
96832011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9684
fb103ca9
SM
9685 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9686 (print_preprocess, print_object): New macro to fix last change.
9687
35ac2a97
SM
9688 * print.c (print_preprocess): Don't forget font objects.
9689
62973b41
JB
96902011-03-16 Juanma Barranquero <lekktu@gmail.com>
9691
9692 * emacs.c (USAGE3): Doc fixes.
9693
0e48bb22
AS
96942011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9695
9696 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9697 structure.
9698
7684e57b
JB
96992011-03-14 Juanma Barranquero <lekktu@gmail.com>
9700
9701 * lisp.h (VWindow_system, Qfile_name_history):
9702 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9703 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9704 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9705
9706 * w32select.c: Don't #include "keyboard.h".
c96bbc66 9707 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
9708
9709 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9710 * w32console.c (detect_input_pending, read_input_pending)
9711 (encode_terminal_code):
9712 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9713 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9714 (w32_system_caret_y, Qfile_name_history):
9715 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9716 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9717 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9718 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9719 * w32proc.c (Qlocal, report_file_error):
9720 * w32term.c (Vwindow_system, updating_frame):
9721 * w32uniscribe.c (initialized, uniscribe_font_driver):
9722 Remove unneeded extern declarations.
9723
2aa46d6c
CY
97242011-03-14 Chong Yidong <cyd@stupidchicken.com>
9725
c96bbc66 9726 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 9727
cffc6f3b
CY
97282011-03-13 Chong Yidong <cyd@stupidchicken.com>
9729
9730 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9731 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9732 These macros can no longer be used for assignment.
9733
44f230aa
SM
9734 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9735 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
9736 (record_buffer_markers, fetch_buffer_markers): New functions for
9737 recording and fetching special buffer markers.
9738 (set_buffer_internal_1, set_buffer_temp): Use them.
9739
9740 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9741
9742 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9743
9744 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9745 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9746
9747 * xdisp.c (hscroll_window_tree):
9748 (reconsider_clip_changes): Use PT instead of BUF_PT.
9749
d251f04b
EZ
97502011-03-13 Eli Zaretskii <eliz@gnu.org>
9751
9752 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9753 $(EMACS_ROOT)/lib/intprops.h.
9754
f0c77cd1
PE
97552011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9756
3eca4629
PE
9757 Fix more problems found by GCC 4.5.2's static checks.
9758
7c86ee98
PE
9759 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9760 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
9761 (xg_free_frame_widgets): Make it clear that a local variable is
9762 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
9763 (gdk_window_get_screen): Make it clear that this macro is needed
9764 only if USE_GTK_TOOLTIP.
1e5524e7
PE
9765 (int_gtk_range_get_value): New function, which avoids a diagnostic
9766 from gcc -Wbad-function-cast.
9767 (xg_set_toolkit_scroll_bar_thumb): Use it.
9768 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9769 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
9770 (get_utf8_string, xg_get_file_with_chooser):
9771 Rename locals to avoid shadowing.
9772 (create_dialog): Move locals to avoid shadowing.
7c86ee98 9773
41729b81
PE
9774 * xgselect.c (xg_select): Remove unused var.
9775
f0c77cd1
PE
9776 * image.c (four_corners_best): Mark locals as initialized.
9777 (gif_load): Initialize transparent_p to zero (Bug#8238).
9778 Mark another local as initialized.
ec6cf4c6 9779 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 9780
ce0ad53d 9781 * image.c (clear_image_cache): Now static.
d5d5a617 9782 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 9783 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
9784 (x_edge_detection): Remove unnecessary cast that
9785 gcc -Wbad-function-cast diagnoses.
2037898d 9786 (gif_load): Fix pointer signedness.
6ae141d6
PE
9787 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9788 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 9789
33383987 97902011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 9791
d32df629
PE
9792 Improve quality of tests for time stamp overflow.
9793 For example, without this patch (encode-time 0 0 0 1 1
9794 1152921504606846976) returns the obviously-bogus value (-948597
9795 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9796 reports time overflow. See
9797 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
9798 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9799 * editfns.c: Include limits.h and intprops.h.
9800 (TIME_T_MIN, TIME_T_MAX): New macros.
9801 (time_overflow): Move earlier, to before first use.
9802 (hi_time, lo_time): New functions, for an accurate test for
9803 out-of-range times.
9804 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9805 (Fget_internal_run_time): Don't assume time_t fits in int.
9806 (make_time): Use list2 instead of Fcons twice.
9807 (Fdecode_time): More accurate test for out-of-range times.
9808 (check_tm_member): New function.
9809 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
9810 (lisp_time_argument): Don't rely on undefined left-shift and
9811 right-shift behavior when checking for time stamp overflow.
8be6f318 9812
fe31d94c
PE
9813 * editfns.c (time_overflow): New function, refactoring common code.
9814 (Fformat_time_string, Fdecode_time, Fencode_time):
9815 (Fcurrent_time_string): Use it.
9816
8be6f318
PE
9817 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9818 * dired.c (make_time): Move to ...
9819 * editfns.c (make_time): ... here.
9820 * systime.h: Note the move.
9821
09d9db2c 98222011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 9823
126bc0dc
YM
9824 * fringe.c (update_window_fringes): Remove unused variables.
9825
c47cbdfd
YM
9826 * unexmacosx.c (copy_data_segment): Also copy __got section.
9827 (Bug#8223)
9828
7ac80be9
EZ
98292011-03-12 Eli Zaretskii <eliz@gnu.org>
9830
c96bbc66 9831 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
9832 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9833 Constify `char *' arguments and their references according to
9834 prototypes in tparam.h.
9835
ecb0f94d 9836 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 9837
7ac80be9
EZ
9838 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9839 Adapt all references accordingly.
9840
9841 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9842
ef1fd07e
TT
98432011-03-11 Tom Tromey <tromey@redhat.com>
9844
9845 * buffer.c (syms_of_buffer): Remove obsolete comment.
9846
7ef4b50c
EZ
98472011-03-11 Eli Zaretskii <eliz@gnu.org>
9848
9849 * termhooks.h (encode_terminal_code): Declare prototype.
9850
9851 * msdos.c (encode_terminal_code): Don't declare prototype.
9852
9853 * term.c (encode_terminal_code): Now external again, used by
9854 w32console.c and msdos.c.
9855
44f230aa
SM
9856 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9857 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 9858
4b1ec863 98592011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 9860
1714f52b 9861 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 9862
4b1ec863
PE
9863 * fringe.c (update_window_fringes): Mark locals as initialized
9864 (Bug#8227).
9865 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 9866
524c7aa6
PE
9867 * alloc.c (mark_fringe_data): Move decl from here ...
9868 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9869 to check its interface.
9870 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9871
a5c0af81 9872 * fontset.c (free_realized_fontset): Now static.
7519b8cd 9873 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 9874 (fontset_font): Mark local as initialized.
a9a06e0b 9875 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 9876
b4716021
PE
9877 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9878
811e9bac 9879 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 9880 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
9881 (x_own_selection, Fx_disown_selection_internal): Rename locals
9882 to avoid shadowing.
9883 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 9884
7e3ab302
PE
9885 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9886 so that the caller can use some name other than gcpro1.
9887 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
9888 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9889 (Fx_backspace_delete_keys_p):
9890 Use them to avoid shadowing, and rename vars to avoid shadowing.
9891 (x_decode_color, x_set_name, x_window): Now static.
6b437900 9892 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 9893 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
9894 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9895 Remove unused locals.
7e3ab302
PE
9896 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9897 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9898 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9899 macros.
f78faa98 9900
e2b13473
PE
9901 * xterm.h (x_mouse_leave): New decl.
9902
77f23912
PE
9903 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9904 Remove unused functions.
cdf4ba58
PE
9905 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9906 (x_calc_absolute_position): Now static.
7411c686 9907 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 9908 Don't declare local "event" unless it's used.
ed7bf3a5
PE
9909 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9910 unless they are used.
38d0b34a
PE
9911 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9912 (x_fatal_error_signal): Remove; not used.
a6067996
PE
9913 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9914 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9915 (x_error_catcher, x_connection_closed, x_error_handler):
9916 (x_error_quitter, xembed_send_message, x_iconify_frame):
9917 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 9918 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 9919 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 9920
44f230aa
SM
9921 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9922 Rename or move locals to avoid shadowing.
6b463e58 9923 (tty_defined_color, merge_face_heights): Now static.
5967d051 9924 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
9925 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9926 does not deduce is never used uninitialized.
73719eba
PE
9927 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9928 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 9929
426994c3 9930 * terminal.c (store_terminal_param): Now static.
5489860b 9931
032f1620 9932 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 9933 (set_frame_menubar): Remove unused local.
d4323972 9934 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
9935 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9936 since they might point to immutable storage.
281585b0
PE
9937 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9938 since it's unused otherwise.
032f1620 9939
367c19e5 9940 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 9941 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
9942 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9943 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 9944 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
9945 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9946 does not deduce are never used uninitialized.
70739cbe 9947
07b48fa9
PE
9948 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9949
8868a238 9950 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
9951 * window.c (window_loop, size_window):
9952 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 9953
7e5cf297 9954 * window.c (display_buffer): Now static.
d6550a9f
PE
9955 (size_window): Mark variables that gcc -Wuninitialized
9956 does not deduce are never used uninitialized.
a586633d
PE
9957 * window.h (check_all_windows): New decl, to forestall
9958 gcc -Wmissing-prototypes diagnostic.
5b555da1 9959 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 9960
f6095868
PE
9961 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9962 shadowing.
9963 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
9964 Include <limits.h>.
9965 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9966 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
9967 (load_charset_map): Mark variables that gcc -Wuninitialized
9968 does not deduce are never used uninitialized.
53df7c11 9969 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 9970
f38b440c
PE
9971 * coding.c (coding_set_source, coding_set_destination):
9972 Use "else { /* comment */ }" rather than "else /* comment */;"
9973 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
9974 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9975 a block, when the outer 'i' will do.
9976 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9977 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9978 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9979 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9980 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9981 Rename locals to avoid shadowing.
9982 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
9983 * coding.c (emacs_mule_char, encode_invocation_designation):
9984 Now static, since they're not used elsewhere.
413bb2db 9985 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 9986 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
9987 (decode_coding_emacs_mule): Mark variables that gcc
9988 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
9989 (detect_coding_iso_2022): Initialize a local variable that might
9990 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 9991 this initialization is needed. (Bug#8211)
5f58e762
PE
9992 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9993 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9994 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9995 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9996 Remove unused macros.
f38b440c 9997
232b38b9 9998 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 9999 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 10000 * character.c (string_count_byte8): Likewise.
232b38b9 10001
fb90da1b
PE
10002 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
10003 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
10004
fb93dbc2
PE
10005 * chartab.c (copy_sub_char_table): Now static, since it's not used
10006 elsewhere.
5c156ace
PE
10007 (sub_char_table_ref_and_range, char_table_ref_and_range):
10008 Rename locals to avoid shadowing.
bbcd0949 10009 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 10010
7d3b3862 10011 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 10012 (BIDI_BOB): Remove unused macro.
7d3b3862 10013
6be7d3da
PE
10014 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
10015 deduce are never used uninitialized.
c2ed9c8b 10016 * term.c (encode_terminal_code): Likewise.
6be7d3da 10017
75f8807f 10018 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 10019
50938595
PE
10020 * tparam.h: New file.
10021 * term.c, tparam.h: Include it.
10022 * deps.mk (term.o, tparam.o): Depend on tparam.h.
10023 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
10024 Move these decls to tparam.h, and make them agree with what
10025 is actually in tparam.c. The previous trick of using incompatible
10026 decls in different modules does not conform to the C standard.
10027 All callers of tparam changed to use tparam's actual API.
10028 * tparam.c (tparam1, tparam, tgoto):
10029 Use const pointers where appropriate.
10030
fbceeba2
PE
10031 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
10032 * cm.h (struct cm): Likewise.
10033 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
10034 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
10035 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
10036 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
10037 (turn_on_face, init_tty): Likewise.
10038 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 10039
7f3f1250
PE
10040 * term.c (term_mouse_position): Rename local to avoid shadowing.
10041
e6ca6543
PE
10042 * alloc.c (mark_ttys): Move decl from here ...
10043 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
10044
c40f8d15
AS
100452011-03-11 Andreas Schwab <schwab@linux-m68k.org>
10046
10047 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
10048
cfe0661d
JB
100492011-03-09 Juanma Barranquero <lekktu@gmail.com>
10050
10051 * search.c (compile_pattern_1): Remove argument regp, unused since
10052 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
10053 (compile_pattern): Don't pass it.
10054
0afb4571
J
100552011-03-08 Jan Djärv <jan.h.d@swipnet.se>
10056
10057 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
10058 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
10059 for ! HAVE_GTK3.
10060 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
10061
10062 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
10063
10064 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
10065 gdk_window_get_screen, gdk_window_get_geometry,
10066 gdk_x11_window_lookup_for_display and GDK_KEY_g.
10067 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
10068 (xg_get_pixbuf_from_pixmap): New function.
10069 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
10070 to Pixmap, take frame as parameter, remove GdkColormap parameter.
10071 Call xg_get_pixbuf_from_pixmap instead of
10072 gdk_pixbuf_get_from_drawable.
10073 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
10074 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
10075 (xg_check_special_colors): Use GtkStyleContext and its functions
10076 for HAVE_GTK3.
10077 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
10078 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
10079 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
10080 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
10081 Call gtk_widget_get_preferred_size.
0afb4571
J
10082 (xg_frame_resized): gdk_window_get_geometry only takes 5
10083 parameters.
44f230aa
SM
10084 (xg_win_to_widget, xg_event_is_for_menubar):
10085 Call gdk_x11_window_lookup_for_display.
0afb4571
J
10086 (xg_set_widget_bg): New function.
10087 (delete_cb): New function.
895009e1 10088 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 10089 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
10090 (xg_set_background_color): Call xg_set_widget_bg.
10091 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
10092 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
10093 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
10094 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
10095 if ! HAVE_GTK3.
10096 (update_frame_tool_bar): Call gtk_widget_hide.
10097 (xg_initialize): Use GDK_KEY_g.
10098
10099 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
10100 if ! HAVE_GTK3
10101 (x_session_initialize): Call gdk_x11_set_sm_client_id.
10102
10103 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
10104 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
10105 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
10106
1c2cc4ef
JB
101072011-03-08 Juanma Barranquero <lekktu@gmail.com>
10108
10109 * w32xfns.c (select_palette): Check success of RealizePalette against
10110 GDI_ERROR, not zero.
10111
33383987 10112See ChangeLog.11 for earlier changes.
aac0c6e3
MR
10113
10114;; Local Variables:
10115;; coding: utf-8
aac0c6e3
MR
10116;; End:
10117
2f097256 10118 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
10119
10120 This file is part of GNU Emacs.
10121
10122 GNU Emacs is free software: you can redistribute it and/or modify
10123 it under the terms of the GNU General Public License as published by
10124 the Free Software Foundation, either version 3 of the License, or
10125 (at your option) any later version.
10126
10127 GNU Emacs is distributed in the hope that it will be useful,
10128 but WITHOUT ANY WARRANTY; without even the implied warranty of
10129 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
10130 GNU General Public License for more details.
10131
10132 You should have received a copy of the GNU General Public License
10133 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.