* lread.c (string_to_number): Simplify the 2011-04-26 change by invoking xsignal1.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
eb49b136
PE
12011-06-19 Paul Eggert <eggert@cs.ucla.edu>
2
e4d29b33
PE
3 * lread.c (invalid_syntax): Omit length argument.
4 All uses changed. This doesn't fix a bug, but it simplifies the
5 code away from its former Hollerith-constant appearance, and it's
6 one less 'int' to worry about when looking at integer-overflow issues.
f14ed477 7 (string_to_number): Simplify the 2011-04-26 change by invoking xsignal1.
e4d29b33 8
eb49b136
PE
9 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
10 This didn't break anything, but it didn't help either.
11 It's confusing to put a bogus integer in a place where the actual
12 value does not matter.
9f62aeb1 13 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 14 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 15
e39e811e
PE
162011-06-18 Paul Eggert <eggert@cs.ucla.edu>
17
15375a22
PE
18 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
19 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
20 implementation.
b61cc01c
PE
21 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
22 We prefer signed types, and the value cannot exceed the EMACS_INT
23 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
24 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
25 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
26 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 27
53b2623d
PE
28 * indent.c (sane_tab_width): New function.
29 (current_column, scan_for_column, Findent_to, position_indentation)
30 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 31 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 32
45aebb64
PE
33 * image.c (xbm_image_p): Don't assume stated width and height fit in int.
34
f2ed8a70
PE
35 * lisp.h (lint_assume): New macro.
36 * composite.c (composition_gstring_put_cache):
37 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
38
abe80cc6
PE
39 * editfns.c, insdel.c:
40 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 41
b02c740e
PE
42 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
43
ebc96716
PE
44 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
45
b4e50fa0 46 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 47 Use much-faster test for byte-length change.
311d5d7c 48 Don't assume string byte-length fits in 'int'.
a4cf38e4 49 Check that character arg fits in 'int'.
85461888 50 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 51
c0c1ee9f
PE
52 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
53
a498d7f4
PE
54 * fns.c (concat): Catch string overflow earlier.
55 Do not rely on integer wraparound.
56
e39e811e
PE
57 * dispextern.h (struct it.overlay_strings_charpos): EMACS_INT, not int.
58
fadf4e30
PE
592011-06-17 Paul Eggert <eggert@cs.ucla.edu>
60
87830974
PE
61 * dispextern.h (struct it.selective): Now EMACS_INT, not int.
62 * xdisp.c (forward_to_next_line_start)
63 (back_to_previous_visible_line_start)
64 (reseat_at_next_visible_line_start, next_element_from_buffer):
65 Don't arbitrarily truncate the value of 'selective' to int.
66
76031fad
PE
67 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
68
5eb55db9
PE
69 * composite.c: Don't truncate sizes to 'int'.
70 (composition_gstring_p, composition_reseat_it)
71 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
72 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
73 not EMACS_UINT, for indexes.
5eb55db9 74
0703a717
PE
75 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
76
d6202519
PE
77 * buffer.c: Include <verify.h>.
78 (struct sortvec.priority, struct sortstr.priority):
8961a454 79 Now EMACS_INT, not int.
c20998a7 80 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
81 (struct sortstr.size, record_overlay_string)
82 (struct sortstrlist.size, struct sortlist.used):
83 Don't truncate size to int.
84 (record_overlay_string): Check for size-calculation overflow.
d6202519 85 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 86
28177add
PE
872011-06-16 Paul Eggert <eggert@cs.ucla.edu>
88
dd3482fe
PE
89 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
90 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
91 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
92
393d71f3 93 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
94 * fileio.c (Finsert_file_contents):
95 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
96 Remove the old (too-loose) buffer overflow checks.
97 They weren't needed, since make_gap checks for buffer overflow.
98 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
99 The old code merely checked for Emacs fixnum overflow, and relied
100 on undefined (wraparound) behavior. The new code avoids undefined
101 behavior, and also checks for ptrdiff_t and/or size_t overflow.
102
2e6813b0 103 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
104 Tune. Don't use wider integers than needed. Don't use alloca.
105 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 106
599a9e4f
PE
107 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
108
99561444
PE
109 * insdel.c, lisp.h (buffer_overflow): New function.
110 (insert_from_buffer_1, replace_range, replace_range_2):
111 * insdel.c (make_gap_larger):
112 * editfns.c (Finsert_char):
113 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
114
28177add
PE
115 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
116
e69dafad
PE
1172011-06-15 Paul Eggert <eggert@cs.ucla.edu>
118
a7af7fde 119 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 120
b1c46f02
PE
121 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
122 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
123
e69dafad
PE
124 * fileio.c: Don't assume EMACS_INT fits in off_t.
125 (emacs_lseek): New static function.
126 (Finsert_file_contents, Fwrite_region): Use it.
127 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
128
566684ea
PE
129 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
130
e6966cd6
PE
131 * fns.c: Don't overflow int when computing a list length.
132 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
133 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
134 truncation on 64-bit hosts. Check for QUIT every
135 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
136 faster and is responsive enough.
137 (Flength): Report an error instead of overflowing an integer.
138 (Fsafe_length): Return a float if the value is not representable
139 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 140 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 141 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 142
dd0b0efb
PE
143 * alloc.c: Check that resized vectors' lengths fit in fixnums.
144 (header_size, word_size): New constants.
145 (allocate_vectorlike): Don't check size overflow here.
146 (allocate_vector): Check it here instead, since this is the only
147 caller of allocate_vectorlike that could cause overflow.
148 Check that the new vector's length is representable as a fixnum.
149
86fe5cfe
PE
150 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
151 The previous code was bogus. For example, next_almost_prime (32)
152 returned 39, which is undesirable as it is a multiple of 3; and
153 next_almost_prime (24) returned 25, which is a multiple of 5 so
154 why was the code bothering to check for multiples of 7?
155
80e88859
PE
156 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
157
4a2f0ad6
PE
158 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
159
f66c7cf8
PE
160 Variadic C functions now count arguments with ptrdiff_t.
161 This partly undoes my 2011-03-30 change, which replaced int with size_t.
162 Back then I didn't know that the Emacs coding style prefers signed int.
163 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
164 were being counted with int, which may truncate counts on 64-bit
165 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
166 * lisp.h (struct Lisp_Subr.function.aMANY)
167 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
168 Arg counts are now ptrdiff_t, not size_t.
169 All variadic functions and their callers changed accordingly.
170 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
171 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
172 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
173 * callint.c (Fcall_interactively): Check arg count for overflow,
174 to avoid potential buffer overrun. Use signed char, not 'int',
175 for 'varies' array, so that we needn't bother to check its size
176 calculation for overflow.
177 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
178 * eval.c (apply_lambda):
179 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
180 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
181 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
182
a1759b76
PE
183 * callint.c (Fcall_interactively): Don't use index var as event count.
184
d96be9fc
PE
185 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
186 * mem-limits.h (SIZE): Remove; no longer used.
187
a690a978 188 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 189
578c21e6
PE
190 Remove unnecessary casts.
191 * xterm.c (x_term_init):
192 * xfns.c (x_set_border_pixel):
193 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
194 These aren't needed now that we assume ANSI C.
195
96f53c6c
PE
196 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
197 It's more likely to cause problems (due to unsigned overflow)
198 than to cure them.
199
83c77d31
PE
200 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
201
ee2079f1
PE
202 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
203
6da65536
PE
204 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
205
7147c4a4
PE
206 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
207
193e32d9
PE
208 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
209
e5533da6
PE
210 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
211
9910e595
PE
212 GLYPH_CODE_FACE returns EMACS_INT, not int.
213 * dispextern.h (merge_faces):
214 * xfaces.c (merge_faces):
01103c44
PE
215 * xdisp.c (get_next_display_element, next_element_from_display_vector):
216 Don't assume EMACS_INT fits in int.
9910e595 217
2638320e
PE
218 * character.h (CHAR_VALID_P): Remove unused parameter.
219 * fontset.c, lisp.h, xdisp.c: All uses changed.
220
045eb8d9
PE
221 * editfns.c (Ftranslate_region_internal): Omit redundant test.
222
c1f134b5
PE
223 * fns.c (concat): Minor tuning based on overflow analysis.
224 This doesn't fix any bugs. Use int to hold character, instead
225 of constantly refetching from Emacs object. Use XFASTINT, not
226 XINT, for value known to be a character. Don't bother comparing
227 a single byte to 0400, as it's always less.
228
395fcb93 229 * floatfns.c (Fexpt):
327eeec8
PE
230 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
231
abbd3d23
PE
232 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
233 for characters.
234
684a03ef
PE
235 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
236
0fed43f3
PE
237 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
238 Without this fix, on a 64-bit host (aset S 0 4294967386) would
239 incorrectly succeed when S was a string, because 4294967386 was
240 truncated before it was used.
241
8fd02eb7
PE
242 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
243 Otherwise, an out-of-range integer could cause undefined behavior
244 on a 64-bit host.
245
f8c86b69
PE
246 * composite.c: Use int, not EMACS_INT, for characters.
247 (fill_gstring_body, composition_compute_stop_pos): Use int, not
248 EMACS_INT, for values that are known to be in character range.
249 This doesn't fix any bugs but is the usual style inside Emacs and
250 may generate better code on 32-bit machines.
251
34206dd2
PE
252 Make sure a 64-bit char is never passed to ENCODE_CHAR.
253 This is for reasons similar to the recent CHAR_STRING fix.
254 * charset.c (Fencode_char): Check that character arg is actually
255 a character. Pass an int to ENCODE_CHAR.
256 * charset.h (ENCODE_CHAR): Verify that the character argument is no
257 wider than 'int', as a compile-time check to prevent future regressions
258 in this area.
259
c5958d4c 260 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
261
262 Make sure a 64-bit char is never passed to CHAR_STRING.
263 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
264 by silently ignoring the top 32 bits, allowing some values
265 that were far too large to be valid characters.
266 * character.h: Include <verify.h>.
267 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
268 arguments are no wider than unsigned, as a compile-time check
269 to prevent future regressions in this area.
270 * data.c (Faset):
01103c44 271 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
272 (Fsubst_char_in_region):
273 * fns.c (concat):
274 * xdisp.c (decode_mode_spec_coding):
275 Adjust to CHAR_STRING's new requirement.
276 * editfns.c (Finsert_char, Fsubst_char_in_region):
277 * fns.c (concat): Check that character args are actually
278 characters. Without this test, these functions did the wrong
279 thing with wildly out-of-range values on 64-bit hosts.
280
d37ca623
PE
281 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
282 These casts should not be needed on 32-bit hosts, either.
283 * keyboard.c (read_char):
284 * lread.c (Fload): Remove casts to unsigned.
285
ea204efb
PE
286 * lisp.h (UNSIGNED_CMP): New macro.
287 This fixes comparison bugs on 64-bit hosts.
288 (ASCII_CHAR_P): Use it.
289 * casefiddle.c (casify_object):
01103c44 290 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
291 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
292 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
293 * dispextern.h (FACE_FROM_ID):
294 * keyboard.c (read_char): Use UNSIGNED_CMP.
295
41cb286c
PE
296 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
297 not to EMACS_INT, to avoid GCC warning.
298
4a1b9832
PE
299 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
300
55daad71
PE
301 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
302 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
303 isn't needed on 32-bit machines.
8f95c75c 304
01103c44
PE
305 * buffer.c (Fgenerate_new_buffer_name):
306 Use EMACS_INT for count, not int.
0ceccced 307 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
308
309 * data.c (Qcompiled_function): Now static.
310
c6f072e7
PE
311 * window.c (window_body_lines): Now static.
312
20ce5912
PE
313 * image.c (gif_load): Rename local to avoid shadowing.
314
9c4c5f81
PE
315 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
316 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
317 * alloc.c (make_save_value): Integer argument is now of type
318 ptrdiff_t, not int.
319 (mark_object): Use ptrdiff_t, not int.
320 * lisp.h (pD): New macro.
321 * print.c (print_object): Use it.
322
c0c5c8ae
PE
323 * alloc.c: Use EMACS_INT, not int, to count objects.
324 (total_conses, total_markers, total_symbols, total_vector_size)
325 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
326 (total_free_floats, total_floats, total_free_intervals)
327 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
328 Now EMACS_INT, not int. All uses changed.
329 (Fgarbage_collect): Compute overall total using a double, so that
330 integer overflow is less likely to be a problem. Check for overflow
331 when converting back to an integer.
5a25e253
PE
332 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
333 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
334 These were 'int' variables that could overflow on 64-bit hosts;
335 they were never used, so remove them instead of repairing them.
211a0b2a 336 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
337 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
338 Previously, this ceilinged at INT_MAX, but that doesn't work on
339 64-bit machines.
e46bb31a 340 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 341
c78baabf 342 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 343 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
344 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
345 when a (possibly-narrower) signed value would do just as well.
346 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 347
c9d624c6
PE
348 * alloc.c: Catch some string size overflows that we were missing.
349 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
350 for convenience in STRING_BYTES_MAX.
351 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
352 The definition here is exact; the one in lisp.h was approximate.
353 (allocate_string_data): Check for string overflow. This catches
354 some instances we weren't catching before. Also, it catches
355 size_t overflow on (unusual) hosts where SIZE_MAX <= min
356 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
357 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 358
c9d624c6
PE
359 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
360 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
361 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
362
353032ce
PE
363 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
364
2bccce07
PE
365 * alloc.c (Fmake_string): Check for out-of-range init.
366
0ac30604
SM
3672011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
368
369 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
370
c195f2de
JD
3712011-06-14 Jan Djärv <jan.h.d@swipnet.se>
372
373 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
374 xg_get_default_scrollbar_width.
375
376 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
377 (int_gtk_range_get_value): Move to the scroll bar part of the file.
378 (style_changed_cb): Call update_theme_scrollbar_width and call
379 x_set_scroll_bar_default_width and xg_frame_set_char_size for
380 all frames (Bug#8505).
381 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
382 Call gtk_window_set_resizable if HAVE_GTK3.
383 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
384 and height if HAVE_GTK3 (Bug#8505).
385 (scroll_bar_width_for_theme): New variable.
386 (update_theme_scrollbar_width): New function.
387 (xg_get_default_scrollbar_width): Move code to
388 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
389 (xg_initialize): Call update_theme_scrollbar_width.
390
391 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
392
393 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
394
e10ac9f1
MR
3952011-06-12 Martin Rudalics <rudalics@gmx.at>
396
397 * frame.c (make_frame): Call other_buffer_safely instead of
398 other_buffer.
399
400 * window.c (temp_output_buffer_show): Call display_buffer with
401 second argument Vtemp_buffer_show_specifiers and reset latter
402 immediately after the call.
403 (Vtemp_buffer_show_specifiers): New variable.
404 (auto_window_vscroll_p, next_screen_context_lines)
405 (Vscroll_preserve_screen_position): Remove leading asterisks from
406 doc-strings.
407
2d3c217e 4082011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 409
7b7f97e8 410 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
411 * buffer.c (Qclone_number): Remove for now, as it's unused.
412 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
413 (record_buffer): Remove unused local.
414 * frame.c (other_visible_frames, frame_buffer_list): Now static.
415 (set_frame_buffer_list): Remove; unused.
416 * frame.h (other_visible_frames): Remove decl.
417 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
418 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
419 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
420 if HAVE_GPM.
421 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
422 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
423 Define only if HAVE_GPM.
424 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
425 (update_hints_inhibit): Remove; never set. All uses removed.
426 * widgetprv.h (emacsFrameClassRec): Remove decl.
427 * window.c (delete_deletable_window): Now returns void, since it
428 wasn't returning anything.
429 (compare_window_configurations): Remove unused locals.
430 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
431 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
432 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
433 the same widths as pointers. This follows up on the 2011-05-06 patch.
434 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
435 * xterm.h: Likewise.
436 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
437
1384b89e
JB
4382011-06-12 Juanma Barranquero <lekktu@gmail.com>
439
440 * makefile.w32-in: Update dependencies.
441 (LISP_H): Add lib/intprops.h.
442
1100a63c
CY
4432011-06-11 Chong Yidong <cyd@stupidchicken.com>
444
445 * image.c (gif_load): Add animation frame delay to the metadata.
446 (syms_of_image): Use DEFSYM. New symbol `delay'.
447
6198ccd0
MR
4482011-06-11 Martin Rudalics <rudalics@gmx.at>
449
450 * window.c (delete_deletable_window): Re-add.
451 (Fset_window_configuration): Rewrite to handle dead buffers and
452 consequently deletable windows.
453 (window_tree, Fwindow_tree): Remove. Supply functionality in
454 window.el.
455 (compare_window_configurations): Simplify code.
456
b6e3633c
AS
4572011-06-11 Andreas Schwab <schwab@linux-m68k.org>
458
1ab0dee5
AS
459 * image.c (imagemagick_load_image): Fix type mismatch.
460 (Fimagemagick_types): Likewise.
461
b6e3633c
AS
462 * window.h (replace_buffer_in_windows): Declare.
463
9397e56f
MR
4642011-06-11 Martin Rudalics <rudalics@gmx.at>
465
466 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
467 Qclone_number. Remove external declaration of Qdelete_window.
468 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
469 code.
470 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
471 Qbuffer_list_update_hook if allowed.
472 (Fother_buffer): Rewrite doc-string. Major rewrite for new
473 buffer list implementation.
474 (other_buffer_safely): New function.
475 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
476 calls to replace_buffer_in_windows and
477 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
478 if allowed.
479 (record_buffer): Inhibit quitting and rewrite using quittable
480 functions. Run Qbuffer_list_update_hook if allowed.
481 (Frecord_buffer, Funrecord_buffer): New functions.
482 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
483 switch-to-buffer to window.el.
484 (bury-buffer): Move to window.el.
485 (Vbuffer_list_update_hook): New variable.
486
487 * lisp.h (other_buffer_safely): Add prototype in buffer.c
488 section.
489
490 * window.h (resize_frame_windows): Move up in code.
491 (Fwindow_frame): Remove EXFUN.
492 (replace_buffer_in_all_windows): Remove prototype.
493 (replace_buffer_in_windows_safely): Add prototype.
494
495 * window.c: Declare Qdelete_window static again. Move down
496 declaration of select_count.
497 (Fnext_window, Fprevious_window): Rewrite doc-strings.
498 (Fother_window): Move to window.el.
499 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
500 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
501 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
502 window.el.
503 (replace_buffer_in_windows): Implement by calling
504 Qreplace_buffer_in_windows.
505 (replace_buffer_in_all_windows): Remove with some functionality
506 moved into replace_buffer_in_windows_safely.
507 (replace_buffer_in_windows_safely): New function.
508 (select_window_norecord, select_frame_norecord): Move in front
509 of run_window_configuration_change_hook. Remove now obsolete
510 declarations.
511 (Fset_window_buffer): Rewrite doc-string. Call
512 Qrecord_window_buffer.
513 (keys_of_window): Move binding for other-window to window.el.
514
b50691aa
CY
5152011-06-11 Chong Yidong <cyd@stupidchicken.com>
516
517 * dispextern.h (struct image): Replace data member, whose int_val
518 and ptr_val fields were not used by anything, with a single
519 lisp_val object.
520
521 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
522 (gif_clear_image, gif_load, imagemagick_load_image)
523 (gs_clear_image, gs_load): Callers changed.
524
3f754b86
PE
5252011-06-10 Paul Eggert <eggert@cs.ucla.edu>
526
cca69397
PE
527 * buffer.h: Include <time.h>, for time_t.
528 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
529
109e28d0
PE
530 Fix minor problems found by static checking.
531
60737f02
PE
532 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
533
4b66faf3
PE
534 Make identifiers static if they are not used in other modules.
535 * data.c (Qcompiled_function, Qframe, Qvector):
536 * image.c (QimageMagick, Qsvg):
537 * minibuf.c (Qmetadata):
538 * window.c (resize_window_check, resize_root_window): Now static.
539 * window.h (resize_window_check, resize_root_window): Remove decls.
540
109e28d0
PE
541 * window.c (window_deletion_count, delete_deletable_window):
542 Remove; unused.
46a4ce9e
PE
543 (window_body_lines): Now static.
544 (Fdelete_other_windows_internal): Mark vars as initialized.
545 Make sure 'resize_failed' is initialized.
546 (run_window_configuration_change_hook): Rename local to avoid shadowing.
547 (resize_window_apply): Remove unused local.
548 * window.h (delete_deletable_window): Remove decl.
549
109e28d0 550 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
551 (imagemagick_load_image): Fix pointer signedness problem by changing
552 last arg from unsigned char * to char *. All uses changed.
553 Also, fix a local for similar reasons.
554 Remove unused locals. Remove locals to avoid shadowing.
555 (fn_rsvg_handle_free): Remove; unused.
556 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 557 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 558
3f754b86
PE
559 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
560
2547adb1
CY
5612011-06-10 Chong Yidong <cyd@stupidchicken.com>
562
563 * image.c (gif_load): Fix omitted cast error introduced by
564 2011-06-06 change.
565
2c8e37d4
MR
5662011-06-10 Martin Rudalics <rudalics@gmx.at>
567
568 * window.h (resize_proportionally, orig_total_lines)
569 (orig_top_line): Remove from window structure.
570 (set_window_height, set_window_width, change_window_heights)
571 (Fdelete_window): Remove prototypes.
572 (resize_frame_windows): Remove duplicate declaration.
573
440a42e3
EZ
5742011-06-10 Eli Zaretskii <eliz@gnu.org>
575
576 * window.h (resize_frame_windows, resize_window_check)
577 (delete_deletable_window, resize_root_window)
578 (resize_frame_windows): Declare prototypes.
579
580 * window.c (resize_window_apply): Make definition be "static" to
581 match the prototype.
582
562dd5e9
MR
5832011-06-10 Martin Rudalics <rudalics@gmx.at>
584
585 * window.c: Remove declarations of Qwindow_size_fixed,
586 window_min_size_1, window_min_size_2, window_min_size,
587 size_window, window_fixed_size_p, enlarge_window, delete_window.
588 Remove static from declaration of Qdelete_window, it's
589 temporarily needed by Fbury_buffer.
590 (replace_window): Don't assign orig_top_line and
591 orig_total_lines.
592 (Fdelete_window, delete_window): Remove. Window deletion is
593 handled by window.el.
594 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
595 Fdelete_window calls with calls to Qdelete_window.
596 (Fdelete_other_windows): Remove. Deleting other windows is
597 handled by window.el.
598 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
599 handled in window.el.
600 (window_min_size_2, window_min_size_1, window_min_size): Remove.
601 Window minimum sizes are handled in window.el.
602 (shrink_windows, size_window, set_window_height)
603 (set_window_width, change_window_heights, window_height)
604 (window_width, CURBEG, CURSIZE, enlarge_window)
605 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
606 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
607 handled in window.el.
608 (make_dummy_parent): Rename to make_parent_window and give it a
609 second argument horflag.
610 (make_window): Don't set resize_proportionally any more.
611 (Fsplit_window): Remove. Windows are split in window.el.
612 (save_restore_action, save_restore_orig_size)
613 (shrink_window_lowest_first, save_restore_orig_size): Remove.
614 Resize mini windows in window.el.
615 (grow_mini_window, shrink_mini_window): Implement by calling
616 Qresize_root_window_vertically, resize_window_check and
617 resize_window_apply.
618 (saved_window, Fset_window_configuration, save_window_save): Do
619 not handle orig_top_line, orig_total_lines, and
620 resize_proportionally.
621 (window_min_height, window_min_width): Move to window.el.
622 (keys_of_window): Move bindings for delete-other-windows,
623 split-window, delete-window and enlarge-window to window.el.
624
625 * buffer.c: Temporarily extern Qdelete_window.
626 (Fbury_buffer): Temporarily call Qdelete_window instead of
627 Fdelete_window (Fbury_buffer will move to window.el soon).
628
629 * frame.c (set_menu_bar_lines_1): Remove code handling
630 orig_top_line and orig_total_lines.
631
632 * dispnew.c (adjust_frame_glyphs_initially): Don't use
633 set_window_height but set heights directly.
634 (change_frame_size_1): Use resize_frame_windows.
635
636 * xdisp.c (init_xdisp): Don't use set_window_height but set
637 heights directly.
638
639 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
640 resize_frame_windows instead of change_window_heights and run
641 run_window_configuration_change_hook.
642
643 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
644 instead of change_window_heights and run
645 run_window_configuration_change_hook.
646
1a13852e
MR
6472011-06-09 Martin Rudalics <rudalics@gmx.at>
648
649 * window.c (replace_window): Rename second argument REPLACEMENT to
650 NEW. New third argument SETFLAG. Rewrite.
651 (delete_window, make_dummy_parent): Call replace_window with
652 third argument 1.
653 (window_list_1): Move down in code.
654 (run_window_configuration_change_hook): Move set_buffer part
655 before select_frame_norecord part in order to unwind correctly.
656 Rename count1 to count.
657 (recombine_windows, delete_deletable_window, resize_root_window)
658 (Fdelete_other_windows_internal)
659 (Frun_window_configuration_change_hook, make_parent_window)
660 (resize_window_check, resize_window_apply, Fresize_window_apply)
661 (resize_frame_windows, Fsplit_window_internal)
662 (Fdelete_window_internal, Fresize_mini_window_internal): New
663 functions.
664 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
665
f3d1777e
MR
6662011-06-08 Martin Rudalics <rudalics@gmx.at>
667
496e208e
MR
668 * window.h (window): Add some new members to window structure -
669 normal_lines, normal_cols, new_total, new_normal, clone_number,
670 splits, nest, prev_buffers, next_buffers.
671 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 672 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 673
f3d1777e
MR
674 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
675 Remove.
496e208e
MR
676 (make_dummy_parent): Set new members of windows structure.
677 (make_window): Move down in code. Handle new members of window
678 structure.
679 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
680 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
681 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
682 (Fset_window_prev_buffers, Fwindow_next_buffers)
683 (Fset_window_next_buffers, Fset_window_clone_number): New
684 functions.
685 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
686 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
687 Doc-string fixes.
688 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
689 Argument WINDOW can be now internal window too.
690 (Fwindow_use_time): Move up in code.
691 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
692 Rewrite doc-string.
693 (Fset_window_configuration, saved_window)
694 (Fcurrent_window_configuration, save_window_save): Handle new
695 members of window structure.
b9e809c2
MR
696 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
697 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
698 (syms_of_window): New Lisp objects Qrecord_window_buffer,
699 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
700 Qget_mru_window, Qresize_root_window,
701 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
702 Qauto_buffer_name; staticpro them.
f3d1777e 703
abde8f8c
MR
7042011-06-07 Martin Rudalics <rudalics@gmx.at>
705
706 * window.c (Fwindow_total_size, Fwindow_left_column)
707 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
708 (Fwindow_list_1): New functions.
709 (window_box_text_cols): Replace with window_body_cols.
710 (Fwindow_width, Fscroll_left, Fscroll_right): Use
711 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
712 (delete_window, Fset_window_configuration): Call
713 delete_all_subwindows with window as argument.
714 (delete_all_subwindows): Take a window as argument and not a
715 structure. Rewrite.
190b47e6
MR
716 (window_loop): Remove handling of GET_LRU_WINDOW and
717 GET_LARGEST_WINDOW.
718 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
719
720 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
721 window_box_text_cols. delete_all_subwindows now takes a
722 Lisp_Object as argument.
abde8f8c
MR
723
724 * indent.c (compute_motion, Fcompute_motion): Use
725 window_body_cols instead of window_box_text_cols.
726
fa8a67e6
MR
727 * frame.c (delete_frame): Call delete_all_subwindows with root
728 window as argument.
729
a54e3482
DC
7302011-06-07 Daniel Colascione <dan.colascione@gmail.com>
731
732 * fns.c (Fputhash): Document return value.
733
60002bf5
CY
7342011-06-06 Chong Yidong <cyd@stupidchicken.com>
735
736 * image.c (gif_load): Implement gif89a spec "no disposal" method.
737
0c671da6 7382011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 739
b862a52a 740 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 741
be44ca6c
PE
742 Check for overflow when converting integer to cons and back.
743 * charset.c (Fdefine_charset_internal, Fdecode_char):
744 Use cons_to_unsigned to catch overflow.
745 (Fencode_char): Use INTEGER_TO_CONS.
746 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
747 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
748 * data.c (long_to_cons, cons_to_long): Remove.
749 (cons_to_unsigned, cons_to_signed): New functions.
750 These signal an error for invalid or out-of-range values.
751 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
752 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
753 * font.c (Ffont_variation_glyphs):
754 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
755 * lisp.h: Include <intprops.h>.
756 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
757 (cons_to_signed, cons_to_unsigned): New decls.
758 (long_to_cons, cons_to_long): Remove decls.
759 * undo.c (record_first_change): Use INTEGER_TO_CONS.
760 (Fprimitive_undo): Use CONS_TO_INTEGER.
761 * xfns.c (Fx_window_property): Likewise.
762 * xselect.c: Include <limits.h>.
763 (x_own_selection, selection_data_to_lisp_data):
764 Use INTEGER_TO_CONS.
765 (x_handle_selection_request, x_handle_selection_clear)
766 (x_get_foreign_selection, Fx_disown_selection_internal)
767 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
768 (lisp_data_to_selection_data): Use cons_to_unsigned.
769 (x_fill_property_data): Use cons_to_signed.
770 Report values out of range.
771
d1f3d2af
PE
772 Check for buffer and string overflow more precisely.
773 * buffer.h (BUF_BYTES_MAX): New macro.
774 * lisp.h (STRING_BYTES_MAX): New macro.
775 * alloc.c (Fmake_string):
776 * character.c (string_escape_byte8):
777 * coding.c (coding_alloc_by_realloc):
778 * doprnt.c (doprnt):
779 * editfns.c (Fformat):
780 * eval.c (verror):
781 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
782 since they may not be the same number.
783 * editfns.c (Finsert_char):
784 * fileio.c (Finsert_file_contents):
785 Likewise for BUF_BYTES_MAX.
786
dd52fcea
PE
787 * image.c: Use ptrdiff_t, not int, for sizes.
788 (slurp_file): Switch from int to ptrdiff_t.
789 All uses changed.
790 (slurp_file): Check that file size fits in both size_t (for
791 malloc) and ptrdiff_t (for sanity and safety).
792
7f9bbdbb
PE
793 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
794 if b->modtime has its maximal value.
795
dfe18f82
PE
796 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
797
84acfcf0
PE
798 Don't assume time_t can fit into int.
799 * buffer.h (struct buffer.modtime): Now time_t, not int.
800 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
801 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
802
ccd9a01a
PE
803 Minor fixes for signed vs unsigned integers.
804 * character.h (MAYBE_UNIFY_CHAR):
805 * charset.c (maybe_unify_char):
806 * keyboard.c (read_char, reorder_modifiers):
807 XINT -> XFASTINT, since the integer must be nonnegative.
808 * ftfont.c (ftfont_spec_pattern):
809 * keymap.c (access_keymap, silly_event_symbol_error):
810 XUINT -> XFASTINT, since the integer must be nonnegative.
811 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
812 since it makes no difference and we prefer signed.
813 * keyboard.c (record_char): Use XUINT when all the neighbors do.
814 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
815 nonnegative.
816
d6d100dd
SM
8172011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
818
819 * window.h (Fwindow_frame): Declare.
820
2b6148e4
PE
8212011-06-06 Paul Eggert <eggert@cs.ucla.edu>
822
823 * alloc.c: Simplify handling of large-request failures (Bug#8800).
824 (SPARE_MEMORY): Always define.
825 (LARGE_REQUEST): Remove.
826 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
827
f230ecc9
MR
8282011-06-06 Martin Rudalics <rudalics@gmx.at>
829
727e958e
MR
830 * lisp.h: Move EXFUNS for Fframe_root_window,
831 Fframe_first_window and Fset_frame_selected_window to window.h.
832
833 * window.h: Move EXFUNS for Fframe_root_window,
834 Fframe_first_window and Fset_frame_selected_window here from
835 lisp.h.
836
837 * frame.c (Fwindow_frame, Fframe_first_window)
838 (Fframe_root_window, Fframe_selected_window)
839 (Fset_frame_selected_window): Move to window.c.
840 (Factive_minibuffer_window): Move to minibuf.c.
841 (Fother_visible_frames_p): New function.
842
843 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
844
f230ecc9
MR
845 * window.c (decode_window, decode_any_window): Move up in code.
846 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
847 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
848 (Fwindow_buffer): Move up and rewrite doc-string.
849 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
850 (Fwindow_prev): New functions.
727e958e
MR
851 (Fwindow_frame): Move here from frame.c. Accept any window as
852 argument.
853 (Fframe_root_window, Fframe_first_window)
854 (Fframe_selected_window): Move here from frame.c. Accept frame
855 or arbitrary window as argument. Update doc-strings.
856 (Fminibuffer_window): Move up in code.
857 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
858 (Fset_frame_selected_window): Move here from frame.c.
859 Marginal rewrite.
727e958e
MR
860 (Fselected_window, select_window, Fselect_window): Move up in
861 code. Minor doc-string fixes.
f230ecc9 862
4d09bcf6
PE
8632011-06-06 Paul Eggert <eggert@cs.ucla.edu>
864
865 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
866 Do not assume that spare memory exists; that assumption is valid
867 only if SYSTEM_MALLOC.
868 (LARGE_REQUEST): New macro, so that the issue of large requests
869 is separated from the issue of spare memory.
870
810928a2
AS
8712011-06-05 Andreas Schwab <schwab@linux-m68k.org>
872
172418ad
AS
873 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
874 format. (Bug#8806)
875
43f862f7
AS
876 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
877
810928a2
AS
878 * xfns.c (x_set_scroll_bar_default_width): Move declarations
879 before statements.
880
a059fe24
JD
8812011-06-05 Jan Djärv <jan.h.d@swipnet.se>
882
883 * gtkutil.c (xg_get_default_scrollbar_width): New function.
884
885 * gtkutil.h: Declare xg_get_default_scrollbar_width.
886
887 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
888 min width by calling x_set_scroll_bar_default_width (Bug#8505).
889
989bf368
JB
8902011-06-05 Juanma Barranquero <lekktu@gmail.com>
891
892 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
893
4b80f674
CY
8942011-06-04 Chong Yidong <cyd@stupidchicken.com>
895
896 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
897 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
898 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
899 New error handlers.
4b80f674
CY
900 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
901 Obey Vx_select_enable_clipboard_manager. Catch errors in
902 x_clipboard_manager_save (Bug#8779).
903 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 904 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 905
99a33b77 9062011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
907
908 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
909
99a33b77 9102011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
911
912 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
913 in the current matrix if keep_current_p is non-zero.
914
8264569d
EZ
9152011-06-04 Eli Zaretskii <eliz@gnu.org>
916
917 * bidi.c (bidi_level_of_next_char): Fix last change.
918
57f97249
EZ
9192011-06-03 Eli Zaretskii <eliz@gnu.org>
920
fec2107c 921 Support bidi reordering of text covered by display properties.
57f97249 922
fec2107c
EZ
923 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
924 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
925 (bidi_cache_search, bidi_cache_iterator_state)
926 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
927 (bidi_level_of_next_char, bidi_move_to_visually_next):
928 Support character positions inside a run of characters covered by a
fec2107c
EZ
929 display string.
930 (bidi_paragraph_init, bidi_resolve_explicit_1)
931 (bidi_level_of_next_char): Call bidi_fetch_char and
932 bidi_fetch_char_advance instead of FETCH_CHAR and
933 FETCH_CHAR_ADVANCE.
934 (bidi_init_it): Initialize new members.
935 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
936 definitions.
937 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
938 instead of using explicit *_CHAR codes.
d6d100dd
SM
939 (bidi_resolve_explicit, bidi_resolve_weak):
940 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
941 bidirectional text is supported only in multibyte buffers.
942 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
943 it to initialize the frame_window_p member of struct bidi_it.
944 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
945 (bidi_resolve_explicit, bidi_resolve_weak)
946 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
947 bidi_it->nchars is non-positive.
948 (bidi_level_of_next_char): Don't try to lookup the cache for the
949 next/previous character if nothing is cached there yet, or if we
950 were just reseat()'ed to a new position.
c40e2fb2 951
0e14fe90
EZ
952 * xdisp.c (set_cursor_from_row): Set start and stop points
953 according to the row's direction when priming the loop that looks
954 for the glyph on which to display cursor.
955 (single_display_spec_intangible_p): Function deleted.
956 (display_prop_intangible_p): Reimplement to call
957 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
958 Accept 3 additional arguments needed by handle_display_spec.
959 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
960 values: lists, `(when COND...)' forms, etc.
961 (single_display_spec_string_p): Support property values that are
962 lists with the argument STRING its top-level element.
963 (display_prop_string_p): Fix the condition for processing a
964 property that is a list to be consistent with handle_display_spec.
fec2107c 965 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
966 last portion of handle_display_prop.
967 (compute_display_string_pos): Accept additional argument
968 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
969 value of a `display' property is a "replacing spec".
970 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
971 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
972 the display property, but just return a value indicating whether
973 the display property will replace the characters it covers.
974 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
975 frame_window_p members of struct bidi_it.
d6d100dd
SM
976 (compute_display_string_pos, compute_display_string_end):
977 New functions.
fec2107c
EZ
978 (push_it): Accept second argument POSITION, where pop_it should
979 jump to continue iteration.
980 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 981
fec2107c
EZ
982 * keyboard.c (adjust_point_for_property): Adjust the call to
983 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
984
985 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
986 (bidi_init_it): Update prototypes.
987 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
988 (compute_display_string_pos, compute_display_string_end):
989 Declare prototypes.
fec2107c
EZ
990 (struct bidi_it): New members nchars and disp_pos. ch_len is now
991 EMACS_INT.
fc6f18ce 992
40087514 9932011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 994
57f53182
PE
995 Malloc failure behavior now depends on size of allocation.
996 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
997 * lisp.h: Change signatures accordingly.
998 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
999 All callers changed. (Bug#8762)
1000
1001 * gnutls.c: Use Emacs's memory allocators.
1002 Without this change, the gnutls library would invoke malloc etc.
1003 directly, which causes problems on non-SYNC_INPUT hosts, and which
1004 runs afoul of improving memory_full behavior. (Bug#8761)
1005 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1006 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1007 xfree instead of the default malloc, realloc, free.
1008 (Fgnutls_boot): No need to check for memory allocation failure,
1009 since xmalloc does that for us.
1010
ac32cd99 1011 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
1012 * category.c (hash_get_category_set):
1013 * ccl.c (ccl_driver):
1014 * charset.c (Fdefine_charset_internal):
1015 * charset.h (struct charset.hash_index):
1016 * composite.c (get_composition_id, gstring_lookup_cache)
1017 (composition_gstring_put_cache):
1018 * composite.h (struct composition.hash_index):
1019 * dispextern.h (struct image.hash):
1020 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1021 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1022 (hashfn_equal, hashfn_user_defined, make_hash_table)
1023 (maybe_resize_hash_table, hash_lookup, hash_put)
1024 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1025 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1026 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1027 * image.c (make_image, search_image_cache, lookup_image)
1028 (xpm_put_color_table_h):
1029 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 1030 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
1031 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1032 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
1033 * alloc.c (allocate_vectorlike):
1034 Check for overflow in vector size calculations.
1035 * ccl.c (ccl_driver):
1036 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
1037 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1038 need to be updated by these changes.
40087514
PE
1039 * fns.c (make_hash_table, maybe_resize_hash_table):
1040 Check for integer overflow with large hash tables.
0de4bb68
PE
1041 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1042 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1043 (SXHASH_REDUCE): New macro.
1044 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1045 Use it instead of discarding useful hash info with large hash values.
1046 (sxhash_float): New function.
1047 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1048 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
1049 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1050 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
1051 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1052 Adjust signatures to match updated version of code.
1053 (consing_since_gc): Now EMACS_INT, since a single hash table can
1054 use more than INT_MAX bytes.
1055
698d32e2
DN
10562011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1057
1058 Make it possible to build with GCC-4.6+ -O2 -flto.
1059
1060 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1061
fd6fa53f
SM
10622011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1063
1064 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1065 Call minibuffer-inactive-mode.
1066
864db017
JB
10672011-05-31 Juanma Barranquero <lekktu@gmail.com>
1068
1069 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1070 Update dependencies.
1071
2ad0baf4
DN
10722011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1073
1074 * data.c (init_data): Remove code for UTS, this system is not
1075 supported anymore.
1076
4fcc2638
DN
10772011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1078
1079 Don't force ./temacs to start in terminal mode.
1080
1081 * frame.c (make_initial_frame): Initialize faces in all cases, not
1082 only when CANNOT_DUMP is defined.
1083 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1084
c56e0fd5
DN
10852011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1086
1087 * dispnew.c (add_window_display_history): Use const for the string
1088 pointer. Remove declaration, not needed.
1089
333d54da 10902011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 1091
55d4c1b2 1092 Use 'inline', not 'INLINE'.
333d54da 1093 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
1094 * alloc.c, fontset.c (INLINE): Remove.
1095 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1096 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1097 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1098 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1099 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1100
738db178
DN
11012011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1102
1103 Make it possible to run ./temacs.
1104
1105 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1106 syms_of_callproc does the same thing. Remove test for
1107 "initialized", do it in the caller.
1108 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1109
620c53a6
SM
11102011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1111
1112 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1113 (read_minibuf): Use get_minibuffer.
1114 (syms_of_minibuf): Use DEFSYM.
1115 (Qmetadata): New var.
1116 * data.c (Qbuffer): Don't make it static.
1117 (syms_of_data): Use DEFSYM.
1118
e003a292
PE
11192011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1120
1121 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1122 (CCL_CODE_MIN): New macro.
1123
ed008a6d
PE
11242011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1125
3687c2ef
PE
1126 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1127
ed008a6d
PE
1128 * eval.c (Qdebug): Now static.
1129 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1130 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1131 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1132
d66c4c7c
CY
11332011-05-29 Chong Yidong <cyd@stupidchicken.com>
1134
1135 * image.c: Various fixes to ImageMagick code comments.
1136 (Fimagemagick_types): Doc fix.
1137
5fbc2025
PE
11382011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1139
0196f88a
PE
1140 Minor fixes prompted by GCC 4.6.0 warnings.
1141
1142 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1143
5fbc2025
PE
1144 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1145 (x_clipboard_manager_save_all): Move extern decl to ...
1146 * xterm.h: ... here, so that it can be checked for consistency.
1147
1dd3c2d9
CY
11482011-05-29 Chong Yidong <cyd@stupidchicken.com>
1149
1150 * xselect.c (x_clipboard_manager_save_frame)
1151 (x_clipboard_manager_save_all): New functions.
1152 (Fx_clipboard_manager_save): Lisp function deleted.
1153
1154 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1155 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1156
1157 * xterm.h: Update prototype.
1158
5ba6571d
WX
11592011-05-28 William Xu <william.xwl@gmail.com>
1160
1161 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1162 exiting (Bug#8239).
1163
3eaff834
JM
11642011-05-28 Jim Meyering <meyering@redhat.com>
1165
e1900994 1166 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
1167 * fns.c (to_uchar): Define.
1168 (crypto_hash_function): Use it to convert some newly-signed
1169 variables to unsigned, to avoid sign-extension bugs. For example,
1170 without this change, (md5 "truc") would evaluate to
1171 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1172 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 1173 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 1174
0f6990a7
PE
11752011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1176
1177 Integer overflow fixes.
c8a9ca5a 1178
08686060
PE
1179 * dbusbind.c: Serial number integer overflow fixes.
1180 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
1181 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1182 to hold a serial number that is too large for a fixnum.
1183 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1184 Check for serial numbers out of range. Decode any serial number
59568bf0 1185 that was so large that it became a float. (Bug#8722)
08686060 1186
2d1fc3c7
PE
1187 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1188 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1189 Use XFASTINT rather than XUINT when numbers are nonnegative.
1190 (xd_append_arg, Fdbus_method_return_internal):
1191 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1192 arguments, check that Lisp number is nonnegative, rather than
59568bf0 1193 silently wrapping negative numbers around. (Bug#8722)
30217ff0 1194 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 1195 (Bug#8722)
2d1fc3c7 1196
c8a9ca5a
PE
1197 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1198
519e1d69
PE
1199 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1200
30569699
PE
1201 ccl: add integer overflow checks
1202 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1203 (IN_INT_RANGE): New macros.
1204 (ccl_driver): Use them to check for integer overflow when
1205 decoding a CCL program. Many of the new checks are whether XINT (x)
1206 fits in int; it doesn't always, on 64-bit hosts. The new version
1207 doesn't catch all possible integer overflows, but it's an
847044ea 1208 improvement. (Bug#8719)
30569699 1209
c11285dc
PE
1210 * alloc.c (make_event_array): Use XINT, not XUINT.
1211 There's no need for unsigned here.
1212
fdccd48e
PE
1213 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1214 This follows up to the 2011-05-06 change that substituted uintptr_t
1215 for EMACS_INT. This case wasn't caught back then.
1216
37910ab2
PE
1217 Rework Fformat to avoid integer overflow issues.
1218 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1219 now (part of C89). Include <verify.h>.
1220 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1221 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1222 (Fformat): Avoid the prepass trying to compute sizes; it was only
1223 approximate and thus did not catch overflow reliably. Instead, walk
1224 through the format just once, formatting and computing sizes as we go,
1225 checking for integer overflow at every step, and allocating a larger
1226 buffer as needed. Keep track separately whether the format is
1227 multibyte. Keep only the most-recently calculated precision, rather
1228 than them all. Record whether each argument has been converted to
1229 string. Use EMACS_INT, not int, for byte and char and arg counts.
1230 Support field widths and precisions larger than INT_MAX. Avoid
1231 sprintf's undefined behavior with conversion specifications such as %#d
1232 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1233 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1234 formatting out-of-range floating point numbers with int
1235 formats. (Bug#8668)
1236
2e6578fb
PE
1237 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1238
0ae6bdee
PE
1239 * data.c: Avoid integer truncation in expressions involving floats.
1240 * data.c: Include <intprops.h>.
1241 (arith_driver): When there's an integer overflow in an expression
1242 involving floating point, convert the integers to floating point
1243 so that the resulting value does not suffer from catastrophic
1244 integer truncation. For example, on a 64-bit host (* 4
1245 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1246 Do not rely on undefined behavior after integer overflow.
1247
de883a70
PE
1248 merge count_size_as_multibyte, parse_str_to_multibyte
1249 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 1250 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
1251 Check for integer overflow.
1252 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1253 since it's now a duplicate of the other. This is more of
1254 a character than a buffer op, so better that it's in character.c.
1255 * fns.c, print.c: Adjust to above changes.
1256
2ff916cb
PE
12572011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1258
1259 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1260
f1b54466
PE
12612011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1262
fb1ac845
PE
1263 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1264 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1265 (x_clipboard_manager_save): Now static.
1266 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1267
f1b54466
PE
1268 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1269 (crypto_hash_function): Now static.
1270 Fix pointer signedness problems. Avoid unnecessary initializations.
1271
a9f737ee
CY
12722011-05-27 Chong Yidong <cyd@stupidchicken.com>
1273
1274 * termhooks.h (Vselection_alist): Make it terminal-local.
1275
1276 * terminal.c (create_terminal): Initialize it.
1277
1278 * xselect.c: Support for clipboard managers.
1279 (Vselection_alist): Move to termhooks.h as terminal-local var.
1280 (LOCAL_SELECTION): New macro.
1281 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1282 (symbol_to_x_atom): Remove gratuitous arg.
1283 (x_handle_selection_request, lisp_data_to_selection_data)
1284 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
1285 (x_own_selection, x_get_local_selection, x_convert_selection):
1286 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
1287 (some_frame_on_display): Delete unused function.
1288 (Fx_own_selection_internal, Fx_get_selection_internal)
1289 (Fx_disown_selection_internal, Fx_selection_owner_p)
1290 (Fx_selection_exists_p): New optional frame arg.
1291 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1292 (x_handle_selection_clear): Don't treat other terminals with the
1293 same keyboard specially. Use the terminal-local Vselection_alist.
1294 (x_clear_frame_selections): Use Frun_hook_with_args.
1295
1296 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1297
1298 * xterm.h: Add support for those atoms.
1299
e067f0c1
CY
13002011-05-26 Chong Yidong <cyd@stupidchicken.com>
1301
1302 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1303 (converted_selections, conversion_fail_tag): New global variables.
1304 (x_selection_request_lisp_error): Free the above.
1305 (x_get_local_selection): Remove unnecessary code.
1306 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
1307 of converted selections stored in converted_selections.
1308 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
1309 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1310 (x_convert_selection): New function.
1311 (x_handle_selection_event): Simplify.
1312 (x_get_foreign_selection): Don't ignore incoming requests while
1313 waiting for an answer; this will fail when we implement
1314 SAVE_TARGETS, and seems unnecessary anyway.
1315 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1316 (Vx_sent_selection_functions): Doc fix.
1317
0f4aebc0
LL
13182011-05-26 Leo Liu <sdl.web@gmail.com>
1319
1320 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1321
e61124cd
YM
13222011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1323
1324 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1325
1326 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1327 for fringe update if it has periodic bitmap.
1328 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1329 and fringe_bitmap_periodic_p.
1330
1331 * fringe.c (get_fringe_bitmap_data): New function.
1332 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1333 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1334 row. Mark glyph row for fringe update if periodicity changed.
1335
1336 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1337 for fringe update unless it has periodic bitmap.
1338
f16d9837
KH
13392011-05-25 Kenichi Handa <handa@m17n.org>
1340
1341 * xdisp.c (get_next_display_element): Set correct it->face_id for
1342 a static composition.
1343
e1b90ef6
LL
13442011-05-24 Leo Liu <sdl.web@gmail.com>
1345
1346 * deps.mk (fns.o):
1347 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1348
1349 * fns.c (crypto_hash_function, Fsha1): New function.
1350 (Fmd5): Use crypto_hash_function.
1351 (syms_of_fns): Add Ssha1.
1352
7400048f
PE
13532011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1354
1355 * gnutls.c: Remove unused macros.
1356 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1357 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1358 Remove macros that are defined and never used.
1359 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1360
abb71cf4
CY
13612011-05-22 Chong Yidong <cyd@stupidchicken.com>
1362
1363 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1364 (Fx_get_selection_internal): Minor cleanup.
1365 (Fx_own_selection_internal): Rename arguments for consistency with
1366 select.el.
1367
6307db39
PE
13682011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1369
1370 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1371
f3d4e0a4
CY
13722011-05-22 Chong Yidong <cyd@stupidchicken.com>
1373
1374 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1375
4d8ade89
YM
13762011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1377
1378 * dispnew.c (scrolling_window): Don't exclude the case that the
1379 last enabled row in the desired matrix touches the bottom boundary.
1380
32078c8d
GM
13812011-05-21 Glenn Morris <rgm@gnu.org>
1382
1383 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
1384 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1385 and add some more files.
32078c8d 1386
7285dc67
EZ
13872011-05-20 Eli Zaretskii <eliz@gnu.org>
1388
1389 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1390 report_file_error introduced by the change from 2011-05-07.
1391
89d1bd22
PE
13922011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1393
1394 * systime.h (Time): Define only if emacs is defined.
1395 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1396 where the include path doesn't have X11/X.h by default. See
1397 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1398
e23640bb 13992011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
1400
1401 * composite.c (find_automatic_composition): Fix previous change.
1402
b9704ad9
GM
14032011-05-20 Glenn Morris <rgm@gnu.org>
1404
1405 * lisp.mk: New file, split from Makefile.in.
1406 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1407 (shortlisp): Remove.
1408 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1409
4a720484
GM
14102011-05-19 Glenn Morris <rgm@gnu.org>
1411
1412 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1413 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1414 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1415 (lisp): Set the order to that of loadup.el.
1416 (shortlisp): Make it a copy of $lisp.
1417 (SOME_MACHINE_LISP): Remove.
1418 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1419 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1420
a28d4396
KH
14212011-05-18 Kenichi Handa <handa@m17n.org>
1422
1423 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1424 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1425 (find_automatic_composition): Mostly rewrite for efficiency.
1426
a2b1fa8e
JB
14272011-05-18 Juanma Barranquero <lekktu@gmail.com>
1428
1429 * makefile.w32-in: Update dependencies.
1430
8e1f5610
CS
14312011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1432
1433 * menu.c: Include limits.h (fixes the MS-Windows build broken by
fadf4e30 1434 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 1435
7025ee00 14362011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 1437
cdfa6eab
PE
1438 Fix some integer overflow issues, such as string length overflow.
1439
06d6db33
PE
1440 * insdel.c (count_size_as_multibyte): Check for string overflow.
1441
2b4560a8
PE
1442 * character.c (lisp_string_width): Check for string overflow.
1443 Use EMACS_INT, not int, for string indexes and lengths; in
1444 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1445 the resulting string length overflows an EMACS_INT; instead,
1446 report a string overflow if no precision given. When checking for
1447 precision exhaustion, use a check that cannot possibly have
1448 integer overflow. (Bug#8675)
1449 * character.h (lisp_string_width): Adjust to new signature.
1450
cb93f9be
PE
1451 * alloc.c (string_overflow): New function.
1452 (Fmake_string): Use it. This doesn't change behavior, but saves
1453 a few bytes and will simplify future changes.
1454 * character.c (string_escape_byte8): Likewise.
1455 * lisp.h (string_overflow): New decl.
1456
1a1f3366
PE
1457 Fixups, following up to the user-interface timestamp change.
1458 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1459 for UI timestamps, instead of unsigned long.
9fbd6841
PE
1460 * msdos.c (mouse_get_pos): Likewise.
1461 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
1462 * w32gui.h (Time): Define by including "systime.h" rather than by
1463 declaring it ourselves. (Bug#8664)
1464
d4e3e4d3
PE
1465 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1466 * image.c (clear_image_cache): Likewise.
1467
f6a24d19
PE
1468 * term.c (term_mouse_position): Don't assume time_t wraparound.
1469
08dc5ae6
PE
1470 Be more systematic about user-interface timestamps.
1471 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
1472 and sometimes 'EMACS_UINT', to represent these timestamps.
1473 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
1474 This makes the code easier to follow, and makes it easier to catch
1475 integer overflow bugs such as Bug#8664.
1476 * frame.c (Fmouse_position, Fmouse_pixel_position):
1477 Use Time, not unsigned long, for user-interface timestamps.
1478 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1479 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1480 * keyboard.h (last_event_timestamp): Likewise.
1481 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1482 * menu.h (xmenu_show): Likewise.
1483 * term.c (term_mouse_position): Likewise.
1484 * termhooks.h (struct input_event.timestamp): Likewise.
1485 (struct terminal.mouse_position_hook): Likewise.
1486 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1487 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1488 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1489 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1490 what it was before.
1491 * menu.h, termhooks.h: Include "systime.h", for Time.
1492
8e55734a
PE
1493 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1494 Don't assume that the difference between two unsigned long values
1495 can fit into an integer. At this point, we know button_down_time
1496 <= event->timestamp, so the difference must be nonnegative, so
1497 there's no need to cast the result if double-click-time is
1498 nonnegative, as it should be; check that it's nonnegative, just in
1499 case. This bug is triggered when events are more than 2**31 ms
86db42d2 1500 apart (about 25 days). (Bug#8664)
8e55734a 1501
841f1b75 1502 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 1503 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 1504
3e26f69c
PE
1505 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1506 that always fit in int. Use a sentinel instead of a counter, to
1507 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
1508 * frame.h (struct frame): Use int for menu_bar_items_used
1509 instead of EMACS_INT, since it always fits in int.
3e26f69c 1510
5cc152c0
PE
1511 * menu.c (grow_menu_items): Check for int overflow.
1512
d89eb65e
PE
1513 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1514
5235bd3e
PE
1515 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1516 Before, the code was not consistent. These values cannot exceed
1517 2**31 - 1 so there's no need to make them unsigned.
1518 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1519 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1520 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1521 as modifiers.
1522 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1523
bc827e23
PE
1524 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1525 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1526 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1527 presumably because the widths might not match.
1528
78eb494e
PE
1529 * window.c (size_window): Avoid needless test at loop start.
1530
04f2d78b
CB
15312011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1532
1533 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1534
d2fc7e3d 15352011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
1536
1537 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1538
d2fc7e3d 15392011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
1540
1541 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1542 `width' to `bar_area_x' and `bar_area_width', respectively.
1543 (x_scroll_run): Take account of fringe background extension.
1544
04f2d78b
CB
1545 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1546 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
1547 `bar_area_width', respectively.
1548 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1549 background extension.
1550
79b70037
GM
15512011-05-10 Jim Meyering <meyering@redhat.com>
1552
1553 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1554
2f142cc5
JB
15552011-05-10 Juanma Barranquero <lekktu@gmail.com>
1556
1557 * image.c (Finit_image_library): Return t for built-in image types,
1558 like pbm and xbm. (Bug#8640)
1559
57679c86
AS
15602011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1561
1562 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1563
888c9e86
EZ
15642011-05-07 Eli Zaretskii <eliz@gnu.org>
1565
b0512a1d
EZ
1566 * w32console.c (Fset_screen_color): Doc fix.
1567 (Fget_screen_color): New function.
1568 (syms_of_ntterm): Defsubr it.
1569
7285dc67
EZ
1570 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1571 unlink the temporary file if Fcall_process didn't create it in the
1572 first place.
1573 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1574 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
1575 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1576 cue to call_process_cleanup not to close that handle.
1577
4d3fcc8e
BK
15782011-05-07 Ben Key <bkey76@gmail.com>
1579
1580 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1581 one of two shell specific rules, either bootstrap-temacs-CMD or
1582 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1583 to the previous implementation of the bootstrap-temacs rule.
1584 The bootstrap-temacs-CMD rule is similar to the previous
1585 implementation of the bootstrap-temacs rule except that it
1586 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1587 variable.
1588
1589 These changes, along with some changes to nt/configure.bat,
1590 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1591 earlier fix to add support for --cflags and --ldflags options
1592 that include quotes so that it works whether make uses cmd or
1593 sh as the shell.
1594
b4289b64
MA
15952011-05-06 Michael Albinus <michael.albinus@gmx.de>
1596
1597 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1598 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1599 is a constant.
1600 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1601 a string. Handle both cases.
1602 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1603 (Fdbus_register_method): Use Qinvalid_function.
1604
af4c0e28
JB
16052011-05-06 Juanma Barranquero <lekktu@gmail.com>
1606
1607 * makefile.w32-in: Update dependencies.
1608 (LISP_H): Add inttypes.h and stdin.h.
1609 (PROCESS_H): Add unistd.h.
1610
c51453d9
EZ
16112011-05-06 Eli Zaretskii <eliz@gnu.org>
1612
1613 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1614 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1615
8ff0ac3c 16162011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 1617
4c4b566b
PE
1618 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1619
aab2b9b5
PE
1620 * term.c (vfatal): Remove stray call to va_end.
1621 It's not needed and the C Standard doesn't allow it here anyway.
1622
c378da0b
PE
1623 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1624 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1625
288b08c7
PE
1626 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1627 bytes.
1628
e3601888
PE
1629 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1630
db6c0e74
PE
1631 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1632
dd5963ea
PE
1633 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1634
88c9450f
PE
1635 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1636
2f9442b8
PE
1637 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1638
c032b5f8
PE
1639 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1640 * charset.c (Fdefine_charset_internal): Don't initialize
1641 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 1642 32-bit int (Bug#8600).
a108c10b
PE
1643
1644 * lread.c (read_integer): Be more consistent with string-to-number.
1645 Use string_to_number to do the actual conversion; this avoids
1646 rounding errors and fixes some other screwups. Without this fix,
1647 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1648 (digit_to_number): Move earlier, for benefit of read_integer.
1649 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 1650 not a digit in any supported base. (Bug#8602)
a108c10b 1651
ad5f9eea
PE
1652 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1653
aec1708a
PE
1654 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1655 to match comment at start of function. This also removes a
1656 GCC warning about overflow in a 32+64-bit port.
1657
47be4ab5
PE
1658 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1659
371cac43
PE
1660 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1661 Reported by Stefan Monnier in
1662 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
1663 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1664 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 1665
d01a7826
PE
1666 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1667 (EMACS_UINTPTR): Likewise, with uintptr_t.
1668
7fd47d5c
PE
1669 * lisp.h: Prefer 64-bit EMACS_INT if available.
1670 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1671 on 32-bit hosts that have 64-bit int, so that they can access
1672 large files.
122b0c86
PE
1673 However, temporarily disable this change unless the temporary
1674 symbol WIDE_EMACS_INT is defined.
7fd47d5c 1675
8727937b
PE
1676 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1677
8ac068ac
PE
1678 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1679 This removes an assumption that EMACS_INT and long are the same
1680 width as pointers. The assumption is true for Emacs porting targets
1681 now, but we want to make other targets possible.
1682 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1683 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1684 In the rest of the code, change types of integers that hold casted
1685 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1686 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1687 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1688 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1689 No need to cast type when ORing.
1690 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1691 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1692 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1693 assume EMACS_INT is the same width as char *.
1694 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1695 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1696 Remove no-longer-needed casts.
1697 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1698 (xg_tool_bar_help_callback, xg_make_tool_item):
1699 Use EMACS_INTPTR to hold an integer
1700 that will be cast to void *; this can avoid a GCC warning
1701 if EMACS_INT is not the same width as void *.
1702 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1703 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1704 (current_message_1, set_message_1):
1705 Use a local to convert to proper width without a cast.
1706 * xmenu.c (dialog_selection_callback): Likewise.
1707
ede49d71
PE
1708 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1709 Also, don't assume VALBITS / RAND_BITS is less than 5,
1710 and don't rely on undefined behavior when shifting a 1 left into
1711 the sign bit.
1712 * lisp.h (get_random): Change signature to match.
1713
2f30ecd0
PE
1714 * lread.c (hash_string): Use size_t, not int, for hash computation.
1715 Normally we prefer signed values; but hashing is special, because
1716 it's better to use unsigned division on hash table sizes so that
1717 the remainder is nonnegative. Also, size_t is the natural width
1718 for hashing into memory. The previous code used 'int', which doesn't
1719 retain enough info to hash well into very large tables.
1720 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1721
2a866e7b
PE
1722 * dbusbind.c: Don't possibly lose pointer info when converting.
1723 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1724 Use XPNTR rather than XHASH, so that the high-order bits of
1725 the pointer aren't lost when converting through void *.
1726
51639eac
PE
1727 * eval.c (Fautoload): Don't double-shift a pointer.
1728
92394119
PE
1729 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1730
dbdb9a7c
JB
17312011-05-06 Juanma Barranquero <lekktu@gmail.com>
1732
1733 * gnutls.c (DEF_GNUTLS_FN):
1734 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1735
db7a0b4f
AS
17362011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1737
1738 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1739 marker. (Bug#8610)
1740
f7ff1b0f 17412011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
1742
1743 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1744 New version that can reserve upto 2GB of heap space.
1745
f7ff1b0f 17462011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
1747
1748 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1749
639c109b
TZ
17502011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1751
1752 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1753 `gnutls_certificate_set_x509_key_file'.
1754
d2127135
JB
17552011-05-05 Juanma Barranquero <lekktu@gmail.com>
1756
1757 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1758 Update dependencies.
1759
e968f4f3
JB
17602011-05-04 Juanma Barranquero <lekktu@gmail.com>
1761
1762 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1763 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1764 Remove unused parameter `fildes'.
1765 * process.c (read_process_output, send_process): Don't pass it.
1766
84d358f0
JB
17672011-05-04 Juanma Barranquero <lekktu@gmail.com>
1768
1769 Fix previous change: the library cache is defined in w32.c.
1770 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1771 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1772
0898ca10
JB
17732011-05-04 Juanma Barranquero <lekktu@gmail.com>
1774
1775 Implement dynamic loading of GnuTLS on Windows.
1776
1777 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1778 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1779 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1780 Declare.
1781
1782 * gnutls.c (Qgnutls_dll): Define.
1783 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1784 (gnutls_*): Declare function pointers.
1785 (init_gnutls_functions): New function to initialize function pointers.
1786 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1787 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1788 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1789 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1790 (emacs_gnutls_write, emacs_gnutls_read)
1791 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1792 (Fgnutls_available_p): New function.
1793 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1794 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1795 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1796
1797 * image.c: Include w32.h.
1798 (Vimage_type_cache): Delete.
1799 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1800 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1801 (w32_delayed_load): Move to w32.c.
1802
1803 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1804
1805 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1806 (w32_delayed_load): Move from image.c. When loading a library, record
1807 its filename in the :loaded-from property of the library id.
1808 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1809 Initialize and staticpro them.
1810 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1811
1812 * process.c: Include lisp.h before w32.h, not after.
1813 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1814 instead of gnutls_record_check_pending.
1815
1816 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1817
ff4de4aa
TZ
18182011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1819
1820 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1821 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1822 as passed in.
1823
abe95abb
JD
18242011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1825
1826 * xterm.c (x_set_frame_alpha): Do not set property on anything
1827 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1828
e16e55d4
JB
18292011-05-02 Juanma Barranquero <lekktu@gmail.com>
1830
1831 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1832
bafcf6a5
JB
18332011-05-02 Juanma Barranquero <lekktu@gmail.com>
1834
1835 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1836 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1837 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1838 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1839 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1840 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1841 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1842 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1843 (Qgnutls_bootprop_callbacks_verify): Make static.
1844
e7a6747f
AS
18452011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1846
19ed11ba
AS
1847 * callproc.c: Indentation fixup.
1848
e7a6747f 1849 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
1850 (wait_for_termination, interruptible_wait_for_termination):
1851 Move after wait_for_termination_1.
e7a6747f 1852
1ef14cb4
LMI
18532011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1854
1855 * sysdep.c (interruptible_wait_for_termination): New function
1856 which is like wait_for_termination, but allows keyboard
1857 interruptions.
1858
1859 * callproc.c (Fcall_process): Add (:file "file") as an option for
1860 the STDOUT buffer.
1861 (Fcall_process_region): Ditto.
1862
330d880c
EZ
18632011-04-30 Eli Zaretskii <eliz@gnu.org>
1864
8db90b73
EZ
1865 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1866 rather than `XVECTOR (FOO)->size'.
1867
330d880c
EZ
1868 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1869 inttypes.h, as a gnulib replacement is used if it not available in
1870 system headers.
1871
15cbd324
EZ
18722011-04-21 Eli Zaretskii <eliz@gnu.org>
1873
1874 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1875 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1876 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1877
1878 * coding.c (coding_alloc_by_realloc): Error out if destination
1879 will grow beyond MOST_POSITIVE_FIXNUM.
1880 (decode_coding_emacs_mule): Abort if there isn't enough place in
1881 charbuf for the composition carryover bytes. Reserve an extra
1882 space for up to 2 characters produced in a loop.
1883 (decode_coding_iso_2022): Abort if there isn't enough place in
1884 charbuf for the composition carryover bytes.
1885
18862011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 1887
ae940cca
EZ
1888 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1889 aborting when %lld or %lll format is passed.
1890 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1891 %llo or %llx format is passed. (Bug#8545)
1892
03ab8921
EZ
1893 * window.c (window_scroll_line_based): Use a marker instead of
1894 simple variables to record original value of point. (Bug#7952)
1895
afda1437
EZ
1896 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1897 produced by %s or %c overflows available buffer space. (Bug#8545)
1898
f76dee0c
PE
18992011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1900
1901 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 1902 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 1903
fdc5744d
JB
19042011-04-28 Juanma Barranquero <lekktu@gmail.com>
1905
1906 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1907
638f053a
JB
19082011-04-28 Juanma Barranquero <lekktu@gmail.com>
1909
1910 * keyboard.c (Qdelayed_warnings_hook): Define.
1911 (command_loop_1): Run `delayed-warnings-hook'
1912 if Vdelayed_warnings_list is non-nil.
1913 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1914 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1915
d178f871
EZ
19162011-04-28 Eli Zaretskii <eliz@gnu.org>
1917
1918 * doprnt.c (doprnt): Don't return value smaller than the buffer
1919 size if the message was truncated. (Bug#8545).
1920
b124fd93
JB
19212011-04-28 Juanma Barranquero <lekktu@gmail.com>
1922
1923 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1924 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1925
e810457d
PE
19262011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1927
1928 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1929
ea51cceb
JB
19302011-04-27 Juanma Barranquero <lekktu@gmail.com>
1931
1932 * makefile.w32-in: Update dependencies.
1933
94dcfacf
EZ
19342011-04-27 Eli Zaretskii <eliz@gnu.org>
1935
1936 Improve `doprnt' and its usage. (Bug#8545)
1937 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1938 `format_end'. Remove support for %l as a conversion specifier.
1939 Don't use xrealloc. Improve diagnostics when the %l size modifier
1940 is used. Update the commentary.
1941
1942 * eval.c (verror): Simplify calculation of size_t.
1943
1944 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1945 messages.
1946
f61f41d7
PE
19472011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1948
1949 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1950 change.
1951
96fb4434
PE
19522011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1953
1954 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1955 This makes this file independent of the recent pseudovector change.
1956
671875da 19572011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 1958
69e9b5a3
PE
1959 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1960
b5f869a7 1961 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 1962 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 1963 Remove unused local.
c8926152 1964 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 1965
841a1577 1966 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
1967 GCC 4.6.0 optimizes based on type-based alias analysis.
1968 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
1969 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1970 != &v->size, and therefore "v->size = 1; b->size = 2; return
1971 v->size;" must therefore return 1. This assumption is incorrect
1972 for Emacs, since it type-puns struct Lisp_Vector * with many other
1973 types. To fix this problem, this patch adds a new type struct
f904488f 1974 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
1975 and pseudovectors, and helps optimizing compilers not get fooled
1976 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1977 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
1978 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1979 the size member.
eab3844f
PE
1980 (XSETPVECTYPE): Rewrite in terms of new macro.
1981 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1982 This is a bit clearer, and further avoids the possibility of
1983 undesirable aliasing.
1984 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 1985 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
1986 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1987 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
1988 (ASIZE): Now uses header.size rather than size.
1989 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
1990 to avoid the hassle of writing XVECTOR (foo)->header.size.
1991 (struct vectorlike_header): New type.
eab3844f
PE
1992 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1993 object, to help avoid aliasing.
1994 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1995 (SUBRP): Likewise, since Lisp_Subr is a special case.
1996 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1997 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1998 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 1999 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
2000 changed to be "header.size" and "header.next".
2001 * buffer.h (struct buffer): Likewise.
2002 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2003 * frame.h (struct frame): Likewise.
2004 * process.h (struct Lisp_Process): Likewise.
2005 * termhooks.h (struct terminal): Likewise.
2006 * window.c (struct save_window_data, struct saved_window): Likewise.
2007 * window.h (struct window): Likewise.
2008 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2009 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2010 * buffer.c (init_buffer_once): Likewise.
2011 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2012 special case.
2013 * process.c (Fformat_network_address): Use local var for size,
2014 for brevity.
2015
0df1eac5
PE
2016 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2017
847ab9d1 2018 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
2019 * data.c (atof): Remove decl; no longer used or needed.
2020 (digit_to_number): Move to lread.c.
2021 (Fstring_to_number): Use new string_to_number function, to be
2022 consistent with how the Lisp reader treats infinities and NaNs.
2023 Do not assume that floating-point numbers represent EMACS_INT
2024 without losing information; this is not true on most 64-bit hosts.
2025 Avoid double-rounding errors, by insisting on integers when
2026 parsing non-base-10 numbers, as the documentation specifies.
2027 * lisp.h (string_to_number): New decl, replacing ...
2028 (isfloat_string): Remove.
bc0a5c13 2029 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 2030 (read1): Do not accept +. and -. as integers; this
452f4150
PE
2031 appears to have been a coding error. Similarly, do not accept
2032 strings like +-1e0 as floating point numbers. Do not report
2033 overflow for integer overflows unless the base is not 10 which
2034 means we have no simple and reliable way to continue.
2035 Break out the floating-point parsing into a new
2036 function string_to_number, so that Fstring_to_number parses
2037 floating point numbers consistently with the Lisp reader.
04f2d78b 2038 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
2039 (E_CHAR, EXP_INT): Remove, replacing with ...
2040 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2041 (string_to_number): New function, replacing isfloat_string.
2042 This function checks for valid syntax and produces the resulting
2043 Lisp float number too. Rework it so that string-to-number
bc0a5c13 2044 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
2045 so that overflow for non-base-10 numbers is reported only when
2046 there's no portable and simple way to convert to floating point.
452f4150 2047
67769ffc
PE
2048 * textprop.c (set_text_properties_1): Rewrite for clarity,
2049 and to avoid GCC warning about integer overflow.
2050
c20db43f
PE
2051 * intervals.h (struct interval): Use EMACS_INT for members
2052 where EMACS_UINT might cause problems. See
2053 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2054 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2055 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2056 All uses changed.
37aa2f85
PE
2057 (offset_intervals): Tell GCC not to worry about length overflow
2058 when negating a negative length.
c20db43f 2059
2538aa2f
PE
2060 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2061 (overrun_check_free): Likewise.
2062
f2d3008d
PE
2063 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2064 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2065 word size.
2066
ec8df744
PE
2067 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2068 (gnutls_make_error): Rename local to avoid shadowing.
2069 (gnutls_emacs_global_deinit): ifdef out; not used.
2070 (Fgnutls_boot): Use const for pointer to readonly storage.
2071 Comment out unused local. Fix pointer signedness problems.
2072
640ee02d
PE
2073 * lread.c (openp): Don't stuff size_t into an 'int'.
2074 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2075 about possible signed overflow.
2076
6048fb2a
PE
2077 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2078 (GDK_KEY_g): Don't define if already defined.
2079 (xg_prepare_tooltip): Avoid pointer signedness problem.
2080 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2081
fa3c87e1
PE
2082 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2083 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2084
2172544b
PE
2085 * xfns.c (Fx_window_property): Simplify a bit,
2086 to make a bit faster and to avoid GCC 4.6.0 warning.
2087 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2088
9b821a21
PE
2089 * fns.c (internal_equal): Don't assume size_t fits in int.
2090
3c616cfa
PE
2091 * alloc.c (compact_small_strings): Tighten assertion a little.
2092
c2982e87
PE
2093 Replace pEd with more-general pI, and fix some printf arg casts.
2094 * lisp.h (pI): New macro, generalizing old pEd macro to other
2095 conversion specifiers. For example, use "...%"pI"d..." rather
2096 than "...%"pEd"...".
2097 (pEd): Remove. All uses replaced with similar uses of pI.
2098 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2099 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2100 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2101 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2102 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2103 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2104 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2105 64-bit hosts.
2106 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2107 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2108 * print.c (safe_debug_print, print_object): Likewise.
2109 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2110 to int.
6f04d126
PE
2111 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2112 avoiding the 0 flag, which is not portable.
c2982e87
PE
2113 * process.c (Fmake_network_process): Use pI to avoid cast.
2114 * region-cache.c (pp_cache): Likewise.
2115 * xdisp.c (decode_mode_spec): Likewise.
2116 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2117 behavior on 64-bit hosts with printf arg.
6f04d126 2118 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
2119 (x_stop_queuing_selection_requests): Likewise.
2120 (x_get_window_property): Don't truncate byte count to an 'int'
2121 when tracing.
0b432f21 2122
5e073ec7
PE
2123 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2124 here, since it parses constructs like leading '-' and spaces,
2125 which are not wanted; and it overflows with large numbers.
2126 Instead, simply match F[0-9]+, which is what is wanted anyway.
2127
36372bf9
PE
2128 * alloc.c: Remove unportable assumptions about struct layout.
2129 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2130 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2131 (allocate_vectorlike, make_pure_vector): Use the new macros,
2132 plus offsetof, to remove unportable assumptions about struct layout.
2133 These assumptions hold on all porting targets that I know of, but
2134 they are not guaranteed, they're easy to remove, and removing them
2135 makes further changes easier.
2136
0b432f21
PE
2137 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2138 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
2139 (string_overrun_cookie): Now const. Use initializers that
2140 don't formally overflow signed char, to avoid warnings.
000098c1
PE
2141 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2142 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
2143 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2144 multiple of sizeof (EMACS_INT); it need not be, if
2145 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 2146 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 2147
895009e1
JB
21482011-04-26 Juanma Barranquero <lekktu@gmail.com>
2149
2150 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2151
6a7a1b0b
TZ
21522011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2153
2154 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 2155 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
2156 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2157
841a1577 21582011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
2159
2160 * lisp.h (Qdebug): List symbol.
895009e1 2161 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
2162 * keyboard.c (debug-on-event): New variable.
2163 (handle_user_signal): Break into debugger when debug-on-event
2164 matches the current signal symbol.
2165
f2d3ba6f
DN
21662011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2167
2168 * alloc.c (check_sblock, check_string_bytes)
2169 (check_string_free_list): Convert to standard C.
2170
42ce4c63
TZ
21712011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2172
2173 * w32.c (emacs_gnutls_push): Fix typo.
2174
825cd63c
EZ
21752011-04-25 Eli Zaretskii <eliz@gnu.org>
2176
fb11d64d
EZ
2177 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2178 "cast to pointer from integer of different size".
2179
825cd63c
EZ
2180 Improve doprnt and its use in verror. (Bug#8545)
2181 * doprnt.c (doprnt): Document the set of format control sequences
2182 supported by the function. Use SAFE_ALLOCA instead of always
2183 using `alloca'.
2184
2185 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2186 is one byte too soon. Don't use xrealloc; instead xfree and
2187 xmalloc anew.
2188
e061a11b
TZ
21892011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2190
2191 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2192 callbacks stage.
2193
2194 * gnutls.c: Renamed global_initialized to
2195 gnutls_global_initialized. Added internals for the
2196 :verify-hostname-error, :verify-error, and :verify-flags
2197 parameters of `gnutls-boot' and documented those parameters in the
2198 docstring. Start callback support.
2199 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2200 unless a fatal error occured. Call gnutls_alert_send_appropriate
2201 on error. Return error code.
2202 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2203 (emacs_gnutls_read): Likewise.
2204 (Fgnutls_boot): Return handshake error code.
2205 (emacs_gnutls_handle_error): New function.
2206 (wsaerror_to_errno): Likewise.
2207
2208 * w32.h (emacs_gnutls_pull): Add prototype.
2209 (emacs_gnutls_push): Likewise.
2210
2211 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2212 (emacs_gnutls_push): Likewise.
2213
22142011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2215
2216 * process.c (wait_reading_process_output): Check if GnuTLS
2217 buffered some data internally if no FDs are set for TLS
2218 connections.
2219
2220 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2221 (LIBS): Link to USER_LIBS.
2222 ($(BLD)/gnutls.$(0)): New target.
2223
fa6996bc
EZ
22242011-04-24 Eli Zaretskii <eliz@gnu.org>
2225
eb35682e
EZ
2226 * xdisp.c (handle_single_display_spec): Rename the
2227 display_replaced_before_p argument into display_replaced_p, to
2228 make it consistent with the commentary. Fix typos in the
2229 commentary.
2230
e2ad650c
EZ
2231 * textprop.c (syms_of_textprop): Remove dead code.
2232 (copy_text_properties): Delete obsolete commentary about an
2233 interface that was deleted long ago. Fix typos in the description
2234 of arguments.
2235
1b2de274
EZ
2236 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2237 to changes in oldXMenu/XMenu.h from 2011-04-16.
2238 <menu_help_message, prev_menu_help_message>: Constify.
2239 (IT_menu_make_room): menu->help_text is now `const char **';
2240 adjust.
2241
2242 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2243 to changes in oldXMenu/XMenu.h from 2011-04-16.
2244 (struct XMenu): Declare `help_text' `const char **'.
2245
2246 * xfaces.c <Qunspecified>: Make extern again.
2247
2248 * syntax.c: Include sys/types.h before including regex.h, as
2249 required by Posix.
2250
762b15be
EZ
2251 * doc.c (get_doc_string): Improve the format passed to `error'.
2252
2253 * doprnt.c (doprnt): Improve commentary.
2254
2255 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2256
2257 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2258 them with etags.
2259
f1052e5d
EZ
2260 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2261 changes in globals.h immediately force recompilation.
762b15be
EZ
2262 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2263 $(CURDIR)/s/ms-w32.h.
2264 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 2265
fa6996bc
EZ
2266 * character.c (Fchar_direction): Function deleted.
2267 (syms_of_character): Don't defsubr it.
2268 <char-direction-table>: Deleted.
2269
e6c3da20
EZ
22702011-04-23 Eli Zaretskii <eliz@gnu.org>
2271
2272 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2273 * doprnt.c: Include limits.h.
2274 (SIZE_MAX): New macro.
04f2d78b
CB
2275 (doprnt): Return a size_t value. 2nd arg is now size_t.
2276 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
2277 Improve overflow protection. Support `l' modifier for integer
2278 conversions. Support %l conversion. Don't assume an EMACS_INT
2279 argument for integer conversions and for %c.
2280
2281 * lisp.h (doprnt): Restore prototype.
2282
2283 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2284 $(SRC)/character.h.
2285
2286 * Makefile.in (base_obj): Add back doprnt.o.
2287
2288 * deps.mk (doprnt.o): Add back prerequisites.
2289 (callint.o): Depend on character.h.
2290
2291 * eval.c (internal_lisp_condition_case): Include the handler
2292 representation in the error message.
2293 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2294 when breaking from the loop.
2295
2296 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2297
2298 * callint.c (Fcall_interactively): When displaying error message
2299 about invalid control letter, pass the character's codepoint, not
2300 a pointer to its multibyte form. Improve display of the character
2301 in octal and display also its hex code.
2302
2303 * character.c (char_string): Use %x to display the (unsigned)
2304 codepoint of an invalid character, to avoid displaying a bogus
2305 negative value.
2306
2307 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2308 `error', not SYMBOL_NAME itself.
2309
2310 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2311 character arguments to `error'.
2312
2313 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2314 to `error' in error message about FINAL_CHAR argument. Make sure
2315 FINAL_CHAR is a character, and use %c when it is passed as
2316 argument to `error'.
2317
4ffd0d6b 23182011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
2319
2320 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2321
2322 * w32.c: Include <time.h>.
2323 (sys_localtime): New function.
2324
4ffd0d6b 23252011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
2326
2327 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2328
4ffd0d6b 2329 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 2330
4ffd0d6b 23312011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 2332
4ffd0d6b
GM
2333 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2334 zombies (Bug#8467).
aac0c6e3 2335
04c56954
EZ
23362011-04-19 Eli Zaretskii <eliz@gnu.org>
2337
2338 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2339 gl_state.e_property when gl_state.object is Qt.
2340
2341 * insdel.c (make_gap_larger): Remove limitation of buffer size
2342 to <= INT_MAX.
2343
16a43933
CY
23442011-04-18 Chong Yidong <cyd@stupidchicken.com>
2345
2346 * xdisp.c (lookup_glyphless_char_display)
2347 (produce_glyphless_glyph): Handle cons cell entry in
2348 glyphless-char-display.
2349 (Vglyphless_char_display): Document it.
2350
2351 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2352 glyphless-char-display.
2353
4581706e
CY
23542011-04-17 Chong Yidong <cyd@stupidchicken.com>
2355
2356 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2357
2358 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2359
2360 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2361 definition for no-X builds.
2362
4887c6e2 23632011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 2364
fd35b6f9
PE
2365 Static checks with GCC 4.6.0 and non-default toolkits.
2366
5c1ccb01
PE
2367 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2368
006c5daa
PE
2369 * process.c (keyboard_bit_set): Define only if SIGIO.
2370 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2371 (send_process): Repair possible setjmp clobbering.
2372
efc736d3
PE
2373 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2374
4e2fe2e6
PE
2375 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2376
f97334a2
PE
2377 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2378
4e75f29d
PE
2379 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2380 Define only if needed.
2381
90efadd1
PE
2382 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2383 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 2384 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 2385
3c647824
PE
2386 * dispextern.h (struct redisplay_interface): Rename param
2387 to avoid shadowing.
e264f262 2388 * termhooks.h (struct terminal): Likewise.
761383f4 2389 * xterm.c (xembed_send_message): Likewise.
3c647824 2390
b58c5c4a
PE
2391 * insdel.c (make_gap_smaller): Define only if
2392 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2393
cad59032
PE
2394 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2395 it.
2396
c339dc2e
PE
2397 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2398 so that we aren't warned about unused symbols.
2399
91a3e27b
PE
2400 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2401
399c71d3 2402 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 2403
8ffc96f5
PE
2404 * xfns.c (x_real_positions): Mark locals as initialized.
2405
eef9bc79
PE
2406 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2407
098db9dd
PE
2408 * xterm.c: Fix problems found by static analysis with other toolkits.
2409 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
2410 (x_dispatch_event): Declare static if USE_GTK, and
2411 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 2412 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 2413 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
2414 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2415 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 2416
eb18f6cc
PE
2417 * xmenu.c (menu_help_callback): Pointer type fixes.
2418 Use const pointers when pointing at readonly data. Avoid pointer
2419 signedness clashes.
2420 (FALSE): Remove unused macro.
2421 (update_frame_menubar): Remove unused decl.
2422
1fe72bf8
PE
2423 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2424
60d9e1db
PE
2425 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2426 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2427 (single_menu_item): Rename local to avoid shadowing.
2428
39261c26
PE
2429 * keyboard.c (make_lispy_event): Remove unused local var.
2430
018c5e19
PE
2431 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2432 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2433
63d2b86e
PE
2434 * bitmaps: Change bitmaps from unsigned char back to the X11
2435 compatible char. Avoid the old compiler warnings about
2436 out-of-range initializers by using, for example, '\xab' rather
2437 than 0xab.
2438
aefd87e1
PE
2439 * xgselect.c (xgselect_initialize): Check vs interface
2440 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2441
bf501fb9
PE
2442 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2443
e9829fdf
PE
2444 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2445 to read-only memory.
2446
1086c095
PE
2447 * fns.c (vector): Remove; this old hack is no longer needed.
2448
2baccd04 2449 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 2450 Remove unused var.
dde42981 2451 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 2452
72391843 2453 * xrdb.c (x_load_resources): Omit unused local.
3565b346 2454
436c16df 2455 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 2456 (x_window): Rename locals to avoid shadowing.
dc5ddd85 2457 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 2458
92bb796d 2459 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 2460 (x_term_init): Remove local to avoid shadowing.
92bb796d 2461
764430a3 2462 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
2463
2464 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2465 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2466
d1dfb56c
EZ
24672011-04-16 Eli Zaretskii <eliz@gnu.org>
2468
c4354cb4
EZ
2469 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2470
d1dfb56c
EZ
2471 Fix regex.c, syntax.c and friends for buffers > 2GB.
2472 * syntax.h (struct gl_state_s): Declare character position members
2473 EMACS_INT.
2474
2475 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2476
04f2d78b
CB
2477 * textprop.c (verify_interval_modification, interval_of):
2478 Declare arguments EMACS_INT.
d1dfb56c
EZ
2479
2480 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2481 EMACS_INT.
2482
2483 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2484
2485 * indent.c (Fvertical_motion): Local variable it_start is now
2486 EMACS_INT.
2487
2488 * regex.c (re_match, re_match_2, re_match_2_internal)
2489 (bcmp_translate, regcomp, regexec, print_double_string)
2490 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2491 (re_compile_pattern, re_exec): Declare arguments and local
2492 variables `size_t' and `ssize_t' and return values `regoff_t', as
2493 appropriate.
2494 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2495 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2496 <compile_stack_type>: `size' and `avail' are now `size_t'.
2497
2498 * regex.h <regoff_t>: Use ssize_t, not int.
2499 (re_search, re_search_2, re_match, re_match_2): Arguments that
2500 specify buffer/string position and length are now ssize_t and
2501 size_t. Return type is regoff_t.
2502
613052cd
BK
25032011-04-16 Ben Key <bkey76@gmail.com>
2504
2505 * nsfont.m: Fixed bugs in ns_get_family and
2506 ns_descriptor_to_entity that were caused by using free to
2507 deallocate memory blocks that were allocated by xmalloc (via
2508 xstrdup). This caused Emacs to crash when compiled with
2509 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2510 --enable-checking=xmallocoverrun). xfree is now used to
2511 deallocate these memory blocks.
2512
4170f62f 25132011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 2514
71b41406
PE
2515 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2516
9587a89d
PE
2517 emacs_write: Accept and return EMACS_INT for sizes.
2518 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2519 et seq.
2520 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2521 Accept and return EMACS_INT.
2522 (emacs_gnutls_write): Return the number of bytes written on
2523 partial writes.
2524 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
2525 (emacs_read, emacs_write): Remove check for negative size, as the
2526 Emacs source code has been audited now.
9587a89d
PE
2527 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2528 (emacs_read, emacs_write): Use it.
273a5f82
PE
2529 * process.c (send_process): Adjust to the new signatures of
2530 emacs_write and emacs_gnutls_write. Do not attempt to store
2531 a byte offset into an 'int'; it might overflow.
9587a89d 2532 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 2533
3e047f51
PE
2534 * sound.c: Don't assume sizes fit in 'int'.
2535 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 2536 Return EMACS_INT, not int.
3e047f51 2537 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
2538 Accept EMACS_INT, not int.
2539 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
2540 record read return values.
2541
cc39a9db
BK
25422011-04-15 Ben Key <bkey76@gmail.com>
2543
c9d0ec6d
JB
2544 * keyboard.c (Qundefined): Don't declare static since it is used
2545 in nsfns.m.
2546 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2547 static since they are used in nsfont.m.
cc39a9db 2548
6c60eb9f
SM
25492011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2550
2551 * process.c (Qprocessp): Don't declare static.
2552 * lisp.h (Qprocessp): Declare again.
2553
7990b61a
JB
25542011-04-15 Juanma Barranquero <lekktu@gmail.com>
2555
2556 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2557
5d4cb038
PE
25582011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2559
8bd7b830 2560 Improve C-level modularity by making more things 'static'.
cd64ea1d 2561
e3b27b31
PE
2562 Don't publish debugger-only interfaces to other modules.
2563 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2564 (verify_bytepos, count_markers): Move decls to the only modules
2565 that need them.
2566 * region-cache.h (pp_cache): Likewise.
2567 * window.h (check_all_windows): Likewise.
2568 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2569
5d4cb038
PE
2570 * sysdep.c (croak): Now static, if
2571 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2572 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
2573
2574 * alloc.c (refill_memory_reserve): Now static if
2575 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2576 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 2577
e87b6180
PE
2578 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2579 Define only if USE_LUCID.
2580
ac64929e
PE
2581 * xrdb.c (x_customization_string, x_rm_string): Now static.
2582
6f37259d
PE
2583 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2584 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2585
1683e3ab
PE
2586 * xdisp.c (draw_row_with_mouse_face): Now static.
2587 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2588
de9c2632
PE
2589 * window.h (check_all_windows): Mark externally visible.
2590
2b96acb7
PE
2591 * window.c (window_deletion_count): Now static.
2592
2593 * undo.c: Make symbols static if they're not exported.
2594 (last_undo_buffer, last_boundary_position, pending_boundary):
2595 Now static.
2596
50436f33
PE
2597 * textprop.c (interval_insert_behind_hooks): Now static.
2598 (interval_insert_in_front_hooks): Likewise.
2599
64520e5c
PE
2600 * term.c: Make symbols static if they're not exported.
2601 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2602 (max_frame_lines, tty_set_terminal_modes):
2603 (tty_reset_terminal_modes, tty_turn_off_highlight):
2604 (get_tty_terminal): Now static.
2605 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2606 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 2607 HAVE_WINDOW_SYSTEM.
64520e5c
PE
2608 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2609 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2610
1fa53021
PE
2611 * sysdep.c: Make symbols static if they're not exported.
2612 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2613 Now static.
2614 (sigprocmask_set, full_mask): Remove; unused.
2615 (wait_debugging): Mark as visible.
2616 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2617 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2618
d4b43b22
PE
2619 * syntax.c (syntax_temp): Define only if !__GNUC__.
2620
b7c513d0
PE
2621 * sound.c (current_sound_device, current_sound): Now static.
2622
989b29ad
PE
2623 * search.c (searchbufs, searchbuf_head): Now static.
2624
13a55a78
PE
2625 * scroll.c (scroll_cost): Remove; unused.
2626 * dispextern.h (scroll_cost): Remove decl.
2627
de68a1fc
PE
2628 * region-cache.h (pp_cache): Mark as externally visible.
2629
40ccffa6
PE
2630 * process.c: Make symbols static if they're not exported.
2631 (process_tick, update_tick, create_process, chan_process):
2632 (Vprocess_alist, proc_buffered_char, datagram_access):
2633 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2634 (deactivate_process): Mark defn as static, as well as decl.
2635 * lisp.h (create_process): Remove decl.
2636 * process.h (chan_process, Vprocess_alist): Remove decls.
2637
ad64fc97
PE
2638 * print.c: Make symbols static if they're not exported.
2639 (print_depth, new_backquote_output, being_printed, print_buffer):
2640 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2641 (print_interval, print_number_index, initial_stderr_stream):
2642 Now static.
2643 * lisp.h (Fprinc): Remove decl.
2644 (debug_output_compilation_hack): Mark as externally visible.
2645
adddb265
PE
2646 * sysdep.c (croak): Move decl from here to syssignal.h.
2647 * syssignal.h (croak): Put it here, so the API can be checked when
2648 'croak' is called from dissociate_if_controlling_tty.
2649
1717ede2
PE
2650 * minibuf.c: Make symbols static if they're not exported.
2651 (minibuf_save_list, choose_minibuf_frame): Now static.
2652 * lisp.h (choose_minibuf_frame): Remove decl.
2653
fa5fb2bc
PE
2654 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2655
1e3890d1
PE
2656 * lread.c: Make symbols static if they're not exported.
2657 (read_objects, initial_obarray, oblookup_last_bucket_number):
2658 Now static.
2659 (make_symbol): Remove; unused.
2660 * lisp.h (initial_obarray, make_symbol): Remove decls.
2661
8a1414fa
PE
2662 * keyboard.c: Make symbols static if they're not exported.
2663 (single_kboard, recent_keys_index, total_keys, recent_keys):
2664 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2665 (this_single_command_key_start, echoing, last_auto_save):
2666 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2667 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2668 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2669 (Vlispy_mouse_stem, double_click_count):
2670 Now static.
2671 (force_auto_save_soon): Define only if SIGDANGER.
2672 (ignore_mouse_drag_p): Now static if
2673 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2674 (print_help): Remove; unused.
2675 (stop_character, last_timer_event): Mark as externally visible.
2676 * keyboard.h (ignore_mouse_drag_p): Declare only if
2677 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2678 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2679 * lisp.h (echoing): Remove decl.
2680 (force_auto_save_soon): Declare only if SIGDANGER.
2681 * xdisp.c (redisplay_window): Simplify code, to make it more
2682 obvious that ignore_mouse_drag_p is not accessed if !defined
2683 USE_GTK && !defined HAVE_NS.
2684
93ea6e8f
PE
2685 * intervals.c: Make symbols static if they're not exported.
2686 (merge_properties_sticky, merge_interval_right, delete_interval):
2687 Now static.
2688 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2689
77382fcc
PE
2690 * insdel.c: Make symbols static if they're not exported.
2691 However, leave prepare_to_modify_buffer alone. It's never
2692 called from outside this function, but that appears to be a bug.
2693 (combine_after_change_list, combine_after_change_buffer):
4889fc82 2694 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
2695 (adjust_after_replace_noundo): Remove; unused.
2696 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 2697 (signal_before_change): Remove decls.
77382fcc 2698
9306c32e
PE
2699 * indent.c (val_compute_motion, val_vmotion): Now static.
2700
cd44d2eb
PE
2701 * image.c: Make symbols static if they're not exported.
2702 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2703 if USE_GTK.
2704 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2705 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2706
ad9a7a06
PE
2707 * fringe.c (standard_bitmaps): Now static.
2708 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2709
81626931
PE
2710 * frame.c: Make symbols static if they're not exported.
2711 (x_report_frame_params, make_terminal_frame): Now static.
2712 (get_frame_param): Now static, unless HAVE_NS.
2713 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2714 (x_get_resource_string): Remove; not used.
2715 * frame.h (make_terminal_frame, x_report_frame_params):
2716 (x_get_resource_string); Remove decls.
2717 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2718 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2719
239f9db9
PE
2720 * font.c, fontset.c: Make symbols static if they're not exported.
2721 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2722 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2723 * font.c (font_close_object): Now static.
2724 * font.h (font_close_object): Remove.
2725 * fontset.c (FONTSET_OBJLIST): Remove.
2726 (free_realized_fontset) #if-0 the body, which does nothing.
2727 (face_suitable_for_char_p): #if-0, as it's never called.
2728 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
2729 * xfaces.c (face_at_string_position):
2730 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
2731 since 0 is always ASCII.
2732
dfcf3579
PE
2733 * fns.c (weak_hash_tables): Now static.
2734
5045092b
PE
2735 * fileio.c: Make symbols static if they're not exported.
2736 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2737 (Vwrite_region_annotation_buffers): Now static.
2738
57a96f5c
PE
2739 * eval.c: Make symbols static if they're not exported.
2740 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2741 * lisp.h (backtrace_list): Remove decl.
2742
35f08c38
PE
2743 * emacs.c: Make symbols static if they're not exported.
2744 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2745 (fatal_error_code, fatal_error_signal_hook, standard_args):
2746 Now static.
2747 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2748 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2749 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2750 * lisp.h (fatal_error_signal_hook): Remove decl.
2751 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2752
f44bd759
PE
2753 * editfns.c: Move a (normally-unused) function to its only use.
2754 * editfns.c, lisp.h (get_operating_system_release): Remove.
2755 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2756 worth the hassle of breaking this out.
2757
b532497d
PE
2758 * xterm.c: Make symbols static if they're not exported.
2759 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2760 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2761 (x_destroy_window, x_delete_display):
2762 Now static.
2763 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2764 (x_mouse_leave): Remove; unused.
2765 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2766 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2767 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2768 Remove decls.
2769 (x_mouse_leave): Declare only if WINDOWSNT.
2770 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2771 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2772 USE_X_TOOLKIT.
2773
1675728f
PE
2774 * ftxfont.c: Make symbols static if they're not exported.
2775 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2776 HAVE_FREETYPE.
2777 * font.h (ftxfont_driver): Likewise.
2778
e4cebfca
PE
2779 * xfns.c: Make symbols static if they're not exported.
2780 (x_last_font_name, x_display_info_for_name):
2781 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2782 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2783 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2784 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2785 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2786 (last_show_tip_args): Now static.
2787 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2788 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2789 (x_screen_planes): Remove; unused.
2790 * dispextern.h (x_screen_planes): Remove decl.
2791
5bf46f05
PE
2792 * dispnew.c: Make symbols static if they're not exported.
2793 * dispextern.h (redraw_garbaged_frames, scrolling):
2794 (increment_row_positions): Remove.
2795 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2796 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2797 Now static.
2798 (redraw_garbaged_frames): Remove; unused.
2799
435f4c28
PE
2800 * xfaces.c: Make symbols static if they're not exported.
2801 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2802 Remove decls.
2803 * xterm.h (defined_color): Remove decls.
2804 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2805 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2806 (menu_face_changed_default, defined_color, free_realized_face):
2807 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2808 (ascii_face_of_lisp_face): Remove; unused.
2809
8524aef3
PE
2810 * xdisp.c: Make symbols static if they're not exported.
2811 * dispextern.h (scratch_glyph_row, window_box_edges):
2812 (glyph_to_pixel_coords, set_cursor_from_row):
2813 (get_next_display_element, set_iterator_to_next):
2814 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2815 (show_mouse_face): Remove decls
2816 * frame.h (message_buf_print): Likewise.
2817 * lisp.h (pop_message, set_message, check_point_in_composition):
2818 Likewise.
2819 * xterm.h (set_vertical_scroll_bar): Likewise.
2820 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2821 (message_buf_print, scratch_glyph_row, displayed_buffer):
2822 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2823 (get_next_display_element, show_mouse_face, window_box_edges):
2824 (frame_to_window_pixel_xy, check_point_in_composition):
2825 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2826 (glyph_to_pixel_coords): Remove; unused.
2827
16390cd2
PE
2828 * dired.c (file_name_completion): Now static.
2829
2830 * dbusbind.c (xd_in_read_queued_messages): Now static.
2831
a25f4dfa
PE
2832 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2833 * data.c (circular_list_error): Remove.
2834
14a9c8df
PE
2835 * commands.h (last_point_position, last_point_position_buffer):
2836 (last_point_position_window): Remove decls.
2837 * keyboard.c: Make these variables static.
2838
04f2d78b
CB
2839 * coding.h (coding, code_convert_region, encode_coding_gap):
2840 Remove decls.
74ab6df5
PE
2841 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2842 (iso_code_class, detect_coding, code_convert_region): Now static.
2843 (encode_coding_gap): Remove; unused.
2844
38dfbee1
PE
2845 * chartab.c (chartab_chars, chartab_bits): Now static.
2846
a2cb4e63
PE
2847 * charset.h (charset_iso_8859_1): Remove decl.
2848 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2849 Now static.
2850
127198fd
PE
2851 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2852 * ccl.c (Vccl_program_table): Now static.
2853 (check_ccl_update): Remove; unused.
2854
d85b608f
PE
2855 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2856 * category.h: ... from here.
2857 * category.c (check_category_table, set_category_set): Now static.
2858
31cd66f3
PE
2859 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2860 * lisp.h: Remove these decls.
2861
c358e587
PE
2862 * buffer.c (buffer_count): Remove unused var.
2863
e78aecca
PE
2864 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2865 so that it's not optimized away.
2866 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2867 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2868 exported only to the debugger.
2869
e192d7d3 2870 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 2871 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 2872
92470028
PE
2873 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2874 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2875 was inaccessible from Lisp.
2876 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2877 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2878
244ed907
PE
2879 alloc.c: Import and export fewer symbols, and remove unused items.
2880 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2881 is defined.
2882 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2883 it's not optimized away by whole-program optimization.
2884 (message_enable_multibyte, free_misc): Remove.
2885 (catchlist, handlerlist, mark_backtrace):
2886 Declare only if BYTE_MARK_STACK.
2887 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2888 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2889 (message_enable_multibyte): Remove decl.
2890 (free_misc, interval_free_list, float_block, float_block_index):
2891 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2892 (cons_free_list, last_marked_index):
2893 Now static.
2894 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2895 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2896 (mark_backtrace): Define only if BYTE_MARK_STACK.
2897 * xdisp.c (message_enable_multibyte): Now static.
2898
61c2b50e 2899 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
2900 This makes it easier for human readers (and static analyzers)
2901 to see whether these variables are used from other modules.
2902 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2903 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2904 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2905 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2906 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2907 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2908 * xmenu.c, xselect.c:
2909 Declare Q* vars static if they are not used in other modules.
2910 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2911 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2912 Remove decls of unexported vars.
2913 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2914
95c82688
PE
2915 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2916
16a97296
PE
2917 Make Emacs functions such as Fatom 'static' by default.
2918 This makes it easier for human readers (and static analyzers)
2919 to see whether these functions can be called from other modules.
2920 DEFUN now defines a static function. To make the function external
2921 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
2922 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2923 (Finit_image_library):
16a97296
PE
2924 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2925 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2926 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2927 Remove decls, since these functions are now static.
2928 (Funintern, Fget_internal_run_time): New decls, since these functions
2929 were already external.
95c82688 2930
16a97296
PE
2931 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2932 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2933 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2934 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2935 * keyboard.c, keymap.c, lread.c:
2936 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2937 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2938 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2939 Mark functions with DEFUE instead of DEFUN,
2940 if they are used in other modules.
2941 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2942 decls for now-static functions.
2943 * buffer.h (Fdelete_overlay): Remove decl.
2944 * callproc.c (Fgetenv_internal): Mark as internal.
2945 * composite.c (Fremove_list_of_text_properties): Remove decl.
2946 (Fcomposition_get_gstring): New forward static decl.
2947 * composite.h (Fcomposite_get_gstring): Remove decl.
2948 * dired.c (Ffile_attributes): New forward static decl.
2949 * doc.c (Fdocumntation_property): New forward static decl.
2950 * eval.c (Ffetch_bytecode): New forward static decl.
2951 (Funintern): Remove extern decl; now in .h file where it belongs.
2952 * fileio.c (Fmake_symbolic_link): New forward static decl.
2953 * image.c (Finit_image_library): New forward static decl.
2954 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2955 * intervals.h (Fprevious_property_change):
2956 (Fremove_list_of_text_properties): Remove decls.
2957 * keyboard.c (Fthis_command_keys): Remove decl.
2958 (Fcommand_execute): New forward static decl.
2959 * keymap.c (Flookup_key): New forward static decl.
2960 (Fcopy_keymap): Now static.
2961 * keymap.h (Flookup_key): Remove decl.
2962 * process.c (Fget_process): New forward static decl.
2963 (Fprocess_datagram_address): Mark as internal.
2964 * syntax.c (Fsyntax_table_p): New forward static decl.
2965 (skip_chars): Remove duplicate decl.
2966 * textprop.c (Fprevious_property_change): New forward static decl.
2967 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2968 Now internal.
2969 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2970 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2971
785bbd42
PE
2972 * editfns.c (Fformat): Remove unreachable code.
2973
8b913b57
AS
29742011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2975
2976 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2977 change. (Bug#8496)
2978
a6744a35
EZ
29792011-04-13 Eli Zaretskii <eliz@gnu.org>
2980
2981 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2982 when at ZV. (Bug#8487)
2983
e7974947
AS
29842011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2985
baad03f0
AS
2986 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2987 (Bug#8437)
2988 * keyboard.c (parse_tool_bar_item): Likewise.
2989 * sound.c (sound_cleanup, alsa_close): Likewise.
2990 * termcap.c (tgetent): Likewise.
2991 * xfns.c (x_default_font_parameter): Likewise.
2992 * xsettings.c (read_and_apply_settings): Likewise.
2993
e7974947
AS
2994 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2995 (overrun_check_free): Protoize.
2996
28272684
PE
29972011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2998
2999 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3000 since callers should never pass a negative size.
3001 Change the signature to match that of plain 'read' and 'write'; see
3002 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3003 * lisp.h: Update prototypes of emacs_write and emacs_read.
3004
11997c76
EZ
30052011-04-11 Eli Zaretskii <eliz@gnu.org>
3006
3007 * xdisp.c (redisplay_window): Don't try to determine the character
3008 position of the scroll margin if the window start point w->startp
e896f03c 3009 is outside the buffer's accessible region. (Bug#8468)
11997c76 3010
8a2cbd72
EZ
30112011-04-10 Eli Zaretskii <eliz@gnu.org>
3012
3013 Fix write-region and its subroutines for buffers > 2GB.
3014 * fileio.c (a_write, e_write): Modify declaration of arguments and
3015 local variables to support buffers larger than 2GB.
3016 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3017
3018 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3019 argument, local variables, and return value.
3020
3021 * lisp.h: Update prototypes of emacs_write and emacs_read.
3022
3023 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3024
4073e537 30252011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 3026
1ebfdcb6
PE
3027 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3028
b2ded58d
PE
3029 Fix more problems found by GCC 4.6.0's static checks.
3030
7d66342c
PE
3031 * xdisp.c (vmessage): Use a better test for character truncation.
3032
bbf47d44
PE
3033 * charset.c (load_charset_map): <, not <=, for optimization,
3034 and to avoid potential problems with integer overflow.
9248994d 3035 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 3036 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 3037 * editfns.c (Fformat): Likewise.
1e69125e 3038 * syntax.c (skip_chars): Likewise.
3befa583 3039
e3019616
PE
3040 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3041 This also lets GCC 4.6.0 generate slightly better loop code.
3042
becfa255
PE
3043 * callint.c (Fcall_interactively): <, not <=, for optimization.
3044 (Fcall_interactively): Count the number of arguments produced,
3045 not the number of arguments given. This is simpler and lets GCC
3046 4.6.0 generate slightly better code.
3047
dae0cd48
PE
3048 * ftfont.c: Distingish more carefully between FcChar8 and char.
3049 The previous code passed unsigned char * to a functions like
3050 strlen and xstrcasecmp that expect char *, which does not
3051 conform to the C standard.
3052 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3053 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3054 char * when the C standard requires it.
3055
76032d70
PE
3056 * keyboard.c (read_char): Remove unused var.
3057
eb3f1cc8
PE
3058 * eval.c: Port to Windows vsnprintf (Bug#8435).
3059 Include <limits.h>.
3060 (SIZE_MAX): Define if the headers do not.
3061 (verror): Do not give up if vsnprintf returns a negative count.
3062 Instead, grow the buffer. This ports to Windows vsnprintf, which
3063 does not conform to C99. Problem reported by Eli Zaretskii.
3064 Also, simplify the allocation scheme, by avoiding the need for
3065 calling realloc, and removing the ALLOCATED variable.
3066
70476b54
PE
3067 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3068
12020a9e
PE
3069 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3070 But keep the doprint source code for now, as we might revamp it
3071 and use it again (Bug#8435).
ea6c7ae6
PE
3072 * lisp.h (doprnt): Remove.
3073 * Makefile.in (base_obj): Remove doprnt.o.
3074 * deps.mk (doprnt.o): Remove.
3075
5fdb398c
PE
3076 error: Print 32- and 64-bit integers portably (Bug#8435).
3077 Without this change, on typical 64-bit hosts error ("...%d...", N)
3078 was used to print both 32- and 64-bit integers N, which relied on
3079 undefined behavior.
3080 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3081 New macro.
3082 * lisp.h (error, verror): Mark as printf-like functions.
3083 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3084 Report overflow in size calculations when allocating printf buffer.
3085 Do not truncate output string at its first null byte.
3086 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3087 Truncate the output at a character boundary, since vsnprintf does not
3088 do that.
3089 * charset.c (check_iso_charset_parameter): Convert internal
3090 character to string before calling 'error', since %c now has the
3091 printf meaning.
3092 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3093 overflow when computing char to be passed to 'error'. Do not
3094 pass Lisp_Object to 'error'; pass the integer instead.
3095 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3096 formatted with plain %d.
3097
b189fa66
PE
3098 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3099
bff87ef0
PE
3100 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3101
7e2cac20
PE
3102 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3103
ce4d90b5
PE
3104 * xterm.c (x_catch_errors): Remove duplicate declaration.
3105
266c9547
PE
3106 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3107
79c49ad2
PE
3108 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3109
368f4090
JM
31102011-04-10 Jim Meyering <meyering@redhat.com>
3111
3112 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3113 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3114 return ssize_t not "int", and use size_t as the buffer length.
3115 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3116 * gnutls.h: Update declarations.
3117 * process.c (read_process_output): Use ssize_t, to match.
3118 (send_process): Likewise.
3119
a32d4040
CY
31202011-04-09 Chong Yidong <cyd@stupidchicken.com>
3121
3122 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3123
8546720e 31242011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 3125
04f2d78b
CB
3126 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3127 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 3128
8546720e
GM
3129 * xterm.c (handle_one_xevent):
3130 * xmenu.c (create_and_show_popup_menu):
3131 * xselect.c (x_decline_selection_request)
3132 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 3133
0a2f5c1a 31342011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
3135
3136 Fix some uses of `int' instead of EMACS_INT.
3137 * search.c (string_match_1, fast_string_match)
3138 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3139 (scan_buffer, find_next_newline_no_quit)
3140 (find_before_next_newline, search_command, Freplace_match)
3141 (Fmatch_data): Make some `int' variables be EMACS_INT.
3142
3143 * xdisp.c (display_count_lines): 3rd argument and return value now
3144 EMACS_INT. All callers changed.
3145 (pint2hrstr): Last argument is now EMACS_INT.
3146
3147 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3148 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3149 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3150 (decode_coding_utf_16, decode_coding_emacs_mule)
3151 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3152 (decode_coding_ccl, decode_coding_charset)
3153 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3154 (decode_coding_iso_2022, decode_coding_emacs_mule)
3155 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3156 <char_offset, last_offset>: Declare EMACS_INT.
3157 (encode_coding_utf_8, encode_coding_utf_16)
3158 (encode_coding_emacs_mule, encode_invocation_designation)
3159 (encode_designation_at_bol, encode_coding_iso_2022)
3160 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3161 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3162 Declare EMACS_INT.
3163 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3164 (encode_invocation_designation): Last argument P_NCHARS is now
3165 EMACS_INT.
3166 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3167 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3168
3169 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3170 All users changed.
3171
3172 * ccl.c (Fccl_execute_on_string): Declare some variables
3173 EMACS_INT.
3174
8546720e 31752011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
3176
3177 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3178
4e19a977
CS
31792011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3180
3181 * process.c (Fformat_network_address): Doc fix.
3182
87302331
R
31832011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3184
3185 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3186
cbb59342
CY
31872011-04-08 Chong Yidong <cyd@stupidchicken.com>
3188
3189 * keyboard.c (read_char): Call Lisp function help-form-show,
3190 instead of using internal_with_output_to_temp_buffer.
3191 (Qhelp_form_show): New var.
e0d38eeb 3192 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
3193
3194 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3195
3196 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3197
e67a13ab
CY
31982011-04-06 Chong Yidong <cyd@stupidchicken.com>
3199
04f2d78b
CB
3200 * process.c (Flist_processes): Remove to Lisp.
3201 (list_processes_1): Delete.
e67a13ab 3202
973f782d
EZ
32032011-04-06 Eli Zaretskii <eliz@gnu.org>
3204
7c106b1e
EZ
3205 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3206
973f782d
EZ
3207 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3208
41cf7d1a 32092011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 3210
ca23cc88
PE
3211 Fix more problems found by GCC 4.6.0's static checks.
3212
f390e2d5
PE
3213 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3214
42eea0d0
PE
3215 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3216
b69769da 3217 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 3218
f9541e84
PE
3219 * xdisp.c (vmessage): Mark as a printf-like function.
3220
13841b55
PE
3221 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3222
c136c10f
PE
3223 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3224
5e2d4a30
PE
3225 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3226 printf-like functions.
3227 (tiff_load): Add casts to remove these marks before passing them
3228 to system-supplied API.
3229
583f48b9
PE
3230 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3231
b25d760e
PE
3232 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3233 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
3234 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3235 directly, rather than having caller test rule sign. This avoids
3236 some unnecessary tests.
3237 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3238 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3239 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 3240
bc7b6697 3241 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 3242 (xfont_open): Avoid unnecessary tests.
bc7b6697 3243
27ccc379
PE
3244 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3245
dcd5c89a
PE
3246 * composite.h, composite.c (composition_gstring_put_cache):
3247 Use EMACS_INT, not int, for length.
3248
b13a45c6
PE
3249 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3250 breaking out part of COMPOSITION_DECODE_RULE.
3251 (COMPOSITION_DECODE_RULE): Use it.
3252 * composite.c (get_composition_id): Remove unused local vars,
3253 by using the new macro.
3254
1e792e4d
PE
3255 * textprop.c (set_text_properties_1): Change while to do-while,
3256 since the condition is always true at first.
3257
dc6c6455 3258 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
3259 (interval_deletion_adjustment): Return unsigned value.
3260 All uses changed.
dc6c6455 3261
aba7731a
PE
3262 * process.c (list_processes_1, create_pty, read_process_output):
3263 (exec_sentinel): Remove vars that were set but not used.
afd4052b 3264 (create_pty): Remove unnecessary "volatile"s.
bc57d757 3265 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 3266 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 3267 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 3268
fdfc4bf3
PE
3269 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3270
fca8fe46 3271 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 3272 (update_syntax_table): Use unsigned instead of int.
fca8fe46 3273
06a0259a 3274 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 3275 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 3276 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 3277
e7b9e80f
PE
3278 * print.c (print_error_message): Avoid int overflow.
3279
56201685
PE
3280 * font.c (font_list_entities): Redo for clarity,
3281 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3282
78834453 3283 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 3284 (font_score): Avoid potential overflow in diff calculation.
78834453 3285
0bc0b309 3286 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 3287 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 3288
e610eaca
PE
3289 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3290
b895abce
PE
3291 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3292 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3293 can always succeed if overflow has undefined behavior.
3294
1f1d9321 3295 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 3296 (wordify): Omit three unnecessary tests.
1f1d9321 3297
c59478bc
PE
3298 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3299 All callers changed. This avoids the need for an unused var.
3300
79b73827
PE
3301 * casefiddle.c (casify_region): Remove var that is set but not used.
3302
a4db5dfe
PE
3303 * dired.c (file_name_completion): Remove var that is set but not used.
3304
43aae36e
PE
3305 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3306
2a47c44d 3307 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 3308 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 3309
a37c69bf
PE
3310 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3311 Check for integer overflow on size calculations.
3312
328ab8e7
PE
3313 * buffer.c (Fprevious_overlay_change): Remove var that is set
3314 but not used.
3315
e5a2a5cb
PE
3316 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3317 Remove vars that are set but not used.
8d84a6eb 3318 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 3319 (timer_check_2): Mark vars as initialized.
e5a2a5cb 3320
a60e5f68
PE
3321 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3322
f661cb61 3323 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 3324 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 3325
f0397f5a
PE
3326 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3327 that are set but not used.
3328
8664db06 3329 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 3330 if XCreateBitmapFromData fails (Bug#8410).
8664db06 3331
6abdaa4a
PE
3332 * xselect.c (x_get_local_selection, x_handle_property_notify):
3333 Remove vars that are set but not used.
3334
0ce7538d 3335 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 3336 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 3337
9ae848fc
PE
3338 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3339 Remove var that is set but not used.
0b918413
PE
3340 (scroll_bar_windows_size): Now size_t, not int.
3341 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3342 Check for overflow.
9ae848fc 3343
a5a62657
PE
3344 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3345 (map_tty_color) [!defined MSDOS]: Likewise.
3346
5c5cdd39
PE
3347 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3348
66ebf983
PE
3349 * coding.c: Remove vars that are set but not used.
3350 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3351 All callers changed.
3352 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3353 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3354 (decode_coding_charset): Remove vars that are set but not used.
3355
1be4d761
PE
3356 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3357 that is set but not used.
3358
47553fa8
PE
3359 * print.c (print_object): Remove var that is set but not used.
3360
1f7196bf 3361 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
3362 The gnulib version avoids calling malloc in the usual case,
3363 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3364 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3365 * filelock.c (current_lock_owner): Likewise.
3366 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3367 * sysdep.c: Include allocator.h, careadlinkat.h.
3368 (emacs_no_realloc_allocator): New static constant.
3369 (emacs_readlink): New function.
fdb61804
PE
3370 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3371 ../lib/careadlinkat.h.
d1fdcab7 3372
f84c17c7
SM
33732011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3374
3375 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3376 first non-nil return value).
3377
ef3862ad
JD
33782011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3379
3380 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3381 if not defined (Bug#8403).
3382
376a7006
JB
33832011-04-02 Juanma Barranquero <lekktu@gmail.com>
3384
3385 * xdisp.c (display_count_lines): Remove parameter `start',
3386 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3387 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3388 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3389 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3390 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3391 and thereabouts. All callers changed.
3392 (get_per_char_metric): Remove parameter `f', unused since
3393 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3394
6ca3801d
JM
33952011-04-02 Jim Meyering <meyering@redhat.com>
3396
3397 do not dereference NULL upon failed strdup
3398 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3399 (ns_get_family): Likewise.
3400
d8e2b5ba
JB
34012011-04-02 Juanma Barranquero <lekktu@gmail.com>
3402
3403 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3404
8c74fcbd
JD
34052011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3406
3407 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3408 later (Bug#8403).
3409
7200d79c
SM
34102011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3411
03408648 3412 Add lexical binding.
7200d79c 3413
03408648
SM
3414 * window.c (Ftemp_output_buffer_show): New fun.
3415 (Fsave_window_excursion):
3416 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3417
3418 * lread.c (lisp_file_lexically_bound_p): New function.
3419 (Fload): Bind Qlexical_binding.
3420 (readevalloop): Remove `evalfun' arg.
3421 Bind Qinternal_interpreter_environment.
3422 (Feval_buffer): Bind Qlexical_binding.
3423 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3424 Mark as dynamic.
3425 (syms_of_lread): Declare `lexical-binding'.
3426
3427 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3428
3429 * keyboard.c (eval_dyn): New fun.
3430 (menu_item_eval_property): Use it.
ca105506
SM
3431
3432 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 3433
03408648
SM
3434 * fns.c (concat, mapcar1): Accept byte-code-functions.
3435
3436 * eval.c (Fsetq): Handle lexical vars.
3437 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3438 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3439 (FletX, Flet): Obey lexical binding.
3440 (Fcommandp): Handle closures.
3441 (Feval): New `lexical' arg.
3442 (eval_sub): New function extracted from Feval. Use it almost
3443 everywhere where Feval was used. Look up vars in lexical env.
3444 Handle closures.
3445 (Ffunctionp): Move from subr.el.
3446 (Ffuncall): Handle closures.
3447 (apply_lambda): Remove `eval_flags'.
3448 (funcall_lambda): Handle closures and new byte-code-functions.
3449 (Fspecial_variable_p): New function.
3450 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3451 but without exporting it to Lisp.
23aba0ea 3452
23aba0ea 3453 * doc.c (Fdocumentation, store_function_docstring):
03408648 3454 * data.c (Finteractive_form): Handle closures.
23aba0ea 3455
03408648
SM
3456 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3457 interactive spec.
ba83908c 3458
04f2d78b
CB
3459 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3460 New byte-codes.
03408648
SM
3461 (exec_byte_code): New function extracted from Fbyte_code to handle new
3462 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 3463
03408648 3464 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 3465
03408648 3466 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 3467
e2abce01
JB
34682011-03-31 Juanma Barranquero <lekktu@gmail.com>
3469
3470 * xdisp.c (redisplay_internal): Fix prototype.
3471
63696a73 34722011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 3473
63696a73 3474 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
3475 (try_scrolling): Use it when setting scroll_limit.
3476 Limit scrolling to 100 screen lines.
63696a73
EZ
3477 (redisplay_window): Even when falling back on "recentering",
3478 position point in the window according to scroll-conservatively,
3479 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3480
3481 (try_scrolling): When point is above the window, allow searching
3482 as far as scroll_max, or one screenful, to compute vertical
3483 distance from PT to the scroll margin position. This prevents
3484 try_scrolling from unnecessarily failing when
3485 scroll-conservatively is set to a value slightly larger than the
3486 window height. Clean up the case of PT below the margin at bottom
3487 of window: scroll_max can no longer be INT_MAX. When aggressive
3488 scrolling is in use, don't let point enter the opposite scroll
3489 margin as result of the scroll.
3490 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
3491 threshold of 100 lines for never-recentering scrolling.
3492
e4cc2dfc
JB
34932011-03-31 Juanma Barranquero <lekktu@gmail.com>
3494
3495 * dispextern.h (move_it_by_lines):
3496 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3497 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3498 (message_log_check_duplicate): Remove parameters `prev_bol' and
3499 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3500 (redisplay_internal): Remove parameter `preserve_echo_area',
3501 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3502
3503 * indent.c (Fvertical_motion):
3504 * window.c (window_scroll_pixel_based, Frecenter):
3505 Don't pass `need_y_p' to `move_it_by_lines'.
3506
1c470562
SM
35072011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3508
44f230aa
SM
3509 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3510 steal a few bits to be more compact.
3511 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3512 Remove unneeded casts.
3513
1c470562
SM
3514 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3515
888adce9
ZK
35162011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3517
3518 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3519 binding" message (bug#7967).
3520
f838ed7b
PE
35212011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3522
77861b95
PE
3523 Fix more problems found by GCC 4.6.0's static checks.
3524
de6dbc14
PE
3525 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3526 Remove unused local var.
3527
f838ed7b
PE
3528 * editfns.c (Fmessage_box): Remove unused local var.
3529
792c7b2b
PE
3530 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3531 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3532 Omit unused local vars.
c499e557 3533 * window.c (shrink_windows): Omit unused local var.
b01a1c29 3534 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
3535 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3536 Omit unused local var.
3537
ba0165e1
PE
3538 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3539 Don't assume string length fits in int.
32ad8845 3540 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 3541 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 3542
3c59b4c9
PE
3543 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3544 instead of alloca (Bug#8344).
3545
a3eed478 3546 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 3547 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 3548
eb4d412d
PE
3549 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3550
1658b401
PE
3551 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3552 concerns.
3553
3554 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3555
3556 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 3557
9a2c6e05
PE
3558 * keyboard.c (syms_of_keyboard): Use the same style as later
3559 in this function when indexing through an array. This also
3560 works around GCC bug 48267.
3561
03d0a109
PE
3562 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3563
44f730c8
PE
3564 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3565
fe75f926
PE
3566 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3567 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3568
ffa8c828
PE
3569 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3570 This avoids undefined behavior on integer overflow, and is a bit
3571 more convenient anyway since it is compared to a size_t variable.
3572
c5101a77
PE
3573 Variadic C functions now count arguments with size_t, not int.
3574 This avoids an unnecessary limitation on 64-bit machines, which
3575 caused (substring ...) to crash on large vectors (Bug#8344).
3576 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3577 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 3578 All variadic functions and their callers changed accordingly.
c5101a77
PE
3579 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3580 * data.c (arith_driver, float_arith_driver): Likewise.
3581 * editfns.c (general_insert_function): Likewise.
3582 * eval.c (struct backtrace.nargs, interactive_p)
3583 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3584 (funcall_lambda, mark_backtrace): Likewise.
3585 * fns.c (concat): Likewise.
3586 * frame.c (x_set_frame_parameters): Likewise.
3587 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3588 0 if not found, not -1. All callers changed.
3589
dd3f25f7
PE
3590 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3591 (stack_copy_size): Now size_t, not int.
3592 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3593
461c2ab9
JB
35942011-03-28 Juanma Barranquero <lekktu@gmail.com>
3595
3596 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3597 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3598 All callers changed.
3599
3600 * lisp.h (multibyte_char_to_unibyte):
3601 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3602 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3603 * character.h (CHAR_TO_BYTE8):
3604 * cmds.c (internal_self_insert):
3605 * editfns.c (general_insert_function):
3606 * keymap.c (push_key_description):
3607 * search.c (Freplace_match):
3608 * xdisp.c (message_dolog, set_message_1): All callers changed.
3609
f6d62986
SM
36102011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3611
3612 * keyboard.c (safe_run_hook_funcall): New function.
3613 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3614 don't set the hook to nil, but remove the offending function instead.
3615 (Qcommand_hook_internal): Remove, unused.
3616 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3617 Vcommand_hook_internal.
3618
3619 * eval.c (enum run_hooks_condition): Remove.
3620 (funcall_nil, funcall_not): New functions.
3621 (run_hook_with_args): Call each function through a `funcall' argument.
3622 Remove `cond' argument, now redundant.
3623 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3624 (Frun_hook_with_args_until_failure): Adjust accordingly.
3625 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3626
1db5b1ad
JB
36272011-03-28 Juanma Barranquero <lekktu@gmail.com>
3628
3629 * dispextern.h (string_buffer_position): Remove declaration.
3630
3631 * print.c (strout): Remove parameter `multibyte', unused since
3632 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3633
3634 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3635 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3636 All callers changed.
3637
3638 * w32.c (_wsa_errlist): Use braces for struct initializers.
3639
3640 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3641 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3642 All callers changed.
3643 (string_buffer_position): Likewise. Also, make static (it's never
3644 used outside xdisp.c).
3645 (cursor_row_p): Remove parameter `w', unused since
3646 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3647 (decode_mode_spec): Remove parameter `precision', introduced during
3648 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3649 All callers changed.
3650
5ffb62aa
JD
36512011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3652
3653 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3654
461c2ab9 36552011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
3656
3657 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3658 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3659 (ns_update_auto_hide_menu_bar): New functions.
3660 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3661 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3662 ns_constrain_all_frames.
3663 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3664 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3665
5c380ffb
JD
36662011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3667
3668 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3669
9af30bdf
GM
36702011-03-27 Glenn Morris <rgm@gnu.org>
3671
3672 * syssignal.h: Replace RETSIGTYPE with void.
3673 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3674 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3675 Replace SIGTYPE with void everywhere.
3676 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3677 * s/template.h (SIGTYPE): Remove commented out definition.
3678
e2abce01
JB
36792011-03-26 Eli Zaretskii <eliz@gnu.org>
3680
3681 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3682 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3683
f868cd8a
JB
36842011-03-26 Juanma Barranquero <lekktu@gmail.com>
3685
59eb0929
JB
3686 * w32.c (read_unc_volume): Use parameter `henum', instead of
3687 global variable `wget_enum_handle'.
3688
3689 * keymap.c (describe_vector): Remove parameters `indices' and
3690 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3691 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3692
f868cd8a
JB
3693 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3694
3695 * keyboard.c (timer_check): Remove parameter `do_it_now',
3696 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3697 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3698 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3699
3700 * keyboard.c (read_char):
3701 * w32menu.c (w32_menu_display_help):
3702 * xmenu.c (show_help_event, menu_help_callback):
3703 Adjust calls to `show_help_echo'.
3704
3705 * gtkutil.c (xg_maybe_add_timer):
3706 * keyboard.c (readable_events):
3707 * process.c (wait_reading_process_output):
3708 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3709
3710 * insdel.c (adjust_markers_gap_motion):
3711 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3712 (gap_left, gap_right): Don't call it.
3713
2ecf6fdb
CY
37142011-03-25 Chong Yidong <cyd@stupidchicken.com>
3715
3716 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3717 incurred during fontification.
3718
6b1f9ba4
JB
37192011-03-25 Juanma Barranquero <lekktu@gmail.com>
3720
3721 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3722 (DEFVAR_PER_BUFFER): Don't pass it.
3723
3724 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3725 (scrolling_window): Don't pass it.
3726
0f4a96b5
JB
37272011-03-25 Juanma Barranquero <lekktu@gmail.com>
3728
3729 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3730
3731 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3732 and `suffix'.
3733 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3734 of variables specific to SELinux and computation of `encoded_absname'.
3735
3736 * image.c (XPutPixel): Remove unused variable `height'.
3737
3738 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3739
3740 * unexw32.c (get_section_info): Remove unused variable `section'.
3741
3742 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3743 (system_process_attributes): Remove unused variable `sess'.
3744 (sys_read): Remove unused variable `err'.
3745
3746 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3747 (w32_wnd_proc): Remove unused variable `isdead'.
3748 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3749 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3750 (x_create_tip_frame): Remove unused variable `tem'.
3751
3752 * w32inevt.c (w32_console_read_socket):
3753 Remove unused variable `no_events'.
3754
3755 * w32term.c (x_draw_composite_glyph_string_foreground):
3756 Remove unused variable `width'.
3757
1149507c
JB
37582011-03-24 Juanma Barranquero <lekktu@gmail.com>
3759
3760 * w32term.c (x_set_glyph_string_clipping):
3761 Don't pass uninitialized region to CombineRgn.
3762
9c88f339
JB
37632011-03-23 Juanma Barranquero <lekktu@gmail.com>
3764
3765 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3766 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3767 (Fx_close_connection): Remove unused variable `i'.
3768
3769 * w32font.c (w32font_draw): Return number of glyphs.
3770 (w32font_open_internal): Remove unused variable `i'.
3771 (w32font_driver): Add missing initializer.
3772
3773 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3774 (fill_in_menu): Remove unused variable `items_added'.
3775
3776 * w32term.c (last_mouse_press_frame): Remove static global variable.
3777 (w32_clip_to_row): Remove unused variable `f'.
3778 (x_delete_terminal): Remove unused variable `i'.
3779
3780 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3781 (NOTHING): Remove unused static global variable.
3782 (uniscribe_check_otf): Remove unused variable `table'.
3783 (uniscribe_font_driver): Add missing initializers.
3784
dee091a3
JD
37852011-03-23 Julien Danjou <julien@danjou.info>
3786
3787 * term.c (Fsuspend_tty, Fresume_tty):
3788 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3789 * window.c (temp_output_buffer_show):
3790 * insdel.c (signal_before_change):
3791 * frame.c (Fhandle_switch_frame):
3792 * fileio.c (Fdo_auto_save):
3793 * emacs.c (Fkill_emacs):
3794 * editfns.c (save_excursion_restore):
3795 * cmds.c (internal_self_insert):
3796 * callint.c (Fcall_interactively):
3797 * buffer.c (Fkill_all_local_variables):
3798 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3799 Use Frun_hooks.
0f4a96b5 3800 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
3801 unconditionnaly since it does the check itself.
3802
2c520ab5 38032011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 3804
c9c49752
PE
3805 Fix more problems found by GCC 4.5.2's static checks.
3806
8abc3f12
PE
3807 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3808 the first time through the loop, since we know p0 < p1 then.
3809 This also avoids a gcc -Wstrict-overflow warning.
3810
a2d26660
PE
3811 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3812 leading to a memory leak, possible in functions like
3813 load_charset_map_from_file that can allocate an unbounded number
b12ef411 3814 of objects (Bug#8318).
a2d26660 3815
916c72e9
PE
3816 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3817 that could (at least in theory) be that large.
3818
19ab8a18
PE
3819 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3820 This is less likely to overflow, and avoids undefined behavior if
3821 overflow does occur. All callers changed. Use strtoul to scan
3822 for the unsigned long integer.
b7cbbd6f
PE
3823 (pint2hrstr): Simplify and tune code slightly.
3824 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 3825
f0641eff
PE
3826 * scroll.c (do_scrolling): Work around GCC bug 48228.
3827 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3828
7f650bb9
PE
3829 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3830 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
3831 (validate_x_resource_name): Simplify count usage.
3832 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 3833
37dd57d1
PE
3834 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3835 fail (Bug#8306).
81e56e61 3836
699979fc 3837 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 3838
401bf9b4
PE
3839 * process.c (Fmake_network_process): Use socklen_t, not int,
3840 where POSIX says socklen_t is required in portable programs.
3841 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 3842 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
3843 (Fmake_network_process, server_accept_connection):
3844 (wait_reading_process_output, read_process_output):
3845 Likewise.
3846
b93aacde
PE
3847 * process.c: Rename or move locals to avoid shadowing.
3848 (list_processes_1, Fmake_network_process):
3849 (read_process_output_error_handler, exec_sentinel_error_handler):
3850 Rename or move locals.
4dc343ee 3851 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 3852 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 3853 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 3854 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 3855 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 3856
af8a867c 3857 Make tparam.h and terminfo.c consistent.
44f230aa
SM
3858 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3859 Include tparam.h instead, since it declares them.
af8a867c
PE
3860 * cm.h (PC): Remove extern decl; tparam.h now does this.
3861 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3862 * terminfo.c: Include tparam.h, to check interfaces.
3863 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3864 (tparam): Adjust signature to match interface in tparam.h;
3865 this removes some undefined behavior. Check that outstring and len
3866 are zero, which they always are with Emacs.
3867 * tparam.h (PC, BC, UP): New extern decls.
3868
0248044d 3869 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 3870 (xftfont_open): Rename locals to avoid shadowing.
0248044d 3871
8ff096c1 3872 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
3873 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3874 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 3875 (ftfont_list): Remove unused local.
49eaafba
PE
3876 (get_adstyle_property, ftfont_pattern_entity):
3877 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3878 Rename locals to avoid shadowing.
8ff096c1 3879
e2be39f6
PE
3880 * xfont.c (xfont_list_family): Mark var as initialized.
3881
c9735e30
PE
3882 * xml.c (make_dom): Now static.
3883
8f5201ae
PE
3884 * composite.c (composition_compute_stop_pos): Rename local to
3885 avoid shadowing.
b246f932
PE
3886 (composition_reseat_it): Remove unused locals.
3887 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 3888 (composition_update_it): Mark var as initialized.
11b61122
PE
3889 (find_automatic_composition): Mark vars as initialized,
3890 with a FIXME (Bug#8290).
8f5201ae 3891
760fbc2c
PE
3892 character.h: Rename locals to avoid shadowing.
3893 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3894 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3895 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3896 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3897 to avoid shadowing.
3898
ff08eb85
PE
3899 * textprop.c (property_change_between_p): Remove; unused.
3900
fc7bf025
PE
3901 * intervals.c (interval_start_pos): Now static.
3902
235d7abc
PE
3903 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3904
44f230aa
SM
3905 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3906 Rename locals to avoid shadowing.
3e7d6594 3907
50060332
PE
3908 * sound.c (wav_play, au_play, Fplay_sound_internal):
3909 Fix pointer signedness.
d01f234b 3910 (alsa_choose_format): Remove unused local var.
c83b8872
PE
3911 (wav_play): Initialize a variable to 0, to prevent undefined
3912 behavior (Bug#8278).
50060332 3913
c4fc4e30
PE
3914 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3915
918436ed
PE
3916 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3917
c939f91b
PE
3918 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3919 clobbering (Bug#8298).
b9c7f648
PE
3920 * sysdep.c (sys_subshell): Likewise.
3921 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 3922
6bd8c144
PE
3923 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3924 This should get cleaned up, so that child_setup has the
3925 same signature on all platforms.
3926
7710357c 3927 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 3928 (relocate_fd): Rename locals to avoid shadowing.
7710357c 3929
c59da222
CY
39302011-03-22 Chong Yidong <cyd@stupidchicken.com>
3931
3932 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3933 not to be necessary, and produces flickering.
3934
66b87493
GM
39352011-03-20 Glenn Morris <rgm@gnu.org>
3936
3937 * config.in: Remove file.
3938
45b6f6d5
JB
39392011-03-20 Juanma Barranquero <lekktu@gmail.com>
3940
3941 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3942 are now in src/globals.h.
3943 (syms_of_minibuf): Remove spurious & from previous change.
3944
3ec03f7e
LL
39452011-03-20 Leo <sdl.web@gmail.com>
3946
3947 * minibuf.c (completing-read-function): New variable.
3948 (completing-read-default): Rename from completing-read.
3949 (completing-read): Call completing-read-function.
3950
b14e3e21
CY
39512011-03-19 Juanma Barranquero <lekktu@gmail.com>
3952
3953 * xfaces.c (Fx_load_color_file):
3954 Read color file from absolute filename (bug#8250).
3955
f2b726e6
JB
39562011-03-19 Juanma Barranquero <lekktu@gmail.com>
3957
3958 * makefile.w32-in: Update dependencies.
3959
09f6ff02
EZ
39602011-03-17 Eli Zaretskii <eliz@gnu.org>
3961
3962 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3963
29a6015a
PE
39642011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3965
a3a6c54e
PE
3966 Fix more problems found by GCC 4.5.2's static checks.
3967
b766f867
PE
3968 * process.c (make_serial_process_unwind, send_process_trap):
3969 (sigchld_handler): Now static.
3970
be02381c
PE
3971 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3972 That way, the code declares only the vars that it needs.
3973 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3974 * s/cygwin.h (PTY_ITERATION): Likewise.
3975 * s/darwin.h (PTY_ITERATION): Likewise.
3976 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3977
57048744
PE
3978 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3979 * process.c (allocate_pty): Don't declare stb unless it's needed.
3980
7914961c 3981 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
3982 (CONSTANTLIM): Remove; unused.
3983 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3984 Define only if needed.
7914961c 3985
b3967b18
PE
3986 * unexelf.c (unexec): Name an expression,
3987 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
3988 Use a different way to cause a compilation error if anyone uses
3989 n rather than nn, a way that does not involve shadowing.
73366a00 3990 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 3991
29a6015a
PE
3992 * deps.mk (unexalpha.o): Remove; unused.
3993
43cfc33e 3994 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 3995 * unexec.h: New file.
ce701a33
PE
3996 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3997 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3998 Depend on unexec.h.
3999 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4000 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4001 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 4002 Change as necessary to match prototype in unexec.h.
ce701a33 4003
01f44d5a
PE
4004 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4005 shadowing.
4f63c6bb 4006 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 4007
a6670b0b
PE
4008 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4009 Rename locals to avoid shadowing.
4010
cef2010d 4011 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 4012 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 4013
d4d7173a
PE
4014 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4015
f08b802a
PE
4016 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4017 warning when compiling print.c.
4018
3ddb0639
PE
4019 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4020 instead of using an uninitialized var.
5ad03b97 4021 (font_sort_entities): Mark var as initialized.
3ddb0639 4022
170a2692
PE
4023 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4024
e663c700
PE
4025 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4026 pointers to constants.
89bc529a 4027 (font_parse_fcname): Remove unused vars.
7b81e2d0 4028 (font_delete_unmatched): Now static.
ea838e10 4029 (font_get_spec): Remove; unused.
13a547c6
PE
4030 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4031 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4032 Rename or move locals to avoid shadowing.
e663c700 4033
2a80c887 4034 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 4035 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 4036
1384fa33 4037 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 4038 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 4039
8b2c52e9
PE
4040 * alloc.c (mark_backtrace): Move decl from here ...
4041 * lisp.h: ... to here, so that it can be checked.
4042
475545b5 4043 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 4044 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
4045 (lisp_indirect_variable): Name an expression,
4046 to avoid gcc -Wbad-function-cast warning.
1faed8ae 4047 (Fdefvar): Rename locals to avoid shadowing.
475545b5 4048
b1349114 4049 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 4050 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 4051 Use const pointer when appropriate.
b1349114 4052
a2928364
PE
4053 * lisp.h (get_system_name, get_operating_system_release):
4054 Move decls here, to check interfaces.
4055 * process.c (get_operating_system_release): Move decl to lisp.h.
4056 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
4057 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4058 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4059 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
4060 (Fformat_time_string, Fencode_time, Finsert_char):
4061 (Ftranslate_region_internal, Fformat):
4062 Rename or remove local vars to avoid shadowing.
9710023e 4063 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 4064
a415e694
PE
4065 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4066 avoid shadowing.
4067
8ef4622d
PE
4068 * lisp.h (eassert): Check that the argument compiles, even if
4069 ENABLE_CHECKING is not defined.
4070
946f9a5b
PE
4071 * data.c (Findirect_variable): Name an expression, to avoid
4072 gcc -Wbad-function-cast warning.
112396d6 4073 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 4074 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
4075 (Fmake_variable_buffer_local, Fmake_local_variable):
4076 Mark variables as initialized.
52746918 4077 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 4078
e5aab7e7 4079 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
4080 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4081 Rename locals to avoid shadowing.
dff45157
PE
4082 (mark_stack): Move local variables into the #ifdef region where
4083 they're used.
7bc26fdb
PE
4084 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4085 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4086 needed otherwise.
4087 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4088 (GC_STRING_CHARS): Remove; not used.
d40d4be1 4089 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 4090
e5aab7e7
PE
4091 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4092 avoids undefined behavior in theory.
4093
4da60324
PE
4094 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4095
88043301
PE
4096 Use functions, not macros, for up- and down-casing (Bug#8254).
4097 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4098 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4099 to use the following functions instead of these macros.
4100 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4101 EMACS_INT, since callers assume the returned value fits in int.
4102 (upcase1): Likewise, for UPCASE_TABLE.
4103 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 4104 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 4105 the race-condition problem in the old DOWNCASE.
88043301 4106
19ed5445
PE
4107 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4108 Rename locals to avoid shadowing.
4109 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
4110 (regex_compile, re_search_2, re_match_2_internal):
4111 Remove unused local vars.
952db0d7
PE
4112 (FREE_VAR): Rewrite so as not to use empty "else",
4113 which gcc can warn about.
da053e48 4114 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
4115 (RETALLOC_IF): Define only if needed.
4116 (WORDCHAR_P): Likewise. This one is never needed, but is used
4117 only in a comment talking about a compiler bug, so put inside
4118 the #if 0 of that comment.
4119 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4120 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4121 Remove; unused.
19ed5445 4122
1f3561e4 4123 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
4124 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4125 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 4126
ded6f8f7
PE
4127 * search.c (simple_search): Remove unused var.
4128
dbd37a95
PE
4129 * dired.c (compile_pattern): Move decl from here ...
4130 * lisp.h: ... to here, so that it can be checked.
4131 (struct re_registers): New forward decl.
4132
7e47afad
PE
4133 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4134
85f24f61
PE
4135 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4136 All uses changed.
4137 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4138 Rename locals to avoid shadowing.
5671df8f 4139 (Fvertical_motion): Mark locals as initialized.
85f24f61 4140
181aa2be 4141 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 4142 (casify_region): Mark local as initialized.
181aa2be 4143
930d429c
PE
4144 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4145
7082eac6
PE
4146 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4147 New macros, so that the caller can use some names other than
4148 gcpro1, gcpro2, etc.
4149 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4150 of the new macros.
4151 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4152 argument, for consistency with GCPRO2_VAR, etc: it is now the
4153 prefix of the variable, not the variable itself. All uses
4154 changed.
38b2c076
PE
4155 * dired.c (directory_files_internal, file_name_completion):
4156 Rename locals to avoid shadowing.
4157
15206ed9
PE
4158 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4159 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4160 dired.c's scmp function, had undefined behavior.
4161 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4162 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4163 * buffer.h: ... to here, because these macros use current_buffer,
4164 and the new implementation with inline functions needs to have
4165 current_buffer in scope now, rather than later when the macros
4166 are used.
4167 (downcase, upcase1): New static inline functions.
4168 (DOWNCASE, UPCASE1): Reimplement using these functions.
4169 This avoids undefined behavior in expressions like
4170 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4171 from race conditions in accessing the global variables
4172 case_temp1 and case_temp2.
4173 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4174 * lisp.h (case_temp1, case_temp2): Remove their decls.
4175 * character.h (ASCII_CHAR_P): Move from here ...
4176 * lisp.h: ... to here, so that the inline functions mentioned
4177 above can use them.
4178
4a6bea26
PE
4179 * dired.c (directory_files_internal_unwind): Now static.
4180
f14b7e14
PE
4181 * fileio.c (file_name_as_directory, directory_file_name):
4182 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4183 Now static.
2893f146
PE
4184 (file_name_as_directory): Use const pointers when appropriate.
4185 (Fexpand_file_name): Likewise. In particular, newdir might
4186 point at constant storage, so make it a const pointer.
fd4ead52 4187 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
4188 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4189 signedness issues.
f839df0c
PE
4190 (Fset_file_times, Finsert_file_contents, auto_save_error):
4191 Rename locals to avoid shadowing.
f14b7e14 4192
5716756e 4193 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
4194 (Ftry_completion, Fall_completions): Rename or remove locals
4195 to avoid shadowing.
5716756e 4196
b4c3046a
PE
4197 * marker.c (bytepos_to_charpos): Remove; unused.
4198
b45db522
PE
4199 * lisp.h (verify_bytepos, count_markers): New decls,
4200 so that gcc does not warn that these functions aren't declared.
4201
85876d07
PE
4202 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4203 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 4204 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 4205 (copy_text): Remove unused local var.
85876d07 4206
03d78a21 4207 * filelock.c (within_one_second): Now static.
b3dd38ab 4208 (lock_file_1): Rename local to avoid shadowing.
03d78a21 4209
5df8f01b
PE
4210 * buffer.c (fix_overlays_before): Mark locals as initialized.
4211 (fix_start_end_in_overlays): Likewise. This function should be
4212 simplified by using pointers-to-pointers, but that's a different
4213 matter.
b1d876f1 4214 (switch_to_buffer_1): Now static.
8f54f30a
PE
4215 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4216 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 4217
a70072c9 4218 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 4219 Fix pointer signedness issue.
edced198
PE
4220 (sys_subshell): Mark local as volatile if checking for lint,
4221 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 4222 (MAXPATHLEN): Define only if needed.
a70072c9 4223
a0977c44
PE
4224 * process.c (serial_open, serial_configure): Move decls from here ...
4225 * systty.h: ... to here, so that they can be checked.
4226
a884fdcc
PE
4227 * fns.c (get_random, seed_random): Move extern decls from here ...
4228 * lisp.h: ... to here, so that they can be checked.
4229
604efe86 4230 * sysdep.c (reset_io): Now static.
b8950c94 4231 (wait_for_termination_signal): Remove; unused.
604efe86 4232
38fc62d9
PE
4233 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4234 (copy_keymap_item, append_key, push_text_char_description):
4235 Now static.
1004a21a 4236 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 4237 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
4238 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4239 (describe_map_tree):
4240 Rename locals to avoid shadowing.
38fc62d9 4241
2f2650da
PE
4242 * keyboard.c: Declare functions static if they are not used elsewhere.
4243 (echo_char, echo_dash, cmd_error, top_level_2):
4244 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
4245 (read_char, kbd_buffer_get_event, make_lispy_position):
4246 (make_lispy_event, make_lispy_movement, apply_modifiers):
4247 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4248 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4249 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 4250 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 4251 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 4252
a053e86c 4253 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
4254 (mark_kboards): Move decl here ...
4255 * alloc.c (mark_kboards): ... from here.
a053e86c 4256
4752793e
PE
4257 * lisp.h (force_auto_save_soon): New decl.
4258
74f10ca7 4259 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
4260 (DEFINE_DUMMY_FUNCTION): New macro.
4261 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4262 Use it.
c03cd23f
PE
4263 (main): Add casts to avoid warnings
4264 if GCC considers string literals to be constants.
74f10ca7 4265
022e70d4
PE
4266 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4267
59d6fe83
PE
4268 * dbusbind.c: Pointer signedness fixes.
4269 (xd_signature, xd_append_arg, xd_initialize):
4270 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4271 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4272 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4273 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4274
78320123
PE
4275 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4276 if GCC considers string literals to be constants.
49cebcca 4277 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 4278
35ac2a97
SM
42792011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4280
fb103ca9
SM
4281 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4282 (print_preprocess, print_object): New macro to fix last change.
4283
35ac2a97
SM
4284 * print.c (print_preprocess): Don't forget font objects.
4285
62973b41
JB
42862011-03-16 Juanma Barranquero <lekktu@gmail.com>
4287
4288 * emacs.c (USAGE3): Doc fixes.
4289
0e48bb22
AS
42902011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4291
4292 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4293 structure.
4294
7684e57b
JB
42952011-03-14 Juanma Barranquero <lekktu@gmail.com>
4296
4297 * lisp.h (VWindow_system, Qfile_name_history):
4298 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4299 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4300 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4301
4302 * w32select.c: Don't #include "keyboard.h".
c96bbc66 4303 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
4304
4305 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4306 * w32console.c (detect_input_pending, read_input_pending)
4307 (encode_terminal_code):
4308 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4309 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4310 (w32_system_caret_y, Qfile_name_history):
4311 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4312 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4313 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4314 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4315 * w32proc.c (Qlocal, report_file_error):
4316 * w32term.c (Vwindow_system, updating_frame):
4317 * w32uniscribe.c (initialized, uniscribe_font_driver):
4318 Remove unneeded extern declarations.
4319
2aa46d6c
CY
43202011-03-14 Chong Yidong <cyd@stupidchicken.com>
4321
c96bbc66 4322 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 4323
cffc6f3b
CY
43242011-03-13 Chong Yidong <cyd@stupidchicken.com>
4325
4326 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4327 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4328 These macros can no longer be used for assignment.
4329
44f230aa
SM
4330 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4331 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
4332 (record_buffer_markers, fetch_buffer_markers): New functions for
4333 recording and fetching special buffer markers.
4334 (set_buffer_internal_1, set_buffer_temp): Use them.
4335
4336 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4337
4338 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4339
4340 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4341 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4342
4343 * xdisp.c (hscroll_window_tree):
4344 (reconsider_clip_changes): Use PT instead of BUF_PT.
4345
d251f04b
EZ
43462011-03-13 Eli Zaretskii <eliz@gnu.org>
4347
4348 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4349 $(EMACS_ROOT)/lib/intprops.h.
4350
f0c77cd1
PE
43512011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4352
3eca4629
PE
4353 Fix more problems found by GCC 4.5.2's static checks.
4354
7c86ee98
PE
4355 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4356 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
4357 (xg_free_frame_widgets): Make it clear that a local variable is
4358 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
4359 (gdk_window_get_screen): Make it clear that this macro is needed
4360 only if USE_GTK_TOOLTIP.
1e5524e7
PE
4361 (int_gtk_range_get_value): New function, which avoids a diagnostic
4362 from gcc -Wbad-function-cast.
4363 (xg_set_toolkit_scroll_bar_thumb): Use it.
4364 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4365 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
4366 (get_utf8_string, xg_get_file_with_chooser):
4367 Rename locals to avoid shadowing.
4368 (create_dialog): Move locals to avoid shadowing.
7c86ee98 4369
41729b81
PE
4370 * xgselect.c (xg_select): Remove unused var.
4371
f0c77cd1
PE
4372 * image.c (four_corners_best): Mark locals as initialized.
4373 (gif_load): Initialize transparent_p to zero (Bug#8238).
4374 Mark another local as initialized.
ec6cf4c6 4375 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 4376
ce0ad53d 4377 * image.c (clear_image_cache): Now static.
d5d5a617 4378 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 4379 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
4380 (x_edge_detection): Remove unnecessary cast that
4381 gcc -Wbad-function-cast diagnoses.
2037898d 4382 (gif_load): Fix pointer signedness.
6ae141d6
PE
4383 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4384 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 4385
33383987 43862011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 4387
d32df629
PE
4388 Improve quality of tests for time stamp overflow.
4389 For example, without this patch (encode-time 0 0 0 1 1
4390 1152921504606846976) returns the obviously-bogus value (-948597
4391 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4392 reports time overflow. See
4393 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
4394 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4395 * editfns.c: Include limits.h and intprops.h.
4396 (TIME_T_MIN, TIME_T_MAX): New macros.
4397 (time_overflow): Move earlier, to before first use.
4398 (hi_time, lo_time): New functions, for an accurate test for
4399 out-of-range times.
4400 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4401 (Fget_internal_run_time): Don't assume time_t fits in int.
4402 (make_time): Use list2 instead of Fcons twice.
4403 (Fdecode_time): More accurate test for out-of-range times.
4404 (check_tm_member): New function.
4405 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
4406 (lisp_time_argument): Don't rely on undefined left-shift and
4407 right-shift behavior when checking for time stamp overflow.
8be6f318 4408
fe31d94c
PE
4409 * editfns.c (time_overflow): New function, refactoring common code.
4410 (Fformat_time_string, Fdecode_time, Fencode_time):
4411 (Fcurrent_time_string): Use it.
4412
8be6f318
PE
4413 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4414 * dired.c (make_time): Move to ...
4415 * editfns.c (make_time): ... here.
4416 * systime.h: Note the move.
4417
09d9db2c 44182011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 4419
126bc0dc
YM
4420 * fringe.c (update_window_fringes): Remove unused variables.
4421
c47cbdfd
YM
4422 * unexmacosx.c (copy_data_segment): Also copy __got section.
4423 (Bug#8223)
4424
7ac80be9
EZ
44252011-03-12 Eli Zaretskii <eliz@gnu.org>
4426
c96bbc66 4427 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
4428 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4429 Constify `char *' arguments and their references according to
4430 prototypes in tparam.h.
4431
ecb0f94d 4432 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 4433
7ac80be9
EZ
4434 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4435 Adapt all references accordingly.
4436
4437 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4438
ef1fd07e
TT
44392011-03-11 Tom Tromey <tromey@redhat.com>
4440
4441 * buffer.c (syms_of_buffer): Remove obsolete comment.
4442
7ef4b50c
EZ
44432011-03-11 Eli Zaretskii <eliz@gnu.org>
4444
4445 * termhooks.h (encode_terminal_code): Declare prototype.
4446
4447 * msdos.c (encode_terminal_code): Don't declare prototype.
4448
4449 * term.c (encode_terminal_code): Now external again, used by
4450 w32console.c and msdos.c.
4451
44f230aa
SM
4452 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4453 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 4454
4b1ec863 44552011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 4456
1714f52b 4457 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 4458
4b1ec863
PE
4459 * fringe.c (update_window_fringes): Mark locals as initialized
4460 (Bug#8227).
4461 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 4462
524c7aa6
PE
4463 * alloc.c (mark_fringe_data): Move decl from here ...
4464 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4465 to check its interface.
4466 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4467
a5c0af81 4468 * fontset.c (free_realized_fontset): Now static.
7519b8cd 4469 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 4470 (fontset_font): Mark local as initialized.
a9a06e0b 4471 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 4472
b4716021
PE
4473 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4474
811e9bac 4475 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 4476 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
4477 (x_own_selection, Fx_disown_selection_internal): Rename locals
4478 to avoid shadowing.
4479 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 4480
7e3ab302
PE
4481 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4482 so that the caller can use some name other than gcpro1.
4483 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
4484 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4485 (Fx_backspace_delete_keys_p):
4486 Use them to avoid shadowing, and rename vars to avoid shadowing.
4487 (x_decode_color, x_set_name, x_window): Now static.
6b437900 4488 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 4489 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
4490 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4491 Remove unused locals.
7e3ab302
PE
4492 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4493 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4494 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4495 macros.
f78faa98 4496
e2b13473
PE
4497 * xterm.h (x_mouse_leave): New decl.
4498
77f23912
PE
4499 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4500 Remove unused functions.
cdf4ba58
PE
4501 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4502 (x_calc_absolute_position): Now static.
7411c686 4503 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 4504 Don't declare local "event" unless it's used.
ed7bf3a5
PE
4505 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4506 unless they are used.
38d0b34a
PE
4507 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4508 (x_fatal_error_signal): Remove; not used.
a6067996
PE
4509 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4510 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4511 (x_error_catcher, x_connection_closed, x_error_handler):
4512 (x_error_quitter, xembed_send_message, x_iconify_frame):
4513 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 4514 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 4515 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 4516
44f230aa
SM
4517 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4518 Rename or move locals to avoid shadowing.
6b463e58 4519 (tty_defined_color, merge_face_heights): Now static.
5967d051 4520 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
4521 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4522 does not deduce is never used uninitialized.
73719eba
PE
4523 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4524 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 4525
426994c3 4526 * terminal.c (store_terminal_param): Now static.
5489860b 4527
032f1620 4528 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 4529 (set_frame_menubar): Remove unused local.
d4323972 4530 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
4531 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4532 since they might point to immutable storage.
281585b0
PE
4533 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4534 since it's unused otherwise.
032f1620 4535
367c19e5 4536 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 4537 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
4538 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4539 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 4540 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
4541 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4542 does not deduce are never used uninitialized.
70739cbe 4543
07b48fa9
PE
4544 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4545
8868a238 4546 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
4547 * window.c (window_loop, size_window):
4548 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 4549
7e5cf297 4550 * window.c (display_buffer): Now static.
d6550a9f
PE
4551 (size_window): Mark variables that gcc -Wuninitialized
4552 does not deduce are never used uninitialized.
a586633d
PE
4553 * window.h (check_all_windows): New decl, to forestall
4554 gcc -Wmissing-prototypes diagnostic.
5b555da1 4555 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 4556
f6095868
PE
4557 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4558 shadowing.
4559 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
4560 Include <limits.h>.
4561 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4562 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
4563 (load_charset_map): Mark variables that gcc -Wuninitialized
4564 does not deduce are never used uninitialized.
53df7c11 4565 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 4566
f38b440c
PE
4567 * coding.c (coding_set_source, coding_set_destination):
4568 Use "else { /* comment */ }" rather than "else /* comment */;"
4569 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
4570 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4571 a block, when the outer 'i' will do.
4572 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4573 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4574 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4575 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4576 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4577 Rename locals to avoid shadowing.
4578 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
4579 * coding.c (emacs_mule_char, encode_invocation_designation):
4580 Now static, since they're not used elsewhere.
413bb2db 4581 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 4582 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
4583 (decode_coding_emacs_mule): Mark variables that gcc
4584 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
4585 (detect_coding_iso_2022): Initialize a local variable that might
4586 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 4587 this initialization is needed. (Bug#8211)
5f58e762
PE
4588 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4589 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4590 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4591 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4592 Remove unused macros.
f38b440c 4593
232b38b9 4594 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 4595 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 4596 * character.c (string_count_byte8): Likewise.
232b38b9 4597
fb90da1b
PE
4598 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4599 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4600
fb93dbc2
PE
4601 * chartab.c (copy_sub_char_table): Now static, since it's not used
4602 elsewhere.
5c156ace
PE
4603 (sub_char_table_ref_and_range, char_table_ref_and_range):
4604 Rename locals to avoid shadowing.
bbcd0949 4605 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 4606
7d3b3862 4607 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 4608 (BIDI_BOB): Remove unused macro.
7d3b3862 4609
6be7d3da
PE
4610 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4611 deduce are never used uninitialized.
c2ed9c8b 4612 * term.c (encode_terminal_code): Likewise.
6be7d3da 4613
75f8807f 4614 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 4615
50938595
PE
4616 * tparam.h: New file.
4617 * term.c, tparam.h: Include it.
4618 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4619 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4620 Move these decls to tparam.h, and make them agree with what
4621 is actually in tparam.c. The previous trick of using incompatible
4622 decls in different modules does not conform to the C standard.
4623 All callers of tparam changed to use tparam's actual API.
4624 * tparam.c (tparam1, tparam, tgoto):
4625 Use const pointers where appropriate.
4626
fbceeba2
PE
4627 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4628 * cm.h (struct cm): Likewise.
4629 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4630 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4631 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4632 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4633 (turn_on_face, init_tty): Likewise.
4634 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 4635
7f3f1250
PE
4636 * term.c (term_mouse_position): Rename local to avoid shadowing.
4637
e6ca6543
PE
4638 * alloc.c (mark_ttys): Move decl from here ...
4639 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4640
c40f8d15
AS
46412011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4642
4643 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4644
cfe0661d
JB
46452011-03-09 Juanma Barranquero <lekktu@gmail.com>
4646
4647 * search.c (compile_pattern_1): Remove argument regp, unused since
4648 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4649 (compile_pattern): Don't pass it.
4650
0afb4571
J
46512011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4652
4653 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4654 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4655 for ! HAVE_GTK3.
4656 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4657
4658 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4659
4660 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4661 gdk_window_get_screen, gdk_window_get_geometry,
4662 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4663 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4664 (xg_get_pixbuf_from_pixmap): New function.
4665 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4666 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4667 Call xg_get_pixbuf_from_pixmap instead of
4668 gdk_pixbuf_get_from_drawable.
4669 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4670 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4671 (xg_check_special_colors): Use GtkStyleContext and its functions
4672 for HAVE_GTK3.
4673 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4674 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4675 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
4676 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4677 Call gtk_widget_get_preferred_size.
0afb4571
J
4678 (xg_frame_resized): gdk_window_get_geometry only takes 5
4679 parameters.
44f230aa
SM
4680 (xg_win_to_widget, xg_event_is_for_menubar):
4681 Call gdk_x11_window_lookup_for_display.
0afb4571
J
4682 (xg_set_widget_bg): New function.
4683 (delete_cb): New function.
895009e1 4684 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
4685 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4686 (xg_set_background_color): Call xg_set_widget_bg.
4687 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4688 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4689 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4690 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4691 if ! HAVE_GTK3.
4692 (update_frame_tool_bar): Call gtk_widget_hide.
4693 (xg_initialize): Use GDK_KEY_g.
4694
4695 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4696 if ! HAVE_GTK3
4697 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4698
4699 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4700 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4701 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4702
1c2cc4ef
JB
47032011-03-08 Juanma Barranquero <lekktu@gmail.com>
4704
4705 * w32xfns.c (select_palette): Check success of RealizePalette against
4706 GDI_ERROR, not zero.
4707
33383987 4708See ChangeLog.11 for earlier changes.
aac0c6e3
MR
4709
4710;; Local Variables:
4711;; coding: utf-8
aac0c6e3
MR
4712;; End:
4713
33383987 4714 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
4715
4716 This file is part of GNU Emacs.
4717
4718 GNU Emacs is free software: you can redistribute it and/or modify
4719 it under the terms of the GNU General Public License as published by
4720 the Free Software Foundation, either version 3 of the License, or
4721 (at your option) any later version.
4722
4723 GNU Emacs is distributed in the hope that it will be useful,
4724 but WITHOUT ANY WARRANTY; without even the implied warranty of
4725 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4726 GNU General Public License for more details.
4727
4728 You should have received a copy of the GNU General Public License
4729 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.