* charset.c (load_charset_map): <, not <=, for optimization.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
762f8d96 12011-04-09 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 2
3befa583
PE
3 * charset.c (load_charset_map): <, not <=, for optimization.
4
e3019616
PE
5 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6 This also lets GCC 4.6.0 generate slightly better loop code.
7
becfa255
PE
8 * callint.c (Fcall_interactively): <, not <=, for optimization.
9 (Fcall_interactively): Count the number of arguments produced,
10 not the number of arguments given. This is simpler and lets GCC
11 4.6.0 generate slightly better code.
12
dae0cd48
PE
13 * ftfont.c: Distingish more carefully between FcChar8 and char.
14 The previous code passed unsigned char * to a functions like
15 strlen and xstrcasecmp that expect char *, which does not
16 conform to the C standard.
17 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
18 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
19 char * when the C standard requires it.
20
76032d70
PE
21 * keyboard.c (read_char): Remove unused var.
22
eb3f1cc8
PE
23 * eval.c: Port to Windows vsnprintf (Bug#8435).
24 Include <limits.h>.
25 (SIZE_MAX): Define if the headers do not.
26 (verror): Do not give up if vsnprintf returns a negative count.
27 Instead, grow the buffer. This ports to Windows vsnprintf, which
28 does not conform to C99. Problem reported by Eli Zaretskii.
29 Also, simplify the allocation scheme, by avoiding the need for
30 calling realloc, and removing the ALLOCATED variable.
31
70476b54
PE
32 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
33
ea6c7ae6
PE
34 Remove the doprnt implementation, as Emacs now uses vsnprintf.
35 * doprnt.c: Remove.
36 * lisp.h (doprnt): Remove.
37 * Makefile.in (base_obj): Remove doprnt.o.
38 * deps.mk (doprnt.o): Remove.
39
5fdb398c
PE
40 error: Print 32- and 64-bit integers portably (Bug#8435).
41 Without this change, on typical 64-bit hosts error ("...%d...", N)
42 was used to print both 32- and 64-bit integers N, which relied on
43 undefined behavior.
44 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
45 New macro.
46 * lisp.h (error, verror): Mark as printf-like functions.
47 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
48 Report overflow in size calculations when allocating printf buffer.
49 Do not truncate output string at its first null byte.
50 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
51 Truncate the output at a character boundary, since vsnprintf does not
52 do that.
53 * charset.c (check_iso_charset_parameter): Convert internal
54 character to string before calling 'error', since %c now has the
55 printf meaning.
56 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
57 overflow when computing char to be passed to 'error'. Do not
58 pass Lisp_Object to 'error'; pass the integer instead.
59 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
60 formatted with plain %d.
61
b189fa66
PE
62 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
63
bff87ef0
PE
64 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
65
7e2cac20
PE
66 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
67
ce4d90b5
PE
68 * xterm.c (x_catch_errors): Remove duplicate declaration.
69
266c9547
PE
70 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
71
79c49ad2
PE
72 * xdisp.c, lisp.h (message_nolog): Remove; unused.
73
8546720e 742011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 75
8546720e
GM
76 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
77 unsigned char, to match FcChar8 type definition.
aac0c6e3 78
8546720e
GM
79 * xterm.c (handle_one_xevent):
80 * xmenu.c (create_and_show_popup_menu):
81 * xselect.c (x_decline_selection_request)
82 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 83
a53e2e89
EZ
842011-04-09 Eli Zaretskii <eliz@emacstest.gnu.org>
85
86 Fix some uses of `int' instead of EMACS_INT.
87 * search.c (string_match_1, fast_string_match)
88 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
89 (scan_buffer, find_next_newline_no_quit)
90 (find_before_next_newline, search_command, Freplace_match)
91 (Fmatch_data): Make some `int' variables be EMACS_INT.
92
93 * xdisp.c (display_count_lines): 3rd argument and return value now
94 EMACS_INT. All callers changed.
95 (pint2hrstr): Last argument is now EMACS_INT.
96
97 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
98 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
99 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
100 (decode_coding_utf_16, decode_coding_emacs_mule)
101 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
102 (decode_coding_ccl, decode_coding_charset)
103 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
104 (decode_coding_iso_2022, decode_coding_emacs_mule)
105 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
106 <char_offset, last_offset>: Declare EMACS_INT.
107 (encode_coding_utf_8, encode_coding_utf_16)
108 (encode_coding_emacs_mule, encode_invocation_designation)
109 (encode_designation_at_bol, encode_coding_iso_2022)
110 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
111 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
112 Declare EMACS_INT.
113 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
114 (encode_invocation_designation): Last argument P_NCHARS is now
115 EMACS_INT.
116 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
117 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
118
119 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
120 All users changed.
121
122 * ccl.c (Fccl_execute_on_string): Declare some variables
123 EMACS_INT.
124
8546720e 1252011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
126
127 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
128
4e19a977
CS
1292011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
130
131 * process.c (Fformat_network_address): Doc fix.
132
87302331
R
1332011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
134
135 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
136
cbb59342
CY
1372011-04-08 Chong Yidong <cyd@stupidchicken.com>
138
139 * keyboard.c (read_char): Call Lisp function help-form-show,
140 instead of using internal_with_output_to_temp_buffer.
141 (Qhelp_form_show): New var.
e0d38eeb 142 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
143
144 * print.c (internal_with_output_to_temp_buffer): Function deleted.
145
146 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
147
e67a13ab
CY
1482011-04-06 Chong Yidong <cyd@stupidchicken.com>
149
150 * process.c (Flist_processes): Removed to Lisp.
151 (list_processes_1): Deleted.
152
973f782d
EZ
1532011-04-06 Eli Zaretskii <eliz@gnu.org>
154
7c106b1e
EZ
155 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
156
973f782d
EZ
157 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
158
41cf7d1a 1592011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 160
ca23cc88
PE
161 Fix more problems found by GCC 4.6.0's static checks.
162
f390e2d5
PE
163 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
164
42eea0d0
PE
165 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
166
b69769da 167 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 168
f9541e84
PE
169 * xdisp.c (vmessage): Mark as a printf-like function.
170
13841b55
PE
171 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
172
c136c10f
PE
173 * sound.c (sound_warning): Don't crash if arg contains a printf format.
174
5e2d4a30
PE
175 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
176 printf-like functions.
177 (tiff_load): Add casts to remove these marks before passing them
178 to system-supplied API.
179
583f48b9
PE
180 * eval.c (Fsignal): Remove excess argument to 'fatal'.
181
b25d760e
PE
182 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
183 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
184 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
185 directly, rather than having caller test rule sign. This avoids
186 some unnecessary tests.
187 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
188 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
189 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 190
bc7b6697 191 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 192 (xfont_open): Avoid unnecessary tests.
bc7b6697 193
27ccc379
PE
194 * composite.c (composition_gstring_put_cache): Use unsigned integer.
195
dcd5c89a
PE
196 * composite.h, composite.c (composition_gstring_put_cache):
197 Use EMACS_INT, not int, for length.
198
b13a45c6
PE
199 * composite.h (COMPOSITION_DECODE_REFS): New macro,
200 breaking out part of COMPOSITION_DECODE_RULE.
201 (COMPOSITION_DECODE_RULE): Use it.
202 * composite.c (get_composition_id): Remove unused local vars,
203 by using the new macro.
204
1e792e4d
PE
205 * textprop.c (set_text_properties_1): Change while to do-while,
206 since the condition is always true at first.
207
dc6c6455 208 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
209 (interval_deletion_adjustment): Return unsigned value.
210 All uses changed.
dc6c6455 211
aba7731a
PE
212 * process.c (list_processes_1, create_pty, read_process_output):
213 (exec_sentinel): Remove vars that were set but not used.
afd4052b 214 (create_pty): Remove unnecessary "volatile"s.
bc57d757 215 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 216 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 217 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 218
fdfc4bf3
PE
219 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
220
fca8fe46 221 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 222 (update_syntax_table): Use unsigned instead of int.
fca8fe46 223
06a0259a 224 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 225 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 226 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 227
e7b9e80f
PE
228 * print.c (print_error_message): Avoid int overflow.
229
56201685
PE
230 * font.c (font_list_entities): Redo for clarity,
231 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
232
78834453 233 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 234 (font_score): Avoid potential overflow in diff calculation.
78834453 235
0bc0b309 236 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 237 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 238
e610eaca
PE
239 * eval.c (funcall_lambda): Rename local to avoid shadowing.
240
b895abce
PE
241 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
242 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
243 can always succeed if overflow has undefined behavior.
244
1f1d9321 245 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 246 (wordify): Omit three unnecessary tests.
1f1d9321 247
c59478bc
PE
248 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
249 All callers changed. This avoids the need for an unused var.
250
79b73827
PE
251 * casefiddle.c (casify_region): Remove var that is set but not used.
252
a4db5dfe
PE
253 * dired.c (file_name_completion): Remove var that is set but not used.
254
43aae36e
PE
255 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
256
2a47c44d 257 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 258 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 259
a37c69bf
PE
260 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
261 Check for integer overflow on size calculations.
262
328ab8e7
PE
263 * buffer.c (Fprevious_overlay_change): Remove var that is set
264 but not used.
265
e5a2a5cb
PE
266 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
267 Remove vars that are set but not used.
8d84a6eb 268 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 269 (timer_check_2): Mark vars as initialized.
e5a2a5cb 270
a60e5f68
PE
271 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
272
f661cb61 273 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 274 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 275
f0397f5a
PE
276 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
277 that are set but not used.
278
8664db06 279 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 280 if XCreateBitmapFromData fails (Bug#8410).
8664db06 281
6abdaa4a
PE
282 * xselect.c (x_get_local_selection, x_handle_property_notify):
283 Remove vars that are set but not used.
284
0ce7538d 285 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 286 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 287
9ae848fc
PE
288 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
289 Remove var that is set but not used.
0b918413
PE
290 (scroll_bar_windows_size): Now size_t, not int.
291 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
292 Check for overflow.
9ae848fc 293
a5a62657
PE
294 * xfaces.c (realize_named_face): Remove vars that are set but not used.
295 (map_tty_color) [!defined MSDOS]: Likewise.
296
5c5cdd39
PE
297 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
298
66ebf983
PE
299 * coding.c: Remove vars that are set but not used.
300 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
301 All callers changed.
302 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
303 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
304 (decode_coding_charset): Remove vars that are set but not used.
305
1be4d761
PE
306 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
307 that is set but not used.
308
47553fa8
PE
309 * print.c (print_object): Remove var that is set but not used.
310
1f7196bf 311 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
312 The gnulib version avoids calling malloc in the usual case,
313 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
314 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
315 * filelock.c (current_lock_owner): Likewise.
316 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
317 * sysdep.c: Include allocator.h, careadlinkat.h.
318 (emacs_no_realloc_allocator): New static constant.
319 (emacs_readlink): New function.
fdb61804
PE
320 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
321 ../lib/careadlinkat.h.
d1fdcab7 322
f84c17c7
SM
3232011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
324
325 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
326 first non-nil return value).
327
ef3862ad
JD
3282011-04-03 Jan Djärv <jan.h.d@swipnet.se>
329
330 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
331 if not defined (Bug#8403).
332
376a7006
JB
3332011-04-02 Juanma Barranquero <lekktu@gmail.com>
334
335 * xdisp.c (display_count_lines): Remove parameter `start',
336 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
337 (get_char_face_and_encoding): Remove parameter `multibyte_p',
338 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
339 (fill_stretch_glyph_string): Remove parameters `row' and `area',
340 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
341 and thereabouts. All callers changed.
342 (get_per_char_metric): Remove parameter `f', unused since
343 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
344
6ca3801d
JM
3452011-04-02 Jim Meyering <meyering@redhat.com>
346
347 do not dereference NULL upon failed strdup
348 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
349 (ns_get_family): Likewise.
350
d8e2b5ba
JB
3512011-04-02 Juanma Barranquero <lekktu@gmail.com>
352
353 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
354
8c74fcbd
JD
3552011-04-02 Jan Djärv <jan.h.d@swipnet.se>
356
357 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
358 later (Bug#8403).
359
7200d79c
SM
3602011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
361
03408648 362 Add lexical binding.
7200d79c 363
03408648
SM
364 * window.c (Ftemp_output_buffer_show): New fun.
365 (Fsave_window_excursion):
366 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
367
368 * lread.c (lisp_file_lexically_bound_p): New function.
369 (Fload): Bind Qlexical_binding.
370 (readevalloop): Remove `evalfun' arg.
371 Bind Qinternal_interpreter_environment.
372 (Feval_buffer): Bind Qlexical_binding.
373 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
374 Mark as dynamic.
375 (syms_of_lread): Declare `lexical-binding'.
376
377 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
378
379 * keyboard.c (eval_dyn): New fun.
380 (menu_item_eval_property): Use it.
ca105506
SM
381
382 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 383
03408648
SM
384 * fns.c (concat, mapcar1): Accept byte-code-functions.
385
386 * eval.c (Fsetq): Handle lexical vars.
387 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
388 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
389 (FletX, Flet): Obey lexical binding.
390 (Fcommandp): Handle closures.
391 (Feval): New `lexical' arg.
392 (eval_sub): New function extracted from Feval. Use it almost
393 everywhere where Feval was used. Look up vars in lexical env.
394 Handle closures.
395 (Ffunctionp): Move from subr.el.
396 (Ffuncall): Handle closures.
397 (apply_lambda): Remove `eval_flags'.
398 (funcall_lambda): Handle closures and new byte-code-functions.
399 (Fspecial_variable_p): New function.
400 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
401 but without exporting it to Lisp.
23aba0ea 402
23aba0ea 403 * doc.c (Fdocumentation, store_function_docstring):
03408648 404 * data.c (Finteractive_form): Handle closures.
23aba0ea 405
03408648
SM
406 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
407 interactive spec.
ba83908c 408
03408648
SM
409 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
410 byte-codes.
411 (exec_byte_code): New function extracted from Fbyte_code to handle new
412 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 413
03408648 414 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 415
03408648 416 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 417
e2abce01
JB
4182011-03-31 Juanma Barranquero <lekktu@gmail.com>
419
420 * xdisp.c (redisplay_internal): Fix prototype.
421
63696a73 4222011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 423
63696a73
EZ
424 * xdisp.c (SCROLL_LIMIT): New macro.
425 (try_scrolling): Use it when setting scroll_limit. Limit
426 scrolling to 100 screen lines.
427 (redisplay_window): Even when falling back on "recentering",
428 position point in the window according to scroll-conservatively,
429 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
430
431 (try_scrolling): When point is above the window, allow searching
432 as far as scroll_max, or one screenful, to compute vertical
433 distance from PT to the scroll margin position. This prevents
434 try_scrolling from unnecessarily failing when
435 scroll-conservatively is set to a value slightly larger than the
436 window height. Clean up the case of PT below the margin at bottom
437 of window: scroll_max can no longer be INT_MAX. When aggressive
438 scrolling is in use, don't let point enter the opposite scroll
439 margin as result of the scroll.
440 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
441 threshold of 100 lines for never-recentering scrolling.
442
e4cc2dfc
JB
4432011-03-31 Juanma Barranquero <lekktu@gmail.com>
444
445 * dispextern.h (move_it_by_lines):
446 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
447 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
448 (message_log_check_duplicate): Remove parameters `prev_bol' and
449 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
450 (redisplay_internal): Remove parameter `preserve_echo_area',
451 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
452
453 * indent.c (Fvertical_motion):
454 * window.c (window_scroll_pixel_based, Frecenter):
455 Don't pass `need_y_p' to `move_it_by_lines'.
456
1c470562
SM
4572011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
458
44f230aa
SM
459 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
460 steal a few bits to be more compact.
461 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
462 Remove unneeded casts.
463
1c470562
SM
464 * bytecode.c (Fbyte_code): CAR and CDR can GC.
465
888adce9
ZK
4662011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
467
468 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
469 binding" message (bug#7967).
470
f838ed7b
PE
4712011-03-30 Paul Eggert <eggert@cs.ucla.edu>
472
77861b95
PE
473 Fix more problems found by GCC 4.6.0's static checks.
474
de6dbc14
PE
475 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
476 Remove unused local var.
477
f838ed7b
PE
478 * editfns.c (Fmessage_box): Remove unused local var.
479
792c7b2b
PE
480 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
481 (note_mode_line_or_margin_highlight, note_mouse_highlight):
482 Omit unused local vars.
c499e557 483 * window.c (shrink_windows): Omit unused local var.
b01a1c29 484 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
485 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
486 Omit unused local var.
487
ba0165e1
PE
488 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
489 Don't assume string length fits in int.
32ad8845 490 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 491 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 492
3c59b4c9
PE
493 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
494 instead of alloca (Bug#8344).
495
a3eed478 496 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 497 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 498
eb4d412d
PE
499 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
500
1658b401
PE
501 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
502 concerns.
503
504 * term.c (produce_glyphless_glyph): Remove unnecessary test.
505
506 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 507
9a2c6e05
PE
508 * keyboard.c (syms_of_keyboard): Use the same style as later
509 in this function when indexing through an array. This also
510 works around GCC bug 48267.
511
03d0a109
PE
512 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
513
44f730c8
PE
514 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
515
fe75f926
PE
516 * chartab.c (sub_char_table_ref_and_range): Redo for slight
517 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
518
ffa8c828
PE
519 * keyboard.c, keyboard.h (num_input_events): Now size_t.
520 This avoids undefined behavior on integer overflow, and is a bit
521 more convenient anyway since it is compared to a size_t variable.
522
c5101a77
PE
523 Variadic C functions now count arguments with size_t, not int.
524 This avoids an unnecessary limitation on 64-bit machines, which
525 caused (substring ...) to crash on large vectors (Bug#8344).
526 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
527 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 528 All variadic functions and their callers changed accordingly.
c5101a77
PE
529 (struct gcpro.nvars): Now size_t, not int. All uses changed.
530 * data.c (arith_driver, float_arith_driver): Likewise.
531 * editfns.c (general_insert_function): Likewise.
532 * eval.c (struct backtrace.nargs, interactive_p)
533 (internal_condition_case_n, run_hook_with_args, apply_lambda)
534 (funcall_lambda, mark_backtrace): Likewise.
535 * fns.c (concat): Likewise.
536 * frame.c (x_set_frame_parameters): Likewise.
537 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
538 0 if not found, not -1. All callers changed.
539
dd3f25f7
PE
540 * alloc.c (garbage_collect): Don't assume stack size fits in int.
541 (stack_copy_size): Now size_t, not int.
542 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
543
461c2ab9
JB
5442011-03-28 Juanma Barranquero <lekktu@gmail.com>
545
546 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
547 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
548 All callers changed.
549
550 * lisp.h (multibyte_char_to_unibyte):
551 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
552 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
553 * character.h (CHAR_TO_BYTE8):
554 * cmds.c (internal_self_insert):
555 * editfns.c (general_insert_function):
556 * keymap.c (push_key_description):
557 * search.c (Freplace_match):
558 * xdisp.c (message_dolog, set_message_1): All callers changed.
559
f6d62986
SM
5602011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
561
562 * keyboard.c (safe_run_hook_funcall): New function.
563 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
564 don't set the hook to nil, but remove the offending function instead.
565 (Qcommand_hook_internal): Remove, unused.
566 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
567 Vcommand_hook_internal.
568
569 * eval.c (enum run_hooks_condition): Remove.
570 (funcall_nil, funcall_not): New functions.
571 (run_hook_with_args): Call each function through a `funcall' argument.
572 Remove `cond' argument, now redundant.
573 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
574 (Frun_hook_with_args_until_failure): Adjust accordingly.
575 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
576
1db5b1ad
JB
5772011-03-28 Juanma Barranquero <lekktu@gmail.com>
578
579 * dispextern.h (string_buffer_position): Remove declaration.
580
581 * print.c (strout): Remove parameter `multibyte', unused since
582 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
583
584 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
585 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
586 All callers changed.
587
588 * w32.c (_wsa_errlist): Use braces for struct initializers.
589
590 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
591 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
592 All callers changed.
593 (string_buffer_position): Likewise. Also, make static (it's never
594 used outside xdisp.c).
595 (cursor_row_p): Remove parameter `w', unused since
596 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
597 (decode_mode_spec): Remove parameter `precision', introduced during
598 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
599 All callers changed.
600
5ffb62aa
JD
6012011-03-27 Jan Djärv <jan.h.d@swipnet.se>
602
603 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
604
461c2ab9 6052011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
606
607 * nsterm.m (ns_menu_bar_is_hidden): New variable.
608 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
609 (ns_update_auto_hide_menu_bar): New functions.
610 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
611 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
612 ns_constrain_all_frames.
613 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
614 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
615
5c380ffb
JD
6162011-03-27 Jan Djärv <jan.h.d@swipnet.se>
617
618 * nsmenu.m (runDialogAt): Remove argument to timer_check.
619
9af30bdf
GM
6202011-03-27 Glenn Morris <rgm@gnu.org>
621
622 * syssignal.h: Replace RETSIGTYPE with void.
623 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
624 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
625 Replace SIGTYPE with void everywhere.
626 * s/usg5-4-common.h (SIGTYPE): Remove definition.
627 * s/template.h (SIGTYPE): Remove commented out definition.
628
e2abce01
JB
6292011-03-26 Eli Zaretskii <eliz@gnu.org>
630
631 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
632 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
633
f868cd8a
JB
6342011-03-26 Juanma Barranquero <lekktu@gmail.com>
635
59eb0929
JB
636 * w32.c (read_unc_volume): Use parameter `henum', instead of
637 global variable `wget_enum_handle'.
638
639 * keymap.c (describe_vector): Remove parameters `indices' and
640 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
641 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
642
f868cd8a
JB
643 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
644
645 * keyboard.c (timer_check): Remove parameter `do_it_now',
646 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
647 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
648 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
649
650 * keyboard.c (read_char):
651 * w32menu.c (w32_menu_display_help):
652 * xmenu.c (show_help_event, menu_help_callback):
653 Adjust calls to `show_help_echo'.
654
655 * gtkutil.c (xg_maybe_add_timer):
656 * keyboard.c (readable_events):
657 * process.c (wait_reading_process_output):
658 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
659
660 * insdel.c (adjust_markers_gap_motion):
661 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
662 (gap_left, gap_right): Don't call it.
663
2ecf6fdb
CY
6642011-03-25 Chong Yidong <cyd@stupidchicken.com>
665
666 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
667 incurred during fontification.
668
6b1f9ba4
JB
6692011-03-25 Juanma Barranquero <lekktu@gmail.com>
670
671 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
672 (DEFVAR_PER_BUFFER): Don't pass it.
673
674 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
675 (scrolling_window): Don't pass it.
676
0f4a96b5
JB
6772011-03-25 Juanma Barranquero <lekktu@gmail.com>
678
679 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
680
681 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
682 and `suffix'.
683 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
684 of variables specific to SELinux and computation of `encoded_absname'.
685
686 * image.c (XPutPixel): Remove unused variable `height'.
687
688 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
689
690 * unexw32.c (get_section_info): Remove unused variable `section'.
691
692 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
693 (system_process_attributes): Remove unused variable `sess'.
694 (sys_read): Remove unused variable `err'.
695
696 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
697 (w32_wnd_proc): Remove unused variable `isdead'.
698 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
699 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
700 (x_create_tip_frame): Remove unused variable `tem'.
701
702 * w32inevt.c (w32_console_read_socket):
703 Remove unused variable `no_events'.
704
705 * w32term.c (x_draw_composite_glyph_string_foreground):
706 Remove unused variable `width'.
707
1149507c
JB
7082011-03-24 Juanma Barranquero <lekktu@gmail.com>
709
710 * w32term.c (x_set_glyph_string_clipping):
711 Don't pass uninitialized region to CombineRgn.
712
9c88f339
JB
7132011-03-23 Juanma Barranquero <lekktu@gmail.com>
714
715 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
716 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
717 (Fx_close_connection): Remove unused variable `i'.
718
719 * w32font.c (w32font_draw): Return number of glyphs.
720 (w32font_open_internal): Remove unused variable `i'.
721 (w32font_driver): Add missing initializer.
722
723 * w32menu.c (utf8to16): Remove unused variable `utf16'.
724 (fill_in_menu): Remove unused variable `items_added'.
725
726 * w32term.c (last_mouse_press_frame): Remove static global variable.
727 (w32_clip_to_row): Remove unused variable `f'.
728 (x_delete_terminal): Remove unused variable `i'.
729
730 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
731 (NOTHING): Remove unused static global variable.
732 (uniscribe_check_otf): Remove unused variable `table'.
733 (uniscribe_font_driver): Add missing initializers.
734
dee091a3
JD
7352011-03-23 Julien Danjou <julien@danjou.info>
736
737 * term.c (Fsuspend_tty, Fresume_tty):
738 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
739 * window.c (temp_output_buffer_show):
740 * insdel.c (signal_before_change):
741 * frame.c (Fhandle_switch_frame):
742 * fileio.c (Fdo_auto_save):
743 * emacs.c (Fkill_emacs):
744 * editfns.c (save_excursion_restore):
745 * cmds.c (internal_self_insert):
746 * callint.c (Fcall_interactively):
747 * buffer.c (Fkill_all_local_variables):
748 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
749 Use Frun_hooks.
0f4a96b5 750 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
751 unconditionnaly since it does the check itself.
752
2c520ab5 7532011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 754
c9c49752
PE
755 Fix more problems found by GCC 4.5.2's static checks.
756
8abc3f12
PE
757 * coding.c (encode_coding_raw_text): Avoid unnecessary test
758 the first time through the loop, since we know p0 < p1 then.
759 This also avoids a gcc -Wstrict-overflow warning.
760
a2d26660
PE
761 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
762 leading to a memory leak, possible in functions like
763 load_charset_map_from_file that can allocate an unbounded number
b12ef411 764 of objects (Bug#8318).
a2d26660 765
916c72e9
PE
766 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
767 that could (at least in theory) be that large.
768
19ab8a18
PE
769 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
770 This is less likely to overflow, and avoids undefined behavior if
771 overflow does occur. All callers changed. Use strtoul to scan
772 for the unsigned long integer.
b7cbbd6f
PE
773 (pint2hrstr): Simplify and tune code slightly.
774 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 775
f0641eff
PE
776 * scroll.c (do_scrolling): Work around GCC bug 48228.
777 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
778
7f650bb9
PE
779 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
780 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
781 (validate_x_resource_name): Simplify count usage.
782 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 783
37dd57d1
PE
784 * fileio.c (Fcopy_file): Report error if fchown or fchmod
785 fail (Bug#8306).
81e56e61 786
699979fc 787 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 788
401bf9b4
PE
789 * process.c (Fmake_network_process): Use socklen_t, not int,
790 where POSIX says socklen_t is required in portable programs.
791 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 792 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
793 (Fmake_network_process, server_accept_connection):
794 (wait_reading_process_output, read_process_output):
795 Likewise.
796
b93aacde
PE
797 * process.c: Rename or move locals to avoid shadowing.
798 (list_processes_1, Fmake_network_process):
799 (read_process_output_error_handler, exec_sentinel_error_handler):
800 Rename or move locals.
4dc343ee 801 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 802 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 803 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 804 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 805 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 806
af8a867c 807 Make tparam.h and terminfo.c consistent.
44f230aa
SM
808 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
809 Include tparam.h instead, since it declares them.
af8a867c
PE
810 * cm.h (PC): Remove extern decl; tparam.h now does this.
811 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
812 * terminfo.c: Include tparam.h, to check interfaces.
813 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
814 (tparam): Adjust signature to match interface in tparam.h;
815 this removes some undefined behavior. Check that outstring and len
816 are zero, which they always are with Emacs.
817 * tparam.h (PC, BC, UP): New extern decls.
818
0248044d 819 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 820 (xftfont_open): Rename locals to avoid shadowing.
0248044d 821
8ff096c1 822 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
823 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
824 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 825 (ftfont_list): Remove unused local.
49eaafba
PE
826 (get_adstyle_property, ftfont_pattern_entity):
827 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
828 Rename locals to avoid shadowing.
8ff096c1 829
e2be39f6
PE
830 * xfont.c (xfont_list_family): Mark var as initialized.
831
c9735e30
PE
832 * xml.c (make_dom): Now static.
833
8f5201ae
PE
834 * composite.c (composition_compute_stop_pos): Rename local to
835 avoid shadowing.
b246f932
PE
836 (composition_reseat_it): Remove unused locals.
837 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 838 (composition_update_it): Mark var as initialized.
11b61122
PE
839 (find_automatic_composition): Mark vars as initialized,
840 with a FIXME (Bug#8290).
8f5201ae 841
760fbc2c
PE
842 character.h: Rename locals to avoid shadowing.
843 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
844 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
845 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
846 (BUF_DEC_POS): Be more systematic about renaming local temporaries
847 to avoid shadowing.
848
ff08eb85
PE
849 * textprop.c (property_change_between_p): Remove; unused.
850
fc7bf025
PE
851 * intervals.c (interval_start_pos): Now static.
852
235d7abc
PE
853 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
854
44f230aa
SM
855 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
856 Rename locals to avoid shadowing.
3e7d6594 857
50060332
PE
858 * sound.c (wav_play, au_play, Fplay_sound_internal):
859 Fix pointer signedness.
d01f234b 860 (alsa_choose_format): Remove unused local var.
c83b8872
PE
861 (wav_play): Initialize a variable to 0, to prevent undefined
862 behavior (Bug#8278).
50060332 863
c4fc4e30
PE
864 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
865
918436ed
PE
866 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
867
c939f91b
PE
868 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
869 clobbering (Bug#8298).
b9c7f648
PE
870 * sysdep.c (sys_subshell): Likewise.
871 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 872
6bd8c144
PE
873 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
874 This should get cleaned up, so that child_setup has the
875 same signature on all platforms.
876
7710357c 877 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 878 (relocate_fd): Rename locals to avoid shadowing.
7710357c 879
c59da222
CY
8802011-03-22 Chong Yidong <cyd@stupidchicken.com>
881
882 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
883 not to be necessary, and produces flickering.
884
66b87493
GM
8852011-03-20 Glenn Morris <rgm@gnu.org>
886
887 * config.in: Remove file.
888
45b6f6d5
JB
8892011-03-20 Juanma Barranquero <lekktu@gmail.com>
890
891 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
892 are now in src/globals.h.
893 (syms_of_minibuf): Remove spurious & from previous change.
894
3ec03f7e
LL
8952011-03-20 Leo <sdl.web@gmail.com>
896
897 * minibuf.c (completing-read-function): New variable.
898 (completing-read-default): Rename from completing-read.
899 (completing-read): Call completing-read-function.
900
b14e3e21
CY
9012011-03-19 Juanma Barranquero <lekktu@gmail.com>
902
903 * xfaces.c (Fx_load_color_file):
904 Read color file from absolute filename (bug#8250).
905
f2b726e6
JB
9062011-03-19 Juanma Barranquero <lekktu@gmail.com>
907
908 * makefile.w32-in: Update dependencies.
909
09f6ff02
EZ
9102011-03-17 Eli Zaretskii <eliz@gnu.org>
911
912 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
913
29a6015a
PE
9142011-03-17 Paul Eggert <eggert@cs.ucla.edu>
915
a3a6c54e
PE
916 Fix more problems found by GCC 4.5.2's static checks.
917
b766f867
PE
918 * process.c (make_serial_process_unwind, send_process_trap):
919 (sigchld_handler): Now static.
920
be02381c
PE
921 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
922 That way, the code declares only the vars that it needs.
923 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
924 * s/cygwin.h (PTY_ITERATION): Likewise.
925 * s/darwin.h (PTY_ITERATION): Likewise.
926 * s/gnu-linux.h (PTY_ITERATION): Likewise.
927
57048744
PE
928 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
929 * process.c (allocate_pty): Don't declare stb unless it's needed.
930
7914961c 931 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
932 (CONSTANTLIM): Remove; unused.
933 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
934 Define only if needed.
7914961c 935
b3967b18
PE
936 * unexelf.c (unexec): Name an expression,
937 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
938 Use a different way to cause a compilation error if anyone uses
939 n rather than nn, a way that does not involve shadowing.
73366a00 940 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 941
29a6015a
PE
942 * deps.mk (unexalpha.o): Remove; unused.
943
43cfc33e 944 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 945 * unexec.h: New file.
ce701a33
PE
946 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
947 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
948 Depend on unexec.h.
949 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
950 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
951 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 952 Change as necessary to match prototype in unexec.h.
ce701a33 953
01f44d5a
PE
954 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
955 shadowing.
4f63c6bb 956 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 957
a6670b0b
PE
958 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
959 Rename locals to avoid shadowing.
960
cef2010d 961 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 962 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 963
d4d7173a
PE
964 * print.c (Fredirect_debugging_output): Fix pointer signedess.
965
f08b802a
PE
966 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
967 warning when compiling print.c.
968
3ddb0639
PE
969 * font.c (font_unparse_fcname): Abort in an "impossible" situation
970 instead of using an uninitialized var.
5ad03b97 971 (font_sort_entities): Mark var as initialized.
3ddb0639 972
170a2692
PE
973 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
974
e663c700
PE
975 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
976 pointers to constants.
89bc529a 977 (font_parse_fcname): Remove unused vars.
7b81e2d0 978 (font_delete_unmatched): Now static.
ea838e10 979 (font_get_spec): Remove; unused.
13a547c6
PE
980 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
981 (font_update_drivers, Ffont_get_glyphs, font_add_log):
982 Rename or move locals to avoid shadowing.
e663c700 983
2a80c887 984 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 985 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 986
1384fa33 987 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 988 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 989
8b2c52e9
PE
990 * alloc.c (mark_backtrace): Move decl from here ...
991 * lisp.h: ... to here, so that it can be checked.
992
475545b5 993 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 994 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
995 (lisp_indirect_variable): Name an expression,
996 to avoid gcc -Wbad-function-cast warning.
1faed8ae 997 (Fdefvar): Rename locals to avoid shadowing.
475545b5 998
b1349114 999 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 1000 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 1001 Use const pointer when appropriate.
b1349114 1002
a2928364
PE
1003 * lisp.h (get_system_name, get_operating_system_release):
1004 Move decls here, to check interfaces.
1005 * process.c (get_operating_system_release): Move decl to lisp.h.
1006 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
1007 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
1008 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
1009 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
1010 (Fformat_time_string, Fencode_time, Finsert_char):
1011 (Ftranslate_region_internal, Fformat):
1012 Rename or remove local vars to avoid shadowing.
9710023e 1013 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 1014
a415e694
PE
1015 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
1016 avoid shadowing.
1017
8ef4622d
PE
1018 * lisp.h (eassert): Check that the argument compiles, even if
1019 ENABLE_CHECKING is not defined.
1020
946f9a5b
PE
1021 * data.c (Findirect_variable): Name an expression, to avoid
1022 gcc -Wbad-function-cast warning.
112396d6 1023 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 1024 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
1025 (Fmake_variable_buffer_local, Fmake_local_variable):
1026 Mark variables as initialized.
52746918 1027 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 1028
e5aab7e7 1029 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
1030 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
1031 Rename locals to avoid shadowing.
dff45157
PE
1032 (mark_stack): Move local variables into the #ifdef region where
1033 they're used.
7bc26fdb
PE
1034 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
1035 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
1036 needed otherwise.
1037 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
1038 (GC_STRING_CHARS): Remove; not used.
d40d4be1 1039 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 1040
e5aab7e7
PE
1041 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
1042 avoids undefined behavior in theory.
1043
4da60324
PE
1044 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
1045
88043301
PE
1046 Use functions, not macros, for up- and down-casing (Bug#8254).
1047 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1048 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
1049 to use the following functions instead of these macros.
1050 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
1051 EMACS_INT, since callers assume the returned value fits in int.
1052 (upcase1): Likewise, for UPCASE_TABLE.
1053 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 1054 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 1055 the race-condition problem in the old DOWNCASE.
88043301 1056
19ed5445
PE
1057 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
1058 Rename locals to avoid shadowing.
1059 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
1060 (regex_compile, re_search_2, re_match_2_internal):
1061 Remove unused local vars.
952db0d7
PE
1062 (FREE_VAR): Rewrite so as not to use empty "else",
1063 which gcc can warn about.
da053e48 1064 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
1065 (RETALLOC_IF): Define only if needed.
1066 (WORDCHAR_P): Likewise. This one is never needed, but is used
1067 only in a comment talking about a compiler bug, so put inside
1068 the #if 0 of that comment.
1069 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
1070 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
1071 Remove; unused.
19ed5445 1072
1f3561e4 1073 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
1074 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
1075 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 1076
ded6f8f7
PE
1077 * search.c (simple_search): Remove unused var.
1078
dbd37a95
PE
1079 * dired.c (compile_pattern): Move decl from here ...
1080 * lisp.h: ... to here, so that it can be checked.
1081 (struct re_registers): New forward decl.
1082
7e47afad
PE
1083 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
1084
85f24f61
PE
1085 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
1086 All uses changed.
1087 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
1088 Rename locals to avoid shadowing.
5671df8f 1089 (Fvertical_motion): Mark locals as initialized.
85f24f61 1090
181aa2be 1091 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 1092 (casify_region): Mark local as initialized.
181aa2be 1093
930d429c
PE
1094 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
1095
7082eac6
PE
1096 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
1097 New macros, so that the caller can use some names other than
1098 gcpro1, gcpro2, etc.
1099 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
1100 of the new macros.
1101 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
1102 argument, for consistency with GCPRO2_VAR, etc: it is now the
1103 prefix of the variable, not the variable itself. All uses
1104 changed.
38b2c076
PE
1105 * dired.c (directory_files_internal, file_name_completion):
1106 Rename locals to avoid shadowing.
1107
15206ed9
PE
1108 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
1109 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
1110 dired.c's scmp function, had undefined behavior.
1111 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1112 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
1113 * buffer.h: ... to here, because these macros use current_buffer,
1114 and the new implementation with inline functions needs to have
1115 current_buffer in scope now, rather than later when the macros
1116 are used.
1117 (downcase, upcase1): New static inline functions.
1118 (DOWNCASE, UPCASE1): Reimplement using these functions.
1119 This avoids undefined behavior in expressions like
1120 DOWNCASE (x) == DOWNCASE (y), which previously suffered
1121 from race conditions in accessing the global variables
1122 case_temp1 and case_temp2.
1123 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
1124 * lisp.h (case_temp1, case_temp2): Remove their decls.
1125 * character.h (ASCII_CHAR_P): Move from here ...
1126 * lisp.h: ... to here, so that the inline functions mentioned
1127 above can use them.
1128
4a6bea26
PE
1129 * dired.c (directory_files_internal_unwind): Now static.
1130
f14b7e14
PE
1131 * fileio.c (file_name_as_directory, directory_file_name):
1132 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
1133 Now static.
2893f146
PE
1134 (file_name_as_directory): Use const pointers when appropriate.
1135 (Fexpand_file_name): Likewise. In particular, newdir might
1136 point at constant storage, so make it a const pointer.
fd4ead52 1137 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
1138 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
1139 signedness issues.
f839df0c
PE
1140 (Fset_file_times, Finsert_file_contents, auto_save_error):
1141 Rename locals to avoid shadowing.
f14b7e14 1142
5716756e 1143 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
1144 (Ftry_completion, Fall_completions): Rename or remove locals
1145 to avoid shadowing.
5716756e 1146
b4c3046a
PE
1147 * marker.c (bytepos_to_charpos): Remove; unused.
1148
b45db522
PE
1149 * lisp.h (verify_bytepos, count_markers): New decls,
1150 so that gcc does not warn that these functions aren't declared.
1151
85876d07
PE
1152 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
1153 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 1154 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 1155 (copy_text): Remove unused local var.
85876d07 1156
03d78a21 1157 * filelock.c (within_one_second): Now static.
b3dd38ab 1158 (lock_file_1): Rename local to avoid shadowing.
03d78a21 1159
5df8f01b
PE
1160 * buffer.c (fix_overlays_before): Mark locals as initialized.
1161 (fix_start_end_in_overlays): Likewise. This function should be
1162 simplified by using pointers-to-pointers, but that's a different
1163 matter.
b1d876f1 1164 (switch_to_buffer_1): Now static.
8f54f30a
PE
1165 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
1166 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 1167
a70072c9 1168 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 1169 Fix pointer signedness issue.
edced198
PE
1170 (sys_subshell): Mark local as volatile if checking for lint,
1171 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 1172 (MAXPATHLEN): Define only if needed.
a70072c9 1173
a0977c44
PE
1174 * process.c (serial_open, serial_configure): Move decls from here ...
1175 * systty.h: ... to here, so that they can be checked.
1176
a884fdcc
PE
1177 * fns.c (get_random, seed_random): Move extern decls from here ...
1178 * lisp.h: ... to here, so that they can be checked.
1179
604efe86 1180 * sysdep.c (reset_io): Now static.
b8950c94 1181 (wait_for_termination_signal): Remove; unused.
604efe86 1182
38fc62d9
PE
1183 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
1184 (copy_keymap_item, append_key, push_text_char_description):
1185 Now static.
1004a21a 1186 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 1187 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
1188 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
1189 (describe_map_tree):
1190 Rename locals to avoid shadowing.
38fc62d9 1191
2f2650da
PE
1192 * keyboard.c: Declare functions static if they are not used elsewhere.
1193 (echo_char, echo_dash, cmd_error, top_level_2):
1194 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
1195 (read_char, kbd_buffer_get_event, make_lispy_position):
1196 (make_lispy_event, make_lispy_movement, apply_modifiers):
1197 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
1198 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
1199 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 1200 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 1201 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 1202
a053e86c 1203 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
1204 (mark_kboards): Move decl here ...
1205 * alloc.c (mark_kboards): ... from here.
a053e86c 1206
4752793e
PE
1207 * lisp.h (force_auto_save_soon): New decl.
1208
74f10ca7 1209 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
1210 (DEFINE_DUMMY_FUNCTION): New macro.
1211 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
1212 Use it.
c03cd23f
PE
1213 (main): Add casts to avoid warnings
1214 if GCC considers string literals to be constants.
74f10ca7 1215
022e70d4
PE
1216 * lisp.h (fatal_error_signal): Add decl, since it's exported.
1217
59d6fe83
PE
1218 * dbusbind.c: Pointer signedness fixes.
1219 (xd_signature, xd_append_arg, xd_initialize):
1220 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1221 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1222 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
1223 (Fdbus_register_signal): Use SSDATA when the context wants char *.
1224
78320123
PE
1225 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
1226 if GCC considers string literals to be constants.
49cebcca 1227 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 1228
35ac2a97
SM
12292011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
1230
fb103ca9
SM
1231 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
1232 (print_preprocess, print_object): New macro to fix last change.
1233
35ac2a97
SM
1234 * print.c (print_preprocess): Don't forget font objects.
1235
62973b41
JB
12362011-03-16 Juanma Barranquero <lekktu@gmail.com>
1237
1238 * emacs.c (USAGE3): Doc fixes.
1239
0e48bb22
AS
12402011-03-15 Andreas Schwab <schwab@linux-m68k.org>
1241
1242 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
1243 structure.
1244
7684e57b
JB
12452011-03-14 Juanma Barranquero <lekktu@gmail.com>
1246
1247 * lisp.h (VWindow_system, Qfile_name_history):
1248 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
1249 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
1250 (w32_system_caret_x, w32_system_caret_y): Declare extern.
1251
1252 * w32select.c: Don't #include "keyboard.h".
c96bbc66 1253 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
1254
1255 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
1256 * w32console.c (detect_input_pending, read_input_pending)
1257 (encode_terminal_code):
1258 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
1259 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
1260 (w32_system_caret_y, Qfile_name_history):
1261 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
1262 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
1263 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
1264 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
1265 * w32proc.c (Qlocal, report_file_error):
1266 * w32term.c (Vwindow_system, updating_frame):
1267 * w32uniscribe.c (initialized, uniscribe_font_driver):
1268 Remove unneeded extern declarations.
1269
2aa46d6c
CY
12702011-03-14 Chong Yidong <cyd@stupidchicken.com>
1271
c96bbc66 1272 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 1273
cffc6f3b
CY
12742011-03-13 Chong Yidong <cyd@stupidchicken.com>
1275
1276 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
1277 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
1278 These macros can no longer be used for assignment.
1279
44f230aa
SM
1280 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1281 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
1282 (record_buffer_markers, fetch_buffer_markers): New functions for
1283 recording and fetching special buffer markers.
1284 (set_buffer_internal_1, set_buffer_temp): Use them.
1285
1286 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
1287
1288 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
1289
1290 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
1291 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
1292
1293 * xdisp.c (hscroll_window_tree):
1294 (reconsider_clip_changes): Use PT instead of BUF_PT.
1295
d251f04b
EZ
12962011-03-13 Eli Zaretskii <eliz@gnu.org>
1297
1298 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
1299 $(EMACS_ROOT)/lib/intprops.h.
1300
f0c77cd1
PE
13012011-03-13 Paul Eggert <eggert@cs.ucla.edu>
1302
3eca4629
PE
1303 Fix more problems found by GCC 4.5.2's static checks.
1304
7c86ee98
PE
1305 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
1306 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
1307 (xg_free_frame_widgets): Make it clear that a local variable is
1308 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
1309 (gdk_window_get_screen): Make it clear that this macro is needed
1310 only if USE_GTK_TOOLTIP.
1e5524e7
PE
1311 (int_gtk_range_get_value): New function, which avoids a diagnostic
1312 from gcc -Wbad-function-cast.
1313 (xg_set_toolkit_scroll_bar_thumb): Use it.
1314 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
1315 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
1316 (get_utf8_string, xg_get_file_with_chooser):
1317 Rename locals to avoid shadowing.
1318 (create_dialog): Move locals to avoid shadowing.
7c86ee98 1319
41729b81
PE
1320 * xgselect.c (xg_select): Remove unused var.
1321
f0c77cd1
PE
1322 * image.c (four_corners_best): Mark locals as initialized.
1323 (gif_load): Initialize transparent_p to zero (Bug#8238).
1324 Mark another local as initialized.
ec6cf4c6 1325 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 1326
ce0ad53d 1327 * image.c (clear_image_cache): Now static.
d5d5a617 1328 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 1329 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
1330 (x_edge_detection): Remove unnecessary cast that
1331 gcc -Wbad-function-cast diagnoses.
2037898d 1332 (gif_load): Fix pointer signedness.
6ae141d6
PE
1333 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
1334 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 1335
33383987 13362011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 1337
d32df629
PE
1338 Improve quality of tests for time stamp overflow.
1339 For example, without this patch (encode-time 0 0 0 1 1
1340 1152921504606846976) returns the obviously-bogus value (-948597
1341 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
1342 reports time overflow. See
1343 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
1344 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
1345 * editfns.c: Include limits.h and intprops.h.
1346 (TIME_T_MIN, TIME_T_MAX): New macros.
1347 (time_overflow): Move earlier, to before first use.
1348 (hi_time, lo_time): New functions, for an accurate test for
1349 out-of-range times.
1350 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
1351 (Fget_internal_run_time): Don't assume time_t fits in int.
1352 (make_time): Use list2 instead of Fcons twice.
1353 (Fdecode_time): More accurate test for out-of-range times.
1354 (check_tm_member): New function.
1355 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
1356 (lisp_time_argument): Don't rely on undefined left-shift and
1357 right-shift behavior when checking for time stamp overflow.
8be6f318 1358
fe31d94c
PE
1359 * editfns.c (time_overflow): New function, refactoring common code.
1360 (Fformat_time_string, Fdecode_time, Fencode_time):
1361 (Fcurrent_time_string): Use it.
1362
8be6f318
PE
1363 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
1364 * dired.c (make_time): Move to ...
1365 * editfns.c (make_time): ... here.
1366 * systime.h: Note the move.
1367
09d9db2c 13682011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 1369
126bc0dc
YM
1370 * fringe.c (update_window_fringes): Remove unused variables.
1371
c47cbdfd
YM
1372 * unexmacosx.c (copy_data_segment): Also copy __got section.
1373 (Bug#8223)
1374
7ac80be9
EZ
13752011-03-12 Eli Zaretskii <eliz@gnu.org>
1376
c96bbc66 1377 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
1378 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
1379 Constify `char *' arguments and their references according to
1380 prototypes in tparam.h.
1381
ecb0f94d 1382 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 1383
7ac80be9
EZ
1384 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
1385 Adapt all references accordingly.
1386
1387 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
1388
ef1fd07e
TT
13892011-03-11 Tom Tromey <tromey@redhat.com>
1390
1391 * buffer.c (syms_of_buffer): Remove obsolete comment.
1392
7ef4b50c
EZ
13932011-03-11 Eli Zaretskii <eliz@gnu.org>
1394
1395 * termhooks.h (encode_terminal_code): Declare prototype.
1396
1397 * msdos.c (encode_terminal_code): Don't declare prototype.
1398
1399 * term.c (encode_terminal_code): Now external again, used by
1400 w32console.c and msdos.c.
1401
44f230aa
SM
1402 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
1403 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 1404
4b1ec863 14052011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 1406
1714f52b 1407 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 1408
4b1ec863
PE
1409 * fringe.c (update_window_fringes): Mark locals as initialized
1410 (Bug#8227).
1411 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 1412
524c7aa6
PE
1413 * alloc.c (mark_fringe_data): Move decl from here ...
1414 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
1415 to check its interface.
1416 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
1417
a5c0af81 1418 * fontset.c (free_realized_fontset): Now static.
7519b8cd 1419 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 1420 (fontset_font): Mark local as initialized.
a9a06e0b 1421 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 1422
b4716021
PE
1423 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
1424
811e9bac 1425 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 1426 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
1427 (x_own_selection, Fx_disown_selection_internal): Rename locals
1428 to avoid shadowing.
1429 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 1430
7e3ab302
PE
1431 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
1432 so that the caller can use some name other than gcpro1.
1433 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
1434 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1435 (Fx_backspace_delete_keys_p):
1436 Use them to avoid shadowing, and rename vars to avoid shadowing.
1437 (x_decode_color, x_set_name, x_window): Now static.
6b437900 1438 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 1439 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
1440 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
1441 Remove unused locals.
7e3ab302
PE
1442 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1443 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
1444 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
1445 macros.
f78faa98 1446
e2b13473
PE
1447 * xterm.h (x_mouse_leave): New decl.
1448
77f23912
PE
1449 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
1450 Remove unused functions.
cdf4ba58
PE
1451 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
1452 (x_calc_absolute_position): Now static.
7411c686 1453 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 1454 Don't declare local "event" unless it's used.
ed7bf3a5
PE
1455 (x_iconify_frame, x_free_frame_resources): Don't declare locals
1456 unless they are used.
38d0b34a
PE
1457 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
1458 (x_fatal_error_signal): Remove; not used.
a6067996
PE
1459 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
1460 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
1461 (x_error_catcher, x_connection_closed, x_error_handler):
1462 (x_error_quitter, xembed_send_message, x_iconify_frame):
1463 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 1464 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 1465 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 1466
44f230aa
SM
1467 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
1468 Rename or move locals to avoid shadowing.
6b463e58 1469 (tty_defined_color, merge_face_heights): Now static.
5967d051 1470 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
1471 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
1472 does not deduce is never used uninitialized.
73719eba
PE
1473 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
1474 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 1475
426994c3 1476 * terminal.c (store_terminal_param): Now static.
5489860b 1477
032f1620 1478 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 1479 (set_frame_menubar): Remove unused local.
d4323972 1480 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
1481 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
1482 since they might point to immutable storage.
281585b0
PE
1483 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
1484 since it's unused otherwise.
032f1620 1485
367c19e5 1486 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 1487 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
1488 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
1489 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 1490 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
1491 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
1492 does not deduce are never used uninitialized.
70739cbe 1493
07b48fa9
PE
1494 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
1495
8868a238 1496 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
1497 * window.c (window_loop, size_window):
1498 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 1499
7e5cf297 1500 * window.c (display_buffer): Now static.
d6550a9f
PE
1501 (size_window): Mark variables that gcc -Wuninitialized
1502 does not deduce are never used uninitialized.
a586633d
PE
1503 * window.h (check_all_windows): New decl, to forestall
1504 gcc -Wmissing-prototypes diagnostic.
5b555da1 1505 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 1506
f6095868
PE
1507 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
1508 shadowing.
1509 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
1510 Include <limits.h>.
1511 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
1512 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
1513 (load_charset_map): Mark variables that gcc -Wuninitialized
1514 does not deduce are never used uninitialized.
53df7c11 1515 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 1516
f38b440c
PE
1517 * coding.c (coding_set_source, coding_set_destination):
1518 Use "else { /* comment */ }" rather than "else /* comment */;"
1519 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
1520 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
1521 a block, when the outer 'i' will do.
1522 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
1523 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
1524 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
1525 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
1526 (Fdecode_sjis_char, Fdefine_coding_system_internal):
1527 Rename locals to avoid shadowing.
1528 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
1529 * coding.c (emacs_mule_char, encode_invocation_designation):
1530 Now static, since they're not used elsewhere.
413bb2db 1531 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 1532 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
1533 (decode_coding_emacs_mule): Mark variables that gcc
1534 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
1535 (detect_coding_iso_2022): Initialize a local variable that might
1536 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 1537 this initialization is needed. (Bug#8211)
5f58e762
PE
1538 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
1539 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
1540 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
1541 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
1542 Remove unused macros.
f38b440c 1543
232b38b9 1544 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 1545 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 1546 * character.c (string_count_byte8): Likewise.
232b38b9 1547
fb90da1b
PE
1548 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
1549 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
1550
fb93dbc2
PE
1551 * chartab.c (copy_sub_char_table): Now static, since it's not used
1552 elsewhere.
5c156ace
PE
1553 (sub_char_table_ref_and_range, char_table_ref_and_range):
1554 Rename locals to avoid shadowing.
bbcd0949 1555 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 1556
7d3b3862 1557 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 1558 (BIDI_BOB): Remove unused macro.
7d3b3862 1559
6be7d3da
PE
1560 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
1561 deduce are never used uninitialized.
c2ed9c8b 1562 * term.c (encode_terminal_code): Likewise.
6be7d3da 1563
75f8807f 1564 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 1565
50938595
PE
1566 * tparam.h: New file.
1567 * term.c, tparam.h: Include it.
1568 * deps.mk (term.o, tparam.o): Depend on tparam.h.
1569 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
1570 Move these decls to tparam.h, and make them agree with what
1571 is actually in tparam.c. The previous trick of using incompatible
1572 decls in different modules does not conform to the C standard.
1573 All callers of tparam changed to use tparam's actual API.
1574 * tparam.c (tparam1, tparam, tgoto):
1575 Use const pointers where appropriate.
1576
fbceeba2
PE
1577 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
1578 * cm.h (struct cm): Likewise.
1579 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
1580 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
1581 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
1582 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
1583 (turn_on_face, init_tty): Likewise.
1584 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 1585
7f3f1250
PE
1586 * term.c (term_mouse_position): Rename local to avoid shadowing.
1587
e6ca6543
PE
1588 * alloc.c (mark_ttys): Move decl from here ...
1589 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
1590
c40f8d15
AS
15912011-03-11 Andreas Schwab <schwab@linux-m68k.org>
1592
1593 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
1594
cfe0661d
JB
15952011-03-09 Juanma Barranquero <lekktu@gmail.com>
1596
1597 * search.c (compile_pattern_1): Remove argument regp, unused since
1598 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
1599 (compile_pattern): Don't pass it.
1600
0afb4571
J
16012011-03-08 Jan Djärv <jan.h.d@swipnet.se>
1602
1603 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
1604 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
1605 for ! HAVE_GTK3.
1606 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
1607
1608 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
1609
1610 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
1611 gdk_window_get_screen, gdk_window_get_geometry,
1612 gdk_x11_window_lookup_for_display and GDK_KEY_g.
1613 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
1614 (xg_get_pixbuf_from_pixmap): New function.
1615 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
1616 to Pixmap, take frame as parameter, remove GdkColormap parameter.
1617 Call xg_get_pixbuf_from_pixmap instead of
1618 gdk_pixbuf_get_from_drawable.
1619 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
1620 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
1621 (xg_check_special_colors): Use GtkStyleContext and its functions
1622 for HAVE_GTK3.
1623 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
1624 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
1625 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
1626 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
1627 Call gtk_widget_get_preferred_size.
0afb4571
J
1628 (xg_frame_resized): gdk_window_get_geometry only takes 5
1629 parameters.
44f230aa
SM
1630 (xg_win_to_widget, xg_event_is_for_menubar):
1631 Call gdk_x11_window_lookup_for_display.
0afb4571
J
1632 (xg_set_widget_bg): New function.
1633 (delete_cb): New function.
1634 (xg_create_frame_widgets): connect delete-event to delete_cb.
1635 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
1636 (xg_set_background_color): Call xg_set_widget_bg.
1637 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
1638 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
1639 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
1640 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
1641 if ! HAVE_GTK3.
1642 (update_frame_tool_bar): Call gtk_widget_hide.
1643 (xg_initialize): Use GDK_KEY_g.
1644
1645 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
1646 if ! HAVE_GTK3
1647 (x_session_initialize): Call gdk_x11_set_sm_client_id.
1648
1649 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
1650 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
1651 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
1652
1c2cc4ef
JB
16532011-03-08 Juanma Barranquero <lekktu@gmail.com>
1654
1655 * w32xfns.c (select_palette): Check success of RealizePalette against
1656 GDI_ERROR, not zero.
1657
33383987 1658See ChangeLog.11 for earlier changes.
aac0c6e3
MR
1659
1660;; Local Variables:
1661;; coding: utf-8
aac0c6e3
MR
1662;; End:
1663
33383987 1664 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
1665
1666 This file is part of GNU Emacs.
1667
1668 GNU Emacs is free software: you can redistribute it and/or modify
1669 it under the terms of the GNU General Public License as published by
1670 the Free Software Foundation, either version 3 of the License, or
1671 (at your option) any later version.
1672
1673 GNU Emacs is distributed in the hope that it will be useful,
1674 but WITHOUT ANY WARRANTY; without even the implied warranty of
1675 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
1676 GNU General Public License for more details.
1677
1678 You should have received a copy of the GNU General Public License
1679 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.