* window.c: Fix minor problems reported by GCC 4.6.0.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
3f754b86
PE
12011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2
46a4ce9e
PE
3 * window.c: Fix minor problems reported by GCC 4.6.0.
4 (window_deletion_count, delete_deletable_window): Remove; unused.
5 (window_body_lines): Now static.
6 (Fdelete_other_windows_internal): Mark vars as initialized.
7 Make sure 'resize_failed' is initialized.
8 (run_window_configuration_change_hook): Rename local to avoid shadowing.
9 (resize_window_apply): Remove unused local.
10 * window.h (delete_deletable_window): Remove decl.
11
33290528
PE
12 * image.c: Fix minor problems reported by GCC 4.6.0.
13 (gif_load, svg_load_image): Rename locals to avoid shadowing.
14 (imagemagick_load_image): Fix pointer signedness problem by changing
15 last arg from unsigned char * to char *. All uses changed.
16 Also, fix a local for similar reasons.
17 Remove unused locals. Remove locals to avoid shadowing.
18 (fn_rsvg_handle_free): Remove; unused.
19 (svg_load, svg_load_image): Fix pointer signedness problem.
20
3f754b86
PE
21 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
22
2547adb1
CY
232011-06-10 Chong Yidong <cyd@stupidchicken.com>
24
25 * image.c (gif_load): Fix omitted cast error introduced by
26 2011-06-06 change.
27
2c8e37d4
MR
282011-06-10 Martin Rudalics <rudalics@gmx.at>
29
30 * window.h (resize_proportionally, orig_total_lines)
31 (orig_top_line): Remove from window structure.
32 (set_window_height, set_window_width, change_window_heights)
33 (Fdelete_window): Remove prototypes.
34 (resize_frame_windows): Remove duplicate declaration.
35
440a42e3
EZ
362011-06-10 Eli Zaretskii <eliz@gnu.org>
37
38 * window.h (resize_frame_windows, resize_window_check)
39 (delete_deletable_window, resize_root_window)
40 (resize_frame_windows): Declare prototypes.
41
42 * window.c (resize_window_apply): Make definition be "static" to
43 match the prototype.
44
562dd5e9
MR
452011-06-10 Martin Rudalics <rudalics@gmx.at>
46
47 * window.c: Remove declarations of Qwindow_size_fixed,
48 window_min_size_1, window_min_size_2, window_min_size,
49 size_window, window_fixed_size_p, enlarge_window, delete_window.
50 Remove static from declaration of Qdelete_window, it's
51 temporarily needed by Fbury_buffer.
52 (replace_window): Don't assign orig_top_line and
53 orig_total_lines.
54 (Fdelete_window, delete_window): Remove. Window deletion is
55 handled by window.el.
56 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
57 Fdelete_window calls with calls to Qdelete_window.
58 (Fdelete_other_windows): Remove. Deleting other windows is
59 handled by window.el.
60 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
61 handled in window.el.
62 (window_min_size_2, window_min_size_1, window_min_size): Remove.
63 Window minimum sizes are handled in window.el.
64 (shrink_windows, size_window, set_window_height)
65 (set_window_width, change_window_heights, window_height)
66 (window_width, CURBEG, CURSIZE, enlarge_window)
67 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
68 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
69 handled in window.el.
70 (make_dummy_parent): Rename to make_parent_window and give it a
71 second argument horflag.
72 (make_window): Don't set resize_proportionally any more.
73 (Fsplit_window): Remove. Windows are split in window.el.
74 (save_restore_action, save_restore_orig_size)
75 (shrink_window_lowest_first, save_restore_orig_size): Remove.
76 Resize mini windows in window.el.
77 (grow_mini_window, shrink_mini_window): Implement by calling
78 Qresize_root_window_vertically, resize_window_check and
79 resize_window_apply.
80 (saved_window, Fset_window_configuration, save_window_save): Do
81 not handle orig_top_line, orig_total_lines, and
82 resize_proportionally.
83 (window_min_height, window_min_width): Move to window.el.
84 (keys_of_window): Move bindings for delete-other-windows,
85 split-window, delete-window and enlarge-window to window.el.
86
87 * buffer.c: Temporarily extern Qdelete_window.
88 (Fbury_buffer): Temporarily call Qdelete_window instead of
89 Fdelete_window (Fbury_buffer will move to window.el soon).
90
91 * frame.c (set_menu_bar_lines_1): Remove code handling
92 orig_top_line and orig_total_lines.
93
94 * dispnew.c (adjust_frame_glyphs_initially): Don't use
95 set_window_height but set heights directly.
96 (change_frame_size_1): Use resize_frame_windows.
97
98 * xdisp.c (init_xdisp): Don't use set_window_height but set
99 heights directly.
100
101 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
102 resize_frame_windows instead of change_window_heights and run
103 run_window_configuration_change_hook.
104
105 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
106 instead of change_window_heights and run
107 run_window_configuration_change_hook.
108
1a13852e
MR
1092011-06-09 Martin Rudalics <rudalics@gmx.at>
110
111 * window.c (replace_window): Rename second argument REPLACEMENT to
112 NEW. New third argument SETFLAG. Rewrite.
113 (delete_window, make_dummy_parent): Call replace_window with
114 third argument 1.
115 (window_list_1): Move down in code.
116 (run_window_configuration_change_hook): Move set_buffer part
117 before select_frame_norecord part in order to unwind correctly.
118 Rename count1 to count.
119 (recombine_windows, delete_deletable_window, resize_root_window)
120 (Fdelete_other_windows_internal)
121 (Frun_window_configuration_change_hook, make_parent_window)
122 (resize_window_check, resize_window_apply, Fresize_window_apply)
123 (resize_frame_windows, Fsplit_window_internal)
124 (Fdelete_window_internal, Fresize_mini_window_internal): New
125 functions.
126 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
127
f3d1777e
MR
1282011-06-08 Martin Rudalics <rudalics@gmx.at>
129
496e208e
MR
130 * window.h (window): Add some new members to window structure -
131 normal_lines, normal_cols, new_total, new_normal, clone_number,
132 splits, nest, prev_buffers, next_buffers.
133 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 134 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 135
f3d1777e
MR
136 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
137 Remove.
496e208e
MR
138 (make_dummy_parent): Set new members of windows structure.
139 (make_window): Move down in code. Handle new members of window
140 structure.
141 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
142 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
143 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
144 (Fset_window_prev_buffers, Fwindow_next_buffers)
145 (Fset_window_next_buffers, Fset_window_clone_number): New
146 functions.
147 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
148 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
149 Doc-string fixes.
150 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
151 Argument WINDOW can be now internal window too.
152 (Fwindow_use_time): Move up in code.
153 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
154 Rewrite doc-string.
155 (Fset_window_configuration, saved_window)
156 (Fcurrent_window_configuration, save_window_save): Handle new
157 members of window structure.
b9e809c2
MR
158 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
159 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
160 (syms_of_window): New Lisp objects Qrecord_window_buffer,
161 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
162 Qget_mru_window, Qresize_root_window,
163 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
164 Qauto_buffer_name; staticpro them.
f3d1777e 165
abde8f8c
MR
1662011-06-07 Martin Rudalics <rudalics@gmx.at>
167
168 * window.c (Fwindow_total_size, Fwindow_left_column)
169 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
170 (Fwindow_list_1): New functions.
171 (window_box_text_cols): Replace with window_body_cols.
172 (Fwindow_width, Fscroll_left, Fscroll_right): Use
173 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
174 (delete_window, Fset_window_configuration): Call
175 delete_all_subwindows with window as argument.
176 (delete_all_subwindows): Take a window as argument and not a
177 structure. Rewrite.
190b47e6
MR
178 (window_loop): Remove handling of GET_LRU_WINDOW and
179 GET_LARGEST_WINDOW.
180 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
181
182 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
183 window_box_text_cols. delete_all_subwindows now takes a
184 Lisp_Object as argument.
abde8f8c
MR
185
186 * indent.c (compute_motion, Fcompute_motion): Use
187 window_body_cols instead of window_box_text_cols.
188
fa8a67e6
MR
189 * frame.c (delete_frame): Call delete_all_subwindows with root
190 window as argument.
191
a54e3482
DC
1922011-06-07 Daniel Colascione <dan.colascione@gmail.com>
193
194 * fns.c (Fputhash): Document return value.
195
60002bf5
CY
1962011-06-06 Chong Yidong <cyd@stupidchicken.com>
197
198 * image.c (gif_load): Implement gif89a spec "no disposal" method.
199
0c671da6 2002011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 201
b862a52a 202 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 203
be44ca6c
PE
204 Check for overflow when converting integer to cons and back.
205 * charset.c (Fdefine_charset_internal, Fdecode_char):
206 Use cons_to_unsigned to catch overflow.
207 (Fencode_char): Use INTEGER_TO_CONS.
208 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
209 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
210 * data.c (long_to_cons, cons_to_long): Remove.
211 (cons_to_unsigned, cons_to_signed): New functions.
212 These signal an error for invalid or out-of-range values.
213 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
214 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
215 * font.c (Ffont_variation_glyphs):
216 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
217 * lisp.h: Include <intprops.h>.
218 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
219 (cons_to_signed, cons_to_unsigned): New decls.
220 (long_to_cons, cons_to_long): Remove decls.
221 * undo.c (record_first_change): Use INTEGER_TO_CONS.
222 (Fprimitive_undo): Use CONS_TO_INTEGER.
223 * xfns.c (Fx_window_property): Likewise.
224 * xselect.c: Include <limits.h>.
225 (x_own_selection, selection_data_to_lisp_data):
226 Use INTEGER_TO_CONS.
227 (x_handle_selection_request, x_handle_selection_clear)
228 (x_get_foreign_selection, Fx_disown_selection_internal)
229 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
230 (lisp_data_to_selection_data): Use cons_to_unsigned.
231 (x_fill_property_data): Use cons_to_signed.
232 Report values out of range.
233
d1f3d2af
PE
234 Check for buffer and string overflow more precisely.
235 * buffer.h (BUF_BYTES_MAX): New macro.
236 * lisp.h (STRING_BYTES_MAX): New macro.
237 * alloc.c (Fmake_string):
238 * character.c (string_escape_byte8):
239 * coding.c (coding_alloc_by_realloc):
240 * doprnt.c (doprnt):
241 * editfns.c (Fformat):
242 * eval.c (verror):
243 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
244 since they may not be the same number.
245 * editfns.c (Finsert_char):
246 * fileio.c (Finsert_file_contents):
247 Likewise for BUF_BYTES_MAX.
248
dd52fcea
PE
249 * image.c: Use ptrdiff_t, not int, for sizes.
250 (slurp_file): Switch from int to ptrdiff_t.
251 All uses changed.
252 (slurp_file): Check that file size fits in both size_t (for
253 malloc) and ptrdiff_t (for sanity and safety).
254
7f9bbdbb
PE
255 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
256 if b->modtime has its maximal value.
257
dfe18f82
PE
258 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
259
84acfcf0
PE
260 Don't assume time_t can fit into int.
261 * buffer.h (struct buffer.modtime): Now time_t, not int.
262 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
263 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
264
ccd9a01a
PE
265 Minor fixes for signed vs unsigned integers.
266 * character.h (MAYBE_UNIFY_CHAR):
267 * charset.c (maybe_unify_char):
268 * keyboard.c (read_char, reorder_modifiers):
269 XINT -> XFASTINT, since the integer must be nonnegative.
270 * ftfont.c (ftfont_spec_pattern):
271 * keymap.c (access_keymap, silly_event_symbol_error):
272 XUINT -> XFASTINT, since the integer must be nonnegative.
273 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
274 since it makes no difference and we prefer signed.
275 * keyboard.c (record_char): Use XUINT when all the neighbors do.
276 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
277 nonnegative.
278
d6d100dd
SM
2792011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
280
281 * window.h (Fwindow_frame): Declare.
282
2b6148e4
PE
2832011-06-06 Paul Eggert <eggert@cs.ucla.edu>
284
285 * alloc.c: Simplify handling of large-request failures (Bug#8800).
286 (SPARE_MEMORY): Always define.
287 (LARGE_REQUEST): Remove.
288 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
289
f230ecc9
MR
2902011-06-06 Martin Rudalics <rudalics@gmx.at>
291
727e958e
MR
292 * lisp.h: Move EXFUNS for Fframe_root_window,
293 Fframe_first_window and Fset_frame_selected_window to window.h.
294
295 * window.h: Move EXFUNS for Fframe_root_window,
296 Fframe_first_window and Fset_frame_selected_window here from
297 lisp.h.
298
299 * frame.c (Fwindow_frame, Fframe_first_window)
300 (Fframe_root_window, Fframe_selected_window)
301 (Fset_frame_selected_window): Move to window.c.
302 (Factive_minibuffer_window): Move to minibuf.c.
303 (Fother_visible_frames_p): New function.
304
305 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
306
f230ecc9
MR
307 * window.c (decode_window, decode_any_window): Move up in code.
308 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
309 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
310 (Fwindow_buffer): Move up and rewrite doc-string.
311 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
312 (Fwindow_prev): New functions.
727e958e
MR
313 (Fwindow_frame): Move here from frame.c. Accept any window as
314 argument.
315 (Fframe_root_window, Fframe_first_window)
316 (Fframe_selected_window): Move here from frame.c. Accept frame
317 or arbitrary window as argument. Update doc-strings.
318 (Fminibuffer_window): Move up in code.
319 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
320 (Fset_frame_selected_window): Move here from frame.c.
321 Marginal rewrite.
727e958e
MR
322 (Fselected_window, select_window, Fselect_window): Move up in
323 code. Minor doc-string fixes.
f230ecc9 324
4d09bcf6
PE
3252011-06-06 Paul Eggert <eggert@cs.ucla.edu>
326
327 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
328 Do not assume that spare memory exists; that assumption is valid
329 only if SYSTEM_MALLOC.
330 (LARGE_REQUEST): New macro, so that the issue of large requests
331 is separated from the issue of spare memory.
332
810928a2
AS
3332011-06-05 Andreas Schwab <schwab@linux-m68k.org>
334
172418ad
AS
335 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
336 format. (Bug#8806)
337
43f862f7
AS
338 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
339
810928a2
AS
340 * xfns.c (x_set_scroll_bar_default_width): Move declarations
341 before statements.
342
a059fe24
JD
3432011-06-05 Jan Djärv <jan.h.d@swipnet.se>
344
345 * gtkutil.c (xg_get_default_scrollbar_width): New function.
346
347 * gtkutil.h: Declare xg_get_default_scrollbar_width.
348
349 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
350 min width by calling x_set_scroll_bar_default_width (Bug#8505).
351
989bf368
JB
3522011-06-05 Juanma Barranquero <lekktu@gmail.com>
353
354 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
355
4b80f674
CY
3562011-06-04 Chong Yidong <cyd@stupidchicken.com>
357
358 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
359 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
360 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
361 New error handlers.
4b80f674
CY
362 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
363 Obey Vx_select_enable_clipboard_manager. Catch errors in
364 x_clipboard_manager_save (Bug#8779).
365 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 366 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 367
99a33b77 3682011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
369
370 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
371
99a33b77 3722011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
373
374 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
375 in the current matrix if keep_current_p is non-zero.
376
8264569d
EZ
3772011-06-04 Eli Zaretskii <eliz@gnu.org>
378
379 * bidi.c (bidi_level_of_next_char): Fix last change.
380
57f97249
EZ
3812011-06-03 Eli Zaretskii <eliz@gnu.org>
382
fec2107c 383 Support bidi reordering of text covered by display properties.
57f97249 384
fec2107c
EZ
385 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
386 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
387 (bidi_cache_search, bidi_cache_iterator_state)
388 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
389 (bidi_level_of_next_char, bidi_move_to_visually_next):
390 Support character positions inside a run of characters covered by a
fec2107c
EZ
391 display string.
392 (bidi_paragraph_init, bidi_resolve_explicit_1)
393 (bidi_level_of_next_char): Call bidi_fetch_char and
394 bidi_fetch_char_advance instead of FETCH_CHAR and
395 FETCH_CHAR_ADVANCE.
396 (bidi_init_it): Initialize new members.
397 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
398 definitions.
399 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
400 instead of using explicit *_CHAR codes.
d6d100dd
SM
401 (bidi_resolve_explicit, bidi_resolve_weak):
402 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
403 bidirectional text is supported only in multibyte buffers.
404 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
405 it to initialize the frame_window_p member of struct bidi_it.
406 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
407 (bidi_resolve_explicit, bidi_resolve_weak)
408 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
409 bidi_it->nchars is non-positive.
410 (bidi_level_of_next_char): Don't try to lookup the cache for the
411 next/previous character if nothing is cached there yet, or if we
412 were just reseat()'ed to a new position.
c40e2fb2 413
0e14fe90
EZ
414 * xdisp.c (set_cursor_from_row): Set start and stop points
415 according to the row's direction when priming the loop that looks
416 for the glyph on which to display cursor.
417 (single_display_spec_intangible_p): Function deleted.
418 (display_prop_intangible_p): Reimplement to call
419 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
420 Accept 3 additional arguments needed by handle_display_spec.
421 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
422 values: lists, `(when COND...)' forms, etc.
423 (single_display_spec_string_p): Support property values that are
424 lists with the argument STRING its top-level element.
425 (display_prop_string_p): Fix the condition for processing a
426 property that is a list to be consistent with handle_display_spec.
fec2107c 427 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
428 last portion of handle_display_prop.
429 (compute_display_string_pos): Accept additional argument
430 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
431 value of a `display' property is a "replacing spec".
432 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
433 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
434 the display property, but just return a value indicating whether
435 the display property will replace the characters it covers.
436 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
437 frame_window_p members of struct bidi_it.
d6d100dd
SM
438 (compute_display_string_pos, compute_display_string_end):
439 New functions.
fec2107c
EZ
440 (push_it): Accept second argument POSITION, where pop_it should
441 jump to continue iteration.
442 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 443
fec2107c
EZ
444 * keyboard.c (adjust_point_for_property): Adjust the call to
445 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
446
447 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
448 (bidi_init_it): Update prototypes.
449 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
450 (compute_display_string_pos, compute_display_string_end):
451 Declare prototypes.
fec2107c
EZ
452 (struct bidi_it): New members nchars and disp_pos. ch_len is now
453 EMACS_INT.
fc6f18ce 454
40087514 4552011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 456
57f53182
PE
457 Malloc failure behavior now depends on size of allocation.
458 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
459 * lisp.h: Change signatures accordingly.
460 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
461 All callers changed. (Bug#8762)
462
463 * gnutls.c: Use Emacs's memory allocators.
464 Without this change, the gnutls library would invoke malloc etc.
465 directly, which causes problems on non-SYNC_INPUT hosts, and which
466 runs afoul of improving memory_full behavior. (Bug#8761)
467 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
468 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
469 xfree instead of the default malloc, realloc, free.
470 (Fgnutls_boot): No need to check for memory allocation failure,
471 since xmalloc does that for us.
472
ac32cd99 473 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
474 * category.c (hash_get_category_set):
475 * ccl.c (ccl_driver):
476 * charset.c (Fdefine_charset_internal):
477 * charset.h (struct charset.hash_index):
478 * composite.c (get_composition_id, gstring_lookup_cache)
479 (composition_gstring_put_cache):
480 * composite.h (struct composition.hash_index):
481 * dispextern.h (struct image.hash):
482 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
483 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
484 (hashfn_equal, hashfn_user_defined, make_hash_table)
485 (maybe_resize_hash_table, hash_lookup, hash_put)
486 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
487 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
488 (Fsxhash, Fgethash, Fputhash, Fmaphash):
489 * image.c (make_image, search_image_cache, lookup_image)
490 (xpm_put_color_table_h):
491 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 492 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
493 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
494 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
495 * alloc.c (allocate_vectorlike):
496 Check for overflow in vector size calculations.
497 * ccl.c (ccl_driver):
498 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
499 * fns.c, image.c: Remove unnecessary static decls that would otherwise
500 need to be updated by these changes.
40087514
PE
501 * fns.c (make_hash_table, maybe_resize_hash_table):
502 Check for integer overflow with large hash tables.
0de4bb68
PE
503 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
504 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
505 (SXHASH_REDUCE): New macro.
506 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
507 Use it instead of discarding useful hash info with large hash values.
508 (sxhash_float): New function.
509 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
510 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
511 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
512 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
513 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
514 Adjust signatures to match updated version of code.
515 (consing_since_gc): Now EMACS_INT, since a single hash table can
516 use more than INT_MAX bytes.
517
698d32e2
DN
5182011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
519
520 Make it possible to build with GCC-4.6+ -O2 -flto.
521
522 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
523
fd6fa53f
SM
5242011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
525
526 * minibuf.c (get_minibuffer, read_minibuf_unwind):
527 Call minibuffer-inactive-mode.
528
864db017
JB
5292011-05-31 Juanma Barranquero <lekktu@gmail.com>
530
531 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
532 Update dependencies.
533
2ad0baf4
DN
5342011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
535
536 * data.c (init_data): Remove code for UTS, this system is not
537 supported anymore.
538
4fcc2638
DN
5392011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
540
541 Don't force ./temacs to start in terminal mode.
542
543 * frame.c (make_initial_frame): Initialize faces in all cases, not
544 only when CANNOT_DUMP is defined.
545 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
546
c56e0fd5
DN
5472011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
548
549 * dispnew.c (add_window_display_history): Use const for the string
550 pointer. Remove declaration, not needed.
551
333d54da 5522011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 553
55d4c1b2 554 Use 'inline', not 'INLINE'.
333d54da 555 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
556 * alloc.c, fontset.c (INLINE): Remove.
557 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
558 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
559 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
560 * gmalloc.c (register_heapinfo): Use inline unconditionally.
561 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
562
738db178
DN
5632011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
564
565 Make it possible to run ./temacs.
566
567 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
568 syms_of_callproc does the same thing. Remove test for
569 "initialized", do it in the caller.
570 * emacs.c (main): Avoid calling set_initial_environment when dumping.
571
620c53a6
SM
5722011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
573
574 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
575 (read_minibuf): Use get_minibuffer.
576 (syms_of_minibuf): Use DEFSYM.
577 (Qmetadata): New var.
578 * data.c (Qbuffer): Don't make it static.
579 (syms_of_data): Use DEFSYM.
580
e003a292
PE
5812011-05-31 Paul Eggert <eggert@cs.ucla.edu>
582
583 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
584 (CCL_CODE_MIN): New macro.
585
ed008a6d
PE
5862011-05-30 Paul Eggert <eggert@cs.ucla.edu>
587
3687c2ef
PE
588 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
589
ed008a6d
PE
590 * eval.c (Qdebug): Now static.
591 * lisp.h (Qdebug): Remove decl. This reverts a part of the
592 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
593 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
594
d66c4c7c
CY
5952011-05-29 Chong Yidong <cyd@stupidchicken.com>
596
597 * image.c: Various fixes to ImageMagick code comments.
598 (Fimagemagick_types): Doc fix.
599
5fbc2025
PE
6002011-05-29 Paul Eggert <eggert@cs.ucla.edu>
601
0196f88a
PE
602 Minor fixes prompted by GCC 4.6.0 warnings.
603
604 * xselect.c (converted_selections, conversion_fail_tag): Now static.
605
5fbc2025
PE
606 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
607 (x_clipboard_manager_save_all): Move extern decl to ...
608 * xterm.h: ... here, so that it can be checked for consistency.
609
1dd3c2d9
CY
6102011-05-29 Chong Yidong <cyd@stupidchicken.com>
611
612 * xselect.c (x_clipboard_manager_save_frame)
613 (x_clipboard_manager_save_all): New functions.
614 (Fx_clipboard_manager_save): Lisp function deleted.
615
616 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
617 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
618
619 * xterm.h: Update prototype.
620
5ba6571d
WX
6212011-05-28 William Xu <william.xwl@gmail.com>
622
623 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
624 exiting (Bug#8239).
625
3eaff834
JM
6262011-05-28 Jim Meyering <meyering@redhat.com>
627
e1900994 628 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
629 * fns.c (to_uchar): Define.
630 (crypto_hash_function): Use it to convert some newly-signed
631 variables to unsigned, to avoid sign-extension bugs. For example,
632 without this change, (md5 "truc") would evaluate to
633 45723a2aff78ff4fff7fff1114760e62 rather than the expected
634 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 635 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 636
0f6990a7
PE
6372011-05-27 Paul Eggert <eggert@cs.ucla.edu>
638
639 Integer overflow fixes.
c8a9ca5a 640
08686060
PE
641 * dbusbind.c: Serial number integer overflow fixes.
642 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
643 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
644 to hold a serial number that is too large for a fixnum.
645 (Fdbus_method_return_internal, Fdbus_method_error_internal):
646 Check for serial numbers out of range. Decode any serial number
59568bf0 647 that was so large that it became a float. (Bug#8722)
08686060 648
2d1fc3c7
PE
649 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
650 (Fdbus_call_method, Fdbus_call_method_asynchronously):
651 Use XFASTINT rather than XUINT when numbers are nonnegative.
652 (xd_append_arg, Fdbus_method_return_internal):
653 (Fdbus_method_error_internal): Likewise. Also, for unsigned
654 arguments, check that Lisp number is nonnegative, rather than
59568bf0 655 silently wrapping negative numbers around. (Bug#8722)
30217ff0 656 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 657 (Bug#8722)
2d1fc3c7 658
c8a9ca5a
PE
659 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
660
519e1d69
PE
661 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
662
30569699
PE
663 ccl: add integer overflow checks
664 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
665 (IN_INT_RANGE): New macros.
666 (ccl_driver): Use them to check for integer overflow when
667 decoding a CCL program. Many of the new checks are whether XINT (x)
668 fits in int; it doesn't always, on 64-bit hosts. The new version
669 doesn't catch all possible integer overflows, but it's an
847044ea 670 improvement. (Bug#8719)
30569699 671
c11285dc
PE
672 * alloc.c (make_event_array): Use XINT, not XUINT.
673 There's no need for unsigned here.
674
fdccd48e
PE
675 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
676 This follows up to the 2011-05-06 change that substituted uintptr_t
677 for EMACS_INT. This case wasn't caught back then.
678
37910ab2
PE
679 Rework Fformat to avoid integer overflow issues.
680 * editfns.c: Include <float.h> unconditionally, as it's everywhere
681 now (part of C89). Include <verify.h>.
682 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
683 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
684 (Fformat): Avoid the prepass trying to compute sizes; it was only
685 approximate and thus did not catch overflow reliably. Instead, walk
686 through the format just once, formatting and computing sizes as we go,
687 checking for integer overflow at every step, and allocating a larger
688 buffer as needed. Keep track separately whether the format is
689 multibyte. Keep only the most-recently calculated precision, rather
690 than them all. Record whether each argument has been converted to
691 string. Use EMACS_INT, not int, for byte and char and arg counts.
692 Support field widths and precisions larger than INT_MAX. Avoid
693 sprintf's undefined behavior with conversion specifications such as %#d
694 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
695 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
696 formatting out-of-range floating point numbers with int
697 formats. (Bug#8668)
698
2e6578fb
PE
699 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
700
0ae6bdee
PE
701 * data.c: Avoid integer truncation in expressions involving floats.
702 * data.c: Include <intprops.h>.
703 (arith_driver): When there's an integer overflow in an expression
704 involving floating point, convert the integers to floating point
705 so that the resulting value does not suffer from catastrophic
706 integer truncation. For example, on a 64-bit host (* 4
707 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
708 Do not rely on undefined behavior after integer overflow.
709
de883a70
PE
710 merge count_size_as_multibyte, parse_str_to_multibyte
711 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 712 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
713 Check for integer overflow.
714 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
715 since it's now a duplicate of the other. This is more of
716 a character than a buffer op, so better that it's in character.c.
717 * fns.c, print.c: Adjust to above changes.
718
2ff916cb
PE
7192011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
720
721 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
722
f1b54466
PE
7232011-05-27 Paul Eggert <eggert@cs.ucla.edu>
724
fb1ac845
PE
725 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
726 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
727 (x_clipboard_manager_save): Now static.
728 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
729
f1b54466
PE
730 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
731 (crypto_hash_function): Now static.
732 Fix pointer signedness problems. Avoid unnecessary initializations.
733
a9f737ee
CY
7342011-05-27 Chong Yidong <cyd@stupidchicken.com>
735
736 * termhooks.h (Vselection_alist): Make it terminal-local.
737
738 * terminal.c (create_terminal): Initialize it.
739
740 * xselect.c: Support for clipboard managers.
741 (Vselection_alist): Move to termhooks.h as terminal-local var.
742 (LOCAL_SELECTION): New macro.
743 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
744 (symbol_to_x_atom): Remove gratuitous arg.
745 (x_handle_selection_request, lisp_data_to_selection_data)
746 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
747 (x_own_selection, x_get_local_selection, x_convert_selection):
748 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
749 (some_frame_on_display): Delete unused function.
750 (Fx_own_selection_internal, Fx_get_selection_internal)
751 (Fx_disown_selection_internal, Fx_selection_owner_p)
752 (Fx_selection_exists_p): New optional frame arg.
753 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
754 (x_handle_selection_clear): Don't treat other terminals with the
755 same keyboard specially. Use the terminal-local Vselection_alist.
756 (x_clear_frame_selections): Use Frun_hook_with_args.
757
758 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
759
760 * xterm.h: Add support for those atoms.
761
e067f0c1
CY
7622011-05-26 Chong Yidong <cyd@stupidchicken.com>
763
764 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
765 (converted_selections, conversion_fail_tag): New global variables.
766 (x_selection_request_lisp_error): Free the above.
767 (x_get_local_selection): Remove unnecessary code.
768 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
769 of converted selections stored in converted_selections.
770 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
771 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
772 (x_convert_selection): New function.
773 (x_handle_selection_event): Simplify.
774 (x_get_foreign_selection): Don't ignore incoming requests while
775 waiting for an answer; this will fail when we implement
776 SAVE_TARGETS, and seems unnecessary anyway.
777 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
778 (Vx_sent_selection_functions): Doc fix.
779
0f4aebc0
LL
7802011-05-26 Leo Liu <sdl.web@gmail.com>
781
782 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
783
e61124cd
YM
7842011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
785
786 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
787
788 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
789 for fringe update if it has periodic bitmap.
790 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
791 and fringe_bitmap_periodic_p.
792
793 * fringe.c (get_fringe_bitmap_data): New function.
794 (draw_fringe_bitmap_1, update_window_fringes): Use it.
795 (update_window_fringes): Record periodicity of fringe bitmap in glyph
796 row. Mark glyph row for fringe update if periodicity changed.
797
798 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
799 for fringe update unless it has periodic bitmap.
800
f16d9837
KH
8012011-05-25 Kenichi Handa <handa@m17n.org>
802
803 * xdisp.c (get_next_display_element): Set correct it->face_id for
804 a static composition.
805
e1b90ef6
LL
8062011-05-24 Leo Liu <sdl.web@gmail.com>
807
808 * deps.mk (fns.o):
809 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
810
811 * fns.c (crypto_hash_function, Fsha1): New function.
812 (Fmd5): Use crypto_hash_function.
813 (syms_of_fns): Add Ssha1.
814
7400048f
PE
8152011-05-22 Paul Eggert <eggert@cs.ucla.edu>
816
817 * gnutls.c: Remove unused macros.
818 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
819 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
820 Remove macros that are defined and never used.
821 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
822
abb71cf4
CY
8232011-05-22 Chong Yidong <cyd@stupidchicken.com>
824
825 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
826 (Fx_get_selection_internal): Minor cleanup.
827 (Fx_own_selection_internal): Rename arguments for consistency with
828 select.el.
829
6307db39
PE
8302011-05-22 Paul Eggert <eggert@cs.ucla.edu>
831
832 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
833
f3d4e0a4
CY
8342011-05-22 Chong Yidong <cyd@stupidchicken.com>
835
836 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
837
4d8ade89
YM
8382011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
839
840 * dispnew.c (scrolling_window): Don't exclude the case that the
841 last enabled row in the desired matrix touches the bottom boundary.
842
32078c8d
GM
8432011-05-21 Glenn Morris <rgm@gnu.org>
844
845 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
846 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
847 and add some more files.
32078c8d 848
7285dc67
EZ
8492011-05-20 Eli Zaretskii <eliz@gnu.org>
850
851 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
852 report_file_error introduced by the change from 2011-05-07.
853
89d1bd22
PE
8542011-05-20 Paul Eggert <eggert@cs.ucla.edu>
855
856 * systime.h (Time): Define only if emacs is defined.
857 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
858 where the include path doesn't have X11/X.h by default. See
859 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
860
e23640bb 8612011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
862
863 * composite.c (find_automatic_composition): Fix previous change.
864
b9704ad9
GM
8652011-05-20 Glenn Morris <rgm@gnu.org>
866
867 * lisp.mk: New file, split from Makefile.in.
868 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
869 (shortlisp): Remove.
870 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
871
4a720484
GM
8722011-05-19 Glenn Morris <rgm@gnu.org>
873
874 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
875 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
876 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
877 (lisp): Set the order to that of loadup.el.
878 (shortlisp): Make it a copy of $lisp.
879 (SOME_MACHINE_LISP): Remove.
880 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
881 Use just $shortlisp, not $SOME_MACHINE_LISP too.
882
a28d4396
KH
8832011-05-18 Kenichi Handa <handa@m17n.org>
884
885 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
886 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
887 (find_automatic_composition): Mostly rewrite for efficiency.
888
a2b1fa8e
JB
8892011-05-18 Juanma Barranquero <lekktu@gmail.com>
890
891 * makefile.w32-in: Update dependencies.
892
8e1f5610
CS
8932011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
894
895 * menu.c: Include limits.h (fixes the MS-Windows build broken by
896 revision 104625).
897
7025ee00 8982011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 899
cdfa6eab
PE
900 Fix some integer overflow issues, such as string length overflow.
901
06d6db33
PE
902 * insdel.c (count_size_as_multibyte): Check for string overflow.
903
2b4560a8
PE
904 * character.c (lisp_string_width): Check for string overflow.
905 Use EMACS_INT, not int, for string indexes and lengths; in
906 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
907 the resulting string length overflows an EMACS_INT; instead,
908 report a string overflow if no precision given. When checking for
909 precision exhaustion, use a check that cannot possibly have
910 integer overflow. (Bug#8675)
911 * character.h (lisp_string_width): Adjust to new signature.
912
cb93f9be
PE
913 * alloc.c (string_overflow): New function.
914 (Fmake_string): Use it. This doesn't change behavior, but saves
915 a few bytes and will simplify future changes.
916 * character.c (string_escape_byte8): Likewise.
917 * lisp.h (string_overflow): New decl.
918
1a1f3366
PE
919 Fixups, following up to the user-interface timestamp change.
920 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
921 for UI timestamps, instead of unsigned long.
9fbd6841
PE
922 * msdos.c (mouse_get_pos): Likewise.
923 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
924 * w32gui.h (Time): Define by including "systime.h" rather than by
925 declaring it ourselves. (Bug#8664)
926
d4e3e4d3
PE
927 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
928 * image.c (clear_image_cache): Likewise.
929
f6a24d19
PE
930 * term.c (term_mouse_position): Don't assume time_t wraparound.
931
08dc5ae6
PE
932 Be more systematic about user-interface timestamps.
933 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
934 and sometimes 'EMACS_UINT', to represent these timestamps.
935 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
936 This makes the code easier to follow, and makes it easier to catch
937 integer overflow bugs such as Bug#8664.
938 * frame.c (Fmouse_position, Fmouse_pixel_position):
939 Use Time, not unsigned long, for user-interface timestamps.
940 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
941 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
942 * keyboard.h (last_event_timestamp): Likewise.
943 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
944 * menu.h (xmenu_show): Likewise.
945 * term.c (term_mouse_position): Likewise.
946 * termhooks.h (struct input_event.timestamp): Likewise.
947 (struct terminal.mouse_position_hook): Likewise.
948 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
949 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
950 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
951 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
952 what it was before.
953 * menu.h, termhooks.h: Include "systime.h", for Time.
954
8e55734a
PE
955 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
956 Don't assume that the difference between two unsigned long values
957 can fit into an integer. At this point, we know button_down_time
958 <= event->timestamp, so the difference must be nonnegative, so
959 there's no need to cast the result if double-click-time is
960 nonnegative, as it should be; check that it's nonnegative, just in
961 case. This bug is triggered when events are more than 2**31 ms
86db42d2 962 apart (about 25 days). (Bug#8664)
8e55734a 963
841f1b75 964 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 965 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 966
3e26f69c
PE
967 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
968 that always fit in int. Use a sentinel instead of a counter, to
969 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
970 * frame.h (struct frame): Use int for menu_bar_items_used
971 instead of EMACS_INT, since it always fits in int.
3e26f69c 972
5cc152c0
PE
973 * menu.c (grow_menu_items): Check for int overflow.
974
d89eb65e
PE
975 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
976
5235bd3e
PE
977 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
978 Before, the code was not consistent. These values cannot exceed
979 2**31 - 1 so there's no need to make them unsigned.
980 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
981 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
982 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
983 as modifiers.
984 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
985
bc827e23
PE
986 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
987 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
988 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
989 presumably because the widths might not match.
990
78eb494e
PE
991 * window.c (size_window): Avoid needless test at loop start.
992
04f2d78b
CB
9932011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
994
995 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
996
d2fc7e3d 9972011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
998
999 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1000
d2fc7e3d 10012011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
1002
1003 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1004 `width' to `bar_area_x' and `bar_area_width', respectively.
1005 (x_scroll_run): Take account of fringe background extension.
1006
04f2d78b
CB
1007 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1008 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
1009 `bar_area_width', respectively.
1010 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1011 background extension.
1012
79b70037
GM
10132011-05-10 Jim Meyering <meyering@redhat.com>
1014
1015 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1016
2f142cc5
JB
10172011-05-10 Juanma Barranquero <lekktu@gmail.com>
1018
1019 * image.c (Finit_image_library): Return t for built-in image types,
1020 like pbm and xbm. (Bug#8640)
1021
57679c86
AS
10222011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1023
1024 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1025
888c9e86
EZ
10262011-05-07 Eli Zaretskii <eliz@gnu.org>
1027
b0512a1d
EZ
1028 * w32console.c (Fset_screen_color): Doc fix.
1029 (Fget_screen_color): New function.
1030 (syms_of_ntterm): Defsubr it.
1031
7285dc67
EZ
1032 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1033 unlink the temporary file if Fcall_process didn't create it in the
1034 first place.
1035 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1036 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
1037 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1038 cue to call_process_cleanup not to close that handle.
1039
4d3fcc8e
BK
10402011-05-07 Ben Key <bkey76@gmail.com>
1041
1042 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1043 one of two shell specific rules, either bootstrap-temacs-CMD or
1044 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1045 to the previous implementation of the bootstrap-temacs rule.
1046 The bootstrap-temacs-CMD rule is similar to the previous
1047 implementation of the bootstrap-temacs rule except that it
1048 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1049 variable.
1050
1051 These changes, along with some changes to nt/configure.bat,
1052 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1053 earlier fix to add support for --cflags and --ldflags options
1054 that include quotes so that it works whether make uses cmd or
1055 sh as the shell.
1056
b4289b64
MA
10572011-05-06 Michael Albinus <michael.albinus@gmx.de>
1058
1059 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1060 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1061 is a constant.
1062 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1063 a string. Handle both cases.
1064 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1065 (Fdbus_register_method): Use Qinvalid_function.
1066
af4c0e28
JB
10672011-05-06 Juanma Barranquero <lekktu@gmail.com>
1068
1069 * makefile.w32-in: Update dependencies.
1070 (LISP_H): Add inttypes.h and stdin.h.
1071 (PROCESS_H): Add unistd.h.
1072
c51453d9
EZ
10732011-05-06 Eli Zaretskii <eliz@gnu.org>
1074
1075 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1076 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1077
8ff0ac3c 10782011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 1079
4c4b566b
PE
1080 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1081
aab2b9b5
PE
1082 * term.c (vfatal): Remove stray call to va_end.
1083 It's not needed and the C Standard doesn't allow it here anyway.
1084
c378da0b
PE
1085 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1086 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1087
288b08c7
PE
1088 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1089 bytes.
1090
e3601888
PE
1091 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1092
db6c0e74
PE
1093 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1094
dd5963ea
PE
1095 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1096
88c9450f
PE
1097 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1098
2f9442b8
PE
1099 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1100
c032b5f8
PE
1101 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1102 * charset.c (Fdefine_charset_internal): Don't initialize
1103 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 1104 32-bit int (Bug#8600).
a108c10b
PE
1105
1106 * lread.c (read_integer): Be more consistent with string-to-number.
1107 Use string_to_number to do the actual conversion; this avoids
1108 rounding errors and fixes some other screwups. Without this fix,
1109 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1110 (digit_to_number): Move earlier, for benefit of read_integer.
1111 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 1112 not a digit in any supported base. (Bug#8602)
a108c10b 1113
ad5f9eea
PE
1114 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1115
aec1708a
PE
1116 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1117 to match comment at start of function. This also removes a
1118 GCC warning about overflow in a 32+64-bit port.
1119
47be4ab5
PE
1120 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1121
371cac43
PE
1122 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1123 Reported by Stefan Monnier in
1124 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
1125 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1126 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 1127
d01a7826
PE
1128 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1129 (EMACS_UINTPTR): Likewise, with uintptr_t.
1130
7fd47d5c
PE
1131 * lisp.h: Prefer 64-bit EMACS_INT if available.
1132 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1133 on 32-bit hosts that have 64-bit int, so that they can access
1134 large files.
122b0c86
PE
1135 However, temporarily disable this change unless the temporary
1136 symbol WIDE_EMACS_INT is defined.
7fd47d5c 1137
8727937b
PE
1138 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1139
8ac068ac
PE
1140 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1141 This removes an assumption that EMACS_INT and long are the same
1142 width as pointers. The assumption is true for Emacs porting targets
1143 now, but we want to make other targets possible.
1144 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1145 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1146 In the rest of the code, change types of integers that hold casted
1147 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1148 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1149 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1150 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1151 No need to cast type when ORing.
1152 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1153 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1154 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1155 assume EMACS_INT is the same width as char *.
1156 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1157 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1158 Remove no-longer-needed casts.
1159 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1160 (xg_tool_bar_help_callback, xg_make_tool_item):
1161 Use EMACS_INTPTR to hold an integer
1162 that will be cast to void *; this can avoid a GCC warning
1163 if EMACS_INT is not the same width as void *.
1164 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1165 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1166 (current_message_1, set_message_1):
1167 Use a local to convert to proper width without a cast.
1168 * xmenu.c (dialog_selection_callback): Likewise.
1169
ede49d71
PE
1170 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1171 Also, don't assume VALBITS / RAND_BITS is less than 5,
1172 and don't rely on undefined behavior when shifting a 1 left into
1173 the sign bit.
1174 * lisp.h (get_random): Change signature to match.
1175
2f30ecd0
PE
1176 * lread.c (hash_string): Use size_t, not int, for hash computation.
1177 Normally we prefer signed values; but hashing is special, because
1178 it's better to use unsigned division on hash table sizes so that
1179 the remainder is nonnegative. Also, size_t is the natural width
1180 for hashing into memory. The previous code used 'int', which doesn't
1181 retain enough info to hash well into very large tables.
1182 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1183
2a866e7b
PE
1184 * dbusbind.c: Don't possibly lose pointer info when converting.
1185 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1186 Use XPNTR rather than XHASH, so that the high-order bits of
1187 the pointer aren't lost when converting through void *.
1188
51639eac
PE
1189 * eval.c (Fautoload): Don't double-shift a pointer.
1190
92394119
PE
1191 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1192
dbdb9a7c
JB
11932011-05-06 Juanma Barranquero <lekktu@gmail.com>
1194
1195 * gnutls.c (DEF_GNUTLS_FN):
1196 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1197
db7a0b4f
AS
11982011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1199
1200 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1201 marker. (Bug#8610)
1202
f7ff1b0f 12032011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
1204
1205 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1206 New version that can reserve upto 2GB of heap space.
1207
f7ff1b0f 12082011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
1209
1210 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1211
639c109b
TZ
12122011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1213
1214 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1215 `gnutls_certificate_set_x509_key_file'.
1216
d2127135
JB
12172011-05-05 Juanma Barranquero <lekktu@gmail.com>
1218
1219 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1220 Update dependencies.
1221
e968f4f3
JB
12222011-05-04 Juanma Barranquero <lekktu@gmail.com>
1223
1224 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1225 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1226 Remove unused parameter `fildes'.
1227 * process.c (read_process_output, send_process): Don't pass it.
1228
84d358f0
JB
12292011-05-04 Juanma Barranquero <lekktu@gmail.com>
1230
1231 Fix previous change: the library cache is defined in w32.c.
1232 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1233 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1234
0898ca10
JB
12352011-05-04 Juanma Barranquero <lekktu@gmail.com>
1236
1237 Implement dynamic loading of GnuTLS on Windows.
1238
1239 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1240 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1241 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1242 Declare.
1243
1244 * gnutls.c (Qgnutls_dll): Define.
1245 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1246 (gnutls_*): Declare function pointers.
1247 (init_gnutls_functions): New function to initialize function pointers.
1248 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1249 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1250 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1251 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1252 (emacs_gnutls_write, emacs_gnutls_read)
1253 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1254 (Fgnutls_available_p): New function.
1255 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1256 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1257 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1258
1259 * image.c: Include w32.h.
1260 (Vimage_type_cache): Delete.
1261 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1262 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1263 (w32_delayed_load): Move to w32.c.
1264
1265 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1266
1267 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1268 (w32_delayed_load): Move from image.c. When loading a library, record
1269 its filename in the :loaded-from property of the library id.
1270 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1271 Initialize and staticpro them.
1272 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1273
1274 * process.c: Include lisp.h before w32.h, not after.
1275 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1276 instead of gnutls_record_check_pending.
1277
1278 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1279
ff4de4aa
TZ
12802011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1281
1282 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1283 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1284 as passed in.
1285
abe95abb
JD
12862011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1287
1288 * xterm.c (x_set_frame_alpha): Do not set property on anything
1289 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1290
e16e55d4
JB
12912011-05-02 Juanma Barranquero <lekktu@gmail.com>
1292
1293 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1294
bafcf6a5
JB
12952011-05-02 Juanma Barranquero <lekktu@gmail.com>
1296
1297 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1298 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1299 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1300 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1301 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1302 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1303 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1304 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1305 (Qgnutls_bootprop_callbacks_verify): Make static.
1306
e7a6747f
AS
13072011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1308
19ed11ba
AS
1309 * callproc.c: Indentation fixup.
1310
e7a6747f 1311 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
1312 (wait_for_termination, interruptible_wait_for_termination):
1313 Move after wait_for_termination_1.
e7a6747f 1314
1ef14cb4
LMI
13152011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1316
1317 * sysdep.c (interruptible_wait_for_termination): New function
1318 which is like wait_for_termination, but allows keyboard
1319 interruptions.
1320
1321 * callproc.c (Fcall_process): Add (:file "file") as an option for
1322 the STDOUT buffer.
1323 (Fcall_process_region): Ditto.
1324
330d880c
EZ
13252011-04-30 Eli Zaretskii <eliz@gnu.org>
1326
8db90b73
EZ
1327 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1328 rather than `XVECTOR (FOO)->size'.
1329
330d880c
EZ
1330 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1331 inttypes.h, as a gnulib replacement is used if it not available in
1332 system headers.
1333
15cbd324
EZ
13342011-04-21 Eli Zaretskii <eliz@gnu.org>
1335
1336 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1337 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1338 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1339
1340 * coding.c (coding_alloc_by_realloc): Error out if destination
1341 will grow beyond MOST_POSITIVE_FIXNUM.
1342 (decode_coding_emacs_mule): Abort if there isn't enough place in
1343 charbuf for the composition carryover bytes. Reserve an extra
1344 space for up to 2 characters produced in a loop.
1345 (decode_coding_iso_2022): Abort if there isn't enough place in
1346 charbuf for the composition carryover bytes.
1347
13482011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 1349
ae940cca
EZ
1350 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1351 aborting when %lld or %lll format is passed.
1352 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1353 %llo or %llx format is passed. (Bug#8545)
1354
03ab8921
EZ
1355 * window.c (window_scroll_line_based): Use a marker instead of
1356 simple variables to record original value of point. (Bug#7952)
1357
afda1437
EZ
1358 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1359 produced by %s or %c overflows available buffer space. (Bug#8545)
1360
f76dee0c
PE
13612011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1362
1363 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 1364 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 1365
fdc5744d
JB
13662011-04-28 Juanma Barranquero <lekktu@gmail.com>
1367
1368 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1369
638f053a
JB
13702011-04-28 Juanma Barranquero <lekktu@gmail.com>
1371
1372 * keyboard.c (Qdelayed_warnings_hook): Define.
1373 (command_loop_1): Run `delayed-warnings-hook'
1374 if Vdelayed_warnings_list is non-nil.
1375 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1376 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1377
d178f871
EZ
13782011-04-28 Eli Zaretskii <eliz@gnu.org>
1379
1380 * doprnt.c (doprnt): Don't return value smaller than the buffer
1381 size if the message was truncated. (Bug#8545).
1382
b124fd93
JB
13832011-04-28 Juanma Barranquero <lekktu@gmail.com>
1384
1385 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1386 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1387
e810457d
PE
13882011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1389
1390 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1391
ea51cceb
JB
13922011-04-27 Juanma Barranquero <lekktu@gmail.com>
1393
1394 * makefile.w32-in: Update dependencies.
1395
94dcfacf
EZ
13962011-04-27 Eli Zaretskii <eliz@gnu.org>
1397
1398 Improve `doprnt' and its usage. (Bug#8545)
1399 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1400 `format_end'. Remove support for %l as a conversion specifier.
1401 Don't use xrealloc. Improve diagnostics when the %l size modifier
1402 is used. Update the commentary.
1403
1404 * eval.c (verror): Simplify calculation of size_t.
1405
1406 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1407 messages.
1408
f61f41d7
PE
14092011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1410
1411 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1412 change.
1413
96fb4434
PE
14142011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1415
1416 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1417 This makes this file independent of the recent pseudovector change.
1418
671875da 14192011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 1420
69e9b5a3
PE
1421 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1422
b5f869a7 1423 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 1424 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 1425 Remove unused local.
c8926152 1426 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 1427
841a1577 1428 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
1429 GCC 4.6.0 optimizes based on type-based alias analysis.
1430 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
1431 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1432 != &v->size, and therefore "v->size = 1; b->size = 2; return
1433 v->size;" must therefore return 1. This assumption is incorrect
1434 for Emacs, since it type-puns struct Lisp_Vector * with many other
1435 types. To fix this problem, this patch adds a new type struct
f904488f 1436 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
1437 and pseudovectors, and helps optimizing compilers not get fooled
1438 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1439 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
1440 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1441 the size member.
eab3844f
PE
1442 (XSETPVECTYPE): Rewrite in terms of new macro.
1443 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1444 This is a bit clearer, and further avoids the possibility of
1445 undesirable aliasing.
1446 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 1447 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
1448 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1449 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
1450 (ASIZE): Now uses header.size rather than size.
1451 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
1452 to avoid the hassle of writing XVECTOR (foo)->header.size.
1453 (struct vectorlike_header): New type.
eab3844f
PE
1454 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1455 object, to help avoid aliasing.
1456 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1457 (SUBRP): Likewise, since Lisp_Subr is a special case.
1458 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1459 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1460 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 1461 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
1462 changed to be "header.size" and "header.next".
1463 * buffer.h (struct buffer): Likewise.
1464 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1465 * frame.h (struct frame): Likewise.
1466 * process.h (struct Lisp_Process): Likewise.
1467 * termhooks.h (struct terminal): Likewise.
1468 * window.c (struct save_window_data, struct saved_window): Likewise.
1469 * window.h (struct window): Likewise.
1470 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1471 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1472 * buffer.c (init_buffer_once): Likewise.
1473 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1474 special case.
1475 * process.c (Fformat_network_address): Use local var for size,
1476 for brevity.
1477
0df1eac5
PE
1478 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1479
847ab9d1 1480 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
1481 * data.c (atof): Remove decl; no longer used or needed.
1482 (digit_to_number): Move to lread.c.
1483 (Fstring_to_number): Use new string_to_number function, to be
1484 consistent with how the Lisp reader treats infinities and NaNs.
1485 Do not assume that floating-point numbers represent EMACS_INT
1486 without losing information; this is not true on most 64-bit hosts.
1487 Avoid double-rounding errors, by insisting on integers when
1488 parsing non-base-10 numbers, as the documentation specifies.
1489 * lisp.h (string_to_number): New decl, replacing ...
1490 (isfloat_string): Remove.
bc0a5c13 1491 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 1492 (read1): Do not accept +. and -. as integers; this
452f4150
PE
1493 appears to have been a coding error. Similarly, do not accept
1494 strings like +-1e0 as floating point numbers. Do not report
1495 overflow for integer overflows unless the base is not 10 which
1496 means we have no simple and reliable way to continue.
1497 Break out the floating-point parsing into a new
1498 function string_to_number, so that Fstring_to_number parses
1499 floating point numbers consistently with the Lisp reader.
04f2d78b 1500 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
1501 (E_CHAR, EXP_INT): Remove, replacing with ...
1502 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1503 (string_to_number): New function, replacing isfloat_string.
1504 This function checks for valid syntax and produces the resulting
1505 Lisp float number too. Rework it so that string-to-number
bc0a5c13 1506 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
1507 so that overflow for non-base-10 numbers is reported only when
1508 there's no portable and simple way to convert to floating point.
452f4150 1509
67769ffc
PE
1510 * textprop.c (set_text_properties_1): Rewrite for clarity,
1511 and to avoid GCC warning about integer overflow.
1512
c20db43f
PE
1513 * intervals.h (struct interval): Use EMACS_INT for members
1514 where EMACS_UINT might cause problems. See
1515 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1516 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1517 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1518 All uses changed.
37aa2f85
PE
1519 (offset_intervals): Tell GCC not to worry about length overflow
1520 when negating a negative length.
c20db43f 1521
2538aa2f
PE
1522 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1523 (overrun_check_free): Likewise.
1524
f2d3008d
PE
1525 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1526 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1527 word size.
1528
ec8df744
PE
1529 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1530 (gnutls_make_error): Rename local to avoid shadowing.
1531 (gnutls_emacs_global_deinit): ifdef out; not used.
1532 (Fgnutls_boot): Use const for pointer to readonly storage.
1533 Comment out unused local. Fix pointer signedness problems.
1534
640ee02d
PE
1535 * lread.c (openp): Don't stuff size_t into an 'int'.
1536 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
1537 about possible signed overflow.
1538
6048fb2a
PE
1539 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1540 (GDK_KEY_g): Don't define if already defined.
1541 (xg_prepare_tooltip): Avoid pointer signedness problem.
1542 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
1543
fa3c87e1
PE
1544 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
1545 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
1546
2172544b
PE
1547 * xfns.c (Fx_window_property): Simplify a bit,
1548 to make a bit faster and to avoid GCC 4.6.0 warning.
1549 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
1550
9b821a21
PE
1551 * fns.c (internal_equal): Don't assume size_t fits in int.
1552
3c616cfa
PE
1553 * alloc.c (compact_small_strings): Tighten assertion a little.
1554
c2982e87
PE
1555 Replace pEd with more-general pI, and fix some printf arg casts.
1556 * lisp.h (pI): New macro, generalizing old pEd macro to other
1557 conversion specifiers. For example, use "...%"pI"d..." rather
1558 than "...%"pEd"...".
1559 (pEd): Remove. All uses replaced with similar uses of pI.
1560 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
1561 * alloc.c (check_pure_size): Don't overflow by converting size to int.
1562 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
1563 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
1564 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
1565 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
1566 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
1567 64-bit hosts.
1568 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
1569 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
1570 * print.c (safe_debug_print, print_object): Likewise.
1571 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
1572 to int.
6f04d126
PE
1573 Use pI instead of if-then-else-abort. Use %p to avoid casts,
1574 avoiding the 0 flag, which is not portable.
c2982e87
PE
1575 * process.c (Fmake_network_process): Use pI to avoid cast.
1576 * region-cache.c (pp_cache): Likewise.
1577 * xdisp.c (decode_mode_spec): Likewise.
1578 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
1579 behavior on 64-bit hosts with printf arg.
6f04d126 1580 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
1581 (x_stop_queuing_selection_requests): Likewise.
1582 (x_get_window_property): Don't truncate byte count to an 'int'
1583 when tracing.
0b432f21 1584
5e073ec7
PE
1585 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
1586 here, since it parses constructs like leading '-' and spaces,
1587 which are not wanted; and it overflows with large numbers.
1588 Instead, simply match F[0-9]+, which is what is wanted anyway.
1589
36372bf9
PE
1590 * alloc.c: Remove unportable assumptions about struct layout.
1591 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
1592 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
1593 (allocate_vectorlike, make_pure_vector): Use the new macros,
1594 plus offsetof, to remove unportable assumptions about struct layout.
1595 These assumptions hold on all porting targets that I know of, but
1596 they are not guaranteed, they're easy to remove, and removing them
1597 makes further changes easier.
1598
0b432f21
PE
1599 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1600 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
1601 (string_overrun_cookie): Now const. Use initializers that
1602 don't formally overflow signed char, to avoid warnings.
000098c1
PE
1603 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1604 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
1605 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1606 multiple of sizeof (EMACS_INT); it need not be, if
1607 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 1608 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 1609
895009e1
JB
16102011-04-26 Juanma Barranquero <lekktu@gmail.com>
1611
1612 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1613
6a7a1b0b
TZ
16142011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1615
1616 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 1617 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
1618 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1619
841a1577 16202011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
1621
1622 * lisp.h (Qdebug): List symbol.
895009e1 1623 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
1624 * keyboard.c (debug-on-event): New variable.
1625 (handle_user_signal): Break into debugger when debug-on-event
1626 matches the current signal symbol.
1627
f2d3ba6f
DN
16282011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1629
1630 * alloc.c (check_sblock, check_string_bytes)
1631 (check_string_free_list): Convert to standard C.
1632
42ce4c63
TZ
16332011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1634
1635 * w32.c (emacs_gnutls_push): Fix typo.
1636
825cd63c
EZ
16372011-04-25 Eli Zaretskii <eliz@gnu.org>
1638
fb11d64d
EZ
1639 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1640 "cast to pointer from integer of different size".
1641
825cd63c
EZ
1642 Improve doprnt and its use in verror. (Bug#8545)
1643 * doprnt.c (doprnt): Document the set of format control sequences
1644 supported by the function. Use SAFE_ALLOCA instead of always
1645 using `alloca'.
1646
1647 * eval.c (verror): Don't limit the buffer size at size_max-1, that
1648 is one byte too soon. Don't use xrealloc; instead xfree and
1649 xmalloc anew.
1650
e061a11b
TZ
16512011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
1652
1653 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
1654 callbacks stage.
1655
1656 * gnutls.c: Renamed global_initialized to
1657 gnutls_global_initialized. Added internals for the
1658 :verify-hostname-error, :verify-error, and :verify-flags
1659 parameters of `gnutls-boot' and documented those parameters in the
1660 docstring. Start callback support.
1661 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
1662 unless a fatal error occured. Call gnutls_alert_send_appropriate
1663 on error. Return error code.
1664 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
1665 (emacs_gnutls_read): Likewise.
1666 (Fgnutls_boot): Return handshake error code.
1667 (emacs_gnutls_handle_error): New function.
1668 (wsaerror_to_errno): Likewise.
1669
1670 * w32.h (emacs_gnutls_pull): Add prototype.
1671 (emacs_gnutls_push): Likewise.
1672
1673 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
1674 (emacs_gnutls_push): Likewise.
1675
16762011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
1677
1678 * process.c (wait_reading_process_output): Check if GnuTLS
1679 buffered some data internally if no FDs are set for TLS
1680 connections.
1681
1682 * makefile.w32-in (OBJ2): Add gnutls.$(O).
1683 (LIBS): Link to USER_LIBS.
1684 ($(BLD)/gnutls.$(0)): New target.
1685
fa6996bc
EZ
16862011-04-24 Eli Zaretskii <eliz@gnu.org>
1687
eb35682e
EZ
1688 * xdisp.c (handle_single_display_spec): Rename the
1689 display_replaced_before_p argument into display_replaced_p, to
1690 make it consistent with the commentary. Fix typos in the
1691 commentary.
1692
e2ad650c
EZ
1693 * textprop.c (syms_of_textprop): Remove dead code.
1694 (copy_text_properties): Delete obsolete commentary about an
1695 interface that was deleted long ago. Fix typos in the description
1696 of arguments.
1697
1b2de274
EZ
1698 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
1699 to changes in oldXMenu/XMenu.h from 2011-04-16.
1700 <menu_help_message, prev_menu_help_message>: Constify.
1701 (IT_menu_make_room): menu->help_text is now `const char **';
1702 adjust.
1703
1704 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
1705 to changes in oldXMenu/XMenu.h from 2011-04-16.
1706 (struct XMenu): Declare `help_text' `const char **'.
1707
1708 * xfaces.c <Qunspecified>: Make extern again.
1709
1710 * syntax.c: Include sys/types.h before including regex.h, as
1711 required by Posix.
1712
762b15be
EZ
1713 * doc.c (get_doc_string): Improve the format passed to `error'.
1714
1715 * doprnt.c (doprnt): Improve commentary.
1716
1717 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
1718
1719 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
1720 them with etags.
1721
f1052e5d
EZ
1722 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
1723 changes in globals.h immediately force recompilation.
762b15be
EZ
1724 (TAGS): Depend on $(CURDIR)/m/intel386.h and
1725 $(CURDIR)/s/ms-w32.h.
1726 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 1727
fa6996bc
EZ
1728 * character.c (Fchar_direction): Function deleted.
1729 (syms_of_character): Don't defsubr it.
1730 <char-direction-table>: Deleted.
1731
e6c3da20
EZ
17322011-04-23 Eli Zaretskii <eliz@gnu.org>
1733
1734 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
1735 * doprnt.c: Include limits.h.
1736 (SIZE_MAX): New macro.
04f2d78b
CB
1737 (doprnt): Return a size_t value. 2nd arg is now size_t.
1738 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
1739 Improve overflow protection. Support `l' modifier for integer
1740 conversions. Support %l conversion. Don't assume an EMACS_INT
1741 argument for integer conversions and for %c.
1742
1743 * lisp.h (doprnt): Restore prototype.
1744
1745 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
1746 $(SRC)/character.h.
1747
1748 * Makefile.in (base_obj): Add back doprnt.o.
1749
1750 * deps.mk (doprnt.o): Add back prerequisites.
1751 (callint.o): Depend on character.h.
1752
1753 * eval.c (internal_lisp_condition_case): Include the handler
1754 representation in the error message.
1755 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1756 when breaking from the loop.
1757
1758 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1759
1760 * callint.c (Fcall_interactively): When displaying error message
1761 about invalid control letter, pass the character's codepoint, not
1762 a pointer to its multibyte form. Improve display of the character
1763 in octal and display also its hex code.
1764
1765 * character.c (char_string): Use %x to display the (unsigned)
1766 codepoint of an invalid character, to avoid displaying a bogus
1767 negative value.
1768
1769 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1770 `error', not SYMBOL_NAME itself.
1771
1772 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1773 character arguments to `error'.
1774
1775 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1776 to `error' in error message about FINAL_CHAR argument. Make sure
1777 FINAL_CHAR is a character, and use %c when it is passed as
1778 argument to `error'.
1779
4ffd0d6b 17802011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
1781
1782 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1783
1784 * w32.c: Include <time.h>.
1785 (sys_localtime): New function.
1786
4ffd0d6b 17872011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
1788
1789 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1790
4ffd0d6b 1791 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 1792
4ffd0d6b 17932011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 1794
4ffd0d6b
GM
1795 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1796 zombies (Bug#8467).
aac0c6e3 1797
04c56954
EZ
17982011-04-19 Eli Zaretskii <eliz@gnu.org>
1799
1800 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1801 gl_state.e_property when gl_state.object is Qt.
1802
1803 * insdel.c (make_gap_larger): Remove limitation of buffer size
1804 to <= INT_MAX.
1805
16a43933
CY
18062011-04-18 Chong Yidong <cyd@stupidchicken.com>
1807
1808 * xdisp.c (lookup_glyphless_char_display)
1809 (produce_glyphless_glyph): Handle cons cell entry in
1810 glyphless-char-display.
1811 (Vglyphless_char_display): Document it.
1812
1813 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1814 glyphless-char-display.
1815
4581706e
CY
18162011-04-17 Chong Yidong <cyd@stupidchicken.com>
1817
1818 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1819
1820 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1821
1822 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1823 definition for no-X builds.
1824
4887c6e2 18252011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 1826
fd35b6f9
PE
1827 Static checks with GCC 4.6.0 and non-default toolkits.
1828
5c1ccb01
PE
1829 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1830
006c5daa
PE
1831 * process.c (keyboard_bit_set): Define only if SIGIO.
1832 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1833 (send_process): Repair possible setjmp clobbering.
1834
efc736d3
PE
1835 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1836
4e2fe2e6
PE
1837 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1838
f97334a2
PE
1839 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1840
4e75f29d
PE
1841 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1842 Define only if needed.
1843
90efadd1
PE
1844 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1845 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 1846 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 1847
3c647824
PE
1848 * dispextern.h (struct redisplay_interface): Rename param
1849 to avoid shadowing.
e264f262 1850 * termhooks.h (struct terminal): Likewise.
761383f4 1851 * xterm.c (xembed_send_message): Likewise.
3c647824 1852
b58c5c4a
PE
1853 * insdel.c (make_gap_smaller): Define only if
1854 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
1855
cad59032
PE
1856 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
1857 it.
1858
c339dc2e
PE
1859 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1860 so that we aren't warned about unused symbols.
1861
91a3e27b
PE
1862 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1863
399c71d3 1864 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 1865
8ffc96f5
PE
1866 * xfns.c (x_real_positions): Mark locals as initialized.
1867
eef9bc79
PE
1868 * xmenu.c (xmenu_show): Don't use uninitialized vars.
1869
098db9dd
PE
1870 * xterm.c: Fix problems found by static analysis with other toolkits.
1871 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
1872 (x_dispatch_event): Declare static if USE_GTK, and
1873 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 1874 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 1875 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
1876 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1877 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 1878
eb18f6cc
PE
1879 * xmenu.c (menu_help_callback): Pointer type fixes.
1880 Use const pointers when pointing at readonly data. Avoid pointer
1881 signedness clashes.
1882 (FALSE): Remove unused macro.
1883 (update_frame_menubar): Remove unused decl.
1884
1fe72bf8
PE
1885 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1886
60d9e1db
PE
1887 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1888 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1889 (single_menu_item): Rename local to avoid shadowing.
1890
39261c26
PE
1891 * keyboard.c (make_lispy_event): Remove unused local var.
1892
018c5e19
PE
1893 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1894 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1895
63d2b86e
PE
1896 * bitmaps: Change bitmaps from unsigned char back to the X11
1897 compatible char. Avoid the old compiler warnings about
1898 out-of-range initializers by using, for example, '\xab' rather
1899 than 0xab.
1900
aefd87e1
PE
1901 * xgselect.c (xgselect_initialize): Check vs interface
1902 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1903
bf501fb9
PE
1904 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1905
e9829fdf
PE
1906 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1907 to read-only memory.
1908
1086c095
PE
1909 * fns.c (vector): Remove; this old hack is no longer needed.
1910
2baccd04 1911 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 1912 Remove unused var.
dde42981 1913 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 1914
72391843 1915 * xrdb.c (x_load_resources): Omit unused local.
3565b346 1916
436c16df 1917 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 1918 (x_window): Rename locals to avoid shadowing.
dc5ddd85 1919 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 1920
92bb796d 1921 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 1922 (x_term_init): Remove local to avoid shadowing.
92bb796d 1923
764430a3 1924 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
1925
1926 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1927 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1928
d1dfb56c
EZ
19292011-04-16 Eli Zaretskii <eliz@gnu.org>
1930
c4354cb4
EZ
1931 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1932
d1dfb56c
EZ
1933 Fix regex.c, syntax.c and friends for buffers > 2GB.
1934 * syntax.h (struct gl_state_s): Declare character position members
1935 EMACS_INT.
1936
1937 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1938
04f2d78b
CB
1939 * textprop.c (verify_interval_modification, interval_of):
1940 Declare arguments EMACS_INT.
d1dfb56c
EZ
1941
1942 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1943 EMACS_INT.
1944
1945 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1946
1947 * indent.c (Fvertical_motion): Local variable it_start is now
1948 EMACS_INT.
1949
1950 * regex.c (re_match, re_match_2, re_match_2_internal)
1951 (bcmp_translate, regcomp, regexec, print_double_string)
1952 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1953 (re_compile_pattern, re_exec): Declare arguments and local
1954 variables `size_t' and `ssize_t' and return values `regoff_t', as
1955 appropriate.
1956 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1957 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1958 <compile_stack_type>: `size' and `avail' are now `size_t'.
1959
1960 * regex.h <regoff_t>: Use ssize_t, not int.
1961 (re_search, re_search_2, re_match, re_match_2): Arguments that
1962 specify buffer/string position and length are now ssize_t and
1963 size_t. Return type is regoff_t.
1964
613052cd
BK
19652011-04-16 Ben Key <bkey76@gmail.com>
1966
1967 * nsfont.m: Fixed bugs in ns_get_family and
1968 ns_descriptor_to_entity that were caused by using free to
1969 deallocate memory blocks that were allocated by xmalloc (via
1970 xstrdup). This caused Emacs to crash when compiled with
1971 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1972 --enable-checking=xmallocoverrun). xfree is now used to
1973 deallocate these memory blocks.
1974
4170f62f 19752011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 1976
71b41406
PE
1977 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1978
9587a89d
PE
1979 emacs_write: Accept and return EMACS_INT for sizes.
1980 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1981 et seq.
1982 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1983 Accept and return EMACS_INT.
1984 (emacs_gnutls_write): Return the number of bytes written on
1985 partial writes.
1986 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
1987 (emacs_read, emacs_write): Remove check for negative size, as the
1988 Emacs source code has been audited now.
9587a89d
PE
1989 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1990 (emacs_read, emacs_write): Use it.
273a5f82
PE
1991 * process.c (send_process): Adjust to the new signatures of
1992 emacs_write and emacs_gnutls_write. Do not attempt to store
1993 a byte offset into an 'int'; it might overflow.
9587a89d 1994 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 1995
3e047f51
PE
1996 * sound.c: Don't assume sizes fit in 'int'.
1997 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 1998 Return EMACS_INT, not int.
3e047f51 1999 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
2000 Accept EMACS_INT, not int.
2001 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
2002 record read return values.
2003
cc39a9db
BK
20042011-04-15 Ben Key <bkey76@gmail.com>
2005
c9d0ec6d
JB
2006 * keyboard.c (Qundefined): Don't declare static since it is used
2007 in nsfns.m.
2008 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2009 static since they are used in nsfont.m.
cc39a9db 2010
6c60eb9f
SM
20112011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2012
2013 * process.c (Qprocessp): Don't declare static.
2014 * lisp.h (Qprocessp): Declare again.
2015
7990b61a
JB
20162011-04-15 Juanma Barranquero <lekktu@gmail.com>
2017
2018 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2019
5d4cb038
PE
20202011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2021
8bd7b830 2022 Improve C-level modularity by making more things 'static'.
cd64ea1d 2023
e3b27b31
PE
2024 Don't publish debugger-only interfaces to other modules.
2025 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2026 (verify_bytepos, count_markers): Move decls to the only modules
2027 that need them.
2028 * region-cache.h (pp_cache): Likewise.
2029 * window.h (check_all_windows): Likewise.
2030 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2031
5d4cb038
PE
2032 * sysdep.c (croak): Now static, if
2033 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2034 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
2035
2036 * alloc.c (refill_memory_reserve): Now static if
2037 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2038 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 2039
e87b6180
PE
2040 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2041 Define only if USE_LUCID.
2042
ac64929e
PE
2043 * xrdb.c (x_customization_string, x_rm_string): Now static.
2044
6f37259d
PE
2045 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2046 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2047
1683e3ab
PE
2048 * xdisp.c (draw_row_with_mouse_face): Now static.
2049 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2050
de9c2632
PE
2051 * window.h (check_all_windows): Mark externally visible.
2052
2b96acb7
PE
2053 * window.c (window_deletion_count): Now static.
2054
2055 * undo.c: Make symbols static if they're not exported.
2056 (last_undo_buffer, last_boundary_position, pending_boundary):
2057 Now static.
2058
50436f33
PE
2059 * textprop.c (interval_insert_behind_hooks): Now static.
2060 (interval_insert_in_front_hooks): Likewise.
2061
64520e5c
PE
2062 * term.c: Make symbols static if they're not exported.
2063 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2064 (max_frame_lines, tty_set_terminal_modes):
2065 (tty_reset_terminal_modes, tty_turn_off_highlight):
2066 (get_tty_terminal): Now static.
2067 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2068 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 2069 HAVE_WINDOW_SYSTEM.
64520e5c
PE
2070 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2071 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2072
1fa53021
PE
2073 * sysdep.c: Make symbols static if they're not exported.
2074 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2075 Now static.
2076 (sigprocmask_set, full_mask): Remove; unused.
2077 (wait_debugging): Mark as visible.
2078 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2079 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2080
d4b43b22
PE
2081 * syntax.c (syntax_temp): Define only if !__GNUC__.
2082
b7c513d0
PE
2083 * sound.c (current_sound_device, current_sound): Now static.
2084
989b29ad
PE
2085 * search.c (searchbufs, searchbuf_head): Now static.
2086
13a55a78
PE
2087 * scroll.c (scroll_cost): Remove; unused.
2088 * dispextern.h (scroll_cost): Remove decl.
2089
de68a1fc
PE
2090 * region-cache.h (pp_cache): Mark as externally visible.
2091
40ccffa6
PE
2092 * process.c: Make symbols static if they're not exported.
2093 (process_tick, update_tick, create_process, chan_process):
2094 (Vprocess_alist, proc_buffered_char, datagram_access):
2095 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2096 (deactivate_process): Mark defn as static, as well as decl.
2097 * lisp.h (create_process): Remove decl.
2098 * process.h (chan_process, Vprocess_alist): Remove decls.
2099
ad64fc97
PE
2100 * print.c: Make symbols static if they're not exported.
2101 (print_depth, new_backquote_output, being_printed, print_buffer):
2102 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2103 (print_interval, print_number_index, initial_stderr_stream):
2104 Now static.
2105 * lisp.h (Fprinc): Remove decl.
2106 (debug_output_compilation_hack): Mark as externally visible.
2107
adddb265
PE
2108 * sysdep.c (croak): Move decl from here to syssignal.h.
2109 * syssignal.h (croak): Put it here, so the API can be checked when
2110 'croak' is called from dissociate_if_controlling_tty.
2111
1717ede2
PE
2112 * minibuf.c: Make symbols static if they're not exported.
2113 (minibuf_save_list, choose_minibuf_frame): Now static.
2114 * lisp.h (choose_minibuf_frame): Remove decl.
2115
fa5fb2bc
PE
2116 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2117
1e3890d1
PE
2118 * lread.c: Make symbols static if they're not exported.
2119 (read_objects, initial_obarray, oblookup_last_bucket_number):
2120 Now static.
2121 (make_symbol): Remove; unused.
2122 * lisp.h (initial_obarray, make_symbol): Remove decls.
2123
8a1414fa
PE
2124 * keyboard.c: Make symbols static if they're not exported.
2125 (single_kboard, recent_keys_index, total_keys, recent_keys):
2126 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2127 (this_single_command_key_start, echoing, last_auto_save):
2128 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2129 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2130 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2131 (Vlispy_mouse_stem, double_click_count):
2132 Now static.
2133 (force_auto_save_soon): Define only if SIGDANGER.
2134 (ignore_mouse_drag_p): Now static if
2135 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2136 (print_help): Remove; unused.
2137 (stop_character, last_timer_event): Mark as externally visible.
2138 * keyboard.h (ignore_mouse_drag_p): Declare only if
2139 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2140 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2141 * lisp.h (echoing): Remove decl.
2142 (force_auto_save_soon): Declare only if SIGDANGER.
2143 * xdisp.c (redisplay_window): Simplify code, to make it more
2144 obvious that ignore_mouse_drag_p is not accessed if !defined
2145 USE_GTK && !defined HAVE_NS.
2146
93ea6e8f
PE
2147 * intervals.c: Make symbols static if they're not exported.
2148 (merge_properties_sticky, merge_interval_right, delete_interval):
2149 Now static.
2150 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2151
77382fcc
PE
2152 * insdel.c: Make symbols static if they're not exported.
2153 However, leave prepare_to_modify_buffer alone. It's never
2154 called from outside this function, but that appears to be a bug.
2155 (combine_after_change_list, combine_after_change_buffer):
4889fc82 2156 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
2157 (adjust_after_replace_noundo): Remove; unused.
2158 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 2159 (signal_before_change): Remove decls.
77382fcc 2160
9306c32e
PE
2161 * indent.c (val_compute_motion, val_vmotion): Now static.
2162
cd44d2eb
PE
2163 * image.c: Make symbols static if they're not exported.
2164 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2165 if USE_GTK.
2166 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2167 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2168
ad9a7a06
PE
2169 * fringe.c (standard_bitmaps): Now static.
2170 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2171
81626931
PE
2172 * frame.c: Make symbols static if they're not exported.
2173 (x_report_frame_params, make_terminal_frame): Now static.
2174 (get_frame_param): Now static, unless HAVE_NS.
2175 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2176 (x_get_resource_string): Remove; not used.
2177 * frame.h (make_terminal_frame, x_report_frame_params):
2178 (x_get_resource_string); Remove decls.
2179 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2180 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2181
239f9db9
PE
2182 * font.c, fontset.c: Make symbols static if they're not exported.
2183 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2184 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2185 * font.c (font_close_object): Now static.
2186 * font.h (font_close_object): Remove.
2187 * fontset.c (FONTSET_OBJLIST): Remove.
2188 (free_realized_fontset) #if-0 the body, which does nothing.
2189 (face_suitable_for_char_p): #if-0, as it's never called.
2190 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
2191 * xfaces.c (face_at_string_position):
2192 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
2193 since 0 is always ASCII.
2194
dfcf3579
PE
2195 * fns.c (weak_hash_tables): Now static.
2196
5045092b
PE
2197 * fileio.c: Make symbols static if they're not exported.
2198 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2199 (Vwrite_region_annotation_buffers): Now static.
2200
57a96f5c
PE
2201 * eval.c: Make symbols static if they're not exported.
2202 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2203 * lisp.h (backtrace_list): Remove decl.
2204
35f08c38
PE
2205 * emacs.c: Make symbols static if they're not exported.
2206 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2207 (fatal_error_code, fatal_error_signal_hook, standard_args):
2208 Now static.
2209 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2210 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2211 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2212 * lisp.h (fatal_error_signal_hook): Remove decl.
2213 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2214
f44bd759
PE
2215 * editfns.c: Move a (normally-unused) function to its only use.
2216 * editfns.c, lisp.h (get_operating_system_release): Remove.
2217 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2218 worth the hassle of breaking this out.
2219
b532497d
PE
2220 * xterm.c: Make symbols static if they're not exported.
2221 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2222 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2223 (x_destroy_window, x_delete_display):
2224 Now static.
2225 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2226 (x_mouse_leave): Remove; unused.
2227 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2228 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2229 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2230 Remove decls.
2231 (x_mouse_leave): Declare only if WINDOWSNT.
2232 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2233 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2234 USE_X_TOOLKIT.
2235
1675728f
PE
2236 * ftxfont.c: Make symbols static if they're not exported.
2237 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2238 HAVE_FREETYPE.
2239 * font.h (ftxfont_driver): Likewise.
2240
e4cebfca
PE
2241 * xfns.c: Make symbols static if they're not exported.
2242 (x_last_font_name, x_display_info_for_name):
2243 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2244 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2245 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2246 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2247 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2248 (last_show_tip_args): Now static.
2249 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2250 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2251 (x_screen_planes): Remove; unused.
2252 * dispextern.h (x_screen_planes): Remove decl.
2253
5bf46f05
PE
2254 * dispnew.c: Make symbols static if they're not exported.
2255 * dispextern.h (redraw_garbaged_frames, scrolling):
2256 (increment_row_positions): Remove.
2257 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2258 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2259 Now static.
2260 (redraw_garbaged_frames): Remove; unused.
2261
435f4c28
PE
2262 * xfaces.c: Make symbols static if they're not exported.
2263 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2264 Remove decls.
2265 * xterm.h (defined_color): Remove decls.
2266 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2267 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2268 (menu_face_changed_default, defined_color, free_realized_face):
2269 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2270 (ascii_face_of_lisp_face): Remove; unused.
2271
8524aef3
PE
2272 * xdisp.c: Make symbols static if they're not exported.
2273 * dispextern.h (scratch_glyph_row, window_box_edges):
2274 (glyph_to_pixel_coords, set_cursor_from_row):
2275 (get_next_display_element, set_iterator_to_next):
2276 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2277 (show_mouse_face): Remove decls
2278 * frame.h (message_buf_print): Likewise.
2279 * lisp.h (pop_message, set_message, check_point_in_composition):
2280 Likewise.
2281 * xterm.h (set_vertical_scroll_bar): Likewise.
2282 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2283 (message_buf_print, scratch_glyph_row, displayed_buffer):
2284 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2285 (get_next_display_element, show_mouse_face, window_box_edges):
2286 (frame_to_window_pixel_xy, check_point_in_composition):
2287 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2288 (glyph_to_pixel_coords): Remove; unused.
2289
16390cd2
PE
2290 * dired.c (file_name_completion): Now static.
2291
2292 * dbusbind.c (xd_in_read_queued_messages): Now static.
2293
a25f4dfa
PE
2294 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2295 * data.c (circular_list_error): Remove.
2296
14a9c8df
PE
2297 * commands.h (last_point_position, last_point_position_buffer):
2298 (last_point_position_window): Remove decls.
2299 * keyboard.c: Make these variables static.
2300
04f2d78b
CB
2301 * coding.h (coding, code_convert_region, encode_coding_gap):
2302 Remove decls.
74ab6df5
PE
2303 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2304 (iso_code_class, detect_coding, code_convert_region): Now static.
2305 (encode_coding_gap): Remove; unused.
2306
38dfbee1
PE
2307 * chartab.c (chartab_chars, chartab_bits): Now static.
2308
a2cb4e63
PE
2309 * charset.h (charset_iso_8859_1): Remove decl.
2310 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2311 Now static.
2312
127198fd
PE
2313 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2314 * ccl.c (Vccl_program_table): Now static.
2315 (check_ccl_update): Remove; unused.
2316
d85b608f
PE
2317 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2318 * category.h: ... from here.
2319 * category.c (check_category_table, set_category_set): Now static.
2320
31cd66f3
PE
2321 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2322 * lisp.h: Remove these decls.
2323
c358e587
PE
2324 * buffer.c (buffer_count): Remove unused var.
2325
e78aecca
PE
2326 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2327 so that it's not optimized away.
2328 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2329 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2330 exported only to the debugger.
2331
e192d7d3 2332 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 2333 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 2334
92470028
PE
2335 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2336 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2337 was inaccessible from Lisp.
2338 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2339 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2340
244ed907
PE
2341 alloc.c: Import and export fewer symbols, and remove unused items.
2342 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2343 is defined.
2344 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2345 it's not optimized away by whole-program optimization.
2346 (message_enable_multibyte, free_misc): Remove.
2347 (catchlist, handlerlist, mark_backtrace):
2348 Declare only if BYTE_MARK_STACK.
2349 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2350 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2351 (message_enable_multibyte): Remove decl.
2352 (free_misc, interval_free_list, float_block, float_block_index):
2353 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2354 (cons_free_list, last_marked_index):
2355 Now static.
2356 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2357 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2358 (mark_backtrace): Define only if BYTE_MARK_STACK.
2359 * xdisp.c (message_enable_multibyte): Now static.
2360
61c2b50e 2361 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
2362 This makes it easier for human readers (and static analyzers)
2363 to see whether these variables are used from other modules.
2364 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2365 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2366 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2367 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2368 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2369 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2370 * xmenu.c, xselect.c:
2371 Declare Q* vars static if they are not used in other modules.
2372 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2373 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2374 Remove decls of unexported vars.
2375 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2376
95c82688
PE
2377 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2378
16a97296
PE
2379 Make Emacs functions such as Fatom 'static' by default.
2380 This makes it easier for human readers (and static analyzers)
2381 to see whether these functions can be called from other modules.
2382 DEFUN now defines a static function. To make the function external
2383 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
2384 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2385 (Finit_image_library):
16a97296
PE
2386 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2387 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2388 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2389 Remove decls, since these functions are now static.
2390 (Funintern, Fget_internal_run_time): New decls, since these functions
2391 were already external.
95c82688 2392
16a97296
PE
2393 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2394 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2395 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2396 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2397 * keyboard.c, keymap.c, lread.c:
2398 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2399 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2400 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2401 Mark functions with DEFUE instead of DEFUN,
2402 if they are used in other modules.
2403 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2404 decls for now-static functions.
2405 * buffer.h (Fdelete_overlay): Remove decl.
2406 * callproc.c (Fgetenv_internal): Mark as internal.
2407 * composite.c (Fremove_list_of_text_properties): Remove decl.
2408 (Fcomposition_get_gstring): New forward static decl.
2409 * composite.h (Fcomposite_get_gstring): Remove decl.
2410 * dired.c (Ffile_attributes): New forward static decl.
2411 * doc.c (Fdocumntation_property): New forward static decl.
2412 * eval.c (Ffetch_bytecode): New forward static decl.
2413 (Funintern): Remove extern decl; now in .h file where it belongs.
2414 * fileio.c (Fmake_symbolic_link): New forward static decl.
2415 * image.c (Finit_image_library): New forward static decl.
2416 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2417 * intervals.h (Fprevious_property_change):
2418 (Fremove_list_of_text_properties): Remove decls.
2419 * keyboard.c (Fthis_command_keys): Remove decl.
2420 (Fcommand_execute): New forward static decl.
2421 * keymap.c (Flookup_key): New forward static decl.
2422 (Fcopy_keymap): Now static.
2423 * keymap.h (Flookup_key): Remove decl.
2424 * process.c (Fget_process): New forward static decl.
2425 (Fprocess_datagram_address): Mark as internal.
2426 * syntax.c (Fsyntax_table_p): New forward static decl.
2427 (skip_chars): Remove duplicate decl.
2428 * textprop.c (Fprevious_property_change): New forward static decl.
2429 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2430 Now internal.
2431 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2432 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2433
785bbd42
PE
2434 * editfns.c (Fformat): Remove unreachable code.
2435
8b913b57
AS
24362011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2437
2438 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2439 change. (Bug#8496)
2440
a6744a35
EZ
24412011-04-13 Eli Zaretskii <eliz@gnu.org>
2442
2443 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2444 when at ZV. (Bug#8487)
2445
e7974947
AS
24462011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2447
baad03f0
AS
2448 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2449 (Bug#8437)
2450 * keyboard.c (parse_tool_bar_item): Likewise.
2451 * sound.c (sound_cleanup, alsa_close): Likewise.
2452 * termcap.c (tgetent): Likewise.
2453 * xfns.c (x_default_font_parameter): Likewise.
2454 * xsettings.c (read_and_apply_settings): Likewise.
2455
e7974947
AS
2456 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2457 (overrun_check_free): Protoize.
2458
28272684
PE
24592011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2460
2461 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2462 since callers should never pass a negative size.
2463 Change the signature to match that of plain 'read' and 'write'; see
2464 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2465 * lisp.h: Update prototypes of emacs_write and emacs_read.
2466
11997c76
EZ
24672011-04-11 Eli Zaretskii <eliz@gnu.org>
2468
2469 * xdisp.c (redisplay_window): Don't try to determine the character
2470 position of the scroll margin if the window start point w->startp
e896f03c 2471 is outside the buffer's accessible region. (Bug#8468)
11997c76 2472
8a2cbd72
EZ
24732011-04-10 Eli Zaretskii <eliz@gnu.org>
2474
2475 Fix write-region and its subroutines for buffers > 2GB.
2476 * fileio.c (a_write, e_write): Modify declaration of arguments and
2477 local variables to support buffers larger than 2GB.
2478 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2479
2480 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2481 argument, local variables, and return value.
2482
2483 * lisp.h: Update prototypes of emacs_write and emacs_read.
2484
2485 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2486
4073e537 24872011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 2488
1ebfdcb6
PE
2489 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2490
b2ded58d
PE
2491 Fix more problems found by GCC 4.6.0's static checks.
2492
7d66342c
PE
2493 * xdisp.c (vmessage): Use a better test for character truncation.
2494
bbf47d44
PE
2495 * charset.c (load_charset_map): <, not <=, for optimization,
2496 and to avoid potential problems with integer overflow.
9248994d 2497 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 2498 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 2499 * editfns.c (Fformat): Likewise.
1e69125e 2500 * syntax.c (skip_chars): Likewise.
3befa583 2501
e3019616
PE
2502 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2503 This also lets GCC 4.6.0 generate slightly better loop code.
2504
becfa255
PE
2505 * callint.c (Fcall_interactively): <, not <=, for optimization.
2506 (Fcall_interactively): Count the number of arguments produced,
2507 not the number of arguments given. This is simpler and lets GCC
2508 4.6.0 generate slightly better code.
2509
dae0cd48
PE
2510 * ftfont.c: Distingish more carefully between FcChar8 and char.
2511 The previous code passed unsigned char * to a functions like
2512 strlen and xstrcasecmp that expect char *, which does not
2513 conform to the C standard.
2514 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2515 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2516 char * when the C standard requires it.
2517
76032d70
PE
2518 * keyboard.c (read_char): Remove unused var.
2519
eb3f1cc8
PE
2520 * eval.c: Port to Windows vsnprintf (Bug#8435).
2521 Include <limits.h>.
2522 (SIZE_MAX): Define if the headers do not.
2523 (verror): Do not give up if vsnprintf returns a negative count.
2524 Instead, grow the buffer. This ports to Windows vsnprintf, which
2525 does not conform to C99. Problem reported by Eli Zaretskii.
2526 Also, simplify the allocation scheme, by avoiding the need for
2527 calling realloc, and removing the ALLOCATED variable.
2528
70476b54
PE
2529 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2530
12020a9e
PE
2531 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2532 But keep the doprint source code for now, as we might revamp it
2533 and use it again (Bug#8435).
ea6c7ae6
PE
2534 * lisp.h (doprnt): Remove.
2535 * Makefile.in (base_obj): Remove doprnt.o.
2536 * deps.mk (doprnt.o): Remove.
2537
5fdb398c
PE
2538 error: Print 32- and 64-bit integers portably (Bug#8435).
2539 Without this change, on typical 64-bit hosts error ("...%d...", N)
2540 was used to print both 32- and 64-bit integers N, which relied on
2541 undefined behavior.
2542 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
2543 New macro.
2544 * lisp.h (error, verror): Mark as printf-like functions.
2545 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
2546 Report overflow in size calculations when allocating printf buffer.
2547 Do not truncate output string at its first null byte.
2548 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
2549 Truncate the output at a character boundary, since vsnprintf does not
2550 do that.
2551 * charset.c (check_iso_charset_parameter): Convert internal
2552 character to string before calling 'error', since %c now has the
2553 printf meaning.
2554 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
2555 overflow when computing char to be passed to 'error'. Do not
2556 pass Lisp_Object to 'error'; pass the integer instead.
2557 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
2558 formatted with plain %d.
2559
b189fa66
PE
2560 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
2561
bff87ef0
PE
2562 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
2563
7e2cac20
PE
2564 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
2565
ce4d90b5
PE
2566 * xterm.c (x_catch_errors): Remove duplicate declaration.
2567
266c9547
PE
2568 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
2569
79c49ad2
PE
2570 * xdisp.c, lisp.h (message_nolog): Remove; unused.
2571
368f4090
JM
25722011-04-10 Jim Meyering <meyering@redhat.com>
2573
2574 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
2575 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
2576 return ssize_t not "int", and use size_t as the buffer length.
2577 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
2578 * gnutls.h: Update declarations.
2579 * process.c (read_process_output): Use ssize_t, to match.
2580 (send_process): Likewise.
2581
a32d4040
CY
25822011-04-09 Chong Yidong <cyd@stupidchicken.com>
2583
2584 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
2585
8546720e 25862011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 2587
04f2d78b
CB
2588 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
2589 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 2590
8546720e
GM
2591 * xterm.c (handle_one_xevent):
2592 * xmenu.c (create_and_show_popup_menu):
2593 * xselect.c (x_decline_selection_request)
2594 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 2595
0a2f5c1a 25962011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
2597
2598 Fix some uses of `int' instead of EMACS_INT.
2599 * search.c (string_match_1, fast_string_match)
2600 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2601 (scan_buffer, find_next_newline_no_quit)
2602 (find_before_next_newline, search_command, Freplace_match)
2603 (Fmatch_data): Make some `int' variables be EMACS_INT.
2604
2605 * xdisp.c (display_count_lines): 3rd argument and return value now
2606 EMACS_INT. All callers changed.
2607 (pint2hrstr): Last argument is now EMACS_INT.
2608
2609 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2610 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2611 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2612 (decode_coding_utf_16, decode_coding_emacs_mule)
2613 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2614 (decode_coding_ccl, decode_coding_charset)
2615 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2616 (decode_coding_iso_2022, decode_coding_emacs_mule)
2617 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2618 <char_offset, last_offset>: Declare EMACS_INT.
2619 (encode_coding_utf_8, encode_coding_utf_16)
2620 (encode_coding_emacs_mule, encode_invocation_designation)
2621 (encode_designation_at_bol, encode_coding_iso_2022)
2622 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2623 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2624 Declare EMACS_INT.
2625 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2626 (encode_invocation_designation): Last argument P_NCHARS is now
2627 EMACS_INT.
2628 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2629 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2630
2631 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2632 All users changed.
2633
2634 * ccl.c (Fccl_execute_on_string): Declare some variables
2635 EMACS_INT.
2636
8546720e 26372011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
2638
2639 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2640
4e19a977
CS
26412011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2642
2643 * process.c (Fformat_network_address): Doc fix.
2644
87302331
R
26452011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2646
2647 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
2648
cbb59342
CY
26492011-04-08 Chong Yidong <cyd@stupidchicken.com>
2650
2651 * keyboard.c (read_char): Call Lisp function help-form-show,
2652 instead of using internal_with_output_to_temp_buffer.
2653 (Qhelp_form_show): New var.
e0d38eeb 2654 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
2655
2656 * print.c (internal_with_output_to_temp_buffer): Function deleted.
2657
2658 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
2659
e67a13ab
CY
26602011-04-06 Chong Yidong <cyd@stupidchicken.com>
2661
04f2d78b
CB
2662 * process.c (Flist_processes): Remove to Lisp.
2663 (list_processes_1): Delete.
e67a13ab 2664
973f782d
EZ
26652011-04-06 Eli Zaretskii <eliz@gnu.org>
2666
7c106b1e
EZ
2667 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
2668
973f782d
EZ
2669 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
2670
41cf7d1a 26712011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 2672
ca23cc88
PE
2673 Fix more problems found by GCC 4.6.0's static checks.
2674
f390e2d5
PE
2675 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
2676
42eea0d0
PE
2677 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
2678
b69769da 2679 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 2680
f9541e84
PE
2681 * xdisp.c (vmessage): Mark as a printf-like function.
2682
13841b55
PE
2683 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
2684
c136c10f
PE
2685 * sound.c (sound_warning): Don't crash if arg contains a printf format.
2686
5e2d4a30
PE
2687 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
2688 printf-like functions.
2689 (tiff_load): Add casts to remove these marks before passing them
2690 to system-supplied API.
2691
583f48b9
PE
2692 * eval.c (Fsignal): Remove excess argument to 'fatal'.
2693
b25d760e
PE
2694 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
2695 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
2696 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
2697 directly, rather than having caller test rule sign. This avoids
2698 some unnecessary tests.
2699 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
2700 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
2701 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 2702
bc7b6697 2703 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 2704 (xfont_open): Avoid unnecessary tests.
bc7b6697 2705
27ccc379
PE
2706 * composite.c (composition_gstring_put_cache): Use unsigned integer.
2707
dcd5c89a
PE
2708 * composite.h, composite.c (composition_gstring_put_cache):
2709 Use EMACS_INT, not int, for length.
2710
b13a45c6
PE
2711 * composite.h (COMPOSITION_DECODE_REFS): New macro,
2712 breaking out part of COMPOSITION_DECODE_RULE.
2713 (COMPOSITION_DECODE_RULE): Use it.
2714 * composite.c (get_composition_id): Remove unused local vars,
2715 by using the new macro.
2716
1e792e4d
PE
2717 * textprop.c (set_text_properties_1): Change while to do-while,
2718 since the condition is always true at first.
2719
dc6c6455 2720 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
2721 (interval_deletion_adjustment): Return unsigned value.
2722 All uses changed.
dc6c6455 2723
aba7731a
PE
2724 * process.c (list_processes_1, create_pty, read_process_output):
2725 (exec_sentinel): Remove vars that were set but not used.
afd4052b 2726 (create_pty): Remove unnecessary "volatile"s.
bc57d757 2727 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 2728 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 2729 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 2730
fdfc4bf3
PE
2731 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
2732
fca8fe46 2733 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 2734 (update_syntax_table): Use unsigned instead of int.
fca8fe46 2735
06a0259a 2736 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 2737 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 2738 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 2739
e7b9e80f
PE
2740 * print.c (print_error_message): Avoid int overflow.
2741
56201685
PE
2742 * font.c (font_list_entities): Redo for clarity,
2743 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
2744
78834453 2745 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 2746 (font_score): Avoid potential overflow in diff calculation.
78834453 2747
0bc0b309 2748 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 2749 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 2750
e610eaca
PE
2751 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2752
b895abce
PE
2753 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2754 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2755 can always succeed if overflow has undefined behavior.
2756
1f1d9321 2757 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 2758 (wordify): Omit three unnecessary tests.
1f1d9321 2759
c59478bc
PE
2760 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2761 All callers changed. This avoids the need for an unused var.
2762
79b73827
PE
2763 * casefiddle.c (casify_region): Remove var that is set but not used.
2764
a4db5dfe
PE
2765 * dired.c (file_name_completion): Remove var that is set but not used.
2766
43aae36e
PE
2767 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2768
2a47c44d 2769 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 2770 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 2771
a37c69bf
PE
2772 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2773 Check for integer overflow on size calculations.
2774
328ab8e7
PE
2775 * buffer.c (Fprevious_overlay_change): Remove var that is set
2776 but not used.
2777
e5a2a5cb
PE
2778 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2779 Remove vars that are set but not used.
8d84a6eb 2780 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 2781 (timer_check_2): Mark vars as initialized.
e5a2a5cb 2782
a60e5f68
PE
2783 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2784
f661cb61 2785 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 2786 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 2787
f0397f5a
PE
2788 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2789 that are set but not used.
2790
8664db06 2791 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 2792 if XCreateBitmapFromData fails (Bug#8410).
8664db06 2793
6abdaa4a
PE
2794 * xselect.c (x_get_local_selection, x_handle_property_notify):
2795 Remove vars that are set but not used.
2796
0ce7538d 2797 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 2798 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 2799
9ae848fc
PE
2800 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2801 Remove var that is set but not used.
0b918413
PE
2802 (scroll_bar_windows_size): Now size_t, not int.
2803 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2804 Check for overflow.
9ae848fc 2805
a5a62657
PE
2806 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2807 (map_tty_color) [!defined MSDOS]: Likewise.
2808
5c5cdd39
PE
2809 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2810
66ebf983
PE
2811 * coding.c: Remove vars that are set but not used.
2812 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2813 All callers changed.
2814 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2815 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2816 (decode_coding_charset): Remove vars that are set but not used.
2817
1be4d761
PE
2818 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2819 that is set but not used.
2820
47553fa8
PE
2821 * print.c (print_object): Remove var that is set but not used.
2822
1f7196bf 2823 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
2824 The gnulib version avoids calling malloc in the usual case,
2825 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2826 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2827 * filelock.c (current_lock_owner): Likewise.
2828 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2829 * sysdep.c: Include allocator.h, careadlinkat.h.
2830 (emacs_no_realloc_allocator): New static constant.
2831 (emacs_readlink): New function.
fdb61804
PE
2832 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2833 ../lib/careadlinkat.h.
d1fdcab7 2834
f84c17c7
SM
28352011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2836
2837 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2838 first non-nil return value).
2839
ef3862ad
JD
28402011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2841
2842 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2843 if not defined (Bug#8403).
2844
376a7006
JB
28452011-04-02 Juanma Barranquero <lekktu@gmail.com>
2846
2847 * xdisp.c (display_count_lines): Remove parameter `start',
2848 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2849 (get_char_face_and_encoding): Remove parameter `multibyte_p',
2850 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2851 (fill_stretch_glyph_string): Remove parameters `row' and `area',
2852 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
2853 and thereabouts. All callers changed.
2854 (get_per_char_metric): Remove parameter `f', unused since
2855 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2856
6ca3801d
JM
28572011-04-02 Jim Meyering <meyering@redhat.com>
2858
2859 do not dereference NULL upon failed strdup
2860 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2861 (ns_get_family): Likewise.
2862
d8e2b5ba
JB
28632011-04-02 Juanma Barranquero <lekktu@gmail.com>
2864
2865 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2866
8c74fcbd
JD
28672011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2868
2869 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
2870 later (Bug#8403).
2871
7200d79c
SM
28722011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2873
03408648 2874 Add lexical binding.
7200d79c 2875
03408648
SM
2876 * window.c (Ftemp_output_buffer_show): New fun.
2877 (Fsave_window_excursion):
2878 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2879
2880 * lread.c (lisp_file_lexically_bound_p): New function.
2881 (Fload): Bind Qlexical_binding.
2882 (readevalloop): Remove `evalfun' arg.
2883 Bind Qinternal_interpreter_environment.
2884 (Feval_buffer): Bind Qlexical_binding.
2885 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2886 Mark as dynamic.
2887 (syms_of_lread): Declare `lexical-binding'.
2888
2889 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2890
2891 * keyboard.c (eval_dyn): New fun.
2892 (menu_item_eval_property): Use it.
ca105506
SM
2893
2894 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 2895
03408648
SM
2896 * fns.c (concat, mapcar1): Accept byte-code-functions.
2897
2898 * eval.c (Fsetq): Handle lexical vars.
2899 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2900 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2901 (FletX, Flet): Obey lexical binding.
2902 (Fcommandp): Handle closures.
2903 (Feval): New `lexical' arg.
2904 (eval_sub): New function extracted from Feval. Use it almost
2905 everywhere where Feval was used. Look up vars in lexical env.
2906 Handle closures.
2907 (Ffunctionp): Move from subr.el.
2908 (Ffuncall): Handle closures.
2909 (apply_lambda): Remove `eval_flags'.
2910 (funcall_lambda): Handle closures and new byte-code-functions.
2911 (Fspecial_variable_p): New function.
2912 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
2913 but without exporting it to Lisp.
23aba0ea 2914
23aba0ea 2915 * doc.c (Fdocumentation, store_function_docstring):
03408648 2916 * data.c (Finteractive_form): Handle closures.
23aba0ea 2917
03408648
SM
2918 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
2919 interactive spec.
ba83908c 2920
04f2d78b
CB
2921 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
2922 New byte-codes.
03408648
SM
2923 (exec_byte_code): New function extracted from Fbyte_code to handle new
2924 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 2925
03408648 2926 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 2927
03408648 2928 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 2929
e2abce01
JB
29302011-03-31 Juanma Barranquero <lekktu@gmail.com>
2931
2932 * xdisp.c (redisplay_internal): Fix prototype.
2933
63696a73 29342011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 2935
63696a73 2936 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
2937 (try_scrolling): Use it when setting scroll_limit.
2938 Limit scrolling to 100 screen lines.
63696a73
EZ
2939 (redisplay_window): Even when falling back on "recentering",
2940 position point in the window according to scroll-conservatively,
2941 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2942
2943 (try_scrolling): When point is above the window, allow searching
2944 as far as scroll_max, or one screenful, to compute vertical
2945 distance from PT to the scroll margin position. This prevents
2946 try_scrolling from unnecessarily failing when
2947 scroll-conservatively is set to a value slightly larger than the
2948 window height. Clean up the case of PT below the margin at bottom
2949 of window: scroll_max can no longer be INT_MAX. When aggressive
2950 scrolling is in use, don't let point enter the opposite scroll
2951 margin as result of the scroll.
2952 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
2953 threshold of 100 lines for never-recentering scrolling.
2954
e4cc2dfc
JB
29552011-03-31 Juanma Barranquero <lekktu@gmail.com>
2956
2957 * dispextern.h (move_it_by_lines):
2958 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2959 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2960 (message_log_check_duplicate): Remove parameters `prev_bol' and
2961 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2962 (redisplay_internal): Remove parameter `preserve_echo_area',
2963 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2964
2965 * indent.c (Fvertical_motion):
2966 * window.c (window_scroll_pixel_based, Frecenter):
2967 Don't pass `need_y_p' to `move_it_by_lines'.
2968
1c470562
SM
29692011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2970
44f230aa
SM
2971 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2972 steal a few bits to be more compact.
2973 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2974 Remove unneeded casts.
2975
1c470562
SM
2976 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2977
888adce9
ZK
29782011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2979
2980 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2981 binding" message (bug#7967).
2982
f838ed7b
PE
29832011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2984
77861b95
PE
2985 Fix more problems found by GCC 4.6.0's static checks.
2986
de6dbc14
PE
2987 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2988 Remove unused local var.
2989
f838ed7b
PE
2990 * editfns.c (Fmessage_box): Remove unused local var.
2991
792c7b2b
PE
2992 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2993 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2994 Omit unused local vars.
c499e557 2995 * window.c (shrink_windows): Omit unused local var.
b01a1c29 2996 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
2997 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2998 Omit unused local var.
2999
ba0165e1
PE
3000 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3001 Don't assume string length fits in int.
32ad8845 3002 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 3003 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 3004
3c59b4c9
PE
3005 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3006 instead of alloca (Bug#8344).
3007
a3eed478 3008 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 3009 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 3010
eb4d412d
PE
3011 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3012
1658b401
PE
3013 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3014 concerns.
3015
3016 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3017
3018 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 3019
9a2c6e05
PE
3020 * keyboard.c (syms_of_keyboard): Use the same style as later
3021 in this function when indexing through an array. This also
3022 works around GCC bug 48267.
3023
03d0a109
PE
3024 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3025
44f730c8
PE
3026 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3027
fe75f926
PE
3028 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3029 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3030
ffa8c828
PE
3031 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3032 This avoids undefined behavior on integer overflow, and is a bit
3033 more convenient anyway since it is compared to a size_t variable.
3034
c5101a77
PE
3035 Variadic C functions now count arguments with size_t, not int.
3036 This avoids an unnecessary limitation on 64-bit machines, which
3037 caused (substring ...) to crash on large vectors (Bug#8344).
3038 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3039 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 3040 All variadic functions and their callers changed accordingly.
c5101a77
PE
3041 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3042 * data.c (arith_driver, float_arith_driver): Likewise.
3043 * editfns.c (general_insert_function): Likewise.
3044 * eval.c (struct backtrace.nargs, interactive_p)
3045 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3046 (funcall_lambda, mark_backtrace): Likewise.
3047 * fns.c (concat): Likewise.
3048 * frame.c (x_set_frame_parameters): Likewise.
3049 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3050 0 if not found, not -1. All callers changed.
3051
dd3f25f7
PE
3052 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3053 (stack_copy_size): Now size_t, not int.
3054 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3055
461c2ab9
JB
30562011-03-28 Juanma Barranquero <lekktu@gmail.com>
3057
3058 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3059 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3060 All callers changed.
3061
3062 * lisp.h (multibyte_char_to_unibyte):
3063 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3064 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3065 * character.h (CHAR_TO_BYTE8):
3066 * cmds.c (internal_self_insert):
3067 * editfns.c (general_insert_function):
3068 * keymap.c (push_key_description):
3069 * search.c (Freplace_match):
3070 * xdisp.c (message_dolog, set_message_1): All callers changed.
3071
f6d62986
SM
30722011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3073
3074 * keyboard.c (safe_run_hook_funcall): New function.
3075 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3076 don't set the hook to nil, but remove the offending function instead.
3077 (Qcommand_hook_internal): Remove, unused.
3078 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3079 Vcommand_hook_internal.
3080
3081 * eval.c (enum run_hooks_condition): Remove.
3082 (funcall_nil, funcall_not): New functions.
3083 (run_hook_with_args): Call each function through a `funcall' argument.
3084 Remove `cond' argument, now redundant.
3085 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3086 (Frun_hook_with_args_until_failure): Adjust accordingly.
3087 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3088
1db5b1ad
JB
30892011-03-28 Juanma Barranquero <lekktu@gmail.com>
3090
3091 * dispextern.h (string_buffer_position): Remove declaration.
3092
3093 * print.c (strout): Remove parameter `multibyte', unused since
3094 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3095
3096 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3097 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3098 All callers changed.
3099
3100 * w32.c (_wsa_errlist): Use braces for struct initializers.
3101
3102 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3103 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3104 All callers changed.
3105 (string_buffer_position): Likewise. Also, make static (it's never
3106 used outside xdisp.c).
3107 (cursor_row_p): Remove parameter `w', unused since
3108 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3109 (decode_mode_spec): Remove parameter `precision', introduced during
3110 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3111 All callers changed.
3112
5ffb62aa
JD
31132011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3114
3115 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3116
461c2ab9 31172011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
3118
3119 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3120 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3121 (ns_update_auto_hide_menu_bar): New functions.
3122 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3123 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3124 ns_constrain_all_frames.
3125 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3126 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3127
5c380ffb
JD
31282011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3129
3130 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3131
9af30bdf
GM
31322011-03-27 Glenn Morris <rgm@gnu.org>
3133
3134 * syssignal.h: Replace RETSIGTYPE with void.
3135 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3136 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3137 Replace SIGTYPE with void everywhere.
3138 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3139 * s/template.h (SIGTYPE): Remove commented out definition.
3140
e2abce01
JB
31412011-03-26 Eli Zaretskii <eliz@gnu.org>
3142
3143 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3144 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3145
f868cd8a
JB
31462011-03-26 Juanma Barranquero <lekktu@gmail.com>
3147
59eb0929
JB
3148 * w32.c (read_unc_volume): Use parameter `henum', instead of
3149 global variable `wget_enum_handle'.
3150
3151 * keymap.c (describe_vector): Remove parameters `indices' and
3152 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3153 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3154
f868cd8a
JB
3155 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3156
3157 * keyboard.c (timer_check): Remove parameter `do_it_now',
3158 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3159 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3160 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3161
3162 * keyboard.c (read_char):
3163 * w32menu.c (w32_menu_display_help):
3164 * xmenu.c (show_help_event, menu_help_callback):
3165 Adjust calls to `show_help_echo'.
3166
3167 * gtkutil.c (xg_maybe_add_timer):
3168 * keyboard.c (readable_events):
3169 * process.c (wait_reading_process_output):
3170 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3171
3172 * insdel.c (adjust_markers_gap_motion):
3173 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3174 (gap_left, gap_right): Don't call it.
3175
2ecf6fdb
CY
31762011-03-25 Chong Yidong <cyd@stupidchicken.com>
3177
3178 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3179 incurred during fontification.
3180
6b1f9ba4
JB
31812011-03-25 Juanma Barranquero <lekktu@gmail.com>
3182
3183 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3184 (DEFVAR_PER_BUFFER): Don't pass it.
3185
3186 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3187 (scrolling_window): Don't pass it.
3188
0f4a96b5
JB
31892011-03-25 Juanma Barranquero <lekktu@gmail.com>
3190
3191 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3192
3193 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3194 and `suffix'.
3195 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3196 of variables specific to SELinux and computation of `encoded_absname'.
3197
3198 * image.c (XPutPixel): Remove unused variable `height'.
3199
3200 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3201
3202 * unexw32.c (get_section_info): Remove unused variable `section'.
3203
3204 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3205 (system_process_attributes): Remove unused variable `sess'.
3206 (sys_read): Remove unused variable `err'.
3207
3208 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3209 (w32_wnd_proc): Remove unused variable `isdead'.
3210 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3211 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3212 (x_create_tip_frame): Remove unused variable `tem'.
3213
3214 * w32inevt.c (w32_console_read_socket):
3215 Remove unused variable `no_events'.
3216
3217 * w32term.c (x_draw_composite_glyph_string_foreground):
3218 Remove unused variable `width'.
3219
1149507c
JB
32202011-03-24 Juanma Barranquero <lekktu@gmail.com>
3221
3222 * w32term.c (x_set_glyph_string_clipping):
3223 Don't pass uninitialized region to CombineRgn.
3224
9c88f339
JB
32252011-03-23 Juanma Barranquero <lekktu@gmail.com>
3226
3227 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3228 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3229 (Fx_close_connection): Remove unused variable `i'.
3230
3231 * w32font.c (w32font_draw): Return number of glyphs.
3232 (w32font_open_internal): Remove unused variable `i'.
3233 (w32font_driver): Add missing initializer.
3234
3235 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3236 (fill_in_menu): Remove unused variable `items_added'.
3237
3238 * w32term.c (last_mouse_press_frame): Remove static global variable.
3239 (w32_clip_to_row): Remove unused variable `f'.
3240 (x_delete_terminal): Remove unused variable `i'.
3241
3242 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3243 (NOTHING): Remove unused static global variable.
3244 (uniscribe_check_otf): Remove unused variable `table'.
3245 (uniscribe_font_driver): Add missing initializers.
3246
dee091a3
JD
32472011-03-23 Julien Danjou <julien@danjou.info>
3248
3249 * term.c (Fsuspend_tty, Fresume_tty):
3250 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3251 * window.c (temp_output_buffer_show):
3252 * insdel.c (signal_before_change):
3253 * frame.c (Fhandle_switch_frame):
3254 * fileio.c (Fdo_auto_save):
3255 * emacs.c (Fkill_emacs):
3256 * editfns.c (save_excursion_restore):
3257 * cmds.c (internal_self_insert):
3258 * callint.c (Fcall_interactively):
3259 * buffer.c (Fkill_all_local_variables):
3260 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3261 Use Frun_hooks.
0f4a96b5 3262 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
3263 unconditionnaly since it does the check itself.
3264
2c520ab5 32652011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 3266
c9c49752
PE
3267 Fix more problems found by GCC 4.5.2's static checks.
3268
8abc3f12
PE
3269 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3270 the first time through the loop, since we know p0 < p1 then.
3271 This also avoids a gcc -Wstrict-overflow warning.
3272
a2d26660
PE
3273 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3274 leading to a memory leak, possible in functions like
3275 load_charset_map_from_file that can allocate an unbounded number
b12ef411 3276 of objects (Bug#8318).
a2d26660 3277
916c72e9
PE
3278 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3279 that could (at least in theory) be that large.
3280
19ab8a18
PE
3281 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3282 This is less likely to overflow, and avoids undefined behavior if
3283 overflow does occur. All callers changed. Use strtoul to scan
3284 for the unsigned long integer.
b7cbbd6f
PE
3285 (pint2hrstr): Simplify and tune code slightly.
3286 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 3287
f0641eff
PE
3288 * scroll.c (do_scrolling): Work around GCC bug 48228.
3289 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3290
7f650bb9
PE
3291 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3292 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
3293 (validate_x_resource_name): Simplify count usage.
3294 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 3295
37dd57d1
PE
3296 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3297 fail (Bug#8306).
81e56e61 3298
699979fc 3299 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 3300
401bf9b4
PE
3301 * process.c (Fmake_network_process): Use socklen_t, not int,
3302 where POSIX says socklen_t is required in portable programs.
3303 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 3304 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
3305 (Fmake_network_process, server_accept_connection):
3306 (wait_reading_process_output, read_process_output):
3307 Likewise.
3308
b93aacde
PE
3309 * process.c: Rename or move locals to avoid shadowing.
3310 (list_processes_1, Fmake_network_process):
3311 (read_process_output_error_handler, exec_sentinel_error_handler):
3312 Rename or move locals.
4dc343ee 3313 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 3314 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 3315 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 3316 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 3317 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 3318
af8a867c 3319 Make tparam.h and terminfo.c consistent.
44f230aa
SM
3320 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3321 Include tparam.h instead, since it declares them.
af8a867c
PE
3322 * cm.h (PC): Remove extern decl; tparam.h now does this.
3323 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3324 * terminfo.c: Include tparam.h, to check interfaces.
3325 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3326 (tparam): Adjust signature to match interface in tparam.h;
3327 this removes some undefined behavior. Check that outstring and len
3328 are zero, which they always are with Emacs.
3329 * tparam.h (PC, BC, UP): New extern decls.
3330
0248044d 3331 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 3332 (xftfont_open): Rename locals to avoid shadowing.
0248044d 3333
8ff096c1 3334 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
3335 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3336 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 3337 (ftfont_list): Remove unused local.
49eaafba
PE
3338 (get_adstyle_property, ftfont_pattern_entity):
3339 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3340 Rename locals to avoid shadowing.
8ff096c1 3341
e2be39f6
PE
3342 * xfont.c (xfont_list_family): Mark var as initialized.
3343
c9735e30
PE
3344 * xml.c (make_dom): Now static.
3345
8f5201ae
PE
3346 * composite.c (composition_compute_stop_pos): Rename local to
3347 avoid shadowing.
b246f932
PE
3348 (composition_reseat_it): Remove unused locals.
3349 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 3350 (composition_update_it): Mark var as initialized.
11b61122
PE
3351 (find_automatic_composition): Mark vars as initialized,
3352 with a FIXME (Bug#8290).
8f5201ae 3353
760fbc2c
PE
3354 character.h: Rename locals to avoid shadowing.
3355 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3356 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3357 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3358 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3359 to avoid shadowing.
3360
ff08eb85
PE
3361 * textprop.c (property_change_between_p): Remove; unused.
3362
fc7bf025
PE
3363 * intervals.c (interval_start_pos): Now static.
3364
235d7abc
PE
3365 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3366
44f230aa
SM
3367 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3368 Rename locals to avoid shadowing.
3e7d6594 3369
50060332
PE
3370 * sound.c (wav_play, au_play, Fplay_sound_internal):
3371 Fix pointer signedness.
d01f234b 3372 (alsa_choose_format): Remove unused local var.
c83b8872
PE
3373 (wav_play): Initialize a variable to 0, to prevent undefined
3374 behavior (Bug#8278).
50060332 3375
c4fc4e30
PE
3376 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3377
918436ed
PE
3378 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3379
c939f91b
PE
3380 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3381 clobbering (Bug#8298).
b9c7f648
PE
3382 * sysdep.c (sys_subshell): Likewise.
3383 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 3384
6bd8c144
PE
3385 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3386 This should get cleaned up, so that child_setup has the
3387 same signature on all platforms.
3388
7710357c 3389 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 3390 (relocate_fd): Rename locals to avoid shadowing.
7710357c 3391
c59da222
CY
33922011-03-22 Chong Yidong <cyd@stupidchicken.com>
3393
3394 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3395 not to be necessary, and produces flickering.
3396
66b87493
GM
33972011-03-20 Glenn Morris <rgm@gnu.org>
3398
3399 * config.in: Remove file.
3400
45b6f6d5
JB
34012011-03-20 Juanma Barranquero <lekktu@gmail.com>
3402
3403 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3404 are now in src/globals.h.
3405 (syms_of_minibuf): Remove spurious & from previous change.
3406
3ec03f7e
LL
34072011-03-20 Leo <sdl.web@gmail.com>
3408
3409 * minibuf.c (completing-read-function): New variable.
3410 (completing-read-default): Rename from completing-read.
3411 (completing-read): Call completing-read-function.
3412
b14e3e21
CY
34132011-03-19 Juanma Barranquero <lekktu@gmail.com>
3414
3415 * xfaces.c (Fx_load_color_file):
3416 Read color file from absolute filename (bug#8250).
3417
f2b726e6
JB
34182011-03-19 Juanma Barranquero <lekktu@gmail.com>
3419
3420 * makefile.w32-in: Update dependencies.
3421
09f6ff02
EZ
34222011-03-17 Eli Zaretskii <eliz@gnu.org>
3423
3424 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3425
29a6015a
PE
34262011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3427
a3a6c54e
PE
3428 Fix more problems found by GCC 4.5.2's static checks.
3429
b766f867
PE
3430 * process.c (make_serial_process_unwind, send_process_trap):
3431 (sigchld_handler): Now static.
3432
be02381c
PE
3433 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3434 That way, the code declares only the vars that it needs.
3435 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3436 * s/cygwin.h (PTY_ITERATION): Likewise.
3437 * s/darwin.h (PTY_ITERATION): Likewise.
3438 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3439
57048744
PE
3440 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3441 * process.c (allocate_pty): Don't declare stb unless it's needed.
3442
7914961c 3443 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
3444 (CONSTANTLIM): Remove; unused.
3445 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3446 Define only if needed.
7914961c 3447
b3967b18
PE
3448 * unexelf.c (unexec): Name an expression,
3449 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
3450 Use a different way to cause a compilation error if anyone uses
3451 n rather than nn, a way that does not involve shadowing.
73366a00 3452 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 3453
29a6015a
PE
3454 * deps.mk (unexalpha.o): Remove; unused.
3455
43cfc33e 3456 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 3457 * unexec.h: New file.
ce701a33
PE
3458 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3459 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3460 Depend on unexec.h.
3461 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3462 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3463 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 3464 Change as necessary to match prototype in unexec.h.
ce701a33 3465
01f44d5a
PE
3466 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3467 shadowing.
4f63c6bb 3468 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 3469
a6670b0b
PE
3470 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3471 Rename locals to avoid shadowing.
3472
cef2010d 3473 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 3474 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 3475
d4d7173a
PE
3476 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3477
f08b802a
PE
3478 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3479 warning when compiling print.c.
3480
3ddb0639
PE
3481 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3482 instead of using an uninitialized var.
5ad03b97 3483 (font_sort_entities): Mark var as initialized.
3ddb0639 3484
170a2692
PE
3485 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3486
e663c700
PE
3487 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3488 pointers to constants.
89bc529a 3489 (font_parse_fcname): Remove unused vars.
7b81e2d0 3490 (font_delete_unmatched): Now static.
ea838e10 3491 (font_get_spec): Remove; unused.
13a547c6
PE
3492 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3493 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3494 Rename or move locals to avoid shadowing.
e663c700 3495
2a80c887 3496 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 3497 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 3498
1384fa33 3499 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 3500 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 3501
8b2c52e9
PE
3502 * alloc.c (mark_backtrace): Move decl from here ...
3503 * lisp.h: ... to here, so that it can be checked.
3504
475545b5 3505 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 3506 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
3507 (lisp_indirect_variable): Name an expression,
3508 to avoid gcc -Wbad-function-cast warning.
1faed8ae 3509 (Fdefvar): Rename locals to avoid shadowing.
475545b5 3510
b1349114 3511 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 3512 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 3513 Use const pointer when appropriate.
b1349114 3514
a2928364
PE
3515 * lisp.h (get_system_name, get_operating_system_release):
3516 Move decls here, to check interfaces.
3517 * process.c (get_operating_system_release): Move decl to lisp.h.
3518 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
3519 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3520 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3521 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
3522 (Fformat_time_string, Fencode_time, Finsert_char):
3523 (Ftranslate_region_internal, Fformat):
3524 Rename or remove local vars to avoid shadowing.
9710023e 3525 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 3526
a415e694
PE
3527 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3528 avoid shadowing.
3529
8ef4622d
PE
3530 * lisp.h (eassert): Check that the argument compiles, even if
3531 ENABLE_CHECKING is not defined.
3532
946f9a5b
PE
3533 * data.c (Findirect_variable): Name an expression, to avoid
3534 gcc -Wbad-function-cast warning.
112396d6 3535 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 3536 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
3537 (Fmake_variable_buffer_local, Fmake_local_variable):
3538 Mark variables as initialized.
52746918 3539 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 3540
e5aab7e7 3541 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
3542 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
3543 Rename locals to avoid shadowing.
dff45157
PE
3544 (mark_stack): Move local variables into the #ifdef region where
3545 they're used.
7bc26fdb
PE
3546 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
3547 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
3548 needed otherwise.
3549 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
3550 (GC_STRING_CHARS): Remove; not used.
d40d4be1 3551 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 3552
e5aab7e7
PE
3553 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
3554 avoids undefined behavior in theory.
3555
4da60324
PE
3556 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
3557
88043301
PE
3558 Use functions, not macros, for up- and down-casing (Bug#8254).
3559 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3560 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
3561 to use the following functions instead of these macros.
3562 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
3563 EMACS_INT, since callers assume the returned value fits in int.
3564 (upcase1): Likewise, for UPCASE_TABLE.
3565 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 3566 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 3567 the race-condition problem in the old DOWNCASE.
88043301 3568
19ed5445
PE
3569 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
3570 Rename locals to avoid shadowing.
3571 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
3572 (regex_compile, re_search_2, re_match_2_internal):
3573 Remove unused local vars.
952db0d7
PE
3574 (FREE_VAR): Rewrite so as not to use empty "else",
3575 which gcc can warn about.
da053e48 3576 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
3577 (RETALLOC_IF): Define only if needed.
3578 (WORDCHAR_P): Likewise. This one is never needed, but is used
3579 only in a comment talking about a compiler bug, so put inside
3580 the #if 0 of that comment.
3581 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
3582 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
3583 Remove; unused.
19ed5445 3584
1f3561e4 3585 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
3586 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
3587 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 3588
ded6f8f7
PE
3589 * search.c (simple_search): Remove unused var.
3590
dbd37a95
PE
3591 * dired.c (compile_pattern): Move decl from here ...
3592 * lisp.h: ... to here, so that it can be checked.
3593 (struct re_registers): New forward decl.
3594
7e47afad
PE
3595 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3596
85f24f61
PE
3597 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3598 All uses changed.
3599 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3600 Rename locals to avoid shadowing.
5671df8f 3601 (Fvertical_motion): Mark locals as initialized.
85f24f61 3602
181aa2be 3603 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 3604 (casify_region): Mark local as initialized.
181aa2be 3605
930d429c
PE
3606 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3607
7082eac6
PE
3608 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3609 New macros, so that the caller can use some names other than
3610 gcpro1, gcpro2, etc.
3611 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3612 of the new macros.
3613 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3614 argument, for consistency with GCPRO2_VAR, etc: it is now the
3615 prefix of the variable, not the variable itself. All uses
3616 changed.
38b2c076
PE
3617 * dired.c (directory_files_internal, file_name_completion):
3618 Rename locals to avoid shadowing.
3619
15206ed9
PE
3620 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3621 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3622 dired.c's scmp function, had undefined behavior.
3623 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3624 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3625 * buffer.h: ... to here, because these macros use current_buffer,
3626 and the new implementation with inline functions needs to have
3627 current_buffer in scope now, rather than later when the macros
3628 are used.
3629 (downcase, upcase1): New static inline functions.
3630 (DOWNCASE, UPCASE1): Reimplement using these functions.
3631 This avoids undefined behavior in expressions like
3632 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3633 from race conditions in accessing the global variables
3634 case_temp1 and case_temp2.
3635 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3636 * lisp.h (case_temp1, case_temp2): Remove their decls.
3637 * character.h (ASCII_CHAR_P): Move from here ...
3638 * lisp.h: ... to here, so that the inline functions mentioned
3639 above can use them.
3640
4a6bea26
PE
3641 * dired.c (directory_files_internal_unwind): Now static.
3642
f14b7e14
PE
3643 * fileio.c (file_name_as_directory, directory_file_name):
3644 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
3645 Now static.
2893f146
PE
3646 (file_name_as_directory): Use const pointers when appropriate.
3647 (Fexpand_file_name): Likewise. In particular, newdir might
3648 point at constant storage, so make it a const pointer.
fd4ead52 3649 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
3650 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
3651 signedness issues.
f839df0c
PE
3652 (Fset_file_times, Finsert_file_contents, auto_save_error):
3653 Rename locals to avoid shadowing.
f14b7e14 3654
5716756e 3655 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
3656 (Ftry_completion, Fall_completions): Rename or remove locals
3657 to avoid shadowing.
5716756e 3658
b4c3046a
PE
3659 * marker.c (bytepos_to_charpos): Remove; unused.
3660
b45db522
PE
3661 * lisp.h (verify_bytepos, count_markers): New decls,
3662 so that gcc does not warn that these functions aren't declared.
3663
85876d07
PE
3664 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
3665 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 3666 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 3667 (copy_text): Remove unused local var.
85876d07 3668
03d78a21 3669 * filelock.c (within_one_second): Now static.
b3dd38ab 3670 (lock_file_1): Rename local to avoid shadowing.
03d78a21 3671
5df8f01b
PE
3672 * buffer.c (fix_overlays_before): Mark locals as initialized.
3673 (fix_start_end_in_overlays): Likewise. This function should be
3674 simplified by using pointers-to-pointers, but that's a different
3675 matter.
b1d876f1 3676 (switch_to_buffer_1): Now static.
8f54f30a
PE
3677 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
3678 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 3679
a70072c9 3680 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 3681 Fix pointer signedness issue.
edced198
PE
3682 (sys_subshell): Mark local as volatile if checking for lint,
3683 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 3684 (MAXPATHLEN): Define only if needed.
a70072c9 3685
a0977c44
PE
3686 * process.c (serial_open, serial_configure): Move decls from here ...
3687 * systty.h: ... to here, so that they can be checked.
3688
a884fdcc
PE
3689 * fns.c (get_random, seed_random): Move extern decls from here ...
3690 * lisp.h: ... to here, so that they can be checked.
3691
604efe86 3692 * sysdep.c (reset_io): Now static.
b8950c94 3693 (wait_for_termination_signal): Remove; unused.
604efe86 3694
38fc62d9
PE
3695 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
3696 (copy_keymap_item, append_key, push_text_char_description):
3697 Now static.
1004a21a 3698 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 3699 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
3700 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
3701 (describe_map_tree):
3702 Rename locals to avoid shadowing.
38fc62d9 3703
2f2650da
PE
3704 * keyboard.c: Declare functions static if they are not used elsewhere.
3705 (echo_char, echo_dash, cmd_error, top_level_2):
3706 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
3707 (read_char, kbd_buffer_get_event, make_lispy_position):
3708 (make_lispy_event, make_lispy_movement, apply_modifiers):
3709 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
3710 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
3711 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 3712 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 3713 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 3714
a053e86c 3715 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
3716 (mark_kboards): Move decl here ...
3717 * alloc.c (mark_kboards): ... from here.
a053e86c 3718
4752793e
PE
3719 * lisp.h (force_auto_save_soon): New decl.
3720
74f10ca7 3721 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
3722 (DEFINE_DUMMY_FUNCTION): New macro.
3723 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
3724 Use it.
c03cd23f
PE
3725 (main): Add casts to avoid warnings
3726 if GCC considers string literals to be constants.
74f10ca7 3727
022e70d4
PE
3728 * lisp.h (fatal_error_signal): Add decl, since it's exported.
3729
59d6fe83
PE
3730 * dbusbind.c: Pointer signedness fixes.
3731 (xd_signature, xd_append_arg, xd_initialize):
3732 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3733 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3734 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
3735 (Fdbus_register_signal): Use SSDATA when the context wants char *.
3736
78320123
PE
3737 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
3738 if GCC considers string literals to be constants.
49cebcca 3739 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 3740
35ac2a97
SM
37412011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
3742
fb103ca9
SM
3743 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
3744 (print_preprocess, print_object): New macro to fix last change.
3745
35ac2a97
SM
3746 * print.c (print_preprocess): Don't forget font objects.
3747
62973b41
JB
37482011-03-16 Juanma Barranquero <lekktu@gmail.com>
3749
3750 * emacs.c (USAGE3): Doc fixes.
3751
0e48bb22
AS
37522011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3753
3754 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3755 structure.
3756
7684e57b
JB
37572011-03-14 Juanma Barranquero <lekktu@gmail.com>
3758
3759 * lisp.h (VWindow_system, Qfile_name_history):
3760 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3761 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3762 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3763
3764 * w32select.c: Don't #include "keyboard.h".
c96bbc66 3765 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
3766
3767 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3768 * w32console.c (detect_input_pending, read_input_pending)
3769 (encode_terminal_code):
3770 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3771 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3772 (w32_system_caret_y, Qfile_name_history):
3773 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3774 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3775 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3776 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3777 * w32proc.c (Qlocal, report_file_error):
3778 * w32term.c (Vwindow_system, updating_frame):
3779 * w32uniscribe.c (initialized, uniscribe_font_driver):
3780 Remove unneeded extern declarations.
3781
2aa46d6c
CY
37822011-03-14 Chong Yidong <cyd@stupidchicken.com>
3783
c96bbc66 3784 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 3785
cffc6f3b
CY
37862011-03-13 Chong Yidong <cyd@stupidchicken.com>
3787
3788 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3789 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3790 These macros can no longer be used for assignment.
3791
44f230aa
SM
3792 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3793 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
3794 (record_buffer_markers, fetch_buffer_markers): New functions for
3795 recording and fetching special buffer markers.
3796 (set_buffer_internal_1, set_buffer_temp): Use them.
3797
3798 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3799
3800 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3801
3802 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3803 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3804
3805 * xdisp.c (hscroll_window_tree):
3806 (reconsider_clip_changes): Use PT instead of BUF_PT.
3807
d251f04b
EZ
38082011-03-13 Eli Zaretskii <eliz@gnu.org>
3809
3810 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3811 $(EMACS_ROOT)/lib/intprops.h.
3812
f0c77cd1
PE
38132011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3814
3eca4629
PE
3815 Fix more problems found by GCC 4.5.2's static checks.
3816
7c86ee98
PE
3817 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3818 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
3819 (xg_free_frame_widgets): Make it clear that a local variable is
3820 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
3821 (gdk_window_get_screen): Make it clear that this macro is needed
3822 only if USE_GTK_TOOLTIP.
1e5524e7
PE
3823 (int_gtk_range_get_value): New function, which avoids a diagnostic
3824 from gcc -Wbad-function-cast.
3825 (xg_set_toolkit_scroll_bar_thumb): Use it.
3826 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3827 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
3828 (get_utf8_string, xg_get_file_with_chooser):
3829 Rename locals to avoid shadowing.
3830 (create_dialog): Move locals to avoid shadowing.
7c86ee98 3831
41729b81
PE
3832 * xgselect.c (xg_select): Remove unused var.
3833
f0c77cd1
PE
3834 * image.c (four_corners_best): Mark locals as initialized.
3835 (gif_load): Initialize transparent_p to zero (Bug#8238).
3836 Mark another local as initialized.
ec6cf4c6 3837 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 3838
ce0ad53d 3839 * image.c (clear_image_cache): Now static.
d5d5a617 3840 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 3841 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
3842 (x_edge_detection): Remove unnecessary cast that
3843 gcc -Wbad-function-cast diagnoses.
2037898d 3844 (gif_load): Fix pointer signedness.
6ae141d6
PE
3845 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
3846 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 3847
33383987 38482011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 3849
d32df629
PE
3850 Improve quality of tests for time stamp overflow.
3851 For example, without this patch (encode-time 0 0 0 1 1
3852 1152921504606846976) returns the obviously-bogus value (-948597
3853 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
3854 reports time overflow. See
3855 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
3856 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
3857 * editfns.c: Include limits.h and intprops.h.
3858 (TIME_T_MIN, TIME_T_MAX): New macros.
3859 (time_overflow): Move earlier, to before first use.
3860 (hi_time, lo_time): New functions, for an accurate test for
3861 out-of-range times.
3862 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3863 (Fget_internal_run_time): Don't assume time_t fits in int.
3864 (make_time): Use list2 instead of Fcons twice.
3865 (Fdecode_time): More accurate test for out-of-range times.
3866 (check_tm_member): New function.
3867 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
3868 (lisp_time_argument): Don't rely on undefined left-shift and
3869 right-shift behavior when checking for time stamp overflow.
8be6f318 3870
fe31d94c
PE
3871 * editfns.c (time_overflow): New function, refactoring common code.
3872 (Fformat_time_string, Fdecode_time, Fencode_time):
3873 (Fcurrent_time_string): Use it.
3874
8be6f318
PE
3875 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3876 * dired.c (make_time): Move to ...
3877 * editfns.c (make_time): ... here.
3878 * systime.h: Note the move.
3879
09d9db2c 38802011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 3881
126bc0dc
YM
3882 * fringe.c (update_window_fringes): Remove unused variables.
3883
c47cbdfd
YM
3884 * unexmacosx.c (copy_data_segment): Also copy __got section.
3885 (Bug#8223)
3886
7ac80be9
EZ
38872011-03-12 Eli Zaretskii <eliz@gnu.org>
3888
c96bbc66 3889 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
3890 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3891 Constify `char *' arguments and their references according to
3892 prototypes in tparam.h.
3893
ecb0f94d 3894 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 3895
7ac80be9
EZ
3896 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3897 Adapt all references accordingly.
3898
3899 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3900
ef1fd07e
TT
39012011-03-11 Tom Tromey <tromey@redhat.com>
3902
3903 * buffer.c (syms_of_buffer): Remove obsolete comment.
3904
7ef4b50c
EZ
39052011-03-11 Eli Zaretskii <eliz@gnu.org>
3906
3907 * termhooks.h (encode_terminal_code): Declare prototype.
3908
3909 * msdos.c (encode_terminal_code): Don't declare prototype.
3910
3911 * term.c (encode_terminal_code): Now external again, used by
3912 w32console.c and msdos.c.
3913
44f230aa
SM
3914 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
3915 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 3916
4b1ec863 39172011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 3918
1714f52b 3919 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 3920
4b1ec863
PE
3921 * fringe.c (update_window_fringes): Mark locals as initialized
3922 (Bug#8227).
3923 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 3924
524c7aa6
PE
3925 * alloc.c (mark_fringe_data): Move decl from here ...
3926 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3927 to check its interface.
3928 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3929
a5c0af81 3930 * fontset.c (free_realized_fontset): Now static.
7519b8cd 3931 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 3932 (fontset_font): Mark local as initialized.
a9a06e0b 3933 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 3934
b4716021
PE
3935 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3936
811e9bac 3937 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 3938 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
3939 (x_own_selection, Fx_disown_selection_internal): Rename locals
3940 to avoid shadowing.
3941 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 3942
7e3ab302
PE
3943 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3944 so that the caller can use some name other than gcpro1.
3945 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
3946 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3947 (Fx_backspace_delete_keys_p):
3948 Use them to avoid shadowing, and rename vars to avoid shadowing.
3949 (x_decode_color, x_set_name, x_window): Now static.
6b437900 3950 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 3951 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
3952 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3953 Remove unused locals.
7e3ab302
PE
3954 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3955 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3956 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3957 macros.
f78faa98 3958
e2b13473
PE
3959 * xterm.h (x_mouse_leave): New decl.
3960
77f23912
PE
3961 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3962 Remove unused functions.
cdf4ba58
PE
3963 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3964 (x_calc_absolute_position): Now static.
7411c686 3965 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 3966 Don't declare local "event" unless it's used.
ed7bf3a5
PE
3967 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3968 unless they are used.
38d0b34a
PE
3969 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3970 (x_fatal_error_signal): Remove; not used.
a6067996
PE
3971 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3972 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3973 (x_error_catcher, x_connection_closed, x_error_handler):
3974 (x_error_quitter, xembed_send_message, x_iconify_frame):
3975 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 3976 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 3977 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 3978
44f230aa
SM
3979 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3980 Rename or move locals to avoid shadowing.
6b463e58 3981 (tty_defined_color, merge_face_heights): Now static.
5967d051 3982 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
3983 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3984 does not deduce is never used uninitialized.
73719eba
PE
3985 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3986 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 3987
426994c3 3988 * terminal.c (store_terminal_param): Now static.
5489860b 3989
032f1620 3990 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 3991 (set_frame_menubar): Remove unused local.
d4323972 3992 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
3993 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3994 since they might point to immutable storage.
281585b0
PE
3995 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3996 since it's unused otherwise.
032f1620 3997
367c19e5 3998 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 3999 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
4000 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4001 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 4002 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
4003 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4004 does not deduce are never used uninitialized.
70739cbe 4005
07b48fa9
PE
4006 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4007
8868a238 4008 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
4009 * window.c (window_loop, size_window):
4010 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 4011
7e5cf297 4012 * window.c (display_buffer): Now static.
d6550a9f
PE
4013 (size_window): Mark variables that gcc -Wuninitialized
4014 does not deduce are never used uninitialized.
a586633d
PE
4015 * window.h (check_all_windows): New decl, to forestall
4016 gcc -Wmissing-prototypes diagnostic.
5b555da1 4017 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 4018
f6095868
PE
4019 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4020 shadowing.
4021 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
4022 Include <limits.h>.
4023 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4024 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
4025 (load_charset_map): Mark variables that gcc -Wuninitialized
4026 does not deduce are never used uninitialized.
53df7c11 4027 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 4028
f38b440c
PE
4029 * coding.c (coding_set_source, coding_set_destination):
4030 Use "else { /* comment */ }" rather than "else /* comment */;"
4031 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
4032 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4033 a block, when the outer 'i' will do.
4034 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4035 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4036 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4037 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4038 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4039 Rename locals to avoid shadowing.
4040 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
4041 * coding.c (emacs_mule_char, encode_invocation_designation):
4042 Now static, since they're not used elsewhere.
413bb2db 4043 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 4044 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
4045 (decode_coding_emacs_mule): Mark variables that gcc
4046 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
4047 (detect_coding_iso_2022): Initialize a local variable that might
4048 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 4049 this initialization is needed. (Bug#8211)
5f58e762
PE
4050 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4051 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4052 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4053 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4054 Remove unused macros.
f38b440c 4055
232b38b9 4056 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 4057 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 4058 * character.c (string_count_byte8): Likewise.
232b38b9 4059
fb90da1b
PE
4060 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4061 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4062
fb93dbc2
PE
4063 * chartab.c (copy_sub_char_table): Now static, since it's not used
4064 elsewhere.
5c156ace
PE
4065 (sub_char_table_ref_and_range, char_table_ref_and_range):
4066 Rename locals to avoid shadowing.
bbcd0949 4067 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 4068
7d3b3862 4069 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 4070 (BIDI_BOB): Remove unused macro.
7d3b3862 4071
6be7d3da
PE
4072 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4073 deduce are never used uninitialized.
c2ed9c8b 4074 * term.c (encode_terminal_code): Likewise.
6be7d3da 4075
75f8807f 4076 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 4077
50938595
PE
4078 * tparam.h: New file.
4079 * term.c, tparam.h: Include it.
4080 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4081 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4082 Move these decls to tparam.h, and make them agree with what
4083 is actually in tparam.c. The previous trick of using incompatible
4084 decls in different modules does not conform to the C standard.
4085 All callers of tparam changed to use tparam's actual API.
4086 * tparam.c (tparam1, tparam, tgoto):
4087 Use const pointers where appropriate.
4088
fbceeba2
PE
4089 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4090 * cm.h (struct cm): Likewise.
4091 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4092 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4093 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4094 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4095 (turn_on_face, init_tty): Likewise.
4096 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 4097
7f3f1250
PE
4098 * term.c (term_mouse_position): Rename local to avoid shadowing.
4099
e6ca6543
PE
4100 * alloc.c (mark_ttys): Move decl from here ...
4101 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4102
c40f8d15
AS
41032011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4104
4105 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4106
cfe0661d
JB
41072011-03-09 Juanma Barranquero <lekktu@gmail.com>
4108
4109 * search.c (compile_pattern_1): Remove argument regp, unused since
4110 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4111 (compile_pattern): Don't pass it.
4112
0afb4571
J
41132011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4114
4115 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4116 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4117 for ! HAVE_GTK3.
4118 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4119
4120 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4121
4122 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4123 gdk_window_get_screen, gdk_window_get_geometry,
4124 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4125 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4126 (xg_get_pixbuf_from_pixmap): New function.
4127 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4128 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4129 Call xg_get_pixbuf_from_pixmap instead of
4130 gdk_pixbuf_get_from_drawable.
4131 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4132 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4133 (xg_check_special_colors): Use GtkStyleContext and its functions
4134 for HAVE_GTK3.
4135 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4136 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4137 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
4138 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4139 Call gtk_widget_get_preferred_size.
0afb4571
J
4140 (xg_frame_resized): gdk_window_get_geometry only takes 5
4141 parameters.
44f230aa
SM
4142 (xg_win_to_widget, xg_event_is_for_menubar):
4143 Call gdk_x11_window_lookup_for_display.
0afb4571
J
4144 (xg_set_widget_bg): New function.
4145 (delete_cb): New function.
895009e1 4146 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
4147 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4148 (xg_set_background_color): Call xg_set_widget_bg.
4149 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4150 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4151 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4152 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4153 if ! HAVE_GTK3.
4154 (update_frame_tool_bar): Call gtk_widget_hide.
4155 (xg_initialize): Use GDK_KEY_g.
4156
4157 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4158 if ! HAVE_GTK3
4159 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4160
4161 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4162 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4163 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4164
1c2cc4ef
JB
41652011-03-08 Juanma Barranquero <lekktu@gmail.com>
4166
4167 * w32xfns.c (select_palette): Check success of RealizePalette against
4168 GDI_ERROR, not zero.
4169
33383987 4170See ChangeLog.11 for earlier changes.
aac0c6e3
MR
4171
4172;; Local Variables:
4173;; coding: utf-8
aac0c6e3
MR
4174;; End:
4175
33383987 4176 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
4177
4178 This file is part of GNU Emacs.
4179
4180 GNU Emacs is free software: you can redistribute it and/or modify
4181 it under the terms of the GNU General Public License as published by
4182 the Free Software Foundation, either version 3 of the License, or
4183 (at your option) any later version.
4184
4185 GNU Emacs is distributed in the hope that it will be useful,
4186 but WITHOUT ANY WARRANTY; without even the implied warranty of
4187 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4188 GNU General Public License for more details.
4189
4190 You should have received a copy of the GNU General Public License
4191 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.