* lisp/subr.el (read-passwd-map): New var.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
c6e21c03
PE
12012-10-06 Paul Eggert <eggert@cs.ucla.edu>
2
3 * keyboard.c (read_char): Remove unnecessary 'volatile's and label.
4
0d9f584b
EZ
52012-10-05 Eli Zaretskii <eliz@gnu.org>
6
a65fbb5f
EZ
7 * w32proc.c (stop_timer_thread): Fix declaration of 'err'.
8
0d9f584b
EZ
9 * w32.c (utime): Open the file with FILE_FLAG_BACKUP_SEMANTICS, so
10 that time stamps of directories could also be changed. Don't
11 request the too broad GENERIC_WRITE, only the more restrictive
12 FILE_WRITE_ATTRIBUTES access rights.
13
14 * fileio.c (Fset_file_times): Special-case ignoring errors for
15 directories only on MSDOS, not on MS-Windows.
16
e8757f09 172012-10-05 Ikumi Keita <ikumi@ikumi.que.jp> (tiny change)
ca347e3d
IK
18
19 * minibuf.c (Fcompleting_read): Doc fix. (Bug#12555)
20
7604f298
EZ
212012-10-04 Eli Zaretskii <eliz@gnu.org>
22
23 * w32.c (utime): Test for INVALID_HANDLE_VALUE, not for NULL, to
24 see whether CreateFile failed.
25
88d69b7d
PE
262012-10-04 Paul Eggert <eggert@cs.ucla.edu>
27
28 * profiler.c (handle_profiler_signal): Inhibit pending signals too,
29 to avoid similar races.
30 * keyboard.c (pending_signals): Now bool, not int.
31
7509f454
PE
32 Port timers to OpenBSD, plus check for timer failures.
33 OpenBSD problem reported by Han Boetes.
34 * profiler.c (setup_cpu_timer): Check for failure of timer_settime
35 and/or setitimer.
36 (Fprofiler_cpu_stop): Don't assume HAVE_SETITIMER.
37 * syssignal.h (HAVE_ITIMERSPEC): New macro. This is for platforms
38 like OpenBSD, which has timer_settime but does not declare it.
39 OpenBSD does not define SIGEV_SIGNAL, so use that when deciding
40 whether to use itimerspec-related primitives. All uses of
41 HAVE_TIMER_SETTIME replaced with HAVE_ITIMERSPEC.
42
a3c5c0c5
PE
432012-10-02 Paul Eggert <eggert@cs.ucla.edu>
44
45 * profiler.c (handle_profiler_signal): Fix a malloc race
46 that caused Emacs to hang on Fedora 17 when profiling Lisp.
47
914e743b
JD
482012-10-02 Jan Djärv <jan.h.d@swipnet.se>
49
50 * nsterm.m (windowDidEnterFullScreen): Remove fprintf.
51
d8ab37a8
EZ
522012-10-02 Eli Zaretskii <eliz@gnu.org>
53
54 * w32proc.c (sys_wait): Declare 'signame' 'const char *', to be
55 consistent with the change in return value of 'safe_strsignal'.
56
b3ecad33
PE
572012-10-02 Paul Eggert <eggert@cs.ucla.edu>
58
0a99eee1
PE
59 Prefer plain 'static' to 'static inline' (Bug#12541).
60 * bidi.c (bidi_get_type, bidi_check_type, bidi_get_category)
61 (bidi_set_sor_type, bidi_push_embedding_level)
62 (bidi_pop_embedding_level, bidi_remember_char, bidi_copy_it)
63 (bidi_cache_reset, bidi_cache_shrink, bidi_cache_fetch_state)
64 (bidi_cache_search, bidi_cache_ensure_space)
65 (bidi_cache_iterator_state, bidi_cache_find)
66 (bidi_peek_at_next_level, bidi_set_paragraph_end)
67 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
68 (bidi_explicit_dir_char, bidi_resolve_neutral_1):
69 Now 'static', not 'static inline'.
70
b3ecad33
PE
71 Count overruns when profiling; change units to ns.
72 * profiler.c (handle_profiler_signal): Count sampling intervals, not ms.
73 Give extra weight to samples after overruns, to attempt to count
74 the time more accurately.
75 (setup_cpu_timer): Change sampling interval units from ms to ns, since
76 the underlying primitives nominally do ns.
77 (Fprofiler_cpu_start): Document the change. Mention that
78 the sampling intervals are only approximate.
79
090cf9db
SM
802012-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
81
82 * frame.c (Fmake_terminal_frame): Prefer safer CONSP over !NILP.
83
84 * coding.h (ENCODE_FILE, DECODE_FILE, DECODE_SYSTEM): Remove special
85 case for the special 0 coding-system.
86
87 * buffer.c (Fset_buffer_multibyte): Signal an error instead of widening.
88 (Fmake_overlay): Remove redundant tests.
64edc777 89 (fix_start_end_in_overlays): Remove redundant recentering.
090cf9db 90
81550bf4
JB
912012-10-02 Juanma Barranquero <lekktu@gmail.com>
92
93 * makefile.w32-in ($(BLD)/alloc.$(O), $(BLD)/gmalloc.$(O)):
94 Update dependencies.
95
aa1ba90e
PE
962012-10-01 Paul Eggert <eggert@cs.ucla.edu>
97
98 Fix a malloc race condition involving strsignal.
99 A signal can arrive in the middle of a malloc, and Emacs's signal
100 handler can invoke strsignal, which can invoke malloc, which is
101 not portable. This race condition bug makes Emacs hang on GNU/Linux.
102 Fix it by altering the signal handler so that it does not invoke
103 strsignal.
104 * emacs.c (shut_down_emacs): Use safe_strsignal, not strsignal.
105 * process.c (status_message): Use const pointer, in case strsignal
106 is #defined to safe_strsignal.
107 * sysdep.c (sys_siglist, init_signals): Always define and
108 initialize a substitute sys_siglist if the system does not define
109 one, even if HAVE_STRSIGNAL.
110 (safe_strsignal): Rename from strsignal. Always define,
111 using sys_siglist. Return a const pointer.
112 * syssignal.h (safe_strsignal): New decl.
113 (strsignal) [!HAVE_STRSIGNAL]: Define in terms of safe_strsignal.
114
ace917bd
EZ
1152012-10-01 Eli Zaretskii <eliz@gnu.org>
116
117 * w32proc.c (timer_loop): Fix code that waits for timer
118 expiration, to avoid high CPU usage.
119
9eb71b9c
SM
1202012-10-01 Stefan Monnier <monnier@iro.umontreal.ca>
121
122 * fns.c (check_hash_table, get_key_arg, maybe_resize_hash_table)
123 (sweep_weak_table): Remove redundant prototypes.
124
b3317662
FP
1252012-10-01 Fabrice Popineau <fabrice.popineau@gmail.com>
126
127 * emacs.c: Move the inclusion of TERM_HEADER after including
128 windows.h on WINDOWSNT. This avoids compilation problems with
129 MSVC.
130
f0e5f225
EZ
1312012-10-01 Eli Zaretskii <eliz@gnu.org>
132
2d7d1608
EZ
133 * unexw32.c (OFFSET_TO_RVA, RVA_TO_OFFSET)
134 (RVA_TO_SECTION_OFFSET): Encode all macro arguments in parentheses.
135 (RVA_TO_PTR): Cast the result of RVA_TO_OFFSET to 'unsigned char *',
136 as the previous version used 'void *'.
137
138 * ralloc.c (ROUNDUP): Fix last change.
139 (MEM_ROUNDUP): Don't cast MEM_ALIGN, it is already of type
140 'size_t'.
141
f0e5f225
EZ
142 * w32proc.c <disable_itimers>: New static flag.
143 (init_timers): Initialize it to zero, after creating the critical
144 sections used by the timer threads.
145 (term_timers): Set to 1 before deleting the critical sections.
146 (getitimer, setitimer): If disable_itimers is non-zero, return an
147 error indication without doing anything. Reported by Fabrice
148 Popineau <fabrice.popineau@supelec.fr> as part of bug#12544.
4cdfbb89
EZ
149 (alarm) [HAVE_SETITIMER]: Be more conformant to the expected
150 return results.
151 [!HAVE_SETITIMER]: Behave as the previous version that didn't
152 support timers.
f0e5f225
EZ
153
154 * emacs.c (shut_down_emacs) [WINDOWSNT]: Move the call to
155 term_ntproc after all the other bookkeeping, to get timers working
156 as long as possible.
157
82ef37c1
PE
1582012-10-01 Paul Eggert <eggert@cs.ucla.edu>
159
b3a4c387
PE
160 * xdisp.c (syms_of_xdisp): Default message-log-max to 1000, not 100.
161 Suggested by Juri Linkov in
162 <http://lists.gnu.org/archive/html/emacs-devel/2012-09/msg00821.html>.
163
b0ab8123
PE
164 Prefer plain 'static' to 'static inline' (Bug#12541).
165 With static functions, modern compilers inline pretty well by
166 themselves; advice from programmers often hurts as much as it helps.
167 On my host (x86-64, Fedora 17, GCC 4.7.2, default 'configure'),
168 this change shrinks the text size of the Emacs executable by 1.1%
169 without affecting CPU significantly in my benchmark.
170 * alloc.c (mem_find, live_string_p, live_cons_p, live_symbol_p)
171 (live_float_p, live_misc_p, live_vector_p, live_buffer_p)
172 (mark_maybe_object, mark_maybe_pointer, bounded_number):
173 * buffer.c (bset_abbrev_mode, bset_abbrev_table)
174 (bset_auto_fill_function, bset_auto_save_file_format)
175 (bset_auto_save_file_name, bset_backed_up, bset_begv_marker)
176 (bset_bidi_display_reordering, bset_buffer_file_coding_system)
177 (bset_cache_long_line_scans, bset_case_fold_search)
178 (bset_ctl_arrow, bset_cursor_in_non_selected_windows)
179 (bset_cursor_type, bset_display_table, bset_extra_line_spacing)
180 (bset_file_format, bset_file_truename, bset_fringe_cursor_alist)
181 (bset_fringe_indicator_alist, bset_fringes_outside_margins)
182 (bset_header_line_format, bset_indicate_buffer_boundaries)
183 (bset_indicate_empty_lines, bset_invisibility_spec)
184 (bset_left_fringe_width, bset_major_mode, bset_mark)
185 (bset_minor_modes, bset_mode_line_format, bset_mode_name)
186 (bset_name, bset_overwrite_mode, bset_pt_marker)
187 (bset_right_fringe_width, bset_save_length)
188 (bset_scroll_bar_width, bset_scroll_down_aggressively)
189 (bset_scroll_up_aggressively, bset_selective_display)
190 (bset_selective_display_ellipses, bset_vertical_scroll_bar_type)
191 (bset_word_wrap, bset_zv_marker, set_buffer_overlays_before)
192 (set_buffer_overlays_after):
193 * category.c (bset_category_table):
194 * charset.c (read_hex):
195 * coding.c (produce_composition, produce_charset)
196 (handle_composition_annotation, handle_charset_annotation)
197 (char_encodable_p):
198 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers)
199 (assign_row, set_frame_matrix_frame, make_current)
200 (add_row_entry):
201 * eval.c (set_specpdl_symbol, set_specpdl_old_value):
202 * fns.c (maybe_resize_hash_table):
203 * frame.c (fset_buffer_predicate, fset_minibuffer_window):
204 * gmalloc.c (register_heapinfo):
205 * image.c (lookup_image_type):
206 * intervals.c (set_interval_object, set_interval_left)
207 (set_interval_right, copy_interval_parent, rotate_right)
208 (rotate_left, balance_possible_root_interval):
209 * keyboard.c (kset_echo_string, kset_kbd_queue)
210 (kset_keyboard_translate_table, kset_last_prefix_arg)
211 (kset_last_repeatable_command, kset_local_function_key_map)
212 (kset_overriding_terminal_local_map, kset_real_last_command)
213 (kset_system_key_syms, clear_event, set_prop):
214 * lread.c (digit_to_number):
215 * marker.c (attach_marker, live_buffer, set_marker_internal):
216 * nsterm.m (ns_compute_glyph_string_overhangs):
217 * process.c (pset_buffer, pset_command)
218 (pset_decode_coding_system, pset_decoding_buf)
219 (pset_encode_coding_system, pset_encoding_buf, pset_filter)
220 (pset_log, pset_mark, pset_name, pset_plist, pset_sentinel)
221 (pset_status, pset_tty_name, pset_type, pset_write_queue):
222 * syntax.c (bset_syntax_table, dec_bytepos):
223 * terminal.c (tset_param_alist):
224 * textprop.c (interval_has_some_properties)
225 (interval_has_some_properties_list):
226 * window.c (wset_combination_limit, wset_dedicated)
227 (wset_display_table, wset_hchild, wset_left_fringe_width)
228 (wset_left_margin_cols, wset_new_normal, wset_new_total)
229 (wset_normal_cols, wset_normal_lines, wset_parent, wset_pointm)
230 (wset_right_fringe_width, wset_right_margin_cols)
231 (wset_scroll_bar_width, wset_start, wset_temslot, wset_vchild)
232 (wset_vertical_scroll_bar_type, wset_window_parameters):
233 * xdisp.c (wset_base_line_number, wset_base_line_pos)
234 (wset_column_number_displayed, wset_region_showing)
235 (window_box_edges, run_window_scroll_functions)
236 (append_glyph_string_lists, prepend_glyph_string_lists)
237 (append_glyph_string, set_glyph_string_background_width)
238 (append_glyph, append_composite_glyph)
239 (take_vertical_position_into_account):
240 * xfaces.c (x_create_gc, x_free_gc, merge_face_vectors)
241 (face_attr_equal_p, lface_equal_p, hash_string_case_insensitive)
242 (lface_hash, lface_same_font_attributes_p, lookup_face):
243 * xml.c (libxml2_loaded_p):
244 * xterm.c (x_set_mode_line_face_gc, x_set_glyph_string_gc)
245 (x_set_glyph_string_clipping, x_clear_glyph_string_rect):
246 Now 'static', not 'static inline'.
247
05584c31
PE
248 * bidi.c: Tune.
249 (bidi_copy_it): Do the whole copy with a single memcpy.
250 (bidi_char_at_pos): Merge the two STRING_CHAR calls into one.
251
86ec63ba
PE
252 Revert the FOLLOW-SYMLINKS change for file-attributes.
253 Doing it right would require several changes to Tramp, and there's
254 not enough time to get that tested before the freeze today.
255 * dired.c (directory_files_internal, Ffile_attributes):
256 Undo last change.
257
82ef37c1
PE
258 * frame.c (x_report_frame_params): Port better to wider ints.
259 Do not assume that EMACS_UINT is the same width as uprintmax_t,
260 or that pointers can be printed in 15 decimal digits.
261 Avoid GCC warnings if EMACS_UINT is wider than a pointer.
262
62aba0d4
FP
2632012-09-30 Fabrice Popineau <fabrice.popineau@supelec.fr>
264
265 Support x64 build on MS-Windows.
266 * w32term.h (SCROLL_BAR_PACK, SCROLL_BAR_UNPACK): Define for x64.
267 (SET_SCROLL_BAR_W32_WINDOW): Cast ID to intptr_t, for
268 compatibility with x64.
5e4daaf3 269 (x_get_focus_frame): Add prototype.
62aba0d4
FP
270
271 * w32term.c (w32_draw_underwave): Don't use GCC extensions for
272 defining an XRectangle structure.
273
274 * w32proc.c (RVA_TO_PTR, w32_executable_type): Fix pointer
275 arithmetics for compatibility with x64.
276
277 * w32menu.c (add_menu_item): Use UINT_PTR instead of UINT, for
278 compatibility with x64.
279
280 * w32heap.h: Adjust prototypes and declarations.
281
282 * w32heap.c (RVA_TO_PTR, allocate_heap, sbrk, init_heap)
283 (round_heap): Use DWORD_PTR, ptrdiff_t and size_t instead of
284 DWORD, long, and unsigned long, for compatibility with x64.
285 (allocate_heap) [_WIN64]: Reserve 32GB of memory.
286 (sbrk): Argument is now of type ptrdiff_t.
287
288 * w32fns.c (HMONITOR): Condition declaration on _WIN32_WINNT being
289 less than 0x0500.
290 (w32_msg_pump): Use WPARAM type for 'result'.
291
292 * w32.c (init_environment, get_emacs_configuration): Support AMD64
293 architecture.
294 (init_ntproc): Cast arguments of _open_osfhandle to intptr_t, for
295 compatibility with x64.
296
297 * vm-limit.c (lim_data): Now size_t.
298 (check_memory_limits): Adjust prototypes of real_morecore and
299 __morecore to receive argument of type ptrdiff_t. Use size_t for
300 five_percent and data_size.
301
302 * unexw32.c: Use DWORD_PTR instead of DWORD for file-scope
303 variables, for compatibility with x64.
304 (rva_to_section, offset_to_section, relocate_offset)
305 (OFFSET_TO_RVA, RVA_TO_OFFSET, RVA_TO_SECTION_OFFSET)
306 (PTR_TO_RVA, RVA_TO_PTR, OFFSET_TO_PTR, get_section_info)
307 (copy_executable_and_dump_data): Use DWORD_PTR instead of DWORD
308 for compatibility with x64.
309
310 * sysdep.c (STDERR_FILENO): Define if not already defined.
311
312 * ralloc.c (real_morecore): Argument type is now ptrdiff_t.
313 (__morecore): Argument type is now ptrdiff_t.
314 (ROUNDUP, MEM_ROUNDUP): Use size_t instead of 'unsigned long'.
315 (relinquish): Use ptrdiff_t type for 'excess'.
316 (r_alloc_sbrk): Argument type is now ptrdiff_t.
317
318 * makefile.w32-in (HEAPSIZE): Get value from EMACS_HEAPSIZE.
319 (bootstrap-temacs-CMD, bootstrap-temacs-SH): Use $(EMACS_PURESIZE)
320 instead of a literal number.
321
322 * gmalloc.c [WINDOWSNT]: Include w32heap.h.
323 (min): Define only if not already defined.
324
325 * frame.c (x_report_frame_params): Use EMACS_UINT for the return
326 value of FRAME_X_WINDOW, to fit a 64-bit pointer on 64-bit Windows
327 hosts.
328
329 * image.c (x_bitmap_pixmap): Return ptrdiff_t, not int, since
330 'bitmaps' is a pointer.
331
332 * dispextern.h (x_bitmap_pixmap): Adjust prototype.
333
334 * alloc.c (gdb_make_enums_visible): Now conditional on __GNUC__.
335
e7a2937b
PE
3362012-09-30 Paul Eggert <eggert@cs.ucla.edu>
337
338 file-attributes has a new optional arg FOLLOW-SYMLINKS.
339 * dired.c (directory_files_internal, Ffile_attributes):
340 New arg follow_symlinks. All uses changed.
341
b43d62ae
SM
3422012-09-30 Stefan Monnier <monnier@iro.umontreal.ca>
343
344 * .gdbinit (xbacktrace): Adjust to recent "struct backtrace" change.
345
c06c382a
EZ
3462012-09-30 Eli Zaretskii <eliz@gnu.org>
347
348 Support atimers and CPU profiler via profile.c on MS-Windows.
349 * w32proc.c (sig_mask, crit_sig): New static variables.
350 (sys_signal): Support SIGALRM and SIGPROF.
351 (sigemptyset, sigaddset, sigfillset, sigprocmask)
b43d62ae 352 (pthread_sigmask, setpgrp): Move here from w32.c. sigaddset,
c06c382a
EZ
353 sigfillset, and sigprocmask are no longer no-ops.
354 (sigismember): New function.
355 (struct itimer_data): New definition.
356 (ticks_now, real_itimer, prof_itimer, clocks_min, crit_real)
357 (crit_prof): New static variables.
358 (MAX_SINGLE_SLEEP): New definition.
359 (timer_loop, stop_timer_thread, term_timers, init_timers)
360 (start_timer_thread, getitimer, setitimer): New functions.
361 (alarm): No longer a no-op, calls setitimer.
362
363 * w32.c (term_ntproc): Call term_timers.
364 (init_ntproc): Make sure all signals are unblocked at startup, to
365 erase any traces of dumping. Call init_timers.
366
367 * w32fns.c (hourglass_timer, HOURGLASS_ID): Remove.
368 Windows-specific code to display the hourglass mouse pointer is no
369 longer used.
370 (w32_wnd_proc): Remove code that handled the WM_TIMER message due
371 to hourglass timer expiration.
372 (start_hourglass, cancel_hourglass, DEFAULT_HOURGLASS_DELAY):
373 Remove, no longer used.
b43d62ae
SM
374 (w32_note_current_window, show_hourglass, hide_hourglass):
375 New functions, in support of hourglass cursor display similar to other
c06c382a
EZ
376 window systems.
377 (syms_of_w32fns): Don't initialize hourglass_timer.
378
379 * xdisp.c (start_hourglass, cancel_hourglass): Now used on
380 WINDOWSNT as well.
381 (start_hourglass) [WINDOWSNT]: Call w32_note_current_window.
382
383 * w32.h (init_timers, term_timers): Add prototypes.
384
95402d5f
KH
3852012-09-30 Kenichi Handa <handa@gnu.org>
386
387 * coding.c (decode_coding_ccl, encode_coding_ccl): Pay attention
388 to the buffer relocation which may be caused by ccl_driver.
389
dd946752
JD
3902012-09-30 Jan Djärv <jan.h.d@swipnet.se>
391
d7e642cc
JD
392 * xfns.c (Fx_file_dialog): Update comment.
393
394 * w32fns.c (Fx_file_dialog): Update comment.
395
396 * nsfns.m (Fns_read_file_name): Add argument DIR_ONLY_P.
397 Initialize panel name field if OSX >= 10.6.
398
399 * fileio.c (Fnext_read_file_uses_dialog_p): Add HAVE_NS.
400
dd946752
JD
401 * nsfns.m (ns_frame_parm_handlers): Add x_set_fullscreen.
402
403 * nsterm.m (NEW_STYLE_FS): New define.
404 (ns_fullscreen_hook, windowWillEnterFullScreen)
405 (windowDidEnterFullScreen, windowWillExitFullScreen)
406 (windowDidExitFullScreen, toggleFullScreen, handleFS)
407 (setFSValue): New functions.
408 (EmacsFSWindow): New implementation.
409 (canBecomeKeyWindow): New function for EmacsFSWindow.
410 (ns_create_terminal): Set fullscreen_hook to ns_fullscreen_hook.
411 (dealloc): Release nonfs_window if in fullscreen.
412 (updateFrameSize:): Call windowDidMove to update top/left.
413 (windowWillResize:toSize:): Check if frame is still maximized.
414 (initFrameFromEmacs:): Initialize fs_state, fs_before_fs,
415 next_maximized, maximized_width, maximized_height and nonfs_window.
416 Call setCollectionBehavior if NEW_STYLE_FS. Initialize bwidth and
417 tbar_height.
418 (windowWillUseStandardFrame:defaultFrame:): Update frame parameter
419 fullscreen. Set maximized_width/height. Act on next_maximized.
420
421 * nsterm.h (MAC_OS_X_VERSION_10_7, MAC_OS_X_VERSION_10_8): New.
422 (EmacsView): Add variables for fullscreen.
423 (handleFS, setFSValue, toggleFullScreen): New in EmacsView.
424 (EmacsFSWindow): New interface for fullscreen.
425
427730eb
JB
4262012-09-30 Juanma Barranquero <lekktu@gmail.com>
427
428 * makefile.w32-in ($(BLD)/profiler.$(O)): Update dependencies.
429
48de8b12
CY
4302012-09-30 Chong Yidong <cyd@gnu.org>
431
432 * fns.c (Frandom): Doc fix.
433
5938d519
MR
4342012-09-30 Martin Rudalics <rudalics@gmx.at>
435
436 * window.c (Vwindow_combination_limit): New default value.
437 (Qwindow_size): New symbol replacing Qtemp_buffer_resize.
438
cb5b0266
PE
4392012-09-30 Paul Eggert <eggert@cs.ucla.edu>
440
441 * syssignal.h (PROFILER_CPU_SUPPORT): Don't define if PROFILING.
442 Suggested by Eli Zaretskii in
443 <http://lists.gnu.org/archive/html/emacs-devel/2012-09/msg00811.html>.
444
84f72efd
EZ
4452012-09-30 Eli Zaretskii <eliz@gnu.org>
446
447 * profiler.c (Fprofiler_cpu_stop): Use timer_settime only if
448 HAVE_TIMER_SETTIME is defined.
449
9d4dcdc9
PE
4502012-09-30 Paul Eggert <eggert@cs.ucla.edu>
451
d89460ed
PE
452 Profiler improvements: more-accurate timers, overflow checks.
453 * profiler.c: Don't include stdio.h, limits.h, sys/time.h,
454 signal.h, setjmp.h. Include systime.h instead.
455 (saturated_add): New function.
456 (record_backtrace, current_sample_interval): Use EMACS_INT, not size_t.
457 (record_backtrace, handle_profiler_signal): Saturate on fixnum overflow.
458 (profiler_timer, profiler_timer_ok) [HAVE_TIMER_SETTIME]:
459 New static vars.
84f72efd 460 (enum profiler_cpu_running): New enum.
d89460ed
PE
461 (profiler_cpu_running): Now of that enum type, not bool.
462 All uses changed to store the new value.
463 (handle_profiler_signal): Rename from sigprof_handler_1,
464 for consistency with other handlers. Do not check whether
465 cpu_log is a hash-table if garbage collecting, since it
466 doesn't matter in that case.
467 (deliver_profiler_signal): Rename from sigprof_handler,
468 for consistency with other handlers.
469 (setup_cpu_timer): New function, with much of what used to be in
470 Fprofiler_cpu_start. Check for out-of-range argument.
471 Prefer timer_settime if available, and prefer
472 thread cputime clocks, then process cputime clocks, then
473 monotonic clocks, to the old realtime clock. Use make_timeval
474 to round more-correctly when falling back to setitimer.
475 (Fprofiler_cpu_start): Use it.
476 (Fprofiler_cpu_stop): Prefer timer_settime if available.
477 Don't assume that passing NULL as the 2nd argument of setitimer
478 is the same as passing a pointer to all-zero storage.
479 Ignore SIGPROF afterwards.
480 (malloc_probe): Saturate at MOST_POSITIVE_FIXNUM.
481 * sysdep.c (emacs_sigaction_init): Also mask out SIGPROF in
482 non-fatal signal handlers. Ignore SIGPROF on startup.
483 * syssignal.h (PROFILER_CPU_SUPPORT): Define this macro here, not
484 in profiler.c, since sysdep.c now uses it.
485
9d4dcdc9
PE
486 * sysdep.c (handle_fatal_signal): Bump backtrace size to 40.
487 Suggested by Eli Zaretskii in
488 <http://lists.gnu.org/archive/html/emacs-devel/2012-09/msg00796.html>.
489
8e5691a0
JB
4902012-09-29 Juanma Barranquero <lekktu@gmail.com>
491
492 * makefile.w32-in ($(BLD)/profiler.$(O)): Update dependencies.
493
e7c1b6ef
SM
4942012-09-29 Stefan Monnier <monnier@iro.umontreal.ca>
495
496 * lisp.h (struct backtrace): Remove indirection for `function' field.
497 * xdisp.c (redisplay_internal):
498 * profiler.c (record_backtrace, sigprof_handler_1):
499 * alloc.c (Fgarbage_collect):
500 * eval.c (interactive_p, Fsignal, eval_sub, Ffuncall, Fbacktrace)
501 (Fbacktrace_frame): Adjust accordingly.
502
e61d39cd 5032012-09-28 Glenn Morris <rgm@gnu.org>
d393cefb
GM
504
505 * eval.c (Frun_hook_with_args, Frun_hook_with_args_until_success)
506 (Frun_hook_with_args_until_failure): Doc fixes.
507
404043ea
EZ
5082012-09-28 Eli Zaretskii <eliz@gnu.org>
509
510 * xdisp.c (syms_of_xdisp) <Qredisplay_internal>: Rename from
511 Qautomatic_redisplay and change the symbol name. All users changed.
512
704d3f45
TM
5132012-09-28 Tomohiro Matsuyama <tomo@cx4a.org>
514
515 * profiler.c (sigprof_handler): Fix race condition.
516
757140ff
GM
5172012-09-28 Glenn Morris <rgm@gnu.org>
518
519 * lread.c (lisp_file_lexically_bound_p): Handle #! lines. (Bug#12528)
520
a615a3ae
PE
5212012-09-27 Paul Eggert <eggert@cs.ucla.edu>
522
523 Check more robustly for timer_settime.
89d17fd0
PE
524 * Makefile.in (LIB_TIMER_TIME): New macro.
525 (LIBES): Add it.
a615a3ae
PE
526 * atimer.c (alarm_timer, alarm_timer_ok, set_alarm, init_atimer):
527 Use HAVE_TIMER_SETTIME, not SIGEV_SIGNAL, to decide whether to
528 call timer_settime.
529
3670daf7
TM
5302012-09-26 Tomohiro Matsuyama <tomo@cx4a.org>
531
532 * profiler.c (Fprofiler_cpu_start): Remove unnecessary flag SA_SIGINFO.
533
6a586b7f
JB
5342012-09-26 Juanma Barranquero <lekktu@gmail.com>
535
536 * makefile.w32-in ($(BLD)/profiler.$(O)): Update dependencies.
537
41c8bfcf
PE
5382012-09-26 Paul Eggert <eggert@cs.ucla.edu>
539
540 * character.h (MAYBE_UNIFY_CHAR): Remove.
541 * charset.c, charset.h (maybe_unify_char): Now static.
542 * charset.c (decode_char): Use maybe_unify_char, not MAYBE_UNIFY_CHAR.
543 Since this stuff is now private to charset.c, there's no need for
544 a public macro and no need to inline by hand.
545
3a880af4
SM
5462012-09-26 Tomohiro Matsuyama <tomo@cx4a.org>
547 Stefan Monnier <monnier@iro.umontreal.ca>
548 Juanma Barranquero <lekktu@gmail.com>
611b7507 549
3a880af4
SM
550 * profiler.c: New file.
551 * Makefile.in (base_obj): Add profiler.o.
611b7507
JB
552 * makefile.w32-in (OBJ2, GLOBAL_SOURCES): Add profiler.c.
553 ($(BLD)/profiler.$(O)): New target.
3a880af4
SM
554 * emacs.c (main): Call syms_of_profiler.
555 * alloc.c (Qautomatic_gc): New constant.
556 (MALLOC_PROBE): New macro.
557 (xmalloc, xzalloc, xrealloc, lisp_malloc, lisp_align_malloc): Use it.
558 (total_bytes_of_live_objects): New function.
559 (Fgarbage_collect): Use it. Record itself in backtrace_list.
560 Call malloc_probe for the memory profiler.
561 (syms_of_alloc): Define Qautomatic_gc.
562 * eval.c (eval_sub, Ffuncall): Reorder assignments to avoid
563 race condition.
564 (struct backtrace): Move definition...
565 * lisp.h (struct backtrace): ..here.
566 (Qautomatic_gc, profiler_memory_running): Declare vars.
567 (malloc_probe, syms_of_profiler): Declare functions.
568 * xdisp.c (Qautomatic_redisplay): New constant.
569 (redisplay_internal): Record itself in backtrace_list.
570 (syms_of_xdisp): Define Qautomatic_redisplay.
611b7507 571
5938d519 5722012-09-25 Eli Zaretskii <eliz@gnu.org>
b67238c2
JB
5732012-09-25 Juanma Barranquero <lekktu@gmail.com>
574
575 * makefile.w32-in ($(BLD)/callproc.$(O)): Update dependencies.
576
e26fd2e4
PE
5772012-09-25 Paul Eggert <eggert@cs.ucla.edu>
578
579 Prefer POSIX timers if available.
580 They avoid a race if the timer is too close to the current time.
581 * atimer.c (alarm_timer, alarm_timer_ok) [SIGEV_SIGNAL]: New static vars.
582 (set_alarm) [SIGEV_SIGNAL]: Use POSIX timers if available.
9180598c 583 (init_atimer) [SIGEV_SIGNAL]: Initialize them.
e26fd2e4 584
eedec3ee
EZ
5852012-09-25 Eli Zaretskii <eliz@gnu.org>
586
587 * coding.c (CHAR_STRING_ADVANCE_NO_UNIFY): Make it an alias of
588 CHAR_STRING_ADVANCE.
589 (STRING_CHAR_ADVANCE_NO_UNIFY): Make it an alias of
590 STRING_CHAR_ADVANCE.
591
aa15c6bb
JB
5922012-09-25 Juanma Barranquero <lekktu@gmail.com>
593
594 Move Vlibrary_cache to emacs.c and reset before dumping.
595
596 * lisp.h (reset_image_types): Declare.
597 [WINDOWSNT] (Vlibrary_cache): Declare.
598
599 * image.c (reset_image_types): New function.
600
601 * emacs.c [WINDOWSNT] (Vlibrary_cache): Move from w32.c.
602 (syms_of_emacs) [WINDOWSNT] <Vlibrary_cache>: Initialize and staticpro.
603 (Fdump_emacs): Reset Vlibrary_cache and image_types.
604
605 * w32.c (Vlibrary_cache): Do not define; moved to emacs.c
606 (globals_of_w32) <Vlibrary_cache>: Do not initialize.
607
608 * w32.h (Vlibrary_cache): Do not declare.
609
54d629be
EZ
6102012-09-25 Eli Zaretskii <eliz@gnu.org>
611
16b22fef
EZ
612 * w32proc.c (sys_signal): Handle all signals defined by the
613 MS-Windows runtime, not just SIGCHLD. Actually install the signal
614 handlers for signals supported by Windows. Don't override
615 term_ntproc as the handler for SIGABRT.
616 (sigaction): Rewrite to call sys_signal instead of duplicating its
617 code.
618 (sys_kill): Improve commentary.
619
620 * w32.c (term_ntproc): Accept (and ignore) one argument, for
621 consistency with a signature of a signal handler. All callers
622 changed.
623 (init_ntproc): Accept an argument DUMPING. If dumping, don't
624 install term_ntproc as a signal handler for SIGABRT, as that
625 should be done by the dumped Emacs.
626
627 * w32.h (init_ntproc, term_ntproc): Adjust prototypes.
628
629 * w32select.c (term_w32select): Protect against repeated
630 invocation by setting clipboard_owner to NULL after calling
631 DestroyWindow.
632
633 * emacs.c (shut_down_emacs, main): Adapt the calls to init_ntproc
634 and term_ntproc to their modified signatures.
635
54d629be
EZ
636 * character.c (char_string, string_char): Remove calls to
637 MAYBE_UNIFY_CHAR. See the discussion starting at
638 http://lists.gnu.org/archive/html/emacs-devel/2012-09/msg00433.html
639 for the details.
640
59f7af81
CY
6412012-09-25 Chong Yidong <cyd@gnu.org>
642
643 * xdisp.c (mode_line_inverse_video): Delete obsolete variable.
644
22e8cf4a
SM
6452012-09-24 Stefan Monnier <monnier@iro.umontreal.ca>
646
647 * bytecode.c (exec_byte_code): Signal an error instead of aborting,
648 when encountering an unknown bytecode.
649
578098f3
PE
6502012-09-24 Paul Eggert <eggert@cs.ucla.edu>
651
652 image.c, indent.c: Use bool for booleans.
653 * dispextern.h (struct image_type): Members valid_p, load, init
654 now return bool, not int. All uses changed.
655 * image.c: Omit unnecessary static decls.
656 (x_create_bitmap_mask, x_build_heuristic_mask):
657 Return void, not int, since callers don't care about the return value.
658 (x_create_bitmap_mask, define_image_type, valid_image_p)
659 (struct image_keyword, parse_image_spec, image_spec_value)
660 (check_image_size, image_background)
661 (image_background_transparent, x_clear_image_1)
662 (postprocess_image, lookup_image, x_check_image_size)
663 (x_create_x_image_and_pixmap, xbm_image_p)
664 (Create_Pixmap_From_Bitmap_Data, xbm_read_bitmap_data)
665 (xbm_load_image, xbm_file_p, xbm_load, xpm_lookup_color)
666 (init_xpm_functions, xpm_valid_color_symbols_p, xpm_image_p)
667 (xpm_load, xpm_load_image, lookup_rgb_color, lookup_pixel_color)
668 (x_to_xcolors, x_build_heuristic_mask, pbm_image_p, pbm_load)
669 (png_image_p, init_png_functions, png_load_body, png_load)
670 (jpeg_image_p, init_jpeg_functions, jpeg_load_body, jpeg_load)
671 (tiff_image_p, init_tiff_functions, tiff_load, gif_image_p)
672 (init_gif_functions, gif_load, imagemagick_image_p)
673 (imagemagick_load_image, imagemagick_load, svg_image_p)
674 (init_svg_functions, svg_load, svg_load_image, gs_image_p)
675 (gs_load):
676 * nsimage.m (ns_load_image):
677 * nsterm.m (ns_defined_color):
678 * xfaces.c (tty_lookup_color, tty_defined_color, defined_color):
679 * xfns.c (x_defined_color):
680 * xterm.c (x_alloc_lighter_color_for_widget)
681 (x_alloc_nearest_color_1, x_alloc_nearest_color)
682 (x_alloc_lighter_color):
683 * indent.c (disptab_matches_widthtab, current_column)
684 (scan_for_column, string_display_width, indented_beyond_p)
685 (compute_motion, vmotion, Fvertical_motion):
686 Use bool for booleans.
687
a5f2b6ec
CY
6882012-09-24 Chong Yidong <cyd@gnu.org>
689
690 * chartab.c (Fset_char_table_default): Obsolete function removed.
691
18e27ea8
PE
6922012-09-23 Paul Eggert <eggert@cs.ucla.edu>
693
afea8a8a
PE
694 Move pid_t related decls out of lisp.h.
695 * lisp.h, syswait.h (record_child_status_change, wait_for_termination)
696 (interruptible_wait_for_termination):
697 Move these decls from lisp.h to syswait.h, since they use pid_t.
698 Needed on FreeBSD; see Herbert J. Skuhra in
699 <http://lists.gnu.org/archive/html/emacs-devel/2012-09/msg00571.html>.
700 * callproc.c: Include syswait.h.
701
18e27ea8
PE
702 gnutls.c, gtkutil.c: Use bool for boolean.
703 * gnutls.c (gnutls_global_initialized, init_gnutls_functions)
704 (emacs_gnutls_handle_error):
705 * gtkutil.c (xg_check_special_colors, xg_prepare_tooltip)
706 (xg_hide_tooltip, xg_create_frame_widgets)
707 (create_dialog, xg_uses_old_file_dialog)
708 (xg_get_file_with_chooser, xg_get_file_with_selection)
709 (xg_get_file_name, xg_have_tear_offs, create_menus, xg_create_widget)
710 (xg_item_label_same_p, xg_update_menubar)
711 (xg_modify_menubar_widgets, xg_event_is_for_menubar)
712 (xg_ignore_gtk_scrollbar, xg_set_toolkit_scroll_bar_thumb)
713 (xg_event_is_for_scrollbar, xg_pack_tool_bar, xg_make_tool_item)
714 (is_box_type, xg_tool_item_stale_p, xg_update_tool_bar_sizes)
715 (update_frame_tool_bar, free_frame_tool_bar):
716 * gtkutil.c, w32term.c, xterm.c (x_wm_set_size_hint):
717 * nsmenu.m (ns_update_menubar):
718 * nsmenu.m, w32menu.c, xmenu.c (set_frame_menubar):
719 * xfns.c (Fx_show_tip) [USE_GTK]:
720 Use bool for boolean.
721 * gtkutil.c (xg_update_frame_menubar):
722 * xmenu.c (update_frame_menubar):
723 Return void, not int, since caller ignores return value.
724 * gtkutil.c (xg_change_toolbar_position):
725 Return void, not 1.
726
af0e9f75
JB
7272012-09-23 Juanma Barranquero <lekktu@gmail.com>
728
729 * makefile.w32-in (BLOCKINPUT_H): Remove.
730 (SYSSIGNAL_H): New macro.
731 ($(BLD)/alloc.$(O), $(BLD)/atimer.$(O), $(BLD)/buffer.$(O))
732 ($(BLD)/callproc.$(O), $(BLD)/data.$(O), $(BLD)/dired.$(O))
733 ($(BLD)/dispnew.$(O), $(BLD)/editfns.$(O), $(BLD)/emacs.$(O))
734 ($(BLD)/eval.$(O), $(BLD)/fileio.$(O), $(BLD)/floatfns.$(O))
735 ($(BLD)/fns.$(O), $(BLD)/fontset.$(O), $(BLD)/frame.$(O))
736 ($(BLD)/fringe.$(O), $(BLD)/image.$(O), $(BLD)/insdel.$(O))
737 ($(BLD)/keyboard.$(O), $(BLD)/keymap.$(O), $(BLD)/lread.$(O))
738 ($(BLD)/menu.$(O), $(BLD)/w32inevt.$(O), $(BLD)/w32proc.$(O))
739 ($(BLD)/print.$(O), $(BLD)/process.$(O), $(BLD)/ralloc.$(O))
740 ($(BLD)/search.$(O), $(BLD)/sound.$(O), $(BLD)/sysdep.$(O))
741 ($(BLD)/term.$(O), $(BLD)/window.$(O), $(BLD)/xdisp.$(O))
742 ($(BLD)/xfaces.$(O), $(BLD)/w32fns.$(O), $(BLD)/w32menu.$(O))
743 ($(BLD)/w32term.$(O), $(BLD)/w32select.$(O), $(BLD)/w32reg.$(O))
744 ($(BLD)/w32xfns.$(O)): Update dependencies.
745
5101529e
EZ
7462012-09-23 Eli Zaretskii <eliz@gnu.org>
747
748 * .gdbinit: Set breakpoint on terminate_due_to_signal, not on
749 fatal_error_backtrace.
750
751 * w32proc.c (sys_kill): Undo last change: don't do anything when
752 invoked to deliver SIGABRT to our own process. This is now
753 handled by emacs_raise.
754
2c3ee0ad
JB
7552012-09-23 Juanma Barranquero <lekktu@gmail.com>
756
757 * w32term.c (w32_read_socket): Remove leftover reference to
758 interrupt_input_pending.
759
62a1d661
PE
7602012-09-23 Paul Eggert <eggert@cs.ucla.edu>
761
762 Do not use SA_NODEFER.
763 Problem reported by Dani Moncayo in
764 <http://lists.gnu.org/archive/html/emacs-devel/2012-09/msg00557.html>.
765 * alloc.c (die):
766 * sysdep.c (emacs_abort): Do not reset signal handler.
767 * emacs.c (terminate_due_to_signal): Reset signal handler here.
768 * sysdep.c (init_signals): Do not use SA_NODEFER. It wasn't
769 wanted even on POSIXish hosts, and it doesn't work on Windows.
770
a0942b9a
JD
7712012-09-23 Jan Djärv <jan.h.d@swipnet.se>
772
773 * xterm.c (x_term_init): Call fixup_locale before and after calling
774 gtk_init (Bug#12392).
775
d07ff9db
CY
7762012-09-23 Chong Yidong <cyd@gnu.org>
777
778 * w32.c (w32_delayed_load): Remove LIBRARIES argument; always use
779 Vdynamic_library_alist.
780
781 * gnutls.c (init_gnutls_functions): Caller changed; remove arg.
782 (Fgnutls_available_p): Caller changed.
783
784 * xml.c (init_libxml2_functions, Flibxml_parse_html_region)
785 (Flibxml_parse_xml_region): Likewise.
786
787 * dispextern.h (struct image_type): Remove arg from init function.
788
789 * image.c (Finit_image_library, lookup_image_type)
790 (define_image_type): Remove now-unneeded second arg.
791 (init_xpm_functions, init_png_functions, init_jpeg_functions)
792 (init_tiff_functions, init_gif_functions, init_svg_functions):
793 Arglist and w32_delayed_load calling convention changed.
794 (gs_type): Remove init_gs_functions; there is no such function.
641cfd14 795 (valid_image_p, make_image): Fix caller to lookup_image_type.
d07ff9db 796
4d7e6e51
PE
7972012-09-23 Paul Eggert <eggert@cs.ucla.edu>
798
799 Simplify and avoid signal-handling races (Bug#12471).
800 * alloc.c (die):
801 * sysdep.c (emacs_abort) [HAVE_NTGUI]:
802 Avoid recursive loop if there's a fatal error in the function itself.
803 * atimer.c (pending_atimers):
804 * blockinput.h: Don't include "atimer.h"; no longer needed.
805 (interrupt_input_pending): Remove. All uses removed.
806 pending_signals now counts both atimers and ordinary interrupts.
807 This is less racy than having three separate pending-signal flags.
808 (block_input, unblock_input, totally_unblock_input, unblock_input_to)
809 (input_blocked_p):
810 Rename from their upper-case counterparts BLOCK_INPUT,
811 UNBLOCK_INPUT, TOTALLY_UNBLOCK_INPUT, UNBLOCK_INPUT_TO,
812 INPUT_BLOCKED_P, and turn into functions. All uses changed.
813 This makes it easier to access volatile variables more accurately.
814 (BLOCK_INPUT_RESIGNAL): Remove. All uses replaced by unblock_input ().
815 (input_blocked_p): Prefer this to 'interrupt_input_blocked', as
816 that's more reliable if the code is buggy and sets
817 interrupt_input_blocked to a negative value. All uses changed.
818 * atimer.c (deliver_alarm_signal):
819 Remove. No need to deliver this to the parent; any thread can
820 handle this signal now. All uses replaced by underlying handler.
821 * atimer.c (turn_on_atimers):
822 * dispnew.c (handle_window_change_signal):
823 * emacs.c (handle_danger_signal):
824 * keyboard.c (kbd_buffer_get_event):
825 Don't reestablish signal handler; not needed with sigaction.
826 * blockinput.h (UNBLOCK_INPUT_TO, TOTALLY_UNBLOCK_INPUT)
827 (UNBLOCK_INPUT_TO):
828 Rework to avoid unnecessary accesses to volatile variables.
829 (UNBLOCK_INPUT_TO): Now a function.
830 (totally_unblock_input, unblock_input): New decls.
831 * data.c (handle_arith_signal, deliver_arith_signal): Move to sysdep.c
832 (init_data): Remove. Necessary stuff now done in init_signal.
833 * emacs.c, xdisp.c: Include "atimer.h", since we invoke atimer functions.
834 * emacs.c (handle_fatal_signal, deliver_fatal_signal): Move to sysdep.c.
835 (fatal_error_code): Remove; no longer needed.
836 (terminate_due_to_signal): Rename from fatal_error_backtrace, since
837 it doesn't always backtrace. All uses changed. No need to reset
838 signal to default, since sigaction and/or die does that for us now.
839 Use emacs_raise (FOO), not kill (getpid (), FOO).
840 (main): Check more-accurately whether we're dumping.
841 Move fatal-error setup to sysdep.c
842 * floatfns.c: Do not include "syssignal.h"; no longer needed.
843 * gtkutil.c (xg_get_file_name, xg_get_font):
844 Remove no-longer-needed signal-mask manipulation.
845 * keyboard.c, process.c (POLL_FOR_INPUT):
846 Don't depend on USE_ASYNC_EVENTS, a symbol that is never defined.
847 * keyboard.c (read_avail_input): Remove.
848 All uses replaced by gobble_input.
849 (Ftop_level): Use TOTALLY_UNBLOCK_INPUT rather than open code.
850 (kbd_buffer_store_event_hold, gobble_input):
851 (record_asynch_buffer_change) [USABLE_SIGIO]:
852 (store_user_signal_events):
853 No need to mess with signal mask.
854 (gobble_input): If blocking input and there are terminals, simply
855 set pending_signals to 1 and return. All hooks changed to not
856 worry about whether input is blocked.
857 (process_pending_signals): Clear pending_signals before processing
858 them, in case a signal comes in while we're processing.
859 By convention callers now test pending_signals before calling us.
860 (UNBLOCK_INPUT_TO, unblock_input, totally_unblock_input):
861 New functions, to support changes to blockinput.h.
862 (handle_input_available_signal): Now extern.
863 (reinvoke_input_signal): Remove. All uses replaced by
864 handle_async_input.
865 (quit_count): Now volatile, since a signal handler uses it.
3a880af4
SM
866 (handle_interrupt): Now takes bool IN_SIGNAL_HANDLER as arg.
867 All callers changed. Block SIGINT only if not already blocked.
4d7e6e51
PE
868 Clear sigmask reliably, even if Fsignal returns, which it can.
869 Omit unnecessary accesses to volatile var.
870 (quit_throw_to_read_char): No need to restore sigmask.
871 * keyboard.c (gobble_input, handle_user_signal):
872 * process.c (wait_reading_process_output):
873 Call signal-handling code rather than killing ourselves.
874 * lisp.h: Include <float.h>, for...
875 (IEEE_FLOATING_POINT): New macro, moved here to avoid duplication.
876 (pending_signals): Now volatile.
877 (syms_of_data): Now const if IEEE floating point.
878 (handle_input_available_signal) [USABLE_SIGIO]:
879 (terminate_due_to_signal, record_child_status_change): New decls.
880 * process.c (create_process): Avoid disaster if memory is exhausted
881 while we're processing a vfork, by tightening the critical section
882 around the vfork.
883 (send_process_frame, process_sent_to, handle_pipe_signal)
884 (deliver_pipe_signal): Remove. No longer needed, as Emacs now
885 ignores SIGPIPE.
886 (send_process): No need for setjmp/longjmp any more, since the
887 SIGPIPE stuff is now gone. Instead, report an error if errno
888 is EPIPE.
889 (record_child_status_change): Now extern. PID and W are now args.
890 Return void, not bool. All callers changed.
891 * sysdep.c (wait_debugging) [(BSD_SYSTEM || HPUX) && !defined (__GNU__)]:
892 Remove. All uses removed. This bug should be fixed now in a
893 different way.
894 (wait_for_termination_1): Use waitpid rather than sigsuspend,
895 and record the child status change directly. This avoids the
896 need to futz with the signal mask.
897 (process_fatal_action): Move here from emacs.c.
898 (emacs_sigaction_flags): New function, containing
899 much of what used to be in emacs_sigaction_init.
900 (emacs_sigaction_init): Use it. Block nonfatal system signals that are
901 caught by emacs, to make races less likely.
902 (deliver_process_signal): Rename from handle_on_main_thread.
903 All uses changed.
904 (BACKTRACE_LIMIT_MAX): Now at top level.
905 (thread_backtrace_buffer, threadback_backtrace_pointers):
906 New static vars.
907 (deliver_thread_signal, deliver_fatal_thread_signal):
908 New functions, for more-accurate delivery of thread-specific signals.
909 (handle_fatal_signal, deliver_fatal_signal): Move here from emacs.c.
910 (deliver_arith_signal): Handle in this thread, not
911 in the main thread, since it's triggered by this thread.
912 (maybe_fatal_sig): New function.
913 (init_signals): New arg DUMPING so that we can be more accurate
914 about whether we're dumping. Caller changed.
915 Treat thread-specific signals differently from process-general signals.
916 Block all signals while handling fatal error; that's safer.
917 xsignal from SIGFPE only on non-IEEE hosts, treating it as fatal
918 on IEEE hosts.
919 When batch, ignore SIGHUP, SIGINT, SIGTERM if they were already ignored.
920 Ignore SIGPIPE unless batch.
921 (emacs_backtrace): Output backtrace for the appropriate thread,
922 which is not necessarily the main thread.
923 * syssignal.h: Include <stdbool.h>.
924 (emacs_raise): New macro.
925 * xterm.c (x_connection_signal): Remove; no longer needed
926 now that we use sigaction.
927 (x_connection_closed): No need to mess with sigmask now.
928 (x_initialize): No need to reset SIGPIPE handler here, since
929 init_signals does this for us now.
930
8f4635e9
JD
9312012-09-23 Jan Djärv <jan.h.d@swipnet.se>
932
933 * nsterm.m (ns_dumpglyphs_image): dr is a new rect to draw image into,
fb39b937 934 background rect may be larger (Bug#12245).
8f4635e9 935
3296976d
CY
9362012-09-23 Chong Yidong <cyd@gnu.org>
937
938 * keyboard.c (timer_check): Avoid quitting during Fcopy_sequence.
939
d41e491e
PE
9402012-09-22 Paul Eggert <eggert@cs.ucla.edu>
941
942 * .gdbinit: Just stop at fatal_error_backtrace.
943 See Stefan Monnier's request in
944 <http://lists.gnu.org/archive/html/emacs-devel/2012-09/msg00549.html>.
945 Remove no-longer-used query of system type.
946
c88b867f
CY
9472012-09-22 Chong Yidong <cyd@gnu.org>
948
949 * search.c (Freplace_match): Doc fix (Bug#12325).
950
951 * minibuf.c (Finternal_complete_buffer): Doc fix (Bug#12391).
952
953 * editfns.c (Fline_beginning_position): Doc fix (Bug#12416).
954 (Fline_end_position): Doc fix.
955
956 * cmds.c (Fforward_char, Fbackward_char): Doc fix (Bug#12414).
957
bb4d86b4
CY
9582012-09-22 Chong Yidong <cyd@gnu.org>
959
960 * dispextern.h (struct image_type): Add new slot, storing a type
961 initialization function.
962
963 * image.c (define_image_type): Call the image initializer function
964 if it is defined. Arguments and return value changed.
965 (valid_image_p, make_image): Callers changed.
966 (xbm_type, xpm_type, pbm_type, png_type, jpeg_type, tiff_type)
3a880af4
SM
967 (gif_type, imagemagick_type, svg_type, gs_type):
968 Add initialization functions.
bb4d86b4
CY
969 (Finit_image_library): Call lookup_image_type.
970 (CHECK_LIB_AVAILABLE): Macro deleted.
971 (lookup_image_type): Call define_image_type here, rather than via
972 Finit_image_library, and without using CHECK_LIB_AVAILABLE.
973 (syms_of_image): Move define_image_type calls for xbm_type and
974 pbm_type to lookup_image_type.
975
df9685f3
EZ
9762012-09-22 Eli Zaretskii <eliz@gnu.org>
977
978 * keyboard.c (timer_check_2): Move calculation of 'timers' and
979 'idle_timers' from here ...
980 (timer_check): ... to here. Use Fcopy_sequence to copy the timer
981 lists, to avoid infloops when the timer does something stupid,
982 like reinvoke itself with the same or smaller time-out.
983 (Bug#12447)
984
8e17c9ba
MR
9852012-09-22 Martin Rudalics <rudalics@gmx.at>
986
987 * window.c (Fsplit_window_internal): Handle only Qt value of
988 Vwindow_combination_limit separately.
989 (Qtemp_buffer_resize): New symbol.
3a880af4
SM
990 (Vwindow_combination_limit): New default value.
991 Rewrite doc-string.
8e17c9ba 992
589bd69b
EZ
9932012-09-22 Eli Zaretskii <eliz@gnu.org>
994
995 * xdisp.c (next_overlay_string): Initialize it->end_charpos for
996 the new overlay string. (Bug#10159)
997
01108e3f
PE
9982012-09-22 Paul Eggert <eggert@cs.ucla.edu>
999
1000 * emacs.c (shut_down_emacs): Don't assume stderr is buffered,
1001 or that fprintf is async-signal-safe. POSIX doesn't require
1002 either assumption.
1003
82f8cd94
CY
10042012-09-22 Chong Yidong <cyd@gnu.org>
1005
1006 * buffer.c (Fset_buffer_modified_p): Handle indirect buffers
1007 (Bug#8207).
1008
3cccbd87
KH
10092012-09-22 Kenichi Handa <handa@gnu.org>
1010
1011 * composite.c (composition_reseat_it): Handle the case that a
1012 grapheme cluster is not covered by a single font (Bug#12352).
1013
09c01941
CY
10142012-09-21 Chong Yidong <cyd@gnu.org>
1015
1016 * image.c (define_image_type): Avoid adding duplicate types to
1017 image_types (Bug#12463). Suggested by Jörg Walter.
1018
acfa068f 10192012-09-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
e25c1a30
YM
1020
1021 * unexmacosx.c: Define LC_DATA_IN_CODE if not defined.
1022 (print_load_command_name): Add case LC_DATA_IN_CODE.
1023 (dump_it) [LC_DATA_IN_CODE]: Call copy_linkedit_data.
1024
acfa068f 10252012-09-21 Glenn Morris <rgm@gnu.org>
1e9bbf47
GM
1026
1027 * eval.c (Frun_hook_with_args_until_success)
1028 (Frun_hook_with_args_until_failure): Doc fixes. (Bug#12393)
1029
acfa068f 10302012-09-21 Andreas Schwab <schwab@linux-m68k.org>
c6ba4138
AS
1031
1032 * fileio.c (Ffile_selinux_context): Only call freecon when
1033 lgetfilecon succeeded.
1034 (Fset_file_selinux_context): Likewise. (Bug#12444)
1035
acfa068f 10362012-09-21 Eli Zaretskii <eliz@gnu.org>
aa36e4d2
EZ
1037
1038 * xdisp.c (try_window_reusing_current_matrix): Under bidi
1039 reordering, locate the cursor by calling set_cursor_from_row; if
1040 that fails, clear the desired glyph matrix before returning a
1041 failure indication to the caller. Fixes leaving garbled display
1042 when fast scrolling with a down-key. (Bug#12403)
f2016bea
EZ
1043 (compute_stop_pos_backwards): Fix a typo that caused crashes while
1044 scrolling through multibyte text.
aa36e4d2 1045
e99f70c8
SM
10462012-09-20 Stefan Monnier <monnier@iro.umontreal.ca>
1047
1048 * alloc.c (mark_object) <PVEC_WINDOW>: Mark prev/next_buffers *after*
1049 calling mark_vectorlike since that's the one that marks the window.
1050 (mark_discard_killed_buffers): Mark the final cdr.
1051 * window.h (struct window): Move prev/next_buffers to the
1052 non-standard fields.
1053 * window.c (make_window): Initialize prev/next_buffers manually.
1054
f75beb47
PE
10552012-09-20 Paul Eggert <eggert@cs.ucla.edu>
1056
1057 Omit unused arg EXPECTED from socket hooks.
1058 * keyboard.c (gobble_input, read_avail_input, tty_read_avail_input):
1059 * nsterm.m (ns_term_init):
1060 * termhooks.h (struct terminal.read_socket_hook):
1061 * w32inevt.c (w32_console_read_socket):
1062 * w32term.c (w32_read_socket):
1063 * xterm.c (XTread_socket):
1064 Omit unused arg EXPECTED. All callers changed.
1065 (store_user_signal_events): Return void, not int, since callers no
1066 longer care about the return value. All uses changed.
1067
b019b76a
JB
10682012-09-20 Juanma Barranquero <lekktu@gmail.com>
1069
1070 * w32gui.h (XParseGeometry): Do not declare.
1071
05642592
PE
10722012-09-19 Paul Eggert <eggert@cs.ucla.edu>
1073
e4bce92a
PE
1074 * w32inevt.c (w32_console_read_socket): Return -1 on failure, not 0.
1075 Ignore 'expected'. See Eli Zaretskii in
1076 <http://bugs.gnu.org/12471#8> (last line).
1077
05642592
PE
1078 * frame.c (read_integer): Remove. All uses replaced by strtol/strtoul.
1079 (XParseGeometry): Now static. Substitute extremal values for
1080 values that are out of range.
1081
e543ae91
JD
10822012-09-19 Jan Djärv <jan.h.d@swipnet.se>
1083
1084 * w32xfns.c (read_integer, XParseGeometry): Move to frame.c.
1085
1086 * nsfns.m (XParseGeometry): Remove.
1087 (Fx_create_frame): Call x_set_offset to correctly interpret
1088 top_pos in geometry.
1089
3a880af4 1090 * frame.c (read_integer, XParseGeometry): Move from w32xfns.c.
e543ae91
JD
1091 (Fx_parse_geometry): If there is a space in string, call
1092 Qns_parse_geometry, otherwise do as on other terms (Bug#12368).
1093
45ba16c7
EZ
10942012-09-17 Eli Zaretskii <eliz@gnu.org>
1095
c8b9f1bc
EZ
1096 * search.c (scan_buffer): Use character positions in calls to
1097 region_cache_forward and region_cache_backward, not byte
1098 positions. (Bug#12196)
1099
b4c932a2
EZ
1100 * w32term.c (w32_read_socket): Set pending_signals to 1, like
1101 xterm.c does. Reported by Daniel Colascione <dancol@dancol.org>.
1102
45ba16c7
EZ
1103 * ralloc.c (r_alloc_init) [!SYSTEM_MALLOC]: Initialize
1104 __malloc_extra_blocks to 32 instead of 64, like alloc.c did in
1105 emacs_blocked_malloc, now deleted.
1106
eeceac93
PE
11072012-09-17 Paul Eggert <eggert@cs.ucla.edu>
1108
1109 Remove no-longer-needed Solaris 2.4 vfork bug workaround.
1110 The workaround was for improving performance on Solaris 2.4, but
1111 is getting in the way now. Emacs will still work if someone is
1112 still running Solaris 2.4 in a museum somewhere; Sun dropped
1113 support for Solaris 2.4 in 2003.
1114 * callproc.c (Fcall_process) [HAVE_WORKING_VFORK]:
1115 * process.c (create_process) [HAVE_WORKING_VFORK]:
1116 Omit now-unnecessary workaround for the Solaris 2.4 vfork bug,
1117 since Emacs no longer uses vfork on that platform.
1118
78f83752
GM
11192012-09-17 Glenn Morris <rgm@gnu.org>
1120
1121 * emacs.c: Use COPYRIGHT.
1122
634b8cac
PE
11232012-09-16 Paul Eggert <eggert@cs.ucla.edu>
1124
0caaedb1
PE
1125 Remove configure's --without-sync-input option (Bug#12450).
1126 When auditing signal-handling in preparation for cleaning it up,
1127 I found that SYNC_INPUT has race conditions and would be a real
1128 pain to fix. Since it's an undocumented and deprecated
1129 configure-time option, now seems like a good time to remove it.
1130 Also see <http://bugs.gnu.org/11080#16>.
1131 * alloc.c (_bytes_used, __malloc_extra_blocks, _malloc_internal)
1132 (_free_internal) [!DOUG_LEA_MALLOC]: Remove decls.
1133 (alloc_mutex) [!SYSTEM_MALLOC && !SYNC_INPUT && HAVE_PTHREAD]:
1134 (malloc_hysteresis):
1135 (check_depth) [XMALLOC_OVERRUN_CHECK]:
1136 (MALLOC_BLOCK_INPUT, MALLOC_UNBLOCK_INPUT):
1137 (__malloc_hook, __realloc_hook, __free_hook, BYTES_USED)
1138 (dont_register_blocks, bytes_used_when_reconsidered)
1139 (bytes_used_when_full, emacs_blocked_free, emacs_blocked_malloc)
1140 (emacs_blocked_realloc, reset_malloc_hooks, uninterrupt_malloc):
1141 [!SYSTEM_MALLOC && !SYNC_INPUT]:
1142 Remove. All uses removed.
1143 (MALLOC_BLOCK_INPUT, MALLOC_UNBLOCK_INPUT): Use a different
1144 implementation, one that depends on whether the new macro
1145 XMALLOC_BLOCK_INPUT_CHECK is defined, not on whether SYNC_INPUT
1146 is defined.
1147 * atimer.c (run_timers, handle_alarm_signal):
1148 * keyboard.c (pending_signal, poll_for_input_1, poll_for_input)
1149 (handle_async_input, process_pending_signals)
1150 (handle_input_available_signal, init_keyboard):
1151 * nsterm.m (ns_read_socket):
1152 * process.c (wait_reading_process_output):
1153 * regex.c (immediate_quit, IMMEDIATE_QUIT_CHECK):
1154 * sysdep.c (emacs_sigaction_init) [SA_RESTART]:
1155 (emacs_write):
1156 * xterm.c (XTread_socket):
1157 Assume SYNC_INPUT.
1158 * conf_post.h (SA_RESTART) [IRIX6_5]: Do not #undef.
1159 * eval.c (handling_signal): Remove. All uses removed.
1160 * lisp.h (ELSE_PENDING_SIGNALS): Remove.
1161 All uses replaced with the SYNC_INPUT version.
1162 (reset_malloc_hooks, uninterrupt_malloc, handling_signal):
1163 Remove decls.
1164 * sysdep.c, syssignal.h (main_thread) [FORWARD_SIGNAL_TO_MAIN_THREAD]:
1165 Now static.
1166
634b8cac
PE
1167 * font.c (Ffont_shape_gstring): Remove unused local.
1168
83da1b55
GM
11692012-09-16 Glenn Morris <rgm@gnu.org>
1170
518650a5
GM
1171 * Makefile.in (clean): No longer run nextstep's clean.
1172
83da1b55
GM
1173 * Makefile.in (ns_appdir, ns_appbindir, ns_appsrc): Remove variables.
1174 (ns_frag): Remove.
1175 (ns-app): Move here from ns.mk, and simplify.
1176 (clean): Simplify nextstep entry.
1177 * ns.mk: Remove file.
1178
85a43e2e
KH
11792012-09-17 Kenichi Handa <handa@gnu.org>
1180
1181 * font.c (Ffont_shape_gstring): Fix previous change; GLYPHs may
1182 not covert the last few charactes.
1183
ba13e616 11842012-09-16 Kenichi Handa <handa@gnu.org>
ea964864
KH
1185
1186 * font.c (Ffont_shape_gstring): Don't adjust grapheme cluster
1187 here, but just check the validity of glyphs in the glyph-string.
1188
a8c729af
MR
11892012-09-16 Martin Rudalics <rudalics@gmx.at>
1190
3a880af4
SM
1191 * window.c (Fwindow_parameter, Fset_window_parameter):
1192 Accept any window as argument (Bug#12452).
a8c729af 1193
c077c059
JD
11942012-09-16 Jan Djärv <jan.h.d@swipnet.se>
1195
1196 * nsfns.m (Fx_open_connection): Move initialization of ns_*_types
1197 to ns_term_init to avoid memory leak.
1198
1199 * nsterm.m (ns_update_begin): Initialize bp after lcokFocus, use
1200 explicit retain/release.
1201 (ns_term_init): Only allow one display. Initialize outerpool and
1202 ns_*_types.
1203
39a57ad0
PE
12042012-09-15 Paul Eggert <eggert@cs.ucla.edu>
1205
1206 Port _setjmp fix to POSIXish hosts as well as Microsoft.
1207 * image.c (_setjmp) [!HAVE__SETJMP]: Restore definition, as
1208 it's needed on POSIXish hosts that lack _setjmp. Attempt to solve
1209 the Microsoft problem in a different way, by altering ../nt/config.nt.
1210
7105c8cb
EZ
12112012-09-15 Eli Zaretskii <eliz@gnu.org>
1212
1213 * w32xfns.c:
1214 * w32uniscribe.c:
1215 * w32term.c:
1216 * w32select.c:
1217 * w32reg.c:
1218 * w32proc.c:
1219 * w32menu.c:
1220 * w32inevt.c:
1221 * w32heap.c:
1222 * w32font.c:
1223 * w32fns.c:
1224 * w32console.c:
1225 * w32.c:
1226 * w16select.c: Remove inclusion of setjmp.h, as it is now included
1227 by lisp.h. This completes removal of setjmp.h inclusion
1228 erroneously announced in the previous commit. (Bug#12446)
1229
1230 * lisp.h [!HAVE__SETJMP, !HAVE_SIGSETJMP]: Make the commentary
1231 more accurate.
1232
1233 * image.c (_setjmp) [!HAVE__SETJMP]: Define only if 'setjmp' is
1234 not defined as a macro. The latter happens on MS-Windows.
1235 (Bug#12446)
1236
0328b6de
PE
12372012-09-15 Paul Eggert <eggert@cs.ucla.edu>
1238
1239 Port better to POSIX hosts lacking _setjmp (Bug#12446).
1240 * lisp.h: Include <setjmp.h> here, since we use its symbols here.
7105c8cb 1241 Some instances of '#include <setjmp.h>' removed, if the
0328b6de
PE
1242 only reason for the instance was because "lisp.h" was included.
1243 (sys_jmp_buf, sys_setjmp, sys_longjmp): New symbols.
1244 Unless otherwise specified, replace all uses of jmp_buf, _setjmp,
1245 and _longjmp with the new symbols. Emacs already uses _setjmp if
1246 available, so this change affects only POSIXish hosts that have
1247 sigsetjmp but not _setjmp, such as some versions of Solaris and
1248 Unixware. (Also, POSIX-2008 marks _setjmp as obsolescent.)
1249 * image.c (_setjmp, _longjmp) [HAVE_PNG && !HAVE__SETJMP]: New macros.
1250 (png_load_body) [HAVE_PNG]:
1251 (PNG_LONGJMP) [HAVE_PNG && PNG_LIBPNG_VER < 10500]:
1252 (PNG_JMPBUF) [HAVE_PNG && PNG_LIBPNG_VER >= 10500]:
1253 Use _setjmp and _longjmp rather than sys_setjmp and sys_longjmp,
1254 since PNG requires jmp_buf. This is the only exception to the
1255 general rule that we now use sys_setjmp and sys_longjmp.
1256 This exception is OK since this code does not change the signal
1257 mask or longjmp out of a signal handler.
1258
2af03429
PE
12592012-09-14 Paul Eggert <eggert@cs.ucla.edu>
1260
1261 * alloc.c [!SYSTEM_MALLOC && !SYNC_INPUT && HAVE_PTHREAD]:
1262 Include "syssignal.h", for 'main_thread'.
1263
2f294edf
DA
12642012-09-14 Dmitry Antipov <dmantipov@yandex.ru>
1265
1266 Avoid out-of-range marker position (Bug#12426).
3a880af4
SM
1267 * insdel.c (replace_range, replace_range_2):
1268 Adjust markers before overlays, as suggested by comments.
2f294edf
DA
1269 (insert_1_both, insert_from_buffer_1, adjust_after_replace):
1270 Remove redundant check before calling offset_intervals.
1271
6b533e9c
MR
12722012-09-14 Martin Rudalics <rudalics@gmx.at>
1273
1274 * xdisp.c (Fformat_mode_line): Unconditionally save/restore
1275 current buffer (Bug#12387).
1276
2a7931e3
JB
12772012-09-14 Juanma Barranquero <lekktu@gmail.com>
1278
1279 * makefile.w32-in ($(BLD)/alloc.$(O)): Update dependencies.
1280
c18e885b
PE
12812012-09-13 Paul Eggert <eggert@cs.ucla.edu>
1282
1283 Use a more backwards-compatible timer format (Bug#12430).
1284 * keyboard.c (decode_timer): Get PSECS from the 8th (origin-0)
1285 vector element, not from the 4th, since PSECS is now at the end.
1286 (Fcurrent_idle_time): Doc fix.
1287
d59a1afb
DA
12882012-09-13 Dmitry Antipov <dmantipov@yandex.ru>
1289
1290 Function to mark objects and remove killed buffers at once.
1291 * alloc.c (discard_killed_buffers): Rename to ...
1292 (mark_discard_killed buffers) ... new name. Add marking
1293 of remaining objects. Fix comment. Adjust users.
1294 (mark_object): Do not touch frame buffer lists here.
1295 * frame.c (delete_frame): Reset frame buffer lists here.
1296
5f0cb45a
PE
12972012-09-13 Paul Eggert <eggert@cs.ucla.edu>
1298
8ea47e3a
PE
1299 Better workaround for GNOME bug when --enable-gcc-warnings.
1300 * emacsgtkfixed.c (G_STATIC_ASSERT): Remove, undoing last change.
1301 Instead, disable -Wunused-local-typedefs. See Dmitry Antipov in
1302 <http://lists.gnu.org/archive/html/emacs-devel/2012-09/msg00335.html>.
1303
4a4bbad2
PE
1304 Simplify SIGIO usage (Bug#12408).
1305 The code that dealt with SIGIO was crufty and confusing, e.g., it
1306 played tricks like "#undef SIGIO" but these tricks were not used
1307 consistently. Simplify mostly by not #undeffing standard symbols,
1308 e.g., use "defined USABLE_SIGIO" (our symbol, which we can define
1309 or not as we please) rather than "defined SIGIO" (standard symbol
1310 that we probably shouldn't #undef).
1311 * conf_post.h [USG5_4]: Do not include <sys/wait.h> here.
1312 Modules that need it can include it.
1313 [USG5_4 && emacs]: Likewise, do not include the streams stuff here.
1314 * dispextern.h (ignore_sigio): New decl.
1315 * emacs.c (shut_down_emacs): Invoke unrequest_sigio
1316 unconditionally, since it's now a no-op if !USABLE_SIGIO.
1317 * emacs.c (shut_down_emacs):
1318 * keyboard.c (kbd_buffer_store_event_hold):
1319 Use ignore_sigio rather than invoking 'signal' directly.
1320 * keyboard.c (USABLE_FIONREAD && USG5_4): Include <sys/filio.h>,
1321 for FIONREAD.
1322 (FIONREAD, SIGIO): Do not #undef.
1323 (tty_read_avail_input): Use #error rather than a syntax error.
1324 * process.c [USG5_4]: Include <sys/stream.h> and <sys/stropts.h>,
1325 for I_PIPE, used by SETUP_SLAVE_PTY.
1326 (DATAGRAM_SOCKETS): Simplify defn, based on USABLE_FIONREAD.
1327 * sysdep.c (croak): Remove; no longer needed. This bit of
1328 temporary code, with Fred N. Fish's comment that it's temporary,
1329 has been in Emacs since at least 1992!
1330 (init_sigio, reset_sigio, request_sigio, unrequest_sigio):
1331 Arrange for them to be no-ops in all cases when ! USABLE_SIGIO.
1332 * syssignal.h (croak): Remove decl.
1333 (SIGIO, SIGPOO, SIGAIO, SIGPTY): Do not #undef; that's too fragile.
1334 * systty.h [!NO_TERMIO]: Do not include <termio.h>; no longer needed
1335 now that we're termios-only.
1336 (FIONREAD, ASYNC) [BROKEN_FIONREAD]: Do not #undef.
1337 * term.c (dissociate_if_controlling_tty): Use #error rather than
1338 a run-time error.
1339
5f0cb45a
PE
1340 Work around GCC and GNOME bugs when --enable-gcc-warnings.
1341 * emacsgtkfixed.c (G_STATIC_ASSERT): Redefine to use 'verify',
1342 to work around GNOME bug 683906.
1343 * image.c (jpeg_load_body) [HAVE_JPEG && lint]: Pacify gcc -Wclobber.
1344 (struct my_jpeg_error_mgr) [HAVE_JPEG && lint]: New member fp.
1345 This works around GCC bug 54561.
1346
40bce90b
PE
13472012-09-12 Paul Eggert <eggert@cs.ucla.edu>
1348
1349 More fixes for 'volatile' and setjmp/longjmp.
1350 * eval.c (Fdefvar, Fcondition_case): Remove unnecessary 'volatile's.
1351 * image.c (struct png_load_context) [HAVE_PNG]: New type.
1352 (png_load_body) [HAVE_PNG]:
1353 (jpeg_load_body) [HAVE_JPEG]:
1354 New function, with most of the old parent function's body.
1355 (png_load) [HAVE_PNG]:
1356 (jpeg_load) [HAVE_JPEG]:
1357 Invoke the new function, to avoid longjmp munging our locals.
1358 (struct my_jpeg_error_mgr) [HAVE_JPEG]: New members cinfo, failure_code.
1359 (my_error_exit) [HAVE_JPEG]: Don't trust 'setjmp' to return 2 when
1360 longjmp is passed 2, as the C standard doesn't guarantee this.
1361 Instead, store the failure code into mgr->failure_code.
1362
bfeae2cf
SM
13632012-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1364
1365 * keyboard.c (read_char, requeued_events_pending_p, Finput_pending_p)
1366 (Fdiscard_input, quit_throw_to_read_char, init_keyboard)
1367 (syms_of_keyboard): Remove support for unread-command-char.
1368
8099e36b
EZ
13692012-09-12 Eli Zaretskii <eliz@gnu.org>
1370
1371 * w32proc.c (sys_kill): If PID is our process ID and the signal is
1372 SIGABRT, call emacs_abort. Avoids silently exiting upon assertion
1373 violation. (Bug#12426)
1374
92547ff9
PE
13752012-09-12 Paul Eggert <eggert@cs.ucla.edu>
1376
1377 * image.c (jpeg_memory_src): Don't assume string len fits in unsigned.
1378
45b82ad0
SM
13792012-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1380
1381 * eval.c: Add `inhibit-debugger'.
1382 (Qinhibit_debugger): New symbol.
1383 (call_debugger): Bind it instead of Qdebug_on_error.
1384 (maybe_call_debugger): Test Vinhibit_debugger.
1385 (syms_of_eval): Define inhibit-debugger.
1386 * xdisp.c (set_message): Don't bind Qinhibit_debug_on_message.
1387 (syms_of_xdisp): Remove inhibit-debug-on-message.
1388
5779a1dc
PE
13892012-09-11 Paul Eggert <eggert@cs.ucla.edu>
1390
50f2e553
PE
1391 Avoid _setjmp/_longjmp problems with local nonvolatile variables.
1392 If a nonvolatile local variable is written before a _longjmp to
1393 the frame containing the variable, and is read after the _longjmp,
1394 the value read is indeterminate. Some local variables of type
1395 'struct handler' and 'struct catchtag' are used in this way, so
1396 mark each of their slots as volatile if the slot can be set before
1397 _longjmp and read afterwards.
1398 * lisp.h (struct handler): var and chosen_clause are now volatile.
1399 (struct catchtag): val, next, and pdlcount are now volatile.
1400
ae1d87e2
PE
1401 * bidi.c (bidi_push_it, bidi_pop_it):
1402 * fns.c (copy_hash_table):
1403 * image.c (define_image_type):
1404 * keyboard.c (kbd_buffer_store_event_hold):
1405 * process.c (Fprocess_send_eof):
1406 * xfaces.c (x_create_gc) [HAVE_NS]:
1407 * xgselect.c (xg_select):
1408 Prefer assignment to memcpy when either will do.
1409
5779a1dc
PE
1410 * alloc.c (discard_killed_buffers): Tune and simplify a bit.
1411 Use pointer-to-a-pointer to simplify and avoid a NILP check each
1412 time an item is removed. No need to mark this function 'inline';
1413 the compiler knows better than we do.
1414
c4c9756b
JD
14152012-09-11 Jan Djärv <jan.h.d@swipnet.se>
1416
1417 * nsterm.m (ns_judge_scroll_bars): Pass NO to updateFrameSize.
1418 (updateFrameSize:): Add delay parameter to updateFrameSize, send it
1419 to change_frame_size (Bug#12388).
1420 (windowDidResize:): Pass YES to updateFrameSize.
1421
1422 * nsterm.h: Add delay parameter to updateFrameSize.
1423
d73e321c
DA
14242012-09-11 Dmitry Antipov <dmantipov@yandex.ru>
1425
1426 Discard killed buffers from deleted window and frame objects.
1427 This reduces an amount of references to killed buffers and
1428 helps GC to reclaim them faster.
1429 * alloc.c (discard_killed_buffers): New function.
1430 (mark_object): Use it for deleted windows and frames.
1431 (mark_object): If symbol's value is set up for a killed buffer
1432 or deleted frame, restore it's global binding.
1433 * data.c (swap_in_global_binding): Add GC notice.
1434 (swap_in_symval_forwarding): Use convenient set_blv_where.
1435 * window.c (wset_next_buffers, wset_prev_buffers): Move ...
1436 * window.h: ... to here.
1437
e578f381
DA
14382012-09-11 Dmitry Antipov <dmantipov@yandex.ru>
1439
1440 Convenient macro to check whether the buffer is live.
1441 * buffer.h (BUFFER_LIVE_P): New macro.
1442 * alloc.c, buffer.c, editfns.c, insdel.c, lread.c, marker.c:
1443 * minibuf.c, print.c, process.c, window.c, xdisp.c: Use it.
1444
3057e615
YM
14452012-09-11 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1446
1447 * xdisp.c (right_overwritten, right_overwriting): Also handle gstring
1448 composition cases (Bug#12364).
1449
1450 * xterm.c (x_draw_glyph_string): Avoid overwriting inverted left
1451 overhang of succeeding glyphs overlapping box cursor.
1452
1453 * w32term.c (x_draw_glyph_string): Likewise.
1454
6fda35f2
PE
14552012-09-11 Paul Eggert <eggert@cs.ucla.edu>
1456
c990426a
PE
1457 Simplify, document, and port floating-point (Bug#12381).
1458 The porting part of this patch fixes bugs on non-IEEE platforms
1459 with frexp, ldexp, logb.
1460 * data.c, lisp.h (Qdomain_error, Qsingularity_error, Qunderflow_error):
1461 Now static.
1462 * floatfns.c: Simplify discussion of functions that Emacs doesn't
1463 support, by removing commented-out code and briefly listing the
1464 C89 functions excluded. The commented-out stuff was confusing
1465 maintenance, e.g., we thought we needed cbrt but it was commented out.
1466 (logb): Remove decl; no longer needed.
1467 (isfinite): New macro, if not already supplied.
1468 (isnan): Don't replace any existing macro.
1469 (Ffrexp, Fldexp): Define even if !HAVE_COPYSIGN, as frexp and ldexp
1470 are present on all C89 platforms.
1471 (Ffrexp): Do not special-case zero, as frexp does the right thing
1472 for that case.
1473 (Flogb): Do not use logb, as it doesn't have the desired meaning
1474 on hosts that use non-base-2 floating point. Instead, stick with
1475 frexp, which is C89 anyway. Do not pass an infinity or a NaN to
1476 frexp, to avoid getting an unspecified result.
1477
6fda35f2
PE
1478 * xdisp.c (Qinhibit_debug_on_message): Now static.
1479
16130a58
JD
14802012-09-10 Jan Djärv <jan.h.d@swipnet.se>
1481
1482 * nsterm.m (ns_update_begin): Set clip path to whole view by using
1483 NSBezierPath (Bug#12131).
1484
d105a573
CY
14852012-09-10 Chong Yidong <cyd@gnu.org>
1486
1487 * fns.c (Fdelq, Fdelete): Doc fix.
1488
ff55dfe8
PE
14892012-09-10 Paul Eggert <eggert@cs.ucla.edu>
1490
1491 * lisp.h (XSETINT, XSETCONS, XSETVECTOR, XSETSTRING, XSETSYMBOL)
1492 (XSETFLOAT, XSETMISC): Parenthesize macro bodies.
1493
e7032e7c
SM
14942012-09-09 Stefan Monnier <monnier@iro.umontreal.ca>
1495
1496 * lisp.h (make_lisp_ptr): New macro to replace XSET.
1497 (XSETCONS, XSETVECTOR, XSETSTRING, XSETSYMBOL, XSETFLOAT, XSETMISC):
1498 Use it.
1499
e9957956
EZ
15002012-09-09 Eli Zaretskii <eliz@gnu.org>
1501
aba05ce9
EZ
1502 * fringe.c (draw_fringe_bitmap_1): Don't reduce the width of the
1503 left fringe if the window has a left margin. This avoids leaving
1504 traces of the cursor because its leftmost pixel is not drawn over.
1505
e9957956
EZ
1506 * dispnew.c (update_window_line): When the left margin area of a
1507 screen line is updated, set the redraw_fringe_bitmaps_p flag of
1508 that screen line. (Bug#12277)
1509
f6196b87
PE
15102012-09-09 Paul Eggert <eggert@cs.ucla.edu>
1511
1512 Assume C89 or later for math functions (Bug#12381).
1513 This simplifies the code, and makes it a bit smaller and faster,
1514 and (most important) makes it easier to clean up signal handling
1515 since we can stop worring about floating-point exceptions in
1516 library code. That was a problem before C89, but the problem
1517 went away many years ago on all practical Emacs targets.
1518 * data.c, image.c, lread.c, print.c:
1519 Don't include <math.h>; no longer needed.
1520 * data.c, floatfns.c (IEEE_FLOATING_POINT): Don't worry that it
1521 might be autoconfigured, as that never happens.
1522 * data.c (fmod):
1523 * doprnt.c (DBL_MAX_10_EXP):
1524 * print.c (DBL_DIG):
1525 Remove. C89 or later always defines these.
1526 * floatfns.c (HAVE_MATHERR, FLOAT_CHECK_ERRNO, FLOAT_CHECK_DOMAIN)
1527 (in_float, float_error_arg, float_error_arg2, float_error_fn_name)
1528 (arith_error, domain_error, domain_error2):
1529 Remove all this pre-C89 cruft. Do not include <errno.h> as that's
1530 no longer needed -- we simply return what C returns. All uses removed.
1531 (IN_FLOAT, IN_FLOAT2): Remove. All uses replaced with
1532 the wrapped code.
1533 (FLOAT_TO_INT, FLOAT_TO_INT2, range_error, range_error2):
1534 Remove. All uses expanded, as these macros are no longer used
1535 more than once and are now more trouble than they're worth.
1536 (Ftan): Use tan, not sin / cos.
1537 (Flogb): Assume C89 frexp.
1538 (fmod_float): Assume C89 fmod.
1539 (matherr) [HAVE_MATHERR]: Remove; no longer needed.
1540 (init_floatfns): Remove. All uses removed.
1541
9d7f1863
JD
15422012-09-08 Jan Djärv <jan.h.d@swipnet.se>
1543
1544 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Take back
1545 compositeToPoint for OSX < 10.6 (Bug#12390).
1546
eabf0404
PE
15472012-09-08 Paul Eggert <eggert@cs.ucla.edu>
1548
1549 * floatfns.c (Ftan): Use tan (x), not (sin (x) / cos (x)).
1550 This produces more-accurate results.
1551
0b3b1d23
JD
15522012-09-08 Jan Djärv <jan.h.d@swipnet.se>
1553
1554 * nsterm.m (updateFrameSize): Call setFrame: on the view when size
1555 changes (Bug#12088).
1556
6dcef6ec
CY
15572012-09-08 Chong Yidong <cyd@gnu.org>
1558
1559 * syntax.c (Fstring_to_syntax): Doc fix.
1560
aa7d57c5
JD
15612012-09-08 Jan Djärv <jan.h.d@swipnet.se>
1562
1563 * nsterm.m (ns_clip_to_row): Remove code that deals with drawing fringe
1564 in the internal border.
1565 (x_set_window_size): Remove static variables and their usage.
1566 (ns_redraw_scroll_bars): Fix NSTRACE arg.
3a880af4
SM
1567 (ns_after_update_window_line, ns_draw_fringe_bitmap):
1568 Remove fringe/internal border adjustment (Bug#11052).
aa7d57c5
JD
1569 (ns_draw_fringe_bitmap): Make code more like other terms (xterm.c).
1570 (ns_draw_window_cursor): Remove fringe/internal border adjustment.
1571 (ns_fix_rect_ibw): Remove.
1572 (ns_get_glyph_string_clip_rect): Remove call to ns_fix_rect_ibw.
1573 (ns_dumpglyphs_box_or_relief): Ditto.
1574 (ns_maybe_dumpglyphs_background): Remove fringe/internal border
1575 adjustment.
1576 (ns_dumpglyphs_image): Ditto.
fc0c31f8 1577 (ns_dumpglyphs_stretch): Fix coding style. Remove fringe/internal
aa7d57c5
JD
1578 border adjustment.
1579 (ns_set_vertical_scroll_bar): Remove variables barOnVeryLeft/Right and
1580 their usage. Add fringe_extended_p and its use as in other terms.
1581 (ns_judge_scroll_bars): Code style fix. Call updateFrameSize if
1582 scroll bar was removed.
1583 (updateFrameSize): New function.
1584 (windowDidResize): Move code to updateFrameSize and call it.
1585
1586 * nsterm.h (EmacsView): Add updateFrameSize.
1587
1a5432bc
CY
15882012-09-07 Chong Yidong <cyd@gnu.org>
1589
b4f5313e
CY
1590 * textprop.c (Fget_text_property): Minor doc fix (Bug#12323).
1591
1a5432bc
CY
1592 * data.c (Flocal_variable_if_set_p): Doc fix (Bug#10713).
1593
1a4f1e9b
PE
15942012-09-07 Paul Eggert <eggert@cs.ucla.edu>
1595
1596 More signal-handler cleanup (Bug#12327).
eddb36a7
PE
1597 * emacs.c (main): Convert three 'signal' calls to 'sigaction' calls.
1598 Problem introduced when merging patches. Noted by Eli Zaretskii in
1599 <http://bugs.gnu.org/12327#67>.
1a4f1e9b
PE
1600 * floatfns.c: Comment fix.
1601 * lisp.h (force_auto_save_soon): Declare regardless of SIGDANGER.
1602 SIGDANGER might not be in scope so "#ifdef SIGDANGER" is not right,
1603 and anyway the declaration is harmless even if SIGDANGER is not defined.
1604 * syssignal.h (SIGIO): Also #undef if (! defined FIONREAD ||
1605 defined BROKEN_FIONREAD). systty.h formerly did this, but other
1606 source files not surprisingly expected syssignal.h to define, or
1607 not define, SIGIO, and it's cleaner to do it that way, for consistency.
1608 Include <sys/ioctl.h>, for FIONREAD.
1609 * systty.h (SIGIO): Do not #undef here; it's now syssignal.h's job.
1610 This eliminates a problem whereby other files mysteriously had
1611 to include "syssignal.h" before including "systty.h" if they
1612 wanted to use "#ifdef SIGIO".
1613
bc8000ff
EZ
16142012-09-07 Eli Zaretskii <eliz@gnu.org>
1615
3e6d6928
EZ
1616 * w32proc.c (sigaction): New function, emulates Posix 'sigaction'.
1617
1618 * w32.c (sigemptyset): Empty the set.
1619 (sigsetmask, sigmask, sigblock, sigunblock): Remove unused functions.
1620
bc8000ff
EZ
1621 * alloc.c [ENABLE_CHECKING]: Include signal.h, since we need SIGABRT.
1622
b4fa72f2
DA
16232012-09-07 Dmitry Antipov <dmantipov@yandex.ru>
1624
1625 * alloc.c (mark_buffer): Revert unsafe marking optimization.
1626 (mark_object): Likewise for frame objects.
1627
30730c93
PE
16282012-09-07 Paul Eggert <eggert@cs.ucla.edu>
1629
1630 * syssignal.h (handle_on_main_thread): Always declare,
1631 even if FORWARD_SIGNAL_TO_MAIN_THREAD is not defined.
1632 This ports to platforms without HAVE_PTHREAD.
1633
2fe28299
PE
16342012-09-06 Paul Eggert <eggert@cs.ucla.edu>
1635
1636 Signal-handler cleanup (Bug#12327).
1637 Emacs's signal handlers were written in the old 4.2BSD style with
1638 sigblock and sigmask and so forth, and this led to some
1639 inefficiencies and confusion. Rewrite these to use
1640 pthread_sigmask etc. without copying signal sets around. Also,
1641 get rid of the confusing macros 'SIGNAL_THREAD_CHECK' and
1642 'signal', and instead use functions that do not attempt to take
1643 over the system name space. This patch causes Emacs's text
1644 segment to shrink by 0.7% on my platform, Fedora 17 x86-64.
1645 * alloc.c, emacsgtkfixed.c, nsfns.m, widget.c, xmenu.c:
1646 Do not include <signal.h> or "syssignal.h", as these
1647 modules do not use signals.
1648 * atimer.c, callproc.c, data.c, dispnew.c, emacs.c, floatfns.c:
1649 * gtkutil.c, keyboard.c, process.c, sound.c, sysdep.c, term.c, xterm.c:
1650 Do not include <signal.h>, as "syssignal.h" does that for us now.
1651 * atimer.c (sigmask_atimers): New function.
1652 (block_atimers, unblock_atimers): New functions,
1653 replacing the old macros BLOCK_ATIMERS and UNBLOCK_ATIMERS.
1654 All uses replaced.
1655 * conf_post.h [SIGNAL_H_AHB]: Do not include <signal.h>;
1656 no longer needed here.
1657 * emacs.c (main): Inspect existing signal handler with sigaction,
fc0c31f8 1658 so that there's no need to block and unblock SIGHUP.
2fe28299
PE
1659 * sysdep.c (struct save_signal): New member 'action', replacing
1660 old member 'handler'.
1661 (save_signal_handlers, restore_signal_handlers):
1662 Use sigaction instead of 'signal' to save and restore.
1663 (get_set_sighandler, set_sighandler) [!WINDOWSNT]:
1664 New function. All users of 'signal' modified to use set_sighandler
1665 if they're writeonly, and to use sys_signal if they're read+write.
1666 (emacs_sigaction_init, forwarded_signal): New functions.
1667 (sys_signal): Remove. All uses replaced by calls to sigaction
1668 and emacs_sigaction_init, or by direct calls to 'signal'.
1669 (sys_sigmask) [!__GNUC__]: Remove; no longer needed.
1670 (sys_sigblock, sys_sigunblock, sys_sigsetmask): Remove;
1671 all uses replaced by pthread_sigmask etc. calls.
1672 * syssignal.h: Include <signal.h>.
1673 (emacs_sigaction_init, forwarded_signal): New decls.
1674 (SIGMASKTYPE): Remove. All uses replaced by its definiens, sigset_t.
1675 (SIGEMPTYMASK): Remove; all uses replaced by its definiens, empty_mask.
1676 (sigmask, sys_sigmask): Remove; no longer needed.
1677 (sigpause): Remove. All uses replaced by its definiens, sigsuspend.
1678 (sigblock, sigunblock, sigfree):
1679 (sigsetmask) [!defined sigsetmask]:
1680 Remove. All uses replaced by pthread_sigmask.
1681 (signal): Remove. Its remaining uses (with SIG_DFL and SIG_IGN)
1682 no longer need to be replaced, and its typical old uses
1683 are now done via emacs_sigaction_init and sigaction.
1684 (sys_sigblock, sys_sigunblock, sys_sigsetmask): Remove decls.
1685 (sys_sigdel): Remove; unused.
1686 (NSIG): Remove a FIXME; the code's fine. Remove an unnecessary ifdef.
1687
0216c128
EZ
16882012-09-06 Eli Zaretskii <eliz@gnu.org>
1689
1690 * process.c (CAN_HANDLE_MULTIPLE_CHILDREN): Fix a typo that broke
1691 SIGCHLD handling on systems that don't have WNOHANG. (Bug#12327)
1692
c752cfa9
DA
16932012-09-06 Dmitry Antipov <dmantipov@yandex.ru>
1694
1695 Explicitly mark buffer_defaults and buffer_local_symbols.
1696 * alloc.c (Fgarbage_collect): Mark buffer_defaults and
1697 mark_local_symbols here.
1698 (mark_object): If GC_CHECK_MARKED_OBJECTS, simplify checking
1699 since special buffers aren't marked here any more.
1700 (allocate_buffer): Chain new buffer with all_buffers here...
1701 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer): ...and
1702 not here.
1703 (Vbuffer_defaults, Vbuffer_local_symbols): Remove.
1704 (syms_of_buffer): Remove staticpro of the above.
1705 (init_buffer_once): Set names for buffer_defaults and
1706 buffer_local_symbols.
1707
a864ef14
PE
17082012-09-06 Paul Eggert <eggert@cs.ucla.edu>
1709
1710 Use bool for booleans in font-related modules.
1711 * font.c (font_intern_prop, font_style_to_value)
1712 (font_style_symbolic, font_parse_xlfd, font_parse_fcname)
1713 (generate_otf_features, font_check_otf_features, font_check_otf)
1714 (font_match_p, font_list_entities, font_at):
1715 * fontset.c (fontset_id_valid_p, reorder_font_vector
1716 (fontset_find_font, Fset_fontset_font)
1717 (face_suitable_for_char_p) [0]:
1718 * ftfont.c (fc_initialized, ftfont_get_open_type_spec)
1719 (ftfont_open, ftfont_text_extents, ftfont_check_otf):
1720 (m17n_flt_initialized, ftfont_shape_by_flt):
1721 * ftxfont.c (ftxfont_draw_bitmap, ftxfont_draw):
1722 * nsfont.m (nsfont_draw):
1723 * w32font.c (w32font_draw):
1724 * w32term.c (x_draw_glyphless_glyph_string_foreground):
1725 Use bool for booleans.
1726 * font.h: Adjust to above API changes.
1727 (struct font, struct font_driver, struct font_driver_list):
1728 Use bool for booleans.
1729 (struct font): Remove useless member encoding_type.
1730 All users removed.
1731 * fontset.c, xftfont.c: Omit unnecessary static decls.
1732
0699fc18
DA
17332012-09-06 Dmitry Antipov <dmantipov@yandex.ru>
1734
1735 * alloc.c (mark_object): Revert window marking code
1736 since it's unsafe for the Fset_window_configuration.
1737
20ef56db
PE
17382012-09-05 Paul Eggert <eggert@cs.ucla.edu>
1739
2fe28299 1740 Fix race conditions with signal handlers and errno (Bug#12327).
20ef56db
PE
1741 Be more systematic about preserving errno whenever a signal
1742 handler returns, even if it's not in the main thread. Do this by
1743 renaming signal handlers to distinguish between signal delivery
1744 and signal handling. All uses changed.
1745 * atimer.c (deliver_alarm_signal): Rename from alarm_signal_handler.
1746 * data.c (deliver_arith_signal): Rename from arith_error.
1747 * dispnew.c (deliver_window_change_signal): Rename from
1748 window_change_signal.
1749 * emacs.c (deliver_error_signal): Rename from fatal_error_signal.
1750 (deliver_danger_signal) [SIGDANGER]: Rename from memory_warning_signal.
1751 * keyboard.c (deliver_input_available_signal): Rename from
1752 input_available_signal.
1753 (deliver_user_signal): Rename from handle_user_signal.
1754 (deliver_interrupt_signal): Rename from interrupt_signal.
1755 * process.c (deliver_pipe_signal): Rename from send_process_trap.
1756 (deliver_child_signal): Rename from sigchld_handler.
1757 * atimer.c (handle_alarm_signal):
1758 * data.c (handle_arith_signal):
1759 * dispnew.c (handle_window_change_signal):
1760 * emacs.c (handle_fatal_signal, handle_danger_signal):
1761 * keyboard.c (handle_input_available_signal):
1762 * keyboard.c (handle_user_signal, handle_interrupt_signal):
1763 * process.c (handle_pipe_signal, handle_child_signal):
1764 New functions, with the actual signal-handling code taken from the
1765 original respective signal handlers, sans the sporadic attempts to
1766 preserve errno, since that's now done by handle_on_main_thread.
1767 * atimer.c (alarm_signal_handler): Remove unnecessary decl.
1768 * emacs.c, floatfns.c, lisp.h: Remove unused FLOAT_CATCH_SIGKILL cruft.
1769 * emacs.c (main_thread) [FORWARD_SIGNAL_TO_MAIN_THREAD]:
1770 Move to sysdep.c.
1771 (main) [FORWARD_SIGNAL_TO_MAIN_THREAD]:
1772 Move initialization of main_thread to sysdep.c's init_signals.
1773 * process.c (waitpid) [!WNOHANG]: #define to wait; that's good enough for
1774 our usage, and simplifies the mainline code.
1775 (record_child_status_change): New static function, as a helper
1776 for handle_child_signal, and with most of the old child handler's
1777 contents.
1778 (CAN_HANDLE_MULTIPLE_CHILDREN): New constant.
1779 (handle_child_signal): Use the above.
1780 * sysdep.c (main_thread) [FORWARD_SIGNAL_TO_MAIN_THREAD]:
1781 Moved here from emacs.c.
1782 (init_signals) [FORWARD_SIGNAL_TO_MAIN_THREAD]: Initialize it;
1783 code moved here from emacs.c's main function.
1784 * sysdep.c, syssignal.h (handle_on_main_thread): New function,
3a880af4
SM
1785 replacing the old SIGNAL_THREAD_CHECK. All uses changed.
1786 This lets callers save and restore errno properly.
20ef56db 1787
e3ccf108
DA
17882012-09-05 Dmitry Antipov <dmantipov@yandex.ru>
1789
1790 Remove redundant or unused things here and there.
1791 * lisp.h (CYCLE_CHECK, CHAR_TABLE_TRANSLATE): Remove.
1792 * conf_post.h (RE_TRANSLATE): Use char_table_translate.
1793 * editfns.c (Fcompare_buffer_substrings): Likewise.
1794 * frame.h (struct terminal, struct font_driver_list):
1795 Remove redundant declarations.
1796 * window.h (Qleft, Qright): Likewise.
1797
697e1e39
DA
17982012-09-05 Dmitry Antipov <dmantipov@yandex.ru>
1799
1800 Do not mark objects from deleted buffers, windows and frames.
1801 * alloc.c (mark_buffer): Mark just the buffer if it is dead.
1802 (mark_object): Likewise for windows and frames.
1803
c1ca42ca
DA
18042012-09-05 Dmitry Antipov <dmantipov@yandex.ru>
1805
1806 * alloc.c (valid_lisp_object_p): Treat killed buffers,
1807 buffer_defaults and buffer_local_symbols as valid objects.
1808 Return special value to denote them.
1809
014d93be
PE
18102012-09-05 Paul Eggert <eggert@cs.ucla.edu>
1811
f75d7a91
PE
1812 * fileio.c, filelock.c, floatfns.c, fns.c: Use bool for boolean.
1813 * fileio.c (auto_saving, auto_save_error_occurred, make_temp_name)
1814 (Fexpand_file_name, barf_or_query_if_file_exists, Fcopy_file)
1815 (file_name_absolute_p, Fsubstitute_in_file_name):
1816 (check_executable, check_writable, Ffile_accessible_directory_p)
1817 (Fset_file_selinux_context, Fdefault_file_modes)
1818 (Finsert_file_contents, choose_write_coding_system)
1819 (Fwrite_region, build_annotations, a_write, e_write)
1820 (Fdo_auto_save):
1821 * filelock.c (boot_time_initialized, get_boot_time)
1822 (get_boot_time_1, lock_file_1, within_one_second):
1823 * floatfns.c (in_float):
1824 * fns.c (concat, internal_equal, Frequire, base64_encode_1)
1825 (base64_decode_1, cmpfn_eql, cmpfn_user_defined)
1826 (sweep_weak_table, sweep_weak_hash_tables, secure_hash):
1827 * lisp.h (struct Lisp_Hash_Table.cmpfn):
1828 * window.c (compare_window_configurations):
1829 Use bool for booleans.
1830 * fileio.c (auto_saving_dir_umask, auto_saving_mode_bits)
1831 (Fdefault_file_modes): Now mode_t, not int, for modes.
1832 (Fdo_auto_save): Set a boolean to 1 rather than using ++.
1833 (internal_delete_file): Now returns void, not a (boolean) int,
1834 since nobody was looking at the return value.
1835 * lisp.h, window.h: Adjust to above API changes.
1836
014d93be
PE
1837 * xdisp.c (set_message): Simplify and reindent last change.
1838
776f29e1
JB
18392012-09-05 Juanma Barranquero <lekktu@gmail.com>
1840
1841 * makefile.w32-in ($(BLD)/sysdep.$(O)): Update dependencies.
1842
7f7e0167
LI
18432012-09-04 Lars Ingebrigtsen <larsi@gnus.org>
1844
1845 * eval.c (call_debugger): Make the function non-static so that we
1846 can call it from set_message.
1847
1848 * xdisp.c (set_message): Implement the new variable `debug-on-message'.
1849 (syms_of_xdisp): Defvar it and `inhibit-debug-on-message'.
1850
cf29dd84
PE
18512012-09-04 Paul Eggert <eggert@cs.ucla.edu>
1852
1853 Give more-useful info on a fatal error (Bug#12328).
1854 * alloc.c [ENABLE_CHECKING]: Do not include <execinfo.h>.
1855 (die) [ENABLE_CHECKING]: Call fatal_error_backtrace instead
1856 of doing the work ourselves.
1857 * emacs.c (fatal_error_signal): Let fatal_error_backtrace
1858 do most of the work.
1859 (fatal_error_backtrace): New function, taken from the guts
1860 of the old fatal_error_signal, but with a new option to output
1861 a backtrace.
1862 (shut_down_emacs) [!DOS_NT]: Use strsignal to give more-useful
1863 info about the signal than just its number.
1864 * lisp.h (fatal_error_backtrace, emacs_backtrace): New decls.
1865 * sysdep.c: Include <execinfo.h>
1866 (emacs_backtrace): New function, taken partly from the previous
1867 code of the 'die' function.
1868 (emacs_abort): Call fatal_error_backtrace rather than abort.
1869
972debf2
SM
18702012-09-04 Stefan Monnier <monnier@iro.umontreal.ca>
1871
1872 * lread.c (readevalloop): Call internal-macroexpand-for-load to perform
1873 eager (load-time) macro-expansion.
1874 * lisp.mk (lisp): Add macroexp.
1875
1088b922
PE
18762012-09-04 Paul Eggert <eggert@cs.ucla.edu>
1877
1878 Simplify redefinition of 'abort' (Bug#12316).
1879 Do not try to redefine the 'abort' function. Instead, redo
1880 the code so that it calls 'emacs_abort' rather than 'abort'.
1881 This removes the need for the NO_ABORT configure-time macro
1882 and makes it easier to change the abort code to do a backtrace.
1883 * .gdbinit: Just stop at emacs_abort, not at w32_abort or abort.
1884 * emacs.c (abort) [!DOS_NT && !NO_ABORT]:
1885 Remove; sysdep.c's emacs_abort now takes its place.
1886 * lisp.h (emacs_abort): New decl. All calls from Emacs code to
1887 'abort' changed to use 'emacs_abort'.
1888 * msdos.c (dos_abort) [defined abort]: Remove; not used.
1889 (abort) [!defined abort]: Rename to ...
1890 (emacs_abort): ... new name.
1891 * sysdep.c (emacs_abort) [!HAVE_NTGUI]: New function, taking
1892 the place of the old 'abort' in emacs.c.
1893 * w32.c, w32fns.c (abort): Do not #undef.
1894 * w32.c (emacs_abort): Rename from w32_abort.
1895
30934d33
EZ
18962012-09-04 Eli Zaretskii <eliz@gnu.org>
1897
1898 * w32uniscribe.c (uniscribe_shape): Reverse the sign of
1899 offsets[j].dv, since the y axis of the screen coordinates points
1900 down, while the y axis of the font definition coordinates points
1901 up. This fixes display of Arabic diacritics such as KASRA and
1902 KASRATAN. (Bug#11860)
1903
af26b72c
PE
19042012-09-04 Paul Eggert <eggert@cs.ucla.edu>
1905
1906 Be more systematic about _setjmp vs setjmp.
1907 * alloc.c (test_setjmp, mark_stack):
1908 * image.c (PNG_LONGJMP) [PNG_LIBPNG_VER < 10500]:
1909 (PNG_JMPBUF) [! (PNG_LIBPNG_VER < 10500)]:
1910 (png_load, my_error_exit, jpeg_load):
1911 * process.c (send_process_trap, send_process):
1912 Uniformly prefer _setjmp and _longjmp to setjmp and longjmp.
1913 The underscored versions are up to 30x faster on some hosts.
1914 Formerly, the code used setjmp+longjmp sometimes and
1915 _setjmp+_longjmp at other times, with no particular reason to
1916 prefer setjmp+longjmp.
1917
26d4541d
PE
19182012-09-03 Paul Eggert <eggert@cs.ucla.edu>
1919
d42f4f0f 1920 Fix minor problem found by static checking.
26d4541d 1921 * buffer.c (Fdelete_all_overlays): Return nil.
26d4541d 1922
c5e28e39
MR
19232012-09-03 Martin Rudalics <rudalics@gmx.at>
1924
1925 * buffer.c (Fdelete_all_overlays): New function.
1926
3eab3ca9
CY
19272012-09-03 Chong Yidong <cyd@gnu.org>
1928
1929 * gtkutil.c: Add extern decl for Qxft.
1930
c04889f8
PE
19312012-09-02 Paul Eggert <eggert@cs.ucla.edu>
1932
1882aa38
PE
1933 * emacs.c, eval.c: Use bool for boolean.
1934 * emacs.c (initialized, inhibit_window_system, running_asynch_code):
1935 (malloc_using_checking) [DOUG_LEA_MALLOC]:
1936 (display_arg) [HAVE_X_WINDOWS || HAVE_NS]:
1937 (noninteractive, no_site_lisp, fatal_error_in_progress, argmatch)
1938 (main, decode_env_path, Fdaemon_initialized):
1939 * eval.c (call_debugger, Finteractive_p, interactive_p):
1940 (unwind_to_catch, Fsignal, wants_debugger, skip_debugger)
1941 (maybe_call_debugger, Fbacktrace):
1942 * process.c (read_process_output, exec_sentinel):
1943 Use bool for booleans.
1944 * emacs.c (shut_down_emacs): Omit unused boolean argument NO_X.
1945 All callers changed.
1946 * eval.c (interactive_p): Omit always-true boolean argument
1947 EXCLUDE_SUBRS_P. All callers changed.
1948 * dispextern.h, lisp.h: Reflect above API changes.
1949 * firstfile.c (dummy): Use the address of 'main', whose signature
1950 won't change, instead of the address of 'initialize', whose
1951 signature just changed from int to bool.
1952 * lisp.h (fatal_error_in_progress): New decl of boolean, moved here ...
1953 * msdos.c (fatal_error_in_progress): ... from here.
1954 * xdisp.c (redisplaying_p): Now a boolean. Set it to 1 instead
1955 of incrementing it.
1956 (redisplay_internal, unwind_redisplay): Simply clear
1957 REDISPLAYING_P when unwinding, instead of saving its previous,
1958 always-false value and then restoring it.
1959
a411ac43
PE
1960 Clean up some extern decls.
1961 Mostly, this hoists extern decls out of .c files and into .h files.
1962 That way, we're more likely to catch errors if the interfaces change.
1963 * alloc.c [USE_GTK]: Include "gtkutil.h" so that we need not
1964 declare xg_mark_data.
1965 * dispextern.h (x_frame_parm_handlers):
1966 * font.h (Qxft):
1967 * lisp.h (Qlexical_binding, Qinternal_interpreter_environment)
1968 (Qextra_light, Qlight, Qsemi_light, Qsemi_bold, Qbold, Qextra_bold)
1969 (Qultra_bold, Qoblique, Qitalic):
1970 Move extern decl here from .c file.
1971 * alloc.c (xg_mark_data) [USE_GTK]:
1972 * doc.c (Qclosure):
1973 * eval.c (Qlexical_binding):
1974 * fns.c (time) [!HAVE_UNISTD_H]:
1975 * gtkutil.c (Qxft, Qnormal, Qextra_light, Qlight, Qsemi_light)
1976 (Qsemi_bold, Qbold, Qextra_bold, Qultra_bold, Qoblique, Qitalic):
1977 * image.c (Vlibrary_cache, QCloaded_from) [HAVE_NTGUI]:
1978 * lread.c (Qinternal_interpreter_environment):
1979 * minibuf.c (Qbuffer):
1980 * process.c (QCfamily, QCfilter):
1981 * widget.c (free_frame_faces):
1982 * xfaces.c (free_frame_menubar) [USE_X_TOOLKIT]:
1983 * xfont.c (x_clear_errors):
1984 * xterm.c (x_frame_parm_handlers):
1985 Remove now-redundant extern decls.
1986 * keyboard.c, keyboard.h (ignore_mouse_drag_p) [USE_GTK || HAVE_NS]:
1987 * xfaces.c (Qultra_light, Qreverse_oblique, Qreverse_italic):
1988 Now static.
1989 * xfaces.c: Remove unnecessary static decls.
1990 * xterm.c (updating_frame): Remove decl of nonexistent object.
1991
c04889f8
PE
1992 * Makefile.in (gl-stamp): Don't scan $(SOME_MACHINE_OBJECTS)
1993 when building globals.h, as the objects that are not built on
1994 this host are not needed to compile C files on this host.
1995
8b339673
JD
19962012-09-02 Jan Djärv <jan.h.d@swipnet.se>
1997
1998 * gtkutil.h: Remove prototype for x_wm_set_size_hint.
1999
2000 * frame.h: Add missing prototype for x_wm_set_size_hint.
2001
a08d4ba7
PE
20022012-09-02 Paul Eggert <eggert@cs.ucla.edu>
2003
2004 * doc.c, editfns.c, insdel.c, intervals.c: Use bool for boolean.
2005 * doc.c (read_bytecode_char, get_doc_string, reread_doc_file)
2006 (Fdocumentation, Fdocumentation_property, Fsnarf_documentation)
2007 (Fsubstitute_command_keys):
2008 * editfns.c (region_limit, find_field, Fconstrain_to_field)
2009 (save_excursion_save, save_excursion_restore)
2010 (disassemble_lisp_time, decode_time_components, emacs_nmemftime)
2011 (format_time_string, general_insert_function)
2012 (make_buffer_string, make_buffer_string_both)
2013 (Fsubst_char_in_region, Ftranslate_region_internal, Fformat):
2014 * insdel.c (check_markers, gap_left, adjust_markers_for_insert)
2015 (copy_text, insert_1, insert_1_both, insert_from_string)
2016 (insert_from_string_before_markers, insert_from_string_1)
2017 (insert_from_buffer, insert_from_buffer_1, replace_range)
2018 (replace_range_2, del_range_1, del_range_byte, del_range_both)
2019 (del_range_2, modify_region):
2020 * intervals.c (intervals_equal, balance_possible_root_interval)
2021 (adjust_intervals_for_insertion, merge_properties_sticky)
2022 (graft_intervals_into_buffer, lookup_char_property)
2023 (adjust_for_invis_intang, set_point_both)
2024 (get_property_and_range, compare_string_intervals)
2025 (set_intervals_multibyte_1, set_intervals_multibyte):
2026 * keyboard.c (decode_timer):
2027 Use bool for boolean.
2028 * intervals.h, lisp.h, systime.h: Reflect above API changes.
2029 * editfns.c (struct info): Use 1-bit unsigned bitfields for booleans.
2030
48c948de
CY
20312012-09-02 Chong Yidong <cyd@gnu.org>
2032
2033 * keymap.c (push_key_description): Print M-TAB as C-M-i
2034 (Bug#11758).
2035
6c49a40b
JB
20362012-09-02 Juanma Barranquero <lekktu@gmail.com>
2037
2038 * makefile.w32-in (CCL_H, W32FONT_H): New macros.
2039 (ATIMER_H, FONT_H, $(BLD)/alloc.$(O), $(BLD)/callproc.$(O))
2040 ($(BLD)/editfns.$(O), $(BLD)/ccl.$(O), $(BLD)/chartab.$(O))
2041 ($(BLD)/coding.$(O), $(BLD)/sysdep.$(O), $(BLD)/fontset.$(O))
2042 ($(BLD)/sysdep.$(O), $(BLD)/w32fns.$(O), $(BLD)/keyboard.$(O))
2043 ($(BLD)/w32term.$(O), $(BLD)/w32menu.$(O), $(BLD)/process.$(O))
2044 ($(BLD)/w32font.$(O), $(BLD)/w32uniscribe.$(O)): Update dependencies.
2045
4dfbd238
EZ
20462012-09-01 Eli Zaretskii <eliz@gnu.org>
2047
7e510e28
EZ
2048 * w32uniscribe.c (uniscribe_shape): Handle correctly the case of
2049 more than one grapheme cluster passed to the shaper: compute the
2050 offset adjustment values separately for each cluster. (Bug#11860)
2051
4dfbd238
EZ
2052 * image.c: Restore mistakenly removed inclusion of w32.h. Without
2053 it, GCC doesn't see prototypes of w32_delayed_load, and complains
2054 about implicit conversions from integer to pointer.
2055
86571ae0
DC
20562012-09-01 Daniel Colascione <dancol@dancol.org>
2057
2058 * w32fns.c (x_display_info_for_name): Prevent crash if w32 window
2059 system used too early.
2060
0e23ef9d
PE
20612012-09-01 Paul Eggert <eggert@cs.ucla.edu>
2062
2063 Better seed support for (random).
2064 * emacs.c (main): Call init_random.
2065 * fns.c (Frandom): Set the seed from a string argument, if given.
2066 Remove long-obsolete Gentzel cruft.
2067 * lisp.h, sysdep.c (seed_random): Now takes address and size, not long.
2068 (init_random): New function.
2069
17a2cbbd
DC
20702012-09-01 Daniel Colascione <dancol@dancol.org>
2071
2072 * xterm.h: Add header guards. Declare x_menubar_window_to_frame.
2073 Remove x_set_frame_alpha, x_bitmap_icon, x_make_frame_visible,
2074 x_make_frame_invisible, x_iconify_frame, x_free_frame_resources,
2075 x_wm_set_size_hint, x_query_colors, x_real_positions,
2076 x_set_menu_bar_lines, x_char_width, x_char_height, x_sync,
2077 x_set_tool_bar_lines, x_activate_menubar, and free_frame_menubar,
2078 all of which have been moved to common code.
2079
2080 * xfaces.c: Include TERM_HEADER instead of listing all possible
2081 window-system headers.
2082
2083 * w32xfns.c (x_sync): Correct definition of x_sync (a no-op here)
2084 to match header.
2085
2086 * w32term.h (FRAME_X_WINDOW): Use FRAME_W32_WINDOW instead of
2087 directly accessing frame internals.
2088
f18cbb28 2089 * w32font.h: Include font.h. Define syms_of_w32font and
17a2cbbd
DC
2090 globals_of_w32font.
2091
2092 * process.c: Include TERM_HEADER instead of listing all possible
2093 window-system headers.
2094
3a880af4
SM
2095 * nsterm.h: Remove declarations now in frame.h.
2096 Define FRAME_X_SCREEN, FRAME_X_VISUAL.
17a2cbbd
DC
2097
2098 * menu.c: Include TERM_HEADER instead of listing all possible
2099 window-system headers.
2100
2101 * keyboard.h: Declare ignore_mouse_drag_p whenever we have a
2102 window system.
2103
2104 * keyboard.c: Include TERM_HEADER instead of listing all possible
2105 window-system headers.
2106
2107 * image.c: Include TERM_HEADER instead of listing all possible
2108 window-system headers. Declare Vlibrary_cache when compiling for
2109 Windows.
2110
2111 * gtkutil.h (xg_list_node_): Include xterm.h to pick up needed
2112 window system declarations.
2113
2114 * frame.h: Move common functions here: set_frame_menubar,
2115 x_set_window_size, x_sync, x_get_focus_frame,
2116 x_set_mouse_position, x_set_mouse_pixel_position,
2117 x_make_frame_visible, x_make_frame_invisible, x_iconify_frame,
2118 x_char_width, x_char_height, x_pixel_width, x_pixel_height,
2119 x_set_frame_alpha, x_set_menu_bar_lines, x_set_tool_bar_lines,
2120 x_activate_menubar, x_real_positions, x_bitmap_icon,
2121 x_set_menu_bar_lines, free_frame_menubar, x_free_frame_resources,
2122 and x_query_colors.
2123
2124 * frame.c: Include TERM_HEADER instead of listing all possible
2125 window-system headers.
2126
2127 * font.c: Include TERM_HEADER instead of listing all possible
2128 window-system headers.
2129
2130 * emacs.c: Include TERM_HEADER.
2131
f18cbb28
EZ
2132 * dispnew.c: Include TERM_HEADER instead of listing all possible
2133 window-system headers.
17a2cbbd 2134
f18cbb28 2135 * ccl.h: Include character.h.
17a2cbbd
DC
2136
2137 * Makefile.in: Define WINDOW_SYSTEM_OBJ to hold objects needed for
2138 the current window system; include in list of objects to link into
2139 Emacs.
2140
c650a5de
DA
21412012-08-31 Dmitry Antipov <dmantipov@yandex.ru>
2142
2143 Remove mark_ttys function and fix tty_display_info initialization.
2144 * lisp.h (mark_ttys): Remove prototype.
2145 * alloc.c (Fgarbage_collect): Remove redundant (and the only) call
2146 to mark_ttys because all possible values of 'top_frame' slot are
2147 the frames which are reachable from Vframe_list.
2148 * term.c (mark_ttys): Remove.
2149 (init_tty): Safely initialize 'top_frame' slot with Qnil.
2150
4e0f6479
DA
21512012-08-31 Dmitry Antipov <dmantipov@yandex.ru>
2152
2153 Change struct frame bitfields from unsigned char to unsigned.
2154 * frame.h (struct frame): Change type of 'display_preempted',
2155 'visible', 'iconified', 'has_minibuffer', 'wants_modeline',
2156 'auto_raise', 'auto_lower', 'no_split', 'explicit_name',
2157 'window_sizes_changed', 'mouse_moved' and 'pointer_invisible'
2158 bitfields from unsigned char to unsigned.
2159
8b96a52c
DA
21602012-08-31 Dmitry Antipov <dmantipov@yandex.ru>
2161
2162 Remove unused member of struct x_output and struct w32_output.
2163 * xterm.h (struct x_output): Remove unused field 'needs_exposure'.
2164 * w32term.h (struct w32_output): Likewise.
2165
b4444c8a
JD
21662012-08-30 Jan Djärv <jan.h.d@swipnet.se>
2167
2168 * gtkutil.c (x_wm_set_size_hint): Use 1 col for base_width so it
2169 does not become zero (Bug#12234).
2170
b98521db
PE
21712012-08-30 Paul Eggert <eggert@cs.ucla.edu>
2172
2173 * dispnew.c (update_frame_1): Pacify gcc -Wstrict-overflow
2174 for GCC 4.7.1 x86-64.
2175
31d02438
GM
21762012-08-30 Glenn Morris <rgm@gnu.org>
2177
2178 * lread.c (init_lread): For out-of-tree builds, only add the
2179 source directory's site-lisp dir to the load-path if it exists,
2180 consistent with in-tree builds. (Bug#12302)
2181
7f8941d8
JD
21822012-08-28 Jan Djärv <jan.h.d@swipnet.se>
2183
2184 * nsmenu.m (initWithContentRect:styleMask:backing:defer:): Initialize
fc0c31f8 2185 button_values to NULL. Call setStykeMask so dialogs get a close button.
7f8941d8
JD
2186 (windowShouldClose:): Set window_closed.
2187 (dealloc): New member, free button_values.
fc0c31f8
JB
2188 (process_dialog:): Make member function. Remove window argument,
2189 replace window with self. Count buttons and allocate and store values
7f8941d8
JD
2190 in button_values.
2191 (addButton:value:row:): value is int with the name tag. Call setTag
fc0c31f8 2192 with tag. Remove return self, declare return value as void.
7f8941d8
JD
2193 (addString:row:): Remove return self, declare return value as void.
2194 (addSplit): Remove return self, declare return value as void.
2195 (clicked:): Remove return self, declare return value as void.
fc0c31f8 2196 Set dialog_return to button_values[seltag]. Code formatting change.
7f8941d8
JD
2197 (initFromContents:isQuestion:): Adjust call to process_dialog.
2198 Code formatting change.
2199 (timeout_handler:): Set timer_fired to YES.
2200 (runDialogAt:): Set timer_fired to NO.
2201 Handle click on close button as quit.
2202
2203 * nsterm.h (EmacsDialogPanel): Make timer_fired BOOL.
2204 Add window_closed and button_values. Add void as return value for
2205 add(Button|String|Split). addButton takes int instead of Lisp_Object.
2206 Add process_dialog as new member.
2207
eada0861 22082012-08-28 Eli Zaretskii <eliz@gnu.org>
19c17fc1 2209
eada0861
GM
2210 * ralloc.c (free_bloc): Don't dereference a 'heap' structure if it
2211 is not one of the heaps we manage. (Bug#12242)
2212
22132012-08-28 Glenn Morris <rgm@gnu.org>
2214
2215 * eval.c (Fcalled_interactively_p): Doc fix. (Bug#11747)
2216
457294dd
MR
22172012-08-28 Martin Rudalics <rudalics@gmx.at>
2218
2219 * window.c (Fset_window_configuration): Remove handling of
37b9743e
MR
2220 auto-buffer-name window parameter. Install revision of reverted
2221 fix.
457294dd 2222
4f2daf31
DA
22232012-08-28 Dmitry Antipov <dmantipov@yandex.ru>
2224
2225 Do not allow to set major mode for a dead buffer.
2226 * buffer.c (Fset_buffer_major_mode): Signal an error
2227 if the buffer is dead.
2228 (Fother_buffer, other_buffer_safely): Remove redundant
2229 nested declaration.
2230
66322887
DA
22312012-08-28 Dmitry Antipov <dmantipov@yandex.ru>
2232
2233 Always use set_buffer_if_live to restore original buffer at unwind.
2234 * buffer.h (record_unwind_current_buffer): New function.
2235 * bytecode.c, dispnew.c, editfns.c, fileio.c, fns.c, insdel.c:
2236 * keyboard.c, keymap.c, minibuf.c, print.c, process.c, textprop.c:
2237 * undo.c, window.c: Adjust users.
2238 * buffer.c (set_buffer_if_live): Fix comment.
2239
a3d794a1
DA
22402012-08-28 Dmitry Antipov <dmantipov@yandex.ru>
2241
2242 Fix usage of set_buffer_internal.
2243 * buffer.h (set_buffer_internal): Make it BUFFER_INLINE.
2244 * buffer.c (set_buffer_if_live): Use set_buffer_internal.
2245 * coding.c (decode_coding): Omit redundant test.
2246 * fileio.c (decide_coding_unwind): Likewise.
2247 * fns.c (secure_hash): Likewise.
2248 * insdel.c (modify_region): Likewise.
2249 * keyboard.c (command_loop_1): Likewise.
2250 * print.c (PRINTFINISH): Likewise.
2251 * xdisp.c (run_window_scroll_functions): Use set_buffer_internal.
2252
59ea14cd
PE
22532012-08-27 Paul Eggert <eggert@cs.ucla.edu>
2254
2255 * dispnew.c: Use bool for boolean.
2256 (frame_garbaged, display_completed, delayed_size_change)
2257 (fonts_changed_p, add_window_display_history)
2258 (add_frame_display_history, verify_row_hash)
2259 (adjust_glyph_matrix, clear_window_matrices, glyph_row_slice_p)
2260 (row_equal_p, realloc_glyph_pool)
2261 (allocate_matrices_for_frame_redisplay)
2262 (showing_window_margins_p)
2263 (adjust_frame_glyphs_for_frame_redisplay)
2264 (build_frame_matrix_from_leaf_window, make_current)
2265 (mirrored_line_dance, mirror_line_dance, update_frame)
2266 (update_window_tree, update_single_window)
2267 (check_current_matrix_flags, update_window, update_text_area)
2268 (update_window_line, set_window_update_flags, scrolling_window)
2269 (update_frame_1, scrolling, buffer_posn_from_coords)
2270 (do_pending_window_change, change_frame_size)
2271 (change_frame_size_1, sit_for):
2272 Use bool for boolean.
2273 (clear_glyph_matrix_rows): Rename from enable_glyph_matrix_rows,
2274 and remove last int (actually boolean) argument, which was always 0.
2275 All callers changed.
2276 * dispextern.h, frame.h, lisp.h: Reflect above API changes.
2277 * dispextern.h (struct composition_it): Use bool for boolean.
2278 (struct glyph_matrix): Don't assume buffer sizes can fit in 'int'.
2279 (struct bidi_it): Use unsigned:1, not int, for boolean prev_was_pdf.
2280 * dired.c (file_name_completion):
2281 Use bool for boolean. (This was missed in an earlier change.)
2282
95072a94
MR
22832012-08-27 Martin Rudalics <rudalics@gmx.at>
2284
2285 * window.c (Fset_window_configuration): Revert first part of
2286 last change.
2287
0f19feff
JD
22882012-08-27 Jan Djärv <jan.h.d@swipnet.se>
2289
2290 * nsterm.h (NSPanel): New class variable dialog_return.
2291
3a880af4
SM
2292 * nsmenu.m (initWithContentRect:styleMask:backing:defer:):
2293 Initialize dialog_return.
0f19feff
JD
2294 (windowShouldClose:): Use stop instead of stopModalWithCode.
2295 (clicked:): Ditto, and also set dialog_return (Bug#12258).
2296 (timeout_handler:): Use stop instead of abortModal. Send a dummy
2297 event.
2298 (runDialogAt:): Make ret Lisp_Object. Set it from dialog_return when
2299 modal loop returns.
2300
f10fe38f
PE
23012012-08-27 Paul Eggert <eggert@cs.ucla.edu>
2302
de1339b0
PE
2303 * composite.c, data.c, dbusbind.c, dired.c: Use bool for booleans.
2304 * composite.c (find_composition, composition_gstring_p)
2305 (composition_reseat_it, find_automatic_composition):
2306 * data.c (let_shadows_buffer_binding_p)
2307 (let_shadows_global_binding_p, set_internal, make_blv)
2308 (Fmake_variable_buffer_local, Fmake_local_variable)
2309 (Fmake_variable_frame_local, arithcompare, cons_to_unsigned)
2310 (cons_to_signed, arith_driver):
2311 * dbusbind.c (xd_in_read_queued_messages):
2312 * dired.c (directory_files_internal, file_name_completion):
2313 Use bool for booleans.
2314 * dired.c (file_name_completion):
2315 * process.h (fd_callback):
2316 Omit int (actually boolean) argument. It wasn't being used.
2317 All uses changed.
2318 * composite.h, lisp.h: Reflect above API changes.
2319
f10fe38f
PE
2320 * cmds.c, coding.c: Use bool for booleans.
2321 * cmds.c (move_point, Fself_insert_command):
2322 * coding.h (struct composition status, struct coding_system):
2323 * coding.c (detect_coding_utf_8, encode_coding_utf_8)
2324 (detect_coding_utf_16, encode_coding_utf_16, detect_coding_emacs_mule)
2325 (emacs_mule_char, decode_coding_emacs_mule)
2326 (encode_coding_emacs_mule, detect_coding_iso_2022)
2327 (decode_coding_iso_2022, encode_invocation_designation)
2328 (encode_designation_at_bol, encode_coding_iso_2022)
2329 (detect_coding_sjis, detect_coding_big5, decode_coding_sjis)
2330 (decode_coding_big5, encode_coding_sjis, encode_coding_big5)
2331 (detect_coding_ccl, encode_coding_ccl, decode_coding_raw_text)
2332 (encode_coding_raw_text, detect_coding_charset)
2333 (decode_coding_charset, encode_coding_charset, detect_eol)
2334 (detect_coding, get_translation_table, produce_chars)
2335 (consume_chars, reused_workbuf_in_use)
2336 (make_conversion_work_buffer, code_conversion_save)
2337 (decode_coding_object, encode_coding_object)
2338 (detect_coding_system, char_encodable_p)
2339 (Funencodable_char_position, code_convert_region)
2340 (code_convert_string, code_convert_string_norecord)
2341 (Fset_coding_system_priority):
2342 * fileio.c (Finsert_file_contents):
2343 Use bool for booleans.
2344 * coding.h, lisp.h: Reflect above API changes.
2345 * coding.c: Remove unnecessary static function decls.
2346 (detect_coding): Use unsigned, not signed, to copy an unsigned field.
2347 (decode_coding, encode_coding, decode_coding_gap): Return 'void',
2348 not a boolean 'int', since callers never look at the return value.
2349 (ALLOC_CONVERSION_WORK_AREA): Assume caller returns 'void', not 'int'.
2350 * coding.h (decoding_buffer_size, encoding_buffer_size)
2351 (emacs_mule_string_char): Remove unused extern decls.
2352 (struct iso_2022_spec, struct coding_system):
2353 Use 'unsigned int : 1' for boolean fields, since there's more than one.
2354 (struct emacs_mule_spec): Remove unused field 'full_support'.
2355 All initializations removed.
2356 * cmds.c (internal_self_insert): Don't assume EMACS_INT fits in 'int'.
2357
5474c384
DA
23582012-08-27 Dmitry Antipov <dmantipov@yandex.ru>
2359
f10fe38f 2360 Fix spare memory change (Bug#12286).
5474c384
DA
2361 * alloc.c (mark_maybe_pointer): Handle MEM_TYPE_SPARE.
2362 (valid_lisp_object_p): Likewise.
2363
c4b6914d
MR
23642012-08-27 Martin Rudalics <rudalics@gmx.at>
2365
2366 * window.c (Fset_window_configuration): Record any window's old
2367 buffer if it's replaced (see Bug#8789). If the new current
2368 buffer doesn't appear in the selected window, go to its old
2369 point (Bug#12208).
2370
35aaa1ea
DA
23712012-08-27 Dmitry Antipov <dmantipov@yandex.ru>
2372
2373 Special MEM_TYPE_SPARE to denote reserved memory.
2374 * alloc.c (enum mem_type): New memory type.
2375 (refill_memory_reserve): Use new type for spare memory.
2376 This prevents live_cons_p and live_string_p from incorrect
2377 detection of uninitialized objects from spare memory as live.
2378
6af64513
PE
23792012-08-26 Paul Eggert <eggert@cs.ucla.edu>
2380
8b2e00a3
PE
2381 Spelling fixes.
2382 * Makefile.in (.PHONY): versioclean -> versionclean.
2383
b52d6985
PE
2384 Remove unused external symbols.
2385 * data.c (Qcons, Qfloat, Qmisc, Qstring, Qvector):
2386 * window.c (Qwindow_valid_p, decode_valid_window):
2387 Now static, not extern.
2388 * data.c (Qinterval): Remove; unused.
2389 (syms_of_data): Do not define 'interval'.
2390 * lisp.h (Qinteger, Qstring, Qmisc, Qvector, Qfloat, Qcons):
2391 * window.h (decode_valid_window):
2392 Remove decls.
2393
d5172d4f
PE
2394 * character.c, charset.c, chartab.c: Use bool for booleans.
2395 * character.c (lisp_string_width, string_count_byte8)
2396 (string_escape_byte8):
2397 * charset.c (charset_map_loaded, load_charset_map, read_hex):
2398 (load_charset_map_from_file, map_charset_chars)
2399 (Fdefine_charset_internal, define_charset_internal)
2400 (Fdeclare_equiv_charset, find_charsets_in_text)
2401 (Ffind_charset_region, char_charset, Fiso_charset):
2402 * chartab.c (sub_char_table_ref, sub_char_table_ref_and_range)
2403 (sub_char_table_set, sub_char_table_set_range)
2404 (char_table_set_range, optimize_sub_char_table)
2405 (map_sub_char_table):
2406 Use bool for boolean.
2407 * character.c (str_to_unibyte): Omit last boolean argument; it was
2408 always 0. All callers changed.
2409 * character.h, charset.h: Adjust to match previous changes.
2410 * character.h (char_printable_p): Remove decl of nonexistent function.
2411 * charset.h (struct charset): Members code_linear_p, iso_chars_96,
2412 ascii_compatible_p, supplementary_p, compact_codes_p, unified_p
2413 are all boolean, so make them single-bit bitfields.
2414
6af64513
PE
2415 * lisp.h (ASET): Remove attempt to detect side effects.
2416 It was meant to be temporary and it often doesn't work,
2417 because when IDX has side effects the behavior of IDX==IDX
2418 is undefined. See Stefan Monnier in
2419 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00762.html>.
2420
e1f29348
BR
24212012-08-26 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
2422
2423 * lisp.h (functionp): New function (extracted from Ffunctionp).
2424 (FUNCTIONP): Use it.
2425 * eval.c (Ffunctionp): Use it.
2426
17c05d74
PE
24272012-08-25 Paul Eggert <eggert@cs.ucla.edu>
2428
0f46bc75
PE
2429 * xgselect.c (xg_select): Use auto storage for the GPollFD buffer
2430 as that's faster and simpler than static storage. Don't bother
2431 with the g_main_context_query overhead if g_main_context_pending
2432 says no events are pending.
2433 (gfds, gfds_size): Remove these static vars.
2434 (xgselect_initialize): Remove; no longer needed.
2435 All uses and decls removed.
2436
ee4c0f69
PE
2437 * emacs.c (fatal_error_signal_hook): Remove.
2438 All uses removed. This leftover from old code was always 0.
2439
17c05d74
PE
2440 * casefiddle.c, casetab.c, category.c: Use bool for boolean.
2441 * casefiddle.c (casify_object, casify_region):
2442 * casetab.c (set_case_table):
2443 * category.c, category.h (word_boundary_p):
2444 * category.h (CHAR_HAS_CATEGORY):
2445 Use bool for booleans, instead of int.
2446
391ceac5
EZ
24472012-08-25 Eli Zaretskii <eliz@gnu.org>
2448
2449 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on $(GNU_LIB)/execinfo.h.
2450
2f221583
PE
24512012-08-25 Paul Eggert <eggert@cs.ucla.edu>
2452
f4a681b0
PE
2453 On assertion failure, print backtrace if available.
2454 * alloc.c [ENABLE_CHECKING]: Include <execinfo.h>.
2455 (die) [ENABLE_CHECKING]: Print a backtrace if available.
2456 * Makefile.in (LIB_EXECINFO): New macro.
2457 (LIBES): Use it.
2458
2f221583
PE
2459 * bytecode.c, callint.c, callproc.c: Use bool for boolean.
2460 * bytecode.c (exec_byte_code):
2461 * callint.c (check_mark, Fcall_interactively):
2462 * callproc.c (Fcall_process, add_env, child_setup, getenv_internal_1)
2463 (getenv_internal, sync_process_alive, call_process_exited):
2464 * lisp.h (USE_SAFE_ALLOCA):
2465 Use bool for booleans, instead of int.
2466 * lisp.h, process.h: Adjust prototypes to match above changes.
2467 * callint.c (Fcall_interactively): Don't assume the mark's
2468 offset fits in 'int'.
2469
37ef52bb
PE
24702012-08-24 Paul Eggert <eggert@cs.ucla.edu>
2471
2472 * buffer.c, buffer.h: Use bool for boolean.
2473 * buffer.c (reset_buffer_local_variables)
2474 (buffer_lisp_local_variables, Fset_buffer_modified_p)
2475 (Frestore_buffer_modified_p, Fset_buffer_multibyte):
2476 (overlays_at, overlays_in, mouse_face_overlay_overlaps)
2477 (overlay_touches_p, overlay_strings, Foverlay_put)
2478 (report_overlay_modification, call_overlay_mod_hooks):
2479 (mmap_enlarge, mmap_set_vars):
2480 * buffer.h (buffer_has_overlays, uppercasep, lowercasep):
2481 Use bool for booleans, instead of int.
2482 * buffer.c (compact_buffer, mmap_free_1): Return void, not int,
2483 since the 1-or-0 return value is always ignored anyway.
2484 (mmap_initialized_p):
2485 * buffer.h (struct buffer_text.inhibit_shrinking): Now bool, not int.
2486 * buffer.h, lisp.h: Adjust prototypes to match above changes.
2487
2cc21167
PE
24882012-08-23 Paul Eggert <eggert@cs.ucla.edu>
2489
2490 * bidi.c: Use bool for boolean.
2491 This is a bit more readable, and makes the text segment of bidi.o
2492 0.4% smaller on my platform (GCC 4.7.1 x86-64, Fedora 15).
2493 Presumably it's faster too.
2494 (bidi_initialized, bidi_ignore_explicit_marks_for_paragraph_level):
2495 Now bool.
2496 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2497 (bidi_unshelve_cache, bidi_init_it, bidi_count_bytes)
2498 (bidi_char_at_pos, bidi_fetch_char, bidi_paragraph_init)
2499 (bidi_explicit_dir_char, bidi_level_of_next_char)
2500 (bidi_find_other_level_edge, bidi_move_to_visually_next):
2501 Use bool for booleans, instead of int.
2502 * dispextern.h (bidi_init_it, bidi_paragraph_init)
2503 (bidi_unshelve_cache): Adjust decls to match code.
2504
7db4ddf4
MR
25052012-08-23 Martin Rudalics <rudalics@gmx.at>
2506
2507 * keyboard.c (Fposn_at_x_y): Do not allow internal window as
2508 argument.
2509
b1bb8011
PE
25102012-08-23 Paul Eggert <eggert@cs.ucla.edu>
2511
2512 * atimer.c, atimer.h (turn_on_atimers): Use bool for boolean.
2513 * atimer.h: Include <stdbool.h>.
2514
ff687885
DN
25152012-08-22 Dan Nicolaescu <dann@gnu.org>
2516
2517 * frame.h (FRAME_W32_P, FRAME_MSDOS_P, FRAME_NS_P): Change to
2518 compile time tests instead of run time tests on systems that do
2519 not use them.
2520 (FRAME_MAC_P): Remove leftover from deleted code.
2521 * frame.c (syms_of_frame): Remove leftover from deleted code.
2522
4ce7a138
JD
25232012-08-22 Jan Djärv <jan.h.d@swipnet.se>
2524
2525 * nsterm.m (insertText:): Don't clear modifiers if code is space.
2526
d733ec6d
PE
25272012-08-22 Paul Eggert <eggert@cs.ucla.edu>
2528
2529 * fontset.c (FONTSET_ADD): Return void, not Lisp_Object.
2530 Otherwise, the compiler complains about (A?B:C) where B is void
fc0c31f8 2531 and C is Lisp_Object. This fixes an incompatibility with Sun C 5.12.
d733ec6d
PE
2532 (fontset_add): Return void, for FONTSET_ADD.
2533
d0d2d26f
PE
25342012-08-21 Paul Eggert <eggert@cs.ucla.edu>
2535
fce31d69
PE
2536 * alloc.c: Use bool for booleans.
2537 (gc_in_progress, abort_on_gc)
2538 (setjmp_tested_p) [!GC_SAVE_REGISTERS_ON_STACK && !GC_SETJMP_WORKS]:
2539 (dont_register_blocks) [GC_MALLOC_CHECK]:
2540 (suppress_checking) [ENABLE_CHECKING]: Now bool, not int.
2541 (check_string_bytes, make_specified_string, memory_full)
2542 (live_string_p, live_cons_p, live_symbol_p, live_float_p)
2543 (live_misc_p, live_vector_p, live_buffer_p, mark_maybe_object)
2544 (mark_stack, valid_pointer_p, make_pure_string)
2545 (Fgarbage_collect, survives_gc_p, gc_sweep):
2546 Use bool for booleans, instead of int.
2547 (test_setjmp) [!GC_SAVE_REGISTERS_ON_STACK && !GC_SETJMP_WORKS]:
2548 Remove unused local.
2549 * alloc.c (PURE_POINTER_P):
2550 * lisp.h (STRING_MULTIBYTE): Document that it returns a boolean.
2551 * editfns.c (Fformat):
2552 * fileio.c (Fexpand_file_name, Fsubstitute_in_file_name)
2553 (Fdo_auto_save):
2554 * fns.c (sweep_weak_table):
2555 * lisp.h (suppress_checking, push_message, survives_gc_p)
2556 (make_pure_string, gc_in_progress, abort_on_gc):
2557 * lread.c (readchar, read1):
2558 * print.c (Fprin1_to_string):
2559 * xdisp.c (push_message):
2560 Use bool for booleans affected directly or indirectly by
2561 alloc.c's changes.
2562
d0d2d26f
PE
2563 Make recently-introduced setters macros.
2564 * fontset.c (set_fontset_id, set_fontset_name, set_fontset_ascii)
2565 (set_fontset_base, set_fontset_frame, set_fontset_nofont_face)
2566 (set_fontset_default, set_fontset_fallback): Rename from their
2567 upper-case counterparts, and make them functions rather than macros.
2568 This is more consistent with the other recently-introduced setters.
2569 These don't need to be inline, since they're local.
2570
d18e2bb6
JD
25712012-08-21 Jan Djärv <jan.h.d@swipnet.se>
2572
2573 * nsterm.m (fd_handler:): Alloc and release a NSAutoreleasePool in
2574 the loop (Bug#12247).
2575
1b9d9d16
PE
25762012-08-21 Paul Eggert <eggert@cs.ucla.edu>
2577
2578 * lisp.h (vcopy): Use memcpy rather than our own loop.
2579 This fixes a performance regression introduced by the recent
2580 addition of vcopy. This means 'vcopy' will need to be modified
2581 for a copying collector, but that's OK. Also, tighten the
2582 checking in the assertion.
2583
b2f09701
EZ
25842012-08-21 Eli Zaretskii <eliz@gnu.org>
2585
2586 * w32uniscribe.c (uniscribe_shape): Fix producing gstring
2587 components for RTL text (Bug#11860). Adjust X-OFFSET of each
2588 non-base glyph for the width of the base character, according to
e1f29348
BR
2589 what x_draw_composite_glyph_string_foreground expects.
2590 Generate WADJUST value according to composition_gstring_width's
b2f09701
EZ
2591 expectations, to produce correct width of the composed character.
2592 Reverse the sign of the DU offset produced by ScriptPlace.
2593
9b994fed
PE
25942012-08-21 Paul Eggert <eggert@cs.ucla.edu>
2595
2596 * dbusbind.c (xd_remove_watch): Do not assume C99 comments.
2597
086ca913
DA
25982012-08-21 Dmitry Antipov <dmantipov@yandex.ru>
2599
2600 Avoid direct writes to contents member of struct Lisp_Vector.
2601 * lisp.h (vcopy): New function to copy data into vector.
2602 * dispnew.c (Fframe_or_buffer_changed_p): Use AREF and ASET.
2603 * fns.c (Ffillarray): Use ASET.
2604 * keyboard.c (timer_check_2): Use AREF and ASET.
2605 (append_tool_bar_item, Frecent_keys): Use vcopy.
2606 * lread.c (read_vector): Use ASET.
2607 * msdos.c (Frecent_doskeys): Use vcopy.
2608 * xface.c (Finternal_copy_lisp_face): Use vcopy.
2609 (Finternal_merge_in_global_face): Use ASET and vcopy.
2610 * xfont.c (xfont_list_pattern): Likewise.
2611
5481664a
MR
26122012-08-21 Martin Rudalics <rudalics@gmx.at>
2613
2614 * window.c (Fwindow_point): For the selected window always return
2615 the position of its buffer's point.
2616 (Fset_window_point): For the selected window always go in its
2617 buffer to the specified position.
2618
6d470bdd
DA
26192012-08-21 Dmitry Antipov <dmantipov@yandex.ru>
2620
2621 Setter macros for fontsets.
2622 * fontset.c (SET_FONTSET_ID, SET_FONTSET_NAME, SET_FONTSET_ASCII)
2623 (SET_FONTSET_BASE, SET_FONTSET_FRAME, SET_FONTSET_NOFONT_FACE)
2624 (SET_FONTSET_DEFAULT, SET_FONTSET_FALLBACK): New macros.
2625 Adjust users.
2626
24564fe1
GM
26272012-08-20 Glenn Morris <rgm@gnu.org>
2628
2629 * Makefile.in (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
2630 Don't assume that `ln -f' works.
2631
0a05a035
EZ
26322012-08-20 Eli Zaretskii <eliz@gnu.org>
2633
2634 * .gdbinit: Use "set $dummy = ..." to avoid warnings from GDB 7.5
2635 and later about non-assignments with no effect. See discussion at
2636 http://sourceware.org/ml/gdb-patches/2012-08/msg00518.html for
2637 details.
2638
e46f2325
DA
26392012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
2640
2641 Inline setter functions for Lisp_Objects slots of struct specbinding.
2642 * eval.c (set_specpdl_symbol, set_specpdl_old_value): New functions.
2643 Adjust users.
2644
734fbd86
MR
26452012-08-20 Martin Rudalics <rudalics@gmx.at>
2646
2647 * window.c (select_window): Always make selected window's buffer
2648 current.
2649
f1a95992
DA
26502012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
2651
2652 Use AREF and ASET for docstrings of category tables.
2653 * category.h (CATEGORY_DOCSTRING): Use AREF.
2654 (SET_CATEGORY_DOCSTRING): Use ASET.
2655 * category.c (Fdefine_category): Use SET_CATEGORY_DOCSTRING.
2656
e83064be
DA
26572012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
2658
2659 Inline setter functions for hash table members.
2660 * lisp.h (set_hash_key, set_hash_value, set_hash_next)
2661 (set_hash_hash, set_hash_index): Rename with _slot suffix.
2662 (set_hash_key_and_value, set_hash_index, set_hash_next)
2663 (set_hash_hash): New functions.
2664 * charset.c, fns.c: Adjust users.
2665
4ce60d2e
DA
26662012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
2667
2668 Inline getter and setter functions for per-buffer values.
2669 * buffer.h (per_buffer_default, set_per_buffer_default)
2670 (per_buffer_value, set_per_buffer_value): New functions.
2671 (PER_BUFFER_VALUE, PER_BUFFER_DEFAULT): Remove.
2672 * buffer.c, data.c: Adjust users.
2673
c06c9690
JB
26742012-08-20 Juanma Barranquero <lekktu@gmail.com>
2675
2676 * makefile.w32-in ($(BLD)/vm-limit.$(O)): Update dependencies.
2677
32bd4250
PE
26782012-08-19 Paul Eggert <eggert@cs.ucla.edu>
2679
bad03192 2680 Rely on <config.h> + <unistd.h> to declare 'environ',
b69a6d22
PE
2681 as gnulib does this if the system doesn't.
2682 * callproc.c, editfns.c, process.c (environ) [!USE_CRT_DLL]:
72279493
EZ
2683 Remove declaration. MS-Windows declares it on stdlib.h which is
2684 included by conf_post.h.
b69a6d22
PE
2685 * emacs.c (environ) [DOUG_LEA_MALLOC]:
2686 * vm-limit.c (environ) [ORDINARY_LINK]: Remove decl.
2687 * vm-limit.c: Include <unistd.h>, for 'environ'.
2688
22d7feb2
PE
2689 * unexaix.c, unexcoff.c: Include "mem-limits.h".
2690 (start_of_data): Remove decl; mem-limits.h provides it.
2691
32bd4250
PE
2692 * xdisp.c (handle_invisible_prop): Make it a bit faster
2693 and avoid a gcc -Wmaybe-uninitialized diagnostic.
2694
450809af
CY
26952012-08-19 Chong Yidong <cyd@gnu.org>
2696
2697 * xdisp.c (handle_invisible_prop): Fix ellipses at overlay string
2698 ends (Bug#3874).
2699
9e677988
AS
27002012-08-19 Andreas Schwab <schwab@linux-m68k.org>
2701
6b1319ce
AS
2702 * .gdbinit: Use call instead of set when calling a function in the
2703 inferior.
2704
9e677988
AS
2705 * data.c (set_internal): Don't use set_blv_found.
2706 (Fkill_local_variable): Likewise.
2707
d7191076
AA
27082012-08-18 Alp Aker <alp.tekin.aker@gmail.com>
2709
2710 * nsfont.m (ns_ascii_average_width): Ensure the string
2711 ascii_printable is initialized with a null-terminated character
2712 array. Otherwise, it can contain undesired extra characters.
2713
e757f1c6
PE
27142012-08-18 Paul Eggert <eggert@cs.ucla.edu>
2715
2716 port new setting code to Sun C 5.8 2005/10/13
2717 * chartab.c, lisp.h (char_table_set, char_table_set_range):
2718 Return void, not Lisp_Object. Otherwise, the compiler
2719 complains about (A?B:C) where B is void and C is Lisp_Object
2720 when compiling CHAR_TABLE_SET, due to the recent change to
2721 the API of sub_char_table_set_contents.
2722
a999ce26
CY
27232012-08-18 Chong Yidong <cyd@gnu.org>
2724
2725 * xdisp.c (handle_invisible_prop): Obey TEXT_PROP_MEANS_INVISIBLE
2726 for the string case (Bug#3874).
2727
3f22b86f
PE
27282012-08-18 Paul Eggert <eggert@cs.ucla.edu>
2729
39eb03f1
PE
2730 * buffer.h (BSET): Remove (Bug#12215).
2731 Replace all uses with calls to new setter functions.
2732 (bset_bidi_paragraph_direction, bset_case_canon_table)
2733 (bset_case_eqv_table, bset_directory, bset_display_count)
2734 (bset_display_time, bset_downcase_table)
2735 (bset_enable_multibyte_characters, bset_filename, bset_keymap)
2736 (bset_last_selected_window, bset_local_var_alist)
2737 (bset_mark_active, bset_point_before_scroll, bset_read_only)
2738 (bset_truncate_lines, bset_undo_list, bset_upcase_table)
2739 (bset_width_table):
2740 * buffer.c (bset_abbrev_mode, bset_abbrev_table)
2741 (bset_auto_fill_function, bset_auto_save_file_format)
2742 (bset_auto_save_file_name, bset_backed_up, bset_begv_marker)
2743 (bset_bidi_display_reordering, bset_buffer_file_coding_system)
2744 (bset_cache_long_line_scans, bset_case_fold_search)
2745 (bset_ctl_arrow, bset_cursor_in_non_selected_windows)
2746 (bset_cursor_type, bset_display_table, bset_extra_line_spacing)
2747 (bset_file_format, bset_file_truename, bset_fringe_cursor_alist)
2748 (bset_fringe_indicator_alist, bset_fringes_outside_margins)
2749 (bset_header_line_format, bset_indicate_buffer_boundaries)
2750 (bset_indicate_empty_lines, bset_invisibility_spec)
2751 (bset_left_fringe_width, bset_major_mode, bset_mark)
2752 (bset_minor_modes, bset_mode_line_format, bset_mode_name)
2753 (bset_name, bset_overwrite_mode, bset_pt_marker)
2754 (bset_right_fringe_width, bset_save_length)
2755 (bset_scroll_bar_width, bset_scroll_down_aggressively)
2756 (bset_scroll_up_aggressively, bset_selective_display)
2757 (bset_selective_display_ellipses, bset_vertical_scroll_bar_type)
2758 (bset_word_wrap, bset_zv_marker):
2759 * category.c (bset_category_table):
2760 * syntax.c (bset_syntax_table):
2761 New setter functions.
2762
6a09a33b
PE
2763 * process.h (PSET): Remove (Bug#12215).
2764 Replace all uses with calls to new setter functions.
2765 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
2766 (PROCESS_INLINE): New macro.
2767 (pset_childp): New setter function.
2768 (pset_gnutls_cred_type) [HAVE_GNUTLS]: New setter function.
2769 * process.c (PROCESS_INLINE):
2770 Define to EXTERN_INLINE, so that the corresponding functions
2771 are compiled into code.
2772 (pset_buffer, pset_command, pset_decode_coding_system)
2773 (pset_decoding_buf, pset_encode_coding_system)
2774 (pset_encoding_buf, pset_filter, pset_log, pset_mark, pset_name)
2775 (pset_plist, pset_sentinel, pset_status, pset_tty_name)
2776 (pset_type, pset_write_queue): New setter functions.
2777
e8c17b81
PE
2778 * window.h (WSET): Remove (Bug#12215).
2779 Replace all uses with calls to new setter functions.
2780 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
2781 (WINDOW_INLINE): New macro.
2782 (wset_buffer, wset_frame, wset_left_col, wset_next, wset_prev)
2783 (wset_redisplay_end_trigger, wset_top_line, wset_total_cols)
2784 (wset_total_lines, wset_vertical_scroll_bar)
2785 (wset_window_end_pos, wset_window_end_valid)
2786 (wset_window_end_vpos): New setter functions.
2787 * window.c (WINDOW_INLINE):
2788 Define to EXTERN_INLINE, so that the corresponding functions
2789 are compiled into code.
2790 (wset_combination_limit, wset_dedicated, wset_display_table)
2791 (wset_hchild, wset_left_fringe_width, wset_left_margin_cols)
2792 (wset_new_normal, wset_new_total, wset_next_buffers)
2793 (wset_normal_cols, wset_normal_lines, wset_parent, wset_pointm)
2794 (wset_prev_buffers, wset_right_fringe_width)
2795 (wset_right_margin_cols, wset_scroll_bar_width, wset_start)
2796 (wset_temslot, wset_vchild, wset_vertical_scroll_bar_type)
2797 (wset_window_parameters):
2798 * xdisp.c (wset_base_line_number, wset_base_line_pos)
2799 (wset_column_number_displayed, wset_region_showing):
2800 New setter functions.
2801
3f22b86f
PE
2802 * termhooks.h (TSET): Remove (Bug#12215).
2803 Replace all uses with calls to new setter functions.
2804 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
2805 (TERMHOOKS_INLINE): New macro.
2806 (tset_charset_list, tset_selection_alist): New setter functions.
2807 * terminal.c (TERMHOOKS_INLINE):
2808 Define to EXTERN_INLINE, so that the corresponding functions
2809 are compiled into code.
2810 (tset_param_alist): New setter function.
2811
742af32f
PE
28122012-08-17 Paul Eggert <eggert@cs.ucla.edu>
2813
15dbb4d6
PE
2814 * keyboard.h (KSET): Remove (Bug#12215).
2815 Replace all uses with calls to new setter functions.
2816 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
2817 (KEYBOARD_INLINE): New macro.
2818 (kset_default_minibuffer_frame, kset_defining_kbd_macro)
2819 (kset_input_decode_map, kset_last_command, kset_last_kbd_macro)
2820 (kset_prefix_arg, kset_system_key_alist, kset_window_system):
2821 New setter functions.
2822 * keyboard.c (KEYBOARD_INLINE):
2823 Define to EXTERN_INLINE, so that the corresponding functions
2824 are compiled into code.
2825 (kset_echo_string, kset_kbd_queue)
2826 (kset_keyboard_translate_table, kset_last_prefix_arg)
2827 (kset_last_repeatable_command, kset_local_function_key_map)
2828 (kset_overriding_terminal_local_map, kset_real_last_command)
2829 (kset_system_key_syms): New setter functions.
2830
f00af5b1
PE
2831 * frame.h (FSET): Remove (Bug#12215).
2832 Replace all uses with calls to new setter functions.
2833 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
2834 (FRAME_INLINE): New macro.
2835 (fset_buffer_list, fset_buried_buffer_list, fset_condemned_scroll_bars)
2836 (fset_current_tool_bar_string, fset_desired_tool_bar_string)
2837 (fset_face_alist, fset_focus_frame, fset_icon_name, fset_menu_bar_items)
2838 (fset_menu_bar_vector, fset_menu_bar_window, fset_name)
2839 (fset_param_alist, fset_root_window, fset_scroll_bars)
2840 (fset_selected_window, fset_title, fset_tool_bar_items)
2841 (fset_tool_bar_position, fset_tool_bar_window): New functions.
2842 * frame.c (FRAME_INLINE):
2843 Define to EXTERN_INLINE, so that the corresponding functions
2844 are compiled into code.
2845 (fset_buffer_predicate, fset_minibuffer_window): New setter functions.
2846
0c94c8d6
PE
2847 A few more naming-convention fixes for getters and setters.
2848 * buffer.c (set_buffer_overlays_before): Move here from buffer.h,
2849 and rename from buffer_overlays_set_before.
2850 (set_buffer_overlays_after): Move here from buffer.h, and rename
2851 from buffer_overlays_set_after.
2852 * buffer.h (buffer_intervals): Rename from buffer_get_intervals.
2853 All uses changed.
2854 (set_buffer_intervals): Rename from buffer_set_intervals.
2855 * intervals.c (set_interval_object): Move here from intervals.h,
2856 and rename from interval_set_object.
2857 (set_interval_left): Move here from intervals.h, and rename from
2858 interval_set_left.
2859 (set_interval_right): Move here from intervals.h, and rename from
2860 interval_set_right.
2861 (copy_interval_parent): Move here from intervals.h, and rename from
2862 interval_copy_parent.
2863 * intervals.h (set_interval_parent): Rename from interval_set_parent.
2864 (set_interval_plist): Rename from interval_set_plist.
2865 Return void, not Lisp_Object, since no caller uses the result.
2866 * lisp.h (string_intervals): Rename from string_get_intervals.
2867 (set_string_intervals): Rename from string_set_intervals.
2868
34dabdb7
PE
2869 * lisp.h (set_char_table_extras): Rename from char_table_set_extras.
2870 (set_char_table_contents): Rename from char_table_set_contents.
0b390a9d 2871 (set_sub_char_table_contents): Rename from sub_char_table_set_contents.
34dabdb7
PE
2872 All uses changed. See the end of
2873 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00549.html>.
2874
742af32f
PE
2875 * lisp.h (CSET): Remove (Bug#12215).
2876 (set_char_table_ascii, set_char_table_defalt, set_char_table_parent)
2877 (set_char_table_purpose): New functions,
2878 replacing CSET. All uses changed. For example, replace
2879 "CSET (XCHAR_TABLE (char_table), parent, parent);" with
c24eb18a 2880 "set_char_table_parent (char_table, parent);".
742af32f
PE
2881 The old version was confusing because it used the same name
2882 'parent' for two different things.
2883
a04e2c62
DA
28842012-08-17 Dmitry Antipov <dmantipov@yandex.ru>
2885
2886 Functions to get and set Lisp_Object fields of buffer-local variables.
2887 * lisp.h (blv_found, set_blv_found, blv_value, set_blv_value)
2888 (set_blv_where, set_blv_defcell, set_blv_valcell): New functions.
2889 (BLV_FOUND, SET_BLV_FOUND, BLV_VALUE, SET_BLV_VALUE): Remove.
2890 * data.c, eval.c, frame.c: Adjust users.
2891
383dcbf9
CY
28922012-08-17 Chong Yidong <cyd@gnu.org>
2893
2894 * xfaces.c (merge_face_vectors): If the target font specfies a
2895 font spec, make the font's attributes take precedence over
2896 directly-specified attributes.
2897 (merge_face_ref): Recognize :font.
2898
44386687
DA
28992012-08-17 Dmitry Antipov <dmantipov@yandex.ru>
2900
2901 Do not use memcpy for copying intervals.
2902 * intervals.c (reproduce_interval): New function.
2903 (reproduce_tree, reproduce_tree_obj): Use it.
2904 (reproduce_tree_obj): Remove prototype.
2905
927c7216
PE
29062012-08-17 Paul Eggert <eggert@cs.ucla.edu>
2907
2908 * lisp.h (duration_to_sec_usec): Remove unused decl.
2909
93044f7b
AA
29102012-08-17 Alp Aker <alp.tekin.aker@gmail.com>
2911
2912 * nsfont.m (ns_ascii_average_width): Send initWithFormat selector
2913 to an allocated instance of NSString, not to the class itself.
2914
9851e4a5
JB
29152012-08-17 Juanma Barranquero <lekktu@gmail.com>
2916
2917 * makefile.w32-in (C_CTYPE_H): New macro.
2918 (LISP_H, $(BLD)/ccl.$(O), $(BLD)/doc.$(O), $(BLD)/w32console.$(O)):
2919 ($(BLD)/fontset.$(O), $(BLD)/frame.$(O), $(BLD)/composite.$(O)):
2920 ($(BLD)/sysdep.$(O), $(BLD)/w32uniscribe.$(O)): Update dependencies.
2921
620f13b0
PE
29222012-08-16 Paul Eggert <eggert@cs.ucla.edu>
2923
2924 Use ASCII tests for character types.
2925 * category.c, dispnew.c, doprnt.c, editfns.c, syntax.c, term.c:
2926 * xfns.c, xterm.c:
2927 Don't include <ctype.h>; was not needed.
2928 * charset.c, doc.c, fileio.c, font.c, frame.c, gtkutil.c, image.c:
2929 * sysdep.c, xfaces.c:
2930 Include <c-ctype.h> instead of <ctype.h>.
2931 * nsterm.m: Include <c-ctype.h>.
2932 * charset.c (read_hex):
2933 * doc.c (Fsnarf_documentation):
2934 * fileio.c (IS_DRIVE) [WINDOWSNT]:
2935 (DRIVE_LETTER) [DOS_NT]:
2936 (Ffile_name_directory, Fexpand_file_name)
2937 (Fsubstitute_in_file_name):
2938 * font.c (font_parse_xlfd, font_parse_fcname):
2939 * frame.c (x_set_font_backend):
2940 * gtkutil.c (xg_get_font):
2941 * image.c (xbm_scan, xpm_scan, pbm_scan_number):
2942 * nsimage.m (hexchar):
2943 * nsterm.m (ns_xlfd_to_fontname):
2944 * sysdep.c (system_process_attributes):
2945 * xfaces.c (hash_string_case_insensitive):
2946 Use C-locale tests instead of locale-specific tests for character
2947 types, since we want the ASCII interpretation here, not the
2948 interpretation suitable for whatever happens to be the current locale.
2949
52162052
MR
29502012-08-16 Martin Rudalics <rudalics@gmx.at>
2951
2952 Consistently check windows for validity/liveness
2953 (Bug#11984, Bug#12025, Bug#12026).
2954 * lisp.h (CHECK_VALID_WINDOW): New macro.
2955 * window.c (decode_window): Rename to decode_live_window.
2956 (decode_valid_window, Fwindow_valid_p): New functions.
2957 (Fwindow_frame, Fframe_root_window, Fwindow_minibuffer_p)
2958 (Fframe_first_window, Fframe_selected_window, Fwindow_parent)
2959 (Fwindow_top_child, Fwindow_left_child, Fwindow_next_sibling)
2960 (Fwindow_prev_sibling, Fwindow_combination_limit)
2961 (Fset_window_combination_limit, Fwindow_use_time)
2962 (Fwindow_total_height, Fwindow_total_width, Fwindow_new_total)
2963 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_left_column)
2964 (Fwindow_top_line, Fwindow_body_height, Fwindow_body_width)
2965 (Fwindow_hscroll, Fset_window_hscroll)
2966 (Fwindow_redisplay_end_trigger)
2967 (Fset_window_redisplay_end_trigger, Fwindow_edges)
2968 (Fwindow_pixel_edges, Fwindow_absolute_pixel_edges)
2969 (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
2970 (Fcoordinates_in_window_p, Fwindow_point, Fwindow_start)
2971 (Fwindow_end, Fset_window_point, Fset_window_start)
2972 (Fpos_visible_in_window_p, Fwindow_line_height)
2973 (Fwindow_dedicated_p, Fset_window_dedicated_p)
2974 (Fwindow_prev_buffers, Fset_window_prev_buffers)
2975 (Fwindow_next_buffers, Fwindow_parameters, Fwindow_parameter)
2976 (Fset_window_parameter, Fwindow_display_table)
2977 (Fset_window_display_table, Fdelete_other_windows_internal)
2978 (Fset_window_buffer, Fset_window_new_total)
2979 (Fset_window_new_normal, Fdelete_window_internal)
2980 (Fwindow_text_height, Fset_window_margins, Fwindow_margins)
2981 (Fset_window_fringes, Fwindow_fringes, Fset_window_scroll_bars)
2982 (Fwindow_scroll_bars): Check whether argument window is a valid or
2983 live window. Update doc-strings.
2984 (syms_of_window): New symbol Qwindow_valid_p.
2985 * keyboard.c (Fposn_at_x_y): Check whether argument
2986 frame_or_window denotes a valid window.
2987
2751c80f
DA
29882012-08-16 Dmitry Antipov <dmantipov@yandex.ru>
2989
2990 Fix previous char table change.
2991 * lisp.h (CHAR_TABLE_SET): Use sub_char_table_set_contents.
2992 * chartab.c (optimize_sub_char_table): Likewise.
2993
032a42c8
CY
29942012-08-16 Chong Yidong <cyd@gnu.org>
2995
a2d19368
CY
2996 * gtkutil.c (xg_get_font): Demand an Xft font (Bug#3228).
2997
032a42c8
CY
2998 * xfont.c (xfont_open):
2999 * xftfont.c (xftfont_open): Set the font's max_width field.
3000
3001 * nsfont.m (nsfont_open): Similar to the Xft backend, set
3002 min_width to space_width and average_width to the average over
3003 printable ASCII characters.
3004 (ns_char_width): Code cleanup.
3005 (ns_ascii_average_width): New utility function.
3006
3007 * font.h (struct font): Update comments.
3008
a098c930
DA
30092012-08-16 Dmitry Antipov <dmantipov@yandex.ru>
3010
032a42c8 3011 Simple interface to set Lisp_Object fields of character tables.
a098c930
DA
3012 * lisp.h (CSET): New macro.
3013 (char_table_set_extras, char_table_set_contents)
3014 (sub_char_table_set_contents): New function.
3015 * casetab.c, category.c, chartab.c, fns.c, fontset.c, search.c:
3016 * syntax.c: Adjust users.
3017
8be3a09c
SM
30182012-08-16 Stefan Monnier <monnier@iro.umontreal.ca>
3019
3020 * eval.c (eval_sub): Bind lexical-binding.
3021 * lread.c (Qlexical_binding): Make non-static.
3022
ac4845a6
JD
30232012-08-15 Jan Djärv <jan.h.d@swipnet.se>
3024
ddee6515
JD
3025 * nsmenu.m (popupSession): Remove.
3026 (pop_down_menu): Remove endModalSession.
3027 (timeout_handler:): New method.
3028 (runDialogAt:): Get next timeout. Start a NSTimer with that timeout.
3029 Call runModalForWindow. Check timer_fired when it returns.
3030 If not set, cancel timer and break out of loop.
3031 Otherwise loop again, with a new timeout.
3032
3033 * nsterm.m: Include fcntl.h if present.
3034 (fd_entry, t_readfds, inNsSelect): Remove.
3035 (select_writefds, select_valid, select_timeout, selfds)
3036 (select_mutex, apploopnr): Add.
3037 (EV_TRAILER): Call kbd_buffer_store_event_hold only if q_event_ptr.
3038 Otherwise call kbd_buffer_store_event.
3039 (ns_send_appdefined): Remove release of fd_entry.
3040 (ns_read_socket): Always send appdefined. Remove inNsSelect check.
3041 Increment and decrement apploopnr.
3042 (ns_select): If no file descriptors, just do a NSTimer.
3043 Otherwise copy read/write masks and start select thread (fd_handler).
3044 Start main loop and wait for application defined event.
3045 Inform select thread to stop selecting after main loop is exited.
3046 (ns_term_init): Create selfds pipe and set non-blocking.
fc0c31f8 3047 Initialize select_mutex. Start the select thread (fd_handler).
ddee6515
JD
3048 (fd_handler:): Loop forever, wait for info from the main thread
3049 to either start or stop selecting. When select returns, send
3050 and appdefined event.
3051 (sendScrollEventAtLoc:fromEvent:): Check if q_event_ptr is set.
3052 If not call kbd_buffer_store_event.
3053
3054 * nsterm.h (EmacsApp): fd_handler takes id argument.
3055 (EmacsDialogPanel): Add timer_fired and timeout_handler.
3056
ac4845a6
JD
3057 * gtkutil.c (xg_mark_data): Use FRAME_X_P.
3058
eb424fe3
EZ
30592012-08-15 Eli Zaretskii <eliz@gnu.org>
3060
3061 * region-cache.c (move_cache_gap): Update gap_len using the actual
3062 growth of the boundaries array. Do not change cache_len.
3063 (Bug#12196)
3064
4e6a86c6
DA
30652012-08-15 Dmitry Antipov <dmantipov@yandex.ru>
3066
3067 Generalize and cleanup font subsystem checks.
3068 * font.h (FONT_DEBUG, font_assert): Remove.
8be3a09c
SM
3069 * font.c, fontset.c, w32font.c, xfont.c, xftfont.c:
3070 Change font_assert to eassert. Use eassert where appropriate.
4e6a86c6 3071
5bf192ca
DA
30722012-08-15 Dmitry Antipov <dmantipov@yandex.ru>
3073
3074 * gtkutil.c (xg_get_font): Use pango_units_to_double.
3075
f2045622
CY
30762012-08-15 Chong Yidong <cyd@gnu.org>
3077
8be3a09c
SM
3078 * gtkutil.c (xg_get_font): Rename from xg_get_font_name.
3079 When using the new font chooser, use gtk_font_chooser_get_font_desc to
3080 extract the font descriptor instead of just the font name.
3081 In that case, return a font spec instead of a string.
f2045622
CY
3082 (x_last_font_name): Move to this file from xfns.c.
3083
3084 * xfns.c (Fx_select_font): The return value can also be a font
3085 spec. Move x_last_font_name management to gtkutil.c.
3086
3087 * xfaces.c: Make font weight and style symbols non-static.
3088
7f6feb56
SM
30892012-08-15 Stefan Monnier <monnier@iro.umontreal.ca>
3090
3091 * minibuf.c (read_minibuf): Ignore caller's inhibit-read-only
3092 (bug#12117).
3093
fecbd8ff
SM
30942012-08-14 Stefan Monnier <monnier@iro.umontreal.ca>
3095
3096 * alloc.c (Fgarbage_collect): Use plural form consistently.
3097
9b8d5165
EZ
30982012-08-14 Eli Zaretskii <eliz@gnu.org>
3099
3100 * keyboard.c (command_loop_1): Reset ignore_mouse_drag_p flag each
3101 iteration through the command loop. Fixes a problem whereby mouse
3102 movements are ignored until the first mouse click.
3103
f5d9e83a
PE
31042012-08-14 Paul Eggert <eggert@cs.ucla.edu>
3105
3106 Use bool, not int, for Lisp booleans.
3107 This is more natural, and on my platform (GCC 4.7.1 x86-64) it
3108 makes Emacs a bit smaller and presumably a bit faster.
3109 * lisp.h: Include <stdbool.h>.
3110 (struct Lisp_Boolfwd, defvar_bool):
3111 * lread.c (defvar_bool): Use bool, not int, for Lisp booleans.
3112 * regex.c [!emacs]: Include <stdbool.h>.
3113 (false, true): Remove; <stdbool.h> does this for us now.
3114
55802e4a
CY
31152012-08-14 Chong Yidong <cyd@gnu.org>
3116
4abcdac8
CY
3117 * character.c (Fcharacterp): Doc fix (Bug#12076).
3118
3119 * data.c (Findirect_variable): Doc fix (Bug#11040).
3120
55802e4a
CY
3121 * chartab.c (Fmap_char_table): Doc fix (Bug#12061).
3122
3123 * editfns.c (Fformat): Doc fix (Bug#12059).
4abcdac8 3124 (Fsave_current_buffer): Doc fix (Bug#11542).
55802e4a 3125
8e99d072
BR
31262012-08-14 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
3127
3128 * keyboard.c (access_keymap_keyremap): Accept anonymous functions
3129 (bug#12022).
3130
08908aca
MR
31312012-08-14 Martin Rudalics <rudalics@gmx.at>
3132
3133 * frame.c (make_frame_without_minibuffer, make_minibuffer_frame)
3134 (delete_frame, Fmake_frame_invisible, Ficonify_frame):
3135 * minibuf.c (choose_minibuf_frame, read_minibuf):
3136 * w32fns.c (x_create_tip_frame):
3137 * xfns.c (x_create_tip_frame): Call set_window_buffer instead of
3138 Fset_window_buffer (Bug#11984, Bug#12025, Bug#12026).
3139
56120d6f
PE
31402012-08-14 Paul Eggert <eggert@cs.ucla.edu>
3141
3142 * intervals.c (offset_intervals): Remove obsolete comment.
3143
67b77c0b
AS
31442012-08-14 Andreas Schwab <schwab@linux-m68k.org>
3145
3146 * gtkutil.c (find_rtl_image, update_frame_tool_bar): Use NILP.
3147
f48b82fd
GR
31482012-08-14 Gergely Risko <gergely@risko.hu>
3149
3150 * coding.c (decode_coding): Record buffer modification before
3151 disabling undo_list (Bug#11773).
3152
fd318b54
DA
31532012-08-14 Dmitry Antipov <dmantipov@yandex.ru>
3154
3155 Revert and cleanup some recent overlay changes.
3156 * buffer.h (enum overlay_type): Remove.
3157 (buffer_get_overlays, buffer_set_overlays): Likewise.
3158 (buffer_set_overlays_before, buffer_set_overlays_after):
3159 New function. Adjust users.
3160 (unchain_both): Add eassert.
3161
41a62dd9
DA
31622012-08-14 Dmitry Antipov <dmantipov@yandex.ru>
3163
3164 * gtkutil.c (update_frame_tool_bar): Use EQ where appropriate.
3165
5884c324
PE
31662012-08-14 Paul Eggert <eggert@cs.ucla.edu>
3167
3168 * gtkutil.c (xg_mark_data): Don't assume C99.
3169
ca06f160
JD
31702012-08-13 Jan Djärv <jan.h.d@swipnet.se>
3171
3172 * gtkutil.c (xg_frame_tb_info): New struct.
3173 (TB_INFO_KEY): New define.
3174 (xg_free_frame_widgets): Free xg_frame_tb_info for frame if present.
3175 (xg_mark_data): Mark Lisp_Objects in xg_frame_tb_info.
3176 (xg_create_tool_bar): Allocate and initialize a xg_frame_tb_info
3177 if not present.
3178 (update_frame_tool_bar): Return early if data in xg_frame_tb_info
fc0c31f8 3179 is up to date. Otherwise store new data.
ca06f160
JD
3180 (free_frame_tool_bar): Free xg_frame_tb_info if present.
3181
7864a3f7
DA
31822012-08-13 Dmitry Antipov <dmantipov@yandex.ru>
3183
3184 Use KSET for write access to Lisp_Object members of struct kboard.
3185 * keyboard.h (KSET): New macro.
3186 * callint.c, category.c, frame.c, keyboard.c, keyboard.h, macros.c:
3187 * msdos.c, nsfns.m, nsterm.m, term.c, w32fns.c, w32term.c, xfns.c:
3188 * xterm.c: Adjust users.
3189
4c31be61
DA
31902012-08-13 Dmitry Antipov <dmantipov@yandex.ru>
3191
3192 Use BSET for write access to Lisp_Object members of struct buffer.
3193 * buffer.h (BSET): New macro.
3194 * buffer.c, casetab.c, cmds.c, coding.c, data.c, editfns.c:
3195 * fileio.c, frame.c, indent.c, insdel.c, intervals.c, keymap.c:
3196 * minibuf.c, print.c, process.c, syntax.c, undo.c, w32fns.c:
3197 * window.c, xdisp.c, xfns.c: Adjust users.
3198
14ae4239
BT
31992012-08-11 BT Templeton <bpt@hcoop.net> (tiny change)
3200
3201 * lread.c (syms_of_lread): Initialize Vlexical_binding.
3202
32bcadb4
JD
32032012-08-11 Jan Djärv <jan.h.d@swipnet.se>
3204
3d29b2ce 3205 * nsterm.m (not_in_argv): New function.
fc0c31f8 3206 (application:openFile, application:openTempFile:):
3d29b2ce
JD
3207 (application:openFileWithoutUI:, application:openFiles:): Open file
3208 if not_in_argv returns non-zero (bug#12171).
3209
32bcadb4 3210 * gtkutil.c (gtk_font_chooser_dialog_new, GTK_FONT_CHOOSER)
14ae4239
BT
3211 (gtk_font_chooser_set_font, gtk_font_chooser_get_font):
3212 Define for Gtk+ versions less than 3.2.
32bcadb4
JD
3213 (xg_get_font_name): Use those functions/macros here.
3214 Reported by Frans Oilinki <moilinki@gmail.com>.
3215
9ff9402d 32162012-08-11 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8ccd072a
YM
3217
3218 * unexmacosx.c (copy_data_segment): Copy initialized data in
3219 statically linked libraries from input file rather than memory.
3220
db74a5fc
YM
3221 * unexmacosx.c (print_load_command_name): Add cases LC_MAIN,
3222 LC_SOURCE_VERSION, and LC_DYLIB_CODE_SIGN_DRS.
3223 (dump_it) [LC_DYLIB_CODE_SIGN_DRS]: Call copy_linkedit_data.
3224
25e65510
GM
32252012-08-10 Glenn Morris <rgm@gnu.org>
3226
3227 * conf_post.h (IF_LINT, lint_assume): Move here from lisp.h.
3228 * lisp.h (IF_LINT, lint_assume): Move to conf_post.h.
3229
7961135c
DA
32302012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
3231
3232 Fix last change to allow compilation with low optimization levels.
3233 * intervals.c (INTERVALS_INLINE): Define to EXTERN_INLINE.
3234 Reported by Jan Djärv <jan.h.d@swipnet.se>.
3235
42b3a444
DA
32362012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
3237
3238 Use common inline syntax in intervals.h.
3239 * intervals.h (INTERVALS_INLINE): New macro.
3240 Change all users from LISP_INLINE.
3241
9fb0c957
DA
32422012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
3243
3244 Define Qnone once for all platforms.
3245 * frame.c (Qnone): Define here.
3246 (syms_of_frame): DEFSYM it.
3247 * lisp.h (Qnone): New declaration.
3248 * nsfns.m, nsterm.h, nsterm.m, w32fns.c, w32font.c:
3249 * xfns.c: Remove duplication. Adjust users.
3250
65e8ee52
DA
32512012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
3252
3253 Remove unused macros from intervals.h.
3254 * intervals.h (MERGE_INSERTIONS, DISPLAY_INVISIBLE_GLYPH): Remove.
3255 * intervals.c: Adjust comment.
3256
9b855fd6
EZ
32572012-08-10 Eli Zaretskii <eliz@gnu.org>
3258
3259 * w32fns.c <w32_unicode_gui>: New static variable.
3260 (globals_of_w32fns): Initialize it according to os_subtype.
3261 (w32_init_class, w32_msg_pump, w32_wnd_proc): Use it instead of
3262 testing os_subtype.
3263
39cb9e56 32642012-08-10 Joakim Hårsman <joakim.harsman@gmail.com> (tiny change)
d30be705
EZ
3265 Eli Zaretskii <eliz@gnu.org>
3266
3267 Fix bug #10299 with Unicode characters sent by customized
3268 keyboards created by MSKLC.
3269 * w32fns.c (INIT_WINDOW_CLASS): New macro.
3270 (w32_init_class): Use it to initialize the Emacs class with either
3271 ANSI or Unicode API calls.
3272 (w32_msg_pump): Call GetMessageW and DispatchMessageW on NT and
3273 later.
3274 (w32_wnd_proc): If the character code sent by WM_CHAR or
3275 WM_SYSCHAR is above 255, post a WM_UNICHAR message, not the
3276 original message. Call DefWindowProcW on NT and later.
3277
9374581a
GM
32782012-08-10 Glenn Morris <rgm@gnu.org>
3279
4b94e8cf
GM
3280 * Makefile.in (config_h): Fix conf_post.h out-of-tree build location.
3281
9374581a
GM
3282 * lisp.h (DIRECTORY_SEP): Let configure set it.
3283
a2752828
DA
32842012-08-09 Dmitry Antipov <dmantipov@yandex.ru>
3285
3286 Use TSET for write access to Lisp_Object slots of struct terminal.
3287 * termhooks.h (TSET): New macro.
3288 * coding.c, terminal.c, xselect.c: Adjust users.
3289
cc92c454
SM
32902012-08-08 Stefan Monnier <monnier@iro.umontreal.ca>
3291
3292 * xdisp.c (safe_eval_handler): Remove prototype. Receive args describing
3293 the failing expression, include them in the error message.
3294 * eval.c (internal_condition_case_n): Pass nargs and args to hfun.
3295 * lisp.h (internal_condition_case_n): Update declaration.
3296
4cb3e6b3
DA
32972012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
3298
3299 Inline functions to examine and change buffer overlays.
3300 * buffer.c (unchain_both): New function.
3301 * buffer.h (buffer_get_overlays, buffer_set_overlays):
3302 (buffer_has_overlays): New function.
3303 (enum overlay_type): New enum.
3304 * alloc.c, buffer.c, editfns.c, fileio.c, indent.c:
3305 * insdel.c, intervals.c, print.c, xdisp.c: Adjust users.
3306
8707c1e5
DA
33072012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
3308
3309 Inline functions to examine and change buffer intervals.
3310 * alloc.c (mark_interval_tree): Remove.
3311 (MARK_INTERVAL_TREE): Simplify.
3312 (UNMARK_BALANCE_INTERVALS): Remove. Adjust users.
3313 * intervals.c (buffer_balance_intervals): New function.
3314 (graft_intervals_into_buffer): Adjust indentation.
3315 (set_intervals_multibyte): Simplify.
3316 * buffer.h (BUF_INTERVALS): Remove.
3317 (buffer_get_intervals, buffer_set_intervals): New function.
3318 * alloc.c, buffer.c, editfns.c, fileio.c, indent.c, insdel.c:
3319 * intervals.c, textprop.c: Adjust users.
3320
ad8c997f
DA
33212012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
3322
3323 Inline functions to examine and change string intervals.
3324 * lisp.h (STRING_INTERVALS, STRING_SET_INTERVALS): Remove.
3325 (string_get_intervals, string_set_intervals): New function.
3326 * alloc.c, buffer.c, editfns.c, fns.c, insdel.c, intervals.c:
3327 * lread.c, print.c, textprop.c: Adjust users.
3328
32ac3a6b
GM
33292012-08-08 Glenn Morris <rgm@gnu.org>
3330
3331 * lisp.mk (lisp): Remove language/persian.elc.
3332
77c7bcb1
DA
33332012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
3334
3335 Cleanup intervals.
3336 * intervals.h (NULL_INTERVAL, DEFAULT_INTERVAL): Remove.
3337 (NULL_INTERVAL_P): Likewise. Adjust users.
14ae4239
BT
3338 (FRONT_STICKY_P, END_NONSTICKY_P, FRONT_NONSTICKY_P):
3339 Adjust comment. Move under #if 0.
77c7bcb1
DA
3340 * alloc.c, buffer.c, editfns.c, fns.c, insdel.c, intervals.c:
3341 * print.c, syntax.c, textprop.c, xdisp.c: Adjust users.
3342
9c08a8d4
DA
33432012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
3344
3345 Check total length of intervals with eassert.
3346 * intervals.h (CHECK_TOTAL_LENGTH): Remove.
3347 * intervals.c: Change all users to eassert.
3348
26d16b35
EZ
33492012-08-07 Eli Zaretskii <eliz@gnu.org>
3350
14ae4239
BT
3351 * .gdbinit (xframe, xwindow, nextcons, xcar, xcdr, xlist):
3352 Rename fields to match removal of FGET and WGET and disuse of
26d16b35
EZ
3353 INTERNAL_FIELD in Lisp_Cons.
3354
c644523b
DA
33552012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
3356
3357 Revert and cleanup Lisp_Cons, Lisp_Misc and Lisp_Symbol things.
3358 * lisp.h (struct Lisp_Symbol): Change xname to meaningful
3359 name since all xname users are fixed long time ago. Do not
3360 use INTERNAL_FIELD.
3361 (set_symbol_name, set_symbol_function, set_symbol_plist):
3362 (set_symbol_next, set_overlay_plist): New function.
3363 (struct Lisp_Cons): Do not use INTERNAL_FIELD.
3364 (struct Lisp_Overlay): Likewise.
3365 (CVAR, MVAR, SVAR): Remove.
3366 * alloc.c, buffer.c, buffer.h, bytecode.c, cmds.c, data.c:
3367 * doc.c, eval.c, fns.c, keyboard.c, lread.c, nsselect.m:
3368 * xterm.c: Adjust users.
3369 * .gdbinit: Change to use name field of struct Lisp_Symbol
3370 where appropriate.
3371
6a3d20cc
DA
33722012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
3373
3374 Basic functions to set Lisp_Object and pointer slots of intervals.
3375 * intervals.h (interval_set_parent, interval_set_object):
3376 (interval_set_left, interval_set_right, interval_set_plist):
3377 (interval_copy_parent): New function.
3378 (SET_INTERVAL_OBJECT, SET_INTERVAL_PARENT, INTERVAL_PTR_SIZE): Remove.
14ae4239
BT
3379 (RESET_INTERVAL, COPY_INTERVAL_CACHE, MERGE_INTERVAL_CACHE):
3380 Adjust indentation.
6a3d20cc
DA
3381 (INTERVAL_SIZE): Remove. Adjust users.
3382 * alloc.c, intervals.c, lread.c, textprop.c: Use new functions.
3383
4d2b044c
DA
33842012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
3385
3386 Drop PGET and revert read access to Lisp_Objects slots of Lisp_Process.
3387 * process.h (PGET): Remove.
3388 (struct Lisp_Process): Do not use INTERNAL_FIELD.
3389 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
3390
d3d50620
DA
33912012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
3392
3393 Drop WGET and revert read access to Lisp_Objects slots of struct window.
3394 * window.h (WGET): Remove.
3395 (struct window): Do not use INTERNAL_FIELD.
3396 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
3397 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
3398 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
3399 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
3400 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
3401 Adjust users.
3402
d10a51dc
CY
34032012-08-07 Chong Yidong <cyd@gnu.org>
3404
3405 * window.c (Fwindow_edges, Fwindow_pixel_edges)
3406 (Fwindow_absolute_pixel_edges, Fdelete_other_windows_internal)
3407 (Fdelete_window_internal): Signal an error if the window is not on
3408 a live frame (Bug#12025).
3409
e69b0960
DA
34102012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
3411
3412 Drop FGET and revert read access to Lisp_Objects slots of struct frame.
3413 * frame.h (FGET): Remove.
3414 (struct frame): Do not use INTERNAL_FIELD.
3415 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
3416 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
3417 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
3418 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
3419
25a20a3a
JB
34202012-08-06 Juanma Barranquero <lekktu@gmail.com>
3421
3422 * w32.c: Silence compiler warnings.
3423 (map_w32_filename): Remove unused variable `is_fat'.
3424 (chase_symlinks): Add parentheses around expression.
3425
1c6f11f4
GM
34262012-08-06 Glenn Morris <rgm@gnu.org>
3427
1db4583a
GM
3428 * sysdep.c: Respect BROKEN_GETWD.
3429
1c6f11f4
GM
3430 * dispnew.c (GNU_LIBRARY_PENDING_OUTPUT_COUNT, PENDING_OUTPUT_COUNT):
3431 Let configure handle it.
3432 (stdio_ext.h) [DISPNEW_NEEDS_STDIO_EXT]: Include it.
3433
2b90362b
DA
34342012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
3435
3436 Use GCALIGNMENT where appropriate.
3437 * alloc.c (XMALLOC_HEADER_ALIGNMENT, roundup_size):
3438 (union aligned_Lisp_Symbol, union aligned_Lisp_Misc):
3439 (mark_maybe_pointer, pure_alloc): Change to use GCALIGNMENT.
3440
5f50daf2
EZ
34412012-08-06 Eli Zaretskii <eliz@gnu.org>
3442
14ae4239
BT
3443 * w32menu.c (set_frame_menubar, initialize_frame_menubar):
3444 Don't use FRAME_MENU_BAR_ITEMS as an lvalue.
5f50daf2 3445
cbcc7007
SM
34462012-08-06 Stefan Monnier <monnier@iro.umontreal.ca>
3447
3448 * buffer.h (struct buffer): Revert `indirections' to a simple int;
3449 that should be sufficient for everyone.
3450
4d365fa4
JD
34512012-08-06 Jan Djärv <jan.h.d@swipnet.se>
3452
3453 * keyboard.c (timer_check_2): Add break so timer_check returns next
3454 timeout.
3455
dd86bd82
DA
34562012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
3457
3458 Fix Windows build errors introduced after converting to WGET and WSET.
3459 * w32term.c (w32_set_vertical_scroll_bar): Change to use WSET.
3460 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
3461
054e1668
JD
34622012-08-06 Jan Djärv <jan.h.d@swipnet.se>
3463
3464 * nsterm.m (ns_frame_rehighlight): Use FSET.
3465
3466 * nsmenu.m (ns_update_menubar): Use FSET.
3467
21238f11
DA
34682012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
3469
3470 Separate read and write access to Lisp_Object slots of Lisp_Process.
3471 * process.h (PGET, PSET): New macros similar to AREF and ASET.
3472 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
3473
077288cf
DA
34742012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
3475
3476 Separate read and write access to Lisp_Object slots of struct window.
3477 * window.h (WGET, WSET): New macros similar to AREF and ASET.
3478 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
3479 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
3480 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
3481 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
3482 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
3483 Adjust users.
3484
71688bd7
DA
34852012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
3486
3487 Fix Windows build errors introduced after converting to FGET and FSET.
3488 * w32term.c (x_frame_rehighlight, x_scroll_bar_create):
3489 (w32_condemn_scroll_bars, w32_redeem_scroll_bar):
3490 (w32_judge_scroll_bars): Change to use FSET.
3491 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
3492
f99bac93
DA
34932012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
3494
3495 Fix replacement typo.
3496 * window.c (replace_window): Set root_window instead of
3497 selected_window. This fixes a total window subsystem
3498 malfunction reported by Bastien Guerry <bzg@gnu.org>.
3499
8c2a0f2d
GM
35002012-08-06 Glenn Morris <rgm@gnu.org>
3501
3502 * lisp.mk (lisp): Add language/persian.elc.
3503
edd74c35
DA
35042012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
3505
3506 Separate read and write access to Lisp_Object slots of struct frame.
3507 * frame.h (FGET, FSET): New macros similar to AREF and ASET.
3508 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
3509 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
3510 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
3511 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
3512
8671676c
AS
35132012-08-05 Andreas Schwab <schwab@linux-m68k.org>
3514
3515 * emacs.c (decode_env_path): Only use defaulted if WINDOWSNT.
3516
663e2b3f
DA
35172012-08-05 Dmitry Antipov <dmantipov@yandex.ru>
3518
3519 Generalize common compile-time constants.
3520 * lisp.h (header_size, bool_header_size, word_size): Now here.
3521 (struct Lisp_Vector): Add comment.
3522 (struct Lisp_Bool_Vector): Move up to define handy constants.
3523 (VECSIZE, PSEUDOVECSIZE): Simplify.
3524 (SAFE_ALLOCA_LISP): Use new constant. Adjust indentation.
3525 * buffer.c, buffer.h, bytecode.c, callint.c, eval.c, fns.c:
3526 * font.c, fontset.c, keyboard.c, keymap.c, macros.c, menu.c:
3527 * msdos.c, w32menu.c, w32term.h, window.c, xdisp.c, xfaces.c:
3528 * xfont.c, xmenu.c: Use word_size where appropriate.
3529
d32e47af
LM
35302012-08-05 Lawrence Mitchell <wence@gmx.li>
3531
3532 * search.c (Freplace_match): Treat \? in the replacement text
3533 literally (Bug#8161).
3534
e5d9c0d1
CY
35352012-08-05 Chong Yidong <cyd@gnu.org>
3536
3537 * term.c (Vsuspend_tty_functions, Vresume_tty_functions):
3538 * frame.c (Vdelete_frame_functions):
3539 * emacs.c (Vkill_emacs_hook): Doc fix.
3540
8da0576b
EZ
35412012-08-04 Eli Zaretskii <eliz@gnu.org>
3542
3543 * xfns.c (x_set_menu_bar_lines): Fix compilation error in
3544 --with-x-toolkit=no builds.
3545 Reported by Carsten Mattner <carstenmattner@gmail.com>.
3546
02676e5d
CY
35472012-08-04 Chong Yidong <cyd@gnu.org>
3548
3549 * syntax.c (Fmodify_syntax_entry): Doc fix.
3550
97147da9
EZ
35512012-08-04 Eli Zaretskii <eliz@gnu.org>
3552
76151e2c
EZ
3553 Fix startup warnings about ../site-lisp on MS-Windows. (Bug#11959)
3554 * w32.c (init_environment): Change the default values of many
3555 environment variables in dflt_envvars[] to NULL, to avoid pushing
14ae4239
BT
3556 them into environment when they were not already defined.
3557 Remove the code that deletes site-lisp subdirectories from the default
76151e2c 3558 value of EMACSLOADPATH, as it is no longer needed.
14ae4239
BT
3559 (check_windows_init_file): Now external, not static.
3560 Use Vload_path as is, without adding anything, as this function is now
76151e2c
EZ
3561 called when Vload_path is already set up.
3562
3563 * w32.h (check_windows_init_file): Add prototype.
3564
3565 * emacs.c (init_cmdargs) [WINDOWSNT]: When running from the build
3566 directory, ignore the /*/i386/ tail in Vinvocation_directory, for
3567 compatibility with Posix platforms.
3568 (main): Move the call to check_windows_init_file to here from
3569 w32.c.
3570 (decode_env_path) [WINDOWSNT]: Expand the %emacs_dir%/ prefix, if
3571 any, in the DEFALT argument into the root of the Emacs build or
3572 installation tree, as appropriate.
3573
3574 * callproc.c (init_callproc_1): Call decode_env_path instead of
3575 doing its equivalent by hand.
3576 (init_callproc): Replace DOS_NT condition with MSDOS, thus letting
3577 the code that sets Vexec_path run on MS-Windows.
3578
3579 * lread.c (init_lread): Add comments to #ifdef's.
3580
97147da9
EZ
3581 * msdos.c (dos_set_window_size, IT_update_begin)
3582 (IT_frame_up_to_date, IT_set_frame_parameters): Use FVAR and WVAR
3583 instead of direct references.
3584
185ee146
PE
35852012-08-04 Paul Eggert <eggert@cs.ucla.edu>
3586
3587 Export DEFAULT_REHASH_* to GDB.
3588 * lisp.h (DEFAULT_REHASH_THRESHOLD, DEFAULT_REHASH_SIZE):
3589 Now constants, not macros.
3590
8834c57a
PE
35912012-08-03 Paul Eggert <eggert@cs.ucla.edu>
3592
98c6f1e3
PE
3593 Remove unnecessary casts involving pointers.
3594 These casts are no longer needed now that we assume C89 or later,
3595 since they involve casting to or from void *.
3596 * alloc.c (make_pure_string, make_pure_c_string, pure_cons)
3597 (make_pure_float, make_pure_vector):
3598 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP):
3599 * macros.c (Fstart_kbd_macro):
3600 * menu.c (find_and_return_menu_selection):
3601 * minibuf.c (read_minibuf_noninteractive):
3602 * sysdep.c (closedir):
3603 * xdisp.c (x_produce_glyphs):
3604 * xfaces.c (compare_fonts_by_sort_order):
3605 * xfns.c (x_real_positions, select_visual):
3606 * xselect.c (x_stop_queuing_selection_requests)
3607 (x_get_window_property, x_get_window_property_as_lisp_data):
3608 * xterm.c (x_set_frame_alpha, x_find_modifier_meanings):
3609 Remove unnecessary pointer casts.
3610 * alloc.c (record_xmalloc): New function.
3611 * lisp.h (record_xmalloc): New decl.
3612 (SAFE_ALLOCA): Now takes just one arg -- the size -- and acts
3613 more like a function. This is because the pointer cast is not
3614 needed. All uses changed.
3615 * print.c (print_string, print_error_message): Avoid length recalc.
3616
8834c57a
PE
3617 Improve fix for macroexp crash with debugging (Bug#12118).
3618 * lisp.h (ASET) [ENABLE_CHECKING]: Pay attention to
3619 ARRAY_MARK_FLAG when checking subscripts, because ASET is
3620 not supposed to be invoked from the garbage collector.
3621 See Andreas Schwab in <http://bugs.gnu.org/12118#25>.
3622 (gc_aset): New function, which is like ASET but can be
3623 used in the garbage collector.
3624 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
3625 (set_hash_index): Use it instead of ASET.
3626
6dad7178
EZ
36272012-08-03 Eli Zaretskii <eliz@gnu.org>
3628
3629 Support symlinks on latest versions of MS-Windows.
3630 * w32.c: Include winioctl.h and aclapi.h.
3631 (is_symlink, chase_symlinks, enable_privilege, restore_privilege)
3632 (revert_to_self): Forward declarations of static functions.
3633 <static BOOL g_b_init_get_security_info>:
3634 <g_b_init_create_symbolic_link>: New static flags.
3635 (globals_of_w32): Initialize them to zero.
3636 (GetSecurityInfo_Proc, CreateSymbolicLink_Proc): New typedefs.
3637 (map_w32_filename): Improve commentary. Simplify switch.
3638 (SYMBOLIC_LINK_FLAG_DIRECTORY): Define if not defined in system
3639 headers (most versions of MinGW w32api don't).
3640 (get_security_info, create_symbolic_link)
3641 (get_file_security_desc_by_handle, is_symlink, chase_symlinks):
3642 New functions.
3643 (sys_access, sys_chmod): Call 'chase_symlinks' to resolve symlinks
3644 in the argument file name.
3645 (sys_access): Call unc_volume_file_attributes only if
3646 GetFileAttributes fails with network-related error codes.
3647 (sys_rename): Diagnose renaming of a symlink when the user doesn't
3648 have the required privileges.
14ae4239 3649 (get_file_security_desc_by_name): Rename from
6dad7178
EZ
3650 get_file_security_desc.
3651 (stat_worker): New function, with most of the guts of 'stat', and
14ae4239
BT
3652 with addition of handling of symlinks and support for 'lstat'.
3653 If possible, get file's attributes and security information by
6dad7178
EZ
3654 handle, not by name. Produce S_IFLNK bit for symlinks, when
3655 called from 'lstat'.
3656 (stat, lstat): New functions, call 'stat_worker'.
3657 (symlink, readlink, careadlinkat): Rewritten to create and resolve
3658 symlinks when the underlying filesystem supports them.
3659
f162bcc3
PE
36602012-08-02 Paul Eggert <eggert@cs.ucla.edu>
3661
79ea6c20
PE
3662 Fix macroexp crash on Windows with debugging (Bug#12118).
3663 * lisp.h (ASET) [ENABLE_CHECKING]: Ignore ARRAY_MARK_FLAG when
3664 checking subscripts; problem introduced with the recent
3665 "ASET (a, i, v)" rather than "AREF (a, i) = v" patch.
3666 (ARRAY_MARK_FLAG): Now a macro as well as a constant,
3667 since it's used in non-static inline functions now.
3668
c0ce93fd
PE
3669 * xfaces.c (face_at_buffer_position, face_for_overlay_string):
3670 Don't assume buffer size fits in 'int'. Remove unused local.
c71f5156 3671
f162bcc3
PE
3672 Use C99-style 'extern inline' if available.
3673 * buffer.h (BUFFER_INLINE):
3674 * category.h (CATEGORY_INLINE):
3675 * character.h (CHARACTER_INLINE):
3676 * charset.h (CHARSET_INLINE):
3677 * composite.h (COMPOSITE_INLINE):
3678 * dispextern.h (DISPEXTERN_INLINE):
3679 * lisp.h (LISP_INLINE):
3680 * systime.h (SYSTIME_INLINE):
3681 New macro, replacing 'static inline' in this header.
3682 * buffer.h, category.h, character.h, charset.h, composite.h:
3683 * dispextern.h, lisp.h, systime.h:
3684 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
3685 * alloc.c (LISP_INLINE):
3686 * buffer.c (BUFFER_INLINE):
3687 * category.c (CATEGORY_INLINE):
3688 * character.c (CHARACTER_INLINE):
3689 * charset.c (CHARSET_INLINE):
3690 * composite.c (COMPOSITE_INLINE):
3691 * dispnew.c (DISPEXTERN_INLINE):
3692 * sysdep.c (SYSTIME_INLINE):
3693 Define to EXTERN_INLINE, so that the corresponding functions
3694 are compiled into code.
3695 * conf_post.h (INLINE, EXTERN_INLINE, INLINE_HEADER_BEGIN)
3696 (INLINE_HEADER_END): New macros.
3697 * lisp.h (PSEUDOVECTOR_FLAG): Now a macro as well as a constant,
3698 since it's used in non-static inline functions now.
a8333d03 3699 (VALMASK) [!USE_LSB_TAG]: Likewise.
f162bcc3 3700
837b365b
GM
37012012-08-02 Glenn Morris <rgm@gnu.org>
3702
d66b744d
GM
3703 * s/: Remove empty directory.
3704
837b365b
GM
3705 * s/ms-w32.h: Move to ../nt/inc.
3706 * makefile.w32-in (TAGS, TAGS-gmake, MS_W32_H):
3707 Update for new ms-w32.h location.
3708
13294f95
PE
37092012-08-02 Paul Eggert <eggert@cs.ucla.edu>
3710
3711 Port to Solaris 8.
3712 * syswait.h (WRETCODE): Remove, consistently with ../configure.ac.
3713
90df0db3
GM
37142012-08-02 Glenn Morris <rgm@gnu.org>
3715
3716 * nsterm.m (ns_exec_path, ns_load_path): Use SEPCHAR rather than
3717 hard-coding the path separator.
3718
4939150c
PE
37192012-08-01 Paul Eggert <eggert@cs.ucla.edu>
3720
3721 Use "ASET (a, i, v)" rather than "AREF (a, i) = v".
3722 This how ASET and AREF are supposed to work, and makes
3723 it easier to think about future improvements. See
3724 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00026.html>.
3725 * charset.h (set_charset_attr): New function.
3726 All lvalue-style uses of CHARSET_DECODER etc. changed to use it.
3727 * lisp.h (ASET): Rewrite so as not to use AREF in an lvalue style.
3728 (aref_addr): New function. All uses of &AREF(...) changed.
3729 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
3730 (set_hash_index): New functions. All lvalue-style uses of
3731 HASH_KEY etc. changed.
3732 * keyboard.c (set_prop): New function. All lvalue-style uses
3733 of PROP changed.
3734
947b2afd
AA
37352012-08-01 Alp Aker <alp.tekin.aker@gmail.com>
3736
3737 * nsterm.m (ns_set_vertical_scroll_bar, ns_redeem_scroll_bar)
3738 (EmacsWindow-accessibilityAttributeValue, EmacsScroller-initFrame:)
3739 (EmacsScroller-dealloc): Adjust to use WVAR. (Bug#12114)
3740 * nsfns.m (ns_set_name_as_filename): Likewise.
3741 * nsmenu.m (ns_update_menubar): Likewise.
3742 * nsselect.m (symbol_to_nsstring): Adjust to use SVAR.
3743
4f5d0325
EZ
37442012-08-01 Eli Zaretskii <eliz@gnu.org>
3745
2008beae
EZ
3746 * .gdbinit (xcar, xcdr, xlist, xwindow, nextcons, xprintsym):
3747 Adapt to latest changes in field names of the corresponding Lisp
288479f6 3748 objects.
2008beae 3749
4f5d0325
EZ
3750 * xdisp.c (try_window_id): Use WVAR in IF_DEBUG code.
3751
fe3cc771
GM
37522012-08-01 Glenn Morris <rgm@gnu.org>
3753
3754 * s/msdos.h: Remove file.
3755 * conf_post.h [MSDOS]: New section, moved from s/msdos.h.
3756 * Makefile.in (S_FILE): Remove.
3757 (config_h): Remove S_FILE.
3758
c90acc54
JB
37592012-08-01 Juanma Barranquero <lekktu@gmail.com>
3760
3761 * s/ms-w32.h (DEVICE_SEP, IS_DIRECTORY_SEP, IS_ANY_SEP):
3762 Remove; moved to nt/config.nt.
3763
d8a05828
DA
37642012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
3765
3766 Use INTERNAL_FIELD for conses and overlays.
3767 * lisp.h (struct Lisp_Cons): Use INTERNAL_FIELD.
3768 Remove obsolete comment.
3769 (MVAR): New macro.
3770 (struct Lisp_Overlay): Use INTERNAL_FIELD.
3771 * alloc.c, buffer.c, buffer.h, fns.c: Adjust users.
3772
8271d590
DA
37732012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
3774
3775 Use INTERNAL_FIELD for symbols.
3776 * lisp.h (SVAR): New macro. Adjust users.
3777 * alloc.c, bytecode.c, cmds.c, data.c, doc.c, eval.c:
3778 * fns.c, keyboard.c, lread.c, xterm.c: Users changed.
3779
3193acd2
DA
37802012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
3781
3782 Use INTERNAL_FIELD for processes.
3783 * process.h (PVAR): New macro. Adjust style.
3784 (struct Lisp_Process): Change Lisp_Object members to INTERNAL_FIELD.
3785 * print.c, process.c, sysdep.c, w32.c, xdisp.c: Users changed.
3786
3a45383a
DA
37872012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
3788
3789 Use INTERNAL_FIELD for windows.
3790 * window.h (WVAR): New macro.
3791 (struct window): Change Lisp_Object members to INTERNAL_FIELD.
3792 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
3793 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
3794 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, nsterm.m, print.c:
3795 * textprop.c, w32fns.c, w32menu.c, w32term.c, window.c, xdisp.c:
3796 * xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
3797
c1dbc63c
PE
37982012-08-01 Paul Eggert <eggert@cs.ucla.edu>
3799
3800 * coding.h (CODING_ATTR_FLUSHING): Remove; unused and wouldn't work.
3801
5c0c0e8a
GM
38022012-08-01 Glenn Morris <rgm@gnu.org>
3803
3804 * lisp.h (IS_DIRECTORY_SEP, IS_DEVICE_SEP, IS_ANY_SEP):
3805 Move to configure.ac.
3806
552a99b4
JB
38072012-08-01 Juanma Barranquero <lekktu@gmail.com>
3808
3809 * makefile.w32-in (CONFIG_H): Update dependencies.
3810 (CONF_POST_H): New macro.
3811
3812 * s/ms-w32.h (SEPCHAR, NULL_DEVICE): Remove; moved to nt/config.nt.
3813
8d8e2dfe
GM
38142012-07-31 Glenn Morris <rgm@gnu.org>
3815
bc96620a
GM
3816 * Makefile.in (S_FILE): No longer set by configure.
3817
476b1b2d
GM
3818 * conf_post.h (config_opsysfile): Move earlier, so that WINDOWSNT
3819 is available.
3820 (alloca.h) [WINDOWSNT]: Don't include it on MS Windows.
3821
b2c7a106
GM
3822 * process.h (NULL_DEVICE):
3823 * emacs.c (SEPCHAR):
3824 * editfns.c (USER_FULL_NAME): Let configure set them.
3825
d53d062a
GM
3826 * s/README, s/template.h: Remove files.
3827
4515017f
GM
3828 * conf_post.h [HPUX]: Undefine HAVE_RANDOM and HAVE_RINT.
3829
8d8e2dfe
GM
3830 * conf_post.h (AMPERSAND_FULL_NAME, subprocesses):
3831 Move to configure.ac.
3832
5b20b3cc
EZ
38332012-07-31 Eli Zaretskii <eliz@gnu.org>
3834
1e0afd9a
EZ
3835 * .gdbinit (xframe): Adapt to introduction of FVAR and the
3836 resulting renaming of 'struct frame' members.
3837
5b20b3cc
EZ
3838 * w32menu.c (w32_menu_show): Revert bogus introduction of FVAR.
3839
3840 * fontset.c (dump_fontset): Fix compilation with ENABLE_CHECKING
3841 after introduction of FVAR.
3842
f1310128
JD
38432012-07-31 Jan Djärv <jan.h.d@swipnet.se>
3844
79e721e0
JD
3845 * nsmenu.m (update_frame_tool_bar): Change key from NSObject* to id.
3846
3847 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Use drawInRect
3848 instead of compositeToPoint.
3849 (applicationShouldTerminate): Pass NS String literal to NSRunAlertPanel.
3850
8d7c7eed 3851 * nsfns.m, nsmenu.m, nsterm.m: Adopt to struct frame/FVAR changes.
f1310128 3852
e34f7f79
DA
38532012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
3854
3855 Generalize INTERNAL_FIELD between buffers, keyboards and frames.
3856 * lisp.h (INTERNAL_FIELD): New macro.
14ae4239 3857 * buffer.h (BUFFER_INTERNAL_FIELD): Remove.
e34f7f79
DA
3858 (BVAR): Change to use INTERNAL_FIELD.
3859 * keyboard.h (KBOARD_INTERNAL_FIELD): Likewise.
3860 (KVAR): Change to use INTERNAL_FIELD.
3861 * frame.h (FVAR): New macro.
3862 (struct frame): Use INTERNAL_FIELD for all Lisp_Object fields.
3a45383a
DA
3863 * alloc.c, buffer.c, data.c, dispnew.c, dosfns.c, eval.c, frame.c:
3864 * fringe.c, gtkutil.c, minibuf.c, nsfns.m, nsterm.m, print.c:
3865 * term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
e34f7f79
DA
3866 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
3867
c09bfb2f
DA
38682012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
3869
3870 Miscellaneous fixes for non-default X toolkits.
3871 * xfns.c (Fx_file_dialog): Change to SSDATA to avoid warnings.
3872 * xterm.c (x_frame_of_widget): Remove redundant prototype.
3873 Move under #ifdef USE_LUCID.
3874 (x_create_toolkit_scroll_bar): Adjust scroll_bar_name
3875 definition and usage to avoid warnings.
3876
14c114ae
JD
38772012-07-31 Jan Djärv <jan.h.d@swipnet.se>
3878
3879 * nsterm.m (openFiles): Fix previous checkin.
3880
3bd21e82
PE
38812012-07-31 Paul Eggert <eggert@cs.ucla.edu>
3882
3883 * indent.c (compute_motion): Remove unused local.
3884
c1529ded
GM
38852012-07-31 Glenn Morris <rgm@gnu.org>
3886
400d5621
GM
3887 * s/usg5-4-common.h (wait3, WRETCODE): Let configure set them.
3888
268e2432
GM
3889 * conf_post.h [USG5_4]:
3890 Move remaining contents of s/usg5-4-common.h here.
3891 * s/usg5-4-common.h: Remove file.
3892
7552f3ee
GM
3893 * conf_post.h [IRIX6_5]: Move remaining contents of s/irix6-5.h here.
3894 * s/irix6-5.h: Remove file.
3895
6a381852
GM
3896 * conf_post.h [DARWIN_OS]: Move remaining contents of s/darwin.h here.
3897 * s/darwin.h: Remove file.
3898
c1529ded
GM
3899 * conf_post.h [HPUX]: Move random, srandom here from s/hpux10-20.h.
3900 * s/hpux10-20.h: Remove file, which is now empty.
3901
b429a4ee
GM
39022012-07-30 Glenn Morris <rgm@gnu.org>
3903
3904 * conf_post.h: New, split from configure.ac's AH_BOTTOM.
3905 * Makefile.in (config_h): Add conf_post.h.
3906 * makefile.w32-in (CONFIG_H): Add conf_post.h.
3907
adff3182
JD
39082012-07-30 Jan Djärv <jan.h.d@swipnet.se>
3909
3910 * nsterm.m (ns_do_open_file): New variable.
b9031d69 3911 (ns_term_init): Set ns_do_open_file to YES after run returns.
14ae4239
BT
3912 (openFile, openTempFile, openFileWithoutUI, openFiles):
3913 Open files only if ns_do_open_file.
adff3182 3914
c32af1e4
PE
39152012-07-30 Paul Eggert <eggert@cs.ucla.edu>
3916
7393bcbb
PE
3917 * lisp.h (SWITCH_ENUM_CAST): Remove. All uses removed.
3918 This no-op macro hasn't been needed for many years.
3919 * src/regex.c (SWITCH_ENUM_CAST) [!emacs]: Likewise.
3920
c32af1e4
PE
3921 Export DIRECTORY_SEP, TYPEMASK, VALMASK to GDB.
3922 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]: Add lsb_bits.
3923 * lisp.h (enum lsb_bits) [USE_LSB_TAG]: New enum, for
3924 gdb_make_enums_visible.
3925 (TYPEMASK, VALMASK) [USE_LSB_TAGS]: Now enum constants, not macros.
3926 (DIRECTORY_SEP): Now a constant, not a macro.
3927
302fc036
EZ
39282012-07-30 Eli Zaretskii <eliz@gnu.org>
3929
3930 * w32fns.c (w32_wnd_proc): Pass w32_keyboard_codepage to
3931 w32_kbd_patch_key as the 2nd arg. (Bug#12082)
3932
3933 * w32term.c <w32_keyboard_codepage>: Renamed from
3934 keyboard_codepage and now external. All users changed.
3935
3936 * w32term.h: Add declaration of w32_keyboard_codepage.
3937
3938 * w32inevt.c (w32_kbd_patch_key): Accept an additional argument --
3939 the codepage to translate keys to Unicode. If this argument is
3940 -1, use the value returned by GetConsoleCP. All callers changed.
3941
88fb40b4
PE
39422012-07-30 Paul Eggert <eggert@cs.ucla.edu>
3943
0aee6912
PE
3944 Update .PHONY listings in makefiles.
3945 * Makefile.in (.PHONY): Add all, mostlyclean, clean,
3946 bootstrap-clean, distclean, maintainer-clean, versioclean,
3947 extraclean, frc.
3948
88fb40b4
PE
3949 * lisp.h (STRING_BYTES_BOUND): Cast entire result to ptrdiff_t.
3950 This is a bit clearer. Fix some commentary typos.
3951
0a763bd1
GM
39522012-07-30 Glenn Morris <rgm@gnu.org>
3953
32bac6d6
GM
3954 * s/netbsd.h: Let configure include signal.h if needed.
3955 Remove file, which is now empty.
3956
b65e7c46
GM
3957 * s/usg5-4-common.h (_longjmp, _setjmp, TIOCSIGSEND):
3958 Let configure set them.
3959 * s/irix6-5.h (_longjmp, _setjmp, TIOCSIGSEND):
3960 No more need to undefine.
0a763bd1 3961
169304bd
AS
39622012-07-30 Andreas Schwab <schwab@linux-m68k.org>
3963
3964 * keymap.c (Fkey_description): Don't remove 0x80 bit from
3965 non-single-byte char when adding meta modifier. (Bug#12090)
3966
6cd7a139
DA
39672012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
3968
3969 Convert safe_call to use variable number of arguments.
3970 * xdisp.c (safe_call): Convert to use varargs. Adjust users.
3971 (safe_call2): Fix comment.
3972 * lisp.h (safe_call): Adjust prototype.
3973 * coding.c (encode_coding_object): Change to use safe_call2.
3974 * xfaces.c (merge_face_heights): Change to use safe_call1.
3975
d34d6ffc
GM
39762012-07-30 Glenn Morris <rgm@gnu.org>
3977
7b8a48e4 3978 * s/aix4-2.h (sigmask): No need to undefine it, since syssignal.h
227f5bd0 3979 does that unconditionally. Remove file, which is now empty.
7b8a48e4 3980
d34d6ffc
GM
3981 * s/freebsd.h, s/gnu-linux.h, s/sol2-6.h, s/unixware.h:
3982 Remove empty files.
3983
03a660a6
PE
39842012-07-30 Paul Eggert <eggert@cs.ucla.edu>
3985
3986 Export to GDB most of lisp.h's remaining object-like macros.
3987 * lisp.h (min, max): Move earlier, because they're used earlier now.
3988 (INTMASK, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK)
3989 (CHAR_TABLE_STANDARD_SLOTS, CHARTAB_SIZE_BITS_0)
3990 (CHARTAB_SIZE_BITS_1, CHARTAB_SIZE_BITS_2, CHARTAB_SIZE_BITS_3)
3991 (DEFAULT_HASH_SIZE, COMPILED_ARGLIST, COMPILED_BYTECODE)
3992 (COMPILED_CONSTANTS, COMPILED_STACK_DEPTH, COMPILED_DOC_STRING)
3993 (COMPILED_INTERACTIVE, CHAR_ALT, CHAR_SUPER, CHAR_HYPER, CHAR_SHIFT)
3994 (CHAR_CTL, CHAR_META, CHAR_MODIFIER_MASK, CHARACTERBITS)
3995 (MANY, UNEVALLED, FLOAT_TO_STRING_BUFSIZE, MAX_ALLOCA):
3996 Now constants, for GDB. They need not be macros.
3997 (MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM, STRING_BYTES_BOUND):
3998 Now constants, for GDB, as well as macros, for static initializers.
3999 (CHAR_TABLE_STANDARD_SLOTS, CHAR_TABLE_EXTRA_SLOTS):
4000 Move to after the definition of struct Lisp_Char_Table,
4001 since the former now needs that type defined.
4002 (enum CHARTAB_SIZE_BITS, enum CHAR_TABLE_STANDARD_SLOTS)
4003 (enum DEFAULT_HASH_SIZE, enum Lisp_Compiled, enum char_bits)
4004 (enum maxargs, enum FLOAT_TO_STRING_BUFSIZE, enum MAX_ALLOCA):
4005 New enums, for gdb_make_enums_visible.
4006 (GLYPH_MODE_LINE_FACE): Remove; unused.
88fb40b4 4007 * alloc.c (STRING_BYTES_MAX): Now a constant, not a macro.
03a660a6
PE
4008 (gdb_make_enums_visible): Add enum CHARTAB_SIZE_BITS, enum
4009 CHAR_TABLE_STANDARD_SLOTS, enum char_bits, enum DEFAULT_HASH_SIZE,
4010 enum FLOAT_TO_STRING_BUFSIZE, enum Lisp_Bits, enum Lisp_Compiled,
4011 enum maxargs, enum MAX_ALLOCA.
4012 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): Remove.
4013 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Remove;
4014 no longer needed, now that they are done in lisp.h.
4015
e499d0ee
DA
40162012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
4017
4018 Cleanup string bytes checking.
4019 * alloc.c (GC_STRING_BYTES, CHECK_STRING_BYTES): Remove. Convert
4020 all users to STRING_BYTES or string_bytes if GC_CHECK_STRING_BYTES.
4021 (check_string_bytes): Define to empty if not GC_CHECK_STRING_BYTES.
4022 (check_sblock, compact_small_strings): Simplify.
4023
d5040d2d
PE
40242012-07-29 Paul Eggert <eggert@cs.ucla.edu>
4025
4026 * lisp.h (LISP_INT_TAG, LISP_INT1_TAG, LISP_STRING_TAG): Remove.
4027 These macros are confusing and no longer need to be defined, as
4028 the enum values now suffice. All uses replaced with definiens.
4029 (Lisp_Int1, Lisp_String): Define directly; this is clearer.
4030
7f259ae6
JB
40312012-07-29 Juanma Barranquero <lekktu@gmail.com>
4032
4033 * makefile.w32-in (LISP_H, $(BLD)/emacs.$(O), $(BLD)/w32inevt.$(O))
4034 ($(BLD)/w32console.$(O)): Update dependencies.
4035
7e63e0c3
DA
40362012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
4037
4038 Remove HIDE_LISP_IMPLEMENTATION and cleanup cons free list check.
4039 * lisp.h (HIDE_LISP_IMPLEMENTATION): Remove as useless for a long
4040 time. Adjust users.
4041 (CHECK_CONS_LIST): Remove. Convert all users to check_cons_list.
4042
ffd817eb
JD
40432012-07-29 Jan Djärv <jan.h.d@swipnet.se>
4044
4045 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
4046 setting sitelisp (Bug#12010).
4047
417a7a0e
EZ
40482012-07-29 Eli Zaretskii <eliz@gnu.org>
4049
14ae4239 4050 * w32heap.h (OS_9X): Rename from OS_WINDOWS_95.
417a7a0e
EZ
4051
4052 * w32heap.c (cache_system_info):
4053 * w32.c (sys_rename):
4054 * w32proc.c (find_child_console, sys_kill): All users changed.
4055
387d4d92
PE
40562012-07-29 Paul Eggert <eggert@cs.ucla.edu>
4057
4058 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
4059
55a6cca6
EZ
40602012-07-29 Eli Zaretskii <eliz@gnu.org>
4061
4062 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
4063
dbcf001c
DA
40642012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
4065
4066 Cleanup statistics calculation in Fgarbage_collect.
14ae4239
BT
4067 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start.
4068 Fix zombies percentage calculation. Simplify elapsed time calculation.
dbcf001c 4069
e2688e4a
DA
40702012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
4071
4072 Generalize marker debugging code under MARKER_DEBUG and use eassert.
4073 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
4074 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
4075 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
4076 (replace_range, replace_range_2, del_range_2): Change to eassert.
4077 * marker.c (byte_char_debug_check): Adjust style.
4078
b46a6a83
PE
40792012-07-29 Paul Eggert <eggert@cs.ucla.edu>
4080
4081 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
4082 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
4083 long-ago-commented-out code that talks about "WIN32".
4084 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
4085 All uses changed.
4086
e32a5799
PE
40872012-07-28 Paul Eggert <eggert@cs.ucla.edu>
4088
4089 Use Gnulib stdalign module (Bug#9772, Bug#9960).
4090 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
4091 Simplify by using alignof.
4092 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
4093 * lisp.h: Include <stdalign.h>.
4094 (GCALIGNMENT): New macro and constant.
4095 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
4096 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
4097 (stdalign): New macro, if not already defined.
4098
df81cd29
EZ
40992012-07-28 Eli Zaretskii <eliz@gnu.org>
4100
01bd1b0d
EZ
4101 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
4102 * w32inevt.c: Include w32inevt.h.
4103 (w32_read_console_input): New inline function, calls either
4104 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
4105 w32_console_unicode_input.
4106 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
4107 (w32_kbd_patch_key, key_event): Use the codepage returned by
4108 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
4109 (key_event): use uChar.UnicodeChar only if
4110 w32_console_unicode_input is non-zero.
4111
4112 * w32console.c: Include w32heap.h.
4113 <w32_console_unicode_input>: New global variable.
4114 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
4115 family of Windows, zero otherwise.
4116
4117 * w32inevt.h: Declare w32_console_unicode_input.
4118
df81cd29
EZ
4119 * xdisp.c (init_iterator): Don't reference tip_frame in a build
4120 --without-x. (Bug#11742)
4121
c20fdd9e
PE
41222012-07-27 Paul Eggert <eggert@cs.ucla.edu>
4123
4124 Adjust GDB to reflect pvec_type changes (Bug#12036).
4125 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
14ae4239
BT
4126 2012-07-04 changes to pseudovector representation.
4127 Problem reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
c20fdd9e 4128
32770973 41292012-07-27 Michael Albinus <michael.albinus@gmx.de>
e518bc71
MA
4130
4131 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
4132 bus address.
4133 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
4134
3438fe21
EZ
41352012-07-27 Eli Zaretskii <eliz@gnu.org>
4136
bcfbc9de
EZ
4137 * alloc.c (listn): Fix the order the arguments are consed onto the
4138 list.
4139
3438fe21
EZ
4140 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
4141 enumeration constants, as PURE and HEAP are too general, and clash
4142 with other headers and sources, such as gmalloc.c and the
4143 MS-Windows system headers. All users changed.
4144
eeaea515
DA
41452012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
4146
4147 Revert last save_excursion_save and save_excursion_restore changes.
4148 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
4149 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
4150
073c88c2
DA
41512012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
4152
4153 Fix recently-introduced typos in Windows port.
4154 Reported by Martin Rudalics <rudalics@gmx.at>.
4155 * w32.c (init_environment): Replace comma with semicolon.
eeaea515 4156 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
073c88c2 4157
4706125e
PE
41582012-07-27 Paul Eggert <eggert@cs.ucla.edu>
4159
4160 Improve GDB symbol export (Bug#12036).
4161 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
4162 arms of an 'if', not using conditional expressions; otherwise GDB
4163 complains about the types in the unevaluated arm when the argument
4164 is an integer literal.
4165 (xgetint): Simplify expression.
4166 * alloc.c (gdb_make_enums_visible): New constant. This ports to
4167 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
4168 Zaretskii in <http://bugs.gnu.org/12036#13>.
4169 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
4170 needed now that we have gdb_make_enums_visible.
4171 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
4172 (enum enum_USE_LSB_TAG):
4173 New enum types, packaging up enums that need to be exported to GDB.
4174
694b6c97
DA
41752012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
4176
4177 Utility function to make a list from specified amount of objects.
4178 * lisp.h (enum constype): New datatype.
4179 (listn): New prototype.
4180 * alloc.c (listn): New function.
4181 (Fmemory_use_count, syms_of_alloc): Use it.
4182 * buffer.c (syms_of_buffer): Likewise.
4183 * callint.c (syms_of_callint): Likewise.
4184 * charset.c (define_charset_internal): Likewise.
4185 * coding.c (syms_of_coding): Likewise.
4186 * keymap.c (syms_of_keymap): Likewise.
4187 * search.c (syms_of_search): Likewise.
4188 * syntax.c (syms_of_syntax): Likewise.
4189 * w32.c (init_environment): Likewise.
4190 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
4191 * xdisp.c (syms_of_xdisp): Likewise.
4192 * xfns.c (syms_of_xfns): Likewise.
4193
6195f384
DA
41942012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
4195
4196 Fast save_excursion_save and save_excursion_restore.
4197 * lisp.h (struct Lisp_Excursion): New data type.
4198 (PVEC_EXCURSION): New pseudovector type.
4199 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
4200 to deal with it. Adjust comments.
4201 (init_marker, attach_marker): New prototype.
4202 (unchain_marker): Adjust prototype.
4203 * marker.c (attach_marker): Change to global.
4204 (init_marker): New function.
4205 * alloc.c (Fmake_marker, build_marker): Use it.
4206 (build_marker): More easserts.
4207 (mark_object): Handle struct Lisp_Excursion.
4208 * editfns.c (save_excursion_save, save_excursion_restore):
4209 Reimplement to use struct Lisp_Excursion. Add comments.
4210
5eceb8fb
PE
42112012-07-26 Paul Eggert <eggert@cs.ucla.edu>
4212
4213 Fix export of symbols to GDB (Bug#12036).
4214 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
4215 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
4216 emacs.c, as this is a more-suitable home. Had this been done earlier
4217 the fix for 12036 would have avoided some of the problems noted in
4218 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
4219 would have been more obvious.
562157c8
PE
4220 * emacs.c: Do not include <verify.h>; no longer needed.
4221 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
5eceb8fb
PE
4222 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
4223 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
4224 Remove; now done in lisp.h.
4225 * lisp.h (PUBLISH_TO_GDB): New macro.
4226 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
4227 (DATA_SEG_BITS): Use it.
4228 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
4229 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
4230 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
4231 not be usable in #if. This simplifies things.
4232
d6749401
JB
42332012-07-26 Juanma Barranquero <lekktu@gmail.com>
4234
4235 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
4236
1781b9e9
PE
42372012-07-26 Paul Eggert <eggert@cs.ucla.edu>
4238
d89518db 4239 Simplify export of symbols to GDB (Bug#12036).
1781b9e9
PE
4240 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
4241 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
4242 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
4243 Adjust to changes in lisp.h and emacs.c, by using
4244 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
4245 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
4246 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
4247 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
4248 instead of gdb_valbits.
4249 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
4250 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
4251 instead of gdb_array_mark_flag.
4252 (xboolvector): Get size from $->size, not $->header.size.
4253 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
4254 (xreload, hook-run, hookpost-run): Remove.
4255 * emacs.c: Include <verify.h>.
4256 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
4257 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
4258 Remove.
4259 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
4260 (gdb_USE_LSB_TAG): New enum constants.
4261 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
4262 Also define these as enum constants, so they're visible to GDB.
4263 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
4264 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
4265 as constants, so they're visible to GDB.
4266 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
4267 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
4268 Now enum constants, not macros, so they're visible to GDB.
4269 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
4270 more convenient now. All uses changed.
4271 (VALMASK) [USE_LSB_TAG]: Also define in this case.
4272 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
4273
3628596a
DA
42742012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
4275
4276 Explicitly free restriction data that are not needed anymore.
4277 * editfns.c (save_restriction_restore): Free restriction data.
4278
7abaf5cc
SM
42792012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
4280
4281 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
4282 add argument, tune behavior, and adjust all callers.
4283
71f88e00
PE
42842012-07-25 Paul Eggert <eggert@cs.ucla.edu>
4285
4286 Use typedef for EMACS_INT, EMACS_UINT.
4287 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
4288 than macros. This simplifies debugging in the usual case, since
4289 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
4290 and it allows expressions involving EMACS_INT casts.
4291 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
4292
57ec3034
JD
42932012-07-25 Jan Djärv <jan.h.d@swipnet.se>
4294
4295 * nsterm.m (ns_read_socket): Return early if there is a modal
4296 window (Bug#12043).
4297
8137e7b3
MR
42982012-07-25 Martin Rudalics <rudalics@gmx.at>
4299
4300 * frame.c (Fredirect_frame_focus): In doc-string don't mention
4301 that FOCUS-FRAME can be omitted.
4302
04e9897c
DA
43032012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
4304
4305 Adjust buffer text indirection counters at the end of Fkill_buffer.
4306 * buffer.c (Fkill_buffer): Adjust indirection counters when the
4307 buffer is definitely dead. This should really fix an issue reported
4308 by Christoph Scholtes again. (Bug#12007).
4309 (init_buffer_once): Initialize indirection counters of
4310 buffer_defaults and buffer_local_symbols (for sanity and safety).
4311
8a0484e1
EZ
43122012-07-24 Eli Zaretskii <eliz@gnu.org>
4313
4314 * xdisp.c (init_iterator): Don't compute dimensions of truncation
4315 and continuation glyphs on tooltip frames, leave them at zero.
4316 Avoids continued lines in tooltips. (Bug#11832)
4317
fa691a83
DA
43182012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
4319
4320 Simplify copy_overlay.
04e9897c 4321 * buffer.c (copy_overlay): Simplify. Use build_marker.
fa691a83
DA
4322 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
4323
436bc8e0
EZ
43242012-07-23 Eli Zaretskii <eliz@gnu.org>
4325
4326 * print.c (print_object): Don't crash when a frame's name is nil
4327 or invalid. (Bug#12025)
4328
4329 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
4330 it signals an error when a tooltip frame is being created.
4331
d7a7fda3
DA
43322012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
4333
4334 Cleanup miscellaneous objects allocation and initialization.
4335 * alloc.c (allocate_misc): Change to static. Add argument to
4336 specify the subtype. Adjust comment and users.
4337 (build_overlay): New function.
4338 * buffer.c (copy_overlays, Fmake_overlay): Use it.
4339 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
4340 (allocate_misc): Remove prototype.
4341 (build_overlay): Add prototype.
4342
43432012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
372f8ffc
DA
4344
4345 Swap buffer text indirection counters in Fbuffer_swap_text.
4346 * buffer.c (Fbuffer_swap_text): Swap indirections too.
4347 This avoids crash reported by Christoph Scholtes at
4348 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
4349
9d7fa573
JD
43502012-07-22 Jan Djärv <jan.h.d@swipnet.se>
4351
4352 * nsmenu.m (Popdown_data): New struct.
4353 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
4354 free Popdown_data.
4355 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
4356 (initWithContentRect): Make imgView and contentView non-static
4357 and autorelease them. Also autorelease img and matrix (Bug#12005).
4358 (dealloc): Remove (Bug#12005).
4359
0dd6d66d
DA
43602012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
4361
4362 Adjust consing_since_gc when objects are explicitly freed.
4363 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
4364 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
4365 (free_cons, free_misc): Subtract object size from consing_since_gc.
4366
d36d71df
DA
43672012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
4368
4369 Simplify and cleanup markers positioning code.
4370 * marker.c (attach_marker): More useful eassert.
4371 (live_buffer, set_marker_internal): New function.
4372 (Fset_marker, set_marker_restricted): Use set_marker_internal.
4373 (set_marker_both, set_marker_restricted_both): Use live_buffer.
4374
fb9ea40f
PE
43752012-07-22 Paul Eggert <eggert@cs.ucla.edu>
4376
4377 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
4378 as it's limited by the amount of memory, not by INT_MAX.
4379
2d5c5f7d
EZ
43802012-07-21 Eli Zaretskii <eliz@gnu.org>
4381
07fb592e
EZ
4382 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
4383 in special-event-map. See the discussion at
4384 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
4385 for the reasons.
4386
37a9eac8 4387 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
14ae4239
BT
4388 info.dwItemData. Fixes crashes on 64-bit Windows.
4389 Suggested by Fabrice Popineau <fabrice.popineau@supelec.fr>.
2d5c5f7d 4390
c4328746
JD
43912012-07-21 Jan Djärv <jan.h.d@swipnet.se>
4392
fc0c31f8 4393 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 4394 (conversationIdentifier): Return value is NSInteger.
784051c4 4395 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 4396
6e5d1c12
CY
43972012-07-21 Chong Yidong <cyd@gnu.org>
4398
4399 * window.c (decode_any_window): Signal an error if the window is
4400 on a dead frame (Bug#11984).
4401
9928463d
DA
44022012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
4403
4404 Add indirection counting to speed up Fkill_buffer.
4405 * buffer.h (struct buffer): New member.
4406 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
4407 (Fmake_indirect_buffer): Set indirection counter to -1, increment
4408 base buffer indirection counter.
4409 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
4410 (Fkill_buffer): Adjust indirection counters as needed, don't walk
4411 through buffer list if indirection counter is 0.
4412
f8643a6b
DA
44132012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
4414
4415 Extend the value returned by Fgarbage_collect with heap statistics.
4416 * alloc.c (Qheap): New symbol.
4417 (syms_of_alloc): DEFSYM it.
4418 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
4419 (Fmemory_free): Remove.
4420 (syms_of_alloc): Don't defsubr it.
4421 * buffer.c (Fcompact_buffer): Remove.
4422 (syms_of_buffer): Don't defsubr it.
4423
dac616ff
DA
44242012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
4425
4426 Make maybe_gc inline.
4427 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
4428 * lisp.h (consing_since_gc, gc_relative_threshold)
4429 (memory_full_cons_threshold): Revert declaration.
4430 (maybe_gc): Remove prototype, define as inline.
4431 * alloc.c: Remove old commented-out code.
4432 (consing_since_gc, gc_relative_threshold)
4433 (memory_full_cons_threshold): Revert to global.
4434 (maybe_gc): Remove.
4435
d7ea76b4
DA
44362012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
4437
4438 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
4439 * lisp.h (build_unibyte_string): New function.
4440 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
4441 * sysdep.c, w32fns.c, xfns.c: Use it.
4442 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
4443 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
4444 Adjust users accordingly.
4445 * font.h (font_open_by_name): Adjust prototype.
4446
765e61e3
DA
44472012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
4448
4449 Cleanup calls to Fgarbage_collect.
4450 * lisp.h (maybe_gc): New prototype.
4451 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
4452 Remove declarations.
4453 * alloc.c (maybe_gc): New function.
4454 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
4455 Make them static.
4456 * bytecode.c (MAYBE_GC): Use maybe_gc.
4457 * eval.c (eval_sub, Ffuncall): Likewise.
4458 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
4459 to avoid dependency from auto-save feature.
4460
52b852c7
PE
44612012-07-19 Paul Eggert <eggert@cs.ucla.edu>
4462
4463 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
4464 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
4465 'for_each_per_buffer_object_at'.
4466 All uses changed. It's better to use upper-case for macros that
4467 cannot be implemented as functions, to give the reader a clue
4468 that they're special.
4469
5db81e33
SM
44702012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
4471
4472 * alloc.c (Fgarbage_collect): Tweak docstring.
4473
5b835e1d
DA
44742012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
4475
4476 Tweak the value returned from Fgarbage_collect again.
4477 * alloc.c (Fgarbage_collect): New return value, as confirmed in
4478 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
4479 Adjust documentation.
4480 (total_vector_bytes): Rename to total_vector_slots, adjust
4481 accounting.
4482 (total_free_vector_bytes): Rename to total_free_vector_slots,
4483 adjust accounting.
4484 (Qstring_bytes, Qvector_slots): New symbols.
4485 (syms_of_alloc): DEFSYM them.
4486
9cd47b72
DA
44872012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
4488
4489 Buffer compaction primitive which may be used from Lisp.
4490 * buffer.c (compact_buffer, Fcompact_buffer): New function.
4491 (syms_of_buffer): Register Fcompact_buffer.
4492 * alloc.c (Fgarbage_collect): Use compact_buffer.
4493 * buffer.h (compact_buffer): New prototype.
4494 (struct buffer_text): New member.
4495
d17337e5
DA
44962012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
4497
4498 New macro to iterate over all buffers, miscellaneous cleanups.
4499 * lisp.h (all_buffers): Remove declaration.
4500 * buffer.h (all_buffers): Add declaration, with comment.
4501 (for_each_buffer): New macro.
4502 * alloc.c (Fgarbage_collect, mark_object): Use it.
4503 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
4504 (init_buffer): Likewise.
4505 * data.c (Fset_default): Likewise.
4506 * coding.c (code_conversion_restore): Remove redundant check
4507 for dead buffer.
4508 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
4509
60cfd278
AS
45102012-07-18 Andreas Schwab <schwab@linux-m68k.org>
4511
4512 Fix bug that created negative-length intervals.
4513 * intervals.c (merge_interval_right, merge_interval_left):
4514 Do not zero out this interval if it is absorbed by its children,
4515 as this interval's total length doesn't change in that case. See
4516 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
4517
d06714cb
PE
45182012-07-18 Paul Eggert <eggert@cs.ucla.edu>
4519
83713154
PE
4520 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
4521 when invoking (make-bool-vector N t) and N is a positive
4522 multiple of 8 -- the last 8 bits were mistakenly cleared.
4523
d06714cb
PE
4524 Remove some struct layout assumptions in bool vectors.
4525 * alloc.c (bool_header_size): New constant.
4526 (header_size, word_size): Move earlier, as they're now used earlier.
4527 Use 'word_size' in a few more places, where it's appropriate.
4528 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
4529 padding before the data member of a bool vector.
4530 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
4531 than doing the check by hand with an abort ().
4532
464d5a5e
SM
45332012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
4534
5fbc0409
SM
4535 * eval.c (Fdefvar): Don't check constants since we only set the var if
4536 it's not yet defined anyway (bug#11904).
4537
464d5a5e
SM
4538 * lisp.h (last_undo_boundary): Declare new var.
4539 * keyboard.c (command_loop_1): Set it.
4540 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
4541 were auto-added by the command loop (bug#11774).
4542
8dc2e44a
AS
45432012-07-18 Andreas Schwab <schwab@linux-m68k.org>
4544
4545 * w32font.c (Qsymbol): Remove local definition.
4546 (syms_of_w32font): Don't DEFSYM it.
4547
169925ec
DA
45482012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
4549
4550 Fix sweep_vectors to handle large bool vectors correctly.
4551 * alloc.c (sweep_vectors): Account total_vector_bytes for
4552 bool vectors larger than VBLOCK_BYTES_MAX.
4553
5fbfb018
CY
45542012-07-18 Chong Yidong <cyd@gnu.org>
4555
4556 * frame.c (x_set_frame_parameters): Revert bogus change introduced
4557 in 2012-05-25 commit by Paul Eggert (Bug#11738).
4558
3ab6e069
DA
45592012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
4560
4561 Return more descriptive data from Fgarbage_collect.
4562 Suggested by Stefan Monnier in
4563 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
4564 * alloc.c (bounded_number): New function.
4565 (total_buffers, total_vectors): New variable.
4566 (total_string_size): Rename to total_string_bytes, adjust users.
4567 (total_vector_size): Rename to total_vector_bytes, adjust users.
4568 (sweep_vectors): Account total_vectors and total_vector_bytes.
4569 (Fgarbage_collect): New return value. Adjust documentation.
4570 (gc_sweep): Account total_buffers.
4571 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
4572 (VECTOR_SIZE): Remove.
4573 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
4574 (Qinterval, Qmisc): New symbols.
4575 (syms_of_data): Initialize them.
4576 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
4577 (Qcons, Qbuffer): New declarations.
4578
6d02fe5b
PE
45792012-07-17 Paul Eggert <eggert@cs.ucla.edu>
4580
4581 * alloc.c (Fmemory_free): Account for memory-free's own storage.
4582 Round up, not down. Improve doc.
4583
b7ffe040
DA
45842012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
4585
4586 Restore old code in allocate_string_data to avoid Faset breakage.
4587 Reported by Julien Danjou <julien@danjou.info> in
4588 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
4589 * alloc.c (allocate_string_data): Restore old code with minor
4590 adjustments, fix comment to explain this subtle issue.
4591
4dc7c8d5
SM
45922012-07-17 Eli Zaretskii <eliz@gnu.org>
4593
4594 Remove FILE_SYSTEM_CASE.
4595 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
4596
4597 * fileio.c (FILE_SYSTEM_CASE): Don't define.
4598 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
4599 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
4600 call-process-region passes it through expand-file-name.
4601
4602 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
4603
46042012-07-17 Andreas Schwab <schwab@linux-m68k.org>
4605
4606 Fix crash when creating indirect buffer (Bug#11917)
4607 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
4608 Don't handle unbound variables specially if non-zero.
4609 (Fbuffer_local_variables): Pass zero.
4610 (clone_per_buffer_values): Pass non-zero.
4611
46122012-07-17 Andreas Schwab <schwab@linux-m68k.org>
4613
4614 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
4615 to make the loop interruptible.
4616
46172012-07-17 Andreas Schwab <schwab@linux-m68k.org>
4618
4619 * gnutls.c (emacs_gnutls_handshake): Only retry if
4620 GNUTLS_E_INTERRUPTED.
4621
cce7fefc
DA
46222012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
4623
4624 Cleanup and convert miscellaneous checks to eassert.
4625 * alloc.c (mark_interval): Fix comment, partially rephrase
4626 old comment from intervals.h (see below).
4627 * intervals.c (find_interval, adjust_intervals_for_insertion)
4628 (delete_interval, adjust_intervals_for_deletion)
4629 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
4630 Convert to eassert.
4631 (adjust_intervals_for_insertion, make_new_interval):
4632 Remove obsolete and unused code.
4633 * intervals.h (struct interval): Remove obsolete comment.
4634 * textprotp.c (erase_properties): Remove unused code.
4635 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
4636 (Fremove_list_of_text_properties): Convert to eassert.
4637
9ea10cc3
CY
46382012-07-17 Chong Yidong <cyd@gnu.org>
4639
4640 * editfns.c (Finsert_char): Doc fix.
4641
3900d5de
DA
46422012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
4643
4644 Fix previous change to make Fmemory_free always accurate.
4645 * alloc.c (make_interval): Update total_free_intervals.
4646 (make_float): Likewise for total_free_floats.
4647 (free_cons, Fcons): Likewise for total_free_conses.
4648 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
4649 Likewise for total_free_vector_bytes.
4650 (Fmake_symbol): Likewise for total_free_symbols.
4651 (bytes_free): Remove.
4652
7098646f
DA
46532012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
4654
4655 Simple free memory accounting feature.
4656 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
4657 (sweep_vectors): Accumulate size of free vectors.
4658 (Fgarbage_collect): Setup bytes_free.
4659 (Fmemory_free): New function.
4660 (syms_of_alloc): Register it.
4661
22657b40
DA
46622012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
4663
4664 Cleanup overlays checking.
4665 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
4666 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
4667 eassert and OVERLAYP.
4668 (sort_overlays): Change to use OVERLAYP.
4669
ddfc8813
RK
46702012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
4671
4672 * editfns.c (Finsert_char): Make it interactive, and make the
4673 second arg optional. Copy interactive spec and docstring from
4674 ucs-insert.
4675
7c26cf3c
PE
46762012-07-17 Paul Eggert <eggert@cs.ucla.edu>
4677
4678 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
4679 Unlike the other wrapped functions, fabs has an unspecified
4680 effect on errno.
4681
5d127af9
JD
46822012-07-16 Jan Djärv <jan.h.d@swipnet.se>
4683
4684 * nsterm.m (keyDown): Interpret flags without left/right bits
4685 as the left key (Bug#11670).
4686
6a0dd1d7
DA
46872012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
4688
4689 Remove empty and useless init functions.
4690 * lisp.h (init_character_once, init_fns, init_image)
4691 (init_filelock, init_sound): Remove prototype.
4692 * character.c (init_character_once): Remove.
4693 * filelock.c (init_filelock): Likewise.
4694 * fns.c (init_fns): Likewise.
4695 * image.c (init_image): Likewise.
4696 * sound.c (init_sound): Likewise.
4697 * emacs.c (main): Adjust accordingly.
4698
7a6136fd
DA
46992012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
4700
4701 * gtkutil.h: Tiny cleanups.
4702 (use_old_gtk_file_dialog): Remove useless declaration.
4703 (xg_uses_old_file_dialog): Add suggested const attribute.
4704
ce811ad9
EZ
47052012-07-15 Eli Zaretskii <eliz@gnu.org>
4706
4707 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
4708 (bidi_paragraph_init): Use it to limit search forward for a strong
4709 directional character in abnormally large paragraphs full of
4710 neutral or weak characters. (Bug#11943)
4711
c9adfeaa
SF
47122012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
4713
4714 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
4715 the toolbar (Bug#9451).
4716 (xg_make_tool_item): Give the widget event box a transparent
4717 background.
4718
fff62aa9
DA
47192012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
4720
4721 Cleanup basic allocation variables and functions.
4722 * alloc.c (ignore_warnings, init_intervals, init_float)
4723 (init_cons, init_symbol, init_marker): Remove.
4724 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
4725 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
4726 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
4727 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
4728 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
4729 (staticidx, init_alloc_once, init_strings, free_ablock):
4730 Remove redundant initialization.
4731 * fns.c (init_weak_hash_tables): Remove.
4732 * lisp.h (init_weak_hash_tables): Remove prototype.
4733
9730daca
DA
47342012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
4735
4736 Use zero_vector where appropriate.
4737 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
4738 accordingly.
4739 * lisp.h (zero_vector): New declaration.
4740 * font.c (null_vector): Remove.
4741 (syms_of_font): Remove initialization and staticpro.
4742 (font_list_entities, font_find_for_lface): Change to use zero_vector.
4743 * keymap.c (Faccessible_keymaps): Likewise.
4744
2e2d2a13
LL
47452012-07-15 Leo Liu <sdl.web@gmail.com>
4746
4747 * fringe.c: Fix typo in comments.
4748
cd276f6e
LL
47492012-07-14 Leo Liu <sdl.web@gmail.com>
4750
4751 * fringe.c: Add a new bitmap exclamation-mark.
4752
5a1131d9
EZ
47532012-07-14 Eli Zaretskii <eliz@gnu.org>
4754
4755 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
4756
4757 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
4758 (HAVE_MENUS): Don't define, defined by editing config.in with
4759 msdos/sed2v2.inp.
4760 (GMALLOC_INHIBIT_VALLOC): Don't define.
4761 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
4762
22e983b7
JB
47632012-07-14 Juanma Barranquero <lekktu@gmail.com>
4764
4765 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
4766
5b3f250f
GM
47672012-07-14 Glenn Morris <rgm@gnu.org>
4768
4769 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
4770 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
4771 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
4772
33d63ff4
GM
47732012-07-13 Glenn Morris <rgm@gnu.org>
4774
5b633342
GM
4775 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
4776
33d63ff4
GM
4777 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
4778 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
4779
b55b9f85
JD
47802012-07-13 Jan Djärv <jan.h.d@swipnet.se>
4781
0dc8cf50
JD
4782 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
4783 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
4784 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
4785 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
4786 where appropriate.
4787 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
4788 as boolean expression.
4789 (x_set_window_size): Remove unused variable toolbar.
4790 (ns_get_color_default, ns_mod_to_lisp): Remove.
4791 (ns_mouse_position): Remove unused variables xchar and ychar.
4792 (ns_compute_glyph_string_overhangs): Remove unused variable face.
4793 (ns_set_vertical_scroll_bar): Remove unused variable count.
4794 (ns_delete_terminal): Remove unused variable i.
4795 (ns_term_init): Remove unused variables r, g and b.
4796 (mouseDown): Remove unused variable window.
4797 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
4798 (initFrameFromEmacs): Remove unused variable vbextra.
4799 (mouseEntered): Remove unused variables p and dpyinfo.
4800 (mouseExited): Remove unused variables p and r.
4801 (ns_define_frame_cursor, ns_clear_frame_area)
4802 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
4803 (menuDown): Assign [sender tag] to variable and cast the variable.
4804
4805 * nsterm.h (menuDown): Add id as type to argument sender.
4806 (ns_display_info_for_name): Add Lisp_Object argument.
4807 (ns_term_init): Add Lisp_Object argument.
4808 (ns_map_event_to_object): Add void argument.
4809 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
4810 prototype with arguments and only declare if __OBJC__.
4811 (nxatoms_of_nsselect): Add void argument.
4812 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
4813 (ns_alloc_autorelease_pool): Add void argument.
4814 (ns_release_autorelease_pool): Add void* argument.
4815 (ns_get_defaults_value): Add const char* argument.
4816
4817 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
4818 (initFromContents): Use SSDATA where appropriate.
4819 (ns_update_menubar): Add braces to ambigous if-else.
4820 (initWithTitle): Put () around assignment in if statement.
4821 (ns_menu_show): Remove unused variables window and keymap.
4822 (update_frame_tool_bar): Remove unused variable selected_p.
4823 (initWithContentRect): Remove unused variable this_cmd_name.
4824
4825 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
4826 appropriate.
4827 (setXBMColor): Remove unused variable len.
4828 (setPixmapData): Put () around assignment in loop statement.
4829
4830 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
4831 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
4832 where appropriate.
4833 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
4834 around assignment in loop statement.
4835 (nsfont_open): Remove unused variable i.
4836 (nsfont_open): Remove unused variable len.
4837 (nsfont_draw): Remove unused variable cs.
4838
4839 * nsfns.m (x_set_icon_name, ns_set_name_internal)
4840 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
4841 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
4842 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
4843 (Fns_font_name, Fns_perform_service)
4844 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
4845 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
4846 (ns_set_name): Remove unused variable view.
4847 (x_set_menu_bar_lines): Remove unused variable olines.
4848 (x_set_tool_bar_lines): Remove unused variable root_window.
4849 (Fns_list_colors): Put () around assignment in while statement.
4850 (Fns_perform_service): Remove unused variable len.
4851 (Fns_display_usable_bounds): Remove unused variable top.
4852 (syms_of_nsfns): Remove unused variable i.
4853
b55b9f85
JD
4854 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
4855 memcpy (Bug#11907).
4856
ed9265fc 48572012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
4858
4859 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
4860 and free it with DestroyExceptionInfo (Bug#11558).
4861
ef099b57
JB
48622012-07-13 Juanma Barranquero <lekktu@gmail.com>
4863
4864 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
4865 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
4866 Set here, not in nt/config.nt.
4867
ea814a5d
EZ
48682012-07-13 Eli Zaretskii <eliz@gnu.org>
4869
4870 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
4871 cursor overflow into the last glyph on display line when the right
4872 fringe is off. (Bug#11832)
4873
1a952767
PE
48742012-07-13 Paul Eggert <eggert@cs.ucla.edu>
4875
4876 * xdisp.c (produce_special_glyphs): Now static.
4877 * dispextern.h (produce_special_glyphs): Remove decl.
4878
983188fd
GM
48792012-07-13 Glenn Morris <rgm@gnu.org>
4880
8d7c7eed 4881 * s/bsd-common.h, s/cygwin.h: Remove empty files.
32fb4bb6
GM
4882 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
4883
983188fd
GM
4884 * s/usg5-4-common.h (USG, USG5):
4885 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
4886 * s/sol2-6.h (SOLARIS2):
4887 * s/irix6-5.h (IRIX6_5):
4888 * s/hpux10-20.h (USG, USG5, HPUX):
4889 * s/gnu-linux.h (USG, GNU_LINUX):
4890 * s/freebsd.h (BSD_SYSTEM):
4891 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
4892 * s/cygwin.h (CYGWIN):
4893 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
4894 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
4895
d1e68667 48962012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
4897
4898 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 4899
6de0e799
GM
49002012-07-13 Glenn Morris <rgm@gnu.org>
4901
739ae010
GM
4902 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
4903
dbee5793
GM
4904 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
4905
6de0e799
GM
4906 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
4907 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
4908
b82da769
GM
49092012-07-12 Glenn Morris <rgm@gnu.org>
4910
4fae5a7a 4911 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
4912
4913 * process.c (init_process_emacs): Rename from init_process.
4914 The old name is also the name of a Mach system call.
4915 * lisp.h, emacs.c: Update for this name change.
4916 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
4917 longer needed.
4918
5a979817
EZ
49192012-07-12 Eli Zaretskii <eliz@gnu.org>
4920
4921 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
4922 memmove call that removes glyphs covered by the left truncation
4923 glyph. Improve commentary.
4924 (display_line): Fix display of continuation glyphs on GUI frames
4925 when the right fringe is turned off and variable-size fonts are
4926 used in the window. Move the code that appends a stretch glyph to
4927 produce_special_glyphs, so that it could be used for truncation
4928 and continuation glyphs alike.
4929 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
4930 glyph of a suitably computed width, to align the special glyphs at
4931 the window margin. Code moved from display_line. (Bug#11832)
4932
3e91a053
GM
49332012-07-12 Glenn Morris <rgm@gnu.org>
4934
ba9e4b84
GM
4935 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
4936
4937 * s/gnu-linux.h, s/hpux10-20.h:
4938 Do not unconditionally define HAVE_XRMSETDATABASE.
4939
3e91a053
GM
4940 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
4941
b300b1f4
PE
49422012-07-12 Paul Eggert <eggert@cs.ucla.edu>
4943
4944 Fix typos that broke OS X build.
4945 Reported by Randal L. Schwartz in
4946 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
4947 * nsterm.m (ns_timeout): Add missing local decl.
4948 (ns_get_color): snprintf -> sprintf, to fix typo.
4949
6e777848
GM
49502012-07-12 Glenn Morris <rgm@gnu.org>
4951
3f922c37
GM
4952 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
4953 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
4954 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
4955 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
4956
0ab7b23a
GM
4957 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
4958 Move PTY_OPEN to configure.
4959
6e777848
GM
4960 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
4961 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
4962 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
4963
4a7edc24
DA
49642012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
4965
4966 Use empty_unibyte_string where applicable.
4967 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
4968 * lread.c (read1): Likewise.
4969 * xsettings.c (syms_of_xsettings): Likewise.
4970
308aab79
GM
49712012-07-12 Glenn Morris <rgm@gnu.org>
4972
42bd1719
GM
4973 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
4974 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
4975 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
4976 * s/hpux10-20.h (RUN_TIME_REMAP):
4977 * s/bsd-common.h (TABDLY): Move to configure.
4978
4979 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
4980
4981 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
4982
ea0bbd17 4983 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 4984 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
4985
4986 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 4987
308aab79
GM
4988 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
4989 * s/template.h: Move NARROWPROTO to configure.
4990
ee1cf5cf
GM
49912012-07-11 Glenn Morris <rgm@gnu.org>
4992
30fe9bf4
GM
4993 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
4994 unused since 2011-01-17 change to systty.h.
4995
ee1cf5cf
GM
4996 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
4997 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
4998 Move HAVE_PTYS and HAVE_SOCKETS to configure.
4999
63e47e07
PE
50002012-07-11 Paul Eggert <eggert@cs.ucla.edu>
5001
5002 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
5003
c43fb4c3
GM
50042012-07-11 Glenn Morris <rgm@gnu.org>
5005
5006 * s/darwin.h, s/gnu-linux.h, s/template.h:
5007 Move INTERRUPT_INPUT to configure.
5008
e8df9267
DA
50092012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
5010
5011 Minor adjustments to interning code.
5012 * lisp.h (intern, intern_c_string): Redefine as static inline
5013 wrappers for intern_1 and intern_c_string_1, respectively.
5014 (intern_1, intern_c_string_1): Rename prototypes.
14ae4239
BT
5015 * lread.c (intern_1, intern_c_string_1, oblookup):
5016 Simplify Vobarray checking.
e8df9267
DA
5017 * font.c (font_intern_prop): Likewise. Adjust comment.
5018 * w32font.c (intern_font_name): Likewise.
5019
34348bd4
AS
50202012-07-11 Andreas Schwab <schwab@linux-m68k.org>
5021
d96a1e0c
AS
5022 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
5023
34348bd4
AS
5024 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
5025 of Fcar/Fcdr if possible.
5026 * font.c (check_otf_features): Likewise.
5027 * fontset.c (Fnew_fontset): Likewise.
5028 * gnutls.c (Fgnutls_boot): Likewise.
5029 * minibuf.c (read_minibuf): Likewise.
5030 * msdos.c (IT_set_frame_parameters): Likewise.
5031 * xmenu.c (Fx_popup_dialog): Likewise.
5032 * w32menu.c (Fx_popup_dialog): Likewise.
5033
c8add24e
GM
50342012-07-11 Glenn Morris <rgm@gnu.org>
5035
4b575b3c
GM
5036 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
5037 since nothing has defined it on these platforms.
5038
09f4e3b0
GM
5039 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
5040 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
5041
172bedef
GM
5042 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
5043 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
5044 Move CLASH_DETECTION to configure.
5045
249685df
GM
5046 * s/gnu.h: Remove file, which is now empty.
5047
c8add24e
GM
5048 * s/gnu.h, s/gnu-linux.h:
5049 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
5050
b41253a3
JW
50512012-07-11 John Wiegley <johnw@newartisans.com>
5052
5053 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
5054 function attribute, so we only use it if it exists in the
5055 compiler.
5056
d923b542
DA
50572012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
5058
5059 Avoid call to strlen in fast_c_string_match_ignore_case.
5060 * search.c (fast_c_string_match_ignore_case): Change to use
5061 length argument. Adjust users accordingly.
5062 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
5063
5ebbef1d
PE
50642012-07-11 Paul Eggert <eggert@cs.ucla.edu>
5065
bb352260
PE
5066 Assume mkdir, rmdir.
5067 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
5068 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
5069
57054ddd
PE
5070 Assume rename.
5071 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
5072
b747d3f7
PE
5073 Assume perror.
5074 * s/hpux10-20.h (HAVE_PERROR): Remove.
5075 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
5076 Remove dummy definition, as this problem was obsolete long ago.
5077
5ebbef1d
PE
5078 Assume strerror.
5079 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
5080
984e7f30
DA
50812012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
5082
5083 Avoid calls to strlen in font processing functions.
5084 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
14ae4239
BT
5085 (font_open_by_name): Change to use length argument.
5086 Adjust users accordingly.
d923b542
DA
5087 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
5088 Adjust prototypes.
5089 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
5090 Change to return ptrdiff_t.
984e7f30
DA
5091 (xfont_list_pattern, xfont_match): Use length returned by
5092 xfont_decode_coding_xlfd.
5093 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
5094
20e94fdd
GM
50952012-07-11 Glenn Morris <rgm@gnu.org>
5096
9d596af3
GM
5097 * s/darwin.h, s/freebsd.h, s/netbsd.h:
5098 Move DONT_REOPEN_PTY to configure.
5099
20e94fdd
GM
5100 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
5101 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
5102
e99a530f
PE
51032012-07-10 Paul Eggert <eggert@cs.ucla.edu>
5104
22ffb973
PE
5105 Remove "#define unix" that is no longer needed (Bug#11905).
5106 * s/aix4-2.h (unix): Remove; no longer needed.
5107
e9a9ae03
PE
5108 EMACS_TIME simplification (Bug#11875).
5109 This replaces macros (which typically do not work in GDB)
5110 with functions, typedefs and enums, making the code easier to debug.
5111 The functional style also makes code easier to read and maintain.
5112 * systime.h: Include <sys/time.h> on all hosts, not just if
5113 WINDOWSNT, since 'struct timeval' is needed in general.
5114 (EMACS_TIME): Now a typedef, not a macro.
5115 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
5116 not macros.
5117 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
5118 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
5119 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
5120 (EMACS_TIME_LE): Now functions, not macros.
5121 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
5122 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
5123 which are not functions. All uses rewritten to use:
5124 (make_emacs_time): New function.
5125 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
5126 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
5127 not functions. All uses rewritten to use the following, respectively:
5128 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
5129 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 5130 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
5131 * fileio.c (Fcopy_file):
5132 * xterm.c (XTflash): Get the current time closer to when it's used.
5133 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
5134
ffacb126
PE
5135 * bytecode.c (targets): Suppress -Woverride-init warnings.
5136
e99a530f
PE
5137 Simplify by avoiding confusing use of strncpy etc.
5138 * doc.c (Fsnarf_documentation):
5139 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
5140 * frame.c (Fmake_terminal_frame):
5141 * gtkutil.c (get_utf8_string):
5142 * lread.c (openp):
5143 * nsmenu.m (ns_update_menubar):
5144 * regex.c (regerror):
5145 Prefer memcpy to strncpy and strncat when either will do.
5146 * fileio.c (Fsubstitute_in_file_name):
5147 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
5148 (menu_separator_name_p):
5149 * nsmenu.m (ns_update_menubar):
5150 Prefer memcmp to strncmp when either will do.
5151 * nsterm.m: Include <ftoastr.h>.
5152 (ns_get_color):
5153 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
5154 Prefer snprintf to strncpy.
5155 * nsterm.m (ns_term_init):
5156 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
5157 * nsterm.m (ns_term_init):
5158 Avoid the need for strncpy, by using build_string or
5159 make_unibyte_string directly. Use dtoastr, not snprintf.
5160 * process.c (Fmake_network_process): Diagnose service names that
5161 are too long, rather than silently truncating them or creating
5162 non-null-terminated names.
5163 (Fnetwork_interface_info): Likewise, for interface names.
5164 * sysdep.c (system_process_attributes) [GNU_LINUX]:
5165 Prefer sprintf to strncat.
5166 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
5167 Prefer vsnprintf to vsprintf + strncpy.
5168
c59592b3
GM
51692012-07-10 Glenn Morris <rgm@gnu.org>
5170
5171 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
5172 Clarify fallback case.
5173
7d7bbefd
DA
51742012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
5175
5176 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
5177 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
5178 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 5179 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
5180 where argument type is known to be a Lisp_Cons.
5181
3a4c8000
TT
51822012-07-10 Tom Tromey <tromey@redhat.com>
5183
5184 * bytecode.c (BYTE_CODE_THREADED): New macro.
5185 (BYTE_CODES): New macro. Replaces all old byte-code defines.
5186 (enum byte_code_op): New type.
5187 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
5188 (exec_byte_code): Use them. Use token threading when applicable.
5189
2a0213a6
DA
51902012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
5191
5192 Optimize pure C strings initialization.
5193 * lisp.h (make_pure_string): Fix prototype.
5194 (build_pure_c_string): New function, defined as static inline. This
5195 provides a better opportunity to optimize away calls to strlen when
5196 the function is called with compile-time constant argument.
5197 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
5198 argument, adjust users accordingly. Use build_pure_c_string where
5199 appropriate.
5200 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
5201 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
5202 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
5203
cb1caeaf
DA
52042012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
5205
5206 Avoid calls to strlen in miscellaneous functions.
5207 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
5208 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
5209 * lread.c (openp): Likewise.
5210
c293e30c
DA
52112012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
5212
5213 Avoid calls to strlen in path processing functions.
5214 * fileio.c (file_name_as_directory): Add comment. Change to add
5215 srclen argument and return the length of result. Adjust users
5216 accordingly.
5217 (directory_file_name): Fix comment. Change to add srclen argument,
14ae4239
BT
5218 swap 1st and 2nd arguments to obey the common convention.
5219 Adjust users accordingly.
c293e30c
DA
5220 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
5221
9e059e3f
GM
52222012-07-10 Glenn Morris <rgm@gnu.org>
5223
d02eb359
GM
5224 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
5225 Move PENDING_OUTPUT_COUNT definition to configure.
5226
882cf227
GM
5227 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
5228 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
5229 * s/gnu.h (DATA_START): Move definitions to configure.
5230
af6e839f
GM
5231 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
5232 We include usg5-4-common.h, which defines them both.
5233
40289a12
GM
5234 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
5235 O_RDONLY already includes it).
5236
9e059e3f
GM
5237 Stop ns builds setting the EMACSLOADPATH environment variable.
5238 * nsterm.m (ns_load_path): Rename from ns_init_paths.
5239 Now it does not set EMACSLOADPATH, just returns the load-path string.
5240 * nsterm.h: Update accordingly.
5241 * lread.c [HAVE_NS]: Include nsterm.h.
5242 (init_lread) [HAVE_NS]: Use ns_load_path.
5243 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
5244
7c4e8ec0
GM
52452012-07-09 Glenn Morris <rgm@gnu.org>
5246
d4f600ff
GM
5247 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
5248 since the included bsd-common.h does so.
5249
cbb31951
GM
5250 Stop ns builds setting the EMACSPATH environment variable.
5251 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
5252 (ns_init_paths): Do not set EMACSPATH.
5253 * nsterm.h (ns_exec_path): Add it.
5254 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
5255 Use ns_exec_path.
5256
7c4e8ec0
GM
5257 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
5258
26bccfae
PE
52592012-07-09 Paul Eggert <eggert@cs.ucla.edu>
5260
a0bee46f
PE
5261 * process.c (wait_reading_process_output): 'waitchannels' was unset
5262 when read_kbd || !NILP (wait_for_cell); fix this.
5263
5994c183
PE
5264 Add GCC-style 'const' attribute to functions that can use it.
5265 * character.h (char_resolve_modifier_mask):
5266 * keyboard.h (make_ctrl_char):
5267 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
5268 (init_character_once, next_almost_prime, init_fns, init_image)
5269 (flush_pending_output, init_sound):
5270 * mem-limits.h (start_of_data):
5271 * menu.h (finish_menu_items):
5272 Add ATTRIBUTE_CONST.
5273 * emacs.c (DEFINE_DUMMY_FUNCTION):
5274 Declare the dummy function with ATTRIBUTE_CONST.
5275 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
5276 Add decls with ATTRIBUTE_CONST.
5277
26bccfae
PE
5278 Minor improvements to make_formatted_string.
5279 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
5280 where int is good enough, as vsprintf returns an int.
5281 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
5282
a8290ec3
DA
52832012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
5284
5285 Use make_formatted_string to avoid double length calculation.
5286 * lisp.h (make_formatted_string): New prototype.
5287 * alloc.c (make_formatted_string): New function.
5288 * buffer.c (Fgenerate_new_buffer_name): Use it.
5289 * dbus.c (syms_of_dbusbind): Likewise.
5290 * editfns.c (Fcurrent_time_zone): Likewise.
5291 * filelock.c (get_boot_time): Likewise.
5292 * frame.c (make_terminal_frame, set_term_frame_name)
5293 (x_report_frame_params): Likewise.
5294 * image.c (gs_load): Likewise.
5295 * minibuf.c (get_minibuffer): Likewise.
5296 * msdos.c (dos_set_window_size): Likewise.
5297 * process.c (make_process): Likewise.
5298 * xdisp.c (ensure_echo_area_buffers): Likewise.
5299 * xsettings.c (apply_xft_settings): Likewise.
5300
d01ba2f1
GM
53012012-07-09 Glenn Morris <rgm@gnu.org>
5302
5303 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
5304 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
5305 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
5306 * nsterm.h (ns_etc_directory): Add it.
5307 * callproc.c [HAVE_NS]: Include nsterm.h.
5308 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
5309
f1f924b6
DA
53102012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
5311
5312 Move marker debugging code under MARKER_DEBUG.
5313 * marker.c (MARKER_DEBUG): Move marker debugging code under
5314 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
5315 for bootstrap with --enable-checking (~3x slowdown reported
5316 by Juanma Barranquero <lekktu@gmail.com>).
5317 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
5318
ab531b66
PE
53192012-07-08 Paul Eggert <eggert@cs.ucla.edu>
5320
5321 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
5322 See <http://bugs.gnu.org/11825#29>.
5323
c4b3bc8a
EZ
53242012-07-08 Eli Zaretskii <eliz@gnu.org>
5325
5326 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
5327 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
5328 (display_line): Add commentary about displaying truncation glyphs
5329 on GUI frames.
5330 (produce_special_glyphs): Move here from term.c.
5331
5332 * term.c (produce_special_glyphs): Move to xdisp.c.
5333
5334 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
5335 section.
c4b3bc8a 5336
b676b881
AS
53372012-07-07 Andreas Schwab <schwab@linux-m68k.org>
5338
f17c5273
AS
5339 * xdisp.c (display_line): Avoid warning about implicit declaration
5340 of FRAME_FONT.
5341
298819b9
AS
5342 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
5343
b676b881
AS
5344 * lisp.h: Remove empty conditional.
5345
6045c4fd
PE
53462012-07-07 Paul Eggert <eggert@cs.ucla.edu>
5347
b3350bf9
PE
5348 * lread.c (load_path_check): Now static.
5349
6045c4fd
PE
5350 Fix some minor --with-ns problems found by static checking.
5351 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
5352 (x_set_font) [!HAVE_X_WINDOWS]:
5353 * image.c (xpm_load_image) [HAVE_NS]:
5354 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
5355 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
5356 Remove unused local.
5357 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
5358 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
5359 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
5360 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
5361 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
5362 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
5363 Fix pointer signedness problem.
5364 * xfaces.c (FRAME_X_FONT_TABLE):
5365 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
5366
929e7845
GM
53672012-07-07 Glenn Morris <rgm@gnu.org>
5368
5369 * lread.c (load_path_check): New function, split from init_lread.
5370 (init_lread): Reorganize. Motivation:
5371 If EMACSLOADPATH is set, check/warn about that rather than the
5372 defaults, which we are not going to use. Hence we can remove
5373 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
5374 Don't warn if site-lisp directories are missing.
5375 If not installed, start from a blank load-path, since
5376 PATH_LOADSEARCH refers to the eventual installation directories.
5377
58dd0aa4
EZ
53782012-07-07 Eli Zaretskii <eliz@gnu.org>
5379
5380 Support truncation and continuation glyphs on GUI frames, when
5381 fringes are disabled. (Bug#11832)
5382 * xdisp.c (init_iterator): Get dimensions of truncation and
14ae4239
BT
5383 continuation glyphs even if on GUI frames.
5384 Adjust it->last_visible_x on GUI frames when the left or right fringes,
58dd0aa4
EZ
5385 or both, are absent.
5386 (start_display, move_it_in_display_line_to): Handle the case of a
5387 GUI frame without a fringe to display continuation or truncation
5388 glyphs.
5389 (insert_left_trunc_glyphs): Support GUI frames: make sure
5390 truncation glyphs overwrite enough glyphs from the current line to
5391 have sufficient space in pixels.
5392 (display_line): Support truncation and continuation glyphs on GUI
5393 frames. If some spare pixels are left on the line after inserting
5394 the truncation glyphs, fill that space with a stretch glyph of a
5395 suitably computed width.
5396
5397 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
5398 produce_glyphs, to support GUI sessions.
5399
31571fd7
PE
54002012-07-07 Paul Eggert <eggert@cs.ucla.edu>
5401
5a16b9bc
PE
5402 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
5403
f3047c75
PE
5404 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
5405
31571fd7
PE
5406 Do not require float-time's arg to fit in time_t (Bug#11825).
5407 This works better on hosts where time_t is unsigned, and where
5408 float-time is applied to the (negative) difference between two times.
5409 * editfns.c (decode_time_components): Last arg is now double *,
5410 not int *, and means to store all the result as a double, without
5411 worrying about whether the seconds part fits in time_t.
5412 All callers changed.
5413 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
5414 All callers changed.
5415 (Ffloat_time): Do not fail merely because the specified time falls
5416 outside of time_t range.
5417
4516fbef
GM
54182012-07-07 Glenn Morris <rgm@gnu.org>
5419
5420 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
5421 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
5422 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
5423
07adc2c6
JB
54242012-07-07 Juanma Barranquero <lekktu@gmail.com>
5425
5426 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
5427 Update dependencies.
5428
5429 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
5430
fd573f31
PE
54312012-07-06 Paul Eggert <eggert@cs.ucla.edu>
5432
fee5959d
PE
5433 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
5434 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
5435 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
5436 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
5437 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
5438 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
5439
fd573f31
PE
5440 * xfont.c (compare_font_names): Redo to omit the need for casts.
5441
ddadbc0e
AS
54422012-07-06 Andreas Schwab <schwab@linux-m68k.org>
5443
fca8d6b6
AS
5444 * xfns.c (Fx_change_window_property): Doc fix.
5445 * w32fns.c (Fx_change_window_property): Doc fix.
5446
ddadbc0e
AS
5447 * w32fns.c (Fx_window_property): Accept the same arguments as the
5448 X Windows version. Doc fix.
5449 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
5450
ed9265fc 54512012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
5452 Eli Zaretskii <eliz@gnu.org>
5453
5454 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
5455 Windows-specific code from nt/config.nt moved here.
5456 Obsolete settings removed.
5457
216ee680
PE
54582012-07-06 Paul Eggert <eggert@cs.ucla.edu>
5459
5460 * process.c: Avoid unnecessary calls to gettime.
5461 (wait_reading_process_output): Don't get the time of day
5462 when gobbling data immediately and not waiting, as there's no need
5463 for it in that case. This removes a FIXME.
5464
bdd091e4
JD
54652012-07-06 Jan Djärv <jan.h.d@swipnet.se>
5466
5467 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
5468 is defined (Bug#11768).
5469
9d44f8ce
DA
54702012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
5471
5472 Fix marker debugging code.
5473 * marker.c (byte_char_debug_check): Do not perform the check
5474 if buffer is not multibyte.
090bd7cb
JB
5475 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
5476 Call byte_char_debug_check with correct arguments.
9d44f8ce 5477
90fc4786
DA
54782012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
5479
5480 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
5481 * marker.c (byte_char_debug_check, count_markers):
5482 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
5483 (byte_debug_flag): Remove.
5484 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
5485 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
5486
7b7ae965
DA
54872012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
5488
4e57b342
DA
5489 Avoid code repetition in marker-related functions.
5490 * marker.c (attach_marker): New function.
5491 (Fset_marker, set_marker_restricted, set_marker_both)
5492 (set_marker_restricted_both): Use it.
5493 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
5494 Consistently rename charno to charpos.
5495 (marker_position): Add eassert.
5496 (marker_byte_position): Convert to eassert.
5497
54982012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
5499
5500 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 5501 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 5502 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 5503
657924ff
DA
55042012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
5505
5506 Introduce fast path for the widely used marker operation.
5507 * alloc.c (build_marker): New function.
5508 * lisp.h (build_marker): New prototype.
5509 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
5510 * composite.c (autocmp_chars): Likewise.
5511 * editfns.c (buildmark): Remove.
5512 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
5513 (save_restriction_save): Use build_marker.
5514 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
5515 * window.c (save_window_save): Likewise.
5516
041a49a6
DA
55172012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
5518
5519 Do not use Fdelete_overlay in delete_all_overlays
5520 to avoid redundant calls to unchain_overlay.
5521 * buffer.c (drop_overlay): New function.
5522 (delete_all_overlays, Fdelete_overlay): Use it.
5523 * minibuf.c (get_minibuffer): Fix comment.
5524
7dca65a4
PE
55252012-07-06 Paul Eggert <eggert@cs.ucla.edu>
5526
5527 Port to OpenBSD 5.1 amd64.
5528 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
5529 This is needed for OpenBSD, and should be harmless on all BSD systems.
5530 Also, include <sys/sysctl.h>, as it should be available on all
5531 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
5532 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
5533 use p_pid member, not kp_proc.pid.
5534
8eb876e2
GM
55352012-07-06 Glenn Morris <rgm@gnu.org>
5536
5537 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
5538
38182d90
PE
55392012-07-05 Paul Eggert <eggert@cs.ucla.edu>
5540
5541 More xmalloc and related cleanup.
5542 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
5543 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
5544 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
5545 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
5546 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
5547 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
5548 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
5549 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
5550 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
5551 * xterm.c:
5552 Omit needless casts involving void * pointers and allocation.
5553 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
5554 as the former is more robust if P's type is changed.
5555 Prefer xzalloc to xmalloc + memset 0.
5556 Simplify malloc-or-realloc to realloc.
5557 Don't worry about xmalloc returning a null pointer.
5558 Prefer xstrdup to xmalloc + strcpy.
5559 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
5560 growing it.
5561 * keyboard.c (apply_modifiers_uncached): Prefer local array to
5562 alloca of a constant.
5563
6dd5a677
EZ
55642012-07-05 Eli Zaretskii <eliz@gnu.org>
5565
5566 * xdisp.c (display_line): Fix horizontal pixel coordinates when
5567 hscroll is larger than the line width. Fixes long and futile
5568 looping inside extend_face_to_end_of_line (on a TTY) producing
5569 glyphs that are not needed and thrown away.
5570
6b312f0f
DA
55712012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
5572
5573 * marker.c (set_marker_restricted_both): Simplify by using
5574 clip_to_bounds.
5575
f520ef9b
PE
55762012-07-05 Paul Eggert <eggert@cs.ucla.edu>
5577
5578 * editfns.c (region_limit): Simplify by using clip_to_bounds.
5579
383b7c95
JD
55802012-07-05 Jan Djärv <jan.h.d@swipnet.se>
5581
5582 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
5583 not defined (Bug#11768).
5584 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
5585 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
5586 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
5587 followed by gtk_box_set_homogeneous (Bug#11768).
5588 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
5589 (update_theme_scrollbar_width, xg_create_scroll_bar):
5590 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
5591 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
5592 (is_box_type): New function (Bug#11768).
5593 (xg_tool_item_stale_p): Call is_box_type.
5293d758 5594 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
5595 with default display (Bug#11768).
5596
d6e7bf45
EZ
55972012-07-05 Eli Zaretskii <eliz@gnu.org>
5598
5599 * xdisp.c (window_hscroll_limited): New function.
5600 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
5601 coordinates when window's hscroll is set to insanely large
5602 values. (Bug#11857)
5603
431391ec
JB
56042012-07-05 Juanma Barranquero <lekktu@gmail.com>
5605
5606 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
5607 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
5608
23f86fce
DA
56092012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
5610
5611 Cleanup xmalloc.
5612 * lisp.h (xzalloc): New prototype. Omit needless casts.
5613 * alloc.c (xzalloc): New function. Omit needless casts.
5614 * charset.c: Omit needless casts. Convert all calls to
5615 xmalloc with following memset to xzalloc.
5616 * dispnew.c: Likewise.
5617 * fringe.c: Likewise.
5618 * image.c: Likewise.
5619 * sound.c: Likewise.
5620 * term.c: Likewise.
5621 * w32fns.c: Likewise.
5622 * w32font.c: Likewise.
5623 * w32term.c: Likewise.
5624 * xfaces.c: Likewise.
5625 * xfns.c: Likewise.
5626 * xterm.c: Likewise.
5627 * atimer.c: Omit needless casts.
5628 * buffer.c: Likewise.
5629 * callproc.c: Likewise.
5630 * ccl.c: Likewise.
5631 * coding.c: Likewise.
5632 * composite.c: Likewise.
5633 * doc.c: Likewise.
5634 * doprnt.c: Likewise.
5635 * editfns.c: Likewise.
5636 * emacs.c: Likewise.
5637 * eval.c: Likewise.
5638 * filelock.c: Likewise.
5639 * fns.c: Likewise.
5640 * gtkutil.c: Likewise.
5641 * keyboard.c: Likewise.
5642 * lisp.h: Likewise.
5643 * lread.c: Likewise.
5644 * minibuf.c: Likewise.
5645 * msdos.c: Likewise.
5646 * print.c: Likewise.
5647 * process.c: Likewise.
5648 * region-cache.c: Likewise.
5649 * search.c: Likewise.
5650 * sysdep.c: Likewise.
5651 * termcap.c: Likewise.
5652 * terminal.c: Likewise.
5653 * tparam.c: Likewise.
5654 * w16select.c: Likewise.
5655 * w32.c: Likewise.
5656 * w32reg.c: Likewise.
5657 * w32select.c: Likewise.
5658 * w32uniscribe.c: Likewise.
5659 * widget.c: Likewise.
5660 * xdisp.c: Likewise.
5661 * xmenu.c: Likewise.
5662 * xrdb.c: Likewise.
5663 * xselect.c: Likewise.
5664
0497dc44
PE
56652012-07-05 Paul Eggert <eggert@cs.ucla.edu>
5666
5667 * fileio.c (time_error_value): Check the right error number.
5668 Problem reported by Troels Nielsen in
5669 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
5670
356e7178
PE
56712012-07-04 Paul Eggert <eggert@cs.ucla.edu>
5672
4e71fd89
PE
5673 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
5674 This should be fixed in a better way; see Eli Zaretskii in
5675 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
5676 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
5677
f0941253
PE
5678 * fileio.c (time_error_value): Rename from special_mtime.
5679 The old name's problems were noted by Eli Zaretskii in
5680 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
5681
065c9eb4
PE
5682 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
5683 This variable's comment says Emacs needs at least one GDB-visible
5684 symbol of type enum pvec_type, to work around GDB problems.
5685 The symbol's value doesn't matter.
5686
356e7178
PE
5687 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
5688 that causes compilation to fail on pre-C99 compilers.
5689
ed9265fc 56902012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
5691
5692 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
5693 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
5694
3884d954
DA
56952012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
5696
d209e2fb 5697 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
5698 headers for buffer_defaults and buffer_local_symbols.
5699 Reported by Juanma Barranquero <lekktu@gmail.com>.
5700
ee28be33
SM
57012012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
5702
5703 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
5704 * lisp.h (enum pvec_type): Use fewer bits.
5705 (PSEUDOVECTOR_SIZE_BITS): New constant.
5706 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
5707 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
5708 change in pvec_type.
5709 (PSEUDOVECTOR_TYPEP): New macro.
5710 (TYPED_PSEUDOVECTORP): Use it.
5711 * fns.c (internal_equal): Adapt code to extract pvectype.
5712 * emacs.c (gdb_pvec_type): Update type.
5713 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
5714 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
5715 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
5716 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
5717 (sweep_vectors): Use it. Use local var `total_bytes' instead of
5718 abusing vector->header.next.nbytes.
5719 (live_vector_p): Use PVEC_TYPE.
5720 (mark_object): Adapt code to extract pvectype. Use switch.
5721
c7f2cd7f
PE
57222012-07-04 Paul Eggert <eggert@cs.ucla.edu>
5723
5724 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
5725 Tighten new eassert a bit.
5726
8ce70ed2
DA
57272012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
5728
5729 Fix compilation with --enable-gcc-warnings and -O1
5730 optimization level.
5731 * doprnt.c (doprnt): Change type of tem to int, initialize
5732 to avoid compiler warning. Add eassert.
5733 * search.c (simple_search): Initialize match_byte to avoid
5734 compiler warning. Add eassert.
5735
dea7f1e5
PE
57362012-07-04 Paul Eggert <eggert@cs.ucla.edu>
5737
24a212eb
PE
5738 Avoid weird behavior with large horizontal scrolls.
5739 Without this change, for example, large hscroll values would
5740 mess up Emacs's display on Fedora 15 x86, presumably due to
5741 overflows in int calculations in the display code.
5742 Also, if buffers had long lines, Emacs would freeze.
5743 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
5744 (set_window_hscroll): New function, containing the old guts of
5745 Fset_window_hscroll. Return the clipped value.
5746 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
5747 This avoids the need to check against PTRDIFF_MAX.
5748
dea7f1e5
PE
5749 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
5750
76046526
DA
57512012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
5752
5753 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
5754
39adff0d
PE
57552012-07-04 Paul Eggert <eggert@cs.ucla.edu>
5756
63807d47
PE
5757 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
5758 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
5759 since GCC 4.4.6 issues a bogus warning for them.
5760
39adff0d
PE
5761 Fix bugs in file timestamp newness comparisons.
5762 * fileio.c (Ffile_newer_than_file_p):
5763 * lread.c (Fload): Use full timestamp resolution of files,
5764 not just the 1-second resolution, so that files that are only
5765 slightly newer still count as newer.
5766 * fileio.c (Ffile_newer_than_file_p): Don't assume file
5767 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
5768
dbeed9a6
PE
57692012-07-03 Paul Eggert <eggert@cs.ucla.edu>
5770
5771 * fileio.c: Improve handling of file time marker. (Bug#11852)
5772 (special_mtime): New function.
5773 (Finsert_file_contents, Fverify_visited_file_modtime):
5774 Use it to set special mtime values consistently.
5775
636334d6
AS
57762012-07-03 Andreas Schwab <schwab@linux-m68k.org>
5777
5778 * fileio.c (Finsert_file_contents): Properly handle st_mtime
5779 marker for non-existing file. (Bug#11852)
5780
e2017fe2
GM
57812012-07-03 Glenn Morris <rgm@gnu.org>
5782
5783 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
5784 and did not make it into globals.h).
5785
404dbd37
TT
57862012-07-03 Tom Tromey <tromey@redhat.com>
5787
5788 * window.c (Fset_window_margins, Fset_window_fringes)
5789 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
5790 * textprop.c (Fprevious_property_change): No longer static.
5791 * syntax.c (Fsyntax_table_p): No longer static.
5792 * process.c (Fget_process, Fprocess_datagram_address): No longer
5793 static.
5794 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
5795 * keyboard.c (Fcommand_execute): No longer static.
5796 Remove EXFUN.
5797 * insdel.c (Fcombine_after_change_execute): No longer static.
5798 * image.c (Finit_image_library): No longer static.
5799 * fileio.c (Fmake_symbolic_link): No longer static.
5800 * eval.c (Ffetch_bytecode): No longer static.
5801 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
5802 * doc.c (Fdocumentation_property, Fsnarf_documentation):
5803 No longer static.
404dbd37
TT
5804 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
5805 static.
5806 * dired.c (Ffile_attributes): No longer static.
5807 * composite.c (Fcomposition_get_gstring): No longer static.
5808 * callproc.c (Fgetenv_internal): No longer static.
5809
5810 * ccl.h: Remove EXFUNs.
5811 * buffer.h: Remove EXFUNs.
5812 * dispextern.h: Remove EXFUNs.
5813 * intervals.h: Remove EXFUNs.
5814 * fontset.h: Remove EXFUN.
5815 * font.h: Remove EXFUNs.
5816 * dosfns.c (system_process_attributes): Remove EXFUN.
5817 * keymap.h: Remove EXFUNs.
5818 * lisp.h: Remove EXFUNs.
5819 * w32term.h: Remove EXFUNs.
5820 * window.h: Remove EXFUNs.
5821 * xsettings.h: Remove EXFUN.
5822 * xterm.h: Remove EXFUN.
5823
8e4fd1e1
GM
58242012-07-03 Glenn Morris <rgm@gnu.org>
5825
5826 * lisp.h (Frandom): Make it visible to C.
5827 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
5828 buffer for invisible buffers. (Bug#1229)
5829
ca95b3eb
DA
58302012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
5831
5832 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
5833 values which aren't power of 2.
14ae4239
BT
5834 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro.
5835 Verify it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
ca95b3eb
DA
5836 accordingly.
5837
7555c33f
SM
58382012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
5839
5840 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
5841
5842 * alloc.c (mark_object): Revert part of last patch to use `switch'.
5843
d12e8f5a
DA
58442012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
5845
5846 * alloc.c (allocate_vector_block): Remove redundant
5847 calls to mallopt if DOUG_LEA_MALLOC is defined.
5848 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
5849 avoid calls to mallopt if zero_vector is returned.
5850
296094c3
DA
58512012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
5852
5853 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
5854 is enabled, avoid dereferencing NULL current_sblock if
5855 running undumped.
5856
36429c89
DA
58572012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
5858
5859 Cleanup basic buffer management.
5860 * buffer.h (struct buffer): Change layout to use generic vector
5861 marking code. Fix some comments. Change type of 'clip_changed'
5862 to bitfield. Remove unused #ifndef old.
5863 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
5864 (GET_OVERLAYS_AT): Fix indentation.
5865 (for_each_per_buffer_object_at): New macro.
5866 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
5867 (Fbuffer_local_variables): Use it.
5868 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
5869 * alloc.c (allocate_buffer): Adjust to match new layout of
5870 struct buffer. Fix comment.
5871 (mark_overlay): New function.
5872 (mark_buffer): Use it. Use mark_vectorlike to mark normal
5873 Lisp area of struct buffer.
5874 (mark_object): Use it. Adjust marking of misc objects
5875 and related comments.
5876
3b3e4cac
PE
58772012-07-02 Paul Eggert <eggert@cs.ucla.edu>
5878
5879 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
5880 wrapper that is not needed because the wrapped code is a no-op (zero
5881 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
5882 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
5883
cf5c0175
DA
58842012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
5885
5886 * alloc.c (mark_buffer): Simplify. Remove prototype.
5887 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 5888 objects. Use CHECK_LIVE for all vector-like objects except buffers
14ae4239
BT
5889 and subroutines when GC_CHECK_MARKED_OBJECTS is defined.
5890 Avoid redundant calls to mark_vectorlike for bool vectors.
cf5c0175 5891
ca26824c
GM
58922012-06-30 Glenn Morris <rgm@gnu.org>
5893
2e4c5312
GM
5894 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
5895
ca26824c
GM
5896 * epaths.in (PATH_SITELOADSEARCH): New.
5897 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
5898 This is rather than relying on --enable-locallisppath elements
5899 having "site-lisp" in their names. (Bug#10208#25, 11658)
5900
0d23c240
EZ
59012012-06-30 Eli Zaretskii <eliz@gnu.org>
5902
c9240d7a
EZ
5903 * w32proc.c (sys_select): Accept and ignore one more argument.
5904
5905 * w32.c (emacs_gnutls_pull): Call select with one more argument.
5906
0d23c240 5907 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 5908 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
5909
5910 * sysdep.c: Don't include dos.h and dosfns.h.
5911
5912 * process.c (sys_select):
5913 * msdos.c (sys_select): Accept one more argument and ignore it.
5914
5915 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
5916 adapt data types and code to that.
5917
5918 * dosfns.c:
5919 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
5920 which clashes with the gnulib function of the same name.
5921
af5a5a98
AS
59222012-06-30 Andreas Schwab <schwab@linux-m68k.org>
5923
c5e4379c
AS
5924 * font.c (font_style_to_value, font_style_symbolic)
5925 (font_prop_validate_style): Add type checks for values in
5926 font_style_table.
5927
af5a5a98
AS
5928 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
5929 argument.
5930 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
5931 uses.
5932
8d38f461
EZ
59332012-06-29 Eli Zaretskii <eliz@gnu.org>
5934
2e5a6631
EZ
5935 * xdisp.c (try_window_id): Undo last change.
5936
8d38f461
EZ
5937 * w32.c (getwd): Adjust commentary about startup_dir.
5938 (init_environment): Always call sys_access, even in non-MSVC
5939 builds. Don't chdir to the directory of the Emacs executable.
5940 This undoes code from 1997 which was justified by the need to
5941 "avoid conflicts when removing and renaming directories". But its
5942 downside was that every relative file name was being interpreted
5943 relative to the directory of the Emacs executable, which can never
5944 be TRT. In particular, it broke sys_access when called with
5945 relative file names.
5946 (sys_access): Map GetLastError to errno.
5947
2af3565e
DA
59482012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
5949
5950 * window.h (struct window): Change type of 'fringes_outside_margins'
5951 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 5952 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
5953 Adjust comment.
5954 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
5955 to ptrdiff_t.
5956
c8d3a25c 59572012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 5958
c8d3a25c
GM
5959 * gnutls.c (emacs_gnutls_handshake):
5960 Add QUIT to make the loop interruptible.
57570cd3 5961
c8d3a25c 59622012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 5963
c8d3a25c
GM
5964 * charset.c (init_charset): Make lack of etc/charsets fatal.
5965
3e984ee8
DA
59662012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
5967
5968 * editfns.c (region_limit): Fix type mismatch.
5969
ef884f23
DA
59702012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
5971
5972 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
5973 undefined. Convert from xassert to eassert.
5974 * nsmenu.m: Convert from xassert to eassert.
5975 * nsterm.m: Likewise.
5976
7d7e0027
SM
59772012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
5978
5979 * editfns.c (region_limit): Clip to narrowing (bug#11770).
5980
aa754e6a
PE
59812012-06-28 Paul Eggert <eggert@cs.ucla.edu>
5982
5983 Avoid integer overflow on scroll-left and scroll-right.
5984 * window.c (HSCROLL_MAX): New macro.
5985 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
5986 overflow when requested scroll falls outside ptrdiff_t range.
5987
80b00b08
DA
59882012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
5989
5990 * window.h (struct window): Change type of 'hscroll',
5991 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
5992 'last_modified' and 'last_overlay_modified' to EMACS_INT.
5993 Adjust users accordingly.
5994 * xdisp.c (try_cursor_movement): Replace type check with eassert.
5995 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
5996 from EMACS_INT to ptrdiff_t.
5997 (make_window): Omit redundant initialization.
5998
62b2bcf6
JB
59992012-06-28 Juanma Barranquero <lekktu@gmail.com>
6000
6001 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
6002
45942c7d
DA
60032012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
6004
6005 * window.h (struct window): Change type of 'use_time' and
6006 'sequence_number' from Lisp_Object to int.
6007 * frame.c (make_frame): Adjust users accordingly.
6008 * print.c (print_object): Likewise.
6009 * window.c (select_window, Fwindow_use_time, make_parent_window)
6010 (make_window): Likewise.
6011
e509cfa6
DA
60122012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
6013
6014 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
6015 enabled with --enable-checking=[all,glyphs] configure option.
6016 Fix GLYPH_DEBUG usage assuming that it may be undefined,
6017 adjust comments accordingly.
6018 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
6019 undefined, adjust comments accordingly.
6020 * image.c: Likewise.
6021 * scroll.c: Likewise.
6022 * w32fns.c: Likewise.
6023 * w32term.c: Likewise.
6024 * xdisp.c: Likewise.
6025 * xfaces.c: Likewise.
6026 * xfns.c: Likewise.
6027 * xterm.c: Likewise.
6028
a54e2c05
DA
60292012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
6030
6031 Generalize run-time debugging checks.
6032 * dispextern.h (XASSERTS): Remove.
6033 * fontset.c (xassert): Remove.
6034 Convert from xassert to eassert.
6035 * alloc.c: Convert from xassert to eassert.
6036 * bidi.c: Likewise.
6037 * dispnew.c: Likewise.
6038 * fns.c: Likewise.
6039 * fringe.c: Likewise.
6040 * ftfont.c: Likewise.
6041 * gtkutil.c: Likewise.
6042 * image.c: Likewise.
6043 * keyboard.c: Likewise.
6044 * menu.c: Likewise.
6045 * process.c: Likewise.
6046 * scroll.c: Likewise.
6047 * sound.c: Likewise.
6048 * term.c: Likewise.
6049 * w32console.c: Likewise.
6050 * w32fns.c: Likewise.
6051 * w32term.c: Likewise.
6052 * window.c: Likewise.
6053 * xdisp.c: Likewise.
6054 * xfaces.c: Likewise.
6055 * xfns.c: Likewise.
6056 * xselect.c: Likewise.
6057 * xterm.c: Likewise.
6058
1ec4b7b2
SM
60592012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
6060
6061 * fns.c (maybe_resize_hash_table): Output message when growing the
6062 purify-hashtable.
6063
2014308a
DA
60642012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
6065
6066 * alloc.c (allocate_string_data): Remove dead code.
6067 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
6068 avoid GCC warning about unused macro.
6069
246155eb
DA
60702012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
6071
6072 * alloc.c (allocate_string): Omit intervals initialization.
6073 * alloc.c (make_uninit_multibyte_string): Initialize intervals
6074 as in make_pure_string and make_pure_c_string.
6075
43184b7b
DA
60762012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
6077
d209e2fb 6078 * alloc.c (allocate_string): Fix last change.
43184b7b 6079
3fe6dd74
DA
60802012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
6081
d209e2fb 6082 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
6083 to memset, add explicit initialization where appropriate.
6084
1ba6038a
GM
60852012-06-27 Glenn Morris <rgm@gnu.org>
6086
6087 * lisp.mk (lisp): Remove paths.elc.
6088
c89926a5
CY
60892012-06-27 Chong Yidong <cyd@gnu.org>
6090
6091 * doc.c (Fsubstitute_command_keys): Fix punctuation.
6092
ed6b3510
JW
60932012-06-26 John Wiegley <johnw@newartisans.com>
6094
1ec4b7b2 6095 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
6096 on Mac OS X Lion: __mod_init_func and __mod_term_func.
6097
ed6b3510
JW
6098 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
6099 when building with Clang.
6100
8edd4a2b
SM
61012012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
6102
6103 * eval.c (Fapply): Allow calling it with a single argument.
6104
f6f62d1b
EZ
61052012-06-26 Eli Zaretskii <eliz@gnu.org>
6106
6107 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
6108 _stricmp and _strnicmp.
6109 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
6110
62efea5e
DA
61112012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
6112
6113 * alloc.c (allocate_window): Zero out non-Lisp part of newly
6114 allocated window.
6115 (allocate_process): Likewise for new process.
8edd4a2b 6116 (allocate_terminal): Change to use offsetof.
62efea5e
DA
6117 (allocate_frame): Likewise.
6118 * frame.c (make_frame): Omit redundant initialization.
6119 * window.c (make_parent_window): Use memset.
6120 (make_window): Omit redundant initialization.
6121 * process.c (make_process): Omit redundant initialization.
6122 * terminal.c (create_terminal): Likewise.
6123
42997f4d
DA
61242012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
6125
6126 * term.c (delete_tty): Remove redundant call to memset.
6127
1130ecfc
DA
61282012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
6129
6130 * alloc.c: Remove build_string.
6131 * lisp.h: Define build_string as static inline. This provides
6132 a better opportunity to optimize away calls to strlen when the
6133 function is called with compile-time constant argument.
6134 * image.c (imagemagick_error): Convert to build_string.
6135 * w32proc.c (sys_spawnve): Likewise.
6136 * xterm.c (x_term_init): Likewise.
6137
cf38a720
PE
61382012-06-26 Paul Eggert <eggert@cs.ucla.edu>
6139
99027bdd
PE
6140 Use sprintf return value instead of invoking strlen on result.
6141 In the old days this wasn't portable, since some sprintf
6142 implementations returned char *. But they died out years ago and
6143 Emacs already assumes sprintf returns int.
6144 Similarly for float_to_string.
6145 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
6146 * ccl.c (ccl_driver):
6147 * character.c (string_escape_byte8):
6148 * data.c (Fnumber_to_string):
6149 * doprnt.c (doprnt):
6150 * print.c (print_object):
6151 * xdisp.c (message_dolog):
6152 * xfns.c (syms_of_xfns):
6153 Use sprintf or float_to_string result to avoid need to call strlen.
6154 * data.c (Fnumber_to_string):
6155 Use make_unibyte_string, since the string must be ASCII.
6156 * lisp.h, print.c (float_to_string): Now returns int length.
6157 * term.c (produce_glyphless_glyph):
6158 Use sprintf result rather than recomputing it.
6159
cf38a720
PE
6160 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
6161 * Makefile.in (ALL_CFLAGS):
6162 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
6163 * gmalloc.c, regex.c: Include <config.h> unconditionally.
6164
3511c784
DA
61652012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
6166
0a08eb21 6167 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
6168 strcasecmp if available.
6169 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
6170
fb7da12e
AS
61712012-06-25 Andreas Schwab <schwab@linux-m68k.org>
6172
6173 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
6174 Avoid comma operator.
6175 * menu.c (push_submenu_start, push_submenu_end)
6176 (push_left_right_boundary, push_menu_pane): Likewise.
6177 * msdos.c (dos_rawgetc): Likewise.
6178
afa2ffd8
DA
61792012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
6180
6181 * xfns.c (xic_create_fontsetname): Remove redundant calls
6182 to memset.
6183
b3b4476b
PE
61842012-06-25 Paul Eggert <eggert@cs.ucla.edu>
6185
4495ff38
PE
6186 * gtkutil.c (get_utf8_string): Remove redundant assignment.
6187 sprintf already null-terminates its output.
6188
b3b4476b
PE
6189 * xfns.c (x_window): Remove redundant cast.
6190
b00876c9
DA
61912012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
6192
6193 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
6194 `const char *' to `char *' to avoid compiler warning.
6195
d188e26b
PE
61962012-06-24 Paul Eggert <eggert@cs.ucla.edu>
6197
885d1d74
PE
6198 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
6199 instead of truncating it to 63 (admittedly a generous limit).
6200
d188e26b
PE
6201 * process.c: Fix spelling and caps in comments.
6202
e2f560b1
DN
62032012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
6204
e86db54b 6205 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
6206 * sysdep.c (setpgrp): Remove definition, not used in this file.
6207
7583a3a1
JB
62082012-06-24 Juanma Barranquero <lekktu@gmail.com>
6209
6210 * makefile.w32-in: Update dependencies.
6211
696056c2
EZ
62122012-06-24 Eli Zaretskii <eliz@gnu.org>
6213
6214 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
6215 (SYSTIME_H): Add nt/inc/sys/time.h.
6216
6217 * systime.h [WINDOWSNT]: Include sys/time.h.
6218
6219 * s/ms-w32.h (struct timespec): Definition moved from
6220 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
6221
845ca893
PE
62222012-06-24 Paul Eggert <eggert@cs.ucla.edu>
6223
6224 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
6225 * buffer.h (buffer_slot_type_mismatch):
6226 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
6227 * eval.c (unwind_to_catch):
6228 * image.c (my_png_error, my_error_exit):
6229 * keyboard.c (quit_throw_to_read_char, user_error)
6230 (Fexit_recursive_edit, Fabort_recursive_edit):
6231 * lisp.h (die, args_out_of_range, args_out_of_range_3)
6232 (wrong_type_argument, buffer_overflow, __executable_start)
6233 (memory_full, buffer_memory_full, string_overflow, Fthrow)
6234 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
6235 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
6236 (fatal):
6237 (child_setup) [!DOS_NT]:
6238 * lread.c (end_of_file_error, invalid_syntax):
6239 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
6240 * puresize.h (pure_write_error):
6241 * search.c (matcher_overflow):
6242 * sound.c (sound_perror, alsa_sound_perror):
6243 * sysdep.c, syssignal.h (croak):
6244 * term.c (maybe_fatal, vfatal):
6245 * textprop.c (text_read_only):
6246 * undo.c (user_error):
6247 * unexmacosx.c (unexec_error):
6248 * xterm.c (x_ins_del_lines, x_delete_glyphs):
6249 Use _Noreturn rather than NO_RETURN.
6250 No need for separate decl merely because of _Noreturn.
6251 * sound.c (sound_warning, parse_sound):
6252 Remove unnecessary forward decls.
6253
f1dd8073
PE
62542012-06-24 Paul Eggert <eggert@cs.ucla.edu>
6255
6256 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
6257 * lisp.h (WAIT_READING_MAX): New macro.
6258 * dispnew.c (Fsleep_for, sit_for):
6259 * keyboard.c (kbd_buffer_get_event):
6260 * process.c (Faccept_process_output):
6261 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
6262 This improves on the previous patch, which introduced a bug
6263 when time_t is unsigned and as wide as intmax_t.
6264 See <http://bugs.gnu.org/9000#51>.
6265
b82c1755
EZ
62662012-06-23 Eli Zaretskii <eliz@gnu.org>
6267
6268 * dispnew.c (sit_for, Fsleep_for):
6269 * keyboard.c (kbd_buffer_get_event):
6270 * process.c (Faccept_process_output): Avoid compiler warnings when
6271 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
6272
ca300656
JB
62732012-06-23 Juanma Barranquero <lekktu@gmail.com>
6274
049ec95b
JB
6275 * makefile.w32-in: Update dependencies.
6276
ca300656
JB
6277 * w32.c (ltime): Add return type and declare static.
6278 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
6279
db7b8d06
PE
62802012-06-23 Paul Eggert <eggert@cs.ucla.edu>
6281
6282 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
6283 Privately reported by Herbert J. Skuhra.
6284 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
6285 All uses changed.
6286 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
6287 not make_lisp_timeval, when the argument is of type EMACS_TIME.
6288
0bd8297f
EZ
62892012-06-23 Eli Zaretskii <eliz@gnu.org>
6290
96512555
EZ
6291 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
6292 last argument of make_unibyte_string.
6293
0bd8297f
EZ
6294 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
6295 language ID in the event parameters.
6296
6297 * w32term.c (w32_read_socket): Put the new keyboard codepage into
6298 event.code, not the obscure "character set ID".
6299
63def6b6
CY
63002012-06-23 Chong Yidong <cyd@gnu.org>
6301
6302 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
6303
e8a02204
EZ
63042012-06-23 Eli Zaretskii <eliz@gnu.org>
6305
388cdec0
EZ
6306 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
6307 * w32.c (fdutimens): New function.
6308
6309 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
6310
6311 * s/ms-w32.h (pselect): Redirect to sys_select.
6312
6313 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
6314
e8a02204
EZ
6315 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
6316 in the logic of incrementing and decrementing the value of
6317 use_relocatable_buffers.
6318
d054f3fb
PE
63192012-06-23 Paul Eggert <eggert@cs.ucla.edu>
6320
6321 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
6322 Privately reported by Herbert J. Skuhra.
6323 [__FreeBSD__]: Remove "*/" typo after "#include".
6324 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
6325 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
6326 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
6327 Don't assume EMACS_TIME and struct timeval are the same type.
6328
d35af63c
PE
63292012-06-22 Paul Eggert <eggert@cs.ucla.edu>
6330
6331 Support higher-resolution time stamps (Bug#9000).
6332 The time stamps are only nanosecond-resolution at the C level,
6333 since that's the best that any real-world system supports now.
6334 But they are picosecond-resolution at the Lisp level, as that's
6335 easy, and leaves room for future OS improvements.
6336
6337 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
6338 (LIBES): Use it.
6339
6340 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
6341 Don't get current time unless it's needed.
6342
6343 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
6344 now provides it if it's absent.
6345 (start_atimer): Port to higher-res time stamps.
6346 Check for time stamp overflow. Don't get current time more
6347 often than is needed.
6348
6349 * buffer.h (struct buffer): Buffer modtime now has high resolution.
6350 Include systime.h, not time.h.
6351 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
6352
6353 * dired.c: Include stat-time.h.
6354 (Ffile-attributes): File times now have higher resolution.
6355
6356 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
6357 (struct image): Timestamp now has higher resolution.
6358
6359 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
6360 has at least microseconds now. All uses removed.
6361 (update_frame, update_single_window, update_window, update_frame_1)
6362 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
927c7216 6363 (duration_to_sec_usec): Remove; no longer needed.
d35af63c
PE
6364
6365 * editfns.c (time_overflow): Now extern.
6366 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
6367 (float-time, Fformat_time_string, Fcurrent_time_string)
6368 (Fcurrent_time_zone): Accept and generate higher-resolution
6369 time stamps.
6370 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
6371 (decode_time_components, lisp_seconds_argument): New functions.
6372 (make_time): Now static.
6373 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
6374 Report an error if the time is invalid, rather than having the caller
6375 do that.
6376
6377 * fileio.c: Include <stat-time.h>
6378 (Fcopy_file): Copy higher-resolution time stamps.
6379 Prefer to set the time stamp via a file descriptor if that works.
6380 (Fset_file_times, Finsert_file_contents, Fwrite_region)
6381 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
6382 (Fvisited_file_modtime, Fset_visited_file_modtime):
6383 Support higher-resolution time stamps.
6384
6385 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
6386
6387 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
6388
6389 * image.c (prepare_image_for_display, clear_image_cache)
6390 (lookup_image): Port to higer-resolution time stamps.
6391
6392 * keyboard.c (start_polling, bind_polling_period):
6393 Check for time stamp overflow.
6394 (read_char, kbd_buffer_get_event, timer_start_idle)
6395 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
6396 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
6397 Port to higher-resolution time stamps. Do not assume time_t is signed.
6398 (decode_timer): New function. Timers are now vectors of length 9,
6399 not 8, to accommodate the picosecond component.
6400 (timer_check_2): Use it.
6401
6402 * nsterm.m (select_timeout, timeval_subtract): Remove.
6403 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
6404 as they're a bit more accurate and handle overflow better.
6405 (ns_select): Change prototype to be compatible with pselect.
6406 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
6407 * nsterm.h (ns_select): Adjust prototype.
6408
6409 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
6410 us-resolution time stamps.
6411 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
6412
6413 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
6414
6415 * lisp.h (time_overflow): New decl.
6416 (wait_reading_process_output): First arg is now intmax_t, not int,
6417 to accommodate larger waits.
6418
6419 * process.h (struct Lisp_Process.read_output_delay):
6420 Now counts nanoseconds, not microseconds.
6421 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
6422 EMACS_HAS_USECS.
6423 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
6424 (wait_reading_process_output):
6425 Port to ns-resolution time stamps.
6426 (Faccept_process_output, wait_reading_process_output):
6427 Check for time stamp overflow. Do not assume time_t is signed.
6428 (select_wrapper): Remove; we now use pselect.
6429 (Fprocess_attributes): Now generates ns-resolution time stamps.
6430
6431 * sysdep.c: Include utimens.h. Don't include utime.h
6432 or worry about struct utimbuf; gnulib does that for us now.
6433 (gettimeofday): Remove; gnulib provides a substitute.
6434 (make_timeval): New function.
6435 (set_file_times): Now sets ns-resolution time stamps.
6436 New arg FD; all uses changed.
6437 (time_from_jiffies, ltime_from_jiffies, get_up_time)
6438 (system_process_attributes):
6439 Now returns ns-resolution time stamp. All uses changed.
6440 Check for time stamp overflow.
6441
6442 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
6443 provides a substitute now.
6444
6445 * systime.h: Include timespec.h rather than sys/time.h and time.h,
6446 since it guarantees struct timespec.
6447 (EMACS_TIME): Now struct timespec, so that we can support
6448 ns-resolution time stamps.
6449 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
6450 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
6451 (EMACS_USECS): Remove.
6452 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
6453 so multiply the arg by 1000 before storing it.
6454 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
6455 New macros.
6456 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
6457 Port to ns-resolution time stamps.
6458 (EMACS_TIME_NEG_P): Remove; replaced by....
6459 (EMACS_TIME_SIGN): New macro.
6460 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
6461 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
6462 (set_file_times, make_time, lisp_time_argument): Adjust signature.
6463 (make_timeval, make_lisp_time, decode_time_components): New decls.
6464 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
6465 that it mishandled time_t overflow. You can't compare by subtracting!
6466 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
6467 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
6468
6469 * term.c: Include <sys/time.h>.
6470 (timeval_to_Time): New function, for proper overflow wraparound.
6471 (term_mouse_position, term_mouse_click): Use it.
6472
6473 * undo.c (record_first_change): Support higher-resolution time stamps
6474 in the undo buffer.
6475 (Fprimitive_undo): Use them when restoring time stamps.
6476
6477 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
6478 (w32_get_internal_run_time):
6479 Port to higher-resolution Emacs time stamps.
6480 (ltime): Now accepts single 64-bit integer, as that's more convenient
6481 for callers.
6482
6483 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
6484
6485 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
6486 for compatibility with pselect. Support ns-resolution time stamps.
6487
6488 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
6489
6490 * xselect.c (wait_for_property_change, x_get_foreign_selection):
6491 Check for time stamp overflow, and support ns-resolution time stamps.
6492
6493 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
6494 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
6495 (timeval_subtract): Remove; no longer needed.
6496 (XTflash, XTring_bell, x_wait_for_event):
6497 Port to ns-resolution time stamps. Don't assume time_t is signed.
6498
b6a92dfe
CY
64992012-06-22 Chong Yidong <cyd@gnu.org>
6500
6501 * xdisp.c (x_consider_frame_title): Revert last change.
6502
d251c37c
EZ
65032012-06-22 Eli Zaretskii <eliz@gnu.org>
6504
6505 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
6506 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
6507 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
6508 staticidx goes up to 1597 out of 1600 = 0x640.)
6509
f10deafb
PE
65102012-06-20 Paul Eggert <eggert@cs.ucla.edu>
6511
6512 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
6513 Otherwise, the umask might be mistakenly 0 while handling input signals.
6514
ec6de1e2
SM
65152012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
6516
6517 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
6518
28be1ada
DA
65192012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
6520
6521 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
6522 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
6523 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
6524 access to `contents' member of Lisp_Vector objects with AREF and ASET
6525 where appropriate.
6526
c6bf3022
CY
65272012-06-19 Chong Yidong <cyd@gnu.org>
6528
6529 * frame.c (delete_frame): When selecting a frame on a different
6530 text terminal, do not alter the terminal's top-frame.
6531
6532 * xdisp.c (format_mode_line_unwind_data): Record the target
6533 frame's selected window and its terminal's top-frame.
6534 (unwind_format_mode_line): Restore them.
6535 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
6536 Callers changed.
6537 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
6538 since tty frames can be explicitly named.
6539 (prepare_menu_bars): Likewise.
6540
6541 * term.c (Ftty_top_frame): New function.
6542
defd4196
PE
65432012-06-18 Paul Eggert <eggert@cs.ucla.edu>
6544
6545 Port byte-code-meter to modern targets.
6546 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
6547 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 6548 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
6549 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
6550 (METER_1, METER_2): Simplify.
6551
1053a871
SM
65522012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
6553
6554 * data.c (Fdefalias): Return `symbol' (bug#11686).
6555
b7e8d081
MR
65562012-06-18 Martin Rudalics <rudalics@gmx.at>
6557
6558 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
6559 gets killed during executing of this function (Bug#11665).
6560 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
6561 (Vkill_buffer_query_functions): In doc-string say that functions
6562 run by this hook should not change the current buffer.
6563
7ea2b339
PE
65642012-06-18 Paul Eggert <eggert@cs.ucla.edu>
6565
6566 Fix recently-introduced process.c problems found by static checking.
6567 * process.c (write_queue_push, write_queue_pop, send_process):
6568 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
6569 (write_queue_pop): Fix pointer signedness problem.
6570 (send_process): Remove unused local.
6571
96a313a1
CY
65722012-06-17 Chong Yidong <cyd@gnu.org>
6573
6574 * xdisp.c (redisplay_internal): No need to redisplay terminal
6575 frames that are not on top.
6576
20ca2e94
TN
65772012-06-17 Troels Nielsen <bn.troels@gmail.com>
6578
6579 * process.c (make_process): Initialize write_queue.
6580 (write_queue_push, write_queue_pop): New functions.
6581 (send_process): Use them to maintain correct ordering of process
6582 writes (Bug#10815).
6583
9a900ca9
PE
65842012-06-17 Paul Eggert <eggert@cs.ucla.edu>
6585
310fbfa8
PE
6586 * lisp.h (eassert): Assume C89 or later.
6587 This removes the need for CHECK.
6588 (CHECK): Remove. Its comments about always evaluating its
6589 argument were confusing, as 'eassert' typically does not evaluate
6590 its argument.
6591
27bb1ca4
PE
6592 * coding.c (produce_chars): Use ptrdiff_t, not int.
6593
9a900ca9
PE
6594 * xterm.c (x_draw_underwave): Check for integer overflow.
6595 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
6596
41b7f8bc 65972012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
6598
6599 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
6600 referenced (Bug#11583).
6601
9b0e3eba
AA
66022012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
6603
6604 Implement wave-style variant of underlining.
6605 * dispextern.h (face_underline_type): New enum.
6606 (face): Add field for underline type.
6607 * nsterm.m (ns_draw_underwave): New function.
6608 (ns_draw_text_decoration): Use it.
6609 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
6610 New functions.
6611 (x_draw_glyph_string): Use them.
6612 * xfaces.c (Qline, Qwave): New Lisp objects.
6613 (check_lface_attrs, merge_face_ref)
1053a871
SM
6614 (Finternal_set_lisp_face_attribute, realize_x_face):
6615 Handle wave-style underline face attributes.
9b0e3eba
AA
6616 * xterm.c (x_draw_underwave): New function.
6617 (x_draw_glyph_string): Use it.
6618
0fb52f11
JB
66192012-06-16 Juanma Barranquero <lekktu@gmail.com>
6620
6621 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
6622 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
6623 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
6624 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
6625 ($(BLD)/w32select.$(O)): Update dependencies.
6626
e5560ff7
AS
66272012-06-16 Andreas Schwab <schwab@linux-m68k.org>
6628
6629 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
6630 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
6631 * character.c (_fetch_multibyte_char_p): Remove.
6632 * alloc.c: Include "character.h" before "buffer.h".
6633 * bidi.c: Likewise.
6634 * buffer.c: Likewise.
6635 * bytecode.c: Likewise.
6636 * callint.c: Likewise.
6637 * callproc.c: Likewise.
6638 * casefiddle.c: Likewise.
6639 * casetab.c: Likewise.
6640 * category.c: Likewise.
6641 * cmds.c: Likewise.
6642 * coding.c: Likewise.
6643 * composite.c: Likewise.
6644 * dired.c: Likewise.
6645 * dispnew.c: Likewise.
6646 * doc.c: Likewise.
6647 * dosfns.c: Likewise.
6648 * editfns.c: Likewise.
6649 * emacs.c: Likewise.
6650 * fileio.c: Likewise.
6651 * filelock.c: Likewise.
6652 * font.c: Likewise.
6653 * fontset.c: Likewise.
6654 * fringe.c: Likewise.
6655 * indent.c: Likewise.
6656 * insdel.c: Likewise.
6657 * intervals.c: Likewise.
6658 * keyboard.c: Likewise.
6659 * keymap.c: Likewise.
6660 * lread.c: Likewise.
6661 * macros.c: Likewise.
6662 * marker.c: Likewise.
6663 * minibuf.c: Likewise.
6664 * nsfns.m: Likewise.
6665 * nsmenu.m: Likewise.
6666 * print.c: Likewise.
6667 * process.c: Likewise.
6668 * regex.c: Likewise.
6669 * region-cache.c: Likewise.
6670 * search.c: Likewise.
6671 * syntax.c: Likewise.
6672 * term.c: Likewise.
6673 * textprop.c: Likewise.
6674 * undo.c: Likewise.
6675 * unexsol.c: Likewise.
6676 * w16select.c: Likewise.
6677 * w32fns.c: Likewise.
6678 * w32menu.c: Likewise.
6679 * window.c: Likewise.
6680 * xdisp.c: Likewise.
6681 * xfns.c: Likewise.
6682 * xmenu.c: Likewise.
6683 * xml.c: Likewise.
6684 * xselect.c: Likewise.
6685
2f07e6af
EZ
66862012-06-16 Eli Zaretskii <eliz@gnu.org>
6687
1053a871
SM
6688 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
6689 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 6690 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
6691 row.
6692 (handle_face_prop): Use chunk-relative overlay string index when
6693 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
6694 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
6695 the rightmost. (Bug#11720)
2f07e6af 6696
29b83cec
AS
66972012-06-16 Andreas Schwab <schwab@linux-m68k.org>
6698
6699 * category.h (CHAR_HAS_CATEGORY): Define as inline.
6700 (CATEGORY_MEMBER): Enforce 1/0 value.
6701 * category.c (_temp_category_set): Remove.
6702
4c5501e9
EZ
67032012-06-16 Eli Zaretskii <eliz@gnu.org>
6704
6705 * window.c (Fdelete_other_windows_internal)
6706 (Fdelete_window_internal): Don't access frame's mouse highlight
6707 info of the initial frame. (Bug#11677)
6708
2b570124
PE
67092012-06-14 Paul Eggert <eggert@cs.ucla.edu>
6710
e93864f9
PE
6711 * .gdbinit (xgetint): Fix recently-introduced paren typo.
6712 Assume USE_2_TAGS_FOR_INTS.
6713 (xreload): Adjust $tagmask width to match recent lisp.h change.
6714
2b570124
PE
6715 Simplify lisp.h in minor ways that should not affect code.
6716 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
6717 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
6718 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
6719 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
6720 (INTTYPEBITS): New macro, for clarity.
6721 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
6722 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
6723 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
6724 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
6725 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
6726
81755f69
JB
67272012-06-13 Juanma Barranquero <lekktu@gmail.com>
6728
6729 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
6730
16192a57
GM
67312012-06-13 Glenn Morris <rgm@gnu.org>
6732
6733 * s/bsd-common.h (BSD4_3):
6734 * s/usg5-4-common.h (USG5_4): No longer define; unused.
6735
646b5f55
AS
67362012-06-13 Andreas Schwab <schwab@linux-m68k.org>
6737
6738 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
6739 instead of union.
6740 (XLI, XIL): Define.
1053a871
SM
6741 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
6742 Use them.
6743 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 6744 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 6745 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
6746 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
6747 * frame.c (delete_frame): Remove outdated comment.
6748 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
6749 USE_LISP_UNION_TYPE.
6750 (Fw32_unregister_hot_key): Likewise.
6751 (Fw32_toggle_lock_key): Likewise.
6752 * w32menu.c (add_menu_item): Likewise.
6753 (w32_menu_display_help): Use XIL instead of checking
6754 USE_LISP_UNION_TYPE.
6755 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
6756 (init_heap): Likewise.
6757 * w32term.c (w32_read_socket): Update comment.
6758
1d3823c9
GM
67592012-06-13 Glenn Morris <rgm@gnu.org>
6760
c62ff706
GM
6761 * s/usg5-4-common.h, src/s/unixware.h:
6762 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
6763
1d3823c9
GM
6764 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
6765
bfe3e0a2
PE
67662012-06-13 Paul Eggert <eggert@cs.ucla.edu>
6767
6768 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
6769 * alloc.c (make_number) [!defined make_number]:
6770 Remove, as lisp.h always defines this now.
6771 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
6772 (roundup_size): Verify that it is a power of 2.
6773 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
6774 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
6775 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
6776 -DUSE_LSB_TAG=0, to override the automatically-selected default.
6777 USE_LSB_TAG now is always defined to be either 0 or 1.
6778 All uses changed.
6779 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
6780 code works fine either way, and efficiency is not a concern here,
6781 as the union type is for debugging, not for production.
6782 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
6783 Use an inline function on all platforms when using the union type,
6784 since this is simpler and 'static inline' can be used portably
6785 within Emacs now.
6786 (LISP_INITIALLY_ZERO): New macro.
6787 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
6788 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
6789
45fa9c0f
GM
67902012-06-12 Glenn Morris <rgm@gnu.org>
6791
b4492cba
GM
6792 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
6793
6794 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 6795
45fa9c0f
GM
6796 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
6797 Move BROKEN_SIGIO to configure.
6798
6799 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
6800 Move NO_TERMIO to configure.
6801
0e25d334
CY
68022012-06-12 Chong Yidong <cyd@gnu.org>
6803
6804 * image.c (imagemagick_load_image): Use MagickFlattenImage if
6805 MagickMergeImageLayers is undefined. Use pixel pusher loop if
6806 MagickExportImagePixels is undefined.
6807
43682bb6
PE
68082012-06-12 Paul Eggert <eggert@cs.ucla.edu>
6809
6810 * image.c (imagemagick_load_image): Remove unused label.
6811
a9be7d2b
GM
68122012-06-11 Glenn Morris <rgm@gnu.org>
6813
6814 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
6815 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
6816 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
6817 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
6818
3017f87f
SM
68192012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
6820
6821 * alloc.c (make_byte_code): New function.
6822 (Fmake_byte_code): Use it. Don't purify here.
6823 * lread.c (read1): Use it as well to avoid extra allocation.
6824
1b9b4cf4
CY
68252012-06-11 Chong Yidong <cyd@gnu.org>
6826
6827 * image.c (imagemagick_load_image): Implement transparency.
6828
95988fcf
AS
68292012-06-10 Andreas Schwab <schwab@linux-m68k.org>
6830
6831 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
6832 account for preceding backslashes. (Bug#11663)
6833
cd4eb164
CY
68342012-06-09 Chong Yidong <cyd@gnu.org>
6835
6836 * term.c: Support italics in capable terminals (Bug#9652).
6837 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
6838 (turn_on_face): Output using TS_enter_italic_mode if available.
6839 Don't handle unused blinking and alt-charset cases.
6840 (turn_off_face): Handle italic case; discard unused tty_blinking_p
6841 and tty_alt_charset_p cases.
6842 (tty_capable_p, init_tty): Support italics.
6843
6844 * termchar.h (struct tty_display_info): Add field for italics.
6845 Remove unused blink field.
6846
6847 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
6848 Handle slant.
6849
6850 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
6851 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
6852 tty_alt_charset_p. Add tty_italic_p.
6853
ff88beb8
MA
68542012-06-09 Michael Albinus <michael.albinus@gmx.de>
6855
6856 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
6857 dbus_type_is_basic if available.
6858 (xd_extract_signed, xd_extract_unsigned): Rename from
6859 extract_signed and extract_unsigned, respectively. Adapt callers.
6860
44286096
CY
68612012-06-09 Chong Yidong <cyd@gnu.org>
6862
1682701f
CY
6863 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
6864
44286096
CY
6865 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
6866 case (Bug#9752).
6867
d86feb17
PE
68682012-06-08 Paul Eggert <eggert@cs.ucla.edu>
6869
6870 * xdisp.c (vmessage): Treat frame message as multibyte.
6871 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
6872 would generate the diagnostic "Making \302\247 buffer-local while
6873 let-bound!".
6874
d5c20fe8
EZ
68752012-06-08 Eli Zaretskii <eliz@gnu.org>
6876
6877 * dispnew.c (showing_window_margins_p): Undo last change, which
6878 was done due to an inadvertent commit.
6879 (adjust_frame_glyphs_for_frame_redisplay): Do call
6880 showing_window_margins_p.
6881
513749ee
SM
68822012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
6883
6884 * eval.c (Fmake_var_non_special): New primitive.
6885 (syms_of_eval): Defsubr it.
6886 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
6887
d4a8f5c1
JB
68882012-06-08 Juanma Barranquero <lekktu@gmail.com>
6889
6890 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
6891 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
6892
8bbbc977
EZ
68932012-06-08 Eli Zaretskii <eliz@gnu.org>
6894
6895 * alloc.c (allocate_vectorlike): Fix last change.
6896
f3372c87
DA
68972012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
6898
6899 Block-based vector allocation of small vectors.
6900 * lisp.h (struct vectorlike_header): New field `nbytes',
6901 adjust comment accordingly.
6902 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
fc0c31f8 6903 to denote vector blocks. Adjust users (live_vector_p,
f3372c87
DA
6904 mark_maybe_pointer, valid_lisp_object_p) accordingly.
6905 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
6906 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
6907 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
6908 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
6909 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
6910 (roundup_size): New constant.
6911 (struct vector_block): New data type.
6912 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 6913 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
6914 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
6915 (sweep_vectors): New functions.
6916 (allocate_vectorlike): Return `zero_vector' as the only vector of
fc0c31f8 6917 0 items. Allocate new vector from block if vector size is less than
f3372c87
DA
6918 or equal to VBLOCK_BYTES_MAX.
6919 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
6920 (init_alloc_once): Add call to init_vectors.
6921
4f18a4ed
SM
69222012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
6923
6924 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
6925
86f158bc
PE
69262012-06-07 Paul Eggert <eggert@cs.ucla.edu>
6927
6928 * doprnt.c (doprnt): Truncate multibyte char correctly.
6929 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
6930 would mishandle a string argument "Xc" if X was a multibyte
6931 character of length 2: it would truncate after X's first byte
6932 rather than including all of X.
6933
c5cfcbe0
CY
69342012-06-06 Chong Yidong <cyd@gnu.org>
6935
6936 * buffer.c (word_wrap): Doc fix.
6937
c05cf390
PE
69382012-06-04 Paul Eggert <eggert@cs.ucla.edu>
6939
6940 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
6941
0c3461de
GM
69422012-06-03 Glenn Morris <rgm@gnu.org>
6943
6944 * xdisp.c (tool-bar-style): Doc fix.
6945
c71232db
UM
69462012-06-03 Ulrich Müller <ulm@gentoo.org>
6947
6948 * Makefile.in (PAXCTL): Define.
6949 (temacs$(EXEEXT)): Disable memory randomization for the temacs
6950 binary via PaX flags if the paxctl utility is available.
6951 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
6952 Restore PaX flags to their default. (Bug#11398)
6953
383f7350
CY
69542012-06-03 Chong Yidong <cyd@gnu.org>
6955
6956 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
6957 buffer (Bug#11226).
6958
5f2c76c6
CY
69592012-06-03 Chong Yidong <cyd@gnu.org>
6960
6961 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
6962 (note_mode_line_or_margin_highlight): If there is no help echo,
6963 use mode-line-default-help-echo. Handle the case where the mouse
6964 position is past the end of the mode line string.
6965
6966 * buffer.c (buffer_local_value_1): New function, split from
6967 Fbuffer_local_value; can return Qunbound.
6968 (Fbuffer_local_value): Use it.
6969 (Vmode_line_format): Docstring tweaks.
6970
773d47f6
PE
69712012-06-02 Paul Eggert <eggert@cs.ucla.edu>
6972
6973 * sysdep.c (system_process_attributes): Improve comment.
6974
f2d6a3df
SM
69752012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
6976
6977 * keyboard.c: Export real-this-command to Elisp.
6978 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
6979 and DEFVAR it. Update all users.
6980
63810350
PE
69812012-06-02 Paul Eggert <eggert@cs.ucla.edu>
6982
7bd5c1f4
PE
6983 * minibuf.c (Fassoc_string): Remove duplicate declaration.
6984
63810350
PE
6985 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
6986 Convert pctcpu and pctmem to Lisp float properly.
6987 Let the compiler fold better, as 100.0/0x8000 is exact.
6988
a2821611
AS
69892012-06-02 Andreas Schwab <schwab@linux-m68k.org>
6990
6991 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
6992 cons_block.
6993
5fceba1d
PE
69942012-06-01 Paul Eggert <eggert@cs.ucla.edu>
6995
6996 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
6997
c98ff5dd
DA
69982012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
6999
7000 For a 'struct window', replace some Lisp_Object fields to
7001 bitfields where appropriate, remove unused fields.
7002 * window.h (struct window): Remove unused 'last_mark_x' and
7003 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
7004 change it's type from Lisp_Object to bitfield.
7005 Change type of 'force_start', 'optional_new_start',
7006 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
fc0c31f8 7007 fields from Lisp_Object to bitfield. Adjust users accordingly.
c98ff5dd 7008
ca34e0be
PE
70092012-05-31 Paul Eggert <eggert@cs.ucla.edu>
7010
7011 Pacify gcc -Wdouble-precision when using Xaw.
7012 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
7013 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
7014 Use 'float' consistently, rather than 'float' in most places
7015 and 'double' in a couple of places.
7016
efc00ab1 70172012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
7018
7019 * xdisp.c (handle_stop): Detect whether we have overlay strings
7020 loaded by testing it->current.overlay_string_index to be
7021 non-negative, instead of checking whether n_overlay_strings is
7022 positive. (Bug#11587)
7023
efc00ab1 70242012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
7025
7026 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
7027
7028 * doc.c (Fsubstitute_command_keys): Doc fix.
7029
efc00ab1 70302012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
7031
7032 * search.c (search_buffer): Remove calls to
7033 r_alloc_inhibit_buffer_relocation, as it is now called by
7034 maybe_unify_char, which was the cause of relocation of buffer text
7035 in bug#11519.
7036
efc00ab1 70372012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
7038
7039 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
7040 for the duration of call to load_charset, to avoid problems with
7041 callers of maybe_unify_char that access buffer text through C
7042 pointers.
7043
7044 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
7045 decrement the inhibition flag, instead of just setting or
7046 resetting it.
7047
ba93a187
PE
70482012-05-31 Paul Eggert <eggert@cs.ucla.edu>
7049
7050 Remove obsolete '#define static' cruft.
7051 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
7052 This #undef was "temporary" in 2000; it is no longer needed
7053 now that '#define static' has gone away.
7054 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
7055 (gray_bitmap_bits): Remove; no longer needed.
7056 All uses replaced with definiens.
7057 * xterm.c: Include "bitmaps/gray.xbm".
7058
9e4bf381
PE
70592012-05-30 Paul Eggert <eggert@cs.ucla.edu>
7060
7061 Clean up __executable_start, monstartup when --enable-profiling.
7062 The following changes affect the code only when profiling.
7063 * dispnew.c (__executable_start): Rename from safe_bcopy.
7064 Define only on platforms that need it.
7065 * emacs.c: Include <sys/gmon.h> when profiling.
7066 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
7067 (__executable_start): Remove decl, since lisp.h does it now.
7068 (safe_bcopy): Remove decl; no longer has that name.
7069 (main): Coalesce #if into single bit of code, for simplicity.
7070 Cast pointers to uintptr_t, since standard libraries want integers
7071 and not pointers.
7072 * lisp.h (__executable_start): New decl.
7073
32d72c2f
GM
70742012-05-31 Glenn Morris <rgm@gnu.org>
7075
7076 * image.c (Fimagemagick_types): Doc fix.
7077
baac5bc7
JM
70782012-05-30 Jim Meyering <meyering@redhat.com>
7079
7080 * callproc.c (Fcall_process_region): Include directory component
7081 in mkstemp error message (Bug#11586).
7082
72cb32cf
PE
70832012-05-30 Paul Eggert <eggert@cs.ucla.edu>
7084
7085 * alloc.c, lisp.h (make_pure_vector): Now static.
7086
61b108cc
SM
70872012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
7088
7089 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
7090 Move to byte-run.el.
7091 (Fautoload): Do the hash-doc more carefully.
7092 * data.c (Fdefalias): Purify definition, except for keymaps.
7093 (Qdefun): Move from eval.c.
7094 * lisp.h (Qdefun): Remove.
7095 * lread.c (read1): Tiny simplification.
7096
471fe23d
TN
70972012-05-29 Troels Nielsen <bn.troels@gmail.com>
7098
934f3f58 7099 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
7100 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
7101 Bug#9642, but explicitly check that the buffer the overlay would
7102 be moved to is live and rearrange lines to make sure that errors
7103 will not put the overlay in an inconsistent state.
7104 (Fdelete_overlay): Cosmetics.
7105
85d0efd1
EZ
71062012-05-28 Eli Zaretskii <eliz@gnu.org>
7107
7108 * w32term.c (my_bring_window_to_top): New function.
7109 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
7110 could be different from the original one.
7111 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
7112 (Bug#11513)
7113
7114 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
7115 by calling BringWindowToTop.
7116
7117 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
7118 (WM_EMACS_END): Increase by one.
7119
da92a98c
PE
71202012-05-28 Paul Eggert <eggert@cs.ucla.edu>
7121
7122 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
7123 This avoids undefined behavior that might cause the eassert
7124 to not catch an out-of-range value.
7125
74d1f848
JB
71262012-05-28 Juanma Barranquero <lekktu@gmail.com>
7127
7128 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
7129 Update dependencies.
7130
9e1a06fc
EZ
71312012-05-27 Eli Zaretskii <eliz@gnu.org>
7132
7133 * bidi.c (bidi_mirror_char): Fix last change.
7134
f3dd7312
AS
71352012-05-27 Andreas Schwab <schwab@linux-m68k.org>
7136
7137 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
7138 when referring to sectname field in printf format.
7139
81899c91
PE
71402012-05-27 Paul Eggert <eggert@cs.ucla.edu>
7141
57b81a9f
PE
7142 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
7143 Only r_alloc_inhibit_buffer_relocation needed to be added;
7144 the others were already declared.
7145
81899c91
PE
7146 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
7147 before checking whether it's out of range. Put the check inside
7148 eassert. See
7149 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
7150
33017faf 71512012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
7152
7153 * callproc.c (Fcall_process): Restore a line that was accidentally
7154 commented out in the 2011-02-13 change (bug#11547).
7155
33017faf 71562012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
7157
7158 * lisp.h [REL_ALLOC]: Add prototypes for external functions
7159 defined on ralloc.c.
7160
7161 * buffer.c [REL_ALLOC]: Remove prototypes of
7162 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
7163 they are now on lisp.h.
7164
7165 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
7166
7167 * search.c (search_buffer): Use it to inhibit relocation of buffer
7168 text while re_search_2 is doing its job, because re_search_2 is
7169 passed C pointers to buffer text. (Bug#11519)
7170
23415acf
EZ
7171 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
7172 Update value to 24.
7173
44e27368
EZ
7174 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
7175 state after an additional call to move_it_in_display_line_to, keep
7176 the values of it->max_ascent and it->max_descent found for the
7177 entire line.
7178 (pos_visible_p): Revert the comparison against bottom_y to what it
7179 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
7180 (Bug#11464)
7181
c1892f11
PE
71822012-05-26 Paul Eggert <eggert@cs.ucla.edu>
7183
7184 Fix coding-related core dumps with gcc -ftrapv.
7185 The code was computing A - B, where A and B are pointers, and B is
7186 random garbage. This can lead to core dumps on platforms that
7187 have special pointer registers, and it also leads to core dumps on
7188 x86-64 when compiled with gcc -ftrapv. The fix is to compute
7189 A - B only when B is initialized properly.
7190 * coding.c (coding_set_source, coding_set_destination): Return void.
7191 (coding_change_source, coding_change_destinations): New functions,
7192 with the old behaviors of coding_set_source and coding_set_destination.
7193 All callers that need an offset changed to use these new functions.
7194
eb7afdad
GM
71952012-05-26 Glenn Morris <rgm@gnu.org>
7196
7197 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
7198
f12fdf02
EZ
71992012-05-26 Eli Zaretskii <eliz@gnu.org>
7200
53a63be6 7201 Extend mouse support on W32 text-mode console.
61b108cc
SM
7202 * xdisp.c (draw_row_with_mouse_face):
7203 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 7204
eb3f6f01 7205 * w32console.c: Include window.h.
61b108cc
SM
7206 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
7207 New functions.
eb3f6f01
EZ
7208 (initialize_w32_display): Initialize mouse-highlight data.
7209
53a63be6
EZ
7210 * w32inevt.c: Include termchar.h and window.h.
7211 (do_mouse_event): Support mouse-autoselect-window. When the mouse
7212 moves, call note_mouse_highlight. If help_echo changed, call
7213 gen_help_event to produce help-echo message in the echo area.
7214 Call clear_mouse_face if mouse_face_hidden is set in the mouse
7215 highlight info.
7216
4cfd81f6
PE
72172012-05-26 Paul Eggert <eggert@cs.ucla.edu>
7218
7219 * lread.c (read1): Simplify slightly to avoid an overflow warning
7220 with GCC 4.7.0 on x86-64.
7221
4446092a
EZ
72222012-05-26 Eli Zaretskii <eliz@gnu.org>
7223
7224 * bidi.c (bidi_mirror_char): Revert last change: an int is
7225 definitely wide enough here.
7226
42b2a986 72272012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 7228
42b2a986 7229 Fix integer width and related bugs (Bug#9874).
eb106a49 7230 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
7231 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
7232 (string_bytes, check_sblock, allocate_string_data):
7233 (compact_small_strings, Fmake_bool_vector, make_string)
7234 (make_unibyte_string, make_multibyte_string)
7235 (make_string_from_bytes, make_specified_string)
7236 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
7237 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
7238 (mark_vectorlike):
7239 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7240 (allocate_pseudovector):
7241 Use int, not EMACS_INT, where int is wide enough.
7242 (inhibit_garbage_collection, Fgarbage_collect):
7243 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7244 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
7245 int might not be wide enough.
7246 (bidi_cache_search, bidi_cache_find, bidi_init_it)
7247 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
7248 (bidi_at_paragraph_end, bidi_find_paragraph_start)
7249 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
7250 (bidi_level_of_next_char, bidi_move_to_visually_next):
7251 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7252 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
7253 (Fkill_buffer, Fset_buffer_major_mode)
7254 (advance_to_char_boundary, Fbuffer_swap_text)
7255 (Fset_buffer_multibyte, overlays_at, overlays_in)
7256 (overlay_touches_p, struct sortvec, record_overlay_string)
7257 (overlay_strings, recenter_overlay_lists)
7258 (adjust_overlays_for_insert, adjust_overlays_for_delete)
7259 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
7260 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
7261 (Foverlay_recenter, last_overlay_modification_hooks_used)
7262 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
7263 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
7264 (validate_region): Omit unnecessary test for b <= e,
7265 since that's guaranteed by the previous test.
d311d28c
PE
7266 (adjust_overlays_for_delete): Avoid pos + length overflow.
7267 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
7268 (report_overlay_modification):
7269 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7270 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
7271 Omit pointer cast, which isn't needed anyway, and doesn't work
7272 after the EMACS_INT -> ptrdiff_t change.
02481186 7273 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
7274 * buffer.h: Adjust decls to match defn changes elsewhere.
7275 (struct buffer_text, struct buffer):
7276 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7277 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
7278 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
7279 not int, to avoid needless 32-bit limit on 64-bit hosts.
7280 (exec_byte_code): Use tighter memory-full test, one that checks
7281 for alloca overflow. Don't compute the address of the object just
7282 before an array, as that's not portable. Use EMACS_INT, not
7283 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
7284 * callint.c (Fcall_interactively):
7285 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7286 * callproc.c (call_process_kill, Fcall_process):
7287 Don't assume pid_t fits into an Emacs fixnum.
7288 (call_process_cleanup, Fcall_process, child_setup):
7289 Don't assume pid_t fits into int.
7290 (call_process_cleanup, Fcall_process, delete_temp_file)
7291 (Fcall_process_region):
7292 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7293 (Fcall_process): Simplify handling of volatile integers.
7294 Use int, not EMACS_INT, where int will do.
7295 * casefiddle.c (casify_object, casify_region, operate_on_word)
7296 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
7297 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7298 (casify_object): Avoid integer overflow when overallocating buffer.
7299 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 7300 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
7301 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
7302 * category.h (CATEGORYP): Don't assume arg is nonnegative.
7303 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
7304 integers are now checked earlier. All uses replaced with XINT.
7305 (ccl_driver):
7306 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7307 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
7308 (ccl_driver, Fregister_code_conversion_map):
7309 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
7310 (resolve_symbol_ccl_program): Check that vector header is in range.
7311 Always copy the vector, so that we can check its contents reliably
7312 now rather than having to recheck each instruction as it's being
7313 executed. Check that vector words fit in 'int'.
7314 (ccl_get_compiled_code, Fregister_ccl_program)
7315 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
7316 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
7317 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
7318 contents are in range.
7319 (Fccl_execute_on_string): Check that status is in range.
7320 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
7321 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
7322 Accept and return EMACS_INT, not int, because callers can pass values
7323 out of 'int' range.
7324 (c_string_width, strwidth, lisp_string_width, chars_in_text)
7325 (multibyte_chars_in_text, parse_str_as_multibyte)
7326 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
7327 (str_as_unibyte, str_to_unibyte, string_count_byte8)
7328 (string_escape_byte8, Fget_byte):
7329 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 7330 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
7331 avoid mishandling large integers.
7332 * character.h: Adjust decls to match defn changes elsewhere.
7333 * charset.c (load_charset_map_from_file, find_charsets_in_text)
7334 (Ffind_charset_region):
7335 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7336 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
7337 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 7338 Don't assume fixnum fits in int.
d311d28c
PE
7339 (load_charset_map_from_vector, Fmap_charset_chars):
7340 Remove now-unnecessary CHECK_NATNUMs.
7341 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
7342 Don't rely on undefined behavior with signed left shift overflow.
7343 Don't assume unsigned int fits into fixnum, or that fixnum fits
7344 into unsigned int. Don't require max_code to be a valid fixnum;
7345 that's not true for gb10830 4-byte on a 32-bit host. Allow
7346 invalid_code to be a cons, for the same reason. Require code_offset
7347 to be a character. Avoid int overflow if max_char is close
7348 to INT_MAX.
7349 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
7350 this is intended anyway and avoids some undefined behavior.
7351 (load_charset_map): Pass unsigned, not int, as 2nd arg of
7352 INDEX_TO_CODE_POINT, as that's what it expects.
7353 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
7354 * charset.h (DECODE_CHAR): Return int, not unsigned;
7355 this is what was intended anyway, and it avoids undefined behavior.
7356 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
7357 integer-overflow issues.
7358 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
7359 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
7360 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
7361 * chartab.c (Fmake_char_table, Fset_char_table_range)
7362 (uniprop_get_decoder, uniprop_get_encoder):
7363 Don't assume fixnum fits in int.
7364 * cmds.c (move_point): New function, that does the gist of
7365 Fforward_char and Fbackward_char, but does so while checking
7366 for integer overflow more accurately.
c96e5d6a 7367 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
7368 (Fforward_line, Fend_of_line, internal_self_insert)
7369 (internal_self_insert):
7370 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7371 Fix a FIXME, by checking for integer overflow when calculating
7372 target_clm and actual_clm.
7373 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 7374 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
7375 (ASSURE_DESTINATION, coding_alloc_by_realloc)
7376 (coding_alloc_by_making_gap, alloc_destination)
7377 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
7378 (encode_coding_utf_16, detect_coding_emacs_mule)
7379 (decode_coding_emacs_mule, encode_coding_emacs_mule)
7380 (detect_coding_iso_2022, decode_coding_iso_2022)
7381 (encode_invocation_designation, encode_designation_at_bol)
7382 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7383 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
7384 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
7385 (encode_coding_ccl, encode_coding_raw_text)
7386 (detect_coding_charset, decode_coding_charset)
7387 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
7388 (produce_composition, produce_charset, produce_annotation)
7389 (decode_coding, handle_composition_annotation)
7390 (handle_charset_annotation, consume_chars, decode_coding_gap)
7391 (decode_coding_object, encode_coding_object, detect_coding_system)
7392 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
7393 (code_convert_region, code_convert_string)
8f50130c
PE
7394 (Fdefine_coding_system_internal)
7395 (coding_set_source, coding_set_destination):
d311d28c
PE
7396 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7397 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
7398 (Fdefine_coding_system_internal):
7399 Don't assume fixnums fit in int.
7400 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 7401 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
7402 (Funencodable_char_position, Fcheck_coding_systems_region)
7403 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 7404 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 7405 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 7406 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 7407 Don't access memory outside of the args array.
d311d28c 7408 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
7409 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
7410 result of ENCODE_CHAR.
d311d28c
PE
7411 * coding.h: Adjust decls to match defn changes elsewhere.
7412 (struct coding_system):
7413 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7414 * composite.c (get_composition_id, find_composition)
7415 (run_composition_function, update_compositions)
7416 (compose_text, composition_gstring_put_cache)
7417 (composition_gstring_p, composition_gstring_width)
7418 (fill_gstring_header, fill_gstring_body, autocmp_chars)
7419 (composition_compute_stop_pos, composition_reseat_it)
7420 (composition_update_it, struct position_record)
7421 (find_automatic_composition, composition_adjust_point)
7422 (Fcomposition_get_gstring, Ffind_composition_internal):
7423 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7424 (update_compositions):
7425 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7426 * composite.h: Adjust decls to match defn changes elsewhere.
7427 (struct composition):
7428 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7429 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
7430 Do not attempt to compute the address of the object just before a
7431 buffer; this is not portable.
7432 (Faref, Faset):
7433 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7434 (Faset): Use int, not EMACS_INT, where int is wide enough.
7435 (Fstring_to_number): Don't assume fixnums fit in int.
7436 (Frem): Don't assume arg is nonnegative.
7437 * dbusbind.c (xd_append_arg): Check for integers out of range.
7438 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 7439 (extract_signed, extract_unsigned): New functions.
243e0530
PE
7440 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
7441 (xd_get_connection_references): Return ptrdiff_t, not int.
7442 All uses changed.
7443 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
7444 (xd_read_message_1):
7445 Use int, not unsigned, where the dbus API uses int.
7446 (Fdbus_message_internal): Don't overflow mtype.
7447 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
7448 * dired.c (directory_files_internal, file_name_completion, scmp)
7449 (file_name_completion_stat):
7450 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7451 (file_name_completion): Don't overflow matchcount.
7452 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
7453 * dispextern.h: Adjust decls to match defn changes elsewhere.
7454 (struct text_pos, struct glyph, struct bidi_saved_info)
7455 (struct bidi_string_data, struct bidi_it, struct composition_it)
7456 (struct it):
7457 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7458 (struct display_pos, struct composition_it, struct it):
7459 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7460 * dispnew.c (increment_matrix_positions)
7461 (increment_row_positions, mode_line_string)
7462 (marginal_area_string):
7463 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 7464 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
7465 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7466 (duration_to_sec_usec): New function, to check for overflow better.
7467 (Fsleep_for, sit_for): Use it.
7468 * doc.c (get_doc_string, store_function_docstring):
7469 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7470 (get_doc_string, Fsnarf_documentation):
7471 Use int, not EMACS_INT, where int is wide enough.
7472 (get_doc_string):
7473 Use SAFE_ALLOCA, not alloca.
7474 Check for overflow when converting EMACS_INT to off_t.
7475 * doprnt.c (doprnt):
7476 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7477 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
7478 Don't assume uid_t fits into fixnum.
7479 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
7480 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
7481 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
7482 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
7483 (general_insert_function)
7484 (Finsert_char, make_buffer_string, make_buffer_string_both)
7485 (update_buffer_properties, Fbuffer_substring)
7486 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
7487 (Fsubst_char_in_region, check_translation)
7488 (Ftranslate_region_internal, save_restriction_restore, Fformat)
7489 (transpose_markers, Ftranspose_regions):
7490 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7491 (clip_to_bounds): Move to lisp.h as an inline function).
7492 (Fconstrain_to_field): Don't assume integers are nonnegative.
7493 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
7494 (Fsubst_char_in_region, Fsave_restriction):
7495 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7496 (Femacs_pid): Don't assume pid_t fits into fixnum.
7497 (lo_time): Use int, not EMACS_INT, when int suffices.
7498 (lisp_time_argument): Check for usec out of range.
7499 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
7500 (Fuser_login_name, Fuser_full_name): Signal an error
7501 if a uid argument is out of range, rather than relying on
7502 undefined behavior.
c8d5c857
PE
7503 (Fformat_time_string): Remove now-unnecessary check.
7504 lisp_time_argument checks for out-of-range usec now.
243e0530 7505 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
7506 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
7507 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
7508 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
7509 (init_cmdargs, Fdump_emacs):
7510 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7511 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
7512 the bottom (typically) 32 bits of the fixnum.
7513 * eval.c (specpdl_size, call_debugger):
7514 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7515 (when_entered_debugger, Fbacktrace_debug):
7516 Don't assume fixnum can fit in int.
7517 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
7518 the object just before a buffer; this is not portable.
7519 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
7520 (grow_specpdl, unbind_to):
7521 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7522 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
7523 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 7524 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
7525 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
7526 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
7527 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7528 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
7529 (a_write, e_write):
7530 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7531 (Fcopy_file, non_regular_nbytes, read_non_regular)
7532 (Finsert_file_contents):
7533 Use int, not EMACS_INT, where int is wide enough.
7534 (READ_BUF_SIZE): Verify that it fits in int.
7535 (Finsert_file_contents): Check that counts are in proper range,
7536 rather than assuming fixnums fit into ptrdiff_t etc.
7537 Don't assume fixnums fit into int.
125b3835 7538 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
7539 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
7540 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
7541 (string_char_to_byte, string_byte_to_char)
7542 (string_make_multibyte, string_to_multibyte)
7543 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
7544 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
7545 (substring_both, Fdelete, internal_equal, Ffillarray)
7546 (Fclear_string, mapcar1)
7547 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
7548 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
7549 (larger_vector, make_hash_table, maybe_resize_hash_table)
7550 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
7551 (Fmaphash, secure_hash):
7552 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7553 (concat): Check for string index and length overflow.
7554 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
7555 (Frequire):
7556 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7557 (larger_vector): New API (vec, incr_min, size_max) replaces old
7558 one (vec, new_size, init). This catches size overflow.
7559 INIT was removed because it was always Qnil.
7560 All callers changed.
7561 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
7562 the upper bound on a hash table index size.
7563 (make_hash_table, maybe_resize_hash_table): Use it.
7564 (secure_hash): Computer start_byte and end_byte only after
7565 they're known to be in ptrdiff_t range.
7566 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
7567 (Ffont_get_glyphs, Ffont_at):
7568 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7569 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
7570 (Flist_fonts, Fopen_font):
7571 Don't assume fixnum can fit in int.
7572 (check_gstring): Don't assume index can fit in int.
7573 (font_match_p): Check that fixnum is a character, not a nonnegative
7574 fixnum, since the later code needs to stuff it into an int.
7575 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
7576 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
7577 conversion overflow issues.
7578 (Fopen_font): Check for integer out of range.
7579 (Ffont_get_glyphs): Don't assume index can fit in int.
7580 * font.h: Adjust decls to match defn changes elsewhere.
7581 * fontset.c (reorder_font_vector): Redo score calculation to avoid
7582 integer overflow.
7583 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
7584 printmax_t, where ptrdiff_t is wide enough.
7585 (Finternal_char_font):
7586 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7587 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
7588 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
7589 (Fset_frame_position, x_set_frame_parameters)
7590 (x_set_line_spacing, x_set_border_width)
7591 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
7592 Check that fixnums are in proper range for system types.
7593 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
7594 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7595 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
7596 Use SAFE_ALLOCA_LISP, not alloca.
7597 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
7598 intptr_t is wide enough.
7599 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
7600 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
7601 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
7602 Check for fixnum out of range.
7603 * ftfont.c (ftfont_list): Don't assume index fits in int.
7604 Check that fixnums are in proper range for system types.
7605 (ftfont_shape_by_flt):
7606 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
7607 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
7608 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7609 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
7610 Check that fixnums are in proper range for system types.
7611 * gnutls.h: Adjust decls to match defn changes elsewhere.
7612 * gtkutil.c (xg_dialog_run):
7613 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7614 (update_frame_tool_bar):
7615 Check that fixnums are in proper range for system types.
7616 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 7617 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
7618 * indent.c (last_known_column, last_known_column_point):
7619 (current_column_bol_cache):
7620 (skip_invisible, current_column, check_display_width):
7621 (check_display_width, scan_for_column, current_column_1)
7622 (Findent_to, Fcurrent_indentation, position_indentation)
7623 (indented_beyond_p, Fmove_to_column, compute_motion):
7624 (Fcompute_motion, Fvertical_motion):
7625 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7626 (last_known_column_modified): Use EMACS_INT, not int.
7627 (check_display_width):
7628 (Fcompute_motion):
7629 Check that fixnums and floats are in proper range for system types.
7630 (compute_motion): Don't assume index or fixnum fits in int.
7631 (compute_motion, Fcompute_motion):
7632 Use int, not EMACS_INT, when it is wide enough.
7633 (vmotion): Omit local var start_hpos that is always 0; that way
7634 we don't need to worry about overflow in expressions involving it.
7635 * indent.h: Adjust decls to match defn changes elsewhere.
7636 (struct position):
7637 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7638 Use int, not EMACS_INT, where int is wide enough.
7639 Remove unused members ovstring_chars_done and tab_offset;
7640 all uses removed.
7641 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
7642 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
7643 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
7644 (make_gap, copy_text, insert, insert_and_inherit)
7645 (insert_before_markers, insert_before_markers_and_inherit)
7646 (insert_1, count_combining_before, count_combining_after)
7647 (insert_1_both, insert_from_string)
7648 (insert_from_string_before_markers, insert_from_string_1)
7649 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
7650 (adjust_after_replace, adjust_after_insert, replace_range)
7651 (replace_range_2, del_range, del_range_1, del_range_byte)
7652 (del_range_both, del_range_2, modify_region)
7653 (prepare_to_modify_buffer, signal_before_change)
7654 (signal_after_change, Fcombine_after_change_execute):
7655 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7656 * intervals.c (traverse_intervals, rotate_right, rotate_left)
7657 (balance_an_interval, split_interval_right, split_interval_left)
7658 (find_interval, next_interval, update_interval)
7659 (adjust_intervals_for_insertion, delete_node, delete_interval)
7660 (interval_deletion_adjustment, adjust_intervals_for_deletion)
7661 (static_offset_intervals, offset_intervals)
7662 (merge_interval_right, merge_interval_left, make_new_interval)
7663 (graft_intervals_into_buffer, temp_set_point_both)
7664 (temp_set_point, set_point, adjust_for_invis_intang)
7665 (set_point_both, move_if_not_intangible, get_property_and_range)
7666 (get_local_map, copy_intervals, copy_intervals_to_string)
7667 (compare_string_intervals, set_intervals_multibyte_1):
7668 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7669 * intervals.h: Adjust decls to match defn changes elsewhere.
7670 (struct interval):
7671 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7672 * keyboard.c (this_command_key_count, this_single_command_key_start)
7673 (before_command_key_count, before_command_echo_length, echo_now)
7674 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
7675 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
7676 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
7677 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
7678 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7679 (last_non_minibuf_size, last_point_position, echo_truncate)
7680 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
7681 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
7682 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
7683 (stuff_buffered_input):
7684 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7685 (last_auto_save, command_loop_1, read_char):
7686 Use EMACS_INT, not int, to avoid integer overflow.
7687 (record_char): Avoid overflow in total_keys computation.
7688 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
7689 * keyboard.h: Adjust decls to match defn changes elsewhere.
7690 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
7691 (Fkey_description, Fdescribe_vector, Flookup_key):
7692 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7693 (click_position): New function, to check that positions are in range.
7694 (Fcurrent_active_maps):
7695 (describe_command):
7696 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7697 (Faccessible_keymaps, Fkey_description):
7698 (preferred_sequence_p):
7699 Don't assume fixnum can fit into int.
7700 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
7701 Check for integer overflow in size calculations.
7702 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
7703 avoid mishandling large integers.
7704 * lisp.h: Adjust decls to match defn changes elsewhere.
7705 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
7706 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
7707 (struct Lisp_Marker):
7708 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7709 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
7710 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
7711 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
7712 All callers changed.
7713 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
7714 Assume the arg has valid form, since it always does.
7715 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
7716 unsigned integer system type.
7717 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
7718 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
7719 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7720 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
7721 (duration_to_sec_usec): New decl.
7722 * lread.c (read_from_string_index, read_from_string_index_byte)
7723 (read_from_string_limit, readchar, unreadchar, openp)
7724 (read_internal_start, read1, oblookup):
7725 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7726 (Fload, readevalloop, Feval_buffer, Feval_region):
7727 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7728 (openp): Check for out-of-range argument to 'access'.
7729 (read1): Use int, not EMACS_INT, where int is wide enough.
7730 Don't assume fixnum fits into int.
6efdadfd 7731 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
7732 (read_filtered_event): Use duration_to_sec_usec
7733 to do proper overflow checking on durations.
d311d28c
PE
7734 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
7735 in size calculation.
7736 (Fexecute_kbd_macro):
7737 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7738 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
7739 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
7740 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
7741 (set_marker_both, set_marker_restricted_both, marker_position)
7742 (marker_byte_position, Fbuffer_has_markers_at):
7743 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7744 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 7745 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
7746 It now merely ensures that the menu is large enough, without
7747 necessarily growing it, as this avoids some integer overflow issues.
7748 All callers changed.
7749 (keymap_panes, parse_single_submenu, Fx_popup_menu):
7750 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7751 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
7752 Use SAFE_ALLOCA_LISP, not alloca.
7753 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
7754 to EMACS_INT. Check that fixnums are in proper range for system types.
7755 * minibuf.c (minibuf_prompt_width, string_to_object)
7756 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
7757 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
7758 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7759 (get_minibuffer, read_minibuf_unwind):
7760 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7761 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
7762 this simplifies overflow checking. All callers changed.
7763 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
7764 (Ftest_completion):
7765 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7766 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
7767 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
7768 Check that fixnums are in proper range for system types.
7769 (Fx_create_frame, Fx_show_tip):
7770 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7771 * nsfont.m (ns_findfonts, nsfont_list_family):
7772 Don't assume fixnum fits in long.
7773 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
7774 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7775 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
7776 wide enough.
17fdb222 7777 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
7778 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7779 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
7780 (PRINTDECLARE, PRINTPREPARE):
7781 (strout, print_string):
7782 (print, print_preprocess, print_check_string_charset_prop)
7783 (print_object):
7784 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7785 (PRINTDECLARE):
7786 (temp_output_buffer_setup, Fprin1_to_string, print_object):
7787 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7788 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 7789 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 7790 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
7791 (print_error_message): Use SAFE_ALLOCA, not alloca.
7792 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
7793 (print_depth, new_backquote_output, print_number_index):
7794 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
7795 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
7796 (Fset_process_window_size, Fformat_network_address)
7797 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 7798 (sigchld_handler):
d311d28c 7799 Check that fixnums are in proper range for system types.
d44287d4 7800 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
7801 Check for process-ids out of pid_t range rather than relying on
7802 undefined behavior.
e4d81efc 7803 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
7804 (Fformat_network_address, read_process_output, send_process)
7805 (Fprocess_send_region, status_notify):
7806 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7807 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
7808 (wait_reading_process_output, read_process_output, exec_sentinel):
7809 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7810 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
7811 (Faccept_process_output): Use duration_to_sec_usec to do proper
7812 overflow checking on durations.
dde14581
PE
7813 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
7814 Don't assume pid_t fits in int.
02481186
PE
7815 * process.h (struct Lisp_Process): Members tick and update_tick
7816 are now of type EMACS_INT, not int.
b62b53e8
PE
7817 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
7818 configured --with-wide-int.
d311d28c
PE
7819 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
7820 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
7821 * search.c (looking_at_1, string_match_1):
7822 (fast_string_match, fast_c_string_match_ignore_case)
7823 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
7824 (scan_newline, find_before_next_newline, search_command)
7825 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
7826 (set_search_regs, wordify):
7827 (Freplace_match):
7828 (Fmatch_data):
7829 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7830 (string_match_1, search_buffer, set_search_regs):
7831 (Fmatch_data):
7832 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7833 (wordify): Check for overflow in size calculation.
7834 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
7835 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
7836 Check that fixnums are in proper range for system types.
7837 * sound.c (struct sound_device)
7838 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
7839 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7840 (Fplay_sound_internal):
7841 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 7842 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
7843 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
7844 (Fparse_partial_sexp):
7845 Don't assume fixnums can fit in int.
7846 (struct lisp_parse_state, find_start_pos, find_start_value)
7847 (find_start_value_byte, find_start_begv)
7848 (update_syntax_table, char_quoted, dec_bytepos)
7849 (find_defun_start, prev_char_comend_first, back_comment):
7850 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
7851 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
7852 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7853 (Finternal_describe_syntax_value): Check that match_lisp is a
7854 character, not an integer, since the code stuffs it into int.
7855 (scan_words, scan_sexps_forward):
7856 Check that fixnums are in proper range for system types.
7857 (Fforward_word):
7858 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7859 (scan_sexps_forward):
7860 Use CHARACTERP, not INTEGERP, since the value must fit into int.
7861 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
7862 * syntax.h: Adjust decls to match defn changes elsewhere.
7863 (struct gl_state_s):
7864 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
7865 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
7866 MOST_POSITIVE_FIXNUM.
d311d28c
PE
7867 * sysdep.c (wait_for_termination_1, wait_for_termination)
7868 (interruptible_wait_for_termination, mkdir):
7869 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
7870 (emacs_read, emacs_write):
7871 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
7872 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
7873 and double all fit in int.
d311d28c
PE
7874 * term.c (set_tty_color_mode):
7875 Check that fixnums are in proper range for system types.
7876 * termhooks.h (struct input_event):
7877 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7878 * textprop.c (validate_interval_range, interval_of)
7879 (Fadd_text_properties, set_text_properties_1)
7880 (Fremove_text_properties, Fremove_list_of_text_properties)
7881 (Ftext_property_any, Ftext_property_not_all)
7882 (copy_text_properties, text_property_list, extend_property_ranges)
7883 (verify_interval_modification):
7884 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7885 (Fnext_single_char_property_change)
7886 (Fprevious_single_char_property_change):
7887 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
7888 (copy_text_properties):
7889 Check for integer overflow in index calculation.
d311d28c
PE
7890 * undo.c (last_boundary_position, record_point, record_insert)
7891 (record_delete, record_marker_adjustment, record_change)
7892 (record_property_change):
7893 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7894 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
7895 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7896 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
7897 (Fx_hide_tip, Fx_file_dialog):
7898 * w32menu.c (set_frame_menubar):
7899 Use ptrdiff_t, not int, for consistency with rest of code.
7900 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
7901 (select_window, Fdelete_other_windows_internal)
7902 (window_scroll_pixel_based, window_scroll_line_based)
7903 (Frecenter, Fset_window_configuration):
7904 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7905 (Fset_window_hscroll, run_window_configuration_change_hook)
7906 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 7907 (Fscroll_other_window, Frecenter):
d311d28c
PE
7908 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7909 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
7910 Don't assume fixnum fits in int.
7911 (Fset_window_scroll_bars):
7912 Check that fixnums are in proper range for system types.
7913 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
7914 (string_pos, c_string_pos, number_of_chars, init_iterator)
7915 (in_ellipses_for_invisible_text_p, init_from_display_pos)
7916 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
7917 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
7918 (face_before_or_after_it_pos, handle_invisible_prop)
7919 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
7920 (display_prop_intangible_p, string_buffer_position_lim)
7921 (string_buffer_position, handle_composition_prop, load_overlay_strings)
7922 (get_overlay_strings_1, get_overlay_strings)
7923 (iterate_out_of_display_property, forward_to_next_line_start)
7924 (back_to_previous_visible_line_start, reseat, reseat_to_string)
7925 (get_next_display_element, set_iterator_to_next)
7926 (get_visually_first_element, compute_stop_pos_backwards)
7927 (handle_stop_backwards, next_element_from_buffer)
7928 (move_it_in_display_line_to, move_it_in_display_line)
7929 (move_it_to, move_it_vertically_backward, move_it_by_lines)
7930 (add_to_log, message_dolog, message_log_check_duplicate)
7931 (message2, message2_nolog, message3, message3_nolog
7932 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
7933 (current_message_1, truncate_echo_area, truncate_message_1)
7934 (set_message, set_message_1, store_mode_line_noprop)
7935 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
7936 (text_outside_line_unchanged_p, check_point_in_composition)
7937 (reconsider_clip_changes)
7938 (redisplay_internal, set_cursor_from_row, try_scrolling)
7939 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
7940 (redisplay_window, find_last_unchanged_at_beg_row)
7941 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
7942 (trailing_whitespace_p, find_row_edges, display_line)
7943 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
7944 (display_mode_element, store_mode_line_string)
7945 (pint2str, pint2hrstr, decode_mode_spec)
7946 (display_count_lines, display_string, draw_glyphs)
7947 (x_produce_glyphs, x_insert_glyphs)
7948 (rows_from_pos_range, mouse_face_from_buffer_pos)
7949 (fast_find_string_pos, mouse_face_from_string_pos)
7950 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7951 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7952 (safe_call, init_from_display_pos, handle_fontified_prop)
7953 (handle_single_display_spec, load_overlay_strings)
7954 (with_echo_area_buffer, setup_echo_area_for_printing)
7955 (display_echo_area, echo_area_display)
7956 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
7957 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
7958 (redisplay_window, dump_glyph_row, display_mode_line)
7959 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 7960 (handle_display_spec, display_prop_string_p):
d311d28c
PE
7961 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7962 (handle_single_display_spec, build_desired_tool_bar_string)
7963 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
7964 (get_specified_cursor_type):
7965 Check that fixnums are in proper range for system types.
7966 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
7967 (Flookup_image_map):
7968 Don't assume fixnums fit in int.
7969 (compare_overlay_entries):
7970 Avoid mishandling comparisons due to subtraction overflow.
7971 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
7972 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
7973 (handle_tool_bar_click):
7974 Use int, not unsigned, since we prefer signed and the signedness
7975 doesn't matter here.
7976 (get_next_display_element, next_element_from_display_vector):
7977 Use int, not EMACS_INT, when int is wide enough.
7978 (start_hourglass): Use duration_to_sec_usec to do proper
7979 overflow checking on durations.
7980 * xfaces.c (Fbitmap_spec_p):
7981 Check that fixnums are in proper range for system types.
7982 (compare_fonts_by_sort_order):
7983 Avoid mishandling comparisons due to subtraction overflow.
7984 (Fx_family_fonts, realize_basic_faces):
7985 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7986 (Fx_family_fonts):
7987 Don't assume fixnum fits in int.
7988 Use SAFE_ALLOCA_LISP, not alloca.
7989 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
7990 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
7991 (face_at_buffer_position, face_for_overlay_string)
7992 (face_at_string_position):
7993 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7994 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
7995 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
7996 (Fx_show_tip):
7997 Check that fixnums are in proper range for system types.
7998 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
7999 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
8000 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8001 (Fx_change_window_property): Don't assume fixnums fit in int.
8002 * xfont.c (xfont_chars_supported):
8003 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8004 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
8005 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
8006 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8007 * xml.c (parse_region):
8008 * xrdb.c (magic_file_p):
8009 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8010 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
8011 (x_get_local_selection, x_reply_selection_request)
8012 (x_handle_selection_request, wait_for_property_change):
8013 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8014 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
8015 short is wide enough.
8016 (x_send_client_event): Don't assume fixnum fits in int.
8017 * xterm.c (x_x_to_emacs_modifiers):
8018 Don't assume EMACS_INT overflows nicely into int.
8019 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
8020 may come from Lisp.
8021 (handle_one_xevent): NATNUMP can eval its arg twice.
8022 (x_connection_closed):
8023 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8024 * xterm.h: Adjust decls to match defn changes elsewhere.
8025 (struct scroll_bar): Use struct vectorlike_header
8026 rather than rolling our own approximation.
8027 (SCROLL_BAR_VEC_SIZE): Remove; not used.
8028
c6574eb5
GM
80292012-05-25 Glenn Morris <rgm@gnu.org>
8030
8031 * lisp.mk (lisp): Update for more files being compiled now.
8032
e8d32c7e
SM
80332012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
8034
48def666
SM
8035 * lread.c: Remove `read_pure' which makes no difference.
8036 (read_pure): Remove var.
8037 (unreadpure): Remove function.
8038 (readevalloop): Don't call read_list with -1 flag.
8039 (read1, read_vector): Don't test read_pure any more.
8040 (read_list): Simplify.
8041
e8d32c7e
SM
8042 * fileio.c, character.h: Minor style tweaks.
8043
4b2addb7
DA
80442012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
8045
8046 * window.h (clip_changed): Remove useless declaration.
8047
584461b2
JB
80482012-05-22 Juanma Barranquero <lekktu@gmail.com>
8049
8050 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
8051 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
8052
34374650
PE
80532012-05-22 Paul Eggert <eggert@cs.ucla.edu>
8054
8055 Remove src/m/*.
8056 This directory predates autoconf and is no longer needed nowadays.
8057 Move its few remaining bits of functionality to where they're needed.
8058 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
8059 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
8060 * m/template.h: Remove.
8061 * Makefile.in (M_FILE): Remove. All uses removed.
8062 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
8063 * lisp.h (USE_LSB_TAG):
8064 * mem-limits.h (EXCEEDS_LISP_PTR):
8065 Use VAL_MAX, not VALBITS, in #if.
8066 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
8067 (EMACS_UINT): Define unconditionally now.
8068 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
8069 (BITS_PER_EMACS_INT): New constants, replacing
8070 what used to be in config.h, but not useful in #if.
8071 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
8072 define them any more.
8073 (VAL_MAX): New macro.
8074 (VALMASK): Use it.
8075 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
8076 BITS_PER_EMACS_INT, in #if.
8077 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
8078 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
8079 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
8080 * s/ms-w32.h (DATA_START):
8081 Move here from removed file m/intel386.h.
8082 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
8083 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
8084
261cb4bb
PE
80852012-05-21 Paul Eggert <eggert@cs.ucla.edu>
8086
8087 Assume C89 or later.
8088 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
8089 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
8090 (xrealloc):
8091 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
8092 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
8093 * textprop.c, tparam.c (NULL): Remove.
8094 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
8095 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
8096 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
8097 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
8098 * xterm.c (input_signal_count): Assume volatile works.
8099
ff23cd9f
KB
81002012-05-21 Ken Brown <kbrown@cornell.edu>
8101
8102 * xgselect.c (xg_select): Fix first argument in call to 'select'
8103 (bug#11508).
8104
1b170bc6
KB
81052012-05-20 Ken Brown <kbrown@cornell.edu>
8106
8107 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 8108 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 8109
b2f4d39f
KB
81102012-05-19 Ken Brown <kbrown@cornell.edu>
8111
8112 * xfns.c (x_in_use): Remove `static' qualifier.
8113 * xterm.h (x_in_use): Declare.
8114 * xgselect.c: Include xterm.h.
8115 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
8116 and `display_arg' (bug#9754).
8117
003fdae2
PE
81182012-05-19 Paul Eggert <eggert@cs.ucla.edu>
8119
9232a6d9
PE
8120 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
8121
003fdae2
PE
8122 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
8123 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
8124
784b56e2
EZ
81252012-05-18 Eli Zaretskii <eliz@gnu.org>
8126
8127 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
8128
8129 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 8130 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
8131
8132 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
8133 reference to image_cache->refcount.
8134 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
8135
a0a79cde
JL
81362012-05-17 Juri Linkov <juri@jurta.org>
8137
8138 * search.c (Fword_search_regexp, Fword_search_backward)
8139 (Fword_search_forward, Fword_search_backward_lax)
8140 (Fword_search_forward_lax): Move functions to isearch.el
8141 (bug#10145, bug#11381).
8142
b0572523
PE
81432012-05-16 Paul Eggert <eggert@cs.ucla.edu>
8144
8145 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
8146
9660f5fc
SM
81472012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
8148
8149 * lread.c (init_obarray): Declare Qt and Qnil as special.
8150
4374de83
GM
81512012-05-14 Glenn Morris <rgm@gnu.org>
8152
8153 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 8154 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 8155
dc44c39a
PE
81562012-05-14 Paul Eggert <eggert@cs.ucla.edu>
8157
078c97cb
PE
8158 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
8159
dc44c39a
PE
8160 * unexaix.c: Port to more-recent AIX compilers.
8161 (report_error, report_error_1, make_hdr, copy_sym)
8162 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
8163 Make arguments const char *, not char *, to avoid violations of C
8164 standard and to fix some AIX warnings reported by Gilles Pion.
8165
e18afed7 81662012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
8167
8168 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
8169 already have overlays loaded.
8170 (handle_single_display_spec): Before returning without displaying
8171 fringe bitmap, synchronize the bidi iterator with the main display
8172 iterator, by calling iterate_out_of_display_property.
8173 (iterate_out_of_display_property): Detect buffer iteration by
8174 testing that it->string is a Lisp string.
8175 (get_next_display_element): When the current object is exhausted,
8176 and there's something on it->stack, call set_iterator_to_next to
8177 proceed with what's on the stack, instead of returning zero.
8178 (set_iterator_to_next): If called at the end of a Lisp string,
8179 proceed to consider_string_end without incrementing string
8180 position. Don't increment display vector index past the end of
8181 the display vector. (Bug#11417)
c8fb9dc6
EZ
8182 (pos_visible_p): Don't report a position visible when move_it_to
8183 stopped at the last line of window, which happens to be scanned
8184 backwards by the bidi iteration. (Bug#11464)
ac268e67 8185
e18afed7 81862012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
8187
8188 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
8189 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
8190 are on a TTY, and thus unable to display on the fringes.
8191 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
8192 so we need to signal to the caller that this is a "replacing"
8193 display spec. This fixes display when the spec is invalid or we
8194 are on a TTY.
8195
e18afed7 81962012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
8197
8198 * unexaix.c (make_hdr): Fix typo in prototype.
8199 This bug broke the build on AIX. Problem reported by Gilles Pion.
8200
9d0a235a
MA
82012012-05-14 Michael Albinus <michael.albinus@gmx.de>
8202
8203 * keyboard.c (kbd_buffer_get_event): Read special events also in
8204 batch mode. (Bug#11415)
8205
9e6b06ed
GM
82062012-05-12 Glenn Morris <rgm@gnu.org>
8207
8208 * ns.mk: Update for ns_appbindir no longer having trailing "/".
8209
c1a1d7a3
EZ
82102012-05-12 Eli Zaretskii <eliz@gnu.org>
8211
8212 * lisp.mk (lisp): Add newcomment.elc.
8213
3fe7cdc8
GM
82142012-05-12 Glenn Morris <rgm@gnu.org>
8215
8216 * Makefile.in (MKDIR_P): New, set by configure.
8217 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
8218
53f7d2c0
PE
82192012-05-11 Paul Eggert <eggert@cs.ucla.edu>
8220
8221 Remove unused function hourglass_started.
8222 * dispextern.h (hourglass_started):
8223 * w32fns.c (hourglass_started):
8224 * xdisp.c (hourglass_started): Remove.
8225
75aafb17
JB
82262012-05-10 Juanma Barranquero <lekktu@gmail.com>
8227
8228 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
8229 Update dependencies.
8230
12959e8e
PE
82312012-05-10 Paul Eggert <eggert@cs.ucla.edu>
8232
97107e2e
PE
8233 * xgselect.c (xg_select): Put maxfds+1 into a var.
8234 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
8235
12959e8e
PE
8236 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
8237
836d29b3
DA
82382012-05-10 Dave Abrahams <dave@boostpro.com>
8239
8240 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
8241 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
8242
5cb67954
MA
82432012-05-09 Michael Albinus <michael.albinus@gmx.de>
8244
8245 * dbusbind.c (xd_registered_buses): New internal Lisp object.
8246 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
8247 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
8248 Initialize xd_registered_buses.
8249
3478ec45
PE
82502012-05-09 Paul Eggert <eggert@cs.ucla.edu>
8251
b263a6b0
PE
8252 Untag more efficiently if USE_LSB_TAG.
8253 This is based on a proposal by YAMAMOTO Mitsuharu in
8254 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
8255 For an admittedly artificial (nth 8000 longlist) benchmark on
8256 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
8257 Emacs's overall text size by 1%.
8258 * lisp.h (XUNTAG): New macro.
8259 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
8260 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
8261 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
8262 * eval.c (Fautoload):
8263 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
8264 * frame.h (XFRAME): Use XUNTAG.
8265
3478ec45
PE
8266 Port recent dbusbind.c changes to 32-bit --with-wide-int.
8267 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
8268 Remove unportable assumptions about print widths of types like
8269 dbus_uint32_t.
8270 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
8271 intptr_t when converting between pointer and integer, to avoid GCC
8272 warnings about wrong width.
8273
666b903b 82742012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
8275
8276 * w32proc.c (new_child): Force Windows to reserve only 64KB of
8277 stack for each reader_thread, instead of defaulting to 8MB
8278 determined by the linker. This avoids failures in creating
8279 subprocesses on Windows 7, see the discussion in this thread:
8280 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
8281
b120cc17
JC
82822012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
8283
8284 Fix up display of the *Minibuf-0* buffer in the mini window.
8285 * keyboard.c (read_char): Don't clear the echo area if there's no
8286 message to clear.
8287 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 8288 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 8289
9a4b36f8
MA
82902012-05-07 Michael Albinus <michael.albinus@gmx.de>
8291
8292 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
8293 batch mode.
8294
e5f9458f
CY
82952012-05-06 Chong Yidong <cyd@gnu.org>
8296
8297 * lisp.mk (lisp): Update.
8298
eceeb5fc 82992012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
8300
8301 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
8302
71873e2b
SM
83032012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
8304
8305 * data.c (PUT_ERROR): New macro.
8306 (syms_of_data): Use it. Add new error type `user-error'.
8307 * undo.c (user_error): New function.
8308 (Fprimitive_undo): Use it.
8309 * print.c (print_error_message): Adjust print style for `user-error'.
8310 * keyboard.c (user_error): New function.
8311 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
8312
ab0fa4e4
PE
83132012-05-03 Paul Eggert <eggert@cs.ucla.edu>
8314
8315 Do not limit current-time-string to years 1000..9999.
8316 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
8317 (Fcurrent_time_string): Support any year that is supported by the
8318 underlying localtime representation. Don't use asctime, as it
8319 has undefined behavior for years outside the range -999..9999.
8320
7ed806a7
PE
83212012-05-02 Paul Eggert <eggert@cs.ucla.edu>
8322
8323 Fix race conditions involving setenv, gmtime, localtime, asctime.
8324 Without this fix, interrupts could mess up code that uses these
8325 nonreentrant functions, since setting TZ invalidates existing
8326 tm_zone or tzname values, and since most of these functions return
8327 pointers to static storage.
8328 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
8329 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
8330 Grow the critical sections to include not just invoking
8331 localtime/gmtime, but also accessing these functions' results
8332 including their tm_zone values if any, and any related TZ setting.
8333 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
8334 so that the struct tm is saved in the critical section.
8335 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
8336 motivated by the fact that memory allocation needs to be outside
8337 the critical section.
8338
0c16dfed
DA
83392012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
8340
8341 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
8342 with RESET_INTERVAL.
8343
8344 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8345 Remove duplicated buffer name initialization.
8346
3f83ace8
JM
83472012-05-02 Jim Meyering <jim@meyering.net>
8348
8349 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
8350
c7b8541e
JM
8351 * xfns.c (x_window): Use xstrdup (Bug#11375).
8352
90207a15 83532012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
8354
8355 * xdisp.c (pos_visible_p): If already at a newline from the
8356 display string before the 'while' loop, don't walk back the glyphs
8357 from it3.glyph_row. Solves assertion violation when the display
8358 string begins with a newline (egg.el). (Bug#11367)
8359
b593d6a9
AH
83602012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
8361
8362 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
8363 Move to simple.el.
8364
4737362e
GM
83652012-05-01 Glenn Morris <rgm@gnu.org>
8366
99cf43f9
GM
8367 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
8368 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
8369 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
8370 All were removed before 23.1.
8371
9311dcff
GM
8372 * dispnew.c: Remove HAVE_LIBNCURSES test;
8373 it is always true on relevant platforms.
8374
4d5c6349
GM
8375 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
8376 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
8377
4737362e
GM
8378 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
8379
74dd3a6b
AS
83802012-04-30 Andreas Schwab <schwab@linux-m68k.org>
8381
8382 * .gdbinit (xpr): Remove checks for no longer existing misc types.
8383 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
8384 Remove.
8385
13c379ee
PE
83862012-04-28 Paul Eggert <eggert@cs.ucla.edu>
8387
8388 Do not avoid creating empty evaporating overlays (Bug#9642).
8389 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
8390 That is, do not delete an evaporating overlay if it becomes
8391 empty after its bounds are adjusted to fit within its buffer.
8392 This fix caused other problems, and I'm reverting it until we get
8393 to the bottom of them.
8394
a8e7d6d7 83952012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
8396
8397 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
8398
a8e7d6d7 83992012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
8400
8401 * xdisp.c (pos_visible_p): If the window start position is beyond
8402 ZV, start the display from buffer beginning. Prevents assertion
8403 violation in init_iterator when the minibuffer window is scrolled
8404 via the scroll bar.
8405
8406 * window.c (window_scroll_pixel_based): Likewise.
8407
a8e7d6d7 84082012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
8409
8410 * keymap.c (where_is_internal): Doc fix (Bug#10872).
8411
a8e7d6d7 84122012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
8413
8414 * fileio.c (Fcopy_file, Fset_file_selinux_context):
8415 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
8416
a8e7d6d7 84172012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 8418
b593d6a9
AH
8419 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
8420 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 8421
1c6900d9
EZ
84222012-04-26 Eli Zaretskii <eliz@gnu.org>
8423
4c3fa1d9
EZ
8424 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
8425 display element, check also the underlying string or buffer
8426 character. (Bug#11341)
8427
1c6900d9
EZ
8428 * w32menu.c: Include w32heap.h.
8429 (add_menu_item): If the call to AppendMenuW (via
8430 unicode_append_menu) fails, disable Unicode menus only if we are
8431 running on Windows 9X/Me.
8432
42bf8205
AS
84332012-04-24 Andreas Schwab <schwab@linux-m68k.org>
8434
8435 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
8436 (xgetint): Add missing shift for LSB tags.
8437
b1bac16e
MR
84382012-04-24 Martin Rudalics <rudalics@gmx.at>
8439
8440 * keyboard.c (read_char): Don't wipe echo area for select window
8441 events: These might get delayed via `mouse-autoselect-window'
8442 (Bug#11304).
8443
d69621cc
JB
84442012-04-24 Juanma Barranquero <lekktu@gmail.com>
8445
8446 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
8447 manipulation of :loaded-from data.
8448
02fd101b
JB
84492012-04-23 Juanma Barranquero <lekktu@gmail.com>
8450
8451 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
8452 now a cons (bug#11311).
8453
888bec30
PE
84542012-04-23 Paul Eggert <eggert@cs.ucla.edu>
8455
89a438bd
PE
8456 Do not create empty overlays with the evaporate property (Bug#9642).
8457 * buffer.c (Fmove_overlay): Delete an evaporating overlay
8458 if it becomes empty after its bounds are adjusted to fit within
8459 its buffer. Without this fix, in a nonempty buffer (let ((o
8460 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
8461 yields an empty overlay that has the evaporate property, which is
8462 not supposed to happen.
8463
1068fe4d
PE
8464 Fix minor GTK3 problems found by static checking.
8465 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
8466 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
8467 (struct _EmacsFixedClass, emacs_fixed_get_type):
8468 Move decls here from emacsgtkfixed.h, since they needn't be public.
8469 (emacs_fixed_get_type): Now static.
8470 (emacs_fixed_class_init): Omit unused local.
8471 (emacs_fixed_child_type): Remove; unused.
8472 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
8473 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
8474 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
8475 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
8476 (EMACS_FIXED_GET_CLASS): Remove; unused.
8477 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
8478
888bec30
PE
8479 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
8480 Problem reported by Juanma Barranquero for Windows -Wunused-function.
8481
de85e130
PE
84822012-04-22 Paul Eggert <eggert@cs.ucla.edu>
8483
d0baac98 8484 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 8485 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
8486 (__malloc_size_t, __malloc_ptrdiff_t):
8487 Remove. All uses removed, replaced by the definiens if needed,
8488 since we can assume C89 or better now.
8489 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
8490 (protect_malloc_state, align, get_contiguous_space)
8491 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
8492 (malloc_atfork_handler_child, malloc_enable_thread)
8493 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
8494 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
8495 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
8496 (special_realloc, _realloc_internal_nolock, _realloc_internal)
8497 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
8498 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
8499 Define using prototypes, not old style.
8500 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
8501 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
8502 (align): Don't assume that signed integer overflow wraps around.
8503 Omit unused local var.
8504 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
8505 (_free_internal_nolock, memalign, mallochook, reallochook):
8506 Omit no-longer-needed casts.
8507 (valloc): Use getpagesize, not __getpagesize.
8508 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
8509 (struct hdr): The 'magic' member is now size_t, not unsigned long.
8510
de85e130
PE
8511 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
8512
dcbf5805
MA
85132012-04-22 Michael Albinus <michael.albinus@gmx.de>
8514
8515 Move functions from C to Lisp. Make non-blocking method calls
8516 the default. Implement further D-Bus standard interfaces.
8517
8518 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
8519 (QCdbus_request_name_allow_replacement)
8520 (QCdbus_request_name_replace_existing)
8521 (QCdbus_request_name_do_not_queue)
8522 (QCdbus_request_name_reply_primary_owner)
8523 (QCdbus_request_name_reply_in_queue)
8524 (QCdbus_request_name_reply_exists)
8525 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
8526 (QCdbus_registered_serial, QCdbus_registered_method)
8527 (QCdbus_registered_signal): New Lisp objects.
8528 (XD_DEBUG_MESSAGE): Use sizeof.
8529 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
8530 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
8531 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
8532 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
8533 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
8534 (xd_signature, xd_append_arg): Allow float for integer types.
8535 (xd_get_connection_references): New function.
b593d6a9
AH
8536 (xd_get_connection_address): Rename from xd_initialize.
8537 Return cached address.
dcbf5805
MA
8538 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
8539 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
8540 level.
8541 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 8542 Return number of refcounts.
dcbf5805
MA
8543 (Fdbus_get_unique_name): Make stronger parameter check.
8544 (Fdbus_message_internal): New defun.
8545 (Fdbus_call_method, Fdbus_call_method_asynchronously)
8546 (Fdbus_method_return_internal, Fdbus_method_error_internal)
8547 (Fdbus_send_signal, Fdbus_register_service)
8548 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
8549 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
8550 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
8551 (Vdbus_compiled_version, Vdbus_runtime_version)
8552 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
8553 (Vdbus_message_type_method_return, Vdbus_message_type_error)
8554 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
8555 (Vdbus_registered_buses, Vdbus_registered_objects_table):
8556 Adapt docstring.
dcbf5805 8557
52828e02
PE
85582012-04-22 Paul Eggert <eggert@cs.ucla.edu>
8559
da05bc4c
PE
8560 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
8561 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
8562 Do not assume ptrdiff_t is the same width as 'int'.
8563
52828e02
PE
8564 * alloc.c: Handle unusual debugging option combinations.
8565 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
8566 since the two debugging options are incompatible.
8567 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
8568 is defined.
8569 (mem_init, mem_insert, mem_insert_fixup):
8570 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
8571 (NEED_MEM_INSERT): Remove; no longer needed.
8572
f01769f9
LL
85732012-04-22 Leo Liu <sdl.web@gmail.com>
8574
8575 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
8576
5790543d
PE
85772012-04-22 Paul Eggert <eggert@cs.ucla.edu>
8578
8579 * sysdep.c [__FreeBSD__]: Minor cleanups.
8580 (list_system_processes, system_process_attributes) [__FreeBSD__]:
8581 Use Emacs indenting style more consistently. Avoid some casts.
8582 Use 'double' consistently rather than mixing 'float' and 'double'.
8583
b91b7e4d
EW
85842012-04-21 Eduard Wiebe <usenet@pusto.de>
8585
b593d6a9
AH
8586 * sysdep.c (list_system_processes, system_process_attributes):
8587 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 8588
6114eb15
AS
85892012-04-21 Andreas Schwab <schwab@linux-m68k.org>
8590
8591 * lisp.mk (lisp): Update.
8592
2f38dff7
PE
85932012-04-20 Paul Eggert <eggert@cs.ucla.edu>
8594
8595 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
8596 It is never used otherwise.
8597
4ae29f89
SM
85982012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
8599
8600 * print.c (print_preprocess): Only check print_depth if print-circle
8601 is nil.
8602 (print_object): Check for cycles even when print-circle is nil and
8603 print-gensym is t, but only check print_depth if print-circle is nil.
8604
f30d612a
CY
86052012-04-20 Chong Yidong <cyd@gnu.org>
8606
8607 * process.c (wait_reading_process_output): If EIO occurs on a pty,
8608 set the status to "failed" and ensure that sentinel is run.
8609
c07a4c0b 86102012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
8611
8612 * process.c (Fset_process_inherit_coding_system_flag)
8613 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 8614 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 8615
c07a4c0b 86162012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
8617
8618 * xdisp.c (string_buffer_position_lim): Limit starting position to
8619 BEGV.
8620 (set_cursor_from_row): If called for a mode-line or header-line
8621 row, return zero immediately.
8622 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
8623 farther than the first row after the header line, if any.
8624 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
8625 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
8626
c07a4c0b 86272012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 8628
4ae29f89
SM
8629 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
8630 (bug#11238).
ad3a2b41 8631
c07a4c0b 86322012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 86332012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
8634
8635 configure: new option --enable-gcc-warnings (Bug#11207)
8636 * Makefile.in (C_WARNINGS_SWITCH): Remove.
8637 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
8638 (ALL_CFLAGS): Use new macros rather than old.
8639 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
8640 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
8641 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
8642 -Wunused-result, -Wunused-variable. This should go away once
8643 the Emacs and Gnulib regex code is merged.
8644 (xmalloc, xrealloc): Now static.
8645
aba027e8
PE
86462012-04-17 Paul Eggert <eggert@cs.ucla.edu>
8647
8648 * dired.c (Fsystem_groups): Remove unused local.
8649
e5a36063
GM
86502012-04-17 Glenn Morris <rgm@gnu.org>
8651
8652 * dired.c (Fsystem_users): Doc fix.
8653
316411f0
DA
86542012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
8655
8656 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
8657 (syms_of_dired): Add them.
8658
9426aba4
PE
86592012-04-16 Paul Eggert <eggert@cs.ucla.edu>
8660
b62a57be
PE
8661 Fix minor alloc.c problems found by static checking.
8662 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
8663 New extern decls, to avoid calling undeclared functions.
8664 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
8665 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
8666 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
8667 (NEED_MEM_INSERT): New macro.
8668 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 8669 Remove one incorrect comment and fix another.
b62a57be 8670
3539f31f
PE
8671 Fix minor ralloc.c problems found by static checking.
8672 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
8673 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
8674 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
8675 (r_alloc_sbrk): Now static.
8676
a041960a
PE
8677 Improve ralloc.c interface checking.
8678 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
8679 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
8680 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
8681 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
8682 [REL_ALLOC]: ... to here, to check interface.
8683 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
8684 Remove decls. This fixes an "It stinks!".
8685
9426aba4
PE
8686 * alloc.c (which_symbols): Fix alignment issue / type clash.
8687
d55c12ed
AS
86882012-04-15 Andreas Schwab <schwab@linux-m68k.org>
8689
8690 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
8691 (struct Lisp_Misc_Any): Likewise.
8692 (struct Lisp_Free): Likewise.
8693 * alloc.c (union aligned_Lisp_Symbol): Define.
8694 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
8695 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
8696 (union aligned_Lisp_Misc): Define.
8697 (MARKER_BLOCK_SIZE, struct marker_block): Use union
8698 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 8699 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 8700
b948ce8b
PE
87012012-04-14 Paul Eggert <eggert@cs.ucla.edu>
8702
8703 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
8704 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
8705 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
8706 * s/netbsd.h, s/sol2-6.h:
8707 Remove definition of GC_MARK_STACK, since the default now works.
8708 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
8709 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
8710 no longer the default.
8711 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
8712
35dc09a1 87132012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 8714
35dc09a1
GM
8715 * lread.c (lisp_file_lexically_bound_p):
8716 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 8717
35dc09a1
GM
87182012-04-14 Eli Zaretskii <eliz@gnu.org>
8719
8720 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
8721 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
8722
87232012-04-14 Jan Djärv <jan.h.d@swipnet.se>
8724
8725 * nsterm.m (constrainFrameRect): Always constrain when there is only
8726 one screen (Bug#10962).
8727
bcd86815
KB
87282012-04-13 Ken Brown <kbrown@cornell.edu>
8729
8730 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
8731
c25df26e
RT
87322012-04-13 Reuben Thomas <rrt@sc3d.org>
8733
8734 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
8735
0fc59f1e
DC
87362012-04-11 Daniel Colascione <dancol@dancol.org>
8737
8738 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
8739 against is gone. It's better to use vfork now so that when Cygwin
8740 gains a new, working vfork, we use it automatically (bug#10398).
8741
de8c03dc
SM
87422012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
8743
8744 * window.c (save_window_save): Obey window-point-insertion-type.
8745
2f097256
GM
87462012-04-11 Glenn Morris <rgm@gnu.org>
8747
8748 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
8749
453b951e
SM
87502012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
8751
8752 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
8753
75f1671a 87542012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
8755
8756 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
8757 (force_quit_count): New var.
8758 (handle_interrupt): Use it.
8759
2a8ce227
JB
87602012-04-10 Juanma Barranquero <lekktu@gmail.com>
8761
8762 * w32.c (w32_delayed_load): Record the full path of the library
8763 being loaded (bug#10424).
8764
935396c0
GM
87652012-04-09 Glenn Morris <rgm@gnu.org>
8766
05920a43
GM
8767 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
8768 not just in the obarray, before snarfing them. (Bug#11036)
8769
935396c0
GM
8770 * Makefile.in ($(leimdir)/leim-list.el):
8771 Pass EMACS rather than BUILT_EMACS.
8772
a18ecafa
TZ
87732012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
8774
8775 * process.c (make_process):
8776 * process.h: Add integer `gnutls_handshakes_tried' member to
8777 process struct.
8778
6bbef4e5
JC
8779 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
8780 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
8781
8782 * gnutls.c (gnutls_log_function2i): Convenience log function.
8783 (emacs_gnutls_read): Use new log functions,
8784 `gnutls_handshakes_tried' process member, and
8785 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
8786 attempts per process (connection).
8787
b4d3bc10
CY
87882012-04-09 Chong Yidong <cyd@gnu.org>
8789
8790 * eval.c (Fuser_variable_p, user_variable_p_eh)
8791 (lisp_indirect_variable): Functions deleted.
8792 (Fdefvar): Caller changed.
8793
8794 * callint.c (Finteractive, Fcall_interactively):
8795 * minibuf.c (Fread_variable): Callers changed.
8796
70f4d973
EZ
87972012-04-09 Eli Zaretskii <eliz@gnu.org>
8798
8799 * xdisp.c (set_cursor_from_row): If the display string appears in
8800 the buffer at position that is closer to point than the position
8801 after the display string, display the cursor on the first glyph of
8802 the display string. Fixes cursor display when a 'display' text
8803 property immediately follows invisible text. (Bug#11094)
8804
cb3c2e3e
PE
88052012-04-09 Paul Eggert <eggert@cs.ucla.edu>
8806
8807 composite.c: use 'double' consistently
8808 * composite.c (get_composition_id): Use 'double' consistently
8809 instead of converting 'float' to 'double' and vice versa; this is
8810 easier to understand and avoids a GCC warning.
8811
fd06db5d
GM
88122012-04-09 Glenn Morris <rgm@gnu.org>
8813
50fe702a
GM
8814 * Makefile.in: Generate leim-list with bootstrap-emacs, in
8815 preparation for dumping it with emacs. (Bug#4789)
8816 (leimdir): New variable.
8817 ($(leimdir)/leim-list.el): New rule.
8818 (emacs$(EXEEXT)): Depend on leim-list.el.
8819
fd06db5d
GM
8820 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
8821 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
8822 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
8823
55c131ee
AS
88242012-04-08 Andreas Schwab <schwab@linux-m68k.org>
8825
8826 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
8827 proper alignment.
8828
9209588f
JB
88292012-04-07 Juanma Barranquero <lekktu@gmail.com>
8830
8831 * xml.c (init_libxml2_functions) [WINDOWSNT]:
8832 Remove unused local variable.
8833
e3fb2efb
PE
88342012-04-07 Paul Eggert <eggert@cs.ucla.edu>
8835
8836 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
8837 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
8838 (mark_memory): Mark Lisp_Objects only if pointers might hide in
8839 objects, as mark_maybe_pointer will catch them otherwise.
8840 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
8841 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
8842
b5385551
PE
88432012-04-07 Paul Eggert <eggert@cs.ucla.edu>
8844
8845 Fix typo that broke non-Windows builds.
8846 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
8847
9078ead6
EZ
88482012-04-07 Eli Zaretskii <eliz@gnu.org>
8849
8850 Support building on MS-Windows with libxml2.
8851
8852 * makefile.w32-in (OBJ2): Add xml.$(O).
8853 (GLOBAL_SOURCES): Add xml.c.
8854 ($(BLD)/xml.$(O)): New dependency list.
8855
8856 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
8857 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
8858 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
8859 [!WINDOWSNT]: New macros.
8860 (init_libxml2_functions, libxml2_loaded_p): New functions.
8861 (parse_region): Call fn_xmlCheckVersion instead of using the macro
8862 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
8863 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
8864 Calls xmlCleanupParser only if libxml2 was loaded (or statically
8865 linked in).
6bbef4e5
JC
8866 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
8867 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
8868 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
8869
8870 * emacs.c: Don't include libxml/parser.h.
8871 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
8872 xmlCleanupParser directly.
8873
8874 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
8875
3811fdf3
EZ
88762012-04-07 Eli Zaretskii <eliz@gnu.org>
8877
8878 * indent.c (Fvertical_motion): If there is a display string at
8879 point, use it.vpos to compute how many lines to backtrack after
8880 move_it_to point. (Bug#11133)
8881
2f8e16b2
EZ
88822012-04-06 Eli Zaretskii <eliz@gnu.org>
8883
8884 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
8885 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
8886 about subtle differences between FETCH_CHAR* and STRING_CHAR*
8887 macros related to unification of CJK characters. For the details,
8888 see the discussion following the message here:
8889 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
8890
3d439cd1
CY
88912012-04-04 Chong Yidong <cyd@gnu.org>
8892
8893 * keyboard.c (Vdelayed_warnings_list): Doc fix.
8894
8bc53d00
EZ
88952012-04-01 Eli Zaretskii <eliz@gnu.org>
8896
8897 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
8898 instead of alloca. (Bug#11138)
8899
3b0512a3
AS
89002012-04-01 Andreas Schwab <schwab@linux-m68k.org>
8901
8902 * w32menu.c (is_simple_dialog): Properly check lisp types.
8903 (Bug#11141)
8904
8427ddd2
EZ
89052012-03-31 Eli Zaretskii <eliz@gnu.org>
8906
979022ef
EZ
8907 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
8908 position we get to after a call to move_it_to fails the
8909 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
8910 only if we wind up in a string from display property. (Bug#11063)
8911
a6b1c7cc
EZ
8912 * window.c (Fdelete_other_windows_internal): Invalidate the row
8913 and column information about mouse highlight, so that redisplay
8914 restores it after reallocating the glyph matrices. (Bug#7464)
8915
8427ddd2
EZ
8916 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
8917 string comes from a `display' text property, use the buffer
8918 position of that property as if we actually saw that position in
8919 the row's glyphs.
697ba24b
EZ
8920 (move_it_by_lines): Remove the assertion that
8921 "it->current_x == 0 && it->hpos == 0" which can be legitimately
8922 violated when there's a before-string at the beginning of a line.
8923 (Bug#11063)
8427ddd2 8924
65a0a738
EZ
89252012-03-30 Eli Zaretskii <eliz@gnu.org>
8926
8927 * xdisp.c (append_space_for_newline): If the default face was
8928 remapped, use the remapped face for the appended newline.
8929 (extend_face_to_end_of_line): Use the remapped default face for
8930 extending the face to the end of the line.
8931 (display_line): Call extend_face_to_end_of_line when the default
8932 face was remapped. (Bug#11068)
8933
581355cc
EZ
89342012-03-29 Eli Zaretskii <eliz@gnu.org>
8935
8936 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
8937
e8fc049f
SM
89382012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8939
8940 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
8941
4fb9a543
GM
89422012-03-27 Glenn Morris <rgm@gnu.org>
8943
8944 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
8945 Doc fixes.
8946
679910f1
KH
89472012-03-26 Kenichi Handa <handa@m17n.org>
8948
8949 * dispextern.h (struct glyph): Fix previous change. Change the
8950 bit length of glyphless.ch to 25 (Bug#11082).
8951
90d49b7f
CY
89522012-03-26 Chong Yidong <cyd@gnu.org>
8953
8954 * keyboard.c (Vselection_inhibit_update_commands): New variable.
8955 (command_loop_1): Use it; inhibit selection update for
8956 handle-select-window too (Bug#8996).
8957
f514f6f0
FP
89582012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
8959
e8fc049f 8960 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 8961
bf43fa51
KH
89622012-03-25 Kenichi Handa <handa@m17n.org>
8963
8964 * dispextern.h (struct glyph): Change the bit length of
8965 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
8966
8a0c01dd
EZ
89672012-03-24 Eli Zaretskii <eliz@gnu.org>
8968
8969 * s/ms-w32.h (tzname): Include time.h before redirecting to
8970 _tzname. Fixes the MSVC build. (Bug#9960)
8971
7d1c3a76
AS
89722012-03-24 Andreas Schwab <schwab@linux-m68k.org>
8973
8ed79523
AS
8974 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
8975 characters.
8976
7d1c3a76
AS
8977 * xterm.c (XTread_socket): Only modify handling_signal if
8978 !SYNC_INPUT. (Bug#11080)
8979
e99a9b8b
EZ
89802012-03-23 Eli Zaretskii <eliz@gnu.org>
8981
8982 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
8983 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
8984 when fetching a multibyte character consumes more bytes than
8985 CHAR_BYTES returns, due to unification of CJK characters in
8986 string_char. (Bug#11073)
8987
5063c0e1
TN
89882012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
8989
8990 * process.c (wait_reading_process_output): Handle pty disconnect
8991 by refraining from sending oneself a SIGCHLD (bug#10933).
8992
9f851fbd
CY
89932012-03-22 Chong Yidong <cyd@gnu.org>
8994
8995 * dispextern.h (struct it): New member string_from_prefix_prop_p.
8996
5063c0e1 8997 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
8998 Mark string as coming from a prefix property.
8999 (handle_face_prop): Use default face for prefix strings (Bug#4281).
9000 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
9001
fb5b8aca
CY
90022012-03-21 Chong Yidong <cyd@gnu.org>
9003
9004 * xfaces.c (Vface_remapping_alist): Doc fix.
9005
62356a1b
EZ
90062012-03-20 Eli Zaretskii <eliz@gnu.org>
9007
9008 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
9009 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
9010 Doc fixes.
62356a1b 9011
025de85b
CY
90122012-03-20 Chong Yidong <cyd@gnu.org>
9013
9014 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
9015 to reflect default non-nil value of redisplay-dont-pause.
9016
4827f94e
KH
90172012-03-19 Kenichi Handa <handa@m17n.org>
9018
9019 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
9020 it fit in a valid range (Bug#11003).
9021
e50a24a2
EZ
90222012-03-18 Eli Zaretskii <eliz@gnu.org>
9023
9024 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
9025 that is not from display property, accept the row as a "cursor
9026 row" if one of the string's character has a non-nil `cursor'
9027 property. Fixes cursor positioning when there are newlines in
9028 overlay strings, e.g. in icomplete.el. (Bug#11035)
9029
9af5ed87
PE
90302012-03-12 Paul Eggert <eggert@cs.ucla.edu>
9031
9032 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
9033
d1f55f16
CY
90342012-03-12 Chong Yidong <cyd@gnu.org>
9035
9036 * eval.c (inhibit_lisp_code): Rename from
9037 inhibit_window_configuration_change_hook; move from window.c.
9038
9039 * xfns.c (unwind_create_frame_1, Fx_create_frame):
9040 * window.c (run_window_configuration_change_hook)
9041 (syms_of_window): Callers changed.
9042
66c5eebd
CY
90432012-03-11 Chong Yidong <cyd@gnu.org>
9044
413df973
CY
9045 * keymap.c (Fkey_description): Doc fix (Bug#9700).
9046
66c5eebd
CY
9047 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
9048
1de11f56
CY
90492012-03-10 Chong Yidong <cyd@gnu.org>
9050
9051 * frame.c (other_visible_frames): Don't assume the selected frame
9052 is visible (Bug#10955).
9053
cae07000
SM
90542012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
9055
9056 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
9057
89c94350
JD
90582012-03-08 Jan Djärv <jan.h.d@swipnet.se>
9059
9060 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
9061 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
9062 zero (Bug#10954).
9063
999dd333
GM
90642012-03-03 Glenn Morris <rgm@gnu.org>
9065
01a6dcc8 9066 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 9067
de0100f2
EZ
90682012-03-02 Eli Zaretskii <eliz@gnu.org>
9069
9070 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
9071 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
9072 (redisplay_window, next_element_from_string): Fix typos in
9073 comments.
3e441275
EZ
9074 (redisplay_window): Pass to move_it_vertically the margin in
9075 pixels, not in screen lines.
de0100f2 9076
96a72ee9
GM
90772012-03-02 Glenn Morris <rgm@gnu.org>
9078
9079 * buffer.c (buffer-list-update-hook): Doc fix.
9080
312508d7
EZ
90812012-02-29 Eli Zaretskii <eliz@gnu.org>
9082
9083 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
9084 push_it before setting up the iterator for the first overlay
9085 string, even if we have an empty string loaded.
9086 (next_overlay_string): If there's an empty string on the iterator
9087 stack, pop the stack. (Bug#10903)
9088
27f3c637
PE
90892012-02-25 Paul Eggert <eggert@cs.ucla.edu>
9090
9091 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
9092 Suggested by Stefan Monnier in
9093 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
9094 * alloc.c (widen_to_Lisp_Object): New static function.
9095 (mark_memory): Also mark Lisp_Objects by fetching pointer words
9096 and widening them to Lisp_Objects. This would work even if
9097 USE_LSB_TAG is defined and wide integers are used, which might
9098 happen in a future version of Emacs.
9099
3c9dfce6
CY
91002012-02-25 Chong Yidong <cyd@gnu.org>
9101
fa74b241
CY
9102 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
9103 Doc fix.
9104
3c9dfce6
CY
9105 * xselect.c (Fx_selection_exists_p): Doc fix.
9106 (x_clipboard_manager_save_all): Print an informative message
9107 before saving to clipboard manager.
9108
9486df08
CY
91092012-02-24 Chong Yidong <cyd@gnu.org>
9110
9111 * keyboard.c (process_special_events): Handle all X selection
9112 requests in kbd_buffer, not just the next one (Bug#8869).
9113
f01d3321
CY
91142012-02-23 Chong Yidong <cyd@gnu.org>
9115
9116 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
9117 call when setting menu-bar-lines and tool-bar-lines parameters.
9118 (unwind_create_frame_1): New helper function.
9119
9120 * window.c (inhibit_window_configuration_change_hook): New var.
9121 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 9122 (syms_of_window): Initialize it.
f01d3321 9123
86b847b6
CY
91242012-02-22 Chong Yidong <cyd@gnu.org>
9125
9126 * xterm.c (x_draw_image_relief): Add missing type check for
9127 Vtool_bar_button_margin (Bug#10743).
9128
a59225b1
CY
91292012-02-21 Chong Yidong <cyd@gnu.org>
9130
9131 * fileio.c (Vfile_name_handler_alist): Doc fix.
9132
9133 * buffer.c (Fget_file_buffer): Protect against invalid file
9134 handler return value.
9135
310f5bd4
PE
91362012-02-20 Paul Eggert <eggert@cs.ucla.edu>
9137
cb3a28cc
PE
9138 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
9139 when computing $valmask.
9140
310f5bd4
PE
9141 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
9142 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
9143 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
9144 It's useless in that case, and it can cause problems on hosts
9145 that allocate halves of EMACS_INT values separately.
9146 Reported by Dan Horák. Diagnosed by Andreas Schwab in
9147 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
9148 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
9149 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
9150 it avoids undefined behavior on hosts where shifting right by more
9151 than the word width has undefined behavior.
9152
2375c96a
CY
91532012-02-19 Chong Yidong <cyd@gnu.org>
9154
9155 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
9156 (Funhandled_file_name_directory, Ffile_name_as_directory)
9157 (Fdirectory_file_name, Fexpand_file_name)
9158 (Fsubstitute_in_file_name): Protect against invalid file handler
9159 return values (Bug#10845).
9160
3eb49e71
EZ
91612012-02-18 Eli Zaretskii <eliz@gnu.org>
9162
9163 * .gdbinit (pitx): Fix incorrect references to fields of the
9164 iterator stack.
9165
7b926f3f
CY
91662012-02-17 Chong Yidong <cyd@gnu.org>
9167
9168 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
9169
11273115
PE
91702012-02-15 Paul Eggert <eggert@cs.ucla.edu>
9171
9172 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
9173 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
9174
c3a70e2b
CY
91752012-02-15 Chong Yidong <cyd@gnu.org>
9176
9177 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
9178 marked as special. Also, starting docstrings with * is obsolete.
9179
0ca43699
AS
91802012-02-13 Andreas Schwab <schwab@linux-m68k.org>
9181
9182 * gnutls.c (emacs_gnutls_write): Fix last change.
9183
2e8f3c56
LI
91842012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
9185
9186 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
9187 send_process.
9188
af70074f
SM
91892012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
9190
9191 * keymap.c (Fsingle_key_description): Handle char ranges.
9192
95986d52
CY
91932012-02-12 Chong Yidong <cyd@gnu.org>
9194
afd83bd1
CY
9195 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
9196 as that creates a dangerous corner case.
9197
95986d52
CY
9198 * window.c (Fdelete_window_internal): Invalidate the mouse
9199 highlight (Bug#9904).
9200
bd7da63e
GM
92012012-02-12 Glenn Morris <rgm@gnu.org>
9202
9203 * xselect.c (Fx_own_selection_internal)
9204 (Fx_get_selection_internal, Fx_disown_selection_internal)
9205 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
9206 * nsselect.m (Fx_own_selection_internal)
9207 (Fx_disown_selection_internal, Fx_selection_exists_p)
9208 (Fx_selection_owner_p, Fx_get_selection_internal):
9209 Sync docs and argument specs with the xselect.c versions.
9210
77abcbc2
LI
92112012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
9212
9213 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
9214
90b671e2
EZ
92152012-02-11 Eli Zaretskii <eliz@gnu.org>
9216
1c0ca0b7
EZ
9217 * w32select.c (Fx_selection_exists_p): Sync doc string and
9218 argument list with xselect.c. (Bug#10783)
9219
9220 * w16select.c (Fx_selection_exists_p): Sync doc string and
9221 argument list with xselect.c. (Bug#10783)
90b671e2 9222
49241268
GM
92232012-02-10 Glenn Morris <rgm@gnu.org>
9224
9225 * fns.c (Fsecure_hash): Doc fix.
9226
f998bbe7 92272012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
9228
9229 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
9230
0992bd9c
CY
92312012-02-07 Chong Yidong <cyd@gnu.org>
9232
9233 * buffer.c (Fbuffer_local_variables)
9234 (buffer_lisp_local_variables): Handle unbound vars correctly;
9235 don't let Qunbound leak into Lisp.
9236
af008560
GM
92372012-02-07 Glenn Morris <rgm@gnu.org>
9238
dd605cc4
GM
9239 * image.c (Fimagemagick_types): Doc fix.
9240
af008560
GM
9241 * image.c (imagemagick-render-type): Change it from a lisp object
9242 to an integer. Move the doc here from the lisp manual.
9243 Treat all values not equal to 0 the same.
9244
1449fa1d
CY
92452012-02-06 Chong Yidong <cyd@gnu.org>
9246
9247 * doc.c (store_function_docstring): Avoid applying docstring of
9248 alias to base function (Bug#2603).
9249
3723ec07
AS
92502012-02-04 Andreas Schwab <schwab@linux-m68k.org>
9251
9252 * .gdbinit (pp1, pv1): Remove redundant defines.
9253 (pr): Use pp.
9254
79c1cc1e
CY
92552012-02-04 Chong Yidong <cyd@gnu.org>
9256
9257 * nsterm.m: Declare a global (Bug#10694).
9258
d7f29f8e
EZ
92592012-02-04 Eli Zaretskii <eliz@gnu.org>
9260
cae07000
SM
9261 * w32.c (get_emacs_configuration_options):
9262 Include --enable-checking, if specified, in the return value.
d7f29f8e 9263
3b95a6f9
MR
92642012-02-04 Martin Rudalics <rudalics@gmx.at>
9265
9266 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
9267 after rounding frame sizes. (Bug#9723)
9268
d6fa96a6
EZ
92692012-02-04 Eli Zaretskii <eliz@gnu.org>
9270
9271 * keyboard.c (adjust_point_for_property): Don't position point
9272 before BEGV. (Bug#10696)
9273
df0b2940
PE
92742012-02-03 Paul Eggert <eggert@cs.ucla.edu>
9275
9276 Handle overflow when computing char display width (Bug#9496).
9277 * character.c (char_width): Return EMACS_INT, not int.
9278 (char_width, c_string_width): Check for overflow when
9279 computing the width; this is possible now that individual
9280 characters can have unbounded width. Problem introduced
9281 by merge from Emacs 23 on 2012-01-19.
9282
6bee44d6
MA
92832012-02-02 Michael Albinus <michael.albinus@gmx.de>
9284
9285 * dbusbind.c (Fdbus_register_method): Mention the return value
9286 :ignore in the docstring.
9287
44f92739
GM
92882012-02-02 Glenn Morris <rgm@gnu.org>
9289
1b9f60cc
GM
9290 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
9291
44f92739
GM
9292 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
9293 Unconditionally set to t. (Bug#10673)
9294 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
9295 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
9296 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
9297
c5d3843c
KH
92982012-02-02 Kenichi Handa <handa@m17n.org>
9299
9300 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
9301 0, do not call append_composite_glyph.
9302
159462d4 93032012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
9304
9305 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
9306 NULL (Bug#6988).
9307 (x_produce_glyphs): If the component of a composition is a null
9308 string, set it->pixel_width to 1 to avoid zero-width glyph.
9309
78cef877
EZ
93102012-02-01 Eli Zaretskii <eliz@gnu.org>
9311
9312 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
9313 first 2 arguments are identical. This makes inserting large
9314 output from a subprocess an order of magnitude faster on
9315 MS-Windows, where all sbrk'ed memory is always contiguous.
9316
97897668
GM
93172012-01-31 Glenn Morris <rgm@gnu.org>
9318
9319 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 9320 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
9321 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
9322
31fd3586
GM
93232012-01-29 Glenn Morris <rgm@gnu.org>
9324
9325 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
9326
0e24a8b2
CY
93272012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
9328
9329 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
9330
cc0adcb0
CY
93312012-01-28 Chong Yidong <cyd@gnu.org>
9332
9333 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
9334
acc28cb9
CY
93352012-01-26 Chong Yidong <cyd@gnu.org>
9336
9c69cfb7
CY
9337 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
9338
acc28cb9
CY
9339 * search.c (Fsearch_forward, Fsearch_backward): Document negative
9340 repeat counts (Bug#10507).
9341
48da7392
GM
93422012-01-26 Glenn Morris <rgm@gnu.org>
9343
9344 * lread.c (syms_of_lread): Doc fix.
9345
14af5f7f
CY
93462012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
9347
9348 * coding.c (encode_designation_at_bol): Change return value to
9349 EMACS_INT.
9350
0b21c100
CY
93512012-01-25 Chong Yidong <cyd@gnu.org>
9352
9353 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
9354
3c2907f7
CY
93552012-01-21 Chong Yidong <cyd@gnu.org>
9356
9357 * floatfns.c (Fcopysign): Make the second argument non-optional,
9358 since nil is not allowed anyway.
9359
959ad23f
AS
93602012-01-21 Andreas Schwab <schwab@linux-m68k.org>
9361
9362 * process.c (read_process_output): Use p instead of XPROCESS (proc).
9363 (send_process): Likewise.
9364
34a02f46
MR
93652012-01-19 Martin Rudalics <rudalics@gmx.at>
9366
9367 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
9368 (Vwindow_persistent_parameters): Do not use Qstate.
9369 Rewrite doc-strings.
34a02f46 9370
1259009a 93712012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
9372
9373 * character.c (char_width): New function.
70d4fdf6
GM
9374 (Fchar_width, c_string_width, lisp_string_width):
9375 Use char_width (Bug#9496).
25ed9e61 9376
6a6ee00d
MR
93772012-01-16 Martin Rudalics <rudalics@gmx.at>
9378
9379 * window.c (Vwindow_persistent_parameters): New variable.
9380 (Fset_window_configuration, save_window_save): Handle persistent
9381 window parameters.
9382
c85efaf7
EZ
93832012-01-14 Eli Zaretskii <eliz@gnu.org>
9384
9385 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
9386 thrashing the stack of the thread. (Bug#9087)
9387
5944709e
PE
93882012-01-12 Paul Eggert <eggert@cs.ucla.edu>
9389
9390 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
9391
e71f5d99
EZ
93922012-01-11 Eli Zaretskii <eliz@gnu.org>
9393
9394 * xdisp.c (rows_from_pos_range): Handle the case where the
9395 highlight ends on a newline. (Bug#10464)
9396 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
9397 he end column for display of highlight that ends on a newline
9398 before a R2L line.
9399
ce316182
GM
94002012-01-11 Glenn Morris <rgm@gnu.org>
9401
9402 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
9403 from load-path also when installation-directory is nil. (Bug#10208)
9404
5b43da69
GM
94052012-01-10 Glenn Morris <rgm@gnu.org>
9406
74cc8ff9
GM
9407 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
9408
7d8d6e4e
GM
9409 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
9410 Update template values to be closer to their typical values these days.
5b43da69 9411
a0db8d43
EZ
94122012-01-09 Eli Zaretskii <eliz@gnu.org>
9413
9414 * xdisp.c (rows_from_pos_range): Accept additional argument
9415 DISP_STRING, and accept any glyph in a row whose object is that
9416 string as eligible for mouse highlight. Fixes mouse highlight of
9417 display strings from overlays. (Bug#10464)
9418
9a0115ab 94192012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 9420
b9110d6a 9421 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
9422 * fileio.c (auto_saving_dir_umask): New static var.
9423 (Fmake_directory_internal): Use it.
9424 (do_auto_save_make_dir): Set it, instead of invoking chmod after
9425 creating the directory. The old code temporarily assigns
9426 too-generous permissions to the directory.
9427 (do_auto_save_eh): Clear it.
b9110d6a 9428 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
9429 that the var is always cleared.
9430
6c1bd3f3
EZ
94312012-01-07 Eli Zaretskii <eliz@gnu.org>
9432
9433 * search.c (scan_buffer): Pass character positions to
9434 know_region_cache, not byte positions. (Bug#6540)
9435
069d2b50
L
94362012-01-07 LynX <_LynX@bk.ru> (tiny change)
9437
9438 * w32.c (sys_rename): Report EXDEV when rename of a directory
9439 fails because the target is on another logical disk. (Bug#10284)
9440
75bf0d33
DB
94412012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
9442
9443 * xterm.c (x_embed_request_focus): New function.
9444
9445 * xterm.h: Add prototype.
9446
9447 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
9448
1c6e5a32
GM
94492012-01-05 Glenn Morris <rgm@gnu.org>
9450
9451 * emacs.c (emacs_copyright): Update short copyright year to 2012.
9452
651e947e
EZ
94532012-01-01 Eli Zaretskii <eliz@gnu.org>
9454
9455 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
9456 Load gnutls_transport_set_lowat only if GnuTLS version is below
9457 2.11.1.
9458 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
9459 GnuTLS versions below 2.11.1.
9460
3778cdd8
AL
94612011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
9462
9463 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
9464 to the doc string advising against its use for altering the way
9465 windows are scrolled.
9466
0e5317f7
KH
94672011-12-28 Kenichi Handa <handa@m17n.org>
9468
9469 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
9470 coding-system ASCII compatible only when it does not produce BOM
9471 on encoding (Bug#10383).
9472
93d5ca1f
JD
94732011-12-26 Jan Djärv <jan.h.d@swipnet.se>
9474
9475 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
9476 can scroll.
9477 (create_and_show_popup_menu): Always use menu_position_func for
9478 Gtk3 (Bug#10361).
9479
ca22b785
AS
94802011-12-24 Andreas Schwab <schwab@linux-m68k.org>
9481
9482 * callint.c (Fcall_interactively): Don't truncate prompt string.
9483
d048e1e6
EZ
94842011-12-23 Eli Zaretskii <eliz@gnu.org>
9485
9486 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
9487 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 9488 resumed from there (after widening). (Bug#10360)
d048e1e6 9489
5ccaba1f
JD
94902011-12-22 Jan Djärv <jan.h.d@swipnet.se>
9491
9492 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
9493
204ee57f
JD
94942011-12-21 Jan Djärv <jan.h.d@swipnet.se>
9495
b81d40f0
JB
9496 * nsterm.m (x_free_frame_resources):
9497 Release f->output_data.ns->miniimage.
204ee57f
JD
9498 (ns_index_color): Fix indentation. Do not retain
9499 color_table->colors[i].
9500
9501 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
9502 before returning.
9503
9504 * nsfns.m (x_set_background_color): Assign return value from
9505 ns_index_color to face-background instead of NSColor*.
9506 (ns_implicitly_set_icon_type): Fix indentation.
9507 Change assignment in for loop to comparison.
9508
9509 * emacs.c (ns_pool): New variable.
9510 (main): Assign ns_pool.
9511 (Fkill_emacs): Call ns_release_autorelease_pool.
9512
9513 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
9514 autorelease fdesc, release fdAttrs and tdict.
9515 (ns_get_covering_families): Release charset.
9516 (ns_findfonts): Release NSFontDescriptor created with new.
9517 (ns_uni_to_glyphs): Fix indentation.
9518 (setString): Release attrStr before assigning new value.
9519
c803b2b7
JD
95202011-12-18 Jan Djärv <jan.h.d@swipnet.se>
9521
678f4426
JD
9522 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
9523 and NS_IMPL_COCOA.
9524 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
9525 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
9526
cd394be1 95272011-12-18 David Reitter <reitter@cmu.edu>
678f4426 9528
5fecd5fc
JD
9529 * nsterm.m (ns_term_init): Subscribe for notifications
9530 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
9531 to method trackingNotification in EmacsMenu.
9532
9533 * nsmenu.m (trackingMenu): New variable.
3771cb17 9534 (trackingNotification): New method (from Aquamacs).
5fecd5fc 9535 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 9536 from Aquamacs (Bug#7030).
678f4426
JD
9537
95382011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 9539
c803b2b7
JD
9540 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
9541 (symbol_to_nsstring): Fix indentation.
9542 (ns_symbol_to_pb): New function.
cae07000
SM
9543 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
9544 (Fns_rotate_cut_buffers_internal): Remove.
9545 (Fns_store_selection_internal): Rename from
c803b2b7
JD
9546 Fns_store_cut_buffer_internal.
9547 (ns_get_foreign_selection, Fx_own_selection_internal)
9548 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
9549 (Fns_get_selection_internal, Fns_store_selection_internal):
9550 Use ns_symbol_to_pb and check if return value is nil.
9551 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
9552 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
9553 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
9554 renamed to Sns_store_selection_internal.
9555 (ns_handle_selection_request): Move code to Fx_own_selection_internal
9556 and remove this function.
9557 (ns_handle_selection_clear): Remove, never used.
9558 (Fx_own_selection_internal): Move code from ns_handle_selection_request
9559 here.
9560
e1b01a3a
KB
95612011-12-17 Ken Brown <kbrown@cornell.edu>
9562
9563 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
9564 GID is unknown (Bug#10257).
9565
2adb6e85
PE
95662011-12-17 Paul Eggert <eggert@cs.ucla.edu>
9567
9568 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
9569 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
9570 which caused a build failure on GNU/Linux IA-64. This problem was
9571 introduced by my 2011-10-07 patch.
9572
d1d7b339
JL
95732011-12-15 Juri Linkov <juri@jurta.org>
9574
9575 * image.c (imagemagick_error): New function. (Bug#10112)
9576 (imagemagick_load_image): Comment out `MagickSetResolution' call.
9577 Use `imagemagick_error' where ImageMagick functions return
9578 `MagickFalse'.
9579 (Fimagemagick_types): Add `Fnreverse' to return the list in the
9580 proper order.
9581
100d5755
KH
95822011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9583
9584 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
9585 fill background (Bug#8992).
9586
454592a6
MR
95872011-12-13 Martin Rudalics <rudalics@gmx.at>
9588
9589 * window.c (Vwindow_combination_resize)
9590 (Vwindow_combination_limit): Use t instead of non-nil in
9591 doc-strings.
61d4b438
MR
9592 (Vrecenter_redisplay): Add first sentence of doc-string on
9593 separate line.
53524d93 9594 (Frecenter): Fix doc-string typo.
454592a6 9595
3633e3aa
KH
95962011-12-11 Kenichi Handa <handa@m17n.org>
9597
9598 * coding.c (Funencodable_char_position): Pay attention to the
9599 buffer text relocation (Bug#9389).
9600
7b9d523a 96012011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 9602
7b9d523a
JD
9603 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
9604 gtk_init (Bug#10100).
9605
b73189c6
EZ
96062011-12-10 Eli Zaretskii <eliz@gnu.org>
9607
9608 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
9609 IT->string is nil. (Bug#10263)
9610
f7dfe5d6
JD
96112011-12-10 Jan Djärv <jan.h.d@swipnet.se>
9612
83faebb4
JD
9613 * nsterm.h (x_free_frame_resources): Declare.
9614
f7dfe5d6
JD
9615 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
9616 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
9617
9618 * nsterm.h (ns_get_defaults_value): Declare.
9619
9620 * nsterm.m (ns_default): Call ns_get_defaults_value.
9621
7cd4e72c
EZ
96222011-12-09 Eli Zaretskii <eliz@gnu.org>
9623
9624 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
9625 (Bug#10170)
9626
b34d7317
YM
96272011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9628
9629 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
9630 that where the value of an _OBJC_* symbol points to is in the .bss
9631 section (Bug#10240).
9632
76470ad1
KH
96332011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
9634
9635 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 9636 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 9637
745fff94
KH
96382011-12-08 Kenichi Handa <handa@m17n.org>
9639
9640 * ftfont.c (get_adstyle_property): Fix previous change
9641 (Bug#10233).
9642
6e44397c
JB
96432011-12-07 Juanma Barranquero <lekktu@gmail.com>
9644
9645 * w32.c (init_environment): If no_site_lisp, remove site-lisp
9646 dirs from the default value of EMACSLOADPATH (bug#10208).
9647
7efa6272
GM
96482011-12-07 Glenn Morris <rgm@gnu.org>
9649
9650 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
9651 installation and source directories as well. (Bug#10208)
9652
f6fc4d87
CY
96532011-12-06 Chong Yidong <cyd@gnu.org>
9654
9655 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
9656
2bf26180
GM
96572011-12-06 Glenn Morris <rgm@gnu.org>
9658
9659 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
9660 as an error, not just -1. (Bug#10217)
9661
3a6ad4f0
CY
96622011-12-05 Chong Yidong <cyd@gnu.org>
9663
9664 * keyboard.c (process_special_events): New function.
9665 (swallow_events, Finput_pending_p): Use it (Bug#10195).
9666
75a3b399
PE
96672011-12-05 Paul Eggert <eggert@cs.ucla.edu>
9668
9669 * coding.c (encode_designation_at_bol): Don't use uninitialized
9670 local variable (Bug#9318).
9671
c3c9e25e
KH
96722011-12-05 Kenichi Handa <handa@m17n.org>
9673
9674 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
9675 return Qnil (Bug#8046, Bug#10193).
9676
5eb05ea3
KH
96772011-12-05 Kenichi Handa <handa@m17n.org>
9678
9679 * coding.c (encode_designation_at_bol): New args charbuf_end and
9680 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
9681 (coding_set_source): Return how many bytes coding->source was
9682 relocated.
9683 (coding_set_destination): Return how many bytes
9684 coding->destination was relocated.
9685 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 9686 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
9687
96882011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
9689
9690 * coding.c (CODING_CHAR_CHARSET_P): New macro.
9691 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
9692 macro (Bug#9318).
9693
96942011-12-05 Andreas Schwab <schwab@linux-m68k.org>
9695
9696 The following changes are to fix Bug#9318.
9697
a79703f5 9698 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
9699 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
9700 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 9701 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 9702
7dbda6df
JB
97032011-12-05 Juanma Barranquero <lekktu@gmail.com>
9704
9705 * lisp.h (process_quit_flag): Fix external declaration.
9706
6d5eb5b0
SM
97072011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
9708
9709 Don't macro-inline non-performance-critical code.
9710 * eval.c (process_quit_flag): New function.
9711 * lisp.h (QUIT): Use it.
9712
a0c3fad0
JD
97132011-12-04 Jan Djärv <jan.h.d@swipnet.se>
9714
9715 * nsfns.m (get_geometry_from_preferences): New function.
9716 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
9717
6c07aac2
AS
97182011-12-04 Andreas Schwab <schwab@linux-m68k.org>
9719
9720 * emacs.c (Qkill_emacs): Define.
9721 (syms_of_emacs): Initialize it.
9722 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
9723 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
9724 (quit_throw_to_read_char): Add parameter `from_signal'.
9725 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
9726 * lisp.h (QUIT): Call Fkill_emacs if requested.
9727
c052ead4
JD
97282011-12-03 Jan Djärv <jan.h.d@swipnet.se>
9729
9730 * widget.c (update_wm_hints): Return if wmshell is null.
9731 (widget_update_wm_size_hints): New function.
9732
9733 * widget.h (widget_update_wm_size_hints): Declare.
9734
9735 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
9736 widget_update_wm_size_hints (Bug#10104).
9737
9e49252b
EZ
97382011-12-03 Eli Zaretskii <eliz@gnu.org>
9739
9740 * xdisp.c (handle_invisible_prop): If the invisible text ends just
9741 before a newline, prepare the bidi iterator for consuming the
9742 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 9743 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 9744
02b16839
JL
97452011-12-02 Juri Linkov <juri@jurta.org>
9746
9747 * search.c (Fword_search_regexp): New Lisp function created from
9748 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
9749 (Fword_search_backward, Fword_search_forward)
9750 (Fword_search_backward_lax, Fword_search_forward_lax):
9751 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
9752 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
9753
0068070e
SM
97542011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
9755
9756 * fileio.c (Finsert_file_contents): Move after-change-function call
9757 to before the "handled:" label, since all "goto handled" appear in
9758 cases where the *-change-functions have already been properly called
9759 (bug#10117).
9760
3360a3fc
AS
97612011-12-01 Andreas Schwab <schwab@linux-m68k.org>
9762
9763 * keyboard.c (interrupt_signal): Don't call kill-emacs when
9764 waiting for input. (Bug#10169)
9765
73d6c093
EZ
97662011-11-30 Eli Zaretskii <eliz@gnu.org>
9767
9768 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
9769 verifies glyph row's hash code--we have just reallocated the
9770 glyphs, so their contents can be complete garbage. (Bug#10164)
9771
febe6bea
JB
97722011-11-30 Juanma Barranquero <lekktu@gmail.com>
9773
9774 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
9775
801a4313
EZ
97762011-11-30 Eli Zaretskii <eliz@gnu.org>
9777
9778 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
9779 attributes are tested _before_ calling verify_row_hash, to protect
9780 against GCC re-ordering of the tests. (Bug#10164)
9781
2b56b87e
JD
97822011-11-29 Jan Djärv <jan.h.d@swipnet.se>
9783
9784 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
9785
9786 * xterm.c (handle_one_xevent): Only set async_visible and friends
9787 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 9788 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
9789 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
9790
dbf31225
PE
97912011-11-28 Paul Eggert <eggert@cs.ucla.edu>
9792
9793 Remove GCPRO-related macros that exist only to avoid shadowing locals.
9794 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
9795 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
9796 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
9797 All uses changed to use GCPRO1 etc.
9798 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
9799 Revert to old implementation (i.e., before 2011-03-11).
9800
1305621b
YM
98012011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9802
9803 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
9804 of scroll runs so as to avoid assigning disabled bogus rows and
9805 unnecessary graphics copy operations.
9806
8c9afb46
EZ
98072011-11-27 Eli Zaretskii <eliz@gnu.org>
9808
9809 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
9810 (snprintf) [_MSC_VER]: Redirect to _snprintf.
9811 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
9812 (malloc, free, realloc, calloc): Redirect to e_* only when
9813 compiling Emacs.
9814
9815 * lisp.h (GCTYPEBITS): Move before first use.
9816 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
9817 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
9818 this macro definition.
9819
9820 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
9821 _MSC_VER.
9822
54e9e3bf
JD
98232011-11-27 Jan Djärv <jan.h.d@swipnet.se>
9824
6d5eb5b0
SM
9825 * gtkutil.c (xg_create_frame_widgets):
9826 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
9827 present with Gtk+ 2.0.
9828
83aca1cb
PE
98292011-11-26 Paul Eggert <eggert@cs.ucla.edu>
9830
9831 * fileio.c (Finsert_file_contents): Undo previous change; see
9832 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
9833
5b76caa4
PE
98342011-11-26 Paul Eggert <eggert@cs.ucla.edu>
9835
9836 Rename locals to avoid shadowing.
9837 * fileio.c (Finsert_file_contents):
9838 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
9839 * process.c (wait_reading_process_output):
9840 Rename inner 'proc' to 'p' to avoid shadowing.
9841 Indent for consistency with usual Emacs style.
9842
8c535114
EZ
98432011-11-25 Eli Zaretskii <eliz@gnu.org>
9844
9845 * xdisp.c (redisplay_window): If cursor row is not fully visible
9846 after recentering, and scroll-conservatively is set to a large
9847 number, scroll window by a few more lines to make the cursor fully
9848 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
9849 (start_display): Don't move to the next line if the display should
9850 start at a newline that is part of a display vector or an overlay
9851 string. (Bug#10119)
8c535114 9852
fa4fdb5c
JL
98532011-11-24 Juri Linkov <juri@jurta.org>
9854
9855 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
9856 after the `MagickPingImage' call. (Bug#10112)
9857
90ec88df
CY
98582011-11-23 Chong Yidong <cyd@gnu.org>
9859
9860 * window.c (Fcoordinates_in_window_p): Accept only live windows.
9861
56e2e794
MR
98622011-11-23 Martin Rudalics <rudalics@gmx.at>
9863
9864 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
9865 making another buffer current. (Bug#10114)
9866
b6e64c41
GM
98672011-11-23 Glenn Morris <rgm@gnu.org>
9868
9869 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
9870
6b21de18
CY
98712011-11-23 Chong Yidong <cyd@gnu.org>
9872
9873 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
9874 using it (Bug#5984).
9875
b12cd789
EZ
98762011-11-22 Eli Zaretskii <eliz@gnu.org>
9877
9878 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
9879 and header-lines, as they don't have one computed for them.
9880 (Bug#10098)
9881
9882 * .gdbinit (prow): Make displayed values more self-explaining.
9883 Add row's hash code.
9884
261b6fd4
LMI
98852011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
9886
9887 * process.c (wait_reading_process_output): Fix asynchrounous
9888 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 9889 (wait_reading_process_output): Add comment and URL.
261b6fd4 9890
e7cfd277
JD
98912011-11-21 Jan Djärv <jan.h.d@swipnet.se>
9892
9893 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
9894
a9b9b7f5
CY
98952011-11-21 Chong Yidong <cyd@gnu.org>
9896
9897 * window.c (Fnext_window, Fprevious_window): Doc fix.
9898
b0d15b4f
SM
98992011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
9900
9901 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
9902
fe7a3057
JB
99032011-11-20 Juanma Barranquero <lekktu@gmail.com>
9904
9905 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
9906
d2999b1a
MR
99072011-11-20 Martin Rudalics <rudalics@gmx.at>
9908
9909 * window.c (Fset_window_combination_limit): Rename argument
9910 STATUS to LIMIT.
9911 (Vwindow_combination_limit): Remove "status" from doc-string.
9912
d5ff9cd0
AS
99132011-11-20 Andreas Schwab <schwab@linux-m68k.org>
9914
9915 * m/ibms390.h: Remove.
9916 * m/ibms390x.h: Don't include "ibms390.h".
9917
a5bb9bd3
SM
99182011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
9919
9920 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
9921 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
9922
cd1181db
JB
99232011-11-20 Juanma Barranquero <lekktu@gmail.com>
9924
9925 * casetab.c (Fset_case_table):
9926 * charset.c (Fcharset_after): Fix typos.
9927
615a3b8d 99282011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 9929
17e845af
PE
9930 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
9931 Otherwise, valgrind does not work on some platforms.
9932 Problem reported by Andreas Schwab in
6a0bf43d
PE
9933 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
9934 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
9935 is set, removing the need for VIRT_ADDRESS_VARIES.
9936 (PURE_P): Use a more-efficient implementation that needs just one
9937 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
9938 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
9939 to 4 (xorl, subq, cmpq, setbe).
9940 * alloc.c (pure): Always extern now, since that's the
9941 VIRT_ADDR_VARIES behavior.
9942 (PURE_POINTER_P): Use a single comparison, not two, for
9943 consistency with the new puresize.h.
9944 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
9945 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
9946 Remove VIRT_ADDR_VARIES no longer needed.
9947
f8fe6f96
EZ
99482011-11-19 Eli Zaretskii <eliz@gnu.org>
9949
9950 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
9951 (erase_phys_cursor, update_window_cursor, show_mouse_face)
9952 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
9953 behave as if the cursor position were at the window margin.
9954
9955 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
9956 and the cursor position is out of bounds, behave as if the cursor
9957 position were at the window margin. (Bug#10075)
9958
df05a53c
CY
99592011-11-18 Chong Yidong <cyd@gnu.org>
9960
9961 * window.c (Fwindow_combination_limit): Make first argument
9962 non-optional, since it is meaningless for live windows like the
9963 selected window.
61ccba97 9964
2071918e
DA
99652011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
9966
9967 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
9968
b50a28de
SM
99692011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
9970
9971 * intervals.c: Fix grafting over the whole buffer (bug#10071).
9972 (graft_intervals_into_buffer): Simplify.
9973
015137db
EZ
99742011-11-18 Eli Zaretskii <eliz@gnu.org>
9975
9976 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
9977 hash values of the two rows.
9978 (copy_row_except_pointers): Preserve the used[] arrays and the
9979 hash values of the two rows. (Bug#10035)
68c95424 9980 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
9981
9982 * xdisp.c (row_hash): New function, body extracted from
9983 compute_line_metrics.
9984 (compute_line_metrics): Call row_hash, instead of computing the
9985 hash code inline.
9986
9987 * dispnew.c (verify_row_hash): Call row_hash for computing the
9988 hash code of a row, instead of duplicating code from xdisp.c.
9989
9990 * dispextern.h (row_hash): Add prototype.
9991
a2addb04
TH
99922011-11-18 Tassilo Horn <tassilo@member.fsf.org>
9993
9994 * frame.c (delete_frame): Don't delete the terminal when the last
9995 X frame is closed if emacs is built with GTK toolkit.
9996
df85d315
JB
99972011-11-17 Juanma Barranquero <lekktu@gmail.com>
9998
9999 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
10000
a0c2d0ae
MR
100012011-11-17 Martin Rudalics <rudalics@gmx.at>
10002
10003 * window.c (Vwindow_splits): Rename to
10004 Vwindow_combination_resize. Suggested by Juri Linkov.
10005 (Fsplit_window_internal): Use Vwindow_combination_resize instead
10006 of Vwindow_splits.
10007
58179cce
JB
100082011-11-16 Juanma Barranquero <lekktu@gmail.com>
10009
7877f373
JB
10010 * nsfns.m (Fns_font_name):
10011 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 10012
b6f67890
MR
100132011-11-16 Martin Rudalics <rudalics@gmx.at>
10014
10015 * window.h (window): Rename slot "nest" to "combination_limit".
10016 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
10017 (Fset_window_nest): Rename to Fset_window_combination_limit.
10018 (Vwindow_nest): Rename to Vwindow_combination_limit.
10019 (recombine_windows, make_parent_window, make_window)
10020 (Fsplit_window_internal, saved_window)
10021 (Fset_window_configuration, save_window_save): Rename all
10022 occurrences of window_nest to window_combination_limit.
10023
c7015153
JB
100242011-11-15 Juanma Barranquero <lekktu@gmail.com>
10025
10026 * image.c (imagemagick_load_image): Fix typo.
10027
322ad6ec
EZ
100282011-11-14 Eli Zaretskii <eliz@gnu.org>
10029
10030 * xdisp.c (display_line): Move the call to
10031 highlight_trailing_whitespace before the call to
10032 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
10033 faces of all the glyphs to compute ROW's hash value.
10034 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 10035
f067b8ec
JB
100362011-11-14 Juanma Barranquero <lekktu@gmail.com>
10037
10038 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
10039 just return (bug#10044).
10040
1e5b2111
EZ
100412011-11-12 Eli Zaretskii <eliz@gnu.org>
10042
7ef3cbd5
EZ
10043 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
10044 with user-defined heap size. Bump the default size of the temacs
10045 heap to 27MB, to avoid memory warning when running temacs.
10046 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
10047
1e5b2111
EZ
10048 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
10049 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
10050 (verify_row_hash) [XASSERTS]: New function.
10051 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
10052 that the hash value of glyph rows is correct.
1e5b2111 10053
89d61221
MR
100542011-11-12 Martin Rudalics <rudalics@gmx.at>
10055
10056 * window.h (window): Remove splits slot.
10057 * window.c (Fwindow_splits, Fset_window_splits): Remove.
10058 (Fdelete_other_windows_internal, make_parent_window)
10059 (make_window, Fsplit_window_internal, Fdelete_window_internal)
10060 (Fset_window_configuration, save_window_save): Don't deal with
10061 split status of windows.
10062 (saved_window): Remove splits slot.
10063 (Vwindow_splits): Rewrite doc-string.
10064
97f18cc8
JD
100652011-11-11 Jan Djärv <jan.h.d@swipnet.se>
10066
10067 * xfns.c (unwind_create_frame):
10068 * nsfns.m (unwind_create_frame):
10069 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
10070 Vframe_list (Bug#9999).
10071
22a648b4
DA
100722011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
10073
0b381c7e 10074 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 10075
659afede
KH
100762011-11-11 Kenichi Handa <handa@m17n.org>
10077
10078 * callproc.c (Fcall_process): Set the member dst_multibyte of
10079 process_coding.
10080
9ac0394b
KH
100812011-11-11 Johan Bockgård <bojohan@gnu.org>
10082
10083 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
10084 avoid a crash (bug#9496).
10085
2fbdc249
CY
100862011-11-09 Chong Yidong <cyd@gnu.org>
10087
10088 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
10089 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
10090
ac6b1f81
PE
100912011-11-08 Paul Eggert <eggert@cs.ucla.edu>
10092
10093 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
10094
09db192c
PE
100952011-11-08 Paul Eggert <eggert@cs.ucla.edu>
10096
10097 Avoid some portability problems by eschewing 'extern inline' functions.
10098 The trivial performance wins aren't worth the portability hassles; see
10099 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
10100 et seq.
10101 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
10102 (window_box_width, window_box_left, window_box_left_offset)
10103 (window_box_right, window_box_right_offset): Undo previous change,
10104 by removing the "extern"s.
10105 * intervals.c (adjust_intervals_for_insertion)
10106 (adjust_intervals_for_deletion): Undo previous change,
10107 making these static again.
10108 (offset_intervals, temp_set_point_both, temp_set_point)
10109 (copy_intervals_to_string): No longer inline.
10110 * xdisp.c (window_text_bottom_y, window_box_width)
10111 (window_box_height, window_box_left_offset)
10112 (window_box_right_offset, window_box_left, window_box_right)
10113 (window_box): No longer inline.
10114
105216ed
CY
101152011-11-08 Chong Yidong <cyd@gnu.org>
10116
10117 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
10118 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
10119 Signal an error if not a live window.
105216ed
CY
10120 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
10121 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
10122
ae9e237f
JB
101232011-11-07 Juanma Barranquero <lekktu@gmail.com>
10124
10125 * lisp.h (syms_of_abbrev): Remove declaration.
10126 Reported by CHENG Gao <chenggao@royau.me>.
10127
c7aa8333
EZ
101282011-11-07 Eli Zaretskii <eliz@gnu.org>
10129
10130 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
10131 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
10132 of temacs in GUI mode.
10133
be7f5545
MR
101342011-11-07 Martin Rudalics <rudalics@gmx.at>
10135
10136 * window.h: Declare delete_all_child_windows instead of
10137 delete_all_subwindows.
10138 * window.c (Fwindow_nest, Fset_window_nest)
10139 (Fset_window_new_total, Fset_window_new_normal)
10140 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
10141 (delete_all_subwindows): Rename to delete_all_child_windows.
10142 (Fdelete_other_windows_internal, Fset_window_configuration):
10143 Call delete_all_child_windows instead of delete_all_subwindows.
10144 * frame.c (delete_frame): Call delete_all_child_windows instead
10145 of delete_all_subwindows.
10146
ca78dc43
PE
101472011-11-07 Paul Eggert <eggert@cs.ucla.edu>
10148
10149 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
10150 This is also needed for porting to any host where GC_MARK_STACK is
10151 not GC_MAKE_GCPROS_NOOPS.
10152 (which_symbols): Use it.
10153
a0241d01
KH
101542011-11-07 Kenichi Handa <handa@m17n.org>
10155
10156 * coding.c (coding_set_destination): Check coding->src_pos only
10157 when coding->src_object is a buffer (bug#9910).
10158
10159 * process.c (send_process): Set the member src_multibyte of coding
10160 to 0 (bug#9911) when sending a unibyte text.
10161
10162 * callproc.c (Fcall_process): Set the member src_multibyte of
10163 process_coding to 0 (bug#9912).
10164
a64bfdfa 101652011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
10166
10167 * xmenu.c (cleanup_widget_value_tree): New function.
10168 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
10169 calling free_menubar_widget_value_tree directly (Bug#9830).
10170
cb41b32a
PE
101712011-11-06 Paul Eggert <eggert@cs.ucla.edu>
10172
10173 Fix some portability problems with 'inline'.
10174 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
10175 (window_box_width, window_box_left, window_box_left_offset)
10176 (window_box_right, window_box_right_offset): Declare extern.
10177 Otherwise, these inline functions do not conform to C99 and
10178 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
10179 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
10180 * intervals.c (adjust_intervals_for_insertion)
10181 (adjust_intervals_for_deletion): Now extern, because otherwise the
10182 extern inline functions 'offset_intervals' couldn't refer to it.
10183 (static_offset_intervals): Remove.
10184 (offset_intervals): Rewrite using the old contents of
10185 static_offset_intervals. The old version didn't conform to C99
10186 because an extern inline function contained a reference to an
10187 identifier with static linkage.
10188
b7041366
AS
101892011-11-06 Andreas Schwab <schwab@linux-m68k.org>
10190
10191 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
10192 GC.
10193
88a37c4d
EZ
101942011-11-06 Eli Zaretskii <eliz@gnu.org>
10195
10196 * xdisp.c (init_iterator, reseat_to_string): Don't set the
10197 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
10198 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
10199 return Qleft_to_right.
10200
49745b39
CY
102012011-11-06 Chong Yidong <cyd@gnu.org>
10202
10203 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
10204 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
10205 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
10206 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
10207 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
10208 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
10209 (Fwindow_vscroll): Doc fix.
10210 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
10211 argument, since it makes no sense to pass a live window and for
10212 consistency with window-child.
10213
1f05cd82
CS
102142011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
10215
10216 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
10217 support MSVC.
10218
22610910
JR
102192011-11-05 Jason Rumney <jasonr@gnu.org>
10220
10221 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
10222 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
10223 fonts (Bug#6029).
10224 (add_font_entity_to_list): Fix logic errors in mixed boolean and
10225 bitwise arithmetic preventing use of unicode-sip and non-truetype
10226 opentype fonts.
10227
a06776b2
EZ
102282011-11-05 Eli Zaretskii <eliz@gnu.org>
10229
3ad924ba
EZ
10230 * s/ms-w32.h (fstat, stat, utime): Move redirections to
10231 "emacs"-only part.
10232
a06776b2
EZ
10233 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
10234 initialization code to keep similarity to xfns.c after changes
10235 from 2011-11-05.
10236
c9e7db78
JD
102372011-11-05 Jan Djärv <jan.h.d@swipnet.se>
10238
a97f8f3f
JD
10239 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
10240 (unwind_create_frame): New function (Bug#9943).
10241 (Fx_create_frame): Restructure code to be more similar to the one in
10242 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
10243 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
10244 Move terminal->reference_count++ just before making the frame official
10245 (Bug#9943).
10246
10247 * nsterm.m (x_free_frame_resources): New function.
10248 (x_destroy_window): Move code to x_free_frame_resources.
10249
c9e7db78 10250 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
10251 (Fx_create_frame, x_create_tip_frame):
10252 Move terminal->reference_count++ just before making the frame
75f1671a 10253 official. Move initialization of image_cache_refcount and
c9e7db78
JD
10254 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
10255
a6fc3b5c
EZ
102562011-11-05 Eli Zaretskii <eliz@gnu.org>
10257
10258 Support MSVC build with newer versions of Visual Studio.
10259 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
10260 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
10261 nt/gmake.defs.
10262
10263 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
10264 which are not supported by MSVC.
10265 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
10266 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
10267 bitfields.
10268 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
10269 types in bitfields.
10270 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
10271
10272 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
10273
58179cce 102742011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
10275
10276 Support MSVC build with newer versions of Visual Studio.
10277 * w32.c: Don't include w32api.h for MSVC.
10278 (init_environment) [_MSC_VER]: Call sys_access, not _access.
10279
10280 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
10281 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
10282 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
10283 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
10284 e_* cousins.
10285 (alloca) [_MSC_VER]: Define to _alloca.
10286
10287 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
10288
10289 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
10290
a58c13ed
EZ
102912011-11-04 Eli Zaretskii <eliz@gnu.org>
10292
10293 * xdisp.c (note_mouse_highlight): If either of
10294 previous/next-single-property-change returns nil, treat that as
10295 the beginning or the end of the buffer. (Bug#9955)
10296
fe0b6370
JD
102972011-11-04 Jan Djärv <jan.h.d@swipnet.se>
10298
a58c13ed 10299 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
10300 label is not null (Bug#9951).
10301 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
10302 may be NULL.
10303
89bd5ee1
EZ
103042011-11-04 Eli Zaretskii <eliz@gnu.org>
10305
10306 * window.c (Fwindow_body_size): Mention in the doc string that the
10307 return value is in frame's canonical units. (Bug#9949)
10308
84c3edb9
EZ
103092011-11-03 Eli Zaretskii <eliz@gnu.org>
10310
4e2fb5c7
EZ
10311 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
10312
84c3edb9 10313 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 10314 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 10315 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 10316
bc17a887
EZ
103172011-11-01 Eli Zaretskii <eliz@gnu.org>
10318
10319 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
10320 Don't stop backward scan on the continuation glyph, even though
10321 its CHARPOS is positive.
6d5eb5b0
SM
10322 (mouse_face_from_buffer_pos, note_mouse_highlight):
10323 Rename cover_string to disp_string.
bc17a887 10324
4ee88440
MR
103252011-11-01 Martin Rudalics <rudalics@gmx.at>
10326
10327 * window.c (temp_output_buffer_show): Don't use
10328 Vtemp_buffer_show_specifiers.
10329 (Vtemp_buffer_show_specifiers): Remove unused variable.
10330
c2ff3c02
EZ
103312011-10-30 Eli Zaretskii <eliz@gnu.org>
10332
10333 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
10334 past the beginning of the current glyph matrix.
10335
58179cce 103362011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
10337
10338 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
10339 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
10340 HAVE_GTK3 (Bug#9869).
b77a6a7f 10341
3b574623
JD
10342 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
10343 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
10344
b77a6a7f
JD
10345 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
10346
10347 * xterm.c: Declare x_handle_net_wm_state to return int.
10348 (handle_one_xevent): Check if we are iconified but don't have
10349 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
10350 (get_current_wm_state): Return non-zero if not hidden,
10351 check for _NET_WM_STATE_HIDDEN (Bug#9893).
10352 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
10353 (x_handle_net_wm_state): Return what get_current_wm_state returns.
10354 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
10355
196e41e4
PE
103562011-10-29 Paul Eggert <eggert@cs.ucla.edu>
10357
10358 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
10359 so that this new function doesn't get optimized away by a
10360 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
10361
021f2e1a
AS
103622011-10-29 Andreas Schwab <schwab@linux-m68k.org>
10363
10364 * frame.h (MOUSE_HL_INFO): Remove excess parens.
10365
8b058d44
EZ
103662011-10-29 Eli Zaretskii <eliz@gnu.org>
10367
10368 Fix the `xbytecode' command.
10369 * .gdbinit (xprintbytestr): New command.
b50a28de 10370 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
10371 (xbytecode): Print the byte-code string as well.
10372
4452fb80
EZ
103732011-10-29 Kim Storm <storm@cua.dk>
10374
8b058d44
EZ
10375 * alloc.c (which_symbols): New function.
10376
21b72067
AS
103772011-10-29 Andreas Schwab <schwab@linux-m68k.org>
10378
10379 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
10380 line. (Bug#9903)
10381
83ed7b5c
GM
103822011-10-29 Glenn Morris <rgm@gnu.org>
10383
10384 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
10385 Not clear what it was for, and it causes various bugs. (Bug#9839)
10386
5a7a728b
EZ
103872011-10-28 Eli Zaretskii <eliz@gnu.org>
10388
10389 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
10390 possible random value that matches one of those tested as
10391 condition to clear the mouse face.
10392
d3d0842f
CY
103932011-10-28 Chong Yidong <cyd@gnu.org>
10394
10395 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
10396
31b39d13
DN
103972011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
10398
10399 * window.c (make_window): Initialize phys_cursor_on_p.
10400
9aba6043
SM
104012011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
10402
10403 * lisp.h (struct Lisp_Symbol): Update comments.
10404
c20992f4
JB
104052011-10-28 Juanma Barranquero <lekktu@gmail.com>
10406
10407 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
10408
db4f02f2
EZ
104092011-10-28 Eli Zaretskii <eliz@gnu.org>
10410
10411 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
10412 <oslsachem@gmail.com> for helping to debug this.
10413
10414 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
10415 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
10416 (g_b_init_get_glyph_outline_w): New static variables.
10417 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
10418 (GetGlyphOutlineW_Proc): New typedefs.
10419 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
10420 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
10421 New functions.
10422 (w32font_open_internal, compute_metrics):
10423 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
10424 instead of calling the "wide" APIs directly.
10425
10426 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
10427
10428 * w32.h (syms_of_w32font): Add prototype.
10429
87e68db4
JB
104302011-10-27 Juanma Barranquero <lekktu@gmail.com>
10431
10432 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
10433 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
10434 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
10435 (Fmove_to_window_line): Doc fix.
10436
435c1d67
CY
104372011-10-27 Chong Yidong <cyd@gnu.org>
10438
10439 * process.c (make_process): Set gnutls_state to NULL.
10440
10441 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
10442 non-NULL, regardless of GNUTLS_INITSTAGE.
10443 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
10444 an error. Set process slots as soon as we allocate them.
10445
10446 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
10447
9c6c6f49
CY
104482011-10-27 Chong Yidong <cyd@gnu.org>
10449
9aba6043
SM
10450 * gnutls.c (emacs_gnutls_deinit): New function.
10451 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
10452 (Fgnutls_deinit, Fgnutls_boot): Use it.
10453
10454 * process.c (make_process): Initialize GnuTLS credentials to NULL.
10455 (deactivate_process): Call emacs_gnutls_deinit.
10456
657d08d3
JB
104572011-10-27 Juanma Barranquero <lekktu@gmail.com>
10458
10459 * image.c (x_create_x_image_and_pixmap):
10460 * w32.c (sys_rename, w32_delayed_load):
10461 * w32font.c (fill_in_logfont):
10462 * w32reg.c (x_get_string_resource): Silence compiler warnings.
10463
5430d399
JB
104642011-10-26 Juanma Barranquero <lekktu@gmail.com>
10465
10466 * w32fns.c (w32_default_color_map): New function,
10467 extracted from Fw32_default_color_map.
a7ef684b 10468 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 10469
fe0055fa
PE
104702011-10-25 Paul Eggert <eggert@cs.ucla.edu>
10471
10472 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
10473
e6346438
SM
104742011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
10475
10476 * keyboard.c (test_undefined): New function (bug#9751).
10477 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
10478
e112cc37
ET
104792011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
10480
10481 * sysdep.c (init_sys_modes): Fix the check for the controlling
10482 terminal (Bug#6649).
10483
7b5d6677
EZ
104842011-10-20 Eli Zaretskii <eliz@gnu.org>
10485
10486 * dispextern.h (struct bidi_it): New member next_en_type.
10487
10488 * bidi.c (bidi_line_init): Initialize the next_en_type member.
10489 (bidi_resolve_explicit_1): When next_en_pos is valid for the
10490 current character, check also for next_en_type being WEAK_EN.
10491 (bidi_resolve_weak): Don't enter the expensive loop if the current
10492 position is before next_en_pos. Record the bidi type of the first
10493 non-ET, non-BN character we find, in addition to its position.
10494 (bidi_level_of_next_char): Invalidate next_en_type when
10495 next_en_pos is over-stepped.
10496
7da0b018
PE
104972011-10-20 Paul Eggert <eggert@cs.ucla.edu>
10498
10499 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
10500 * editfns.c: Rewrite current-time-zone so that it invokes
10501 the equivalent of (format-time-string "%Z") to get the time zone name.
10502 This fixes a bug when the time zone name contains characters that
10503 need converting from the system time locale to Emacs internal format.
10504 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
10505 that patch fixed format-time-string to do the conversion, but
10506 I forgot to fix current-time-zone.
10507 (format_time_string): New function, containing most of
10508 what Fformat_time_string used to contain.
10509 (Fformat_time_string): Rewrite in terms of format_time_string.
10510 This doesn't change this function's behavior.
10511 (current-time-zone): Rewrite to use format_time_string.
10512 This fixes the bug reported by Michael Schierl in
10513 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
10514 Jason Rumney's 2007-06-07 change worked around this bug, but
10515 didn't fix it.
10516 * systime.h (tzname, timezone): Remove no-longer-used declarations.
10517
8547b010
EZ
105182011-10-19 Eli Zaretskii <eliz@gnu.org>
10519
10520 * xdisp.c (start_display): If the character at POS is displayed
10521 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
10522 (try_window_reusing_current_matrix): If a line ends in a display
10523 vector or the next line starts in a display vector, continue
10524 redrawing the window even though the character position of
10525 start_row was reached.
8547b010
EZ
10526 (Bug#9771, part 2)
10527
4e948d15
CY
105282011-10-18 Chong Yidong <cyd@gnu.org>
10529
10530 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
10531 with nobreak-char-display too.
10532
4787455f
EZ
105332011-10-18 Eli Zaretskii <eliz@gnu.org>
10534
10535 Fix part 3 of bug#9771.
10536 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
10537 (bidi_resolve_neutral): Don't enter the expensive loop looking for
10538 non-neutral characters if the current character is a paragraph
10539 separator (a.k.a. Newline). This avoids running the same
10540 expensive loop twice, once when we consume the preceding newline
10541 and the other time when the line actually needs to be displayed.
10542 Avoid the loop when we see neutrals on the base embedding level
10543 following a character whose directionality is the same as the
10544 paragraph's. This avoids running the expensive loop when a line
10545 ends in a long sequence of neutrals, like control characters.
10546 Add assertion against STRONG_AL type. Slightly rearrange code
10547 that determines the type of a neutral given the first non-neutral
10548 that follows it.
10549 (bidi_level_of_next_char): Set next_en_pos to zero when
10550 invalidating its info.
10551
2c91f553
EZ
105522011-10-17 Eli Zaretskii <eliz@gnu.org>
10553
10554 * xdisp.c (push_display_prop): Determine whether to record string
10555 or buffer position by IT->string, not by IT->method. Allow
10556 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
10557 (move_it_vertically_backward): Don't look for character position
10558 immediately after the newline when in a continuation line.
10559 (Bug#9771, part 1)
2c91f553 10560
c7b08b0d
MR
105612011-10-15 Martin Rudalics <rudalics@gmx.at>
10562
10563 * window.c (coordinates_in_window): Rewrite and delabelize
10564 vertical border check. (Bug#5357) (Bug#9618)
10565
6b02f655
SM
105662011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
10567
10568 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
10569 errors in XSetWindowBorder (bug#9310).
10570
81d40c92
DA
105712011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
10572
10573 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
10574 avoid crash when xmalloc overrun checking is enabled.
10575
d4172c3b
EZ
105762011-10-13 Eli Zaretskii <eliz@gnu.org>
10577
10578 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
10579 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
10580 cursor motion with <left> and <right> arrow keys.
10581
10582 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
10583 some callers set that themselves.
10584
b00eea75
EZ
105852011-10-12 Eli Zaretskii <eliz@gnu.org>
10586
10587 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
10588 display string and the previous row comes from the same string and
10589 is empty. (Bug#9739) (Bug#9738)
10590
8fe012c4
SM
105912011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
10592
10593 * doc.c (get_doc_string): Encode file name (bug#9735).
10594
0074aef2
EZ
105952011-10-12 Eli Zaretskii <eliz@gnu.org>
10596
79beb178
EZ
10597 * bidi.c (bidi_level_of_next_char):
10598 * xdisp.c (get_visually_first_element): Remove old incorrect
10599 comments regarding the Unicode Line Separator character.
10600
0074aef2
EZ
10601 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
10602
6e4b3fbe
DA
106032011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
10604
10605 * alloc.c (Fgc_status): Do not access beyond zombies array
10606 boundary if nzombies > MAX_ZOMBIES.
10607 * alloc.c (dump_zombies): Add missing format specifier.
10608
0324f3af
PE
106092011-10-12 Paul Eggert <eggert@cs.ucla.edu>
10610
b5525cac
PE
10611 * xdisp.c (set_cursor_from_row): Simplify conditionals,
10612 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
10613
0324f3af
PE
10614 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
10615 Some packages use them to denote characters with modifiers.
10616
e9b5f888
AS
106172011-10-11 Andreas Schwab <schwab@linux-m68k.org>
10618
10619 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
10620 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
10621 matching a pp-number. Rename parameter var to var1.
10622
127827c0
SM
106232011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
10624
10625 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
10626
c8fd3bd0
GM
106272011-10-08 Glenn Morris <rgm@gnu.org>
10628
10629 * callint.c (Fcall_interactively): Give a more explicit error for the
10630 'c' case with a non-character input. (Bug#8479)
10631
352ec8ff
EZ
106322011-10-08 Eli Zaretskii <eliz@gnu.org>
10633
03669ccb
EZ
10634 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
10635 lines.
7061c986
EZ
10636 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
10637 lines that are hscrolled on the left.
03669ccb 10638
352ec8ff
EZ
10639 * dispnew.c (buffer_posn_from_coords): Account for a possible
10640 presence of header-line. (Bug#4426)
10641
a66cfb1c
SM
106422011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
10643
6b02f655
SM
10644 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
10645 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 10646
7c5ee88e
PE
106472011-10-07 Paul Eggert <eggert@cs.ucla.edu>
10648
10649 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
10650 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
10651 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
10652 this makes Emacs dump core during garbage collection on rare
10653 occasions. sizeof is obviously inferior to offsetof here, so
10654 stick with offsetof.
10655 (GC_POINTER_ALIGNMENT): New macro.
10656 (mark_memory): Omit 3rd (offset) arg; caller changed.
10657 Don't assume EMACS_INT alignment is the same as pointer alignment.
10658
df1bbe5b
SM
106592011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
10660
10661 * keyboard.c (read_key_sequence_remapped): New var.
10662 (read_key_sequence): Compute remapping in the right buffer.
10663 (command_loop_1): Use read_key_sequence's remapping directly.
10664
51553db6
SM
106652011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
10666
32c1fffd
SM
10667 * dired.c (file_name_completion): Don't expand file name.
10668 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
10669 before checking file name handler.
10670
51553db6
SM
10671 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
10672 they've been requested explicitly (bug#9591).
10673
b6bd1599 106742011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
10675
10676 * keymap.c (Fsingle_key_description): Use make_specified_string
10677 instead of build_string to build string from push_key_description.
10678 (Bug#5193)
10679
f701dc2a
PE
106802011-09-30 Paul Eggert <eggert@cs.ucla.edu>
10681
4222c55d
PE
10682 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
10683 This fixes a Y2038 bug on 64-bit hosts.
10684 * buffer.c (reset_buffer):
10685 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
10686 (Fclear_buffer_auto_save_failure):
10687 Use 0, not -1, to represent an unset failure time, since time_t
10688 might not be signed.
10689
f701dc2a
PE
10690 Remove dependency on glibc malloc internals.
10691 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
10692 Move back here from lisp.h, but with their new implementations.
10693 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
10694 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
10695 * charset.c (charset_table_init): New static var.
10696 (syms_of_charset): Use it instead of xmalloc. This removes a
10697 dependency on glibc malloc internals. See Eli Zaretskii's comment in
10698 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
10699 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
10700 Move back to alloc.c.
10701 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
10702 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
10703
9ceebf39
JD
107042011-09-30 Jan Djärv <jan.h.d@swipnet.se>
10705
10706 * nsterm.m (windowDidResize): Call x_set_window_size only when
10707 ns_in_resize is true. Otherwise set pixelwidth/height and
10708 call change_frame_size (Bug#9628).
10709
cb993c58
PE
107102011-09-30 Paul Eggert <eggert@cs.ucla.edu>
10711
3930c88b
PE
10712 Port --enable-checking=all to Fedora 14 x86-64.
10713 * charset.c (syms_of_charset): Also account for glibc malloc's
10714 internal overhead when calculating the initial malloc maximum.
10715
cb993c58
PE
10716 Port --enable-checking=all to Fedora 14 x86.
10717 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
10718 Move to lisp.h.
10719 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
10720 (overrun_check_realloc, overrun_check_free):
10721 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
10722 That way, xmalloc returns a properly-aligned pointer even if
10723 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
10724 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
10725 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
10726 into account when calculating the initial malloc maximum.
10727 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
10728 Move here from alloc.c, so that charset.c can use it too.
10729 Properly align; the old code wasn't right for common 32-bit hosts
10730 when configured with --enable-checking=all.
10731 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
10732 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
10733
31bed486
EZ
107342011-09-29 Eli Zaretskii <eliz@gnu.org>
10735
04c70788 10736 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
10737 use EDOM.
10738
fbcaa2f3
EZ
107392011-09-28 Eli Zaretskii <eliz@gnu.org>
10740
10741 * xdisp.c (compute_display_string_end): If there's no display
10742 string at CHARPOS, return -1.
10743
10744 * bidi.c (bidi_fetch_char): When compute_display_string_end
10745 returns a negative value, treat the character as a normal
10746 character not covered by a display string. (Bug#9624)
10747
a239d4e9
JB
107482011-09-28 Juanma Barranquero <lekktu@gmail.com>
10749
10750 * lread.c (Fread_from_string): Fix typo in docstring.
10751
88652fd5
EZ
107522011-09-27 Eli Zaretskii <eliz@gnu.org>
10753
10754 * xdisp.c (handle_invisible_prop): If invisible text ends on a
10755 newline, reseat the iterator instead of bidi-iterating there one
10756 character at a time. (Bug#9610)
32c1fffd
SM
10757 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
10758 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 10759
ed497dd4
AS
107602011-09-27 Andreas Schwab <schwab@linux-m68k.org>
10761
10762 * lread.c (readevalloop): Use correct code for NBSP.
10763 (read1): Likewise. (Bug#9608)
10764
b2bf61aa
MA
107652011-09-25 Michael Albinus <michael.albinus@gmx.de>
10766
10767 * dbusbind.c (Fdbus_register_signal): When service is not
10768 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
10769
32bbb17c
GM
107702011-09-25 Glenn Morris <rgm@gnu.org>
10771
10772 * buffer.c (truncate-lines): Doc fix.
10773
94e0933e
CY
107742011-09-24 Chong Yidong <cyd@stupidchicken.com>
10775
10776 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
10777 (Fset_window_next_buffers): Doc fix.
10778
cddde921
GM
107792011-09-24 Glenn Morris <rgm@gnu.org>
10780
10781 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
10782
1260aef1
PE
107832011-09-24 Paul Eggert <eggert@cs.ucla.edu>
10784
25b4bfa0
PE
10785 Fix minor problems found by static checking.
10786 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
10787 * indent.c (Fvertical_motion): Fix == vs = typo.
10788
e3cbd34b
EZ
107892011-09-24 Eli Zaretskii <eliz@gnu.org>
10790
a66cfb1c
SM
10791 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
10792 Default value is now t. Doc fix.
6bf7006f 10793
e3cbd34b 10794 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 10795 logic when moving up, not only when moving down. Fix the
e3cbd34b 10796 confusing name and values of the it_overshoot_expected variable;
32c1fffd 10797 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
10798
10799 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
10800 CHARPOS is covered by a display string which includes newlines.
10801 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
10802 is covered by a display string with embedded newlines.
10803
a3de0cbd
MA
108042011-09-24 Michael Albinus <michael.albinus@gmx.de>
10805
10806 * dbusbind.c (Fdbus_register_signal): Add match rule to
10807 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
10808 (Fdbus_register_method, Vdbus_registered_objects_table):
10809 Fix docstring.
a3de0cbd 10810
b260039d
JM
108112011-09-24 Jim Meyering <meyering@redhat.com>
10812
32c1fffd 10813 do not ignore write error for any output size
b260039d
JM
10814 The previous change was incomplete.
10815 While it makes emacs --batch detect the vast majority of stdout
10816 write failures, errors were still ignored whenever the output size is
10817 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
10818 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
10819 && echo FAIL: ignored write error
10820 FAIL: ignored write error
10821 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
10822 && echo FAIL: ignored write error
10823 FAIL: ignored write error
10824 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
10825
8eca8a7c
AS
108262011-09-23 Andreas Schwab <schwab@linux-m68k.org>
10827
10828 * emacs.c (Fkill_emacs): In noninteractive mode exit
10829 non-successfully if a write error occurred on stdout. (Bug#9574)
10830
3341db62
EZ
108312011-09-21 Eli Zaretskii <eliz@gnu.org>
10832
10833 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
10834 the xassert test.
10835
10836 * dispextern.h (struct it): Update the comment documenting what
10837 can it->OBJECT be.
10838
8c203dbf
EZ
108392011-09-20 Eli Zaretskii <eliz@gnu.org>
10840
10841 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
10842 a display string, extend search for cursor position to end of row.
10843 (find_row_edges): If the row ends in a newline from a display
10844 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
10845 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
10846 (Fcurrent_bidi_paragraph_direction): Fix search for previous
10847 non-empty line. Fixes confusing cursor motion with arrow keys at
10848 the beginning of a line that starts with whitespace.
8c203dbf 10849
a4824228
LMI
108502011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
10851
10852 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
10853 (bug#9493).
10854
33ed493b
CY
108552011-09-18 Chong Yidong <cyd@stupidchicken.com>
10856
10857 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
10858 boolean (Bug#9154).
10859
56cd55c8
EZ
108602011-09-18 Eli Zaretskii <eliz@gnu.org>
10861
10862 * xdisp.c (display_line): Record maximum and minimum buffer
10863 positions even if no glyphs were produced (e.g., by a zero-width
10864 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
10865 buffer positions that will be removed from the glyph row because
10866 they don't fit.
c02dcedf
EZ
10867 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
10868 column is beyond frame width: don't subtract 1 "pixel" when
10869 computing width of the stretch.
3e62b7e0
EZ
10870 (reseat_at_next_visible_line_start): Undo the change made on
10871 2011-09-17 that saved paragraph information and restored it after
10872 the call to `reseat'. (Bug#9545)
56cd55c8 10873
5ed99d36 108742011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
10875
10876 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
10877 and turn window cursor on if cleared (Bug#9415).
10878
5ed99d36 108792011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
10880
10881 * search.c (boyer_moore): Take unibyte characters from pattern
10882 literally. (Bug#9458)
10883
9bade7b2
EZ
108842011-09-18 Eli Zaretskii <eliz@gnu.org>
10885
10886 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
10887
e5e9d610
PE
108882011-09-18 Paul Eggert <eggert@cs.ucla.edu>
10889
87e4427a
PE
10890 Fix minor problem found by static checking.
10891 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
10892 initialized, to pacify gcc -Wuninitialized.
10893
e5e9d610
PE
10894 * fileio.c: Report proper errno when syscall falls.
10895 (Finsert_file_contents): Save and restore errno,
10896 so that report_file_error outputs the correct diagnostic.
10897 (Fwrite_region) [CLASH_DETECTION]: Likewise.
10898
a1674f0b
EZ
108992011-09-18 Eli Zaretskii <eliz@gnu.org>
10900
10901 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
10902
fbfb6dd4
EZ
109032011-09-17 Eli Zaretskii <eliz@gnu.org>
10904
10905 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
10906 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
10907
bb187662
EZ
109082011-09-17 Eli Zaretskii <eliz@gnu.org>
10909
1137e8b8 10910 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 10911 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
10912
10913 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
10914 (bidi_find_paragraph_start): Search back for paragraph beginning
10915 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
10916 (bidi_move_to_visually_next): Only trigger paragraph-related
10917 computations when the last character is a newline or at EOB, not
10918 just any NEUTRAL_B. (Bug#9470)
10919
bb187662
EZ
10920 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
10921 truncated lines if point is covered by a display string. (Bug#9524)
10922
2e621251
PE
109232011-09-16 Paul Eggert <eggert@cs.ucla.edu>
10924
10925 * xselect.c: Relax test for outgoing X longs (Bug#9498).
10926 (cons_to_x_long): New function.
10927 (lisp_data_to_selection_data): Use it. Correct the test for
10928 short-versus-long data; it was negated. Break out of vector
10929 loop, for efficiency, when a long datum is discovered.
10930
91a15bc6
SM
109312011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
10932
10933 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
10934
b41c3a35
EZ
109352011-09-16 Eli Zaretskii <eliz@gnu.org>
10936
10937 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
10938 GCC PR/17406) by declaring this function with external scope.
10939
7812ba2d
PE
109402011-09-15 Paul Eggert <eggert@cs.ucla.edu>
10941
10942 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
10943 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
10944
cf7edc2a
AS
109452011-09-15 Andreas Schwab <schwab@linux-m68k.org>
10946
10947 * editfns.c (Fformat): Correctly handle text properties on "%%".
10948
bd01620e
EZ
109492011-09-15 Eli Zaretskii <eliz@gnu.org>
10950
10951 * xterm.c (x_draw_composite_glyph_string_foreground):
10952 * w32term.c (x_draw_composite_glyph_string_foreground):
10953 * term.c (encode_terminal_code):
10954 * composite.c (composition_update_it, get_composition_id):
10955 * xdisp.c (get_next_display_element)
10956 (fill_composite_glyph_string): Add comments about special meaning
10957 of TAB characters in a composition.
10958
a02719a3
PE
109592011-09-15 Paul Eggert <eggert@cs.ucla.edu>
10960
10961 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
10962 This occurs when processing a multibyte format.
10963 Problem reported by Wolfgang Jenker.
a02719a3 10964
72589a3c
JB
109652011-09-15 Johan Bockgård <bojohan@gnu.org>
10966
10967 * xdisp.c (try_cursor_movement): Only check for exact match if
10968 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
10969
1c14176c
PE
109702011-09-14 Paul Eggert <eggert@cs.ucla.edu>
10971
10972 Remove unused external symbols.
10973 * dispextern.h (calc_pixel_width_or_height): Remove decl.
10974 * xdisp.c (calc_pixel_width_or_height): Now static.
10975 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
10976 * indent.c (check_display_width):
10977 * w32term.c: Fix comment to match code.
10978 * xterm.c, xterm.h (x_catching_errors): Remove.
10979
d2eea5b5
PE
109802011-09-14 Paul Eggert <eggert@cs.ucla.edu>
10981
10982 * xselect.c: Use signed conversions more consistently (Bug#9498).
10983 (selection_data_to_lisp_data): Assume incoming selection data are
10984 signed integers, not unsigned. This is to be consistent with
10985 outgoing selection data, which was modified to use signed integers
10986 in as part of the fix to Bug#9196 in response to Jan D.'s comment
10987 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
10988 expects long, not unsigned long.
10989
46888499
EZ
109902011-09-14 Eli Zaretskii <eliz@gnu.org>
10991
10992 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
10993 computation of loop end. Reported by Johan Bockgård
10994 <bojohan@gnu.org>.
10995
ef8ef9fb
CY
109962011-09-13 Chong Yidong <cyd@stupidchicken.com>
10997
10998 * frame.c (Fother_visible_frames_p): Function deleted.
10999
fa819fed
EZ
110002011-09-12 Eli Zaretskii <eliz@gnu.org>
11001
11002 * indent.c (compute_motion): Process display vector front to back
11003 rather than the other way around. (Bug#2496)
11004
2ba8e008
SM
110052011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
11006
11007 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
11008
20f53c69
CY
110092011-09-11 Chong Yidong <cyd@stupidchicken.com>
11010
11011 * minibuf.c (Fread_from_minibuffer): Doc fix.
11012
d562d7a4
EZ
110132011-09-11 Eli Zaretskii <eliz@gnu.org>
11014
11015 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
11016 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
11017
1c4d7f3d
LMI
110182011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
11019
11020 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
11021 value for non-existent files.
11022
b885bf36
EZ
110232011-09-11 Eli Zaretskii <eliz@gnu.org>
11024
11025 * fileio.c (Finsert_file_contents): If the file cannot be opened,
11026 set its "size" to -1. This will set the modtime_size field of
11027 the corresponding buffer to -1, which is what
11028 verify-visited-file-modtime expects for files that do not exist.
11029 (Bug#9139)
11030
6612f0bf
PE
110312011-09-11 Paul Eggert <eggert@cs.ucla.edu>
11032
11033 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
11034 here ...
11035 * lisp.h: ... from here. push_key_description is no longer
11036 defined in keyboard.c, so its declaration should not be in
11037 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
11038 logically belongs with push_key_description.
11039
dfb3f755
PE
110402011-09-10 Paul Eggert <eggert@cs.ucla.edu>
11041
11042 * buffer.h: Include <sys/types.h> instead of <time.h>.
11043 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
11044 Problem reported by Herbert J. Skuhra.
11045
3134906c
LMI
110462011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
11047
11048 * xml.c (parse_region): Make the parsing work for
11049 non-comment-starting XML files again (bug#9144).
11050
8d903f4e
AS
110512011-09-10 Andreas Schwab <schwab@linux-m68k.org>
11052
11053 * image.c (gif_load): Fix calculation of bottom and right corner.
11054 (Bug#9468)
11055
80ad64f4
EZ
110562011-09-10 Eli Zaretskii <eliz@gnu.org>
11057
11058 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
11059 redisplay in small windows.
11060
208a048d
EZ
110612011-09-09 Eli Zaretskii <eliz@gnu.org>
11062
11063 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
11064
9b1c252e
MR
110652011-09-08 Martin Rudalics <rudalics@gmx.at>
11066
11067 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
11068 Operate on live windows only.
11069
2949f33b
JB
110702011-09-08 Juanma Barranquero <lekktu@gmail.com>
11071
11072 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
11073
e08dcafd
EZ
110742011-09-07 Eli Zaretskii <eliz@gnu.org>
11075
11076 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
11077 only under bidi iteration.
11078
115b96bd
JD
110792011-09-07 Jan Djärv <jan.h.d@swipnet.se>
11080
11081 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
11082
c8199d0f
PE
110832011-09-06 Paul Eggert <eggert@cs.ucla.edu>
11084
11085 isnan: Fix porting problem to Solaris 10 with bundled gcc.
11086 Without this fix, the command to link temacs failed due to an
11087 undefined symbol __builtin_isnan. This is because
11088 /usr/include/iso/math_c99.h #defines isnan(x) to
11089 __builtin_isnan(x), but the bundled gcc, which identifies itself
11090 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
11091 a __builtin_isnan.
11092 * floatfns.c (isnan): #undef, and then #define to a clone of
11093 what's in data.c.
11094 (Fisnan): Always define, since it's always available now.
11095 (syms_of_floatfns): Always define isnan at the Lisp level.
11096
e39b275c 110972011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
11098
11099 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
11100
b2db44d9 111012011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 11102
f4af5137 11103 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
11104 The previous code assumed that file offsets (off_t values) fit in
11105 EMACS_INT variables, which is not true on typical 32-bit hosts.
11106 The code messed up by falsely reporting buffer overflow in cases
11107 such as (insert-file-contents "big" nil 1 2) into an empty buffer
11108 when "big" contains more than 2**29 bytes, even though this
11109 inserts just one byte and does not overflow the buffer.
11110 (Finsert_file_contents): Store file offsets as off_t
11111 values, not as EMACS_INT values. Check for overflow when
11112 converting between EMACS_INT and off_t. When checking for
11113 buffer overflow or for overlap, take the offsets into account.
11114 Don't use EMACS_INT for small values where int suffices.
11115 When checking for overlap, fix a typo: ZV was used where
11116 ZV_BYTE was intended.
11117 (Fwrite_region): Don't assume off_t fits into 'long'.
11118 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
11119
ecfc0a49
MA
111202011-09-05 Michael Albinus <michael.albinus@gmx.de>
11121
11122 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
11123
6511acf2 111242011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 11125
0999621a 11126 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
11127
11128 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 11129 (esprintf, exprintf, evxprintf): New functions.
62f19c19 11130 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 11131 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
11132 (modify_event_symbol): Do not assume that the length of
11133 name_alist_or_stem is safe to alloca and fits in int.
11134 (Fexecute_extended_command): Likewise for function name and binding.
11135 (Frecursion_depth): Wrap around reliably on integer overflow.
11136 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
11137 since some callers pass EMACS_INT values.
11138 (Fsingle_key_description): Don't crash if symbol name contains more
11139 than MAX_ALLOCA bytes.
11140 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
11141 (get_minibuffer): Arg is now EMACS_INT, not int.
11142 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 11143 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
11144 * window.h (command_loop_level, minibuf_level): Reflect API changes.
11145
2be7d702
PE
11146 * dbusbind.c (signature_cat): New function.
11147 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
11148 Do not overrun buffer; instead, report string overflow.
11149
9d1df220
PE
11150 * dispnew.c (add_window_display_history): Don't overrun buffer.
11151 Truncate instead; this is OK since it's just a log.
11152
33ef5c64
PE
11153 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
11154 even if the time zone offset is outlandishly large.
11155 Don't mishandle offset == INT_MIN.
11156
66c6fdd5
PE
11157 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
11158 when creating daemon; the previous buffer-overflow check was incorrect.
11159
d749b01b
PE
11160 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
11161 which has the guts of the old verror function.
11162
b5cd1905
PE
11163 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
11164 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
11165
6e1a67fb
PE
11166 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
11167 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 11168 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 11169 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
11170 length of string rather than counting it via multiple sprintfs;
11171 that's simpler and more reliable.
c21721cc
PE
11172 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
11173 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
11174 sprintf, in case result does not fit in int.
11175
c57b67fc
PE
11176 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
11177 (fontset_from_font): Print it.
11178
8a401434
PE
11179 * frame.c (tty_frame_count): Now printmax_t, not int.
11180 (make_terminal_frame, set_term_frame_name): Print it.
11181 (x_report_frame_params): In X, window IDs are unsigned long,
11182 not signed long, so print them as unsigned.
11183 (validate_x_resource_name): Check for implausibly long names,
11184 and don't assume name length fits in 'int'.
11185 (x_get_resource_string): Don't blindly alloca invocation name;
11186 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
11187 not fit in int.
11188
6e1a67fb
PE
11189 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
11190 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
11191 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
11192
0df02bf3
PE
11193 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
11194 Use esprintf, not sprintf, in case result does not fit in int.
11195
48e30793
PE
11196 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
11197 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
11198 it as a large positive number.
11199 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
11200 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
11201
a66ff6d8
PE
11202 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
11203 in case result does not fit in int.
11204
aca216ff
PE
11205 * print.c (float_to_string): Detect width overflow more reliably.
11206 (print_object): Make sprintf buffer a bit bigger, to avoid potential
11207 buffer overrun. Don't assume list length fits in 'int'. Treat
11208 print length of 0 as 0, not as infinity; to be consistent with other
11209 uses of print length in this function. Don't overflow print length
11210 index. Don't assume hash table size fits in 'long', or that
11211 vectorlike size fits in 'unsigned long'.
11212
31c286f7
PE
11213 * process.c (make_process): Use printmax_t, not int, to format
11214 process-name gensyms.
11215
55e5faa1
PE
11216 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
11217
80f2e268
PE
11218 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
11219 to avoid potential buffer overrun.
11220
670741ab
PE
11221 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
11222 if X resource line is longer than 512 bytes.
11223
b7163a50
PE
11224 * xfns.c (x_window): Make sprintf buffer a bit bigger
11225 to avoid potential buffer overrun.
11226
ae58ff1f
PE
11227 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
11228
c43c8a6a
PE
11229 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
11230
3f8236f4
PE
112312011-09-04 Paul Eggert <eggert@cs.ucla.edu>
11232
53e9fe90 11233 Integer overflow fixes for scrolling, etc.
6511acf2
PE
11234 Without these, Emacs silently mishandles large integers sometimes.
11235 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
11236 it were "C-u 1 M-x recenter" on a typical 64-bit host.
11237
6511acf2
PE
11238 * xdisp.c (try_window_id): Check Emacs fixnum range before
11239 converting to 'int'.
806add1d 11240
6511acf2 11241 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
11242 Check that an Emacs fixnum is in range before assigning it to 'int'.
11243 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
11244 values converted from Emacs fixnums.
11245 (Frecenter): Don't wrap around a line count if it is out of 'int'
11246 range; instead, treat it as an extreme value.
11247 (Fset_window_configuration, compare_window_configurations):
11248 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
11249
6511acf2
PE
11250 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
11251 that can exceed INT_MAX. Check that EMACS_INT value is in range
11252 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
11253 (match_limit): Don't assume that a fixnum can fit in 'int'.
11254
6511acf2 11255 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
11256 exceed INT_MAX.
11257
6511acf2 11258 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
11259 (Fvertical_motion): Don't wrap around LINES values that don't fit
11260 in 'int'. Instead, treat them as extreme values. This is good
11261 enough for windows, which can't have more than INT_MAX lines anyway.
11262
fcb901a7
LMI
112632011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
11264
0f2f6b6d
LMI
11265 * Require libxml/parser.h to avoid compilation warning.
11266
fcb901a7
LMI
11267 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
11268
11269 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
11270 since this reportedly can destroy thread storage.
11271
6e20a0d4
CY
112722011-08-30 Chong Yidong <cyd@stupidchicken.com>
11273
11274 * syntax.c (find_defun_start): Update all cache variables if
11275 exiting early (Bug#9401).
11276
148ae00e
EZ
112772011-08-30 Eli Zaretskii <eliz@gnu.org>
11278
f6cfbd8f
EZ
11279 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
11280
148ae00e
EZ
11281 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
11282 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
11283 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
11284
11285 * term.c (tty_append_glyph): New function.
11286 (produce_stretch_glyph): Static function and its prototype deleted.
11287
a66cfb1c
SM
11288 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
11289 Add prototypes.
148ae00e 11290
c4a07a4c
PE
112912011-08-29 Paul Eggert <eggert@cs.ucla.edu>
11292
11293 * image.c (parse_image_spec): Check for nonnegative, not for positive,
11294 when checking :margin (Bug#9390).
11295 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 11296 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
11297 so that the name doesn't mislead. All uses changed.
11298
6bc8cd65
JB
112992011-08-28 Johan Bockgård <bojohan@gnu.org>
11300
11301 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
11302 set_tty_hooks.
11303
dca4927e
EZ
113042011-08-27 Eli Zaretskii <eliz@gnu.org>
11305
11306 * xdisp.c (move_it_to): Don't bail out early when reaching
11307 position beyond to_charpos, if we are scanning backwards.
11308 (move_it_vertically_backward): When DY == 0, make sure we get to
11309 the first character in the line after the newline.
11310
f2cad773
PE
113112011-08-27 Paul Eggert <eggert@cs.ucla.edu>
11312
11313 * ccl.c: Improve and simplify overflow checking (Bug#9196).
11314 (ccl_driver): Do not generate an out-of-range pointer.
11315 (Fccl_execute_on_string): Remove unnecessary check for
11316 integer overflow, noted by Stefan Monnier in
11317 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
11318 Remove a FIXME that didn't need fixing.
11319 Simplify the newly-introduced buffer reallocation code.
11320
0cae2cdb
JB
113212011-08-27 Juanma Barranquero <lekktu@gmail.com>
11322
11323 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
11324
5fc295a4 113252011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 11326
70c60eb2 11327 Integer and memory overflow issues (Bug#9196).
726e0ab1 11328
d31850da
PE
11329 * doc.c (get_doc_string): Rework so that
11330 get_doc_string_buffer_size is the actual buffer size, rather than
11331 being 1 less than the actual buffer size; this makes xpalloc more
11332 convenient.
11333
a69fbedb
PE
11334 * image.c (x_allocate_bitmap_record, cache_image):
11335 * xselect.c (Fx_register_dnd_atom):
11336 Simplify previous changes by using xpalloc.
11337
fe5c5d37
PE
11338 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
11339 since either will do and ptrdiff_t is convenient with xpalloc.
11340
0065d054
PE
11341 * charset.c (charset_table_size)
11342 (struct charset_sort_data.priority): Now ptrdiff_t.
11343 (charset_compare): Don't overflow if priorities differ greatly.
11344 (Fsort_charsets): Don't assume list length fits in int.
11345 Check for size-calculation overflow when allocating sort data.
11346 (syms_of_charset): Allocate an initial charset table that is
11347 just under 64 KiB, to avoid problems with glibc malloc and mmap.
11348
11349 * cmds.c (internal_self_insert): Check for size-calculation overflow.
11350
11351 * composite.h (struct composition.glyph_len): Now int, not unsigned.
11352 The actual value is always <= INT_MAX, and leaving it unsigned made
11353 overflow checking harder.
11354
11355 * dispextern.h (struct glyph_matrix.rows_allocated)
11356 (struct face_cache.size): Now ptrdiff_t, for convenience in use
11357 with xpalloc. The values are still always <= INT_MAX.
11358
11359 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
11360
11361 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
11362 (SAFE_NALLOCA): New macro.
11363
11364 * region-cache.c (struct boundary.pos, find_cache_boundary)
11365 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
11366 (set_cache_region, invalidate_region_cache)
11367 (revalidate_region_cache, know_region_cache, region_cache_forward)
11368 (region_cache_backward, pp_cache):
11369 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
11370 so that ptrdiff_t * can be passed to xpalloc.
11371 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
11372 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
11373 (pp_cache): Don't assume cache_len fits in int.
11374 * region-cache.h: Adjust extern decls to match.
11375
11376 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
11377 EMACS_INT, since either will do, for xpalloc.
11378
11379 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
11380 (xnmalloc, xnrealloc, xpalloc): New functions.
11381
726e0ab1
PE
11382 * bidi.c (bidi_shelve_header_size): New constant.
11383 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
11384 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
11385
51f30bc5 11386 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
11387 * buffer.c (overlays_at, overlays_in, record_overlay_string)
11388 (overlay_strings):
11389 Don't update size of array until after memory allocation succeeds,
11390 because xmalloc/xrealloc may not return.
0065d054
PE
11391 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
11392 now that we have proper integer overflow checking.
11393 (record_overlay_string, overlay_strings): Catch overflows when
11394 calculating size of overlay_str_buf.
726e0ab1 11395
0065d054
PE
11396 * callproc.c (Fcall_process): Check for size overflow when
11397 calculating size of args2.
11398 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
11399 Normally we prefer signed values, but sticking with ptrdiff_t would
11400 require adding more-complicated checks.
726e0ab1
PE
11401
11402 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
11403 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
11404 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 11405 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
11406
11407 * character.c (Fstring): Check for size-calculation overflow.
11408
11409 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
11410 unnecessary integer overflow. Check for size overflow.
11411 (encode_coding_object): Don't update size until xmalloc succeeds.
11412
11413 * composite.c (get_composition_id): Check for overflow in glyph
11414 length calculations.
11415
11416 Integer and memory overflow fixes for display code.
11417 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
11418 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
11419 (scrolling_window): Check for overflow in size calculations.
11420 (line_draw_cost, realloc_glyph_pool, add_row_entry):
11421 Don't assume glyph table len fits in int.
11422 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
11423 (row_table_size): Now ptrdiff_t, not int.
11424 (scrolling_window): Avoid overflow in size calculations.
11425 Don't update size until allocation succeeds.
11426 * fns.c (concat): Check for overflow in size calculations.
11427 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
11428 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
11429 (NEXT_ALMOST_PRIME_LIMIT): New constant.
11430
11431 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
11432 (get_doc_string): Check for size calculation overflow.
11433 Don't update size until allocation succeeds.
11434 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
11435 EMACS_INT, where ptrdiff_t will do.
11436 (Fsubstitute_command_keys): Check for string overflow.
11437
11438 * editfns.c (set_time_zone_rule): Don't assume environment length
11439 fits in int.
11440 (message_length): Now ptrdiff_t, not int.
11441 (Fmessage_box): Don't update size until allocation succeeds.
11442 Don't assume message length fits in int.
11443 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
11444
0065d054
PE
11445 * emacs.c (main): Do not reallocate argv, since there is a null at
11446 the end that can be overwritten, and this way there's no need to
11447 worry about size-calculation overflow.
11448 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
11449
11450 * eval.c (init_eval_once, grow_specpdl): Don't update size until
11451 alloc succeeds.
11452 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
11453
11454 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
11455 (x_set_scroll_bar_width, x_figure_window_size):
11456 Check for integer overflow.
11457 (x_set_alpha): Do not assume XINT fits in int.
11458
11459 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
11460 This is for the members text_lines, text_cols, total_lines, total_cols,
11461 where the system imposes an 'int' limit.
11462
11463 * fringe.c (Fdefine_fringe_bitmap):
11464 Don't update size until alloc works.
11465
11466 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
11467 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
11468
11469 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
11470 Check for size-calculation overflow.
11471 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
11472 do, as we prefer signed integers.
11473 (id_to_widget.max_size, id_to_widget.used)
11474 (xg_store_widget_in_map, xg_remove_widget_from_map)
11475 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
11476 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
11477 Use and return ptrdiff_t, not int.
11478 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
11479 * gtkutil.h: Change prototypes to match the above.
11480
11481 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
11482 are duplicate now that they've been promoted to lisp.h.
11483 (x_allocate_bitmap_record, x_alloc_image_color)
11484 (make_image_cache, cache_image, xpm_load):
11485 Don't update size until alloc is done.
11486 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
11487 (x_detect_edges):
3256efce 11488 Check for size calculation overflow.
726e0ab1
PE
11489 (ct_colors_allocated_max): New constant.
11490 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
11491 overflow.
3256efce 11492
726e0ab1
PE
11493 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
11494 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
11495 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
11496 Use ptrdiff_t, not int, to count maps.
11497 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
11498 calculations. Don't update size until allocation succeeds.
11499 Redo calculations to avoid overflow.
726e0ab1
PE
11500 * keyboard.h: Change prototypes to match the above.
11501
11502 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
11503 to count maps.
11504 (current_minor_maps): Check for size calculation overflow.
11505 * keymap.h: Change prototypes to match the above.
11506
11507 * lread.c (read1, init_obarray): Don't update size until alloc done.
11508
11509 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
11510 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
11511
726e0ab1
PE
11512 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
11513 Now ptrdiff_t, not int.
11514 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
11515 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
11516
11517 * process.c (Fnetwork_interface_list): Check for overflow
11518 in size calculation.
11519
11520 * region-cache.c (move_cache_gap): Check for size calculation overflow.
11521
11522 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
11523 overflow. Don't bother calling xmalloc when xrealloc will do.
11524
11525 * search.c (Freplace_match): Check for size calculation overflow.
11526 (Fset_match_data): Don't assume list lengths fit in 'int'.
11527
11528 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
11529 for command line length. Do not attempt to address one before the
11530 beginning of an array, as that's not portable.
11531
11532 * term.c (max_frame_lines): Remove; unused.
11533 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
11534 not int.
11535 (encode_terminal_code, calculate_costs): Check for size
11536 calculation overflow.
11537 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
11538 table lengths and related sizes. Don't update size until alloc
11539 done. Redo calculations to avoid overflow.
11540 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
11541
11542 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
11543 subtracting pointers.
11544 (gobble_line): Check for overflow more carefully. Don't update size
11545 until alloc done.
11546
11547 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
11548 Don't update size until alloc done.
11549 Redo size calculations to avoid overflow.
11550 Check for size calculation overflow.
0065d054 11551 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
11552
11553 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
11554 Use ptrdiff_t, not int, for sizes.
11555 (store_mode_line_noprop_char): Don't update size until alloc done.
11556
0065d054
PE
11557 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
11558 Use ptrdiff_t, not int, for sizes.
11559 (Finternal_make_lisp_face, cache_face):
11560 Check for size calculation overflow.
11561 (cache_face): Treat size calculation overflows as if they were
11562 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
11563
11564 * xfns.c (x_encode_text, x_set_name_internal)
11565 (Fx_change_window_property): Use ptrdiff_t, not int, to count
11566 sizes, since they can exceed INT_MAX in size. Check for size
11567 calculation overflow.
11568
0065d054
PE
11569 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
11570 (xg_select): Check for size calculation overflow.
726e0ab1
PE
11571 Don't update size until alloc done.
11572
0065d054 11573 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 11574 as sprintf is limited to int lengths.
1d526e2f 11575
252c5ee1
PE
11576 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
11577 (X_LONG_MIN): New macros.
864d7ce7
PE
11578 Use them to make the following changes clearer.
11579 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
11580 This change doesn't affect the value now, but it may help remind
11581 future maintainers not to raise the value too much later.
11582 (SELECTION_QUANTUM): Remove, replacing with ...
11583 (selection_quantum): ... new function, which avoids overflow.
11584 All uses changed.
11585 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
11586 assumption that selection length fits in 'int'.
11587 (x_reply_selection_request, x_handle_selection_request)
11588 (x_get_window_property, receive_incremental_selection)
11589 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
11590 (lisp_data_to_selection_data, clean_local_selection_data):
11591 Use ptrdiff_t, not int, to record length of selection.
11592 (x_reply_selection_request, x_get_window_property)
11593 (receive_incremental_selection, x_property_data_to_lisp):
11594 Redo calculations to avoid overflow.
11595 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 11596 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
11597 something.
11598 (x_get_window_property, receive_incremental_selection)
11599 (lisp_data_to_selection_data, x_property_data_to_lisp):
11600 Check for size-calculation overflow.
11601 (x_get_window_property, receive_incremental_selection)
11602 (lisp_data_to_selection_data, Fx_register_dnd_atom):
11603 Don't store size until memory allocation succeeds.
11604 (x_get_window_property): Plug memory leak on memory exhaustion.
11605 Don't double-block input; malloc is safe here. Don't assume 2**34
11606 - 4 fits in unsigned long. Add an xassert to check
11607 XGetWindowProperty overflow. Be more careful about overflow
11608 calculations, and distinguish size from memory overflow better.
11609 (receive_incremental_selection): When tracing, don't assume
11610 unsigned int is less than INT_MAX.
11611 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
11612 harmful) conversions of unsigned short to int.
11613 (lisp_data_to_selection_data): Don't assume that integers
11614 in the range -65535 through -1 fit in an X unsigned short.
11615 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
11616 result parameters unless successful. Rely on cons_to_unsigned
11617 to report problems with elements; the old code wasn't right anyway.
11618 (x_check_property_data): Check for int overflow; we cannot use
11619 a wider type due to X limits.
11620 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
11621
726e0ab1 11622 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 11623
0065d054
PE
11624 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
11625 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
11626 (x_color_cells): Don't store size until memory allocation succeeds.
11627 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 11628 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
11629 (x_term_init): Don't assume length fits in int (sprintf is limited
11630 to int size).
bc18e09d 11631
ebfa62c0
PE
11632 Use ptrdiff_t for composition IDs.
11633 * character.c (lisp_string_width):
11634 * composite.c (composition_table_size, n_compositions)
11635 (get_composition_id, composition_gstring_from_id):
11636 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
11637 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
11638 * window.c (Frecenter):
11639 Use ptrdiff_t, not int, for composition IDs.
11640 * composite.c (get_composition_id): Check for integer overflow.
11641 * composite.h: Adjust prototypes to match the above changes.
11642
d3411f89
PE
11643 Use ptrdiff_t for hash table indexes.
11644 * category.c (hash_get_category_set):
11645 * ccl.c (ccl_driver):
11646 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
11647 * coding.c (coding_system_charset_list, detect_coding_system):
11648 * coding.h (struct coding_system.id):
11649 * composite.c (get_composition_id, gstring_lookup_cache):
11650 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
11651 * image.c (xpm_get_color_table_h):
11652 * lisp.h (hash_lookup, hash_put):
11653 * minibuf.c (Ftest_completion):
11654 Use ptrdiff_t for hash table indexes, not int (which is too
11655 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
11656 32-bit --with-wide-int hosts).
11657
e097a6fa
PE
11658 * charset.c (Fdefine_charset_internal): Check for integer overflow.
11659 Add a FIXME comment about memory leaks.
11660 (syms_of_charset): Don't assume xmalloc returns.
11661
5637687f
PE
11662 Don't assume that stated character widths fit in int.
11663 * character.c (Fchar_width, c_string_width, lisp_string_width):
11664 * character.h (CHAR_WIDTH):
11665 * indent.c (MULTIBYTE_BYTES_WIDTH):
11666 Use sanitize_char_width to avoid undefined and/or bad behavior
11667 with outlandish widths.
a66cfb1c 11668 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
11669 now that we have two such functions. All uses changed.
11670 (sanitize_char_width): New inline function.
11671
a2271ba2
PE
11672 Don't assume that tab-width fits in int.
11673 * character.h (sanitize_width): New inline function.
11674 (SANE_TAB_WIDTH): New macro.
11675 (ASCII_CHAR_WIDTH): Use it.
11676 * indent.c (sane_tab_width): Remove. All uses replaced by
11677 SANE_TAB_WIDTH (current_buffer).
11678 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
11679
18c52557
PE
11680 * fileio.c: Integer overflow issues with file modes.
11681 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
11682
caeeedc1
PE
11683 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
11684 Remove unreachable code.
11685 (read_hex, load_charset_map_from_file): Check for integer overflow.
11686
6df6ae42 11687 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
11688 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
11689 (x_send_scroll_bar_event): Likewise. Check that the size does not
11690 exceed limits imposed by XClientMessageEvent, as well as the usual
11691 ptrdiff_t and size_t limits.
11692
b13995db
PE
11693 * keyboard.c: Overflow, signedness and related fixes.
11694 (make_lispy_movement): Use same integer type in forward decl
11695 that is used in the definition.
11696 (read_key_sequence, keyremap_step):
11697 Change bufsize argument back to int, undoing my 2011-03-30 change.
11698 We prefer signed types, and int is wide enough here.
11699 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
11700 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
11701 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
11702 length, not size_t. Use ptrdiff_t for index, not int.
11703 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
11704 possibility of integer overflow.
11705
13464394
PE
11706 Overflow, signedness and related fixes for images.
11707
11708 * dispextern.h (struct it.stack[0].u.image.image_id)
11709 (struct_it.image_id, struct image.id, struct image_cache.size)
11710 (struct image_cache.used, struct image_cache.ref_count):
11711 * gtkutil.c (update_frame_tool_bar):
11712 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
11713 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
11714 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
11715 * nsmenu.m (update_frame_tool_bar):
11716 * xdisp.c (calc_pixel_width_or_height):
11717 * xfns.c (image_cache_refcount):
11718 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
11719 on typical 64-bit hosts.
11720
11721 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
11722 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
11723 Omit unnecessary casts to int.
11724 (parse_image_spec): Check that integers fall into 'int' range
11725 when the callers expect that.
11726 (image_ascent): Redo ascent calculation to avoid int overflow.
11727 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
11728 (lookup_image): Remove unnecessary tests.
11729 (xbm_image_p): Locals are now of int, not EMACS_INT,
11730 since parse_image_check makes sure they fit into int.
11731 (png_load, gif_load, svg_load_image):
11732 Prefer int to unsigned where either will do.
11733 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
11734 old tiff_error_handler and tiff_warning_handler.
11735 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
11736 stack buffer overflows. It uses only the features of vsnprintf
11737 that are common to both POSIX and native Microsoft.
11738 (tiff_error_handler, tiff_warning_handler): Use it.
11739 (tiff_load, gif_load, imagemagick_load_image):
11740 Don't assume :index value fits in 'int'.
11741 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
11742 (imagemagick_load_image): Check that crop parameters fit into
11743 the integer types that MagickCropImage accepts. Don't assume
11744 Vimagemagick_render_type has a nonnegative value. Don't assume
11745 size_t fits in 'long'.
11746 (gs_load): Use printmax_t to print the widest integers possible.
11747 Check for integer overflow when computing image height and width.
11748
c11821d4
EZ
117492011-08-26 Eli Zaretskii <eliz@gnu.org>
11750
11751 * xdisp.c (redisplay_window): Don't force window start if point
11752 will be invisible in the resulting window. (Bug#9324)
11753
0c95fcf7
EZ
117542011-08-25 Eli Zaretskii <eliz@gnu.org>
11755
11756 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
11757 the display spec is of the form `(space ...)'.
11758 (handle_display_spec): Return the value returned by
11759 handle_single_display_spec, not just 1 or zero.
11760 (handle_single_display_spec): If the display spec is of the form
11761 `(space ...)', and specifies display in the text area, return 2
11762 rather than 1.
fee65a97 11763 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
11764 accurately, and prefer exact match for point under bidi.
11765 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
11766
11767 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
11768 into disp_prop; all users changed.
11769
11770 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
11771 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
11772 for the text covered by the display property.
11773
e4ed06f1
CY
117742011-08-25 Chong Yidong <cyd@stupidchicken.com>
11775
11776 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
11777 Change return value to nil.
11778 (Frecord_buffer): Delete unused function.
11779
f67cdd7f
EZ
117802011-08-24 Eli Zaretskii <eliz@gnu.org>
11781
5980d4c6
EZ
11782 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
11783 buffers, return left-to-right.
8610fe8b
EZ
11784 (set_cursor_from_row): Consider candidate row a win if its glyph
11785 represents a newline and point is on that newline. Fixes cursor
11786 positioning on the newline at EOL of R2L text within L2R
11787 paragraph, and vice versa.
11788 (try_cursor_movement): Check continued rows, in addition to
11789 continuation rows. Fixes unwarranted scroll when point enters a
11790 continued line of R2L text within an L2R paragraph, or vice versa.
11791 (cursor_row_p): Consider the case of point being equal to
11792 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
11793 from the end of a short line to the beginning of a continued line
11794 of R2L text within L2R paragraph.
11795 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
11796 composed characters.
5980d4c6 11797
f67cdd7f
EZ
11798 * bidi.c (bidi_check_type): Use xassert.
11799 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
11800 members.
11801
bca633fb
EZ
118022011-08-23 Eli Zaretskii <eliz@gnu.org>
11803
11804 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
11805 a character.
11806
4a5885a7
CY
118072011-08-23 Chong Yidong <cyd@stupidchicken.com>
11808
11809 * nsfont.m (ns_otf_to_script): Fix typo.
11810
0902a04e
KH
118112011-08-22 Kenichi Handa <handa@m17n.org>
11812
11813 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
11814 extra slot even if the purpose is char-code-property-table.
11815
1a2e6670
EZ
118162011-08-23 Eli Zaretskii <eliz@gnu.org>
11817
8ddde651
EZ
11818 * xdisp.c (redisplay_window): When computing centering_position,
11819 account for the height of the header line. (Bug#8874)
11820
425cc014
EZ
11821 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
11822 instead of CHAR_TO_BYTE. Fixes a crash when a completion
11823 candidate is selected by the mouse, and that candidate has a
11824 composed character under the mouse.
11825
1a2e6670
EZ
11826 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
11827 coordinates reported by pos-visible-in-window-p for a composed
11828 character in column zero.
11829
8b76d6f8
SM
118302011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
11831
11832 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
11833
dac347dd
EZ
118342011-08-22 Eli Zaretskii <eliz@gnu.org>
11835
11836 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
11837 consider it a hit if to_charpos is anywhere in the range of the
11838 composed buffer positions.
11839
e013fb34
CY
118402011-08-22 Chong Yidong <cyd@stupidchicken.com>
11841
11842 * image.c (gif_load): Don't assume that each subimage has the same
11843 dimensions as the base image. Handle disposal method that is
11844 "undefined" by the gif spec (Bug#9335).
11845
bd1ba3e8
CY
118462011-08-20 Chong Yidong <cyd@stupidchicken.com>
11847
11848 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 11849 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 11850
54a1215b
EZ
118512011-08-19 Eli Zaretskii <eliz@gnu.org>
11852
823564e5
EZ
11853 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
11854 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
11855 from an Org mode buffer to a Speedbar frame.
11856
54a1215b
EZ
11857 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
11858 a composition, take its buffer position from IT->cmp_it.charpos.
11859 Fixes cursor positioning at the beginning of a line that begins
11860 with a composed character.
11861
9778ebcc
EZ
118622011-08-18 Eli Zaretskii <eliz@gnu.org>
11863
0be6ee06
EZ
11864 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
11865 character bidirectional type, use STRONG_L instead. Fixes crashes
11866 in a buffer produced by `describe-categories'.
11867
9778ebcc
EZ
11868 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
11869 members before the level stack, so they would be saved and
11870 restored when copying iterator state. Fixes incorrect reordering
11871 around TABs covered by display properties.
11872
156bffbe
AS
118732011-08-18 Andreas Schwab <schwab@linux-m68k.org>
11874
6b02f655 11875 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 11876
72ad093b
CY
118772011-08-17 Chong Yidong <cyd@stupidchicken.com>
11878
11879 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
11880 (internal_condition_case_2, internal_condition_case_n):
11881 Remove unnecessary aborts (Bug#9081).
72ad093b 11882
35774242
EZ
118832011-08-17 Eli Zaretskii <eliz@gnu.org>
11884
11885 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
11886 has no `load' handler, try opening the file locally. (Bug#9311)
11887
db76dd85
KB
118882011-08-16 Ken Brown <kbrown@cornell.edu>
11889
11890 * gmalloc.c: Expand comment.
11891
b215eee5
EZ
118922011-08-16 Eli Zaretskii <eliz@gnu.org>
11893
11894 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
11895 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
11896
a4579d33
KB
118972011-08-16 Ken Brown <kbrown@cornell.edu>
11898
11899 Fix memory allocation problems in Cygwin build (Bug#9273).
11900
11901 * unexcw.c ( __malloc_initialized): Declare external variable.
11902 (fixup_executable): Force the dumped emacs to reinitialize malloc.
11903
8b76d6f8
SM
11904 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
11905 New variables.
a4579d33
KB
11906 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
11907 dumped emacs.
11908 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
11909 in the static heap.
11910 [CYGWIN] (special_realloc): New function.
11911 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
11912 requests to realloc storage in the static heap.
11913
3ebec551
PE
119142011-08-15 Paul Eggert <eggert@cs.ucla.edu>
11915
11916 * bidi.c (bidi_initialize): Remove unused local.
11917
9fd8be00
EZ
119182011-08-15 Eli Zaretskii <eliz@gnu.org>
11919
6b02f655
SM
11920 * bidimirror.h:
11921 * biditype.h: Remove file.
11922 * makefile.w32-in ($(BLD)/bidi.$(O)):
11923 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
11924
11925 * dispextern.h: Fix a typo in the comment to bidi_type_t.
11926
11927 * chartab.c: Improve commentary for the uniprop_table API.
11928
32413314
EZ
11929 * bidi.c (bidi_paragraph_init): Support zero value of
11930 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
11931 (bidi_initialize): Use uniprop_table instead of including
11932 biditype.h and bidimirror.h.
32413314 11933
9fd8be00
EZ
11934 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
11935 coordinates of the iterator when restoring from ppos_it.
11936 (Bug#9296)
11937
5cf2b69b
KH
119382011-08-14 Kenichi Handa <handa@m17n.org>
11939
11940 * process.c (create_process): Call setup_process_coding_systems
72ad093b 11941 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 11942
daf17d00
EZ
119432011-08-14 Eli Zaretskii <eliz@gnu.org>
11944
11945 * xdisp.c (move_it_in_display_line_to): Don't invoke
11946 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
11947 ppos_it. Fixes vertical cursor motion when line beginning is
11948 covered by an image. (Bug#9296)
11949
08e3161a
JD
119502011-08-14 Jan Djärv <jan.h.d@swipnet.se>
11951
11952 * nsterm.h (ns_run_ascript): Declare.
11953 (NSAPP_DATA2_RUNASSCRIPT): Define.
11954
11955 * nsfns.m (as_script, as_result, as_status): New static variables.
11956 (ns_run_ascript): New function.
5e617bc2 11957 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
11958 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
11959 the event loop. Get status from as_status (Bug#7276).
11960
11961 * nsterm.m (sendEvent): If event is NSApplicationDefined and
11962 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
11963 the event loop (Bug#7276).
11964
a3720aa2
AS
119652011-08-14 Andreas Schwab <schwab@linux-m68k.org>
11966
11967 * gnutls.c (QCgnutls_bootprop_priority)
11968 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
11969 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
11970 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
11971 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
11972 (QCgnutls_bootprop_verify_hostname_error)
11973 (QCgnutls_bootprop_callbacks_verify): Rename from
11974 Qgnutls_bootprop_..., all uses changed.
11975
11976 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
11977 uses changed.
11978
0a0d27fb
PE
119792011-08-14 Paul Eggert <eggert@cs.ucla.edu>
11980
19d5c50c
PE
11981 * xfaces.c (Qframe_set_background_mode): Now static.
11982 * dispextern.h (Qframe_set_background_mode): Remove decl.
11983
0a0d27fb
PE
11984 * process.c (Fnetwork_interface_info): Declare local only if needed.
11985
377538cb
JD
119862011-08-13 Jan Djärv <jan.h.d@swipnet.se>
11987
11988 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
11989 (Fnetwork_interface_list): Allocate in increments of bytes instead
11990 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
11991 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
11992 sockaddr.
11993 (struct ifflag_def): notrailers is smart on OSX.
11994 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
11995 Get hardware address with getifaddrs if available.
11996
08fff70c
EZ
119972011-08-12 Eli Zaretskii <eliz@gnu.org>
11998
11999 * xdisp.c (iterate_out_of_display_property): xassert that
12000 IT->position is set to within IT->object's boundaries. Break from
12001 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
12002 when IT->position is set up wrongly due to some bug.
12003 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
12004 (push_display_prop): Allow GET_FROM_STRING as IT->method on
12005 entry. Force push_it to save on the stack the current
12006 buffer/string position, to be restored by pop_it. Fix flags in
12007 the iterator structure wrt the object coming from a display
12008 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
12009 properties. (Bug#9284)
12010
7be1c708 120112011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 12012
7be1c708
CY
12013 * fontset.c (fontset_get_font_group): Add proper type checks.
12014 (Bug#9172)
aac0c6e3 12015
7be1c708 120162011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 12017
7be1c708
CY
12018 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
12019 and LC_VERSION_MIN_MACOSX.
12020 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
12021 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 12022
97bb72a6
EZ
120232011-08-08 Eli Zaretskii <eliz@gnu.org>
12024
12025 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
12026 no-display-properties-and-no-overlays under bidi display.
12027 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 12028 properties and overlays.
97bb72a6 12029
d5617611
CY
120302011-08-08 Chong Yidong <cyd@stupidchicken.com>
12031
37e11a63
CY
12032 * editfns.c (Fset_time_zone_rule): Document relationship with the
12033 setenv function.
12034
d5617611
CY
12035 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
12036 the font entity extracted from the cache (Bug#8109).
12037
58872834
CY
120382011-08-07 Chong Yidong <cyd@stupidchicken.com>
12039
12040 * composite.c (autocmp_chars): Don't reset point. That is done by
12041 restore_point_unwind (Bug#5984).
12042
75bfc667
JL
120432011-08-07 Juri Linkov <juri@jurta.org>
12044
12045 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
12046 to show the arg `TIME' instead of `TIMEVAL'.
12047
d1410150
EZ
120482011-08-06 Eli Zaretskii <eliz@gnu.org>
12049
12050 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
12051 display property strides EOL and includes a newline, as in
12052 longlines-mode. (Bug#9254)
75b771e4
EZ
12053 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
12054 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
12055
12056 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
12057 is non-zero, even if the data buffer is NULL. Fixes a crash in
12058 vertical-motion with longlines-mode. (Bug#9254)
12059
35928349
EZ
120602011-08-05 Eli Zaretskii <eliz@gnu.org>
12061
ec7cc85b
EZ
12062 * bidi.c <bidi_cache_total_alloc>: Now static.
12063 (bidi_initialize): Initialize bidi_cache_total_alloc.
12064
8b76d6f8 12065 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
12066 cache. (Bug#9221)
12067
12068 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
12069 amount allocated this far in `bidi_cache_total_alloc'.
12070 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
12071 non-zero, only free the data buffer without restoring the cache
12072 contents. All callers changed.
12073
12074 * dispextern.h (bidi_unshelve_cache): Update prototype.
12075
12076 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
12077 (move_it_in_display_line, move_it_to)
12078 (move_it_vertically_backward, move_it_by_lines): Replace the call
12079 to xfree to an equivalent call to bidi_unshelve_cache.
12080 (move_it_in_display_line_to): Fix logic of returning
412b6358 12081 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 12082
e2e2423b
EZ
120832011-08-05 Eli Zaretskii <eliz@gnu.org>
12084
12085 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
12086 came from a string character with a `cursor' property. (Bug#9229)
12087
ae9e757a
JD
120882011-08-04 Jan Djärv <jan.h.d@swipnet.se>
12089
12090 * Makefile.in (LIB_PTHREAD): New variable.
12091 (LIBES): Add LIB_PTHREAD (Bug#9216).
12092
12093 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
12094 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
12095
213bd7f2
AS
120962011-08-04 Andreas Schwab <schwab@linux-m68k.org>
12097
6b02f655 12098 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 12099
99aaf75f
JD
121002011-08-04 Jan Djärv <jan.h.d@swipnet.se>
12101
12102 * xterm.c (x_find_topmost_parent): New function.
12103 (x_set_frame_alpha): Find topmost parent window with
12104 x_find_topmost_parent and set the property there also (bug#9181).
12105 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
12106
c74e9d86
PE
121072011-08-04 Paul Eggert <eggert@cs.ucla.edu>
12108
12109 * callproc.c (Fcall_process): Avoid vfork clobbering
12110 the local vars buffer, coding_systems, current_dir.
12111
640c8776
SM
121122011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
12113
12114 * keymap.c (Fmake_composed_keymap): Move to subr.el.
12115
f26d0e4c
PE
121162011-08-03 Paul Eggert <eggert@cs.ucla.edu>
12117
8a10d76c
PE
12118 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
12119 so that it is not optimized away.
12120
f26d0e4c
PE
12121 * xdisp.c (compute_display_string_pos): Remove unused local.
12122
55439c61
EZ
121232011-08-02 Eli Zaretskii <eliz@gnu.org>
12124
12125 Fix slow cursor motion and scrolling in large buffers with
12126 selective display, like Org Mode buffers. (Bug#9218)
12127
12128 * dispextern.h (struct bidi_it): New member disp_prop_p.
12129
12130 * xdisp.c: Remove one-slot cache of display string positions.
12131 (compute_display_string_pos): Accept an additional argument
5e617bc2 12132 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
12133 for a display string or property. If found, set DISP_PROP_P
12134 non-zero.
12135
12136 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
12137 DISP_PROP_P, and pass it to compute_display_string_pos.
12138 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
12139 non-zero. All callers of bidi_fetch_char changed.
12140
fb33fa43
SM
121412011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
12142
12143 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
12144
b099e063
DM
121452010-12-03 Don March <don@ohspite.net>
12146
12147 * keymap.c (Fdefine_key): Fix non-prefix key error message when
12148 last character M-[char] is translated to ESC [char] (bug#7541).
12149
5cc7f7af
KH
121502011-08-02 Kenichi Handa <handa@m17n.org>
12151
d0fffa3f 12152 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
12153
12154 * chartab.c (uniprop_table): Make it non-static.
12155
525d5e6e
EZ
121562011-08-01 Eli Zaretskii <eliz@gnu.org>
12157
12158 * xdisp.c (forward_to_next_line_start): Accept additional argument
12159 BIDI_IT_PREV, and store into it the state of the bidi iterator had
12160 on the newline.
12161 (reseat_at_next_visible_line_start): Use the bidi iterator state
12162 returned by forward_to_next_line_start to restore the state of
12163 it->bidi_it after backing up to previous newline. (Bug#9212)
12164
31011111
AS
121652011-07-30 Andreas Schwab <schwab@linux-m68k.org>
12166
12167 * regex.c (re_comp): Protoize.
12168 (re_exec): Fix return type.
12169 (regexec): Fix type of `ret'. (Bug#9203)
12170
476371c4
PE
121712011-07-28 Paul Eggert <eggert@cs.ucla.edu>
12172
e5d76069
PE
12173 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
12174 This is needed if max-image-size is a floating-point number.
12175
9a79b20c
AS
121762011-07-28 Andreas Schwab <schwab@linux-m68k.org>
12177
12178 * print.c (print_object): Print empty symbol as ##.
12179
12180 * lread.c (read1): Read ## as empty symbol.
12181
d8c2fa78
AA
121822011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
12183
12184 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
12185 setting frame foreground color (Bug#9175).
12186 (x_set_background_color): Likewise.
12187
ffe57a7a
AA
12188 * nsmenu.m (-setText): Size tooltip dimensions precisely to
12189 contents (Bug#9176).
12190 (EmacsTooltip -init): Remove bezels and add shadows to
12191 tooltip windows.
12192
bf3492a5
AA
12193 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
12194 or scroll bar (Bug#8470).
12195
d55e9c53
AA
12196 * nsfont.m (nsfont_open): Remove assignment to voffset and
12197 unnecessary vars hshink, expand, hd, full_height, min_height.
12198 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
12199
12200 * nsterm.h (nsfont_info): Remove voffset field.
12201
d8c2fa78 122022011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
12203
12204 Implement strike-through and overline on NextStep (Bug#8863).
12205
12206 * nsfont.m (nsfont_open): Use underline position provided by font,
12207 instead of hard-coded value of 2.
12208 (nsfont_draw): Call ns_draw_text_decoration instead.
12209
12210 * nsterm.h: Add declaration for ns_draw_text_decoration.
12211
12212 * nsterm.m (ns_draw_text_decoration): New function for drawing
12213 underline, overline, and strike-through.
12214 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
12215 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 12216 accommodate underlining, etc.
4843aac3 12217
4cc60b9b
EZ
122182011-07-28 Eli Zaretskii <eliz@gnu.org>
12219
bc7ece87
EZ
12220 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
12221 default.
4cc60b9b 12222
476371c4
PE
122232011-07-28 Paul Eggert <eggert@cs.ucla.edu>
12224
66606eea
PE
12225 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
12226 Without this fix, if a signal arrives just after memory fills up,
12227 'malloc' might be invoked reentrantly.
12228
476371c4
PE
12229 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
12230 In other words, assume that every image size is allowed, on non-X
12231 hosts. This assumption is probably wrong, but it lets Emacs compile.
12232
f3fcc40d
AS
122332011-07-28 Andreas Schwab <schwab@linux-m68k.org>
12234
12235 * regex.c (re_iswctype): Convert return values to boolean.
12236
350c992f
EZ
122372011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
12238
12239 * xdisp.c (compute_display_string_pos): Don't use cached display
12240 string position if the buffer had its restriction changed.
12241 (Bug#9184)
12242
5266b4bb
PE
122432011-07-28 Paul Eggert <eggert@cs.ucla.edu>
12244
12245 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
12246
2573a837 122472011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 12248
41f55ccd 12249 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 12250
39e378da
PE
12251 * bidi.c: Integer size and overflow fixes.
12252 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
12253 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
12254 (bidi_cache_find_level_change, bidi_cache_ensure_space)
12255 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
12256 (bidi_find_other_level_edge):
12257 Use ptrdiff_t instead of EMACS_INT where either will do.
12258 This works better on 32-bit hosts configured --with-wide-int.
12259 (bidi_cache_ensure_space): Check for size-calculation overflow.
12260 Use % rather than repeated addition, for better worst-case speed.
12261 Don't set bidi_cache_size until after xrealloc returns, because it
12262 might not return.
12263 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
12264 (bidi_cache_ensure_space): Also check that the bidi cache size
12265 does not exceed that of the largest Lisp string or buffer. See Eli
12266 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 12267
5e927815
PE
12268 * alloc.c (__malloc_size_t): Remove.
12269 All uses replaced by size_t. See Andreas Schwab's note
12270 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
12271
ca4aa935
PE
12272 * image.c: Improve checking for integer overflow.
12273 (check_image_size): Assume that f is nonnull, since
12274 it is always nonnull in practice. This is one less thing to
12275 worry about when checking for integer overflow later.
12276 (x_check_image_size): New function, which checks for integer
12277 overflow issues inside X.
12278 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
12279 This removes the need for a memory_full check.
12280 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
12281 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
12282 (xbm_read_bitmap_data): Change locals back to 'int', since
12283 their values must fit in 'int'.
12284 (xpm_load_image, png_load, tiff_load):
12285 Invoke x_create_x_image_and_pixmap earlier,
12286 to avoid much needless work if the image is too large.
12287 (tiff_load): Treat overly large images as if
12288 x_create_x_image_and_pixmap failed, not as malloc failures.
12289 (gs_load): Use x_check_image_size.
12290
5f8f9cc2
PE
12291 * gtkutil.c: Omit integer casts.
12292 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
12293 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
12294
5adf60bc
PE
12295 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
12296
c8907a93
PE
12297 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
12298 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
12299 would wrongly return t on a 64-bit host.
12300
e3c25c68
PE
12301 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
12302 The plain *_OVERFLOW macros run afoul of GCC bug 49705
12303 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
12304 and therefore cause GCC to emit a bogus diagnostic in some cases.
12305
3f791afe
PE
12306 * image.c: Integer signedness and overflow and related fixes.
12307 This is not an exhaustive set of fixes, but it's time to
12308 record what I've got.
12309 (lookup_pixel_color, check_image_size): Remove redundant decls.
12310 (check_image_size): Don't assume that arbitrary EMACS_INT values
12311 fit in 'int', or that arbitrary 'double' values fit in 'int'.
12312 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
12313 (tiff_load, imagemagick_load_image):
12314 Check for overflow in size calculations.
12315 (x_create_x_image_and_pixmap): Remove unnecessary test for
12316 xmalloc returning NULL; that can't happen.
12317 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
12318 (xpm_color_bucket): Use better integer hashing function.
12319 (xpm_cache_color): Don't possibly over-allocate memory.
12320 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
12321 (gif_memory_source):
12322 Use ptrdiff_t, not int or size_t, to record sizes.
12323 (png_load): Don't assume values greater than 2**31 fit in 'int'.
12324 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
12325 either works, as we prefer signed integers.
12326 (tiff_read_from_memory, tiff_write_from_memory):
12327 Return tsize_t, not size_t, since that's what the TIFF API wants.
12328 (tiff_read_from_memory): Don't fail simply because the read would
12329 go past EOF; instead, return a short read.
12330 (tiff_load): Omit no-longer-needed casts.
12331 (Fimagemagick_types): Don't assume size fits into 'int'.
12332
3cc5a532
PE
12333 Improve hashing quality when configured --with-wide-int.
12334 * fns.c (hash_string): New function, taken from sxhash_string.
12335 Do not discard information about ASCII character case; this
12336 discarding is no longer needed.
12337 (sxhash-string): Use it. Change sig to match it. Caller changed.
12338 * lisp.h: Declare it.
12339 * lread.c (hash_string): Remove, since we now use fns.c's version.
12340 The fns.c version returns a wider integer if --with-wide-int is
12341 specified, so this should help the quality of the hashing a bit.
12342
b312a492
PE
12343 * emacs.c: Integer overflow minor fix.
12344 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
12345 Define only if GNU_LINUX.
12346 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
12347
dfd153ae
PE
12348 * dispnew.c: Integer signedness and overflow fixes.
12349 Remove unnecessary forward decls, that were a maintenance hassle.
12350 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
12351 All uses changed.
12352 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
12353 (scrolling_window): Use ptrdiff_t, not int, for byte count.
12354 (prepare_desired_row, line_draw_cost):
12355 Use int, not unsigned, where either works.
12356 (save_current_matrix, restore_current_matrix):
12357 Use ptrdiff_t, not size_t, where either works.
12358 (init_display): Check for overflow more accurately, and without
12359 relying on undefined behavior.
12360
a81d11a3
PE
12361 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
12362 Remove, replacing with the new symbols in lisp.h. All uses changed.
12363 * fileio.c (make_temp_name):
12364 * filelock.c (lock_file_1, lock_file):
12365 * xdisp.c (message_dolog):
12366 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
12367 Use pMd etc. instead.
12368 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
12369 replacing the pWIDE etc. symbols removed from editfns.c.
12370
3300e6fd
PE
12371 * keyboard.h (num_input_events): Now uintmax_t.
12372 This is (very slightly) less likely to mess up due to wraparound.
12373 All uses changed.
12374
fd05c7e9
PE
12375 * buffer.c: Integer signedness fixes.
12376 (alloc_buffer_text, enlarge_buffer_text):
12377 Use ptrdiff_t rather than size_t when either will do, as we prefer
12378 signed integers.
12379
903fe15d
PE
12380 * alloc.c: Integer signedness and overflow fixes.
12381 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
12382 (__malloc_size_t): Default to size_t, not to int.
12383 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
12384 (Fgarbage_collect, mark_object_loop_halt, mark_object):
12385 Prefer ptrdiff_t to size_t when either would do, as we prefer
12386 signed integers.
12387 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
12388 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
12389 Now const. Initialize with values that are in range even if char
12390 is signed.
12391 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
12392 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
12393 These functions do the right thing with sizes > 2**32.
12394 (check_depth): Now ptrdiff_t, not int.
12395 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
12396 Adjust to new way of storing sizes. Check for size overflow bugs
12397 in rest of code.
12398 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
12399 slightly wrong anyway, as it missed one instance of
12400 XMALLOC_OVERRUN_CHECK_OVERHEAD.
12401 (refill_memory_reserve): Omit needless cast to size_t.
12402 (mark_object_loop_halt): Mark as externally visible.
12403
ac82cc6a
PE
12404 * xselect.c: Integer signedness and overflow fixes.
12405 (Fx_register_dnd_atom, x_handle_dnd_message):
12406 Use ptrdiff_t, not size_t, since we prefer signed.
12407 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
12408 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
12409 x_dnd_atoms_size and x_dnd_atoms_length.
12410
c2d1e36d
PE
12411 * doprnt.c: Prefer signed to unsigned when either works.
12412 * eval.c (verror):
12413 * doprnt.c (doprnt):
12414 * lisp.h (doprnt):
12415 * xdisp.c (vmessage):
12416 Use ptrdiff_t, not size_t, when using or implementing doprnt,
12417 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
12418 prefer signed arithmetic to avoid comparison confusion.
12419 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
12420 but is a bit tricky.
12421
0e926e56
PE
12422 Assume freestanding C89 headers, string.h, stdlib.h.
12423 * data.c, doprnt.c, floatfns.c, print.c:
12424 Include float.h unconditionally.
12425 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
12426 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
12427 * regex.c: Likewise for stddef.h, string.h.
12428 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
12429 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
12430 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
12431 (STDC_HEADERS): Remove obsolete defines.
12432 * sysdep.c: Include limits.h unconditionally.
12433
9cfdb3ec
PE
12434 Assume support for memcmp, memcpy, memmove, memset.
12435 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
12436 * regex.c (memcmp, memcpy):
12437 Remove; we assume C89 now.
12438
12439 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
12440 (__malloc_safe_bcopy): Remove; no longer needed.
12441
cf950e6b 12442 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
12443 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
12444 well either way, and we prefer signed to unsigned.
12445
dbf38e02
LMI
124462011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
12447
12448 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
12449 closes the connection while we're reading (bug#9182).
12450
d6f0886c 124512011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 12452
d6f0886c
JD
12453 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
12454 are specified (Bug#9168).
24e0f6b1 12455
2eb1f9e6
PE
124562011-07-25 Paul Eggert <eggert@cs.ucla.edu>
12457
12458 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
12459 Found by GCC static checking and --with-wide-int on a 32-bit host.
12460
22381272 124612011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
12462
12463 * xdisp.c (compute_display_string_pos): Fix logic of caching
12464 previous display string position. Initialize cached_prev_pos to
12465 -1. Fixes slow-down at the beginning of a buffer.
12466
f25e39b4
EZ
124672011-07-24 Eli Zaretskii <eliz@gnu.org>
12468
12469 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
12470 for attrs[LFACE_FONTSET_INDEX].
12471
04c4b52e
PE
124722011-07-23 Paul Eggert <eggert@cs.ucla.edu>
12473
12474 * xml.c (parse_region): Remove unused local
12475 that was recently introduced.
12476
c1734fbd
EZ
124772011-07-23 Eli Zaretskii <eliz@gnu.org>
12478
be18c5a5
EZ
12479 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
12480 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
12481
c1734fbd
EZ
12482 * xdisp.c (move_it_in_display_line_to): Record the best matching
12483 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
12484 exit if none of the characters scanned was an exact match.
12485 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
12486 when exact match is impossible due to invisible text, and the
12487 lines are truncated.
12488
a258d627
JD
124892011-07-23 Jan Djärv <jan.h.d@swipnet.se>
12490
12491 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
12492 for OSX >= 10.7.
12493
b6d5a689
EZ
124942011-07-22 Eli Zaretskii <eliz@gnu.org>
12495
0f74f785
EZ
12496 Fix a significant slow-down of cursor motion with C-n, C-p,
12497 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
12498 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 12499 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
12500 (next_element_from_buffer): Call compute_stop_pos_backwards to
12501 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
12502 base_level_stop.
12503 (reseat): Don't look for prev_stop, as that could mean a very long
12504 run.
12505 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
12506 <cached_disp_overlay_modiff>: Cache for last found display string
12507 position.
551918c1 12508 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
12509 about the same buffer in the same area of character positions, and
12510 the buffer wasn't changed since the time the display string
12511 position was cached.
551918c1 12512
b2d0c91a
EZ
125132011-07-22 Eli Zaretskii <eliz@gnu.org>
12514
12515 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
12516 is an integer, which is important for empty lines. (Bug#9149)
12517
043604ee
CY
125182011-07-22 Chong Yidong <cyd@stupidchicken.com>
12519
12520 * frame.c (Fmodify_frame_parameters): In tty case, update the
12521 default face if necessary (Bug#4238).
12522
da4adb04
CY
125232011-07-21 Chong Yidong <cyd@stupidchicken.com>
12524
12525 * editfns.c (Fstring_to_char): No need to explain what a character
12526 is in the docstring (Bug#6576).
12527
9abd0532
LMI
125282011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
12529
12530 * xml.c (parse_region): Make sure we always return a tree.
12531
36881d16
HK
125322011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
12533
12534 * xml.c (parse_region): If a document contains only comments,
12535 return that, too.
12536
1e98674d
LMI
125372011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
12538
12539 * xml.c (make_dom): Return comments, too.
12540
590bd467
PE
125412011-07-19 Paul Eggert <eggert@cs.ucla.edu>
12542
12543 Port to OpenBSD.
12544 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
12545 and the surrounding thread.
12546 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
12547 rather than fgets, and retry after EINTR. Otherwise, 'emacs
12548 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
12549 timer goes off.
12550 * s/openbsd.h (BROKEN_SIGIO): Define.
12551 * unexelf.c (unexec) [__OpenBSD__]:
12552 Don't update the .mdebug section of the Alpha COFF symbol table.
12553
f41628b2
LMI
125542011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
12555
12556 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
12557 (bug#8460).
12558
b59b67c5
PE
125592011-07-18 Paul Eggert <eggert@cs.ucla.edu>
12560
15e3a074
PE
12561 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
12562 This fixes some race conditions on the permissions of any newly
12563 created file.
12564
41bed37d
PE
12565 * alloc.c (valid_pointer_p): Use pipe, not open.
12566 This fixes some permissions issues when debugging.
12567
b59b67c5
PE
12568 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
12569 If fchown fails to set both uid and gid, try to set just gid,
12570 as that is sometimes allowed. Adjust the file's mode to eliminate
12571 setuid or setgid bits that are inappropriate if fchown fails.
12572
925a6be7
SM
125732011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
12574
12575 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
12576 to compare Lisp_Objects.
12577 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
12578 global_gnutls_log_level, don't mistake it for a Lisp_Object.
12579 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
12580
52968808
AS
125812011-07-17 Andreas Schwab <schwab@linux-m68k.org>
12582
0a6a104b
AS
12583 * lread.c (read_integer): Unread even EOF character.
12584 (read1): Likewise. Properly record start position of symbol.
12585
52968808
AS
12586 * lread.c (read1): Read `#:' as empty uninterned symbol if no
12587 symbol character follows.
12588
9e381cdd
PE
125892011-07-17 Paul Eggert <eggert@cs.ucla.edu>
12590
12591 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
12592 This works around a problem with the previous change to Fcopy_file.
12593 Recent glibc declares fchown with __attribute__((warn_unused_result)),
12594 and without this change, GCC might complain about discarding
12595 fchown's return value.
12596
b5641435
JB
125972011-07-16 Juanma Barranquero <lekktu@gmail.com>
12598
12599 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
12600
a8031457
PE
126012011-07-16 Paul Eggert <eggert@cs.ucla.edu>
12602
12603 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
12604
dd889327
LMI
126052011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
12606
750c33f7
LMI
12607 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
12608 it's used from the C level.
12609
dd889327
LMI
12610 * process.c: Use the same condition for POLL_FOR_INPUT in both
12611 keyboard.c and process.c (bug#1858).
12612
87e86684
LM
126132011-07-09 Lawrence Mitchell <wence@gmx.li>
12614
12615 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
12616 (Fgnutls_boot): Use it.
12617
64348f40
AS
126182011-07-15 Andreas Schwab <schwab@linux-m68k.org>
12619
12620 * doc.c (Fsubstitute_command_keys): Revert last change.
12621
1d698799
LMI
126222011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
12623
f863868c
LMI
12624 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
12625 quotes the next character, and doesn't affect other longer
12626 sequences (bug#8935).
12627
1d698799
LMI
12628 * lread.c (syms_of_lread): Clarify that is isn't only
12629 `eval-buffer' and `eval-defun' that's affected by
12630 `lexical-binding' (bug#8460).
12631
aa4b6df6
EZ
126322011-07-15 Eli Zaretskii <eliz@gnu.org>
12633
12634 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 12635 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 12636
5d856da6
PE
126372011-07-14 Paul Eggert <eggert@cs.ucla.edu>
12638
ad6042bb
PE
12639 Fix minor problems found by static checking.
12640 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
12641 (elsz): Now a signed constant, not a size_t var. We prefer signed
12642 types to unsigned, to avoid integer comparison confusion. Without
12643 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
12644 "cannot optimize loop, the loop counter may overflow", a symptom
12645 of the confusion.
f00bbb22 12646 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
12647 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
12648
6468f31c
LMI
126492011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
12650
49080b10
LMI
12651 * search.c (Fre_search_backward): Mention `case-fold-search' in
12652 all the re_search_* functions (bug#8138).
12653
6468f31c
LMI
12654 * keyboard.c (Fopen_dribble_file): Document when the file is
12655 closed (bug#8056).
12656
c965adc5
EZ
126572011-07-14 Eli Zaretskii <eliz@gnu.org>
12658
df9733bf
EZ
12659 * bidi.c (bidi_dump_cached_states): Fix format of displaying
12660 bidi_cache_idx.
12661
0bb23927
EZ
12662 Support bidi reordering of display and overlay strings.
12663 * xdisp.c (compute_display_string_pos)
12664 (compute_display_string_end): Accept additional argument STRING.
12665 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
12666 (reseat_to_string): Initialize bidi_it->string.s and
12667 bidi_it->string.schars.
12668 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
12669 NULL (avoids a crash in bidi_paragraph_init).
12670 Initialize itb.string.lstring.
0bb23927
EZ
12671 (init_iterator): Call bidi_init_it only of a valid
12672 buffer position was specified. Initialize paragraph_embedding to
12673 L2R.
12674 (reseat_to_string): Initialize the bidi iterator.
12675 (display_string): If we need to ignore text properties of
12676 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
12677 original value of -1 will not work with bidi.)
12678 (compute_display_string_pos): First arg is now struct
12679 `text_pos *'; all callers changed. Support display properties on
12680 Lisp strings.
12681 (compute_display_string_end): Support display properties on Lisp
12682 strings.
12683 (init_iterator, reseat_1, reseat_to_string): Initialize the
12684 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
12685 when iterating on a string not from display properties).
640c8776
SM
12686 (compute_display_string_pos, compute_display_string_end):
12687 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
12688 arrow keys.
12689 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
12690 base_level_stop; instead, set base_level_stop to BEGV.
12691 Fixes crashes in vertical-motion.
0bb23927
EZ
12692 (next_element_from_buffer): Improve commentary for when
12693 the iterator is before prev_stop.
12694 (init_iterator): Initialize bidi_p from the default value of
12695 bidi-display-reordering, not from buffer-local value. Use the
12696 buffer-local value only if initializing for buffer iteration.
12697 (handle_invisible_prop): Support invisible properties on strings
12698 that are being bidi-reordered.
12699 (set_iterator_to_next): Support bidi reordering of C strings and
12700 Lisp strings.
12701 (next_element_from_string): Support bidi reordering of Lisp
12702 strings.
12703 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
12704 (display_string): Support display of R2L glyph rows.
12705 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
12706 (init_iterator): Don't initialize it->bidi_p for strings
12707 here.
12708 (reseat_to_string): Initialize it->bidi_p for strings here.
12709 (next_element_from_string, next_element_from_c_string)
12710 (next_element_from_buffer): Add xassert's for correspondence
12711 between IT's object being iterated and it->bidi_it.string
12712 structure.
12713 (face_before_or_after_it_pos): Support bidi iteration.
12714 (next_element_from_c_string): Handle the case of the first string
12715 character that is not the first one in the visual order.
12716 (get_visually_first_element): New function, refactored from common
12717 parts of next_element_from_buffer, next_element_from_string, and
12718 next_element_from_c_string.
12719 (tool_bar_lines_needed, redisplay_tool_bar)
12720 (display_menu_bar): Force left-to-right direction. Add a FIXME
12721 comment for making that be controlled by a user option.
12722 (push_it, pop_it): Save and restore the state of the
12723 bidi iterator. Save and restore the bidi_p flag.
12724 (pop_it): Iterate out of display property for string iteration as
12725 well.
12726 (iterate_out_of_display_property): Support iteration over strings.
12727 (handle_single_display_spec): Set up it->bidi_it for iteration
12728 over a display string, and call bidi_init_it.
12729 (handle_single_display_spec, next_overlay_string)
12730 (get_overlay_strings_1, push_display_prop): Set up the bidi
12731 iterator for displaying display or overlay strings.
12732 (forward_to_next_line_start): Don't use the shortcut if
12733 bidi-iterating.
12734 (back_to_previous_visible_line_start): If handle_display_prop
12735 pushed the iterator stack, restore the internal state of the bidi
12736 iterator by calling bidi_pop_it same number of times.
12737 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
12738 and we are bidi-iterating, don't decrement the iterator position;
12739 instead, set the first_elt flag in the bidi iterator, to produce
12740 the same effect.
12741 (reseat_1): Remove redundant setting of string_from_display_prop_p.
12742 (push_display_prop): xassert that we are iterating a buffer.
12743 (push_it, pop_it): Save and restore paragraph_embedding member.
12744 (handle_single_display_spec, next_overlay_string)
12745 (get_overlay_strings_1, reseat_1, reseat_to_string)
12746 (push_display_prop): Set up the `unibyte' member of bidi_it.string
12747 correctly. Don't assume unibyte strings are not bidi-reordered.
12748 (compute_display_string_pos)
12749 (compute_display_string_end): Fix handling the case of C string.
12750 (push_it, pop_it): Save and restore from_disp_prop_p.
12751 (handle_single_display_spec, push_display_prop): Set the
12752 from_disp_prop_p flag.
12753 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
12754 (pop_it): Call iterate_out_of_display_property only if we are
12755 popping after iteration over a string that came from a display
12756 property. Fix a typo in popping stretch info. Add an assertion
12757 for verifying that the iterator position is in sync with the bidi
12758 iterator.
12759 (handle_single_display_spec, get_overlay_strings_1)
12760 (push_display_prop): Fix initialization of paragraph direction for
12761 string when that of the parent object is not yet determined.
12762 (reseat_1): Call bidi_init_it to resync the bidi
12763 iterator with IT's position. (Bug#7616)
12764 (find_row_edges): If ROW->start.pos gives position
12765 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
12766 (handle_stop, back_to_previous_visible_line_start, reseat_1):
12767 Reset the from_disp_prop_p flag.
12768 (SAVE_IT, RESTORE_IT): New macros.
12769 (pos_visible_p, face_before_or_after_it_pos)
12770 (back_to_previous_visible_line_start)
12771 (move_it_in_display_line_to, move_it_in_display_line)
12772 (move_it_to, move_it_vertically_backward, move_it_by_lines)
12773 (try_scrolling, redisplay_window, display_line): Use them when
12774 saving a temporary copy of the iterator and restoring it back.
12775 (back_to_previous_visible_line_start, reseat_1)
12776 (init_iterator): Empty the bidi cache "stack".
12777 (move_it_in_display_line_to): If iterator ended up at
12778 EOL, but we never saw any buffer positions smaller than
12779 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
12780 motion in bidi-reordered lines.
12781 (move_it_in_display_line_to): Record prev_method and prev_pos
12782 immediately before the call to set_iterator_to_next. Fixes cursor
12783 motion in bidi-reordered lines with stretch glyphs and strings
12784 displayed in margins. (Bug#8133) (Bug#8867)
12785 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
12786 TO_CHARPOS.
640c8776
SM
12787 (pos_visible_p): Support positions in bidi-reordered lines.
12788 Save and restore bidi cache.
0bb23927
EZ
12789
12790 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
12791 (bidi_paragraph_info): Delete unused struct.
12792 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
12793 (bidi_cache_start): New variable.
12794 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
12795 to zero.
12796 (bidi_cache_fetch_state, bidi_cache_search)
12797 (bidi_cache_find_level_change, bidi_cache_iterator_state)
12798 (bidi_cache_find, bidi_peek_at_next_level)
12799 (bidi_level_of_next_char, bidi_find_other_level_edge)
12800 (bidi_move_to_visually_next): Compare cache index with
12801 bidi_cache_start rather than with zero.
12802 (bidi_fetch_char): Accept new argument STRING; all callers
12803 changed. Support iteration over a string. Support strings with
12804 display properties. Support unibyte strings. Fix the type of
12805 `len' according to what STRING_CHAR_AND_LENGTH expects.
12806 (bidi_paragraph_init, bidi_resolve_explicit_1)
12807 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
12808 (bidi_level_of_next_char, bidi_move_to_visually_next):
12809 Support iteration over a string.
0bb23927
EZ
12810 (bidi_set_sor_type, bidi_resolve_explicit_1)
12811 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
12812 can now be zero (for strings); special values 0 and -1 were
12813 changed to -1 and -2, respectively.
12814 (bidi_char_at_pos): New function.
12815 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
12816 Call it instead of FETCH_MULTIBYTE_CHAR.
12817 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
12818 initialized to valid values.
12819 (bidi_init_it): Don't initialize charpos and bytepos with invalid
12820 values.
12821 (bidi_level_of_next_char): Allow the sentinel "position" to pass
12822 the test for valid cached positions. Fix the logic for looking up
12823 the sentinel state in the cache. GCPRO the Lisp string we are
12824 iterating.
12825 (bidi_push_it, bidi_pop_it): New functions.
12826 (bidi_initialize): Initialize the bidi cache start stack pointer.
12827 (bidi_cache_ensure_space): New function, refactored from part of
12828 bidi_cache_iterator_state. Don't assume the required size is just
12829 one BIDI_CACHE_CHUNK away.
12830 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
12831 (bidi_count_bytes, bidi_char_at_pos): New functions.
12832 (bidi_cache_search): Don't assume bidi_cache_last_idx is
12833 always valid if bidi_cache_idx is valid.
12834 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
12835 is valid if it's going to be used.
12836 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
12837 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
12838 (bidi_cache_find_level_change, bidi_cache_ensure_space)
12839 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
12840 (bidi_find_other_level_edge, bidi_cache_start_stack):
12841 All variables related to cache indices are now EMACS_INT.
c965adc5 12842
0bb23927
EZ
12843 * dispextern.h (struct bidi_string_data): New structure.
12844 (struct bidi_it): New member `string'. Make flag members be 1-bit
12845 fields, and put them last in the struct.
640c8776
SM
12846 (compute_display_string_pos, compute_display_string_end):
12847 Update prototypes.
0bb23927
EZ
12848 (bidi_push_it, bidi_pop_it): Add prototypes.
12849 (struct iterator_stack_entry): New members bidi_p,
12850 paragraph_embedding, and from_disp_prop_p.
12851 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
12852 (bidi_shelve_cache, bidi_unshelve_cache):
12853 Declare prototypes.
0bb23927
EZ
12854
12855 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
12856 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
12857 and vector-like objects.
12858
12859 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
12860 cache around display iteration.
12861
12862 * window.c (Fwindow_end, window_scroll_pixel_based)
12863 (displayed_window_lines, Frecenter): Save and restore the bidi
12864 cache around display iteration.
12865
3bbd2265
LMI
128662011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
12867
12868 * editfns.c (Fdelete_region): Clarify the use of the named
12869 parameters (bug#6788).
12870
adc47434
MR
128712011-07-14 Martin Rudalics <rudalics@gmx.at>
12872
12873 * indent.c (Fvertical_motion): Set and restore w->pointm when
12874 saving and restoring the window's buffer (Bug#9006).
12875
837c31f8
LMI
128762011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
12877
12878 * editfns.c (Fstring_to_char): Clarify just what is returned
12879 (bug#6576). Text by Eli Zaretskii.
12880
ac389d0c
JB
128812011-07-13 Juanma Barranquero <lekktu@gmail.com>
12882
12883 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
12884
0be0ce47
EZ
128852011-07-13 Eli Zaretskii <eliz@gnu.org>
12886
12887 * buffer.c (mmap_find): Fix a typo.
12888
cd18e7e3
JB
128892011-07-13 Johan Bockgård <bojohan@gnu.org>
12890
12891 Fix execution of x selection hooks.
12892 * xselect.c (Qx_lost_selection_functions)
12893 (Qx_sent_selection_functions): New vars.
12894 (syms_of_xselect): DEFSYM them.
12895 (x_handle_selection_request): Pass Qx_sent_selection_functions
12896 rather than Vx_sent_selection_functions to Frun_hook_with_args.
12897 (x_handle_selection_clear,x_clear_frame_selections):
12898 Pass Qx_lost_selection_functions rather than
12899 Vx_lost_selection_functions to Frun_hook_with_args.
12900
47ea7f44
PE
129012011-07-13 Paul Eggert <eggert@cs.ucla.edu>
12902
ac389d0c 12903 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
12904 The old code sometimes used this field without initializing it.
12905
47ea7f44
PE
12906 * alloc.c (gc_sweep): Don't read past end of array.
12907 In theory, the old code could also have corrupted Emacs internals,
12908 though it'd be very unlikely.
12909
bc985c87
AS
129102011-07-12 Andreas Schwab <schwab@linux-m68k.org>
12911
12912 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 12913 argument. (Bug#4026)
bc985c87 12914
0cf34688
LMI
129152011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
12916
b3dadd76
LMI
12917 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
12918 key" (bug#4257).
12919
0cf34688
LMI
12920 * window.c (Fset_window_start): Doc fix (bug#4199).
12921 (Fset_window_hscroll): Ditto.
12922
270768cd
PE
129232011-07-12 Paul Eggert <eggert@cs.ucla.edu>
12924
077e3dda 12925 Fix minor new problems caught by GCC 4.6.1.
270768cd 12926 * term.c (init_tty): Remove unused local.
490011a6 12927 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 12928 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 12929 not used otherwise.
270768cd 12930
b1f58454
CY
129312011-07-12 Chong Yidong <cyd@stupidchicken.com>
12932
12933 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
12934
22b9578d
LMI
129352011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
12936
6e70ab07
LMI
12937 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
12938 are the mini-buffer and the echo area (bug#3320).
12939
22b9578d
LMI
12940 * term.c (init_tty): Remove support for supdup, c10 and perq
12941 terminals, which are no longer supported (bug#1482).
12942
8974cc9f
JB
129432011-07-10 Johan Bockgård <bojohan@gnu.org>
12944
12945 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
12946
a560d974
JD
129472011-07-10 Jan Djärv <jan.h.d@swipnet.se>
12948
12949 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
12950 for non-popups (Bug#3642).
12951
1dae0f0a
AS
129522011-07-10 Andreas Schwab <schwab@linux-m68k.org>
12953
268c2c36 12954 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 12955 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
12956 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
12957 * cm.c (losecursor): Likewise.
1dae0f0a
AS
12958 * data.c (fmod): Likewise.
12959 * dispnew.c (swap_glyphs_in_rows): Likewise.
12960 * emacs.c (memory_warning_signal): Likewise.
12961 * floatfns.c (float_error): Likewise.
12962 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
12963 (otf_open, font_otf_capability, generate_otf_features)
12964 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
12965 Likewise.
12966 * image.c (pbm_read_file): Likewise.
12967 * indent.c (string_display_width): Likewise.
12968 * intervals.c (check_for_interval, search_for_interval)
12969 (inc_interval_count, count_intervals, root_interval)
12970 (adjust_intervals_for_insertion, make_new_interval): Likewise.
12971 * lread.c (defalias): Likewise.
268c2c36 12972 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
12973 * regex.c (set_image_of_range_1, set_image_of_range)
12974 (regex_grow_registers): Likewise.
12975 * sysdep.c (strerror): Likewise.
12976 * termcap.c (valid_filename_p, tprint, main): Likewise.
12977 * tparam.c (main): Likewise.
12978 * unexhp9k800.c (run_time_remap, save_data_space)
12979 (update_file_ptrs, read_header, write_header, calculate_checksum)
12980 (copy_file, copy_rest, display_header): Likewise.
12981 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
12982 Likewise.
12983 * xdisp.c (check_it): Likewise.
12984 * xfaces.c (register_color, unregister_color, unregister_colors):
12985 Likewise.
12986 * xfns.c (print_fontset_result): Likewise.
12987 * xrdb.c (member, fatal, main): Likewise.
12988
99033785
PE
129892011-07-10 Paul Eggert <eggert@cs.ucla.edu>
12990
12991 Fix minor problems found by static checking (Bug#9031).
12992 * chartab.c (char_table_set_range, map_sub_char_table):
12993 Remove unused locals.
12994 (uniprop_table): Now static.
12995 * composite.c (_work_char): Remove unused static var.
12996
9cb2ac56
JB
129972011-07-09 Juanma Barranquero <lekktu@gmail.com>
12998
12999 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
13000
f25661f0
JD
130012011-07-09 Jan Djärv <jan.h.d@swipnet.se>
13002
13003 * gtkutil.c (qttip_cb): Remove code without function.
13004
8278c4fe
EZ
130052011-07-09 Eli Zaretskii <eliz@gnu.org>
13006
13007 * w32.c (pthread_sigmask): New stub.
13008
1692ae2d 130092011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 13010
8a6ebd58 13011 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
13012 sigprocmask is portable only for single-threaded applications, and
13013 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
13014 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
13015 (LIBES): Use it.
13016 * callproc.c (Fcall_process):
13017 * process.c (create_process):
13018 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
13019 Use pthread_sigmask, not sigprocmask.
123403e4 13020
1b854618
JD
130212011-07-08 Jan Djärv <jan.h.d@swipnet.se>
13022
13023 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
13024 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
13025 wrong (Bug#8591).
13026
3fe4b549
JD
130272011-07-08 Jan Djärv <jan.h.d@swipnet.se>
13028
0ce7e563
JD
13029 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
13030 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
13031 (xg_hide_tooltip): Fix comment.
13032
3fe4b549
JD
13033 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
13034 in registerServicesMenuSendTypes.
13035 (validRequestorForSendType): Don't check ns_return_types.
13036
13037 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
13038 ns_return_type.
13039
5df75e47
JR
130402011-07-08 Jason Rumney <jasonr@gnu.org>
13041
22610910
JR
13042 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
13043 SH_SHOW for hidden windows (Bug#5482).
13044
5df75e47
JR
13045 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
13046 frame struct members of non-existent frames (Bug#6284).
13047
699c10bd
JD
130482011-07-08 Jan Djärv <jan.h.d@swipnet.se>
13049
4393663b
JD
13050 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
13051 variable firstTime not needed on OSX >= 10.6.
13052 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
13053 >= 10.5. Use setKnobProportion, setDoubleValue.
13054
13055 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
13056 (MAC_OS_X_VERSION_10_5): Define if not defined.
13057 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
13058 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
13059 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
13060
13061 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 13062 cString and lossyCString on OSX >= 10.4.
4393663b 13063
58179cce 13064 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
13065 sizeToFit on OSX >= 10.2.
13066
13067 * nsimage.m (allocInitFromFile): Don't use deprecated method
13068 bestRepresentationForDevice on OSX >= 10.6.
13069
13070 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
13071 to avoid warning.
13072
13073 * emacs.c: Declare unexec_init_emacs_zone.
13074
a63e0781
JD
13075 * nsgui.h: Fix compiler warning about gnulib redefining verify.
13076
699c10bd
JD
13077 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
13078
13079 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
13080 on svcsMenu (Bug#8842).
13081
13082 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
13083 ns_return_types.
13084 (Fns_list_services): Just return Qnil on 10.6, code not working there.
13085
13086 * nsterm.m (QUTF8_STRING): Declare.
13087 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
13088 (validRequestorForSendType): Return type is (id).
13089 Change indexOfObjectIdenticalTo to indexOfObject.
13090 Check if we have local selection before returning self (Bug#8842).
13091 (writeSelectionToPasteboard): Put local selection into paste board
13092 if we have a local selection (Bug#8842).
13093 (syms_of_nsterm): DEFSYM QUTF8_STRING.
13094
13095 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
13096 (ns_get_local_selection): Declare.
13097
54e10184
LMI
130982011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
13099
9888ff71
LMI
13100 * keymap.c (describe_map_tree): Don't insert a double newline at
13101 the end of the buffer (bug#1169) and return whether we inserted
13102 something.
13103
54e10184
LMI
13104 * callint.c (Fcall_interactively): Change "reading args" to
13105 "providing args" to try to clarify what it does (bug#1010).
13106
15fa4783
KH
131072011-07-07 Kenichi Handa <handa@m17n.org>
13108
13109 * composite.c (composition_compute_stop_pos): Ignore a static
13110 composition starting before CHARPOS (Bug#8915).
13111
13112 * xdisp.c (handle_composition_prop): Likewise.
13113
a8815b00
EZ
131142011-07-07 Eli Zaretskii <eliz@gnu.org>
13115
13116 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
13117 (Bug#9015)
13118
ef7b981d 131192011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
13120
13121 * character.h (unicode_category_t): New enum type.
13122
13123 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
13124 (Qchar_code_property_table): New variable.
13125 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
13126 (UNIPROP_COMPRESSED_FORM_P): New macros.
13127 (char_table_ascii): Uncompress the compressed values.
13128 (sub_char_table_ref): New arg is_uniprop. Callers changed.
13129 Uncompress the compressed values.
ac389d0c 13130 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
13131 (char_table_ref_and_range): Uncompress the compressed values.
13132 (sub_char_table_set): New arg is_uniprop. Callers changed.
13133 Uncompress the compressed values.
13134 (sub_char_table_set_range): Args changed. Callers changed.
13135 (char_table_set_range): Adjuted for the above change.
13136 (map_sub_char_table): Delete args default_val and parent. Add arg
13137 top. Give decoded values to a Lisp function.
640c8776 13138 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
13139 values to a Lisp function. Gcpro more variables.
13140 (uniprop_table_uncompress)
13141 (uniprop_decode_value_run_length): New functions.
13142 (uniprop_decoder, uniprop_decoder_count): New variables.
13143 (uniprop_get_decoder, uniprop_encode_value_character)
13144 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
13145 New functions.
13146 (uniprop_encoder, uniprop_encoder_count): New variables.
13147 (uniprop_get_encoder, uniprop_table)
13148 (Funicode_property_table_internal, Fget_unicode_property_internal)
13149 (Fput_unicode_property_internal): New functions.
13150 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
13151 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 13152 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
13153 char-code-property-alist.
13154
640c8776 13155 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
13156 Vunicode_category_table.
13157
640c8776 13158 * font.c (font_range): Adjust for the change of
c805dec0
KH
13159 Vunicode_category_table.
13160
76b397fb
DN
131612011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
13162
13163 * m/iris4d.h: Remove file, move contents ...
13164 * s/irix6-5.h: ... here.
13165
22b4128e
PE
131662011-07-06 Paul Eggert <eggert@cs.ucla.edu>
13167
13168 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
13169 * alloc.c (mark_buffer):
13170 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
13171 (clone_per_buffer_values): Don't assume that
22b4128e
PE
13172 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
13173 This isn't true in general, and it's particularly not true
13174 if Emacs is configured with --with-wide-int.
13175 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
13176 New macros, used in the buffer.c change.
13177
869795d6
JD
131782011-07-05 Jan Djärv <jan.h.d@swipnet.se>
13179
13180 * xsettings.c: Use both GConf and GSettings if both are available.
13181 (store_config_changed_event): Add comment.
13182 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
13183 (store_tool_bar_style_changed): New functions.
5e617bc2 13184 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
13185 (struct xsettings): Move font inside HAVE_XFT.
13186 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 13187 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 13188 Move inside HAVE_XFT.
640c8776 13189 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
13190 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
13191 also.
13192 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 13193 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 13194 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
13195 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
13196 (parse_settings): Move check for font inside HAVE_XFT.
13197 (read_settings, apply_xft_settings): Add comment.
13198 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
13199 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
13200 call store_font_name_changed.
13201 (xft_settings_event): Add comment.
13202 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
13203 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
13204 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
13205 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
13206 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
13207 (xsettings_get_system_font, xsettings_get_system_normal_font):
13208 Add comment.
869795d6 13209
d8ed26bd
PE
132102011-07-05 Paul Eggert <eggert@cs.ucla.edu>
13211
13212 Random fixes. E.g., (random) never returned negative values.
13213 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
13214 subseconds part to the entropy, as that's a bit more random.
13215 Prefer signed to unsigned, since the signedness doesn't matter and
13216 in general we prefer signed. When given a limit, use a
13217 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
13218 latter isn't right if USE_2_TAGS_FOR_INTS.
13219 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
13220 not 0..VALMASK. Don't discard "excess" bits that random () returns.
13221
cabf1cac
SM
132222011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
13223
13224 * textprop.c (text_property_stickiness):
13225 Obey Vtext_property_default_nonsticky.
13226 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
13227 * w32fns.c (syms_of_w32fns):
13228 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
13229
6e9b2be9
PE
132302011-07-04 Paul Eggert <eggert@cs.ucla.edu>
13231
13232 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
13233 This is more efficient than Ffile_directory_p and avoids a minor race.
13234
90186c68
LMI
132352011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
13236
7c301272
LMI
13237 * buffer.c (Foverlay_put): Say what the return value is
13238 (bug#7835).
13239
c4f2d8d4
LMI
13240 * fileio.c (barf_or_query_if_file_exists): Check first if the file
13241 is a directory before asking whether to use the file name
13242 (bug#7564).
ad637907
LMI
13243 (barf_or_query_if_file_exists): Make the "File is a directory"
13244 error be more correct.
c4f2d8d4 13245
90186c68
LMI
13246 * fns.c (Frequire): Remove the mention of the .gz files, since
13247 that's installation-specific, but keep the mention of
13248 `get-load-suffixes'.
13249
da64016e
PE
132502011-07-04 Paul Eggert <eggert@cs.ucla.edu>
13251
13252 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
13253 Report string overflow if the output is too long.
13254
7d47b580
JB
132552011-07-04 Juanma Barranquero <lekktu@gmail.com>
13256
a555cb87
JB
13257 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
13258 (syms_of_gnutls): Remove duplicate DEFSYM for
13259 Qgnutls_bootprop_verify_hostname_error, an error for
13260 Qgnutls_bootprop_verify_error (which is no longer used).
13261
7d47b580
JB
13262 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
13263 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
13264 Also (re)move comments that are misplaced or no longer relevant.
13265
1e49bfab
LMI
132662011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
13267
13268 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
13269
1485f4c0
CY
132702011-07-03 Chong Yidong <cyd@stupidchicken.com>
13271
13272 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
13273 and background color parameters if they have been changed.
13274
a9ab721e
LMI
132752011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
13276
13277 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
13278
cf7cff57
PE
132792011-07-03 Paul Eggert <eggert@cs.ucla.edu>
13280
2e13213d
PE
13281 * xsettings.c (SYSTEM_FONT): Define only when used.
13282 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
13283
cf7cff57
PE
13284 * keymap.c (access_keymap_1): Now static.
13285
7a8e04f7
CY
132862011-07-02 Chong Yidong <cyd@stupidchicken.com>
13287
13288 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
13289 leave any prefix arg for the up event (Bug#1586).
13290
61352f62
LMI
132912011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
13292
69bb1ef7
LMI
13293 * lread.c (syms_of_lread): Mention single symbols defined by
13294 `defvar' or `defconst' (bug#7154).
13295
61352f62 13296 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 13297 (Frequire): Mention get-load-suffixes.
61352f62 13298
28545e04
MR
132992011-07-02 Martin Rudalics <rudalics@gmx.at>
13300
13301 * window.h (window): Remove clone_number slot.
13302 * window.c (Fwindow_clone_number, Fset_window_clone_number):
13303 Remove.
13304 (make_parent_window, make_window, saved_window)
13305 (Fset_window_configuration, save_window_save): Don't deal with
13306 clone numbers.
13307 * buffer.c (Qclone_number): Remove declaration.
13308 (sort_overlays, overlay_strings): Don't deal with clone numbers.
13309
3349e122
SM
133102011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
13311
13312 Add multiple inheritance to keymaps.
13313 * keymap.c (Fmake_composed_keymap): New function.
13314 (Fset_keymap_parent): Simplify.
13315 (fix_submap_inheritance): Remove.
13316 (access_keymap_1): New function extracted from access_keymap to handle
13317 embedded parents and handle lists of maps.
13318 (access_keymap): Use it.
13319 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
13320 (Fcopy_keymap): Handle embedded parents.
13321 (Fcommand_remapping, define_as_prefix): Simplify.
13322 (Fkey_binding): Simplify.
13323 (syms_of_keymap): Move minibuffer-local-completion-map,
13324 minibuffer-local-filename-completion-map,
13325 minibuffer-local-must-match-map, and
13326 minibuffer-local-filename-must-match-map to Elisp.
13327 (syms_of_keymap): Defsubr make-composed-keymap.
13328 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
13329 (parse_menu_item): Trivial simplification.
13330
3279eb87
GM
133312011-07-01 Glenn Morris <rgm@gnu.org>
13332
13333 * Makefile.in (SETTINGS_LIBS): Fix typo.
13334
39cb9e56 133352011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4550efdf
KI
13336
13337 * coding.c (Fencode_coding_string): Record the last coding system
13338 used, as the function doc string says (bug#8738).
13339
0949d2b6
JD
133402011-07-01 Jan Djärv <jan.h.d@swipnet.se>
13341
13342 * xsettings.c (store_monospaced_changed): Take new font as arg and
13343 check for change against current_mono_font.
13344 (EMACS_TYPE_SETTINGS): Remove this and related defines.
13345 (emacs_settings_constructor, emacs_settings_get_property)
13346 (emacs_settings_set_property, emacs_settings_class_init)
13347 (emacs_settings_init, gsettings_obj): Remove.
13348 (something_changedCB): New function for HAVE_GSETTINGS.
13349 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
13350 with value as argument.
13351 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
13352 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 13353 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
13354 "changed".
13355
13356 * xgselect.c: Add defined (HAVE_GSETTINGS).
13357 (xgselect_initialize): Ditto.
13358
13359 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
13360 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
13361 xg_select.
13362
bbc6b304
PE
133632011-07-01 Paul Eggert <eggert@cs.ucla.edu>
13364
13365 * eval.c (struct backtrace): Simplify and port the data structure.
13366 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
13367 signed bit field, as this assumption is not portable and it makes
13368 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
13369 "char debug_on_exit : 1" as this is not portable either; instead,
13370 use the portable "unsigned int debug_on_exit : 1". Remove unused
13371 member evalargs. Remove obsolete comments about cc bombing out.
13372
9851bfc5
JD
133732011-06-30 Jan Djärv <jan.h.d@swipnet.se>
13374
51bb811f 13375 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
13376 Let HAVE_GSETTINGS override HAVE_GCONF.
13377 (store_monospaced_changed): New function.
13378 (EMACS_SETTINGS): A new type derived from GObject to handle
13379 GSettings notifications.
13380 (emacs_settings_constructor, emacs_settings_get_property)
13381 (emacs_settings_set_property, emacs_settings_class_init):
13382 New functions.
13383 (gsettings_client, gsettings_obj): New variables.
13384 (GSETTINGS_SCHEMA): New define.
13385 (something_changedCB): Call store_monospaced_changed.
13386 (init_gsettings): New function.
13387 (xsettings_initialize): Call init_gsettings.
13388 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
13389 to NULL.
13390
640c8776 13391 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
13392 GCONF_CFLAGS/LIBS.
13393
5386012d
MR
133942011-06-29 Martin Rudalics <rudalics@gmx.at>
13395
13396 * window.c (resize_root_window, grow_mini_window)
13397 (shrink_mini_window): Rename Qresize_root_window to
13398 Qwindow_resize_root_window and Qresize_root_window_vertically to
13399 Qwindow_resize_root_window_vertically.
13400
f13e0b08
PE
134012011-06-28 Paul Eggert <eggert@cs.ucla.edu>
13402
13403 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
13404
94515237
JB
134052011-06-27 Juanma Barranquero <lekktu@gmail.com>
13406
13407 * makefile.w32-in: Redesign dependencies so they reflect more
13408 clearly which files are directly included by each source file,
13409 and not through other includes.
13410
e43b6e43
MR
134112011-06-27 Martin Rudalics <rudalics@gmx.at>
13412
13413 * buffer.c (Qclone_number): Declare static and DEFSYM it.
13414 (sort_overlays, overlay_strings): When an overlay's clone number
13415 matches the window's clone number process the overlay even if
13416 the overlay's window property doesn't match the current window.
13417
d68443dc
MR
13418 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
13419 (Fwindow_hchild): Rename to Fwindow_left_child.
13420 (Fwindow_next): Rename to Fwindow_next_sibling.
13421 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
13422 (resize_window_check): Rename to window_resize_check.
13423 (resize_window_apply): Rename to window_resize_apply.
13424 (Fresize_window_apply): Rename to Fwindow_resize_apply.
13425 (Fdelete_other_windows_internal, resize_frame_windows)
13426 (Fsplit_window_internal, Fdelete_window_internal)
13427 (grow_mini_window, shrink_mini_window)
13428 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 13429
c7e73be5
JD
134302011-06-26 Jan Djärv <jan.h.d@swipnet.se>
13431
13432 * emacsgtkfixed.h: State that this is only used with Gtk+3.
13433 (emacs_fixed_set_min_size): Remove.
13434 (emacs_fixed_new): Take frame as argument.
13435
13436 * emacsgtkfixed.c: State that this is only used with Gtk+3.
13437 (_EmacsFixedPrivate): Remove minwidth/height.
13438 Add struct frame *f.
13439 (emacs_fixed_init): Initialize priv->f.
13440 (get_parent_class, emacs_fixed_set_min_size): Remove.
13441 (emacs_fixed_new): Set priv->f to argument.
13442 (emacs_fixed_get_preferred_width)
13443 (emacs_fixed_get_preferred_height): Use min_width/height from
13444 frames size_hint to set minimum and natural (Bug#8919).
13445 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
13446 and use min_width/height from frames size_hint to set
13447 min_width/height (Bug#8919).
13448
13449 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
13450 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
13451 Fix indentation.
c7e73be5 13452
cf99dcf8
EZ
134532011-06-26 Eli Zaretskii <eliz@gnu.org>
13454
13455 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
13456 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
13457 called at ZV.
13458
029529ac
CY
134592011-06-26 Chong Yidong <cyd@stupidchicken.com>
13460
13461 * process.c (wait_reading_process_output): Bypass select if
13462 waiting for a cell while ignoring keyboard input, and input is
13463 pending. Suggested by Jan Djärv (Bug#8869).
13464
7a7ef429
PE
134652011-06-25 Paul Eggert <eggert@cs.ucla.edu>
13466
13467 Use gnulib's dup2 module instead of rolling our own.
13468 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
13469
11fdef7d 134702011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
13471
13472 * dispnew.c (scrolling_window): Before scrolling, turn off a
13473 mouse-highlight in the window being scrolled.
13474
cd3520a4
JB
134752011-06-24 Juanma Barranquero <lekktu@gmail.com>
13476
13477 Move DEFSYM to lisp.h and use everywhere.
13478
13479 * character.h (DEFSYM): Move declaration...
13480 * lisp.h (DEFSYM): ...here.
13481
13482 * gnutls.c:
13483 * minibuf.c:
13484 * w32menu.c:
13485 * w32proc.c:
13486 * w32select.c: Don't include character.h.
13487
13488 * alloc.c (syms_of_alloc):
13489 * buffer.c (syms_of_buffer):
13490 * bytecode.c (syms_of_bytecode):
13491 * callint.c (syms_of_callint):
13492 * casefiddle.c (syms_of_casefiddle):
13493 * casetab.c (init_casetab_once):
13494 * category.c (init_category_once, syms_of_category):
13495 * ccl.c (syms_of_ccl):
13496 * cmds.c (syms_of_cmds):
13497 * composite.c (syms_of_composite):
13498 * dbusbind.c (syms_of_dbusbind):
13499 * dired.c (syms_of_dired):
13500 * dispnew.c (syms_of_display):
13501 * doc.c (syms_of_doc):
13502 * editfns.c (syms_of_editfns):
13503 * emacs.c (syms_of_emacs):
13504 * eval.c (syms_of_eval):
13505 * fileio.c (syms_of_fileio):
13506 * fns.c (syms_of_fns):
13507 * frame.c (syms_of_frame):
13508 * fringe.c (syms_of_fringe):
13509 * insdel.c (syms_of_insdel):
13510 * keymap.c (syms_of_keymap):
13511 * lread.c (init_obarray, syms_of_lread):
13512 * macros.c (syms_of_macros):
13513 * msdos.c (syms_of_msdos):
13514 * print.c (syms_of_print):
13515 * process.c (syms_of_process):
13516 * search.c (syms_of_search):
13517 * sound.c (syms_of_sound):
13518 * syntax.c (init_syntax_once, syms_of_syntax):
13519 * terminal.c (syms_of_terminal):
13520 * textprop.c (syms_of_textprop):
13521 * undo.c (syms_of_undo):
13522 * w32.c (globals_of_w32):
13523 * window.c (syms_of_window):
13524 * xdisp.c (syms_of_xdisp):
13525 * xfaces.c (syms_of_xfaces):
13526 * xfns.c (syms_of_xfns):
13527 * xmenu.c (syms_of_xmenu):
13528 * xsettings.c (syms_of_xsettings):
13529 * xterm.c (syms_of_xterm): Use DEFSYM.
13530
4228cf16
TZ
135312011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
13532
cd3520a4 13533 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 13534
7fcccf1e
PE
135352011-06-23 Paul Eggert <eggert@cs.ucla.edu>
13536
7efb4e0e
PE
13537 Integer and buffer overflow fixes (Bug#8873).
13538
ff5844ad
PE
13539 * print.c (printchar, strout): Check for string overflow.
13540 (PRINTPREPARE, printchar, strout):
13541 Don't set size unless allocation succeeds.
13542
90532f02
PE
13543 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
13544 for sizes. Check for string overflow more accurately.
13545 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
13546
6d84508d
PE
13547 * macros.c: Integer and buffer overflow fixes.
13548 * keyboard.h (struct keyboard.kbd_macro_bufsize):
13549 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
13550 Use ptrdiff_t, not int, for sizes.
13551 Don't increment bufsize until after realloc succeeds.
13552 Check for size-calculation overflow.
13553 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
13554
437b2cb4
PE
13555 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
13556
8b9ac8b4
PE
13557 * lread.c: Integer overflow fixes.
13558 (read_integer): Radix is now EMACS_INT, not int,
13559 to improve quality of diagnostics for out-of-range radices.
13560 Calculate buffer size correctly for out-of-range radices.
13561 (read1): Check for integer overflow in radices, and in
13562 read-circle numbers.
82cb60d3
PE
13563 (read_escape): Avoid int overflow.
13564 (Fload, openp, read_buffer_size, read1)
13565 (substitute_object_recurse, read_vector, read_list, map_obarray):
13566 Use ptrdiff_t, not int, for sizes.
13567 (read1): Use EMACS_INT, not int, for sizes.
20270765 13568 Check for size overflow.
8b9ac8b4 13569
7fcccf1e
PE
13570 * image.c (cache_image): Check for size arithmetic overflow.
13571
bfbbd7e7
PE
13572 * lread.c: Integer overflow issues.
13573 (saved_doc_string_size, saved_doc_string_length)
13574 (prev_saved_doc_string_size, prev_saved_doc_string_length):
13575 Now ptrdiff_t, not int.
13576 (read1): Don't assume doc string length fits in int. Check for
13577 out-of-range doc string lengths.
13578 (read_list): Don't assume file position fits in int.
39019e54 13579 (read_escape): Check for hex character overflow.
bfbbd7e7 13580
4e323265
LL
135812011-06-22 Leo Liu <sdl.web@gmail.com>
13582
13583 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
13584 Move to minibuffer.el.
13585
85fece3e
PE
135862011-06-22 Paul Eggert <eggert@cs.ucla.edu>
13587
20b84ce9 13588 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
13589 The following patches are for when GLYPH_DEBUG && !XASSERT.
13590 * dispextern.h (trace_redisplay_p, dump_glyph_string):
13591 * dispnew.c (flush_stdout):
13592 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
13593 Mark as externally visible.
13594 * dispnew.c (check_window_matrix_pointers): Now static.
13595 * dispnew.c (window_to_frame_vpos):
13596 * xfns.c (unwind_create_frame):
13597 * xterm.c (x_check_font): Remove unused local.
13598 * scroll.c (CHECK_BOUNDS):
13599 * xfaces.c (cache_fache): Rename local to avoid shadowing.
13600 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
13601 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
13602 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
13603 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
13604 Now static.
13605 (debug_method_add): Use va_list and vsprintf rather than relying
13606 on undefined behavior with wrong number of arguments.
13607 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
13608 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
13609 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
13610 since we're not interested in debugging glyphs with old libraries.
13611 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
13612 GCC 4.6.0's static checking.
13613
0766b489
PE
136142011-06-22 Paul Eggert <eggert@cs.ucla.edu>
13615
31fd4b32
PE
13616 Integer overflow and signedness fixes (Bug#8873).
13617 A few related buffer overrun fixes, too.
13618
b79e8648
PE
13619 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
13620
0766b489
PE
13621 * dispextern.h (struct face.stipple):
13622 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
13623 (x_bitmap_mask, x_allocate_bitmap_record)
13624 (x_create_bitmap_from_data, x_create_bitmap_from_file)
13625 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
13626 (x_create_bitmap_from_xpm_data):
13627 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
13628 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
13629 (.bitmaps_last):
13630 * xfaces.c (load_pixmap):
13631 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
13632 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
13633 (.bitmaps_last, struct x_output.icon_bitmap):
13634 Use ptrdiff_t, not int, for bitmap indexes.
13635 (x_allocate_bitmap_record): Check for size overflow.
13636 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
13637
b081724f
PE
13638 Use ptrdiff_t, not int, for overlay counts.
13639 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
13640 * editfns.c (overlays_around, get_pos_property):
13641 * textprop.c (get_char_property_and_overlay):
13642 * xdisp.c (next_overlay_change, note_mouse_highlight):
13643 * xfaces.c (face_at_buffer_position):
21514da7
PE
13644 * buffer.c (OVERLAY_COUNT_MAX): New macro.
13645 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
13646 (Fnext_overlay_change, Fprevious_overlay_change)
13647 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 13648 Use ptrdiff_t, not int, for sizes.
21514da7 13649 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 13650
3de73e5e
PE
13651 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
13652
2606c57b
PE
13653 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
13654 (x_session_initialize): Do not assume string length fits in int.
13655
aaafe47a
PE
13656 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
13657 This is unlikely, but can occur if DPI is outlandish.
13658
2674ddc8 13659 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
13660 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
13661
28154962
PE
13662 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
13663 * xrdb.c (magic_file_p, search_magic_path):
13664 Omit last arg SUFFIX; it was always 0. All callers changed.
13665 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
13666
7de51af5
PE
13667 * xfont.c (xfont_match): Avoid need for strlen.
13668
25ed6cc3
PE
13669 * xfns.c: Don't assume strlen fits in int.
13670 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
13671
4eab31dd
PE
13672 * xdisp.c (message_log_check_duplicate): Return intmax_t,
13673 not unsigned long, as we prefer signed integers. All callers changed.
13674 Detect integer overflow in repeat count.
13675 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 13676 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 13677
171e2a58
PE
13678 * termcap.c: Don't assume sizes fit in int and never overflow.
13679 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
13680 (gobble_line): Check for size-calculation overflow.
13681
ad39faca 13682 * minibuf.c (Fread_buffer):
6e5bb2dc 13683 * lread.c (intern, intern_c_string):
74ca2eb3
PE
13684 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
13685 Don't assume string length fits in int.
13686
52c61c22 13687 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
13688 * gtkutil.c (style_changed_cb): Avoid need for strlen.
13689
b5b8c9e5
PE
13690 * font.c: Don't assume string length fits in int.
13691 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
13692 Use ptrdiff_t, not int.
ccd6111c
PE
13693 (font_intern_prop): Don't assume string length fits in int.
13694 Don't assume integer property fits in fixnum.
13695 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 13696
882f0d81 13697 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 13698 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
13699 Reformulate so as not to need the command string.
13700 Invoke gzip -cd rather than gunzip, as it's more portable.
13701 (lock_info_type, lock_file_1, lock_file):
13702 Don't assume pid_t and time_t fit in unsigned long.
13703 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
13704 (current_lock_owner): Prefer signed type for sizes.
13705 Use memcpy, not strncpy, where memcpy is what is really wanted.
13706 Don't assume (via atoi) that time_t and pid_t fit in int.
13707 Check for time_t and/or pid_t out of range, e.g., via a network share.
13708 Don't alloca where an auto var works fine.
13709
93f4cf88
PE
13710 * fileio.c: Fix some integer overflow issues.
13711 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
13712 Don't assume string length fits in int.
13713 (directory_file_name): Don't assume string length fits in long.
13714 (make_temp_name): Don't assume pid fits in int, or that its print
13715 length is less than 20.
13716
f3e92b69
PE
13717 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
13718
1bfdaf10
PE
13719 * coding.c (make_subsidiaries): Don't assume string length fits in int.
13720
35016e9a
PE
13721 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
13722
3d1e65a1
PE
13723 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
13724 We prefer signed integers, even for size calculations.
13725
0b963a93
PE
13726 * emacs.c: Don't assume string length fits in 'int'.
13727 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
13728 (main): Don't invoke strlen when not needed.
13729
573f4b54
PE
13730 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
13731 (XD_DEBUG_MESSAGE): Don't waste a byte.
13732
989f33ba
PE
13733 * callproc.c (getenv_internal_1, getenv_internal)
13734 (Fgetenv_internal):
965d34eb
PE
13735 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
13736
e4d29b33
PE
13737 * lread.c (invalid_syntax): Omit length argument.
13738 All uses changed. This doesn't fix a bug, but it simplifies the
13739 code away from its former Hollerith-constant appearance, and it's
13740 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 13741 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 13742
eb49b136
PE
13743 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
13744 This didn't break anything, but it didn't help either.
13745 It's confusing to put a bogus integer in a place where the actual
13746 value does not matter.
9f62aeb1 13747 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 13748 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 13749
15375a22
PE
13750 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
13751 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
13752 implementation.
b61cc01c
PE
13753 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
13754 We prefer signed types, and the value cannot exceed the EMACS_INT
13755 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
13756 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
13757 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
13758 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 13759
53b2623d
PE
13760 * indent.c (sane_tab_width): New function.
13761 (current_column, scan_for_column, Findent_to, position_indentation)
13762 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 13763 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 13764
51cab52b 13765 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 13766
f2ed8a70
PE
13767 * lisp.h (lint_assume): New macro.
13768 * composite.c (composition_gstring_put_cache):
13769 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
13770
abe80cc6
PE
13771 * editfns.c, insdel.c:
13772 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 13773
b02c740e
PE
13774 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
13775
ebc96716
PE
13776 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
13777
b4e50fa0 13778 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 13779 Use much-faster test for byte-length change.
311d5d7c 13780 Don't assume string byte-length fits in 'int'.
a4cf38e4 13781 Check that character arg fits in 'int'.
85461888 13782 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 13783
c0c1ee9f
PE
13784 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
13785
a498d7f4
PE
13786 * fns.c (concat): Catch string overflow earlier.
13787 Do not rely on integer wraparound.
13788
51cab52b
PE
13789 * dispextern.h (struct it.overlay_strings_charpos)
13790 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
13791 * xdisp.c (forward_to_next_line_start)
13792 (back_to_previous_visible_line_start)
13793 (reseat_at_next_visible_line_start, next_element_from_buffer):
13794 Don't arbitrarily truncate the value of 'selective' to int.
13795
76031fad
PE
13796 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
13797
5eb55db9
PE
13798 * composite.c: Don't truncate sizes to 'int'.
13799 (composition_gstring_p, composition_reseat_it)
13800 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
13801 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
13802 not EMACS_UINT, for indexes.
5eb55db9 13803
0703a717
PE
13804 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
13805
d6202519
PE
13806 * buffer.c: Include <verify.h>.
13807 (struct sortvec.priority, struct sortstr.priority):
8961a454 13808 Now EMACS_INT, not int.
c20998a7 13809 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
13810 (struct sortstr.size, record_overlay_string)
13811 (struct sortstrlist.size, struct sortlist.used):
13812 Don't truncate size to int.
13813 (record_overlay_string): Check for size-calculation overflow.
d6202519 13814 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 13815
d5a19415
JM
138162011-06-22 Jim Meyering <meyering@redhat.com>
13817
029529ac 13818 Don't leak an XBM-image-sized buffer
d5a19415
JM
13819 * image.c (xbm_load): Free the image buffer after using it.
13820
a9041e6c
PE
138212011-06-21 Paul Eggert <eggert@cs.ucla.edu>
13822
13823 Port to Sun C.
13824 * composite.c (find_automatic_composition): Omit needless 'return 0;'
13825 that Sun C diagnosed.
13826 * fns.c (secure_hash): Fix pointer signedness issue.
13827 * intervals.c (static_offset_intervals): New function.
13828 (offset_intervals): Use it.
13829
7f3f739f
LL
138302011-06-21 Leo Liu <sdl.web@gmail.com>
13831
13832 * deps.mk (fns.o):
13833 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
13834 sha512.h.
13835
13836 * fns.c (secure_hash): Rename from crypto_hash_function and change
13837 the first arg to accept symbols.
5b66d427 13838 (Fsecure_hash): New primitive.
7f3f739f
LL
13839 (syms_of_fns): New symbols.
13840
76147d94
DD
138412011-06-20 Deniz Dogan <deniz@dogan.se>
13842
13843 * process.c (Fset_process_buffer): Clarify return value in
13844 docstring.
13845
7d7d0045
CY
138462011-06-18 Chong Yidong <cyd@stupidchicken.com>
13847
13848 * dispnew.c (add_window_display_history): Use BVAR.
13849
13850 * xdisp.c (debug_method_add): Use BVAR.
13851 (check_window_end, dump_glyph_matrix, dump_glyph)
13852 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
13853
13854 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
13855 Likewise.
13856
13857 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
13858 check till after the cache is created in init_frame_faces.
13859
ff2bc410
SM
138602011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
13861
13862 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
13863
28177add
PE
138642011-06-16 Paul Eggert <eggert@cs.ucla.edu>
13865
dd3482fe
PE
13866 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
13867 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
13868 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
13869
393d71f3 13870 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
13871 * fileio.c (Finsert_file_contents):
13872 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
13873 Remove the old (too-loose) buffer overflow checks.
13874 They weren't needed, since make_gap checks for buffer overflow.
13875 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
13876 The old code merely checked for Emacs fixnum overflow, and relied
13877 on undefined (wraparound) behavior. The new code avoids undefined
13878 behavior, and also checks for ptrdiff_t and/or size_t overflow.
13879
2e6813b0 13880 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
13881 Tune. Don't use wider integers than needed. Don't use alloca.
13882 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 13883
599a9e4f
PE
13884 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
13885
99561444
PE
13886 * insdel.c, lisp.h (buffer_overflow): New function.
13887 (insert_from_buffer_1, replace_range, replace_range_2):
13888 * insdel.c (make_gap_larger):
13889 * editfns.c (Finsert_char):
13890 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
13891
28177add
PE
13892 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
13893
e69dafad
PE
138942011-06-15 Paul Eggert <eggert@cs.ucla.edu>
13895
4baa020d 13896 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 13897
b1c46f02
PE
13898 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
13899 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
13900
e69dafad
PE
13901 * fileio.c: Don't assume EMACS_INT fits in off_t.
13902 (emacs_lseek): New static function.
13903 (Finsert_file_contents, Fwrite_region): Use it.
13904 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
13905
566684ea
PE
13906 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
13907
e6966cd6
PE
13908 * fns.c: Don't overflow int when computing a list length.
13909 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
13910 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
13911 truncation on 64-bit hosts. Check for QUIT every
13912 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
13913 faster and is responsive enough.
13914 (Flength): Report an error instead of overflowing an integer.
13915 (Fsafe_length): Return a float if the value is not representable
13916 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 13917 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 13918 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 13919
dd0b0efb
PE
13920 * alloc.c: Check that resized vectors' lengths fit in fixnums.
13921 (header_size, word_size): New constants.
13922 (allocate_vectorlike): Don't check size overflow here.
13923 (allocate_vector): Check it here instead, since this is the only
13924 caller of allocate_vectorlike that could cause overflow.
13925 Check that the new vector's length is representable as a fixnum.
13926
86fe5cfe
PE
13927 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
13928 The previous code was bogus. For example, next_almost_prime (32)
13929 returned 39, which is undesirable as it is a multiple of 3; and
13930 next_almost_prime (24) returned 25, which is a multiple of 5 so
13931 why was the code bothering to check for multiples of 7?
13932
80e88859
PE
13933 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
13934
4a2f0ad6
PE
13935 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
13936
f66c7cf8
PE
13937 Variadic C functions now count arguments with ptrdiff_t.
13938 This partly undoes my 2011-03-30 change, which replaced int with size_t.
13939 Back then I didn't know that the Emacs coding style prefers signed int.
13940 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
13941 were being counted with int, which may truncate counts on 64-bit
13942 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
13943 * lisp.h (struct Lisp_Subr.function.aMANY)
13944 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
13945 Arg counts are now ptrdiff_t, not size_t.
13946 All variadic functions and their callers changed accordingly.
13947 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
13948 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
13949 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
13950 * callint.c (Fcall_interactively): Check arg count for overflow,
13951 to avoid potential buffer overrun. Use signed char, not 'int',
13952 for 'varies' array, so that we needn't bother to check its size
13953 calculation for overflow.
13954 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
13955 * eval.c (apply_lambda):
13956 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
13957 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
13958 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
13959
a1759b76
PE
13960 * callint.c (Fcall_interactively): Don't use index var as event count.
13961
d96be9fc
PE
13962 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
13963 * mem-limits.h (SIZE): Remove; no longer used.
13964
a690a978 13965 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 13966
578c21e6
PE
13967 Remove unnecessary casts.
13968 * xterm.c (x_term_init):
13969 * xfns.c (x_set_border_pixel):
13970 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
13971 These aren't needed now that we assume ANSI C.
13972
96f53c6c
PE
13973 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
13974 It's more likely to cause problems (due to unsigned overflow)
13975 than to cure them.
13976
83c77d31
PE
13977 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
13978
ee2079f1
PE
13979 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
13980
6da65536
PE
13981 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
13982
7147c4a4
PE
13983 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
13984
193e32d9
PE
13985 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
13986
e5533da6
PE
13987 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
13988
9910e595
PE
13989 GLYPH_CODE_FACE returns EMACS_INT, not int.
13990 * dispextern.h (merge_faces):
13991 * xfaces.c (merge_faces):
01103c44
PE
13992 * xdisp.c (get_next_display_element, next_element_from_display_vector):
13993 Don't assume EMACS_INT fits in int.
9910e595 13994
2638320e
PE
13995 * character.h (CHAR_VALID_P): Remove unused parameter.
13996 * fontset.c, lisp.h, xdisp.c: All uses changed.
13997
045eb8d9
PE
13998 * editfns.c (Ftranslate_region_internal): Omit redundant test.
13999
c1f134b5
PE
14000 * fns.c (concat): Minor tuning based on overflow analysis.
14001 This doesn't fix any bugs. Use int to hold character, instead
14002 of constantly refetching from Emacs object. Use XFASTINT, not
14003 XINT, for value known to be a character. Don't bother comparing
14004 a single byte to 0400, as it's always less.
14005
395fcb93 14006 * floatfns.c (Fexpt):
327eeec8
PE
14007 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
14008
abbd3d23
PE
14009 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
14010 for characters.
14011
684a03ef
PE
14012 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
14013
0fed43f3
PE
14014 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
14015 Without this fix, on a 64-bit host (aset S 0 4294967386) would
14016 incorrectly succeed when S was a string, because 4294967386 was
14017 truncated before it was used.
14018
8fd02eb7
PE
14019 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
14020 Otherwise, an out-of-range integer could cause undefined behavior
14021 on a 64-bit host.
14022
f8c86b69
PE
14023 * composite.c: Use int, not EMACS_INT, for characters.
14024 (fill_gstring_body, composition_compute_stop_pos): Use int, not
14025 EMACS_INT, for values that are known to be in character range.
14026 This doesn't fix any bugs but is the usual style inside Emacs and
14027 may generate better code on 32-bit machines.
14028
34206dd2
PE
14029 Make sure a 64-bit char is never passed to ENCODE_CHAR.
14030 This is for reasons similar to the recent CHAR_STRING fix.
14031 * charset.c (Fencode_char): Check that character arg is actually
14032 a character. Pass an int to ENCODE_CHAR.
14033 * charset.h (ENCODE_CHAR): Verify that the character argument is no
14034 wider than 'int', as a compile-time check to prevent future regressions
14035 in this area.
14036
c5958d4c 14037 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
14038
14039 Make sure a 64-bit char is never passed to CHAR_STRING.
14040 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
14041 by silently ignoring the top 32 bits, allowing some values
14042 that were far too large to be valid characters.
14043 * character.h: Include <verify.h>.
14044 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
14045 arguments are no wider than unsigned, as a compile-time check
14046 to prevent future regressions in this area.
14047 * data.c (Faset):
01103c44 14048 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
14049 (Fsubst_char_in_region):
14050 * fns.c (concat):
14051 * xdisp.c (decode_mode_spec_coding):
14052 Adjust to CHAR_STRING's new requirement.
14053 * editfns.c (Finsert_char, Fsubst_char_in_region):
14054 * fns.c (concat): Check that character args are actually
14055 characters. Without this test, these functions did the wrong
14056 thing with wildly out-of-range values on 64-bit hosts.
14057
d37ca623
PE
14058 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
14059 These casts should not be needed on 32-bit hosts, either.
14060 * keyboard.c (read_char):
14061 * lread.c (Fload): Remove casts to unsigned.
14062
ea204efb
PE
14063 * lisp.h (UNSIGNED_CMP): New macro.
14064 This fixes comparison bugs on 64-bit hosts.
14065 (ASCII_CHAR_P): Use it.
14066 * casefiddle.c (casify_object):
01103c44 14067 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
14068 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
14069 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
14070 * dispextern.h (FACE_FROM_ID):
14071 * keyboard.c (read_char): Use UNSIGNED_CMP.
14072
41cb286c
PE
14073 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
14074 not to EMACS_INT, to avoid GCC warning.
14075
4a1b9832
PE
14076 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
14077
55daad71
PE
14078 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
14079 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
14080 isn't needed on 32-bit machines.
8f95c75c 14081
01103c44
PE
14082 * buffer.c (Fgenerate_new_buffer_name):
14083 Use EMACS_INT for count, not int.
0ceccced 14084 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
14085
14086 * data.c (Qcompiled_function): Now static.
14087
c6f072e7
PE
14088 * window.c (window_body_lines): Now static.
14089
20ce5912
PE
14090 * image.c (gif_load): Rename local to avoid shadowing.
14091
9c4c5f81
PE
14092 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
14093 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
14094 * alloc.c (make_save_value): Integer argument is now of type
14095 ptrdiff_t, not int.
14096 (mark_object): Use ptrdiff_t, not int.
14097 * lisp.h (pD): New macro.
14098 * print.c (print_object): Use it.
14099
c0c5c8ae
PE
14100 * alloc.c: Use EMACS_INT, not int, to count objects.
14101 (total_conses, total_markers, total_symbols, total_vector_size)
14102 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
14103 (total_free_floats, total_floats, total_free_intervals)
14104 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
14105 Now EMACS_INT, not int. All uses changed.
14106 (Fgarbage_collect): Compute overall total using a double, so that
14107 integer overflow is less likely to be a problem. Check for overflow
14108 when converting back to an integer.
5a25e253
PE
14109 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
14110 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
14111 These were 'int' variables that could overflow on 64-bit hosts;
14112 they were never used, so remove them instead of repairing them.
211a0b2a 14113 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
14114 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
14115 Previously, this ceilinged at INT_MAX, but that doesn't work on
14116 64-bit machines.
e46bb31a 14117 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 14118
c78baabf 14119 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 14120 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
14121 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
14122 when a (possibly-narrower) signed value would do just as well.
14123 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 14124
c9d624c6
PE
14125 * alloc.c: Catch some string size overflows that we were missing.
14126 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
14127 for convenience in STRING_BYTES_MAX.
14128 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
14129 The definition here is exact; the one in lisp.h was approximate.
14130 (allocate_string_data): Check for string overflow. This catches
14131 some instances we weren't catching before. Also, it catches
14132 size_t overflow on (unusual) hosts where SIZE_MAX <= min
14133 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
14134 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 14135
c9d624c6
PE
14136 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
14137 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 14138 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 14139
353032ce
PE
14140 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
14141
2bccce07
PE
14142 * alloc.c (Fmake_string): Check for out-of-range init.
14143
0ac30604
SM
141442011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
14145
14146 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
14147
c195f2de
JD
141482011-06-14 Jan Djärv <jan.h.d@swipnet.se>
14149
14150 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
14151 xg_get_default_scrollbar_width.
14152
14153 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
14154 (int_gtk_range_get_value): Move to the scroll bar part of the file.
14155 (style_changed_cb): Call update_theme_scrollbar_width and call
14156 x_set_scroll_bar_default_width and xg_frame_set_char_size for
14157 all frames (Bug#8505).
14158 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
14159 Call gtk_window_set_resizable if HAVE_GTK3.
14160 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
14161 and height if HAVE_GTK3 (Bug#8505).
14162 (scroll_bar_width_for_theme): New variable.
14163 (update_theme_scrollbar_width): New function.
14164 (xg_get_default_scrollbar_width): Move code to
14165 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
14166 (xg_initialize): Call update_theme_scrollbar_width.
14167
14168 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
14169
14170 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
14171
e10ac9f1
MR
141722011-06-12 Martin Rudalics <rudalics@gmx.at>
14173
14174 * frame.c (make_frame): Call other_buffer_safely instead of
14175 other_buffer.
14176
14177 * window.c (temp_output_buffer_show): Call display_buffer with
14178 second argument Vtemp_buffer_show_specifiers and reset latter
14179 immediately after the call.
14180 (Vtemp_buffer_show_specifiers): New variable.
14181 (auto_window_vscroll_p, next_screen_context_lines)
14182 (Vscroll_preserve_screen_position): Remove leading asterisks from
14183 doc-strings.
14184
2d3c217e 141852011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 14186
7b7f97e8 14187 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
14188 * buffer.c (Qclone_number): Remove for now, as it's unused.
14189 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
14190 (record_buffer): Remove unused local.
14191 * frame.c (other_visible_frames, frame_buffer_list): Now static.
14192 (set_frame_buffer_list): Remove; unused.
14193 * frame.h (other_visible_frames): Remove decl.
14194 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
14195 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
14196 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
14197 if HAVE_GPM.
14198 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
14199 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
14200 Define only if HAVE_GPM.
14201 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
14202 (update_hints_inhibit): Remove; never set. All uses removed.
14203 * widgetprv.h (emacsFrameClassRec): Remove decl.
14204 * window.c (delete_deletable_window): Now returns void, since it
14205 wasn't returning anything.
14206 (compare_window_configurations): Remove unused locals.
14207 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
14208 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
14209 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
14210 the same widths as pointers. This follows up on the 2011-05-06 patch.
14211 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
14212 * xterm.h: Likewise.
14213 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
14214
1384b89e
JB
142152011-06-12 Juanma Barranquero <lekktu@gmail.com>
14216
14217 * makefile.w32-in: Update dependencies.
14218 (LISP_H): Add lib/intprops.h.
14219
1100a63c
CY
142202011-06-11 Chong Yidong <cyd@stupidchicken.com>
14221
14222 * image.c (gif_load): Add animation frame delay to the metadata.
14223 (syms_of_image): Use DEFSYM. New symbol `delay'.
14224
6198ccd0
MR
142252011-06-11 Martin Rudalics <rudalics@gmx.at>
14226
14227 * window.c (delete_deletable_window): Re-add.
14228 (Fset_window_configuration): Rewrite to handle dead buffers and
14229 consequently deletable windows.
14230 (window_tree, Fwindow_tree): Remove. Supply functionality in
14231 window.el.
14232 (compare_window_configurations): Simplify code.
14233
b6e3633c
AS
142342011-06-11 Andreas Schwab <schwab@linux-m68k.org>
14235
1ab0dee5
AS
14236 * image.c (imagemagick_load_image): Fix type mismatch.
14237 (Fimagemagick_types): Likewise.
14238
b6e3633c
AS
14239 * window.h (replace_buffer_in_windows): Declare.
14240
9397e56f
MR
142412011-06-11 Martin Rudalics <rudalics@gmx.at>
14242
14243 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
14244 Qclone_number. Remove external declaration of Qdelete_window.
14245 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
14246 code.
640c8776
SM
14247 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
14248 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
14249 (Fother_buffer): Rewrite doc-string. Major rewrite for new
14250 buffer list implementation.
14251 (other_buffer_safely): New function.
14252 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
14253 calls to replace_buffer_in_windows and
14254 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
14255 if allowed.
14256 (record_buffer): Inhibit quitting and rewrite using quittable
14257 functions. Run Qbuffer_list_update_hook if allowed.
14258 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
14259 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
14260 Move switch-to-buffer to window.el.
9397e56f
MR
14261 (bury-buffer): Move to window.el.
14262 (Vbuffer_list_update_hook): New variable.
14263
14264 * lisp.h (other_buffer_safely): Add prototype in buffer.c
14265 section.
14266
14267 * window.h (resize_frame_windows): Move up in code.
14268 (Fwindow_frame): Remove EXFUN.
14269 (replace_buffer_in_all_windows): Remove prototype.
14270 (replace_buffer_in_windows_safely): Add prototype.
14271
14272 * window.c: Declare Qdelete_window static again. Move down
14273 declaration of select_count.
14274 (Fnext_window, Fprevious_window): Rewrite doc-strings.
14275 (Fother_window): Move to window.el.
14276 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
14277 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
14278 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
14279 window.el.
14280 (replace_buffer_in_windows): Implement by calling
14281 Qreplace_buffer_in_windows.
14282 (replace_buffer_in_all_windows): Remove with some functionality
14283 moved into replace_buffer_in_windows_safely.
14284 (replace_buffer_in_windows_safely): New function.
14285 (select_window_norecord, select_frame_norecord): Move in front
14286 of run_window_configuration_change_hook. Remove now obsolete
14287 declarations.
640c8776
SM
14288 (Fset_window_buffer): Rewrite doc-string.
14289 Call Qrecord_window_buffer.
9397e56f
MR
14290 (keys_of_window): Move binding for other-window to window.el.
14291
b50691aa
CY
142922011-06-11 Chong Yidong <cyd@stupidchicken.com>
14293
14294 * dispextern.h (struct image): Replace data member, whose int_val
14295 and ptr_val fields were not used by anything, with a single
14296 lisp_val object.
14297
14298 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
14299 (gif_clear_image, gif_load, imagemagick_load_image)
14300 (gs_clear_image, gs_load): Callers changed.
14301
3f754b86
PE
143022011-06-10 Paul Eggert <eggert@cs.ucla.edu>
14303
cca69397
PE
14304 * buffer.h: Include <time.h>, for time_t.
14305 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
14306
109e28d0
PE
14307 Fix minor problems found by static checking.
14308
60737f02
PE
14309 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
14310
4b66faf3
PE
14311 Make identifiers static if they are not used in other modules.
14312 * data.c (Qcompiled_function, Qframe, Qvector):
14313 * image.c (QimageMagick, Qsvg):
14314 * minibuf.c (Qmetadata):
14315 * window.c (resize_window_check, resize_root_window): Now static.
14316 * window.h (resize_window_check, resize_root_window): Remove decls.
14317
109e28d0
PE
14318 * window.c (window_deletion_count, delete_deletable_window):
14319 Remove; unused.
46a4ce9e
PE
14320 (window_body_lines): Now static.
14321 (Fdelete_other_windows_internal): Mark vars as initialized.
14322 Make sure 'resize_failed' is initialized.
14323 (run_window_configuration_change_hook): Rename local to avoid shadowing.
14324 (resize_window_apply): Remove unused local.
14325 * window.h (delete_deletable_window): Remove decl.
14326
109e28d0 14327 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
14328 (imagemagick_load_image): Fix pointer signedness problem by changing
14329 last arg from unsigned char * to char *. All uses changed.
14330 Also, fix a local for similar reasons.
14331 Remove unused locals. Remove locals to avoid shadowing.
14332 (fn_rsvg_handle_free): Remove; unused.
14333 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 14334 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 14335
3f754b86
PE
14336 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
14337
2547adb1
CY
143382011-06-10 Chong Yidong <cyd@stupidchicken.com>
14339
14340 * image.c (gif_load): Fix omitted cast error introduced by
14341 2011-06-06 change.
14342
2c8e37d4
MR
143432011-06-10 Martin Rudalics <rudalics@gmx.at>
14344
14345 * window.h (resize_proportionally, orig_total_lines)
14346 (orig_top_line): Remove from window structure.
14347 (set_window_height, set_window_width, change_window_heights)
14348 (Fdelete_window): Remove prototypes.
14349 (resize_frame_windows): Remove duplicate declaration.
14350
440a42e3
EZ
143512011-06-10 Eli Zaretskii <eliz@gnu.org>
14352
14353 * window.h (resize_frame_windows, resize_window_check)
14354 (delete_deletable_window, resize_root_window)
14355 (resize_frame_windows): Declare prototypes.
14356
14357 * window.c (resize_window_apply): Make definition be "static" to
14358 match the prototype.
14359
562dd5e9
MR
143602011-06-10 Martin Rudalics <rudalics@gmx.at>
14361
14362 * window.c: Remove declarations of Qwindow_size_fixed,
14363 window_min_size_1, window_min_size_2, window_min_size,
14364 size_window, window_fixed_size_p, enlarge_window, delete_window.
14365 Remove static from declaration of Qdelete_window, it's
14366 temporarily needed by Fbury_buffer.
14367 (replace_window): Don't assign orig_top_line and
14368 orig_total_lines.
14369 (Fdelete_window, delete_window): Remove. Window deletion is
14370 handled by window.el.
640c8776
SM
14371 (window_loop): Remove DELETE_OTHER_WINDOWS case.
14372 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
14373 (Fdelete_other_windows): Remove. Deleting other windows is
14374 handled by window.el.
14375 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
14376 handled in window.el.
14377 (window_min_size_2, window_min_size_1, window_min_size): Remove.
14378 Window minimum sizes are handled in window.el.
14379 (shrink_windows, size_window, set_window_height)
14380 (set_window_width, change_window_heights, window_height)
14381 (window_width, CURBEG, CURSIZE, enlarge_window)
14382 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
14383 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
14384 handled in window.el.
14385 (make_dummy_parent): Rename to make_parent_window and give it a
14386 second argument horflag.
14387 (make_window): Don't set resize_proportionally any more.
14388 (Fsplit_window): Remove. Windows are split in window.el.
14389 (save_restore_action, save_restore_orig_size)
14390 (shrink_window_lowest_first, save_restore_orig_size): Remove.
14391 Resize mini windows in window.el.
14392 (grow_mini_window, shrink_mini_window): Implement by calling
14393 Qresize_root_window_vertically, resize_window_check and
14394 resize_window_apply.
640c8776
SM
14395 (saved_window, Fset_window_configuration, save_window_save):
14396 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
14397 resize_proportionally.
14398 (window_min_height, window_min_width): Move to window.el.
14399 (keys_of_window): Move bindings for delete-other-windows,
14400 split-window, delete-window and enlarge-window to window.el.
14401
14402 * buffer.c: Temporarily extern Qdelete_window.
14403 (Fbury_buffer): Temporarily call Qdelete_window instead of
14404 Fdelete_window (Fbury_buffer will move to window.el soon).
14405
14406 * frame.c (set_menu_bar_lines_1): Remove code handling
14407 orig_top_line and orig_total_lines.
14408
14409 * dispnew.c (adjust_frame_glyphs_initially): Don't use
14410 set_window_height but set heights directly.
14411 (change_frame_size_1): Use resize_frame_windows.
14412
14413 * xdisp.c (init_xdisp): Don't use set_window_height but set
14414 heights directly.
14415
640c8776
SM
14416 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
14417 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
14418 run_window_configuration_change_hook.
14419
14420 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
14421 instead of change_window_heights and run
14422 run_window_configuration_change_hook.
14423
1a13852e
MR
144242011-06-09 Martin Rudalics <rudalics@gmx.at>
14425
14426 * window.c (replace_window): Rename second argument REPLACEMENT to
14427 NEW. New third argument SETFLAG. Rewrite.
14428 (delete_window, make_dummy_parent): Call replace_window with
14429 third argument 1.
14430 (window_list_1): Move down in code.
14431 (run_window_configuration_change_hook): Move set_buffer part
14432 before select_frame_norecord part in order to unwind correctly.
14433 Rename count1 to count.
14434 (recombine_windows, delete_deletable_window, resize_root_window)
14435 (Fdelete_other_windows_internal)
14436 (Frun_window_configuration_change_hook, make_parent_window)
14437 (resize_window_check, resize_window_apply, Fresize_window_apply)
14438 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
14439 (Fdelete_window_internal, Fresize_mini_window_internal):
14440 New functions.
1a13852e
MR
14441 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
14442
f3d1777e
MR
144432011-06-08 Martin Rudalics <rudalics@gmx.at>
14444
496e208e
MR
14445 * window.h (window): Add some new members to window structure -
14446 normal_lines, normal_cols, new_total, new_normal, clone_number,
14447 splits, nest, prev_buffers, next_buffers.
14448 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 14449 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 14450
f3d1777e
MR
14451 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
14452 Remove.
496e208e
MR
14453 (make_dummy_parent): Set new members of windows structure.
14454 (make_window): Move down in code. Handle new members of window
14455 structure.
14456 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
14457 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
14458 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
14459 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
14460 (Fset_window_next_buffers, Fset_window_clone_number):
14461 New functions.
496e208e
MR
14462 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
14463 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
14464 Doc-string fixes.
14465 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
14466 Argument WINDOW can be now internal window too.
14467 (Fwindow_use_time): Move up in code.
14468 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
14469 Rewrite doc-string.
14470 (Fset_window_configuration, saved_window)
14471 (Fcurrent_window_configuration, save_window_save): Handle new
14472 members of window structure.
b9e809c2
MR
14473 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
14474 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
14475 (syms_of_window): New Lisp objects Qrecord_window_buffer,
14476 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
14477 Qget_mru_window, Qresize_root_window,
14478 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
14479 Qauto_buffer_name; staticpro them.
f3d1777e 14480
abde8f8c
MR
144812011-06-07 Martin Rudalics <rudalics@gmx.at>
14482
14483 * window.c (Fwindow_total_size, Fwindow_left_column)
14484 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
14485 (Fwindow_list_1): New functions.
14486 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
14487 (Fwindow_width, Fscroll_left, Fscroll_right):
14488 Use window_body_cols instead of window_box_text_cols.
14489 (delete_window, Fset_window_configuration):
14490 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
14491 (delete_all_subwindows): Take a window as argument and not a
14492 structure. Rewrite.
190b47e6
MR
14493 (window_loop): Remove handling of GET_LRU_WINDOW and
14494 GET_LARGEST_WINDOW.
14495 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
14496
14497 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
14498 window_box_text_cols. delete_all_subwindows now takes a
14499 Lisp_Object as argument.
abde8f8c 14500
640c8776
SM
14501 * indent.c (compute_motion, Fcompute_motion):
14502 Use window_body_cols instead of window_box_text_cols.
abde8f8c 14503
fa8a67e6
MR
14504 * frame.c (delete_frame): Call delete_all_subwindows with root
14505 window as argument.
14506
a54e3482
DC
145072011-06-07 Daniel Colascione <dan.colascione@gmail.com>
14508
14509 * fns.c (Fputhash): Document return value.
14510
60002bf5
CY
145112011-06-06 Chong Yidong <cyd@stupidchicken.com>
14512
14513 * image.c (gif_load): Implement gif89a spec "no disposal" method.
14514
0c671da6 145152011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 14516
b862a52a 14517 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 14518
be44ca6c
PE
14519 Check for overflow when converting integer to cons and back.
14520 * charset.c (Fdefine_charset_internal, Fdecode_char):
14521 Use cons_to_unsigned to catch overflow.
14522 (Fencode_char): Use INTEGER_TO_CONS.
14523 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
14524 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
14525 * data.c (long_to_cons, cons_to_long): Remove.
14526 (cons_to_unsigned, cons_to_signed): New functions.
14527 These signal an error for invalid or out-of-range values.
14528 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
14529 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
14530 * font.c (Ffont_variation_glyphs):
14531 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
14532 * lisp.h: Include <intprops.h>.
14533 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
14534 (cons_to_signed, cons_to_unsigned): New decls.
14535 (long_to_cons, cons_to_long): Remove decls.
14536 * undo.c (record_first_change): Use INTEGER_TO_CONS.
14537 (Fprimitive_undo): Use CONS_TO_INTEGER.
14538 * xfns.c (Fx_window_property): Likewise.
14539 * xselect.c: Include <limits.h>.
14540 (x_own_selection, selection_data_to_lisp_data):
14541 Use INTEGER_TO_CONS.
14542 (x_handle_selection_request, x_handle_selection_clear)
14543 (x_get_foreign_selection, Fx_disown_selection_internal)
14544 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
14545 (lisp_data_to_selection_data): Use cons_to_unsigned.
14546 (x_fill_property_data): Use cons_to_signed.
14547 Report values out of range.
14548
d1f3d2af
PE
14549 Check for buffer and string overflow more precisely.
14550 * buffer.h (BUF_BYTES_MAX): New macro.
14551 * lisp.h (STRING_BYTES_MAX): New macro.
14552 * alloc.c (Fmake_string):
14553 * character.c (string_escape_byte8):
14554 * coding.c (coding_alloc_by_realloc):
14555 * doprnt.c (doprnt):
14556 * editfns.c (Fformat):
14557 * eval.c (verror):
14558 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
14559 since they may not be the same number.
14560 * editfns.c (Finsert_char):
14561 * fileio.c (Finsert_file_contents):
14562 Likewise for BUF_BYTES_MAX.
14563
dd52fcea
PE
14564 * image.c: Use ptrdiff_t, not int, for sizes.
14565 (slurp_file): Switch from int to ptrdiff_t.
14566 All uses changed.
14567 (slurp_file): Check that file size fits in both size_t (for
14568 malloc) and ptrdiff_t (for sanity and safety).
14569
7f9bbdbb
PE
14570 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
14571 if b->modtime has its maximal value.
14572
dfe18f82
PE
14573 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
14574
84acfcf0
PE
14575 Don't assume time_t can fit into int.
14576 * buffer.h (struct buffer.modtime): Now time_t, not int.
14577 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
14578 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
14579
ccd9a01a
PE
14580 Minor fixes for signed vs unsigned integers.
14581 * character.h (MAYBE_UNIFY_CHAR):
14582 * charset.c (maybe_unify_char):
14583 * keyboard.c (read_char, reorder_modifiers):
14584 XINT -> XFASTINT, since the integer must be nonnegative.
14585 * ftfont.c (ftfont_spec_pattern):
14586 * keymap.c (access_keymap, silly_event_symbol_error):
14587 XUINT -> XFASTINT, since the integer must be nonnegative.
14588 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
14589 since it makes no difference and we prefer signed.
14590 * keyboard.c (record_char): Use XUINT when all the neighbors do.
14591 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
14592 nonnegative.
14593
d6d100dd
SM
145942011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
14595
14596 * window.h (Fwindow_frame): Declare.
14597
2b6148e4
PE
145982011-06-06 Paul Eggert <eggert@cs.ucla.edu>
14599
14600 * alloc.c: Simplify handling of large-request failures (Bug#8800).
14601 (SPARE_MEMORY): Always define.
14602 (LARGE_REQUEST): Remove.
14603 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
14604
f230ecc9
MR
146052011-06-06 Martin Rudalics <rudalics@gmx.at>
14606
727e958e
MR
14607 * lisp.h: Move EXFUNS for Fframe_root_window,
14608 Fframe_first_window and Fset_frame_selected_window to window.h.
14609
14610 * window.h: Move EXFUNS for Fframe_root_window,
14611 Fframe_first_window and Fset_frame_selected_window here from
14612 lisp.h.
14613
14614 * frame.c (Fwindow_frame, Fframe_first_window)
14615 (Fframe_root_window, Fframe_selected_window)
14616 (Fset_frame_selected_window): Move to window.c.
14617 (Factive_minibuffer_window): Move to minibuf.c.
14618 (Fother_visible_frames_p): New function.
14619
14620 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
14621
f230ecc9
MR
14622 * window.c (decode_window, decode_any_window): Move up in code.
14623 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
14624 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
14625 (Fwindow_buffer): Move up and rewrite doc-string.
14626 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
14627 (Fwindow_prev): New functions.
727e958e
MR
14628 (Fwindow_frame): Move here from frame.c. Accept any window as
14629 argument.
14630 (Fframe_root_window, Fframe_first_window)
14631 (Fframe_selected_window): Move here from frame.c. Accept frame
14632 or arbitrary window as argument. Update doc-strings.
14633 (Fminibuffer_window): Move up in code.
14634 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
14635 (Fset_frame_selected_window): Move here from frame.c.
14636 Marginal rewrite.
727e958e
MR
14637 (Fselected_window, select_window, Fselect_window): Move up in
14638 code. Minor doc-string fixes.
f230ecc9 14639
4d09bcf6
PE
146402011-06-06 Paul Eggert <eggert@cs.ucla.edu>
14641
14642 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
14643 Do not assume that spare memory exists; that assumption is valid
14644 only if SYSTEM_MALLOC.
14645 (LARGE_REQUEST): New macro, so that the issue of large requests
14646 is separated from the issue of spare memory.
14647
810928a2
AS
146482011-06-05 Andreas Schwab <schwab@linux-m68k.org>
14649
172418ad
AS
14650 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
14651 format. (Bug#8806)
14652
43f862f7
AS
14653 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
14654
810928a2
AS
14655 * xfns.c (x_set_scroll_bar_default_width): Move declarations
14656 before statements.
14657
a059fe24
JD
146582011-06-05 Jan Djärv <jan.h.d@swipnet.se>
14659
14660 * gtkutil.c (xg_get_default_scrollbar_width): New function.
14661
14662 * gtkutil.h: Declare xg_get_default_scrollbar_width.
14663
14664 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
14665 min width by calling x_set_scroll_bar_default_width (Bug#8505).
14666
989bf368
JB
146672011-06-05 Juanma Barranquero <lekktu@gmail.com>
14668
14669 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
14670
4b80f674
CY
146712011-06-04 Chong Yidong <cyd@stupidchicken.com>
14672
14673 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
14674 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
14675 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
14676 New error handlers.
4b80f674
CY
14677 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
14678 Obey Vx_select_enable_clipboard_manager. Catch errors in
14679 x_clipboard_manager_save (Bug#8779).
14680 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 14681 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 14682
99a33b77 146832011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
14684
14685 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
14686
99a33b77 146872011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
14688
14689 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
14690 in the current matrix if keep_current_p is non-zero.
14691
8264569d
EZ
146922011-06-04 Eli Zaretskii <eliz@gnu.org>
14693
14694 * bidi.c (bidi_level_of_next_char): Fix last change.
14695
57f97249
EZ
146962011-06-03 Eli Zaretskii <eliz@gnu.org>
14697
fec2107c 14698 Support bidi reordering of text covered by display properties.
57f97249 14699
fec2107c
EZ
14700 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
14701 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
14702 (bidi_cache_search, bidi_cache_iterator_state)
14703 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
14704 (bidi_level_of_next_char, bidi_move_to_visually_next):
14705 Support character positions inside a run of characters covered by a
fec2107c
EZ
14706 display string.
14707 (bidi_paragraph_init, bidi_resolve_explicit_1)
14708 (bidi_level_of_next_char): Call bidi_fetch_char and
14709 bidi_fetch_char_advance instead of FETCH_CHAR and
14710 FETCH_CHAR_ADVANCE.
14711 (bidi_init_it): Initialize new members.
14712 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
14713 definitions.
14714 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
14715 instead of using explicit *_CHAR codes.
d6d100dd
SM
14716 (bidi_resolve_explicit, bidi_resolve_weak):
14717 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
14718 bidirectional text is supported only in multibyte buffers.
14719 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
14720 it to initialize the frame_window_p member of struct bidi_it.
14721 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
14722 (bidi_resolve_explicit, bidi_resolve_weak)
14723 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
14724 bidi_it->nchars is non-positive.
14725 (bidi_level_of_next_char): Don't try to lookup the cache for the
14726 next/previous character if nothing is cached there yet, or if we
14727 were just reseat()'ed to a new position.
c40e2fb2 14728
0e14fe90
EZ
14729 * xdisp.c (set_cursor_from_row): Set start and stop points
14730 according to the row's direction when priming the loop that looks
14731 for the glyph on which to display cursor.
14732 (single_display_spec_intangible_p): Function deleted.
14733 (display_prop_intangible_p): Reimplement to call
14734 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
14735 Accept 3 additional arguments needed by handle_display_spec.
14736 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
14737 values: lists, `(when COND...)' forms, etc.
14738 (single_display_spec_string_p): Support property values that are
14739 lists with the argument STRING its top-level element.
14740 (display_prop_string_p): Fix the condition for processing a
14741 property that is a list to be consistent with handle_display_spec.
fec2107c 14742 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
14743 last portion of handle_display_prop.
14744 (compute_display_string_pos): Accept additional argument
14745 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
14746 value of a `display' property is a "replacing spec".
14747 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
14748 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
14749 the display property, but just return a value indicating whether
14750 the display property will replace the characters it covers.
14751 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
14752 frame_window_p members of struct bidi_it.
d6d100dd
SM
14753 (compute_display_string_pos, compute_display_string_end):
14754 New functions.
fec2107c
EZ
14755 (push_it): Accept second argument POSITION, where pop_it should
14756 jump to continue iteration.
14757 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 14758
fec2107c
EZ
14759 * keyboard.c (adjust_point_for_property): Adjust the call to
14760 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
14761
14762 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
14763 (bidi_init_it): Update prototypes.
14764 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
14765 (compute_display_string_pos, compute_display_string_end):
14766 Declare prototypes.
fec2107c
EZ
14767 (struct bidi_it): New members nchars and disp_pos. ch_len is now
14768 EMACS_INT.
fc6f18ce 14769
40087514 147702011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 14771
57f53182
PE
14772 Malloc failure behavior now depends on size of allocation.
14773 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
14774 * lisp.h: Change signatures accordingly.
14775 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
14776 All callers changed. (Bug#8762)
14777
14778 * gnutls.c: Use Emacs's memory allocators.
14779 Without this change, the gnutls library would invoke malloc etc.
14780 directly, which causes problems on non-SYNC_INPUT hosts, and which
14781 runs afoul of improving memory_full behavior. (Bug#8761)
14782 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
14783 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
14784 xfree instead of the default malloc, realloc, free.
14785 (Fgnutls_boot): No need to check for memory allocation failure,
14786 since xmalloc does that for us.
14787
ac32cd99 14788 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
14789 * category.c (hash_get_category_set):
14790 * ccl.c (ccl_driver):
14791 * charset.c (Fdefine_charset_internal):
14792 * charset.h (struct charset.hash_index):
14793 * composite.c (get_composition_id, gstring_lookup_cache)
14794 (composition_gstring_put_cache):
14795 * composite.h (struct composition.hash_index):
14796 * dispextern.h (struct image.hash):
14797 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
14798 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
14799 (hashfn_equal, hashfn_user_defined, make_hash_table)
14800 (maybe_resize_hash_table, hash_lookup, hash_put)
14801 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
14802 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
14803 (Fsxhash, Fgethash, Fputhash, Fmaphash):
14804 * image.c (make_image, search_image_cache, lookup_image)
14805 (xpm_put_color_table_h):
14806 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 14807 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 14808 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 14809 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
14810 * alloc.c (allocate_vectorlike):
14811 Check for overflow in vector size calculations.
14812 * ccl.c (ccl_driver):
14813 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
14814 * fns.c, image.c: Remove unnecessary static decls that would otherwise
14815 need to be updated by these changes.
40087514
PE
14816 * fns.c (make_hash_table, maybe_resize_hash_table):
14817 Check for integer overflow with large hash tables.
0de4bb68
PE
14818 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
14819 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
14820 (SXHASH_REDUCE): New macro.
14821 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
14822 Use it instead of discarding useful hash info with large hash values.
14823 (sxhash_float): New function.
14824 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
14825 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
14826 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
14827 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
14828 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
14829 Adjust signatures to match updated version of code.
14830 (consing_since_gc): Now EMACS_INT, since a single hash table can
14831 use more than INT_MAX bytes.
14832
698d32e2
DN
148332011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
14834
14835 Make it possible to build with GCC-4.6+ -O2 -flto.
14836
14837 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
14838
fd6fa53f
SM
148392011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
14840
14841 * minibuf.c (get_minibuffer, read_minibuf_unwind):
14842 Call minibuffer-inactive-mode.
14843
864db017
JB
148442011-05-31 Juanma Barranquero <lekktu@gmail.com>
14845
14846 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
14847 Update dependencies.
14848
2ad0baf4
DN
148492011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
14850
14851 * data.c (init_data): Remove code for UTS, this system is not
14852 supported anymore.
14853
4fcc2638
DN
148542011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
14855
14856 Don't force ./temacs to start in terminal mode.
14857
14858 * frame.c (make_initial_frame): Initialize faces in all cases, not
14859 only when CANNOT_DUMP is defined.
14860 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
14861
c56e0fd5
DN
148622011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
14863
14864 * dispnew.c (add_window_display_history): Use const for the string
14865 pointer. Remove declaration, not needed.
14866
333d54da 148672011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 14868
55d4c1b2 14869 Use 'inline', not 'INLINE'.
333d54da 14870 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
14871 * alloc.c, fontset.c (INLINE): Remove.
14872 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
14873 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
14874 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
14875 * gmalloc.c (register_heapinfo): Use inline unconditionally.
14876 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
14877
738db178
DN
148782011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
14879
14880 Make it possible to run ./temacs.
14881
14882 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
14883 syms_of_callproc does the same thing. Remove test for
14884 "initialized", do it in the caller.
14885 * emacs.c (main): Avoid calling set_initial_environment when dumping.
14886
620c53a6
SM
148872011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
14888
14889 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
14890 (read_minibuf): Use get_minibuffer.
14891 (syms_of_minibuf): Use DEFSYM.
14892 (Qmetadata): New var.
14893 * data.c (Qbuffer): Don't make it static.
14894 (syms_of_data): Use DEFSYM.
14895
e003a292
PE
148962011-05-31 Paul Eggert <eggert@cs.ucla.edu>
14897
14898 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
14899 (CCL_CODE_MIN): New macro.
14900
ed008a6d
PE
149012011-05-30 Paul Eggert <eggert@cs.ucla.edu>
14902
3687c2ef
PE
14903 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
14904
ed008a6d
PE
14905 * eval.c (Qdebug): Now static.
14906 * lisp.h (Qdebug): Remove decl. This reverts a part of the
14907 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
14908 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
14909
d66c4c7c
CY
149102011-05-29 Chong Yidong <cyd@stupidchicken.com>
14911
14912 * image.c: Various fixes to ImageMagick code comments.
14913 (Fimagemagick_types): Doc fix.
14914
5fbc2025
PE
149152011-05-29 Paul Eggert <eggert@cs.ucla.edu>
14916
0196f88a
PE
14917 Minor fixes prompted by GCC 4.6.0 warnings.
14918
14919 * xselect.c (converted_selections, conversion_fail_tag): Now static.
14920
5fbc2025
PE
14921 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
14922 (x_clipboard_manager_save_all): Move extern decl to ...
14923 * xterm.h: ... here, so that it can be checked for consistency.
14924
1dd3c2d9
CY
149252011-05-29 Chong Yidong <cyd@stupidchicken.com>
14926
14927 * xselect.c (x_clipboard_manager_save_frame)
14928 (x_clipboard_manager_save_all): New functions.
14929 (Fx_clipboard_manager_save): Lisp function deleted.
14930
14931 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
14932 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
14933
14934 * xterm.h: Update prototype.
14935
5ba6571d
WX
149362011-05-28 William Xu <william.xwl@gmail.com>
14937
14938 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
14939 exiting (Bug#8239).
14940
3eaff834
JM
149412011-05-28 Jim Meyering <meyering@redhat.com>
14942
e1900994 14943 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
14944 * fns.c (to_uchar): Define.
14945 (crypto_hash_function): Use it to convert some newly-signed
14946 variables to unsigned, to avoid sign-extension bugs. For example,
14947 without this change, (md5 "truc") would evaluate to
14948 45723a2aff78ff4fff7fff1114760e62 rather than the expected
14949 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 14950 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 14951
0f6990a7
PE
149522011-05-27 Paul Eggert <eggert@cs.ucla.edu>
14953
14954 Integer overflow fixes.
c8a9ca5a 14955
08686060
PE
14956 * dbusbind.c: Serial number integer overflow fixes.
14957 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
14958 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
14959 to hold a serial number that is too large for a fixnum.
14960 (Fdbus_method_return_internal, Fdbus_method_error_internal):
14961 Check for serial numbers out of range. Decode any serial number
59568bf0 14962 that was so large that it became a float. (Bug#8722)
08686060 14963
2d1fc3c7
PE
14964 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
14965 (Fdbus_call_method, Fdbus_call_method_asynchronously):
14966 Use XFASTINT rather than XUINT when numbers are nonnegative.
14967 (xd_append_arg, Fdbus_method_return_internal):
14968 (Fdbus_method_error_internal): Likewise. Also, for unsigned
14969 arguments, check that Lisp number is nonnegative, rather than
59568bf0 14970 silently wrapping negative numbers around. (Bug#8722)
30217ff0 14971 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 14972 (Bug#8722)
2d1fc3c7 14973
c8a9ca5a
PE
14974 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
14975
519e1d69
PE
14976 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
14977
6df6ae42 14978 ccl: Add integer overflow checks.
30569699
PE
14979 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
14980 (IN_INT_RANGE): New macros.
14981 (ccl_driver): Use them to check for integer overflow when
14982 decoding a CCL program. Many of the new checks are whether XINT (x)
14983 fits in int; it doesn't always, on 64-bit hosts. The new version
14984 doesn't catch all possible integer overflows, but it's an
847044ea 14985 improvement. (Bug#8719)
30569699 14986
c11285dc
PE
14987 * alloc.c (make_event_array): Use XINT, not XUINT.
14988 There's no need for unsigned here.
14989
fdccd48e
PE
14990 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
14991 This follows up to the 2011-05-06 change that substituted uintptr_t
14992 for EMACS_INT. This case wasn't caught back then.
14993
37910ab2
PE
14994 Rework Fformat to avoid integer overflow issues.
14995 * editfns.c: Include <float.h> unconditionally, as it's everywhere
14996 now (part of C89). Include <verify.h>.
14997 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
14998 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
14999 (Fformat): Avoid the prepass trying to compute sizes; it was only
15000 approximate and thus did not catch overflow reliably. Instead, walk
15001 through the format just once, formatting and computing sizes as we go,
15002 checking for integer overflow at every step, and allocating a larger
15003 buffer as needed. Keep track separately whether the format is
15004 multibyte. Keep only the most-recently calculated precision, rather
15005 than them all. Record whether each argument has been converted to
15006 string. Use EMACS_INT, not int, for byte and char and arg counts.
15007 Support field widths and precisions larger than INT_MAX. Avoid
15008 sprintf's undefined behavior with conversion specifications such as %#d
15009 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
15010 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
15011 formatting out-of-range floating point numbers with int
9173deec 15012 formats. (Bug#8668)
37910ab2 15013
2e6578fb
PE
15014 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
15015
0ae6bdee
PE
15016 * data.c: Avoid integer truncation in expressions involving floats.
15017 * data.c: Include <intprops.h>.
15018 (arith_driver): When there's an integer overflow in an expression
15019 involving floating point, convert the integers to floating point
15020 so that the resulting value does not suffer from catastrophic
15021 integer truncation. For example, on a 64-bit host (* 4
15022 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
15023 Do not rely on undefined behavior after integer overflow.
15024
de883a70
PE
15025 merge count_size_as_multibyte, parse_str_to_multibyte
15026 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 15027 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
15028 Check for integer overflow.
15029 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
15030 since it's now a duplicate of the other. This is more of
15031 a character than a buffer op, so better that it's in character.c.
15032 * fns.c, print.c: Adjust to above changes.
15033
2ff916cb
PE
150342011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
15035
15036 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
15037
f1b54466
PE
150382011-05-27 Paul Eggert <eggert@cs.ucla.edu>
15039
fb1ac845
PE
15040 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
15041 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
15042 (x_clipboard_manager_save): Now static.
15043 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
15044
f1b54466
PE
15045 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
15046 (crypto_hash_function): Now static.
15047 Fix pointer signedness problems. Avoid unnecessary initializations.
15048
a9f737ee
CY
150492011-05-27 Chong Yidong <cyd@stupidchicken.com>
15050
15051 * termhooks.h (Vselection_alist): Make it terminal-local.
15052
15053 * terminal.c (create_terminal): Initialize it.
15054
15055 * xselect.c: Support for clipboard managers.
15056 (Vselection_alist): Move to termhooks.h as terminal-local var.
15057 (LOCAL_SELECTION): New macro.
15058 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
15059 (symbol_to_x_atom): Remove gratuitous arg.
15060 (x_handle_selection_request, lisp_data_to_selection_data)
15061 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
15062 (x_own_selection, x_get_local_selection, x_convert_selection):
15063 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
15064 (some_frame_on_display): Delete unused function.
15065 (Fx_own_selection_internal, Fx_get_selection_internal)
15066 (Fx_disown_selection_internal, Fx_selection_owner_p)
15067 (Fx_selection_exists_p): New optional frame arg.
15068 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
15069 (x_handle_selection_clear): Don't treat other terminals with the
15070 same keyboard specially. Use the terminal-local Vselection_alist.
15071 (x_clear_frame_selections): Use Frun_hook_with_args.
15072
15073 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
15074
15075 * xterm.h: Add support for those atoms.
15076
e067f0c1
CY
150772011-05-26 Chong Yidong <cyd@stupidchicken.com>
15078
15079 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
15080 (converted_selections, conversion_fail_tag): New global variables.
15081 (x_selection_request_lisp_error): Free the above.
15082 (x_get_local_selection): Remove unnecessary code.
15083 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
15084 of converted selections stored in converted_selections.
15085 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
15086 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
15087 (x_convert_selection): New function.
15088 (x_handle_selection_event): Simplify.
15089 (x_get_foreign_selection): Don't ignore incoming requests while
15090 waiting for an answer; this will fail when we implement
15091 SAVE_TARGETS, and seems unnecessary anyway.
15092 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
15093 (Vx_sent_selection_functions): Doc fix.
15094
0f4aebc0
LL
150952011-05-26 Leo Liu <sdl.web@gmail.com>
15096
15097 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
15098
e61124cd
YM
150992011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
15100
15101 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
15102
15103 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
15104 for fringe update if it has periodic bitmap.
ac389d0c 15105 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
15106 and fringe_bitmap_periodic_p.
15107
15108 * fringe.c (get_fringe_bitmap_data): New function.
15109 (draw_fringe_bitmap_1, update_window_fringes): Use it.
15110 (update_window_fringes): Record periodicity of fringe bitmap in glyph
15111 row. Mark glyph row for fringe update if periodicity changed.
15112
15113 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
15114 for fringe update unless it has periodic bitmap.
15115
f16d9837
KH
151162011-05-25 Kenichi Handa <handa@m17n.org>
15117
15118 * xdisp.c (get_next_display_element): Set correct it->face_id for
15119 a static composition.
15120
e1b90ef6
LL
151212011-05-24 Leo Liu <sdl.web@gmail.com>
15122
15123 * deps.mk (fns.o):
15124 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
15125
15126 * fns.c (crypto_hash_function, Fsha1): New function.
15127 (Fmd5): Use crypto_hash_function.
15128 (syms_of_fns): Add Ssha1.
15129
7400048f
PE
151302011-05-22 Paul Eggert <eggert@cs.ucla.edu>
15131
15132 * gnutls.c: Remove unused macros.
15133 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
15134 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
15135 Remove macros that are defined and never used.
15136 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
15137
abb71cf4
CY
151382011-05-22 Chong Yidong <cyd@stupidchicken.com>
15139
15140 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
15141 (Fx_get_selection_internal): Minor cleanup.
15142 (Fx_own_selection_internal): Rename arguments for consistency with
15143 select.el.
15144
6307db39
PE
151452011-05-22 Paul Eggert <eggert@cs.ucla.edu>
15146
15147 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
15148
f3d4e0a4
CY
151492011-05-22 Chong Yidong <cyd@stupidchicken.com>
15150
15151 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
15152
4d8ade89
YM
151532011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
15154
15155 * dispnew.c (scrolling_window): Don't exclude the case that the
15156 last enabled row in the desired matrix touches the bottom boundary.
15157
32078c8d
GM
151582011-05-21 Glenn Morris <rgm@gnu.org>
15159
15160 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
15161 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
15162 and add some more files.
32078c8d 15163
7285dc67
EZ
151642011-05-20 Eli Zaretskii <eliz@gnu.org>
15165
15166 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
15167 report_file_error introduced by the change from 2011-05-07.
15168
89d1bd22
PE
151692011-05-20 Paul Eggert <eggert@cs.ucla.edu>
15170
15171 * systime.h (Time): Define only if emacs is defined.
15172 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
15173 where the include path doesn't have X11/X.h by default. See
15174 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
15175
cd394be1 151762011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
15177
15178 * composite.c (find_automatic_composition): Fix previous change.
15179
b9704ad9
GM
151802011-05-20 Glenn Morris <rgm@gnu.org>
15181
15182 * lisp.mk: New file, split from Makefile.in.
15183 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
15184 (shortlisp): Remove.
15185 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
15186
4a720484
GM
151872011-05-19 Glenn Morris <rgm@gnu.org>
15188
15189 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
15190 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
15191 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
15192 (lisp): Set the order to that of loadup.el.
15193 (shortlisp): Make it a copy of $lisp.
15194 (SOME_MACHINE_LISP): Remove.
15195 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
15196 Use just $shortlisp, not $SOME_MACHINE_LISP too.
15197
a28d4396
KH
151982011-05-18 Kenichi Handa <handa@m17n.org>
15199
15200 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
15201 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
15202 (find_automatic_composition): Mostly rewrite for efficiency.
15203
a2b1fa8e
JB
152042011-05-18 Juanma Barranquero <lekktu@gmail.com>
15205
15206 * makefile.w32-in: Update dependencies.
15207
8e1f5610
CS
152082011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
15209
15210 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 15211 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 15212
7025ee00 152132011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 15214
cdfa6eab
PE
15215 Fix some integer overflow issues, such as string length overflow.
15216
06d6db33
PE
15217 * insdel.c (count_size_as_multibyte): Check for string overflow.
15218
2b4560a8
PE
15219 * character.c (lisp_string_width): Check for string overflow.
15220 Use EMACS_INT, not int, for string indexes and lengths; in
15221 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
15222 the resulting string length overflows an EMACS_INT; instead,
15223 report a string overflow if no precision given. When checking for
15224 precision exhaustion, use a check that cannot possibly have
15225 integer overflow. (Bug#8675)
15226 * character.h (lisp_string_width): Adjust to new signature.
15227
cb93f9be
PE
15228 * alloc.c (string_overflow): New function.
15229 (Fmake_string): Use it. This doesn't change behavior, but saves
15230 a few bytes and will simplify future changes.
15231 * character.c (string_escape_byte8): Likewise.
15232 * lisp.h (string_overflow): New decl.
15233
1a1f3366
PE
15234 Fixups, following up to the user-interface timestamp change.
15235 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
15236 for UI timestamps, instead of unsigned long.
9fbd6841
PE
15237 * msdos.c (mouse_get_pos): Likewise.
15238 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
15239 * w32gui.h (Time): Define by including "systime.h" rather than by
15240 declaring it ourselves. (Bug#8664)
15241
d4e3e4d3
PE
15242 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
15243 * image.c (clear_image_cache): Likewise.
15244
f6a24d19
PE
15245 * term.c (term_mouse_position): Don't assume time_t wraparound.
15246
08dc5ae6
PE
15247 Be more systematic about user-interface timestamps.
15248 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
15249 and sometimes 'EMACS_UINT', to represent these timestamps.
15250 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
15251 This makes the code easier to follow, and makes it easier to catch
15252 integer overflow bugs such as Bug#8664.
15253 * frame.c (Fmouse_position, Fmouse_pixel_position):
15254 Use Time, not unsigned long, for user-interface timestamps.
15255 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
15256 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
15257 * keyboard.h (last_event_timestamp): Likewise.
15258 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
15259 * menu.h (xmenu_show): Likewise.
15260 * term.c (term_mouse_position): Likewise.
15261 * termhooks.h (struct input_event.timestamp): Likewise.
15262 (struct terminal.mouse_position_hook): Likewise.
15263 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
15264 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
15265 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
15266 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
15267 what it was before.
15268 * menu.h, termhooks.h: Include "systime.h", for Time.
15269
8e55734a
PE
15270 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
15271 Don't assume that the difference between two unsigned long values
15272 can fit into an integer. At this point, we know button_down_time
15273 <= event->timestamp, so the difference must be nonnegative, so
15274 there's no need to cast the result if double-click-time is
15275 nonnegative, as it should be; check that it's nonnegative, just in
15276 case. This bug is triggered when events are more than 2**31 ms
86db42d2 15277 apart (about 25 days). (Bug#8664)
8e55734a 15278
841f1b75 15279 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 15280 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 15281
3e26f69c
PE
15282 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
15283 that always fit in int. Use a sentinel instead of a counter, to
15284 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
15285 * frame.h (struct frame): Use int for menu_bar_items_used
15286 instead of EMACS_INT, since it always fits in int.
3e26f69c 15287
5cc152c0
PE
15288 * menu.c (grow_menu_items): Check for int overflow.
15289
d89eb65e
PE
15290 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
15291
5235bd3e
PE
15292 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
15293 Before, the code was not consistent. These values cannot exceed
15294 2**31 - 1 so there's no need to make them unsigned.
15295 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
15296 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
15297 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
15298 as modifiers.
15299 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
15300
bc827e23
PE
15301 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
15302 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
15303 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
15304 presumably because the widths might not match.
15305
78eb494e
PE
15306 * window.c (size_window): Avoid needless test at loop start.
15307
04f2d78b
CB
153082011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
15309
15310 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
15311
d2fc7e3d 153122011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
15313
15314 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
15315
d2fc7e3d 153162011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
15317
15318 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
15319 `width' to `bar_area_x' and `bar_area_width', respectively.
15320 (x_scroll_run): Take account of fringe background extension.
15321
04f2d78b
CB
15322 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
15323 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
15324 `bar_area_width', respectively.
15325 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
15326 background extension.
15327
79b70037
GM
153282011-05-10 Jim Meyering <meyering@redhat.com>
15329
15330 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
15331
2f142cc5
JB
153322011-05-10 Juanma Barranquero <lekktu@gmail.com>
15333
15334 * image.c (Finit_image_library): Return t for built-in image types,
15335 like pbm and xbm. (Bug#8640)
15336
57679c86
AS
153372011-05-09 Andreas Schwab <schwab@linux-m68k.org>
15338
15339 * w32menu.c (set_frame_menubar): Fix submenu allocation.
15340
888c9e86
EZ
153412011-05-07 Eli Zaretskii <eliz@gnu.org>
15342
b0512a1d
EZ
15343 * w32console.c (Fset_screen_color): Doc fix.
15344 (Fget_screen_color): New function.
15345 (syms_of_ntterm): Defsubr it.
15346
7285dc67
EZ
15347 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
15348 unlink the temporary file if Fcall_process didn't create it in the
15349 first place.
15350 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
15351 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
15352 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
15353 cue to call_process_cleanup not to close that handle.
15354
4d3fcc8e
BK
153552011-05-07 Ben Key <bkey76@gmail.com>
15356
15357 * makefile.w32-in: The bootstrap-temacs rule now makes use of
15358 one of two shell specific rules, either bootstrap-temacs-CMD or
15359 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
15360 to the previous implementation of the bootstrap-temacs rule.
15361 The bootstrap-temacs-CMD rule is similar to the previous
15362 implementation of the bootstrap-temacs rule except that it
15363 makes use of the ESC_CFLAGS variable instead of the CFLAGS
15364 variable.
15365
15366 These changes, along with some changes to nt/configure.bat,
15367 nt/gmake.defs, and nt/nmake.defs, are required to extend my
15368 earlier fix to add support for --cflags and --ldflags options
15369 that include quotes so that it works whether make uses cmd or
15370 sh as the shell.
15371
b4289b64
MA
153722011-05-06 Michael Albinus <michael.albinus@gmx.de>
15373
15374 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
15375 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
15376 is a constant.
15377 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
15378 a string. Handle both cases.
15379 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
15380 (Fdbus_register_method): Use Qinvalid_function.
15381
af4c0e28
JB
153822011-05-06 Juanma Barranquero <lekktu@gmail.com>
15383
15384 * makefile.w32-in: Update dependencies.
15385 (LISP_H): Add inttypes.h and stdin.h.
15386 (PROCESS_H): Add unistd.h.
15387
c51453d9
EZ
153882011-05-06 Eli Zaretskii <eliz@gnu.org>
15389
15390 * lread.c: Include limits.h (fixes the MS-Windows build broken by
15391 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
15392
8ff0ac3c 153932011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 15394
4c4b566b
PE
15395 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
15396
aab2b9b5
PE
15397 * term.c (vfatal): Remove stray call to va_end.
15398 It's not needed and the C Standard doesn't allow it here anyway.
15399
c378da0b
PE
15400 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
15401 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
15402
288b08c7
PE
15403 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
15404 bytes.
15405
e3601888
PE
15406 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
15407
db6c0e74
PE
15408 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
15409
dd5963ea
PE
15410 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
15411
88c9450f
PE
15412 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
15413
2f9442b8
PE
15414 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
15415
c032b5f8
PE
15416 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
15417 * charset.c (Fdefine_charset_internal): Don't initialize
15418 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 15419 32-bit int (Bug#8600).
a108c10b
PE
15420
15421 * lread.c (read_integer): Be more consistent with string-to-number.
15422 Use string_to_number to do the actual conversion; this avoids
15423 rounding errors and fixes some other screwups. Without this fix,
15424 for example, #x1fffffffffffffff was misread as -2305843009213693952.
15425 (digit_to_number): Move earlier, for benefit of read_integer.
15426 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 15427 not a digit in any supported base. (Bug#8602)
a108c10b 15428
ad5f9eea
PE
15429 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
15430
aec1708a
PE
15431 * dispnew.c (scrolling_window): Return 1 if we scrolled,
15432 to match comment at start of function. This also removes a
15433 GCC warning about overflow in a 32+64-bit port.
15434
47be4ab5
PE
15435 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
15436
371cac43
PE
15437 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
15438 Reported by Stefan Monnier in
15439 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
15440 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
15441 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 15442
d01a7826
PE
15443 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
15444 (EMACS_UINTPTR): Likewise, with uintptr_t.
15445
7fd47d5c
PE
15446 * lisp.h: Prefer 64-bit EMACS_INT if available.
15447 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
15448 on 32-bit hosts that have 64-bit int, so that they can access
15449 large files.
122b0c86
PE
15450 However, temporarily disable this change unless the temporary
15451 symbol WIDE_EMACS_INT is defined.
7fd47d5c 15452
8727937b
PE
15453 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
15454
8ac068ac
PE
15455 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
15456 This removes an assumption that EMACS_INT and long are the same
15457 width as pointers. The assumption is true for Emacs porting targets
15458 now, but we want to make other targets possible.
15459 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
15460 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
15461 In the rest of the code, change types of integers that hold casted
15462 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
15463 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
15464 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
15465 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
15466 No need to cast type when ORing.
15467 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
15468 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
15469 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
15470 assume EMACS_INT is the same width as char *.
15471 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
15472 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
15473 Remove no-longer-needed casts.
15474 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
15475 (xg_tool_bar_help_callback, xg_make_tool_item):
15476 Use EMACS_INTPTR to hold an integer
15477 that will be cast to void *; this can avoid a GCC warning
15478 if EMACS_INT is not the same width as void *.
15479 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
15480 * xdisp.c (display_echo_area_1, resize_mini_window_1):
15481 (current_message_1, set_message_1):
15482 Use a local to convert to proper width without a cast.
15483 * xmenu.c (dialog_selection_callback): Likewise.
15484
ede49d71
PE
15485 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
15486 Also, don't assume VALBITS / RAND_BITS is less than 5,
15487 and don't rely on undefined behavior when shifting a 1 left into
15488 the sign bit.
15489 * lisp.h (get_random): Change signature to match.
15490
2f30ecd0
PE
15491 * lread.c (hash_string): Use size_t, not int, for hash computation.
15492 Normally we prefer signed values; but hashing is special, because
15493 it's better to use unsigned division on hash table sizes so that
15494 the remainder is nonnegative. Also, size_t is the natural width
15495 for hashing into memory. The previous code used 'int', which doesn't
15496 retain enough info to hash well into very large tables.
15497 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
15498
2a866e7b
PE
15499 * dbusbind.c: Don't possibly lose pointer info when converting.
15500 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
15501 Use XPNTR rather than XHASH, so that the high-order bits of
15502 the pointer aren't lost when converting through void *.
15503
51639eac
PE
15504 * eval.c (Fautoload): Don't double-shift a pointer.
15505
92394119
PE
15506 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
15507
dbdb9a7c
JB
155082011-05-06 Juanma Barranquero <lekktu@gmail.com>
15509
15510 * gnutls.c (DEF_GNUTLS_FN):
15511 * image.c (DEF_IMGLIB_FN): Make function pointers static.
15512
db7a0b4f
AS
155132011-05-05 Andreas Schwab <schwab@linux-m68k.org>
15514
15515 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
15516 marker. (Bug#8610)
15517
cd394be1 155182011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
15519
15520 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
15521 New version that can reserve upto 2GB of heap space.
15522
f7ff1b0f 155232011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
15524
15525 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
15526
639c109b
TZ
155272011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
15528
15529 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
15530 `gnutls_certificate_set_x509_key_file'.
15531
d2127135
JB
155322011-05-05 Juanma Barranquero <lekktu@gmail.com>
15533
15534 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
15535 Update dependencies.
15536
e968f4f3
JB
155372011-05-04 Juanma Barranquero <lekktu@gmail.com>
15538
15539 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
15540 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
15541 Remove unused parameter `fildes'.
15542 * process.c (read_process_output, send_process): Don't pass it.
15543
84d358f0
JB
155442011-05-04 Juanma Barranquero <lekktu@gmail.com>
15545
15546 Fix previous change: the library cache is defined in w32.c.
15547 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
15548 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
15549
0898ca10
JB
155502011-05-04 Juanma Barranquero <lekktu@gmail.com>
15551
15552 Implement dynamic loading of GnuTLS on Windows.
15553
15554 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
15555 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
15556 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
15557 Declare.
15558
15559 * gnutls.c (Qgnutls_dll): Define.
15560 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
15561 (gnutls_*): Declare function pointers.
15562 (init_gnutls_functions): New function to initialize function pointers.
15563 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
15564 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
15565 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
15566 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
15567 (emacs_gnutls_write, emacs_gnutls_read)
15568 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
15569 (Fgnutls_available_p): New function.
15570 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
15571 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
15572 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
15573
15574 * image.c: Include w32.h.
15575 (Vimage_type_cache): Delete.
15576 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
15577 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
15578 (w32_delayed_load): Move to w32.c.
15579
15580 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
15581
15582 * w32.c (QCloaded_from, Vlibrary_cache): Define.
15583 (w32_delayed_load): Move from image.c. When loading a library, record
15584 its filename in the :loaded-from property of the library id.
15585 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
15586 Initialize and staticpro them.
15587 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
15588
15589 * process.c: Include lisp.h before w32.h, not after.
15590 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
15591 instead of gnutls_record_check_pending.
15592
15593 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
15594
ff4de4aa
TZ
155952011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
15596
15597 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
15598 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
15599 as passed in.
15600
abe95abb
JD
156012011-05-03 Jan Djärv <jan.h.d@swipnet.se>
15602
15603 * xterm.c (x_set_frame_alpha): Do not set property on anything
15604 else than FRAME_X_OUTER_WINDOW (Bug#8608).
15605
e16e55d4
JB
156062011-05-02 Juanma Barranquero <lekktu@gmail.com>
15607
15608 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
15609
bafcf6a5
JB
156102011-05-02 Juanma Barranquero <lekktu@gmail.com>
15611
15612 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
15613 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
15614 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
15615 (gnutls_global_initialized, Qgnutls_bootprop_priority)
15616 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
15617 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
15618 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
15619 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
15620 (Qgnutls_bootprop_callbacks_verify): Make static.
15621
e7a6747f
AS
156222011-05-01 Andreas Schwab <schwab@linux-m68k.org>
15623
19ed11ba
AS
15624 * callproc.c: Indentation fixup.
15625
e7a6747f 15626 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
15627 (wait_for_termination, interruptible_wait_for_termination):
15628 Move after wait_for_termination_1.
e7a6747f 15629
1ef14cb4
LMI
156302011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
15631
15632 * sysdep.c (interruptible_wait_for_termination): New function
15633 which is like wait_for_termination, but allows keyboard
15634 interruptions.
15635
15636 * callproc.c (Fcall_process): Add (:file "file") as an option for
15637 the STDOUT buffer.
15638 (Fcall_process_region): Ditto.
15639
330d880c
EZ
156402011-04-30 Eli Zaretskii <eliz@gnu.org>
15641
8db90b73
EZ
15642 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
15643 rather than `XVECTOR (FOO)->size'.
15644
330d880c
EZ
15645 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
15646 inttypes.h, as a gnulib replacement is used if it not available in
15647 system headers.
15648
15cbd324
EZ
156492011-04-21 Eli Zaretskii <eliz@gnu.org>
15650
15651 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
15652 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
15653 of MOST_POSITIVE_FIXNUM. (Bug#8528)
15654
15655 * coding.c (coding_alloc_by_realloc): Error out if destination
15656 will grow beyond MOST_POSITIVE_FIXNUM.
15657 (decode_coding_emacs_mule): Abort if there isn't enough place in
15658 charbuf for the composition carryover bytes. Reserve an extra
15659 space for up to 2 characters produced in a loop.
15660 (decode_coding_iso_2022): Abort if there isn't enough place in
15661 charbuf for the composition carryover bytes.
15662
156632011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 15664
ae940cca
EZ
15665 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
15666 aborting when %lld or %lll format is passed.
15667 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
15668 %llo or %llx format is passed. (Bug#8545)
15669
03ab8921
EZ
15670 * window.c (window_scroll_line_based): Use a marker instead of
15671 simple variables to record original value of point. (Bug#7952)
15672
afda1437
EZ
15673 * doprnt.c (doprnt): Fix the case where a multibyte sequence
15674 produced by %s or %c overflows available buffer space. (Bug#8545)
15675
f76dee0c
PE
156762011-04-28 Paul Eggert <eggert@cs.ucla.edu>
15677
15678 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 15679 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 15680
fdc5744d
JB
156812011-04-28 Juanma Barranquero <lekktu@gmail.com>
15682
15683 * w32.c (init_environment): Warn about defaulting HOME to C:\.
15684
638f053a
JB
156852011-04-28 Juanma Barranquero <lekktu@gmail.com>
15686
15687 * keyboard.c (Qdelayed_warnings_hook): Define.
15688 (command_loop_1): Run `delayed-warnings-hook'
15689 if Vdelayed_warnings_list is non-nil.
15690 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
15691 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
15692
d178f871
EZ
156932011-04-28 Eli Zaretskii <eliz@gnu.org>
15694
15695 * doprnt.c (doprnt): Don't return value smaller than the buffer
15696 size if the message was truncated. (Bug#8545).
15697
b124fd93
JB
156982011-04-28 Juanma Barranquero <lekktu@gmail.com>
15699
15700 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
15701 (Fx_window_property): #if-0 the whole functions, not just the bodies.
15702
e810457d
PE
157032011-04-27 Paul Eggert <eggert@cs.ucla.edu>
15704
15705 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
15706
ea51cceb
JB
157072011-04-27 Juanma Barranquero <lekktu@gmail.com>
15708
15709 * makefile.w32-in: Update dependencies.
15710
94dcfacf
EZ
157112011-04-27 Eli Zaretskii <eliz@gnu.org>
15712
15713 Improve `doprnt' and its usage. (Bug#8545)
15714 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
15715 `format_end'. Remove support for %l as a conversion specifier.
15716 Don't use xrealloc. Improve diagnostics when the %l size modifier
15717 is used. Update the commentary.
15718
15719 * eval.c (verror): Simplify calculation of size_t.
15720
15721 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
15722 messages.
15723
f61f41d7
PE
157242011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
15725
15726 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
15727 change.
15728
96fb4434
PE
157292011-04-27 Paul Eggert <eggert@cs.ucla.edu>
15730
15731 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
15732 This makes this file independent of the recent pseudovector change.
15733
671875da 157342011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 15735
69e9b5a3
PE
15736 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
15737
b5f869a7 15738 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 15739 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 15740 Remove unused local.
c8926152 15741 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 15742
841a1577 15743 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
15744 GCC 4.6.0 optimizes based on type-based alias analysis.
15745 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
15746 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
15747 != &v->size, and therefore "v->size = 1; b->size = 2; return
15748 v->size;" must therefore return 1. This assumption is incorrect
15749 for Emacs, since it type-puns struct Lisp_Vector * with many other
15750 types. To fix this problem, this patch adds a new type struct
f904488f 15751 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
15752 and pseudovectors, and helps optimizing compilers not get fooled
15753 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
15754 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
15755 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
15756 the size member.
eab3844f
PE
15757 (XSETPVECTYPE): Rewrite in terms of new macro.
15758 (XSETPVECTYPESIZE): New macro, specifying both type and size.
15759 This is a bit clearer, and further avoids the possibility of
15760 undesirable aliasing.
15761 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 15762 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
15763 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
15764 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
15765 (ASIZE): Now uses header.size rather than size.
15766 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
15767 to avoid the hassle of writing XVECTOR (foo)->header.size.
15768 (struct vectorlike_header): New type.
eab3844f
PE
15769 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
15770 object, to help avoid aliasing.
15771 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
15772 (SUBRP): Likewise, since Lisp_Subr is a special case.
15773 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
15774 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
15775 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 15776 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
15777 changed to be "header.size" and "header.next".
15778 * buffer.h (struct buffer): Likewise.
15779 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
15780 * frame.h (struct frame): Likewise.
15781 * process.h (struct Lisp_Process): Likewise.
15782 * termhooks.h (struct terminal): Likewise.
15783 * window.c (struct save_window_data, struct saved_window): Likewise.
15784 * window.h (struct window): Likewise.
15785 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
15786 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
15787 * buffer.c (init_buffer_once): Likewise.
15788 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
15789 special case.
15790 * process.c (Fformat_network_address): Use local var for size,
15791 for brevity.
15792
0df1eac5
PE
15793 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
15794
847ab9d1 15795 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
15796 * data.c (atof): Remove decl; no longer used or needed.
15797 (digit_to_number): Move to lread.c.
15798 (Fstring_to_number): Use new string_to_number function, to be
15799 consistent with how the Lisp reader treats infinities and NaNs.
15800 Do not assume that floating-point numbers represent EMACS_INT
15801 without losing information; this is not true on most 64-bit hosts.
15802 Avoid double-rounding errors, by insisting on integers when
15803 parsing non-base-10 numbers, as the documentation specifies.
15804 * lisp.h (string_to_number): New decl, replacing ...
15805 (isfloat_string): Remove.
bc0a5c13 15806 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 15807 (read1): Do not accept +. and -. as integers; this
452f4150
PE
15808 appears to have been a coding error. Similarly, do not accept
15809 strings like +-1e0 as floating point numbers. Do not report
15810 overflow for integer overflows unless the base is not 10 which
15811 means we have no simple and reliable way to continue.
15812 Break out the floating-point parsing into a new
15813 function string_to_number, so that Fstring_to_number parses
15814 floating point numbers consistently with the Lisp reader.
04f2d78b 15815 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
15816 (E_CHAR, EXP_INT): Remove, replacing with ...
15817 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
15818 (string_to_number): New function, replacing isfloat_string.
15819 This function checks for valid syntax and produces the resulting
15820 Lisp float number too. Rework it so that string-to-number
bc0a5c13 15821 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
15822 so that overflow for non-base-10 numbers is reported only when
15823 there's no portable and simple way to convert to floating point.
452f4150 15824
67769ffc
PE
15825 * textprop.c (set_text_properties_1): Rewrite for clarity,
15826 and to avoid GCC warning about integer overflow.
15827
c20db43f
PE
15828 * intervals.h (struct interval): Use EMACS_INT for members
15829 where EMACS_UINT might cause problems. See
15830 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
15831 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
15832 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
15833 All uses changed.
37aa2f85
PE
15834 (offset_intervals): Tell GCC not to worry about length overflow
15835 when negating a negative length.
c20db43f 15836
2538aa2f
PE
15837 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
15838 (overrun_check_free): Likewise.
15839
f2d3008d
PE
15840 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
15841 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
15842 word size.
15843
ec8df744
PE
15844 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
15845 (gnutls_make_error): Rename local to avoid shadowing.
15846 (gnutls_emacs_global_deinit): ifdef out; not used.
15847 (Fgnutls_boot): Use const for pointer to readonly storage.
15848 Comment out unused local. Fix pointer signedness problems.
15849
640ee02d
PE
15850 * lread.c (openp): Don't stuff size_t into an 'int'.
15851 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
15852 about possible signed overflow.
15853
6048fb2a
PE
15854 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
15855 (GDK_KEY_g): Don't define if already defined.
15856 (xg_prepare_tooltip): Avoid pointer signedness problem.
15857 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
15858
fa3c87e1
PE
15859 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
15860 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
15861
2172544b
PE
15862 * xfns.c (Fx_window_property): Simplify a bit,
15863 to make a bit faster and to avoid GCC 4.6.0 warning.
15864 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
15865
9b821a21
PE
15866 * fns.c (internal_equal): Don't assume size_t fits in int.
15867
3c616cfa
PE
15868 * alloc.c (compact_small_strings): Tighten assertion a little.
15869
c2982e87
PE
15870 Replace pEd with more-general pI, and fix some printf arg casts.
15871 * lisp.h (pI): New macro, generalizing old pEd macro to other
15872 conversion specifiers. For example, use "...%"pI"d..." rather
15873 than "...%"pEd"...".
15874 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 15875 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
15876 * alloc.c (check_pure_size): Don't overflow by converting size to int.
15877 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
15878 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
15879 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
15880 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
15881 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
15882 64-bit hosts.
15883 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
15884 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
15885 * print.c (safe_debug_print, print_object): Likewise.
15886 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
15887 to int.
6f04d126
PE
15888 Use pI instead of if-then-else-abort. Use %p to avoid casts,
15889 avoiding the 0 flag, which is not portable.
c2982e87
PE
15890 * process.c (Fmake_network_process): Use pI to avoid cast.
15891 * region-cache.c (pp_cache): Likewise.
15892 * xdisp.c (decode_mode_spec): Likewise.
15893 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
15894 behavior on 64-bit hosts with printf arg.
6f04d126 15895 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
15896 (x_stop_queuing_selection_requests): Likewise.
15897 (x_get_window_property): Don't truncate byte count to an 'int'
15898 when tracing.
0b432f21 15899
5e073ec7
PE
15900 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
15901 here, since it parses constructs like leading '-' and spaces,
15902 which are not wanted; and it overflows with large numbers.
15903 Instead, simply match F[0-9]+, which is what is wanted anyway.
15904
36372bf9
PE
15905 * alloc.c: Remove unportable assumptions about struct layout.
15906 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
15907 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
15908 (allocate_vectorlike, make_pure_vector): Use the new macros,
15909 plus offsetof, to remove unportable assumptions about struct layout.
15910 These assumptions hold on all porting targets that I know of, but
15911 they are not guaranteed, they're easy to remove, and removing them
15912 makes further changes easier.
15913
0b432f21
PE
15914 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
15915 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
15916 (string_overrun_cookie): Now const. Use initializers that
15917 don't formally overflow signed char, to avoid warnings.
000098c1
PE
15918 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
15919 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
15920 (allocate_buffer): Don't assume sizeof (struct buffer) is a
15921 multiple of sizeof (EMACS_INT); it need not be, if
15922 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 15923 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 15924
895009e1
JB
159252011-04-26 Juanma Barranquero <lekktu@gmail.com>
15926
15927 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
15928
6a7a1b0b
TZ
159292011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
15930
15931 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 15932 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
15933 Reported by Paul Eggert <eggert@cs.ucla.edu>.
15934
841a1577 159352011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
15936
15937 * lisp.h (Qdebug): List symbol.
895009e1 15938 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
15939 * keyboard.c (debug-on-event): New variable.
15940 (handle_user_signal): Break into debugger when debug-on-event
15941 matches the current signal symbol.
15942
f2d3ba6f
DN
159432011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
15944
15945 * alloc.c (check_sblock, check_string_bytes)
15946 (check_string_free_list): Convert to standard C.
15947
42ce4c63
TZ
159482011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
15949
15950 * w32.c (emacs_gnutls_push): Fix typo.
15951
825cd63c
EZ
159522011-04-25 Eli Zaretskii <eliz@gnu.org>
15953
fb11d64d
EZ
15954 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
15955 "cast to pointer from integer of different size".
15956
825cd63c
EZ
15957 Improve doprnt and its use in verror. (Bug#8545)
15958 * doprnt.c (doprnt): Document the set of format control sequences
15959 supported by the function. Use SAFE_ALLOCA instead of always
15960 using `alloca'.
15961
15962 * eval.c (verror): Don't limit the buffer size at size_max-1, that
15963 is one byte too soon. Don't use xrealloc; instead xfree and
15964 xmalloc anew.
15965
e061a11b
TZ
159662011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
15967
15968 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
15969 callbacks stage.
15970
15971 * gnutls.c: Renamed global_initialized to
15972 gnutls_global_initialized. Added internals for the
15973 :verify-hostname-error, :verify-error, and :verify-flags
15974 parameters of `gnutls-boot' and documented those parameters in the
15975 docstring. Start callback support.
9173deec
JB
15976 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
15977 unless a fatal error occurred. Call gnutls_alert_send_appropriate
15978 on error. Return error code.
e061a11b
TZ
15979 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
15980 (emacs_gnutls_read): Likewise.
15981 (Fgnutls_boot): Return handshake error code.
15982 (emacs_gnutls_handle_error): New function.
15983 (wsaerror_to_errno): Likewise.
15984
15985 * w32.h (emacs_gnutls_pull): Add prototype.
15986 (emacs_gnutls_push): Likewise.
15987
15988 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
15989 (emacs_gnutls_push): Likewise.
15990
159912011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
15992
15993 * process.c (wait_reading_process_output): Check if GnuTLS
15994 buffered some data internally if no FDs are set for TLS
15995 connections.
15996
15997 * makefile.w32-in (OBJ2): Add gnutls.$(O).
15998 (LIBS): Link to USER_LIBS.
15999 ($(BLD)/gnutls.$(0)): New target.
16000
fa6996bc
EZ
160012011-04-24 Eli Zaretskii <eliz@gnu.org>
16002
eb35682e
EZ
16003 * xdisp.c (handle_single_display_spec): Rename the
16004 display_replaced_before_p argument into display_replaced_p, to
16005 make it consistent with the commentary. Fix typos in the
16006 commentary.
16007
e2ad650c
EZ
16008 * textprop.c (syms_of_textprop): Remove dead code.
16009 (copy_text_properties): Delete obsolete commentary about an
16010 interface that was deleted long ago. Fix typos in the description
16011 of arguments.
16012
1b2de274
EZ
16013 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
16014 to changes in oldXMenu/XMenu.h from 2011-04-16.
16015 <menu_help_message, prev_menu_help_message>: Constify.
16016 (IT_menu_make_room): menu->help_text is now `const char **';
16017 adjust.
16018
16019 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
16020 to changes in oldXMenu/XMenu.h from 2011-04-16.
16021 (struct XMenu): Declare `help_text' `const char **'.
16022
16023 * xfaces.c <Qunspecified>: Make extern again.
16024
16025 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 16026 required by POSIX.
1b2de274 16027
762b15be
EZ
16028 * doc.c (get_doc_string): Improve the format passed to `error'.
16029
16030 * doprnt.c (doprnt): Improve commentary.
16031
16032 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
16033
16034 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
16035 them with etags.
16036
f1052e5d
EZ
16037 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
16038 changes in globals.h immediately force recompilation.
762b15be
EZ
16039 (TAGS): Depend on $(CURDIR)/m/intel386.h and
16040 $(CURDIR)/s/ms-w32.h.
16041 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 16042
fa6996bc
EZ
16043 * character.c (Fchar_direction): Function deleted.
16044 (syms_of_character): Don't defsubr it.
16045 <char-direction-table>: Deleted.
16046
e6c3da20
EZ
160472011-04-23 Eli Zaretskii <eliz@gnu.org>
16048
16049 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
16050 * doprnt.c: Include limits.h.
16051 (SIZE_MAX): New macro.
04f2d78b
CB
16052 (doprnt): Return a size_t value. 2nd arg is now size_t.
16053 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
16054 Improve overflow protection. Support `l' modifier for integer
16055 conversions. Support %l conversion. Don't assume an EMACS_INT
16056 argument for integer conversions and for %c.
16057
16058 * lisp.h (doprnt): Restore prototype.
16059
16060 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
16061 $(SRC)/character.h.
16062
16063 * Makefile.in (base_obj): Add back doprnt.o.
16064
16065 * deps.mk (doprnt.o): Add back prerequisites.
16066 (callint.o): Depend on character.h.
16067
16068 * eval.c (internal_lisp_condition_case): Include the handler
16069 representation in the error message.
16070 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
16071 when breaking from the loop.
16072
16073 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
16074
16075 * callint.c (Fcall_interactively): When displaying error message
16076 about invalid control letter, pass the character's codepoint, not
16077 a pointer to its multibyte form. Improve display of the character
16078 in octal and display also its hex code.
16079
16080 * character.c (char_string): Use %x to display the (unsigned)
16081 codepoint of an invalid character, to avoid displaying a bogus
16082 negative value.
16083
16084 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
16085 `error', not SYMBOL_NAME itself.
16086
16087 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
16088 character arguments to `error'.
16089
16090 * charset.c (check_iso_charset_parameter): Fix incorrect argument
16091 to `error' in error message about FINAL_CHAR argument. Make sure
16092 FINAL_CHAR is a character, and use %c when it is passed as
16093 argument to `error'.
16094
4ffd0d6b 160952011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
16096
16097 * s/ms-w32.h (localtime): Redirect to sys_localtime.
16098
16099 * w32.c: Include <time.h>.
16100 (sys_localtime): New function.
16101
4ffd0d6b 161022011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
16103
16104 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
16105
4ffd0d6b 16106 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 16107
4ffd0d6b 161082011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 16109
4ffd0d6b
GM
16110 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
16111 zombies (Bug#8467).
aac0c6e3 16112
04c56954
EZ
161132011-04-19 Eli Zaretskii <eliz@gnu.org>
16114
16115 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
16116 gl_state.e_property when gl_state.object is Qt.
16117
16118 * insdel.c (make_gap_larger): Remove limitation of buffer size
16119 to <= INT_MAX.
16120
16a43933
CY
161212011-04-18 Chong Yidong <cyd@stupidchicken.com>
16122
16123 * xdisp.c (lookup_glyphless_char_display)
16124 (produce_glyphless_glyph): Handle cons cell entry in
16125 glyphless-char-display.
16126 (Vglyphless_char_display): Document it.
16127
16128 * term.c (produce_glyphless_glyph): Handle cons cell entry in
16129 glyphless-char-display.
16130
4581706e
CY
161312011-04-17 Chong Yidong <cyd@stupidchicken.com>
16132
16133 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
16134
16135 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
16136
16137 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
16138 definition for no-X builds.
16139
4887c6e2 161402011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 16141
fd35b6f9
PE
16142 Static checks with GCC 4.6.0 and non-default toolkits.
16143
5c1ccb01
PE
16144 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
16145
006c5daa
PE
16146 * process.c (keyboard_bit_set): Define only if SIGIO.
16147 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
16148 (send_process): Repair possible setjmp clobbering.
16149
efc736d3
PE
16150 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
16151
4e2fe2e6
PE
16152 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
16153
f97334a2
PE
16154 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
16155
4e75f29d
PE
16156 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
16157 Define only if needed.
16158
90efadd1
PE
16159 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
16160 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 16161 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 16162
3c647824
PE
16163 * dispextern.h (struct redisplay_interface): Rename param
16164 to avoid shadowing.
e264f262 16165 * termhooks.h (struct terminal): Likewise.
761383f4 16166 * xterm.c (xembed_send_message): Likewise.
3c647824 16167
b58c5c4a
PE
16168 * insdel.c (make_gap_smaller): Define only if
16169 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
16170
cad59032
PE
16171 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
16172 it.
16173
c339dc2e
PE
16174 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
16175 so that we aren't warned about unused symbols.
16176
91a3e27b
PE
16177 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
16178
399c71d3 16179 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 16180
8ffc96f5
PE
16181 * xfns.c (x_real_positions): Mark locals as initialized.
16182
eef9bc79
PE
16183 * xmenu.c (xmenu_show): Don't use uninitialized vars.
16184
098db9dd
PE
16185 * xterm.c: Fix problems found by static analysis with other toolkits.
16186 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
16187 (x_dispatch_event): Declare static if USE_GTK, and
16188 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 16189 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 16190 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
16191 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
16192 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 16193
eb18f6cc
PE
16194 * xmenu.c (menu_help_callback): Pointer type fixes.
16195 Use const pointers when pointing at readonly data. Avoid pointer
16196 signedness clashes.
16197 (FALSE): Remove unused macro.
16198 (update_frame_menubar): Remove unused decl.
16199
1fe72bf8
PE
16200 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
16201
60d9e1db
PE
16202 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
16203 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
16204 (single_menu_item): Rename local to avoid shadowing.
16205
39261c26
PE
16206 * keyboard.c (make_lispy_event): Remove unused local var.
16207
018c5e19
PE
16208 * frame.c, frame.h (x_get_resource_string): Bring this back, but
16209 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
16210
63d2b86e
PE
16211 * bitmaps: Change bitmaps from unsigned char back to the X11
16212 compatible char. Avoid the old compiler warnings about
16213 out-of-range initializers by using, for example, '\xab' rather
16214 than 0xab.
16215
aefd87e1
PE
16216 * xgselect.c (xgselect_initialize): Check vs interface
16217 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
16218
bf501fb9
PE
16219 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
16220
e9829fdf
PE
16221 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
16222 to read-only memory.
16223
1086c095
PE
16224 * fns.c (vector): Remove; this old hack is no longer needed.
16225
2baccd04 16226 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 16227 Remove unused var.
dde42981 16228 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 16229
72391843 16230 * xrdb.c (x_load_resources): Omit unused local.
3565b346 16231
436c16df 16232 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 16233 (x_window): Rename locals to avoid shadowing.
dc5ddd85 16234 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 16235
92bb796d 16236 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 16237 (x_term_init): Remove local to avoid shadowing.
92bb796d 16238
764430a3 16239 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
16240
16241 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
16242 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
16243
d1dfb56c
EZ
162442011-04-16 Eli Zaretskii <eliz@gnu.org>
16245
c4354cb4
EZ
16246 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
16247
d1dfb56c
EZ
16248 Fix regex.c, syntax.c and friends for buffers > 2GB.
16249 * syntax.h (struct gl_state_s): Declare character position members
16250 EMACS_INT.
16251
16252 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
16253
04f2d78b
CB
16254 * textprop.c (verify_interval_modification, interval_of):
16255 Declare arguments EMACS_INT.
d1dfb56c
EZ
16256
16257 * intervals.c (adjust_intervals_for_insertion): Declare arguments
16258 EMACS_INT.
16259
16260 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
16261
16262 * indent.c (Fvertical_motion): Local variable it_start is now
16263 EMACS_INT.
16264
16265 * regex.c (re_match, re_match_2, re_match_2_internal)
16266 (bcmp_translate, regcomp, regexec, print_double_string)
16267 (group_in_compile_stack, re_search, re_search_2, regex_compile)
16268 (re_compile_pattern, re_exec): Declare arguments and local
16269 variables `size_t' and `ssize_t' and return values `regoff_t', as
16270 appropriate.
16271 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
16272 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
16273 <compile_stack_type>: `size' and `avail' are now `size_t'.
16274
16275 * regex.h <regoff_t>: Use ssize_t, not int.
16276 (re_search, re_search_2, re_match, re_match_2): Arguments that
16277 specify buffer/string position and length are now ssize_t and
16278 size_t. Return type is regoff_t.
16279
613052cd
BK
162802011-04-16 Ben Key <bkey76@gmail.com>
16281
16282 * nsfont.m: Fixed bugs in ns_get_family and
16283 ns_descriptor_to_entity that were caused by using free to
16284 deallocate memory blocks that were allocated by xmalloc (via
16285 xstrdup). This caused Emacs to crash when compiled with
16286 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
16287 --enable-checking=xmallocoverrun). xfree is now used to
16288 deallocate these memory blocks.
16289
4170f62f 162902011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 16291
71b41406
PE
16292 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
16293
9587a89d
PE
16294 emacs_write: Accept and return EMACS_INT for sizes.
16295 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
16296 et seq.
16297 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
16298 Accept and return EMACS_INT.
16299 (emacs_gnutls_write): Return the number of bytes written on
16300 partial writes.
16301 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
16302 (emacs_read, emacs_write): Remove check for negative size, as the
16303 Emacs source code has been audited now.
9587a89d
PE
16304 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
16305 (emacs_read, emacs_write): Use it.
273a5f82
PE
16306 * process.c (send_process): Adjust to the new signatures of
16307 emacs_write and emacs_gnutls_write. Do not attempt to store
16308 a byte offset into an 'int'; it might overflow.
9587a89d 16309 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 16310
3e047f51
PE
16311 * sound.c: Don't assume sizes fit in 'int'.
16312 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 16313 Return EMACS_INT, not int.
3e047f51 16314 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
16315 Accept EMACS_INT, not int.
16316 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
16317 record read return values.
16318
cc39a9db
BK
163192011-04-15 Ben Key <bkey76@gmail.com>
16320
c9d0ec6d
JB
16321 * keyboard.c (Qundefined): Don't declare static since it is used
16322 in nsfns.m.
16323 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
16324 static since they are used in nsfont.m.
cc39a9db 16325
6c60eb9f
SM
163262011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
16327
16328 * process.c (Qprocessp): Don't declare static.
16329 * lisp.h (Qprocessp): Declare again.
16330
7990b61a
JB
163312011-04-15 Juanma Barranquero <lekktu@gmail.com>
16332
16333 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
16334
5d4cb038
PE
163352011-04-14 Paul Eggert <eggert@cs.ucla.edu>
16336
8bd7b830 16337 Improve C-level modularity by making more things 'static'.
cd64ea1d 16338
e3b27b31
PE
16339 Don't publish debugger-only interfaces to other modules.
16340 * lisp.h (safe_debug_print, debug_output_compilation_hack):
16341 (verify_bytepos, count_markers): Move decls to the only modules
16342 that need them.
16343 * region-cache.h (pp_cache): Likewise.
16344 * window.h (check_all_windows): Likewise.
16345 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
16346
5d4cb038
PE
16347 * sysdep.c (croak): Now static, if
16348 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
16349 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
16350
16351 * alloc.c (refill_memory_reserve): Now static if
16352 !defined REL_ALLOC || defined SYSTEM_MALLOC.
16353 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 16354
e87b6180
PE
16355 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
16356 Define only if USE_LUCID.
16357
ac64929e
PE
16358 * xrdb.c (x_customization_string, x_rm_string): Now static.
16359
6f37259d
PE
16360 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
16361 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
16362
1683e3ab
PE
16363 * xdisp.c (draw_row_with_mouse_face): Now static.
16364 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
16365
de9c2632
PE
16366 * window.h (check_all_windows): Mark externally visible.
16367
2b96acb7
PE
16368 * window.c (window_deletion_count): Now static.
16369
16370 * undo.c: Make symbols static if they're not exported.
16371 (last_undo_buffer, last_boundary_position, pending_boundary):
16372 Now static.
16373
50436f33
PE
16374 * textprop.c (interval_insert_behind_hooks): Now static.
16375 (interval_insert_in_front_hooks): Likewise.
16376
64520e5c
PE
16377 * term.c: Make symbols static if they're not exported.
16378 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
16379 (max_frame_lines, tty_set_terminal_modes):
16380 (tty_reset_terminal_modes, tty_turn_off_highlight):
16381 (get_tty_terminal): Now static.
16382 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
16383 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 16384 HAVE_WINDOW_SYSTEM.
64520e5c
PE
16385 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
16386 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
16387
1fa53021
PE
16388 * sysdep.c: Make symbols static if they're not exported.
16389 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
16390 Now static.
16391 (sigprocmask_set, full_mask): Remove; unused.
16392 (wait_debugging): Mark as visible.
16393 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
16394 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
16395
d4b43b22
PE
16396 * syntax.c (syntax_temp): Define only if !__GNUC__.
16397
b7c513d0
PE
16398 * sound.c (current_sound_device, current_sound): Now static.
16399
989b29ad
PE
16400 * search.c (searchbufs, searchbuf_head): Now static.
16401
13a55a78
PE
16402 * scroll.c (scroll_cost): Remove; unused.
16403 * dispextern.h (scroll_cost): Remove decl.
16404
de68a1fc
PE
16405 * region-cache.h (pp_cache): Mark as externally visible.
16406
40ccffa6
PE
16407 * process.c: Make symbols static if they're not exported.
16408 (process_tick, update_tick, create_process, chan_process):
16409 (Vprocess_alist, proc_buffered_char, datagram_access):
16410 (fd_callback_data, send_process_frame, process_sent_to): Now static.
16411 (deactivate_process): Mark defn as static, as well as decl.
16412 * lisp.h (create_process): Remove decl.
16413 * process.h (chan_process, Vprocess_alist): Remove decls.
16414
ad64fc97
PE
16415 * print.c: Make symbols static if they're not exported.
16416 (print_depth, new_backquote_output, being_printed, print_buffer):
16417 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
16418 (print_interval, print_number_index, initial_stderr_stream):
16419 Now static.
16420 * lisp.h (Fprinc): Remove decl.
16421 (debug_output_compilation_hack): Mark as externally visible.
16422
adddb265
PE
16423 * sysdep.c (croak): Move decl from here to syssignal.h.
16424 * syssignal.h (croak): Put it here, so the API can be checked when
16425 'croak' is called from dissociate_if_controlling_tty.
16426
1717ede2
PE
16427 * minibuf.c: Make symbols static if they're not exported.
16428 (minibuf_save_list, choose_minibuf_frame): Now static.
16429 * lisp.h (choose_minibuf_frame): Remove decl.
16430
fa5fb2bc
PE
16431 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
16432
1e3890d1
PE
16433 * lread.c: Make symbols static if they're not exported.
16434 (read_objects, initial_obarray, oblookup_last_bucket_number):
16435 Now static.
16436 (make_symbol): Remove; unused.
16437 * lisp.h (initial_obarray, make_symbol): Remove decls.
16438
8a1414fa
PE
16439 * keyboard.c: Make symbols static if they're not exported.
16440 (single_kboard, recent_keys_index, total_keys, recent_keys):
16441 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
16442 (this_single_command_key_start, echoing, last_auto_save):
16443 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
16444 (command_loop, echo_now, keyboard_init_hook, help_char_p):
16445 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
16446 (Vlispy_mouse_stem, double_click_count):
16447 Now static.
16448 (force_auto_save_soon): Define only if SIGDANGER.
16449 (ignore_mouse_drag_p): Now static if
16450 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
16451 (print_help): Remove; unused.
16452 (stop_character, last_timer_event): Mark as externally visible.
16453 * keyboard.h (ignore_mouse_drag_p): Declare only if
16454 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
16455 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
16456 * lisp.h (echoing): Remove decl.
16457 (force_auto_save_soon): Declare only if SIGDANGER.
16458 * xdisp.c (redisplay_window): Simplify code, to make it more
16459 obvious that ignore_mouse_drag_p is not accessed if !defined
16460 USE_GTK && !defined HAVE_NS.
16461
93ea6e8f
PE
16462 * intervals.c: Make symbols static if they're not exported.
16463 (merge_properties_sticky, merge_interval_right, delete_interval):
16464 Now static.
16465 * intervals.h (merge_interval_right, delete_interval): Remove decls.
16466
77382fcc
PE
16467 * insdel.c: Make symbols static if they're not exported.
16468 However, leave prepare_to_modify_buffer alone. It's never
16469 called from outside this function, but that appears to be a bug.
16470 (combine_after_change_list, combine_after_change_buffer):
4889fc82 16471 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
16472 (adjust_after_replace_noundo): Remove; unused.
16473 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 16474 (signal_before_change): Remove decls.
77382fcc 16475
9306c32e
PE
16476 * indent.c (val_compute_motion, val_vmotion): Now static.
16477
cd44d2eb
PE
16478 * image.c: Make symbols static if they're not exported.
16479 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
16480 if USE_GTK.
16481 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
16482 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
16483
ad9a7a06
PE
16484 * fringe.c (standard_bitmaps): Now static.
16485 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
16486
81626931
PE
16487 * frame.c: Make symbols static if they're not exported.
16488 (x_report_frame_params, make_terminal_frame): Now static.
16489 (get_frame_param): Now static, unless HAVE_NS.
16490 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
16491 (x_get_resource_string): Remove; not used.
16492 * frame.h (make_terminal_frame, x_report_frame_params):
16493 (x_get_resource_string); Remove decls.
16494 (x_fullscreen_adjust): Declare only if WINDOWSNT.
16495 * lisp.h (get_frame_param): Declare only if HAVE_NS.
16496
239f9db9
PE
16497 * font.c, fontset.c: Make symbols static if they're not exported.
16498 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
16499 (FACE_SUITABLE_FOR_CHAR_P): Use it.
16500 * font.c (font_close_object): Now static.
16501 * font.h (font_close_object): Remove.
16502 * fontset.c (FONTSET_OBJLIST): Remove.
16503 (free_realized_fontset) #if-0 the body, which does nothing.
16504 (face_suitable_for_char_p): #if-0, as it's never called.
16505 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
16506 * xfaces.c (face_at_string_position):
16507 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
16508 since 0 is always ASCII.
16509
dfcf3579
PE
16510 * fns.c (weak_hash_tables): Now static.
16511
5045092b
PE
16512 * fileio.c: Make symbols static if they're not exported.
16513 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
16514 (Vwrite_region_annotation_buffers): Now static.
16515
57a96f5c
PE
16516 * eval.c: Make symbols static if they're not exported.
16517 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
16518 * lisp.h (backtrace_list): Remove decl.
16519
35f08c38
PE
16520 * emacs.c: Make symbols static if they're not exported.
16521 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
16522 (fatal_error_code, fatal_error_signal_hook, standard_args):
16523 Now static.
16524 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
16525 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
16526 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
16527 * lisp.h (fatal_error_signal_hook): Remove decl.
16528 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
16529
f44bd759
PE
16530 * editfns.c: Move a (normally-unused) function to its only use.
16531 * editfns.c, lisp.h (get_operating_system_release): Remove.
16532 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
16533 worth the hassle of breaking this out.
16534
b532497d
PE
16535 * xterm.c: Make symbols static if they're not exported.
16536 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
16537 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
16538 (x_destroy_window, x_delete_display):
16539 Now static.
16540 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
16541 (x_mouse_leave): Remove; unused.
16542 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
16543 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
16544 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
16545 Remove decls.
16546 (x_mouse_leave): Declare only if WINDOWSNT.
16547 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
16548 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
16549 USE_X_TOOLKIT.
16550
1675728f
PE
16551 * ftxfont.c: Make symbols static if they're not exported.
16552 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
16553 HAVE_FREETYPE.
16554 * font.h (ftxfont_driver): Likewise.
16555
e4cebfca
PE
16556 * xfns.c: Make symbols static if they're not exported.
16557 (x_last_font_name, x_display_info_for_name):
16558 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
16559 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
16560 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
16561 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
16562 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
16563 (last_show_tip_args): Now static.
16564 (xic_defaut_fontset, xic_create_fontsetname): Define only if
16565 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
16566 (x_screen_planes): Remove; unused.
16567 * dispextern.h (x_screen_planes): Remove decl.
16568
5bf46f05
PE
16569 * dispnew.c: Make symbols static if they're not exported.
16570 * dispextern.h (redraw_garbaged_frames, scrolling):
16571 (increment_row_positions): Remove.
16572 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
16573 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
16574 Now static.
16575 (redraw_garbaged_frames): Remove; unused.
16576
435f4c28
PE
16577 * xfaces.c: Make symbols static if they're not exported.
16578 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
16579 Remove decls.
16580 * xterm.h (defined_color): Remove decls.
16581 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
16582 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
16583 (menu_face_changed_default, defined_color, free_realized_face):
16584 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
16585 (ascii_face_of_lisp_face): Remove; unused.
16586
8524aef3
PE
16587 * xdisp.c: Make symbols static if they're not exported.
16588 * dispextern.h (scratch_glyph_row, window_box_edges):
16589 (glyph_to_pixel_coords, set_cursor_from_row):
16590 (get_next_display_element, set_iterator_to_next):
16591 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
16592 (show_mouse_face): Remove decls
16593 * frame.h (message_buf_print): Likewise.
16594 * lisp.h (pop_message, set_message, check_point_in_composition):
16595 Likewise.
16596 * xterm.h (set_vertical_scroll_bar): Likewise.
16597 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
16598 (message_buf_print, scratch_glyph_row, displayed_buffer):
16599 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
16600 (get_next_display_element, show_mouse_face, window_box_edges):
16601 (frame_to_window_pixel_xy, check_point_in_composition):
16602 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
16603 (glyph_to_pixel_coords): Remove; unused.
16604
16390cd2
PE
16605 * dired.c (file_name_completion): Now static.
16606
16607 * dbusbind.c (xd_in_read_queued_messages): Now static.
16608
a25f4dfa
PE
16609 * lisp.h (circular_list_error, FOREACH): Remove; unused.
16610 * data.c (circular_list_error): Remove.
16611
14a9c8df
PE
16612 * commands.h (last_point_position, last_point_position_buffer):
16613 (last_point_position_window): Remove decls.
16614 * keyboard.c: Make these variables static.
16615
04f2d78b
CB
16616 * coding.h (coding, code_convert_region, encode_coding_gap):
16617 Remove decls.
74ab6df5
PE
16618 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
16619 (iso_code_class, detect_coding, code_convert_region): Now static.
16620 (encode_coding_gap): Remove; unused.
16621
38dfbee1
PE
16622 * chartab.c (chartab_chars, chartab_bits): Now static.
16623
a2cb4e63
PE
16624 * charset.h (charset_iso_8859_1): Remove decl.
16625 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
16626 Now static.
16627
127198fd
PE
16628 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
16629 * ccl.c (Vccl_program_table): Now static.
16630 (check_ccl_update): Remove; unused.
16631
d85b608f
PE
16632 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
16633 * category.h: ... from here.
16634 * category.c (check_category_table, set_category_set): Now static.
16635
31cd66f3
PE
16636 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
16637 * lisp.h: Remove these decls.
16638
c358e587
PE
16639 * buffer.c (buffer_count): Remove unused var.
16640
e78aecca
PE
16641 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
16642 so that it's not optimized away.
16643 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
16644 * dispextern.h (bidi_dump_cached_states): Remove, since it's
16645 exported only to the debugger.
16646
e192d7d3 16647 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 16648 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 16649
92470028
PE
16650 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
16651 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
16652 was inaccessible from Lisp.
16653 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
16654 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
16655
244ed907
PE
16656 alloc.c: Import and export fewer symbols, and remove unused items.
16657 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
16658 is defined.
16659 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
16660 it's not optimized away by whole-program optimization.
16661 (message_enable_multibyte, free_misc): Remove.
16662 (catchlist, handlerlist, mark_backtrace):
16663 Declare only if BYTE_MARK_STACK.
16664 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
16665 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
16666 (message_enable_multibyte): Remove decl.
16667 (free_misc, interval_free_list, float_block, float_block_index):
16668 (n_float_blocks, float_free_list, cons_block, cons_block_index):
16669 (cons_free_list, last_marked_index):
16670 Now static.
16671 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
16672 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
16673 (mark_backtrace): Define only if BYTE_MARK_STACK.
16674 * xdisp.c (message_enable_multibyte): Now static.
16675
61c2b50e 16676 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
16677 This makes it easier for human readers (and static analyzers)
16678 to see whether these variables are used from other modules.
16679 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
16680 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
16681 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
16682 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
16683 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
16684 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
16685 * xmenu.c, xselect.c:
16686 Declare Q* vars static if they are not used in other modules.
16687 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
16688 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
16689 Remove decls of unexported vars.
16690 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
16691
95c82688
PE
16692 * lisp.h (DEFINE_FUNC): Make sname 'static'.
16693
16a97296
PE
16694 Make Emacs functions such as Fatom 'static' by default.
16695 This makes it easier for human readers (and static analyzers)
16696 to see whether these functions can be called from other modules.
16697 DEFUN now defines a static function. To make the function external
16698 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
16699 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
16700 (Finit_image_library):
16a97296
PE
16701 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
16702 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
16703 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
16704 Remove decls, since these functions are now static.
16705 (Funintern, Fget_internal_run_time): New decls, since these functions
16706 were already external.
95c82688 16707
16a97296
PE
16708 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
16709 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
16710 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
16711 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
16712 * keyboard.c, keymap.c, lread.c:
16713 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
16714 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
16715 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
16716 Mark functions with DEFUE instead of DEFUN,
16717 if they are used in other modules.
16718 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
16719 decls for now-static functions.
16720 * buffer.h (Fdelete_overlay): Remove decl.
16721 * callproc.c (Fgetenv_internal): Mark as internal.
16722 * composite.c (Fremove_list_of_text_properties): Remove decl.
16723 (Fcomposition_get_gstring): New forward static decl.
16724 * composite.h (Fcomposite_get_gstring): Remove decl.
16725 * dired.c (Ffile_attributes): New forward static decl.
16726 * doc.c (Fdocumntation_property): New forward static decl.
16727 * eval.c (Ffetch_bytecode): New forward static decl.
16728 (Funintern): Remove extern decl; now in .h file where it belongs.
16729 * fileio.c (Fmake_symbolic_link): New forward static decl.
16730 * image.c (Finit_image_library): New forward static decl.
16731 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
16732 * intervals.h (Fprevious_property_change):
16733 (Fremove_list_of_text_properties): Remove decls.
16734 * keyboard.c (Fthis_command_keys): Remove decl.
16735 (Fcommand_execute): New forward static decl.
16736 * keymap.c (Flookup_key): New forward static decl.
16737 (Fcopy_keymap): Now static.
16738 * keymap.h (Flookup_key): Remove decl.
16739 * process.c (Fget_process): New forward static decl.
16740 (Fprocess_datagram_address): Mark as internal.
16741 * syntax.c (Fsyntax_table_p): New forward static decl.
16742 (skip_chars): Remove duplicate decl.
16743 * textprop.c (Fprevious_property_change): New forward static decl.
16744 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
16745 Now internal.
16746 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
16747 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
16748
785bbd42
PE
16749 * editfns.c (Fformat): Remove unreachable code.
16750
8b913b57
AS
167512011-04-14 Andreas Schwab <schwab@linux-m68k.org>
16752
16753 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
16754 change. (Bug#8496)
16755
a6744a35
EZ
167562011-04-13 Eli Zaretskii <eliz@gnu.org>
16757
16758 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
16759 when at ZV. (Bug#8487)
16760
e7974947
AS
167612011-04-12 Andreas Schwab <schwab@linux-m68k.org>
16762
baad03f0
AS
16763 * charset.c (Fclear_charset_maps): Use xfree instead of free.
16764 (Bug#8437)
16765 * keyboard.c (parse_tool_bar_item): Likewise.
16766 * sound.c (sound_cleanup, alsa_close): Likewise.
16767 * termcap.c (tgetent): Likewise.
16768 * xfns.c (x_default_font_parameter): Likewise.
16769 * xsettings.c (read_and_apply_settings): Likewise.
16770
e7974947
AS
16771 * alloc.c (overrun_check_malloc, overrun_check_realloc)
16772 (overrun_check_free): Protoize.
16773
28272684
PE
167742011-04-12 Paul Eggert <eggert@cs.ucla.edu>
16775
16776 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
16777 since callers should never pass a negative size.
16778 Change the signature to match that of plain 'read' and 'write'; see
16779 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
16780 * lisp.h: Update prototypes of emacs_write and emacs_read.
16781
11997c76
EZ
167822011-04-11 Eli Zaretskii <eliz@gnu.org>
16783
16784 * xdisp.c (redisplay_window): Don't try to determine the character
16785 position of the scroll margin if the window start point w->startp
e896f03c 16786 is outside the buffer's accessible region. (Bug#8468)
11997c76 16787
8a2cbd72
EZ
167882011-04-10 Eli Zaretskii <eliz@gnu.org>
16789
16790 Fix write-region and its subroutines for buffers > 2GB.
16791 * fileio.c (a_write, e_write): Modify declaration of arguments and
16792 local variables to support buffers larger than 2GB.
16793 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
16794
16795 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
16796 argument, local variables, and return value.
16797
16798 * lisp.h: Update prototypes of emacs_write and emacs_read.
16799
16800 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
16801
4073e537 168022011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 16803
1ebfdcb6
PE
16804 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
16805
b2ded58d
PE
16806 Fix more problems found by GCC 4.6.0's static checks.
16807
7d66342c
PE
16808 * xdisp.c (vmessage): Use a better test for character truncation.
16809
bbf47d44
PE
16810 * charset.c (load_charset_map): <, not <=, for optimization,
16811 and to avoid potential problems with integer overflow.
9248994d 16812 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 16813 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 16814 * editfns.c (Fformat): Likewise.
1e69125e 16815 * syntax.c (skip_chars): Likewise.
3befa583 16816
e3019616
PE
16817 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
16818 This also lets GCC 4.6.0 generate slightly better loop code.
16819
becfa255
PE
16820 * callint.c (Fcall_interactively): <, not <=, for optimization.
16821 (Fcall_interactively): Count the number of arguments produced,
16822 not the number of arguments given. This is simpler and lets GCC
16823 4.6.0 generate slightly better code.
16824
dae0cd48
PE
16825 * ftfont.c: Distingish more carefully between FcChar8 and char.
16826 The previous code passed unsigned char * to a functions like
16827 strlen and xstrcasecmp that expect char *, which does not
16828 conform to the C standard.
16829 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
16830 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
16831 char * when the C standard requires it.
16832
76032d70
PE
16833 * keyboard.c (read_char): Remove unused var.
16834
eb3f1cc8
PE
16835 * eval.c: Port to Windows vsnprintf (Bug#8435).
16836 Include <limits.h>.
16837 (SIZE_MAX): Define if the headers do not.
16838 (verror): Do not give up if vsnprintf returns a negative count.
16839 Instead, grow the buffer. This ports to Windows vsnprintf, which
16840 does not conform to C99. Problem reported by Eli Zaretskii.
16841 Also, simplify the allocation scheme, by avoiding the need for
16842 calling realloc, and removing the ALLOCATED variable.
16843
70476b54
PE
16844 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
16845
12020a9e
PE
16846 Remove invocations of doprnt, as Emacs now uses vsnprintf.
16847 But keep the doprint source code for now, as we might revamp it
16848 and use it again (Bug#8435).
ea6c7ae6
PE
16849 * lisp.h (doprnt): Remove.
16850 * Makefile.in (base_obj): Remove doprnt.o.
16851 * deps.mk (doprnt.o): Remove.
16852
5fdb398c
PE
16853 error: Print 32- and 64-bit integers portably (Bug#8435).
16854 Without this change, on typical 64-bit hosts error ("...%d...", N)
16855 was used to print both 32- and 64-bit integers N, which relied on
16856 undefined behavior.
61bdb816 16857 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
16858 * lisp.h (error, verror): Mark as printf-like functions.
16859 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
16860 Report overflow in size calculations when allocating printf buffer.
16861 Do not truncate output string at its first null byte.
16862 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
16863 Truncate the output at a character boundary, since vsnprintf does not
16864 do that.
16865 * charset.c (check_iso_charset_parameter): Convert internal
16866 character to string before calling 'error', since %c now has the
16867 printf meaning.
16868 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
16869 overflow when computing char to be passed to 'error'. Do not
16870 pass Lisp_Object to 'error'; pass the integer instead.
16871 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
16872 formatted with plain %d.
16873
b189fa66
PE
16874 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
16875
bff87ef0
PE
16876 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
16877
7e2cac20
PE
16878 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
16879
ce4d90b5
PE
16880 * xterm.c (x_catch_errors): Remove duplicate declaration.
16881
266c9547
PE
16882 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
16883
79c49ad2
PE
16884 * xdisp.c, lisp.h (message_nolog): Remove; unused.
16885
368f4090
JM
168862011-04-10 Jim Meyering <meyering@redhat.com>
16887
16888 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
16889 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
16890 return ssize_t not "int", and use size_t as the buffer length.
16891 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
16892 * gnutls.h: Update declarations.
16893 * process.c (read_process_output): Use ssize_t, to match.
16894 (send_process): Likewise.
16895
a32d4040
CY
168962011-04-09 Chong Yidong <cyd@stupidchicken.com>
16897
16898 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
16899
8546720e 169002011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 16901
04f2d78b
CB
16902 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
16903 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 16904
8546720e
GM
16905 * xterm.c (handle_one_xevent):
16906 * xmenu.c (create_and_show_popup_menu):
16907 * xselect.c (x_decline_selection_request)
16908 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 16909
0a2f5c1a 169102011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
16911
16912 Fix some uses of `int' instead of EMACS_INT.
16913 * search.c (string_match_1, fast_string_match)
16914 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
16915 (scan_buffer, find_next_newline_no_quit)
16916 (find_before_next_newline, search_command, Freplace_match)
16917 (Fmatch_data): Make some `int' variables be EMACS_INT.
16918
16919 * xdisp.c (display_count_lines): 3rd argument and return value now
16920 EMACS_INT. All callers changed.
16921 (pint2hrstr): Last argument is now EMACS_INT.
16922
16923 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
16924 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
16925 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
16926 (decode_coding_utf_16, decode_coding_emacs_mule)
16927 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
16928 (decode_coding_ccl, decode_coding_charset)
16929 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
16930 (decode_coding_iso_2022, decode_coding_emacs_mule)
16931 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
16932 <char_offset, last_offset>: Declare EMACS_INT.
16933 (encode_coding_utf_8, encode_coding_utf_16)
16934 (encode_coding_emacs_mule, encode_invocation_designation)
16935 (encode_designation_at_bol, encode_coding_iso_2022)
16936 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
16937 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
16938 Declare EMACS_INT.
16939 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
16940 (encode_invocation_designation): Last argument P_NCHARS is now
16941 EMACS_INT.
16942 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
16943 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
16944
16945 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
16946 All users changed.
16947
16948 * ccl.c (Fccl_execute_on_string): Declare some variables
16949 EMACS_INT.
16950
8546720e 169512011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
16952
16953 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
16954
4e19a977
CS
169552011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
16956
16957 * process.c (Fformat_network_address): Doc fix.
16958
87302331
R
169592011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
16960
ee7683eb 16961 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 16962
cbb59342
CY
169632011-04-08 Chong Yidong <cyd@stupidchicken.com>
16964
16965 * keyboard.c (read_char): Call Lisp function help-form-show,
16966 instead of using internal_with_output_to_temp_buffer.
16967 (Qhelp_form_show): New var.
e0d38eeb 16968 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
16969
16970 * print.c (internal_with_output_to_temp_buffer): Function deleted.
16971
16972 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
16973
e67a13ab
CY
169742011-04-06 Chong Yidong <cyd@stupidchicken.com>
16975
04f2d78b
CB
16976 * process.c (Flist_processes): Remove to Lisp.
16977 (list_processes_1): Delete.
e67a13ab 16978
973f782d
EZ
169792011-04-06 Eli Zaretskii <eliz@gnu.org>
16980
7c106b1e
EZ
16981 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
16982
973f782d
EZ
16983 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
16984
41cf7d1a 169852011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 16986
ca23cc88
PE
16987 Fix more problems found by GCC 4.6.0's static checks.
16988
f390e2d5
PE
16989 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
16990
42eea0d0
PE
16991 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
16992
b69769da 16993 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 16994
f9541e84
PE
16995 * xdisp.c (vmessage): Mark as a printf-like function.
16996
13841b55
PE
16997 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
16998
c136c10f
PE
16999 * sound.c (sound_warning): Don't crash if arg contains a printf format.
17000
5e2d4a30
PE
17001 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
17002 printf-like functions.
17003 (tiff_load): Add casts to remove these marks before passing them
17004 to system-supplied API.
17005
583f48b9
PE
17006 * eval.c (Fsignal): Remove excess argument to 'fatal'.
17007
b25d760e
PE
17008 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
17009 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
17010 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
17011 directly, rather than having caller test rule sign. This avoids
17012 some unnecessary tests.
17013 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
17014 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
17015 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 17016
bc7b6697 17017 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 17018 (xfont_open): Avoid unnecessary tests.
bc7b6697 17019
27ccc379
PE
17020 * composite.c (composition_gstring_put_cache): Use unsigned integer.
17021
dcd5c89a
PE
17022 * composite.h, composite.c (composition_gstring_put_cache):
17023 Use EMACS_INT, not int, for length.
17024
b13a45c6
PE
17025 * composite.h (COMPOSITION_DECODE_REFS): New macro,
17026 breaking out part of COMPOSITION_DECODE_RULE.
17027 (COMPOSITION_DECODE_RULE): Use it.
17028 * composite.c (get_composition_id): Remove unused local vars,
17029 by using the new macro.
17030
1e792e4d
PE
17031 * textprop.c (set_text_properties_1): Change while to do-while,
17032 since the condition is always true at first.
17033
dc6c6455 17034 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
17035 (interval_deletion_adjustment): Return unsigned value.
17036 All uses changed.
dc6c6455 17037
aba7731a
PE
17038 * process.c (list_processes_1, create_pty, read_process_output):
17039 (exec_sentinel): Remove vars that were set but not used.
afd4052b 17040 (create_pty): Remove unnecessary "volatile"s.
bc57d757 17041 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 17042 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 17043 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 17044
fdfc4bf3
PE
17045 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
17046
fca8fe46 17047 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 17048 (update_syntax_table): Use unsigned instead of int.
fca8fe46 17049
06a0259a 17050 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 17051 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 17052 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 17053
e7b9e80f
PE
17054 * print.c (print_error_message): Avoid int overflow.
17055
56201685
PE
17056 * font.c (font_list_entities): Redo for clarity,
17057 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
17058
78834453 17059 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 17060 (font_score): Avoid potential overflow in diff calculation.
78834453 17061
0bc0b309 17062 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 17063 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 17064
e610eaca
PE
17065 * eval.c (funcall_lambda): Rename local to avoid shadowing.
17066
b895abce
PE
17067 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
17068 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
17069 can always succeed if overflow has undefined behavior.
17070
1f1d9321 17071 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 17072 (wordify): Omit three unnecessary tests.
1f1d9321 17073
c59478bc
PE
17074 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
17075 All callers changed. This avoids the need for an unused var.
17076
79b73827
PE
17077 * casefiddle.c (casify_region): Remove var that is set but not used.
17078
a4db5dfe
PE
17079 * dired.c (file_name_completion): Remove var that is set but not used.
17080
43aae36e
PE
17081 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
17082
2a47c44d 17083 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 17084 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 17085
a37c69bf
PE
17086 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
17087 Check for integer overflow on size calculations.
17088
328ab8e7
PE
17089 * buffer.c (Fprevious_overlay_change): Remove var that is set
17090 but not used.
17091
e5a2a5cb
PE
17092 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
17093 Remove vars that are set but not used.
8d84a6eb 17094 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 17095 (timer_check_2): Mark vars as initialized.
e5a2a5cb 17096
a60e5f68
PE
17097 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
17098
f661cb61 17099 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 17100 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 17101
f0397f5a
PE
17102 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
17103 that are set but not used.
17104
8664db06 17105 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 17106 if XCreateBitmapFromData fails (Bug#8410).
8664db06 17107
6abdaa4a
PE
17108 * xselect.c (x_get_local_selection, x_handle_property_notify):
17109 Remove vars that are set but not used.
17110
0ce7538d 17111 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 17112 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 17113
9ae848fc
PE
17114 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
17115 Remove var that is set but not used.
0b918413
PE
17116 (scroll_bar_windows_size): Now size_t, not int.
17117 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
17118 Check for overflow.
9ae848fc 17119
a5a62657
PE
17120 * xfaces.c (realize_named_face): Remove vars that are set but not used.
17121 (map_tty_color) [!defined MSDOS]: Likewise.
17122
5c5cdd39
PE
17123 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
17124
66ebf983
PE
17125 * coding.c: Remove vars that are set but not used.
17126 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
17127 All callers changed.
17128 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
17129 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
17130 (decode_coding_charset): Remove vars that are set but not used.
17131
1be4d761
PE
17132 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
17133 that is set but not used.
17134
47553fa8
PE
17135 * print.c (print_object): Remove var that is set but not used.
17136
1f7196bf 17137 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
17138 The gnulib version avoids calling malloc in the usual case,
17139 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
17140 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
17141 * filelock.c (current_lock_owner): Likewise.
17142 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
17143 * sysdep.c: Include allocator.h, careadlinkat.h.
17144 (emacs_no_realloc_allocator): New static constant.
17145 (emacs_readlink): New function.
fdb61804
PE
17146 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
17147 ../lib/careadlinkat.h.
d1fdcab7 17148
f84c17c7
SM
171492011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
17150
17151 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
17152 first non-nil return value).
17153
ef3862ad
JD
171542011-04-03 Jan Djärv <jan.h.d@swipnet.se>
17155
17156 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
17157 if not defined (Bug#8403).
17158
376a7006
JB
171592011-04-02 Juanma Barranquero <lekktu@gmail.com>
17160
17161 * xdisp.c (display_count_lines): Remove parameter `start',
17162 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
17163 (get_char_face_and_encoding): Remove parameter `multibyte_p',
17164 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
17165 (fill_stretch_glyph_string): Remove parameters `row' and `area',
17166 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
17167 and thereabouts. All callers changed.
17168 (get_per_char_metric): Remove parameter `f', unused since
17169 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
17170
6ca3801d
JM
171712011-04-02 Jim Meyering <meyering@redhat.com>
17172
17173 do not dereference NULL upon failed strdup
17174 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
17175 (ns_get_family): Likewise.
17176
d8e2b5ba
JB
171772011-04-02 Juanma Barranquero <lekktu@gmail.com>
17178
17179 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
17180
8c74fcbd
JD
171812011-04-02 Jan Djärv <jan.h.d@swipnet.se>
17182
17183 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
17184 later (Bug#8403).
17185
7200d79c
SM
171862011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
17187
03408648 17188 Add lexical binding.
7200d79c 17189
03408648
SM
17190 * window.c (Ftemp_output_buffer_show): New fun.
17191 (Fsave_window_excursion):
17192 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
17193
17194 * lread.c (lisp_file_lexically_bound_p): New function.
17195 (Fload): Bind Qlexical_binding.
17196 (readevalloop): Remove `evalfun' arg.
17197 Bind Qinternal_interpreter_environment.
17198 (Feval_buffer): Bind Qlexical_binding.
17199 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
17200 Mark as dynamic.
17201 (syms_of_lread): Declare `lexical-binding'.
17202
17203 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
17204
17205 * keyboard.c (eval_dyn): New fun.
17206 (menu_item_eval_property): Use it.
ca105506
SM
17207
17208 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 17209
03408648
SM
17210 * fns.c (concat, mapcar1): Accept byte-code-functions.
17211
17212 * eval.c (Fsetq): Handle lexical vars.
17213 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
17214 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
17215 (FletX, Flet): Obey lexical binding.
17216 (Fcommandp): Handle closures.
17217 (Feval): New `lexical' arg.
17218 (eval_sub): New function extracted from Feval. Use it almost
17219 everywhere where Feval was used. Look up vars in lexical env.
17220 Handle closures.
17221 (Ffunctionp): Move from subr.el.
17222 (Ffuncall): Handle closures.
17223 (apply_lambda): Remove `eval_flags'.
17224 (funcall_lambda): Handle closures and new byte-code-functions.
17225 (Fspecial_variable_p): New function.
17226 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
17227 but without exporting it to Lisp.
23aba0ea 17228
23aba0ea 17229 * doc.c (Fdocumentation, store_function_docstring):
03408648 17230 * data.c (Finteractive_form): Handle closures.
23aba0ea 17231
03408648
SM
17232 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
17233 interactive spec.
ba83908c 17234
04f2d78b
CB
17235 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
17236 New byte-codes.
03408648
SM
17237 (exec_byte_code): New function extracted from Fbyte_code to handle new
17238 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 17239
03408648 17240 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 17241
03408648 17242 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 17243
e2abce01
JB
172442011-03-31 Juanma Barranquero <lekktu@gmail.com>
17245
17246 * xdisp.c (redisplay_internal): Fix prototype.
17247
63696a73 172482011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 17249
63696a73 17250 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
17251 (try_scrolling): Use it when setting scroll_limit.
17252 Limit scrolling to 100 screen lines.
63696a73
EZ
17253 (redisplay_window): Even when falling back on "recentering",
17254 position point in the window according to scroll-conservatively,
17255 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
17256
17257 (try_scrolling): When point is above the window, allow searching
17258 as far as scroll_max, or one screenful, to compute vertical
17259 distance from PT to the scroll margin position. This prevents
17260 try_scrolling from unnecessarily failing when
17261 scroll-conservatively is set to a value slightly larger than the
17262 window height. Clean up the case of PT below the margin at bottom
17263 of window: scroll_max can no longer be INT_MAX. When aggressive
17264 scrolling is in use, don't let point enter the opposite scroll
17265 margin as result of the scroll.
17266 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
17267 threshold of 100 lines for never-recentering scrolling.
17268
e4cc2dfc
JB
172692011-03-31 Juanma Barranquero <lekktu@gmail.com>
17270
17271 * dispextern.h (move_it_by_lines):
17272 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
17273 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
17274 (message_log_check_duplicate): Remove parameters `prev_bol' and
17275 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
17276 (redisplay_internal): Remove parameter `preserve_echo_area',
17277 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
17278
17279 * indent.c (Fvertical_motion):
17280 * window.c (window_scroll_pixel_based, Frecenter):
17281 Don't pass `need_y_p' to `move_it_by_lines'.
17282
1c470562
SM
172832011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
17284
44f230aa
SM
17285 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
17286 steal a few bits to be more compact.
17287 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
17288 Remove unneeded casts.
17289
1c470562
SM
17290 * bytecode.c (Fbyte_code): CAR and CDR can GC.
17291
888adce9
ZK
172922011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
17293
17294 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
17295 binding" message (bug#7967).
17296
f838ed7b
PE
172972011-03-30 Paul Eggert <eggert@cs.ucla.edu>
17298
77861b95
PE
17299 Fix more problems found by GCC 4.6.0's static checks.
17300
de6dbc14
PE
17301 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
17302 Remove unused local var.
17303
f838ed7b
PE
17304 * editfns.c (Fmessage_box): Remove unused local var.
17305
792c7b2b
PE
17306 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
17307 (note_mode_line_or_margin_highlight, note_mouse_highlight):
17308 Omit unused local vars.
c499e557 17309 * window.c (shrink_windows): Omit unused local var.
b01a1c29 17310 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
17311 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
17312 Omit unused local var.
17313
ba0165e1
PE
17314 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
17315 Don't assume string length fits in int.
32ad8845 17316 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 17317 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 17318
3c59b4c9
PE
17319 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
17320 instead of alloca (Bug#8344).
17321
a3eed478 17322 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 17323 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 17324
eb4d412d
PE
17325 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
17326
1658b401
PE
17327 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
17328 concerns.
17329
17330 * term.c (produce_glyphless_glyph): Remove unnecessary test.
17331
17332 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 17333
9a2c6e05
PE
17334 * keyboard.c (syms_of_keyboard): Use the same style as later
17335 in this function when indexing through an array. This also
17336 works around GCC bug 48267.
17337
03d0a109
PE
17338 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
17339
44f730c8
PE
17340 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
17341
fe75f926
PE
17342 * chartab.c (sub_char_table_ref_and_range): Redo for slight
17343 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
17344
ffa8c828
PE
17345 * keyboard.c, keyboard.h (num_input_events): Now size_t.
17346 This avoids undefined behavior on integer overflow, and is a bit
17347 more convenient anyway since it is compared to a size_t variable.
17348
c5101a77
PE
17349 Variadic C functions now count arguments with size_t, not int.
17350 This avoids an unnecessary limitation on 64-bit machines, which
17351 caused (substring ...) to crash on large vectors (Bug#8344).
17352 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
17353 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 17354 All variadic functions and their callers changed accordingly.
c5101a77
PE
17355 (struct gcpro.nvars): Now size_t, not int. All uses changed.
17356 * data.c (arith_driver, float_arith_driver): Likewise.
17357 * editfns.c (general_insert_function): Likewise.
17358 * eval.c (struct backtrace.nargs, interactive_p)
17359 (internal_condition_case_n, run_hook_with_args, apply_lambda)
17360 (funcall_lambda, mark_backtrace): Likewise.
17361 * fns.c (concat): Likewise.
17362 * frame.c (x_set_frame_parameters): Likewise.
17363 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
17364 0 if not found, not -1. All callers changed.
17365
dd3f25f7
PE
17366 * alloc.c (garbage_collect): Don't assume stack size fits in int.
17367 (stack_copy_size): Now size_t, not int.
17368 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
17369
461c2ab9
JB
173702011-03-28 Juanma Barranquero <lekktu@gmail.com>
17371
17372 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
17373 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
17374 All callers changed.
17375
17376 * lisp.h (multibyte_char_to_unibyte):
17377 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
17378 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
17379 * character.h (CHAR_TO_BYTE8):
17380 * cmds.c (internal_self_insert):
17381 * editfns.c (general_insert_function):
17382 * keymap.c (push_key_description):
17383 * search.c (Freplace_match):
17384 * xdisp.c (message_dolog, set_message_1): All callers changed.
17385
f6d62986
SM
173862011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
17387
17388 * keyboard.c (safe_run_hook_funcall): New function.
17389 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
17390 don't set the hook to nil, but remove the offending function instead.
17391 (Qcommand_hook_internal): Remove, unused.
17392 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
17393 Vcommand_hook_internal.
17394
17395 * eval.c (enum run_hooks_condition): Remove.
17396 (funcall_nil, funcall_not): New functions.
17397 (run_hook_with_args): Call each function through a `funcall' argument.
17398 Remove `cond' argument, now redundant.
17399 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
17400 (Frun_hook_with_args_until_failure): Adjust accordingly.
17401 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
17402
1db5b1ad
JB
174032011-03-28 Juanma Barranquero <lekktu@gmail.com>
17404
17405 * dispextern.h (string_buffer_position): Remove declaration.
17406
17407 * print.c (strout): Remove parameter `multibyte', unused since
17408 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
17409
17410 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
17411 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
17412 All callers changed.
17413
17414 * w32.c (_wsa_errlist): Use braces for struct initializers.
17415
17416 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
17417 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
17418 All callers changed.
17419 (string_buffer_position): Likewise. Also, make static (it's never
17420 used outside xdisp.c).
17421 (cursor_row_p): Remove parameter `w', unused since
17422 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
17423 (decode_mode_spec): Remove parameter `precision', introduced during
17424 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
17425 All callers changed.
17426
5ffb62aa
JD
174272011-03-27 Jan Djärv <jan.h.d@swipnet.se>
17428
17429 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
17430
461c2ab9 174312011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
17432
17433 * nsterm.m (ns_menu_bar_is_hidden): New variable.
17434 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
17435 (ns_update_auto_hide_menu_bar): New functions.
17436 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
17437 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
17438 ns_constrain_all_frames.
17439 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
17440 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
17441
5c380ffb
JD
174422011-03-27 Jan Djärv <jan.h.d@swipnet.se>
17443
17444 * nsmenu.m (runDialogAt): Remove argument to timer_check.
17445
9af30bdf
GM
174462011-03-27 Glenn Morris <rgm@gnu.org>
17447
17448 * syssignal.h: Replace RETSIGTYPE with void.
17449 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
17450 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
17451 Replace SIGTYPE with void everywhere.
17452 * s/usg5-4-common.h (SIGTYPE): Remove definition.
17453 * s/template.h (SIGTYPE): Remove commented out definition.
17454
e2abce01
JB
174552011-03-26 Eli Zaretskii <eliz@gnu.org>
17456
17457 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
17458 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
17459
f868cd8a
JB
174602011-03-26 Juanma Barranquero <lekktu@gmail.com>
17461
59eb0929
JB
17462 * w32.c (read_unc_volume): Use parameter `henum', instead of
17463 global variable `wget_enum_handle'.
17464
17465 * keymap.c (describe_vector): Remove parameters `indices' and
17466 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
17467 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
17468
f868cd8a
JB
17469 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
17470
17471 * keyboard.c (timer_check): Remove parameter `do_it_now',
17472 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
17473 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
17474 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
17475
17476 * keyboard.c (read_char):
17477 * w32menu.c (w32_menu_display_help):
17478 * xmenu.c (show_help_event, menu_help_callback):
17479 Adjust calls to `show_help_echo'.
17480
17481 * gtkutil.c (xg_maybe_add_timer):
17482 * keyboard.c (readable_events):
17483 * process.c (wait_reading_process_output):
17484 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
17485
17486 * insdel.c (adjust_markers_gap_motion):
17487 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
17488 (gap_left, gap_right): Don't call it.
17489
2ecf6fdb
CY
174902011-03-25 Chong Yidong <cyd@stupidchicken.com>
17491
17492 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
17493 incurred during fontification.
17494
6b1f9ba4
JB
174952011-03-25 Juanma Barranquero <lekktu@gmail.com>
17496
17497 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
17498 (DEFVAR_PER_BUFFER): Don't pass it.
17499
17500 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
17501 (scrolling_window): Don't pass it.
17502
0f4a96b5
JB
175032011-03-25 Juanma Barranquero <lekktu@gmail.com>
17504
17505 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
17506
17507 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
17508 and `suffix'.
17509 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
17510 of variables specific to SELinux and computation of `encoded_absname'.
17511
17512 * image.c (XPutPixel): Remove unused variable `height'.
17513
17514 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
17515
17516 * unexw32.c (get_section_info): Remove unused variable `section'.
17517
17518 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
17519 (system_process_attributes): Remove unused variable `sess'.
17520 (sys_read): Remove unused variable `err'.
17521
17522 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
17523 (w32_wnd_proc): Remove unused variable `isdead'.
17524 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
17525 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
17526 (x_create_tip_frame): Remove unused variable `tem'.
17527
17528 * w32inevt.c (w32_console_read_socket):
17529 Remove unused variable `no_events'.
17530
17531 * w32term.c (x_draw_composite_glyph_string_foreground):
17532 Remove unused variable `width'.
17533
1149507c
JB
175342011-03-24 Juanma Barranquero <lekktu@gmail.com>
17535
17536 * w32term.c (x_set_glyph_string_clipping):
17537 Don't pass uninitialized region to CombineRgn.
17538
9c88f339
JB
175392011-03-23 Juanma Barranquero <lekktu@gmail.com>
17540
17541 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
17542 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
17543 (Fx_close_connection): Remove unused variable `i'.
17544
17545 * w32font.c (w32font_draw): Return number of glyphs.
17546 (w32font_open_internal): Remove unused variable `i'.
17547 (w32font_driver): Add missing initializer.
17548
17549 * w32menu.c (utf8to16): Remove unused variable `utf16'.
17550 (fill_in_menu): Remove unused variable `items_added'.
17551
17552 * w32term.c (last_mouse_press_frame): Remove static global variable.
17553 (w32_clip_to_row): Remove unused variable `f'.
17554 (x_delete_terminal): Remove unused variable `i'.
17555
17556 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
17557 (NOTHING): Remove unused static global variable.
17558 (uniscribe_check_otf): Remove unused variable `table'.
17559 (uniscribe_font_driver): Add missing initializers.
17560
dee091a3
JD
175612011-03-23 Julien Danjou <julien@danjou.info>
17562
17563 * term.c (Fsuspend_tty, Fresume_tty):
17564 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
17565 * window.c (temp_output_buffer_show):
17566 * insdel.c (signal_before_change):
17567 * frame.c (Fhandle_switch_frame):
17568 * fileio.c (Fdo_auto_save):
17569 * emacs.c (Fkill_emacs):
17570 * editfns.c (save_excursion_restore):
17571 * cmds.c (internal_self_insert):
17572 * callint.c (Fcall_interactively):
17573 * buffer.c (Fkill_all_local_variables):
17574 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
17575 Use Frun_hooks.
0f4a96b5 17576 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 17577 unconditionally since it does the check itself.
dee091a3 17578
2c520ab5 175792011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 17580
c9c49752
PE
17581 Fix more problems found by GCC 4.5.2's static checks.
17582
8abc3f12
PE
17583 * coding.c (encode_coding_raw_text): Avoid unnecessary test
17584 the first time through the loop, since we know p0 < p1 then.
17585 This also avoids a gcc -Wstrict-overflow warning.
17586
a2d26660
PE
17587 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
17588 leading to a memory leak, possible in functions like
17589 load_charset_map_from_file that can allocate an unbounded number
b12ef411 17590 of objects (Bug#8318).
a2d26660 17591
916c72e9
PE
17592 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
17593 that could (at least in theory) be that large.
17594
19ab8a18
PE
17595 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
17596 This is less likely to overflow, and avoids undefined behavior if
17597 overflow does occur. All callers changed. Use strtoul to scan
17598 for the unsigned long integer.
b7cbbd6f
PE
17599 (pint2hrstr): Simplify and tune code slightly.
17600 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 17601
f0641eff
PE
17602 * scroll.c (do_scrolling): Work around GCC bug 48228.
17603 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
17604
7f650bb9
PE
17605 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
17606 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
17607 (validate_x_resource_name): Simplify count usage.
17608 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 17609
37dd57d1
PE
17610 * fileio.c (Fcopy_file): Report error if fchown or fchmod
17611 fail (Bug#8306).
81e56e61 17612
699979fc 17613 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 17614
401bf9b4
PE
17615 * process.c (Fmake_network_process): Use socklen_t, not int,
17616 where POSIX says socklen_t is required in portable programs.
17617 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 17618 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
17619 (Fmake_network_process, server_accept_connection):
17620 (wait_reading_process_output, read_process_output):
17621 Likewise.
17622
b93aacde
PE
17623 * process.c: Rename or move locals to avoid shadowing.
17624 (list_processes_1, Fmake_network_process):
17625 (read_process_output_error_handler, exec_sentinel_error_handler):
17626 Rename or move locals.
4dc343ee 17627 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 17628 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 17629 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 17630 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 17631 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 17632
af8a867c 17633 Make tparam.h and terminfo.c consistent.
44f230aa
SM
17634 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
17635 Include tparam.h instead, since it declares them.
af8a867c
PE
17636 * cm.h (PC): Remove extern decl; tparam.h now does this.
17637 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
17638 * terminfo.c: Include tparam.h, to check interfaces.
17639 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
17640 (tparam): Adjust signature to match interface in tparam.h;
17641 this removes some undefined behavior. Check that outstring and len
17642 are zero, which they always are with Emacs.
17643 * tparam.h (PC, BC, UP): New extern decls.
17644
0248044d 17645 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 17646 (xftfont_open): Rename locals to avoid shadowing.
0248044d 17647
8ff096c1 17648 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
17649 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
17650 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 17651 (ftfont_list): Remove unused local.
49eaafba
PE
17652 (get_adstyle_property, ftfont_pattern_entity):
17653 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
17654 Rename locals to avoid shadowing.
8ff096c1 17655
e2be39f6
PE
17656 * xfont.c (xfont_list_family): Mark var as initialized.
17657
c9735e30
PE
17658 * xml.c (make_dom): Now static.
17659
8f5201ae
PE
17660 * composite.c (composition_compute_stop_pos): Rename local to
17661 avoid shadowing.
b246f932
PE
17662 (composition_reseat_it): Remove unused locals.
17663 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 17664 (composition_update_it): Mark var as initialized.
11b61122
PE
17665 (find_automatic_composition): Mark vars as initialized,
17666 with a FIXME (Bug#8290).
8f5201ae 17667
760fbc2c
PE
17668 character.h: Rename locals to avoid shadowing.
17669 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
17670 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
17671 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
17672 (BUF_DEC_POS): Be more systematic about renaming local temporaries
17673 to avoid shadowing.
17674
ff08eb85
PE
17675 * textprop.c (property_change_between_p): Remove; unused.
17676
fc7bf025
PE
17677 * intervals.c (interval_start_pos): Now static.
17678
235d7abc
PE
17679 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
17680
44f230aa
SM
17681 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
17682 Rename locals to avoid shadowing.
3e7d6594 17683
50060332
PE
17684 * sound.c (wav_play, au_play, Fplay_sound_internal):
17685 Fix pointer signedness.
d01f234b 17686 (alsa_choose_format): Remove unused local var.
c83b8872
PE
17687 (wav_play): Initialize a variable to 0, to prevent undefined
17688 behavior (Bug#8278).
50060332 17689
c4fc4e30
PE
17690 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
17691
918436ed
PE
17692 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
17693
c939f91b
PE
17694 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
17695 clobbering (Bug#8298).
b9c7f648
PE
17696 * sysdep.c (sys_subshell): Likewise.
17697 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 17698
6bd8c144
PE
17699 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
17700 This should get cleaned up, so that child_setup has the
17701 same signature on all platforms.
17702
7710357c 17703 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 17704 (relocate_fd): Rename locals to avoid shadowing.
7710357c 17705
c59da222
CY
177062011-03-22 Chong Yidong <cyd@stupidchicken.com>
17707
17708 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
17709 not to be necessary, and produces flickering.
17710
66b87493
GM
177112011-03-20 Glenn Morris <rgm@gnu.org>
17712
17713 * config.in: Remove file.
17714
45b6f6d5
JB
177152011-03-20 Juanma Barranquero <lekktu@gmail.com>
17716
17717 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
17718 are now in src/globals.h.
17719 (syms_of_minibuf): Remove spurious & from previous change.
17720
cd394be1 177212011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
17722
17723 * minibuf.c (completing-read-function): New variable.
17724 (completing-read-default): Rename from completing-read.
17725 (completing-read): Call completing-read-function.
17726
b14e3e21
CY
177272011-03-19 Juanma Barranquero <lekktu@gmail.com>
17728
17729 * xfaces.c (Fx_load_color_file):
17730 Read color file from absolute filename (bug#8250).
17731
f2b726e6
JB
177322011-03-19 Juanma Barranquero <lekktu@gmail.com>
17733
17734 * makefile.w32-in: Update dependencies.
17735
09f6ff02
EZ
177362011-03-17 Eli Zaretskii <eliz@gnu.org>
17737
17738 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
17739
29a6015a
PE
177402011-03-17 Paul Eggert <eggert@cs.ucla.edu>
17741
a3a6c54e
PE
17742 Fix more problems found by GCC 4.5.2's static checks.
17743
b766f867
PE
17744 * process.c (make_serial_process_unwind, send_process_trap):
17745 (sigchld_handler): Now static.
17746
be02381c
PE
17747 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
17748 That way, the code declares only the vars that it needs.
17749 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
17750 * s/cygwin.h (PTY_ITERATION): Likewise.
17751 * s/darwin.h (PTY_ITERATION): Likewise.
17752 * s/gnu-linux.h (PTY_ITERATION): Likewise.
17753
57048744
PE
17754 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
17755 * process.c (allocate_pty): Don't declare stb unless it's needed.
17756
7914961c 17757 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
17758 (CONSTANTLIM): Remove; unused.
17759 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
17760 Define only if needed.
7914961c 17761
b3967b18
PE
17762 * unexelf.c (unexec): Name an expression,
17763 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
17764 Use a different way to cause a compilation error if anyone uses
17765 n rather than nn, a way that does not involve shadowing.
73366a00 17766 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 17767
29a6015a
PE
17768 * deps.mk (unexalpha.o): Remove; unused.
17769
43cfc33e 17770 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 17771 * unexec.h: New file.
ce701a33
PE
17772 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
17773 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
17774 Depend on unexec.h.
17775 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
17776 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
17777 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 17778 Change as necessary to match prototype in unexec.h.
ce701a33 17779
01f44d5a
PE
17780 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
17781 shadowing.
4f63c6bb 17782 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 17783
a6670b0b
PE
17784 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
17785 Rename locals to avoid shadowing.
17786
cef2010d 17787 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 17788 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 17789
d4d7173a
PE
17790 * print.c (Fredirect_debugging_output): Fix pointer signedess.
17791
f08b802a
PE
17792 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
17793 warning when compiling print.c.
17794
3ddb0639
PE
17795 * font.c (font_unparse_fcname): Abort in an "impossible" situation
17796 instead of using an uninitialized var.
5ad03b97 17797 (font_sort_entities): Mark var as initialized.
3ddb0639 17798
170a2692
PE
17799 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
17800
e663c700
PE
17801 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
17802 pointers to constants.
89bc529a 17803 (font_parse_fcname): Remove unused vars.
7b81e2d0 17804 (font_delete_unmatched): Now static.
ea838e10 17805 (font_get_spec): Remove; unused.
13a547c6
PE
17806 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
17807 (font_update_drivers, Ffont_get_glyphs, font_add_log):
17808 Rename or move locals to avoid shadowing.
e663c700 17809
2a80c887 17810 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 17811 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 17812
1384fa33 17813 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 17814 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 17815
8b2c52e9
PE
17816 * alloc.c (mark_backtrace): Move decl from here ...
17817 * lisp.h: ... to here, so that it can be checked.
17818
475545b5 17819 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 17820 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
17821 (lisp_indirect_variable): Name an expression,
17822 to avoid gcc -Wbad-function-cast warning.
1faed8ae 17823 (Fdefvar): Rename locals to avoid shadowing.
475545b5 17824
b1349114 17825 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 17826 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 17827 Use const pointer when appropriate.
b1349114 17828
a2928364
PE
17829 * lisp.h (get_system_name, get_operating_system_release):
17830 Move decls here, to check interfaces.
17831 * process.c (get_operating_system_release): Move decl to lisp.h.
17832 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
17833 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
17834 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
17835 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
17836 (Fformat_time_string, Fencode_time, Finsert_char):
17837 (Ftranslate_region_internal, Fformat):
17838 Rename or remove local vars to avoid shadowing.
9710023e 17839 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 17840
a415e694
PE
17841 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
17842 avoid shadowing.
17843
8ef4622d
PE
17844 * lisp.h (eassert): Check that the argument compiles, even if
17845 ENABLE_CHECKING is not defined.
17846
946f9a5b
PE
17847 * data.c (Findirect_variable): Name an expression, to avoid
17848 gcc -Wbad-function-cast warning.
112396d6 17849 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 17850 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
17851 (Fmake_variable_buffer_local, Fmake_local_variable):
17852 Mark variables as initialized.
52746918 17853 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 17854
e5aab7e7 17855 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
17856 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
17857 Rename locals to avoid shadowing.
dff45157
PE
17858 (mark_stack): Move local variables into the #ifdef region where
17859 they're used.
7bc26fdb
PE
17860 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
17861 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
17862 needed otherwise.
17863 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
17864 (GC_STRING_CHARS): Remove; not used.
d40d4be1 17865 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 17866
e5aab7e7
PE
17867 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
17868 avoids undefined behavior in theory.
17869
4da60324
PE
17870 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
17871
88043301
PE
17872 Use functions, not macros, for up- and down-casing (Bug#8254).
17873 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
17874 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
17875 to use the following functions instead of these macros.
17876 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
17877 EMACS_INT, since callers assume the returned value fits in int.
17878 (upcase1): Likewise, for UPCASE_TABLE.
17879 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 17880 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 17881 the race-condition problem in the old DOWNCASE.
88043301 17882
19ed5445
PE
17883 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
17884 Rename locals to avoid shadowing.
17885 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
17886 (regex_compile, re_search_2, re_match_2_internal):
17887 Remove unused local vars.
952db0d7
PE
17888 (FREE_VAR): Rewrite so as not to use empty "else",
17889 which gcc can warn about.
da053e48 17890 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
17891 (RETALLOC_IF): Define only if needed.
17892 (WORDCHAR_P): Likewise. This one is never needed, but is used
17893 only in a comment talking about a compiler bug, so put inside
17894 the #if 0 of that comment.
17895 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
17896 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
17897 Remove; unused.
19ed5445 17898
1f3561e4 17899 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
17900 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
17901 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 17902
ded6f8f7
PE
17903 * search.c (simple_search): Remove unused var.
17904
dbd37a95
PE
17905 * dired.c (compile_pattern): Move decl from here ...
17906 * lisp.h: ... to here, so that it can be checked.
17907 (struct re_registers): New forward decl.
17908
7e47afad
PE
17909 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
17910
85f24f61
PE
17911 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
17912 All uses changed.
17913 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
17914 Rename locals to avoid shadowing.
5671df8f 17915 (Fvertical_motion): Mark locals as initialized.
85f24f61 17916
181aa2be 17917 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 17918 (casify_region): Mark local as initialized.
181aa2be 17919
930d429c
PE
17920 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
17921
7082eac6
PE
17922 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
17923 New macros, so that the caller can use some names other than
17924 gcpro1, gcpro2, etc.
17925 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
17926 of the new macros.
17927 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
17928 argument, for consistency with GCPRO2_VAR, etc: it is now the
17929 prefix of the variable, not the variable itself. All uses
17930 changed.
38b2c076
PE
17931 * dired.c (directory_files_internal, file_name_completion):
17932 Rename locals to avoid shadowing.
17933
15206ed9
PE
17934 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
17935 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
17936 dired.c's scmp function, had undefined behavior.
17937 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
17938 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
17939 * buffer.h: ... to here, because these macros use current_buffer,
17940 and the new implementation with inline functions needs to have
17941 current_buffer in scope now, rather than later when the macros
17942 are used.
17943 (downcase, upcase1): New static inline functions.
17944 (DOWNCASE, UPCASE1): Reimplement using these functions.
17945 This avoids undefined behavior in expressions like
17946 DOWNCASE (x) == DOWNCASE (y), which previously suffered
17947 from race conditions in accessing the global variables
17948 case_temp1 and case_temp2.
17949 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
17950 * lisp.h (case_temp1, case_temp2): Remove their decls.
17951 * character.h (ASCII_CHAR_P): Move from here ...
17952 * lisp.h: ... to here, so that the inline functions mentioned
17953 above can use them.
17954
4a6bea26
PE
17955 * dired.c (directory_files_internal_unwind): Now static.
17956
f14b7e14
PE
17957 * fileio.c (file_name_as_directory, directory_file_name):
17958 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
17959 Now static.
2893f146
PE
17960 (file_name_as_directory): Use const pointers when appropriate.
17961 (Fexpand_file_name): Likewise. In particular, newdir might
17962 point at constant storage, so make it a const pointer.
fd4ead52 17963 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
17964 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
17965 signedness issues.
f839df0c
PE
17966 (Fset_file_times, Finsert_file_contents, auto_save_error):
17967 Rename locals to avoid shadowing.
f14b7e14 17968
5716756e 17969 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
17970 (Ftry_completion, Fall_completions): Rename or remove locals
17971 to avoid shadowing.
5716756e 17972
b4c3046a
PE
17973 * marker.c (bytepos_to_charpos): Remove; unused.
17974
b45db522
PE
17975 * lisp.h (verify_bytepos, count_markers): New decls,
17976 so that gcc does not warn that these functions aren't declared.
17977
85876d07
PE
17978 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
17979 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 17980 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 17981 (copy_text): Remove unused local var.
85876d07 17982
03d78a21 17983 * filelock.c (within_one_second): Now static.
b3dd38ab 17984 (lock_file_1): Rename local to avoid shadowing.
03d78a21 17985
5df8f01b
PE
17986 * buffer.c (fix_overlays_before): Mark locals as initialized.
17987 (fix_start_end_in_overlays): Likewise. This function should be
17988 simplified by using pointers-to-pointers, but that's a different
17989 matter.
b1d876f1 17990 (switch_to_buffer_1): Now static.
8f54f30a
PE
17991 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
17992 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 17993
a70072c9 17994 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 17995 Fix pointer signedness issue.
edced198
PE
17996 (sys_subshell): Mark local as volatile if checking for lint,
17997 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 17998 (MAXPATHLEN): Define only if needed.
a70072c9 17999
a0977c44
PE
18000 * process.c (serial_open, serial_configure): Move decls from here ...
18001 * systty.h: ... to here, so that they can be checked.
18002
a884fdcc
PE
18003 * fns.c (get_random, seed_random): Move extern decls from here ...
18004 * lisp.h: ... to here, so that they can be checked.
18005
604efe86 18006 * sysdep.c (reset_io): Now static.
b8950c94 18007 (wait_for_termination_signal): Remove; unused.
604efe86 18008
38fc62d9
PE
18009 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
18010 (copy_keymap_item, append_key, push_text_char_description):
18011 Now static.
1004a21a 18012 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 18013 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
18014 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
18015 (describe_map_tree):
18016 Rename locals to avoid shadowing.
38fc62d9 18017
2f2650da
PE
18018 * keyboard.c: Declare functions static if they are not used elsewhere.
18019 (echo_char, echo_dash, cmd_error, top_level_2):
18020 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
18021 (read_char, kbd_buffer_get_event, make_lispy_position):
18022 (make_lispy_event, make_lispy_movement, apply_modifiers):
18023 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
18024 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
18025 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 18026 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 18027 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 18028
a053e86c 18029 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
18030 (mark_kboards): Move decl here ...
18031 * alloc.c (mark_kboards): ... from here.
a053e86c 18032
4752793e
PE
18033 * lisp.h (force_auto_save_soon): New decl.
18034
74f10ca7 18035 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
18036 (DEFINE_DUMMY_FUNCTION): New macro.
18037 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
18038 Use it.
c03cd23f
PE
18039 (main): Add casts to avoid warnings
18040 if GCC considers string literals to be constants.
74f10ca7 18041
022e70d4
PE
18042 * lisp.h (fatal_error_signal): Add decl, since it's exported.
18043
59d6fe83
PE
18044 * dbusbind.c: Pointer signedness fixes.
18045 (xd_signature, xd_append_arg, xd_initialize):
18046 (Fdbus_call_method, Fdbus_call_method_asynchronously):
18047 (Fdbus_method_return_internal, Fdbus_method_error_internal):
18048 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
18049 (Fdbus_register_signal): Use SSDATA when the context wants char *.
18050
78320123
PE
18051 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
18052 if GCC considers string literals to be constants.
49cebcca 18053 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 18054
35ac2a97
SM
180552011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
18056
fb103ca9
SM
18057 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
18058 (print_preprocess, print_object): New macro to fix last change.
18059
35ac2a97
SM
18060 * print.c (print_preprocess): Don't forget font objects.
18061
62973b41
JB
180622011-03-16 Juanma Barranquero <lekktu@gmail.com>
18063
18064 * emacs.c (USAGE3): Doc fixes.
18065
0e48bb22
AS
180662011-03-15 Andreas Schwab <schwab@linux-m68k.org>
18067
18068 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
18069 structure.
18070
7684e57b
JB
180712011-03-14 Juanma Barranquero <lekktu@gmail.com>
18072
18073 * lisp.h (VWindow_system, Qfile_name_history):
18074 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
18075 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
18076 (w32_system_caret_x, w32_system_caret_y): Declare extern.
18077
18078 * w32select.c: Don't #include "keyboard.h".
c96bbc66 18079 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
18080
18081 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
18082 * w32console.c (detect_input_pending, read_input_pending)
18083 (encode_terminal_code):
18084 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
18085 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
18086 (w32_system_caret_y, Qfile_name_history):
18087 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
18088 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
18089 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
18090 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
18091 * w32proc.c (Qlocal, report_file_error):
18092 * w32term.c (Vwindow_system, updating_frame):
18093 * w32uniscribe.c (initialized, uniscribe_font_driver):
18094 Remove unneeded extern declarations.
18095
2aa46d6c
CY
180962011-03-14 Chong Yidong <cyd@stupidchicken.com>
18097
c96bbc66 18098 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 18099
cffc6f3b
CY
181002011-03-13 Chong Yidong <cyd@stupidchicken.com>
18101
18102 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
18103 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
18104 These macros can no longer be used for assignment.
18105
44f230aa
SM
18106 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
18107 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
18108 (record_buffer_markers, fetch_buffer_markers): New functions for
18109 recording and fetching special buffer markers.
18110 (set_buffer_internal_1, set_buffer_temp): Use them.
18111
18112 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
18113
18114 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
18115
18116 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
18117 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
18118
18119 * xdisp.c (hscroll_window_tree):
18120 (reconsider_clip_changes): Use PT instead of BUF_PT.
18121
d251f04b
EZ
181222011-03-13 Eli Zaretskii <eliz@gnu.org>
18123
18124 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
18125 $(EMACS_ROOT)/lib/intprops.h.
18126
f0c77cd1
PE
181272011-03-13 Paul Eggert <eggert@cs.ucla.edu>
18128
3eca4629
PE
18129 Fix more problems found by GCC 4.5.2's static checks.
18130
7c86ee98
PE
18131 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
18132 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
18133 (xg_free_frame_widgets): Make it clear that a local variable is
18134 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
18135 (gdk_window_get_screen): Make it clear that this macro is needed
18136 only if USE_GTK_TOOLTIP.
1e5524e7
PE
18137 (int_gtk_range_get_value): New function, which avoids a diagnostic
18138 from gcc -Wbad-function-cast.
18139 (xg_set_toolkit_scroll_bar_thumb): Use it.
18140 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
18141 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
18142 (get_utf8_string, xg_get_file_with_chooser):
18143 Rename locals to avoid shadowing.
18144 (create_dialog): Move locals to avoid shadowing.
7c86ee98 18145
41729b81
PE
18146 * xgselect.c (xg_select): Remove unused var.
18147
f0c77cd1
PE
18148 * image.c (four_corners_best): Mark locals as initialized.
18149 (gif_load): Initialize transparent_p to zero (Bug#8238).
18150 Mark another local as initialized.
ec6cf4c6 18151 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 18152
ce0ad53d 18153 * image.c (clear_image_cache): Now static.
d5d5a617 18154 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 18155 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
18156 (x_edge_detection): Remove unnecessary cast that
18157 gcc -Wbad-function-cast diagnoses.
2037898d 18158 (gif_load): Fix pointer signedness.
6ae141d6
PE
18159 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
18160 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 18161
33383987 181622011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 18163
d32df629
PE
18164 Improve quality of tests for time stamp overflow.
18165 For example, without this patch (encode-time 0 0 0 1 1
18166 1152921504606846976) returns the obviously-bogus value (-948597
18167 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
18168 reports time overflow. See
18169 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
18170 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
18171 * editfns.c: Include limits.h and intprops.h.
18172 (TIME_T_MIN, TIME_T_MAX): New macros.
18173 (time_overflow): Move earlier, to before first use.
18174 (hi_time, lo_time): New functions, for an accurate test for
18175 out-of-range times.
18176 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
18177 (Fget_internal_run_time): Don't assume time_t fits in int.
18178 (make_time): Use list2 instead of Fcons twice.
18179 (Fdecode_time): More accurate test for out-of-range times.
18180 (check_tm_member): New function.
18181 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
18182 (lisp_time_argument): Don't rely on undefined left-shift and
18183 right-shift behavior when checking for time stamp overflow.
8be6f318 18184
fe31d94c
PE
18185 * editfns.c (time_overflow): New function, refactoring common code.
18186 (Fformat_time_string, Fdecode_time, Fencode_time):
18187 (Fcurrent_time_string): Use it.
18188
8be6f318
PE
18189 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
18190 * dired.c (make_time): Move to ...
18191 * editfns.c (make_time): ... here.
18192 * systime.h: Note the move.
18193
09d9db2c 181942011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 18195
126bc0dc
YM
18196 * fringe.c (update_window_fringes): Remove unused variables.
18197
c47cbdfd
YM
18198 * unexmacosx.c (copy_data_segment): Also copy __got section.
18199 (Bug#8223)
18200
7ac80be9
EZ
182012011-03-12 Eli Zaretskii <eliz@gnu.org>
18202
c96bbc66 18203 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
18204 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
18205 Constify `char *' arguments and their references according to
18206 prototypes in tparam.h.
18207
ecb0f94d 18208 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 18209
7ac80be9
EZ
18210 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
18211 Adapt all references accordingly.
18212
18213 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
18214
ef1fd07e
TT
182152011-03-11 Tom Tromey <tromey@redhat.com>
18216
18217 * buffer.c (syms_of_buffer): Remove obsolete comment.
18218
7ef4b50c
EZ
182192011-03-11 Eli Zaretskii <eliz@gnu.org>
18220
18221 * termhooks.h (encode_terminal_code): Declare prototype.
18222
18223 * msdos.c (encode_terminal_code): Don't declare prototype.
18224
18225 * term.c (encode_terminal_code): Now external again, used by
18226 w32console.c and msdos.c.
18227
44f230aa
SM
18228 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
18229 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 18230
4b1ec863 182312011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 18232
1714f52b 18233 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 18234
4b1ec863
PE
18235 * fringe.c (update_window_fringes): Mark locals as initialized
18236 (Bug#8227).
18237 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 18238
524c7aa6
PE
18239 * alloc.c (mark_fringe_data): Move decl from here ...
18240 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
18241 to check its interface.
18242 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
18243
a5c0af81 18244 * fontset.c (free_realized_fontset): Now static.
7519b8cd 18245 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 18246 (fontset_font): Mark local as initialized.
a9a06e0b 18247 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 18248
b4716021
PE
18249 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
18250
811e9bac 18251 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 18252 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
18253 (x_own_selection, Fx_disown_selection_internal): Rename locals
18254 to avoid shadowing.
18255 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 18256
7e3ab302
PE
18257 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
18258 so that the caller can use some name other than gcpro1.
18259 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
18260 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
18261 (Fx_backspace_delete_keys_p):
18262 Use them to avoid shadowing, and rename vars to avoid shadowing.
18263 (x_decode_color, x_set_name, x_window): Now static.
6b437900 18264 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 18265 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
18266 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
18267 Remove unused locals.
7e3ab302
PE
18268 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
18269 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
18270 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
18271 macros.
f78faa98 18272
e2b13473
PE
18273 * xterm.h (x_mouse_leave): New decl.
18274
77f23912
PE
18275 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
18276 Remove unused functions.
cdf4ba58
PE
18277 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
18278 (x_calc_absolute_position): Now static.
7411c686 18279 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 18280 Don't declare local "event" unless it's used.
ed7bf3a5
PE
18281 (x_iconify_frame, x_free_frame_resources): Don't declare locals
18282 unless they are used.
38d0b34a
PE
18283 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
18284 (x_fatal_error_signal): Remove; not used.
a6067996
PE
18285 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
18286 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
18287 (x_error_catcher, x_connection_closed, x_error_handler):
18288 (x_error_quitter, xembed_send_message, x_iconify_frame):
18289 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 18290 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 18291 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 18292
44f230aa
SM
18293 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
18294 Rename or move locals to avoid shadowing.
6b463e58 18295 (tty_defined_color, merge_face_heights): Now static.
5967d051 18296 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
18297 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
18298 does not deduce is never used uninitialized.
73719eba
PE
18299 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
18300 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 18301
426994c3 18302 * terminal.c (store_terminal_param): Now static.
5489860b 18303
032f1620 18304 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 18305 (set_frame_menubar): Remove unused local.
d4323972 18306 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
18307 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
18308 since they might point to immutable storage.
281585b0
PE
18309 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
18310 since it's unused otherwise.
032f1620 18311
367c19e5 18312 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 18313 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
18314 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
18315 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 18316 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
18317 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
18318 does not deduce are never used uninitialized.
70739cbe 18319
07b48fa9
PE
18320 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
18321
8868a238 18322 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
18323 * window.c (window_loop, size_window):
18324 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 18325
7e5cf297 18326 * window.c (display_buffer): Now static.
d6550a9f
PE
18327 (size_window): Mark variables that gcc -Wuninitialized
18328 does not deduce are never used uninitialized.
a586633d
PE
18329 * window.h (check_all_windows): New decl, to forestall
18330 gcc -Wmissing-prototypes diagnostic.
5b555da1 18331 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 18332
f6095868
PE
18333 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
18334 shadowing.
18335 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
18336 Include <limits.h>.
18337 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
18338 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
18339 (load_charset_map): Mark variables that gcc -Wuninitialized
18340 does not deduce are never used uninitialized.
53df7c11 18341 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 18342
f38b440c
PE
18343 * coding.c (coding_set_source, coding_set_destination):
18344 Use "else { /* comment */ }" rather than "else /* comment */;"
18345 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
18346 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
18347 a block, when the outer 'i' will do.
18348 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
18349 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
18350 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
18351 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
18352 (Fdecode_sjis_char, Fdefine_coding_system_internal):
18353 Rename locals to avoid shadowing.
18354 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
18355 * coding.c (emacs_mule_char, encode_invocation_designation):
18356 Now static, since they're not used elsewhere.
413bb2db 18357 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 18358 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
18359 (decode_coding_emacs_mule): Mark variables that gcc
18360 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
18361 (detect_coding_iso_2022): Initialize a local variable that might
18362 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 18363 this initialization is needed. (Bug#8211)
5f58e762
PE
18364 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
18365 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
18366 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
18367 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
18368 Remove unused macros.
f38b440c 18369
232b38b9 18370 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 18371 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 18372 * character.c (string_count_byte8): Likewise.
232b38b9 18373
fb90da1b
PE
18374 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
18375 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
18376
fb93dbc2
PE
18377 * chartab.c (copy_sub_char_table): Now static, since it's not used
18378 elsewhere.
5c156ace
PE
18379 (sub_char_table_ref_and_range, char_table_ref_and_range):
18380 Rename locals to avoid shadowing.
bbcd0949 18381 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 18382
7d3b3862 18383 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 18384 (BIDI_BOB): Remove unused macro.
7d3b3862 18385
6be7d3da
PE
18386 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
18387 deduce are never used uninitialized.
c2ed9c8b 18388 * term.c (encode_terminal_code): Likewise.
6be7d3da 18389
75f8807f 18390 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 18391
50938595
PE
18392 * tparam.h: New file.
18393 * term.c, tparam.h: Include it.
18394 * deps.mk (term.o, tparam.o): Depend on tparam.h.
18395 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
18396 Move these decls to tparam.h, and make them agree with what
18397 is actually in tparam.c. The previous trick of using incompatible
18398 decls in different modules does not conform to the C standard.
18399 All callers of tparam changed to use tparam's actual API.
18400 * tparam.c (tparam1, tparam, tgoto):
18401 Use const pointers where appropriate.
18402
fbceeba2
PE
18403 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
18404 * cm.h (struct cm): Likewise.
18405 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
18406 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
18407 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
18408 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
18409 (turn_on_face, init_tty): Likewise.
18410 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 18411
7f3f1250
PE
18412 * term.c (term_mouse_position): Rename local to avoid shadowing.
18413
e6ca6543
PE
18414 * alloc.c (mark_ttys): Move decl from here ...
18415 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
18416
c40f8d15
AS
184172011-03-11 Andreas Schwab <schwab@linux-m68k.org>
18418
18419 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
18420
cfe0661d
JB
184212011-03-09 Juanma Barranquero <lekktu@gmail.com>
18422
18423 * search.c (compile_pattern_1): Remove argument regp, unused since
18424 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
18425 (compile_pattern): Don't pass it.
18426
0afb4571
J
184272011-03-08 Jan Djärv <jan.h.d@swipnet.se>
18428
18429 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
18430 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
18431 for ! HAVE_GTK3.
18432 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
18433
18434 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
18435
18436 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
18437 gdk_window_get_screen, gdk_window_get_geometry,
18438 gdk_x11_window_lookup_for_display and GDK_KEY_g.
18439 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
18440 (xg_get_pixbuf_from_pixmap): New function.
18441 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
18442 to Pixmap, take frame as parameter, remove GdkColormap parameter.
18443 Call xg_get_pixbuf_from_pixmap instead of
18444 gdk_pixbuf_get_from_drawable.
18445 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
18446 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
18447 (xg_check_special_colors): Use GtkStyleContext and its functions
18448 for HAVE_GTK3.
18449 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
18450 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
18451 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
18452 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
18453 Call gtk_widget_get_preferred_size.
0afb4571
J
18454 (xg_frame_resized): gdk_window_get_geometry only takes 5
18455 parameters.
44f230aa
SM
18456 (xg_win_to_widget, xg_event_is_for_menubar):
18457 Call gdk_x11_window_lookup_for_display.
0afb4571
J
18458 (xg_set_widget_bg): New function.
18459 (delete_cb): New function.
895009e1 18460 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 18461 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
18462 (xg_set_background_color): Call xg_set_widget_bg.
18463 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
18464 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
18465 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
18466 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
18467 if ! HAVE_GTK3.
18468 (update_frame_tool_bar): Call gtk_widget_hide.
18469 (xg_initialize): Use GDK_KEY_g.
18470
18471 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
18472 if ! HAVE_GTK3
18473 (x_session_initialize): Call gdk_x11_set_sm_client_id.
18474
18475 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
18476 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
18477 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
18478
1c2cc4ef
JB
184792011-03-08 Juanma Barranquero <lekktu@gmail.com>
18480
18481 * w32xfns.c (select_palette): Check success of RealizePalette against
18482 GDI_ERROR, not zero.
18483
33383987 18484See ChangeLog.11 for earlier changes.
aac0c6e3
MR
18485
18486;; Local Variables:
18487;; coding: utf-8
aac0c6e3
MR
18488;; End:
18489
2f097256 18490 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
18491
18492 This file is part of GNU Emacs.
18493
18494 GNU Emacs is free software: you can redistribute it and/or modify
18495 it under the terms of the GNU General Public License as published by
18496 the Free Software Foundation, either version 3 of the License, or
18497 (at your option) any later version.
18498
18499 GNU Emacs is distributed in the hope that it will be useful,
18500 but WITHOUT ANY WARRANTY; without even the implied warranty of
18501 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
18502 GNU General Public License for more details.
18503
18504 You should have received a copy of the GNU General Public License
18505 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.