* nsterm.m (ns_set_vertical_scroll_bar, ns_redeem_scroll_bar)
[bpt/emacs.git] / src / ChangeLog
CommitLineData
947b2afd
AA
12012-08-01 Alp Aker <alp.tekin.aker@gmail.com>
2
3 * nsterm.m (ns_set_vertical_scroll_bar, ns_redeem_scroll_bar)
4 (EmacsWindow-accessibilityAttributeValue, EmacsScroller-initFrame:)
5 (EmacsScroller-dealloc): Adjust to use WVAR. (Bug#12114)
6 * nsfns.m (ns_set_name_as_filename): Likewise.
7 * nsmenu.m (ns_update_menubar): Likewise.
8 * nsselect.m (symbol_to_nsstring): Adjust to use SVAR.
9
4f5d0325
EZ
102012-08-01 Eli Zaretskii <eliz@gnu.org>
11
2008beae
EZ
12 * .gdbinit (xcar, xcdr, xlist, xwindow, nextcons, xprintsym):
13 Adapt to latest changes in field names of the corresponding Lisp
288479f6 14 objects.
2008beae 15
4f5d0325
EZ
16 * xdisp.c (try_window_id): Use WVAR in IF_DEBUG code.
17
fe3cc771
GM
182012-08-01 Glenn Morris <rgm@gnu.org>
19
20 * s/msdos.h: Remove file.
21 * conf_post.h [MSDOS]: New section, moved from s/msdos.h.
22 * Makefile.in (S_FILE): Remove.
23 (config_h): Remove S_FILE.
24
c90acc54
JB
252012-08-01 Juanma Barranquero <lekktu@gmail.com>
26
27 * s/ms-w32.h (DEVICE_SEP, IS_DIRECTORY_SEP, IS_ANY_SEP):
28 Remove; moved to nt/config.nt.
29
d8a05828
DA
302012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
31
32 Use INTERNAL_FIELD for conses and overlays.
33 * lisp.h (struct Lisp_Cons): Use INTERNAL_FIELD.
34 Remove obsolete comment.
35 (MVAR): New macro.
36 (struct Lisp_Overlay): Use INTERNAL_FIELD.
37 * alloc.c, buffer.c, buffer.h, fns.c: Adjust users.
38
8271d590
DA
392012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
40
41 Use INTERNAL_FIELD for symbols.
42 * lisp.h (SVAR): New macro. Adjust users.
43 * alloc.c, bytecode.c, cmds.c, data.c, doc.c, eval.c:
44 * fns.c, keyboard.c, lread.c, xterm.c: Users changed.
45
3193acd2
DA
462012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
47
48 Use INTERNAL_FIELD for processes.
49 * process.h (PVAR): New macro. Adjust style.
50 (struct Lisp_Process): Change Lisp_Object members to INTERNAL_FIELD.
51 * print.c, process.c, sysdep.c, w32.c, xdisp.c: Users changed.
52
3a45383a
DA
532012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
54
55 Use INTERNAL_FIELD for windows.
56 * window.h (WVAR): New macro.
57 (struct window): Change Lisp_Object members to INTERNAL_FIELD.
58 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
59 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
60 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, nsterm.m, print.c:
61 * textprop.c, w32fns.c, w32menu.c, w32term.c, window.c, xdisp.c:
62 * xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
63
c1dbc63c
PE
642012-08-01 Paul Eggert <eggert@cs.ucla.edu>
65
66 * coding.h (CODING_ATTR_FLUSHING): Remove; unused and wouldn't work.
67
5c0c0e8a
GM
682012-08-01 Glenn Morris <rgm@gnu.org>
69
70 * lisp.h (IS_DIRECTORY_SEP, IS_DEVICE_SEP, IS_ANY_SEP):
71 Move to configure.ac.
72
552a99b4
JB
732012-08-01 Juanma Barranquero <lekktu@gmail.com>
74
75 * makefile.w32-in (CONFIG_H): Update dependencies.
76 (CONF_POST_H): New macro.
77
78 * s/ms-w32.h (SEPCHAR, NULL_DEVICE): Remove; moved to nt/config.nt.
79
8d8e2dfe
GM
802012-07-31 Glenn Morris <rgm@gnu.org>
81
bc96620a
GM
82 * Makefile.in (S_FILE): No longer set by configure.
83
476b1b2d
GM
84 * conf_post.h (config_opsysfile): Move earlier, so that WINDOWSNT
85 is available.
86 (alloca.h) [WINDOWSNT]: Don't include it on MS Windows.
87
b2c7a106
GM
88 * process.h (NULL_DEVICE):
89 * emacs.c (SEPCHAR):
90 * editfns.c (USER_FULL_NAME): Let configure set them.
91
d53d062a
GM
92 * s/README, s/template.h: Remove files.
93
4515017f
GM
94 * conf_post.h [HPUX]: Undefine HAVE_RANDOM and HAVE_RINT.
95
8d8e2dfe
GM
96 * conf_post.h (AMPERSAND_FULL_NAME, subprocesses):
97 Move to configure.ac.
98
5b20b3cc
EZ
992012-07-31 Eli Zaretskii <eliz@gnu.org>
100
1e0afd9a
EZ
101 * .gdbinit (xframe): Adapt to introduction of FVAR and the
102 resulting renaming of 'struct frame' members.
103
5b20b3cc
EZ
104 * w32menu.c (w32_menu_show): Revert bogus introduction of FVAR.
105
106 * fontset.c (dump_fontset): Fix compilation with ENABLE_CHECKING
107 after introduction of FVAR.
108
f1310128
JD
1092012-07-31 Jan Djärv <jan.h.d@swipnet.se>
110
79e721e0
JD
111 * nsmenu.m (update_frame_tool_bar): Change key from NSObject* to id.
112
113 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Use drawInRect
114 instead of compositeToPoint.
115 (applicationShouldTerminate): Pass NS String literal to NSRunAlertPanel.
116
8d7c7eed 117 * nsfns.m, nsmenu.m, nsterm.m: Adopt to struct frame/FVAR changes.
f1310128 118
e34f7f79
DA
1192012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
120
121 Generalize INTERNAL_FIELD between buffers, keyboards and frames.
122 * lisp.h (INTERNAL_FIELD): New macro.
123 * buffer.h (BUFFER_INTERNAL_FIELD): Removed.
124 (BVAR): Change to use INTERNAL_FIELD.
125 * keyboard.h (KBOARD_INTERNAL_FIELD): Likewise.
126 (KVAR): Change to use INTERNAL_FIELD.
127 * frame.h (FVAR): New macro.
128 (struct frame): Use INTERNAL_FIELD for all Lisp_Object fields.
3a45383a
DA
129 * alloc.c, buffer.c, data.c, dispnew.c, dosfns.c, eval.c, frame.c:
130 * fringe.c, gtkutil.c, minibuf.c, nsfns.m, nsterm.m, print.c:
131 * term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
e34f7f79
DA
132 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
133
c09bfb2f
DA
1342012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
135
136 Miscellaneous fixes for non-default X toolkits.
137 * xfns.c (Fx_file_dialog): Change to SSDATA to avoid warnings.
138 * xterm.c (x_frame_of_widget): Remove redundant prototype.
139 Move under #ifdef USE_LUCID.
140 (x_create_toolkit_scroll_bar): Adjust scroll_bar_name
141 definition and usage to avoid warnings.
142
14c114ae
JD
1432012-07-31 Jan Djärv <jan.h.d@swipnet.se>
144
145 * nsterm.m (openFiles): Fix previous checkin.
146
3bd21e82
PE
1472012-07-31 Paul Eggert <eggert@cs.ucla.edu>
148
149 * indent.c (compute_motion): Remove unused local.
150
c1529ded
GM
1512012-07-31 Glenn Morris <rgm@gnu.org>
152
400d5621
GM
153 * s/usg5-4-common.h (wait3, WRETCODE): Let configure set them.
154
268e2432
GM
155 * conf_post.h [USG5_4]:
156 Move remaining contents of s/usg5-4-common.h here.
157 * s/usg5-4-common.h: Remove file.
158
7552f3ee
GM
159 * conf_post.h [IRIX6_5]: Move remaining contents of s/irix6-5.h here.
160 * s/irix6-5.h: Remove file.
161
6a381852
GM
162 * conf_post.h [DARWIN_OS]: Move remaining contents of s/darwin.h here.
163 * s/darwin.h: Remove file.
164
c1529ded
GM
165 * conf_post.h [HPUX]: Move random, srandom here from s/hpux10-20.h.
166 * s/hpux10-20.h: Remove file, which is now empty.
167
b429a4ee
GM
1682012-07-30 Glenn Morris <rgm@gnu.org>
169
170 * conf_post.h: New, split from configure.ac's AH_BOTTOM.
171 * Makefile.in (config_h): Add conf_post.h.
172 * makefile.w32-in (CONFIG_H): Add conf_post.h.
173
adff3182
JD
1742012-07-30 Jan Djärv <jan.h.d@swipnet.se>
175
176 * nsterm.m (ns_do_open_file): New variable.
b9031d69 177 (ns_term_init): Set ns_do_open_file to YES after run returns.
adff3182
JD
178 (openFile, openTempFile, openFileWithoutUI, openFiles): Open
179 files only if ns_do_open_file.
180
c32af1e4
PE
1812012-07-30 Paul Eggert <eggert@cs.ucla.edu>
182
7393bcbb
PE
183 * lisp.h (SWITCH_ENUM_CAST): Remove. All uses removed.
184 This no-op macro hasn't been needed for many years.
185 * src/regex.c (SWITCH_ENUM_CAST) [!emacs]: Likewise.
186
c32af1e4
PE
187 Export DIRECTORY_SEP, TYPEMASK, VALMASK to GDB.
188 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]: Add lsb_bits.
189 * lisp.h (enum lsb_bits) [USE_LSB_TAG]: New enum, for
190 gdb_make_enums_visible.
191 (TYPEMASK, VALMASK) [USE_LSB_TAGS]: Now enum constants, not macros.
192 (DIRECTORY_SEP): Now a constant, not a macro.
193
302fc036
EZ
1942012-07-30 Eli Zaretskii <eliz@gnu.org>
195
196 * w32fns.c (w32_wnd_proc): Pass w32_keyboard_codepage to
197 w32_kbd_patch_key as the 2nd arg. (Bug#12082)
198
199 * w32term.c <w32_keyboard_codepage>: Renamed from
200 keyboard_codepage and now external. All users changed.
201
202 * w32term.h: Add declaration of w32_keyboard_codepage.
203
204 * w32inevt.c (w32_kbd_patch_key): Accept an additional argument --
205 the codepage to translate keys to Unicode. If this argument is
206 -1, use the value returned by GetConsoleCP. All callers changed.
207
88fb40b4
PE
2082012-07-30 Paul Eggert <eggert@cs.ucla.edu>
209
0aee6912
PE
210 Update .PHONY listings in makefiles.
211 * Makefile.in (.PHONY): Add all, mostlyclean, clean,
212 bootstrap-clean, distclean, maintainer-clean, versioclean,
213 extraclean, frc.
214
88fb40b4
PE
215 * lisp.h (STRING_BYTES_BOUND): Cast entire result to ptrdiff_t.
216 This is a bit clearer. Fix some commentary typos.
217
0a763bd1
GM
2182012-07-30 Glenn Morris <rgm@gnu.org>
219
32bac6d6
GM
220 * s/netbsd.h: Let configure include signal.h if needed.
221 Remove file, which is now empty.
222
b65e7c46
GM
223 * s/usg5-4-common.h (_longjmp, _setjmp, TIOCSIGSEND):
224 Let configure set them.
225 * s/irix6-5.h (_longjmp, _setjmp, TIOCSIGSEND):
226 No more need to undefine.
0a763bd1 227
169304bd
AS
2282012-07-30 Andreas Schwab <schwab@linux-m68k.org>
229
230 * keymap.c (Fkey_description): Don't remove 0x80 bit from
231 non-single-byte char when adding meta modifier. (Bug#12090)
232
6cd7a139
DA
2332012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
234
235 Convert safe_call to use variable number of arguments.
236 * xdisp.c (safe_call): Convert to use varargs. Adjust users.
237 (safe_call2): Fix comment.
238 * lisp.h (safe_call): Adjust prototype.
239 * coding.c (encode_coding_object): Change to use safe_call2.
240 * xfaces.c (merge_face_heights): Change to use safe_call1.
241
d34d6ffc
GM
2422012-07-30 Glenn Morris <rgm@gnu.org>
243
7b8a48e4 244 * s/aix4-2.h (sigmask): No need to undefine it, since syssignal.h
227f5bd0 245 does that unconditionally. Remove file, which is now empty.
7b8a48e4 246
d34d6ffc
GM
247 * s/freebsd.h, s/gnu-linux.h, s/sol2-6.h, s/unixware.h:
248 Remove empty files.
249
03a660a6
PE
2502012-07-30 Paul Eggert <eggert@cs.ucla.edu>
251
252 Export to GDB most of lisp.h's remaining object-like macros.
253 * lisp.h (min, max): Move earlier, because they're used earlier now.
254 (INTMASK, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK)
255 (CHAR_TABLE_STANDARD_SLOTS, CHARTAB_SIZE_BITS_0)
256 (CHARTAB_SIZE_BITS_1, CHARTAB_SIZE_BITS_2, CHARTAB_SIZE_BITS_3)
257 (DEFAULT_HASH_SIZE, COMPILED_ARGLIST, COMPILED_BYTECODE)
258 (COMPILED_CONSTANTS, COMPILED_STACK_DEPTH, COMPILED_DOC_STRING)
259 (COMPILED_INTERACTIVE, CHAR_ALT, CHAR_SUPER, CHAR_HYPER, CHAR_SHIFT)
260 (CHAR_CTL, CHAR_META, CHAR_MODIFIER_MASK, CHARACTERBITS)
261 (MANY, UNEVALLED, FLOAT_TO_STRING_BUFSIZE, MAX_ALLOCA):
262 Now constants, for GDB. They need not be macros.
263 (MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM, STRING_BYTES_BOUND):
264 Now constants, for GDB, as well as macros, for static initializers.
265 (CHAR_TABLE_STANDARD_SLOTS, CHAR_TABLE_EXTRA_SLOTS):
266 Move to after the definition of struct Lisp_Char_Table,
267 since the former now needs that type defined.
268 (enum CHARTAB_SIZE_BITS, enum CHAR_TABLE_STANDARD_SLOTS)
269 (enum DEFAULT_HASH_SIZE, enum Lisp_Compiled, enum char_bits)
270 (enum maxargs, enum FLOAT_TO_STRING_BUFSIZE, enum MAX_ALLOCA):
271 New enums, for gdb_make_enums_visible.
272 (GLYPH_MODE_LINE_FACE): Remove; unused.
88fb40b4 273 * alloc.c (STRING_BYTES_MAX): Now a constant, not a macro.
03a660a6
PE
274 (gdb_make_enums_visible): Add enum CHARTAB_SIZE_BITS, enum
275 CHAR_TABLE_STANDARD_SLOTS, enum char_bits, enum DEFAULT_HASH_SIZE,
276 enum FLOAT_TO_STRING_BUFSIZE, enum Lisp_Bits, enum Lisp_Compiled,
277 enum maxargs, enum MAX_ALLOCA.
278 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): Remove.
279 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Remove;
280 no longer needed, now that they are done in lisp.h.
281
e499d0ee
DA
2822012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
283
284 Cleanup string bytes checking.
285 * alloc.c (GC_STRING_BYTES, CHECK_STRING_BYTES): Remove. Convert
286 all users to STRING_BYTES or string_bytes if GC_CHECK_STRING_BYTES.
287 (check_string_bytes): Define to empty if not GC_CHECK_STRING_BYTES.
288 (check_sblock, compact_small_strings): Simplify.
289
d5040d2d
PE
2902012-07-29 Paul Eggert <eggert@cs.ucla.edu>
291
292 * lisp.h (LISP_INT_TAG, LISP_INT1_TAG, LISP_STRING_TAG): Remove.
293 These macros are confusing and no longer need to be defined, as
294 the enum values now suffice. All uses replaced with definiens.
295 (Lisp_Int1, Lisp_String): Define directly; this is clearer.
296
7f259ae6
JB
2972012-07-29 Juanma Barranquero <lekktu@gmail.com>
298
299 * makefile.w32-in (LISP_H, $(BLD)/emacs.$(O), $(BLD)/w32inevt.$(O))
300 ($(BLD)/w32console.$(O)): Update dependencies.
301
7e63e0c3
DA
3022012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
303
304 Remove HIDE_LISP_IMPLEMENTATION and cleanup cons free list check.
305 * lisp.h (HIDE_LISP_IMPLEMENTATION): Remove as useless for a long
306 time. Adjust users.
307 (CHECK_CONS_LIST): Remove. Convert all users to check_cons_list.
308
ffd817eb
JD
3092012-07-29 Jan Djärv <jan.h.d@swipnet.se>
310
311 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
312 setting sitelisp (Bug#12010).
313
417a7a0e
EZ
3142012-07-29 Eli Zaretskii <eliz@gnu.org>
315
316 * w32heap.h (OS_9X): Renamed from OS_WINDOWS_95.
317
318 * w32heap.c (cache_system_info):
319 * w32.c (sys_rename):
320 * w32proc.c (find_child_console, sys_kill): All users changed.
321
387d4d92
PE
3222012-07-29 Paul Eggert <eggert@cs.ucla.edu>
323
324 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
325
55a6cca6
EZ
3262012-07-29 Eli Zaretskii <eliz@gnu.org>
327
328 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
329
dbcf001c
DA
3302012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
331
332 Cleanup statistics calculation in Fgarbage_collect.
333 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start. Fix
334 zombies percentage calculation. Simplify elapsed time calculation.
335
e2688e4a
DA
3362012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
337
338 Generalize marker debugging code under MARKER_DEBUG and use eassert.
339 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
340 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
341 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
342 (replace_range, replace_range_2, del_range_2): Change to eassert.
343 * marker.c (byte_char_debug_check): Adjust style.
344
b46a6a83
PE
3452012-07-29 Paul Eggert <eggert@cs.ucla.edu>
346
347 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
348 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
349 long-ago-commented-out code that talks about "WIN32".
350 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
351 All uses changed.
352
e32a5799
PE
3532012-07-28 Paul Eggert <eggert@cs.ucla.edu>
354
355 Use Gnulib stdalign module (Bug#9772, Bug#9960).
356 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
357 Simplify by using alignof.
358 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
359 * lisp.h: Include <stdalign.h>.
360 (GCALIGNMENT): New macro and constant.
361 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
362 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
363 (stdalign): New macro, if not already defined.
364
df81cd29
EZ
3652012-07-28 Eli Zaretskii <eliz@gnu.org>
366
01bd1b0d
EZ
367 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
368 * w32inevt.c: Include w32inevt.h.
369 (w32_read_console_input): New inline function, calls either
370 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
371 w32_console_unicode_input.
372 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
373 (w32_kbd_patch_key, key_event): Use the codepage returned by
374 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
375 (key_event): use uChar.UnicodeChar only if
376 w32_console_unicode_input is non-zero.
377
378 * w32console.c: Include w32heap.h.
379 <w32_console_unicode_input>: New global variable.
380 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
381 family of Windows, zero otherwise.
382
383 * w32inevt.h: Declare w32_console_unicode_input.
384
df81cd29
EZ
385 * xdisp.c (init_iterator): Don't reference tip_frame in a build
386 --without-x. (Bug#11742)
387
c20fdd9e
PE
3882012-07-27 Paul Eggert <eggert@cs.ucla.edu>
389
390 Adjust GDB to reflect pvec_type changes (Bug#12036).
391 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
392 2012-07-04 changes to pseudovector representation. Problem
393 reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
394
32770973 3952012-07-27 Michael Albinus <michael.albinus@gmx.de>
e518bc71
MA
396
397 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
398 bus address.
399 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
400
3438fe21
EZ
4012012-07-27 Eli Zaretskii <eliz@gnu.org>
402
bcfbc9de
EZ
403 * alloc.c (listn): Fix the order the arguments are consed onto the
404 list.
405
3438fe21
EZ
406 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
407 enumeration constants, as PURE and HEAP are too general, and clash
408 with other headers and sources, such as gmalloc.c and the
409 MS-Windows system headers. All users changed.
410
eeaea515
DA
4112012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
412
413 Revert last save_excursion_save and save_excursion_restore changes.
414 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
415 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
416
073c88c2
DA
4172012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
418
419 Fix recently-introduced typos in Windows port.
420 Reported by Martin Rudalics <rudalics@gmx.at>.
421 * w32.c (init_environment): Replace comma with semicolon.
eeaea515 422 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
073c88c2 423
4706125e
PE
4242012-07-27 Paul Eggert <eggert@cs.ucla.edu>
425
426 Improve GDB symbol export (Bug#12036).
427 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
428 arms of an 'if', not using conditional expressions; otherwise GDB
429 complains about the types in the unevaluated arm when the argument
430 is an integer literal.
431 (xgetint): Simplify expression.
432 * alloc.c (gdb_make_enums_visible): New constant. This ports to
433 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
434 Zaretskii in <http://bugs.gnu.org/12036#13>.
435 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
436 needed now that we have gdb_make_enums_visible.
437 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
438 (enum enum_USE_LSB_TAG):
439 New enum types, packaging up enums that need to be exported to GDB.
440
694b6c97
DA
4412012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
442
443 Utility function to make a list from specified amount of objects.
444 * lisp.h (enum constype): New datatype.
445 (listn): New prototype.
446 * alloc.c (listn): New function.
447 (Fmemory_use_count, syms_of_alloc): Use it.
448 * buffer.c (syms_of_buffer): Likewise.
449 * callint.c (syms_of_callint): Likewise.
450 * charset.c (define_charset_internal): Likewise.
451 * coding.c (syms_of_coding): Likewise.
452 * keymap.c (syms_of_keymap): Likewise.
453 * search.c (syms_of_search): Likewise.
454 * syntax.c (syms_of_syntax): Likewise.
455 * w32.c (init_environment): Likewise.
456 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
457 * xdisp.c (syms_of_xdisp): Likewise.
458 * xfns.c (syms_of_xfns): Likewise.
459
6195f384
DA
4602012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
461
462 Fast save_excursion_save and save_excursion_restore.
463 * lisp.h (struct Lisp_Excursion): New data type.
464 (PVEC_EXCURSION): New pseudovector type.
465 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
466 to deal with it. Adjust comments.
467 (init_marker, attach_marker): New prototype.
468 (unchain_marker): Adjust prototype.
469 * marker.c (attach_marker): Change to global.
470 (init_marker): New function.
471 * alloc.c (Fmake_marker, build_marker): Use it.
472 (build_marker): More easserts.
473 (mark_object): Handle struct Lisp_Excursion.
474 * editfns.c (save_excursion_save, save_excursion_restore):
475 Reimplement to use struct Lisp_Excursion. Add comments.
476
5eceb8fb
PE
4772012-07-26 Paul Eggert <eggert@cs.ucla.edu>
478
479 Fix export of symbols to GDB (Bug#12036).
480 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
481 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
482 emacs.c, as this is a more-suitable home. Had this been done earlier
483 the fix for 12036 would have avoided some of the problems noted in
484 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
485 would have been more obvious.
562157c8
PE
486 * emacs.c: Do not include <verify.h>; no longer needed.
487 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
5eceb8fb
PE
488 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
489 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
490 Remove; now done in lisp.h.
491 * lisp.h (PUBLISH_TO_GDB): New macro.
492 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
493 (DATA_SEG_BITS): Use it.
494 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
495 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
496 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
497 not be usable in #if. This simplifies things.
498
d6749401
JB
4992012-07-26 Juanma Barranquero <lekktu@gmail.com>
500
501 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
502
1781b9e9
PE
5032012-07-26 Paul Eggert <eggert@cs.ucla.edu>
504
d89518db 505 Simplify export of symbols to GDB (Bug#12036).
1781b9e9
PE
506 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
507 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
508 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
509 Adjust to changes in lisp.h and emacs.c, by using
510 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
511 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
512 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
513 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
514 instead of gdb_valbits.
515 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
516 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
517 instead of gdb_array_mark_flag.
518 (xboolvector): Get size from $->size, not $->header.size.
519 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
520 (xreload, hook-run, hookpost-run): Remove.
521 * emacs.c: Include <verify.h>.
522 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
523 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
524 Remove.
525 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
526 (gdb_USE_LSB_TAG): New enum constants.
527 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
528 Also define these as enum constants, so they're visible to GDB.
529 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
530 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
531 as constants, so they're visible to GDB.
532 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
533 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
534 Now enum constants, not macros, so they're visible to GDB.
535 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
536 more convenient now. All uses changed.
537 (VALMASK) [USE_LSB_TAG]: Also define in this case.
538 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
539
3628596a
DA
5402012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
541
542 Explicitly free restriction data that are not needed anymore.
543 * editfns.c (save_restriction_restore): Free restriction data.
544
7abaf5cc
SM
5452012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
546
547 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
548 add argument, tune behavior, and adjust all callers.
549
71f88e00
PE
5502012-07-25 Paul Eggert <eggert@cs.ucla.edu>
551
552 Use typedef for EMACS_INT, EMACS_UINT.
553 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
554 than macros. This simplifies debugging in the usual case, since
555 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
556 and it allows expressions involving EMACS_INT casts.
557 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
558
57ec3034
JD
5592012-07-25 Jan Djärv <jan.h.d@swipnet.se>
560
561 * nsterm.m (ns_read_socket): Return early if there is a modal
562 window (Bug#12043).
563
8137e7b3
MR
5642012-07-25 Martin Rudalics <rudalics@gmx.at>
565
566 * frame.c (Fredirect_frame_focus): In doc-string don't mention
567 that FOCUS-FRAME can be omitted.
568
04e9897c
DA
5692012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
570
571 Adjust buffer text indirection counters at the end of Fkill_buffer.
572 * buffer.c (Fkill_buffer): Adjust indirection counters when the
573 buffer is definitely dead. This should really fix an issue reported
574 by Christoph Scholtes again. (Bug#12007).
575 (init_buffer_once): Initialize indirection counters of
576 buffer_defaults and buffer_local_symbols (for sanity and safety).
577
8a0484e1
EZ
5782012-07-24 Eli Zaretskii <eliz@gnu.org>
579
580 * xdisp.c (init_iterator): Don't compute dimensions of truncation
581 and continuation glyphs on tooltip frames, leave them at zero.
582 Avoids continued lines in tooltips. (Bug#11832)
583
fa691a83
DA
5842012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
585
586 Simplify copy_overlay.
04e9897c 587 * buffer.c (copy_overlay): Simplify. Use build_marker.
fa691a83
DA
588 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
589
436bc8e0
EZ
5902012-07-23 Eli Zaretskii <eliz@gnu.org>
591
592 * print.c (print_object): Don't crash when a frame's name is nil
593 or invalid. (Bug#12025)
594
595 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
596 it signals an error when a tooltip frame is being created.
597
d7a7fda3
DA
5982012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
599
600 Cleanup miscellaneous objects allocation and initialization.
601 * alloc.c (allocate_misc): Change to static. Add argument to
602 specify the subtype. Adjust comment and users.
603 (build_overlay): New function.
604 * buffer.c (copy_overlays, Fmake_overlay): Use it.
605 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
606 (allocate_misc): Remove prototype.
607 (build_overlay): Add prototype.
608
6092012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
372f8ffc
DA
610
611 Swap buffer text indirection counters in Fbuffer_swap_text.
612 * buffer.c (Fbuffer_swap_text): Swap indirections too.
613 This avoids crash reported by Christoph Scholtes at
614 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
615
9d7fa573
JD
6162012-07-22 Jan Djärv <jan.h.d@swipnet.se>
617
618 * nsmenu.m (Popdown_data): New struct.
619 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
620 free Popdown_data.
621 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
622 (initWithContentRect): Make imgView and contentView non-static
623 and autorelease them. Also autorelease img and matrix (Bug#12005).
624 (dealloc): Remove (Bug#12005).
625
0dd6d66d
DA
6262012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
627
628 Adjust consing_since_gc when objects are explicitly freed.
629 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
630 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
631 (free_cons, free_misc): Subtract object size from consing_since_gc.
632
d36d71df
DA
6332012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
634
635 Simplify and cleanup markers positioning code.
636 * marker.c (attach_marker): More useful eassert.
637 (live_buffer, set_marker_internal): New function.
638 (Fset_marker, set_marker_restricted): Use set_marker_internal.
639 (set_marker_both, set_marker_restricted_both): Use live_buffer.
640
fb9ea40f
PE
6412012-07-22 Paul Eggert <eggert@cs.ucla.edu>
642
643 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
644 as it's limited by the amount of memory, not by INT_MAX.
645
2d5c5f7d
EZ
6462012-07-21 Eli Zaretskii <eliz@gnu.org>
647
07fb592e
EZ
648 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
649 in special-event-map. See the discussion at
650 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
651 for the reasons.
652
37a9eac8 653 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
2d5c5f7d
EZ
654 info.dwItemData. Fixes crashes on 64-bit Windows. Suggested by
655 Fabrice Popineau <fabrice.popineau@supelec.fr>.
656
c4328746
JD
6572012-07-21 Jan Djärv <jan.h.d@swipnet.se>
658
659 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 660 (conversationIdentifier): Return value is NSInteger.
784051c4 661 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 662
6e5d1c12
CY
6632012-07-21 Chong Yidong <cyd@gnu.org>
664
665 * window.c (decode_any_window): Signal an error if the window is
666 on a dead frame (Bug#11984).
667
9928463d
DA
6682012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
669
670 Add indirection counting to speed up Fkill_buffer.
671 * buffer.h (struct buffer): New member.
672 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
673 (Fmake_indirect_buffer): Set indirection counter to -1, increment
674 base buffer indirection counter.
675 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
676 (Fkill_buffer): Adjust indirection counters as needed, don't walk
677 through buffer list if indirection counter is 0.
678
f8643a6b
DA
6792012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
680
681 Extend the value returned by Fgarbage_collect with heap statistics.
682 * alloc.c (Qheap): New symbol.
683 (syms_of_alloc): DEFSYM it.
684 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
685 (Fmemory_free): Remove.
686 (syms_of_alloc): Don't defsubr it.
687 * buffer.c (Fcompact_buffer): Remove.
688 (syms_of_buffer): Don't defsubr it.
689
dac616ff
DA
6902012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
691
692 Make maybe_gc inline.
693 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
694 * lisp.h (consing_since_gc, gc_relative_threshold)
695 (memory_full_cons_threshold): Revert declaration.
696 (maybe_gc): Remove prototype, define as inline.
697 * alloc.c: Remove old commented-out code.
698 (consing_since_gc, gc_relative_threshold)
699 (memory_full_cons_threshold): Revert to global.
700 (maybe_gc): Remove.
701
d7ea76b4
DA
7022012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
703
704 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
705 * lisp.h (build_unibyte_string): New function.
706 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
707 * sysdep.c, w32fns.c, xfns.c: Use it.
708 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
709 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
710 Adjust users accordingly.
711 * font.h (font_open_by_name): Adjust prototype.
712
765e61e3
DA
7132012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
714
715 Cleanup calls to Fgarbage_collect.
716 * lisp.h (maybe_gc): New prototype.
717 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
718 Remove declarations.
719 * alloc.c (maybe_gc): New function.
720 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
721 Make them static.
722 * bytecode.c (MAYBE_GC): Use maybe_gc.
723 * eval.c (eval_sub, Ffuncall): Likewise.
724 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
725 to avoid dependency from auto-save feature.
726
52b852c7
PE
7272012-07-19 Paul Eggert <eggert@cs.ucla.edu>
728
729 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
730 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
731 'for_each_per_buffer_object_at'.
732 All uses changed. It's better to use upper-case for macros that
733 cannot be implemented as functions, to give the reader a clue
734 that they're special.
735
5db81e33
SM
7362012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
737
738 * alloc.c (Fgarbage_collect): Tweak docstring.
739
5b835e1d
DA
7402012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
741
742 Tweak the value returned from Fgarbage_collect again.
743 * alloc.c (Fgarbage_collect): New return value, as confirmed in
744 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
745 Adjust documentation.
746 (total_vector_bytes): Rename to total_vector_slots, adjust
747 accounting.
748 (total_free_vector_bytes): Rename to total_free_vector_slots,
749 adjust accounting.
750 (Qstring_bytes, Qvector_slots): New symbols.
751 (syms_of_alloc): DEFSYM them.
752
9cd47b72
DA
7532012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
754
755 Buffer compaction primitive which may be used from Lisp.
756 * buffer.c (compact_buffer, Fcompact_buffer): New function.
757 (syms_of_buffer): Register Fcompact_buffer.
758 * alloc.c (Fgarbage_collect): Use compact_buffer.
759 * buffer.h (compact_buffer): New prototype.
760 (struct buffer_text): New member.
761
d17337e5
DA
7622012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
763
764 New macro to iterate over all buffers, miscellaneous cleanups.
765 * lisp.h (all_buffers): Remove declaration.
766 * buffer.h (all_buffers): Add declaration, with comment.
767 (for_each_buffer): New macro.
768 * alloc.c (Fgarbage_collect, mark_object): Use it.
769 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
770 (init_buffer): Likewise.
771 * data.c (Fset_default): Likewise.
772 * coding.c (code_conversion_restore): Remove redundant check
773 for dead buffer.
774 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
775
60cfd278
AS
7762012-07-18 Andreas Schwab <schwab@linux-m68k.org>
777
778 Fix bug that created negative-length intervals.
779 * intervals.c (merge_interval_right, merge_interval_left):
780 Do not zero out this interval if it is absorbed by its children,
781 as this interval's total length doesn't change in that case. See
782 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
783
d06714cb
PE
7842012-07-18 Paul Eggert <eggert@cs.ucla.edu>
785
83713154
PE
786 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
787 when invoking (make-bool-vector N t) and N is a positive
788 multiple of 8 -- the last 8 bits were mistakenly cleared.
789
d06714cb
PE
790 Remove some struct layout assumptions in bool vectors.
791 * alloc.c (bool_header_size): New constant.
792 (header_size, word_size): Move earlier, as they're now used earlier.
793 Use 'word_size' in a few more places, where it's appropriate.
794 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
795 padding before the data member of a bool vector.
796 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
797 than doing the check by hand with an abort ().
798
464d5a5e
SM
7992012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
800
5fbc0409
SM
801 * eval.c (Fdefvar): Don't check constants since we only set the var if
802 it's not yet defined anyway (bug#11904).
803
464d5a5e
SM
804 * lisp.h (last_undo_boundary): Declare new var.
805 * keyboard.c (command_loop_1): Set it.
806 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
807 were auto-added by the command loop (bug#11774).
808
8dc2e44a
AS
8092012-07-18 Andreas Schwab <schwab@linux-m68k.org>
810
811 * w32font.c (Qsymbol): Remove local definition.
812 (syms_of_w32font): Don't DEFSYM it.
813
169925ec
DA
8142012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
815
816 Fix sweep_vectors to handle large bool vectors correctly.
817 * alloc.c (sweep_vectors): Account total_vector_bytes for
818 bool vectors larger than VBLOCK_BYTES_MAX.
819
5fbfb018
CY
8202012-07-18 Chong Yidong <cyd@gnu.org>
821
822 * frame.c (x_set_frame_parameters): Revert bogus change introduced
823 in 2012-05-25 commit by Paul Eggert (Bug#11738).
824
3ab6e069
DA
8252012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
826
827 Return more descriptive data from Fgarbage_collect.
828 Suggested by Stefan Monnier in
829 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
830 * alloc.c (bounded_number): New function.
831 (total_buffers, total_vectors): New variable.
832 (total_string_size): Rename to total_string_bytes, adjust users.
833 (total_vector_size): Rename to total_vector_bytes, adjust users.
834 (sweep_vectors): Account total_vectors and total_vector_bytes.
835 (Fgarbage_collect): New return value. Adjust documentation.
836 (gc_sweep): Account total_buffers.
837 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
838 (VECTOR_SIZE): Remove.
839 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
840 (Qinterval, Qmisc): New symbols.
841 (syms_of_data): Initialize them.
842 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
843 (Qcons, Qbuffer): New declarations.
844
6d02fe5b
PE
8452012-07-17 Paul Eggert <eggert@cs.ucla.edu>
846
847 * alloc.c (Fmemory_free): Account for memory-free's own storage.
848 Round up, not down. Improve doc.
849
b7ffe040
DA
8502012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
851
852 Restore old code in allocate_string_data to avoid Faset breakage.
853 Reported by Julien Danjou <julien@danjou.info> in
854 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
855 * alloc.c (allocate_string_data): Restore old code with minor
856 adjustments, fix comment to explain this subtle issue.
857
4dc7c8d5
SM
8582012-07-17 Eli Zaretskii <eliz@gnu.org>
859
860 Remove FILE_SYSTEM_CASE.
861 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
862
863 * fileio.c (FILE_SYSTEM_CASE): Don't define.
864 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
865 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
866 call-process-region passes it through expand-file-name.
867
868 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
869
8702012-07-17 Andreas Schwab <schwab@linux-m68k.org>
871
872 Fix crash when creating indirect buffer (Bug#11917)
873 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
874 Don't handle unbound variables specially if non-zero.
875 (Fbuffer_local_variables): Pass zero.
876 (clone_per_buffer_values): Pass non-zero.
877
8782012-07-17 Andreas Schwab <schwab@linux-m68k.org>
879
880 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
881 to make the loop interruptible.
882
8832012-07-17 Andreas Schwab <schwab@linux-m68k.org>
884
885 * gnutls.c (emacs_gnutls_handshake): Only retry if
886 GNUTLS_E_INTERRUPTED.
887
cce7fefc
DA
8882012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
889
890 Cleanup and convert miscellaneous checks to eassert.
891 * alloc.c (mark_interval): Fix comment, partially rephrase
892 old comment from intervals.h (see below).
893 * intervals.c (find_interval, adjust_intervals_for_insertion)
894 (delete_interval, adjust_intervals_for_deletion)
895 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
896 Convert to eassert.
897 (adjust_intervals_for_insertion, make_new_interval):
898 Remove obsolete and unused code.
899 * intervals.h (struct interval): Remove obsolete comment.
900 * textprotp.c (erase_properties): Remove unused code.
901 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
902 (Fremove_list_of_text_properties): Convert to eassert.
903
9ea10cc3
CY
9042012-07-17 Chong Yidong <cyd@gnu.org>
905
906 * editfns.c (Finsert_char): Doc fix.
907
3900d5de
DA
9082012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
909
910 Fix previous change to make Fmemory_free always accurate.
911 * alloc.c (make_interval): Update total_free_intervals.
912 (make_float): Likewise for total_free_floats.
913 (free_cons, Fcons): Likewise for total_free_conses.
914 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
915 Likewise for total_free_vector_bytes.
916 (Fmake_symbol): Likewise for total_free_symbols.
917 (bytes_free): Remove.
918
7098646f
DA
9192012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
920
921 Simple free memory accounting feature.
922 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
923 (sweep_vectors): Accumulate size of free vectors.
924 (Fgarbage_collect): Setup bytes_free.
925 (Fmemory_free): New function.
926 (syms_of_alloc): Register it.
927
22657b40
DA
9282012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
929
930 Cleanup overlays checking.
931 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
932 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
933 eassert and OVERLAYP.
934 (sort_overlays): Change to use OVERLAYP.
935
ddfc8813
RK
9362012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
937
938 * editfns.c (Finsert_char): Make it interactive, and make the
939 second arg optional. Copy interactive spec and docstring from
940 ucs-insert.
941
7c26cf3c
PE
9422012-07-17 Paul Eggert <eggert@cs.ucla.edu>
943
944 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
945 Unlike the other wrapped functions, fabs has an unspecified
946 effect on errno.
947
5d127af9
JD
9482012-07-16 Jan Djärv <jan.h.d@swipnet.se>
949
950 * nsterm.m (keyDown): Interpret flags without left/right bits
951 as the left key (Bug#11670).
952
6a0dd1d7
DA
9532012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
954
955 Remove empty and useless init functions.
956 * lisp.h (init_character_once, init_fns, init_image)
957 (init_filelock, init_sound): Remove prototype.
958 * character.c (init_character_once): Remove.
959 * filelock.c (init_filelock): Likewise.
960 * fns.c (init_fns): Likewise.
961 * image.c (init_image): Likewise.
962 * sound.c (init_sound): Likewise.
963 * emacs.c (main): Adjust accordingly.
964
7a6136fd
DA
9652012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
966
967 * gtkutil.h: Tiny cleanups.
968 (use_old_gtk_file_dialog): Remove useless declaration.
969 (xg_uses_old_file_dialog): Add suggested const attribute.
970
ce811ad9
EZ
9712012-07-15 Eli Zaretskii <eliz@gnu.org>
972
973 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
974 (bidi_paragraph_init): Use it to limit search forward for a strong
975 directional character in abnormally large paragraphs full of
976 neutral or weak characters. (Bug#11943)
977
c9adfeaa
SF
9782012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
979
980 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
981 the toolbar (Bug#9451).
982 (xg_make_tool_item): Give the widget event box a transparent
983 background.
984
fff62aa9
DA
9852012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
986
987 Cleanup basic allocation variables and functions.
988 * alloc.c (ignore_warnings, init_intervals, init_float)
989 (init_cons, init_symbol, init_marker): Remove.
990 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
991 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
992 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
993 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
994 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
995 (staticidx, init_alloc_once, init_strings, free_ablock):
996 Remove redundant initialization.
997 * fns.c (init_weak_hash_tables): Remove.
998 * lisp.h (init_weak_hash_tables): Remove prototype.
999
9730daca
DA
10002012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
1001
1002 Use zero_vector where appropriate.
1003 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
1004 accordingly.
1005 * lisp.h (zero_vector): New declaration.
1006 * font.c (null_vector): Remove.
1007 (syms_of_font): Remove initialization and staticpro.
1008 (font_list_entities, font_find_for_lface): Change to use zero_vector.
1009 * keymap.c (Faccessible_keymaps): Likewise.
1010
2e2d2a13
LL
10112012-07-15 Leo Liu <sdl.web@gmail.com>
1012
1013 * fringe.c: Fix typo in comments.
1014
cd276f6e
LL
10152012-07-14 Leo Liu <sdl.web@gmail.com>
1016
1017 * fringe.c: Add a new bitmap exclamation-mark.
1018
5a1131d9
EZ
10192012-07-14 Eli Zaretskii <eliz@gnu.org>
1020
1021 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
1022
1023 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
1024 (HAVE_MENUS): Don't define, defined by editing config.in with
1025 msdos/sed2v2.inp.
1026 (GMALLOC_INHIBIT_VALLOC): Don't define.
1027 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
1028
22e983b7
JB
10292012-07-14 Juanma Barranquero <lekktu@gmail.com>
1030
1031 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
1032
5b3f250f
GM
10332012-07-14 Glenn Morris <rgm@gnu.org>
1034
1035 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
1036 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
1037 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
1038
33d63ff4
GM
10392012-07-13 Glenn Morris <rgm@gnu.org>
1040
5b633342
GM
1041 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
1042
33d63ff4
GM
1043 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
1044 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
1045
b55b9f85
JD
10462012-07-13 Jan Djärv <jan.h.d@swipnet.se>
1047
0dc8cf50
JD
1048 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
1049 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
1050 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
1051 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
1052 where appropriate.
1053 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
1054 as boolean expression.
1055 (x_set_window_size): Remove unused variable toolbar.
1056 (ns_get_color_default, ns_mod_to_lisp): Remove.
1057 (ns_mouse_position): Remove unused variables xchar and ychar.
1058 (ns_compute_glyph_string_overhangs): Remove unused variable face.
1059 (ns_set_vertical_scroll_bar): Remove unused variable count.
1060 (ns_delete_terminal): Remove unused variable i.
1061 (ns_term_init): Remove unused variables r, g and b.
1062 (mouseDown): Remove unused variable window.
1063 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
1064 (initFrameFromEmacs): Remove unused variable vbextra.
1065 (mouseEntered): Remove unused variables p and dpyinfo.
1066 (mouseExited): Remove unused variables p and r.
1067 (ns_define_frame_cursor, ns_clear_frame_area)
1068 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
1069 (menuDown): Assign [sender tag] to variable and cast the variable.
1070
1071 * nsterm.h (menuDown): Add id as type to argument sender.
1072 (ns_display_info_for_name): Add Lisp_Object argument.
1073 (ns_term_init): Add Lisp_Object argument.
1074 (ns_map_event_to_object): Add void argument.
1075 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
1076 prototype with arguments and only declare if __OBJC__.
1077 (nxatoms_of_nsselect): Add void argument.
1078 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
1079 (ns_alloc_autorelease_pool): Add void argument.
1080 (ns_release_autorelease_pool): Add void* argument.
1081 (ns_get_defaults_value): Add const char* argument.
1082
1083 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
1084 (initFromContents): Use SSDATA where appropriate.
1085 (ns_update_menubar): Add braces to ambigous if-else.
1086 (initWithTitle): Put () around assignment in if statement.
1087 (ns_menu_show): Remove unused variables window and keymap.
1088 (update_frame_tool_bar): Remove unused variable selected_p.
1089 (initWithContentRect): Remove unused variable this_cmd_name.
1090
1091 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
1092 appropriate.
1093 (setXBMColor): Remove unused variable len.
1094 (setPixmapData): Put () around assignment in loop statement.
1095
1096 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
1097 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
1098 where appropriate.
1099 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
1100 around assignment in loop statement.
1101 (nsfont_open): Remove unused variable i.
1102 (nsfont_open): Remove unused variable len.
1103 (nsfont_draw): Remove unused variable cs.
1104
1105 * nsfns.m (x_set_icon_name, ns_set_name_internal)
1106 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
1107 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
1108 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
1109 (Fns_font_name, Fns_perform_service)
1110 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
1111 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
1112 (ns_set_name): Remove unused variable view.
1113 (x_set_menu_bar_lines): Remove unused variable olines.
1114 (x_set_tool_bar_lines): Remove unused variable root_window.
1115 (Fns_list_colors): Put () around assignment in while statement.
1116 (Fns_perform_service): Remove unused variable len.
1117 (Fns_display_usable_bounds): Remove unused variable top.
1118 (syms_of_nsfns): Remove unused variable i.
1119
b55b9f85
JD
1120 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
1121 memcpy (Bug#11907).
1122
ed9265fc 11232012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
1124
1125 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
1126 and free it with DestroyExceptionInfo (Bug#11558).
1127
ef099b57
JB
11282012-07-13 Juanma Barranquero <lekktu@gmail.com>
1129
1130 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
1131 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
1132 Set here, not in nt/config.nt.
1133
ea814a5d
EZ
11342012-07-13 Eli Zaretskii <eliz@gnu.org>
1135
1136 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
1137 cursor overflow into the last glyph on display line when the right
1138 fringe is off. (Bug#11832)
1139
1a952767
PE
11402012-07-13 Paul Eggert <eggert@cs.ucla.edu>
1141
1142 * xdisp.c (produce_special_glyphs): Now static.
1143 * dispextern.h (produce_special_glyphs): Remove decl.
1144
983188fd
GM
11452012-07-13 Glenn Morris <rgm@gnu.org>
1146
8d7c7eed 1147 * s/bsd-common.h, s/cygwin.h: Remove empty files.
32fb4bb6
GM
1148 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
1149
983188fd
GM
1150 * s/usg5-4-common.h (USG, USG5):
1151 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
1152 * s/sol2-6.h (SOLARIS2):
1153 * s/irix6-5.h (IRIX6_5):
1154 * s/hpux10-20.h (USG, USG5, HPUX):
1155 * s/gnu-linux.h (USG, GNU_LINUX):
1156 * s/freebsd.h (BSD_SYSTEM):
1157 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
1158 * s/cygwin.h (CYGWIN):
1159 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
1160 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
1161
d1e68667 11622012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
1163
1164 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 1165
6de0e799
GM
11662012-07-13 Glenn Morris <rgm@gnu.org>
1167
739ae010
GM
1168 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
1169
dbee5793
GM
1170 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
1171
6de0e799
GM
1172 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
1173 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
1174
b82da769
GM
11752012-07-12 Glenn Morris <rgm@gnu.org>
1176
4fae5a7a 1177 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
1178
1179 * process.c (init_process_emacs): Rename from init_process.
1180 The old name is also the name of a Mach system call.
1181 * lisp.h, emacs.c: Update for this name change.
1182 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
1183 longer needed.
1184
5a979817
EZ
11852012-07-12 Eli Zaretskii <eliz@gnu.org>
1186
1187 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
1188 memmove call that removes glyphs covered by the left truncation
1189 glyph. Improve commentary.
1190 (display_line): Fix display of continuation glyphs on GUI frames
1191 when the right fringe is turned off and variable-size fonts are
1192 used in the window. Move the code that appends a stretch glyph to
1193 produce_special_glyphs, so that it could be used for truncation
1194 and continuation glyphs alike.
1195 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
1196 glyph of a suitably computed width, to align the special glyphs at
1197 the window margin. Code moved from display_line. (Bug#11832)
1198
3e91a053
GM
11992012-07-12 Glenn Morris <rgm@gnu.org>
1200
ba9e4b84
GM
1201 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
1202
1203 * s/gnu-linux.h, s/hpux10-20.h:
1204 Do not unconditionally define HAVE_XRMSETDATABASE.
1205
3e91a053
GM
1206 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
1207
b300b1f4
PE
12082012-07-12 Paul Eggert <eggert@cs.ucla.edu>
1209
1210 Fix typos that broke OS X build.
1211 Reported by Randal L. Schwartz in
1212 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
1213 * nsterm.m (ns_timeout): Add missing local decl.
1214 (ns_get_color): snprintf -> sprintf, to fix typo.
1215
6e777848
GM
12162012-07-12 Glenn Morris <rgm@gnu.org>
1217
3f922c37
GM
1218 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
1219 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
1220 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
1221 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
1222
0ab7b23a
GM
1223 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
1224 Move PTY_OPEN to configure.
1225
6e777848
GM
1226 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1227 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
1228 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
1229
4a7edc24
DA
12302012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
1231
1232 Use empty_unibyte_string where applicable.
1233 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
1234 * lread.c (read1): Likewise.
1235 * xsettings.c (syms_of_xsettings): Likewise.
1236
308aab79
GM
12372012-07-12 Glenn Morris <rgm@gnu.org>
1238
42bd1719
GM
1239 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
1240 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
1241 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
1242 * s/hpux10-20.h (RUN_TIME_REMAP):
1243 * s/bsd-common.h (TABDLY): Move to configure.
1244
1245 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
1246
1247 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
1248
ea0bbd17 1249 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 1250 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
1251
1252 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 1253
308aab79
GM
1254 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
1255 * s/template.h: Move NARROWPROTO to configure.
1256
ee1cf5cf
GM
12572012-07-11 Glenn Morris <rgm@gnu.org>
1258
30fe9bf4
GM
1259 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
1260 unused since 2011-01-17 change to systty.h.
1261
ee1cf5cf
GM
1262 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
1263 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1264 Move HAVE_PTYS and HAVE_SOCKETS to configure.
1265
63e47e07
PE
12662012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1267
1268 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
1269
c43fb4c3
GM
12702012-07-11 Glenn Morris <rgm@gnu.org>
1271
1272 * s/darwin.h, s/gnu-linux.h, s/template.h:
1273 Move INTERRUPT_INPUT to configure.
1274
e8df9267
DA
12752012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1276
1277 Minor adjustments to interning code.
1278 * lisp.h (intern, intern_c_string): Redefine as static inline
1279 wrappers for intern_1 and intern_c_string_1, respectively.
1280 (intern_1, intern_c_string_1): Rename prototypes.
2bce5643
DA
1281 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
1282 Vobarray checking.
e8df9267
DA
1283 * font.c (font_intern_prop): Likewise. Adjust comment.
1284 * w32font.c (intern_font_name): Likewise.
1285
34348bd4
AS
12862012-07-11 Andreas Schwab <schwab@linux-m68k.org>
1287
d96a1e0c
AS
1288 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
1289
34348bd4
AS
1290 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
1291 of Fcar/Fcdr if possible.
1292 * font.c (check_otf_features): Likewise.
1293 * fontset.c (Fnew_fontset): Likewise.
1294 * gnutls.c (Fgnutls_boot): Likewise.
1295 * minibuf.c (read_minibuf): Likewise.
1296 * msdos.c (IT_set_frame_parameters): Likewise.
1297 * xmenu.c (Fx_popup_dialog): Likewise.
1298 * w32menu.c (Fx_popup_dialog): Likewise.
1299
c8add24e
GM
13002012-07-11 Glenn Morris <rgm@gnu.org>
1301
4b575b3c
GM
1302 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
1303 since nothing has defined it on these platforms.
1304
09f4e3b0
GM
1305 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
1306 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
1307
172bedef
GM
1308 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1309 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1310 Move CLASH_DETECTION to configure.
1311
249685df
GM
1312 * s/gnu.h: Remove file, which is now empty.
1313
c8add24e
GM
1314 * s/gnu.h, s/gnu-linux.h:
1315 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
1316
b41253a3
JW
13172012-07-11 John Wiegley <johnw@newartisans.com>
1318
1319 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
1320 function attribute, so we only use it if it exists in the
1321 compiler.
1322
d923b542
DA
13232012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1324
1325 Avoid call to strlen in fast_c_string_match_ignore_case.
1326 * search.c (fast_c_string_match_ignore_case): Change to use
1327 length argument. Adjust users accordingly.
1328 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
1329
5ebbef1d
PE
13302012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1331
bb352260
PE
1332 Assume mkdir, rmdir.
1333 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
1334 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
1335
57054ddd
PE
1336 Assume rename.
1337 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
1338
b747d3f7
PE
1339 Assume perror.
1340 * s/hpux10-20.h (HAVE_PERROR): Remove.
1341 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
1342 Remove dummy definition, as this problem was obsolete long ago.
1343
5ebbef1d
PE
1344 Assume strerror.
1345 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
1346
984e7f30
DA
13472012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1348
1349 Avoid calls to strlen in font processing functions.
1350 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
d923b542 1351 (font_open_by_name): Change to use length argument. Adjust
984e7f30 1352 users accordingly.
d923b542
DA
1353 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
1354 Adjust prototypes.
1355 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
1356 Change to return ptrdiff_t.
984e7f30
DA
1357 (xfont_list_pattern, xfont_match): Use length returned by
1358 xfont_decode_coding_xlfd.
1359 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
1360
20e94fdd
GM
13612012-07-11 Glenn Morris <rgm@gnu.org>
1362
9d596af3
GM
1363 * s/darwin.h, s/freebsd.h, s/netbsd.h:
1364 Move DONT_REOPEN_PTY to configure.
1365
20e94fdd
GM
1366 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
1367 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
1368
e99a530f
PE
13692012-07-10 Paul Eggert <eggert@cs.ucla.edu>
1370
22ffb973
PE
1371 Remove "#define unix" that is no longer needed (Bug#11905).
1372 * s/aix4-2.h (unix): Remove; no longer needed.
1373
e9a9ae03
PE
1374 EMACS_TIME simplification (Bug#11875).
1375 This replaces macros (which typically do not work in GDB)
1376 with functions, typedefs and enums, making the code easier to debug.
1377 The functional style also makes code easier to read and maintain.
1378 * systime.h: Include <sys/time.h> on all hosts, not just if
1379 WINDOWSNT, since 'struct timeval' is needed in general.
1380 (EMACS_TIME): Now a typedef, not a macro.
1381 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
1382 not macros.
1383 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
1384 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
1385 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
1386 (EMACS_TIME_LE): Now functions, not macros.
1387 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
1388 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
1389 which are not functions. All uses rewritten to use:
1390 (make_emacs_time): New function.
1391 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
1392 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
1393 not functions. All uses rewritten to use the following, respectively:
1394 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
1395 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 1396 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
1397 * fileio.c (Fcopy_file):
1398 * xterm.c (XTflash): Get the current time closer to when it's used.
1399 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
1400
ffacb126
PE
1401 * bytecode.c (targets): Suppress -Woverride-init warnings.
1402
e99a530f
PE
1403 Simplify by avoiding confusing use of strncpy etc.
1404 * doc.c (Fsnarf_documentation):
1405 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
1406 * frame.c (Fmake_terminal_frame):
1407 * gtkutil.c (get_utf8_string):
1408 * lread.c (openp):
1409 * nsmenu.m (ns_update_menubar):
1410 * regex.c (regerror):
1411 Prefer memcpy to strncpy and strncat when either will do.
1412 * fileio.c (Fsubstitute_in_file_name):
1413 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
1414 (menu_separator_name_p):
1415 * nsmenu.m (ns_update_menubar):
1416 Prefer memcmp to strncmp when either will do.
1417 * nsterm.m: Include <ftoastr.h>.
1418 (ns_get_color):
1419 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
1420 Prefer snprintf to strncpy.
1421 * nsterm.m (ns_term_init):
1422 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
1423 * nsterm.m (ns_term_init):
1424 Avoid the need for strncpy, by using build_string or
1425 make_unibyte_string directly. Use dtoastr, not snprintf.
1426 * process.c (Fmake_network_process): Diagnose service names that
1427 are too long, rather than silently truncating them or creating
1428 non-null-terminated names.
1429 (Fnetwork_interface_info): Likewise, for interface names.
1430 * sysdep.c (system_process_attributes) [GNU_LINUX]:
1431 Prefer sprintf to strncat.
1432 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
1433 Prefer vsnprintf to vsprintf + strncpy.
1434
c59592b3
GM
14352012-07-10 Glenn Morris <rgm@gnu.org>
1436
1437 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
1438 Clarify fallback case.
1439
7d7bbefd
DA
14402012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1441
1442 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
1443 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
1444 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 1445 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
1446 where argument type is known to be a Lisp_Cons.
1447
3a4c8000
TT
14482012-07-10 Tom Tromey <tromey@redhat.com>
1449
1450 * bytecode.c (BYTE_CODE_THREADED): New macro.
1451 (BYTE_CODES): New macro. Replaces all old byte-code defines.
1452 (enum byte_code_op): New type.
1453 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
1454 (exec_byte_code): Use them. Use token threading when applicable.
1455
2a0213a6
DA
14562012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1457
1458 Optimize pure C strings initialization.
1459 * lisp.h (make_pure_string): Fix prototype.
1460 (build_pure_c_string): New function, defined as static inline. This
1461 provides a better opportunity to optimize away calls to strlen when
1462 the function is called with compile-time constant argument.
1463 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
1464 argument, adjust users accordingly. Use build_pure_c_string where
1465 appropriate.
1466 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
1467 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
1468 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
1469
cb1caeaf
DA
14702012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1471
1472 Avoid calls to strlen in miscellaneous functions.
1473 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
1474 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
1475 * lread.c (openp): Likewise.
1476
c293e30c
DA
14772012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1478
1479 Avoid calls to strlen in path processing functions.
1480 * fileio.c (file_name_as_directory): Add comment. Change to add
1481 srclen argument and return the length of result. Adjust users
1482 accordingly.
1483 (directory_file_name): Fix comment. Change to add srclen argument,
cb1caeaf 1484 swap 1st and 2nd arguments to obey the common convention. Adjust
c293e30c
DA
1485 users accordingly.
1486 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
1487
9e059e3f
GM
14882012-07-10 Glenn Morris <rgm@gnu.org>
1489
d02eb359
GM
1490 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
1491 Move PENDING_OUTPUT_COUNT definition to configure.
1492
882cf227
GM
1493 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
1494 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
1495 * s/gnu.h (DATA_START): Move definitions to configure.
1496
af6e839f
GM
1497 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
1498 We include usg5-4-common.h, which defines them both.
1499
40289a12
GM
1500 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
1501 O_RDONLY already includes it).
1502
9e059e3f
GM
1503 Stop ns builds setting the EMACSLOADPATH environment variable.
1504 * nsterm.m (ns_load_path): Rename from ns_init_paths.
1505 Now it does not set EMACSLOADPATH, just returns the load-path string.
1506 * nsterm.h: Update accordingly.
1507 * lread.c [HAVE_NS]: Include nsterm.h.
1508 (init_lread) [HAVE_NS]: Use ns_load_path.
1509 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
1510
7c4e8ec0
GM
15112012-07-09 Glenn Morris <rgm@gnu.org>
1512
d4f600ff
GM
1513 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
1514 since the included bsd-common.h does so.
1515
cbb31951
GM
1516 Stop ns builds setting the EMACSPATH environment variable.
1517 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
1518 (ns_init_paths): Do not set EMACSPATH.
1519 * nsterm.h (ns_exec_path): Add it.
1520 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
1521 Use ns_exec_path.
1522
7c4e8ec0
GM
1523 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
1524
26bccfae
PE
15252012-07-09 Paul Eggert <eggert@cs.ucla.edu>
1526
a0bee46f
PE
1527 * process.c (wait_reading_process_output): 'waitchannels' was unset
1528 when read_kbd || !NILP (wait_for_cell); fix this.
1529
5994c183
PE
1530 Add GCC-style 'const' attribute to functions that can use it.
1531 * character.h (char_resolve_modifier_mask):
1532 * keyboard.h (make_ctrl_char):
1533 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
1534 (init_character_once, next_almost_prime, init_fns, init_image)
1535 (flush_pending_output, init_sound):
1536 * mem-limits.h (start_of_data):
1537 * menu.h (finish_menu_items):
1538 Add ATTRIBUTE_CONST.
1539 * emacs.c (DEFINE_DUMMY_FUNCTION):
1540 Declare the dummy function with ATTRIBUTE_CONST.
1541 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
1542 Add decls with ATTRIBUTE_CONST.
1543
26bccfae
PE
1544 Minor improvements to make_formatted_string.
1545 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
1546 where int is good enough, as vsprintf returns an int.
1547 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
1548
a8290ec3
DA
15492012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1550
1551 Use make_formatted_string to avoid double length calculation.
1552 * lisp.h (make_formatted_string): New prototype.
1553 * alloc.c (make_formatted_string): New function.
1554 * buffer.c (Fgenerate_new_buffer_name): Use it.
1555 * dbus.c (syms_of_dbusbind): Likewise.
1556 * editfns.c (Fcurrent_time_zone): Likewise.
1557 * filelock.c (get_boot_time): Likewise.
1558 * frame.c (make_terminal_frame, set_term_frame_name)
1559 (x_report_frame_params): Likewise.
1560 * image.c (gs_load): Likewise.
1561 * minibuf.c (get_minibuffer): Likewise.
1562 * msdos.c (dos_set_window_size): Likewise.
1563 * process.c (make_process): Likewise.
1564 * xdisp.c (ensure_echo_area_buffers): Likewise.
1565 * xsettings.c (apply_xft_settings): Likewise.
1566
d01ba2f1
GM
15672012-07-09 Glenn Morris <rgm@gnu.org>
1568
1569 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
1570 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
1571 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
1572 * nsterm.h (ns_etc_directory): Add it.
1573 * callproc.c [HAVE_NS]: Include nsterm.h.
1574 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
1575
f1f924b6
DA
15762012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1577
1578 Move marker debugging code under MARKER_DEBUG.
1579 * marker.c (MARKER_DEBUG): Move marker debugging code under
1580 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
1581 for bootstrap with --enable-checking (~3x slowdown reported
1582 by Juanma Barranquero <lekktu@gmail.com>).
1583 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
1584
ab531b66
PE
15852012-07-08 Paul Eggert <eggert@cs.ucla.edu>
1586
1587 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
1588 See <http://bugs.gnu.org/11825#29>.
1589
c4b3bc8a
EZ
15902012-07-08 Eli Zaretskii <eliz@gnu.org>
1591
1592 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
1593 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
1594 (display_line): Add commentary about displaying truncation glyphs
1595 on GUI frames.
1596 (produce_special_glyphs): Move here from term.c.
1597
1598 * term.c (produce_special_glyphs): Move to xdisp.c.
1599
1600 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
1601 section.
c4b3bc8a 1602
b676b881
AS
16032012-07-07 Andreas Schwab <schwab@linux-m68k.org>
1604
f17c5273
AS
1605 * xdisp.c (display_line): Avoid warning about implicit declaration
1606 of FRAME_FONT.
1607
298819b9
AS
1608 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
1609
b676b881
AS
1610 * lisp.h: Remove empty conditional.
1611
6045c4fd
PE
16122012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1613
b3350bf9
PE
1614 * lread.c (load_path_check): Now static.
1615
6045c4fd
PE
1616 Fix some minor --with-ns problems found by static checking.
1617 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
1618 (x_set_font) [!HAVE_X_WINDOWS]:
1619 * image.c (xpm_load_image) [HAVE_NS]:
1620 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
1621 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
1622 Remove unused local.
1623 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
1624 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
1625 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
1626 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
1627 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
1628 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
1629 Fix pointer signedness problem.
1630 * xfaces.c (FRAME_X_FONT_TABLE):
1631 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
1632
929e7845
GM
16332012-07-07 Glenn Morris <rgm@gnu.org>
1634
1635 * lread.c (load_path_check): New function, split from init_lread.
1636 (init_lread): Reorganize. Motivation:
1637 If EMACSLOADPATH is set, check/warn about that rather than the
1638 defaults, which we are not going to use. Hence we can remove
1639 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
1640 Don't warn if site-lisp directories are missing.
1641 If not installed, start from a blank load-path, since
1642 PATH_LOADSEARCH refers to the eventual installation directories.
1643
58dd0aa4
EZ
16442012-07-07 Eli Zaretskii <eliz@gnu.org>
1645
1646 Support truncation and continuation glyphs on GUI frames, when
1647 fringes are disabled. (Bug#11832)
1648 * xdisp.c (init_iterator): Get dimensions of truncation and
1649 continuation glyphs even if on GUI frames. Adjust
1650 it->last_visible_x on GUI frames when the left or right fringes,
1651 or both, are absent.
1652 (start_display, move_it_in_display_line_to): Handle the case of a
1653 GUI frame without a fringe to display continuation or truncation
1654 glyphs.
1655 (insert_left_trunc_glyphs): Support GUI frames: make sure
1656 truncation glyphs overwrite enough glyphs from the current line to
1657 have sufficient space in pixels.
1658 (display_line): Support truncation and continuation glyphs on GUI
1659 frames. If some spare pixels are left on the line after inserting
1660 the truncation glyphs, fill that space with a stretch glyph of a
1661 suitably computed width.
1662
1663 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
1664 produce_glyphs, to support GUI sessions.
1665
31571fd7
PE
16662012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1667
5a16b9bc
PE
1668 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
1669
f3047c75
PE
1670 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
1671
31571fd7
PE
1672 Do not require float-time's arg to fit in time_t (Bug#11825).
1673 This works better on hosts where time_t is unsigned, and where
1674 float-time is applied to the (negative) difference between two times.
1675 * editfns.c (decode_time_components): Last arg is now double *,
1676 not int *, and means to store all the result as a double, without
1677 worrying about whether the seconds part fits in time_t.
1678 All callers changed.
1679 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
1680 All callers changed.
1681 (Ffloat_time): Do not fail merely because the specified time falls
1682 outside of time_t range.
1683
4516fbef
GM
16842012-07-07 Glenn Morris <rgm@gnu.org>
1685
1686 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
1687 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
1688 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
1689
07adc2c6
JB
16902012-07-07 Juanma Barranquero <lekktu@gmail.com>
1691
1692 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
1693 Update dependencies.
1694
1695 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
1696
fd573f31
PE
16972012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1698
fee5959d
PE
1699 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
1700 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
1701 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
1702 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
1703 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
1704 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
1705
fd573f31
PE
1706 * xfont.c (compare_font_names): Redo to omit the need for casts.
1707
ddadbc0e
AS
17082012-07-06 Andreas Schwab <schwab@linux-m68k.org>
1709
fca8d6b6
AS
1710 * xfns.c (Fx_change_window_property): Doc fix.
1711 * w32fns.c (Fx_change_window_property): Doc fix.
1712
ddadbc0e
AS
1713 * w32fns.c (Fx_window_property): Accept the same arguments as the
1714 X Windows version. Doc fix.
1715 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
1716
ed9265fc 17172012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
1718 Eli Zaretskii <eliz@gnu.org>
1719
1720 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
1721 Windows-specific code from nt/config.nt moved here.
1722 Obsolete settings removed.
1723
216ee680
PE
17242012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1725
1726 * process.c: Avoid unnecessary calls to gettime.
1727 (wait_reading_process_output): Don't get the time of day
1728 when gobbling data immediately and not waiting, as there's no need
1729 for it in that case. This removes a FIXME.
1730
bdd091e4
JD
17312012-07-06 Jan Djärv <jan.h.d@swipnet.se>
1732
1733 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
1734 is defined (Bug#11768).
1735
9d44f8ce
DA
17362012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1737
1738 Fix marker debugging code.
1739 * marker.c (byte_char_debug_check): Do not perform the check
1740 if buffer is not multibyte.
090bd7cb
JB
1741 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1742 Call byte_char_debug_check with correct arguments.
9d44f8ce 1743
90fc4786
DA
17442012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1745
1746 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
1747 * marker.c (byte_char_debug_check, count_markers):
1748 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
1749 (byte_debug_flag): Remove.
1750 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1751 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
1752
7b7ae965
DA
17532012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1754
4e57b342
DA
1755 Avoid code repetition in marker-related functions.
1756 * marker.c (attach_marker): New function.
1757 (Fset_marker, set_marker_restricted, set_marker_both)
1758 (set_marker_restricted_both): Use it.
1759 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
1760 Consistently rename charno to charpos.
1761 (marker_position): Add eassert.
1762 (marker_byte_position): Convert to eassert.
1763
17642012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1765
1766 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 1767 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 1768 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 1769
657924ff
DA
17702012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1771
1772 Introduce fast path for the widely used marker operation.
1773 * alloc.c (build_marker): New function.
1774 * lisp.h (build_marker): New prototype.
1775 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
1776 * composite.c (autocmp_chars): Likewise.
1777 * editfns.c (buildmark): Remove.
1778 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
1779 (save_restriction_save): Use build_marker.
1780 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
1781 * window.c (save_window_save): Likewise.
1782
041a49a6
DA
17832012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1784
1785 Do not use Fdelete_overlay in delete_all_overlays
1786 to avoid redundant calls to unchain_overlay.
1787 * buffer.c (drop_overlay): New function.
1788 (delete_all_overlays, Fdelete_overlay): Use it.
1789 * minibuf.c (get_minibuffer): Fix comment.
1790
7dca65a4
PE
17912012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1792
1793 Port to OpenBSD 5.1 amd64.
1794 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
1795 This is needed for OpenBSD, and should be harmless on all BSD systems.
1796 Also, include <sys/sysctl.h>, as it should be available on all
1797 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
1798 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
1799 use p_pid member, not kp_proc.pid.
1800
8eb876e2
GM
18012012-07-06 Glenn Morris <rgm@gnu.org>
1802
1803 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
1804
38182d90
PE
18052012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1806
1807 More xmalloc and related cleanup.
1808 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
1809 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
1810 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
1811 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
1812 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
1813 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
1814 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
1815 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
1816 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
1817 * xterm.c:
1818 Omit needless casts involving void * pointers and allocation.
1819 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
1820 as the former is more robust if P's type is changed.
1821 Prefer xzalloc to xmalloc + memset 0.
1822 Simplify malloc-or-realloc to realloc.
1823 Don't worry about xmalloc returning a null pointer.
1824 Prefer xstrdup to xmalloc + strcpy.
1825 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
1826 growing it.
1827 * keyboard.c (apply_modifiers_uncached): Prefer local array to
1828 alloca of a constant.
1829
6dd5a677
EZ
18302012-07-05 Eli Zaretskii <eliz@gnu.org>
1831
1832 * xdisp.c (display_line): Fix horizontal pixel coordinates when
1833 hscroll is larger than the line width. Fixes long and futile
1834 looping inside extend_face_to_end_of_line (on a TTY) producing
1835 glyphs that are not needed and thrown away.
1836
6b312f0f
DA
18372012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1838
1839 * marker.c (set_marker_restricted_both): Simplify by using
1840 clip_to_bounds.
1841
f520ef9b
PE
18422012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1843
1844 * editfns.c (region_limit): Simplify by using clip_to_bounds.
1845
383b7c95
JD
18462012-07-05 Jan Djärv <jan.h.d@swipnet.se>
1847
1848 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
1849 not defined (Bug#11768).
1850 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
1851 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
1852 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
1853 followed by gtk_box_set_homogeneous (Bug#11768).
1854 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
1855 (update_theme_scrollbar_width, xg_create_scroll_bar):
1856 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
1857 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
1858 (is_box_type): New function (Bug#11768).
1859 (xg_tool_item_stale_p): Call is_box_type.
5293d758 1860 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
1861 with default display (Bug#11768).
1862
d6e7bf45
EZ
18632012-07-05 Eli Zaretskii <eliz@gnu.org>
1864
1865 * xdisp.c (window_hscroll_limited): New function.
1866 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
1867 coordinates when window's hscroll is set to insanely large
1868 values. (Bug#11857)
1869
431391ec
JB
18702012-07-05 Juanma Barranquero <lekktu@gmail.com>
1871
1872 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
1873 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
1874
23f86fce
DA
18752012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1876
1877 Cleanup xmalloc.
1878 * lisp.h (xzalloc): New prototype. Omit needless casts.
1879 * alloc.c (xzalloc): New function. Omit needless casts.
1880 * charset.c: Omit needless casts. Convert all calls to
1881 xmalloc with following memset to xzalloc.
1882 * dispnew.c: Likewise.
1883 * fringe.c: Likewise.
1884 * image.c: Likewise.
1885 * sound.c: Likewise.
1886 * term.c: Likewise.
1887 * w32fns.c: Likewise.
1888 * w32font.c: Likewise.
1889 * w32term.c: Likewise.
1890 * xfaces.c: Likewise.
1891 * xfns.c: Likewise.
1892 * xterm.c: Likewise.
1893 * atimer.c: Omit needless casts.
1894 * buffer.c: Likewise.
1895 * callproc.c: Likewise.
1896 * ccl.c: Likewise.
1897 * coding.c: Likewise.
1898 * composite.c: Likewise.
1899 * doc.c: Likewise.
1900 * doprnt.c: Likewise.
1901 * editfns.c: Likewise.
1902 * emacs.c: Likewise.
1903 * eval.c: Likewise.
1904 * filelock.c: Likewise.
1905 * fns.c: Likewise.
1906 * gtkutil.c: Likewise.
1907 * keyboard.c: Likewise.
1908 * lisp.h: Likewise.
1909 * lread.c: Likewise.
1910 * minibuf.c: Likewise.
1911 * msdos.c: Likewise.
1912 * print.c: Likewise.
1913 * process.c: Likewise.
1914 * region-cache.c: Likewise.
1915 * search.c: Likewise.
1916 * sysdep.c: Likewise.
1917 * termcap.c: Likewise.
1918 * terminal.c: Likewise.
1919 * tparam.c: Likewise.
1920 * w16select.c: Likewise.
1921 * w32.c: Likewise.
1922 * w32reg.c: Likewise.
1923 * w32select.c: Likewise.
1924 * w32uniscribe.c: Likewise.
1925 * widget.c: Likewise.
1926 * xdisp.c: Likewise.
1927 * xmenu.c: Likewise.
1928 * xrdb.c: Likewise.
1929 * xselect.c: Likewise.
1930
0497dc44
PE
19312012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1932
1933 * fileio.c (time_error_value): Check the right error number.
1934 Problem reported by Troels Nielsen in
1935 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
1936
356e7178
PE
19372012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1938
4e71fd89
PE
1939 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
1940 This should be fixed in a better way; see Eli Zaretskii in
1941 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
1942 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
1943
f0941253
PE
1944 * fileio.c (time_error_value): Rename from special_mtime.
1945 The old name's problems were noted by Eli Zaretskii in
1946 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
1947
065c9eb4
PE
1948 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
1949 This variable's comment says Emacs needs at least one GDB-visible
1950 symbol of type enum pvec_type, to work around GDB problems.
1951 The symbol's value doesn't matter.
1952
356e7178
PE
1953 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
1954 that causes compilation to fail on pre-C99 compilers.
1955
ed9265fc 19562012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
1957
1958 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
1959 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
1960
3884d954
DA
19612012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1962
d209e2fb 1963 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
1964 headers for buffer_defaults and buffer_local_symbols.
1965 Reported by Juanma Barranquero <lekktu@gmail.com>.
1966
ee28be33
SM
19672012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1968
1969 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
1970 * lisp.h (enum pvec_type): Use fewer bits.
1971 (PSEUDOVECTOR_SIZE_BITS): New constant.
1972 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
1973 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
1974 change in pvec_type.
1975 (PSEUDOVECTOR_TYPEP): New macro.
1976 (TYPED_PSEUDOVECTORP): Use it.
1977 * fns.c (internal_equal): Adapt code to extract pvectype.
1978 * emacs.c (gdb_pvec_type): Update type.
1979 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
1980 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
1981 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
1982 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
1983 (sweep_vectors): Use it. Use local var `total_bytes' instead of
1984 abusing vector->header.next.nbytes.
1985 (live_vector_p): Use PVEC_TYPE.
1986 (mark_object): Adapt code to extract pvectype. Use switch.
1987
c7f2cd7f
PE
19882012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1989
1990 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
1991 Tighten new eassert a bit.
1992
8ce70ed2
DA
19932012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1994
1995 Fix compilation with --enable-gcc-warnings and -O1
1996 optimization level.
1997 * doprnt.c (doprnt): Change type of tem to int, initialize
1998 to avoid compiler warning. Add eassert.
1999 * search.c (simple_search): Initialize match_byte to avoid
2000 compiler warning. Add eassert.
2001
dea7f1e5
PE
20022012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2003
24a212eb
PE
2004 Avoid weird behavior with large horizontal scrolls.
2005 Without this change, for example, large hscroll values would
2006 mess up Emacs's display on Fedora 15 x86, presumably due to
2007 overflows in int calculations in the display code.
2008 Also, if buffers had long lines, Emacs would freeze.
2009 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
2010 (set_window_hscroll): New function, containing the old guts of
2011 Fset_window_hscroll. Return the clipped value.
2012 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
2013 This avoids the need to check against PTRDIFF_MAX.
2014
dea7f1e5
PE
2015 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
2016
76046526
DA
20172012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2018
2019 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
2020
39adff0d
PE
20212012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2022
63807d47
PE
2023 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
2024 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
2025 since GCC 4.4.6 issues a bogus warning for them.
2026
39adff0d
PE
2027 Fix bugs in file timestamp newness comparisons.
2028 * fileio.c (Ffile_newer_than_file_p):
2029 * lread.c (Fload): Use full timestamp resolution of files,
2030 not just the 1-second resolution, so that files that are only
2031 slightly newer still count as newer.
2032 * fileio.c (Ffile_newer_than_file_p): Don't assume file
2033 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
2034
dbeed9a6
PE
20352012-07-03 Paul Eggert <eggert@cs.ucla.edu>
2036
2037 * fileio.c: Improve handling of file time marker. (Bug#11852)
2038 (special_mtime): New function.
2039 (Finsert_file_contents, Fverify_visited_file_modtime):
2040 Use it to set special mtime values consistently.
2041
636334d6
AS
20422012-07-03 Andreas Schwab <schwab@linux-m68k.org>
2043
2044 * fileio.c (Finsert_file_contents): Properly handle st_mtime
2045 marker for non-existing file. (Bug#11852)
2046
e2017fe2
GM
20472012-07-03 Glenn Morris <rgm@gnu.org>
2048
2049 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
2050 and did not make it into globals.h).
2051
404dbd37
TT
20522012-07-03 Tom Tromey <tromey@redhat.com>
2053
2054 * window.c (Fset_window_margins, Fset_window_fringes)
2055 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
2056 * textprop.c (Fprevious_property_change): No longer static.
2057 * syntax.c (Fsyntax_table_p): No longer static.
2058 * process.c (Fget_process, Fprocess_datagram_address): No longer
2059 static.
2060 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
2061 * keyboard.c (Fcommand_execute): No longer static.
2062 Remove EXFUN.
2063 * insdel.c (Fcombine_after_change_execute): No longer static.
2064 * image.c (Finit_image_library): No longer static.
2065 * fileio.c (Fmake_symbolic_link): No longer static.
2066 * eval.c (Ffetch_bytecode): No longer static.
2067 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
2068 * doc.c (Fdocumentation_property, Fsnarf_documentation):
2069 No longer static.
404dbd37
TT
2070 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
2071 static.
2072 * dired.c (Ffile_attributes): No longer static.
2073 * composite.c (Fcomposition_get_gstring): No longer static.
2074 * callproc.c (Fgetenv_internal): No longer static.
2075
2076 * ccl.h: Remove EXFUNs.
2077 * buffer.h: Remove EXFUNs.
2078 * dispextern.h: Remove EXFUNs.
2079 * intervals.h: Remove EXFUNs.
2080 * fontset.h: Remove EXFUN.
2081 * font.h: Remove EXFUNs.
2082 * dosfns.c (system_process_attributes): Remove EXFUN.
2083 * keymap.h: Remove EXFUNs.
2084 * lisp.h: Remove EXFUNs.
2085 * w32term.h: Remove EXFUNs.
2086 * window.h: Remove EXFUNs.
2087 * xsettings.h: Remove EXFUN.
2088 * xterm.h: Remove EXFUN.
2089
8e4fd1e1
GM
20902012-07-03 Glenn Morris <rgm@gnu.org>
2091
2092 * lisp.h (Frandom): Make it visible to C.
2093 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
2094 buffer for invisible buffers. (Bug#1229)
2095
ca95b3eb
DA
20962012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2097
2098 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
2099 values which aren't power of 2.
2100 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
2101 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
2102 accordingly.
2103
7555c33f
SM
21042012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
2105
2106 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
2107
2108 * alloc.c (mark_object): Revert part of last patch to use `switch'.
2109
d12e8f5a
DA
21102012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2111
2112 * alloc.c (allocate_vector_block): Remove redundant
2113 calls to mallopt if DOUG_LEA_MALLOC is defined.
2114 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
2115 avoid calls to mallopt if zero_vector is returned.
2116
296094c3
DA
21172012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2118
2119 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
2120 is enabled, avoid dereferencing NULL current_sblock if
2121 running undumped.
2122
36429c89
DA
21232012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2124
2125 Cleanup basic buffer management.
2126 * buffer.h (struct buffer): Change layout to use generic vector
2127 marking code. Fix some comments. Change type of 'clip_changed'
2128 to bitfield. Remove unused #ifndef old.
2129 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
2130 (GET_OVERLAYS_AT): Fix indentation.
2131 (for_each_per_buffer_object_at): New macro.
2132 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
2133 (Fbuffer_local_variables): Use it.
2134 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
2135 * alloc.c (allocate_buffer): Adjust to match new layout of
2136 struct buffer. Fix comment.
2137 (mark_overlay): New function.
2138 (mark_buffer): Use it. Use mark_vectorlike to mark normal
2139 Lisp area of struct buffer.
2140 (mark_object): Use it. Adjust marking of misc objects
2141 and related comments.
2142
3b3e4cac
PE
21432012-07-02 Paul Eggert <eggert@cs.ucla.edu>
2144
2145 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
2146 wrapper that is not needed because the wrapped code is a no-op (zero
2147 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
2148 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
2149
cf5c0175
DA
21502012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
2151
2152 * alloc.c (mark_buffer): Simplify. Remove prototype.
2153 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 2154 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
2155 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
2156 redundant calls to mark_vectorlike for bool vectors.
2157
ca26824c
GM
21582012-06-30 Glenn Morris <rgm@gnu.org>
2159
2e4c5312
GM
2160 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
2161
ca26824c
GM
2162 * epaths.in (PATH_SITELOADSEARCH): New.
2163 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
2164 This is rather than relying on --enable-locallisppath elements
2165 having "site-lisp" in their names. (Bug#10208#25, 11658)
2166
0d23c240
EZ
21672012-06-30 Eli Zaretskii <eliz@gnu.org>
2168
c9240d7a
EZ
2169 * w32proc.c (sys_select): Accept and ignore one more argument.
2170
2171 * w32.c (emacs_gnutls_pull): Call select with one more argument.
2172
0d23c240 2173 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 2174 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
2175
2176 * sysdep.c: Don't include dos.h and dosfns.h.
2177
2178 * process.c (sys_select):
2179 * msdos.c (sys_select): Accept one more argument and ignore it.
2180
2181 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
2182 adapt data types and code to that.
2183
2184 * dosfns.c:
2185 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
2186 which clashes with the gnulib function of the same name.
2187
af5a5a98
AS
21882012-06-30 Andreas Schwab <schwab@linux-m68k.org>
2189
c5e4379c
AS
2190 * font.c (font_style_to_value, font_style_symbolic)
2191 (font_prop_validate_style): Add type checks for values in
2192 font_style_table.
2193
af5a5a98
AS
2194 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
2195 argument.
2196 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
2197 uses.
2198
8d38f461
EZ
21992012-06-29 Eli Zaretskii <eliz@gnu.org>
2200
2e5a6631
EZ
2201 * xdisp.c (try_window_id): Undo last change.
2202
8d38f461
EZ
2203 * w32.c (getwd): Adjust commentary about startup_dir.
2204 (init_environment): Always call sys_access, even in non-MSVC
2205 builds. Don't chdir to the directory of the Emacs executable.
2206 This undoes code from 1997 which was justified by the need to
2207 "avoid conflicts when removing and renaming directories". But its
2208 downside was that every relative file name was being interpreted
2209 relative to the directory of the Emacs executable, which can never
2210 be TRT. In particular, it broke sys_access when called with
2211 relative file names.
2212 (sys_access): Map GetLastError to errno.
2213
2af3565e
DA
22142012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2215
2216 * window.h (struct window): Change type of 'fringes_outside_margins'
2217 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 2218 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
2219 Adjust comment.
2220 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
2221 to ptrdiff_t.
2222
c8d3a25c 22232012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 2224
c8d3a25c
GM
2225 * gnutls.c (emacs_gnutls_handshake):
2226 Add QUIT to make the loop interruptible.
57570cd3 2227
c8d3a25c 22282012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 2229
c8d3a25c
GM
2230 * charset.c (init_charset): Make lack of etc/charsets fatal.
2231
3e984ee8
DA
22322012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2233
2234 * editfns.c (region_limit): Fix type mismatch.
2235
ef884f23
DA
22362012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2237
2238 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
2239 undefined. Convert from xassert to eassert.
2240 * nsmenu.m: Convert from xassert to eassert.
2241 * nsterm.m: Likewise.
2242
7d7e0027
SM
22432012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
2244
2245 * editfns.c (region_limit): Clip to narrowing (bug#11770).
2246
aa754e6a
PE
22472012-06-28 Paul Eggert <eggert@cs.ucla.edu>
2248
2249 Avoid integer overflow on scroll-left and scroll-right.
2250 * window.c (HSCROLL_MAX): New macro.
2251 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
2252 overflow when requested scroll falls outside ptrdiff_t range.
2253
80b00b08
DA
22542012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2255
2256 * window.h (struct window): Change type of 'hscroll',
2257 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
2258 'last_modified' and 'last_overlay_modified' to EMACS_INT.
2259 Adjust users accordingly.
2260 * xdisp.c (try_cursor_movement): Replace type check with eassert.
2261 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
2262 from EMACS_INT to ptrdiff_t.
2263 (make_window): Omit redundant initialization.
2264
62b2bcf6
JB
22652012-06-28 Juanma Barranquero <lekktu@gmail.com>
2266
2267 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
2268
45942c7d
DA
22692012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2270
2271 * window.h (struct window): Change type of 'use_time' and
2272 'sequence_number' from Lisp_Object to int.
2273 * frame.c (make_frame): Adjust users accordingly.
2274 * print.c (print_object): Likewise.
2275 * window.c (select_window, Fwindow_use_time, make_parent_window)
2276 (make_window): Likewise.
2277
e509cfa6
DA
22782012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2279
2280 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
2281 enabled with --enable-checking=[all,glyphs] configure option.
2282 Fix GLYPH_DEBUG usage assuming that it may be undefined,
2283 adjust comments accordingly.
2284 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
2285 undefined, adjust comments accordingly.
2286 * image.c: Likewise.
2287 * scroll.c: Likewise.
2288 * w32fns.c: Likewise.
2289 * w32term.c: Likewise.
2290 * xdisp.c: Likewise.
2291 * xfaces.c: Likewise.
2292 * xfns.c: Likewise.
2293 * xterm.c: Likewise.
2294
a54e2c05
DA
22952012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2296
2297 Generalize run-time debugging checks.
2298 * dispextern.h (XASSERTS): Remove.
2299 * fontset.c (xassert): Remove.
2300 Convert from xassert to eassert.
2301 * alloc.c: Convert from xassert to eassert.
2302 * bidi.c: Likewise.
2303 * dispnew.c: Likewise.
2304 * fns.c: Likewise.
2305 * fringe.c: Likewise.
2306 * ftfont.c: Likewise.
2307 * gtkutil.c: Likewise.
2308 * image.c: Likewise.
2309 * keyboard.c: Likewise.
2310 * menu.c: Likewise.
2311 * process.c: Likewise.
2312 * scroll.c: Likewise.
2313 * sound.c: Likewise.
2314 * term.c: Likewise.
2315 * w32console.c: Likewise.
2316 * w32fns.c: Likewise.
2317 * w32term.c: Likewise.
2318 * window.c: Likewise.
2319 * xdisp.c: Likewise.
2320 * xfaces.c: Likewise.
2321 * xfns.c: Likewise.
2322 * xselect.c: Likewise.
2323 * xterm.c: Likewise.
2324
1ec4b7b2
SM
23252012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
2326
2327 * fns.c (maybe_resize_hash_table): Output message when growing the
2328 purify-hashtable.
2329
2014308a
DA
23302012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2331
2332 * alloc.c (allocate_string_data): Remove dead code.
2333 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
2334 avoid GCC warning about unused macro.
2335
246155eb
DA
23362012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2337
2338 * alloc.c (allocate_string): Omit intervals initialization.
2339 * alloc.c (make_uninit_multibyte_string): Initialize intervals
2340 as in make_pure_string and make_pure_c_string.
2341
43184b7b
DA
23422012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2343
d209e2fb 2344 * alloc.c (allocate_string): Fix last change.
43184b7b 2345
3fe6dd74
DA
23462012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2347
d209e2fb 2348 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
2349 to memset, add explicit initialization where appropriate.
2350
1ba6038a
GM
23512012-06-27 Glenn Morris <rgm@gnu.org>
2352
2353 * lisp.mk (lisp): Remove paths.elc.
2354
c89926a5
CY
23552012-06-27 Chong Yidong <cyd@gnu.org>
2356
2357 * doc.c (Fsubstitute_command_keys): Fix punctuation.
2358
ed6b3510
JW
23592012-06-26 John Wiegley <johnw@newartisans.com>
2360
1ec4b7b2 2361 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
2362 on Mac OS X Lion: __mod_init_func and __mod_term_func.
2363
ed6b3510
JW
2364 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
2365 when building with Clang.
2366
8edd4a2b
SM
23672012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
2368
2369 * eval.c (Fapply): Allow calling it with a single argument.
2370
f6f62d1b
EZ
23712012-06-26 Eli Zaretskii <eliz@gnu.org>
2372
2373 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
2374 _stricmp and _strnicmp.
2375 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
2376
62efea5e
DA
23772012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2378
2379 * alloc.c (allocate_window): Zero out non-Lisp part of newly
2380 allocated window.
2381 (allocate_process): Likewise for new process.
8edd4a2b 2382 (allocate_terminal): Change to use offsetof.
62efea5e
DA
2383 (allocate_frame): Likewise.
2384 * frame.c (make_frame): Omit redundant initialization.
2385 * window.c (make_parent_window): Use memset.
2386 (make_window): Omit redundant initialization.
2387 * process.c (make_process): Omit redundant initialization.
2388 * terminal.c (create_terminal): Likewise.
2389
42997f4d
DA
23902012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2391
2392 * term.c (delete_tty): Remove redundant call to memset.
2393
1130ecfc
DA
23942012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2395
2396 * alloc.c: Remove build_string.
2397 * lisp.h: Define build_string as static inline. This provides
2398 a better opportunity to optimize away calls to strlen when the
2399 function is called with compile-time constant argument.
2400 * image.c (imagemagick_error): Convert to build_string.
2401 * w32proc.c (sys_spawnve): Likewise.
2402 * xterm.c (x_term_init): Likewise.
2403
cf38a720
PE
24042012-06-26 Paul Eggert <eggert@cs.ucla.edu>
2405
99027bdd
PE
2406 Use sprintf return value instead of invoking strlen on result.
2407 In the old days this wasn't portable, since some sprintf
2408 implementations returned char *. But they died out years ago and
2409 Emacs already assumes sprintf returns int.
2410 Similarly for float_to_string.
2411 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
2412 * ccl.c (ccl_driver):
2413 * character.c (string_escape_byte8):
2414 * data.c (Fnumber_to_string):
2415 * doprnt.c (doprnt):
2416 * print.c (print_object):
2417 * xdisp.c (message_dolog):
2418 * xfns.c (syms_of_xfns):
2419 Use sprintf or float_to_string result to avoid need to call strlen.
2420 * data.c (Fnumber_to_string):
2421 Use make_unibyte_string, since the string must be ASCII.
2422 * lisp.h, print.c (float_to_string): Now returns int length.
2423 * term.c (produce_glyphless_glyph):
2424 Use sprintf result rather than recomputing it.
2425
cf38a720
PE
2426 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
2427 * Makefile.in (ALL_CFLAGS):
2428 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
2429 * gmalloc.c, regex.c: Include <config.h> unconditionally.
2430
3511c784
DA
24312012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2432
0a08eb21 2433 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
2434 strcasecmp if available.
2435 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
2436
fb7da12e
AS
24372012-06-25 Andreas Schwab <schwab@linux-m68k.org>
2438
2439 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
2440 Avoid comma operator.
2441 * menu.c (push_submenu_start, push_submenu_end)
2442 (push_left_right_boundary, push_menu_pane): Likewise.
2443 * msdos.c (dos_rawgetc): Likewise.
2444
afa2ffd8
DA
24452012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2446
2447 * xfns.c (xic_create_fontsetname): Remove redundant calls
2448 to memset.
2449
b3b4476b
PE
24502012-06-25 Paul Eggert <eggert@cs.ucla.edu>
2451
4495ff38
PE
2452 * gtkutil.c (get_utf8_string): Remove redundant assignment.
2453 sprintf already null-terminates its output.
2454
b3b4476b
PE
2455 * xfns.c (x_window): Remove redundant cast.
2456
b00876c9
DA
24572012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2458
2459 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
2460 `const char *' to `char *' to avoid compiler warning.
2461
d188e26b
PE
24622012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2463
885d1d74
PE
2464 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
2465 instead of truncating it to 63 (admittedly a generous limit).
2466
d188e26b
PE
2467 * process.c: Fix spelling and caps in comments.
2468
e2f560b1
DN
24692012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
2470
e86db54b 2471 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
2472 * sysdep.c (setpgrp): Remove definition, not used in this file.
2473
7583a3a1
JB
24742012-06-24 Juanma Barranquero <lekktu@gmail.com>
2475
2476 * makefile.w32-in: Update dependencies.
2477
696056c2
EZ
24782012-06-24 Eli Zaretskii <eliz@gnu.org>
2479
2480 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
2481 (SYSTIME_H): Add nt/inc/sys/time.h.
2482
2483 * systime.h [WINDOWSNT]: Include sys/time.h.
2484
2485 * s/ms-w32.h (struct timespec): Definition moved from
2486 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
2487
845ca893
PE
24882012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2489
2490 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
2491 * buffer.h (buffer_slot_type_mismatch):
2492 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2493 * eval.c (unwind_to_catch):
2494 * image.c (my_png_error, my_error_exit):
2495 * keyboard.c (quit_throw_to_read_char, user_error)
2496 (Fexit_recursive_edit, Fabort_recursive_edit):
2497 * lisp.h (die, args_out_of_range, args_out_of_range_3)
2498 (wrong_type_argument, buffer_overflow, __executable_start)
2499 (memory_full, buffer_memory_full, string_overflow, Fthrow)
2500 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
2501 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
2502 (fatal):
2503 (child_setup) [!DOS_NT]:
2504 * lread.c (end_of_file_error, invalid_syntax):
2505 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2506 * puresize.h (pure_write_error):
2507 * search.c (matcher_overflow):
2508 * sound.c (sound_perror, alsa_sound_perror):
2509 * sysdep.c, syssignal.h (croak):
2510 * term.c (maybe_fatal, vfatal):
2511 * textprop.c (text_read_only):
2512 * undo.c (user_error):
2513 * unexmacosx.c (unexec_error):
2514 * xterm.c (x_ins_del_lines, x_delete_glyphs):
2515 Use _Noreturn rather than NO_RETURN.
2516 No need for separate decl merely because of _Noreturn.
2517 * sound.c (sound_warning, parse_sound):
2518 Remove unnecessary forward decls.
2519
f1dd8073
PE
25202012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2521
2522 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
2523 * lisp.h (WAIT_READING_MAX): New macro.
2524 * dispnew.c (Fsleep_for, sit_for):
2525 * keyboard.c (kbd_buffer_get_event):
2526 * process.c (Faccept_process_output):
2527 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
2528 This improves on the previous patch, which introduced a bug
2529 when time_t is unsigned and as wide as intmax_t.
2530 See <http://bugs.gnu.org/9000#51>.
2531
b82c1755
EZ
25322012-06-23 Eli Zaretskii <eliz@gnu.org>
2533
2534 * dispnew.c (sit_for, Fsleep_for):
2535 * keyboard.c (kbd_buffer_get_event):
2536 * process.c (Faccept_process_output): Avoid compiler warnings when
2537 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
2538
ca300656
JB
25392012-06-23 Juanma Barranquero <lekktu@gmail.com>
2540
049ec95b
JB
2541 * makefile.w32-in: Update dependencies.
2542
ca300656
JB
2543 * w32.c (ltime): Add return type and declare static.
2544 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
2545
db7b8d06
PE
25462012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2547
2548 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
2549 Privately reported by Herbert J. Skuhra.
2550 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
2551 All uses changed.
2552 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
2553 not make_lisp_timeval, when the argument is of type EMACS_TIME.
2554
0bd8297f
EZ
25552012-06-23 Eli Zaretskii <eliz@gnu.org>
2556
96512555
EZ
2557 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
2558 last argument of make_unibyte_string.
2559
0bd8297f
EZ
2560 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
2561 language ID in the event parameters.
2562
2563 * w32term.c (w32_read_socket): Put the new keyboard codepage into
2564 event.code, not the obscure "character set ID".
2565
63def6b6
CY
25662012-06-23 Chong Yidong <cyd@gnu.org>
2567
2568 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
2569
e8a02204
EZ
25702012-06-23 Eli Zaretskii <eliz@gnu.org>
2571
388cdec0
EZ
2572 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
2573 * w32.c (fdutimens): New function.
2574
2575 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
2576
2577 * s/ms-w32.h (pselect): Redirect to sys_select.
2578
2579 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
2580
e8a02204
EZ
2581 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
2582 in the logic of incrementing and decrementing the value of
2583 use_relocatable_buffers.
2584
d054f3fb
PE
25852012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2586
2587 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
2588 Privately reported by Herbert J. Skuhra.
2589 [__FreeBSD__]: Remove "*/" typo after "#include".
2590 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
2591 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
2592 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
2593 Don't assume EMACS_TIME and struct timeval are the same type.
2594
d35af63c
PE
25952012-06-22 Paul Eggert <eggert@cs.ucla.edu>
2596
2597 Support higher-resolution time stamps (Bug#9000).
2598 The time stamps are only nanosecond-resolution at the C level,
2599 since that's the best that any real-world system supports now.
2600 But they are picosecond-resolution at the Lisp level, as that's
2601 easy, and leaves room for future OS improvements.
2602
2603 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
2604 (LIBES): Use it.
2605
2606 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
2607 Don't get current time unless it's needed.
2608
2609 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
2610 now provides it if it's absent.
2611 (start_atimer): Port to higher-res time stamps.
2612 Check for time stamp overflow. Don't get current time more
2613 often than is needed.
2614
2615 * buffer.h (struct buffer): Buffer modtime now has high resolution.
2616 Include systime.h, not time.h.
2617 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
2618
2619 * dired.c: Include stat-time.h.
2620 (Ffile-attributes): File times now have higher resolution.
2621
2622 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
2623 (struct image): Timestamp now has higher resolution.
2624
2625 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
2626 has at least microseconds now. All uses removed.
2627 (update_frame, update_single_window, update_window, update_frame_1)
2628 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
2629
2630 * editfns.c (time_overflow): Now extern.
2631 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
2632 (float-time, Fformat_time_string, Fcurrent_time_string)
2633 (Fcurrent_time_zone): Accept and generate higher-resolution
2634 time stamps.
2635 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
2636 (decode_time_components, lisp_seconds_argument): New functions.
2637 (make_time): Now static.
2638 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
2639 Report an error if the time is invalid, rather than having the caller
2640 do that.
2641
2642 * fileio.c: Include <stat-time.h>
2643 (Fcopy_file): Copy higher-resolution time stamps.
2644 Prefer to set the time stamp via a file descriptor if that works.
2645 (Fset_file_times, Finsert_file_contents, Fwrite_region)
2646 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
2647 (Fvisited_file_modtime, Fset_visited_file_modtime):
2648 Support higher-resolution time stamps.
2649
2650 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
2651
2652 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
2653
2654 * image.c (prepare_image_for_display, clear_image_cache)
2655 (lookup_image): Port to higer-resolution time stamps.
2656
2657 * keyboard.c (start_polling, bind_polling_period):
2658 Check for time stamp overflow.
2659 (read_char, kbd_buffer_get_event, timer_start_idle)
2660 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
2661 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
2662 Port to higher-resolution time stamps. Do not assume time_t is signed.
2663 (decode_timer): New function. Timers are now vectors of length 9,
2664 not 8, to accommodate the picosecond component.
2665 (timer_check_2): Use it.
2666
2667 * nsterm.m (select_timeout, timeval_subtract): Remove.
2668 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
2669 as they're a bit more accurate and handle overflow better.
2670 (ns_select): Change prototype to be compatible with pselect.
2671 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
2672 * nsterm.h (ns_select): Adjust prototype.
2673
2674 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
2675 us-resolution time stamps.
2676 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
2677
2678 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
2679
2680 * lisp.h (time_overflow): New decl.
2681 (wait_reading_process_output): First arg is now intmax_t, not int,
2682 to accommodate larger waits.
2683
2684 * process.h (struct Lisp_Process.read_output_delay):
2685 Now counts nanoseconds, not microseconds.
2686 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
2687 EMACS_HAS_USECS.
2688 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
2689 (wait_reading_process_output):
2690 Port to ns-resolution time stamps.
2691 (Faccept_process_output, wait_reading_process_output):
2692 Check for time stamp overflow. Do not assume time_t is signed.
2693 (select_wrapper): Remove; we now use pselect.
2694 (Fprocess_attributes): Now generates ns-resolution time stamps.
2695
2696 * sysdep.c: Include utimens.h. Don't include utime.h
2697 or worry about struct utimbuf; gnulib does that for us now.
2698 (gettimeofday): Remove; gnulib provides a substitute.
2699 (make_timeval): New function.
2700 (set_file_times): Now sets ns-resolution time stamps.
2701 New arg FD; all uses changed.
2702 (time_from_jiffies, ltime_from_jiffies, get_up_time)
2703 (system_process_attributes):
2704 Now returns ns-resolution time stamp. All uses changed.
2705 Check for time stamp overflow.
2706
2707 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
2708 provides a substitute now.
2709
2710 * systime.h: Include timespec.h rather than sys/time.h and time.h,
2711 since it guarantees struct timespec.
2712 (EMACS_TIME): Now struct timespec, so that we can support
2713 ns-resolution time stamps.
2714 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
2715 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
2716 (EMACS_USECS): Remove.
2717 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
2718 so multiply the arg by 1000 before storing it.
2719 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
2720 New macros.
2721 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
2722 Port to ns-resolution time stamps.
2723 (EMACS_TIME_NEG_P): Remove; replaced by....
2724 (EMACS_TIME_SIGN): New macro.
2725 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
2726 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
2727 (set_file_times, make_time, lisp_time_argument): Adjust signature.
2728 (make_timeval, make_lisp_time, decode_time_components): New decls.
2729 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
2730 that it mishandled time_t overflow. You can't compare by subtracting!
2731 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
2732 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
2733
2734 * term.c: Include <sys/time.h>.
2735 (timeval_to_Time): New function, for proper overflow wraparound.
2736 (term_mouse_position, term_mouse_click): Use it.
2737
2738 * undo.c (record_first_change): Support higher-resolution time stamps
2739 in the undo buffer.
2740 (Fprimitive_undo): Use them when restoring time stamps.
2741
2742 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
2743 (w32_get_internal_run_time):
2744 Port to higher-resolution Emacs time stamps.
2745 (ltime): Now accepts single 64-bit integer, as that's more convenient
2746 for callers.
2747
2748 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
2749
2750 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
2751 for compatibility with pselect. Support ns-resolution time stamps.
2752
2753 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
2754
2755 * xselect.c (wait_for_property_change, x_get_foreign_selection):
2756 Check for time stamp overflow, and support ns-resolution time stamps.
2757
2758 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
2759 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
2760 (timeval_subtract): Remove; no longer needed.
2761 (XTflash, XTring_bell, x_wait_for_event):
2762 Port to ns-resolution time stamps. Don't assume time_t is signed.
2763
b6a92dfe
CY
27642012-06-22 Chong Yidong <cyd@gnu.org>
2765
2766 * xdisp.c (x_consider_frame_title): Revert last change.
2767
d251c37c
EZ
27682012-06-22 Eli Zaretskii <eliz@gnu.org>
2769
2770 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
2771 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
2772 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
2773 staticidx goes up to 1597 out of 1600 = 0x640.)
2774
f10deafb
PE
27752012-06-20 Paul Eggert <eggert@cs.ucla.edu>
2776
2777 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
2778 Otherwise, the umask might be mistakenly 0 while handling input signals.
2779
ec6de1e2
SM
27802012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
2781
2782 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
2783
28be1ada
DA
27842012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
2785
2786 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
2787 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
2788 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
2789 access to `contents' member of Lisp_Vector objects with AREF and ASET
2790 where appropriate.
2791
c6bf3022
CY
27922012-06-19 Chong Yidong <cyd@gnu.org>
2793
2794 * frame.c (delete_frame): When selecting a frame on a different
2795 text terminal, do not alter the terminal's top-frame.
2796
2797 * xdisp.c (format_mode_line_unwind_data): Record the target
2798 frame's selected window and its terminal's top-frame.
2799 (unwind_format_mode_line): Restore them.
2800 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
2801 Callers changed.
2802 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
2803 since tty frames can be explicitly named.
2804 (prepare_menu_bars): Likewise.
2805
2806 * term.c (Ftty_top_frame): New function.
2807
defd4196
PE
28082012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2809
2810 Port byte-code-meter to modern targets.
2811 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
2812 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 2813 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
2814 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
2815 (METER_1, METER_2): Simplify.
2816
1053a871
SM
28172012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
2818
2819 * data.c (Fdefalias): Return `symbol' (bug#11686).
2820
b7e8d081
MR
28212012-06-18 Martin Rudalics <rudalics@gmx.at>
2822
2823 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
2824 gets killed during executing of this function (Bug#11665).
2825 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
2826 (Vkill_buffer_query_functions): In doc-string say that functions
2827 run by this hook should not change the current buffer.
2828
7ea2b339
PE
28292012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2830
2831 Fix recently-introduced process.c problems found by static checking.
2832 * process.c (write_queue_push, write_queue_pop, send_process):
2833 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
2834 (write_queue_pop): Fix pointer signedness problem.
2835 (send_process): Remove unused local.
2836
96a313a1
CY
28372012-06-17 Chong Yidong <cyd@gnu.org>
2838
2839 * xdisp.c (redisplay_internal): No need to redisplay terminal
2840 frames that are not on top.
2841
20ca2e94
TN
28422012-06-17 Troels Nielsen <bn.troels@gmail.com>
2843
2844 * process.c (make_process): Initialize write_queue.
2845 (write_queue_push, write_queue_pop): New functions.
2846 (send_process): Use them to maintain correct ordering of process
2847 writes (Bug#10815).
2848
9a900ca9
PE
28492012-06-17 Paul Eggert <eggert@cs.ucla.edu>
2850
310fbfa8
PE
2851 * lisp.h (eassert): Assume C89 or later.
2852 This removes the need for CHECK.
2853 (CHECK): Remove. Its comments about always evaluating its
2854 argument were confusing, as 'eassert' typically does not evaluate
2855 its argument.
2856
27bb1ca4
PE
2857 * coding.c (produce_chars): Use ptrdiff_t, not int.
2858
9a900ca9
PE
2859 * xterm.c (x_draw_underwave): Check for integer overflow.
2860 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
2861
41b7f8bc 28622012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
2863
2864 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
2865 referenced (Bug#11583).
2866
9b0e3eba
AA
28672012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
2868
2869 Implement wave-style variant of underlining.
2870 * dispextern.h (face_underline_type): New enum.
2871 (face): Add field for underline type.
2872 * nsterm.m (ns_draw_underwave): New function.
2873 (ns_draw_text_decoration): Use it.
2874 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
2875 New functions.
2876 (x_draw_glyph_string): Use them.
2877 * xfaces.c (Qline, Qwave): New Lisp objects.
2878 (check_lface_attrs, merge_face_ref)
1053a871
SM
2879 (Finternal_set_lisp_face_attribute, realize_x_face):
2880 Handle wave-style underline face attributes.
9b0e3eba
AA
2881 * xterm.c (x_draw_underwave): New function.
2882 (x_draw_glyph_string): Use it.
2883
0fb52f11
JB
28842012-06-16 Juanma Barranquero <lekktu@gmail.com>
2885
2886 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
2887 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
2888 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
2889 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
2890 ($(BLD)/w32select.$(O)): Update dependencies.
2891
e5560ff7
AS
28922012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2893
2894 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
2895 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
2896 * character.c (_fetch_multibyte_char_p): Remove.
2897 * alloc.c: Include "character.h" before "buffer.h".
2898 * bidi.c: Likewise.
2899 * buffer.c: Likewise.
2900 * bytecode.c: Likewise.
2901 * callint.c: Likewise.
2902 * callproc.c: Likewise.
2903 * casefiddle.c: Likewise.
2904 * casetab.c: Likewise.
2905 * category.c: Likewise.
2906 * cmds.c: Likewise.
2907 * coding.c: Likewise.
2908 * composite.c: Likewise.
2909 * dired.c: Likewise.
2910 * dispnew.c: Likewise.
2911 * doc.c: Likewise.
2912 * dosfns.c: Likewise.
2913 * editfns.c: Likewise.
2914 * emacs.c: Likewise.
2915 * fileio.c: Likewise.
2916 * filelock.c: Likewise.
2917 * font.c: Likewise.
2918 * fontset.c: Likewise.
2919 * fringe.c: Likewise.
2920 * indent.c: Likewise.
2921 * insdel.c: Likewise.
2922 * intervals.c: Likewise.
2923 * keyboard.c: Likewise.
2924 * keymap.c: Likewise.
2925 * lread.c: Likewise.
2926 * macros.c: Likewise.
2927 * marker.c: Likewise.
2928 * minibuf.c: Likewise.
2929 * nsfns.m: Likewise.
2930 * nsmenu.m: Likewise.
2931 * print.c: Likewise.
2932 * process.c: Likewise.
2933 * regex.c: Likewise.
2934 * region-cache.c: Likewise.
2935 * search.c: Likewise.
2936 * syntax.c: Likewise.
2937 * term.c: Likewise.
2938 * textprop.c: Likewise.
2939 * undo.c: Likewise.
2940 * unexsol.c: Likewise.
2941 * w16select.c: Likewise.
2942 * w32fns.c: Likewise.
2943 * w32menu.c: Likewise.
2944 * window.c: Likewise.
2945 * xdisp.c: Likewise.
2946 * xfns.c: Likewise.
2947 * xmenu.c: Likewise.
2948 * xml.c: Likewise.
2949 * xselect.c: Likewise.
2950
2f07e6af
EZ
29512012-06-16 Eli Zaretskii <eliz@gnu.org>
2952
1053a871
SM
2953 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
2954 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 2955 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
2956 row.
2957 (handle_face_prop): Use chunk-relative overlay string index when
2958 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
2959 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
2960 the rightmost. (Bug#11720)
2f07e6af 2961
29b83cec
AS
29622012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2963
2964 * category.h (CHAR_HAS_CATEGORY): Define as inline.
2965 (CATEGORY_MEMBER): Enforce 1/0 value.
2966 * category.c (_temp_category_set): Remove.
2967
4c5501e9
EZ
29682012-06-16 Eli Zaretskii <eliz@gnu.org>
2969
2970 * window.c (Fdelete_other_windows_internal)
2971 (Fdelete_window_internal): Don't access frame's mouse highlight
2972 info of the initial frame. (Bug#11677)
2973
2b570124
PE
29742012-06-14 Paul Eggert <eggert@cs.ucla.edu>
2975
e93864f9
PE
2976 * .gdbinit (xgetint): Fix recently-introduced paren typo.
2977 Assume USE_2_TAGS_FOR_INTS.
2978 (xreload): Adjust $tagmask width to match recent lisp.h change.
2979
2b570124
PE
2980 Simplify lisp.h in minor ways that should not affect code.
2981 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
2982 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
2983 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
2984 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
2985 (INTTYPEBITS): New macro, for clarity.
2986 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
2987 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
2988 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
2989 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
2990 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
2991
81755f69
JB
29922012-06-13 Juanma Barranquero <lekktu@gmail.com>
2993
2994 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
2995
16192a57
GM
29962012-06-13 Glenn Morris <rgm@gnu.org>
2997
2998 * s/bsd-common.h (BSD4_3):
2999 * s/usg5-4-common.h (USG5_4): No longer define; unused.
3000
646b5f55
AS
30012012-06-13 Andreas Schwab <schwab@linux-m68k.org>
3002
3003 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
3004 instead of union.
3005 (XLI, XIL): Define.
1053a871
SM
3006 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
3007 Use them.
3008 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 3009 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 3010 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
3011 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
3012 * frame.c (delete_frame): Remove outdated comment.
3013 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
3014 USE_LISP_UNION_TYPE.
3015 (Fw32_unregister_hot_key): Likewise.
3016 (Fw32_toggle_lock_key): Likewise.
3017 * w32menu.c (add_menu_item): Likewise.
3018 (w32_menu_display_help): Use XIL instead of checking
3019 USE_LISP_UNION_TYPE.
3020 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
3021 (init_heap): Likewise.
3022 * w32term.c (w32_read_socket): Update comment.
3023
1d3823c9
GM
30242012-06-13 Glenn Morris <rgm@gnu.org>
3025
c62ff706
GM
3026 * s/usg5-4-common.h, src/s/unixware.h:
3027 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
3028
1d3823c9
GM
3029 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
3030
bfe3e0a2
PE
30312012-06-13 Paul Eggert <eggert@cs.ucla.edu>
3032
3033 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
3034 * alloc.c (make_number) [!defined make_number]:
3035 Remove, as lisp.h always defines this now.
3036 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
3037 (roundup_size): Verify that it is a power of 2.
3038 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
3039 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
3040 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
3041 -DUSE_LSB_TAG=0, to override the automatically-selected default.
3042 USE_LSB_TAG now is always defined to be either 0 or 1.
3043 All uses changed.
3044 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
3045 code works fine either way, and efficiency is not a concern here,
3046 as the union type is for debugging, not for production.
3047 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
3048 Use an inline function on all platforms when using the union type,
3049 since this is simpler and 'static inline' can be used portably
3050 within Emacs now.
3051 (LISP_INITIALLY_ZERO): New macro.
3052 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
3053 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
3054
45fa9c0f
GM
30552012-06-12 Glenn Morris <rgm@gnu.org>
3056
b4492cba
GM
3057 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
3058
3059 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 3060
45fa9c0f
GM
3061 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
3062 Move BROKEN_SIGIO to configure.
3063
3064 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
3065 Move NO_TERMIO to configure.
3066
0e25d334
CY
30672012-06-12 Chong Yidong <cyd@gnu.org>
3068
3069 * image.c (imagemagick_load_image): Use MagickFlattenImage if
3070 MagickMergeImageLayers is undefined. Use pixel pusher loop if
3071 MagickExportImagePixels is undefined.
3072
43682bb6
PE
30732012-06-12 Paul Eggert <eggert@cs.ucla.edu>
3074
3075 * image.c (imagemagick_load_image): Remove unused label.
3076
a9be7d2b
GM
30772012-06-11 Glenn Morris <rgm@gnu.org>
3078
3079 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
3080 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
3081 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
3082 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
3083
3017f87f
SM
30842012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
3085
3086 * alloc.c (make_byte_code): New function.
3087 (Fmake_byte_code): Use it. Don't purify here.
3088 * lread.c (read1): Use it as well to avoid extra allocation.
3089
1b9b4cf4
CY
30902012-06-11 Chong Yidong <cyd@gnu.org>
3091
3092 * image.c (imagemagick_load_image): Implement transparency.
3093
95988fcf
AS
30942012-06-10 Andreas Schwab <schwab@linux-m68k.org>
3095
3096 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
3097 account for preceding backslashes. (Bug#11663)
3098
cd4eb164
CY
30992012-06-09 Chong Yidong <cyd@gnu.org>
3100
3101 * term.c: Support italics in capable terminals (Bug#9652).
3102 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
3103 (turn_on_face): Output using TS_enter_italic_mode if available.
3104 Don't handle unused blinking and alt-charset cases.
3105 (turn_off_face): Handle italic case; discard unused tty_blinking_p
3106 and tty_alt_charset_p cases.
3107 (tty_capable_p, init_tty): Support italics.
3108
3109 * termchar.h (struct tty_display_info): Add field for italics.
3110 Remove unused blink field.
3111
3112 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
3113 Handle slant.
3114
3115 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
3116 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
3117 tty_alt_charset_p. Add tty_italic_p.
3118
ff88beb8
MA
31192012-06-09 Michael Albinus <michael.albinus@gmx.de>
3120
3121 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
3122 dbus_type_is_basic if available.
3123 (xd_extract_signed, xd_extract_unsigned): Rename from
3124 extract_signed and extract_unsigned, respectively. Adapt callers.
3125
44286096
CY
31262012-06-09 Chong Yidong <cyd@gnu.org>
3127
1682701f
CY
3128 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
3129
44286096
CY
3130 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
3131 case (Bug#9752).
3132
d86feb17
PE
31332012-06-08 Paul Eggert <eggert@cs.ucla.edu>
3134
3135 * xdisp.c (vmessage): Treat frame message as multibyte.
3136 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
3137 would generate the diagnostic "Making \302\247 buffer-local while
3138 let-bound!".
3139
d5c20fe8
EZ
31402012-06-08 Eli Zaretskii <eliz@gnu.org>
3141
3142 * dispnew.c (showing_window_margins_p): Undo last change, which
3143 was done due to an inadvertent commit.
3144 (adjust_frame_glyphs_for_frame_redisplay): Do call
3145 showing_window_margins_p.
3146
513749ee
SM
31472012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3148
3149 * eval.c (Fmake_var_non_special): New primitive.
3150 (syms_of_eval): Defsubr it.
3151 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
3152
d4a8f5c1
JB
31532012-06-08 Juanma Barranquero <lekktu@gmail.com>
3154
3155 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
3156 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
3157
8bbbc977
EZ
31582012-06-08 Eli Zaretskii <eliz@gnu.org>
3159
3160 * alloc.c (allocate_vectorlike): Fix last change.
3161
f3372c87
DA
31622012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
3163
3164 Block-based vector allocation of small vectors.
3165 * lisp.h (struct vectorlike_header): New field `nbytes',
3166 adjust comment accordingly.
3167 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
3168 to denote vector blocks. Adjust users (live_vector_p,
3169 mark_maybe_pointer, valid_lisp_object_p) accordingly.
3170 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
3171 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
3172 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
3173 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
3174 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
3175 (roundup_size): New constant.
3176 (struct vector_block): New data type.
3177 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 3178 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
3179 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
3180 (sweep_vectors): New functions.
3181 (allocate_vectorlike): Return `zero_vector' as the only vector of
3182 0 items. Allocate new vector from block if vector size is less than
3183 or equal to VBLOCK_BYTES_MAX.
3184 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
3185 (init_alloc_once): Add call to init_vectors.
3186
4f18a4ed
SM
31872012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3188
3189 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
3190
86f158bc
PE
31912012-06-07 Paul Eggert <eggert@cs.ucla.edu>
3192
3193 * doprnt.c (doprnt): Truncate multibyte char correctly.
3194 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
3195 would mishandle a string argument "Xc" if X was a multibyte
3196 character of length 2: it would truncate after X's first byte
3197 rather than including all of X.
3198
c5cfcbe0
CY
31992012-06-06 Chong Yidong <cyd@gnu.org>
3200
3201 * buffer.c (word_wrap): Doc fix.
3202
c05cf390
PE
32032012-06-04 Paul Eggert <eggert@cs.ucla.edu>
3204
3205 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
3206
0c3461de
GM
32072012-06-03 Glenn Morris <rgm@gnu.org>
3208
3209 * xdisp.c (tool-bar-style): Doc fix.
3210
c71232db
UM
32112012-06-03 Ulrich Müller <ulm@gentoo.org>
3212
3213 * Makefile.in (PAXCTL): Define.
3214 (temacs$(EXEEXT)): Disable memory randomization for the temacs
3215 binary via PaX flags if the paxctl utility is available.
3216 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
3217 Restore PaX flags to their default. (Bug#11398)
3218
383f7350
CY
32192012-06-03 Chong Yidong <cyd@gnu.org>
3220
3221 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
3222 buffer (Bug#11226).
3223
5f2c76c6
CY
32242012-06-03 Chong Yidong <cyd@gnu.org>
3225
3226 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
3227 (note_mode_line_or_margin_highlight): If there is no help echo,
3228 use mode-line-default-help-echo. Handle the case where the mouse
3229 position is past the end of the mode line string.
3230
3231 * buffer.c (buffer_local_value_1): New function, split from
3232 Fbuffer_local_value; can return Qunbound.
3233 (Fbuffer_local_value): Use it.
3234 (Vmode_line_format): Docstring tweaks.
3235
773d47f6
PE
32362012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3237
3238 * sysdep.c (system_process_attributes): Improve comment.
3239
f2d6a3df
SM
32402012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
3241
3242 * keyboard.c: Export real-this-command to Elisp.
3243 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
3244 and DEFVAR it. Update all users.
3245
63810350
PE
32462012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3247
7bd5c1f4
PE
3248 * minibuf.c (Fassoc_string): Remove duplicate declaration.
3249
63810350
PE
3250 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
3251 Convert pctcpu and pctmem to Lisp float properly.
3252 Let the compiler fold better, as 100.0/0x8000 is exact.
3253
a2821611
AS
32542012-06-02 Andreas Schwab <schwab@linux-m68k.org>
3255
3256 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
3257 cons_block.
3258
5fceba1d
PE
32592012-06-01 Paul Eggert <eggert@cs.ucla.edu>
3260
3261 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
3262
c98ff5dd
DA
32632012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
3264
3265 For a 'struct window', replace some Lisp_Object fields to
3266 bitfields where appropriate, remove unused fields.
3267 * window.h (struct window): Remove unused 'last_mark_x' and
3268 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
3269 change it's type from Lisp_Object to bitfield.
3270 Change type of 'force_start', 'optional_new_start',
3271 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
3272 fields from Lisp_Object to bitfield. Adjust users accordingly.
3273
ca34e0be
PE
32742012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3275
3276 Pacify gcc -Wdouble-precision when using Xaw.
3277 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
3278 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
3279 Use 'float' consistently, rather than 'float' in most places
3280 and 'double' in a couple of places.
3281
efc00ab1 32822012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
3283
3284 * xdisp.c (handle_stop): Detect whether we have overlay strings
3285 loaded by testing it->current.overlay_string_index to be
3286 non-negative, instead of checking whether n_overlay_strings is
3287 positive. (Bug#11587)
3288
efc00ab1 32892012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
3290
3291 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
3292
3293 * doc.c (Fsubstitute_command_keys): Doc fix.
3294
efc00ab1 32952012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
3296
3297 * search.c (search_buffer): Remove calls to
3298 r_alloc_inhibit_buffer_relocation, as it is now called by
3299 maybe_unify_char, which was the cause of relocation of buffer text
3300 in bug#11519.
3301
efc00ab1 33022012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
3303
3304 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
3305 for the duration of call to load_charset, to avoid problems with
3306 callers of maybe_unify_char that access buffer text through C
3307 pointers.
3308
3309 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
3310 decrement the inhibition flag, instead of just setting or
3311 resetting it.
3312
ba93a187
PE
33132012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3314
3315 Remove obsolete '#define static' cruft.
3316 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
3317 This #undef was "temporary" in 2000; it is no longer needed
3318 now that '#define static' has gone away.
3319 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
3320 (gray_bitmap_bits): Remove; no longer needed.
3321 All uses replaced with definiens.
3322 * xterm.c: Include "bitmaps/gray.xbm".
3323
9e4bf381
PE
33242012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3325
3326 Clean up __executable_start, monstartup when --enable-profiling.
3327 The following changes affect the code only when profiling.
3328 * dispnew.c (__executable_start): Rename from safe_bcopy.
3329 Define only on platforms that need it.
3330 * emacs.c: Include <sys/gmon.h> when profiling.
3331 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
3332 (__executable_start): Remove decl, since lisp.h does it now.
3333 (safe_bcopy): Remove decl; no longer has that name.
3334 (main): Coalesce #if into single bit of code, for simplicity.
3335 Cast pointers to uintptr_t, since standard libraries want integers
3336 and not pointers.
3337 * lisp.h (__executable_start): New decl.
3338
32d72c2f
GM
33392012-05-31 Glenn Morris <rgm@gnu.org>
3340
3341 * image.c (Fimagemagick_types): Doc fix.
3342
baac5bc7
JM
33432012-05-30 Jim Meyering <meyering@redhat.com>
3344
3345 * callproc.c (Fcall_process_region): Include directory component
3346 in mkstemp error message (Bug#11586).
3347
72cb32cf
PE
33482012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3349
3350 * alloc.c, lisp.h (make_pure_vector): Now static.
3351
61b108cc
SM
33522012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
3353
3354 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
3355 Move to byte-run.el.
3356 (Fautoload): Do the hash-doc more carefully.
3357 * data.c (Fdefalias): Purify definition, except for keymaps.
3358 (Qdefun): Move from eval.c.
3359 * lisp.h (Qdefun): Remove.
3360 * lread.c (read1): Tiny simplification.
3361
471fe23d
TN
33622012-05-29 Troels Nielsen <bn.troels@gmail.com>
3363
934f3f58 3364 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
3365 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
3366 Bug#9642, but explicitly check that the buffer the overlay would
3367 be moved to is live and rearrange lines to make sure that errors
3368 will not put the overlay in an inconsistent state.
3369 (Fdelete_overlay): Cosmetics.
3370
85d0efd1
EZ
33712012-05-28 Eli Zaretskii <eliz@gnu.org>
3372
3373 * w32term.c (my_bring_window_to_top): New function.
3374 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
3375 could be different from the original one.
3376 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
3377 (Bug#11513)
3378
3379 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
3380 by calling BringWindowToTop.
3381
3382 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
3383 (WM_EMACS_END): Increase by one.
3384
da92a98c
PE
33852012-05-28 Paul Eggert <eggert@cs.ucla.edu>
3386
3387 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
3388 This avoids undefined behavior that might cause the eassert
3389 to not catch an out-of-range value.
3390
74d1f848
JB
33912012-05-28 Juanma Barranquero <lekktu@gmail.com>
3392
3393 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
3394 Update dependencies.
3395
9e1a06fc
EZ
33962012-05-27 Eli Zaretskii <eliz@gnu.org>
3397
3398 * bidi.c (bidi_mirror_char): Fix last change.
3399
f3dd7312
AS
34002012-05-27 Andreas Schwab <schwab@linux-m68k.org>
3401
3402 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
3403 when referring to sectname field in printf format.
3404
81899c91
PE
34052012-05-27 Paul Eggert <eggert@cs.ucla.edu>
3406
57b81a9f
PE
3407 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
3408 Only r_alloc_inhibit_buffer_relocation needed to be added;
3409 the others were already declared.
3410
81899c91
PE
3411 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
3412 before checking whether it's out of range. Put the check inside
3413 eassert. See
3414 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
3415
33017faf 34162012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
3417
3418 * callproc.c (Fcall_process): Restore a line that was accidentally
3419 commented out in the 2011-02-13 change (bug#11547).
3420
33017faf 34212012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
3422
3423 * lisp.h [REL_ALLOC]: Add prototypes for external functions
3424 defined on ralloc.c.
3425
3426 * buffer.c [REL_ALLOC]: Remove prototypes of
3427 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
3428 they are now on lisp.h.
3429
3430 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
3431
3432 * search.c (search_buffer): Use it to inhibit relocation of buffer
3433 text while re_search_2 is doing its job, because re_search_2 is
3434 passed C pointers to buffer text. (Bug#11519)
3435
23415acf
EZ
3436 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
3437 Update value to 24.
3438
44e27368
EZ
3439 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
3440 state after an additional call to move_it_in_display_line_to, keep
3441 the values of it->max_ascent and it->max_descent found for the
3442 entire line.
3443 (pos_visible_p): Revert the comparison against bottom_y to what it
3444 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
3445 (Bug#11464)
3446
c1892f11
PE
34472012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3448
3449 Fix coding-related core dumps with gcc -ftrapv.
3450 The code was computing A - B, where A and B are pointers, and B is
3451 random garbage. This can lead to core dumps on platforms that
3452 have special pointer registers, and it also leads to core dumps on
3453 x86-64 when compiled with gcc -ftrapv. The fix is to compute
3454 A - B only when B is initialized properly.
3455 * coding.c (coding_set_source, coding_set_destination): Return void.
3456 (coding_change_source, coding_change_destinations): New functions,
3457 with the old behaviors of coding_set_source and coding_set_destination.
3458 All callers that need an offset changed to use these new functions.
3459
eb7afdad
GM
34602012-05-26 Glenn Morris <rgm@gnu.org>
3461
3462 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
3463
f12fdf02
EZ
34642012-05-26 Eli Zaretskii <eliz@gnu.org>
3465
53a63be6 3466 Extend mouse support on W32 text-mode console.
61b108cc
SM
3467 * xdisp.c (draw_row_with_mouse_face):
3468 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 3469
eb3f6f01 3470 * w32console.c: Include window.h.
61b108cc
SM
3471 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
3472 New functions.
eb3f6f01
EZ
3473 (initialize_w32_display): Initialize mouse-highlight data.
3474
53a63be6
EZ
3475 * w32inevt.c: Include termchar.h and window.h.
3476 (do_mouse_event): Support mouse-autoselect-window. When the mouse
3477 moves, call note_mouse_highlight. If help_echo changed, call
3478 gen_help_event to produce help-echo message in the echo area.
3479 Call clear_mouse_face if mouse_face_hidden is set in the mouse
3480 highlight info.
3481
4cfd81f6
PE
34822012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3483
3484 * lread.c (read1): Simplify slightly to avoid an overflow warning
3485 with GCC 4.7.0 on x86-64.
3486
4446092a
EZ
34872012-05-26 Eli Zaretskii <eliz@gnu.org>
3488
3489 * bidi.c (bidi_mirror_char): Revert last change: an int is
3490 definitely wide enough here.
3491
42b2a986 34922012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 3493
42b2a986 3494 Fix integer width and related bugs (Bug#9874).
eb106a49 3495 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
3496 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
3497 (string_bytes, check_sblock, allocate_string_data):
3498 (compact_small_strings, Fmake_bool_vector, make_string)
3499 (make_unibyte_string, make_multibyte_string)
3500 (make_string_from_bytes, make_specified_string)
3501 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
3502 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
3503 (mark_vectorlike):
3504 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3505 (allocate_pseudovector):
3506 Use int, not EMACS_INT, where int is wide enough.
3507 (inhibit_garbage_collection, Fgarbage_collect):
3508 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3509 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
3510 int might not be wide enough.
3511 (bidi_cache_search, bidi_cache_find, bidi_init_it)
3512 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
3513 (bidi_at_paragraph_end, bidi_find_paragraph_start)
3514 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3515 (bidi_level_of_next_char, bidi_move_to_visually_next):
3516 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3517 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
3518 (Fkill_buffer, Fset_buffer_major_mode)
3519 (advance_to_char_boundary, Fbuffer_swap_text)
3520 (Fset_buffer_multibyte, overlays_at, overlays_in)
3521 (overlay_touches_p, struct sortvec, record_overlay_string)
3522 (overlay_strings, recenter_overlay_lists)
3523 (adjust_overlays_for_insert, adjust_overlays_for_delete)
3524 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
3525 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
3526 (Foverlay_recenter, last_overlay_modification_hooks_used)
3527 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
3528 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
3529 (validate_region): Omit unnecessary test for b <= e,
3530 since that's guaranteed by the previous test.
d311d28c
PE
3531 (adjust_overlays_for_delete): Avoid pos + length overflow.
3532 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
3533 (report_overlay_modification):
3534 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3535 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
3536 Omit pointer cast, which isn't needed anyway, and doesn't work
3537 after the EMACS_INT -> ptrdiff_t change.
02481186 3538 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
3539 * buffer.h: Adjust decls to match defn changes elsewhere.
3540 (struct buffer_text, struct buffer):
3541 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3542 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
3543 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
3544 not int, to avoid needless 32-bit limit on 64-bit hosts.
3545 (exec_byte_code): Use tighter memory-full test, one that checks
3546 for alloca overflow. Don't compute the address of the object just
3547 before an array, as that's not portable. Use EMACS_INT, not
3548 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
3549 * callint.c (Fcall_interactively):
3550 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3551 * callproc.c (call_process_kill, Fcall_process):
3552 Don't assume pid_t fits into an Emacs fixnum.
3553 (call_process_cleanup, Fcall_process, child_setup):
3554 Don't assume pid_t fits into int.
3555 (call_process_cleanup, Fcall_process, delete_temp_file)
3556 (Fcall_process_region):
3557 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3558 (Fcall_process): Simplify handling of volatile integers.
3559 Use int, not EMACS_INT, where int will do.
3560 * casefiddle.c (casify_object, casify_region, operate_on_word)
3561 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
3562 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3563 (casify_object): Avoid integer overflow when overallocating buffer.
3564 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 3565 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
3566 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
3567 * category.h (CATEGORYP): Don't assume arg is nonnegative.
3568 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
3569 integers are now checked earlier. All uses replaced with XINT.
3570 (ccl_driver):
3571 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3572 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
3573 (ccl_driver, Fregister_code_conversion_map):
3574 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
3575 (resolve_symbol_ccl_program): Check that vector header is in range.
3576 Always copy the vector, so that we can check its contents reliably
3577 now rather than having to recheck each instruction as it's being
3578 executed. Check that vector words fit in 'int'.
3579 (ccl_get_compiled_code, Fregister_ccl_program)
3580 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
3581 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
3582 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
3583 contents are in range.
3584 (Fccl_execute_on_string): Check that status is in range.
3585 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
3586 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
3587 Accept and return EMACS_INT, not int, because callers can pass values
3588 out of 'int' range.
3589 (c_string_width, strwidth, lisp_string_width, chars_in_text)
3590 (multibyte_chars_in_text, parse_str_as_multibyte)
3591 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
3592 (str_as_unibyte, str_to_unibyte, string_count_byte8)
3593 (string_escape_byte8, Fget_byte):
3594 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 3595 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
3596 avoid mishandling large integers.
3597 * character.h: Adjust decls to match defn changes elsewhere.
3598 * charset.c (load_charset_map_from_file, find_charsets_in_text)
3599 (Ffind_charset_region):
3600 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3601 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
3602 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 3603 Don't assume fixnum fits in int.
d311d28c
PE
3604 (load_charset_map_from_vector, Fmap_charset_chars):
3605 Remove now-unnecessary CHECK_NATNUMs.
3606 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
3607 Don't rely on undefined behavior with signed left shift overflow.
3608 Don't assume unsigned int fits into fixnum, or that fixnum fits
3609 into unsigned int. Don't require max_code to be a valid fixnum;
3610 that's not true for gb10830 4-byte on a 32-bit host. Allow
3611 invalid_code to be a cons, for the same reason. Require code_offset
3612 to be a character. Avoid int overflow if max_char is close
3613 to INT_MAX.
3614 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
3615 this is intended anyway and avoids some undefined behavior.
3616 (load_charset_map): Pass unsigned, not int, as 2nd arg of
3617 INDEX_TO_CODE_POINT, as that's what it expects.
3618 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
3619 * charset.h (DECODE_CHAR): Return int, not unsigned;
3620 this is what was intended anyway, and it avoids undefined behavior.
3621 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
3622 integer-overflow issues.
3623 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
3624 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
3625 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
3626 * chartab.c (Fmake_char_table, Fset_char_table_range)
3627 (uniprop_get_decoder, uniprop_get_encoder):
3628 Don't assume fixnum fits in int.
3629 * cmds.c (move_point): New function, that does the gist of
3630 Fforward_char and Fbackward_char, but does so while checking
3631 for integer overflow more accurately.
c96e5d6a 3632 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
3633 (Fforward_line, Fend_of_line, internal_self_insert)
3634 (internal_self_insert):
3635 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3636 Fix a FIXME, by checking for integer overflow when calculating
3637 target_clm and actual_clm.
3638 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 3639 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
3640 (ASSURE_DESTINATION, coding_alloc_by_realloc)
3641 (coding_alloc_by_making_gap, alloc_destination)
3642 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
3643 (encode_coding_utf_16, detect_coding_emacs_mule)
3644 (decode_coding_emacs_mule, encode_coding_emacs_mule)
3645 (detect_coding_iso_2022, decode_coding_iso_2022)
3646 (encode_invocation_designation, encode_designation_at_bol)
3647 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3648 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
3649 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
3650 (encode_coding_ccl, encode_coding_raw_text)
3651 (detect_coding_charset, decode_coding_charset)
3652 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
3653 (produce_composition, produce_charset, produce_annotation)
3654 (decode_coding, handle_composition_annotation)
3655 (handle_charset_annotation, consume_chars, decode_coding_gap)
3656 (decode_coding_object, encode_coding_object, detect_coding_system)
3657 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
3658 (code_convert_region, code_convert_string)
8f50130c
PE
3659 (Fdefine_coding_system_internal)
3660 (coding_set_source, coding_set_destination):
d311d28c
PE
3661 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3662 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
3663 (Fdefine_coding_system_internal):
3664 Don't assume fixnums fit in int.
3665 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 3666 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
3667 (Funencodable_char_position, Fcheck_coding_systems_region)
3668 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 3669 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 3670 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 3671 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 3672 Don't access memory outside of the args array.
d311d28c 3673 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
3674 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
3675 result of ENCODE_CHAR.
d311d28c
PE
3676 * coding.h: Adjust decls to match defn changes elsewhere.
3677 (struct coding_system):
3678 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3679 * composite.c (get_composition_id, find_composition)
3680 (run_composition_function, update_compositions)
3681 (compose_text, composition_gstring_put_cache)
3682 (composition_gstring_p, composition_gstring_width)
3683 (fill_gstring_header, fill_gstring_body, autocmp_chars)
3684 (composition_compute_stop_pos, composition_reseat_it)
3685 (composition_update_it, struct position_record)
3686 (find_automatic_composition, composition_adjust_point)
3687 (Fcomposition_get_gstring, Ffind_composition_internal):
3688 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3689 (update_compositions):
3690 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3691 * composite.h: Adjust decls to match defn changes elsewhere.
3692 (struct composition):
3693 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3694 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
3695 Do not attempt to compute the address of the object just before a
3696 buffer; this is not portable.
3697 (Faref, Faset):
3698 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3699 (Faset): Use int, not EMACS_INT, where int is wide enough.
3700 (Fstring_to_number): Don't assume fixnums fit in int.
3701 (Frem): Don't assume arg is nonnegative.
3702 * dbusbind.c (xd_append_arg): Check for integers out of range.
3703 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 3704 (extract_signed, extract_unsigned): New functions.
243e0530
PE
3705 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
3706 (xd_get_connection_references): Return ptrdiff_t, not int.
3707 All uses changed.
3708 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
3709 (xd_read_message_1):
3710 Use int, not unsigned, where the dbus API uses int.
3711 (Fdbus_message_internal): Don't overflow mtype.
3712 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
3713 * dired.c (directory_files_internal, file_name_completion, scmp)
3714 (file_name_completion_stat):
3715 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3716 (file_name_completion): Don't overflow matchcount.
3717 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
3718 * dispextern.h: Adjust decls to match defn changes elsewhere.
3719 (struct text_pos, struct glyph, struct bidi_saved_info)
3720 (struct bidi_string_data, struct bidi_it, struct composition_it)
3721 (struct it):
3722 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3723 (struct display_pos, struct composition_it, struct it):
3724 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3725 * dispnew.c (increment_matrix_positions)
3726 (increment_row_positions, mode_line_string)
3727 (marginal_area_string):
3728 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 3729 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
3730 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3731 (duration_to_sec_usec): New function, to check for overflow better.
3732 (Fsleep_for, sit_for): Use it.
3733 * doc.c (get_doc_string, store_function_docstring):
3734 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3735 (get_doc_string, Fsnarf_documentation):
3736 Use int, not EMACS_INT, where int is wide enough.
3737 (get_doc_string):
3738 Use SAFE_ALLOCA, not alloca.
3739 Check for overflow when converting EMACS_INT to off_t.
3740 * doprnt.c (doprnt):
3741 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3742 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
3743 Don't assume uid_t fits into fixnum.
3744 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
3745 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
3746 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
3747 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
3748 (general_insert_function)
3749 (Finsert_char, make_buffer_string, make_buffer_string_both)
3750 (update_buffer_properties, Fbuffer_substring)
3751 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
3752 (Fsubst_char_in_region, check_translation)
3753 (Ftranslate_region_internal, save_restriction_restore, Fformat)
3754 (transpose_markers, Ftranspose_regions):
3755 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3756 (clip_to_bounds): Move to lisp.h as an inline function).
3757 (Fconstrain_to_field): Don't assume integers are nonnegative.
3758 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
3759 (Fsubst_char_in_region, Fsave_restriction):
3760 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3761 (Femacs_pid): Don't assume pid_t fits into fixnum.
3762 (lo_time): Use int, not EMACS_INT, when int suffices.
3763 (lisp_time_argument): Check for usec out of range.
3764 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
3765 (Fuser_login_name, Fuser_full_name): Signal an error
3766 if a uid argument is out of range, rather than relying on
3767 undefined behavior.
c8d5c857
PE
3768 (Fformat_time_string): Remove now-unnecessary check.
3769 lisp_time_argument checks for out-of-range usec now.
243e0530 3770 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
3771 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
3772 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
3773 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
3774 (init_cmdargs, Fdump_emacs):
3775 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3776 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
3777 the bottom (typically) 32 bits of the fixnum.
3778 * eval.c (specpdl_size, call_debugger):
3779 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3780 (when_entered_debugger, Fbacktrace_debug):
3781 Don't assume fixnum can fit in int.
3782 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
3783 the object just before a buffer; this is not portable.
3784 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
3785 (grow_specpdl, unbind_to):
3786 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3787 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
3788 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 3789 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
3790 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
3791 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
3792 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3793 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
3794 (a_write, e_write):
3795 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3796 (Fcopy_file, non_regular_nbytes, read_non_regular)
3797 (Finsert_file_contents):
3798 Use int, not EMACS_INT, where int is wide enough.
3799 (READ_BUF_SIZE): Verify that it fits in int.
3800 (Finsert_file_contents): Check that counts are in proper range,
3801 rather than assuming fixnums fit into ptrdiff_t etc.
3802 Don't assume fixnums fit into int.
125b3835 3803 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
3804 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
3805 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
3806 (string_char_to_byte, string_byte_to_char)
3807 (string_make_multibyte, string_to_multibyte)
3808 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
3809 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
3810 (substring_both, Fdelete, internal_equal, Ffillarray)
3811 (Fclear_string, mapcar1)
3812 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
3813 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
3814 (larger_vector, make_hash_table, maybe_resize_hash_table)
3815 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
3816 (Fmaphash, secure_hash):
3817 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3818 (concat): Check for string index and length overflow.
3819 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
3820 (Frequire):
3821 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3822 (larger_vector): New API (vec, incr_min, size_max) replaces old
3823 one (vec, new_size, init). This catches size overflow.
3824 INIT was removed because it was always Qnil.
3825 All callers changed.
3826 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
3827 the upper bound on a hash table index size.
3828 (make_hash_table, maybe_resize_hash_table): Use it.
3829 (secure_hash): Computer start_byte and end_byte only after
3830 they're known to be in ptrdiff_t range.
3831 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
3832 (Ffont_get_glyphs, Ffont_at):
3833 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3834 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
3835 (Flist_fonts, Fopen_font):
3836 Don't assume fixnum can fit in int.
3837 (check_gstring): Don't assume index can fit in int.
3838 (font_match_p): Check that fixnum is a character, not a nonnegative
3839 fixnum, since the later code needs to stuff it into an int.
3840 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
3841 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
3842 conversion overflow issues.
3843 (Fopen_font): Check for integer out of range.
3844 (Ffont_get_glyphs): Don't assume index can fit in int.
3845 * font.h: Adjust decls to match defn changes elsewhere.
3846 * fontset.c (reorder_font_vector): Redo score calculation to avoid
3847 integer overflow.
3848 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
3849 printmax_t, where ptrdiff_t is wide enough.
3850 (Finternal_char_font):
3851 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3852 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
3853 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
3854 (Fset_frame_position, x_set_frame_parameters)
3855 (x_set_line_spacing, x_set_border_width)
3856 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
3857 Check that fixnums are in proper range for system types.
3858 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
3859 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3860 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
3861 Use SAFE_ALLOCA_LISP, not alloca.
3862 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
3863 intptr_t is wide enough.
3864 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
3865 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
3866 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
3867 Check for fixnum out of range.
3868 * ftfont.c (ftfont_list): Don't assume index fits in int.
3869 Check that fixnums are in proper range for system types.
3870 (ftfont_shape_by_flt):
3871 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
3872 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3873 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3874 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
3875 Check that fixnums are in proper range for system types.
3876 * gnutls.h: Adjust decls to match defn changes elsewhere.
3877 * gtkutil.c (xg_dialog_run):
3878 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3879 (update_frame_tool_bar):
3880 Check that fixnums are in proper range for system types.
3881 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 3882 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
3883 * indent.c (last_known_column, last_known_column_point):
3884 (current_column_bol_cache):
3885 (skip_invisible, current_column, check_display_width):
3886 (check_display_width, scan_for_column, current_column_1)
3887 (Findent_to, Fcurrent_indentation, position_indentation)
3888 (indented_beyond_p, Fmove_to_column, compute_motion):
3889 (Fcompute_motion, Fvertical_motion):
3890 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3891 (last_known_column_modified): Use EMACS_INT, not int.
3892 (check_display_width):
3893 (Fcompute_motion):
3894 Check that fixnums and floats are in proper range for system types.
3895 (compute_motion): Don't assume index or fixnum fits in int.
3896 (compute_motion, Fcompute_motion):
3897 Use int, not EMACS_INT, when it is wide enough.
3898 (vmotion): Omit local var start_hpos that is always 0; that way
3899 we don't need to worry about overflow in expressions involving it.
3900 * indent.h: Adjust decls to match defn changes elsewhere.
3901 (struct position):
3902 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3903 Use int, not EMACS_INT, where int is wide enough.
3904 Remove unused members ovstring_chars_done and tab_offset;
3905 all uses removed.
3906 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
3907 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
3908 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
3909 (make_gap, copy_text, insert, insert_and_inherit)
3910 (insert_before_markers, insert_before_markers_and_inherit)
3911 (insert_1, count_combining_before, count_combining_after)
3912 (insert_1_both, insert_from_string)
3913 (insert_from_string_before_markers, insert_from_string_1)
3914 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
3915 (adjust_after_replace, adjust_after_insert, replace_range)
3916 (replace_range_2, del_range, del_range_1, del_range_byte)
3917 (del_range_both, del_range_2, modify_region)
3918 (prepare_to_modify_buffer, signal_before_change)
3919 (signal_after_change, Fcombine_after_change_execute):
3920 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3921 * intervals.c (traverse_intervals, rotate_right, rotate_left)
3922 (balance_an_interval, split_interval_right, split_interval_left)
3923 (find_interval, next_interval, update_interval)
3924 (adjust_intervals_for_insertion, delete_node, delete_interval)
3925 (interval_deletion_adjustment, adjust_intervals_for_deletion)
3926 (static_offset_intervals, offset_intervals)
3927 (merge_interval_right, merge_interval_left, make_new_interval)
3928 (graft_intervals_into_buffer, temp_set_point_both)
3929 (temp_set_point, set_point, adjust_for_invis_intang)
3930 (set_point_both, move_if_not_intangible, get_property_and_range)
3931 (get_local_map, copy_intervals, copy_intervals_to_string)
3932 (compare_string_intervals, set_intervals_multibyte_1):
3933 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3934 * intervals.h: Adjust decls to match defn changes elsewhere.
3935 (struct interval):
3936 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3937 * keyboard.c (this_command_key_count, this_single_command_key_start)
3938 (before_command_key_count, before_command_echo_length, echo_now)
3939 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
3940 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
3941 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
3942 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
3943 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3944 (last_non_minibuf_size, last_point_position, echo_truncate)
3945 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
3946 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
3947 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
3948 (stuff_buffered_input):
3949 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3950 (last_auto_save, command_loop_1, read_char):
3951 Use EMACS_INT, not int, to avoid integer overflow.
3952 (record_char): Avoid overflow in total_keys computation.
3953 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
3954 * keyboard.h: Adjust decls to match defn changes elsewhere.
3955 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
3956 (Fkey_description, Fdescribe_vector, Flookup_key):
3957 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3958 (click_position): New function, to check that positions are in range.
3959 (Fcurrent_active_maps):
3960 (describe_command):
3961 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3962 (Faccessible_keymaps, Fkey_description):
3963 (preferred_sequence_p):
3964 Don't assume fixnum can fit into int.
3965 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
3966 Check for integer overflow in size calculations.
3967 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
3968 avoid mishandling large integers.
3969 * lisp.h: Adjust decls to match defn changes elsewhere.
3970 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
3971 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
3972 (struct Lisp_Marker):
3973 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3974 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
3975 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
3976 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
3977 All callers changed.
3978 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
3979 Assume the arg has valid form, since it always does.
3980 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
3981 unsigned integer system type.
3982 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
3983 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
3984 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3985 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
3986 (duration_to_sec_usec): New decl.
3987 * lread.c (read_from_string_index, read_from_string_index_byte)
3988 (read_from_string_limit, readchar, unreadchar, openp)
3989 (read_internal_start, read1, oblookup):
3990 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3991 (Fload, readevalloop, Feval_buffer, Feval_region):
3992 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3993 (openp): Check for out-of-range argument to 'access'.
3994 (read1): Use int, not EMACS_INT, where int is wide enough.
3995 Don't assume fixnum fits into int.
6efdadfd 3996 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
3997 (read_filtered_event): Use duration_to_sec_usec
3998 to do proper overflow checking on durations.
d311d28c
PE
3999 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
4000 in size calculation.
4001 (Fexecute_kbd_macro):
4002 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4003 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
4004 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
4005 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
4006 (set_marker_both, set_marker_restricted_both, marker_position)
4007 (marker_byte_position, Fbuffer_has_markers_at):
4008 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4009 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 4010 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
4011 It now merely ensures that the menu is large enough, without
4012 necessarily growing it, as this avoids some integer overflow issues.
4013 All callers changed.
4014 (keymap_panes, parse_single_submenu, Fx_popup_menu):
4015 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4016 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
4017 Use SAFE_ALLOCA_LISP, not alloca.
4018 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
4019 to EMACS_INT. Check that fixnums are in proper range for system types.
4020 * minibuf.c (minibuf_prompt_width, string_to_object)
4021 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
4022 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
4023 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4024 (get_minibuffer, read_minibuf_unwind):
4025 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4026 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
4027 this simplifies overflow checking. All callers changed.
4028 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
4029 (Ftest_completion):
4030 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4031 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
4032 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
4033 Check that fixnums are in proper range for system types.
4034 (Fx_create_frame, Fx_show_tip):
4035 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4036 * nsfont.m (ns_findfonts, nsfont_list_family):
4037 Don't assume fixnum fits in long.
4038 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
4039 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4040 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
4041 wide enough.
17fdb222 4042 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
4043 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4044 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
4045 (PRINTDECLARE, PRINTPREPARE):
4046 (strout, print_string):
4047 (print, print_preprocess, print_check_string_charset_prop)
4048 (print_object):
4049 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4050 (PRINTDECLARE):
4051 (temp_output_buffer_setup, Fprin1_to_string, print_object):
4052 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4053 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 4054 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 4055 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
4056 (print_error_message): Use SAFE_ALLOCA, not alloca.
4057 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
4058 (print_depth, new_backquote_output, print_number_index):
4059 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
4060 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
4061 (Fset_process_window_size, Fformat_network_address)
4062 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 4063 (sigchld_handler):
d311d28c 4064 Check that fixnums are in proper range for system types.
d44287d4 4065 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
4066 Check for process-ids out of pid_t range rather than relying on
4067 undefined behavior.
e4d81efc 4068 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
4069 (Fformat_network_address, read_process_output, send_process)
4070 (Fprocess_send_region, status_notify):
4071 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4072 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
4073 (wait_reading_process_output, read_process_output, exec_sentinel):
4074 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4075 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
4076 (Faccept_process_output): Use duration_to_sec_usec to do proper
4077 overflow checking on durations.
dde14581
PE
4078 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
4079 Don't assume pid_t fits in int.
02481186
PE
4080 * process.h (struct Lisp_Process): Members tick and update_tick
4081 are now of type EMACS_INT, not int.
b62b53e8
PE
4082 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
4083 configured --with-wide-int.
d311d28c
PE
4084 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
4085 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
4086 * search.c (looking_at_1, string_match_1):
4087 (fast_string_match, fast_c_string_match_ignore_case)
4088 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
4089 (scan_newline, find_before_next_newline, search_command)
4090 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
4091 (set_search_regs, wordify):
4092 (Freplace_match):
4093 (Fmatch_data):
4094 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4095 (string_match_1, search_buffer, set_search_regs):
4096 (Fmatch_data):
4097 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4098 (wordify): Check for overflow in size calculation.
4099 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
4100 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
4101 Check that fixnums are in proper range for system types.
4102 * sound.c (struct sound_device)
4103 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
4104 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4105 (Fplay_sound_internal):
4106 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 4107 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
4108 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
4109 (Fparse_partial_sexp):
4110 Don't assume fixnums can fit in int.
4111 (struct lisp_parse_state, find_start_pos, find_start_value)
4112 (find_start_value_byte, find_start_begv)
4113 (update_syntax_table, char_quoted, dec_bytepos)
4114 (find_defun_start, prev_char_comend_first, back_comment):
4115 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
4116 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
4117 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4118 (Finternal_describe_syntax_value): Check that match_lisp is a
4119 character, not an integer, since the code stuffs it into int.
4120 (scan_words, scan_sexps_forward):
4121 Check that fixnums are in proper range for system types.
4122 (Fforward_word):
4123 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4124 (scan_sexps_forward):
4125 Use CHARACTERP, not INTEGERP, since the value must fit into int.
4126 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
4127 * syntax.h: Adjust decls to match defn changes elsewhere.
4128 (struct gl_state_s):
4129 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
4130 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
4131 MOST_POSITIVE_FIXNUM.
d311d28c
PE
4132 * sysdep.c (wait_for_termination_1, wait_for_termination)
4133 (interruptible_wait_for_termination, mkdir):
4134 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
4135 (emacs_read, emacs_write):
4136 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
4137 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
4138 and double all fit in int.
d311d28c
PE
4139 * term.c (set_tty_color_mode):
4140 Check that fixnums are in proper range for system types.
4141 * termhooks.h (struct input_event):
4142 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4143 * textprop.c (validate_interval_range, interval_of)
4144 (Fadd_text_properties, set_text_properties_1)
4145 (Fremove_text_properties, Fremove_list_of_text_properties)
4146 (Ftext_property_any, Ftext_property_not_all)
4147 (copy_text_properties, text_property_list, extend_property_ranges)
4148 (verify_interval_modification):
4149 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4150 (Fnext_single_char_property_change)
4151 (Fprevious_single_char_property_change):
4152 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
4153 (copy_text_properties):
4154 Check for integer overflow in index calculation.
d311d28c
PE
4155 * undo.c (last_boundary_position, record_point, record_insert)
4156 (record_delete, record_marker_adjustment, record_change)
4157 (record_property_change):
4158 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4159 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
4160 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4161 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4162 (Fx_hide_tip, Fx_file_dialog):
4163 * w32menu.c (set_frame_menubar):
4164 Use ptrdiff_t, not int, for consistency with rest of code.
4165 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
4166 (select_window, Fdelete_other_windows_internal)
4167 (window_scroll_pixel_based, window_scroll_line_based)
4168 (Frecenter, Fset_window_configuration):
4169 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4170 (Fset_window_hscroll, run_window_configuration_change_hook)
4171 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 4172 (Fscroll_other_window, Frecenter):
d311d28c
PE
4173 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4174 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
4175 Don't assume fixnum fits in int.
4176 (Fset_window_scroll_bars):
4177 Check that fixnums are in proper range for system types.
4178 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
4179 (string_pos, c_string_pos, number_of_chars, init_iterator)
4180 (in_ellipses_for_invisible_text_p, init_from_display_pos)
4181 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
4182 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
4183 (face_before_or_after_it_pos, handle_invisible_prop)
4184 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
4185 (display_prop_intangible_p, string_buffer_position_lim)
4186 (string_buffer_position, handle_composition_prop, load_overlay_strings)
4187 (get_overlay_strings_1, get_overlay_strings)
4188 (iterate_out_of_display_property, forward_to_next_line_start)
4189 (back_to_previous_visible_line_start, reseat, reseat_to_string)
4190 (get_next_display_element, set_iterator_to_next)
4191 (get_visually_first_element, compute_stop_pos_backwards)
4192 (handle_stop_backwards, next_element_from_buffer)
4193 (move_it_in_display_line_to, move_it_in_display_line)
4194 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4195 (add_to_log, message_dolog, message_log_check_duplicate)
4196 (message2, message2_nolog, message3, message3_nolog
4197 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
4198 (current_message_1, truncate_echo_area, truncate_message_1)
4199 (set_message, set_message_1, store_mode_line_noprop)
4200 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
4201 (text_outside_line_unchanged_p, check_point_in_composition)
4202 (reconsider_clip_changes)
4203 (redisplay_internal, set_cursor_from_row, try_scrolling)
4204 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
4205 (redisplay_window, find_last_unchanged_at_beg_row)
4206 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
4207 (trailing_whitespace_p, find_row_edges, display_line)
4208 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
4209 (display_mode_element, store_mode_line_string)
4210 (pint2str, pint2hrstr, decode_mode_spec)
4211 (display_count_lines, display_string, draw_glyphs)
4212 (x_produce_glyphs, x_insert_glyphs)
4213 (rows_from_pos_range, mouse_face_from_buffer_pos)
4214 (fast_find_string_pos, mouse_face_from_string_pos)
4215 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4216 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4217 (safe_call, init_from_display_pos, handle_fontified_prop)
4218 (handle_single_display_spec, load_overlay_strings)
4219 (with_echo_area_buffer, setup_echo_area_for_printing)
4220 (display_echo_area, echo_area_display)
4221 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
4222 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
4223 (redisplay_window, dump_glyph_row, display_mode_line)
4224 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 4225 (handle_display_spec, display_prop_string_p):
d311d28c
PE
4226 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4227 (handle_single_display_spec, build_desired_tool_bar_string)
4228 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
4229 (get_specified_cursor_type):
4230 Check that fixnums are in proper range for system types.
4231 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
4232 (Flookup_image_map):
4233 Don't assume fixnums fit in int.
4234 (compare_overlay_entries):
4235 Avoid mishandling comparisons due to subtraction overflow.
4236 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
4237 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
4238 (handle_tool_bar_click):
4239 Use int, not unsigned, since we prefer signed and the signedness
4240 doesn't matter here.
4241 (get_next_display_element, next_element_from_display_vector):
4242 Use int, not EMACS_INT, when int is wide enough.
4243 (start_hourglass): Use duration_to_sec_usec to do proper
4244 overflow checking on durations.
4245 * xfaces.c (Fbitmap_spec_p):
4246 Check that fixnums are in proper range for system types.
4247 (compare_fonts_by_sort_order):
4248 Avoid mishandling comparisons due to subtraction overflow.
4249 (Fx_family_fonts, realize_basic_faces):
4250 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4251 (Fx_family_fonts):
4252 Don't assume fixnum fits in int.
4253 Use SAFE_ALLOCA_LISP, not alloca.
4254 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
4255 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
4256 (face_at_buffer_position, face_for_overlay_string)
4257 (face_at_string_position):
4258 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4259 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
4260 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
4261 (Fx_show_tip):
4262 Check that fixnums are in proper range for system types.
4263 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4264 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
4265 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4266 (Fx_change_window_property): Don't assume fixnums fit in int.
4267 * xfont.c (xfont_chars_supported):
4268 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4269 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
4270 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
4271 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4272 * xml.c (parse_region):
4273 * xrdb.c (magic_file_p):
4274 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4275 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
4276 (x_get_local_selection, x_reply_selection_request)
4277 (x_handle_selection_request, wait_for_property_change):
4278 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4279 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
4280 short is wide enough.
4281 (x_send_client_event): Don't assume fixnum fits in int.
4282 * xterm.c (x_x_to_emacs_modifiers):
4283 Don't assume EMACS_INT overflows nicely into int.
4284 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
4285 may come from Lisp.
4286 (handle_one_xevent): NATNUMP can eval its arg twice.
4287 (x_connection_closed):
4288 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4289 * xterm.h: Adjust decls to match defn changes elsewhere.
4290 (struct scroll_bar): Use struct vectorlike_header
4291 rather than rolling our own approximation.
4292 (SCROLL_BAR_VEC_SIZE): Remove; not used.
4293
c6574eb5
GM
42942012-05-25 Glenn Morris <rgm@gnu.org>
4295
4296 * lisp.mk (lisp): Update for more files being compiled now.
4297
e8d32c7e
SM
42982012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
4299
48def666
SM
4300 * lread.c: Remove `read_pure' which makes no difference.
4301 (read_pure): Remove var.
4302 (unreadpure): Remove function.
4303 (readevalloop): Don't call read_list with -1 flag.
4304 (read1, read_vector): Don't test read_pure any more.
4305 (read_list): Simplify.
4306
e8d32c7e
SM
4307 * fileio.c, character.h: Minor style tweaks.
4308
4b2addb7
DA
43092012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
4310
4311 * window.h (clip_changed): Remove useless declaration.
4312
584461b2
JB
43132012-05-22 Juanma Barranquero <lekktu@gmail.com>
4314
4315 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
4316 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
4317
34374650
PE
43182012-05-22 Paul Eggert <eggert@cs.ucla.edu>
4319
4320 Remove src/m/*.
4321 This directory predates autoconf and is no longer needed nowadays.
4322 Move its few remaining bits of functionality to where they're needed.
4323 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
4324 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
4325 * m/template.h: Remove.
4326 * Makefile.in (M_FILE): Remove. All uses removed.
4327 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
4328 * lisp.h (USE_LSB_TAG):
4329 * mem-limits.h (EXCEEDS_LISP_PTR):
4330 Use VAL_MAX, not VALBITS, in #if.
4331 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
4332 (EMACS_UINT): Define unconditionally now.
4333 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
4334 (BITS_PER_EMACS_INT): New constants, replacing
4335 what used to be in config.h, but not useful in #if.
4336 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
4337 define them any more.
4338 (VAL_MAX): New macro.
4339 (VALMASK): Use it.
4340 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
4341 BITS_PER_EMACS_INT, in #if.
4342 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
4343 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
4344 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
4345 * s/ms-w32.h (DATA_START):
4346 Move here from removed file m/intel386.h.
4347 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
4348 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
4349
261cb4bb
PE
43502012-05-21 Paul Eggert <eggert@cs.ucla.edu>
4351
4352 Assume C89 or later.
4353 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
4354 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
4355 (xrealloc):
4356 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
4357 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
4358 * textprop.c, tparam.c (NULL): Remove.
4359 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
4360 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
4361 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
4362 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
4363 * xterm.c (input_signal_count): Assume volatile works.
4364
ff23cd9f
KB
43652012-05-21 Ken Brown <kbrown@cornell.edu>
4366
4367 * xgselect.c (xg_select): Fix first argument in call to 'select'
4368 (bug#11508).
4369
1b170bc6
KB
43702012-05-20 Ken Brown <kbrown@cornell.edu>
4371
4372 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 4373 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 4374
b2f4d39f
KB
43752012-05-19 Ken Brown <kbrown@cornell.edu>
4376
4377 * xfns.c (x_in_use): Remove `static' qualifier.
4378 * xterm.h (x_in_use): Declare.
4379 * xgselect.c: Include xterm.h.
4380 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
4381 and `display_arg' (bug#9754).
4382
003fdae2
PE
43832012-05-19 Paul Eggert <eggert@cs.ucla.edu>
4384
9232a6d9
PE
4385 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
4386
003fdae2
PE
4387 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
4388 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
4389
784b56e2
EZ
43902012-05-18 Eli Zaretskii <eliz@gnu.org>
4391
4392 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
4393
4394 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 4395 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
4396
4397 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
4398 reference to image_cache->refcount.
4399 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
4400
a0a79cde
JL
44012012-05-17 Juri Linkov <juri@jurta.org>
4402
4403 * search.c (Fword_search_regexp, Fword_search_backward)
4404 (Fword_search_forward, Fword_search_backward_lax)
4405 (Fword_search_forward_lax): Move functions to isearch.el
4406 (bug#10145, bug#11381).
4407
b0572523
PE
44082012-05-16 Paul Eggert <eggert@cs.ucla.edu>
4409
4410 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
4411
9660f5fc
SM
44122012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
4413
4414 * lread.c (init_obarray): Declare Qt and Qnil as special.
4415
4374de83
GM
44162012-05-14 Glenn Morris <rgm@gnu.org>
4417
4418 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 4419 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 4420
dc44c39a
PE
44212012-05-14 Paul Eggert <eggert@cs.ucla.edu>
4422
078c97cb
PE
4423 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
4424
dc44c39a
PE
4425 * unexaix.c: Port to more-recent AIX compilers.
4426 (report_error, report_error_1, make_hdr, copy_sym)
4427 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
4428 Make arguments const char *, not char *, to avoid violations of C
4429 standard and to fix some AIX warnings reported by Gilles Pion.
4430
e18afed7 44312012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
4432
4433 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
4434 already have overlays loaded.
4435 (handle_single_display_spec): Before returning without displaying
4436 fringe bitmap, synchronize the bidi iterator with the main display
4437 iterator, by calling iterate_out_of_display_property.
4438 (iterate_out_of_display_property): Detect buffer iteration by
4439 testing that it->string is a Lisp string.
4440 (get_next_display_element): When the current object is exhausted,
4441 and there's something on it->stack, call set_iterator_to_next to
4442 proceed with what's on the stack, instead of returning zero.
4443 (set_iterator_to_next): If called at the end of a Lisp string,
4444 proceed to consider_string_end without incrementing string
4445 position. Don't increment display vector index past the end of
4446 the display vector. (Bug#11417)
c8fb9dc6
EZ
4447 (pos_visible_p): Don't report a position visible when move_it_to
4448 stopped at the last line of window, which happens to be scanned
4449 backwards by the bidi iteration. (Bug#11464)
ac268e67 4450
e18afed7 44512012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
4452
4453 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
4454 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
4455 are on a TTY, and thus unable to display on the fringes.
4456 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
4457 so we need to signal to the caller that this is a "replacing"
4458 display spec. This fixes display when the spec is invalid or we
4459 are on a TTY.
4460
e18afed7 44612012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
4462
4463 * unexaix.c (make_hdr): Fix typo in prototype.
4464 This bug broke the build on AIX. Problem reported by Gilles Pion.
4465
9d0a235a
MA
44662012-05-14 Michael Albinus <michael.albinus@gmx.de>
4467
4468 * keyboard.c (kbd_buffer_get_event): Read special events also in
4469 batch mode. (Bug#11415)
4470
9e6b06ed
GM
44712012-05-12 Glenn Morris <rgm@gnu.org>
4472
4473 * ns.mk: Update for ns_appbindir no longer having trailing "/".
4474
c1a1d7a3
EZ
44752012-05-12 Eli Zaretskii <eliz@gnu.org>
4476
4477 * lisp.mk (lisp): Add newcomment.elc.
4478
3fe7cdc8
GM
44792012-05-12 Glenn Morris <rgm@gnu.org>
4480
4481 * Makefile.in (MKDIR_P): New, set by configure.
4482 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
4483
53f7d2c0
PE
44842012-05-11 Paul Eggert <eggert@cs.ucla.edu>
4485
4486 Remove unused function hourglass_started.
4487 * dispextern.h (hourglass_started):
4488 * w32fns.c (hourglass_started):
4489 * xdisp.c (hourglass_started): Remove.
4490
75aafb17
JB
44912012-05-10 Juanma Barranquero <lekktu@gmail.com>
4492
4493 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
4494 Update dependencies.
4495
12959e8e
PE
44962012-05-10 Paul Eggert <eggert@cs.ucla.edu>
4497
97107e2e
PE
4498 * xgselect.c (xg_select): Put maxfds+1 into a var.
4499 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
4500
12959e8e
PE
4501 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
4502
836d29b3
DA
45032012-05-10 Dave Abrahams <dave@boostpro.com>
4504
4505 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
4506 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
4507
5cb67954
MA
45082012-05-09 Michael Albinus <michael.albinus@gmx.de>
4509
4510 * dbusbind.c (xd_registered_buses): New internal Lisp object.
4511 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
4512 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
4513 Initialize xd_registered_buses.
4514
3478ec45
PE
45152012-05-09 Paul Eggert <eggert@cs.ucla.edu>
4516
b263a6b0
PE
4517 Untag more efficiently if USE_LSB_TAG.
4518 This is based on a proposal by YAMAMOTO Mitsuharu in
4519 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
4520 For an admittedly artificial (nth 8000 longlist) benchmark on
4521 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
4522 Emacs's overall text size by 1%.
4523 * lisp.h (XUNTAG): New macro.
4524 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
4525 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
4526 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
4527 * eval.c (Fautoload):
4528 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
4529 * frame.h (XFRAME): Use XUNTAG.
4530
3478ec45
PE
4531 Port recent dbusbind.c changes to 32-bit --with-wide-int.
4532 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
4533 Remove unportable assumptions about print widths of types like
4534 dbus_uint32_t.
4535 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
4536 intptr_t when converting between pointer and integer, to avoid GCC
4537 warnings about wrong width.
4538
666b903b 45392012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
4540
4541 * w32proc.c (new_child): Force Windows to reserve only 64KB of
4542 stack for each reader_thread, instead of defaulting to 8MB
4543 determined by the linker. This avoids failures in creating
4544 subprocesses on Windows 7, see the discussion in this thread:
4545 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
4546
b120cc17
JC
45472012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
4548
4549 Fix up display of the *Minibuf-0* buffer in the mini window.
4550 * keyboard.c (read_char): Don't clear the echo area if there's no
4551 message to clear.
4552 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 4553 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 4554
9a4b36f8
MA
45552012-05-07 Michael Albinus <michael.albinus@gmx.de>
4556
4557 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
4558 batch mode.
4559
e5f9458f
CY
45602012-05-06 Chong Yidong <cyd@gnu.org>
4561
4562 * lisp.mk (lisp): Update.
4563
eceeb5fc 45642012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
4565
4566 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
4567
71873e2b
SM
45682012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
4569
4570 * data.c (PUT_ERROR): New macro.
4571 (syms_of_data): Use it. Add new error type `user-error'.
4572 * undo.c (user_error): New function.
4573 (Fprimitive_undo): Use it.
4574 * print.c (print_error_message): Adjust print style for `user-error'.
4575 * keyboard.c (user_error): New function.
4576 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
4577
ab0fa4e4
PE
45782012-05-03 Paul Eggert <eggert@cs.ucla.edu>
4579
4580 Do not limit current-time-string to years 1000..9999.
4581 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
4582 (Fcurrent_time_string): Support any year that is supported by the
4583 underlying localtime representation. Don't use asctime, as it
4584 has undefined behavior for years outside the range -999..9999.
4585
7ed806a7
PE
45862012-05-02 Paul Eggert <eggert@cs.ucla.edu>
4587
4588 Fix race conditions involving setenv, gmtime, localtime, asctime.
4589 Without this fix, interrupts could mess up code that uses these
4590 nonreentrant functions, since setting TZ invalidates existing
4591 tm_zone or tzname values, and since most of these functions return
4592 pointers to static storage.
4593 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
4594 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
4595 Grow the critical sections to include not just invoking
4596 localtime/gmtime, but also accessing these functions' results
4597 including their tm_zone values if any, and any related TZ setting.
4598 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
4599 so that the struct tm is saved in the critical section.
4600 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
4601 motivated by the fact that memory allocation needs to be outside
4602 the critical section.
4603
0c16dfed
DA
46042012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
4605
4606 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
4607 with RESET_INTERVAL.
4608
4609 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4610 Remove duplicated buffer name initialization.
4611
3f83ace8
JM
46122012-05-02 Jim Meyering <jim@meyering.net>
4613
4614 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
4615
c7b8541e
JM
4616 * xfns.c (x_window): Use xstrdup (Bug#11375).
4617
90207a15 46182012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
4619
4620 * xdisp.c (pos_visible_p): If already at a newline from the
4621 display string before the 'while' loop, don't walk back the glyphs
4622 from it3.glyph_row. Solves assertion violation when the display
4623 string begins with a newline (egg.el). (Bug#11367)
4624
b593d6a9
AH
46252012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
4626
4627 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
4628 Move to simple.el.
4629
4737362e
GM
46302012-05-01 Glenn Morris <rgm@gnu.org>
4631
99cf43f9
GM
4632 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
4633 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
4634 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
4635 All were removed before 23.1.
4636
9311dcff
GM
4637 * dispnew.c: Remove HAVE_LIBNCURSES test;
4638 it is always true on relevant platforms.
4639
4d5c6349
GM
4640 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
4641 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
4642
4737362e
GM
4643 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
4644
74dd3a6b
AS
46452012-04-30 Andreas Schwab <schwab@linux-m68k.org>
4646
4647 * .gdbinit (xpr): Remove checks for no longer existing misc types.
4648 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
4649 Remove.
4650
13c379ee
PE
46512012-04-28 Paul Eggert <eggert@cs.ucla.edu>
4652
4653 Do not avoid creating empty evaporating overlays (Bug#9642).
4654 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
4655 That is, do not delete an evaporating overlay if it becomes
4656 empty after its bounds are adjusted to fit within its buffer.
4657 This fix caused other problems, and I'm reverting it until we get
4658 to the bottom of them.
4659
a8e7d6d7 46602012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
4661
4662 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
4663
a8e7d6d7 46642012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
4665
4666 * xdisp.c (pos_visible_p): If the window start position is beyond
4667 ZV, start the display from buffer beginning. Prevents assertion
4668 violation in init_iterator when the minibuffer window is scrolled
4669 via the scroll bar.
4670
4671 * window.c (window_scroll_pixel_based): Likewise.
4672
a8e7d6d7 46732012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
4674
4675 * keymap.c (where_is_internal): Doc fix (Bug#10872).
4676
a8e7d6d7 46772012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
4678
4679 * fileio.c (Fcopy_file, Fset_file_selinux_context):
4680 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
4681
a8e7d6d7 46822012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 4683
b593d6a9
AH
4684 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
4685 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 4686
1c6900d9
EZ
46872012-04-26 Eli Zaretskii <eliz@gnu.org>
4688
4c3fa1d9
EZ
4689 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
4690 display element, check also the underlying string or buffer
4691 character. (Bug#11341)
4692
1c6900d9
EZ
4693 * w32menu.c: Include w32heap.h.
4694 (add_menu_item): If the call to AppendMenuW (via
4695 unicode_append_menu) fails, disable Unicode menus only if we are
4696 running on Windows 9X/Me.
4697
42bf8205
AS
46982012-04-24 Andreas Schwab <schwab@linux-m68k.org>
4699
4700 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
4701 (xgetint): Add missing shift for LSB tags.
4702
b1bac16e
MR
47032012-04-24 Martin Rudalics <rudalics@gmx.at>
4704
4705 * keyboard.c (read_char): Don't wipe echo area for select window
4706 events: These might get delayed via `mouse-autoselect-window'
4707 (Bug#11304).
4708
d69621cc
JB
47092012-04-24 Juanma Barranquero <lekktu@gmail.com>
4710
4711 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
4712 manipulation of :loaded-from data.
4713
02fd101b
JB
47142012-04-23 Juanma Barranquero <lekktu@gmail.com>
4715
4716 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
4717 now a cons (bug#11311).
4718
888bec30
PE
47192012-04-23 Paul Eggert <eggert@cs.ucla.edu>
4720
89a438bd
PE
4721 Do not create empty overlays with the evaporate property (Bug#9642).
4722 * buffer.c (Fmove_overlay): Delete an evaporating overlay
4723 if it becomes empty after its bounds are adjusted to fit within
4724 its buffer. Without this fix, in a nonempty buffer (let ((o
4725 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
4726 yields an empty overlay that has the evaporate property, which is
4727 not supposed to happen.
4728
1068fe4d
PE
4729 Fix minor GTK3 problems found by static checking.
4730 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4731 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4732 (struct _EmacsFixedClass, emacs_fixed_get_type):
4733 Move decls here from emacsgtkfixed.h, since they needn't be public.
4734 (emacs_fixed_get_type): Now static.
4735 (emacs_fixed_class_init): Omit unused local.
4736 (emacs_fixed_child_type): Remove; unused.
4737 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4738 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4739 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
4740 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
4741 (EMACS_FIXED_GET_CLASS): Remove; unused.
4742 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
4743
888bec30
PE
4744 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
4745 Problem reported by Juanma Barranquero for Windows -Wunused-function.
4746
de85e130
PE
47472012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4748
d0baac98 4749 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 4750 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
4751 (__malloc_size_t, __malloc_ptrdiff_t):
4752 Remove. All uses removed, replaced by the definiens if needed,
4753 since we can assume C89 or better now.
4754 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
4755 (protect_malloc_state, align, get_contiguous_space)
4756 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
4757 (malloc_atfork_handler_child, malloc_enable_thread)
4758 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
4759 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
4760 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
4761 (special_realloc, _realloc_internal_nolock, _realloc_internal)
4762 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
4763 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
4764 Define using prototypes, not old style.
4765 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
4766 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
4767 (align): Don't assume that signed integer overflow wraps around.
4768 Omit unused local var.
4769 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
4770 (_free_internal_nolock, memalign, mallochook, reallochook):
4771 Omit no-longer-needed casts.
4772 (valloc): Use getpagesize, not __getpagesize.
4773 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
4774 (struct hdr): The 'magic' member is now size_t, not unsigned long.
4775
de85e130
PE
4776 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
4777
dcbf5805
MA
47782012-04-22 Michael Albinus <michael.albinus@gmx.de>
4779
4780 Move functions from C to Lisp. Make non-blocking method calls
4781 the default. Implement further D-Bus standard interfaces.
4782
4783 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
4784 (QCdbus_request_name_allow_replacement)
4785 (QCdbus_request_name_replace_existing)
4786 (QCdbus_request_name_do_not_queue)
4787 (QCdbus_request_name_reply_primary_owner)
4788 (QCdbus_request_name_reply_in_queue)
4789 (QCdbus_request_name_reply_exists)
4790 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
4791 (QCdbus_registered_serial, QCdbus_registered_method)
4792 (QCdbus_registered_signal): New Lisp objects.
4793 (XD_DEBUG_MESSAGE): Use sizeof.
4794 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
4795 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
4796 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
4797 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
4798 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
4799 (xd_signature, xd_append_arg): Allow float for integer types.
4800 (xd_get_connection_references): New function.
b593d6a9
AH
4801 (xd_get_connection_address): Rename from xd_initialize.
4802 Return cached address.
dcbf5805
MA
4803 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
4804 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
4805 level.
4806 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 4807 Return number of refcounts.
dcbf5805
MA
4808 (Fdbus_get_unique_name): Make stronger parameter check.
4809 (Fdbus_message_internal): New defun.
4810 (Fdbus_call_method, Fdbus_call_method_asynchronously)
4811 (Fdbus_method_return_internal, Fdbus_method_error_internal)
4812 (Fdbus_send_signal, Fdbus_register_service)
4813 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
4814 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
4815 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
4816 (Vdbus_compiled_version, Vdbus_runtime_version)
4817 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
4818 (Vdbus_message_type_method_return, Vdbus_message_type_error)
4819 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
4820 (Vdbus_registered_buses, Vdbus_registered_objects_table):
4821 Adapt docstring.
dcbf5805 4822
52828e02
PE
48232012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4824
da05bc4c
PE
4825 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
4826 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
4827 Do not assume ptrdiff_t is the same width as 'int'.
4828
52828e02
PE
4829 * alloc.c: Handle unusual debugging option combinations.
4830 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
4831 since the two debugging options are incompatible.
4832 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
4833 is defined.
4834 (mem_init, mem_insert, mem_insert_fixup):
4835 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
4836 (NEED_MEM_INSERT): Remove; no longer needed.
4837
f01769f9
LL
48382012-04-22 Leo Liu <sdl.web@gmail.com>
4839
4840 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
4841
5790543d
PE
48422012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4843
4844 * sysdep.c [__FreeBSD__]: Minor cleanups.
4845 (list_system_processes, system_process_attributes) [__FreeBSD__]:
4846 Use Emacs indenting style more consistently. Avoid some casts.
4847 Use 'double' consistently rather than mixing 'float' and 'double'.
4848
b91b7e4d
EW
48492012-04-21 Eduard Wiebe <usenet@pusto.de>
4850
b593d6a9
AH
4851 * sysdep.c (list_system_processes, system_process_attributes):
4852 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 4853
6114eb15
AS
48542012-04-21 Andreas Schwab <schwab@linux-m68k.org>
4855
4856 * lisp.mk (lisp): Update.
4857
2f38dff7
PE
48582012-04-20 Paul Eggert <eggert@cs.ucla.edu>
4859
4860 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
4861 It is never used otherwise.
4862
4ae29f89
SM
48632012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
4864
4865 * print.c (print_preprocess): Only check print_depth if print-circle
4866 is nil.
4867 (print_object): Check for cycles even when print-circle is nil and
4868 print-gensym is t, but only check print_depth if print-circle is nil.
4869
f30d612a
CY
48702012-04-20 Chong Yidong <cyd@gnu.org>
4871
4872 * process.c (wait_reading_process_output): If EIO occurs on a pty,
4873 set the status to "failed" and ensure that sentinel is run.
4874
c07a4c0b 48752012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
4876
4877 * process.c (Fset_process_inherit_coding_system_flag)
4878 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 4879 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 4880
c07a4c0b 48812012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
4882
4883 * xdisp.c (string_buffer_position_lim): Limit starting position to
4884 BEGV.
4885 (set_cursor_from_row): If called for a mode-line or header-line
4886 row, return zero immediately.
4887 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
4888 farther than the first row after the header line, if any.
4889 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
4890 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
4891
c07a4c0b 48922012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 4893
4ae29f89
SM
4894 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
4895 (bug#11238).
ad3a2b41 4896
c07a4c0b 48972012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 48982012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
4899
4900 configure: new option --enable-gcc-warnings (Bug#11207)
4901 * Makefile.in (C_WARNINGS_SWITCH): Remove.
4902 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
4903 (ALL_CFLAGS): Use new macros rather than old.
4904 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
4905 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
4906 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
4907 -Wunused-result, -Wunused-variable. This should go away once
4908 the Emacs and Gnulib regex code is merged.
4909 (xmalloc, xrealloc): Now static.
4910
aba027e8
PE
49112012-04-17 Paul Eggert <eggert@cs.ucla.edu>
4912
4913 * dired.c (Fsystem_groups): Remove unused local.
4914
e5a36063
GM
49152012-04-17 Glenn Morris <rgm@gnu.org>
4916
4917 * dired.c (Fsystem_users): Doc fix.
4918
316411f0
DA
49192012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
4920
4921 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
4922 (syms_of_dired): Add them.
4923
9426aba4
PE
49242012-04-16 Paul Eggert <eggert@cs.ucla.edu>
4925
b62a57be
PE
4926 Fix minor alloc.c problems found by static checking.
4927 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
4928 New extern decls, to avoid calling undeclared functions.
4929 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
4930 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
4931 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
4932 (NEED_MEM_INSERT): New macro.
4933 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 4934 Remove one incorrect comment and fix another.
b62a57be 4935
3539f31f
PE
4936 Fix minor ralloc.c problems found by static checking.
4937 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4938 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
4939 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
4940 (r_alloc_sbrk): Now static.
4941
a041960a
PE
4942 Improve ralloc.c interface checking.
4943 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4944 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
4945 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
4946 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
4947 [REL_ALLOC]: ... to here, to check interface.
4948 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
4949 Remove decls. This fixes an "It stinks!".
4950
9426aba4
PE
4951 * alloc.c (which_symbols): Fix alignment issue / type clash.
4952
d55c12ed
AS
49532012-04-15 Andreas Schwab <schwab@linux-m68k.org>
4954
4955 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
4956 (struct Lisp_Misc_Any): Likewise.
4957 (struct Lisp_Free): Likewise.
4958 * alloc.c (union aligned_Lisp_Symbol): Define.
4959 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
4960 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
4961 (union aligned_Lisp_Misc): Define.
4962 (MARKER_BLOCK_SIZE, struct marker_block): Use union
4963 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 4964 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 4965
b948ce8b
PE
49662012-04-14 Paul Eggert <eggert@cs.ucla.edu>
4967
4968 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
4969 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
4970 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
4971 * s/netbsd.h, s/sol2-6.h:
4972 Remove definition of GC_MARK_STACK, since the default now works.
4973 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
4974 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
4975 no longer the default.
4976 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
4977
35dc09a1 49782012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 4979
35dc09a1
GM
4980 * lread.c (lisp_file_lexically_bound_p):
4981 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 4982
35dc09a1
GM
49832012-04-14 Eli Zaretskii <eliz@gnu.org>
4984
4985 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
4986 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
4987
49882012-04-14 Jan Djärv <jan.h.d@swipnet.se>
4989
4990 * nsterm.m (constrainFrameRect): Always constrain when there is only
4991 one screen (Bug#10962).
4992
bcd86815
KB
49932012-04-13 Ken Brown <kbrown@cornell.edu>
4994
4995 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
4996
c25df26e
RT
49972012-04-13 Reuben Thomas <rrt@sc3d.org>
4998
4999 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
5000
0fc59f1e
DC
50012012-04-11 Daniel Colascione <dancol@dancol.org>
5002
5003 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
5004 against is gone. It's better to use vfork now so that when Cygwin
5005 gains a new, working vfork, we use it automatically (bug#10398).
5006
de8c03dc
SM
50072012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
5008
5009 * window.c (save_window_save): Obey window-point-insertion-type.
5010
2f097256
GM
50112012-04-11 Glenn Morris <rgm@gnu.org>
5012
5013 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
5014
453b951e
SM
50152012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
5016
5017 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
5018
75f1671a 50192012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
5020
5021 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
5022 (force_quit_count): New var.
5023 (handle_interrupt): Use it.
5024
2a8ce227
JB
50252012-04-10 Juanma Barranquero <lekktu@gmail.com>
5026
5027 * w32.c (w32_delayed_load): Record the full path of the library
5028 being loaded (bug#10424).
5029
935396c0
GM
50302012-04-09 Glenn Morris <rgm@gnu.org>
5031
05920a43
GM
5032 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
5033 not just in the obarray, before snarfing them. (Bug#11036)
5034
935396c0
GM
5035 * Makefile.in ($(leimdir)/leim-list.el):
5036 Pass EMACS rather than BUILT_EMACS.
5037
a18ecafa
TZ
50382012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
5039
5040 * process.c (make_process):
5041 * process.h: Add integer `gnutls_handshakes_tried' member to
5042 process struct.
5043
6bbef4e5
JC
5044 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
5045 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
5046
5047 * gnutls.c (gnutls_log_function2i): Convenience log function.
5048 (emacs_gnutls_read): Use new log functions,
5049 `gnutls_handshakes_tried' process member, and
5050 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
5051 attempts per process (connection).
5052
b4d3bc10
CY
50532012-04-09 Chong Yidong <cyd@gnu.org>
5054
5055 * eval.c (Fuser_variable_p, user_variable_p_eh)
5056 (lisp_indirect_variable): Functions deleted.
5057 (Fdefvar): Caller changed.
5058
5059 * callint.c (Finteractive, Fcall_interactively):
5060 * minibuf.c (Fread_variable): Callers changed.
5061
70f4d973
EZ
50622012-04-09 Eli Zaretskii <eliz@gnu.org>
5063
5064 * xdisp.c (set_cursor_from_row): If the display string appears in
5065 the buffer at position that is closer to point than the position
5066 after the display string, display the cursor on the first glyph of
5067 the display string. Fixes cursor display when a 'display' text
5068 property immediately follows invisible text. (Bug#11094)
5069
cb3c2e3e
PE
50702012-04-09 Paul Eggert <eggert@cs.ucla.edu>
5071
5072 composite.c: use 'double' consistently
5073 * composite.c (get_composition_id): Use 'double' consistently
5074 instead of converting 'float' to 'double' and vice versa; this is
5075 easier to understand and avoids a GCC warning.
5076
fd06db5d
GM
50772012-04-09 Glenn Morris <rgm@gnu.org>
5078
50fe702a
GM
5079 * Makefile.in: Generate leim-list with bootstrap-emacs, in
5080 preparation for dumping it with emacs. (Bug#4789)
5081 (leimdir): New variable.
5082 ($(leimdir)/leim-list.el): New rule.
5083 (emacs$(EXEEXT)): Depend on leim-list.el.
5084
fd06db5d
GM
5085 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
5086 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
5087 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
5088
55c131ee
AS
50892012-04-08 Andreas Schwab <schwab@linux-m68k.org>
5090
5091 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
5092 proper alignment.
5093
9209588f
JB
50942012-04-07 Juanma Barranquero <lekktu@gmail.com>
5095
5096 * xml.c (init_libxml2_functions) [WINDOWSNT]:
5097 Remove unused local variable.
5098
e3fb2efb
PE
50992012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5100
5101 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
5102 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
5103 (mark_memory): Mark Lisp_Objects only if pointers might hide in
5104 objects, as mark_maybe_pointer will catch them otherwise.
5105 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
5106 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
5107
b5385551
PE
51082012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5109
5110 Fix typo that broke non-Windows builds.
5111 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
5112
9078ead6
EZ
51132012-04-07 Eli Zaretskii <eliz@gnu.org>
5114
5115 Support building on MS-Windows with libxml2.
5116
5117 * makefile.w32-in (OBJ2): Add xml.$(O).
5118 (GLOBAL_SOURCES): Add xml.c.
5119 ($(BLD)/xml.$(O)): New dependency list.
5120
5121 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
5122 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
5123 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
5124 [!WINDOWSNT]: New macros.
5125 (init_libxml2_functions, libxml2_loaded_p): New functions.
5126 (parse_region): Call fn_xmlCheckVersion instead of using the macro
5127 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
5128 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
5129 Calls xmlCleanupParser only if libxml2 was loaded (or statically
5130 linked in).
6bbef4e5
JC
5131 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
5132 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
5133 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
5134
5135 * emacs.c: Don't include libxml/parser.h.
5136 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
5137 xmlCleanupParser directly.
5138
5139 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
5140
3811fdf3
EZ
51412012-04-07 Eli Zaretskii <eliz@gnu.org>
5142
5143 * indent.c (Fvertical_motion): If there is a display string at
5144 point, use it.vpos to compute how many lines to backtrack after
5145 move_it_to point. (Bug#11133)
5146
2f8e16b2
EZ
51472012-04-06 Eli Zaretskii <eliz@gnu.org>
5148
5149 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
5150 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
5151 about subtle differences between FETCH_CHAR* and STRING_CHAR*
5152 macros related to unification of CJK characters. For the details,
5153 see the discussion following the message here:
5154 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
5155
3d439cd1
CY
51562012-04-04 Chong Yidong <cyd@gnu.org>
5157
5158 * keyboard.c (Vdelayed_warnings_list): Doc fix.
5159
8bc53d00
EZ
51602012-04-01 Eli Zaretskii <eliz@gnu.org>
5161
5162 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
5163 instead of alloca. (Bug#11138)
5164
3b0512a3
AS
51652012-04-01 Andreas Schwab <schwab@linux-m68k.org>
5166
5167 * w32menu.c (is_simple_dialog): Properly check lisp types.
5168 (Bug#11141)
5169
8427ddd2
EZ
51702012-03-31 Eli Zaretskii <eliz@gnu.org>
5171
979022ef
EZ
5172 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
5173 position we get to after a call to move_it_to fails the
5174 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
5175 only if we wind up in a string from display property. (Bug#11063)
5176
a6b1c7cc
EZ
5177 * window.c (Fdelete_other_windows_internal): Invalidate the row
5178 and column information about mouse highlight, so that redisplay
5179 restores it after reallocating the glyph matrices. (Bug#7464)
5180
8427ddd2
EZ
5181 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
5182 string comes from a `display' text property, use the buffer
5183 position of that property as if we actually saw that position in
5184 the row's glyphs.
697ba24b
EZ
5185 (move_it_by_lines): Remove the assertion that
5186 "it->current_x == 0 && it->hpos == 0" which can be legitimately
5187 violated when there's a before-string at the beginning of a line.
5188 (Bug#11063)
8427ddd2 5189
65a0a738
EZ
51902012-03-30 Eli Zaretskii <eliz@gnu.org>
5191
5192 * xdisp.c (append_space_for_newline): If the default face was
5193 remapped, use the remapped face for the appended newline.
5194 (extend_face_to_end_of_line): Use the remapped default face for
5195 extending the face to the end of the line.
5196 (display_line): Call extend_face_to_end_of_line when the default
5197 face was remapped. (Bug#11068)
5198
581355cc
EZ
51992012-03-29 Eli Zaretskii <eliz@gnu.org>
5200
5201 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
5202
e8fc049f
SM
52032012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5204
5205 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
5206
4fb9a543
GM
52072012-03-27 Glenn Morris <rgm@gnu.org>
5208
5209 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
5210 Doc fixes.
5211
679910f1
KH
52122012-03-26 Kenichi Handa <handa@m17n.org>
5213
5214 * dispextern.h (struct glyph): Fix previous change. Change the
5215 bit length of glyphless.ch to 25 (Bug#11082).
5216
90d49b7f
CY
52172012-03-26 Chong Yidong <cyd@gnu.org>
5218
5219 * keyboard.c (Vselection_inhibit_update_commands): New variable.
5220 (command_loop_1): Use it; inhibit selection update for
5221 handle-select-window too (Bug#8996).
5222
f514f6f0
FP
52232012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
5224
e8fc049f 5225 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 5226
bf43fa51
KH
52272012-03-25 Kenichi Handa <handa@m17n.org>
5228
5229 * dispextern.h (struct glyph): Change the bit length of
5230 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
5231
8a0c01dd
EZ
52322012-03-24 Eli Zaretskii <eliz@gnu.org>
5233
5234 * s/ms-w32.h (tzname): Include time.h before redirecting to
5235 _tzname. Fixes the MSVC build. (Bug#9960)
5236
7d1c3a76
AS
52372012-03-24 Andreas Schwab <schwab@linux-m68k.org>
5238
8ed79523
AS
5239 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
5240 characters.
5241
7d1c3a76
AS
5242 * xterm.c (XTread_socket): Only modify handling_signal if
5243 !SYNC_INPUT. (Bug#11080)
5244
e99a9b8b
EZ
52452012-03-23 Eli Zaretskii <eliz@gnu.org>
5246
5247 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
5248 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
5249 when fetching a multibyte character consumes more bytes than
5250 CHAR_BYTES returns, due to unification of CJK characters in
5251 string_char. (Bug#11073)
5252
5063c0e1
TN
52532012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
5254
5255 * process.c (wait_reading_process_output): Handle pty disconnect
5256 by refraining from sending oneself a SIGCHLD (bug#10933).
5257
9f851fbd
CY
52582012-03-22 Chong Yidong <cyd@gnu.org>
5259
5260 * dispextern.h (struct it): New member string_from_prefix_prop_p.
5261
5063c0e1 5262 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
5263 Mark string as coming from a prefix property.
5264 (handle_face_prop): Use default face for prefix strings (Bug#4281).
5265 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
5266
fb5b8aca
CY
52672012-03-21 Chong Yidong <cyd@gnu.org>
5268
5269 * xfaces.c (Vface_remapping_alist): Doc fix.
5270
62356a1b
EZ
52712012-03-20 Eli Zaretskii <eliz@gnu.org>
5272
5273 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
5274 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
5275 Doc fixes.
62356a1b 5276
025de85b
CY
52772012-03-20 Chong Yidong <cyd@gnu.org>
5278
5279 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
5280 to reflect default non-nil value of redisplay-dont-pause.
5281
4827f94e
KH
52822012-03-19 Kenichi Handa <handa@m17n.org>
5283
5284 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
5285 it fit in a valid range (Bug#11003).
5286
e50a24a2
EZ
52872012-03-18 Eli Zaretskii <eliz@gnu.org>
5288
5289 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
5290 that is not from display property, accept the row as a "cursor
5291 row" if one of the string's character has a non-nil `cursor'
5292 property. Fixes cursor positioning when there are newlines in
5293 overlay strings, e.g. in icomplete.el. (Bug#11035)
5294
9af5ed87
PE
52952012-03-12 Paul Eggert <eggert@cs.ucla.edu>
5296
5297 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
5298
d1f55f16
CY
52992012-03-12 Chong Yidong <cyd@gnu.org>
5300
5301 * eval.c (inhibit_lisp_code): Rename from
5302 inhibit_window_configuration_change_hook; move from window.c.
5303
5304 * xfns.c (unwind_create_frame_1, Fx_create_frame):
5305 * window.c (run_window_configuration_change_hook)
5306 (syms_of_window): Callers changed.
5307
66c5eebd
CY
53082012-03-11 Chong Yidong <cyd@gnu.org>
5309
413df973
CY
5310 * keymap.c (Fkey_description): Doc fix (Bug#9700).
5311
66c5eebd
CY
5312 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
5313
1de11f56
CY
53142012-03-10 Chong Yidong <cyd@gnu.org>
5315
5316 * frame.c (other_visible_frames): Don't assume the selected frame
5317 is visible (Bug#10955).
5318
cae07000
SM
53192012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
5320
5321 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
5322
89c94350
JD
53232012-03-08 Jan Djärv <jan.h.d@swipnet.se>
5324
5325 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
5326 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
5327 zero (Bug#10954).
5328
999dd333
GM
53292012-03-03 Glenn Morris <rgm@gnu.org>
5330
01a6dcc8 5331 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 5332
de0100f2
EZ
53332012-03-02 Eli Zaretskii <eliz@gnu.org>
5334
5335 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
5336 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
5337 (redisplay_window, next_element_from_string): Fix typos in
5338 comments.
3e441275
EZ
5339 (redisplay_window): Pass to move_it_vertically the margin in
5340 pixels, not in screen lines.
de0100f2 5341
96a72ee9
GM
53422012-03-02 Glenn Morris <rgm@gnu.org>
5343
5344 * buffer.c (buffer-list-update-hook): Doc fix.
5345
312508d7
EZ
53462012-02-29 Eli Zaretskii <eliz@gnu.org>
5347
5348 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
5349 push_it before setting up the iterator for the first overlay
5350 string, even if we have an empty string loaded.
5351 (next_overlay_string): If there's an empty string on the iterator
5352 stack, pop the stack. (Bug#10903)
5353
27f3c637
PE
53542012-02-25 Paul Eggert <eggert@cs.ucla.edu>
5355
5356 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
5357 Suggested by Stefan Monnier in
5358 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
5359 * alloc.c (widen_to_Lisp_Object): New static function.
5360 (mark_memory): Also mark Lisp_Objects by fetching pointer words
5361 and widening them to Lisp_Objects. This would work even if
5362 USE_LSB_TAG is defined and wide integers are used, which might
5363 happen in a future version of Emacs.
5364
3c9dfce6
CY
53652012-02-25 Chong Yidong <cyd@gnu.org>
5366
fa74b241
CY
5367 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
5368 Doc fix.
5369
3c9dfce6
CY
5370 * xselect.c (Fx_selection_exists_p): Doc fix.
5371 (x_clipboard_manager_save_all): Print an informative message
5372 before saving to clipboard manager.
5373
9486df08
CY
53742012-02-24 Chong Yidong <cyd@gnu.org>
5375
5376 * keyboard.c (process_special_events): Handle all X selection
5377 requests in kbd_buffer, not just the next one (Bug#8869).
5378
f01d3321
CY
53792012-02-23 Chong Yidong <cyd@gnu.org>
5380
5381 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
5382 call when setting menu-bar-lines and tool-bar-lines parameters.
5383 (unwind_create_frame_1): New helper function.
5384
5385 * window.c (inhibit_window_configuration_change_hook): New var.
5386 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 5387 (syms_of_window): Initialize it.
f01d3321 5388
86b847b6
CY
53892012-02-22 Chong Yidong <cyd@gnu.org>
5390
5391 * xterm.c (x_draw_image_relief): Add missing type check for
5392 Vtool_bar_button_margin (Bug#10743).
5393
a59225b1
CY
53942012-02-21 Chong Yidong <cyd@gnu.org>
5395
5396 * fileio.c (Vfile_name_handler_alist): Doc fix.
5397
5398 * buffer.c (Fget_file_buffer): Protect against invalid file
5399 handler return value.
5400
310f5bd4
PE
54012012-02-20 Paul Eggert <eggert@cs.ucla.edu>
5402
cb3a28cc
PE
5403 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
5404 when computing $valmask.
5405
310f5bd4
PE
5406 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
5407 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
5408 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
5409 It's useless in that case, and it can cause problems on hosts
5410 that allocate halves of EMACS_INT values separately.
5411 Reported by Dan Horák. Diagnosed by Andreas Schwab in
5412 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
5413 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
5414 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
5415 it avoids undefined behavior on hosts where shifting right by more
5416 than the word width has undefined behavior.
5417
2375c96a
CY
54182012-02-19 Chong Yidong <cyd@gnu.org>
5419
5420 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
5421 (Funhandled_file_name_directory, Ffile_name_as_directory)
5422 (Fdirectory_file_name, Fexpand_file_name)
5423 (Fsubstitute_in_file_name): Protect against invalid file handler
5424 return values (Bug#10845).
5425
3eb49e71
EZ
54262012-02-18 Eli Zaretskii <eliz@gnu.org>
5427
5428 * .gdbinit (pitx): Fix incorrect references to fields of the
5429 iterator stack.
5430
7b926f3f
CY
54312012-02-17 Chong Yidong <cyd@gnu.org>
5432
5433 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
5434
11273115
PE
54352012-02-15 Paul Eggert <eggert@cs.ucla.edu>
5436
5437 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
5438 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
5439
c3a70e2b
CY
54402012-02-15 Chong Yidong <cyd@gnu.org>
5441
5442 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
5443 marked as special. Also, starting docstrings with * is obsolete.
5444
0ca43699
AS
54452012-02-13 Andreas Schwab <schwab@linux-m68k.org>
5446
5447 * gnutls.c (emacs_gnutls_write): Fix last change.
5448
2e8f3c56
LI
54492012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
5450
5451 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
5452 send_process.
5453
af70074f
SM
54542012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
5455
5456 * keymap.c (Fsingle_key_description): Handle char ranges.
5457
95986d52
CY
54582012-02-12 Chong Yidong <cyd@gnu.org>
5459
afd83bd1
CY
5460 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
5461 as that creates a dangerous corner case.
5462
95986d52
CY
5463 * window.c (Fdelete_window_internal): Invalidate the mouse
5464 highlight (Bug#9904).
5465
bd7da63e
GM
54662012-02-12 Glenn Morris <rgm@gnu.org>
5467
5468 * xselect.c (Fx_own_selection_internal)
5469 (Fx_get_selection_internal, Fx_disown_selection_internal)
5470 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
5471 * nsselect.m (Fx_own_selection_internal)
5472 (Fx_disown_selection_internal, Fx_selection_exists_p)
5473 (Fx_selection_owner_p, Fx_get_selection_internal):
5474 Sync docs and argument specs with the xselect.c versions.
5475
77abcbc2
LI
54762012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
5477
5478 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
5479
90b671e2
EZ
54802012-02-11 Eli Zaretskii <eliz@gnu.org>
5481
1c0ca0b7
EZ
5482 * w32select.c (Fx_selection_exists_p): Sync doc string and
5483 argument list with xselect.c. (Bug#10783)
5484
5485 * w16select.c (Fx_selection_exists_p): Sync doc string and
5486 argument list with xselect.c. (Bug#10783)
90b671e2 5487
49241268
GM
54882012-02-10 Glenn Morris <rgm@gnu.org>
5489
5490 * fns.c (Fsecure_hash): Doc fix.
5491
f998bbe7 54922012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
5493
5494 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
5495
0992bd9c
CY
54962012-02-07 Chong Yidong <cyd@gnu.org>
5497
5498 * buffer.c (Fbuffer_local_variables)
5499 (buffer_lisp_local_variables): Handle unbound vars correctly;
5500 don't let Qunbound leak into Lisp.
5501
af008560
GM
55022012-02-07 Glenn Morris <rgm@gnu.org>
5503
dd605cc4
GM
5504 * image.c (Fimagemagick_types): Doc fix.
5505
af008560
GM
5506 * image.c (imagemagick-render-type): Change it from a lisp object
5507 to an integer. Move the doc here from the lisp manual.
5508 Treat all values not equal to 0 the same.
5509
1449fa1d
CY
55102012-02-06 Chong Yidong <cyd@gnu.org>
5511
5512 * doc.c (store_function_docstring): Avoid applying docstring of
5513 alias to base function (Bug#2603).
5514
3723ec07
AS
55152012-02-04 Andreas Schwab <schwab@linux-m68k.org>
5516
5517 * .gdbinit (pp1, pv1): Remove redundant defines.
5518 (pr): Use pp.
5519
79c1cc1e
CY
55202012-02-04 Chong Yidong <cyd@gnu.org>
5521
5522 * nsterm.m: Declare a global (Bug#10694).
5523
d7f29f8e
EZ
55242012-02-04 Eli Zaretskii <eliz@gnu.org>
5525
cae07000
SM
5526 * w32.c (get_emacs_configuration_options):
5527 Include --enable-checking, if specified, in the return value.
d7f29f8e 5528
3b95a6f9
MR
55292012-02-04 Martin Rudalics <rudalics@gmx.at>
5530
5531 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
5532 after rounding frame sizes. (Bug#9723)
5533
d6fa96a6
EZ
55342012-02-04 Eli Zaretskii <eliz@gnu.org>
5535
5536 * keyboard.c (adjust_point_for_property): Don't position point
5537 before BEGV. (Bug#10696)
5538
df0b2940
PE
55392012-02-03 Paul Eggert <eggert@cs.ucla.edu>
5540
5541 Handle overflow when computing char display width (Bug#9496).
5542 * character.c (char_width): Return EMACS_INT, not int.
5543 (char_width, c_string_width): Check for overflow when
5544 computing the width; this is possible now that individual
5545 characters can have unbounded width. Problem introduced
5546 by merge from Emacs 23 on 2012-01-19.
5547
6bee44d6
MA
55482012-02-02 Michael Albinus <michael.albinus@gmx.de>
5549
5550 * dbusbind.c (Fdbus_register_method): Mention the return value
5551 :ignore in the docstring.
5552
44f92739
GM
55532012-02-02 Glenn Morris <rgm@gnu.org>
5554
1b9f60cc
GM
5555 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
5556
44f92739
GM
5557 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5558 Unconditionally set to t. (Bug#10673)
5559 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5560 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
5561 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
5562
c5d3843c
KH
55632012-02-02 Kenichi Handa <handa@m17n.org>
5564
5565 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
5566 0, do not call append_composite_glyph.
5567
159462d4 55682012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
5569
5570 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
5571 NULL (Bug#6988).
5572 (x_produce_glyphs): If the component of a composition is a null
5573 string, set it->pixel_width to 1 to avoid zero-width glyph.
5574
78cef877
EZ
55752012-02-01 Eli Zaretskii <eliz@gnu.org>
5576
5577 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
5578 first 2 arguments are identical. This makes inserting large
5579 output from a subprocess an order of magnitude faster on
5580 MS-Windows, where all sbrk'ed memory is always contiguous.
5581
97897668
GM
55822012-01-31 Glenn Morris <rgm@gnu.org>
5583
5584 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 5585 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
5586 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
5587
31fd3586
GM
55882012-01-29 Glenn Morris <rgm@gnu.org>
5589
5590 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
5591
0e24a8b2
CY
55922012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
5593
5594 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
5595
cc0adcb0
CY
55962012-01-28 Chong Yidong <cyd@gnu.org>
5597
5598 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
5599
acc28cb9
CY
56002012-01-26 Chong Yidong <cyd@gnu.org>
5601
9c69cfb7
CY
5602 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
5603
acc28cb9
CY
5604 * search.c (Fsearch_forward, Fsearch_backward): Document negative
5605 repeat counts (Bug#10507).
5606
48da7392
GM
56072012-01-26 Glenn Morris <rgm@gnu.org>
5608
5609 * lread.c (syms_of_lread): Doc fix.
5610
14af5f7f
CY
56112012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
5612
5613 * coding.c (encode_designation_at_bol): Change return value to
5614 EMACS_INT.
5615
0b21c100
CY
56162012-01-25 Chong Yidong <cyd@gnu.org>
5617
5618 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
5619
3c2907f7
CY
56202012-01-21 Chong Yidong <cyd@gnu.org>
5621
5622 * floatfns.c (Fcopysign): Make the second argument non-optional,
5623 since nil is not allowed anyway.
5624
959ad23f
AS
56252012-01-21 Andreas Schwab <schwab@linux-m68k.org>
5626
5627 * process.c (read_process_output): Use p instead of XPROCESS (proc).
5628 (send_process): Likewise.
5629
34a02f46
MR
56302012-01-19 Martin Rudalics <rudalics@gmx.at>
5631
5632 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
5633 (Vwindow_persistent_parameters): Do not use Qstate.
5634 Rewrite doc-strings.
34a02f46 5635
1259009a 56362012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
5637
5638 * character.c (char_width): New function.
70d4fdf6
GM
5639 (Fchar_width, c_string_width, lisp_string_width):
5640 Use char_width (Bug#9496).
25ed9e61 5641
6a6ee00d
MR
56422012-01-16 Martin Rudalics <rudalics@gmx.at>
5643
5644 * window.c (Vwindow_persistent_parameters): New variable.
5645 (Fset_window_configuration, save_window_save): Handle persistent
5646 window parameters.
5647
c85efaf7
EZ
56482012-01-14 Eli Zaretskii <eliz@gnu.org>
5649
5650 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
5651 thrashing the stack of the thread. (Bug#9087)
5652
5944709e
PE
56532012-01-12 Paul Eggert <eggert@cs.ucla.edu>
5654
5655 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
5656
e71f5d99
EZ
56572012-01-11 Eli Zaretskii <eliz@gnu.org>
5658
5659 * xdisp.c (rows_from_pos_range): Handle the case where the
5660 highlight ends on a newline. (Bug#10464)
5661 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
5662 he end column for display of highlight that ends on a newline
5663 before a R2L line.
5664
ce316182
GM
56652012-01-11 Glenn Morris <rgm@gnu.org>
5666
5667 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
5668 from load-path also when installation-directory is nil. (Bug#10208)
5669
5b43da69
GM
56702012-01-10 Glenn Morris <rgm@gnu.org>
5671
74cc8ff9
GM
5672 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
5673
7d8d6e4e
GM
5674 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
5675 Update template values to be closer to their typical values these days.
5b43da69 5676
a0db8d43
EZ
56772012-01-09 Eli Zaretskii <eliz@gnu.org>
5678
5679 * xdisp.c (rows_from_pos_range): Accept additional argument
5680 DISP_STRING, and accept any glyph in a row whose object is that
5681 string as eligible for mouse highlight. Fixes mouse highlight of
5682 display strings from overlays. (Bug#10464)
5683
9a0115ab 56842012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 5685
b9110d6a 5686 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
5687 * fileio.c (auto_saving_dir_umask): New static var.
5688 (Fmake_directory_internal): Use it.
5689 (do_auto_save_make_dir): Set it, instead of invoking chmod after
5690 creating the directory. The old code temporarily assigns
5691 too-generous permissions to the directory.
5692 (do_auto_save_eh): Clear it.
b9110d6a 5693 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
5694 that the var is always cleared.
5695
6c1bd3f3
EZ
56962012-01-07 Eli Zaretskii <eliz@gnu.org>
5697
5698 * search.c (scan_buffer): Pass character positions to
5699 know_region_cache, not byte positions. (Bug#6540)
5700
069d2b50
L
57012012-01-07 LynX <_LynX@bk.ru> (tiny change)
5702
5703 * w32.c (sys_rename): Report EXDEV when rename of a directory
5704 fails because the target is on another logical disk. (Bug#10284)
5705
75bf0d33
DB
57062012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
5707
5708 * xterm.c (x_embed_request_focus): New function.
5709
5710 * xterm.h: Add prototype.
5711
5712 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
5713
1c6e5a32
GM
57142012-01-05 Glenn Morris <rgm@gnu.org>
5715
5716 * emacs.c (emacs_copyright): Update short copyright year to 2012.
5717
651e947e
EZ
57182012-01-01 Eli Zaretskii <eliz@gnu.org>
5719
5720 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
5721 Load gnutls_transport_set_lowat only if GnuTLS version is below
5722 2.11.1.
5723 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
5724 GnuTLS versions below 2.11.1.
5725
3778cdd8
AL
57262011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
5727
5728 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
5729 to the doc string advising against its use for altering the way
5730 windows are scrolled.
5731
0e5317f7
KH
57322011-12-28 Kenichi Handa <handa@m17n.org>
5733
5734 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
5735 coding-system ASCII compatible only when it does not produce BOM
5736 on encoding (Bug#10383).
5737
93d5ca1f
JD
57382011-12-26 Jan Djärv <jan.h.d@swipnet.se>
5739
5740 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
5741 can scroll.
5742 (create_and_show_popup_menu): Always use menu_position_func for
5743 Gtk3 (Bug#10361).
5744
ca22b785
AS
57452011-12-24 Andreas Schwab <schwab@linux-m68k.org>
5746
5747 * callint.c (Fcall_interactively): Don't truncate prompt string.
5748
d048e1e6
EZ
57492011-12-23 Eli Zaretskii <eliz@gnu.org>
5750
5751 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
5752 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 5753 resumed from there (after widening). (Bug#10360)
d048e1e6 5754
5ccaba1f
JD
57552011-12-22 Jan Djärv <jan.h.d@swipnet.se>
5756
5757 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
5758
204ee57f
JD
57592011-12-21 Jan Djärv <jan.h.d@swipnet.se>
5760
b81d40f0
JB
5761 * nsterm.m (x_free_frame_resources):
5762 Release f->output_data.ns->miniimage.
204ee57f
JD
5763 (ns_index_color): Fix indentation. Do not retain
5764 color_table->colors[i].
5765
5766 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
5767 before returning.
5768
5769 * nsfns.m (x_set_background_color): Assign return value from
5770 ns_index_color to face-background instead of NSColor*.
5771 (ns_implicitly_set_icon_type): Fix indentation.
5772 Change assignment in for loop to comparison.
5773
5774 * emacs.c (ns_pool): New variable.
5775 (main): Assign ns_pool.
5776 (Fkill_emacs): Call ns_release_autorelease_pool.
5777
5778 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
5779 autorelease fdesc, release fdAttrs and tdict.
5780 (ns_get_covering_families): Release charset.
5781 (ns_findfonts): Release NSFontDescriptor created with new.
5782 (ns_uni_to_glyphs): Fix indentation.
5783 (setString): Release attrStr before assigning new value.
5784
c803b2b7
JD
57852011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5786
678f4426
JD
5787 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
5788 and NS_IMPL_COCOA.
5789 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
5790 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
5791
cd394be1 57922011-12-18 David Reitter <reitter@cmu.edu>
678f4426 5793
5fecd5fc
JD
5794 * nsterm.m (ns_term_init): Subscribe for notifications
5795 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
5796 to method trackingNotification in EmacsMenu.
5797
5798 * nsmenu.m (trackingMenu): New variable.
3771cb17 5799 (trackingNotification): New method (from Aquamacs).
5fecd5fc 5800 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 5801 from Aquamacs (Bug#7030).
678f4426
JD
5802
58032011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 5804
c803b2b7
JD
5805 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
5806 (symbol_to_nsstring): Fix indentation.
5807 (ns_symbol_to_pb): New function.
cae07000
SM
5808 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
5809 (Fns_rotate_cut_buffers_internal): Remove.
5810 (Fns_store_selection_internal): Rename from
c803b2b7
JD
5811 Fns_store_cut_buffer_internal.
5812 (ns_get_foreign_selection, Fx_own_selection_internal)
5813 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
5814 (Fns_get_selection_internal, Fns_store_selection_internal):
5815 Use ns_symbol_to_pb and check if return value is nil.
5816 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
5817 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
5818 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
5819 renamed to Sns_store_selection_internal.
5820 (ns_handle_selection_request): Move code to Fx_own_selection_internal
5821 and remove this function.
5822 (ns_handle_selection_clear): Remove, never used.
5823 (Fx_own_selection_internal): Move code from ns_handle_selection_request
5824 here.
5825
e1b01a3a
KB
58262011-12-17 Ken Brown <kbrown@cornell.edu>
5827
5828 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
5829 GID is unknown (Bug#10257).
5830
2adb6e85
PE
58312011-12-17 Paul Eggert <eggert@cs.ucla.edu>
5832
5833 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
5834 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
5835 which caused a build failure on GNU/Linux IA-64. This problem was
5836 introduced by my 2011-10-07 patch.
5837
d1d7b339
JL
58382011-12-15 Juri Linkov <juri@jurta.org>
5839
5840 * image.c (imagemagick_error): New function. (Bug#10112)
5841 (imagemagick_load_image): Comment out `MagickSetResolution' call.
5842 Use `imagemagick_error' where ImageMagick functions return
5843 `MagickFalse'.
5844 (Fimagemagick_types): Add `Fnreverse' to return the list in the
5845 proper order.
5846
100d5755
KH
58472011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5848
5849 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
5850 fill background (Bug#8992).
5851
454592a6
MR
58522011-12-13 Martin Rudalics <rudalics@gmx.at>
5853
5854 * window.c (Vwindow_combination_resize)
5855 (Vwindow_combination_limit): Use t instead of non-nil in
5856 doc-strings.
61d4b438
MR
5857 (Vrecenter_redisplay): Add first sentence of doc-string on
5858 separate line.
53524d93 5859 (Frecenter): Fix doc-string typo.
454592a6 5860
3633e3aa
KH
58612011-12-11 Kenichi Handa <handa@m17n.org>
5862
5863 * coding.c (Funencodable_char_position): Pay attention to the
5864 buffer text relocation (Bug#9389).
5865
7b9d523a 58662011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 5867
7b9d523a
JD
5868 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
5869 gtk_init (Bug#10100).
5870
b73189c6
EZ
58712011-12-10 Eli Zaretskii <eliz@gnu.org>
5872
5873 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
5874 IT->string is nil. (Bug#10263)
5875
f7dfe5d6
JD
58762011-12-10 Jan Djärv <jan.h.d@swipnet.se>
5877
83faebb4
JD
5878 * nsterm.h (x_free_frame_resources): Declare.
5879
f7dfe5d6
JD
5880 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
5881 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
5882
5883 * nsterm.h (ns_get_defaults_value): Declare.
5884
5885 * nsterm.m (ns_default): Call ns_get_defaults_value.
5886
7cd4e72c
EZ
58872011-12-09 Eli Zaretskii <eliz@gnu.org>
5888
5889 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
5890 (Bug#10170)
5891
b34d7317
YM
58922011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5893
5894 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
5895 that where the value of an _OBJC_* symbol points to is in the .bss
5896 section (Bug#10240).
5897
76470ad1
KH
58982011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5899
5900 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 5901 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 5902
745fff94
KH
59032011-12-08 Kenichi Handa <handa@m17n.org>
5904
5905 * ftfont.c (get_adstyle_property): Fix previous change
5906 (Bug#10233).
5907
6e44397c
JB
59082011-12-07 Juanma Barranquero <lekktu@gmail.com>
5909
5910 * w32.c (init_environment): If no_site_lisp, remove site-lisp
5911 dirs from the default value of EMACSLOADPATH (bug#10208).
5912
7efa6272
GM
59132011-12-07 Glenn Morris <rgm@gnu.org>
5914
5915 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
5916 installation and source directories as well. (Bug#10208)
5917
f6fc4d87
CY
59182011-12-06 Chong Yidong <cyd@gnu.org>
5919
5920 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
5921
2bf26180
GM
59222011-12-06 Glenn Morris <rgm@gnu.org>
5923
5924 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
5925 as an error, not just -1. (Bug#10217)
5926
3a6ad4f0
CY
59272011-12-05 Chong Yidong <cyd@gnu.org>
5928
5929 * keyboard.c (process_special_events): New function.
5930 (swallow_events, Finput_pending_p): Use it (Bug#10195).
5931
75a3b399
PE
59322011-12-05 Paul Eggert <eggert@cs.ucla.edu>
5933
5934 * coding.c (encode_designation_at_bol): Don't use uninitialized
5935 local variable (Bug#9318).
5936
c3c9e25e
KH
59372011-12-05 Kenichi Handa <handa@m17n.org>
5938
5939 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
5940 return Qnil (Bug#8046, Bug#10193).
5941
5eb05ea3
KH
59422011-12-05 Kenichi Handa <handa@m17n.org>
5943
5944 * coding.c (encode_designation_at_bol): New args charbuf_end and
5945 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
5946 (coding_set_source): Return how many bytes coding->source was
5947 relocated.
5948 (coding_set_destination): Return how many bytes
5949 coding->destination was relocated.
5950 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 5951 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
5952
59532011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5954
5955 * coding.c (CODING_CHAR_CHARSET_P): New macro.
5956 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
5957 macro (Bug#9318).
5958
59592011-12-05 Andreas Schwab <schwab@linux-m68k.org>
5960
5961 The following changes are to fix Bug#9318.
5962
a79703f5 5963 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
5964 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
5965 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 5966 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 5967
7dbda6df
JB
59682011-12-05 Juanma Barranquero <lekktu@gmail.com>
5969
5970 * lisp.h (process_quit_flag): Fix external declaration.
5971
6d5eb5b0
SM
59722011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
5973
5974 Don't macro-inline non-performance-critical code.
5975 * eval.c (process_quit_flag): New function.
5976 * lisp.h (QUIT): Use it.
5977
a0c3fad0
JD
59782011-12-04 Jan Djärv <jan.h.d@swipnet.se>
5979
5980 * nsfns.m (get_geometry_from_preferences): New function.
5981 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
5982
6c07aac2
AS
59832011-12-04 Andreas Schwab <schwab@linux-m68k.org>
5984
5985 * emacs.c (Qkill_emacs): Define.
5986 (syms_of_emacs): Initialize it.
5987 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
5988 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
5989 (quit_throw_to_read_char): Add parameter `from_signal'.
5990 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
5991 * lisp.h (QUIT): Call Fkill_emacs if requested.
5992
c052ead4
JD
59932011-12-03 Jan Djärv <jan.h.d@swipnet.se>
5994
5995 * widget.c (update_wm_hints): Return if wmshell is null.
5996 (widget_update_wm_size_hints): New function.
5997
5998 * widget.h (widget_update_wm_size_hints): Declare.
5999
6000 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
6001 widget_update_wm_size_hints (Bug#10104).
6002
9e49252b
EZ
60032011-12-03 Eli Zaretskii <eliz@gnu.org>
6004
6005 * xdisp.c (handle_invisible_prop): If the invisible text ends just
6006 before a newline, prepare the bidi iterator for consuming the
6007 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 6008 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 6009
02b16839
JL
60102011-12-02 Juri Linkov <juri@jurta.org>
6011
6012 * search.c (Fword_search_regexp): New Lisp function created from
6013 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
6014 (Fword_search_backward, Fword_search_forward)
6015 (Fword_search_backward_lax, Fword_search_forward_lax):
6016 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
6017 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
6018
0068070e
SM
60192011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
6020
6021 * fileio.c (Finsert_file_contents): Move after-change-function call
6022 to before the "handled:" label, since all "goto handled" appear in
6023 cases where the *-change-functions have already been properly called
6024 (bug#10117).
6025
3360a3fc
AS
60262011-12-01 Andreas Schwab <schwab@linux-m68k.org>
6027
6028 * keyboard.c (interrupt_signal): Don't call kill-emacs when
6029 waiting for input. (Bug#10169)
6030
73d6c093
EZ
60312011-11-30 Eli Zaretskii <eliz@gnu.org>
6032
6033 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
6034 verifies glyph row's hash code--we have just reallocated the
6035 glyphs, so their contents can be complete garbage. (Bug#10164)
6036
febe6bea
JB
60372011-11-30 Juanma Barranquero <lekktu@gmail.com>
6038
6039 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
6040
801a4313
EZ
60412011-11-30 Eli Zaretskii <eliz@gnu.org>
6042
6043 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
6044 attributes are tested _before_ calling verify_row_hash, to protect
6045 against GCC re-ordering of the tests. (Bug#10164)
6046
2b56b87e
JD
60472011-11-29 Jan Djärv <jan.h.d@swipnet.se>
6048
6049 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
6050
6051 * xterm.c (handle_one_xevent): Only set async_visible and friends
6052 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 6053 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
6054 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
6055
dbf31225
PE
60562011-11-28 Paul Eggert <eggert@cs.ucla.edu>
6057
6058 Remove GCPRO-related macros that exist only to avoid shadowing locals.
6059 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
6060 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
6061 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6062 All uses changed to use GCPRO1 etc.
6063 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
6064 Revert to old implementation (i.e., before 2011-03-11).
6065
1305621b
YM
60662011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6067
6068 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
6069 of scroll runs so as to avoid assigning disabled bogus rows and
6070 unnecessary graphics copy operations.
6071
8c9afb46
EZ
60722011-11-27 Eli Zaretskii <eliz@gnu.org>
6073
6074 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
6075 (snprintf) [_MSC_VER]: Redirect to _snprintf.
6076 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
6077 (malloc, free, realloc, calloc): Redirect to e_* only when
6078 compiling Emacs.
6079
6080 * lisp.h (GCTYPEBITS): Move before first use.
6081 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
6082 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
6083 this macro definition.
6084
6085 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
6086 _MSC_VER.
6087
54e9e3bf
JD
60882011-11-27 Jan Djärv <jan.h.d@swipnet.se>
6089
6d5eb5b0
SM
6090 * gtkutil.c (xg_create_frame_widgets):
6091 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
6092 present with Gtk+ 2.0.
6093
83aca1cb
PE
60942011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6095
6096 * fileio.c (Finsert_file_contents): Undo previous change; see
6097 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6098
5b76caa4
PE
60992011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6100
6101 Rename locals to avoid shadowing.
6102 * fileio.c (Finsert_file_contents):
6103 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
6104 * process.c (wait_reading_process_output):
6105 Rename inner 'proc' to 'p' to avoid shadowing.
6106 Indent for consistency with usual Emacs style.
6107
8c535114
EZ
61082011-11-25 Eli Zaretskii <eliz@gnu.org>
6109
6110 * xdisp.c (redisplay_window): If cursor row is not fully visible
6111 after recentering, and scroll-conservatively is set to a large
6112 number, scroll window by a few more lines to make the cursor fully
6113 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
6114 (start_display): Don't move to the next line if the display should
6115 start at a newline that is part of a display vector or an overlay
6116 string. (Bug#10119)
8c535114 6117
fa4fdb5c
JL
61182011-11-24 Juri Linkov <juri@jurta.org>
6119
6120 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
6121 after the `MagickPingImage' call. (Bug#10112)
6122
90ec88df
CY
61232011-11-23 Chong Yidong <cyd@gnu.org>
6124
6125 * window.c (Fcoordinates_in_window_p): Accept only live windows.
6126
56e2e794
MR
61272011-11-23 Martin Rudalics <rudalics@gmx.at>
6128
6129 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
6130 making another buffer current. (Bug#10114)
6131
b6e64c41
GM
61322011-11-23 Glenn Morris <rgm@gnu.org>
6133
6134 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
6135
6b21de18
CY
61362011-11-23 Chong Yidong <cyd@gnu.org>
6137
6138 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
6139 using it (Bug#5984).
6140
b12cd789
EZ
61412011-11-22 Eli Zaretskii <eliz@gnu.org>
6142
6143 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
6144 and header-lines, as they don't have one computed for them.
6145 (Bug#10098)
6146
6147 * .gdbinit (prow): Make displayed values more self-explaining.
6148 Add row's hash code.
6149
261b6fd4
LMI
61502011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
6151
6152 * process.c (wait_reading_process_output): Fix asynchrounous
6153 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 6154 (wait_reading_process_output): Add comment and URL.
261b6fd4 6155
e7cfd277
JD
61562011-11-21 Jan Djärv <jan.h.d@swipnet.se>
6157
6158 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
6159
a9b9b7f5
CY
61602011-11-21 Chong Yidong <cyd@gnu.org>
6161
6162 * window.c (Fnext_window, Fprevious_window): Doc fix.
6163
b0d15b4f
SM
61642011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6165
6166 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
6167
fe7a3057
JB
61682011-11-20 Juanma Barranquero <lekktu@gmail.com>
6169
6170 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
6171
d2999b1a
MR
61722011-11-20 Martin Rudalics <rudalics@gmx.at>
6173
6174 * window.c (Fset_window_combination_limit): Rename argument
6175 STATUS to LIMIT.
6176 (Vwindow_combination_limit): Remove "status" from doc-string.
6177
d5ff9cd0
AS
61782011-11-20 Andreas Schwab <schwab@linux-m68k.org>
6179
6180 * m/ibms390.h: Remove.
6181 * m/ibms390x.h: Don't include "ibms390.h".
6182
a5bb9bd3
SM
61832011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6184
6185 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
6186 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
6187
cd1181db
JB
61882011-11-20 Juanma Barranquero <lekktu@gmail.com>
6189
6190 * casetab.c (Fset_case_table):
6191 * charset.c (Fcharset_after): Fix typos.
6192
615a3b8d 61932011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 6194
17e845af
PE
6195 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
6196 Otherwise, valgrind does not work on some platforms.
6197 Problem reported by Andreas Schwab in
6a0bf43d
PE
6198 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
6199 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
6200 is set, removing the need for VIRT_ADDRESS_VARIES.
6201 (PURE_P): Use a more-efficient implementation that needs just one
6202 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
6203 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
6204 to 4 (xorl, subq, cmpq, setbe).
6205 * alloc.c (pure): Always extern now, since that's the
6206 VIRT_ADDR_VARIES behavior.
6207 (PURE_POINTER_P): Use a single comparison, not two, for
6208 consistency with the new puresize.h.
6209 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
6210 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
6211 Remove VIRT_ADDR_VARIES no longer needed.
6212
f8fe6f96
EZ
62132011-11-19 Eli Zaretskii <eliz@gnu.org>
6214
6215 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
6216 (erase_phys_cursor, update_window_cursor, show_mouse_face)
6217 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
6218 behave as if the cursor position were at the window margin.
6219
6220 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
6221 and the cursor position is out of bounds, behave as if the cursor
6222 position were at the window margin. (Bug#10075)
6223
df05a53c
CY
62242011-11-18 Chong Yidong <cyd@gnu.org>
6225
6226 * window.c (Fwindow_combination_limit): Make first argument
6227 non-optional, since it is meaningless for live windows like the
6228 selected window.
61ccba97 6229
2071918e
DA
62302011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
6231
6232 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
6233
b50a28de
SM
62342011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
6235
6236 * intervals.c: Fix grafting over the whole buffer (bug#10071).
6237 (graft_intervals_into_buffer): Simplify.
6238
015137db
EZ
62392011-11-18 Eli Zaretskii <eliz@gnu.org>
6240
6241 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
6242 hash values of the two rows.
6243 (copy_row_except_pointers): Preserve the used[] arrays and the
6244 hash values of the two rows. (Bug#10035)
68c95424 6245 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
6246
6247 * xdisp.c (row_hash): New function, body extracted from
6248 compute_line_metrics.
6249 (compute_line_metrics): Call row_hash, instead of computing the
6250 hash code inline.
6251
6252 * dispnew.c (verify_row_hash): Call row_hash for computing the
6253 hash code of a row, instead of duplicating code from xdisp.c.
6254
6255 * dispextern.h (row_hash): Add prototype.
6256
a2addb04
TH
62572011-11-18 Tassilo Horn <tassilo@member.fsf.org>
6258
6259 * frame.c (delete_frame): Don't delete the terminal when the last
6260 X frame is closed if emacs is built with GTK toolkit.
6261
df85d315
JB
62622011-11-17 Juanma Barranquero <lekktu@gmail.com>
6263
6264 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
6265
a0c2d0ae
MR
62662011-11-17 Martin Rudalics <rudalics@gmx.at>
6267
6268 * window.c (Vwindow_splits): Rename to
6269 Vwindow_combination_resize. Suggested by Juri Linkov.
6270 (Fsplit_window_internal): Use Vwindow_combination_resize instead
6271 of Vwindow_splits.
6272
58179cce
JB
62732011-11-16 Juanma Barranquero <lekktu@gmail.com>
6274
7877f373
JB
6275 * nsfns.m (Fns_font_name):
6276 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 6277
b6f67890
MR
62782011-11-16 Martin Rudalics <rudalics@gmx.at>
6279
6280 * window.h (window): Rename slot "nest" to "combination_limit".
6281 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
6282 (Fset_window_nest): Rename to Fset_window_combination_limit.
6283 (Vwindow_nest): Rename to Vwindow_combination_limit.
6284 (recombine_windows, make_parent_window, make_window)
6285 (Fsplit_window_internal, saved_window)
6286 (Fset_window_configuration, save_window_save): Rename all
6287 occurrences of window_nest to window_combination_limit.
6288
c7015153
JB
62892011-11-15 Juanma Barranquero <lekktu@gmail.com>
6290
6291 * image.c (imagemagick_load_image): Fix typo.
6292
322ad6ec
EZ
62932011-11-14 Eli Zaretskii <eliz@gnu.org>
6294
6295 * xdisp.c (display_line): Move the call to
6296 highlight_trailing_whitespace before the call to
6297 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
6298 faces of all the glyphs to compute ROW's hash value.
6299 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 6300
f067b8ec
JB
63012011-11-14 Juanma Barranquero <lekktu@gmail.com>
6302
6303 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
6304 just return (bug#10044).
6305
1e5b2111
EZ
63062011-11-12 Eli Zaretskii <eliz@gnu.org>
6307
7ef3cbd5
EZ
6308 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
6309 with user-defined heap size. Bump the default size of the temacs
6310 heap to 27MB, to avoid memory warning when running temacs.
6311 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
6312
1e5b2111
EZ
6313 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
6314 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
6315 (verify_row_hash) [XASSERTS]: New function.
6316 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
6317 that the hash value of glyph rows is correct.
1e5b2111 6318
89d61221
MR
63192011-11-12 Martin Rudalics <rudalics@gmx.at>
6320
6321 * window.h (window): Remove splits slot.
6322 * window.c (Fwindow_splits, Fset_window_splits): Remove.
6323 (Fdelete_other_windows_internal, make_parent_window)
6324 (make_window, Fsplit_window_internal, Fdelete_window_internal)
6325 (Fset_window_configuration, save_window_save): Don't deal with
6326 split status of windows.
6327 (saved_window): Remove splits slot.
6328 (Vwindow_splits): Rewrite doc-string.
6329
97f18cc8
JD
63302011-11-11 Jan Djärv <jan.h.d@swipnet.se>
6331
6332 * xfns.c (unwind_create_frame):
6333 * nsfns.m (unwind_create_frame):
6334 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
6335 Vframe_list (Bug#9999).
6336
22a648b4
DA
63372011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
6338
0b381c7e 6339 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 6340
659afede
KH
63412011-11-11 Kenichi Handa <handa@m17n.org>
6342
6343 * callproc.c (Fcall_process): Set the member dst_multibyte of
6344 process_coding.
6345
9ac0394b
KH
63462011-11-11 Johan Bockgård <bojohan@gnu.org>
6347
6348 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
6349 avoid a crash (bug#9496).
6350
2fbdc249
CY
63512011-11-09 Chong Yidong <cyd@gnu.org>
6352
6353 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
6354 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
6355
ac6b1f81
PE
63562011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6357
6358 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
6359
09db192c
PE
63602011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6361
6362 Avoid some portability problems by eschewing 'extern inline' functions.
6363 The trivial performance wins aren't worth the portability hassles; see
6364 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
6365 et seq.
6366 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6367 (window_box_width, window_box_left, window_box_left_offset)
6368 (window_box_right, window_box_right_offset): Undo previous change,
6369 by removing the "extern"s.
6370 * intervals.c (adjust_intervals_for_insertion)
6371 (adjust_intervals_for_deletion): Undo previous change,
6372 making these static again.
6373 (offset_intervals, temp_set_point_both, temp_set_point)
6374 (copy_intervals_to_string): No longer inline.
6375 * xdisp.c (window_text_bottom_y, window_box_width)
6376 (window_box_height, window_box_left_offset)
6377 (window_box_right_offset, window_box_left, window_box_right)
6378 (window_box): No longer inline.
6379
105216ed
CY
63802011-11-08 Chong Yidong <cyd@gnu.org>
6381
6382 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
6383 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
6384 Signal an error if not a live window.
105216ed
CY
6385 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
6386 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
6387
ae9e237f
JB
63882011-11-07 Juanma Barranquero <lekktu@gmail.com>
6389
6390 * lisp.h (syms_of_abbrev): Remove declaration.
6391 Reported by CHENG Gao <chenggao@royau.me>.
6392
c7aa8333
EZ
63932011-11-07 Eli Zaretskii <eliz@gnu.org>
6394
6395 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
6396 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
6397 of temacs in GUI mode.
6398
be7f5545
MR
63992011-11-07 Martin Rudalics <rudalics@gmx.at>
6400
6401 * window.h: Declare delete_all_child_windows instead of
6402 delete_all_subwindows.
6403 * window.c (Fwindow_nest, Fset_window_nest)
6404 (Fset_window_new_total, Fset_window_new_normal)
6405 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
6406 (delete_all_subwindows): Rename to delete_all_child_windows.
6407 (Fdelete_other_windows_internal, Fset_window_configuration):
6408 Call delete_all_child_windows instead of delete_all_subwindows.
6409 * frame.c (delete_frame): Call delete_all_child_windows instead
6410 of delete_all_subwindows.
6411
ca78dc43
PE
64122011-11-07 Paul Eggert <eggert@cs.ucla.edu>
6413
6414 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
6415 This is also needed for porting to any host where GC_MARK_STACK is
6416 not GC_MAKE_GCPROS_NOOPS.
6417 (which_symbols): Use it.
6418
a0241d01
KH
64192011-11-07 Kenichi Handa <handa@m17n.org>
6420
6421 * coding.c (coding_set_destination): Check coding->src_pos only
6422 when coding->src_object is a buffer (bug#9910).
6423
6424 * process.c (send_process): Set the member src_multibyte of coding
6425 to 0 (bug#9911) when sending a unibyte text.
6426
6427 * callproc.c (Fcall_process): Set the member src_multibyte of
6428 process_coding to 0 (bug#9912).
6429
a64bfdfa 64302011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
6431
6432 * xmenu.c (cleanup_widget_value_tree): New function.
6433 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
6434 calling free_menubar_widget_value_tree directly (Bug#9830).
6435
cb41b32a
PE
64362011-11-06 Paul Eggert <eggert@cs.ucla.edu>
6437
6438 Fix some portability problems with 'inline'.
6439 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6440 (window_box_width, window_box_left, window_box_left_offset)
6441 (window_box_right, window_box_right_offset): Declare extern.
6442 Otherwise, these inline functions do not conform to C99 and
6443 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
6444 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
6445 * intervals.c (adjust_intervals_for_insertion)
6446 (adjust_intervals_for_deletion): Now extern, because otherwise the
6447 extern inline functions 'offset_intervals' couldn't refer to it.
6448 (static_offset_intervals): Remove.
6449 (offset_intervals): Rewrite using the old contents of
6450 static_offset_intervals. The old version didn't conform to C99
6451 because an extern inline function contained a reference to an
6452 identifier with static linkage.
6453
b7041366
AS
64542011-11-06 Andreas Schwab <schwab@linux-m68k.org>
6455
6456 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
6457 GC.
6458
88a37c4d
EZ
64592011-11-06 Eli Zaretskii <eliz@gnu.org>
6460
6461 * xdisp.c (init_iterator, reseat_to_string): Don't set the
6462 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
6463 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
6464 return Qleft_to_right.
6465
49745b39
CY
64662011-11-06 Chong Yidong <cyd@gnu.org>
6467
6468 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
6469 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
6470 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
6471 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
6472 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
6473 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
6474 (Fwindow_vscroll): Doc fix.
6475 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
6476 argument, since it makes no sense to pass a live window and for
6477 consistency with window-child.
6478
1f05cd82
CS
64792011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
6480
6481 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
6482 support MSVC.
6483
22610910
JR
64842011-11-05 Jason Rumney <jasonr@gnu.org>
6485
6486 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
6487 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
6488 fonts (Bug#6029).
6489 (add_font_entity_to_list): Fix logic errors in mixed boolean and
6490 bitwise arithmetic preventing use of unicode-sip and non-truetype
6491 opentype fonts.
6492
a06776b2
EZ
64932011-11-05 Eli Zaretskii <eliz@gnu.org>
6494
3ad924ba
EZ
6495 * s/ms-w32.h (fstat, stat, utime): Move redirections to
6496 "emacs"-only part.
6497
a06776b2
EZ
6498 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
6499 initialization code to keep similarity to xfns.c after changes
6500 from 2011-11-05.
6501
c9e7db78
JD
65022011-11-05 Jan Djärv <jan.h.d@swipnet.se>
6503
a97f8f3f
JD
6504 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
6505 (unwind_create_frame): New function (Bug#9943).
6506 (Fx_create_frame): Restructure code to be more similar to the one in
6507 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
6508 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
6509 Move terminal->reference_count++ just before making the frame official
6510 (Bug#9943).
6511
6512 * nsterm.m (x_free_frame_resources): New function.
6513 (x_destroy_window): Move code to x_free_frame_resources.
6514
c9e7db78 6515 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
6516 (Fx_create_frame, x_create_tip_frame):
6517 Move terminal->reference_count++ just before making the frame
75f1671a 6518 official. Move initialization of image_cache_refcount and
c9e7db78
JD
6519 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
6520
a6fc3b5c
EZ
65212011-11-05 Eli Zaretskii <eliz@gnu.org>
6522
6523 Support MSVC build with newer versions of Visual Studio.
6524 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
6525 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
6526 nt/gmake.defs.
6527
6528 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
6529 which are not supported by MSVC.
6530 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
6531 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
6532 bitfields.
6533 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
6534 types in bitfields.
6535 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
6536
6537 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
6538
58179cce 65392011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
6540
6541 Support MSVC build with newer versions of Visual Studio.
6542 * w32.c: Don't include w32api.h for MSVC.
6543 (init_environment) [_MSC_VER]: Call sys_access, not _access.
6544
6545 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
6546 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
6547 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
6548 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
6549 e_* cousins.
6550 (alloca) [_MSC_VER]: Define to _alloca.
6551
6552 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
6553
6554 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
6555
a58c13ed
EZ
65562011-11-04 Eli Zaretskii <eliz@gnu.org>
6557
6558 * xdisp.c (note_mouse_highlight): If either of
6559 previous/next-single-property-change returns nil, treat that as
6560 the beginning or the end of the buffer. (Bug#9955)
6561
fe0b6370
JD
65622011-11-04 Jan Djärv <jan.h.d@swipnet.se>
6563
a58c13ed 6564 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
6565 label is not null (Bug#9951).
6566 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
6567 may be NULL.
6568
89bd5ee1
EZ
65692011-11-04 Eli Zaretskii <eliz@gnu.org>
6570
6571 * window.c (Fwindow_body_size): Mention in the doc string that the
6572 return value is in frame's canonical units. (Bug#9949)
6573
84c3edb9
EZ
65742011-11-03 Eli Zaretskii <eliz@gnu.org>
6575
4e2fb5c7
EZ
6576 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
6577
84c3edb9 6578 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 6579 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 6580 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 6581
bc17a887
EZ
65822011-11-01 Eli Zaretskii <eliz@gnu.org>
6583
6584 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
6585 Don't stop backward scan on the continuation glyph, even though
6586 its CHARPOS is positive.
6d5eb5b0
SM
6587 (mouse_face_from_buffer_pos, note_mouse_highlight):
6588 Rename cover_string to disp_string.
bc17a887 6589
4ee88440
MR
65902011-11-01 Martin Rudalics <rudalics@gmx.at>
6591
6592 * window.c (temp_output_buffer_show): Don't use
6593 Vtemp_buffer_show_specifiers.
6594 (Vtemp_buffer_show_specifiers): Remove unused variable.
6595
c2ff3c02
EZ
65962011-10-30 Eli Zaretskii <eliz@gnu.org>
6597
6598 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
6599 past the beginning of the current glyph matrix.
6600
58179cce 66012011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
6602
6603 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
6604 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
6605 HAVE_GTK3 (Bug#9869).
b77a6a7f 6606
3b574623
JD
6607 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
6608 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
6609
b77a6a7f
JD
6610 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
6611
6612 * xterm.c: Declare x_handle_net_wm_state to return int.
6613 (handle_one_xevent): Check if we are iconified but don't have
6614 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
6615 (get_current_wm_state): Return non-zero if not hidden,
6616 check for _NET_WM_STATE_HIDDEN (Bug#9893).
6617 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
6618 (x_handle_net_wm_state): Return what get_current_wm_state returns.
6619 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
6620
196e41e4
PE
66212011-10-29 Paul Eggert <eggert@cs.ucla.edu>
6622
6623 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
6624 so that this new function doesn't get optimized away by a
6625 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
6626
021f2e1a
AS
66272011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6628
6629 * frame.h (MOUSE_HL_INFO): Remove excess parens.
6630
8b058d44
EZ
66312011-10-29 Eli Zaretskii <eliz@gnu.org>
6632
6633 Fix the `xbytecode' command.
6634 * .gdbinit (xprintbytestr): New command.
b50a28de 6635 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
6636 (xbytecode): Print the byte-code string as well.
6637
4452fb80
EZ
66382011-10-29 Kim Storm <storm@cua.dk>
6639
8b058d44
EZ
6640 * alloc.c (which_symbols): New function.
6641
21b72067
AS
66422011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6643
6644 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
6645 line. (Bug#9903)
6646
83ed7b5c
GM
66472011-10-29 Glenn Morris <rgm@gnu.org>
6648
6649 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
6650 Not clear what it was for, and it causes various bugs. (Bug#9839)
6651
5a7a728b
EZ
66522011-10-28 Eli Zaretskii <eliz@gnu.org>
6653
6654 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
6655 possible random value that matches one of those tested as
6656 condition to clear the mouse face.
6657
d3d0842f
CY
66582011-10-28 Chong Yidong <cyd@gnu.org>
6659
6660 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
6661
31b39d13
DN
66622011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
6663
6664 * window.c (make_window): Initialize phys_cursor_on_p.
6665
9aba6043
SM
66662011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
6667
6668 * lisp.h (struct Lisp_Symbol): Update comments.
6669
c20992f4
JB
66702011-10-28 Juanma Barranquero <lekktu@gmail.com>
6671
6672 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
6673
db4f02f2
EZ
66742011-10-28 Eli Zaretskii <eliz@gnu.org>
6675
6676 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
6677 <oslsachem@gmail.com> for helping to debug this.
6678
6679 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
6680 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
6681 (g_b_init_get_glyph_outline_w): New static variables.
6682 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
6683 (GetGlyphOutlineW_Proc): New typedefs.
6684 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
6685 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
6686 New functions.
6687 (w32font_open_internal, compute_metrics):
6688 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
6689 instead of calling the "wide" APIs directly.
6690
6691 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
6692
6693 * w32.h (syms_of_w32font): Add prototype.
6694
87e68db4
JB
66952011-10-27 Juanma Barranquero <lekktu@gmail.com>
6696
6697 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
6698 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
6699 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
6700 (Fmove_to_window_line): Doc fix.
6701
435c1d67
CY
67022011-10-27 Chong Yidong <cyd@gnu.org>
6703
6704 * process.c (make_process): Set gnutls_state to NULL.
6705
6706 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
6707 non-NULL, regardless of GNUTLS_INITSTAGE.
6708 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
6709 an error. Set process slots as soon as we allocate them.
6710
6711 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
6712
9c6c6f49
CY
67132011-10-27 Chong Yidong <cyd@gnu.org>
6714
9aba6043
SM
6715 * gnutls.c (emacs_gnutls_deinit): New function.
6716 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
6717 (Fgnutls_deinit, Fgnutls_boot): Use it.
6718
6719 * process.c (make_process): Initialize GnuTLS credentials to NULL.
6720 (deactivate_process): Call emacs_gnutls_deinit.
6721
657d08d3
JB
67222011-10-27 Juanma Barranquero <lekktu@gmail.com>
6723
6724 * image.c (x_create_x_image_and_pixmap):
6725 * w32.c (sys_rename, w32_delayed_load):
6726 * w32font.c (fill_in_logfont):
6727 * w32reg.c (x_get_string_resource): Silence compiler warnings.
6728
5430d399
JB
67292011-10-26 Juanma Barranquero <lekktu@gmail.com>
6730
6731 * w32fns.c (w32_default_color_map): New function,
6732 extracted from Fw32_default_color_map.
a7ef684b 6733 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 6734
fe0055fa
PE
67352011-10-25 Paul Eggert <eggert@cs.ucla.edu>
6736
6737 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
6738
e6346438
SM
67392011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
6740
6741 * keyboard.c (test_undefined): New function (bug#9751).
6742 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
6743
e112cc37
ET
67442011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
6745
6746 * sysdep.c (init_sys_modes): Fix the check for the controlling
6747 terminal (Bug#6649).
6748
7b5d6677
EZ
67492011-10-20 Eli Zaretskii <eliz@gnu.org>
6750
6751 * dispextern.h (struct bidi_it): New member next_en_type.
6752
6753 * bidi.c (bidi_line_init): Initialize the next_en_type member.
6754 (bidi_resolve_explicit_1): When next_en_pos is valid for the
6755 current character, check also for next_en_type being WEAK_EN.
6756 (bidi_resolve_weak): Don't enter the expensive loop if the current
6757 position is before next_en_pos. Record the bidi type of the first
6758 non-ET, non-BN character we find, in addition to its position.
6759 (bidi_level_of_next_char): Invalidate next_en_type when
6760 next_en_pos is over-stepped.
6761
7da0b018
PE
67622011-10-20 Paul Eggert <eggert@cs.ucla.edu>
6763
6764 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
6765 * editfns.c: Rewrite current-time-zone so that it invokes
6766 the equivalent of (format-time-string "%Z") to get the time zone name.
6767 This fixes a bug when the time zone name contains characters that
6768 need converting from the system time locale to Emacs internal format.
6769 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
6770 that patch fixed format-time-string to do the conversion, but
6771 I forgot to fix current-time-zone.
6772 (format_time_string): New function, containing most of
6773 what Fformat_time_string used to contain.
6774 (Fformat_time_string): Rewrite in terms of format_time_string.
6775 This doesn't change this function's behavior.
6776 (current-time-zone): Rewrite to use format_time_string.
6777 This fixes the bug reported by Michael Schierl in
6778 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
6779 Jason Rumney's 2007-06-07 change worked around this bug, but
6780 didn't fix it.
6781 * systime.h (tzname, timezone): Remove no-longer-used declarations.
6782
8547b010
EZ
67832011-10-19 Eli Zaretskii <eliz@gnu.org>
6784
6785 * xdisp.c (start_display): If the character at POS is displayed
6786 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
6787 (try_window_reusing_current_matrix): If a line ends in a display
6788 vector or the next line starts in a display vector, continue
6789 redrawing the window even though the character position of
6790 start_row was reached.
8547b010
EZ
6791 (Bug#9771, part 2)
6792
4e948d15
CY
67932011-10-18 Chong Yidong <cyd@gnu.org>
6794
6795 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
6796 with nobreak-char-display too.
6797
4787455f
EZ
67982011-10-18 Eli Zaretskii <eliz@gnu.org>
6799
6800 Fix part 3 of bug#9771.
6801 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
6802 (bidi_resolve_neutral): Don't enter the expensive loop looking for
6803 non-neutral characters if the current character is a paragraph
6804 separator (a.k.a. Newline). This avoids running the same
6805 expensive loop twice, once when we consume the preceding newline
6806 and the other time when the line actually needs to be displayed.
6807 Avoid the loop when we see neutrals on the base embedding level
6808 following a character whose directionality is the same as the
6809 paragraph's. This avoids running the expensive loop when a line
6810 ends in a long sequence of neutrals, like control characters.
6811 Add assertion against STRONG_AL type. Slightly rearrange code
6812 that determines the type of a neutral given the first non-neutral
6813 that follows it.
6814 (bidi_level_of_next_char): Set next_en_pos to zero when
6815 invalidating its info.
6816
2c91f553
EZ
68172011-10-17 Eli Zaretskii <eliz@gnu.org>
6818
6819 * xdisp.c (push_display_prop): Determine whether to record string
6820 or buffer position by IT->string, not by IT->method. Allow
6821 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
6822 (move_it_vertically_backward): Don't look for character position
6823 immediately after the newline when in a continuation line.
6824 (Bug#9771, part 1)
2c91f553 6825
c7b08b0d
MR
68262011-10-15 Martin Rudalics <rudalics@gmx.at>
6827
6828 * window.c (coordinates_in_window): Rewrite and delabelize
6829 vertical border check. (Bug#5357) (Bug#9618)
6830
6b02f655
SM
68312011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
6832
6833 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
6834 errors in XSetWindowBorder (bug#9310).
6835
81d40c92
DA
68362011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
6837
6838 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
6839 avoid crash when xmalloc overrun checking is enabled.
6840
d4172c3b
EZ
68412011-10-13 Eli Zaretskii <eliz@gnu.org>
6842
6843 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
6844 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
6845 cursor motion with <left> and <right> arrow keys.
6846
6847 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
6848 some callers set that themselves.
6849
b00eea75
EZ
68502011-10-12 Eli Zaretskii <eliz@gnu.org>
6851
6852 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
6853 display string and the previous row comes from the same string and
6854 is empty. (Bug#9739) (Bug#9738)
6855
8fe012c4
SM
68562011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
6857
6858 * doc.c (get_doc_string): Encode file name (bug#9735).
6859
0074aef2
EZ
68602011-10-12 Eli Zaretskii <eliz@gnu.org>
6861
79beb178
EZ
6862 * bidi.c (bidi_level_of_next_char):
6863 * xdisp.c (get_visually_first_element): Remove old incorrect
6864 comments regarding the Unicode Line Separator character.
6865
0074aef2
EZ
6866 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
6867
6e4b3fbe
DA
68682011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
6869
6870 * alloc.c (Fgc_status): Do not access beyond zombies array
6871 boundary if nzombies > MAX_ZOMBIES.
6872 * alloc.c (dump_zombies): Add missing format specifier.
6873
0324f3af
PE
68742011-10-12 Paul Eggert <eggert@cs.ucla.edu>
6875
b5525cac
PE
6876 * xdisp.c (set_cursor_from_row): Simplify conditionals,
6877 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
6878
0324f3af
PE
6879 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
6880 Some packages use them to denote characters with modifiers.
6881
e9b5f888
AS
68822011-10-11 Andreas Schwab <schwab@linux-m68k.org>
6883
6884 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
6885 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
6886 matching a pp-number. Rename parameter var to var1.
6887
127827c0
SM
68882011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
6889
6890 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
6891
c8fd3bd0
GM
68922011-10-08 Glenn Morris <rgm@gnu.org>
6893
6894 * callint.c (Fcall_interactively): Give a more explicit error for the
6895 'c' case with a non-character input. (Bug#8479)
6896
352ec8ff
EZ
68972011-10-08 Eli Zaretskii <eliz@gnu.org>
6898
03669ccb
EZ
6899 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
6900 lines.
7061c986
EZ
6901 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
6902 lines that are hscrolled on the left.
03669ccb 6903
352ec8ff
EZ
6904 * dispnew.c (buffer_posn_from_coords): Account for a possible
6905 presence of header-line. (Bug#4426)
6906
a66cfb1c
SM
69072011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
6908
6b02f655
SM
6909 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
6910 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 6911
7c5ee88e
PE
69122011-10-07 Paul Eggert <eggert@cs.ucla.edu>
6913
6914 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
6915 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
6916 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
6917 this makes Emacs dump core during garbage collection on rare
6918 occasions. sizeof is obviously inferior to offsetof here, so
6919 stick with offsetof.
6920 (GC_POINTER_ALIGNMENT): New macro.
6921 (mark_memory): Omit 3rd (offset) arg; caller changed.
6922 Don't assume EMACS_INT alignment is the same as pointer alignment.
6923
df1bbe5b
SM
69242011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
6925
6926 * keyboard.c (read_key_sequence_remapped): New var.
6927 (read_key_sequence): Compute remapping in the right buffer.
6928 (command_loop_1): Use read_key_sequence's remapping directly.
6929
51553db6
SM
69302011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
6931
32c1fffd
SM
6932 * dired.c (file_name_completion): Don't expand file name.
6933 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
6934 before checking file name handler.
6935
51553db6
SM
6936 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
6937 they've been requested explicitly (bug#9591).
6938
b6bd1599 69392011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
6940
6941 * keymap.c (Fsingle_key_description): Use make_specified_string
6942 instead of build_string to build string from push_key_description.
6943 (Bug#5193)
6944
f701dc2a
PE
69452011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6946
4222c55d
PE
6947 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
6948 This fixes a Y2038 bug on 64-bit hosts.
6949 * buffer.c (reset_buffer):
6950 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
6951 (Fclear_buffer_auto_save_failure):
6952 Use 0, not -1, to represent an unset failure time, since time_t
6953 might not be signed.
6954
f701dc2a
PE
6955 Remove dependency on glibc malloc internals.
6956 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6957 Move back here from lisp.h, but with their new implementations.
6958 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6959 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
6960 * charset.c (charset_table_init): New static var.
6961 (syms_of_charset): Use it instead of xmalloc. This removes a
6962 dependency on glibc malloc internals. See Eli Zaretskii's comment in
6963 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
6964 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6965 Move back to alloc.c.
6966 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6967 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
6968
9ceebf39
JD
69692011-09-30 Jan Djärv <jan.h.d@swipnet.se>
6970
6971 * nsterm.m (windowDidResize): Call x_set_window_size only when
6972 ns_in_resize is true. Otherwise set pixelwidth/height and
6973 call change_frame_size (Bug#9628).
6974
cb993c58
PE
69752011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6976
3930c88b
PE
6977 Port --enable-checking=all to Fedora 14 x86-64.
6978 * charset.c (syms_of_charset): Also account for glibc malloc's
6979 internal overhead when calculating the initial malloc maximum.
6980
cb993c58
PE
6981 Port --enable-checking=all to Fedora 14 x86.
6982 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6983 Move to lisp.h.
6984 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
6985 (overrun_check_realloc, overrun_check_free):
6986 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
6987 That way, xmalloc returns a properly-aligned pointer even if
6988 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
6989 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
6990 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
6991 into account when calculating the initial malloc maximum.
6992 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6993 Move here from alloc.c, so that charset.c can use it too.
6994 Properly align; the old code wasn't right for common 32-bit hosts
6995 when configured with --enable-checking=all.
6996 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6997 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
6998
31bed486
EZ
69992011-09-29 Eli Zaretskii <eliz@gnu.org>
7000
04c70788 7001 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
7002 use EDOM.
7003
fbcaa2f3
EZ
70042011-09-28 Eli Zaretskii <eliz@gnu.org>
7005
7006 * xdisp.c (compute_display_string_end): If there's no display
7007 string at CHARPOS, return -1.
7008
7009 * bidi.c (bidi_fetch_char): When compute_display_string_end
7010 returns a negative value, treat the character as a normal
7011 character not covered by a display string. (Bug#9624)
7012
a239d4e9
JB
70132011-09-28 Juanma Barranquero <lekktu@gmail.com>
7014
7015 * lread.c (Fread_from_string): Fix typo in docstring.
7016
88652fd5
EZ
70172011-09-27 Eli Zaretskii <eliz@gnu.org>
7018
7019 * xdisp.c (handle_invisible_prop): If invisible text ends on a
7020 newline, reseat the iterator instead of bidi-iterating there one
7021 character at a time. (Bug#9610)
32c1fffd
SM
7022 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
7023 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 7024
ed497dd4
AS
70252011-09-27 Andreas Schwab <schwab@linux-m68k.org>
7026
7027 * lread.c (readevalloop): Use correct code for NBSP.
7028 (read1): Likewise. (Bug#9608)
7029
b2bf61aa
MA
70302011-09-25 Michael Albinus <michael.albinus@gmx.de>
7031
7032 * dbusbind.c (Fdbus_register_signal): When service is not
7033 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
7034
32bbb17c
GM
70352011-09-25 Glenn Morris <rgm@gnu.org>
7036
7037 * buffer.c (truncate-lines): Doc fix.
7038
94e0933e
CY
70392011-09-24 Chong Yidong <cyd@stupidchicken.com>
7040
7041 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
7042 (Fset_window_next_buffers): Doc fix.
7043
cddde921
GM
70442011-09-24 Glenn Morris <rgm@gnu.org>
7045
7046 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
7047
1260aef1
PE
70482011-09-24 Paul Eggert <eggert@cs.ucla.edu>
7049
25b4bfa0
PE
7050 Fix minor problems found by static checking.
7051 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
7052 * indent.c (Fvertical_motion): Fix == vs = typo.
7053
e3cbd34b
EZ
70542011-09-24 Eli Zaretskii <eliz@gnu.org>
7055
a66cfb1c
SM
7056 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
7057 Default value is now t. Doc fix.
6bf7006f 7058
e3cbd34b 7059 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 7060 logic when moving up, not only when moving down. Fix the
e3cbd34b 7061 confusing name and values of the it_overshoot_expected variable;
32c1fffd 7062 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
7063
7064 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
7065 CHARPOS is covered by a display string which includes newlines.
7066 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
7067 is covered by a display string with embedded newlines.
7068
a3de0cbd
MA
70692011-09-24 Michael Albinus <michael.albinus@gmx.de>
7070
7071 * dbusbind.c (Fdbus_register_signal): Add match rule to
7072 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
7073 (Fdbus_register_method, Vdbus_registered_objects_table):
7074 Fix docstring.
a3de0cbd 7075
b260039d
JM
70762011-09-24 Jim Meyering <meyering@redhat.com>
7077
32c1fffd 7078 do not ignore write error for any output size
b260039d
JM
7079 The previous change was incomplete.
7080 While it makes emacs --batch detect the vast majority of stdout
7081 write failures, errors were still ignored whenever the output size is
7082 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
7083 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
7084 && echo FAIL: ignored write error
7085 FAIL: ignored write error
7086 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
7087 && echo FAIL: ignored write error
7088 FAIL: ignored write error
7089 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
7090
8eca8a7c
AS
70912011-09-23 Andreas Schwab <schwab@linux-m68k.org>
7092
7093 * emacs.c (Fkill_emacs): In noninteractive mode exit
7094 non-successfully if a write error occurred on stdout. (Bug#9574)
7095
3341db62
EZ
70962011-09-21 Eli Zaretskii <eliz@gnu.org>
7097
7098 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
7099 the xassert test.
7100
7101 * dispextern.h (struct it): Update the comment documenting what
7102 can it->OBJECT be.
7103
8c203dbf
EZ
71042011-09-20 Eli Zaretskii <eliz@gnu.org>
7105
7106 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
7107 a display string, extend search for cursor position to end of row.
7108 (find_row_edges): If the row ends in a newline from a display
7109 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
7110 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
7111 (Fcurrent_bidi_paragraph_direction): Fix search for previous
7112 non-empty line. Fixes confusing cursor motion with arrow keys at
7113 the beginning of a line that starts with whitespace.
8c203dbf 7114
a4824228
LMI
71152011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7116
7117 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
7118 (bug#9493).
7119
33ed493b
CY
71202011-09-18 Chong Yidong <cyd@stupidchicken.com>
7121
7122 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
7123 boolean (Bug#9154).
7124
56cd55c8
EZ
71252011-09-18 Eli Zaretskii <eliz@gnu.org>
7126
7127 * xdisp.c (display_line): Record maximum and minimum buffer
7128 positions even if no glyphs were produced (e.g., by a zero-width
7129 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
7130 buffer positions that will be removed from the glyph row because
7131 they don't fit.
c02dcedf
EZ
7132 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
7133 column is beyond frame width: don't subtract 1 "pixel" when
7134 computing width of the stretch.
3e62b7e0
EZ
7135 (reseat_at_next_visible_line_start): Undo the change made on
7136 2011-09-17 that saved paragraph information and restored it after
7137 the call to `reseat'. (Bug#9545)
56cd55c8 7138
5ed99d36 71392011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
7140
7141 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
7142 and turn window cursor on if cleared (Bug#9415).
7143
5ed99d36 71442011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
7145
7146 * search.c (boyer_moore): Take unibyte characters from pattern
7147 literally. (Bug#9458)
7148
9bade7b2
EZ
71492011-09-18 Eli Zaretskii <eliz@gnu.org>
7150
7151 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
7152
e5e9d610
PE
71532011-09-18 Paul Eggert <eggert@cs.ucla.edu>
7154
87e4427a
PE
7155 Fix minor problem found by static checking.
7156 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
7157 initialized, to pacify gcc -Wuninitialized.
7158
e5e9d610
PE
7159 * fileio.c: Report proper errno when syscall falls.
7160 (Finsert_file_contents): Save and restore errno,
7161 so that report_file_error outputs the correct diagnostic.
7162 (Fwrite_region) [CLASH_DETECTION]: Likewise.
7163
a1674f0b
EZ
71642011-09-18 Eli Zaretskii <eliz@gnu.org>
7165
7166 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
7167
fbfb6dd4
EZ
71682011-09-17 Eli Zaretskii <eliz@gnu.org>
7169
7170 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
7171 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
7172
bb187662
EZ
71732011-09-17 Eli Zaretskii <eliz@gnu.org>
7174
1137e8b8 7175 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 7176 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
7177
7178 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
7179 (bidi_find_paragraph_start): Search back for paragraph beginning
7180 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
7181 (bidi_move_to_visually_next): Only trigger paragraph-related
7182 computations when the last character is a newline or at EOB, not
7183 just any NEUTRAL_B. (Bug#9470)
7184
bb187662
EZ
7185 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
7186 truncated lines if point is covered by a display string. (Bug#9524)
7187
2e621251
PE
71882011-09-16 Paul Eggert <eggert@cs.ucla.edu>
7189
7190 * xselect.c: Relax test for outgoing X longs (Bug#9498).
7191 (cons_to_x_long): New function.
7192 (lisp_data_to_selection_data): Use it. Correct the test for
7193 short-versus-long data; it was negated. Break out of vector
7194 loop, for efficiency, when a long datum is discovered.
7195
91a15bc6
SM
71962011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
7197
7198 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
7199
b41c3a35
EZ
72002011-09-16 Eli Zaretskii <eliz@gnu.org>
7201
7202 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
7203 GCC PR/17406) by declaring this function with external scope.
7204
7812ba2d
PE
72052011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7206
7207 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
7208 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
7209
cf7edc2a
AS
72102011-09-15 Andreas Schwab <schwab@linux-m68k.org>
7211
7212 * editfns.c (Fformat): Correctly handle text properties on "%%".
7213
bd01620e
EZ
72142011-09-15 Eli Zaretskii <eliz@gnu.org>
7215
7216 * xterm.c (x_draw_composite_glyph_string_foreground):
7217 * w32term.c (x_draw_composite_glyph_string_foreground):
7218 * term.c (encode_terminal_code):
7219 * composite.c (composition_update_it, get_composition_id):
7220 * xdisp.c (get_next_display_element)
7221 (fill_composite_glyph_string): Add comments about special meaning
7222 of TAB characters in a composition.
7223
a02719a3
PE
72242011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7225
7226 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
7227 This occurs when processing a multibyte format.
7228 Problem reported by Wolfgang Jenker.
a02719a3 7229
72589a3c
JB
72302011-09-15 Johan Bockgård <bojohan@gnu.org>
7231
7232 * xdisp.c (try_cursor_movement): Only check for exact match if
7233 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
7234
1c14176c
PE
72352011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7236
7237 Remove unused external symbols.
7238 * dispextern.h (calc_pixel_width_or_height): Remove decl.
7239 * xdisp.c (calc_pixel_width_or_height): Now static.
7240 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
7241 * indent.c (check_display_width):
7242 * w32term.c: Fix comment to match code.
7243 * xterm.c, xterm.h (x_catching_errors): Remove.
7244
d2eea5b5
PE
72452011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7246
7247 * xselect.c: Use signed conversions more consistently (Bug#9498).
7248 (selection_data_to_lisp_data): Assume incoming selection data are
7249 signed integers, not unsigned. This is to be consistent with
7250 outgoing selection data, which was modified to use signed integers
7251 in as part of the fix to Bug#9196 in response to Jan D.'s comment
7252 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
7253 expects long, not unsigned long.
7254
46888499
EZ
72552011-09-14 Eli Zaretskii <eliz@gnu.org>
7256
7257 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
7258 computation of loop end. Reported by Johan Bockgård
7259 <bojohan@gnu.org>.
7260
ef8ef9fb
CY
72612011-09-13 Chong Yidong <cyd@stupidchicken.com>
7262
7263 * frame.c (Fother_visible_frames_p): Function deleted.
7264
fa819fed
EZ
72652011-09-12 Eli Zaretskii <eliz@gnu.org>
7266
7267 * indent.c (compute_motion): Process display vector front to back
7268 rather than the other way around. (Bug#2496)
7269
2ba8e008
SM
72702011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
7271
7272 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
7273
20f53c69
CY
72742011-09-11 Chong Yidong <cyd@stupidchicken.com>
7275
7276 * minibuf.c (Fread_from_minibuffer): Doc fix.
7277
d562d7a4
EZ
72782011-09-11 Eli Zaretskii <eliz@gnu.org>
7279
7280 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
7281 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
7282
1c4d7f3d
LMI
72832011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7284
7285 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
7286 value for non-existent files.
7287
b885bf36
EZ
72882011-09-11 Eli Zaretskii <eliz@gnu.org>
7289
7290 * fileio.c (Finsert_file_contents): If the file cannot be opened,
7291 set its "size" to -1. This will set the modtime_size field of
7292 the corresponding buffer to -1, which is what
7293 verify-visited-file-modtime expects for files that do not exist.
7294 (Bug#9139)
7295
6612f0bf
PE
72962011-09-11 Paul Eggert <eggert@cs.ucla.edu>
7297
7298 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
7299 here ...
7300 * lisp.h: ... from here. push_key_description is no longer
7301 defined in keyboard.c, so its declaration should not be in
7302 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
7303 logically belongs with push_key_description.
7304
dfb3f755
PE
73052011-09-10 Paul Eggert <eggert@cs.ucla.edu>
7306
7307 * buffer.h: Include <sys/types.h> instead of <time.h>.
7308 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
7309 Problem reported by Herbert J. Skuhra.
7310
3134906c
LMI
73112011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
7312
7313 * xml.c (parse_region): Make the parsing work for
7314 non-comment-starting XML files again (bug#9144).
7315
8d903f4e
AS
73162011-09-10 Andreas Schwab <schwab@linux-m68k.org>
7317
7318 * image.c (gif_load): Fix calculation of bottom and right corner.
7319 (Bug#9468)
7320
80ad64f4
EZ
73212011-09-10 Eli Zaretskii <eliz@gnu.org>
7322
7323 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
7324 redisplay in small windows.
7325
208a048d
EZ
73262011-09-09 Eli Zaretskii <eliz@gnu.org>
7327
7328 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
7329
9b1c252e
MR
73302011-09-08 Martin Rudalics <rudalics@gmx.at>
7331
7332 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
7333 Operate on live windows only.
7334
2949f33b
JB
73352011-09-08 Juanma Barranquero <lekktu@gmail.com>
7336
7337 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
7338
e08dcafd
EZ
73392011-09-07 Eli Zaretskii <eliz@gnu.org>
7340
7341 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
7342 only under bidi iteration.
7343
115b96bd
JD
73442011-09-07 Jan Djärv <jan.h.d@swipnet.se>
7345
7346 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
7347
c8199d0f
PE
73482011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7349
7350 isnan: Fix porting problem to Solaris 10 with bundled gcc.
7351 Without this fix, the command to link temacs failed due to an
7352 undefined symbol __builtin_isnan. This is because
7353 /usr/include/iso/math_c99.h #defines isnan(x) to
7354 __builtin_isnan(x), but the bundled gcc, which identifies itself
7355 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
7356 a __builtin_isnan.
7357 * floatfns.c (isnan): #undef, and then #define to a clone of
7358 what's in data.c.
7359 (Fisnan): Always define, since it's always available now.
7360 (syms_of_floatfns): Always define isnan at the Lisp level.
7361
e39b275c 73622011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
7363
7364 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
7365
b2db44d9 73662011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 7367
f4af5137 7368 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
7369 The previous code assumed that file offsets (off_t values) fit in
7370 EMACS_INT variables, which is not true on typical 32-bit hosts.
7371 The code messed up by falsely reporting buffer overflow in cases
7372 such as (insert-file-contents "big" nil 1 2) into an empty buffer
7373 when "big" contains more than 2**29 bytes, even though this
7374 inserts just one byte and does not overflow the buffer.
7375 (Finsert_file_contents): Store file offsets as off_t
7376 values, not as EMACS_INT values. Check for overflow when
7377 converting between EMACS_INT and off_t. When checking for
7378 buffer overflow or for overlap, take the offsets into account.
7379 Don't use EMACS_INT for small values where int suffices.
7380 When checking for overlap, fix a typo: ZV was used where
7381 ZV_BYTE was intended.
7382 (Fwrite_region): Don't assume off_t fits into 'long'.
7383 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
7384
ecfc0a49
MA
73852011-09-05 Michael Albinus <michael.albinus@gmx.de>
7386
7387 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
7388
6511acf2 73892011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 7390
0999621a 7391 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
7392
7393 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 7394 (esprintf, exprintf, evxprintf): New functions.
62f19c19 7395 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 7396 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
7397 (modify_event_symbol): Do not assume that the length of
7398 name_alist_or_stem is safe to alloca and fits in int.
7399 (Fexecute_extended_command): Likewise for function name and binding.
7400 (Frecursion_depth): Wrap around reliably on integer overflow.
7401 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
7402 since some callers pass EMACS_INT values.
7403 (Fsingle_key_description): Don't crash if symbol name contains more
7404 than MAX_ALLOCA bytes.
7405 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
7406 (get_minibuffer): Arg is now EMACS_INT, not int.
7407 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 7408 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
7409 * window.h (command_loop_level, minibuf_level): Reflect API changes.
7410
2be7d702
PE
7411 * dbusbind.c (signature_cat): New function.
7412 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
7413 Do not overrun buffer; instead, report string overflow.
7414
9d1df220
PE
7415 * dispnew.c (add_window_display_history): Don't overrun buffer.
7416 Truncate instead; this is OK since it's just a log.
7417
33ef5c64
PE
7418 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
7419 even if the time zone offset is outlandishly large.
7420 Don't mishandle offset == INT_MIN.
7421
66c6fdd5
PE
7422 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
7423 when creating daemon; the previous buffer-overflow check was incorrect.
7424
d749b01b
PE
7425 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
7426 which has the guts of the old verror function.
7427
b5cd1905
PE
7428 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
7429 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
7430
6e1a67fb
PE
7431 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
7432 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 7433 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 7434 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
7435 length of string rather than counting it via multiple sprintfs;
7436 that's simpler and more reliable.
c21721cc
PE
7437 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
7438 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
7439 sprintf, in case result does not fit in int.
7440
c57b67fc
PE
7441 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
7442 (fontset_from_font): Print it.
7443
8a401434
PE
7444 * frame.c (tty_frame_count): Now printmax_t, not int.
7445 (make_terminal_frame, set_term_frame_name): Print it.
7446 (x_report_frame_params): In X, window IDs are unsigned long,
7447 not signed long, so print them as unsigned.
7448 (validate_x_resource_name): Check for implausibly long names,
7449 and don't assume name length fits in 'int'.
7450 (x_get_resource_string): Don't blindly alloca invocation name;
7451 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
7452 not fit in int.
7453
6e1a67fb
PE
7454 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
7455 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
7456 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
7457
0df02bf3
PE
7458 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
7459 Use esprintf, not sprintf, in case result does not fit in int.
7460
48e30793
PE
7461 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7462 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
7463 it as a large positive number.
7464 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
7465 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7466
a66ff6d8
PE
7467 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
7468 in case result does not fit in int.
7469
aca216ff
PE
7470 * print.c (float_to_string): Detect width overflow more reliably.
7471 (print_object): Make sprintf buffer a bit bigger, to avoid potential
7472 buffer overrun. Don't assume list length fits in 'int'. Treat
7473 print length of 0 as 0, not as infinity; to be consistent with other
7474 uses of print length in this function. Don't overflow print length
7475 index. Don't assume hash table size fits in 'long', or that
7476 vectorlike size fits in 'unsigned long'.
7477
31c286f7
PE
7478 * process.c (make_process): Use printmax_t, not int, to format
7479 process-name gensyms.
7480
55e5faa1
PE
7481 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
7482
80f2e268
PE
7483 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
7484 to avoid potential buffer overrun.
7485
670741ab
PE
7486 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
7487 if X resource line is longer than 512 bytes.
7488
b7163a50
PE
7489 * xfns.c (x_window): Make sprintf buffer a bit bigger
7490 to avoid potential buffer overrun.
7491
ae58ff1f
PE
7492 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
7493
c43c8a6a
PE
7494 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
7495
3f8236f4
PE
74962011-09-04 Paul Eggert <eggert@cs.ucla.edu>
7497
53e9fe90 7498 Integer overflow fixes for scrolling, etc.
6511acf2
PE
7499 Without these, Emacs silently mishandles large integers sometimes.
7500 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
7501 it were "C-u 1 M-x recenter" on a typical 64-bit host.
7502
6511acf2
PE
7503 * xdisp.c (try_window_id): Check Emacs fixnum range before
7504 converting to 'int'.
806add1d 7505
6511acf2 7506 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
7507 Check that an Emacs fixnum is in range before assigning it to 'int'.
7508 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
7509 values converted from Emacs fixnums.
7510 (Frecenter): Don't wrap around a line count if it is out of 'int'
7511 range; instead, treat it as an extreme value.
7512 (Fset_window_configuration, compare_window_configurations):
7513 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
7514
6511acf2
PE
7515 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
7516 that can exceed INT_MAX. Check that EMACS_INT value is in range
7517 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
7518 (match_limit): Don't assume that a fixnum can fit in 'int'.
7519
6511acf2 7520 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
7521 exceed INT_MAX.
7522
6511acf2 7523 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
7524 (Fvertical_motion): Don't wrap around LINES values that don't fit
7525 in 'int'. Instead, treat them as extreme values. This is good
7526 enough for windows, which can't have more than INT_MAX lines anyway.
7527
fcb901a7
LMI
75282011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7529
0f2f6b6d
LMI
7530 * Require libxml/parser.h to avoid compilation warning.
7531
fcb901a7
LMI
7532 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
7533
7534 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
7535 since this reportedly can destroy thread storage.
7536
6e20a0d4
CY
75372011-08-30 Chong Yidong <cyd@stupidchicken.com>
7538
7539 * syntax.c (find_defun_start): Update all cache variables if
7540 exiting early (Bug#9401).
7541
148ae00e
EZ
75422011-08-30 Eli Zaretskii <eliz@gnu.org>
7543
f6cfbd8f
EZ
7544 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
7545
148ae00e
EZ
7546 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
7547 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
7548 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
7549
7550 * term.c (tty_append_glyph): New function.
7551 (produce_stretch_glyph): Static function and its prototype deleted.
7552
a66cfb1c
SM
7553 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
7554 Add prototypes.
148ae00e 7555
c4a07a4c
PE
75562011-08-29 Paul Eggert <eggert@cs.ucla.edu>
7557
7558 * image.c (parse_image_spec): Check for nonnegative, not for positive,
7559 when checking :margin (Bug#9390).
7560 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 7561 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
7562 so that the name doesn't mislead. All uses changed.
7563
6bc8cd65
JB
75642011-08-28 Johan Bockgård <bojohan@gnu.org>
7565
7566 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
7567 set_tty_hooks.
7568
dca4927e
EZ
75692011-08-27 Eli Zaretskii <eliz@gnu.org>
7570
7571 * xdisp.c (move_it_to): Don't bail out early when reaching
7572 position beyond to_charpos, if we are scanning backwards.
7573 (move_it_vertically_backward): When DY == 0, make sure we get to
7574 the first character in the line after the newline.
7575
f2cad773
PE
75762011-08-27 Paul Eggert <eggert@cs.ucla.edu>
7577
7578 * ccl.c: Improve and simplify overflow checking (Bug#9196).
7579 (ccl_driver): Do not generate an out-of-range pointer.
7580 (Fccl_execute_on_string): Remove unnecessary check for
7581 integer overflow, noted by Stefan Monnier in
7582 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
7583 Remove a FIXME that didn't need fixing.
7584 Simplify the newly-introduced buffer reallocation code.
7585
0cae2cdb
JB
75862011-08-27 Juanma Barranquero <lekktu@gmail.com>
7587
7588 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
7589
5fc295a4 75902011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 7591
70c60eb2 7592 Integer and memory overflow issues (Bug#9196).
726e0ab1 7593
d31850da
PE
7594 * doc.c (get_doc_string): Rework so that
7595 get_doc_string_buffer_size is the actual buffer size, rather than
7596 being 1 less than the actual buffer size; this makes xpalloc more
7597 convenient.
7598
a69fbedb
PE
7599 * image.c (x_allocate_bitmap_record, cache_image):
7600 * xselect.c (Fx_register_dnd_atom):
7601 Simplify previous changes by using xpalloc.
7602
fe5c5d37
PE
7603 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
7604 since either will do and ptrdiff_t is convenient with xpalloc.
7605
0065d054
PE
7606 * charset.c (charset_table_size)
7607 (struct charset_sort_data.priority): Now ptrdiff_t.
7608 (charset_compare): Don't overflow if priorities differ greatly.
7609 (Fsort_charsets): Don't assume list length fits in int.
7610 Check for size-calculation overflow when allocating sort data.
7611 (syms_of_charset): Allocate an initial charset table that is
7612 just under 64 KiB, to avoid problems with glibc malloc and mmap.
7613
7614 * cmds.c (internal_self_insert): Check for size-calculation overflow.
7615
7616 * composite.h (struct composition.glyph_len): Now int, not unsigned.
7617 The actual value is always <= INT_MAX, and leaving it unsigned made
7618 overflow checking harder.
7619
7620 * dispextern.h (struct glyph_matrix.rows_allocated)
7621 (struct face_cache.size): Now ptrdiff_t, for convenience in use
7622 with xpalloc. The values are still always <= INT_MAX.
7623
7624 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
7625
7626 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
7627 (SAFE_NALLOCA): New macro.
7628
7629 * region-cache.c (struct boundary.pos, find_cache_boundary)
7630 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
7631 (set_cache_region, invalidate_region_cache)
7632 (revalidate_region_cache, know_region_cache, region_cache_forward)
7633 (region_cache_backward, pp_cache):
7634 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
7635 so that ptrdiff_t * can be passed to xpalloc.
7636 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
7637 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
7638 (pp_cache): Don't assume cache_len fits in int.
7639 * region-cache.h: Adjust extern decls to match.
7640
7641 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
7642 EMACS_INT, since either will do, for xpalloc.
7643
7644 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
7645 (xnmalloc, xnrealloc, xpalloc): New functions.
7646
726e0ab1
PE
7647 * bidi.c (bidi_shelve_header_size): New constant.
7648 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
7649 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
7650
51f30bc5 7651 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
7652 * buffer.c (overlays_at, overlays_in, record_overlay_string)
7653 (overlay_strings):
7654 Don't update size of array until after memory allocation succeeds,
7655 because xmalloc/xrealloc may not return.
0065d054
PE
7656 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
7657 now that we have proper integer overflow checking.
7658 (record_overlay_string, overlay_strings): Catch overflows when
7659 calculating size of overlay_str_buf.
726e0ab1 7660
0065d054
PE
7661 * callproc.c (Fcall_process): Check for size overflow when
7662 calculating size of args2.
7663 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
7664 Normally we prefer signed values, but sticking with ptrdiff_t would
7665 require adding more-complicated checks.
726e0ab1
PE
7666
7667 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
7668 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
7669 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 7670 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
7671
7672 * character.c (Fstring): Check for size-calculation overflow.
7673
7674 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
7675 unnecessary integer overflow. Check for size overflow.
7676 (encode_coding_object): Don't update size until xmalloc succeeds.
7677
7678 * composite.c (get_composition_id): Check for overflow in glyph
7679 length calculations.
7680
7681 Integer and memory overflow fixes for display code.
7682 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
7683 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
7684 (scrolling_window): Check for overflow in size calculations.
7685 (line_draw_cost, realloc_glyph_pool, add_row_entry):
7686 Don't assume glyph table len fits in int.
7687 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
7688 (row_table_size): Now ptrdiff_t, not int.
7689 (scrolling_window): Avoid overflow in size calculations.
7690 Don't update size until allocation succeeds.
7691 * fns.c (concat): Check for overflow in size calculations.
7692 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
7693 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7694 (NEXT_ALMOST_PRIME_LIMIT): New constant.
7695
7696 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
7697 (get_doc_string): Check for size calculation overflow.
7698 Don't update size until allocation succeeds.
7699 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
7700 EMACS_INT, where ptrdiff_t will do.
7701 (Fsubstitute_command_keys): Check for string overflow.
7702
7703 * editfns.c (set_time_zone_rule): Don't assume environment length
7704 fits in int.
7705 (message_length): Now ptrdiff_t, not int.
7706 (Fmessage_box): Don't update size until allocation succeeds.
7707 Don't assume message length fits in int.
7708 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
7709
0065d054
PE
7710 * emacs.c (main): Do not reallocate argv, since there is a null at
7711 the end that can be overwritten, and this way there's no need to
7712 worry about size-calculation overflow.
7713 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
7714
7715 * eval.c (init_eval_once, grow_specpdl): Don't update size until
7716 alloc succeeds.
7717 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
7718
7719 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
7720 (x_set_scroll_bar_width, x_figure_window_size):
7721 Check for integer overflow.
7722 (x_set_alpha): Do not assume XINT fits in int.
7723
7724 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
7725 This is for the members text_lines, text_cols, total_lines, total_cols,
7726 where the system imposes an 'int' limit.
7727
7728 * fringe.c (Fdefine_fringe_bitmap):
7729 Don't update size until alloc works.
7730
7731 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
7732 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
7733
7734 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
7735 Check for size-calculation overflow.
7736 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
7737 do, as we prefer signed integers.
7738 (id_to_widget.max_size, id_to_widget.used)
7739 (xg_store_widget_in_map, xg_remove_widget_from_map)
7740 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
7741 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
7742 Use and return ptrdiff_t, not int.
7743 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
7744 * gtkutil.h: Change prototypes to match the above.
7745
7746 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
7747 are duplicate now that they've been promoted to lisp.h.
7748 (x_allocate_bitmap_record, x_alloc_image_color)
7749 (make_image_cache, cache_image, xpm_load):
7750 Don't update size until alloc is done.
7751 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
7752 (x_detect_edges):
3256efce 7753 Check for size calculation overflow.
726e0ab1
PE
7754 (ct_colors_allocated_max): New constant.
7755 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
7756 overflow.
3256efce 7757
726e0ab1
PE
7758 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
7759 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
7760 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
7761 Use ptrdiff_t, not int, to count maps.
7762 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
7763 calculations. Don't update size until allocation succeeds.
7764 Redo calculations to avoid overflow.
726e0ab1
PE
7765 * keyboard.h: Change prototypes to match the above.
7766
7767 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
7768 to count maps.
7769 (current_minor_maps): Check for size calculation overflow.
7770 * keymap.h: Change prototypes to match the above.
7771
7772 * lread.c (read1, init_obarray): Don't update size until alloc done.
7773
7774 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
7775 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
7776
726e0ab1
PE
7777 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
7778 Now ptrdiff_t, not int.
7779 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
7780 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
7781
7782 * process.c (Fnetwork_interface_list): Check for overflow
7783 in size calculation.
7784
7785 * region-cache.c (move_cache_gap): Check for size calculation overflow.
7786
7787 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
7788 overflow. Don't bother calling xmalloc when xrealloc will do.
7789
7790 * search.c (Freplace_match): Check for size calculation overflow.
7791 (Fset_match_data): Don't assume list lengths fit in 'int'.
7792
7793 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
7794 for command line length. Do not attempt to address one before the
7795 beginning of an array, as that's not portable.
7796
7797 * term.c (max_frame_lines): Remove; unused.
7798 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
7799 not int.
7800 (encode_terminal_code, calculate_costs): Check for size
7801 calculation overflow.
7802 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
7803 table lengths and related sizes. Don't update size until alloc
7804 done. Redo calculations to avoid overflow.
7805 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
7806
7807 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
7808 subtracting pointers.
7809 (gobble_line): Check for overflow more carefully. Don't update size
7810 until alloc done.
7811
7812 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
7813 Don't update size until alloc done.
7814 Redo size calculations to avoid overflow.
7815 Check for size calculation overflow.
0065d054 7816 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
7817
7818 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
7819 Use ptrdiff_t, not int, for sizes.
7820 (store_mode_line_noprop_char): Don't update size until alloc done.
7821
0065d054
PE
7822 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
7823 Use ptrdiff_t, not int, for sizes.
7824 (Finternal_make_lisp_face, cache_face):
7825 Check for size calculation overflow.
7826 (cache_face): Treat size calculation overflows as if they were
7827 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
7828
7829 * xfns.c (x_encode_text, x_set_name_internal)
7830 (Fx_change_window_property): Use ptrdiff_t, not int, to count
7831 sizes, since they can exceed INT_MAX in size. Check for size
7832 calculation overflow.
7833
0065d054
PE
7834 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
7835 (xg_select): Check for size calculation overflow.
726e0ab1
PE
7836 Don't update size until alloc done.
7837
0065d054 7838 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 7839 as sprintf is limited to int lengths.
1d526e2f 7840
252c5ee1
PE
7841 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
7842 (X_LONG_MIN): New macros.
864d7ce7
PE
7843 Use them to make the following changes clearer.
7844 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
7845 This change doesn't affect the value now, but it may help remind
7846 future maintainers not to raise the value too much later.
7847 (SELECTION_QUANTUM): Remove, replacing with ...
7848 (selection_quantum): ... new function, which avoids overflow.
7849 All uses changed.
7850 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
7851 assumption that selection length fits in 'int'.
7852 (x_reply_selection_request, x_handle_selection_request)
7853 (x_get_window_property, receive_incremental_selection)
7854 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
7855 (lisp_data_to_selection_data, clean_local_selection_data):
7856 Use ptrdiff_t, not int, to record length of selection.
7857 (x_reply_selection_request, x_get_window_property)
7858 (receive_incremental_selection, x_property_data_to_lisp):
7859 Redo calculations to avoid overflow.
7860 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 7861 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
7862 something.
7863 (x_get_window_property, receive_incremental_selection)
7864 (lisp_data_to_selection_data, x_property_data_to_lisp):
7865 Check for size-calculation overflow.
7866 (x_get_window_property, receive_incremental_selection)
7867 (lisp_data_to_selection_data, Fx_register_dnd_atom):
7868 Don't store size until memory allocation succeeds.
7869 (x_get_window_property): Plug memory leak on memory exhaustion.
7870 Don't double-block input; malloc is safe here. Don't assume 2**34
7871 - 4 fits in unsigned long. Add an xassert to check
7872 XGetWindowProperty overflow. Be more careful about overflow
7873 calculations, and distinguish size from memory overflow better.
7874 (receive_incremental_selection): When tracing, don't assume
7875 unsigned int is less than INT_MAX.
7876 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
7877 harmful) conversions of unsigned short to int.
7878 (lisp_data_to_selection_data): Don't assume that integers
7879 in the range -65535 through -1 fit in an X unsigned short.
7880 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
7881 result parameters unless successful. Rely on cons_to_unsigned
7882 to report problems with elements; the old code wasn't right anyway.
7883 (x_check_property_data): Check for int overflow; we cannot use
7884 a wider type due to X limits.
7885 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
7886
726e0ab1 7887 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 7888
0065d054
PE
7889 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
7890 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
7891 (x_color_cells): Don't store size until memory allocation succeeds.
7892 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 7893 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
7894 (x_term_init): Don't assume length fits in int (sprintf is limited
7895 to int size).
bc18e09d 7896
ebfa62c0
PE
7897 Use ptrdiff_t for composition IDs.
7898 * character.c (lisp_string_width):
7899 * composite.c (composition_table_size, n_compositions)
7900 (get_composition_id, composition_gstring_from_id):
7901 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
7902 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
7903 * window.c (Frecenter):
7904 Use ptrdiff_t, not int, for composition IDs.
7905 * composite.c (get_composition_id): Check for integer overflow.
7906 * composite.h: Adjust prototypes to match the above changes.
7907
d3411f89
PE
7908 Use ptrdiff_t for hash table indexes.
7909 * category.c (hash_get_category_set):
7910 * ccl.c (ccl_driver):
7911 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
7912 * coding.c (coding_system_charset_list, detect_coding_system):
7913 * coding.h (struct coding_system.id):
7914 * composite.c (get_composition_id, gstring_lookup_cache):
7915 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
7916 * image.c (xpm_get_color_table_h):
7917 * lisp.h (hash_lookup, hash_put):
7918 * minibuf.c (Ftest_completion):
7919 Use ptrdiff_t for hash table indexes, not int (which is too
7920 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
7921 32-bit --with-wide-int hosts).
7922
e097a6fa
PE
7923 * charset.c (Fdefine_charset_internal): Check for integer overflow.
7924 Add a FIXME comment about memory leaks.
7925 (syms_of_charset): Don't assume xmalloc returns.
7926
5637687f
PE
7927 Don't assume that stated character widths fit in int.
7928 * character.c (Fchar_width, c_string_width, lisp_string_width):
7929 * character.h (CHAR_WIDTH):
7930 * indent.c (MULTIBYTE_BYTES_WIDTH):
7931 Use sanitize_char_width to avoid undefined and/or bad behavior
7932 with outlandish widths.
a66cfb1c 7933 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
7934 now that we have two such functions. All uses changed.
7935 (sanitize_char_width): New inline function.
7936
a2271ba2
PE
7937 Don't assume that tab-width fits in int.
7938 * character.h (sanitize_width): New inline function.
7939 (SANE_TAB_WIDTH): New macro.
7940 (ASCII_CHAR_WIDTH): Use it.
7941 * indent.c (sane_tab_width): Remove. All uses replaced by
7942 SANE_TAB_WIDTH (current_buffer).
7943 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
7944
18c52557
PE
7945 * fileio.c: Integer overflow issues with file modes.
7946 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
7947
caeeedc1
PE
7948 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
7949 Remove unreachable code.
7950 (read_hex, load_charset_map_from_file): Check for integer overflow.
7951
6df6ae42 7952 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
7953 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
7954 (x_send_scroll_bar_event): Likewise. Check that the size does not
7955 exceed limits imposed by XClientMessageEvent, as well as the usual
7956 ptrdiff_t and size_t limits.
7957
b13995db
PE
7958 * keyboard.c: Overflow, signedness and related fixes.
7959 (make_lispy_movement): Use same integer type in forward decl
7960 that is used in the definition.
7961 (read_key_sequence, keyremap_step):
7962 Change bufsize argument back to int, undoing my 2011-03-30 change.
7963 We prefer signed types, and int is wide enough here.
7964 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
7965 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
7966 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
7967 length, not size_t. Use ptrdiff_t for index, not int.
7968 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
7969 possibility of integer overflow.
7970
13464394
PE
7971 Overflow, signedness and related fixes for images.
7972
7973 * dispextern.h (struct it.stack[0].u.image.image_id)
7974 (struct_it.image_id, struct image.id, struct image_cache.size)
7975 (struct image_cache.used, struct image_cache.ref_count):
7976 * gtkutil.c (update_frame_tool_bar):
7977 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
7978 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
7979 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
7980 * nsmenu.m (update_frame_tool_bar):
7981 * xdisp.c (calc_pixel_width_or_height):
7982 * xfns.c (image_cache_refcount):
7983 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
7984 on typical 64-bit hosts.
7985
7986 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7987 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
7988 Omit unnecessary casts to int.
7989 (parse_image_spec): Check that integers fall into 'int' range
7990 when the callers expect that.
7991 (image_ascent): Redo ascent calculation to avoid int overflow.
7992 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
7993 (lookup_image): Remove unnecessary tests.
7994 (xbm_image_p): Locals are now of int, not EMACS_INT,
7995 since parse_image_check makes sure they fit into int.
7996 (png_load, gif_load, svg_load_image):
7997 Prefer int to unsigned where either will do.
7998 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
7999 old tiff_error_handler and tiff_warning_handler.
8000 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
8001 stack buffer overflows. It uses only the features of vsnprintf
8002 that are common to both POSIX and native Microsoft.
8003 (tiff_error_handler, tiff_warning_handler): Use it.
8004 (tiff_load, gif_load, imagemagick_load_image):
8005 Don't assume :index value fits in 'int'.
8006 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
8007 (imagemagick_load_image): Check that crop parameters fit into
8008 the integer types that MagickCropImage accepts. Don't assume
8009 Vimagemagick_render_type has a nonnegative value. Don't assume
8010 size_t fits in 'long'.
8011 (gs_load): Use printmax_t to print the widest integers possible.
8012 Check for integer overflow when computing image height and width.
8013
c11821d4
EZ
80142011-08-26 Eli Zaretskii <eliz@gnu.org>
8015
8016 * xdisp.c (redisplay_window): Don't force window start if point
8017 will be invisible in the resulting window. (Bug#9324)
8018
0c95fcf7
EZ
80192011-08-25 Eli Zaretskii <eliz@gnu.org>
8020
8021 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
8022 the display spec is of the form `(space ...)'.
8023 (handle_display_spec): Return the value returned by
8024 handle_single_display_spec, not just 1 or zero.
8025 (handle_single_display_spec): If the display spec is of the form
8026 `(space ...)', and specifies display in the text area, return 2
8027 rather than 1.
fee65a97 8028 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
8029 accurately, and prefer exact match for point under bidi.
8030 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
8031
8032 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
8033 into disp_prop; all users changed.
8034
8035 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
8036 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
8037 for the text covered by the display property.
8038
e4ed06f1
CY
80392011-08-25 Chong Yidong <cyd@stupidchicken.com>
8040
8041 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
8042 Change return value to nil.
8043 (Frecord_buffer): Delete unused function.
8044
f67cdd7f
EZ
80452011-08-24 Eli Zaretskii <eliz@gnu.org>
8046
5980d4c6
EZ
8047 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
8048 buffers, return left-to-right.
8610fe8b
EZ
8049 (set_cursor_from_row): Consider candidate row a win if its glyph
8050 represents a newline and point is on that newline. Fixes cursor
8051 positioning on the newline at EOL of R2L text within L2R
8052 paragraph, and vice versa.
8053 (try_cursor_movement): Check continued rows, in addition to
8054 continuation rows. Fixes unwarranted scroll when point enters a
8055 continued line of R2L text within an L2R paragraph, or vice versa.
8056 (cursor_row_p): Consider the case of point being equal to
8057 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
8058 from the end of a short line to the beginning of a continued line
8059 of R2L text within L2R paragraph.
8060 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
8061 composed characters.
5980d4c6 8062
f67cdd7f
EZ
8063 * bidi.c (bidi_check_type): Use xassert.
8064 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
8065 members.
8066
bca633fb
EZ
80672011-08-23 Eli Zaretskii <eliz@gnu.org>
8068
8069 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
8070 a character.
8071
4a5885a7
CY
80722011-08-23 Chong Yidong <cyd@stupidchicken.com>
8073
8074 * nsfont.m (ns_otf_to_script): Fix typo.
8075
0902a04e
KH
80762011-08-22 Kenichi Handa <handa@m17n.org>
8077
8078 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
8079 extra slot even if the purpose is char-code-property-table.
8080
1a2e6670
EZ
80812011-08-23 Eli Zaretskii <eliz@gnu.org>
8082
8ddde651
EZ
8083 * xdisp.c (redisplay_window): When computing centering_position,
8084 account for the height of the header line. (Bug#8874)
8085
425cc014
EZ
8086 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
8087 instead of CHAR_TO_BYTE. Fixes a crash when a completion
8088 candidate is selected by the mouse, and that candidate has a
8089 composed character under the mouse.
8090
1a2e6670
EZ
8091 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
8092 coordinates reported by pos-visible-in-window-p for a composed
8093 character in column zero.
8094
8b76d6f8
SM
80952011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
8096
8097 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
8098
dac347dd
EZ
80992011-08-22 Eli Zaretskii <eliz@gnu.org>
8100
8101 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
8102 consider it a hit if to_charpos is anywhere in the range of the
8103 composed buffer positions.
8104
e013fb34
CY
81052011-08-22 Chong Yidong <cyd@stupidchicken.com>
8106
8107 * image.c (gif_load): Don't assume that each subimage has the same
8108 dimensions as the base image. Handle disposal method that is
8109 "undefined" by the gif spec (Bug#9335).
8110
bd1ba3e8
CY
81112011-08-20 Chong Yidong <cyd@stupidchicken.com>
8112
8113 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 8114 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 8115
54a1215b
EZ
81162011-08-19 Eli Zaretskii <eliz@gnu.org>
8117
823564e5
EZ
8118 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
8119 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
8120 from an Org mode buffer to a Speedbar frame.
8121
54a1215b
EZ
8122 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
8123 a composition, take its buffer position from IT->cmp_it.charpos.
8124 Fixes cursor positioning at the beginning of a line that begins
8125 with a composed character.
8126
9778ebcc
EZ
81272011-08-18 Eli Zaretskii <eliz@gnu.org>
8128
0be6ee06
EZ
8129 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
8130 character bidirectional type, use STRONG_L instead. Fixes crashes
8131 in a buffer produced by `describe-categories'.
8132
9778ebcc
EZ
8133 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
8134 members before the level stack, so they would be saved and
8135 restored when copying iterator state. Fixes incorrect reordering
8136 around TABs covered by display properties.
8137
156bffbe
AS
81382011-08-18 Andreas Schwab <schwab@linux-m68k.org>
8139
6b02f655 8140 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 8141
72ad093b
CY
81422011-08-17 Chong Yidong <cyd@stupidchicken.com>
8143
8144 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
8145 (internal_condition_case_2, internal_condition_case_n):
8146 Remove unnecessary aborts (Bug#9081).
72ad093b 8147
35774242
EZ
81482011-08-17 Eli Zaretskii <eliz@gnu.org>
8149
8150 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
8151 has no `load' handler, try opening the file locally. (Bug#9311)
8152
db76dd85
KB
81532011-08-16 Ken Brown <kbrown@cornell.edu>
8154
8155 * gmalloc.c: Expand comment.
8156
b215eee5
EZ
81572011-08-16 Eli Zaretskii <eliz@gnu.org>
8158
8159 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
8160 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
8161
a4579d33
KB
81622011-08-16 Ken Brown <kbrown@cornell.edu>
8163
8164 Fix memory allocation problems in Cygwin build (Bug#9273).
8165
8166 * unexcw.c ( __malloc_initialized): Declare external variable.
8167 (fixup_executable): Force the dumped emacs to reinitialize malloc.
8168
8b76d6f8
SM
8169 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
8170 New variables.
a4579d33
KB
8171 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
8172 dumped emacs.
8173 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
8174 in the static heap.
8175 [CYGWIN] (special_realloc): New function.
8176 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
8177 requests to realloc storage in the static heap.
8178
3ebec551
PE
81792011-08-15 Paul Eggert <eggert@cs.ucla.edu>
8180
8181 * bidi.c (bidi_initialize): Remove unused local.
8182
9fd8be00
EZ
81832011-08-15 Eli Zaretskii <eliz@gnu.org>
8184
6b02f655
SM
8185 * bidimirror.h:
8186 * biditype.h: Remove file.
8187 * makefile.w32-in ($(BLD)/bidi.$(O)):
8188 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
8189
8190 * dispextern.h: Fix a typo in the comment to bidi_type_t.
8191
8192 * chartab.c: Improve commentary for the uniprop_table API.
8193
32413314
EZ
8194 * bidi.c (bidi_paragraph_init): Support zero value of
8195 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
8196 (bidi_initialize): Use uniprop_table instead of including
8197 biditype.h and bidimirror.h.
32413314 8198
9fd8be00
EZ
8199 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
8200 coordinates of the iterator when restoring from ppos_it.
8201 (Bug#9296)
8202
5cf2b69b
KH
82032011-08-14 Kenichi Handa <handa@m17n.org>
8204
8205 * process.c (create_process): Call setup_process_coding_systems
72ad093b 8206 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 8207
daf17d00
EZ
82082011-08-14 Eli Zaretskii <eliz@gnu.org>
8209
8210 * xdisp.c (move_it_in_display_line_to): Don't invoke
8211 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
8212 ppos_it. Fixes vertical cursor motion when line beginning is
8213 covered by an image. (Bug#9296)
8214
08e3161a
JD
82152011-08-14 Jan Djärv <jan.h.d@swipnet.se>
8216
8217 * nsterm.h (ns_run_ascript): Declare.
8218 (NSAPP_DATA2_RUNASSCRIPT): Define.
8219
8220 * nsfns.m (as_script, as_result, as_status): New static variables.
8221 (ns_run_ascript): New function.
5e617bc2 8222 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
8223 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
8224 the event loop. Get status from as_status (Bug#7276).
8225
8226 * nsterm.m (sendEvent): If event is NSApplicationDefined and
8227 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
8228 the event loop (Bug#7276).
8229
a3720aa2
AS
82302011-08-14 Andreas Schwab <schwab@linux-m68k.org>
8231
8232 * gnutls.c (QCgnutls_bootprop_priority)
8233 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
8234 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
8235 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
8236 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
8237 (QCgnutls_bootprop_verify_hostname_error)
8238 (QCgnutls_bootprop_callbacks_verify): Rename from
8239 Qgnutls_bootprop_..., all uses changed.
8240
8241 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
8242 uses changed.
8243
0a0d27fb
PE
82442011-08-14 Paul Eggert <eggert@cs.ucla.edu>
8245
19d5c50c
PE
8246 * xfaces.c (Qframe_set_background_mode): Now static.
8247 * dispextern.h (Qframe_set_background_mode): Remove decl.
8248
0a0d27fb
PE
8249 * process.c (Fnetwork_interface_info): Declare local only if needed.
8250
377538cb
JD
82512011-08-13 Jan Djärv <jan.h.d@swipnet.se>
8252
8253 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
8254 (Fnetwork_interface_list): Allocate in increments of bytes instead
8255 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
8256 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
8257 sockaddr.
8258 (struct ifflag_def): notrailers is smart on OSX.
8259 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
8260 Get hardware address with getifaddrs if available.
8261
08fff70c
EZ
82622011-08-12 Eli Zaretskii <eliz@gnu.org>
8263
8264 * xdisp.c (iterate_out_of_display_property): xassert that
8265 IT->position is set to within IT->object's boundaries. Break from
8266 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
8267 when IT->position is set up wrongly due to some bug.
8268 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
8269 (push_display_prop): Allow GET_FROM_STRING as IT->method on
8270 entry. Force push_it to save on the stack the current
8271 buffer/string position, to be restored by pop_it. Fix flags in
8272 the iterator structure wrt the object coming from a display
8273 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
8274 properties. (Bug#9284)
8275
7be1c708 82762011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 8277
7be1c708
CY
8278 * fontset.c (fontset_get_font_group): Add proper type checks.
8279 (Bug#9172)
aac0c6e3 8280
7be1c708 82812011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 8282
7be1c708
CY
8283 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
8284 and LC_VERSION_MIN_MACOSX.
8285 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
8286 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 8287
97bb72a6
EZ
82882011-08-08 Eli Zaretskii <eliz@gnu.org>
8289
8290 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
8291 no-display-properties-and-no-overlays under bidi display.
8292 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 8293 properties and overlays.
97bb72a6 8294
d5617611
CY
82952011-08-08 Chong Yidong <cyd@stupidchicken.com>
8296
37e11a63
CY
8297 * editfns.c (Fset_time_zone_rule): Document relationship with the
8298 setenv function.
8299
d5617611
CY
8300 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
8301 the font entity extracted from the cache (Bug#8109).
8302
58872834
CY
83032011-08-07 Chong Yidong <cyd@stupidchicken.com>
8304
8305 * composite.c (autocmp_chars): Don't reset point. That is done by
8306 restore_point_unwind (Bug#5984).
8307
75bfc667
JL
83082011-08-07 Juri Linkov <juri@jurta.org>
8309
8310 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
8311 to show the arg `TIME' instead of `TIMEVAL'.
8312
d1410150
EZ
83132011-08-06 Eli Zaretskii <eliz@gnu.org>
8314
8315 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
8316 display property strides EOL and includes a newline, as in
8317 longlines-mode. (Bug#9254)
75b771e4
EZ
8318 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
8319 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
8320
8321 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
8322 is non-zero, even if the data buffer is NULL. Fixes a crash in
8323 vertical-motion with longlines-mode. (Bug#9254)
8324
35928349
EZ
83252011-08-05 Eli Zaretskii <eliz@gnu.org>
8326
ec7cc85b
EZ
8327 * bidi.c <bidi_cache_total_alloc>: Now static.
8328 (bidi_initialize): Initialize bidi_cache_total_alloc.
8329
8b76d6f8 8330 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
8331 cache. (Bug#9221)
8332
8333 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
8334 amount allocated this far in `bidi_cache_total_alloc'.
8335 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
8336 non-zero, only free the data buffer without restoring the cache
8337 contents. All callers changed.
8338
8339 * dispextern.h (bidi_unshelve_cache): Update prototype.
8340
8341 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
8342 (move_it_in_display_line, move_it_to)
8343 (move_it_vertically_backward, move_it_by_lines): Replace the call
8344 to xfree to an equivalent call to bidi_unshelve_cache.
8345 (move_it_in_display_line_to): Fix logic of returning
412b6358 8346 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 8347
e2e2423b
EZ
83482011-08-05 Eli Zaretskii <eliz@gnu.org>
8349
8350 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
8351 came from a string character with a `cursor' property. (Bug#9229)
8352
ae9e757a
JD
83532011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8354
8355 * Makefile.in (LIB_PTHREAD): New variable.
8356 (LIBES): Add LIB_PTHREAD (Bug#9216).
8357
8358 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
8359 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
8360
213bd7f2
AS
83612011-08-04 Andreas Schwab <schwab@linux-m68k.org>
8362
6b02f655 8363 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 8364
99aaf75f
JD
83652011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8366
8367 * xterm.c (x_find_topmost_parent): New function.
8368 (x_set_frame_alpha): Find topmost parent window with
8369 x_find_topmost_parent and set the property there also (bug#9181).
8370 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
8371
c74e9d86
PE
83722011-08-04 Paul Eggert <eggert@cs.ucla.edu>
8373
8374 * callproc.c (Fcall_process): Avoid vfork clobbering
8375 the local vars buffer, coding_systems, current_dir.
8376
640c8776
SM
83772011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
8378
8379 * keymap.c (Fmake_composed_keymap): Move to subr.el.
8380
f26d0e4c
PE
83812011-08-03 Paul Eggert <eggert@cs.ucla.edu>
8382
8a10d76c
PE
8383 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
8384 so that it is not optimized away.
8385
f26d0e4c
PE
8386 * xdisp.c (compute_display_string_pos): Remove unused local.
8387
55439c61
EZ
83882011-08-02 Eli Zaretskii <eliz@gnu.org>
8389
8390 Fix slow cursor motion and scrolling in large buffers with
8391 selective display, like Org Mode buffers. (Bug#9218)
8392
8393 * dispextern.h (struct bidi_it): New member disp_prop_p.
8394
8395 * xdisp.c: Remove one-slot cache of display string positions.
8396 (compute_display_string_pos): Accept an additional argument
5e617bc2 8397 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
8398 for a display string or property. If found, set DISP_PROP_P
8399 non-zero.
8400
8401 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
8402 DISP_PROP_P, and pass it to compute_display_string_pos.
8403 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
8404 non-zero. All callers of bidi_fetch_char changed.
8405
fb33fa43
SM
84062011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
8407
8408 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
8409
b099e063
DM
84102010-12-03 Don March <don@ohspite.net>
8411
8412 * keymap.c (Fdefine_key): Fix non-prefix key error message when
8413 last character M-[char] is translated to ESC [char] (bug#7541).
8414
5cc7f7af
KH
84152011-08-02 Kenichi Handa <handa@m17n.org>
8416
d0fffa3f 8417 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
8418
8419 * chartab.c (uniprop_table): Make it non-static.
8420
525d5e6e
EZ
84212011-08-01 Eli Zaretskii <eliz@gnu.org>
8422
8423 * xdisp.c (forward_to_next_line_start): Accept additional argument
8424 BIDI_IT_PREV, and store into it the state of the bidi iterator had
8425 on the newline.
8426 (reseat_at_next_visible_line_start): Use the bidi iterator state
8427 returned by forward_to_next_line_start to restore the state of
8428 it->bidi_it after backing up to previous newline. (Bug#9212)
8429
31011111
AS
84302011-07-30 Andreas Schwab <schwab@linux-m68k.org>
8431
8432 * regex.c (re_comp): Protoize.
8433 (re_exec): Fix return type.
8434 (regexec): Fix type of `ret'. (Bug#9203)
8435
476371c4
PE
84362011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8437
e5d76069
PE
8438 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
8439 This is needed if max-image-size is a floating-point number.
8440
9a79b20c
AS
84412011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8442
8443 * print.c (print_object): Print empty symbol as ##.
8444
8445 * lread.c (read1): Read ## as empty symbol.
8446
d8c2fa78
AA
84472011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
8448
8449 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
8450 setting frame foreground color (Bug#9175).
8451 (x_set_background_color): Likewise.
8452
ffe57a7a
AA
8453 * nsmenu.m (-setText): Size tooltip dimensions precisely to
8454 contents (Bug#9176).
8455 (EmacsTooltip -init): Remove bezels and add shadows to
8456 tooltip windows.
8457
bf3492a5
AA
8458 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
8459 or scroll bar (Bug#8470).
8460
d55e9c53
AA
8461 * nsfont.m (nsfont_open): Remove assignment to voffset and
8462 unnecessary vars hshink, expand, hd, full_height, min_height.
8463 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
8464
8465 * nsterm.h (nsfont_info): Remove voffset field.
8466
d8c2fa78 84672011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
8468
8469 Implement strike-through and overline on NextStep (Bug#8863).
8470
8471 * nsfont.m (nsfont_open): Use underline position provided by font,
8472 instead of hard-coded value of 2.
8473 (nsfont_draw): Call ns_draw_text_decoration instead.
8474
8475 * nsterm.h: Add declaration for ns_draw_text_decoration.
8476
8477 * nsterm.m (ns_draw_text_decoration): New function for drawing
8478 underline, overline, and strike-through.
8479 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
8480 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 8481 accommodate underlining, etc.
4843aac3 8482
4cc60b9b
EZ
84832011-07-28 Eli Zaretskii <eliz@gnu.org>
8484
bc7ece87
EZ
8485 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
8486 default.
4cc60b9b 8487
476371c4
PE
84882011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8489
66606eea
PE
8490 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
8491 Without this fix, if a signal arrives just after memory fills up,
8492 'malloc' might be invoked reentrantly.
8493
476371c4
PE
8494 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
8495 In other words, assume that every image size is allowed, on non-X
8496 hosts. This assumption is probably wrong, but it lets Emacs compile.
8497
f3fcc40d
AS
84982011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8499
8500 * regex.c (re_iswctype): Convert return values to boolean.
8501
350c992f
EZ
85022011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
8503
8504 * xdisp.c (compute_display_string_pos): Don't use cached display
8505 string position if the buffer had its restriction changed.
8506 (Bug#9184)
8507
5266b4bb
PE
85082011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8509
8510 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8511
2573a837 85122011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 8513
41f55ccd 8514 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 8515
39e378da
PE
8516 * bidi.c: Integer size and overflow fixes.
8517 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
8518 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
8519 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8520 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
8521 (bidi_find_other_level_edge):
8522 Use ptrdiff_t instead of EMACS_INT where either will do.
8523 This works better on 32-bit hosts configured --with-wide-int.
8524 (bidi_cache_ensure_space): Check for size-calculation overflow.
8525 Use % rather than repeated addition, for better worst-case speed.
8526 Don't set bidi_cache_size until after xrealloc returns, because it
8527 might not return.
8528 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
8529 (bidi_cache_ensure_space): Also check that the bidi cache size
8530 does not exceed that of the largest Lisp string or buffer. See Eli
8531 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 8532
5e927815
PE
8533 * alloc.c (__malloc_size_t): Remove.
8534 All uses replaced by size_t. See Andreas Schwab's note
8535 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
8536
ca4aa935
PE
8537 * image.c: Improve checking for integer overflow.
8538 (check_image_size): Assume that f is nonnull, since
8539 it is always nonnull in practice. This is one less thing to
8540 worry about when checking for integer overflow later.
8541 (x_check_image_size): New function, which checks for integer
8542 overflow issues inside X.
8543 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
8544 This removes the need for a memory_full check.
8545 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
8546 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
8547 (xbm_read_bitmap_data): Change locals back to 'int', since
8548 their values must fit in 'int'.
8549 (xpm_load_image, png_load, tiff_load):
8550 Invoke x_create_x_image_and_pixmap earlier,
8551 to avoid much needless work if the image is too large.
8552 (tiff_load): Treat overly large images as if
8553 x_create_x_image_and_pixmap failed, not as malloc failures.
8554 (gs_load): Use x_check_image_size.
8555
5f8f9cc2
PE
8556 * gtkutil.c: Omit integer casts.
8557 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
8558 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
8559
5adf60bc
PE
8560 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
8561
c8907a93
PE
8562 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
8563 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
8564 would wrongly return t on a 64-bit host.
8565
e3c25c68
PE
8566 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
8567 The plain *_OVERFLOW macros run afoul of GCC bug 49705
8568 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
8569 and therefore cause GCC to emit a bogus diagnostic in some cases.
8570
3f791afe
PE
8571 * image.c: Integer signedness and overflow and related fixes.
8572 This is not an exhaustive set of fixes, but it's time to
8573 record what I've got.
8574 (lookup_pixel_color, check_image_size): Remove redundant decls.
8575 (check_image_size): Don't assume that arbitrary EMACS_INT values
8576 fit in 'int', or that arbitrary 'double' values fit in 'int'.
8577 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
8578 (tiff_load, imagemagick_load_image):
8579 Check for overflow in size calculations.
8580 (x_create_x_image_and_pixmap): Remove unnecessary test for
8581 xmalloc returning NULL; that can't happen.
8582 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
8583 (xpm_color_bucket): Use better integer hashing function.
8584 (xpm_cache_color): Don't possibly over-allocate memory.
8585 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
8586 (gif_memory_source):
8587 Use ptrdiff_t, not int or size_t, to record sizes.
8588 (png_load): Don't assume values greater than 2**31 fit in 'int'.
8589 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
8590 either works, as we prefer signed integers.
8591 (tiff_read_from_memory, tiff_write_from_memory):
8592 Return tsize_t, not size_t, since that's what the TIFF API wants.
8593 (tiff_read_from_memory): Don't fail simply because the read would
8594 go past EOF; instead, return a short read.
8595 (tiff_load): Omit no-longer-needed casts.
8596 (Fimagemagick_types): Don't assume size fits into 'int'.
8597
3cc5a532
PE
8598 Improve hashing quality when configured --with-wide-int.
8599 * fns.c (hash_string): New function, taken from sxhash_string.
8600 Do not discard information about ASCII character case; this
8601 discarding is no longer needed.
8602 (sxhash-string): Use it. Change sig to match it. Caller changed.
8603 * lisp.h: Declare it.
8604 * lread.c (hash_string): Remove, since we now use fns.c's version.
8605 The fns.c version returns a wider integer if --with-wide-int is
8606 specified, so this should help the quality of the hashing a bit.
8607
b312a492
PE
8608 * emacs.c: Integer overflow minor fix.
8609 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
8610 Define only if GNU_LINUX.
8611 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
8612
dfd153ae
PE
8613 * dispnew.c: Integer signedness and overflow fixes.
8614 Remove unnecessary forward decls, that were a maintenance hassle.
8615 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
8616 All uses changed.
8617 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
8618 (scrolling_window): Use ptrdiff_t, not int, for byte count.
8619 (prepare_desired_row, line_draw_cost):
8620 Use int, not unsigned, where either works.
8621 (save_current_matrix, restore_current_matrix):
8622 Use ptrdiff_t, not size_t, where either works.
8623 (init_display): Check for overflow more accurately, and without
8624 relying on undefined behavior.
8625
a81d11a3
PE
8626 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
8627 Remove, replacing with the new symbols in lisp.h. All uses changed.
8628 * fileio.c (make_temp_name):
8629 * filelock.c (lock_file_1, lock_file):
8630 * xdisp.c (message_dolog):
8631 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
8632 Use pMd etc. instead.
8633 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
8634 replacing the pWIDE etc. symbols removed from editfns.c.
8635
3300e6fd
PE
8636 * keyboard.h (num_input_events): Now uintmax_t.
8637 This is (very slightly) less likely to mess up due to wraparound.
8638 All uses changed.
8639
fd05c7e9
PE
8640 * buffer.c: Integer signedness fixes.
8641 (alloc_buffer_text, enlarge_buffer_text):
8642 Use ptrdiff_t rather than size_t when either will do, as we prefer
8643 signed integers.
8644
903fe15d
PE
8645 * alloc.c: Integer signedness and overflow fixes.
8646 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
8647 (__malloc_size_t): Default to size_t, not to int.
8648 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
8649 (Fgarbage_collect, mark_object_loop_halt, mark_object):
8650 Prefer ptrdiff_t to size_t when either would do, as we prefer
8651 signed integers.
8652 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
8653 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
8654 Now const. Initialize with values that are in range even if char
8655 is signed.
8656 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
8657 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
8658 These functions do the right thing with sizes > 2**32.
8659 (check_depth): Now ptrdiff_t, not int.
8660 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
8661 Adjust to new way of storing sizes. Check for size overflow bugs
8662 in rest of code.
8663 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
8664 slightly wrong anyway, as it missed one instance of
8665 XMALLOC_OVERRUN_CHECK_OVERHEAD.
8666 (refill_memory_reserve): Omit needless cast to size_t.
8667 (mark_object_loop_halt): Mark as externally visible.
8668
ac82cc6a
PE
8669 * xselect.c: Integer signedness and overflow fixes.
8670 (Fx_register_dnd_atom, x_handle_dnd_message):
8671 Use ptrdiff_t, not size_t, since we prefer signed.
8672 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
8673 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
8674 x_dnd_atoms_size and x_dnd_atoms_length.
8675
c2d1e36d
PE
8676 * doprnt.c: Prefer signed to unsigned when either works.
8677 * eval.c (verror):
8678 * doprnt.c (doprnt):
8679 * lisp.h (doprnt):
8680 * xdisp.c (vmessage):
8681 Use ptrdiff_t, not size_t, when using or implementing doprnt,
8682 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
8683 prefer signed arithmetic to avoid comparison confusion.
8684 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
8685 but is a bit tricky.
8686
0e926e56
PE
8687 Assume freestanding C89 headers, string.h, stdlib.h.
8688 * data.c, doprnt.c, floatfns.c, print.c:
8689 Include float.h unconditionally.
8690 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
8691 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
8692 * regex.c: Likewise for stddef.h, string.h.
8693 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
8694 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
8695 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
8696 (STDC_HEADERS): Remove obsolete defines.
8697 * sysdep.c: Include limits.h unconditionally.
8698
9cfdb3ec
PE
8699 Assume support for memcmp, memcpy, memmove, memset.
8700 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
8701 * regex.c (memcmp, memcpy):
8702 Remove; we assume C89 now.
8703
8704 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
8705 (__malloc_safe_bcopy): Remove; no longer needed.
8706
cf950e6b 8707 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
8708 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
8709 well either way, and we prefer signed to unsigned.
8710
dbf38e02
LMI
87112011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
8712
8713 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
8714 closes the connection while we're reading (bug#9182).
8715
d6f0886c 87162011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 8717
d6f0886c
JD
8718 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
8719 are specified (Bug#9168).
24e0f6b1 8720
2eb1f9e6
PE
87212011-07-25 Paul Eggert <eggert@cs.ucla.edu>
8722
8723 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
8724 Found by GCC static checking and --with-wide-int on a 32-bit host.
8725
22381272 87262011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
8727
8728 * xdisp.c (compute_display_string_pos): Fix logic of caching
8729 previous display string position. Initialize cached_prev_pos to
8730 -1. Fixes slow-down at the beginning of a buffer.
8731
f25e39b4
EZ
87322011-07-24 Eli Zaretskii <eliz@gnu.org>
8733
8734 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
8735 for attrs[LFACE_FONTSET_INDEX].
8736
04c4b52e
PE
87372011-07-23 Paul Eggert <eggert@cs.ucla.edu>
8738
8739 * xml.c (parse_region): Remove unused local
8740 that was recently introduced.
8741
c1734fbd
EZ
87422011-07-23 Eli Zaretskii <eliz@gnu.org>
8743
be18c5a5
EZ
8744 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
8745 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
8746
c1734fbd
EZ
8747 * xdisp.c (move_it_in_display_line_to): Record the best matching
8748 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
8749 exit if none of the characters scanned was an exact match.
8750 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
8751 when exact match is impossible due to invisible text, and the
8752 lines are truncated.
8753
a258d627
JD
87542011-07-23 Jan Djärv <jan.h.d@swipnet.se>
8755
8756 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
8757 for OSX >= 10.7.
8758
b6d5a689
EZ
87592011-07-22 Eli Zaretskii <eliz@gnu.org>
8760
0f74f785
EZ
8761 Fix a significant slow-down of cursor motion with C-n, C-p,
8762 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
8763 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 8764 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
8765 (next_element_from_buffer): Call compute_stop_pos_backwards to
8766 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
8767 base_level_stop.
8768 (reseat): Don't look for prev_stop, as that could mean a very long
8769 run.
8770 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
8771 <cached_disp_overlay_modiff>: Cache for last found display string
8772 position.
551918c1 8773 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
8774 about the same buffer in the same area of character positions, and
8775 the buffer wasn't changed since the time the display string
8776 position was cached.
551918c1 8777
b2d0c91a
EZ
87782011-07-22 Eli Zaretskii <eliz@gnu.org>
8779
8780 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
8781 is an integer, which is important for empty lines. (Bug#9149)
8782
043604ee
CY
87832011-07-22 Chong Yidong <cyd@stupidchicken.com>
8784
8785 * frame.c (Fmodify_frame_parameters): In tty case, update the
8786 default face if necessary (Bug#4238).
8787
da4adb04
CY
87882011-07-21 Chong Yidong <cyd@stupidchicken.com>
8789
8790 * editfns.c (Fstring_to_char): No need to explain what a character
8791 is in the docstring (Bug#6576).
8792
9abd0532
LMI
87932011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8794
8795 * xml.c (parse_region): Make sure we always return a tree.
8796
36881d16
HK
87972011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
8798
8799 * xml.c (parse_region): If a document contains only comments,
8800 return that, too.
8801
1e98674d
LMI
88022011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8803
8804 * xml.c (make_dom): Return comments, too.
8805
590bd467
PE
88062011-07-19 Paul Eggert <eggert@cs.ucla.edu>
8807
8808 Port to OpenBSD.
8809 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
8810 and the surrounding thread.
8811 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
8812 rather than fgets, and retry after EINTR. Otherwise, 'emacs
8813 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
8814 timer goes off.
8815 * s/openbsd.h (BROKEN_SIGIO): Define.
8816 * unexelf.c (unexec) [__OpenBSD__]:
8817 Don't update the .mdebug section of the Alpha COFF symbol table.
8818
f41628b2
LMI
88192011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
8820
8821 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
8822 (bug#8460).
8823
b59b67c5
PE
88242011-07-18 Paul Eggert <eggert@cs.ucla.edu>
8825
15e3a074
PE
8826 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
8827 This fixes some race conditions on the permissions of any newly
8828 created file.
8829
41bed37d
PE
8830 * alloc.c (valid_pointer_p): Use pipe, not open.
8831 This fixes some permissions issues when debugging.
8832
b59b67c5
PE
8833 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
8834 If fchown fails to set both uid and gid, try to set just gid,
8835 as that is sometimes allowed. Adjust the file's mode to eliminate
8836 setuid or setgid bits that are inappropriate if fchown fails.
8837
925a6be7
SM
88382011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
8839
8840 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
8841 to compare Lisp_Objects.
8842 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
8843 global_gnutls_log_level, don't mistake it for a Lisp_Object.
8844 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
8845
52968808
AS
88462011-07-17 Andreas Schwab <schwab@linux-m68k.org>
8847
0a6a104b
AS
8848 * lread.c (read_integer): Unread even EOF character.
8849 (read1): Likewise. Properly record start position of symbol.
8850
52968808
AS
8851 * lread.c (read1): Read `#:' as empty uninterned symbol if no
8852 symbol character follows.
8853
9e381cdd
PE
88542011-07-17 Paul Eggert <eggert@cs.ucla.edu>
8855
8856 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
8857 This works around a problem with the previous change to Fcopy_file.
8858 Recent glibc declares fchown with __attribute__((warn_unused_result)),
8859 and without this change, GCC might complain about discarding
8860 fchown's return value.
8861
b5641435
JB
88622011-07-16 Juanma Barranquero <lekktu@gmail.com>
8863
8864 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
8865
a8031457
PE
88662011-07-16 Paul Eggert <eggert@cs.ucla.edu>
8867
8868 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
8869
dd889327
LMI
88702011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
8871
750c33f7
LMI
8872 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
8873 it's used from the C level.
8874
dd889327
LMI
8875 * process.c: Use the same condition for POLL_FOR_INPUT in both
8876 keyboard.c and process.c (bug#1858).
8877
87e86684
LM
88782011-07-09 Lawrence Mitchell <wence@gmx.li>
8879
8880 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
8881 (Fgnutls_boot): Use it.
8882
64348f40
AS
88832011-07-15 Andreas Schwab <schwab@linux-m68k.org>
8884
8885 * doc.c (Fsubstitute_command_keys): Revert last change.
8886
1d698799
LMI
88872011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
8888
f863868c
LMI
8889 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
8890 quotes the next character, and doesn't affect other longer
8891 sequences (bug#8935).
8892
1d698799
LMI
8893 * lread.c (syms_of_lread): Clarify that is isn't only
8894 `eval-buffer' and `eval-defun' that's affected by
8895 `lexical-binding' (bug#8460).
8896
aa4b6df6
EZ
88972011-07-15 Eli Zaretskii <eliz@gnu.org>
8898
8899 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 8900 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 8901
5d856da6
PE
89022011-07-14 Paul Eggert <eggert@cs.ucla.edu>
8903
ad6042bb
PE
8904 Fix minor problems found by static checking.
8905 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
8906 (elsz): Now a signed constant, not a size_t var. We prefer signed
8907 types to unsigned, to avoid integer comparison confusion. Without
8908 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
8909 "cannot optimize loop, the loop counter may overflow", a symptom
8910 of the confusion.
f00bbb22 8911 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
8912 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
8913
6468f31c
LMI
89142011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8915
49080b10
LMI
8916 * search.c (Fre_search_backward): Mention `case-fold-search' in
8917 all the re_search_* functions (bug#8138).
8918
6468f31c
LMI
8919 * keyboard.c (Fopen_dribble_file): Document when the file is
8920 closed (bug#8056).
8921
c965adc5
EZ
89222011-07-14 Eli Zaretskii <eliz@gnu.org>
8923
df9733bf
EZ
8924 * bidi.c (bidi_dump_cached_states): Fix format of displaying
8925 bidi_cache_idx.
8926
0bb23927
EZ
8927 Support bidi reordering of display and overlay strings.
8928 * xdisp.c (compute_display_string_pos)
8929 (compute_display_string_end): Accept additional argument STRING.
8930 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
8931 (reseat_to_string): Initialize bidi_it->string.s and
8932 bidi_it->string.schars.
8933 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
8934 NULL (avoids a crash in bidi_paragraph_init).
8935 Initialize itb.string.lstring.
0bb23927
EZ
8936 (init_iterator): Call bidi_init_it only of a valid
8937 buffer position was specified. Initialize paragraph_embedding to
8938 L2R.
8939 (reseat_to_string): Initialize the bidi iterator.
8940 (display_string): If we need to ignore text properties of
8941 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
8942 original value of -1 will not work with bidi.)
8943 (compute_display_string_pos): First arg is now struct
8944 `text_pos *'; all callers changed. Support display properties on
8945 Lisp strings.
8946 (compute_display_string_end): Support display properties on Lisp
8947 strings.
8948 (init_iterator, reseat_1, reseat_to_string): Initialize the
8949 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
8950 when iterating on a string not from display properties).
640c8776
SM
8951 (compute_display_string_pos, compute_display_string_end):
8952 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
8953 arrow keys.
8954 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
8955 base_level_stop; instead, set base_level_stop to BEGV.
8956 Fixes crashes in vertical-motion.
0bb23927
EZ
8957 (next_element_from_buffer): Improve commentary for when
8958 the iterator is before prev_stop.
8959 (init_iterator): Initialize bidi_p from the default value of
8960 bidi-display-reordering, not from buffer-local value. Use the
8961 buffer-local value only if initializing for buffer iteration.
8962 (handle_invisible_prop): Support invisible properties on strings
8963 that are being bidi-reordered.
8964 (set_iterator_to_next): Support bidi reordering of C strings and
8965 Lisp strings.
8966 (next_element_from_string): Support bidi reordering of Lisp
8967 strings.
8968 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
8969 (display_string): Support display of R2L glyph rows.
8970 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
8971 (init_iterator): Don't initialize it->bidi_p for strings
8972 here.
8973 (reseat_to_string): Initialize it->bidi_p for strings here.
8974 (next_element_from_string, next_element_from_c_string)
8975 (next_element_from_buffer): Add xassert's for correspondence
8976 between IT's object being iterated and it->bidi_it.string
8977 structure.
8978 (face_before_or_after_it_pos): Support bidi iteration.
8979 (next_element_from_c_string): Handle the case of the first string
8980 character that is not the first one in the visual order.
8981 (get_visually_first_element): New function, refactored from common
8982 parts of next_element_from_buffer, next_element_from_string, and
8983 next_element_from_c_string.
8984 (tool_bar_lines_needed, redisplay_tool_bar)
8985 (display_menu_bar): Force left-to-right direction. Add a FIXME
8986 comment for making that be controlled by a user option.
8987 (push_it, pop_it): Save and restore the state of the
8988 bidi iterator. Save and restore the bidi_p flag.
8989 (pop_it): Iterate out of display property for string iteration as
8990 well.
8991 (iterate_out_of_display_property): Support iteration over strings.
8992 (handle_single_display_spec): Set up it->bidi_it for iteration
8993 over a display string, and call bidi_init_it.
8994 (handle_single_display_spec, next_overlay_string)
8995 (get_overlay_strings_1, push_display_prop): Set up the bidi
8996 iterator for displaying display or overlay strings.
8997 (forward_to_next_line_start): Don't use the shortcut if
8998 bidi-iterating.
8999 (back_to_previous_visible_line_start): If handle_display_prop
9000 pushed the iterator stack, restore the internal state of the bidi
9001 iterator by calling bidi_pop_it same number of times.
9002 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
9003 and we are bidi-iterating, don't decrement the iterator position;
9004 instead, set the first_elt flag in the bidi iterator, to produce
9005 the same effect.
9006 (reseat_1): Remove redundant setting of string_from_display_prop_p.
9007 (push_display_prop): xassert that we are iterating a buffer.
9008 (push_it, pop_it): Save and restore paragraph_embedding member.
9009 (handle_single_display_spec, next_overlay_string)
9010 (get_overlay_strings_1, reseat_1, reseat_to_string)
9011 (push_display_prop): Set up the `unibyte' member of bidi_it.string
9012 correctly. Don't assume unibyte strings are not bidi-reordered.
9013 (compute_display_string_pos)
9014 (compute_display_string_end): Fix handling the case of C string.
9015 (push_it, pop_it): Save and restore from_disp_prop_p.
9016 (handle_single_display_spec, push_display_prop): Set the
9017 from_disp_prop_p flag.
9018 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
9019 (pop_it): Call iterate_out_of_display_property only if we are
9020 popping after iteration over a string that came from a display
9021 property. Fix a typo in popping stretch info. Add an assertion
9022 for verifying that the iterator position is in sync with the bidi
9023 iterator.
9024 (handle_single_display_spec, get_overlay_strings_1)
9025 (push_display_prop): Fix initialization of paragraph direction for
9026 string when that of the parent object is not yet determined.
9027 (reseat_1): Call bidi_init_it to resync the bidi
9028 iterator with IT's position. (Bug#7616)
9029 (find_row_edges): If ROW->start.pos gives position
9030 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
9031 (handle_stop, back_to_previous_visible_line_start, reseat_1):
9032 Reset the from_disp_prop_p flag.
9033 (SAVE_IT, RESTORE_IT): New macros.
9034 (pos_visible_p, face_before_or_after_it_pos)
9035 (back_to_previous_visible_line_start)
9036 (move_it_in_display_line_to, move_it_in_display_line)
9037 (move_it_to, move_it_vertically_backward, move_it_by_lines)
9038 (try_scrolling, redisplay_window, display_line): Use them when
9039 saving a temporary copy of the iterator and restoring it back.
9040 (back_to_previous_visible_line_start, reseat_1)
9041 (init_iterator): Empty the bidi cache "stack".
9042 (move_it_in_display_line_to): If iterator ended up at
9043 EOL, but we never saw any buffer positions smaller than
9044 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
9045 motion in bidi-reordered lines.
9046 (move_it_in_display_line_to): Record prev_method and prev_pos
9047 immediately before the call to set_iterator_to_next. Fixes cursor
9048 motion in bidi-reordered lines with stretch glyphs and strings
9049 displayed in margins. (Bug#8133) (Bug#8867)
9050 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
9051 TO_CHARPOS.
640c8776
SM
9052 (pos_visible_p): Support positions in bidi-reordered lines.
9053 Save and restore bidi cache.
0bb23927
EZ
9054
9055 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
9056 (bidi_paragraph_info): Delete unused struct.
9057 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
9058 (bidi_cache_start): New variable.
9059 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
9060 to zero.
9061 (bidi_cache_fetch_state, bidi_cache_search)
9062 (bidi_cache_find_level_change, bidi_cache_iterator_state)
9063 (bidi_cache_find, bidi_peek_at_next_level)
9064 (bidi_level_of_next_char, bidi_find_other_level_edge)
9065 (bidi_move_to_visually_next): Compare cache index with
9066 bidi_cache_start rather than with zero.
9067 (bidi_fetch_char): Accept new argument STRING; all callers
9068 changed. Support iteration over a string. Support strings with
9069 display properties. Support unibyte strings. Fix the type of
9070 `len' according to what STRING_CHAR_AND_LENGTH expects.
9071 (bidi_paragraph_init, bidi_resolve_explicit_1)
9072 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
9073 (bidi_level_of_next_char, bidi_move_to_visually_next):
9074 Support iteration over a string.
0bb23927
EZ
9075 (bidi_set_sor_type, bidi_resolve_explicit_1)
9076 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
9077 can now be zero (for strings); special values 0 and -1 were
9078 changed to -1 and -2, respectively.
9079 (bidi_char_at_pos): New function.
9080 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
9081 Call it instead of FETCH_MULTIBYTE_CHAR.
9082 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
9083 initialized to valid values.
9084 (bidi_init_it): Don't initialize charpos and bytepos with invalid
9085 values.
9086 (bidi_level_of_next_char): Allow the sentinel "position" to pass
9087 the test for valid cached positions. Fix the logic for looking up
9088 the sentinel state in the cache. GCPRO the Lisp string we are
9089 iterating.
9090 (bidi_push_it, bidi_pop_it): New functions.
9091 (bidi_initialize): Initialize the bidi cache start stack pointer.
9092 (bidi_cache_ensure_space): New function, refactored from part of
9093 bidi_cache_iterator_state. Don't assume the required size is just
9094 one BIDI_CACHE_CHUNK away.
9095 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
9096 (bidi_count_bytes, bidi_char_at_pos): New functions.
9097 (bidi_cache_search): Don't assume bidi_cache_last_idx is
9098 always valid if bidi_cache_idx is valid.
9099 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
9100 is valid if it's going to be used.
9101 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
9102 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
9103 (bidi_cache_find_level_change, bidi_cache_ensure_space)
9104 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
9105 (bidi_find_other_level_edge, bidi_cache_start_stack):
9106 All variables related to cache indices are now EMACS_INT.
c965adc5 9107
0bb23927
EZ
9108 * dispextern.h (struct bidi_string_data): New structure.
9109 (struct bidi_it): New member `string'. Make flag members be 1-bit
9110 fields, and put them last in the struct.
640c8776
SM
9111 (compute_display_string_pos, compute_display_string_end):
9112 Update prototypes.
0bb23927
EZ
9113 (bidi_push_it, bidi_pop_it): Add prototypes.
9114 (struct iterator_stack_entry): New members bidi_p,
9115 paragraph_embedding, and from_disp_prop_p.
9116 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
9117 (bidi_shelve_cache, bidi_unshelve_cache):
9118 Declare prototypes.
0bb23927
EZ
9119
9120 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
9121 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
9122 and vector-like objects.
9123
9124 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
9125 cache around display iteration.
9126
9127 * window.c (Fwindow_end, window_scroll_pixel_based)
9128 (displayed_window_lines, Frecenter): Save and restore the bidi
9129 cache around display iteration.
9130
3bbd2265
LMI
91312011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
9132
9133 * editfns.c (Fdelete_region): Clarify the use of the named
9134 parameters (bug#6788).
9135
adc47434
MR
91362011-07-14 Martin Rudalics <rudalics@gmx.at>
9137
9138 * indent.c (Fvertical_motion): Set and restore w->pointm when
9139 saving and restoring the window's buffer (Bug#9006).
9140
837c31f8
LMI
91412011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
9142
9143 * editfns.c (Fstring_to_char): Clarify just what is returned
9144 (bug#6576). Text by Eli Zaretskii.
9145
ac389d0c
JB
91462011-07-13 Juanma Barranquero <lekktu@gmail.com>
9147
9148 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
9149
0be0ce47
EZ
91502011-07-13 Eli Zaretskii <eliz@gnu.org>
9151
9152 * buffer.c (mmap_find): Fix a typo.
9153
cd18e7e3
JB
91542011-07-13 Johan Bockgård <bojohan@gnu.org>
9155
9156 Fix execution of x selection hooks.
9157 * xselect.c (Qx_lost_selection_functions)
9158 (Qx_sent_selection_functions): New vars.
9159 (syms_of_xselect): DEFSYM them.
9160 (x_handle_selection_request): Pass Qx_sent_selection_functions
9161 rather than Vx_sent_selection_functions to Frun_hook_with_args.
9162 (x_handle_selection_clear,x_clear_frame_selections):
9163 Pass Qx_lost_selection_functions rather than
9164 Vx_lost_selection_functions to Frun_hook_with_args.
9165
47ea7f44
PE
91662011-07-13 Paul Eggert <eggert@cs.ucla.edu>
9167
ac389d0c 9168 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
9169 The old code sometimes used this field without initializing it.
9170
47ea7f44
PE
9171 * alloc.c (gc_sweep): Don't read past end of array.
9172 In theory, the old code could also have corrupted Emacs internals,
9173 though it'd be very unlikely.
9174
bc985c87
AS
91752011-07-12 Andreas Schwab <schwab@linux-m68k.org>
9176
9177 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 9178 argument. (Bug#4026)
bc985c87 9179
0cf34688
LMI
91802011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
9181
b3dadd76
LMI
9182 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
9183 key" (bug#4257).
9184
0cf34688
LMI
9185 * window.c (Fset_window_start): Doc fix (bug#4199).
9186 (Fset_window_hscroll): Ditto.
9187
270768cd
PE
91882011-07-12 Paul Eggert <eggert@cs.ucla.edu>
9189
077e3dda 9190 Fix minor new problems caught by GCC 4.6.1.
270768cd 9191 * term.c (init_tty): Remove unused local.
490011a6 9192 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 9193 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 9194 not used otherwise.
270768cd 9195
b1f58454
CY
91962011-07-12 Chong Yidong <cyd@stupidchicken.com>
9197
9198 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
9199
22b9578d
LMI
92002011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
9201
6e70ab07
LMI
9202 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
9203 are the mini-buffer and the echo area (bug#3320).
9204
22b9578d
LMI
9205 * term.c (init_tty): Remove support for supdup, c10 and perq
9206 terminals, which are no longer supported (bug#1482).
9207
8974cc9f
JB
92082011-07-10 Johan Bockgård <bojohan@gnu.org>
9209
9210 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
9211
a560d974
JD
92122011-07-10 Jan Djärv <jan.h.d@swipnet.se>
9213
9214 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
9215 for non-popups (Bug#3642).
9216
1dae0f0a
AS
92172011-07-10 Andreas Schwab <schwab@linux-m68k.org>
9218
268c2c36 9219 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 9220 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
9221 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
9222 * cm.c (losecursor): Likewise.
1dae0f0a
AS
9223 * data.c (fmod): Likewise.
9224 * dispnew.c (swap_glyphs_in_rows): Likewise.
9225 * emacs.c (memory_warning_signal): Likewise.
9226 * floatfns.c (float_error): Likewise.
9227 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
9228 (otf_open, font_otf_capability, generate_otf_features)
9229 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
9230 Likewise.
9231 * image.c (pbm_read_file): Likewise.
9232 * indent.c (string_display_width): Likewise.
9233 * intervals.c (check_for_interval, search_for_interval)
9234 (inc_interval_count, count_intervals, root_interval)
9235 (adjust_intervals_for_insertion, make_new_interval): Likewise.
9236 * lread.c (defalias): Likewise.
268c2c36 9237 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
9238 * regex.c (set_image_of_range_1, set_image_of_range)
9239 (regex_grow_registers): Likewise.
9240 * sysdep.c (strerror): Likewise.
9241 * termcap.c (valid_filename_p, tprint, main): Likewise.
9242 * tparam.c (main): Likewise.
9243 * unexhp9k800.c (run_time_remap, save_data_space)
9244 (update_file_ptrs, read_header, write_header, calculate_checksum)
9245 (copy_file, copy_rest, display_header): Likewise.
9246 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
9247 Likewise.
9248 * xdisp.c (check_it): Likewise.
9249 * xfaces.c (register_color, unregister_color, unregister_colors):
9250 Likewise.
9251 * xfns.c (print_fontset_result): Likewise.
9252 * xrdb.c (member, fatal, main): Likewise.
9253
99033785
PE
92542011-07-10 Paul Eggert <eggert@cs.ucla.edu>
9255
9256 Fix minor problems found by static checking (Bug#9031).
9257 * chartab.c (char_table_set_range, map_sub_char_table):
9258 Remove unused locals.
9259 (uniprop_table): Now static.
9260 * composite.c (_work_char): Remove unused static var.
9261
9cb2ac56
JB
92622011-07-09 Juanma Barranquero <lekktu@gmail.com>
9263
9264 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
9265
f25661f0
JD
92662011-07-09 Jan Djärv <jan.h.d@swipnet.se>
9267
9268 * gtkutil.c (qttip_cb): Remove code without function.
9269
8278c4fe
EZ
92702011-07-09 Eli Zaretskii <eliz@gnu.org>
9271
9272 * w32.c (pthread_sigmask): New stub.
9273
1692ae2d 92742011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 9275
8a6ebd58 9276 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
9277 sigprocmask is portable only for single-threaded applications, and
9278 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
9279 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
9280 (LIBES): Use it.
9281 * callproc.c (Fcall_process):
9282 * process.c (create_process):
9283 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
9284 Use pthread_sigmask, not sigprocmask.
123403e4 9285
1b854618
JD
92862011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9287
9288 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
9289 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
9290 wrong (Bug#8591).
9291
3fe4b549
JD
92922011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9293
0ce7e563
JD
9294 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
9295 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
9296 (xg_hide_tooltip): Fix comment.
9297
3fe4b549
JD
9298 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
9299 in registerServicesMenuSendTypes.
9300 (validRequestorForSendType): Don't check ns_return_types.
9301
9302 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
9303 ns_return_type.
9304
5df75e47
JR
93052011-07-08 Jason Rumney <jasonr@gnu.org>
9306
22610910
JR
9307 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
9308 SH_SHOW for hidden windows (Bug#5482).
9309
5df75e47
JR
9310 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
9311 frame struct members of non-existent frames (Bug#6284).
9312
699c10bd
JD
93132011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9314
4393663b
JD
9315 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
9316 variable firstTime not needed on OSX >= 10.6.
9317 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
9318 >= 10.5. Use setKnobProportion, setDoubleValue.
9319
9320 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
9321 (MAC_OS_X_VERSION_10_5): Define if not defined.
9322 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
9323 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
9324 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
9325
9326 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 9327 cString and lossyCString on OSX >= 10.4.
4393663b 9328
58179cce 9329 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
9330 sizeToFit on OSX >= 10.2.
9331
9332 * nsimage.m (allocInitFromFile): Don't use deprecated method
9333 bestRepresentationForDevice on OSX >= 10.6.
9334
9335 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
9336 to avoid warning.
9337
9338 * emacs.c: Declare unexec_init_emacs_zone.
9339
a63e0781
JD
9340 * nsgui.h: Fix compiler warning about gnulib redefining verify.
9341
699c10bd
JD
9342 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
9343
9344 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
9345 on svcsMenu (Bug#8842).
9346
9347 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
9348 ns_return_types.
9349 (Fns_list_services): Just return Qnil on 10.6, code not working there.
9350
9351 * nsterm.m (QUTF8_STRING): Declare.
9352 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
9353 (validRequestorForSendType): Return type is (id).
9354 Change indexOfObjectIdenticalTo to indexOfObject.
9355 Check if we have local selection before returning self (Bug#8842).
9356 (writeSelectionToPasteboard): Put local selection into paste board
9357 if we have a local selection (Bug#8842).
9358 (syms_of_nsterm): DEFSYM QUTF8_STRING.
9359
9360 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
9361 (ns_get_local_selection): Declare.
9362
54e10184
LMI
93632011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
9364
9888ff71
LMI
9365 * keymap.c (describe_map_tree): Don't insert a double newline at
9366 the end of the buffer (bug#1169) and return whether we inserted
9367 something.
9368
54e10184
LMI
9369 * callint.c (Fcall_interactively): Change "reading args" to
9370 "providing args" to try to clarify what it does (bug#1010).
9371
15fa4783
KH
93722011-07-07 Kenichi Handa <handa@m17n.org>
9373
9374 * composite.c (composition_compute_stop_pos): Ignore a static
9375 composition starting before CHARPOS (Bug#8915).
9376
9377 * xdisp.c (handle_composition_prop): Likewise.
9378
a8815b00
EZ
93792011-07-07 Eli Zaretskii <eliz@gnu.org>
9380
9381 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
9382 (Bug#9015)
9383
ef7b981d 93842011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
9385
9386 * character.h (unicode_category_t): New enum type.
9387
9388 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
9389 (Qchar_code_property_table): New variable.
9390 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
9391 (UNIPROP_COMPRESSED_FORM_P): New macros.
9392 (char_table_ascii): Uncompress the compressed values.
9393 (sub_char_table_ref): New arg is_uniprop. Callers changed.
9394 Uncompress the compressed values.
ac389d0c 9395 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
9396 (char_table_ref_and_range): Uncompress the compressed values.
9397 (sub_char_table_set): New arg is_uniprop. Callers changed.
9398 Uncompress the compressed values.
9399 (sub_char_table_set_range): Args changed. Callers changed.
9400 (char_table_set_range): Adjuted for the above change.
9401 (map_sub_char_table): Delete args default_val and parent. Add arg
9402 top. Give decoded values to a Lisp function.
640c8776 9403 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
9404 values to a Lisp function. Gcpro more variables.
9405 (uniprop_table_uncompress)
9406 (uniprop_decode_value_run_length): New functions.
9407 (uniprop_decoder, uniprop_decoder_count): New variables.
9408 (uniprop_get_decoder, uniprop_encode_value_character)
9409 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
9410 New functions.
9411 (uniprop_encoder, uniprop_encoder_count): New variables.
9412 (uniprop_get_encoder, uniprop_table)
9413 (Funicode_property_table_internal, Fget_unicode_property_internal)
9414 (Fput_unicode_property_internal): New functions.
9415 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
9416 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 9417 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
9418 char-code-property-alist.
9419
640c8776 9420 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
9421 Vunicode_category_table.
9422
640c8776 9423 * font.c (font_range): Adjust for the change of
c805dec0
KH
9424 Vunicode_category_table.
9425
76b397fb
DN
94262011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
9427
9428 * m/iris4d.h: Remove file, move contents ...
9429 * s/irix6-5.h: ... here.
9430
22b4128e
PE
94312011-07-06 Paul Eggert <eggert@cs.ucla.edu>
9432
9433 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
9434 * alloc.c (mark_buffer):
9435 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
9436 (clone_per_buffer_values): Don't assume that
22b4128e
PE
9437 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
9438 This isn't true in general, and it's particularly not true
9439 if Emacs is configured with --with-wide-int.
9440 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
9441 New macros, used in the buffer.c change.
9442
869795d6
JD
94432011-07-05 Jan Djärv <jan.h.d@swipnet.se>
9444
9445 * xsettings.c: Use both GConf and GSettings if both are available.
9446 (store_config_changed_event): Add comment.
9447 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
9448 (store_tool_bar_style_changed): New functions.
5e617bc2 9449 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
9450 (struct xsettings): Move font inside HAVE_XFT.
9451 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 9452 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 9453 Move inside HAVE_XFT.
640c8776 9454 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
9455 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
9456 also.
9457 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 9458 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 9459 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
9460 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
9461 (parse_settings): Move check for font inside HAVE_XFT.
9462 (read_settings, apply_xft_settings): Add comment.
9463 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
9464 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
9465 call store_font_name_changed.
9466 (xft_settings_event): Add comment.
9467 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
9468 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
9469 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
9470 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
9471 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
9472 (xsettings_get_system_font, xsettings_get_system_normal_font):
9473 Add comment.
869795d6 9474
d8ed26bd
PE
94752011-07-05 Paul Eggert <eggert@cs.ucla.edu>
9476
9477 Random fixes. E.g., (random) never returned negative values.
9478 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
9479 subseconds part to the entropy, as that's a bit more random.
9480 Prefer signed to unsigned, since the signedness doesn't matter and
9481 in general we prefer signed. When given a limit, use a
9482 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
9483 latter isn't right if USE_2_TAGS_FOR_INTS.
9484 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
9485 not 0..VALMASK. Don't discard "excess" bits that random () returns.
9486
cabf1cac
SM
94872011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
9488
9489 * textprop.c (text_property_stickiness):
9490 Obey Vtext_property_default_nonsticky.
9491 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
9492 * w32fns.c (syms_of_w32fns):
9493 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
9494
6e9b2be9
PE
94952011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9496
9497 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
9498 This is more efficient than Ffile_directory_p and avoids a minor race.
9499
90186c68
LMI
95002011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
9501
7c301272
LMI
9502 * buffer.c (Foverlay_put): Say what the return value is
9503 (bug#7835).
9504
c4f2d8d4
LMI
9505 * fileio.c (barf_or_query_if_file_exists): Check first if the file
9506 is a directory before asking whether to use the file name
9507 (bug#7564).
ad637907
LMI
9508 (barf_or_query_if_file_exists): Make the "File is a directory"
9509 error be more correct.
c4f2d8d4 9510
90186c68
LMI
9511 * fns.c (Frequire): Remove the mention of the .gz files, since
9512 that's installation-specific, but keep the mention of
9513 `get-load-suffixes'.
9514
da64016e
PE
95152011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9516
9517 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
9518 Report string overflow if the output is too long.
9519
7d47b580
JB
95202011-07-04 Juanma Barranquero <lekktu@gmail.com>
9521
a555cb87
JB
9522 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
9523 (syms_of_gnutls): Remove duplicate DEFSYM for
9524 Qgnutls_bootprop_verify_hostname_error, an error for
9525 Qgnutls_bootprop_verify_error (which is no longer used).
9526
7d47b580
JB
9527 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
9528 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
9529 Also (re)move comments that are misplaced or no longer relevant.
9530
1e49bfab
LMI
95312011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9532
9533 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
9534
1485f4c0
CY
95352011-07-03 Chong Yidong <cyd@stupidchicken.com>
9536
9537 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
9538 and background color parameters if they have been changed.
9539
a9ab721e
LMI
95402011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9541
9542 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
9543
cf7cff57
PE
95442011-07-03 Paul Eggert <eggert@cs.ucla.edu>
9545
2e13213d
PE
9546 * xsettings.c (SYSTEM_FONT): Define only when used.
9547 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
9548
cf7cff57
PE
9549 * keymap.c (access_keymap_1): Now static.
9550
7a8e04f7
CY
95512011-07-02 Chong Yidong <cyd@stupidchicken.com>
9552
9553 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
9554 leave any prefix arg for the up event (Bug#1586).
9555
61352f62
LMI
95562011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
9557
69bb1ef7
LMI
9558 * lread.c (syms_of_lread): Mention single symbols defined by
9559 `defvar' or `defconst' (bug#7154).
9560
61352f62 9561 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 9562 (Frequire): Mention get-load-suffixes.
61352f62 9563
28545e04
MR
95642011-07-02 Martin Rudalics <rudalics@gmx.at>
9565
9566 * window.h (window): Remove clone_number slot.
9567 * window.c (Fwindow_clone_number, Fset_window_clone_number):
9568 Remove.
9569 (make_parent_window, make_window, saved_window)
9570 (Fset_window_configuration, save_window_save): Don't deal with
9571 clone numbers.
9572 * buffer.c (Qclone_number): Remove declaration.
9573 (sort_overlays, overlay_strings): Don't deal with clone numbers.
9574
3349e122
SM
95752011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
9576
9577 Add multiple inheritance to keymaps.
9578 * keymap.c (Fmake_composed_keymap): New function.
9579 (Fset_keymap_parent): Simplify.
9580 (fix_submap_inheritance): Remove.
9581 (access_keymap_1): New function extracted from access_keymap to handle
9582 embedded parents and handle lists of maps.
9583 (access_keymap): Use it.
9584 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
9585 (Fcopy_keymap): Handle embedded parents.
9586 (Fcommand_remapping, define_as_prefix): Simplify.
9587 (Fkey_binding): Simplify.
9588 (syms_of_keymap): Move minibuffer-local-completion-map,
9589 minibuffer-local-filename-completion-map,
9590 minibuffer-local-must-match-map, and
9591 minibuffer-local-filename-must-match-map to Elisp.
9592 (syms_of_keymap): Defsubr make-composed-keymap.
9593 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
9594 (parse_menu_item): Trivial simplification.
9595
3279eb87
GM
95962011-07-01 Glenn Morris <rgm@gnu.org>
9597
9598 * Makefile.in (SETTINGS_LIBS): Fix typo.
9599
4550efdf
KI
96002011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
9601
9602 * coding.c (Fencode_coding_string): Record the last coding system
9603 used, as the function doc string says (bug#8738).
9604
0949d2b6
JD
96052011-07-01 Jan Djärv <jan.h.d@swipnet.se>
9606
9607 * xsettings.c (store_monospaced_changed): Take new font as arg and
9608 check for change against current_mono_font.
9609 (EMACS_TYPE_SETTINGS): Remove this and related defines.
9610 (emacs_settings_constructor, emacs_settings_get_property)
9611 (emacs_settings_set_property, emacs_settings_class_init)
9612 (emacs_settings_init, gsettings_obj): Remove.
9613 (something_changedCB): New function for HAVE_GSETTINGS.
9614 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
9615 with value as argument.
9616 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
9617 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 9618 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
9619 "changed".
9620
9621 * xgselect.c: Add defined (HAVE_GSETTINGS).
9622 (xgselect_initialize): Ditto.
9623
9624 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
9625 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
9626 xg_select.
9627
bbc6b304
PE
96282011-07-01 Paul Eggert <eggert@cs.ucla.edu>
9629
9630 * eval.c (struct backtrace): Simplify and port the data structure.
9631 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
9632 signed bit field, as this assumption is not portable and it makes
9633 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
9634 "char debug_on_exit : 1" as this is not portable either; instead,
9635 use the portable "unsigned int debug_on_exit : 1". Remove unused
9636 member evalargs. Remove obsolete comments about cc bombing out.
9637
9851bfc5
JD
96382011-06-30 Jan Djärv <jan.h.d@swipnet.se>
9639
51bb811f 9640 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
9641 Let HAVE_GSETTINGS override HAVE_GCONF.
9642 (store_monospaced_changed): New function.
9643 (EMACS_SETTINGS): A new type derived from GObject to handle
9644 GSettings notifications.
9645 (emacs_settings_constructor, emacs_settings_get_property)
9646 (emacs_settings_set_property, emacs_settings_class_init):
9647 New functions.
9648 (gsettings_client, gsettings_obj): New variables.
9649 (GSETTINGS_SCHEMA): New define.
9650 (something_changedCB): Call store_monospaced_changed.
9651 (init_gsettings): New function.
9652 (xsettings_initialize): Call init_gsettings.
9653 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
9654 to NULL.
9655
640c8776 9656 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
9657 GCONF_CFLAGS/LIBS.
9658
5386012d
MR
96592011-06-29 Martin Rudalics <rudalics@gmx.at>
9660
9661 * window.c (resize_root_window, grow_mini_window)
9662 (shrink_mini_window): Rename Qresize_root_window to
9663 Qwindow_resize_root_window and Qresize_root_window_vertically to
9664 Qwindow_resize_root_window_vertically.
9665
f13e0b08
PE
96662011-06-28 Paul Eggert <eggert@cs.ucla.edu>
9667
9668 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
9669
94515237
JB
96702011-06-27 Juanma Barranquero <lekktu@gmail.com>
9671
9672 * makefile.w32-in: Redesign dependencies so they reflect more
9673 clearly which files are directly included by each source file,
9674 and not through other includes.
9675
e43b6e43
MR
96762011-06-27 Martin Rudalics <rudalics@gmx.at>
9677
9678 * buffer.c (Qclone_number): Declare static and DEFSYM it.
9679 (sort_overlays, overlay_strings): When an overlay's clone number
9680 matches the window's clone number process the overlay even if
9681 the overlay's window property doesn't match the current window.
9682
d68443dc
MR
9683 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
9684 (Fwindow_hchild): Rename to Fwindow_left_child.
9685 (Fwindow_next): Rename to Fwindow_next_sibling.
9686 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
9687 (resize_window_check): Rename to window_resize_check.
9688 (resize_window_apply): Rename to window_resize_apply.
9689 (Fresize_window_apply): Rename to Fwindow_resize_apply.
9690 (Fdelete_other_windows_internal, resize_frame_windows)
9691 (Fsplit_window_internal, Fdelete_window_internal)
9692 (grow_mini_window, shrink_mini_window)
9693 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 9694
c7e73be5
JD
96952011-06-26 Jan Djärv <jan.h.d@swipnet.se>
9696
9697 * emacsgtkfixed.h: State that this is only used with Gtk+3.
9698 (emacs_fixed_set_min_size): Remove.
9699 (emacs_fixed_new): Take frame as argument.
9700
9701 * emacsgtkfixed.c: State that this is only used with Gtk+3.
9702 (_EmacsFixedPrivate): Remove minwidth/height.
9703 Add struct frame *f.
9704 (emacs_fixed_init): Initialize priv->f.
9705 (get_parent_class, emacs_fixed_set_min_size): Remove.
9706 (emacs_fixed_new): Set priv->f to argument.
9707 (emacs_fixed_get_preferred_width)
9708 (emacs_fixed_get_preferred_height): Use min_width/height from
9709 frames size_hint to set minimum and natural (Bug#8919).
9710 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
9711 and use min_width/height from frames size_hint to set
9712 min_width/height (Bug#8919).
9713
9714 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
9715 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
9716 Fix indentation.
c7e73be5 9717
cf99dcf8
EZ
97182011-06-26 Eli Zaretskii <eliz@gnu.org>
9719
9720 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
9721 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
9722 called at ZV.
9723
029529ac
CY
97242011-06-26 Chong Yidong <cyd@stupidchicken.com>
9725
9726 * process.c (wait_reading_process_output): Bypass select if
9727 waiting for a cell while ignoring keyboard input, and input is
9728 pending. Suggested by Jan Djärv (Bug#8869).
9729
7a7ef429
PE
97302011-06-25 Paul Eggert <eggert@cs.ucla.edu>
9731
9732 Use gnulib's dup2 module instead of rolling our own.
9733 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
9734
11fdef7d 97352011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
9736
9737 * dispnew.c (scrolling_window): Before scrolling, turn off a
9738 mouse-highlight in the window being scrolled.
9739
cd3520a4
JB
97402011-06-24 Juanma Barranquero <lekktu@gmail.com>
9741
9742 Move DEFSYM to lisp.h and use everywhere.
9743
9744 * character.h (DEFSYM): Move declaration...
9745 * lisp.h (DEFSYM): ...here.
9746
9747 * gnutls.c:
9748 * minibuf.c:
9749 * w32menu.c:
9750 * w32proc.c:
9751 * w32select.c: Don't include character.h.
9752
9753 * alloc.c (syms_of_alloc):
9754 * buffer.c (syms_of_buffer):
9755 * bytecode.c (syms_of_bytecode):
9756 * callint.c (syms_of_callint):
9757 * casefiddle.c (syms_of_casefiddle):
9758 * casetab.c (init_casetab_once):
9759 * category.c (init_category_once, syms_of_category):
9760 * ccl.c (syms_of_ccl):
9761 * cmds.c (syms_of_cmds):
9762 * composite.c (syms_of_composite):
9763 * dbusbind.c (syms_of_dbusbind):
9764 * dired.c (syms_of_dired):
9765 * dispnew.c (syms_of_display):
9766 * doc.c (syms_of_doc):
9767 * editfns.c (syms_of_editfns):
9768 * emacs.c (syms_of_emacs):
9769 * eval.c (syms_of_eval):
9770 * fileio.c (syms_of_fileio):
9771 * fns.c (syms_of_fns):
9772 * frame.c (syms_of_frame):
9773 * fringe.c (syms_of_fringe):
9774 * insdel.c (syms_of_insdel):
9775 * keymap.c (syms_of_keymap):
9776 * lread.c (init_obarray, syms_of_lread):
9777 * macros.c (syms_of_macros):
9778 * msdos.c (syms_of_msdos):
9779 * print.c (syms_of_print):
9780 * process.c (syms_of_process):
9781 * search.c (syms_of_search):
9782 * sound.c (syms_of_sound):
9783 * syntax.c (init_syntax_once, syms_of_syntax):
9784 * terminal.c (syms_of_terminal):
9785 * textprop.c (syms_of_textprop):
9786 * undo.c (syms_of_undo):
9787 * w32.c (globals_of_w32):
9788 * window.c (syms_of_window):
9789 * xdisp.c (syms_of_xdisp):
9790 * xfaces.c (syms_of_xfaces):
9791 * xfns.c (syms_of_xfns):
9792 * xmenu.c (syms_of_xmenu):
9793 * xsettings.c (syms_of_xsettings):
9794 * xterm.c (syms_of_xterm): Use DEFSYM.
9795
4228cf16
TZ
97962011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
9797
cd3520a4 9798 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 9799
7fcccf1e
PE
98002011-06-23 Paul Eggert <eggert@cs.ucla.edu>
9801
7efb4e0e
PE
9802 Integer and buffer overflow fixes (Bug#8873).
9803
ff5844ad
PE
9804 * print.c (printchar, strout): Check for string overflow.
9805 (PRINTPREPARE, printchar, strout):
9806 Don't set size unless allocation succeeds.
9807
90532f02
PE
9808 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
9809 for sizes. Check for string overflow more accurately.
9810 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
9811
6d84508d
PE
9812 * macros.c: Integer and buffer overflow fixes.
9813 * keyboard.h (struct keyboard.kbd_macro_bufsize):
9814 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
9815 Use ptrdiff_t, not int, for sizes.
9816 Don't increment bufsize until after realloc succeeds.
9817 Check for size-calculation overflow.
9818 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
9819
437b2cb4
PE
9820 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
9821
8b9ac8b4
PE
9822 * lread.c: Integer overflow fixes.
9823 (read_integer): Radix is now EMACS_INT, not int,
9824 to improve quality of diagnostics for out-of-range radices.
9825 Calculate buffer size correctly for out-of-range radices.
9826 (read1): Check for integer overflow in radices, and in
9827 read-circle numbers.
82cb60d3
PE
9828 (read_escape): Avoid int overflow.
9829 (Fload, openp, read_buffer_size, read1)
9830 (substitute_object_recurse, read_vector, read_list, map_obarray):
9831 Use ptrdiff_t, not int, for sizes.
9832 (read1): Use EMACS_INT, not int, for sizes.
20270765 9833 Check for size overflow.
8b9ac8b4 9834
7fcccf1e
PE
9835 * image.c (cache_image): Check for size arithmetic overflow.
9836
bfbbd7e7
PE
9837 * lread.c: Integer overflow issues.
9838 (saved_doc_string_size, saved_doc_string_length)
9839 (prev_saved_doc_string_size, prev_saved_doc_string_length):
9840 Now ptrdiff_t, not int.
9841 (read1): Don't assume doc string length fits in int. Check for
9842 out-of-range doc string lengths.
9843 (read_list): Don't assume file position fits in int.
39019e54 9844 (read_escape): Check for hex character overflow.
bfbbd7e7 9845
4e323265
LL
98462011-06-22 Leo Liu <sdl.web@gmail.com>
9847
9848 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
9849 Move to minibuffer.el.
9850
85fece3e
PE
98512011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9852
20b84ce9 9853 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
9854 The following patches are for when GLYPH_DEBUG && !XASSERT.
9855 * dispextern.h (trace_redisplay_p, dump_glyph_string):
9856 * dispnew.c (flush_stdout):
9857 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
9858 Mark as externally visible.
9859 * dispnew.c (check_window_matrix_pointers): Now static.
9860 * dispnew.c (window_to_frame_vpos):
9861 * xfns.c (unwind_create_frame):
9862 * xterm.c (x_check_font): Remove unused local.
9863 * scroll.c (CHECK_BOUNDS):
9864 * xfaces.c (cache_fache): Rename local to avoid shadowing.
9865 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
9866 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
9867 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
9868 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
9869 Now static.
9870 (debug_method_add): Use va_list and vsprintf rather than relying
9871 on undefined behavior with wrong number of arguments.
9872 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
9873 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
9874 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
9875 since we're not interested in debugging glyphs with old libraries.
9876 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
9877 GCC 4.6.0's static checking.
9878
0766b489
PE
98792011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9880
31fd4b32
PE
9881 Integer overflow and signedness fixes (Bug#8873).
9882 A few related buffer overrun fixes, too.
9883
b79e8648
PE
9884 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
9885
0766b489
PE
9886 * dispextern.h (struct face.stipple):
9887 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
9888 (x_bitmap_mask, x_allocate_bitmap_record)
9889 (x_create_bitmap_from_data, x_create_bitmap_from_file)
9890 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
9891 (x_create_bitmap_from_xpm_data):
9892 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
9893 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
9894 (.bitmaps_last):
9895 * xfaces.c (load_pixmap):
9896 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
9897 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
9898 (.bitmaps_last, struct x_output.icon_bitmap):
9899 Use ptrdiff_t, not int, for bitmap indexes.
9900 (x_allocate_bitmap_record): Check for size overflow.
9901 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
9902
b081724f
PE
9903 Use ptrdiff_t, not int, for overlay counts.
9904 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
9905 * editfns.c (overlays_around, get_pos_property):
9906 * textprop.c (get_char_property_and_overlay):
9907 * xdisp.c (next_overlay_change, note_mouse_highlight):
9908 * xfaces.c (face_at_buffer_position):
21514da7
PE
9909 * buffer.c (OVERLAY_COUNT_MAX): New macro.
9910 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
9911 (Fnext_overlay_change, Fprevious_overlay_change)
9912 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 9913 Use ptrdiff_t, not int, for sizes.
21514da7 9914 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 9915
3de73e5e
PE
9916 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
9917
2606c57b
PE
9918 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
9919 (x_session_initialize): Do not assume string length fits in int.
9920
aaafe47a
PE
9921 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
9922 This is unlikely, but can occur if DPI is outlandish.
9923
2674ddc8 9924 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
9925 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
9926
28154962
PE
9927 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
9928 * xrdb.c (magic_file_p, search_magic_path):
9929 Omit last arg SUFFIX; it was always 0. All callers changed.
9930 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
9931
7de51af5
PE
9932 * xfont.c (xfont_match): Avoid need for strlen.
9933
25ed6cc3
PE
9934 * xfns.c: Don't assume strlen fits in int.
9935 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
9936
4eab31dd
PE
9937 * xdisp.c (message_log_check_duplicate): Return intmax_t,
9938 not unsigned long, as we prefer signed integers. All callers changed.
9939 Detect integer overflow in repeat count.
9940 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 9941 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 9942
171e2a58
PE
9943 * termcap.c: Don't assume sizes fit in int and never overflow.
9944 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
9945 (gobble_line): Check for size-calculation overflow.
9946
ad39faca 9947 * minibuf.c (Fread_buffer):
6e5bb2dc 9948 * lread.c (intern, intern_c_string):
74ca2eb3
PE
9949 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
9950 Don't assume string length fits in int.
9951
52c61c22 9952 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
9953 * gtkutil.c (style_changed_cb): Avoid need for strlen.
9954
b5b8c9e5
PE
9955 * font.c: Don't assume string length fits in int.
9956 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
9957 Use ptrdiff_t, not int.
ccd6111c
PE
9958 (font_intern_prop): Don't assume string length fits in int.
9959 Don't assume integer property fits in fixnum.
9960 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 9961
882f0d81 9962 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 9963 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
9964 Reformulate so as not to need the command string.
9965 Invoke gzip -cd rather than gunzip, as it's more portable.
9966 (lock_info_type, lock_file_1, lock_file):
9967 Don't assume pid_t and time_t fit in unsigned long.
9968 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
9969 (current_lock_owner): Prefer signed type for sizes.
9970 Use memcpy, not strncpy, where memcpy is what is really wanted.
9971 Don't assume (via atoi) that time_t and pid_t fit in int.
9972 Check for time_t and/or pid_t out of range, e.g., via a network share.
9973 Don't alloca where an auto var works fine.
9974
93f4cf88
PE
9975 * fileio.c: Fix some integer overflow issues.
9976 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
9977 Don't assume string length fits in int.
9978 (directory_file_name): Don't assume string length fits in long.
9979 (make_temp_name): Don't assume pid fits in int, or that its print
9980 length is less than 20.
9981
f3e92b69
PE
9982 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
9983
1bfdaf10
PE
9984 * coding.c (make_subsidiaries): Don't assume string length fits in int.
9985
35016e9a
PE
9986 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
9987
3d1e65a1
PE
9988 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
9989 We prefer signed integers, even for size calculations.
9990
0b963a93
PE
9991 * emacs.c: Don't assume string length fits in 'int'.
9992 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
9993 (main): Don't invoke strlen when not needed.
9994
573f4b54
PE
9995 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
9996 (XD_DEBUG_MESSAGE): Don't waste a byte.
9997
989f33ba
PE
9998 * callproc.c (getenv_internal_1, getenv_internal)
9999 (Fgetenv_internal):
965d34eb
PE
10000 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
10001
e4d29b33
PE
10002 * lread.c (invalid_syntax): Omit length argument.
10003 All uses changed. This doesn't fix a bug, but it simplifies the
10004 code away from its former Hollerith-constant appearance, and it's
10005 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 10006 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 10007
eb49b136
PE
10008 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
10009 This didn't break anything, but it didn't help either.
10010 It's confusing to put a bogus integer in a place where the actual
10011 value does not matter.
9f62aeb1 10012 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 10013 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 10014
15375a22
PE
10015 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
10016 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
10017 implementation.
b61cc01c
PE
10018 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
10019 We prefer signed types, and the value cannot exceed the EMACS_INT
10020 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
10021 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
10022 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
10023 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 10024
53b2623d
PE
10025 * indent.c (sane_tab_width): New function.
10026 (current_column, scan_for_column, Findent_to, position_indentation)
10027 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 10028 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 10029
51cab52b 10030 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 10031
f2ed8a70
PE
10032 * lisp.h (lint_assume): New macro.
10033 * composite.c (composition_gstring_put_cache):
10034 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
10035
abe80cc6
PE
10036 * editfns.c, insdel.c:
10037 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 10038
b02c740e
PE
10039 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
10040
ebc96716
PE
10041 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
10042
b4e50fa0 10043 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 10044 Use much-faster test for byte-length change.
311d5d7c 10045 Don't assume string byte-length fits in 'int'.
a4cf38e4 10046 Check that character arg fits in 'int'.
85461888 10047 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 10048
c0c1ee9f
PE
10049 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
10050
a498d7f4
PE
10051 * fns.c (concat): Catch string overflow earlier.
10052 Do not rely on integer wraparound.
10053
51cab52b
PE
10054 * dispextern.h (struct it.overlay_strings_charpos)
10055 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
10056 * xdisp.c (forward_to_next_line_start)
10057 (back_to_previous_visible_line_start)
10058 (reseat_at_next_visible_line_start, next_element_from_buffer):
10059 Don't arbitrarily truncate the value of 'selective' to int.
10060
76031fad
PE
10061 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
10062
5eb55db9
PE
10063 * composite.c: Don't truncate sizes to 'int'.
10064 (composition_gstring_p, composition_reseat_it)
10065 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
10066 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
10067 not EMACS_UINT, for indexes.
5eb55db9 10068
0703a717
PE
10069 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
10070
d6202519
PE
10071 * buffer.c: Include <verify.h>.
10072 (struct sortvec.priority, struct sortstr.priority):
8961a454 10073 Now EMACS_INT, not int.
c20998a7 10074 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
10075 (struct sortstr.size, record_overlay_string)
10076 (struct sortstrlist.size, struct sortlist.used):
10077 Don't truncate size to int.
10078 (record_overlay_string): Check for size-calculation overflow.
d6202519 10079 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 10080
d5a19415
JM
100812011-06-22 Jim Meyering <meyering@redhat.com>
10082
029529ac 10083 Don't leak an XBM-image-sized buffer
d5a19415
JM
10084 * image.c (xbm_load): Free the image buffer after using it.
10085
a9041e6c
PE
100862011-06-21 Paul Eggert <eggert@cs.ucla.edu>
10087
10088 Port to Sun C.
10089 * composite.c (find_automatic_composition): Omit needless 'return 0;'
10090 that Sun C diagnosed.
10091 * fns.c (secure_hash): Fix pointer signedness issue.
10092 * intervals.c (static_offset_intervals): New function.
10093 (offset_intervals): Use it.
10094
7f3f739f
LL
100952011-06-21 Leo Liu <sdl.web@gmail.com>
10096
10097 * deps.mk (fns.o):
10098 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
10099 sha512.h.
10100
10101 * fns.c (secure_hash): Rename from crypto_hash_function and change
10102 the first arg to accept symbols.
5b66d427 10103 (Fsecure_hash): New primitive.
7f3f739f
LL
10104 (syms_of_fns): New symbols.
10105
76147d94
DD
101062011-06-20 Deniz Dogan <deniz@dogan.se>
10107
10108 * process.c (Fset_process_buffer): Clarify return value in
10109 docstring.
10110
7d7d0045
CY
101112011-06-18 Chong Yidong <cyd@stupidchicken.com>
10112
10113 * dispnew.c (add_window_display_history): Use BVAR.
10114
10115 * xdisp.c (debug_method_add): Use BVAR.
10116 (check_window_end, dump_glyph_matrix, dump_glyph)
10117 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
10118
10119 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
10120 Likewise.
10121
10122 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
10123 check till after the cache is created in init_frame_faces.
10124
ff2bc410
SM
101252011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
10126
10127 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
10128
28177add
PE
101292011-06-16 Paul Eggert <eggert@cs.ucla.edu>
10130
dd3482fe
PE
10131 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
10132 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
10133 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
10134
393d71f3 10135 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
10136 * fileio.c (Finsert_file_contents):
10137 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
10138 Remove the old (too-loose) buffer overflow checks.
10139 They weren't needed, since make_gap checks for buffer overflow.
10140 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
10141 The old code merely checked for Emacs fixnum overflow, and relied
10142 on undefined (wraparound) behavior. The new code avoids undefined
10143 behavior, and also checks for ptrdiff_t and/or size_t overflow.
10144
2e6813b0 10145 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
10146 Tune. Don't use wider integers than needed. Don't use alloca.
10147 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 10148
599a9e4f
PE
10149 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
10150
99561444
PE
10151 * insdel.c, lisp.h (buffer_overflow): New function.
10152 (insert_from_buffer_1, replace_range, replace_range_2):
10153 * insdel.c (make_gap_larger):
10154 * editfns.c (Finsert_char):
10155 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
10156
28177add
PE
10157 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
10158
e69dafad
PE
101592011-06-15 Paul Eggert <eggert@cs.ucla.edu>
10160
4baa020d 10161 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 10162
b1c46f02
PE
10163 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
10164 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
10165
e69dafad
PE
10166 * fileio.c: Don't assume EMACS_INT fits in off_t.
10167 (emacs_lseek): New static function.
10168 (Finsert_file_contents, Fwrite_region): Use it.
10169 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
10170
566684ea
PE
10171 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
10172
e6966cd6
PE
10173 * fns.c: Don't overflow int when computing a list length.
10174 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
10175 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
10176 truncation on 64-bit hosts. Check for QUIT every
10177 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
10178 faster and is responsive enough.
10179 (Flength): Report an error instead of overflowing an integer.
10180 (Fsafe_length): Return a float if the value is not representable
10181 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 10182 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 10183 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 10184
dd0b0efb
PE
10185 * alloc.c: Check that resized vectors' lengths fit in fixnums.
10186 (header_size, word_size): New constants.
10187 (allocate_vectorlike): Don't check size overflow here.
10188 (allocate_vector): Check it here instead, since this is the only
10189 caller of allocate_vectorlike that could cause overflow.
10190 Check that the new vector's length is representable as a fixnum.
10191
86fe5cfe
PE
10192 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
10193 The previous code was bogus. For example, next_almost_prime (32)
10194 returned 39, which is undesirable as it is a multiple of 3; and
10195 next_almost_prime (24) returned 25, which is a multiple of 5 so
10196 why was the code bothering to check for multiples of 7?
10197
80e88859
PE
10198 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
10199
4a2f0ad6
PE
10200 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
10201
f66c7cf8
PE
10202 Variadic C functions now count arguments with ptrdiff_t.
10203 This partly undoes my 2011-03-30 change, which replaced int with size_t.
10204 Back then I didn't know that the Emacs coding style prefers signed int.
10205 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
10206 were being counted with int, which may truncate counts on 64-bit
10207 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
10208 * lisp.h (struct Lisp_Subr.function.aMANY)
10209 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
10210 Arg counts are now ptrdiff_t, not size_t.
10211 All variadic functions and their callers changed accordingly.
10212 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
10213 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
10214 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
10215 * callint.c (Fcall_interactively): Check arg count for overflow,
10216 to avoid potential buffer overrun. Use signed char, not 'int',
10217 for 'varies' array, so that we needn't bother to check its size
10218 calculation for overflow.
10219 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
10220 * eval.c (apply_lambda):
10221 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
10222 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
10223 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
10224
a1759b76
PE
10225 * callint.c (Fcall_interactively): Don't use index var as event count.
10226
d96be9fc
PE
10227 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
10228 * mem-limits.h (SIZE): Remove; no longer used.
10229
a690a978 10230 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 10231
578c21e6
PE
10232 Remove unnecessary casts.
10233 * xterm.c (x_term_init):
10234 * xfns.c (x_set_border_pixel):
10235 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
10236 These aren't needed now that we assume ANSI C.
10237
96f53c6c
PE
10238 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
10239 It's more likely to cause problems (due to unsigned overflow)
10240 than to cure them.
10241
83c77d31
PE
10242 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
10243
ee2079f1
PE
10244 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
10245
6da65536
PE
10246 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
10247
7147c4a4
PE
10248 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
10249
193e32d9
PE
10250 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
10251
e5533da6
PE
10252 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
10253
9910e595
PE
10254 GLYPH_CODE_FACE returns EMACS_INT, not int.
10255 * dispextern.h (merge_faces):
10256 * xfaces.c (merge_faces):
01103c44
PE
10257 * xdisp.c (get_next_display_element, next_element_from_display_vector):
10258 Don't assume EMACS_INT fits in int.
9910e595 10259
2638320e
PE
10260 * character.h (CHAR_VALID_P): Remove unused parameter.
10261 * fontset.c, lisp.h, xdisp.c: All uses changed.
10262
045eb8d9
PE
10263 * editfns.c (Ftranslate_region_internal): Omit redundant test.
10264
c1f134b5
PE
10265 * fns.c (concat): Minor tuning based on overflow analysis.
10266 This doesn't fix any bugs. Use int to hold character, instead
10267 of constantly refetching from Emacs object. Use XFASTINT, not
10268 XINT, for value known to be a character. Don't bother comparing
10269 a single byte to 0400, as it's always less.
10270
395fcb93 10271 * floatfns.c (Fexpt):
327eeec8
PE
10272 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
10273
abbd3d23
PE
10274 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
10275 for characters.
10276
684a03ef
PE
10277 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
10278
0fed43f3
PE
10279 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
10280 Without this fix, on a 64-bit host (aset S 0 4294967386) would
10281 incorrectly succeed when S was a string, because 4294967386 was
10282 truncated before it was used.
10283
8fd02eb7
PE
10284 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
10285 Otherwise, an out-of-range integer could cause undefined behavior
10286 on a 64-bit host.
10287
f8c86b69
PE
10288 * composite.c: Use int, not EMACS_INT, for characters.
10289 (fill_gstring_body, composition_compute_stop_pos): Use int, not
10290 EMACS_INT, for values that are known to be in character range.
10291 This doesn't fix any bugs but is the usual style inside Emacs and
10292 may generate better code on 32-bit machines.
10293
34206dd2
PE
10294 Make sure a 64-bit char is never passed to ENCODE_CHAR.
10295 This is for reasons similar to the recent CHAR_STRING fix.
10296 * charset.c (Fencode_char): Check that character arg is actually
10297 a character. Pass an int to ENCODE_CHAR.
10298 * charset.h (ENCODE_CHAR): Verify that the character argument is no
10299 wider than 'int', as a compile-time check to prevent future regressions
10300 in this area.
10301
c5958d4c 10302 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
10303
10304 Make sure a 64-bit char is never passed to CHAR_STRING.
10305 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
10306 by silently ignoring the top 32 bits, allowing some values
10307 that were far too large to be valid characters.
10308 * character.h: Include <verify.h>.
10309 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
10310 arguments are no wider than unsigned, as a compile-time check
10311 to prevent future regressions in this area.
10312 * data.c (Faset):
01103c44 10313 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
10314 (Fsubst_char_in_region):
10315 * fns.c (concat):
10316 * xdisp.c (decode_mode_spec_coding):
10317 Adjust to CHAR_STRING's new requirement.
10318 * editfns.c (Finsert_char, Fsubst_char_in_region):
10319 * fns.c (concat): Check that character args are actually
10320 characters. Without this test, these functions did the wrong
10321 thing with wildly out-of-range values on 64-bit hosts.
10322
d37ca623
PE
10323 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
10324 These casts should not be needed on 32-bit hosts, either.
10325 * keyboard.c (read_char):
10326 * lread.c (Fload): Remove casts to unsigned.
10327
ea204efb
PE
10328 * lisp.h (UNSIGNED_CMP): New macro.
10329 This fixes comparison bugs on 64-bit hosts.
10330 (ASCII_CHAR_P): Use it.
10331 * casefiddle.c (casify_object):
01103c44 10332 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
10333 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
10334 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
10335 * dispextern.h (FACE_FROM_ID):
10336 * keyboard.c (read_char): Use UNSIGNED_CMP.
10337
41cb286c
PE
10338 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
10339 not to EMACS_INT, to avoid GCC warning.
10340
4a1b9832
PE
10341 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
10342
55daad71
PE
10343 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
10344 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
10345 isn't needed on 32-bit machines.
8f95c75c 10346
01103c44
PE
10347 * buffer.c (Fgenerate_new_buffer_name):
10348 Use EMACS_INT for count, not int.
0ceccced 10349 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
10350
10351 * data.c (Qcompiled_function): Now static.
10352
c6f072e7
PE
10353 * window.c (window_body_lines): Now static.
10354
20ce5912
PE
10355 * image.c (gif_load): Rename local to avoid shadowing.
10356
9c4c5f81
PE
10357 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
10358 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
10359 * alloc.c (make_save_value): Integer argument is now of type
10360 ptrdiff_t, not int.
10361 (mark_object): Use ptrdiff_t, not int.
10362 * lisp.h (pD): New macro.
10363 * print.c (print_object): Use it.
10364
c0c5c8ae
PE
10365 * alloc.c: Use EMACS_INT, not int, to count objects.
10366 (total_conses, total_markers, total_symbols, total_vector_size)
10367 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
10368 (total_free_floats, total_floats, total_free_intervals)
10369 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
10370 Now EMACS_INT, not int. All uses changed.
10371 (Fgarbage_collect): Compute overall total using a double, so that
10372 integer overflow is less likely to be a problem. Check for overflow
10373 when converting back to an integer.
5a25e253
PE
10374 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
10375 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
10376 These were 'int' variables that could overflow on 64-bit hosts;
10377 they were never used, so remove them instead of repairing them.
211a0b2a 10378 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
10379 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
10380 Previously, this ceilinged at INT_MAX, but that doesn't work on
10381 64-bit machines.
e46bb31a 10382 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 10383
c78baabf 10384 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 10385 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
10386 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
10387 when a (possibly-narrower) signed value would do just as well.
10388 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 10389
c9d624c6
PE
10390 * alloc.c: Catch some string size overflows that we were missing.
10391 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
10392 for convenience in STRING_BYTES_MAX.
10393 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
10394 The definition here is exact; the one in lisp.h was approximate.
10395 (allocate_string_data): Check for string overflow. This catches
10396 some instances we weren't catching before. Also, it catches
10397 size_t overflow on (unusual) hosts where SIZE_MAX <= min
10398 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
10399 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 10400
c9d624c6
PE
10401 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
10402 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 10403 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 10404
353032ce
PE
10405 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
10406
2bccce07
PE
10407 * alloc.c (Fmake_string): Check for out-of-range init.
10408
0ac30604
SM
104092011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
10410
10411 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
10412
c195f2de
JD
104132011-06-14 Jan Djärv <jan.h.d@swipnet.se>
10414
10415 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
10416 xg_get_default_scrollbar_width.
10417
10418 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
10419 (int_gtk_range_get_value): Move to the scroll bar part of the file.
10420 (style_changed_cb): Call update_theme_scrollbar_width and call
10421 x_set_scroll_bar_default_width and xg_frame_set_char_size for
10422 all frames (Bug#8505).
10423 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
10424 Call gtk_window_set_resizable if HAVE_GTK3.
10425 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
10426 and height if HAVE_GTK3 (Bug#8505).
10427 (scroll_bar_width_for_theme): New variable.
10428 (update_theme_scrollbar_width): New function.
10429 (xg_get_default_scrollbar_width): Move code to
10430 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
10431 (xg_initialize): Call update_theme_scrollbar_width.
10432
10433 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
10434
10435 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
10436
e10ac9f1
MR
104372011-06-12 Martin Rudalics <rudalics@gmx.at>
10438
10439 * frame.c (make_frame): Call other_buffer_safely instead of
10440 other_buffer.
10441
10442 * window.c (temp_output_buffer_show): Call display_buffer with
10443 second argument Vtemp_buffer_show_specifiers and reset latter
10444 immediately after the call.
10445 (Vtemp_buffer_show_specifiers): New variable.
10446 (auto_window_vscroll_p, next_screen_context_lines)
10447 (Vscroll_preserve_screen_position): Remove leading asterisks from
10448 doc-strings.
10449
2d3c217e 104502011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 10451
7b7f97e8 10452 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
10453 * buffer.c (Qclone_number): Remove for now, as it's unused.
10454 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
10455 (record_buffer): Remove unused local.
10456 * frame.c (other_visible_frames, frame_buffer_list): Now static.
10457 (set_frame_buffer_list): Remove; unused.
10458 * frame.h (other_visible_frames): Remove decl.
10459 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
10460 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
10461 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
10462 if HAVE_GPM.
10463 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
10464 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
10465 Define only if HAVE_GPM.
10466 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
10467 (update_hints_inhibit): Remove; never set. All uses removed.
10468 * widgetprv.h (emacsFrameClassRec): Remove decl.
10469 * window.c (delete_deletable_window): Now returns void, since it
10470 wasn't returning anything.
10471 (compare_window_configurations): Remove unused locals.
10472 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
10473 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
10474 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
10475 the same widths as pointers. This follows up on the 2011-05-06 patch.
10476 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
10477 * xterm.h: Likewise.
10478 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
10479
1384b89e
JB
104802011-06-12 Juanma Barranquero <lekktu@gmail.com>
10481
10482 * makefile.w32-in: Update dependencies.
10483 (LISP_H): Add lib/intprops.h.
10484
1100a63c
CY
104852011-06-11 Chong Yidong <cyd@stupidchicken.com>
10486
10487 * image.c (gif_load): Add animation frame delay to the metadata.
10488 (syms_of_image): Use DEFSYM. New symbol `delay'.
10489
6198ccd0
MR
104902011-06-11 Martin Rudalics <rudalics@gmx.at>
10491
10492 * window.c (delete_deletable_window): Re-add.
10493 (Fset_window_configuration): Rewrite to handle dead buffers and
10494 consequently deletable windows.
10495 (window_tree, Fwindow_tree): Remove. Supply functionality in
10496 window.el.
10497 (compare_window_configurations): Simplify code.
10498
b6e3633c
AS
104992011-06-11 Andreas Schwab <schwab@linux-m68k.org>
10500
1ab0dee5
AS
10501 * image.c (imagemagick_load_image): Fix type mismatch.
10502 (Fimagemagick_types): Likewise.
10503
b6e3633c
AS
10504 * window.h (replace_buffer_in_windows): Declare.
10505
9397e56f
MR
105062011-06-11 Martin Rudalics <rudalics@gmx.at>
10507
10508 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
10509 Qclone_number. Remove external declaration of Qdelete_window.
10510 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
10511 code.
640c8776
SM
10512 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
10513 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
10514 (Fother_buffer): Rewrite doc-string. Major rewrite for new
10515 buffer list implementation.
10516 (other_buffer_safely): New function.
10517 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
10518 calls to replace_buffer_in_windows and
10519 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
10520 if allowed.
10521 (record_buffer): Inhibit quitting and rewrite using quittable
10522 functions. Run Qbuffer_list_update_hook if allowed.
10523 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
10524 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
10525 Move switch-to-buffer to window.el.
9397e56f
MR
10526 (bury-buffer): Move to window.el.
10527 (Vbuffer_list_update_hook): New variable.
10528
10529 * lisp.h (other_buffer_safely): Add prototype in buffer.c
10530 section.
10531
10532 * window.h (resize_frame_windows): Move up in code.
10533 (Fwindow_frame): Remove EXFUN.
10534 (replace_buffer_in_all_windows): Remove prototype.
10535 (replace_buffer_in_windows_safely): Add prototype.
10536
10537 * window.c: Declare Qdelete_window static again. Move down
10538 declaration of select_count.
10539 (Fnext_window, Fprevious_window): Rewrite doc-strings.
10540 (Fother_window): Move to window.el.
10541 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
10542 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
10543 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
10544 window.el.
10545 (replace_buffer_in_windows): Implement by calling
10546 Qreplace_buffer_in_windows.
10547 (replace_buffer_in_all_windows): Remove with some functionality
10548 moved into replace_buffer_in_windows_safely.
10549 (replace_buffer_in_windows_safely): New function.
10550 (select_window_norecord, select_frame_norecord): Move in front
10551 of run_window_configuration_change_hook. Remove now obsolete
10552 declarations.
640c8776
SM
10553 (Fset_window_buffer): Rewrite doc-string.
10554 Call Qrecord_window_buffer.
9397e56f
MR
10555 (keys_of_window): Move binding for other-window to window.el.
10556
b50691aa
CY
105572011-06-11 Chong Yidong <cyd@stupidchicken.com>
10558
10559 * dispextern.h (struct image): Replace data member, whose int_val
10560 and ptr_val fields were not used by anything, with a single
10561 lisp_val object.
10562
10563 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
10564 (gif_clear_image, gif_load, imagemagick_load_image)
10565 (gs_clear_image, gs_load): Callers changed.
10566
3f754b86
PE
105672011-06-10 Paul Eggert <eggert@cs.ucla.edu>
10568
cca69397
PE
10569 * buffer.h: Include <time.h>, for time_t.
10570 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
10571
109e28d0
PE
10572 Fix minor problems found by static checking.
10573
60737f02
PE
10574 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
10575
4b66faf3
PE
10576 Make identifiers static if they are not used in other modules.
10577 * data.c (Qcompiled_function, Qframe, Qvector):
10578 * image.c (QimageMagick, Qsvg):
10579 * minibuf.c (Qmetadata):
10580 * window.c (resize_window_check, resize_root_window): Now static.
10581 * window.h (resize_window_check, resize_root_window): Remove decls.
10582
109e28d0
PE
10583 * window.c (window_deletion_count, delete_deletable_window):
10584 Remove; unused.
46a4ce9e
PE
10585 (window_body_lines): Now static.
10586 (Fdelete_other_windows_internal): Mark vars as initialized.
10587 Make sure 'resize_failed' is initialized.
10588 (run_window_configuration_change_hook): Rename local to avoid shadowing.
10589 (resize_window_apply): Remove unused local.
10590 * window.h (delete_deletable_window): Remove decl.
10591
109e28d0 10592 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
10593 (imagemagick_load_image): Fix pointer signedness problem by changing
10594 last arg from unsigned char * to char *. All uses changed.
10595 Also, fix a local for similar reasons.
10596 Remove unused locals. Remove locals to avoid shadowing.
10597 (fn_rsvg_handle_free): Remove; unused.
10598 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 10599 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 10600
3f754b86
PE
10601 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
10602
2547adb1
CY
106032011-06-10 Chong Yidong <cyd@stupidchicken.com>
10604
10605 * image.c (gif_load): Fix omitted cast error introduced by
10606 2011-06-06 change.
10607
2c8e37d4
MR
106082011-06-10 Martin Rudalics <rudalics@gmx.at>
10609
10610 * window.h (resize_proportionally, orig_total_lines)
10611 (orig_top_line): Remove from window structure.
10612 (set_window_height, set_window_width, change_window_heights)
10613 (Fdelete_window): Remove prototypes.
10614 (resize_frame_windows): Remove duplicate declaration.
10615
440a42e3
EZ
106162011-06-10 Eli Zaretskii <eliz@gnu.org>
10617
10618 * window.h (resize_frame_windows, resize_window_check)
10619 (delete_deletable_window, resize_root_window)
10620 (resize_frame_windows): Declare prototypes.
10621
10622 * window.c (resize_window_apply): Make definition be "static" to
10623 match the prototype.
10624
562dd5e9
MR
106252011-06-10 Martin Rudalics <rudalics@gmx.at>
10626
10627 * window.c: Remove declarations of Qwindow_size_fixed,
10628 window_min_size_1, window_min_size_2, window_min_size,
10629 size_window, window_fixed_size_p, enlarge_window, delete_window.
10630 Remove static from declaration of Qdelete_window, it's
10631 temporarily needed by Fbury_buffer.
10632 (replace_window): Don't assign orig_top_line and
10633 orig_total_lines.
10634 (Fdelete_window, delete_window): Remove. Window deletion is
10635 handled by window.el.
640c8776
SM
10636 (window_loop): Remove DELETE_OTHER_WINDOWS case.
10637 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
10638 (Fdelete_other_windows): Remove. Deleting other windows is
10639 handled by window.el.
10640 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
10641 handled in window.el.
10642 (window_min_size_2, window_min_size_1, window_min_size): Remove.
10643 Window minimum sizes are handled in window.el.
10644 (shrink_windows, size_window, set_window_height)
10645 (set_window_width, change_window_heights, window_height)
10646 (window_width, CURBEG, CURSIZE, enlarge_window)
10647 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
10648 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
10649 handled in window.el.
10650 (make_dummy_parent): Rename to make_parent_window and give it a
10651 second argument horflag.
10652 (make_window): Don't set resize_proportionally any more.
10653 (Fsplit_window): Remove. Windows are split in window.el.
10654 (save_restore_action, save_restore_orig_size)
10655 (shrink_window_lowest_first, save_restore_orig_size): Remove.
10656 Resize mini windows in window.el.
10657 (grow_mini_window, shrink_mini_window): Implement by calling
10658 Qresize_root_window_vertically, resize_window_check and
10659 resize_window_apply.
640c8776
SM
10660 (saved_window, Fset_window_configuration, save_window_save):
10661 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
10662 resize_proportionally.
10663 (window_min_height, window_min_width): Move to window.el.
10664 (keys_of_window): Move bindings for delete-other-windows,
10665 split-window, delete-window and enlarge-window to window.el.
10666
10667 * buffer.c: Temporarily extern Qdelete_window.
10668 (Fbury_buffer): Temporarily call Qdelete_window instead of
10669 Fdelete_window (Fbury_buffer will move to window.el soon).
10670
10671 * frame.c (set_menu_bar_lines_1): Remove code handling
10672 orig_top_line and orig_total_lines.
10673
10674 * dispnew.c (adjust_frame_glyphs_initially): Don't use
10675 set_window_height but set heights directly.
10676 (change_frame_size_1): Use resize_frame_windows.
10677
10678 * xdisp.c (init_xdisp): Don't use set_window_height but set
10679 heights directly.
10680
640c8776
SM
10681 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
10682 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
10683 run_window_configuration_change_hook.
10684
10685 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
10686 instead of change_window_heights and run
10687 run_window_configuration_change_hook.
10688
1a13852e
MR
106892011-06-09 Martin Rudalics <rudalics@gmx.at>
10690
10691 * window.c (replace_window): Rename second argument REPLACEMENT to
10692 NEW. New third argument SETFLAG. Rewrite.
10693 (delete_window, make_dummy_parent): Call replace_window with
10694 third argument 1.
10695 (window_list_1): Move down in code.
10696 (run_window_configuration_change_hook): Move set_buffer part
10697 before select_frame_norecord part in order to unwind correctly.
10698 Rename count1 to count.
10699 (recombine_windows, delete_deletable_window, resize_root_window)
10700 (Fdelete_other_windows_internal)
10701 (Frun_window_configuration_change_hook, make_parent_window)
10702 (resize_window_check, resize_window_apply, Fresize_window_apply)
10703 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
10704 (Fdelete_window_internal, Fresize_mini_window_internal):
10705 New functions.
1a13852e
MR
10706 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
10707
f3d1777e
MR
107082011-06-08 Martin Rudalics <rudalics@gmx.at>
10709
496e208e
MR
10710 * window.h (window): Add some new members to window structure -
10711 normal_lines, normal_cols, new_total, new_normal, clone_number,
10712 splits, nest, prev_buffers, next_buffers.
10713 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 10714 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 10715
f3d1777e
MR
10716 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
10717 Remove.
496e208e
MR
10718 (make_dummy_parent): Set new members of windows structure.
10719 (make_window): Move down in code. Handle new members of window
10720 structure.
10721 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
10722 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
10723 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
10724 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
10725 (Fset_window_next_buffers, Fset_window_clone_number):
10726 New functions.
496e208e
MR
10727 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
10728 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
10729 Doc-string fixes.
10730 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
10731 Argument WINDOW can be now internal window too.
10732 (Fwindow_use_time): Move up in code.
10733 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
10734 Rewrite doc-string.
10735 (Fset_window_configuration, saved_window)
10736 (Fcurrent_window_configuration, save_window_save): Handle new
10737 members of window structure.
b9e809c2
MR
10738 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
10739 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
10740 (syms_of_window): New Lisp objects Qrecord_window_buffer,
10741 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
10742 Qget_mru_window, Qresize_root_window,
10743 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
10744 Qauto_buffer_name; staticpro them.
f3d1777e 10745
abde8f8c
MR
107462011-06-07 Martin Rudalics <rudalics@gmx.at>
10747
10748 * window.c (Fwindow_total_size, Fwindow_left_column)
10749 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
10750 (Fwindow_list_1): New functions.
10751 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
10752 (Fwindow_width, Fscroll_left, Fscroll_right):
10753 Use window_body_cols instead of window_box_text_cols.
10754 (delete_window, Fset_window_configuration):
10755 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
10756 (delete_all_subwindows): Take a window as argument and not a
10757 structure. Rewrite.
190b47e6
MR
10758 (window_loop): Remove handling of GET_LRU_WINDOW and
10759 GET_LARGEST_WINDOW.
10760 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
10761
10762 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
10763 window_box_text_cols. delete_all_subwindows now takes a
10764 Lisp_Object as argument.
abde8f8c 10765
640c8776
SM
10766 * indent.c (compute_motion, Fcompute_motion):
10767 Use window_body_cols instead of window_box_text_cols.
abde8f8c 10768
fa8a67e6
MR
10769 * frame.c (delete_frame): Call delete_all_subwindows with root
10770 window as argument.
10771
a54e3482
DC
107722011-06-07 Daniel Colascione <dan.colascione@gmail.com>
10773
10774 * fns.c (Fputhash): Document return value.
10775
60002bf5
CY
107762011-06-06 Chong Yidong <cyd@stupidchicken.com>
10777
10778 * image.c (gif_load): Implement gif89a spec "no disposal" method.
10779
0c671da6 107802011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 10781
b862a52a 10782 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 10783
be44ca6c
PE
10784 Check for overflow when converting integer to cons and back.
10785 * charset.c (Fdefine_charset_internal, Fdecode_char):
10786 Use cons_to_unsigned to catch overflow.
10787 (Fencode_char): Use INTEGER_TO_CONS.
10788 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
10789 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
10790 * data.c (long_to_cons, cons_to_long): Remove.
10791 (cons_to_unsigned, cons_to_signed): New functions.
10792 These signal an error for invalid or out-of-range values.
10793 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
10794 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
10795 * font.c (Ffont_variation_glyphs):
10796 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
10797 * lisp.h: Include <intprops.h>.
10798 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
10799 (cons_to_signed, cons_to_unsigned): New decls.
10800 (long_to_cons, cons_to_long): Remove decls.
10801 * undo.c (record_first_change): Use INTEGER_TO_CONS.
10802 (Fprimitive_undo): Use CONS_TO_INTEGER.
10803 * xfns.c (Fx_window_property): Likewise.
10804 * xselect.c: Include <limits.h>.
10805 (x_own_selection, selection_data_to_lisp_data):
10806 Use INTEGER_TO_CONS.
10807 (x_handle_selection_request, x_handle_selection_clear)
10808 (x_get_foreign_selection, Fx_disown_selection_internal)
10809 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
10810 (lisp_data_to_selection_data): Use cons_to_unsigned.
10811 (x_fill_property_data): Use cons_to_signed.
10812 Report values out of range.
10813
d1f3d2af
PE
10814 Check for buffer and string overflow more precisely.
10815 * buffer.h (BUF_BYTES_MAX): New macro.
10816 * lisp.h (STRING_BYTES_MAX): New macro.
10817 * alloc.c (Fmake_string):
10818 * character.c (string_escape_byte8):
10819 * coding.c (coding_alloc_by_realloc):
10820 * doprnt.c (doprnt):
10821 * editfns.c (Fformat):
10822 * eval.c (verror):
10823 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
10824 since they may not be the same number.
10825 * editfns.c (Finsert_char):
10826 * fileio.c (Finsert_file_contents):
10827 Likewise for BUF_BYTES_MAX.
10828
dd52fcea
PE
10829 * image.c: Use ptrdiff_t, not int, for sizes.
10830 (slurp_file): Switch from int to ptrdiff_t.
10831 All uses changed.
10832 (slurp_file): Check that file size fits in both size_t (for
10833 malloc) and ptrdiff_t (for sanity and safety).
10834
7f9bbdbb
PE
10835 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
10836 if b->modtime has its maximal value.
10837
dfe18f82
PE
10838 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
10839
84acfcf0
PE
10840 Don't assume time_t can fit into int.
10841 * buffer.h (struct buffer.modtime): Now time_t, not int.
10842 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
10843 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
10844
ccd9a01a
PE
10845 Minor fixes for signed vs unsigned integers.
10846 * character.h (MAYBE_UNIFY_CHAR):
10847 * charset.c (maybe_unify_char):
10848 * keyboard.c (read_char, reorder_modifiers):
10849 XINT -> XFASTINT, since the integer must be nonnegative.
10850 * ftfont.c (ftfont_spec_pattern):
10851 * keymap.c (access_keymap, silly_event_symbol_error):
10852 XUINT -> XFASTINT, since the integer must be nonnegative.
10853 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
10854 since it makes no difference and we prefer signed.
10855 * keyboard.c (record_char): Use XUINT when all the neighbors do.
10856 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
10857 nonnegative.
10858
d6d100dd
SM
108592011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
10860
10861 * window.h (Fwindow_frame): Declare.
10862
2b6148e4
PE
108632011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10864
10865 * alloc.c: Simplify handling of large-request failures (Bug#8800).
10866 (SPARE_MEMORY): Always define.
10867 (LARGE_REQUEST): Remove.
10868 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
10869
f230ecc9
MR
108702011-06-06 Martin Rudalics <rudalics@gmx.at>
10871
727e958e
MR
10872 * lisp.h: Move EXFUNS for Fframe_root_window,
10873 Fframe_first_window and Fset_frame_selected_window to window.h.
10874
10875 * window.h: Move EXFUNS for Fframe_root_window,
10876 Fframe_first_window and Fset_frame_selected_window here from
10877 lisp.h.
10878
10879 * frame.c (Fwindow_frame, Fframe_first_window)
10880 (Fframe_root_window, Fframe_selected_window)
10881 (Fset_frame_selected_window): Move to window.c.
10882 (Factive_minibuffer_window): Move to minibuf.c.
10883 (Fother_visible_frames_p): New function.
10884
10885 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
10886
f230ecc9
MR
10887 * window.c (decode_window, decode_any_window): Move up in code.
10888 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
10889 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
10890 (Fwindow_buffer): Move up and rewrite doc-string.
10891 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
10892 (Fwindow_prev): New functions.
727e958e
MR
10893 (Fwindow_frame): Move here from frame.c. Accept any window as
10894 argument.
10895 (Fframe_root_window, Fframe_first_window)
10896 (Fframe_selected_window): Move here from frame.c. Accept frame
10897 or arbitrary window as argument. Update doc-strings.
10898 (Fminibuffer_window): Move up in code.
10899 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
10900 (Fset_frame_selected_window): Move here from frame.c.
10901 Marginal rewrite.
727e958e
MR
10902 (Fselected_window, select_window, Fselect_window): Move up in
10903 code. Minor doc-string fixes.
f230ecc9 10904
4d09bcf6
PE
109052011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10906
10907 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
10908 Do not assume that spare memory exists; that assumption is valid
10909 only if SYSTEM_MALLOC.
10910 (LARGE_REQUEST): New macro, so that the issue of large requests
10911 is separated from the issue of spare memory.
10912
810928a2
AS
109132011-06-05 Andreas Schwab <schwab@linux-m68k.org>
10914
172418ad
AS
10915 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
10916 format. (Bug#8806)
10917
43f862f7
AS
10918 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
10919
810928a2
AS
10920 * xfns.c (x_set_scroll_bar_default_width): Move declarations
10921 before statements.
10922
a059fe24
JD
109232011-06-05 Jan Djärv <jan.h.d@swipnet.se>
10924
10925 * gtkutil.c (xg_get_default_scrollbar_width): New function.
10926
10927 * gtkutil.h: Declare xg_get_default_scrollbar_width.
10928
10929 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
10930 min width by calling x_set_scroll_bar_default_width (Bug#8505).
10931
989bf368
JB
109322011-06-05 Juanma Barranquero <lekktu@gmail.com>
10933
10934 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
10935
4b80f674
CY
109362011-06-04 Chong Yidong <cyd@stupidchicken.com>
10937
10938 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
10939 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
10940 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
10941 New error handlers.
4b80f674
CY
10942 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
10943 Obey Vx_select_enable_clipboard_manager. Catch errors in
10944 x_clipboard_manager_save (Bug#8779).
10945 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 10946 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 10947
99a33b77 109482011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
10949
10950 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
10951
99a33b77 109522011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
10953
10954 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
10955 in the current matrix if keep_current_p is non-zero.
10956
8264569d
EZ
109572011-06-04 Eli Zaretskii <eliz@gnu.org>
10958
10959 * bidi.c (bidi_level_of_next_char): Fix last change.
10960
57f97249
EZ
109612011-06-03 Eli Zaretskii <eliz@gnu.org>
10962
fec2107c 10963 Support bidi reordering of text covered by display properties.
57f97249 10964
fec2107c
EZ
10965 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
10966 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
10967 (bidi_cache_search, bidi_cache_iterator_state)
10968 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
10969 (bidi_level_of_next_char, bidi_move_to_visually_next):
10970 Support character positions inside a run of characters covered by a
fec2107c
EZ
10971 display string.
10972 (bidi_paragraph_init, bidi_resolve_explicit_1)
10973 (bidi_level_of_next_char): Call bidi_fetch_char and
10974 bidi_fetch_char_advance instead of FETCH_CHAR and
10975 FETCH_CHAR_ADVANCE.
10976 (bidi_init_it): Initialize new members.
10977 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
10978 definitions.
10979 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
10980 instead of using explicit *_CHAR codes.
d6d100dd
SM
10981 (bidi_resolve_explicit, bidi_resolve_weak):
10982 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
10983 bidirectional text is supported only in multibyte buffers.
10984 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
10985 it to initialize the frame_window_p member of struct bidi_it.
10986 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
10987 (bidi_resolve_explicit, bidi_resolve_weak)
10988 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
10989 bidi_it->nchars is non-positive.
10990 (bidi_level_of_next_char): Don't try to lookup the cache for the
10991 next/previous character if nothing is cached there yet, or if we
10992 were just reseat()'ed to a new position.
c40e2fb2 10993
0e14fe90
EZ
10994 * xdisp.c (set_cursor_from_row): Set start and stop points
10995 according to the row's direction when priming the loop that looks
10996 for the glyph on which to display cursor.
10997 (single_display_spec_intangible_p): Function deleted.
10998 (display_prop_intangible_p): Reimplement to call
10999 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
11000 Accept 3 additional arguments needed by handle_display_spec.
11001 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
11002 values: lists, `(when COND...)' forms, etc.
11003 (single_display_spec_string_p): Support property values that are
11004 lists with the argument STRING its top-level element.
11005 (display_prop_string_p): Fix the condition for processing a
11006 property that is a list to be consistent with handle_display_spec.
fec2107c 11007 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
11008 last portion of handle_display_prop.
11009 (compute_display_string_pos): Accept additional argument
11010 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
11011 value of a `display' property is a "replacing spec".
11012 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
11013 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
11014 the display property, but just return a value indicating whether
11015 the display property will replace the characters it covers.
11016 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
11017 frame_window_p members of struct bidi_it.
d6d100dd
SM
11018 (compute_display_string_pos, compute_display_string_end):
11019 New functions.
fec2107c
EZ
11020 (push_it): Accept second argument POSITION, where pop_it should
11021 jump to continue iteration.
11022 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 11023
fec2107c
EZ
11024 * keyboard.c (adjust_point_for_property): Adjust the call to
11025 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
11026
11027 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
11028 (bidi_init_it): Update prototypes.
11029 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
11030 (compute_display_string_pos, compute_display_string_end):
11031 Declare prototypes.
fec2107c
EZ
11032 (struct bidi_it): New members nchars and disp_pos. ch_len is now
11033 EMACS_INT.
fc6f18ce 11034
40087514 110352011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 11036
57f53182
PE
11037 Malloc failure behavior now depends on size of allocation.
11038 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
11039 * lisp.h: Change signatures accordingly.
11040 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
11041 All callers changed. (Bug#8762)
11042
11043 * gnutls.c: Use Emacs's memory allocators.
11044 Without this change, the gnutls library would invoke malloc etc.
11045 directly, which causes problems on non-SYNC_INPUT hosts, and which
11046 runs afoul of improving memory_full behavior. (Bug#8761)
11047 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
11048 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
11049 xfree instead of the default malloc, realloc, free.
11050 (Fgnutls_boot): No need to check for memory allocation failure,
11051 since xmalloc does that for us.
11052
ac32cd99 11053 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
11054 * category.c (hash_get_category_set):
11055 * ccl.c (ccl_driver):
11056 * charset.c (Fdefine_charset_internal):
11057 * charset.h (struct charset.hash_index):
11058 * composite.c (get_composition_id, gstring_lookup_cache)
11059 (composition_gstring_put_cache):
11060 * composite.h (struct composition.hash_index):
11061 * dispextern.h (struct image.hash):
11062 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
11063 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
11064 (hashfn_equal, hashfn_user_defined, make_hash_table)
11065 (maybe_resize_hash_table, hash_lookup, hash_put)
11066 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
11067 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
11068 (Fsxhash, Fgethash, Fputhash, Fmaphash):
11069 * image.c (make_image, search_image_cache, lookup_image)
11070 (xpm_put_color_table_h):
11071 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 11072 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 11073 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 11074 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
11075 * alloc.c (allocate_vectorlike):
11076 Check for overflow in vector size calculations.
11077 * ccl.c (ccl_driver):
11078 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
11079 * fns.c, image.c: Remove unnecessary static decls that would otherwise
11080 need to be updated by these changes.
40087514
PE
11081 * fns.c (make_hash_table, maybe_resize_hash_table):
11082 Check for integer overflow with large hash tables.
0de4bb68
PE
11083 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
11084 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
11085 (SXHASH_REDUCE): New macro.
11086 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
11087 Use it instead of discarding useful hash info with large hash values.
11088 (sxhash_float): New function.
11089 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
11090 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
11091 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
11092 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
11093 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
11094 Adjust signatures to match updated version of code.
11095 (consing_since_gc): Now EMACS_INT, since a single hash table can
11096 use more than INT_MAX bytes.
11097
698d32e2
DN
110982011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
11099
11100 Make it possible to build with GCC-4.6+ -O2 -flto.
11101
11102 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
11103
fd6fa53f
SM
111042011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
11105
11106 * minibuf.c (get_minibuffer, read_minibuf_unwind):
11107 Call minibuffer-inactive-mode.
11108
864db017
JB
111092011-05-31 Juanma Barranquero <lekktu@gmail.com>
11110
11111 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
11112 Update dependencies.
11113
2ad0baf4
DN
111142011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11115
11116 * data.c (init_data): Remove code for UTS, this system is not
11117 supported anymore.
11118
4fcc2638
DN
111192011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11120
11121 Don't force ./temacs to start in terminal mode.
11122
11123 * frame.c (make_initial_frame): Initialize faces in all cases, not
11124 only when CANNOT_DUMP is defined.
11125 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
11126
c56e0fd5
DN
111272011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11128
11129 * dispnew.c (add_window_display_history): Use const for the string
11130 pointer. Remove declaration, not needed.
11131
333d54da 111322011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 11133
55d4c1b2 11134 Use 'inline', not 'INLINE'.
333d54da 11135 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
11136 * alloc.c, fontset.c (INLINE): Remove.
11137 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
11138 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
11139 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
11140 * gmalloc.c (register_heapinfo): Use inline unconditionally.
11141 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
11142
738db178
DN
111432011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11144
11145 Make it possible to run ./temacs.
11146
11147 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
11148 syms_of_callproc does the same thing. Remove test for
11149 "initialized", do it in the caller.
11150 * emacs.c (main): Avoid calling set_initial_environment when dumping.
11151
620c53a6
SM
111522011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
11153
11154 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
11155 (read_minibuf): Use get_minibuffer.
11156 (syms_of_minibuf): Use DEFSYM.
11157 (Qmetadata): New var.
11158 * data.c (Qbuffer): Don't make it static.
11159 (syms_of_data): Use DEFSYM.
11160
e003a292
PE
111612011-05-31 Paul Eggert <eggert@cs.ucla.edu>
11162
11163 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
11164 (CCL_CODE_MIN): New macro.
11165
ed008a6d
PE
111662011-05-30 Paul Eggert <eggert@cs.ucla.edu>
11167
3687c2ef
PE
11168 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
11169
ed008a6d
PE
11170 * eval.c (Qdebug): Now static.
11171 * lisp.h (Qdebug): Remove decl. This reverts a part of the
11172 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
11173 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
11174
d66c4c7c
CY
111752011-05-29 Chong Yidong <cyd@stupidchicken.com>
11176
11177 * image.c: Various fixes to ImageMagick code comments.
11178 (Fimagemagick_types): Doc fix.
11179
5fbc2025
PE
111802011-05-29 Paul Eggert <eggert@cs.ucla.edu>
11181
0196f88a
PE
11182 Minor fixes prompted by GCC 4.6.0 warnings.
11183
11184 * xselect.c (converted_selections, conversion_fail_tag): Now static.
11185
5fbc2025
PE
11186 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
11187 (x_clipboard_manager_save_all): Move extern decl to ...
11188 * xterm.h: ... here, so that it can be checked for consistency.
11189
1dd3c2d9
CY
111902011-05-29 Chong Yidong <cyd@stupidchicken.com>
11191
11192 * xselect.c (x_clipboard_manager_save_frame)
11193 (x_clipboard_manager_save_all): New functions.
11194 (Fx_clipboard_manager_save): Lisp function deleted.
11195
11196 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
11197 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
11198
11199 * xterm.h: Update prototype.
11200
5ba6571d
WX
112012011-05-28 William Xu <william.xwl@gmail.com>
11202
11203 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
11204 exiting (Bug#8239).
11205
3eaff834
JM
112062011-05-28 Jim Meyering <meyering@redhat.com>
11207
e1900994 11208 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
11209 * fns.c (to_uchar): Define.
11210 (crypto_hash_function): Use it to convert some newly-signed
11211 variables to unsigned, to avoid sign-extension bugs. For example,
11212 without this change, (md5 "truc") would evaluate to
11213 45723a2aff78ff4fff7fff1114760e62 rather than the expected
11214 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 11215 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 11216
0f6990a7
PE
112172011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11218
11219 Integer overflow fixes.
c8a9ca5a 11220
08686060
PE
11221 * dbusbind.c: Serial number integer overflow fixes.
11222 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
11223 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
11224 to hold a serial number that is too large for a fixnum.
11225 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11226 Check for serial numbers out of range. Decode any serial number
59568bf0 11227 that was so large that it became a float. (Bug#8722)
08686060 11228
2d1fc3c7
PE
11229 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
11230 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11231 Use XFASTINT rather than XUINT when numbers are nonnegative.
11232 (xd_append_arg, Fdbus_method_return_internal):
11233 (Fdbus_method_error_internal): Likewise. Also, for unsigned
11234 arguments, check that Lisp number is nonnegative, rather than
59568bf0 11235 silently wrapping negative numbers around. (Bug#8722)
30217ff0 11236 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 11237 (Bug#8722)
2d1fc3c7 11238
c8a9ca5a
PE
11239 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
11240
519e1d69
PE
11241 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
11242
6df6ae42 11243 ccl: Add integer overflow checks.
30569699
PE
11244 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
11245 (IN_INT_RANGE): New macros.
11246 (ccl_driver): Use them to check for integer overflow when
11247 decoding a CCL program. Many of the new checks are whether XINT (x)
11248 fits in int; it doesn't always, on 64-bit hosts. The new version
11249 doesn't catch all possible integer overflows, but it's an
847044ea 11250 improvement. (Bug#8719)
30569699 11251
c11285dc
PE
11252 * alloc.c (make_event_array): Use XINT, not XUINT.
11253 There's no need for unsigned here.
11254
fdccd48e
PE
11255 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
11256 This follows up to the 2011-05-06 change that substituted uintptr_t
11257 for EMACS_INT. This case wasn't caught back then.
11258
37910ab2
PE
11259 Rework Fformat to avoid integer overflow issues.
11260 * editfns.c: Include <float.h> unconditionally, as it's everywhere
11261 now (part of C89). Include <verify.h>.
11262 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
11263 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
11264 (Fformat): Avoid the prepass trying to compute sizes; it was only
11265 approximate and thus did not catch overflow reliably. Instead, walk
11266 through the format just once, formatting and computing sizes as we go,
11267 checking for integer overflow at every step, and allocating a larger
11268 buffer as needed. Keep track separately whether the format is
11269 multibyte. Keep only the most-recently calculated precision, rather
11270 than them all. Record whether each argument has been converted to
11271 string. Use EMACS_INT, not int, for byte and char and arg counts.
11272 Support field widths and precisions larger than INT_MAX. Avoid
11273 sprintf's undefined behavior with conversion specifications such as %#d
11274 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
11275 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
11276 formatting out-of-range floating point numbers with int
9173deec 11277 formats. (Bug#8668)
37910ab2 11278
2e6578fb
PE
11279 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
11280
0ae6bdee
PE
11281 * data.c: Avoid integer truncation in expressions involving floats.
11282 * data.c: Include <intprops.h>.
11283 (arith_driver): When there's an integer overflow in an expression
11284 involving floating point, convert the integers to floating point
11285 so that the resulting value does not suffer from catastrophic
11286 integer truncation. For example, on a 64-bit host (* 4
11287 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
11288 Do not rely on undefined behavior after integer overflow.
11289
de883a70
PE
11290 merge count_size_as_multibyte, parse_str_to_multibyte
11291 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 11292 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
11293 Check for integer overflow.
11294 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
11295 since it's now a duplicate of the other. This is more of
11296 a character than a buffer op, so better that it's in character.c.
11297 * fns.c, print.c: Adjust to above changes.
11298
2ff916cb
PE
112992011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
11300
11301 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
11302
f1b54466
PE
113032011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11304
fb1ac845
PE
11305 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11306 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
11307 (x_clipboard_manager_save): Now static.
11308 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
11309
f1b54466
PE
11310 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11311 (crypto_hash_function): Now static.
11312 Fix pointer signedness problems. Avoid unnecessary initializations.
11313
a9f737ee
CY
113142011-05-27 Chong Yidong <cyd@stupidchicken.com>
11315
11316 * termhooks.h (Vselection_alist): Make it terminal-local.
11317
11318 * terminal.c (create_terminal): Initialize it.
11319
11320 * xselect.c: Support for clipboard managers.
11321 (Vselection_alist): Move to termhooks.h as terminal-local var.
11322 (LOCAL_SELECTION): New macro.
11323 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
11324 (symbol_to_x_atom): Remove gratuitous arg.
11325 (x_handle_selection_request, lisp_data_to_selection_data)
11326 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
11327 (x_own_selection, x_get_local_selection, x_convert_selection):
11328 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
11329 (some_frame_on_display): Delete unused function.
11330 (Fx_own_selection_internal, Fx_get_selection_internal)
11331 (Fx_disown_selection_internal, Fx_selection_owner_p)
11332 (Fx_selection_exists_p): New optional frame arg.
11333 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
11334 (x_handle_selection_clear): Don't treat other terminals with the
11335 same keyboard specially. Use the terminal-local Vselection_alist.
11336 (x_clear_frame_selections): Use Frun_hook_with_args.
11337
11338 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
11339
11340 * xterm.h: Add support for those atoms.
11341
e067f0c1
CY
113422011-05-26 Chong Yidong <cyd@stupidchicken.com>
11343
11344 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
11345 (converted_selections, conversion_fail_tag): New global variables.
11346 (x_selection_request_lisp_error): Free the above.
11347 (x_get_local_selection): Remove unnecessary code.
11348 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
11349 of converted selections stored in converted_selections.
11350 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
11351 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
11352 (x_convert_selection): New function.
11353 (x_handle_selection_event): Simplify.
11354 (x_get_foreign_selection): Don't ignore incoming requests while
11355 waiting for an answer; this will fail when we implement
11356 SAVE_TARGETS, and seems unnecessary anyway.
11357 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
11358 (Vx_sent_selection_functions): Doc fix.
11359
0f4aebc0
LL
113602011-05-26 Leo Liu <sdl.web@gmail.com>
11361
11362 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
11363
e61124cd
YM
113642011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11365
11366 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
11367
11368 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
11369 for fringe update if it has periodic bitmap.
ac389d0c 11370 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
11371 and fringe_bitmap_periodic_p.
11372
11373 * fringe.c (get_fringe_bitmap_data): New function.
11374 (draw_fringe_bitmap_1, update_window_fringes): Use it.
11375 (update_window_fringes): Record periodicity of fringe bitmap in glyph
11376 row. Mark glyph row for fringe update if periodicity changed.
11377
11378 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
11379 for fringe update unless it has periodic bitmap.
11380
f16d9837
KH
113812011-05-25 Kenichi Handa <handa@m17n.org>
11382
11383 * xdisp.c (get_next_display_element): Set correct it->face_id for
11384 a static composition.
11385
e1b90ef6
LL
113862011-05-24 Leo Liu <sdl.web@gmail.com>
11387
11388 * deps.mk (fns.o):
11389 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
11390
11391 * fns.c (crypto_hash_function, Fsha1): New function.
11392 (Fmd5): Use crypto_hash_function.
11393 (syms_of_fns): Add Ssha1.
11394
7400048f
PE
113952011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11396
11397 * gnutls.c: Remove unused macros.
11398 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
11399 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
11400 Remove macros that are defined and never used.
11401 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
11402
abb71cf4
CY
114032011-05-22 Chong Yidong <cyd@stupidchicken.com>
11404
11405 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
11406 (Fx_get_selection_internal): Minor cleanup.
11407 (Fx_own_selection_internal): Rename arguments for consistency with
11408 select.el.
11409
6307db39
PE
114102011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11411
11412 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
11413
f3d4e0a4
CY
114142011-05-22 Chong Yidong <cyd@stupidchicken.com>
11415
11416 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
11417
4d8ade89
YM
114182011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11419
11420 * dispnew.c (scrolling_window): Don't exclude the case that the
11421 last enabled row in the desired matrix touches the bottom boundary.
11422
32078c8d
GM
114232011-05-21 Glenn Morris <rgm@gnu.org>
11424
11425 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
11426 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
11427 and add some more files.
32078c8d 11428
7285dc67
EZ
114292011-05-20 Eli Zaretskii <eliz@gnu.org>
11430
11431 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
11432 report_file_error introduced by the change from 2011-05-07.
11433
89d1bd22
PE
114342011-05-20 Paul Eggert <eggert@cs.ucla.edu>
11435
11436 * systime.h (Time): Define only if emacs is defined.
11437 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
11438 where the include path doesn't have X11/X.h by default. See
11439 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
11440
cd394be1 114412011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
11442
11443 * composite.c (find_automatic_composition): Fix previous change.
11444
b9704ad9
GM
114452011-05-20 Glenn Morris <rgm@gnu.org>
11446
11447 * lisp.mk: New file, split from Makefile.in.
11448 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
11449 (shortlisp): Remove.
11450 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
11451
4a720484
GM
114522011-05-19 Glenn Morris <rgm@gnu.org>
11453
11454 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
11455 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
11456 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
11457 (lisp): Set the order to that of loadup.el.
11458 (shortlisp): Make it a copy of $lisp.
11459 (SOME_MACHINE_LISP): Remove.
11460 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
11461 Use just $shortlisp, not $SOME_MACHINE_LISP too.
11462
a28d4396
KH
114632011-05-18 Kenichi Handa <handa@m17n.org>
11464
11465 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
11466 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
11467 (find_automatic_composition): Mostly rewrite for efficiency.
11468
a2b1fa8e
JB
114692011-05-18 Juanma Barranquero <lekktu@gmail.com>
11470
11471 * makefile.w32-in: Update dependencies.
11472
8e1f5610
CS
114732011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
11474
11475 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 11476 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 11477
7025ee00 114782011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 11479
cdfa6eab
PE
11480 Fix some integer overflow issues, such as string length overflow.
11481
06d6db33
PE
11482 * insdel.c (count_size_as_multibyte): Check for string overflow.
11483
2b4560a8
PE
11484 * character.c (lisp_string_width): Check for string overflow.
11485 Use EMACS_INT, not int, for string indexes and lengths; in
11486 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
11487 the resulting string length overflows an EMACS_INT; instead,
11488 report a string overflow if no precision given. When checking for
11489 precision exhaustion, use a check that cannot possibly have
11490 integer overflow. (Bug#8675)
11491 * character.h (lisp_string_width): Adjust to new signature.
11492
cb93f9be
PE
11493 * alloc.c (string_overflow): New function.
11494 (Fmake_string): Use it. This doesn't change behavior, but saves
11495 a few bytes and will simplify future changes.
11496 * character.c (string_escape_byte8): Likewise.
11497 * lisp.h (string_overflow): New decl.
11498
1a1f3366
PE
11499 Fixups, following up to the user-interface timestamp change.
11500 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
11501 for UI timestamps, instead of unsigned long.
9fbd6841
PE
11502 * msdos.c (mouse_get_pos): Likewise.
11503 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
11504 * w32gui.h (Time): Define by including "systime.h" rather than by
11505 declaring it ourselves. (Bug#8664)
11506
d4e3e4d3
PE
11507 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
11508 * image.c (clear_image_cache): Likewise.
11509
f6a24d19
PE
11510 * term.c (term_mouse_position): Don't assume time_t wraparound.
11511
08dc5ae6
PE
11512 Be more systematic about user-interface timestamps.
11513 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
11514 and sometimes 'EMACS_UINT', to represent these timestamps.
11515 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
11516 This makes the code easier to follow, and makes it easier to catch
11517 integer overflow bugs such as Bug#8664.
11518 * frame.c (Fmouse_position, Fmouse_pixel_position):
11519 Use Time, not unsigned long, for user-interface timestamps.
11520 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
11521 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
11522 * keyboard.h (last_event_timestamp): Likewise.
11523 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
11524 * menu.h (xmenu_show): Likewise.
11525 * term.c (term_mouse_position): Likewise.
11526 * termhooks.h (struct input_event.timestamp): Likewise.
11527 (struct terminal.mouse_position_hook): Likewise.
11528 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
11529 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
11530 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
11531 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
11532 what it was before.
11533 * menu.h, termhooks.h: Include "systime.h", for Time.
11534
8e55734a
PE
11535 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
11536 Don't assume that the difference between two unsigned long values
11537 can fit into an integer. At this point, we know button_down_time
11538 <= event->timestamp, so the difference must be nonnegative, so
11539 there's no need to cast the result if double-click-time is
11540 nonnegative, as it should be; check that it's nonnegative, just in
11541 case. This bug is triggered when events are more than 2**31 ms
86db42d2 11542 apart (about 25 days). (Bug#8664)
8e55734a 11543
841f1b75 11544 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 11545 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 11546
3e26f69c
PE
11547 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
11548 that always fit in int. Use a sentinel instead of a counter, to
11549 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
11550 * frame.h (struct frame): Use int for menu_bar_items_used
11551 instead of EMACS_INT, since it always fits in int.
3e26f69c 11552
5cc152c0
PE
11553 * menu.c (grow_menu_items): Check for int overflow.
11554
d89eb65e
PE
11555 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
11556
5235bd3e
PE
11557 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
11558 Before, the code was not consistent. These values cannot exceed
11559 2**31 - 1 so there's no need to make them unsigned.
11560 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
11561 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
11562 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
11563 as modifiers.
11564 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
11565
bc827e23
PE
11566 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
11567 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
11568 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
11569 presumably because the widths might not match.
11570
78eb494e
PE
11571 * window.c (size_window): Avoid needless test at loop start.
11572
04f2d78b
CB
115732011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
11574
11575 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
11576
d2fc7e3d 115772011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
11578
11579 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
11580
d2fc7e3d 115812011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
11582
11583 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
11584 `width' to `bar_area_x' and `bar_area_width', respectively.
11585 (x_scroll_run): Take account of fringe background extension.
11586
04f2d78b
CB
11587 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
11588 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
11589 `bar_area_width', respectively.
11590 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
11591 background extension.
11592
79b70037
GM
115932011-05-10 Jim Meyering <meyering@redhat.com>
11594
11595 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
11596
2f142cc5
JB
115972011-05-10 Juanma Barranquero <lekktu@gmail.com>
11598
11599 * image.c (Finit_image_library): Return t for built-in image types,
11600 like pbm and xbm. (Bug#8640)
11601
57679c86
AS
116022011-05-09 Andreas Schwab <schwab@linux-m68k.org>
11603
11604 * w32menu.c (set_frame_menubar): Fix submenu allocation.
11605
888c9e86
EZ
116062011-05-07 Eli Zaretskii <eliz@gnu.org>
11607
b0512a1d
EZ
11608 * w32console.c (Fset_screen_color): Doc fix.
11609 (Fget_screen_color): New function.
11610 (syms_of_ntterm): Defsubr it.
11611
7285dc67
EZ
11612 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
11613 unlink the temporary file if Fcall_process didn't create it in the
11614 first place.
11615 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
11616 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
11617 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
11618 cue to call_process_cleanup not to close that handle.
11619
4d3fcc8e
BK
116202011-05-07 Ben Key <bkey76@gmail.com>
11621
11622 * makefile.w32-in: The bootstrap-temacs rule now makes use of
11623 one of two shell specific rules, either bootstrap-temacs-CMD or
11624 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
11625 to the previous implementation of the bootstrap-temacs rule.
11626 The bootstrap-temacs-CMD rule is similar to the previous
11627 implementation of the bootstrap-temacs rule except that it
11628 makes use of the ESC_CFLAGS variable instead of the CFLAGS
11629 variable.
11630
11631 These changes, along with some changes to nt/configure.bat,
11632 nt/gmake.defs, and nt/nmake.defs, are required to extend my
11633 earlier fix to add support for --cflags and --ldflags options
11634 that include quotes so that it works whether make uses cmd or
11635 sh as the shell.
11636
b4289b64
MA
116372011-05-06 Michael Albinus <michael.albinus@gmx.de>
11638
11639 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
11640 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
11641 is a constant.
11642 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
11643 a string. Handle both cases.
11644 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
11645 (Fdbus_register_method): Use Qinvalid_function.
11646
af4c0e28
JB
116472011-05-06 Juanma Barranquero <lekktu@gmail.com>
11648
11649 * makefile.w32-in: Update dependencies.
11650 (LISP_H): Add inttypes.h and stdin.h.
11651 (PROCESS_H): Add unistd.h.
11652
c51453d9
EZ
116532011-05-06 Eli Zaretskii <eliz@gnu.org>
11654
11655 * lread.c: Include limits.h (fixes the MS-Windows build broken by
11656 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
11657
8ff0ac3c 116582011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 11659
4c4b566b
PE
11660 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
11661
aab2b9b5
PE
11662 * term.c (vfatal): Remove stray call to va_end.
11663 It's not needed and the C Standard doesn't allow it here anyway.
11664
c378da0b
PE
11665 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
11666 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
11667
288b08c7
PE
11668 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
11669 bytes.
11670
e3601888
PE
11671 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
11672
db6c0e74
PE
11673 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
11674
dd5963ea
PE
11675 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
11676
88c9450f
PE
11677 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
11678
2f9442b8
PE
11679 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
11680
c032b5f8
PE
11681 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
11682 * charset.c (Fdefine_charset_internal): Don't initialize
11683 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 11684 32-bit int (Bug#8600).
a108c10b
PE
11685
11686 * lread.c (read_integer): Be more consistent with string-to-number.
11687 Use string_to_number to do the actual conversion; this avoids
11688 rounding errors and fixes some other screwups. Without this fix,
11689 for example, #x1fffffffffffffff was misread as -2305843009213693952.
11690 (digit_to_number): Move earlier, for benefit of read_integer.
11691 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 11692 not a digit in any supported base. (Bug#8602)
a108c10b 11693
ad5f9eea
PE
11694 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
11695
aec1708a
PE
11696 * dispnew.c (scrolling_window): Return 1 if we scrolled,
11697 to match comment at start of function. This also removes a
11698 GCC warning about overflow in a 32+64-bit port.
11699
47be4ab5
PE
11700 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
11701
371cac43
PE
11702 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
11703 Reported by Stefan Monnier in
11704 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
11705 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11706 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 11707
d01a7826
PE
11708 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
11709 (EMACS_UINTPTR): Likewise, with uintptr_t.
11710
7fd47d5c
PE
11711 * lisp.h: Prefer 64-bit EMACS_INT if available.
11712 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
11713 on 32-bit hosts that have 64-bit int, so that they can access
11714 large files.
122b0c86
PE
11715 However, temporarily disable this change unless the temporary
11716 symbol WIDE_EMACS_INT is defined.
7fd47d5c 11717
8727937b
PE
11718 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
11719
8ac068ac
PE
11720 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
11721 This removes an assumption that EMACS_INT and long are the same
11722 width as pointers. The assumption is true for Emacs porting targets
11723 now, but we want to make other targets possible.
11724 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
11725 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
11726 In the rest of the code, change types of integers that hold casted
11727 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
11728 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
11729 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
11730 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
11731 No need to cast type when ORing.
11732 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
11733 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
11734 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
11735 assume EMACS_INT is the same width as char *.
11736 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
11737 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
11738 Remove no-longer-needed casts.
11739 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
11740 (xg_tool_bar_help_callback, xg_make_tool_item):
11741 Use EMACS_INTPTR to hold an integer
11742 that will be cast to void *; this can avoid a GCC warning
11743 if EMACS_INT is not the same width as void *.
11744 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
11745 * xdisp.c (display_echo_area_1, resize_mini_window_1):
11746 (current_message_1, set_message_1):
11747 Use a local to convert to proper width without a cast.
11748 * xmenu.c (dialog_selection_callback): Likewise.
11749
ede49d71
PE
11750 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
11751 Also, don't assume VALBITS / RAND_BITS is less than 5,
11752 and don't rely on undefined behavior when shifting a 1 left into
11753 the sign bit.
11754 * lisp.h (get_random): Change signature to match.
11755
2f30ecd0
PE
11756 * lread.c (hash_string): Use size_t, not int, for hash computation.
11757 Normally we prefer signed values; but hashing is special, because
11758 it's better to use unsigned division on hash table sizes so that
11759 the remainder is nonnegative. Also, size_t is the natural width
11760 for hashing into memory. The previous code used 'int', which doesn't
11761 retain enough info to hash well into very large tables.
11762 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
11763
2a866e7b
PE
11764 * dbusbind.c: Don't possibly lose pointer info when converting.
11765 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11766 Use XPNTR rather than XHASH, so that the high-order bits of
11767 the pointer aren't lost when converting through void *.
11768
51639eac
PE
11769 * eval.c (Fautoload): Don't double-shift a pointer.
11770
92394119
PE
11771 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
11772
dbdb9a7c
JB
117732011-05-06 Juanma Barranquero <lekktu@gmail.com>
11774
11775 * gnutls.c (DEF_GNUTLS_FN):
11776 * image.c (DEF_IMGLIB_FN): Make function pointers static.
11777
db7a0b4f
AS
117782011-05-05 Andreas Schwab <schwab@linux-m68k.org>
11779
11780 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
11781 marker. (Bug#8610)
11782
cd394be1 117832011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
11784
11785 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
11786 New version that can reserve upto 2GB of heap space.
11787
f7ff1b0f 117882011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
11789
11790 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
11791
639c109b
TZ
117922011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
11793
11794 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
11795 `gnutls_certificate_set_x509_key_file'.
11796
d2127135
JB
117972011-05-05 Juanma Barranquero <lekktu@gmail.com>
11798
11799 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
11800 Update dependencies.
11801
e968f4f3
JB
118022011-05-04 Juanma Barranquero <lekktu@gmail.com>
11803
11804 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
11805 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
11806 Remove unused parameter `fildes'.
11807 * process.c (read_process_output, send_process): Don't pass it.
11808
84d358f0
JB
118092011-05-04 Juanma Barranquero <lekktu@gmail.com>
11810
11811 Fix previous change: the library cache is defined in w32.c.
11812 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
11813 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
11814
0898ca10
JB
118152011-05-04 Juanma Barranquero <lekktu@gmail.com>
11816
11817 Implement dynamic loading of GnuTLS on Windows.
11818
11819 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
11820 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
11821 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11822 Declare.
11823
11824 * gnutls.c (Qgnutls_dll): Define.
11825 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
11826 (gnutls_*): Declare function pointers.
11827 (init_gnutls_functions): New function to initialize function pointers.
11828 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
11829 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
11830 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11831 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
11832 (emacs_gnutls_write, emacs_gnutls_read)
11833 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
11834 (Fgnutls_available_p): New function.
11835 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
11836 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
11837 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
11838
11839 * image.c: Include w32.h.
11840 (Vimage_type_cache): Delete.
11841 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
11842 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
11843 (w32_delayed_load): Move to w32.c.
11844
11845 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
11846
11847 * w32.c (QCloaded_from, Vlibrary_cache): Define.
11848 (w32_delayed_load): Move from image.c. When loading a library, record
11849 its filename in the :loaded-from property of the library id.
11850 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
11851 Initialize and staticpro them.
11852 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
11853
11854 * process.c: Include lisp.h before w32.h, not after.
11855 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
11856 instead of gnutls_record_check_pending.
11857
11858 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
11859
ff4de4aa
TZ
118602011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
11861
11862 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
11863 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
11864 as passed in.
11865
abe95abb
JD
118662011-05-03 Jan Djärv <jan.h.d@swipnet.se>
11867
11868 * xterm.c (x_set_frame_alpha): Do not set property on anything
11869 else than FRAME_X_OUTER_WINDOW (Bug#8608).
11870
e16e55d4
JB
118712011-05-02 Juanma Barranquero <lekktu@gmail.com>
11872
11873 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
11874
bafcf6a5
JB
118752011-05-02 Juanma Barranquero <lekktu@gmail.com>
11876
11877 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
11878 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
11879 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
11880 (gnutls_global_initialized, Qgnutls_bootprop_priority)
11881 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
11882 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
11883 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
11884 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
11885 (Qgnutls_bootprop_callbacks_verify): Make static.
11886
e7a6747f
AS
118872011-05-01 Andreas Schwab <schwab@linux-m68k.org>
11888
19ed11ba
AS
11889 * callproc.c: Indentation fixup.
11890
e7a6747f 11891 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
11892 (wait_for_termination, interruptible_wait_for_termination):
11893 Move after wait_for_termination_1.
e7a6747f 11894
1ef14cb4
LMI
118952011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
11896
11897 * sysdep.c (interruptible_wait_for_termination): New function
11898 which is like wait_for_termination, but allows keyboard
11899 interruptions.
11900
11901 * callproc.c (Fcall_process): Add (:file "file") as an option for
11902 the STDOUT buffer.
11903 (Fcall_process_region): Ditto.
11904
330d880c
EZ
119052011-04-30 Eli Zaretskii <eliz@gnu.org>
11906
8db90b73
EZ
11907 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
11908 rather than `XVECTOR (FOO)->size'.
11909
330d880c
EZ
11910 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
11911 inttypes.h, as a gnulib replacement is used if it not available in
11912 system headers.
11913
15cbd324
EZ
119142011-04-21 Eli Zaretskii <eliz@gnu.org>
11915
11916 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
11917 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
11918 of MOST_POSITIVE_FIXNUM. (Bug#8528)
11919
11920 * coding.c (coding_alloc_by_realloc): Error out if destination
11921 will grow beyond MOST_POSITIVE_FIXNUM.
11922 (decode_coding_emacs_mule): Abort if there isn't enough place in
11923 charbuf for the composition carryover bytes. Reserve an extra
11924 space for up to 2 characters produced in a loop.
11925 (decode_coding_iso_2022): Abort if there isn't enough place in
11926 charbuf for the composition carryover bytes.
11927
119282011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 11929
ae940cca
EZ
11930 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
11931 aborting when %lld or %lll format is passed.
11932 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
11933 %llo or %llx format is passed. (Bug#8545)
11934
03ab8921
EZ
11935 * window.c (window_scroll_line_based): Use a marker instead of
11936 simple variables to record original value of point. (Bug#7952)
11937
afda1437
EZ
11938 * doprnt.c (doprnt): Fix the case where a multibyte sequence
11939 produced by %s or %c overflows available buffer space. (Bug#8545)
11940
f76dee0c
PE
119412011-04-28 Paul Eggert <eggert@cs.ucla.edu>
11942
11943 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 11944 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 11945
fdc5744d
JB
119462011-04-28 Juanma Barranquero <lekktu@gmail.com>
11947
11948 * w32.c (init_environment): Warn about defaulting HOME to C:\.
11949
638f053a
JB
119502011-04-28 Juanma Barranquero <lekktu@gmail.com>
11951
11952 * keyboard.c (Qdelayed_warnings_hook): Define.
11953 (command_loop_1): Run `delayed-warnings-hook'
11954 if Vdelayed_warnings_list is non-nil.
11955 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
11956 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
11957
d178f871
EZ
119582011-04-28 Eli Zaretskii <eliz@gnu.org>
11959
11960 * doprnt.c (doprnt): Don't return value smaller than the buffer
11961 size if the message was truncated. (Bug#8545).
11962
b124fd93
JB
119632011-04-28 Juanma Barranquero <lekktu@gmail.com>
11964
11965 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
11966 (Fx_window_property): #if-0 the whole functions, not just the bodies.
11967
e810457d
PE
119682011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11969
11970 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
11971
ea51cceb
JB
119722011-04-27 Juanma Barranquero <lekktu@gmail.com>
11973
11974 * makefile.w32-in: Update dependencies.
11975
94dcfacf
EZ
119762011-04-27 Eli Zaretskii <eliz@gnu.org>
11977
11978 Improve `doprnt' and its usage. (Bug#8545)
11979 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
11980 `format_end'. Remove support for %l as a conversion specifier.
11981 Don't use xrealloc. Improve diagnostics when the %l size modifier
11982 is used. Update the commentary.
11983
11984 * eval.c (verror): Simplify calculation of size_t.
11985
11986 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
11987 messages.
11988
f61f41d7
PE
119892011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
11990
11991 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
11992 change.
11993
96fb4434
PE
119942011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11995
11996 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
11997 This makes this file independent of the recent pseudovector change.
11998
671875da 119992011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 12000
69e9b5a3
PE
12001 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
12002
b5f869a7 12003 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 12004 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 12005 Remove unused local.
c8926152 12006 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 12007
841a1577 12008 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
12009 GCC 4.6.0 optimizes based on type-based alias analysis.
12010 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
12011 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
12012 != &v->size, and therefore "v->size = 1; b->size = 2; return
12013 v->size;" must therefore return 1. This assumption is incorrect
12014 for Emacs, since it type-puns struct Lisp_Vector * with many other
12015 types. To fix this problem, this patch adds a new type struct
f904488f 12016 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
12017 and pseudovectors, and helps optimizing compilers not get fooled
12018 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
12019 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
12020 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
12021 the size member.
eab3844f
PE
12022 (XSETPVECTYPE): Rewrite in terms of new macro.
12023 (XSETPVECTYPESIZE): New macro, specifying both type and size.
12024 This is a bit clearer, and further avoids the possibility of
12025 undesirable aliasing.
12026 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 12027 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
12028 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
12029 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
12030 (ASIZE): Now uses header.size rather than size.
12031 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
12032 to avoid the hassle of writing XVECTOR (foo)->header.size.
12033 (struct vectorlike_header): New type.
eab3844f
PE
12034 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
12035 object, to help avoid aliasing.
12036 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
12037 (SUBRP): Likewise, since Lisp_Subr is a special case.
12038 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
12039 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
12040 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 12041 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
12042 changed to be "header.size" and "header.next".
12043 * buffer.h (struct buffer): Likewise.
12044 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
12045 * frame.h (struct frame): Likewise.
12046 * process.h (struct Lisp_Process): Likewise.
12047 * termhooks.h (struct terminal): Likewise.
12048 * window.c (struct save_window_data, struct saved_window): Likewise.
12049 * window.h (struct window): Likewise.
12050 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
12051 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
12052 * buffer.c (init_buffer_once): Likewise.
12053 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
12054 special case.
12055 * process.c (Fformat_network_address): Use local var for size,
12056 for brevity.
12057
0df1eac5
PE
12058 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
12059
847ab9d1 12060 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
12061 * data.c (atof): Remove decl; no longer used or needed.
12062 (digit_to_number): Move to lread.c.
12063 (Fstring_to_number): Use new string_to_number function, to be
12064 consistent with how the Lisp reader treats infinities and NaNs.
12065 Do not assume that floating-point numbers represent EMACS_INT
12066 without losing information; this is not true on most 64-bit hosts.
12067 Avoid double-rounding errors, by insisting on integers when
12068 parsing non-base-10 numbers, as the documentation specifies.
12069 * lisp.h (string_to_number): New decl, replacing ...
12070 (isfloat_string): Remove.
bc0a5c13 12071 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 12072 (read1): Do not accept +. and -. as integers; this
452f4150
PE
12073 appears to have been a coding error. Similarly, do not accept
12074 strings like +-1e0 as floating point numbers. Do not report
12075 overflow for integer overflows unless the base is not 10 which
12076 means we have no simple and reliable way to continue.
12077 Break out the floating-point parsing into a new
12078 function string_to_number, so that Fstring_to_number parses
12079 floating point numbers consistently with the Lisp reader.
04f2d78b 12080 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
12081 (E_CHAR, EXP_INT): Remove, replacing with ...
12082 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
12083 (string_to_number): New function, replacing isfloat_string.
12084 This function checks for valid syntax and produces the resulting
12085 Lisp float number too. Rework it so that string-to-number
bc0a5c13 12086 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
12087 so that overflow for non-base-10 numbers is reported only when
12088 there's no portable and simple way to convert to floating point.
452f4150 12089
67769ffc
PE
12090 * textprop.c (set_text_properties_1): Rewrite for clarity,
12091 and to avoid GCC warning about integer overflow.
12092
c20db43f
PE
12093 * intervals.h (struct interval): Use EMACS_INT for members
12094 where EMACS_UINT might cause problems. See
12095 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
12096 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
12097 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
12098 All uses changed.
37aa2f85
PE
12099 (offset_intervals): Tell GCC not to worry about length overflow
12100 when negating a negative length.
c20db43f 12101
2538aa2f
PE
12102 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
12103 (overrun_check_free): Likewise.
12104
f2d3008d
PE
12105 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
12106 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
12107 word size.
12108
ec8df744
PE
12109 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12110 (gnutls_make_error): Rename local to avoid shadowing.
12111 (gnutls_emacs_global_deinit): ifdef out; not used.
12112 (Fgnutls_boot): Use const for pointer to readonly storage.
12113 Comment out unused local. Fix pointer signedness problems.
12114
640ee02d
PE
12115 * lread.c (openp): Don't stuff size_t into an 'int'.
12116 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
12117 about possible signed overflow.
12118
6048fb2a
PE
12119 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12120 (GDK_KEY_g): Don't define if already defined.
12121 (xg_prepare_tooltip): Avoid pointer signedness problem.
12122 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
12123
fa3c87e1
PE
12124 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
12125 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
12126
2172544b
PE
12127 * xfns.c (Fx_window_property): Simplify a bit,
12128 to make a bit faster and to avoid GCC 4.6.0 warning.
12129 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
12130
9b821a21
PE
12131 * fns.c (internal_equal): Don't assume size_t fits in int.
12132
3c616cfa
PE
12133 * alloc.c (compact_small_strings): Tighten assertion a little.
12134
c2982e87
PE
12135 Replace pEd with more-general pI, and fix some printf arg casts.
12136 * lisp.h (pI): New macro, generalizing old pEd macro to other
12137 conversion specifiers. For example, use "...%"pI"d..." rather
12138 than "...%"pEd"...".
12139 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 12140 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
12141 * alloc.c (check_pure_size): Don't overflow by converting size to int.
12142 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
12143 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
12144 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
12145 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
12146 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
12147 64-bit hosts.
12148 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
12149 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
12150 * print.c (safe_debug_print, print_object): Likewise.
12151 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
12152 to int.
6f04d126
PE
12153 Use pI instead of if-then-else-abort. Use %p to avoid casts,
12154 avoiding the 0 flag, which is not portable.
c2982e87
PE
12155 * process.c (Fmake_network_process): Use pI to avoid cast.
12156 * region-cache.c (pp_cache): Likewise.
12157 * xdisp.c (decode_mode_spec): Likewise.
12158 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
12159 behavior on 64-bit hosts with printf arg.
6f04d126 12160 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
12161 (x_stop_queuing_selection_requests): Likewise.
12162 (x_get_window_property): Don't truncate byte count to an 'int'
12163 when tracing.
0b432f21 12164
5e073ec7
PE
12165 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
12166 here, since it parses constructs like leading '-' and spaces,
12167 which are not wanted; and it overflows with large numbers.
12168 Instead, simply match F[0-9]+, which is what is wanted anyway.
12169
36372bf9
PE
12170 * alloc.c: Remove unportable assumptions about struct layout.
12171 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
12172 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
12173 (allocate_vectorlike, make_pure_vector): Use the new macros,
12174 plus offsetof, to remove unportable assumptions about struct layout.
12175 These assumptions hold on all porting targets that I know of, but
12176 they are not guaranteed, they're easy to remove, and removing them
12177 makes further changes easier.
12178
0b432f21
PE
12179 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
12180 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
12181 (string_overrun_cookie): Now const. Use initializers that
12182 don't formally overflow signed char, to avoid warnings.
000098c1
PE
12183 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
12184 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
12185 (allocate_buffer): Don't assume sizeof (struct buffer) is a
12186 multiple of sizeof (EMACS_INT); it need not be, if
12187 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 12188 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 12189
895009e1
JB
121902011-04-26 Juanma Barranquero <lekktu@gmail.com>
12191
12192 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
12193
6a7a1b0b
TZ
121942011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
12195
12196 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 12197 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
12198 Reported by Paul Eggert <eggert@cs.ucla.edu>.
12199
841a1577 122002011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
12201
12202 * lisp.h (Qdebug): List symbol.
895009e1 12203 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
12204 * keyboard.c (debug-on-event): New variable.
12205 (handle_user_signal): Break into debugger when debug-on-event
12206 matches the current signal symbol.
12207
f2d3ba6f
DN
122082011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
12209
12210 * alloc.c (check_sblock, check_string_bytes)
12211 (check_string_free_list): Convert to standard C.
12212
42ce4c63
TZ
122132011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
12214
12215 * w32.c (emacs_gnutls_push): Fix typo.
12216
825cd63c
EZ
122172011-04-25 Eli Zaretskii <eliz@gnu.org>
12218
fb11d64d
EZ
12219 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
12220 "cast to pointer from integer of different size".
12221
825cd63c
EZ
12222 Improve doprnt and its use in verror. (Bug#8545)
12223 * doprnt.c (doprnt): Document the set of format control sequences
12224 supported by the function. Use SAFE_ALLOCA instead of always
12225 using `alloca'.
12226
12227 * eval.c (verror): Don't limit the buffer size at size_max-1, that
12228 is one byte too soon. Don't use xrealloc; instead xfree and
12229 xmalloc anew.
12230
e061a11b
TZ
122312011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
12232
12233 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
12234 callbacks stage.
12235
12236 * gnutls.c: Renamed global_initialized to
12237 gnutls_global_initialized. Added internals for the
12238 :verify-hostname-error, :verify-error, and :verify-flags
12239 parameters of `gnutls-boot' and documented those parameters in the
12240 docstring. Start callback support.
9173deec
JB
12241 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
12242 unless a fatal error occurred. Call gnutls_alert_send_appropriate
12243 on error. Return error code.
e061a11b
TZ
12244 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
12245 (emacs_gnutls_read): Likewise.
12246 (Fgnutls_boot): Return handshake error code.
12247 (emacs_gnutls_handle_error): New function.
12248 (wsaerror_to_errno): Likewise.
12249
12250 * w32.h (emacs_gnutls_pull): Add prototype.
12251 (emacs_gnutls_push): Likewise.
12252
12253 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
12254 (emacs_gnutls_push): Likewise.
12255
122562011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
12257
12258 * process.c (wait_reading_process_output): Check if GnuTLS
12259 buffered some data internally if no FDs are set for TLS
12260 connections.
12261
12262 * makefile.w32-in (OBJ2): Add gnutls.$(O).
12263 (LIBS): Link to USER_LIBS.
12264 ($(BLD)/gnutls.$(0)): New target.
12265
fa6996bc
EZ
122662011-04-24 Eli Zaretskii <eliz@gnu.org>
12267
eb35682e
EZ
12268 * xdisp.c (handle_single_display_spec): Rename the
12269 display_replaced_before_p argument into display_replaced_p, to
12270 make it consistent with the commentary. Fix typos in the
12271 commentary.
12272
e2ad650c
EZ
12273 * textprop.c (syms_of_textprop): Remove dead code.
12274 (copy_text_properties): Delete obsolete commentary about an
12275 interface that was deleted long ago. Fix typos in the description
12276 of arguments.
12277
1b2de274
EZ
12278 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
12279 to changes in oldXMenu/XMenu.h from 2011-04-16.
12280 <menu_help_message, prev_menu_help_message>: Constify.
12281 (IT_menu_make_room): menu->help_text is now `const char **';
12282 adjust.
12283
12284 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
12285 to changes in oldXMenu/XMenu.h from 2011-04-16.
12286 (struct XMenu): Declare `help_text' `const char **'.
12287
12288 * xfaces.c <Qunspecified>: Make extern again.
12289
12290 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 12291 required by POSIX.
1b2de274 12292
762b15be
EZ
12293 * doc.c (get_doc_string): Improve the format passed to `error'.
12294
12295 * doprnt.c (doprnt): Improve commentary.
12296
12297 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
12298
12299 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
12300 them with etags.
12301
f1052e5d
EZ
12302 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
12303 changes in globals.h immediately force recompilation.
762b15be
EZ
12304 (TAGS): Depend on $(CURDIR)/m/intel386.h and
12305 $(CURDIR)/s/ms-w32.h.
12306 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 12307
fa6996bc
EZ
12308 * character.c (Fchar_direction): Function deleted.
12309 (syms_of_character): Don't defsubr it.
12310 <char-direction-table>: Deleted.
12311
e6c3da20
EZ
123122011-04-23 Eli Zaretskii <eliz@gnu.org>
12313
12314 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
12315 * doprnt.c: Include limits.h.
12316 (SIZE_MAX): New macro.
04f2d78b
CB
12317 (doprnt): Return a size_t value. 2nd arg is now size_t.
12318 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
12319 Improve overflow protection. Support `l' modifier for integer
12320 conversions. Support %l conversion. Don't assume an EMACS_INT
12321 argument for integer conversions and for %c.
12322
12323 * lisp.h (doprnt): Restore prototype.
12324
12325 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
12326 $(SRC)/character.h.
12327
12328 * Makefile.in (base_obj): Add back doprnt.o.
12329
12330 * deps.mk (doprnt.o): Add back prerequisites.
12331 (callint.o): Depend on character.h.
12332
12333 * eval.c (internal_lisp_condition_case): Include the handler
12334 representation in the error message.
12335 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
12336 when breaking from the loop.
12337
12338 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
12339
12340 * callint.c (Fcall_interactively): When displaying error message
12341 about invalid control letter, pass the character's codepoint, not
12342 a pointer to its multibyte form. Improve display of the character
12343 in octal and display also its hex code.
12344
12345 * character.c (char_string): Use %x to display the (unsigned)
12346 codepoint of an invalid character, to avoid displaying a bogus
12347 negative value.
12348
12349 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
12350 `error', not SYMBOL_NAME itself.
12351
12352 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
12353 character arguments to `error'.
12354
12355 * charset.c (check_iso_charset_parameter): Fix incorrect argument
12356 to `error' in error message about FINAL_CHAR argument. Make sure
12357 FINAL_CHAR is a character, and use %c when it is passed as
12358 argument to `error'.
12359
4ffd0d6b 123602011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
12361
12362 * s/ms-w32.h (localtime): Redirect to sys_localtime.
12363
12364 * w32.c: Include <time.h>.
12365 (sys_localtime): New function.
12366
4ffd0d6b 123672011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
12368
12369 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
12370
4ffd0d6b 12371 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 12372
4ffd0d6b 123732011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 12374
4ffd0d6b
GM
12375 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
12376 zombies (Bug#8467).
aac0c6e3 12377
04c56954
EZ
123782011-04-19 Eli Zaretskii <eliz@gnu.org>
12379
12380 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
12381 gl_state.e_property when gl_state.object is Qt.
12382
12383 * insdel.c (make_gap_larger): Remove limitation of buffer size
12384 to <= INT_MAX.
12385
16a43933
CY
123862011-04-18 Chong Yidong <cyd@stupidchicken.com>
12387
12388 * xdisp.c (lookup_glyphless_char_display)
12389 (produce_glyphless_glyph): Handle cons cell entry in
12390 glyphless-char-display.
12391 (Vglyphless_char_display): Document it.
12392
12393 * term.c (produce_glyphless_glyph): Handle cons cell entry in
12394 glyphless-char-display.
12395
4581706e
CY
123962011-04-17 Chong Yidong <cyd@stupidchicken.com>
12397
12398 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
12399
12400 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
12401
12402 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
12403 definition for no-X builds.
12404
4887c6e2 124052011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 12406
fd35b6f9
PE
12407 Static checks with GCC 4.6.0 and non-default toolkits.
12408
5c1ccb01
PE
12409 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
12410
006c5daa
PE
12411 * process.c (keyboard_bit_set): Define only if SIGIO.
12412 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
12413 (send_process): Repair possible setjmp clobbering.
12414
efc736d3
PE
12415 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
12416
4e2fe2e6
PE
12417 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
12418
f97334a2
PE
12419 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
12420
4e75f29d
PE
12421 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
12422 Define only if needed.
12423
90efadd1
PE
12424 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
12425 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 12426 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 12427
3c647824
PE
12428 * dispextern.h (struct redisplay_interface): Rename param
12429 to avoid shadowing.
e264f262 12430 * termhooks.h (struct terminal): Likewise.
761383f4 12431 * xterm.c (xembed_send_message): Likewise.
3c647824 12432
b58c5c4a
PE
12433 * insdel.c (make_gap_smaller): Define only if
12434 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
12435
cad59032
PE
12436 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
12437 it.
12438
c339dc2e
PE
12439 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
12440 so that we aren't warned about unused symbols.
12441
91a3e27b
PE
12442 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
12443
399c71d3 12444 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 12445
8ffc96f5
PE
12446 * xfns.c (x_real_positions): Mark locals as initialized.
12447
eef9bc79
PE
12448 * xmenu.c (xmenu_show): Don't use uninitialized vars.
12449
098db9dd
PE
12450 * xterm.c: Fix problems found by static analysis with other toolkits.
12451 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
12452 (x_dispatch_event): Declare static if USE_GTK, and
12453 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 12454 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 12455 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
12456 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
12457 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 12458
eb18f6cc
PE
12459 * xmenu.c (menu_help_callback): Pointer type fixes.
12460 Use const pointers when pointing at readonly data. Avoid pointer
12461 signedness clashes.
12462 (FALSE): Remove unused macro.
12463 (update_frame_menubar): Remove unused decl.
12464
1fe72bf8
PE
12465 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
12466
60d9e1db
PE
12467 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
12468 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
12469 (single_menu_item): Rename local to avoid shadowing.
12470
39261c26
PE
12471 * keyboard.c (make_lispy_event): Remove unused local var.
12472
018c5e19
PE
12473 * frame.c, frame.h (x_get_resource_string): Bring this back, but
12474 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
12475
63d2b86e
PE
12476 * bitmaps: Change bitmaps from unsigned char back to the X11
12477 compatible char. Avoid the old compiler warnings about
12478 out-of-range initializers by using, for example, '\xab' rather
12479 than 0xab.
12480
aefd87e1
PE
12481 * xgselect.c (xgselect_initialize): Check vs interface
12482 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
12483
bf501fb9
PE
12484 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
12485
e9829fdf
PE
12486 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
12487 to read-only memory.
12488
1086c095
PE
12489 * fns.c (vector): Remove; this old hack is no longer needed.
12490
2baccd04 12491 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 12492 Remove unused var.
dde42981 12493 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 12494
72391843 12495 * xrdb.c (x_load_resources): Omit unused local.
3565b346 12496
436c16df 12497 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 12498 (x_window): Rename locals to avoid shadowing.
dc5ddd85 12499 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 12500
92bb796d 12501 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 12502 (x_term_init): Remove local to avoid shadowing.
92bb796d 12503
764430a3 12504 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
12505
12506 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
12507 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
12508
d1dfb56c
EZ
125092011-04-16 Eli Zaretskii <eliz@gnu.org>
12510
c4354cb4
EZ
12511 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
12512
d1dfb56c
EZ
12513 Fix regex.c, syntax.c and friends for buffers > 2GB.
12514 * syntax.h (struct gl_state_s): Declare character position members
12515 EMACS_INT.
12516
12517 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
12518
04f2d78b
CB
12519 * textprop.c (verify_interval_modification, interval_of):
12520 Declare arguments EMACS_INT.
d1dfb56c
EZ
12521
12522 * intervals.c (adjust_intervals_for_insertion): Declare arguments
12523 EMACS_INT.
12524
12525 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
12526
12527 * indent.c (Fvertical_motion): Local variable it_start is now
12528 EMACS_INT.
12529
12530 * regex.c (re_match, re_match_2, re_match_2_internal)
12531 (bcmp_translate, regcomp, regexec, print_double_string)
12532 (group_in_compile_stack, re_search, re_search_2, regex_compile)
12533 (re_compile_pattern, re_exec): Declare arguments and local
12534 variables `size_t' and `ssize_t' and return values `regoff_t', as
12535 appropriate.
12536 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
12537 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
12538 <compile_stack_type>: `size' and `avail' are now `size_t'.
12539
12540 * regex.h <regoff_t>: Use ssize_t, not int.
12541 (re_search, re_search_2, re_match, re_match_2): Arguments that
12542 specify buffer/string position and length are now ssize_t and
12543 size_t. Return type is regoff_t.
12544
613052cd
BK
125452011-04-16 Ben Key <bkey76@gmail.com>
12546
12547 * nsfont.m: Fixed bugs in ns_get_family and
12548 ns_descriptor_to_entity that were caused by using free to
12549 deallocate memory blocks that were allocated by xmalloc (via
12550 xstrdup). This caused Emacs to crash when compiled with
12551 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
12552 --enable-checking=xmallocoverrun). xfree is now used to
12553 deallocate these memory blocks.
12554
4170f62f 125552011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 12556
71b41406
PE
12557 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
12558
9587a89d
PE
12559 emacs_write: Accept and return EMACS_INT for sizes.
12560 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
12561 et seq.
12562 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
12563 Accept and return EMACS_INT.
12564 (emacs_gnutls_write): Return the number of bytes written on
12565 partial writes.
12566 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
12567 (emacs_read, emacs_write): Remove check for negative size, as the
12568 Emacs source code has been audited now.
9587a89d
PE
12569 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
12570 (emacs_read, emacs_write): Use it.
273a5f82
PE
12571 * process.c (send_process): Adjust to the new signatures of
12572 emacs_write and emacs_gnutls_write. Do not attempt to store
12573 a byte offset into an 'int'; it might overflow.
9587a89d 12574 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 12575
3e047f51
PE
12576 * sound.c: Don't assume sizes fit in 'int'.
12577 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 12578 Return EMACS_INT, not int.
3e047f51 12579 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
12580 Accept EMACS_INT, not int.
12581 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
12582 record read return values.
12583
cc39a9db
BK
125842011-04-15 Ben Key <bkey76@gmail.com>
12585
c9d0ec6d
JB
12586 * keyboard.c (Qundefined): Don't declare static since it is used
12587 in nsfns.m.
12588 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
12589 static since they are used in nsfont.m.
cc39a9db 12590
6c60eb9f
SM
125912011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
12592
12593 * process.c (Qprocessp): Don't declare static.
12594 * lisp.h (Qprocessp): Declare again.
12595
7990b61a
JB
125962011-04-15 Juanma Barranquero <lekktu@gmail.com>
12597
12598 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
12599
5d4cb038
PE
126002011-04-14 Paul Eggert <eggert@cs.ucla.edu>
12601
8bd7b830 12602 Improve C-level modularity by making more things 'static'.
cd64ea1d 12603
e3b27b31
PE
12604 Don't publish debugger-only interfaces to other modules.
12605 * lisp.h (safe_debug_print, debug_output_compilation_hack):
12606 (verify_bytepos, count_markers): Move decls to the only modules
12607 that need them.
12608 * region-cache.h (pp_cache): Likewise.
12609 * window.h (check_all_windows): Likewise.
12610 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
12611
5d4cb038
PE
12612 * sysdep.c (croak): Now static, if
12613 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
12614 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
12615
12616 * alloc.c (refill_memory_reserve): Now static if
12617 !defined REL_ALLOC || defined SYSTEM_MALLOC.
12618 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 12619
e87b6180
PE
12620 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
12621 Define only if USE_LUCID.
12622
ac64929e
PE
12623 * xrdb.c (x_customization_string, x_rm_string): Now static.
12624
6f37259d
PE
12625 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
12626 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
12627
1683e3ab
PE
12628 * xdisp.c (draw_row_with_mouse_face): Now static.
12629 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
12630
de9c2632
PE
12631 * window.h (check_all_windows): Mark externally visible.
12632
2b96acb7
PE
12633 * window.c (window_deletion_count): Now static.
12634
12635 * undo.c: Make symbols static if they're not exported.
12636 (last_undo_buffer, last_boundary_position, pending_boundary):
12637 Now static.
12638
50436f33
PE
12639 * textprop.c (interval_insert_behind_hooks): Now static.
12640 (interval_insert_in_front_hooks): Likewise.
12641
64520e5c
PE
12642 * term.c: Make symbols static if they're not exported.
12643 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
12644 (max_frame_lines, tty_set_terminal_modes):
12645 (tty_reset_terminal_modes, tty_turn_off_highlight):
12646 (get_tty_terminal): Now static.
12647 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
12648 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 12649 HAVE_WINDOW_SYSTEM.
64520e5c
PE
12650 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
12651 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
12652
1fa53021
PE
12653 * sysdep.c: Make symbols static if they're not exported.
12654 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
12655 Now static.
12656 (sigprocmask_set, full_mask): Remove; unused.
12657 (wait_debugging): Mark as visible.
12658 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
12659 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
12660
d4b43b22
PE
12661 * syntax.c (syntax_temp): Define only if !__GNUC__.
12662
b7c513d0
PE
12663 * sound.c (current_sound_device, current_sound): Now static.
12664
989b29ad
PE
12665 * search.c (searchbufs, searchbuf_head): Now static.
12666
13a55a78
PE
12667 * scroll.c (scroll_cost): Remove; unused.
12668 * dispextern.h (scroll_cost): Remove decl.
12669
de68a1fc
PE
12670 * region-cache.h (pp_cache): Mark as externally visible.
12671
40ccffa6
PE
12672 * process.c: Make symbols static if they're not exported.
12673 (process_tick, update_tick, create_process, chan_process):
12674 (Vprocess_alist, proc_buffered_char, datagram_access):
12675 (fd_callback_data, send_process_frame, process_sent_to): Now static.
12676 (deactivate_process): Mark defn as static, as well as decl.
12677 * lisp.h (create_process): Remove decl.
12678 * process.h (chan_process, Vprocess_alist): Remove decls.
12679
ad64fc97
PE
12680 * print.c: Make symbols static if they're not exported.
12681 (print_depth, new_backquote_output, being_printed, print_buffer):
12682 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
12683 (print_interval, print_number_index, initial_stderr_stream):
12684 Now static.
12685 * lisp.h (Fprinc): Remove decl.
12686 (debug_output_compilation_hack): Mark as externally visible.
12687
adddb265
PE
12688 * sysdep.c (croak): Move decl from here to syssignal.h.
12689 * syssignal.h (croak): Put it here, so the API can be checked when
12690 'croak' is called from dissociate_if_controlling_tty.
12691
1717ede2
PE
12692 * minibuf.c: Make symbols static if they're not exported.
12693 (minibuf_save_list, choose_minibuf_frame): Now static.
12694 * lisp.h (choose_minibuf_frame): Remove decl.
12695
fa5fb2bc
PE
12696 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
12697
1e3890d1
PE
12698 * lread.c: Make symbols static if they're not exported.
12699 (read_objects, initial_obarray, oblookup_last_bucket_number):
12700 Now static.
12701 (make_symbol): Remove; unused.
12702 * lisp.h (initial_obarray, make_symbol): Remove decls.
12703
8a1414fa
PE
12704 * keyboard.c: Make symbols static if they're not exported.
12705 (single_kboard, recent_keys_index, total_keys, recent_keys):
12706 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
12707 (this_single_command_key_start, echoing, last_auto_save):
12708 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
12709 (command_loop, echo_now, keyboard_init_hook, help_char_p):
12710 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
12711 (Vlispy_mouse_stem, double_click_count):
12712 Now static.
12713 (force_auto_save_soon): Define only if SIGDANGER.
12714 (ignore_mouse_drag_p): Now static if
12715 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
12716 (print_help): Remove; unused.
12717 (stop_character, last_timer_event): Mark as externally visible.
12718 * keyboard.h (ignore_mouse_drag_p): Declare only if
12719 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
12720 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
12721 * lisp.h (echoing): Remove decl.
12722 (force_auto_save_soon): Declare only if SIGDANGER.
12723 * xdisp.c (redisplay_window): Simplify code, to make it more
12724 obvious that ignore_mouse_drag_p is not accessed if !defined
12725 USE_GTK && !defined HAVE_NS.
12726
93ea6e8f
PE
12727 * intervals.c: Make symbols static if they're not exported.
12728 (merge_properties_sticky, merge_interval_right, delete_interval):
12729 Now static.
12730 * intervals.h (merge_interval_right, delete_interval): Remove decls.
12731
77382fcc
PE
12732 * insdel.c: Make symbols static if they're not exported.
12733 However, leave prepare_to_modify_buffer alone. It's never
12734 called from outside this function, but that appears to be a bug.
12735 (combine_after_change_list, combine_after_change_buffer):
4889fc82 12736 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
12737 (adjust_after_replace_noundo): Remove; unused.
12738 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 12739 (signal_before_change): Remove decls.
77382fcc 12740
9306c32e
PE
12741 * indent.c (val_compute_motion, val_vmotion): Now static.
12742
cd44d2eb
PE
12743 * image.c: Make symbols static if they're not exported.
12744 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
12745 if USE_GTK.
12746 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
12747 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
12748
ad9a7a06
PE
12749 * fringe.c (standard_bitmaps): Now static.
12750 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
12751
81626931
PE
12752 * frame.c: Make symbols static if they're not exported.
12753 (x_report_frame_params, make_terminal_frame): Now static.
12754 (get_frame_param): Now static, unless HAVE_NS.
12755 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
12756 (x_get_resource_string): Remove; not used.
12757 * frame.h (make_terminal_frame, x_report_frame_params):
12758 (x_get_resource_string); Remove decls.
12759 (x_fullscreen_adjust): Declare only if WINDOWSNT.
12760 * lisp.h (get_frame_param): Declare only if HAVE_NS.
12761
239f9db9
PE
12762 * font.c, fontset.c: Make symbols static if they're not exported.
12763 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
12764 (FACE_SUITABLE_FOR_CHAR_P): Use it.
12765 * font.c (font_close_object): Now static.
12766 * font.h (font_close_object): Remove.
12767 * fontset.c (FONTSET_OBJLIST): Remove.
12768 (free_realized_fontset) #if-0 the body, which does nothing.
12769 (face_suitable_for_char_p): #if-0, as it's never called.
12770 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
12771 * xfaces.c (face_at_string_position):
12772 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
12773 since 0 is always ASCII.
12774
dfcf3579
PE
12775 * fns.c (weak_hash_tables): Now static.
12776
5045092b
PE
12777 * fileio.c: Make symbols static if they're not exported.
12778 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
12779 (Vwrite_region_annotation_buffers): Now static.
12780
57a96f5c
PE
12781 * eval.c: Make symbols static if they're not exported.
12782 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
12783 * lisp.h (backtrace_list): Remove decl.
12784
35f08c38
PE
12785 * emacs.c: Make symbols static if they're not exported.
12786 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
12787 (fatal_error_code, fatal_error_signal_hook, standard_args):
12788 Now static.
12789 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
12790 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
12791 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
12792 * lisp.h (fatal_error_signal_hook): Remove decl.
12793 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
12794
f44bd759
PE
12795 * editfns.c: Move a (normally-unused) function to its only use.
12796 * editfns.c, lisp.h (get_operating_system_release): Remove.
12797 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
12798 worth the hassle of breaking this out.
12799
b532497d
PE
12800 * xterm.c: Make symbols static if they're not exported.
12801 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
12802 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
12803 (x_destroy_window, x_delete_display):
12804 Now static.
12805 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
12806 (x_mouse_leave): Remove; unused.
12807 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
12808 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
12809 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
12810 Remove decls.
12811 (x_mouse_leave): Declare only if WINDOWSNT.
12812 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
12813 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
12814 USE_X_TOOLKIT.
12815
1675728f
PE
12816 * ftxfont.c: Make symbols static if they're not exported.
12817 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
12818 HAVE_FREETYPE.
12819 * font.h (ftxfont_driver): Likewise.
12820
e4cebfca
PE
12821 * xfns.c: Make symbols static if they're not exported.
12822 (x_last_font_name, x_display_info_for_name):
12823 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
12824 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
12825 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
12826 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
12827 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
12828 (last_show_tip_args): Now static.
12829 (xic_defaut_fontset, xic_create_fontsetname): Define only if
12830 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
12831 (x_screen_planes): Remove; unused.
12832 * dispextern.h (x_screen_planes): Remove decl.
12833
5bf46f05
PE
12834 * dispnew.c: Make symbols static if they're not exported.
12835 * dispextern.h (redraw_garbaged_frames, scrolling):
12836 (increment_row_positions): Remove.
12837 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
12838 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
12839 Now static.
12840 (redraw_garbaged_frames): Remove; unused.
12841
435f4c28
PE
12842 * xfaces.c: Make symbols static if they're not exported.
12843 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
12844 Remove decls.
12845 * xterm.h (defined_color): Remove decls.
12846 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
12847 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
12848 (menu_face_changed_default, defined_color, free_realized_face):
12849 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
12850 (ascii_face_of_lisp_face): Remove; unused.
12851
8524aef3
PE
12852 * xdisp.c: Make symbols static if they're not exported.
12853 * dispextern.h (scratch_glyph_row, window_box_edges):
12854 (glyph_to_pixel_coords, set_cursor_from_row):
12855 (get_next_display_element, set_iterator_to_next):
12856 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
12857 (show_mouse_face): Remove decls
12858 * frame.h (message_buf_print): Likewise.
12859 * lisp.h (pop_message, set_message, check_point_in_composition):
12860 Likewise.
12861 * xterm.h (set_vertical_scroll_bar): Likewise.
12862 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
12863 (message_buf_print, scratch_glyph_row, displayed_buffer):
12864 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
12865 (get_next_display_element, show_mouse_face, window_box_edges):
12866 (frame_to_window_pixel_xy, check_point_in_composition):
12867 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
12868 (glyph_to_pixel_coords): Remove; unused.
12869
16390cd2
PE
12870 * dired.c (file_name_completion): Now static.
12871
12872 * dbusbind.c (xd_in_read_queued_messages): Now static.
12873
a25f4dfa
PE
12874 * lisp.h (circular_list_error, FOREACH): Remove; unused.
12875 * data.c (circular_list_error): Remove.
12876
14a9c8df
PE
12877 * commands.h (last_point_position, last_point_position_buffer):
12878 (last_point_position_window): Remove decls.
12879 * keyboard.c: Make these variables static.
12880
04f2d78b
CB
12881 * coding.h (coding, code_convert_region, encode_coding_gap):
12882 Remove decls.
74ab6df5
PE
12883 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
12884 (iso_code_class, detect_coding, code_convert_region): Now static.
12885 (encode_coding_gap): Remove; unused.
12886
38dfbee1
PE
12887 * chartab.c (chartab_chars, chartab_bits): Now static.
12888
a2cb4e63
PE
12889 * charset.h (charset_iso_8859_1): Remove decl.
12890 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
12891 Now static.
12892
127198fd
PE
12893 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
12894 * ccl.c (Vccl_program_table): Now static.
12895 (check_ccl_update): Remove; unused.
12896
d85b608f
PE
12897 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
12898 * category.h: ... from here.
12899 * category.c (check_category_table, set_category_set): Now static.
12900
31cd66f3
PE
12901 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
12902 * lisp.h: Remove these decls.
12903
c358e587
PE
12904 * buffer.c (buffer_count): Remove unused var.
12905
e78aecca
PE
12906 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
12907 so that it's not optimized away.
12908 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
12909 * dispextern.h (bidi_dump_cached_states): Remove, since it's
12910 exported only to the debugger.
12911
e192d7d3 12912 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 12913 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 12914
92470028
PE
12915 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
12916 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
12917 was inaccessible from Lisp.
12918 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
12919 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
12920
244ed907
PE
12921 alloc.c: Import and export fewer symbols, and remove unused items.
12922 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
12923 is defined.
12924 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
12925 it's not optimized away by whole-program optimization.
12926 (message_enable_multibyte, free_misc): Remove.
12927 (catchlist, handlerlist, mark_backtrace):
12928 Declare only if BYTE_MARK_STACK.
12929 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
12930 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
12931 (message_enable_multibyte): Remove decl.
12932 (free_misc, interval_free_list, float_block, float_block_index):
12933 (n_float_blocks, float_free_list, cons_block, cons_block_index):
12934 (cons_free_list, last_marked_index):
12935 Now static.
12936 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
12937 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
12938 (mark_backtrace): Define only if BYTE_MARK_STACK.
12939 * xdisp.c (message_enable_multibyte): Now static.
12940
61c2b50e 12941 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
12942 This makes it easier for human readers (and static analyzers)
12943 to see whether these variables are used from other modules.
12944 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
12945 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
12946 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
12947 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
12948 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
12949 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
12950 * xmenu.c, xselect.c:
12951 Declare Q* vars static if they are not used in other modules.
12952 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
12953 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
12954 Remove decls of unexported vars.
12955 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
12956
95c82688
PE
12957 * lisp.h (DEFINE_FUNC): Make sname 'static'.
12958
16a97296
PE
12959 Make Emacs functions such as Fatom 'static' by default.
12960 This makes it easier for human readers (and static analyzers)
12961 to see whether these functions can be called from other modules.
12962 DEFUN now defines a static function. To make the function external
12963 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
12964 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
12965 (Finit_image_library):
16a97296
PE
12966 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
12967 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
12968 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
12969 Remove decls, since these functions are now static.
12970 (Funintern, Fget_internal_run_time): New decls, since these functions
12971 were already external.
95c82688 12972
16a97296
PE
12973 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
12974 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
12975 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
12976 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
12977 * keyboard.c, keymap.c, lread.c:
12978 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
12979 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
12980 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
12981 Mark functions with DEFUE instead of DEFUN,
12982 if they are used in other modules.
12983 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
12984 decls for now-static functions.
12985 * buffer.h (Fdelete_overlay): Remove decl.
12986 * callproc.c (Fgetenv_internal): Mark as internal.
12987 * composite.c (Fremove_list_of_text_properties): Remove decl.
12988 (Fcomposition_get_gstring): New forward static decl.
12989 * composite.h (Fcomposite_get_gstring): Remove decl.
12990 * dired.c (Ffile_attributes): New forward static decl.
12991 * doc.c (Fdocumntation_property): New forward static decl.
12992 * eval.c (Ffetch_bytecode): New forward static decl.
12993 (Funintern): Remove extern decl; now in .h file where it belongs.
12994 * fileio.c (Fmake_symbolic_link): New forward static decl.
12995 * image.c (Finit_image_library): New forward static decl.
12996 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
12997 * intervals.h (Fprevious_property_change):
12998 (Fremove_list_of_text_properties): Remove decls.
12999 * keyboard.c (Fthis_command_keys): Remove decl.
13000 (Fcommand_execute): New forward static decl.
13001 * keymap.c (Flookup_key): New forward static decl.
13002 (Fcopy_keymap): Now static.
13003 * keymap.h (Flookup_key): Remove decl.
13004 * process.c (Fget_process): New forward static decl.
13005 (Fprocess_datagram_address): Mark as internal.
13006 * syntax.c (Fsyntax_table_p): New forward static decl.
13007 (skip_chars): Remove duplicate decl.
13008 * textprop.c (Fprevious_property_change): New forward static decl.
13009 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
13010 Now internal.
13011 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
13012 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
13013
785bbd42
PE
13014 * editfns.c (Fformat): Remove unreachable code.
13015
8b913b57
AS
130162011-04-14 Andreas Schwab <schwab@linux-m68k.org>
13017
13018 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
13019 change. (Bug#8496)
13020
a6744a35
EZ
130212011-04-13 Eli Zaretskii <eliz@gnu.org>
13022
13023 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
13024 when at ZV. (Bug#8487)
13025
e7974947
AS
130262011-04-12 Andreas Schwab <schwab@linux-m68k.org>
13027
baad03f0
AS
13028 * charset.c (Fclear_charset_maps): Use xfree instead of free.
13029 (Bug#8437)
13030 * keyboard.c (parse_tool_bar_item): Likewise.
13031 * sound.c (sound_cleanup, alsa_close): Likewise.
13032 * termcap.c (tgetent): Likewise.
13033 * xfns.c (x_default_font_parameter): Likewise.
13034 * xsettings.c (read_and_apply_settings): Likewise.
13035
e7974947
AS
13036 * alloc.c (overrun_check_malloc, overrun_check_realloc)
13037 (overrun_check_free): Protoize.
13038
28272684
PE
130392011-04-12 Paul Eggert <eggert@cs.ucla.edu>
13040
13041 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
13042 since callers should never pass a negative size.
13043 Change the signature to match that of plain 'read' and 'write'; see
13044 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
13045 * lisp.h: Update prototypes of emacs_write and emacs_read.
13046
11997c76
EZ
130472011-04-11 Eli Zaretskii <eliz@gnu.org>
13048
13049 * xdisp.c (redisplay_window): Don't try to determine the character
13050 position of the scroll margin if the window start point w->startp
e896f03c 13051 is outside the buffer's accessible region. (Bug#8468)
11997c76 13052
8a2cbd72
EZ
130532011-04-10 Eli Zaretskii <eliz@gnu.org>
13054
13055 Fix write-region and its subroutines for buffers > 2GB.
13056 * fileio.c (a_write, e_write): Modify declaration of arguments and
13057 local variables to support buffers larger than 2GB.
13058 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
13059
13060 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
13061 argument, local variables, and return value.
13062
13063 * lisp.h: Update prototypes of emacs_write and emacs_read.
13064
13065 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
13066
4073e537 130672011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 13068
1ebfdcb6
PE
13069 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
13070
b2ded58d
PE
13071 Fix more problems found by GCC 4.6.0's static checks.
13072
7d66342c
PE
13073 * xdisp.c (vmessage): Use a better test for character truncation.
13074
bbf47d44
PE
13075 * charset.c (load_charset_map): <, not <=, for optimization,
13076 and to avoid potential problems with integer overflow.
9248994d 13077 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 13078 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 13079 * editfns.c (Fformat): Likewise.
1e69125e 13080 * syntax.c (skip_chars): Likewise.
3befa583 13081
e3019616
PE
13082 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
13083 This also lets GCC 4.6.0 generate slightly better loop code.
13084
becfa255
PE
13085 * callint.c (Fcall_interactively): <, not <=, for optimization.
13086 (Fcall_interactively): Count the number of arguments produced,
13087 not the number of arguments given. This is simpler and lets GCC
13088 4.6.0 generate slightly better code.
13089
dae0cd48
PE
13090 * ftfont.c: Distingish more carefully between FcChar8 and char.
13091 The previous code passed unsigned char * to a functions like
13092 strlen and xstrcasecmp that expect char *, which does not
13093 conform to the C standard.
13094 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
13095 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
13096 char * when the C standard requires it.
13097
76032d70
PE
13098 * keyboard.c (read_char): Remove unused var.
13099
eb3f1cc8
PE
13100 * eval.c: Port to Windows vsnprintf (Bug#8435).
13101 Include <limits.h>.
13102 (SIZE_MAX): Define if the headers do not.
13103 (verror): Do not give up if vsnprintf returns a negative count.
13104 Instead, grow the buffer. This ports to Windows vsnprintf, which
13105 does not conform to C99. Problem reported by Eli Zaretskii.
13106 Also, simplify the allocation scheme, by avoiding the need for
13107 calling realloc, and removing the ALLOCATED variable.
13108
70476b54
PE
13109 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
13110
12020a9e
PE
13111 Remove invocations of doprnt, as Emacs now uses vsnprintf.
13112 But keep the doprint source code for now, as we might revamp it
13113 and use it again (Bug#8435).
ea6c7ae6
PE
13114 * lisp.h (doprnt): Remove.
13115 * Makefile.in (base_obj): Remove doprnt.o.
13116 * deps.mk (doprnt.o): Remove.
13117
5fdb398c
PE
13118 error: Print 32- and 64-bit integers portably (Bug#8435).
13119 Without this change, on typical 64-bit hosts error ("...%d...", N)
13120 was used to print both 32- and 64-bit integers N, which relied on
13121 undefined behavior.
61bdb816 13122 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
13123 * lisp.h (error, verror): Mark as printf-like functions.
13124 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
13125 Report overflow in size calculations when allocating printf buffer.
13126 Do not truncate output string at its first null byte.
13127 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
13128 Truncate the output at a character boundary, since vsnprintf does not
13129 do that.
13130 * charset.c (check_iso_charset_parameter): Convert internal
13131 character to string before calling 'error', since %c now has the
13132 printf meaning.
13133 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
13134 overflow when computing char to be passed to 'error'. Do not
13135 pass Lisp_Object to 'error'; pass the integer instead.
13136 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
13137 formatted with plain %d.
13138
b189fa66
PE
13139 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
13140
bff87ef0
PE
13141 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
13142
7e2cac20
PE
13143 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
13144
ce4d90b5
PE
13145 * xterm.c (x_catch_errors): Remove duplicate declaration.
13146
266c9547
PE
13147 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
13148
79c49ad2
PE
13149 * xdisp.c, lisp.h (message_nolog): Remove; unused.
13150
368f4090
JM
131512011-04-10 Jim Meyering <meyering@redhat.com>
13152
13153 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
13154 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
13155 return ssize_t not "int", and use size_t as the buffer length.
13156 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
13157 * gnutls.h: Update declarations.
13158 * process.c (read_process_output): Use ssize_t, to match.
13159 (send_process): Likewise.
13160
a32d4040
CY
131612011-04-09 Chong Yidong <cyd@stupidchicken.com>
13162
13163 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
13164
8546720e 131652011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 13166
04f2d78b
CB
13167 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
13168 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 13169
8546720e
GM
13170 * xterm.c (handle_one_xevent):
13171 * xmenu.c (create_and_show_popup_menu):
13172 * xselect.c (x_decline_selection_request)
13173 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 13174
0a2f5c1a 131752011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
13176
13177 Fix some uses of `int' instead of EMACS_INT.
13178 * search.c (string_match_1, fast_string_match)
13179 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
13180 (scan_buffer, find_next_newline_no_quit)
13181 (find_before_next_newline, search_command, Freplace_match)
13182 (Fmatch_data): Make some `int' variables be EMACS_INT.
13183
13184 * xdisp.c (display_count_lines): 3rd argument and return value now
13185 EMACS_INT. All callers changed.
13186 (pint2hrstr): Last argument is now EMACS_INT.
13187
13188 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
13189 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
13190 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
13191 (decode_coding_utf_16, decode_coding_emacs_mule)
13192 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
13193 (decode_coding_ccl, decode_coding_charset)
13194 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
13195 (decode_coding_iso_2022, decode_coding_emacs_mule)
13196 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
13197 <char_offset, last_offset>: Declare EMACS_INT.
13198 (encode_coding_utf_8, encode_coding_utf_16)
13199 (encode_coding_emacs_mule, encode_invocation_designation)
13200 (encode_designation_at_bol, encode_coding_iso_2022)
13201 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
13202 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
13203 Declare EMACS_INT.
13204 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
13205 (encode_invocation_designation): Last argument P_NCHARS is now
13206 EMACS_INT.
13207 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
13208 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
13209
13210 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
13211 All users changed.
13212
13213 * ccl.c (Fccl_execute_on_string): Declare some variables
13214 EMACS_INT.
13215
8546720e 132162011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
13217
13218 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
13219
4e19a977
CS
132202011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
13221
13222 * process.c (Fformat_network_address): Doc fix.
13223
87302331
R
132242011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
13225
ee7683eb 13226 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 13227
cbb59342
CY
132282011-04-08 Chong Yidong <cyd@stupidchicken.com>
13229
13230 * keyboard.c (read_char): Call Lisp function help-form-show,
13231 instead of using internal_with_output_to_temp_buffer.
13232 (Qhelp_form_show): New var.
e0d38eeb 13233 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
13234
13235 * print.c (internal_with_output_to_temp_buffer): Function deleted.
13236
13237 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
13238
e67a13ab
CY
132392011-04-06 Chong Yidong <cyd@stupidchicken.com>
13240
04f2d78b
CB
13241 * process.c (Flist_processes): Remove to Lisp.
13242 (list_processes_1): Delete.
e67a13ab 13243
973f782d
EZ
132442011-04-06 Eli Zaretskii <eliz@gnu.org>
13245
7c106b1e
EZ
13246 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
13247
973f782d
EZ
13248 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
13249
41cf7d1a 132502011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 13251
ca23cc88
PE
13252 Fix more problems found by GCC 4.6.0's static checks.
13253
f390e2d5
PE
13254 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
13255
42eea0d0
PE
13256 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
13257
b69769da 13258 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 13259
f9541e84
PE
13260 * xdisp.c (vmessage): Mark as a printf-like function.
13261
13841b55
PE
13262 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
13263
c136c10f
PE
13264 * sound.c (sound_warning): Don't crash if arg contains a printf format.
13265
5e2d4a30
PE
13266 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
13267 printf-like functions.
13268 (tiff_load): Add casts to remove these marks before passing them
13269 to system-supplied API.
13270
583f48b9
PE
13271 * eval.c (Fsignal): Remove excess argument to 'fatal'.
13272
b25d760e
PE
13273 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
13274 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
13275 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
13276 directly, rather than having caller test rule sign. This avoids
13277 some unnecessary tests.
13278 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
13279 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
13280 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 13281
bc7b6697 13282 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 13283 (xfont_open): Avoid unnecessary tests.
bc7b6697 13284
27ccc379
PE
13285 * composite.c (composition_gstring_put_cache): Use unsigned integer.
13286
dcd5c89a
PE
13287 * composite.h, composite.c (composition_gstring_put_cache):
13288 Use EMACS_INT, not int, for length.
13289
b13a45c6
PE
13290 * composite.h (COMPOSITION_DECODE_REFS): New macro,
13291 breaking out part of COMPOSITION_DECODE_RULE.
13292 (COMPOSITION_DECODE_RULE): Use it.
13293 * composite.c (get_composition_id): Remove unused local vars,
13294 by using the new macro.
13295
1e792e4d
PE
13296 * textprop.c (set_text_properties_1): Change while to do-while,
13297 since the condition is always true at first.
13298
dc6c6455 13299 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
13300 (interval_deletion_adjustment): Return unsigned value.
13301 All uses changed.
dc6c6455 13302
aba7731a
PE
13303 * process.c (list_processes_1, create_pty, read_process_output):
13304 (exec_sentinel): Remove vars that were set but not used.
afd4052b 13305 (create_pty): Remove unnecessary "volatile"s.
bc57d757 13306 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 13307 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 13308 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 13309
fdfc4bf3
PE
13310 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
13311
fca8fe46 13312 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 13313 (update_syntax_table): Use unsigned instead of int.
fca8fe46 13314
06a0259a 13315 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 13316 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 13317 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 13318
e7b9e80f
PE
13319 * print.c (print_error_message): Avoid int overflow.
13320
56201685
PE
13321 * font.c (font_list_entities): Redo for clarity,
13322 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
13323
78834453 13324 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 13325 (font_score): Avoid potential overflow in diff calculation.
78834453 13326
0bc0b309 13327 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 13328 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 13329
e610eaca
PE
13330 * eval.c (funcall_lambda): Rename local to avoid shadowing.
13331
b895abce
PE
13332 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
13333 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
13334 can always succeed if overflow has undefined behavior.
13335
1f1d9321 13336 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 13337 (wordify): Omit three unnecessary tests.
1f1d9321 13338
c59478bc
PE
13339 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
13340 All callers changed. This avoids the need for an unused var.
13341
79b73827
PE
13342 * casefiddle.c (casify_region): Remove var that is set but not used.
13343
a4db5dfe
PE
13344 * dired.c (file_name_completion): Remove var that is set but not used.
13345
43aae36e
PE
13346 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
13347
2a47c44d 13348 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 13349 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 13350
a37c69bf
PE
13351 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
13352 Check for integer overflow on size calculations.
13353
328ab8e7
PE
13354 * buffer.c (Fprevious_overlay_change): Remove var that is set
13355 but not used.
13356
e5a2a5cb
PE
13357 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
13358 Remove vars that are set but not used.
8d84a6eb 13359 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 13360 (timer_check_2): Mark vars as initialized.
e5a2a5cb 13361
a60e5f68
PE
13362 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
13363
f661cb61 13364 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 13365 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 13366
f0397f5a
PE
13367 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
13368 that are set but not used.
13369
8664db06 13370 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 13371 if XCreateBitmapFromData fails (Bug#8410).
8664db06 13372
6abdaa4a
PE
13373 * xselect.c (x_get_local_selection, x_handle_property_notify):
13374 Remove vars that are set but not used.
13375
0ce7538d 13376 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 13377 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 13378
9ae848fc
PE
13379 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
13380 Remove var that is set but not used.
0b918413
PE
13381 (scroll_bar_windows_size): Now size_t, not int.
13382 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
13383 Check for overflow.
9ae848fc 13384
a5a62657
PE
13385 * xfaces.c (realize_named_face): Remove vars that are set but not used.
13386 (map_tty_color) [!defined MSDOS]: Likewise.
13387
5c5cdd39
PE
13388 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
13389
66ebf983
PE
13390 * coding.c: Remove vars that are set but not used.
13391 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
13392 All callers changed.
13393 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
13394 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
13395 (decode_coding_charset): Remove vars that are set but not used.
13396
1be4d761
PE
13397 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
13398 that is set but not used.
13399
47553fa8
PE
13400 * print.c (print_object): Remove var that is set but not used.
13401
1f7196bf 13402 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
13403 The gnulib version avoids calling malloc in the usual case,
13404 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
13405 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
13406 * filelock.c (current_lock_owner): Likewise.
13407 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
13408 * sysdep.c: Include allocator.h, careadlinkat.h.
13409 (emacs_no_realloc_allocator): New static constant.
13410 (emacs_readlink): New function.
fdb61804
PE
13411 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
13412 ../lib/careadlinkat.h.
d1fdcab7 13413
f84c17c7
SM
134142011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
13415
13416 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
13417 first non-nil return value).
13418
ef3862ad
JD
134192011-04-03 Jan Djärv <jan.h.d@swipnet.se>
13420
13421 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
13422 if not defined (Bug#8403).
13423
376a7006
JB
134242011-04-02 Juanma Barranquero <lekktu@gmail.com>
13425
13426 * xdisp.c (display_count_lines): Remove parameter `start',
13427 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13428 (get_char_face_and_encoding): Remove parameter `multibyte_p',
13429 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13430 (fill_stretch_glyph_string): Remove parameters `row' and `area',
13431 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
13432 and thereabouts. All callers changed.
13433 (get_per_char_metric): Remove parameter `f', unused since
13434 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13435
6ca3801d
JM
134362011-04-02 Jim Meyering <meyering@redhat.com>
13437
13438 do not dereference NULL upon failed strdup
13439 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
13440 (ns_get_family): Likewise.
13441
d8e2b5ba
JB
134422011-04-02 Juanma Barranquero <lekktu@gmail.com>
13443
13444 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
13445
8c74fcbd
JD
134462011-04-02 Jan Djärv <jan.h.d@swipnet.se>
13447
13448 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
13449 later (Bug#8403).
13450
7200d79c
SM
134512011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
13452
03408648 13453 Add lexical binding.
7200d79c 13454
03408648
SM
13455 * window.c (Ftemp_output_buffer_show): New fun.
13456 (Fsave_window_excursion):
13457 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
13458
13459 * lread.c (lisp_file_lexically_bound_p): New function.
13460 (Fload): Bind Qlexical_binding.
13461 (readevalloop): Remove `evalfun' arg.
13462 Bind Qinternal_interpreter_environment.
13463 (Feval_buffer): Bind Qlexical_binding.
13464 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
13465 Mark as dynamic.
13466 (syms_of_lread): Declare `lexical-binding'.
13467
13468 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
13469
13470 * keyboard.c (eval_dyn): New fun.
13471 (menu_item_eval_property): Use it.
ca105506
SM
13472
13473 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 13474
03408648
SM
13475 * fns.c (concat, mapcar1): Accept byte-code-functions.
13476
13477 * eval.c (Fsetq): Handle lexical vars.
13478 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
13479 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
13480 (FletX, Flet): Obey lexical binding.
13481 (Fcommandp): Handle closures.
13482 (Feval): New `lexical' arg.
13483 (eval_sub): New function extracted from Feval. Use it almost
13484 everywhere where Feval was used. Look up vars in lexical env.
13485 Handle closures.
13486 (Ffunctionp): Move from subr.el.
13487 (Ffuncall): Handle closures.
13488 (apply_lambda): Remove `eval_flags'.
13489 (funcall_lambda): Handle closures and new byte-code-functions.
13490 (Fspecial_variable_p): New function.
13491 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
13492 but without exporting it to Lisp.
23aba0ea 13493
23aba0ea 13494 * doc.c (Fdocumentation, store_function_docstring):
03408648 13495 * data.c (Finteractive_form): Handle closures.
23aba0ea 13496
03408648
SM
13497 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
13498 interactive spec.
ba83908c 13499
04f2d78b
CB
13500 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
13501 New byte-codes.
03408648
SM
13502 (exec_byte_code): New function extracted from Fbyte_code to handle new
13503 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 13504
03408648 13505 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 13506
03408648 13507 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 13508
e2abce01
JB
135092011-03-31 Juanma Barranquero <lekktu@gmail.com>
13510
13511 * xdisp.c (redisplay_internal): Fix prototype.
13512
63696a73 135132011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 13514
63696a73 13515 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
13516 (try_scrolling): Use it when setting scroll_limit.
13517 Limit scrolling to 100 screen lines.
63696a73
EZ
13518 (redisplay_window): Even when falling back on "recentering",
13519 position point in the window according to scroll-conservatively,
13520 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
13521
13522 (try_scrolling): When point is above the window, allow searching
13523 as far as scroll_max, or one screenful, to compute vertical
13524 distance from PT to the scroll margin position. This prevents
13525 try_scrolling from unnecessarily failing when
13526 scroll-conservatively is set to a value slightly larger than the
13527 window height. Clean up the case of PT below the margin at bottom
13528 of window: scroll_max can no longer be INT_MAX. When aggressive
13529 scrolling is in use, don't let point enter the opposite scroll
13530 margin as result of the scroll.
13531 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
13532 threshold of 100 lines for never-recentering scrolling.
13533
e4cc2dfc
JB
135342011-03-31 Juanma Barranquero <lekktu@gmail.com>
13535
13536 * dispextern.h (move_it_by_lines):
13537 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
13538 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
13539 (message_log_check_duplicate): Remove parameters `prev_bol' and
13540 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13541 (redisplay_internal): Remove parameter `preserve_echo_area',
13542 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
13543
13544 * indent.c (Fvertical_motion):
13545 * window.c (window_scroll_pixel_based, Frecenter):
13546 Don't pass `need_y_p' to `move_it_by_lines'.
13547
1c470562
SM
135482011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
13549
44f230aa
SM
13550 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
13551 steal a few bits to be more compact.
13552 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
13553 Remove unneeded casts.
13554
1c470562
SM
13555 * bytecode.c (Fbyte_code): CAR and CDR can GC.
13556
888adce9
ZK
135572011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
13558
13559 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
13560 binding" message (bug#7967).
13561
f838ed7b
PE
135622011-03-30 Paul Eggert <eggert@cs.ucla.edu>
13563
77861b95
PE
13564 Fix more problems found by GCC 4.6.0's static checks.
13565
de6dbc14
PE
13566 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
13567 Remove unused local var.
13568
f838ed7b
PE
13569 * editfns.c (Fmessage_box): Remove unused local var.
13570
792c7b2b
PE
13571 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
13572 (note_mode_line_or_margin_highlight, note_mouse_highlight):
13573 Omit unused local vars.
c499e557 13574 * window.c (shrink_windows): Omit unused local var.
b01a1c29 13575 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
13576 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
13577 Omit unused local var.
13578
ba0165e1
PE
13579 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
13580 Don't assume string length fits in int.
32ad8845 13581 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 13582 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 13583
3c59b4c9
PE
13584 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
13585 instead of alloca (Bug#8344).
13586
a3eed478 13587 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 13588 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 13589
eb4d412d
PE
13590 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
13591
1658b401
PE
13592 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
13593 concerns.
13594
13595 * term.c (produce_glyphless_glyph): Remove unnecessary test.
13596
13597 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 13598
9a2c6e05
PE
13599 * keyboard.c (syms_of_keyboard): Use the same style as later
13600 in this function when indexing through an array. This also
13601 works around GCC bug 48267.
13602
03d0a109
PE
13603 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
13604
44f730c8
PE
13605 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
13606
fe75f926
PE
13607 * chartab.c (sub_char_table_ref_and_range): Redo for slight
13608 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
13609
ffa8c828
PE
13610 * keyboard.c, keyboard.h (num_input_events): Now size_t.
13611 This avoids undefined behavior on integer overflow, and is a bit
13612 more convenient anyway since it is compared to a size_t variable.
13613
c5101a77
PE
13614 Variadic C functions now count arguments with size_t, not int.
13615 This avoids an unnecessary limitation on 64-bit machines, which
13616 caused (substring ...) to crash on large vectors (Bug#8344).
13617 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
13618 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 13619 All variadic functions and their callers changed accordingly.
c5101a77
PE
13620 (struct gcpro.nvars): Now size_t, not int. All uses changed.
13621 * data.c (arith_driver, float_arith_driver): Likewise.
13622 * editfns.c (general_insert_function): Likewise.
13623 * eval.c (struct backtrace.nargs, interactive_p)
13624 (internal_condition_case_n, run_hook_with_args, apply_lambda)
13625 (funcall_lambda, mark_backtrace): Likewise.
13626 * fns.c (concat): Likewise.
13627 * frame.c (x_set_frame_parameters): Likewise.
13628 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
13629 0 if not found, not -1. All callers changed.
13630
dd3f25f7
PE
13631 * alloc.c (garbage_collect): Don't assume stack size fits in int.
13632 (stack_copy_size): Now size_t, not int.
13633 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
13634
461c2ab9
JB
136352011-03-28 Juanma Barranquero <lekktu@gmail.com>
13636
13637 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
13638 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13639 All callers changed.
13640
13641 * lisp.h (multibyte_char_to_unibyte):
13642 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
13643 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13644 * character.h (CHAR_TO_BYTE8):
13645 * cmds.c (internal_self_insert):
13646 * editfns.c (general_insert_function):
13647 * keymap.c (push_key_description):
13648 * search.c (Freplace_match):
13649 * xdisp.c (message_dolog, set_message_1): All callers changed.
13650
f6d62986
SM
136512011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
13652
13653 * keyboard.c (safe_run_hook_funcall): New function.
13654 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
13655 don't set the hook to nil, but remove the offending function instead.
13656 (Qcommand_hook_internal): Remove, unused.
13657 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
13658 Vcommand_hook_internal.
13659
13660 * eval.c (enum run_hooks_condition): Remove.
13661 (funcall_nil, funcall_not): New functions.
13662 (run_hook_with_args): Call each function through a `funcall' argument.
13663 Remove `cond' argument, now redundant.
13664 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
13665 (Frun_hook_with_args_until_failure): Adjust accordingly.
13666 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
13667
1db5b1ad
JB
136682011-03-28 Juanma Barranquero <lekktu@gmail.com>
13669
13670 * dispextern.h (string_buffer_position): Remove declaration.
13671
13672 * print.c (strout): Remove parameter `multibyte', unused since
13673 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
13674
13675 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
13676 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
13677 All callers changed.
13678
13679 * w32.c (_wsa_errlist): Use braces for struct initializers.
13680
13681 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
13682 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
13683 All callers changed.
13684 (string_buffer_position): Likewise. Also, make static (it's never
13685 used outside xdisp.c).
13686 (cursor_row_p): Remove parameter `w', unused since
13687 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
13688 (decode_mode_spec): Remove parameter `precision', introduced during
13689 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
13690 All callers changed.
13691
5ffb62aa
JD
136922011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13693
13694 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
13695
461c2ab9 136962011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
13697
13698 * nsterm.m (ns_menu_bar_is_hidden): New variable.
13699 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
13700 (ns_update_auto_hide_menu_bar): New functions.
13701 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
13702 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
13703 ns_constrain_all_frames.
13704 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
13705 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
13706
5c380ffb
JD
137072011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13708
13709 * nsmenu.m (runDialogAt): Remove argument to timer_check.
13710
9af30bdf
GM
137112011-03-27 Glenn Morris <rgm@gnu.org>
13712
13713 * syssignal.h: Replace RETSIGTYPE with void.
13714 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
13715 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
13716 Replace SIGTYPE with void everywhere.
13717 * s/usg5-4-common.h (SIGTYPE): Remove definition.
13718 * s/template.h (SIGTYPE): Remove commented out definition.
13719
e2abce01
JB
137202011-03-26 Eli Zaretskii <eliz@gnu.org>
13721
13722 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
13723 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
13724
f868cd8a
JB
137252011-03-26 Juanma Barranquero <lekktu@gmail.com>
13726
59eb0929
JB
13727 * w32.c (read_unc_volume): Use parameter `henum', instead of
13728 global variable `wget_enum_handle'.
13729
13730 * keymap.c (describe_vector): Remove parameters `indices' and
13731 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
13732 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
13733
f868cd8a
JB
13734 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
13735
13736 * keyboard.c (timer_check): Remove parameter `do_it_now',
13737 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
13738 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
13739 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
13740
13741 * keyboard.c (read_char):
13742 * w32menu.c (w32_menu_display_help):
13743 * xmenu.c (show_help_event, menu_help_callback):
13744 Adjust calls to `show_help_echo'.
13745
13746 * gtkutil.c (xg_maybe_add_timer):
13747 * keyboard.c (readable_events):
13748 * process.c (wait_reading_process_output):
13749 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
13750
13751 * insdel.c (adjust_markers_gap_motion):
13752 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
13753 (gap_left, gap_right): Don't call it.
13754
2ecf6fdb
CY
137552011-03-25 Chong Yidong <cyd@stupidchicken.com>
13756
13757 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
13758 incurred during fontification.
13759
6b1f9ba4
JB
137602011-03-25 Juanma Barranquero <lekktu@gmail.com>
13761
13762 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
13763 (DEFVAR_PER_BUFFER): Don't pass it.
13764
13765 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
13766 (scrolling_window): Don't pass it.
13767
0f4a96b5
JB
137682011-03-25 Juanma Barranquero <lekktu@gmail.com>
13769
13770 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
13771
13772 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
13773 and `suffix'.
13774 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
13775 of variables specific to SELinux and computation of `encoded_absname'.
13776
13777 * image.c (XPutPixel): Remove unused variable `height'.
13778
13779 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
13780
13781 * unexw32.c (get_section_info): Remove unused variable `section'.
13782
13783 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
13784 (system_process_attributes): Remove unused variable `sess'.
13785 (sys_read): Remove unused variable `err'.
13786
13787 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
13788 (w32_wnd_proc): Remove unused variable `isdead'.
13789 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
13790 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
13791 (x_create_tip_frame): Remove unused variable `tem'.
13792
13793 * w32inevt.c (w32_console_read_socket):
13794 Remove unused variable `no_events'.
13795
13796 * w32term.c (x_draw_composite_glyph_string_foreground):
13797 Remove unused variable `width'.
13798
1149507c
JB
137992011-03-24 Juanma Barranquero <lekktu@gmail.com>
13800
13801 * w32term.c (x_set_glyph_string_clipping):
13802 Don't pass uninitialized region to CombineRgn.
13803
9c88f339
JB
138042011-03-23 Juanma Barranquero <lekktu@gmail.com>
13805
13806 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
13807 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
13808 (Fx_close_connection): Remove unused variable `i'.
13809
13810 * w32font.c (w32font_draw): Return number of glyphs.
13811 (w32font_open_internal): Remove unused variable `i'.
13812 (w32font_driver): Add missing initializer.
13813
13814 * w32menu.c (utf8to16): Remove unused variable `utf16'.
13815 (fill_in_menu): Remove unused variable `items_added'.
13816
13817 * w32term.c (last_mouse_press_frame): Remove static global variable.
13818 (w32_clip_to_row): Remove unused variable `f'.
13819 (x_delete_terminal): Remove unused variable `i'.
13820
13821 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
13822 (NOTHING): Remove unused static global variable.
13823 (uniscribe_check_otf): Remove unused variable `table'.
13824 (uniscribe_font_driver): Add missing initializers.
13825
dee091a3
JD
138262011-03-23 Julien Danjou <julien@danjou.info>
13827
13828 * term.c (Fsuspend_tty, Fresume_tty):
13829 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
13830 * window.c (temp_output_buffer_show):
13831 * insdel.c (signal_before_change):
13832 * frame.c (Fhandle_switch_frame):
13833 * fileio.c (Fdo_auto_save):
13834 * emacs.c (Fkill_emacs):
13835 * editfns.c (save_excursion_restore):
13836 * cmds.c (internal_self_insert):
13837 * callint.c (Fcall_interactively):
13838 * buffer.c (Fkill_all_local_variables):
13839 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
13840 Use Frun_hooks.
0f4a96b5 13841 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 13842 unconditionally since it does the check itself.
dee091a3 13843
2c520ab5 138442011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 13845
c9c49752
PE
13846 Fix more problems found by GCC 4.5.2's static checks.
13847
8abc3f12
PE
13848 * coding.c (encode_coding_raw_text): Avoid unnecessary test
13849 the first time through the loop, since we know p0 < p1 then.
13850 This also avoids a gcc -Wstrict-overflow warning.
13851
a2d26660
PE
13852 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
13853 leading to a memory leak, possible in functions like
13854 load_charset_map_from_file that can allocate an unbounded number
b12ef411 13855 of objects (Bug#8318).
a2d26660 13856
916c72e9
PE
13857 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
13858 that could (at least in theory) be that large.
13859
19ab8a18
PE
13860 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
13861 This is less likely to overflow, and avoids undefined behavior if
13862 overflow does occur. All callers changed. Use strtoul to scan
13863 for the unsigned long integer.
b7cbbd6f
PE
13864 (pint2hrstr): Simplify and tune code slightly.
13865 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 13866
f0641eff
PE
13867 * scroll.c (do_scrolling): Work around GCC bug 48228.
13868 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
13869
7f650bb9
PE
13870 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
13871 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
13872 (validate_x_resource_name): Simplify count usage.
13873 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 13874
37dd57d1
PE
13875 * fileio.c (Fcopy_file): Report error if fchown or fchmod
13876 fail (Bug#8306).
81e56e61 13877
699979fc 13878 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 13879
401bf9b4
PE
13880 * process.c (Fmake_network_process): Use socklen_t, not int,
13881 where POSIX says socklen_t is required in portable programs.
13882 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 13883 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
13884 (Fmake_network_process, server_accept_connection):
13885 (wait_reading_process_output, read_process_output):
13886 Likewise.
13887
b93aacde
PE
13888 * process.c: Rename or move locals to avoid shadowing.
13889 (list_processes_1, Fmake_network_process):
13890 (read_process_output_error_handler, exec_sentinel_error_handler):
13891 Rename or move locals.
4dc343ee 13892 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 13893 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 13894 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 13895 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 13896 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 13897
af8a867c 13898 Make tparam.h and terminfo.c consistent.
44f230aa
SM
13899 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
13900 Include tparam.h instead, since it declares them.
af8a867c
PE
13901 * cm.h (PC): Remove extern decl; tparam.h now does this.
13902 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
13903 * terminfo.c: Include tparam.h, to check interfaces.
13904 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
13905 (tparam): Adjust signature to match interface in tparam.h;
13906 this removes some undefined behavior. Check that outstring and len
13907 are zero, which they always are with Emacs.
13908 * tparam.h (PC, BC, UP): New extern decls.
13909
0248044d 13910 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 13911 (xftfont_open): Rename locals to avoid shadowing.
0248044d 13912
8ff096c1 13913 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
13914 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
13915 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 13916 (ftfont_list): Remove unused local.
49eaafba
PE
13917 (get_adstyle_property, ftfont_pattern_entity):
13918 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
13919 Rename locals to avoid shadowing.
8ff096c1 13920
e2be39f6
PE
13921 * xfont.c (xfont_list_family): Mark var as initialized.
13922
c9735e30
PE
13923 * xml.c (make_dom): Now static.
13924
8f5201ae
PE
13925 * composite.c (composition_compute_stop_pos): Rename local to
13926 avoid shadowing.
b246f932
PE
13927 (composition_reseat_it): Remove unused locals.
13928 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 13929 (composition_update_it): Mark var as initialized.
11b61122
PE
13930 (find_automatic_composition): Mark vars as initialized,
13931 with a FIXME (Bug#8290).
8f5201ae 13932
760fbc2c
PE
13933 character.h: Rename locals to avoid shadowing.
13934 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
13935 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
13936 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
13937 (BUF_DEC_POS): Be more systematic about renaming local temporaries
13938 to avoid shadowing.
13939
ff08eb85
PE
13940 * textprop.c (property_change_between_p): Remove; unused.
13941
fc7bf025
PE
13942 * intervals.c (interval_start_pos): Now static.
13943
235d7abc
PE
13944 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
13945
44f230aa
SM
13946 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
13947 Rename locals to avoid shadowing.
3e7d6594 13948
50060332
PE
13949 * sound.c (wav_play, au_play, Fplay_sound_internal):
13950 Fix pointer signedness.
d01f234b 13951 (alsa_choose_format): Remove unused local var.
c83b8872
PE
13952 (wav_play): Initialize a variable to 0, to prevent undefined
13953 behavior (Bug#8278).
50060332 13954
c4fc4e30
PE
13955 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
13956
918436ed
PE
13957 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
13958
c939f91b
PE
13959 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
13960 clobbering (Bug#8298).
b9c7f648
PE
13961 * sysdep.c (sys_subshell): Likewise.
13962 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 13963
6bd8c144
PE
13964 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
13965 This should get cleaned up, so that child_setup has the
13966 same signature on all platforms.
13967
7710357c 13968 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 13969 (relocate_fd): Rename locals to avoid shadowing.
7710357c 13970
c59da222
CY
139712011-03-22 Chong Yidong <cyd@stupidchicken.com>
13972
13973 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
13974 not to be necessary, and produces flickering.
13975
66b87493
GM
139762011-03-20 Glenn Morris <rgm@gnu.org>
13977
13978 * config.in: Remove file.
13979
45b6f6d5
JB
139802011-03-20 Juanma Barranquero <lekktu@gmail.com>
13981
13982 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
13983 are now in src/globals.h.
13984 (syms_of_minibuf): Remove spurious & from previous change.
13985
cd394be1 139862011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
13987
13988 * minibuf.c (completing-read-function): New variable.
13989 (completing-read-default): Rename from completing-read.
13990 (completing-read): Call completing-read-function.
13991
b14e3e21
CY
139922011-03-19 Juanma Barranquero <lekktu@gmail.com>
13993
13994 * xfaces.c (Fx_load_color_file):
13995 Read color file from absolute filename (bug#8250).
13996
f2b726e6
JB
139972011-03-19 Juanma Barranquero <lekktu@gmail.com>
13998
13999 * makefile.w32-in: Update dependencies.
14000
09f6ff02
EZ
140012011-03-17 Eli Zaretskii <eliz@gnu.org>
14002
14003 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
14004
29a6015a
PE
140052011-03-17 Paul Eggert <eggert@cs.ucla.edu>
14006
a3a6c54e
PE
14007 Fix more problems found by GCC 4.5.2's static checks.
14008
b766f867
PE
14009 * process.c (make_serial_process_unwind, send_process_trap):
14010 (sigchld_handler): Now static.
14011
be02381c
PE
14012 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
14013 That way, the code declares only the vars that it needs.
14014 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
14015 * s/cygwin.h (PTY_ITERATION): Likewise.
14016 * s/darwin.h (PTY_ITERATION): Likewise.
14017 * s/gnu-linux.h (PTY_ITERATION): Likewise.
14018
57048744
PE
14019 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
14020 * process.c (allocate_pty): Don't declare stb unless it's needed.
14021
7914961c 14022 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
14023 (CONSTANTLIM): Remove; unused.
14024 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
14025 Define only if needed.
7914961c 14026
b3967b18
PE
14027 * unexelf.c (unexec): Name an expression,
14028 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
14029 Use a different way to cause a compilation error if anyone uses
14030 n rather than nn, a way that does not involve shadowing.
73366a00 14031 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 14032
29a6015a
PE
14033 * deps.mk (unexalpha.o): Remove; unused.
14034
43cfc33e 14035 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 14036 * unexec.h: New file.
ce701a33
PE
14037 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
14038 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
14039 Depend on unexec.h.
14040 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
14041 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
14042 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 14043 Change as necessary to match prototype in unexec.h.
ce701a33 14044
01f44d5a
PE
14045 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
14046 shadowing.
4f63c6bb 14047 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 14048
a6670b0b
PE
14049 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
14050 Rename locals to avoid shadowing.
14051
cef2010d 14052 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 14053 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 14054
d4d7173a
PE
14055 * print.c (Fredirect_debugging_output): Fix pointer signedess.
14056
f08b802a
PE
14057 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
14058 warning when compiling print.c.
14059
3ddb0639
PE
14060 * font.c (font_unparse_fcname): Abort in an "impossible" situation
14061 instead of using an uninitialized var.
5ad03b97 14062 (font_sort_entities): Mark var as initialized.
3ddb0639 14063
170a2692
PE
14064 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
14065
e663c700
PE
14066 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
14067 pointers to constants.
89bc529a 14068 (font_parse_fcname): Remove unused vars.
7b81e2d0 14069 (font_delete_unmatched): Now static.
ea838e10 14070 (font_get_spec): Remove; unused.
13a547c6
PE
14071 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
14072 (font_update_drivers, Ffont_get_glyphs, font_add_log):
14073 Rename or move locals to avoid shadowing.
e663c700 14074
2a80c887 14075 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 14076 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 14077
1384fa33 14078 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 14079 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 14080
8b2c52e9
PE
14081 * alloc.c (mark_backtrace): Move decl from here ...
14082 * lisp.h: ... to here, so that it can be checked.
14083
475545b5 14084 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 14085 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
14086 (lisp_indirect_variable): Name an expression,
14087 to avoid gcc -Wbad-function-cast warning.
1faed8ae 14088 (Fdefvar): Rename locals to avoid shadowing.
475545b5 14089
b1349114 14090 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 14091 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 14092 Use const pointer when appropriate.
b1349114 14093
a2928364
PE
14094 * lisp.h (get_system_name, get_operating_system_release):
14095 Move decls here, to check interfaces.
14096 * process.c (get_operating_system_release): Move decl to lisp.h.
14097 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
14098 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
14099 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
14100 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
14101 (Fformat_time_string, Fencode_time, Finsert_char):
14102 (Ftranslate_region_internal, Fformat):
14103 Rename or remove local vars to avoid shadowing.
9710023e 14104 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 14105
a415e694
PE
14106 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
14107 avoid shadowing.
14108
8ef4622d
PE
14109 * lisp.h (eassert): Check that the argument compiles, even if
14110 ENABLE_CHECKING is not defined.
14111
946f9a5b
PE
14112 * data.c (Findirect_variable): Name an expression, to avoid
14113 gcc -Wbad-function-cast warning.
112396d6 14114 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 14115 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
14116 (Fmake_variable_buffer_local, Fmake_local_variable):
14117 Mark variables as initialized.
52746918 14118 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 14119
e5aab7e7 14120 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
14121 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
14122 Rename locals to avoid shadowing.
dff45157
PE
14123 (mark_stack): Move local variables into the #ifdef region where
14124 they're used.
7bc26fdb
PE
14125 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
14126 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
14127 needed otherwise.
14128 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
14129 (GC_STRING_CHARS): Remove; not used.
d40d4be1 14130 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 14131
e5aab7e7
PE
14132 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
14133 avoids undefined behavior in theory.
14134
4da60324
PE
14135 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
14136
88043301
PE
14137 Use functions, not macros, for up- and down-casing (Bug#8254).
14138 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14139 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
14140 to use the following functions instead of these macros.
14141 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
14142 EMACS_INT, since callers assume the returned value fits in int.
14143 (upcase1): Likewise, for UPCASE_TABLE.
14144 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 14145 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 14146 the race-condition problem in the old DOWNCASE.
88043301 14147
19ed5445
PE
14148 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
14149 Rename locals to avoid shadowing.
14150 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
14151 (regex_compile, re_search_2, re_match_2_internal):
14152 Remove unused local vars.
952db0d7
PE
14153 (FREE_VAR): Rewrite so as not to use empty "else",
14154 which gcc can warn about.
da053e48 14155 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
14156 (RETALLOC_IF): Define only if needed.
14157 (WORDCHAR_P): Likewise. This one is never needed, but is used
14158 only in a comment talking about a compiler bug, so put inside
14159 the #if 0 of that comment.
14160 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
14161 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
14162 Remove; unused.
19ed5445 14163
1f3561e4 14164 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
14165 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
14166 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 14167
ded6f8f7
PE
14168 * search.c (simple_search): Remove unused var.
14169
dbd37a95
PE
14170 * dired.c (compile_pattern): Move decl from here ...
14171 * lisp.h: ... to here, so that it can be checked.
14172 (struct re_registers): New forward decl.
14173
7e47afad
PE
14174 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
14175
85f24f61
PE
14176 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
14177 All uses changed.
14178 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
14179 Rename locals to avoid shadowing.
5671df8f 14180 (Fvertical_motion): Mark locals as initialized.
85f24f61 14181
181aa2be 14182 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 14183 (casify_region): Mark local as initialized.
181aa2be 14184
930d429c
PE
14185 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
14186
7082eac6
PE
14187 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
14188 New macros, so that the caller can use some names other than
14189 gcpro1, gcpro2, etc.
14190 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
14191 of the new macros.
14192 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
14193 argument, for consistency with GCPRO2_VAR, etc: it is now the
14194 prefix of the variable, not the variable itself. All uses
14195 changed.
38b2c076
PE
14196 * dired.c (directory_files_internal, file_name_completion):
14197 Rename locals to avoid shadowing.
14198
15206ed9
PE
14199 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
14200 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
14201 dired.c's scmp function, had undefined behavior.
14202 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14203 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
14204 * buffer.h: ... to here, because these macros use current_buffer,
14205 and the new implementation with inline functions needs to have
14206 current_buffer in scope now, rather than later when the macros
14207 are used.
14208 (downcase, upcase1): New static inline functions.
14209 (DOWNCASE, UPCASE1): Reimplement using these functions.
14210 This avoids undefined behavior in expressions like
14211 DOWNCASE (x) == DOWNCASE (y), which previously suffered
14212 from race conditions in accessing the global variables
14213 case_temp1 and case_temp2.
14214 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
14215 * lisp.h (case_temp1, case_temp2): Remove their decls.
14216 * character.h (ASCII_CHAR_P): Move from here ...
14217 * lisp.h: ... to here, so that the inline functions mentioned
14218 above can use them.
14219
4a6bea26
PE
14220 * dired.c (directory_files_internal_unwind): Now static.
14221
f14b7e14
PE
14222 * fileio.c (file_name_as_directory, directory_file_name):
14223 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
14224 Now static.
2893f146
PE
14225 (file_name_as_directory): Use const pointers when appropriate.
14226 (Fexpand_file_name): Likewise. In particular, newdir might
14227 point at constant storage, so make it a const pointer.
fd4ead52 14228 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
14229 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
14230 signedness issues.
f839df0c
PE
14231 (Fset_file_times, Finsert_file_contents, auto_save_error):
14232 Rename locals to avoid shadowing.
f14b7e14 14233
5716756e 14234 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
14235 (Ftry_completion, Fall_completions): Rename or remove locals
14236 to avoid shadowing.
5716756e 14237
b4c3046a
PE
14238 * marker.c (bytepos_to_charpos): Remove; unused.
14239
b45db522
PE
14240 * lisp.h (verify_bytepos, count_markers): New decls,
14241 so that gcc does not warn that these functions aren't declared.
14242
85876d07
PE
14243 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
14244 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 14245 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 14246 (copy_text): Remove unused local var.
85876d07 14247
03d78a21 14248 * filelock.c (within_one_second): Now static.
b3dd38ab 14249 (lock_file_1): Rename local to avoid shadowing.
03d78a21 14250
5df8f01b
PE
14251 * buffer.c (fix_overlays_before): Mark locals as initialized.
14252 (fix_start_end_in_overlays): Likewise. This function should be
14253 simplified by using pointers-to-pointers, but that's a different
14254 matter.
b1d876f1 14255 (switch_to_buffer_1): Now static.
8f54f30a
PE
14256 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
14257 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 14258
a70072c9 14259 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 14260 Fix pointer signedness issue.
edced198
PE
14261 (sys_subshell): Mark local as volatile if checking for lint,
14262 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 14263 (MAXPATHLEN): Define only if needed.
a70072c9 14264
a0977c44
PE
14265 * process.c (serial_open, serial_configure): Move decls from here ...
14266 * systty.h: ... to here, so that they can be checked.
14267
a884fdcc
PE
14268 * fns.c (get_random, seed_random): Move extern decls from here ...
14269 * lisp.h: ... to here, so that they can be checked.
14270
604efe86 14271 * sysdep.c (reset_io): Now static.
b8950c94 14272 (wait_for_termination_signal): Remove; unused.
604efe86 14273
38fc62d9
PE
14274 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
14275 (copy_keymap_item, append_key, push_text_char_description):
14276 Now static.
1004a21a 14277 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 14278 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
14279 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
14280 (describe_map_tree):
14281 Rename locals to avoid shadowing.
38fc62d9 14282
2f2650da
PE
14283 * keyboard.c: Declare functions static if they are not used elsewhere.
14284 (echo_char, echo_dash, cmd_error, top_level_2):
14285 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
14286 (read_char, kbd_buffer_get_event, make_lispy_position):
14287 (make_lispy_event, make_lispy_movement, apply_modifiers):
14288 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
14289 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
14290 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 14291 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 14292 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 14293
a053e86c 14294 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
14295 (mark_kboards): Move decl here ...
14296 * alloc.c (mark_kboards): ... from here.
a053e86c 14297
4752793e
PE
14298 * lisp.h (force_auto_save_soon): New decl.
14299
74f10ca7 14300 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
14301 (DEFINE_DUMMY_FUNCTION): New macro.
14302 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
14303 Use it.
c03cd23f
PE
14304 (main): Add casts to avoid warnings
14305 if GCC considers string literals to be constants.
74f10ca7 14306
022e70d4
PE
14307 * lisp.h (fatal_error_signal): Add decl, since it's exported.
14308
59d6fe83
PE
14309 * dbusbind.c: Pointer signedness fixes.
14310 (xd_signature, xd_append_arg, xd_initialize):
14311 (Fdbus_call_method, Fdbus_call_method_asynchronously):
14312 (Fdbus_method_return_internal, Fdbus_method_error_internal):
14313 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
14314 (Fdbus_register_signal): Use SSDATA when the context wants char *.
14315
78320123
PE
14316 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
14317 if GCC considers string literals to be constants.
49cebcca 14318 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 14319
35ac2a97
SM
143202011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
14321
fb103ca9
SM
14322 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
14323 (print_preprocess, print_object): New macro to fix last change.
14324
35ac2a97
SM
14325 * print.c (print_preprocess): Don't forget font objects.
14326
62973b41
JB
143272011-03-16 Juanma Barranquero <lekktu@gmail.com>
14328
14329 * emacs.c (USAGE3): Doc fixes.
14330
0e48bb22
AS
143312011-03-15 Andreas Schwab <schwab@linux-m68k.org>
14332
14333 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
14334 structure.
14335
7684e57b
JB
143362011-03-14 Juanma Barranquero <lekktu@gmail.com>
14337
14338 * lisp.h (VWindow_system, Qfile_name_history):
14339 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
14340 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
14341 (w32_system_caret_x, w32_system_caret_y): Declare extern.
14342
14343 * w32select.c: Don't #include "keyboard.h".
c96bbc66 14344 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
14345
14346 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
14347 * w32console.c (detect_input_pending, read_input_pending)
14348 (encode_terminal_code):
14349 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
14350 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
14351 (w32_system_caret_y, Qfile_name_history):
14352 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
14353 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
14354 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
14355 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
14356 * w32proc.c (Qlocal, report_file_error):
14357 * w32term.c (Vwindow_system, updating_frame):
14358 * w32uniscribe.c (initialized, uniscribe_font_driver):
14359 Remove unneeded extern declarations.
14360
2aa46d6c
CY
143612011-03-14 Chong Yidong <cyd@stupidchicken.com>
14362
c96bbc66 14363 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 14364
cffc6f3b
CY
143652011-03-13 Chong Yidong <cyd@stupidchicken.com>
14366
14367 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
14368 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
14369 These macros can no longer be used for assignment.
14370
44f230aa
SM
14371 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
14372 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
14373 (record_buffer_markers, fetch_buffer_markers): New functions for
14374 recording and fetching special buffer markers.
14375 (set_buffer_internal_1, set_buffer_temp): Use them.
14376
14377 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
14378
14379 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
14380
14381 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
14382 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
14383
14384 * xdisp.c (hscroll_window_tree):
14385 (reconsider_clip_changes): Use PT instead of BUF_PT.
14386
d251f04b
EZ
143872011-03-13 Eli Zaretskii <eliz@gnu.org>
14388
14389 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
14390 $(EMACS_ROOT)/lib/intprops.h.
14391
f0c77cd1
PE
143922011-03-13 Paul Eggert <eggert@cs.ucla.edu>
14393
3eca4629
PE
14394 Fix more problems found by GCC 4.5.2's static checks.
14395
7c86ee98
PE
14396 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
14397 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
14398 (xg_free_frame_widgets): Make it clear that a local variable is
14399 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
14400 (gdk_window_get_screen): Make it clear that this macro is needed
14401 only if USE_GTK_TOOLTIP.
1e5524e7
PE
14402 (int_gtk_range_get_value): New function, which avoids a diagnostic
14403 from gcc -Wbad-function-cast.
14404 (xg_set_toolkit_scroll_bar_thumb): Use it.
14405 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
14406 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
14407 (get_utf8_string, xg_get_file_with_chooser):
14408 Rename locals to avoid shadowing.
14409 (create_dialog): Move locals to avoid shadowing.
7c86ee98 14410
41729b81
PE
14411 * xgselect.c (xg_select): Remove unused var.
14412
f0c77cd1
PE
14413 * image.c (four_corners_best): Mark locals as initialized.
14414 (gif_load): Initialize transparent_p to zero (Bug#8238).
14415 Mark another local as initialized.
ec6cf4c6 14416 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 14417
ce0ad53d 14418 * image.c (clear_image_cache): Now static.
d5d5a617 14419 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 14420 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
14421 (x_edge_detection): Remove unnecessary cast that
14422 gcc -Wbad-function-cast diagnoses.
2037898d 14423 (gif_load): Fix pointer signedness.
6ae141d6
PE
14424 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
14425 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 14426
33383987 144272011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 14428
d32df629
PE
14429 Improve quality of tests for time stamp overflow.
14430 For example, without this patch (encode-time 0 0 0 1 1
14431 1152921504606846976) returns the obviously-bogus value (-948597
14432 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
14433 reports time overflow. See
14434 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
14435 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
14436 * editfns.c: Include limits.h and intprops.h.
14437 (TIME_T_MIN, TIME_T_MAX): New macros.
14438 (time_overflow): Move earlier, to before first use.
14439 (hi_time, lo_time): New functions, for an accurate test for
14440 out-of-range times.
14441 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
14442 (Fget_internal_run_time): Don't assume time_t fits in int.
14443 (make_time): Use list2 instead of Fcons twice.
14444 (Fdecode_time): More accurate test for out-of-range times.
14445 (check_tm_member): New function.
14446 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
14447 (lisp_time_argument): Don't rely on undefined left-shift and
14448 right-shift behavior when checking for time stamp overflow.
8be6f318 14449
fe31d94c
PE
14450 * editfns.c (time_overflow): New function, refactoring common code.
14451 (Fformat_time_string, Fdecode_time, Fencode_time):
14452 (Fcurrent_time_string): Use it.
14453
8be6f318
PE
14454 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
14455 * dired.c (make_time): Move to ...
14456 * editfns.c (make_time): ... here.
14457 * systime.h: Note the move.
14458
09d9db2c 144592011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 14460
126bc0dc
YM
14461 * fringe.c (update_window_fringes): Remove unused variables.
14462
c47cbdfd
YM
14463 * unexmacosx.c (copy_data_segment): Also copy __got section.
14464 (Bug#8223)
14465
7ac80be9
EZ
144662011-03-12 Eli Zaretskii <eliz@gnu.org>
14467
c96bbc66 14468 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
14469 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
14470 Constify `char *' arguments and their references according to
14471 prototypes in tparam.h.
14472
ecb0f94d 14473 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 14474
7ac80be9
EZ
14475 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
14476 Adapt all references accordingly.
14477
14478 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
14479
ef1fd07e
TT
144802011-03-11 Tom Tromey <tromey@redhat.com>
14481
14482 * buffer.c (syms_of_buffer): Remove obsolete comment.
14483
7ef4b50c
EZ
144842011-03-11 Eli Zaretskii <eliz@gnu.org>
14485
14486 * termhooks.h (encode_terminal_code): Declare prototype.
14487
14488 * msdos.c (encode_terminal_code): Don't declare prototype.
14489
14490 * term.c (encode_terminal_code): Now external again, used by
14491 w32console.c and msdos.c.
14492
44f230aa
SM
14493 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
14494 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 14495
4b1ec863 144962011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 14497
1714f52b 14498 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 14499
4b1ec863
PE
14500 * fringe.c (update_window_fringes): Mark locals as initialized
14501 (Bug#8227).
14502 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 14503
524c7aa6
PE
14504 * alloc.c (mark_fringe_data): Move decl from here ...
14505 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
14506 to check its interface.
14507 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
14508
a5c0af81 14509 * fontset.c (free_realized_fontset): Now static.
7519b8cd 14510 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 14511 (fontset_font): Mark local as initialized.
a9a06e0b 14512 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 14513
b4716021
PE
14514 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
14515
811e9bac 14516 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 14517 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
14518 (x_own_selection, Fx_disown_selection_internal): Rename locals
14519 to avoid shadowing.
14520 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 14521
7e3ab302
PE
14522 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
14523 so that the caller can use some name other than gcpro1.
14524 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
14525 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14526 (Fx_backspace_delete_keys_p):
14527 Use them to avoid shadowing, and rename vars to avoid shadowing.
14528 (x_decode_color, x_set_name, x_window): Now static.
6b437900 14529 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 14530 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
14531 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
14532 Remove unused locals.
7e3ab302
PE
14533 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14534 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
14535 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
14536 macros.
f78faa98 14537
e2b13473
PE
14538 * xterm.h (x_mouse_leave): New decl.
14539
77f23912
PE
14540 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
14541 Remove unused functions.
cdf4ba58
PE
14542 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
14543 (x_calc_absolute_position): Now static.
7411c686 14544 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 14545 Don't declare local "event" unless it's used.
ed7bf3a5
PE
14546 (x_iconify_frame, x_free_frame_resources): Don't declare locals
14547 unless they are used.
38d0b34a
PE
14548 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
14549 (x_fatal_error_signal): Remove; not used.
a6067996
PE
14550 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
14551 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
14552 (x_error_catcher, x_connection_closed, x_error_handler):
14553 (x_error_quitter, xembed_send_message, x_iconify_frame):
14554 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 14555 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 14556 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 14557
44f230aa
SM
14558 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
14559 Rename or move locals to avoid shadowing.
6b463e58 14560 (tty_defined_color, merge_face_heights): Now static.
5967d051 14561 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
14562 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
14563 does not deduce is never used uninitialized.
73719eba
PE
14564 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
14565 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 14566
426994c3 14567 * terminal.c (store_terminal_param): Now static.
5489860b 14568
032f1620 14569 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 14570 (set_frame_menubar): Remove unused local.
d4323972 14571 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
14572 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
14573 since they might point to immutable storage.
281585b0
PE
14574 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
14575 since it's unused otherwise.
032f1620 14576
367c19e5 14577 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 14578 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
14579 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
14580 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 14581 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
14582 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
14583 does not deduce are never used uninitialized.
70739cbe 14584
07b48fa9
PE
14585 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
14586
8868a238 14587 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
14588 * window.c (window_loop, size_window):
14589 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 14590
7e5cf297 14591 * window.c (display_buffer): Now static.
d6550a9f
PE
14592 (size_window): Mark variables that gcc -Wuninitialized
14593 does not deduce are never used uninitialized.
a586633d
PE
14594 * window.h (check_all_windows): New decl, to forestall
14595 gcc -Wmissing-prototypes diagnostic.
5b555da1 14596 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 14597
f6095868
PE
14598 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
14599 shadowing.
14600 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
14601 Include <limits.h>.
14602 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
14603 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
14604 (load_charset_map): Mark variables that gcc -Wuninitialized
14605 does not deduce are never used uninitialized.
53df7c11 14606 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 14607
f38b440c
PE
14608 * coding.c (coding_set_source, coding_set_destination):
14609 Use "else { /* comment */ }" rather than "else /* comment */;"
14610 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
14611 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
14612 a block, when the outer 'i' will do.
14613 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
14614 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
14615 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
14616 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
14617 (Fdecode_sjis_char, Fdefine_coding_system_internal):
14618 Rename locals to avoid shadowing.
14619 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
14620 * coding.c (emacs_mule_char, encode_invocation_designation):
14621 Now static, since they're not used elsewhere.
413bb2db 14622 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 14623 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
14624 (decode_coding_emacs_mule): Mark variables that gcc
14625 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
14626 (detect_coding_iso_2022): Initialize a local variable that might
14627 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 14628 this initialization is needed. (Bug#8211)
5f58e762
PE
14629 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
14630 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
14631 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
14632 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
14633 Remove unused macros.
f38b440c 14634
232b38b9 14635 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 14636 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 14637 * character.c (string_count_byte8): Likewise.
232b38b9 14638
fb90da1b
PE
14639 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
14640 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
14641
fb93dbc2
PE
14642 * chartab.c (copy_sub_char_table): Now static, since it's not used
14643 elsewhere.
5c156ace
PE
14644 (sub_char_table_ref_and_range, char_table_ref_and_range):
14645 Rename locals to avoid shadowing.
bbcd0949 14646 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 14647
7d3b3862 14648 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 14649 (BIDI_BOB): Remove unused macro.
7d3b3862 14650
6be7d3da
PE
14651 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
14652 deduce are never used uninitialized.
c2ed9c8b 14653 * term.c (encode_terminal_code): Likewise.
6be7d3da 14654
75f8807f 14655 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 14656
50938595
PE
14657 * tparam.h: New file.
14658 * term.c, tparam.h: Include it.
14659 * deps.mk (term.o, tparam.o): Depend on tparam.h.
14660 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
14661 Move these decls to tparam.h, and make them agree with what
14662 is actually in tparam.c. The previous trick of using incompatible
14663 decls in different modules does not conform to the C standard.
14664 All callers of tparam changed to use tparam's actual API.
14665 * tparam.c (tparam1, tparam, tgoto):
14666 Use const pointers where appropriate.
14667
fbceeba2
PE
14668 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
14669 * cm.h (struct cm): Likewise.
14670 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
14671 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
14672 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
14673 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
14674 (turn_on_face, init_tty): Likewise.
14675 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 14676
7f3f1250
PE
14677 * term.c (term_mouse_position): Rename local to avoid shadowing.
14678
e6ca6543
PE
14679 * alloc.c (mark_ttys): Move decl from here ...
14680 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
14681
c40f8d15
AS
146822011-03-11 Andreas Schwab <schwab@linux-m68k.org>
14683
14684 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
14685
cfe0661d
JB
146862011-03-09 Juanma Barranquero <lekktu@gmail.com>
14687
14688 * search.c (compile_pattern_1): Remove argument regp, unused since
14689 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
14690 (compile_pattern): Don't pass it.
14691
0afb4571
J
146922011-03-08 Jan Djärv <jan.h.d@swipnet.se>
14693
14694 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
14695 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
14696 for ! HAVE_GTK3.
14697 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
14698
14699 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
14700
14701 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
14702 gdk_window_get_screen, gdk_window_get_geometry,
14703 gdk_x11_window_lookup_for_display and GDK_KEY_g.
14704 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
14705 (xg_get_pixbuf_from_pixmap): New function.
14706 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
14707 to Pixmap, take frame as parameter, remove GdkColormap parameter.
14708 Call xg_get_pixbuf_from_pixmap instead of
14709 gdk_pixbuf_get_from_drawable.
14710 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
14711 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
14712 (xg_check_special_colors): Use GtkStyleContext and its functions
14713 for HAVE_GTK3.
14714 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
14715 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
14716 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
14717 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
14718 Call gtk_widget_get_preferred_size.
0afb4571
J
14719 (xg_frame_resized): gdk_window_get_geometry only takes 5
14720 parameters.
44f230aa
SM
14721 (xg_win_to_widget, xg_event_is_for_menubar):
14722 Call gdk_x11_window_lookup_for_display.
0afb4571
J
14723 (xg_set_widget_bg): New function.
14724 (delete_cb): New function.
895009e1 14725 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 14726 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
14727 (xg_set_background_color): Call xg_set_widget_bg.
14728 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
14729 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
14730 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
14731 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
14732 if ! HAVE_GTK3.
14733 (update_frame_tool_bar): Call gtk_widget_hide.
14734 (xg_initialize): Use GDK_KEY_g.
14735
14736 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
14737 if ! HAVE_GTK3
14738 (x_session_initialize): Call gdk_x11_set_sm_client_id.
14739
14740 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
14741 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
14742 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
14743
1c2cc4ef
JB
147442011-03-08 Juanma Barranquero <lekktu@gmail.com>
14745
14746 * w32xfns.c (select_palette): Check success of RealizePalette against
14747 GDI_ERROR, not zero.
14748
33383987 14749See ChangeLog.11 for earlier changes.
aac0c6e3
MR
14750
14751;; Local Variables:
14752;; coding: utf-8
aac0c6e3
MR
14753;; End:
14754
2f097256 14755 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
14756
14757 This file is part of GNU Emacs.
14758
14759 GNU Emacs is free software: you can redistribute it and/or modify
14760 it under the terms of the GNU General Public License as published by
14761 the Free Software Foundation, either version 3 of the License, or
14762 (at your option) any later version.
14763
14764 GNU Emacs is distributed in the hope that it will be useful,
14765 but WITHOUT ANY WARRANTY; without even the implied warranty of
14766 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14767 GNU General Public License for more details.
14768
14769 You should have received a copy of the GNU General Public License
14770 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.