Document trash changes in manual.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
dca4927e
EZ
12011-08-27 Eli Zaretskii <eliz@gnu.org>
2
3 * xdisp.c (move_it_to): Don't bail out early when reaching
4 position beyond to_charpos, if we are scanning backwards.
5 (move_it_vertically_backward): When DY == 0, make sure we get to
6 the first character in the line after the newline.
7
f2cad773
PE
82011-08-27 Paul Eggert <eggert@cs.ucla.edu>
9
10 * ccl.c: Improve and simplify overflow checking (Bug#9196).
11 (ccl_driver): Do not generate an out-of-range pointer.
12 (Fccl_execute_on_string): Remove unnecessary check for
13 integer overflow, noted by Stefan Monnier in
14 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
15 Remove a FIXME that didn't need fixing.
16 Simplify the newly-introduced buffer reallocation code.
17
0cae2cdb
JB
182011-08-27 Juanma Barranquero <lekktu@gmail.com>
19
20 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
21
5fc295a4 222011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 23
70c60eb2 24 Integer and memory overflow issues (Bug#9196).
726e0ab1 25
d31850da
PE
26 * doc.c (get_doc_string): Rework so that
27 get_doc_string_buffer_size is the actual buffer size, rather than
28 being 1 less than the actual buffer size; this makes xpalloc more
29 convenient.
30
a69fbedb
PE
31 * image.c (x_allocate_bitmap_record, cache_image):
32 * xselect.c (Fx_register_dnd_atom):
33 Simplify previous changes by using xpalloc.
34
fe5c5d37
PE
35 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
36 since either will do and ptrdiff_t is convenient with xpalloc.
37
0065d054
PE
38 * charset.c (charset_table_size)
39 (struct charset_sort_data.priority): Now ptrdiff_t.
40 (charset_compare): Don't overflow if priorities differ greatly.
41 (Fsort_charsets): Don't assume list length fits in int.
42 Check for size-calculation overflow when allocating sort data.
43 (syms_of_charset): Allocate an initial charset table that is
44 just under 64 KiB, to avoid problems with glibc malloc and mmap.
45
46 * cmds.c (internal_self_insert): Check for size-calculation overflow.
47
48 * composite.h (struct composition.glyph_len): Now int, not unsigned.
49 The actual value is always <= INT_MAX, and leaving it unsigned made
50 overflow checking harder.
51
52 * dispextern.h (struct glyph_matrix.rows_allocated)
53 (struct face_cache.size): Now ptrdiff_t, for convenience in use
54 with xpalloc. The values are still always <= INT_MAX.
55
56 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
57
58 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
59 (SAFE_NALLOCA): New macro.
60
61 * region-cache.c (struct boundary.pos, find_cache_boundary)
62 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
63 (set_cache_region, invalidate_region_cache)
64 (revalidate_region_cache, know_region_cache, region_cache_forward)
65 (region_cache_backward, pp_cache):
66 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
67 so that ptrdiff_t * can be passed to xpalloc.
68 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
69 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
70 (pp_cache): Don't assume cache_len fits in int.
71 * region-cache.h: Adjust extern decls to match.
72
73 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
74 EMACS_INT, since either will do, for xpalloc.
75
76 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
77 (xnmalloc, xnrealloc, xpalloc): New functions.
78
726e0ab1
PE
79 * bidi.c (bidi_shelve_header_size): New constant.
80 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
81 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
82
51f30bc5 83 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
84 * buffer.c (overlays_at, overlays_in, record_overlay_string)
85 (overlay_strings):
86 Don't update size of array until after memory allocation succeeds,
87 because xmalloc/xrealloc may not return.
0065d054
PE
88 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
89 now that we have proper integer overflow checking.
90 (record_overlay_string, overlay_strings): Catch overflows when
91 calculating size of overlay_str_buf.
726e0ab1 92
0065d054
PE
93 * callproc.c (Fcall_process): Check for size overflow when
94 calculating size of args2.
95 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
96 Normally we prefer signed values, but sticking with ptrdiff_t would
97 require adding more-complicated checks.
726e0ab1
PE
98
99 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
100 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
101 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 102 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
103
104 * character.c (Fstring): Check for size-calculation overflow.
105
106 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
107 unnecessary integer overflow. Check for size overflow.
108 (encode_coding_object): Don't update size until xmalloc succeeds.
109
110 * composite.c (get_composition_id): Check for overflow in glyph
111 length calculations.
112
113 Integer and memory overflow fixes for display code.
114 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
115 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
116 (scrolling_window): Check for overflow in size calculations.
117 (line_draw_cost, realloc_glyph_pool, add_row_entry):
118 Don't assume glyph table len fits in int.
119 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
120 (row_table_size): Now ptrdiff_t, not int.
121 (scrolling_window): Avoid overflow in size calculations.
122 Don't update size until allocation succeeds.
123 * fns.c (concat): Check for overflow in size calculations.
124 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
125 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
126 (NEXT_ALMOST_PRIME_LIMIT): New constant.
127
128 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
129 (get_doc_string): Check for size calculation overflow.
130 Don't update size until allocation succeeds.
131 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
132 EMACS_INT, where ptrdiff_t will do.
133 (Fsubstitute_command_keys): Check for string overflow.
134
135 * editfns.c (set_time_zone_rule): Don't assume environment length
136 fits in int.
137 (message_length): Now ptrdiff_t, not int.
138 (Fmessage_box): Don't update size until allocation succeeds.
139 Don't assume message length fits in int.
140 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
141
0065d054
PE
142 * emacs.c (main): Do not reallocate argv, since there is a null at
143 the end that can be overwritten, and this way there's no need to
144 worry about size-calculation overflow.
145 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
146
147 * eval.c (init_eval_once, grow_specpdl): Don't update size until
148 alloc succeeds.
149 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
150
151 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
152 (x_set_scroll_bar_width, x_figure_window_size):
153 Check for integer overflow.
154 (x_set_alpha): Do not assume XINT fits in int.
155
156 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
157 This is for the members text_lines, text_cols, total_lines, total_cols,
158 where the system imposes an 'int' limit.
159
160 * fringe.c (Fdefine_fringe_bitmap):
161 Don't update size until alloc works.
162
163 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
164 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
165
166 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
167 Check for size-calculation overflow.
168 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
169 do, as we prefer signed integers.
170 (id_to_widget.max_size, id_to_widget.used)
171 (xg_store_widget_in_map, xg_remove_widget_from_map)
172 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
173 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
174 Use and return ptrdiff_t, not int.
175 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
176 * gtkutil.h: Change prototypes to match the above.
177
178 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
179 are duplicate now that they've been promoted to lisp.h.
180 (x_allocate_bitmap_record, x_alloc_image_color)
181 (make_image_cache, cache_image, xpm_load):
182 Don't update size until alloc is done.
183 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
184 (x_detect_edges):
3256efce 185 Check for size calculation overflow.
726e0ab1
PE
186 (ct_colors_allocated_max): New constant.
187 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
188 overflow.
3256efce 189
726e0ab1
PE
190 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
191 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
192 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
193 Use ptrdiff_t, not int, to count maps.
194 (read_char_minibuf_menu_prompt): Check for overflow in size
195 calculations. Don't update size until allocation succeeds. Redo
196 calculations to avoid overflow.
197 * keyboard.h: Change prototypes to match the above.
198
199 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
200 to count maps.
201 (current_minor_maps): Check for size calculation overflow.
202 * keymap.h: Change prototypes to match the above.
203
204 * lread.c (read1, init_obarray): Don't update size until alloc done.
205
206 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
207 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
208
726e0ab1
PE
209 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
210 Now ptrdiff_t, not int.
211 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
212 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
213
214 * process.c (Fnetwork_interface_list): Check for overflow
215 in size calculation.
216
217 * region-cache.c (move_cache_gap): Check for size calculation overflow.
218
219 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
220 overflow. Don't bother calling xmalloc when xrealloc will do.
221
222 * search.c (Freplace_match): Check for size calculation overflow.
223 (Fset_match_data): Don't assume list lengths fit in 'int'.
224
225 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
226 for command line length. Do not attempt to address one before the
227 beginning of an array, as that's not portable.
228
229 * term.c (max_frame_lines): Remove; unused.
230 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
231 not int.
232 (encode_terminal_code, calculate_costs): Check for size
233 calculation overflow.
234 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
235 table lengths and related sizes. Don't update size until alloc
236 done. Redo calculations to avoid overflow.
237 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
238
239 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
240 subtracting pointers.
241 (gobble_line): Check for overflow more carefully. Don't update size
242 until alloc done.
243
244 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
245 Don't update size until alloc done.
246 Redo size calculations to avoid overflow.
247 Check for size calculation overflow.
0065d054 248 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
249
250 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
251 Use ptrdiff_t, not int, for sizes.
252 (store_mode_line_noprop_char): Don't update size until alloc done.
253
0065d054
PE
254 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
255 Use ptrdiff_t, not int, for sizes.
256 (Finternal_make_lisp_face, cache_face):
257 Check for size calculation overflow.
258 (cache_face): Treat size calculation overflows as if they were
259 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
260
261 * xfns.c (x_encode_text, x_set_name_internal)
262 (Fx_change_window_property): Use ptrdiff_t, not int, to count
263 sizes, since they can exceed INT_MAX in size. Check for size
264 calculation overflow.
265
0065d054
PE
266 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
267 (xg_select): Check for size calculation overflow.
726e0ab1
PE
268 Don't update size until alloc done.
269
0065d054 270 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 271 as sprintf is limited to int lengths.
1d526e2f 272
252c5ee1
PE
273 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
274 (X_LONG_MIN): New macros.
864d7ce7
PE
275 Use them to make the following changes clearer.
276 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
277 This change doesn't affect the value now, but it may help remind
278 future maintainers not to raise the value too much later.
279 (SELECTION_QUANTUM): Remove, replacing with ...
280 (selection_quantum): ... new function, which avoids overflow.
281 All uses changed.
282 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
283 assumption that selection length fits in 'int'.
284 (x_reply_selection_request, x_handle_selection_request)
285 (x_get_window_property, receive_incremental_selection)
286 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
287 (lisp_data_to_selection_data, clean_local_selection_data):
288 Use ptrdiff_t, not int, to record length of selection.
289 (x_reply_selection_request, x_get_window_property)
290 (receive_incremental_selection, x_property_data_to_lisp):
291 Redo calculations to avoid overflow.
292 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 293 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
294 something.
295 (x_get_window_property, receive_incremental_selection)
296 (lisp_data_to_selection_data, x_property_data_to_lisp):
297 Check for size-calculation overflow.
298 (x_get_window_property, receive_incremental_selection)
299 (lisp_data_to_selection_data, Fx_register_dnd_atom):
300 Don't store size until memory allocation succeeds.
301 (x_get_window_property): Plug memory leak on memory exhaustion.
302 Don't double-block input; malloc is safe here. Don't assume 2**34
303 - 4 fits in unsigned long. Add an xassert to check
304 XGetWindowProperty overflow. Be more careful about overflow
305 calculations, and distinguish size from memory overflow better.
306 (receive_incremental_selection): When tracing, don't assume
307 unsigned int is less than INT_MAX.
308 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
309 harmful) conversions of unsigned short to int.
310 (lisp_data_to_selection_data): Don't assume that integers
311 in the range -65535 through -1 fit in an X unsigned short.
312 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
313 result parameters unless successful. Rely on cons_to_unsigned
314 to report problems with elements; the old code wasn't right anyway.
315 (x_check_property_data): Check for int overflow; we cannot use
316 a wider type due to X limits.
317 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
318
726e0ab1 319 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 320
0065d054
PE
321 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
322 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
323 (x_color_cells): Don't store size until memory allocation succeeds.
324 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 325 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
326 (x_term_init): Don't assume length fits in int (sprintf is limited
327 to int size).
bc18e09d 328
ebfa62c0
PE
329 Use ptrdiff_t for composition IDs.
330 * character.c (lisp_string_width):
331 * composite.c (composition_table_size, n_compositions)
332 (get_composition_id, composition_gstring_from_id):
333 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
334 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
335 * window.c (Frecenter):
336 Use ptrdiff_t, not int, for composition IDs.
337 * composite.c (get_composition_id): Check for integer overflow.
338 * composite.h: Adjust prototypes to match the above changes.
339
d3411f89
PE
340 Use ptrdiff_t for hash table indexes.
341 * category.c (hash_get_category_set):
342 * ccl.c (ccl_driver):
343 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
344 * coding.c (coding_system_charset_list, detect_coding_system):
345 * coding.h (struct coding_system.id):
346 * composite.c (get_composition_id, gstring_lookup_cache):
347 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
348 * image.c (xpm_get_color_table_h):
349 * lisp.h (hash_lookup, hash_put):
350 * minibuf.c (Ftest_completion):
351 Use ptrdiff_t for hash table indexes, not int (which is too
352 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
353 32-bit --with-wide-int hosts).
354
e097a6fa
PE
355 * charset.c (Fdefine_charset_internal): Check for integer overflow.
356 Add a FIXME comment about memory leaks.
357 (syms_of_charset): Don't assume xmalloc returns.
358
5637687f
PE
359 Don't assume that stated character widths fit in int.
360 * character.c (Fchar_width, c_string_width, lisp_string_width):
361 * character.h (CHAR_WIDTH):
362 * indent.c (MULTIBYTE_BYTES_WIDTH):
363 Use sanitize_char_width to avoid undefined and/or bad behavior
364 with outlandish widths.
365 * character.h (sanitize_tab_width): Renamed from sanitize_width,
366 now that we have two such functions. All uses changed.
367 (sanitize_char_width): New inline function.
368
a2271ba2
PE
369 Don't assume that tab-width fits in int.
370 * character.h (sanitize_width): New inline function.
371 (SANE_TAB_WIDTH): New macro.
372 (ASCII_CHAR_WIDTH): Use it.
373 * indent.c (sane_tab_width): Remove. All uses replaced by
374 SANE_TAB_WIDTH (current_buffer).
375 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
376
18c52557
PE
377 * fileio.c: Integer overflow issues with file modes.
378 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
379
caeeedc1
PE
380 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
381 Remove unreachable code.
382 (read_hex, load_charset_map_from_file): Check for integer overflow.
383
50849c52
PE
384 * xterm.c: don't go over XClientMessageEvent limit
385 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
386 (x_send_scroll_bar_event): Likewise. Check that the size does not
387 exceed limits imposed by XClientMessageEvent, as well as the usual
388 ptrdiff_t and size_t limits.
389
b13995db
PE
390 * keyboard.c: Overflow, signedness and related fixes.
391 (make_lispy_movement): Use same integer type in forward decl
392 that is used in the definition.
393 (read_key_sequence, keyremap_step):
394 Change bufsize argument back to int, undoing my 2011-03-30 change.
395 We prefer signed types, and int is wide enough here.
396 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
397 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
398 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
399 length, not size_t. Use ptrdiff_t for index, not int.
400 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
401 possibility of integer overflow.
402
13464394
PE
403 Overflow, signedness and related fixes for images.
404
405 * dispextern.h (struct it.stack[0].u.image.image_id)
406 (struct_it.image_id, struct image.id, struct image_cache.size)
407 (struct image_cache.used, struct image_cache.ref_count):
408 * gtkutil.c (update_frame_tool_bar):
409 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
410 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
411 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
412 * nsmenu.m (update_frame_tool_bar):
413 * xdisp.c (calc_pixel_width_or_height):
414 * xfns.c (image_cache_refcount):
415 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
416 on typical 64-bit hosts.
417
418 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
419 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
420 Omit unnecessary casts to int.
421 (parse_image_spec): Check that integers fall into 'int' range
422 when the callers expect that.
423 (image_ascent): Redo ascent calculation to avoid int overflow.
424 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
425 (lookup_image): Remove unnecessary tests.
426 (xbm_image_p): Locals are now of int, not EMACS_INT,
427 since parse_image_check makes sure they fit into int.
428 (png_load, gif_load, svg_load_image):
429 Prefer int to unsigned where either will do.
430 (tiff_handler): New function, combining the cores of the
431 old tiff_error_handler and tiff_warning_handler. This
432 function is rewritten to use vsnprintf and thereby avoid
433 stack buffer overflows. It uses only the features of vsnprintf
434 that are common to both POSIX and native Microsoft.
435 (tiff_error_handler, tiff_warning_handler): Use it.
436 (tiff_load, gif_load, imagemagick_load_image):
437 Don't assume :index value fits in 'int'.
438 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
439 (imagemagick_load_image): Check that crop parameters fit into
440 the integer types that MagickCropImage accepts. Don't assume
441 Vimagemagick_render_type has a nonnegative value. Don't assume
442 size_t fits in 'long'.
443 (gs_load): Use printmax_t to print the widest integers possible.
444 Check for integer overflow when computing image height and width.
445
c11821d4
EZ
4462011-08-26 Eli Zaretskii <eliz@gnu.org>
447
448 * xdisp.c (redisplay_window): Don't force window start if point
449 will be invisible in the resulting window. (Bug#9324)
450
0c95fcf7
EZ
4512011-08-25 Eli Zaretskii <eliz@gnu.org>
452
453 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
454 the display spec is of the form `(space ...)'.
455 (handle_display_spec): Return the value returned by
456 handle_single_display_spec, not just 1 or zero.
457 (handle_single_display_spec): If the display spec is of the form
458 `(space ...)', and specifies display in the text area, return 2
459 rather than 1.
fee65a97 460 (try_cursor_movement): Check for the need to scroll more
e25be792
EZ
461 accurately, and prefer exact match for point under bidi. Don't
462 advance `row' beyond the last row of the window.
0c95fcf7
EZ
463
464 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
465 into disp_prop; all users changed.
466
467 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
468 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
469 for the text covered by the display property.
470
e4ed06f1
CY
4712011-08-25 Chong Yidong <cyd@stupidchicken.com>
472
473 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
474 Change return value to nil.
475 (Frecord_buffer): Delete unused function.
476
f67cdd7f
EZ
4772011-08-24 Eli Zaretskii <eliz@gnu.org>
478
5980d4c6
EZ
479 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
480 buffers, return left-to-right.
8610fe8b
EZ
481 (set_cursor_from_row): Consider candidate row a win if its glyph
482 represents a newline and point is on that newline. Fixes cursor
483 positioning on the newline at EOL of R2L text within L2R
484 paragraph, and vice versa.
485 (try_cursor_movement): Check continued rows, in addition to
486 continuation rows. Fixes unwarranted scroll when point enters a
487 continued line of R2L text within an L2R paragraph, or vice versa.
488 (cursor_row_p): Consider the case of point being equal to
489 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
490 from the end of a short line to the beginning of a continued line
491 of R2L text within L2R paragraph.
492 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
493 composed characters.
5980d4c6 494
f67cdd7f
EZ
495 * bidi.c (bidi_check_type): Use xassert.
496 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
497 members.
498
bca633fb
EZ
4992011-08-23 Eli Zaretskii <eliz@gnu.org>
500
501 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
502 a character.
503
4a5885a7
CY
5042011-08-23 Chong Yidong <cyd@stupidchicken.com>
505
506 * nsfont.m (ns_otf_to_script): Fix typo.
507
0902a04e
KH
5082011-08-22 Kenichi Handa <handa@m17n.org>
509
510 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
511 extra slot even if the purpose is char-code-property-table.
512
1a2e6670
EZ
5132011-08-23 Eli Zaretskii <eliz@gnu.org>
514
8ddde651
EZ
515 * xdisp.c (redisplay_window): When computing centering_position,
516 account for the height of the header line. (Bug#8874)
517
425cc014
EZ
518 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
519 instead of CHAR_TO_BYTE. Fixes a crash when a completion
520 candidate is selected by the mouse, and that candidate has a
521 composed character under the mouse.
522
1a2e6670
EZ
523 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
524 coordinates reported by pos-visible-in-window-p for a composed
525 character in column zero.
526
8b76d6f8
SM
5272011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
528
529 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
530
dac347dd
EZ
5312011-08-22 Eli Zaretskii <eliz@gnu.org>
532
533 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
534 consider it a hit if to_charpos is anywhere in the range of the
535 composed buffer positions.
536
e013fb34
CY
5372011-08-22 Chong Yidong <cyd@stupidchicken.com>
538
539 * image.c (gif_load): Don't assume that each subimage has the same
540 dimensions as the base image. Handle disposal method that is
541 "undefined" by the gif spec (Bug#9335).
542
bd1ba3e8
CY
5432011-08-20 Chong Yidong <cyd@stupidchicken.com>
544
545 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 546 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 547
54a1215b
EZ
5482011-08-19 Eli Zaretskii <eliz@gnu.org>
549
823564e5
EZ
550 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
551 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
552 from an Org mode buffer to a Speedbar frame.
553
54a1215b
EZ
554 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
555 a composition, take its buffer position from IT->cmp_it.charpos.
556 Fixes cursor positioning at the beginning of a line that begins
557 with a composed character.
558
9778ebcc
EZ
5592011-08-18 Eli Zaretskii <eliz@gnu.org>
560
0be6ee06
EZ
561 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
562 character bidirectional type, use STRONG_L instead. Fixes crashes
563 in a buffer produced by `describe-categories'.
564
9778ebcc
EZ
565 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
566 members before the level stack, so they would be saved and
567 restored when copying iterator state. Fixes incorrect reordering
568 around TABs covered by display properties.
569
156bffbe
AS
5702011-08-18 Andreas Schwab <schwab@linux-m68k.org>
571
572 * process.c (Fnetwork_interface_list): Correctly determine buffer
573 size.
574
72ad093b
CY
5752011-08-17 Chong Yidong <cyd@stupidchicken.com>
576
577 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
578 (internal_condition_case_2, internal_condition_case_n):
579 Remove unnecessary aborts (Bug#9081).
72ad093b 580
35774242
EZ
5812011-08-17 Eli Zaretskii <eliz@gnu.org>
582
583 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
584 has no `load' handler, try opening the file locally. (Bug#9311)
585
db76dd85
KB
5862011-08-16 Ken Brown <kbrown@cornell.edu>
587
588 * gmalloc.c: Expand comment.
589
b215eee5
EZ
5902011-08-16 Eli Zaretskii <eliz@gnu.org>
591
592 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
593 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
594
a4579d33
KB
5952011-08-16 Ken Brown <kbrown@cornell.edu>
596
597 Fix memory allocation problems in Cygwin build (Bug#9273).
598
599 * unexcw.c ( __malloc_initialized): Declare external variable.
600 (fixup_executable): Force the dumped emacs to reinitialize malloc.
601
8b76d6f8
SM
602 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
603 New variables.
a4579d33
KB
604 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
605 dumped emacs.
606 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
607 in the static heap.
608 [CYGWIN] (special_realloc): New function.
609 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
610 requests to realloc storage in the static heap.
611
3ebec551
PE
6122011-08-15 Paul Eggert <eggert@cs.ucla.edu>
613
614 * bidi.c (bidi_initialize): Remove unused local.
615
9fd8be00
EZ
6162011-08-15 Eli Zaretskii <eliz@gnu.org>
617
474a8465
EZ
618 * biditype.h: File removed.
619
620 * bidimirror.h: File removed.
621
622 * deps.mk (bidi.o): Remove biditype.h and
623 bidimirror.h.
624
625 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
626 bidimirror.h.
627
628 * dispextern.h: Fix a typo in the comment to bidi_type_t.
629
630 * chartab.c: Improve commentary for the uniprop_table API.
631
32413314
EZ
632 * bidi.c (bidi_paragraph_init): Support zero value of
633 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
634 (bidi_initialize): Use uniprop_table instead of including
635 biditype.h and bidimirror.h.
32413314 636
9fd8be00
EZ
637 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
638 coordinates of the iterator when restoring from ppos_it.
639 (Bug#9296)
640
5cf2b69b
KH
6412011-08-14 Kenichi Handa <handa@m17n.org>
642
643 * process.c (create_process): Call setup_process_coding_systems
72ad093b 644 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 645
daf17d00
EZ
6462011-08-14 Eli Zaretskii <eliz@gnu.org>
647
648 * xdisp.c (move_it_in_display_line_to): Don't invoke
649 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
650 ppos_it. Fixes vertical cursor motion when line beginning is
651 covered by an image. (Bug#9296)
652
08e3161a
JD
6532011-08-14 Jan Djärv <jan.h.d@swipnet.se>
654
655 * nsterm.h (ns_run_ascript): Declare.
656 (NSAPP_DATA2_RUNASSCRIPT): Define.
657
658 * nsfns.m (as_script, as_result, as_status): New static variables.
659 (ns_run_ascript): New function.
660 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
661 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
662 the event loop. Get status from as_status (Bug#7276).
663
664 * nsterm.m (sendEvent): If event is NSApplicationDefined and
665 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
666 the event loop (Bug#7276).
667
a3720aa2
AS
6682011-08-14 Andreas Schwab <schwab@linux-m68k.org>
669
670 * gnutls.c (QCgnutls_bootprop_priority)
671 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
672 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
673 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
674 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
675 (QCgnutls_bootprop_verify_hostname_error)
676 (QCgnutls_bootprop_callbacks_verify): Rename from
677 Qgnutls_bootprop_..., all uses changed.
678
679 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
680 uses changed.
681
0a0d27fb
PE
6822011-08-14 Paul Eggert <eggert@cs.ucla.edu>
683
19d5c50c
PE
684 * xfaces.c (Qframe_set_background_mode): Now static.
685 * dispextern.h (Qframe_set_background_mode): Remove decl.
686
0a0d27fb
PE
687 * process.c (Fnetwork_interface_info): Declare local only if needed.
688
377538cb
JD
6892011-08-13 Jan Djärv <jan.h.d@swipnet.se>
690
691 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
692 (Fnetwork_interface_list): Allocate in increments of bytes instead
693 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
694 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
695 sockaddr.
696 (struct ifflag_def): notrailers is smart on OSX.
697 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
698 Get hardware address with getifaddrs if available.
699
08fff70c
EZ
7002011-08-12 Eli Zaretskii <eliz@gnu.org>
701
702 * xdisp.c (iterate_out_of_display_property): xassert that
703 IT->position is set to within IT->object's boundaries. Break from
704 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
705 when IT->position is set up wrongly due to some bug.
706 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
707 (push_display_prop): Allow GET_FROM_STRING as IT->method on
708 entry. Force push_it to save on the stack the current
709 buffer/string position, to be restored by pop_it. Fix flags in
710 the iterator structure wrt the object coming from a display
711 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
712 properties. (Bug#9284)
713
7be1c708 7142011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 715
7be1c708
CY
716 * fontset.c (fontset_get_font_group): Add proper type checks.
717 (Bug#9172)
aac0c6e3 718
7be1c708 7192011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 720
7be1c708
CY
721 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
722 and LC_VERSION_MIN_MACOSX.
723 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
724 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 725
97bb72a6
EZ
7262011-08-08 Eli Zaretskii <eliz@gnu.org>
727
728 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
729 no-display-properties-and-no-overlays under bidi display.
730 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 731 properties and overlays.
97bb72a6 732
d5617611
CY
7332011-08-08 Chong Yidong <cyd@stupidchicken.com>
734
37e11a63
CY
735 * editfns.c (Fset_time_zone_rule): Document relationship with the
736 setenv function.
737
d5617611
CY
738 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
739 the font entity extracted from the cache (Bug#8109).
740
58872834
CY
7412011-08-07 Chong Yidong <cyd@stupidchicken.com>
742
743 * composite.c (autocmp_chars): Don't reset point. That is done by
744 restore_point_unwind (Bug#5984).
745
75bfc667
JL
7462011-08-07 Juri Linkov <juri@jurta.org>
747
748 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
749 to show the arg `TIME' instead of `TIMEVAL'.
750
d1410150
EZ
7512011-08-06 Eli Zaretskii <eliz@gnu.org>
752
753 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
754 display property strides EOL and includes a newline, as in
755 longlines-mode. (Bug#9254)
75b771e4
EZ
756 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
757 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
758
759 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
760 is non-zero, even if the data buffer is NULL. Fixes a crash in
761 vertical-motion with longlines-mode. (Bug#9254)
762
35928349
EZ
7632011-08-05 Eli Zaretskii <eliz@gnu.org>
764
ec7cc85b
EZ
765 * bidi.c <bidi_cache_total_alloc>: Now static.
766 (bidi_initialize): Initialize bidi_cache_total_alloc.
767
8b76d6f8 768 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
769 cache. (Bug#9221)
770
771 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
772 amount allocated this far in `bidi_cache_total_alloc'.
773 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
774 non-zero, only free the data buffer without restoring the cache
775 contents. All callers changed.
776
777 * dispextern.h (bidi_unshelve_cache): Update prototype.
778
779 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
780 (move_it_in_display_line, move_it_to)
781 (move_it_vertically_backward, move_it_by_lines): Replace the call
782 to xfree to an equivalent call to bidi_unshelve_cache.
783 (move_it_in_display_line_to): Fix logic of returning
412b6358 784 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 785
e2e2423b
EZ
7862011-08-05 Eli Zaretskii <eliz@gnu.org>
787
788 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
789 came from a string character with a `cursor' property. (Bug#9229)
790
ae9e757a
JD
7912011-08-04 Jan Djärv <jan.h.d@swipnet.se>
792
793 * Makefile.in (LIB_PTHREAD): New variable.
794 (LIBES): Add LIB_PTHREAD (Bug#9216).
795
796 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
797 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
798
213bd7f2
AS
7992011-08-04 Andreas Schwab <schwab@linux-m68k.org>
800
801 * regex.c (re_iswctype): Remove some redundant boolean
802 conversions.
803
99aaf75f
JD
8042011-08-04 Jan Djärv <jan.h.d@swipnet.se>
805
806 * xterm.c (x_find_topmost_parent): New function.
807 (x_set_frame_alpha): Find topmost parent window with
808 x_find_topmost_parent and set the property there also (bug#9181).
809 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
810
c74e9d86
PE
8112011-08-04 Paul Eggert <eggert@cs.ucla.edu>
812
813 * callproc.c (Fcall_process): Avoid vfork clobbering
814 the local vars buffer, coding_systems, current_dir.
815
640c8776
SM
8162011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
817
818 * keymap.c (Fmake_composed_keymap): Move to subr.el.
819
f26d0e4c
PE
8202011-08-03 Paul Eggert <eggert@cs.ucla.edu>
821
8a10d76c
PE
822 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
823 so that it is not optimized away.
824
f26d0e4c
PE
825 * xdisp.c (compute_display_string_pos): Remove unused local.
826
55439c61
EZ
8272011-08-02 Eli Zaretskii <eliz@gnu.org>
828
829 Fix slow cursor motion and scrolling in large buffers with
830 selective display, like Org Mode buffers. (Bug#9218)
831
832 * dispextern.h (struct bidi_it): New member disp_prop_p.
833
834 * xdisp.c: Remove one-slot cache of display string positions.
835 (compute_display_string_pos): Accept an additional argument
836 DISP_PROP_P; callers changed. Scan at most 5K characters forward
837 for a display string or property. If found, set DISP_PROP_P
838 non-zero.
839
840 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
841 DISP_PROP_P, and pass it to compute_display_string_pos.
842 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
843 non-zero. All callers of bidi_fetch_char changed.
844
fb33fa43
SM
8452011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
846
847 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
848
b099e063
DM
8492010-12-03 Don March <don@ohspite.net>
850
851 * keymap.c (Fdefine_key): Fix non-prefix key error message when
852 last character M-[char] is translated to ESC [char] (bug#7541).
853
5cc7f7af
KH
8542011-08-02 Kenichi Handa <handa@m17n.org>
855
d0fffa3f 856 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
857
858 * chartab.c (uniprop_table): Make it non-static.
859
525d5e6e
EZ
8602011-08-01 Eli Zaretskii <eliz@gnu.org>
861
862 * xdisp.c (forward_to_next_line_start): Accept additional argument
863 BIDI_IT_PREV, and store into it the state of the bidi iterator had
864 on the newline.
865 (reseat_at_next_visible_line_start): Use the bidi iterator state
866 returned by forward_to_next_line_start to restore the state of
867 it->bidi_it after backing up to previous newline. (Bug#9212)
868
31011111
AS
8692011-07-30 Andreas Schwab <schwab@linux-m68k.org>
870
871 * regex.c (re_comp): Protoize.
872 (re_exec): Fix return type.
873 (regexec): Fix type of `ret'. (Bug#9203)
874
e5d76069
PE
8752011-07-29 Paul Eggert <eggert@cs.ucla.edu>
876
877 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
878 This is needed if max-image-size is a floating-point number.
879
9a79b20c
AS
8802011-07-28 Andreas Schwab <schwab@linux-m68k.org>
881
882 * print.c (print_object): Print empty symbol as ##.
883
884 * lread.c (read1): Read ## as empty symbol.
885
d8c2fa78
AA
8862011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
887
888 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
889 setting frame foreground color (Bug#9175).
890 (x_set_background_color): Likewise.
891
ffe57a7a
AA
892 * nsmenu.m (-setText): Size tooltip dimensions precisely to
893 contents (Bug#9176).
894 (EmacsTooltip -init): Remove bezels and add shadows to
895 tooltip windows.
896
bf3492a5
AA
897 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
898 or scroll bar (Bug#8470).
899
d55e9c53
AA
900 * nsfont.m (nsfont_open): Remove assignment to voffset and
901 unnecessary vars hshink, expand, hd, full_height, min_height.
902 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
903
904 * nsterm.h (nsfont_info): Remove voffset field.
905
d8c2fa78 9062011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
907
908 Implement strike-through and overline on NextStep (Bug#8863).
909
910 * nsfont.m (nsfont_open): Use underline position provided by font,
911 instead of hard-coded value of 2.
912 (nsfont_draw): Call ns_draw_text_decoration instead.
913
914 * nsterm.h: Add declaration for ns_draw_text_decoration.
915
916 * nsterm.m (ns_draw_text_decoration): New function for drawing
917 underline, overline, and strike-through.
918 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
919 ns_draw_text_decoration. Change treatment of cursor drawing to
920 accomodate underlining, etc.
921
4cc60b9b
EZ
9222011-07-28 Eli Zaretskii <eliz@gnu.org>
923
bc7ece87
EZ
924 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
925 default.
4cc60b9b 926
476371c4
PE
9272011-07-28 Paul Eggert <eggert@cs.ucla.edu>
928
66606eea
PE
929 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
930 Without this fix, if a signal arrives just after memory fills up,
931 'malloc' might be invoked reentrantly.
932
476371c4
PE
933 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
934 In other words, assume that every image size is allowed, on non-X
935 hosts. This assumption is probably wrong, but it lets Emacs compile.
936
f3fcc40d
AS
9372011-07-28 Andreas Schwab <schwab@linux-m68k.org>
938
939 * regex.c (re_iswctype): Convert return values to boolean.
940
350c992f
EZ
9412011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
942
943 * xdisp.c (compute_display_string_pos): Don't use cached display
944 string position if the buffer had its restriction changed.
945 (Bug#9184)
946
5266b4bb
PE
9472011-07-28 Paul Eggert <eggert@cs.ucla.edu>
948
949 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
950
2573a837 9512011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 952
41f55ccd 953 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 954
39e378da
PE
955 * bidi.c: Integer size and overflow fixes.
956 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
957 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
958 (bidi_cache_find_level_change, bidi_cache_ensure_space)
959 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
960 (bidi_find_other_level_edge):
961 Use ptrdiff_t instead of EMACS_INT where either will do.
962 This works better on 32-bit hosts configured --with-wide-int.
963 (bidi_cache_ensure_space): Check for size-calculation overflow.
964 Use % rather than repeated addition, for better worst-case speed.
965 Don't set bidi_cache_size until after xrealloc returns, because it
966 might not return.
967 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
968 (bidi_cache_ensure_space): Also check that the bidi cache size
969 does not exceed that of the largest Lisp string or buffer. See Eli
970 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 971
5e927815
PE
972 * alloc.c (__malloc_size_t): Remove.
973 All uses replaced by size_t. See Andreas Schwab's note
974 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
975
ca4aa935
PE
976 * image.c: Improve checking for integer overflow.
977 (check_image_size): Assume that f is nonnull, since
978 it is always nonnull in practice. This is one less thing to
979 worry about when checking for integer overflow later.
980 (x_check_image_size): New function, which checks for integer
981 overflow issues inside X.
982 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
983 This removes the need for a memory_full check.
984 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
985 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
986 (xbm_read_bitmap_data): Change locals back to 'int', since
987 their values must fit in 'int'.
988 (xpm_load_image, png_load, tiff_load):
989 Invoke x_create_x_image_and_pixmap earlier,
990 to avoid much needless work if the image is too large.
991 (tiff_load): Treat overly large images as if
992 x_create_x_image_and_pixmap failed, not as malloc failures.
993 (gs_load): Use x_check_image_size.
994
5f8f9cc2
PE
995 * gtkutil.c: Omit integer casts.
996 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
997 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
998
5adf60bc
PE
999 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1000
c8907a93
PE
1001 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1002 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1003 would wrongly return t on a 64-bit host.
1004
e3c25c68
PE
1005 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1006 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1007 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1008 and therefore cause GCC to emit a bogus diagnostic in some cases.
1009
3f791afe
PE
1010 * image.c: Integer signedness and overflow and related fixes.
1011 This is not an exhaustive set of fixes, but it's time to
1012 record what I've got.
1013 (lookup_pixel_color, check_image_size): Remove redundant decls.
1014 (check_image_size): Don't assume that arbitrary EMACS_INT values
1015 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1016 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1017 (tiff_load, imagemagick_load_image):
1018 Check for overflow in size calculations.
1019 (x_create_x_image_and_pixmap): Remove unnecessary test for
1020 xmalloc returning NULL; that can't happen.
1021 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1022 (xpm_color_bucket): Use better integer hashing function.
1023 (xpm_cache_color): Don't possibly over-allocate memory.
1024 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1025 (gif_memory_source):
1026 Use ptrdiff_t, not int or size_t, to record sizes.
1027 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1028 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1029 either works, as we prefer signed integers.
1030 (tiff_read_from_memory, tiff_write_from_memory):
1031 Return tsize_t, not size_t, since that's what the TIFF API wants.
1032 (tiff_read_from_memory): Don't fail simply because the read would
1033 go past EOF; instead, return a short read.
1034 (tiff_load): Omit no-longer-needed casts.
1035 (Fimagemagick_types): Don't assume size fits into 'int'.
1036
3cc5a532
PE
1037 Improve hashing quality when configured --with-wide-int.
1038 * fns.c (hash_string): New function, taken from sxhash_string.
1039 Do not discard information about ASCII character case; this
1040 discarding is no longer needed.
1041 (sxhash-string): Use it. Change sig to match it. Caller changed.
1042 * lisp.h: Declare it.
1043 * lread.c (hash_string): Remove, since we now use fns.c's version.
1044 The fns.c version returns a wider integer if --with-wide-int is
1045 specified, so this should help the quality of the hashing a bit.
1046
b312a492
PE
1047 * emacs.c: Integer overflow minor fix.
1048 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1049 Define only if GNU_LINUX.
1050 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1051
dfd153ae
PE
1052 * dispnew.c: Integer signedness and overflow fixes.
1053 Remove unnecessary forward decls, that were a maintenance hassle.
1054 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1055 All uses changed.
1056 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1057 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1058 (prepare_desired_row, line_draw_cost):
1059 Use int, not unsigned, where either works.
1060 (save_current_matrix, restore_current_matrix):
1061 Use ptrdiff_t, not size_t, where either works.
1062 (init_display): Check for overflow more accurately, and without
1063 relying on undefined behavior.
1064
a81d11a3
PE
1065 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1066 Remove, replacing with the new symbols in lisp.h. All uses changed.
1067 * fileio.c (make_temp_name):
1068 * filelock.c (lock_file_1, lock_file):
1069 * xdisp.c (message_dolog):
1070 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1071 Use pMd etc. instead.
1072 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1073 replacing the pWIDE etc. symbols removed from editfns.c.
1074
3300e6fd
PE
1075 * keyboard.h (num_input_events): Now uintmax_t.
1076 This is (very slightly) less likely to mess up due to wraparound.
1077 All uses changed.
1078
fd05c7e9
PE
1079 * buffer.c: Integer signedness fixes.
1080 (alloc_buffer_text, enlarge_buffer_text):
1081 Use ptrdiff_t rather than size_t when either will do, as we prefer
1082 signed integers.
1083
903fe15d
PE
1084 * alloc.c: Integer signedness and overflow fixes.
1085 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1086 (__malloc_size_t): Default to size_t, not to int.
1087 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1088 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1089 Prefer ptrdiff_t to size_t when either would do, as we prefer
1090 signed integers.
1091 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1092 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1093 Now const. Initialize with values that are in range even if char
1094 is signed.
1095 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1096 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1097 These functions do the right thing with sizes > 2**32.
1098 (check_depth): Now ptrdiff_t, not int.
1099 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1100 Adjust to new way of storing sizes. Check for size overflow bugs
1101 in rest of code.
1102 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1103 slightly wrong anyway, as it missed one instance of
1104 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1105 (refill_memory_reserve): Omit needless cast to size_t.
1106 (mark_object_loop_halt): Mark as externally visible.
1107
ac82cc6a
PE
1108 * xselect.c: Integer signedness and overflow fixes.
1109 (Fx_register_dnd_atom, x_handle_dnd_message):
1110 Use ptrdiff_t, not size_t, since we prefer signed.
1111 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1112 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1113 x_dnd_atoms_size and x_dnd_atoms_length.
1114
c2d1e36d
PE
1115 * doprnt.c: Prefer signed to unsigned when either works.
1116 * eval.c (verror):
1117 * doprnt.c (doprnt):
1118 * lisp.h (doprnt):
1119 * xdisp.c (vmessage):
1120 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1121 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1122 prefer signed arithmetic to avoid comparison confusion.
1123 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1124 but is a bit tricky.
1125
0e926e56
PE
1126 Assume freestanding C89 headers, string.h, stdlib.h.
1127 * data.c, doprnt.c, floatfns.c, print.c:
1128 Include float.h unconditionally.
1129 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1130 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1131 * regex.c: Likewise for stddef.h, string.h.
1132 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1133 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1134 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1135 (STDC_HEADERS): Remove obsolete defines.
1136 * sysdep.c: Include limits.h unconditionally.
1137
9cfdb3ec
PE
1138 Assume support for memcmp, memcpy, memmove, memset.
1139 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1140 * regex.c (memcmp, memcpy):
1141 Remove; we assume C89 now.
1142
1143 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1144 (__malloc_safe_bcopy): Remove; no longer needed.
1145
cf950e6b 1146 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
1147 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1148 well either way, and we prefer signed to unsigned.
1149
dbf38e02
LMI
11502011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1151
1152 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1153 closes the connection while we're reading (bug#9182).
1154
d6f0886c
JD
11552011-07-25 Jan Djärv <jan.h.d@swipnet.se>
1156
1157 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1158 are specified (Bug#9168).
1159
2eb1f9e6
PE
11602011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1161
1162 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1163 Found by GCC static checking and --with-wide-int on a 32-bit host.
1164
22381272 11652011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
1166
1167 * xdisp.c (compute_display_string_pos): Fix logic of caching
1168 previous display string position. Initialize cached_prev_pos to
1169 -1. Fixes slow-down at the beginning of a buffer.
1170
f25e39b4
EZ
11712011-07-24 Eli Zaretskii <eliz@gnu.org>
1172
1173 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1174 for attrs[LFACE_FONTSET_INDEX].
1175
04c4b52e
PE
11762011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1177
1178 * xml.c (parse_region): Remove unused local
1179 that was recently introduced.
1180
c1734fbd
EZ
11812011-07-23 Eli Zaretskii <eliz@gnu.org>
1182
be18c5a5
EZ
1183 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1184 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1185
c1734fbd
EZ
1186 * xdisp.c (move_it_in_display_line_to): Record the best matching
1187 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
1188 exit if none of the characters scanned was an exact match.
1189 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
1190 when exact match is impossible due to invisible text, and the
1191 lines are truncated.
1192
a258d627
JD
11932011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1194
1195 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1196 for OSX >= 10.7.
1197
b6d5a689
EZ
11982011-07-22 Eli Zaretskii <eliz@gnu.org>
1199
0f74f785
EZ
1200 Fix a significant slow-down of cursor motion with C-n, C-p,
1201 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1202 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 1203 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
1204 (next_element_from_buffer): Call compute_stop_pos_backwards to
1205 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
1206 base_level_stop.
1207 (reseat): Don't look for prev_stop, as that could mean a very long
1208 run.
1209 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1210 <cached_disp_overlay_modiff>: Cache for last found display string
1211 position.
551918c1 1212 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
1213 about the same buffer in the same area of character positions, and
1214 the buffer wasn't changed since the time the display string
1215 position was cached.
551918c1 1216
b2d0c91a
EZ
12172011-07-22 Eli Zaretskii <eliz@gnu.org>
1218
1219 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1220 is an integer, which is important for empty lines. (Bug#9149)
1221
043604ee
CY
12222011-07-22 Chong Yidong <cyd@stupidchicken.com>
1223
1224 * frame.c (Fmodify_frame_parameters): In tty case, update the
1225 default face if necessary (Bug#4238).
1226
da4adb04
CY
12272011-07-21 Chong Yidong <cyd@stupidchicken.com>
1228
1229 * editfns.c (Fstring_to_char): No need to explain what a character
1230 is in the docstring (Bug#6576).
1231
9abd0532
LMI
12322011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1233
1234 * xml.c (parse_region): Make sure we always return a tree.
1235
36881d16
HK
12362011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1237
1238 * xml.c (parse_region): If a document contains only comments,
1239 return that, too.
1240
1e98674d
LMI
12412011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1242
1243 * xml.c (make_dom): Return comments, too.
1244
590bd467
PE
12452011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1246
1247 Port to OpenBSD.
1248 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1249 and the surrounding thread.
1250 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1251 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1252 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1253 timer goes off.
1254 * s/openbsd.h (BROKEN_SIGIO): Define.
1255 * unexelf.c (unexec) [__OpenBSD__]:
1256 Don't update the .mdebug section of the Alpha COFF symbol table.
1257
f41628b2
LMI
12582011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1259
1260 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1261 (bug#8460).
1262
b59b67c5
PE
12632011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1264
15e3a074
PE
1265 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1266 This fixes some race conditions on the permissions of any newly
1267 created file.
1268
41bed37d
PE
1269 * alloc.c (valid_pointer_p): Use pipe, not open.
1270 This fixes some permissions issues when debugging.
1271
b59b67c5
PE
1272 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1273 If fchown fails to set both uid and gid, try to set just gid,
1274 as that is sometimes allowed. Adjust the file's mode to eliminate
1275 setuid or setgid bits that are inappropriate if fchown fails.
1276
925a6be7
SM
12772011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1278
1279 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1280 to compare Lisp_Objects.
1281 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1282 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1283 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1284
52968808
AS
12852011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1286
0a6a104b
AS
1287 * lread.c (read_integer): Unread even EOF character.
1288 (read1): Likewise. Properly record start position of symbol.
1289
52968808
AS
1290 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1291 symbol character follows.
1292
9e381cdd
PE
12932011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1294
1295 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1296 This works around a problem with the previous change to Fcopy_file.
1297 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1298 and without this change, GCC might complain about discarding
1299 fchown's return value.
1300
b5641435
JB
13012011-07-16 Juanma Barranquero <lekktu@gmail.com>
1302
1303 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1304
a8031457
PE
13052011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1306
1307 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1308
dd889327
LMI
13092011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1310
750c33f7
LMI
1311 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1312 it's used from the C level.
1313
dd889327
LMI
1314 * process.c: Use the same condition for POLL_FOR_INPUT in both
1315 keyboard.c and process.c (bug#1858).
1316
87e86684
LM
13172011-07-09 Lawrence Mitchell <wence@gmx.li>
1318
1319 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1320 (Fgnutls_boot): Use it.
1321
64348f40
AS
13222011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1323
1324 * doc.c (Fsubstitute_command_keys): Revert last change.
1325
1d698799
LMI
13262011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1327
f863868c
LMI
1328 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1329 quotes the next character, and doesn't affect other longer
1330 sequences (bug#8935).
1331
1d698799
LMI
1332 * lread.c (syms_of_lread): Clarify that is isn't only
1333 `eval-buffer' and `eval-defun' that's affected by
1334 `lexical-binding' (bug#8460).
1335
aa4b6df6
EZ
13362011-07-15 Eli Zaretskii <eliz@gnu.org>
1337
1338 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1339 bidi redisplay when a line includes both an image and is
1340 truncated.
1341
5d856da6
PE
13422011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1343
ad6042bb
PE
1344 Fix minor problems found by static checking.
1345 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1346 (elsz): Now a signed constant, not a size_t var. We prefer signed
1347 types to unsigned, to avoid integer comparison confusion. Without
1348 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1349 "cannot optimize loop, the loop counter may overflow", a symptom
1350 of the confusion.
f00bbb22 1351 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
1352 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1353
6468f31c
LMI
13542011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1355
49080b10
LMI
1356 * search.c (Fre_search_backward): Mention `case-fold-search' in
1357 all the re_search_* functions (bug#8138).
1358
6468f31c
LMI
1359 * keyboard.c (Fopen_dribble_file): Document when the file is
1360 closed (bug#8056).
1361
c965adc5
EZ
13622011-07-14 Eli Zaretskii <eliz@gnu.org>
1363
df9733bf
EZ
1364 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1365 bidi_cache_idx.
1366
0bb23927
EZ
1367 Support bidi reordering of display and overlay strings.
1368 * xdisp.c (compute_display_string_pos)
1369 (compute_display_string_end): Accept additional argument STRING.
1370 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1371 (reseat_to_string): Initialize bidi_it->string.s and
1372 bidi_it->string.schars.
1373 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
1374 NULL (avoids a crash in bidi_paragraph_init).
1375 Initialize itb.string.lstring.
0bb23927
EZ
1376 (init_iterator): Call bidi_init_it only of a valid
1377 buffer position was specified. Initialize paragraph_embedding to
1378 L2R.
1379 (reseat_to_string): Initialize the bidi iterator.
1380 (display_string): If we need to ignore text properties of
1381 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1382 original value of -1 will not work with bidi.)
1383 (compute_display_string_pos): First arg is now struct
1384 `text_pos *'; all callers changed. Support display properties on
1385 Lisp strings.
1386 (compute_display_string_end): Support display properties on Lisp
1387 strings.
1388 (init_iterator, reseat_1, reseat_to_string): Initialize the
1389 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1390 when iterating on a string not from display properties).
640c8776
SM
1391 (compute_display_string_pos, compute_display_string_end):
1392 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
1393 arrow keys.
1394 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
1395 base_level_stop; instead, set base_level_stop to BEGV.
1396 Fixes crashes in vertical-motion.
0bb23927
EZ
1397 (next_element_from_buffer): Improve commentary for when
1398 the iterator is before prev_stop.
1399 (init_iterator): Initialize bidi_p from the default value of
1400 bidi-display-reordering, not from buffer-local value. Use the
1401 buffer-local value only if initializing for buffer iteration.
1402 (handle_invisible_prop): Support invisible properties on strings
1403 that are being bidi-reordered.
1404 (set_iterator_to_next): Support bidi reordering of C strings and
1405 Lisp strings.
1406 (next_element_from_string): Support bidi reordering of Lisp
1407 strings.
1408 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
1409 (display_string): Support display of R2L glyph rows.
1410 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
1411 (init_iterator): Don't initialize it->bidi_p for strings
1412 here.
1413 (reseat_to_string): Initialize it->bidi_p for strings here.
1414 (next_element_from_string, next_element_from_c_string)
1415 (next_element_from_buffer): Add xassert's for correspondence
1416 between IT's object being iterated and it->bidi_it.string
1417 structure.
1418 (face_before_or_after_it_pos): Support bidi iteration.
1419 (next_element_from_c_string): Handle the case of the first string
1420 character that is not the first one in the visual order.
1421 (get_visually_first_element): New function, refactored from common
1422 parts of next_element_from_buffer, next_element_from_string, and
1423 next_element_from_c_string.
1424 (tool_bar_lines_needed, redisplay_tool_bar)
1425 (display_menu_bar): Force left-to-right direction. Add a FIXME
1426 comment for making that be controlled by a user option.
1427 (push_it, pop_it): Save and restore the state of the
1428 bidi iterator. Save and restore the bidi_p flag.
1429 (pop_it): Iterate out of display property for string iteration as
1430 well.
1431 (iterate_out_of_display_property): Support iteration over strings.
1432 (handle_single_display_spec): Set up it->bidi_it for iteration
1433 over a display string, and call bidi_init_it.
1434 (handle_single_display_spec, next_overlay_string)
1435 (get_overlay_strings_1, push_display_prop): Set up the bidi
1436 iterator for displaying display or overlay strings.
1437 (forward_to_next_line_start): Don't use the shortcut if
1438 bidi-iterating.
1439 (back_to_previous_visible_line_start): If handle_display_prop
1440 pushed the iterator stack, restore the internal state of the bidi
1441 iterator by calling bidi_pop_it same number of times.
1442 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
1443 and we are bidi-iterating, don't decrement the iterator position;
1444 instead, set the first_elt flag in the bidi iterator, to produce
1445 the same effect.
1446 (reseat_1): Remove redundant setting of string_from_display_prop_p.
1447 (push_display_prop): xassert that we are iterating a buffer.
1448 (push_it, pop_it): Save and restore paragraph_embedding member.
1449 (handle_single_display_spec, next_overlay_string)
1450 (get_overlay_strings_1, reseat_1, reseat_to_string)
1451 (push_display_prop): Set up the `unibyte' member of bidi_it.string
1452 correctly. Don't assume unibyte strings are not bidi-reordered.
1453 (compute_display_string_pos)
1454 (compute_display_string_end): Fix handling the case of C string.
1455 (push_it, pop_it): Save and restore from_disp_prop_p.
1456 (handle_single_display_spec, push_display_prop): Set the
1457 from_disp_prop_p flag.
1458 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
1459 (pop_it): Call iterate_out_of_display_property only if we are
1460 popping after iteration over a string that came from a display
1461 property. Fix a typo in popping stretch info. Add an assertion
1462 for verifying that the iterator position is in sync with the bidi
1463 iterator.
1464 (handle_single_display_spec, get_overlay_strings_1)
1465 (push_display_prop): Fix initialization of paragraph direction for
1466 string when that of the parent object is not yet determined.
1467 (reseat_1): Call bidi_init_it to resync the bidi
1468 iterator with IT's position. (Bug#7616)
1469 (find_row_edges): If ROW->start.pos gives position
1470 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
1471 (handle_stop, back_to_previous_visible_line_start, reseat_1):
1472 Reset the from_disp_prop_p flag.
1473 (SAVE_IT, RESTORE_IT): New macros.
1474 (pos_visible_p, face_before_or_after_it_pos)
1475 (back_to_previous_visible_line_start)
1476 (move_it_in_display_line_to, move_it_in_display_line)
1477 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1478 (try_scrolling, redisplay_window, display_line): Use them when
1479 saving a temporary copy of the iterator and restoring it back.
1480 (back_to_previous_visible_line_start, reseat_1)
1481 (init_iterator): Empty the bidi cache "stack".
1482 (move_it_in_display_line_to): If iterator ended up at
1483 EOL, but we never saw any buffer positions smaller than
1484 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
1485 motion in bidi-reordered lines.
1486 (move_it_in_display_line_to): Record prev_method and prev_pos
1487 immediately before the call to set_iterator_to_next. Fixes cursor
1488 motion in bidi-reordered lines with stretch glyphs and strings
1489 displayed in margins. (Bug#8133) (Bug#8867)
1490 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
1491 TO_CHARPOS.
640c8776
SM
1492 (pos_visible_p): Support positions in bidi-reordered lines.
1493 Save and restore bidi cache.
0bb23927
EZ
1494
1495 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
1496 (bidi_paragraph_info): Delete unused struct.
1497 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
1498 (bidi_cache_start): New variable.
1499 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
1500 to zero.
1501 (bidi_cache_fetch_state, bidi_cache_search)
1502 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1503 (bidi_cache_find, bidi_peek_at_next_level)
1504 (bidi_level_of_next_char, bidi_find_other_level_edge)
1505 (bidi_move_to_visually_next): Compare cache index with
1506 bidi_cache_start rather than with zero.
1507 (bidi_fetch_char): Accept new argument STRING; all callers
1508 changed. Support iteration over a string. Support strings with
1509 display properties. Support unibyte strings. Fix the type of
1510 `len' according to what STRING_CHAR_AND_LENGTH expects.
1511 (bidi_paragraph_init, bidi_resolve_explicit_1)
1512 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
1513 (bidi_level_of_next_char, bidi_move_to_visually_next):
1514 Support iteration over a string.
0bb23927
EZ
1515 (bidi_set_sor_type, bidi_resolve_explicit_1)
1516 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
1517 can now be zero (for strings); special values 0 and -1 were
1518 changed to -1 and -2, respectively.
1519 (bidi_char_at_pos): New function.
1520 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
1521 Call it instead of FETCH_MULTIBYTE_CHAR.
1522 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
1523 initialized to valid values.
1524 (bidi_init_it): Don't initialize charpos and bytepos with invalid
1525 values.
1526 (bidi_level_of_next_char): Allow the sentinel "position" to pass
1527 the test for valid cached positions. Fix the logic for looking up
1528 the sentinel state in the cache. GCPRO the Lisp string we are
1529 iterating.
1530 (bidi_push_it, bidi_pop_it): New functions.
1531 (bidi_initialize): Initialize the bidi cache start stack pointer.
1532 (bidi_cache_ensure_space): New function, refactored from part of
1533 bidi_cache_iterator_state. Don't assume the required size is just
1534 one BIDI_CACHE_CHUNK away.
1535 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
1536 (bidi_count_bytes, bidi_char_at_pos): New functions.
1537 (bidi_cache_search): Don't assume bidi_cache_last_idx is
1538 always valid if bidi_cache_idx is valid.
1539 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
1540 is valid if it's going to be used.
1541 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
1542 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
1543 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1544 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
1545 (bidi_find_other_level_edge, bidi_cache_start_stack):
1546 All variables related to cache indices are now EMACS_INT.
c965adc5 1547
0bb23927
EZ
1548 * dispextern.h (struct bidi_string_data): New structure.
1549 (struct bidi_it): New member `string'. Make flag members be 1-bit
1550 fields, and put them last in the struct.
640c8776
SM
1551 (compute_display_string_pos, compute_display_string_end):
1552 Update prototypes.
0bb23927
EZ
1553 (bidi_push_it, bidi_pop_it): Add prototypes.
1554 (struct iterator_stack_entry): New members bidi_p,
1555 paragraph_embedding, and from_disp_prop_p.
1556 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
1557 (bidi_shelve_cache, bidi_unshelve_cache):
1558 Declare prototypes.
0bb23927
EZ
1559
1560 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
1561 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1562 and vector-like objects.
1563
1564 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1565 cache around display iteration.
1566
1567 * window.c (Fwindow_end, window_scroll_pixel_based)
1568 (displayed_window_lines, Frecenter): Save and restore the bidi
1569 cache around display iteration.
1570
3bbd2265
LMI
15712011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1572
1573 * editfns.c (Fdelete_region): Clarify the use of the named
1574 parameters (bug#6788).
1575
adc47434
MR
15762011-07-14 Martin Rudalics <rudalics@gmx.at>
1577
1578 * indent.c (Fvertical_motion): Set and restore w->pointm when
1579 saving and restoring the window's buffer (Bug#9006).
1580
837c31f8
LMI
15812011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1582
1583 * editfns.c (Fstring_to_char): Clarify just what is returned
1584 (bug#6576). Text by Eli Zaretskii.
1585
ac389d0c
JB
15862011-07-13 Juanma Barranquero <lekktu@gmail.com>
1587
1588 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1589
0be0ce47
EZ
15902011-07-13 Eli Zaretskii <eliz@gnu.org>
1591
1592 * buffer.c (mmap_find): Fix a typo.
1593
cd18e7e3
JB
15942011-07-13 Johan Bockgård <bojohan@gnu.org>
1595
1596 Fix execution of x selection hooks.
1597 * xselect.c (Qx_lost_selection_functions)
1598 (Qx_sent_selection_functions): New vars.
1599 (syms_of_xselect): DEFSYM them.
1600 (x_handle_selection_request): Pass Qx_sent_selection_functions
1601 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1602 (x_handle_selection_clear,x_clear_frame_selections):
1603 Pass Qx_lost_selection_functions rather than
1604 Vx_lost_selection_functions to Frun_hook_with_args.
1605
47ea7f44
PE
16062011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1607
ac389d0c 1608 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
1609 The old code sometimes used this field without initializing it.
1610
47ea7f44
PE
1611 * alloc.c (gc_sweep): Don't read past end of array.
1612 In theory, the old code could also have corrupted Emacs internals,
1613 though it'd be very unlikely.
1614
bc985c87
AS
16152011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1616
1617 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 1618 argument. (Bug#4026)
bc985c87 1619
0cf34688
LMI
16202011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1621
b3dadd76
LMI
1622 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
1623 key" (bug#4257).
1624
0cf34688
LMI
1625 * window.c (Fset_window_start): Doc fix (bug#4199).
1626 (Fset_window_hscroll): Ditto.
1627
270768cd
PE
16282011-07-12 Paul Eggert <eggert@cs.ucla.edu>
1629
077e3dda 1630 Fix minor new problems caught by GCC 4.6.1.
270768cd 1631 * term.c (init_tty): Remove unused local.
490011a6 1632 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 1633 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 1634 not used otherwise.
270768cd 1635
b1f58454
CY
16362011-07-12 Chong Yidong <cyd@stupidchicken.com>
1637
1638 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
1639
22b9578d
LMI
16402011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1641
6e70ab07
LMI
1642 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
1643 are the mini-buffer and the echo area (bug#3320).
1644
22b9578d
LMI
1645 * term.c (init_tty): Remove support for supdup, c10 and perq
1646 terminals, which are no longer supported (bug#1482).
1647
8974cc9f
JB
16482011-07-10 Johan Bockgård <bojohan@gnu.org>
1649
1650 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
1651
a560d974
JD
16522011-07-10 Jan Djärv <jan.h.d@swipnet.se>
1653
1654 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
1655 for non-popups (Bug#3642).
1656
1dae0f0a
AS
16572011-07-10 Andreas Schwab <schwab@linux-m68k.org>
1658
268c2c36 1659 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 1660 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
1661 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
1662 * cm.c (losecursor): Likewise.
1dae0f0a
AS
1663 * data.c (fmod): Likewise.
1664 * dispnew.c (swap_glyphs_in_rows): Likewise.
1665 * emacs.c (memory_warning_signal): Likewise.
1666 * floatfns.c (float_error): Likewise.
1667 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
1668 (otf_open, font_otf_capability, generate_otf_features)
1669 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
1670 Likewise.
1671 * image.c (pbm_read_file): Likewise.
1672 * indent.c (string_display_width): Likewise.
1673 * intervals.c (check_for_interval, search_for_interval)
1674 (inc_interval_count, count_intervals, root_interval)
1675 (adjust_intervals_for_insertion, make_new_interval): Likewise.
1676 * lread.c (defalias): Likewise.
268c2c36 1677 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
1678 * regex.c (set_image_of_range_1, set_image_of_range)
1679 (regex_grow_registers): Likewise.
1680 * sysdep.c (strerror): Likewise.
1681 * termcap.c (valid_filename_p, tprint, main): Likewise.
1682 * tparam.c (main): Likewise.
1683 * unexhp9k800.c (run_time_remap, save_data_space)
1684 (update_file_ptrs, read_header, write_header, calculate_checksum)
1685 (copy_file, copy_rest, display_header): Likewise.
1686 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
1687 Likewise.
1688 * xdisp.c (check_it): Likewise.
1689 * xfaces.c (register_color, unregister_color, unregister_colors):
1690 Likewise.
1691 * xfns.c (print_fontset_result): Likewise.
1692 * xrdb.c (member, fatal, main): Likewise.
1693
99033785
PE
16942011-07-10 Paul Eggert <eggert@cs.ucla.edu>
1695
1696 Fix minor problems found by static checking (Bug#9031).
1697 * chartab.c (char_table_set_range, map_sub_char_table):
1698 Remove unused locals.
1699 (uniprop_table): Now static.
1700 * composite.c (_work_char): Remove unused static var.
1701
9cb2ac56
JB
17022011-07-09 Juanma Barranquero <lekktu@gmail.com>
1703
1704 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
1705
f25661f0
JD
17062011-07-09 Jan Djärv <jan.h.d@swipnet.se>
1707
1708 * gtkutil.c (qttip_cb): Remove code without function.
1709
8278c4fe
EZ
17102011-07-09 Eli Zaretskii <eliz@gnu.org>
1711
1712 * w32.c (pthread_sigmask): New stub.
1713
1692ae2d 17142011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 1715
8a6ebd58 1716 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
1717 sigprocmask is portable only for single-threaded applications, and
1718 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
1719 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
1720 (LIBES): Use it.
1721 * callproc.c (Fcall_process):
1722 * process.c (create_process):
1723 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
1724 Use pthread_sigmask, not sigprocmask.
123403e4 1725
1b854618
JD
17262011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1727
1728 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
1729 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
1730 wrong (Bug#8591).
1731
3fe4b549
JD
17322011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1733
0ce7e563
JD
1734 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
1735 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
1736 (xg_hide_tooltip): Fix comment.
1737
3fe4b549
JD
1738 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
1739 in registerServicesMenuSendTypes.
1740 (validRequestorForSendType): Don't check ns_return_types.
1741
1742 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
1743 ns_return_type.
1744
5df75e47
JR
17452011-07-08 Jason Rumney <jasonr@gnu.org>
1746
1747 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
1748 frame struct members of non-existent frames (Bug#6284).
1749
699c10bd
JD
17502011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1751
4393663b
JD
1752 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
1753 variable firstTime not needed on OSX >= 10.6.
1754 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
1755 >= 10.5. Use setKnobProportion, setDoubleValue.
1756
1757 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
1758 (MAC_OS_X_VERSION_10_5): Define if not defined.
1759 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
1760 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
1761 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
1762
1763 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
1764 cString and lossyCString on OSX >= 10.4
1765
1766 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
1767 sizeToFit on OSX >= 10.2.
1768
1769 * nsimage.m (allocInitFromFile): Don't use deprecated method
1770 bestRepresentationForDevice on OSX >= 10.6.
1771
1772 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
1773 to avoid warning.
1774
1775 * emacs.c: Declare unexec_init_emacs_zone.
1776
a63e0781
JD
1777 * nsgui.h: Fix compiler warning about gnulib redefining verify.
1778
699c10bd
JD
1779 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
1780
1781 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
1782 on svcsMenu (Bug#8842).
1783
1784 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
1785 ns_return_types.
1786 (Fns_list_services): Just return Qnil on 10.6, code not working there.
1787
1788 * nsterm.m (QUTF8_STRING): Declare.
1789 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
1790 (validRequestorForSendType): Return type is (id).
1791 Change indexOfObjectIdenticalTo to indexOfObject.
1792 Check if we have local selection before returning self (Bug#8842).
1793 (writeSelectionToPasteboard): Put local selection into paste board
1794 if we have a local selection (Bug#8842).
1795 (syms_of_nsterm): DEFSYM QUTF8_STRING.
1796
1797 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
1798 (ns_get_local_selection): Declare.
1799
54e10184
LMI
18002011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
1801
9888ff71
LMI
1802 * keymap.c (describe_map_tree): Don't insert a double newline at
1803 the end of the buffer (bug#1169) and return whether we inserted
1804 something.
1805
54e10184
LMI
1806 * callint.c (Fcall_interactively): Change "reading args" to
1807 "providing args" to try to clarify what it does (bug#1010).
1808
15fa4783
KH
18092011-07-07 Kenichi Handa <handa@m17n.org>
1810
1811 * composite.c (composition_compute_stop_pos): Ignore a static
1812 composition starting before CHARPOS (Bug#8915).
1813
1814 * xdisp.c (handle_composition_prop): Likewise.
1815
a8815b00
EZ
18162011-07-07 Eli Zaretskii <eliz@gnu.org>
1817
1818 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1819 (Bug#9015)
1820
ef7b981d 18212011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
1822
1823 * character.h (unicode_category_t): New enum type.
1824
1825 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1826 (Qchar_code_property_table): New variable.
1827 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1828 (UNIPROP_COMPRESSED_FORM_P): New macros.
1829 (char_table_ascii): Uncompress the compressed values.
1830 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1831 Uncompress the compressed values.
ac389d0c 1832 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
1833 (char_table_ref_and_range): Uncompress the compressed values.
1834 (sub_char_table_set): New arg is_uniprop. Callers changed.
1835 Uncompress the compressed values.
1836 (sub_char_table_set_range): Args changed. Callers changed.
1837 (char_table_set_range): Adjuted for the above change.
1838 (map_sub_char_table): Delete args default_val and parent. Add arg
1839 top. Give decoded values to a Lisp function.
640c8776 1840 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
1841 values to a Lisp function. Gcpro more variables.
1842 (uniprop_table_uncompress)
1843 (uniprop_decode_value_run_length): New functions.
1844 (uniprop_decoder, uniprop_decoder_count): New variables.
1845 (uniprop_get_decoder, uniprop_encode_value_character)
1846 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1847 New functions.
1848 (uniprop_encoder, uniprop_encoder_count): New variables.
1849 (uniprop_get_encoder, uniprop_table)
1850 (Funicode_property_table_internal, Fget_unicode_property_internal)
1851 (Fput_unicode_property_internal): New functions.
1852 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1853 Sunicode_property_table_internal, Sget_unicode_property_internal,
1854 and Sput_unicode_property_internal. Defvar_lisp
1855 char-code-property-alist.
1856
640c8776 1857 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
1858 Vunicode_category_table.
1859
640c8776 1860 * font.c (font_range): Adjust for the change of
c805dec0
KH
1861 Vunicode_category_table.
1862
76b397fb
DN
18632011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1864
1865 * m/iris4d.h: Remove file, move contents ...
1866 * s/irix6-5.h: ... here.
1867
22b4128e
PE
18682011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1869
1870 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
1871 * alloc.c (mark_buffer):
1872 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1873 (clone_per_buffer_values): Don't assume that
22b4128e
PE
1874 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1875 This isn't true in general, and it's particularly not true
1876 if Emacs is configured with --with-wide-int.
1877 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1878 New macros, used in the buffer.c change.
1879
869795d6
JD
18802011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1881
1882 * xsettings.c: Use both GConf and GSettings if both are available.
1883 (store_config_changed_event): Add comment.
1884 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1885 (store_tool_bar_style_changed): New functions.
1886 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1887 (struct xsettings): Move font inside HAVE_XFT.
1888 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 1889 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 1890 Move inside HAVE_XFT.
640c8776 1891 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
1892 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1893 also.
1894 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
640c8776
SM
1895 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1896 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
1897 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1898 (parse_settings): Move check for font inside HAVE_XFT.
1899 (read_settings, apply_xft_settings): Add comment.
1900 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1901 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1902 call store_font_name_changed.
1903 (xft_settings_event): Add comment.
1904 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1905 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1906 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1907 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1908 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
1909 (xsettings_get_system_font, xsettings_get_system_normal_font):
1910 Add comment.
869795d6 1911
d8ed26bd
PE
19122011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1913
1914 Random fixes. E.g., (random) never returned negative values.
1915 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1916 subseconds part to the entropy, as that's a bit more random.
1917 Prefer signed to unsigned, since the signedness doesn't matter and
1918 in general we prefer signed. When given a limit, use a
1919 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1920 latter isn't right if USE_2_TAGS_FOR_INTS.
1921 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1922 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1923
cabf1cac
SM
19242011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1925
1926 * textprop.c (text_property_stickiness):
1927 Obey Vtext_property_default_nonsticky.
1928 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1929 * w32fns.c (syms_of_w32fns):
1930 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1931
6e9b2be9
PE
19322011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1933
1934 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1935 This is more efficient than Ffile_directory_p and avoids a minor race.
1936
90186c68
LMI
19372011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1938
7c301272
LMI
1939 * buffer.c (Foverlay_put): Say what the return value is
1940 (bug#7835).
1941
c4f2d8d4
LMI
1942 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1943 is a directory before asking whether to use the file name
1944 (bug#7564).
ad637907
LMI
1945 (barf_or_query_if_file_exists): Make the "File is a directory"
1946 error be more correct.
c4f2d8d4 1947
90186c68
LMI
1948 * fns.c (Frequire): Remove the mention of the .gz files, since
1949 that's installation-specific, but keep the mention of
1950 `get-load-suffixes'.
1951
da64016e
PE
19522011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1953
1954 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1955 Report string overflow if the output is too long.
1956
7d47b580
JB
19572011-07-04 Juanma Barranquero <lekktu@gmail.com>
1958
a555cb87
JB
1959 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1960 (syms_of_gnutls): Remove duplicate DEFSYM for
1961 Qgnutls_bootprop_verify_hostname_error, an error for
1962 Qgnutls_bootprop_verify_error (which is no longer used).
1963
7d47b580
JB
1964 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1965 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1966 Also (re)move comments that are misplaced or no longer relevant.
1967
1e49bfab
LMI
19682011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1969
1970 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1971
1485f4c0
CY
19722011-07-03 Chong Yidong <cyd@stupidchicken.com>
1973
1974 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1975 and background color parameters if they have been changed.
1976
a9ab721e
LMI
19772011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1978
1979 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1980
cf7cff57
PE
19812011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1982
2e13213d
PE
1983 * xsettings.c (SYSTEM_FONT): Define only when used.
1984 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1985
cf7cff57
PE
1986 * keymap.c (access_keymap_1): Now static.
1987
7a8e04f7
CY
19882011-07-02 Chong Yidong <cyd@stupidchicken.com>
1989
1990 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1991 leave any prefix arg for the up event (Bug#1586).
1992
61352f62
LMI
19932011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1994
69bb1ef7
LMI
1995 * lread.c (syms_of_lread): Mention single symbols defined by
1996 `defvar' or `defconst' (bug#7154).
1997
61352f62 1998 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 1999 (Frequire): Mention get-load-suffixes.
61352f62 2000
28545e04
MR
20012011-07-02 Martin Rudalics <rudalics@gmx.at>
2002
2003 * window.h (window): Remove clone_number slot.
2004 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2005 Remove.
2006 (make_parent_window, make_window, saved_window)
2007 (Fset_window_configuration, save_window_save): Don't deal with
2008 clone numbers.
2009 * buffer.c (Qclone_number): Remove declaration.
2010 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2011
3349e122
SM
20122011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2013
2014 Add multiple inheritance to keymaps.
2015 * keymap.c (Fmake_composed_keymap): New function.
2016 (Fset_keymap_parent): Simplify.
2017 (fix_submap_inheritance): Remove.
2018 (access_keymap_1): New function extracted from access_keymap to handle
2019 embedded parents and handle lists of maps.
2020 (access_keymap): Use it.
2021 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2022 (Fcopy_keymap): Handle embedded parents.
2023 (Fcommand_remapping, define_as_prefix): Simplify.
2024 (Fkey_binding): Simplify.
2025 (syms_of_keymap): Move minibuffer-local-completion-map,
2026 minibuffer-local-filename-completion-map,
2027 minibuffer-local-must-match-map, and
2028 minibuffer-local-filename-must-match-map to Elisp.
2029 (syms_of_keymap): Defsubr make-composed-keymap.
2030 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2031 (parse_menu_item): Trivial simplification.
2032
3279eb87
GM
20332011-07-01 Glenn Morris <rgm@gnu.org>
2034
2035 * Makefile.in (SETTINGS_LIBS): Fix typo.
2036
4550efdf
KI
20372011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2038
2039 * coding.c (Fencode_coding_string): Record the last coding system
2040 used, as the function doc string says (bug#8738).
2041
0949d2b6
JD
20422011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2043
2044 * xsettings.c (store_monospaced_changed): Take new font as arg and
2045 check for change against current_mono_font.
2046 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2047 (emacs_settings_constructor, emacs_settings_get_property)
2048 (emacs_settings_set_property, emacs_settings_class_init)
2049 (emacs_settings_init, gsettings_obj): Remove.
2050 (something_changedCB): New function for HAVE_GSETTINGS.
2051 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2052 with value as argument.
2053 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2054 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 2055 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
2056 "changed".
2057
2058 * xgselect.c: Add defined (HAVE_GSETTINGS).
2059 (xgselect_initialize): Ditto.
2060
2061 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2062 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2063 xg_select.
2064
bbc6b304
PE
20652011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2066
2067 * eval.c (struct backtrace): Simplify and port the data structure.
2068 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2069 signed bit field, as this assumption is not portable and it makes
2070 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2071 "char debug_on_exit : 1" as this is not portable either; instead,
2072 use the portable "unsigned int debug_on_exit : 1". Remove unused
2073 member evalargs. Remove obsolete comments about cc bombing out.
2074
9851bfc5
JD
20752011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2076
51bb811f 2077 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
2078 Let HAVE_GSETTINGS override HAVE_GCONF.
2079 (store_monospaced_changed): New function.
2080 (EMACS_SETTINGS): A new type derived from GObject to handle
2081 GSettings notifications.
2082 (emacs_settings_constructor, emacs_settings_get_property)
2083 (emacs_settings_set_property, emacs_settings_class_init):
2084 New functions.
2085 (gsettings_client, gsettings_obj): New variables.
2086 (GSETTINGS_SCHEMA): New define.
2087 (something_changedCB): Call store_monospaced_changed.
2088 (init_gsettings): New function.
2089 (xsettings_initialize): Call init_gsettings.
2090 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2091 to NULL.
2092
640c8776 2093 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
2094 GCONF_CFLAGS/LIBS.
2095
5386012d
MR
20962011-06-29 Martin Rudalics <rudalics@gmx.at>
2097
2098 * window.c (resize_root_window, grow_mini_window)
2099 (shrink_mini_window): Rename Qresize_root_window to
2100 Qwindow_resize_root_window and Qresize_root_window_vertically to
2101 Qwindow_resize_root_window_vertically.
2102
f13e0b08
PE
21032011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2104
2105 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2106
94515237
JB
21072011-06-27 Juanma Barranquero <lekktu@gmail.com>
2108
2109 * makefile.w32-in: Redesign dependencies so they reflect more
2110 clearly which files are directly included by each source file,
2111 and not through other includes.
2112
e43b6e43
MR
21132011-06-27 Martin Rudalics <rudalics@gmx.at>
2114
2115 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2116 (sort_overlays, overlay_strings): When an overlay's clone number
2117 matches the window's clone number process the overlay even if
2118 the overlay's window property doesn't match the current window.
2119
d68443dc
MR
2120 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2121 (Fwindow_hchild): Rename to Fwindow_left_child.
2122 (Fwindow_next): Rename to Fwindow_next_sibling.
2123 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
2124 (resize_window_check): Rename to window_resize_check.
2125 (resize_window_apply): Rename to window_resize_apply.
2126 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2127 (Fdelete_other_windows_internal, resize_frame_windows)
2128 (Fsplit_window_internal, Fdelete_window_internal)
2129 (grow_mini_window, shrink_mini_window)
2130 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 2131
c7e73be5
JD
21322011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2133
2134 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2135 (emacs_fixed_set_min_size): Remove.
2136 (emacs_fixed_new): Take frame as argument.
2137
2138 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2139 (_EmacsFixedPrivate): Remove minwidth/height.
2140 Add struct frame *f.
2141 (emacs_fixed_init): Initialize priv->f.
2142 (get_parent_class, emacs_fixed_set_min_size): Remove.
2143 (emacs_fixed_new): Set priv->f to argument.
2144 (emacs_fixed_get_preferred_width)
2145 (emacs_fixed_get_preferred_height): Use min_width/height from
2146 frames size_hint to set minimum and natural (Bug#8919).
2147 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2148 and use min_width/height from frames size_hint to set
2149 min_width/height (Bug#8919).
2150
2151 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
2152 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2153 Fix indentation.
c7e73be5 2154
cf99dcf8
EZ
21552011-06-26 Eli Zaretskii <eliz@gnu.org>
2156
2157 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2158 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2159 called at ZV.
2160
029529ac
CY
21612011-06-26 Chong Yidong <cyd@stupidchicken.com>
2162
2163 * process.c (wait_reading_process_output): Bypass select if
2164 waiting for a cell while ignoring keyboard input, and input is
2165 pending. Suggested by Jan Djärv (Bug#8869).
2166
7a7ef429
PE
21672011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2168
2169 Use gnulib's dup2 module instead of rolling our own.
2170 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2171
11fdef7d 21722011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
2173
2174 * dispnew.c (scrolling_window): Before scrolling, turn off a
2175 mouse-highlight in the window being scrolled.
2176
cd3520a4
JB
21772011-06-24 Juanma Barranquero <lekktu@gmail.com>
2178
2179 Move DEFSYM to lisp.h and use everywhere.
2180
2181 * character.h (DEFSYM): Move declaration...
2182 * lisp.h (DEFSYM): ...here.
2183
2184 * gnutls.c:
2185 * minibuf.c:
2186 * w32menu.c:
2187 * w32proc.c:
2188 * w32select.c: Don't include character.h.
2189
2190 * alloc.c (syms_of_alloc):
2191 * buffer.c (syms_of_buffer):
2192 * bytecode.c (syms_of_bytecode):
2193 * callint.c (syms_of_callint):
2194 * casefiddle.c (syms_of_casefiddle):
2195 * casetab.c (init_casetab_once):
2196 * category.c (init_category_once, syms_of_category):
2197 * ccl.c (syms_of_ccl):
2198 * cmds.c (syms_of_cmds):
2199 * composite.c (syms_of_composite):
2200 * dbusbind.c (syms_of_dbusbind):
2201 * dired.c (syms_of_dired):
2202 * dispnew.c (syms_of_display):
2203 * doc.c (syms_of_doc):
2204 * editfns.c (syms_of_editfns):
2205 * emacs.c (syms_of_emacs):
2206 * eval.c (syms_of_eval):
2207 * fileio.c (syms_of_fileio):
2208 * fns.c (syms_of_fns):
2209 * frame.c (syms_of_frame):
2210 * fringe.c (syms_of_fringe):
2211 * insdel.c (syms_of_insdel):
2212 * keymap.c (syms_of_keymap):
2213 * lread.c (init_obarray, syms_of_lread):
2214 * macros.c (syms_of_macros):
2215 * msdos.c (syms_of_msdos):
2216 * print.c (syms_of_print):
2217 * process.c (syms_of_process):
2218 * search.c (syms_of_search):
2219 * sound.c (syms_of_sound):
2220 * syntax.c (init_syntax_once, syms_of_syntax):
2221 * terminal.c (syms_of_terminal):
2222 * textprop.c (syms_of_textprop):
2223 * undo.c (syms_of_undo):
2224 * w32.c (globals_of_w32):
2225 * window.c (syms_of_window):
2226 * xdisp.c (syms_of_xdisp):
2227 * xfaces.c (syms_of_xfaces):
2228 * xfns.c (syms_of_xfns):
2229 * xmenu.c (syms_of_xmenu):
2230 * xsettings.c (syms_of_xsettings):
2231 * xterm.c (syms_of_xterm): Use DEFSYM.
2232
4228cf16
TZ
22332011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2234
cd3520a4 2235 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 2236
7fcccf1e
PE
22372011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2238
7efb4e0e
PE
2239 Integer and buffer overflow fixes (Bug#8873).
2240
ff5844ad
PE
2241 * print.c (printchar, strout): Check for string overflow.
2242 (PRINTPREPARE, printchar, strout):
2243 Don't set size unless allocation succeeds.
2244
90532f02
PE
2245 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2246 for sizes. Check for string overflow more accurately.
2247 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2248
6d84508d
PE
2249 * macros.c: Integer and buffer overflow fixes.
2250 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2251 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2252 Use ptrdiff_t, not int, for sizes.
2253 Don't increment bufsize until after realloc succeeds.
2254 Check for size-calculation overflow.
2255 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2256
437b2cb4
PE
2257 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2258
8b9ac8b4
PE
2259 * lread.c: Integer overflow fixes.
2260 (read_integer): Radix is now EMACS_INT, not int,
2261 to improve quality of diagnostics for out-of-range radices.
2262 Calculate buffer size correctly for out-of-range radices.
2263 (read1): Check for integer overflow in radices, and in
2264 read-circle numbers.
82cb60d3
PE
2265 (read_escape): Avoid int overflow.
2266 (Fload, openp, read_buffer_size, read1)
2267 (substitute_object_recurse, read_vector, read_list, map_obarray):
2268 Use ptrdiff_t, not int, for sizes.
2269 (read1): Use EMACS_INT, not int, for sizes.
20270765 2270 Check for size overflow.
8b9ac8b4 2271
7fcccf1e
PE
2272 * image.c (cache_image): Check for size arithmetic overflow.
2273
bfbbd7e7
PE
2274 * lread.c: Integer overflow issues.
2275 (saved_doc_string_size, saved_doc_string_length)
2276 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2277 Now ptrdiff_t, not int.
2278 (read1): Don't assume doc string length fits in int. Check for
2279 out-of-range doc string lengths.
2280 (read_list): Don't assume file position fits in int.
39019e54 2281 (read_escape): Check for hex character overflow.
bfbbd7e7 2282
4e323265
LL
22832011-06-22 Leo Liu <sdl.web@gmail.com>
2284
2285 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2286 Move to minibuffer.el.
2287
85fece3e
PE
22882011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2289
20b84ce9 2290 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
2291 The following patches are for when GLYPH_DEBUG && !XASSERT.
2292 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2293 * dispnew.c (flush_stdout):
2294 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2295 Mark as externally visible.
2296 * dispnew.c (check_window_matrix_pointers): Now static.
2297 * dispnew.c (window_to_frame_vpos):
2298 * xfns.c (unwind_create_frame):
2299 * xterm.c (x_check_font): Remove unused local.
2300 * scroll.c (CHECK_BOUNDS):
2301 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2302 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2303 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2304 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2305 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2306 Now static.
2307 (debug_method_add): Use va_list and vsprintf rather than relying
2308 on undefined behavior with wrong number of arguments.
2309 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2310 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2311 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2312 since we're not interested in debugging glyphs with old libraries.
2313 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2314 GCC 4.6.0's static checking.
2315
0766b489
PE
23162011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2317
31fd4b32
PE
2318 Integer overflow and signedness fixes (Bug#8873).
2319 A few related buffer overrun fixes, too.
2320
b79e8648
PE
2321 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2322
0766b489
PE
2323 * dispextern.h (struct face.stipple):
2324 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2325 (x_bitmap_mask, x_allocate_bitmap_record)
2326 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2327 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2328 (x_create_bitmap_from_xpm_data):
2329 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2330 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2331 (.bitmaps_last):
2332 * xfaces.c (load_pixmap):
2333 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2334 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2335 (.bitmaps_last, struct x_output.icon_bitmap):
2336 Use ptrdiff_t, not int, for bitmap indexes.
2337 (x_allocate_bitmap_record): Check for size overflow.
2338 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2339
b081724f
PE
2340 Use ptrdiff_t, not int, for overlay counts.
2341 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2342 * editfns.c (overlays_around, get_pos_property):
2343 * textprop.c (get_char_property_and_overlay):
2344 * xdisp.c (next_overlay_change, note_mouse_highlight):
2345 * xfaces.c (face_at_buffer_position):
21514da7
PE
2346 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2347 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2348 (Fnext_overlay_change, Fprevious_overlay_change)
2349 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 2350 Use ptrdiff_t, not int, for sizes.
21514da7 2351 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 2352
3de73e5e
PE
2353 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2354
2606c57b
PE
2355 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2356 (x_session_initialize): Do not assume string length fits in int.
2357
aaafe47a
PE
2358 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2359 This is unlikely, but can occur if DPI is outlandish.
2360
2674ddc8 2361 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
2362 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2363
28154962
PE
2364 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2365 * xrdb.c (magic_file_p, search_magic_path):
2366 Omit last arg SUFFIX; it was always 0. All callers changed.
2367 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2368
7de51af5
PE
2369 * xfont.c (xfont_match): Avoid need for strlen.
2370
25ed6cc3
PE
2371 * xfns.c: Don't assume strlen fits in int.
2372 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2373
4eab31dd
PE
2374 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2375 not unsigned long, as we prefer signed integers. All callers changed.
2376 Detect integer overflow in repeat count.
2377 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 2378 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 2379
171e2a58
PE
2380 * termcap.c: Don't assume sizes fit in int and never overflow.
2381 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2382 (gobble_line): Check for size-calculation overflow.
2383
ad39faca 2384 * minibuf.c (Fread_buffer):
6e5bb2dc 2385 * lread.c (intern, intern_c_string):
74ca2eb3
PE
2386 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2387 Don't assume string length fits in int.
2388
52c61c22 2389 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
2390 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2391
b5b8c9e5
PE
2392 * font.c: Don't assume string length fits in int.
2393 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2394 Use ptrdiff_t, not int.
ccd6111c
PE
2395 (font_intern_prop): Don't assume string length fits in int.
2396 Don't assume integer property fits in fixnum.
2397 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 2398
882f0d81 2399 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 2400 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
2401 Reformulate so as not to need the command string.
2402 Invoke gzip -cd rather than gunzip, as it's more portable.
2403 (lock_info_type, lock_file_1, lock_file):
2404 Don't assume pid_t and time_t fit in unsigned long.
2405 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
2406 (current_lock_owner): Prefer signed type for sizes.
2407 Use memcpy, not strncpy, where memcpy is what is really wanted.
2408 Don't assume (via atoi) that time_t and pid_t fit in int.
2409 Check for time_t and/or pid_t out of range, e.g., via a network share.
2410 Don't alloca where an auto var works fine.
2411
93f4cf88
PE
2412 * fileio.c: Fix some integer overflow issues.
2413 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
2414 Don't assume string length fits in int.
2415 (directory_file_name): Don't assume string length fits in long.
2416 (make_temp_name): Don't assume pid fits in int, or that its print
2417 length is less than 20.
2418
f3e92b69
PE
2419 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
2420
1bfdaf10
PE
2421 * coding.c (make_subsidiaries): Don't assume string length fits in int.
2422
35016e9a
PE
2423 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
2424
3d1e65a1
PE
2425 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
2426 We prefer signed integers, even for size calculations.
2427
0b963a93
PE
2428 * emacs.c: Don't assume string length fits in 'int'.
2429 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
2430 (main): Don't invoke strlen when not needed.
2431
573f4b54
PE
2432 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
2433 (XD_DEBUG_MESSAGE): Don't waste a byte.
2434
989f33ba
PE
2435 * callproc.c (getenv_internal_1, getenv_internal)
2436 (Fgetenv_internal):
965d34eb
PE
2437 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
2438
e4d29b33
PE
2439 * lread.c (invalid_syntax): Omit length argument.
2440 All uses changed. This doesn't fix a bug, but it simplifies the
2441 code away from its former Hollerith-constant appearance, and it's
2442 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 2443 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 2444
eb49b136
PE
2445 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
2446 This didn't break anything, but it didn't help either.
2447 It's confusing to put a bogus integer in a place where the actual
2448 value does not matter.
9f62aeb1 2449 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 2450 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 2451
15375a22
PE
2452 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
2453 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
2454 implementation.
b61cc01c
PE
2455 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
2456 We prefer signed types, and the value cannot exceed the EMACS_INT
2457 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
2458 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
2459 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
2460 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 2461
53b2623d
PE
2462 * indent.c (sane_tab_width): New function.
2463 (current_column, scan_for_column, Findent_to, position_indentation)
2464 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 2465 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 2466
51cab52b 2467 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 2468
f2ed8a70
PE
2469 * lisp.h (lint_assume): New macro.
2470 * composite.c (composition_gstring_put_cache):
2471 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
2472
abe80cc6
PE
2473 * editfns.c, insdel.c:
2474 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 2475
b02c740e
PE
2476 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
2477
ebc96716
PE
2478 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
2479
b4e50fa0 2480 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 2481 Use much-faster test for byte-length change.
311d5d7c 2482 Don't assume string byte-length fits in 'int'.
a4cf38e4 2483 Check that character arg fits in 'int'.
85461888 2484 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 2485
c0c1ee9f
PE
2486 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
2487
a498d7f4
PE
2488 * fns.c (concat): Catch string overflow earlier.
2489 Do not rely on integer wraparound.
2490
51cab52b
PE
2491 * dispextern.h (struct it.overlay_strings_charpos)
2492 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
2493 * xdisp.c (forward_to_next_line_start)
2494 (back_to_previous_visible_line_start)
2495 (reseat_at_next_visible_line_start, next_element_from_buffer):
2496 Don't arbitrarily truncate the value of 'selective' to int.
2497
76031fad
PE
2498 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
2499
5eb55db9
PE
2500 * composite.c: Don't truncate sizes to 'int'.
2501 (composition_gstring_p, composition_reseat_it)
2502 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
2503 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
2504 not EMACS_UINT, for indexes.
5eb55db9 2505
0703a717
PE
2506 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
2507
d6202519
PE
2508 * buffer.c: Include <verify.h>.
2509 (struct sortvec.priority, struct sortstr.priority):
8961a454 2510 Now EMACS_INT, not int.
c20998a7 2511 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
2512 (struct sortstr.size, record_overlay_string)
2513 (struct sortstrlist.size, struct sortlist.used):
2514 Don't truncate size to int.
2515 (record_overlay_string): Check for size-calculation overflow.
d6202519 2516 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 2517
d5a19415
JM
25182011-06-22 Jim Meyering <meyering@redhat.com>
2519
029529ac 2520 Don't leak an XBM-image-sized buffer
d5a19415
JM
2521 * image.c (xbm_load): Free the image buffer after using it.
2522
a9041e6c
PE
25232011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2524
2525 Port to Sun C.
2526 * composite.c (find_automatic_composition): Omit needless 'return 0;'
2527 that Sun C diagnosed.
2528 * fns.c (secure_hash): Fix pointer signedness issue.
2529 * intervals.c (static_offset_intervals): New function.
2530 (offset_intervals): Use it.
2531
7f3f739f
LL
25322011-06-21 Leo Liu <sdl.web@gmail.com>
2533
2534 * deps.mk (fns.o):
2535 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
2536 sha512.h.
2537
2538 * fns.c (secure_hash): Rename from crypto_hash_function and change
2539 the first arg to accept symbols.
5b66d427 2540 (Fsecure_hash): New primitive.
7f3f739f
LL
2541 (syms_of_fns): New symbols.
2542
76147d94
DD
25432011-06-20 Deniz Dogan <deniz@dogan.se>
2544
2545 * process.c (Fset_process_buffer): Clarify return value in
2546 docstring.
2547
7d7d0045
CY
25482011-06-18 Chong Yidong <cyd@stupidchicken.com>
2549
2550 * dispnew.c (add_window_display_history): Use BVAR.
2551
2552 * xdisp.c (debug_method_add): Use BVAR.
2553 (check_window_end, dump_glyph_matrix, dump_glyph)
2554 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
2555
2556 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
2557 Likewise.
2558
2559 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
2560 check till after the cache is created in init_frame_faces.
2561
ff2bc410
SM
25622011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2563
2564 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2565
28177add
PE
25662011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2567
dd3482fe
PE
2568 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2569 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2570 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2571
393d71f3 2572 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
2573 * fileio.c (Finsert_file_contents):
2574 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2575 Remove the old (too-loose) buffer overflow checks.
2576 They weren't needed, since make_gap checks for buffer overflow.
2577 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2578 The old code merely checked for Emacs fixnum overflow, and relied
2579 on undefined (wraparound) behavior. The new code avoids undefined
2580 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2581
2e6813b0 2582 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
2583 Tune. Don't use wider integers than needed. Don't use alloca.
2584 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 2585
599a9e4f
PE
2586 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2587
99561444
PE
2588 * insdel.c, lisp.h (buffer_overflow): New function.
2589 (insert_from_buffer_1, replace_range, replace_range_2):
2590 * insdel.c (make_gap_larger):
2591 * editfns.c (Finsert_char):
2592 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2593
28177add
PE
2594 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2595
e69dafad
PE
25962011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2597
a7af7fde 2598 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 2599
b1c46f02
PE
2600 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2601 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2602
e69dafad
PE
2603 * fileio.c: Don't assume EMACS_INT fits in off_t.
2604 (emacs_lseek): New static function.
2605 (Finsert_file_contents, Fwrite_region): Use it.
2606 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2607
566684ea
PE
2608 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2609
e6966cd6
PE
2610 * fns.c: Don't overflow int when computing a list length.
2611 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2612 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2613 truncation on 64-bit hosts. Check for QUIT every
2614 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2615 faster and is responsive enough.
2616 (Flength): Report an error instead of overflowing an integer.
2617 (Fsafe_length): Return a float if the value is not representable
2618 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 2619 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 2620 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 2621
dd0b0efb
PE
2622 * alloc.c: Check that resized vectors' lengths fit in fixnums.
2623 (header_size, word_size): New constants.
2624 (allocate_vectorlike): Don't check size overflow here.
2625 (allocate_vector): Check it here instead, since this is the only
2626 caller of allocate_vectorlike that could cause overflow.
2627 Check that the new vector's length is representable as a fixnum.
2628
86fe5cfe
PE
2629 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
2630 The previous code was bogus. For example, next_almost_prime (32)
2631 returned 39, which is undesirable as it is a multiple of 3; and
2632 next_almost_prime (24) returned 25, which is a multiple of 5 so
2633 why was the code bothering to check for multiples of 7?
2634
80e88859
PE
2635 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
2636
4a2f0ad6
PE
2637 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
2638
f66c7cf8
PE
2639 Variadic C functions now count arguments with ptrdiff_t.
2640 This partly undoes my 2011-03-30 change, which replaced int with size_t.
2641 Back then I didn't know that the Emacs coding style prefers signed int.
2642 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
2643 were being counted with int, which may truncate counts on 64-bit
2644 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
2645 * lisp.h (struct Lisp_Subr.function.aMANY)
2646 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
2647 Arg counts are now ptrdiff_t, not size_t.
2648 All variadic functions and their callers changed accordingly.
2649 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
2650 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
2651 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
2652 * callint.c (Fcall_interactively): Check arg count for overflow,
2653 to avoid potential buffer overrun. Use signed char, not 'int',
2654 for 'varies' array, so that we needn't bother to check its size
2655 calculation for overflow.
2656 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
2657 * eval.c (apply_lambda):
2658 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
2659 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
2660 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
2661
a1759b76
PE
2662 * callint.c (Fcall_interactively): Don't use index var as event count.
2663
d96be9fc
PE
2664 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
2665 * mem-limits.h (SIZE): Remove; no longer used.
2666
a690a978 2667 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 2668
578c21e6
PE
2669 Remove unnecessary casts.
2670 * xterm.c (x_term_init):
2671 * xfns.c (x_set_border_pixel):
2672 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
2673 These aren't needed now that we assume ANSI C.
2674
96f53c6c
PE
2675 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
2676 It's more likely to cause problems (due to unsigned overflow)
2677 than to cure them.
2678
83c77d31
PE
2679 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
2680
ee2079f1
PE
2681 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
2682
6da65536
PE
2683 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
2684
7147c4a4
PE
2685 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
2686
193e32d9
PE
2687 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
2688
e5533da6
PE
2689 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
2690
9910e595
PE
2691 GLYPH_CODE_FACE returns EMACS_INT, not int.
2692 * dispextern.h (merge_faces):
2693 * xfaces.c (merge_faces):
01103c44
PE
2694 * xdisp.c (get_next_display_element, next_element_from_display_vector):
2695 Don't assume EMACS_INT fits in int.
9910e595 2696
2638320e
PE
2697 * character.h (CHAR_VALID_P): Remove unused parameter.
2698 * fontset.c, lisp.h, xdisp.c: All uses changed.
2699
045eb8d9
PE
2700 * editfns.c (Ftranslate_region_internal): Omit redundant test.
2701
c1f134b5
PE
2702 * fns.c (concat): Minor tuning based on overflow analysis.
2703 This doesn't fix any bugs. Use int to hold character, instead
2704 of constantly refetching from Emacs object. Use XFASTINT, not
2705 XINT, for value known to be a character. Don't bother comparing
2706 a single byte to 0400, as it's always less.
2707
395fcb93 2708 * floatfns.c (Fexpt):
327eeec8
PE
2709 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
2710
abbd3d23
PE
2711 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
2712 for characters.
2713
684a03ef
PE
2714 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
2715
0fed43f3
PE
2716 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
2717 Without this fix, on a 64-bit host (aset S 0 4294967386) would
2718 incorrectly succeed when S was a string, because 4294967386 was
2719 truncated before it was used.
2720
8fd02eb7
PE
2721 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
2722 Otherwise, an out-of-range integer could cause undefined behavior
2723 on a 64-bit host.
2724
f8c86b69
PE
2725 * composite.c: Use int, not EMACS_INT, for characters.
2726 (fill_gstring_body, composition_compute_stop_pos): Use int, not
2727 EMACS_INT, for values that are known to be in character range.
2728 This doesn't fix any bugs but is the usual style inside Emacs and
2729 may generate better code on 32-bit machines.
2730
34206dd2
PE
2731 Make sure a 64-bit char is never passed to ENCODE_CHAR.
2732 This is for reasons similar to the recent CHAR_STRING fix.
2733 * charset.c (Fencode_char): Check that character arg is actually
2734 a character. Pass an int to ENCODE_CHAR.
2735 * charset.h (ENCODE_CHAR): Verify that the character argument is no
2736 wider than 'int', as a compile-time check to prevent future regressions
2737 in this area.
2738
c5958d4c 2739 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
2740
2741 Make sure a 64-bit char is never passed to CHAR_STRING.
2742 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
2743 by silently ignoring the top 32 bits, allowing some values
2744 that were far too large to be valid characters.
2745 * character.h: Include <verify.h>.
2746 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
2747 arguments are no wider than unsigned, as a compile-time check
2748 to prevent future regressions in this area.
2749 * data.c (Faset):
01103c44 2750 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
2751 (Fsubst_char_in_region):
2752 * fns.c (concat):
2753 * xdisp.c (decode_mode_spec_coding):
2754 Adjust to CHAR_STRING's new requirement.
2755 * editfns.c (Finsert_char, Fsubst_char_in_region):
2756 * fns.c (concat): Check that character args are actually
2757 characters. Without this test, these functions did the wrong
2758 thing with wildly out-of-range values on 64-bit hosts.
2759
d37ca623
PE
2760 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
2761 These casts should not be needed on 32-bit hosts, either.
2762 * keyboard.c (read_char):
2763 * lread.c (Fload): Remove casts to unsigned.
2764
ea204efb
PE
2765 * lisp.h (UNSIGNED_CMP): New macro.
2766 This fixes comparison bugs on 64-bit hosts.
2767 (ASCII_CHAR_P): Use it.
2768 * casefiddle.c (casify_object):
01103c44 2769 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
2770 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
2771 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
2772 * dispextern.h (FACE_FROM_ID):
2773 * keyboard.c (read_char): Use UNSIGNED_CMP.
2774
41cb286c
PE
2775 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
2776 not to EMACS_INT, to avoid GCC warning.
2777
4a1b9832
PE
2778 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
2779
55daad71
PE
2780 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
2781 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
2782 isn't needed on 32-bit machines.
8f95c75c 2783
01103c44
PE
2784 * buffer.c (Fgenerate_new_buffer_name):
2785 Use EMACS_INT for count, not int.
0ceccced 2786 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
2787
2788 * data.c (Qcompiled_function): Now static.
2789
c6f072e7
PE
2790 * window.c (window_body_lines): Now static.
2791
20ce5912
PE
2792 * image.c (gif_load): Rename local to avoid shadowing.
2793
9c4c5f81
PE
2794 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
2795 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
2796 * alloc.c (make_save_value): Integer argument is now of type
2797 ptrdiff_t, not int.
2798 (mark_object): Use ptrdiff_t, not int.
2799 * lisp.h (pD): New macro.
2800 * print.c (print_object): Use it.
2801
c0c5c8ae
PE
2802 * alloc.c: Use EMACS_INT, not int, to count objects.
2803 (total_conses, total_markers, total_symbols, total_vector_size)
2804 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
2805 (total_free_floats, total_floats, total_free_intervals)
2806 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
2807 Now EMACS_INT, not int. All uses changed.
2808 (Fgarbage_collect): Compute overall total using a double, so that
2809 integer overflow is less likely to be a problem. Check for overflow
2810 when converting back to an integer.
5a25e253
PE
2811 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2812 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2813 These were 'int' variables that could overflow on 64-bit hosts;
2814 they were never used, so remove them instead of repairing them.
211a0b2a 2815 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
2816 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2817 Previously, this ceilinged at INT_MAX, but that doesn't work on
2818 64-bit machines.
e46bb31a 2819 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 2820
c78baabf 2821 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 2822 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
2823 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2824 when a (possibly-narrower) signed value would do just as well.
2825 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 2826
c9d624c6
PE
2827 * alloc.c: Catch some string size overflows that we were missing.
2828 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2829 for convenience in STRING_BYTES_MAX.
2830 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2831 The definition here is exact; the one in lisp.h was approximate.
2832 (allocate_string_data): Check for string overflow. This catches
2833 some instances we weren't catching before. Also, it catches
2834 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2835 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2836 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 2837
c9d624c6
PE
2838 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2839 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 2840 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 2841
353032ce
PE
2842 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2843
2bccce07
PE
2844 * alloc.c (Fmake_string): Check for out-of-range init.
2845
0ac30604
SM
28462011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2847
2848 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2849
c195f2de
JD
28502011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2851
2852 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2853 xg_get_default_scrollbar_width.
2854
2855 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2856 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2857 (style_changed_cb): Call update_theme_scrollbar_width and call
2858 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2859 all frames (Bug#8505).
2860 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2861 Call gtk_window_set_resizable if HAVE_GTK3.
2862 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2863 and height if HAVE_GTK3 (Bug#8505).
2864 (scroll_bar_width_for_theme): New variable.
2865 (update_theme_scrollbar_width): New function.
2866 (xg_get_default_scrollbar_width): Move code to
2867 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2868 (xg_initialize): Call update_theme_scrollbar_width.
2869
2870 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2871
2872 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2873
e10ac9f1
MR
28742011-06-12 Martin Rudalics <rudalics@gmx.at>
2875
2876 * frame.c (make_frame): Call other_buffer_safely instead of
2877 other_buffer.
2878
2879 * window.c (temp_output_buffer_show): Call display_buffer with
2880 second argument Vtemp_buffer_show_specifiers and reset latter
2881 immediately after the call.
2882 (Vtemp_buffer_show_specifiers): New variable.
2883 (auto_window_vscroll_p, next_screen_context_lines)
2884 (Vscroll_preserve_screen_position): Remove leading asterisks from
2885 doc-strings.
2886
2d3c217e 28872011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 2888
7b7f97e8 2889 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
2890 * buffer.c (Qclone_number): Remove for now, as it's unused.
2891 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2892 (record_buffer): Remove unused local.
2893 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2894 (set_frame_buffer_list): Remove; unused.
2895 * frame.h (other_visible_frames): Remove decl.
2896 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2897 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2898 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2899 if HAVE_GPM.
2900 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2901 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2902 Define only if HAVE_GPM.
2903 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2904 (update_hints_inhibit): Remove; never set. All uses removed.
2905 * widgetprv.h (emacsFrameClassRec): Remove decl.
2906 * window.c (delete_deletable_window): Now returns void, since it
2907 wasn't returning anything.
2908 (compare_window_configurations): Remove unused locals.
2909 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2910 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
2911 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2912 the same widths as pointers. This follows up on the 2011-05-06 patch.
2913 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2914 * xterm.h: Likewise.
2915 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2916
1384b89e
JB
29172011-06-12 Juanma Barranquero <lekktu@gmail.com>
2918
2919 * makefile.w32-in: Update dependencies.
2920 (LISP_H): Add lib/intprops.h.
2921
1100a63c
CY
29222011-06-11 Chong Yidong <cyd@stupidchicken.com>
2923
2924 * image.c (gif_load): Add animation frame delay to the metadata.
2925 (syms_of_image): Use DEFSYM. New symbol `delay'.
2926
6198ccd0
MR
29272011-06-11 Martin Rudalics <rudalics@gmx.at>
2928
2929 * window.c (delete_deletable_window): Re-add.
2930 (Fset_window_configuration): Rewrite to handle dead buffers and
2931 consequently deletable windows.
2932 (window_tree, Fwindow_tree): Remove. Supply functionality in
2933 window.el.
2934 (compare_window_configurations): Simplify code.
2935
b6e3633c
AS
29362011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2937
1ab0dee5
AS
2938 * image.c (imagemagick_load_image): Fix type mismatch.
2939 (Fimagemagick_types): Likewise.
2940
b6e3633c
AS
2941 * window.h (replace_buffer_in_windows): Declare.
2942
9397e56f
MR
29432011-06-11 Martin Rudalics <rudalics@gmx.at>
2944
2945 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2946 Qclone_number. Remove external declaration of Qdelete_window.
2947 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2948 code.
640c8776
SM
2949 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
2950 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
2951 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2952 buffer list implementation.
2953 (other_buffer_safely): New function.
2954 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2955 calls to replace_buffer_in_windows and
2956 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2957 if allowed.
2958 (record_buffer): Inhibit quitting and rewrite using quittable
2959 functions. Run Qbuffer_list_update_hook if allowed.
2960 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
2961 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
2962 Move switch-to-buffer to window.el.
9397e56f
MR
2963 (bury-buffer): Move to window.el.
2964 (Vbuffer_list_update_hook): New variable.
2965
2966 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2967 section.
2968
2969 * window.h (resize_frame_windows): Move up in code.
2970 (Fwindow_frame): Remove EXFUN.
2971 (replace_buffer_in_all_windows): Remove prototype.
2972 (replace_buffer_in_windows_safely): Add prototype.
2973
2974 * window.c: Declare Qdelete_window static again. Move down
2975 declaration of select_count.
2976 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2977 (Fother_window): Move to window.el.
2978 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2979 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2980 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2981 window.el.
2982 (replace_buffer_in_windows): Implement by calling
2983 Qreplace_buffer_in_windows.
2984 (replace_buffer_in_all_windows): Remove with some functionality
2985 moved into replace_buffer_in_windows_safely.
2986 (replace_buffer_in_windows_safely): New function.
2987 (select_window_norecord, select_frame_norecord): Move in front
2988 of run_window_configuration_change_hook. Remove now obsolete
2989 declarations.
640c8776
SM
2990 (Fset_window_buffer): Rewrite doc-string.
2991 Call Qrecord_window_buffer.
9397e56f
MR
2992 (keys_of_window): Move binding for other-window to window.el.
2993
b50691aa
CY
29942011-06-11 Chong Yidong <cyd@stupidchicken.com>
2995
2996 * dispextern.h (struct image): Replace data member, whose int_val
2997 and ptr_val fields were not used by anything, with a single
2998 lisp_val object.
2999
3000 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3001 (gif_clear_image, gif_load, imagemagick_load_image)
3002 (gs_clear_image, gs_load): Callers changed.
3003
3f754b86
PE
30042011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3005
cca69397
PE
3006 * buffer.h: Include <time.h>, for time_t.
3007 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3008
109e28d0
PE
3009 Fix minor problems found by static checking.
3010
60737f02
PE
3011 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3012
4b66faf3
PE
3013 Make identifiers static if they are not used in other modules.
3014 * data.c (Qcompiled_function, Qframe, Qvector):
3015 * image.c (QimageMagick, Qsvg):
3016 * minibuf.c (Qmetadata):
3017 * window.c (resize_window_check, resize_root_window): Now static.
3018 * window.h (resize_window_check, resize_root_window): Remove decls.
3019
109e28d0
PE
3020 * window.c (window_deletion_count, delete_deletable_window):
3021 Remove; unused.
46a4ce9e
PE
3022 (window_body_lines): Now static.
3023 (Fdelete_other_windows_internal): Mark vars as initialized.
3024 Make sure 'resize_failed' is initialized.
3025 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3026 (resize_window_apply): Remove unused local.
3027 * window.h (delete_deletable_window): Remove decl.
3028
109e28d0 3029 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
3030 (imagemagick_load_image): Fix pointer signedness problem by changing
3031 last arg from unsigned char * to char *. All uses changed.
3032 Also, fix a local for similar reasons.
3033 Remove unused locals. Remove locals to avoid shadowing.
3034 (fn_rsvg_handle_free): Remove; unused.
3035 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 3036 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 3037
3f754b86
PE
3038 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3039
2547adb1
CY
30402011-06-10 Chong Yidong <cyd@stupidchicken.com>
3041
3042 * image.c (gif_load): Fix omitted cast error introduced by
3043 2011-06-06 change.
3044
2c8e37d4
MR
30452011-06-10 Martin Rudalics <rudalics@gmx.at>
3046
3047 * window.h (resize_proportionally, orig_total_lines)
3048 (orig_top_line): Remove from window structure.
3049 (set_window_height, set_window_width, change_window_heights)
3050 (Fdelete_window): Remove prototypes.
3051 (resize_frame_windows): Remove duplicate declaration.
3052
440a42e3
EZ
30532011-06-10 Eli Zaretskii <eliz@gnu.org>
3054
3055 * window.h (resize_frame_windows, resize_window_check)
3056 (delete_deletable_window, resize_root_window)
3057 (resize_frame_windows): Declare prototypes.
3058
3059 * window.c (resize_window_apply): Make definition be "static" to
3060 match the prototype.
3061
562dd5e9
MR
30622011-06-10 Martin Rudalics <rudalics@gmx.at>
3063
3064 * window.c: Remove declarations of Qwindow_size_fixed,
3065 window_min_size_1, window_min_size_2, window_min_size,
3066 size_window, window_fixed_size_p, enlarge_window, delete_window.
3067 Remove static from declaration of Qdelete_window, it's
3068 temporarily needed by Fbury_buffer.
3069 (replace_window): Don't assign orig_top_line and
3070 orig_total_lines.
3071 (Fdelete_window, delete_window): Remove. Window deletion is
3072 handled by window.el.
640c8776
SM
3073 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3074 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
3075 (Fdelete_other_windows): Remove. Deleting other windows is
3076 handled by window.el.
3077 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3078 handled in window.el.
3079 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3080 Window minimum sizes are handled in window.el.
3081 (shrink_windows, size_window, set_window_height)
3082 (set_window_width, change_window_heights, window_height)
3083 (window_width, CURBEG, CURSIZE, enlarge_window)
3084 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3085 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3086 handled in window.el.
3087 (make_dummy_parent): Rename to make_parent_window and give it a
3088 second argument horflag.
3089 (make_window): Don't set resize_proportionally any more.
3090 (Fsplit_window): Remove. Windows are split in window.el.
3091 (save_restore_action, save_restore_orig_size)
3092 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3093 Resize mini windows in window.el.
3094 (grow_mini_window, shrink_mini_window): Implement by calling
3095 Qresize_root_window_vertically, resize_window_check and
3096 resize_window_apply.
640c8776
SM
3097 (saved_window, Fset_window_configuration, save_window_save):
3098 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
3099 resize_proportionally.
3100 (window_min_height, window_min_width): Move to window.el.
3101 (keys_of_window): Move bindings for delete-other-windows,
3102 split-window, delete-window and enlarge-window to window.el.
3103
3104 * buffer.c: Temporarily extern Qdelete_window.
3105 (Fbury_buffer): Temporarily call Qdelete_window instead of
3106 Fdelete_window (Fbury_buffer will move to window.el soon).
3107
3108 * frame.c (set_menu_bar_lines_1): Remove code handling
3109 orig_top_line and orig_total_lines.
3110
3111 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3112 set_window_height but set heights directly.
3113 (change_frame_size_1): Use resize_frame_windows.
3114
3115 * xdisp.c (init_xdisp): Don't use set_window_height but set
3116 heights directly.
3117
640c8776
SM
3118 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3119 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
3120 run_window_configuration_change_hook.
3121
3122 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3123 instead of change_window_heights and run
3124 run_window_configuration_change_hook.
3125
1a13852e
MR
31262011-06-09 Martin Rudalics <rudalics@gmx.at>
3127
3128 * window.c (replace_window): Rename second argument REPLACEMENT to
3129 NEW. New third argument SETFLAG. Rewrite.
3130 (delete_window, make_dummy_parent): Call replace_window with
3131 third argument 1.
3132 (window_list_1): Move down in code.
3133 (run_window_configuration_change_hook): Move set_buffer part
3134 before select_frame_norecord part in order to unwind correctly.
3135 Rename count1 to count.
3136 (recombine_windows, delete_deletable_window, resize_root_window)
3137 (Fdelete_other_windows_internal)
3138 (Frun_window_configuration_change_hook, make_parent_window)
3139 (resize_window_check, resize_window_apply, Fresize_window_apply)
3140 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
3141 (Fdelete_window_internal, Fresize_mini_window_internal):
3142 New functions.
1a13852e
MR
3143 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3144
f3d1777e
MR
31452011-06-08 Martin Rudalics <rudalics@gmx.at>
3146
496e208e
MR
3147 * window.h (window): Add some new members to window structure -
3148 normal_lines, normal_cols, new_total, new_normal, clone_number,
3149 splits, nest, prev_buffers, next_buffers.
3150 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 3151 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 3152
f3d1777e
MR
3153 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3154 Remove.
496e208e
MR
3155 (make_dummy_parent): Set new members of windows structure.
3156 (make_window): Move down in code. Handle new members of window
3157 structure.
3158 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3159 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3160 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3161 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
3162 (Fset_window_next_buffers, Fset_window_clone_number):
3163 New functions.
496e208e
MR
3164 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3165 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3166 Doc-string fixes.
3167 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3168 Argument WINDOW can be now internal window too.
3169 (Fwindow_use_time): Move up in code.
3170 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3171 Rewrite doc-string.
3172 (Fset_window_configuration, saved_window)
3173 (Fcurrent_window_configuration, save_window_save): Handle new
3174 members of window structure.
b9e809c2
MR
3175 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3176 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3177 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3178 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3179 Qget_mru_window, Qresize_root_window,
3180 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3181 Qauto_buffer_name; staticpro them.
f3d1777e 3182
abde8f8c
MR
31832011-06-07 Martin Rudalics <rudalics@gmx.at>
3184
3185 * window.c (Fwindow_total_size, Fwindow_left_column)
3186 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3187 (Fwindow_list_1): New functions.
3188 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
3189 (Fwindow_width, Fscroll_left, Fscroll_right):
3190 Use window_body_cols instead of window_box_text_cols.
3191 (delete_window, Fset_window_configuration):
3192 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
3193 (delete_all_subwindows): Take a window as argument and not a
3194 structure. Rewrite.
190b47e6
MR
3195 (window_loop): Remove handling of GET_LRU_WINDOW and
3196 GET_LARGEST_WINDOW.
3197 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
3198
3199 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
3200 window_box_text_cols. delete_all_subwindows now takes a
3201 Lisp_Object as argument.
abde8f8c 3202
640c8776
SM
3203 * indent.c (compute_motion, Fcompute_motion):
3204 Use window_body_cols instead of window_box_text_cols.
abde8f8c 3205
fa8a67e6
MR
3206 * frame.c (delete_frame): Call delete_all_subwindows with root
3207 window as argument.
3208
a54e3482
DC
32092011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3210
3211 * fns.c (Fputhash): Document return value.
3212
60002bf5
CY
32132011-06-06 Chong Yidong <cyd@stupidchicken.com>
3214
3215 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3216
0c671da6 32172011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 3218
b862a52a 3219 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 3220
be44ca6c
PE
3221 Check for overflow when converting integer to cons and back.
3222 * charset.c (Fdefine_charset_internal, Fdecode_char):
3223 Use cons_to_unsigned to catch overflow.
3224 (Fencode_char): Use INTEGER_TO_CONS.
3225 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3226 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3227 * data.c (long_to_cons, cons_to_long): Remove.
3228 (cons_to_unsigned, cons_to_signed): New functions.
3229 These signal an error for invalid or out-of-range values.
3230 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3231 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3232 * font.c (Ffont_variation_glyphs):
3233 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3234 * lisp.h: Include <intprops.h>.
3235 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3236 (cons_to_signed, cons_to_unsigned): New decls.
3237 (long_to_cons, cons_to_long): Remove decls.
3238 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3239 (Fprimitive_undo): Use CONS_TO_INTEGER.
3240 * xfns.c (Fx_window_property): Likewise.
3241 * xselect.c: Include <limits.h>.
3242 (x_own_selection, selection_data_to_lisp_data):
3243 Use INTEGER_TO_CONS.
3244 (x_handle_selection_request, x_handle_selection_clear)
3245 (x_get_foreign_selection, Fx_disown_selection_internal)
3246 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3247 (lisp_data_to_selection_data): Use cons_to_unsigned.
3248 (x_fill_property_data): Use cons_to_signed.
3249 Report values out of range.
3250
d1f3d2af
PE
3251 Check for buffer and string overflow more precisely.
3252 * buffer.h (BUF_BYTES_MAX): New macro.
3253 * lisp.h (STRING_BYTES_MAX): New macro.
3254 * alloc.c (Fmake_string):
3255 * character.c (string_escape_byte8):
3256 * coding.c (coding_alloc_by_realloc):
3257 * doprnt.c (doprnt):
3258 * editfns.c (Fformat):
3259 * eval.c (verror):
3260 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3261 since they may not be the same number.
3262 * editfns.c (Finsert_char):
3263 * fileio.c (Finsert_file_contents):
3264 Likewise for BUF_BYTES_MAX.
3265
dd52fcea
PE
3266 * image.c: Use ptrdiff_t, not int, for sizes.
3267 (slurp_file): Switch from int to ptrdiff_t.
3268 All uses changed.
3269 (slurp_file): Check that file size fits in both size_t (for
3270 malloc) and ptrdiff_t (for sanity and safety).
3271
7f9bbdbb
PE
3272 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3273 if b->modtime has its maximal value.
3274
dfe18f82
PE
3275 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3276
84acfcf0
PE
3277 Don't assume time_t can fit into int.
3278 * buffer.h (struct buffer.modtime): Now time_t, not int.
3279 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3280 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3281
ccd9a01a
PE
3282 Minor fixes for signed vs unsigned integers.
3283 * character.h (MAYBE_UNIFY_CHAR):
3284 * charset.c (maybe_unify_char):
3285 * keyboard.c (read_char, reorder_modifiers):
3286 XINT -> XFASTINT, since the integer must be nonnegative.
3287 * ftfont.c (ftfont_spec_pattern):
3288 * keymap.c (access_keymap, silly_event_symbol_error):
3289 XUINT -> XFASTINT, since the integer must be nonnegative.
3290 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3291 since it makes no difference and we prefer signed.
3292 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3293 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3294 nonnegative.
3295
d6d100dd
SM
32962011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3297
3298 * window.h (Fwindow_frame): Declare.
3299
2b6148e4
PE
33002011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3301
3302 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3303 (SPARE_MEMORY): Always define.
3304 (LARGE_REQUEST): Remove.
3305 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3306
f230ecc9
MR
33072011-06-06 Martin Rudalics <rudalics@gmx.at>
3308
727e958e
MR
3309 * lisp.h: Move EXFUNS for Fframe_root_window,
3310 Fframe_first_window and Fset_frame_selected_window to window.h.
3311
3312 * window.h: Move EXFUNS for Fframe_root_window,
3313 Fframe_first_window and Fset_frame_selected_window here from
3314 lisp.h.
3315
3316 * frame.c (Fwindow_frame, Fframe_first_window)
3317 (Fframe_root_window, Fframe_selected_window)
3318 (Fset_frame_selected_window): Move to window.c.
3319 (Factive_minibuffer_window): Move to minibuf.c.
3320 (Fother_visible_frames_p): New function.
3321
3322 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3323
f230ecc9
MR
3324 * window.c (decode_window, decode_any_window): Move up in code.
3325 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3326 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
3327 (Fwindow_buffer): Move up and rewrite doc-string.
3328 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3329 (Fwindow_prev): New functions.
727e958e
MR
3330 (Fwindow_frame): Move here from frame.c. Accept any window as
3331 argument.
3332 (Fframe_root_window, Fframe_first_window)
3333 (Fframe_selected_window): Move here from frame.c. Accept frame
3334 or arbitrary window as argument. Update doc-strings.
3335 (Fminibuffer_window): Move up in code.
3336 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
3337 (Fset_frame_selected_window): Move here from frame.c.
3338 Marginal rewrite.
727e958e
MR
3339 (Fselected_window, select_window, Fselect_window): Move up in
3340 code. Minor doc-string fixes.
f230ecc9 3341
4d09bcf6
PE
33422011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3343
3344 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3345 Do not assume that spare memory exists; that assumption is valid
3346 only if SYSTEM_MALLOC.
3347 (LARGE_REQUEST): New macro, so that the issue of large requests
3348 is separated from the issue of spare memory.
3349
810928a2
AS
33502011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3351
172418ad
AS
3352 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3353 format. (Bug#8806)
3354
43f862f7
AS
3355 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3356
810928a2
AS
3357 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3358 before statements.
3359
a059fe24
JD
33602011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3361
3362 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3363
3364 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3365
3366 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3367 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3368
989bf368
JB
33692011-06-05 Juanma Barranquero <lekktu@gmail.com>
3370
3371 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3372
4b80f674
CY
33732011-06-04 Chong Yidong <cyd@stupidchicken.com>
3374
3375 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3376 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
3377 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3378 New error handlers.
4b80f674
CY
3379 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3380 Obey Vx_select_enable_clipboard_manager. Catch errors in
3381 x_clipboard_manager_save (Bug#8779).
3382 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 3383 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 3384
99a33b77 33852011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
3386
3387 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3388
99a33b77 33892011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
3390
3391 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3392 in the current matrix if keep_current_p is non-zero.
3393
8264569d
EZ
33942011-06-04 Eli Zaretskii <eliz@gnu.org>
3395
3396 * bidi.c (bidi_level_of_next_char): Fix last change.
3397
57f97249
EZ
33982011-06-03 Eli Zaretskii <eliz@gnu.org>
3399
fec2107c 3400 Support bidi reordering of text covered by display properties.
57f97249 3401
fec2107c
EZ
3402 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3403 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3404 (bidi_cache_search, bidi_cache_iterator_state)
3405 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
3406 (bidi_level_of_next_char, bidi_move_to_visually_next):
3407 Support character positions inside a run of characters covered by a
fec2107c
EZ
3408 display string.
3409 (bidi_paragraph_init, bidi_resolve_explicit_1)
3410 (bidi_level_of_next_char): Call bidi_fetch_char and
3411 bidi_fetch_char_advance instead of FETCH_CHAR and
3412 FETCH_CHAR_ADVANCE.
3413 (bidi_init_it): Initialize new members.
3414 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
3415 definitions.
3416 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
3417 instead of using explicit *_CHAR codes.
d6d100dd
SM
3418 (bidi_resolve_explicit, bidi_resolve_weak):
3419 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
3420 bidirectional text is supported only in multibyte buffers.
3421 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
3422 it to initialize the frame_window_p member of struct bidi_it.
3423 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
3424 (bidi_resolve_explicit, bidi_resolve_weak)
3425 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
3426 bidi_it->nchars is non-positive.
3427 (bidi_level_of_next_char): Don't try to lookup the cache for the
3428 next/previous character if nothing is cached there yet, or if we
3429 were just reseat()'ed to a new position.
c40e2fb2 3430
0e14fe90
EZ
3431 * xdisp.c (set_cursor_from_row): Set start and stop points
3432 according to the row's direction when priming the loop that looks
3433 for the glyph on which to display cursor.
3434 (single_display_spec_intangible_p): Function deleted.
3435 (display_prop_intangible_p): Reimplement to call
3436 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
3437 Accept 3 additional arguments needed by handle_display_spec.
3438 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
3439 values: lists, `(when COND...)' forms, etc.
3440 (single_display_spec_string_p): Support property values that are
3441 lists with the argument STRING its top-level element.
3442 (display_prop_string_p): Fix the condition for processing a
3443 property that is a list to be consistent with handle_display_spec.
fec2107c 3444 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
3445 last portion of handle_display_prop.
3446 (compute_display_string_pos): Accept additional argument
3447 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
3448 value of a `display' property is a "replacing spec".
3449 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
3450 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
3451 the display property, but just return a value indicating whether
3452 the display property will replace the characters it covers.
3453 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
3454 frame_window_p members of struct bidi_it.
d6d100dd
SM
3455 (compute_display_string_pos, compute_display_string_end):
3456 New functions.
fec2107c
EZ
3457 (push_it): Accept second argument POSITION, where pop_it should
3458 jump to continue iteration.
3459 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 3460
fec2107c
EZ
3461 * keyboard.c (adjust_point_for_property): Adjust the call to
3462 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
3463
3464 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
3465 (bidi_init_it): Update prototypes.
3466 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
3467 (compute_display_string_pos, compute_display_string_end):
3468 Declare prototypes.
fec2107c
EZ
3469 (struct bidi_it): New members nchars and disp_pos. ch_len is now
3470 EMACS_INT.
fc6f18ce 3471
40087514 34722011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 3473
57f53182
PE
3474 Malloc failure behavior now depends on size of allocation.
3475 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
3476 * lisp.h: Change signatures accordingly.
3477 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
3478 All callers changed. (Bug#8762)
3479
3480 * gnutls.c: Use Emacs's memory allocators.
3481 Without this change, the gnutls library would invoke malloc etc.
3482 directly, which causes problems on non-SYNC_INPUT hosts, and which
3483 runs afoul of improving memory_full behavior. (Bug#8761)
3484 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
3485 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
3486 xfree instead of the default malloc, realloc, free.
3487 (Fgnutls_boot): No need to check for memory allocation failure,
3488 since xmalloc does that for us.
3489
ac32cd99 3490 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
3491 * category.c (hash_get_category_set):
3492 * ccl.c (ccl_driver):
3493 * charset.c (Fdefine_charset_internal):
3494 * charset.h (struct charset.hash_index):
3495 * composite.c (get_composition_id, gstring_lookup_cache)
3496 (composition_gstring_put_cache):
3497 * composite.h (struct composition.hash_index):
3498 * dispextern.h (struct image.hash):
3499 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
3500 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
3501 (hashfn_equal, hashfn_user_defined, make_hash_table)
3502 (maybe_resize_hash_table, hash_lookup, hash_put)
3503 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
3504 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
3505 (Fsxhash, Fgethash, Fputhash, Fmaphash):
3506 * image.c (make_image, search_image_cache, lookup_image)
3507 (xpm_put_color_table_h):
3508 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 3509 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 3510 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 3511 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
3512 * alloc.c (allocate_vectorlike):
3513 Check for overflow in vector size calculations.
3514 * ccl.c (ccl_driver):
3515 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
3516 * fns.c, image.c: Remove unnecessary static decls that would otherwise
3517 need to be updated by these changes.
40087514
PE
3518 * fns.c (make_hash_table, maybe_resize_hash_table):
3519 Check for integer overflow with large hash tables.
0de4bb68
PE
3520 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
3521 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
3522 (SXHASH_REDUCE): New macro.
3523 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
3524 Use it instead of discarding useful hash info with large hash values.
3525 (sxhash_float): New function.
3526 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
3527 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
3528 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
3529 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
3530 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
3531 Adjust signatures to match updated version of code.
3532 (consing_since_gc): Now EMACS_INT, since a single hash table can
3533 use more than INT_MAX bytes.
3534
698d32e2
DN
35352011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
3536
3537 Make it possible to build with GCC-4.6+ -O2 -flto.
3538
3539 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
3540
fd6fa53f
SM
35412011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
3542
3543 * minibuf.c (get_minibuffer, read_minibuf_unwind):
3544 Call minibuffer-inactive-mode.
3545
864db017
JB
35462011-05-31 Juanma Barranquero <lekktu@gmail.com>
3547
3548 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3549 Update dependencies.
3550
2ad0baf4
DN
35512011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3552
3553 * data.c (init_data): Remove code for UTS, this system is not
3554 supported anymore.
3555
4fcc2638
DN
35562011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3557
3558 Don't force ./temacs to start in terminal mode.
3559
3560 * frame.c (make_initial_frame): Initialize faces in all cases, not
3561 only when CANNOT_DUMP is defined.
3562 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3563
c56e0fd5
DN
35642011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3565
3566 * dispnew.c (add_window_display_history): Use const for the string
3567 pointer. Remove declaration, not needed.
3568
333d54da 35692011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 3570
55d4c1b2 3571 Use 'inline', not 'INLINE'.
333d54da 3572 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
3573 * alloc.c, fontset.c (INLINE): Remove.
3574 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3575 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3576 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3577 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3578 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3579
738db178
DN
35802011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3581
3582 Make it possible to run ./temacs.
3583
3584 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3585 syms_of_callproc does the same thing. Remove test for
3586 "initialized", do it in the caller.
3587 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3588
620c53a6
SM
35892011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3590
3591 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3592 (read_minibuf): Use get_minibuffer.
3593 (syms_of_minibuf): Use DEFSYM.
3594 (Qmetadata): New var.
3595 * data.c (Qbuffer): Don't make it static.
3596 (syms_of_data): Use DEFSYM.
3597
e003a292
PE
35982011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3599
3600 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3601 (CCL_CODE_MIN): New macro.
3602
ed008a6d
PE
36032011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3604
3687c2ef
PE
3605 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3606
ed008a6d
PE
3607 * eval.c (Qdebug): Now static.
3608 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3609 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
3610 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3611
d66c4c7c
CY
36122011-05-29 Chong Yidong <cyd@stupidchicken.com>
3613
3614 * image.c: Various fixes to ImageMagick code comments.
3615 (Fimagemagick_types): Doc fix.
3616
5fbc2025
PE
36172011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3618
0196f88a
PE
3619 Minor fixes prompted by GCC 4.6.0 warnings.
3620
3621 * xselect.c (converted_selections, conversion_fail_tag): Now static.
3622
5fbc2025
PE
3623 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
3624 (x_clipboard_manager_save_all): Move extern decl to ...
3625 * xterm.h: ... here, so that it can be checked for consistency.
3626
1dd3c2d9
CY
36272011-05-29 Chong Yidong <cyd@stupidchicken.com>
3628
3629 * xselect.c (x_clipboard_manager_save_frame)
3630 (x_clipboard_manager_save_all): New functions.
3631 (Fx_clipboard_manager_save): Lisp function deleted.
3632
3633 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
3634 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
3635
3636 * xterm.h: Update prototype.
3637
5ba6571d
WX
36382011-05-28 William Xu <william.xwl@gmail.com>
3639
3640 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
3641 exiting (Bug#8239).
3642
3eaff834
JM
36432011-05-28 Jim Meyering <meyering@redhat.com>
3644
e1900994 3645 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
3646 * fns.c (to_uchar): Define.
3647 (crypto_hash_function): Use it to convert some newly-signed
3648 variables to unsigned, to avoid sign-extension bugs. For example,
3649 without this change, (md5 "truc") would evaluate to
3650 45723a2aff78ff4fff7fff1114760e62 rather than the expected
3651 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 3652 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 3653
0f6990a7
PE
36542011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3655
3656 Integer overflow fixes.
c8a9ca5a 3657
08686060
PE
3658 * dbusbind.c: Serial number integer overflow fixes.
3659 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
3660 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
3661 to hold a serial number that is too large for a fixnum.
3662 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3663 Check for serial numbers out of range. Decode any serial number
59568bf0 3664 that was so large that it became a float. (Bug#8722)
08686060 3665
2d1fc3c7
PE
3666 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
3667 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3668 Use XFASTINT rather than XUINT when numbers are nonnegative.
3669 (xd_append_arg, Fdbus_method_return_internal):
3670 (Fdbus_method_error_internal): Likewise. Also, for unsigned
3671 arguments, check that Lisp number is nonnegative, rather than
59568bf0 3672 silently wrapping negative numbers around. (Bug#8722)
30217ff0 3673 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 3674 (Bug#8722)
2d1fc3c7 3675
c8a9ca5a
PE
3676 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
3677
519e1d69
PE
3678 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
3679
30569699
PE
3680 ccl: add integer overflow checks
3681 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
3682 (IN_INT_RANGE): New macros.
3683 (ccl_driver): Use them to check for integer overflow when
3684 decoding a CCL program. Many of the new checks are whether XINT (x)
3685 fits in int; it doesn't always, on 64-bit hosts. The new version
3686 doesn't catch all possible integer overflows, but it's an
847044ea 3687 improvement. (Bug#8719)
30569699 3688
c11285dc
PE
3689 * alloc.c (make_event_array): Use XINT, not XUINT.
3690 There's no need for unsigned here.
3691
fdccd48e
PE
3692 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
3693 This follows up to the 2011-05-06 change that substituted uintptr_t
3694 for EMACS_INT. This case wasn't caught back then.
3695
37910ab2
PE
3696 Rework Fformat to avoid integer overflow issues.
3697 * editfns.c: Include <float.h> unconditionally, as it's everywhere
3698 now (part of C89). Include <verify.h>.
3699 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
3700 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
3701 (Fformat): Avoid the prepass trying to compute sizes; it was only
3702 approximate and thus did not catch overflow reliably. Instead, walk
3703 through the format just once, formatting and computing sizes as we go,
3704 checking for integer overflow at every step, and allocating a larger
3705 buffer as needed. Keep track separately whether the format is
3706 multibyte. Keep only the most-recently calculated precision, rather
3707 than them all. Record whether each argument has been converted to
3708 string. Use EMACS_INT, not int, for byte and char and arg counts.
3709 Support field widths and precisions larger than INT_MAX. Avoid
3710 sprintf's undefined behavior with conversion specifications such as %#d
3711 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
3712 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
3713 formatting out-of-range floating point numbers with int
9173deec 3714 formats. (Bug#8668)
37910ab2 3715
2e6578fb
PE
3716 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
3717
0ae6bdee
PE
3718 * data.c: Avoid integer truncation in expressions involving floats.
3719 * data.c: Include <intprops.h>.
3720 (arith_driver): When there's an integer overflow in an expression
3721 involving floating point, convert the integers to floating point
3722 so that the resulting value does not suffer from catastrophic
3723 integer truncation. For example, on a 64-bit host (* 4
3724 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
3725 Do not rely on undefined behavior after integer overflow.
3726
de883a70
PE
3727 merge count_size_as_multibyte, parse_str_to_multibyte
3728 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 3729 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
3730 Check for integer overflow.
3731 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
3732 since it's now a duplicate of the other. This is more of
3733 a character than a buffer op, so better that it's in character.c.
3734 * fns.c, print.c: Adjust to above changes.
3735
2ff916cb
PE
37362011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
3737
3738 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
3739
f1b54466
PE
37402011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3741
fb1ac845
PE
3742 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3743 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
3744 (x_clipboard_manager_save): Now static.
3745 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
3746
f1b54466
PE
3747 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3748 (crypto_hash_function): Now static.
3749 Fix pointer signedness problems. Avoid unnecessary initializations.
3750
a9f737ee
CY
37512011-05-27 Chong Yidong <cyd@stupidchicken.com>
3752
3753 * termhooks.h (Vselection_alist): Make it terminal-local.
3754
3755 * terminal.c (create_terminal): Initialize it.
3756
3757 * xselect.c: Support for clipboard managers.
3758 (Vselection_alist): Move to termhooks.h as terminal-local var.
3759 (LOCAL_SELECTION): New macro.
3760 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
3761 (symbol_to_x_atom): Remove gratuitous arg.
3762 (x_handle_selection_request, lisp_data_to_selection_data)
3763 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
3764 (x_own_selection, x_get_local_selection, x_convert_selection):
3765 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
3766 (some_frame_on_display): Delete unused function.
3767 (Fx_own_selection_internal, Fx_get_selection_internal)
3768 (Fx_disown_selection_internal, Fx_selection_owner_p)
3769 (Fx_selection_exists_p): New optional frame arg.
3770 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
3771 (x_handle_selection_clear): Don't treat other terminals with the
3772 same keyboard specially. Use the terminal-local Vselection_alist.
3773 (x_clear_frame_selections): Use Frun_hook_with_args.
3774
3775 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
3776
3777 * xterm.h: Add support for those atoms.
3778
e067f0c1
CY
37792011-05-26 Chong Yidong <cyd@stupidchicken.com>
3780
3781 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
3782 (converted_selections, conversion_fail_tag): New global variables.
3783 (x_selection_request_lisp_error): Free the above.
3784 (x_get_local_selection): Remove unnecessary code.
3785 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
3786 of converted selections stored in converted_selections.
3787 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
3788 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
3789 (x_convert_selection): New function.
3790 (x_handle_selection_event): Simplify.
3791 (x_get_foreign_selection): Don't ignore incoming requests while
3792 waiting for an answer; this will fail when we implement
3793 SAVE_TARGETS, and seems unnecessary anyway.
3794 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
3795 (Vx_sent_selection_functions): Doc fix.
3796
0f4aebc0
LL
37972011-05-26 Leo Liu <sdl.web@gmail.com>
3798
3799 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
3800
e61124cd
YM
38012011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3802
3803 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
3804
3805 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
3806 for fringe update if it has periodic bitmap.
ac389d0c 3807 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
3808 and fringe_bitmap_periodic_p.
3809
3810 * fringe.c (get_fringe_bitmap_data): New function.
3811 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3812 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3813 row. Mark glyph row for fringe update if periodicity changed.
3814
3815 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3816 for fringe update unless it has periodic bitmap.
3817
f16d9837
KH
38182011-05-25 Kenichi Handa <handa@m17n.org>
3819
3820 * xdisp.c (get_next_display_element): Set correct it->face_id for
3821 a static composition.
3822
e1b90ef6
LL
38232011-05-24 Leo Liu <sdl.web@gmail.com>
3824
3825 * deps.mk (fns.o):
3826 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3827
3828 * fns.c (crypto_hash_function, Fsha1): New function.
3829 (Fmd5): Use crypto_hash_function.
3830 (syms_of_fns): Add Ssha1.
3831
7400048f
PE
38322011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3833
3834 * gnutls.c: Remove unused macros.
3835 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3836 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3837 Remove macros that are defined and never used.
3838 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3839
abb71cf4
CY
38402011-05-22 Chong Yidong <cyd@stupidchicken.com>
3841
3842 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3843 (Fx_get_selection_internal): Minor cleanup.
3844 (Fx_own_selection_internal): Rename arguments for consistency with
3845 select.el.
3846
6307db39
PE
38472011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3848
3849 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3850
f3d4e0a4
CY
38512011-05-22 Chong Yidong <cyd@stupidchicken.com>
3852
3853 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3854
4d8ade89
YM
38552011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3856
3857 * dispnew.c (scrolling_window): Don't exclude the case that the
3858 last enabled row in the desired matrix touches the bottom boundary.
3859
32078c8d
GM
38602011-05-21 Glenn Morris <rgm@gnu.org>
3861
3862 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
3863 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3864 and add some more files.
32078c8d 3865
7285dc67
EZ
38662011-05-20 Eli Zaretskii <eliz@gnu.org>
3867
3868 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3869 report_file_error introduced by the change from 2011-05-07.
3870
89d1bd22
PE
38712011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3872
3873 * systime.h (Time): Define only if emacs is defined.
3874 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3875 where the include path doesn't have X11/X.h by default. See
3876 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3877
e23640bb 38782011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
3879
3880 * composite.c (find_automatic_composition): Fix previous change.
3881
b9704ad9
GM
38822011-05-20 Glenn Morris <rgm@gnu.org>
3883
3884 * lisp.mk: New file, split from Makefile.in.
3885 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3886 (shortlisp): Remove.
3887 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3888
4a720484
GM
38892011-05-19 Glenn Morris <rgm@gnu.org>
3890
3891 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3892 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3893 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3894 (lisp): Set the order to that of loadup.el.
3895 (shortlisp): Make it a copy of $lisp.
3896 (SOME_MACHINE_LISP): Remove.
3897 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3898 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3899
a28d4396
KH
39002011-05-18 Kenichi Handa <handa@m17n.org>
3901
3902 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3903 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3904 (find_automatic_composition): Mostly rewrite for efficiency.
3905
a2b1fa8e
JB
39062011-05-18 Juanma Barranquero <lekktu@gmail.com>
3907
3908 * makefile.w32-in: Update dependencies.
3909
8e1f5610
CS
39102011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3911
3912 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 3913 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 3914
7025ee00 39152011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 3916
cdfa6eab
PE
3917 Fix some integer overflow issues, such as string length overflow.
3918
06d6db33
PE
3919 * insdel.c (count_size_as_multibyte): Check for string overflow.
3920
2b4560a8
PE
3921 * character.c (lisp_string_width): Check for string overflow.
3922 Use EMACS_INT, not int, for string indexes and lengths; in
3923 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3924 the resulting string length overflows an EMACS_INT; instead,
3925 report a string overflow if no precision given. When checking for
3926 precision exhaustion, use a check that cannot possibly have
3927 integer overflow. (Bug#8675)
3928 * character.h (lisp_string_width): Adjust to new signature.
3929
cb93f9be
PE
3930 * alloc.c (string_overflow): New function.
3931 (Fmake_string): Use it. This doesn't change behavior, but saves
3932 a few bytes and will simplify future changes.
3933 * character.c (string_escape_byte8): Likewise.
3934 * lisp.h (string_overflow): New decl.
3935
1a1f3366
PE
3936 Fixups, following up to the user-interface timestamp change.
3937 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3938 for UI timestamps, instead of unsigned long.
9fbd6841
PE
3939 * msdos.c (mouse_get_pos): Likewise.
3940 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
3941 * w32gui.h (Time): Define by including "systime.h" rather than by
3942 declaring it ourselves. (Bug#8664)
3943
d4e3e4d3
PE
3944 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3945 * image.c (clear_image_cache): Likewise.
3946
f6a24d19
PE
3947 * term.c (term_mouse_position): Don't assume time_t wraparound.
3948
08dc5ae6
PE
3949 Be more systematic about user-interface timestamps.
3950 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
3951 and sometimes 'EMACS_UINT', to represent these timestamps.
3952 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
3953 This makes the code easier to follow, and makes it easier to catch
3954 integer overflow bugs such as Bug#8664.
3955 * frame.c (Fmouse_position, Fmouse_pixel_position):
3956 Use Time, not unsigned long, for user-interface timestamps.
3957 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3958 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3959 * keyboard.h (last_event_timestamp): Likewise.
3960 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3961 * menu.h (xmenu_show): Likewise.
3962 * term.c (term_mouse_position): Likewise.
3963 * termhooks.h (struct input_event.timestamp): Likewise.
3964 (struct terminal.mouse_position_hook): Likewise.
3965 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3966 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3967 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3968 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3969 what it was before.
3970 * menu.h, termhooks.h: Include "systime.h", for Time.
3971
8e55734a
PE
3972 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3973 Don't assume that the difference between two unsigned long values
3974 can fit into an integer. At this point, we know button_down_time
3975 <= event->timestamp, so the difference must be nonnegative, so
3976 there's no need to cast the result if double-click-time is
3977 nonnegative, as it should be; check that it's nonnegative, just in
3978 case. This bug is triggered when events are more than 2**31 ms
86db42d2 3979 apart (about 25 days). (Bug#8664)
8e55734a 3980
841f1b75 3981 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 3982 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 3983
3e26f69c
PE
3984 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3985 that always fit in int. Use a sentinel instead of a counter, to
3986 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
3987 * frame.h (struct frame): Use int for menu_bar_items_used
3988 instead of EMACS_INT, since it always fits in int.
3e26f69c 3989
5cc152c0
PE
3990 * menu.c (grow_menu_items): Check for int overflow.
3991
d89eb65e
PE
3992 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3993
5235bd3e
PE
3994 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3995 Before, the code was not consistent. These values cannot exceed
3996 2**31 - 1 so there's no need to make them unsigned.
3997 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3998 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3999 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4000 as modifiers.
4001 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4002
bc827e23
PE
4003 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4004 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4005 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4006 presumably because the widths might not match.
4007
78eb494e
PE
4008 * window.c (size_window): Avoid needless test at loop start.
4009
04f2d78b
CB
40102011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4011
4012 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4013
d2fc7e3d 40142011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
4015
4016 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4017
d2fc7e3d 40182011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
4019
4020 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4021 `width' to `bar_area_x' and `bar_area_width', respectively.
4022 (x_scroll_run): Take account of fringe background extension.
4023
04f2d78b
CB
4024 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4025 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
4026 `bar_area_width', respectively.
4027 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4028 background extension.
4029
79b70037
GM
40302011-05-10 Jim Meyering <meyering@redhat.com>
4031
4032 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4033
2f142cc5
JB
40342011-05-10 Juanma Barranquero <lekktu@gmail.com>
4035
4036 * image.c (Finit_image_library): Return t for built-in image types,
4037 like pbm and xbm. (Bug#8640)
4038
57679c86
AS
40392011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4040
4041 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4042
888c9e86
EZ
40432011-05-07 Eli Zaretskii <eliz@gnu.org>
4044
b0512a1d
EZ
4045 * w32console.c (Fset_screen_color): Doc fix.
4046 (Fget_screen_color): New function.
4047 (syms_of_ntterm): Defsubr it.
4048
7285dc67
EZ
4049 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4050 unlink the temporary file if Fcall_process didn't create it in the
4051 first place.
4052 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4053 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
4054 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4055 cue to call_process_cleanup not to close that handle.
4056
4d3fcc8e
BK
40572011-05-07 Ben Key <bkey76@gmail.com>
4058
4059 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4060 one of two shell specific rules, either bootstrap-temacs-CMD or
4061 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4062 to the previous implementation of the bootstrap-temacs rule.
4063 The bootstrap-temacs-CMD rule is similar to the previous
4064 implementation of the bootstrap-temacs rule except that it
4065 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4066 variable.
4067
4068 These changes, along with some changes to nt/configure.bat,
4069 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4070 earlier fix to add support for --cflags and --ldflags options
4071 that include quotes so that it works whether make uses cmd or
4072 sh as the shell.
4073
b4289b64
MA
40742011-05-06 Michael Albinus <michael.albinus@gmx.de>
4075
4076 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4077 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4078 is a constant.
4079 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4080 a string. Handle both cases.
4081 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4082 (Fdbus_register_method): Use Qinvalid_function.
4083
af4c0e28
JB
40842011-05-06 Juanma Barranquero <lekktu@gmail.com>
4085
4086 * makefile.w32-in: Update dependencies.
4087 (LISP_H): Add inttypes.h and stdin.h.
4088 (PROCESS_H): Add unistd.h.
4089
c51453d9
EZ
40902011-05-06 Eli Zaretskii <eliz@gnu.org>
4091
4092 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4093 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4094
8ff0ac3c 40952011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 4096
4c4b566b
PE
4097 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4098
aab2b9b5
PE
4099 * term.c (vfatal): Remove stray call to va_end.
4100 It's not needed and the C Standard doesn't allow it here anyway.
4101
c378da0b
PE
4102 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4103 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4104
288b08c7
PE
4105 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4106 bytes.
4107
e3601888
PE
4108 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4109
db6c0e74
PE
4110 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4111
dd5963ea
PE
4112 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4113
88c9450f
PE
4114 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4115
2f9442b8
PE
4116 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4117
c032b5f8
PE
4118 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4119 * charset.c (Fdefine_charset_internal): Don't initialize
4120 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 4121 32-bit int (Bug#8600).
a108c10b
PE
4122
4123 * lread.c (read_integer): Be more consistent with string-to-number.
4124 Use string_to_number to do the actual conversion; this avoids
4125 rounding errors and fixes some other screwups. Without this fix,
4126 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4127 (digit_to_number): Move earlier, for benefit of read_integer.
4128 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 4129 not a digit in any supported base. (Bug#8602)
a108c10b 4130
ad5f9eea
PE
4131 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4132
aec1708a
PE
4133 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4134 to match comment at start of function. This also removes a
4135 GCC warning about overflow in a 32+64-bit port.
4136
47be4ab5
PE
4137 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4138
371cac43
PE
4139 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4140 Reported by Stefan Monnier in
4141 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
4142 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4143 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 4144
d01a7826
PE
4145 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4146 (EMACS_UINTPTR): Likewise, with uintptr_t.
4147
7fd47d5c
PE
4148 * lisp.h: Prefer 64-bit EMACS_INT if available.
4149 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4150 on 32-bit hosts that have 64-bit int, so that they can access
4151 large files.
122b0c86
PE
4152 However, temporarily disable this change unless the temporary
4153 symbol WIDE_EMACS_INT is defined.
7fd47d5c 4154
8727937b
PE
4155 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4156
8ac068ac
PE
4157 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4158 This removes an assumption that EMACS_INT and long are the same
4159 width as pointers. The assumption is true for Emacs porting targets
4160 now, but we want to make other targets possible.
4161 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4162 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4163 In the rest of the code, change types of integers that hold casted
4164 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4165 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4166 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4167 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4168 No need to cast type when ORing.
4169 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4170 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4171 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4172 assume EMACS_INT is the same width as char *.
4173 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4174 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4175 Remove no-longer-needed casts.
4176 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4177 (xg_tool_bar_help_callback, xg_make_tool_item):
4178 Use EMACS_INTPTR to hold an integer
4179 that will be cast to void *; this can avoid a GCC warning
4180 if EMACS_INT is not the same width as void *.
4181 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4182 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4183 (current_message_1, set_message_1):
4184 Use a local to convert to proper width without a cast.
4185 * xmenu.c (dialog_selection_callback): Likewise.
4186
ede49d71
PE
4187 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4188 Also, don't assume VALBITS / RAND_BITS is less than 5,
4189 and don't rely on undefined behavior when shifting a 1 left into
4190 the sign bit.
4191 * lisp.h (get_random): Change signature to match.
4192
2f30ecd0
PE
4193 * lread.c (hash_string): Use size_t, not int, for hash computation.
4194 Normally we prefer signed values; but hashing is special, because
4195 it's better to use unsigned division on hash table sizes so that
4196 the remainder is nonnegative. Also, size_t is the natural width
4197 for hashing into memory. The previous code used 'int', which doesn't
4198 retain enough info to hash well into very large tables.
4199 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4200
2a866e7b
PE
4201 * dbusbind.c: Don't possibly lose pointer info when converting.
4202 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4203 Use XPNTR rather than XHASH, so that the high-order bits of
4204 the pointer aren't lost when converting through void *.
4205
51639eac
PE
4206 * eval.c (Fautoload): Don't double-shift a pointer.
4207
92394119
PE
4208 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4209
dbdb9a7c
JB
42102011-05-06 Juanma Barranquero <lekktu@gmail.com>
4211
4212 * gnutls.c (DEF_GNUTLS_FN):
4213 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4214
db7a0b4f
AS
42152011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4216
4217 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4218 marker. (Bug#8610)
4219
f7ff1b0f 42202011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
4221
4222 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4223 New version that can reserve upto 2GB of heap space.
4224
f7ff1b0f 42252011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
4226
4227 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4228
639c109b
TZ
42292011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4230
4231 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4232 `gnutls_certificate_set_x509_key_file'.
4233
d2127135
JB
42342011-05-05 Juanma Barranquero <lekktu@gmail.com>
4235
4236 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4237 Update dependencies.
4238
e968f4f3
JB
42392011-05-04 Juanma Barranquero <lekktu@gmail.com>
4240
4241 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4242 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4243 Remove unused parameter `fildes'.
4244 * process.c (read_process_output, send_process): Don't pass it.
4245
84d358f0
JB
42462011-05-04 Juanma Barranquero <lekktu@gmail.com>
4247
4248 Fix previous change: the library cache is defined in w32.c.
4249 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4250 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4251
0898ca10
JB
42522011-05-04 Juanma Barranquero <lekktu@gmail.com>
4253
4254 Implement dynamic loading of GnuTLS on Windows.
4255
4256 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4257 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4258 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4259 Declare.
4260
4261 * gnutls.c (Qgnutls_dll): Define.
4262 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4263 (gnutls_*): Declare function pointers.
4264 (init_gnutls_functions): New function to initialize function pointers.
4265 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4266 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4267 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4268 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4269 (emacs_gnutls_write, emacs_gnutls_read)
4270 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4271 (Fgnutls_available_p): New function.
4272 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4273 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4274 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4275
4276 * image.c: Include w32.h.
4277 (Vimage_type_cache): Delete.
4278 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4279 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4280 (w32_delayed_load): Move to w32.c.
4281
4282 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4283
4284 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4285 (w32_delayed_load): Move from image.c. When loading a library, record
4286 its filename in the :loaded-from property of the library id.
4287 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4288 Initialize and staticpro them.
4289 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4290
4291 * process.c: Include lisp.h before w32.h, not after.
4292 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4293 instead of gnutls_record_check_pending.
4294
4295 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4296
ff4de4aa
TZ
42972011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4298
4299 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4300 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4301 as passed in.
4302
abe95abb
JD
43032011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4304
4305 * xterm.c (x_set_frame_alpha): Do not set property on anything
4306 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4307
e16e55d4
JB
43082011-05-02 Juanma Barranquero <lekktu@gmail.com>
4309
4310 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4311
bafcf6a5
JB
43122011-05-02 Juanma Barranquero <lekktu@gmail.com>
4313
4314 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4315 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4316 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4317 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4318 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4319 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4320 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4321 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4322 (Qgnutls_bootprop_callbacks_verify): Make static.
4323
e7a6747f
AS
43242011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4325
19ed11ba
AS
4326 * callproc.c: Indentation fixup.
4327
e7a6747f 4328 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
4329 (wait_for_termination, interruptible_wait_for_termination):
4330 Move after wait_for_termination_1.
e7a6747f 4331
1ef14cb4
LMI
43322011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4333
4334 * sysdep.c (interruptible_wait_for_termination): New function
4335 which is like wait_for_termination, but allows keyboard
4336 interruptions.
4337
4338 * callproc.c (Fcall_process): Add (:file "file") as an option for
4339 the STDOUT buffer.
4340 (Fcall_process_region): Ditto.
4341
330d880c
EZ
43422011-04-30 Eli Zaretskii <eliz@gnu.org>
4343
8db90b73
EZ
4344 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4345 rather than `XVECTOR (FOO)->size'.
4346
330d880c
EZ
4347 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4348 inttypes.h, as a gnulib replacement is used if it not available in
4349 system headers.
4350
15cbd324
EZ
43512011-04-21 Eli Zaretskii <eliz@gnu.org>
4352
4353 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4354 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4355 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4356
4357 * coding.c (coding_alloc_by_realloc): Error out if destination
4358 will grow beyond MOST_POSITIVE_FIXNUM.
4359 (decode_coding_emacs_mule): Abort if there isn't enough place in
4360 charbuf for the composition carryover bytes. Reserve an extra
4361 space for up to 2 characters produced in a loop.
4362 (decode_coding_iso_2022): Abort if there isn't enough place in
4363 charbuf for the composition carryover bytes.
4364
43652011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 4366
ae940cca
EZ
4367 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4368 aborting when %lld or %lll format is passed.
4369 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4370 %llo or %llx format is passed. (Bug#8545)
4371
03ab8921
EZ
4372 * window.c (window_scroll_line_based): Use a marker instead of
4373 simple variables to record original value of point. (Bug#7952)
4374
afda1437
EZ
4375 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4376 produced by %s or %c overflows available buffer space. (Bug#8545)
4377
f76dee0c
PE
43782011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4379
4380 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 4381 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 4382
fdc5744d
JB
43832011-04-28 Juanma Barranquero <lekktu@gmail.com>
4384
4385 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4386
638f053a
JB
43872011-04-28 Juanma Barranquero <lekktu@gmail.com>
4388
4389 * keyboard.c (Qdelayed_warnings_hook): Define.
4390 (command_loop_1): Run `delayed-warnings-hook'
4391 if Vdelayed_warnings_list is non-nil.
4392 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4393 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4394
d178f871
EZ
43952011-04-28 Eli Zaretskii <eliz@gnu.org>
4396
4397 * doprnt.c (doprnt): Don't return value smaller than the buffer
4398 size if the message was truncated. (Bug#8545).
4399
b124fd93
JB
44002011-04-28 Juanma Barranquero <lekktu@gmail.com>
4401
4402 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4403 (Fx_window_property): #if-0 the whole functions, not just the bodies.
4404
e810457d
PE
44052011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4406
4407 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4408
ea51cceb
JB
44092011-04-27 Juanma Barranquero <lekktu@gmail.com>
4410
4411 * makefile.w32-in: Update dependencies.
4412
94dcfacf
EZ
44132011-04-27 Eli Zaretskii <eliz@gnu.org>
4414
4415 Improve `doprnt' and its usage. (Bug#8545)
4416 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
4417 `format_end'. Remove support for %l as a conversion specifier.
4418 Don't use xrealloc. Improve diagnostics when the %l size modifier
4419 is used. Update the commentary.
4420
4421 * eval.c (verror): Simplify calculation of size_t.
4422
4423 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
4424 messages.
4425
f61f41d7
PE
44262011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
4427
4428 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
4429 change.
4430
96fb4434
PE
44312011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4432
4433 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
4434 This makes this file independent of the recent pseudovector change.
4435
671875da 44362011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 4437
69e9b5a3
PE
4438 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
4439
b5f869a7 4440 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 4441 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 4442 Remove unused local.
c8926152 4443 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 4444
841a1577 4445 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
4446 GCC 4.6.0 optimizes based on type-based alias analysis.
4447 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
4448 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
4449 != &v->size, and therefore "v->size = 1; b->size = 2; return
4450 v->size;" must therefore return 1. This assumption is incorrect
4451 for Emacs, since it type-puns struct Lisp_Vector * with many other
4452 types. To fix this problem, this patch adds a new type struct
f904488f 4453 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
4454 and pseudovectors, and helps optimizing compilers not get fooled
4455 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
4456 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
4457 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
4458 the size member.
eab3844f
PE
4459 (XSETPVECTYPE): Rewrite in terms of new macro.
4460 (XSETPVECTYPESIZE): New macro, specifying both type and size.
4461 This is a bit clearer, and further avoids the possibility of
4462 undesirable aliasing.
4463 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 4464 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
4465 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
4466 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
4467 (ASIZE): Now uses header.size rather than size.
4468 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
4469 to avoid the hassle of writing XVECTOR (foo)->header.size.
4470 (struct vectorlike_header): New type.
eab3844f
PE
4471 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
4472 object, to help avoid aliasing.
4473 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
4474 (SUBRP): Likewise, since Lisp_Subr is a special case.
4475 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
4476 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
4477 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 4478 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
4479 changed to be "header.size" and "header.next".
4480 * buffer.h (struct buffer): Likewise.
4481 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
4482 * frame.h (struct frame): Likewise.
4483 * process.h (struct Lisp_Process): Likewise.
4484 * termhooks.h (struct terminal): Likewise.
4485 * window.c (struct save_window_data, struct saved_window): Likewise.
4486 * window.h (struct window): Likewise.
4487 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
4488 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
4489 * buffer.c (init_buffer_once): Likewise.
4490 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
4491 special case.
4492 * process.c (Fformat_network_address): Use local var for size,
4493 for brevity.
4494
0df1eac5
PE
4495 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
4496
847ab9d1 4497 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
4498 * data.c (atof): Remove decl; no longer used or needed.
4499 (digit_to_number): Move to lread.c.
4500 (Fstring_to_number): Use new string_to_number function, to be
4501 consistent with how the Lisp reader treats infinities and NaNs.
4502 Do not assume that floating-point numbers represent EMACS_INT
4503 without losing information; this is not true on most 64-bit hosts.
4504 Avoid double-rounding errors, by insisting on integers when
4505 parsing non-base-10 numbers, as the documentation specifies.
4506 * lisp.h (string_to_number): New decl, replacing ...
4507 (isfloat_string): Remove.
bc0a5c13 4508 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 4509 (read1): Do not accept +. and -. as integers; this
452f4150
PE
4510 appears to have been a coding error. Similarly, do not accept
4511 strings like +-1e0 as floating point numbers. Do not report
4512 overflow for integer overflows unless the base is not 10 which
4513 means we have no simple and reliable way to continue.
4514 Break out the floating-point parsing into a new
4515 function string_to_number, so that Fstring_to_number parses
4516 floating point numbers consistently with the Lisp reader.
04f2d78b 4517 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
4518 (E_CHAR, EXP_INT): Remove, replacing with ...
4519 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
4520 (string_to_number): New function, replacing isfloat_string.
4521 This function checks for valid syntax and produces the resulting
4522 Lisp float number too. Rework it so that string-to-number
bc0a5c13 4523 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
4524 so that overflow for non-base-10 numbers is reported only when
4525 there's no portable and simple way to convert to floating point.
452f4150 4526
67769ffc
PE
4527 * textprop.c (set_text_properties_1): Rewrite for clarity,
4528 and to avoid GCC warning about integer overflow.
4529
c20db43f
PE
4530 * intervals.h (struct interval): Use EMACS_INT for members
4531 where EMACS_UINT might cause problems. See
4532 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
4533 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
4534 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
4535 All uses changed.
37aa2f85
PE
4536 (offset_intervals): Tell GCC not to worry about length overflow
4537 when negating a negative length.
c20db43f 4538
2538aa2f
PE
4539 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
4540 (overrun_check_free): Likewise.
4541
f2d3008d
PE
4542 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
4543 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
4544 word size.
4545
ec8df744
PE
4546 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4547 (gnutls_make_error): Rename local to avoid shadowing.
4548 (gnutls_emacs_global_deinit): ifdef out; not used.
4549 (Fgnutls_boot): Use const for pointer to readonly storage.
4550 Comment out unused local. Fix pointer signedness problems.
4551
640ee02d
PE
4552 * lread.c (openp): Don't stuff size_t into an 'int'.
4553 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4554 about possible signed overflow.
4555
6048fb2a
PE
4556 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4557 (GDK_KEY_g): Don't define if already defined.
4558 (xg_prepare_tooltip): Avoid pointer signedness problem.
4559 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
4560
fa3c87e1
PE
4561 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4562 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4563
2172544b
PE
4564 * xfns.c (Fx_window_property): Simplify a bit,
4565 to make a bit faster and to avoid GCC 4.6.0 warning.
4566 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4567
9b821a21
PE
4568 * fns.c (internal_equal): Don't assume size_t fits in int.
4569
3c616cfa
PE
4570 * alloc.c (compact_small_strings): Tighten assertion a little.
4571
c2982e87
PE
4572 Replace pEd with more-general pI, and fix some printf arg casts.
4573 * lisp.h (pI): New macro, generalizing old pEd macro to other
4574 conversion specifiers. For example, use "...%"pI"d..." rather
4575 than "...%"pEd"...".
4576 (pEd): Remove. All uses replaced with similar uses of pI.
4577 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4578 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4579 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4580 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4581 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4582 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4583 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4584 64-bit hosts.
4585 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4586 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4587 * print.c (safe_debug_print, print_object): Likewise.
4588 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4589 to int.
6f04d126
PE
4590 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4591 avoiding the 0 flag, which is not portable.
c2982e87
PE
4592 * process.c (Fmake_network_process): Use pI to avoid cast.
4593 * region-cache.c (pp_cache): Likewise.
4594 * xdisp.c (decode_mode_spec): Likewise.
4595 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4596 behavior on 64-bit hosts with printf arg.
6f04d126 4597 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
4598 (x_stop_queuing_selection_requests): Likewise.
4599 (x_get_window_property): Don't truncate byte count to an 'int'
4600 when tracing.
0b432f21 4601
5e073ec7
PE
4602 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4603 here, since it parses constructs like leading '-' and spaces,
4604 which are not wanted; and it overflows with large numbers.
4605 Instead, simply match F[0-9]+, which is what is wanted anyway.
4606
36372bf9
PE
4607 * alloc.c: Remove unportable assumptions about struct layout.
4608 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4609 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4610 (allocate_vectorlike, make_pure_vector): Use the new macros,
4611 plus offsetof, to remove unportable assumptions about struct layout.
4612 These assumptions hold on all porting targets that I know of, but
4613 they are not guaranteed, they're easy to remove, and removing them
4614 makes further changes easier.
4615
0b432f21
PE
4616 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4617 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
4618 (string_overrun_cookie): Now const. Use initializers that
4619 don't formally overflow signed char, to avoid warnings.
000098c1
PE
4620 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
4621 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
4622 (allocate_buffer): Don't assume sizeof (struct buffer) is a
4623 multiple of sizeof (EMACS_INT); it need not be, if
4624 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 4625 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 4626
895009e1
JB
46272011-04-26 Juanma Barranquero <lekktu@gmail.com>
4628
4629 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
4630
6a7a1b0b
TZ
46312011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
4632
4633 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 4634 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
4635 Reported by Paul Eggert <eggert@cs.ucla.edu>.
4636
841a1577 46372011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
4638
4639 * lisp.h (Qdebug): List symbol.
895009e1 4640 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
4641 * keyboard.c (debug-on-event): New variable.
4642 (handle_user_signal): Break into debugger when debug-on-event
4643 matches the current signal symbol.
4644
f2d3ba6f
DN
46452011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
4646
4647 * alloc.c (check_sblock, check_string_bytes)
4648 (check_string_free_list): Convert to standard C.
4649
42ce4c63
TZ
46502011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
4651
4652 * w32.c (emacs_gnutls_push): Fix typo.
4653
825cd63c
EZ
46542011-04-25 Eli Zaretskii <eliz@gnu.org>
4655
fb11d64d
EZ
4656 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
4657 "cast to pointer from integer of different size".
4658
825cd63c
EZ
4659 Improve doprnt and its use in verror. (Bug#8545)
4660 * doprnt.c (doprnt): Document the set of format control sequences
4661 supported by the function. Use SAFE_ALLOCA instead of always
4662 using `alloca'.
4663
4664 * eval.c (verror): Don't limit the buffer size at size_max-1, that
4665 is one byte too soon. Don't use xrealloc; instead xfree and
4666 xmalloc anew.
4667
e061a11b
TZ
46682011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
4669
4670 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
4671 callbacks stage.
4672
4673 * gnutls.c: Renamed global_initialized to
4674 gnutls_global_initialized. Added internals for the
4675 :verify-hostname-error, :verify-error, and :verify-flags
4676 parameters of `gnutls-boot' and documented those parameters in the
4677 docstring. Start callback support.
9173deec
JB
4678 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
4679 unless a fatal error occurred. Call gnutls_alert_send_appropriate
4680 on error. Return error code.
e061a11b
TZ
4681 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
4682 (emacs_gnutls_read): Likewise.
4683 (Fgnutls_boot): Return handshake error code.
4684 (emacs_gnutls_handle_error): New function.
4685 (wsaerror_to_errno): Likewise.
4686
4687 * w32.h (emacs_gnutls_pull): Add prototype.
4688 (emacs_gnutls_push): Likewise.
4689
4690 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
4691 (emacs_gnutls_push): Likewise.
4692
46932011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
4694
4695 * process.c (wait_reading_process_output): Check if GnuTLS
4696 buffered some data internally if no FDs are set for TLS
4697 connections.
4698
4699 * makefile.w32-in (OBJ2): Add gnutls.$(O).
4700 (LIBS): Link to USER_LIBS.
4701 ($(BLD)/gnutls.$(0)): New target.
4702
fa6996bc
EZ
47032011-04-24 Eli Zaretskii <eliz@gnu.org>
4704
eb35682e
EZ
4705 * xdisp.c (handle_single_display_spec): Rename the
4706 display_replaced_before_p argument into display_replaced_p, to
4707 make it consistent with the commentary. Fix typos in the
4708 commentary.
4709
e2ad650c
EZ
4710 * textprop.c (syms_of_textprop): Remove dead code.
4711 (copy_text_properties): Delete obsolete commentary about an
4712 interface that was deleted long ago. Fix typos in the description
4713 of arguments.
4714
1b2de274
EZ
4715 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
4716 to changes in oldXMenu/XMenu.h from 2011-04-16.
4717 <menu_help_message, prev_menu_help_message>: Constify.
4718 (IT_menu_make_room): menu->help_text is now `const char **';
4719 adjust.
4720
4721 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
4722 to changes in oldXMenu/XMenu.h from 2011-04-16.
4723 (struct XMenu): Declare `help_text' `const char **'.
4724
4725 * xfaces.c <Qunspecified>: Make extern again.
4726
4727 * syntax.c: Include sys/types.h before including regex.h, as
4728 required by Posix.
4729
762b15be
EZ
4730 * doc.c (get_doc_string): Improve the format passed to `error'.
4731
4732 * doprnt.c (doprnt): Improve commentary.
4733
4734 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
4735
4736 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
4737 them with etags.
4738
f1052e5d
EZ
4739 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
4740 changes in globals.h immediately force recompilation.
762b15be
EZ
4741 (TAGS): Depend on $(CURDIR)/m/intel386.h and
4742 $(CURDIR)/s/ms-w32.h.
4743 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 4744
fa6996bc
EZ
4745 * character.c (Fchar_direction): Function deleted.
4746 (syms_of_character): Don't defsubr it.
4747 <char-direction-table>: Deleted.
4748
e6c3da20
EZ
47492011-04-23 Eli Zaretskii <eliz@gnu.org>
4750
4751 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
4752 * doprnt.c: Include limits.h.
4753 (SIZE_MAX): New macro.
04f2d78b
CB
4754 (doprnt): Return a size_t value. 2nd arg is now size_t.
4755 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
4756 Improve overflow protection. Support `l' modifier for integer
4757 conversions. Support %l conversion. Don't assume an EMACS_INT
4758 argument for integer conversions and for %c.
4759
4760 * lisp.h (doprnt): Restore prototype.
4761
4762 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
4763 $(SRC)/character.h.
4764
4765 * Makefile.in (base_obj): Add back doprnt.o.
4766
4767 * deps.mk (doprnt.o): Add back prerequisites.
4768 (callint.o): Depend on character.h.
4769
4770 * eval.c (internal_lisp_condition_case): Include the handler
4771 representation in the error message.
4772 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
4773 when breaking from the loop.
4774
4775 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
4776
4777 * callint.c (Fcall_interactively): When displaying error message
4778 about invalid control letter, pass the character's codepoint, not
4779 a pointer to its multibyte form. Improve display of the character
4780 in octal and display also its hex code.
4781
4782 * character.c (char_string): Use %x to display the (unsigned)
4783 codepoint of an invalid character, to avoid displaying a bogus
4784 negative value.
4785
4786 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
4787 `error', not SYMBOL_NAME itself.
4788
4789 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
4790 character arguments to `error'.
4791
4792 * charset.c (check_iso_charset_parameter): Fix incorrect argument
4793 to `error' in error message about FINAL_CHAR argument. Make sure
4794 FINAL_CHAR is a character, and use %c when it is passed as
4795 argument to `error'.
4796
4ffd0d6b 47972011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
4798
4799 * s/ms-w32.h (localtime): Redirect to sys_localtime.
4800
4801 * w32.c: Include <time.h>.
4802 (sys_localtime): New function.
4803
4ffd0d6b 48042011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
4805
4806 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
4807
4ffd0d6b 4808 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 4809
4ffd0d6b 48102011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 4811
4ffd0d6b
GM
4812 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4813 zombies (Bug#8467).
aac0c6e3 4814
04c56954
EZ
48152011-04-19 Eli Zaretskii <eliz@gnu.org>
4816
4817 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4818 gl_state.e_property when gl_state.object is Qt.
4819
4820 * insdel.c (make_gap_larger): Remove limitation of buffer size
4821 to <= INT_MAX.
4822
16a43933
CY
48232011-04-18 Chong Yidong <cyd@stupidchicken.com>
4824
4825 * xdisp.c (lookup_glyphless_char_display)
4826 (produce_glyphless_glyph): Handle cons cell entry in
4827 glyphless-char-display.
4828 (Vglyphless_char_display): Document it.
4829
4830 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4831 glyphless-char-display.
4832
4581706e
CY
48332011-04-17 Chong Yidong <cyd@stupidchicken.com>
4834
4835 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4836
4837 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4838
4839 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4840 definition for no-X builds.
4841
4887c6e2 48422011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 4843
fd35b6f9
PE
4844 Static checks with GCC 4.6.0 and non-default toolkits.
4845
5c1ccb01
PE
4846 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4847
006c5daa
PE
4848 * process.c (keyboard_bit_set): Define only if SIGIO.
4849 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4850 (send_process): Repair possible setjmp clobbering.
4851
efc736d3
PE
4852 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4853
4e2fe2e6
PE
4854 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4855
f97334a2
PE
4856 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4857
4e75f29d
PE
4858 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4859 Define only if needed.
4860
90efadd1
PE
4861 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4862 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 4863 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 4864
3c647824
PE
4865 * dispextern.h (struct redisplay_interface): Rename param
4866 to avoid shadowing.
e264f262 4867 * termhooks.h (struct terminal): Likewise.
761383f4 4868 * xterm.c (xembed_send_message): Likewise.
3c647824 4869
b58c5c4a
PE
4870 * insdel.c (make_gap_smaller): Define only if
4871 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4872
cad59032
PE
4873 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4874 it.
4875
c339dc2e
PE
4876 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4877 so that we aren't warned about unused symbols.
4878
91a3e27b
PE
4879 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4880
399c71d3 4881 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 4882
8ffc96f5
PE
4883 * xfns.c (x_real_positions): Mark locals as initialized.
4884
eef9bc79
PE
4885 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4886
098db9dd
PE
4887 * xterm.c: Fix problems found by static analysis with other toolkits.
4888 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
4889 (x_dispatch_event): Declare static if USE_GTK, and
4890 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 4891 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 4892 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
4893 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4894 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 4895
eb18f6cc
PE
4896 * xmenu.c (menu_help_callback): Pointer type fixes.
4897 Use const pointers when pointing at readonly data. Avoid pointer
4898 signedness clashes.
4899 (FALSE): Remove unused macro.
4900 (update_frame_menubar): Remove unused decl.
4901
1fe72bf8
PE
4902 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4903
60d9e1db
PE
4904 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4905 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4906 (single_menu_item): Rename local to avoid shadowing.
4907
39261c26
PE
4908 * keyboard.c (make_lispy_event): Remove unused local var.
4909
018c5e19
PE
4910 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4911 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4912
63d2b86e
PE
4913 * bitmaps: Change bitmaps from unsigned char back to the X11
4914 compatible char. Avoid the old compiler warnings about
4915 out-of-range initializers by using, for example, '\xab' rather
4916 than 0xab.
4917
aefd87e1
PE
4918 * xgselect.c (xgselect_initialize): Check vs interface
4919 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4920
bf501fb9
PE
4921 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4922
e9829fdf
PE
4923 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4924 to read-only memory.
4925
1086c095
PE
4926 * fns.c (vector): Remove; this old hack is no longer needed.
4927
2baccd04 4928 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 4929 Remove unused var.
dde42981 4930 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 4931
72391843 4932 * xrdb.c (x_load_resources): Omit unused local.
3565b346 4933
436c16df 4934 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 4935 (x_window): Rename locals to avoid shadowing.
dc5ddd85 4936 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 4937
92bb796d 4938 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 4939 (x_term_init): Remove local to avoid shadowing.
92bb796d 4940
764430a3 4941 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
4942
4943 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4944 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4945
d1dfb56c
EZ
49462011-04-16 Eli Zaretskii <eliz@gnu.org>
4947
c4354cb4
EZ
4948 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4949
d1dfb56c
EZ
4950 Fix regex.c, syntax.c and friends for buffers > 2GB.
4951 * syntax.h (struct gl_state_s): Declare character position members
4952 EMACS_INT.
4953
4954 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4955
04f2d78b
CB
4956 * textprop.c (verify_interval_modification, interval_of):
4957 Declare arguments EMACS_INT.
d1dfb56c
EZ
4958
4959 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4960 EMACS_INT.
4961
4962 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4963
4964 * indent.c (Fvertical_motion): Local variable it_start is now
4965 EMACS_INT.
4966
4967 * regex.c (re_match, re_match_2, re_match_2_internal)
4968 (bcmp_translate, regcomp, regexec, print_double_string)
4969 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4970 (re_compile_pattern, re_exec): Declare arguments and local
4971 variables `size_t' and `ssize_t' and return values `regoff_t', as
4972 appropriate.
4973 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4974 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4975 <compile_stack_type>: `size' and `avail' are now `size_t'.
4976
4977 * regex.h <regoff_t>: Use ssize_t, not int.
4978 (re_search, re_search_2, re_match, re_match_2): Arguments that
4979 specify buffer/string position and length are now ssize_t and
4980 size_t. Return type is regoff_t.
4981
613052cd
BK
49822011-04-16 Ben Key <bkey76@gmail.com>
4983
4984 * nsfont.m: Fixed bugs in ns_get_family and
4985 ns_descriptor_to_entity that were caused by using free to
4986 deallocate memory blocks that were allocated by xmalloc (via
4987 xstrdup). This caused Emacs to crash when compiled with
4988 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4989 --enable-checking=xmallocoverrun). xfree is now used to
4990 deallocate these memory blocks.
4991
4170f62f 49922011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 4993
71b41406
PE
4994 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4995
9587a89d
PE
4996 emacs_write: Accept and return EMACS_INT for sizes.
4997 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4998 et seq.
4999 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5000 Accept and return EMACS_INT.
5001 (emacs_gnutls_write): Return the number of bytes written on
5002 partial writes.
5003 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
5004 (emacs_read, emacs_write): Remove check for negative size, as the
5005 Emacs source code has been audited now.
9587a89d
PE
5006 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5007 (emacs_read, emacs_write): Use it.
273a5f82
PE
5008 * process.c (send_process): Adjust to the new signatures of
5009 emacs_write and emacs_gnutls_write. Do not attempt to store
5010 a byte offset into an 'int'; it might overflow.
9587a89d 5011 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 5012
3e047f51
PE
5013 * sound.c: Don't assume sizes fit in 'int'.
5014 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 5015 Return EMACS_INT, not int.
3e047f51 5016 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
5017 Accept EMACS_INT, not int.
5018 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
5019 record read return values.
5020
cc39a9db
BK
50212011-04-15 Ben Key <bkey76@gmail.com>
5022
c9d0ec6d
JB
5023 * keyboard.c (Qundefined): Don't declare static since it is used
5024 in nsfns.m.
5025 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5026 static since they are used in nsfont.m.
cc39a9db 5027
6c60eb9f
SM
50282011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5029
5030 * process.c (Qprocessp): Don't declare static.
5031 * lisp.h (Qprocessp): Declare again.
5032
7990b61a
JB
50332011-04-15 Juanma Barranquero <lekktu@gmail.com>
5034
5035 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5036
5d4cb038
PE
50372011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5038
8bd7b830 5039 Improve C-level modularity by making more things 'static'.
cd64ea1d 5040
e3b27b31
PE
5041 Don't publish debugger-only interfaces to other modules.
5042 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5043 (verify_bytepos, count_markers): Move decls to the only modules
5044 that need them.
5045 * region-cache.h (pp_cache): Likewise.
5046 * window.h (check_all_windows): Likewise.
5047 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5048
5d4cb038
PE
5049 * sysdep.c (croak): Now static, if
5050 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5051 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
5052
5053 * alloc.c (refill_memory_reserve): Now static if
5054 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5055 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 5056
e87b6180
PE
5057 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5058 Define only if USE_LUCID.
5059
ac64929e
PE
5060 * xrdb.c (x_customization_string, x_rm_string): Now static.
5061
6f37259d
PE
5062 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5063 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5064
1683e3ab
PE
5065 * xdisp.c (draw_row_with_mouse_face): Now static.
5066 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5067
de9c2632
PE
5068 * window.h (check_all_windows): Mark externally visible.
5069
2b96acb7
PE
5070 * window.c (window_deletion_count): Now static.
5071
5072 * undo.c: Make symbols static if they're not exported.
5073 (last_undo_buffer, last_boundary_position, pending_boundary):
5074 Now static.
5075
50436f33
PE
5076 * textprop.c (interval_insert_behind_hooks): Now static.
5077 (interval_insert_in_front_hooks): Likewise.
5078
64520e5c
PE
5079 * term.c: Make symbols static if they're not exported.
5080 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5081 (max_frame_lines, tty_set_terminal_modes):
5082 (tty_reset_terminal_modes, tty_turn_off_highlight):
5083 (get_tty_terminal): Now static.
5084 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5085 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 5086 HAVE_WINDOW_SYSTEM.
64520e5c
PE
5087 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5088 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5089
1fa53021
PE
5090 * sysdep.c: Make symbols static if they're not exported.
5091 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5092 Now static.
5093 (sigprocmask_set, full_mask): Remove; unused.
5094 (wait_debugging): Mark as visible.
5095 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5096 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5097
d4b43b22
PE
5098 * syntax.c (syntax_temp): Define only if !__GNUC__.
5099
b7c513d0
PE
5100 * sound.c (current_sound_device, current_sound): Now static.
5101
989b29ad
PE
5102 * search.c (searchbufs, searchbuf_head): Now static.
5103
13a55a78
PE
5104 * scroll.c (scroll_cost): Remove; unused.
5105 * dispextern.h (scroll_cost): Remove decl.
5106
de68a1fc
PE
5107 * region-cache.h (pp_cache): Mark as externally visible.
5108
40ccffa6
PE
5109 * process.c: Make symbols static if they're not exported.
5110 (process_tick, update_tick, create_process, chan_process):
5111 (Vprocess_alist, proc_buffered_char, datagram_access):
5112 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5113 (deactivate_process): Mark defn as static, as well as decl.
5114 * lisp.h (create_process): Remove decl.
5115 * process.h (chan_process, Vprocess_alist): Remove decls.
5116
ad64fc97
PE
5117 * print.c: Make symbols static if they're not exported.
5118 (print_depth, new_backquote_output, being_printed, print_buffer):
5119 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5120 (print_interval, print_number_index, initial_stderr_stream):
5121 Now static.
5122 * lisp.h (Fprinc): Remove decl.
5123 (debug_output_compilation_hack): Mark as externally visible.
5124
adddb265
PE
5125 * sysdep.c (croak): Move decl from here to syssignal.h.
5126 * syssignal.h (croak): Put it here, so the API can be checked when
5127 'croak' is called from dissociate_if_controlling_tty.
5128
1717ede2
PE
5129 * minibuf.c: Make symbols static if they're not exported.
5130 (minibuf_save_list, choose_minibuf_frame): Now static.
5131 * lisp.h (choose_minibuf_frame): Remove decl.
5132
fa5fb2bc
PE
5133 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5134
1e3890d1
PE
5135 * lread.c: Make symbols static if they're not exported.
5136 (read_objects, initial_obarray, oblookup_last_bucket_number):
5137 Now static.
5138 (make_symbol): Remove; unused.
5139 * lisp.h (initial_obarray, make_symbol): Remove decls.
5140
8a1414fa
PE
5141 * keyboard.c: Make symbols static if they're not exported.
5142 (single_kboard, recent_keys_index, total_keys, recent_keys):
5143 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5144 (this_single_command_key_start, echoing, last_auto_save):
5145 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5146 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5147 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5148 (Vlispy_mouse_stem, double_click_count):
5149 Now static.
5150 (force_auto_save_soon): Define only if SIGDANGER.
5151 (ignore_mouse_drag_p): Now static if
5152 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5153 (print_help): Remove; unused.
5154 (stop_character, last_timer_event): Mark as externally visible.
5155 * keyboard.h (ignore_mouse_drag_p): Declare only if
5156 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5157 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5158 * lisp.h (echoing): Remove decl.
5159 (force_auto_save_soon): Declare only if SIGDANGER.
5160 * xdisp.c (redisplay_window): Simplify code, to make it more
5161 obvious that ignore_mouse_drag_p is not accessed if !defined
5162 USE_GTK && !defined HAVE_NS.
5163
93ea6e8f
PE
5164 * intervals.c: Make symbols static if they're not exported.
5165 (merge_properties_sticky, merge_interval_right, delete_interval):
5166 Now static.
5167 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5168
77382fcc
PE
5169 * insdel.c: Make symbols static if they're not exported.
5170 However, leave prepare_to_modify_buffer alone. It's never
5171 called from outside this function, but that appears to be a bug.
5172 (combine_after_change_list, combine_after_change_buffer):
4889fc82 5173 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
5174 (adjust_after_replace_noundo): Remove; unused.
5175 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 5176 (signal_before_change): Remove decls.
77382fcc 5177
9306c32e
PE
5178 * indent.c (val_compute_motion, val_vmotion): Now static.
5179
cd44d2eb
PE
5180 * image.c: Make symbols static if they're not exported.
5181 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5182 if USE_GTK.
5183 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5184 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5185
ad9a7a06
PE
5186 * fringe.c (standard_bitmaps): Now static.
5187 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5188
81626931
PE
5189 * frame.c: Make symbols static if they're not exported.
5190 (x_report_frame_params, make_terminal_frame): Now static.
5191 (get_frame_param): Now static, unless HAVE_NS.
5192 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5193 (x_get_resource_string): Remove; not used.
5194 * frame.h (make_terminal_frame, x_report_frame_params):
5195 (x_get_resource_string); Remove decls.
5196 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5197 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5198
239f9db9
PE
5199 * font.c, fontset.c: Make symbols static if they're not exported.
5200 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5201 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5202 * font.c (font_close_object): Now static.
5203 * font.h (font_close_object): Remove.
5204 * fontset.c (FONTSET_OBJLIST): Remove.
5205 (free_realized_fontset) #if-0 the body, which does nothing.
5206 (face_suitable_for_char_p): #if-0, as it's never called.
5207 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
5208 * xfaces.c (face_at_string_position):
5209 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
5210 since 0 is always ASCII.
5211
dfcf3579
PE
5212 * fns.c (weak_hash_tables): Now static.
5213
5045092b
PE
5214 * fileio.c: Make symbols static if they're not exported.
5215 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5216 (Vwrite_region_annotation_buffers): Now static.
5217
57a96f5c
PE
5218 * eval.c: Make symbols static if they're not exported.
5219 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5220 * lisp.h (backtrace_list): Remove decl.
5221
35f08c38
PE
5222 * emacs.c: Make symbols static if they're not exported.
5223 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5224 (fatal_error_code, fatal_error_signal_hook, standard_args):
5225 Now static.
5226 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5227 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5228 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5229 * lisp.h (fatal_error_signal_hook): Remove decl.
5230 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5231
f44bd759
PE
5232 * editfns.c: Move a (normally-unused) function to its only use.
5233 * editfns.c, lisp.h (get_operating_system_release): Remove.
5234 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5235 worth the hassle of breaking this out.
5236
b532497d
PE
5237 * xterm.c: Make symbols static if they're not exported.
5238 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5239 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5240 (x_destroy_window, x_delete_display):
5241 Now static.
5242 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5243 (x_mouse_leave): Remove; unused.
5244 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5245 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5246 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5247 Remove decls.
5248 (x_mouse_leave): Declare only if WINDOWSNT.
5249 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5250 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5251 USE_X_TOOLKIT.
5252
1675728f
PE
5253 * ftxfont.c: Make symbols static if they're not exported.
5254 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5255 HAVE_FREETYPE.
5256 * font.h (ftxfont_driver): Likewise.
5257
e4cebfca
PE
5258 * xfns.c: Make symbols static if they're not exported.
5259 (x_last_font_name, x_display_info_for_name):
5260 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5261 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5262 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5263 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5264 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5265 (last_show_tip_args): Now static.
5266 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5267 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5268 (x_screen_planes): Remove; unused.
5269 * dispextern.h (x_screen_planes): Remove decl.
5270
5bf46f05
PE
5271 * dispnew.c: Make symbols static if they're not exported.
5272 * dispextern.h (redraw_garbaged_frames, scrolling):
5273 (increment_row_positions): Remove.
5274 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5275 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5276 Now static.
5277 (redraw_garbaged_frames): Remove; unused.
5278
435f4c28
PE
5279 * xfaces.c: Make symbols static if they're not exported.
5280 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5281 Remove decls.
5282 * xterm.h (defined_color): Remove decls.
5283 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5284 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5285 (menu_face_changed_default, defined_color, free_realized_face):
5286 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5287 (ascii_face_of_lisp_face): Remove; unused.
5288
8524aef3
PE
5289 * xdisp.c: Make symbols static if they're not exported.
5290 * dispextern.h (scratch_glyph_row, window_box_edges):
5291 (glyph_to_pixel_coords, set_cursor_from_row):
5292 (get_next_display_element, set_iterator_to_next):
5293 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5294 (show_mouse_face): Remove decls
5295 * frame.h (message_buf_print): Likewise.
5296 * lisp.h (pop_message, set_message, check_point_in_composition):
5297 Likewise.
5298 * xterm.h (set_vertical_scroll_bar): Likewise.
5299 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5300 (message_buf_print, scratch_glyph_row, displayed_buffer):
5301 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5302 (get_next_display_element, show_mouse_face, window_box_edges):
5303 (frame_to_window_pixel_xy, check_point_in_composition):
5304 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5305 (glyph_to_pixel_coords): Remove; unused.
5306
16390cd2
PE
5307 * dired.c (file_name_completion): Now static.
5308
5309 * dbusbind.c (xd_in_read_queued_messages): Now static.
5310
a25f4dfa
PE
5311 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5312 * data.c (circular_list_error): Remove.
5313
14a9c8df
PE
5314 * commands.h (last_point_position, last_point_position_buffer):
5315 (last_point_position_window): Remove decls.
5316 * keyboard.c: Make these variables static.
5317
04f2d78b
CB
5318 * coding.h (coding, code_convert_region, encode_coding_gap):
5319 Remove decls.
74ab6df5
PE
5320 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5321 (iso_code_class, detect_coding, code_convert_region): Now static.
5322 (encode_coding_gap): Remove; unused.
5323
38dfbee1
PE
5324 * chartab.c (chartab_chars, chartab_bits): Now static.
5325
a2cb4e63
PE
5326 * charset.h (charset_iso_8859_1): Remove decl.
5327 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5328 Now static.
5329
127198fd
PE
5330 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5331 * ccl.c (Vccl_program_table): Now static.
5332 (check_ccl_update): Remove; unused.
5333
d85b608f
PE
5334 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5335 * category.h: ... from here.
5336 * category.c (check_category_table, set_category_set): Now static.
5337
31cd66f3
PE
5338 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5339 * lisp.h: Remove these decls.
5340
c358e587
PE
5341 * buffer.c (buffer_count): Remove unused var.
5342
e78aecca
PE
5343 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5344 so that it's not optimized away.
5345 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5346 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5347 exported only to the debugger.
5348
e192d7d3 5349 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 5350 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 5351
92470028
PE
5352 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5353 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5354 was inaccessible from Lisp.
5355 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5356 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5357
244ed907
PE
5358 alloc.c: Import and export fewer symbols, and remove unused items.
5359 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5360 is defined.
5361 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5362 it's not optimized away by whole-program optimization.
5363 (message_enable_multibyte, free_misc): Remove.
5364 (catchlist, handlerlist, mark_backtrace):
5365 Declare only if BYTE_MARK_STACK.
5366 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5367 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5368 (message_enable_multibyte): Remove decl.
5369 (free_misc, interval_free_list, float_block, float_block_index):
5370 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5371 (cons_free_list, last_marked_index):
5372 Now static.
5373 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5374 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5375 (mark_backtrace): Define only if BYTE_MARK_STACK.
5376 * xdisp.c (message_enable_multibyte): Now static.
5377
61c2b50e 5378 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
5379 This makes it easier for human readers (and static analyzers)
5380 to see whether these variables are used from other modules.
5381 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5382 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5383 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5384 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5385 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5386 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5387 * xmenu.c, xselect.c:
5388 Declare Q* vars static if they are not used in other modules.
5389 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5390 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5391 Remove decls of unexported vars.
5392 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5393
95c82688
PE
5394 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5395
16a97296
PE
5396 Make Emacs functions such as Fatom 'static' by default.
5397 This makes it easier for human readers (and static analyzers)
5398 to see whether these functions can be called from other modules.
5399 DEFUN now defines a static function. To make the function external
5400 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
5401 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5402 (Finit_image_library):
16a97296
PE
5403 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5404 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
5405 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
5406 Remove decls, since these functions are now static.
5407 (Funintern, Fget_internal_run_time): New decls, since these functions
5408 were already external.
95c82688 5409
16a97296
PE
5410 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
5411 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
5412 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
5413 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
5414 * keyboard.c, keymap.c, lread.c:
5415 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
5416 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
5417 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
5418 Mark functions with DEFUE instead of DEFUN,
5419 if they are used in other modules.
5420 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
5421 decls for now-static functions.
5422 * buffer.h (Fdelete_overlay): Remove decl.
5423 * callproc.c (Fgetenv_internal): Mark as internal.
5424 * composite.c (Fremove_list_of_text_properties): Remove decl.
5425 (Fcomposition_get_gstring): New forward static decl.
5426 * composite.h (Fcomposite_get_gstring): Remove decl.
5427 * dired.c (Ffile_attributes): New forward static decl.
5428 * doc.c (Fdocumntation_property): New forward static decl.
5429 * eval.c (Ffetch_bytecode): New forward static decl.
5430 (Funintern): Remove extern decl; now in .h file where it belongs.
5431 * fileio.c (Fmake_symbolic_link): New forward static decl.
5432 * image.c (Finit_image_library): New forward static decl.
5433 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
5434 * intervals.h (Fprevious_property_change):
5435 (Fremove_list_of_text_properties): Remove decls.
5436 * keyboard.c (Fthis_command_keys): Remove decl.
5437 (Fcommand_execute): New forward static decl.
5438 * keymap.c (Flookup_key): New forward static decl.
5439 (Fcopy_keymap): Now static.
5440 * keymap.h (Flookup_key): Remove decl.
5441 * process.c (Fget_process): New forward static decl.
5442 (Fprocess_datagram_address): Mark as internal.
5443 * syntax.c (Fsyntax_table_p): New forward static decl.
5444 (skip_chars): Remove duplicate decl.
5445 * textprop.c (Fprevious_property_change): New forward static decl.
5446 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
5447 Now internal.
5448 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
5449 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
5450
785bbd42
PE
5451 * editfns.c (Fformat): Remove unreachable code.
5452
8b913b57
AS
54532011-04-14 Andreas Schwab <schwab@linux-m68k.org>
5454
5455 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
5456 change. (Bug#8496)
5457
a6744a35
EZ
54582011-04-13 Eli Zaretskii <eliz@gnu.org>
5459
5460 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
5461 when at ZV. (Bug#8487)
5462
e7974947
AS
54632011-04-12 Andreas Schwab <schwab@linux-m68k.org>
5464
baad03f0
AS
5465 * charset.c (Fclear_charset_maps): Use xfree instead of free.
5466 (Bug#8437)
5467 * keyboard.c (parse_tool_bar_item): Likewise.
5468 * sound.c (sound_cleanup, alsa_close): Likewise.
5469 * termcap.c (tgetent): Likewise.
5470 * xfns.c (x_default_font_parameter): Likewise.
5471 * xsettings.c (read_and_apply_settings): Likewise.
5472
e7974947
AS
5473 * alloc.c (overrun_check_malloc, overrun_check_realloc)
5474 (overrun_check_free): Protoize.
5475
28272684
PE
54762011-04-12 Paul Eggert <eggert@cs.ucla.edu>
5477
5478 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
5479 since callers should never pass a negative size.
5480 Change the signature to match that of plain 'read' and 'write'; see
5481 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
5482 * lisp.h: Update prototypes of emacs_write and emacs_read.
5483
11997c76
EZ
54842011-04-11 Eli Zaretskii <eliz@gnu.org>
5485
5486 * xdisp.c (redisplay_window): Don't try to determine the character
5487 position of the scroll margin if the window start point w->startp
e896f03c 5488 is outside the buffer's accessible region. (Bug#8468)
11997c76 5489
8a2cbd72
EZ
54902011-04-10 Eli Zaretskii <eliz@gnu.org>
5491
5492 Fix write-region and its subroutines for buffers > 2GB.
5493 * fileio.c (a_write, e_write): Modify declaration of arguments and
5494 local variables to support buffers larger than 2GB.
5495 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
5496
5497 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
5498 argument, local variables, and return value.
5499
5500 * lisp.h: Update prototypes of emacs_write and emacs_read.
5501
5502 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
5503
4073e537 55042011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 5505
1ebfdcb6
PE
5506 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
5507
b2ded58d
PE
5508 Fix more problems found by GCC 4.6.0's static checks.
5509
7d66342c
PE
5510 * xdisp.c (vmessage): Use a better test for character truncation.
5511
bbf47d44
PE
5512 * charset.c (load_charset_map): <, not <=, for optimization,
5513 and to avoid potential problems with integer overflow.
9248994d 5514 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 5515 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 5516 * editfns.c (Fformat): Likewise.
1e69125e 5517 * syntax.c (skip_chars): Likewise.
3befa583 5518
e3019616
PE
5519 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
5520 This also lets GCC 4.6.0 generate slightly better loop code.
5521
becfa255
PE
5522 * callint.c (Fcall_interactively): <, not <=, for optimization.
5523 (Fcall_interactively): Count the number of arguments produced,
5524 not the number of arguments given. This is simpler and lets GCC
5525 4.6.0 generate slightly better code.
5526
dae0cd48
PE
5527 * ftfont.c: Distingish more carefully between FcChar8 and char.
5528 The previous code passed unsigned char * to a functions like
5529 strlen and xstrcasecmp that expect char *, which does not
5530 conform to the C standard.
5531 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
5532 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
5533 char * when the C standard requires it.
5534
76032d70
PE
5535 * keyboard.c (read_char): Remove unused var.
5536
eb3f1cc8
PE
5537 * eval.c: Port to Windows vsnprintf (Bug#8435).
5538 Include <limits.h>.
5539 (SIZE_MAX): Define if the headers do not.
5540 (verror): Do not give up if vsnprintf returns a negative count.
5541 Instead, grow the buffer. This ports to Windows vsnprintf, which
5542 does not conform to C99. Problem reported by Eli Zaretskii.
5543 Also, simplify the allocation scheme, by avoiding the need for
5544 calling realloc, and removing the ALLOCATED variable.
5545
70476b54
PE
5546 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5547
12020a9e
PE
5548 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5549 But keep the doprint source code for now, as we might revamp it
5550 and use it again (Bug#8435).
ea6c7ae6
PE
5551 * lisp.h (doprnt): Remove.
5552 * Makefile.in (base_obj): Remove doprnt.o.
5553 * deps.mk (doprnt.o): Remove.
5554
5fdb398c
PE
5555 error: Print 32- and 64-bit integers portably (Bug#8435).
5556 Without this change, on typical 64-bit hosts error ("...%d...", N)
5557 was used to print both 32- and 64-bit integers N, which relied on
5558 undefined behavior.
5559 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
5560 New macro.
5561 * lisp.h (error, verror): Mark as printf-like functions.
5562 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5563 Report overflow in size calculations when allocating printf buffer.
5564 Do not truncate output string at its first null byte.
5565 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5566 Truncate the output at a character boundary, since vsnprintf does not
5567 do that.
5568 * charset.c (check_iso_charset_parameter): Convert internal
5569 character to string before calling 'error', since %c now has the
5570 printf meaning.
5571 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5572 overflow when computing char to be passed to 'error'. Do not
5573 pass Lisp_Object to 'error'; pass the integer instead.
5574 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5575 formatted with plain %d.
5576
b189fa66
PE
5577 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5578
bff87ef0
PE
5579 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5580
7e2cac20
PE
5581 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5582
ce4d90b5
PE
5583 * xterm.c (x_catch_errors): Remove duplicate declaration.
5584
266c9547
PE
5585 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5586
79c49ad2
PE
5587 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5588
368f4090
JM
55892011-04-10 Jim Meyering <meyering@redhat.com>
5590
5591 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5592 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5593 return ssize_t not "int", and use size_t as the buffer length.
5594 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5595 * gnutls.h: Update declarations.
5596 * process.c (read_process_output): Use ssize_t, to match.
5597 (send_process): Likewise.
5598
a32d4040
CY
55992011-04-09 Chong Yidong <cyd@stupidchicken.com>
5600
5601 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5602
8546720e 56032011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 5604
04f2d78b
CB
5605 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5606 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 5607
8546720e
GM
5608 * xterm.c (handle_one_xevent):
5609 * xmenu.c (create_and_show_popup_menu):
5610 * xselect.c (x_decline_selection_request)
5611 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 5612
0a2f5c1a 56132011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
5614
5615 Fix some uses of `int' instead of EMACS_INT.
5616 * search.c (string_match_1, fast_string_match)
5617 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5618 (scan_buffer, find_next_newline_no_quit)
5619 (find_before_next_newline, search_command, Freplace_match)
5620 (Fmatch_data): Make some `int' variables be EMACS_INT.
5621
5622 * xdisp.c (display_count_lines): 3rd argument and return value now
5623 EMACS_INT. All callers changed.
5624 (pint2hrstr): Last argument is now EMACS_INT.
5625
5626 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
5627 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5628 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
5629 (decode_coding_utf_16, decode_coding_emacs_mule)
5630 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
5631 (decode_coding_ccl, decode_coding_charset)
5632 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
5633 (decode_coding_iso_2022, decode_coding_emacs_mule)
5634 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
5635 <char_offset, last_offset>: Declare EMACS_INT.
5636 (encode_coding_utf_8, encode_coding_utf_16)
5637 (encode_coding_emacs_mule, encode_invocation_designation)
5638 (encode_designation_at_bol, encode_coding_iso_2022)
5639 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
5640 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
5641 Declare EMACS_INT.
5642 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
5643 (encode_invocation_designation): Last argument P_NCHARS is now
5644 EMACS_INT.
5645 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
5646 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
5647
5648 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
5649 All users changed.
5650
5651 * ccl.c (Fccl_execute_on_string): Declare some variables
5652 EMACS_INT.
5653
8546720e 56542011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
5655
5656 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
5657
4e19a977
CS
56582011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
5659
5660 * process.c (Fformat_network_address): Doc fix.
5661
87302331
R
56622011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
5663
5664 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
5665
cbb59342
CY
56662011-04-08 Chong Yidong <cyd@stupidchicken.com>
5667
5668 * keyboard.c (read_char): Call Lisp function help-form-show,
5669 instead of using internal_with_output_to_temp_buffer.
5670 (Qhelp_form_show): New var.
e0d38eeb 5671 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
5672
5673 * print.c (internal_with_output_to_temp_buffer): Function deleted.
5674
5675 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
5676
e67a13ab
CY
56772011-04-06 Chong Yidong <cyd@stupidchicken.com>
5678
04f2d78b
CB
5679 * process.c (Flist_processes): Remove to Lisp.
5680 (list_processes_1): Delete.
e67a13ab 5681
973f782d
EZ
56822011-04-06 Eli Zaretskii <eliz@gnu.org>
5683
7c106b1e
EZ
5684 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
5685
973f782d
EZ
5686 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
5687
41cf7d1a 56882011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 5689
ca23cc88
PE
5690 Fix more problems found by GCC 4.6.0's static checks.
5691
f390e2d5
PE
5692 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
5693
42eea0d0
PE
5694 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
5695
b69769da 5696 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 5697
f9541e84
PE
5698 * xdisp.c (vmessage): Mark as a printf-like function.
5699
13841b55
PE
5700 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
5701
c136c10f
PE
5702 * sound.c (sound_warning): Don't crash if arg contains a printf format.
5703
5e2d4a30
PE
5704 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
5705 printf-like functions.
5706 (tiff_load): Add casts to remove these marks before passing them
5707 to system-supplied API.
5708
583f48b9
PE
5709 * eval.c (Fsignal): Remove excess argument to 'fatal'.
5710
b25d760e
PE
5711 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
5712 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
5713 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
5714 directly, rather than having caller test rule sign. This avoids
5715 some unnecessary tests.
5716 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
5717 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
5718 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 5719
bc7b6697 5720 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 5721 (xfont_open): Avoid unnecessary tests.
bc7b6697 5722
27ccc379
PE
5723 * composite.c (composition_gstring_put_cache): Use unsigned integer.
5724
dcd5c89a
PE
5725 * composite.h, composite.c (composition_gstring_put_cache):
5726 Use EMACS_INT, not int, for length.
5727
b13a45c6
PE
5728 * composite.h (COMPOSITION_DECODE_REFS): New macro,
5729 breaking out part of COMPOSITION_DECODE_RULE.
5730 (COMPOSITION_DECODE_RULE): Use it.
5731 * composite.c (get_composition_id): Remove unused local vars,
5732 by using the new macro.
5733
1e792e4d
PE
5734 * textprop.c (set_text_properties_1): Change while to do-while,
5735 since the condition is always true at first.
5736
dc6c6455 5737 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
5738 (interval_deletion_adjustment): Return unsigned value.
5739 All uses changed.
dc6c6455 5740
aba7731a
PE
5741 * process.c (list_processes_1, create_pty, read_process_output):
5742 (exec_sentinel): Remove vars that were set but not used.
afd4052b 5743 (create_pty): Remove unnecessary "volatile"s.
bc57d757 5744 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 5745 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 5746 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 5747
fdfc4bf3
PE
5748 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
5749
fca8fe46 5750 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 5751 (update_syntax_table): Use unsigned instead of int.
fca8fe46 5752
06a0259a 5753 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 5754 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 5755 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 5756
e7b9e80f
PE
5757 * print.c (print_error_message): Avoid int overflow.
5758
56201685
PE
5759 * font.c (font_list_entities): Redo for clarity,
5760 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
5761
78834453 5762 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 5763 (font_score): Avoid potential overflow in diff calculation.
78834453 5764
0bc0b309 5765 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 5766 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 5767
e610eaca
PE
5768 * eval.c (funcall_lambda): Rename local to avoid shadowing.
5769
b895abce
PE
5770 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
5771 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
5772 can always succeed if overflow has undefined behavior.
5773
1f1d9321 5774 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 5775 (wordify): Omit three unnecessary tests.
1f1d9321 5776
c59478bc
PE
5777 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
5778 All callers changed. This avoids the need for an unused var.
5779
79b73827
PE
5780 * casefiddle.c (casify_region): Remove var that is set but not used.
5781
a4db5dfe
PE
5782 * dired.c (file_name_completion): Remove var that is set but not used.
5783
43aae36e
PE
5784 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
5785
2a47c44d 5786 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 5787 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 5788
a37c69bf
PE
5789 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
5790 Check for integer overflow on size calculations.
5791
328ab8e7
PE
5792 * buffer.c (Fprevious_overlay_change): Remove var that is set
5793 but not used.
5794
e5a2a5cb
PE
5795 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
5796 Remove vars that are set but not used.
8d84a6eb 5797 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 5798 (timer_check_2): Mark vars as initialized.
e5a2a5cb 5799
a60e5f68
PE
5800 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
5801
f661cb61 5802 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 5803 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 5804
f0397f5a
PE
5805 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
5806 that are set but not used.
5807
8664db06 5808 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 5809 if XCreateBitmapFromData fails (Bug#8410).
8664db06 5810
6abdaa4a
PE
5811 * xselect.c (x_get_local_selection, x_handle_property_notify):
5812 Remove vars that are set but not used.
5813
0ce7538d 5814 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 5815 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 5816
9ae848fc
PE
5817 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5818 Remove var that is set but not used.
0b918413
PE
5819 (scroll_bar_windows_size): Now size_t, not int.
5820 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5821 Check for overflow.
9ae848fc 5822
a5a62657
PE
5823 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5824 (map_tty_color) [!defined MSDOS]: Likewise.
5825
5c5cdd39
PE
5826 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5827
66ebf983
PE
5828 * coding.c: Remove vars that are set but not used.
5829 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5830 All callers changed.
5831 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5832 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5833 (decode_coding_charset): Remove vars that are set but not used.
5834
1be4d761
PE
5835 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5836 that is set but not used.
5837
47553fa8
PE
5838 * print.c (print_object): Remove var that is set but not used.
5839
1f7196bf 5840 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
5841 The gnulib version avoids calling malloc in the usual case,
5842 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5843 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5844 * filelock.c (current_lock_owner): Likewise.
5845 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5846 * sysdep.c: Include allocator.h, careadlinkat.h.
5847 (emacs_no_realloc_allocator): New static constant.
5848 (emacs_readlink): New function.
fdb61804
PE
5849 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5850 ../lib/careadlinkat.h.
d1fdcab7 5851
f84c17c7
SM
58522011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5853
5854 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5855 first non-nil return value).
5856
ef3862ad
JD
58572011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5858
5859 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5860 if not defined (Bug#8403).
5861
376a7006
JB
58622011-04-02 Juanma Barranquero <lekktu@gmail.com>
5863
5864 * xdisp.c (display_count_lines): Remove parameter `start',
5865 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5866 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5867 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5868 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5869 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5870 and thereabouts. All callers changed.
5871 (get_per_char_metric): Remove parameter `f', unused since
5872 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5873
6ca3801d
JM
58742011-04-02 Jim Meyering <meyering@redhat.com>
5875
5876 do not dereference NULL upon failed strdup
5877 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5878 (ns_get_family): Likewise.
5879
d8e2b5ba
JB
58802011-04-02 Juanma Barranquero <lekktu@gmail.com>
5881
5882 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5883
8c74fcbd
JD
58842011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5885
5886 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5887 later (Bug#8403).
5888
7200d79c
SM
58892011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5890
03408648 5891 Add lexical binding.
7200d79c 5892
03408648
SM
5893 * window.c (Ftemp_output_buffer_show): New fun.
5894 (Fsave_window_excursion):
5895 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5896
5897 * lread.c (lisp_file_lexically_bound_p): New function.
5898 (Fload): Bind Qlexical_binding.
5899 (readevalloop): Remove `evalfun' arg.
5900 Bind Qinternal_interpreter_environment.
5901 (Feval_buffer): Bind Qlexical_binding.
5902 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5903 Mark as dynamic.
5904 (syms_of_lread): Declare `lexical-binding'.
5905
5906 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5907
5908 * keyboard.c (eval_dyn): New fun.
5909 (menu_item_eval_property): Use it.
ca105506
SM
5910
5911 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 5912
03408648
SM
5913 * fns.c (concat, mapcar1): Accept byte-code-functions.
5914
5915 * eval.c (Fsetq): Handle lexical vars.
5916 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5917 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5918 (FletX, Flet): Obey lexical binding.
5919 (Fcommandp): Handle closures.
5920 (Feval): New `lexical' arg.
5921 (eval_sub): New function extracted from Feval. Use it almost
5922 everywhere where Feval was used. Look up vars in lexical env.
5923 Handle closures.
5924 (Ffunctionp): Move from subr.el.
5925 (Ffuncall): Handle closures.
5926 (apply_lambda): Remove `eval_flags'.
5927 (funcall_lambda): Handle closures and new byte-code-functions.
5928 (Fspecial_variable_p): New function.
5929 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5930 but without exporting it to Lisp.
23aba0ea 5931
23aba0ea 5932 * doc.c (Fdocumentation, store_function_docstring):
03408648 5933 * data.c (Finteractive_form): Handle closures.
23aba0ea 5934
03408648
SM
5935 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5936 interactive spec.
ba83908c 5937
04f2d78b
CB
5938 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5939 New byte-codes.
03408648
SM
5940 (exec_byte_code): New function extracted from Fbyte_code to handle new
5941 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 5942
03408648 5943 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 5944
03408648 5945 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 5946
e2abce01
JB
59472011-03-31 Juanma Barranquero <lekktu@gmail.com>
5948
5949 * xdisp.c (redisplay_internal): Fix prototype.
5950
63696a73 59512011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 5952
63696a73 5953 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
5954 (try_scrolling): Use it when setting scroll_limit.
5955 Limit scrolling to 100 screen lines.
63696a73
EZ
5956 (redisplay_window): Even when falling back on "recentering",
5957 position point in the window according to scroll-conservatively,
5958 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5959
5960 (try_scrolling): When point is above the window, allow searching
5961 as far as scroll_max, or one screenful, to compute vertical
5962 distance from PT to the scroll margin position. This prevents
5963 try_scrolling from unnecessarily failing when
5964 scroll-conservatively is set to a value slightly larger than the
5965 window height. Clean up the case of PT below the margin at bottom
5966 of window: scroll_max can no longer be INT_MAX. When aggressive
5967 scrolling is in use, don't let point enter the opposite scroll
5968 margin as result of the scroll.
5969 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
5970 threshold of 100 lines for never-recentering scrolling.
5971
e4cc2dfc
JB
59722011-03-31 Juanma Barranquero <lekktu@gmail.com>
5973
5974 * dispextern.h (move_it_by_lines):
5975 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5976 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5977 (message_log_check_duplicate): Remove parameters `prev_bol' and
5978 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5979 (redisplay_internal): Remove parameter `preserve_echo_area',
5980 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5981
5982 * indent.c (Fvertical_motion):
5983 * window.c (window_scroll_pixel_based, Frecenter):
5984 Don't pass `need_y_p' to `move_it_by_lines'.
5985
1c470562
SM
59862011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5987
44f230aa
SM
5988 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5989 steal a few bits to be more compact.
5990 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5991 Remove unneeded casts.
5992
1c470562
SM
5993 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5994
888adce9
ZK
59952011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5996
5997 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5998 binding" message (bug#7967).
5999
f838ed7b
PE
60002011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6001
77861b95
PE
6002 Fix more problems found by GCC 4.6.0's static checks.
6003
de6dbc14
PE
6004 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6005 Remove unused local var.
6006
f838ed7b
PE
6007 * editfns.c (Fmessage_box): Remove unused local var.
6008
792c7b2b
PE
6009 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6010 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6011 Omit unused local vars.
c499e557 6012 * window.c (shrink_windows): Omit unused local var.
b01a1c29 6013 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
6014 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6015 Omit unused local var.
6016
ba0165e1
PE
6017 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6018 Don't assume string length fits in int.
32ad8845 6019 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 6020 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 6021
3c59b4c9
PE
6022 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6023 instead of alloca (Bug#8344).
6024
a3eed478 6025 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 6026 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 6027
eb4d412d
PE
6028 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6029
1658b401
PE
6030 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6031 concerns.
6032
6033 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6034
6035 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 6036
9a2c6e05
PE
6037 * keyboard.c (syms_of_keyboard): Use the same style as later
6038 in this function when indexing through an array. This also
6039 works around GCC bug 48267.
6040
03d0a109
PE
6041 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6042
44f730c8
PE
6043 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6044
fe75f926
PE
6045 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6046 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6047
ffa8c828
PE
6048 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6049 This avoids undefined behavior on integer overflow, and is a bit
6050 more convenient anyway since it is compared to a size_t variable.
6051
c5101a77
PE
6052 Variadic C functions now count arguments with size_t, not int.
6053 This avoids an unnecessary limitation on 64-bit machines, which
6054 caused (substring ...) to crash on large vectors (Bug#8344).
6055 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6056 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 6057 All variadic functions and their callers changed accordingly.
c5101a77
PE
6058 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6059 * data.c (arith_driver, float_arith_driver): Likewise.
6060 * editfns.c (general_insert_function): Likewise.
6061 * eval.c (struct backtrace.nargs, interactive_p)
6062 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6063 (funcall_lambda, mark_backtrace): Likewise.
6064 * fns.c (concat): Likewise.
6065 * frame.c (x_set_frame_parameters): Likewise.
6066 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6067 0 if not found, not -1. All callers changed.
6068
dd3f25f7
PE
6069 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6070 (stack_copy_size): Now size_t, not int.
6071 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6072
461c2ab9
JB
60732011-03-28 Juanma Barranquero <lekktu@gmail.com>
6074
6075 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6076 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6077 All callers changed.
6078
6079 * lisp.h (multibyte_char_to_unibyte):
6080 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6081 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6082 * character.h (CHAR_TO_BYTE8):
6083 * cmds.c (internal_self_insert):
6084 * editfns.c (general_insert_function):
6085 * keymap.c (push_key_description):
6086 * search.c (Freplace_match):
6087 * xdisp.c (message_dolog, set_message_1): All callers changed.
6088
f6d62986
SM
60892011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6090
6091 * keyboard.c (safe_run_hook_funcall): New function.
6092 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6093 don't set the hook to nil, but remove the offending function instead.
6094 (Qcommand_hook_internal): Remove, unused.
6095 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6096 Vcommand_hook_internal.
6097
6098 * eval.c (enum run_hooks_condition): Remove.
6099 (funcall_nil, funcall_not): New functions.
6100 (run_hook_with_args): Call each function through a `funcall' argument.
6101 Remove `cond' argument, now redundant.
6102 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6103 (Frun_hook_with_args_until_failure): Adjust accordingly.
6104 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6105
1db5b1ad
JB
61062011-03-28 Juanma Barranquero <lekktu@gmail.com>
6107
6108 * dispextern.h (string_buffer_position): Remove declaration.
6109
6110 * print.c (strout): Remove parameter `multibyte', unused since
6111 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6112
6113 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6114 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6115 All callers changed.
6116
6117 * w32.c (_wsa_errlist): Use braces for struct initializers.
6118
6119 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6120 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6121 All callers changed.
6122 (string_buffer_position): Likewise. Also, make static (it's never
6123 used outside xdisp.c).
6124 (cursor_row_p): Remove parameter `w', unused since
6125 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6126 (decode_mode_spec): Remove parameter `precision', introduced during
6127 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6128 All callers changed.
6129
5ffb62aa
JD
61302011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6131
6132 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6133
461c2ab9 61342011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
6135
6136 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6137 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6138 (ns_update_auto_hide_menu_bar): New functions.
6139 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6140 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6141 ns_constrain_all_frames.
6142 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6143 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6144
5c380ffb
JD
61452011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6146
6147 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6148
9af30bdf
GM
61492011-03-27 Glenn Morris <rgm@gnu.org>
6150
6151 * syssignal.h: Replace RETSIGTYPE with void.
6152 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6153 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6154 Replace SIGTYPE with void everywhere.
6155 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6156 * s/template.h (SIGTYPE): Remove commented out definition.
6157
e2abce01
JB
61582011-03-26 Eli Zaretskii <eliz@gnu.org>
6159
6160 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6161 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6162
f868cd8a
JB
61632011-03-26 Juanma Barranquero <lekktu@gmail.com>
6164
59eb0929
JB
6165 * w32.c (read_unc_volume): Use parameter `henum', instead of
6166 global variable `wget_enum_handle'.
6167
6168 * keymap.c (describe_vector): Remove parameters `indices' and
6169 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6170 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6171
f868cd8a
JB
6172 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6173
6174 * keyboard.c (timer_check): Remove parameter `do_it_now',
6175 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6176 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6177 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6178
6179 * keyboard.c (read_char):
6180 * w32menu.c (w32_menu_display_help):
6181 * xmenu.c (show_help_event, menu_help_callback):
6182 Adjust calls to `show_help_echo'.
6183
6184 * gtkutil.c (xg_maybe_add_timer):
6185 * keyboard.c (readable_events):
6186 * process.c (wait_reading_process_output):
6187 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6188
6189 * insdel.c (adjust_markers_gap_motion):
6190 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6191 (gap_left, gap_right): Don't call it.
6192
2ecf6fdb
CY
61932011-03-25 Chong Yidong <cyd@stupidchicken.com>
6194
6195 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6196 incurred during fontification.
6197
6b1f9ba4
JB
61982011-03-25 Juanma Barranquero <lekktu@gmail.com>
6199
6200 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6201 (DEFVAR_PER_BUFFER): Don't pass it.
6202
6203 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6204 (scrolling_window): Don't pass it.
6205
0f4a96b5
JB
62062011-03-25 Juanma Barranquero <lekktu@gmail.com>
6207
6208 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6209
6210 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6211 and `suffix'.
6212 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6213 of variables specific to SELinux and computation of `encoded_absname'.
6214
6215 * image.c (XPutPixel): Remove unused variable `height'.
6216
6217 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6218
6219 * unexw32.c (get_section_info): Remove unused variable `section'.
6220
6221 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6222 (system_process_attributes): Remove unused variable `sess'.
6223 (sys_read): Remove unused variable `err'.
6224
6225 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6226 (w32_wnd_proc): Remove unused variable `isdead'.
6227 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6228 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6229 (x_create_tip_frame): Remove unused variable `tem'.
6230
6231 * w32inevt.c (w32_console_read_socket):
6232 Remove unused variable `no_events'.
6233
6234 * w32term.c (x_draw_composite_glyph_string_foreground):
6235 Remove unused variable `width'.
6236
1149507c
JB
62372011-03-24 Juanma Barranquero <lekktu@gmail.com>
6238
6239 * w32term.c (x_set_glyph_string_clipping):
6240 Don't pass uninitialized region to CombineRgn.
6241
9c88f339
JB
62422011-03-23 Juanma Barranquero <lekktu@gmail.com>
6243
6244 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6245 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6246 (Fx_close_connection): Remove unused variable `i'.
6247
6248 * w32font.c (w32font_draw): Return number of glyphs.
6249 (w32font_open_internal): Remove unused variable `i'.
6250 (w32font_driver): Add missing initializer.
6251
6252 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6253 (fill_in_menu): Remove unused variable `items_added'.
6254
6255 * w32term.c (last_mouse_press_frame): Remove static global variable.
6256 (w32_clip_to_row): Remove unused variable `f'.
6257 (x_delete_terminal): Remove unused variable `i'.
6258
6259 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6260 (NOTHING): Remove unused static global variable.
6261 (uniscribe_check_otf): Remove unused variable `table'.
6262 (uniscribe_font_driver): Add missing initializers.
6263
dee091a3
JD
62642011-03-23 Julien Danjou <julien@danjou.info>
6265
6266 * term.c (Fsuspend_tty, Fresume_tty):
6267 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6268 * window.c (temp_output_buffer_show):
6269 * insdel.c (signal_before_change):
6270 * frame.c (Fhandle_switch_frame):
6271 * fileio.c (Fdo_auto_save):
6272 * emacs.c (Fkill_emacs):
6273 * editfns.c (save_excursion_restore):
6274 * cmds.c (internal_self_insert):
6275 * callint.c (Fcall_interactively):
6276 * buffer.c (Fkill_all_local_variables):
6277 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6278 Use Frun_hooks.
0f4a96b5 6279 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
6280 unconditionnaly since it does the check itself.
6281
2c520ab5 62822011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 6283
c9c49752
PE
6284 Fix more problems found by GCC 4.5.2's static checks.
6285
8abc3f12
PE
6286 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6287 the first time through the loop, since we know p0 < p1 then.
6288 This also avoids a gcc -Wstrict-overflow warning.
6289
a2d26660
PE
6290 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6291 leading to a memory leak, possible in functions like
6292 load_charset_map_from_file that can allocate an unbounded number
b12ef411 6293 of objects (Bug#8318).
a2d26660 6294
916c72e9
PE
6295 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6296 that could (at least in theory) be that large.
6297
19ab8a18
PE
6298 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6299 This is less likely to overflow, and avoids undefined behavior if
6300 overflow does occur. All callers changed. Use strtoul to scan
6301 for the unsigned long integer.
b7cbbd6f
PE
6302 (pint2hrstr): Simplify and tune code slightly.
6303 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 6304
f0641eff
PE
6305 * scroll.c (do_scrolling): Work around GCC bug 48228.
6306 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6307
7f650bb9
PE
6308 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6309 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
6310 (validate_x_resource_name): Simplify count usage.
6311 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 6312
37dd57d1
PE
6313 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6314 fail (Bug#8306).
81e56e61 6315
699979fc 6316 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 6317
401bf9b4
PE
6318 * process.c (Fmake_network_process): Use socklen_t, not int,
6319 where POSIX says socklen_t is required in portable programs.
6320 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 6321 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
6322 (Fmake_network_process, server_accept_connection):
6323 (wait_reading_process_output, read_process_output):
6324 Likewise.
6325
b93aacde
PE
6326 * process.c: Rename or move locals to avoid shadowing.
6327 (list_processes_1, Fmake_network_process):
6328 (read_process_output_error_handler, exec_sentinel_error_handler):
6329 Rename or move locals.
4dc343ee 6330 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 6331 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 6332 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 6333 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 6334 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 6335
af8a867c 6336 Make tparam.h and terminfo.c consistent.
44f230aa
SM
6337 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6338 Include tparam.h instead, since it declares them.
af8a867c
PE
6339 * cm.h (PC): Remove extern decl; tparam.h now does this.
6340 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6341 * terminfo.c: Include tparam.h, to check interfaces.
6342 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6343 (tparam): Adjust signature to match interface in tparam.h;
6344 this removes some undefined behavior. Check that outstring and len
6345 are zero, which they always are with Emacs.
6346 * tparam.h (PC, BC, UP): New extern decls.
6347
0248044d 6348 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 6349 (xftfont_open): Rename locals to avoid shadowing.
0248044d 6350
8ff096c1 6351 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
6352 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6353 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 6354 (ftfont_list): Remove unused local.
49eaafba
PE
6355 (get_adstyle_property, ftfont_pattern_entity):
6356 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6357 Rename locals to avoid shadowing.
8ff096c1 6358
e2be39f6
PE
6359 * xfont.c (xfont_list_family): Mark var as initialized.
6360
c9735e30
PE
6361 * xml.c (make_dom): Now static.
6362
8f5201ae
PE
6363 * composite.c (composition_compute_stop_pos): Rename local to
6364 avoid shadowing.
b246f932
PE
6365 (composition_reseat_it): Remove unused locals.
6366 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 6367 (composition_update_it): Mark var as initialized.
11b61122
PE
6368 (find_automatic_composition): Mark vars as initialized,
6369 with a FIXME (Bug#8290).
8f5201ae 6370
760fbc2c
PE
6371 character.h: Rename locals to avoid shadowing.
6372 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6373 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6374 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6375 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6376 to avoid shadowing.
6377
ff08eb85
PE
6378 * textprop.c (property_change_between_p): Remove; unused.
6379
fc7bf025
PE
6380 * intervals.c (interval_start_pos): Now static.
6381
235d7abc
PE
6382 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6383
44f230aa
SM
6384 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6385 Rename locals to avoid shadowing.
3e7d6594 6386
50060332
PE
6387 * sound.c (wav_play, au_play, Fplay_sound_internal):
6388 Fix pointer signedness.
d01f234b 6389 (alsa_choose_format): Remove unused local var.
c83b8872
PE
6390 (wav_play): Initialize a variable to 0, to prevent undefined
6391 behavior (Bug#8278).
50060332 6392
c4fc4e30
PE
6393 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6394
918436ed
PE
6395 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6396
c939f91b
PE
6397 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6398 clobbering (Bug#8298).
b9c7f648
PE
6399 * sysdep.c (sys_subshell): Likewise.
6400 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 6401
6bd8c144
PE
6402 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6403 This should get cleaned up, so that child_setup has the
6404 same signature on all platforms.
6405
7710357c 6406 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 6407 (relocate_fd): Rename locals to avoid shadowing.
7710357c 6408
c59da222
CY
64092011-03-22 Chong Yidong <cyd@stupidchicken.com>
6410
6411 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
6412 not to be necessary, and produces flickering.
6413
66b87493
GM
64142011-03-20 Glenn Morris <rgm@gnu.org>
6415
6416 * config.in: Remove file.
6417
45b6f6d5
JB
64182011-03-20 Juanma Barranquero <lekktu@gmail.com>
6419
6420 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
6421 are now in src/globals.h.
6422 (syms_of_minibuf): Remove spurious & from previous change.
6423
3ec03f7e
LL
64242011-03-20 Leo <sdl.web@gmail.com>
6425
6426 * minibuf.c (completing-read-function): New variable.
6427 (completing-read-default): Rename from completing-read.
6428 (completing-read): Call completing-read-function.
6429
b14e3e21
CY
64302011-03-19 Juanma Barranquero <lekktu@gmail.com>
6431
6432 * xfaces.c (Fx_load_color_file):
6433 Read color file from absolute filename (bug#8250).
6434
f2b726e6
JB
64352011-03-19 Juanma Barranquero <lekktu@gmail.com>
6436
6437 * makefile.w32-in: Update dependencies.
6438
09f6ff02
EZ
64392011-03-17 Eli Zaretskii <eliz@gnu.org>
6440
6441 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
6442
29a6015a
PE
64432011-03-17 Paul Eggert <eggert@cs.ucla.edu>
6444
a3a6c54e
PE
6445 Fix more problems found by GCC 4.5.2's static checks.
6446
b766f867
PE
6447 * process.c (make_serial_process_unwind, send_process_trap):
6448 (sigchld_handler): Now static.
6449
be02381c
PE
6450 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
6451 That way, the code declares only the vars that it needs.
6452 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
6453 * s/cygwin.h (PTY_ITERATION): Likewise.
6454 * s/darwin.h (PTY_ITERATION): Likewise.
6455 * s/gnu-linux.h (PTY_ITERATION): Likewise.
6456
57048744
PE
6457 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
6458 * process.c (allocate_pty): Don't declare stb unless it's needed.
6459
7914961c 6460 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
6461 (CONSTANTLIM): Remove; unused.
6462 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
6463 Define only if needed.
7914961c 6464
b3967b18
PE
6465 * unexelf.c (unexec): Name an expression,
6466 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
6467 Use a different way to cause a compilation error if anyone uses
6468 n rather than nn, a way that does not involve shadowing.
73366a00 6469 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 6470
29a6015a
PE
6471 * deps.mk (unexalpha.o): Remove; unused.
6472
43cfc33e 6473 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 6474 * unexec.h: New file.
ce701a33
PE
6475 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
6476 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
6477 Depend on unexec.h.
6478 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
6479 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
6480 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 6481 Change as necessary to match prototype in unexec.h.
ce701a33 6482
01f44d5a
PE
6483 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
6484 shadowing.
4f63c6bb 6485 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 6486
a6670b0b
PE
6487 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
6488 Rename locals to avoid shadowing.
6489
cef2010d 6490 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 6491 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 6492
d4d7173a
PE
6493 * print.c (Fredirect_debugging_output): Fix pointer signedess.
6494
f08b802a
PE
6495 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
6496 warning when compiling print.c.
6497
3ddb0639
PE
6498 * font.c (font_unparse_fcname): Abort in an "impossible" situation
6499 instead of using an uninitialized var.
5ad03b97 6500 (font_sort_entities): Mark var as initialized.
3ddb0639 6501
170a2692
PE
6502 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
6503
e663c700
PE
6504 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
6505 pointers to constants.
89bc529a 6506 (font_parse_fcname): Remove unused vars.
7b81e2d0 6507 (font_delete_unmatched): Now static.
ea838e10 6508 (font_get_spec): Remove; unused.
13a547c6
PE
6509 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
6510 (font_update_drivers, Ffont_get_glyphs, font_add_log):
6511 Rename or move locals to avoid shadowing.
e663c700 6512
2a80c887 6513 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 6514 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 6515
1384fa33 6516 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 6517 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 6518
8b2c52e9
PE
6519 * alloc.c (mark_backtrace): Move decl from here ...
6520 * lisp.h: ... to here, so that it can be checked.
6521
475545b5 6522 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 6523 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
6524 (lisp_indirect_variable): Name an expression,
6525 to avoid gcc -Wbad-function-cast warning.
1faed8ae 6526 (Fdefvar): Rename locals to avoid shadowing.
475545b5 6527
b1349114 6528 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 6529 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 6530 Use const pointer when appropriate.
b1349114 6531
a2928364
PE
6532 * lisp.h (get_system_name, get_operating_system_release):
6533 Move decls here, to check interfaces.
6534 * process.c (get_operating_system_release): Move decl to lisp.h.
6535 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
6536 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
6537 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
6538 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
6539 (Fformat_time_string, Fencode_time, Finsert_char):
6540 (Ftranslate_region_internal, Fformat):
6541 Rename or remove local vars to avoid shadowing.
9710023e 6542 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 6543
a415e694
PE
6544 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
6545 avoid shadowing.
6546
8ef4622d
PE
6547 * lisp.h (eassert): Check that the argument compiles, even if
6548 ENABLE_CHECKING is not defined.
6549
946f9a5b
PE
6550 * data.c (Findirect_variable): Name an expression, to avoid
6551 gcc -Wbad-function-cast warning.
112396d6 6552 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 6553 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
6554 (Fmake_variable_buffer_local, Fmake_local_variable):
6555 Mark variables as initialized.
52746918 6556 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 6557
e5aab7e7 6558 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
6559 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
6560 Rename locals to avoid shadowing.
dff45157
PE
6561 (mark_stack): Move local variables into the #ifdef region where
6562 they're used.
7bc26fdb
PE
6563 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6564 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6565 needed otherwise.
6566 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6567 (GC_STRING_CHARS): Remove; not used.
d40d4be1 6568 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 6569
e5aab7e7
PE
6570 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6571 avoids undefined behavior in theory.
6572
4da60324
PE
6573 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6574
88043301
PE
6575 Use functions, not macros, for up- and down-casing (Bug#8254).
6576 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6577 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6578 to use the following functions instead of these macros.
6579 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6580 EMACS_INT, since callers assume the returned value fits in int.
6581 (upcase1): Likewise, for UPCASE_TABLE.
6582 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 6583 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 6584 the race-condition problem in the old DOWNCASE.
88043301 6585
19ed5445
PE
6586 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6587 Rename locals to avoid shadowing.
6588 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
6589 (regex_compile, re_search_2, re_match_2_internal):
6590 Remove unused local vars.
952db0d7
PE
6591 (FREE_VAR): Rewrite so as not to use empty "else",
6592 which gcc can warn about.
da053e48 6593 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
6594 (RETALLOC_IF): Define only if needed.
6595 (WORDCHAR_P): Likewise. This one is never needed, but is used
6596 only in a comment talking about a compiler bug, so put inside
6597 the #if 0 of that comment.
6598 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6599 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6600 Remove; unused.
19ed5445 6601
1f3561e4 6602 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
6603 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6604 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 6605
ded6f8f7
PE
6606 * search.c (simple_search): Remove unused var.
6607
dbd37a95
PE
6608 * dired.c (compile_pattern): Move decl from here ...
6609 * lisp.h: ... to here, so that it can be checked.
6610 (struct re_registers): New forward decl.
6611
7e47afad
PE
6612 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6613
85f24f61
PE
6614 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6615 All uses changed.
6616 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6617 Rename locals to avoid shadowing.
5671df8f 6618 (Fvertical_motion): Mark locals as initialized.
85f24f61 6619
181aa2be 6620 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 6621 (casify_region): Mark local as initialized.
181aa2be 6622
930d429c
PE
6623 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
6624
7082eac6
PE
6625 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
6626 New macros, so that the caller can use some names other than
6627 gcpro1, gcpro2, etc.
6628 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
6629 of the new macros.
6630 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
6631 argument, for consistency with GCPRO2_VAR, etc: it is now the
6632 prefix of the variable, not the variable itself. All uses
6633 changed.
38b2c076
PE
6634 * dired.c (directory_files_internal, file_name_completion):
6635 Rename locals to avoid shadowing.
6636
15206ed9
PE
6637 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
6638 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
6639 dired.c's scmp function, had undefined behavior.
6640 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6641 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
6642 * buffer.h: ... to here, because these macros use current_buffer,
6643 and the new implementation with inline functions needs to have
6644 current_buffer in scope now, rather than later when the macros
6645 are used.
6646 (downcase, upcase1): New static inline functions.
6647 (DOWNCASE, UPCASE1): Reimplement using these functions.
6648 This avoids undefined behavior in expressions like
6649 DOWNCASE (x) == DOWNCASE (y), which previously suffered
6650 from race conditions in accessing the global variables
6651 case_temp1 and case_temp2.
6652 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
6653 * lisp.h (case_temp1, case_temp2): Remove their decls.
6654 * character.h (ASCII_CHAR_P): Move from here ...
6655 * lisp.h: ... to here, so that the inline functions mentioned
6656 above can use them.
6657
4a6bea26
PE
6658 * dired.c (directory_files_internal_unwind): Now static.
6659
f14b7e14
PE
6660 * fileio.c (file_name_as_directory, directory_file_name):
6661 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
6662 Now static.
2893f146
PE
6663 (file_name_as_directory): Use const pointers when appropriate.
6664 (Fexpand_file_name): Likewise. In particular, newdir might
6665 point at constant storage, so make it a const pointer.
fd4ead52 6666 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
6667 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
6668 signedness issues.
f839df0c
PE
6669 (Fset_file_times, Finsert_file_contents, auto_save_error):
6670 Rename locals to avoid shadowing.
f14b7e14 6671
5716756e 6672 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
6673 (Ftry_completion, Fall_completions): Rename or remove locals
6674 to avoid shadowing.
5716756e 6675
b4c3046a
PE
6676 * marker.c (bytepos_to_charpos): Remove; unused.
6677
b45db522
PE
6678 * lisp.h (verify_bytepos, count_markers): New decls,
6679 so that gcc does not warn that these functions aren't declared.
6680
85876d07
PE
6681 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
6682 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 6683 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 6684 (copy_text): Remove unused local var.
85876d07 6685
03d78a21 6686 * filelock.c (within_one_second): Now static.
b3dd38ab 6687 (lock_file_1): Rename local to avoid shadowing.
03d78a21 6688
5df8f01b
PE
6689 * buffer.c (fix_overlays_before): Mark locals as initialized.
6690 (fix_start_end_in_overlays): Likewise. This function should be
6691 simplified by using pointers-to-pointers, but that's a different
6692 matter.
b1d876f1 6693 (switch_to_buffer_1): Now static.
8f54f30a
PE
6694 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
6695 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 6696
a70072c9 6697 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 6698 Fix pointer signedness issue.
edced198
PE
6699 (sys_subshell): Mark local as volatile if checking for lint,
6700 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 6701 (MAXPATHLEN): Define only if needed.
a70072c9 6702
a0977c44
PE
6703 * process.c (serial_open, serial_configure): Move decls from here ...
6704 * systty.h: ... to here, so that they can be checked.
6705
a884fdcc
PE
6706 * fns.c (get_random, seed_random): Move extern decls from here ...
6707 * lisp.h: ... to here, so that they can be checked.
6708
604efe86 6709 * sysdep.c (reset_io): Now static.
b8950c94 6710 (wait_for_termination_signal): Remove; unused.
604efe86 6711
38fc62d9
PE
6712 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
6713 (copy_keymap_item, append_key, push_text_char_description):
6714 Now static.
1004a21a 6715 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 6716 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
6717 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
6718 (describe_map_tree):
6719 Rename locals to avoid shadowing.
38fc62d9 6720
2f2650da
PE
6721 * keyboard.c: Declare functions static if they are not used elsewhere.
6722 (echo_char, echo_dash, cmd_error, top_level_2):
6723 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
6724 (read_char, kbd_buffer_get_event, make_lispy_position):
6725 (make_lispy_event, make_lispy_movement, apply_modifiers):
6726 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
6727 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
6728 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 6729 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 6730 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 6731
a053e86c 6732 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
6733 (mark_kboards): Move decl here ...
6734 * alloc.c (mark_kboards): ... from here.
a053e86c 6735
4752793e
PE
6736 * lisp.h (force_auto_save_soon): New decl.
6737
74f10ca7 6738 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
6739 (DEFINE_DUMMY_FUNCTION): New macro.
6740 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
6741 Use it.
c03cd23f
PE
6742 (main): Add casts to avoid warnings
6743 if GCC considers string literals to be constants.
74f10ca7 6744
022e70d4
PE
6745 * lisp.h (fatal_error_signal): Add decl, since it's exported.
6746
59d6fe83
PE
6747 * dbusbind.c: Pointer signedness fixes.
6748 (xd_signature, xd_append_arg, xd_initialize):
6749 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6750 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6751 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
6752 (Fdbus_register_signal): Use SSDATA when the context wants char *.
6753
78320123
PE
6754 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
6755 if GCC considers string literals to be constants.
49cebcca 6756 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 6757
35ac2a97
SM
67582011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
6759
fb103ca9
SM
6760 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
6761 (print_preprocess, print_object): New macro to fix last change.
6762
35ac2a97
SM
6763 * print.c (print_preprocess): Don't forget font objects.
6764
62973b41
JB
67652011-03-16 Juanma Barranquero <lekktu@gmail.com>
6766
6767 * emacs.c (USAGE3): Doc fixes.
6768
0e48bb22
AS
67692011-03-15 Andreas Schwab <schwab@linux-m68k.org>
6770
6771 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
6772 structure.
6773
7684e57b
JB
67742011-03-14 Juanma Barranquero <lekktu@gmail.com>
6775
6776 * lisp.h (VWindow_system, Qfile_name_history):
6777 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
6778 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
6779 (w32_system_caret_x, w32_system_caret_y): Declare extern.
6780
6781 * w32select.c: Don't #include "keyboard.h".
c96bbc66 6782 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
6783
6784 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
6785 * w32console.c (detect_input_pending, read_input_pending)
6786 (encode_terminal_code):
6787 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
6788 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
6789 (w32_system_caret_y, Qfile_name_history):
6790 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
6791 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
6792 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
6793 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
6794 * w32proc.c (Qlocal, report_file_error):
6795 * w32term.c (Vwindow_system, updating_frame):
6796 * w32uniscribe.c (initialized, uniscribe_font_driver):
6797 Remove unneeded extern declarations.
6798
2aa46d6c
CY
67992011-03-14 Chong Yidong <cyd@stupidchicken.com>
6800
c96bbc66 6801 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 6802
cffc6f3b
CY
68032011-03-13 Chong Yidong <cyd@stupidchicken.com>
6804
6805 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
6806 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
6807 These macros can no longer be used for assignment.
6808
44f230aa
SM
6809 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6810 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
6811 (record_buffer_markers, fetch_buffer_markers): New functions for
6812 recording and fetching special buffer markers.
6813 (set_buffer_internal_1, set_buffer_temp): Use them.
6814
6815 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6816
6817 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6818
6819 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6820 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6821
6822 * xdisp.c (hscroll_window_tree):
6823 (reconsider_clip_changes): Use PT instead of BUF_PT.
6824
d251f04b
EZ
68252011-03-13 Eli Zaretskii <eliz@gnu.org>
6826
6827 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6828 $(EMACS_ROOT)/lib/intprops.h.
6829
f0c77cd1
PE
68302011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6831
3eca4629
PE
6832 Fix more problems found by GCC 4.5.2's static checks.
6833
7c86ee98
PE
6834 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6835 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
6836 (xg_free_frame_widgets): Make it clear that a local variable is
6837 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
6838 (gdk_window_get_screen): Make it clear that this macro is needed
6839 only if USE_GTK_TOOLTIP.
1e5524e7
PE
6840 (int_gtk_range_get_value): New function, which avoids a diagnostic
6841 from gcc -Wbad-function-cast.
6842 (xg_set_toolkit_scroll_bar_thumb): Use it.
6843 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6844 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
6845 (get_utf8_string, xg_get_file_with_chooser):
6846 Rename locals to avoid shadowing.
6847 (create_dialog): Move locals to avoid shadowing.
7c86ee98 6848
41729b81
PE
6849 * xgselect.c (xg_select): Remove unused var.
6850
f0c77cd1
PE
6851 * image.c (four_corners_best): Mark locals as initialized.
6852 (gif_load): Initialize transparent_p to zero (Bug#8238).
6853 Mark another local as initialized.
ec6cf4c6 6854 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 6855
ce0ad53d 6856 * image.c (clear_image_cache): Now static.
d5d5a617 6857 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 6858 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
6859 (x_edge_detection): Remove unnecessary cast that
6860 gcc -Wbad-function-cast diagnoses.
2037898d 6861 (gif_load): Fix pointer signedness.
6ae141d6
PE
6862 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6863 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 6864
33383987 68652011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 6866
d32df629
PE
6867 Improve quality of tests for time stamp overflow.
6868 For example, without this patch (encode-time 0 0 0 1 1
6869 1152921504606846976) returns the obviously-bogus value (-948597
6870 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6871 reports time overflow. See
6872 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
6873 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6874 * editfns.c: Include limits.h and intprops.h.
6875 (TIME_T_MIN, TIME_T_MAX): New macros.
6876 (time_overflow): Move earlier, to before first use.
6877 (hi_time, lo_time): New functions, for an accurate test for
6878 out-of-range times.
6879 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6880 (Fget_internal_run_time): Don't assume time_t fits in int.
6881 (make_time): Use list2 instead of Fcons twice.
6882 (Fdecode_time): More accurate test for out-of-range times.
6883 (check_tm_member): New function.
6884 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
6885 (lisp_time_argument): Don't rely on undefined left-shift and
6886 right-shift behavior when checking for time stamp overflow.
8be6f318 6887
fe31d94c
PE
6888 * editfns.c (time_overflow): New function, refactoring common code.
6889 (Fformat_time_string, Fdecode_time, Fencode_time):
6890 (Fcurrent_time_string): Use it.
6891
8be6f318
PE
6892 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6893 * dired.c (make_time): Move to ...
6894 * editfns.c (make_time): ... here.
6895 * systime.h: Note the move.
6896
09d9db2c 68972011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 6898
126bc0dc
YM
6899 * fringe.c (update_window_fringes): Remove unused variables.
6900
c47cbdfd
YM
6901 * unexmacosx.c (copy_data_segment): Also copy __got section.
6902 (Bug#8223)
6903
7ac80be9
EZ
69042011-03-12 Eli Zaretskii <eliz@gnu.org>
6905
c96bbc66 6906 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
6907 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6908 Constify `char *' arguments and their references according to
6909 prototypes in tparam.h.
6910
ecb0f94d 6911 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 6912
7ac80be9
EZ
6913 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6914 Adapt all references accordingly.
6915
6916 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6917
ef1fd07e
TT
69182011-03-11 Tom Tromey <tromey@redhat.com>
6919
6920 * buffer.c (syms_of_buffer): Remove obsolete comment.
6921
7ef4b50c
EZ
69222011-03-11 Eli Zaretskii <eliz@gnu.org>
6923
6924 * termhooks.h (encode_terminal_code): Declare prototype.
6925
6926 * msdos.c (encode_terminal_code): Don't declare prototype.
6927
6928 * term.c (encode_terminal_code): Now external again, used by
6929 w32console.c and msdos.c.
6930
44f230aa
SM
6931 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6932 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 6933
4b1ec863 69342011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 6935
1714f52b 6936 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 6937
4b1ec863
PE
6938 * fringe.c (update_window_fringes): Mark locals as initialized
6939 (Bug#8227).
6940 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 6941
524c7aa6
PE
6942 * alloc.c (mark_fringe_data): Move decl from here ...
6943 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6944 to check its interface.
6945 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6946
a5c0af81 6947 * fontset.c (free_realized_fontset): Now static.
7519b8cd 6948 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 6949 (fontset_font): Mark local as initialized.
a9a06e0b 6950 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 6951
b4716021
PE
6952 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6953
811e9bac 6954 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 6955 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
6956 (x_own_selection, Fx_disown_selection_internal): Rename locals
6957 to avoid shadowing.
6958 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 6959
7e3ab302
PE
6960 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6961 so that the caller can use some name other than gcpro1.
6962 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
6963 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6964 (Fx_backspace_delete_keys_p):
6965 Use them to avoid shadowing, and rename vars to avoid shadowing.
6966 (x_decode_color, x_set_name, x_window): Now static.
6b437900 6967 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 6968 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
6969 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6970 Remove unused locals.
7e3ab302
PE
6971 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6972 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6973 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6974 macros.
f78faa98 6975
e2b13473
PE
6976 * xterm.h (x_mouse_leave): New decl.
6977
77f23912
PE
6978 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6979 Remove unused functions.
cdf4ba58
PE
6980 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6981 (x_calc_absolute_position): Now static.
7411c686 6982 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 6983 Don't declare local "event" unless it's used.
ed7bf3a5
PE
6984 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6985 unless they are used.
38d0b34a
PE
6986 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6987 (x_fatal_error_signal): Remove; not used.
a6067996
PE
6988 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6989 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6990 (x_error_catcher, x_connection_closed, x_error_handler):
6991 (x_error_quitter, xembed_send_message, x_iconify_frame):
6992 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 6993 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 6994 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 6995
44f230aa
SM
6996 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6997 Rename or move locals to avoid shadowing.
6b463e58 6998 (tty_defined_color, merge_face_heights): Now static.
5967d051 6999 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
7000 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7001 does not deduce is never used uninitialized.
73719eba
PE
7002 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7003 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 7004
426994c3 7005 * terminal.c (store_terminal_param): Now static.
5489860b 7006
032f1620 7007 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 7008 (set_frame_menubar): Remove unused local.
d4323972 7009 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
7010 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7011 since they might point to immutable storage.
281585b0
PE
7012 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7013 since it's unused otherwise.
032f1620 7014
367c19e5 7015 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 7016 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
7017 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7018 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 7019 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
7020 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7021 does not deduce are never used uninitialized.
70739cbe 7022
07b48fa9
PE
7023 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7024
8868a238 7025 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
7026 * window.c (window_loop, size_window):
7027 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 7028
7e5cf297 7029 * window.c (display_buffer): Now static.
d6550a9f
PE
7030 (size_window): Mark variables that gcc -Wuninitialized
7031 does not deduce are never used uninitialized.
a586633d
PE
7032 * window.h (check_all_windows): New decl, to forestall
7033 gcc -Wmissing-prototypes diagnostic.
5b555da1 7034 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 7035
f6095868
PE
7036 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7037 shadowing.
7038 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
7039 Include <limits.h>.
7040 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7041 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
7042 (load_charset_map): Mark variables that gcc -Wuninitialized
7043 does not deduce are never used uninitialized.
53df7c11 7044 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 7045
f38b440c
PE
7046 * coding.c (coding_set_source, coding_set_destination):
7047 Use "else { /* comment */ }" rather than "else /* comment */;"
7048 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
7049 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7050 a block, when the outer 'i' will do.
7051 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7052 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7053 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7054 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7055 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7056 Rename locals to avoid shadowing.
7057 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
7058 * coding.c (emacs_mule_char, encode_invocation_designation):
7059 Now static, since they're not used elsewhere.
413bb2db 7060 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 7061 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
7062 (decode_coding_emacs_mule): Mark variables that gcc
7063 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
7064 (detect_coding_iso_2022): Initialize a local variable that might
7065 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 7066 this initialization is needed. (Bug#8211)
5f58e762
PE
7067 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7068 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7069 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7070 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7071 Remove unused macros.
f38b440c 7072
232b38b9 7073 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 7074 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 7075 * character.c (string_count_byte8): Likewise.
232b38b9 7076
fb90da1b
PE
7077 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7078 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7079
fb93dbc2
PE
7080 * chartab.c (copy_sub_char_table): Now static, since it's not used
7081 elsewhere.
5c156ace
PE
7082 (sub_char_table_ref_and_range, char_table_ref_and_range):
7083 Rename locals to avoid shadowing.
bbcd0949 7084 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 7085
7d3b3862 7086 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 7087 (BIDI_BOB): Remove unused macro.
7d3b3862 7088
6be7d3da
PE
7089 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7090 deduce are never used uninitialized.
c2ed9c8b 7091 * term.c (encode_terminal_code): Likewise.
6be7d3da 7092
75f8807f 7093 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 7094
50938595
PE
7095 * tparam.h: New file.
7096 * term.c, tparam.h: Include it.
7097 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7098 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7099 Move these decls to tparam.h, and make them agree with what
7100 is actually in tparam.c. The previous trick of using incompatible
7101 decls in different modules does not conform to the C standard.
7102 All callers of tparam changed to use tparam's actual API.
7103 * tparam.c (tparam1, tparam, tgoto):
7104 Use const pointers where appropriate.
7105
fbceeba2
PE
7106 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7107 * cm.h (struct cm): Likewise.
7108 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7109 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7110 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7111 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7112 (turn_on_face, init_tty): Likewise.
7113 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 7114
7f3f1250
PE
7115 * term.c (term_mouse_position): Rename local to avoid shadowing.
7116
e6ca6543
PE
7117 * alloc.c (mark_ttys): Move decl from here ...
7118 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7119
c40f8d15
AS
71202011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7121
7122 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7123
cfe0661d
JB
71242011-03-09 Juanma Barranquero <lekktu@gmail.com>
7125
7126 * search.c (compile_pattern_1): Remove argument regp, unused since
7127 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7128 (compile_pattern): Don't pass it.
7129
0afb4571
J
71302011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7131
7132 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7133 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7134 for ! HAVE_GTK3.
7135 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7136
7137 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7138
7139 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7140 gdk_window_get_screen, gdk_window_get_geometry,
7141 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7142 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7143 (xg_get_pixbuf_from_pixmap): New function.
7144 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7145 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7146 Call xg_get_pixbuf_from_pixmap instead of
7147 gdk_pixbuf_get_from_drawable.
7148 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7149 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7150 (xg_check_special_colors): Use GtkStyleContext and its functions
7151 for HAVE_GTK3.
7152 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7153 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7154 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
7155 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7156 Call gtk_widget_get_preferred_size.
0afb4571
J
7157 (xg_frame_resized): gdk_window_get_geometry only takes 5
7158 parameters.
44f230aa
SM
7159 (xg_win_to_widget, xg_event_is_for_menubar):
7160 Call gdk_x11_window_lookup_for_display.
0afb4571
J
7161 (xg_set_widget_bg): New function.
7162 (delete_cb): New function.
895009e1 7163 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
7164 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7165 (xg_set_background_color): Call xg_set_widget_bg.
7166 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7167 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7168 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7169 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7170 if ! HAVE_GTK3.
7171 (update_frame_tool_bar): Call gtk_widget_hide.
7172 (xg_initialize): Use GDK_KEY_g.
7173
7174 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7175 if ! HAVE_GTK3
7176 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7177
7178 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7179 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7180 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7181
1c2cc4ef
JB
71822011-03-08 Juanma Barranquero <lekktu@gmail.com>
7183
7184 * w32xfns.c (select_palette): Check success of RealizePalette against
7185 GDI_ERROR, not zero.
7186
33383987 7187See ChangeLog.11 for earlier changes.
aac0c6e3
MR
7188
7189;; Local Variables:
7190;; coding: utf-8
aac0c6e3
MR
7191;; End:
7192
33383987 7193 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
7194
7195 This file is part of GNU Emacs.
7196
7197 GNU Emacs is free software: you can redistribute it and/or modify
7198 it under the terms of the GNU General Public License as published by
7199 the Free Software Foundation, either version 3 of the License, or
7200 (at your option) any later version.
7201
7202 GNU Emacs is distributed in the hope that it will be useful,
7203 but WITHOUT ANY WARRANTY; without even the implied warranty of
7204 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7205 GNU General Public License for more details.
7206
7207 You should have received a copy of the GNU General Public License
7208 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.