* regex.c (re_iswctype): Convert return values to boolean.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
f3fcc40d
AS
12011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2
3 * regex.c (re_iswctype): Convert return values to boolean.
4
350c992f
EZ
52011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
6
7 * xdisp.c (compute_display_string_pos): Don't use cached display
8 string position if the buffer had its restriction changed.
9 (Bug#9184)
10
5266b4bb
PE
112011-07-28 Paul Eggert <eggert@cs.ucla.edu>
12
13 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
14
2573a837 152011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 16
41f55ccd 17 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 18
39e378da
PE
19 * bidi.c: Integer size and overflow fixes.
20 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
21 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
22 (bidi_cache_find_level_change, bidi_cache_ensure_space)
23 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
24 (bidi_find_other_level_edge):
25 Use ptrdiff_t instead of EMACS_INT where either will do.
26 This works better on 32-bit hosts configured --with-wide-int.
27 (bidi_cache_ensure_space): Check for size-calculation overflow.
28 Use % rather than repeated addition, for better worst-case speed.
29 Don't set bidi_cache_size until after xrealloc returns, because it
30 might not return.
31 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
32 (bidi_cache_ensure_space): Also check that the bidi cache size
33 does not exceed that of the largest Lisp string or buffer. See Eli
34 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 35
5e927815
PE
36 * alloc.c (__malloc_size_t): Remove.
37 All uses replaced by size_t. See Andreas Schwab's note
38 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
39
ca4aa935
PE
40 * image.c: Improve checking for integer overflow.
41 (check_image_size): Assume that f is nonnull, since
42 it is always nonnull in practice. This is one less thing to
43 worry about when checking for integer overflow later.
44 (x_check_image_size): New function, which checks for integer
45 overflow issues inside X.
46 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
47 This removes the need for a memory_full check.
48 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
49 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
50 (xbm_read_bitmap_data): Change locals back to 'int', since
51 their values must fit in 'int'.
52 (xpm_load_image, png_load, tiff_load):
53 Invoke x_create_x_image_and_pixmap earlier,
54 to avoid much needless work if the image is too large.
55 (tiff_load): Treat overly large images as if
56 x_create_x_image_and_pixmap failed, not as malloc failures.
57 (gs_load): Use x_check_image_size.
58
5f8f9cc2
PE
59 * gtkutil.c: Omit integer casts.
60 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
61 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
62
5adf60bc
PE
63 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
64
c8907a93
PE
65 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
66 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
67 would wrongly return t on a 64-bit host.
68
e3c25c68
PE
69 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
70 The plain *_OVERFLOW macros run afoul of GCC bug 49705
71 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
72 and therefore cause GCC to emit a bogus diagnostic in some cases.
73
3f791afe
PE
74 * image.c: Integer signedness and overflow and related fixes.
75 This is not an exhaustive set of fixes, but it's time to
76 record what I've got.
77 (lookup_pixel_color, check_image_size): Remove redundant decls.
78 (check_image_size): Don't assume that arbitrary EMACS_INT values
79 fit in 'int', or that arbitrary 'double' values fit in 'int'.
80 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
81 (tiff_load, imagemagick_load_image):
82 Check for overflow in size calculations.
83 (x_create_x_image_and_pixmap): Remove unnecessary test for
84 xmalloc returning NULL; that can't happen.
85 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
86 (xpm_color_bucket): Use better integer hashing function.
87 (xpm_cache_color): Don't possibly over-allocate memory.
88 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
89 (gif_memory_source):
90 Use ptrdiff_t, not int or size_t, to record sizes.
91 (png_load): Don't assume values greater than 2**31 fit in 'int'.
92 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
93 either works, as we prefer signed integers.
94 (tiff_read_from_memory, tiff_write_from_memory):
95 Return tsize_t, not size_t, since that's what the TIFF API wants.
96 (tiff_read_from_memory): Don't fail simply because the read would
97 go past EOF; instead, return a short read.
98 (tiff_load): Omit no-longer-needed casts.
99 (Fimagemagick_types): Don't assume size fits into 'int'.
100
3cc5a532
PE
101 Improve hashing quality when configured --with-wide-int.
102 * fns.c (hash_string): New function, taken from sxhash_string.
103 Do not discard information about ASCII character case; this
104 discarding is no longer needed.
105 (sxhash-string): Use it. Change sig to match it. Caller changed.
106 * lisp.h: Declare it.
107 * lread.c (hash_string): Remove, since we now use fns.c's version.
108 The fns.c version returns a wider integer if --with-wide-int is
109 specified, so this should help the quality of the hashing a bit.
110
b312a492
PE
111 * emacs.c: Integer overflow minor fix.
112 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
113 Define only if GNU_LINUX.
114 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
115
dfd153ae
PE
116 * dispnew.c: Integer signedness and overflow fixes.
117 Remove unnecessary forward decls, that were a maintenance hassle.
118 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
119 All uses changed.
120 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
121 (scrolling_window): Use ptrdiff_t, not int, for byte count.
122 (prepare_desired_row, line_draw_cost):
123 Use int, not unsigned, where either works.
124 (save_current_matrix, restore_current_matrix):
125 Use ptrdiff_t, not size_t, where either works.
126 (init_display): Check for overflow more accurately, and without
127 relying on undefined behavior.
128
a81d11a3
PE
129 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
130 Remove, replacing with the new symbols in lisp.h. All uses changed.
131 * fileio.c (make_temp_name):
132 * filelock.c (lock_file_1, lock_file):
133 * xdisp.c (message_dolog):
134 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
135 Use pMd etc. instead.
136 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
137 replacing the pWIDE etc. symbols removed from editfns.c.
138
3300e6fd
PE
139 * keyboard.h (num_input_events): Now uintmax_t.
140 This is (very slightly) less likely to mess up due to wraparound.
141 All uses changed.
142
fd05c7e9
PE
143 * buffer.c: Integer signedness fixes.
144 (alloc_buffer_text, enlarge_buffer_text):
145 Use ptrdiff_t rather than size_t when either will do, as we prefer
146 signed integers.
147
903fe15d
PE
148 * alloc.c: Integer signedness and overflow fixes.
149 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
150 (__malloc_size_t): Default to size_t, not to int.
151 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
152 (Fgarbage_collect, mark_object_loop_halt, mark_object):
153 Prefer ptrdiff_t to size_t when either would do, as we prefer
154 signed integers.
155 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
156 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
157 Now const. Initialize with values that are in range even if char
158 is signed.
159 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
160 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
161 These functions do the right thing with sizes > 2**32.
162 (check_depth): Now ptrdiff_t, not int.
163 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
164 Adjust to new way of storing sizes. Check for size overflow bugs
165 in rest of code.
166 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
167 slightly wrong anyway, as it missed one instance of
168 XMALLOC_OVERRUN_CHECK_OVERHEAD.
169 (refill_memory_reserve): Omit needless cast to size_t.
170 (mark_object_loop_halt): Mark as externally visible.
171
ac82cc6a
PE
172 * xselect.c: Integer signedness and overflow fixes.
173 (Fx_register_dnd_atom, x_handle_dnd_message):
174 Use ptrdiff_t, not size_t, since we prefer signed.
175 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
176 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
177 x_dnd_atoms_size and x_dnd_atoms_length.
178
c2d1e36d
PE
179 * doprnt.c: Prefer signed to unsigned when either works.
180 * eval.c (verror):
181 * doprnt.c (doprnt):
182 * lisp.h (doprnt):
183 * xdisp.c (vmessage):
184 Use ptrdiff_t, not size_t, when using or implementing doprnt,
185 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
186 prefer signed arithmetic to avoid comparison confusion.
187 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
188 but is a bit tricky.
189
0e926e56
PE
190 Assume freestanding C89 headers, string.h, stdlib.h.
191 * data.c, doprnt.c, floatfns.c, print.c:
192 Include float.h unconditionally.
193 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
194 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
195 * regex.c: Likewise for stddef.h, string.h.
196 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
197 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
198 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
199 (STDC_HEADERS): Remove obsolete defines.
200 * sysdep.c: Include limits.h unconditionally.
201
9cfdb3ec
PE
202 Assume support for memcmp, memcpy, memmove, memset.
203 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
204 * regex.c (memcmp, memcpy):
205 Remove; we assume C89 now.
206
207 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
208 (__malloc_safe_bcopy): Remove; no longer needed.
209
cf950e6b 210 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
211 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
212 well either way, and we prefer signed to unsigned.
213
dbf38e02
LMI
2142011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
215
216 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
217 closes the connection while we're reading (bug#9182).
218
d6f0886c
JD
2192011-07-25 Jan Djärv <jan.h.d@swipnet.se>
220
221 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
222 are specified (Bug#9168).
223
2eb1f9e6
PE
2242011-07-25 Paul Eggert <eggert@cs.ucla.edu>
225
226 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
227 Found by GCC static checking and --with-wide-int on a 32-bit host.
228
22381272 2292011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
230
231 * xdisp.c (compute_display_string_pos): Fix logic of caching
232 previous display string position. Initialize cached_prev_pos to
233 -1. Fixes slow-down at the beginning of a buffer.
234
f25e39b4
EZ
2352011-07-24 Eli Zaretskii <eliz@gnu.org>
236
237 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
238 for attrs[LFACE_FONTSET_INDEX].
239
04c4b52e
PE
2402011-07-23 Paul Eggert <eggert@cs.ucla.edu>
241
242 * xml.c (parse_region): Remove unused local
243 that was recently introduced.
244
c1734fbd
EZ
2452011-07-23 Eli Zaretskii <eliz@gnu.org>
246
be18c5a5
EZ
247 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
248 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
249
c1734fbd
EZ
250 * xdisp.c (move_it_in_display_line_to): Record the best matching
251 position for TO_CHARPOS while scanning the line, and restore it on
252 exit if none of the characters scanned was an exact match. Fixes
a9269c18
EZ
253 vertical-motion and pos-visible-in-window-p under bidi redisplay
254 when exact match is impossible due to invisible text, and the
255 lines are truncated.
256
a258d627
JD
2572011-07-23 Jan Djärv <jan.h.d@swipnet.se>
258
259 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
260 for OSX >= 10.7.
261
b6d5a689
EZ
2622011-07-22 Eli Zaretskii <eliz@gnu.org>
263
0f74f785
EZ
264 Fix a significant slow-down of cursor motion with C-n, C-p,
265 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
266 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 267 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
268 (next_element_from_buffer): Call compute_stop_pos_backwards to
269 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
270 base_level_stop.
271 (reseat): Don't look for prev_stop, as that could mean a very long
272 run.
273 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
274 <cached_disp_overlay_modiff>: Cache for last found display string
275 position.
551918c1 276 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
277 about the same buffer in the same area of character positions, and
278 the buffer wasn't changed since the time the display string
279 position was cached.
551918c1 280
b2d0c91a
EZ
2812011-07-22 Eli Zaretskii <eliz@gnu.org>
282
283 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
284 is an integer, which is important for empty lines. (Bug#9149)
285
043604ee
CY
2862011-07-22 Chong Yidong <cyd@stupidchicken.com>
287
288 * frame.c (Fmodify_frame_parameters): In tty case, update the
289 default face if necessary (Bug#4238).
290
da4adb04
CY
2912011-07-21 Chong Yidong <cyd@stupidchicken.com>
292
293 * editfns.c (Fstring_to_char): No need to explain what a character
294 is in the docstring (Bug#6576).
295
9abd0532
LMI
2962011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
297
298 * xml.c (parse_region): Make sure we always return a tree.
299
36881d16
HK
3002011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
301
302 * xml.c (parse_region): If a document contains only comments,
303 return that, too.
304
1e98674d
LMI
3052011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
306
307 * xml.c (make_dom): Return comments, too.
308
590bd467
PE
3092011-07-19 Paul Eggert <eggert@cs.ucla.edu>
310
311 Port to OpenBSD.
312 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
313 and the surrounding thread.
314 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
315 rather than fgets, and retry after EINTR. Otherwise, 'emacs
316 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
317 timer goes off.
318 * s/openbsd.h (BROKEN_SIGIO): Define.
319 * unexelf.c (unexec) [__OpenBSD__]:
320 Don't update the .mdebug section of the Alpha COFF symbol table.
321
f41628b2
LMI
3222011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
323
324 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
325 (bug#8460).
326
b59b67c5
PE
3272011-07-18 Paul Eggert <eggert@cs.ucla.edu>
328
15e3a074
PE
329 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
330 This fixes some race conditions on the permissions of any newly
331 created file.
332
41bed37d
PE
333 * alloc.c (valid_pointer_p): Use pipe, not open.
334 This fixes some permissions issues when debugging.
335
b59b67c5
PE
336 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
337 If fchown fails to set both uid and gid, try to set just gid,
338 as that is sometimes allowed. Adjust the file's mode to eliminate
339 setuid or setgid bits that are inappropriate if fchown fails.
340
925a6be7
SM
3412011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
342
343 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
344 to compare Lisp_Objects.
345 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
346 global_gnutls_log_level, don't mistake it for a Lisp_Object.
347 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
348
52968808
AS
3492011-07-17 Andreas Schwab <schwab@linux-m68k.org>
350
0a6a104b
AS
351 * lread.c (read_integer): Unread even EOF character.
352 (read1): Likewise. Properly record start position of symbol.
353
52968808
AS
354 * lread.c (read1): Read `#:' as empty uninterned symbol if no
355 symbol character follows.
356
9e381cdd
PE
3572011-07-17 Paul Eggert <eggert@cs.ucla.edu>
358
359 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
360 This works around a problem with the previous change to Fcopy_file.
361 Recent glibc declares fchown with __attribute__((warn_unused_result)),
362 and without this change, GCC might complain about discarding
363 fchown's return value.
364
b5641435
JB
3652011-07-16 Juanma Barranquero <lekktu@gmail.com>
366
367 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
368
a8031457
PE
3692011-07-16 Paul Eggert <eggert@cs.ucla.edu>
370
371 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
372
dd889327
LMI
3732011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
374
750c33f7
LMI
375 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
376 it's used from the C level.
377
dd889327
LMI
378 * process.c: Use the same condition for POLL_FOR_INPUT in both
379 keyboard.c and process.c (bug#1858).
380
87e86684
LM
3812011-07-09 Lawrence Mitchell <wence@gmx.li>
382
383 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
384 (Fgnutls_boot): Use it.
385
64348f40
AS
3862011-07-15 Andreas Schwab <schwab@linux-m68k.org>
387
388 * doc.c (Fsubstitute_command_keys): Revert last change.
389
1d698799
LMI
3902011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
391
f863868c
LMI
392 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
393 quotes the next character, and doesn't affect other longer
394 sequences (bug#8935).
395
1d698799
LMI
396 * lread.c (syms_of_lread): Clarify that is isn't only
397 `eval-buffer' and `eval-defun' that's affected by
398 `lexical-binding' (bug#8460).
399
aa4b6df6
EZ
4002011-07-15 Eli Zaretskii <eliz@gnu.org>
401
402 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
403 bidi redisplay when a line includes both an image and is
404 truncated.
405
5d856da6
PE
4062011-07-14 Paul Eggert <eggert@cs.ucla.edu>
407
ad6042bb
PE
408 Fix minor problems found by static checking.
409 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
410 (elsz): Now a signed constant, not a size_t var. We prefer signed
411 types to unsigned, to avoid integer comparison confusion. Without
412 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
413 "cannot optimize loop, the loop counter may overflow", a symptom
414 of the confusion.
f00bbb22 415 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
416 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
417
6468f31c
LMI
4182011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
419
49080b10
LMI
420 * search.c (Fre_search_backward): Mention `case-fold-search' in
421 all the re_search_* functions (bug#8138).
422
6468f31c
LMI
423 * keyboard.c (Fopen_dribble_file): Document when the file is
424 closed (bug#8056).
425
c965adc5
EZ
4262011-07-14 Eli Zaretskii <eliz@gnu.org>
427
df9733bf
EZ
428 * bidi.c (bidi_dump_cached_states): Fix format of displaying
429 bidi_cache_idx.
430
0bb23927
EZ
431 Support bidi reordering of display and overlay strings.
432 * xdisp.c (compute_display_string_pos)
433 (compute_display_string_end): Accept additional argument STRING.
434 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
435 (reseat_to_string): Initialize bidi_it->string.s and
436 bidi_it->string.schars.
437 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
438 NULL (avoids a crash in bidi_paragraph_init). Initialize
439 itb.string.lstring.
440 (init_iterator): Call bidi_init_it only of a valid
441 buffer position was specified. Initialize paragraph_embedding to
442 L2R.
443 (reseat_to_string): Initialize the bidi iterator.
444 (display_string): If we need to ignore text properties of
445 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
446 original value of -1 will not work with bidi.)
447 (compute_display_string_pos): First arg is now struct
448 `text_pos *'; all callers changed. Support display properties on
449 Lisp strings.
450 (compute_display_string_end): Support display properties on Lisp
451 strings.
452 (init_iterator, reseat_1, reseat_to_string): Initialize the
453 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
454 when iterating on a string not from display properties).
455 (compute_display_string_pos, compute_display_string_end): Fix
456 calculation of the object to scan. Fixes an error when using
457 arrow keys.
458 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
459 base_level_stop; instead, set base_level_stop to BEGV. Fixes
460 crashes in vertical-motion.
461 (next_element_from_buffer): Improve commentary for when
462 the iterator is before prev_stop.
463 (init_iterator): Initialize bidi_p from the default value of
464 bidi-display-reordering, not from buffer-local value. Use the
465 buffer-local value only if initializing for buffer iteration.
466 (handle_invisible_prop): Support invisible properties on strings
467 that are being bidi-reordered.
468 (set_iterator_to_next): Support bidi reordering of C strings and
469 Lisp strings.
470 (next_element_from_string): Support bidi reordering of Lisp
471 strings.
472 (handle_stop_backwards): Support Lisp strings as well.
473 (display_string): Support display of R2L glyph rows. Use
474 IT_STRING_CHARPOS when displaying from a Lisp string.
475 (init_iterator): Don't initialize it->bidi_p for strings
476 here.
477 (reseat_to_string): Initialize it->bidi_p for strings here.
478 (next_element_from_string, next_element_from_c_string)
479 (next_element_from_buffer): Add xassert's for correspondence
480 between IT's object being iterated and it->bidi_it.string
481 structure.
482 (face_before_or_after_it_pos): Support bidi iteration.
483 (next_element_from_c_string): Handle the case of the first string
484 character that is not the first one in the visual order.
485 (get_visually_first_element): New function, refactored from common
486 parts of next_element_from_buffer, next_element_from_string, and
487 next_element_from_c_string.
488 (tool_bar_lines_needed, redisplay_tool_bar)
489 (display_menu_bar): Force left-to-right direction. Add a FIXME
490 comment for making that be controlled by a user option.
491 (push_it, pop_it): Save and restore the state of the
492 bidi iterator. Save and restore the bidi_p flag.
493 (pop_it): Iterate out of display property for string iteration as
494 well.
495 (iterate_out_of_display_property): Support iteration over strings.
496 (handle_single_display_spec): Set up it->bidi_it for iteration
497 over a display string, and call bidi_init_it.
498 (handle_single_display_spec, next_overlay_string)
499 (get_overlay_strings_1, push_display_prop): Set up the bidi
500 iterator for displaying display or overlay strings.
501 (forward_to_next_line_start): Don't use the shortcut if
502 bidi-iterating.
503 (back_to_previous_visible_line_start): If handle_display_prop
504 pushed the iterator stack, restore the internal state of the bidi
505 iterator by calling bidi_pop_it same number of times.
506 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
507 and we are bidi-iterating, don't decrement the iterator position;
508 instead, set the first_elt flag in the bidi iterator, to produce
509 the same effect.
510 (reseat_1): Remove redundant setting of string_from_display_prop_p.
511 (push_display_prop): xassert that we are iterating a buffer.
512 (push_it, pop_it): Save and restore paragraph_embedding member.
513 (handle_single_display_spec, next_overlay_string)
514 (get_overlay_strings_1, reseat_1, reseat_to_string)
515 (push_display_prop): Set up the `unibyte' member of bidi_it.string
516 correctly. Don't assume unibyte strings are not bidi-reordered.
517 (compute_display_string_pos)
518 (compute_display_string_end): Fix handling the case of C string.
519 (push_it, pop_it): Save and restore from_disp_prop_p.
520 (handle_single_display_spec, push_display_prop): Set the
521 from_disp_prop_p flag.
522 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
523 (pop_it): Call iterate_out_of_display_property only if we are
524 popping after iteration over a string that came from a display
525 property. Fix a typo in popping stretch info. Add an assertion
526 for verifying that the iterator position is in sync with the bidi
527 iterator.
528 (handle_single_display_spec, get_overlay_strings_1)
529 (push_display_prop): Fix initialization of paragraph direction for
530 string when that of the parent object is not yet determined.
531 (reseat_1): Call bidi_init_it to resync the bidi
532 iterator with IT's position. (Bug#7616)
533 (find_row_edges): If ROW->start.pos gives position
534 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
535 (handle_stop, back_to_previous_visible_line_start, reseat_1):
536 Reset the from_disp_prop_p flag.
537 (SAVE_IT, RESTORE_IT): New macros.
538 (pos_visible_p, face_before_or_after_it_pos)
539 (back_to_previous_visible_line_start)
540 (move_it_in_display_line_to, move_it_in_display_line)
541 (move_it_to, move_it_vertically_backward, move_it_by_lines)
542 (try_scrolling, redisplay_window, display_line): Use them when
543 saving a temporary copy of the iterator and restoring it back.
544 (back_to_previous_visible_line_start, reseat_1)
545 (init_iterator): Empty the bidi cache "stack".
546 (move_it_in_display_line_to): If iterator ended up at
547 EOL, but we never saw any buffer positions smaller than
548 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
549 motion in bidi-reordered lines.
550 (move_it_in_display_line_to): Record prev_method and prev_pos
551 immediately before the call to set_iterator_to_next. Fixes cursor
552 motion in bidi-reordered lines with stretch glyphs and strings
553 displayed in margins. (Bug#8133) (Bug#8867)
554 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
555 TO_CHARPOS.
556 (pos_visible_p): Support positions in bidi-reordered lines. Save
557 and restore bidi cache.
558
559 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
560 (bidi_paragraph_info): Delete unused struct.
561 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
562 (bidi_cache_start): New variable.
563 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
564 to zero.
565 (bidi_cache_fetch_state, bidi_cache_search)
566 (bidi_cache_find_level_change, bidi_cache_iterator_state)
567 (bidi_cache_find, bidi_peek_at_next_level)
568 (bidi_level_of_next_char, bidi_find_other_level_edge)
569 (bidi_move_to_visually_next): Compare cache index with
570 bidi_cache_start rather than with zero.
571 (bidi_fetch_char): Accept new argument STRING; all callers
572 changed. Support iteration over a string. Support strings with
573 display properties. Support unibyte strings. Fix the type of
574 `len' according to what STRING_CHAR_AND_LENGTH expects.
575 (bidi_paragraph_init, bidi_resolve_explicit_1)
576 (bidi_resolve_explicit, bidi_resolve_weak)
577 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
578 iteration over a string.
579 (bidi_set_sor_type, bidi_resolve_explicit_1)
580 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
581 can now be zero (for strings); special values 0 and -1 were
582 changed to -1 and -2, respectively.
583 (bidi_char_at_pos): New function.
584 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
585 Call it instead of FETCH_MULTIBYTE_CHAR.
586 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
587 initialized to valid values.
588 (bidi_init_it): Don't initialize charpos and bytepos with invalid
589 values.
590 (bidi_level_of_next_char): Allow the sentinel "position" to pass
591 the test for valid cached positions. Fix the logic for looking up
592 the sentinel state in the cache. GCPRO the Lisp string we are
593 iterating.
594 (bidi_push_it, bidi_pop_it): New functions.
595 (bidi_initialize): Initialize the bidi cache start stack pointer.
596 (bidi_cache_ensure_space): New function, refactored from part of
597 bidi_cache_iterator_state. Don't assume the required size is just
598 one BIDI_CACHE_CHUNK away.
599 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
600 (bidi_count_bytes, bidi_char_at_pos): New functions.
601 (bidi_cache_search): Don't assume bidi_cache_last_idx is
602 always valid if bidi_cache_idx is valid.
603 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
604 is valid if it's going to be used.
605 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
606 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
607 (bidi_cache_find_level_change, bidi_cache_ensure_space)
608 (bidi_cache_iterator_state, bidi_cache_find)
609 (bidi_find_other_level_edge, bidi_cache_start_stack): All
610 variables related to cache indices are now EMACS_INT.
611
0bb23927
EZ
612 * dispextern.h (struct bidi_string_data): New structure.
613 (struct bidi_it): New member `string'. Make flag members be 1-bit
614 fields, and put them last in the struct.
615 (compute_display_string_pos, compute_display_string_end): Update
616 prototypes.
617 (bidi_push_it, bidi_pop_it): Add prototypes.
618 (struct iterator_stack_entry): New members bidi_p,
619 paragraph_embedding, and from_disp_prop_p.
620 (struct it): Member bidi_p is now a bit field 1 bit wide.
621 (bidi_shelve_cache, bidi_unshelve_cache): Declare
622 prototypes.
623
624 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
625 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
626 and vector-like objects.
627
628 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
629 cache around display iteration.
630
631 * window.c (Fwindow_end, window_scroll_pixel_based)
632 (displayed_window_lines, Frecenter): Save and restore the bidi
633 cache around display iteration.
634
3bbd2265
LMI
6352011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
636
637 * editfns.c (Fdelete_region): Clarify the use of the named
638 parameters (bug#6788).
639
adc47434
MR
6402011-07-14 Martin Rudalics <rudalics@gmx.at>
641
642 * indent.c (Fvertical_motion): Set and restore w->pointm when
643 saving and restoring the window's buffer (Bug#9006).
644
837c31f8
LMI
6452011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
646
647 * editfns.c (Fstring_to_char): Clarify just what is returned
648 (bug#6576). Text by Eli Zaretskii.
649
ac389d0c
JB
6502011-07-13 Juanma Barranquero <lekktu@gmail.com>
651
652 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
653
0be0ce47
EZ
6542011-07-13 Eli Zaretskii <eliz@gnu.org>
655
656 * buffer.c (mmap_find): Fix a typo.
657
cd18e7e3
JB
6582011-07-13 Johan Bockgård <bojohan@gnu.org>
659
660 Fix execution of x selection hooks.
661 * xselect.c (Qx_lost_selection_functions)
662 (Qx_sent_selection_functions): New vars.
663 (syms_of_xselect): DEFSYM them.
664 (x_handle_selection_request): Pass Qx_sent_selection_functions
665 rather than Vx_sent_selection_functions to Frun_hook_with_args.
666 (x_handle_selection_clear,x_clear_frame_selections):
667 Pass Qx_lost_selection_functions rather than
668 Vx_lost_selection_functions to Frun_hook_with_args.
669
47ea7f44
PE
6702011-07-13 Paul Eggert <eggert@cs.ucla.edu>
671
ac389d0c 672 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
673 The old code sometimes used this field without initializing it.
674
47ea7f44
PE
675 * alloc.c (gc_sweep): Don't read past end of array.
676 In theory, the old code could also have corrupted Emacs internals,
677 though it'd be very unlikely.
678
bc985c87
AS
6792011-07-12 Andreas Schwab <schwab@linux-m68k.org>
680
681 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 682 argument. (Bug#4026)
bc985c87 683
0cf34688
LMI
6842011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
685
b3dadd76
LMI
686 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
687 key" (bug#4257).
688
0cf34688
LMI
689 * window.c (Fset_window_start): Doc fix (bug#4199).
690 (Fset_window_hscroll): Ditto.
691
270768cd
PE
6922011-07-12 Paul Eggert <eggert@cs.ucla.edu>
693
077e3dda 694 Fix minor new problems caught by GCC 4.6.1.
270768cd 695 * term.c (init_tty): Remove unused local.
490011a6 696 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 697 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 698 not used otherwise.
270768cd 699
b1f58454
CY
7002011-07-12 Chong Yidong <cyd@stupidchicken.com>
701
702 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
703
22b9578d
LMI
7042011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
705
6e70ab07
LMI
706 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
707 are the mini-buffer and the echo area (bug#3320).
708
22b9578d
LMI
709 * term.c (init_tty): Remove support for supdup, c10 and perq
710 terminals, which are no longer supported (bug#1482).
711
8974cc9f
JB
7122011-07-10 Johan Bockgård <bojohan@gnu.org>
713
714 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
715
a560d974
JD
7162011-07-10 Jan Djärv <jan.h.d@swipnet.se>
717
718 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
719 for non-popups (Bug#3642).
720
1dae0f0a
AS
7212011-07-10 Andreas Schwab <schwab@linux-m68k.org>
722
268c2c36 723 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 724 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
725 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
726 * cm.c (losecursor): Likewise.
1dae0f0a
AS
727 * data.c (fmod): Likewise.
728 * dispnew.c (swap_glyphs_in_rows): Likewise.
729 * emacs.c (memory_warning_signal): Likewise.
730 * floatfns.c (float_error): Likewise.
731 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
732 (otf_open, font_otf_capability, generate_otf_features)
733 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
734 Likewise.
735 * image.c (pbm_read_file): Likewise.
736 * indent.c (string_display_width): Likewise.
737 * intervals.c (check_for_interval, search_for_interval)
738 (inc_interval_count, count_intervals, root_interval)
739 (adjust_intervals_for_insertion, make_new_interval): Likewise.
740 * lread.c (defalias): Likewise.
268c2c36 741 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
742 * regex.c (set_image_of_range_1, set_image_of_range)
743 (regex_grow_registers): Likewise.
744 * sysdep.c (strerror): Likewise.
745 * termcap.c (valid_filename_p, tprint, main): Likewise.
746 * tparam.c (main): Likewise.
747 * unexhp9k800.c (run_time_remap, save_data_space)
748 (update_file_ptrs, read_header, write_header, calculate_checksum)
749 (copy_file, copy_rest, display_header): Likewise.
750 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
751 Likewise.
752 * xdisp.c (check_it): Likewise.
753 * xfaces.c (register_color, unregister_color, unregister_colors):
754 Likewise.
755 * xfns.c (print_fontset_result): Likewise.
756 * xrdb.c (member, fatal, main): Likewise.
757
99033785
PE
7582011-07-10 Paul Eggert <eggert@cs.ucla.edu>
759
760 Fix minor problems found by static checking (Bug#9031).
761 * chartab.c (char_table_set_range, map_sub_char_table):
762 Remove unused locals.
763 (uniprop_table): Now static.
764 * composite.c (_work_char): Remove unused static var.
765
9cb2ac56
JB
7662011-07-09 Juanma Barranquero <lekktu@gmail.com>
767
768 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
769
f25661f0
JD
7702011-07-09 Jan Djärv <jan.h.d@swipnet.se>
771
772 * gtkutil.c (qttip_cb): Remove code without function.
773
8278c4fe
EZ
7742011-07-09 Eli Zaretskii <eliz@gnu.org>
775
776 * w32.c (pthread_sigmask): New stub.
777
1692ae2d 7782011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 779
8a6ebd58 780 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
781 sigprocmask is portable only for single-threaded applications, and
782 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
783 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
784 (LIBES): Use it.
785 * callproc.c (Fcall_process):
786 * process.c (create_process):
787 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
788 Use pthread_sigmask, not sigprocmask.
123403e4 789
1b854618
JD
7902011-07-08 Jan Djärv <jan.h.d@swipnet.se>
791
792 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
793 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
794 wrong (Bug#8591).
795
3fe4b549
JD
7962011-07-08 Jan Djärv <jan.h.d@swipnet.se>
797
0ce7e563
JD
798 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
799 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
800 (xg_hide_tooltip): Fix comment.
801
3fe4b549
JD
802 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
803 in registerServicesMenuSendTypes.
804 (validRequestorForSendType): Don't check ns_return_types.
805
806 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
807 ns_return_type.
808
5df75e47
JR
8092011-07-08 Jason Rumney <jasonr@gnu.org>
810
811 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
812 frame struct members of non-existent frames (Bug#6284).
813
699c10bd
JD
8142011-07-08 Jan Djärv <jan.h.d@swipnet.se>
815
4393663b
JD
816 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
817 variable firstTime not needed on OSX >= 10.6.
818 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
819 >= 10.5. Use setKnobProportion, setDoubleValue.
820
821 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
822 (MAC_OS_X_VERSION_10_5): Define if not defined.
823 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
824 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
825 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
826
827 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
828 cString and lossyCString on OSX >= 10.4
829
830 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
831 sizeToFit on OSX >= 10.2.
832
833 * nsimage.m (allocInitFromFile): Don't use deprecated method
834 bestRepresentationForDevice on OSX >= 10.6.
835
836 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
837 to avoid warning.
838
839 * emacs.c: Declare unexec_init_emacs_zone.
840
a63e0781
JD
841 * nsgui.h: Fix compiler warning about gnulib redefining verify.
842
699c10bd
JD
843 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
844
845 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
846 on svcsMenu (Bug#8842).
847
848 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
849 ns_return_types.
850 (Fns_list_services): Just return Qnil on 10.6, code not working there.
851
852 * nsterm.m (QUTF8_STRING): Declare.
853 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
854 (validRequestorForSendType): Return type is (id).
855 Change indexOfObjectIdenticalTo to indexOfObject.
856 Check if we have local selection before returning self (Bug#8842).
857 (writeSelectionToPasteboard): Put local selection into paste board
858 if we have a local selection (Bug#8842).
859 (syms_of_nsterm): DEFSYM QUTF8_STRING.
860
861 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
862 (ns_get_local_selection): Declare.
863
54e10184
LMI
8642011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
865
9888ff71
LMI
866 * keymap.c (describe_map_tree): Don't insert a double newline at
867 the end of the buffer (bug#1169) and return whether we inserted
868 something.
869
54e10184
LMI
870 * callint.c (Fcall_interactively): Change "reading args" to
871 "providing args" to try to clarify what it does (bug#1010).
872
15fa4783
KH
8732011-07-07 Kenichi Handa <handa@m17n.org>
874
875 * composite.c (composition_compute_stop_pos): Ignore a static
876 composition starting before CHARPOS (Bug#8915).
877
878 * xdisp.c (handle_composition_prop): Likewise.
879
a8815b00
EZ
8802011-07-07 Eli Zaretskii <eliz@gnu.org>
881
882 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
883 (Bug#9015)
884
ef7b981d 8852011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
886
887 * character.h (unicode_category_t): New enum type.
888
889 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
890 (Qchar_code_property_table): New variable.
891 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
892 (UNIPROP_COMPRESSED_FORM_P): New macros.
893 (char_table_ascii): Uncompress the compressed values.
894 (sub_char_table_ref): New arg is_uniprop. Callers changed.
895 Uncompress the compressed values.
ac389d0c 896 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
897 (char_table_ref_and_range): Uncompress the compressed values.
898 (sub_char_table_set): New arg is_uniprop. Callers changed.
899 Uncompress the compressed values.
900 (sub_char_table_set_range): Args changed. Callers changed.
901 (char_table_set_range): Adjuted for the above change.
902 (map_sub_char_table): Delete args default_val and parent. Add arg
903 top. Give decoded values to a Lisp function.
904 (map_char_table): Adjusted for the above change. Give decoded
905 values to a Lisp function. Gcpro more variables.
906 (uniprop_table_uncompress)
907 (uniprop_decode_value_run_length): New functions.
908 (uniprop_decoder, uniprop_decoder_count): New variables.
909 (uniprop_get_decoder, uniprop_encode_value_character)
910 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
911 New functions.
912 (uniprop_encoder, uniprop_encoder_count): New variables.
913 (uniprop_get_encoder, uniprop_table)
914 (Funicode_property_table_internal, Fget_unicode_property_internal)
915 (Fput_unicode_property_internal): New functions.
916 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
917 Sunicode_property_table_internal, Sget_unicode_property_internal,
918 and Sput_unicode_property_internal. Defvar_lisp
919 char-code-property-alist.
920
921 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
922 Vunicode_category_table.
923
924 * font.c (font_range): Adjusted for the change of
925 Vunicode_category_table.
926
76b397fb
DN
9272011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
928
929 * m/iris4d.h: Remove file, move contents ...
930 * s/irix6-5.h: ... here.
931
22b4128e
PE
9322011-07-06 Paul Eggert <eggert@cs.ucla.edu>
933
934 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
935 * alloc.c (mark_buffer):
936 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
937 (clone_per_buffer_values): Don't assume that
22b4128e
PE
938 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
939 This isn't true in general, and it's particularly not true
940 if Emacs is configured with --with-wide-int.
941 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
942 New macros, used in the buffer.c change.
943
869795d6
JD
9442011-07-05 Jan Djärv <jan.h.d@swipnet.se>
945
946 * xsettings.c: Use both GConf and GSettings if both are available.
947 (store_config_changed_event): Add comment.
948 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
949 (store_tool_bar_style_changed): New functions.
950 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
951 (struct xsettings): Move font inside HAVE_XFT.
952 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
953 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
954 Move inside HAVE_XFT.
955 (something_changed_gsettingsCB): Renamed from something_changedCB.
956 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
957 also.
958 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
959 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
960 (something_changed_gconfCB): Renamed from something_changedCB.
961 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
962 (parse_settings): Move check for font inside HAVE_XFT.
963 (read_settings, apply_xft_settings): Add comment.
964 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
965 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
966 call store_font_name_changed.
967 (xft_settings_event): Add comment.
968 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
969 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
970 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
971 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
972 (xsettings_initialize): Call init_gsettings last.
973 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
974 comment.
975
d8ed26bd
PE
9762011-07-05 Paul Eggert <eggert@cs.ucla.edu>
977
978 Random fixes. E.g., (random) never returned negative values.
979 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
980 subseconds part to the entropy, as that's a bit more random.
981 Prefer signed to unsigned, since the signedness doesn't matter and
982 in general we prefer signed. When given a limit, use a
983 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
984 latter isn't right if USE_2_TAGS_FOR_INTS.
985 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
986 not 0..VALMASK. Don't discard "excess" bits that random () returns.
987
cabf1cac
SM
9882011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
989
990 * textprop.c (text_property_stickiness):
991 Obey Vtext_property_default_nonsticky.
992 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
993 * w32fns.c (syms_of_w32fns):
994 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
995
6e9b2be9
PE
9962011-07-04 Paul Eggert <eggert@cs.ucla.edu>
997
998 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
999 This is more efficient than Ffile_directory_p and avoids a minor race.
1000
90186c68
LMI
10012011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1002
7c301272
LMI
1003 * buffer.c (Foverlay_put): Say what the return value is
1004 (bug#7835).
1005
c4f2d8d4
LMI
1006 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1007 is a directory before asking whether to use the file name
1008 (bug#7564).
ad637907
LMI
1009 (barf_or_query_if_file_exists): Make the "File is a directory"
1010 error be more correct.
c4f2d8d4 1011
90186c68
LMI
1012 * fns.c (Frequire): Remove the mention of the .gz files, since
1013 that's installation-specific, but keep the mention of
1014 `get-load-suffixes'.
1015
da64016e
PE
10162011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1017
1018 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1019 Report string overflow if the output is too long.
1020
7d47b580
JB
10212011-07-04 Juanma Barranquero <lekktu@gmail.com>
1022
a555cb87
JB
1023 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1024 (syms_of_gnutls): Remove duplicate DEFSYM for
1025 Qgnutls_bootprop_verify_hostname_error, an error for
1026 Qgnutls_bootprop_verify_error (which is no longer used).
1027
7d47b580
JB
1028 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1029 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1030 Also (re)move comments that are misplaced or no longer relevant.
1031
1e49bfab
LMI
10322011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1033
1034 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1035
1485f4c0
CY
10362011-07-03 Chong Yidong <cyd@stupidchicken.com>
1037
1038 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1039 and background color parameters if they have been changed.
1040
a9ab721e
LMI
10412011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1042
1043 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1044
cf7cff57
PE
10452011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1046
2e13213d
PE
1047 * xsettings.c (SYSTEM_FONT): Define only when used.
1048 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1049
cf7cff57
PE
1050 * keymap.c (access_keymap_1): Now static.
1051
7a8e04f7
CY
10522011-07-02 Chong Yidong <cyd@stupidchicken.com>
1053
1054 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1055 leave any prefix arg for the up event (Bug#1586).
1056
61352f62
LMI
10572011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1058
69bb1ef7
LMI
1059 * lread.c (syms_of_lread): Mention single symbols defined by
1060 `defvar' or `defconst' (bug#7154).
1061
61352f62 1062 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 1063 (Frequire): Mention get-load-suffixes.
61352f62 1064
28545e04
MR
10652011-07-02 Martin Rudalics <rudalics@gmx.at>
1066
1067 * window.h (window): Remove clone_number slot.
1068 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1069 Remove.
1070 (make_parent_window, make_window, saved_window)
1071 (Fset_window_configuration, save_window_save): Don't deal with
1072 clone numbers.
1073 * buffer.c (Qclone_number): Remove declaration.
1074 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1075
3349e122
SM
10762011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1077
1078 Add multiple inheritance to keymaps.
1079 * keymap.c (Fmake_composed_keymap): New function.
1080 (Fset_keymap_parent): Simplify.
1081 (fix_submap_inheritance): Remove.
1082 (access_keymap_1): New function extracted from access_keymap to handle
1083 embedded parents and handle lists of maps.
1084 (access_keymap): Use it.
1085 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
1086 (Fcopy_keymap): Handle embedded parents.
1087 (Fcommand_remapping, define_as_prefix): Simplify.
1088 (Fkey_binding): Simplify.
1089 (syms_of_keymap): Move minibuffer-local-completion-map,
1090 minibuffer-local-filename-completion-map,
1091 minibuffer-local-must-match-map, and
1092 minibuffer-local-filename-must-match-map to Elisp.
1093 (syms_of_keymap): Defsubr make-composed-keymap.
1094 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1095 (parse_menu_item): Trivial simplification.
1096
3279eb87
GM
10972011-07-01 Glenn Morris <rgm@gnu.org>
1098
1099 * Makefile.in (SETTINGS_LIBS): Fix typo.
1100
4550efdf
KI
11012011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1102
1103 * coding.c (Fencode_coding_string): Record the last coding system
1104 used, as the function doc string says (bug#8738).
1105
0949d2b6
JD
11062011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1107
1108 * xsettings.c (store_monospaced_changed): Take new font as arg and
1109 check for change against current_mono_font.
1110 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1111 (emacs_settings_constructor, emacs_settings_get_property)
1112 (emacs_settings_set_property, emacs_settings_class_init)
1113 (emacs_settings_init, gsettings_obj): Remove.
1114 (something_changedCB): New function for HAVE_GSETTINGS.
1115 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1116 with value as argument.
1117 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1118 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 1119 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
1120 "changed".
1121
1122 * xgselect.c: Add defined (HAVE_GSETTINGS).
1123 (xgselect_initialize): Ditto.
1124
1125 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1126 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1127 xg_select.
1128
bbc6b304
PE
11292011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1130
1131 * eval.c (struct backtrace): Simplify and port the data structure.
1132 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1133 signed bit field, as this assumption is not portable and it makes
1134 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1135 "char debug_on_exit : 1" as this is not portable either; instead,
1136 use the portable "unsigned int debug_on_exit : 1". Remove unused
1137 member evalargs. Remove obsolete comments about cc bombing out.
1138
9851bfc5
JD
11392011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1140
51bb811f 1141 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
1142 Let HAVE_GSETTINGS override HAVE_GCONF.
1143 (store_monospaced_changed): New function.
1144 (EMACS_SETTINGS): A new type derived from GObject to handle
1145 GSettings notifications.
1146 (emacs_settings_constructor, emacs_settings_get_property)
1147 (emacs_settings_set_property, emacs_settings_class_init):
1148 New functions.
1149 (gsettings_client, gsettings_obj): New variables.
1150 (GSETTINGS_SCHEMA): New define.
1151 (something_changedCB): Call store_monospaced_changed.
1152 (init_gsettings): New function.
1153 (xsettings_initialize): Call init_gsettings.
1154 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1155 to NULL.
1156
1157 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
1158 GCONF_CFLAGS/LIBS.
1159
5386012d
MR
11602011-06-29 Martin Rudalics <rudalics@gmx.at>
1161
1162 * window.c (resize_root_window, grow_mini_window)
1163 (shrink_mini_window): Rename Qresize_root_window to
1164 Qwindow_resize_root_window and Qresize_root_window_vertically to
1165 Qwindow_resize_root_window_vertically.
1166
f13e0b08
PE
11672011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1168
1169 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1170
94515237
JB
11712011-06-27 Juanma Barranquero <lekktu@gmail.com>
1172
1173 * makefile.w32-in: Redesign dependencies so they reflect more
1174 clearly which files are directly included by each source file,
1175 and not through other includes.
1176
e43b6e43
MR
11772011-06-27 Martin Rudalics <rudalics@gmx.at>
1178
1179 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1180 (sort_overlays, overlay_strings): When an overlay's clone number
1181 matches the window's clone number process the overlay even if
1182 the overlay's window property doesn't match the current window.
1183
d68443dc
MR
1184 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1185 (Fwindow_hchild): Rename to Fwindow_left_child.
1186 (Fwindow_next): Rename to Fwindow_next_sibling.
1187 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
1188 (resize_window_check): Rename to window_resize_check.
1189 (resize_window_apply): Rename to window_resize_apply.
1190 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1191 (Fdelete_other_windows_internal, resize_frame_windows)
1192 (Fsplit_window_internal, Fdelete_window_internal)
1193 (grow_mini_window, shrink_mini_window)
1194 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 1195
c7e73be5
JD
11962011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1197
1198 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1199 (emacs_fixed_set_min_size): Remove.
1200 (emacs_fixed_new): Take frame as argument.
1201
1202 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1203 (_EmacsFixedPrivate): Remove minwidth/height.
1204 Add struct frame *f.
1205 (emacs_fixed_init): Initialize priv->f.
1206 (get_parent_class, emacs_fixed_set_min_size): Remove.
1207 (emacs_fixed_new): Set priv->f to argument.
1208 (emacs_fixed_get_preferred_width)
1209 (emacs_fixed_get_preferred_height): Use min_width/height from
1210 frames size_hint to set minimum and natural (Bug#8919).
1211 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1212 and use min_width/height from frames size_hint to set
1213 min_width/height (Bug#8919).
1214
1215 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
1216 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1217 Fix indentation.
c7e73be5 1218
cf99dcf8
EZ
12192011-06-26 Eli Zaretskii <eliz@gnu.org>
1220
1221 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1222 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1223 called at ZV.
1224
029529ac
CY
12252011-06-26 Chong Yidong <cyd@stupidchicken.com>
1226
1227 * process.c (wait_reading_process_output): Bypass select if
1228 waiting for a cell while ignoring keyboard input, and input is
1229 pending. Suggested by Jan Djärv (Bug#8869).
1230
7a7ef429
PE
12312011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1232
1233 Use gnulib's dup2 module instead of rolling our own.
1234 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1235
11fdef7d 12362011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
1237
1238 * dispnew.c (scrolling_window): Before scrolling, turn off a
1239 mouse-highlight in the window being scrolled.
1240
cd3520a4
JB
12412011-06-24 Juanma Barranquero <lekktu@gmail.com>
1242
1243 Move DEFSYM to lisp.h and use everywhere.
1244
1245 * character.h (DEFSYM): Move declaration...
1246 * lisp.h (DEFSYM): ...here.
1247
1248 * gnutls.c:
1249 * minibuf.c:
1250 * w32menu.c:
1251 * w32proc.c:
1252 * w32select.c: Don't include character.h.
1253
1254 * alloc.c (syms_of_alloc):
1255 * buffer.c (syms_of_buffer):
1256 * bytecode.c (syms_of_bytecode):
1257 * callint.c (syms_of_callint):
1258 * casefiddle.c (syms_of_casefiddle):
1259 * casetab.c (init_casetab_once):
1260 * category.c (init_category_once, syms_of_category):
1261 * ccl.c (syms_of_ccl):
1262 * cmds.c (syms_of_cmds):
1263 * composite.c (syms_of_composite):
1264 * dbusbind.c (syms_of_dbusbind):
1265 * dired.c (syms_of_dired):
1266 * dispnew.c (syms_of_display):
1267 * doc.c (syms_of_doc):
1268 * editfns.c (syms_of_editfns):
1269 * emacs.c (syms_of_emacs):
1270 * eval.c (syms_of_eval):
1271 * fileio.c (syms_of_fileio):
1272 * fns.c (syms_of_fns):
1273 * frame.c (syms_of_frame):
1274 * fringe.c (syms_of_fringe):
1275 * insdel.c (syms_of_insdel):
1276 * keymap.c (syms_of_keymap):
1277 * lread.c (init_obarray, syms_of_lread):
1278 * macros.c (syms_of_macros):
1279 * msdos.c (syms_of_msdos):
1280 * print.c (syms_of_print):
1281 * process.c (syms_of_process):
1282 * search.c (syms_of_search):
1283 * sound.c (syms_of_sound):
1284 * syntax.c (init_syntax_once, syms_of_syntax):
1285 * terminal.c (syms_of_terminal):
1286 * textprop.c (syms_of_textprop):
1287 * undo.c (syms_of_undo):
1288 * w32.c (globals_of_w32):
1289 * window.c (syms_of_window):
1290 * xdisp.c (syms_of_xdisp):
1291 * xfaces.c (syms_of_xfaces):
1292 * xfns.c (syms_of_xfns):
1293 * xmenu.c (syms_of_xmenu):
1294 * xsettings.c (syms_of_xsettings):
1295 * xterm.c (syms_of_xterm): Use DEFSYM.
1296
4228cf16
TZ
12972011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1298
cd3520a4 1299 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 1300
7fcccf1e
PE
13012011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1302
7efb4e0e
PE
1303 Integer and buffer overflow fixes (Bug#8873).
1304
ff5844ad
PE
1305 * print.c (printchar, strout): Check for string overflow.
1306 (PRINTPREPARE, printchar, strout):
1307 Don't set size unless allocation succeeds.
1308
90532f02
PE
1309 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1310 for sizes. Check for string overflow more accurately.
1311 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1312
6d84508d
PE
1313 * macros.c: Integer and buffer overflow fixes.
1314 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1315 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1316 Use ptrdiff_t, not int, for sizes.
1317 Don't increment bufsize until after realloc succeeds.
1318 Check for size-calculation overflow.
1319 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1320
437b2cb4
PE
1321 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1322
8b9ac8b4
PE
1323 * lread.c: Integer overflow fixes.
1324 (read_integer): Radix is now EMACS_INT, not int,
1325 to improve quality of diagnostics for out-of-range radices.
1326 Calculate buffer size correctly for out-of-range radices.
1327 (read1): Check for integer overflow in radices, and in
1328 read-circle numbers.
82cb60d3
PE
1329 (read_escape): Avoid int overflow.
1330 (Fload, openp, read_buffer_size, read1)
1331 (substitute_object_recurse, read_vector, read_list, map_obarray):
1332 Use ptrdiff_t, not int, for sizes.
1333 (read1): Use EMACS_INT, not int, for sizes.
20270765 1334 Check for size overflow.
8b9ac8b4 1335
7fcccf1e
PE
1336 * image.c (cache_image): Check for size arithmetic overflow.
1337
bfbbd7e7
PE
1338 * lread.c: Integer overflow issues.
1339 (saved_doc_string_size, saved_doc_string_length)
1340 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1341 Now ptrdiff_t, not int.
1342 (read1): Don't assume doc string length fits in int. Check for
1343 out-of-range doc string lengths.
1344 (read_list): Don't assume file position fits in int.
39019e54 1345 (read_escape): Check for hex character overflow.
bfbbd7e7 1346
4e323265
LL
13472011-06-22 Leo Liu <sdl.web@gmail.com>
1348
1349 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1350 Move to minibuffer.el.
1351
85fece3e
PE
13522011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1353
20b84ce9 1354 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
1355 The following patches are for when GLYPH_DEBUG && !XASSERT.
1356 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1357 * dispnew.c (flush_stdout):
1358 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1359 Mark as externally visible.
1360 * dispnew.c (check_window_matrix_pointers): Now static.
1361 * dispnew.c (window_to_frame_vpos):
1362 * xfns.c (unwind_create_frame):
1363 * xterm.c (x_check_font): Remove unused local.
1364 * scroll.c (CHECK_BOUNDS):
1365 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1366 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1367 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1368 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1369 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1370 Now static.
1371 (debug_method_add): Use va_list and vsprintf rather than relying
1372 on undefined behavior with wrong number of arguments.
1373 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1374 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1375 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1376 since we're not interested in debugging glyphs with old libraries.
1377 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1378 GCC 4.6.0's static checking.
1379
0766b489
PE
13802011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1381
31fd4b32
PE
1382 Integer overflow and signedness fixes (Bug#8873).
1383 A few related buffer overrun fixes, too.
1384
b79e8648
PE
1385 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1386
0766b489
PE
1387 * dispextern.h (struct face.stipple):
1388 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1389 (x_bitmap_mask, x_allocate_bitmap_record)
1390 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1391 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1392 (x_create_bitmap_from_xpm_data):
1393 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1394 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1395 (.bitmaps_last):
1396 * xfaces.c (load_pixmap):
1397 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1398 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1399 (.bitmaps_last, struct x_output.icon_bitmap):
1400 Use ptrdiff_t, not int, for bitmap indexes.
1401 (x_allocate_bitmap_record): Check for size overflow.
1402 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1403
b081724f
PE
1404 Use ptrdiff_t, not int, for overlay counts.
1405 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1406 * editfns.c (overlays_around, get_pos_property):
1407 * textprop.c (get_char_property_and_overlay):
1408 * xdisp.c (next_overlay_change, note_mouse_highlight):
1409 * xfaces.c (face_at_buffer_position):
21514da7
PE
1410 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1411 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1412 (Fnext_overlay_change, Fprevious_overlay_change)
1413 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 1414 Use ptrdiff_t, not int, for sizes.
21514da7 1415 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 1416
3de73e5e
PE
1417 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1418
2606c57b
PE
1419 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1420 (x_session_initialize): Do not assume string length fits in int.
1421
aaafe47a
PE
1422 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1423 This is unlikely, but can occur if DPI is outlandish.
1424
2674ddc8 1425 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
1426 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1427
28154962
PE
1428 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1429 * xrdb.c (magic_file_p, search_magic_path):
1430 Omit last arg SUFFIX; it was always 0. All callers changed.
1431 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1432
7de51af5
PE
1433 * xfont.c (xfont_match): Avoid need for strlen.
1434
25ed6cc3
PE
1435 * xfns.c: Don't assume strlen fits in int.
1436 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1437
4eab31dd
PE
1438 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1439 not unsigned long, as we prefer signed integers. All callers changed.
1440 Detect integer overflow in repeat count.
1441 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 1442 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 1443
171e2a58
PE
1444 * termcap.c: Don't assume sizes fit in int and never overflow.
1445 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1446 (gobble_line): Check for size-calculation overflow.
1447
ad39faca 1448 * minibuf.c (Fread_buffer):
6e5bb2dc 1449 * lread.c (intern, intern_c_string):
74ca2eb3
PE
1450 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1451 Don't assume string length fits in int.
1452
52c61c22 1453 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
1454 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1455
b5b8c9e5
PE
1456 * font.c: Don't assume string length fits in int.
1457 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1458 Use ptrdiff_t, not int.
ccd6111c
PE
1459 (font_intern_prop): Don't assume string length fits in int.
1460 Don't assume integer property fits in fixnum.
1461 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 1462
882f0d81 1463 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 1464 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
1465 Reformulate so as not to need the command string.
1466 Invoke gzip -cd rather than gunzip, as it's more portable.
1467 (lock_info_type, lock_file_1, lock_file):
1468 Don't assume pid_t and time_t fit in unsigned long.
1469 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1470 (current_lock_owner): Prefer signed type for sizes.
1471 Use memcpy, not strncpy, where memcpy is what is really wanted.
1472 Don't assume (via atoi) that time_t and pid_t fit in int.
1473 Check for time_t and/or pid_t out of range, e.g., via a network share.
1474 Don't alloca where an auto var works fine.
1475
93f4cf88
PE
1476 * fileio.c: Fix some integer overflow issues.
1477 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1478 Don't assume string length fits in int.
1479 (directory_file_name): Don't assume string length fits in long.
1480 (make_temp_name): Don't assume pid fits in int, or that its print
1481 length is less than 20.
1482
f3e92b69
PE
1483 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1484
1bfdaf10
PE
1485 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1486
35016e9a
PE
1487 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1488
3d1e65a1
PE
1489 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1490 We prefer signed integers, even for size calculations.
1491
0b963a93
PE
1492 * emacs.c: Don't assume string length fits in 'int'.
1493 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1494 (main): Don't invoke strlen when not needed.
1495
573f4b54
PE
1496 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1497 (XD_DEBUG_MESSAGE): Don't waste a byte.
1498
989f33ba
PE
1499 * callproc.c (getenv_internal_1, getenv_internal)
1500 (Fgetenv_internal):
965d34eb
PE
1501 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1502
e4d29b33
PE
1503 * lread.c (invalid_syntax): Omit length argument.
1504 All uses changed. This doesn't fix a bug, but it simplifies the
1505 code away from its former Hollerith-constant appearance, and it's
1506 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 1507 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 1508
eb49b136
PE
1509 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1510 This didn't break anything, but it didn't help either.
1511 It's confusing to put a bogus integer in a place where the actual
1512 value does not matter.
9f62aeb1 1513 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 1514 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 1515
15375a22
PE
1516 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1517 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1518 implementation.
b61cc01c
PE
1519 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1520 We prefer signed types, and the value cannot exceed the EMACS_INT
1521 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
1522 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1523 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1524 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 1525
53b2623d
PE
1526 * indent.c (sane_tab_width): New function.
1527 (current_column, scan_for_column, Findent_to, position_indentation)
1528 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 1529 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 1530
51cab52b 1531 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 1532
f2ed8a70
PE
1533 * lisp.h (lint_assume): New macro.
1534 * composite.c (composition_gstring_put_cache):
1535 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1536
abe80cc6
PE
1537 * editfns.c, insdel.c:
1538 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 1539
b02c740e
PE
1540 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1541
ebc96716
PE
1542 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1543
b4e50fa0 1544 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 1545 Use much-faster test for byte-length change.
311d5d7c 1546 Don't assume string byte-length fits in 'int'.
a4cf38e4 1547 Check that character arg fits in 'int'.
85461888 1548 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 1549
c0c1ee9f
PE
1550 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1551
a498d7f4
PE
1552 * fns.c (concat): Catch string overflow earlier.
1553 Do not rely on integer wraparound.
1554
51cab52b
PE
1555 * dispextern.h (struct it.overlay_strings_charpos)
1556 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
1557 * xdisp.c (forward_to_next_line_start)
1558 (back_to_previous_visible_line_start)
1559 (reseat_at_next_visible_line_start, next_element_from_buffer):
1560 Don't arbitrarily truncate the value of 'selective' to int.
1561
76031fad
PE
1562 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1563
5eb55db9
PE
1564 * composite.c: Don't truncate sizes to 'int'.
1565 (composition_gstring_p, composition_reseat_it)
1566 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
1567 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1568 not EMACS_UINT, for indexes.
5eb55db9 1569
0703a717
PE
1570 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1571
d6202519
PE
1572 * buffer.c: Include <verify.h>.
1573 (struct sortvec.priority, struct sortstr.priority):
8961a454 1574 Now EMACS_INT, not int.
c20998a7 1575 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
1576 (struct sortstr.size, record_overlay_string)
1577 (struct sortstrlist.size, struct sortlist.used):
1578 Don't truncate size to int.
1579 (record_overlay_string): Check for size-calculation overflow.
d6202519 1580 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 1581
d5a19415
JM
15822011-06-22 Jim Meyering <meyering@redhat.com>
1583
029529ac 1584 Don't leak an XBM-image-sized buffer
d5a19415
JM
1585 * image.c (xbm_load): Free the image buffer after using it.
1586
a9041e6c
PE
15872011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1588
1589 Port to Sun C.
1590 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1591 that Sun C diagnosed.
1592 * fns.c (secure_hash): Fix pointer signedness issue.
1593 * intervals.c (static_offset_intervals): New function.
1594 (offset_intervals): Use it.
1595
7f3f739f
LL
15962011-06-21 Leo Liu <sdl.web@gmail.com>
1597
1598 * deps.mk (fns.o):
1599 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1600 sha512.h.
1601
1602 * fns.c (secure_hash): Rename from crypto_hash_function and change
1603 the first arg to accept symbols.
5b66d427 1604 (Fsecure_hash): New primitive.
7f3f739f
LL
1605 (syms_of_fns): New symbols.
1606
76147d94
DD
16072011-06-20 Deniz Dogan <deniz@dogan.se>
1608
1609 * process.c (Fset_process_buffer): Clarify return value in
1610 docstring.
1611
7d7d0045
CY
16122011-06-18 Chong Yidong <cyd@stupidchicken.com>
1613
1614 * dispnew.c (add_window_display_history): Use BVAR.
1615
1616 * xdisp.c (debug_method_add): Use BVAR.
1617 (check_window_end, dump_glyph_matrix, dump_glyph)
1618 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1619
1620 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1621 Likewise.
1622
1623 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1624 check till after the cache is created in init_frame_faces.
1625
ff2bc410
SM
16262011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1627
1628 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1629
28177add
PE
16302011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1631
dd3482fe
PE
1632 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1633 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1634 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1635
393d71f3 1636 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
1637 * fileio.c (Finsert_file_contents):
1638 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1639 Remove the old (too-loose) buffer overflow checks.
1640 They weren't needed, since make_gap checks for buffer overflow.
1641 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1642 The old code merely checked for Emacs fixnum overflow, and relied
1643 on undefined (wraparound) behavior. The new code avoids undefined
1644 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1645
2e6813b0 1646 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
1647 Tune. Don't use wider integers than needed. Don't use alloca.
1648 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 1649
599a9e4f
PE
1650 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1651
99561444
PE
1652 * insdel.c, lisp.h (buffer_overflow): New function.
1653 (insert_from_buffer_1, replace_range, replace_range_2):
1654 * insdel.c (make_gap_larger):
1655 * editfns.c (Finsert_char):
1656 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1657
28177add
PE
1658 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1659
e69dafad
PE
16602011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1661
a7af7fde 1662 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 1663
b1c46f02
PE
1664 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1665 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1666
e69dafad
PE
1667 * fileio.c: Don't assume EMACS_INT fits in off_t.
1668 (emacs_lseek): New static function.
1669 (Finsert_file_contents, Fwrite_region): Use it.
1670 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1671
566684ea
PE
1672 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1673
e6966cd6
PE
1674 * fns.c: Don't overflow int when computing a list length.
1675 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1676 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1677 truncation on 64-bit hosts. Check for QUIT every
1678 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1679 faster and is responsive enough.
1680 (Flength): Report an error instead of overflowing an integer.
1681 (Fsafe_length): Return a float if the value is not representable
1682 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 1683 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 1684 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 1685
dd0b0efb
PE
1686 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1687 (header_size, word_size): New constants.
1688 (allocate_vectorlike): Don't check size overflow here.
1689 (allocate_vector): Check it here instead, since this is the only
1690 caller of allocate_vectorlike that could cause overflow.
1691 Check that the new vector's length is representable as a fixnum.
1692
86fe5cfe
PE
1693 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1694 The previous code was bogus. For example, next_almost_prime (32)
1695 returned 39, which is undesirable as it is a multiple of 3; and
1696 next_almost_prime (24) returned 25, which is a multiple of 5 so
1697 why was the code bothering to check for multiples of 7?
1698
80e88859
PE
1699 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1700
4a2f0ad6
PE
1701 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1702
f66c7cf8
PE
1703 Variadic C functions now count arguments with ptrdiff_t.
1704 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1705 Back then I didn't know that the Emacs coding style prefers signed int.
1706 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
1707 were being counted with int, which may truncate counts on 64-bit
1708 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
1709 * lisp.h (struct Lisp_Subr.function.aMANY)
1710 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1711 Arg counts are now ptrdiff_t, not size_t.
1712 All variadic functions and their callers changed accordingly.
1713 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1714 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1715 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1716 * callint.c (Fcall_interactively): Check arg count for overflow,
1717 to avoid potential buffer overrun. Use signed char, not 'int',
1718 for 'varies' array, so that we needn't bother to check its size
1719 calculation for overflow.
1720 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1721 * eval.c (apply_lambda):
1722 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1723 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1724 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1725
a1759b76
PE
1726 * callint.c (Fcall_interactively): Don't use index var as event count.
1727
d96be9fc
PE
1728 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1729 * mem-limits.h (SIZE): Remove; no longer used.
1730
a690a978 1731 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 1732
578c21e6
PE
1733 Remove unnecessary casts.
1734 * xterm.c (x_term_init):
1735 * xfns.c (x_set_border_pixel):
1736 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1737 These aren't needed now that we assume ANSI C.
1738
96f53c6c
PE
1739 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1740 It's more likely to cause problems (due to unsigned overflow)
1741 than to cure them.
1742
83c77d31
PE
1743 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1744
ee2079f1
PE
1745 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1746
6da65536
PE
1747 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1748
7147c4a4
PE
1749 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1750
193e32d9
PE
1751 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1752
e5533da6
PE
1753 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1754
9910e595
PE
1755 GLYPH_CODE_FACE returns EMACS_INT, not int.
1756 * dispextern.h (merge_faces):
1757 * xfaces.c (merge_faces):
01103c44
PE
1758 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1759 Don't assume EMACS_INT fits in int.
9910e595 1760
2638320e
PE
1761 * character.h (CHAR_VALID_P): Remove unused parameter.
1762 * fontset.c, lisp.h, xdisp.c: All uses changed.
1763
045eb8d9
PE
1764 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1765
c1f134b5
PE
1766 * fns.c (concat): Minor tuning based on overflow analysis.
1767 This doesn't fix any bugs. Use int to hold character, instead
1768 of constantly refetching from Emacs object. Use XFASTINT, not
1769 XINT, for value known to be a character. Don't bother comparing
1770 a single byte to 0400, as it's always less.
1771
395fcb93 1772 * floatfns.c (Fexpt):
327eeec8
PE
1773 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1774
abbd3d23
PE
1775 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1776 for characters.
1777
684a03ef
PE
1778 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1779
0fed43f3
PE
1780 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1781 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1782 incorrectly succeed when S was a string, because 4294967386 was
1783 truncated before it was used.
1784
8fd02eb7
PE
1785 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1786 Otherwise, an out-of-range integer could cause undefined behavior
1787 on a 64-bit host.
1788
f8c86b69
PE
1789 * composite.c: Use int, not EMACS_INT, for characters.
1790 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1791 EMACS_INT, for values that are known to be in character range.
1792 This doesn't fix any bugs but is the usual style inside Emacs and
1793 may generate better code on 32-bit machines.
1794
34206dd2
PE
1795 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1796 This is for reasons similar to the recent CHAR_STRING fix.
1797 * charset.c (Fencode_char): Check that character arg is actually
1798 a character. Pass an int to ENCODE_CHAR.
1799 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1800 wider than 'int', as a compile-time check to prevent future regressions
1801 in this area.
1802
c5958d4c 1803 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
1804
1805 Make sure a 64-bit char is never passed to CHAR_STRING.
1806 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1807 by silently ignoring the top 32 bits, allowing some values
1808 that were far too large to be valid characters.
1809 * character.h: Include <verify.h>.
1810 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1811 arguments are no wider than unsigned, as a compile-time check
1812 to prevent future regressions in this area.
1813 * data.c (Faset):
01103c44 1814 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
1815 (Fsubst_char_in_region):
1816 * fns.c (concat):
1817 * xdisp.c (decode_mode_spec_coding):
1818 Adjust to CHAR_STRING's new requirement.
1819 * editfns.c (Finsert_char, Fsubst_char_in_region):
1820 * fns.c (concat): Check that character args are actually
1821 characters. Without this test, these functions did the wrong
1822 thing with wildly out-of-range values on 64-bit hosts.
1823
d37ca623
PE
1824 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1825 These casts should not be needed on 32-bit hosts, either.
1826 * keyboard.c (read_char):
1827 * lread.c (Fload): Remove casts to unsigned.
1828
ea204efb
PE
1829 * lisp.h (UNSIGNED_CMP): New macro.
1830 This fixes comparison bugs on 64-bit hosts.
1831 (ASCII_CHAR_P): Use it.
1832 * casefiddle.c (casify_object):
01103c44 1833 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
1834 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1835 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1836 * dispextern.h (FACE_FROM_ID):
1837 * keyboard.c (read_char): Use UNSIGNED_CMP.
1838
41cb286c
PE
1839 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1840 not to EMACS_INT, to avoid GCC warning.
1841
4a1b9832
PE
1842 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1843
55daad71
PE
1844 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1845 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1846 isn't needed on 32-bit machines.
8f95c75c 1847
01103c44
PE
1848 * buffer.c (Fgenerate_new_buffer_name):
1849 Use EMACS_INT for count, not int.
0ceccced 1850 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
1851
1852 * data.c (Qcompiled_function): Now static.
1853
c6f072e7
PE
1854 * window.c (window_body_lines): Now static.
1855
20ce5912
PE
1856 * image.c (gif_load): Rename local to avoid shadowing.
1857
9c4c5f81
PE
1858 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1859 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1860 * alloc.c (make_save_value): Integer argument is now of type
1861 ptrdiff_t, not int.
1862 (mark_object): Use ptrdiff_t, not int.
1863 * lisp.h (pD): New macro.
1864 * print.c (print_object): Use it.
1865
c0c5c8ae
PE
1866 * alloc.c: Use EMACS_INT, not int, to count objects.
1867 (total_conses, total_markers, total_symbols, total_vector_size)
1868 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
1869 (total_free_floats, total_floats, total_free_intervals)
1870 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
1871 Now EMACS_INT, not int. All uses changed.
1872 (Fgarbage_collect): Compute overall total using a double, so that
1873 integer overflow is less likely to be a problem. Check for overflow
1874 when converting back to an integer.
5a25e253
PE
1875 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
1876 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
1877 These were 'int' variables that could overflow on 64-bit hosts;
1878 they were never used, so remove them instead of repairing them.
211a0b2a 1879 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
1880 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
1881 Previously, this ceilinged at INT_MAX, but that doesn't work on
1882 64-bit machines.
e46bb31a 1883 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 1884
c78baabf 1885 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 1886 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
1887 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
1888 when a (possibly-narrower) signed value would do just as well.
1889 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 1890
c9d624c6
PE
1891 * alloc.c: Catch some string size overflows that we were missing.
1892 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
1893 for convenience in STRING_BYTES_MAX.
1894 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
1895 The definition here is exact; the one in lisp.h was approximate.
1896 (allocate_string_data): Check for string overflow. This catches
1897 some instances we weren't catching before. Also, it catches
1898 size_t overflow on (unusual) hosts where SIZE_MAX <= min
1899 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
1900 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 1901
c9d624c6
PE
1902 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
1903 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
1904 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
1905
353032ce
PE
1906 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
1907
2bccce07
PE
1908 * alloc.c (Fmake_string): Check for out-of-range init.
1909
0ac30604
SM
19102011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
1911
1912 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
1913
c195f2de
JD
19142011-06-14 Jan Djärv <jan.h.d@swipnet.se>
1915
1916 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
1917 xg_get_default_scrollbar_width.
1918
1919 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
1920 (int_gtk_range_get_value): Move to the scroll bar part of the file.
1921 (style_changed_cb): Call update_theme_scrollbar_width and call
1922 x_set_scroll_bar_default_width and xg_frame_set_char_size for
1923 all frames (Bug#8505).
1924 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
1925 Call gtk_window_set_resizable if HAVE_GTK3.
1926 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
1927 and height if HAVE_GTK3 (Bug#8505).
1928 (scroll_bar_width_for_theme): New variable.
1929 (update_theme_scrollbar_width): New function.
1930 (xg_get_default_scrollbar_width): Move code to
1931 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
1932 (xg_initialize): Call update_theme_scrollbar_width.
1933
1934 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
1935
1936 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
1937
e10ac9f1
MR
19382011-06-12 Martin Rudalics <rudalics@gmx.at>
1939
1940 * frame.c (make_frame): Call other_buffer_safely instead of
1941 other_buffer.
1942
1943 * window.c (temp_output_buffer_show): Call display_buffer with
1944 second argument Vtemp_buffer_show_specifiers and reset latter
1945 immediately after the call.
1946 (Vtemp_buffer_show_specifiers): New variable.
1947 (auto_window_vscroll_p, next_screen_context_lines)
1948 (Vscroll_preserve_screen_position): Remove leading asterisks from
1949 doc-strings.
1950
2d3c217e 19512011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 1952
7b7f97e8 1953 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
1954 * buffer.c (Qclone_number): Remove for now, as it's unused.
1955 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
1956 (record_buffer): Remove unused local.
1957 * frame.c (other_visible_frames, frame_buffer_list): Now static.
1958 (set_frame_buffer_list): Remove; unused.
1959 * frame.h (other_visible_frames): Remove decl.
1960 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
1961 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
1962 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
1963 if HAVE_GPM.
1964 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
1965 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
1966 Define only if HAVE_GPM.
1967 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
1968 (update_hints_inhibit): Remove; never set. All uses removed.
1969 * widgetprv.h (emacsFrameClassRec): Remove decl.
1970 * window.c (delete_deletable_window): Now returns void, since it
1971 wasn't returning anything.
1972 (compare_window_configurations): Remove unused locals.
1973 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
1974 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
1975 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
1976 the same widths as pointers. This follows up on the 2011-05-06 patch.
1977 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
1978 * xterm.h: Likewise.
1979 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
1980
1384b89e
JB
19812011-06-12 Juanma Barranquero <lekktu@gmail.com>
1982
1983 * makefile.w32-in: Update dependencies.
1984 (LISP_H): Add lib/intprops.h.
1985
1100a63c
CY
19862011-06-11 Chong Yidong <cyd@stupidchicken.com>
1987
1988 * image.c (gif_load): Add animation frame delay to the metadata.
1989 (syms_of_image): Use DEFSYM. New symbol `delay'.
1990
6198ccd0
MR
19912011-06-11 Martin Rudalics <rudalics@gmx.at>
1992
1993 * window.c (delete_deletable_window): Re-add.
1994 (Fset_window_configuration): Rewrite to handle dead buffers and
1995 consequently deletable windows.
1996 (window_tree, Fwindow_tree): Remove. Supply functionality in
1997 window.el.
1998 (compare_window_configurations): Simplify code.
1999
b6e3633c
AS
20002011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2001
1ab0dee5
AS
2002 * image.c (imagemagick_load_image): Fix type mismatch.
2003 (Fimagemagick_types): Likewise.
2004
b6e3633c
AS
2005 * window.h (replace_buffer_in_windows): Declare.
2006
9397e56f
MR
20072011-06-11 Martin Rudalics <rudalics@gmx.at>
2008
2009 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2010 Qclone_number. Remove external declaration of Qdelete_window.
2011 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2012 code.
2013 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
2014 Qbuffer_list_update_hook if allowed.
2015 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2016 buffer list implementation.
2017 (other_buffer_safely): New function.
2018 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2019 calls to replace_buffer_in_windows and
2020 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2021 if allowed.
2022 (record_buffer): Inhibit quitting and rewrite using quittable
2023 functions. Run Qbuffer_list_update_hook if allowed.
2024 (Frecord_buffer, Funrecord_buffer): New functions.
2025 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
2026 switch-to-buffer to window.el.
2027 (bury-buffer): Move to window.el.
2028 (Vbuffer_list_update_hook): New variable.
2029
2030 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2031 section.
2032
2033 * window.h (resize_frame_windows): Move up in code.
2034 (Fwindow_frame): Remove EXFUN.
2035 (replace_buffer_in_all_windows): Remove prototype.
2036 (replace_buffer_in_windows_safely): Add prototype.
2037
2038 * window.c: Declare Qdelete_window static again. Move down
2039 declaration of select_count.
2040 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2041 (Fother_window): Move to window.el.
2042 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2043 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2044 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2045 window.el.
2046 (replace_buffer_in_windows): Implement by calling
2047 Qreplace_buffer_in_windows.
2048 (replace_buffer_in_all_windows): Remove with some functionality
2049 moved into replace_buffer_in_windows_safely.
2050 (replace_buffer_in_windows_safely): New function.
2051 (select_window_norecord, select_frame_norecord): Move in front
2052 of run_window_configuration_change_hook. Remove now obsolete
2053 declarations.
2054 (Fset_window_buffer): Rewrite doc-string. Call
2055 Qrecord_window_buffer.
2056 (keys_of_window): Move binding for other-window to window.el.
2057
b50691aa
CY
20582011-06-11 Chong Yidong <cyd@stupidchicken.com>
2059
2060 * dispextern.h (struct image): Replace data member, whose int_val
2061 and ptr_val fields were not used by anything, with a single
2062 lisp_val object.
2063
2064 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2065 (gif_clear_image, gif_load, imagemagick_load_image)
2066 (gs_clear_image, gs_load): Callers changed.
2067
3f754b86
PE
20682011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2069
cca69397
PE
2070 * buffer.h: Include <time.h>, for time_t.
2071 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2072
109e28d0
PE
2073 Fix minor problems found by static checking.
2074
60737f02
PE
2075 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2076
4b66faf3
PE
2077 Make identifiers static if they are not used in other modules.
2078 * data.c (Qcompiled_function, Qframe, Qvector):
2079 * image.c (QimageMagick, Qsvg):
2080 * minibuf.c (Qmetadata):
2081 * window.c (resize_window_check, resize_root_window): Now static.
2082 * window.h (resize_window_check, resize_root_window): Remove decls.
2083
109e28d0
PE
2084 * window.c (window_deletion_count, delete_deletable_window):
2085 Remove; unused.
46a4ce9e
PE
2086 (window_body_lines): Now static.
2087 (Fdelete_other_windows_internal): Mark vars as initialized.
2088 Make sure 'resize_failed' is initialized.
2089 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2090 (resize_window_apply): Remove unused local.
2091 * window.h (delete_deletable_window): Remove decl.
2092
109e28d0 2093 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
2094 (imagemagick_load_image): Fix pointer signedness problem by changing
2095 last arg from unsigned char * to char *. All uses changed.
2096 Also, fix a local for similar reasons.
2097 Remove unused locals. Remove locals to avoid shadowing.
2098 (fn_rsvg_handle_free): Remove; unused.
2099 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 2100 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 2101
3f754b86
PE
2102 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2103
2547adb1
CY
21042011-06-10 Chong Yidong <cyd@stupidchicken.com>
2105
2106 * image.c (gif_load): Fix omitted cast error introduced by
2107 2011-06-06 change.
2108
2c8e37d4
MR
21092011-06-10 Martin Rudalics <rudalics@gmx.at>
2110
2111 * window.h (resize_proportionally, orig_total_lines)
2112 (orig_top_line): Remove from window structure.
2113 (set_window_height, set_window_width, change_window_heights)
2114 (Fdelete_window): Remove prototypes.
2115 (resize_frame_windows): Remove duplicate declaration.
2116
440a42e3
EZ
21172011-06-10 Eli Zaretskii <eliz@gnu.org>
2118
2119 * window.h (resize_frame_windows, resize_window_check)
2120 (delete_deletable_window, resize_root_window)
2121 (resize_frame_windows): Declare prototypes.
2122
2123 * window.c (resize_window_apply): Make definition be "static" to
2124 match the prototype.
2125
562dd5e9
MR
21262011-06-10 Martin Rudalics <rudalics@gmx.at>
2127
2128 * window.c: Remove declarations of Qwindow_size_fixed,
2129 window_min_size_1, window_min_size_2, window_min_size,
2130 size_window, window_fixed_size_p, enlarge_window, delete_window.
2131 Remove static from declaration of Qdelete_window, it's
2132 temporarily needed by Fbury_buffer.
2133 (replace_window): Don't assign orig_top_line and
2134 orig_total_lines.
2135 (Fdelete_window, delete_window): Remove. Window deletion is
2136 handled by window.el.
2137 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
2138 Fdelete_window calls with calls to Qdelete_window.
2139 (Fdelete_other_windows): Remove. Deleting other windows is
2140 handled by window.el.
2141 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2142 handled in window.el.
2143 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2144 Window minimum sizes are handled in window.el.
2145 (shrink_windows, size_window, set_window_height)
2146 (set_window_width, change_window_heights, window_height)
2147 (window_width, CURBEG, CURSIZE, enlarge_window)
2148 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2149 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2150 handled in window.el.
2151 (make_dummy_parent): Rename to make_parent_window and give it a
2152 second argument horflag.
2153 (make_window): Don't set resize_proportionally any more.
2154 (Fsplit_window): Remove. Windows are split in window.el.
2155 (save_restore_action, save_restore_orig_size)
2156 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2157 Resize mini windows in window.el.
2158 (grow_mini_window, shrink_mini_window): Implement by calling
2159 Qresize_root_window_vertically, resize_window_check and
2160 resize_window_apply.
2161 (saved_window, Fset_window_configuration, save_window_save): Do
2162 not handle orig_top_line, orig_total_lines, and
2163 resize_proportionally.
2164 (window_min_height, window_min_width): Move to window.el.
2165 (keys_of_window): Move bindings for delete-other-windows,
2166 split-window, delete-window and enlarge-window to window.el.
2167
2168 * buffer.c: Temporarily extern Qdelete_window.
2169 (Fbury_buffer): Temporarily call Qdelete_window instead of
2170 Fdelete_window (Fbury_buffer will move to window.el soon).
2171
2172 * frame.c (set_menu_bar_lines_1): Remove code handling
2173 orig_top_line and orig_total_lines.
2174
2175 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2176 set_window_height but set heights directly.
2177 (change_frame_size_1): Use resize_frame_windows.
2178
2179 * xdisp.c (init_xdisp): Don't use set_window_height but set
2180 heights directly.
2181
2182 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
2183 resize_frame_windows instead of change_window_heights and run
2184 run_window_configuration_change_hook.
2185
2186 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2187 instead of change_window_heights and run
2188 run_window_configuration_change_hook.
2189
1a13852e
MR
21902011-06-09 Martin Rudalics <rudalics@gmx.at>
2191
2192 * window.c (replace_window): Rename second argument REPLACEMENT to
2193 NEW. New third argument SETFLAG. Rewrite.
2194 (delete_window, make_dummy_parent): Call replace_window with
2195 third argument 1.
2196 (window_list_1): Move down in code.
2197 (run_window_configuration_change_hook): Move set_buffer part
2198 before select_frame_norecord part in order to unwind correctly.
2199 Rename count1 to count.
2200 (recombine_windows, delete_deletable_window, resize_root_window)
2201 (Fdelete_other_windows_internal)
2202 (Frun_window_configuration_change_hook, make_parent_window)
2203 (resize_window_check, resize_window_apply, Fresize_window_apply)
2204 (resize_frame_windows, Fsplit_window_internal)
2205 (Fdelete_window_internal, Fresize_mini_window_internal): New
2206 functions.
2207 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2208
f3d1777e
MR
22092011-06-08 Martin Rudalics <rudalics@gmx.at>
2210
496e208e
MR
2211 * window.h (window): Add some new members to window structure -
2212 normal_lines, normal_cols, new_total, new_normal, clone_number,
2213 splits, nest, prev_buffers, next_buffers.
2214 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 2215 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 2216
f3d1777e
MR
2217 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2218 Remove.
496e208e
MR
2219 (make_dummy_parent): Set new members of windows structure.
2220 (make_window): Move down in code. Handle new members of window
2221 structure.
2222 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2223 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2224 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2225 (Fset_window_prev_buffers, Fwindow_next_buffers)
2226 (Fset_window_next_buffers, Fset_window_clone_number): New
2227 functions.
2228 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2229 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2230 Doc-string fixes.
2231 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2232 Argument WINDOW can be now internal window too.
2233 (Fwindow_use_time): Move up in code.
2234 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2235 Rewrite doc-string.
2236 (Fset_window_configuration, saved_window)
2237 (Fcurrent_window_configuration, save_window_save): Handle new
2238 members of window structure.
b9e809c2
MR
2239 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2240 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2241 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2242 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2243 Qget_mru_window, Qresize_root_window,
2244 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2245 Qauto_buffer_name; staticpro them.
f3d1777e 2246
abde8f8c
MR
22472011-06-07 Martin Rudalics <rudalics@gmx.at>
2248
2249 * window.c (Fwindow_total_size, Fwindow_left_column)
2250 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2251 (Fwindow_list_1): New functions.
2252 (window_box_text_cols): Replace with window_body_cols.
2253 (Fwindow_width, Fscroll_left, Fscroll_right): Use
2254 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
2255 (delete_window, Fset_window_configuration): Call
2256 delete_all_subwindows with window as argument.
2257 (delete_all_subwindows): Take a window as argument and not a
2258 structure. Rewrite.
190b47e6
MR
2259 (window_loop): Remove handling of GET_LRU_WINDOW and
2260 GET_LARGEST_WINDOW.
2261 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
2262
2263 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
2264 window_box_text_cols. delete_all_subwindows now takes a
2265 Lisp_Object as argument.
abde8f8c
MR
2266
2267 * indent.c (compute_motion, Fcompute_motion): Use
2268 window_body_cols instead of window_box_text_cols.
2269
fa8a67e6
MR
2270 * frame.c (delete_frame): Call delete_all_subwindows with root
2271 window as argument.
2272
a54e3482
DC
22732011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2274
2275 * fns.c (Fputhash): Document return value.
2276
60002bf5
CY
22772011-06-06 Chong Yidong <cyd@stupidchicken.com>
2278
2279 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2280
0c671da6 22812011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 2282
b862a52a 2283 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 2284
be44ca6c
PE
2285 Check for overflow when converting integer to cons and back.
2286 * charset.c (Fdefine_charset_internal, Fdecode_char):
2287 Use cons_to_unsigned to catch overflow.
2288 (Fencode_char): Use INTEGER_TO_CONS.
2289 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2290 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2291 * data.c (long_to_cons, cons_to_long): Remove.
2292 (cons_to_unsigned, cons_to_signed): New functions.
2293 These signal an error for invalid or out-of-range values.
2294 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2295 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2296 * font.c (Ffont_variation_glyphs):
2297 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2298 * lisp.h: Include <intprops.h>.
2299 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2300 (cons_to_signed, cons_to_unsigned): New decls.
2301 (long_to_cons, cons_to_long): Remove decls.
2302 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2303 (Fprimitive_undo): Use CONS_TO_INTEGER.
2304 * xfns.c (Fx_window_property): Likewise.
2305 * xselect.c: Include <limits.h>.
2306 (x_own_selection, selection_data_to_lisp_data):
2307 Use INTEGER_TO_CONS.
2308 (x_handle_selection_request, x_handle_selection_clear)
2309 (x_get_foreign_selection, Fx_disown_selection_internal)
2310 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2311 (lisp_data_to_selection_data): Use cons_to_unsigned.
2312 (x_fill_property_data): Use cons_to_signed.
2313 Report values out of range.
2314
d1f3d2af
PE
2315 Check for buffer and string overflow more precisely.
2316 * buffer.h (BUF_BYTES_MAX): New macro.
2317 * lisp.h (STRING_BYTES_MAX): New macro.
2318 * alloc.c (Fmake_string):
2319 * character.c (string_escape_byte8):
2320 * coding.c (coding_alloc_by_realloc):
2321 * doprnt.c (doprnt):
2322 * editfns.c (Fformat):
2323 * eval.c (verror):
2324 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2325 since they may not be the same number.
2326 * editfns.c (Finsert_char):
2327 * fileio.c (Finsert_file_contents):
2328 Likewise for BUF_BYTES_MAX.
2329
dd52fcea
PE
2330 * image.c: Use ptrdiff_t, not int, for sizes.
2331 (slurp_file): Switch from int to ptrdiff_t.
2332 All uses changed.
2333 (slurp_file): Check that file size fits in both size_t (for
2334 malloc) and ptrdiff_t (for sanity and safety).
2335
7f9bbdbb
PE
2336 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2337 if b->modtime has its maximal value.
2338
dfe18f82
PE
2339 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2340
84acfcf0
PE
2341 Don't assume time_t can fit into int.
2342 * buffer.h (struct buffer.modtime): Now time_t, not int.
2343 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2344 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2345
ccd9a01a
PE
2346 Minor fixes for signed vs unsigned integers.
2347 * character.h (MAYBE_UNIFY_CHAR):
2348 * charset.c (maybe_unify_char):
2349 * keyboard.c (read_char, reorder_modifiers):
2350 XINT -> XFASTINT, since the integer must be nonnegative.
2351 * ftfont.c (ftfont_spec_pattern):
2352 * keymap.c (access_keymap, silly_event_symbol_error):
2353 XUINT -> XFASTINT, since the integer must be nonnegative.
2354 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2355 since it makes no difference and we prefer signed.
2356 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2357 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2358 nonnegative.
2359
d6d100dd
SM
23602011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2361
2362 * window.h (Fwindow_frame): Declare.
2363
2b6148e4
PE
23642011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2365
2366 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2367 (SPARE_MEMORY): Always define.
2368 (LARGE_REQUEST): Remove.
2369 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2370
f230ecc9
MR
23712011-06-06 Martin Rudalics <rudalics@gmx.at>
2372
727e958e
MR
2373 * lisp.h: Move EXFUNS for Fframe_root_window,
2374 Fframe_first_window and Fset_frame_selected_window to window.h.
2375
2376 * window.h: Move EXFUNS for Fframe_root_window,
2377 Fframe_first_window and Fset_frame_selected_window here from
2378 lisp.h.
2379
2380 * frame.c (Fwindow_frame, Fframe_first_window)
2381 (Fframe_root_window, Fframe_selected_window)
2382 (Fset_frame_selected_window): Move to window.c.
2383 (Factive_minibuffer_window): Move to minibuf.c.
2384 (Fother_visible_frames_p): New function.
2385
2386 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2387
f230ecc9
MR
2388 * window.c (decode_window, decode_any_window): Move up in code.
2389 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2390 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
2391 (Fwindow_buffer): Move up and rewrite doc-string.
2392 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2393 (Fwindow_prev): New functions.
727e958e
MR
2394 (Fwindow_frame): Move here from frame.c. Accept any window as
2395 argument.
2396 (Fframe_root_window, Fframe_first_window)
2397 (Fframe_selected_window): Move here from frame.c. Accept frame
2398 or arbitrary window as argument. Update doc-strings.
2399 (Fminibuffer_window): Move up in code.
2400 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
2401 (Fset_frame_selected_window): Move here from frame.c.
2402 Marginal rewrite.
727e958e
MR
2403 (Fselected_window, select_window, Fselect_window): Move up in
2404 code. Minor doc-string fixes.
f230ecc9 2405
4d09bcf6
PE
24062011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2407
2408 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2409 Do not assume that spare memory exists; that assumption is valid
2410 only if SYSTEM_MALLOC.
2411 (LARGE_REQUEST): New macro, so that the issue of large requests
2412 is separated from the issue of spare memory.
2413
810928a2
AS
24142011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2415
172418ad
AS
2416 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2417 format. (Bug#8806)
2418
43f862f7
AS
2419 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2420
810928a2
AS
2421 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2422 before statements.
2423
a059fe24
JD
24242011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2425
2426 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2427
2428 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2429
2430 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2431 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2432
989bf368
JB
24332011-06-05 Juanma Barranquero <lekktu@gmail.com>
2434
2435 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2436
4b80f674
CY
24372011-06-04 Chong Yidong <cyd@stupidchicken.com>
2438
2439 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2440 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
2441 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2442 New error handlers.
4b80f674
CY
2443 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2444 Obey Vx_select_enable_clipboard_manager. Catch errors in
2445 x_clipboard_manager_save (Bug#8779).
2446 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 2447 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 2448
99a33b77 24492011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
2450
2451 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2452
99a33b77 24532011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
2454
2455 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2456 in the current matrix if keep_current_p is non-zero.
2457
8264569d
EZ
24582011-06-04 Eli Zaretskii <eliz@gnu.org>
2459
2460 * bidi.c (bidi_level_of_next_char): Fix last change.
2461
57f97249
EZ
24622011-06-03 Eli Zaretskii <eliz@gnu.org>
2463
fec2107c 2464 Support bidi reordering of text covered by display properties.
57f97249 2465
fec2107c
EZ
2466 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2467 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2468 (bidi_cache_search, bidi_cache_iterator_state)
2469 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
2470 (bidi_level_of_next_char, bidi_move_to_visually_next):
2471 Support character positions inside a run of characters covered by a
fec2107c
EZ
2472 display string.
2473 (bidi_paragraph_init, bidi_resolve_explicit_1)
2474 (bidi_level_of_next_char): Call bidi_fetch_char and
2475 bidi_fetch_char_advance instead of FETCH_CHAR and
2476 FETCH_CHAR_ADVANCE.
2477 (bidi_init_it): Initialize new members.
2478 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2479 definitions.
2480 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2481 instead of using explicit *_CHAR codes.
d6d100dd
SM
2482 (bidi_resolve_explicit, bidi_resolve_weak):
2483 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
2484 bidirectional text is supported only in multibyte buffers.
2485 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2486 it to initialize the frame_window_p member of struct bidi_it.
2487 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2488 (bidi_resolve_explicit, bidi_resolve_weak)
2489 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2490 bidi_it->nchars is non-positive.
2491 (bidi_level_of_next_char): Don't try to lookup the cache for the
2492 next/previous character if nothing is cached there yet, or if we
2493 were just reseat()'ed to a new position.
c40e2fb2 2494
0e14fe90
EZ
2495 * xdisp.c (set_cursor_from_row): Set start and stop points
2496 according to the row's direction when priming the loop that looks
2497 for the glyph on which to display cursor.
2498 (single_display_spec_intangible_p): Function deleted.
2499 (display_prop_intangible_p): Reimplement to call
2500 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
2501 Accept 3 additional arguments needed by handle_display_spec.
2502 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
2503 values: lists, `(when COND...)' forms, etc.
2504 (single_display_spec_string_p): Support property values that are
2505 lists with the argument STRING its top-level element.
2506 (display_prop_string_p): Fix the condition for processing a
2507 property that is a list to be consistent with handle_display_spec.
fec2107c 2508 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
2509 last portion of handle_display_prop.
2510 (compute_display_string_pos): Accept additional argument
2511 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2512 value of a `display' property is a "replacing spec".
2513 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2514 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2515 the display property, but just return a value indicating whether
2516 the display property will replace the characters it covers.
2517 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2518 frame_window_p members of struct bidi_it.
d6d100dd
SM
2519 (compute_display_string_pos, compute_display_string_end):
2520 New functions.
fec2107c
EZ
2521 (push_it): Accept second argument POSITION, where pop_it should
2522 jump to continue iteration.
2523 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 2524
fec2107c
EZ
2525 * keyboard.c (adjust_point_for_property): Adjust the call to
2526 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
2527
2528 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
2529 (bidi_init_it): Update prototypes.
2530 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
2531 (compute_display_string_pos, compute_display_string_end):
2532 Declare prototypes.
fec2107c
EZ
2533 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2534 EMACS_INT.
fc6f18ce 2535
40087514 25362011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 2537
57f53182
PE
2538 Malloc failure behavior now depends on size of allocation.
2539 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2540 * lisp.h: Change signatures accordingly.
2541 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2542 All callers changed. (Bug#8762)
2543
2544 * gnutls.c: Use Emacs's memory allocators.
2545 Without this change, the gnutls library would invoke malloc etc.
2546 directly, which causes problems on non-SYNC_INPUT hosts, and which
2547 runs afoul of improving memory_full behavior. (Bug#8761)
2548 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2549 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2550 xfree instead of the default malloc, realloc, free.
2551 (Fgnutls_boot): No need to check for memory allocation failure,
2552 since xmalloc does that for us.
2553
ac32cd99 2554 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
2555 * category.c (hash_get_category_set):
2556 * ccl.c (ccl_driver):
2557 * charset.c (Fdefine_charset_internal):
2558 * charset.h (struct charset.hash_index):
2559 * composite.c (get_composition_id, gstring_lookup_cache)
2560 (composition_gstring_put_cache):
2561 * composite.h (struct composition.hash_index):
2562 * dispextern.h (struct image.hash):
2563 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2564 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2565 (hashfn_equal, hashfn_user_defined, make_hash_table)
2566 (maybe_resize_hash_table, hash_lookup, hash_put)
2567 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2568 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2569 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2570 * image.c (make_image, search_image_cache, lookup_image)
2571 (xpm_put_color_table_h):
2572 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 2573 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 2574 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 2575 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
2576 * alloc.c (allocate_vectorlike):
2577 Check for overflow in vector size calculations.
2578 * ccl.c (ccl_driver):
2579 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
2580 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2581 need to be updated by these changes.
40087514
PE
2582 * fns.c (make_hash_table, maybe_resize_hash_table):
2583 Check for integer overflow with large hash tables.
0de4bb68
PE
2584 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2585 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2586 (SXHASH_REDUCE): New macro.
2587 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2588 Use it instead of discarding useful hash info with large hash values.
2589 (sxhash_float): New function.
2590 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2591 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
2592 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2593 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
2594 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2595 Adjust signatures to match updated version of code.
2596 (consing_since_gc): Now EMACS_INT, since a single hash table can
2597 use more than INT_MAX bytes.
2598
698d32e2
DN
25992011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2600
2601 Make it possible to build with GCC-4.6+ -O2 -flto.
2602
2603 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2604
fd6fa53f
SM
26052011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2606
2607 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2608 Call minibuffer-inactive-mode.
2609
864db017
JB
26102011-05-31 Juanma Barranquero <lekktu@gmail.com>
2611
2612 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2613 Update dependencies.
2614
2ad0baf4
DN
26152011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2616
2617 * data.c (init_data): Remove code for UTS, this system is not
2618 supported anymore.
2619
4fcc2638
DN
26202011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2621
2622 Don't force ./temacs to start in terminal mode.
2623
2624 * frame.c (make_initial_frame): Initialize faces in all cases, not
2625 only when CANNOT_DUMP is defined.
2626 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2627
c56e0fd5
DN
26282011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2629
2630 * dispnew.c (add_window_display_history): Use const for the string
2631 pointer. Remove declaration, not needed.
2632
333d54da 26332011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 2634
55d4c1b2 2635 Use 'inline', not 'INLINE'.
333d54da 2636 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
2637 * alloc.c, fontset.c (INLINE): Remove.
2638 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2639 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2640 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2641 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2642 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2643
738db178
DN
26442011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2645
2646 Make it possible to run ./temacs.
2647
2648 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2649 syms_of_callproc does the same thing. Remove test for
2650 "initialized", do it in the caller.
2651 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2652
620c53a6
SM
26532011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2654
2655 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2656 (read_minibuf): Use get_minibuffer.
2657 (syms_of_minibuf): Use DEFSYM.
2658 (Qmetadata): New var.
2659 * data.c (Qbuffer): Don't make it static.
2660 (syms_of_data): Use DEFSYM.
2661
e003a292
PE
26622011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2663
2664 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2665 (CCL_CODE_MIN): New macro.
2666
ed008a6d
PE
26672011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2668
3687c2ef
PE
2669 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2670
ed008a6d
PE
2671 * eval.c (Qdebug): Now static.
2672 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2673 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2674 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2675
d66c4c7c
CY
26762011-05-29 Chong Yidong <cyd@stupidchicken.com>
2677
2678 * image.c: Various fixes to ImageMagick code comments.
2679 (Fimagemagick_types): Doc fix.
2680
5fbc2025
PE
26812011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2682
0196f88a
PE
2683 Minor fixes prompted by GCC 4.6.0 warnings.
2684
2685 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2686
5fbc2025
PE
2687 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2688 (x_clipboard_manager_save_all): Move extern decl to ...
2689 * xterm.h: ... here, so that it can be checked for consistency.
2690
1dd3c2d9
CY
26912011-05-29 Chong Yidong <cyd@stupidchicken.com>
2692
2693 * xselect.c (x_clipboard_manager_save_frame)
2694 (x_clipboard_manager_save_all): New functions.
2695 (Fx_clipboard_manager_save): Lisp function deleted.
2696
2697 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2698 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2699
2700 * xterm.h: Update prototype.
2701
5ba6571d
WX
27022011-05-28 William Xu <william.xwl@gmail.com>
2703
2704 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2705 exiting (Bug#8239).
2706
3eaff834
JM
27072011-05-28 Jim Meyering <meyering@redhat.com>
2708
e1900994 2709 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
2710 * fns.c (to_uchar): Define.
2711 (crypto_hash_function): Use it to convert some newly-signed
2712 variables to unsigned, to avoid sign-extension bugs. For example,
2713 without this change, (md5 "truc") would evaluate to
2714 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2715 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 2716 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 2717
0f6990a7
PE
27182011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2719
2720 Integer overflow fixes.
c8a9ca5a 2721
08686060
PE
2722 * dbusbind.c: Serial number integer overflow fixes.
2723 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
2724 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2725 to hold a serial number that is too large for a fixnum.
2726 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2727 Check for serial numbers out of range. Decode any serial number
59568bf0 2728 that was so large that it became a float. (Bug#8722)
08686060 2729
2d1fc3c7
PE
2730 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2731 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2732 Use XFASTINT rather than XUINT when numbers are nonnegative.
2733 (xd_append_arg, Fdbus_method_return_internal):
2734 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2735 arguments, check that Lisp number is nonnegative, rather than
59568bf0 2736 silently wrapping negative numbers around. (Bug#8722)
30217ff0 2737 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 2738 (Bug#8722)
2d1fc3c7 2739
c8a9ca5a
PE
2740 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2741
519e1d69
PE
2742 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2743
30569699
PE
2744 ccl: add integer overflow checks
2745 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2746 (IN_INT_RANGE): New macros.
2747 (ccl_driver): Use them to check for integer overflow when
2748 decoding a CCL program. Many of the new checks are whether XINT (x)
2749 fits in int; it doesn't always, on 64-bit hosts. The new version
2750 doesn't catch all possible integer overflows, but it's an
847044ea 2751 improvement. (Bug#8719)
30569699 2752
c11285dc
PE
2753 * alloc.c (make_event_array): Use XINT, not XUINT.
2754 There's no need for unsigned here.
2755
fdccd48e
PE
2756 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2757 This follows up to the 2011-05-06 change that substituted uintptr_t
2758 for EMACS_INT. This case wasn't caught back then.
2759
37910ab2
PE
2760 Rework Fformat to avoid integer overflow issues.
2761 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2762 now (part of C89). Include <verify.h>.
2763 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2764 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2765 (Fformat): Avoid the prepass trying to compute sizes; it was only
2766 approximate and thus did not catch overflow reliably. Instead, walk
2767 through the format just once, formatting and computing sizes as we go,
2768 checking for integer overflow at every step, and allocating a larger
2769 buffer as needed. Keep track separately whether the format is
2770 multibyte. Keep only the most-recently calculated precision, rather
2771 than them all. Record whether each argument has been converted to
2772 string. Use EMACS_INT, not int, for byte and char and arg counts.
2773 Support field widths and precisions larger than INT_MAX. Avoid
2774 sprintf's undefined behavior with conversion specifications such as %#d
2775 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2776 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2777 formatting out-of-range floating point numbers with int
9173deec 2778 formats. (Bug#8668)
37910ab2 2779
2e6578fb
PE
2780 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2781
0ae6bdee
PE
2782 * data.c: Avoid integer truncation in expressions involving floats.
2783 * data.c: Include <intprops.h>.
2784 (arith_driver): When there's an integer overflow in an expression
2785 involving floating point, convert the integers to floating point
2786 so that the resulting value does not suffer from catastrophic
2787 integer truncation. For example, on a 64-bit host (* 4
2788 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2789 Do not rely on undefined behavior after integer overflow.
2790
de883a70
PE
2791 merge count_size_as_multibyte, parse_str_to_multibyte
2792 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 2793 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
2794 Check for integer overflow.
2795 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2796 since it's now a duplicate of the other. This is more of
2797 a character than a buffer op, so better that it's in character.c.
2798 * fns.c, print.c: Adjust to above changes.
2799
2ff916cb
PE
28002011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2801
2802 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2803
f1b54466
PE
28042011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2805
fb1ac845
PE
2806 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2807 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2808 (x_clipboard_manager_save): Now static.
2809 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2810
f1b54466
PE
2811 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2812 (crypto_hash_function): Now static.
2813 Fix pointer signedness problems. Avoid unnecessary initializations.
2814
a9f737ee
CY
28152011-05-27 Chong Yidong <cyd@stupidchicken.com>
2816
2817 * termhooks.h (Vselection_alist): Make it terminal-local.
2818
2819 * terminal.c (create_terminal): Initialize it.
2820
2821 * xselect.c: Support for clipboard managers.
2822 (Vselection_alist): Move to termhooks.h as terminal-local var.
2823 (LOCAL_SELECTION): New macro.
2824 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2825 (symbol_to_x_atom): Remove gratuitous arg.
2826 (x_handle_selection_request, lisp_data_to_selection_data)
2827 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
2828 (x_own_selection, x_get_local_selection, x_convert_selection):
2829 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
2830 (some_frame_on_display): Delete unused function.
2831 (Fx_own_selection_internal, Fx_get_selection_internal)
2832 (Fx_disown_selection_internal, Fx_selection_owner_p)
2833 (Fx_selection_exists_p): New optional frame arg.
2834 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2835 (x_handle_selection_clear): Don't treat other terminals with the
2836 same keyboard specially. Use the terminal-local Vselection_alist.
2837 (x_clear_frame_selections): Use Frun_hook_with_args.
2838
2839 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2840
2841 * xterm.h: Add support for those atoms.
2842
e067f0c1
CY
28432011-05-26 Chong Yidong <cyd@stupidchicken.com>
2844
2845 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2846 (converted_selections, conversion_fail_tag): New global variables.
2847 (x_selection_request_lisp_error): Free the above.
2848 (x_get_local_selection): Remove unnecessary code.
2849 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
2850 of converted selections stored in converted_selections.
2851 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
2852 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2853 (x_convert_selection): New function.
2854 (x_handle_selection_event): Simplify.
2855 (x_get_foreign_selection): Don't ignore incoming requests while
2856 waiting for an answer; this will fail when we implement
2857 SAVE_TARGETS, and seems unnecessary anyway.
2858 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2859 (Vx_sent_selection_functions): Doc fix.
2860
0f4aebc0
LL
28612011-05-26 Leo Liu <sdl.web@gmail.com>
2862
2863 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2864
e61124cd
YM
28652011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2866
2867 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
2868
2869 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
2870 for fringe update if it has periodic bitmap.
ac389d0c 2871 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
2872 and fringe_bitmap_periodic_p.
2873
2874 * fringe.c (get_fringe_bitmap_data): New function.
2875 (draw_fringe_bitmap_1, update_window_fringes): Use it.
2876 (update_window_fringes): Record periodicity of fringe bitmap in glyph
2877 row. Mark glyph row for fringe update if periodicity changed.
2878
2879 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
2880 for fringe update unless it has periodic bitmap.
2881
f16d9837
KH
28822011-05-25 Kenichi Handa <handa@m17n.org>
2883
2884 * xdisp.c (get_next_display_element): Set correct it->face_id for
2885 a static composition.
2886
e1b90ef6
LL
28872011-05-24 Leo Liu <sdl.web@gmail.com>
2888
2889 * deps.mk (fns.o):
2890 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
2891
2892 * fns.c (crypto_hash_function, Fsha1): New function.
2893 (Fmd5): Use crypto_hash_function.
2894 (syms_of_fns): Add Ssha1.
2895
7400048f
PE
28962011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2897
2898 * gnutls.c: Remove unused macros.
2899 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
2900 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
2901 Remove macros that are defined and never used.
2902 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
2903
abb71cf4
CY
29042011-05-22 Chong Yidong <cyd@stupidchicken.com>
2905
2906 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
2907 (Fx_get_selection_internal): Minor cleanup.
2908 (Fx_own_selection_internal): Rename arguments for consistency with
2909 select.el.
2910
6307db39
PE
29112011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2912
2913 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
2914
f3d4e0a4
CY
29152011-05-22 Chong Yidong <cyd@stupidchicken.com>
2916
2917 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
2918
4d8ade89
YM
29192011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2920
2921 * dispnew.c (scrolling_window): Don't exclude the case that the
2922 last enabled row in the desired matrix touches the bottom boundary.
2923
32078c8d
GM
29242011-05-21 Glenn Morris <rgm@gnu.org>
2925
2926 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
2927 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
2928 and add some more files.
32078c8d 2929
7285dc67
EZ
29302011-05-20 Eli Zaretskii <eliz@gnu.org>
2931
2932 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
2933 report_file_error introduced by the change from 2011-05-07.
2934
89d1bd22
PE
29352011-05-20 Paul Eggert <eggert@cs.ucla.edu>
2936
2937 * systime.h (Time): Define only if emacs is defined.
2938 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
2939 where the include path doesn't have X11/X.h by default. See
2940 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
2941
e23640bb 29422011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
2943
2944 * composite.c (find_automatic_composition): Fix previous change.
2945
b9704ad9
GM
29462011-05-20 Glenn Morris <rgm@gnu.org>
2947
2948 * lisp.mk: New file, split from Makefile.in.
2949 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
2950 (shortlisp): Remove.
2951 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
2952
4a720484
GM
29532011-05-19 Glenn Morris <rgm@gnu.org>
2954
2955 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
2956 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
2957 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
2958 (lisp): Set the order to that of loadup.el.
2959 (shortlisp): Make it a copy of $lisp.
2960 (SOME_MACHINE_LISP): Remove.
2961 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
2962 Use just $shortlisp, not $SOME_MACHINE_LISP too.
2963
a28d4396
KH
29642011-05-18 Kenichi Handa <handa@m17n.org>
2965
2966 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
2967 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
2968 (find_automatic_composition): Mostly rewrite for efficiency.
2969
a2b1fa8e
JB
29702011-05-18 Juanma Barranquero <lekktu@gmail.com>
2971
2972 * makefile.w32-in: Update dependencies.
2973
8e1f5610
CS
29742011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
2975
2976 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 2977 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 2978
7025ee00 29792011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 2980
cdfa6eab
PE
2981 Fix some integer overflow issues, such as string length overflow.
2982
06d6db33
PE
2983 * insdel.c (count_size_as_multibyte): Check for string overflow.
2984
2b4560a8
PE
2985 * character.c (lisp_string_width): Check for string overflow.
2986 Use EMACS_INT, not int, for string indexes and lengths; in
2987 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
2988 the resulting string length overflows an EMACS_INT; instead,
2989 report a string overflow if no precision given. When checking for
2990 precision exhaustion, use a check that cannot possibly have
2991 integer overflow. (Bug#8675)
2992 * character.h (lisp_string_width): Adjust to new signature.
2993
cb93f9be
PE
2994 * alloc.c (string_overflow): New function.
2995 (Fmake_string): Use it. This doesn't change behavior, but saves
2996 a few bytes and will simplify future changes.
2997 * character.c (string_escape_byte8): Likewise.
2998 * lisp.h (string_overflow): New decl.
2999
1a1f3366
PE
3000 Fixups, following up to the user-interface timestamp change.
3001 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3002 for UI timestamps, instead of unsigned long.
9fbd6841
PE
3003 * msdos.c (mouse_get_pos): Likewise.
3004 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
3005 * w32gui.h (Time): Define by including "systime.h" rather than by
3006 declaring it ourselves. (Bug#8664)
3007
d4e3e4d3
PE
3008 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3009 * image.c (clear_image_cache): Likewise.
3010
f6a24d19
PE
3011 * term.c (term_mouse_position): Don't assume time_t wraparound.
3012
08dc5ae6
PE
3013 Be more systematic about user-interface timestamps.
3014 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
3015 and sometimes 'EMACS_UINT', to represent these timestamps.
3016 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
3017 This makes the code easier to follow, and makes it easier to catch
3018 integer overflow bugs such as Bug#8664.
3019 * frame.c (Fmouse_position, Fmouse_pixel_position):
3020 Use Time, not unsigned long, for user-interface timestamps.
3021 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3022 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3023 * keyboard.h (last_event_timestamp): Likewise.
3024 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3025 * menu.h (xmenu_show): Likewise.
3026 * term.c (term_mouse_position): Likewise.
3027 * termhooks.h (struct input_event.timestamp): Likewise.
3028 (struct terminal.mouse_position_hook): Likewise.
3029 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3030 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3031 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3032 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3033 what it was before.
3034 * menu.h, termhooks.h: Include "systime.h", for Time.
3035
8e55734a
PE
3036 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3037 Don't assume that the difference between two unsigned long values
3038 can fit into an integer. At this point, we know button_down_time
3039 <= event->timestamp, so the difference must be nonnegative, so
3040 there's no need to cast the result if double-click-time is
3041 nonnegative, as it should be; check that it's nonnegative, just in
3042 case. This bug is triggered when events are more than 2**31 ms
86db42d2 3043 apart (about 25 days). (Bug#8664)
8e55734a 3044
841f1b75 3045 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 3046 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 3047
3e26f69c
PE
3048 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3049 that always fit in int. Use a sentinel instead of a counter, to
3050 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
3051 * frame.h (struct frame): Use int for menu_bar_items_used
3052 instead of EMACS_INT, since it always fits in int.
3e26f69c 3053
5cc152c0
PE
3054 * menu.c (grow_menu_items): Check for int overflow.
3055
d89eb65e
PE
3056 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3057
5235bd3e
PE
3058 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3059 Before, the code was not consistent. These values cannot exceed
3060 2**31 - 1 so there's no need to make them unsigned.
3061 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3062 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3063 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3064 as modifiers.
3065 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3066
bc827e23
PE
3067 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3068 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3069 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3070 presumably because the widths might not match.
3071
78eb494e
PE
3072 * window.c (size_window): Avoid needless test at loop start.
3073
04f2d78b
CB
30742011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3075
3076 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3077
d2fc7e3d 30782011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
3079
3080 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3081
d2fc7e3d 30822011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
3083
3084 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
3085 `width' to `bar_area_x' and `bar_area_width', respectively.
3086 (x_scroll_run): Take account of fringe background extension.
3087
04f2d78b
CB
3088 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3089 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
3090 `bar_area_width', respectively.
3091 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3092 background extension.
3093
79b70037
GM
30942011-05-10 Jim Meyering <meyering@redhat.com>
3095
3096 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3097
2f142cc5
JB
30982011-05-10 Juanma Barranquero <lekktu@gmail.com>
3099
3100 * image.c (Finit_image_library): Return t for built-in image types,
3101 like pbm and xbm. (Bug#8640)
3102
57679c86
AS
31032011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3104
3105 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3106
888c9e86
EZ
31072011-05-07 Eli Zaretskii <eliz@gnu.org>
3108
b0512a1d
EZ
3109 * w32console.c (Fset_screen_color): Doc fix.
3110 (Fget_screen_color): New function.
3111 (syms_of_ntterm): Defsubr it.
3112
7285dc67
EZ
3113 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3114 unlink the temporary file if Fcall_process didn't create it in the
3115 first place.
3116 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3117 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
3118 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3119 cue to call_process_cleanup not to close that handle.
3120
4d3fcc8e
BK
31212011-05-07 Ben Key <bkey76@gmail.com>
3122
3123 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3124 one of two shell specific rules, either bootstrap-temacs-CMD or
3125 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3126 to the previous implementation of the bootstrap-temacs rule.
3127 The bootstrap-temacs-CMD rule is similar to the previous
3128 implementation of the bootstrap-temacs rule except that it
3129 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3130 variable.
3131
3132 These changes, along with some changes to nt/configure.bat,
3133 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3134 earlier fix to add support for --cflags and --ldflags options
3135 that include quotes so that it works whether make uses cmd or
3136 sh as the shell.
3137
b4289b64
MA
31382011-05-06 Michael Albinus <michael.albinus@gmx.de>
3139
3140 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3141 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3142 is a constant.
3143 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3144 a string. Handle both cases.
3145 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3146 (Fdbus_register_method): Use Qinvalid_function.
3147
af4c0e28
JB
31482011-05-06 Juanma Barranquero <lekktu@gmail.com>
3149
3150 * makefile.w32-in: Update dependencies.
3151 (LISP_H): Add inttypes.h and stdin.h.
3152 (PROCESS_H): Add unistd.h.
3153
c51453d9
EZ
31542011-05-06 Eli Zaretskii <eliz@gnu.org>
3155
3156 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3157 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3158
8ff0ac3c 31592011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 3160
4c4b566b
PE
3161 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3162
aab2b9b5
PE
3163 * term.c (vfatal): Remove stray call to va_end.
3164 It's not needed and the C Standard doesn't allow it here anyway.
3165
c378da0b
PE
3166 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3167 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3168
288b08c7
PE
3169 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3170 bytes.
3171
e3601888
PE
3172 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3173
db6c0e74
PE
3174 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3175
dd5963ea
PE
3176 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3177
88c9450f
PE
3178 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3179
2f9442b8
PE
3180 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3181
c032b5f8
PE
3182 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3183 * charset.c (Fdefine_charset_internal): Don't initialize
3184 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 3185 32-bit int (Bug#8600).
a108c10b
PE
3186
3187 * lread.c (read_integer): Be more consistent with string-to-number.
3188 Use string_to_number to do the actual conversion; this avoids
3189 rounding errors and fixes some other screwups. Without this fix,
3190 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3191 (digit_to_number): Move earlier, for benefit of read_integer.
3192 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 3193 not a digit in any supported base. (Bug#8602)
a108c10b 3194
ad5f9eea
PE
3195 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3196
aec1708a
PE
3197 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3198 to match comment at start of function. This also removes a
3199 GCC warning about overflow in a 32+64-bit port.
3200
47be4ab5
PE
3201 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3202
371cac43
PE
3203 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3204 Reported by Stefan Monnier in
3205 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
3206 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3207 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 3208
d01a7826
PE
3209 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3210 (EMACS_UINTPTR): Likewise, with uintptr_t.
3211
7fd47d5c
PE
3212 * lisp.h: Prefer 64-bit EMACS_INT if available.
3213 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3214 on 32-bit hosts that have 64-bit int, so that they can access
3215 large files.
122b0c86
PE
3216 However, temporarily disable this change unless the temporary
3217 symbol WIDE_EMACS_INT is defined.
7fd47d5c 3218
8727937b
PE
3219 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3220
8ac068ac
PE
3221 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3222 This removes an assumption that EMACS_INT and long are the same
3223 width as pointers. The assumption is true for Emacs porting targets
3224 now, but we want to make other targets possible.
3225 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3226 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3227 In the rest of the code, change types of integers that hold casted
3228 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3229 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3230 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3231 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3232 No need to cast type when ORing.
3233 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3234 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3235 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3236 assume EMACS_INT is the same width as char *.
3237 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3238 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3239 Remove no-longer-needed casts.
3240 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3241 (xg_tool_bar_help_callback, xg_make_tool_item):
3242 Use EMACS_INTPTR to hold an integer
3243 that will be cast to void *; this can avoid a GCC warning
3244 if EMACS_INT is not the same width as void *.
3245 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3246 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3247 (current_message_1, set_message_1):
3248 Use a local to convert to proper width without a cast.
3249 * xmenu.c (dialog_selection_callback): Likewise.
3250
ede49d71
PE
3251 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3252 Also, don't assume VALBITS / RAND_BITS is less than 5,
3253 and don't rely on undefined behavior when shifting a 1 left into
3254 the sign bit.
3255 * lisp.h (get_random): Change signature to match.
3256
2f30ecd0
PE
3257 * lread.c (hash_string): Use size_t, not int, for hash computation.
3258 Normally we prefer signed values; but hashing is special, because
3259 it's better to use unsigned division on hash table sizes so that
3260 the remainder is nonnegative. Also, size_t is the natural width
3261 for hashing into memory. The previous code used 'int', which doesn't
3262 retain enough info to hash well into very large tables.
3263 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3264
2a866e7b
PE
3265 * dbusbind.c: Don't possibly lose pointer info when converting.
3266 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3267 Use XPNTR rather than XHASH, so that the high-order bits of
3268 the pointer aren't lost when converting through void *.
3269
51639eac
PE
3270 * eval.c (Fautoload): Don't double-shift a pointer.
3271
92394119
PE
3272 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3273
dbdb9a7c
JB
32742011-05-06 Juanma Barranquero <lekktu@gmail.com>
3275
3276 * gnutls.c (DEF_GNUTLS_FN):
3277 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3278
db7a0b4f
AS
32792011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3280
3281 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3282 marker. (Bug#8610)
3283
f7ff1b0f 32842011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
3285
3286 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3287 New version that can reserve upto 2GB of heap space.
3288
f7ff1b0f 32892011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
3290
3291 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3292
639c109b
TZ
32932011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3294
3295 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3296 `gnutls_certificate_set_x509_key_file'.
3297
d2127135
JB
32982011-05-05 Juanma Barranquero <lekktu@gmail.com>
3299
3300 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3301 Update dependencies.
3302
e968f4f3
JB
33032011-05-04 Juanma Barranquero <lekktu@gmail.com>
3304
3305 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3306 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3307 Remove unused parameter `fildes'.
3308 * process.c (read_process_output, send_process): Don't pass it.
3309
84d358f0
JB
33102011-05-04 Juanma Barranquero <lekktu@gmail.com>
3311
3312 Fix previous change: the library cache is defined in w32.c.
3313 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3314 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3315
0898ca10
JB
33162011-05-04 Juanma Barranquero <lekktu@gmail.com>
3317
3318 Implement dynamic loading of GnuTLS on Windows.
3319
3320 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3321 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3322 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3323 Declare.
3324
3325 * gnutls.c (Qgnutls_dll): Define.
3326 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3327 (gnutls_*): Declare function pointers.
3328 (init_gnutls_functions): New function to initialize function pointers.
3329 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3330 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3331 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3332 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3333 (emacs_gnutls_write, emacs_gnutls_read)
3334 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3335 (Fgnutls_available_p): New function.
3336 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3337 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3338 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3339
3340 * image.c: Include w32.h.
3341 (Vimage_type_cache): Delete.
3342 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3343 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3344 (w32_delayed_load): Move to w32.c.
3345
3346 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3347
3348 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3349 (w32_delayed_load): Move from image.c. When loading a library, record
3350 its filename in the :loaded-from property of the library id.
3351 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3352 Initialize and staticpro them.
3353 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3354
3355 * process.c: Include lisp.h before w32.h, not after.
3356 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3357 instead of gnutls_record_check_pending.
3358
3359 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3360
ff4de4aa
TZ
33612011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3362
3363 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3364 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3365 as passed in.
3366
abe95abb
JD
33672011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3368
3369 * xterm.c (x_set_frame_alpha): Do not set property on anything
3370 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3371
e16e55d4
JB
33722011-05-02 Juanma Barranquero <lekktu@gmail.com>
3373
3374 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3375
bafcf6a5
JB
33762011-05-02 Juanma Barranquero <lekktu@gmail.com>
3377
3378 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3379 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3380 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3381 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3382 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3383 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3384 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3385 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3386 (Qgnutls_bootprop_callbacks_verify): Make static.
3387
e7a6747f
AS
33882011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3389
19ed11ba
AS
3390 * callproc.c: Indentation fixup.
3391
e7a6747f 3392 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
3393 (wait_for_termination, interruptible_wait_for_termination):
3394 Move after wait_for_termination_1.
e7a6747f 3395
1ef14cb4
LMI
33962011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3397
3398 * sysdep.c (interruptible_wait_for_termination): New function
3399 which is like wait_for_termination, but allows keyboard
3400 interruptions.
3401
3402 * callproc.c (Fcall_process): Add (:file "file") as an option for
3403 the STDOUT buffer.
3404 (Fcall_process_region): Ditto.
3405
330d880c
EZ
34062011-04-30 Eli Zaretskii <eliz@gnu.org>
3407
8db90b73
EZ
3408 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3409 rather than `XVECTOR (FOO)->size'.
3410
330d880c
EZ
3411 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3412 inttypes.h, as a gnulib replacement is used if it not available in
3413 system headers.
3414
15cbd324
EZ
34152011-04-21 Eli Zaretskii <eliz@gnu.org>
3416
3417 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3418 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3419 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3420
3421 * coding.c (coding_alloc_by_realloc): Error out if destination
3422 will grow beyond MOST_POSITIVE_FIXNUM.
3423 (decode_coding_emacs_mule): Abort if there isn't enough place in
3424 charbuf for the composition carryover bytes. Reserve an extra
3425 space for up to 2 characters produced in a loop.
3426 (decode_coding_iso_2022): Abort if there isn't enough place in
3427 charbuf for the composition carryover bytes.
3428
34292011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 3430
ae940cca
EZ
3431 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3432 aborting when %lld or %lll format is passed.
3433 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3434 %llo or %llx format is passed. (Bug#8545)
3435
03ab8921
EZ
3436 * window.c (window_scroll_line_based): Use a marker instead of
3437 simple variables to record original value of point. (Bug#7952)
3438
afda1437
EZ
3439 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3440 produced by %s or %c overflows available buffer space. (Bug#8545)
3441
f76dee0c
PE
34422011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3443
3444 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 3445 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 3446
fdc5744d
JB
34472011-04-28 Juanma Barranquero <lekktu@gmail.com>
3448
3449 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3450
638f053a
JB
34512011-04-28 Juanma Barranquero <lekktu@gmail.com>
3452
3453 * keyboard.c (Qdelayed_warnings_hook): Define.
3454 (command_loop_1): Run `delayed-warnings-hook'
3455 if Vdelayed_warnings_list is non-nil.
3456 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3457 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3458
d178f871
EZ
34592011-04-28 Eli Zaretskii <eliz@gnu.org>
3460
3461 * doprnt.c (doprnt): Don't return value smaller than the buffer
3462 size if the message was truncated. (Bug#8545).
3463
b124fd93
JB
34642011-04-28 Juanma Barranquero <lekktu@gmail.com>
3465
3466 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3467 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3468
e810457d
PE
34692011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3470
3471 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3472
ea51cceb
JB
34732011-04-27 Juanma Barranquero <lekktu@gmail.com>
3474
3475 * makefile.w32-in: Update dependencies.
3476
94dcfacf
EZ
34772011-04-27 Eli Zaretskii <eliz@gnu.org>
3478
3479 Improve `doprnt' and its usage. (Bug#8545)
3480 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3481 `format_end'. Remove support for %l as a conversion specifier.
3482 Don't use xrealloc. Improve diagnostics when the %l size modifier
3483 is used. Update the commentary.
3484
3485 * eval.c (verror): Simplify calculation of size_t.
3486
3487 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3488 messages.
3489
f61f41d7
PE
34902011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3491
3492 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3493 change.
3494
96fb4434
PE
34952011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3496
3497 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3498 This makes this file independent of the recent pseudovector change.
3499
671875da 35002011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 3501
69e9b5a3
PE
3502 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3503
b5f869a7 3504 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 3505 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 3506 Remove unused local.
c8926152 3507 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 3508
841a1577 3509 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
3510 GCC 4.6.0 optimizes based on type-based alias analysis.
3511 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
3512 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3513 != &v->size, and therefore "v->size = 1; b->size = 2; return
3514 v->size;" must therefore return 1. This assumption is incorrect
3515 for Emacs, since it type-puns struct Lisp_Vector * with many other
3516 types. To fix this problem, this patch adds a new type struct
f904488f 3517 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
3518 and pseudovectors, and helps optimizing compilers not get fooled
3519 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3520 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
3521 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3522 the size member.
eab3844f
PE
3523 (XSETPVECTYPE): Rewrite in terms of new macro.
3524 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3525 This is a bit clearer, and further avoids the possibility of
3526 undesirable aliasing.
3527 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 3528 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
3529 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3530 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
3531 (ASIZE): Now uses header.size rather than size.
3532 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
3533 to avoid the hassle of writing XVECTOR (foo)->header.size.
3534 (struct vectorlike_header): New type.
eab3844f
PE
3535 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3536 object, to help avoid aliasing.
3537 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3538 (SUBRP): Likewise, since Lisp_Subr is a special case.
3539 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3540 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3541 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 3542 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
3543 changed to be "header.size" and "header.next".
3544 * buffer.h (struct buffer): Likewise.
3545 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3546 * frame.h (struct frame): Likewise.
3547 * process.h (struct Lisp_Process): Likewise.
3548 * termhooks.h (struct terminal): Likewise.
3549 * window.c (struct save_window_data, struct saved_window): Likewise.
3550 * window.h (struct window): Likewise.
3551 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3552 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3553 * buffer.c (init_buffer_once): Likewise.
3554 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3555 special case.
3556 * process.c (Fformat_network_address): Use local var for size,
3557 for brevity.
3558
0df1eac5
PE
3559 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3560
847ab9d1 3561 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
3562 * data.c (atof): Remove decl; no longer used or needed.
3563 (digit_to_number): Move to lread.c.
3564 (Fstring_to_number): Use new string_to_number function, to be
3565 consistent with how the Lisp reader treats infinities and NaNs.
3566 Do not assume that floating-point numbers represent EMACS_INT
3567 without losing information; this is not true on most 64-bit hosts.
3568 Avoid double-rounding errors, by insisting on integers when
3569 parsing non-base-10 numbers, as the documentation specifies.
3570 * lisp.h (string_to_number): New decl, replacing ...
3571 (isfloat_string): Remove.
bc0a5c13 3572 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 3573 (read1): Do not accept +. and -. as integers; this
452f4150
PE
3574 appears to have been a coding error. Similarly, do not accept
3575 strings like +-1e0 as floating point numbers. Do not report
3576 overflow for integer overflows unless the base is not 10 which
3577 means we have no simple and reliable way to continue.
3578 Break out the floating-point parsing into a new
3579 function string_to_number, so that Fstring_to_number parses
3580 floating point numbers consistently with the Lisp reader.
04f2d78b 3581 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
3582 (E_CHAR, EXP_INT): Remove, replacing with ...
3583 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3584 (string_to_number): New function, replacing isfloat_string.
3585 This function checks for valid syntax and produces the resulting
3586 Lisp float number too. Rework it so that string-to-number
bc0a5c13 3587 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
3588 so that overflow for non-base-10 numbers is reported only when
3589 there's no portable and simple way to convert to floating point.
452f4150 3590
67769ffc
PE
3591 * textprop.c (set_text_properties_1): Rewrite for clarity,
3592 and to avoid GCC warning about integer overflow.
3593
c20db43f
PE
3594 * intervals.h (struct interval): Use EMACS_INT for members
3595 where EMACS_UINT might cause problems. See
3596 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3597 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3598 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3599 All uses changed.
37aa2f85
PE
3600 (offset_intervals): Tell GCC not to worry about length overflow
3601 when negating a negative length.
c20db43f 3602
2538aa2f
PE
3603 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3604 (overrun_check_free): Likewise.
3605
f2d3008d
PE
3606 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3607 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3608 word size.
3609
ec8df744
PE
3610 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3611 (gnutls_make_error): Rename local to avoid shadowing.
3612 (gnutls_emacs_global_deinit): ifdef out; not used.
3613 (Fgnutls_boot): Use const for pointer to readonly storage.
3614 Comment out unused local. Fix pointer signedness problems.
3615
640ee02d
PE
3616 * lread.c (openp): Don't stuff size_t into an 'int'.
3617 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3618 about possible signed overflow.
3619
6048fb2a
PE
3620 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3621 (GDK_KEY_g): Don't define if already defined.
3622 (xg_prepare_tooltip): Avoid pointer signedness problem.
3623 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3624
fa3c87e1
PE
3625 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3626 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3627
2172544b
PE
3628 * xfns.c (Fx_window_property): Simplify a bit,
3629 to make a bit faster and to avoid GCC 4.6.0 warning.
3630 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3631
9b821a21
PE
3632 * fns.c (internal_equal): Don't assume size_t fits in int.
3633
3c616cfa
PE
3634 * alloc.c (compact_small_strings): Tighten assertion a little.
3635
c2982e87
PE
3636 Replace pEd with more-general pI, and fix some printf arg casts.
3637 * lisp.h (pI): New macro, generalizing old pEd macro to other
3638 conversion specifiers. For example, use "...%"pI"d..." rather
3639 than "...%"pEd"...".
3640 (pEd): Remove. All uses replaced with similar uses of pI.
3641 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3642 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3643 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3644 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3645 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3646 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3647 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3648 64-bit hosts.
3649 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3650 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3651 * print.c (safe_debug_print, print_object): Likewise.
3652 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3653 to int.
6f04d126
PE
3654 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3655 avoiding the 0 flag, which is not portable.
c2982e87
PE
3656 * process.c (Fmake_network_process): Use pI to avoid cast.
3657 * region-cache.c (pp_cache): Likewise.
3658 * xdisp.c (decode_mode_spec): Likewise.
3659 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3660 behavior on 64-bit hosts with printf arg.
6f04d126 3661 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
3662 (x_stop_queuing_selection_requests): Likewise.
3663 (x_get_window_property): Don't truncate byte count to an 'int'
3664 when tracing.
0b432f21 3665
5e073ec7
PE
3666 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3667 here, since it parses constructs like leading '-' and spaces,
3668 which are not wanted; and it overflows with large numbers.
3669 Instead, simply match F[0-9]+, which is what is wanted anyway.
3670
36372bf9
PE
3671 * alloc.c: Remove unportable assumptions about struct layout.
3672 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3673 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3674 (allocate_vectorlike, make_pure_vector): Use the new macros,
3675 plus offsetof, to remove unportable assumptions about struct layout.
3676 These assumptions hold on all porting targets that I know of, but
3677 they are not guaranteed, they're easy to remove, and removing them
3678 makes further changes easier.
3679
0b432f21
PE
3680 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3681 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
3682 (string_overrun_cookie): Now const. Use initializers that
3683 don't formally overflow signed char, to avoid warnings.
000098c1
PE
3684 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3685 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
3686 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3687 multiple of sizeof (EMACS_INT); it need not be, if
3688 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 3689 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 3690
895009e1
JB
36912011-04-26 Juanma Barranquero <lekktu@gmail.com>
3692
3693 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3694
6a7a1b0b
TZ
36952011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3696
3697 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 3698 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
3699 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3700
841a1577 37012011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
3702
3703 * lisp.h (Qdebug): List symbol.
895009e1 3704 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
3705 * keyboard.c (debug-on-event): New variable.
3706 (handle_user_signal): Break into debugger when debug-on-event
3707 matches the current signal symbol.
3708
f2d3ba6f
DN
37092011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3710
3711 * alloc.c (check_sblock, check_string_bytes)
3712 (check_string_free_list): Convert to standard C.
3713
42ce4c63
TZ
37142011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3715
3716 * w32.c (emacs_gnutls_push): Fix typo.
3717
825cd63c
EZ
37182011-04-25 Eli Zaretskii <eliz@gnu.org>
3719
fb11d64d
EZ
3720 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3721 "cast to pointer from integer of different size".
3722
825cd63c
EZ
3723 Improve doprnt and its use in verror. (Bug#8545)
3724 * doprnt.c (doprnt): Document the set of format control sequences
3725 supported by the function. Use SAFE_ALLOCA instead of always
3726 using `alloca'.
3727
3728 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3729 is one byte too soon. Don't use xrealloc; instead xfree and
3730 xmalloc anew.
3731
e061a11b
TZ
37322011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3733
3734 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3735 callbacks stage.
3736
3737 * gnutls.c: Renamed global_initialized to
3738 gnutls_global_initialized. Added internals for the
3739 :verify-hostname-error, :verify-error, and :verify-flags
3740 parameters of `gnutls-boot' and documented those parameters in the
3741 docstring. Start callback support.
9173deec
JB
3742 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3743 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3744 on error. Return error code.
e061a11b
TZ
3745 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3746 (emacs_gnutls_read): Likewise.
3747 (Fgnutls_boot): Return handshake error code.
3748 (emacs_gnutls_handle_error): New function.
3749 (wsaerror_to_errno): Likewise.
3750
3751 * w32.h (emacs_gnutls_pull): Add prototype.
3752 (emacs_gnutls_push): Likewise.
3753
3754 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3755 (emacs_gnutls_push): Likewise.
3756
37572011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3758
3759 * process.c (wait_reading_process_output): Check if GnuTLS
3760 buffered some data internally if no FDs are set for TLS
3761 connections.
3762
3763 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3764 (LIBS): Link to USER_LIBS.
3765 ($(BLD)/gnutls.$(0)): New target.
3766
fa6996bc
EZ
37672011-04-24 Eli Zaretskii <eliz@gnu.org>
3768
eb35682e
EZ
3769 * xdisp.c (handle_single_display_spec): Rename the
3770 display_replaced_before_p argument into display_replaced_p, to
3771 make it consistent with the commentary. Fix typos in the
3772 commentary.
3773
e2ad650c
EZ
3774 * textprop.c (syms_of_textprop): Remove dead code.
3775 (copy_text_properties): Delete obsolete commentary about an
3776 interface that was deleted long ago. Fix typos in the description
3777 of arguments.
3778
1b2de274
EZ
3779 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3780 to changes in oldXMenu/XMenu.h from 2011-04-16.
3781 <menu_help_message, prev_menu_help_message>: Constify.
3782 (IT_menu_make_room): menu->help_text is now `const char **';
3783 adjust.
3784
3785 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3786 to changes in oldXMenu/XMenu.h from 2011-04-16.
3787 (struct XMenu): Declare `help_text' `const char **'.
3788
3789 * xfaces.c <Qunspecified>: Make extern again.
3790
3791 * syntax.c: Include sys/types.h before including regex.h, as
3792 required by Posix.
3793
762b15be
EZ
3794 * doc.c (get_doc_string): Improve the format passed to `error'.
3795
3796 * doprnt.c (doprnt): Improve commentary.
3797
3798 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3799
3800 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3801 them with etags.
3802
f1052e5d
EZ
3803 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3804 changes in globals.h immediately force recompilation.
762b15be
EZ
3805 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3806 $(CURDIR)/s/ms-w32.h.
3807 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 3808
fa6996bc
EZ
3809 * character.c (Fchar_direction): Function deleted.
3810 (syms_of_character): Don't defsubr it.
3811 <char-direction-table>: Deleted.
3812
e6c3da20
EZ
38132011-04-23 Eli Zaretskii <eliz@gnu.org>
3814
3815 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3816 * doprnt.c: Include limits.h.
3817 (SIZE_MAX): New macro.
04f2d78b
CB
3818 (doprnt): Return a size_t value. 2nd arg is now size_t.
3819 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
3820 Improve overflow protection. Support `l' modifier for integer
3821 conversions. Support %l conversion. Don't assume an EMACS_INT
3822 argument for integer conversions and for %c.
3823
3824 * lisp.h (doprnt): Restore prototype.
3825
3826 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3827 $(SRC)/character.h.
3828
3829 * Makefile.in (base_obj): Add back doprnt.o.
3830
3831 * deps.mk (doprnt.o): Add back prerequisites.
3832 (callint.o): Depend on character.h.
3833
3834 * eval.c (internal_lisp_condition_case): Include the handler
3835 representation in the error message.
3836 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3837 when breaking from the loop.
3838
3839 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3840
3841 * callint.c (Fcall_interactively): When displaying error message
3842 about invalid control letter, pass the character's codepoint, not
3843 a pointer to its multibyte form. Improve display of the character
3844 in octal and display also its hex code.
3845
3846 * character.c (char_string): Use %x to display the (unsigned)
3847 codepoint of an invalid character, to avoid displaying a bogus
3848 negative value.
3849
3850 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3851 `error', not SYMBOL_NAME itself.
3852
3853 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3854 character arguments to `error'.
3855
3856 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3857 to `error' in error message about FINAL_CHAR argument. Make sure
3858 FINAL_CHAR is a character, and use %c when it is passed as
3859 argument to `error'.
3860
4ffd0d6b 38612011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
3862
3863 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3864
3865 * w32.c: Include <time.h>.
3866 (sys_localtime): New function.
3867
4ffd0d6b 38682011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
3869
3870 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
3871
4ffd0d6b 3872 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 3873
4ffd0d6b 38742011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 3875
4ffd0d6b
GM
3876 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
3877 zombies (Bug#8467).
aac0c6e3 3878
04c56954
EZ
38792011-04-19 Eli Zaretskii <eliz@gnu.org>
3880
3881 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
3882 gl_state.e_property when gl_state.object is Qt.
3883
3884 * insdel.c (make_gap_larger): Remove limitation of buffer size
3885 to <= INT_MAX.
3886
16a43933
CY
38872011-04-18 Chong Yidong <cyd@stupidchicken.com>
3888
3889 * xdisp.c (lookup_glyphless_char_display)
3890 (produce_glyphless_glyph): Handle cons cell entry in
3891 glyphless-char-display.
3892 (Vglyphless_char_display): Document it.
3893
3894 * term.c (produce_glyphless_glyph): Handle cons cell entry in
3895 glyphless-char-display.
3896
4581706e
CY
38972011-04-17 Chong Yidong <cyd@stupidchicken.com>
3898
3899 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
3900
3901 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
3902
3903 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
3904 definition for no-X builds.
3905
4887c6e2 39062011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 3907
fd35b6f9
PE
3908 Static checks with GCC 4.6.0 and non-default toolkits.
3909
5c1ccb01
PE
3910 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
3911
006c5daa
PE
3912 * process.c (keyboard_bit_set): Define only if SIGIO.
3913 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
3914 (send_process): Repair possible setjmp clobbering.
3915
efc736d3
PE
3916 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
3917
4e2fe2e6
PE
3918 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
3919
f97334a2
PE
3920 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
3921
4e75f29d
PE
3922 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
3923 Define only if needed.
3924
90efadd1
PE
3925 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
3926 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 3927 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 3928
3c647824
PE
3929 * dispextern.h (struct redisplay_interface): Rename param
3930 to avoid shadowing.
e264f262 3931 * termhooks.h (struct terminal): Likewise.
761383f4 3932 * xterm.c (xembed_send_message): Likewise.
3c647824 3933
b58c5c4a
PE
3934 * insdel.c (make_gap_smaller): Define only if
3935 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
3936
cad59032
PE
3937 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
3938 it.
3939
c339dc2e
PE
3940 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
3941 so that we aren't warned about unused symbols.
3942
91a3e27b
PE
3943 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
3944
399c71d3 3945 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 3946
8ffc96f5
PE
3947 * xfns.c (x_real_positions): Mark locals as initialized.
3948
eef9bc79
PE
3949 * xmenu.c (xmenu_show): Don't use uninitialized vars.
3950
098db9dd
PE
3951 * xterm.c: Fix problems found by static analysis with other toolkits.
3952 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
3953 (x_dispatch_event): Declare static if USE_GTK, and
3954 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 3955 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 3956 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
3957 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
3958 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 3959
eb18f6cc
PE
3960 * xmenu.c (menu_help_callback): Pointer type fixes.
3961 Use const pointers when pointing at readonly data. Avoid pointer
3962 signedness clashes.
3963 (FALSE): Remove unused macro.
3964 (update_frame_menubar): Remove unused decl.
3965
1fe72bf8
PE
3966 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
3967
60d9e1db
PE
3968 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
3969 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
3970 (single_menu_item): Rename local to avoid shadowing.
3971
39261c26
PE
3972 * keyboard.c (make_lispy_event): Remove unused local var.
3973
018c5e19
PE
3974 * frame.c, frame.h (x_get_resource_string): Bring this back, but
3975 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
3976
63d2b86e
PE
3977 * bitmaps: Change bitmaps from unsigned char back to the X11
3978 compatible char. Avoid the old compiler warnings about
3979 out-of-range initializers by using, for example, '\xab' rather
3980 than 0xab.
3981
aefd87e1
PE
3982 * xgselect.c (xgselect_initialize): Check vs interface
3983 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
3984
bf501fb9
PE
3985 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
3986
e9829fdf
PE
3987 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
3988 to read-only memory.
3989
1086c095
PE
3990 * fns.c (vector): Remove; this old hack is no longer needed.
3991
2baccd04 3992 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 3993 Remove unused var.
dde42981 3994 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 3995
72391843 3996 * xrdb.c (x_load_resources): Omit unused local.
3565b346 3997
436c16df 3998 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 3999 (x_window): Rename locals to avoid shadowing.
dc5ddd85 4000 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 4001
92bb796d 4002 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 4003 (x_term_init): Remove local to avoid shadowing.
92bb796d 4004
764430a3 4005 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
4006
4007 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4008 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4009
d1dfb56c
EZ
40102011-04-16 Eli Zaretskii <eliz@gnu.org>
4011
c4354cb4
EZ
4012 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4013
d1dfb56c
EZ
4014 Fix regex.c, syntax.c and friends for buffers > 2GB.
4015 * syntax.h (struct gl_state_s): Declare character position members
4016 EMACS_INT.
4017
4018 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4019
04f2d78b
CB
4020 * textprop.c (verify_interval_modification, interval_of):
4021 Declare arguments EMACS_INT.
d1dfb56c
EZ
4022
4023 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4024 EMACS_INT.
4025
4026 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4027
4028 * indent.c (Fvertical_motion): Local variable it_start is now
4029 EMACS_INT.
4030
4031 * regex.c (re_match, re_match_2, re_match_2_internal)
4032 (bcmp_translate, regcomp, regexec, print_double_string)
4033 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4034 (re_compile_pattern, re_exec): Declare arguments and local
4035 variables `size_t' and `ssize_t' and return values `regoff_t', as
4036 appropriate.
4037 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4038 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4039 <compile_stack_type>: `size' and `avail' are now `size_t'.
4040
4041 * regex.h <regoff_t>: Use ssize_t, not int.
4042 (re_search, re_search_2, re_match, re_match_2): Arguments that
4043 specify buffer/string position and length are now ssize_t and
4044 size_t. Return type is regoff_t.
4045
613052cd
BK
40462011-04-16 Ben Key <bkey76@gmail.com>
4047
4048 * nsfont.m: Fixed bugs in ns_get_family and
4049 ns_descriptor_to_entity that were caused by using free to
4050 deallocate memory blocks that were allocated by xmalloc (via
4051 xstrdup). This caused Emacs to crash when compiled with
4052 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4053 --enable-checking=xmallocoverrun). xfree is now used to
4054 deallocate these memory blocks.
4055
4170f62f 40562011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 4057
71b41406
PE
4058 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4059
9587a89d
PE
4060 emacs_write: Accept and return EMACS_INT for sizes.
4061 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4062 et seq.
4063 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4064 Accept and return EMACS_INT.
4065 (emacs_gnutls_write): Return the number of bytes written on
4066 partial writes.
4067 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
4068 (emacs_read, emacs_write): Remove check for negative size, as the
4069 Emacs source code has been audited now.
9587a89d
PE
4070 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4071 (emacs_read, emacs_write): Use it.
273a5f82
PE
4072 * process.c (send_process): Adjust to the new signatures of
4073 emacs_write and emacs_gnutls_write. Do not attempt to store
4074 a byte offset into an 'int'; it might overflow.
9587a89d 4075 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 4076
3e047f51
PE
4077 * sound.c: Don't assume sizes fit in 'int'.
4078 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 4079 Return EMACS_INT, not int.
3e047f51 4080 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
4081 Accept EMACS_INT, not int.
4082 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
4083 record read return values.
4084
cc39a9db
BK
40852011-04-15 Ben Key <bkey76@gmail.com>
4086
c9d0ec6d
JB
4087 * keyboard.c (Qundefined): Don't declare static since it is used
4088 in nsfns.m.
4089 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4090 static since they are used in nsfont.m.
cc39a9db 4091
6c60eb9f
SM
40922011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4093
4094 * process.c (Qprocessp): Don't declare static.
4095 * lisp.h (Qprocessp): Declare again.
4096
7990b61a
JB
40972011-04-15 Juanma Barranquero <lekktu@gmail.com>
4098
4099 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4100
5d4cb038
PE
41012011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4102
8bd7b830 4103 Improve C-level modularity by making more things 'static'.
cd64ea1d 4104
e3b27b31
PE
4105 Don't publish debugger-only interfaces to other modules.
4106 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4107 (verify_bytepos, count_markers): Move decls to the only modules
4108 that need them.
4109 * region-cache.h (pp_cache): Likewise.
4110 * window.h (check_all_windows): Likewise.
4111 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4112
5d4cb038
PE
4113 * sysdep.c (croak): Now static, if
4114 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4115 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
4116
4117 * alloc.c (refill_memory_reserve): Now static if
4118 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4119 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 4120
e87b6180
PE
4121 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4122 Define only if USE_LUCID.
4123
ac64929e
PE
4124 * xrdb.c (x_customization_string, x_rm_string): Now static.
4125
6f37259d
PE
4126 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4127 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4128
1683e3ab
PE
4129 * xdisp.c (draw_row_with_mouse_face): Now static.
4130 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4131
de9c2632
PE
4132 * window.h (check_all_windows): Mark externally visible.
4133
2b96acb7
PE
4134 * window.c (window_deletion_count): Now static.
4135
4136 * undo.c: Make symbols static if they're not exported.
4137 (last_undo_buffer, last_boundary_position, pending_boundary):
4138 Now static.
4139
50436f33
PE
4140 * textprop.c (interval_insert_behind_hooks): Now static.
4141 (interval_insert_in_front_hooks): Likewise.
4142
64520e5c
PE
4143 * term.c: Make symbols static if they're not exported.
4144 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4145 (max_frame_lines, tty_set_terminal_modes):
4146 (tty_reset_terminal_modes, tty_turn_off_highlight):
4147 (get_tty_terminal): Now static.
4148 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4149 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 4150 HAVE_WINDOW_SYSTEM.
64520e5c
PE
4151 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4152 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4153
1fa53021
PE
4154 * sysdep.c: Make symbols static if they're not exported.
4155 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4156 Now static.
4157 (sigprocmask_set, full_mask): Remove; unused.
4158 (wait_debugging): Mark as visible.
4159 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4160 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4161
d4b43b22
PE
4162 * syntax.c (syntax_temp): Define only if !__GNUC__.
4163
b7c513d0
PE
4164 * sound.c (current_sound_device, current_sound): Now static.
4165
989b29ad
PE
4166 * search.c (searchbufs, searchbuf_head): Now static.
4167
13a55a78
PE
4168 * scroll.c (scroll_cost): Remove; unused.
4169 * dispextern.h (scroll_cost): Remove decl.
4170
de68a1fc
PE
4171 * region-cache.h (pp_cache): Mark as externally visible.
4172
40ccffa6
PE
4173 * process.c: Make symbols static if they're not exported.
4174 (process_tick, update_tick, create_process, chan_process):
4175 (Vprocess_alist, proc_buffered_char, datagram_access):
4176 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4177 (deactivate_process): Mark defn as static, as well as decl.
4178 * lisp.h (create_process): Remove decl.
4179 * process.h (chan_process, Vprocess_alist): Remove decls.
4180
ad64fc97
PE
4181 * print.c: Make symbols static if they're not exported.
4182 (print_depth, new_backquote_output, being_printed, print_buffer):
4183 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4184 (print_interval, print_number_index, initial_stderr_stream):
4185 Now static.
4186 * lisp.h (Fprinc): Remove decl.
4187 (debug_output_compilation_hack): Mark as externally visible.
4188
adddb265
PE
4189 * sysdep.c (croak): Move decl from here to syssignal.h.
4190 * syssignal.h (croak): Put it here, so the API can be checked when
4191 'croak' is called from dissociate_if_controlling_tty.
4192
1717ede2
PE
4193 * minibuf.c: Make symbols static if they're not exported.
4194 (minibuf_save_list, choose_minibuf_frame): Now static.
4195 * lisp.h (choose_minibuf_frame): Remove decl.
4196
fa5fb2bc
PE
4197 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4198
1e3890d1
PE
4199 * lread.c: Make symbols static if they're not exported.
4200 (read_objects, initial_obarray, oblookup_last_bucket_number):
4201 Now static.
4202 (make_symbol): Remove; unused.
4203 * lisp.h (initial_obarray, make_symbol): Remove decls.
4204
8a1414fa
PE
4205 * keyboard.c: Make symbols static if they're not exported.
4206 (single_kboard, recent_keys_index, total_keys, recent_keys):
4207 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4208 (this_single_command_key_start, echoing, last_auto_save):
4209 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4210 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4211 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4212 (Vlispy_mouse_stem, double_click_count):
4213 Now static.
4214 (force_auto_save_soon): Define only if SIGDANGER.
4215 (ignore_mouse_drag_p): Now static if
4216 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4217 (print_help): Remove; unused.
4218 (stop_character, last_timer_event): Mark as externally visible.
4219 * keyboard.h (ignore_mouse_drag_p): Declare only if
4220 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4221 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4222 * lisp.h (echoing): Remove decl.
4223 (force_auto_save_soon): Declare only if SIGDANGER.
4224 * xdisp.c (redisplay_window): Simplify code, to make it more
4225 obvious that ignore_mouse_drag_p is not accessed if !defined
4226 USE_GTK && !defined HAVE_NS.
4227
93ea6e8f
PE
4228 * intervals.c: Make symbols static if they're not exported.
4229 (merge_properties_sticky, merge_interval_right, delete_interval):
4230 Now static.
4231 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4232
77382fcc
PE
4233 * insdel.c: Make symbols static if they're not exported.
4234 However, leave prepare_to_modify_buffer alone. It's never
4235 called from outside this function, but that appears to be a bug.
4236 (combine_after_change_list, combine_after_change_buffer):
4889fc82 4237 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
4238 (adjust_after_replace_noundo): Remove; unused.
4239 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 4240 (signal_before_change): Remove decls.
77382fcc 4241
9306c32e
PE
4242 * indent.c (val_compute_motion, val_vmotion): Now static.
4243
cd44d2eb
PE
4244 * image.c: Make symbols static if they're not exported.
4245 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4246 if USE_GTK.
4247 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4248 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4249
ad9a7a06
PE
4250 * fringe.c (standard_bitmaps): Now static.
4251 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4252
81626931
PE
4253 * frame.c: Make symbols static if they're not exported.
4254 (x_report_frame_params, make_terminal_frame): Now static.
4255 (get_frame_param): Now static, unless HAVE_NS.
4256 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4257 (x_get_resource_string): Remove; not used.
4258 * frame.h (make_terminal_frame, x_report_frame_params):
4259 (x_get_resource_string); Remove decls.
4260 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4261 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4262
239f9db9
PE
4263 * font.c, fontset.c: Make symbols static if they're not exported.
4264 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4265 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4266 * font.c (font_close_object): Now static.
4267 * font.h (font_close_object): Remove.
4268 * fontset.c (FONTSET_OBJLIST): Remove.
4269 (free_realized_fontset) #if-0 the body, which does nothing.
4270 (face_suitable_for_char_p): #if-0, as it's never called.
4271 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
4272 * xfaces.c (face_at_string_position):
4273 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
4274 since 0 is always ASCII.
4275
dfcf3579
PE
4276 * fns.c (weak_hash_tables): Now static.
4277
5045092b
PE
4278 * fileio.c: Make symbols static if they're not exported.
4279 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4280 (Vwrite_region_annotation_buffers): Now static.
4281
57a96f5c
PE
4282 * eval.c: Make symbols static if they're not exported.
4283 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4284 * lisp.h (backtrace_list): Remove decl.
4285
35f08c38
PE
4286 * emacs.c: Make symbols static if they're not exported.
4287 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4288 (fatal_error_code, fatal_error_signal_hook, standard_args):
4289 Now static.
4290 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4291 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4292 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4293 * lisp.h (fatal_error_signal_hook): Remove decl.
4294 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4295
f44bd759
PE
4296 * editfns.c: Move a (normally-unused) function to its only use.
4297 * editfns.c, lisp.h (get_operating_system_release): Remove.
4298 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4299 worth the hassle of breaking this out.
4300
b532497d
PE
4301 * xterm.c: Make symbols static if they're not exported.
4302 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4303 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4304 (x_destroy_window, x_delete_display):
4305 Now static.
4306 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4307 (x_mouse_leave): Remove; unused.
4308 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4309 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4310 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4311 Remove decls.
4312 (x_mouse_leave): Declare only if WINDOWSNT.
4313 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4314 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4315 USE_X_TOOLKIT.
4316
1675728f
PE
4317 * ftxfont.c: Make symbols static if they're not exported.
4318 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4319 HAVE_FREETYPE.
4320 * font.h (ftxfont_driver): Likewise.
4321
e4cebfca
PE
4322 * xfns.c: Make symbols static if they're not exported.
4323 (x_last_font_name, x_display_info_for_name):
4324 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4325 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4326 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4327 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4328 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4329 (last_show_tip_args): Now static.
4330 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4331 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4332 (x_screen_planes): Remove; unused.
4333 * dispextern.h (x_screen_planes): Remove decl.
4334
5bf46f05
PE
4335 * dispnew.c: Make symbols static if they're not exported.
4336 * dispextern.h (redraw_garbaged_frames, scrolling):
4337 (increment_row_positions): Remove.
4338 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4339 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4340 Now static.
4341 (redraw_garbaged_frames): Remove; unused.
4342
435f4c28
PE
4343 * xfaces.c: Make symbols static if they're not exported.
4344 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4345 Remove decls.
4346 * xterm.h (defined_color): Remove decls.
4347 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4348 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4349 (menu_face_changed_default, defined_color, free_realized_face):
4350 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4351 (ascii_face_of_lisp_face): Remove; unused.
4352
8524aef3
PE
4353 * xdisp.c: Make symbols static if they're not exported.
4354 * dispextern.h (scratch_glyph_row, window_box_edges):
4355 (glyph_to_pixel_coords, set_cursor_from_row):
4356 (get_next_display_element, set_iterator_to_next):
4357 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4358 (show_mouse_face): Remove decls
4359 * frame.h (message_buf_print): Likewise.
4360 * lisp.h (pop_message, set_message, check_point_in_composition):
4361 Likewise.
4362 * xterm.h (set_vertical_scroll_bar): Likewise.
4363 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4364 (message_buf_print, scratch_glyph_row, displayed_buffer):
4365 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4366 (get_next_display_element, show_mouse_face, window_box_edges):
4367 (frame_to_window_pixel_xy, check_point_in_composition):
4368 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4369 (glyph_to_pixel_coords): Remove; unused.
4370
16390cd2
PE
4371 * dired.c (file_name_completion): Now static.
4372
4373 * dbusbind.c (xd_in_read_queued_messages): Now static.
4374
a25f4dfa
PE
4375 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4376 * data.c (circular_list_error): Remove.
4377
14a9c8df
PE
4378 * commands.h (last_point_position, last_point_position_buffer):
4379 (last_point_position_window): Remove decls.
4380 * keyboard.c: Make these variables static.
4381
04f2d78b
CB
4382 * coding.h (coding, code_convert_region, encode_coding_gap):
4383 Remove decls.
74ab6df5
PE
4384 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4385 (iso_code_class, detect_coding, code_convert_region): Now static.
4386 (encode_coding_gap): Remove; unused.
4387
38dfbee1
PE
4388 * chartab.c (chartab_chars, chartab_bits): Now static.
4389
a2cb4e63
PE
4390 * charset.h (charset_iso_8859_1): Remove decl.
4391 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4392 Now static.
4393
127198fd
PE
4394 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4395 * ccl.c (Vccl_program_table): Now static.
4396 (check_ccl_update): Remove; unused.
4397
d85b608f
PE
4398 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4399 * category.h: ... from here.
4400 * category.c (check_category_table, set_category_set): Now static.
4401
31cd66f3
PE
4402 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4403 * lisp.h: Remove these decls.
4404
c358e587
PE
4405 * buffer.c (buffer_count): Remove unused var.
4406
e78aecca
PE
4407 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4408 so that it's not optimized away.
4409 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4410 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4411 exported only to the debugger.
4412
e192d7d3 4413 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 4414 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 4415
92470028
PE
4416 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4417 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4418 was inaccessible from Lisp.
4419 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4420 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4421
244ed907
PE
4422 alloc.c: Import and export fewer symbols, and remove unused items.
4423 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4424 is defined.
4425 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4426 it's not optimized away by whole-program optimization.
4427 (message_enable_multibyte, free_misc): Remove.
4428 (catchlist, handlerlist, mark_backtrace):
4429 Declare only if BYTE_MARK_STACK.
4430 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4431 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4432 (message_enable_multibyte): Remove decl.
4433 (free_misc, interval_free_list, float_block, float_block_index):
4434 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4435 (cons_free_list, last_marked_index):
4436 Now static.
4437 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4438 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4439 (mark_backtrace): Define only if BYTE_MARK_STACK.
4440 * xdisp.c (message_enable_multibyte): Now static.
4441
61c2b50e 4442 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
4443 This makes it easier for human readers (and static analyzers)
4444 to see whether these variables are used from other modules.
4445 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4446 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4447 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4448 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4449 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4450 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4451 * xmenu.c, xselect.c:
4452 Declare Q* vars static if they are not used in other modules.
4453 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4454 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4455 Remove decls of unexported vars.
4456 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4457
95c82688
PE
4458 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4459
16a97296
PE
4460 Make Emacs functions such as Fatom 'static' by default.
4461 This makes it easier for human readers (and static analyzers)
4462 to see whether these functions can be called from other modules.
4463 DEFUN now defines a static function. To make the function external
4464 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
4465 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4466 (Finit_image_library):
16a97296
PE
4467 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4468 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4469 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4470 Remove decls, since these functions are now static.
4471 (Funintern, Fget_internal_run_time): New decls, since these functions
4472 were already external.
95c82688 4473
16a97296
PE
4474 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4475 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4476 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4477 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4478 * keyboard.c, keymap.c, lread.c:
4479 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4480 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4481 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4482 Mark functions with DEFUE instead of DEFUN,
4483 if they are used in other modules.
4484 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4485 decls for now-static functions.
4486 * buffer.h (Fdelete_overlay): Remove decl.
4487 * callproc.c (Fgetenv_internal): Mark as internal.
4488 * composite.c (Fremove_list_of_text_properties): Remove decl.
4489 (Fcomposition_get_gstring): New forward static decl.
4490 * composite.h (Fcomposite_get_gstring): Remove decl.
4491 * dired.c (Ffile_attributes): New forward static decl.
4492 * doc.c (Fdocumntation_property): New forward static decl.
4493 * eval.c (Ffetch_bytecode): New forward static decl.
4494 (Funintern): Remove extern decl; now in .h file where it belongs.
4495 * fileio.c (Fmake_symbolic_link): New forward static decl.
4496 * image.c (Finit_image_library): New forward static decl.
4497 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4498 * intervals.h (Fprevious_property_change):
4499 (Fremove_list_of_text_properties): Remove decls.
4500 * keyboard.c (Fthis_command_keys): Remove decl.
4501 (Fcommand_execute): New forward static decl.
4502 * keymap.c (Flookup_key): New forward static decl.
4503 (Fcopy_keymap): Now static.
4504 * keymap.h (Flookup_key): Remove decl.
4505 * process.c (Fget_process): New forward static decl.
4506 (Fprocess_datagram_address): Mark as internal.
4507 * syntax.c (Fsyntax_table_p): New forward static decl.
4508 (skip_chars): Remove duplicate decl.
4509 * textprop.c (Fprevious_property_change): New forward static decl.
4510 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4511 Now internal.
4512 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4513 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4514
785bbd42
PE
4515 * editfns.c (Fformat): Remove unreachable code.
4516
8b913b57
AS
45172011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4518
4519 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4520 change. (Bug#8496)
4521
a6744a35
EZ
45222011-04-13 Eli Zaretskii <eliz@gnu.org>
4523
4524 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4525 when at ZV. (Bug#8487)
4526
e7974947
AS
45272011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4528
baad03f0
AS
4529 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4530 (Bug#8437)
4531 * keyboard.c (parse_tool_bar_item): Likewise.
4532 * sound.c (sound_cleanup, alsa_close): Likewise.
4533 * termcap.c (tgetent): Likewise.
4534 * xfns.c (x_default_font_parameter): Likewise.
4535 * xsettings.c (read_and_apply_settings): Likewise.
4536
e7974947
AS
4537 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4538 (overrun_check_free): Protoize.
4539
28272684
PE
45402011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4541
4542 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4543 since callers should never pass a negative size.
4544 Change the signature to match that of plain 'read' and 'write'; see
4545 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4546 * lisp.h: Update prototypes of emacs_write and emacs_read.
4547
11997c76
EZ
45482011-04-11 Eli Zaretskii <eliz@gnu.org>
4549
4550 * xdisp.c (redisplay_window): Don't try to determine the character
4551 position of the scroll margin if the window start point w->startp
e896f03c 4552 is outside the buffer's accessible region. (Bug#8468)
11997c76 4553
8a2cbd72
EZ
45542011-04-10 Eli Zaretskii <eliz@gnu.org>
4555
4556 Fix write-region and its subroutines for buffers > 2GB.
4557 * fileio.c (a_write, e_write): Modify declaration of arguments and
4558 local variables to support buffers larger than 2GB.
4559 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4560
4561 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4562 argument, local variables, and return value.
4563
4564 * lisp.h: Update prototypes of emacs_write and emacs_read.
4565
4566 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4567
4073e537 45682011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 4569
1ebfdcb6
PE
4570 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4571
b2ded58d
PE
4572 Fix more problems found by GCC 4.6.0's static checks.
4573
7d66342c
PE
4574 * xdisp.c (vmessage): Use a better test for character truncation.
4575
bbf47d44
PE
4576 * charset.c (load_charset_map): <, not <=, for optimization,
4577 and to avoid potential problems with integer overflow.
9248994d 4578 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 4579 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 4580 * editfns.c (Fformat): Likewise.
1e69125e 4581 * syntax.c (skip_chars): Likewise.
3befa583 4582
e3019616
PE
4583 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4584 This also lets GCC 4.6.0 generate slightly better loop code.
4585
becfa255
PE
4586 * callint.c (Fcall_interactively): <, not <=, for optimization.
4587 (Fcall_interactively): Count the number of arguments produced,
4588 not the number of arguments given. This is simpler and lets GCC
4589 4.6.0 generate slightly better code.
4590
dae0cd48
PE
4591 * ftfont.c: Distingish more carefully between FcChar8 and char.
4592 The previous code passed unsigned char * to a functions like
4593 strlen and xstrcasecmp that expect char *, which does not
4594 conform to the C standard.
4595 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4596 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4597 char * when the C standard requires it.
4598
76032d70
PE
4599 * keyboard.c (read_char): Remove unused var.
4600
eb3f1cc8
PE
4601 * eval.c: Port to Windows vsnprintf (Bug#8435).
4602 Include <limits.h>.
4603 (SIZE_MAX): Define if the headers do not.
4604 (verror): Do not give up if vsnprintf returns a negative count.
4605 Instead, grow the buffer. This ports to Windows vsnprintf, which
4606 does not conform to C99. Problem reported by Eli Zaretskii.
4607 Also, simplify the allocation scheme, by avoiding the need for
4608 calling realloc, and removing the ALLOCATED variable.
4609
70476b54
PE
4610 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4611
12020a9e
PE
4612 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4613 But keep the doprint source code for now, as we might revamp it
4614 and use it again (Bug#8435).
ea6c7ae6
PE
4615 * lisp.h (doprnt): Remove.
4616 * Makefile.in (base_obj): Remove doprnt.o.
4617 * deps.mk (doprnt.o): Remove.
4618
5fdb398c
PE
4619 error: Print 32- and 64-bit integers portably (Bug#8435).
4620 Without this change, on typical 64-bit hosts error ("...%d...", N)
4621 was used to print both 32- and 64-bit integers N, which relied on
4622 undefined behavior.
4623 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4624 New macro.
4625 * lisp.h (error, verror): Mark as printf-like functions.
4626 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4627 Report overflow in size calculations when allocating printf buffer.
4628 Do not truncate output string at its first null byte.
4629 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4630 Truncate the output at a character boundary, since vsnprintf does not
4631 do that.
4632 * charset.c (check_iso_charset_parameter): Convert internal
4633 character to string before calling 'error', since %c now has the
4634 printf meaning.
4635 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4636 overflow when computing char to be passed to 'error'. Do not
4637 pass Lisp_Object to 'error'; pass the integer instead.
4638 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4639 formatted with plain %d.
4640
b189fa66
PE
4641 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4642
bff87ef0
PE
4643 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4644
7e2cac20
PE
4645 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4646
ce4d90b5
PE
4647 * xterm.c (x_catch_errors): Remove duplicate declaration.
4648
266c9547
PE
4649 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4650
79c49ad2
PE
4651 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4652
368f4090
JM
46532011-04-10 Jim Meyering <meyering@redhat.com>
4654
4655 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4656 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4657 return ssize_t not "int", and use size_t as the buffer length.
4658 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4659 * gnutls.h: Update declarations.
4660 * process.c (read_process_output): Use ssize_t, to match.
4661 (send_process): Likewise.
4662
a32d4040
CY
46632011-04-09 Chong Yidong <cyd@stupidchicken.com>
4664
4665 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4666
8546720e 46672011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 4668
04f2d78b
CB
4669 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4670 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 4671
8546720e
GM
4672 * xterm.c (handle_one_xevent):
4673 * xmenu.c (create_and_show_popup_menu):
4674 * xselect.c (x_decline_selection_request)
4675 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 4676
0a2f5c1a 46772011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
4678
4679 Fix some uses of `int' instead of EMACS_INT.
4680 * search.c (string_match_1, fast_string_match)
4681 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4682 (scan_buffer, find_next_newline_no_quit)
4683 (find_before_next_newline, search_command, Freplace_match)
4684 (Fmatch_data): Make some `int' variables be EMACS_INT.
4685
4686 * xdisp.c (display_count_lines): 3rd argument and return value now
4687 EMACS_INT. All callers changed.
4688 (pint2hrstr): Last argument is now EMACS_INT.
4689
4690 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4691 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4692 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4693 (decode_coding_utf_16, decode_coding_emacs_mule)
4694 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4695 (decode_coding_ccl, decode_coding_charset)
4696 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4697 (decode_coding_iso_2022, decode_coding_emacs_mule)
4698 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4699 <char_offset, last_offset>: Declare EMACS_INT.
4700 (encode_coding_utf_8, encode_coding_utf_16)
4701 (encode_coding_emacs_mule, encode_invocation_designation)
4702 (encode_designation_at_bol, encode_coding_iso_2022)
4703 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4704 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4705 Declare EMACS_INT.
4706 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4707 (encode_invocation_designation): Last argument P_NCHARS is now
4708 EMACS_INT.
4709 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4710 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4711
4712 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4713 All users changed.
4714
4715 * ccl.c (Fccl_execute_on_string): Declare some variables
4716 EMACS_INT.
4717
8546720e 47182011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
4719
4720 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4721
4e19a977
CS
47222011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4723
4724 * process.c (Fformat_network_address): Doc fix.
4725
87302331
R
47262011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4727
4728 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4729
cbb59342
CY
47302011-04-08 Chong Yidong <cyd@stupidchicken.com>
4731
4732 * keyboard.c (read_char): Call Lisp function help-form-show,
4733 instead of using internal_with_output_to_temp_buffer.
4734 (Qhelp_form_show): New var.
e0d38eeb 4735 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
4736
4737 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4738
4739 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4740
e67a13ab
CY
47412011-04-06 Chong Yidong <cyd@stupidchicken.com>
4742
04f2d78b
CB
4743 * process.c (Flist_processes): Remove to Lisp.
4744 (list_processes_1): Delete.
e67a13ab 4745
973f782d
EZ
47462011-04-06 Eli Zaretskii <eliz@gnu.org>
4747
7c106b1e
EZ
4748 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4749
973f782d
EZ
4750 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4751
41cf7d1a 47522011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 4753
ca23cc88
PE
4754 Fix more problems found by GCC 4.6.0's static checks.
4755
f390e2d5
PE
4756 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4757
42eea0d0
PE
4758 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4759
b69769da 4760 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 4761
f9541e84
PE
4762 * xdisp.c (vmessage): Mark as a printf-like function.
4763
13841b55
PE
4764 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4765
c136c10f
PE
4766 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4767
5e2d4a30
PE
4768 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4769 printf-like functions.
4770 (tiff_load): Add casts to remove these marks before passing them
4771 to system-supplied API.
4772
583f48b9
PE
4773 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4774
b25d760e
PE
4775 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4776 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
4777 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4778 directly, rather than having caller test rule sign. This avoids
4779 some unnecessary tests.
4780 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4781 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4782 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 4783
bc7b6697 4784 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 4785 (xfont_open): Avoid unnecessary tests.
bc7b6697 4786
27ccc379
PE
4787 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4788
dcd5c89a
PE
4789 * composite.h, composite.c (composition_gstring_put_cache):
4790 Use EMACS_INT, not int, for length.
4791
b13a45c6
PE
4792 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4793 breaking out part of COMPOSITION_DECODE_RULE.
4794 (COMPOSITION_DECODE_RULE): Use it.
4795 * composite.c (get_composition_id): Remove unused local vars,
4796 by using the new macro.
4797
1e792e4d
PE
4798 * textprop.c (set_text_properties_1): Change while to do-while,
4799 since the condition is always true at first.
4800
dc6c6455 4801 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
4802 (interval_deletion_adjustment): Return unsigned value.
4803 All uses changed.
dc6c6455 4804
aba7731a
PE
4805 * process.c (list_processes_1, create_pty, read_process_output):
4806 (exec_sentinel): Remove vars that were set but not used.
afd4052b 4807 (create_pty): Remove unnecessary "volatile"s.
bc57d757 4808 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 4809 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 4810 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 4811
fdfc4bf3
PE
4812 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4813
fca8fe46 4814 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 4815 (update_syntax_table): Use unsigned instead of int.
fca8fe46 4816
06a0259a 4817 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 4818 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 4819 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 4820
e7b9e80f
PE
4821 * print.c (print_error_message): Avoid int overflow.
4822
56201685
PE
4823 * font.c (font_list_entities): Redo for clarity,
4824 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4825
78834453 4826 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 4827 (font_score): Avoid potential overflow in diff calculation.
78834453 4828
0bc0b309 4829 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 4830 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 4831
e610eaca
PE
4832 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4833
b895abce
PE
4834 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4835 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4836 can always succeed if overflow has undefined behavior.
4837
1f1d9321 4838 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 4839 (wordify): Omit three unnecessary tests.
1f1d9321 4840
c59478bc
PE
4841 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4842 All callers changed. This avoids the need for an unused var.
4843
79b73827
PE
4844 * casefiddle.c (casify_region): Remove var that is set but not used.
4845
a4db5dfe
PE
4846 * dired.c (file_name_completion): Remove var that is set but not used.
4847
43aae36e
PE
4848 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4849
2a47c44d 4850 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 4851 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 4852
a37c69bf
PE
4853 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4854 Check for integer overflow on size calculations.
4855
328ab8e7
PE
4856 * buffer.c (Fprevious_overlay_change): Remove var that is set
4857 but not used.
4858
e5a2a5cb
PE
4859 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4860 Remove vars that are set but not used.
8d84a6eb 4861 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 4862 (timer_check_2): Mark vars as initialized.
e5a2a5cb 4863
a60e5f68
PE
4864 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4865
f661cb61 4866 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 4867 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 4868
f0397f5a
PE
4869 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
4870 that are set but not used.
4871
8664db06 4872 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 4873 if XCreateBitmapFromData fails (Bug#8410).
8664db06 4874
6abdaa4a
PE
4875 * xselect.c (x_get_local_selection, x_handle_property_notify):
4876 Remove vars that are set but not used.
4877
0ce7538d 4878 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 4879 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 4880
9ae848fc
PE
4881 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
4882 Remove var that is set but not used.
0b918413
PE
4883 (scroll_bar_windows_size): Now size_t, not int.
4884 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
4885 Check for overflow.
9ae848fc 4886
a5a62657
PE
4887 * xfaces.c (realize_named_face): Remove vars that are set but not used.
4888 (map_tty_color) [!defined MSDOS]: Likewise.
4889
5c5cdd39
PE
4890 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
4891
66ebf983
PE
4892 * coding.c: Remove vars that are set but not used.
4893 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
4894 All callers changed.
4895 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
4896 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
4897 (decode_coding_charset): Remove vars that are set but not used.
4898
1be4d761
PE
4899 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
4900 that is set but not used.
4901
47553fa8
PE
4902 * print.c (print_object): Remove var that is set but not used.
4903
1f7196bf 4904 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
4905 The gnulib version avoids calling malloc in the usual case,
4906 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
4907 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
4908 * filelock.c (current_lock_owner): Likewise.
4909 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
4910 * sysdep.c: Include allocator.h, careadlinkat.h.
4911 (emacs_no_realloc_allocator): New static constant.
4912 (emacs_readlink): New function.
fdb61804
PE
4913 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
4914 ../lib/careadlinkat.h.
d1fdcab7 4915
f84c17c7
SM
49162011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
4917
4918 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
4919 first non-nil return value).
4920
ef3862ad
JD
49212011-04-03 Jan Djärv <jan.h.d@swipnet.se>
4922
4923 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
4924 if not defined (Bug#8403).
4925
376a7006
JB
49262011-04-02 Juanma Barranquero <lekktu@gmail.com>
4927
4928 * xdisp.c (display_count_lines): Remove parameter `start',
4929 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4930 (get_char_face_and_encoding): Remove parameter `multibyte_p',
4931 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4932 (fill_stretch_glyph_string): Remove parameters `row' and `area',
4933 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
4934 and thereabouts. All callers changed.
4935 (get_per_char_metric): Remove parameter `f', unused since
4936 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4937
6ca3801d
JM
49382011-04-02 Jim Meyering <meyering@redhat.com>
4939
4940 do not dereference NULL upon failed strdup
4941 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
4942 (ns_get_family): Likewise.
4943
d8e2b5ba
JB
49442011-04-02 Juanma Barranquero <lekktu@gmail.com>
4945
4946 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
4947
8c74fcbd
JD
49482011-04-02 Jan Djärv <jan.h.d@swipnet.se>
4949
4950 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
4951 later (Bug#8403).
4952
7200d79c
SM
49532011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
4954
03408648 4955 Add lexical binding.
7200d79c 4956
03408648
SM
4957 * window.c (Ftemp_output_buffer_show): New fun.
4958 (Fsave_window_excursion):
4959 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
4960
4961 * lread.c (lisp_file_lexically_bound_p): New function.
4962 (Fload): Bind Qlexical_binding.
4963 (readevalloop): Remove `evalfun' arg.
4964 Bind Qinternal_interpreter_environment.
4965 (Feval_buffer): Bind Qlexical_binding.
4966 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
4967 Mark as dynamic.
4968 (syms_of_lread): Declare `lexical-binding'.
4969
4970 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
4971
4972 * keyboard.c (eval_dyn): New fun.
4973 (menu_item_eval_property): Use it.
ca105506
SM
4974
4975 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 4976
03408648
SM
4977 * fns.c (concat, mapcar1): Accept byte-code-functions.
4978
4979 * eval.c (Fsetq): Handle lexical vars.
4980 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
4981 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
4982 (FletX, Flet): Obey lexical binding.
4983 (Fcommandp): Handle closures.
4984 (Feval): New `lexical' arg.
4985 (eval_sub): New function extracted from Feval. Use it almost
4986 everywhere where Feval was used. Look up vars in lexical env.
4987 Handle closures.
4988 (Ffunctionp): Move from subr.el.
4989 (Ffuncall): Handle closures.
4990 (apply_lambda): Remove `eval_flags'.
4991 (funcall_lambda): Handle closures and new byte-code-functions.
4992 (Fspecial_variable_p): New function.
4993 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
4994 but without exporting it to Lisp.
23aba0ea 4995
23aba0ea 4996 * doc.c (Fdocumentation, store_function_docstring):
03408648 4997 * data.c (Finteractive_form): Handle closures.
23aba0ea 4998
03408648
SM
4999 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5000 interactive spec.
ba83908c 5001
04f2d78b
CB
5002 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5003 New byte-codes.
03408648
SM
5004 (exec_byte_code): New function extracted from Fbyte_code to handle new
5005 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 5006
03408648 5007 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 5008
03408648 5009 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 5010
e2abce01
JB
50112011-03-31 Juanma Barranquero <lekktu@gmail.com>
5012
5013 * xdisp.c (redisplay_internal): Fix prototype.
5014
63696a73 50152011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 5016
63696a73 5017 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
5018 (try_scrolling): Use it when setting scroll_limit.
5019 Limit scrolling to 100 screen lines.
63696a73
EZ
5020 (redisplay_window): Even when falling back on "recentering",
5021 position point in the window according to scroll-conservatively,
5022 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5023
5024 (try_scrolling): When point is above the window, allow searching
5025 as far as scroll_max, or one screenful, to compute vertical
5026 distance from PT to the scroll margin position. This prevents
5027 try_scrolling from unnecessarily failing when
5028 scroll-conservatively is set to a value slightly larger than the
5029 window height. Clean up the case of PT below the margin at bottom
5030 of window: scroll_max can no longer be INT_MAX. When aggressive
5031 scrolling is in use, don't let point enter the opposite scroll
5032 margin as result of the scroll.
5033 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
5034 threshold of 100 lines for never-recentering scrolling.
5035
e4cc2dfc
JB
50362011-03-31 Juanma Barranquero <lekktu@gmail.com>
5037
5038 * dispextern.h (move_it_by_lines):
5039 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5040 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5041 (message_log_check_duplicate): Remove parameters `prev_bol' and
5042 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5043 (redisplay_internal): Remove parameter `preserve_echo_area',
5044 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5045
5046 * indent.c (Fvertical_motion):
5047 * window.c (window_scroll_pixel_based, Frecenter):
5048 Don't pass `need_y_p' to `move_it_by_lines'.
5049
1c470562
SM
50502011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5051
44f230aa
SM
5052 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5053 steal a few bits to be more compact.
5054 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5055 Remove unneeded casts.
5056
1c470562
SM
5057 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5058
888adce9
ZK
50592011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5060
5061 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5062 binding" message (bug#7967).
5063
f838ed7b
PE
50642011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5065
77861b95
PE
5066 Fix more problems found by GCC 4.6.0's static checks.
5067
de6dbc14
PE
5068 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5069 Remove unused local var.
5070
f838ed7b
PE
5071 * editfns.c (Fmessage_box): Remove unused local var.
5072
792c7b2b
PE
5073 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5074 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5075 Omit unused local vars.
c499e557 5076 * window.c (shrink_windows): Omit unused local var.
b01a1c29 5077 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
5078 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5079 Omit unused local var.
5080
ba0165e1
PE
5081 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5082 Don't assume string length fits in int.
32ad8845 5083 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 5084 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 5085
3c59b4c9
PE
5086 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5087 instead of alloca (Bug#8344).
5088
a3eed478 5089 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 5090 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 5091
eb4d412d
PE
5092 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5093
1658b401
PE
5094 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5095 concerns.
5096
5097 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5098
5099 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 5100
9a2c6e05
PE
5101 * keyboard.c (syms_of_keyboard): Use the same style as later
5102 in this function when indexing through an array. This also
5103 works around GCC bug 48267.
5104
03d0a109
PE
5105 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5106
44f730c8
PE
5107 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5108
fe75f926
PE
5109 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5110 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5111
ffa8c828
PE
5112 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5113 This avoids undefined behavior on integer overflow, and is a bit
5114 more convenient anyway since it is compared to a size_t variable.
5115
c5101a77
PE
5116 Variadic C functions now count arguments with size_t, not int.
5117 This avoids an unnecessary limitation on 64-bit machines, which
5118 caused (substring ...) to crash on large vectors (Bug#8344).
5119 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5120 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 5121 All variadic functions and their callers changed accordingly.
c5101a77
PE
5122 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5123 * data.c (arith_driver, float_arith_driver): Likewise.
5124 * editfns.c (general_insert_function): Likewise.
5125 * eval.c (struct backtrace.nargs, interactive_p)
5126 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5127 (funcall_lambda, mark_backtrace): Likewise.
5128 * fns.c (concat): Likewise.
5129 * frame.c (x_set_frame_parameters): Likewise.
5130 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5131 0 if not found, not -1. All callers changed.
5132
dd3f25f7
PE
5133 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5134 (stack_copy_size): Now size_t, not int.
5135 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5136
461c2ab9
JB
51372011-03-28 Juanma Barranquero <lekktu@gmail.com>
5138
5139 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5140 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5141 All callers changed.
5142
5143 * lisp.h (multibyte_char_to_unibyte):
5144 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5145 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5146 * character.h (CHAR_TO_BYTE8):
5147 * cmds.c (internal_self_insert):
5148 * editfns.c (general_insert_function):
5149 * keymap.c (push_key_description):
5150 * search.c (Freplace_match):
5151 * xdisp.c (message_dolog, set_message_1): All callers changed.
5152
f6d62986
SM
51532011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5154
5155 * keyboard.c (safe_run_hook_funcall): New function.
5156 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5157 don't set the hook to nil, but remove the offending function instead.
5158 (Qcommand_hook_internal): Remove, unused.
5159 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5160 Vcommand_hook_internal.
5161
5162 * eval.c (enum run_hooks_condition): Remove.
5163 (funcall_nil, funcall_not): New functions.
5164 (run_hook_with_args): Call each function through a `funcall' argument.
5165 Remove `cond' argument, now redundant.
5166 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5167 (Frun_hook_with_args_until_failure): Adjust accordingly.
5168 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5169
1db5b1ad
JB
51702011-03-28 Juanma Barranquero <lekktu@gmail.com>
5171
5172 * dispextern.h (string_buffer_position): Remove declaration.
5173
5174 * print.c (strout): Remove parameter `multibyte', unused since
5175 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5176
5177 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5178 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5179 All callers changed.
5180
5181 * w32.c (_wsa_errlist): Use braces for struct initializers.
5182
5183 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5184 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5185 All callers changed.
5186 (string_buffer_position): Likewise. Also, make static (it's never
5187 used outside xdisp.c).
5188 (cursor_row_p): Remove parameter `w', unused since
5189 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5190 (decode_mode_spec): Remove parameter `precision', introduced during
5191 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5192 All callers changed.
5193
5ffb62aa
JD
51942011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5195
5196 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5197
461c2ab9 51982011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
5199
5200 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5201 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5202 (ns_update_auto_hide_menu_bar): New functions.
5203 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5204 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5205 ns_constrain_all_frames.
5206 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5207 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5208
5c380ffb
JD
52092011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5210
5211 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5212
9af30bdf
GM
52132011-03-27 Glenn Morris <rgm@gnu.org>
5214
5215 * syssignal.h: Replace RETSIGTYPE with void.
5216 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5217 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5218 Replace SIGTYPE with void everywhere.
5219 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5220 * s/template.h (SIGTYPE): Remove commented out definition.
5221
e2abce01
JB
52222011-03-26 Eli Zaretskii <eliz@gnu.org>
5223
5224 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5225 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5226
f868cd8a
JB
52272011-03-26 Juanma Barranquero <lekktu@gmail.com>
5228
59eb0929
JB
5229 * w32.c (read_unc_volume): Use parameter `henum', instead of
5230 global variable `wget_enum_handle'.
5231
5232 * keymap.c (describe_vector): Remove parameters `indices' and
5233 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5234 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5235
f868cd8a
JB
5236 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5237
5238 * keyboard.c (timer_check): Remove parameter `do_it_now',
5239 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5240 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5241 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5242
5243 * keyboard.c (read_char):
5244 * w32menu.c (w32_menu_display_help):
5245 * xmenu.c (show_help_event, menu_help_callback):
5246 Adjust calls to `show_help_echo'.
5247
5248 * gtkutil.c (xg_maybe_add_timer):
5249 * keyboard.c (readable_events):
5250 * process.c (wait_reading_process_output):
5251 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5252
5253 * insdel.c (adjust_markers_gap_motion):
5254 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5255 (gap_left, gap_right): Don't call it.
5256
2ecf6fdb
CY
52572011-03-25 Chong Yidong <cyd@stupidchicken.com>
5258
5259 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5260 incurred during fontification.
5261
6b1f9ba4
JB
52622011-03-25 Juanma Barranquero <lekktu@gmail.com>
5263
5264 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5265 (DEFVAR_PER_BUFFER): Don't pass it.
5266
5267 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5268 (scrolling_window): Don't pass it.
5269
0f4a96b5
JB
52702011-03-25 Juanma Barranquero <lekktu@gmail.com>
5271
5272 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5273
5274 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5275 and `suffix'.
5276 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5277 of variables specific to SELinux and computation of `encoded_absname'.
5278
5279 * image.c (XPutPixel): Remove unused variable `height'.
5280
5281 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5282
5283 * unexw32.c (get_section_info): Remove unused variable `section'.
5284
5285 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5286 (system_process_attributes): Remove unused variable `sess'.
5287 (sys_read): Remove unused variable `err'.
5288
5289 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5290 (w32_wnd_proc): Remove unused variable `isdead'.
5291 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5292 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5293 (x_create_tip_frame): Remove unused variable `tem'.
5294
5295 * w32inevt.c (w32_console_read_socket):
5296 Remove unused variable `no_events'.
5297
5298 * w32term.c (x_draw_composite_glyph_string_foreground):
5299 Remove unused variable `width'.
5300
1149507c
JB
53012011-03-24 Juanma Barranquero <lekktu@gmail.com>
5302
5303 * w32term.c (x_set_glyph_string_clipping):
5304 Don't pass uninitialized region to CombineRgn.
5305
9c88f339
JB
53062011-03-23 Juanma Barranquero <lekktu@gmail.com>
5307
5308 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5309 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5310 (Fx_close_connection): Remove unused variable `i'.
5311
5312 * w32font.c (w32font_draw): Return number of glyphs.
5313 (w32font_open_internal): Remove unused variable `i'.
5314 (w32font_driver): Add missing initializer.
5315
5316 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5317 (fill_in_menu): Remove unused variable `items_added'.
5318
5319 * w32term.c (last_mouse_press_frame): Remove static global variable.
5320 (w32_clip_to_row): Remove unused variable `f'.
5321 (x_delete_terminal): Remove unused variable `i'.
5322
5323 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5324 (NOTHING): Remove unused static global variable.
5325 (uniscribe_check_otf): Remove unused variable `table'.
5326 (uniscribe_font_driver): Add missing initializers.
5327
dee091a3
JD
53282011-03-23 Julien Danjou <julien@danjou.info>
5329
5330 * term.c (Fsuspend_tty, Fresume_tty):
5331 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5332 * window.c (temp_output_buffer_show):
5333 * insdel.c (signal_before_change):
5334 * frame.c (Fhandle_switch_frame):
5335 * fileio.c (Fdo_auto_save):
5336 * emacs.c (Fkill_emacs):
5337 * editfns.c (save_excursion_restore):
5338 * cmds.c (internal_self_insert):
5339 * callint.c (Fcall_interactively):
5340 * buffer.c (Fkill_all_local_variables):
5341 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5342 Use Frun_hooks.
0f4a96b5 5343 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
5344 unconditionnaly since it does the check itself.
5345
2c520ab5 53462011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 5347
c9c49752
PE
5348 Fix more problems found by GCC 4.5.2's static checks.
5349
8abc3f12
PE
5350 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5351 the first time through the loop, since we know p0 < p1 then.
5352 This also avoids a gcc -Wstrict-overflow warning.
5353
a2d26660
PE
5354 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5355 leading to a memory leak, possible in functions like
5356 load_charset_map_from_file that can allocate an unbounded number
b12ef411 5357 of objects (Bug#8318).
a2d26660 5358
916c72e9
PE
5359 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5360 that could (at least in theory) be that large.
5361
19ab8a18
PE
5362 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5363 This is less likely to overflow, and avoids undefined behavior if
5364 overflow does occur. All callers changed. Use strtoul to scan
5365 for the unsigned long integer.
b7cbbd6f
PE
5366 (pint2hrstr): Simplify and tune code slightly.
5367 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 5368
f0641eff
PE
5369 * scroll.c (do_scrolling): Work around GCC bug 48228.
5370 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5371
7f650bb9
PE
5372 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5373 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
5374 (validate_x_resource_name): Simplify count usage.
5375 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 5376
37dd57d1
PE
5377 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5378 fail (Bug#8306).
81e56e61 5379
699979fc 5380 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 5381
401bf9b4
PE
5382 * process.c (Fmake_network_process): Use socklen_t, not int,
5383 where POSIX says socklen_t is required in portable programs.
5384 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 5385 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
5386 (Fmake_network_process, server_accept_connection):
5387 (wait_reading_process_output, read_process_output):
5388 Likewise.
5389
b93aacde
PE
5390 * process.c: Rename or move locals to avoid shadowing.
5391 (list_processes_1, Fmake_network_process):
5392 (read_process_output_error_handler, exec_sentinel_error_handler):
5393 Rename or move locals.
4dc343ee 5394 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 5395 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 5396 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 5397 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 5398 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 5399
af8a867c 5400 Make tparam.h and terminfo.c consistent.
44f230aa
SM
5401 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5402 Include tparam.h instead, since it declares them.
af8a867c
PE
5403 * cm.h (PC): Remove extern decl; tparam.h now does this.
5404 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5405 * terminfo.c: Include tparam.h, to check interfaces.
5406 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5407 (tparam): Adjust signature to match interface in tparam.h;
5408 this removes some undefined behavior. Check that outstring and len
5409 are zero, which they always are with Emacs.
5410 * tparam.h (PC, BC, UP): New extern decls.
5411
0248044d 5412 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 5413 (xftfont_open): Rename locals to avoid shadowing.
0248044d 5414
8ff096c1 5415 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
5416 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5417 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 5418 (ftfont_list): Remove unused local.
49eaafba
PE
5419 (get_adstyle_property, ftfont_pattern_entity):
5420 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5421 Rename locals to avoid shadowing.
8ff096c1 5422
e2be39f6
PE
5423 * xfont.c (xfont_list_family): Mark var as initialized.
5424
c9735e30
PE
5425 * xml.c (make_dom): Now static.
5426
8f5201ae
PE
5427 * composite.c (composition_compute_stop_pos): Rename local to
5428 avoid shadowing.
b246f932
PE
5429 (composition_reseat_it): Remove unused locals.
5430 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 5431 (composition_update_it): Mark var as initialized.
11b61122
PE
5432 (find_automatic_composition): Mark vars as initialized,
5433 with a FIXME (Bug#8290).
8f5201ae 5434
760fbc2c
PE
5435 character.h: Rename locals to avoid shadowing.
5436 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5437 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5438 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5439 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5440 to avoid shadowing.
5441
ff08eb85
PE
5442 * textprop.c (property_change_between_p): Remove; unused.
5443
fc7bf025
PE
5444 * intervals.c (interval_start_pos): Now static.
5445
235d7abc
PE
5446 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5447
44f230aa
SM
5448 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5449 Rename locals to avoid shadowing.
3e7d6594 5450
50060332
PE
5451 * sound.c (wav_play, au_play, Fplay_sound_internal):
5452 Fix pointer signedness.
d01f234b 5453 (alsa_choose_format): Remove unused local var.
c83b8872
PE
5454 (wav_play): Initialize a variable to 0, to prevent undefined
5455 behavior (Bug#8278).
50060332 5456
c4fc4e30
PE
5457 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5458
918436ed
PE
5459 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5460
c939f91b
PE
5461 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5462 clobbering (Bug#8298).
b9c7f648
PE
5463 * sysdep.c (sys_subshell): Likewise.
5464 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 5465
6bd8c144
PE
5466 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5467 This should get cleaned up, so that child_setup has the
5468 same signature on all platforms.
5469
7710357c 5470 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 5471 (relocate_fd): Rename locals to avoid shadowing.
7710357c 5472
c59da222
CY
54732011-03-22 Chong Yidong <cyd@stupidchicken.com>
5474
5475 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5476 not to be necessary, and produces flickering.
5477
66b87493
GM
54782011-03-20 Glenn Morris <rgm@gnu.org>
5479
5480 * config.in: Remove file.
5481
45b6f6d5
JB
54822011-03-20 Juanma Barranquero <lekktu@gmail.com>
5483
5484 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5485 are now in src/globals.h.
5486 (syms_of_minibuf): Remove spurious & from previous change.
5487
3ec03f7e
LL
54882011-03-20 Leo <sdl.web@gmail.com>
5489
5490 * minibuf.c (completing-read-function): New variable.
5491 (completing-read-default): Rename from completing-read.
5492 (completing-read): Call completing-read-function.
5493
b14e3e21
CY
54942011-03-19 Juanma Barranquero <lekktu@gmail.com>
5495
5496 * xfaces.c (Fx_load_color_file):
5497 Read color file from absolute filename (bug#8250).
5498
f2b726e6
JB
54992011-03-19 Juanma Barranquero <lekktu@gmail.com>
5500
5501 * makefile.w32-in: Update dependencies.
5502
09f6ff02
EZ
55032011-03-17 Eli Zaretskii <eliz@gnu.org>
5504
5505 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5506
29a6015a
PE
55072011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5508
a3a6c54e
PE
5509 Fix more problems found by GCC 4.5.2's static checks.
5510
b766f867
PE
5511 * process.c (make_serial_process_unwind, send_process_trap):
5512 (sigchld_handler): Now static.
5513
be02381c
PE
5514 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5515 That way, the code declares only the vars that it needs.
5516 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5517 * s/cygwin.h (PTY_ITERATION): Likewise.
5518 * s/darwin.h (PTY_ITERATION): Likewise.
5519 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5520
57048744
PE
5521 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5522 * process.c (allocate_pty): Don't declare stb unless it's needed.
5523
7914961c 5524 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
5525 (CONSTANTLIM): Remove; unused.
5526 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5527 Define only if needed.
7914961c 5528
b3967b18
PE
5529 * unexelf.c (unexec): Name an expression,
5530 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
5531 Use a different way to cause a compilation error if anyone uses
5532 n rather than nn, a way that does not involve shadowing.
73366a00 5533 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 5534
29a6015a
PE
5535 * deps.mk (unexalpha.o): Remove; unused.
5536
43cfc33e 5537 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 5538 * unexec.h: New file.
ce701a33
PE
5539 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5540 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5541 Depend on unexec.h.
5542 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5543 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5544 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 5545 Change as necessary to match prototype in unexec.h.
ce701a33 5546
01f44d5a
PE
5547 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5548 shadowing.
4f63c6bb 5549 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 5550
a6670b0b
PE
5551 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5552 Rename locals to avoid shadowing.
5553
cef2010d 5554 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 5555 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 5556
d4d7173a
PE
5557 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5558
f08b802a
PE
5559 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5560 warning when compiling print.c.
5561
3ddb0639
PE
5562 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5563 instead of using an uninitialized var.
5ad03b97 5564 (font_sort_entities): Mark var as initialized.
3ddb0639 5565
170a2692
PE
5566 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5567
e663c700
PE
5568 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5569 pointers to constants.
89bc529a 5570 (font_parse_fcname): Remove unused vars.
7b81e2d0 5571 (font_delete_unmatched): Now static.
ea838e10 5572 (font_get_spec): Remove; unused.
13a547c6
PE
5573 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5574 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5575 Rename or move locals to avoid shadowing.
e663c700 5576
2a80c887 5577 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 5578 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 5579
1384fa33 5580 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 5581 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 5582
8b2c52e9
PE
5583 * alloc.c (mark_backtrace): Move decl from here ...
5584 * lisp.h: ... to here, so that it can be checked.
5585
475545b5 5586 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 5587 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
5588 (lisp_indirect_variable): Name an expression,
5589 to avoid gcc -Wbad-function-cast warning.
1faed8ae 5590 (Fdefvar): Rename locals to avoid shadowing.
475545b5 5591
b1349114 5592 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 5593 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 5594 Use const pointer when appropriate.
b1349114 5595
a2928364
PE
5596 * lisp.h (get_system_name, get_operating_system_release):
5597 Move decls here, to check interfaces.
5598 * process.c (get_operating_system_release): Move decl to lisp.h.
5599 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
5600 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5601 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5602 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
5603 (Fformat_time_string, Fencode_time, Finsert_char):
5604 (Ftranslate_region_internal, Fformat):
5605 Rename or remove local vars to avoid shadowing.
9710023e 5606 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 5607
a415e694
PE
5608 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5609 avoid shadowing.
5610
8ef4622d
PE
5611 * lisp.h (eassert): Check that the argument compiles, even if
5612 ENABLE_CHECKING is not defined.
5613
946f9a5b
PE
5614 * data.c (Findirect_variable): Name an expression, to avoid
5615 gcc -Wbad-function-cast warning.
112396d6 5616 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 5617 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
5618 (Fmake_variable_buffer_local, Fmake_local_variable):
5619 Mark variables as initialized.
52746918 5620 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 5621
e5aab7e7 5622 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
5623 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5624 Rename locals to avoid shadowing.
dff45157
PE
5625 (mark_stack): Move local variables into the #ifdef region where
5626 they're used.
7bc26fdb
PE
5627 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5628 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5629 needed otherwise.
5630 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5631 (GC_STRING_CHARS): Remove; not used.
d40d4be1 5632 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 5633
e5aab7e7
PE
5634 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5635 avoids undefined behavior in theory.
5636
4da60324
PE
5637 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5638
88043301
PE
5639 Use functions, not macros, for up- and down-casing (Bug#8254).
5640 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5641 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5642 to use the following functions instead of these macros.
5643 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5644 EMACS_INT, since callers assume the returned value fits in int.
5645 (upcase1): Likewise, for UPCASE_TABLE.
5646 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 5647 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 5648 the race-condition problem in the old DOWNCASE.
88043301 5649
19ed5445
PE
5650 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5651 Rename locals to avoid shadowing.
5652 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
5653 (regex_compile, re_search_2, re_match_2_internal):
5654 Remove unused local vars.
952db0d7
PE
5655 (FREE_VAR): Rewrite so as not to use empty "else",
5656 which gcc can warn about.
da053e48 5657 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
5658 (RETALLOC_IF): Define only if needed.
5659 (WORDCHAR_P): Likewise. This one is never needed, but is used
5660 only in a comment talking about a compiler bug, so put inside
5661 the #if 0 of that comment.
5662 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5663 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5664 Remove; unused.
19ed5445 5665
1f3561e4 5666 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
5667 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5668 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 5669
ded6f8f7
PE
5670 * search.c (simple_search): Remove unused var.
5671
dbd37a95
PE
5672 * dired.c (compile_pattern): Move decl from here ...
5673 * lisp.h: ... to here, so that it can be checked.
5674 (struct re_registers): New forward decl.
5675
7e47afad
PE
5676 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5677
85f24f61
PE
5678 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5679 All uses changed.
5680 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5681 Rename locals to avoid shadowing.
5671df8f 5682 (Fvertical_motion): Mark locals as initialized.
85f24f61 5683
181aa2be 5684 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 5685 (casify_region): Mark local as initialized.
181aa2be 5686
930d429c
PE
5687 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5688
7082eac6
PE
5689 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5690 New macros, so that the caller can use some names other than
5691 gcpro1, gcpro2, etc.
5692 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5693 of the new macros.
5694 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5695 argument, for consistency with GCPRO2_VAR, etc: it is now the
5696 prefix of the variable, not the variable itself. All uses
5697 changed.
38b2c076
PE
5698 * dired.c (directory_files_internal, file_name_completion):
5699 Rename locals to avoid shadowing.
5700
15206ed9
PE
5701 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5702 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5703 dired.c's scmp function, had undefined behavior.
5704 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5705 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5706 * buffer.h: ... to here, because these macros use current_buffer,
5707 and the new implementation with inline functions needs to have
5708 current_buffer in scope now, rather than later when the macros
5709 are used.
5710 (downcase, upcase1): New static inline functions.
5711 (DOWNCASE, UPCASE1): Reimplement using these functions.
5712 This avoids undefined behavior in expressions like
5713 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5714 from race conditions in accessing the global variables
5715 case_temp1 and case_temp2.
5716 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5717 * lisp.h (case_temp1, case_temp2): Remove their decls.
5718 * character.h (ASCII_CHAR_P): Move from here ...
5719 * lisp.h: ... to here, so that the inline functions mentioned
5720 above can use them.
5721
4a6bea26
PE
5722 * dired.c (directory_files_internal_unwind): Now static.
5723
f14b7e14
PE
5724 * fileio.c (file_name_as_directory, directory_file_name):
5725 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5726 Now static.
2893f146
PE
5727 (file_name_as_directory): Use const pointers when appropriate.
5728 (Fexpand_file_name): Likewise. In particular, newdir might
5729 point at constant storage, so make it a const pointer.
fd4ead52 5730 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
5731 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5732 signedness issues.
f839df0c
PE
5733 (Fset_file_times, Finsert_file_contents, auto_save_error):
5734 Rename locals to avoid shadowing.
f14b7e14 5735
5716756e 5736 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
5737 (Ftry_completion, Fall_completions): Rename or remove locals
5738 to avoid shadowing.
5716756e 5739
b4c3046a
PE
5740 * marker.c (bytepos_to_charpos): Remove; unused.
5741
b45db522
PE
5742 * lisp.h (verify_bytepos, count_markers): New decls,
5743 so that gcc does not warn that these functions aren't declared.
5744
85876d07
PE
5745 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5746 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 5747 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 5748 (copy_text): Remove unused local var.
85876d07 5749
03d78a21 5750 * filelock.c (within_one_second): Now static.
b3dd38ab 5751 (lock_file_1): Rename local to avoid shadowing.
03d78a21 5752
5df8f01b
PE
5753 * buffer.c (fix_overlays_before): Mark locals as initialized.
5754 (fix_start_end_in_overlays): Likewise. This function should be
5755 simplified by using pointers-to-pointers, but that's a different
5756 matter.
b1d876f1 5757 (switch_to_buffer_1): Now static.
8f54f30a
PE
5758 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5759 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 5760
a70072c9 5761 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 5762 Fix pointer signedness issue.
edced198
PE
5763 (sys_subshell): Mark local as volatile if checking for lint,
5764 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 5765 (MAXPATHLEN): Define only if needed.
a70072c9 5766
a0977c44
PE
5767 * process.c (serial_open, serial_configure): Move decls from here ...
5768 * systty.h: ... to here, so that they can be checked.
5769
a884fdcc
PE
5770 * fns.c (get_random, seed_random): Move extern decls from here ...
5771 * lisp.h: ... to here, so that they can be checked.
5772
604efe86 5773 * sysdep.c (reset_io): Now static.
b8950c94 5774 (wait_for_termination_signal): Remove; unused.
604efe86 5775
38fc62d9
PE
5776 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5777 (copy_keymap_item, append_key, push_text_char_description):
5778 Now static.
1004a21a 5779 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 5780 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
5781 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5782 (describe_map_tree):
5783 Rename locals to avoid shadowing.
38fc62d9 5784
2f2650da
PE
5785 * keyboard.c: Declare functions static if they are not used elsewhere.
5786 (echo_char, echo_dash, cmd_error, top_level_2):
5787 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
5788 (read_char, kbd_buffer_get_event, make_lispy_position):
5789 (make_lispy_event, make_lispy_movement, apply_modifiers):
5790 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5791 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5792 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 5793 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 5794 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 5795
a053e86c 5796 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
5797 (mark_kboards): Move decl here ...
5798 * alloc.c (mark_kboards): ... from here.
a053e86c 5799
4752793e
PE
5800 * lisp.h (force_auto_save_soon): New decl.
5801
74f10ca7 5802 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
5803 (DEFINE_DUMMY_FUNCTION): New macro.
5804 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5805 Use it.
c03cd23f
PE
5806 (main): Add casts to avoid warnings
5807 if GCC considers string literals to be constants.
74f10ca7 5808
022e70d4
PE
5809 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5810
59d6fe83
PE
5811 * dbusbind.c: Pointer signedness fixes.
5812 (xd_signature, xd_append_arg, xd_initialize):
5813 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5814 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5815 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5816 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5817
78320123
PE
5818 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5819 if GCC considers string literals to be constants.
49cebcca 5820 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 5821
35ac2a97
SM
58222011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5823
fb103ca9
SM
5824 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5825 (print_preprocess, print_object): New macro to fix last change.
5826
35ac2a97
SM
5827 * print.c (print_preprocess): Don't forget font objects.
5828
62973b41
JB
58292011-03-16 Juanma Barranquero <lekktu@gmail.com>
5830
5831 * emacs.c (USAGE3): Doc fixes.
5832
0e48bb22
AS
58332011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5834
5835 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5836 structure.
5837
7684e57b
JB
58382011-03-14 Juanma Barranquero <lekktu@gmail.com>
5839
5840 * lisp.h (VWindow_system, Qfile_name_history):
5841 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5842 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5843 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5844
5845 * w32select.c: Don't #include "keyboard.h".
c96bbc66 5846 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
5847
5848 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5849 * w32console.c (detect_input_pending, read_input_pending)
5850 (encode_terminal_code):
5851 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5852 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5853 (w32_system_caret_y, Qfile_name_history):
5854 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5855 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5856 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5857 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5858 * w32proc.c (Qlocal, report_file_error):
5859 * w32term.c (Vwindow_system, updating_frame):
5860 * w32uniscribe.c (initialized, uniscribe_font_driver):
5861 Remove unneeded extern declarations.
5862
2aa46d6c
CY
58632011-03-14 Chong Yidong <cyd@stupidchicken.com>
5864
c96bbc66 5865 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 5866
cffc6f3b
CY
58672011-03-13 Chong Yidong <cyd@stupidchicken.com>
5868
5869 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
5870 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
5871 These macros can no longer be used for assignment.
5872
44f230aa
SM
5873 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5874 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
5875 (record_buffer_markers, fetch_buffer_markers): New functions for
5876 recording and fetching special buffer markers.
5877 (set_buffer_internal_1, set_buffer_temp): Use them.
5878
5879 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
5880
5881 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
5882
5883 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
5884 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
5885
5886 * xdisp.c (hscroll_window_tree):
5887 (reconsider_clip_changes): Use PT instead of BUF_PT.
5888
d251f04b
EZ
58892011-03-13 Eli Zaretskii <eliz@gnu.org>
5890
5891 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
5892 $(EMACS_ROOT)/lib/intprops.h.
5893
f0c77cd1
PE
58942011-03-13 Paul Eggert <eggert@cs.ucla.edu>
5895
3eca4629
PE
5896 Fix more problems found by GCC 4.5.2's static checks.
5897
7c86ee98
PE
5898 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
5899 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
5900 (xg_free_frame_widgets): Make it clear that a local variable is
5901 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
5902 (gdk_window_get_screen): Make it clear that this macro is needed
5903 only if USE_GTK_TOOLTIP.
1e5524e7
PE
5904 (int_gtk_range_get_value): New function, which avoids a diagnostic
5905 from gcc -Wbad-function-cast.
5906 (xg_set_toolkit_scroll_bar_thumb): Use it.
5907 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
5908 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
5909 (get_utf8_string, xg_get_file_with_chooser):
5910 Rename locals to avoid shadowing.
5911 (create_dialog): Move locals to avoid shadowing.
7c86ee98 5912
41729b81
PE
5913 * xgselect.c (xg_select): Remove unused var.
5914
f0c77cd1
PE
5915 * image.c (four_corners_best): Mark locals as initialized.
5916 (gif_load): Initialize transparent_p to zero (Bug#8238).
5917 Mark another local as initialized.
ec6cf4c6 5918 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 5919
ce0ad53d 5920 * image.c (clear_image_cache): Now static.
d5d5a617 5921 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 5922 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
5923 (x_edge_detection): Remove unnecessary cast that
5924 gcc -Wbad-function-cast diagnoses.
2037898d 5925 (gif_load): Fix pointer signedness.
6ae141d6
PE
5926 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
5927 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 5928
33383987 59292011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 5930
d32df629
PE
5931 Improve quality of tests for time stamp overflow.
5932 For example, without this patch (encode-time 0 0 0 1 1
5933 1152921504606846976) returns the obviously-bogus value (-948597
5934 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
5935 reports time overflow. See
5936 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
5937 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
5938 * editfns.c: Include limits.h and intprops.h.
5939 (TIME_T_MIN, TIME_T_MAX): New macros.
5940 (time_overflow): Move earlier, to before first use.
5941 (hi_time, lo_time): New functions, for an accurate test for
5942 out-of-range times.
5943 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
5944 (Fget_internal_run_time): Don't assume time_t fits in int.
5945 (make_time): Use list2 instead of Fcons twice.
5946 (Fdecode_time): More accurate test for out-of-range times.
5947 (check_tm_member): New function.
5948 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
5949 (lisp_time_argument): Don't rely on undefined left-shift and
5950 right-shift behavior when checking for time stamp overflow.
8be6f318 5951
fe31d94c
PE
5952 * editfns.c (time_overflow): New function, refactoring common code.
5953 (Fformat_time_string, Fdecode_time, Fencode_time):
5954 (Fcurrent_time_string): Use it.
5955
8be6f318
PE
5956 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
5957 * dired.c (make_time): Move to ...
5958 * editfns.c (make_time): ... here.
5959 * systime.h: Note the move.
5960
09d9db2c 59612011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 5962
126bc0dc
YM
5963 * fringe.c (update_window_fringes): Remove unused variables.
5964
c47cbdfd
YM
5965 * unexmacosx.c (copy_data_segment): Also copy __got section.
5966 (Bug#8223)
5967
7ac80be9
EZ
59682011-03-12 Eli Zaretskii <eliz@gnu.org>
5969
c96bbc66 5970 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
5971 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
5972 Constify `char *' arguments and their references according to
5973 prototypes in tparam.h.
5974
ecb0f94d 5975 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 5976
7ac80be9
EZ
5977 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
5978 Adapt all references accordingly.
5979
5980 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
5981
ef1fd07e
TT
59822011-03-11 Tom Tromey <tromey@redhat.com>
5983
5984 * buffer.c (syms_of_buffer): Remove obsolete comment.
5985
7ef4b50c
EZ
59862011-03-11 Eli Zaretskii <eliz@gnu.org>
5987
5988 * termhooks.h (encode_terminal_code): Declare prototype.
5989
5990 * msdos.c (encode_terminal_code): Don't declare prototype.
5991
5992 * term.c (encode_terminal_code): Now external again, used by
5993 w32console.c and msdos.c.
5994
44f230aa
SM
5995 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
5996 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 5997
4b1ec863 59982011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 5999
1714f52b 6000 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 6001
4b1ec863
PE
6002 * fringe.c (update_window_fringes): Mark locals as initialized
6003 (Bug#8227).
6004 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 6005
524c7aa6
PE
6006 * alloc.c (mark_fringe_data): Move decl from here ...
6007 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6008 to check its interface.
6009 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6010
a5c0af81 6011 * fontset.c (free_realized_fontset): Now static.
7519b8cd 6012 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 6013 (fontset_font): Mark local as initialized.
a9a06e0b 6014 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 6015
b4716021
PE
6016 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6017
811e9bac 6018 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 6019 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
6020 (x_own_selection, Fx_disown_selection_internal): Rename locals
6021 to avoid shadowing.
6022 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 6023
7e3ab302
PE
6024 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6025 so that the caller can use some name other than gcpro1.
6026 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
6027 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6028 (Fx_backspace_delete_keys_p):
6029 Use them to avoid shadowing, and rename vars to avoid shadowing.
6030 (x_decode_color, x_set_name, x_window): Now static.
6b437900 6031 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 6032 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
6033 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6034 Remove unused locals.
7e3ab302
PE
6035 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6036 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6037 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6038 macros.
f78faa98 6039
e2b13473
PE
6040 * xterm.h (x_mouse_leave): New decl.
6041
77f23912
PE
6042 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6043 Remove unused functions.
cdf4ba58
PE
6044 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6045 (x_calc_absolute_position): Now static.
7411c686 6046 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 6047 Don't declare local "event" unless it's used.
ed7bf3a5
PE
6048 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6049 unless they are used.
38d0b34a
PE
6050 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6051 (x_fatal_error_signal): Remove; not used.
a6067996
PE
6052 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6053 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6054 (x_error_catcher, x_connection_closed, x_error_handler):
6055 (x_error_quitter, xembed_send_message, x_iconify_frame):
6056 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 6057 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 6058 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 6059
44f230aa
SM
6060 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6061 Rename or move locals to avoid shadowing.
6b463e58 6062 (tty_defined_color, merge_face_heights): Now static.
5967d051 6063 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
6064 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6065 does not deduce is never used uninitialized.
73719eba
PE
6066 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6067 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 6068
426994c3 6069 * terminal.c (store_terminal_param): Now static.
5489860b 6070
032f1620 6071 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 6072 (set_frame_menubar): Remove unused local.
d4323972 6073 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
6074 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6075 since they might point to immutable storage.
281585b0
PE
6076 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6077 since it's unused otherwise.
032f1620 6078
367c19e5 6079 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 6080 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
6081 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6082 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 6083 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
6084 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
6085 does not deduce are never used uninitialized.
70739cbe 6086
07b48fa9
PE
6087 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6088
8868a238 6089 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
6090 * window.c (window_loop, size_window):
6091 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 6092
7e5cf297 6093 * window.c (display_buffer): Now static.
d6550a9f
PE
6094 (size_window): Mark variables that gcc -Wuninitialized
6095 does not deduce are never used uninitialized.
a586633d
PE
6096 * window.h (check_all_windows): New decl, to forestall
6097 gcc -Wmissing-prototypes diagnostic.
5b555da1 6098 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 6099
f6095868
PE
6100 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6101 shadowing.
6102 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
6103 Include <limits.h>.
6104 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6105 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
6106 (load_charset_map): Mark variables that gcc -Wuninitialized
6107 does not deduce are never used uninitialized.
53df7c11 6108 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 6109
f38b440c
PE
6110 * coding.c (coding_set_source, coding_set_destination):
6111 Use "else { /* comment */ }" rather than "else /* comment */;"
6112 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
6113 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6114 a block, when the outer 'i' will do.
6115 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6116 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6117 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6118 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6119 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6120 Rename locals to avoid shadowing.
6121 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
6122 * coding.c (emacs_mule_char, encode_invocation_designation):
6123 Now static, since they're not used elsewhere.
413bb2db 6124 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 6125 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
6126 (decode_coding_emacs_mule): Mark variables that gcc
6127 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
6128 (detect_coding_iso_2022): Initialize a local variable that might
6129 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 6130 this initialization is needed. (Bug#8211)
5f58e762
PE
6131 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6132 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6133 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6134 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6135 Remove unused macros.
f38b440c 6136
232b38b9 6137 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 6138 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 6139 * character.c (string_count_byte8): Likewise.
232b38b9 6140
fb90da1b
PE
6141 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6142 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6143
fb93dbc2
PE
6144 * chartab.c (copy_sub_char_table): Now static, since it's not used
6145 elsewhere.
5c156ace
PE
6146 (sub_char_table_ref_and_range, char_table_ref_and_range):
6147 Rename locals to avoid shadowing.
bbcd0949 6148 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 6149
7d3b3862 6150 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 6151 (BIDI_BOB): Remove unused macro.
7d3b3862 6152
6be7d3da
PE
6153 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6154 deduce are never used uninitialized.
c2ed9c8b 6155 * term.c (encode_terminal_code): Likewise.
6be7d3da 6156
75f8807f 6157 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 6158
50938595
PE
6159 * tparam.h: New file.
6160 * term.c, tparam.h: Include it.
6161 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6162 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6163 Move these decls to tparam.h, and make them agree with what
6164 is actually in tparam.c. The previous trick of using incompatible
6165 decls in different modules does not conform to the C standard.
6166 All callers of tparam changed to use tparam's actual API.
6167 * tparam.c (tparam1, tparam, tgoto):
6168 Use const pointers where appropriate.
6169
fbceeba2
PE
6170 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6171 * cm.h (struct cm): Likewise.
6172 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6173 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6174 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6175 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6176 (turn_on_face, init_tty): Likewise.
6177 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 6178
7f3f1250
PE
6179 * term.c (term_mouse_position): Rename local to avoid shadowing.
6180
e6ca6543
PE
6181 * alloc.c (mark_ttys): Move decl from here ...
6182 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6183
c40f8d15
AS
61842011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6185
6186 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6187
cfe0661d
JB
61882011-03-09 Juanma Barranquero <lekktu@gmail.com>
6189
6190 * search.c (compile_pattern_1): Remove argument regp, unused since
6191 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6192 (compile_pattern): Don't pass it.
6193
0afb4571
J
61942011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6195
6196 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6197 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6198 for ! HAVE_GTK3.
6199 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6200
6201 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6202
6203 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6204 gdk_window_get_screen, gdk_window_get_geometry,
6205 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6206 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6207 (xg_get_pixbuf_from_pixmap): New function.
6208 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6209 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6210 Call xg_get_pixbuf_from_pixmap instead of
6211 gdk_pixbuf_get_from_drawable.
6212 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6213 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6214 (xg_check_special_colors): Use GtkStyleContext and its functions
6215 for HAVE_GTK3.
6216 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6217 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6218 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
6219 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6220 Call gtk_widget_get_preferred_size.
0afb4571
J
6221 (xg_frame_resized): gdk_window_get_geometry only takes 5
6222 parameters.
44f230aa
SM
6223 (xg_win_to_widget, xg_event_is_for_menubar):
6224 Call gdk_x11_window_lookup_for_display.
0afb4571
J
6225 (xg_set_widget_bg): New function.
6226 (delete_cb): New function.
895009e1 6227 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
6228 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6229 (xg_set_background_color): Call xg_set_widget_bg.
6230 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6231 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6232 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6233 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6234 if ! HAVE_GTK3.
6235 (update_frame_tool_bar): Call gtk_widget_hide.
6236 (xg_initialize): Use GDK_KEY_g.
6237
6238 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6239 if ! HAVE_GTK3
6240 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6241
6242 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6243 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6244 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6245
1c2cc4ef
JB
62462011-03-08 Juanma Barranquero <lekktu@gmail.com>
6247
6248 * w32xfns.c (select_palette): Check success of RealizePalette against
6249 GDI_ERROR, not zero.
6250
33383987 6251See ChangeLog.11 for earlier changes.
aac0c6e3
MR
6252
6253;; Local Variables:
6254;; coding: utf-8
aac0c6e3
MR
6255;; End:
6256
33383987 6257 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
6258
6259 This file is part of GNU Emacs.
6260
6261 GNU Emacs is free software: you can redistribute it and/or modify
6262 it under the terms of the GNU General Public License as published by
6263 the Free Software Foundation, either version 3 of the License, or
6264 (at your option) any later version.
6265
6266 GNU Emacs is distributed in the hope that it will be useful,
6267 but WITHOUT ANY WARRANTY; without even the implied warranty of
6268 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6269 GNU General Public License for more details.
6270
6271 You should have received a copy of the GNU General Public License
6272 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.